1 2010-06-29 Marek Safar <marek.safar@gmail.com>
3 * import.cs: Operators must have between 1 and 2 parameters.
5 * method.cs: Switch destructor to direct membercache lookup
7 2010-06-29 Marek Safar <marek.safar@gmail.com>
9 * driver.cs, expression.cs: Use Membercache for StringConcat when
10 it got all what is needed.
12 2010-06-29 Marek Safar <marek.safar@gmail.com>
14 * membercache.cs, expression.cs, statement.cs, doc.cs, ecore.cs:
15 Changed FindMembers to allocate a new list only when a filter is
16 used. Saves decent chunk of memory and should save even more in the
17 future when the filter is not used that often.
19 2010-06-28 Marek Safar <marek.safar@gmail.com>
21 * field.cs, property.cs, assign.cs, const.cs, expression.cs,
22 ecore.cs, class.cs, cs-parser.jay, enum.cs: Don't use intermediate
23 structure for simple type fields (saves memory and makes few things
24 simpler). Clean up some hacks mostly for events.
26 2010-06-25 Marek Safar <marek.safar@gmail.com>
28 * statement.cs, cs-parser.jay: Don't create expensive block for
31 2010-06-24 Marek Safar <marek.safar@gmail.com>
33 * statement.cs, report.cs: Rethrow internal error when reporting is
36 * ecore.cs: Check for identical name only when simple name is set.
39 2010-06-24 Marek Safar <marek.safar@gmail.com>
42 * generic.cs, expression.cs, ecore.cs: Added a new type expression
43 for open generic type to pass unbound type arguments to typeof
46 2010-06-24 Marek Safar <marek.safar@gmail.com>
48 * statement.cs: Foreach collection implementation refactoring to
49 search for GetEnumerator more preciselly. Fixes #431453 and more
52 * linq.cs, decl.cs, ecore.cs, delegate.cs: Update methodgroup api.
54 2010-06-23 Marek Safar <marek.safar@gmail.com>
56 * cs-parser.jay: Track more locations.
58 2010-06-22 Marek Safar <marek.safar@gmail.com>
60 * cs-tokenizer.cs, location.cs, cs-parser.jay: Track more locations.
62 2010-06-18 Marek Safar <marek.safar@gmail.com>
64 * cs-tokenizer.cs, anonymous.cs, expression.cs, statement.cs,
65 support.cs, location.cs, cs-parser.jay: Some work on full ast mode.
67 2010-06-18 Marek Safar <marek.safar@gmail.com>
69 * convert.cs, typespec.cs, method.cs: Fixed few more dynamic
72 2010-06-18 Marek Safar <marek.safar@gmail.com>
74 * typemanager.cs, namespace.cs: Report more predefined types and
75 imported types collision types as a warning.
76 Fixes #537414, #601157
78 2010-06-18 Marek Safar <marek.safar@gmail.com>
80 * generic.cs: Overrides base method constraint can use method type
83 * import.cs: Removed redundant cache.
85 2010-06-17 Marek Safar <marek.safar@gmail.com>
87 * generic.cs: Propagate type only inflate downwards.
89 2010-06-17 Marek Safar <marek.safar@gmail.com>
92 * method.cs: Do not reject binary dynamic operators.
94 2010-06-17 Marek Safar <marek.safar@gmail.com>
96 * typespec.cs: Internal types have no generic parameters.
99 2010-06-17 Marek Safar <marek.safar@gmail.com>
101 A fix for bug #614955
102 * cs-parser.jay: Correctly set expression mode for default parameter
105 2010-06-17 Marek Safar <marek.safar@gmail.com>
107 A fix for bug #615023
108 * ecore.cs: Resolve dynamic namespace and keyword collision in the
109 favour of the keyword.
111 2010-06-17 Marek Safar <marek.safar@gmail.com>
113 A fix for bug #614917
114 * convert.cs: Allow more undocumented 0 like values to enum type
117 2010-06-17 Marek Safar <marek.safar@gmail.com>
119 * generic.cs, method.cs: Inflate copied type parameters from base
120 class or explicit interfaces.
122 * convert.cs: Fixed conversion between two type parameters.
125 2010-06-16 Marek Safar <marek.safar@gmail.com>
127 * membercache.cs, convert.cs: Correctly resize an array used by
130 2010-06-15 Marek Safar <marek.safar@gmail.com>
132 A fix for bug #599601
133 * dynamic.cs, ecore.cs: A new flag for dynamic resolver to ignore
134 generated member access left expression.
136 2010-06-16 Marek Safar <marek.safar@gmail.com>
138 * expression.cs: Dispatch dynamic invocation solely on left
141 2010-06-16 Marek Safar <marek.safar@gmail.com>
143 * expression.cs, statement.cs: Always persist explicit cast
144 semantic at expression level.
146 2010-06-15 Marek Safar <marek.safar@gmail.com>
148 * expression.cs, attribute.cs: Enable generic type parameters
151 2010-06-15 Marek Safar <marek.safar@gmail.com>
153 A fix for bug #612146
154 * generic.cs: Don't use fixed array for inflated type parameter
155 interface constraints.
157 2010-06-15 Marek Safar <marek.safar@gmail.com>
159 * typespec.cs: ElementTypeSpec has to use its own ITypeDefinition.
161 * report.cs: Unwrap elements for related symbols reporting.
163 2010-06-15 Marek Safar <marek.safar@gmail.com>
165 A fix for bug #612796
166 * cs-tokenizer.cs: Offset correctly keywords the first character
169 2010-06-15 Marek Safar <marek.safar@gmail.com>
171 A fix for bug #613397
172 * expression.cs: Removed too aggressive object initializers
175 2010-06-15 Marek Safar <marek.safar@gmail.com>
177 * parameter.cs, property.cs, membercache.cs, decl.cs, iterators.cs,
178 anonymous.cs, expression.cs, support.cs, method.cs, pending.cs,
179 class.cs, cs-parser.jay: Simplify parsing of accessors by removing
180 any intermediate steps and fake nodes, also saves few MBs of memory.
182 2010-06-11 Marek Safar <marek.safar@gmail.com>
184 * modifiers.cs, rootcontext.cs, location.cs, cs-parser.jay: More
185 precise modifiers parsing.
187 2010-06-09 Marek Safar <marek.safar@gmail.com>
189 * cs-tokenizer.cs, anonymous.cs, expression.cs, cs-parser.jay:
190 Fixed few shift/reduce conflicts.
192 2010-06-09 Marek Safar <marek.safar@gmail.com>
194 * typemanager.cs, parameter.cs, dynamic.cs, typespec.cs,
195 expression.cs, ecore.cs, cs-parser.jay: Fully parse composed type
196 specifiers and stop using string in AST.
198 2010-06-07 Marek Safar <marek.safar@gmail.com>
200 * typemanager.cs, eval.cs, iterators.cs, anonymous.cs, expression.cs
201 method.cs, class.cs, delegate.cs, cs-parser.jay, driver.cs, visit.cs
202 enum.cs: Hold location of predefined types.
204 2010-06-07 Marek Safar <marek.safar@gmail.com>
206 A fix for bug #610878
207 * pending.cs: Clone cached list before modifying.
209 2010-06-04 Marek Safar <marek.safar@gmail.com>
211 * convert.cs, typespec.cs, expression.cs: Start using array member
212 kind for better conversion checks.
214 * import.cs, report.cs: Report better error message for runtime
217 2010-06-04 Marek Safar <marek.safar@gmail.com>
219 * membercache.cs, convert.cs, nullable.cs, expression.cs: Optimize
220 user defined conversion probing and simplify user conversion for
221 nullabe types. Fixes #610940.
223 2010-06-03 Marek Safar <marek.safar@gmail.com>
225 A fix for bug #610919
226 * parameter.cs, property.cs, cs-parser.jay: Use independent implicit
227 parameters for explicit event accessors. Anonymous method capturing
228 won't otherwise work for event implicit parameter.
230 2010-06-02 Marek Safar <marek.safar@gmail.com>
232 A fix for bug #610088
233 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs:
234 Ignore overrides for base overload resolution as for non-base
235 expressions and convert the best candidate to closest override
238 2010-06-01 Marek Safar <marek.safar@gmail.com>
240 A fix for bug #610139
241 * generic.cs, convert.cs: Recursively check effective base interface
243 2010-06-01 Marek Safar <marek.safar@gmail.com>
245 * statement.cs: Handle nullable types and type parameters in using
246 statement, avoid boxing value types. Also fixes #571010
248 2010-06-01 Marek Safar <marek.safar@gmail.com>
250 * convert.cs, expression.cs: Emit unbox for underlying nullable
253 2010-05-29 Marek Safar <marek.safar@gmail.com>
255 A fix for bug #610126
256 * expression.cs: Don't use branch optimization for types bigger than
259 2010-05-28 Marek Safar <marek.safar@gmail.com>
261 A fix for bug #609088
262 * import.cs: Check private modifier correctly.
264 2010-05-28 Marek Safar <marek.safar@gmail.com>
266 A fix for bug #609049
267 * ecore.cs: Don't ignore override methods when looking for base
270 2010-05-27 Marek Safar <marek.safar@gmail.com>
272 A fix for bugs #608007, #572540, #566130, #476358
274 * generic.cs, linq.cs, expression.cs, statement.cs, cs-parser.jay:
275 More tricky refactoring of implicit linq blocks.
277 2010-05-25 Marek Safar <marek.safar@gmail.com>
279 * linq.cs, cs-parser.jay: Keep location for all linq clauses.
281 2010-05-25 Marek Safar <marek.safar@gmail.com>
283 * context.cs, expression.cs, cs-parser.jay: Don't store current
284 block in This expression (it's too early for linq blocks).
286 2010-05-21 Marek Safar <marek.safar@gmail.com>
288 * expression.cs: Use constrained prefix more broadly to avoid boxing.
290 2010-05-20 Marek Safar <marek.safar@gmail.com>
292 A fix for bug #591149
293 * nullable.cs: Don't double wrap same expression.
295 2010-05-20 Marek Safar <marek.safar@gmail.com>
297 A fix for bug #569827
298 * anonymous.cs: Any issued error in probing mode means no match.
300 2010-05-20 Marek Safar <marek.safar@gmail.com>
302 * expression.cs: Search for base indexer using the closest match
305 2010-05-20 Marek Safar <marek.safar@gmail.com>
307 A fix for bug #572071
308 * method.cs: Set override constraints using unexpanded interface
311 2010-05-20 Marek Safar <marek.safar@gmail.com>
313 A fix for bug #572071
314 * ecore.cs: Include secondary extension method lookup in probing
317 2010-05-19 Marek Safar <marek.safar@gmail.com>
319 A fix for bug #515801
320 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
323 2010-05-19 Marek Safar <marek.safar@gmail.com>
325 A fix for bug #515801
326 * pending.cs: Advance counter correctly.
328 2010-05-19 Marek Safar <marek.safar@gmail.com>
330 A fix for bug #480139
331 * method.cs, pending.cs: Indexer override uses base name.
333 2010-05-19 Marek Safar <marek.safar@gmail.com>
335 A fix for bug #424064
336 * generic.cs: Replace original with inflated type parameter on
339 2010-05-19 Marek Safar <marek.safar@gmail.com>
341 A fix for bug #359733
342 * parameter.cs: Extension attribute can be defined in each assembly.
344 2010-05-18 Marek Safar <marek.safar@gmail.com>
346 A fix for bug #446507
347 * method.cs: Only one method can implement an interface.
349 2010-05-18 Marek Safar <marek.safar@gmail.com>
351 A fix for bug #594905
352 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
353 Typed null can be used as a source for expression methods.
355 2010-05-18 Marek Safar <marek.safar@gmail.com>
357 A fix for bug #606551
358 * namespace.cs: Using directive imports only types and not nested
361 2010-05-17 Marek Safar <marek.safar@gmail.com>
363 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
364 delegate.cs: Member instance is resolved after member overload
365 definitely resolves static/instance property of member expression.
366 Fixes #545047, #358848, #456605, #460016, #603299
368 2010-05-12 Marek Safar <marek.safar@gmail.com>
370 A fix for bug #604981
371 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
372 details for nested anonymous methods stories.
374 2010-05-11 Marek Safar <marek.safar@gmail.com>
376 A fix for bug #604735
377 * namespace.cs: Don't report namespace collision.
379 2010-05-11 Marek Safar <marek.safar@gmail.com>
381 A fix for bug #604748
382 * class.cs, typespec.cs: Search full imported attribute hierarchy
385 2010-05-11 Marek Safar <marek.safar@gmail.com>
387 * namespace.cs: Ignore missing dependencies failure at
390 2010-05-11 Marek Safar <marek.safar@gmail.com>
392 A fix for bug #604640
393 * namespace.cs: Don't resolve using constraints too early.
395 2010-05-11 Marek Safar <marek.safar@gmail.com>
397 A fix for bug #604239
398 * generic.cs: Copy partial type constraints to partial container.
400 2010-05-10 Marek Safar <marek.safar@gmail.com>
402 A fix for bug #557210
403 * import.cs: Relax underlying enum field rules.
405 2010-05-10 Marek Safar <marek.safar@gmail.com>
407 A fix for bug #603476
408 * property.cs: Implement IParametersMember for indexer accessors.
410 2010-05-07 Marek Safar <marek.safar@gmail.com>
412 A fix for bug #601141
413 * class.cs: Update all partial modifiers.
415 2010-05-06 Marek Safar <marek.safar@gmail.com>
417 A fix for bug #601708
418 * method.cs, membercache.cs: Destructors cannot be hidden.
420 2010-05-06 Marek Safar <marek.safar@gmail.com>
422 A fix for bug #602551
423 * class.cs: Resursive reference of type definition is allowed.
425 2010-05-06 Marek Safar <marek.safar@gmail.com>
427 * anonymous.cs: Mutate cached storey instance types too.
429 2010-05-06 Marek Safar <marek.safar@gmail.com>
431 A fix for bug #602443
432 * convert.cs: Explicit enum conversion cannot involve user operators
434 2010-05-05 Miguel de Icaza <miguel@novell.com>
436 * class.cs (TypeContainer.DefineBaseTypes)
437 (TypeContainer.CheckRecursiveDefinition): check for the iface not
438 being null, as we could have failed resolution and crashed;
441 * cs-parser.jay: Productions to catch common mistakes when other
442 punctuation operators are used instead of comma. Fixes 571702
444 2010-05-05 Marek Safar <marek.safar@gmail.com>
446 * anonymous.cs: Mutate correct set of constraints.
448 2010-05-05 Marek Safar <marek.safar@gmail.com>
450 A fix for bug #602842
451 * expression.cs: Resolve all array bound arguments.
453 2010-05-05 Marek Safar <marek.safar@gmail.com>
455 * import.cs: Don't import private fields.
457 2010-04-30 Marek Safar <marek.safar@gmail.com>
459 Partially based on patch by <sami.lamti@gmail.com>
461 * eval.cs, ecore.cs: Fixed eval show methods.
463 2010-04-30 Marek Safar <marek.safar@gmail.com>
465 * generic.cs, delegate.cs: Implement output type inference of
466 methodgroup now when the specification was cleared at least little
469 2010-04-29 Marek Safar <marek.safar@gmail.com>
471 A fix for bug #575611
472 * class.cs: Fix recursive unmanaged recursice sruct check.
474 2010-04-29 Marek Safar <marek.safar@gmail.com>
476 A fix for bug #479776
477 * expression.cs: Implement typeof unbounded nested generic types.
479 2010-04-29 Marek Safar <marek.safar@gmail.com>
481 A fix for bug #474953
482 * class.cs: Fix valid recursive base type definition.
484 2010-04-29 Marek Safar <marek.safar@gmail.com>
486 A fix for bug #421737
487 * convert.cs, expression.cs: A boxing conversion exists from a
488 nullable-type to a reference type, if a boxing conversion exists
489 from the underlying non-nullable-value-type to the reference type.
491 2010-04-29 Marek Safar <marek.safar@gmail.com>
493 A fix for bug #376875
494 * import.cs: Import volatile modifier.
496 2010-04-29 Marek Safar <marek.safar@gmail.com>
498 A fix for bug #372412
499 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
502 2010-04-29 Marek Safar <marek.safar@gmail.com>
504 A fix for bug #568955
505 * statements.cs: Handle recursive scope initializers.
507 2010-04-28 Marek Safar <marek.safar@gmail.com>
509 A fix for bug #566511
510 * anonymous.cs: Always get inflated version of hoisted variable
511 on generic type definition.
513 2010-04-28 Marek Safar <marek.safar@gmail.com>
515 * import.cs, membercache.cs: Relax rules for valid properties.
517 2010-04-28 Marek Safar <marek.safar@gmail.com>
519 * import.cs: Intern arrays used in generic arguments.
521 2010-04-28 Marek Safar <marek.safar@gmail.com>
523 A fix for bug #600398
524 * convert.cs: Actually use effective base type for the comparison.
526 2010-04-28 Marek Safar <marek.safar@gmail.com>
528 A fix for bug #600326
529 * ecore.cs: Pass arity to base member lookup.
531 2010-04-28 Marek Safar <marek.safar@gmail.com>
533 A fix for bug #573385
534 * expression.cs: MemberAccess is of generic type based on right
537 2010-05-28 Marek Safar <marek.safar@gmail.com>
539 * cs-tokenizer.cs: Made tab size configurable.
541 2010-05-27 Marek Safar <marek.safar@gmail.com>
543 * attribute.cs: Ensure Obsolete members are defined before doing
546 2010-05-27 Marek Safar <marek.safar@gmail.com>
548 * visit.cs: Add DOM visitor skeleton.
552 2010-05-27 Marek Safar <marek.safar@gmail.com>
554 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
556 2010-05-27 Marek Safar <marek.safar@gmail.com>
558 * *.cs: Major rewrite of compiler internals to better work with
559 unmodified System.Reflection.Emit. Some of the key changes are
560 - TypeSpec replaces reflection specific System.Type.
561 - All Type(TypeSpec) operations are now done in compiler therefore
562 no dependency on SRE to inflate generic members and types or to
563 query unclosed types.
564 - MemberCache is now the only and full hierarchical topology.
565 - Generic constraints are implemented properly.
566 - And as a bonus compilation is on average 30% faster.
568 2010-04-15 Jb Evain <jbevain@novell.com>
570 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
572 2010-04-12 Marek Safar <marek.safar@gmail.com>
574 * expression.cs, attribute.cs, parameter.cs: More attribute type
577 2010-04-12 Marek Safar <marek.safar@gmail.com>
579 A fix for bug #593342
581 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
582 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
583 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
584 codegen.cs: Add custom attribute encoder to deal with unfinished
585 types and easier corlib bootstrap from its own types.
587 2010-03-26 Marek Safar <marek.safar@gmail.com>
589 * cs-parser.jay: Report invalid constraint types.
591 2010-03-16 Jb Evain <jbevain@novell.com>
593 * Makefile: rename the net_2_1 profile to moonlight.
595 2010-03-11 Marek Safar <marek.safar@gmail.com>
597 * statement.cs, cs-parser.jay: Use correct location for empty
600 2010-03-11 Marek Safar <marek.safar@gmail.com>
602 * cs-parser.jay: Disable Location from expression.
604 * generic.cs: Check constraints for overrides in the parser.
606 2010-03-09 Marek Safar <marek.safar@gmail.com>
608 * cs-parser.jay (GetLocation): Use an expression when available.
610 2010-03-04 Marek Safar <marek.safar@gmail.com>
612 A fix for bug #582579
613 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
615 2010-03-04 Marek Safar <marek.safar@gmail.com>
617 A patch by kornelpal@gmail.com
619 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
620 compiler generated classes sealed by default. Emit and close top
621 level compiler generated classes as well.
623 * support.cs: Use RuntimeHelpers.GetHashCode.
625 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
627 * Makefile: We need to use the internal bootstrapping gmcs for
628 net_2_1_bootstrap too now.
630 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
632 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
634 2010-03-02 Marek Safar <marek.safar@gmail.com>
636 * cs-tokenizer.cs: Missed few locations in previous fix.
638 2010-03-02 Marek Safar <marek.safar@gmail.com>
640 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
641 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
642 Report correct location for operator errors.
644 2010-03-02 Marek Safar <marek.safar@gmail.com>
646 * typemanager.cs (IsDynamicType): Don't check external types when
647 the attribute is not external.
649 2010-02-24 Marek Safar <marek.safar@gmail.com>
651 A fix for bug #582579
652 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
655 2010-02-24 Marek Safar <marek.safar@gmail.com>
657 A fix for bug #581804
658 * ecore.cs: Fixed type comparison.
660 2010-02-08 Miguel de Icaza <miguel@novell.com>
662 * namespace.cs (CompletionGetTypesStartingWith): Do not include
663 private types in the completion results.
665 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
668 2010-02-17 Marek Safar <marek.safar@gmail.com>
670 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
673 2010-02-14 Miguel de Icaza <miguel@novell.com>
675 * eval.cs: Do not do the report printer dance unless the user has
676 set the DescribeTypes feature.
678 2010-02-10 Marek Safar <marek.safar@gmail.com>
680 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
682 2010-02-08 Marek Safar <marek.safar@gmail.com>
684 A fix for bug #577029
685 * anonymous.cs: Fixed TypeBuilder* check.
687 2010-02-06 Miguel de Icaza <miguel@novell.com>
689 * eval.cs (CompileBlock): Also undo if there are problems during
690 semantic analysis, fixes various cases where invalid C# code would
691 be reported, but the internal changes would not be undone.
693 2010-02-03 Miguel de Icaza <miguel@novell.com>
695 * driver.cs: Change the --fatal flag to allow a number to be
696 passed, this ignores the first N fatal errors. Useful to debug
697 errors that do not happen on the first hit.
699 * cs-parser.jay (invocation_expression): accept both the
700 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
701 inside an invocation.
703 * driver.cs: Expose FatalErrors.
705 * eval.cs: Initialize the printer's Fatal property from the
706 Driver's FatalError flag, this allows csharp --fatal to work
709 Add support for calling Describe (typeof (TYPE)) if the expression
712 2010-02-02 Marek Safar <marek.safar@gmail.com>
714 A fix for bug #574991
715 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
718 2010-02-02 Marek Safar <marek.safar@gmail.com>
720 A fix for bug #575986
721 * expression.cs: Don't mutate typeof type definitions.
723 2010-01-28 Marek Safar <marek.safar@gmail.com>
725 * decl.cs: Use only one set of modifiers.
727 2010-01-26 Marek Safar <marek.safar@gmail.com>
729 A fix for bug #573329
730 * eval.cs: Don't disable error reporting completely on silent mode.
732 2010-01-25 Marek Safar <marek.safar@gmail.com>
734 A fix for bug #573312
735 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
736 pointer index of unknown size types greater than 2.
738 2010-01-15 Marek Safar <marek.safar@gmail.com>
740 * *.cs: Use only 1 member kind enum.
742 2010-01-15 Marek Safar <marek.safar@gmail.com>
744 * *.cs: Add event specification.
746 2010-01-14 Marek Safar <marek.safar@gmail.com>
748 * membercache.cs: Extracted from decl.cs.
750 * *.cs: Put more infrastructure in place.
752 2010-01-13 Marek Safar <marek.safar@gmail.com>
754 * *.cs: Add property specification, unused yet.
756 2010-01-13 Marek Safar <marek.safar@gmail.com>
758 * property.cs: Move all property based declarations into a new file.
760 2010-01-13 Marek Safar <marek.safar at gmail.com>
762 * expression.cs (Conditional): Resolve reduced expression.
764 2010-01-13 Marek Safar <marek.safar at gmail.com>
766 * *.cs: Introduced non-generic method specification.
768 2010-01-07 Marek Safar <marek.safar@gmail.com>
770 * method.cs: Move all method based declarations into a new file.
772 2010-01-07 Marek Safar <marek.safar@gmail.com>
774 * *.cs: Extract field specification.
776 2009-12-17 Marek Safar <marek.safar@gmail.com>
778 * field.cs: Extracted from class.cs
780 2009-12-15 Marek Safar <marek.safar@gmail.com>
782 * attribute.cs (GetFixedBuffer): Work on field definition only.
784 2009-12-15 Marek Safar <marek.safar@gmail.com>
786 * *.cs: Clean up NET_4_0 conditional where possible.
788 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
790 support.cs (DynamicType): Assembly property returns the assembly builder.
791 This is required due to how compiler context works in corlib.
793 2009-12-14 Marek Safar <marek.safar@gmail.com>
795 A fix for bug #564376
796 * assign.cs (LocalTemporary): Removed no longer needed special
799 2009-12-11 Marek Safar <marek.safar@gmail.com>
801 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
802 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
803 enum for easier debugging.
805 2009-12-10 Marek Safar <marek.safar@gmail.com>
807 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
810 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
813 2009-12-10 Marek Safar <marek.safar@gmail.com>
815 * cs-parser.jay, statement.cs: Handle parser error in code
818 2009-12-10 Marek Safar <marek.safar@gmail.com>
820 * ecore.cs: Ignore base imported methods when they are already
823 * eval.cs: Handle non-existent keys.
825 * report.cs, driver.cs: Make fatal work with console printer only.
827 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
829 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
831 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
833 * typemanager.cs: Add MakeGenericMethod that checks if the method
834 is really the generic method definition.
836 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
837 to inflate generic methods.
839 2009-12-08 Marek Safar <marek.safar@gmail.com>
841 A fix for bug #561149
842 * anonymous.cs: Use actual type parameters when checking for generic
845 2009-12-08 Marek Safar <marek.safar@gmail.com>
847 A fix for bug #561369
848 * expression.cs (DoNumericPromotion): Fixed typo.
850 2009-12-08 Marek Safar <marek.safar@gmail.com>
852 *.cs: Moving to generics world.
854 cs-parser.jay: Removed current_array_type.
856 2009-12-07 Marek Safar <marek.safar@gmail.com>
858 *.cs: Moving to generics world.
860 2009-12-04 Marek Safar <marek.safar@gmail.com>
862 *.cs: Moving to generics world (day 2).
864 2009-12-03 Marek Safar <marek.safar@gmail.com>
866 *.cs: Moving to generics world.
868 2009-12-02 Marek Safar <marek.safar@gmail.com>
870 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
871 Encode dynamic type attribute for elements where attributes cannot
874 2009-12-01 Marek Safar <marek.safar@gmail.com>
876 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
879 2009-12-01 Marek Safar <marek.safar@gmail.com>
881 A fix for bug #360455
882 * class.cs: Never report a unused warning for generic events to
883 workaround wrong expression type.
885 2009-11-30 Marek Safar <marek.safar@gmail.com>
887 A fix for bug #558305
888 * decl.cs, class.cs: Check partial method definitions using correct
891 2009-11-30 Marek Safar <marek.safar@gmail.com>
893 * argument.cs: Don't cache rarely used dynamic flag.
895 2009-11-27 Marek Safar <marek.safar@gmail.com>
897 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
899 2009-11-27 Marek Safar <marek.safar@gmail.com>
901 * ecore.cs (SimpleName): Removed no longer needed in_transit as
902 Resolve is now non-reentrant (saves ~0.6MB for corlib).
904 2009-11-26 Marek Safar <marek.safar@gmail.com>
906 A fix for bug #545081
907 * decl.cs: Check private nested types of nested types recursively.
909 2009-11-26 Marek Safar <marek.safar@gmail.com>
911 A fix for bug #558305
912 * location.cs: Ignore self referencing #line directive
914 2009-11-26 Marek Safar <marek.safar@gmail.com>
916 A fix for bug #558292
917 * class.cs: Allow single unsafe fixed buffer fields.
919 2009-11-26 Marek Safar <marek.safar@gmail.com>
921 * expression: Optimize few more zero-based operations.
923 2009-11-26 Marek Safar <marek.safar@gmail.com>
925 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
926 avoids boxing of literal values.
928 2009-11-26 Marek Safar <marek.safar@gmail.com>
930 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
931 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
932 codegen.cs: LocatedToken redesing to avoid excessive allocation and
933 boxing (saves ~7MB for corlib). Also fixes presise token location.
935 2009-11-25 Marek Safar <marek.safar@gmail.com>
937 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
940 2009-11-24 Marek Safar <marek.safar@gmail.com>
942 * expression.cs: Lower static array initializer barrier.
944 * support.cs, driver.cs: Share reader buffer.
946 2009-11-23 Marek Safar <marek.safar@gmail.com>
948 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
950 2009-11-23 Marek Safar <marek.safar@gmail.com>
952 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
953 cleanup some obsolete code.
955 2009-11-20 Marek Safar <marek.safar@gmail.com>
957 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
960 2009-11-20 Marek Safar <marek.safar@gmail.com>
962 * *.cs: Resolved expressions are never resolved again, this helps to
963 uncover some not easy to find bugs and improve the performance.
965 2009-11-19 Marek Safar <marek.safar@gmail.com>
967 * *.cs: Made constant expressions fully compatible with any other
970 2009-11-19 Marek Safar <marek.safar@gmail.com>
972 * *.cs: DoResolve is a worker method and has to be protected.
974 2009-11-18 Marek Safar <marek.safar@gmail.com>
976 * *.cs: More context specific handling.
978 2009-11-17 Marek Safar <marek.safar@gmail.com>
980 * *.cs: More context specific handling.
982 2009-11-16 Marek Safar <marek.safar@gmail.com>
984 * dynamic.cs, class.cs: Removed few fixed user types conversions.
986 * symbolwriter.cs: Uses public ILOffset.
988 2009-11-13 Marek Safar <marek.safar@gmail.com>
990 A fix for bug #553650
991 * generic.cs: Another missing TypeToCoreType, still too many to fix.
993 2009-11-13 Marek Safar <marek.safar@gmail.com>
995 A fix for bug #555170
997 * class.cs, delegate.cs, enum.cs: Constants have to be available
998 for parameters resolve.
1000 2009-11-12 Marek Safar <marek.safar@gmail.com>
1002 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
1005 2009-11-12 Marek Safar <marek.safar@gmail.com>
1007 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
1008 with a statically known candidate set.
1010 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
1012 * generic.cs: Made type inflation for generic constraint checks
1013 recursive. This fixes BGO #553655.
1015 2009-11-11 Marek Safar <marek.safar@gmail.com>
1017 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
1020 2009-11-10 Marek Safar <marek.safar@gmail.com>
1022 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
1023 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
1024 attribute.cs: Add some dynamic error checking.
1026 2009-11-07 Marek Safar <marek.safar@gmail.com>
1028 A fix for bug #553465
1030 * expression.cs: Fixed mixed version of expression tree anonymous
1033 2009-11-06 Marek Safar <marek.safar@gmail.com>
1035 A fix for bug #553031
1037 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
1038 expression tree version of anonymous type with members declaration.
1040 2009-11-05 Marek Safar <marek.safar@gmail.com>
1042 * parameter.cs: Handle nullable parameter default expression.
1044 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
1045 class.cs, attribute.cs: Check for wrong dynamic arguments.
1047 2009-11-05 Marek Safar <marek.safar@gmail.com>
1049 * statement.cs: Dynamic statements.
1051 2009-11-04 Marek Safar <marek.safar@gmail.com>
1053 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
1054 Compound assignments over dynamic type.
1056 2009-11-03 Marek Safar <marek.safar@gmail.com>
1058 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
1059 constructor arguments.
1061 2009-10-30 Marek Safar <marek.safar@gmail.com>
1063 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
1064 codegen.cs: Unary mutator on dynamic member access expression.
1066 2009-10-29 Marek Safar <marek.safar@gmail.com>
1068 A fix for bug #550580
1069 * convert.cs: Don't eliminate explicit precission casts.
1071 2009-10-28 Marek Safar <marek.safar@gmail.com>
1073 A fix for bug #550404
1075 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
1076 expression.cs, statement.cs, ecore.cs: Quote any nested expression
1079 2009-10-27 Marek Safar <marek.safar@gmail.com>
1081 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
1084 * class.cs: Allow nullable binary user operators.
1086 2009-10-26 Marek Safar <marek.safar@gmail.com>
1088 * expression.cs: Move binary expression optimization at the end of
1091 2009-10-23 Marek Safar <marek.safar@gmail.com>
1093 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
1094 Separate NullConstant from NullLiteral.
1096 2009-10-23 Marek Safar <marek.safar@gmail.com>
1098 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
1099 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
1100 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
1101 ModuleContainer. Add common unclosed member check routine.
1103 2009-10-22 Marek Safar <marek.safar@gmail.com>
1105 * argument.cs: Use literal flag for real literals only.
1107 * dynamic.cs: Use correct return type for custom delegates.
1109 2009-10-22 Marek Safar <marek.safar@gmail.com>
1111 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
1114 2009-10-22 Marek Safar <marek.safar@gmail.com>
1116 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
1118 2009-10-21 Marek Safar <marek.safar@gmail.com>
1120 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
1123 2009-10-21 Marek Safar <marek.safar@gmail.com>
1125 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
1128 2009-10-20 Marek Safar <marek.safar@gmail.com>
1130 * argument.cs, dynamic.cs, expression.cs: Latest API update.
1132 2009-10-19 Marek Safar <marek.safar@gmail.com>
1134 * typemanager.cs, expression.cs: Dynamic array initializer.
1136 2009-10-16 Marek Safar <marek.safar@gmail.com>
1138 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
1141 2009-10-16 Marek Safar <marek.safar@gmail.com>
1143 A fix for bug #493523, #507067
1144 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
1145 standard nullable conversion using underlying standard conversion
1146 and not full conversion.
1148 2009-10-15 Marek Safar <marek.safar@gmail.com>
1150 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
1151 type in VerifyArgumentsCompat.
1153 2009-10-15 Marek Safar <marek.safar@gmail.com>
1155 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1156 Reject variable used with type arguments.
1158 2009-10-14 Marek Safar <marek.safar@gmail.com>
1160 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
1161 Implement dynamic expressions assignment.
1163 2009-10-14 Marek Safar <marek.safar@gmail.com>
1165 * expression.cs: Build underlying expression when resolving unary
1168 2009-10-14 Marek Safar <marek.safar@gmail.com>
1170 * expression.cs: Emit enum array initializer using binary blob.
1172 2009-10-08 Marek Safar <marek.safar@gmail.com>
1174 * typemanager.cs, constant.cs: Optimize decimal constants which fit
1177 2009-10-07 Marek Safar <marek.safar@gmail.com>
1179 * typemanager.cs: Reset object_type.
1181 * assign: Made SimpleAssign public.
1183 2009-10-06 Marek Safar <marek.safar@gmail.com>
1185 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
1186 invocation assembly to IsThisOrFriendAssembly.
1188 2009-10-05 Marek Safar <marek.safar@gmail.com>
1190 * expression.cs: Equality comparison of generic parameter with
1193 2009-10-05 Marek Safar <marek.safar@gmail.com>
1195 A fix for bug #543570
1196 * generic.cs: Import predefined constraints correctly.
1198 2009-10-02 Marek Safar <marek.safar@gmail.com>
1200 * ecore.cs: Don't crash on overloads with optional paremeters where
1201 arguments count overflows.
1203 * parameter.cs: Import optional parameter constants using optional
1206 2009-10-01 Marek Safar <marek.safar@gmail.com>
1208 * Makefile: Default is gmcs compiler.
1210 2009-10-01 Marek Safar <marek.safar@gmail.com>
1212 * cs-parser.jay: Fixed few NRE.
1214 2009-10-01 Marek Safar <marek.safar@gmail.com>
1216 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
1218 2009-09-30 Marek Safar <marek.safar@gmail.com>
1220 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
1221 ShimExpression, ImplicitCast.
1223 2009-09-30 Marek Safar <marek.safar@gmail.com>
1225 A fix for bug #542959
1226 * delegate.cs: Emit correct delegate instance variable when there
1227 are static and non-static overloads.
1229 2009-09-29 Marek Safar <marek.safar@gmail.com>
1231 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
1232 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
1234 2009-09-28 Marek Safar <marek.safar@gmail.com>
1236 A fix for bug #542487
1237 * ecore.cs: Resolve extension methods hidden by properties.
1239 2009-09-25 Marek Safar <marek.safar@gmail.com>
1241 * expression.cs, ecore.cs: More dynamic binary expressions.
1243 2009-09-22 Marek Safar <marek.safar@gmail.com>
1245 * nullable.cs, expression.cs: Fixed null lifted conversion for
1246 bitwise enum operations.
1248 2009-09-22 Marek Safar <marek.safar@gmail.com>
1250 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
1251 values in checked context.
1253 2009-09-22 Marek Safar <marek.safar@gmail.com>
1255 * expression.cs, ecore.cs: Fixed array index constant conversion.
1257 2009-09-20 Miguel de Icaza <miguel@novell.com>
1259 * expression.cs: Do not crash when MemberLookup returns something
1260 that is not a MemberExpr here. Report error 582 instead.
1264 2009-09-18 Marek Safar <marek.safar@gmail.com>
1266 * decl.cs, class.cs: Check protected property accessors.
1268 2009-09-18 Marek Safar <marek.safar@gmail.com>
1270 * dynamic.cs, assign.cs: Dynamic compound assignment.
1272 2009-09-17 Marek Safar <marek.safar@gmail.com>
1274 * expression.cs: Fixed compound assignment explicit conversion.
1276 2009-09-17 Marek Safar <marek.safar@gmail.com>
1278 * expression.cs, ecore.cs: Cannot infer variables from method group.
1280 2009-09-16 Marek Safar <marek.safar@gmail.com>
1282 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
1283 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
1284 codegen.cs: Dynamic binary operations scaffolding.
1286 2009-09-15 Marek Safar <marek.safar@gmail.com>
1288 * expression.cs: Fixes nullable promotion for enum type variables.
1290 2009-09-11 Marek Safar <marek.safar@gmail.com>
1292 * driver.cs, dynamic.cs: Reset more static variables.
1294 2009-09-11 Marek Safar <marek.safar@gmail.com>
1296 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1297 driver.cs: Introduced Expression::MakeExpression.
1299 2009-09-11 Marek Safar <marek.safar@gmail.com>
1301 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1303 2009-09-09 Marek Safar <marek.safar@gmail.com>
1305 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1308 2009-09-09 Marek Safar <marek.safar@gmail.com>
1310 A fix for bug #518707
1311 * expression.cs (Is): Optimize only generic parameter type
1312 expression probing value type generic parameter.
1314 2009-09-09 Marek Safar <marek.safar@gmail.com>
1316 A fix for bug #532571
1317 * ecore.cs: Check for simple name type arguments used with
1320 2009-09-08 Marek Safar <marek.safar@gmail.com>
1322 A fix for bug #497421
1323 * generic.cs (CheckConstraint): Don't use buildin types to check for
1324 parameterless constructor.
1326 2009-09-08 Marek Safar <marek.safar@gmail.com>
1328 A fix for bug #537402
1329 * generic.cs (CheckConstraint): Correctly inflate generic type
1330 arguments when checking generic method.
1332 2009-09-08 Marek Safar <marek.safar@gmail.com>
1334 A fix for bug #536463
1335 * decl.cs (AddToContainer): Don't report collision between explicit
1336 and parameterless non-explicit members.
1338 2009-09-08 Marek Safar <marek.safar@gmail.com>
1340 * eval.cs: Reset more static stuff.
1342 2009-09-07 Marek Safar <marek.safar@gmail.com>
1344 A fix for bug #324625
1345 * expression.cs, ecore.cs: Create nested generic type expression
1346 using declaring and not current type.
1348 2009-09-07 Marek Safar <marek.safar@gmail.com>
1350 * *.cs: Changed Report class to accept various output printers and
1351 be an instance class. An expression resolver can now use different
1352 message reporter for each call and Report.Error can safely throw
1353 an exception. Part of ongoing work to turn mcs into proper library.
1355 2009-09-04 Marek Safar <marek.safar@gmail.com>
1357 * statement.cs, ecore.cs: Removed error reporting from emit code.
1359 2009-09-04 Marek Safar <marek.safar@gmail.com>
1361 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1363 2009-09-03 Marek Safar <marek.safar@gmail.com>
1365 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1366 parser checks out of constructors.
1368 2009-09-02 Marek Safar <marek.safar@gmail.com>
1370 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1372 2009-09-02 Marek Safar <marek.safar@gmail.com>
1374 A fix for bug #535448
1375 * anonymous.cs, class.cs: Copy return label between all contexts.
1377 2009-09-02 Marek Safar <marek.safar@gmail.com>
1379 A fix for bug #535395
1380 * namespace.cs: Resolve context can be null.
1382 2009-08-25 Marek Safar <marek.safar@gmail.com>
1384 A fix for bug #533912
1385 * generic.cs: Use correct context for constraints resolving.
1387 2009-08-25 Marek Safar <marek.safar@gmail.com>
1389 A fix for bug #532630
1390 * driver.cs: Trim conditional symbols.
1392 2009-08-25 Marek Safar <marek.safar@gmail.com>
1394 * context.cs: New file.
1396 * *.exe.sources, *.csproj: Updated.
1398 2009-08-25 Marek Safar <marek.safar@gmail.com>
1400 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1401 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1402 IMembercontext, some small cleanups.
1404 2009-08-24 Marek Safar <marek.safar@gmail.com>
1406 * *.cs: Split ResolveContext and EmitContext.
1408 2009-08-24 Marek Safar <marek.safar@gmail.com>
1410 * *.cs: Only ResolveContext implements IMemberContext.
1412 2009-08-21 Marek Safar <marek.safar@gmail.com>
1414 * *.cs: Renamed IResolveContext to IMemberContext.
1416 2009-08-21 Marek Safar <marek.safar@gmail.com>
1418 * *.cs: Detached ResolveContext from EmitContext.
1420 2009-08-21 Marek Safar <marek.safar@gmail.com>
1422 * codegen.cs: Moved flow-analysis to BlockContext.
1424 2009-08-21 Marek Safar <marek.safar@gmail.com>
1426 * *.cs: Detached BlockContext from EmitContext.
1428 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1430 * statement.cs: avoid nullref when the return value of GetEnumerator()
1431 does not contain any MoveNext() method.
1433 2009-08-19 Marek Safar <marek.safar@gmail.com>
1435 * *.cs: Removed IResolveContext::GenericDeclContainer.
1437 2009-08-19 Marek Safar <marek.safar@gmail.com>
1439 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1441 2009-08-19 Marek Safar <marek.safar@gmail.com>
1443 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1444 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1446 2009-08-18 Marek Safar <marek.safar@gmail.com>
1448 * *.cs: Removed boolean fields from EmitContext.
1450 2009-08-18 Marek Safar <marek.safar@gmail.com>
1452 * *.cs: Add IResolveContext::IsStatic.
1454 2009-08-18 Marek Safar <marek.safar@gmail.com>
1456 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1458 2009-08-17 Marek Safar <marek.safar@gmail.com>
1460 * *.cs: Removed DeclContainer from EmitContext.
1462 2009-08-17 Marek Safar <marek.safar@gmail.com>
1464 * *.cs: Add IResolveContext::CurrentTypeParameters.
1466 2009-08-14 Marek Safar <marek.safar@gmail.com>
1468 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1470 2009-08-14 Marek Safar <marek.safar@gmail.com>
1472 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1473 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1475 2009-08-13 Marek Safar <marek.safar@gmail.com>
1477 * decl.cs: Look in PartialContainer for parent type parameters.
1479 2009-08-13 Marek Safar <marek.safar@gmail.com>
1481 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1482 codegen.cs: Add IResolveContext::LookupTypeParameter.
1484 2009-08-13 Marek Safar <marek.safar@gmail.com>
1486 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1487 Moved resolved logic from Emit to Resolve.
1489 2009-08-13 Marek Safar <marek.safar@gmail.com>
1491 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1492 codegen.cs: Reworked atttributes handling of ResolveContext.
1494 2009-08-12 Marek Safar <marek.safar@gmail.com>
1496 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1497 LookupNamespaceOrType to ResolveContext.
1499 2009-08-12 Marek Safar <marek.safar@gmail.com>
1501 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1502 class.cs: Removed unused parameters and methods.
1504 2009-08-11 Marek Safar <marek.safar@gmail.com>
1506 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1507 codegen.cs: Finding the best common type of a set of expressions for
1510 2009-08-07 Marek Safar <marek.safar@gmail.com>
1512 * dynamic.cs, expression.cs: More dynamic conversions.
1514 2009-08-06 Miguel de Icaza <miguel@novell.com>
1516 * generic.cs: This loop was incorrect, it was increment ii, but
1517 checking for `i'. This was a change introduced to fix #327497,
1520 * class.cs: Catch another case for cs0533 error, fixes #324782.
1522 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1524 * typemanager.cs (GetGenericArguments): SRE returns null for
1525 generic methods on type builder instances if they are not generic
1526 themselves. For example, for Foo<int>::Bar() it returns null, but
1527 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1529 2009-08-05 Marek Safar <marek.safar@gmail.com>
1531 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1532 delegate.cs: Work on dynamic binding.
1534 2009-08-04 Marek Safar <marek.safar@gmail.com>
1536 A second fix for bug #525342
1537 * class.cs: Attach partial method attributes to method
1540 2009-08-03 Marek Safar <marek.safar@gmail.com>
1542 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1545 * rootcontext.cs: Default to langversion v4.
1547 2009-08-03 Marek Safar <marek.safar@gmail.com>
1549 * pending.cs: Check return type before member info is set.
1551 2009-08-03 Marek Safar <marek.safar@gmail.com>
1553 * anonymous.cs: Fully initialize generic hoisted field expression.
1555 2009-08-02 Miguel de Icaza <miguel@novell.com>
1557 * cs-parser.jay: Flag variables declared on the interactive shell
1558 as used to prevent the 168 warning about local variable not being
1561 2009-07-31 Marek Safar <marek.safar@gmail.com>
1563 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1564 attribute.cs: Emit dynamic export attribute.
1566 2009-07-30 Marek Safar <marek.safar@gmail.com>
1568 * expression.cs: More verifier work.
1570 2009-07-29 Marek Safar <marek.safar@gmail.com>
1572 * nullable.cs: Fixed SRE crash during corlib compilation.
1574 2009-07-29 Marek Safar <marek.safar@gmail.com>
1576 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1577 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1578 More TypeManager.TypeToCoreType needed.
1580 2009-07-29 Marek Safar <marek.safar@gmail.com>
1582 * anonymous.cs: Update after recent SRE fixes.
1584 2009-07-28 Marek Safar <marek.safar@gmail.com>
1586 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1587 version of GetFieldHandle for fields of generic types.
1589 2009-07-27 Marek Safar <marek.safar@gmail.com>
1591 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1592 ecore.cs: Add TypeManager.IsDynamicType,
1593 PredefinedAttributes.Dynamic.
1595 2009-07-27 Marek Safar <marek.safar@gmail.com>
1597 A fix for bug #415375
1598 * expression.cs: Fixed object and reference type parameter
1601 2009-07-27 Marek Safar <marek.safar@gmail.com>
1603 A fix for bug #525342
1604 * class.cs: Attach partial method attributes to method
1607 2009-07-24 Marek Safar <marek.safar@gmail.com>
1609 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1612 2009-07-24 Marek Safar <marek.safar@gmail.com>
1614 * anonymous.cs (MutateField): Add imported types handling.
1616 2009-07-23 Marek Safar <marek.safar@gmail.com>
1618 * expression.cs, delegate.cs: Moved arguments resolve into their
1619 counterparts expressions. Removed argument resolve from
1620 CollectionElementInitializer.
1622 2009-07-23 Marek Safar <marek.safar@gmail.com>
1624 A fix for bug #523683
1625 * convert.cs, delegate.cs: Use common overload mechanism for method
1626 group conversion check.
1628 2009-07-22 Marek Safar <marek.safar@gmail.com>
1630 A fix for bug #523899
1631 * generics.cs: Exact type inference with other bound types.
1633 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1635 Don't complain when the same type is implemented by the output
1636 assembly as well as multiple referenced assemblies
1637 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1638 'must_be_unique' flag.
1639 (GlobalRootNamespace): Update to changes.
1640 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1641 already have a type in hand.
1643 2009-07-22 Marek Safar <marek.safar@gmail.com>
1645 * expression.cs: More verifier instrumentation.
1647 * statement.cs: Do proper throw expression conversion.
1649 2009-07-22 Marek Safar <marek.safar@gmail.com>
1651 A fix for bug #522789
1652 * expression.cs: Mutate invocation return type.
1654 2009-07-16 Marek Safar <marek.safar@gmail.com>
1656 * anonymous.cs: Split assignable and readonly generated variable
1659 2009-07-16 Marek Safar <marek.safar@gmail.com>
1661 A fix for bug #521671
1662 * statement.cs: Fixed crash when checking missing type.
1664 2009-07-16 Marek Safar <marek.safar@gmail.com>
1666 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1667 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1668 class.cs, driver.cs: Work on dynamic binding.
1670 * dynamic.cs: New file.
1672 * *.sources, *.proj: Updated.
1674 2009-07-15 Marek Safar <marek.safar@gmail.com>
1676 * expression.cs (Conditional): Avoid double Resolve.
1678 2009-07-13 Marcus Griep <marcus@griep.us>
1680 * ecore.cs: Fix obscure bug with resolving members of interfaces
1681 that hide parent interface members. Fixes bug #444388 and corrects
1684 2009-07-13 Marek Safar <marek.safar@gmail.com>
1686 * expression.cs (LocalVariableReference): Bounce resolve.
1688 2009-07-10 Marek Safar <marek.safar@gmail.com>
1690 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1691 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1694 * support.cs: New dynamic type wrapper.
1696 2009-07-08 Marek Safar <marek.safar@gmail.com>
1698 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1699 typed local variable.
1701 2009-07-06 Marek Safar <marek.safar@gmail.com>
1703 A fix for bug #519005
1704 * anonymous.cs: Use null_type as no return type placeholder.
1706 2009-07-02 Marek Safar <marek.safar@gmail.com>
1708 * generic.cs: Handle type inference of identical type parameters
1709 with different bounds.
1711 2009-07-01 Marek Safar <marek.safar@gmail.com>
1713 * expression.cs, class.cs: Events variance.
1715 * cs-parser.jay: Interface events error messages.
1717 2009-07-01 Marek Safar <marek.safar@gmail.com>
1719 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1721 2009-06-29 Marek Safar <marek.safar@gmail.com>
1723 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1724 parameter expression can be value-type New.
1726 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1728 2009-06-26 Marek Safar <marek.safar@gmail.com>
1730 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1731 Implemented C# 4.0 named arguments.
1733 2009-06-24 Marek Safar <marek.safar@gmail.com>
1735 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1736 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1737 parameter modifier. Also fixes bug #515497.
1739 2009-06-24 Marek Safar <marek.safar@gmail.com>
1741 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1742 arguments expression to be implemented.
1744 *.sources: Add argument.cs
1746 2009-06-23 Marek Safar <marek.safar@gmail.com>
1748 * parameter.cs: Moved GetParameterIndexByName to base class.
1750 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1751 unused AType. Use argument's version of GetExpressionTree.
1753 2009-06-22 Marek Safar <marek.safar@gmail.com>
1755 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1758 2009-06-17 Marek Safar <marek.safar@gmail.com>
1760 A fix for bug #514096
1761 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1763 2009-06-17 Marek Safar <marek.safar@gmail.com>
1765 * expression.cs: The first multi-dimensional array nested array
1766 initializers was not checked.
1768 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1770 2009-06-17 Marek Safar <marek.safar@gmail.com>
1772 A fix for bug #513400
1773 * nullable.cs (EmitEquality): Operands emit could be simplified for
1774 built-in types when we now emit user operators differently.
1776 2009-06-16 Marek Safar <marek.safar@gmail.com>
1778 * ecore.cs: Report inaccessible delegate methods correctly.
1780 2009-06-16 Marek Safar <marek.safar@gmail.com>
1782 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1783 cs-parser.jay: Implemented C# 4.0 optional parameters.
1785 2009-06-16 Marek Safar <marek.safar@gmail.com>
1787 * driver.cs: Removed broken DefineManifestResource.
1789 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1791 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1792 Use $(BOOTSTRAP_PROFILE) instead.
1794 2009-06-12 Jb Evain <jbevain@novell.com>
1796 * rootcontext.cs: add a Platform field.
1797 * driver.cs: handle /platform.
1798 * codegen.cs: pass the proper flags according to
1799 the platform when saving the assembly.
1801 2009-06-11 Marek Safar <marek.safar@gmail.com>
1803 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1804 Add optional parameters grammar.
1806 2009-06-10 Marek Safar <marek.safar@gmail.com>
1808 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1809 driver.cs: Split lang version and metadata version.
1811 2009-06-10 Marek Safar <marek.safar@gmail.com>
1813 * decl.cs: Better overload ctor collision error message.
1815 2009-06-05 Jb Evain <jbevain@novell.com>
1817 * driver.cs (EmbededResource): avoid using an internal method
1818 in gmcs to embed manifest resources.
1820 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1822 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1823 the compiler from older mono versions (like moon's bots)
1825 2009-06-04 Marek Safar <marek.safar@gmail.com>
1827 * namespace.cs (LookupTypeReflection): Ignore collisions between
1830 2009-06-04 Marek Safar <marek.safar@gmail.com>
1832 * codegen.cs: Enabled generic type forwarders.
1834 2009-06-04 Marek Safar <marek.safar@gmail.com>
1836 * dmcs.*: Add another version of SRE compiler.
1838 2009-06-03 Marek Safar <marek.safar@gmail.com>
1840 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1841 generic-mcs.cs: Fixed variant type conversions.
1843 2009-06-02 Marek Safar <marek.safar@gmail.com>
1845 A fix for bug #507863
1846 * codegen.cs: Fixes a crash on invalid string value attribute.
1848 2009-06-01 Marek Safar <marek.safar@gmail.com>
1850 A fix for bug #508334
1851 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1852 cs-parser.jay: Fully import __arglist modifier.
1854 2009-05-29 Marek Safar <marek.safar@gmail.com>
1856 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1857 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1858 actually work with closed generic types.
1860 2009-05-27 Alan McGovern <amcgovern@novell.com>
1862 * class.cs, decl.cs, delegate.cs, parameter.cs:
1863 Fix the build by replacing the use of 'var' with the actual type.
1865 2009-05-27 Marek Safar <marek.safar@gmail.com>
1867 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1868 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1871 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1874 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1875 Marek Safar <marek.safar@gmail.com>
1877 A fix for bug #377509
1878 * parameter.cs: Use predefined and not empty name for implicit
1881 2009-05-21 Marek Safar <marek.safar@gmail.com>
1883 * class.cs: Don't report wrong warnings for event fields.
1885 2009-05-21 Marek Safar <marek.safar@gmail.com>
1887 A fix for bug #504667
1888 * class.cs: Check for static class using parent container instead of
1891 2009-05-08 Marek Safar <marek.safar@gmail.com>
1893 A fix for bug #496922
1894 * expression.cs: Always use temporary variable when using object
1897 2009-04-28 Marek Safar <marek.safar@gmail.com>
1899 A fix for bug #495112
1900 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1903 2009-04-27 Miguel de Icaza <miguel@novell.com>
1905 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1907 2009-04-24 Miguel de Icaza <miguel@novell.com>
1909 * complete.cs: No idea how gonzalo got a null in the list, but
1912 2009-04-24 Miguel de Icaza <miguel@novell.com>
1914 * complete.cs (CompletionElementInitializer): New completion class
1915 to support completing inside a C# 3 element initializer, so this
1916 allows completion for Silverlight situations where it is very
1919 new TextBlock () { Fo<TAB>
1921 (CompletionSimpleName): Expose the prefix that was
1922 passed to the simple name.
1924 * cs-parser.jay (object_or_collection_initializer): Add support
1925 for element_initializers.
1927 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1928 special case completion expressions as this method aggressively
1929 collects data before it operates, and errors were being thrown
1930 earlier than we were able to complete.
1932 2009-04-23 Miguel de Icaza <miguel@novell.com>
1934 * eval.cs: Make getcompletions silent and enable debugging output
1935 if the -v option is passed.
1937 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1938 Consider looking up the namespace that matches the prefix being
1941 This is part of the support for allowing completions like:
1942 `System.Co<TAB>' to complete to System.Console.
1944 * complete.cs (CompletionSimpleName.AppendResults): Make this
1947 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1949 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1950 COMPLETE_COMPLETION as internal.
1952 2009-04-17 Miguel de Icaza <miguel@novell.com>
1954 * complete.cs: Include namespace resolution in simple names as
1955 well as global types and types in the using scope in the
1958 * namespace.cs: Supporting infrastrcture to provide completions
1959 based on the current using scope.
1961 * eval.cs: Introduce an entry point that allows for initialization
1962 to return a list of the files passed on the command line.
1964 2009-04-14 Marek Safar <marek.safar@gmail.com>
1966 A fix for bug #494243
1967 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1969 2009-04-13 Marek Safar <marek.safar@gmail.com>
1971 A fix for bug #493887
1972 * statement.cs: Don't skip string multi-section with default or
1973 null label when populating string hashtable.
1975 2009-04-06 Marek Safar <marek.safar@gmail.com>
1977 A fix for bug #492329
1978 * expression.cs (New): Load variable when assigning type parameter
1981 2009-04-06 Marek Safar <marek.safar@gmail.com>
1983 A fix for bug #488960
1984 * decl.cs: Compare MVAR types using non-null values.
1986 2009-03-27 Marek Safar <marek.safar@gmail.com>
1988 * typemanager.cs, expression.cs: Removed unused nullable checks.
1990 2009-03-27 Marek Safar <marek.safar@gmail.com>
1992 * *.cs: Removed some gmcs conditionals.
1994 2009-03-26 Marek Safar <marek.safar@gmail.com>
1996 * generic.cs, support.cs: Moved generics stuff out of support.cs
1998 2009-03-24 Marek Safar <marek.safar@gmail.com>
2000 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
2003 2009-03-23 Marek Safar <marek.safar@gmail.com>
2005 * attribute.cs: Consider all members for error reporting when
2006 checking named arguments.
2008 2009-03-23 Marek Safar <marek.safar@gmail.com>
2010 A fix for bug #487625
2011 * namespace.cs: Use a warning for all predefined type conflicts.
2013 2009-03-23 Marek Safar <marek.safar@gmail.com>
2015 A fix for bug #485706
2016 * statement.cs: Explicitly type catch type argument to pass verifier
2019 2009-03-22 Miguel de Icaza <miguel@novell.com>
2021 Initial support to provide code completion facilities to consumers
2022 of the evaluator API.
2024 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
2025 support the completion engine. When we reach the end of the
2026 input stream instead of returning EOF, when this flag is true the
2027 tokenizer instead produces:
2029 One GENERATE_COMPLETION token: this token then must be
2030 handled in the grammar at every point where the user
2031 would likely request a completion.
2033 As many COMPLETE_COMPLETION tokens as necessary. These
2034 tokens are generated to assist the parser in unwinding and
2035 producing a valid parse tree.
2037 The parser rules do not have to be perfect, the parser needs to be
2038 augmented with judicious use of GENERATE_COMPLETION tokens to
2039 improve the areas where we can provide completion and the parser
2040 needs to add support for COMPLETE_COMPLETION tokens in productions
2043 It is common to not have enough support for COMPLETE_COMPLETION
2044 under certain rules and that even if we generated the
2045 GENERATE_COMPLETION token that the resulting tree will be invalid
2046 due to the missing rules that support COMPLETE_COMPLETION.
2048 The final EOF token is produced by having the parser notify the
2049 tokenizer when it reaches the root production that the next token
2052 * support.cs (CompletionResult): New Exception. This exception
2053 is thrown to return the completion results when one of the special
2054 completion expressions is reached.
2056 This exception is thrown by the completing ExpressionStatements
2057 classes that live in complete.cs
2059 * complete.cs (CompletingExpression): a new base class for
2060 completing expressions. This derives from the
2061 ExpressionStatement class and not from Expression as it allows
2062 completion to happen not only where expressions are expected in
2063 the grammar, but also where statements are expected.
2065 (CompletionSimpleName): A new class used to provide completions
2066 for SimpleNames. This currently only resolves to local
2067 variables from the evaluator context (GetVars call).
2069 (CompletionMemberAccess): Implements support for completing member
2072 * cs-parser.jay: Add support for completion in a few places.
2074 * eval.cs (GetCompletions): New public API for the evaluator that
2075 returns a list of possible completions given the input. The
2076 return value is an array of completions
2078 * anonymous.cs (Compatible): If the exception thrown from the
2079 resolved expression is a CompletionResult exception let that one
2080 through instead of printing a diagnostic error in the try/catch.
2082 2009-03-22 Miguel de Icaza <miguel@novell.com>
2086 * driver.cs (Main): Use Environment.Exit to quit quickly and
2087 prevent the compiler from doing the usual wait for helper thread
2090 This is to prevent a slowdown that was reported by Gonzalo on
2093 2009-03-19 Marek Safar <marek.safar@gmail.com>
2095 * ecore.cs: Load build-in types directly instead of accessing
2098 2009-03-18 Marek Safar <marek.safar@gmail.com>
2100 * ecore.cs: Always use unbox.any when available.
2102 2009-03-18 Marek Safar <marek.safar@gmail.com>
2104 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
2106 2009-03-17 Marek Safar <marek.safar@gmail.com>
2108 * generic.cs: Removed obsolete version of type inference.
2110 2009-03-16 Marek Safar <marek.safar@gmail.com>
2112 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
2113 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
2114 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
2115 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
2117 2009-03-11 Marek Safar <marek.safar@gmail.com>
2119 A fix for bug #482996
2120 * anonymous.cs: Make sure we are not infering return type when
2121 checking type compatibility.
2123 2009-03-11 Marek Safar <marek.safar@gmail.com>
2125 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
2126 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
2127 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
2128 attributes in their own structure. Needed when accessing their
2129 properties before they are resolved.
2131 2009-03-09 Marek Safar <marek.safar@gmail.com>
2133 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
2134 hashtable (~10x faster).
2136 * driver.cs: Removed wrong Reset.
2138 2009-03-08 Marek Safar <marek.safar@gmail.com>
2140 * class.cs: Use correct common base type for unmanaged delayed
2143 * rootcontext.cs: Wrap unhandled exception.
2145 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
2147 Make SeekableStreamReader self-tuning and arbitrarily seekable
2148 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
2150 (SeekableStreamReader.Position.set): Use it. Simplify logic
2151 which, as a side-effect, makes it arbitrarily-seekable. Tune the
2152 buffer size when the stream needs to be re-read from the beginning.
2154 2009-03-05 Marek Safar <marek.safar@gmail.com>
2156 A fix for bug #480100
2157 * parameter.cs: A parameter is not hoisted when used directly as ET.
2159 2009-03-04 Marek Safar <marek.safar@gmail.com>
2161 * statement.cs: Fixed an issue when using variable is of interface
2164 2009-03-03 Marek Safar <marek.safar@gmail.com>
2166 A fix for bug #480319
2167 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
2169 2009-03-03 Marek Safar <marek.safar@gmail.com>
2171 A fix for bug #480867
2172 * typemanager.cs, expression.cs, ecore.cs: Changed method group
2173 expression to have no valid type.
2175 2009-03-03 Marek Safar <marek.safar@gmail.com>
2177 A fix for bug #481258
2178 * class.cs: Set extension method flag in partial container.
2180 2009-03-03 Marek Safar <marek.safar@gmail.com>
2182 * statement.cs, typemanager.cs: Use expression for StringEmitter.
2184 * attribute.cs: Add sanity check.
2186 2009-02-27 Marek Safar <marek.safar@gmail.com>
2188 * class.cs: Add external constructor error.
2190 2009-02-26 Marek Safar <marek.safar@gmail.com>
2192 A fix for bug #475354
2193 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
2194 correctly user defined nullable equality operators.
2196 2009-02-25 Marek Safar <marek.safar@gmail.com>
2198 A fix for bug #479532
2199 * expression.cs: Implement NewInitialize::AddressOf.
2201 2009-02-25 Marek Safar <marek.safar@gmail.com>
2203 A fix for bug #413633
2204 * expression.cs: Iterate all base class-constraint types.
2206 2009-02-24 Marek Safar <marek.safar@gmail.com>
2208 A fix for bug #479209
2209 * literal.cs: Mutate null underlying type.
2211 2009-02-24 Marek Safar <marek.safar@gmail.com>
2213 A fix for bug #476295
2214 * convert.cs: Avoid wrapping implicitly convertible reference type.
2216 2009-02-23 Marek Safar <marek.safar@gmail.com>
2218 * iterators.cs: Create MemberName correctly.
2220 2009-02-23 Marek Safar <marek.safar@gmail.com>
2222 A fix for bug #478655
2223 * literal.cs: Check also underlying null type conversion.
2225 2009-02-21 Marek Safar <marek.safar@gmail.com>
2227 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
2229 2009-02-20 Marek Safar <marek.safar@gmail.com>
2231 A fix for bug #477447
2232 * statement.cs: Add reference to correct parent storey when this
2233 is accessible from deep children storey (more than 1 level).
2235 2009-02-19 Marek Safar <marek.safar@gmail.com>
2237 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
2238 * class.cs: Define base type members before setting up member cache.
2240 2009-02-18 Marek Safar <marek.safar@gmail.com>
2242 A fix for bug #477378
2243 * nullable.cs, expression.cs, statement.cs: More precise null type
2246 2009-02-18 Marek Safar <marek.safar@gmail.com>
2248 A fix for bug #472805
2249 * typemanager.cs, namespace.cs: Import only visible extension method
2252 2009-02-18 Marek Safar <marek.safar@gmail.com>
2254 A fix for bug #476895
2255 * attribute.cs: Use correct resolve context for attribute type.
2257 2009-02-18 Marek Safar <marek.safar@gmail.com>
2259 A fix for bug #476266
2260 * anonymous.cs: Mutate multi-dimensional arrays.
2262 2009-02-18 Marek Safar <marek.safar@gmail.com>
2264 A fix for bug #476400
2265 * statement.cs, expression.cs: Removed wrong Dispose optimization.
2267 2009-02-18 Marek Safar <marek.safar@gmail.com>
2269 A fix for bug #476811
2270 * generics.cs: Fixed null-literal check.
2272 2009-02-17 Marek Safar <marek.safar@gmail.com>
2274 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
2275 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
2276 messing with static variables.
2278 2009-02-16 Marek Safar <marek.safar@gmail.com>
2280 A fix for bug #475965
2281 * generics.cs: Check generic parameter type after extracting from
2284 2009-02-16 Marek Safar <marek.safar@gmail.com>
2286 A fix for bug #475823
2287 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
2290 2009-02-14 Marek Safar <marek.safar@gmail.com>
2292 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
2293 Simplified event field definition using backing field and not
2294 field builder directly.
2296 * expression.cs (EmitLdArg): Optimize fast paths.
2298 2009-02-13 Marek Safar <marek.safar@gmail.com>
2300 A fix for bug #475327
2301 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2303 2009-02-13 Marek Safar <marek.safar@gmail.com>
2305 A fix for bug #475342
2306 * cs-parser.jay: Using 'super' instead of 'base' to call base
2307 constructor crashes compiler.
2309 2009-02-13 Marek Safar <marek.safar@gmail.com>
2311 A fix for bug #475354
2312 * expression.cs (Constantify): Add nullable types.
2314 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2316 2009-02-12 Marek Safar <marek.safar@gmail.com>
2318 A fix for bug #475246
2319 * expression.cs: More broken flowanalysis hacking needed.
2321 2009-02-12 Marek Safar <marek.safar@gmail.com>
2323 * attribute.cs: Compare only ref/out array modifiers.
2325 2009-02-11 Marek Safar <marek.safar@gmail.com>
2327 * statement.cs: Use member cache when looking for foreach members.
2329 2009-02-11 Marek Safar <marek.safar@gmail.com>
2331 * expression.cs: Don't expose internal initializer types.
2333 * statement.cs: Check also explicit conversions for goto case.
2335 2009-02-11 Marek Safar <marek.safar@gmail.com>
2337 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2339 2009-02-10 Marek Safar <marek.safar@gmail.com>
2341 * *.cs: Replace null-type with NullLiteral where appropriate.
2343 2009-02-09 Marek Safar <marek.safar@gmail.com>
2345 * expression.cs: Initializer of reference argument use temporary
2346 variable to be verifiable.
2348 * parameter.cs: Share EmitLdArg.
2350 2009-02-09 Marek Safar <marek.safar@gmail.com>
2352 A fix for bug #473559
2353 * class.cs: Fixed: Not reporting error about nested class with the
2356 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2358 Contributed under the MIT/X11 license.
2360 * generic.cs: Added VerifyVariantTypeParameters which performs new
2361 variance verification logic. The old logic, based on the spec, was
2362 wrong because the spec is full of LIES!
2364 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2366 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2369 * ecore.cs: Added calls to the new variance verification logic.
2372 * delegate.cs: Removed calls to the old variance verification logic.
2374 2009-02-06 Marek Safar <marek.safar@gmail.com>
2376 * delegate.cs: Use cached Invoke method directly.
2378 2009-02-06 Marek Safar <marek.safar@gmail.com>
2380 * expression.cs: Emit expression tree for hoisted variable access.
2382 2009-02-04 Marek Safar <marek.safar@gmail.com>
2384 * namespace.cs: Add better extension class check.
2386 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2388 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2390 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2392 This patch adds initial generic variance support to the compiler.
2393 It is contributed under the MIT/X11 license.
2395 * typemanager.cs: Modified ImplementsInterface to check variance.
2396 Added VerifyVariantTypeParameters which checks the specified type to see
2397 if it uses a variant type parameter as a type argument (which is not
2398 allowed). Added IsVariantOf which determins if the first type is a
2399 variant of the second. NOTE: This only supports reference types at
2400 the moment to conform with the current level of VM support. When the
2401 VM supports value types, this will follow step.
2403 * generic.cs: Added the Variance enum. Added a Variance property to
2404 TypeParameter and added variance support to definition phase. Added a
2405 Variance property to TypeParameterName. Also check to make sure that
2406 no variant types appear in generic method parameters.
2408 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2409 keywords if the langversion supports it.
2411 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2412 that variant types are only used in legal positions. Also added
2413 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2416 * decl.cs: Construct TypeParameter with the variance information.
2418 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2419 and ImplicitConversionStandard.
2421 * rootcontext.cs: Added new "Future" language version.
2423 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2424 type parameters are not used as type arguments in interface inheritance.
2425 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2426 parameters are not used as method return types. In MemberBase.
2427 ResolveMemberType, ensure that variant type parameters are not used
2428 as type arguments. Also call VerifyNoVariantTypeParameters on every
2429 set of parameters which are resolved.
2431 * delegate.cs: Modified Delegate.Define to ensure that variant
2432 parameters are not used as type arguments and that a contravariant
2433 parameter is not used as the return type. Also call
2434 VerifyNoVariantTypeParameters on the delegate parameters.
2436 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2437 to specify generic variance.
2439 * driver.cs: Added support for LanguageVersion.Future in the form of
2440 "-langversion:future".
2442 * generic-mcs.cs: Stubbed out new members in generic.cs.
2444 2009-02-03 Marek Safar <marek.safar@gmail.com>
2446 * class.cs, generic.cs: Emit type parameter constraints for nested
2449 2009-02-02 Marek Safar <marek.safar@gmail.com>
2451 A fix for bug #471213
2452 * class.cs: Avoid emitting backing field for abstract event fields.
2454 2009-02-01 Marek Safar <marek.safar@gmail.com>
2456 A fix for bug #359731
2457 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2460 2009-01-30 Marek Safar <marek.safar@gmail.com>
2462 A fix for bug #470767
2463 * statement.cs: Introduced BlockScopeExpression, needed when
2464 expression tree conversion has to emit scope variables.
2466 2009-01-29 Marek Safar <marek.safar@gmail.com>
2468 * class.cs: Remove duplicate CallingConvention.
2470 2009-01-29 Marek Safar <marek.safar@gmail.com>
2472 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2473 when I finally found the right naming convention.
2475 2009-01-29 Marek Safar <marek.safar@gmail.com>
2477 * cs-tokenizer.cs: Put back different open parens optimization.
2479 2009-01-28 Marek Safar <marek.safar@gmail.com>
2481 A fix for bug #470227
2482 * cs-tokenizer.cs: Remove too agressive parser optimization.
2484 2009-01-28 Marek Safar <marek.safar@gmail.com>
2486 A fix for bug #324319
2487 * class.cs: Remove too early base type resolve.
2489 2009-01-27 Marek Safar <marek.safar@gmail.com>
2491 A fix for bug #324319
2492 * ecore.cs: Explicitly type null when assigning to type argument to
2493 make pass verifier check.
2495 2009-01-27 Marek Safar <marek.safar@gmail.com>
2497 * anonymous.cs: Fixed recent regression when initializing captured
2500 2009-01-26 Marek Safar <marek.safar@gmail.com>
2502 A fix for bug #469019
2503 * anonymous.cs: Use all parent type parameters when instantiating
2504 nested generic storey.
2506 2009-01-26 Marek Safar <marek.safar@gmail.com>
2508 * expression.cs: Check for null instance methodgroup expression.
2510 2009-01-26 Marek Safar <marek.safar@gmail.com>
2512 A fix for bug #469244
2513 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2514 instance inside a conditional expression.
2516 2009-01-23 Marek Safar <marek.safar@gmail.com>
2518 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2519 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2520 GetElementType and HasElementType. IsValueType clean up.
2522 2009-01-23 Marek Safar <marek.safar@gmail.com>
2524 * nullable.cs: Use common EmitCall.
2526 * expression.cs: Emit constraint. for virtual calls only.
2528 2009-01-23 Marek Safar <marek.safar@gmail.com>
2530 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2531 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2532 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2535 2009-01-22 Jb Evain <jbevain@novell.com>
2537 * anonymous.cs: make anonymous types' ToString implementation
2538 match what csc outputs.
2540 2009-01-21 Marek Safar <marek.safar@gmail.com>
2542 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2545 2009-01-17 Marek Safar <marek.safar@gmail.com>
2547 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2550 2009-01-16 Marek Safar <marek.safar@gmail.com>
2552 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2555 2009-01-15 Marek Safar <marek.safar@gmail.com>
2557 A fix for bug #466634
2558 * statement.cs: Add reference for nested storey when only this
2561 2009-01-15 Marek Safar <marek.safar@gmail.com>
2563 A fix for bug #466474
2564 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2567 2009-01-15 Marek Safar <marek.safar@gmail.com>
2569 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2570 Fixed nested stories parent referencing process. Also fixes #463985.
2572 2009-01-06 Marek Safar <marek.safar@gmail.com>
2574 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2575 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2576 implementation. Also fixes #463108.
2578 2009-01-05 Marek Safar <marek.safar@gmail.com>
2580 A fix for bug #416109
2581 * decl.cs: Issue correct CLSAttribute warning location.
2583 2009-01-05 Marek Safar <marek.safar@gmail.com>
2585 A fix for bug #456775
2586 * attribute.cs: Use attribute owner scope when resolving attribute
2589 2009-01-05 Marek Safar <marek.safar@gmail.com>
2591 A fix for bug #457257
2592 * decl.cs: Fixed incorrect member declaring type comparison.
2594 2009-01-05 Marek Safar <marek.safar@gmail.com>
2596 A fix for bug #460896
2597 * driver.cs: Handle /RES resources as embeddable.
2599 2009-01-05 Marek Safar <marek.safar@gmail.com>
2601 A fix for bug #462515
2602 * ecore.cs: Report inacessible members upwards.
2604 2009-01-05 Marek Safar <marek.safar@gmail.com>
2606 A fix for bug #463190, #463192
2607 * decl.cs, namespace.cs: Also import internal extension classes.
2609 2009-01-04 Marek Safar <marek.safar@gmail.com>
2611 A fix for bug #463415
2612 * generic.cs: Use right index for RemoveDependentTypes.
2614 2009-01-02 Marek Safar <marek.safar@gmail.com>
2616 A fix for bug #463196
2617 * expression.cs: Fixed enum to null comparison.
2619 2009-01-02 Marek Safar <marek.safar@gmail.com>
2621 A fix for bug #463121
2622 * nullable.cs: Fixed nullable user equality operator comparison.
2624 2009-01-02 Marek Safar <marek.safar@gmail.com>
2626 A fix for bug #462950
2627 * class.cs, decl.cs: Use full explicit name when defining automatic
2628 property backing field.
2630 2009-01-02 Marek Safar <marek.safar@gmail.com>
2632 A fix for bug #462592
2633 * pending.cs: Emit type arguments for generic proxy method.
2635 2008-12-30 Marek Safar <marek.safar@gmail.com>
2637 * expression.cs (As): Mutate all type arguments.
2639 2008-12-29 Marek Safar <marek.safar@gmail.com>
2641 A fix for bug #462622
2642 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2645 2008-12-29 Marek Safar <marek.safar@gmail.com>
2647 A fix for bug #450782
2648 * ecore.cs: Consider more variables of form V.I to be fixed.
2650 2008-12-29 Marek Safar <marek.safar@gmail.com>
2652 A fix for bug #460712
2653 * typemanager.cs: Core types could be imported.
2655 2008-12-28 Marek Safar <marek.safar@gmail.com>
2657 A fix for bugs #460847, #460772, #458049, #457339, #447807
2658 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2659 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2660 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2661 user lambdas used inside query clauses.
2663 2008-12-18 Marek Safar <marek.safar@gmail.com>
2665 A fix for bug #460229
2666 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2668 2008-12-18 Marek Safar <marek.safar@gmail.com>
2670 A fix for bug #459952
2671 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2673 2008-12-18 Marek Safar <marek.safar@gmail.com>
2675 A fix for bug #459630
2676 * convert.cs: Enum to valuetype conversion is not allowed.
2678 2008-12-18 Marek Safar <marek.safar@gmail.com>
2680 A fix for bug #457087
2681 * generic.cs: Don't crash when constraint comes from type
2684 2008-12-16 Marek Safar <marek.safar@gmail.com>
2686 A fix for bug #459221
2687 * anonymous.cs, statement.cs: Delay only captured this
2690 2008-12-12 Marek Safar <marek.safar@gmail.com>
2692 A fix for bug #457489
2693 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2694 and initialization to capture scope initializers correctly.
2696 2008-12-11 Marek Safar <marek.safar@gmail.com>
2698 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2699 ParameterReference refactoring.
2701 2008-12-03 Marek Safar <marek.safar@gmail.com>
2703 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2704 to be imported from any assembly.
2706 2008-12-03 Marek Safar <marek.safar@gmail.com>
2708 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2709 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2710 from anonymous method and lambda expression.
2712 2008-12-01 Marek Safar <marek.safar@gmail.com>
2714 A fix for bug #448560
2715 * expression.cs (As): Box any generic type arguments to be
2718 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2720 Add tripwire for implicit conversion bugs
2721 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2723 (MethodGroupExpr.OverloadResolve): Add sanity check between
2724 IsApplicable and VerifyArgumentsCompat.
2725 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2727 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2729 Fix build break in System.Data_test
2730 * convert.cs (ImplicitConversionExists): Move NullLiteral
2732 (ImplicitStandardConversionExists): ... here.
2734 2008-11-28 Marek Safar <marek.safar@gmail.com>
2736 * literal.cs: Emit correctly explicit null to nullable cast.
2738 2008-11-28 Marek Safar <marek.safar@gmail.com>
2740 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2743 2008-11-28 Marek Safar <marek.safar@gmail.com>
2745 A fix for bug #449005
2746 * convert.cs, nullable.cs: Use only one implicit nullable
2749 2008-11-27 Marek Safar <marek.safar@gmail.com>
2751 * convert.cs, literal.cs: More Convert cleanup is needed.
2753 2008-11-27 Marek Safar <marek.safar@gmail.com>
2755 * decl.cs, class.cs: Fixed misleading error message.
2757 2008-11-26 Marek Safar <marek.safar@gmail.com>
2759 A fix for bug #449005
2760 * nullable.cs (EmitEquality): Disable optimization for user operator
2763 2008-11-25 Marek Safar <marek.safar@gmail.com>
2765 A fix for bug #447027
2766 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2767 with context variables stored as expression instances.
2769 2008-11-25 Marek Safar <marek.safar@gmail.com>
2771 A fix for bug #447027
2772 * delegate.cs: Fixed delegate VerifyMethod logic.
2774 2008-11-24 Marek Safar <marek.safar@gmail.com>
2776 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2779 2008-11-21 Marek Safar <marek.safar@gmail.com>
2781 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2782 member type resolve to follow normal flow, instead of random
2785 2008-11-21 Marek Safar <marek.safar@gmail.com>
2787 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2790 2008-11-21 Marek Safar <marek.safar@gmail.com>
2792 * const.cs: Emit decimal array constant as literal.
2794 2008-11-20 Marek Safar <marek.safar@gmail.com>
2796 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2798 2008-11-19 Marek Safar <marek.safar@gmail.com>
2800 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2801 into real property (saves 8 MB for corlib compilation).
2803 2008-11-19 Marek Safar <marek.safar@gmail.com>
2805 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2806 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2807 generic-mcs.cs: Small cleanup of TypeArguments.
2809 2008-11-18 Marek Safar <marek.safar@gmail.com>
2811 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2812 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2813 of ConstructedType expression, renamed to GenericTypeExpr.
2815 2008-11-17 Marek Safar <marek.safar@gmail.com>
2817 A fix for bug #445303
2818 * location.cs (IsConditionalDefined): Handle undefined global
2821 2008-11-17 Marek Safar <marek.safar@gmail.com>
2823 A fix for bug #444678
2824 * expression.cs (TryReduceConstant): Always create new constant
2827 2008-11-17 Marek Safar <marek.safar@gmail.com>
2829 A fix for bug #444673
2830 * ecore.cs: Ignore open generic types when used as generic type
2833 2008-11-17 Marek Safar <marek.safar@gmail.com>
2835 A fix for bug #445458
2836 * expression.cs, cs-parser.jay: Don't crash when an expression
2839 2008-11-17 Marek Safar <marek.safar@gmail.com>
2841 A fix for bug #445464
2842 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2843 inside unbound type.
2845 2008-11-14 Jb Evain <jbevain@novell.com>
2847 * driver.cs: ignore empty -nowarn argument such as
2848 the one in -nowarn:12,13,,.
2850 2008-11-13 Marek Safar <marek.safar@gmail.com>
2852 A fix for bug #444271
2853 * anonymous.cs: Rescan parent storeys when best candidate was
2856 2008-11-13 Marek Safar <marek.safar@gmail.com>
2858 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2859 useless UnboundTypeExpression.
2861 * attribute.cs: Do check obsolete attribute on generic types.
2863 2008-11-12 Marek Safar <marek.safar@gmail.com>
2865 A fix for bugs #425680, #400139
2866 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2869 2008-11-11 Marek Safar <marek.safar@gmail.com>
2871 A fix for bug #435747
2872 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2873 compound value types assignment. Few micro optimizations added.
2875 2008-11-10 Marek Safar <marek.safar@gmail.com>
2877 A fix for bug #442610
2878 * anonymous.cs (MutateConstructor): More SRE hacking.
2880 2008-11-10 Marek Safar <marek.safar@gmail.com>
2882 A fix for bug #442579
2883 * ecore.cs: Also initialize expanded form of a method with 1 params
2886 2008-11-06 Marek Safar <marek.safar@gmail.com>
2888 * expression.cs (UnaryMutator): Do early l-side check.
2890 2008-11-05 Miguel de Icaza <miguel@novell.com>
2892 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2893 Init, otherwise we would crash later on when checking for friend
2896 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2897 Otherwise we never get any meaningful information as to what
2900 2008-11-05 Marek Safar <marek.safar@gmail.com>
2902 A fix for bug #436318
2903 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2905 2008-11-05 Miguel de Icaza <miguel@novell.com>
2907 * namespace.cs: Turns out that it was a really bad idea to hide
2908 the errors for namespaces not found here in eval mode.
2910 * eval.cs: When we process using clauses, only enter those into
2911 the list of valid using clauses after they have been validated.
2913 The above change gives the proper semantics: it does not
2914 senselessly report the same errors with broken using statements by
2915 never storing them in the first place when they are invalid.
2917 2008-11-05 Marek Safar <marek.safar@gmail.com>
2919 A fix for bug #421839
2920 * cs-parser.jay: Remove expression from coalesce rule to force lower
2921 priority than the assignment operator.
2923 2008-11-05 Marek Safar <marek.safar@gmail.com>
2925 A fix for bug #437875
2926 * nullable.cs: Compile correctly method group operand used with null
2927 coalescing operator.
2929 2008-11-04 Marek Safar <marek.safar@gmail.com>
2931 A fix for bug #434589
2932 * expression.cs (Binary): Ignore lifted conversions when at least
2933 one operand is of reference type.
2935 2008-11-04 Marek Safar <marek.safar@gmail.com>
2937 * cs-parser.jay: Better syntax error report.
2939 2008-11-03 Marek Safar <marek.safar@gmail.com>
2941 A fix for bug #436792
2942 * cs-parser.jay: Use GetLocation to access location.
2944 2008-11-03 Marek Safar <marek.safar@gmail.com>
2946 A fix for bug #440774
2947 * cs-parser.jay: Also set current_array_type when parsing local
2950 2008-11-03 Marek Safar <marek.safar@gmail.com>
2952 A fix for bug #440785
2953 * expression.cs (As): Don't resolve self modifing expression
2956 2008-11-03 Marek Safar <marek.safar@gmail.com>
2958 A fix for bug #439447
2959 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2961 2008-11-03 Marek Safar <marek.safar@gmail.com>
2963 A fix for bug #437571
2964 * cs-parser.jay: Fixes internal error for invalid expression
2967 2008-10-17 Marek Safar <marek.safar@gmail.com>
2969 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2971 2008-10-17 Marek Safar <marek.safar@gmail.com>
2973 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2975 2008-10-17 Marek Safar <marek.safar@gmail.com>
2977 * cs-tokenizer.cs: More precise cast parsing.
2979 2008-10-16 Martin Baulig <martin@ximian.com>
2981 * anonymous.cs (AnonymousMethodStorey): Put back the
2982 `hoisted_locals' hashtable and use it in EmitType().
2984 2008-10-15 Marek Safar <marek.safar@gmail.com>
2986 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2987 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2990 2008-10-14 Marek Safar <marek.safar@gmail.com>
2992 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2994 2008-10-14 Marek Safar <marek.safar@gmail.com>
2996 * statement.cs: Mutate scope initializers.
2998 2008-10-14 Marek Safar <marek.safar@gmail.com>
3000 * expression.cs: Use typeless value for This constant.
3002 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
3004 2008-10-14 Marek Safar <marek.safar@gmail.com>
3006 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
3009 2008-10-13 Marek Safar <marek.safar@gmail.com>
3011 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
3014 2008-10-13 Marek Safar <marek.safar@gmail.com>
3016 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
3017 parser and tokenizer. Fixes many ambiguities including #433258.
3019 2008-10-10 Marek Safar <marek.safar@gmail.com>
3021 * cs-parser.jay: Fixed missing accessor recovery.
3023 2008-10-10 Marek Safar <marek.safar@gmail.com>
3025 A fix for bug #433701
3026 * expression.cs: Better error message.
3028 2008-10-10 Marek Safar <marek.safar@gmail.com>
3030 * cs-parser.jay, expression.cs: Start reporting real parser errors.
3032 * Makefile: Disabled unused debug symbols.
3034 Also fixes: #320556, #321097, #321656, #321876, #351316
3036 2008-10-09 Miguel de Icaza <miguel@novell.com>
3038 * eval.cs: rename "<interactive>" to "{interactive}", to work
3039 around a requirement in the compiler that this be a valid
3040 filename, and in Windows it is not (433886).
3042 2008-10-09 Marek Safar <marek.safar@gmail.com>
3044 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
3046 2008-10-08 Marek Safar <marek.safar@gmail.com>
3048 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
3049 cs-parser.jay: Generic type declaration and type arguments cleanup.
3051 2008-10-05 Marek Safar <marek.safar@gmail.com>
3053 * cs-parser.jay: Allow parsing weird array creation construct.
3055 2008-10-05 Marek Safar <marek.safar@gmail.com>
3057 * cs-parser.jay: Conflicts reduction.
3059 2008-10-04 Marek Safar <marek.safar@gmail.com>
3061 * cs-parser.jay: Conflicts reduction.
3063 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
3066 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
3067 property. Add a 'count' hint about the use of the shared vector.
3068 Ensure that we don't leak out dirty bits.
3069 (UsageVector.MergeChild): Throw away information about variables
3071 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
3073 2008-10-03 Marek Safar <marek.safar@gmail.com>
3075 A fix for bug #431746
3076 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
3077 parameters when iterator is created.
3079 2008-10-03 Marek Safar <marek.safar@gmail.com>
3081 A fix for bug #431827
3082 * expression.cs: Fixed right based pointer arithmetic operations
3085 2008-10-03 Marek Safar <marek.safar@gmail.com>
3087 A fix for bug #353779
3088 * assign.cs, expression.cs: Fixed compound assignment conversions.
3090 2008-10-02 Marek Safar <marek.safar@gmail.com>
3092 A fix for bug #375262
3093 * statement.cs: Refactor ArrayForeach to be usable with string
3094 indexer. Optimized single dimentional arrays foreach.
3096 2008-10-02 Marek Safar <marek.safar@gmail.com>
3098 A fix for bug #431255
3099 * anonymous.cs, expression.cs: Removed broken optimization.
3101 2008-10-01 Marek Safar <marek.safar@gmail.com>
3103 * anonymous.cs: Use full type parameters of parent generic
3104 containers. Removed unnecessary AddParentStoreyReference call.
3106 2008-10-01 Marek Safar <marek.safar@gmail.com>
3108 A fix for bug #324702
3109 * class.cs: Use better shorter names for explicit interface member
3112 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
3114 2008-10-01 Marek Safar <marek.safar@gmail.com>
3116 * expression.cs: Use new interface to check fixed expression.
3118 2008-10-01 Marek Safar <marek.safar@gmail.com>
3120 A fix for bug #421101
3121 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
3122 interface to check for fixed fixed-buffers.
3124 2008-10-01 Marek Safar <marek.safar@gmail.com>
3126 A fix for bug #429264
3127 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
3129 * delegate.cs: Removed unnecessary casts.
3131 2008-09-30 Marek Safar <marek.safar@gmail.com>
3133 A fix for bug #352151
3134 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
3135 class.cs: Fixed already defined explicit interface members check.
3137 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
3139 cs-tokenizer.cs: Fix typo.
3141 2008-09-28 Miguel de Icaza <miguel@novell.com>
3143 * eval.cs (InteractiveBase): The quit command now just sets a
3144 flag, instead of calling Environment.Exit(), it is milder on
3147 CompiledMethod is now in Mono.CSharp, not nested inside
3148 the Evaluator, it was inconvenient to use.
3150 2008-09-27 Miguel de Icaza <miguel@novell.com>
3152 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
3153 code to be invoked without having to reparse.
3155 2008-09-27 Miguel de Icaza <miguel@novell.com>
3157 * ecore.cs: The recent changes to FieldExpr broke this as well.
3158 Fixes LINQ queries in the interactive shell.
3160 * Multiple files: indentation fixing for the Mono coding
3161 guidelines for the switch statement.
3163 * eval.cs: Make the Evaluator API thread safe.
3165 2008-09-26 Marek Safar <marek.safar@gmail.com>
3167 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
3168 constructor parsing.
3170 2008-09-26 Marek Safar <marek.safar@gmail.com>
3172 A fix for bug #325326
3173 * statement.cs: Check possible mistaken empty statement using
3174 explicit blocks only.
3176 2008-09-25 Miguel de Icaza <miguel@novell.com>
3178 * eval.cs (LoadAssembly, ReferenceAssembly): Call
3179 RootNamespace.ComputeNamespaces to update the internal list of
3180 namespaces, this is no longer done for us.
3182 (InteractiveBase): Use the Evaluator APIs instead of calling into
3185 2008-09-25 Marek Safar <marek.safar@gmail.com>
3187 A fix for bug #429264
3188 * expression.cs: Missing mutator for access to multidimensional
3191 2008-09-25 Marek Safar <marek.safar@gmail.com>
3193 * class.cs, statement: Emit DebuggerHidden attribute for iterator
3196 * driver.cs: Missing input argument check.
3198 2008-09-25 Marek Safar <marek.safar@gmail.com>
3200 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
3201 expression.cs, statement.cs, rootcontext.cs, class.cs,
3202 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
3205 2008-09-24 Miguel de Icaza <miguel@novell.com>
3207 * ecore.cs (FieldExpr): Only initialize eclass when we return a
3208 fully constructed FieldExpr, fixes the regression introduced in
3211 * ecore.cs, expression.cs: Plug back the eclass initialization as
3212 otherwise it regresses `csharp'.
3214 2008-09-24 Marek Safar <marek.safar@gmail.com>
3216 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
3217 ecore.cs, attribute.cs: Moved obsolete method checks from emit
3218 phase to resolve phase. It resolves problems with expression trees
3219 and fixes bugs #323796, #325156.
3221 2008-09-23 Marek Safar <marek.safar@gmail.com>
3223 * codegen.cs: Report better error when symbol writer is missing.
3225 2008-09-23 Marek Safar <marek.safar@gmail.com>
3227 * codegen.cs: Set .NET symbol writer.
3229 * decl.cs: Guard against null generic arguments.
3231 * report.cs: Don't report exactly same additional details.
3233 2008-09-22 Marek Safar <marek.safar@gmail.com>
3235 A fix for bug #324917
3236 * cs-parser.jay: Add missing multidimensional non-expression type
3239 2008-09-22 Marek Safar <marek.safar@gmail.com>
3241 A fix for bug #428191
3242 * anonymous.cs: Create an outer generic fields also for non-storey
3245 2008-09-22 Marek Safar <marek.safar@gmail.com>
3247 A fix for bug #378294
3248 * class.cs: Make fixed size buffers gmcs feature only.
3250 2008-09-22 Marek Safar <marek.safar@gmail.com>
3252 A fix for bug #355622, #324993
3253 * assign.cs, const.cs, class.cs: Create new EmitContext for each
3256 2008-09-19 Marek Safar <marek.safar@gmail.com>
3258 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
3261 2008-09-19 Marek Safar <marek.safar@gmail.com>
3263 A fix for bug #416110
3264 * generic.cs: Struct constraint results in default ctor and
3265 ValueType base type constraint to be set.
3267 2008-09-19 Marek Safar <marek.safar@gmail.com>
3269 A fix for bug #423791
3270 * generic.cs: Fixed params output type type-inference.
3272 2008-09-19 Marek Safar <marek.safar@gmail.com>
3274 * cs-parser.jay, expression.cs: Fixed few expression crashes.
3276 2008-09-19 Marek Safar <marek.safar@gmail.com>
3278 * cs-tokenizer.cs: Don't break on extra partial modifier.
3280 2008-09-19 Marek Safar <marek.safar@gmail.com>
3282 A fix for bug #427592
3283 * generic.cs: Use common parameter resolve method.
3285 2008-09-18 Marek Safar <marek.safar@gmail.com>
3287 A fix for bug #414758
3288 * expression.cs, ecore.cs: Fixed crash when accessing non-static
3291 2008-09-18 Marek Safar <marek.safar@gmail.com>
3293 * driver.cs, namespace.cs: Read types and namespaces after all
3294 requested assemblies are loaded, fixes issues with System.Core
3295 auto-reference, and #419888.
3297 2008-09-18 Marek Safar <marek.safar@gmail.com>
3299 A fix for bug #417705
3300 * cs-parser.jay: Fixed as/is operator expression split.
3302 2008-09-18 Marek Safar <marek.safar@gmail.com>
3304 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3305 Fixed expression tree representation of empty new expression and
3306 new initializer expression.
3308 2008-09-18 Miguel de Icaza <miguel@novell.com>
3310 * eval.cs: Remove warning, keep reference to driver around.
3312 * Hide fields that do not need to be public.
3314 2008-09-17 Marek Safar <marek.safar@gmail.com>
3316 A fix for bug #426385
3317 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3318 conversion for array elements.
3320 2008-09-17 Marek Safar <marek.safar@gmail.com>
3322 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3323 void parsing conflicts.
3325 2008-09-15 Marek Safar <marek.safar@gmail.com>
3327 A fix for bug #425601
3328 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3329 System.Core only when there is no custom ExtensionAttribute
3332 2008-09-15 Miguel de Icaza <miguel@novell.com>
3334 * namespace.cs: Do not report CS0246 (name
3336 2008-09-12 Marek Safar <marek.safar@gmail.com>
3338 A fix for bug #425669
3339 * generic.cs: Don't cache generic static anonymous method
3342 2008-09-12 Marek Safar <marek.safar@gmail.com>
3344 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3345 conflicting constraints.
3347 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3349 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3352 2008-09-12 Marek Safar <marek.safar@gmail.com>
3354 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3355 to null pointer conversion fixes.
3357 2008-09-11 Marek Safar <marek.safar@gmail.com>
3359 * cs-parser.jay, expression.cs: An implicitly typed local variable
3360 declarator cannot use an array initializer.
3362 2008-09-11 Marek Safar <marek.safar@gmail.com>
3364 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3366 2008-09-11 Marek Safar <marek.safar@gmail.com>
3368 * generic.cs (InflatedConstraints): Don't crash when constraints
3371 * cs-parser.jay: const_declarator is a block.
3373 * constant.cs: Check for not allowed NaN conversions.
3375 2008-09-10 Miguel de Icaza <miguel@novell.com>
3377 * driver.cs: Drop --shell argument, the compiler is no longer a
3380 * eval.cs: Move most of the code that deals with evaluation into
3381 this file and document the public API from repl.cs
3383 * repl.cs: Remove from here.
3385 2008-09-10 Marek Safar <marek.safar@gmail.com>
3387 A fix for bug #424684
3388 * generic.cs: Generic class constraints must come first.
3390 2008-09-09 Miguel de Icaza <miguel@novell.com>
3392 * cs-parser.jay: Improve error reporting for syntax errors in
3393 statements and expressions, we now report the expected tokens
3394 instead of reporting the useless "; expected".
3396 Drop the strings from the token declaration, it turns out that
3397 they did not do what I thought they did. Instead they were adding
3398 two sets of tokens to the tables.
3400 2008-09-09 Marek Safar <marek.safar@gmail.com>
3402 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3403 delegate.cs: Share special type check.
3405 2008-09-09 Marek Safar <marek.safar@gmail.com>
3407 A fix for bug #423981
3408 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3410 2008-09-09 Marek Safar <marek.safar@gmail.com>
3412 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3415 2008-09-09 Marek Safar <marek.safar@gmail.com>
3417 A fix for bugs: #324750, #335946
3418 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3419 lookup rule to determine ?-based tokens.
3421 2008-09-08 Miguel de Icaza <miguel@novell.com>
3423 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3424 expressions (like event adding or removing) end up here, so we
3425 need to treat those as statements.
3427 Add LoadAssembly method.
3429 2008-09-04 Miguel de Icaza <miguel@novell.com>
3431 * repl.cs: Add Time method.
3433 2008-09-05 Marek Safar <marek.safar@gmail.com>
3435 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3437 2008-09-05 Miguel de Icaza <miguel@novell.com>
3439 * repl.cs: Add workaround for old compilers.
3441 2008-09-04 Jb Evain <jbevain@novell.com>
3443 * repl.cs (PrettyPrint): pretty print everything that
3444 implements IDictionary, as well as IEnumerables. Also,
3445 add a quit helper property.
3447 2008-09-04 Marek Safar <marek.safar@gmail.com>
3449 * constant.cs: Better error reporting for decimal literals.
3451 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3454 2008-09-04 Marek Safar <marek.safar@gmail.com>
3455 Miguel de Icaza <miguel@novell.com>
3457 A fix for bug #422951
3458 * assign.cs (Assign.DoResolve): Perform the type conversions
3459 checks before we attempt to initialize `New' initializers.
3461 2008-09-04 Marek Safar <marek.safar@gmail.com>
3463 A fix for bug #422853
3464 * delegate.cs (DelegateCreation): Add special handling for
3465 EmptyExpression.Null instance expression which is just another
3466 hack for undecided member instance exression.
3468 2008-09-04 Marek Safar <marek.safar@gmail.com>
3470 * expression.cs, ecore.cs: Emit full expression tree for reduced
3473 2008-09-04 Marek Safar <marek.safar@gmail.com>
3475 * expression.cs (This): Guard against multi-resolving.
3477 * ecore.cs, statement.cs (Throw): Simplified.
3479 * flowanalysis.cs: Also verify event fields.
3481 2008-09-04 Miguel de Icaza <miguel@novell.com>
3483 * assign.cs (Assign.DoResolve): Perform the type conversions
3484 checks before we attempt to initialize `New' initializers.
3486 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3488 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3491 * repl.cs: Update help.
3493 2008-09-03 Miguel de Icaza <miguel@novell.com>
3495 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3496 handling of the default config handling, including the special
3497 treatment of System.Core assembly.
3499 Fixes the REPL processing for LINQ.
3501 2008-09-03 Marek Safar <marek.safar@gmail.com>
3503 A fix for bug #422507
3504 * expression.cs (UnboxCast): Add missing child expression mutator.
3506 2008-09-03 Marek Safar <marek.safar@gmail.com>
3508 * driver.cs: Don't self reference System.Core assembly.
3510 2008-09-03 Marek Safar <marek.safar@gmail.com>
3512 A fix for bug #422507
3513 * expression.cs (StringConcat): Add missing type mutator.
3515 2008-09-03 Marek Safar <marek.safar@gmail.com>
3517 * generic.cs (TypeInferenceContext): Follow equality rule for
3518 constructed type lower bound type inference.
3520 2008-09-02 Miguel de Icaza <miguel@novell.com>
3522 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3523 <dblank@cs.brynmawr.edu> which updates the cursor position on
3526 2008-09-02 Marek Safar <marek.safar@gmail.com>
3528 A fix for bug #367145
3529 * driver.cs: Fixed import of extension methods when using -noconfig
3532 2008-09-02 Marek Safar <marek.safar@gmail.com>
3534 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3535 version from non-generic implementation instead.
3537 2008-09-01 Marek Safar <marek.safar@gmail.com>
3539 A fix for bug #418908
3540 * class.cs: Use AddScopeStatement for field initializers.
3542 2008-09-01 Marek Safar <marek.safar@gmail.com>
3544 A fix for bug #415385
3545 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3547 2008-09-01 Marek Safar <marek.safar@gmail.com>
3549 A fix for bug #421736
3550 * iterators.cs: Don't crash on unreachable iterators.
3552 2008-09-01 Marek Safar <marek.safar@gmail.com>
3554 A fix for bug #421628
3555 * parameter.cs, attribute.cs: Clone also parameter attributes.
3557 2008-08-30 Miguel de Icaza <miguel@novell.com>
3559 * namespace.cs (LookupType): In EvalMode, try to replace
3560 the TypeBuilder from our cache with a Type as Reflection.Emit does
3561 not like to mix code from older assemblies emitted and new
3564 This sounds like a serious Mono bug that prevents multiple
3565 assemblies to be generated and consumed at the same time.
3567 * cs-parser.jay (push_current_class): Do not make interactive
3568 classes internal or private, make them public as we currently
3569 generate each new class in a new assembly.
3571 2008-08-29 Miguel de Icaza <miguel@novell.com>
3573 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3574 remove types that are entered into the global namespace during
3575 parsing so that we can remove them on failure.
3577 * cs-parser.jay: Parsing: we now keep track of types that are
3578 entered into global variables and queue those in case the parsing
3581 This happens in a few situations: during partial-input, we invoke
3582 the parser repeatedly for example with the string "class X", this
3583 would cause X to be registed, and we need to remove this
3584 registration so that another parse attempt later with say "class X {"
3585 would actually work.
3587 Additionally, if there is an error in the resolution phase, for
3588 example: "class X : NonExistant {}" th
3590 * cs-parser.jay: Be more precise with the errors being raised,
3591 instead of flagging all exceptions during parsing to be attributed
3592 to the parsing process, distinguish those from errors happening in
3593 the actions and hint that using -v would produce the actual
3596 * repl.cs: Do not load all compiler references on each reset,
3597 doing the partial reset takes care of this.
3599 2008-08-28 Miguel de Icaza <miguel@novell.com>
3601 * repl.cs: Add support for loading all the files from
3602 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3605 Introduce a micro-parser that is able to deambiguate on its input
3606 whether we are dealing with a compilation unit (namespace, class,
3607 interface, struct, delegate) declaration or a statement. This
3608 allows both declarations and statements to be entered.
3610 Set history size by default to 300 lines.
3612 Instead of distinguishing based on the parser.InteractiveResult,
3613 have only two cases: statements were parsed, or a compilation unit
3614 was. Always pull the Using statement additions from the
3615 compilation unit parse.
3617 * cs-tokenizer.cs: Rename tokens to better describe their intent
3618 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3620 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3621 EvalMode is used to trigger the lookup of global variables while
3622 StatementMode is used turn variable declarations into static
3625 * getline.cs: Allow history size to be set.
3627 2008-08-29 Marek Safar <marek.safar@gmail.com>
3629 A fix for bug #360755
3630 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3632 2008-08-29 Marek Safar <marek.safar@gmail.com>
3634 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3636 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3637 member name, it is too confusing
3639 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3641 * rootcontext.cs: Finally default to warning level 4.
3643 2008-08-28 Marek Safar <marek.safar@gmail.com>
3645 * class.cs (CheckBase): Ignore overloaded operators.
3647 2008-08-28 Marek Safar <marek.safar@gmail.com>
3649 A fix for bug #420830
3650 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3652 2008-08-28 Marek Safar <marek.safar@gmail.com>
3654 A fix for bug #420832
3655 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3657 2008-08-28 Marek Safar <marek.safar@gmail.com>
3659 A fix for bug #420386
3660 * nullables.cs: Fixed logic of nullable user comparison operators involving
3663 2008-08-28 Marek Safar <marek.safar@gmail.com>
3665 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3667 2008-08-27 Miguel de Icaza <miguel@novell.com>
3669 * repl.cs: Add support for aborting the running code with C-c.
3671 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3673 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3675 2008-08-27 Miguel de Icaza <miguel@novell.com>
3677 * cs-parser.jay (interactive_statement_list): A new set of rules
3678 for hosting statements that uses the "interactive_" prefix.
3680 * repl.cs: Add support for parsing `using' as a statement or as a
3681 directive. Deambiguating before passing this to the parser.
3683 We need to distinguish statement_expressions that occur at the
3684 toplevel vs those that occur embedded into expressions.
3686 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3687 that fixes the cursor key handling, and a history bug.
3689 2008-08-26 Miguel de Icaza <miguel@novell.com>
3691 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3692 limitations in Console, instead the 2.0 bootstrap libraries now
3693 include the Console bits.
3695 Also, remove the use of Nullables from getline.cs
3699 Interactive support for the C# compiler. Use gmcs --shell to
3700 enter a read-eval-print loop shell.
3702 Docs: http://www.mono-project.com/CsharpRepl
3704 * sources: include repl.cs here and getline.cs for gmcs.exe,
3705 everything else is getline.cs impaired.
3707 * Makefile: when bootstrapping pass a special flag
3708 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3709 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3710 This distinguishes those two cases.
3712 * repl.cs: Support for a read-eval-print loop. Will be soon
3713 refactored into eval support and then REPL on top of it.
3715 * ecore.cs: If a simplename lookup fails, before erroring out,
3716 if we are in EvalMode to resolve the name to a declaration in the
3719 This means that variable declarations that happened in previous
3720 classes (as repl puts every statement in a separate class) are
3721 made visible in this way.
3723 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3724 triggered an error due to the end of file being reached. This is
3725 used to do multi-line input, and notify the caller that the user
3726 needs to provide more text before a successful parse.
3728 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3729 to drive the evaluation with a custom wrapper.
3731 * driver.cs: Add support for --shell, and refactor some code to be
3734 * namespace.cs: Add support for serializing the contents of the
3735 namespaces and reloading them.
3737 * getline.cs: A managed implementation of ReadLine under
3738 X11/Apache2 license terms. Easy to embed in other applications as
3741 * namespace.cs: Add some functions to save and restore the
3744 * rootcontext.cs: New public field.
3746 * cs-tokenizer.cs: Add support for one of the possible characters
3747 we introduce into the token stream.
3749 This patch does not affect the regular tokenization process, the
3750 only performance hit would happen if there is an invalid character
3751 on the input string.
3753 * support.cs: Move isatty helper routine here.
3755 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3756 code generator for in-memory assemblies.
3758 2008-08-26 Marek Safar <marek.safar@gmail.com>
3760 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3761 parameter cannot be always used as a type.
3763 2008-08-21 Marek Safar <marek.safar@gmail.com>
3765 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3767 2008-08-21 Marek Safar <marek.safar@gmail.com>
3769 * convert.cs: Implement explicit array to IList<T> conversion.
3771 2008-08-20 Marek Safar <marek.safar@gmail.com>
3773 A fix for bug #362740
3774 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3776 2008-08-20 Marek Safar <marek.safar@gmail.com>
3778 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3779 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3780 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3781 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3782 handling to use just one type of infrastructure and deal with generics
3785 2008-07-23 Martin Baulig <martin@ximian.com>
3787 *** Merged this from trunk revision 108527 ***
3790 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3791 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3794 2008-08-15 Marek Safar <marek.safar@gmail.com>
3796 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3799 2008-08-15 Marek Safar <marek.safar@gmail.com>
3801 * delegate.cs: Fixed compiler crash when creating delegate using partial
3804 * typemanager.cs: MulticastDelegate is not a delegate.
3806 2008-08-14 Marek Safar <marek.safar@gmail.com>
3808 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3811 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3813 * cs-parser.jay (type): Allow 'var' in mcs too.
3814 (local_variable_type): Likewise.
3816 2008-08-14 Marek Safar <marek.safar@gmail.com>
3818 * driver.cs: Removed broken -noconfig variants.
3820 2008-08-14 Marek Safar <marek.safar@gmail.com>
3822 A fix for bug #417078
3823 * expression.cs: Emit correctly left side pointer operators.
3825 2008-08-13 Marek Safar <marek.safar@gmail.com>
3827 * generic.cs, lambda.cs: Inflate method generic arguments only.
3829 2008-08-12 Marek Safar <marek.safar@gmail.com>
3831 * class.cs: Fixed struct layout check regression.
3833 2008-08-12 Marek Safar <marek.safar@gmail.com>
3835 * cs-parser.jay, enum.cs: Simplified enum parsing.
3837 * decl.cs: Check all type parameters conflicts.
3839 * expression.cs, statement.cs, attribute.cs: More expression checks.
3841 2008-08-11 Marek Safar <marek.safar@gmail.com>
3843 * generic.cs: Add type inference types restriction.
3845 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3846 anonymous.cs, expression.cs: Allocate less accessor parameters.
3848 2008-08-08 Marek Safar <marek.safar@gmail.com>
3850 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3853 2008-08-08 Marek Safar <marek.safar@gmail.com>
3855 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3857 2008-08-07 Marek Safar <marek.safar@gmail.com>
3859 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3860 Also fixes #362146 and #381592.
3862 2008-08-07 Marek Safar <marek.safar@gmail.com>
3864 * ecore.cs: Reduced constant cannot be used as an attribute value.
3866 * cs-parser.jay: Base expression has to be a type.
3868 * expression.cs (Conditional): Uses ReducedExpression.
3870 2008-08-06 Marek Safar <marek.safar@gmail.com>
3872 A fix for bug #376826
3873 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3874 address of hoisted local variable or parameter cannot be taken.
3876 2008-08-05 Marek Safar <marek.safar@gmail.com>
3878 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3879 anonymous method inside checked/unchecked expression.
3881 2008-08-05 Marek Safar <marek.safar@gmail.com>
3883 * typemanager.cs (IsEqual): Guard against null.
3885 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3886 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3887 routine. Fixed few misleading conversion errors.
3889 2008-08-04 Marek Safar <marek.safar@gmail.com>
3891 * class.cs: Consider generics when checking cycles in struct layout.
3893 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3895 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3897 2008-08-04 Marek Safar <marek.safar@gmail.com>
3899 A fix for bug #414165
3900 * anonymous.cs: Use same anonymous implementation method for all anonymous
3903 2008-08-04 Marek Safar <marek.safar@gmail.com>
3905 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3908 2008-08-04 Marek Safar <marek.safar@gmail.com>
3910 * cs-parser.jay: Typeof argument has to be a type expression.
3912 * namespace.cs: Check alias and namespace definitions collisions.
3914 * class.cs, pending.cs: Moved explicit interface accessor implementation
3917 * delegate.cs, expression.cs: Verify special name invocations.
3919 2008-08-01 Marek Safar <marek.safar@gmail.com>
3921 * cs-parser.jay: Don't choke on empty generic type arguments.
3923 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3925 * expression.cs, ecore.cs: Minor expressions bugs.
3927 2008-08-01 Marek Safar <marek.safar@gmail.com>
3929 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3930 and added more error handling.
3932 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3934 * modifiers.cs, enum.cs: Fixed.
3936 2008-07-31 Jb Evain <jbevain@novell.com>
3938 * driver.cs: remove -pkg ability of smcs.
3940 2008-07-30 Marek Safar <marek.safar@gmail.com>
3942 * statement.cs (Switch): Correctly set empty default target for single
3945 2008-07-30 Marek Safar <marek.safar@gmail.com>
3947 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3948 string switch statement implementation to use string dictionary which
3949 significantly (2-8x) improves performance of generated code.
3951 2008-07-29 Marek Safar <marek.safar@gmail.com>
3953 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3954 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3956 2008-07-29 Marek Safar <marek.safar@gmail.com>
3958 A fix for bug #412595
3959 * typemanager.cs, convert.cs, expression.cs: Some types are never
3960 convertible to each other.
3962 2008-07-29 Marek Safar <marek.safar@gmail.com>
3964 * nullable.cs (CreateNullConstant): An error messages update.
3966 2008-07-29 Marek Safar <marek.safar@gmail.com>
3968 A fix for bug #412595
3969 * cfold.cs: Don't cast undefined bool constant.
3971 2008-07-29 Martin Baulig <martin@ximian.com>
3974 (SymbolWriter.Reset): New public static method.
3977 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3979 2008-07-28 Marek Safar <marek.safar@gmail.com>
3981 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3983 * expression.cs (ElementAccess): Exact size allocation.
3985 2008-07-26 Marek Safar <marek.safar@gmail.com>
3987 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3989 2008-07-25 Marek Safar <marek.safar@gmail.com>
3991 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3993 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3996 2008-07-25 Marek Safar <marek.safar@gmail.com>
3998 A fix for bug #412217
3999 * assign.cs: Mutate also assignment type.
4001 2008-07-25 Marek Safar <marek.safar@gmail.com>
4003 A fix for bug #323644
4004 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
4007 2008-07-25 Marek Safar <marek.safar@gmail.com>
4009 A fix for bug #412134
4010 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
4011 non-enumerable operands when overloading equality or bitwise operators.
4013 2008-07-25 Marek Safar <marek.safar@gmail.com>
4015 * anonymous.cs: Cache closed generic anonymous method delegates.
4017 2008-07-24 Marek Safar <marek.safar@gmail.com>
4019 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
4020 anonymous.cs, statement.cs: Always emit anonymous method as static method
4021 when is instance free. Use nesting for nested anynomous methods blocks.
4023 2008-07-23 Marek Safar <marek.safar@gmail.com>
4025 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
4028 2008-07-23 Marek Safar <marek.safar@gmail.com>
4030 * expression.cs: Removed MakeSimpleCall.
4032 2008-07-23 Marek Safar <marek.safar@gmail.com>
4034 A fix for bug #323012
4035 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
4036 Base method implementing interface has to be public.
4038 2008-07-23 Marek Safar <marek.safar@gmail.com>
4040 * cs-parser.jay: Don't break on missing argument.
4042 2008-07-22 Marek Safar <marek.safar@gmail.com>
4044 A fix for bug #320993
4045 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
4046 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
4048 2008-07-22 Marek Safar <marek.safar@gmail.com>
4050 A fix for bug #320748
4051 * convert.cs: Implicit user operators cannot convert to interfaces
4053 2008-07-22 Marek Safar <marek.safar@gmail.com>
4055 A fix for bug #312686
4056 * driver.cs: Ignore empty assembly references.
4058 2008-07-22 Marek Safar <marek.safar@gmail.com>
4060 A fix for bug #387040
4061 * ecore.cs: Skip constrains check for an explicit implementation.
4063 2008-07-21 Marek Safar <marek.safar@gmail.com>
4065 A fix for bug #409045
4066 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
4067 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
4068 identifiers are file specific unless passed as input arguments.
4070 2008-07-21 Marek Safar <marek.safar@gmail.com>
4072 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
4073 to emit UnmanagedMarshal data under 2.0 profile.
4075 2008-07-21 Marek Safar <marek.safar@gmail.com>
4077 A fix for bug #410369
4078 * parameter.cs: Clone correctly ParamsParameter.
4080 2008-07-21 Marek Safar <marek.safar@gmail.com>
4082 * expression.cs (Argument): Always report type for type based expressions
4085 2008-07-18 Marek Safar <marek.safar@gmail.com>
4087 A fix for bug #410666
4088 * anonymous.cs: Correctly initialize generic storey reference.
4090 2008-07-18 Marek Safar <marek.safar@gmail.com>
4092 * convert.cs: Don't box same type arguments.
4094 2008-07-18 Marek Safar <marek.safar@gmail.com>
4096 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
4097 Finished missing generic type mutators.
4099 2008-07-18 Marek Safar <marek.safar@gmail.com>
4101 * iterators.cs, statement.cs: Finished statements CloneTo.
4103 2008-07-18 Marek Safar <marek.safar@gmail.com>
4105 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
4107 * expression.cs: Emit optimized default value expressions in expression tree
4110 2008-07-18 Marek Safar <marek.safar@gmail.com>
4112 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
4114 2008-07-17 Marek Safar <marek.safar@gmail.com>
4116 A fix for bug #367536
4117 * cs-parser.jay: Check static constructor of generic types for an access
4120 2008-07-17 Marek Safar <marek.safar@gmail.com>
4122 A fix for bug #353800
4123 * lambda.cs: Emit ret for contextual statements.
4125 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
4126 up emitting redundant ret for all anonymous methods with return.
4128 2008-07-17 Marek Safar <marek.safar@gmail.com>
4130 A fix for bug #365188
4131 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
4132 create anonymous method storey in unreachable block.
4134 2008-07-17 Marek Safar <marek.safar@gmail.com>
4136 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
4137 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
4138 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
4139 statement.cs: Fixed relevant defects found by Gendarme.
4141 2008-07-17 Marek Safar <marek.safar@gmail.com>
4143 A fix for bug #325291
4144 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
4145 statement.cs: Replaced IAnonymousHost with top level block flag.
4147 2008-07-17 Marek Safar <marek.safar@gmail.com>
4149 * cs-parser.jay: Clean up unused open_parens.
4151 2008-07-17 Marek Safar <marek.safar@gmail.com>
4153 * ecore.cs: Custom error message for a range variable assignment.
4155 2008-07-16 Marek Safar <marek.safar@gmail.com>
4157 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
4160 2008-07-16 Marek Safar <marek.safar@gmail.com>
4162 * literal.cs: Null literal is of object type.
4164 2008-07-16 Marek Safar <marek.safar@gmail.com>
4166 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
4167 expression of nullable equality comparison.
4169 2008-07-15 Marek Safar <marek.safar@gmail.com>
4171 * expression.cs(PointerArithmetic): Removed redundant assignment.
4173 2008-07-15 Marek Safar <marek.safar@gmail.com>
4175 * decl.cs (GetSignatureForError): Report full namespace name for containers.
4177 2008-07-14 Marek Safar <marek.safar@gmail.com>
4179 A fix for bug #408361
4180 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
4181 they are replaced by GetMethod.
4183 2008-07-14 Marek Safar <marek.safar@gmail.com>
4185 A fix for bug #408721 by jeremie.laval@gmail.com
4186 * expression.cs (Indirection): Implemented CloneTo.
4188 2008-07-14 Marek Safar <marek.safar@gmail.com>
4190 * statement.cs (AssignableSlots): Temporary disabled variable initialization
4193 2008-07-14 Marek Safar <marek.safar@gmail.com>
4195 * report.cs (EnableReporting): Don't reinitialize 0-based values.
4197 2008-07-11 Marek Safar <marek.safar@gmail.com>
4199 * linq.cs: Reset tranparent parameter counter in probing mode.
4201 2008-07-11 Marek Safar <marek.safar@gmail.com>
4203 * anonymous.cs: Mutate anonymous method type.
4205 2008-07-11 Marek Safar <marek.safar@gmail.com>
4207 * ecore.cs, anonymous.cs: Mutate field expressions.
4209 2008-07-10 Marek Safar <marek.safar@gmail.com>
4211 A fix for bug #369670
4212 * linq.cs, statement.cs: Use explicit block for query expressions variables.
4214 2008-07-10 Marek Safar <marek.safar@gmail.com>
4216 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
4218 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
4221 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
4222 only one '>', and finds a '>>', abort the generic lookahead.
4224 2008-07-10 Marek Safar <marek.safar@gmail.com>
4226 A fix for bug #319902
4227 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
4229 2008-07-10 Marek Safar <marek.safar@gmail.com>
4231 A fix for bug #406371
4232 * statement.cs: Moved EmitSymbolInfo to Block.
4234 2008-07-09 Marek Safar <marek.safar@gmail.com>
4236 * ecore.cs: Report better error for extension method overload failures.
4238 2008-07-09 Marek Safar <marek.safar@gmail.com>
4240 * expression.cs (Is): No need to box reference values.
4242 2008-07-09 Marek Safar <marek.safar@gmail.com>
4244 * class.cs: Use event resolve context when initializing CreateEmitContext.
4246 2008-07-09 Marek Safar <marek.safar@gmail.com>
4248 A fix for bug #394436
4249 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
4250 method used inside expression trees. Added more LINQ to expression tree
4253 2008-07-08 Marek Safar <marek.safar@gmail.com>
4255 A fix for bug #378189, #370577
4256 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
4259 2008-07-08 Marek Safar <marek.safar@gmail.com>
4261 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
4264 2008-07-08 Marek Safar <marek.safar@gmail.com>
4266 A fix for bug #406702
4267 * anonymous.cs: Always park anonymous method in the nearest parent storey.
4269 2008-07-07 Marek Safar <marek.safar@gmail.com>
4271 A fix for bug #406648
4272 * cs-parser.jay: Report nullable use in mcs for some cases.
4274 2008-07-07 Marek Safar <marek.safar@gmail.com>
4276 * ecore.cs: Improved argument mismatch error messages.
4278 2008-07-07 Marek Safar <marek.safar@gmail.com>
4280 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
4282 2008-07-07 Marek Safar <marek.safar@gmail.com>
4284 * expression.cs (TypeOf): Mutate type argument.
4286 2008-07-04 Marek Safar <marek.safar@gmail.com>
4288 * class.cs: Report missing partial modifier for correct type.
4290 2008-07-04 Marek Safar <marek.safar@gmail.com>
4292 * ecore.cs, expression.cs (VariableReference): Variable property is
4295 2008-07-04 Marek Safar <marek.safar@gmail.com>
4297 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4299 2008-07-04 Marek Safar <marek.safar@gmail.com>
4301 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4304 2008-07-04 Marek Safar <marek.safar@gmail.com>
4306 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4307 anonymous method storey to an instance method when only "this" is hoisted.
4309 2008-07-03 Marek Safar <marek.safar@gmail.com>
4311 A fix for bug #321615
4312 * expression.cs: Pointer comparisons use unsigned operator.
4314 2008-07-03 Marek Safar <marek.safar@gmail.com>
4316 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4318 2008-07-02 Marek Safar <marek.safar@gmail.com>
4320 A fix for bug #404905
4321 * class.cs: Always initialize local unsafe variables.
4323 2008-06-30 Marek Safar <marek.safar@gmail.com>
4325 A fix for bug #396987
4326 * expression.cs (NewInitialize): Clear local temporary variable for next run
4328 2008-06-27 Marek Safar <marek.safar@gmail.com>
4330 A fix for bug #401020
4331 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4333 2008-06-27 Marek Safar <marek.safar@gmail.com>
4335 A fix for bug #398319
4336 * cs-parser.jay: Implemented undocumented base access expression inside
4339 2008-06-26 Marek Safar <marek.safar@gmail.com>
4341 A fix for bug #404227
4342 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4344 2008-06-26 Marek Safar <marek.safar@gmail.com>
4346 A fix for bug #404227
4347 * convert.cs: Fixed explicit array to interface cast.
4349 2008-06-26 Marek Safar <marek.safar@gmail.com>
4351 A fix for bug #403894
4352 * delegate.cs: Mutate DelegateInvocation type.
4354 2008-06-26 Marek Safar <marek.safar@gmail.com>
4356 A fix for bug #379348
4357 * delegate.cs: Box a load of generic parameters.
4359 2008-06-26 Marek Safar <marek.safar@gmail.com>
4361 * expression.cs: Add an array creation arguments mutate.
4363 2008-06-26 Marek Safar <marek.safar@gmail.com>
4365 A fix for bug #386068
4366 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4369 2008-06-25 Marek Safar <marek.safar@gmail.com>
4371 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4374 2008-06-25 Marek Safar <marek.safar@gmail.com>
4376 A fix for bug #403518
4377 * delegate.cs: Type correctly anonymous method new invocation.
4379 2008-06-24 Marek Safar <marek.safar@gmail.com>
4381 A fix for bug #394826
4382 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4385 2008-06-24 Marek Safar <marek.safar@gmail.com>
4387 A fix for bug #394826
4388 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4391 2008-06-24 Marek Safar <marek.safar@gmail.com>
4393 * class.cs: Clone indexer parameters for localized capturing.
4395 2008-06-24 Marek Safar <marek.safar@gmail.com>
4397 A fix for bug #402379
4398 * expression.cs: Don't crash when an object initializer resolve fails.
4400 2008-06-24 Marek Safar <marek.safar@gmail.com>
4402 A fix for bug #402888
4403 * expression.cs: Mutate conditional expression.
4405 2008-06-24 Marek Safar <marek.safar@gmail.com>
4407 A fix for bug #401012
4408 * class.cs: Keep StructLayout in shared container.
4410 2008-06-24 Marek Safar <marek.safar@gmail.com>
4412 A fix for bug #400438
4413 * decl.cs, class.cs: Only properties can be automatically implemented.
4415 2008-06-24 Marek Safar <marek.safar@gmail.com>
4417 * statement.cs (ChangeToIterator): Copy also labels.
4419 2008-06-23 Marek Safar <marek.safar@gmail.com>
4421 * ecore.cs: Pass type argument details to parent extension method.
4423 2008-06-23 Marek Safar <marek.safar@gmail.com>
4425 A fix for bug #375966
4426 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4428 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4430 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4432 2008-06-22 Marek Safar <marek.safar@gmail.com>
4434 A fix for bug #394347
4435 * anonymous.cs: Cache compatible delegates as compatibility check produces
4436 a new method every time.
4438 2008-06-20 Marek Safar <marek.safar@gmail.com>
4440 * anonymous.cs: Propagate storey reference for single references.
4442 2008-06-20 Marek Safar <marek.safar@gmail.com>
4444 A fix for bug #387615
4445 * assign.cs, expression.cs: Correctly clone compound assignment.
4447 2008-06-19 Marek Safar <marek.safar@gmail.com>
4449 A fix for bug #359611, #359604
4450 * anonymous.cs: Mutate all types of hoisted parameters.
4452 2008-06-19 Marek Safar <marek.safar@gmail.com>
4454 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4455 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4456 expression.cs, codegen.cs, statement.cs
4458 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4459 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4461 ** Anonymous methods, lambda expressions rewrite **
4463 Anonymous expressions are now resolved when an explicit block is resolved
4464 and they don't require any registration procedure anymore. Further,
4465 anonymous methods are defined when explicit block is emitted which allows
4466 better control of whole process and opens possibilities for more
4467 optimizations as well as alternative to reverse whole process.
4469 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4470 process consistent and to correctly emit hoisted generic methods when they
4471 have at least 1 hoisted variable.
4473 2008-06-17 Martin Baulig <martin@ximian.com>
4475 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4477 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4478 virtual property; check it in Emit().
4479 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4481 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4483 (Indexer.Define): Likewise.
4485 2008-06-17 Marek Safar <marek.safar@gmail.com>
4487 * convert.cs: Don't use IsInterface on type arguments.
4489 * delegate.cs: DelegateInvocation uses MethodInfo.
4491 * parameter.cs: Removed IsTypeParameter.
4493 * generic-mcs.cs: More missing stuff.
4495 2008-06-16 Martin Baulig <martin@ximian.com>
4498 (Modifiers.DEBUGGER_HIDDEN): New public const.
4501 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4504 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4505 (AbstractPropertyEventMethod): Likewise.
4506 (Constructor.Emit): Likewise.
4507 (SourceMethod.SetCompilerGenerated): Removed.
4509 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4513 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4514 if we're an `IteratorHost'.
4515 (AnonymousMethodMethod..ctor): Don't set
4516 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4519 2008-06-16 Marek Safar <marek.safar@gmail.com>
4521 * statement.cs: Clean-up foreach statements.
4523 2008-06-12 Marek Safar <marek.safar@gmail.com>
4525 * class.cs: Stop using public method which should not exist
4526 (MethodBuilder.SetGenericMethodSignature).
4528 2008-06-11 Martin Baulig <martin@ximian.com>
4531 (Location.LookupFile): Add `CompilationUnit' argument; when given
4532 a relative file name, make it relative to the directory the .cs
4533 file is located in instead of using the current directory.
4535 2008-06-11 Martin Baulig <martin@ximian.com>
4538 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4539 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4540 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4541 (SourceMethod.SetCompilerGenerated): Likewise.
4543 2008-06-11 Marek Safar <marek.safar@gmail.com>
4545 * codegen.cs, driver: Only write symbol file when it's asked for.
4547 2008-06-11 Marek Safar <marek.safar@gmail.com>
4549 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4551 2008-06-10 Martin Baulig <martin@ximian.com>
4553 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4555 2008-06-09 Marek Safar <marek.safar@gmail.com>
4557 A fix for bug #316290
4558 * expression.cs: Include decimal operators in predefined table.
4560 * parameters.cs: More readonlyness.
4562 2008-06-09 Marek Safar <marek.safar@gmail.com>
4564 A fix for bug #397213
4565 * cs-parser.jay: One more missing current_local_parameters reset.
4567 2008-06-09 Marek Safar <marek.safar@gmail.com>
4569 A fix for bug #396633
4570 * class.cs: Host backing field in partial container.
4572 2008-06-09 Marek Safar <marek.safar@gmail.com>
4574 A fix for bug #397068
4575 * expression.cs: Check both operand types when predefined operator is used.
4577 2008-06-05 Martin Baulig <martin@ximian.com>
4579 Merged the `debugger-kahalo' branch.
4582 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4583 we're an iterator method.
4584 (SourceMethod): Reflect latest symbol writer changes;
4585 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4586 now `start_row' and `end_row'.
4587 (Constructor.Emit): Fix the logic whether to emit symbol information.
4589 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4593 (CompilationUnit): New public class; derives from `SourceFile'.
4594 (SourceFileEntry.DefineSymbolInfo): New public method.
4595 (SourceFileEntry.SetChecksum): New public method.
4596 (Location): Encode hidden line numbers by using `column == 255';
4597 the .ctor now accepts `column == -1' to mark a hidden line number.
4598 (Location.Hidden): New public property.
4599 (Location.CheckPoint): Add `CompilationUnit'.
4600 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4601 (Location.Push): Add `CompilationUnit compile_unit' argument.
4602 (Location.CompilationUnit): New public property.
4605 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4607 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4609 * driver.cs: `SourceFile' -> `CompilationUnit'.
4611 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4613 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4615 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4619 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4620 new symbol writer API to also pass the file.
4622 2008-06-05 Marek Safar <marek.safar@gmail.com>
4624 * statement.cs: Emit catch variable assignment using variable expression.
4626 2008-06-05 Marek Safar <marek.safar@gmail.com>
4628 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4629 with other variable types.
4631 2008-06-04 Marek Safar <marek.safar@gmail.com>
4633 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4634 GetLength method emit, it breaks resolve rules.
4636 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4637 Marek Safar <marek.safar@gmail.com>
4639 A fix for bug #395542
4640 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4643 2008-06-02 Marek Safar <marek.safar@gmail.com>
4645 A fix for bug #395287
4646 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4648 2008-05-31 Marek Safar <marek.safar@gmail.com>
4650 A fix for bug #395845
4651 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4652 non-nullable parameter type.
4654 2008-05-31 Marek Safar <marek.safar@gmail.com>
4656 * class.cs: Handle contructor initializer as a statement in top-level block.
4658 2008-05-30 Marek Safar <marek.safar@gmail.com>
4660 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4661 security attributes.
4663 2008-05-24 Marek Safar <marek.safar@gmail.com>
4665 * ecore.cs, expression.cs: Small IVariable refactoring.
4667 2008-05-22 Marek Safar <marek.safar@gmail.com>
4669 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4671 2008-05-21 Marek Safar <marek.safar@gmail.com>
4673 * cs-parser.jay: Removed redundant catch type check.
4675 2008-05-21 Marek Safar <marek.safar@gmail.com>
4677 A fix for bug #390372
4678 * nullable.cs: Set correct return type.
4680 2008-05-21 Marek Safar <marek.safar@gmail.com>
4682 A fix for bug #391062
4683 * typemanager.cs: Fixed crash when comparing null types.
4685 2008-05-21 Marek Safar <marek.safar@gmail.com>
4687 A fix for bug #391871
4688 * cs-parser.jay: Better error handling for invalid catch type.
4690 2008-05-20 Marek Safar <marek.safar@gmail.com>
4692 A fix for bug #392155
4693 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4695 2008-05-15 Marek Safar <marek.safar@gmail.com>
4697 A fix for bug #390666
4698 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4701 2008-05-15 Marek Safar <marek.safar@gmail.com>
4703 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4706 2008-05-13 Marek Safar <marek.safar@gmail.com>
4708 A fix for bug #389625
4709 * delegate.cs, generic.cs: Some progress on method group return type
4712 2008-05-13 Marek Safar <marek.safar@gmail.com>
4714 A fix for bug #378419
4715 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4717 2008-05-12 Marek Safar <marek.safar@gmail.com>
4719 * class.cs (Constructor): Added IsCompilerGenerated.
4721 2008-05-12 Marek Safar <marek.safar@gmail.com>
4723 * expression.cs: Enum binary operators can accept non-enum operand only when
4724 is implicitly convertible to underlying type.
4726 2008-05-12 Marek Safar <marek.safar@gmail.com>
4728 A fix for bug #389272
4729 * support.cs: Workaround System.InvalidOperationException for enums.
4731 2008-05-12 Marek Safar <marek.safar@gmail.com>
4733 A fix for bug #389073
4734 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4736 2008-05-10 Marek Safar <marek.safar@gmail.com>
4738 * driver.cs: Split Parse.
4740 * location.cs (LookupFile): Uses string.Empty.
4742 2008-05-07 Marek Safar <marek.safar@gmail.com>
4744 * expression.cs, parameter.cs: Small ParameterReference clean up.
4746 2008-05-07 Marek Safar <marek.safar@gmail.com>
4748 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4749 hack. Fixes #387502.
4751 2008-05-06 Martin Baulig <martin@ximian.com>
4753 * class.cs (Constructor.Emit): Fix the logic whether to emit
4756 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4759 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4760 InvalidOperationException when the iterator is before the start or
4763 2008-05-06 Marek Safar <marek.safar@gmail.com>
4765 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4766 when left is nullable type.
4768 2008-05-06 Marek Safar <marek.safar@gmail.com>
4770 A fix for bug #386628
4771 * expression.cs (LocalVariableReference): Continue in resolving when
4772 variable is not assigned.
4774 2008-05-05 Marek Safar <marek.safar@gmail.com>
4776 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4777 nullable operations.
4779 2008-05-04 Marek Safar <marek.safar@gmail.com>
4781 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4782 it saves many redundant temporary variables for nullable operations.
4784 2008-05-03 Marek Safar <marek.safar@gmail.com>
4786 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4788 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4791 * nullable.cs: Constant coalescing operator optimizations.
4793 2008-05-03 Marek Safar <marek.safar@gmail.com>
4795 * constant.cs: Use unsigned conversion for values which are unsigned only.
4797 2008-05-03 Marek Safar <marek.safar@gmail.com>
4799 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4800 coalescing operator as it should be.
4802 2008-05-02 Marek Safar <marek.safar@gmail.com>
4804 A fix for bug #371016
4805 * expression.cs: All predefined delegate operators require implicit method
4808 2008-05-02 Marek Safar <marek.safar@gmail.com>
4810 * constant.cs: Emit long constant as uint when fits the range.
4812 * convert.cs, expression.cs: Fixed few unsafe conversions.
4814 2008-05-02 Marek Safar <marek.safar@gmail.com>
4816 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4818 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4821 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4823 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4825 2008-05-01 Marek Safar <marek.safar@gmail.com>
4827 * constant.cs, literal.cs: IsLiteral property for error reporting.
4829 * ecore.cs, expression.cs: Implemented Property expression.
4831 2008-05-01 Marek Safar <marek.safar@gmail.com>
4833 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4835 * nullable.cs: Implemented nullable coalescing null operator.
4837 * ecore.cs, expression.cs: Expression trees work.
4839 2008-05-01 Marek Safar <marek.safar@gmail.com>
4841 * ecore.cs: CreateExpressionTree is finally abstract.
4843 * expression.cs, linq.cs: Updated.
4845 2008-05-01 Marek Safar <marek.safar@gmail.com>
4847 * expression.cs, ecore.cs: Block base access expression inside expression
4850 2008-05-01 Marek Safar <marek.safar@gmail.com>
4852 A fix for bug #385058
4853 * expression.cs: User-defined operator implementations always take
4854 precedence over predefined operator implementations.
4856 2008-04-30 Marek Safar <marek.safar@gmail.com>
4858 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4859 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4860 expression tree conversions.
4862 2008-04-30 Marek Safar <marek.safar@gmail.com>
4864 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4865 operators method details to Operator class.
4867 2008-04-30 Marek Safar <marek.safar@gmail.com>
4869 * anonymous.cs: Pass unsafe flags to anonymous container.
4871 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4872 inside expression tree.
4874 2008-04-29 Martin Baulig <martin@ximian.com>
4876 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4877 (Tokenizer.PopPosition): Also restore the `line'.
4879 2008-04-29 Marek Safar <marek.safar@gmail.com>
4881 * delegate.cs: Implemented Invoke expression.
4883 2008-04-29 Marek Safar <marek.safar@gmail.com>
4885 * expression.cs: Fixed equality reference comparison regression.
4887 2008-04-29 Marek Safar <marek.safar@gmail.com>
4889 * ecore.cs: Clean up EmptyCast hack.
4891 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4892 using correct conversion rules. Also fixes #383993.
4894 2008-04-28 Martin Baulig <martin@ximian.com>
4896 * class.cs (Constructor.Emit): Don't emit debugging information
4897 for generated default .ctor's.
4899 2008-04-28 Marek Safar <marek.safar@gmail.com>
4901 * convert.cs: Empty-cast ushort to int conversion.
4903 2008-04-28 Marek Safar <marek.safar@gmail.com>
4905 A fix for bug #384191
4906 * ecore.cs, expression.cs: Fixed expression cloning.
4908 2008-04-28 Marek Safar <marek.safar@gmail.com>
4910 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4912 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4914 Fix #381559, test-638.cs, test-639.cs
4915 * assign.cs (CompoundAssign.Helper): New wrapper.
4916 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4918 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4919 Pass unconverted expressions to the params array creation expression.
4920 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4921 (PropertyExpr.EmitAssign): Likewise.
4922 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4923 element if it is of kind CompoundAssign.Helper.
4924 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4925 first before anything else.
4926 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4927 (ArrayAccess.LoadArrayAndArguments): Simplify.
4929 2008-04-27 Marek Safar <marek.safar@gmail.com>
4931 * expression.cs: Fixed cloning of typeof(void).
4933 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4935 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4936 (Assign.Emit): Likewise. Move it to ...
4937 (CompoundAssign.DoResolve): ... here and ...
4938 (CompoundAssign.Emit): ... here.
4939 (EventAddOrRemove): New helper to handle += and -= on events, and
4940 avoid the use of BinaryDelegates.
4941 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4942 (EventExpr.EmitAddOrRemove): Improve.
4943 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4945 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4946 create VarExprs for 'foo.bar.var'.
4947 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4948 is a highly inappropriate name for its functionality.
4950 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4952 Simplify handling of multiple assignments
4953 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4955 (SimpleAssign): New. Class to be used for normal assignments.
4956 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4957 * expression.cs, parameter.cs, statement.cs: Likewise.
4959 2008-04-25 Marek Safar <marek.safar@gmail.com>
4961 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4962 for incompatible underlying types, more to come, uff.
4964 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4967 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4968 Handle 'leave_copy'.
4970 2008-04-25 Marek Safar <marek.safar@gmail.com>
4972 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4974 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4976 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4977 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4978 * statement.cs (While, Do, For): Allow test to have side effects.
4979 (For.DoEmit): Always emit InitStatement.
4982 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4983 Always create SideEffectConstant.
4984 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4985 of type EnumConstant.
4987 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4988 Handle 'right' being SideEffectConstant of type 'bool'.
4990 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4991 Use left.EmitBranchable instead of open coding it, so as to
4992 improve optimization opportunities.
4994 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4996 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4998 (Expression.EmitSideEffect): Document.
5000 2008-04-23 Marek Safar <marek.safar@gmail.com>
5002 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
5004 2008-04-23 Marek Safar <marek.safar@gmail.com>
5006 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
5008 2008-04-23 Marek Safar <marek.safar@gmail.com>
5010 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
5011 conversion to expression tree.
5013 2008-04-23 Marek Safar <marek.safar@gmail.com>
5015 * ecore.cs: Removed unused expression.
5017 2008-04-22 Marek Safar <marek.safar@gmail.com>
5019 * expression.cs: Implemented NegateChecked and New expressions.
5021 2008-04-22 Marek Safar <marek.safar@gmail.com>
5023 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
5025 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
5028 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
5029 needing final 'ret' instruction.
5031 2008-04-22 Marek Safar <marek.safar@gmail.com>
5033 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
5035 2008-04-21 Marek Safar <marek.safar@gmail.com>
5037 * expression.cs: Emit ldnull and not null expression as an instance argument
5038 of static method expression calls.
5040 2008-04-21 Marek Safar <marek.safar@gmail.com>
5042 A fix for bug #378200
5043 * expression.cs: Fixed crash when creating parameterless expression tree
5046 2008-04-21 Marek Safar <marek.safar@gmail.com>
5048 A fix for bug #375297
5049 * anonymous.cs: Fixed crash when inferring from null argument anonymous
5052 2008-04-21 Marek Safar <marek.safar@gmail.com>
5054 A fix for bug #377596
5055 * decl.cs, class.cs: Emit delegate type argument attributes.
5057 2008-04-21 Marek Safar <marek.safar@gmail.com>
5059 A fix for bug #365314
5060 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
5062 2008-04-21 Marek Safar <marek.safar@gmail.com>
5064 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
5067 2008-04-21 Marek Safar <marek.safar@gmail.com>
5069 * generic.cs (TypeParameter): Removed redundant location.
5071 2008-04-19 Marek Safar <marek.safar@gmail.com>
5073 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
5074 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
5075 FullNamedExpression in all declaration type expression, statements will come
5078 2008-04-18 Marek Safar <marek.safar@gmail.com>
5080 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
5081 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
5083 2008-04-18 Marek Safar <marek.safar@gmail.com>
5085 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
5088 2008-04-17 Marek Safar <marek.safar@gmail.com>
5090 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
5093 2008-04-17 Marek Safar <marek.safar@gmail.com>
5095 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
5099 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
5101 Hook up 'EmitSideEffect'
5102 * constant.cs (Constant.EmitSideEffect): New.
5103 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
5104 (SideEffectConstant.EmitSideEffect): New.
5105 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
5106 unconditional branch in EmitBranchable.
5107 (FieldExpr.EmitBranchable): New.
5108 * expression.cs (Unary.EmitSideEffect): New.
5109 (Binary.EmitSideEffect): New.
5110 (VariableReference.EmitSideEffect): New. Do nothing.
5112 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5114 Introduce 'EmitSideEffect'
5115 * ecore.cs (Expression.EmitSideEffect): New.
5116 (TypeCast): Rename from EmptyCast.
5118 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
5119 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
5120 * convert.cs, nullable.cs: Update to changes.
5122 2008-04-16 Marek Safar <marek.safar@gmail.com>
5124 * class.cs, cs-parser.jay: Early check for base types expression.
5126 2008-04-16 Marek Safar <marek.safar@gmail.com>
5128 * decl.cs (MemberName): Declare PrettyName as obsolete.
5130 2008-04-16 Marek Safar <marek.safar@gmail.com>
5132 * namespace.cs: Use MemberName comparison.
5134 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5137 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
5139 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
5140 (MemberName.FullyQualifiedName): New. Provides the functionality
5141 that users assume FullName would have.
5142 * ecore.cs, namespace.cs: Update to changes.
5144 * statement.cs (Using.assign): Make into ExpressionStatement.
5145 (Using.EmitPreTryBody): Simplify.
5147 2008-04-16 Marek Safar <marek.safar@gmail.com>
5149 * report.cs: ColorFormat is protected.
5151 * rootcontext.cs: Unused fields clean-up.
5153 * namespace.cs: Made UsingEntry name private.
5155 2008-04-16 Marek Safar <marek.safar@gmail.com>
5157 * cs-tokenizer.cs, location.cs: Removed unused field.
5159 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
5160 Raja R Harinath <harinath@hurrynot.org>
5163 * constant.cs (SideEffectConstant.value): Rename from 'left'.
5164 (SideEffectConstant.side_effect): Rename from 'right'.
5165 (SideEffectConstant..ctor): Normalize 'side_effect'.
5166 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
5167 value of this constant.
5168 * cfold.cs: Update to changes.
5170 2008-04-15 Marek Safar <marek.safar@gmail.com>
5172 * cs-paser.jay: Removed unused variable.
5174 * driver.cs: Made Compile instance method.
5176 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
5178 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
5180 2008-04-15 Marek Safar <marek.safar@gmail.com>
5182 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
5184 2008-04-13 Jb Evain <jbevain@novell.com>
5186 * namespace.cs: update the System.Core fullname for 2.1
5187 * driver.cs: update the list of required assemblies for 2.1.
5188 Merged from the Moonlight 2 branch.
5190 2008-04-11 Marek Safar <marek.safar@gmail.com>
5192 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
5193 types and user defined operators. User operators arguments has to be checked
5194 for null value before invocation, which also means no operator is called
5195 when any argument is not convertible to unwrapped nullable type.
5197 2008-04-09 Marek Safar <marek.safar@gmail.com>
5199 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
5200 of Unary expressions to follow operator overloading rules precisely.
5201 Also fixes #321794, #323794
5203 2008-04-08 Marek Safar <marek.safar@gmail.com>
5205 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
5208 2008-04-08 Marek Safar <marek.safar@gmail.com>
5210 * expression.cs, ecore.cs: Implemented MemberInit expression.
5212 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
5214 Fix mono/tests/exception4.cs
5215 * statement.cs (ExceptionStatement, TryCatch): Revert to using
5216 ec.NeedReturnLabel () rather emitting a 'nop'.
5218 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
5220 (TryCatch.SomeCodeFollows): Likewise.
5221 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
5222 for 'break', 'continue' and 'return' statements inside a try.
5223 We're fairly sure that the generated IL stream will have more
5224 instructions textually following the try.
5225 (FlowBranchingTryCatch): Likewise.
5227 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
5228 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
5231 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
5232 wrapper -- forward everything to CollectionForeach.
5233 (CollectionForeach.NonDisposableWrapper): New.
5234 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
5235 instead of a pop + branch to end.
5237 2008-04-07 Marek Safar <marek.safar@gmail.com>
5239 A fix for bug #377485
5240 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
5241 Propagate location for extension method groups. Report conversion failure at
5244 2008-04-07 Marek Safar <marek.safar@gmail.com>
5246 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
5247 ListInit and Field expressions.
5249 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
5251 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
5252 Since $PC is always -1 inside the body of MoveNext, the fault
5254 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
5255 * statement.cs (ExceptionStatement.emit_finally): Likewise.
5256 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
5258 The denouement! Fix #324708
5259 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
5260 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
5261 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
5262 'finally' inside the finally clause.
5264 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
5265 inside an iterator. Don't emit the body of the 'finally' inside
5266 the finally clause yet.
5268 Use the ResumableStatement infrastructure for MoveNext ()
5269 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
5270 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
5271 'old_resume_points'. Move dispatcher upfront.
5272 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
5273 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
5274 in an enumerator. This encodes the main fix in this patch series
5275 -- we can only jump into the first instruction of a try from the
5276 outside, but we want to emit try/finally regions in iterators and
5277 resume in the middle of them.
5279 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
5281 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
5282 of NeedReturnLabel here.
5284 Introduce a common point for emitting try/finally to IL
5285 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
5286 features of the various subclasses, which are now driven by ...
5287 (ExceptionStatement.EmitPreTryBody): ... this and ...
5288 (ExceptionStatement.EmitTryBody): ... this and the original
5290 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
5291 Remove DoEmit and update to follow above protocol.
5293 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5294 of the dispatcher are the same, skip emitting the 'switch'.
5295 * iterator.cs (Iterator.EmitDispose): Update to changes.
5297 Clean up handling of 'using' statement
5298 * statement.cs (UsingTemporary): New. Carved out of ...
5299 (Using): ... this. Simplify drastically. Handle exactly
5301 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5302 or Using as appropriate. If there are multiple variable declared,
5303 create nested Using statements.
5304 (resource_acquisition): Kill.
5306 * statement.cs (ExceptionStatement.EmitForDispose): Use
5307 EmitFinallyBody, not EmitFinally.
5309 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5310 * iterator.cs: Update to changes.
5312 Start using the ResumableStatement infrastructure
5313 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5314 (ResumableStatement.EmitForDispose): New.
5315 (ExceptionStatement): Override them.
5316 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5317 EmitForDispose to create the body of the Dispose method. Don't
5320 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5321 * statement.cs (Toplevel.AddResumePoint): ... here.
5322 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5323 * flowanalysis.cs (FlowBranchingIterator): New.
5324 * codegen.cs (EmitContext): Update to changes.
5326 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5327 (Iterator.old_resume_points): Rename from 'resume_points'.
5328 (Iterator.MoveNextStatement): Remove unused class.
5330 New infrastructure for try/finally in iterators (still unused)
5331 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5332 (FlowBranchingToplevel.AddResumePoint): Hook into
5333 ToplevelBlock.AddResumePoint.
5334 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5335 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5336 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5337 resume points and assign program-counter values.
5338 (ExceptionBlock.AddResumePoint): Collect resume points for
5339 de-muxer at the top of try block.
5340 * iterators.cs (Yield.CheckContext): Simplify.
5341 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5343 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5345 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5346 argument to an ExitStatement.
5347 (FlowBranchingException): Refactor saved origins code.
5348 * statement.cs (ExitStatement): Update to cahges.
5349 * iterator.cs (YieldBreak): Likewise.
5351 * statement.cs (ResumableStatement): New. Common base class for
5352 YieldReturn and ExceptionStatement.
5353 (ExitStatement): New. Common base class for Return and YieldBreak.
5354 (Return): Update to changes.
5355 * iterator.cs (YieldBreak): Likewise.
5356 * lambda.cs (ContextualReturn): Likewise.
5359 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5360 emit a meaningful error message.
5362 Fix #324765, #319508
5363 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5364 (VariableInfo.SetAssigned): Set it.
5365 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5366 determine if CS0219 or CS0168 is appropriate. Don't use
5367 flow-analysis information.
5368 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5369 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5370 (EmitContext.EndFlowBranching): ... this.
5372 2008-04-03 Marek Safar <marek.safar@gmail.com>
5374 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5376 2008-04-03 Marek Safar <marek.safar@gmail.com>
5378 A fix for bug #376508
5379 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5380 ImplicitConversionExists.
5382 2008-04-03 Marek Safar <marek.safar@gmail.com>
5384 * expression.cs (Binary): Added remaining binary operators to expression
5387 * nullable.cs: Optimize shift with null argument.
5389 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5391 Fix minor IL regression
5392 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5393 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5394 * cs-parser.jay (try_statement): Update to changes.
5396 * statement.cs (TryFinally.need_exc_block): Delete.
5397 (TryFinally): Update to changes.
5399 Now all ExceptionStatements are unconditional
5400 * statement.cs (CollectionForeach.DisposableWrapper): New.
5401 Extract out the try/finally code into a new wrapper.
5402 (CollectionForeach.Resolve): Use it to simplify the code.
5404 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5406 Start at simplifying ExceptionStatement semantics a bit
5407 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5408 * cs-parser.jay (try_statement): Update to changes.
5409 (opt_catch_clauses): Remove.
5410 * flowanalysis.cs: Update to changes.
5411 (FlowBranching.BranchingType.TryCatch): New.
5412 (FlowBranchingTryCatch): New.
5414 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5415 (FlowBranching.CreateBranching): Update to changes.
5416 (FlowBranchingBlock.AddSibling): Add sanity check.
5417 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5420 * iterators.cs (Iterator.MarkFinally): Remove.
5421 * statement.cs (ExceptionStatement): Update to changes.
5423 Add support for skipping over finally blocks at runtime. First
5424 in a series to fix #324708
5425 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5426 (Iterator.EmitMoveNext): Initialize it.
5427 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5428 branch over the body of the 'finally' clause.
5430 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5432 Avoid lopsided use of Foo/DoFoo names
5433 * statement.cs (ExpressionStatement.EmitFinallyBody):
5434 Rename from EmitFinally.
5435 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5436 * iterator.cs: Update to changes.
5438 2008-04-02 Marek Safar <marek.safar@gmail.com>
5440 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5441 based on UserOperatorCall. More binary nullable operators clean up.
5443 2008-04-02 Martin Baulig <martin@ximian.com>
5445 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5447 2008-04-02 Marek Safar <marek.safar@gmail.com>
5449 * nullable.cs: Merge user and empty conversions when lifting expression
5452 * expression.cs (StringConcat): Implemented expression tree representation.
5454 2008-04-01 Marek Safar <marek.safar@gmail.com>
5456 * nullable.cs: When lifting null literal and a user operator exists, no call
5459 2008-04-01 Marek Safar <marek.safar@gmail.com>
5461 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5464 2008-04-01 Marek Safar <marek.safar@gmail.com>
5466 * nullable.cs, expression.cs: Use namespace instead heavily nested
5467 monster abstract class.
5469 2008-04-01 Marek Safar <marek.safar@gmail.com>
5471 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5472 lifting of null literal and user operators. Clean up of some temporary
5475 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5477 Fix #368224, test-629.cs
5478 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5479 if it crossed an unwind-protect boundary.
5480 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5481 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5482 inside an unwind-protected region.
5483 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5484 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5485 'leave' instead of a 'br' if unwind-protected.
5486 (Iterator.EmitYieldBreak): Likewise.
5488 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5490 * driver.cs: Only define versioninfo resources if no win32 resource
5493 2008-03-28 Marek Safar <marek.safar@gmail.com>
5495 A fix for bug #372375
5496 * convert.cs: Fixed boxing of nullable types.
5498 2008-03-28 Marek Safar <marek.safar@gmail.com>
5500 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5503 2008-03-28 Marek Safar <marek.safar@gmail.com>
5505 A fix for bug #374619
5506 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5508 2008-03-27 Marek Safar <marek.safar@gmail.com>
5510 * lambda.cs: Check return type only for invocation.
5512 2008-03-27 Marek Safar <marek.safar@gmail.com>
5514 A fix for bug #374214
5515 * ecore.cs: Correctly report argument type mismatch.
5517 2008-03-27 Marek Safar <marek.safar@gmail.com>
5519 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5520 and not rely on broken IsEnum.
5522 2008-03-27 Marek Safar <marek.safar@gmail.com>
5524 * nullable.cs: New file, extracted from generic.cs.
5526 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5528 2008-03-27 Marek Safar <marek.safar@gmail.com>
5530 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5531 predefined comparison operators and null literals.
5533 * report.cs: New warning ID.
5535 2008-03-25 Marek Safar <marek.safar@gmail.com>
5537 A fix for bug #370577
5538 * lambda.cs: Check return type too.
5540 2008-03-25 Marek Safar <marek.safar@gmail.com>
5542 A fix for bug #372846
5543 * class.cs: Automatic properties can be declared as unsafe.
5545 2008-03-20 Marek Safar <marek.safar@gmail.com>
5547 * location.cs: Use string based concatenation.
5549 * expression.cs: LiftedBinaryOperator is gmcs only.
5551 2008-03-20 Marek Safar <marek.safar@gmail.com>
5553 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5554 conversions rules and expression trees.
5556 2008-03-19 Marek Safar <marek.safar@gmail.com>
5558 * delegate.cs: Use extension method source as delegate target.
5560 2008-03-19 Marek Safar <marek.safar@gmail.com>
5562 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5563 binary operations to be purely based on binary operations and optimized
5564 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5565 and other ET refactoring.
5567 * typemanager.cs: Fixed warning.
5569 2008-03-17 Marek Safar <marek.safar@gmail.com>
5571 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5573 * symbolwriter.cs: Fixed.
5575 2008-03-17 Marek Safar <marek.safar@gmail.com>
5577 * anonymous.cs, driver.cs: Reset anonymous types counters.
5579 2008-03-17 Marek Safar <marek.safar@gmail.com>
5581 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5583 * class.cs: Use fullname for all type member definitions.
5585 2008-02-19 Martin Baulig <martin@ximian.com>
5588 (IMethodData.EmitExtraSymbolInfo): New interface method.
5589 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5590 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5591 interface method here as an empty public virtual method.
5594 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5595 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5596 CodeGen.SymbolWriter.SetRealMethodName().
5598 2008-02-18 Martin Baulig <martin@ximian.com>
5601 (ScopeInfo.EmitType): Override this and emit debugging
5602 information for captured variables.
5603 (RootScopeInfo.EmitType): Override this and emit symbol
5604 information for a captured `this'.
5606 2008-02-15 Martin Baulig <martin@ximian.com>
5608 * iterators.cs: Emit debugging info.
5611 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5612 (EmitContext.OmitDebuggingInfo): New public property.
5615 (While): Override Emit() and don't emit symbol info there; do it
5616 inside DoEmit() instead.
5617 (Block.Emit): Omit symbol information while emitting the scope
5618 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5620 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5621 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5622 .ctor to make `IsIterator' work.
5624 2008-03-14 Martin Baulig <martin@ximian.com>
5626 * symbolwriter.cs: Added the new symbol writer function from the
5627 debugger's `terrania' branch; temporarily enclose them inside
5628 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5631 2008-03-14 Martin Baulig <martin@ximian.com>
5634 (SymbolWriter): Make this a public static class.
5637 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5638 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5640 2008-03-14 Marek Safar <marek.safar@gmail.com>
5642 A fix for bug #370577
5643 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5646 2008-03-14 Marek Safar <marek.safar@gmail.com>
5648 * typemanager.cs (CSharpName): Made 250 times faster.
5650 2008-03-13 Marek Safar <marek.safar@gmail.com>
5652 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5654 2008-03-12 Marek Safar <marek.safar@gmail.com>
5656 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5657 crash when predefined field does not exist.
5659 2008-03-12 Marek Safar <marek.safar@gmail.com>
5661 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5663 2008-03-12 Marek Safar <marek.safar@gmail.com>
5665 * class.cs (FixedField): Don't crash when contructors are missing.
5667 2008-03-11 Marek Safar <marek.safar@gmail.com>
5669 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5670 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5671 check internal types accessibility for internal and external types.
5672 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5674 2008-03-11 Marek Safar <marek.safar@gmail.com>
5676 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5677 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5678 attribute.cs, statement: Use corect instance of predefined types (work
5679 related to #364674).
5681 2008-03-07 Marek Safar <marek.safar@gmail.com>
5683 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5685 2008-03-07 Marek Safar <marek.safar@gmail.com>
5687 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5688 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5689 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5690 predefined types clean up, delayed predefined types members initialization
5691 (work related to #364674).
5693 2008-03-05 Marek Safar <marek.safar@gmail.com>
5695 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5697 2008-03-05 Marek Safar <marek.safar@gmail.com>
5699 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5700 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5701 predefined types clean up (work related to #364674).
5703 2008-03-04 Marek Safar <marek.safar@gmail.com>
5705 * ecore.cs: Print an error message instead of throwing exception.
5707 2008-03-04 Marek Safar <marek.safar@gmail.com>
5709 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5710 expression.cs, statement.cs: Unififed null literal representation.
5712 2008-03-03 Marek Safar <marek.safar@gmail.com>
5714 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5715 expression.cs: Refactored binary operators resolve phase and improved speed.
5716 The nullable code is still missing and won't work correctly, more fixes
5719 It also fixes #323726, #324312, #324248, and many other unreported issues.
5721 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5723 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5726 2008-02-27 Marek Safar <marek.safar@gmail.com>
5728 * ecore.cs: Clean-up and split BetterConversion.
5730 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5733 * enum.cs (EnumMember.Value): Only access 'value' if
5734 ResolveValue says it's ok.
5735 (EnumMember.DoResolveValue): Don't set prev_member.value.
5736 (Enum.GetDefinition): Reverse arguments of Equals --
5737 EnumMember.Value can return 'null'.
5739 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5741 2008-02-22 Marek Safar <marek.safar@gmail.com>
5743 * generic.cs, expression.cs: More ongoing work on expression trees.
5745 2008-02-21 Marek Safar <marek.safar@gmail.com>
5747 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5748 handle missing matches when mutiple operators exist.
5750 2008-02-20 Marek Safar <marek.safar@gmail.com>
5752 A fix for bug #363218
5753 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5756 2008-02-20 Marek Safar <marek.safar@gmail.com>
5758 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5759 update. This time to deal correctly with SideEffectConstant expression used
5760 as an argument for another constant folding.
5762 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5764 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5767 2008-02-19 Marek Safar <marek.safar@gmail.com>
5769 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5771 2008-02-19 Marek Safar <marek.safar@gmail.com>
5773 A fix for bug #328136
5774 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5775 side is a false constant, because we still need to evaluate the right-hand
5778 * statement.cs (If): Emit two types of boolean constants (simple constant,
5779 side-effect constant).
5781 2008-02-19 Marek Safar <marek.safar@gmail.com>
5783 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5785 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5788 2008-02-18 Marek Safar <marek.safar@gmail.com>
5790 A fix for bug #361457
5791 * ecore.cs (IsApplicable): Params methods have lower priority.
5793 * support.cs: Return correct parameter modifier for params types.
5795 2008-02-18 Marek Safar <marek.safar@gmail.com>
5797 * generic.cs (TypeParameter): Cache attribute target name.
5799 * support.cs: Removed unused variable.
5801 * typemanager.cs: Removed debugging leftover.
5803 * ecore.cs: Use local type instead of a property;
5805 * class.cs (VerifyMembers): Consider also parent to test whether type member
5808 * expression.cs (FullMethodDesc): Removed.
5810 * attribute.cs (IsValidArgumentType): Made static.
5812 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5814 Cleanup to be more readable.
5815 * Makefile (GMCS_PROFILE): Remove.
5816 (COMPILER_NAME): New helper.
5818 2008-02-15 Miguel de Icaza <miguel@novell.com>
5820 * cs-tokenizer.cs: if a conditional expression happens inside a
5821 (...) this also means that we do not need to de-ambiguate between
5822 an parenthesized expression and a cast.
5826 * constant.cs (SideEffectConstant): a constant value that happens
5827 to have a side effect.
5829 Fixes the build regressions introduced by the fix for #359789
5831 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5833 * expression.cs (Conditional.Emit): when emitting the ternary
5834 operator, use local variables to generate code verifiable code.
5836 The verifier cannot infer that the type on stack before the
5837 stloc.0 is executed is of type ParentB. This happens because the
5838 stack merge algorithm uses only parent types when deciding which
5839 is the common type. This is described in Part III 1.8.1.3 of ECMA
5842 This code compiled with mcs is not verifiable under MS. The MS
5843 verifier picks the first common interface of Foo and Bar, which is
5844 wrong, but doesn't use a full join type of the 2 interfaces.
5846 CSC uses a clever hack to compile such code in a verifiable
5847 way. It stores the intermediate values in a local variable with
5852 2008-02-14 Miguel de Icaza <miguel@novell.com>
5854 * expression.cs: Do not fold BitwiseAnd operators when the left
5855 side is a false constant, because we still need to evaluate the
5860 * support.cs: Instead of throwing an InternalErrorException when
5861 the position of the stream is outside the boundary of our buffer,
5862 reset the state of the reader, and restart the reading from the
5863 beginning of the file.
5865 2008-02-14 Marek Safar <marek.safar@gmail.com>
5867 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5869 2008-02-14 Marek Safar <marek.safar@gmail.com>
5871 A fix for bug #361686
5872 * decl.cs: A protected types used inside a private class which parents
5873 derives from the protected class are accessible.
5875 2008-02-13 Marek Safar <marek.safar@gmail.com>
5877 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5878 the parameterless constructor.
5880 2008-02-13 Marek Safar <marek.safar@gmail.com>
5882 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5883 lookup methods to use standard member cache when doing member lookup.
5885 2008-02-12 Marek Safar <marek.safar@gmail.com>
5887 * driver.cs: Don't report full path for referenced module as assembly error.
5889 2008-02-12 Marek Safar <marek.safar@gmail.com>
5891 * Makefile: Fixed `qh' target to work on all machines.
5893 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5894 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5895 and HasElementType with TypeManager implementation.
5897 2008-02-08 Marek Safar <marek.safar@gmail.com>
5899 A fix for bugs #325134, #359749
5900 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5901 first binds point to non-method member expression.
5903 2008-02-08 Marek Safar <marek.safar@gmail.com>
5905 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5907 2008-02-08 Marek Safar <marek.safar@gmail.com>
5909 A fix for bugs #321394, #323028
5910 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5911 Reworked naive IsAccessibleAs implementation to handle nested types.
5913 2008-02-05 Jb Evain <jbevain@novell.com>
5915 * class.cs: use generic type comparison for parameters
5918 2008-02-05 Marek Safar <marek.safar@gmail.com>
5920 A fix for bug #325372
5921 * class.cs: Use generic type comparison when testing method signatures.
5923 2008-02-05 Marek Safar <marek.safar@gmail.com>
5925 A fix for bug #357047
5926 * ecore.cs: Applied C# 3.0 changes to better conversion.
5928 2008-02-05 Marek Safar <marek.safar@gmail.com>
5930 A fix for bug #358374
5931 * cs-parser.jay: Correctly set modifiers for all constructor types.
5933 2008-02-04 Marek Safar <marek.safar@gmail.com>
5935 A fix for bug #355251
5936 * generic.cs: Added base class constraint based type inference.
5938 2008-02-01 Marek Safar <marek.safar@gmail.com>
5940 A fix for bug #357255
5941 * decl.cs: One more missing visibility check.
5943 2008-02-01 Marek Safar <marek.safar@gmail.com>
5945 * support.cs: Fixed broken return.
5947 2008-01-25 Marek Safar <marek.safar@gmail.com>
5949 * report.cs: Correctly reset warnings count after probing.
5951 2008-01-25 Martin Baulig <martin@ximian.com>
5954 (NamespaceEntry.SymbolFileID): Make this work again after
5955 MemberName.ToString() is gone.
5957 2008-01-25 Marek Safar <marek.safar@gmail.com>
5959 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5962 2008-01-25 Marek Safar <marek.safar@gmail.com>
5964 * generic.cs: Use full implicit conversion for type inference fixing.
5966 2008-01-24 Marek Safar <marek.safar@gmail.com>
5968 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5969 Fixed user operator conversions.
5971 2008-01-24 Marek Safar <marek.safar@gmail.com>
5973 * generic.cs: Do nullable type to null comparison optimization during
5976 2008-01-24 Marek Safar <marek.safar@gmail.com>
5978 A fix for bug #355163
5979 * generic.cs: Enabled l-value resolve on nullable expressions.
5981 2008-01-24 Marek Safar <marek.safar@gmail.com>
5983 A fix for bug #353986
5984 * class.cs: Ingore static ctors with parameters for any further checks.
5986 2008-01-24 Marek Safar <marek.safar@gmail.com>
5988 A fix for bug #354310
5989 * namespace.cs: Removed redundant check.
5991 2008-01-24 Marek Safar <marek.safar@gmail.com>
5993 A fix for bug #354928
5994 * expression.cs: ElementInitializers can be resolved only once.
5996 2008-01-24 Marek Safar <marek.safar@gmail.com>
5998 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5999 Condition expressions.
6001 2008-01-23 Marek Safar <marek.safar@gmail.com>
6003 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
6005 2008-01-22 Marek Safar <marek.safar@gmail.com>
6007 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
6010 * generic.cs: Implemented coalesce expression.
6012 2008-01-22 Marek Safar <marek.safar@gmail.com>
6014 A fix for bug #355145
6015 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
6016 expression tree type inference.
6018 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
6021 * expression.cs (Binary.IsUnsignedType): Fix typo.
6023 2008-01-22 Marek Safar <marek.safar@gmail.com>
6025 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
6027 2008-01-22 Marek Safar <marek.safar@gmail.com>
6029 A fix for bug #355161
6030 * ecore.cs, expression.cs: Wider range of extension method supported
6033 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
6035 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
6036 AssemblyBuilder to operate in compiler context. Fixes mcs part of
6039 2008-01-22 Marek Safar <marek.safar@gmail.com>
6041 A fix for bug #355148
6042 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
6044 2008-01-22 Miguel de Icaza <miguel@novell.com>
6046 * expression.cs (CreateExpressionTree): Add support for or and
6047 logical or, and indent following the coding conventions.
6049 * typemanager.cs (LinqExpression): renamed from
6050 ExpressionTreeManager, for a shorter name.
6052 Use TypeManager.CoreLookupType to lookup types from our core
6053 assemblies and turn those into "Type" variables.
6055 Consumers that previously used "Namespace" and "Type" from this
6056 class should instead use the TypeExpression which is a type that
6057 is fully resolved (without involving the regular C# resolution
6060 This typically looks like this:
6062 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
6063 new MemberAccess (texpr, name, type_arguments, loc)
6065 This avoids the problem in: #355178
6067 2008-01-21 Marek Safar <marek.safar@gmail.com>
6069 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
6070 feature in parser only as we do in other cases.
6072 2008-01-21 Marek Safar <marek.safar@gmail.com>
6074 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
6075 typemanager.cs: A refactoring of params arguments to reuse existing
6076 expressions (params -> array initializer) to emit params argument instead
6077 of specialized handling.
6078 It was required by expression tree implementation and it has other benefits
6079 as well, we now apply same optimization for params arguments as we do for
6082 2008-01-18 Marek Safar <marek.safar@gmail.com>
6084 A fix for bug #353526
6085 * generic.cs: A type inference of params arguments may not required any
6086 temporary array creation.
6088 2008-01-18 Marek Safar <marek.safar@gmail.com>
6090 A fix for bug #353534
6091 * generic.cs, ecore.cs, expression.cs: A method group type inference is
6092 supported for delegates only.
6094 2008-01-18 Marek Safar <marek.safar@gmail.com>
6096 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
6097 type for more than 1 candidates.
6099 2008-01-18 Marek Safar <marek.safar@gmail.com>
6101 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
6104 2008-01-16 Marek Safar <marek.safar@gmail.com>
6106 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
6107 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
6108 operator) expressions.
6110 2008-01-16 Zoltan Varga <vargaz@gmail.com>
6112 * statement.cs: Avoid declaring an IL variable for this_variable since it is
6113 not accessed from the generated IL.
6115 2008-01-14 Marek Safar <marek.safar@gmail.com>
6117 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
6118 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
6119 statement.cs: The first expression tree implementation drop, mostly
6120 infrastructure work.
6122 2008-01-14 Marek Safar <marek.safar@gmail.com>
6124 * ecore.cs (IsNestedChild): Refactored.
6126 2008-01-11 Marek Safar <marek.safar@gmail.com>
6128 * lambda.cs: Don't use a cast on unknown expression statement.
6130 2008-01-10 Geoff Norton <gnorton@novell.com>
6132 * cs-tokenizer.cs: One more token to distinguish between method and lambda
6135 2008-01-09 Marek Safar <marek.safar@gmail.com>
6137 * doc.cs: Report better /doc crash details.
6139 2008-01-09 Marek Safar <marek.safar@gmail.com>
6141 A fix for bug #352536
6142 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
6144 2008-01-08 Marek Safar <marek.safar@gmail.com>
6146 A fix for bug #352287
6147 * ecore.cs, expression.cs: Do `this' access checking in all member access
6150 2008-01-08 Marek Safar <marek.safar@gmail.com>
6152 * rootcontext.cs, driver.cs: Switch to linq mode by default.
6154 * report.cs: Reset message stacks.
6156 2008-01-08 Marek Safar <marek.safar@gmail.com>
6158 * generic.cs (InferInPhases): Correctly calculate params position.
6160 2008-01-08 Marek Safar <marek.safar@gmail.com>
6162 * cs-tokenizer.cs: No need to parse full string when parsing lambda
6165 2008-01-07 Marek Safar <marek.safar@gmail.com>
6167 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
6169 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
6171 * driver.cs: Updated --help option.
6173 2008-01-07 Marek Safar <marek.safar@gmail.com>
6175 * generic.cs (InferParamsTypeArguments): Removed.
6176 (InferInPhases): Add params type inference.
6177 (LowerBoundInference): Fixed scoring mechanism.
6179 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
6181 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
6183 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
6184 byte array for unsigned "baked" assemblies.
6186 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
6188 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
6189 array for assemblies that are not strongnamed.
6191 2008-01-04 Marek Safar <marek.safar@gmail.com>
6193 A fix for bug #351481
6194 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
6195 declaring type for nested generic types.
6197 2008-01-04 Marek Safar <marek.safar@gmail.com>
6199 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
6200 instead of ToString.
6202 2008-01-03 Marek Safar <marek.safar@gmail.com>
6204 A fix for bug #351047
6205 * expression.cs (Binary.ResolveOperator): Allow equality operators between
6206 null and structs only when equality and inequality operators are defined
6207 either as an user-operators or predefined operators.
6209 2008-01-03 Marek Safar <marek.safar@gmail.com>
6211 A fix for bug #351047
6212 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
6214 2008-01-03 Marek Safar <marek.safar@gmail.com>
6216 A fix for bug #351257
6217 * cs-tokenizer.cs: Advance line number for '\r' correctly.
6219 2008-01-03 Marek Safar <marek.safar@gmail.com>
6221 A fix for bug #351157
6222 * class.cs (Using): Fixed yet another broken cloning.
6224 (Block): Put back more sensible default value for statements.
6226 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
6228 * codegen.cs: Allow AssemblyVersion with only major version component.
6231 2007-12-29 Marek Safar <marek.safar@gmail.com>
6233 A fix for bug #324654
6234 * class.cs: Use FullName property as member name.
6236 2007-12-28 Marek Safar <marek.safar@gmail.com>
6238 A fix for bug #342117
6239 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
6240 constructor constraint.
6242 2007-12-28 Marek Safar <marek.safar@gmail.com>
6244 A fix for bug #338273
6245 * class.cs (ProbertyBase): Access modifier checks are required for overrides
6248 2007-12-28 Marek Safar <marek.safar@gmail.com>
6250 A fix for bug #350839
6251 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
6253 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6255 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6258 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6260 * statement.cs: Changed some Hashtables to use HybridDictionaries
6261 instead. It was observed that some HashTables only contained a few
6262 items in the vast majority of cases. Since HybridDictionary is
6263 more efficient on small sets (<10 elements), "known_variables"
6264 from class ExplicitBlock as well as "labels" and "constants " from
6265 class Block were changed to HybridDictionaries.
6267 Atsai results: (56216kb->54987kb)
6269 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
6272 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6274 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6277 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6279 * expression.cs: foreach loop to for loop, saved on allocation of
6280 enumerator (59333kb->59141kb)
6282 * statement.cs. Changed foreach loops to for loops, saved on
6283 allocation of enumerator (59141kb->59006kb)
6285 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
6286 when constructed with no specified capacity. This was causing a
6287 few ArrayLists to allocate more memory than they would potentially
6288 need in the Block class and MemberCache class. Setting the
6289 ArrayLists to construct with a capacity of 1 saves some
6290 memory. (56216kb->55585kb)
6292 2007-12-27 Marek Safar <marek.safar@gmail.com>
6294 A fix for bug #347189 (2nd issue)
6295 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6298 2007-12-27 Miguel de Icaza <miguel@novell.com>
6300 * report.cs: Do not use colors if stdout and stderr are not a
6303 2007-12-27 Marek Safar <marek.safar@gmail.com>
6305 A fix for bug #346998
6306 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6309 2007-12-27 Marek Safar <marek.safar@gmail.com>
6311 A fix for bug #343465
6312 * class.cs: Explicit method name for nested types uses dots only.
6314 2007-12-27 Marek Safar <marek.safar@gmail.com>
6316 A fix for bug #343707
6317 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6319 2007-12-27 Marek Safar <marek.safar@gmail.com>
6321 * ecore.cs: Report type inference errors only when arguments count matches
6324 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6326 * expression.cs, report.cs: New warning.
6328 * typemanager.cs: Catch anonymous method type too.
6330 2007-12-23 Marek Safar <marek.safar@gmail.com>
6332 A fix for bug #346379
6333 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6335 2007-12-23 Marek Safar <marek.safar@gmail.com>
6337 A fix for bug #347359
6338 * expression.cs (Invocation): Don't resolve already resolved expression.
6340 2007-12-23 Marek Safar <marek.safar@gmail.com>
6342 A fix for bug #347189
6343 * class.cs (FixedField): Use non-dependent code only in the define phase.
6345 2007-12-23 Marek Safar <marek.safar@gmail.com>
6347 A fix for bug #348076
6348 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6350 2007-12-22 Marek Safar <marek.safar@gmail.com>
6352 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6353 discovered extension methods.
6355 2007-12-22 Marek Safar <marek.safar@gmail.com>
6357 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6360 2007-12-21 Miguel de Icaza <miguel@novell.com>
6362 * report.cs (ErrorMessage): Add support for using colors on
6363 terminals that support it.
6365 2007-12-21 Marek Safar <marek.safar@gmail.com>
6367 * ecore.cs: Use information about expanded params for error reporting.
6369 2007-12-21 Marek Safar <marek.safar@gmail.com>
6371 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6372 and logic for params overloads.
6374 2007-12-15 Miguel de Icaza <miguel@novell.com>
6376 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6377 as this is also created from the parser. Fixes #349034
6379 2007-12-12 Miguel de Icaza <miguel@novell.com>
6381 * statement.cs (Throw.CloneTo): it is valid to have empty
6382 expressions for throw.
6384 2007-12-03 Marek Safar <marek.safar@gmail.com>
6386 * cs-parser.jay: Set delegate constraint parsing region correctly.
6388 2007-12-03 Marek Safar <marek.safar@gmail.com>
6390 A fix for bug #345467
6391 * typemanager.cs (IsEqual): Compare generic parameters position only.
6393 2007-11-28 Marek Safar <marek.safar@gmail.com>
6395 * expression.cs (BaseAccess): Type arguments can be null.
6397 2007-11-27 Raja R Harinath <harinath@gmail.com>
6399 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6400 consistent even when an error has occured.
6401 (Switch.Resolve): Likewise.
6403 2007-11-22 Marek Safar <marek.safar@gmail.com>
6405 A fix for bug #334505
6406 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6409 2007-11-22 Marek Safar <marek.safar@gmail.com>
6411 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6412 refactorings required to resolve extension methods correctly when mixing
6413 generics and non-generics members.
6415 2007-11-20 Marek Safar <marek.safar@gmail.com>
6417 A fix for bug #342584
6418 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6421 2007-11-19 Marek Safar <marek.safar@gmail.com>
6423 A fix for bug #342512
6424 * delegate.cs: Use delegate argument expression when is available. Don't
6425 emit virtual call when class is sealed.
6427 2007-11-16 Marek Safar <marek.safar@gmail.com>
6429 A fix for bug #325423
6430 * assign.cs (FieldInitializer): Use resolved expression for emit.
6432 * class.cs: Print less confusing error message.
6434 2007-11-16 Marek Safar <marek.safar@gmail.com>
6436 * cs-tokenizer.cs: Removed GMCS ifdefs.
6438 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6441 * cs-parser.jay: Disabled nullable check.
6443 * generic-mcs: Copied more generic stuff.
6445 2007-11-16 Marek Safar <marek.safar@gmail.com>
6447 * gcs-parser.jay: Merged to cs-parser.jay.
6449 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6450 * *.csproj, *.sources: Updated to use only jay parser file.
6452 2007-11-16 Marek Safar <marek.safar@gmail.com>
6454 * gcs-parser.jay: Added nullable and default expression feature checks.
6456 2007-11-16 Marek Safar <marek.safar@gmail.com>
6458 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6459 it fixes many TODOs and hidden bugs.
6461 * expression: Removed duplicate error check.
6463 2007-11-15 Marek Safar <marek.safar@gmail.com>
6465 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6466 implicitly type local variable only when it is used in a declaration.
6468 2007-11-15 Marek Safar <marek.safar@gmail.com>
6470 * attribute.cs: Use CS0612 for empty strings.
6472 2007-11-14 Marek Safar <marek.safar@gmail.com>
6474 * lambda.cs, statement.cs: Contextual return may act as a statement.
6476 2007-11-14 Marek Safar <marek.safar@gmail.com>
6478 A fix for a regression cause by #324222
6479 * class.cs: Don't report unused even when it implements an interface.
6481 2007-11-13 Marek Safar <marek.safar@gmail.com>
6483 A fix for bug #341205
6484 * ecore.cs, expression.cs: Method group expression cannot do static
6485 method access with an instance reference check before overloading takes
6488 2007-11-13 Marek Safar <marek.safar@gmail.com>
6490 A fix for bug #325359
6491 * class.cs: Use predictable name for automatically generated property.
6493 2007-11-12 Marek Safar <marek.safar@gmail.com>
6495 A fix for bug #324996
6496 * expression.cs (Is): Handle case where D is nullable and T is not
6499 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6501 2007-11-12 Marek Safar <marek.safar@gmail.com>
6503 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6504 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6505 Flush small error reporting changes.
6507 2007-11-09 Marek Safar <marek.safar@gmail.com>
6509 A fix for bug #324996
6510 * expression.cs: Rewrote Is expression implementation to work with
6511 generics, nullable types, anonymous method. A const result expression
6512 uses existing infrastructure instead of custom not fully-featured one.
6514 2007-11-08 Marek Safar <marek.safar@gmail.com>
6516 A fix for bug #340202
6517 * class.cs: Consider generics for volatile field.
6519 2007-11-08 Marek Safar <marek.safar@gmail.com>
6521 A fix for bug #335594
6522 * expression.cs: Use conversion rules when handling string addition.
6524 2007-11-07 Marek Safar <marek.safar@gmail.com>
6526 A fix for bug #336651
6527 * expression.cs: Fixed a crash when probing is on.
6529 2007-11-07 Marek Safar <marek.safar@gmail.com>
6531 A fix for bug #324242
6532 * covert.cs: Added a conversion from any nullable-type with an
6533 underlying enum-type to the type System.Enum.
6535 2007-11-07 Marek Safar <marek.safar@gmail.com>
6537 A fix for bug #324222
6538 * class.cs: Report all non-used event fields.
6540 2007-11-07 Marek Safar <marek.safar@gmail.com>
6542 A fix for bug #325161
6543 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6544 qualifier for generic types.
6546 2007-11-07 Marek Safar <marek.safar@gmail.com>
6548 A fix for bug #322971
6549 * expression.cs, ecore.cs: Added intermediate result value check for
6552 2007-11-07 Marek Safar <marek.safar@gmail.com>
6554 A fix for bug #324754
6555 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6556 when it was requested.
6558 2007-11-07 Marek Safar <marek.safar@gmail.com>
6560 A fix for bug #325101
6561 * expression.cs: Do type not value comparison for `is' expression.
6563 2007-11-07 Marek Safar <marek.safar@gmail.com>
6565 A fix for bug #320236
6566 * convert.cs: Don't apply user conversion on underlying target type.
6568 2007-11-06 Marek Safar <marek.safar@gmail.com>
6570 * expression.cs: Don't use unresolved expression for error reporting.
6572 2007-11-06 Marek Safar <marek.safar@gmail.com>
6574 A fix for bugs #337712, #324490
6575 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6576 overloading resolution too.
6578 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6579 the process consistent and more robust.
6581 * expression.cs, linq.cs, report.cs: Update.
6583 2007-11-02 Marek Safar <marek.safar@gmail.com>
6585 A fix for bug #332909
6586 * attribute.cs: Resolve attributes in correct context using error
6589 * rootcontext.cs: Define Obsolete attribute members as core members.
6591 2007-11-02 Marek Safar <marek.safar@gmail.com>
6593 * statement.cs: Removed unused methods.
6595 2007-10-31 Wade Berrier <wberrier@novell.com>
6597 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6598 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6601 2007-10-31 Marek Safar <marek.safar@gmail.com>
6603 A fix for bug #338102
6604 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6605 methods registered as non-generics.
6607 2007-10-31 Marek Safar <marek.safar@gmail.com>
6609 A fix for bugs #337712, #324490
6610 * delegate.cs: Delegate covariance and contravariance is not allowed for
6613 2007-10-31 Marek Safar <marek.safar@gmail.com>
6615 A fix for bug #337719
6616 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6619 2007-10-30 Marek Safar <marek.safar@gmail.com>
6621 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6623 2007-10-29 Marek Safar <marek.safar@gmail.com>
6625 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6628 2007-10-29 Raja R Harinath <rharinath@novell.com>
6630 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6632 2007-10-29 Marek Safar <marek.safar@gmail.com>
6634 A fix for bug #334652
6635 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6636 extension methods when we have not found the best candidate in normal
6639 2007-10-27 Marek Safar <marek.safar@gmail.com>
6641 * AssemblyInfo.cs: Keep up-to-date.
6643 2007-10-27 Marek Safar <marek.safar@gmail.com>
6645 * Makefile: Fixed generics compiler name.
6647 2007-10-27 Marek Safar <marek.safar@gmail.com>
6649 * lambda.test: removed, lambda parsing is done differently.
6651 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6653 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6655 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6657 2007-10-27 Marek Safar <marek.safar@gmail.com>
6659 * Makefile, *.sources : All C# compilers are in mcs folder.
6661 * *.cs: Use existing 2_1 define for smcs.
6663 2007-10-26 Marek Safar <marek.safar@gmail.com>
6665 A fix for bug #335847
6666 * assign.cs, expression.cs: Couple of changes to avoid creating a
6667 temporary variable for each object initializer assignment statement. It
6668 simplifies struct initialization too, otherwise two temporary variables
6670 Implemented optimization of redundant default element initializers.
6672 2007-10-25 Marek Safar <marek.safar@gmail.com>
6674 A fix for bug #336766
6675 * expression.cs (Class.CheckBase): Use generic name when method is
6678 2007-10-25 Marek Safar <marek.safar@gmail.com>
6680 A fix for bug #334737
6681 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6682 variable and not variable argument for prepared copies.
6684 2007-10-24 Marek Safar <marek.safar@gmail.com>
6686 A fix for bug #325110
6687 * class.cs, expression.cs, attribute.cs: Use open generic method when
6688 checking conditional attribute.
6690 2007-10-24 Marek Safar <marek.safar@gmail.com>
6692 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6693 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6694 FeatureIsNotAvailable.
6696 2007-10-24 Marek Safar <marek.safar@gmail.com>
6698 ** C# 3.0 Partial methods
6700 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6701 methods support. Because of member cache issue with generics only
6702 non-generics partial methods are fully supported.
6704 2007-10-23 Marek Safar <marek.safar@gmail.com>
6706 * class.cs, decl.cs: Rewrote member overloads check to cope with
6707 generics and to use member cache for member checking. It also improves
6708 performance and fixes remaining overloads issues.
6710 2007-10-20 Marek Safar <marek.safar@gmail.com>
6712 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6713 roottypes.cs, typemanager.cs:
6715 A member cache creation logic changed to add members immediately and
6716 not rely on fallback. The member cache is now only prefered way
6717 how to access and find type declaration members. It saves 5 MB of memory
6718 during MWF compilation and makes code ready for more optimizations and
6719 clean-ups, it's also a pre-requirement for partial methods.
6721 2007-10-18 Raja R Harinath <harinath@gmail.com>
6723 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6724 handling for generic parameters.
6726 2007-10-15 Marek Safar <marek.safar@gmail.com>
6728 * class.cs (FixedField): Removed redundant volatile check.
6730 2007-10-15 Marek Safar <marek.safar@gmail.com>
6732 * class.cs, decl.cs: Fixed overload members verification to do only one
6733 check per possible collision.
6735 2007-10-13 Marek Safar <marek.safar@gmail.com>
6737 A fix for bug #325478
6738 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6739 and create only one disposable flags container.
6741 2007-10-12 Marek Safar <marek.safar@gmail.com>
6743 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6744 * statement.cs (Fixed): Fixed variables cloning.
6746 2007-10-12 Marek Safar <marek.safar@gmail.com>
6748 A fix for bug #333342
6749 * class.cs (EventField): Don't mark value type event as synchronized.
6751 2007-10-12 Marek Safar <marek.safar@gmail.com>
6753 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6754 inference to identify best candidate method correctly.
6755 (ProperyExpr): A range variable is read only and cannot be modified.
6757 2007-10-11 Marek Safar <marek.safar@gmail.com>
6759 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6760 logic to identify best candidate method correctly.
6762 2007-10-11 Marek Safar <marek.safar@gmail.com>
6764 * location.cs (Equals, GetHashCode): Removed.
6766 2007-10-11 Marek Safar <marek.safar@gmail.com>
6768 * report.cs: Implemented message recorder. It is used mainly for lambda
6769 expressions to capture otherwise swallowed error messages.
6771 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6773 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6775 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6777 * expression.cs (MemberAccess): Always report lookup failure.
6779 * location.cs: Implemented Equals, GetHashCode.
6781 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6783 2007-10-10 Jb Evain <jbevain@novell.com>
6785 * codegen.cs: re-enable assembly version check.
6787 2007-10-09 Marek Safar <marek.safar@gmail.com>
6789 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6792 * namespace.cs (UsingAlias): Do correct version check.
6794 2007-10-08 Marek Safar <marek.safar@gmail.com>
6796 * expresison.cs, ecore.cs: Issue extension method error message when
6799 * rootcontext.cs: Added ISO_2 compiler mode option.
6801 2007-10-08 Marek Safar <marek.safar@gmail.com>
6803 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6806 2007-10-08 Marek Safar <marek.safar@gmail.com>
6808 * attribute.cs (GetString, GetBoolean): Work with both literal and
6811 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6812 Moved method overload specific methods to MethodGroupExpr.
6814 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6815 it should be less memory consuming.
6817 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6819 * codegen.cs: remove the assembly version check until the buildbot is
6822 2007-10-07 Jb Evain <jbevain@novell.com>
6824 * attribute.cs (Attribute.GetString): if the value
6825 expression is a StringConstant, return its string value.
6827 2007-10-07 Jb Evain <jbevain@novell.com>
6829 * typemanager.cs: add `assembly_version_attribute_type`.
6830 * codegen.cs: on attribute emission, check that the
6831 AssemblyVersionAttribute doesn't overflow.
6833 2007-10-05 Marek Safar <marek.safar@gmail.com>
6835 A fix for bug #324677
6836 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6837 parent container of a scope container with currently resolved one.
6839 2007-10-05 Marek Safar <marek.safar@gmail.com>
6841 A fix for bug #325534
6842 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6845 2007-10-05 Marek Safar <marek.safar@gmail.com>
6847 A fix for bug #327504
6848 * class.cs (Operator.Define): Refactored implicit and explicit user
6849 operator conversion rules.
6851 2007-10-05 Marek Safar <marek.safar@gmail.com>
6853 A fix for bug #327520
6854 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6856 2007-10-04 Marek Safar <marek.safar@gmail.com>
6858 A fix for bug #328022
6859 * class.cs (MethodData.Define): Use correct method to check whether
6860 a method implementents an accessor.
6862 2007-10-04 Marek Safar <marek.safar@gmail.com>
6864 A fix for bug #330069
6865 * statement.cs (Fixed.Resolve): Read the first array element only when
6866 an array is instantiated.
6868 2007-10-04 Marek Safar <marek.safar@gmail.com>
6870 * expression.cs, assign.cs, generics.cs: Print correct operator when
6871 compound assignment is used.
6873 2007-10-04 Marek Safar <marek.safar@gmail.com>
6875 A fix for bug #325841
6876 * expression.cs (ArrayAccess): Use full argument cloning only for
6877 string compound concatenation.
6879 2007-10-03 Marek Safar <marek.safar@gmail.com>
6881 A fix for bug #328774
6882 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6884 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6887 2007-10-03 Raja R Harinath <rharinath@novell.com>
6890 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6891 Event accessibility checks here. Remove some bogus code that
6892 accidently made GenericMethods work.
6893 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6895 2007-09-25 Marek Safar <marek.safar@gmail.com>
6897 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6899 * statement.cs (Block): Refactored AddVariable to allow error handling
6902 * generic.cs: New stub.
6904 2007-09-23 Marek Safar <marek.safar@gmail.com>
6906 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6909 2007-09-17 Marek Safar <marek.safar@gmail.com>
6911 * class.cs: Use partial container to record whether any partial part
6912 contains static field initializer and therefore default contructor has
6915 2007-09-14 Marek Safar <marek.safar@gmail.com>
6917 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6918 mono-list when only one of two partial parts has defined accessibility
6921 2007-09-14 Marek Safar <marek.safar@gmail.com>
6923 A fix for bug #82845
6925 * class.cs (TypeContainer): Set correct resolve context for all field
6928 2007-09-13 Marek Safar <marek.safar@gmail.com>
6930 * assign.cs: Fixed a crash when field is resolved twice with an error.
6932 * codegen.cs: Changed InFieldInitializer to be flag.
6934 * anonymous.cs, ecore.cs, expression.cs: Update after
6935 IsInFieldInitializer rename.
6937 * const.cs: Removed unused parameter.
6939 * class.cs: Changed the way how we resolve and emit field initializers.
6940 The field initilizers have to have access to contructor block to emit
6941 compiler generated code.
6943 2007-09-13 Marek Safar <marek.safar@gmail.com>
6945 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6946 generics use TypeContainer instead.
6948 2007-09-12 Marek Safar <marek.safar@gmail.com>
6950 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6952 * lambda.cs (ResolveParameters): Use more powerful
6953 InflateGenericArgument.
6955 * parameters.cs: Better exception message.
6957 2007-09-10 Marek Safar <marek.safar@gmail.com>
6959 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6960 correct expression block type.
6962 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6964 * expression.cs (Invocation): Extracted method group resolve to
6967 2007-09-07 Marek Safar <marek.safar@gmail.com>
6969 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6970 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6972 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6973 generic extension methods.
6975 2007-09-06 Marek Safar <marek.safar@gmail.com>
6977 A fix for bug #82676 (Do I get it right now?)
6978 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6979 object before a standard conversion is applied.
6981 2007-09-06 Marek Safar <marek.safar@gmail.com>
6983 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6986 2007-09-05 Marek Safar <marek.safar@gmail.com>
6988 A fix for bug #82676
6989 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6990 non-generic interface types.
6992 2007-09-05 Marek Safar <marek.safar@gmail.com>
6994 A fix for bug #82690
6995 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6997 2007-09-05 Marek Safar <marek.safar@gmail.com>
6999 A fix for bug #82571
7000 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
7001 modifier for container based methods.
7003 2007-09-05 Marek Safar <marek.safar@gmail.com>
7005 A fix for bug #82676
7006 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
7007 any interface-type T means to any of interface type T.
7009 2007-09-04 Marek Safar <marek.safar@gmail.com>
7011 * namespace.cs: We have 2 versions of System.Core assembly.
7013 2007-09-04 Marek Safar <marek.safar@gmail.com>
7015 A fix for bug #82652
7016 * class.cs (Class.GetClassBases): Compare types and not expressions.
7018 2007-09-04 Marek Safar <marek.safar@gmail.com>
7020 A fix for bug #82620
7021 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
7022 actually never worked before.
7023 (IndexerAccess): Emit prepared arguments before they are modified.
7025 2007-09-04 Marek Safar <marek.safar@gmail.com>
7027 A fix for bug #82563
7028 * assign.cs: Revert wrong fix.
7030 * expression.cs (VariableReference.EmitAssign): Handle ref reference
7032 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
7033 Instead of ldelema/stdind we have to use temporary variables to handle
7034 cases like String.Concat (params string[]).
7036 2007-08-31 Marek Safar <marek.safar@gmail.com>
7038 * class.cs: EmitAttributes to Emit rename.
7040 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
7042 (MemberCore.HasClsCompliantAttribute): Don't depend on
7043 GetClsCompliantAttributeValue execution.
7045 2007-08-31 Marek Safar <marek.safar@gmail.com>
7047 * anonymous.cs: Use shorter type prefix.
7049 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
7052 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
7053 variables when probing is on.
7055 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
7056 unresolved variables.
7057 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
7058 handle transparent identifiers.
7060 2007-08-26 Marek Safar <marek.safar@gmail.com>
7062 * attribute.cs (IsClsCompliant): Add nullable types test.
7064 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
7066 * doc.cs : catch other types of exception than XmlException to
7067 report CS1570. Fixed bug #82565.
7069 2007-08-23 Marek Safar <marek.safar@gmail.com>
7071 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
7072 The number of delegate parameters has to match.
7073 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
7076 2007-08-21 Marek Safar <marek.safar@gmail.com>
7078 * anonymous.cs (AnonymousMethod): Generate private anonymous method
7079 to fix problem with private arguments.
7081 2007-08-20 Marek Safar <marek.safar@gmail.com>
7083 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
7085 * decl.cs (MemberName): Ignore generic type with no generic arguments.
7087 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
7088 empty. Add cloning suport.
7090 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
7092 2007-08-20 Marek Safar <marek.safar@gmail.com>
7094 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
7095 to create EmptyCast. It handles EmptyConstantCast specialization for
7098 2007-08-18 Marek Safar <marek.safar@gmail.com>
7100 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
7101 (EmitArrayArgument): One routine for array arguments.
7102 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
7104 2007-08-17 Marek Safar <marek.safar@gmail.com>
7106 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
7108 2007-08-17 Marek Safar <marek.safar@gmail.com>
7110 * anonymous.cs: MemberLookupFinal update.
7112 * class.cs (ConstructorInitializer): Is expression based.
7114 * delegate.cs: MethodGroupExpr update.
7116 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
7118 (Error_MemberLookupFailed): Customizable error override.
7119 (MethodGroupExpr): Keep queried type for later usage.
7120 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
7123 * expression.cs: Error_MemberLookupFailed refactoring.
7124 (New.DoResolve): Resolve as much as possible.
7125 (ElementInitializer.Error_MemberLookupFailed): Object initializer
7126 customization for invalid member types.
7128 * statement.cs: MethodGroupExpr update.
7130 2007-08-16 Marek Safar <marek.safar@gmail.com>
7132 * modifier.cs (Check): Check all modifiers and not only accessibility
7135 2007-08-16 Marek Safar <marek.safar@gmail.com>
7137 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
7138 type and not an expression.
7140 2007-08-16 Marek Safar <marek.safar@gmail.com>
7142 * statement.cs (Catch.Clone): Type and variable can be null.
7144 2007-08-16 Marek Safar <marek.safar@gmail.com>
7146 A fix for bug #81979
7147 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
7148 I am really not sure whether this is the best fix.
7150 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
7153 2007-08-14 Marek Safar <marek.safar@gmail.com>
7155 ** C# 3.0 Object and collection initializers (major re-write)
7157 * assign.cs (DoResolve): Initializers are not assign related.
7159 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
7160 used during collection or object initialization.
7162 * expression.cs (Error_InvalidArguments): Add initializers specific
7163 messages. More will come later because it requires some general
7165 (New.DoResolve): Better error handling for unsafe types.
7166 (EmptyExpressionStatement): New class.
7167 (ElementInitializer): An object initializer expression.
7168 (CollectionElementInitializer): A collection initializer expression.
7169 (CollectionOrObjectInitializers): A block of object or collection
7171 (NewInitialize): New expression with element/object initializers.
7173 * statement.cs: Reverted object/collection initializer hacks.
7175 * typemanager.cs (CSharpName): Filter __arglist type.
7177 2007-08-09 Marek Safar <marek.safar@gmail.com>
7179 ** C# 3.0 Anonymous Types (update to the latest standard)
7181 * expression.cs (Binary.ResolveOperator): Threat all null based types
7183 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
7184 (AnonymousTypeParameter): Updated.
7186 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
7187 (AnonymousTypeClass): New anonymous type container.
7189 * class.cs (AddField): Return operation result.
7191 * generic.cs: Another empty TypeArguments overload.
7193 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
7194 are stored at top of normal hierarchy.
7196 * typemanager.cs (CSharpName): Filter anonymous types.
7198 2007-08-09 Marek Safar <marek.safar@gmail.com>
7200 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
7201 as single Concat call. How could we miss that :-(
7203 2007-08-08 Marek Safar <marek.safar@gmail.com>
7205 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
7207 2007-08-07 Miguel de Icaza <miguel@novell.com>
7209 * expression.cs: Fix the previous commit, the creation of the
7210 arguments array list needs also to be conditional on the arguments
7213 * class.cs: Add a little bit of help to help narrow down problems.
7215 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
7216 not try to copy in that case.
7218 * driver.cs: When building SMCS, include a new different set of
7219 default assemblies here. Do this here so we can control whether
7220 to include the default assemblies with /noconfig.
7222 2007-08-03 Marek Safar <marek.safar@gmail.com>
7224 A fix for bug #81979
7225 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
7228 2007-08-03 Marek Safar <marek.safar@gmail.com>
7230 A fix for bug #82300
7232 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
7233 we are in probing scope.
7235 2007-08-03 Marek Safar <marek.safar@gmail.com>
7237 A fix for bug #82301
7239 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
7240 (Statement.CloneTo): Clone and not map children blocks.
7242 2007-08-03 Marek Safar <marek.safar@gmail.com>
7244 A fix for bug #82299
7246 * expression.cs (LocalVariableReference.CloneTo): Remap local info
7249 * statement.cs (Statement.CloneTo): Clone variables before statements
7250 to allow remaping of local variables.
7252 2007-08-03 Marek Safar <marek.safar@gmail.com>
7254 A fix for bug #82296
7257 * report.cs: Log crash details for future clone problems.
7259 * statement.cs (Return.Clone): Don't clone non-existent expression.
7261 2007-08-03 Raja R Harinath <harinath@gmail.com>
7263 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
7264 (Class.AddBasesForPart): Move CS0537 check here from ...
7265 * cs-parser.jay (class_declaration): ... here. Move calling of
7266 'AddBasesForPart' to ...
7267 (class_bases): ... here.
7268 (struct_declaration, interface_declaration): Update to changes.
7270 2007-08-02 Marek Safar <marek.safar@gmail.com>
7272 A fix for bug #81923
7274 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
7275 conversion is allowed.
7277 2007-08-02 Marek Safar <marek.safar@gmail.com>
7279 A fix for bug #81564
7281 * ecore.cs (EventExpr): Add IsBase handling.
7283 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
7286 2007-08-02 Raja R Harinath <harinath@gmail.com>
7288 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
7289 * cs-parser.jay: Some whitespace cleanups.
7290 (current_delegate): New.
7292 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
7293 a dummy code block, and use 'type_name' instead of 'member_name'.
7294 (interface_declaration, class_declaration): Likewise.
7295 (delegate_declaration): Likewise. Rearrange slightly and use
7297 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7298 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7300 2007-08-02 Marek Safar <marek.safar@gmail.com>
7302 A fix for bug #82039
7304 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7307 * typemanager.cs (CSharpName): Split to string overload.
7309 2007-08-02 Marek Safar <marek.safar@gmail.com>
7312 * report.cs: Updated warning CS0472.
7314 2007-08-01 Marek Safar <marek.safar@gmail.com>
7316 A fix for bug #82181
7318 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7320 2007-08-01 Marek Safar <marek.safar@gmail.com>
7322 A fix for bug #82277
7323 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7325 2007-08-01 Marek Safar <marek.safar@gmail.com>
7327 ** C# 3.0 Type Inference (major bits are working)
7329 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7330 (.ImplicitStandardConversionExists): Uses compatible.
7331 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7332 (.InferReturnType): New method.
7333 (.Compatible): Refactored.
7334 (.ResolveParameters): Uses factory to create resolved parameters.
7335 (.CompatibleMethod): Add probing mode support.
7336 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7337 clearly distinguish between 2 different operations.
7338 (LambdaMethod): Moved to lambda.cs.
7339 (AnonymousMethod): Removed unused fields and methods.
7340 (AnonymousDelegate): Simplified.
7342 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7344 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7346 * delegate.cs (Delegate): New mehods to reduce code duplication.
7347 (.GetConstructor): New method.
7348 (.GetInvokeMethod): New method.
7349 (DelegateCreation): Updated.
7351 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7353 (OverloadResolve): Made probing little bit faster.
7355 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7358 * generic.cs (TypeInferenceContext): Dummy implementation.
7360 * iterators.cs: Updated after Resolve/Define rename.
7362 * lambda.cs (LambdaExpression)
7363 (.ResolveParameters): Handles both type of arguments and type inference too.
7365 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7366 (InflateTypes): Updated.
7368 * support.cs (InflateTypes): Changed signature and updated.
7370 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7371 (MemberLookup_FindMembers): More MS tricks.
7372 (GetParameterData): Ditto.
7373 (GetDelegateParameters): Uses quick path for dynamic types.
7375 2007-08-01 Marek Safar <marek.safar@gmail.com>
7377 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7380 2007-07-31 Marek Safar <marek.safar@gmail.com>
7382 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7385 2007-07-26 Jb Evain <jbevain@novell.com>
7387 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7388 which takes a boolean 'report_errors', similar to the GetMethod.
7389 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7390 in .net 2.1, do not report errors here.
7392 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7393 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7394 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7397 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7398 of the type InternalsVisibleToAttribute before the first call
7399 to CoreLookupType which is allowed to fail (third boolean parameter
7400 to true). Because, during the resolution for a type that is not
7401 immediately found, we try to check if the type is not defined in
7402 a friend assembly, and to do so, we need the
7403 InternalVisibleToAttribute.
7405 2007-07-23 Miguel de Icaza <miguel@novell.com>
7407 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7408 feature that allows structs to be compared against null and inline
7409 the result as true or false.
7411 Notice that the same code is not permitted inside a generic block
7412 of code that would do:
7414 class Foo<T> where T : struct {
7421 It is only allowed if the type of T is not bound (no where
7422 clause). In my opinion, this CSC 2 behavior is broken but people
7423 seem to be using it (IronRuby does, a few bug reports on bugzilla
7424 have it and some people have complained about it).
7426 All of the users that depend on this behavior have code that is
7429 * report.cs (Warning, Error): make these take object arguments,
7430 not strings, as that allows us to take advantage of Format.
7432 2007-07-20 William Holmes <billholmes54@gmail.com>
7434 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7435 Left member variable for the Count.
7436 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7437 MemberName.CountTypeArguments to avoid a NRE.
7439 This code is contributed under the MIT X11 license
7441 2007-07-18 Marek Safar <marek.safar@gmail.com>
7443 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7445 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7447 * doc.cs : generic method arguments are written as ``x while generic
7448 type arguments are `x. Combined with the previous change, fixed bug
7451 2007-07-18 Raja R Harinath <rharinath@novell.com>
7454 * expression.cs (Binary.ResolveOperator): When converting
7455 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7457 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7459 * doc.cs : when T: or whatever x: is specified, it does not really
7460 check the doc comment's syntax correctness. Fixed bug #82006.
7462 2007-07-18 Marek Safar <marek.safar@gmail.com>
7464 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7465 LambdaExpression better.
7467 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7469 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7471 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7472 as it can be generated.
7474 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7477 * lambda.cs (LambdaExpression): Refactored to share same code with
7478 AnonymousMethodExpression.
7480 2007-07-17 Marek Safar <marek.safar@gmail.com>
7482 * anonymous.cs (MakeName): Include host name for easier debugging.
7483 (LambdaMethod): New class for lambda spcecific stuff.
7485 * attribute.cs: Set EmitContext return type.
7487 * class.cs: Set EmitContext return type.
7489 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7490 with null/void meaning.
7492 * iterators.cs (ContainerType): Implemented.
7494 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7496 * statement.cs (Return): Updated to lambda expressions.
7497 (Block.CloneTo): Parent can be null.
7499 2007-07-13 Marek Safar <marek.safar@gmail.com>
7501 A fix for bug #81917
7502 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7504 * class.cs (FixedField): Check whether field is in unsafe scope.
7506 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7507 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7509 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7512 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7514 2007-07-13 Marek Safar <marek.safar@gmail.com>
7516 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7517 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7520 2007-07-13 Marek Safar <marek.safar@gmail.com>
7522 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7524 2007-07-13 Marek Safar <marek.safar@gmail.com>
7526 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7527 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7529 * codegen.cs(EmitContext): Add ProbingMode flag.
7531 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7533 * driver.cs: For now set both warning values.
7535 * ecore.cs (SimpleName): Name is readonly.
7536 (MethodGroup.OverloadResolve): One quick path for probing.
7538 * expression.cs (Unary): Set Oper r/o.
7539 (Binary): Set Oper r/o.
7540 (ParameterReference): Set few instance variables as r/o.
7541 (ParameterReference.DoResolveBase): Don't capture aruments when
7543 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7544 (Arglist): arguments are private.
7545 (SizeOf): type is private and r/o.
7546 (MemberAccess): arguments are private.
7548 * report.cs: Enhanced reporting on/off capabilities.
7550 * lambda.cs: Uses ec.IsInProbingMode.
7551 (ContextualReturn): Derives from return.
7553 * rootcontext.cs: For now set both warning values.
7555 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7557 (Return.Resolve): Don't die immediately.
7558 (Block.Resolve): Speed-up probing.
7559 (Block.CloneTo): Clone only child blocks.
7561 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7563 * iterators.cs: reverted Miguel's latest change (r81925) as it
7564 breaks the build in System.
7566 2007-07-13 Miguel de Icaza <miguel@novell.com>
7568 * iterators.cs (Yield.CheckContext): Check for the iterator type
7569 also here as we can call into Yield even in codepaths that are not
7571 (MethodOrOperator is the only path that was checked).
7573 In addition to the standard check, use a more specific check for
7574 constructors to report a more verbose error.
7576 2007-07-12 Miguel de Icaza <miguel@novell.com>
7578 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7579 report the warning and continue
7581 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7582 values on the stack on the call to Emit. Use EmitStatement if
7583 possible, or using Emit + Pop if not possible. Fixes #82064
7585 2007-07-12 Raja R Harinath <rharinath@novell.com>
7587 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7588 avoid try...finally in some cases.
7590 2007-07-10 Marek Safar <marek.safar@gmail.com>
7592 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7594 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7595 instead of method. Re-use standard error handling.
7596 (ConstructorInitializer.Emit): Simplified.
7598 * delegate.cs: Updated after Invocation.EmitCall change.
7600 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7601 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7602 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7603 method and don't permanently changing input arguments.
7604 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7605 is resolved it has one of the candidates is the best one which is later
7606 used to emit. Removed a few unused method.
7607 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7609 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7610 (Binary.ResolveOperator): Ditto.
7611 (ConditionalLogicalOperator.DoResolve): Ditto.
7612 (Invocation): Uses method group.
7613 (Invocation.DoResolve): Simplified.
7614 (Invocation.EmitCall): Removed useless is_static.
7615 (Invocation.Emit): Delegate to method group.
7616 (Invocation.EmitStatement): Simplified.
7617 (New): Uses method group.
7618 (MemberAccess.DoResolve): Don't destroy original expression.
7620 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7622 2007-07-04 Marek Safar <marek.safar@gmail.com>
7624 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7627 * lambda.cs: Add custom error message type.
7629 2007-07-03 Marek Safar <marek.safar@gmail.com>
7631 * lambda.cs: Simplified little bit.
7633 * parameter.cs: Introduced ImplicitLambdaParameter.
7634 (Parameters.CreateFullyResolved): New factory instead of ctor.
7638 * delegate.cs: Updated parameter creation.
7640 2007-07-03 Marek Safar <marek.safar@gmail.com>
7642 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7645 * generic.cs: Synchronized with gmcs.
7647 2007-07-03 Marek Safar <marek.safar@gmail.com>
7649 * class.cs (Indexer): Check return type as soon as possible.
7651 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7654 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7656 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7658 * parameter.cs (Parameter): Use expression type when it is available.
7660 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7661 method modifier for the first parameter only.
7663 2007-06-24 Marek Safar <marek.safar@gmail.com>
7665 A fix for bug #81938
7666 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7668 * constant.cs: Tide up an exception message.
7670 2007-06-22 Marek Safar <marek.safar@gmail.com>
7672 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7673 an uninitialized variable is used.
7675 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7677 2007-06-22 Marek Safar <marek.safar@gmail.com>
7679 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7680 not found error handling.
7682 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7684 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7685 (ArrayCreation.DoResolve): Simplified.
7686 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7687 its own resolve process.
7688 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7690 2007-06-20 Marek Safar <marek.safar@gmail.com>
7692 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7695 2007-06-20 Marek Safar <marek.safar@gmail.com>
7697 * cs-tokenizer.cs: Removed var related stuff.
7699 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7700 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7701 a type and a keyword at same time.
7703 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7706 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7707 implicitly typed arrays, more changes will follow.
7709 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7711 2007-06-19 Marek Safar <marek.safar@gmail.com>
7713 * ecore.cs (VarExpr): Removed Handled field.
7715 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7716 build-in assign functionality.
7717 (ForEach.Resolve): Removed all implicitly typed local variable code and
7719 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7720 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7722 2007-06-18 Marek Safar <marek.safar@gmail.com>
7724 * assign.cs: Removed implicitly typed local variable check.
7726 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7727 referencing implicitly typed local variable.
7728 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7731 * statement.cs (Fixed): Removed unsupported implicitly typed local
7734 2007-06-15 Marek Safar <marek.safar@gmail.com>
7736 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7738 2007-06-14 Marek Safar <marek.safar@gmail.com>
7740 A fix for bugs #81855 and #76274
7741 * attribute.cs (AttachTo): Always set owner for global attributes to
7744 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7747 * cs-parser.jay: Assembly and module attributes must precede all other
7748 elements except using clauses and extern alias declarations.
7750 2007-06-13 Marek Safar <marek.safar@gmail.com>
7752 A fix for bug #81748
7754 * expression.cs: More checks for non ISO-1 features.
7756 2007-06-12 Marek Safar <marek.safar@gmail.com>
7758 A fix for bug #81807
7759 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7760 present inside switch statement and it is required by nullable check.
7762 2007-06-12 Marek Safar <marek.safar@gmail.com>
7764 A fix for bug #81840
7765 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7766 when type matching fails.
7768 * namespace.cs: Tiny error message change.
7770 2007-06-12 Marek Safar <marek.safar@gmail.com>
7772 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7773 reporting. Added automatic property check.
7775 * class.cs: Updated after CheckAbstractAndExtern relocation.
7776 (AEventPropertyAccessor.GetSignatureForError): Customized.
7778 2007-06-11 Marek Safar <marek.safar@gmail.com>
7780 * class.cs (DefineBaseTypes): Base type can be undefined.
7782 * ecore.cs (TypeLookup): Minor refactoring.
7783 (DoResolveAsTypeStep): Removed redundant check.
7785 * namespace.cs (Lookup): Removed redundant check.
7787 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7788 ResolveAsTypeTerminal step.
7789 (BootstrapCorlib_*): Simplified.
7790 (PopulateCoreType): Core types can be now external.
7792 2007-06-07 Marek Safar <marek.safar@gmail.com>
7794 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7796 (InferTypeArguments): Infers anonymous expression type arguments.
7797 (Compatible): Split to Compatible and InferTypeArguments.
7799 * lambda.cs: Updated.
7801 2007-06-08 Marek Safar <marek.safar@gmail.com>
7803 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7805 2007-06-07 Raja R Harinath <harinath@gmail.com>
7807 Fix #80477, cs0135-2.cs, cs0135-3.cs
7808 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7809 names to the "known" variables list.
7810 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7811 parameter names are also "known".
7812 (Block.CheckError136): Remove.
7813 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7816 2007-06-07 Marek Safar <marek.safar@gmail.com>
7818 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7820 2007-06-06 Marek Safar <marek.safar@gmail.com>
7822 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7823 internal error not an user error.
7825 * expression.cs (IsApplicable): Refactored to make debugging easier.
7827 * support.cs: More tricks for non-mono runtimes.
7829 * typemanager.cs (CoreLookupType): Made public.
7830 (InitSystemCore): All linq specific stuff moved to linq.cs
7832 2007-06-05 Marek Safar <marek.safar@gmail.com>
7834 * typemanager.cs (CSharpSignature): One more missing build-in types
7836 More tricks for non-mono runtime.
7838 2007-06-05 Raja R Harinath <harinath@gmail.com>
7840 * statement.cs (Block.CheckError136_InParents): Remove.
7841 (Block.AddVariable): Use GetParameterInfo instead.
7842 (ToplevelBlock.ProcessArguments): Likewise.
7844 2007-06-04 Raja R Harinath <rharinath@novell.com>
7846 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7848 (ToplevelBlock.GetParameterInfo): Split out of ...
7849 (ToplevelBlock.GetParameterRefernce): ... this.
7850 (ToplevelBlock.ParameterMap): Remove.
7851 * expression.cs (ParameterReference): Update to use
7852 ToplevelParameterInfo.
7854 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7857 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7858 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7860 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7861 (ToplevelBlock.ProcessParameters) ... here.
7862 (ToplevelBlock..ctor): Invoke it.
7864 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7867 * statement.cs (IKnownVariable): New interface.
7868 (LocalInfo): Implement it.
7869 (ToplevelParameterInfo): New class.
7870 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7871 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7872 GetKnownVariableInfo.
7874 2007-06-03 Raja R Harinath <harinath@gmail.com>
7876 Partly speed up CS0136 error checks.
7877 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7878 'recurse' parameter.
7879 (Block.DoCheckError136): Only check errors in parameters. Move
7880 local variable checks ...
7881 (Block.AddVariable): ... here, and ...
7882 (ToplevelBlock.ResolveMeta): ... here.
7884 2007-06-02 Raja R Harinath <harinath@gmail.com>
7886 * statement.cs (Block.IsChildOf): Remove.
7888 * statement.cs (Statement.Clone): Move special case code ...
7889 (Block.CloneTo): ... here.
7891 2007-05-29 Raja R Harinath <rharinath@novell.com>
7893 * statement.cs (ToplevelBlock.container): Remove field. It's
7894 redundant with 'Parent'.
7895 (ToplevelBlock.ContainerBlock): Remove accessor.
7896 (ToplevelBlock..ctor): Update to changes. Register anonymous
7897 child with parent here, ...
7898 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7900 (start_anonymous): Don't save current_block.
7901 (top_current_block): Remove.
7903 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7904 (Block.Resolve): Update to changes.
7905 (Block..ctor): Move setting of "correct" 'Toplevel'
7906 and 'Explicit' fields to ...
7907 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7909 2007-05-27 Raja R Harinath <harinath@gmail.com>
7912 * statement.cs (Block.Implicit): Remove.
7913 (Block): Update to changes.
7914 * flowanalysis.cs: Likewise.
7916 Mildly speed up CheckInvariantMeaningInBlock
7917 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7918 Recursively call AddKnownVariable to all enclosing blocks.
7919 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7920 Remove recursive calls.
7921 (Block): Update to changes.
7923 New ExplicitBlock invariants
7924 * statement.cs (Block.Explicit): New field. It points to the
7925 immediately enclosing non-implicit block.
7926 (Block..ctor): Maintain the invariant.
7927 * cs-parser.jay: Take advantage of invariant.
7929 Introduce ExplicitBlock
7930 * statement.cs (ExplicitBlock): New.
7931 (ToplevelBlock): Derive from it.
7932 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7934 (Block.Implicit): Update to changes.
7935 * cs-parser.jay: Update to changes.
7938 * codegen.cs (EmitContext.IsLastStatement): Remove.
7939 * statement.cs (Block.DoEmit): Update to changes.
7941 2007-05-25 Raja R Harinath <rharinath@novell.com>
7943 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7944 modifying current_block directly.
7946 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7948 * class.cs: Implemented automatic properties (C# 3.0)
7949 Thanks to Marek for the help.
7951 2007-05-23 Raja R Harinath <rharinath@novell.com>
7953 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7954 variable as assigned, note also that all its components are
7956 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7958 2007-05-19 Marek Safar <marek.safar@gmail.com>
7960 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7961 member is marked as compiler generated.
7963 * decl.cs (MemberCore): Refactored ModFlags into property.
7965 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7966 (Check): Check only accessibility modifiers.
7968 2007-05-18 Raja R Harinath <rharinath@novell.com>
7970 Track all assignable slots in one bit array
7971 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7972 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7973 logic from VariableMap constructor here. Use the same 'offset'
7974 variable that's later used for computing offsets of local
7976 * flowanalysis.cs (UsageVector.parameters): Remove.
7977 (UsageVector): Update to changes.
7978 (VariableMap): Remove.
7980 Avoid creating ParameterMap in every block
7981 * statement.cs (Block.ParameterMap): Move ...
7982 (ToplevelBlock.ParameterMap): ... here.
7983 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7985 * flowanalysis.cs (FlowBranching.param_map): Remove.
7986 (FlowBranching.UsageVector): Update to changes.
7987 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7989 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7991 * expression.cs (ParameterReference): Distinguish between block
7992 where parameter was referenced and declared.
7994 2007-05-18 Marek Safar <marek.safar@gmail.com>
7996 * flowanalysis.cs, statement.cs: Put back improved error handling.
7998 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
8002 Imporved object and collection initialization (C# 3.0).
8004 2007-05-15 Marek Safar <marek.safar@gmail.com>
8006 A fix for bug #81380
8007 * expression.cs (Is.DoResolve): Only value types have constant `is'
8010 2007-05-15 Raja R Harinath <rharinath@novell.com>
8012 * statement.cs (ToplevelBlock.child): Remove.
8014 2007-05-15 Raja R Harinath <harinath@gmail.com>
8016 Rationalize ResolveMeta: refactoring
8017 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
8018 out constant handling code into ...
8019 (Block.DoResolveConstants): ... this.
8021 Rationalize ResolveMeta: kill local_map
8022 * statement.cs (Block.local_map, Block.LocalMap): Remove.
8023 (Block.AssignableSlots): New.
8024 (Block.ResolveMeta): Make protected. Don't create a VariableMap
8025 for locals -- move code from VariableMap here. Avoid unnecessary
8027 * flowanalysis.cs (FlowBranching.local_map): Remove.
8028 (FlowBranching..ctor): Use Block.AssignableSlots.
8029 (VariableMap): Remove unused constructors.
8031 2007-05-11 Raja R Harinath <rharinath@novell.com>
8033 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
8035 2007-05-11 Marek Safar <marek.safar@gmail.com>
8037 * typemanager.cs (IsFriendAssembly): Should not be called for building
8040 2007-05-09 Marek Safar <marek.safar@gmail.com>
8042 * literal.cs (NullConstant): Print null in all cases.
8044 * expression.cs (Binary.ResolveOperator): Implemented delegate
8045 comparison based on C# 2.0 changes.
8047 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
8049 This code is contributed under the MIT X11 license
8051 The following enables support for several C# 3.0 language features:
8053 * cs-tokenizer.cs: Added support for the "var" keyword.
8055 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
8056 Added VarExpr class to facilitate type inferencing.
8058 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
8059 to support anonymous types.
8061 * assign.cs: Added support for type inferencing and initialization.
8063 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
8065 * expression.cs: Added implicit array support to ArrayCreation.
8066 Added 5 types and 1 interface:
8068 IInitializable Implementing classes can inject initializing
8069 statements after object instantiation.
8071 Initializer Stores data for object initialization.
8073 AnonymousType An expression for anonymous types.
8075 AnonymousTypeParameter Stores data about an anonymous type's field.
8077 NewInitialize An expression for object initialization.
8079 CollectionInitialize An expression for collection initialization.
8081 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
8084 2007-05-06 Marek Safar <marek.safar@gmail.com>
8086 A fix for bug #81500
8087 * cs-tokenizer.cs: Add special handling for coalescing operator.
8089 2007-05-06 Marek Safar <marek.safar@gmail.com>
8091 A fix for bug #81529
8092 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
8093 its value from base class until it is redefined.
8095 2007-05-02 Raja R Harinath <rharinath@novell.com>
8097 Fix regression in cs0631-3.cs
8098 * cs-parser.jay (operator_declarator): Add opt_attributes to error
8099 fallback. Make error fallback catch more cases.
8101 2007-05-01 Miguel de Icaza <miguel@novell.com>
8103 * cs-parser.jay: Allow parameters in operator declarations to have
8106 2007-04-27 Miguel de Icaza <miguel@novell.com>
8108 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
8111 * lambda.cs (ContextualReturn.Resolve): An expression is valid
8112 inside the ContextualReturn, it does not have to be an
8113 ExpressionStatement.
8115 2007-04-24 Miguel de Icaza <miguel@novell.com>
8117 * lambda.cs (ContextualReturn.Resolve): if the return type is not
8120 2007-04-23 Miguel de Icaza <miguel@novell.com>
8122 * anonymous.cs (AnonymousContainer): split the virtual Resolve
8123 method in two methods: ResolveNoDefine and Resolve.
8125 ResolveNoDefine will stop just after ResolveTopBlock has been
8128 Resolve will then continue by creating a method and issuing the
8129 call to method.Define ().
8131 (AnonymousMethod): Split and implement the new Resolve and
8132 ResolveNoDefine as well.
8134 * lambda.cs (LambdaExpression): Split the anonymous method
8135 resolution code into a separate routine (CoreCompatibilityTest)
8136 from DoCompatibleTest.
8138 (LambdaExpression.TryBuild): New method, this method tries to
8139 build the LambdaExpression with the given set of types to be used
8140 as the types for the various parameters of the lambda expression.
8142 If the compilation succeed with the given types, the infered type
8143 of the Anonymous method is returned, otherwise null is returned.
8145 2007-04-23 Marek Safar <marek.safar@gmail.com>
8147 A fix for bug #81414
8148 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
8150 2007-04-22 Miguel de Icaza <miguel@novell.com>
8152 * cs-tokenizer.cs: Change various identifiers here from the
8153 camelCasing to the recommended Linux-like style for instance
8154 variables from the Coding Guidelines.
8156 2007-04-19 Martin Baulig <martin@ximian.com>
8159 (Convert.ImplicitReferenceConversionCore): Allow conversions from
8160 System.Enum to System.ValueType.
8162 2007-04-13 Martin Baulig <martin@ximian.com>
8164 Rewrote implicit reference conversions. We need to distinguish
8165 between implicit reference conversions (13.1.4) and implicit
8166 boxing conversions (13.1.5).
8168 According to the spec, there's an an implicit conversion
8169 "From a one-dimensional array-type S[] to IList<T> and base
8170 interfaces of this interface, provided there is an implicit
8171 reference conversion from S to T." Note that this does not
8172 include boxing conversions.
8175 (Convert.ImplicitTypeParameterBoxingConversion): New method.
8176 (Convert.ImplicitReferenceConversion): Split into
8177 ImplicitReferenceConversionCore() and
8178 ImplicitBoxingConversionExist().
8179 (Convert.ImplicitReferenceConversionExists): Use the new
8180 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
8182 2007-04-12 Martin Baulig <martin@ximian.com>
8184 * convert.cs (Convert.ImplicitReferenceConversion): Move the
8185 `TypeManager.null_type' checks up to the top of the method.
8187 2007-04-11 Marek Safar <marek.safar@gmail.com>
8189 A fix for bug #81350
8190 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
8193 2007-04-11 Martin Baulig <martin@ximian.com>
8195 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
8196 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
8197 to make this work for generic classes; fixes #79561.
8199 2007-04-11 Martin Baulig <martin@ximian.com>
8201 * expression.cs (As): Add support for nullable types; fixes #79371.
8203 2007-04-11 Martin Baulig <martin@ximian.com>
8205 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
8206 `type.FullName' is null; fixes #80243.
8208 2007-04-11 Martin Baulig <martin@ximian.com>
8210 * expression.cs (Invocation.IsApplicable): Don't modify the method
8211 if type inference succeeded, but the method was not applicable.
8214 2007-04-10 Marek Safar <marek.safar@gmail.com>
8216 A fix for bug #81324
8217 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
8218 internal and external namespaces containers.
8220 2007-04-10 Martin Baulig <martin@ximian.com>
8222 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
8223 TypeManager.DropGenericMethodArguments() so we also call
8224 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
8226 2007-04-10 Martin Baulig <martin@ximian.com>
8228 * iterators.cs (Iterator.CreateIterator): Don't crash if
8229 `method.ReturnType' is null. This happens if something went wrong
8230 while resolving that typ (we already reported an error in this case).
8232 2007-04-10 Martin Baulig <martin@ximian.com>
8234 * expression.cs (New.DoResolve): Don't call CheckComImport() on
8235 generic interfaces; report the CS0144 directly.
8237 2007-04-10 Martin Baulig <martin@ximian.com>
8239 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
8240 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
8242 2007-04-10 Martin Baulig <martin@ximian.com>
8244 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
8246 2007-04-09 Raja R Harinath <rharinath@novell.com>
8249 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
8250 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
8253 * statement.cs (For.Resolve): If resolution fails, use
8256 2007-04-08 Marek Safar <marek.safar@gmail.com>
8258 * anonymous.cs (MakeName): Make faster and zero-based.
8259 (VerifyExplicitParameterCompatibility): Back to mode where generic
8260 parameter is ignored.
8261 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
8263 * class.cs (EmitType): Method can emit another new method.
8265 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
8267 * driver.cs: Updated.
8269 * lambda.cs: Reuse predefined empty parameters.
8271 * parameter.cs: Updated
8273 * support.cs: Implemented InflateTypes.
8275 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
8276 (InitSystemCore): Introduced to isolate 3.0 dependencies.
8278 2007-04-03 Martin Baulig <martin@ximian.com>
8282 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
8283 version of TypeManager.IsOverride() which also works with generic
8286 2007-04-03 Martin Baulig <martin@ximian.com>
8291 (Convert.ExplicitReferenceConversion): We need to cast when
8292 converting from IList<T> to S[].
8294 2007-04-01 Marek Safar <marek.safar@gmail.com>
8296 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8299 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8301 2007-03-31 Marek Safar <marek.safar@gmail.com>
8303 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8304 argument and return type inferring.
8306 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8307 (ReturnType): Turned to property.
8309 * statement.cs (Return): Implemented return type inferring.
8311 * support.cs (ReflectionParameters): Use local types if possible.
8313 2007-03-30 Raja R Harinath <rharinath@novell.com>
8315 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8316 (FlowBranching.UsageVector): Update to changes.
8318 Prepare to kill 'Reachability'
8319 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8320 argument of constructor.
8322 2007-03-29 Raja R Harinath <rharinath@novell.com>
8324 Prepare to kill 'Reachability'
8325 * flowanalysis.cs (UsageVector.is_unreachable): New.
8326 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8327 'reachability', and verify they're consistent.
8330 * expression.cs (New.EmitStatement): Handle type parameters here too.
8332 2007-03-29 Martin Baulig <martin@ximian.com>
8337 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8338 CompilerGeneratedClass.
8339 (ScopeInfo.EmitScopeInstance): Make this protected.
8340 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8341 `ec.CurrentAnonymousMethod.Scope == Scope'.
8343 * statement.cs (Block.ScopeInfo): Make this a property.
8345 2007-03-27 Raja R Harinath <harinath@gmail.com>
8347 Prepare to kill 'Reachability'
8348 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8349 (FlowBranching.UsageVector.Reachability): Remove property.
8350 (FlowBranching.UsageVector.IsUnreachable): New property.
8351 (FlowBranching.UsageVector.ResetBarrier): New.
8352 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8353 * codegen.cs, statement.cs: Update to changes.
8355 2007-03-27 Martin Baulig <martin@ximian.com>
8360 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8363 2007-03-26 Raja R Harinath <rharinath@novell.com>
8365 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8366 instead of TriState. Remove all mention of TriState.
8368 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8369 replaced by a boolean. Add boolean 'is_unreachable' field, check
8370 and maintain invariants.
8372 2007-03-25 Marek Safar <marek.safar@gmail.com>
8374 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8376 2007-03-25 Marek Safar <marek.safar@gmail.com>
8378 * expression.cs: Stop using obsolete 2.0 opcodes.
8380 2007-03-25 Marek Safar <marek.safar@gmail.com>
8382 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8383 one of the latests Martin's fixes.
8385 2007-03-23 Miguel de Icaza <miguel@novell.com>
8387 * expression.cs: On BigEndian systems, swap the bytes, temporary
8388 solution until we get a new bitconverter class.
8390 2007-03-23 Martin Baulig <martin@ximian.com>
8394 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8395 "Method" and "Method`1". Normally, a cache lookup is done on the
8396 "Method" form (ie. without the generic arity), but this one makes
8397 lookups on the full form work as well.
8399 2007-03-22 Raja R Harinath <rharinath@novell.com>
8401 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8404 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8406 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8407 ordered_member_list, to TypeBuilder to store members to be defined
8408 in the order they were parsed in.
8409 - ordered_explicit_member_list contains all properties indexers
8410 and methods that are defined as explicit implementation of an
8411 interface or base class.
8412 - ordered_member_list contains all properties indexers and methods
8413 that are not defined as explicit implementation of an interface
8416 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8417 functionality in these removed classes has been replaced with
8418 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8419 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8421 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8422 to CheckForDuplications inside GetMethod and SetMethod Define Method
8423 to handle method property and indexer name conflicts.
8427 All code is contributed under the MIT/X11 license.
8429 2007-03-20 Martin Baulig <martin@ximian.com>
8431 * class.cs (TypeContainer.Interfaces): Removed; they're now
8432 included in `TypeContainer.Types'.
8434 2007-03-20 Martin Baulig <martin@ximian.com>
8436 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8438 * class.cs (TypeContainer.CreateType): New public method. This is
8439 now called before DefineType() to create the TypeBuilders.
8440 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8441 has already been created by CreateType().
8442 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8443 don't resolve our base classes here; this has been moved into
8444 DefineBaseTypes(). We're now called from CreateType().
8445 (TypeContainer.DefineBaseTypes): New private method; resolve our
8446 base classes here. We're now called from DefineType().
8449 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8450 our types first to create all the TypeBuilders. After that, call
8451 TypeContainer.DefineType() on all the types which'll resolve their
8452 base classes and setup the resolve order.
8454 2007-03-20 Martin Baulig <martin@ximian.com>
8456 * class.cs (TypeContainer.Enums): Removed; they're now included in
8457 `TypeContainer.Types'.
8459 2007-03-20 Martin Baulig <martin@ximian.com>
8462 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8463 (TypeContainer.DoResolveMembers): Call DefineType() on our
8464 `compiler_generated' classes; moved here from DefineNestedTypes().
8467 (RootContext.ResolveTree): Call ResolveMembers() on all
8468 TypeContainer's in the `type_container_resolve_order'.
8470 2007-03-19 Marek Safar <marek.safar@gmail.com>
8472 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8474 2007-03-17 Marek Safar <marek.safar@gmail.com>
8476 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8477 implementation flags.
8479 2007-03-17 Marek Safar <marek.safar@gmail.com>
8481 * class.cs: More optimizations for type parameters.
8483 2007-03-15 Marek Safar <marek.safar@gmail.com>
8485 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8487 * ecore.cs, parameter.cs: More common code for both corlibs.
8489 * typemanager.cs (IsGenericMethod): Simplified.
8491 2007-03-15 Raja R Harinath <rharinath@novell.com>
8493 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8495 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8497 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8498 unconditionally. Simplify explanation.
8499 (Try.Resolve, Using.Resolve): Likewise.
8501 2007-03-15 Martin Baulig <martin@ximian.com>
8505 * decl.cs (DeclSpace): If we're a partial class, use our
8506 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8508 2007-03-15 Raja R Harinath <rharinath@novell.com>
8510 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8512 (FlowBranching.UsageVector): Update to changes.
8513 (FlowBranching.MergeSiblings): Likewise.
8514 * statement.cs: Likewise.
8516 2007-03-15 Martin Baulig <martin@ximian.com>
8521 (MemberCache): Added a special .ctor for type parameters.
8524 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8527 2007-03-09 Martin Baulig <martin@ximian.com>
8529 * enum.cs (Enum): Make this a TypeContainer.
8530 (EnumMember): Derive from `Const'.
8533 (Const.DoResolveValue): New protected virtual method; move most of
8534 the functionality of ResolveValue() here so we can override it in
8536 (Const.CreateConstantReference): Make this virtual.
8538 * class.cs (Kind): Add `Kind.Enum'.
8539 (TypeContainer.Emit): Don't emit the enums here; they're already
8540 in the `RootContext.typecontainer_resolve_order'.
8542 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8543 here; they're already in the `typecontainer_resolve_order'.
8545 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8546 TypeManager.DropGenericTypeArguments().
8549 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8550 (TypeManager.IsEnumType): Likewise.
8551 (TypeManager.EnumToUnderlying): Likewise.
8552 (TypeManager.IsEqual): Add support for enums.
8554 2007-03-12 Raja R Harinath <rharinath@novell.com>
8556 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8557 DefaultParameterValueAttribute to be undefined, say if System.dll
8560 2007-03-11 Marek Safar <marek.safar@gmail.com>
8562 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8565 2007-03-10 Marek Safar <marek.safar@gmail.com>
8567 * class.cs, parameter.cs: Unified parameters verification.
8569 2007-03-08 Martin Baulig <martin@ximian.com>
8571 * cs-parser.jay (constructor_header): Pass the location to the
8572 newly created TopLevelBlock.
8574 2007-03-07 Martin Baulig <martin@ximian.com>
8576 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8578 2007-03-06 Miguel de Icaza <miguel@novell.com>
8580 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8581 with the changes from David, fixes the build.
8583 2007-03-05 David Mitchell <dmitchell@logos.com>
8585 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8586 and its base interfaces to a one-dimensional array type S[],
8587 provided there is an implicit or explicit reference conversion
8590 2007-03-03 Marek Safar <marek.safar@gmail.com>
8592 * cs-tokenizer.cs: Implemented basic linq grammar.
8594 * driver.cs: Set linq lang version on demand.
8596 2007-02-26 Marek Safar <marek.safar@gmail.com>
8598 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8600 2007-02-25 Marek Safar <marek.safar@gmail.com>
8602 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8605 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8607 Check property and event extern attributes.
8609 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8612 2007-02-24 Marek Safar <marek.safar@gmail.com>
8614 A fix for bug #80407
8615 * ecore.cs: Don't report ambiguity error when methods have same parent.
8617 2007-02-23 Marek Safar <marek.safar@gmail.com>
8619 A fix for bug #80878
8620 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8622 2007-02-22 Marek Safar <marek.safar@gmail.com>
8624 * attribute.cs: Enable ExtensionAttribute presence test.
8626 2007-02-22 Marek Safar <marek.safar@gmail.com>
8628 * class.cs: Warn about missing GetHashCode only when Equals is override.
8630 * decl.cs: Check accessibility of type arguments.
8632 * typemanager.cs: Correctly report nullable array.
8634 2007-02-20 Marek Safar <marek.safar@gmail.com>
8636 * class.cs, report.cs: Capture more details when things go wrong.
8638 2007-02-20 Marek Safar <marek.safar@gmail.com>
8640 A fix for bug #80650
8641 * cs-parser.jay: Anonymous container starts at constructor declaration
8642 and not at block beginning because it has to be usable in constructor
8645 * statement.cs: Use context location and not block one for error reporting.
8647 2007-02-18 Marek Safar <marek.safar@gmail.com>
8649 A fix for bug #78712
8650 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8653 2007-02-18 Marek Safar <marek.safar@gmail.com>
8655 A fix for bug #80493 by Atsushi Enomoto
8656 * cs-parser.jay: Ignore invalid attribute target.
8658 2007-02-18 Marek Safar <marek.safar@gmail.com>
8660 * cs-tokenizer.cs: Ignore '\0' as white space character.
8662 2007-02-17 Miguel de Icaza <miguel@novell.com>
8664 * cs-parser.jay: Add support for lambda expressions to the mcs
8667 * lambda.cs: Only clone when we are probing, not on the final call
8668 (Compatible is the final call).
8670 * statement.cs (CloneContext): Introduce class to provide block
8671 remapping during clone.
8673 All statements Clone themselves now.
8675 (Clone): special handling for blocks, when we clone a block, we
8676 register the block inside this routine, as children of the block
8677 might trigger a lookup.
8679 * expression.cs: Add support for CloneContext in all expressions.
8681 2007-02-17 Marek Safar <marek.safar@gmail.com>
8683 A fix for bug #80493
8684 * statement.cs: Report ambiguous warning when interfaces are not related.
8686 2007-02-15 Marek Safar <marek.safar@gmail.com>
8688 C# 3.0 extension methods.
8690 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8691 cannot be used directly.
8693 * class.cs (Class.Emit): Emit extension attribute if any class method
8694 is extension method.
8695 (Method.Define): Add basic extension method validation conditions.
8696 (Method.Emit): Emit extension attribute for method.
8698 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8699 extension method exists. Currently we follow same approach as Microsoft
8700 does, emit even if a method or a class are private but this can change
8703 * cs-parser.jay: Add handling of `this' keyword in method parameters
8706 * decl.cs (DeclSpace.IsStaticClass): New property.
8707 (MemberCache.FindExtensionMethods): Looks for extension methods with
8708 defined name and extension type.
8710 * doc.cs: Updated after OverloadResolve changes.
8712 * driver.cs: Add new soft reference to System.Core.dll.
8714 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8715 (ExtensionMethodGroupExpr): Represents group of extension methods.
8717 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8718 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8719 to MethodGroupExpr and made non-static for easier customization.
8720 (Invocation.DoResolve): Add extension method lookup when no standard
8722 (MemberAccess.DoResolve): Try extension methods if no member exists.
8724 * modifiers.cs: Add METHOD_EXTENSION modifier.
8726 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8727 as well as candidate extension type.
8728 (ComputeNamespaces): When assembly constains extension methods registers
8730 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8731 extension method lookup.
8732 (Namespace.LookupExtensionMethod): Looks for extension method in this
8734 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8735 find a method which matches name and extensionType.
8737 * parameter.cs (Parameter): Add This modifer.
8738 (HasExtensionMethodModifier): New property.
8739 (Resolve): Add extension parameter check.
8740 (ModFlags): turned to property to exclude this modifier as it is not real
8742 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8744 * support.cs (ParameterData): Add ExtensionMethodType.
8745 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8747 * typemanager.cs: Add type and ctor extension attribute type.
8749 2007-02-15 Miguel de Icaza <miguel@novell.com>
8751 * report.cs (DisableErrors, EnableErrors): used to prevent error
8752 output when we are "trying" to compile various methods with
8755 * ecore.cs (Expression): Add Clone method that calls the virtual
8756 CloneTo method. The current CloneTo method in Expression throws
8757 an exception so we can track down all the places where this must
8758 be implemented (not using abstract, because that would be a lot of
8759 up-front-work before we can start testing the implementation
8762 Important: we only need Clone capabilities for expressions created
8763 by the parser, as the expressions we will be cloning are
8764 expressions in the pre-resolved state. This vastly simplifies
8767 (SimpleName): Add CloneTo that does nothing.
8768 (EmptyCast): Add CloneTo.
8770 * expression.cs (Binary): Implement CloneTo.
8771 (Invocation.IsApplicable): Store the current ec in
8772 EmitContext.TempEc and restore it on return. This is used so we
8773 do not have to sprinkle hundres of methods with an extra
8774 EmitContext, we know that the only user is the lambda expression
8775 ImplicitConversionExists code.
8777 (Argument): Add Cloning capabilities.
8778 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8779 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8780 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8781 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8782 IndexerAccess): Add Clone capability.
8784 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8786 (Argument): Add cloning capability.
8788 * assign.cs (Assign): Implement CloneTo.
8790 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8792 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8793 version by calling Convert with the EmitContext (that we are
8794 currently storing in ec, this is not great, but will do for now,
8795 to avoid passing EmitContext parameters to hundreds of functions
8796 that do not need them now).
8798 (SetExpression): Remove, it is not needed.
8800 (ContextualReturn): Implement CloneTo.
8802 * statement.cs (Statement): Implement cloning infrastructure,
8803 similar to expressions.
8805 (Block): Partial implementation of Clone for statements.
8807 (Return): Implement clone.
8809 * constant.cs (Constant.CloneTo): New method, does nothing.
8811 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8812 solution, until we decide how to exactly do this.
8814 2007-02-14 Marek Safar <marek.safar@gmail.com>
8816 A fix for bug #80493
8817 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8818 a property is override we need to use second accessor.
8820 2007-02-13 Marek Safar <marek.safar@gmail.com>
8822 A fix for bug #80418
8823 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8826 2007-02-13 Marek Safar <marek.safar@gmail.com>
8828 Another fix for bug #80749
8829 * pending.cs: Abstract class has priority over interfaces.
8831 2007-02-13 Marek Safar <marek.safar@gmail.com>
8833 Another fix for bug #80749
8834 * pending.cs: Abstract class has priority over interfaces.
8836 2007-02-13 Marek Safar <marek.safar@gmail.com>
8838 Another fix for bug #80749
8839 * pending.cs: Abstract class has priority over interfaces.
8841 2007-02-13 Marek Safar <marek.safar@gmail.com>
8843 Another fix for bug #80749
8844 * pending.cs: Abstract class has priority over interfaces.
8846 2007-02-13 Marek Safar <marek.safar@gmail.com>
8848 * class.cs Better error message.
8850 * driver.cs: Add shorter versions of -optimize option.
8852 2007-02-13 Martin Baulig <martin@ximian.com>
8854 * class.cs (Constructor.Emit): Check the return value of
8855 ec.ResolveTopBlock() and return on error.
8857 2007-02-13 Raja R Harinath <rharinath@novell.com>
8859 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8860 message to fix error message regression.
8862 2007-02-12 Marek Safar <marek.safar@gmail.com>
8864 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8866 2007-02-12 Marek Safar <marek.safar@gmail.com>
8868 A fix for bug #80749
8869 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8870 its parent container.
8872 * class.cs (DefineFieldInitializers): Each initializer can has different
8875 * const.cs: Updated.
8877 2007-02-11 Miguel de Icaza <miguel@novell.com>
8879 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8880 now all the heavy lifting to check that embedded statements or
8881 expressions have the right form is done in the ContextualReturn.
8883 (ContextualReturn): New class.
8885 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8886 method that can be invoked to report 201, so we do not replicate
8889 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8891 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8892 treating tabs as spaces.
8894 2007-02-09 Marek Safar <marek.safar@gmail.com>
8896 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8897 * assign.cs: Use full implicit conversion for right side check.
8899 2007-02-09 Marek Safar <marek.safar@gmail.com>
8901 * statement.cs (Switch): Switch over boolean type is not standardized.
8903 2007-02-08 Marek Safar <marek.safar@gmail.com>
8905 A fix for bug #80755
8906 * decl.cs (FindBaseEvent): Don't use method cache for events.
8908 2007-02-07 Marek Safar <marek.safar@gmail.com>
8910 * cs-parser.jay: Better syntax error handling.
8912 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8913 instead of underlying type value.
8915 2007-02-06 Marek Safar <marek.safar@gmail.com>
8917 * driver.cs: Check define identifier before is registered.
8919 * namespace.cs: Use existing error message.
8921 * report.cs: New warning.
8923 2007-02-06 Marek Safar <marek.safar@gmail.com>
8925 A fix for bug #80742
8926 * expression.cs: Delegate Invoke method can be called directly.
8928 2007-02-06 Marek Safar <marek.safar@gmail.com>
8930 A fix for bug #80676
8931 * class.cs (IsEntryPoint): The Main method can have params modifier.
8933 2007-02-04 Miguel de Icaza <miguel@novell.com>
8935 * parameter.cs (Parameter, Parameters): Add Clone method.
8937 * anonymous.cs (Compatible): Turn method into virtual method, so
8938 LambdaExpression can implement a different behavior.
8940 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8941 out the basic checking here, so it can be used by
8944 * lambda.cs: Introduce "Compatible" function that will do the
8947 2007-02-02 Marek Safar <marek.safar@gmail.com>
8949 * attribute.cs: Unified one error message.
8951 * class.cs (Class): Use type attributes and not properties to test static
8953 (IsEntryPoint): Don's pass local variable.
8955 * convert.cs: Removed duplicate check.
8957 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8959 * driver.cs: Don't crash when soft reference does not exist.
8961 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8962 (UsingEntry): Removed redundant allocation.
8964 * parameter.cs: Add fast path for type parameters.
8966 * support.cs: Don't allocate attribute when it's not used.
8968 2007-01-30 Miguel de Icaza <miguel@novell.com>
8971 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8972 this into a virtual method, so we can override it in LambdaExpression.
8974 * driver.cs: Improve diagnostics in case of failure.
8976 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8977 write a function that is slightly more complex and that parses:
8979 type identifier [, type identifier]* )
8981 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8984 (canEmpty ? i >= 0 : i > 0)
8986 2007-01-30 Raja R Harinath <rharinath@novell.com>
8988 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8989 exception on possibly valid code.
8991 2007-01-29 Raja R Harinath <rharinath@novell.com>
8993 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8995 (parse_opt_type_arguments): Remove. It's almost the same as
8997 (parse_namespace_or_typename): Use parse_less_than.
8999 2007-01-28 Miguel de Icaza <miguel@novell.com>
9001 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
9002 this bug took a few hours to find, because the state saved and
9003 restored by PushPosition and PopPosition was ignoring the state of
9004 parse_generic_less_than.
9006 I can also now remove the handling of OP_LT and OP_GT, this solves
9009 * cs-tokenizer.cs: store the location for the ARROW token, we use
9012 (PushPosition, PopPosition): save/restore also `current_token',
9013 restore `parse_generic_less_than' (was missing).
9015 (parse_opt_type_arguments): use parse_type, not
9016 parse_namespace_or_typename to parse types.
9018 * lambda.cs: Empty new file, will eventually have the lambda
9019 expression implementation.
9021 * lambda.test: used to test the internal tokenizer.
9023 * report.cs (FeatureIsNotISO1): Rename from
9024 FeatureIsNotStandardized, because it was about the language level
9025 (1 vs 2) it was not about standarization.
9027 (FeatureRequiresLINQ): New.
9029 * support.cs (SeekableStreamReader): Only require that the reader
9030 is a TextReader, not a StreamReader, so we can plug StringReader.
9032 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
9033 given position in the input stream the following tokens can be
9034 parsed as a type followed by an identifier.
9036 (is_punct): after a '(' if parse_type_and_parameter returns true,
9037 then return a special token OPEN_PARENS_LAMBDA which is used to
9038 avoid reduce/reduce errors in the grammar for the
9039 lambda_expression rules.
9041 (parse_type): implement a type parser inside the
9042 tokenizer, the parser only returns true or false depending on
9043 whether the input at a given position can be parsed as a type.
9045 (peek_token): new method used during type parsing.
9047 2007-01-28 Raja R Harinath <rharinath@novell.com>
9050 * anonymous.cs (ScopeInfo.InflateParameters): New.
9051 (AnonymousContainer.Resolve): Use it to redirect types of
9052 delegate parameters.
9054 2007-01-27 Raja R Harinath <rharinath@novell.com>
9057 * expression.cs (Error_InvalidArguments): Don't use two different
9058 messages for CS1503. Use ExtraInformation and
9059 SymbolRelatedToPreviousError instead.
9062 * decl.cs (DeclSpace.initialize_type_params): Don't access
9063 'type_params' of a partial class directly.
9065 2007-01-26 Miguel de Icaza <miguel@novell.com>
9067 * constant.cs: Removed a handful of out-of-range checks that were
9070 2007-01-25 Marek Safar <marek.safar@gmail.com>
9072 * expression.cs (CheckUselessComparison): Add additional check for char
9075 * namespace.cs: Fixed typo.
9077 2007-01-23 Miguel de Icaza <miguel@novell.com>
9079 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
9080 gone, instead we inline the test, preventing the needless casts to
9081 longs, ulongs and doubles for the parameters, avoiding calls to
9082 methods that overchecked stuff, and instead inlined things
9085 2007-01-20 Marek Safar <marek.safar@gmail.com>
9087 * cs-parser.jay: Better parameter error handling.
9089 2007-01-17 Marek Safar <marek.safar@gmail.com>
9091 A fix for bug #80368, #80522
9092 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
9093 whether array initializer contains constants only.
9094 (ArrayCreation.Emit): Use better formula to decide when
9095 are array initializers for static initialization.
9096 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
9097 have to emit even constants otherwise they are pre-initialized.
9099 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
9100 Raja R Harinath <rharinath@novell.com>
9102 Fix emit order of 'get' vs. 'set'.
9103 * support.cs (Accessors): New.
9104 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
9105 Note the order in which accessors are declared in the source.
9106 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
9107 Refactored from Property.Define and Indexer.Define.
9108 (PropertyBase.DefineAccessors): New helper that calls the above in
9109 appropriate order as noted by the parser.
9110 (Property.Define, Indexer.Define): Update to changes.
9111 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
9113 2007-01-17 Raja R Harinath <rharinath@novell.com>
9115 Fix cs0029-6.cs and gcs0029-2.cs (regression)
9116 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
9117 there's an implicit conversion from the current type to the target
9118 type before converting the underlying constant.
9120 2007-01-16 Marek Safar <marek.safar@gmail.com>
9122 * const.cs (ResolveValue): Updated after constant conversion was made more
9125 * constant.cs (GetAttributableValue): constant to object conversion is
9126 used for attributes only.
9127 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
9128 constant conversions.
9129 (LongConstant.ConvertImplicitly): Ditto.
9131 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
9132 (ImplicitConversionStandard): Handle constant conversion as extra step.
9133 It solves the issue when constant conversion was called indirectly like
9134 inside array initializer and constant folding was skipped.
9136 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
9139 * statement.cs(ImplicitConversionStandard): Updated after constant
9140 conversion was made more generic.
9142 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
9144 * expression.cs (As.DoResolve): Use GenericConstraints instead of
9145 Constraints, solves the problem where the compiler incorrectly
9146 reported that a type parameter was not constrained to a class (Bug
9149 2007-01-14 Marek Habersack <grendello@gmail.com>
9151 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
9153 2007-01-14 Marek Safar <marek.safar@gmail.com>
9155 A fix for bug #80368
9156 * assign.cs (FieldInitializer): New class implements field
9157 initializer statement.
9159 * attribute.cs: Update after FieldMember rename.
9161 * class.cs (PropertyBasedMember): New common class for property based
9163 (InterfaceMemberBase): New base class for all members which can be used as
9164 an interface members.
9165 (MethodCore): Moved really common code to InterfaceMemberBase.
9166 (Method.Define): Equal and GetHasCode detection is relevant for methods
9168 (MethodData.Define): Don't assume that public event implements an
9169 interface automatically.
9170 (MethodData.DefineMethodBuilder): Issue an error even if only extern
9172 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
9173 (FieldMember): Merged with FieldBase.
9174 (EventProperty.AEventPropertyAccessor): New specialization to check whether
9175 event extern modifier can be used.
9176 (EventField.EventFieldAccessor): Moved event field specific code here.
9177 (Event.AllowedModifiers): Even event can be extern.
9178 (Event.FindOutBaseMethod): New override specific to events.
9179 (Indexer.parameters): Reintroduce parameters because base class holds
9180 only properties common data.
9181 (Indexer.CheckForDuplications): Indexers are threated as methods so we
9182 need do extra parameters check.
9184 * const.cs: Update after FieldMember rename.
9186 * decl.cs (MemberCache.FindBaseEvent): New method.
9188 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
9189 to reflect that indexer is now derived from PropertyBased.
9191 * ecore.cs (GetMemberType): Made public.
9192 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
9195 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
9197 * typemanager.cs (CSharpSignature): Correctly print event accessors.
9198 (RegisterEvent): Removed.
9199 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
9200 (GetPrivateFieldOfEvent): Renamed to GetEventField.
9202 2007-01-11 Raja R Harinath <rharinath@novell.com>
9205 * statement.cs (CollectionForeach.TryType): Prefer generic
9206 GetEnumerator over non-generic variant. Fix code to follow comments.
9208 2007-01-09 Raja R Harinath <rharinath@novell.com>
9211 * support.cs (ReflectionParameter): Don't use an invalid index on
9212 the generic parameter data.
9214 2007-01-08 Miguel de Icaza <miguel@novell.com>
9216 * driver.cs: Just add a tiny bit of infrastructure.
9218 2007-01-02 Marek Safar <marek.safar@gmail.com>
9220 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
9221 where field type is struct from current assembly.
9223 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
9226 2007-01-02 Marek Safar <marek.safar@gmail.com>
9228 A fix for bug #80381
9229 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
9232 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
9234 (Namespace.LookupType): Always use core types from corlib when speficied.
9236 * report.cs: A new warning.
9238 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
9239 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
9240 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
9242 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
9243 (InitCoreTypes): Set expression type of object_type and value_type
9244 immediately after lookup.
9246 2007-01-01 Miguel de Icaza <miguel@novell.com>
9248 * cs-tokenizer.cs: Accept Pc class characters (Connector
9249 Punctuation) as valid identifiers. Fixes #78259
9251 * expression.cs (Invocation.DoResolve): Moved the check for the
9252 use of `this' for doing method calls to the Invocation resolution
9253 step, after overload resolution has taken place instead of doing
9254 the check at the low-level `This.DoResolve' level.
9256 The `This.DoResolve'(appens before overload resolution, so it has
9257 no way of knowing if the method that will be called will be
9258 instace or static, triggering an erroneous report for cs0188 (Bug
9261 We now do the check for instance method invocations after we know
9262 what method will be called.
9264 (This.CheckThisUsage): Move the actual use of this structure
9265 checking into its own method and expose it.
9267 * Everywhere that called Error_ValueCannotBeConverted: pass a new
9270 Exceptions: Null.ConvertImplicitly,
9271 Constant.ImplicitConversionRequired as there are too many call
9272 sites for passing the ec.
9274 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
9275 EmitContext, if the value is null, then we do not try to provide
9276 the extra information from the error (If a userdefined conversion
9277 exists, as UserDefinedConversion requires a non null-EmitContext).
9281 2006-12-30 Raja R Harinath <rharinath@novell.com>
9283 * flowanalysis.cs (MyBitVector): Document some invariants.
9284 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
9285 introduced below, and add a couple of others,
9287 2006-12-30 Marek Safar <marek.safar@gmail.com>
9289 * attribute.cs (GetMethodObsoleteAttribute): Uses new
9290 GetPropertyFromAccessor and GetEventFromAccessor.
9292 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
9293 overrides non-obsolete one.
9294 (Indexer.Define): Error message has been moved to the parser.
9296 * cs-parser.jay: Better syntax errors handling.
9298 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9299 when an invocation has no arguments.
9301 * ecore.cs: Removed not used caching.
9303 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9306 * report.cs: Add a new warning.
9308 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9310 * typemanager.cs (enumeration_type): Removed.
9311 (CSharpSignature): Reuses IsSpecialMethod.
9312 (IsEqual): Hack for MS BCL.
9313 (GetPropertyFromAccessor): New method.
9314 (GetEventFromAccessor): New method.
9315 (IsSpecialMethod): Fixed to handle more cases.
9317 2006-12-30 Marek Safar <marek.safar@gmail.com>
9319 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9320 Made white spaces array static.
9322 * ecore.cs (RemoveGenericArity): Optimized.
9324 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9326 (MyBitVector.initialize_vector): Simplified.
9328 2006-12-22 Miguel de Icaza <miguel@novell.com>
9330 * ecore.cs: Am not entirely happy with this hack, but it seems to
9331 address the issue in 80257 (a small test case for
9334 I set the MethodGroupExpr.Type to an internal compiler type
9335 (itself in this case) to force the resolution to take place. Why
9336 it does not take place with a null is beyond me.
9338 2006-12-20 Marek Safar <marek.safar@gmail.com>
9340 A fix for bug #80288
9341 * expression.cs (ResolveOperator): Consider user defined conversion for
9342 logical and operator too.
9343 (EmitBranchable): Optimization for logical and when full constant folding
9344 could not be applied but one operand is constant.
9346 2006-12-19 Marek Safar <marek.safar@gmail.com>
9348 * class.cs (GetClassBases): Write 5 times every day, will never use
9349 FullName for error reporting.
9351 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9353 2006-12-19 Martin Baulig <martin@ximian.com>
9355 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9356 the symbol file info here.
9358 2006-12-18 Marek Safar <marek.safar@gmail.com>
9360 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9361 of `elseif' is taking then following sections are not taking.
9362 Fixes an issue reported on mono mailing list.
9364 2006-12-18 Marek Safar <marek.safar@gmail.com>
9366 A fix for bug #80300
9367 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9368 a caller is not taking.
9370 2006-12-18 Raja R Harinath <rharinath@novell.com>
9372 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9373 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9374 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9375 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9376 * class.cs: Update to changes.
9378 2006-12-17 Marek Safar <marek.safar@gmail.com>
9380 A fix for bug #79934
9381 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9384 * class.cs (ResolveMembers): Register an iterator in current container and
9387 2006-12-16 Raja R Harinath <rharinath@novell.com>
9390 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9391 satisfy a params annotated parameter.
9393 2006-12-16 Marek Safar <marek.safar@gmail.com>
9395 A fix for bug #77014
9396 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9397 paramters correctly and not rely on hacks in Parameters class.
9398 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9400 (Invocation.VerifyArgumentsCompat): Ditto.
9401 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9404 * parameter.cs (HasParams): Don't assume that params is the last one.
9406 * support.cs (ReflectionParameters.ctor): Look for params attribute
9408 (ReflectionParameters.ParameterType): Removed hack when we returned last
9409 parameter for out of range parameters.
9410 (ParameterName, ParameterModifier): Ditto.
9412 2006-12-14 Marek Safar <marek.safar@gmail.com>
9414 A fix for bug #79987
9415 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9416 when assembly is not CLS compliant but type is. I have no idea why is this
9419 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9421 2006-12-13 Miguel de Icaza <miguel@novell.com>
9423 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9424 in struct constructors, they are basically no-ops.
9426 2006-12-12 Marek Safar <marek.safar@gmail.com>
9428 * cs-tokenizer.cs (Position): Save preprocessor status too.
9430 2006-12-12 Marek Safar <marek.safar@gmail.com>
9432 A fix for bug #77794
9433 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9435 2006-12-12 Marek Safar <marek.safar@gmail.com>
9437 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9439 (pp_expr): Report error for an invalid expression.
9440 (handle_preprocessing_directive): Simplified; add more error checking.
9442 2006-12-11 Marek Safar <marek.safar@gmail.com>
9444 A fix for bug #74939
9445 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9446 directives handling.
9448 2006-12-10 Marek Safar <marek.safar@gmail.com>
9450 A fix for bugs #80093, and #75984
9451 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9452 logic, it seems to me as it worked before "by coincidence".
9453 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9454 (cleanup): Enabled endif check.
9456 2006-12-09 Marek Safar <marek.safar@gmail.com>
9458 A fix for bug #80162
9459 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9460 enumerators are never ambiguous.
9462 2006-12-08 Raja R Harinath <rharinath@novell.com>
9465 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9467 2006-12-06 Marek Safar <marek.safar@gmail.com>
9469 A fix for bug #80144
9470 * class.cs (EventProperty.Define): Explicit implementation means
9471 that an even is used.
9473 2006-12-06 Marek Safar <marek.safar@gmail.com>
9475 Fixes the operators implementation (part II)
9477 * cfold.cs (DoConstantNumericPromotions): Renamed to
9478 DoBinaryNumericPromotions and simplified.
9479 (BinaryFold): Couple of conversion fixes; simplified.
9481 * constant.cs, ecore.cs, literal.cs
9482 (ToType): Renamed to ConvertImplicitly.
9483 (Reduce): Renamed to ConvertExplicitly.
9485 * class.cs, convert.cs: Updated.
9487 * expression.cs: TryReduce doesn't throw an exception.
9489 2006-12-01 Marek Safar <marek.safar@gmail.com>
9491 A fix for bug #80108
9492 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9495 2006-11-30 Marek Safar <marek.safar@gmail.com>
9497 Fixes unary operators implementation (part I)
9500 * cfold.cs (Error_CompileTimeOverflow): Made internal
9502 * const.cs (IConstant): Changed to use reference to constant and
9503 not constant itself.
9504 Updated IConstant implementations.
9506 * constant.cs (CreateConstant): New factory method.
9507 Updated IConstant implementation.
9509 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9511 * ecore.cs: Updated to use CreateConstantReference.
9513 * enum.cs: Reflects IConstant changes.
9515 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9517 * literal.cs (NullConstant): Change to be independently usable.
9519 2006-11-29 Martin Baulig <martin@ximian.com>
9521 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9522 we need to emit the scope initializer before calling the base .ctor.
9524 * anonymous.cs: Merged back from the new anonymous methods branch.
9525 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9527 * expression.cs (ParameterReference.DoResolveBase): Create a
9528 "normal" ScopeInfo when capturing parameters rather than using the
9529 root scope; this makes things work with anonymous methods having
9533 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9535 2006-11-22 Marek Safar <marek.safar@gmail.com>
9537 A fix for bug #79987
9538 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9539 check to a base class.
9540 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9541 only when assembly has missing attribute.
9542 * report.cs: Update.
9544 2006-11-21 Marek Safar <marek.safar@gmail.com>
9546 * cs-tokenizer.cs: Merged with gmcs version.
9548 2006-11-20 Marek Safar <marek.safar@gmail.com>
9551 * cs-parser.jay: Better error message when partial keyword is misplaced.
9553 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9555 A fix for bug #79810
9556 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9557 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9558 a RuntimeWrappedException by default.
9560 2006-11-18 Marek Safar <marek.safar@gmail.com>
9562 A fix for bug #79843
9563 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9565 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9567 2006-11-18 Marek Safar <marek.safar@gmail.com>
9569 * driver.cs, namespace.cs: Uses faster IndexOf version.
9571 2006-11-17 Marek Safar <marek.safar@gmail.com>
9573 A fix for bug #79941
9574 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9576 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9577 even if internal name is different.
9578 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9579 (UserDefinedConversion): Simplified as the operators cannot be internal.
9580 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9582 (MethodLookup): Replaced EmitContext with parentType.
9583 * expression.cs: Updated.
9585 2006-11-09 Raja R Harinath <rharinath@novell.com>
9587 * driver.cs (BadAssembly): Handle all the ugliness of
9588 DefineDynamicAssembly.
9590 2006-11-08 Raja R Harinath <rharinath@novell.com>
9592 Address parts of #58244 -- most of what's left is in the runtime
9593 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9594 CS1509 error checks, and handle them for all assembly loads, not
9595 just the first invocation.
9596 (LoadModule): Likewise. Move handling of 'adder_method' ...
9597 * codegen.cs (AssemblyClass.AddModule): ... here.
9599 2006-11-02 Marek Safar <marek.safar@gmail.com>
9601 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9602 IEnumerable<T> is ambiguous.
9604 2006-10-31 Marek Safar <marek.safar@gmail.com>
9606 A fix for bug #67689
9607 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9608 GetEnumerator is ambiguous.
9610 * report.cs: Add new warning.
9612 2006-10-29 Marek Safar <marek.safar@gmail.com>
9614 A fix for bug #78602
9615 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9616 to protected member can be nested type.
9618 2006-10-28 Marek Safar <marek.safar@gmail.com>
9620 A fix for bug #78965
9621 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9622 to protected member must derive from current type.
9624 2006-10-27 Marek Safar <marek.safar@gmail.com>
9626 assign.cs: Reuses error method.
9628 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9629 instead of type for constants.
9630 (Expression.Error_ValueAssignment): Common error method.
9632 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9635 2006-10-27 Marek Safar <marek.safar@gmail.com>
9637 A fix for bug #79081
9638 * expression.cs (MemberAccess.DoResolve): Check nested type
9641 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9643 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9645 2006-10-26 Marek Safar <marek.safar@gmail.com>
9647 A fix for bug #76591
9648 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9650 2006-10-26 Marek Safar <marek.safar@gmail.com>
9652 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9653 type forwarder of the same type multiple times.
9655 2006-10-26 Raja R Harinath <rharinath@novell.com>
9658 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9659 instance as an rvalue, even when we later resolve as an lvalue.
9661 2006-10-25 Martin Baulig <martin@ximian.com>
9663 * anonymous.cs: Fix #79673.
9665 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9667 A fix for bug #79666
9668 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9669 ignored when is optimized (= default value) as its value is already set.
9671 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9673 A fix for bug #79724
9674 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9675 TypeContainer for type lookup.
9677 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9679 A fix for bug #79231
9680 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9681 * expression.cs (OverloadResolve): Always convert type name for
9683 (ResolveNamespaceOrType): Don't confuse a nested type with any
9686 2006-10-18 Martin Baulig <martin@ximian.com>
9688 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9690 2006-10-17 Miguel de Icaza <miguel@novell.com>
9692 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9693 an int32, but requesting an int64 from the conversion
9695 2006-10-12 Martin Baulig <martin@ximian.com>
9698 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9700 2006-10-12 Martin Baulig <martin@ximian.com>
9703 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9705 2006-10-11 Miguel de Icaza <miguel@novell.com>
9707 * convert.cs: Remove broken code: I was doing the "Existance"
9708 tests for Implicit conversions.
9710 2006-10-10 Miguel de Icaza <miguel@novell.com>
9712 * convert.cs: Added one missing case in
9713 ImplicitStandardConversionExists uint64 to intptr.
9717 * typemanager.cs (uintptr_type): another core known type.
9719 * ecore.cs (OperatorCast): routine used to do cast operations that
9720 depend on op_Explicit. We could change some of the Decimal
9721 conversions to use this.
9723 This one has a probe mechanism that checks both types for an op_
9724 which it coudl be used to eliminate two classes: CastToDecimal
9725 and CastFromDecimal.
9727 * convert.cs: Implement the conversions documented in #59800
9729 2006-10-10 Martin Baulig <martin@ximian.com>
9731 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9732 before RootScope.ResolveMembers().
9734 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9735 `CurrentType' if appropriate.
9737 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9739 A fix for bug #78568
9740 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9741 when contains binary operators.
9742 * cs-parser.jay: Updated.
9744 2006-10-09 Martin Baulig <martin@ximian.com>
9747 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9748 moved that into Define() and also do the other type parameter
9749 checks there. Fixes #79094. Added gtest-292.cs.
9752 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9753 since that doesn't include type parameters; don't use `Ldelema'
9754 for type parameters. Fixes #78980. Added gtest-293.cs.
9756 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9759 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9760 conversion is allowed.
9762 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9764 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9765 error reporting when no error occurs.
9767 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9769 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9772 2006-10-06 Raja R Harinath <rharinath@novell.com>
9775 * class.cs (DefineTypeBuilder): Check circular dependencies before
9776 setting the parent of the TypeBuilder.
9777 (CheckRecursiveDefinition): Don't use 'BaseType', since
9778 it may not be valid until after DefineTypeBuilder. Use
9779 'base_type' instead.
9781 2006-10-04 Martin Baulig <martin@ximian.com>
9783 Merged the Anonymous Methods patch.
9785 * anonymous.cs, iterators.cs: The new anonymous methods code.
9787 * statement.cs (Variable): New public abstract class.
9788 (LocalInfo.Variable): New public property.
9789 (LocalInfo.ResolveVariable): New public method.
9790 (Block.Flags): Add `IsIterator'.
9791 (Block.AddVariable): Improved the CS0136 check.
9792 (Block.AnonymousChildren): New public property.
9793 (Block.AddAnonymousChild): New public method.
9794 (ToplevelBlock): Update to use the new anonymous method framework.
9795 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9796 `ToplevelBlock'; this is required to correctly implement the
9798 (Fixed, Using): Use `TemporaryVariable' instead of directly
9799 creating the `LocalBuilder'.
9801 * parameter.cs (Parameter.ResolveVariable): New public method.
9802 (Parameters.ResolveVariable): Likewise.
9804 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9806 * class.cs (TypeContainer): Replaced the `iterators' list and
9807 corresponding methods with a list of `CompilerGeneratedClass'es.
9808 (TypeContainer.ResolveMembers): New public method.
9809 (Method): `IIteratorContainer' has been replaced by
9812 * expression.cs (VariableReference): New public abstract base
9813 class for `LocalVariableReference', `ParameterReference' and
9816 * codegen.cs (EmitContext): Removed `capture_context',
9817 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9818 (EmitContext.EmitThis): Removed.
9820 * cs-parser.jay: Replace `iterator_container' with
9823 2006-10-04 Martin Baulig <martin@ximian.com>
9825 * generic.cs (GenericMethod): Don't make this abstract.
9826 (Constraints.Clone): Added dummy implementation.
9828 2006-10-04 Raja R Harinath <harinath@gmail.com>
9831 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9832 'declspaces'. Avoid allocating arrays willy-nilly.
9835 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9836 cases out of the switch.
9838 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9840 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9841 message when non-generic type is used with the type arguments.
9842 * expression.cs: Updated.
9844 2006-09-28 Raja R Harinath <rharinath@novell.com>
9847 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9848 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9849 Change semantics slightly. Don't insist on having only one
9850 temporary EmptyExpression -- just throttle the creation of new ones.
9853 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9854 non-interfaces too. If no methods are found, don't try to create
9857 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9859 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9862 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9863 us produce better error message.
9865 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9867 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9868 of the `|' operator.
9870 * report.cs: A new warning added.
9872 2006-09-27 Martin Baulig <martin@ximian.com>
9874 * generic.cs (GenericMethod): Don't make this abstract.
9876 2006-09-27 Martin Baulig <martin@ximian.com>
9879 (InternalErrorException): Added overloaded ctor taking a params array.
9881 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9883 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9884 Fixed the cases when same error was reported twice.
9886 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9887 now report symbol information.
9889 2006-09-25 Martin Baulig <martin@ximian.com>
9891 * class.cs: Completely unified with the gmcs version.
9893 2006-09-25 Martin Baulig <martin@ximian.com>
9895 * typemanager.cs (TypeManager.IsNullableType): New public function.
9896 (TypeManager.IsNullableTypeOf): Likewise.
9897 (TypeManager.IsNullableValueType): Likewise.
9899 * class.cs (MethodCore): Added the `GenericMethod' argument from
9900 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9902 2006-09-24 Raja R Harinath <harinath@gmail.com>
9904 * convert.cs: Unify with gmcs version.
9906 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9908 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9909 verify them as well.
9911 * report.cs: New warning.
9913 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9915 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9916 for anonymous block with out argument.
9918 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9920 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9921 not used private events only.
9923 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9925 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9927 * const.cs (Const.Define): Check for constant type.
9928 (Const.IsConstantTypeValid): Looks for valid constant types.
9930 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9932 * ecore.cs (EmptyConstantCast): New common class for all constant based
9935 * expression.cs (Is.DoResolve): Handle null constant especially.
9936 (New.DoResolve): Check for new void().
9937 (MemberAccess.DoResolve): Cope with all kind of nulls.
9939 * literal.cs (NullConstant): Uses EmptyConstantCast.
9940 (NullDefault): Based on EmptyConstantCast.
9941 (NullLiteral): Uses EmptyConstantCast.
9943 * statement.cs (Block.ResolveMeta): Check for constant type.
9945 2006-09-22 Martin Baulig <martin@ximian.com>
9947 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9949 2006-09-22 Raja R Harinath <rharinath@novell.com>
9951 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9955 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9956 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9959 2006-09-22 Martin Baulig <martin@ximian.com>
9961 * ecore.cs: Merged with the gmcs version.
9963 * generic.cs (ConstructedType): New dummy class.
9964 (TypeArguments): Don't make this abstract.
9967 (TypeManager.IsGenericTypeDefinition): New method.
9968 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9970 2006-09-22 Raja R Harinath <rharinath@novell.com>
9972 * expression.cs (ComposedCast): Check for arrays of TypedReference
9973 before creating the type, not after.
9975 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9977 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9978 after ToType change.
9980 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9981 when constant must be implicitly convertible.
9983 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9985 * ecore.cs (NullCast): Derives from NullConstant.
9987 * expression.cs (Is.DoResolve): Removed useless variables.
9988 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9989 (New.Constantify): Add enum support.
9990 (MemberAccess.DoResolve): Add warning when accessing null constant or
9993 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9996 * literal.cs (NullConstant): New abstract class with common
9997 functionality for all null specializations.
9998 (NullDefault): Represents default(X) when result can be
10000 (NullLiteral): Updated.
10002 * report.cs: Add new warning.
10004 2006-09-21 Martin Baulig <martin@ximian.com>
10006 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
10008 2006-09-21 Martin Baulig <martin@ximian.com>
10010 * generic.cs (GenericConstraints): New dummy class.
10011 (Constraints): Likewise.
10012 (TypeParameter): Likewise.
10013 (TypeParameterName): Likewise.
10014 (GenericMethod): Likewise.
10016 * typemanager.cs (TypeManager.GetGenericArguments): New method.
10018 * decl.cs: Merged with the gmcs version.
10020 2006-09-21 Raja R Harinath <rharinath@novell.com>
10022 * generic.cs (TypeParameter): Implement IMemberContainer.
10023 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
10025 * rootcontext.cs: Unify with gmcs version.
10027 * report.cs: Unify with gmcs version.
10028 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
10029 from gmcs/generics.cs.
10030 * generics.cs (TypeParameter): New dummy class.
10032 * support.cs: Unify with gmcs version.
10034 2006-09-20 Raja R Harinath <rharinath@novell.com>
10036 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
10037 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
10039 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
10040 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
10041 * mcs.exe.sources: Add generic.cs.
10043 * codegen.cs: Unify with gmcs version.
10045 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
10046 (EmitContext): Add GenericDeclContainer implementation.
10047 * decl.cs (MemberCore, DeclSpace): Likewise.
10048 * namespace.cs: Remove #ifdef GMCS_SOURCE.
10050 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
10051 MCS TypeManager has a corresponding dummy method.
10053 2006-09-19 Martin Baulig <martin@ximian.com>
10055 * expression.cs: Completely merged with the gmcs version.
10057 2006-09-19 Martin Baulig <martin@ximian.com>
10059 * expression.cs (Invocation): Merged with the gmcs version.
10060 (ArrayAccess.GetStoreOpcode): Likewise.
10062 2006-09-19 Martin Baulig <martin@ximian.com>
10065 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
10066 (TypeManager.IsGenericMethodDefinition): Likewise.
10068 2006-09-19 Martin Baulig <martin@ximian.com>
10071 (TypeManager.IsEqual): Moved the gmcs implementation here.
10072 (TypeManager.DropGenericTypeArguments): Likewise.
10073 (TypeManager.DropGenericMethodArguments): Likewise.
10074 (TypeManager.GetTypeArguments): Moved here from gmcs.
10075 (TypeManager.HasGenericArguments): Likewise.
10077 2006-09-19 Martin Baulig <martin@ximian.com>
10079 * expression.cs (Binary): Merged with the gmcs version.
10081 2006-09-19 Martin Baulig <martin@ximian.com>
10083 * expression.cs (Probe, As, Is): Merged with the gmcs version.
10085 2006-09-19 Martin Baulig <martin@ximian.com>
10087 * typemanager.cs: Merged with the gmcs version.
10089 2006-09-16 Raja R Harinath <rharinath@novell.com>
10091 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
10092 * driver.cs: Likewise.
10094 2006-09-16 Marek Safar <marek.safar@seznam.cz>
10097 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
10098 only if parent type is class.
10099 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
10102 2006-09-15 Marek Safar <marek.safar@seznam.cz>
10105 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
10107 * typemanager.cs(CSharpName): Converts NullType to null.
10109 2006-09-15 Martin Baulig <martin@ximian.com>
10112 (TypeManager.GetMethodName): Added mcs implementation.
10113 (TypeManager.IsEqual): Likewise.
10116 (SimpleName.RemoveGenericArity): Added dummy implementation.
10118 * pending.cs: Merged with the gmcs version.
10120 2006-09-15 Martin Baulig <martin@ximian.com>
10122 * statement.cs: Merge with the gmcs version.
10124 2006-09-15 Martin Baulig <martin@ximian.com>
10126 * statement.cs (Switch): Merge with the gmcs implementation
10127 (without nullables), which is newer.
10129 2006-09-15 Martin Baulig <martin@ximian.com>
10131 * statement.cs (Block.Variables): Make this public.
10132 (ToplevelBlock.Parameters): Make this a property.
10133 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
10135 2006-09-15 Martin Baulig <martin@ximian.com>
10137 * namespace.cs: Merge with the gmcs version.
10139 2006-09-15 Martin Baulig <martin@ximian.com>
10141 * decl.cs (MemberName): Minor code cleanups.
10143 2006-09-15 Martin Baulig <martin@ximian.com>
10145 * parameter.cs: Merge with the gmcs version.
10147 2006-09-15 Martin Baulig <martin@ximian.com>
10149 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
10150 and an error in mcs.
10152 2006-09-15 Martin Baulig <martin@ximian.com>
10154 * flowanalysis.cs: Merged from GMCS; added the generics code into
10155 a `GMCS_SOURCE' conditional so we can share this file.
10157 2006-09-08 Martin Baulig <martin@ximian.com>
10159 * typemanager.cs (TypeManager.interlocked_type): New public field.
10160 (TypeManager.int_interlocked_compare-exchange): New public field.
10161 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
10162 enumerator types here and call InitGenericCoreTypes().
10163 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
10164 after calling InitEnumUnderlyingTypes().
10167 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
10168 `classes_second_stage'.
10170 2006-09-14 Marek Safar <marek.safar@seznam.cz>
10172 * assign.cs, ecore.cs, expression.cs: Share error message text.
10173 * class.cs (FieldMember.Define): Check for varible of static type.
10174 * driver.cs (LoadAssembly): Uses error output for errors.
10175 * statement.cs: Updated.
10177 2006-09-08 Marek Safar <marek.safar@seznam.cz>
10179 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
10182 2006-09-07 Martin Baulig <martin@ximian.com>
10185 (MainDriver): Revert r62663 from Marek; see #70506 for details.
10187 2006-08-29 Miguel de Icaza <miguel@novell.com>
10189 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
10191 2006-08-17 Miguel de Icaza <miguel@novell.com>
10193 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
10194 #52019 and #79064, the use of the \uXXXX sequence in source code
10195 to represent unicode characters.
10197 2006-08-15 Marek Safar <marek.safar@seznam.cz>
10199 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
10201 * class.cs, ecore.cs, statement.cs: Merged to one error message.
10203 2006-08-13 Miguel de Icaza <miguel@novell.com>
10205 * assign.cs: Catch attempts to assign to a method groups in += and
10208 2006-08-13 Marek Safar <marek.safar@seznam.cz>
10211 * cs-parser.jay: Don't destroy current array type by typeof of array's.
10213 2006-08-12 Marek Safar <marek.safar@seznam.cz>
10215 * class.cs (Method.Define): Issue a warning when generic method looks like
10217 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
10220 2006-08-09 Marek Safar <marek.safar@seznam.cz>
10222 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
10224 * decl.cs (MemberCache.FindMembers): When container is interface we need to
10225 search all base interfaces as a member can be ambiguous.
10226 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
10227 Constructor member type filter.
10228 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
10229 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
10230 reporting for returned memberinfos.
10231 * report.cs: Updated.
10232 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
10233 version to work on all runtimes.
10234 (TypeManager.RealMemberLookup): Removed members filtering.
10236 2006-08-08 Raja R Harinath <rharinath@novell.com>
10238 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
10239 (PropertyExpr.EmitAssign): Likewise.
10240 * expression.cs (Indirection.EmitAssign): Likewise.
10241 (LocalVariableReference.EmitAssign): Likewise.
10242 (ParameterReference.EmitAssign): Likewise.
10243 (Invocation.EmitArguments): Likewise.
10244 (ArrayAccess.EmitAssign): Likewise.
10245 (IndexerAccess.EmitAssign): Likewise.
10246 (This.EmitAssign): Likewise.
10247 (ConditionalLogicalOperator.Emit): Likewise.
10250 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
10251 instead of ArrayList. If the hashtable has a LocalBuilder, don't
10252 leave it in after returning it.
10253 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
10255 2006-08-06 Marek Safar <marek.safar@seznam.cz>
10257 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
10260 2006-08-03 Raja R Harinath <rharinath@novell.com>
10262 Fix cs0146-3.cs and cs0146-4.cs.
10263 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
10264 enclosing types don't depend on the current type.
10266 2006-08-02 Raja R Harinath <rharinath@novell.com>
10269 * class.cs (TypeContainer.DoDefineMembers): Use
10270 FindBaseMemberWithSameName on Parent, since we're interested in
10271 whether we hide inherited members or not.
10272 (FindBaseMemberWithSameName): Make slightly more robust.
10274 Fix the non-generic testcase from #77396
10275 * decl.cs (DeclSpace.DeclContainer): Remove override.
10277 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
10278 declspaces for doppelgangers too.
10279 (UsingEntry): Implement IResolveContext.
10280 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
10281 'this' as the resolve context.
10282 (LocalAliasEntry): Likewise.
10284 Implement parts of #77403
10285 * roottypes.cs (RootDeclSpace): New. Used to represent the
10286 toplevel declaration space. Each namespace declaration introduces
10287 a "partial" root declaretion space.
10288 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
10289 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
10290 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
10291 from 'current_namespace.SlaveDeclSpace'.
10292 (namespace_declaration): Likewise.
10293 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10294 check. It can't happen now.
10295 * decl.cs (DeclSpace.LookupType): Likewise.
10296 * driver.cs (MainDriver): Sanity check.
10298 2006-08-01 Raja R Harinath <rharinath@novell.com>
10300 * decl.cs (DeclSpace.FindNestedType): Remove.
10301 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10302 LookupTypeContainer to get the container of the nested type.
10303 * class.cs (TypeContainer.FindNestedType): Make non-override.
10305 2006-07-31 Raja R Harinath <rharinath@novell.com>
10307 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10308 * class.cs (TypeContainer.PartialContainer): ... here.
10309 (TypeContainer.AddBasesForPart): New helper.
10310 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10312 * cs-parser.jay (current_class): Convert to DeclSpace.
10313 (struct_declaration, interface_declaration, class_declaration):
10314 Use AddBasesForPart instead of .Bases directly.
10315 * const.cs, iterators.cs: Update to changes.
10317 2006-07-28 Raja R Harinath <rharinath@novell.com>
10319 * class.cs (TypeContainer.AddMemberType): Rename from
10320 AddToTypeContainer.
10321 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10322 (AddTypeContainer): New. Combine AddClassOrStruct and
10324 (AddPartial): Update. Add 'is_partial' argument.
10325 * roottypes.cs: Update to changes.
10326 * cs-parser.jay (push_current_class): New helper for handling
10327 current_container and current_class.
10328 (struct_declaration, interface_declaration, class_declaration):
10331 2006-07-26 Raja R Harinath <rharinath@novell.com>
10333 * roottypes.cs: Rename from tree.cs.
10335 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10336 * tree.cs (Tree, ITreeDump): Remove types.
10337 * rootcontext.cs (tree, Tree): Remove fields.
10338 (root, ToplevelTypes): New.
10339 * *.cs: Update to rename.
10341 * tree.cs (Tree.RecordDecl): Remove.
10342 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10344 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10346 2006-07-23 Raja R Harinath <harinath@gmail.com>
10348 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10349 DoFlowAnalysis and OmitStructFlowAnalysis here.
10350 (ec.With): Rename from WithUnsafe and generalize.
10351 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10352 (ec.WithFlowAnalyis): New.
10353 * ecore.cs, expression.cs, statement.cs: Update.
10355 2006-07-22 Raja R Harinath <harinath@gmail.com>
10357 * statement.cs (Block.ResolveMeta): Simplify slightly.
10359 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10360 multiple boolean fields. Convert InUnsafe, constant_check_state,
10361 check_state to flags.
10362 (CheckState, ConstantCheckState): Update.
10363 (InUnsafe): New read-only property.
10364 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10366 (WithUnsafe): New helper similar to WithCheckState.
10367 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10368 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10370 2006-07-21 Raja R Harinath <rharinath@novell.com>
10372 Make comparisons use the same IL irrespective of whether they're
10373 in a 'checked' or 'unchecked' context: one of the issues in #78899
10374 * codegen.cs (EmitContext.CheckState): Make read-only property.
10375 (EmitContext.ConstantCheckState): Likewise.
10376 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10377 helper that implement a save/restore stack for CheckState
10378 values. This is the only way to change check-state.
10379 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10380 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10381 (CheckedExpr.EmitBranchable): New forwarding method.
10382 (UnCheckedExpr): Likewise.
10383 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10384 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10385 (Checked.Resolve, checked.DoEmit): Likewise.
10387 2006-07-20 Miguel de Icaza <miguel@novell.com>
10389 * anonymous.cs: Cache the resolved anonymous delegate, and return
10390 this so that the ResolveTopBlock is only triggered once, not
10393 Currently we trigger ResolvetopBlock twice due to a first pass of
10394 argument check compatibility, and a second pass that does the
10397 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10399 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10401 * rootcontext.cs (Reset): Add helper_classes.
10403 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10406 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10409 2006-07-13 Miguel de Icaza <miguel@novell.com>
10411 * statement.cs (Lock): Handle expressions of type
10412 TypeManager.null_type specially. Fixes #78770
10414 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10416 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10419 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10421 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10422 for accessors as well.
10423 * ecore.cs (EventExpr): Add AccessorTable.
10425 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10428 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10429 for CS0122 where appropriate.
10430 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10432 (Filter): Assembly can be null in the case of top level attributes.
10434 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10438 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10439 is done at global level.
10441 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10443 A fix for #77002, Implemented TypeForwarder support.
10445 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10446 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10447 * typemanager.cs (): Add type_forwarder_attr_type.
10449 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10451 * report.cs: Add CS0469 warning.
10453 2006-06-21 Martin Baulig <martin@ximian.com>
10455 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10456 the `try'-block, so we also report CS0016 etc. there.
10458 2006-06-21 Martin Baulig <martin@ximian.com>
10461 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10463 2006-06-21 Martin Baulig <martin@ximian.com>
10465 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10466 also report CS1686 for parameters.
10468 2006-06-21 Martin Baulig <martin@ximian.com>
10470 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10471 instead of an error if the value is not implicitly convertible to
10472 the switch types; fixes #77964.
10474 2006-06-21 Raja R Harinath <rharinath@novell.com>
10477 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10478 FieldBuilder is null.
10481 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10482 'left' and 'right' before error-checking.
10484 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10486 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10488 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10489 (FieldExpr.DoResolve): likewise.
10490 (PropertyExpr.InstanceResolve): likewise.
10491 (EventExpr.InstanceResolve): likewise.
10493 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10495 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10496 attribute applicable tests for attribute argument.
10498 2006-06-02 Raja R Harinath <rharinath@novell.com>
10501 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10502 (Binary.OverloadResolve_PredefinedIntegral): New.
10503 (Binary.OverloadResolve_PredefinedFloating): New.
10504 (Binary.OverloadResolve_PredefinedString): New.
10505 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10506 Follow the standard more closely, and treat numeric promotions in
10507 terms of overload resolution.
10508 (Binary.CheckShiftArguments): Simplify.
10510 2006-06-01 Raja R Harinath <rharinath@novell.com>
10512 * flowanalysis.cs (MyBitVector): Simplify representation.
10513 (MyBitVector.Clone): Avoid allocating BitArray.
10514 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10515 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10516 (*): Update. Change all references to MyBitVector.And and
10517 MyBitVector.Or to &= and |=.
10519 2006-05-29 Raja R Harinath <rharinath@novell.com>
10521 Fix cs0231-[34].cs.
10522 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10523 to param arguments too.
10525 2006-05-26 Miguel de Icaza <miguel@novell.com>
10527 * cs-parser.jay: Catch another parsing form for arglist being
10528 followed by other arguments. Fixes #78313.
10530 2006-05-24 Raja R Harinath <rharinath@novell.com>
10532 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10533 checking of out parameters to ...
10534 (FlowBranchingToplevel.Merge): ... here.
10535 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10536 set, propagate the origin upward, and only complain if there was
10538 (FlowBranchingException.AddContinueOrigin): Likewise.
10539 (FlowBranchingException.AddReturnOrigin): Likewise.
10540 (FlowBranchingException.AddGotoOrigin): Likewise.
10542 2006-05-23 Raja R Harinath <rharinath@novell.com>
10544 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10545 unreachable, skip it.
10546 (FlowBranchingException.Merge): Always propagate jumps, even if
10547 the finally block renders subsequent code unreachable.
10549 2006-05-18 Raja R Harinath <rharinath@novell.com>
10552 * statement.cs (Goto.Resolve): Move responsibility for resolving
10553 'goto' to FlowBranching.AddGotoOrigin.
10554 (Goto.SetResolvedTarget): New. Callback to set the
10555 LabeledStatement that's the target of the goto.
10556 (Goto.DoEmit): Use Leave instead of Br when crossing an
10557 unwind-protect boundary.
10558 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10559 LookupLabel and adjust to new semantics.
10560 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10561 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10562 Goto.SetResolvedTarget to update target.
10563 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10564 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10565 AddBreakOrigin & co. Delay propagation until ...
10566 (FlowBranchingException.Merge): ... this.
10568 * statement.cs (Block.Resolve): Always depend on flow-branching to
10569 determine unreachability. Kill workaround that originally emitted
10570 only one statement after an "unreachable" label (see infloop in
10573 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10574 This is still "wrong", but anything better would probably need a
10575 multi-pass algorithm.
10576 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10577 usage vector. Force current usage vector to be reachable, to
10578 optimistically signify backward jumps.
10579 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10581 (FlowBranchingLabeled.Merge): New. If no backward jump was
10582 detected, return the original salted-away usage vector instead,
10583 updated with appropriate changes. Print unreachable warning if
10585 * statement.cs (Block.Resolve): Don't print unreachable warning on
10586 a labeled statement.
10588 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10590 * driver.cs: Pass filename without path to AssemblyBuilder's
10591 AddResourceFile. Fixes bug #78407.
10593 2006-05-17 Raja R Harinath <rharinath@novell.com>
10595 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10596 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10597 (FlowBranching.MergeChild): Overwrite
10598 reachability information from Labeled branchings too.
10600 2006-05-16 Raja R Harinath <rharinath@novell.com>
10602 * statement.cs (Goto.Resolve): Merge jump origins here ...
10603 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10605 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10606 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10607 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10608 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10610 * statement.cs (Goto.Resolve): ... not here.
10611 (Goto.Emit): Remove CS1632 check.
10613 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10615 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10618 2006-05-11 Raja R Harinath <rharinath@novell.com>
10620 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10621 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10622 (FlowBranchingException.Label): Likewise.
10624 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10626 (MyBitVector.Or): Use it to avoid losing information (Count).
10627 (FlowBranching.MergeOrigins): Likewise.
10629 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10630 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10631 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10632 (UsageVector.ToString): Simplify.
10633 (UsageVector.MergeSiblings): Move here from ...
10634 (FlowBranching.Merge): ... here.
10635 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10638 2006-05-10 Raja R Harinath <rharinath@novell.com>
10640 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10641 null bitvector is treated as all-true.
10643 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10644 (MyBitVector): Rationalize invariants. 'vector != null' implies
10645 that we have our own copy of the bitvector. Otherwise,
10646 'InheritsFrom == null' implies all inherited bits are true.
10648 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10650 * statement.cs (LocalInfo): Add IsConstant.
10651 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10652 local variable for constants.
10654 2006-05-09 Raja R Harinath <rharinath@novell.com>
10656 * flowanalysis.cs (MyBitVector.Empty): New.
10657 (MyBitVector): Don't allow InheritedFrom to be null.
10658 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10659 (UsageVector, FlowBranching): Update to changes.
10661 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10662 recursion. The 'Parent == null' condition isn't sufficient for
10664 (FlowBranching.AddBreakOrigin): Likewise.
10665 (FlowBranching.AddContinueOrigin): Likewise.
10666 (FlowBranching.AddReturnOrigin): Likewise.
10667 (FlowBranching.StealFinallyClauses): Likewise.
10668 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10669 (FlowBranching.CheckOutParameters): Likewise.
10670 (FlowBranchingToplevel): Terminate all the above recursions here.
10671 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10672 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10674 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10676 (FlowBranchingToplevel): New. Empty for now.
10677 (FlowBranching.MergeTopBlock): Update.
10678 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10679 branching for the anonymous delegate.
10680 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10682 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10683 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10684 information at the start of the merge. Reorganize.
10686 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10688 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10690 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10692 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10693 to newly introduced ctor.
10695 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10696 message to one place.
10697 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10700 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10702 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10704 * ecore.cs (Expression.ResolveAsConstant): Updated.
10706 * statement.cs (ResolveMeta): Updated.
10708 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10710 * cs-parser.jay: __arglist cannot be used in initializer.
10712 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10715 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10718 2006-05-05 Raja R Harinath <rharinath@novell.com>
10720 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10721 (LabeledStatement): Add 'name' parameter.
10722 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10723 (Block.AddLabel): Update to changes.
10724 * cs-parser.jay (labeled_statement): Likewise.
10726 * flowanalysis.cs (BranchingType.Labeled): New.
10727 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10728 (FlowBranchingLabeled): New. Does nothing for now, but will
10729 eventually handle 'goto' flows.
10730 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10731 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10732 that's terminated ...
10733 (Block.Resolve): ... here.
10735 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10736 (UsageVector.MergeFinallyOrigins): Likewise.
10737 (FlowBranching.InTryOrCatch): Likewise.
10738 (FlowBranching.AddFinallyVector): Likewise.
10739 (FlowBranchingException): Update to changes.
10742 * statement.cs (Return.Resolve): Move error checking to ...
10743 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10744 (FlowBranchingException): Handle return origins like break and
10746 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10748 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10751 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10754 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10757 * class.cs (MethodData.Define): Do public accessor check only when method
10758 implements an interface.
10760 2006-05-04 Raja R Harinath <rharinath@novell.com>
10762 Remove special handling of 'break'
10763 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10764 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10765 (UsageVector.Break): Remove.
10766 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10768 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10770 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10771 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10773 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10776 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10777 be the interface member.
10779 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10782 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10783 for emitting small (int) values.
10785 2006-05-03 Raja R Harinath <rharinath@novell.com>
10788 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10789 control-flow passes through the 'finally' after merging-in all the
10790 control-flows from 'try' and the 'catch' clauses.
10792 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10793 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10794 always true at the only non-recursive entry point.
10795 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10796 FlowBranchingBreakable.
10797 (FlowBranchingLoop): Remove.
10798 * statement.cs (Return.DoResolve): Update to changes.
10801 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10802 (FlowBranching.CreateBranching): Handle it: create a
10803 FlowBranchingContinuable.
10804 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10805 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10806 except that it handles the 'continue' command.
10807 (FlowBranching.UsageVector.MergeOrigins): Rename from
10809 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10810 except that it overrides AddContinueOrigin.
10811 (FlowBranchingException): Override AddContinueOrigin, similar to
10813 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10814 Create a new branching around the embedded statement.
10815 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10816 control flow after the embedded statement.
10817 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10819 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10820 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10821 FlowBranchingBreakable.
10822 (FlowBranchingSwitch): Remove.
10825 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10826 error reporting to ...
10827 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10828 Rename from 'AddBreakVector'. Add new location argument. Return
10829 a bool indicating whether the 'break' crosses an unwind-protect.
10830 (FlowBranchingException.AddBreakOrigin): Add.
10831 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10832 flowbranching after updating with the effects of the 'finally'
10834 (FlowBranchingBreakable): New common base class for
10835 FlowBranchingLoop and FlowBranchingSwitch.
10837 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10838 embedded statement.
10839 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10841 2006-05-02 Raja R Harinath <rharinath@novell.com>
10843 * statement.cs (Do.Resolve): If the loop is infinite, set the
10845 (While.Resolve, For.Resolve): Set a barrier after the embedded
10846 statement. There's no direct control flow that goes from the end
10847 of the embedded statement to the end of the loop.
10848 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10849 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10850 above ensure that the reachability is correctly computed.
10852 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10853 (UsageVector.MergeBreakOrigins): If the current path is
10854 unreachable, treat it as if all parameters/locals are initialized.
10855 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10856 infinite loops before merging-in break origins.
10858 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10859 (Reachability.Reachable): Split part into ...
10860 (Reachability.Unreachable): ... this. Simplify.
10861 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10863 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10864 (Reachability.SetThrowsSometimes): Likewise.
10865 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10866 TriState.Always, use corresponding property.
10867 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10868 (Block.Resolve): Likewise. Remove some redundant checks.
10870 2006-05-02 Raja R Harinath <harinath@gmail.com>
10872 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10873 (Reachability.Meet): Don't bother checking AlwaysThrows --
10874 barrier is always set.
10875 (FlowBranchingBlock.Merge): Likewise.
10877 2006-05-01 Raja R Harinath <harinath@gmail.com>
10879 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10880 checks for unreachable.
10882 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10885 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10887 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10888 whether field is really assigned.
10890 2006-04-30 Raja R Harinath <harinath@gmail.com>
10892 * flowanalysis.cs (Reachability): Make 4-argument constructor
10894 (Reachability.Meet): Rename from 'And'. Remove static variant.
10895 (Reachability.Always): Rename from the highly misleading
10896 'Reachability.Never'.
10897 (FlowBranching.Merge): Update to changes. Mark an impossible
10898 situation with a 'throw'.
10899 (*): Update to changes.
10901 2006-04-29 Raja R Harinath <harinath@gmail.com>
10903 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10904 Remove 'Undefined'.
10905 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10906 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10907 (*): Update to changes.
10908 * statement.cs: Update to changes.
10910 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10913 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10915 2006-04-28 Raja R Harinath <harinath@gmail.com>
10917 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10920 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10921 argument to two arguments: an usage-vector and a bool. Move call
10922 to FlowBranching.Merge () ...
10923 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10925 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10926 handling of loop and switch reachability to ...
10927 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10929 2006-04-27 Raja R Harinath <harinath@gmail.com>
10931 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10932 handling to FlowBranchingLoop.InLoop.
10933 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10935 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10938 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10939 anonymous method is allowed from AnonymousContainer here.
10941 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10943 2006-04-24 Raja R Harinath <rharinath@novell.com>
10946 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10948 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10951 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10952 (DoubleConstant.Reduce): Ditto.
10954 2006-04-23 Raja R Harinath <rharinath@novell.com>
10956 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10957 Remove 'lvalue_right_side' argument. Move parts to ...
10958 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10959 (LocalVariable.DoResolveLValue): ... these.
10961 2006-04-21 Raja R Harinath <rharinath@novell.com>
10964 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10965 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10966 (LocalVariableReference.DoResolveBase): Use it to implement new
10968 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10969 (Argument.Resolve): Simplify. Move CS1510 check ...
10970 * ecore.cs (Expression.ResolveLValue): ... here.
10971 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10972 (PropertyExpr.DoResolveLValue): Likewise.
10973 (FieldExpr.Report_AssignToReadonly): Likewise.
10974 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10975 LValueMemberAccess or LValueMemberOutAccess on instance depending
10977 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10978 DoResolve as appropriate.
10980 2006-04-20 Raja R Harinath <rharinath@novell.com>
10983 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10984 implicit conversions on 'out' and 'ref' arguments.
10986 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10987 improve clarity. Remove dead code.
10990 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10991 (Catch.Resolve): Resolve VarBlock if it exists.
10993 2006-04-19 Miguel de Icaza <miguel@novell.com>
10995 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10996 twice, this was some residual code, the enumerator was emitted
10997 properly in the two branche of if later.
10999 2006-04-19 Raja R Harinath <rharinath@novell.com>
11001 * expression.cs (Cast.ResolveLValue): Remove. The result of a
11002 cast is never an lvalue.
11003 (Cast.DoResolve, Cast.ResolveRest): Combine.
11004 (Argument.Emit): Simplify slightly. Move 'Expr is
11005 IMemoryLocation' check ...
11006 (Argument.Resolve): ... here.
11007 (Argument.Error_LValueRequired): Remove. Inline into only user.
11009 Simplifications. Fix cs0191-2.cs
11010 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
11011 CS1649 and CS1651 to ...
11012 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
11013 the actual selection of the error code and message to a lookup
11014 table. Add a dummy return value to simplify callsites.
11015 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
11016 readonly fields of other instances of the same type. Move CS0197
11018 * expression.cs (Argument.Resolve): ... here. Simplify code.
11019 Ensure that ec.InRefOutArgumentResolving is only set during LValue
11020 resolution of an out or ref argument. The code simplification
11021 above uses this invariant.
11023 2006-04-18 Raja R Harinath <rharinath@novell.com>
11025 Possibly fix #77752. Fix cs1690-[4-7].cs.
11026 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
11027 CheckMarshallByRefAccess. Drop parameter.
11028 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
11030 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
11031 InstanceExpression.
11032 * report.cs (AllWarnings): Add CS1690.
11033 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
11034 for ref access too.
11035 (LocalVariableReference.DoResolveBase): Update.
11037 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11039 * class.cs (MethodOrOperator): Moved common parts from method class.
11040 detect obsolete attributes.
11041 (Method.Define): Simplified as it reuses code from base.
11042 (Constructor.ValidAttributeTargets): Fixed issue found during
11044 (Destructor.ValidAttributeTargets): Fixed issue found during
11046 (Operator): Finished refactoring set off by #78020. Operator class is now
11047 ordinary method class.
11049 * anonymous.cs: Updated.
11051 * decl.cs (DeclSpace): Add IsGeneric
11053 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11055 * class.cs (Constructor.Emit): Don't emit the attributes twice.
11057 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11059 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
11060 detect obsolete attributes.
11061 (Method.CreateEmitContext): Moved to MethodOrOperator.
11063 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11066 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
11067 customized exception to make crash detection easier.
11068 (MethodOrOperator): Started to work on new base class for methods and
11070 (Method): Derives from MethodOrOperator.
11071 (Constructor.Emit): Emits its own attributes.
11072 (AbstractPropertyEventMethod.Emit): Ditto.
11073 (Operator): Derives from MethodOrOperator, will refactor fully in extra
11075 (Operator.Emit): It's temporary more tricky than should be.
11077 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
11079 * report.cs (InternalErrorException): Add ctor with inner exception.
11081 2006-04-08 Marek Safar <marek.safar@seznam.cz>
11084 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
11087 2006-04-07 Marek Safar <marek.safar@seznam.cz>
11090 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
11093 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11095 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
11096 attribute is present and Guid not.
11097 (Interface.ApplyAttributeBuilder): Ditto.
11099 * attribute.cs: Add error message.
11101 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11105 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
11106 sources (it's composite) so hold them in extra array as they are used in
11107 Emit phase only. It worked in the previous versions by mistake.
11108 (Attribute.Emit): Emit attribute for more owners when exist.
11110 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
11111 it has now different behaviour.
11113 2006-04-04 Marek Safar <marek.safar@seznam.cz>
11115 * constant.cs (Constant.IsDefaultInitializer): New method.
11117 * class.cs: Updated.
11119 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
11120 re-initialize default values. It saves KBs almost for every assembly.
11121 Thanks Zoltan for the idea.
11122 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
11123 (ArrayCreation.DoResolve): Resolve only once.
11124 (ArrayCreation.Emit): Emit static initializer only when it is faster.
11125 (ArrayCreation.GetAttributableValue): Cope with optimized values.
11127 2006-04-03 Zoltan Varga <vargaz@gmail.com>
11129 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
11132 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11134 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
11135 in an embedded statement too.
11137 2006-04-01 Raja R Harinath <rharinath@novell.com>
11140 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
11142 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11146 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
11149 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
11151 2006-03-31 Marek Safar <marek.safar@seznam.cz>
11153 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
11156 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
11157 LocalTemporary change.
11159 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
11161 (ClassOrStruct.DefineFieldInitializers): Implemented static field
11162 initializers optimization.
11163 (ClassOrStruct.TypeAttr): Moved from modifiers.
11164 (Constructor.CheckBase): Don't crash when static ctor has parameters.
11165 (FieldBase.ResolveInitializer): Resolves initializer.
11166 (FieldBase.HasDefaultInitializer): New property.
11168 * cs-parser.jay: Removed message.
11170 * expression.cs (CompilerGeneratedThis): New specialization.
11172 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
11174 2006-03-28 Marek Safar <marek.safar@seznam.cz>
11176 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
11178 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11180 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
11181 be now EnumConstants only.
11183 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11185 * attribute.cs, driver.cs: Reset more caches.
11187 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11189 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
11191 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11193 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
11194 for easier reuse. Updated all overrides.
11195 (IntegralConstant): New base class for all integral constants.
11196 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
11197 of the constant range, report custom error.
11198 (UIntConstant.Reduce): Fixed uint conversion.
11200 * ecore.cs, literal.cs: Reduce updates.
11202 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11206 * class.cs (Constructor.Define): Removed extra if for default ctors.
11207 A patch from Atsushi Enomoto.
11209 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11211 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
11212 GetAttributableValue.
11214 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
11217 * convert.cs (ImplicitConversionRequired): Error message moved to
11220 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
11221 automatic implicit conversion of an output value.
11222 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
11224 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
11226 (TypeOf.GetAttributableValue): Add extra handling for object type.
11228 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
11229 special error message.
11231 2006-03-25 Marek Safar <marek.safar@seznam.cz>
11233 * class.cs (Constructor.Emit): Don't crash when struct ctor is
11235 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
11236 compatible with MS runtime.
11238 2006-03-23 Marek Safar <marek.safar@seznam.cz>
11240 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
11241 attribute arguments here.
11243 * class.cs (Indexer.Define): The check was moved to attribute class.
11245 2006-03-22 Marek Safar <marek.safar@seznam.cz>
11247 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
11248 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
11251 2006-03-22 Raja R Harinath <rharinath@novell.com>
11253 Support ParameterDefaultValueAttribute in gmcs. Also applied to
11254 mcs to keep code differences small.
11255 * attribute.cs (Attribute.GetParameterDefaultValue): New.
11256 * typemanager.cs (parameter_default_value_attribute_type): New.
11257 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
11260 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11262 * expression.cs (StringConcat.Append): Reverted back to no warning state.
11264 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11266 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
11268 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
11271 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
11273 * doc-bootstrap.cs : fix build.
11275 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11277 * expression.cs (StringConcat.Append): Issue a warning when empty string
11278 is going to append.
11280 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11282 * assign.cs (CompoundAssign.ResolveSource): Removed.
11284 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
11287 * class.cs (TypeContainer.FindMethods): Removed.
11288 (TypeContainer.CheckMemberUsage): Made static.
11290 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
11292 * constant.cs (CheckRange): Removed unused type argument.
11293 (CheckUnsigned): Removed unused type argument.
11295 * cs-parser.jay: Updated after MemberAccess clean up.
11296 Uses Length for empty string test.
11298 * cs-tokenizer.cs: Uses Length for empty string test.
11299 (IsCastToken): Made static.
11300 (is_hex): Made static.
11301 (real_type_suffix): Made static.
11303 * decl.cs (SetupCache): Made static.
11304 (OnGenerateDocComment): Removed unused ds argument.
11306 * delegate.cs (VerifyDelegate): Removed unused argument.
11308 * doc.cs: Uses Length for empty string test.
11310 * driver.cs: Uses Length for empty string test.
11312 * enum.cs (IsValidEnumType): Made static
11314 * expression.cs (EnumLiftUp): Removed unused argument.
11315 (ResolveMethodGroup): Ditto.
11316 (BetterConversion): Ditto.
11317 (GetVarargsTypes): Ditto.
11318 (UpdateIndices): Ditto.
11319 (ValidateInitializers): Ditto.
11320 (MemberAccess.ctor): Ditto.
11321 (GetIndexersForType): Ditto.
11323 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11325 * iterators.cs: Updated after MemberAccess clean up.
11327 * location.cs: Uses Length for empty string test.
11329 * namespace.cs: Uses Length for empty string test.
11331 * report.cs (CheckWarningCode): Made static.
11333 * statement.cs (LabeledStatement): Removed unused argument.
11335 * typemanager.cs (FilterNone): Removed.
11337 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11339 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11342 * class.cs: Updated.
11344 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11346 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11348 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11352 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11353 reporting, it's more tricky than I thought.
11355 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11359 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11361 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11362 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11363 Add more error reporting; Fixed issue with params.
11365 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11367 * cs-parser.jay: AnonymousMethod requires host container.
11369 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11371 2006-03-18 Raja R Harinath <harinath@gmail.com>
11373 * class.cs: Change 'TypeContainer ds' constructor argument to
11374 'DeclSpace parent'. Some classes were missed below due to
11375 different naming convention.
11377 * class.cs (MemberCore.Parent): Delete. This makes the
11378 ParentContainer changes below enforceable by the compiler.
11380 Treat pointers to enclosing declaration space as 'DeclSpace', not
11382 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11383 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11385 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11387 (Block.AddThisVariable): Likewise.
11388 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11389 (AbstractPropertyEventMethod.Emit): Likewise.
11390 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11391 (GetMethod.Define, SetMethod.Define): Likewise.
11392 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11393 (DelegateMethod.EmitMethod): Likewise.
11395 Fix regression test-partial-13.cs.
11396 Rationalize use of PartialContainer. Ensure that the partial
11397 class semantics can be tied to type-correctness, i.e., any
11398 violation will cause a compile error.
11399 * class.cs, const.cs: Access all fields that belong to class
11400 TypeContainer via ParentContainer. Arguments of EmitContexts and
11401 Resolve()-like functions still use 'Parent'.
11403 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11404 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11405 (PropertyMethod.CheckModifiers): Remove unused argument.
11406 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11409 2006-03-17 Raja R Harinath <harinath@gmail.com>
11411 Make semantics of PartialContainer simpler.
11412 * decl.cs (DeclSpace.IsPartial): Remove.
11413 * class.cs (TypeContainer.IsPartial): Likewise.
11414 (TypeContainer..ctor): Set PartialContainer to point to self.
11415 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11416 (TypeContainer.FindNestedType): Likewise.
11417 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11419 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11421 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11423 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11425 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11428 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11430 * class.cs (Operator.Define): An error for base conversion was not
11431 reported correctly.
11433 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11435 * iterator.cs : yield break is allowed in try statement which has
11436 catch clauses. Fixed bug #77767.
11438 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11440 A fix for #77593, #77574.
11442 * class.cs (MethodCore.CheckBase): Another if for operator.
11444 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11446 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11449 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11450 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11453 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11456 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11457 Updated after another emitcontext usage was clean up. It should help us to
11458 synchronize with gmcs easier.
11460 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11464 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11465 (Event.Define): ditto
11466 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11468 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11469 Removed redundant code and set NewSlot for Invoke method too.
11471 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11472 (Parameters.MergeGenerated): New method. Use this method when you merge
11473 compiler generated argument with user arguments.
11475 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11477 * attribute.cs (ResolveAsTypeTerminal): Removed.
11479 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11480 specialization for predefined types; 30% speed up.
11481 Finally placed obsolete check to right place.
11482 (Expression.ResolveType): Removed.
11484 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11485 Updated after ResolveType was removed.
11487 * expression.cs (Cast.ctor): Check void cast.
11488 (Binary.ResolveAsTypeTerminal): Is never type.
11489 (Conditional.ResolveAsTypeTerminal): Is never type.
11491 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11493 2006-03-01 Raja R Harinath <rharinath@novell.com>
11496 * expression.cs (ParameterReference.DoResolveBase): Change return
11498 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11502 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11505 * typemanager.cs (GetFullNameSignature): Don't nullref on
11506 protected accessors.
11508 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11510 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11511 these two separated members to simplify the code.
11512 (Attribute.Resolve): Refactored to use new fields and methods.
11513 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11514 implemented obsolete attribute checking.
11515 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11516 implemented obsolete checking again. It look line never ending quest ;-)
11517 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11519 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11521 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11523 *class.cs (Property.Define): Add RegisterProperty call.
11525 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11526 argument groups (only 2).
11528 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11529 encoding expression to arguments.
11530 (Expression.ExprClassToResolveFlags): Just turned to property.
11532 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11533 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11534 optimized as well as implemented support for zero-length attributes.
11536 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11537 Add caching of PropertyInfo's.
11539 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11541 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11542 error multiple times.
11544 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11546 New partial class implementation.
11547 A fix for #77027, #77029, #77403
11549 * attribute.cs (Attributable): Made attributes protected.
11551 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11552 the replacements of ClassPart and PartialContainer.
11553 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11554 (TypeContainer.AddInterface): Ditto.
11555 (TypeContainer.AddPartial): The main method for partial classes. It checks
11556 for errors and merges ModFlags and attributes. At the end class is added to
11557 partial_parts list.
11558 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11560 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11561 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11562 from the rest of partial classes.
11563 (TypeContainer.GetClassBases): Simplified.
11564 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11566 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11567 (TypeContainer.HasExplicitLayout): Uses Flags now.
11568 (PartialContainer): Removed.
11569 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11570 (StaticClass): Was merged with Class.
11571 (Class.GetClassBases): class and static class bases are verified here.
11572 (Class.TypeAttr): Added static attributes when class is static.
11573 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11574 (MemberBase): In some cases we need to call parent container for partial
11575 class. It should be eliminated but it's not easy now.
11577 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11579 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11580 partial classed to accumulate class comments.
11581 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11583 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11585 * driver.cs (MainDriver): Tree.GetDecl was removed.
11587 * modifiers.cs (Modifiers): Add partial modifier.
11589 * tree.cs (Tree.decl): Removed.
11590 (RootTypes): Started to use this class more often for root types
11593 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11597 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11598 external interface does not have an attribute.
11600 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11602 Another prerequisites for new partial classs implementation.
11604 * attribute.cs (Attribute.Equal): Implemented.
11605 (Attribute.Emit): Changed as attributes can be applied more than twice.
11606 (Attributes.Emit): Check for duplicate attributes here.
11608 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11609 as a parameter, clean-up.
11611 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11615 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11616 contains obsolete attribute check which can in some cases look for base
11617 type of current class which is not initialized yet.
11618 (TypeContainer.BaseType): Replacement of ptype.
11620 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11622 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11624 First of prerequisites for new partial classs implemention.
11626 * attribute.cs (Attributable): Extended by ResolveContext;
11627 Attributes finally have correct context for resolving in all cases.
11628 (AttachTo): Attribute owner is assigned here.
11630 * codegen.cs (IResolveContext): Introduce new interface to hold
11631 all information needed in resolving phase.
11632 (EmitContext): Implements IResolveContext; more clean-up needed here.
11634 * decl.cs (MemberCore): Implemented IResolveContext.
11636 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11637 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11638 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11639 Refactored to use new IResolveContext instead of EmitContext; cleanup
11641 2006-02-06 Miguel de Icaza <miguel@novell.com>
11643 * codegen.cs (EmitScopeInitFromBlock): check here the
11644 capture_context, there is no need to make two calls to the
11647 * anonymous.cs: Add some debugging messages that might help me
11648 track other instances of this problem in the future (the
11649 regression of test 467).
11651 * cs-parser.jay: track the variable block, as we need to initalize
11652 any captured variables declared in this block for the "catch"
11653 portion of the "Try" statement.
11655 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11656 scope initialization for captured variables.
11658 Also, move the emit for the variables after the block location has
11661 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11663 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11665 2006-02-02 Miguel de Icaza <miguel@novell.com>
11667 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11668 commit yesterday, the initialization for the roots is necessary.
11669 What is not necessary is the scope activation.
11671 2006-02-02 Raja R Harinath <rharinath@novell.com>
11673 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11674 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11676 (Argument.Resolve): Remove CS0206 checks.
11678 2006-02-01 Miguel de Icaza <miguel@novell.com>
11680 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11681 scopes for all the roots, the scopes will now be emitted when the
11682 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11684 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11685 code. This reduces a lot of existing cruft.
11687 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11688 that the ScopeInfo is generated as we enter the scope, not at the
11689 time of use, which is what we used to do before.
11691 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11692 every time a Block is about to be emitted if we have a
11695 2006-02-01 Raja R Harinath <rharinath@novell.com>
11697 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11699 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11701 * typemanager.cs (cons_param_array_attribute): Make private.
11702 (Reset): Set it to null.
11703 (InitCoreHelpers): Don't initialize it.
11704 (ConsParamArrayAttribute): New. Initialize it as needed.
11705 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11707 2006-01-31 Miguel de Icaza <miguel@novell.com>
11709 * expression.cs: There might be errors reported during the
11710 selection of applicable methods. If there are errors, do not
11711 continue execution as it will lead the compiler to crash.
11713 2006-01-30 Miguel de Icaza <miguel@novell.com>
11715 * expression.cs: Member access is not allowed on anonymous
11716 methods. Fixes #77402.
11718 2006-01-30 Raja R Harinath <rharinath@novell.com>
11721 * cs-parser.jay (VariableDeclaration): Don't set
11722 current_array_type to null.
11723 (field_declaration, event_declaration, declaration_statement):
11724 Set it to null here.
11726 2006-01-28 Raja R Harinath <harinath@gmail.com>
11728 * typemanager.cs (GenericParameterPosition): New.
11731 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11733 * doc.cs : To process "include" elements, first we should create
11734 another list than XmlNodeList, because it could result in node
11735 removal, which could result in that the XmlNodeList gives up
11736 yielding next node.
11738 (Also made code identical to gmcs again.)
11740 2006-01-25 Miguel de Icaza <miguel@novell.com>
11742 * ecore.cs: Introduce an error report that we were not catching
11743 before, if not silent, we must report the error. Gonzalo ran into
11746 2006-01-23 Miguel de Icaza <miguel@novell.com>
11748 A fix for bug: #76957
11750 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11751 ComputeMethodHost before creating the method, this is a new
11754 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11755 that this method references (RegisterScope). The actual scope
11756 where the method is hosted is computed with the ComputeMethodHost
11757 before we create the method.
11759 Moved the Deepest routine here.
11761 (AnonymousContainer.ComputeMethodHost): New routine used to
11762 compute the proper ScopeInfo that will host the anonymous method.
11764 (ScopeInfo): Deal with multiple roots. The problem was that we
11765 did not have a unique root where all ScopeInfos could be hanged
11766 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11769 Remove AdjustMethodScope which is now computed at the end. Remove
11770 LinkScope which did a partial link, instead link all ScopeInfos
11771 before code generation from the new "LinkScopes" routine.
11773 Simplify all the Add* routines as they no longer need to maintain
11774 the tree, they just need to record that they are using variables
11777 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11778 routines to produce the forest of ScopeInfo trees.
11780 * class.cs (TypeContainer.AppendMethod): This is just like
11781 AddMethod, but ensures that an interface implementation method
11782 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11783 methods, but at the end.
11785 We use this functionality to ensure that the generated MoveNext
11786 method in the iterator class is resolved/emitted before the
11787 enumerator methods created.
11789 This is required because the MoveNext method computes the right
11790 ScopeInfo for the method. And the other methods will eventually
11791 need to resolve and fetch information computed from the anonymous
11794 2006-01-21 Raja R Harinath <harinath@gmail.com>
11795 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11797 Fix rest of #76995.
11798 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11799 the 'aliases' hash.
11800 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11801 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11803 2006-01-18 Raja R Harinath <rharinath@novell.com>
11805 Fix #76656, cs0231-2.cs.
11806 * cs-parser.jay (formal_parameter_list): Make error case catch
11808 (parenthesized_expression_0): Add CS1026 check.
11809 (invocation_expression): Remove unused { $$ = lexer.Location }.
11811 2006-01-17 Raja R Harinath <rharinath@novell.com>
11814 * cs-parser.jay (statement_expression): Don't list out the
11815 individual statement-expressions. Convert syntax error into
11818 2006-01-16 Raja R Harinath <rharinath@novell.com>
11821 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11822 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11823 CheckIntermediateModification.
11824 (FieldExpr.DoResolve): Add new two-argument version that
11825 allows us to resolve the InstanceExpression as an lvalue.
11826 The one-argument variant is now just a wrapper.
11827 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11828 Resolve the lhs as an lvalue if the it has a value type.
11829 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11830 from Assign.DoResolve.
11831 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11832 resolved as an lvalue.
11833 (PropertyExpr.DoResolve): Update.
11834 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11835 has a value type. Move CS1612 check here from
11836 CheckIntermediateModification.
11837 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11838 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11839 'right_side' of a ResolveLValue on an 'out' argument.
11840 (EmptyExpression.LValueMemberAccess): New. Used as the
11841 'right_side' of a propagated ResolveLValue on a value type.
11842 (LocalVariableReference.DoResolveBase): Recognize
11843 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11845 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11846 EmptyExpression.Null.
11848 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11850 * typemanager.cs : added IsGenericParameter(). In mcs it always
11852 * doc.cs : for generic parameters, use GenericParameterPosition,
11855 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11857 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11859 2006-01-12 Miguel de Icaza <miguel@novell.com>
11861 This fixes the problem where we used ldfld instead of ldflda to
11862 load the "THIS" pointer on captured parameters, when THIS is a
11863 value type. See bug #77205.
11865 * iterators.cs (CapturedThisReference.Emit): Pass false to
11866 EmitThis (we do not need the address).
11868 * codegen.cs (EmitThis): it needs to know whether we need the
11869 address of `this' or not. This is used by value types.
11871 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11872 every other call passes false.
11874 2006-01-12 Raja R Harinath <rharinath@novell.com>
11877 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11879 * expression.cs (Invocation.OverloadResolve): Update.
11880 (Invocation.DoResolve): Avoid double resolution of invocation.
11882 2006-01-11 Raja R Harinath <rharinath@novell.com>
11885 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11886 unary negation of floating point types as 0-expr; negation cannot
11887 overflow in floating point types.
11890 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11891 on operands of 'void' type.
11894 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11895 and ExclusiveOr for boolean constants too.
11897 2006-01-09 Raja R Harinath <rharinath@novell.com>
11900 * expression.cs (Invocation.OverloadResolve): Replace reflected
11901 override methods with their base virtual methods, rather than
11902 skipping over them.
11903 * typemanager.cs (TypeManager.GetOverride): New.
11905 2006-01-05 Jb Evain <jbevain@gmail.com>
11907 * class.cs (Property.Define, Indexer.Define): do not tag the
11908 properties as SpecialName | RTSpecialName.
11910 2006-01-04 Miguel de Icaza <miguel@novell.com>
11912 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11913 doing a low-level comparission of parameter types. It was lacking
11914 a check for __argslist.
11916 2005-12-30 Miguel de Icaza <miguel@novell.com>
11918 * expression.cs (ParameterReference.DoResolveBase): Allow
11919 reference parameters if they are local to this block.
11921 This allows the ref and out parameters of a delegate to be used in
11922 an anonymous method, for example:
11924 delegate void set (out int x);
11926 set s = delegate (out int x){
11930 This is used by functionality introduced late in the C# language.
11932 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11933 method that take ref and out parameters.
11935 Fixes #77119 which was a late change in the spec.
11937 2005-12-23 Miguel de Icaza <miguel@novell.com>
11939 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11940 parent if its the same scope. Fixes #77060.
11942 2005-12-21 Miguel de Icaza <miguel@novell.com>
11944 * driver.cs: Report the case of no source files and no -out:
11947 2005-12-20 Raja R Harinath <rharinath@novell.com>
11950 * expression.cs (ComposedCast.GetSignatureForError): Define.
11952 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11956 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11957 ListDictionary, to contain the ExternAliasEntry entries (in
11958 addition to the NamespaceEntry.aliases hashtable). This field is
11959 shared between the original entry and its doppelganger (bodyless
11961 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11962 extern_aliases field.
11963 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11964 lookup in extern_aliases.
11966 2005-12-16 Raja R Harinath <rharinath@novell.com>
11969 * class.cs (TypeContainer.Mark_HasEquals): New.
11970 (TypeContainer.Mark_HasGetHashCode): New.
11971 (ClassPart): Override them.
11972 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11975 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11976 'parent' argument to the base constructor.
11978 Remove all mention of TypeContainer from decl.cs.
11979 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11980 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11981 (DeclSpace.DeclSpace): Likewise.
11982 (DeclSpace.DefineMembers): Remove unused argument.
11983 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11984 debugging check -- we don't care if the debug code throws an
11985 InvalidCastException instead of an InternalErrorException.
11986 * class.cs (TypeContainer.DefineMembers): Update to changes.
11987 (TypeContainer.DoDefineMembers): Likewise.
11988 (TypeContainer.GetMethods): Likewise.
11989 (PropertyMember.Define): Likewise.
11990 (MemberBase.Parent): New property that forwards to
11991 MemberCore.Parent, but ensures that we get a TypeContainer.
11992 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11993 (RootContext.PopulateTypes): Likewise. Remove special case code
11994 for !RootContext.StdLib: DefineMembers is idempotent.
11996 2005-12-14 Miguel de Icaza <miguel@novell.com>
11998 * convert.cs (ExplicitConversionCore): Check the return value from
11999 ExplicitConversionCore which can return null on failure. Fixes #76914
12001 2005-12-13 Marek Safar <marek.safar@seznam.cz>
12003 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
12005 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
12007 * doc.cs : The search for referenced namespace was insufficient to
12008 get global one as it used to do. Fixed bug #76965.
12010 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
12012 * doc.cs : check name in cref in the last phase that whether it is
12015 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12017 * cs-tokenizer.cs : reverted the latest change: it somehow broke
12020 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12022 * doc.cs : so it turned out that we cannot skip override check for
12023 interface members. Fixed bug #76954.
12025 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12027 * cs-tokenizer.cs : fixed bug #75984:
12028 - #warning and #error should not be handled when the source line
12030 - #line is not checked strictly when the source line is disabled.
12031 - #define and #undef is on the other hand checked strictly at any
12034 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
12036 * cs-tokenizer.cs : missing Location (actually, filename) in one of
12039 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12041 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
12043 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
12044 event initializers.
12045 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
12046 (FieldBase.Initializer): Initializer is now optional.
12047 (EventField.Define): Only event field can have initializer.
12049 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
12051 * const.cs (Const): Reuse initializer.
12053 * cs-parser.jay: Updated after FieldBase changes.
12054 Added current_array_type to simplify array initializers.
12056 * ecore.cs (NullCast.IsDefaultValue): Implemented.
12058 * expression.cs, iterators.cs: Updated.
12060 * namespace.cs (NamespaceEntry): Made UsingFound private.
12062 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12064 * parameterCollection.cs: Obsolete, removed.
12065 * parser.cs: Obsolete, removed.
12067 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12070 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
12072 * enum.cs (Enum.Define): Set obsolete context here.
12074 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12077 - FindDocumentedMember() now expects 1) paramList as null
12078 when "we don't have to check the number of parameters" and
12079 2) Type.EmptyTypes when "there is no arguments".
12080 - Introduced FoundMember struct to hold the exact type which was
12081 used to find the documented member (the above change broke
12082 test-xml-044; it might be better just to use DeclaringType than
12083 what MS does, like this change does, but it depends on usage.)
12085 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12087 * doc.cs : documented member might be from DeclaringType for nested
12088 types. Fixed bug #76782.
12090 2005-12-03 Ben Maurer <bmaurer@ximian.com>
12092 * anonymous.cs: Have the param code handle leaving copies on the
12093 stack etc. Allows anonymous params to take part in the assignment
12094 code (++, +=, etc). Fixes bug #76550
12096 * expression.cs: Handle the prepare_for_load/leave_copy by passing
12097 it down to the anon code.
12099 * iterators.cs: Use dummy var here
12101 * codegen.cs: Handle new vars
12103 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12106 * class.cs (MethodData.Define): Set proper Obsolete context.
12108 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
12110 (FieldExpr.DoResolve): Ditto.
12112 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12115 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
12116 parent is not obsolete.
12118 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
12120 * doc.cs : (FindDocumentedMember) find parameterless members first
12121 and get CS0419 in the early stage. Fixed first case of bug #76727.
12123 2005-11-30 Marek Safar <marek.safar@seznam.cz>
12126 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
12127 no error was reported.
12129 *expression.cs (Binary.DoResolve): left can be null.
12131 2005-11-22 Marek Safar <marek.safar@seznam.cz>
12134 * class.cs (MethodData.Emit): Parameters should be labeled first.
12136 2005-11-21 Marek Safar <marek.safar@seznam.cz>
12139 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
12141 2005-11-18 Marek Safar <marek.safar@seznam.cz>
12143 * attribute.cs (AreParametersCompliant): Moved to Parameter.
12145 * class.cs (MethodCore): Parameter clean up.
12146 (IMethodData): Added ParameterInfo.
12147 (MethodData): Parameter clean up.
12148 (Indexer.Define): Parameter clean up.
12160 * typemanager.cs: Parameter clean up.
12162 * delegate.cs (Define): Get rid of duplicated code.
12164 * expression.cs (ParameterReference): Removed useless parameters
12166 (Invocation): Ditto.
12168 * parameter.cs (ParamsParameter): New class, params specialization.
12169 (ArglistParameter): Attemp to separate arglist.
12170 (Parameter): Refactored to be reusable and faster.
12171 (Parameter.Modifier): Made understandable.
12172 (Parameters): Changed to be used as a class for `this' assembly
12173 parameters. Refactored to use new specialized classes.
12175 * support.cs (ParameterData): Added Types property.
12176 (InternalParameters): Deleted.
12178 2005-08-20 Martin Baulig <martin@ximian.com>
12180 Merging this patch from GMCS to fix #75867.
12182 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12183 scope if we don't already have it.
12185 2005-11-17 Martin Baulig <martin@ximian.com>
12188 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
12189 inherit the scope from our parent. Fixes #76653.
12191 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12193 * doc.cs : the previous patch does not actually fix the bug.
12194 PropertyInfo override check is now implemented and really fixed it.
12195 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
12197 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12199 * doc.cs : apply "override filter" also to properties.
12202 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12204 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
12205 no need to check overrides. For classes, omit those results from
12206 interfaces since they must exist in the class. Fixed bug #76726.
12208 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12210 * typemanager.cs : (GetFullNameSignature) differentiate indexers
12211 with different parameters. Fixed the second problem in #76685.
12213 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12215 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
12216 get expected 'protected' access in CheckValidFamilyAccess()).
12219 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12221 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
12222 Fixed bug #76705. CS1569 was incorrectly commented out.
12224 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12226 * doc.cs : use Invocation.IsOverride() to do real override check.
12227 * expression.cs : made Invocation.IsOverride() internal.
12229 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12231 * doc.cs : use TypeManager.FindMembers() instead of (possible)
12232 TypeBuilder.FindMembers() and filter overriden base members out.
12235 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12237 * doc.cs : ref/out parameters are represented as '@' (instead of
12238 '&' in type FullName). Fixed bug #76630 (additionally crefs).
12240 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12242 * doc.cs : when there was no '.' in cref to methods in doc comment,
12243 then parameters were missing in the output. Fixed bug #76691.
12245 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12247 * driver.cs : don't output docs when there is an error.
12250 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12253 Now it should detect indexers. Fixed primary concern in bug #76685.
12254 Fixed CS0419 message to not show the identical member signature in
12257 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12259 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
12260 instead of Type.FindMembers() since it does not handle events.
12263 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
12265 * codegen.cs: Fixed typo (speficied -> specified).
12267 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12270 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
12272 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12274 * attribute.cs: Changed error message.
12276 * cs-tokenizer.cs: One more check.
12278 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12280 * statement.cs (Block.Resolve): Ignore empty statement.
12282 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12284 * report.cs: Made error/warning methods more strict to avoid
12287 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
12288 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
12289 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
12290 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
12292 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12294 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12295 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12297 * class.cs (TypeContainer.IsComImport): New property.
12298 (Constructor.Define): Create proper ctor for ComImport types.
12300 * expression.cs (New.CheckComImport): Fixed.
12302 2005-11-07 Miguel de Icaza <miguel@novell.com>
12304 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12305 that a parameter has been captured does not mean that we do not
12306 have to do the rest of the processing. This fixes the second part
12307 of #76592. If there was another anonymous method capturing
12308 values in the past, the Scope would never be set for the second
12309 method that captured the same parameter.
12311 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12312 properly manipulate the stack. Second part of fix for #76592.
12314 * expression.cs (New): Add support for invoking "new" on
12315 interfaces that have been flagged with the ComImport attribute and
12316 the CoClass. Fixes #76637
12318 * statement.cs (Try.DoEmit): When a variable is captured, do not
12319 try to emit the vi.LocalBuilder variable as it has been captured.
12320 Create a temporary variable and store the results on the
12321 FieldBuilder. Fixes #76642
12323 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12325 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12327 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12329 * expression.cs (Binary.DoResolve): Added && optimalization.
12331 * typemanager.cs (AddUserType): Removed useless argument.
12333 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12335 * statement.cs (Block.variables): Uses ListDictionary.
12337 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12340 * class.cs (PartialContainer.EmitType): Customized to emit
12341 security attributes.
12342 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12343 for partial classes.
12345 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12348 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12349 access has to be fixed.
12351 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12353 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12356 * ecore.cs (NullCast.Reduce): Implemented.
12358 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12361 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12363 (Foreach.Resolve): Catch null properly.
12365 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12367 * cs-tokenizer.cs: Warning text fix.
12369 * driver.cs: AllWarningNumbers exposed on public interface.
12371 * report.cs (): Reviewed warning numbers.
12372 (IsValidWarning): Use binary search.
12374 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12376 * driver.cs: Implemeted resource visibility.
12377 (Resources): New class for code sharing between /res: and
12380 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12383 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12386 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12389 * ecore.cs (NullCast): Child is contant only.
12391 * literal.cs (NullLiteral.Reduce): null can be converted to any
12394 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12396 * driver.cs: Use Encoding.Default as default code page instead
12399 2005-10-27 Raja R Harinath <rharinath@novell.com>
12402 * expression.cs (Invocation.Error_InvalidArguments): Handle
12403 __arglist parameters.
12404 (Invocation.VerifyArgumentsCompat): Likewise.
12405 * support.cs (ReflectionParameters.GetSignatureForError): Print
12406 __arglist parameters.
12407 (InternalParamters.GetSignatureForError): Likewise.
12408 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12410 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12412 * attribute.cs (GetPropertyValue): Made public.
12414 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12416 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12418 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12421 * driver.cs: Reflect method name change.
12423 * statement.cs (Try.Resolve): Warn when try has both general
12424 exception handlers.
12426 * typemanager.cs: runtime_compatibility_attr_type new predefined
12429 2005-10-26 Raja R Harinath <harinath@gmail.com>
12432 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12433 treat it as an empty parameter list.
12435 2005-10-26 Raja R Harinath <rharinath@novell.com>
12438 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12439 ResolveAsTypeStep silent.
12440 * statement.cs (Block.AddConstant): Mark block as used.
12441 (Block.ResolveMeta): Avoid piling on error messages
12442 if a constant initializer resolution fails.
12444 2005-10-25 Raja R Harinath <rharinath@novell.com>
12446 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12448 (NamespaceEntry.VerifyAllUsing): New.
12449 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12450 behaviour. Delegates actual resolution of alias to ...
12451 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12452 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12454 * driver.cs (Driver.MainDriver): Update.
12456 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12457 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12459 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12461 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12462 RootNamespace.DefineNamespacesForAll.
12464 2005-10-24 Raja R Harinath <harinath@gmail.com>
12466 * typemanager.cs (assemblies, external_aliases, modules)
12467 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12468 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12469 overhead. Move resposibility ...
12470 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12471 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12473 2005-10-23 Raja R Harinath <harinath@gmail.com>
12475 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12476 cached_namespaces. Improve usage.
12477 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12478 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12479 Move from GlobalRootNamespace and simplify.
12480 (RootNamespace.Global): Make instance variable.
12481 (RootNamespace.RootNamespace): Add "alias name" parameter.
12482 (GlobalRootNamespace): Simplify drastically.
12483 (Namespace.Lookup): Don't use GetNamespace.
12484 * typemanager.cs (GetRootNamespace): Rename from
12485 ComputeNamespaceForAlias.
12486 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12488 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12490 * anonymous.cs (AnonymousContainer): Don't crash when container
12493 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12495 * expression.cs (Binary.DoResolve): Warn when comparing same
12498 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12501 * expression.cs (Binary.DoResolve): It looks like there are no
12502 convetsion rules in enum context.
12504 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12506 Add support for extern alias qualifiers.
12507 * typemanager.cs: Move some LookupTypeReflection code
12508 to namespace.cs, to have cleaner code. Added some methods
12509 to help us keep track of the extern aliased references.
12510 * driver.cs: Add suport for extern alias assemblies on command
12511 line and check for their warnings/errors. Also keep track of the
12512 extern aliased assemblies.
12513 * namespace.cs: Move the global functionality of Namespace
12514 to GlobalRootNamespace/RootNamespace. Now the global namespace
12515 is GlobalRootNamespace.Globa. Also the code moved from
12516 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12517 Finally added LocalAliasEntry (AliasEntry before) and
12518 ExternAliasEntry, to handle alias statements.
12519 * cs-parser.jay: Add support in the grammar for extern alias
12521 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12522 Update callings to Namespace (now in GlobalRootNamespace).
12524 2005-10-18 Raja R Harinath <rharinath@novell.com>
12527 * class.cs (TypeContainer.DefineType): Move updating of
12528 topological sort earlier in the code.
12529 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12531 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12534 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12536 * constant.cs (Constant.TryReduce): Moved from Cast class.
12537 (Reduce): Made little bit more OO and fixed missing conversions.
12539 * ecore.cs (Reduce): Implemented.
12540 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12542 * literal.cs (Reduce): Implemented.
12544 * class.cs: Reverted Miguel's wrong commit.
12546 2005-10-14 Miguel de Icaza <miguel@novell.com>
12548 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12550 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12552 * cs-parser.jay, expression.cs : CS0214 was missing error location
12553 for constants. Fixed bug #76404.
12555 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12558 * convert.cs (ExplicitConversionCore): Fixed object->enum
12561 2005-10-10 Raja R Harinath <rharinath@novell.com>
12563 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12564 InstanceExpression.
12565 (PropertyExpr.EmitCall): Likewise.
12566 * expression.cs (Invocation.EmitArguments): Handle case where
12568 (Invocation.EmitCall): Avoid allocating temporary variable if
12569 there are no arguments.
12571 2005-10-07 Raja R Harinath <rharinath@novell.com>
12574 * convert.cs (ImplicitConversionStandard): Move conversion of
12575 void* to arbitrary pointer types ...
12576 (ExplicitConversionStandard): .. here.
12577 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12578 error to always print typenames.
12580 2005-10-07 Raja R Harinath <rharinath@novell.com>
12582 * convert.cs (GetConversionOperator): Rename from
12583 GetConversionOperators. Move operator selection code from ...
12584 (UserDefinedConversion): ... here.
12586 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12588 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12591 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12593 * assign.cs (Assign.DoResolve): Error method changed.
12595 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12597 * const.cs (ResolveValue): Reset in_transit immediately.
12599 * constant.cs: Error method changed.
12601 * convert.cs: Removed useless location parameter.
12602 (ExplicitNumericConversion): Don't do double enum check.
12603 (ExplicitConversionCore): Renamed from ExplicitConversion.
12604 (ExplicitUnsafe): Extracted from ExplicitConversion.
12605 (ExplicitConversion): Uses for error reporting.
12607 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12609 (ResolveBoolean): Uses common error method.
12610 (CastToDecimal): Get rid of ec.
12611 (CastFromDecimal): Optimized.
12612 (ConvCast): Get rid of ec.
12614 * enum.cs (ResolveValue): Reset in_transit immediately.
12615 (Emit): Return after first error.
12617 * expression.cs: Convert changes.
12619 * literal.cs: Error method changed.
12621 * statement.cs: Error method changed.
12623 2005-10-03 Raja R Harinath <rharinath@novell.com>
12625 * support.cs (SeekableStreamReader.Position): Don't error out when
12626 the requested position is just beyond the end of the current
12629 2005-09-28 Raja R Harinath <rharinath@novell.com>
12631 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12632 try to keep in sync with the byte count of the underlying Stream.
12633 However, this limits us to a window size of 2048 characters: i.e.,
12634 the maximum lookahead of our lexer/parser can be 2048 characters.
12636 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12639 * driver.cs: Fix compilation files with full root path.
12641 2005-09-25 Miguel de Icaza <miguel@novell.com>
12643 * report.cs (SymbolRelatedToPreviousError): Format the output so
12644 it does not use an open parenthesis that is never closed.
12646 * driver.cs: Follow coding guidelines
12648 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12651 * const.cs (Const.ResolveValue): Check for assigning non-null
12652 value to reference type.
12654 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12656 * anonymous.cs: Implemented ExprClassName.
12658 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12661 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12664 * class.cs (StaticClass.DefineContainerMembers): Report protected
12667 * codegen.cs: if(ed) PRODUCTION.
12669 * convert.cs (Error_CannotImplicitConversion): Better error
12672 * cs-parser.jay: More error checks.
12674 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12676 * driver.cs (CSCParseOption): Enabled wrong option check.
12678 * ecore.cs (Expression.ExprClassName): Turned to property.
12679 (MemberExpr.CheckIntermediateModification): For checking boxed
12680 value types modification.
12682 * statement.cs (Fixed.Resolve): Expression type must be
12683 convertible to fixed type.
12684 (CollectionForeach.GetEnumeratorFilter,TryType):
12685 Small refactoring for easier error checking.
12687 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12689 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12692 * class.cs (GeneratedBaseInitializer): New class for customization
12693 compiler generated initializers.
12694 (MemberBase.DoDefine): Check Obsolete attribute here.
12695 (FieldMember.DoDefine): Ditto.
12697 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12700 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12701 (MemberCore.GetObsoleteAttribute): Removed argument.
12702 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12703 (MemberCore.CheckObsoleteType): New helper.
12707 * statement.cs: Updates after MemberCore changes.
12709 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12710 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12712 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12713 obsolete attribute for compiler construct.
12714 (As.DoResolve): Cache result.
12716 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12718 2005-09-26 Raja R Harinath <rharinath@novell.com>
12721 * expression.cs (This.VerifyFixed): In a value type T, the type of
12722 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12723 value type R, 'this' is treated as a value parameter.
12725 2005-09-22 Miguel de Icaza <miguel@novell.com>
12727 * statement.cs (Lock): Use the TemporaryVariable class instead of
12728 manually using local variables as those do not work when variables
12731 * ecore.cs: Moved the TemporaryVariable class from being a nested
12732 class inside Foreach to be a public class that can be employed in
12735 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12737 * cs-parser.jay: interface_accessors replaced by
12738 accessor_declarations.
12740 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12743 * statement.cs (GotoCase.Resolve): Convert null constant to
12745 (SwitchLabel.ResolveAndReduce): Ditto.
12746 (SwitchLabel.NullStringCase): Custom null stamp.
12747 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12749 typemanager.cs (CSharpSignature): Don't skip first argument
12752 2005-09-18 Miguel de Icaza <miguel@novell.com>
12754 * driver.cs: Set InEmacs based on the environment variable EMACS.
12756 * location.cs (InEmacs): in this mode, do not report column
12757 location as it confuses Emacs.
12759 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12761 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12762 expression.cs, iterators.cs, literal.cs: Store constants and
12765 * class.cs (MemberBase.ShortName): Pass location.
12767 * cs-parser.jay: Some location fixes.
12769 * ecore.cs (Expression.Location): Made virtual.
12771 2005-09-05 Miguel de Icaza <miguel@novell.com>
12773 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12774 if the underlying types are the same, otherwise we need to produce
12775 code that will do the proper cast.
12777 This was exposed by Marek's constant rewrite which produced
12778 invalid code for the call site:
12780 enum X : long { a }
12781 void Method (X v) {}
12785 This fixes test-49.cs
12787 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12789 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12790 Type/Object should be allowed as well. Fixed bug #75968.
12792 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12794 * expression.cs : (Binary.DoResolve): when one is enum constant and
12795 another is constant 0, then return enum one *as enum type*.
12798 2005-09-02 Raja R Harinath <rharinath@novell.com>
12800 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12804 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12805 flow-branching for LocalVariableReferences in case we were invoked
12806 from a MemberAccess.
12807 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12809 (LocalVariableReference.DoResolveBase): ... this.
12810 (MemberAccess.Resolve): Do the check that was disabled during
12813 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12816 (PartialContainer.Create): check abstract/sealed/static strictly
12817 but abstract/sealed can exist only at one side. Fixed bug #75883.
12819 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12822 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12823 specified, don't default to UnmanagedType.I4.
12825 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12827 * expression.cs : conditional operator should check possibly
12828 incorrect assign expression. Fixed bug #75946.
12830 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12832 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12833 Reverting the change. gmcs is much complex than mcs on this matter.
12835 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12837 * cs-tokenizer.cs : To read another token ahead of the actual
12838 consumption, use new SavedToken and cache token instead of moving
12839 back the stream with SeekableStreamReader (it seemed problematic).
12841 driver.cs : Thus use StreamReader directly.
12842 * support.cs : Thus removed SeekableStreamReader.
12844 2005-08-30 Raja R Harinath <rharinath@novell.com>
12847 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12848 (ScopeInfo.EmitScopeType): Use it to construct field names from
12849 names of captured locals.
12852 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12853 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12854 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12855 (ExplicitConversion): Remove enum cases already handled by
12856 implicit conversion. Move implicit conversion check to the beginning.
12857 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12858 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12859 Don't treat System.Enum as a struct.
12861 2005-08-30 Jb Evain <jbevain@gmail.com>
12863 * attribute.cs: handles as expression in parameters.
12865 2005-08-30 Raja R Harinath <rharinath@novell.com>
12868 * class.cs (TypeContainer.VerifyClsName): Don't use a
12869 PartialContainer when verifying CLS compliance.
12870 (AbstractPropertyEventMethod): Set Parent here, ...
12871 (PropertyMethod): ... not here.
12873 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12875 * attribute.cs : escaped attribute name should not be allowed to be
12876 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12878 2005-08-29 Raja R Harinath <rharinath@novell.com>
12881 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12882 when converting a long constant to unsigned long.
12883 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12884 detect where IsApplicable and VerifyArgumentsCompat disagree.
12886 2005-08-29 Raja R Harinath <rharinath@novell.com>
12887 and Carlos Alberto Cortez <carlos@unixmexico.org>
12890 * class.cs (TypeContainer.CanElideInitializer): New helper.
12891 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12892 can safely emitting the initializer of a field.
12894 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12896 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12897 allowed inside a switch (without loop). Fixed bug #75433.
12899 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12901 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12902 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12904 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12906 * driver.cs : kinda reverting the default encoding changes (not exact
12907 revert since I noticed that "codepage:reset" might not work fine).
12909 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12911 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12912 Location. Now getter and setter store location correctly.
12913 (errors/cs0111-12.cs now reports the expected location.)
12915 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12917 * driver.cs : Use default encoding on the environment.
12918 Removed (now that) extra parameter for SeekableStreamReader.
12919 * support.cs : (SeekableStreamReader) third .ctor() argument for
12920 StreamReader is not required (always true). preamble size could
12921 be acquired in simpler and safe way.
12923 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12925 * cs-parser.jay: report CS0642 at warning level 3
12926 and report CS0642 for an if else statement also
12927 fixes bug #74745. Patch by John Luke (and a bit
12929 Removed extra CS0642 warning check for "while",
12931 * statement.cs: In Block.Resolve(), CS0642 check
12932 is reimplemented to check a sequence of an empty
12933 statement and a block.
12935 Both fix bug #66777.
12937 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12939 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12940 detection until I fix it.
12942 * cs-tokenizer.cs: Changed error message.
12944 * cs-parser.jay: Fixed 2 error locations.
12946 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12947 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12950 * enum.cs (GetSignatureForError): Fixed.
12952 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12956 * typemanager.cs (RegisterProperty): Removed.
12958 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12960 2005-08-24 Raja R Harinath <rharinath@novell.com>
12963 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12964 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12966 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12968 * expression.cs : tiny fix is required for not warning positive ulong.
12971 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12973 * expression.cs : add CS0652 check for constant and integral
12974 expression. Fixed bug #53974.
12976 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12978 * expression.cs : in DoNumericPromotions(), check if there is implicit
12979 conversion overload for string (to check CS0034). Fixed bug #52492.
12981 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12983 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12985 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12987 * ecore.cs : report location when it is *not* Null.
12989 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12995 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12996 correctly. Fixed bug #75721.
12998 2005-08-23 Raja R Harinath <rharinath@novell.com>
13000 * support.cs (SeekableStreamReader.Position): Avoid an expensive
13001 loop that performs 'min (pos, char_count)'.
13004 * expression.cs (Unary.ResolveOperator): Don't discard implicit
13005 converted value in Operator.OnesComplement.
13007 2005-08-22 Ben Maurer <bmaurer@ximian.com>
13009 * anonymous.cs: If the anon method is pulled into a helper class,
13010 it needs to be `internal' not `private'. Fixes runtime behavior on
13013 2005-08-20 Martin Baulig <martin@ximian.com>
13015 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
13016 scope if we don't already have it.
13018 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
13019 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
13022 2005-08-17 Marek Safar <marek.safar@seznam.cz>
13025 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
13026 is a partial class.
13028 2005-08-16 Marek Safar <marek.safar@seznam.cz>
13030 The big constants rewrite
13031 Fix #75746, #75685 and more
13032 As a side effect saved 1MB for MWF ;-)
13034 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
13035 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
13036 enum based for corlib compilation.
13038 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
13041 * class.cs (FixedField.Define): Use ResolveAsConstant.
13043 * const.cs (IConstant): Interface constants and enums.
13044 (Const.ResolveValue): New method for constant resolvning.
13045 (ExternalConstant): Constants from imported assemblies.
13047 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
13048 conversion; like enums.
13049 (Constant.ToType): Converts this constant to different type.
13050 (Constant.Increment): Adds 1.
13052 * convert.cs (ImplicitConversionRequired): Simplified.
13054 * cs-parser.jay: Create EnumMember directly.
13056 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
13058 * doc.cs (GenerateEnumDocComment): Removed.
13060 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
13061 (ConvertIntLiteral): Removed.
13062 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
13064 * enum.cs (EnumMember): Implement IConstant.
13065 (Enum.IsValidEnumConstant): Removed.
13066 (Enum.GetNextDefaultValue): Removed.
13067 (Enum.FindMembers): Updated.
13068 (Enum.GenerateDocComment): Iterate enum members.
13070 * expression.cs (Cast.TryReduce): Handle enums correctly.
13071 (New.Constantify): Made public.
13072 (MemberAccess.DoResolve): Removed contant specific if(s).
13074 * literal.cs (NullLiteral): Implement new abstract methods.
13076 * statement.cs (GotoCase.Resolve): Use new constant methods.
13077 (SwitchLabel.ResolveAndReduce): Use new constant methods.
13079 * typemanager.cs (LookupEnum): Removed.
13080 (IsEnumType): Fixed to work with corlib.
13081 (RegisterConstant): Removed.
13082 (LookupConstant): Removed.
13083 (GetConstant): Changed to work with IConstant.
13085 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
13087 * location.cs : Fixed overflown (>255) column number.
13089 2005-08-03 Raja R Harinath <rharinath@novell.com>
13091 First cut of the qualified-alias-member feature.
13092 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
13094 * cs-parser.jay (DOUBLE_COLON): New token.
13095 (namespace_or_type_name): Add rule for recognizing
13096 qualified-alias-members.
13097 (primary_expression): Likewise.
13098 (element_access): Allow QualifiedAliasMember as a possible
13099 type-bearing expression.
13100 (local_variable_type, local_variable_pointer_type): Likewise.
13101 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
13102 aliases in the current and enclosing namespace declarations.
13103 (NamespaceEntry.UsingAlias): Add CS0440 warning.
13104 * decl.cs (MemberName.is_double_colon): New.
13105 (MemberName.MemberName): Add new constructor for alias-member.
13106 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
13107 * expression.cs (QualifiedAliasMember): New expression type.
13109 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13111 * location.cs : it borked when no argument was specified.
13113 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13115 * location.cs : tiny ToString() format fix.
13117 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13119 * statement.cs : oops, it was missing.
13121 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13123 A set of fixes for precise line/column location.
13126 "token" field now holds a file/line "delta", a line number offset
13127 from the segment, and a column number. See also:
13128 http://lists.ximian.com/pipermail/mono-devel-list/2004-
13129 December/009508.html
13130 Removed static IsNull. Use instance IsNull property instead.
13131 * cs-tokenizer.cs :
13132 For some tokens it stores Location. For Identifier it stores
13133 LocatedToken which is a pair of string name and location.
13134 Column numbers are adjusted only at getChar().
13136 Use Location.ToString() for reporting (it now contains column).
13138 Largely modified to use LocatedToken instead of
13139 string (IDENTIFIER), and to acquire Location from some tokens.
13140 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
13141 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
13143 Now MemberName holds Location. DeclSpace.ctor() receives Location
13144 as a parameter. Removed extra parameters to all derived classes.
13145 Replaced Location.IsNull() with instance property.
13146 * assign.cs, expression.cs :
13147 Added .ctor() overload that omits Location.
13149 Added "nameEscaped" flag that indicates the identifier was escaped
13150 in the source file. This fixes bug #57047.
13152 2005-08-02 Marek Safar <marek.safar@seznam.cz>
13154 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
13155 New method, looking for lo-case imported cls type.
13157 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
13160 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
13162 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
13164 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
13165 all_imported_types.
13166 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
13168 Optimized to save 3.5 MB for SWF compilation.
13170 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13172 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
13173 (PartialContainer.Create): Moved logic AddToContainer.
13174 (PartialContainer.MarkForDuplicationCheck): Shares name.
13176 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
13179 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
13181 (Namespace.GetSignatureForError): New method.
13183 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
13184 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
13186 2005-08-01 Raja R Harinath <rharinath@novell.com>
13189 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
13190 member lookup rather than qualifier_type, since qualifier_type can
13193 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13195 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
13198 2005-07-31 Miguel de Icaza <miguel@novell.com>
13200 * statement.cs: Copy the local exception into the exception
13201 captured local. Fixes 75674
13203 2005-07-31 Raja R Harinath <harinath@gmail.com>
13206 * expression.cs (Invocation.OverloadResolve): Don't report error
13207 CS1501 if error CS1502 has been reported.
13208 (New.DoResolve): Delegate CS1501 reporting to
13209 Invocation.OverloadResolve.
13212 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
13213 invariant-meaning-in-block property in an enclosing block if
13216 2005-07-29 Marek Safar <marek.safar@seznam.cz>
13218 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
13219 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
13220 (Switch.CheckSwitch): Just save 50kb for SWF.
13222 2005-07-27 Martin Baulig <martin@ximian.com>
13224 * anonymous.cs (CaptureContext.AddField): Added
13225 `AnonymousContainer am' argument; compute its toplevel scope if
13226 it's not already computed. Fixes #75649.
13228 2005-07-26 Raja R Harinath <rharinath@novell.com>
13231 * class.cs (Constructor.Emit): Reset block to null if the block
13234 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13236 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
13238 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13240 * class.cs (MethodData.Define): Check whether accessor implementing
13241 interface is public.
13243 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
13245 2005-07-22 Marek Safar <marek.safar@seznam.cz>
13248 * namespace.cs (LookupType): Moved same type check to...
13250 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
13251 with the same name.
13253 2005-07-21 Raja R Harinath <rharinath@novell.com>
13255 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
13256 already found a typebuilder.
13257 * class.cs (MethodCore.IsDuplicateImplementation): Compare
13258 MemberNames, not strings.
13260 * const.cs (Error_ExpressionMustBeConst):
13261 Rename from Error_EpressionMustBeConst.
13262 * const.cs, class.cs, statement.cd: Update.
13264 2005-07-21 Marek Safar <marek.safar@seznam.cz>
13268 * const.cs (Const.LookupConstantValue): Report missing contant expression
13270 (Error_EpressionMustBeConstant): Only one error method.
13272 * class.cs, statement.c: Updated.
13274 2005-07-20 Raja R Harinath <rharinath@novell.com>
13276 * statement.cs (Block.Flags): Add back HasVarargs.
13277 (Block.flags): Make protected.
13278 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
13280 * typemanager.cs (types, typecontainers, user_types): Remove.
13281 (UserTypes, TypeContainers): Likewise.
13282 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
13283 (CleanUp, Reset): Update.
13284 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
13285 (GetNestedType): Use Type.GetNestedType.
13286 (CoreLookupType): Take two arguments, the namespace and the
13287 basename of the type. Update to use the Namespace.Lookup
13289 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
13290 (RealMemberLookup): Use IsNestedChildOf instead of playing with
13291 string concatenation and substring matches.
13292 * class.cs, enum.cs, delegate.cs: Update to changes.
13294 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13296 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13297 Expression and made virtual.
13299 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13300 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13302 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13304 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13307 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13310 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13313 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13314 AssemblyCultureAttribute is not used on executable.
13317 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13319 2005-07-16 Raja R Harinath <rharinath@novell.com>
13322 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13323 New. Reports CS0252/CS0253.
13324 Mostly taken from preliminary patch by Duncak Mak.
13325 (Binary.DoResolveOperator): Store results of operator lookup.
13326 Use them to detect if we need to warn about unintended reference
13329 2005-07-15 Raja R Harinath <rharinath@novell.com>
13332 * namespace.cs (Namespace.Lookup): Add back location parameter.
13333 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13334 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13336 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13337 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13338 (Namespace.LookupType): ... this.
13339 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13341 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13342 purported to handle pointers.
13343 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13346 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13348 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13351 2005-07-15 Raja R Harinath <rharinath@novell.com>
13353 * namespace.cs (Namespace.Lookup): Drop location parameter.
13354 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13355 (NamespaceEntry.Lookup): ... this.
13356 (NamespaceEntry.Error_AmbiguousTypeReference):
13357 Move here from DeclSpace.
13358 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13360 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13361 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13362 Move to NamespaceEntry.
13363 * delegate.cs, expression.cs: Update to changes.
13365 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13367 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13368 CheckAttributeType and refactored.
13369 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13370 ResolveAsTypeTerminal error handling.
13371 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13373 (GetSignatureForError): Print errors in same way.
13376 * codegen.cs: Reflect attribute GetSignatureForError change.
13379 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13381 * namespace.cs (UsingEntry): Refactored to make fields private.
13384 statement.cs: Error_UnexpectedKind has extra parameter.
13386 2005-07-14 Raja R Harinath <rharinath@novell.com>
13388 * ecore.cs (IAlias): Remove.
13389 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13390 that implement the interface.
13391 * namespace.cs (Namespace): Likewise.
13392 (Namespace.declspaces): Renamed from 'defined_names'.
13393 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13394 DeclSpace instead of an IAlias.
13395 * tree.cs (Tree.AddDecl): Update.
13397 2005-07-12 Raja R Harinath <rharinath@novell.com>
13399 * statement.cs (Block.Flags); Remove HasVarargs.
13400 (Block.HasVarargs): Move to ToplevelBlock.
13401 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13402 (Block.Variables): Make protected. Initialize variable hashtable
13404 (Block.AddVariable): Update.
13405 (Block.Resolve): Update to changes.
13406 (ToplevelBlock.HasVarargs): New boolean.
13407 (ToplevelBlock.ThisVariable): Move here from Block.
13408 (ToplevelBlock.AddThisVariable): Likewise.
13409 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13410 * expression.cs (This.ResolveBase): Update to changes.
13411 (ArglistAccess.DoResolve): Likewise.
13413 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13416 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13418 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13419 not used and not used & assigned.
13420 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13422 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13425 * expression.cs (Is.DoResolve): null is never provided type.
13427 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13430 * cs-parser.jay: Less strict event error rule to catch more errors.
13432 2005-07-08 Martin Baulig <martin@ximian.com>
13434 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13435 gettter (allowed) or setter (not allowed).
13437 * class.cs (Accessor): Implement IIteratorContainer.
13438 (Accessor.Yields): New public field.
13439 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13440 per-accessor basis.
13443 (get_accessor_declaration, set_accessor_declaration): Set the
13444 `yields' flag on the accessor, not the property.
13445 (property_declaration): Do the iterators check on a per-accessor
13446 basis and not for the whole property.
13448 2005-07-08 Martin Baulig <martin@ximian.com>
13450 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13451 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13453 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13456 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13457 (ExtractSecurityPermissionSet): Cope with self referencing security
13458 attributes properly.
13460 * driver.cs (SetOutputFile): Made public property OutputFile.
13462 2005-07-07 Raja R Harinath <rharinath@novell.com>
13465 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13466 has_nonstatic_fields. Make into a FieldBase pointer.
13467 (TypeContainer.AddField): Add CS0282 check.
13468 (TypeContainer.EmitType): Update.
13470 2005-07-06 Miguel de Icaza <miguel@novell.com>
13472 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13473 compare if they start with __.
13475 2005-07-06 Raja R Harinath <rharinath@novell.com>
13477 * statement.cs (Switch.SwitchGoverningType): Only look at
13478 UserCasts that don't need implicit standard conversions to one of
13479 the allowed switch types (Fixes test-322.cs).
13480 (LocalInfo.Resolve): Re-enable sanity-test.
13482 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13484 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13486 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13488 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13490 2005-07-06 Raja R Harinath <rharinath@novell.com>
13493 * ecore.cs (SimpleName.GetSignatureForError): Add.
13494 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13495 (MemberAccess.GetSignatureForError): Add.
13497 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13499 The big error and warning messages review.
13529 * typemanager.cs: Updated.
13531 * class.cs: (MethodCore.SetYields): Moved here to share.
13532 (PropertyMethod.Define): Moved iterator setup here.
13534 * iterators.cs: Add orig_method to have full access to parent
13537 2005-07-05 Raja R Harinath <rharinath@novell.com>
13539 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13540 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13541 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13542 variable of struct type.
13543 * expression.cs (Unary.ResolveOperator): Update to change.
13544 (Indirection.VerifyFixed): Likewise.
13545 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13546 (ParameterReference.VerifyFixed): Value parameters are fixed.
13547 (This.VerifyFixed): Treat 'this' as a value parameter.
13548 * statement.cs (LocalInfo.IsFixed): Remove.
13550 2005-07-01 Martin Baulig <martin@ximian.com>
13552 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13553 `ec.EmitThis ()' to get the correct scope.
13555 2005-07-01 Martin Baulig <martin@ximian.com>
13557 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13558 instance is a ParameterReference; fixes #75299.
13560 2005-07-01 Martin Baulig <martin@ximian.com>
13562 Reverted Marek's latest patch (r46725):
13563 - it contains structural changes which are neither mentioned in
13564 the ChangeLog nor explained anywhere; for example the additional
13565 argument of EmitContext's and Iterator's .ctor's and the
13566 TypeContainer.DefineMembers() change.
13567 - structural changes like this should go in in seperate patches
13568 and not be hidden in a huge patch which just seems to affect
13569 warnings and errors.
13570 a big and hard to understand patch.
13571 - it breaks iterators and causes regressions, for instance in
13574 2005-06-30 Raja R Harinath <rharinath@novell.com>
13577 * expression.cs (Indexers.map): Remove.
13578 (Indexers.Append): Filter out inaccessible setters and getters.
13579 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13582 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13583 Refactored from ...
13584 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13585 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13586 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13587 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13589 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13592 * class.cs (FieldBase.GetInitializerExpression): One more field
13595 2005-06-28 Miguel de Icaza <miguel@novell.com>
13597 * pending.cs: Do not define a proxy if the base method is virtual,
13598 it will be picked up by the runtime (bug 75270).
13600 2005-06-08 Martin Baulig <martin@ximian.com>
13602 The big Iterators rewrite :-)
13604 * iterators.cs: Rewrite this to use the anonymous methods framework.
13606 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13607 before the TypeContainers; see 2test-21.cs.
13610 (TypeContainer.DefineType): Don't create a new EmitContext if we
13611 already have one (this only happens if we're an Iterator).
13612 (TypeContainer.Define): Also call Define() on all our iterators.
13613 (Method.CreateEmitContext): Added support for iterators.
13616 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13617 (AnonymousContainer.CreateMethodHost): Moved here from
13618 AnonymousMethod and made abstract.
13619 (AnonymousContainer.CreateScopeType): New abstract method.
13620 (AnonymousContainer.IsIterator): New public property.
13621 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13622 get the ScopeTypeBuilder rather than manually defining it here.
13623 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13626 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13627 before RootContext.DefineTypes().
13629 * codegen.cs (EmitContext.RemapToProxy): Removed.
13630 (EmitContext.CurrentAnonymousMethod): Changed type from
13631 AnonymousMethod -> AnonymousContainer.
13632 (EmitContext.ResolveTopBlock): Protect from being called twice.
13633 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13634 (EmitContext.EmitThis): Removed the iterators hacks; use the
13635 anonymous methods framework for that.
13638 (ToplevelBlock.Container): Make this a property, not a field.
13639 (ToplevelBlock.ReParent): New public method; move the
13640 ToplevelBlock into a new container.
13641 (Foreach.TemporaryVariable): Simplify.
13643 2005-06-05 Martin Baulig <martin@ximian.com>
13645 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13646 (Block.AddTemporaryVariable): New public method; creates a new
13647 `LocalInfo' for a temporary variable.
13648 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13650 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13651 non-iterator variables.
13653 2005-06-05 Martin Baulig <martin@ximian.com>
13655 * statement.cs (Foreach.TemporaryVariable): Create the
13656 LocalBuilder in the Emit phase and not in Resolve since in some
13657 situations, we don't have an ILGenerator during Resolve; see
13658 2test-19.cs for an example.
13660 2005-06-04 Martin Baulig <martin@ximian.com>
13662 **** Merged r45395 from GCS ****
13664 The big Foreach rewrite - Part II.
13666 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13667 with `PropertyInfo ienumerator_getcurrent'.
13669 * codegen.cs (VariableStorage): Removed.
13672 (Foreach): Derive from Statement, not ExceptionStatement.
13673 (Foreach.CollectionForeach): New nested class. Moved all the code
13674 dealing with collection foreach here.
13675 (Foreach.ForeachHelperMethods): Removed.
13676 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13678 2005-05-23 Martin Baulig <martin@ximian.com>
13680 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13681 don't need to. Fix #75014.
13683 2005-05-20 Martin Baulig <martin@ximian.com>
13685 Merged r44808 from GMCS.
13687 * class.cs (TypeContainer.CircularDepException): Removed.
13688 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13689 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13690 (CS0146) and interface (CS0529) dependencies here.
13692 2005-06-21 Raja R Harinath <rharinath@novell.com>
13694 * expression.cs (Invocation.EmitCall): Fix initialization
13695 'this_call' to reflect current behaviour. Fix indentation.
13697 * convert.cs (FindMostEncompassedType): Add two trivial special
13698 cases (number_of_types == 0 || number_of_types == 1).
13699 (FindMostEncompasingType): Likewise.
13701 2005-06-17 Raja R Harinath <rharinath@novell.com>
13703 Some cleanups preparing for the fix of #75283.
13704 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13706 (EventExpr.InstanceResolve): Likewise.
13707 (EventExpr.DoResolve): Remove redundant checks.
13709 2005-06-10 Duncan Mak <duncan@novell.com>
13711 * cs-tokenizer.cs (process_directives): New flag for controlling
13712 the processing of preprocessor directives.
13713 (x_token): After seeing a '#', return Token.NONE instead of going
13714 to handle_preprocessing_directive() when not processing
13715 directives. This avoids unnecessary processing during the token peek in
13720 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13721 the existing error reporting methods instead of Report.Error.
13723 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13724 after Raja's rewrite.
13726 2005-06-08 Miguel de Icaza <miguel@novell.com>
13728 * class.cs: Small fix.
13730 2005-06-08 Raja R Harinath <rharinath@novell.com>
13733 * class.cs (GetPartialBases): Fix return value check of
13734 part.GetClassBases.
13736 2005-06-07 Raja R Harinath <rharinath@novell.com>
13738 Ensure that partial classes are registered in their enclosing
13739 namespace. Initial part of fix of #75160.
13740 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13741 Register declspace with namespace here, not in
13742 DeclSpace.RecordDecl.
13743 * cs-parser.jay: Pass namespace to RecordDecl.
13744 * class.cs (PartialContainer.Create): Likewise.
13745 (ClassPart.DefineType): New sanity-check. Throws an exception if
13747 * decl.cs (Declspace.RecordDecl): Remove.
13748 * namespace.cs (NamespaceEntry.DefineName): Remove.
13750 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13752 * rootcontext.cs: Reset TargetExt as well.
13754 2005-06-03 Raja R Harinath <rharinath@novell.com>
13756 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13757 -langversion:ISO-1.
13759 2005-06-02 Raja R Harinath <rharinath@novell.com>
13761 Fix #75080, cs0119.cs.
13762 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13764 (Expression.Resolve): ... this. Use it. Remove bogus code
13765 allowing ExprClass.Type and ExprClass.Namespace for
13766 ResolveFlags.VariableOrValue.
13767 (Expression.Resolve) [1-argument variant]: Change default resolve
13768 flags based on language version.
13769 (Expression.Error_UnexpectedKind): Use a simple string array
13770 rather than an ArrayList.
13771 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13772 not ExprClass.Type.
13773 (TypeOfVoid.DoResolve): Likewise.
13774 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13775 flags argument -- it always has the same value.
13777 2005-05-31 Raja R Harinath <rharinath@novell.com>
13780 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13781 Use it in the error message.
13782 * assign.cs, expression.cs, statement.cs: Update.
13784 2005-05-30 Raja R Harinath <rharinath@novell.com>
13787 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13788 the "almostMatchedMember" case too.
13789 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13790 that failed the accessibility checks to 'almost_match'.
13792 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13794 * attribute.cs: Use internal MethodBuilder methods to set
13795 ExactSpelling and SetLastError on PInvoke methods, instead
13796 of passing them via charset. Fixes #75060.
13798 2005-05-27 Raja R Harinath <rharinath@novell.com>
13800 * parameter.cs (Parameter): Remove TODO comment.
13801 (Parameter.DefineParameter): Remove Location parameter.
13802 (Parameters.LabelParameters): Likewise.
13803 * class.cs (Constructor.Emit): Update to change.
13804 (MethodData.Emit): Likewise.
13805 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13806 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13808 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13811 Removed Parameters.Location and added Parameter.Location instead.
13812 Removed Location parameter from Emit() and GetSignature().
13819 Modified all related calls.
13821 2005-05-26 Raja R Harinath <rharinath@novell.com>
13823 Improve user-defined conversion handling.
13824 * convert.cs (GetConversionOperators): Rewrite. Return only the
13825 applicable operators.
13826 (AddConversionOperators): New. Helper for GetConversionOperators.
13827 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13828 there is only one most encompassed/encompassing type.
13829 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13830 "applicable operator" handling.
13831 (UserConversion): Move cache here from GetConversionOperators.
13832 Directly cache the chosen operator, rather than the whole
13834 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13835 case. Allow conversion of decimal to sbyte and byte too.
13836 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13837 New static methods. Used to avoid allocating EmptyExpressions in
13840 2005-05-24 Duncan Mak <duncan@novell.com>
13842 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13843 another class, used in Convert.ExplicitNumericConversion.
13844 (CastToDecimal): New class, similar to above, but casts to
13845 System.Decimal, used in Convert.ImplicitNumericConversion and also
13846 in explicit convesion from double/float to decimal.
13848 * convert.cs (ImplicitNumericConversion): Handle implicit
13849 conversions to System.Decimal.
13850 (ExplicitNumericConversion): handle explicit conversions to
13855 2005-05-20 Miguel de Icaza <miguel@novell.com>
13857 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13858 know the type at this stage, just break through. Fixes #75008
13860 2005-05-19 Martin Baulig <martin@ximian.com>
13863 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13864 to disable error reporting.
13866 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13867 here since we don't want to report an error; see the new test-336.cs.
13869 2005-05-19 Raja R Harinath <rharinath@novell.com>
13871 * statement.cs (ToplevelBlock.GetParameterReference)
13872 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13873 Move here from class Block.
13874 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13875 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13877 2005-05-18 Martin Baulig <martin@ximian.com>
13882 (FlowBranching.Reachability): Add non-static public And() and Or()
13884 (FlowBranchingSwitch): New class; do the `break_origins' thing
13885 like in FlowBranchingLoop.
13886 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13887 reachability, not just locals and parameters.
13888 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13889 switch; MergeBreakOrigins() now takes care of that.
13891 2005-05-18 Martin Baulig <martin@ximian.com>
13893 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13894 a loop and may leave it, reset the barrier; fixes #74974.
13896 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13898 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13901 * cs-parser.jay: Catch more lexical errors.
13903 * report.cs: Add one more Error method.
13906 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13908 2005-05-17 Martin Baulig <martin@ximian.com>
13910 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13913 2005-05-16 Raja R Harinath <rharinath@novell.com>
13915 Fix test-382.cs. Emit values of decimal constants.
13916 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13918 (TypeContainer.AddField): ... this.
13919 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13920 with initializers to include 'Const's.
13921 (ClassPart.RegisterFieldForInitialization): Forward to
13923 * const.cs (Const.Const): Pass initializer to base class.
13924 (Const.Define): In case of decimal constants, register them for
13925 initialization in a static constructor.
13927 2005-05-14 Martin Baulig <martin@ximian.com>
13929 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13930 do not call ResolveUnreachable() on unreachable statements in
13931 here, see the comment in the source code.
13933 2005-05-13 Raja R Harinath <rharinath@novell.com>
13936 * expression.cs (BinaryResolveOperator): If one of the operands of
13937 an equality comparison is 'null' and the other is a pointer type,
13938 convert the null to a NullPointer.
13939 * convert.cs (ImplicitReferenceConversion): If the expression is a
13940 NullLiteral and the target type is a pointer type, return a
13941 NullPointer instead.
13942 (ImplicitConversionStandard): Likewise.
13944 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13946 * cs-parser.jay: Set readonly context based on special constructs.
13948 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13949 readonly variable error handling.
13951 * rootcontext.cs (EmitCode): Don't verify members when error
13954 * statement.cs (LocalInfo): Add reaodnly context information.
13955 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13957 2005-05-13 Raja R Harinath <rharinath@novell.com>
13959 * statement.cs (Block.Resolve): Revert change below. Modify fix
13960 for #74041 to initialize 'resolved' to false only for explicit
13961 blocks. Fixes #74873.
13963 2005-05-12 Raja R Harinath <harinath@gmail.com>
13966 * typemanager.cs (unmanaged_enclosing_types): New.
13967 (IsUnmanagedType): Avoid infloops by using
13968 'unmanaged_enclosing_types' to talk with recursive invocations.
13970 2005-05-13 Martin Baulig <martin@ximian.com>
13972 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13973 instance variable, not a local. Fix #74873.
13974 (Block.ResolveUnreachable): Set it to true here.
13976 2005-05-11 Duncan Mak <duncan@novell.com>
13978 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13979 continuing to process for 'arg'.
13980 (handle_preprocessing_directive): Check the argument of the #endif
13981 directive and report error CS1025 if there are any trailing
13984 According to the C# spec, having even whitespace after the #endif
13985 directive is illegal; however, because we call arg.TrimEnd ()
13986 beforehand, we have the same behavior as csc, allowing whitespace
13987 after the directive.
13991 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13995 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13996 (Constructor.GetObsoleteAttribute): Implemented correctly.
13998 2005-05-10 Martin Baulig <martin@ximian.com>
14000 * support.cs (ReflectionParameters.ParameterModifier): Use
14001 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
14002 and `ParameterAttributes.In'. Fixes #74884.
14004 2005-05-10 Marek Safar <marek.safar@seznam.cz>
14006 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
14008 * expression.cs (Argument.GetParameterModifier): Turned to property.
14009 (Invocation.Error_InvalidArguments): Add more descriptive errors.
14011 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
14014 2005-05-09 Raja R Harinath <rharinath@novell.com>
14017 * decl.cs (MemberCache.AddMethods): Register override methods,
14018 rather than non-override methods.
14019 * typemanager.cs (RegisterOverride): New.
14020 (IsOverride): Update.
14022 2005-05-09 Marek Safar <marek.safar@seznam.cz>
14026 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
14027 recursive declaration.
14029 * statement.cs (Block.ResolveMeta): Report any error in resolving.
14031 2005-05-06 Marek Safar <marek.safar@seznam.cz>
14033 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
14035 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
14037 2005-05-05 Raja R Harinath <rharinath@novell.com>
14040 * decl.cs (DeclSpace.FamilyAccessible):
14041 Use TypeManager.IsNestedFamilyAccessible.
14043 Fix reopened #64812.
14044 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
14047 2005-05-04 Raja R Harinath <rharinath@novell.com>
14048 Abin Thomas <projectmonokochi@rediffmail.com>
14049 Anoob V E <projectmonokochi@rediffmail.com>
14050 Harilal P R <projectmonokochi@rediffmail.com>
14053 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
14054 allow access to all static members.
14056 2005-05-04 Martin Baulig <martin@ximian.com>
14058 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
14060 2005-05-04 Martin Baulig <martin@ximian.com>
14064 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
14065 section at the end; make things work if `default' is not the last
14068 2005-05-04 Martin Baulig <martin@ximian.com>
14072 * statement.cs (Switch): Replaced the `got_default' field with a
14073 `default_section' one.
14074 (Switch.CheckSwitch): Set `default_section' here.
14075 (Switch.Resolve): If we're a constant switch and the constant is
14076 not found, use the default section.
14078 2005-05-03 Martin Baulig <martin@ximian.com>
14080 * expression.cs (ArrayAccess.EmitGetLength): New public method.
14082 * statement.cs (Foreach.ArrayForeach): New nested class.
14083 (Foreach.TemporaryVariable): New nested class.
14084 (Foreach.EmitArrayForeach): Removed; this is now in the new
14085 ArrayForeach class.
14087 2005-05-03 Raja R Harinath <rharinath@novell.com>
14089 * pending.cs (BaseImplements): Move the #74773 fix here. This is
14091 (VerifyPendingMethods): Revert change below.
14093 * typemanager.cs (IsOverride, RegisterNonOverride): New.
14094 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
14095 that used to trigger warning -28. Remove warning -28.
14096 * expression.cs (Invocation.OverloadResolve): Use
14097 TypeManager.IsOverride to distinguish override methods.
14100 * pending.cs (VerifyPendingMethods): If a base type implements the
14101 requested interface, don't bother checking individual methods of
14102 the base type. As a side-effect, this prevents the creation of
14103 unnecessary proxies.
14105 2005-05-02 Martin Baulig <martin@ximian.com>
14109 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
14110 Also `And' the locals if the old vector is null.
14111 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
14112 null; in this case we basically reset all the variables.
14114 2005-05-02 Martin Baulig <martin@ximian.com>
14118 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
14119 Added `FlowBranching branching' argument; always `and' the
14120 variables instead of `or'ing them unless we're an infinite loop.
14122 * statement.cs (While.Resolve): Create a new sibling unless we're
14125 2005-05-02 Martin Baulig <martin@ximian.com>
14129 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
14130 arguments; use it instead of creating a new TopLevelBlock.
14131 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
14132 our ConstructorInitializer.
14135 (TopLevelBlock.TopLevelBranching): New public property.
14136 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
14137 and create our `TopLevelBranching'.
14139 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
14140 anonymous method host, use `block.TopLevelBranching' rather than
14141 creating a new branching.
14143 2005-04-20 Miguel de Icaza <miguel@novell.com>
14145 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
14146 a ScopeInfo, if any of the current children is a child of the new
14147 entry, move those children there.
14149 2005-04-30 Martin Baulig <martin@ximian.com>
14151 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
14152 at the beginning of a SwitchSection. Fix #73335.
14154 2005-04-27 Marek Safar <marek.safar@seznam.cz>
14157 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
14159 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
14160 (FieldExpr.DoResolve): Obsolete members are ignored for field
14163 2005-04-26 Marek Safar <marek.safar@seznam.cz>
14165 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
14166 of arrays detection.
14168 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
14170 (Field.VerifyClsCompliance): Volatile fields are not compliant.
14172 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
14175 2005-04-25 Ben Maurer <bmaurer@ximian.com>
14177 * cs-parser.jay: Use the prefered version of -unsafe in error
14180 2005-04-22 Marek Safar <marek.safar@seznam.cz>
14182 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
14185 2005-04-20 John Luke <john.luke@gmail.com>
14187 * driver.cs: fix typo in error message, --outout to --output
14189 2005-04-20 Marek Safar <marek.safar@seznam.cz>
14191 * codegen.cs (InRefOutArgumentResolving): New field.
14193 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
14194 fields outside contructor.
14196 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
14198 2005-04-19 Miguel de Icaza <miguel@novell.com>
14200 * anonymous.cs (CaptureContext.EmitParameterInstance): The
14201 parameter code was not completed ever, so it was not as up-to-date
14202 as local variables. Must finish it.
14204 The bug fix was to compare the Toplevel of the block, not the
14205 current block. Thanks for Ben for pointing this out.
14207 2005-04-19 Raja R Harinath <rharinath@novell.com>
14209 * decl.cs (AddMethods): Use the declaring type of the problem
14210 method to determine if we want to squash a warning.
14212 2005-04-19 Marek Safar <marek.safar@seznam.cz>
14214 * attribute.cs: Removed debug output.
14216 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
14218 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
14221 2005-04-18 Raja R Harinath <rharinath@novell.com>
14224 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
14225 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
14226 all null comparisons against reference types.
14228 2005-04-18 Marek Safar <marek.safar@seznam.cz>
14231 * class.cs (TypeContainer.CircularDepException) New nested
14233 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
14234 (TypeContainer.DefineType): Removed error, reset InTransit before
14236 (Class.DefineType): Throw exception when is in Transit.
14237 Catch exception and report error.
14238 (Struct.DefineType): Throw exception when is in Transit.
14239 Catch exception and report error.
14240 (Interface.DefineType): Throw exception when is in Transit.
14241 Catch exception and report error.
14243 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
14244 handle nested exception handlers.
14246 * flowanalysis.cs (InTryWithCatch): New method, search for try with
14249 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
14250 InFinally and InCatch storage.
14252 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
14253 (Catch.Resolve): Set and Restore ec.InCatch.
14254 (Try.Resolve): Set and Restore ec.InFinally.
14255 (Try.HasCatch): True when try has catch.
14257 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
14259 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
14260 for the same event member, so exclude such cases from warning 419.
14263 2005-04-16 Miguel de Icaza <miguel@novell.com>
14265 * expression.cs (Binary.ResolveOperator): Apply patch from John
14266 Luke to fix bug 59864: operators &, | and ^ on enumerations
14267 require that the same enum type on both sides.
14269 * driver.cs: Add warnings to old flag usage, this is to assist
14270 people who produce Makefiles and hope that the Makefiles will be
14273 * class.cs (TypeContainer.EmitType): Moved the definition of the
14274 special $PRIVATE$ field from the resolve phase to the Emit phase.
14275 During resolve we do not know if we are a struct with
14276 HasExplicitLayout, we know this only after the attributes for the
14279 Set the FieldOffset to zero on the dummy field that we create for
14280 the class. Fixes 74590.
14282 2005-04-16 Raja R Harinath <rharinath@novell.com>
14285 * ecore.cs (PropertyExpr.resolved): New.
14286 (DoResolve): Use it to handle a case of double resolution here.
14287 Handle a case of identical-name-and-type-name.
14288 * expression.cs (ArrayCreation.CheckIndices): Avoid double
14289 resolution by storing the results of expression resolution back
14290 into the "probes" array.
14292 2005-04-15 Raja R Harinath <rharinath@novell.com>
14294 Fix cs0208-7.cs and cs0208-8.cs.
14295 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14296 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14297 error reporting to point out the reason a struct is not unmanaged.
14299 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14301 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14302 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14304 2005-04-13 Raja R Harinath <rharinath@novell.com>
14307 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14308 IdenticalNameAndTypeName here.
14309 (EventExpr.InstanceResolve): Likewise.
14311 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14313 C# 2.0 DefaultCharSetAttribute implementation
14315 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14316 which allows us to set GlobalNamespace for every resolve.
14317 (Attribute.ResolveArguments): Cut from Resolve.
14318 (Attribute.GetCharSetValue): Returns CharSet named argument.
14319 (Attribute.DefinePInvokeMethod): Gets default charset from
14321 (GlobalAttribute.ResolveAsTypeStep): Override.
14322 (GlobalAttribute.ResolveArguments): Override.
14324 * class.cs (TypeAttr): Is protected.
14326 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14327 (ModuleClass.DefaultCharSetType): New memeber.
14328 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14330 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14331 charset from module.
14333 * delegate.cs (TypeAttr): Override.
14334 (Delegate.DefineType): Use this TypeAttr.
14336 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14337 at very early stage (before types are defined) to resolve model
14338 module attributes. It will probably not work with corlib but it
14341 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14342 charset from module.
14344 * typemanager.cs (default_charset_type): New type.
14346 2005-04-13 Raja R Harinath <rharinath@novell.com>
14348 * decl.cs (MemberCache.AddMethods): Don't warn if
14349 System.Object.Finalize has buggy MethodAttributes.
14351 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14354 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14356 * doc.cs : detect ambiguous reference to overloaded members.
14357 Fixed bug #71603. MS 1.1 csc does not detect it.
14359 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14361 * doc.cs : delegates must not be referenced with parameters.
14364 2005-04-12 Miguel de Icaza <miguel@novell.com>
14366 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14368 2005-04-10 Miguel de Icaza <miguel@novell.com>
14370 * driver.cs (MainDriver): Stop processing if the CLS stage found
14373 (CompilerCallableEntryPoint.InvokeCompiler): Always
14374 reset after execution; Take a TextWriter argument for the
14377 * report.cs: Use the error stream instead of hardcoding stderr.
14379 2005-04-09 Miguel de Icaza <miguel@novell.com>
14381 * class.cs: Reduce code paths to test, too small of an
14382 optimization to make it worth the extra testing. Always perform
14385 2005-04-08 Raja R Harinath <rharinath@novell.com>
14388 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14389 operators that had errors reported on them.
14391 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14393 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14395 (Attribute.Resolve): Add named argument type checking.
14397 * class.cs (FixedField.Define): Use IsPrimitiveType
14399 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14401 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14402 unsafe parameter types.
14404 * statement.cs (Using.ResolveExpression): Add better error description.
14406 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14408 2005-04-08 Raja R Harinath <rharinath@novell.com>
14411 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14412 AttributeUsageAttribute in the emitcontext of the attribute class,
14413 not in the emitcontext of the attributable entity it was attached to.
14414 * cs-parser.jay: Use 'current_class', not 'current_container',
14415 when creating a GlobalAttribute.
14417 2005-04-08 Alp Toker <alp@atoker.com>
14419 * pending.cs: The fix to #58413 failed to compile methods implementing
14420 interfaces with/without params modifiers and vice versa, even though
14421 params modifiers aren't part of the signature. Make the modifier check
14422 less strict as in csc.
14424 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14425 Anoob V E <projectmonokochi@rediffmail.com>
14426 Harilal P R <projectmonokochi@rediffmail.com>
14429 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14430 modifiers of pending methods.
14431 (PendingImplementation.PendingImplementation): Initialize it.
14432 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14433 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14434 with ParameterData. Add check for modifiers.
14435 * class.cs (MethodData.Define): Update to changes.
14437 2005-04-07 Raja R Harinath <rharinath@novell.com>
14439 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14441 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14443 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14446 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14449 * typemanager.cs: Registered RequiredAttributeAttribute.
14451 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14453 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14454 Warning CS0169 is back at level 3.
14455 (IMethodData.SetMemberIsUsed): New method.
14457 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14458 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14460 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14462 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14464 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14467 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14470 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14471 to avoid the problems with nested types.
14473 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14474 Anoob V.E <projectmonokochi@rediffmail.com>
14475 Harilal P.R <projectmonokochi@rediffmail.com>
14476 Raja R Harinath <rharinath@novell.com>
14479 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14481 * typemanager (GetConstructor): Make public.
14483 2005-04-05 John Luke <john.luke@gmail.com>
14484 Raja R Harinath <rharinath@novell.com>
14487 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14488 struct too. Return false quicker in a few cases.
14489 (VerifyUnManaged): Use it.
14491 2005-04-05 Raja R Harinath <rharinath@novell.com>
14494 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14495 not 'unreachable_seen'.
14497 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14499 * attribute.cs (Attribute.GetValue): Removed unused.
14501 * codegen.cs (CodeGen.TrimExt): Removed unused.
14503 * cs-parser.jay (output): Removed unused.
14505 * cs-tokenizer.cs (hex_digits): Removed unused.
14507 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14509 * expression.cs (Indirection.LoadExprValue): Removed unused.
14510 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14512 * iterators.cs (Iterator.param_types): Removed unused.
14514 * statement.cs (Goto.block): Removed unused.
14515 (ToplevelBlock.did): Removed unused.
14516 (Switch.ResolveConstantSwitch): Removed unused.
14518 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14520 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14523 2005-04-01 Raja R Harinath <rharinath@novell.com>
14525 Fix #74232 and cs0208-3.cs.
14526 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14527 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14528 unmanaged type. Don't use FieldBuilders when 't' is a
14529 TypeBuilder. Use ModFlags and MemberType fields.
14530 * class.cs (MemberBase.member_type): Rename from MemberType.
14531 (MemberBase.MemberType): New property. Determines member_type on
14533 (MemberBase.DoDefine): Don't initialize MemberType here.
14534 (FieldMember.Define): Likewise.
14536 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14539 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14540 Attributes are emitted there.
14542 2005-04-01 Raja R Harinath <rharinath@novell.com>
14544 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14545 keyword in 'partial enum' too.
14546 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14548 Report from Kamil Skalski <nazgul@omega.pl>.
14551 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14552 have partial containers too.
14554 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14555 in block' checks to Block.CheckInvariantMeaningInBlock.
14556 * statement.cs (Block.GetKnownVariableInfo): Make private.
14557 (Block.IsVariableUsedInChildBlock): Remove.
14558 (Block.IsVariableUsedInBlock): Likewise.
14559 (Block.CheckInvariantMeaningInBlock): New. Show location of
14560 conflicting declaration.
14561 (Block.AddVariable): Make error messages less long-winded and more
14562 specific. Show location of conflicting declaration.
14563 * parameter.cs (Parameters.Location): New readonly property.
14565 2005-03-31 Raja R Harinath <rharinath@novell.com>
14567 Clean up semantics of invoking ResolveMemberAccess.
14568 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14569 can have an instance, ensure that we pass in a non-TypeExpression
14570 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14571 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14572 argument. Update to changes and simplify.
14573 (FieldExpr.Emitinstance): Remove CS0120 check.
14574 (PropertyExpr.EmitInstance): Likewise.
14575 * expression.cs (Argument.Resolve): Likewise.
14576 (Invocation.DoResolve): Update to changes in semantics of
14577 InstanceExpression.
14579 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14582 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14585 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14587 2005-03-31 Raja R Harinath <rharinath@novell.com>
14589 Fix difference in behaviour with commandline invocation.
14590 * driver.cs (Driver.Reset): New.
14591 (CompilerCallableEntryPoint): Call it.
14593 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14594 variable" warnings if the boolean expression failed to resolve.
14596 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14598 * attribute.cs: Fix the union of several permissions when some of them
14599 are unrestricted (so the result isn't an unrestricted permission set).
14602 2005-03-30 Raja R Harinath <rharinath@novell.com>
14604 * ecore.cs (MemberExpr): New class. Convert from interface
14606 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14607 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14609 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14610 (MethodGroupExpr.IsExplicitImpl): Remove.
14611 (Expression.GetFieldFromEvent): Remove.
14612 (SimpleName.MemberStaticCheck): Remove.
14613 (SimpleName.DoSimpleNameResolve): Update to changes.
14614 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14615 (MemberAccess.IdenticalNameAndTypeName): Remove.
14616 (MemberAccess.error176): Move to MemberExpr.
14617 (MemberAccess.DoResolve): Update to changes.
14618 (BaseAccess.DoResolve): Likewise.
14620 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14622 C# 2.0 Conditional attribute class implementation
14624 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14625 Analyzes class whether it has attribute which has ConditionalAttribute
14626 and its condition is not defined.
14628 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14629 (Class.IsExcluded): New method. Search for at least one defined
14630 condition in ConditionalAttribute of attribute class.
14632 2005-03-30 Raja R Harinath <rharinath@novell.com>
14634 * ecore.cs (PropertyExpr): Derive from Expression, not
14635 ExpressionStatement.
14636 (PropertyExpr.EmitStatement): Remove.
14638 2005-03-29 Raja R Harinath <rharinath@novell.com>
14641 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14642 internal field "value__" of an enum be private. The examples for
14643 "value__" that I found on MSDN all used FieldAttributes.Private.
14645 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14646 Don't mention IL method attribute names.
14648 Fix #47991. Remove a TODO.
14649 * statement.cs (Block.Toplevel): Make into a field.
14650 (Block.Parameters): Move into ToplevelBlock.
14651 (Block.known_variables): Rename from child_variable_names.
14652 (Block.Block): Remove variants that take Parameters. Initialize
14653 'Toplevel' with the immediately surrounding toplevel block.
14654 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14655 LocalInfo parameter.
14656 (Block.GetKnownVariableInfo): New.
14657 (Block.IsVariableNameUsedInChildBlock): Update.
14658 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14659 the block, even though it may not be in scope.
14660 (Block.AddVariable): Remove Parameters parameter. Use
14661 Toplevel.Parameters instead.
14662 (Block.AddConstant): Remove Parameters parameter.
14663 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14664 (Block.IsParamaterReference): Likewise.
14665 (Block.IsLocalParameter): Likewise. Simplify a lot.
14666 (ToplevelBlock.Parameters): New. Moved from Block.
14667 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14668 initialize Parameters to a non-null value.
14669 * cs-parser.jay: Update to changes.
14670 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14671 simple names that mean different things in the same block. Use
14672 Block.IsVariableNameUsedInBlock.
14674 2005-03-28 Raja R Harinath <rharinath@novell.com>
14676 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14677 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14678 GetTypeHandle. It is possible for a reflected type to derive from
14679 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14680 System.Array during mscorlib compilation).
14681 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14682 contain a method_hash, don't create one either. Don't create a
14683 deep copy of the base cache's method_hash.
14684 (MemberCache.SetupCache): Rename back from DeepCopy.
14685 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14686 already initialized. If we see an override function, add its
14687 underlying base virtual function to the member_hash too.
14689 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14691 2005-03-26 Raja R Harinath <harinath@acm.org>
14694 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14695 fails to resolve, ensure that the LHS is still resolved as an
14698 2005-03-25 Raja R Harinath <harinath@acm.org>
14700 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14702 (Enum.current_ec): Remove.
14703 (Enum.LookupEnumValue): Remove EmitContext argument.
14704 Just uses the one created during DefineType.
14705 (Enum.FindMembers): Update.
14706 * expression.cs (MemberAccess.DoResolve): Update.
14708 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14710 * assign.cs (Assign.DoResolve): Check for CS1717 when
14711 source and target are same (uses Equals).
14713 * expression.cs (LocalVariableReference, ParameterReference,
14714 This): Implemented Equals, GetHashCode.
14716 * statement.cs (Block.GetParameterReference): Removed useless
14719 2005-03-22 Raja R Harinath <rharinath@novell.com>
14722 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14723 blocks before deciding whether the error is cs0136 or cs0128.
14725 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14726 (using_alias_directive, using_namespace_directive): Pass
14727 MemberName, not an expression to Namespace.UsingAlias and
14729 (MakeName): Use the MemberName of the namespace.
14730 * namespace.cs (Namespace.MemberName): New.
14731 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14732 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14734 * decl.cs (MemberName.Name): Make readonly.
14735 (MemberName.FromDotted): New "constructor".
14736 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14737 (MemberCore.Name): Compute from MemberName on demand.
14738 (MemberCore.SetMemberName): Provide a way to change the
14740 (MemberCore.AddToContainer): Don't take a fullname parameter.
14741 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14742 fully qualified name of the container to the member name.
14743 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14744 only if the type is a member of the root container.
14745 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14746 MemberName.Left rather than searching for an embedded ".".
14747 (PartialContainer.CreatePart): Update to changes in RootContext.
14748 (MemberBase.ShortName): Turn into a property. Use
14749 MemberCore.SetMemberName.
14750 (MemberBase.ExplicitInterfaceName): Remove.
14751 (MemberBase.UpdateMemberName): Remove.
14752 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14753 (PropertyBase.SetMemberName): New override.
14754 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14755 (Tree.GetDecl): New.
14756 (Tree.AllDecls): Rename from Decls.
14757 * attribute.cs, enum.cs, report.cs: Update to changes.
14758 * driver.cs (MainDriver): Use MemberName.FromDotted on
14759 RootContext.MainClass.
14761 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14763 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14766 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14768 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14770 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14771 property accessor modifiers.
14773 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14774 fixed buffer attribute (CS1716).
14775 (PropertyMethod.HasCustomAccessModifier): When property accessor
14776 has custom modifier.
14778 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14780 (PropertyExpr.DoResolveLValue): Add CS0272.
14782 2005-03-17 Miguel de Icaza <miguel@novell.com>
14784 * convert.cs: When converting to a pointer, use the proper Conv.U
14785 or Conv.I depending on the source data type.
14787 * cs-tokenizer.cs: Make the size for large decimal constants,
14790 2005-03-17 Martin Baulig <martin@ximian.com>
14792 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14793 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14795 2005-03-17 Martin Baulig <martin@ximian.com>
14797 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14798 to bool so we can return an error condition.
14799 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14802 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14804 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14807 2005-03-16 Raja R Harinath <rharinath@novell.com>
14809 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14810 Refactor to avoid traversing the list of assemblies, and to avoid
14811 string concatenation.
14812 * typemanager.cs (guid_attr_type): Remove.
14813 (negative_hits, pointers, references): Remove hashes.
14815 (GetConstructedType): New. Uses type_hash to handle constructed
14816 types (arrays, references, pointers).
14817 (GetReferenceType, GetPointerType): Use it.
14818 (GetNestedType): New. Uses type_hash to handle nested types of
14820 (LookupType, LookupTypeDirect): Remove.
14821 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14822 'types' hash and LookupTypeReflection directly.
14823 (params_string, params_object): Use GetConstructedType.
14824 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14826 (Namespace.Lookup): Use cached_types.
14827 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14828 provided by old TypeManager.LookupType.
14829 * rootcontext.cs (MakeFQN): Remove.
14830 * decl.cs (DeclSpace.MakeFQN): Likewise.
14831 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14832 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14833 TypeManager.GetConstructedType.
14834 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14836 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14838 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14841 * cs-parser.jay: Reports CS1527 for any namespace element.
14843 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14846 * expression.cs (ParameterReference.IsAssigned): Changed error to
14848 (Error_WrongNumArguments): Moved CS0245 detection here.
14850 * statement.cs (Return.Resolve): Add CS1622 report.
14852 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14854 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14856 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14858 * attribute.cs expression.cs: Get rid of some allocations.
14860 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14862 * doc.cs : just eliminate the latest change.
14864 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14866 * doc.cs : commented out the latest change. It breaks xml-030.cs
14868 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14870 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14871 fail. So invoke CreateType() in FindDocumentedType().
14873 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14875 * cs-tokenizer.cs : added IsKeyword().
14876 * doc.cs : Detect keyword incorrectly used as identifier.
14877 Allow identifiers prefixed by @.
14879 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14881 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14882 It caused exception in namespace resolving (again!).
14884 * class.cs (Class.ctor): Removed exit.
14885 (PropertyMethod.ctor): ditto.
14887 * codegen.cs (Codegen.Reset): Reset static data.
14888 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14890 * cs-tokenizer.cs (Cleanup): Removed.
14892 * driver.cs (GetSystemDir): Rewrote to one line command.
14893 It caused problem with unloaded dynamic modules.
14894 (UnixParseOption): Removed Exit.
14895 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14896 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14897 Now can be mcs used as library.
14899 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14902 * location.cs (Reset): Reset static data.
14904 * namespace.cs (Reset): Reset static data.
14906 * report.cs (Report.Reset): Reset static data.
14908 * rootcontext.cs (RootContext.Reset): Reset static data.
14910 * tree.cs (RootTypes.ctor): Use Location.Null
14912 * typemanager.cs (TypeManager.Reset): Reset static data.
14913 (CoreLookupType): Removed Exit.
14914 (TypeHandle.Reset): Reset static data.
14916 2005-03-10 Raja R Harinath <rharinath@novell.com>
14919 * typemanager.cs (ComputeNamespaces): Import namespaces from
14920 referenced modules too.
14922 2005-03-09 Raja R Harinath <rharinath@novell.com>
14924 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14927 2005-03-09 Raja R Harinath <rharinath@novell.com>
14929 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14930 enclosing DeclSpace. This ensures that a name-lookup populates
14931 more caches and there are fewer 'TypeExpression's. Carve out
14932 nested type lookup into ...
14933 (LookupNestedTypeInHierarchy): ... this.
14935 2005-03-09 Raja R Harinath <rharinath@novell.com>
14937 Clean up a few partial-class semantics.
14938 Fixes test-357.cs and cs1618-2.cs.
14939 * cs-parser.jay (struct_declaration): Use 'current_class' as
14940 parent of newly-created struct. Remove call to Register ().
14941 Use 'pop_current_class' to complete handing the current struct.
14942 (interface_declaration): Likewise.
14943 (class_declaration): Likewise.
14944 (enum_declaration): Use 'current_class' as parent of newly created
14946 (delegate_declaration): Likewise.
14947 (pop_current_class): New function. This is used to handle closing
14948 up the 'current_class' and 'current_container', and pointing them
14949 to the enclosing class/container.
14950 (CSharpParser): Initialize 'current_class' too.
14951 * decl.cs (MemberCore): Add check for invariant: a partial
14952 container is not a parsed entity, and thus does not enclose any
14954 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14955 (DeclSpace.BaseTypeExpr): Use it.
14956 (DeclSpace.LookupType): Add check for invariant.
14957 * class.cs (TypeContainer): Add check for invariant: a nested
14958 class should have the same NamespaceEntry as its enclosing class.
14959 (TypeContainer.EmitFieldInitializers): Make virtual.
14960 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14962 (TypeContainer.Register): Remove.
14963 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14964 null. Use TypeResolveEmitContext for resolving base types and
14965 interfaces. Move initialization of Parts.TypeBuilder here from
14967 (TypeContainer.DefineNestedTypes): ... here.
14968 (PartialContainer): Take a Namespace not a NamespaceEntry.
14969 (PartialContainer.Create): Don't use Register. Call the
14970 appropriate Add... function directly.
14971 (ClassPart): Take both the PartialContainer and the enclosing
14972 class as constructor arguments.
14973 (ClassPart.EmitFieldInitializers): Override.
14974 (ClassPart.PartFindNestedTypes): Remove.
14975 (FieldBase.GetInitializerExpression): Resolve the initializer
14976 expression in the emit context of the enclosing class.
14977 * tree.cs (RootTypes): Remove Register ().
14979 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14981 * cs-parser.jay: Removed CS0134.
14983 * driver.cs: Removed CS1901.
14985 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14986 for predefined types.
14988 2005-03-07 Duncan Mak <duncan@novell.com>
14990 * codegen.cs (Save): Catch UnauthorizedAccessException as
14991 well. Fixes bug #73454.
14993 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14995 * cs-tokenizer.cs (xtoken): Add CS1035.
14997 * class.cs (MethodData.Define): Add CS0683.
14998 (FieldMember.ctor): Add CS0681.
15000 2005-03-07 Raja R Harinath <rharinath@novell.com>
15002 * ecore.cs (SimpleName.DoResolve): Rename from
15003 SimpleName.DoResolveAllowStatic.
15004 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
15005 Pass 'intermediate' flag to MemberStaticCheck.
15006 (SimpleName.MemberStaticCheck): Skip "static check" only in case
15007 of "intermediate" lookups via MemberAccess.
15008 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
15009 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
15011 2005-03-07 Raja R Harinath <rharinath@novell.com>
15014 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
15015 slipped in because of variable names that are identical to a
15016 builtin type's BCL equivalent ('string String;', 'int Int32;').
15017 (PropertyExpr.EmitInstance): Likewise.
15019 2005-03-04 Marek Safar <marek.safar@seznam.cz>
15021 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
15023 * report.cs (warning_ignore_table): Made public.
15025 2005-03-04 Raja R Harinath <rharinath@novell.com>
15028 * class.cs (MethodData.Emit): Pass 'container' to
15029 container.GetObsoleteAttribute instead of 'container.Parent'.
15031 2005-03-03 Marek Safar <marek.safar@seznam.cz>
15033 * cs-parser.jay: Add 1534 error test.
15035 * iterators.cs (Yield.CheckContext): Add error 1629.
15036 (Iterator.ctor): Save unsafe modifier.
15037 (MoveNextMethod.DoEmit): Restore unsafe context.
15039 * namespace.cs (UsingAlias): Better error message.
15041 2005-03-03 Dan Winship <danw@novell.com>
15043 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
15044 the warning message [#73219]
15046 2005-03-03 Raja R Harinath <rharinath@novell.com>
15048 Fix compile with MCS 1.0.0.0.
15049 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
15050 w_restore to not depend on string constant folding.
15052 2005-03-03 Raja R Harinath <rharinath@novell.com>
15054 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
15055 CS0246 check to users who passed 'silent = false'.
15056 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
15058 (SimpleName.SimpleNameResolve): Update.
15059 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
15060 (MemberAccess.IdenticalNameAndTypeName): Update.
15061 * doc.cs (FindDocumentedTypeNonArray): Update.
15063 2005-03-03 Raja R Harinath <rharinath@novell.com>
15065 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
15066 * parameters.cs (ComputeAndDefineParameters): Remove.
15067 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
15068 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
15069 Use GetParameterInfo.
15071 2005-03-02 Marek Safar <marek.safar@seznam.cz>
15073 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
15075 2005-03-02 Raja R Harinath <rharinath@novell.com>
15077 Unify DeclSpace.LookupType and DeclSpace.FindType.
15078 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
15079 is in charge of defining nested types on demand.
15080 (DeclSpace.LookupType): Use it when the current_type is a
15081 TypeBuilder. Use LookupTypeDirect for reflected types.
15082 (DeclSpace.FindType): Remove.
15083 (DeclSpace.LookupInterfaceOrClass): Likewise.
15084 (DeclSpace.DefineTypeAndParents): Likewise.
15085 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
15086 DeclSpace.LookupType.
15087 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
15088 * typemanager.cs (LookupType): Simplify.
15089 (AddUserType): Remove type from negative_hits.
15090 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
15091 * class.cs (TypeContainer.FindMembers): Move handling of nested
15093 (TypeContainer.FindMembers_NestedTypes): ... here.
15094 (TypeContainer.FindNestedType): Implement override.
15095 (ClassPart.FindNestedType): Delegate to PartialContainer.
15096 (ClassPart.PartFindNestedType): Looks up the nested types of the
15099 2005-03-02 Martin Baulig <martin@ximian.com>
15101 * class.cs (TypeContainer.DoDefineMembers): We also need a default
15102 static constructor in static classes.
15104 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
15106 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
15107 sizeParamIndex is not specified.
15109 2005-03-01 Marek Safar <marek.safar@seznam.cz>
15112 * report.cs (WarningMessage.IsEnabled): Missing null check.
15114 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15116 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
15117 in the fields and not in the properties.
15119 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
15121 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
15124 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15126 * attribute.cs: Small refactoring (improved robustness).
15127 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
15128 (ValidateGuid): Removed.
15129 (Resolve): Removed referenced to above mentioned.
15130 (GetAttributeUsage): Made private and changed to work without
15132 (GetIndexerAttributeValue): Don't crash.
15133 (GetConditionalAttributeValue): Ditto.
15134 (GetClsCompliantAttributeValue): Ditto.
15135 (ExtractSecurityPermissionSet): All attributes exceptions are
15137 (GetPropertyValue): New helper.
15138 (GetMethodImplOptions): New method.
15139 (DefinePInvokeMethod): Reuse common code. Implemented handling of
15140 some missing properties.
15142 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
15143 (Method.ApplyAttributeBuilder): Updated.
15145 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
15148 2005-02-28 Raja R Harinath <rharinath@novell.com>
15151 * report.cs (Report.SymbolRelatedToPreviousError): Handle
15152 non-simple types (array, pointer, reference).
15154 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15156 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
15158 * class.cs (MethodCore.IsDuplicateImplementation): Special error
15160 (Method.CheckBase): Catch wrong destructor here.
15161 (MethodData.Define): Add errors 550, 668.
15163 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
15165 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
15167 * pending.cs (VerifyPendingMethods): Add error 551.
15169 * typemanager.cs (CSharpName): Next error report helper.
15171 2005-02-25 Marek Safar <marek.safar@seznam.cz>
15173 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
15174 attributes. Removed useless attribute double check.
15175 It saves almost 2MBs for corlib.
15177 2005-02-25 Raja R Harinath <rharinath@novell.com>
15180 * statement.cs (ExpressionStatement.Resolve): Make robust to being
15181 called twice in case of error.
15183 2005-02-23 Chris Toshok <toshok@ximian.com>
15185 Fix compiler portions of #72827.
15186 * statement.cs (Block.Emit): call Begin/EndScope on the
15187 EmitContext instead of the ILGenerator.
15189 * codegen.cs (EmitContext.BeginScope): new method, call
15190 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
15192 (EmitContext.BeginScope): same, but EndScope and CloseScope
15194 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
15195 offset and call the superclass's OpenScope(int) with it.
15196 (SymbolWriter.CloseScope): get the current il
15197 offset and call superclass's CloseScope(int) with it.
15199 2005-02-23 Marek Safar <marek.safar@seznam.cz>
15201 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
15202 CS1677 for out and ref as well.
15204 * class.cs (Method.Define): Add error CS1599 detection.
15206 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
15208 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
15210 * delegate.cs (Delegate.Define): Add error CS1599 detection.
15212 * support.cs.cs (ModifierDesc): New helper method.
15214 2005-02-23 Raja R Harinath <rharinath@novell.com>
15215 Abin Thomas <projectmonokochi@rediffmail.com>
15216 Anoob V E <projectmonokochi@rediffmail.com>
15217 Harilal P R <projectmonokochi@rediffmail.com>
15219 Fix #57851, #72718.
15220 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
15221 MemberLookup (used for error reporting) actually returns a result.
15222 Fix error report number (122, not 112).
15224 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
15225 Anoob V E <projectmonokochi@rediffmail.com>
15226 Harilal P R <projectmonokochi@rediffmail.com>
15229 * pending.cs (PendingImplementation.GetAbstractMethods):
15230 Find NonPublic members too.
15232 2005-02-22 Marek Safar <marek.safar@seznam.cz>
15234 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
15237 * class.cs (MethodCore.CheckMethodAgainstBase):
15238 Add error 239 report.
15240 2005-02-21 Raja R Harinath <rharinath@novell.com>
15243 * expression.cs (Invocation.IsApplicable): Make public.
15244 (Invocation.IsParamsMethodApplicable): Likewise.
15245 * delegate.cs (Delegate.VerifyApplicability): Don't use
15246 Invocation.VerifyArgumentCompat for parameter applicability
15247 testing. Use Invocation.IsApplicable and
15248 Invocation.IsParamsMethodApplicable.
15250 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15252 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
15254 * class.cs (Operator.Define): Add error 217 report.
15256 2005-02-21 Raja R Harinath <rharinath@novell.com>
15258 * namespace.cs (UsingEntry.Resolve): Undo change below.
15260 2005-02-21 Raja R Harinath <rharinath@novell.com>
15263 * ecore.cs (Expression.MemberLookupFailed): Add argument to
15264 disable the error message when the extended MemberLookup also
15266 (Expression.MemberLookupFinal): Update.
15267 (SimpleName.DoSimpleNameResolve): Update.
15268 * expression.cs (MemberAccess.ResolveNamespaceOrType):
15269 Don't use MemberLookupFinal.
15270 (New.DoResolve): Update.
15271 (BaseAccess.CommonResolve): Update.
15273 2005-02-21 Raja R Harinath <rharinath@novell.com>
15276 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
15277 occured previously, don't resolve again.
15279 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15282 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
15283 argument. Call ResolveAttributeUsage for unresolved.
15284 when types doesn't match ctor arguments.
15286 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
15287 for nested attribute classes.
15288 (Class.attribute_usage): Removed.
15289 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
15290 for attribute class.
15292 * ecore.cs (IsAttribute): Removed.
15294 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15296 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15298 (attribute_types): Removed.
15299 (EmitCode): Global attributes are emited as the latest.
15301 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15303 * class.cs (EmitFieldInitializers): Don't emit field initializer
15304 for default values when optimilization is on.
15306 * constant.cs (Constant.IsDefaultValue): New property.
15308 * driver.cs: Add /optimize handling.
15312 * literal.cs: Implement new IsDefaultValue property.
15314 * rootcontext.cs (Optimize): New field, holds /optimize option.
15316 2005-02-18 Raja R Harinath <rharinath@novell.com>
15318 Fix crasher in re-opened #72347.
15319 * namespace.cs (Namespace.Lookup): Return null if
15320 DeclSpace.DefineType returns null.
15323 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15325 2005-02-18 Raja R Harinath <rharinath@novell.com>
15327 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15328 now returns null if it cannot resolve to an lvalue.
15329 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15330 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15331 returned null. Remove check for SimpleName.
15332 (EventExpr.DoResolveLValue): New.
15333 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15334 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15336 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15337 avoid CS0131 error.
15338 (Unary.ResolveOperator): Move CS0211 check ...
15339 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15341 (Unary.DoResolveLValue): Simplify.
15342 (AddressOf.DoResolveLValue): New.
15343 (ArrayAccess.DoResolveLValue): New.
15345 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15347 * attribute.cs (Attribute.Resolve): Add arguments casting for
15348 when types doesn't match ctor arguments.
15350 2005-02-16 Raja R Harinath <rharinath@novell.com>
15352 Fix parts of #63202.
15353 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15354 lookup of operator in base type. Ensure that all checks happen
15355 when the operator resolves to an "op_..." method.
15357 2005-02-15 Raja R Harinath <rharinath@novell.com>
15360 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15361 'ignore_cs0104' parameter. Pass it to ...
15362 (NamespaceEntry.Lookup): ... this.
15363 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15364 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15365 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15366 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15367 Update. Request that cs0104 errors be ignored.
15368 (ComposedCast.ResolveAsTypeStep): Update.
15370 2005-02-14 Raja R Harinath <rharinath@novell.com>
15373 * expression.cs (Invocation.BetterFunction): Remove support for
15374 comparing virtual functions and their overrides.
15375 (Invocation.IsOverride): New.
15376 (Invocation.OverloadResolve): Don't consider 'override' functions
15377 during candidate selection. Store them in a lookaside list.
15378 If the selected method is a 'virtual' function, use the list to
15379 find any overrides that are closer to the LHS type.
15381 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15383 * expression.cs (New.DoResolve): Add complex core type reduction.
15384 (New.Constantify): Converts complex core type syntax like 'new int ()'
15385 to simple constant.
15387 2005-02-14 Raja R Harinath <rharinath@novell.com>
15389 * decl.cs (EntryType.EntryType): New constructor to create an
15390 updated copy of a cache entry.
15391 (MemberCache.AddMethods): Use it.
15392 (MemberCache.ClearDeclaredOnly): Remove.
15393 (MemberCache.MemberCache): Update.
15395 2005-02-11 Miguel de Icaza <miguel@novell.com>
15397 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15398 variable. This one is represents the actual low-level declaration
15399 of the method, as opposed to the semantic level `IsStatic'.
15401 An anonymous method which is hosted into a static method might be
15402 actually an instance method. IsStatic would reflect the
15403 container, while MethodIsStatic represents the actual code
15406 * expression.cs (ParameterReference): Use the new MethodIsStatic
15407 instead of IsStatic.
15409 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15410 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15411 set on the current EmitContext.
15413 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15414 resolve our casted expression as an LValue. This triggers the
15415 proper LValue processing that is later required by Assign.
15419 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15421 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15423 C# 2.0 Fixed buffer implementation
15425 * anonymous.cs: Update after RegisterHelperClass renaming.
15427 * attribute.cs (AttributeTester.fixed_buffer_cache):
15428 Cache of external fixed buffers.
15429 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15430 implementation if field is fixed buffer else null.
15433 (TypeContainer.AddField): Accept FieldMember instead of Field.
15434 (FieldBase.IsFieldClsCompliant): Extracted code from
15435 VerifyClsCompliance descendant customization.
15436 (FixedField): New class handles fixed buffer fields.
15437 (FixedFieldExternal): Keeps information about imported fixed
15439 (IFixedField): Make access to internal or external fixed buffer
15442 * cs-parser.jay: Add fixed buffer parsing.
15444 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15447 * expression.cs (Indirection): Extended implementation to accept
15448 fixed buffer field.
15449 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15450 (ElementAccess.MakePointerAccess): Get type as parameter.
15451 (DoResolve): Add fixed buffer field expression conversion.
15452 (DoResolveLValue): Ditto.
15453 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15454 (ArrayPtr): Derives from FixedBufferPtr.
15455 (ArrayPtr.Emit): Add extra emit for array elements.
15457 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15459 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15460 for compiler generated types.
15461 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15463 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15464 and consume less memory.
15465 (Fixed.Resolve): Add fixed buffer case.
15467 * typemanager.cs (compiler_generated_attr_ctor,
15468 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15469 (HasElementType): Add our own implementation to work on every
15472 2005-02-11 Miguel de Icaza <miguel@novell.com>
15474 * anonymous.cs (CaptureContext): Track whether `this' has been
15477 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15478 only captured `this' if it was implicitly done (instance
15479 methods/variables were used).
15481 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15482 `this' must be captured.
15484 2005-01-30 Miguel de Icaza <miguel@novell.com>
15486 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15487 is null it means that there has been no need to capture anything,
15488 so we just create a sibling.
15490 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15492 Just a partial fix. The other half is fairly elusive.
15494 2005-02-10 Raja R Harinath <rharinath@novell.com>
15496 Fix #52586, cs0121-4.cs.
15497 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15498 and return a hashtable.
15499 (MemberCache.ClearDeclaredOnly): New.
15500 (MemberCache.MemberCache): Update to change. Make a deep copy of
15501 the method_hash of a base type too.
15502 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15503 type methods. Overwrite entries with the same MethodHandle so
15504 that the ReflectedType is correct. The process leaves in base
15505 virtual functions and their overrides as distinct entries.
15506 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15507 matters since it was boxed in a ArrayList before.
15508 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15510 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15511 case of a virtual function and its override (choose the overload
15513 (Invocation.OverloadResolve): Avoid 'override' members during
15514 'applicable_type' calculation.
15516 2005-02-09 Raja R Harinath <rharinath@novell.com>
15518 Combine two near-redundant caches.
15519 * typemanager.cs (method_params): Rename from method_internal_params.
15520 (TypeManager.GetParameterData): New. Replace
15521 Invocation.GetParameterData.
15522 (TypeManager.LookupParametersByBuilder): Remove.
15523 * expression.cs (Invocation.method_parameter_cache): Remove.
15524 (Invocation.GetParameterData): Remove.
15526 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15529 2005-02-08 Raja R Harinath <rharinath@novell.com>
15532 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15533 TypeManager.multicast_delegate_type is null, resolve it by looking
15534 up "System.MulticastDelegate".
15535 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15537 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15538 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15539 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15542 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15543 (LabeledStatement.AddReference): New. Set 'referenced'.
15544 (Goto.Resolve): Use it.
15546 2005-02-05 John Luke <john.luke@gmail.com>
15548 * driver.cs: remove duplicate -doc line in Usage ()
15550 2005-02-04 Raja R Harinath <rharinath@novell.com>
15552 * location.cs (Location.AddFile): Fix CS2002 error report.
15554 2005-02-02 Martin Baulig <martin@ximian.com>
15556 * delegate.cs (Delegate.DefineType): Report an internal error if
15557 TypeManager.multicast_delegate_type is null. See bug #72015 for
15560 2005-02-02 Raja R Harinath <rharinath@novell.com>
15562 Fix a crasher in a variant of #31984.
15563 * const.cs (Constant.CheckBase): New override that defers the
15564 new-or-override check in case the base type hasn't been populated
15566 (Constant.Define): Ensure the new-or-override check is performed.
15568 2005-02-01 Duncan Mak <duncan@ximian.com>
15570 * const.cs (LookupConstantValue): Check that `ce' is not null
15571 before calling GetValue ().
15573 2005-02-01 Raja R Harinath <rharinath@novell.com>
15575 Fix test-334.cs (#69519).
15576 * cs-parser.jay (using_alias_directive): Pass in an expression to
15577 NamespaceEntry.UsingAlias.
15578 (using_namespace_directive): Pass in an expression to
15579 NamespaceEntry.Using.
15580 (namespace_name): Don't flatten to a string.
15581 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15582 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15584 (NamespaceEntry.UsingEntry): Likewise.
15585 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15587 (NamespaceEntry.LookupForUsing): Remove.
15588 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15590 (NamespaceEntry.Lookup): Remove support for dotted names.
15592 2005-02-01 Raja R Harinath <rharinath@novell.com>
15594 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15596 (NamespaceEntry.ImplicitParent): Compute on demand.
15597 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15598 parallels the current.
15599 (NamespaceEntry.LookupForUsing): Use it.
15600 (NamespaceEntry.Lookup): If the current namespace-entry is
15601 implicit, don't search aliases and using tables.
15603 2005-02-01 Raja R Harinath <rharinath@novell.com>
15606 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15608 (TypeContainer.BaseCache): Compute on demand.
15609 (TypeContainer.FindMembers): Define constants and types if they're
15610 not already created.
15611 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15613 * const.cs (Constant.Define): Make idempotent.
15615 2005-01-29 Miguel de Icaza <miguel@novell.com>
15617 * pending.cs: Produce better code (no nops produced by using Ldarg
15620 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15621 i - 1' it should be arg + 1.
15625 2005-01-28 Raja R Harinath <rharinath@novell.com>
15627 * attribute.cs (Attribute.CheckAttributeType): Make private
15629 (Attribute.ResolveType): Make virtual.
15630 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15631 handling of RootContext.Tree.Types.
15633 2005-01-27 Raja R Harinath <rharinath@novell.com>
15635 Update attribute-handling to use the SimpleName/MemberAccess
15637 * cs-parser.jay (attribute): Pass in an expression to the
15638 constructors of Attribute and GlobalAttribute.
15639 * attribute.cs (Attribute): Take an expression for the name.
15640 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15641 passed in attribute name expression.
15642 (Attribute.CheckAttributeType): Use it.
15643 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15644 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15645 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15646 argument to prevent error messages if the lookup fails.
15648 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15650 * expression.cs (Indirection): Implemented IVariable interface
15651 to support indirection in AddressOf operator.
15652 (PointerArithmetic.Emit): Add optimalization for case where
15653 result can be precomputed.
15655 2005-01-26 Martin Baulig <martin@ximian.com>
15657 * class.cs (TypeContainer.AttributeTargets): Return the correct
15658 AttributeTargets depending on our `Kind' instead of throwing an
15659 exception; fixes #71632.
15661 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15664 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15667 2005-01-25 Raja R Harinath <rharinath@novell.com>
15670 * expression.cs (MemberAccess.DoResolve): Don't complain with
15671 cs0572 when the LHS of a member access has identical name and type
15674 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15677 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15679 Create custom PermissionSet only for PermissionSetAttribute.
15681 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15684 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15685 delegates in static class.
15687 2005-01-24 Martin Baulig <martin@ximian.com>
15689 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15690 merging an implicit block, just use its reachability.
15692 * statement.cs (Block.Resolve): Make the unreachable code check
15693 work wrt. implicit blocks; see test-337 from #63842.
15695 2005-01-21 Alp Toker <alp@atoker.com>
15697 * cs-parser.jay: destructor_declaration's container is PartialContainer
15698 not Class when partial types are used, so use Kind prop instead of
15701 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15703 * cs-parser.jay: Improve error reporting when an interface
15704 declares new types.
15706 2005-01-20 Dick Porter <dick@ximian.com>
15708 * support.cs: SeekableStreamReader fix from Sandor Dobos
15709 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15710 chars are read. Fixes bug 70369.
15712 2005-01-20 Raja R Harinath <rharinath@novell.com>
15714 * cs-parser.jay (catch_clause): Simplify current_block handling
15717 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15719 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15720 code with ImplicitStandardConversion to handle the implicit
15721 conversion of method groups into valid delegate invocations.
15723 The problem is that in parameter handling we were using this code
15724 path. Fixes bug #64698
15726 2005-01-19 Raja R Harinath <rharinath@novell.com>
15728 * cs-parser.jay: Fix several infelicities.
15729 - Avoid assigning to the parser value stack. Code like
15730 '$3 = null' is unclean. Synthesize a value for the code block
15732 - Avoid using oob_stack for storing location information. Use ...
15733 (_mark_): ... this. New (empty) rule. Saves the current location
15735 (foreach_statement): Avoid using oob_stack for current_block
15736 handling. Use technique used in for_statement and
15737 using_statement. Synthesize a value for the code block to store
15738 additional intermediate information.
15740 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15742 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15743 of a different type is only allowed to private fields of a
15744 containing type, not on fields of a base class.
15746 See test-174.cs and error cs0122-9.cs
15748 2005-01-13 Raja R Harinath <rharinath@novell.com>
15750 Fix test-335.cs (bug #58126).
15751 * cs-parser.jay (argument): Split out non-expression parts of the
15752 rule into 'non_simple_argument'.
15753 (invocation_expression): Support parenthesized invocations with
15754 multiple arguments, and with single non-simple arguments.
15756 2005-01-13 Raja R Harinath <rharinath@novell.com>
15758 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15761 2005-01-12 Raja R Harinath <rharinath@novell.com>
15763 Fix cs0038-1.cs, cs1640-6.cs.
15764 * ecore.cs (Expression.Resolve): Remove special-case for
15765 SimpleName in error-handling.
15766 (Expression.almostMatchedMembers): Relax access permission to
15768 (Expression.MemberLookupFailed): Handle duplicates in
15769 almostMatchedMembers list.
15770 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15771 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15772 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15773 overload if the passed in MemberInfo is a MethodBase.
15775 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15778 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15779 for non-CAS & merge permission sets properly.
15781 2005-01-11 Raja R Harinath <rharinath@novell.com>
15783 Improve standard-compliance of simple name and member access
15784 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15785 * ecore.cs (FullNamedExpression): New abstract base class
15786 for Namespaces and TypeExpressions.
15787 (ResolveFlags.SimpleName): Remove.
15788 (SimpleName): Remove support for dotted names.
15789 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15790 DeclSpace.FindType and DeclSpace.LookupType.
15791 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15792 (Expression.ExprClassName): Make member function.
15793 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15794 a namespace. Remove creation of dotted "SimpleName"s.
15795 (MemberAccess.DoResolve): Likewise.
15796 * decl.cs (DeclSpace.Cache): Make private.
15797 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15798 (DeclSpace.FindType): Update.
15799 (DeclSpace.LookupType): Move here from RootContext. Return a
15800 FullNamedExpression.
15801 * namespace.cs (Namespace): Derive from FullNamedExpression
15802 so that it can be part of expression resolution.
15803 (Namespace.Lookup): Return an FullNamedExpression.
15804 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15806 * rootcontext.cs (NamespaceLookup): Remove.
15807 (LookupType): Move to DeclSpace.
15808 * attribute.cs (CheckAttributeType): Update.
15809 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15810 (FindDocumentedTypeNonArray): Likewise.
15812 2005-01-11 Raja R Harinath <rharinath@novell.com>
15814 Fix cs0509.cs, cs1632.cs.
15815 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15816 is the same as IsInterface.
15817 (TypeContainer.GetClassBases): Likewise.
15818 * statement.cs (LabeledStatement.ig): New field.
15819 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15821 (LabeledStatement.DoEmit): Check that the label was created with
15822 the same ILGenerator.
15824 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15827 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15828 accessors to its properties.
15830 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15831 from accessors to property.
15833 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15836 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15837 only for overrides.
15839 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15841 * attribute.cs: Check for null and empty strings.
15843 I have lost another battle to Paolo.
15845 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15848 * class.cs (PropertyMethod): Set Parent field in ctors.
15849 (SetMethod.InternalParameters): Add unsafe switch hack.
15850 Override MarkForDuplicationCheck where it is appropriate.
15852 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15853 It says whether container allows members with the same name.
15854 Base default is no.
15855 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15856 Removed is_method parameter.
15858 2005-01-06 Duncan Mak <duncan@ximian.com>
15860 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15861 because the previous change led to incorrect reporting of CS1032
15862 ("Cannot define/undefine preprocessor symbols after first token in
15863 file"). Instead of using `tokens_seen' as the only flag that
15864 triggers CS1040, introduce `comments_seen'. This new flag is used
15865 to signify having seen comments on the current line, so it is
15866 unset after a newline.
15868 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15870 * doc.cs : When searching for a type, find nested type too.
15871 This fixes bug #71040.
15873 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15876 - Warn missing member comment on those classes which also does not
15877 have doc comments. Fixed bug #71041.
15878 - Don't warn missing doc comment on default constructor.
15881 2005-01-06 Duncan Mak <duncan@ximian.com>
15883 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15884 comments, set `tokens_seen' to true. This allows us to detect
15885 misplaced preprocessor directives (i.e. not at the beginning of
15886 the a line, nor after whitespaces). In that case, report error
15887 CS1040. This fixes bug #56460.
15889 * cs-parser.jay (interface_member_declaration): Add checks for
15890 IsExplicitImpl, and report CS0541 error if an interface member is
15891 defined as an explicit interface declaration.
15893 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15896 * class.cs (PropertyMethod): Set Parent field in ctors.
15897 (SetMethod.InternalParameters): Add unsafe switch hack.
15899 * decl.cs (MemberCore.Parent): Cannot be readonly.
15901 2005-01-06 Raja R Harinath <rharinath@novell.com>
15903 * decl.cs (DeclSpace.ResolveType): Remove.
15904 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15905 Merge in code from ...
15906 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15907 * class.cs, enum.cs: Update to changes.
15909 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15911 * anonymous.cs: Ensure that we init the scope of our parent if it
15912 has not been initialized yet.
15914 2004-12-30 Duncan Mak <duncan@ximian.com>
15916 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15917 if field.FieldBuilder is null. Fixes #70758.
15919 * convert.cs: Fixed some typos and updated some of the comments.
15920 (ImplicitStandardConversionExists):
15921 (TryImplicitIntConversion): If `target_type' is an interface and
15922 the type of `ic' implements this interface, return true or a new
15923 BoxedCast instead of null. This fixes #70468.
15925 2004-12-29 Duncan Mak <duncan@ximian.com>
15927 * expression.cs (Argument.Emit): Check that Expr is
15928 IMemoryLocation before casting to it, and report CS1510 otherwise.
15932 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15934 * statement.cs (Block.ThisVariable): remove the recursion here, to
15935 make the --profile more sane.
15937 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15939 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15940 assembly, by JB Evain.
15942 2004-12-17 Raja R Harinath <rharinath@novell.com>
15944 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15945 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15946 "parent" refers to enclosing type/class. "base" refers to superclass.
15948 2004-12-17 Raja R Harinath <rharinath@novell.com>
15950 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15951 Ensure that we only have GlobalAttributes.
15952 * attribute.cs (Attribute.Emit): Make non-virtual.
15953 (GlobalAttribute.Emit): Remove.
15954 (Attribute.Resolve): Make virtual.
15955 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15956 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15957 the argument. Don't create one.
15958 (Attribute.GetObsoleteAttribute): Likewise.
15959 (Attribute.GetClsCompliantAttributeValue): Likewise.
15960 * class.cs, decl.cs: Update to changes.
15962 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15964 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15966 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15968 * statement.cs (Foreach.Resolve): Add error 186 report.
15970 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15972 * expression.cs (Conditional.DoResolve): Add warning 429.
15974 * statement.cs (If.Resolve): Add warning 665.
15976 2004-12-16 Raja R Harinath <rharinath@novell.com>
15978 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15979 except when in the parser, and in GlobalAttribute.
15980 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15981 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15982 RootContext.Tree.Types.NamespaceEntry once work is done.
15983 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15984 and resets RootContext.Tree.Types.NamespaceEntry.
15986 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15988 * cs-parser.jay: Don't create a block for every variable.
15990 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15992 * location.cs: Provide extra information.
15994 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15995 variables from the captured environment, it is the ldarg_0.
15997 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15999 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
16002 * class.cs: Changed warning level for 169 to avoid developer
16003 displeasure from warning flooding. It will be changed back when they
16004 fix most of current BCL warnings.
16006 * RootContext.cs: Pushed default WarningLevel to 3.
16008 * statement.cs: Removed unused variable.
16010 2004-12-14 Marek Safar <marek.safar@seznam.cz>
16012 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
16013 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
16014 Add error 502 report.
16015 (StaticClass.DefineType): Add error 441 report.
16016 (Class.AllowedModifiersProp): New virtual property as temporary
16017 extension to AllowedModifiers.
16018 (Class.DefineType): Add error 418 report. Moved ModFlags check here
16019 to share implementation with StaticClass and don't call virtual
16022 * driver.cs (MainDriver): Add error 1558 test.
16024 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
16025 report. Moved error 36 test here.
16027 * statement.cs (Throw.Resolve): Add error 724 report.
16029 * typemanager.cs: Add out_attribute_type core type.
16031 2004-12-13 Marek Safar <marek.safar@seznam.cz>
16033 * class.cs (TypeContainer.VerifyClsCompliance): Add error
16035 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
16037 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
16040 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
16042 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
16043 Add error 3023 report.
16044 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
16046 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
16049 2004-12-12 John Luke <john.luke@gmail.com>
16051 * driver.cs (AddArgs): take -- into account when
16052 adding arguments, fixes bug 65710
16054 2004-12-12 Martin Baulig <martin@ximian.com>
16056 * expression.cs (Unary.TryReduceNegative): Added support for
16057 SByteConstant and ByteConstant.
16058 (Unary.Reduce): Check error values from TryReduceNegative().
16060 2004-12-10 Marek Safar <marek.safar@seznam.cz>
16062 * attributes.cs (Attribute.Resolve): Avoid multiple error report
16063 and report exception as error 182.
16065 2004-12-10 Raja R Harinath <rharinath@novell.com>
16067 * driver.cs (Main): Fix message when there are warnings.
16069 2004-12-09 Miguel de Icaza <miguel@ximian.com>
16071 * delegate.cs: Fixed my fix from yesterday, sorry about that.
16073 2004-12-09 Marek Safar <marek.safar@seznam.cz>
16075 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
16076 Reduced number of warnings.
16078 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
16080 2004-12-08 Miguel de Icaza <miguel@ximian.com>
16082 * driver.cs: Removed message.
16084 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
16086 2004-12-08 <vargaz@freemail.hu>
16088 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
16090 2004-12-08 Martin Baulig <martin@ximian.com>
16092 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
16093 instead of a CS3002 for properties and indexer.
16095 2004-12-08 Martin Baulig <martin@ximian.com>
16097 * decl.cs (MemberName.ToString): Make this work again.
16099 2004-12-08 Marek Safar <marek.safar@seznam.cz>
16101 * attribute.cs (Resolve): Add error 591 detection.
16103 * class.cs (FieldMember.Define): Add error 1547 detection.
16104 (Indexer.Define): Add error 620 detection.
16105 (Operator.Define): Add error 590 detection.
16107 * ecore.cs: Missing argument for error 79.
16109 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
16112 2004-12-07 Marek Safar <marek.safar@seznam.cz>
16115 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
16118 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
16120 * cs-parser.jay : handle doc comments on implicit/explicit operators.
16121 Some operator comments were suppressed.
16122 * doc.cs : Implicit/explicit operator name in doc comments are like
16123 "op_Explicit(type)~returnType", so added suffix handling.
16125 2004-12-07 Martin Baulig <martin@ximian.com>
16128 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
16129 (MemberCore.GetClsCompliantAttributeValue): Likewise.
16130 (DeclSpace.ec): New protected field; store the EmitContext here.
16131 (DeclSpace.EmitContext): New public property; moved here from
16133 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
16136 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
16137 (Enum.Emit): Don't create a new EmitContext.
16139 * delegate.cs (Delegate.DefineType): Always create the
16142 * iterators.cs (Iterators.DefineIterator): Create a new
16143 EmitContext and store it in `ec'.
16145 2004-08-24 Martin Baulig <martin@ximian.com>
16148 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
16149 this for accessibility checks.
16150 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
16151 IsNestedFamilyAccessible.
16152 (TypeManager.IsSubclassOf): New method, do what the name actually
16155 2004-12-06 Raja R Harinath <rharinath@novell.com>
16157 Fix crash on cs0657-17.cs.
16158 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
16159 Use RootContext.Tree.Types, not 'new RootTypes ()'.
16160 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
16161 the case where the NamespaceEntry gets overwritten.
16163 2004-12-06 Marek Safar <marek.safar@seznam.cz>
16165 Fixed #69195, #56821
16166 * ecore.cs (ResolveBoolean): Tiny refactoring.
16168 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
16169 of right expression resolving when left is false constant and
16170 operator is LogicalAnd OR true constant and operator is LogicalOr.
16172 * statement.cs (ResolveUnreachable): Always reports warning.
16174 2004-12-05 Miguel de Icaza <miguel@ximian.com>
16176 * class.cs: Distinguish between 1721 and 1722 (just a little help
16177 for the programmer).
16179 2004-12-03 Miguel de Icaza <miguel@ximian.com>
16181 * delegate.cs: Only allow this on new versions of the language.
16183 2004-12-02 Duncan Mak <duncan@ximian.com>
16185 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
16187 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
16188 here as a static method. Take an additional bool out parameter
16189 `must_do_cs1540_check' for signaling to InstanceResolve.
16190 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
16191 member field from PropertyExpr class and made it an argument of
16192 the method instead.
16193 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
16194 check for MarshalByRefObject, and report CS0122 instead of CS1540.
16195 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
16196 and `remove_accessor' as well as InstanceResolve: report CS0122
16201 2004-12-03 Raja R Harinath <rharinath@novell.com>
16203 Fix test-327.cs, test-328.cs, and put in early infrastructure
16204 for eventually fixing #52697.
16205 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
16206 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
16207 from other methods.
16208 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
16209 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
16210 (VerifyUsing, error246): Update.
16211 * rootcontext.cs (RootContext.NamespaceLookup): Just use
16212 'NamespaceEntry.LookupNamespaceOrType'.
16214 2004-12-03 Martin Baulig <martin@ximian.com>
16216 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16217 method as our child, call AnonymousMethod.Compatible() on it.
16219 2004-12-03 Raja R Harinath <rharinath@novell.com>
16221 Disable XML documentation support in 'basic' profile.
16222 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
16223 Redirect XmlElement to System.Object.
16224 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
16225 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
16226 * mcs.exe.sources: Add doc-bootstrap.cs.
16227 * doc-bootstrap.cs: New file. Contains empty stub implementation
16230 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
16232 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
16233 comments are allowed.
16235 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16237 * delegate.cs: Add checks for subtypes in paramaters and return values
16238 in VerifyMethod () to add support for Covariance/Contravariance
16241 2004-12-02 Miguel de Icaza <miguel@ximian.com>
16243 * report.cs: Remove extra closing parenthesis.
16245 * convert.cs (Error_CannotImplicitConversion): If the name of the
16246 types are the same, provide some extra information.
16248 * class.cs (FieldBase): Use an unused bit field from the field to
16249 encode the `has_offset' property from the FieldMember. This saves
16250 a couple of Ks on bootstrap compilation.
16252 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16253 method as our child, return the AnonymousMethod resolved
16256 * expression.cs (New.DoResolve): Allow return values from
16257 NewDelegate to also include AnonymousMethods.
16261 2004-12-02 Marek Safar <marek.safar@seznam.cz>
16264 * attribute.cs (Resolve): Improved implementation of params
16265 attribute arguments.
16267 * support.cs (ParameterData): Add HasParams to be faster.
16269 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
16271 all things are for /doc support:
16273 * doc.cs: new file that supports XML documentation generation.
16274 * mcs.exe.sources: added doc.cs.
16276 Handle /doc command line option.
16277 Report error 2006 instead of 5 for missing file name for /doc.
16278 Generate XML documentation when required, after type resolution.
16280 Added support for picking up documentation (/// and /** ... */),
16281 including a new XmlCommentState enumeration.
16283 Added lines to fill Documentation element for field, constant,
16284 property, indexer, method, constructor, destructor, operator, event
16285 and class, struct, interface, delegate, enum.
16286 Added lines to warn incorrect comment.
16288 Added Documentation field (passed only when /doc was specified).
16290 Added DocComment, DocCommentHeader, GenerateDocComment() and
16291 OnGenerateDocComment() and some supporting private members for
16292 /doc feature to MemberCore.
16294 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16296 Added overriden DocCommentHeader.
16298 Added overriden DocCommentHeader and GenerateDocComment().
16300 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16302 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16303 unwrapping the enumeration values, chain to
16304 DoConstantNumericPromotions again, so we can promote things to the
16305 fundamental types (takes care of enums that are bytes, sbytes).
16309 2004-12-01 Raja R Harinath <rharinath@novell.com>
16311 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16312 Fix long-standing bug in type-lookup. Use FindType instead of
16313 LookupType when ec.ResolvingTypeTree.
16314 (Attribute.ResolveType, Attribute.Resolve)
16315 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16317 (Attributes.Search): Remove internal version. Update.
16318 (Attributes.SearchMulti): Update.
16319 (Attributes.GetClsCompliantAttribute): Remove.
16320 (Attributes.GetIndexerNameAttribute): Remove.
16321 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16322 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16323 * class.cs (Indexer.Define): Likewise.
16325 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16328 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16329 MarshallByReference members access.
16331 * expression.cs: Use CheckMarshallByRefAccess;
16332 Better error CS0197 message.
16334 * report.cs: Print whole related error message.
16336 2004-11-30 Raja R Harinath <rharinath@novell.com>
16338 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16339 the current directory to help debugging.
16341 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16343 * class (GetClassBases): Better error 60 report.
16344 (EventProperty): Disabled warning 67 detection.
16346 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16349 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16351 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16354 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16357 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16359 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16361 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16363 * attribute.cs (Attribute.Resolve): Refine error reporting and
16364 report a cs0117 if the identifier does not exist, to distinguish
16365 from 0617 which is a miss-use of the actual identifier.
16367 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16368 between cs0070 and cs0079.
16370 * class.cs (MemberBase.DoDefine): When reporting a wrong
16371 accessibility level, we use MethodCore to compare instead of
16372 Method (this was a regression in some refactoring effort).
16374 So now we correctly report cs0056 again.
16376 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16377 testing the target_type (which was known to be object_type) and
16378 not the source type (which is anonymous_method).
16380 Fixed reporting of error cs1660.
16382 * expression.cs (UserCast.Source): Expose the underlying cast.
16384 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16385 allowed types to find a match to int32 first (most common).
16387 In addition, it ignores any ImplicitUserConversions that did an
16388 internal implicit conversion (as the switch statement allows only
16389 one integral conversion to exist).
16391 * class.cs (PartialContainer.Create): rename `name' to
16392 `member_name' for clarity. Then replace the string calls with a
16393 call to MemberName.GetPartialName, as now using
16394 MemberName.ToString is an error (this is due to the side effects
16395 it had, that were fixed in the past).
16397 This will restore the error reporting on a number of partial class
16398 errors that were missusing this (and getting an exception as a
16399 results, which is now just a plain textual warning, because
16400 yyparse debug output would crash otherwise).
16402 2004-11-26 Raja R Harinath <rharinath@novell.com>
16404 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16406 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16408 * rootcontext.cs (LookupType): Make sure to cache lookups that
16409 don't give us a negative result. This saves about 5% of corlib
16412 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16414 * report.cs (AbstractMessage.Print): messages are sent to stderr
16416 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16417 non-interface in the list of interfaces (at this point, either
16418 parent was properly set, or a base class is being listed in the
16419 interfaces section).
16421 This flags error 1722, and resolves the crash from bug 69259.
16423 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16425 * statement.cs (Using.EmitExpressionFinally): make this work right
16426 for valuetypes. Fixes 69926.
16428 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16430 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16431 converted to an enum" here, before we try to change the underlying
16432 type. This code exists, but it is a different code path than the
16433 one used while encoding constants.
16435 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16436 old bug: when converting from the null literal to a pointer,
16437 return an EmptyCast, not the NullLiteral.
16439 This fixes #69921, the recent null_type changes probably made this
16440 bug more prominent.
16442 (ImplicitReferenceConversionExists): In addition, resynchronized
16443 the code here, so it matches the same code in
16444 ImplicitReferenceConversionExists for the `from any class-type S
16445 to any interface-type T'.
16448 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16450 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16452 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16454 * cs-parser.jay: Use verbosity accordingly.
16456 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16458 * expression.cs (Unary.ResolveOperator): Do not report warning;
16459 AddressOf reads from variable.
16461 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16463 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16467 * attribute.cs (Attributable): Removed CheckTargets.
16468 (Attributes.Emit): Explicit attribute targets are tested here.
16470 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16471 not enabled for interfaces.
16473 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16474 (GetAssemblyName): Ouch next bug there.
16476 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16478 * expression.cs: Error 275 added.
16480 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16482 Fix bug #69177 (Implemented decimal constant support)
16484 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16485 (BinaryFold): Add DecimalConstant.
16487 * const.cs (Define): Decimal constant
16489 (ChangeType): Add decimal type handling.
16490 (LookupConstantValue): Don't set value for decimal type but
16491 emit DecimalConstantAttribute. Needed for constant optimization.
16493 * constant.cs (ToDecimal): New method.
16494 (ConvertToDecimal): New method.
16495 (IntConstant): Implemented ConvertToDecimal.
16496 (DecimalConstant.Emit): Emit optimized version for decimals in
16499 * expression.cs (ResolveOperator): Changed order of constant
16500 reduction to work correctly with native types which have
16501 overloaded operators.
16502 (ResolveMemberAccess): Extract constant value from attribute
16505 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16507 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16508 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16509 (ChangeType): Decimal is special.
16510 (TypeToCoreType): Add decimal type.
16512 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16514 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16517 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16519 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16522 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16524 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16526 * pending.cs (PendingImplementation): Grab only interfaces.
16528 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16530 * statement.cs (ForeachHelperMethods): Add location member and
16531 error 202 detection.
16533 2004-11-19 Raja R Harinath <rharinath@novell.com>
16535 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16536 automatically handled by executable.make.
16537 (PROGRAM): Make profile-specific.
16539 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16541 * expression.cs (DoResolveBase): Fixed wrong warning for out
16544 2004-11-18 Martin Baulig <martin@ximian.com>
16546 Merged latest changes into gmcs. Please keep this comment in
16547 here, it makes it easier for me to see what changed in MCS since
16548 the last time I merged.
16550 2004-11-17 Raja R Harinath <rharinath@novell.com>
16552 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16553 (TypeHandle.GetMemberCache): New.
16554 (TypeHandle.TypeHandle): Update.
16555 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16556 (TypeManager.LookupParentInterfacesCache):
16557 Rename from LookupInterfaceCache. Optimize slightly.
16558 (TypeManager.MemberLookup_FindMembers): Update.
16559 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16560 multi-type variant.
16561 (AddCacheContents): Rename from AddHashtable.
16562 * class.cs (TypeContainer.parent_container): Remove.
16563 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16564 (TypeContainer.DoDefineMembers): Don't initialize it.
16565 Update to name changes.
16567 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16569 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16570 that factors the code to check access modifiers on override.
16572 (PropertyBase): Use the code here.
16574 Patch from Lluis S'anchez, fixes bug #69361.
16576 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16578 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16579 routine that is used to report the use of a captured variable
16580 whose address has been taken.
16582 There are two checks: one when variables are being captured and
16583 the other check is when the address of a variable is taken.
16585 (because an anonymous methods might be resolved before *or* after
16586 the address has been taken) and
16588 * expression.cs (Conditional.DoResolve): Remove the special
16589 casing that Martin added to trueExpr and falseExpr being both
16590 NullLiteral. We get the right behavior now just by introducing
16591 the null_type into the compiler.
16593 * convert.cs (ExplicitConversion): Change the code to use
16594 null_type instead of testing `expr is NullLiteral'.
16595 (ImplicitConversionStandard): use null_type too.
16596 (ImplicitReferenceConversionExists): use null_type too.
16597 (ImplicitReferenceConversion): use null_type too.
16599 * literal.cs: The type of `NullLiteral' is now null_type instead
16601 (Resolve): Set the type here.
16603 * typemanager.cs: Introduce null_type.
16605 2004-11-17 Martin Baulig <martin@ximian.com>
16607 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16608 direction, like FindMembers() does. Fixes #69546, testcase is in
16611 2004-11-16 Martin Baulig <martin@ximian.com>
16613 This is based on a patch from Marek Safar, see bug #69082.
16614 Fixes bugs #63705 and #67130.
16616 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16617 method; create a MemberCache for an interface type and cache the
16620 * decl.cs (IMemberContainer.ParentContainer): Removed.
16621 (IMemberContainer.ParentCache): New property.
16622 (MemberCache.SetupCacheForInterface): Removed.
16623 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16624 to create a cache for an interface's "parent".
16626 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16629 2004-11-16 Martin Baulig <martin@ximian.com>
16631 Merged back from gmcs; these changes already went into gmcs a
16632 couple of weeks ago.
16635 (TypeManager.AddUserType): Removed the `ifaces' argument.
16636 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16638 (TypeManager.AddUserInterface): Removed.
16639 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16641 (TypeManager.GetInterfaces): Likewise.
16642 (TypeManager.GetExplicitInterfaces): Likewise.
16644 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16646 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16647 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16649 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16651 * statement.cs: Avoid adding bools to a hashtable.
16653 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16655 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16656 calling an unsafe method from a safe location.
16658 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16661 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16663 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16665 * namespace.cs (VerifyUsing): use GetPartialName instead of
16668 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16670 * statement.cs (Return.Resolve): Fix regression in typo: if
16671 `in_exc', we have to request a NeedReturnLabel, this was a typo
16672 introduced in the anonymous method check-in. Fixes #69131.
16674 * Indexers were using the ShortName when defining themselves,
16675 causing a regression in the compiler bootstrap when applying the
16676 patch from 2004-11-02 (first part), now they use their full name
16677 and the bug is gone.
16679 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16681 * driver.cs: Strip the path from the names of embedded resources. Fixes
16684 2004-11-04 Raja R Harinath <rharinath@novell.com>
16686 Fix error message regression: cs0104-2.cs.
16687 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16688 (AliasEntry.Resolve): Update.
16689 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16691 (RootContext.LookupType): Update.
16693 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16695 * cs-parser.jay: Add support for handling accessor modifiers
16696 * class: Add support port accessor modifiers and error checking,
16697 define PropertyMethod.Define as virtual (not abstract anymore)
16698 * ecore.cs: Add checking for proeprties access with access modifiers
16699 * iterators.cs: Modify Accessor constructor call based in the modified
16701 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16703 * expression.cs (StringConcat): Handle being called twice,
16704 as when we have a concat in a field init with more than two
16707 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16709 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16710 special case explicit implementations, we should always produce
16711 the .property or .event declaration.
16713 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16714 since it will not return correct data if people use this
16715 unresolved in the presence of using statements (see test-313).
16717 * class.cs (MethodData.Define): If we are an explicit interface
16718 implementation, set the method name to the full name of the
16719 interface plus the name of the method.
16721 Notice that using the method.MethodName.GetFullName() does not
16722 work, as it will only contain the name as declared on the source
16723 file (it can be a shorthand in the presence of using statements)
16724 and not the fully qualifed type name, for example:
16728 class D : ICloneable {
16729 object ICloneable.Clone () {
16733 Would produce a method called `ICloneable.Clone' instead of
16734 `System.ICloneable.Clone'.
16736 * namespace.cs (Alias.Resolve): Use GetPartialName.
16738 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16740 * cs-parser.jay: Add error 1055 report.
16742 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16744 * assign.cs (Assign.DoResolve): Only do the transform of
16745 assignment into a New if the types are compatible, if not, fall
16746 through and let the implicit code deal with the errors and with
16747 the necessary conversions.
16749 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16751 * cs-parser.jay: Add error 1031 report.
16753 * cs-tokenizer.cs: Add location for error 1038.
16755 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16757 * cs-parser.jay: Add error 1016 report.
16759 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16761 * cs-parser.jay: Add errors 1575,1611 report.
16763 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16765 * cs-parser.jay: Add error 1001 report.
16767 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16770 * attribute.cs (GetMarshal): Add method argument for
16771 caller identification.
16773 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16774 agument for GetMarshal and RuntimeMissingSupport.
16776 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16778 * attribute.cs (ExtractSecurityPermissionSet): Removed
16779 TypeManager.code_access_permission_type.
16781 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16783 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16785 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16786 for obsolete use of a variable here. Fixes regression on errors
16787 cs0619-25 and cs0619-26.
16789 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16791 Fix #62358, implemented security attribute encoding.
16793 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16794 Tests permitted SecurityAction for assembly or other types.
16795 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16796 data from SecurityPermissionAttribute to PermisionSet class.
16798 * class.cs (ApplyAttributeBuilder): Added special handling
16799 for System.Security.Permissions.SecurityAttribute based types.
16801 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16802 special handling for System.Security.Permissions.SecurityAttribute
16805 * enum.cs (ApplyAttributeBuilder): Added special handling
16806 for System.Security.Permissions.SecurityAttribute based types.
16808 * parameter.cs (ApplyAttributeBuilder): Added special handling
16809 for System.Security.Permissions.SecurityAttribute based types.
16811 * rootcontext.cs: Next 2 core types.
16813 * typemanager.cs (TypeManager.security_permission_attr_type):
16814 Built in type for the SecurityPermission Attribute.
16815 (code_access_permission_type): Build in type.
16817 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16819 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16820 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16821 all of this information into
16822 EmitContext.EmitCapturedVariableInstance.
16824 * codegen.cs (EmitCapturedVariableInstance): move here the
16825 funcionality of emitting an ldarg.0 in the presence of a
16826 remapping. This centralizes the instance emit code.
16828 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16829 then emit a load of this: it means that we have reached the
16830 topmost ScopeInfo: the one that contains the pointer to the
16831 instance of the class hosting the anonymous method.
16833 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16834 captures to the topmost CaptureContext.
16836 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16838 * expression.cs (LocalVariableReference): Move the knowledge about
16839 the iterators into codegen's EmitCapturedVariableInstance.
16841 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16843 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16844 all code paths return a value from an anonymous method (it is the
16845 same as the 161 error, but for anonymous methods).
16847 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16849 The introduction of anonymous methods in the compiler changed
16850 various ways of doing things in the compiler. The most
16851 significant one is the hard split between the resolution phase
16852 and the emission phases of the compiler.
16854 For instance, routines that referenced local variables no
16855 longer can safely create temporary variables during the
16856 resolution phase: they must do so from the emission phase,
16857 since the variable might have been "captured", hence access to
16858 it can not be done with the local-variable operations from the runtime.
16862 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16863 is a toplevel block.
16865 (ToplevelBlock): A new kind of Block, these are the blocks that
16866 are created by the parser for all toplevel method bodies. These
16867 include methods, accessors and anonymous methods.
16869 These contain some extra information not found in regular blocks:
16870 A pointer to an optional CaptureContext (for tracking captured
16871 local variables and parameters). A pointer to the parent
16874 (Return.Resolve): Catch missmatches when returning a value from an
16875 anonymous method (error 1662).
16876 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16879 (Break.Resolve): ditto.
16881 (SwitchLabel): instead of defining the labels during the
16882 resolution phase, we now turned the public ILLabel and ILLabelCode
16883 labels into methods called GetILLabelCode() and GetILLabel() that
16884 only define the label during the Emit phase.
16886 (GotoCase): Track the SwitchLabel instead of the computed label
16887 (its contained therein). Emit the code by using
16888 SwitchLabel.GetILLabelCode ().
16890 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16891 whether the Local has been captured or not.
16893 (LocalInfo.IsCaptured): New property, used to tell whether the
16894 local has been captured.
16896 * anonymous.cs: Vastly updated to contain the anonymous method
16899 The main classes here are: CaptureContext which tracks any
16900 captured information for a toplevel block and ScopeInfo used to
16901 track the activation frames for various local variables.
16903 Each toplevel block has an optional capture context associated
16904 with it. When a method contains an anonymous method both the
16905 toplevel method and the anonymous method will create a capture
16906 context. When variables or parameters are captured, they are
16907 recorded on the CaptureContext that owns them, for example:
16911 MyDelegate d = delegate {
16916 Here `a' will be recorded as captured on the toplevel
16917 CapturedContext, the inner captured context will not have anything
16918 (it will only have data if local variables or parameters from it
16919 are captured in a nested anonymous method.
16921 The ScopeInfo is used to track the activation frames for local
16922 variables, for example:
16924 for (int i = 0; i < 10; i++)
16925 for (int j = 0; j < 10; j++){
16926 MyDelegate d = delegate {
16931 At runtime this captures a single captured variable `i', but it
16932 captures 10 different versions of the variable `j'. The variable
16933 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16934 recorded on a child.
16936 The toplevel ScopeInfo will also track information like the `this'
16937 pointer if instance variables were referenced (this is necessary
16938 as the anonymous method lives inside a nested class in the host
16939 type of the method).
16941 (AnonymousMethod): Expanded to track the Toplevel, implement
16942 `AnonymousMethod.Compatible' to tell whether an anonymous method
16943 can be converted to a target delegate type.
16945 The routine now also produces the anonymous method content
16947 (AnonymousDelegate): A helper class that derives from
16948 DelegateCreation, this is used to generate the code necessary to
16949 produce the delegate for the anonymous method that was created.
16951 * assign.cs: API adjustments for new changes in
16952 Convert.ImplicitStandardConversionExists.
16954 * class.cs: Adjustments to cope with the fact that now toplevel
16955 blocks are of type `ToplevelBlock'.
16957 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16958 insteda of standard blocks.
16960 Flag errors if params arguments are passed to anonymous methods.
16962 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16963 `CurrentAnonymousMethod' which points to the current Anonymous
16964 Method. The variable points to the AnonymousMethod class that
16965 holds the code being compiled. It is set in the new EmitContext
16966 created for the anonymous method.
16968 (EmitContext.Phase): Introduce a variable and an enumeration to
16969 assist in enforcing some rules about when and where we are allowed
16970 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16971 only one that enfonces this right now).
16973 (EmitContext.HaveCaptureInfo): new helper method that returns
16974 whether we have a CapturedContext initialized.
16976 (EmitContext.CaptureVariable): New method used to register that a
16977 LocalInfo must be flagged for capturing.
16979 (EmitContext.CapturedParameter): New method used to register that a
16980 parameters must be flagged for capturing.
16982 (EmitContext.CapturedField): New method used to register that a
16983 field must be flagged for capturing.
16985 (EmitContext.HaveCapturedVariables,
16986 EmitContext.HaveCapturedFields): Return whether there are captured
16987 variables or fields.
16989 (EmitContext.EmitMethodHostInstance): This is used to emit the
16990 instance for the anonymous method. The instance might be null
16991 (static methods), this (for anonymous methods that capture nothing
16992 and happen to live side-by-side with the current method body) or a
16993 more complicated expression if the method has a CaptureContext.
16995 (EmitContext.EmitTopBlock): Routine that drives the emission of
16996 code: it will first resolve the top block, then emit any metadata
16997 and then emit the code. The split is done so that we can extract
16998 any anonymous methods and flag any captured variables/parameters.
17000 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
17001 during this phase, the ILGenerator should not be used as labels
17002 and local variables declared here might not be accessible to any
17003 code that is part of an anonymous method.
17005 Exceptions to this include the temporary variables that are
17006 created by some statements internally for holding temporary
17009 (EmitContext.EmitMeta): New routine, in charge of emitting all the
17012 (EmitContext.TemporaryReturn): This method is typically called
17013 from the Emit phase, and its the only place where we allow the
17014 ReturnLabel to be defined other than the EmitMeta. The reason is
17015 that otherwise we would have to duplicate a lot of logic in the
17016 Resolve phases of various methods that today is on the Emit
17019 (EmitContext.NeedReturnLabel): This no longer creates the label,
17020 as the ILGenerator is not valid during the resolve phase.
17022 (EmitContext.EmitThis): Extended the knowledge in this class to
17023 work in anonymous methods in addition to iterators.
17025 (EmitContext.EmitCapturedVariableInstance): This emits whatever
17026 code is necessary on the stack to access the instance to a local
17027 variable (the variable will be accessed as a field).
17029 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
17030 EmitContext.EmitAddressOfParameter): Routines to support
17031 parameters (not completed at this point).
17033 Removals: Removed RemapLocal and RemapLocalLValue. We probably
17034 will also remove the parameters.
17036 * convert.cs (Convert): Define a `ConstantEC' which points to a
17037 null. This is just to prefity some code that uses
17038 ImplicitStandardConversion code and do not have an EmitContext
17041 The idea is to flag explicitly that at that point in time, it is
17042 known that the conversion will not trigger the delegate checking
17043 code in implicit conversions (which requires a valid
17046 Everywhere: pass new EmitContext parameter since
17047 ImplicitStandardConversionExists now requires it to check for
17048 anonymous method conversions.
17050 (Convert.ImplicitStandardConversionExists): If the type of an
17051 expression is the anonymous_method_type, and the type is a
17052 delegate, we invoke the AnonymousMethod.Compatible method to check
17053 whether an implicit conversion is possible.
17055 (Convert.ImplicitConversionStandard): Only do implicit method
17056 group conversions if the language level is not ISO_1.
17058 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
17059 MethodInfo for the Invoke method. used by Delegate and
17062 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
17063 method conversions if the target type is a delegate.
17065 Removed extra debugging nops.
17067 (LocalVariableReference): Turn the `local_info' into a public
17070 Add `prepared' field, the same hack used for FieldExprs to cope
17071 with composed assignments, as Local variables do not necessarily
17072 operate purely on the stack as they used to: they can be captured
17075 Add `temp' for a temporary result, like fields.
17077 Refactor DoResolve and DoResolveLValue into DoResolveBase.
17079 It now copes with Local variables that are captured and emits the
17080 proper instance variable to load it from a field in the captured
17083 (ParameterReference.DoResolveBase): During the resolve phase,
17084 capture parameters if we are in an anonymous method.
17086 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
17087 anonymous method, use the EmitContext helper routines to emit the
17088 parameter reference.
17090 * iterators.cs: Set RemapToProxy to true/false during the
17093 * parameters.cs (GetParameterByName): New helper method.
17095 * typemanager.cs (anonymous_method_type) a new type that
17096 represents an anonyous method. This is always an internal type,
17097 used as a fencepost to test against the anonymous-methodness of an
17100 2004-10-20 Marek Safar <marek.safar@seznam.cz>
17102 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
17104 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
17106 2004-10-18 Martin Baulig <martin@ximian.com>
17108 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
17109 `Type' directly, but call ResolveType() on it.
17110 (Catch.Resolve): Likewise.
17111 (Foreach.Resolve): Likewise.
17113 2004-10-18 Martin Baulig <martin@ximian.com>
17115 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
17116 `Type' directly, but call ResolveType() on it.
17117 (Probe.DoResolve): Likewise.
17118 (ArrayCreation.LookupType): Likewise.
17119 (TypeOf.DoResolve): Likewise.
17120 (SizeOf.DoResolve): Likewise.
17122 2004-10-18 Martin Baulig <martin@ximian.com>
17124 * expression.cs (Invocation.BetterFunction): Put back
17125 TypeManager.TypeToCoreType().
17127 2004-10-18 Raja R Harinath <rharinath@novell.com>
17129 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
17132 2004-10-18 Martin Baulig <martin@ximian.com>
17134 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
17135 `Type' directly, but call ResolveType() on it.
17137 2004-10-18 Martin Baulig <martin@ximian.com>
17139 * class.cs (FieldMember.Define): Don't access the TypeExpr's
17140 `Type' directly, but call ResolveType() on it.
17141 (MemberBase.DoDefine): Likewise.
17143 * expression.cs (New.DoResolve): Don't access the TypeExpr's
17144 `Type' directly, but call ResolveType() on it.
17145 (ComposedCast.DoResolveAsTypeStep): Likewise.
17147 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
17148 `Type' directly, but call ResolveType() on it.
17150 2004-10-17 John Luke <john.luke@gmail.com>
17152 * class.cs (Operator.GetSignatureForError): use CSharpName
17154 * parameter.cs (Parameter.GetSignatureForError): Returns
17155 correct name even if was not defined.
17157 2004-10-13 Raja R Harinath <rharinath@novell.com>
17160 * class.cs (TypeContainer.EmitContext): New property.
17161 (DefineNestedTypes): Create an emitcontext for each part.
17162 (MethodCore.DoDefineParameters): Use container's emitcontext.
17163 Pass type array to InternalParameters.
17164 (MemberBase.DoDefine): Use container's emitcontext.
17165 (FieldMember.Define): Likewise.
17166 (Event.Define): Likewise.
17167 (SetMethod.GetParameterInfo): Change argument to EmitContext.
17168 Pass type array to InternalParameters.
17169 (SetIndexerMethod.GetParameterInfo): Likewise.
17170 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
17171 * delegate.cs (Define): Pass emitcontext to
17172 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
17173 array to InternalParameters.
17174 * expression.cs (ParameterReference.DoResolveBase): Pass
17175 emitcontext to GetParameterInfo.
17176 (ComposedCast.DoResolveAsTypeStep): Remove check on
17177 ec.ResolvingTypeTree.
17178 * parameter.cs (Parameter.Resolve): Change argument to
17179 EmitContext. Use ResolveAsTypeTerminal.
17180 (Parameter.GetSignature): Change argument to EmitContext.
17181 (Parameters.ComputeSignature): Likewise.
17182 (Parameters.ComputeParameterTypes): Likewise.
17183 (Parameters.GetParameterInfo): Likewise.
17184 (Parameters.ComputeAndDefineParameterTypes): Likewise.
17185 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
17186 * support.cs (InternalParameters..ctor): Remove variant that takes
17188 * typemanager.cs (system_intptr_expr): New.
17189 (InitExpressionTypes): Initialize it.
17191 2004-10-12 Chris Toshok <toshok@ximian.com>
17193 * cs-parser.jay: fix location for try_statement and catch_clause.
17195 2004-10-11 Martin Baulig <martin@ximian.com>
17197 * report.cs: Don't make --fatal abort on warnings, we have
17198 -warnaserror for that.
17200 2004-10-07 Raja R Harinath <rharinath@novell.com>
17202 More DeclSpace.ResolveType avoidance.
17203 * decl.cs (MemberCore.InUnsafe): New property.
17204 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
17205 with newly created EmitContext.
17206 (FieldMember.Define): Likewise.
17207 * delegate.cs (Delegate.Define): Likewise.
17208 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
17209 only if normal name-lookup fails.
17210 (TypeExpr.DoResolve): Enable error-checking.
17211 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
17212 (SizeOf.DoResolve): Likewise.
17213 (ComposedCast.DoResolveAsTypeStep): Likewise.
17214 (StackAlloc.DoResolve): Likewise.
17215 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
17216 (Block.Unsafe): New property.
17217 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
17218 (Unsafe): Set 'unsafe' flag of contained block.
17219 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
17220 (Fixed.Resolve): Likewise.
17221 (Catch.Resolve): Likewise.
17222 (Using.ResolveLocalVariableDecls): Likewise.
17223 (Foreach.Resolve): Likewise.
17225 2004-10-05 John Luke <john.luke@gmail.com>
17227 * cs-parser.jay: add location to error CS0175
17229 2004-10-04 Miguel de Icaza <miguel@ximian.com>
17231 * ecore.cs (Expression.Constantity): Add support for turning null
17234 * const.cs (Const.Define): Allow constants to be reference types
17235 as long as the value is Null.
17237 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
17239 * namespace.cs (NamespaceEntry.Using): No matter which warning
17240 level is set, check if this namespace name has already been added.
17242 2004-10-03 Ben Maurer <bmaurer@ximian.com>
17244 * expression.cs: reftype [!=]= null should always use br[true,false].
17247 2004-10-03 Marek Safar <marek.safar@seznam.cz>
17250 * attribute.cs: Enum conversion moved to
17251 GetAttributeArgumentExpression to be applied to the all
17254 2004-10-01 Raja R Harinath <rharinath@novell.com>
17256 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
17257 * class.c (TypeContainer.DefineType): Flag error if
17258 base types aren't accessible due to access permissions.
17259 * decl.cs (DeclSpace.ResolveType): Move logic to
17260 Expression.ResolveAsTypeTerminal.
17261 (DeclSpace.ResolveTypeExpr): Thin layer over
17262 Expression.ResolveAsTypeTerminal.
17263 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
17264 Refactor code into NestedAccess. Use it.
17265 (DeclSpace.NestedAccess): New.
17266 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
17267 argument to silence errors. Check access permissions.
17268 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
17269 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
17270 (Cast.DoResolve): Likewise.
17271 (New.DoResolve): Likewise.
17272 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
17273 (TypeOf.DoResolve): Likewise.
17275 * expression.cs (Invocation.BetterConversion): Return the Type of
17276 the better conversion. Implement section 14.4.2.3 more faithfully.
17277 (Invocation.BetterFunction): Make boolean. Make correspondence to
17278 section 14.4.2.2 explicit.
17279 (Invocation.OverloadResolve): Update.
17280 (Invocation): Remove is_base field.
17281 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
17282 (Invocation.Emit): Likewise.
17284 2004-09-27 Raja R Harinath <rharinath@novell.com>
17286 * README: Update to changes.
17288 2004-09-24 Marek Safar <marek.safar@seznam.cz>
17290 * cs-parser.jay: Reverted 642 warning fix.
17292 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17295 * decl.cs (FindMemberWithSameName): Indexer can have more than
17298 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17300 * expression.cs (LocalVariableReference.DoResolveLValue):
17301 Do not report warning 219 for out values.
17302 (EmptyExpression.Null): New member to avoid extra allocations.
17304 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17306 * cs-parser.jay: Fix wrong warning 642 report.
17308 * cs-tokenizer.cs (CheckNextToken): New helper;
17309 Inspect next character if is same as expected.
17311 2004-09-23 Martin Baulig <martin@ximian.com>
17313 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17314 (Convert.ImplicitReferenceConversionExists): Likewise.
17316 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17318 * class.cs (Operator.Define): Add error 448 and 559 report.
17320 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17322 * class.cs (MemberBase.IsTypePermitted): New protected
17323 method for checking error CS0610.
17325 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17327 * class.cs (TypeContainer.HasExplicitLayout): New property
17328 Returns whether container has StructLayout attribute set Explicit.
17329 (FieldMember): New abstract class for consts and fields.
17330 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17331 (Field): Reuse FieldMember.
17333 * const.cs (Const): Reuse FieldMember.
17335 * rootcontext.cs: EmitConstants call moved to class.
17337 2004-09-22 Martin Baulig <martin@ximian.com>
17339 Thanks to Peter Sestoft for this bug report.
17341 * expression.cs (Conditional): If both the `trueExpr' and the
17342 `falseExpr' is a NullLiteral, return a NullLiteral.
17344 2004-09-22 Martin Baulig <martin@ximian.com>
17346 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17347 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17348 for the "get_Current" call.
17350 2004-09-22 Martin Baulig <martin@ximian.com>
17352 Marek and me just fixed one of our oldest bugs: #28562 :-)
17354 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17356 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17357 we're an EnumConstant, just return that.
17358 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17359 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17360 to get the value which'll actually be written into the attribute.
17361 However, we have to use GetValue() to access the attribute's value
17364 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17366 * constant.cs (Constant.IsNegative): New abstract property
17369 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17370 (StackAlloc.DoResolve): Reused IsNegative.
17372 2004-09-21 Martin Baulig <martin@ximian.com>
17374 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17375 if we're used in an iterator, we may be called from different
17378 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17379 we actually have an exception block.
17381 2004-09-20 John Luke <jluke@cfl.rr.com>
17383 * class.cs, cs-parser.jay: Improve the error report for 1520:
17384 report the actual line where the error happens, not where the
17385 class was declared.
17387 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17388 Pass location information that was available elsewhere.
17390 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17392 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17393 runtime to delay sign assemblies.
17395 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17397 * cs-parser.jay: Do not report the stack trace, this is barely
17400 2004-08-22 John Luke <john.luke@gmail.com>
17402 * driver.cs : check that a resource id is not already used
17403 before adding it, report CS1508 if it is, bug #63637
17405 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17407 * ecore.cs: Removed dead code.
17409 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17411 * class.cs: Do not report warning CS0067 on the interfaces.
17413 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17415 * cs-parser.jay: Add error 504 report.
17417 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17419 * rootcontext.cs: WarningLevel is 4 by default now.
17421 * statement.cs (Fixed.Resolve): Do not null
17424 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17427 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17428 deep search when property is not virtual.
17429 (PropertyExpr.ResolveAccessors): Make one call for both
17432 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17435 * statement.cs: Error 152 report constains also location.
17437 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17440 * const.cs: Explicitly set constant as static.
17442 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17445 * cs-parser.jay: Add error 1017 report.
17447 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17449 Fixed bug #59980, #64224
17450 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17452 * typemanager.cs (IsSpecialMethod): Simplified
17454 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17456 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17457 condition with better params.
17459 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17462 * attribute.cs (Resolve): Property has to have both
17465 2004-09-14 Martin Baulig <martin@ximian.com>
17467 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17469 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17472 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17473 called and is obsolete then this member suppress message
17474 when call is inside next [Obsolete] method or type.
17476 * expression.cs: Use TestObsoleteMethodUsage member.
17478 2004-09-14 Martin Baulig <martin@ximian.com>
17480 * cs-parser.jay: Sync a bit with the GMCS version.
17482 2004-09-14 Martin Baulig <martin@ximian.com>
17484 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17485 (CSharpParser.yacc_verbose_flag): New public field.
17487 * genericparser.cs: Removed.
17489 2004-09-14 Raja R Harinath <rharinath@novell.com>
17491 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17493 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17495 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17497 2004-09-10 Martin Baulig <martin@ximian.com>
17499 Backported my MemberName changes from GMCS into MCS.
17501 - we are now using a special `MemberName' class instead of using
17502 strings; in GMCS, the `MemberName' also contains the type
17505 - changed the grammar rules a bit:
17506 * the old `member_name' is now a `namespace_or_type_name':
17507 The rule is that we use `namespace_or_type_name' everywhere
17508 where we expect either a "member name" (GetEnumerator) or a
17509 "member name" with an explicit interface name
17510 (IEnumerable.GetEnumerator).
17511 In GMCS, the explicit interface name may include type arguments
17512 (IEnumerable<T>.GetEnumerator).
17513 * we use `member_name' instead of just `IDENTIFIER' for
17515 The rule is that we use `member_name' wherever a member may
17516 have type parameters in GMCS.
17518 * decl.cs (MemberName): New public class.
17519 (MemberCore.MemberName): New public readonly field.
17520 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17521 (DeclSpace): Likewise.
17523 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17524 * enum.cs (Enum.ctor): Likewise.
17526 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17528 (AliasEntry.ctor): Take a MemberName, not an Expression.
17529 (AliasEntry.UsingAlias): Likewise.
17531 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17532 (IMethodData.MemberName): Changed type from string to MemberName.
17533 (MemberBase.ExplicitInterfaceName): Likewise.
17534 (AbstractPropertyEventMethod.SetupName): Make this private.
17535 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17536 argument; compute the member name here.
17537 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17538 on the `member.MemberName' and the `prefix'.
17540 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17542 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17543 thus, we get a `MemberName' instead of a `string'. These
17544 declarations may have type parameters in GMCS.
17545 (interface_method_declaration, delegate_declaration): Likewise.
17546 (class_declaration, interface_declaration): Likewise.
17547 (method_header): Use `namespace_or_type_name' instead of
17548 `member_name'. We may be an explicit interface implementation.
17549 (property_declaration, event_declaration): Likewise.
17550 (member_name): This is now just an `IDENTIFIER', not a
17551 `namespace_or_type_name'.
17552 (type_name, interface_type): Removed.
17553 (namespace_or_type_name): Return a MemberName, not an Expression.
17554 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17555 call GetTypeExpression() on the MemberName to get an expression.
17556 (IndexerDeclaration.interface_type): Changed type from string to
17558 (MakeName): Operate on MemberName's instead of string's.
17560 2004-09-13 Raja R Harinath <rharinath@novell.com>
17563 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17564 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17565 lookup to avoid symbols introduced by 'using'.
17566 * rootcontext.cs (NamespaceLookup): Update.
17568 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17570 * class.cs (TypeContainer.DoDefineMembers): Do not call
17571 DefineDefaultConstructor for static classes.
17573 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17575 * attribute.cs (Attribute.Resolve): Add error 653 report.
17577 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17579 (Method.ApplyAttributeBuilder): Add error 685 report.
17580 (Operator.Define): Add error 564 report.
17582 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17584 * expression.cs (Invocation.DoResolve): Add error
17585 245 and 250 report.
17587 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17590 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17592 * class.cs (ConstructorInitializer.Resolve):
17593 Wrong error number (515->516).
17595 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17597 * class.cs (Indexer.Define): Add error 631 report.
17599 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17601 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17603 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17605 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17607 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17609 * cs-parser.jay: Added error CS0241 report.
17611 2004-09-10 Raja R Harinath <rharinath@novell.com>
17613 * cs-parser.jay (fixed_statement): Introduce a scope for the
17614 declaration in the 'fixed' statement.
17616 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17618 * cs-parser.jay: Added CS0230 error report.
17620 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17622 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17624 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17626 * expression.cs (Argument.Resolve): Added error CS0192 and
17629 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17631 C# 2.0 #pragma warning feature
17633 * cs-tokenizer.cs (PreProcessPragma): New method;
17634 Handles #pragma directive.
17636 * report.cs (WarningRegions): New class; Support
17637 class for #pragma warning directive. It tests whether
17638 warning is enabled for a given line.
17640 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17642 * const.cs: Add more descriptive error report, tahnks to
17645 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17647 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17649 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17651 * expression.cs: Apply patch from Ben: Remove dead code from
17652 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17653 as that code just threw an exception anwyays.
17655 * const.cs: Remove the call to the turnintoconstant, for details
17658 * literal.cs: The type of the null-literal is the null type; So
17659 we use a placeholder type (literal.cs:System.Null, defined here)
17662 * expression.cs (Conditional.DoResolve): Remove some old code that
17663 is no longer needed, conversions have been fixed.
17665 (ArrayCreationExpression.DoResolve): Return false if we fail to
17666 resolve the inner expression.
17668 2004-09-07 Raja R Harinath <rharinath@novell.com>
17671 * cs-parser.jay (delegate_declaration): Record a delegate
17672 declaration as a type declaration.
17673 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17675 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17677 * parameter.cs: Do not crash if the type can not be resolved.
17679 * expression.cs: Report errors with unsafe pointers, fixes #64896
17681 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17683 * expression.cs: Pointer arith always needs to do a conv.i
17684 if the operand is a long. fix 65320
17686 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17688 Fixed cs0619-37.cs, cs0619-38.cs
17690 * enum.cs (GetObsoleteAttribute): Removed.
17692 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17693 on Enum member is double staged. The first is tested member
17696 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17698 Fixed #56986, #63631, #65231
17700 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17701 adds member to name container.
17702 (TypeContainer.AddToTypeContainer): New method, adds type to
17704 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17705 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17706 AddOperator): Simplified by reusing AddToMemberContainer.
17707 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17709 (Method.CheckForDuplications): Fixed implementation to test all
17711 (MemberBase): Detection whether member is explicit interface
17712 implementation is now in constructor.
17713 (MemberBase.UpdateMemberName): Handles IndexerName.
17714 (Accessor): Changed to keep also location information.
17715 (AbstractPropertyEventMethod): Is derived from MemberCore.
17716 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17717 will be emited or not.
17718 (PropertyBase.AreAccessorsDuplicateImplementation):
17719 Tests whether accessors are not in collision with some method.
17720 (Operator): Is derived from MethodCore to simplify common
17723 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17725 (DeclSpace.AddToContainer): Adds the member to defined_names
17726 table. It tests for duplications and enclosing name conflicts.
17728 * enum.cs (EnumMember): Clean up to reuse the base structures
17730 2004-09-03 Martin Baulig <martin@ximian.com>
17732 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17733 into TypeContainer, to make partial classes work again.
17735 2004-09-03 Martin Baulig <martin@ximian.com>
17737 * rootcontext.cs (RootContext.V2): Removed.
17739 2004-03-23 Martin Baulig <martin@ximian.com>
17741 * expression.cs (Invocation.OverloadResolve): Added `bool
17742 may_fail' argument and use it instead of the Location.IsNull() hack.
17744 2004-09-03 Martin Baulig <martin@ximian.com>
17746 Merged latest changes into gmcs. Please keep this comment in
17747 here, it makes it easier for me to see what changed in MCS since
17748 the last time I merged.
17750 2004-09-03 Raja R Harinath <rharinath@novell.com>
17753 * expression.cs (BetterConversion): Don't allow either conversion
17754 to be null. Remove redundant implicit conversion test when 'q ==
17755 null' -- when this function is invoked, we already know that the
17756 implicit conversion exists.
17757 (BetterFunction): Assume that 'best' is non-null. Remove
17758 redundant reimplementation of IsApplicable when 'best' is null.
17759 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17760 number of arguments.
17761 (IsAncestralType): Extract from OverloadResolve.
17762 (OverloadResolve): Make robust to the MethodGroupExpr being
17763 unsorted. Implement all the logic of Section 14.5.5.1, and
17764 support overloading of methods from multiple applicable types.
17765 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17767 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17768 (RealError, Warning): Append type of report to related symbol.
17770 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17772 * enum.cs: Fixed CLS-Compliance checks for enum members.
17773 Error tests cs3008-8.cs, cs3014-8.cs
17775 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17777 Fixed bug #62342, #63102
17778 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17779 like ImplementMethod.
17781 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17783 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17786 2004-09-02 Martin Baulig <martin@ximian.com>
17788 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17789 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17792 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17794 C# 2.0 Static classes implemented
17796 * class.cs (TypeContainer): instance_constructors,
17797 initialized_fields, initialized_static_fields,
17798 default_constructor, base_inteface_types are protected to be
17799 accessible from StaticClass.
17800 (TypeContainer.DefineDefaultConstructor): New virtual method
17801 for custom default constructor generating
17802 (StaticClass): New class to handle "Static classes" feature.
17804 * cs-parser.jay: Handle static keyword on class like instance
17807 * driver.cs: Added "/langversion" command line switch with two
17808 options (iso-1, default).
17810 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17812 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17814 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17816 * delegate.cs: Style.
17818 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17820 * delegate.cs: Add seperate instance expr field for miguel.
17822 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17824 * PointerArithmetic (Resolve): make sure we are not doing
17825 pointer arith on void*. Also, make sure we are resolved
17826 by not setting eclass until resolve.
17828 All callers: Make sure that PointerArithmetic gets resolved.
17830 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17832 * ArrayCreation (LookupType): If the type does not resolve
17833 to an array, give an error.
17835 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17837 * statement.cs (Try.Resolve): Fixed bug #64222
17839 2004-08-27 Martin Baulig <martin@ximian.com>
17842 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17845 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17847 * ecore.cs (Constantify): Get underlying type via
17848 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17849 Windows in special cases.
17851 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17853 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17854 for obtaining also private methods.
17855 (GetRemoveMethod): Used GetRemoveMethod (true)
17856 for obtaining also private methods.
17858 2004-08-24 Martin Baulig <martin@ximian.com>
17860 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17861 MethodAttributes.HideBySig for operators.
17863 2004-08-23 Martin Baulig <martin@ximian.com>
17865 Back to the old error reporting system :-)
17867 * report.cs (Message): Removed.
17868 (Report.MessageData, ErrorData, WarningData): Removed.
17869 (Report.Error, Warning): Back to the old system.
17871 2004-08-23 Martin Baulig <martin@ximian.com>
17873 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17875 * class.cs (TypeContainer.ParentContainer): New public virtual
17876 method; replaces the explicit interface implementation.
17877 (ClassPart.ParentContainer): Override.
17879 2004-08-23 Martin Baulig <martin@ximian.com>
17881 * statement.cs (Switch): Added support for constant switches; see
17882 #59428 or test-285.cs.
17884 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17887 * statement.cs (GetEnumeratorFilter): Removed useless
17888 logic because C# specs is strict. GetEnumerator must be
17891 2004-08-22 Martin Baulig <martin@ximian.com>
17893 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17894 a switch and may break, reset the barrier. Fixes #59867.
17896 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17898 CLS-Compliance speed up (~5% for corlib)
17900 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17901 New method. Tests container for CLS-Compliant names
17903 * class.cs (TypeContainer.VerifyClsName): New method.
17904 Checks whether container name is CLS Compliant.
17905 (Constructor): Implements IMethodData.
17907 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17908 low-case table for CLS Compliance test.
17909 (MemberCache.VerifyClsParameterConflict): New method.
17910 Checks method parameters for CS3006 error.
17912 * enum.cs (EnumMember): Is derived from MemberCore.
17913 (Enum.VerifyClsName): Optimized for better performance.
17915 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17917 * report.cs: Renamed Error_T to Error and changed all
17920 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17922 * class.cs (TypeContainer.IndexerArrayList): New inner class
17923 container for indexers.
17924 (TypeContainer.DefaultIndexerName): New constant for default
17925 indexer name. Replaced all "Item" with this constant.
17926 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17928 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17929 DefaultMemberAttribute constructor.
17931 2004-08-05 Martin Baulig <martin@ximian.com>
17933 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17936 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17938 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17939 multi platforms problem.
17941 * compiler.csproj: Included shared files.
17943 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17945 Fix bug 60333, 55971 in the more general way
17946 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17947 Added arg_type argument for constant conversion.
17948 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17950 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17953 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17954 OperatorArrayList, MethodCoreArrayList for typecontainer
17955 containers. Changed class member types to these new types.
17956 (MethodArrayList.DefineMembers): Added test for CS0659.
17958 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17960 * cfold.cs: Synchronize the folding with the code in expression.cs
17961 Binary.DoNumericPromotions for uint operands.
17963 * attribute.cs: Revert patch from Raja, it introduced a regression
17964 while building Blam-1.2.1 (hard to isolate a test case).
17966 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17970 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17972 (MethodCore.parent_method): New member. The method we're overriding
17973 if this is an override method.
17974 (MethodCore.CheckBase): Moved from Method class and made common.
17975 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17977 (MethodCore.CheckForDuplications): New abstract method. For custom
17978 member duplication search in a container
17979 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17980 method and its return type.
17981 (Event.conflict_symbol): New member. Symbol with same name in the
17985 (MemberCache.FindMemberWithSameName): New method. The method
17986 is looking for conflict with inherited symbols.
17988 2004-08-04 Martin Baulig <martin@ximian.com>
17990 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17992 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17994 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17996 * report.cs (Message): New enum for better error, warning reference in
17998 (MessageData): New inner abstract class. It generally handles printing of
17999 error and warning messages.
18000 Removed unused Error, Warning, Message methods.
18002 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18004 Fix for cs0592-8.cs test
18006 (Attributable.ValidAttributeTargets): Made public.
18007 (Attribute.ExplicitTarget): New member for explicit target value.
18008 (Attribute.CheckTargets): Now we translate explicit attribute
18009 target to Target here.
18011 2004-08-03 Ben Maurer <bmaurer@ximian.com>
18013 * ecore.cs (MethodGroupExpr): new IsBase property.
18015 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
18017 * delegate.cs (DelegateCreation): store a MethodGroupExpr
18018 rather than an instance expr.
18020 (DelegateCreation.Emit): Use the method group rather than
18021 the instance expression. Also, if you have base.Foo as the
18022 method for a delegate, make sure to emit ldftn, not ldftnvirt.
18024 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
18026 (NewDelegate.DoResolve): Only check for the existance of Invoke
18027 if the method is going to be needed. Use MethodGroupExpr.
18029 (NewDelegate.Emit): Remove, DelegateCreation implements this.
18031 * expression.cs: For pointer arith., make sure to use
18032 the size of the type, not the size of the pointer to
18035 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18038 * class.cs (Class): Added error CS0502 test.
18040 2004-08-03 John Luke <jluke@cfl.rr.com>
18041 Raja R Harinath <rharinath@novell.com>
18044 * attribute.cs (Attribute.complained_before): New flag.
18045 (Attribute.ResolveType, Attribute.Resolve),
18046 (Attribute.DefinePInvokeMethod): Set it.
18047 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
18049 2004-08-03 Martin Baulig <martin@ximian.com>
18051 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
18052 use a user-defined operator; we still need to do numeric
18053 promotions in case one argument is a builtin type and the other
18054 one has an implicit conversion to that type. Fixes #62322.
18056 2004-08-02 Martin Baulig <martin@ximian.com>
18058 * statement.cs (LocalInfo.Flags): Added `IsThis'.
18059 (LocalInfo.IsThis): New public property.
18060 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
18062 2004-08-01 Martin Baulig <martin@ximian.com>
18064 * class.cs (TypeContainer.GetClassBases): Don't set the default
18065 here since we may get called from GetPartialBases().
18066 (TypeContainer.DefineType): If GetClassBases() didn't return a
18067 parent, use the default one.
18069 2004-07-30 Duncan Mak <duncan@ximian.com>
18071 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
18073 2004-07-30 Martin Baulig <martin@ximian.com>
18075 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
18077 * class.cs (SourceMethod): New public class, derive from the
18078 symbol writer's ISourceMethod.
18079 (Method): Use the new symbol writer API.
18081 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
18082 as argument and use the new symbol writer.
18085 (SourceFile): Implement the symbol writer's ISourceFile.
18086 (Location.SymbolDocument): Removed.
18087 (Location.SourceFile): New public property.
18089 * symbolwriter.cs: Use the new symbol writer API.
18091 2004-07-30 Raja R Harinath <rharinath@novell.com>
18093 * Makefile (install-local): Remove. Functionality moved to
18096 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
18098 * Makefile: Install mcs.exe.config file together with mcs.exe.
18099 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
18100 correct runtime version.
18102 2004-07-25 Martin Baulig <martin@ximian.com>
18105 (TypeContainer.RegisterOrder): Removed, this was unused.
18106 (TypeContainer, interface_order): Removed.
18107 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
18108 TypeContainer as argument since we can also be called with a
18109 `PartialContainer' for a partial class/struct/interface.
18110 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
18111 of checking whether we're an `Interface' - we could be a
18112 `PartialContainer'.
18113 (PartialContainer.Register): Override; call
18114 AddClass()/AddStruct()/AddInterface() on our parent.
18116 * cs-parser.jay (interface_member_declaration): Add things to the
18117 `current_container', not the `current_class'.
18119 * rootcontext.cs (RegisterOrder): The overloaded version which
18120 takes an `Interface' was unused, removed.
18122 * typemanager.cs (TypeManager.LookupInterface): Return a
18123 `TypeContainer', not an `Interface'.
18124 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
18125 contain a `PartialContainer' for an interface, so check it's
18126 `Kind' to figure out what it is.
18128 2004-07-25 Martin Baulig <martin@ximian.com>
18130 * class.cs (Class.DefaultTypeAttributes): New public constant.
18131 (Struct.DefaultTypeAttributes): Likewise.
18132 (Interface.DefaultTypeAttributes): Likewise.
18133 (PartialContainer.TypeAttr): Override this and add the
18134 DefaultTypeAttributes.
18136 2004-07-25 Martin Baulig <martin@ximian.com>
18138 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
18139 we can just use the `Parent' field instead.
18141 2004-07-25 Martin Baulig <martin@ximian.com>
18143 * class.cs (TypeContainer.Emit): Renamed to EmitType().
18145 2004-07-25 Martin Baulig <martin@ximian.com>
18147 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
18148 our parts before defining any methods.
18149 (TypeContainer.VerifyImplements): Make this virtual.
18150 (ClassPart.VerifyImplements): Override and call VerifyImplements()
18151 on our PartialContainer.
18153 2004-07-25 Martin Baulig <martin@ximian.com>
18155 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
18157 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
18158 argument, we can just use the `Parent' field instead.
18161 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
18162 (MemberBase.DoDefine): Likewise.
18164 2004-07-24 Martin Baulig <martin@ximian.com>
18166 * decl.cs (MemberCore.Parent): New public field.
18167 (DeclSpace.Parent): Moved to MemberCore.
18169 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
18170 (MemberBase.ctor): Added TypeContainer argument, pass it to our
18172 (FieldBase, Field, Operator): Likewise.
18173 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
18174 (EventField, Event): Likewise.
18176 2004-07-23 Martin Baulig <martin@ximian.com>
18178 * class.cs (PartialContainer): New public class.
18179 (ClassPart): New public class.
18180 (TypeContainer): Added support for partial classes.
18181 (TypeContainer.GetClassBases): Splitted some of the functionality
18182 out into GetNormalBases() and GetPartialBases().
18184 * cs-tokenizer.cs (Token.PARTIAL): New token.
18185 (Tokenizer.consume_identifier): Added some hacks to recognize
18186 `partial', but only if it's immediately followed by `class',
18187 `struct' or `interface'.
18189 * cs-parser.jay: Added support for partial clases.
18191 2004-07-23 Martin Baulig <martin@ximian.com>
18193 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
18194 a `DeclSpace' and also made it readonly.
18195 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
18196 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
18197 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
18199 * cs-parser.jay: Pass the `current_class', not the
18200 `current_container' (at the moment, this is still the same thing)
18201 to a new Method, Property, Event, Indexer or Constructor.
18203 2004-07-23 Martin Baulig <martin@ximian.com>
18205 * cs-parser.jay (CSharpParser): Added a new `current_class' field
18206 and removed the `current_interface' one.
18207 (struct_declaration, class_declaration, interface_declaration):
18208 Set `current_class' to the newly created class/struct/interface;
18209 set their `Bases' and call Register() before parsing their body.
18211 2004-07-23 Martin Baulig <martin@ximian.com>
18213 * class.cs (Kind): New public enum.
18214 (TypeContainer): Made this class abstract.
18215 (TypeContainer.Kind): New public readonly field.
18216 (TypeContainer.CheckDef): New public method; moved here from
18218 (TypeContainer.Register): New public abstract method.
18219 (TypeContainer.GetPendingImplementations): New public abstract
18221 (TypeContainer.GetClassBases): Removed the `is_class' and
18222 `is_iface' parameters.
18223 (TypeContainer.DefineNestedTypes): Formerly known as
18225 (ClassOrStruct): Made this class abstract.
18227 * tree.cs (RootTypes): New public type.
18229 2004-07-20 Martin Baulig <martin@ximian.com>
18231 * tree.cs (Tree.RecordNamespace): Removed.
18232 (Tree.Namespaces): Removed.
18234 * rootcontext.cs (RootContext.IsNamespace): Removed.
18236 * cs-parser.jay (namespace_declaration): Just create a new
18237 NamespaceEntry here.
18239 2004-07-20 Martin Baulig <martin@ximian.com>
18241 * statement.cs (ExceptionStatement): New abstract class. This is
18242 now used as a base class for everyone who's using `finally'.
18243 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
18244 our local variables before using them.
18246 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
18247 virtual method. This is used by Yield.Resolve() to "steal" an
18248 outer block's `finally' clauses.
18249 (FlowBranchingException): The .ctor now takes an ExceptionStatement
18252 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
18253 version which takes an ExceptionStatement. This version must be
18254 used to create exception branchings.
18257 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
18258 (Iterator.EmitMoveNext): Added exception support; protect the
18259 block with a `fault' clause, properly handle 'finally' clauses.
18260 (Iterator.EmitDispose): Run all the `finally' clauses here.
18262 2004-07-20 Martin Baulig <martin@ximian.com>
18264 * iterator.cs: This is the first of a set of changes in the
18265 iterator code. Match the spec more closely: if we're an
18266 IEnumerable, then GetEnumerator() must be called. The first time
18267 GetEnumerator() is called, it returns the current instance; all
18268 subsequent invocations (if any) must create a copy.
18270 2004-07-19 Miguel de Icaza <miguel@ximian.com>
18272 * expression.cs: Resolve the constant expression before returning
18275 2004-07-19 Martin Baulig <martin@ximian.com>
18277 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
18278 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
18279 the return type of the new EmitContext.
18281 2004-07-18 Martin Baulig <martin@ximian.com>
18283 * class.cs (Property.Define): Fix iterators.
18285 * iterators.cs (Iterator.Define): Moved the
18286 `container.AddInterator (this)' call here from the .ctor; only do
18287 it if we resolved successfully.
18289 2004-07-17 Miguel de Icaza <miguel@ximian.com>
18291 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
18292 `true' for preprocessing directives that we parse. The return
18293 value indicates whether we should return to regular tokenizing or
18294 not, not whether it was parsed successfully.
18296 In the past if we were in: #if false ... #line #endif, we would
18297 resume parsing after `#line'. See bug 61604.
18299 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18300 building: IsEnumType should return true only for enums, not for
18301 enums or System.Enum itself. This fixes #61593.
18303 Likely what happened is that corlib was wrong: mcs depended on
18304 this bug in some places. The bug got fixed, we had to add the
18305 hack, which caused bug 61593.
18307 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18308 that was a workaround for the older conditions.
18310 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18312 * assign.cs: IAssignMethod has a new interface, as documented
18313 inline. All assignment code now uses this new api.
18315 * ecore.cs, expression.cs: All classes which implement
18316 IAssignMethod now use the new interface.
18318 * expression.cs (Invocation): add a hack to EmitCall so that
18319 IndexerAccess can be the target of a compound assignment without
18320 evaluating its arguments twice.
18322 * statement.cs: Handle changes in Invocation api.
18324 2004-07-16 Martin Baulig <martin@ximian.com>
18326 * iterators.cs: Rewrote this. We're now using one single Proxy
18327 class for both the IEnumerable and the IEnumerator interface and
18328 `Iterator' derives from Class so we can use the high-level API.
18330 * class.cs (TypeContainer.AddIterator): New method.
18331 (TypeContainer.DoDefineType): New protected virtual method, which
18332 is called from DefineType().
18333 (TypeContainer.DoDefineMembers): Call DefineType() and
18334 DefineMembers() on all our iterators.
18335 (TypeContainer.Emit): Call Emit() on all our iterators.
18336 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18338 * codegen.cs (EmitContext.CurrentIterator): New public field.
18340 2004-07-15 Martin Baulig <martin@ximian.com>
18343 (TypeManager.not_supported_exception_type): New type.
18345 2004-07-14 Martin Baulig <martin@ximian.com>
18347 * iterators.cs: Use real error numbers.
18349 2004-07-14 Martin Baulig <martin@ximian.com>
18351 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18352 requires this to be a System.Collection.IEnumerable and not a
18353 class implementing that interface.
18354 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18356 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18358 * class.cs: Fixed previous fix, it broke some error tests.
18360 2004-07-12 Martin Baulig <martin@ximian.com>
18362 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18365 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18367 * assign.cs (LocalTemporary): Add new argument: is_address,If
18368 `is_address' is true, then the value that we store is the address
18369 to the real value, and not the value itself.
18371 * ecore.cs (PropertyExpr): use the new local temporary
18372 stuff to allow us to handle X.Y += z (where X is a struct)
18374 2004-07-08 Martin Baulig <martin@ximian.com>
18376 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18377 not always return, just like we're doing in Using.Resolve().
18379 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18381 * cs-parser.jay (fixed_statement): flag this as Pinned.
18383 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18385 * typemanager.cs (TypeManager): Removed MakePinned method, this
18386 mechanism is replaced with the .NET 2.x compatible mechanism of
18387 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18389 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18390 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18391 `IsFixed' property which has a different meaning.
18393 2004-07-02 Raja R Harinath <rharinath@novell.com>
18395 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18396 visible from inside a nested class, not just the names of the
18397 immediately enclosing class.
18398 Fix for bug #60730.
18400 2004-06-24 Raja R Harinath <rharinath@novell.com>
18402 * expression.cs (BetterConversion): Remove buggy special-case
18403 handling of "implicit constant expression conversions". At this
18404 point, we already know that the conversion is possible -- we're
18405 only checking to see which is better.
18407 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18409 * cs-parser.jay: Added error CS0210 test.
18411 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18413 * cs-parser.jay: Added error CS0134 test.
18415 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18418 * cs-parser.jay: Added error CS0145 test.
18420 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18422 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18424 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18426 * expression.cs (StackAlloc.Resolve): The argument may not
18427 be a constant; deal with this case.
18429 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18431 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18432 GetIndexerAttributeValue.
18433 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18435 * class.cs (Indexer.Define): Added error tests for CS0415,
18438 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18440 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18443 2004-06-23 Martin Baulig <martin@ximian.com>
18445 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18446 neither return nor throw, reset the barrier as well. Fixes #60457.
18448 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18450 * class.cs : EventAttributes is now set to None by default.
18451 This fixes bug #60459.
18453 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18456 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18457 Don't throw exception but return null (it's sufficient now).
18459 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18461 * typemanager.cs (GetArgumentTypes): Faster implementation.
18463 2004-06-18 Martin Baulig <martin@ximian.com>
18465 * attribute.cs (Attribute.Resolve): Check whether we're an
18466 EmptyCast which a Constant child. Fixes #60333.
18468 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18470 * statement.cs (EmitCollectionForeach): Account for the fact that
18471 not all valuetypes are in areas which we can take the address of.
18472 For these variables, we store to a temporary variable. Also, make
18473 sure that we dont emit a `callvirt' on a valuetype method.
18475 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18477 * expression.cs (StackAlloc.DoReSolve): Added test for
18478 negative parameter (CS0247).
18480 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18483 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18485 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18488 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18491 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18493 Fix bug #58254 & cs1555.cs, cs1556.cs
18494 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18496 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18498 * cs-parser.jay: Added error CS1669 test for indexers.
18500 2004-06-11 Martin Baulig <martin@ximian.com>
18502 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18503 call this twice: for params and varargs methods.
18505 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18508 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18510 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18512 * attribute.cs (Attribute.GetValidTargets): Made public.
18515 (AbstractPropertyEventMethod): New class for better code sharing.
18516 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18518 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18520 2004-06-11 Raja R Harinath <rharinath@novell.com>
18523 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18524 that the call to Resolve is part of a MemberAccess.
18525 (Expression.Resolve): Use it for SimpleName resolution.
18526 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18527 Add 'intermediate' boolean argument.
18528 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18529 error message when the SimpleName can be resolved ambiguously
18530 between an expression and a type.
18531 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18533 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18534 call on the left-side.
18536 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18539 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18541 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18543 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18545 2004-06-11 Martin Baulig <martin@ximian.com>
18547 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18548 varargs methods if applicable.
18550 2004-06-11 Martin Baulig <martin@ximian.com>
18552 * expression.cs (Invocation.EmitCall): Don't use
18553 `method.CallingConvention == CallingConventions.VarArgs' since the
18554 method could also have `CallingConventions.HasThis'.
18556 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18558 * class.cs (Event.GetSignatureForError): Implemented.
18559 Fixed crash in error test cs3010.cs
18561 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18563 * cs-tokenizer.cs: Change the way we track __arglist to be
18564 consistent with the other keywords.
18566 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18568 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18571 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18573 * codegen.cs: Check that all referenced assemblies have a strongname
18574 before strongnaming the compiled assembly. If not report error CS1577.
18575 Fix bug #56563. Patch by Jackson Harper.
18576 * typemanager.cs: Added a method to return all referenced assemblies.
18577 Fix bug #56563. Patch by Jackson Harper.
18579 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18582 (Method.ApplyAttributeBuilder): Moved and added conditional
18583 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18586 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18588 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18591 * class.cs: (EventField.attribute_targets): Changed default target.
18593 2004-06-08 Martin Baulig <martin@ximian.com>
18595 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18597 2004-06-08 Martin Baulig <martin@ximian.com>
18599 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18601 2004-06-07 Martin Baulig <martin@ximian.com>
18603 Added support for varargs methods.
18605 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18608 * cs-parser.jay: Added support for `__arglist'.
18610 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18612 * expression.cs (Argument.AType): Added `ArgList'.
18613 (Invocation): Added support for varargs methods.
18614 (ArglistAccess): New public class.
18615 (Arglist): New public class.
18617 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18619 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18620 a method's top-level block if the method has varargs.
18622 * support.cs (ReflectionParameters, InternalParameters): Added
18623 support for varargs methods.
18625 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18627 * class.cs: Provide location in indexer error report.
18629 * driver.cs: Use standard names.
18631 * namespace.cs: Catch the use of using after a namespace has been
18632 declared also on using aliases.
18634 2004-06-03 Raja R Harinath <rharinath@novell.com>
18637 * typemanager.cs (closure_private_ok, closure_invocation_type)
18638 (closure_qualifier_type, closure_invocation_assembly)
18639 (FilterWithClosure): Move to ...
18640 (Closure): New internal nested class.
18641 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18642 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18643 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18644 (MemberLookup, MemberLookupFailed): Use it.
18645 * expression.cs (New.DoResolve): Treat the lookup for the
18646 constructor as being qualified by the 'new'ed type.
18647 (Indexers.GetIndexersForTypeOrInterface): Update.
18649 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18652 (GetConditionalAttributeValue): New method. Returns
18653 condition of ConditionalAttribute.
18654 (SearchMulti): New method. Returns all attributes of type 't'.
18655 Use it when attribute is AllowMultiple = true.
18656 (IsConditionalMethodExcluded): New method.
18659 (Method.IsExcluded): Implemented. Returns true if method has conditional
18660 attribute and the conditions is not defined (method is excluded).
18661 (IMethodData): Extended interface for ConditionalAttribute support.
18662 (PropertyMethod.IsExcluded): Implemented.
18665 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18668 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18671 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18673 * expression.cs (ArrayCreationExpression): Make this just an
18674 `expression'. It can't be a statement, so the code here was
18677 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18680 * typemanager.cs (GetFullNameSignature): New method for
18683 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18686 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18687 Use this method when MethodBuilder is null.
18688 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18689 Added test for error CS0626 (MONO reports error for this situation).
18690 (IMethodData.GetSignatureForError): Extended interface.
18692 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18695 (AttributeTester.GetObsoleteAttribute): Returns instance of
18696 ObsoleteAttribute when type is obsolete.
18699 (TypeContainer.VerifyObsoleteAttribute): Override.
18700 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18701 (MethodCode.VerifyObsoleteAttribute): Override.
18702 (MemberBase.VerifyObsoleteAttribute): Override.
18705 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18706 and report proper error.
18709 Delegate.VerifyObsoleteAttribute): Override.
18712 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18713 and report proper error.
18714 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18717 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18721 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18722 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18723 Added test for ObsoleteAttribute.
18726 (Catch): Derived from Statement.
18728 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18730 Fixed bug #59071 & cs0160.cs
18732 * statement.cs (Try.Resolve): Check here whether order of catch
18733 clauses matches their dependencies.
18735 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18737 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18738 caused a regression: #59343. Referencing nested classes from an
18739 assembly stopped working.
18741 2004-05-31 Martin Baulig <martin@ximian.com>
18743 MCS is now frozen for beta 2.
18745 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18747 * convert.cs: add a trivial cache for overload operator resolution.
18749 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18751 * decl.cs: If possible, use lookuptypedirect here. We can only do
18752 this if there is no `.' after the namespace. Avoids using
18753 LookupType, which does lots of slow processing.
18754 (FindNestedType) New method, does what it says :-).
18755 * namespace.cs: use LookupTypeDirect.
18756 * rootcontext.cs: use membercache, if possible.
18757 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18759 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18762 According to the spec,
18764 In a member access of the form E.I, if E is a single identifier,
18765 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18766 field, property, localvariable, or parameter with the same type as
18767 the meaning of E as a type-name (§3.8), then both possible
18768 meanings of E are permitted.
18770 We did not check that E as a simple-name had the same type as E as
18773 This trivial check gives us 5-7% on bootstrap time.
18775 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18777 * expression.cs (Invocation.OverloadResolve): Avoid the
18778 use of hashtables and boxing here by allocating on demand.
18780 2004-05-30 Martin Baulig <martin@ximian.com>
18782 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18783 we're doing a silent lookup. Don't try to lookup nested types in
18784 TypeManager.object_type (thanks to Ben Maurer).
18786 2004-05-30 Martin Baulig <martin@ximian.com>
18788 Committing a patch from Ben Maurer.
18790 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18792 2004-05-29 Martin Baulig <martin@ximian.com>
18794 * class.cs (IMethodData.ShouldIgnore): New method.
18796 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18797 `Location' argument, we don't need it anywhere. Use
18798 `IMethodData.ShouldIgnore ()' instead of
18799 `MethodData.GetMethodFlags ()'.
18800 (TypeManager.AddMethod): Removed.
18801 (TypeManager.AddMethod2): Renamed to AddMethod.
18803 2004-05-29 Martin Baulig <martin@ximian.com>
18805 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18807 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18808 converting from a class type S to an interface type and we already
18809 have an object on the stack, don't box it again. Fixes #52578.
18811 2004-05-29 Martin Baulig <martin@ximian.com>
18813 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18814 Added support for `params' parameters. Fixes #59267.
18816 2004-05-29 Martin Baulig <martin@ximian.com>
18818 * literal.cs (NullPointer): Provide a private .ctor which sets
18819 `type' to TypeManager.object_type. Fixes #59048.
18821 2004-05-29 Martin Baulig <martin@ximian.com>
18823 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18824 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18826 * ecore.cs (EventExpr.instance_expr): Make the field private.
18828 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18830 Fixed bug #50080 & cs0214-2.cs
18831 * expression.cs (Cast.DoResolve): Check unsafe context here.
18833 * statement.cs (Resolve.DoResolve): Likewise.
18835 2004-05-26 Martin Baulig <martin@ximian.com>
18837 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18839 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18840 (RootContext.LookupType): Pass down the `silent' flag.
18842 2004-05-25 Martin Baulig <martin@ximian.com>
18845 (MethodGroupExpr.IdenticalTypeName): New public property.
18846 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18847 expression actually refers to a type.
18849 2004-05-25 Martin Baulig <martin@ximian.com>
18851 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18852 for #56176 and made it actually work.
18854 2004-05-25 Martin Baulig <martin@ximian.com>
18856 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18857 (FieldExpr, PropertyExpr): Override and implement
18858 CacheTemporaries. Fixes #52279.
18860 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18862 * location.cs: In the new compiler listing a file twice is a
18863 warning, not an error.
18865 2004-05-24 Martin Baulig <martin@ximian.com>
18867 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18868 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18870 2004-05-24 Martin Baulig <martin@ximian.com>
18872 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18873 walking the `using' list. Fixes #53921.
18875 2004-05-24 Martin Baulig <martin@ximian.com>
18877 * const.cs (Const.LookupConstantValue): Added support for
18878 EmptyCast's; fixes #55251.
18880 2004-05-24 Martin Baulig <martin@ximian.com>
18882 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18883 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18884 which does the CS0135 check. The reason is that we first need to
18885 check whether the variable actually exists.
18887 2004-05-24 Martin Baulig <martin@ximian.com>
18889 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18890 than RootContext.LookupType() to find the explicit interface
18891 type. Fixes #58584.
18893 2004-05-24 Raja R Harinath <rharinath@novell.com>
18895 * Makefile: Simplify. Use executable.make.
18896 * mcs.exe.sources: New file. List of sources of mcs.exe.
18898 2004-05-24 Anders Carlsson <andersca@gnome.org>
18902 Use the invariant culture when doing String.Compare for CLS case
18905 2004-05-23 Martin Baulig <martin@ximian.com>
18907 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18908 don't have any dots. Fixes #52622, added cs0246-8.cs.
18910 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18912 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18914 * class.cs (MemberBase.Define): Reuse MemberType member for
18915 resolved type. Other methods can use it too.
18917 2004-05-23 Martin Baulig <martin@ximian.com>
18919 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18920 the variable also exists in the current block (otherwise, we need
18921 to report a CS0103). Fixes #58670.
18923 2004-05-23 Martin Baulig <martin@ximian.com>
18925 * flowanalysis.cs (Reachability.Reachable): Compute this
18926 on-the-fly rather than storing it as a field.
18928 2004-05-23 Martin Baulig <martin@ximian.com>
18930 * flowanalysis.cs (Reachability.And): Manually compute the
18931 resulting `barrier' from the reachability.
18933 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18936 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18937 instance of ObsoleteAttribute when symbol is obsolete.
18940 (IMethodData): Extended interface for ObsoleteAttribute support.
18942 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18944 * attribute.cs: Fix bug #55970
18946 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18950 (GetObsoleteAttribute): New method. Creates the instance of
18952 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18953 ObsoleteAttribute when member is obsolete.
18954 (AttributeTester.Report_ObsoleteMessage): Common method for
18955 Obsolete error/warning reporting.
18958 (TypeContainer.base_classs_type): New member for storing parent type.
18961 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18962 for this MemberCore.
18964 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18966 * attribute.cs, const.cs: Fix bug #58590
18968 2004-05-21 Martin Baulig <martin@ximian.com>
18970 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18971 out parameters if the end of the method is unreachable. Fixes
18974 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18976 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18977 Hari was right, why extra method.
18979 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18981 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18983 2004-05-20 Martin Baulig <martin@ximian.com>
18985 Merged this back from gmcs to keep the differences to a minumum.
18987 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18988 instead of a Declspace.
18989 (Attribute.ResolveType): Likewise.
18990 (Attributes.Search): Likewise.
18991 (Attributes.Contains): Likewise.
18992 (Attributes.GetClsCompliantAttribute): Likewise.
18994 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18996 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18999 2004-05-19 Marek Safar <marek.safar@seznam.cz>
19001 Fix bug #58688 (MCS does not report error when the same attribute
19004 * attribute.cs (Attribute.Emit): Distinction between null and default.
19006 2004-05-19 Raja R Harinath <rharinath@novell.com>
19008 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
19009 of a top-level attribute without an attribute target.
19010 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
19012 (Attribute.Conditional_GetConditionName),
19013 (Attribute.Obsolete_GetObsoleteMessage): Update.
19014 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
19015 part of ScanForIndexerName.
19016 (Attribute.CanIgnoreInvalidAttribute): New function.
19017 (Attribute.ScanForIndexerName): Move to ...
19018 (Attributes.ScanForIndexerName): ... here.
19019 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
19020 (Attributes.Search): New internal variant that can choose not to
19021 complain if types aren't resolved. The original signature now
19023 (Attributes.GetClsCompliantAttribute): Use internal variant, with
19024 complaints suppressed.
19025 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
19026 only if it not useful.
19027 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
19028 top-level for attributes that are shared between the assembly
19029 and a top-level class.
19030 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
19031 * class.cs: Update to reflect changes.
19032 (DefineIndexers): Fuse loops.
19033 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
19034 a couple more variants of attribute names.
19036 2004-05-18 Marek Safar <marek.safar@seznam.cz>
19038 Fix bug #52585 (Implemented explicit attribute declaration)
19041 (Attributable.ValidAttributeTargets): New abstract method. It gets
19042 list of valid attribute targets for explicit target declaration.
19043 (Attribute.Target): It holds target itself.
19044 (AttributeSection): Removed.
19045 (Attribute.CheckTargets): New method. It checks whether attribute
19046 target is valid for the current element.
19049 (EventProperty): New class. For events that are declared like
19050 property (with add and remove accessors).
19051 (EventField): New class. For events that are declared like field.
19054 * cs-parser.jay: Implemented explicit attribute target declaration.
19056 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
19057 Override ValidAttributeTargets.
19060 (ReturnParameter): Class for applying custom attributes on
19062 (ParameterAtribute): New class. Class for applying custom
19063 attributes on the parameter type.
19065 2004-05-17 Miguel de Icaza <miguel@ximian.com>
19067 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
19070 (Method): Allow UNSAFE here.
19072 * modifiers.cs: Support unsafe reporting.
19074 2004-05-17 Marek Safar <marek.safar@seznam.cz>
19076 * decl.cs: Fix bug #58478.
19078 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19080 * statement.cs: When checking for unreachable code on an EmptyStatement,
19081 set the location. Fixes bug #58488.
19083 2004-05-13 Miguel de Icaza <miguel@ximian.com>
19085 * driver.cs: Add -pkg handling.
19087 From Gonzalo: UseShelLExecute=false
19089 2004-05-12 Marek Safar <marek.safar@seznam.cz>
19092 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
19094 (Attribute.IsClsCompliaceRequired): Moved to base for better
19096 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
19097 when attribute is AttributeUsageAttribute.
19098 (Attribute.GetValidTargets): Simplified.
19099 (Attribute.GetAttributeUsage): New method returns AttributeUsage
19100 attribute for this type.
19101 (Attribute.ApplyAttributes): Method renamed to Emit and make
19103 (GlobalAttributeSection): New class for special handling of global
19104 attributes (assembly, module).
19105 (AttributeSection.Emit): New method.
19107 * class.cs: Implemented Attributable abstract methods.
19108 (MethodCore.LabelParameters): Moved to Parameter class.
19109 (Accessor): Is back simple class.
19110 (PropertyMethod): Implemented Attributable abstract class.
19111 (DelegateMethod): Implemented Attributable abstract class.
19112 (Event): New constructor for disctintion between normal Event
19113 and Event with accessors.
19115 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
19117 * codegen.cs, const.cs, decl.cs, delegate.cs:
19118 (CommonAssemblyModulClass): Implemented Attributable abstract class
19121 * enum.cs: Implement IAttributeSupport interface.
19122 (EnumMember): New class for emum members. Implemented Attributable
19126 (ParameterBase): Is abstract.
19127 (ReturnParameter): New class for easier [return:] attribute handling.
19129 * typemanager.cs: Removed builder_to_attr.
19131 2004-05-11 Raja R Harinath <rharinath@novell.com>
19134 * attribute.cs (Attribute.GetPositionalValue): New function.
19135 * class.cs (TypeContainer.VerifyMembers): New function.
19136 (TypeContainer.Emit): Use it.
19137 (ClassOrStruct): New base class for Class and Struct.
19138 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
19139 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
19141 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
19142 then each non-static field should have a FieldOffset attribute.
19143 Otherwise, none of the fields should have a FieldOffset attribute.
19144 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
19145 and FieldOffset attributes.
19146 * typemanager.cs (TypeManager.struct_layout_attribute_type)
19147 (TypeManager.field_offset_attribute_type): New core types.
19148 (TypeManager.InitCoreTypes): Initialize them.
19150 2004-05-11 Michal Moskal <malekith@pld-linux.org>
19152 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
19153 Return correct type.
19156 2004-05-09 Miguel de Icaza <miguel@ximian.com>
19158 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
19159 be implicitly converted to ulong.
19161 * expression.cs: The logic for allowing operator &, | and ^ worked
19162 was wrong, it worked before because we did not report an error in
19163 an else branch. Fixes 57895.
19165 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
19166 allow volatile fields to be reference types.
19168 2004-05-07 Miguel de Icaza <miguel@ximian.com>
19170 * driver.cs: Add support for /debug-
19172 2004-05-07 Raja R Harinath <rharinath@novell.com>
19174 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
19175 Add a 'complain' parameter to silence errors.
19176 (Attribute.Resolve): Update to changes. Put in sanity check to catch
19177 silently overlooked type-resolutions.
19178 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
19179 to reflect changes.
19180 (Attributes.Search): New function.
19181 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
19182 (Attributes.GetAttributeFullName): Remove hack.
19183 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
19184 Update to reflect changes.
19185 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
19186 Use Attributes.Search instead of nested loops.
19188 2004-05-07 Marek Safar <marek.safar@seznam.cz>
19191 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
19192 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
19193 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
19195 * report.cs: (Report.Warning): Renamed to Warning_T because of
19196 parameter collision.
19198 2004-05-05 Raja R Harinath <rharinath@novell.com>
19200 * expression.cs (MemberAccess.ResolveMemberAccess):
19201 Exit with non-zero status after Report.Error.
19202 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
19204 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
19206 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19208 * support.cs: Don't hang when the file is empty.
19210 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19212 * support.cs: In SeekableStreamReader, compute the preamble size of the
19213 underlying stream. Position changes should take into account that initial
19216 2004-05-03 Todd Berman <tberman@sevenl.net>
19218 * driver.cs: remove unused GetSysVersion function.
19220 2004-05-03 Todd Berman <tberman@sevenl.net>
19222 * driver.cs: Remove the hack from saturday, as well as the hack
19223 from jackson (LoadAssemblyFromGac), also adds the CWD to the
19224 link_paths to get that bit proper.
19226 2004-05-01 Todd Berman <tberman@sevenl.net>
19228 * driver.cs: Try a LoadFrom before a Load, this checks the current
19229 path. This is currently a bug in mono that is be fixed, however, this
19230 provides a workaround for now. This will be removed when the bug
19233 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
19235 * CryptoConvert.cs: Updated to latest version. Fix issue with
19236 incomplete key pairs (#57941).
19238 2004-05-01 Todd Berman <tberman@sevenl.net>
19240 * driver.cs: Remove '.' from path_chars, now System.* loads properly
19243 2004-04-30 Jackson Harper <jackson@ximian.com>
19245 * codegen.cs: Open keys readonly.
19247 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19249 * typemanager.cs: don't report cyclic struct layout when a struct
19250 contains 2 or more fields of the same type. Failed for Pango.AttrShape
19251 which has 2 Pango.Rectangle fields.
19253 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
19255 * expression.cs: Handle IntPtr comparisons with IL code
19256 rather than a method call.
19258 2004-04-29 Martin Baulig <martin@ximian.com>
19260 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
19261 the list of PropertyInfo's in class hierarchy and find the
19262 accessor. Fixes #56013.
19264 2004-04-29 Martin Baulig <martin@ximian.com>
19266 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
19268 2004-04-29 Martin Baulig <martin@ximian.com>
19270 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19272 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
19274 2004-04-29 Martin Baulig <martin@ximian.com>
19276 * class.cs (ConstructorInitializer.Resolve): Check whether the
19277 parent .ctor is accessible. Fixes #52146.
19279 2004-04-29 Martin Baulig <martin@ximian.com>
19281 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19283 * statement.cs (Using.EmitLocalVariableDecls): Use
19284 TypeManager.idisposable_type, not typeof (IDisposable).
19285 (Foreach.EmitCollectionForeach): Added support for valuetypes.
19287 2004-04-29 Martin Baulig <martin@ximian.com>
19289 * class.cs (Event.Define): Don't emit the field and don't set
19290 RTSpecialName and SpecialName for events on interfaces. Fixes
19293 2004-04-29 Raja R Harinath <rharinath@novell.com>
19295 Refactor Attribute.ApplyAttributes.
19296 * attribute.cs (Attributable): New base class for objects that can
19297 have Attributes applied on them.
19298 (Attribute): Make AttributeUsage fields public.
19299 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19300 (Attribute.IsInternalCall): New property.
19301 (Attribute.UsageAttr): Convert to a public read-only property.
19302 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19303 (Attribute.ResolveType, Attribute.Resolve)
19304 (Attribute.ScanForIndexerName): Update to reflect changes.
19305 (Attribute.CheckAttributeTarget): Re-format.
19306 (Attribute.ApplyAttributes): Refactor, to various
19307 Attributable.ApplyAttributeBuilder methods.
19308 * decl.cs (MemberCore): Make Attributable.
19309 * class.cs (Accessor): Make Attributable.
19310 (MethodData.ApplyAttributes): Use proper attribute types, not
19312 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19313 (TypeContainer.ApplyAttributeBuilder)
19314 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19315 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19316 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19317 (Operator.ApplyAttributeBuilder): New factored-out methods.
19318 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19319 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19320 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19321 * parameter.cs (ParameterBase): New Attributable base class
19322 that can also represent Return types.
19323 (Parameter): Update to the changes.
19325 2004-04-29 Jackson Harper <jackson@ximian.com>
19327 * driver.cs: Prefer the corlib system version when looking for
19328 assemblies in the GAC. This is still a hack, but its a better hack
19331 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19333 * decl.cs, enum.cs: Improved error 3005 reporting.
19335 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19336 (related_symbols): New private member for list of symbols
19337 related to reported error/warning.
19339 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19341 2004-04-29 Martin Baulig <martin@ximian.com>
19343 * ecore.cs (Expression.Constantify): If we're an enum and
19344 TypeManager.TypeToCoreType() doesn't give us another type, use
19345 t.UnderlyingSystemType. Fixes #56178.
19347 2004-04-29 Martin Baulig <martin@ximian.com>
19349 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19350 interfaces and for each interface, only add members directly
19351 declared in that interface. Fixes #53255.
19353 2004-04-28 Martin Baulig <martin@ximian.com>
19355 * expression.cs (ConditionalLogicalOperator): Use a temporary
19356 variable for `left' to avoid that we evaluate it more than once;
19359 2004-04-28 Martin Baulig <martin@ximian.com>
19361 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19364 2004-04-28 Martin Baulig <martin@ximian.com>
19366 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19369 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19370 whether the type is not void (CS1547).
19372 2004-04-28 Martin Baulig <martin@ximian.com>
19374 * expression.cs (Unary.DoResolveLValue): Override this and report
19375 CS0131 for anything but Operator.Indirection.
19377 2004-04-28 Martin Baulig <martin@ximian.com>
19379 Committing a patch from Ben Maurer; see bug #50820.
19381 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19384 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19387 2004-04-28 Martin Baulig <martin@ximian.com>
19389 Committing a patch from Ben Maurer; see bug #50820.
19391 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19394 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19397 2004-04-28 Martin Baulig <martin@ximian.com>
19399 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19400 (Block.AddLabel): Call DoLookupLabel() to only search in the
19403 2004-04-28 Martin Baulig <martin@ximian.com>
19405 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19406 comparing StringConstants and NullLiterals in Equality and Inequality.
19408 2004-04-28 Jackson Harper <jackson@ximian.com>
19410 * driver.cs: Attempt to load referenced assemblies from the
19411 GAC. This is the quick and dirty version of this method that
19412 doesnt take into account versions and just takes the first
19413 canidate found. Will be good enough for now as we will not have more
19414 then one version installed into the GAC until I update this method.
19416 2004-04-28 Martin Baulig <martin@ximian.com>
19418 * typemanager.cs (TypeManager.CheckStructCycles): New public
19419 static method to check for cycles in the struct layout.
19421 * rootcontext.cs (RootContext.PopulateTypes): Call
19422 TypeManager.CheckStructCycles() for each TypeContainer.
19423 [Note: We only need to visit each type once.]
19425 2004-04-28 Martin Baulig <martin@ximian.com>
19427 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19429 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19430 success and added `out object value'. Use a `bool resolved' field
19431 to check whether we've already been called rather than
19432 `ConstantValue != null' since this breaks for NullLiterals.
19434 2004-04-28 Raja R Harinath <rharinath@novell.com>
19436 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19437 setting of this flag, since the 'set' method may be non-public.
19439 2004-04-28 Raja R Harinath <rharinath@novell.com>
19441 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19442 check on current_vector.Block.
19444 2004-04-27 Martin Baulig <martin@ximian.com>
19446 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19447 a field initializer. Fixes #56459.
19449 2004-04-27 Martin Baulig <martin@ximian.com>
19451 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19452 we're not attempting to use an indexer. Fixes #52154.
19454 2004-04-27 Martin Baulig <martin@ximian.com>
19456 * statement.cs (Return): Don't create a return label if we don't
19457 need it; reverts my change from January 20th. Thanks to Ben
19460 2004-04-27 Martin Baulig <martin@ximian.com>
19462 According to the spec, `goto' can only leave a nested scope, but
19465 * statement.cs (Block.LookupLabel): Only lookup in the current
19466 block, don't recurse into parent or child blocks.
19467 (Block.AddLabel): Check in parent and child blocks, report
19468 CS0140/CS0158 if we find a duplicate.
19469 (Block): Removed this indexer for label lookups.
19470 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19471 this already does the error reporting for us.
19474 (FlowBranching.UsageVector.Block): New public variable; may be null.
19475 (FlowBranching.CreateSibling): Added `Block' argument.
19476 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19477 label for the target of a `goto' and check whether we're not
19478 leaving a `finally'.
19480 2004-04-27 Martin Baulig <martin@ximian.com>
19482 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19483 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19486 2004-04-27 Martin Baulig <martin@ximian.com>
19488 * statement.cs (Block.AddLabel): Also check for implicit blocks
19489 and added a CS0158 check.
19491 2004-04-27 Martin Baulig <martin@ximian.com>
19493 * flowanalysis.cs (FlowBranchingLoop): New class.
19494 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19495 UsageVector's instead of an ArrayList.
19496 (FlowBranching.Label): Likewise.
19497 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19498 (FlowBranching.AddBreakVector): New method.
19500 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19502 * attribute.cs: Small regression fix: only convert the type if we
19503 the type is different, fixes System.Drawing build.
19505 2004-04-27 Martin Baulig <martin@ximian.com>
19507 * attribute.cs (Attribute.Resolve): If we have a constant value
19508 for a named field or property, implicity convert it to the correct
19511 2004-04-27 Raja R Harinath <rharinath@novell.com>
19513 * statement.cs (Block.Block): Implicit blocks share
19514 'child_variable_names' fields with parent blocks.
19515 (Block.AddChildVariableNames): Remove.
19516 (Block.AddVariable): Mark variable as "used by a child block" in
19517 every surrounding block.
19518 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19519 been used in a child block, complain about violation of "Invariant
19520 meaning in blocks" rule.
19521 * cs-parser.jay (declare_local_variables): Don't use
19522 AddChildVariableNames.
19523 (foreach_statement): Don't create an implicit block: 'foreach'
19524 introduces a scope.
19526 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19528 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19529 converting from 0L to ulong. Fixes 57522.
19531 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19533 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19534 derived class hides via 'new' keyword field from base class (test-242.cs).
19535 TODO: Handle this in the more general way.
19537 * class.cs (CheckBase): Ditto.
19539 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19541 * decl.cs (caching_flags): New member for storing cached values
19543 (MemberCore.Flags): New enum where bit flags for caching_flags
19545 (MemberCore.cls_compliance): Moved to caching_flags.
19546 (DeclSpace.Created): Moved to caching_flags.
19548 * class.cs: Use caching_flags instead of DeclSpace.Created
19550 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19552 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19553 if we are only a derived class, not a nested class.
19555 * typemanager.cs: Same as above, but do this at the MemberLookup
19556 level (used by field and methods, properties are handled in
19557 PropertyExpr). Allow for the qualified access if we are a nested
19560 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19562 * class.cs: Refactoring.
19563 (IMethodData): New inteface; Holds links to parent members
19564 to avoid member duplication (reduced memory allocation).
19565 (Method): Implemented IMethodData interface.
19566 (PropertyBase): New inner classes for get/set methods.
19567 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19568 (Event): New inner classes for add/remove methods.
19569 (Event.DelegateMethod): Implemented IMethodData interface.
19571 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19572 EmitContext (related to class.cs refactoring).
19574 2004-04-21 Raja R Harinath <rharinath@novell.com>
19576 * delegate.cs (Delegate.VerifyApplicability): If the number of
19577 arguments are the same as the number of parameters, first try to
19578 verify applicability ignoring any 'params' modifier on the last
19582 2004-04-16 Raja R Harinath <rharinath@novell.com>
19584 * class.cs (TypeContainer.AddIndexer): Use
19585 'ExplicitInterfaceName' to determine if interface name was
19586 explicitly specified. 'InterfaceType' is not initialized at this time.
19587 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19588 Indexers array is already in the required order. Initialize
19589 'IndexerName' only if there are normal indexers.
19590 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19591 (TypeContainer.Emit): Emit DefaultMember attribute only if
19592 IndexerName is initialized.
19595 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19597 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19600 2004-04-15 Raja R Harinath <rharinath@novell.com>
19602 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19606 * attribute.cs (Attribute.Resolve): Check for duplicate named
19610 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19612 * iterators.cs (MarkYield): track whether we are in an exception,
19613 and generate code accordingly. Use a temporary value to store the
19614 result for our state.
19616 I had ignored a bit the interaction of try/catch with iterators
19617 since their behavior was not entirely obvious, but now it is
19618 possible to verify that our behavior is the same as MS .NET 2.0
19622 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19624 * iterators.cs: Avoid creating temporaries if there is no work to
19627 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19628 Enumerations, use TypeManager.EnumToUnderlying and call
19631 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19634 (This.Emit): Use EmitContext.EmitThis to emit our
19637 (This.EmitAssign): Ditto.
19639 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19640 codepaths, we will move all the functionality into
19643 (FieldExpr.EmitAssign): Ditto.
19645 This fixes several hidden bugs that I uncovered while doing a code
19646 review of this today.
19648 * codegen.cs (EmitThis): reworked so the semantics are more clear
19649 and also support value types "this" instances.
19651 * iterators.cs: Changed so that for iterators in value types, we
19652 do not pass the value type as a parameter.
19654 Initialization of the enumerator helpers is now done in the caller
19655 instead of passing the parameters to the constructors and having
19656 the constructor set the fields.
19658 The fields have now `assembly' visibility instead of private.
19660 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19662 * expression.cs (Argument.Resolve): Check if fields passed as ref
19663 or out are contained in a MarshalByRefObject.
19665 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19666 another compiler type.
19668 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19670 * class.cs (Indexer.Define): use the new name checking method.
19671 Also, return false on an error.
19672 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19673 (is_identifier_[start/part]_character): make static.
19675 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19677 * expression.cs (Binary.ResolveOperator): Do no append strings
19678 twice: since we can be invoked more than once (array evaluation)
19679 on the same concatenation, take care of this here. Based on a fix
19680 from Ben (bug #56454)
19682 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19684 * codegen.cs: Fix another case where CS1548 must be reported (when
19685 delay-sign isn't specified and no private is available #56564). Fix
19686 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19687 error when MCS is used on the MS runtime and we need to delay-sign
19688 (which seems unsupported by AssemblyBuilder - see #56621).
19690 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19692 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19693 (TypeManager.ComputeNamespaces): Faster implementation for
19696 * compiler.csproj: Updated AssemblyName to mcs.
19698 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19700 * rootcontext.cs: Add new types to the boot resolution.
19702 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19703 MulticastDelegate is not allowed.
19705 * typemanager.cs: Add new types to lookup: System.TypedReference
19708 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19709 check for TypedReference or ArgIterator, they are not allowed.
19711 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19712 makes us properly catch 1510 in some conditions (see bug 56016 for
19715 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19717 * CryptoConvert.cs: update from corlib version
19720 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19722 * class.cs (Indexer.Define): Check indexername declaration
19724 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19726 * attribute.cs (IsClsCompliant): Fixed problem with handling
19727 all three states (compliant, not-compliant, undetected).
19729 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19731 * attribute.cs (Attribute): Location is now public.
19732 (Resolve): Store resolved arguments (pos_values) in attribute class.
19733 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19734 (GetClsCompliantAttributeValue): New method that gets
19735 CLSCompliantAttribute value.
19736 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19737 if exists else null.
19738 (AttributeTester): New class for CLS-Compliant verification routines.
19740 * class.cs (Emit): Add CLS-Compliant verification.
19741 (Method.GetSignatureForError): Implemented.
19742 (Constructor.GetSignatureForError): Implemented
19743 (Constructor.HasCompliantArgs): Returns if constructor has
19744 CLS-Compliant arguments.
19745 (Constructor.Emit): Override.
19746 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19747 is needed to test only parameters.
19748 (FieldBase.GetSignatureForError): Implemented.
19749 (TypeContainer): New member for storing base interfaces.
19750 (TypeContainer.FindMembers): Search in base interfaces too.
19752 * codegen.cs (GetClsComplianceAttribute): New method that gets
19753 assembly or module CLSCompliantAttribute value.
19754 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19756 (ModuleClass.Emit): Add error 3012 test.
19758 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19760 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19761 state for all decl types.
19762 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19763 if CLS-Compliant tests are required.
19764 (IsClsCompliaceRequired): New method. Analyze whether code
19765 must be CLS-Compliant.
19766 (IsExposedFromAssembly): New method. Returns true when MemberCore
19767 is exposed from assembly.
19768 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19769 value or gets cached value.
19770 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19771 is explicitly marked with CLSCompliantAttribute.
19772 (IsIdentifierClsCompliant): New abstract method. This method is
19773 used to testing error 3005.
19774 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19775 for identifier and parameters CLS-Compliant testing.
19776 (VerifyClsCompliance): New method. The main virtual method for
19777 CLS-Compliant verifications.
19778 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19779 null. I don't know why is null (too many public members !).
19780 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19781 and get value of first CLSCompliantAttribute that found.
19783 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19784 (VerifyClsCompliance): Override and add extra tests.
19786 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19787 clscheck- disable CLS-Compliant verification event if assembly is has
19788 CLSCompliantAttribute(true).
19790 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19791 ApllyAttribute is now called in emit section as in the other cases.
19792 Possible future Emit integration.
19793 (IsIdentifierClsCompliant): New override.
19794 (VerifyClsCompliance): New override.
19795 (GetEnumeratorName): Returns full enum name.
19797 * parameter.cs (GetSignatureForError): Implemented.
19799 * report.cs (WarningData): New struct for Warning message information.
19800 (LocationOfPreviousError): New method.
19801 (Warning): New method. Reports warning based on the warning table.
19802 (Error_T): New method. Reports error based on the error table.
19804 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19805 verifications are done here.
19807 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19809 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19810 CLSCompliantAttribute.
19811 (all_imported_types): New member holds all imported types from other
19813 (LoadAllImportedTypes): New method fills static table with exported types
19814 from all referenced assemblies.
19815 (Modules): New property returns all assembly modules.
19817 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19819 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19820 throwing a parser error.
19822 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19823 which removes the hardcoded get_/set_ prefixes for properties, as
19824 IL allows for the properties to be named something else.
19828 * expression.cs: Do not override operand before we know if it is
19829 non-null. Fix 56207
19831 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19833 * typemanager.cs: support for pinned variables.
19835 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19837 * decl.cs, typemanager.cs: Avoid using an arraylist
19838 as a buffer if there is only one result set.
19840 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19842 * expression.cs: Make sure you cant call a static method
19843 with an instance expression, bug #56174.
19845 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19847 * class.cs (IsDuplicateImplementation): Improve error reporting to
19848 flag 663 (method only differs in parameter modifier).
19850 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19851 in preprocessor directives.
19853 * location.cs (LookupFile): Allow for the empty path.
19855 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19856 better approach for some of that patch, but its failing with the
19857 CharSet enumeration. For now try/catch will do.
19859 * typemanager.cs: Do not crash if a struct does not have fields.
19862 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19864 * expression.cs: cs0213, cant fix a fixed expression.
19867 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19869 * cs-parser.jay: detect invalid embeded statements gracefully.
19872 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19874 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19877 the invocation type may not be a subclass of the tye of the item/
19878 The type of the item must be a subclass of the invocation item.
19883 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19885 * attribute.cs: Added methods to get a string and a bool from an
19886 attribute. Required to information from AssemblyKeyFileAttribute,
19887 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19888 * codegen.cs: Modified AssemblyName creation to include support for
19889 strongnames. Catch additional exceptions to report them as CS1548.
19890 * compiler.csproj: Updated include CryptoConvert.cs.
19891 * compiler.csproj.user: Removed file - user specific configuration.
19892 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19893 Mono.Security assembly. The original class is maintained and tested in
19894 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19895 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19896 like CSC 8.0 (C# v2) supports.
19897 * Makefile: Added CryptoConvert.cs to mcs sources.
19898 * rootcontext.cs: Added new options for strongnames.
19900 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19902 * driver.cs: For --expect-error, report error code `2'
19903 if the program compiled with no errors, error code `1' if
19904 it compiled with an error other than the one expected.
19906 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19908 * compiler.csproj: Updated for Visual Studio .NET 2003.
19909 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19910 * compiler.sln: Updated for Visual Studio .NET 2003.
19912 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19914 * expression.cs: Fix bug #47234. We basically need to apply the
19915 rule that we prefer the conversion of null to a reference type
19916 when faced with a conversion to 'object' (csc behaviour).
19918 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19920 * statement.cs: Shorter form for foreach, eliminates
19921 a local variable. r=Martin.
19923 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19925 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19926 checks if we can use brtrue/brfalse to test for 0.
19927 * expression.cs: use the above in the test for using brtrue/brfalse.
19928 cleanup code a bit.
19930 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19932 * expression.cs: Rewrite string concat stuff. Benefits:
19934 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19935 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19936 rather than a concat chain.
19938 * typemanager.cs: Add lookups for more concat overloads.
19940 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19942 * expression.cs: Emit shorter il code for array init.
19959 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19961 * statement.cs: Before, two switch blocks would be merged if the
19962 total size of the blocks (end_item - begin_item + 1) was less than
19963 two times the combined sizes of the blocks.
19965 Now, it will only merge if after the merge at least half of the
19970 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19972 * class.cs : csc build fix for GetMethods(). See bug #52503.
19974 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19976 * expression.cs: Make sure fp comparisons work with NaN.
19977 This fixes bug #54303. Mig approved this patch a long
19978 time ago, but we were not able to test b/c the runtime
19981 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19983 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19985 2004-03-19 Martin Baulig <martin@ximian.com>
19987 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19988 error here and not in our caller.
19990 2004-03-19 Martin Baulig <martin@ximian.com>
19992 * interface.cs: Completely killed this file.
19993 (Interface): We're now a TypeContainer and live in class.cs.
19995 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19996 argument; we're now also called for interfaces.
19997 (TypeContainer.DefineMembers): Allow this method being called
19999 (TypeContainer.GetMethods): New public method; formerly known as
20000 Interface.GetMethod(). This is used by PendingImplementation.
20001 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
20002 it's now private and non-static.
20003 (Interface): Moved this here; it's now implemented similar to
20005 (Method, Property, Event, Indexer): Added `bool is_interface'
20006 argument to their .ctor's.
20007 (MemberBase.IsInterface): New public field.
20009 * cs-parser.jay: Create normal Method, Property, Event, Indexer
20010 instances instead of InterfaceMethod, InterfaceProperty, etc.
20011 (opt_interface_base): Removed; we now use `opt_class_base' instead.
20012 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
20014 2004-03-19 Martin Baulig <martin@ximian.com>
20016 * class.cs (MethodCore.IsDuplicateImplementation): New private
20017 method which does the CS0111 checking.
20018 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
20019 Use IsDuplicateImplementation().
20021 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
20023 * decl.cs (FindMemberToOverride): New method to find the correct
20024 method or property to override in the base class.
20026 - Make Method/Property use the above method to find the
20027 version in the base class.
20028 - Remove the InheritableMemberSignatureCompare as it is now
20031 This patch makes large code bases much faster to compile, as it is
20032 O(n) rather than O(n^2) to do this validation.
20034 Also, it fixes bug 52458 which is that nested classes are not
20035 taken into account when finding the base class member.
20037 Reviewed/Approved by Martin.
20039 2004-03-17 Marek Safar <marek.safar@seznam.cz>
20041 * interface.cs: In all interface classes removed redundant
20042 member initialization.
20044 2004-03-16 Martin Baulig <martin@ximian.com>
20046 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
20048 2004-03-15 Miguel de Icaza <miguel@ximian.com>
20050 * decl.cs (DefineTypeAndParents): New helper method to define a
20051 type's containers before the type itself is defined; This is a
20052 bug exposed by the recent changes to Windows.Forms when an
20053 implemented interface was defined inside a class that had not been
20056 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
20058 (Check): Loop correctly to report errors modifiers
20059 (UNSAFE was not in the loop, since it was the same as TOP).
20061 * interface.cs: Every interface member now takes a ModFlags,
20062 instead of a "is_new" bool, which we set on the base MemberCore.
20064 Every place where we called "UnsafeOk" in the interface, now we
20065 call the proper member (InterfaceMethod.UnsafeOK) instead to get
20066 the unsafe settings from the member declaration instead of the
20067 container interface.
20069 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
20071 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
20072 `set_indexer_name' to the pending bits (one per type).
20074 We fixed a bug today that was picking the wrong method to
20075 override, since for properties the existing InterfaceMethod code
20076 basically ignored the method name. Now we make sure that the
20077 method name is one of the valid indexer names.
20079 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
20081 * support.cs (SeekableStreamReader): Keep track of stream byte
20082 positions and don't mix them with character offsets to the buffer.
20084 Patch from Gustavo Giráldez
20086 2004-03-15 Marek Safar <marek.safar@seznam.cz>
20088 * interface.cs (InterfaceSetGetBase): Removed double member
20089 initialization, base class does it as well.
20091 2004-03-13 Martin Baulig <martin@ximian.com>
20093 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
20094 when compiling corlib.
20096 2004-03-13 Miguel de Icaza <miguel@ximian.com>
20098 * convert.cs (ExplicitConversion): We were reporting an error on
20099 certain conversions (object_type source to a value type, when the
20100 expression was `null') before we had a chance to pass it through
20101 the user defined conversions.
20103 * driver.cs: Replace / and \ in resource specifications to dots.
20106 * class.cs: Add check for duplicate operators. Fixes 52477
20108 2004-03-11 Miguel de Icaza <miguel@ximian.com>
20110 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
20111 that are in the middle of the statements, not only at the end.
20114 * class.cs (TypeContainer.AddField): No longer set the
20115 `HaveStaticConstructor' flag, now we call it
20116 `UserDefineStaticConstructor' to diferentiate the slightly
20117 semantic difference.
20119 The situation is that we were not adding BeforeFieldInit (from
20120 Modifiers.TypeAttr) to classes that could have it.
20121 BeforeFieldInit should be set to classes that have no static
20126 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
20128 And most importantly Zoltan's comment:
20130 http://bugzilla.ximian.com/show_bug.cgi?id=44229
20132 "I think beforefieldinit means 'it's ok to initialize the type sometime
20133 before its static fields are used', i.e. initialization does not need
20134 to be triggered by the first access to the type. Setting this flag
20135 helps the JIT to compile better code, since it can run the static
20136 constructor at JIT time, and does not need to generate code to call it
20137 (possibly lots of times) at runtime. Unfortunately, mcs does not set
20138 this flag for lots of classes like String.
20140 csc sets this flag if the type does not have an explicit static
20141 constructor. The reasoning seems to be that if there are only static
20142 initalizers for a type, and no static constructor, then the programmer
20143 does not care when this initialization happens, so beforefieldinit
20146 This bug prevents the AOT compiler from being usable, since it
20147 generates so many calls to mono_runtime_class_init that the AOT code
20148 is much slower than the JITted code. The JITted code is faster,
20149 because it does not generate these calls if the vtable is type is
20150 already initialized, which is true in the majority of cases. But the
20151 AOT compiler can't do this."
20153 2004-03-10 Miguel de Icaza <miguel@ximian.com>
20155 * class.cs (MethodData.Emit): Refactor the code so symbolic
20156 information is generated for destructors; For some reasons we
20157 were taking a code path that did not generate symbolic information
20160 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
20162 * class.cs: Create a Constructor.CheckBase method that
20163 takes care of all validation type code. The method
20164 contains some code that was moved from Define.
20166 It also includes new code that checks for duplicate ctors.
20167 This fixes bug #55148.
20169 2004-03-09 Joshua Tauberer <tauberer@for.net>
20171 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
20172 a { ... }-style array creation invokes EmitStaticInitializers
20173 which is not good for reference-type arrays. String, decimal
20174 and now null constants (NullCast) are not counted toward
20175 static initializers.
20177 2004-03-05 Martin Baulig <martin@ximian.com>
20179 * location.cs (SourceFile.HasLineDirective): New public field;
20180 specifies whether the file contains or is referenced by a "#line"
20182 (Location.DefineSymbolDocuments): Ignore source files which
20183 either contain or are referenced by a "#line" directive.
20185 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
20187 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
20188 direct access to our parent, so check the method inline there.
20190 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
20192 * expression.cs (Invocation.EmitCall): Miguel's last commit
20193 caused a regression. If you had:
20198 In Foo the implict this would be null.
20200 2004-02-27 Miguel de Icaza <miguel@ximian.com>
20202 * expression.cs (Invocation.EmitCall): If the method is not
20203 virtual, do not emit a CallVirt to it, use Call.
20205 * typemanager.cs (GetFullNameSignature): Improve the method to
20206 cope with ".ctor" and replace it with the type name.
20208 * class.cs (ConstructorInitializer.Resolve): Now the method takes
20209 as an argument the ConstructorBuilder where it is being defined,
20210 to catch the recursive constructor invocations.
20212 2004-02-26 Miguel de Icaza <miguel@ximian.com>
20214 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
20215 routines to check if a type is an enumerable/enumerator allow
20216 classes that implement the IEnumerable or IEnumerator interfaces.
20218 * class.cs (Property, Operator): Implement IIteratorContainer, and
20219 implement SetYields.
20221 (Property.Define): Do the block swapping for get_methods in the
20222 context of iterators. We need to check if Properties also
20223 include indexers or not.
20225 (Operator): Assign the Block before invoking the
20226 OperatorMethod.Define, so we can trigger the Iterator code
20229 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
20230 Property and Operator classes are not created when we parse the
20231 declarator but until we have the block completed, so we use a
20232 singleton SimpleIteratorContainer.Simple to flag whether the
20233 SetYields has been invoked.
20235 We propagate this setting then to the Property or the Operator to
20236 allow the `yield' to function.
20238 2004-02-25 Marek Safar <marek.safar@seznam.cz>
20240 * codegen.cs: Implemented attribute support for modules.
20241 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
20242 Assembly/Module functionality.
20244 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
20245 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
20246 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
20248 2004-02-16 Marek Safar <marek.safar@seznam.cz>
20250 * interface.cs (FindMembers): The operation is performed on all base
20251 interfaces and not only on the first. It is required for future CLS Compliance patch.
20253 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
20255 * statement.cs, codegen.cs:
20256 This patch deals with patterns such as:
20258 public class List : IEnumerable {
20260 public MyEnumerator GetEnumerator () {
20261 return new MyEnumerator(this);
20264 IEnumerator IEnumerable.GetEnumerator () {
20268 public struct MyEnumerator : IEnumerator {
20273 Before, there were a few things we did wrong:
20274 1) we would emit callvirt on a struct, which is illegal
20275 2) we emited ldarg when we needed to emit ldarga
20276 3) we would mistakenly call the interface methods on an enumerator
20277 type that derived from IEnumerator and was in another assembly. For example:
20279 public class MyEnumerator : IEnumerator
20281 Would have the interface methods called, even if there were public impls of the
20282 method. In a struct, this lead to invalid IL code.
20284 2004-02-11 Marek Safar <marek.safar@seznam.cz>
20286 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
20289 * delegate.cs (Define): Fixed crash when delegate type is undefined.
20291 2004-02-11 Miguel de Icaza <miguel@ximian.com>
20293 * cs-parser.jay: Fix small regression: we were not testing V2
20294 compiler features correctly.
20296 * interface.cs: If the emit context is null, then create one
20298 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20300 * decl.cs (GetSignatureForError): New virtual method to get full name
20301 for error messages.
20303 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20304 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20306 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20307 Duplicated members and code in these classes has been removed.
20308 Better encapsulation in these classes.
20310 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20312 * assign.cs (Assign.DoResolve): When dealing with compound
20313 assignments, there is a new rule in ECMA C# 2.4 (might have been
20314 there before, but it is documented here) that states that in:
20318 If b is of type int, and the `op' is a shift-operator, then the
20319 above is evaluated as:
20323 * expression.cs (Binary.ResolveOperator): Instead of testing for
20324 int/uint/long/ulong, try to implicitly convert to any of those
20325 types and use that in pointer arithmetic.
20327 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20328 method to print information for from the type, not from the
20329 null-method we were given.
20331 2004-02-01 Duncan Mak <duncan@ximian.com>
20333 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20334 parsing for cmd, fixes bug #53694.
20336 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20338 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20339 in the member name duplication tests. Property and operator name duplication
20340 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20342 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20344 * interface.cs (PopulateMethod): Fixed crash when interface method
20345 returns not existing type (error test cs0246-3.cs).
20347 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20349 * cs-parser.jay (interface_accessors): Re-write actions to also
20350 store attributes attached to get and set methods. Fix spelling
20353 (inteface_property_declaration): Modify accordingly.
20355 (InterfaceAccessorInfo): New helper class to store information to pass
20356 around between rules that use interface_accessors.
20358 * interface.cs (Emit): Apply attributes on the get and set
20359 accessors of properties and indexers too.
20361 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20362 right MethodBuilder when applying attributes to the get and set accessors.
20364 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20366 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20368 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20370 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20372 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20374 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20375 changes that treat `yield' specially when present before `break'
20376 or `return' tokens.
20378 * cs-tokenizer.cs: yield is no longer a keyword.
20380 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20382 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20383 setting for default constructors.
20384 For default constructors are almost every time set wrong Modifier. The
20385 generated IL code has been alright. But inside mcs this values was
20386 wrong and this was reason why several of my CLS Compliance tests
20389 2004-01-22 Martin Baulig <martin@ximian.com>
20391 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20392 not a QualifiedIdentifier. This is what `type_name_expression'
20393 was previously doing.
20394 (type_name_expression): Removed; the code is now in
20395 `namespace_or_type_name'.
20396 (qualified_identifier): Removed, use `namespace_or_type_name'
20398 (QualifiedIdentifier): Removed this class.
20400 2004-01-22 Martin Baulig <martin@ximian.com>
20402 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20403 not a string as alias name.
20405 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20407 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20408 #52730 bug, and instead compute correctly the need to use a
20409 temporary variable when requesting an address based on the
20410 static/instace modified of the field and the constructor.
20412 2004-01-21 Martin Baulig <martin@ximian.com>
20414 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20415 class and namespace before looking up aliases. Fixes #52517.
20417 2004-01-21 Martin Baulig <martin@ximian.com>
20419 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20420 assinged in a 'try'; fixes exception4.cs.
20422 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20423 * class.cs : Implemented parameter-less constructor for TypeContainer
20425 * decl.cs: Attributes are now stored here. New property OptAttributes
20427 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20429 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20431 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20433 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20434 (CSharpSignature): New method for indexer and property signature.
20436 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20438 * pending.cs (IsVirtualFilter): Faster implementation.
20440 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20442 * typemanager.cs: Avoid inclusion of same assembly more than once.
20444 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20446 * cs-parser.jay: Fixed problem where the last assembly attribute
20447 has been applied also to following declaration (class, struct, etc.)
20449 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20451 * class.cs: Added error CS0538, CS0539 reporting.
20452 Fixed crash on Microsoft runtime when field type is void.
20454 * cs-parser.jay: Added error CS0537 reporting.
20456 * pending.cs: Added error CS0535 reporting.
20457 Improved error report for errors CS0536, CS0534.
20459 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20461 Merge a few bits from the Anonymous Method MCS tree.
20463 * statement.cs (ToplevelBlock): New class for toplevel methods,
20464 will hold anonymous methods, lifted variables.
20466 * cs-parser.jay: Create toplevel blocks for delegates and for
20467 regular blocks of code.
20469 2004-01-20 Martin Baulig <martin@ximian.com>
20471 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20472 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20473 and `NeedExplicitReturn'; added `IsLastStatement'.
20474 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20475 have a `ReturnLabel' or we're not unreachable.
20477 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20478 child's reachability; don't just override ours with it. Fixes
20479 #58058 (lluis's example).
20480 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20481 InFinally(), InLoop(), InSwitch() and
20482 BreakCrossesTryCatchBoundary() methods.
20484 * statement.cs (Return): Do all error checking in Resolve().
20485 Unless we are the last statement in a top-level block, always
20486 create a return label and jump to it.
20487 (Break, Continue): Do all error checking in Resolve(); also make
20488 sure we aren't leaving a `finally'.
20489 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20490 statement in a top-level block.
20491 (Block.Flags): Added `IsDestructor'.
20492 (Block.IsDestructor): New public property.
20494 2004-01-20 Martin Baulig <martin@ximian.com>
20496 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20498 2004-01-20 Martin Baulig <martin@ximian.com>
20500 * statement.cs (Statement.ResolveUnreachable): New public method.
20501 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20502 (Block.Resolve): Resolve unreachable statements.
20504 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20506 * expression.cs: We need to fix the case where we do
20507 not have a temp variable here.
20509 * assign.cs: Only expression compound assignments need
20510 temporary variables.
20512 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20514 * flowanalysis.cs: Reduce memory allocation in a few ways:
20515 - A block with no variables should not allocate a bit
20517 - A method with no out parameters does not need any tracking
20518 for assignment of the parameters, so we need not allocate
20521 public readonly Type[] VariableTypes;
20522 public readonly string[] VariableNames;
20523 Are redundant. The data is already stored in the variable
20524 map, so we need not allocate another array for it.
20525 - We need to add alot of checks for if (params | locals) == null
20526 due to the first two changes.
20528 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20530 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20531 implement IMemoryLocation, we store a copy on a local variable and
20532 take the address of it. Patch from Benjamin Jemlich
20534 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20535 to use a special "type_name_expression" rule which reduces the
20536 number of "QualifiedIdentifier" classes created, and instead
20537 directly creates MemberAccess expressions.
20539 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20541 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20542 that fixes #52853. Null literal assignment to ValueType
20544 * class.cs (MethodData.Emit): Instead of checking the name of the
20545 method to determine if its a destructor, create a new derived
20546 class from Method called Destructor, and test for that.
20548 * cs-parser.jay: Create a Destructor object instead of a Method.
20550 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20554 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20556 * expression.cs (Binary.ResolveOperator): Perform an implicit
20557 conversion from MethodGroups to their delegate types on the
20558 Addition operation.
20560 * delegate.cs: Introduce a new class DelegateCreation that is the
20561 base class for `NewDelegate' and `ImplicitDelegateCreation',
20562 factor some code in here.
20564 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20565 conversion from MethodGroups to compatible delegate types.
20567 * ecore.cs (Expression.Resolve): Do not flag error 654
20568 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20569 we allow conversions from MethodGroups to delegate types now.
20571 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20572 assignments in v2 either.
20574 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20576 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20577 static read-only fields in ctors.
20579 Applied patch from Benjamin Jemlich
20581 * expression.cs (UnaryMutator): Avoid leaking local variables.
20583 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20585 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20586 here to return true, as they can be used like this:
20588 (XXX) int.MEMBER ()
20590 Fixed 49836 and all the other dups
20592 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20594 * driver.cs: Implement /win32res and /win32icon.
20596 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20598 * cs-parser.jay: Add a rule to improve error handling for the
20599 common mistake of placing modifiers after the type.
20601 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20603 * cs-parser.jay (interface_event_declaration): Catch
20604 initialization of events on interfaces, and report cs0068
20606 * cs-parser.jay (interface_event_declaration): Catch
20607 initialization of events.
20609 * ecore.cs: Better report missing constructors.
20611 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20612 the error reporting done in the wrong place. Fix.
20614 * expression.cs (Binary.ResolveOperator): Catch the
20615 operator + (E x, E y) error earlier, and later allow for implicit
20616 conversions in operator +/- (E e, U x) from U to the underlying
20619 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20620 52596, if the container class is abstract, the default constructor
20621 is protected otherwise its public (before, we were always public).
20623 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20626 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20627 Jemlich that fixes bug #52597, MCS was generating invalid code for
20628 idisposable structs. Thanks to Ben for following up with this
20631 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20633 * driver.cs: Allow assemblies without code to be generated, fixes
20636 2004-01-07 Nick Drochak <ndrochak@gol.com>
20638 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20640 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20642 * cs-parser.jay: Add rules to improve error reporting if fields or
20643 methods are declared at the namespace level (error 116)
20645 * Add rules to catch event add/remove
20647 2004-01-04 David Sheldon <dave-mono@earth.li>
20649 * expression.cs: Added matching ")" to error message for
20652 2004-01-03 Todd Berman <tberman@gentoo.org>
20654 * ecore.cs, attribute.cs:
20655 Applying fix from #52429.
20657 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20659 * ecore.cs, expression.cs, statement.cs:
20660 Total rewrite of how we handle branching. We
20661 now handle complex boolean expressions with fewer
20662 jumps. As well if (x == 0) no longer emits a ceq.
20664 if (x is Foo) is much faster now, because we generate
20667 Overall, we get a pretty big improvement on our benchmark
20668 tests. The code we generate is smaller and more readable.
20670 I did a full two-stage bootstrap. The patch was reviewed
20671 by Martin and Miguel.
20673 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20675 * cs-parser.jay: Make primary_expression not take a QI.
20676 we dont need this because the member_access rule covers
20677 us here. So we replace the rule with just IDENTIFIER.
20679 This has two good effects. First, we remove a s/r conflict.
20680 Second, we allocate many fewer QualifiedIdentifier objects.
20682 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20684 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20685 set the correct information via SRE. This prevents
20686 hanging on the MS runtime. Fixes #29374.
20688 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20690 * convert.cs: correctly handle conversions to value types
20691 from Enum and ValueType as unboxing conversions.
20693 Fixes bug #52569. Patch by Benjamin Jemlich.
20695 2004-01-02 Ravi Pratap <ravi@ximian.com>
20697 * expression.cs (BetterConversion): Prefer int -> uint
20698 over int -> ulong (csc's behaviour). This fixed bug #52046.
20700 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20702 * decl.cs (MemberCache.FindMembers): now returns a
20705 * typemanager.cs: In general, go with with ^^.
20706 (CopyNewMethods): take an IList.
20707 (RealMemberLookup): Only allocate an arraylist
20708 if we copy from two sets of methods.
20710 This change basically does two things:
20711 1) Fewer array lists allocated due to CopyNewMethods.
20712 2) the explicit cast in MemberList costed ALOT.
20714 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20716 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20717 a hashtable to avoid needless string allocations when an identifier is
20718 used more than once (the common case).
20720 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20722 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20723 is broken, it will not return anything. So, we
20724 have to use the information we have in mcs to
20727 * typemanager.cs: Add a cache for GetInterfaces,
20728 since this will now be used more often (due to ^^)
20730 (GetExplicitInterfaces) New method that gets the
20731 declared, not effective, interfaces on a type
20732 builder (eg, if you have interface IFoo, interface
20733 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20736 This patch makes MCS able to bootstrap itself on
20739 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20741 * expression.cs: Remove the Nop's that Miguel put
20744 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20746 * report.cs, codegen.cs: Give the real stack trace to
20747 the error when an exception is thrown.
20749 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20751 * decl.cs: only allocate hashtables for ifaces if
20754 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20756 * expression.cs: fix the error from cs0121-2.cs
20757 (a parent interface has two child interfaces that
20758 have a function with the same name and 0 params
20759 and the function is called through the parent).
20761 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20763 * class.cs, rootcontext.cs, typmanager.cs: do not
20766 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20768 * codegen.cs: remove stack for the ec flow branching.
20769 It is already a linked list, so no need.
20771 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20773 * Makefile: Allow custom profiler here.
20775 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20777 * typemanager.cs (LookupType):
20778 - Use a static char [], because split takes
20779 a param array for args, so it was allocating
20781 - Do not store true in a hashtable, it boxes.
20783 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20785 * flowanalysis.cs: bytify common enums.
20787 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20789 * modifiers.cs: Add a new set of flags for the
20790 flags allowed on explicit interface impls.
20791 * cs-parser.jay: catch the use of modifiers in
20792 interfaces correctly.
20793 * class.cs: catch private void IFoo.Blah ().
20795 All related to bug #50572.
20797 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20799 * decl.cs: Rewrite the consistant accessability checking.
20800 Accessability is not linear, it must be implemented in
20801 a tableish way. Fixes #49704.
20803 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20805 * expression.cs: Handle negation in a checked context.
20806 We must use subtraction from zero. Fixes #38674.
20808 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20810 * class.cs: Ignore static void main in DLLs.
20811 * rootcontext.cs: Handle the target type here,
20812 since we are have to access it from class.cs
20813 * driver.cs: account for the above.
20815 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20817 * report.cs: Give line numbers and files if available.
20819 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20821 * driver.cs: Implement /addmodule.
20823 * typemanager.cs: Change 'modules' field so it now contains Modules not
20826 2003-12-20 Martin Baulig <martin@ximian.com>
20828 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20829 (FieldBase.IsAssigned): Removed this field.
20830 (FieldBase.SetAssigned): New public method.
20831 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20833 2003-12-20 Martin Baulig <martin@ximian.com>
20835 * expression.cs (LocalVariableReference.DoResolve): Don't set
20836 `vi.Used' if we're called from DoResolveLValue().
20838 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20839 returns the usage vector it just merged into the current one -
20840 pass this one to UsageWarning().
20841 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20842 of the `EmitContext', don't call this recursively on our children.
20844 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20846 * driver.cs: Implement /target:module.
20848 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20850 * support.cs (CharArrayHashtable): New helper class.
20852 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20853 char arrays, not strings, so we can avoid creating a string in
20854 consume_identifier if the identifier is a keyword.
20856 2003-12-16 Martin Baulig <martin@ximian.com>
20858 * statement.cs (LocalInfo.Assigned): Removed this property.
20859 (LocalInfo.Flags): Removed `Assigned'.
20860 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20861 and uses flow analysis.
20862 (Block.UsageWarning): Made this method private.
20863 (Block.Resolve): Call UsageWarning() if appropriate.
20865 * expression.cs (LocalVariableReference.DoResolve): Always set
20866 LocalInfo.Used here.
20868 2003-12-13 Martin Baulig <martin@ximian.com>
20870 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20871 any value here; we're now using flow analysis to figure out
20872 whether a statement/block returns a value.
20874 2003-12-13 Martin Baulig <martin@ximian.com>
20876 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20878 (FlowBranching.MergeFinally): Don't call
20879 `branching.CheckOutParameters()' here, this is called in
20881 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20882 when adding the `finally' vector.
20884 2003-12-13 Martin Baulig <martin@ximian.com>
20887 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20888 actually work and also fix #48962.
20890 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20892 * decl.cs: Do not check System.Object for nested types,
20893 since we know it does not have any. Big bang for buck:
20896 Run 1: 8.35 seconds
20897 Run 2: 8.32 seconds
20898 corlib: 17.99 seconds
20900 Run 1: 8.17 seconds
20901 Run 2: 8.17 seconds
20902 corlib: 17.39 seconds
20904 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20906 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20907 time we are returning 0 members, so we save alot here.
20909 2003-12-11 Martin Baulig <martin@ximian.com>
20911 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20912 `MergeChild()', also just take the `FlowBranching' as argument;
20913 call Merge() on it and return the result.
20914 (FlowBranching.Merge): We don't need to do anything if we just
20917 2003-12-11 Martin Baulig <martin@ximian.com>
20919 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20920 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20921 Maurer for this idea.
20923 2003-12-11 Martin Baulig <martin@ximian.com>
20925 * flowanalysis.cs (MergeResult): This class is now gone; we now
20926 use the `UsageVector' for this. The reason for this is that if a
20927 branching just has one sibling, we don't need to "merge" them at
20928 all - that's the next step to do.
20929 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20932 2003-12-11 Martin Baulig <martin@ximian.com>
20934 Reworked flow analyis and made it more precise and bug-free. The
20935 most important change is that we're now using a special `Reachability'
20936 class instead of having "magic" meanings of `FlowReturns'. I'll
20937 do some more cleanups and optimizations and also add some more
20938 documentation this week.
20940 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20941 largely reworked this class.
20942 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20943 the new `Reachability' class instead of having "magic" values here.
20944 (FlowBranching): We're now using an instance of `Reachability'
20945 instead of having separate `Returns', `Breaks' etc. fields.
20947 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20948 based on flow analysis; ignore the return value of block.Emit ().
20950 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20952 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20953 if they are private.
20955 2003-12-09 Martin Baulig <martin@ximian.com>
20957 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20958 call them directly on the UsageVector.
20960 2003-12-09 Martin Baulig <martin@ximian.com>
20962 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20963 Changed return type from `FlowReturns' to `Reachability'.
20965 2003-12-09 Martin Baulig <martin@ximian.com>
20967 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20968 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20969 `Reachable' fields with a single `Reachability' one.
20971 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20973 * class.cs (FindMembers): Remove foreach's.
20978 Run 1: 8.74 seconds
20979 Run 2: 8.71 seconds
20982 Run 1: 8.64 seconds
20983 Run 2: 8.58 seconds
20986 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20991 This patch does a few things:
20992 1. EmptyStatement is now a singleton, so it is never reallocated.
20993 2. All blah is EmptyStatement constructs have been changed to
20994 blah == EmptyStatement.Value, which is much faster and valid
20995 now that EmptyStatement is a singleton.
20996 3. When resolving a block, rather than allocating a new array for
20997 the non-empty statements, empty statements are replaced with
20998 EmptyStatement.Value
20999 4. Some recursive functions have been made non-recursive.
21000 Mainly the performance impact is from (3), however (1) and (2) are needed for
21001 this to work. (4) does not make a big difference in normal situations, however
21002 it makes the profile look saner.
21007 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
21008 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
21009 Total memory allocated: 56397 KB
21012 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
21013 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
21014 Total memory allocated: 55666 KB
21016 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21018 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
21019 than the hashtable in a hashtable version
21021 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
21022 we always end up concating a string. This results in a huge perf
21023 loss, because many strings have to be tracked by the GC. In this
21024 patch, we first use a hashtable that works with two keys, so that
21025 the strings do not need to be concat'ed.
21029 Run 1: 8.74 seconds
21030 Run 2: 8.71 seconds
21033 Run 1: 8.65 seconds
21034 Run 2: 8.56 seconds
21036 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21038 * Makefile: Add a new target `do-time' that does a quick and simple
21039 profile, leaving easy to parse output.
21041 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
21043 * codegen.cs (Init): Create the dynamic assembly with
21044 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
21046 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
21048 * support.cs: Make the PtrHashtable use only one
21049 instance of its comparer.
21051 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
21053 * typemanager.cs: Fix lookup of GetNamespaces.
21055 2003-11-29 Miguel de Icaza <miguel@ximian.com>
21057 * expression.cs: Removed redundant line.
21059 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
21060 ArrayLists, use for loops with bounds.
21062 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
21065 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
21066 arraylists, use for loop with bounds.
21068 The above three changes give us a 0.071 second performance
21069 improvement out of 3.294 seconds down to 3.223. On my machine
21070 the above changes reduced the memory usage by 1,387 KB during
21071 compiler bootstrap.
21073 * cs-parser.jay (QualifiedIdentifier): New class used to represent
21074 QualifiedIdentifiers. Before we created a new string through
21075 concatenation, and mostly later on, the result would be
21076 manipulated by DecomposeQI through string manipulation.
21078 This reduced the compiler memory usage for bootstrapping from
21079 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
21080 compile times in 0.05 seconds.
21082 2003-11-28 Dick Porter <dick@ximian.com>
21084 * support.cs: Do string compares with the Invariant culture.
21092 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
21093 the comparison is done with the Invariant culture.
21095 2003-11-27 Miguel de Icaza <miguel@ximian.com>
21097 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
21098 GetEnumerator method.
21100 (ProbeCollectionType): Iterate starting at the most specific type
21101 upwards looking for a GetEnumerator
21103 * expression.cs: Shift count can be up to 31 for int/uint and 63
21106 2003-11-26 Miguel de Icaza <miguel@ximian.com>
21108 * statement.cs (Block.LookupLabel): Also look for the label on the
21109 children blocks. Use a hash table to keep track of visited
21112 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
21113 we actually did transform the other operand, otherwise fall back
21114 to the common codepath that casts to long.
21116 * cs-tokenizer.cs: Use the same code pattern as the int case.
21117 Maybe I should do the parsing myself, and avoid depending on the
21118 Parse routines to get this done.
21120 2003-11-25 Miguel de Icaza <miguel@ximian.com>
21122 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21123 which fixes bug 51347. This time test it.
21125 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
21126 attributes for example can not tell the difference between these.
21127 The difference was only a syntax feature of the language.
21129 * attribute.cs: Apply attributes to delegates.
21131 * delegate.cs: Call the apply attributes method.
21133 2003-11-24 Miguel de Icaza <miguel@ximian.com>
21135 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
21136 comparing 0 vs Byte.MinValue, not the value
21138 (ImplicitConversionRequired): When reporting a conversion error,
21139 use error 31 to print out the constant error instead of the
21142 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21143 which fixes bug 51347.
21145 2003-11-22 Miguel de Icaza <miguel@ximian.com>
21147 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
21148 which fixes the -warnaserror command line option.
21150 2003-11-21 Miguel de Icaza <miguel@ximian.com>
21152 * cfold.cs (DoNumericPromotions): During constant folding of
21153 additions on UIntConstant, special case intconstants with
21154 IntConstants like we do on the expression binary operator.
21156 2003-11-12 Miguel de Icaza <miguel@ximian.com>
21158 * convert.cs (ImplicitReferenceConversion): We were missing a case
21159 (System.Enum are not value types or class types, so we need to
21160 classify them separatedly).
21162 * driver.cs: We do not support error 2007.
21164 2003-11-12 Jackson Harper <jackson@ximian.com>
21166 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
21167 system directory. Also use the full file name so users can
21168 libraries names mscorlib-o-tron.dll in a non system dir.
21170 2003-11-10 Martin Baulig <martin@ximian.com>
21172 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
21173 (TypeManager.InitCoreTypes): Initialize them here, but instead of
21174 calling `ResolveType()' on them, directly assign their `Type'.
21176 2003-11-08 Martin Baulig <martin@ximian.com>
21178 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
21179 return value and the `out parent' parameter.
21180 (TypeContainer.DefineType): Moved the CS0644 check into
21181 GetClassBases(). Don't pass the interface types to the
21182 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
21183 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
21185 * ecore.cs (TypeExpr.IsAttribute): New property.
21186 (TypeExpr.GetInterfaces): New method.
21188 * interface.cs (Interface.GetInterfaceTypeByName): Return a
21189 TypeExpr instead of a Type.
21190 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
21191 (Interface.DefineType): Don't pass the interface types to the
21192 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
21193 them later and then call `TypeBulider.AddInterfaceImplementation()'.
21195 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
21196 instead of a `Type[]'.
21197 (TypeManager.RegisterBuilder): Likewise.
21198 (TypeManager.AddUserInterface): Likewise.
21199 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
21200 `Type[]' and also return a `TypeExpr[]'.
21201 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
21203 2003-11-08 Martin Baulig <martin@ximian.com>
21205 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
21208 2003-11-08 Martin Baulig <martin@ximian.com>
21210 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
21211 TypeManager.ResolveExpressionTypes().
21213 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
21214 instead of an Expression.
21215 (TypeExpr): This is now an abstract base class for `TypeExpression'.
21216 (TypeExpression): New public class; formerly known as `TypeExpr'.
21218 * expression.cs (ComposedCast): Derive from TypeExpr.
21220 * typemanager.cs (TypeManager.system_*_expr): These are now
21221 TypExpr's instead of Expression's.
21222 (TypeManager.ResolveExpressionTypes): New public static function;
21223 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
21226 2003-11-06 Miguel de Icaza <miguel@ximian.com>
21228 * expression.cs (New.DoResolve): Do not dereference value that
21229 might be a null return.
21231 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
21232 sure that the constant value has the right type. Fixes an
21233 unreported bug, similar to 50425.
21235 * const.cs (Const.LookupConstantValue): Call
21236 ImplicitStandardConversionExists before doing a conversion to
21237 avoid havng the TypeManager.ChangeType do conversions.
21239 Reduced the number of casts used
21241 (Const.ChangeType): New routine to enable reuse of the constant
21242 type changing code from statement.
21244 * typemanager.cs (ChangeType): Move common initialization to
21245 static global variables.
21249 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
21250 every value type to go through, even if it was void. Fix that.
21252 * cs-tokenizer.cs: Use is_identifier_start_character on the start
21253 character of the define, and the is_identifier_part_character for
21254 the rest of the string.
21256 2003-11-05 Miguel de Icaza <miguel@ximian.com>
21258 * expression.cs (UnaryMutator.EmitCode): When I updated
21259 LocalVariableReference.DoResolve, I overdid it, and dropped an
21260 optimization done on local variable references.
21262 2003-11-04 Miguel de Icaza <miguel@ximian.com>
21264 * ecore.cs: Convert the return from Ldlen into an int.
21266 2003-10-20 Miguel de Icaza <miguel@ximian.com>
21268 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
21269 the accessibility, this is a special case for toplevel non-public
21270 classes (internal for instance).
21272 2003-10-20 Nick Drochak <ndrochak@gol.com>
21274 * ecore.cs: Fix typo and build. Needed another right paren.
21276 2003-10-19 Miguel de Icaza <miguel@ximian.com>
21278 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
21279 `internal' case regular and protected, but not allowing protected
21280 to be evaluated later. Bug 49840
21282 2003-10-15 Miguel de Icaza <miguel@ximian.com>
21284 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
21285 to kb.Nlast, and not the kb.nFirst to isolate the switch
21288 Extract the underlying type, so enumerations of long/ulong are
21289 treated like long/ulong.
21291 2003-10-14 Miguel de Icaza <miguel@ximian.com>
21293 * expression.cs (New): Overload the meaning of RequestedType to
21294 track the possible creation of the NewDelegate type, since
21295 DoResolve is invoked more than once for new constructors on field
21298 See bugs: #48800 and #37014
21300 * cs-parser.jay (declare_local_constants): Take an arraylist
21301 instead of a single constant.
21303 (local_constant_declaration): It should take a
21304 constant_declarators, not a constant_declarator. Fixes 49487
21306 * convert.cs: Fix error report.
21308 2003-10-13 Jackson Harper <jackson@ximian.com>
21310 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21313 2003-10-09 Martin Baulig <martin@ximian.com>
21315 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21317 (MethodCore.DoDefineParameters): Removed the TypeContainer
21318 argument; use the DeclSpace which was passed to the .ctor instead.
21319 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21320 TypeContainer; we only need a DeclSpace here.
21322 2003-10-09 Martin Baulig <martin@ximian.com>
21324 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21326 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21327 EmitContext's .ctor.
21329 2003-10-09 Martin Baulig <martin@ximian.com>
21331 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21332 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21333 AsAccessible(), moved them as well.
21335 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21337 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21339 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21341 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21343 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21344 generation for >=, as spotted by Paolo, bug 48679.
21345 Patch from David Waite.
21347 * cs-tokenizer.cs: Add handling for #pragma.
21349 * cs-parser.jay: Allow for both yield and yield return in the
21350 syntax. The anti-cobolization of C# fight will go on!
21352 * class.cs (TypeBuilder.DefineType): Catch error condition here
21353 (Parent.DefineType erroring out and returning null).
21355 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21356 coping with enumerations variables, we were mistakenly processing
21357 them as a regular value type instead of built-in types. Fixes the
21360 * typemanager.cs (IsBuiltinOrEnum): New method.
21362 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21364 * cs-parser.jay: Upgrade: yield now needs the return clause.
21366 2003-09-19 Martin Baulig <martin@ximian.com>
21368 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21369 `MemberCache parent' argument. Normally, an interface doesn't
21370 have a parent type except System.Object, but we use this in gmcs
21371 for generic type parameters.
21373 2003-09-18 Martin Baulig <martin@ximian.com>
21375 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21376 on `type.IsInterface'; don't check whether the type has a parent
21377 to determine whether it's an interface.
21379 2003-09-15 Martin Baulig <martin@ximian.com>
21381 * class.cs (TypeContainer.DefineType): Added an error flag to
21382 avoid reporting duplicate CS0146's ("class definition is
21385 * driver.cs (Driver.MainDriver): Abort if
21386 RootContext.ResolveTree() reported any errors.
21388 2003-09-07 Martin Baulig <martin@ximian.com>
21390 * report.cs (Error, Warning): Added overloaded versions which take
21391 a `params object[] args' and call String.Format().
21393 2003-09-07 Martin Baulig <martin@ximian.com>
21395 * decl.cs (DeclSpace..ctor): Don't call
21396 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21397 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21398 (DeclSpace.RecordDecl): New method.
21400 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21402 2003-09-02 Ravi Pratap <ravi@ximian.com>
21404 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21405 value attributes to be applied to ParameterBuilders.
21407 * class.cs (MethodCore.LabelParameters): Make static and more
21408 generic so that it can be used from other places - like interface
21409 methods, for instance.
21411 * interface.cs (Interface.Emit): Call LabelParameters before
21412 emitting attributes on the InterfaceMethod.
21414 2003-08-26 Martin Baulig <martin@ximian.com>
21416 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21417 resolving aliases; fixes #47927.
21419 2003-08-26 Martin Baulig <martin@ximian.com>
21421 * statement.cs (Using.DoResolve): This is internally emitting a
21422 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21423 do not always return. Fixes #47681.
21425 2003-08-26 Martin Baulig <martin@ximian.com>
21427 * decl.cs (MemberCore): Moved WarningNotHiding(),
21428 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21430 (AdditionResult): Make this nested in DeclSpace.
21431 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21432 argument; call NamespaceEntry.Define() unless we're nested in a
21435 * namespace.cs (Namespace.DefineName): New public function. This
21436 is called from DeclSpace's .ctor to add
21437 (Namespace.Lookup): Include DeclSpaces in the lookup.
21439 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21441 * const.cs (Const): Derive from MemberBase, not MemberCore.
21443 2003-08-25 Martin Baulig <martin@ximian.com>
21445 * convert.cs (Convert.ExplicitReferenceConversion): When
21446 converting from an interface type to a class, unbox if the target
21447 type is a struct type. Fixes #47822.
21449 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21451 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21454 2003-08-22 Martin Baulig <martin@ximian.com>
21456 * class.cs (TypeManager.DefineType): When defining a nested type,
21457 call DefineType() on our parent; fixes #47801.
21459 2003-08-22 Martin Baulig <martin@ximian.com>
21461 * class.cs (MethodData.Define): While checking if a method is an
21462 interface implementation, improve the test a bit more to fix #47654.
21464 2003-08-22 Martin Baulig <martin@ximian.com>
21466 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21467 correctly; fixes #47722.
21469 2003-08-22 Martin Baulig <martin@ximian.com>
21471 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21472 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21474 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21476 2003-08-22 Martin Baulig <martin@ximian.com>
21478 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21479 can only be assigned in static constructors. Fixes #47161.
21481 2003-08-22 Martin Baulig <martin@ximian.com>
21483 Rewrote and improved the flow analysis code.
21485 * flowbranching.cs (FlowBranching): Make this class abstract.
21486 (FlowBranching.CreateBranching): New static function to create a
21487 new flow branching.
21488 (FlowBranchingBlock, FlowBranchingException): New classes.
21489 (FlowBranching.UsageVector.Type): New public readonly field.
21490 (FlowBranching.UsageVector.Breaks): Removed the setter.
21491 (FlowBranching.UsageVector.Returns): Removed the setter.
21492 (FlowBranching.UsageVector): Added Break(), Return(),
21493 NeverReachable() and Throw() methods to modify the reachability.
21494 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21495 done by FlowBranching.Merge().
21496 (FlowBranching.UsageVector.MergeChild): New method; merges the
21497 merge result into the current vector.
21498 (FlowBranching.Merge): New abstract method to merge a branching.
21500 2003-08-12 Martin Baulig <martin@ximian.com>
21502 * expression.cs (Indirection.CacheTemporaries): Create the
21503 LocalTemporary with the pointer type, not its element type.
21505 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21507 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21508 token was a keyword or not.
21510 Add `error' options where an IDENTIFIER was expected; Provide
21511 CheckToken and CheckIdentifierToken convenience error reporting
21514 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21516 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21517 NameSpaceEntry NameSpaceEntry.
21519 (LookupInterfaceOrClass): Avoid creating a full qualified name
21520 from namespace and name: avoid doing lookups when we know the
21521 namespace is non-existant. Use new Tree.LookupByNamespace which
21522 looks up DeclSpaces based on their namespace, name pair.
21524 * driver.cs: Provide a new `parser verbose' to display the
21525 exception thrown during parsing. This is turned off by default
21526 now, so the output of a failure from mcs is more graceful.
21528 * namespace.cs: Track all the namespaces defined in a hashtable
21531 (IsNamespace): New method
21533 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21535 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21536 we know that we need to concatenate (full typename can never be
21541 * statement.cs: Use a bitfield; Do not initialize to null things
21542 which are done by the constructor by default.
21544 * cs-parser.jay: bug fix, parameter was 4, not 3.
21546 * expression.cs: Just use the property;
21548 * statement.cs: No need for GetVariableInfo method.
21550 2003-08-08 Martin Baulig <martin@ximian.com>
21552 * flowanalysis.cs (FlowReturns): This is now nested in the
21553 `FlowBranching' class.
21554 (MyBitVector): Moved this here from statement.cs.
21555 (FlowBranching.SiblingType): New enum type.
21556 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21558 2003-08-07 Martin Baulig <martin@ximian.com>
21560 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21561 `FlowBranching' class and called `BranchingType'.
21563 2003-08-07 Martin Baulig <martin@ximian.com>
21565 * flowanalysis.cs: Moved all the control flow analysis code into
21568 2003-08-07 Martin Baulig <martin@ximian.com>
21570 * assign.cs (Assign.DoResolve): `target' must either be an
21571 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21574 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21576 * expression.cs (BinaryMethod): This kind of expression is created by the
21577 Binary class if it determines that the operator has to be handled
21580 (BinaryDelegate): This kind of expression is created if we are
21581 dealing with a + or - operator on delegates.
21583 (Binary): remove method, argumetns, and DelegateOperator: when
21584 dealing with methods,
21586 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21588 * statement.cs (Block): use bitfields for the three extra booleans
21589 we had in use. Remove unused topblock parameter.
21591 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21593 * assign.cs: Drop extra unneeded tests.
21595 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21597 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21599 * statement.cs (Foreach): Use VariableStorage instead of
21602 * codegen.cs (VariableStorage): New class used by clients that
21603 require a variable stored: locals or fields for variables that
21604 need to live across yield.
21606 Maybe provide a convenience api for EmitThis+EmitLoad?
21608 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21611 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21613 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21614 RemapParameterLValue): New methods that are used to turn a
21615 precomputed FieldInfo into an expression like this:
21619 The idea is to use this instead of making LocalVariableReference
21620 have more than one meaning.
21622 * cs-parser.jay: Add error production to BASE.
21624 * ecore.cs: Deal with TypeManager.GetField returning null, which
21625 is now a valid return value.
21627 (FieldExprNoAddress): New expression for Fields whose address can
21630 * expression.cs (LocalVariableReference): During the resolve
21631 phases, create new expressions if we are in a remapping context.
21632 Remove code that dealt with remapping here.
21634 (ParameterReference): same.
21636 (ProxyInstance): New expression, like the `This' expression, but
21637 it is born fully resolved. We know what we are doing, so remove
21638 the errors that are targeted to user-provided uses of `this'.
21640 * statement.cs (Foreach): our variable is now stored as an
21641 Expression; During resolution, follow the protocol, dont just
21642 assume it will return this.
21644 2003-08-06 Martin Baulig <martin@ximian.com>
21646 * support.cs (SeekableStreamReader.cs): New public class.
21648 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21649 SeekableStreamReader instead of the normal StreamReader.
21651 2003-08-04 Martin Baulig <martin@ximian.com>
21653 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21654 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21655 deambiguate casts and delegate invocations.
21656 (parenthesized_expression): Use the new tokens to ensure this is
21657 not a cast of method invocation.
21659 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21660 when reading a `)' and Deambiguate_CloseParens () was previously
21663 * expression.cs (ParenthesizedExpression): New class. This is
21664 just used for the CS0075 test.
21665 (Binary.DoResolve): Check for CS0075.
21667 2003-07-29 Ravi Pratap <ravi@ximian.com>
21669 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21670 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21671 reference comparison.
21673 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21674 examine the ReturnType for equality - this is necessary in the
21675 cases of implicit and explicit operators whose signature also
21676 includes the return type.
21678 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21680 * namespace.cs: Cache the result of the namespace computation,
21681 instead of computing it every time.
21683 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21685 * decl.cs: Use a global arraylist that we reuse over invocations
21686 to avoid excesive memory consumption. Reduces memory usage on an
21687 mcs compile by one meg (45 average).
21689 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21690 private, work around that.
21692 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21694 * literal.cs (IntLiteral): Define Zero and One static literals.
21696 * cs-parser.jay (integer_literal): use static literals to reduce
21697 memory usage for the most used literals (0, 1 and -1). 211kb
21698 reduced in memory usage.
21700 Replace all calls to `new ArrayList' with `new
21701 ArrayList(4)' which is a good average number for most allocations,
21702 and also requires only 16 bytes of memory for its buffer by
21705 This reduced MCS memory usage in seven megabytes for the RSS after
21708 2003-07-28 Ravi Pratap <ravi@ximian.com>
21710 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21711 handle params methods the correct way by forming only one
21712 applicable set with params and normal methods in them. Earlier we
21713 were looking at params methods only if we found no normal methods
21714 which was not the correct thing to do.
21716 (Invocation.BetterFunction): Take separate arguments indicating
21717 when candidate and the best method are params methods in their
21720 This fixes bugs #43367 and #46199.
21722 * attribute.cs: Documentation updates.
21724 (CheckAttribute): Rename to CheckAttributeTarget.
21725 (GetValidPlaces): Rename to GetValidTargets.
21727 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21728 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21732 2003-07-28 Martin Baulig <martin@ximian.com>
21734 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21735 name when looking up the base class of a nested class. Fixes #46977.
21737 2003-07-26 Martin Baulig <martin@ximian.com>
21739 * expression.cs (Indexers.Indexer): New nested struct; contains
21740 getter, setter and the indexer's type.
21741 (Indexers.Properties): This is now an ArrayList of
21742 Indexers.Indexer's.
21743 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21744 indexer doesn't have any getters.
21746 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21747 for embedded property and indexer assignments.
21749 2003-07-26 Martin Baulig <martin@ximian.com>
21751 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21752 preprocessor directive is not the first non-whitespace character
21755 2003-07-26 Martin Baulig <martin@ximian.com>
21757 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21758 namespace parsing, follow the spec more closely.
21760 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21761 NamespaceEntry.Lookup().
21763 2003-07-25 Martin Baulig <martin@ximian.com>
21765 * MethodCore.cs (OverridesSomething): New public field; it's set
21766 from TypeContainer.DefineMembers if this method overrides
21767 something (which doesn't need to be a method). Fix #39462.
21769 2003-07-25 Ravi Pratap <ravi@ximian.com>
21771 * typemanager.cs (GetMembers): Ensure that the list of members is
21772 reversed. This keeps things in sync.
21774 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21775 find an AttributeUsage attribute.
21777 * expression.cs (Invocation.OverloadResolve): Perform the check
21778 which disallows Invoke to be directly called on a Delegate.
21780 (Error_InvokeOnDelegate): Report error cs1533.
21782 2003-07-25 Martin Baulig <martin@ximian.com>
21784 * expression.cs (Indexers.GetIndexersForType): Only look in the
21785 interface hierarchy if the requested type is already an
21786 interface. Fixes #46788 while keeping #46502 fixed.
21788 2003-07-25 Martin Baulig <martin@ximian.com>
21790 * class.cs (TypeContainer.DefineMembers): Check whether all
21791 readonly fields have been assigned and report warning CS0649 if
21794 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21797 2003-07-24 Ravi Pratap <ravi@ximian.com>
21799 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21800 returned from GetMethods to make things consistent with the
21801 assumptions MCS makes about ordering of methods.
21803 This should comprehensively fix bug #45127 and it does :-)
21805 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21806 ordering is actually reverse.
21808 * Clean up some debug messages I left lying around.
21810 * interface.cs (Populate*): Get rid of code which emits attributes
21811 since the stage in which we emit attributes is the 'Emit' stage,
21812 not the define stage.
21814 (Emit): Move attribute emission for interface members here.
21816 2003-07-22 Ravi Pratap <ravi@ximian.com>
21818 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21819 closely: we eliminate methods in base types when we have an
21820 applicable method in a top-level type.
21822 Please see section 14.5.5.1 for an exact description of what goes
21825 This fixes bug #45127 and a host of other related to corlib compilation.
21827 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21828 array is the method corresponding to the top-level type (this is
21829 because of the changes made to icall.c) so we change this
21832 (MethodGroupExpr.Name): This too.
21834 * typemanager.cs (GetElementType): New method which does the right
21835 thing when compiling corlib.
21837 * everywhere: Make use of the above in the relevant places.
21839 2003-07-22 Martin Baulig <martin@ximian.com>
21841 * cs-parser.jay (invocation_expression): Moved
21842 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21843 `cast_expression', but create a InvocationOrCast which later
21844 resolves to either an Invocation or a Cast.
21846 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21847 method; call this before EmitStatement() to make sure that this
21848 expression can be used as a statement.
21850 * expression.cs (InvocationOrCast): New class; resolves to either
21851 an Invocation or a Cast.
21853 * statement.cs (StatementExpression): Call ResolveStatement() on
21854 the ExpressionStatement before emitting it.
21856 2003-07-21 Martin Baulig <martin@ximian.com>
21858 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21859 `ref' and `out' attributes match; fixes #46220.
21860 (MemberAccess.ResolveMemberAccess): You can't reference a type
21861 through an expression; fixes #33180.
21862 (Indexers.GetIndexersForType): Don't return the indexers from
21863 interfaces the class implements; fixes #46502.
21865 2003-07-21 Martin Baulig <martin@ximian.com>
21867 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21868 CS0661 checks; fixes bug #30442.
21870 2003-07-21 Martin Baulig <martin@ximian.com>
21872 * decl.cs (AdditionResult): Added `Error'.
21874 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21876 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21877 makes cs0031.cs actually work.
21879 2003-07-20 Martin Baulig <martin@ximian.com>
21881 * namespace.cs: Fixed that bug which caused a crash when compiling
21882 the debugger's GUI.
21884 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21886 * typemanager.cs (LookupTypeReflection): Never expose types which
21887 are NotPublic, NestedPrivate, NestedAssembly, or
21888 NestedFamANDAssem. We used to return these, and later do a check
21889 that would report a meaningful error, but the problem is that we
21890 would not get the real match, if there was a name override.
21892 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21894 * namespace.cs (Namespace, Name): Do not compute the namespace
21895 name dynamically, compute it in the constructor. This reduced
21896 memory usage by 1697 KB.
21898 * driver.cs: Use --pause to pause at the end.
21900 2003-07-17 Peter Williams <peter@newton.cx>
21902 * Makefile: Change the name of the test target so that it doesn't
21903 conflict with the recursive test target.
21905 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21907 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21908 AddressOf): Do not use EmitThis, that was wrong, use the actual
21911 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21913 * class.cs (MethodData.Define): While checking if a method is an
21914 interface implementation, improve the test: If we are not public
21915 (use new test here: use the computed MethodAttributes directly,
21916 instead of the parsed modifier flags) check if the `implementing'
21917 method comes from an interface or not.
21919 * pending.cs (VerifyPendingMethods): Slightly better error
21922 * makefile: add test target that does the mcs bootstrap.
21924 2003-07-16 Ravi Pratap <ravi@ximian.com>
21926 * interface.cs (Define): Do nothing here since there are no
21927 members to populate etc. Move the attribute emission out of here
21928 since this was just totally the wrong place to put it. Attribute
21929 application happens during the 'Emit' phase, not in the 'Define'
21932 (Emit): Add this method and move the attribute emission here
21934 * rootcontext.cs (EmitCode): Call the Emit method on interface
21937 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21939 * expression.cs (OverloadResolve): Report error only if Location
21940 is not 'Null' which means that there was a probe going on.
21942 2003-07-14 Martin Baulig <martin@ximian.com>
21944 * expression.cs (ConditionalLogicalOperator): New public class to
21945 implement user defined conditional logical operators.
21946 This is section 14.11.2 in the spec and bug #40505.
21948 2003-07-14 Martin Baulig <martin@ximian.com>
21950 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21952 2003-07-14 Martin Baulig <martin@ximian.com>
21954 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21956 * ecore.cs (IVariable.VerifyFixed): New interface method.
21958 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21959 operator, check whether the variable is actually fixed. Fixes bug
21960 #36055. Set a variable definitely assigned when taking its
21961 address as required by the spec.
21963 * statement.cs (LocalInfo.IsFixed): New field.
21964 (LocalInfo.MakePinned): Set `IsFixed' to true.
21966 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21968 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21969 for .ctors, ensure that we only ask for members declared in the
21970 attribute type (BindingFlags.DeclaredOnly).
21974 * expression.cs (Error_WrongNumArguments): Report error 1501
21975 correctly the way CSC does.
21977 2003-07-13 Martin Baulig <martin@ximian.com>
21979 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21980 lookup on the fully qualified name, to make things like "X.X" work
21981 where "X.X" is a fully qualified type name, but we also have a
21982 namespace "X" in the using list. Fixes #41975.
21984 2003-07-13 Martin Baulig <martin@ximian.com>
21986 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21987 function. If we're a CompoundAssign, we need to create an embedded
21988 CompoundAssign, not an embedded Assign.
21989 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21992 2003-07-13 Martin Baulig <martin@ximian.com>
21994 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21995 work to fix bug #46088.
21997 2003-07-13 Ravi Pratap <ravi@ximian.com>
21999 * class.cs (Operator.Emit): Do not emit attributes here - it is
22000 taken care of by the Method class that we delegate too. This takes
22001 care of bug #45876.
22003 2003-07-10 Martin Baulig <martin@ximian.com>
22005 * expression.cs (TypeOfVoid): New class.
22006 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
22008 2003-07-10 Martin Baulig <martin@ximian.com>
22010 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
22013 2003-07-10 Martin Baulig <martin@ximian.com>
22015 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
22016 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
22018 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
22020 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
22022 2003-07-10 Martin Baulig <martin@ximian.com>
22024 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
22025 of decimal. Fixes #42850.
22027 NOTE: I also fixed the created byte blob, but this doesn't work on
22028 the MS runtime and csc never produces any byte blobs for decimal
22031 2003-07-10 Martin Baulig <martin@ximian.com>
22033 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
22034 structs; fixes #32068.
22035 (Block.AddChildVariableNames): Fixed #44302.
22037 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22039 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
22041 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22043 * attribute.cs: And this test is onger needed.
22045 2003-07-08 Martin Baulig <martin@ximian.com>
22047 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
22048 inaccessible types. Fixes #36313.
22050 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
22052 * namespace.cs (NamespaceEntry): Create implicit entries for all
22053 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
22054 implicit entries for N1.N2 and N1.
22056 2003-07-08 Martin Baulig <martin@ximian.com>
22058 Rewrote the handling of namespaces to fix a lot of the issues
22059 wrt. `using' aliases etc.
22061 * namespace.cs (Namespace): Splitted this class into a
22062 per-assembly `Namespace' and a per-file `NamespaceEntry'.
22064 * typemanager.cs (TypeManager.IsNamespace): Removed.
22065 (TypeManager.ComputeNamespaces): Only compute namespaces from
22066 loaded assemblies here, not the namespaces from the assembly we're
22067 currently compiling.
22069 2003-07-08 Martin Baulig <martin@ximian.com>
22071 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
22073 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22075 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
22078 I thought about the memory savings here, but LookupTypeReflection
22079 is used under already very constrained scenarios. Compiling
22080 corlib or mcs only exposes one hit, so it would not really reduce
22081 any memory consumption.
22083 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22085 * typemanager.cs: fixes bug #45889 by only adding public types from
22086 other assemblies to the list of known types.
22088 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22090 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
22091 on the type we resolved.
22093 2003-07-05 Martin Baulig <martin@ximian.com>
22095 * pending.cs (PendingImplementation.ParentImplements): Don't
22096 create the proxy if the parent is abstract.
22098 * class.cs (TypeContainer.DefineIndexers): Process explicit
22099 interface implementations first. Fixes #37714.
22101 2003-07-04 Miguel de Icaza <miguel@ximian.com>
22103 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
22104 defined recursively; but since we modify the input parameters
22105 (left is set to `this' temporarily), we reset this value if the
22106 left_is_explicit is false, which gives the original semantics to
22109 * literal.cs (NullPointer): new class used to represent a null
22110 literal in a pointer context.
22112 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
22113 type is a pointer, use a NullPointer object instead of a
22114 NullLiteral. Closes 43687
22116 (ExplicitConversion): Convert pointer values using
22117 the conv opcode to the proper type.
22119 * ecore.cs (New): change ValueTypeVariable property into a method,
22120 that returns whether the valuetype is suitable for being used.
22122 * expression.cs (Binary.DoNumericPromotions): Only return if we
22123 the int constant was a valid uint, and we can return both left and
22124 right as uints. If not, we continue processing, to trigger the
22125 type conversion. This fixes 39018.
22127 * statement.cs (Block.EmitMeta): During constant resolution, set
22128 the CurrentBlock property on the emitcontext, so that we resolve
22129 constants propertly.
22131 2003-07-02 Martin Baulig <martin@ximian.com>
22133 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
22134 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
22136 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
22137 than emitting it here.
22139 * statement.cs: Fixed some more flow analysis bugs.
22141 2003-07-02 Martin Baulig <martin@ximian.com>
22143 * class.cs (MethodData.Define): When implementing interface
22144 methods, set Final unless we're Virtual.
22146 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
22147 check work for interface methods.
22149 2003-07-01 Martin Baulig <martin@ximian.com>
22151 * ecore.cs (EmitContext.This): Replaced this property with a
22152 GetThis() method which takes a Location argument. This ensures
22153 that we get the correct error location for a CS0188.
22155 2003-07-01 Miguel de Icaza <miguel@ximian.com>
22157 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
22158 ImplicitStandardConversion.
22160 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
22162 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
22164 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
22167 2003-06-30 Miguel de Icaza <miguel@ximian.com>
22169 * class.cs (Constructor.Define): Turn off initlocals for unsafe
22172 (MethodData.Define): Turn off initlocals for unsafe methods.
22174 2003-06-29 Miguel de Icaza <miguel@ximian.com>
22176 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
22177 complete; Fixes #37521.
22179 * delegate.cs: Use Modifiers.TypeAttr to compute the
22180 TypeAttributes, instead of rolling our own. This makes the flags
22181 correct for the delegates.
22183 2003-06-28 Miguel de Icaza <miguel@ximian.com>
22185 * class.cs (Constructor.Define): Set the private flag for static
22186 constructors as well.
22188 * cs-parser.jay (statement_expression): Set the return value to
22189 null, to avoid a crash when we catch an error.
22191 2003-06-24 Miguel de Icaza <miguel@ximian.com>
22193 * cs-parser.jay: Applied patch from Jackson that adds support for
22194 extern and unsafe modifiers to destructor declarations.
22196 * expression.cs: Report error 21 if the user is trying to index a
22199 * driver.cs: Add an error message, suggested by the bug report.
22201 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
22202 if we do not have a ": this ()" constructor initializer. Fixes 45149
22204 2003-06-14 Miguel de Icaza <miguel@ximian.com>
22206 * namespace.cs: Add some information to reduce FAQs.
22208 2003-06-13 Miguel de Icaza <miguel@ximian.com>
22210 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
22211 underlying enumeration types. Fixes #43915.
22213 * expression.cs: Treat ushort/short as legal values to be used in
22214 bitwise operations.
22216 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
22218 * delegate.cs: transfer custom attributes for paramenters from
22219 the delegate declaration to Invoke and BeginInvoke.
22221 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
22223 * attribute.cs: handle custom marshalers and emit marshal info
22226 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
22228 * makefile.gnu: Added anonymous.cs to the compiler sources.
22230 2003-05-28 Miguel de Icaza <miguel@ximian.com>
22232 * iterators.cs: Change the name of the proxy class to include two
22235 * cs-parser.jay: Update grammar to include anonymous methods.
22237 * anonymous.cs: new file.
22239 2003-05-27 Miguel de Icaza <miguel@ximian.com>
22241 * class.cs (Field.Define): Add missing test for pointers and
22244 2003-05-27 Ravi Pratap <ravi@ximian.com>
22246 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
22247 we use the stobj opcode.
22249 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
22250 since it wasn't the correct fix.
22252 It still is puzzling that we are required to use stobj for IntPtr
22253 which seems to be a ValueType.
22255 2003-05-26 Miguel de Icaza <miguel@ximian.com>
22257 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
22258 during regular simple name resolution. Now, the trick is that
22259 instead of returning for processing the simplename, we do a
22260 TypeManager.LookupType (ie, a rooted lookup as opposed to a
22261 contextual lookup type). If a match is found, return that, if
22262 not, return for further composition.
22264 This fixes long-standing 30485.
22266 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
22267 using the address to initialize an object, do an Stobj instead of
22268 using the regular Stelem.
22270 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
22271 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
22272 Because if we are a BaseIndexerAccess that value will be true.
22275 * statement.cs (GotoCase.Resolve): Return after reporting an
22276 error, do not attempt to continue.
22278 * expression.cs (PointerArithmetic.Emit): If our operand is a
22279 long, convert our constants to match the operand before
22280 multiplying. Convert to I type before adding. Fixes 43670.
22282 2003-05-14 Ravi Pratap <ravi@ximian.com>
22284 * enum.cs (ImplicitConversionExists) : Rename to
22285 ImplicitEnumConversionExists to remove ambiguity.
22287 * ecore.cs (NullCast): New type of cast expression class which
22288 basically is very similar to EmptyCast with the difference being
22289 it still is a constant since it is used only to cast a null to
22291 (eg. (string) null)
22293 * convert.cs (ImplicitReferenceConversion): When casting a null
22294 literal, we return a NullCast.
22296 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22297 should be around anymore.
22299 The renaming (reported was slightly wrong). Corrections:
22301 ConvertImplicitStandard -> ImplicitConversionStandard
22302 ConvertExplicitStandard -> ExplicitConversionStandard
22304 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22305 before passing them in !
22307 * convert.cs (ImplicitConversionStandard): When comparing for
22308 equal expr and target types, ensure that expr is not a
22311 In general, we must not be checking (expr_type ==
22312 target_type) in the top level conversion methods
22313 (ImplicitConversion, ExplicitConversion etc). This checking is
22314 done in the methods that they delegate to.
22316 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22318 * convert.cs: Move Error_CannotConvertType,
22319 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22320 ImplicitNumericConversion, ImplicitConversionExists,
22321 ImplicitUserConversionExists, StandardConversionExists,
22322 FindMostEncompassedType, FindMostSpecificSource,
22323 FindMostSpecificTarget, ImplicitUserConversion,
22324 ExplicitUserConversion, GetConversionOperators,
22325 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22326 TryImplicitIntConversion, Error_CannotConvertImplicit,
22327 ConvertImplicitRequired, ConvertNumericExplicit,
22328 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22329 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22332 Perform the following renames:
22334 StandardConversionExists -> ImplicitStandardConversionExists
22335 ConvertImplicit -> ImplicitConversion
22336 ConvertImplicitStandard -> ImplicitStandardConversion
22337 TryImplicitIntConversion -> ImplicitIntConversion
22338 ConvertImplicitRequired -> ImplicitConversionRequired
22339 ConvertNumericExplicit -> ExplicitNumericConversion
22340 ConvertReferenceExplicit -> ExplicitReferenceConversion
22341 ConvertExplicit -> ExplicitConversion
22342 ConvertExplicitStandard -> ExplicitStandardConversion
22344 2003-05-19 Martin Baulig <martin@ximian.com>
22346 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22347 (TypeInfo): Added support for structs having structs as fields.
22349 * ecore.cs (FieldExpr): Implement IVariable.
22350 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22351 VariableInfo for the field.
22353 2003-05-18 Martin Baulig <martin@ximian.com>
22355 * expression.cs (This.DoResolve): Report a CS0027 if we're
22356 emitting a field initializer.
22358 2003-05-18 Martin Baulig <martin@ximian.com>
22360 * expression.cs (This.ResolveBase): New public function.
22361 (This.DoResolve): Check for CS0188.
22363 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22366 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22367 `instance_expression' to null if we don't have any non-static
22370 2003-05-18 Martin Baulig <martin@ximian.com>
22372 Reworked the way how local variables and parameters are handled by
22373 the flow analysis code.
22375 * statement.cs (TypeInfo, VariableMap): New public classes.
22376 (VariableInfo): New public class. This is now responsible for
22377 checking whether a variable has been assigned. It is used for
22378 parameters and local variables.
22379 (Block.EmitMeta): Take the InternalParameters as argument; compute
22380 the layout of the flow vectors here.
22381 (Block.LocalMap, Block.ParameterMap): New public properties.
22382 (FlowBranching): The .ctor doesn't get the InternalParameters
22383 anymore since Block.EmitMeta() now computes the layout of the flow
22385 (MyStructInfo): This class is now known as `StructInfo' and nested
22386 in `TypeInfo'; we don't access this directly anymore.
22388 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22389 property and removed IsAssigned(), IsFieldAssigned(),
22390 SetAssigned() and SetFieldAssigned(); we now call them on the
22391 VariableInfo so we don't need to duplicate this code everywhere.
22393 * expression.cs (ParameterReference): Added `Block block' argument
22395 (LocalVariableReference, ParameterReference, This): The new
22396 VariableInfo class is now responsible for all the definite
22399 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22400 IsParameterAssigned, SetParameterAssigned): Removed.
22402 2003-05-18 Martin Baulig <martin@ximian.com>
22404 * typemanager.cs (InitCoreTypes): Try calling
22405 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22406 the 3-args-version. Corlib now also needs our `void_type'.
22407 (GetMethod): Added overloaded version which takes an optional
22408 `bool report_errors' to allow lookups of optional methods.
22410 2003-05-12 Martin Baulig <martin@ximian.com>
22412 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22413 only used for locals and not for parameters.
22415 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22417 * support.cs (InternalParameters.ParameterType): Return the
22418 ExternalType of the parameter.
22420 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22423 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22425 * class.cs (MethodData.Define): Do not set the `newslot' on
22426 interface members, if they are also flagged as "override".
22428 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22429 better code for ++i and i++. This only works for static fields
22430 and local variables.
22432 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22433 want to pull the DeclSpace out of the builder_to_declspace instead
22434 of the TypeBuilder (like in TypeContainer.FindMembers).
22436 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22437 instead of LookupTypeContainer. Fixes the crash on .NET for
22438 looking up interface members.
22440 * const.cs: Create our own emit context during the Definition
22441 stage, so that constants are evaluated in the proper context, when
22442 a recursive definition happens.
22444 2003-05-11 Martin Baulig <martin@ximian.com>
22446 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22447 new block for a switch section.
22448 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22449 the adding/lookup in the switch block. Fixes #39828.
22451 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22453 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22454 functionality: I needed to convert the data after I had performed
22455 the add/sub operation into the operands type size.
22457 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22458 pass the type for the box operation, otherwise the resulting
22459 object would have been of type object.
22461 (BoxedCast): Add constructor to specify the type to box as.
22463 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22465 * iterators.cs: I was reusing the `count' variable inadvertently,
22466 take steps to not allow this to happen.
22468 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22470 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22471 by creating an array at the point where the params starts and
22472 putting all those arguments there, then adjusting the size of the
22475 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22477 * expression.cs (New.AddressOf): Implement interface
22478 IMemoryLocation. This is used when the `new' operator is used in
22479 the context of an invocation to a method on a value type.
22481 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22484 * namespace.cs: Also check the using aliases here.
22486 * driver.cs: Move the test for using validity after the types have
22487 been entered, so we do a single pass that also includes the using
22490 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22491 in the regular case. CreateSiblingForFinally is doing extra
22494 * attribute.cs (GetAttributeArgumentExpression): Store the result
22495 on an out value, and use the return value to indicate failure
22496 instead of using null (which is a valid return for Constant.GetValue).
22498 * statement.cs: Perform the analysis flow for the increment
22499 portion after the statement, because this will be the real flow of
22500 execution. Fixes #42385
22502 * codegen.cs (EmitContext.EmitArgument,
22503 EmitContext.EmitStoreArgument): New helper functions when the
22504 RemapToProxy flag is set.
22506 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22509 Add support for remapping parameters.
22511 * iterators.cs: Propagate parameter values; Store parameter
22512 values in the proxy classes.
22514 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22516 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22517 need a proxy reference; I do not know what I was thinking
22519 * cs-parser.jay (constructor_initializer): catch another error,
22520 and display nice message.
22522 (field_declaration): catch void field declaration
22523 to flag a better error.
22525 * class.cs (MemberBase.CheckBase): Report an error instead of a
22526 warning if a new protected member is declared in a struct.
22527 (Field.Define): catch the error of readonly/volatile.
22529 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22531 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22532 volatile variable is taken
22534 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22536 * statement.cs (Fixed.Resolve): Report an error if we are not in
22539 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22541 * typemanager.cs: reuse the code that handles type clashes for
22542 delegates and enumerations.
22544 * class.cs (Report28): Always report.
22546 * expression.cs (EncodeAsAttribute): Allow nulls here.
22548 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22550 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22551 the functionality for testing whether an expression is valid for
22552 an attribute here. Also handle the case of arrays of elements
22555 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22556 encoding a linear array into an array of objects that are suitable
22557 to be passed to an CustomAttributeBuilder.
22559 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22561 * ecore.cs: (FieldExpr): Handle field remapping here.
22563 * iteratators.cs: Pass the instance variable (if the method is an
22564 instance method) to the constructors, so we can access the field
22565 variables on the class.
22567 TODO: Test this with structs. I think the THIS variable on
22568 structs might have to be a pointer, and not a refenrece
22570 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22572 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22573 local variables to fields in a proxy class.
22575 * iterators.cs (PopulateProxy): Rename our internal fields to
22577 Create a <THIS> field if we are an instance method, so we can
22578 reference our parent container variables.
22579 (MapVariable): Called back from the EmitContext code to enter a
22580 new variable to field mapping into the proxy class (we just create
22584 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22585 for using the remapped locals to fields.
22587 I placed the code here, because that gives the same semantics to
22588 local variables, and only changes the Emit code.
22590 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22591 statements inside iterators.
22592 (VariableInfo): Add a FieldBuilder for the cases when we are
22593 remapping local variables to fields in a proxy class
22595 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22596 current_block != null.
22598 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22599 not cope with strings, as it has been moved to the
22600 TableSwitchEmit. Fixed bug in switch generation.
22602 * expression.cs (New.DoResolve): Provide more context for the user
22603 when reporting an error.
22605 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22608 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22609 check the permissions for it. Note than in a type-resolution
22610 context the check was already present in DeclSpace.ResolveType,
22611 but was missing from the MemberAccess.
22613 (ArrayCreation.CheckIndices): warn if the user has
22614 more nested levels of expressions, but there are no more
22615 dimensions specified. Avoids crash on bug 41906.
22617 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22619 * statement.cs (Block): replace Implicit bool, for a generic
22621 New flag: `Unchecked'. This is used during the EmitMeta phase
22622 (which is out-of-line with the regular Resolve/Emit process for a
22623 statement, as this is done ahead of time, but still gets a chance
22624 to call constant resolve).
22626 (Block.Flags): new enum for adding a new flag.
22628 (Block.EmitMeta): track the state of unchecked.
22630 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22631 to enable constant resolution to work there as well.
22633 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22635 * typemanager.cs (ienumerable_type): Also look up
22636 System.Collections.IEnumerable.
22638 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22640 TODO: Test more than one conditional per method.
22642 * class.cs (Indexer.Define): Report the location where the user is
22643 referencing the unsupported feature.
22645 (MethodData): Overload the use of `conditionals' to
22646 minimize the creation of needless ArrayLists. This saves roughly
22647 212kb on my machine.
22649 (Method): Implement the new IIteratorContainer interface.
22650 (Method.SetYields): Implement the method by setting the ModFlags
22651 to contain METHOD_YIELDS.
22653 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22654 which just got set to null.
22656 * iterators.cs: New file.
22658 (Yield, YieldBreak): New statements.
22660 * statement.cs (Return.Resolve): Flag an error if we are used in
22661 an iterator method.
22663 * codegen.cs (InIterator): New flag set if the code is being
22664 compiled in an iterator method.
22666 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22667 internal modifier, and we just use it to avoid adding extra
22668 fields, as this is seldom used.
22670 * cs-parser.jay: Add yield_statement (yield and yield break).
22672 * driver.cs: New flag -v2 to turn on version 2 features.
22674 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22675 hashtable when v2 is enabled.
22677 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22679 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22680 there is already a namespace defined with this name.
22682 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22683 people upgraded their corlibs.
22685 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22686 always use fully qualified types, no need to use the compiler
22689 (TypeManager.IsNamespace): Use binarysearch.
22691 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22692 AddDelegate): I did not quite use the new IsValid API properly: I
22693 have to pass the short-name and the fullname. I was passing only
22694 the basename instead of the fullname sometimes.
22696 (TypeContainer.DefineType): call NamespaceClash.
22698 * interface.cs (Interface.DefineType): use NamespaceClash before
22701 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22704 * enum.cs: (Enum.DefineType): use NamespaceClash before
22707 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22708 speed increase. First, use the negative_hits cache when we get a
22709 negative. Second, add the type with its full original name
22710 instead of the new . and + encoded name (reflection uses + to
22711 separate type from a nested type). Use LookupTypeReflection
22712 directly which bypasses the type->name hashtable (that we already
22713 know does not contain the type.
22715 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22716 location/container type.
22718 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22720 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22722 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22724 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22725 method is being referenced in the method group from a static
22726 context, and report error 120 if so.
22728 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22731 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22732 is created, we create the A namespace).
22734 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22737 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22739 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22740 invocation to ModuleBuilder.GetType with the same values will
22741 return a new type instance, so we need to cache its return
22744 * expression.cs (Binary.ResolveOperator): Only allow the compare
22745 operators on enums if they are of the same type.
22747 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22748 types of ValueType on their own case. Before we were giving them
22749 the same treatment as objects.
22751 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22752 fullname. Short name is used to compare against container name.
22753 Fullname is used to check against defined namespace names.
22755 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22756 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22758 (Method.CheckBase): Call parent.
22759 (MemberBase.CheckBase): Check for protected members on sealed
22761 (PropertyBase.CheckBase): Call parent.
22762 (Field.Define): Call parent.
22764 * report.cs: Negative error codes are now mapped to 8000 - code,
22765 so that the display is render more nicely.
22767 * typemanager.cs: Do not use try/catch, instead report a regular
22770 (GetPointerType, GetReferenceType): These methods provide
22771 mechanisms to obtain the T* and T& from a T. We had the code
22772 previously scattered around the code base, and it also used
22773 TypeManager.LookupType that would go through plenty of caches.
22774 This one goes directly to the type source.
22776 In some places we did the Type.GetType followed by
22777 ModuleBuilder.GetType, but not in others, so this unifies the
22778 processing as well.
22780 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22781 statements now that we have namespace information.
22783 * typemanager.cs (IsNamespace): New method, returns whether the
22784 string presented is a namespace or not.
22786 (ComputeNamespaces): New public entry point, computes the list of
22787 available namespaces, using the GetNamespaces API call in Mono, or
22788 the slower version in MS.NET.
22790 Now before we start the semantic analysis phase, we have a
22791 complete list of namespaces including everything that the user has
22794 Deleted old code to cache namespaces in .nsc files.
22796 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22798 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22799 class/struct location definition Location for the implicit
22800 constructor location.
22802 (Operator.Define): Use the location of the operator for the
22803 implicit Method definition.
22805 (Constructor.Emit): use the constructor location for the implicit
22806 base initializer constructor.
22808 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22809 and the Expression class now contains two new methods:
22811 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22812 isolate type lookup from the rest of the resolution process.
22814 Since we use Expressions to hold type definitions due to the way
22815 we parse the input we have historically overloaded Resolve to
22816 perform the Type lookups if a special flag is passed. Now this is
22817 eliminated and two methods take their place.
22819 The differences in the two methods between xStep and xTerminal is
22820 that xStep is involved in our current lookup system that uses
22821 SimpleNames to compose a name, while xTerminal is used just to
22822 catch the case where the simplename lookup failed.
22824 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22826 * expression.cs (ResolveMemberAccess): Remove redundant code.
22827 TypeExpr expressions are always born fully resolved.
22829 * interface.cs (PopulateMethod): Do not lookup the types twice.
22830 We were doing it once during SemanticAnalysis and once during
22833 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22834 in local variable type definitions, were being returned as a
22835 SimpleName (we decomposed everything into a string), that is
22836 because primary_expression was being used instead of a type in the
22837 grammar (reduce/reduce conflicts).
22839 The part that was wrong is that we converted the expression into a
22840 string (an oversimplification in one hand, compounded with primary
22841 expressions doing string concatenation).
22847 Would return "A.B.C[]" as a SimpleName. This stopped things like
22848 using clauses from working on this particular context. And a type
22849 was being matched directly against "A.B.C[]".
22851 We now use the correct approach, and allow for ComposedCast to be
22852 part of the unary expression. So the "A.B.C []" become a composed
22853 cast of "A.B.C" (as a nested group of MemberAccess with a
22854 SimpleName at the end) plus the rank composition "[]".
22858 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22860 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22861 for the access level checking.
22863 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22864 `TypeContainer container', because I kept getting confused when I
22865 was debugging this code.
22867 * expression.cs (Indexers): Instead of tracking getters/setters,
22868 we now track them in parallel. We create one arraylist less, but
22869 most importantly it is possible now for the LValue code to find a
22870 matching get for a set.
22872 (IndexerAccess.DoResolveLValue): Update the code.
22873 GetIndexersForType has been modified already to extract all the
22874 indexers from a type. The code assumed it did not.
22876 Also make the code set the correct return type for the indexer.
22877 This was fixed a long time ago for properties, but was missing for
22878 indexers. It used to be void_type.
22880 (Binary.Emit): Test first for doubles instead of
22881 floats, as they are more common.
22883 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22884 when dealing with floats and the <=, >= operators. This fixes bug
22887 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22888 to load the array value by emitting a load on the foreach variable
22889 type. This was incorrect.
22891 We now emit the code to load an element using the the array
22892 variable type, and then we emit the conversion operator.
22896 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22898 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22900 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22902 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22903 test for protection before we test for signatures.
22905 (MethodSignature.ToString): implement.
22907 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22908 to the case where we reduced into a LongConstant.
22910 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22911 depend on whether the information is acurrate, because the
22912 Microsoft runtime will always claim that the array type is public,
22913 regardless of the real state.
22915 If the type is a pointer, another problem happens: the type is
22916 reported as non-public in Microsoft.
22918 In both cases we have to call CheckAccessLevel recursively with
22919 the underlying type as the argument to be tested.
22921 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22923 * assign.cs (Assign.Emit): If we are dealing with a compound
22924 assignment expression, we should use the code path that stores the
22925 intermediate result in a temporary value. This fixes #40903.
22927 *expression.cs (Indirection.ToString): Provide ToString method for
22930 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22932 * class.cs: Null out fields holding references to Block objects so
22933 they can be garbage collected.
22935 * expression.cs (OverloadResolve): Remove unused local.
22937 2003-04-07 Martin Baulig <martin@ximian.com>
22939 * codegen.cs (EmitContext.CurrentFile): New public field.
22940 (EmitContext.Mark): Use the CurrentFile to check whether the
22941 location is in the correct file.
22942 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22944 2003-04-07 Martin Baulig <martin@ximian.com>
22946 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22948 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22949 location. [FIXME: The location argument which gets passed to this
22950 method is sometimes wrong!]
22952 2003-04-07 Nick Drochak <ndrochak@gol.com>
22954 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22956 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22958 * expression.cs (Indirection.EmitAssign): We were using the
22959 temporary, but returning immediately instead of continuing the
22962 2003-04-06 Martin Baulig <martin@ximian.com>
22964 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22965 if it's a nested child, but also deriving from the outer class.
22968 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22969 nested child, but also deriving from the outer class. See
22971 (FilterWithClosure): We may access private members of the outer
22972 class if we're a nested child and deriving from the outer class.
22973 (RealMemberLookup): Only set `closure_private_ok' if the
22974 `original_bf' contained BindingFlags.NonPublic.
22976 2003-04-05 Martin Baulig <martin@ximian.com>
22978 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22980 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22982 * class.cs (Event.Define): Do not allow abstract events to have
22985 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22987 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22988 block in event declarations.
22990 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22991 value type, get its address.
22993 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22994 leaving a class on the stack instead of a boolean value (int
22995 0/1). Change the code so we compare against null, and then the
22996 result against zero.
22998 * class.cs (TypeContainer.GetClassBases): We were checking for the
22999 parent class being sealed too late.
23001 * expression.cs (Binary.Emit): For <= and >= when dealing with
23002 floating point values, use cgt.un and clt.un instead of cgt and
23005 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
23007 * statement.cs: Apply the same optimization as MS: skip the
23008 GetEnumerator returning an IEnumerator, and use the one returning a
23009 CharEnumerator instead. This allows us to avoid the try-finally block
23012 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
23014 * cs-parser.jay: Attributes cannot be applied to
23015 namespaces. Fixes #40473
23017 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23020 (Add*): check if the name is valid using the full name for constants,
23021 fields, properties and events.
23023 2003-03-28 Miguel de Icaza <miguel@ximian.com>
23025 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
23026 char constants to be part of the enumeration.
23028 * expression.cs (Conditional.DoResolve): Add support for operator
23029 true. Implements the missing functionality from 14.12
23031 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
23032 operator true/false as required by the spec.
23034 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
23035 implicit conversion to boolean.
23037 * statement.cs (Statement.ResolveBoolean): A boolean expression is
23038 also one where the type implements `operator true'.
23040 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
23041 get an expression that will invoke operator true based on an
23044 (GetConversionOperators): Removed the hack that called op_True
23047 (Expression.ResolveBoolean): Move this from Statement.
23049 2003-03-17 Miguel de Icaza <miguel@ximian.com>
23051 * ecore.cs (FieldExpr): do not allow initialization of initonly
23052 fields on derived classes
23054 2003-03-13 Martin Baulig <martin@ximian.com>
23056 * statement.cs (Block.Emit): Call ig.BeginScope() and
23057 ig.EndScope() when compiling with debugging info; call
23058 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
23060 2003-03-08 Miguel de Icaza <miguel@ximian.com>
23062 * expression.cs (Indexers): Do not construct immediately, allow
23063 for new members to be appended as we go. Fixes 38143
23065 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23067 * expression.cs: save/restore context when resolving an unchecked
23070 2003-03-05 Miguel de Icaza <miguel@ximian.com>
23072 * cfold.cs: Catch division by zero in modulus operator during
23075 2003-03-03 Miguel de Icaza <miguel@ximian.com>
23077 * interface.cs (Interface.DefineMembers): Avoid defining members
23080 2003-02-27 Miguel de Icaza <miguel@ximian.com>
23082 * driver.cs: handle the +/- options for -noconfig
23084 * statement.cs (Unckeched.Resolve): Also track the state of
23085 unchecked in the Resolve phase.
23087 2003-02-27 Martin Baulig <martin@ximian.com>
23089 * ecore.cs (Expression.MemberLookup): Don't create a
23090 MethodGroupExpr for something which is not a method. Fixes #38291.
23092 2003-02-25 Miguel de Icaza <miguel@ximian.com>
23094 * class.cs (MemberBase.CheckParameters): Also check that the type
23095 is unmanaged if it is a pointer.
23097 * expression.cs (SizeOf.Resolve): Add location information.
23099 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
23100 a managed type is declared.
23102 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
23103 parameter modifiers as well. Fixes bug 38606
23105 * class.cs: Very sad. Am backing out the speed up changes
23106 introduced by the ArrayList -> Array in the TypeContainer, as they
23107 were not actually that much faster, and introduced a bug (no error
23108 reports on duplicated methods).
23110 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
23111 source first, this will guarantee that we have a valid expression
23112 before calling in lower levels functions that will require a
23113 resolved object. Then use this original_source in the
23114 target.ResolveLValue instead of the original source that was
23117 Another change. Use target.Resolve instead of LValueResolve.
23118 Although we are resolving for LValues, we will let the Assign code
23119 take care of that (it will be called again from Resolve). This
23120 basically allows code like this:
23122 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
23123 class Y { void A (X x) { x [0] += o; }
23125 The problem was that the indexer was trying to resolve for
23126 set_Item (idx, object o) and never finding one. The real set_Item
23127 was set_Item (idx, X). By delaying the process we get the right
23132 2003-02-23 Martin Baulig <martin@ximian.com>
23134 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
23135 while calling DoEmit ().
23137 * codegen.cs (EmitContext.Mark): Don't mark locations in other
23138 source files; if you use the #line directive inside a method, the
23139 compiler stops emitting line numbers for the debugger until it
23140 reaches the end of the method or another #line directive which
23141 restores the original file.
23143 2003-02-23 Martin Baulig <martin@ximian.com>
23145 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
23147 2003-02-23 Martin Baulig <martin@ximian.com>
23149 * statement.cs (Block.AddChildVariableNames): We need to call this
23150 recursively, not just for our immediate children.
23152 2003-02-23 Martin Baulig <martin@ximian.com>
23154 * class.cs (Event.Define): Always make the field private, like csc does.
23156 * typemanager.cs (TypeManager.RealMemberLookup): Make events
23157 actually work, fixes bug #37521.
23159 2003-02-23 Miguel de Icaza <miguel@ximian.com>
23161 * delegate.cs: When creating the various temporary "Parameters"
23162 classes, make sure that we call the ComputeAndDefineParameterTypes
23163 on those new parameters (just like we do with the formal ones), to
23164 allow them to be resolved in the context of the DeclSpace.
23166 This fixes the bug that Dick observed in Bugzilla #38530.
23168 2003-02-22 Miguel de Icaza <miguel@ximian.com>
23170 * expression.cs (ResolveMemberAccess): When resolving a constant,
23171 do not attempt to pull a constant if the value was not able to
23172 generate a valid constant.
23174 * const.cs (LookupConstantValue): Do not report more errors than required.
23176 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23178 * expression.cs: fixes bug #38328.
23180 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23182 * class.cs: Changed all the various members that can be part of a
23183 class from being an ArrayList to be an Array of the right type.
23184 During the DefineType type_list, interface_list, delegate_list and
23185 enum_list are turned into types, interfaces, delegates and enums
23188 And during the member population, indexer_list, event_list,
23189 constant_list, field_list, instance_constructor_list, method_list,
23190 operator_list and property_list are turned into their real arrays.
23192 Although we could probably perform this operation earlier, for
23193 good error reporting we need to keep the lists and remove the
23194 lists for longer than required.
23196 This optimization was triggered by Paolo profiling the compiler
23197 speed on the output of `gen-sample-program.pl' perl script.
23199 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
23200 not crash in methods like MemberLookupFailed that use this field.
23202 This problem arises when the compiler fails to resolve a type
23203 during interface type definition for example.
23205 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23207 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
23208 inherit from System.Object, so we have to stop at null, not only
23209 when reaching System.Object.
23211 2003-02-17 Miguel de Icaza <miguel@ximian.com>
23213 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
23214 DeclaredOnly because the parent indexer might have had a different
23215 name, but did not loop until the top of the hierarchy was reached.
23217 The problem this one fixes is 35492: when a class implemented an
23218 indexer from an interface, we were getting the interface method
23219 (which was abstract) and we were flagging an error (can not invoke
23222 This also keeps bug 33089 functioning, and test-148 functioning.
23224 * typemanager.cs (IsSpecialMethod): The correct way of figuring
23225 out if a method is special is to see if it is declared in a
23226 property or event, or whether it is one of the predefined operator
23227 names. This should fix correctly #36804.
23229 2003-02-15 Miguel de Icaza <miguel@ximian.com>
23231 The goal here is to remove the dependency on EmptyCast.Peel ().
23232 Killing it completely.
23234 The problem is that currently in a number of places where
23235 constants are expected, we have to "probe" for an EmptyCast, and
23236 Peel, which is not the correct thing to do, as this will be
23237 repetitive and will likely lead to errors.
23239 The idea is to remove any EmptyCasts that are used in casts that
23240 can be reduced to constants, so we only have to cope with
23243 This bug hunt was triggered by Bug 37363 and the desire to remove
23244 the duplicate pattern where we were "peeling" emptycasts to check
23245 whether they were constants. Now constants will always be
23248 * ecore.cs: Use an enumconstant here instead of wrapping with
23251 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
23252 throwing me off. By handling this we can get rid of a few hacks.
23254 * statement.cs (Switch): Removed Peel() code.
23256 2003-02-14 Miguel de Icaza <miguel@ximian.com>
23258 * class.cs: Location information for error 508
23260 * expression.cs (New.DoResolve): Add a guard against double
23261 resolution of an expression.
23263 The New DoResolve might be called twice when initializing field
23264 expressions (see EmitFieldInitializers, the call to
23265 GetInitializerExpression will perform a resolve on the expression,
23266 and later the assign will trigger another resolution
23268 This leads to bugs (#37014)
23270 * delegate.cs: The signature for EndInvoke should contain any ref
23271 or out parameters as well. We were not doing this in the past.
23273 * class.cs (Field.Define): Do not overwrite the type definition
23274 inside the `volatile' group. Turns out that volatile enumerations
23275 were changing the type here to perform a validity test, which
23278 2003-02-12 Miguel de Icaza <miguel@ximian.com>
23280 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
23281 and structs, we do not want to load the instance variable
23283 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
23284 enum_type has to be handled like an object reference (implicit
23285 conversions exists from this to object), but the regular IsClass
23286 and IsValueType tests will never return true for this one.
23288 Also we use TypeManager.IsValueType instead of type.IsValueType,
23289 just for consistency with the rest of the code (this is only
23290 needed if we ever use the construct exposed by test-180.cs inside
23291 corlib, which we dont today).
23293 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23295 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23298 2003-02-09 Martin Baulig <martin@ximian.com>
23300 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23301 (Namespace.DefineNamespaces): New static public method; this is
23302 called when we're compiling with debugging to add all namespaces
23303 to the symbol file.
23305 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23306 pass it to the Namespace's .ctor.
23308 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23309 and MethodBase arguments; pass the namespace ID to the symwriter;
23310 pass the MethodBase instead of the token to the symwriter.
23311 (SymbolWriter.DefineNamespace): New method to add a namespace to
23314 2003-02-09 Martin Baulig <martin@ximian.com>
23316 * symbolwriter.cs: New file. This is a wrapper around
23317 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23318 methods here in near future.
23320 2003-02-09 Martin Baulig <martin@ximian.com>
23322 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23323 ILGenerator.MarkSequencePoint() which are actually used by the
23326 2003-02-09 Martin Baulig <martin@ximian.com>
23328 * location.cs (SourceFile): New public sealed class. This
23329 contains the name and an index which is used in the location's token.
23330 (Location): Reserve an appropriate number of bits in the token for
23331 the source file instead of walking over that list, this gives us a
23332 really huge performance improvement when compiling with debugging.
23334 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23335 `SourceFile' argument instead of a string.
23336 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23337 but don't parse/tokenize here, we need to generate the list of all
23338 source files before we do that.
23339 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23342 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23343 instead of a string.
23345 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23348 2003-02-09 Martin Baulig <martin@ximian.com>
23350 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23351 filename on `#line default'.
23353 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23355 * statement.cs: don't clear the pinned var when the fixed statement
23356 returns from the method (fixes bug#37752).
23358 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23360 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23363 2003-02-07 Martin Baulig <martin@ximian.com>
23365 * driver.cs: Removed the `--debug-args' command line argument.
23367 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23368 automatically by the AsssemblyBuilder.
23369 (CodeGen.InitializeSymbolWriter): We don't need to call any
23370 initialization function on the symbol writer anymore. This method
23371 doesn't take any arguments.
23373 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23375 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23376 from referenced assemblies as well.
23378 2003-02-02 Martin Baulig <martin@ximian.com>
23380 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23382 2003-02-02 Martin Baulig <martin@ximian.com>
23384 * class.cs (Constructor.Emit): Open the symbol writer before
23385 emitting the constructor initializer.
23386 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23387 single-stepping through constructor initializers.
23389 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23391 * class.cs: Handle error 549: do not allow virtual methods in
23394 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23396 * decl.cs: Check access levels when resolving types
23398 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23400 * statement.cs: Add parameters and locals set in catch blocks that might
23401 return to set vector
23403 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23405 * class.cs (Operator): Set the SpecialName flags for operators.
23407 * expression.cs (Invocation.DoResolve): Only block calls to
23408 accessors and operators on SpecialName methods.
23410 (Cast.TryReduce): Handle conversions from char constants.
23413 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23415 * statement.cs: small memory and time optimization in FlowBranching.
23417 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23419 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23420 problem that the last fix but in the other sid (Set).
23422 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23423 access when there is no indexer in the hierarchy.
23425 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23427 * class.cs: Combine some if statements.
23429 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23431 * driver.cs: fixed bug #37187.
23433 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23435 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23436 any indexer, it's needed to build a list with all the indexers in the
23437 hierarchy (AllGetters), else we have problems. Fixes #35653.
23439 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23441 * class.cs (MethodData.Define): It is wrong for an interface
23442 implementation to be static in both cases: explicit and implicit.
23443 We were only handling this in one case.
23445 Improve the if situation there to not have negations.
23447 * class.cs (Field.Define): Turns out that we do not need to check
23448 the unsafe bit on field definition, only on usage. Remove the test.
23450 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23452 * driver.cs: use assembly.Location instead of Codebase (the latest
23453 patch made mcs fail when using MS assemblies).
23455 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23457 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23458 get the path to *corlib.dll.
23460 2003-01-21 Nick Drochak <ndrochak@gol.com>
23464 * typemanager.cs: Remove compiler warnings
23466 2003-01-20 Duncan Mak <duncan@ximian.com>
23468 * AssemblyInfo.cs: Bump the version number to 0.19.
23470 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23472 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23474 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23476 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23478 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23480 * cs-parser.jay: Small fix: we were not comparing the constructor
23481 name correctly. Thanks to Zoltan for the initial pointer.
23483 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23485 * cs-tokenizer.cs: Set file name when specified with #line
23487 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23489 * cs-parser.jay: Only perform the constructor checks here if we
23490 are named like the class; This will help provider a better
23491 error. The constructor path is taken when a type definition is
23492 not found, but most likely the user forgot to add the type, so
23493 report that rather than the constructor error.
23495 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23497 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23500 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23502 * cs-parser.jay: Add cleanup call.
23504 2003-01-13 Duncan Mak <duncan@ximian.com>
23506 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23507 consistent with other methods.
23509 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23511 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23513 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23515 * attribute.cs: only set GuidAttr to true when we have a
23518 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23522 * typemanager.cs: fixes to allow mcs compile corlib with the new
23523 Type.IsSubclassOf fix.
23525 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23527 * expression.cs (LocalVariableReference.DoResolve): Classify a
23528 constant as a value, not as a variable. Also, set the type for
23531 * cs-parser.jay (fixed_statement): take a type instead of a
23532 pointer_type, so we can produce a better error message later.
23534 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23537 (For.DoEmit): Make inifinite loops have a
23538 non-conditional branch back.
23540 (Fixed.DoEmit): First populate the pinned variables, then emit the
23541 statement, then clear the variables. Before I was emitting the
23542 code once for each fixed piece.
23545 2003-01-08 Martin Baulig <martin@ximian.com>
23547 * statement.cs (FlowBranching.MergeChild): A break in a
23548 SWITCH_SECTION does not leave a loop. Fixes #36155.
23550 2003-01-08 Martin Baulig <martin@ximian.com>
23552 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23553 lives in the same number space than `param_map'. Fixes #36154.
23555 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23557 * cs-parser.jay (constructor_declaration): Set the
23558 Constructor.ModFlags before probing for it. This makes the
23559 compiler report 514, 515 and 132 (the code was there, but got
23562 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23563 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23564 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23566 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23568 * enum.cs: create the enum static fields using the enum type.
23570 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23572 * class.cs: don't try to create the ParamBuilder for the return
23573 type if it's not needed (and handle it breaking for the ms runtime
23576 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23578 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23580 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23582 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23583 the command. This showed up while compiling the JANET source
23584 code, which used \r as its only newline separator.
23586 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23588 * class.cs (Method.Define): If we are an operator (because it
23589 reuses our code), then set the SpecialName and HideBySig. #36128
23591 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23593 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23594 exception, report error 120 `object reference required'.
23596 * driver.cs: Add --pause option, used during to measure the size
23597 of the process as it goes with --timestamp.
23599 * expression.cs (Invocation.DoResolve): Do not allow methods with
23600 SpecialName to be invoked.
23602 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23604 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23605 number before adding it.
23607 2002-12-21 Ravi Pratap <ravi@ximian.com>
23609 * ecore.cs (StandardImplicitConversion): When in an unsafe
23610 context, we allow conversion between void * to any other pointer
23611 type. This fixes bug #35973.
23613 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23615 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23616 is not thrown when extensionless outputs are used
23618 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23620 * rootcontext.cs: fixed compilation of corlib.
23622 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23624 * attribute.cs (Attributes.Contains): Add new method.
23626 * class.cs (MethodCore.LabelParameters): if the parameter is an
23627 `out' parameter, check that no attribute `[In]' has been passed.
23629 * enum.cs: Handle the `value__' name in an enumeration.
23631 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23633 * decl.cs: Added special case to allow overrides on "protected
23636 2002-12-18 Ravi Pratap <ravi@ximian.com>
23638 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23639 since it makes much more sense.
23641 (Attributes.ctor): Don't require a Location parameter.
23643 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23645 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23646 since we already have that information per attribute.
23648 * everywhere : make appropriate changes.
23650 * class.cs (LabelParameters): Write the code which actually
23651 applies attributes to the return type. We can't do this on the MS
23652 .NET runtime so we flag a warning in the case an exception is
23655 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23657 * const.cs: Handle implicit null conversions here too.
23659 2002-12-17 Ravi Pratap <ravi@ximian.com>
23661 * class.cs (MethodCore.LabelParameters): Remove the extra
23662 Type [] parameter since it is completely unnecessary. Instead
23663 pass in the method's attributes so that we can extract
23664 the "return" attribute.
23666 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23668 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23669 of ignoring it and letting the compile continue.
23671 * typemanager.cs (ChangeType): use an extra argument to return an
23672 error condition instead of throwing an exception.
23674 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23676 * expression.cs (Unary.TryReduce): mimic the code for the regular
23677 code path. Perform an implicit cast in the cases where we can
23678 implicitly convert to one of the integral types, and then reduce
23679 based on that constant. This fixes bug #35483.
23681 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23683 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23685 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23687 * namespace.cs: fixed bug #35489.
23689 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23691 * class.cs: Remove some dead code.
23693 * cs-parser.jay: Estimate the number of methods needed
23694 (RootContext.MethodCount);
23696 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23697 numbers instead of StringBuilders.
23699 * support.cs (PtrHashtable): Add constructor with initial size;
23700 We can now reduce reallocations of the method table.
23702 2002-12-10 Ravi Pratap <ravi@ximian.com>
23704 * attribute.cs (ApplyAttributes): Keep track of the emitted
23705 attributes on a per-target basis. This fixes bug #35413.
23707 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23709 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23710 default to the Windows 1252 encoding.
23712 (UnixParseOption): Support version, thanks to Alp for the missing
23715 * AssemblyInfo.cs: Add nice assembly information.
23717 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23720 * cs-parser.jay: Allow a trailing comma before the close bracked
23721 in the attribute_section production.
23723 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23724 address of the instance was being taken, I will take this out,
23725 because we take the address of the object immediately here.
23727 2002-12-09 Ravi Pratap <ravi@ximian.com>
23729 * typemanager.cs (AreMultipleAllowed): Take care of the most
23730 obvious case where attribute type is not in the current assembly -
23733 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23735 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23736 definitions, instead of doing that afterwards.
23738 Also we use a nice little hack, depending on the constructor, we
23739 know if we are a "composed" name or a simple name. Hence, we
23740 avoid the IndexOf test, and we avoid
23742 * codegen.cs: Add code to assist in a bug reporter to track down
23743 the source of a compiler crash.
23745 2002-12-07 Ravi Pratap <ravi@ximian.com>
23747 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23748 types have been emitted for a given element and flag an error
23749 if something which does not have AllowMultiple set is used more
23752 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23753 attribute types and their corresponding AllowMultiple properties
23755 (AreMultipleAllowed): Check the property for a given type.
23757 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23758 property in the case we have a TypeContainer.
23760 (Attributes.AddAttribute): Detect duplicates and just skip on
23761 adding them. This trivial fix catches a pretty gross error in our
23762 attribute emission - global attributes were being emitted twice!
23764 Bugzilla bug #33187 is now fixed.
23766 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23768 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23769 instead of pp_and).
23771 * expression.cs (Binary.ResolveOperator): I can only use the
23772 Concat (string, string, string) and Concat (string, string,
23773 string, string) if the child is actually a concatenation of
23776 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23778 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23779 context where we need a 2-character lookahead.
23781 * pending.cs (PendingImplementation): Rework so we can keep track
23782 of interface types all the time, and flag those which were
23783 implemented by parents as optional.
23785 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23787 * expression.cs (Binary.ResolveOperator): Use
23788 String.Concat(string,string,string) or
23789 String.Concat(string,string,string,string) when possible.
23791 * typemanager: More helper methods.
23794 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23796 * pending.cs: remove the bogus return from GetMissingInterfaces()
23797 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23799 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23801 * namespace.cs: avoid duplicated 'using xxx' being added to
23802 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23803 when we get more than one 'using' statement for the same namespace.
23804 Report a CS0105 warning for it.
23806 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23808 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23809 of calling getChar/putback, uses internal knowledge of it.
23811 (xtoken): Reorder tokenizer so most common patterns are checked
23812 first. This reduces the compilation time in another 5% (from 8.11s
23813 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23815 The parsing time is 22% of the compilation in mcs, and from that
23816 64% is spent on the tokenization process.
23818 I tried using a binary search for keywords, but this is slower
23819 than the hashtable. Another option would be to do a couple of
23822 * Not use a StringBuilder, instead use an array of chars,
23823 with a set value. Notice that this way we could catch
23824 the 645 error without having to do it *afterwards*.
23826 * We could write a hand-parser to avoid the hashtable
23827 compares altogether.
23829 The identifier consumption process takes 37% of the tokenization
23830 time. Another 15% is spent on is_number. 56% of the time spent
23831 on is_number is spent on Int64.Parse:
23833 * We could probably choose based on the string length to
23834 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23837 Another 3% is spend on wrapping `xtoken' in the `token' function.
23839 Handle 0xa0 as whitespace (#34752)
23841 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23843 * typemanager.cs (IsCLRType): New routine to tell whether a type
23844 is one of the builtin types.
23846 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23847 typecode in more places instead of doing pointer comparissions.
23848 We could leverage some knowledge about the way the typecodes are
23851 New code to cache namespaces in assemblies, it is currently not
23852 invoked, to be used soon.
23854 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23856 * expression.cs (Binary.ResolveOperator): specially handle
23857 strings, and do not perform user-defined operator overloading for
23860 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23862 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23863 internalcall as it is a pretty simple operation; Avoid whenever
23864 possible to call Char.IsLetter.
23866 (consume_identifier): Cut by half the number of
23867 hashtable calls by merging the is_keyword and GetKeyword behavior.
23869 Do not short-circuit, because if we do, we
23870 report errors (ie, #if false && true would produce an invalid
23874 2002-11-24 Martin Baulig <martin@ximian.com>
23876 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23877 check constant ranges and report a CS0221. Fixes #33186.
23879 2002-11-24 Martin Baulig <martin@ximian.com>
23881 * cs-parser.jay: Make this work for uninitialized variable
23882 declarations in the `for' initializer. Fixes #32416.
23884 2002-11-24 Martin Baulig <martin@ximian.com>
23886 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23887 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23889 2002-11-24 Martin Baulig <martin@ximian.com>
23891 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23892 argument; if true, we also check for user-defined conversions.
23893 This is only needed if both arguments are of a user-defined type.
23894 Fixes #30443, added test-175.cs.
23895 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23897 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23899 2002-11-24 Martin Baulig <martin@ximian.com>
23901 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23902 function to get the store opcode.
23903 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23904 only emit the Ldelema if the store opcode is Stobj. You must run
23905 both test-34 and test-167 to test this. Fixes #34529.
23907 2002-11-23 Martin Baulig <martin@ximian.com>
23909 * ecore.cs (Expression.MemberLookup): Added additional
23910 `qualifier_type' argument which is used when we're being called
23911 from MemberAccess.DoResolve() and null if we're called from a
23913 (Expression.MemberLookupFailed): New method to report errors; this
23914 does the CS1540 check and reports the correct error message.
23916 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23917 argument for the CS1540 check and redone the way how we're dealing
23918 with private members. See the comment in the source code for details.
23919 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23920 `closure_start_type' to `closure_qualifier_type' and check whether
23921 it's not null. It was not this filter being broken, it was just
23922 being called with the wrong arguments.
23924 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23925 and pass it the correct `qualifier_type'; this also does the error
23928 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23930 * expression.cs (Invocation.EmitParams): If the we are dealing
23931 with a non-built-in value type, load its address as well.
23933 (ArrayCreation): Use a a pretty constant instead
23934 of the hardcoded value 2. Use 6 instead of 2 for the number of
23935 static initializers.
23937 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23938 because they are not really value types, just glorified integers.
23940 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23942 * ecore.cs: Remove redundant code for enumerations, make them use
23943 the same code path as everything else, fixes the casting issue
23944 with enumerations in Windows.Forms.
23946 * attribute.cs: Do only cast to string if it is a string, the
23947 validation happens later.
23949 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23950 people upgrade their corlibs.
23952 * ecore.cs: Oops, enumerations were not following the entire code path
23954 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23956 * typemanager.cs (FilterWithClosure): Commented out the test for
23957 1540 in typemanager.cs, as it has problems when accessing
23958 protected methods from a parent class (see test-174.cs).
23960 * attribute.cs (Attribute.ValidateGuid): new method.
23961 (Attribute.Resolve): Use above.
23963 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23965 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23967 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23968 handling for enumerations, as we only needed the TypeContainer
23969 functionality to begin with (this is required for the fix below to
23970 work for enums that reference constants in a container class for
23973 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23975 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23976 a valid TypeBuilder to perform lookups on.o
23978 * class.cs (InheritableMemberSignatureCompare): Use true in the
23979 call to GetGetMethod and GetSetMethod, because we are comparing
23980 the signature, and we need to get the methods *even* if they are
23983 (PropertyBase.CheckBase): ditto.
23985 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23986 GotoCase.Resolve): Use Peel on EmpytCasts.
23988 * ecore.cs (EmptyCast): drop child, add Peel method.
23990 2002-11-17 Martin Baulig <martin@ximian.com>
23992 * ecore.cs (EmptyCast.Child): New public property.
23994 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23995 label resolved to an EmptyCast. Fixes #34162.
23996 (GotoCase.Resolve): Likewise.
23997 (Block.EmitMeta): Likewise.
23999 2002-11-17 Martin Baulig <martin@ximian.com>
24001 * expression.cs (Invocation.BetterConversion): Prefer int over
24002 uint; short over ushort; long over ulong for integer literals.
24003 Use ImplicitConversionExists instead of StandardConversionExists
24004 since we also need to check for user-defined implicit conversions.
24005 Fixes #34165. Added test-173.cs.
24007 2002-11-16 Martin Baulig <martin@ximian.com>
24009 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
24010 with the `true' and `false' literals. Fixes #33151.
24012 2002-11-16 Martin Baulig <martin@ximian.com>
24014 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
24015 October 22nd; don't do the cs1540 check for static members.
24017 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
24018 now using our own filter here and doing the cs1540 check again.
24020 2002-11-16 Martin Baulig <martin@ximian.com>
24022 * support.cs (InternalParameters): Don't crash if we don't have
24023 any fixed parameters. Fixes #33532.
24025 2002-11-16 Martin Baulig <martin@ximian.com>
24027 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
24028 when looking up static methods to make this work on Windows.
24031 2002-11-16 Martin Baulig <martin@ximian.com>
24033 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
24034 a setter rather than using PropertyInfo.CanWrite.
24036 2002-11-15 Nick Drochak <ndrochak@gol.com>
24038 * class.cs: Allow acces to block member by subclasses. Fixes build
24041 2002-11-14 Martin Baulig <martin@ximian.com>
24043 * class.cs (Constructor.Emit): Added the extern/block check.
24046 2002-11-14 Martin Baulig <martin@ximian.com>
24048 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
24049 iteration while looking for indexers, this is needed because the
24050 indexer may have a different name in our base classes. Fixed the
24051 error reporting (no indexers at all, not get accessor, no
24052 overloaded match). Fixes bug #33089.
24053 (IndexerAccess.DoResolveLValue): Likewise.
24055 2002-11-14 Martin Baulig <martin@ximian.com>
24057 * class.cs (PropertyBase.CheckBase): Make this work for multiple
24058 indexers. Fixes the first part of bug #33089.
24059 (MethodSignature.InheritableMemberSignatureCompare): Added support
24062 2002-11-13 Ravi Pratap <ravi@ximian.com>
24064 * attribute.cs (Attribute.Resolve): Catch the
24065 NullReferenceException and report it since it isn't supposed to
24068 2002-11-12 Miguel de Icaza <miguel@ximian.com>
24070 * expression.cs (Binary.EmitBranchable): Also handle the cases for
24071 LogicalOr and LogicalAnd that can benefit from recursively
24072 handling EmitBranchable. The code now should be nice for Paolo.
24074 2002-11-08 Miguel de Icaza <miguel@ximian.com>
24076 * typemanager.cs (LookupType): Added a negative-hit hashtable for
24077 the Type lookups, as we perform quite a number of lookups on
24078 non-Types. This can be removed once we can deterministically tell
24079 whether we have a type or a namespace in advance.
24081 But this might require special hacks from our corlib.
24085 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
24086 and double which avoids a conversion from an integer to a double.
24088 * expression.cs: tiny optimization, avoid calling IsConstant,
24089 because it effectively performs the lookup twice.
24091 2002-11-06 Miguel de Icaza <miguel@ximian.com>
24093 But a bogus return here to keep the semantics of the old code
24094 until the Mono runtime is fixed.
24096 * pending.cs (GetMissingInterfaces): New method used to remove all
24097 the interfaces that are already implemented by our parent
24098 classes from the list of pending methods.
24100 * interface.cs: Add checks for calls after ResolveTypeExpr.
24102 2002-11-05 Miguel de Icaza <miguel@ximian.com>
24104 * class.cs (Class.Emit): Report warning 67: event not used if the
24105 warning level is beyond 3.
24107 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
24108 being a NullLiteral.
24110 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
24113 * class.cs (TypeContainer.GetClassBases): Cover a missing code
24114 path that might fail if a type can not be resolved.
24116 * expression.cs (Binary.Emit): Emit unsigned versions of the
24119 * driver.cs: use error 5.
24121 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
24123 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
24125 2002-11-01 Miguel de Icaza <miguel@ximian.com>
24127 * cs-parser.jay (switch_section): A beautiful patch from Martin
24128 Baulig that fixed 33094.
24130 2002-10-31 Miguel de Icaza <miguel@ximian.com>
24132 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
24133 Check whether the base is abstract and report an error if so.
24135 * expression.cs (IndexerAccess.DoResolveLValue,
24136 IndexerAccess.DoResolve): ditto.
24138 (Invocation.DoResolve): ditto.
24140 (Invocation.FullMethodDesc): Improve the report string.
24142 * statement.cs (Block): Eliminate IsVariableDefined as it is
24143 basically just a wrapper for GetVariableInfo.
24145 * ecore.cs (SimpleName): Use new
24147 * support.cs (ReflectionParamter.ParameterType): We unwrap the
24148 type, as we return the actual parameter ref/unref state on a
24151 2002-10-30 Miguel de Icaza <miguel@ximian.com>
24153 * support.cs: Return proper flags REF/OUT fixing the previous
24156 * expression.cs: Reverted last patch, that was wrong. Is_ref is
24157 not used to mean `ref' but `ref or out' in ParameterReference
24159 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
24160 full type signature instead of calling TypeManger.CSharpName
24163 * support.cs (InternalParameters.ParameterDesc): Do not compare
24164 directly to the modflags, because REF/OUT will actually be bitsets
24167 * delegate.cs (VerifyMethod): Check also the modifiers.
24169 * cs-tokenizer.cs: Fix bug where floating point values with an
24170 exponent where a sign was missing was ignored.
24172 * driver.cs: Allow multiple assemblies to be specified in a single
24175 2002-10-28 Miguel de Icaza <miguel@ximian.com>
24177 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
24178 because identifiers after a parenthesis would end up in this kind
24179 of production, and we needed to desamiguate it for having casts
24182 (UserDefinedType *) xxx
24184 2002-10-24 Miguel de Icaza <miguel@ximian.com>
24186 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
24187 we should set on the Bindingflags.NonPublic, but not turn on
24188 private_ok. private_ok controls whether a Private member is
24189 returned (this is chekced on the filter routine), while the
24190 BindingFlags.NonPublic just controls whether private/protected
24191 will be allowed. This fixes the problem part of the problem of
24192 private properties being allowed to be used in derived classes.
24194 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
24195 so we can call the children DoResolveLValue method (this will
24196 properly signal errors on lvalue assignments to base properties)
24198 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
24199 getter are null, and we have a property info, we know that this
24200 happened because the lookup failed, so we report an error 122 for
24201 protection level violation.
24203 We also silently return if setter and getter are null in the
24204 resolve functions, this condition only happens if we have flagged
24205 the error before. This is the other half of the problem.
24207 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
24208 not have accessibility information, that is why we were returning
24209 true in the filter function in typemanager.cs.
24211 To properly report 122 (property is inaccessible because of its
24212 protection level) correctly, we report this error in ResolveAccess
24213 by failing if both the setter and the getter are lacking (ie, the
24216 DoResolve and DoLResolve have been modified to check for both
24217 setter/getter being null and returning silently, the reason being
24218 that I did not want to put the knowledge about this error in upper
24221 int old = Report.Errors;
24222 x = new PropertyExpr (...);
24223 if (old != Report.Errors)
24228 So the property expr is returned, but it is invalid, so the error
24229 will be flagged during the resolve process.
24231 * class.cs: Remove InheritablePropertySignatureCompare from the
24232 class, as we no longer depend on the property signature to compute
24233 whether it is possible to implement a method or not.
24235 The reason is that calling PropertyInfo.GetGetMethod will return
24236 null (in .NET, in Mono it works, and we should change this), in
24237 cases where the Get Method does not exist in that particular
24242 class X { public virtual int A { get { return 1; } } }
24244 class Z : Y { public override int A { get { return 2; } } }
24246 Would fail in Z because the parent (Y) would not have the property
24247 defined. So we avoid this completely now (because the alternative
24248 fix was ugly and slow), and we now depend exclusively on the
24251 (PropertyBase.CheckBase): Use a method-base mechanism to find our
24252 reference method, instead of using the property.
24254 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
24255 routines are gone now.
24257 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
24258 names, they were incorrectly named.
24260 * cs-tokenizer.cs: Return are more gentle token on failure.
24262 * pending.cs (PendingImplementation.InterfaceMethod): This routine
24263 had an out-of-sync index variable, which caused it to remove from
24264 the list of pending methods the wrong method sometimes.
24266 2002-10-22 Miguel de Icaza <miguel@ximian.com>
24268 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
24269 CanWrite, because those refer to this particular instance of the
24270 property, and do not take into account the fact that we can
24271 override single members of a property.
24273 Constructor requires an EmitContext. The resolution process does
24274 not happen here, but we need to compute the accessors before,
24275 because the resolution does not always happen for properties.
24277 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
24278 subclass, before we did not update this flag, but we did update
24281 (GetAccessors): Drop this routine, as it did not work in the
24282 presence of partially overwritten set/get methods.
24284 Notice that this broke the cs1540 detection, but that will require
24287 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24291 * driver.cs: issue a warning instead of an error if we don't support
24292 debugging for the platform. Also ignore a couple of errors that may
24293 arise when trying to write the symbols. Undo my previous patch.
24295 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24297 * driver.cs: ignore /debug switch except for Unix platforms.
24299 2002-10-23 Nick Drochak <ndrochak@gol.com>
24301 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24303 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24305 * driver.cs: Do not make mcs-debug conditional, so we do not break
24306 builds that use it.
24308 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24309 review this patch. But basically after all the children variables
24310 have been merged, the value of "Breaks" was not being set to
24311 new_breaks for Switch blocks. I think that it should be set after
24312 it has executed. Currently I set this to the value of new_breaks,
24313 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24314 conservative, but I do not understand this code very well.
24316 I did not break anything in the build, so that is good ;-)
24318 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24320 2002-10-20 Mark Crichton <crichton@gimp.org>
24322 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24324 2002-10-20 Nick Drochak <ndrochak@gol.com>
24326 * cfold.cs: Fixed compile blocker.
24328 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24330 * driver.cs: I was chekcing the key, not the file.
24332 2002-10-19 Ravi Pratap <ravi@ximian.com>
24334 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24335 message that we were generating - we just need to silently return
24338 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24340 * class.cs (Event.Define): Change my previous commit, as this
24341 breaks the debugger. This is a temporary hack, as it seems like
24342 the compiler is generating events incorrectly to begin with.
24344 * expression.cs (Binary.ResolveOperator): Added support for
24345 "U operator - (E x, E y)"
24347 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24350 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24351 init-only variables, but this path did not take into account that
24352 there might be also instance readonly variables. Correct this
24355 This fixes bug 32253
24357 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24360 * driver.cs: Change the extension for modules to `netmodule'
24362 * cs-parser.jay: Improved slightly the location tracking for
24363 the debugger symbols.
24365 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24366 modifiers that were specified instead of the hardcoded value
24367 (FamAndAssem). This was basically ignoring the static modifier,
24368 and others. Fixes 32429.
24370 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24371 fixed a bug in the process (32476)
24373 * expression.cs (ArrayAccess.EmitAssign): Patch from
24374 hwang_rob@yahoo.ca that fixes bug 31834.3
24376 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24378 * driver.cs: Make the module extension .netmodule.
24380 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24382 * driver.cs: Report an error if the resource file is not found
24383 instead of crashing.
24385 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24386 false, like Emit does.
24388 2002-10-16 Nick Drochak <ndrochak@gol.com>
24390 * typemanager.cs: Remove unused private member. Also reported mcs
24391 bug to report this as a warning like csc.
24393 2002-10-15 Martin Baulig <martin@gnome.org>
24395 * statement.cs (Statement.Emit): Made this a virtual method; emits
24396 the line number info and calls DoEmit().
24397 (Statement.DoEmit): New protected abstract method, formerly knows
24398 as Statement.Emit().
24400 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24402 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24404 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24405 have fixed a remaining problem: not every AddXXXX was adding a
24406 fully qualified name.
24408 Now everyone registers a fully qualified name in the DeclSpace as
24409 being defined instead of the partial name.
24411 Downsides: we are slower than we need to be due to the excess
24412 copies and the names being registered this way.
24414 The reason for this is that we currently depend (on the corlib
24415 bootstrap for instance) that types are fully qualified, because
24416 we dump all the types in the namespace, and we should really have
24417 types inserted into the proper namespace, so we can only store the
24418 basenames in the defined_names array.
24420 2002-10-10 Martin Baulig <martin@gnome.org>
24422 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24423 from bug #31834, see the bug report for a testcase which is
24426 2002-10-10 Martin Baulig <martin@gnome.org>
24428 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24429 flow analysis code for this.
24431 * statement.cs (Do, While, For): Tell the flow analysis code about
24433 (FlowBranching.UsageVector): Added support for infinite loops.
24434 (Block.Resolve): Moved the dead code elimination here and use flow
24437 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24439 * class.cs (Field.Define): Catch cycles on struct type
24442 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24443 fields if the fields are static. We only need to check instance
24446 * expression.cs (As.DoResolve): Test for reference type.
24448 * statement.cs (Using.ResolveExpression): Use
24449 ConvertImplicitRequired, not ConvertImplicit which reports an
24451 (Using.ResolveLocalVariableDecls): ditto.
24453 * expression.cs (Binary.ResolveOperator): Report errors in a few
24454 places where we had to.
24456 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24458 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24460 * expression.cs: Use StoreFromPtr instead of extracting the type
24461 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24463 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24464 an enumeration value to a System.Enum, but System.Enum is not a
24465 value type, but an class type, so we need to box.
24467 (Expression.ConvertExplicit): One codepath could return
24468 errors but not flag them. Fix this. Fixes #31853
24470 * parameter.cs (Resolve): Do not allow void as a parameter type.
24472 2002-10-06 Martin Baulig <martin@gnome.org>
24474 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24475 if it's a class type and not a struct. Fixes #31815.
24477 2002-10-06 Martin Baulig <martin@gnome.org>
24479 * statement.cs: Reworked the flow analysis code a bit to make it
24480 usable for dead code elimination.
24482 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24484 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24486 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24488 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24489 to fix the test 165, will investigate deeper.
24491 2002-10-04 Martin Baulig <martin@gnome.org>
24493 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24494 finally blocks actually work.
24495 (Try.Resolve): We don't need to create a sibling for `finally' if
24496 there is no finally block.
24498 2002-10-04 Martin Baulig <martin@gnome.org>
24500 * class.cs (Constructor.Define): The default accessibility for a
24501 non-default constructor is private, not public.
24503 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24505 * class.cs (Constructor): Make AllowedModifiers public, add
24508 * cs-parser.jay: Perform the modifiers test here, as the
24509 constructor for the Constructor class usually receives a zero
24510 because of the way we create it (first we create, later we
24511 customize, and we were never checking the modifiers).
24513 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24514 is a version of LookupTypeReflection that includes the type-name
24515 cache. This can be used as a fast path for functions that know
24516 the fully qualified name and are only calling into *.GetType() to
24517 obtain a composed type.
24519 This is also used by TypeManager.LookupType during its type
24522 (LookupType): We now also track the real type name, as sometimes
24523 we can get a quey for the real type name from things like
24524 ComposedCast. This fixes bug 31422.
24526 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24527 complete type fullname, it does not have to go through the type
24528 resolution system to obtain the composed version of the type (for
24529 obtaining arrays or pointers).
24531 (Conditional.Emit): Use the EmitBoolExpression to
24532 generate nicer code, as requested by Paolo.
24534 (ArrayCreation.CheckIndices): Use the patch from
24535 hwang_rob@yahoo.ca to validate the array initializers.
24537 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24539 * class.cs (ConstructorInitializer.Emit): simplify code by using
24540 Invocation.EmitCall, and at the same time, fix the bugs in calling
24541 parent constructors that took variable arguments.
24543 * ecore.cs (Expression.ConvertNumericExplicit,
24544 Expression.ImplicitNumericConversion): Remove the code that
24545 manually wrapped decimal (InternalTypeConstructor call is now gone
24548 * expression.cs (Cast.TryReduce): Also handle decimal types when
24549 trying to perform a constant fold on the type.
24551 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24553 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24554 that only turned off an error report, and did nothing else.
24556 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24558 * driver.cs: Handle and ignore /fullpaths
24560 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24562 * expression.cs (Binary.ResolveOperator): Catch the case where
24563 DoNumericPromotions returns true,
24565 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24567 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24569 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24572 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24574 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24575 conversion exists, but it is also required that the conversion be
24576 performed. This manifested in "(Type64Enum) 2".
24578 * class.cs (TypeManager.AddMethod): The fix is not to change
24579 AddEnum, because that one was using a fully qualified name (every
24580 DeclSpace derivative does), but to change the AddMethod routine
24581 that was using an un-namespaced name. This now correctly reports
24582 the duplicated name.
24584 Revert patch until I can properly fix it. The issue
24585 is that we have a shared Type space across all namespaces
24586 currently, which is wrong.
24588 Options include making the Namespace a DeclSpace, and merge
24589 current_namespace/current_container in the parser.
24591 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24593 * cs-parser.jay: Improve error reporting when we get a different
24594 kind of expression in local_variable_type and
24595 local_variable_pointer_type.
24597 Propagate this to avoid missleading errors being reported.
24599 * ecore.cs (ImplicitReferenceConversion): treat
24600 TypeManager.value_type as a target just like object_type. As
24605 Is valid, and needs to result in the int 1 being boxed before it
24606 is assigned to the value type v.
24608 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24609 to validate the enumeration name.
24611 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24612 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24613 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24615 * ecore.cs (TryImplicitIntConversion): When doing an
24616 implicit-enumeration-conversion, check if the type is 64-bits and
24617 perform a conversion before passing to EnumConstant.
24619 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24621 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24622 report ambiguous type references. Unlike the MS version, we
24623 report what the ambiguity is. Innovation at work ;-)
24625 (DeclSpace.FindType): Require a location argument to
24626 display when we display an ambiguous error.
24628 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24630 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24632 * expression.cs (EmitDynamicInitializers): Apply patch from
24633 hwang_rob@yahoo.ca that fixes the order in which we emit our
24636 2002-09-21 Martin Baulig <martin@gnome.org>
24638 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24639 delegate takes no arguments.
24641 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24643 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24646 * expression.cs: Extract the underlying type.
24648 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24650 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24652 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24654 * class.cs (TypeContainer.DefineType): We can not use the nice
24655 PackingSize with the size set to 1 DefineType method, because it
24656 will not allow us to define the interfaces that the struct
24659 This completes the fixing of bug 27287
24661 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24662 means also structs. This fixes part of the problem.
24663 (Expresion.ImplicitReferenceConversionExists): ditto.
24665 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24666 error if there were no errors reported during the type lookup
24667 process, to avoid duplicates or redundant errors. Without this
24668 you would get an ambiguous errors plus a type not found. We have
24669 beaten the user enough with the first error.
24671 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24674 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24675 during the resolution process, stop the lookup, this avoids
24676 repeated error reports (same error twice).
24678 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24680 * typemanager.cs (LookupType): Redo the type lookup code to match
24681 the needs of System.Reflection.
24683 The issue is that System.Reflection requires references to nested
24684 types to begin with a "+" sign instead of a dot. So toplevel
24685 types look like: "NameSpace.TopLevelClass", and nested ones look
24686 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24689 2002-09-19 Martin Baulig <martin@gnome.org>
24691 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24692 says that a method always returns or always throws an exception,
24693 don't report the CS0161.
24695 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24696 set `Returns = new_returns'.
24698 2002-09-19 Martin Baulig <martin@gnome.org>
24700 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24701 to an enum constant, check for a CS0176.
24703 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24705 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24706 for operators that must be in pairs and report errors.
24708 * ecore.cs (SimpleName.DoResolveType): During the initial type
24709 resolution process, when we define types recursively, we must
24710 check first for types in our current scope before we perform
24711 lookups in the enclosing scopes.
24713 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24715 (Invocation.VerifyArgumentsCompat): Call
24716 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24717 I thought we were supposed to always call this, but there are a
24718 few places in the code where we dont do it.
24720 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24722 * driver.cs: Add support in -linkres and -resource to specify the
24723 name of the identifier.
24725 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24727 * ecore.cs (StandardConversionExists): Sync with the conversion
24728 code: allow anything-* to void* conversions.
24730 (FindMostSpecificSource): Use an Expression argument
24731 instead of a Type, because we might be handed over a Literal which
24732 gets a few more implicit conversions that plain types do not. So
24733 this information was being lost.
24735 Also, we drop the temporary type-holder expression when not
24738 2002-09-17 Martin Baulig <martin@gnome.org>
24740 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24741 this is an explicit interface implementation.
24743 2002-09-17 Martin Baulig <martin@gnome.org>
24745 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24746 different `IndexerName' attributes.
24748 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24749 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24750 virtual CommonResolve().
24752 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24754 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24755 and convert that to the UnderlyingType.
24757 * statement.cs (Foreach.Resolve): Indexers are just like variables
24758 or PropertyAccesses.
24760 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24761 inside quoted strings, we were not doing this before.
24763 2002-09-16 Martin Baulig <martin@gnome.org>
24765 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24766 resolve it. This is needed for the definite assignment check of the
24767 instance expression, fixes bug #29846.
24768 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24770 2002-09-16 Nick Drochak <ndrochak@gol.com>
24772 * parameter.cs: Fix compile error. Cannot reference static member
24773 from an instance object. Is this an mcs bug?
24775 2002-09-14 Martin Baulig <martin@gnome.org>
24777 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24778 multiple times. Fixes bug #30295, added test-166.cs.
24780 2002-09-14 Martin Baulig <martin@gnome.org>
24782 * statement.cs (Block.Emit): Don't emit unreachable code.
24783 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24784 `break' statements.
24785 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24787 2002-09-14 Martin Baulig <martin@gnome.org>
24789 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24792 2002-09-14 Martin Baulig <martin@gnome.org>
24794 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24795 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24796 be false on the ms runtime.
24798 2002-09-13 Martin Baulig <martin@gnome.org>
24800 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24801 the CS0038 error message.
24803 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24805 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24806 constant inside, return it.
24808 2002-09-12 Martin Baulig <martin@gnome.org>
24810 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24811 implicit conversion can be done between enum types.
24813 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24814 check whether an implicit conversion to the current enum's UnderlyingType
24815 exists and report an error if not.
24817 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24818 without debugging support.
24820 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24821 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24823 2002-09-12 Martin Baulig <martin@gnome.org>
24825 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24827 * ecore.cs (IMemberExpr.DeclaringType): New property.
24828 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24829 nonstatic member of an outer type (CS0038).
24831 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24833 * driver.cs: Activate the using-error detector at warning level
24834 4 (at least for MS-compatible APIs).
24836 * namespace.cs (VerifyUsing): Small buglett fix.
24838 * pending.cs (PendingImplementation): pass the container pointer.
24840 * interface.cs (GetMethods): Allow for recursive definition. Long
24841 term, I would like to move every type to support recursive
24842 definitions, not the current ordering mechanism that we have right
24845 The situation is this: Attributes are handled before interfaces,
24846 so we can apply attributes to interfaces. But some attributes
24847 implement interfaces, we will now handle the simple cases
24848 (recursive definitions will just get an error).
24850 * parameter.cs: Only invalidate types at the end if we fail to
24853 2002-09-09 Martin Baulig <martin@gnome.org>
24855 * ecore.cs (PropertyExpr.Emit): Also check for
24856 TypeManager.system_int_array_get_length so this'll also work when
24857 compiling corlib. Fixes #30003.
24859 2002-09-09 Martin Baulig <martin@gnome.org>
24861 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24862 and throw an exception if we can't get the type's size. Fixed #30040,
24865 2002-09-09 Martin Baulig <martin@gnome.org>
24867 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24869 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24870 context. Fixes bug #30027.
24872 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24873 virtual functions. Fixes bug #30043, added test-164.cs.
24875 2002-09-08 Ravi Pratap <ravi@ximian.com>
24877 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24879 2002-09-08 Nick Drochak <ndrochak@gol.com>
24881 * driver.cs: Use an object to get the windows codepage since it's not a
24884 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24886 * statement.cs (For.Emit): for infinite loops (test == null)
24887 return whether there is a break inside, not always "true".
24889 * namespace.cs (UsingEntry): New struct to hold the name of the
24890 using definition, the location where it is defined, and whether it
24891 has been used in a successful type lookup.
24893 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24898 2002-09-06 Ravi Pratap <ravi@ximian.com>
24900 * attribute.cs : Fix incorrect code which relied on catching
24901 a NullReferenceException to detect a null being passed in
24902 where an object was expected.
24904 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24906 * statement.cs (Try): flag the catch variable as assigned
24908 * expression.cs (Cast): Simplified by using ResolveType instead of
24909 manually resolving.
24911 * statement.cs (Catch): Fix bug by using ResolveType.
24913 2002-09-06 Ravi Pratap <ravi@ximian.com>
24915 * expression.cs (BetterConversion): Special case for when we have
24916 a NullLiteral as the argument and we have to choose between string
24917 and object types - we choose string the way csc does.
24919 * attribute.cs (Attribute.Resolve): Catch the
24920 NullReferenceException and report error #182 since the Mono
24921 runtime no more has the bug and having this exception raised means
24922 we tried to select a constructor which takes an object and is
24925 2002-09-05 Ravi Pratap <ravi@ximian.com>
24927 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24928 message (1502, 1503) when we can't locate a method after overload
24929 resolution. This is much more informative and closes the bug
24932 * interface.cs (PopulateMethod): Return if there are no argument
24933 types. Fixes a NullReferenceException bug.
24935 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24936 expressions too. Previously we were checking only in one place for
24937 positional arguments leaving out named arguments.
24939 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24940 type to the enum type is not allowed. Remove code corresponding to
24943 (ConvertNumericExplicit): Allow explicit conversions from
24944 the underlying type to enum type. This precisely follows the spec
24945 and closes a bug filed by Gonzalo.
24947 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24950 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24952 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24954 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24955 it was important that we stored the right value after the
24956 reduction in `converted'.
24958 2002-09-04 Martin Baulig <martin@gnome.org>
24960 * location.cs (Location.SymbolDocument): Use full pathnames for the
24963 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24965 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24966 of the expression resolve mechanism, because that will catch the
24967 SimpleName error failures.
24969 (Conditional): If we can not resolve the
24970 expression, return, do not crash.
24972 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24975 (location): display token name instead of its number.
24977 2002-08-28 Martin Baulig <martin@gnome.org>
24979 * expression.cs (Binary.ResolveOperator): Don't silently return
24980 but return an error if an operator cannot be applied between two
24983 2002-08-28 Martin Baulig <martin@gnome.org>
24985 * class.cs (Constructor.Define): Set the permission attributes
24986 correctly instead of making all constructors public.
24988 2002-08-28 Martin Baulig <martin@gnome.org>
24990 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24991 for private members before reporting a CS0103; if we find anything,
24994 2002-08-28 Martin Baulig <martin@gnome.org>
24996 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24997 to check whether `closure_start_type == closure_invocation_type',
24998 we also need to check whether `m.DeclaringType == closure_invocation_type'
24999 before bypassing the permission checks. We might be accessing
25000 protected/private members from the base class.
25001 (TypeManager.RealMemberLookup): Only set private_ok if private
25002 members were requested via BindingFlags.NonPublic.
25004 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
25006 * expression.cs (MemberAccess.ResolveMemberAccess): Set
25007 MethodGroupExpr.IsExplicitImpl if appropriate.
25008 (Invocation.DoResolve): Don't report the CS0120 for explicit
25009 interface implementations.
25011 2002-08-27 Martin Baulig <martin@gnome.org>
25013 * expression.cs (Invocation.DoResolve): If this is a static
25014 method and we don't have an InstanceExpression, we must report
25017 2002-08-25 Martin Baulig <martin@gnome.org>
25019 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
25020 `==' between a valuetype and an object.
25022 2002-08-25 Miguel de Icaza <miguel@ximian.com>
25024 * ecore.cs (TypeExpr): Provide a ToString method.
25026 2002-08-24 Martin Baulig <martin@gnome.org>
25028 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
25029 now called proggie.dbg and it's a binary file.
25031 2002-08-23 Martin Baulig <martin@gnome.org>
25033 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
25035 2002-08-23 Martin Baulig <martin@gnome.org>
25037 * struct.cs (MyStructInfo.ctor): Make this work with empty
25038 structs; it's not allowed to use foreach() on null.
25040 2002-08-23 Martin Baulig <martin@gnome.org>
25042 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
25043 writer the full pathname of the generated assembly.
25045 2002-08-23 Martin Baulig <martin@gnome.org>
25047 * statements.cs (FlowBranching.UsageVector.MergeChildren):
25048 A `finally' block never returns or breaks; improved handling of
25051 2002-08-23 Martin Baulig <martin@gnome.org>
25053 * statement.cs (Throw.Resolve): Allow `throw null'.
25055 2002-08-23 Martin Baulig <martin@gnome.org>
25057 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
25058 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
25059 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
25060 MemberLookup would return a wrong event if this is an explicit
25061 interface implementation and the class has an event with the same
25064 2002-08-23 Martin Baulig <martin@gnome.org>
25066 * statement.cs (Block.AddChildVariableNames): New public method.
25067 (Block.AddChildVariableName): Likewise.
25068 (Block.IsVariableNameUsedInChildBlock): Likewise.
25069 (Block.AddVariable): Check whether a variable name has already
25070 been used in a child block.
25072 * cs-parser.jay (declare_local_variables): Mark all variable names
25073 from the current block as being used in a child block in the
25076 2002-08-23 Martin Baulig <martin@gnome.org>
25078 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
25079 find the symbol writer.
25081 * driver.cs: csc also allows the arguments to /define being
25082 separated by commas, not only by semicolons.
25084 2002-08-23 Martin Baulig <martin@gnome.org>
25086 * interface.cs (Interface.GetMembers): Added static check for events.
25088 2002-08-15 Martin Baulig <martin@gnome.org>
25090 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
25091 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
25093 * ecore.cs (Expression.MemberLookup): Added documentation and explained
25094 why the MethodData.EmitDestructor() change was necessary.
25096 2002-08-20 Martin Baulig <martin@gnome.org>
25098 * class.cs (TypeContainer.FindMembers): Added static check for events.
25100 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
25102 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
25103 use Type.GetEvents(), not Type.FindMembers().
25105 2002-08-20 Martin Baulig <martin@gnome.org>
25107 * decl.cs (MemberCache): Added a special method cache which will
25108 be used for method-only searched. This ensures that a method
25109 search will return a MethodInfo with the correct ReflectedType for
25112 2002-08-20 Martin Baulig <martin@gnome.org>
25114 * decl.cs (DeclSpace.FindMembers): Made this public.
25116 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25118 * delegate.cs: fixed build on windows.
25119 [FIXME: Filed as bug #29150: MCS must report these errors.]
25121 2002-08-19 Ravi Pratap <ravi@ximian.com>
25123 * ecore.cs (StandardConversionExists): Return a false
25124 if we are trying to convert the void type to anything else
25125 since that is not allowed.
25127 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
25128 we flag error 70 in the event an event is trying to be accessed
25129 directly from outside the declaring type.
25131 2002-08-20 Martin Baulig <martin@gnome.org>
25133 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
25134 MemberCache from typemanager.cs to decl.cs.
25136 2002-08-19 Martin Baulig <martin@gnome.org>
25138 * class.cs (TypeContainer): Implement IMemberContainer.
25139 (TypeContainer.DefineMembers): Create the MemberCache.
25140 (TypeContainer.FindMembers): Do better BindingFlags checking; only
25141 return public members if BindingFlags.Public was given, check
25142 whether members are static.
25144 2002-08-16 Martin Baulig <martin@gnome.org>
25146 * decl.cs (DeclSpace.Define): Splitted this in Define and
25147 DefineMembers. DefineMembers is called first and initializes the
25150 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
25151 DefineMembers() on all our DeclSpaces.
25153 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
25154 but call DefineMembers() on all nested interfaces. We call their
25155 Define() in our new Define() function.
25157 * interface.cs (Interface): Implement IMemberContainer.
25158 (Interface.Define): Moved all code except the attribute stuf to
25160 (Interface.DefineMembers): Initialize the member cache.
25162 * typemanager.cs (IMemberFinder): Removed this interface, we don't
25163 need this anymore since we can use MemberCache.FindMembers directly.
25165 2002-08-19 Martin Baulig <martin@gnome.org>
25167 * typemanager.cs (MemberCache): When creating the cache for an
25168 interface type, add all inherited members.
25169 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
25170 to `out bool used_cache' and documented it.
25171 (TypeManager.MemberLookup): If we already used the cache in the first
25172 iteration, we don't need to do the interfaces check.
25174 2002-08-19 Martin Baulig <martin@gnome.org>
25176 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
25177 here from IMemberFinder and don't implement this interface anymore.
25178 (DeclSpace.MemberCache): Moved here from IMemberFinder.
25180 * typemanager.cs (IMemberFinder): This interface is now only used by
25181 classes which actually support the member cache.
25182 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
25183 since we only put DeclSpaces into this Hashtable.
25184 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
25185 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
25187 2002-08-16 Martin Baulig <martin@gnome.org>
25189 * typemanager.cs (ICachingMemberFinder): Removed.
25190 (IMemberFinder.MemberCache): New property.
25191 (TypeManager.FindMembers): Merged this with RealFindMembers().
25192 This function will never be called from TypeManager.MemberLookup()
25193 so we can't use the cache here, just the IMemberFinder.
25194 (TypeManager.MemberLookup_FindMembers): Check whether the
25195 IMemberFinder has a MemberCache and call the cache's FindMembers
25197 (MemberCache): Rewrote larger parts of this yet another time and
25198 cleaned it up a bit.
25200 2002-08-15 Miguel de Icaza <miguel@ximian.com>
25202 * driver.cs (LoadArgs): Support quoting.
25204 (Usage): Show the CSC-like command line arguments.
25206 Improved a few error messages.
25208 2002-08-15 Martin Baulig <martin@gnome.org>
25210 * typemanager.cs (IMemberContainer.Type): New property.
25211 (IMemberContainer.IsInterface): New property.
25213 The following changes are conditional to BROKEN_RUNTIME, which is
25214 defined at the top of the file.
25216 * typemanager.cs (MemberCache.MemberCache): Don't add the base
25217 class'es members, but add all members from TypeHandle.ObjectType
25218 if we're an interface.
25219 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
25220 is the current type.
25221 (MemberCache.CacheEntry.Container): Removed this field.
25222 (TypeHandle.GetMembers): Include inherited members.
25224 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25226 * typemanager.cs: fixed compilation and added a comment on a field that
25229 2002-08-15 Martin Baulig <martin@gnome.org>
25231 * class.cs (ConstructorInitializer.Resolve): In the
25232 Expression.MemberLookup call, use the queried_type as
25235 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
25236 declared' attribute, it's always true.
25237 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
25238 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
25239 temporary wrapper for FindMembers which tells MemberLookup whether
25240 members from the base classes are included in the return value.
25241 This will go away soon.
25242 (TypeManager.MemberLookup): Use this temporary hack here; once the
25243 new MemberCache is completed, we don't need to do the DeclaredOnly
25244 looping here anymore since the MemberCache will take care of this.
25245 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
25246 (MemberCache): When creating the MemberCache for a class, get
25247 members from the current class and all its base classes.
25248 (MemberCache.CacheEntry.Container): New field. This is a
25249 temporary hack until the Mono runtime is fixed to distinguish
25250 between ReflectedType and DeclaringType. It allows us to use MCS
25251 with both the MS runtime and the unfixed Mono runtime without
25252 problems and without accecting performance.
25253 (MemberCache.SearchMembers): The DeclaredOnly looping from
25254 TypeManager.MemberLookup is now done here.
25256 2002-08-14 Martin Baulig <martin@gnome.org>
25258 * statement.cs (MyStructInfo.MyStructInfo): Don't call
25259 Type.GetFields on dynamic types but get the fields from the
25260 corresponding TypeContainer.
25261 (MyStructInfo.GetStructInfo): Added check for enum types.
25263 * typemanager.cs (MemberList.IsSynchronized): Implemented.
25264 (MemberList.SyncRoot): Implemented.
25265 (TypeManager.FilterWithClosure): No need to check permissions if
25266 closure_start_type == closure_invocation_type, don't crash if
25267 closure_invocation_type is null.
25269 2002-08-13 Martin Baulig <martin@gnome.org>
25271 Rewrote TypeContainer.FindMembers to use a member cache. This
25272 gives us a speed increase of about 35% for the self-hosting MCS
25273 build and of about 15-20% for the class libs (both on GNU/Linux).
25275 * report.cs (Timer): New class to get enhanced profiling. This
25276 whole class is "TIMER" conditional since it remarkably slows down
25279 * class.cs (MemberList): New class. This is an IList wrapper
25280 which we're now using instead of passing MemberInfo[]'s around to
25281 avoid copying this array unnecessarily.
25282 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
25283 (ICachingMemberFinder, IMemberContainer): New interface.
25284 (TypeManager.FilterWithClosure): If `criteria' is null, the name
25285 has already been checked, otherwise use it for the name comparision.
25286 (TypeManager.FindMembers): Renamed to RealMemberFinder and
25287 provided wrapper which tries to use ICachingMemberFinder.FindMembers
25288 if possible. Returns a MemberList, not a MemberInfo [].
25289 (TypeHandle): New class, implements IMemberContainer. We create
25290 one instance of this class per type, it contains a MemberCache
25291 which is used to do the member lookups.
25292 (MemberCache): New class. Each instance of this class contains
25293 all members of a type and a name-based hash table.
25294 (MemberCache.FindMembers): This is our new member lookup
25295 function. First, it looks up all members of the requested name in
25296 the hash table. Then, it walks this list and sorts out all
25297 applicable members and returns them.
25299 2002-08-13 Martin Baulig <martin@gnome.org>
25301 In addition to a nice code cleanup, this gives us a performance
25302 increase of about 1.4% on GNU/Linux - not much, but it's already
25303 half a second for the self-hosting MCS compilation.
25305 * typemanager.cs (IMemberFinder): New interface. It is used by
25306 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25307 Enum, Delegate or Interface.
25308 (TypeManager.finder_to_member_finder): New PtrHashtable.
25309 (TypeManager.finder_to_container): Removed.
25310 (TypeManager.finder_to_delegate): Removed.
25311 (TypeManager.finder_to_interface): Removed.
25312 (TypeManager.finder_to_enum): Removed.
25314 * interface.cs (Interface): Implement IMemberFinder.
25316 * delegate.cs (Delegate): Implement IMemberFinder.
25318 * enum.cs (Enum): Implement IMemberFinder.
25320 * class.cs (TypeContainer): Implement IMemberFinder.
25322 2002-08-12 Martin Baulig <martin@gnome.org>
25324 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25326 2002-08-12 Martin Baulig <martin@gnome.org>
25328 * ecore.cs (ITypeExpression): New interface for expressions which
25330 (TypeExpression): Renamed to TypeLookupExpression.
25331 (Expression.DoResolve): If we're doing a types-only lookup, the
25332 expression must implement the ITypeExpression interface and we
25333 call DoResolveType() on it.
25334 (SimpleName): Implement the new ITypeExpression interface.
25335 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25336 hack, the situation that we're only looking up types can't happen
25337 anymore when this method is called. Moved the type lookup code to
25338 DoResolveType() and call it.
25339 (SimpleName.DoResolveType): This ITypeExpression interface method
25340 is now doing the types-only lookup.
25341 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25342 (ResolveFlags): Added MaskExprClass.
25344 * expression.cs (MemberAccess): Implement the ITypeExpression
25346 (MemberAccess.DoResolve): Added support for a types-only lookup
25347 when we're called via ITypeExpression.DoResolveType().
25348 (ComposedCast): Implement the ITypeExpression interface.
25350 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25351 Expression.Resolve() with ResolveFlags.Type instead.
25353 2002-08-12 Martin Baulig <martin@gnome.org>
25355 * interface.cs (Interface.Define): Apply attributes.
25357 * attribute.cs (Attribute.ApplyAttributes): Added support for
25358 interface attributes.
25360 2002-08-11 Martin Baulig <martin@gnome.org>
25362 * statement.cs (Block.Emit): Only check the "this" variable if we
25363 do not always throw an exception.
25365 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25366 whether the property has a set accessor.
25368 2002-08-11 Martin Baulig <martin@gnome.org>
25370 Added control flow analysis support for structs.
25372 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25373 with control flow analysis turned off.
25374 (IVariable): New interface.
25375 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25376 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25377 (FieldExpr.DoResolve): Resolve the instance expression with flow
25378 analysis turned off and do the definite assignment check after the
25379 resolving when we know what the expression will resolve to.
25381 * expression.cs (LocalVariableReference, ParameterReference):
25382 Implement the new IVariable interface, only call the flow analysis
25383 code if ec.DoFlowAnalysis is true.
25384 (This): Added constructor which takes a Block argument. Implement
25385 the new IVariable interface.
25386 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25387 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25388 This does the definite assignment checks for struct members.
25390 * class.cs (Constructor.Emit): If this is a non-static `struct'
25391 constructor which doesn't have any initializer, call
25392 Block.AddThisVariable() to tell the flow analysis code that all
25393 struct elements must be initialized before control returns from
25396 * statement.cs (MyStructInfo): New public class.
25397 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25398 argument to this indexer. If non-zero, check an individual struct
25399 member, not the whole struct.
25400 (FlowBranching.CheckOutParameters): Check struct members.
25401 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25402 overloaded versions of these methods which take an additional
25403 `int field_idx' argument to check struct members.
25404 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25405 overloaded versions of these methods which take an additional
25406 `string field_name' argument to check struct member.s
25407 (VariableInfo): Implement the IVariable interface.
25408 (VariableInfo.StructInfo): New public property. Returns the
25409 MyStructInfo instance of the variable if it's a struct or null.
25410 (Block.AddThisVariable): New public method. This is called from
25411 Constructor.Emit() for non-static `struct' constructor which do
25412 not have any initializer. It creates a special variable for the
25413 "this" instance variable which will be checked by the flow
25414 analysis code to ensure that all of the struct's fields are
25415 initialized before control returns from the constructor.
25416 (UsageVector): Added support for struct members. If a
25417 variable/parameter is a struct with N members, we reserve a slot
25418 in the usage vector for each member. A struct is considered fully
25419 initialized if either the struct itself (slot 0) or all its
25420 members are initialized.
25422 2002-08-08 Martin Baulig <martin@gnome.org>
25424 * driver.cs (Driver.MainDriver): Only report an error CS5001
25425 if there were no compilation errors.
25427 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25428 `UnsafeContext' property to determine whether the parent is in
25429 unsafe context rather than checking the parent's ModFlags:
25430 classes nested in an unsafe class are unsafe as well.
25432 2002-08-08 Martin Baulig <martin@gnome.org>
25434 * statement.cs (UsageVector.MergeChildren): Distinguish between
25435 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25436 we return. Added test17() and test18() to test-154.cs.
25438 2002-08-08 Martin Baulig <martin@gnome.org>
25440 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25441 Family access, make sure the invoking type isn't a subclass of the
25442 queried type (that'd be a CS1540).
25444 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25445 this method which takes an additional `Type invocation_type'.
25447 * expression.cs (BaseAccess.DoResolve): Use the base type as
25448 invocation and query type.
25449 (MemberAccess.DoResolve): If the lookup failed and we're about to
25450 report a CS0122, try a lookup with the ec.ContainerType - if this
25451 succeeds, we must report a CS1540.
25453 2002-08-08 Martin Baulig <martin@gnome.org>
25455 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25456 (MethodGroupExpr): Implement the IMemberExpr interface.
25458 * expression (MemberAccess.ResolveMemberAccess): No need to have
25459 any special code for MethodGroupExprs anymore, they're now
25462 2002-08-08 Martin Baulig <martin@gnome.org>
25464 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25465 Family, FamANDAssem and FamORAssem permissions.
25466 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25468 2002-08-08 Martin Baulig <martin@gnome.org>
25470 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25471 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25474 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25476 * driver.cs: implemented /resource option to embed managed resources.
25478 2002-08-07 Martin Baulig <martin@gnome.org>
25480 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25481 (FieldBase.HasFieldInitializer): New public property.
25482 (FieldBase.GetInitializerExpression): New public method. Resolves and
25483 returns the field initializer and makes sure it is only resolved once.
25484 (TypeContainer.EmitFieldInitializers): Call
25485 FieldBase.GetInitializerExpression to get the initializer, this ensures
25486 that it isn't resolved multiple times.
25488 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25489 the resolving process (SimpleName/MemberLookup) that we're currently
25490 emitting a field initializer (which must not access any instance members,
25491 this is an error CS0236).
25493 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25494 argument, if the `IsFieldInitializer' flag is set, we must report and
25495 error CS0236 and not an error CS0120.
25497 2002-08-07 Martin Baulig <martin@gnome.org>
25499 * ecore.cs (IMemberExpr): New public interface.
25500 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25501 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25502 if the expression is an IMemberExpr.
25504 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25505 to be null, implicitly default to `this' if we're non-static in
25506 this case. Simplified the code a lot by using the new IMemberExpr
25507 interface. Also fixed bug #28176 here.
25509 2002-08-06 Martin Baulig <martin@gnome.org>
25511 * cs-parser.jay (SimpleLookup): Removed. We need to create
25512 ParameterReferences during semantic analysis so that we can do a
25513 type-only search when resolving Cast, TypeOf and SizeOf.
25514 (block): Pass the `current_local_parameters' to the Block's
25517 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25518 argument to the constructor.
25519 (ConstructorInitializer.Resolve): Create a temporary implicit
25520 block with the parameters.
25522 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25523 references here if we aren't doing a type-only search.
25525 * statement.cs (Block): Added constructor which takes a
25526 `Parameters parameters' argument.
25527 (Block.Parameters): New public property.
25529 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25530 to `Parameters' and made it public readonly.
25532 2002-08-06 Martin Baulig <martin@gnome.org>
25534 * ecore.cs (Expression.Warning): Made this public as well.
25536 * report.cs (Report.Debug): Print the contents of collections.
25538 2002-08-06 Martin Baulig <martin@gnome.org>
25540 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25541 used to tell Resolve() which kinds of expressions it may return.
25542 (Expression.Resolve): Added overloaded version of this method which
25543 takes a `ResolveFlags flags' argument. This can be used to tell
25544 Resolve() which kinds of expressions it may return. Reports a
25546 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25547 ResolveFlags.SimpleName.
25548 (Expression.Error118): Added overloaded version of this method which
25549 takes a `ResolveFlags flags' argument. It uses the flags to determine
25550 which kinds of expressions are allowed.
25552 * expression.cs (Argument.ResolveMethodGroup): New public method.
25553 Resolves an argument, but allows a MethodGroup to be returned.
25554 This is used when invoking a delegate.
25556 * TODO: Updated a bit.
25558 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25560 Fixed compilation with csc.
25562 * ecore.cs: Expression.Error made public. Is this correct? Should
25563 Warning be made public too?
25565 * expression.cs: use ea.Location instead of ea.loc.
25566 [FIXME: Filed as bug #28607: MCS must report these errors.]
25568 2002-08-06 Martin Baulig <martin@gnome.org>
25570 * ecore.cs (Expression.loc): Moved the location here instead of
25571 duplicating it in all derived classes.
25572 (Expression.Location): New public property.
25573 (Expression.Error, Expression.Warning): Made them non-static and
25574 removed the location argument.
25575 (Expression.Warning): Added overloaded version which takes an
25576 `int level' argument.
25577 (Expression.Error118): Make this non-static and removed the
25578 expression and location arguments.
25579 (TypeExpr): Added location argument to the constructor.
25581 * expression.cs (StaticCallExpr): Added location argument to
25583 (Indirection, PointerArithmetic): Likewise.
25584 (CheckedExpr, UnCheckedExpr): Likewise.
25585 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25586 (StringPtr): Likewise.
25589 2002-08-05 Martin Baulig <martin@gnome.org>
25591 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25593 * assign.cs (Assign.DoResolve): Check whether the source
25594 expression is a value or variable.
25596 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25597 while resolving the corresponding blocks.
25599 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25600 an error, don't silently return null.
25602 * statement.cs (Block.AddVariable): Do the error reporting here
25603 and distinguish between CS0128 and CS0136.
25604 (Block.DoResolve): Report all unused labels (warning CS0164).
25605 (LabeledStatement): Pass the location to the constructor.
25606 (LabeledStatement.HasBeenReferenced): New property.
25607 (LabeledStatement.Resolve): Set it to true here.
25609 * statement.cs (Return.Emit): Return success even after reporting
25610 a type mismatch error (CS0126 or CS0127), this is what csc does and
25611 it avoids confusing the users with any consecutive errors.
25613 2002-08-05 Martin Baulig <martin@gnome.org>
25615 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25617 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25619 * expression.cs (MemberAccess.DoResolve): Silently return if an
25620 error has already been reported.
25622 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25623 error has already been reported.
25625 2002-08-05 Martin Baulig <martin@gnome.org>
25627 * statement.cs (UsageVector): Only initialize the `parameters'
25628 vector if we actually have any "out" parameters.
25630 2002-08-05 Martin Baulig <martin@gnome.org>
25632 * expression.cs (Binary.ResolveOperator): When combining delegates,
25633 they must have the same type.
25635 2002-08-05 Martin Baulig <martin@gnome.org>
25637 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25638 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25639 work with the ms runtime and we also don't need it: if we're a
25640 PropertyBuilder and not in the `indexer_arguments' hash, then we
25641 are a property and not an indexer.
25643 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25644 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25645 since the latter one doesn't work with the ms runtime.
25647 2002-08-03 Martin Baulig <martin@gnome.org>
25649 Fixed bugs #27998 and #22735.
25651 * class.cs (Method.IsOperator): New public field.
25652 (Method.CheckBase): Report CS0111 if there's already a method
25653 with the same parameters in the current class. Report CS0508 when
25654 attempting to change the return type of an inherited method.
25655 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25656 and it's not marked abstract or extern.
25657 (PropertyBase): New abstract base class for Property and Indexer.
25658 (PropertyBase.CheckBase): Moved here from Property and made it work
25660 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25661 the same so we can reuse it there.
25662 (Property, Indexer): Derive from PropertyBase.
25663 (MethodSignature.inheritable_property_signature_filter): New delegate
25664 to find properties and indexers.
25666 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25667 argument and improved error reporting.
25669 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25670 EmptyReadOnlyParameters and made it a property.
25672 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25673 version of this method which takes a `PropertyInfo indexer'.
25674 (TypeManager.RegisterIndexer): New method.
25676 * class.cs: Added myself as author of this file :-)
25678 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25680 * class.cs: fixed compilation on windoze.
25682 2002-08-03 Martin Baulig <martin@gnome.org>
25684 * interface.cs (Interface.GetInterfaceBases): Check whether all
25685 base interfaces are at least as accessible than the current one.
25687 * class.cs (TypeContainer.GetClassBases): Check whether base types
25688 are at least as accessible than the current type.
25689 (TypeContainer.AsAccessible): Implemented and made non-static.
25690 (MemberBase.CheckParameters): Report errors if the accessibility
25693 * delegate.cs (Delegate.Delegate): The default visibility is
25694 internal for top-level types and private for nested types.
25695 (Delegate.Define): Report errors if the accessibility checks fail.
25697 * enum.cs (Enum.Enum): The default visibility is internal for
25698 top-level types and private for nested types.
25699 (Enum.DefineType): Compute the correct visibility.
25701 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25702 function which takes a `bool is_toplevel' instead of a TypeContainer.
25704 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25707 2002-08-02 Martin Baulig <martin@gnome.org>
25709 * expression.cs (LocalVariableReferenc): Added constructor which
25710 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25711 (LocalVariableReference.IsReadOnly): New property.
25712 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25713 variable is readonly, use our own readonly flag to do this; you can
25714 use the new constructor to get a writable reference to a read-only
25717 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25718 reference to the local variable.
25720 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25722 * rootcontext.cs (ResolveCore): Also include System.Exception
25724 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25725 we reach an EmptyStatement.
25727 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25730 * expression.cs (Binary.ResolveOperator): Check error result in
25733 use brtrue/brfalse directly and avoid compares to null.
25735 2002-08-02 Martin Baulig <martin@gnome.org>
25737 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25738 Fixes bug #28407, added test-155.cs.
25740 2002-08-01 Martin Baulig <martin@gnome.org>
25742 * class.cs (Event.EmitDefaultMethod): Make this work with static
25743 events. Fixes #28311, added verify-3.cs.
25745 2002-08-01 Martin Baulig <martin@gnome.org>
25747 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25748 `is_disposable' fields.
25749 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25750 `hm.is_disposable' if we're using the collection pattern.
25751 (Foreach.EmitCollectionForeach): Use the correct type for the
25752 enumerator's local variable, only emit the try/finally block if
25753 necessary (fixes #27713).
25755 2002-08-01 Martin Baulig <martin@gnome.org>
25757 * ecore.cs (Expression.report118): Renamed to Error118 and made
25760 * statement.cs (Throw.Resolve): Check whether the expression is of
25761 the correct type (CS0118) and whether the type derives from
25762 System.Exception (CS0155).
25763 (Catch.Resolve): New method. Do the type lookup here and check
25764 whether it derives from System.Exception (CS0155).
25765 (Catch.CatchType, Catch.IsGeneral): New public properties.
25767 * typemanager.cs (TypeManager.exception_type): Added.
25769 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25771 * driver.cs: Updated About function.
25773 2002-07-31 Martin Baulig <martin@gnome.org>
25775 Implemented Control Flow Analysis.
25777 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25778 (EmitContext.CurrentBranching): Added.
25779 (EmitContext.StartFlowBranching): Added.
25780 (EmitContext.EndFlowBranching): Added.
25781 (EmitContext.KillFlowBranching): Added.
25782 (EmitContext.IsVariableAssigned): Added.
25783 (EmitContext.SetVariableAssigned): Added.
25784 (EmitContext.IsParameterAssigned): Added.
25785 (EmitContext.SetParameterAssigned): Added.
25786 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25787 Added control flow analysis stuff here.
25789 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25790 resolve the expression as lvalue.
25791 (LocalVariableReference.DoResolve): Check whether the variable has
25792 already been assigned.
25793 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25794 the parameter as assigned here.
25795 (ParameterReference.DoResolve): Check whether the parameter has already
25797 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25798 expression as lvalue.
25800 * statement.cs (FlowBranching): New class for the flow analysis code.
25801 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25802 (LabeledStatement.IsDefined): New public property.
25803 (LabeledStatement.AddUsageVector): New public method to tell flow
25804 analyis that the label may be reached via a forward jump.
25805 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25807 (VariableInfo.Number): New public field. This is used by flow analysis
25808 to number all locals of a block.
25809 (Block.CountVariables): New public property. This is the number of
25810 local variables in this block (including the locals from all parent
25812 (Block.EmitMeta): Number all the variables.
25814 * statement.cs: Added flow analysis support to all classes.
25816 2002-07-31 Martin Baulig <martin@gnome.org>
25818 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25819 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25820 then use this argument.
25822 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25824 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25825 use this to specify /define options.
25827 2002-07-29 Martin Baulig <martin@gnome.org>
25829 * statement.cs (Fixed): Moved all code that does variable lookups
25830 and resolvings from Emit to Resolve.
25832 * statement.cs (For): Moved all code that does variable lookups
25833 and resolvings from Emit to Resolve.
25835 * statement.cs (Using): Moved all code that does variable lookups
25836 and resolvings from Emit to Resolve.
25838 2002-07-29 Martin Baulig <martin@gnome.org>
25840 * attribute.cs (Attribute.Resolve): Explicitly catch a
25841 System.NullReferenceException when creating the
25842 CustromAttributeBuilder and report a different warning message.
25844 2002-07-29 Martin Baulig <martin@gnome.org>
25846 * support.cs (ParameterData.ParameterName): Added method to
25847 get the name of a parameter.
25849 * typemanager.cs (TypeManager.IsValueType): New public method.
25851 2002-07-29 Martin Baulig <martin@gnome.org>
25853 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25854 is a flag which specifies that it's either ref or out.
25855 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25856 the out parameter to `out Parameter.Modifier mod', also set the
25857 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25859 * support.cs (InternalParameters.ParameterModifier): Distinguish
25860 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25861 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25863 * expression.cs (Argument.GetParameterModifier): Distinguish
25864 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25865 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25867 2002-07-29 Martin Baulig <martin@gnome.org>
25869 * expression.cs (ParameterReference.ParameterReference): Added
25870 `Location loc' argument to the constructor.
25872 * cs-parser.jay: Pass location to ParameterReference.
25874 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25876 * statement.cs (Try): Initialize the location.
25878 * cs-parser.jay: pass location to Try.
25880 * expression.cs (Unary.Reduce): Change the prototype to return
25881 whether a constant fold could be performed or not. The result is
25882 returned in an out parameters. In the case of Indirection and
25883 AddressOf, we want to perform the full tests.
25885 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25887 * statement.cs (Statement.Emit): Flag dead code.
25889 2002-07-27 Andrew Birkett <andy@nobugs.org>
25891 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25893 2002-07-27 Martin Baulig <martin@gnome.org>
25895 * class.cs (MethodData.Define): Put back call to
25896 TypeManager.AddMethod(), accidentally commented this out.
25898 * report.cs (Debug): New public method to print debugging information,
25899 this is `[Conditional ("DEBUG")]'.
25901 2002-07-26 Martin Baulig <martin@gnome.org>
25903 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25904 (switch_statement): Push the current_block to the switch_stack and
25905 pop it again when we're done with the switch.
25906 (switch_section): The new block is a child of the current_block.
25907 Fixes bug #24007, added test-152.cs.
25909 2002-07-27 Martin Baulig <martin@gnome.org>
25911 * expression.cs (Invocation.EmitArguments): When calling a varargs
25912 function with only its fixed arguments, we need to pass an empty
25915 2002-07-27 Martin Baulig <martin@gnome.org>
25917 Mono 0.13 has been released.
25919 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25921 * driver.cs: Rename --resource to --linkres, because that is what
25922 we do currently, we dont support --resource yet.
25924 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25926 2002-07-25 Martin Baulig <martin@gnome.org>
25928 * class.cs (MethodData): New public class. This is a `method builder'
25929 class for a method or one accessor of a Property/Indexer/Event.
25930 (MethodData.GetMethodFlags): Moved here from MemberBase.
25931 (MethodData.ApplyAttributes): Likewise.
25932 (MethodData.ApplyObsoleteAttribute): Likewise.
25933 (MethodData.ApplyConditionalAttribute): Likewise.
25934 (MethodData.ApplyDllImportAttribute): Likewise.
25935 (MethodData.CheckAbstractAndExternal): Likewise.
25936 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25937 (MethodData.Emit): Formerly known as Method.Emit().
25938 (MemberBase): Moved everything which was specific to a single
25939 accessor/method to MethodData.
25940 (Method): Create a new MethodData and call Define() and Emit() on it.
25941 (Property, Indexer, Event): Create a new MethodData objects for each
25942 accessor and call Define() and Emit() on them.
25944 2002-07-25 Martin Baulig <martin@gnome.org>
25946 Made MethodCore derive from MemberBase to reuse the code from there.
25947 MemberBase now also checks for attributes.
25949 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25950 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25952 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25953 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25954 (MemberBase.ApplyAttributes): New virtual method; applies the
25955 attributes to a method or accessor.
25956 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25957 (MemberBase.ApplyConditionalAttribute): Likewise.
25958 (MemberBase.ApplyDllImportAttribute): Likewise.
25959 (MemberBase.CheckAbstractAndExternal): Likewise.
25960 (MethodCore.ParameterTypes): This is now a property instead of a
25961 method, it's initialized from DoDefineParameters().
25962 (MethodCore.ParameterInfo): Removed the set accessor.
25963 (MethodCore.DoDefineParameters): New protected virtual method to
25964 initialize ParameterTypes and ParameterInfo.
25965 (Method.GetReturnType): We can now simply return the MemberType.
25966 (Method.GetMethodFlags): Override the MemberBase version and add
25967 the conditional flags.
25968 (Method.CheckBase): Moved some code from Define() here, call
25969 DoDefineParameters() here.
25970 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25971 here to avoid some larger code duplication.
25972 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25973 ensure that abstract and external accessors don't declare a body.
25975 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25976 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25977 lookup in the attribute's parent classes, so we need to abort as soon
25978 as we found the first match.
25979 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25980 the attribute has no arguments.
25982 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25985 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25987 * cs-parser.jay: reverted previous patch.
25989 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25991 * cs-parser.jay: fixed bug #22119.
25993 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25995 * attribute.cs: fixed compilation. The error was:
25996 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25997 be assigned to before control leaves the current method."
25998 [FIXME: Filed as bug #28186: MCS must report this error.]
26000 2002-07-25 Martin Baulig <martin@gnome.org>
26002 * attribute.cs (Attribute.Conditional_GetConditionName): New static
26003 method to pull the condition name ouf of a Conditional attribute.
26004 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
26005 the obsolete message and error flag out of an Obsolete attribute.
26007 * class.cs (Method.GetMethodFlags): New public method to get the
26008 TypeManager.MethodFlags for this method.
26009 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
26011 (Method.Define): Get and apply the Obsolete and Conditional attributes;
26012 if we're overriding a virtual function, set the new private variable
26013 `parent_method'; call the new TypeManager.AddMethod().
26015 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
26016 the MethodBuilder and the Method in a PtrHashtable.
26017 (TypeManager.builder_to_method): Added for this purpose.
26018 (TypeManager.MethodFlags): Added IsObsoleteError.
26019 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
26020 Obsolete and Conditional arguments in MethodBuilders. If we discover
26021 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
26022 the message from the attribute.
26024 2002-07-24 Martin Baulig <martin@gnome.org>
26026 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
26027 preprocessor directives, ensure that the argument to #define/#undef is
26028 exactly one identifier and that it's actually an identifier.
26030 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
26033 2002-07-24 Martin Baulig <martin@gnome.org>
26035 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
26036 initialize it to TypeManager.object_type in the constructor.
26037 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
26038 of the `hm.get_current' method if we're using the collection pattern.
26039 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
26040 for the explicit conversion to make it work when we're using the collection
26041 pattern and the `Current' property has a different return type than `object'.
26044 2002-07-24 Martin Baulig <martin@gnome.org>
26046 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
26047 does not match, but don't report any errors. This method is called in
26048 order for all methods in a MethodGroupExpr until a matching method is
26049 found, so we don't want to bail out if the first method doesn't match.
26050 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
26051 matches, report the 123. Fixes #28070.
26053 2002-07-24 Martin Baulig <martin@gnome.org>
26055 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
26056 TypeManager.TypeToCoreType() to the top of the method so the
26057 following equality checks will work. Fixes #28107.
26059 2002-07-24 Martin Baulig <martin@gnome.org>
26061 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
26062 operand is of type uint, and the other operand is of type sbyte,
26063 short or int, the operands are converted to type long." -
26064 Actually do what this comment already told us. Fixes bug #28106,
26067 2002-07-24 Martin Baulig <martin@gnome.org>
26069 * class.cs (MethodBase): New abstract class. This is now a base
26070 class for Property, Indexer and Event to avoid some code duplication
26071 in their Define() and DefineMethods() methods.
26072 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
26073 generic methods for Define() and DefineMethods().
26074 (FieldBase): Derive from MemberBase, not MemberCore.
26075 (Property): Derive from MemberBase, not MemberCore.
26076 (Property.DefineMethod): Moved all the code from this method to the
26077 new MethodBase.DefineAccessor(), just call it with appropriate
26079 (Property.Define): Call the new Property.DoDefine(), this does some
26080 sanity checks and we don't need to duplicate the code everywhere.
26081 (Event): Derive from MemberBase, not MemberCore.
26082 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
26083 accessors, this will also make them work with interface events.
26084 (Indexer): Derive from MemberBase, not MemberCore.
26085 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
26086 (Indexer.Define): Use the new MethodBase functions.
26088 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
26089 argument to the constructor.
26090 (Interface.FindMembers): Added support for interface events.
26091 (Interface.PopluateEvent): Implemented.
26093 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
26095 2002-07-22 Miguel de Icaza <miguel@ximian.com>
26097 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
26098 but this is required to check for a method name being the same as
26099 the containing class.
26103 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26105 * interface.cs: initialize variable.
26107 2002-07-23 Martin Baulig <martin@gnome.org>
26109 Implemented the IndexerName attribute in interfaces.
26111 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
26112 name if this is an explicit interface implementation.
26113 (Indexer.InterfaceIndexerName): New public variable. If we're
26114 implementing an interface indexer, this is the IndexerName in that
26115 interface. Otherwise, it's the IndexerName.
26116 (Indexer.DefineMethod): If we're implementing interface indexer,
26117 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
26118 and Pending.ImplementIndexer methods.
26119 (Indexer.Define): Also define the PropertyBuilder if we're
26120 implementing an interface indexer and this is neither an explicit
26121 interface implementation nor do the IndexerName match the one in
26124 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
26125 If a method is defined here, then we always need to create a proxy
26126 for it. This is used when implementing interface indexers.
26127 (Pending.IsInterfaceIndexer): New public method.
26128 (Pending.ImplementIndexer): New public method.
26129 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
26130 This is used when implementing interface indexers to define a proxy
26132 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
26133 define a proxy if necessary.
26135 * interface.cs (Interface.IndexerName): New public variable.
26136 (Interface.PopulateIndexer): Set the IndexerName.
26137 (Interface.DefineIndexers): New private method. Populate all the
26138 indexers and make sure their IndexerNames match.
26140 * typemanager.cs (IndexerPropertyName): Added support for interface
26143 2002-07-22 Martin Baulig <martin@gnome.org>
26145 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
26146 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
26147 ret if HasReturnLabel.
26148 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
26151 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
26152 and set the ec.LoopBeginTryCatchLevel.
26153 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
26154 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
26155 the current ec.TryCatchLevel, the branch goes out of an exception
26156 block. In this case, we need to use Leave and not Br.
26158 2002-07-22 Martin Baulig <martin@gnome.org>
26160 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
26161 block unless the block does not always return or it is contained in
26162 another try { ... } catch { ... } block. Fixes bug #26506.
26163 Added verify-1.cs to the test suite.
26165 2002-07-22 Martin Baulig <martin@gnome.org>
26167 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
26168 then we do not always return. Fixes bug #24985.
26170 2002-07-22 Martin Baulig <martin@gnome.org>
26172 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
26173 lookup on a per-class level; ie. walk up the class hierarchy until we
26174 found at least one applicable method, then choose the best among them.
26175 Fixes bug #24463 and test-29.cs.
26177 2002-07-22 Martin Baulig <martin@gnome.org>
26179 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
26180 return types of the methods. The return type is not part of the
26181 signature and we must not check it to make the `new' modifier work.
26182 Fixes bug #27999, also added test-147.cs.
26183 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
26185 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
26186 on the method's return type.
26188 2002-07-21 Martin Baulig <martin@gnome.org>
26190 * assign.cs: Make this work if the rightmost source is a constant and
26191 we need to do an implicit type conversion. Also adding a few more tests
26192 to test-38.cs which should have caught this.
26194 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
26195 target in the makefile for this. The makefile.gnu is primarily intended
26196 for end-users who don't want to debug the compiler.
26198 2002-07-21 Martin Baulig <martin@gnome.org>
26200 * assign.cs: Improved the Assign class so it can now handle embedded
26201 assignments (X = Y = Z = something). As a side-effect this'll now also
26202 consume less local variables. test-38.cs now passes with MCS, added
26203 a few new test cases to that test.
26205 2002-07-20 Martin Baulig <martin@gnome.org>
26207 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
26208 instructions. Fixes bug #27977, also added test-146.cs.
26210 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26212 * cs-tokenizer.cs: fixed getHex ().
26214 2002-07-19 Martin Baulig <martin@gnome.org>
26216 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
26217 not Type.GetType() to lookup the array type. This is needed when
26218 we're constructing an array of a user-defined type.
26219 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
26220 single-dimensional arrays, but also for single-dimensial arrays of
26223 2002-07-19 Martin Baulig <martin@gnome.org>
26225 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
26226 this function is called, it's not allowed to share LocalBuilders
26227 among ILGenerators.
26229 2002-07-19 Martin Baulig <martin@gnome.org>
26231 * expression.cs (Argument.Resolve): Report an error 118 when trying
26232 to pass a type as argument.
26234 2002-07-18 Martin Baulig <martin@gnome.org>
26236 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
26237 Conv_R_Un for the signed `long' type.
26239 2002-07-15 Miguel de Icaza <miguel@ximian.com>
26241 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
26242 `expr' for the temporary result, as that will fail if we do
26243 multiple resolves on the same expression.
26245 2002-07-05 Miguel de Icaza <miguel@ximian.com>
26247 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
26248 ec.TypeContainer for looking up aliases.
26250 * class.cs (TypeContainer): Remove LookupAlias from here.
26252 * decl.cs (DeclSpace); Move here.
26254 2002-07-01 Miguel de Icaza <miguel@ximian.com>
26256 * class.cs (FindMembers): Only call filter if the constructor
26257 bulider is not null.
26259 Also handle delegates in `NestedTypes' now. Now we will perform
26260 type lookups using the standard resolution process. This also
26263 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
26264 This uses Expressions (the limited kind that can be parsed by the
26265 tree) instead of strings.
26267 * expression.cs (ComposedCast.ToString): Implement, used to flag
26268 errors since now we have to render expressions.
26270 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
26273 * ecore.cs (SimpleName.ToString): ditto.
26275 * cs-parser.jay: Instead of using strings to assemble types, use
26276 Expressions to assemble the type (using SimpleName, ComposedCast,
26277 MemberAccess). This should fix the type lookups in declarations,
26278 because we were using a different code path for this.
26280 * statement.cs (Block.Resolve): Continue processing statements
26281 even when there is an error.
26283 2002-07-17 Miguel de Icaza <miguel@ximian.com>
26285 * class.cs (Event.Define): Also remove the `remove' method from
26286 the list of pending items.
26288 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
26289 generate more compact code.
26291 2002-07-17 Martin Baulig <martin@gnome.org>
26293 * const.cs (Const.LookupConstantValue): Add support for constant
26294 `unchecked' and `checked' expressions.
26295 Also adding test case test-140.cs for this.
26297 2002-07-17 Martin Baulig <martin@gnome.org>
26299 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26300 check whether mi.ReturnType implements the IEnumerator interface; the
26301 `==' and the IsAssignableFrom() will fail in this situation.
26303 2002-07-16 Ravi Pratap <ravi@ximian.com>
26305 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26308 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26310 * expression.cs: fixed bug #27811.
26312 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26314 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26315 Molaro: when we are a ref, the value already contains a pointer
26316 value, do not take the address of it.
26318 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26319 * removed mb-parser.jay and mb-tokenizer.cs
26321 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26323 * expression.cs: check against the building corlib void type.
26325 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26327 * ecore.cs: fix for valuetype static readonly fields: when
26328 initializing them, we need their address, not the address of a copy.
26330 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26332 * typemanager.cs: register also enum_type in corlib.
26334 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26336 * class.cs: allow calling this (but not base) initializers in structs.
26338 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26340 * ecore.cs: make sure we compare against the building base types
26343 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26345 * typemanager.cs: fix TypeToCoreType() to handle void and object
26346 (corlib gets no more typerefs after this change).
26348 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26350 * expression.cs (ArrayCreation.EmitArrayArguments): use
26351 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26353 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26354 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26355 array indexes, the runtime actually forbids them.
26357 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26358 for array arguments here.
26360 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26361 instead of the default for ValueTypes.
26363 (New.DoEmit): Use IsValueType instead of
26364 IsSubclassOf (value_type)
26365 (New.DoResolve): ditto.
26366 (Invocation.EmitCall): ditto.
26368 * assign.cs (Assign): ditto.
26370 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26371 Statements *are* currently doing part of their resolution during
26374 Expressions do always resolve during resolve, but statements are
26375 only required to propagate resolution to their children.
26377 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26379 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26381 (LoadAssembly): Do not add the dll if it is already specified
26383 (MainDriver): Add the System directory to the link path at the end,
26384 after all the other -L arguments.
26386 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26387 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26388 ldelem.u1) and using the opposite for sbytes.
26390 This fixes Digger, and we can finally run it.
26392 * driver.cs (UnixParseOption): Move the option parsing here.
26393 (CSCParseOption): Implement CSC-like parsing of options.
26395 We now support both modes of operation, the old Unix way, and the
26396 new CSC-like way. This should help those who wanted to make cross
26397 platform makefiles.
26399 The only thing broken is that /r:, /reference: and /lib: are not
26400 implemented, because I want to make those have the same semantics
26401 as the CSC compiler has, and kill once and for all the confussion
26402 around this. Will be doing this tomorrow.
26404 * statement.cs (Unsafe.Resolve): The state is checked during
26405 resolve, not emit, so we have to set the flags for IsUnsfe here.
26407 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26409 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26410 not catch the Error_ObjectRefRequired in SimpleName (as it is
26411 possible to have a class/instance variable name that later gets
26412 deambiguated), we have to check this here.
26414 2002-07-10 Ravi Pratap <ravi@ximian.com>
26416 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26417 make static and put into Expression.
26419 (Event.Define): Register the private field of the event with the
26420 TypeManager so that GetFieldFromEvent can get at it.
26422 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26423 keep track of the private field associated with an event which
26426 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26429 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26431 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26433 * expression.cs (Binary.EmitBranchable): this routine emits the
26434 Binary expression in a branchable context. This basically means:
26435 we need to branch somewhere, not just get the value on the stack.
26437 This works together with Statement.EmitBoolExpression.
26439 * statement.cs (Statement.EmitBoolExpression): Use
26442 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26444 * statement.cs (For): Reduce the number of jumps in loops.
26446 (For): Implement loop inversion for the For statement.
26448 (Break): We can be breaking out of a Try/Catch controlled section
26449 (foreach might have an implicit try/catch clause), so we need to
26450 use Leave instead of Br.
26452 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26453 now). If the instace expression supports IMemoryLocation, we use
26454 the AddressOf method from the IMemoryLocation to extract the
26455 address instead of emitting the instance.
26457 This showed up with `This', as we were emitting the instance
26458 always (Emit) instead of the Address of This. Particularly
26459 interesting when This is a value type, as we dont want the Emit
26460 effect (which was to load the object).
26462 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26464 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26466 * statement.cs (Checked): Set the CheckedState during the resolve
26467 process too, as the ConvCast operations track the checked state on
26468 the resolve process, and not emit.
26470 * cs-parser.jay (namespace_member_declaration): Flag that we have
26471 found a declaration when we do. This is used to flag error 1529
26473 * driver.cs: Report ok when we display the help only.
26475 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26477 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26479 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26481 * cs-tokenizer.cs (define): We also have to track locally the
26482 defines. AllDefines is just used for the Conditional Attribute,
26483 but we also need the local defines for the current source code.
26485 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26487 * statement.cs (While, For, Do): These loops can exit through a
26488 Break statement, use this information to tell whether the
26489 statement is the last piece of code.
26491 (Break): Flag that we break.
26493 * codegen.cs (EmitContexts): New `Breaks' state variable.
26495 2002-07-03 Martin Baulig <martin@gnome.org>
26497 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26498 modifiers in method declarations in structs. Otherwise, you won't
26499 be able to override things like Object.Equals().
26501 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26503 * class.cs (Method, Property, Indexer): Do not allow the public
26504 modifier to be used in explicit interface implementations.
26506 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26507 override modifiers in method declarations in structs
26509 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26511 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26512 integer or real overflow, report an error
26514 2002-07-02 Martin Baulig <martin@gnome.org>
26516 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26517 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26518 to tell the runtime about our newly created System.Object and
26519 System.ValueType types.
26521 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26523 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26524 struct instead of Ldarg/Starg.
26526 2002-07-02 Martin Baulig <martin@gnome.org>
26528 * expression.cs (Indirection.Indirection): Call
26529 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26531 2002-07-02 Martin Baulig <martin@gnome.org>
26533 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26534 ValueType, call TypeManager.TypeToCoreType() on it.
26535 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26536 the OpCodes.Newarr argument.
26538 2002-07-02 Martin Baulig <martin@gnome.org>
26540 * expression.cs (Invocation.EmitCall): When compiling corlib,
26541 replace all calls to the system's System.Array type to calls to
26542 the newly created one.
26544 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26545 System.Array methods.
26546 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26547 from the system's System.Array type which must be replaced.
26549 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26551 * typemanager.cs: load unverifiable_code_ctor so we can build
26552 corlib using the correct type. Avoid using GetTypeCode() with
26554 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26555 TypeManager.object_type to allow building corlib.
26557 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26559 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26561 2002-07-01 Martin Baulig <martin@gnome.org>
26563 * class.cs: Make the last change actually work, we need to check
26564 whether `ifaces != null' to avoid a crash.
26566 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26568 * class.cs: when we build structs without fields that implement
26569 interfaces, we need to add the interfaces separately, since there is
26570 no API to both set the size and add the interfaces at type creation
26573 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26575 * expression.cs: the dimension arguments to the array constructors
26576 need to be converted if they are a long.
26578 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26580 * class.cs: don't emit ldarg.0 if there is no parent constructor
26581 (fixes showstopper for corlib).
26583 2002-06-29 Martin Baulig <martin@gnome.org>
26585 MCS now compiles corlib on GNU/Linux :-)
26587 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26588 ie. check for MethodImplOptions.InternalCall.
26590 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26591 and TypeManager.attribute_type are null, so we must explicitly check
26592 whether parent is not null to find out whether it's an attribute type.
26593 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26594 and SetBuilder, not only if the property is neither abstract nor external.
26595 This is necessary to set the MethodImplOptions on the accessor methods.
26596 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26597 SetBuilder, see Property.Emit().
26599 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26600 populate "System.Object", "System.ValueType" and "System.Attribute" since
26601 they've already been populated from BootCorlib_PopulateCoreTypes().
26603 2002-06-29 Martin Baulig <martin@gnome.org>
26605 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26606 is the NullLiteral, we also need to make sure that target_type is not
26609 2002-06-29 Martin Baulig <martin@gnome.org>
26611 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26612 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26613 before calling BootstrapCorlib_ResolveDelegate ().
26615 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26617 * statement.cs: fixed build-breaker. All tests passed ok.
26619 2002-06-27 Martin Baulig <martin@gnome.org>
26621 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26622 for System.Decimal when compiling corlib.
26624 2002-06-27 Martin Baulig <martin@gnome.org>
26626 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26627 switch blocks which contain nothing but a default clause.
26629 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26631 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26633 2002-06-27 Martin Baulig <martin@gnome.org>
26635 * ecore.cs (PropertyExpr.PropertyExpr): Call
26636 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26638 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26639 is already a TypeBuilder.
26641 2002-06-27 Martin Baulig <martin@gnome.org>
26643 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26644 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26645 the "from an array-type to System.Array" case. This makes it work
26646 when compiling corlib.
26648 2002-06-27 Martin Baulig <martin@gnome.org>
26650 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26651 non-static PropertyExpr, set its InstanceExpression. This makes
26652 the `ICollection.Count' property work in System/Array.cs.
26654 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26656 * driver.cs: Made error handling more consistent. Errors now
26657 tracked by Report class, so many methods which used to return int
26658 now return void. Main() now prints success/failure and
26659 errors/warnings message.
26661 Renamed '--probe' compiler argument to '--expect-error'. Removed
26662 the magic number return values (123 and 124). Now, if the
26663 expected error occurs, the compiler exits with success (exit value
26664 0). If the compilation completes without seeing that particular
26665 error, the compiler exits with failure (exit value 1). The
26666 makefile in mcs/errors has been changed to handle the new behaviour.
26668 * report.cs: Made 'expected error' number a property and renamed
26669 it from 'Probe' to 'ExpectedError'.
26671 * genericparser.cs: Removed error handling support, since it is
26672 now all done by Report class.
26674 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26675 class, so parse() no longer returns an int.
26677 * namespace.cs: Use Report.Error instead of GenericParser.error
26679 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26681 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26682 TypeContainer.AddOperator): At the front of the list put the
26683 explicit implementations, so they get resolved/defined first.
26685 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26687 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26688 interface type is implemented by this TypeContainer. Used during
26689 explicit interface implementation.
26691 (Property.Define, Indexer.Define, Method.Define): Validate that
26692 the given interface in the explicit implementation is one of the
26693 base classes for the containing type.
26695 Also if we are explicitly implementing an interface, but there is
26696 no match in the pending implementation table, report an error.
26698 (Property.Define): Only define the property if we are
26699 not explicitly implementing a property from an interface. Use the
26700 correct name also for those properties (the same CSC uses,
26701 although that is really not needed).
26703 (Property.Emit): Do not emit attributes for explicitly implemented
26704 properties, as there is no TypeBuilder.
26706 (Indexer.Emit): ditto.
26708 Hiding then means that we do not really *implement* a pending
26709 implementation, which makes code fail.
26711 2002-06-22 Martin Baulig <martin@gnome.org>
26713 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26714 the return value of Object.GetType(). [FIXME: we need to do this whenever
26715 we get a type back from the reflection library].
26717 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26719 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26721 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26723 * attribute.cs: Return null if we can not look up the type.
26725 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26726 the interface types found.
26728 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26729 interface types found.
26731 * typemanager.cs (GetInterfaces): Make this routine returns alll
26732 the interfaces and work around the lame differences between
26733 System.Type and System.Reflection.Emit.TypeBuilder in the results
26734 result for GetInterfaces.
26736 (ExpandInterfaces): Given an array of interface types, expand and
26737 eliminate repeated ocurrences of an interface. This expands in
26738 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26741 2002-06-21 Martin Baulig <martin@gnome.org>
26743 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26746 2002-06-21 Martin Baulig <martin@gnome.org>
26748 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26749 and called with one of the core types, return the corresponding typebuilder for
26752 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26755 2002-06-21 Martin Baulig <martin@gnome.org>
26757 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26758 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26759 (Expression.ConvertReferenceExplicit): Likewise.
26761 * expression.cs (ElementAccess.DoResolve): Likewise.
26762 (ElementAccess.DoResolveLValue): Likewise.
26764 2002-06-10 Martin Baulig <martin@gnome.org>
26766 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26767 add the "value" parameter to the parameter list.
26769 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26772 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26774 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26775 the argument to an int, uint, long or ulong, per the spec. Also
26776 catch negative constants in array creation.
26778 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26780 * class.cs: do not allow the same interface to appear twice in
26781 the definition list.
26783 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26785 * ecore.cs: don't use ldlen with System.Array.
26787 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26789 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26791 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26793 * modifiers.cs: produce correct field attributes for protected
26794 internal. Easy fix so miguel can work on ther harder stuff:-)
26796 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26798 * pending.cs: New file. Move the code from class.cs here.
26799 Support clearning the pending flag for all methods (when not doing
26800 explicit interface implementation).
26802 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26804 * rootcontext.cs: added a couple more types needed to bootstrap.
26806 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26808 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26809 constructor in the type, instead of any constructor in the type
26810 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26811 a bug in the Mono runtime when applying the params attribute).
26813 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26814 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26816 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26818 * expression.cs (Unary.ResolveOperator): Use TypeManager
26819 to resolve the type.
26821 2002-06-13 Ravi Pratap <ravi@ximian.com>
26823 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26826 * enum.cs (AddEnumMember): Add support to store the attributes associated
26827 with each member too.
26829 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26830 field builders too - this takes care of the enum member case.
26832 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26834 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26835 address-of operator on both value types and pointers.
26837 2002-06-10 Martin Baulig <martin@gnome.org>
26839 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26840 PropertyBuilder to the `property_builders' list.
26842 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26843 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26844 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26845 find any indexers which are inherited from an interface.
26847 2002-06-09 Martin Baulig <martin@gnome.org>
26849 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26850 the same type as the constant if necessary. There's also a test-130.cs
26853 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26855 * typemanager.cs (TypeManager.ChangeType): Previously known as
26856 Enum.ChangeEnumType().
26858 2002-06-09 Martin Baulig <martin@gnome.org>
26860 * expression.cs (Cast.TryReduce): Added support for consts.
26862 2002-06-08 Ravi Pratap <ravi@ximian.com>
26864 * class.cs (Accessor): Hold attributes information so we can pass
26867 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26868 Modify to pass in attributes attached to the methods.
26870 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26872 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26873 to handle the Accessor kind :-)
26875 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26877 2002-06-08 Martin Baulig <martin@gnome.org>
26879 * expression.cs (Unary.TryReduceNegative): Added support for
26882 2002-06-08 Martin Baulig <martin@gnome.org>
26884 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26885 name can't be found in the `defined_names' - the caller will do a
26886 MemberLookup in this case and thus find methods in System.Enum
26887 such as Enum.IsDefined().
26889 2002-06-08 Martin Baulig <martin@gnome.org>
26891 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26892 Convert.ChangeType() which works with TypeBuilder created types.
26893 (Enum.LookupEnumValue, Enum.Define): Use it here.
26895 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26896 `TypeBuilder.BaseType != null' check.
26897 (TypeContainer.FindMembers): Only lookup parent members if we
26898 actually have a parent.
26899 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26900 (ConstructorInitializer.Resolve): Likewise.
26902 * interface.cs (Interface.FindMembers): Added
26903 `TypeBuilder.BaseType != null' check.
26905 * rootcontext.cs (RootContext.ResolveCore): Added
26906 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26907 classes_second_stage.
26909 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26910 debug_type and trace_type when compiling with --nostdlib.
26912 2002-06-07 Martin Baulig <martin@gnome.org>
26914 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26915 (AddField): Set it to true when adding a non-static field.
26916 (DefineType): Use `have_nonstatic_fields' to find out whether we
26917 have non-static fields, not `Fields != null'.
26919 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26921 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26922 dereferencing a null on the static-field code path)
26924 2002-05-30 Martin Baulig <martin@gnome.org>
26926 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26927 to take command line arguments. Use reflection to call the new
26928 custom `Initialize' function on the symbol writer and pass it the
26929 command line arguments.
26931 * driver.cs (--debug-args): New command line argument to pass command
26932 line arguments to the symbol writer.
26934 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26936 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26937 the target type for indexers and properties. Thanks to Joe for
26940 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26942 * typemanager.cs (MethodFlags): returns the method flags
26943 (Obsolete/ShouldIgnore) that control warning emission and whether
26944 the invocation should be made, or ignored.
26946 * expression.cs (Invocation.Emit): Remove previous hack, we should
26947 not do this on matching a base type, we should do this based on an attribute
26949 Only emit calls to System.Diagnostics.Debug and
26950 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26951 on the command line.
26953 * rootcontext.cs: Global settings for tracing and debugging.
26955 * cs-tokenizer.cs (define): New utility function to track
26956 defines. Set the global settings for TRACE and DEBUG if found.
26958 2002-05-25 Ravi Pratap <ravi@ximian.com>
26960 * interface.cs (Populate*): Pass in the TypeContainer as well as
26961 the DeclSpace as parameters so that we can create EmitContexts and
26962 then use that to apply attributes etc.
26964 (PopulateMethod, PopulateEvent, PopulateProperty)
26965 (PopulateIndexer): Apply attributes everywhere.
26967 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26970 (ApplyAttributes): Update accordingly.
26972 We now apply interface attributes for all members too.
26974 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26976 * class.cs (Indexer.Define); Correctly check if we are explicit
26977 implementation (instead of checking the Name for a ".", we
26978 directly look up if the InterfaceType was specified).
26980 Delay the creation of the PropertyBuilder.
26982 Only create the PropertyBuilder if we are not an explicit
26983 interface implementation. This means that explicit interface
26984 implementation members do not participate in regular function
26985 lookups, and hence fixes another major ambiguity problem in
26986 overload resolution (that was the visible effect).
26988 (DefineMethod): Return whether we are doing an interface
26991 * typemanager.cs: Temporary hack until we get attributes in
26992 interfaces (Ravi is working on that) and we get IndexerName
26993 support in interfaces.
26995 * interface.cs: Register the indexers as properties.
26997 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26998 warning, I have verified that this is a bug in the .NET runtime
26999 (JavaScript suffers of the same problem).
27001 * typemanager.cs (MemberLookup): When looking up members for
27002 interfaces, the parent of an interface is the implicit
27003 System.Object (so we succeed in searches of Object methods in an
27004 interface method invocation. Example: IEnumerable x; x.ToString
27007 2002-05-25 Miguel de Icaza <miguel@ximian.com>
27009 * class.cs (Event): Events should also register if they do
27010 implement the methods that an interface requires.
27012 * typemanager.cs (MemberLookup); use the new GetInterfaces
27015 (GetInterfaces): The code used to lookup interfaces for a type is
27016 used in more than one place, factor it here.
27018 * driver.cs: Track the errors at the bottom of the file, we kept
27021 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
27022 instance if the method we are calling is static!
27024 2002-05-24 Miguel de Icaza <miguel@ximian.com>
27026 * attribute.cs (ApplyAttributes): Make this function filter out
27027 the IndexerName attribute (as that attribute in reality is never
27028 applied) and return the string constant for the IndexerName
27031 * class.cs (TypeContainer.Emit): Validate that all the indexers
27032 have the same IndexerName attribute, and if so, set the
27033 DefaultName attribute on the class.
27035 * typemanager.cs: The return value might contain other stuff (not
27036 only methods). For instance, consider a method with an "Item"
27037 property and an Item method.
27039 * class.cs: If there is a problem with the parameter types,
27042 2002-05-24 Ravi Pratap <ravi@ximian.com>
27044 * ecore.cs (ImplicitConversionExists): Wrapper function which also
27045 looks at user defined conversion after making a call to
27046 StandardConversionExists - we need this for overload resolution.
27048 * expression.cs : Update accordingly the various method calls.
27050 This fixes 2 bugs filed against implicit user defined conversions
27052 2002-05-22 Miguel de Icaza <miguel@ximian.com>
27054 * statement.cs: Track the result of the assignment.
27056 2002-05-21 Miguel de Icaza <miguel@ximian.com>
27058 * expression.cs (MemberAccess): Improved error reporting for
27059 inaccessible members.
27061 2002-05-22 Martin Baulig <martin@gnome.org>
27063 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
27064 itself with debugging support.
27066 2002-05-22 Martin Baulig <martin@gnome.org>
27068 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
27069 Removed, this isn't needed anymore.
27071 2002-05-20 Martin Baulig <martin@gnome.org>
27073 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
27074 be underlying type for an enum.
27076 2002-05-20 Miguel de Icaza <miguel@ximian.com>
27078 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
27079 that splits out the loading of just the core types.
27081 * rootcontext.cs (ResolveCore): Split the struct resolution in
27082 two, so we can load the enumeration underlying types before any
27085 * expression.cs (Is): Bandaid until we fix properly Switch (see
27086 bug #24985 for details).
27088 * typemanager.cs (ImplementsInterface): The hashtable will contain
27089 a null if there are no interfaces implemented.
27091 2002-05-18 Miguel de Icaza <miguel@ximian.com>
27093 * cs-parser.jay (indexer_declarator): It is fine to have array
27096 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27098 * typemanager.cs: (RegisterBuilder): New function used to register
27099 TypeBuilders that implement interfaces. Since
27100 TypeBuilder.GetInterfaces (as usual) does not work with lame
27102 (AddUserType): register interfaces.
27104 (ImplementsInterface): Use the builder_to_ifaces hash if we are
27105 dealing with TypeBuilder. Also, arrays are showing up as
27106 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
27107 methods can not be invoked on them!
27109 * ecore.cs (ExplicitReferenceConversionExists): Made public.
27110 (ImplicitReferenceConversionExists): Split out from
27111 StandardConversionExists.
27113 * expression.cs (As): We were only implementing one of the three
27114 cases for the as operator. We now implement them all.
27115 (Is): Implement the various other cases for Is as well.
27117 * typemanager.cs (CACHE): New define used to control if we want or
27118 not the FindMembers cache. Seems to have a negative impact on
27119 performance currently
27121 (MemberLookup): Nested types have full acess to
27122 enclosing type members
27124 Remove code that coped with instance/static returns for events, we
27125 now catch this in RealFindMembers.
27127 (RealFindMembers): only perform static lookup if the instance
27128 lookup did not return a type or an event.
27130 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27132 * assign.cs (CompoundAssign): We pass more semantic information
27133 now to Compound Assignments than we did before: now we have all
27134 the information at hand, and now we resolve the target *before* we
27135 do the expression expansion, which allows the "CacheValue" method
27136 to have the effect we intended (before, a [x] += 1 would generate
27137 two differen ArrayAccess expressions from the ElementAccess,
27138 during the resolution process).
27140 (CompoundAssign.DoResolve): Resolve target and original_source here.
27142 2002-05-16 Miguel de Icaza <miguel@ximian.com>
27144 * expression.cs (ArrayAccess): dropped debugging information.
27146 * typemanager.cs: Small bug fix: I was always returning i_members,
27147 instead of one of i_members or s_members (depending on which had
27150 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
27151 method is invoked before any code generation takes place, and it
27152 is a mechanism to inform that the expression will be invoked more
27153 than once, and that the method should use temporary values to
27154 avoid having side effects
27156 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
27158 * ecore.cs (Expression.CacheTemporaries): Provide empty default
27161 * expression.cs (Indirection, ArrayAccess): Add support for
27162 CacheTemporaries in these two bad boys.
27164 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
27165 ldobj or ldind_ref.
27166 (StoreFromPtr): Handle stobj as well.
27168 * expression.cs (UnaryMutator): Share more code.
27170 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
27171 down: I was not tracking the Filter function as well, which
27172 was affecting the results of the cache.
27174 2002-05-15 Miguel de Icaza <miguel@ximian.com>
27176 * attribute.cs: Remove the hack to handle the CharSet property on
27179 2002-05-14 Miguel de Icaza <miguel@ximian.com>
27181 * attribute.cs (DoResolve): More uglyness, we now only try to
27182 resolve the attribute partially, to extract the CharSet
27183 information (only if we are a StructLayout attribute). Otherwise
27185 (GetExtraTypeInfo): Add some code to conditionally kill in the
27186 future this. I am more and more convinced that the .NET
27187 framework has special code to handle the attribute setting on
27190 * expression.cs (IsParamsMethodApplicable): Revert my previous
27191 foreach change here, it was wrong.
27193 2002-05-13 Miguel de Icaza <miguel@ximian.com>
27195 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
27196 (pp_expr): do not abort on unknown input, just return.
27197 (eval): abort if there are pending chars.
27199 * attribute.cs (Attribute.Resolve): Positional parameters are
27200 optional. Deal with that case.
27202 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
27203 the Ansi/Unicode/Auto information for the type.
27205 (TypeContainer.DefineType): instantiate the EmitContext here, as
27206 we will be using it during the type definition (to resolve
27207 attributes) and during the emit phase.
27209 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
27210 to pull type information out of the attributes
27212 (Attribute.Resolve): track the constructor builder, and allow for
27213 multiple invocations (structs and classes will use this).
27215 * ecore.cs (MemberLookupFinal): new version with all the
27216 parameters customizable.
27218 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
27219 constructors. Return if the result value is null (as the error
27220 would have been flagged already by MemberLookupFinal)
27222 Do not allow instances of abstract classes or interfaces to be
27225 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
27226 We have to compare the assembly property here when dealing with
27227 FamANDAssem and Assembly access modifiers, because we might be
27228 creating an assembly from *modules* (that means that we are not
27229 getting TypeBuilders for types defined in other modules that are
27230 part of this assembly).
27232 (Method.Emit): If the method is marked abstract and has a body,
27235 (TypeContainer.DefineMembers): If both the defined member and the
27236 parent name match are methods, then do not emit any warnings: let
27237 the Method.Define routine take care of flagging warnings. But if
27238 there is a mismatch (method overrides something else, or method is
27239 overriwritten by something, then emit warning).
27241 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
27242 set to null, this means `do not check for the return type on the
27245 (Method.Define): set the return type for the method signature to
27246 null, so that we get methods with the same name and parameters and
27247 different return types. This is used to flag warning 114 (you are
27248 hiding a method, and you probably want to use the new/override
27251 * typemanager.cs (MemberLookup): Implemented proper access
27252 control, closing a long standing set of bug reports. The problem
27253 was that the Framework only has two bits: Public and NonPublic,
27254 and NonPublic includes private and protected methods, but we need
27255 to enforce the FamANDAssem, FamOrAssem and Family.
27257 2002-05-11 Miguel de Icaza <miguel@ximian.com>
27259 * statement.cs (GotoCase): Return true: Ammounts to giving up
27260 knowledge on whether we return or not, and letting the other case
27261 be responsible for it.
27263 2002-05-10 Miguel de Icaza <miguel@ximian.com>
27265 * driver.cs: Do not load directories for each file processed, only
27266 do it if there is a pattern.
27268 * ecore.cs: Report readonly assigns here as well, as we might have
27269 been resolved only by MemberAccess.
27271 (SimpleName.SimpleNameResolve): Also be useful for LValue
27272 resolution. We need this to propagate assign to local readonly variables
27274 * typemanager.cs: Use a ptrhashtable for the criteria, because we
27275 do not want to reuse potential criteria memory.
27277 * class.cs (MyEventBuilder): Set reflected_type;
27279 * ecore.cs (Constantify): Added support for constifying bools.
27281 (RootContext.LookupType): Added a cache for values looked up in
27282 the declaration space.
27284 * typemanager.cs (FindMembers): Now is a front-end to
27285 RealFindMembers, and provides a two-level hashtable-based cache to
27288 15% performance improvement: from 22.5 to 19.2 seconds.
27290 * expression.cs (IsParamsMethodApplicable): use foreach.
27291 (Invocation.DoResolve): ditto.
27292 (New.DoResolve): ditto.
27293 (ArrayCreation.DoResolve): ditto.
27295 * ecore.cs (FindMostEncompassingType): use foreach.
27297 * delegate.cs (NewDelegate.DoResolve): Use foreach
27299 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27300 (RemoveMethods): use foreach.
27302 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27303 nested foreach statements instead of for, and also break out of
27304 the inner loop once a match is found.
27306 (Invocation.OverloadResolve): Use foreach, simplify the code.
27308 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27310 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27311 we actually unwrap the expression to allow for extra information
27314 * expression.cs: Use Shr_Un on unsigned operations.
27316 2002-05-08 Ravi Pratap <ravi@ximian.com>
27318 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27319 applicable operators was not being considered correctly. This closes
27320 the bug Miguel reported.
27322 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27324 * attribute.cs: check that the type derives from System.Attribute
27325 and report the correct error in that case (moved the duplicate code to
27326 its own method, too).
27328 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27330 * attribute.cs: lookup attribute type name as the spec says: first the
27331 bare attribute name and then name + "Attribute" (nant compiles with
27332 mcs after this fix).
27334 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27336 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27337 Because of the way we parse things, we should try to see if a
27338 UIntConstant can fit in an integer.
27340 2002-05-07 Ravi Pratap <ravi@ximian.com>
27342 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27343 when we are in an explicit context.
27345 (ConvertReferenceExplicit): When converting from Iface type S to Class
27346 T make sure the rules are implemented as an OR.
27348 * parameter.cs (ParameterType): Make it a property for now although the
27349 purpose really isn't anything immediate.
27351 * expression.cs (Is*Applicable): Do better checking on the parameter type
27352 of a ref/out parameter. The ones from the system assemblies are already
27353 marked with the correct type so we don't need to do any correction.
27355 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27356 the object type is standard too so include that.
27358 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27360 * ecore.cs (StandardConversionExists): Augment with missing code:
27361 deal with IntConstant, LongConstants and Enumerations.
27363 * assign.cs: Report the error, instead of failing silently
27365 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27366 typecontainer that they are declared, because the
27367 typecontainer/namespace will have the list of using clauses that
27368 need to be applied.
27370 Assembly Attributes were escaping the normal registration
27373 (EmitCode): Apply attributes within an EmitContext that represents
27374 the container they were declared on.
27376 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27378 2002-05-06 Ravi Pratap <ravi@ximian.com>
27380 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27381 Revamp completely - make much cleaner as we now operate only
27384 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27385 to implement the logic detailed in the spec more correctly.
27387 (UserDefinedConversion): Update accordingly.
27389 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27391 * statement.cs: Return flow analysis information up.
27393 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27396 (token): Do not consume an extra character before calling
27399 2002-05-06 Piers Haken <piersh@friskit.com>
27401 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27403 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27405 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27406 EmitContext during the instance constructor initializer
27407 resolution, to stop access to instance variables.
27409 This is mandated by the spec, last paragraph of the `constructor
27410 initializers' section.
27412 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27414 * cs-parser.jay, class.cs (Accessor): new class used to represent
27415 an accessor (get or set). In the past we used `null' to represent
27416 a missing accessor. But this is ambiguous because there was no
27417 way to tell in abstract indexers/properties if one of them was
27420 Now there is a way of addressing that.
27422 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27423 instead of FindMembers.
27425 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27426 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27428 * attribute.cs: Treat indexers and properties as the same in terms
27429 of applying attributes
27431 * ecore.cs (FindMostEncompassedType): Use statically initialized
27432 EmptyExpressions()s like we do elsewhere to avoid creating useless
27433 objects (and we take this out of the tight loop).
27435 (GetConversionOperators): Move the code to extract the actual
27436 operators to a separate routine to clean things up.
27438 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27440 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27441 events are always registered FieldBuilders.
27443 * class.cs (FieldBase): New class shared by Fields
27445 * delegate.cs: If we are a toplevel delegate, use our full name.
27446 If we are a nested delegate, then only use our tail name.
27448 2002-05-02 Ravi Pratap <ravi@ximian.com>
27450 * expression.cs (IsApplicable): Ensure that we add the "&" to
27451 ref/out types before comparing it with the type of the argument.
27453 (IsParamsMethodApplicable): Ditto.
27455 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27458 * delegate.cs : Handle the case when we have more than one applicable
27459 method. Flag an error only when we finish checking all.
27461 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27463 * expression.cs: Add support for boolean static initializers.
27465 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27467 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27469 * parameter.cs (ComputeParameterTypes,
27470 ComputeAndDefineParameterTypes): Better error handling: now we
27471 clear the `types' cache if we fail during any of the type lookups.
27472 We also return the status code correctly to our caller
27474 * delegate.cs: If we fail to define a delegate, abort the extra
27477 * expression.cs (Binary.ResolveOperator): for
27478 operator==(object,object) and operator !=(object, object) we also
27479 have to verify that there is an implicit conversion from one to
27482 (ArrayAccess.DoResolve): Array Access can operate on
27485 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27487 * assign.cs (CompoundAssign): A new class used as a "flag" that
27488 the assignment actually is happening as part of a compound
27489 assignment operator.
27491 During compound assignment, a few new rules exist to enable things
27498 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27499 to the type of x) if y is implicitly convertible to the type of x,
27500 and the operator is a builtin operator and the return type of the
27501 operator is explicitly convertible to the type of x.
27503 * rootcontext.cs: Reset warning level to 2. 4 catches various
27504 "interesting" features in mcs, we must clean this up at some
27505 point, but currently am trying to kill other bugs ;-)
27507 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27508 in container classes as well.
27510 * expression.cs (Binary.ResolveOperator): Handle string case
27511 before anything else (as operator overloading does emit an error
27512 before doing anything else).
27514 This code could go away when we move to a table driven model, but
27515 i could not come up with a good plan last night.
27517 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27519 * typemanager.cs (CSharpName): reimplementation using regex.
27520 * class.cs: added null check for fields in Emit
27521 * rootcontext.cs: set warninglevel to 4
27523 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27525 * typemanager.cs (CSharpName): reimplemented with Lupus
27528 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27530 * statement.cs (If): correclty implement Resolve, because we were
27531 not catching sem errors in there. The same process is needed
27533 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27536 (Statement.Warning_DeadCodeFound): Factorize code.
27537 (While): Report dead code here too.
27539 (Statement): Added Resolve virtual method to allow
27540 for resolution split from the emit code.
27542 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27544 * statement.cs (EmitBoolExpression): No longer try to resolve the
27546 (MakeBoolean): New utility function that resolve, implicitly
27547 converts to boolean and tags the expression.
27550 (If, Do): Implement dead code elimination.
27551 (While): Implement loop inversion
27553 (Do, While, For, If): Resolve the expression prior to calling our
27556 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27559 - added method Report28 (warning: program has more than one entry point)
27560 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27561 - modified method Method.Define, the part at the end of the method
27563 * rootcontext.cs: added static public Location EntryPointLocation;
27565 * ../errors/cs0028.cs : Add test case for the above warning.
27568 - modified method CSharpName to allow arrays of primitive type to
27569 be printed nicely (e.g. instead of System.Int32[][] it now prints
27571 - added method CSharpSignature: returns the signature of a method
27572 in string format to be used in reporting errors, warnings, etc.
27574 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27577 2002-04-26 Ravi Pratap <ravi@ximian.com>
27579 * delegate.cs (Define): Fix extremely silly bug where I was
27580 setting the type of the 'object' parameter of the BeginInvoke
27581 method to System.IAsyncResult instead of System.Object ;-)
27583 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27585 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27588 (Constructor.Emit): return if we fail to initialize the
27589 constructor. Another door closed!
27591 * expression.cs (New.DoResolve): Improve error message (from -6 to
27592 1501). Use DeclaredOnly lookup to find the exact constructor.
27594 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27595 loop. This is useful.
27597 * cs-parser.jay: Adjust the default parameters so that destructors
27598 have the proper signature.
27600 2002-04-26 Martin Baulig <martin@gnome.org>
27602 * driver.cs (LoadAssembly): If `assembly' contains any characters
27603 which are only valid in path names and not in assembly names
27604 (currently slash, backslash and point), use Assembly.LoadFrom ()
27605 instead of Assembly.Load () on the `assembly' (before iteration
27606 over the link_paths).
27608 2002-04-26 Martin Baulig <martin@gnome.org>
27610 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27612 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27614 * class.cs (Property): use the new typemanager.MemberLookup
27616 (TypeContainer.MemberLookup): Implement using the
27617 TypeManager.MemberLookup now.
27619 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27620 and return MemberInfos, so that these can be used without an
27621 EmitContext (what we had before).
27623 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27625 * expression.cs: Fix the case where the argument to params if the
27626 type of the params. I omitted handling this before. Fixed
27628 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27630 * driver.cs: Call BootCorlib_PopulateCoreType
27632 * class.cs (Property.CheckBase): Check for properties only, not
27635 * interface.cs: Temporary hack: try/catch around the
27636 CustomAttributeBuilder, because I am getting an exception that I
27639 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27640 types whose definitions are required to be there (attributes are
27641 defined before standard types).
27643 Compute definitions as we boot the various types, as they are used
27644 immediately (value_type class will need object_type, but if we do
27645 not initialize object_type, we will pass a null, which will let
27646 the runtime pick the System.Object from the existing corlib, which
27647 is not what we want).
27649 2002-04-22 Patrik Torstensson <totte@labs2.com>
27651 * cs-tokenizer.cs: fixed a number of trim() issues.
27653 2002-04-22 Ravi Pratap <ravi@ximian.com>
27655 * expression.cs (Argument.Type): Ensure that we return the correct
27656 type when we have out or ref parameters [in which case we
27659 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27661 * class.cs (Property, Indexer): Allow extern modifier in there.
27663 * typemanager.cs (InitBaseTypes): Initializes object_type and
27664 value_type, since those will be used early on during the bootstrap
27665 process to compile corlib.
27667 (InitCoreTypes): Move code from here to InitBaseTypes.
27669 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27671 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27672 single-dimension arrays as using the ldlen opcode.
27674 Daniel Lewis discovered this optimization.
27676 * typemanager.cs: Add signature for System.Array::get_Length
27678 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27680 * statement.cs: report the error when the foreach does not apply to an
27681 array nor a collection.
27683 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27685 * expression.cs: Add implicit conversions to the operator ~.
27687 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27689 * typemanager.cs: Locate the decimal constructor.
27691 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27693 * attribute.cs: use the new property of TypeOf.
27694 * expression.cs: added 'get' property around typearg.
27696 These changes fix a build breaker reported by NickD. Is this the
27697 correct way to fix? If not, please, revert my changes and make it
27700 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27702 * attribute.cs: Add support for typeof in attribute invocations.
27703 I am not sure that this is right though.
27705 2002-04-14 Duncan Mak <duncan@ximian.com>
27707 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27708 Binary.Operator.Division case.
27710 2002-04-13 Ravi Pratap <ravi@ximian.com>
27712 * class.cs (DefineType): Ensure that we do a proper check on
27713 attribute types and also register it with the TypeManager.
27715 (TypeContainer.Targets): The default for attribute types is
27716 AttributeTargets.All.
27718 * attribute.cs (ApplyAttributes): Registering the attribute type
27719 is done elsewhere, not when we discover we have a Usage attribute.
27721 2002-04-12 Ravi Pratap <ravi@ximian.com>
27723 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27724 and get rid of is_delegate parameter.
27726 * everywhere : update.
27728 2002-04-12 Ravi Pratap <ravi@ximian.com>
27730 * cs-parser.jay (compilation_unit): Revamp completely to use
27731 some new ideas that I got from Rhys' grammar to solve the problems
27732 with assembly level attributes.
27734 (outer_declaration): New grammar production.
27736 (attribute_sections): Add.
27738 (opt_attributes): Base on attribute_sections
27740 (namespace_declaration): Allow opt_attributes to tackle the case
27741 when we have assembly level attributes - we are clever in this
27744 * attribute.cs (ApplyAttributes): Do not worry about assembly
27745 attributes in the non-global context.
27747 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27748 instead of SetGlobalAttributes.
27750 * class.cs, rootcontext.cs : Ensure we define and generate
27751 attribute types before anything else.
27753 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27754 and flag the new error -20 for the case when the attribute type
27755 does not have valid targets specified. csc does not catch this.
27757 * ../errors/errors.txt : update for error # -20
27759 2002-04-11 Ravi Pratap <ravi@ximian.com>
27761 * support.cs (InternalParameters.ParameterModifier): Do some null
27762 checking and return sane values.
27764 * class.cs (Method.Define): If we are a PInvoke method, ensure
27765 that we are static and extern. Report error # 601
27767 * ../errors/cs0601.cs : Add test case for the above error.
27769 2002-04-07 Ravi Pratap <ravi@ximian.com>
27771 * rootcontext.cs (attribute_types): We need to keep type of
27772 all attribute types separately and emit code for them first.
27774 (RegisterAttribute) : Implement.
27776 * class.cs (DefineType): Check if the current Type is a custom
27777 attribute type and register it accordingly.
27779 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27780 adding the first attribute twice and rename to
27782 (SetGlobalAttributes): this.
27784 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27787 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27788 if we are processing global arguments. Hmm, I am unsure of this.
27790 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27792 * expression.cs: added static array of strings to avoid calling
27793 Enum.ToString () for Operator in Binary. Significant recover of
27796 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27798 * class.cs (FindMembers): Allow the Builders of the various
27799 members to be null. If they are skip them. This only happens
27800 during the PInvoke declaration.
27802 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27804 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27805 failure, so we do not keep going afterwards.
27807 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27808 wanted to pass `false' as the `is_delegate' argument. If this is
27809 the case, why not use delegate_type == null to mean `is_delegate =
27810 false' and anything else as is_delegate = true.
27812 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27814 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27815 code for the section, not the beginning of the tests.
27817 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27819 * cfold.cs: Handle operator + (Enum x, Underlying x)
27821 * expression.cs (Binary): same. Warn about errors where we have
27822 Enum/Enum in operator + as well.
27824 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27827 - added support for switch(bool)
27828 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27829 - add TableSwitchEmit() to handle table-based switch statements
27831 2002-04-05 Ravi Pratap <ravi@ximian.com>
27833 * expression.cs (Invocation.OverloadResolve): Factor out code which
27834 does parameter compatibility checking with arguments so that we can
27835 re-use the code even from Delegate.VerifyApplicability
27837 (VerifyArgumentsCompat): Move above code here.
27839 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27840 and instead make a call to the above method.
27842 2002-03-31 Ravi Pratap <ravi@ximian.com>
27844 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27845 We use it to keep track of classes which are attribute types.
27847 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27849 * delegate.cs (Delegate.Define): Correctly define the types in the
27850 presence of fixed and array parameters.
27852 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27855 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27856 include NonPublic after the first iteration.
27858 * class.cs (Indexer.CheckBase): Only check if both parents are
27861 * cs-parser.jay (accessor_body): If empty, set to null.
27863 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27864 same code path here to resolve constants names that we did have in
27865 MemberAccess.DoResolve. There is too much code duplicated here.
27867 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27869 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27871 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27874 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27875 tokens, numbers and strings.
27877 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27880 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27881 asyncronous parameters and the regular parameters.
27883 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27884 specify the target directory.
27886 * expression.cs: (This.DoResolve): Simplify
27887 (As.Emit): Optimize, do not generate IsInst if the expression is
27888 always of the given type.
27890 (Is.DoResolve): Bug fix, we were reporting both always/never for
27893 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27894 creating too many unnecessary arrays.
27896 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27898 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27899 fields instead of rolling our own initializer. Takes care of all
27900 implicit conversions, and drops unnecessary static checks/argument.
27902 2002-03-31 Dick Porter <dick@ximian.com>
27904 * driver.cs: use the GetDirectories() return values properly, and
27905 use "/" as path separator.
27907 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27909 * expression.cs (Unary): Optimize - - expr into expr.
27910 (Binary): Optimize a + (-b) into a -b.
27912 * codegen.cs (CodeGen): Made all methods static.
27914 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27918 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27919 TypeBuilder property.
27921 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27924 * tree.cs: Removed the various RecordXXXX, and replaced with a
27925 single RecordDecl. Removed all the accessor methods, and just
27926 left a single access point Type
27928 * enum.cs: Rename DefineEnum to DefineType.
27930 * decl.cs: New abstract method `DefineType' used to unify the
27931 Defines for Enumerations, Interfaces, TypeContainers and
27934 (FindType): Moved LookupInterfaceOrClass here. Moved the
27935 LookupBaseClasses method that used to live in class.cs and
27936 interface.cs here, and renamed to FindType.
27938 * delegate.cs: Implement DefineType. Take advantage of the
27939 refactored pattern for locating the parent builder without taking
27940 the parent_builder argument (which we know does not work if we are
27941 nested, and triggering a toplevel definition).
27943 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27945 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27946 accessibility of a member has changed during override and report
27949 * class.cs (Method.Define, Property.Define): Only complain on
27950 overrides if the method is private, any other accessibility is
27951 fine (and since we just checked the permission is the same, we are
27954 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27955 and elif are processed always. The other pre-processing
27956 directives are only processed if we are "taking" the path
27958 2002-03-29 Martin Baulig <martin@gnome.org>
27960 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27961 current location is not Null.
27963 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27964 a separate method so we can profile it.
27966 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27967 `span.Seconds' are just seconds, but no minutes or hours.
27968 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27970 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27972 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27973 Remove the gratuitous set of Final:
27975 // If an interface implementation, then we can set Final.
27976 if (((flags & MethodAttributes.Abstract) == 0) &&
27977 implementing.DeclaringType.IsInterface)
27978 flags |= MethodAttributes.Final;
27980 I do not know what I was smoking when I used that.
27983 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27984 step into fixing the name resolution issues for delegates and
27985 unifying the toplevel name resolution.
27987 2002-03-28 Martin Baulig <martin@gnome.org>
27989 * class.cs (Method.Emit): If we have a symbol writer, call its
27990 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27991 tell it about the current method.
27993 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27994 writer that we're going to emit the first byte of IL code for a new
27995 statement (a new source line).
27996 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27997 EmitContext.Mark() before emitting any code.
27999 * location.cs (SymbolDocument): Return null when we're Null.
28001 * statement.cs (Statement): Moved the `Location loc' variable here.
28002 (Statement.EmitBoolExpression): If we have a symbol writer, call
28003 ec.Mark() before emitting any code to tell it that we're at the
28004 beginning of a new statement.
28005 (StatementExpression): Added `Location' argument to the constructor.
28006 (Block): Added public readonly variable `StartLocation' and public
28007 variable `EndLocation'. The latter is to be set using SetEndLocation().
28008 (Block): Added constructor which takes a start and end location.
28009 (Block.SetEndLocation): New method. This sets the end location.
28010 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
28011 local variables we create.
28012 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
28013 each statement and do also mark the begin and end of the block.
28015 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
28016 tell it the current lexer.Location, use Location.Null for the end of the
28018 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
28019 current block, set its end location using SetEndLocation().
28020 (statement_expression): StatementExpression constructor now takes the
28021 lexer.Location as additional argument.
28022 (for_statement, declare_local_variables): Likewise.
28023 (declare_local_variables): When creating a new implicit block, use the
28024 new Block constructor and pass it the lexer.Location.
28026 2002-03-28 Miguel de Icaza <miguel@ximian.com>
28028 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
28029 members also on the parent interfaces recursively.
28031 2002-03-27 Miguel de Icaza <miguel@ximian.com>
28033 * report.cs: Use new formats, since Gonzalo finished the missing
28036 * expression.cs (Binary.ResolveOperator): added missing operator|
28037 operator& and operator^ for bool/bool.
28039 * cs-parser.jay: CheckDef now takes a Location argument that is
28040 used to report errors more precisly (instead of reporting the end
28041 of a definition, we try to track something which is a lot closer
28042 to the source of the problem).
28044 * cs-tokenizer.cs: Track global token use, so we can properly flag
28045 the use of #define/#undef after the first token has been seen.
28047 Also, rename the reportXXXX to Error_DescriptiveName
28049 * decl.cs (DeclSpace.IsTopLevel): Move property here from
28050 TypeContainer, so that Enum and Interface can use this too.
28052 * class.cs (TypeContainer.LookupInterfaceOrClass,
28053 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
28054 `builder' argument. Typically this was used to pass the parent
28055 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
28058 The problem is that a nested class could trigger the definition of
28059 a toplevel class, and the builder would be obviously wrong in that
28062 So we drop this argument, and we compute dynamically the
28063 TypeBuilder/ModuleBuilder (the correct information was available
28064 to us anyways from DeclSpace.Parent)
28066 * interface.cs (Interface.DefineInterface): Drop builder
28067 parameter cleanup like class.cs
28069 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
28072 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
28075 (Try.Emit): Propagate the returns value from the statement.
28077 (Return.Emit): Even if we are leavning
28079 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
28081 * modifiers.cs: Fix the computation of MethodAttributes flags.
28083 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
28085 * driver.cs: allow compilation of files that start with '/'.
28086 Add a default case when checking the argument of --target.
28088 2002-03-25 Miguel de Icaza <miguel@ximian.com>
28090 * interface.cs: Implement the same search algorithm for types in
28091 the interface code.
28093 * delegate.cs: Do not allow multiple definition.
28095 * Recovered ChangeLog that got accidentally amputated
28097 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
28099 * rootcontext.cs: Load manually enum to allow core classes to
28100 contain enumerations.
28102 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
28103 Update to new static methods in TypeManager.
28105 * typemanager.cs (GetMethod, GetConstructor): Use our
28106 implementation of FindMembers to find the members, since during
28107 corlib compilation, the types are TypeBuilders and GetMethod and
28108 GetConstructor do not work.
28110 Make all methods in TypeManager static.
28112 (InitCodeHelpers): Split the functionality from
28113 the InitCodeTypes function.
28115 * driver.cs: Call InitCodeHelpers after we have populated the
28118 * cs-parser.jay (delegate_declaration): we did not used to compute
28119 the delegate name correctly for void delegates.
28121 2002-03-24 Miguel de Icaza <miguel@ximian.com>
28123 * rootcontext.cs (RootContext): Init the interface_resolve_order
28124 and type_container_resolve_order always.
28126 (ResolveCore, BootstrapCorlib_ResolveClass,
28127 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
28128 compiler when compiling with --nostdlib
28130 * class.cs (TypeContainer.DefineType): Check that our parent is
28131 not null. This test is most important when we are bootstraping
28134 * codegen.cs: Split out the symbol writing code.
28136 2002-03-25 Martin Baulig <martin@gnome.org>
28138 * driver.cs (-g): Made -g an alias for --debug.
28140 2002-03-24 Martin Baulig <martin@gnome.org>
28142 * codegen.cs (SymbolWriter): New public variable. Returns the
28143 current symbol writer.
28144 (CodeGen): Added `bool want_debugging_support' argument to the
28145 constructor. If true, tell the ModuleBuild that we want debugging
28146 support and ask it for the ISymbolWriter.
28147 (Save): If we have a symbol writer, call it's Close() method after
28148 saving the assembly.
28150 * driver.c (--debug): New command line argument to create a
28151 debugger information file.
28153 * location.cs (SymbolDocument): New public property. Returns an
28154 ISymbolDocumentWriter object for the current source file or null
28155 if we don't have a symbol writer.
28157 2002-03-21 Miguel de Icaza <miguel@ximian.com>
28159 * driver.cs (LoadAssembly): Correctly return when all the paths
28160 have been tried and not before.
28162 * statement.cs (Switch.Emit): return the actual coverage for this
28163 statement (returns/not-returns)
28165 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
28166 switch of the statement if we are the last switch section. That
28167 kills two problems: try/catch problems (we used to emit an empty
28168 nop at the end) and switch statements where all branches would
28171 2002-03-19 Miguel de Icaza <miguel@ximian.com>
28173 * driver.cs: Add default assemblies (the equivalent to the
28174 Microsoft CSC.RSP file)
28176 * cs-tokenizer.cs: When updating `cols and setting it to zero,
28177 also update tokens_seen and set it to false.
28179 * driver.cs: Implement --recurse for Mike.
28181 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
28182 correctly splitting out the paths.
28184 2002-03-18 Miguel de Icaza <miguel@ximian.com>
28186 * interface.cs (Interface.PopulateProperty): Instead of using
28187 `parent' as the declaration space for the set parameters, use
28190 * support.cs (InternalParameters): InternalParameters constructor
28191 takes a DeclSpace instead of a TypeContainer.
28193 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
28194 types are being initialized, load the address of it before calling
28197 (New): Provide a mechanism to disable the generation of local
28198 value type temporaries when the caller will be providing us with
28199 an address to store it.
28201 (ArrayCreation.EmitDynamicInitializers): Use it.
28203 2002-03-17 Miguel de Icaza <miguel@ximian.com>
28205 * expression.cs (Invocation.EmitArguments): Only probe for array
28206 property if there is more than one argument. Sorry about that.
28208 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
28209 empty param arrays.
28211 * class.cs (Method.LabelParameters): Fix incorrect code path that
28212 prevented the `ParamArrayAttribute' from being applied to the
28215 2002-03-16 Miguel de Icaza <miguel@ximian.com>
28217 * support.cs (ReflectionParameters): Correctly compute whether the
28218 last argument is a params array. Fixes the problem with
28221 * typemanager.cs: Make the assemblies array always be non-null
28222 (empty, but non-null)
28224 * tree.cs (RecordDecl): New function that abstracts the recording
28225 of names. This reports error 101, and provides a pointer to the
28226 previous declaration. Fixes a crash in the compiler.
28228 * cs-parser.jay (constructor_declaration): Update to new grammar,
28229 and provide a constructor_body that can be empty.
28231 2002-03-15 Miguel de Icaza <miguel@ximian.com>
28233 * driver.cs: Add support for --resources.
28235 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
28236 Make all types for the various array helper methods be integer.
28238 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
28239 CheckState to ConvCast.
28241 (ConvCast): Now it takes a `checked' state argument, to avoid
28242 depending on the emit context for the conversion, and just using
28243 the resolve time setting.
28245 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
28246 instead of Invocation.EmitArguments. We do not emit the original
28247 arguments, instead we emit those which have been converted to
28248 unsigned int expressions.
28250 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
28252 * codegen.cs: ditto.
28254 * expression.cs (LocalVariableReference): Drop the use of the
28255 Store function that depended on the variable index.
28257 * statement.cs (VariableInfo): Drop the `Idx' property from this
28258 class, as this is not taking into account the indexes for
28259 temporaries tat we generate during the execution, getting the
28262 * class.cs: First emit class initializers, then call the parent
28265 * expression.cs (Binary): Fix opcode emision.
28266 (UnaryMutator.EmitCode): Support checked code generation
28268 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
28269 matches for events for both the Static and Instance scans,
28270 pointing to the same element. Fix that.
28272 2002-03-14 Miguel de Icaza <miguel@ximian.com>
28274 * rootcontext.cs (ResolveTree): Always set the
28275 interface_resolve_order, because nested interfaces will be calling
28278 * class.cs (GetInterfaceOrClass): Track the same resolution
28279 process used by TypeManager.LookupType. This fixes the nested
28280 type lookups in class declarations (separate path from
28283 (TypeContainer.DefineType): Also define nested interfaces.
28284 (TypeContainer.RegisterOrder): New public function used to
28285 register the order in which child interfaces need to be closed.
28287 Nested interfaces need to be closed after their parents have been
28290 * interface.cs (InterfaceAttr): Put all the logic for computing
28291 the interface attribute here.
28293 (DefineInterface): Register our interface order with the
28294 RootContext or with the TypeContainer depending on the case.
28296 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28298 * cs-parser.jay: rework foreach statement to work with the new
28299 changes to the policy on SimpleNames.
28301 * report.cs: support Stacktrace on warnings as well.
28303 * makefile: drop --unsafe and /unsafe from the compile.
28305 2002-03-13 Ravi Pratap <ravi@ximian.com>
28307 * ecore.cs (StandardConversionExists): Modify to take an Expression
28308 as the first parameter. Ensure we do null -> reference type conversion
28311 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28312 temporary Expression objects.
28314 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28316 * interface.cs: workaround bug in method overloading resolution
28317 (there is already a bugzilla bug for it).
28319 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28321 We could also solve this problem by having a separate path for
28322 performing type lookups, instead of DoResolve, we could have a
28323 ResolveType entry point, and only participating pieces of the
28324 production (simplename, deref, array) would implement this.
28326 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28327 signal SimpleName to only resolve type names and not attempt to
28328 resolve anything else.
28330 * expression.cs (Cast): Set the flag.
28332 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28334 * class.cs: Only report 108 if there is no `new' modifier.
28336 * cs-parser.jay: rework foreach statement to work with the new
28337 changes to the policy on SimpleNames.
28339 * report.cs: support Stacktrace on warnings as well.
28341 * makefile: drop --unsafe and /unsafe from the compile.
28343 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28345 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28346 lookups here, instead of doing that at parse time. This means
28347 that our grammar will not introduce `LocalVariableReferences' as
28348 expressions at this point. That solves the problem of code like
28352 static void Main ()
28356 This is only half the fix. The full fix requires parameters to
28357 also be handled in this way.
28359 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28360 makes the use more obvious of the DeclSpace. The
28361 ec.TypeContainer.TypeBuilder is now only used to pull the
28362 TypeBuilder for it.
28364 My theory is that I can get rid of the TypeBuilder completely from
28365 the EmitContext, and have typecasts where it is used (from
28366 DeclSpace to where it matters).
28368 The only pending problem is that the code that implements Aliases
28369 is on TypeContainer, and probably should go in DeclSpace.
28371 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28372 lookups here, instead of doing that at parse time. This means
28373 that our grammar will not introduce `LocalVariableReferences' as
28374 expressions at this point. That solves the problem of code like
28378 static void Main ()
28382 This is only half the fix. The full fix requires parameters to
28383 also be handled in this way.
28385 * class.cs (Property.DefineMethod): When implementing an interface
28386 method, set newslot, when implementing an abstract method, do not
28387 set the flag (before we tried never setting it, or always setting
28388 it, which is the difference).
28389 (Indexer.DefineMethod): same.
28390 (Method.DefineMethod): same.
28392 * ecore.cs: Only set the status used flag if we get back a Field.
28394 * attribute.cs: Temporary hack, so Paolo can keep working.
28396 2002-03-08 Ravi Pratap <ravi@ximian.com>
28398 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28399 the unmanaged type in the case we have a MarshalAs attribute.
28401 (Resolve): Handle the case when we are parsing the special MarshalAs
28402 attribute [we need to store the unmanaged type to use later]
28404 * typemanager.cs (marshal_as_attr_type): Built in type for the
28405 MarshalAs Attribute.
28407 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28408 on parameters and accordingly set the marshalling info.
28410 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28412 * class.cs: Optimizing slightly by removing redundant code after
28413 we switched to the `NoTypes' return value.
28414 (Property.DefineMethod): use NoTypes here too.
28416 This fixes the bug I introduced in my last batch of changes.
28418 2002-03-05 Ravi Pratap <ravi@ximian.com>
28420 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28422 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28423 Enums since those are types too.
28425 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28427 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28428 thanks to a call during the lookup process.
28430 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28432 * statement.cs (Foreach): Lots of work to accomodate a particular
28433 kind of foreach statement that I had not kept in mind. It is
28434 possible to have foreachs on classes that provide a GetEnumerator
28435 method that return objects that implement the "pattern" for using
28436 a foreach, there is no need to support GetEnumerator
28439 This is needed to compile nant.
28441 * decl.cs: Only report 114 if the member is not `Finalize' and if
28442 the warning level is at least 2.
28444 * class.cs: Moved the compare function from Method to
28447 (MethodSignature.InheritableMemberSignatureCompare): Add new
28448 filter function that is used to extract inheritable methods from a
28451 (Method.Define): Use the new `inheritable_method_signature_filter'
28454 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28457 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28459 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28461 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28463 * expression.cs: Pass location information to
28464 ConvertImplicitStandard.
28466 * class.cs: Added debugging code to track return values from
28469 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28471 * expression.cs (Is.DoResolve): If either side of the `is' is an
28472 interface, do not flag the warning.
28474 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28477 * report.cs: Allow for --fatal to be used with --probe.
28479 * typemanager.cs (NoTypes): Move the definition for the empty Type
28482 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28484 (TypeContainer.DefineProxy): New function used to proxy to parent
28485 implementations when implementing interfaces.
28486 (TypeContainer.ParentImplements): used to lookup if our parent
28487 implements a public function that is required by an interface.
28488 (TypeContainer.VerifyPendingMethods): Hook this up.
28490 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28491 `modules' and `assemblies' arraylists into arrays. We only grow
28492 these are the very early start up of the program, so this improves
28493 the speedof LookupType (nicely measured).
28495 * expression.cs (MakeByteBlob): Replaced unsafe code with
28496 BitConverter, as suggested by Paolo.
28498 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28499 folding of string concatenation, but if either side is a string,
28500 and the other is not, then return null, and let the runtime use
28501 the concatenation on the string plus the object (using
28502 `Object.ToString').
28504 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28506 Constant Folding has been implemented now.
28508 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28509 the error instead on types that are not supported in one's
28512 * constant.cs (Constant and all children): New set of functions to
28513 perform implict and explicit conversions.
28515 * ecore.cs (EnumConstant): Implement the new functions to perform
28516 conversion by proxying to the child expression.
28518 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28519 own separate setting that can not be turned off from the command
28520 line using --unchecked or --checked and is only controlled using
28521 the checked/unchecked statements and expressions. This setting is
28522 used by the constant folder to flag errors.
28524 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28525 ConstantCheckState as well.
28527 During Resolve, they also have to flag the state, because the
28528 constant folder runs completely in the Resolve phase.
28530 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28533 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28535 * cfold.cs: New file, this file contains the constant folder.
28537 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28538 argument to track whether we are using the resulting address to
28539 load or store a value and provide better error messages.
28541 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28542 new AddressOf arguments.
28544 * statement.cs (Foreach.EmitCollectionForeach): Update
28546 * expression.cs (Argument.Emit): Call AddressOf with proper
28547 arguments to track usage.
28549 (New.DoEmit): Call AddressOf with new arguments.
28551 (Unary.Emit): Adjust AddressOf call.
28553 2002-03-01 Ravi Pratap <ravi@ximian.com>
28555 * cs-parser.jay (member_access): Change the case for pre-defined types
28556 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28559 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28562 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28563 essentially like methods and apply attributes like MethodImplOptions to them too.
28565 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28568 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28569 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28572 * Update code everywhere accordingly.
28574 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28576 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28578 2002-02-28 Ravi Pratap <ravi@ximian.com>
28580 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28581 try performing lookups against those instead of jumping straight into using
28582 the 'using' clauses.
28584 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28586 (LookupType): Perform lookups in implicit parents too.
28588 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28589 sequence as RootContext.LookupType.
28591 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28592 the various cases of namespace lookups into this method.
28594 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28596 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28597 in positional arguments)
28599 * class.cs (Operator): Update the AllowedModifiers to contain
28602 * cs-parser.jay: Update operator declaration to allow for the
28603 operator body to be empty.
28605 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28608 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28610 * class.cs (Method.Emit): Label parameters.
28612 * driver.cs: Return 1 or 0 as the program exit code.
28614 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28616 * expression.cs: Special case the `null' object when trying to
28617 auto-compute the type, as anything can be explicitly converted to
28620 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28621 spotting this Paolo.
28623 (Expression.ImplicitNumericConversion): Perform comparissions of
28624 the type using the underlying type in the case of an enumeration
28625 rather than using the enumeration type for the compare.
28627 Cope with the underlying == type case, which is not possible to
28630 (Expression.ConvertNumericExplicit): Perform comparissions of
28631 the type using the underlying type in the case of an enumeration
28632 rather than using the enumeration type for the compare.
28634 * driver.cs: If the user does not supply an extension, assume .exe
28636 * cs-parser.jay (if_statement): Rewrote so that we can track the
28637 location for the if statement.
28639 * expression.cs (Binary.ConstantFold): Only concat strings when
28640 the operation is "+", not everything ;-)
28642 * statement.cs (Statement.EmitBoolExpression): Take a location
28644 (If, While, Do): Track location.
28646 * expression.cs (Binary.ResolveOperator): In the object + string
28647 case, I was missing a call to ConvertImplicit
28649 2002-02-25 Ravi Pratap <ravi@ximian.com>
28651 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28652 Location arguments. Ensure we use RootContext.LookupType to do our work
28653 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28655 * interface.cs (PopulateMethod): Handle the type of the parameter being
28658 * expression.cs (Invocation.BetterFunction): Handle the case when we
28659 have a params method with no fixed arguments and a call is made with no
28662 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28664 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28665 the verbatim-string-literal
28667 * support.cs (InternalParameters.ParameterModifier): handle null
28669 (InternalParameters.ParameterType): ditto.
28671 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28672 duplicating the name of the variable parameter.
28673 (GetParameterByName): Fix bug where we were not looking up array
28674 paramters if they were the only present (thanks Paolo!).
28675 (GetParameterInfo): We only have an empty set of types if both
28676 fixed and array are set to null.
28677 (GetParameterInfo-idx): Handle FixedParameter == null
28679 * cs-parser.jay: Handle the case where there is no catch
28680 statements (missing null test).
28682 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28684 * driver.cs (MainDriver): Be conservative on our command line
28687 Catch DirectoryNotFoundException when calling GetFiles.
28689 (SplitPathAndPattern): Used to split the input specification into
28690 a path and a pattern that we can feed to Directory.GetFiles.
28692 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28694 * statement.cs (Fixed): Implement the last case of the Fixed
28695 statement (string handling).
28697 * expression.cs (StringPtr): New class used to return a char * to
28698 a string; Used by the Fixed statement.
28700 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28702 * expression.cs (Binary.ResolveOperator): Remove redundant
28703 MemberLookup pn parent type.
28704 Optimize union call, we do not need a union if the types are the same.
28705 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28708 Specialize the use of MemberLookup everywhere, instead of using
28709 the default settings.
28711 (StackAlloc): Implement stackalloc keyword.
28713 * cs-parser.jay: Add rule to parse stackalloc.
28715 * driver.cs: Handle /h, /help, /?
28717 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28718 before we supported unsafe code.
28720 * makefile: add --unsafe to the self compilation of mcs.
28722 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28724 * expression.cs (PointerArithmetic): New class that is used to
28725 perform pointer arithmetic.
28726 (Binary.Resolve): Handle pointer arithmetic
28727 Handle pointer comparission.
28728 (ArrayPtr): Utility expression class that is used to take the
28729 address of an array.
28731 (ElementAccess): Implement array access for pointers
28733 * statement.cs (Fixed): Implement fixed statement for arrays, we
28734 are missing one more case before we are done.
28736 * expression.cs (Indirection): Implement EmitAssign and set the
28737 ExprClass to Variable. This allows pointer dereferences to be
28738 treated as variables, and to have values assigned to them.
28740 * ecore.cs (Expression.StoreFromPtr): New utility function to
28741 store values dereferencing.
28743 2002-02-20 Ravi Pratap <ravi@ximian.com>
28745 * expression.cs (Binary.ResolveOperator): Ensure that we are
28746 not trying to operate on a void type - this fixes the reported
28749 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28750 the parent implementation is sealed.
28752 * ../errors/cs0239.cs : Add.
28754 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28756 * typemanager.cs (unverifiable_code_type): Corresponds to
28757 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28758 which have unsafe code in them.
28760 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28763 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28765 * cs-tokenizer.cs: Add support for @"litreal strings"
28767 Make tokenizer accept pre-processor directives
28768 on any column (remove the old C-like limitation).
28770 * rootcontext.cs (EmitCode): Emit any global attributes.
28771 (AddGlobalAttributes): Used to keep track of assembly attributes.
28773 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28775 * cs-parser.jay: Add support for global attributes.
28777 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28779 * expression.cs (Indirection): New helper class. Unary will
28780 create Indirection classes to be able to implement the
28781 IMemoryLocation interface on it.
28783 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28785 * cs-parser.jay (fixed_statement): reference the right statement.
28787 * statement.cs (Fixed.Emit): Finish implementing the fixed
28788 statement for the &x case.
28790 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28792 * class.cs (Property.Define, Method.Define): Remove newslot when
28795 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28796 wrong. NewSlot should only be used if the `new' keyword is present.
28798 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28799 locating our system dir. Sorry about this.
28801 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28803 * driver.cs (GetSystemDir): Compute correctly the location of our
28804 system assemblies. I was using the compiler directory instead of
28805 the library directory.
28807 2002-02-13 Ravi Pratap <ravi@ximian.com>
28809 * expression.cs (BetterFunction): Put back in what Miguel commented out
28810 since it is the correct fix. The problem is elsewhere ;-)
28812 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28813 parameters of the parms method are themselves compatible or not !
28815 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28816 to check that a class implements an interface before saying that an implicit
28817 conversion was allowed. Use ImplementsInterface to do the checking.
28819 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28821 * class.cs (Method.Define): Track whether we are an explicit
28822 implementation or not. And only call DefineMethodOverride if we
28823 are an explicit implementation.
28825 (Property.DefineMethod): Ditto.
28827 2002-02-11 Ravi Pratap <ravi@ximian.com>
28829 * expression.cs (BetterFunction): Catch hideous bug which was
28830 preventing us from detecting ambiguous calls due to implicit casts i.e
28833 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28835 * support.cs (Pair): Remove un-needed method. I figured why I was
28836 getting the error in cs-parser.jay, the variable in a foreach loop
28837 is readonly, and the compiler does not really treat this as a variable.
28839 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28840 instead of EQUALS in grammar.
28842 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28844 * expression.cs (Unary.DoResolve): Check whether the argument is
28847 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28849 * support.cs: Api for Pair to set a value. Despite the fact that
28850 the variables are public the MS C# compiler refuses to compile
28851 code that accesses the field if the variable is part of a foreach
28854 * statement.cs (Fixed): Begin implementation of the fixed
28857 (Block.AddVariable): Return the VariableInfo on success and null
28858 on failure instead of true/false.
28860 * cs-parser.jay (foreach): Catch errors on variables already
28861 defined (we were ignoring this value before) and properly unwind
28862 the block hierarchy
28864 (fixed_statement): grammar for the fixed statement.
28866 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28868 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28869 pointer types to be incretemented.
28871 (SizeOf): Implement.
28873 * cs-parser.jay (pointer_member_access): Implement
28874 expr->IDENTIFIER production.
28876 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28877 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28880 (Unary): Implement indirection.
28882 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28883 use in non-unsafe context).
28885 (SimpleName.DoResolve): Check for pointers in field access on safe
28888 (Expression.LoadFromPtr): Factor the load-indirect code in this
28889 function. This was duplicated in UnboxCast and ParameterReference
28891 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28893 * expression.cs (ComposedCast): report an error if a pointer cast
28894 is used in a safe region.
28896 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28897 pointer type casts in unsafe context.
28899 * codegen.cs (EmitContext): Set up IsUnsafe.
28901 * cs-parser.jay (non_expression_type): Add productions for pointer
28904 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28905 code. We should not use force into static mode if the method is
28906 not virtual. Fixes bug in MIS
28908 * statement.cs (Do.Emit, While.Emit, For.Emit,
28909 Statement.EmitBoolExpression): Add support to Do and While to
28910 propagate infinite loop as `I do return' semantics.
28912 Improve the For case to also test for boolean constants.
28914 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28915 to the list of attributes we can add.
28917 Remove `EmitContext' argument.
28919 * class.cs (Method.Define): Apply parameter attributes.
28920 (Constructor.Define): Apply parameter attributes.
28921 (MethodCore.LabelParameters): Move here the core of labeling
28924 * support.cs (ReflectionParameters.ParameterModifier,
28925 InternalParameters.ParameterModifier): Use IsByRef on the type and
28926 only return the OUT bit for these parameters instead of in/out/ref
28929 This is because I miss-understood things. The ParameterInfo.IsIn
28930 and IsOut represent whether the parameter has the [In] and [Out]
28933 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28935 * ecore.cs (FieldExpr.Emit): Release temporaries.
28937 * assign.cs (LocalTemporary.Release): new function.
28939 * codegen.cs (EmitContext.GetTemporaryStorage,
28940 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28941 temporary storage. Now we can "put back" localbuilders when we
28944 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28946 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28947 need to make a copy of the variable to generate verifiable code.
28949 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28951 * driver.cs: Compute dynamically the system directory.
28953 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28954 Slower, but more generally useful. Used by the abstract
28955 registering implementation.
28957 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28958 the rules for the special rule on Type/instances. First check if
28959 we have the same name, and if so, try that special static path
28960 rather than the instance path.
28962 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28964 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28967 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28968 Enum, ValueType, Delegate or Array for non-corlib compiles.
28970 * cs-tokenizer.cs: Catch long identifiers (645)
28972 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28975 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28976 fix, we were returning too early, so we were not registering
28977 pending methods from abstract classes.
28979 Do not register pending methods if the class is abstract.
28981 * expression.cs (Conditional.DoResolve): Report circular implicit
28982 conversions when we neecd to compute it for conditional
28985 (Is.DoResolve): If the expression is always of the provided type,
28986 flag warning 183. If the expression can not ever be of the
28987 provided type flag warning 184.
28989 * class.cs: Catch 169 as well.
28991 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28994 2002-01-18 Nick Drochak <ndrochak@gol.com>
28996 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28998 2002-01-17 Miguel de Icaza <miguel@ximian.com>
29000 * interface.cs: (PopulateMethod): Check for pointers being defined
29001 only if the unsafe context is active.
29002 (PopulateProperty): ditto.
29003 (PopulateIndexer): ditto.
29005 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
29006 specified. If pointers are present, make sure that they are
29007 present in an unsafe context.
29008 (Constructor, Constructor.Define): ditto.
29009 (Field, Field.Define): ditto.
29010 (Property, Property.Define): ditto.
29011 (Event, Event.Define): ditto.
29013 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
29014 hashtable if there are classes or structs defined.
29016 * expression.cs (LocalVariableReference.DoResolve): Simplify this
29017 code, as the constant resolution moved.
29019 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
29020 the metadata, so we can flag error 133.
29022 * decl.cs (MemberCore.UnsafeOK): New function to test that a
29023 pointer is being declared in an unsafe context.
29025 2002-01-16 Miguel de Icaza <miguel@ximian.com>
29027 * modifiers.cs (Modifiers.Check): Require a Location argument.
29028 Report error 227 for Unsafe use.
29030 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
29032 * statement.cs (For.Emit): If the test is null, then report that
29033 we do `return', as we wont reach anything afterwards.
29035 (Switch.SwitchGoverningType): Track the expression that matched
29038 * driver.cs: Allow negative numbers as an error code to flag.
29040 * cs-parser.jay: Handle 1551.
29042 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
29044 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29046 * cs-parser.jay: Report 1518 (type declaration can only contain
29047 class, struct, interface, enum or delegate)
29049 (switch_label): Report 1523 (keywords `case' or `default' must
29052 (opt_switch_sections): Report 1522 (empty switch)
29054 * driver.cs: Report 1515 (response file specified multiple times)
29055 Report 1516 (Source file specified multiple times).
29057 * expression.cs (Argument.Resolve): Signal 1510
29059 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
29060 access not allowed in static code)
29062 2002-01-11 Ravi Pratap <ravi@ximian.com>
29064 * typemanager.cs (IsPointerType): Utility method which we are going
29067 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
29068 the object type, so we take care of that.
29070 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
29072 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
29073 added to non-params parameters :-)
29075 * typemanager.cs (CSharpName): Include 'void' type too.
29077 (void_ptr_type): Include in the set of core types.
29079 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
29082 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
29085 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
29086 completely forgotten about it.
29088 2002-01-10 Ravi Pratap <ravi@ximian.com>
29090 * cs-parser.jay (pointer_type): Add. This begins our implementation
29091 of parsing rules for unsafe code.
29093 (unsafe_statement): Implement.
29095 (embedded_statement): Modify to include the above.
29097 * statement.cs (Unsafe): Implement new class for unsafe blocks.
29099 * codegen.cs (EmitContext.InUnsafe): Add. This determines
29100 if the current context is an unsafe one.
29102 * cs-parser.jay (local_variable_pointer_type): Since local variable types
29103 are handled differently, we need separate rules for them.
29105 (local_variable_declaration): Update to use local_variable_pointer_type
29106 to allow variable declarations of unmanaged pointer types.
29108 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
29109 in unsafe contexts.
29111 * ../errors/cs0214.cs : Add.
29113 2002-01-16 Nick Drochak <ndrochak@gol.com>
29115 * makefile: remove 'response' file when cleaning.
29117 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29119 * cs-parser.jay: Report 1524.
29121 2002-01-14 Miguel de Icaza <miguel@ximian.com>
29123 * typemanager.cs (RegisterMethod): drop checking if we have
29124 registered this from here
29126 2002-01-12 Miguel de Icaza <miguel@ximian.com>
29128 * class.cs (Method.EmitDestructor): Implement calling our base
29131 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
29132 value of InFinally.
29134 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
29135 this routine and will wrap the call in a try/catch block. Deal
29138 2002-01-11 Miguel de Icaza <miguel@ximian.com>
29140 * ecore.cs (Expression.MemberLookup): instead of taking a
29141 parameter `same_type' that was used to tell whether we could
29142 access private members we compute our containing type from the
29145 (FieldExpr): Added partial support for volatile fields. This does
29146 not work for volatile fields exposed from assemblies, as I can not
29147 figure out how to extract the modreq from it.
29149 Updated all the source files to use this.
29151 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
29152 because it is referenced by MemberLookup very often.
29154 2002-01-09 Ravi Pratap <ravi@ximian.com>
29156 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
29157 TypeBuilder.GetCustomAttributes to retrieve what we need.
29159 Get rid of redundant default_member_attr_type as this is the same as
29160 default_member_type which already exists.
29162 * interface.cs, attribute.cs : Update accordingly.
29164 2002-01-08 Miguel de Icaza <miguel@ximian.com>
29166 * typemanager.cs: Enable IndexerPropertyName again. It does not
29167 work for TYpeBuilders though. Ravi, can you please fix this?
29169 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
29171 * expression.cs (Argument.Emit): Handle the case of ref objects
29172 being passed to ref functions;
29174 (ParameterReference.EmitLoad): Loads the content of the pointer
29175 without dereferencing.
29177 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29179 * cs-tokenizer.cs: Implemented the pre-processing expressions.
29181 2002-01-08 Ravi Pratap <ravi@ximian.com>
29183 * class.cs (Indexer.DefineMethod): Incorporate the interface
29184 type in the name of the method if we are doing explicit interface
29187 * expression.cs (ConversionExists): Remove as it is completely obsolete.
29189 (BetterConversion): Fix extremely trivial bug where we were referring to
29190 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
29193 * ../errors/bug16.cs : Add although we have fixed it.
29195 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29197 * expression.cs (BaseIndexer): Begin implementation.
29199 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
29201 * cs-parser.jay (indexer_declarator): Use qualified_identifier
29202 production directly to remove a shift/reduce, and implement
29203 explicit interface implementation.
29205 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
29206 after a floating point suffix.
29208 * expression.cs (DoNumericPromotions): Improved the conversion for
29209 uint/uint. If we have a constant, we avoid doing a typecast to a
29212 * class.cs (Indexer): Implement explicit interface implementation
29215 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
29217 * class.cs: make the default instance constructor public and hidebysig.
29219 2001-01-03 Ravi Pratap <ravi@ximian.com>
29221 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
29222 so we can call it from elsewhere.
29224 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
29225 we emit it internally if the class has a defined indexer; otherwise the user
29226 emits it by decorating the class definition with the DefaultMemberAttribute.
29228 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
29229 attribute is not used on a type which defines an indexer.
29231 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
29232 character when we skip whitespace.
29234 * ../errors/cs0646.cs : Add.
29236 2002-01-03 Miguel de Icaza <miguel@ximian.com>
29238 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
29241 * makefile: Add practical target `mcs3.exe' which builds the third
29242 generation compiler.
29244 * expression.cs (New): Fix structures constructor calling.
29246 * class.cs (Property, Method, Indexer): Emit Final flag on the
29247 method if we are an interface implementation and we are not
29250 * ecore.cs (PropertyExpr): New public field `IsBase', tells
29251 whether this property is referencing a `base' method.
29253 * expression.cs (Invocation.EmitCall): take an extra argument:
29254 is_base, this is used to determine whether the `call' or
29255 `callvirt' opcode should be used.
29258 * delegate.cs: update EmitCall.
29260 * class.cs (Method.Define): Set NewSlot for the cases where we are
29261 not implementing an interface method.
29263 (Property.Define): ditto.
29265 2002-01-02 Miguel de Icaza <miguel@ximian.com>
29267 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
29268 'r'. Allows mcs to parse itself fully.
29270 2002-01-02 Ravi Pratap <ravi@ximian.com>
29272 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
29273 of the number of initializers that require the InitializeArray method.
29275 (CheckIndices): Store the Expression in all cases - not the plain value. Also
29276 update the above field where necessary.
29278 (MakeByteBlob): Update accordingly.
29280 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
29283 (EmitDynamicInitializers): Update in accordance with the new optimization.
29285 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
29286 same OpCode applies.
29288 * cs-parser.jay : Fix some glaring errors I introduced.
29290 2002-01-01 Ravi Pratap <ravi@ximian.com>
29292 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
29293 so that we can check for name clashes there too.
29295 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29296 for interface indexers.
29298 * interfaces.cs (Define): Emit the default member attribute.
29300 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29301 variable was being referred to while setting the value ;-)
29303 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29305 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29306 byte-by-byte information when we know the data is zero.
29308 Make the block always a multiple of 4, because
29309 DefineInitializedData has a bug.
29311 * assign.cs: Fix, we should assign from the temporary, not from
29314 * expression.cs (MakeByteBlob): Fix my incorrect code.
29316 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29318 * typemanager.cs (EnumToUnderlying): This function is used to get
29319 the underlying type from an enumeration, because it does not
29322 * constant.cs: Use the I4_S form for values between -128 and 127.
29324 * statement.cs (Block.LookupLabel): Looks up a label.
29325 (Block): Drop support for labeled blocks.
29327 (LabeledStatement): New kind of statement that represents a label
29330 (Goto): Finally implement this bad boy.
29332 * cs-parser.jay: Update to reflect new mechanism to implement
29335 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29337 * codegen.cs (EmitContext.This): a codegen property that keeps the
29338 a single instance of this instead of creating many different this
29341 * delegate.cs (Delegate.DoResolve): Update to use the property;
29343 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29345 * expression.cs (BaseAccess.DoResolve): Ditto.
29347 2001-12-29 Ravi Pratap <ravi@ximian.com>
29349 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29350 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29352 (InitCoreTypes): Update accordingly.
29354 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29355 so we can quickly store the state.
29357 (ApplyAttributes): Set the correct implementation flags
29358 for InternalCall methods.
29360 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29362 * expression.cs (EmitCall): if a method is not virtual, then do
29363 not use callvirt on it.
29365 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29366 user defined stuff) requires the use of stobj, which takes an
29367 address on the stack instead of an array and an index. So emit
29368 the Ldelema operation for it.
29370 (EmitStoreOpcode): Use stobj for valuetypes.
29372 (UnaryMutator.EmitCode): Use the right 1 value depending on
29373 whether we are dealing with int64/uint64, float or doubles.
29375 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29376 constructors that I implemented last night.
29378 (Constructor.IsDefault): Fix to work properly for static
29381 * cs-parser.jay (CheckDef): report method signature errors.
29382 Update error number 103 to be 132.
29384 * decl.cs: New AdditionResult enumeration value: MethodExists.
29385 Although we do this check for methods later on in the semantic
29386 analysis, catching repeated default constructors is so easy that
29387 we catch these here.
29389 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29392 (ParameterReference.EmitAssign, Emit): handle
29395 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29396 (ArrayAccess.EmitStoreOpcode): ditto.
29398 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29400 * expression.cs (MakeByteBlob): Complete all the missing types
29401 (uint, short, ushort, byte, sbyte)
29403 * class.cs: Only init instance field initializers on instance
29406 Rename `constructors' to instance_constructors.
29408 (TypeContainer.AddConstructor): Only add constructors to the list
29409 if it is not static.
29411 Make sure that we handle default_static_constructor independently
29412 everywhere where we handle instance_constructors
29414 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29416 * class.cs: Do not lookup or create a base initializer for a
29417 static constructor.
29419 (ConstructorInitializer.Resolve): use the proper type to lookup
29422 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29424 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29427 * decl.cs: CloseType is now an virtual method, the default
29428 implementation just closes this type.
29430 2001-12-28 Ravi Pratap <ravi@ximian.com>
29432 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29433 to PreserveSig by default. Also emit HideBySig on such methods.
29435 Basically, set the defaults to standard values.
29437 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29438 argument, if candidate is better, it can't be worse than the best !
29440 (Invocation): Re-write bits to differentiate between methods being
29441 applicable in their expanded form and their normal form - for params
29444 Get rid of use_standard everywhere as only standard conversions are allowed
29445 in overload resolution.
29447 More spec conformance.
29449 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29451 * driver.cs: Add --timestamp, to see where the compiler spends
29454 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29455 `this' in static code.
29457 (SimpleName.DoResolve): Implement in terms of a helper function
29458 that allows static-references to be passed upstream to
29461 (Expression.ResolveWithSimpleName): Resolve specially simple
29462 names when called by MemberAccess to implement the special
29465 (Expression.ImplicitReferenceConversion): Handle conversions from
29466 Null to reference types before others, as Null's type is
29469 * expression.cs (Invocation.EmitCall): Handle the special case of
29470 calling methods declared on a reference type from a ValueType
29471 (Base classes System.Object and System.Enum)
29473 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29474 the left hand side is a TypeExpr, not on every enumeration.
29476 (Binary.Resolve): If types are reference types, then do a cast to
29477 object on operators != and == of both arguments.
29479 * typemanager.cs (FindMembers): Extract instance and static
29480 members if requested.
29482 * interface.cs (PopulateProperty): Use void_type instead of null
29483 as the return type for the setter method.
29485 (PopulateIndexer): ditto.
29487 2001-12-27 Ravi Pratap <ravi@ximian.com>
29489 * support.cs (ReflectionParameters): Fix minor bug where we
29490 were examining the wrong parameter for the ParamArray attribute.
29492 Cope with requests for the type of the parameter at position
29493 greater than the params parameter's. We now return the element
29494 type of the params array as that makes more sense.
29496 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29497 accordingly as we no longer have to extract the element type
29500 (Invocation.OverloadResolve): Update.
29502 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29504 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29505 against IEnumerator, test whether the return value is a descendant
29506 of the IEnumerator interface.
29508 * class.cs (Indexer.Define): Use an auxiliary method to implement
29509 the other bits of the method definition. Begin support for
29510 explicit interface implementation.
29512 (Property.DefineMethod): Use TypeManager.void_type instead of null
29513 for an empty return value.
29515 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29517 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29518 dealing with a FieldExpr which is composed of a FieldBuilder, in
29519 the code path we did extract the constant, but we should have
29520 obtained the underlying value to be able to cast it (otherwise we
29521 end up in an infinite loop, this is what Ravi was running into).
29523 (ArrayCreation.UpdateIndices): Arrays might be empty.
29525 (MemberAccess.ResolveMemberAccess): Add support for section
29526 14.5.4.1 that deals with the special case of E.I when E is a type
29527 and something else, that I can be a reference to a static member.
29529 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29530 handle a particular array type to create byte blobs, it is just
29531 something we dont generate byteblobs for.
29533 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29536 * location.cs (Push): remove the key from the hashtable that we
29537 are about to add. This happens for empty files.
29539 * driver.cs: Dispose files after we have parsed them.
29541 (tokenize): new function that only runs the tokenizer on its
29542 input, for speed testing.
29544 2001-12-26 Ravi Pratap <ravi@ximian.com>
29546 * class.cs (Event.Define): Define the private field only if there
29547 are no accessors defined.
29549 * expression.cs (ResolveMemberAccess): If there is no associated
29550 field with the event, that means we have an event defined with its
29551 own accessors and we should flag error cs0070 since transforming
29552 ourselves into a field is not valid in that case.
29554 * ecore.cs (SimpleName.DoResolve): Same as above.
29556 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29557 and charset to sane values.
29559 2001-12-25 Ravi Pratap <ravi@ximian.com>
29561 * assign.cs (DoResolve): Perform check on events only if they
29562 are being accessed outside the declaring type.
29564 * cs-parser.jay (event_declarations): Update rules to correctly
29565 set the type of the implicit parameter etc.
29567 (add_accessor, remove_accessor): Set current local parameters.
29569 * expression.cs (Binary): For delegate addition and subtraction,
29570 cast the return value from the method into the appropriate delegate
29573 2001-12-24 Ravi Pratap <ravi@ximian.com>
29575 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29576 of these as the workaround is unnecessary.
29578 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29579 delegate data - none of that is needed at all.
29581 Re-write bits to extract the instance expression and the delegate method
29584 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29587 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29588 of attaching attributes instead of duplicating code everywhere.
29590 * everywhere : Update code to do attribute emission using the above method.
29592 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29594 * expression.cs (IsParamsMethodApplicable): if there are not
29595 parameters, return immediately.
29597 * ecore.cs: The 0 literal can be implicity converted to an enum
29600 (SimpleName.DoResolve): First lookup the type, then lookup the
29603 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29604 want to get its address. If the InstanceExpression is not
29605 addressable, store the result in a temporary variable, then get
29608 * codegen.cs: Only display 219 errors on warning level or above.
29610 * expression.cs (ArrayAccess): Make it implement the
29611 IMemoryLocation interface.
29613 (Binary.DoResolve): handle the operator == (object a, object b)
29614 and operator != (object a, object b) without incurring into a
29615 BoxedCast (because 5 != o should never be performed).
29617 Handle binary enumerator operators.
29619 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29620 value type, otherwise use Ldelem_ref.
29622 Use precomputed names;
29624 (AddressOf): Implement address of
29626 * cs-parser.jay (labeled_statement): Fix recursive block
29627 addition by reworking the production.
29629 * expression.cs (New.DoEmit): New has a special case:
29631 If we are dealing with a ValueType, we have a few
29632 situations to deal with:
29634 * The target of New is a ValueType variable, that is
29635 easy, we just pass this as the variable reference
29637 * The target of New is being passed as an argument,
29638 to a boxing operation or a function that takes a
29641 In this case, we need to create a temporary variable
29642 that is the argument of New.
29645 2001-12-23 Ravi Pratap <ravi@ximian.com>
29647 * rootcontext.cs (LookupType): Check that current_type is not null before
29648 going about looking at nested types.
29650 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29651 not implement the IAssignMethod interface any more.
29653 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29654 where we tranform them into FieldExprs if they are being resolved from within
29655 the declaring type.
29657 * ecore.cs (SimpleName.DoResolve): Do the same here.
29659 * assign.cs (DoResolve, Emit): Clean up code considerably.
29661 * ../errors/bug10.cs : Add.
29663 * ../errors/cs0070.cs : Add.
29665 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29667 * assign.cs : Get rid of EventIsLocal everywhere.
29669 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29671 * ecore.cs (ConvertIntLiteral): finished the implementation.
29673 * statement.cs (SwitchLabel): Convert the value we are using as a
29674 key before looking up the table.
29676 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29678 * codegen.cs (EmitTopBlock): Require a Location argument now.
29680 * cs-parser.jay (constructor_declarator): We need to setup
29681 current_local_parameters before we parse the
29682 opt_constructor_initializer, to allow the variables to be bound
29683 to the constructor arguments.
29685 * rootcontext.cs (LookupType): First lookup nested classes in our
29686 class and our parents before we go looking outside our class.
29688 * expression.cs (ConstantFold): Extract/debox the values at the
29691 * rootcontext.cs (EmitCode): Resolve the constants first before we
29692 resolve the types. This is not really needed, but it helps debugging.
29694 * statement.cs: report location.
29696 * cs-parser.jay: pass location to throw statement.
29698 * driver.cs: Small bug fix.
29700 * report.cs: Updated format to be 4-zero filled digits.
29702 2001-12-22 Ravi Pratap <ravi@ximian.com>
29704 * expression.cs (CheckIndices): Fix minor bug where the wrong
29705 variable was being referred to ;-)
29707 (DoEmit): Do not call EmitStaticInitializers when the
29708 underlying type is System.Object.
29710 2001-12-21 Ravi Pratap <ravi@ximian.com>
29712 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29713 and do the usual workaround for SRE.
29715 * class.cs (MyEventBuilder.EventType): New member to get at the type
29716 of the event, quickly.
29718 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29720 * assign.cs (Assign.DoResolve): Handle the case when the target
29721 is an EventExpr and perform the necessary checks.
29723 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29726 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29728 (EventExpr): Set the type in the constructor itself since we
29729 are meant to be born fully resolved.
29731 (EventExpr.Define): Revert code I wrote earlier.
29733 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29734 instance expression is null. The instance expression is a This in that case
29735 or a null, depending on whether it is a static method or not.
29737 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29738 refers to more than one method.
29740 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29741 and accordingly flag errors.
29743 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29745 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29747 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29749 * location.cs (ToString): Provide useful rutine.
29751 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29753 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29754 objects, return the actual integral boxed.
29756 * statement.cs (SwitchLabel): define an ILLabel for each
29759 (Switch.CheckSwitch): If the value is a Literal, extract
29760 the underlying literal.
29762 Also in the unused hashtable we had, add the SwitchLabel so we can
29763 quickly look this value up.
29765 * constant.cs: Implement a bunch of new constants. Rewrite
29766 Literal based on this. Made changes everywhere to adapt to this.
29768 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29769 dereferencing array only once, and also copes with enumrations.
29771 bytes are two bytes wide, not one.
29773 (Cast): Perform constant conversions.
29775 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29776 wrappers to the literals here.
29778 * expression.cs (DoNumericPromotions): long literals can converted
29779 to ulong implicity (this is taken care of elsewhere, but I was
29780 missing this spot).
29782 * ecore.cs (Expression.Literalize): Make the return type Literal,
29783 to improve type checking.
29785 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29787 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29789 * literal.cs: Revert code from ravi that checked the bounds. The
29790 bounds are sane by the definition of the type itself.
29792 * typemanager.cs: Fix implementation of ImplementsInterface. We
29793 need to actually look up in our parent hierarchy for interfaces
29796 * const.cs: Use the underlying type for enumerations
29798 * delegate.cs: Compute the basename for the delegate creation,
29799 that should fix the delegate test case, and restore the correct
29800 Type Lookup semantics in rootcontext
29802 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29803 referencing a nested type with the Reflection API is using the "+"
29806 * cs-parser.jay: Do not require EOF token at the end.
29808 2001-12-20 Ravi Pratap <ravi@ximian.com>
29810 * rootcontext.cs (LookupType): Concatenate type names with
29811 a '.' instead of a '+' The test suite passes again.
29813 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29814 field of the enumeration.
29816 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29817 the case when the member is an EventExpr.
29819 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29820 static has an associated instance expression.
29822 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29824 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29826 * class.cs (Event.Define): Register event and perform appropriate checks
29829 We define the Add and Remove methods even if the use provides none because
29830 in that case, we provide default implementations ourselves.
29832 Define a private field of the type of the event. This is done by the CSC compiler
29833 and we should be doing it too ;-)
29835 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29836 More methods we use in code we generate.
29838 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29841 (InitCoreTypes): Update accordingly for the above.
29843 * class.cs (Event.Emit): Generate code for default accessors that we provide
29845 (EmitDefaultMethod): Do the job in the above.
29847 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29850 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29852 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29853 builders even if we were missing one.
29855 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29856 pass the Basename as our class name instead of the Name. The
29857 basename will be correctly composed for us.
29859 * parameter.cs (Paramters): Now takes a Location argument.
29861 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29862 make all the code call directly LookupType in RootContext and take
29863 this chance to pass the Location information everywhere.
29865 * Everywhere: pass Location information.
29867 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29869 * class.cs (Constructor.Define): Updated way of detecting the
29870 length of the parameters.
29872 (TypeContainer.DefineType): Use basename as the type name for
29875 (TypeContainer.Define): Do not recursively define types here, as
29876 definition is taken care in order by the RootContext.
29878 * tree.cs: Keep track of namespaces in a per-file basis.
29880 * parameter.cs (Parameter.ComputeSignature): Update to use
29883 (Parameters.GetSignature): ditto.
29885 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29886 instead of a TypeContainer.
29888 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29889 resolve names. Because we need to be resolve in our context, not
29892 * driver.cs: Implement response files.
29894 * class.cs (TypeContainer.DefineType): If we are defined, do not
29895 redefine ourselves.
29897 (Event.Emit): Emit the code for add/remove handlers.
29898 (Event.Define): Save the MethodBuilders for add/remove.
29900 * typemanager.cs: Use pair here too.
29902 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29903 DictionaryEntry requires the first argument to be non-null.
29905 (enum_declaration): Compute full name for registering the
29908 (delegate_declaration): Instead of using
29909 formal_parameter_list, use opt_formal_parameter_list as the list
29912 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29913 (EventParsing): New property that controls whether `add' and
29914 `remove' are returned as tokens or identifiers (for events);
29916 2001-12-19 Ravi Pratap <ravi@ximian.com>
29918 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29919 use MyEventBuilder only and let it wrap the real builder for us.
29921 (MyEventBuilder): Revamp constructor etc.
29923 Implement all operations that we perform on EventBuilder in precisely the same
29926 (FindMembers): Update to use the EventBuilder member.
29928 (Event.Emit): Update accordingly.
29930 2001-12-18 Ravi Pratap <ravi@ximian.com>
29932 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29933 by calling the appropriate methods.
29935 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29938 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29940 2001-12-17 Ravi Pratap <ravi@ximian.com>
29942 * delegate.cs (Delegate.Populate): Check that the return type
29943 and various parameters types are indeed accessible.
29945 * class.cs (Constructor.Define): Same here.
29947 (Field.Define): Ditto.
29949 (Event.Define): Ditto.
29951 (Operator.Define): Check that the underlying Method defined itself
29952 correctly - so it's MethodBuilder should not be null.
29954 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29955 expression happens to be null.
29957 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29958 members but as of now we don't seem to be able to do anything really useful with it.
29960 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29961 not the EventBuilder.
29963 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29965 * cs-tokenizer.cs: Add support for defines.
29966 Add support for #if, #elif, #else, #endif
29968 (eval_var): evaluates a variable.
29969 (eval): stubbed for evaluating functions.
29971 * cs-parser.jay: Pass the defines information
29973 * driver.cs: Add --define command line option.
29975 * decl.cs: Move MemberCore here.
29977 Make it the base class for DeclSpace. This allows us to catch and
29978 report 108 and 109 for everything now.
29980 * class.cs (TypeContainer.Define): Extract all the members
29981 before populating and emit the warning 108 (new keyword required
29982 to override) instead of having each member implement this.
29984 (MemberCore.Define): New abstract method, we will be using this in
29985 the warning reporting engine in Populate.
29987 (Operator.Define): Adjust to new MemberCore protocol.
29989 * const.cs (Const): This does not derive from Expression, it is a
29990 temporary object we use to create fields, it is a MemberCore.
29992 * class.cs (Method.Define): Allow the entry point to be in a
29995 * driver.cs: Rewrite the argument handler to clean it up a bit.
29997 * rootcontext.cs: Made it just an auxiliary namespace feature by
29998 making everything static.
30000 * driver.cs: Adapt code to use RootContext type name instead of
30003 * delegate.cs: Remove RootContext argument.
30005 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
30008 * class.cs (Event.Define): The lookup can fail.
30010 * cs-tokenizer.cs: Begin implementation of pre-procesor.
30012 * expression.cs: Resolve the this instance before invoking the code.
30014 2001-12-17 Miguel de Icaza <miguel@ximian.com>
30016 * cs-parser.jay: Add a production in element_access that allows
30017 the thing to become a "type" reference. This way we can parse
30018 things like "(string [])" as a type.
30020 Note that this still does not handle the more complex rules of
30024 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
30026 * ecore.cs: (CopyNewMethods): new utility function used to
30027 assemble the list of methods from running FindMembers.
30029 (MemberLookup): Rework FindMembers so that
30031 2001-12-16 Miguel de Icaza <miguel@ximian.com>
30033 * class.cs (TypeContainer): Remove Delegates who fail to be
30036 * delegate.cs (Populate): Verify that we dont get null return
30037 values. TODO: Check for AsAccessible.
30039 * cs-parser.jay: Use basename to emit error 574 (destructor should
30040 have the same name as container class), not the full name.
30042 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
30043 possible representation.
30045 Also implements integer type suffixes U and L.
30047 2001-12-15 Miguel de Icaza <miguel@ximian.com>
30049 * expression.cs (ArrayCreation.DoResolve): We need to do the
30050 argument resolution *always*.
30052 * decl.cs: Make this hold the namespace. Hold the root context as
30054 (LookupType): Move here.
30056 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
30058 * location.cs (Row, Name): Fixed the code, it was always returning
30059 references to the first file.
30061 * interface.cs: Register properties defined through interfaces.
30063 * driver.cs: Add support for globbing on the command line
30065 * class.cs (Field): Make it derive from MemberCore as well.
30068 2001-12-15 Ravi Pratap <ravi@ximian.com>
30070 * class.cs (Event::Define): Check that the type of the event is a delegate
30071 type else flag error #66.
30073 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
30076 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
30077 values of EntryPoint, CharSet etc etc.
30079 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
30081 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
30082 be null and we should ignore this. I am not sure if this is really clean. Apparently,
30083 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
30084 which needs this to do its work.
30086 * ../errors/cs0066.cs : Add.
30088 2001-12-14 Miguel de Icaza <miguel@ximian.com>
30090 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
30093 * class.cs: (MethodSignature.MethodSignature): Removed hack that
30094 clears out the parameters field.
30095 (MemberSignatureCompare): Cleanup
30097 (MemberCore): New base class used to share code between MethodCore
30100 (RegisterRequiredImplementations) BindingFlags.Public requires
30101 either BindingFlags.Instace or Static. Use instance here.
30103 (Property): Refactored code to cope better with the full spec.
30105 * parameter.cs (GetParameterInfo): Return an empty array instead
30108 * class.cs (Property): Abstract or extern properties have no bodies.
30110 * parameter.cs (GetParameterInfo): return a zero-sized array.
30112 * class.cs (TypeContainer.MethodModifiersValid): Move all the
30113 method modifier validation to the typecontainer so we can reuse
30114 this on properties.
30116 (MethodCore.ParameterTypes): return an empty sized array of types.
30118 (Property.Define): Test property modifier validity.
30120 Add tests for sealed/override too.
30122 (Method.Emit): abstract or extern methods have no bodies.
30124 2001-12-14 Ravi Pratap <ravi@ximian.com>
30126 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
30129 (Method::Define, ::Emit): Modify accordingly.
30131 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
30133 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
30135 * makefile: Pass in /unsafe.
30137 2001-12-13 Miguel de Icaza <miguel@ximian.com>
30139 * class.cs (MakeKey): Kill routine.
30141 * class.cs (TypeContainer.Define): Correctly define explicit
30142 method implementations (they require the full interface name plus
30145 * typemanager.cs: Deply the PtrHashtable here and stop using the
30146 lame keys. Things work so much better.
30148 This of course broke everyone who depended on `RegisterMethod' to
30149 do the `test for existance' test. This has to be done elsewhere.
30151 * support.cs (PtrHashtable): A hashtable that avoid comparing with
30152 the object stupid Equals method (because, that like fails all over
30153 the place). We still do not use it.
30155 * class.cs (TypeContainer.SetRequiredInterface,
30156 TypeContainer.RequireMethods): Killed these two routines and moved
30157 all the functionality to RegisterRequiredImplementations.
30159 (TypeContainer.RegisterRequiredImplementations): This routine now
30160 registers all the implementations required in an array for the
30161 interfaces and abstract methods. We use an array of structures
30162 which can be computed ahead of time to reduce memory usage and we
30163 also assume that lookups are cheap as most classes will not
30164 implement too many interfaces.
30166 We also avoid creating too many MethodSignatures.
30168 (TypeContainer.IsInterfaceMethod): Update and optionally does not
30169 clear the "pending" bit if we find that there are problems with
30172 (TypeContainer.VerifyPendingMethods): Update to report errors of
30173 methods that look like implementations but are not.
30175 (TypeContainer.Define): Add support for explicit interface method
30178 2001-12-12 Miguel de Icaza <miguel@ximian.com>
30180 * typemanager.cs: Keep track of the parameters here instead of
30181 being a feature of the TypeContainer.
30183 * class.cs: Drop the registration of parameters here, as
30184 InterfaceMethods are also interface declarations.
30186 * delegate.cs: Register methods with the TypeManager not only with
30187 the TypeContainer. This code was buggy.
30189 * interface.cs: Full registation here.
30191 2001-12-11 Miguel de Icaza <miguel@ximian.com>
30193 * expression.cs: Remove reducer for binary expressions, it can not
30196 * const.cs: Put here the code that used to go into constant.cs
30198 * constant.cs: Put here the code for constants, this is a new base
30199 class for Literals.
30201 * literal.cs: Make Literal derive from Constant.
30203 2001-12-09 Miguel de Icaza <miguel@ximian.com>
30205 * statement.cs (Return.Emit): Report error 157 if the user
30206 attempts to return from a finally block.
30208 (Return.Emit): Instead of emitting a return, jump to the end of
30211 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
30212 LocalBuilder to store the result of the function. ReturnLabel is
30213 the target where we jump.
30216 2001-12-09 Radek Doulik <rodo@ximian.com>
30218 * cs-parser.jay: remember alias in current namespace
30220 * ecore.cs (SimpleName::DoResolve): use aliases for types or
30223 * class.cs (LookupAlias): lookup alias in my_namespace
30225 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
30227 (LookupAlias): lookup alias in this and if needed in parent
30230 2001-12-08 Miguel de Icaza <miguel@ximian.com>
30234 * rootcontext.cs: (ModuleBuilder) Made static, first step into
30235 making things static. I need this to avoid passing the
30236 TypeContainer when calling ParameterType.
30238 * support.cs (InternalParameters.ParameterType): Remove ugly hack
30239 that did string manipulation to compute the type and then call
30240 GetType. Use Parameter.ParameterType instead.
30242 * cs-tokenizer.cs: Consume the suffix for floating values.
30244 * expression.cs (ParameterReference): figure out whether this is a
30245 reference parameter or not. Kill an extra variable by computing
30246 the arg_idx during emission.
30248 * parameter.cs (Parameters.GetParameterInfo): New overloaded
30249 function that returns whether a parameter is an out/ref value or not.
30251 (Parameter.ParameterType): The type of the parameter (base,
30252 without ref/out applied).
30254 (Parameter.Resolve): Perform resolution here.
30255 (Parameter.ExternalType): The full type (with ref/out applied).
30257 * statement.cs (Using.Emit, Using.EmitExpression): Implement
30258 support for expressions on the using statement.
30260 2001-12-07 Miguel de Icaza <miguel@ximian.com>
30262 * statement.cs (Using.EmitLocalVariableDecls): Split the
30263 localvariable handling of the using statement.
30265 (Block.EmitMeta): Keep track of variable count across blocks. We
30266 were reusing slots on separate branches of blocks.
30268 (Try.Emit): Emit the general code block, we were not emitting it.
30270 Check the type of the declaration to be an IDisposable or
30271 something that can be implicity converted to it.
30273 Emit conversions if required.
30275 * ecore.cs (EmptyExpression): New utility class.
30276 (Expression.ImplicitConversionExists): New utility function.
30278 2001-12-06 Miguel de Icaza <miguel@ximian.com>
30280 * statement.cs (Using): Implement.
30282 * expression.cs (LocalVariableReference): Support read only variables.
30284 * statement.cs: Remove the explicit emit for the Leave opcode.
30285 (VariableInfo): Add a readonly field.
30287 2001-12-05 Miguel de Icaza <miguel@ximian.com>
30289 * ecore.cs (ConvCast): new class used to encapsulate the various
30290 explicit integer conversions that works in both checked and
30291 unchecked contexts.
30293 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30294 properly generate the overflow opcodes.
30296 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30298 * statement.cs: The correct type for the EmptyExpression is the
30299 element_type, not the variable type. Ravi pointed this out.
30301 2001-12-04 Ravi Pratap <ravi@ximian.com>
30303 * class.cs (Method::Define): Handle PInvoke methods specially
30304 by using DefinePInvokeMethod instead of the usual one.
30306 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30307 above to do the task of extracting information and defining the method.
30309 2001-12-04 Ravi Pratap <ravi@ximian.com>
30311 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30312 of the condition for string type.
30314 (Emit): Move that here.
30316 (ArrayCreation::CheckIndices): Keep string literals in their expression
30319 (EmitDynamicInitializers): Handle strings appropriately.
30321 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30323 * codegen.cs (EmitContext): Replace multiple variables with a
30324 single pointer to the current Switch statement.
30326 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30329 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30333 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30336 (Foreach.Emit): Foreach on arrays was not setting
30337 up the loop variables (for break/continue).
30339 (GotoCase): Semi-implented.
30341 2001-12-03 Ravi Pratap <ravi@ximian.com>
30343 * attribute.cs (CheckAttribute): Handle system attributes by using
30344 Attribute.GetAttributes to examine information we need.
30346 (GetValidPlaces): Same here.
30348 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30350 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30352 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30354 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30356 (Method::Emit): Handle the case when we are a PInvoke method.
30358 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30360 * expression.cs: Use ResolveWithSimpleName on compound names.
30362 2001-12-02 Ravi Pratap <ravi@ximian.com>
30364 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30365 before trying to reduce it.
30367 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30369 * constant.cs (LookupConstantValue): Implement.
30371 (EmitConstant): Use the above in emitting the constant.
30373 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30374 that are user-defined by doing a LookupConstantValue on them.
30376 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30379 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30381 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30383 (BaseAccess.DoResolve): Implement.
30385 (MemberAccess.DoResolve): Split this routine into a
30386 ResolveMemberAccess routine that can be used independently
30388 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30390 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30391 As that share bits of the implementation. Is returns a boolean,
30392 while As returns the Type that is being probed.
30394 2001-12-01 Ravi Pratap <ravi@ximian.com>
30396 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30397 instead of a Literal - much easier.
30399 (EnumInTransit): Remove - utterly useless :-)
30401 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30403 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30405 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30406 chain when we have no associated expression.
30408 2001-11-30 Ravi Pratap <ravi@ximian.com>
30410 * constant.cs (Define): Use Location while reporting the errror.
30412 Also emit a warning when 'new' is used and there is no inherited
30415 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30418 (LookupEnumValue): Implement to lookup an enum member's value and define it
30421 (Populate): Re-write accordingly to use the above routine.
30423 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30425 * expression.cs (This): Fix prototype for DoResolveLValue to
30426 override the base class DoResolveLValue.
30428 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30431 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30432 (we need to load the address of the field here). This fixes
30435 (FieldExpr.DoResolveLValue): Call the DoResolve
30436 function to initialize the Instance expression.
30438 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30439 correctly the GetEnumerator operation on a value type.
30441 * cs-parser.jay: Add more simple parsing error catches.
30443 * statement.cs (Switch): Add support for string switches.
30444 Handle null specially.
30446 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30448 2001-11-28 Ravi Pratap <ravi@ximian.com>
30450 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30452 (declare_local_constant): New helper function.
30454 * statement.cs (AddConstant): Keep a separate record of constants
30456 (IsConstant): Implement to determine if a variable is a constant.
30458 (GetConstantExpression): Implement.
30460 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30462 * statement.cs (IsVariableDefined): Re-write.
30464 2001-11-27 Ravi Pratap <ravi@ximian.com>
30466 * class.cs (TypeContainer::FindMembers): Look for constants
30467 in the case when we are looking for MemberTypes.Field
30469 * expression.cs (MemberAccess::DoResolve): Check that in the
30470 case we are a FieldExpr and a Literal, we are not being accessed
30471 by an instance reference.
30473 * cs-parser.jay (local_constant_declaration): Implement.
30475 (declaration_statement): Implement for constant declarations.
30477 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30479 * statement.cs (Switch): Catch double defaults.
30481 (Switch): More work on the switch() statement
30482 implementation. It works for integral values now, need to finish
30486 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30488 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30489 integer literals into other integer literals. To be used by
30492 2001-11-24 Ravi Pratap <ravi@ximian.com>
30494 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30497 (EmitDynamicInitializers): Cope with the above since we extract data
30498 directly from ArrayData now.
30500 (ExpectInitializers): Keep track of whether initializers are mandatory
30503 (Bounds): Make it a hashtable to prevent the same dimension being
30504 recorded for every element in that dimension.
30506 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30509 Also fix bug which was causing the indices to be emitted in the reverse
30512 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30514 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30515 unfinished. They do not work, because the underlying code is
30518 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30520 * cs-parser.jay: Remove bogus fixme.
30522 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30523 on Switch statement.
30525 2001-11-23 Ravi Pratap <ravi@ximian.com>
30527 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30530 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30531 parameter. Apparently, any expression is allowed.
30533 (ValidateInitializers): Update accordingly.
30535 (CheckIndices): Fix some tricky bugs thanks to recursion.
30537 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30538 I was being completely brain-dead.
30540 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30541 and re-write acordingly.
30543 (DelegateInvocation): Re-write accordingly.
30545 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30547 (MakeByteBlob): Handle types more correctly.
30549 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30550 initialization from expressions but it is incomplete because I am a complete
30553 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30555 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30556 on If. Basically, we have to return `true' (ie, we do return to
30557 our caller) only if both branches of the if return.
30559 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30560 short-circuit operators, handle them as short circuit operators.
30562 (Cast.DoResolve): Resolve type.
30563 (Cast.Cast): Take an expression as the target type.
30565 * cs-parser.jay (cast_expression): Remove old hack that only
30566 allowed a limited set of types to be handled. Now we take a
30567 unary_expression and we resolve to a type during semantic
30570 Use the grammar productions from Rhys to handle casts (this is
30571 not complete like Rhys syntax yet, we fail to handle that corner
30572 case that C# has regarding (-x), but we will get there.
30574 2001-11-22 Ravi Pratap <ravi@ximian.com>
30576 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30577 field which is an array type.
30579 * cs-parser.jay (declare_local_variables): Support array initialization too.
30581 * typemanager.cs (MakeKey): Implement.
30583 (everywhere): Use the above appropriately.
30585 * cs-parser.jay (for_statement): Update for array initialization while
30586 declaring variables.
30588 * ecore.cs : The error message was correct, it's the variable's names that
30589 were misleading ;-) Make the code more readable.
30591 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30592 the correct type etc.
30594 (ConvertExplicit): Handle Enum types by examining the underlying type.
30596 2001-11-21 Ravi Pratap <ravi@ximian.com>
30598 * parameter.cs (GetCallingConvention): Always return
30599 CallingConventions.Standard for now.
30601 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30603 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30604 and `r' after calling DoNumericPromotions.
30606 * ecore.cs: Fix error message (the types were in the wrong order).
30608 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30609 BindingFlags.Instance as well
30611 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30612 implicit int literal conversion in an empty cast so that we
30613 propagate the right type upstream.
30615 (UnboxCast): new class used to unbox value types.
30616 (Expression.ConvertExplicit): Add explicit type conversions done
30619 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30620 the target type before applying the implicit LongLiterals to ULong
30623 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30625 * cs-parser.jay (for_statement): Reworked the way For works: now
30626 we declare manually any variables that are introduced in
30627 for_initializer to solve the problem of having out-of-band code
30628 emition (that is what got for broken).
30630 (declaration_statement): Perform the actual variable declaration
30631 that used to be done in local_variable_declaration here.
30633 (local_variable_declaration): Do not declare anything, just pass
30634 the information on a DictionaryEntry
30636 2001-11-20 Ravi Pratap <ravi@ximian.com>
30638 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30639 re-write of the logic to now make it recursive.
30641 (UpdateIndices): Re-write accordingly.
30643 Store element data in a separate ArrayData list in the above methods.
30645 (MakeByteBlob): Implement to dump the array data into a byte array.
30647 2001-11-19 Ravi Pratap <ravi@ximian.com>
30649 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30652 * constant.cs (Define): Implement.
30654 (EmitConstant): Re-write fully.
30656 Pass in location info.
30658 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30661 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30662 DictionaryEntry since we need location info too.
30664 (constant_declaration): Update accordingly.
30666 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30667 code into another method : UpdateIndices.
30669 2001-11-18 Ravi Pratap <ravi@ximian.com>
30671 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30672 some type checking etc.
30674 2001-11-17 Ravi Pratap <ravi@ximian.com>
30676 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30677 bits to provide dimension info if the user skips doing that.
30679 Update second constructor to store the rank correctly.
30681 2001-11-16 Ravi Pratap <ravi@ximian.com>
30683 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30684 and try to implement.
30686 * ../errors/cs0150.cs : Add.
30688 * ../errors/cs0178.cs : Add.
30690 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30692 * statement.cs: Implement foreach on multi-dimensional arrays.
30694 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30695 name of the params argument.
30697 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30698 initializing the array.
30700 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30701 we can use this elsewhere.
30703 * statement.cs: Finish implementation of foreach for single
30706 * cs-parser.jay: Use an out-of-band stack to pass information
30707 around, I wonder why I need this.
30709 foreach_block: Make the new foreach_block the current_block.
30711 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30712 function used to return a static Parameters structure. Used for
30713 empty parameters, as those are created very frequently.
30715 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30717 2001-11-15 Ravi Pratap <ravi@ximian.com>
30719 * interface.cs : Default modifier is private, not public. The
30720 make verify test passes again.
30722 2001-11-15 Ravi Pratap <ravi@ximian.com>
30724 * support.cs (ReflectionParameters): Fix logic to determine
30725 whether the last parameter is a params one. Test 9 passes again.
30727 * delegate.cs (Populate): Register the builders we define with
30728 RegisterParameterForBuilder. Test 19 passes again.
30730 * cs-parser.jay (property_declaration): Reference $6 instead
30731 of $$ to get at the location.
30733 (indexer_declaration): Similar stuff.
30735 (attribute): Ditto.
30737 * class.cs (Property): Register parameters for the Get and Set methods
30738 if they exist. Test 23 passes again.
30740 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30741 call to EmitArguments as we are sure there aren't any params arguments.
30742 Test 32 passes again.
30744 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30745 IndexOutOfRangeException.
30747 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30748 Test 33 now passes again.
30750 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30752 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30753 broke a bunch of things. Will have to come up with a better way
30754 of tracking locations.
30756 * statement.cs: Implemented foreach for single dimension arrays.
30758 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30760 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30761 an error. This removes the lookup from the critical path.
30763 * cs-parser.jay: Removed use of temporary_loc, which is completely
30766 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30768 * support.cs (ReflectionParameters.ParameterModifier): Report
30769 whether the argument is a PARAMS argument or not.
30771 * class.cs: Set the attribute `ParamArrayAttribute' on the
30772 parameter argument.
30774 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30775 and cons_param_array_attribute (ConstructorInfo for
30776 ParamArrayAttribute).,
30778 * codegen.cs: Emit the return using the `Return' statement, that
30779 way we can report the error correctly for missing return values.
30781 * class.cs (Method.Emit): Clean up.
30783 * expression.cs (Argument.Resolve): Take another argument: the
30784 location where this argument is used. Notice that this is not
30785 part of the "Argument" class as to reduce the size of the
30786 structure (we know the approximate location anyways).
30788 Test if the argument is a variable-reference, if not, then
30789 complain with a 206.
30791 (Argument.Emit): Emit addresses of variables.
30793 (Argument.FullDesc): Simplify.
30795 (Invocation.DoResolve): Update for Argument.Resolve.
30797 (ElementAccess.DoResolve): ditto.
30799 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30800 method should be virtual, as this method is always virtual.
30802 (NewDelegate.DoResolve): Update for Argument.Resolve.
30804 * class.cs (ConstructorInitializer.DoResolve): ditto.
30806 * attribute.cs (Attribute.Resolve): ditto.
30808 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30810 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30812 * expression.cs (ParameterReference): Drop IStackStorage and implement
30813 IAssignMethod instead.
30815 (LocalVariableReference): ditto.
30817 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30818 IAssignMethod instead.
30820 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30822 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30823 enumerations that are used in heavily used structures derive from
30824 byte in a laughable and pathetic attempt to reduce memory usage.
30825 This is the kind of pre-optimzations that you should not do at
30826 home without adult supervision.
30828 * expression.cs (UnaryMutator): New class, used to handle ++ and
30829 -- separatedly from the other unary operators. Cleans up the
30830 code, and kills the ExpressionStatement dependency in Unary.
30832 (Unary): Removed `method' and `Arguments' from this class, making
30833 it smaller, and moving it all to SimpleCall, so I can reuse this
30834 code in other locations and avoid creating a lot of transient data
30835 strucutres when not required.
30837 * cs-parser.jay: Adjust for new changes.
30839 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30841 * enum.cs (Enum.Populate): If there is a failure during
30844 * cs-parser.jay (opt_enum_base): we used to catch type errors
30845 here, but this is really incorrect. The type error should be
30846 catched during semantic analysis.
30848 2001-12-11 Ravi Pratap <ravi@ximian.com>
30850 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30851 current_local_parameters as expected since I, in my stupidity, had forgotten
30854 * attribute.cs (GetValidPlaces): Fix stupid bug.
30856 * class.cs (Method::Emit): Perform check on applicability of attributes.
30858 (Constructor::Emit): Ditto.
30860 (Field::Emit): Ditto.
30862 (Field.Location): Store location information.
30864 (Property, Event, Indexer, Operator): Ditto.
30866 * cs-parser.jay (field_declaration): Pass in location for each field.
30868 * ../errors/cs0592.cs : Add.
30870 2001-11-12 Ravi Pratap <ravi@ximian.com>
30872 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30874 (InitCoreTypes): Update accordingly.
30876 (RegisterAttrType, LookupAttr): Implement.
30878 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30879 info about the same.
30881 (Resolve): Update to populate the above as necessary.
30883 (Error592): Helper.
30885 (GetValidPlaces): Helper to the above.
30887 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30889 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30891 2001-11-12 Ravi Pratap <ravi@ximian.com>
30893 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30895 * ../errors/cs0617.cs : Add.
30897 2001-11-11 Ravi Pratap <ravi@ximian.com>
30899 * enum.cs (Emit): Rename to Populate to be more consistent with what
30900 we expect it to do and when exactly it is called.
30902 * class.cs, rootcontext.cs : Update accordingly.
30904 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30905 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30907 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30909 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30910 of a fieldinfo using the above, when dealing with a FieldBuilder.
30912 2001-11-10 Ravi Pratap <ravi@ximian.com>
30914 * ../errors/cs0031.cs : Add.
30916 * ../errors/cs1008.cs : Add.
30918 * ../errrors/cs0543.cs : Add.
30920 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30923 (FindMembers): Implement.
30925 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30926 enums and delegates too.
30928 (enum_types): Rename to builder_to_enum.
30930 (delegate_types): Rename to builder_to_delegate.
30932 * delegate.cs (FindMembers): Implement.
30934 2001-11-09 Ravi Pratap <ravi@ximian.com>
30936 * typemanager.cs (IsEnumType): Implement.
30938 * enum.cs (Emit): Re-write parts to account for the underlying type
30939 better and perform checking etc.
30941 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30942 of the underlying type.
30944 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30947 * enum.cs (error31): Helper to report error #31.
30949 * cs-parser.jay (enum_declaration): Store location of each member too.
30951 * enum.cs (member_to_location): New hashtable.
30953 (AddEnumMember): Update location hashtable.
30955 (Emit): Use the location of each member while reporting errors.
30957 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30959 * cs-parser.jay: A for_initializer if is a
30960 local_variable_declaration really ammount to have an implicit
30961 block with the variable declaration and no initializer for for.
30963 * statement.cs (For.Emit): Cope with null initializers.
30965 This fixes the infinite loop on for initializers.
30967 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30969 * enum.cs: More cleanup.
30971 * ecore.cs: Remove dead code.
30973 * class.cs (Property.Emit): More simplification.
30974 (Event.Emit): ditto.
30976 Reworked to have less levels of indentation.
30978 2001-11-08 Ravi Pratap <ravi@ximian.com>
30980 * class.cs (Property): Emit attributes.
30990 * enum.cs (Emit): Ditto.
30992 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30995 * class.cs (Field, Event, etc.): Move attribute generation into the
30996 Emit method everywhere.
30998 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30999 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
31000 as we had no way of defining nested enums !
31002 * rootcontext.cs : Adjust code accordingly.
31004 * typemanager.cs (AddEnumType): To keep track of enum types separately.
31006 2001-11-07 Ravi Pratap <ravi@ximian.com>
31008 * expression.cs (EvalConstantExpression): Move into ecore.cs
31010 * enum.cs (Enum): Rename some members and make them public and readonly
31011 according to our convention.
31013 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
31016 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
31018 (Enum::Emit): Write a simple version for now which doesn't try to compute
31019 expressions. I shall modify this to be more robust in just a while.
31021 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
31023 (TypeContainer::CloseType): Create the Enum types too.
31025 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
31027 * expression.cs (EvalConstantExpression): Get rid of completely.
31029 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
31030 user-defined values and other cases.
31032 (IsValidEnumLiteral): Helper function.
31034 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
31035 out there in the case we had a literal FieldExpr.
31037 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
31039 (Literalize): Revamp a bit to take two arguments.
31041 (EnumLiteral): New class which derives from Literal to wrap enum literals.
31043 2001-11-06 Ravi Pratap <ravi@ximian.com>
31045 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
31047 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
31049 (Resolve): Use the above to ensure we have proper initializers.
31051 2001-11-05 Ravi Pratap <ravi@ximian.com>
31053 * expression.cs (Expression::EvalConstantExpression): New method to
31054 evaluate constant expressions.
31056 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
31058 2001-11-07 Miguel de Icaza <miguel@ximian.com>
31060 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
31063 (Binary.ResolveOperator): Handle operator != (object a, object b)
31064 and operator == (object a, object b);
31066 (Binary.DoNumericPromotions): Indicate whether the numeric
31067 promotion was possible.
31069 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
31072 Made the ArrayAccess implement interface IAssignMethod instead of
31073 IStackStore as the order in which arguments are passed reflects
31076 * assign.cs: Instead of using expr.ExprClass to select the way of
31077 assinging, probe for the IStackStore/IAssignMethod interfaces.
31079 * typemanager.cs: Load InitializeArray definition.
31081 * rootcontext.cs (RootContext.MakeStaticData): Used to define
31082 static data that can be used to initialize arrays.
31084 2001-11-05 Miguel de Icaza <miguel@ximian.com>
31086 * expression.cs: Handle operator== and operator!= for booleans.
31088 (Conditioal.Reduce): Implement reducer for the ?: operator.
31090 (Conditional.Resolve): Implement dead code elimination.
31092 (Binary.Resolve): Catch string literals and return a new
31093 concatenated string.
31095 (Unary.Reduce): Implement reduction of unary expressions.
31097 * ecore.cs: Split out the expression core handling here.
31099 (Expression.Reduce): New method used to perform constant folding
31100 and CSE. This is needed to support constant-expressions.
31102 * statement.cs (Statement.EmitBoolExpression): Pass true and false
31103 targets, and optimize for !x.
31105 2001-11-04 Ravi Pratap <ravi@ximian.com>
31107 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
31108 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
31109 set custom atttributes.
31111 * literal.cs (Literal::GetValue): New abstract method to return the actual
31112 value of the literal, cast as an object.
31114 (*Literal): Implement GetValue method.
31116 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
31117 expressions to the arraylist but objects of type Argument.
31119 * class.cs (TypeContainer::Emit): Emit our attributes too.
31121 (Method::Emit, Constructor::Emit): Ditto.
31123 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
31124 to be ignoring earlier.
31126 2001-11-03 Ravi Pratap <ravi@ximian.com>
31128 * attribute.cs (AttributeSection::Define): Implement to do the business
31129 of constructing a CustomAttributeBuilder.
31131 (Attribute): New trivial class. Increases readability of code.
31133 * cs-parser.jay : Update accordingly.
31135 (positional_argument_list, named_argument_list, named_argument): New rules
31137 (attribute_arguments): Use the above so that we are more correct.
31139 2001-11-02 Ravi Pratap <ravi@ximian.com>
31141 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
31142 to perform all checks for a method with a params parameter.
31144 (Invocation::OverloadResolve): Update to use the above method and therefore
31145 cope correctly with params method invocations.
31147 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
31150 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
31151 constructors in our parent too because we can't afford to miss out on
31154 * attribute.cs (AttributeSection): New name for the class Attribute
31156 Other trivial changes to improve readability.
31158 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
31159 use the new class names.
31161 2001-11-01 Ravi Pratap <ravi@ximian.com>
31163 * class.cs (Method::Define): Complete definition for params types too
31165 (Indexer::Define): Ditto.
31167 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
31168 Cope everywhere with a request for info about the array parameter.
31170 2001-11-01 Ravi Pratap <ravi@ximian.com>
31172 * tree.cs (RecordNamespace): Fix up to check for the correct key.
31174 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
31175 local_variable_type to extract the string corresponding to the type.
31177 (local_variable_type): Fixup the action to use the new helper method.
31179 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
31182 * expression.cs : Clean out code which uses the above.
31184 2001-10-31 Ravi Pratap <ravi@ximian.com>
31186 * typemanager.cs (RegisterMethod): Check if we already have an existing key
31187 and bale out if necessary by returning a false.
31189 (RegisterProperty): Ditto.
31191 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
31192 and print out appropriate error messages.
31194 * interface.cs (everywhere): Ditto.
31196 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
31197 location to constructor.
31199 * class.cs (Property, Event, Indexer): Update accordingly.
31201 * ../errors/cs111.cs : Added.
31203 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
31204 of a method, as laid down by the spec.
31206 (Invocation::OverloadResolve): Use the above method.
31208 2001-10-31 Ravi Pratap <ravi@ximian.com>
31210 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
31211 now take a TypeContainer and a Parameters object.
31213 (ParameterData): Modify return type of ParameterModifier method to be
31214 Parameter.Modifier and not a string.
31216 (ReflectionParameters, InternalParameters): Update accordingly.
31218 * expression.cs (Argument::GetParameterModifier): Same here.
31220 * support.cs (InternalParameters::ParameterType): Find a better way of determining
31221 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
31222 symbol in it at all so maybe this is only for now.
31224 2001-10-30 Ravi Pratap <ravi@ximian.com>
31226 * support.cs (InternalParameters): Constructor now takes an extra argument
31227 which is the actual Parameters class.
31229 (ParameterDesc): Update to provide info on ref/out modifiers.
31231 * class.cs (everywhere): Update call to InternalParameters to pass in
31232 the second argument too.
31234 * support.cs (ParameterData): Add ParameterModifier, which is a method
31235 to return the modifier info [ref/out etc]
31237 (InternalParameters, ReflectionParameters): Implement the above.
31239 * expression.cs (Argument::ParameterModifier): Similar function to return
31240 info about the argument's modifiers.
31242 (Invocation::OverloadResolve): Update to take into account matching modifiers
31245 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
31246 a new SetFormalParameters object which we pass to InternalParameters.
31248 2001-10-30 Ravi Pratap <ravi@ximian.com>
31250 * expression.cs (NewArray): Merge into the ArrayCreation class.
31252 2001-10-29 Ravi Pratap <ravi@ximian.com>
31254 * expression.cs (NewArray): Merge classes NewBuiltinArray and
31255 NewUserdefinedArray into one as there wasn't much of a use in having
31258 * expression.cs (Argument): Change field's name to ArgType from Type.
31260 (Type): New readonly property which returns the proper type, taking into
31261 account ref/out modifiers.
31263 (everywhere): Adjust code accordingly for the above.
31265 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
31266 whether we are emitting for a ref or out parameter.
31268 * expression.cs (Argument::Emit): Use the above field to set the state.
31270 (LocalVariableReference::Emit): Update to honour the flag and emit the
31273 * parameter.cs (Attributes): Set the correct flags for ref parameters.
31275 * expression.cs (Argument::FullDesc): New function to provide a full desc.
31277 * support.cs (ParameterData): Add method ParameterDesc to the interface.
31279 (ReflectionParameters, InternalParameters): Implement the above method.
31281 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
31284 (Invocation::FullMethodDesc): Ditto.
31286 2001-10-29 Miguel de Icaza <miguel@ximian.com>
31288 * cs-parser.jay: Add extra production for the second form of array
31291 * expression.cs (ArrayCreation): Update to reflect the above
31294 * Small changes to prepare for Array initialization.
31296 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31298 * typemanager.cs (ImplementsInterface): interface might be null;
31299 Deal with this problem;
31301 Also, we do store negative hits on the cache (null values), so use
31302 this instead of calling t.GetInterfaces on the type everytime.
31304 2001-10-28 Ravi Pratap <ravi@ximian.com>
31306 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31308 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31309 split functionality out into different classes.
31311 (New::FormArrayType): Move into NewBuiltinArray.
31313 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31316 (NewBuiltinArray): New class to handle creation of built-in arrays.
31318 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31319 account creation of one-dimensional arrays.
31321 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31323 (NewUserdefinedArray::DoResolve): Implement.
31325 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31327 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31328 we maintain inside the TypeManager. This is necessary to perform lookups on the
31331 (LookupType): Update to perform GetType on the module builders too.
31333 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31335 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31337 2001-10-23 Ravi Pratap <ravi@ximian.com>
31339 * expression.cs (New::DoResolve): Implement guts of array creation.
31341 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31343 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31345 * expression.cs: Fix bug I introduced lsat night that broke
31348 (Expression.Resolve): Report a 246 error (can not resolve name)
31349 if we find a SimpleName in the stream.
31351 (Expression.ResolveLValue): Ditto.
31353 (Expression.ResolveWithSimpleName): This function is a variant of
31354 ResolveName, this one allows SimpleNames to be returned without a
31355 warning. The only consumer of SimpleNames is MemberAccess
31357 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31359 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31360 might arrive here. I have my doubts that this is correct.
31362 * statement.cs (Lock): Implement lock statement.
31364 * cs-parser.jay: Small fixes to support `lock' and `using'
31366 * cs-tokenizer.cs: Remove extra space
31368 * driver.cs: New flag --checked, allows to turn on integer math
31371 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31372 Threading.Monitor.Exit
31374 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31376 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31377 Expression Class to be IndexerAccess.
31379 Notice that Indexer::DoResolve sets the eclass to Value.
31381 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31383 * class.cs (TypeContainer::Emit): Emit code for indexers.
31385 * assign.cs (IAssignMethod): New interface implemented by Indexers
31386 and Properties for handling assignment.
31388 (Assign::Emit): Simplify and reuse code.
31390 * expression.cs (IndexerAccess, PropertyExpr): Implement
31391 IAssignMethod, clean up old code.
31393 2001-10-22 Ravi Pratap <ravi@ximian.com>
31395 * typemanager.cs (ImplementsInterface): New method to determine if a type
31396 implements a given interface. Provides a nice cache too.
31398 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31401 (ConvertReferenceExplicit): Ditto.
31403 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31404 various methods, with correct names etc.
31406 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31407 Operator.UnaryNegation.
31409 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31410 we have a unary plus or minus operator.
31412 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31415 * everywhere : update accordingly.
31417 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31420 * class.cs (Method::Define): For the case where we are implementing a method
31421 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31422 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31424 2001-10-21 Ravi Pratap <ravi@ximian.com>
31426 * interface.cs (FindMembers): Implement to work around S.R.E
31429 * typemanager.cs (IsInterfaceType): Implement.
31431 (FindMembers): Update to handle interface types too.
31433 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31434 use IsAssignableFrom as that is not correct - it doesn't work.
31436 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31437 and accordingly override EmitStatement.
31439 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31440 using the correct logic :-)
31442 2001-10-19 Ravi Pratap <ravi@ximian.com>
31444 * ../errors/cs-11.cs : Add to demonstrate error -11
31446 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31448 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31449 then pass this as a hint to ResolveLValue.
31451 * expression.cs (FieldExpr): Add Location information
31453 (FieldExpr::LValueResolve): Report assignment to readonly
31456 (Expression::ExprClassFromMemberInfo): Pass location information.
31458 (Expression::ResolveLValue): Add new method that resolves an
31461 (Expression::DoResolveLValue): Default invocation calls
31464 (Indexers): New class used to keep track of indexers in a given
31467 (IStackStore): Renamed from LValue, as it did not really describe
31468 what this did. Also ResolveLValue is gone from this interface and
31469 now is part of Expression.
31471 (ElementAccess): Depending on the element access type
31473 * typemanager.cs: Add `indexer_name_type' as a Core type
31474 (System.Runtime.CompilerServices.IndexerNameAttribute)
31476 * statement.cs (Goto): Take a location.
31478 2001-10-18 Ravi Pratap <ravi@ximian.com>
31480 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31481 if two delegates are compatible.
31483 (NewDelegate::DoResolve): Update to take care of the case when
31484 we instantiate a delegate from another delegate.
31486 * typemanager.cs (FindMembers): Don't even try to look up members
31487 of Delegate types for now.
31489 2001-10-18 Ravi Pratap <ravi@ximian.com>
31491 * delegate.cs (NewDelegate): New class to take care of delegate
31494 * expression.cs (New): Split the delegate related code out into
31495 the NewDelegate class.
31497 * delegate.cs (DelegateInvocation): New class to handle delegate
31500 * expression.cs (Invocation): Split out delegate related code into
31501 the DelegateInvocation class.
31503 2001-10-17 Ravi Pratap <ravi@ximian.com>
31505 * expression.cs (New::DoResolve): Implement delegate creation fully
31506 and according to the spec.
31508 (New::DoEmit): Update to handle delegates differently.
31510 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31511 because of which we were printing out arguments in reverse order !
31513 * delegate.cs (VerifyMethod): Implement to check if the given method
31514 matches the delegate.
31516 (FullDelegateDesc): Implement.
31518 (VerifyApplicability): Implement.
31520 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31521 delegate invocations too.
31523 (Invocation::Emit): Ditto.
31525 * ../errors/cs1593.cs : Added.
31527 * ../errors/cs1594.cs : Added.
31529 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31531 2001-10-16 Ravi Pratap <ravi@ximian.com>
31533 * typemanager.cs (intptr_type): Core type for System.IntPtr
31535 (InitCoreTypes): Update for the same.
31537 (iasyncresult_type, asynccallback_type): Ditto.
31539 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31542 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31545 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31546 the builders for the 4 members of a delegate type :-)
31548 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31551 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31553 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31555 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31557 * statement.cs (Break::Emit): Implement.
31558 (Continue::Emit): Implement.
31560 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31561 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31562 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31563 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31566 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31567 properties that track the label for the current loop (begin of the
31568 loop and end of the loop).
31570 2001-10-15 Ravi Pratap <ravi@ximian.com>
31572 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31573 use of emitting anything at all.
31575 * class.cs, rootcontext.cs : Get rid of calls to the same.
31577 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31579 (Populate): Define the constructor correctly and set the implementation
31582 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31585 (AddDelegateType): Implement.
31587 (IsDelegateType): Implement helper method.
31589 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31591 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31592 and accordingly handle it.
31594 * delegate.cs (Populate): Take TypeContainer argument.
31595 Implement bits to define the Invoke method. However, I still haven't figured out
31596 how to take care of the native int bit :-(
31598 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31599 Qualify the name of the delegate, not its return type !
31601 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31604 (StandardConversionExists): Checking for array types turns out to be recursive.
31606 (ConvertReferenceExplicit): Implement array conversion.
31608 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31610 2001-10-12 Ravi Pratap <ravi@ximian.com>
31612 * cs-parser.jay (delegate_declaration): Store the fully qualified
31613 name as it is a type declaration.
31615 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31618 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31619 as TypeContainer::DefineType.
31621 (Populate): Method in which all the definition of the various methods (Invoke)
31624 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31627 (CloseDelegate): Finally creates the delegate.
31629 * class.cs (TypeContainer::DefineType): Update to define delegates.
31630 (Populate, Emit and CloseType): Do the same thing here too.
31632 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31633 delegates in all these operations.
31635 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31637 * expression.cs: LocalTemporary: a new expression used to
31638 reference a temporary that has been created.
31640 * assign.cs: Handle PropertyAccess back here, so that we can
31641 provide the proper semantic access to properties.
31643 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31644 a few more explicit conversions.
31646 * modifiers.cs: `NEW' modifier maps to HideBySig.
31648 * expression.cs (PropertyExpr): Make this into an
31649 ExpressionStatement, and support the EmitStatement code path.
31651 Perform get/set error checking, clean up the interface.
31653 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31654 them into toplevel access objects.
31656 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31658 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31661 * typemanager.cs: Keep track here of our PropertyBuilders again to
31662 work around lameness in SRE.
31664 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31666 * expression.cs (LValue::LValueResolve): New method in the
31667 interface, used to perform a second resolution pass for LValues.
31669 (This::DoResolve): Catch the use of this in static methods.
31671 (This::LValueResolve): Implement.
31673 (This::Store): Remove warning, assigning to `this' in structures
31676 (Invocation::Emit): Deal with invocation of
31677 methods on value types. We need to pass the address to structure
31678 methods rather than the object itself. (The equivalent code to
31679 emit "this" for structures leaves the entire structure on the
31680 stack instead of a pointer to it).
31682 (ParameterReference::DoResolve): Compute the real index for the
31683 argument based on whether the method takes or not a `this' pointer
31684 (ie, the method is static).
31686 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31687 value types returned from functions when we need to invoke a
31688 method on the sturcture.
31691 2001-10-11 Ravi Pratap <ravi@ximian.com>
31693 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31694 defining the type in the Modulebuilder or Typebuilder. This is to take
31695 care of nested types which need to be defined on the TypeBuilder using
31696 DefineNestedMethod.
31698 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31699 methods in RootContext, only ported to be part of TypeContainer.
31701 (TypeContainer::GetInterfaceOrClass): Ditto.
31703 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31705 * interface.cs (Interface::DefineInterface): New method. Does exactly
31706 what RootContext.CreateInterface did earlier, only it takes care of nested types
31709 (Interface::GetInterfaces): Move from RootContext here and port.
31711 (Interface::GetInterfaceByName): Same here.
31713 * rootcontext.cs (ResolveTree): Re-write.
31715 (PopulateTypes): Re-write.
31717 * class.cs (TypeContainer::Populate): Populate nested types too.
31718 (TypeContainer::Emit): Emit nested members too.
31720 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31721 instead just use the name argument passed in as it is already fully
31724 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31725 to TypeContainer mapping to see if a type is user-defined.
31727 * class.cs (TypeContainer::CloseType): Implement.
31729 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31730 the default constructor.
31732 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31735 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31737 * interface.cs (CloseType): Create the type here.
31739 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31742 Remove all the methods which are now in TypeContainer.
31744 2001-10-10 Ravi Pratap <ravi@ximian.com>
31746 * delegate.cs (Define): Re-write bits to define the delegate
31749 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31751 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31753 * expression.cs (ImplicitReferenceConversion): handle null as well
31754 as a source to convert to any reference type.
31756 * statement.cs (Return): Perform any implicit conversions to
31757 expected return type.
31759 Validate use of return statement.
31761 * codegen.cs (EmitContext): Pass the expected return type here.
31763 * class.cs (Method, Constructor, Property): Pass expected return
31764 type to EmitContext.
31766 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31768 * expression.cs: Make DoResolve take an EmitContext instead of a
31771 Replaced `l' and `location' for `loc', for consistency.
31773 (Error, Warning): Remove unneeded Tc argument.
31775 * assign.cs, literal.cs, constant.cs: Update to new calling
31778 * codegen.cs: EmitContext now contains a flag indicating whether
31779 code is being generated in a static method or not.
31781 * cs-parser.jay: DecomposeQI, new function that replaces the old
31782 QualifiedIdentifier. Now we always decompose the assembled
31783 strings from qualified_identifier productions into a group of
31786 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31788 * rootcontext.cs: Deal with field-less struct types correctly now
31789 by passing the size option to Define Type.
31791 * class.cs: Removed hack that created one static field.
31793 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31795 * statement.cs: Moved most of the code generation here.
31797 2001-10-09 Ravi Pratap <ravi@ximian.com>
31799 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31802 (ElementAccess): Remove useless bits for now - keep checks as the spec
31805 2001-10-08 Ravi Pratap <ravi@ximian.com>
31807 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31808 and start performing checks according to the spec.
31810 2001-10-07 Ravi Pratap <ravi@ximian.com>
31812 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31813 rank_specifiers instead.
31815 (rank_specifiers): Change the order in which the rank specifiers are stored
31817 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31819 * expression.cs (ElementAccess): Implement the LValue interface too.
31821 2001-10-06 Ravi Pratap <ravi@ximian.com>
31823 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31824 except that user defined conversions are not included.
31826 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31827 perform the conversion of the return type, if necessary.
31829 (New::DoResolve): Check whether we are creating an array or an object
31830 and accordingly do the needful.
31832 (New::Emit): Same here.
31834 (New::DoResolve): Implement guts of array creation.
31836 (New::FormLookupType): Helper function.
31838 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31840 * codegen.cs: Removed most of the code generation here, and move the
31841 corresponding code generation bits to the statement classes.
31843 Added support for try/catch/finalize and throw.
31845 * cs-parser.jay: Added support for try/catch/finalize.
31847 * class.cs: Catch static methods having the flags override,
31848 virtual or abstract.
31850 * expression.cs (UserCast): This user cast was not really doing
31851 what it was supposed to do. Which is to be born in fully resolved
31852 state. Parts of the resolution were being performed at Emit time!
31856 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31858 * expression.cs: Implicity convert the result from UserCast.
31860 2001-10-05 Ravi Pratap <ravi@ximian.com>
31862 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31863 prevented it from working correctly.
31865 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31866 merely ConvertImplicit.
31868 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31870 * typemanager.cs: Make the LookupTypeContainer function static,
31871 and not per-instance.
31873 * class.cs: Make static FindMembers (the one that takes a Type
31876 * codegen.cs: Add EmitForeach here.
31878 * cs-parser.jay: Make foreach a toplevel object instead of the
31879 inline expansion, as we need to perform semantic analysis on it.
31881 2001-10-05 Ravi Pratap <ravi@ximian.com>
31883 * expression.cs (Expression::ImplicitUserConversion): Rename to
31884 UserDefinedConversion.
31886 (Expression::UserDefinedConversion): Take an extra argument specifying
31887 whether we look for explicit user conversions too.
31889 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31891 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31893 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31894 with the appropriate arguments.
31896 * cs-parser.jay (cast_expression): Record location too.
31898 * expression.cs (Cast): Record location info.
31900 (Expression::ConvertExplicit): Take location argument.
31902 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31903 to determine if we are doing explicit conversions.
31905 (UserCast::Emit): Update accordingly.
31907 (Expression::ConvertExplicit): Report an error if everything fails.
31909 * ../errors/cs0030.cs : Add.
31911 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31913 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31914 virtual and newslot bits.
31916 * class.cs (TypeContainer::RegisterRequiredImplementations):
31917 Record methods we need.
31919 (TypeContainer::MakeKey): Helper function to make keys for
31920 MethodBases, since the Methodbase key is useless.
31922 (TypeContainer::Populate): Call RegisterRequiredImplementations
31923 before defining the methods.
31925 Create a mapping for method_builders_to_methods ahead of time
31926 instead of inside a tight loop.
31928 (::RequireMethods): Accept an object as the data to set into the
31929 hashtable so we can report interface vs abstract method mismatch.
31931 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31933 * report.cs: Make all of it static.
31935 * rootcontext.cs: Drop object_type and value_type computations, as
31936 we have those in the TypeManager anyways.
31938 Drop report instance variable too, now it is a global.
31940 * driver.cs: Use try/catch on command line handling.
31942 Add --probe option to debug the error reporting system with a test
31945 * report.cs: Add support for exiting program when a probe
31946 condition is reached.
31948 2001-10-03 Ravi Pratap <ravi@ximian.com>
31950 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31951 we do a forcible conversion regardless of type, to check if
31952 ForceConversion returns a null.
31954 (Binary::error19): Use location to report error.
31956 (Unary::error23): Use location here too.
31958 * ../errors/cs0019.cs : Check in.
31960 * ../errors/cs0023.cs : Check in.
31962 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31963 case of a non-null MethodInfo object with a length of 0 !
31965 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31966 an applicable member - according to the spec :-)
31967 Also fix logic to find members in base types.
31969 (Unary::ResolveOperator): Same here.
31971 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31972 as I was getting thoroughly confused between this and error19 :-)
31974 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31975 (::FindMostEncompassedType): Implement.
31976 (::FindMostEncompassingType): Implement.
31977 (::StandardConversionExists): Implement.
31979 (UserImplicitCast): Re-vamp. We now need info about most specific
31980 source and target types so that we can do the necessary conversions.
31982 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31983 mathematical union with no duplicates.
31985 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31987 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31988 in order from base classes to child classes, so that we can in
31989 child classes look up in our parent for method names and
31990 attributes (required for handling abstract, virtual, new, override
31991 constructs: we need to instrospect our base class, and if we dont
31992 populate the classes in order, the introspection might be
31993 incorrect. For example, a method could query its parent before
31994 the parent has any methods and would determine that the parent has
31995 no abstract methods (while it could have had them)).
31997 (RootContext::CreateType): Record the order in which we define the
32000 2001-10-02 Miguel de Icaza <miguel@ximian.com>
32002 * class.cs (TypeContainer::Populate): Also method definitions can
32003 fail now, keep track of this.
32005 (TypeContainer::FindMembers): Implement support for
32006 DeclaredOnly/noDeclaredOnly flag.
32008 (Constructor::Emit) Return the ConstructorBuilder.
32010 (Method::Emit) Return the MethodBuilder.
32011 Check for abstract or virtual methods to be public.
32013 * rootcontext.cs (RootContext::CreateType): Register all the
32014 abstract methods required for the class to be complete and the
32015 interface methods that must be implemented.
32017 * cs-parser.jay: Report error 501 (method requires body if it is
32018 not marked abstract or extern).
32020 * expression.cs (TypeOf::Emit): Implement.
32022 * typemanager.cs: runtime_handle_type, new global type.
32024 * class.cs (Property::Emit): Generate code for properties.
32026 2001-10-02 Ravi Pratap <ravi@ximian.com>
32028 * expression.cs (Unary::ResolveOperator): Find operators on base type
32029 too - we now conform exactly to the spec.
32031 (Binary::ResolveOperator): Same here.
32033 * class.cs (Operator::Define): Fix minor quirk in the tests.
32035 * ../errors/cs0215.cs : Added.
32037 * ../errors/cs0556.cs : Added.
32039 * ../errors/cs0555.cs : Added.
32041 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32043 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
32044 single integer which is really efficient
32046 2001-10-01 Ravi Pratap <ravi@ximian.com>
32048 * expression.cs (Expression::ImplicitUserConversion): Use location
32049 even in the case when we are examining True operators.
32051 * class.cs (Operator::Define): Perform extensive checks to conform
32052 with the rules for operator overloading in the spec.
32054 * expression.cs (Expression::ImplicitReferenceConversion): Implement
32055 some of the other conversions mentioned in the spec.
32057 * typemanager.cs (array_type): New static member for the System.Array built-in
32060 (cloneable_interface): For System.ICloneable interface.
32062 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
32063 we start resolving the tree and populating types.
32065 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
32067 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32069 * expression.cs (Expression::ExprClassFromMemberInfo,
32070 Expression::Literalize): Create literal expressions from
32071 FieldInfos which are literals.
32073 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
32074 type casts, because they were wrong. The test suite in tests
32077 (ImplicitNumericConversion): ushort to ulong requires a widening
32080 Int32 constant to long requires widening cast as well.
32082 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
32083 for integers because the type on the stack is not i4.
32085 2001-09-30 Miguel de Icaza <miguel@ximian.com>
32087 * expression.cs (report118): require location argument.
32089 * parameter.cs: Do not dereference potential null value.
32091 * class.cs: Catch methods that lack the `new' keyword when
32092 overriding a name. Report warnings when `new' is used without
32093 anything being there to override.
32095 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
32097 * class.cs: Only add constructor to hashtable if it is non-null
32098 (as now constructors can fail on define).
32100 (TypeManager, Class, Struct): Take location arguments.
32102 Catch field instance initialization in structs as errors.
32104 accepting_filter: a new filter for FindMembers that is static so
32105 that we dont create an instance per invocation.
32107 (Constructor::Define): Catch errors where a struct constructor is
32110 * cs-parser.jay: Pass location information for various new
32113 * delegate.cs (Delegate): take a location argument.
32115 * driver.cs: Do not call EmitCode if there were problesm in the
32116 Definition of the types, as many Builders wont be there.
32118 * decl.cs (Decl::Decl): Require a location argument.
32120 * cs-tokenizer.cs: Handle properly hex constants that can not fit
32121 into integers, and find the most appropiate integer for it.
32123 * literal.cs: Implement ULongLiteral.
32125 * rootcontext.cs: Provide better information about the location of
32126 failure when CreateType fails.
32128 2001-09-29 Miguel de Icaza <miguel@ximian.com>
32130 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
32133 * expression.cs (Binary::CheckShiftArguments): Add missing type
32135 (Binary::ResolveOperator): Add type to the logical and and logical
32136 or, Bitwise And/Or and Exclusive Or code paths, it was missing
32139 (Binary::DoNumericPromotions): In the case where either argument
32140 is ulong (and most signed types combined with ulong cause an
32141 error) perform implicit integer constant conversions as well.
32143 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32145 * expression.cs (UserImplicitCast): Method should always be
32147 (Invocation::BetterConversion): Simplified test for IntLiteral.
32149 (Expression::ImplicitNumericConversion): Split this routine out.
32150 Put the code that performs implicit constant integer conversions
32153 (Expression::Resolve): Become a wrapper around DoResolve so we can
32154 check eclass and type being set after resolve.
32156 (Invocation::Badness): Remove this dead function
32158 (Binary::ResolveOperator): Do not compute the expensive argumnets
32159 unless we have a union for it.
32161 (Probe::Emit): Is needs to do an isinst and then
32162 compare against null.
32164 (::CanConvert): Added Location argument. If the Location argument
32165 is null (Location.Null), then we do not report errors. This is
32166 used by the `probe' mechanism of the Explicit conversion. We do
32167 not want to generate an error for something that the user
32168 explicitly requested to be casted. But the pipeline for an
32169 explicit cast first tests for potential implicit casts.
32171 So for now, if the Location is null, it means `Probe only' to
32172 avoid adding another argument. Might have to revise this
32175 (ClassCast): New class used to type cast objects into arbitrary
32176 classes (used in Explicit Reference Conversions).
32178 Implement `as' as well.
32180 Reverted all the patches from Ravi below: they were broken:
32182 * The use of `level' as a mechanism to stop recursive
32183 invocations is wrong. That was there just to catch the
32184 bug with a strack trace but not as a way of addressing
32187 To fix the problem we have to *understand* what is going
32188 on and the interactions and come up with a plan, not
32189 just get things going.
32191 * The use of the type conversion cache that I proposed
32192 last night had an open topic: How does this work across
32193 protection domains. A user defined conversion might not
32194 be public in the location where we are applying the
32195 conversion, a different conversion might be selected
32196 (ie, private A->B (better) but public B->A (worse),
32197 inside A, A->B applies, but outside it, B->A will
32200 * On top of that (ie, even if the above is solved),
32201 conversions in a cache need to be abstract. Ie, `To
32202 convert from an Int to a Short use an OpcodeCast', not
32203 `To convert from an Int to a Short use the OpcodeCast on
32204 the variable 5' (which is what this patch was doing).
32206 2001-09-28 Ravi Pratap <ravi@ximian.com>
32208 * expression.cs (Invocation::ConversionExists): Re-write to use
32209 the conversion cache
32211 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
32212 cache all conversions done, not just user-defined ones.
32214 (Invocation::BetterConversion): The real culprit. Use ConversionExists
32215 to determine if a conversion exists instead of acutually trying to
32216 perform the conversion. It's faster too.
32218 (Expression::ConvertExplicit): Modify to use ConversionExists to check
32219 and only then attempt the implicit conversion.
32221 2001-09-28 Ravi Pratap <ravi@ximian.com>
32223 * expression.cs (ConvertImplicit): Use a cache for conversions
32224 already found. Check level of recursion and bail out if necessary.
32226 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32228 * typemanager.cs (string_concat_string_string, string_concat_object_object):
32229 Export standard methods that we expect for string operations.
32231 * statement.cs (Block::UsageWarning): Track usage of variables and
32232 report the errors for not used variables.
32234 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
32237 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32239 * codegen.cs: remove unnneded code
32241 * expression.cs: Removed BuiltinTypeAccess class
32243 Fix the order in which implicit conversions are
32246 The previous fixed dropped support for boxed conversions (adding a
32247 test to the test suite now)
32249 (UserImplicitCast::CanConvert): Remove test for source being null,
32250 that code is broken. We should not feed a null to begin with, if
32251 we do, then we should track the bug where the problem originates
32252 and not try to cover it up here.
32254 Return a resolved expression of type UserImplicitCast on success
32255 rather than true/false. Ravi: this is what I was talking about,
32256 the pattern is to use a static method as a "constructor" for
32259 Also, do not create arguments until the very last minute,
32260 otherwise we always create the arguments even for lookups that
32261 will never be performed.
32263 (UserImplicitCast::Resolve): Eliminate, objects of type
32264 UserImplicitCast are born in a fully resolved state.
32266 * typemanager.cs (InitCoreTypes): Init also value_type
32267 (System.ValueType).
32269 * expression.cs (Cast::Resolve): First resolve the child expression.
32271 (LValue): Add new method AddressOf to be used by
32274 Change the argument of Store to take an EmitContext instead of an
32275 ILGenerator, because things like FieldExpr need to be able to call
32276 their children expression to generate the instance code.
32278 (Expression::Error, Expression::Warning): Sugar functions for
32281 (Expression::MemberLookup): Accept a TypeContainer instead of a
32282 Report as the first argument.
32284 (Expression::ResolvePrimary): Killed. I still want to improve
32285 this as currently the code is just not right.
32287 (Expression::ResolveMemberAccess): Simplify, but it is still
32290 (Unary::Resolve): Catch errors in AddressOf operators.
32292 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
32293 index to a byte for the short-version, or the compiler will choose
32294 the wrong Emit call, which generates the wrong data.
32296 (ParameterReference::Emit, ::Store): same.
32298 (FieldExpr::AddressOf): Implement.
32300 * typemanager.cs: TypeManager: made public variable instead of
32303 * driver.cs: document --fatal.
32305 * report.cs (ErrorMessage, WarningMessage): new names for the old
32306 Error and Warning classes.
32308 * cs-parser.jay (member_access): Turn built-in access to types
32309 into a normal simplename
32311 2001-09-27 Ravi Pratap <ravi@ximian.com>
32313 * expression.cs (Invocation::BetterConversion): Fix to cope
32314 with q being null, since this was introducing a bug.
32316 * expression.cs (ConvertImplicit): Do built-in conversions first.
32318 2001-09-27 Ravi Pratap <ravi@ximian.com>
32320 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32322 2001-09-27 Ravi Pratap <ravi@ximian.com>
32324 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32325 I had introduced long ago (what's new ?).
32327 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32328 the work of all the checking.
32329 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32330 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32332 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32333 that is the right way.
32335 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32336 overloading resolution. Use everywhere instead of cutting and pasting code.
32338 (Binary::ResolveOperator): Use MakeUnionSet.
32340 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32341 we have to convert to bool types. Not complete yet.
32343 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32345 * typemanager.cs (TypeManager::CSharpName): support ushort.
32347 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32348 to provide an expression that performsn an implicit constant int
32349 conversion (section 6.1.6).
32350 (Expression::ConvertImplicitRequired): Reworked to include
32351 implicit constant expression conversions.
32353 (Expression::ConvertNumericExplicit): Finished.
32355 (Invocation::Emit): If InstanceExpression is null, then it means
32356 that we perform a call on this.
32358 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32360 * expression.cs (Unary::Emit): Remove some dead code.
32361 (Probe): Implement Resolve and Emit for `is'.
32362 (Expression::ConvertImplicitRequired): Attempt to do constant
32363 expression conversions here. Maybe should be moved to
32364 ConvertImplicit, but I am not sure.
32365 (Expression::ImplicitLongConstantConversionPossible,
32366 Expression::ImplicitIntConstantConversionPossible): New functions
32367 that tell whether is it possible to apply an implicit constant
32368 expression conversion.
32370 (ConvertNumericExplicit): Started work on explicit numeric
32373 * cs-parser.jay: Update operator constants.
32375 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32376 (Parameters::GetSignature): Hook up VerifyArgs here.
32377 (Parameters::VerifyArgs): Verifies that no two arguments have the
32380 * class.cs (Operator): Update the operator names to reflect the
32381 ones that the spec expects (as we are just stringizing the
32384 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32385 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32386 previous usage did only work for our methods.
32387 (Expression::ConvertImplicit): Handle decimal implicit numeric
32388 conversions as well.
32389 (Expression::InternalTypeConstructor): Used to invoke constructors
32390 on internal types for default promotions.
32392 (Unary::Emit): Implement special handling for the pre/post
32393 increment/decrement for overloaded operators, as they need to have
32394 the same semantics as the other operators.
32396 (Binary::ResolveOperator): ditto.
32397 (Invocation::ConversionExists): ditto.
32398 (UserImplicitCast::Resolve): ditto.
32400 2001-09-26 Ravi Pratap <ravi@ximian.com>
32402 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32403 operator, return after emitting body. Regression tests pass again !
32405 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32406 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32407 (Invocation::OverloadResolve): Ditto.
32408 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32410 * everywhere : update calls to the above methods accordingly.
32412 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32414 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32416 * expression.cs (ExpressionStatement): New base class used for
32417 expressions that can appear in statements, so that we can provide
32418 an alternate path to generate expression that do not leave a value
32421 (Expression::Emit, and all the derivatives): We no longer return
32422 whether a value is left on the stack or not. Every expression
32423 after being emitted leaves a single value on the stack.
32425 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32426 facilties of ExpressionStatement if possible.
32428 * cs-parser.jay: Update statement_expression.
32430 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32432 * driver.cs: Change the wording of message
32434 2001-09-25 Ravi Pratap <ravi@ximian.com>
32436 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32437 the type of the expression to the return type of the method if
32438 we have an overloaded operator match ! The regression tests pass again !
32439 (Unary::ResolveOperator): Ditto.
32441 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32442 to find "op_Implicit", not "implicit" ;-)
32443 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32444 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32446 * everywhere : Correct calls to the above accordingly.
32448 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32449 (ConvertImplicit): Do user-defined conversion if it exists.
32451 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32453 * assign.cs: track location.
32454 (Resolve): Use implicit conversions on assignment.
32456 * literal.cs: Oops. Not good, Emit of short access values should
32457 pass (Bytes) or the wrong argument will be selected.
32459 * expression.cs (Unary::Emit): Emit code for -expr.
32461 (Unary::ResolveOperator): Handle `Substract' for non-constants
32462 (substract from zero from the non-constants).
32463 Deal with Doubles as well.
32465 (Expression::ConvertImplicitRequired): New routine that reports an
32466 error if no implicit conversion exists.
32468 (Invocation::OverloadResolve): Store the converted implicit
32469 expressions if we make them
32471 2001-09-24 Ravi Pratap <ravi@ximian.com>
32473 * class.cs (ConstructorInitializer): Take a Location argument.
32474 (ConstructorBaseInitializer): Same here.
32475 (ConstructorThisInitializer): Same here.
32477 * cs-parser.jay : Update all calls accordingly.
32479 * expression.cs (Unary, Binary, New): Take location argument.
32480 Update accordingly everywhere.
32482 * cs-parser.jay : Update all calls to the above to take a location
32485 * class.cs : Ditto.
32487 2001-09-24 Ravi Pratap <ravi@ximian.com>
32489 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32490 (Invocation::BetterConversion): Same here
32491 (Invocation::ConversionExists): Ditto.
32493 (Invocation::ConversionExists): Implement.
32495 2001-09-22 Ravi Pratap <ravi@ximian.com>
32497 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32498 Also take an additional TypeContainer argument.
32500 * All over : Pass in TypeContainer as argument to OverloadResolve.
32502 * typemanager.cs (CSharpName): Update to check for the string type and return
32505 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32508 2001-09-21 Ravi Pratap <ravi@ximian.com>
32510 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32511 (Invocation::BetterFunction): Implement.
32512 (Invocation::BetterConversion): Implement.
32513 (Invocation::ConversionExists): Skeleton, no implementation yet.
32515 Okay, things work fine !
32517 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32519 * typemanager.cs: declare and load enum_type, delegate_type and
32522 * expression.cs (Expression::Emit): Now emit returns a value that
32523 tells whether a value is left on the stack or not. This strategy
32524 might be reveted tomorrow with a mechanism that would address
32525 multiple assignments.
32526 (Expression::report118): Utility routine to report mismatches on
32529 (Unary::Report23): Report impossible type/operator combination
32532 (Unary::IsIncrementableNumber): Whether the type can be
32533 incremented or decremented with add.
32534 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32536 (Unary::ResolveOperator): Implement ++, !, ~,
32538 (Invocation::Emit): Deal with new Emit convetion.
32540 * All Expression derivatives: Updated their Emit method to return
32541 whether they leave values on the stack or not.
32543 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32544 stack for expressions that are statements.
32546 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32548 * expression.cs (LValue): New interface. Must be implemented by
32550 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32553 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32554 interface for generating code, simplifies the code.
32556 2001-09-20 Ravi Pratap <ravi@ximian.com>
32558 * expression.cs (everywhere): Comment out return statements in ::Resolve
32559 methods to avoid the warnings.
32561 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32563 * driver.cs (parse): Report error 2001 if we can not open the
32566 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32569 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32572 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32573 otherwise nested blocks end up with the same index.
32575 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32577 * expression.cs: Instead of having FIXMEs in the Resolve
32578 functions, throw exceptions so it is obvious that we are facing a
32581 * cs-parser.jay (invocation_expression): Pass Location information.
32583 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32584 Use a basename for those routines because .NET does not like paths
32587 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32590 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32592 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32593 are loading the correct data types (throws an exception if not).
32594 (TypeManager::InitCoreTypes): Use CoreLookupType
32596 * expression.cs (Unary::ResolveOperator): return the child
32597 expression for expressions which are just +expr.
32598 (Unary::ResolveOperator): Return negative literals for -LITERAL
32599 expressions (otherwise they are Unary {Literal}).
32600 (Invocation::Badness): Take into account `Implicit constant
32601 expression conversions'.
32603 * literal.cs (LongLiteral): Implement long literal class.
32604 (IntLiteral): export the `Value' of the intliteral.
32606 2001-09-19 Ravi Pratap <ravi@ximian.com>
32608 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32610 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32611 instead of 'Operator'
32613 * expression.cs (Binary::ResolveOperator): Update accordingly.
32614 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32617 * cs-parser.jay (unary_expression): Update to use the new names.
32619 * gen-treedump.cs (GetUnary): Same here.
32621 * expression.cs (Unary::Resolve): Implement.
32622 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32623 operators are found instead of making noise ;-)
32624 (Unary::ResolveOperator): New method to do precisely the same thing which
32625 Binary::ResolveOperator does for Binary expressions.
32626 (Unary.method, .Arguments): Add.
32627 (Unary::OperName): Implement.
32628 (Unary::ForceConversion): Copy and Paste !
32630 * class.cs (Operator::Define): Fix a small bug for the case when we have
32633 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32634 for the inbuilt operators. Only overloading works for now ;-)
32636 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32638 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32639 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32641 * expression.cs (This::Emit): Implement.
32642 (This::Resolve): Implement.
32643 (TypeOf:Resolve): Implement.
32644 (Expression::ResolveSimpleName): Add an implicit this to instance
32646 (MemberAccess::Resolve): Deal with Parameters and Fields.
32647 Bind instance variable to Field expressions.
32648 (FieldExpr::Instance): New field used to track the expression that
32649 represents the object instance.
32650 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32652 (FieldExpr::Emit): Implement.
32654 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32655 the last instruction contains a return opcode to avoid generating
32656 the last `ret' instruction (this generates correct code, and it is
32657 nice to pass the peverify output).
32659 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32660 initializer for static and instance variables.
32661 (Constructor::Emit): Allow initializer to be null in the case of
32662 static constructors. Only emit initializer for instance
32665 (TypeContainer::FindMembers): Return a null array if there are no
32668 Also fix the code for the MemberTypes.Method branch, as it was not
32669 scanning that for operators (or tried to access null variables before).
32671 * assign.cs (Assign::Emit): Handle instance and static fields.
32675 * driver.cs: Stop compilation if there are parse errors.
32677 * cs-parser.jay (constructor_declaration): Provide default base
32678 initializer for non-static constructors.
32679 (constructor_declarator): Do not provide a default base
32680 initializers if none was specified.
32681 Catch the fact that constructors should not have parameters.
32683 * class.cs: Do not emit parent class initializers for static
32684 constructors, that should be flagged as an error.
32686 2001-09-18 Ravi Pratap <ravi@ximian.com>
32688 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32689 Move back code into TypeContainer::Populate.
32691 2001-09-18 Ravi Pratap <ravi@ximian.com>
32693 * class.cs (TypeContainer::AddConstructor): Fix the check to
32694 compare against Name, not Basename.
32695 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32697 * cs-parser.jay : Update accordingly.
32699 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32700 for methods, don't forget to look into the operators too.
32701 (RegisterMethodBuilder): Helper method to take care of this for
32702 methods, constructors and operators.
32703 (Operator::Define): Completely revamp.
32704 (Operator.OperatorMethod, MethodName): New fields.
32705 (TypeContainer::Populate): Move the registering of builders into
32706 RegisterMethodBuilder.
32707 (Operator::Emit): Re-write.
32709 * expression.cs (Binary::Emit): Comment out code path to emit method
32710 invocation stuff for the case when we have a user defined operator. I am
32711 just not able to get it right !
32713 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32715 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32718 (Expression::MemberLookup): Provide a version that allows to
32719 specify the MemberTypes and BindingFlags.
32721 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32722 so it was not fetching variable information from outer blocks.
32724 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32725 Beforefieldinit as it was buggy.
32727 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32728 that Ravi put here.
32730 * class.cs (Constructor::Emit): Only emit if block is not null.
32731 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32732 deal with this by semantically definining it as if the user had
32735 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32736 constructors as we now "emit" them at a higher level.
32738 (TypeContainer::DefineDefaultConstructor): Used to define the
32739 default constructors if none was provided.
32741 (ConstructorInitializer): Add methods Resolve and Emit.
32743 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32745 2001-09-17 Ravi Pratap <ravi@ximian.com>
32747 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32748 the default constructor builder with our hashtable for methodbuilders
32751 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32752 and argument_count is 0 in which case we have a match.
32753 (Binary::ResolveOperator): More null checking and miscellaneous coding
32756 2001-09-17 Ravi Pratap <ravi@ximian.com>
32758 * rootcontext.cs (IsNameSpace): Compare against null.
32760 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32762 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32763 and Unary::Operator.
32765 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32768 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32769 we have overloaded operators.
32770 (Binary::ResolveOperator): Implement the part which does the operator overload
32773 * class.cs (Operator::Emit): Implement.
32774 (TypeContainer::Emit): Emit the operators we have too.
32776 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32777 the case when we have a user-defined operator.
32779 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32781 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32783 2001-09-16 Ravi Pratap <ravi@ximian.com>
32785 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32786 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32787 (Constructor::Emit): Implement.
32788 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32789 if we have no work to do.
32790 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32793 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32794 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32796 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32799 2001-09-15 Ravi Pratap <ravi@ximian.com>
32801 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32803 (Tree::RecordNamespace): Method to do what the name says ;-)
32804 (Tree::Namespaces): Property to get at the namespaces hashtable.
32806 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32809 * rootcontext.cs (IsNamespace): Fixed it :-)
32811 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32813 * class.cs (TypeContainer::FindMembers): Add support for
32815 (MethodCore): New class that encapsulates both the shared aspects
32816 of a Constructor and a Method.
32817 (Method, Constructor): Factored pieces into MethodCore.
32819 * driver.cs: Added --fatal which makes errors throw exceptions.
32820 Load System assembly as well as part of the standard library.
32822 * report.cs: Allow throwing exceptions on errors for debugging.
32824 * modifiers.cs: Do not use `parent', instead use the real type
32825 container to evaluate permission settings.
32827 * class.cs: Put Ravi's patch back in. He is right, and we will
32828 have to cope with the
32830 2001-09-14 Ravi Pratap <ravi@ximian.com>
32832 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32833 FamORAssem, not FamANDAssem.
32835 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32837 * driver.cs: Added --parse option that only parses its input files
32840 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32841 incorrect. IsTopLevel is not used to tell whether an object is
32842 root_types or not (that can be achieved by testing this ==
32843 root_types). But to see if this is a top-level *class* (not
32844 necessarly our "toplevel" container).
32846 2001-09-14 Ravi Pratap <ravi@ximian.com>
32848 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32849 parent instead of a direct call to GetType.
32851 2001-09-14 Ravi Pratap <ravi@ximian.com>
32853 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32854 Modifiers.TypeAttr. This should just be a call to that method.
32856 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32857 object so that we can determine if we are top-level or not.
32859 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32862 * enum.cs (Enum::Define): Ditto.
32864 * modifiers.cs (FieldAttr): Re-write.
32866 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32867 (TypeContainer::HaveStaticConstructor): New property to provide access
32868 to precisely that info.
32870 * modifiers.cs (MethodAttr): Re-write.
32871 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32873 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32874 of top-level types as claimed.
32876 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32878 * expression.cs (MemberLookup): Fruitless attempt to lookup
32879 constructors. Maybe I need to emit default constructors? That
32880 might be it (currently .NET emits this for me automatically).
32881 (Invocation::OverloadResolve): Cope with Arguments == null.
32882 (Invocation::EmitArguments): new function, shared by the new
32883 constructor and us.
32884 (Invocation::Emit): Handle static and instance methods. Emit
32885 proper call instruction for virtual or non-virtual invocations.
32886 (New::Emit): Implement.
32887 (New::Resolve): Implement.
32888 (MemberAccess:Resolve): Implement.
32889 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32890 to track instances.
32891 (FieldExpr::Resolve): Set type.
32893 * support.cs: Handle empty arguments.
32895 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32896 SimpleLookup): Auxiliary routines to help parse a qualifier
32899 Update qualifier_identifier rule.
32901 * codegen.cs: Removed debugging messages.
32903 * class.cs: Make this a global thing, this acts just as a "key" to
32904 objects that we might have around.
32906 (Populate): Only initialize method_builders_to_methods once.
32908 * expression.cs (PropertyExpr): Initialize type from the
32911 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32912 Resolve pattern. Attempt to implicitly convert value to boolean.
32915 * expression.cs: Set the type for the int32/int32 argument case.
32916 (Binary::ResolveOperator): Set the return type to boolean for
32917 comparission operators
32919 * typemanager.cs: Remove debugging print code.
32921 (Invocation::Resolve): resolve type.
32923 * class.cs: Allocate a MemberInfo of the correct size, as the code
32924 elsewhere depends on the test to reflect the correct contents.
32926 (Method::) Keep track of parameters, due to System.Reflection holes
32928 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32931 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32932 of the exact size and return that.
32934 (Class::LookupMethodByBuilder): New function that maps
32935 MethodBuilders to its methods. Required to locate the information
32936 on methods because System.Reflection bit us again.
32938 * support.cs: New file, contains an interface ParameterData and
32939 two implementations: ReflectionParameters and InternalParameters
32940 used to access Parameter information. We will need to grow this
32943 * expression.cs (Invocation::GetParameterData): implement a cache
32944 and a wrapper around the ParameterData creation for methods.
32945 (Invocation::OverloadResolve): Use new code.
32947 2001-09-13 Ravi Pratap <ravi@ximian.com>
32949 * class.cs (TypeContainer::EmitField): Remove and move into
32950 (Field::Define): here and modify accordingly.
32951 (Field.FieldBuilder): New member.
32952 (TypeContainer::Populate): Update accordingly.
32953 (TypeContainer::FindMembers): Implement.
32955 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32957 * statement.cs: (VariableInfo::VariableType): New field to be
32958 initialized with the full type once it is resolved.
32960 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32962 * parameter.cs (GetParameterInfo): Use a type cache to compute
32963 things only once, and to reuse this information
32965 * expression.cs (LocalVariableReference::Emit): Implement.
32966 (OpcodeCast::Emit): fix.
32968 (ParameterReference::Resolve): Implement.
32969 (ParameterReference::Emit): Implement.
32971 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32972 that are expressions need to stay as Expressions.
32974 * typemanager.cs (CSharpName): Returns the C# name of a type if
32977 * expression.cs (Expression::ConvertImplicit): New function that
32978 implements implicit type conversions.
32980 (Expression::ImplicitReferenceConversion): Implements implicit
32981 reference conversions.
32983 (EmptyCast): New type for transparent casts.
32985 (OpcodeCast): New type for casts of types that are performed with
32986 a sequence of bytecodes.
32988 (BoxedCast): New type used for casting value types into reference
32989 types. Emits a box opcode.
32991 (Binary::DoNumericPromotions): Implements numeric promotions of
32992 and computation of the Binary::Type.
32994 (Binary::EmitBranchable): Optimization.
32996 (Binary::Emit): Implement code emission for expressions.
32998 * typemanager.cs (TypeManager): Added two new core types: sbyte
33001 2001-09-12 Ravi Pratap <ravi@ximian.com>
33003 * class.cs (TypeContainer::FindMembers): Method which does exactly
33004 what Type.FindMembers does, only we don't have to use reflection. No
33005 implementation yet.
33007 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
33008 typecontainer objects as we need to get at them.
33009 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
33011 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
33012 typecontainer object.
33014 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
33015 of just a Report object.
33017 2001-09-11 Ravi Pratap <ravi@ximian.com>
33019 * class.cs (Event::Define): Go back to using the prefixes "add_" and
33021 (TypeContainer::Populate): Now define the delegates of the type too.
33022 (TypeContainer.Delegates): Property to access the list of delegates defined
33025 * delegates.cs (Delegate::Define): Implement partially.
33027 * modifiers.cs (TypeAttr): Handle more flags.
33029 2001-09-11 Ravi Pratap <ravi@ximian.com>
33031 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
33033 (Operator::Define): Re-write logic to get types by using the LookupType method
33034 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
33035 (Indexer::Define): Ditto.
33036 (Event::Define): Ditto.
33037 (Property::Define): Ditto.
33039 2001-09-10 Ravi Pratap <ravi@ximian.com>
33041 * class.cs (TypeContainer::Populate): Now define operators too.
33042 (TypeContainer.Operators): New property to access the list of operators
33044 (Operator.OperatorMethodBuilder): New member to hold the method builder
33045 for the operator we are defining.
33046 (Operator::Define): Implement.
33048 2001-09-10 Ravi Pratap <ravi@ximian.com>
33050 * class.cs (Event::Define): Make the prefixes of the accessor methods
33051 addOn_ and removeOn_
33053 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
33054 of the location being passed in too. Ideally, this should go later since all
33055 error reporting should be done through the Report object.
33057 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
33058 (Populate): Iterate thru the indexers we have and define them too.
33059 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
33060 for the get and set accessors.
33061 (Indexer::Define): Implement.
33063 2001-09-09 Miguel de Icaza <miguel@ximian.com>
33065 * expression.cs (Binary::Resolve): Beginning of it. I scratched
33066 my previous implementation, did not work.
33068 * typemanager.cs: Add a couple of missing types (the longs).
33070 * literal.cs: Use TypeManager.bool_type instead of getting it.
33072 * expression.cs (EventExpr): New kind of expressions.
33073 (Expressio::ExprClassFromMemberInfo): finish
33075 2001-09-08 Miguel de Icaza <miguel@ximian.com>
33077 * assign.cs: Emit stores to static fields differently.
33079 2001-09-08 Ravi Pratap <ravi@ximian.com>
33081 * Merge in changes and adjust code to tackle conflicts. Backed out my
33082 code in Assign::Resolve ;-)
33084 2001-09-08 Ravi Pratap <ravi@ximian.com>
33086 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
33087 instead Report.Error and also pass in the location.
33088 (CSharpParser::Lexer): New readonly property to return the reference
33089 to the Tokenizer object.
33090 (declare_local_variables): Use Report.Error with location instead of plain
33094 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
33095 (Operator.CheckBinaryOperator): Ditto.
33097 * cs-parser.jay (operator_declarator): Update accordingly.
33099 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
33100 (CheckBinaryOperator): Same here.
33102 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
33103 on the name without any prefixes of namespace names etc. This is because we
33104 already might have something already fully qualified like
33105 'System.Console.WriteLine'
33107 * assign.cs (Resolve): Begin implementation. Stuck ;-)
33109 2001-09-07 Ravi Pratap <ravi@ximian.com>
33111 * cs-tokenizer.cs (location): Return a string which also contains
33114 * expression.cs (ElementAccess): New class for expressions of the
33115 type 'element access.'
33116 (BaseAccess): New class for expressions of the type 'base access.'
33117 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
33120 * cs-parser.jay (element_access): Implement action.
33121 (base_access): Implement actions.
33122 (checked_expression, unchecked_expression): Implement.
33124 * cs-parser.jay (local_variable_type): Correct and implement.
33125 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
33127 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
33129 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
33130 name and the specifiers.
33132 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
33134 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
33135 making them all public ;-)
33137 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
33140 2001-09-07 Miguel de Icaza <miguel@ximian.com>
33142 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
33144 (FieldExpr, PropertyExprs): New resolved expressions.
33145 (SimpleName::MemberStaticCheck): Perform static checks for access
33146 to non-static fields on static methods. Maybe this should be
33147 generalized for MemberAccesses.
33148 (SimpleName::ResolveSimpleName): More work on simple name
33151 * cs-parser.jay (primary_expression/qualified_identifier): track
33152 the parameter index.
33154 * codegen.cs (CodeGen::Save): Catch save exception, report error.
33155 (EmitContext::EmitBoolExpression): Chain to expression generation
33156 instead of temporary hack.
33157 (::EmitStatementExpression): Put generic expression code generation.
33159 * assign.cs (Assign::Emit): Implement variable assignments to
33160 local variables, parameters and fields.
33162 2001-09-06 Miguel de Icaza <miguel@ximian.com>
33164 * statement.cs (Block::GetVariableInfo): New method, returns the
33165 VariableInfo for a variable name in a block.
33166 (Block::GetVariableType): Implement in terms of GetVariableInfo
33168 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
33169 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
33171 2001-09-06 Ravi Pratap <ravi@ximian.com>
33173 * cs-parser.jay (operator_declaration): Continue on my quest : update
33174 to take attributes argument.
33175 (event_declaration): Ditto.
33176 (enum_declaration): Ditto.
33177 (indexer_declaration): Ditto.
33179 * class.cs (Operator::Operator): Update constructor accordingly.
33180 (Event::Event): Ditto.
33182 * delegate.cs (Delegate::Delegate): Same here.
33184 * enum.cs (Enum::Enum): Same here.
33186 2001-09-05 Ravi Pratap <ravi@ximian.com>
33188 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
33190 * ../tests/cs0658.cs : New file to demonstrate error 0658.
33192 * attribute.cs (Attributes): New class to encapsulate all attributes which were
33193 being passed around as an arraylist.
33194 (Attributes::AddAttribute): Method to add attribute sections.
33196 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
33197 (struct_declaration): Update accordingly.
33198 (constant_declaration): Update.
33199 (field_declaration): Update.
33200 (method_header): Update.
33201 (fixed_parameter): Update.
33202 (parameter_array): Ditto.
33203 (property_declaration): Ditto.
33204 (destructor_declaration): Ditto.
33206 * class.cs (Struct::Struct): Update constructors accordingly.
33207 (Class::Class): Ditto.
33208 (Field::Field): Ditto.
33209 (Method::Method): Ditto.
33210 (Property::Property): Ditto.
33211 (TypeContainer::OptAttribute): update property's return type.
33213 * interface.cs (Interface.opt_attributes): New member.
33214 (Interface::Interface): Update to take the extra Attributes argument.
33216 * parameter.cs (Parameter::Parameter): Ditto.
33218 * constant.cs (Constant::Constant): Ditto.
33220 * interface.cs (InterfaceMemberBase): New OptAttributes field.
33221 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
33222 the attributes as a parameter.
33223 (InterfaceProperty): Update constructor call.
33224 (InterfaceEvent): Ditto.
33225 (InterfaceMethod): Ditto.
33226 (InterfaceIndexer): Ditto.
33228 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
33229 pass the attributes too.
33230 (interface_event_declaration): Ditto.
33231 (interface_property_declaration): Ditto.
33232 (interface_method_declaration): Ditto.
33233 (interface_declaration): Ditto.
33235 2001-09-05 Miguel de Icaza <miguel@ximian.com>
33237 * class.cs (Method::Define): Track the "static Main" definition to
33238 create an entry point.
33240 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
33241 EntryPoint if we find it.
33243 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
33244 (EmitContext::ig): Make this variable public.
33246 * driver.cs: Make the default output file be the first file name
33247 with the .exe extension.
33249 Detect empty compilations
33251 Handle various kinds of output targets. Handle --target and
33252 rename -t to --dumper.
33254 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
33255 methods inherited from Expression return now an Expression. This
33256 will is used during the tree rewriting as we resolve them during
33259 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
33260 the spec. Missing entirely is the information about
33261 accessability of elements of it.
33263 (Expression::ExprClassFromMemberInfo): New constructor for
33264 Expressions that creates a fully initialized Expression based on
33265 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
33268 (Invocation::Resolve): Begin implementing resolution of invocations.
33270 * literal.cs (StringLiteral): Implement Emit.
33272 2001-09-05 Ravi Pratap <ravi@ximian.com>
33274 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
33277 2001-09-04 Ravi Pratap <ravi@ximian.com>
33279 * cs-parser.jay (attribute_arguments): Implement actions.
33280 (attribute): Fix bug in production. Implement action.
33281 (attribute_list): Implement.
33282 (attribute_target): Implement.
33283 (attribute_target_specifier, opt_target_specifier): Implement
33284 (CheckAttributeTarget): New method to check if the attribute target
33286 (attribute_section): Implement.
33287 (opt_attributes): Implement.
33289 * attribute.cs : New file to handle attributes.
33290 (Attribute): Class to hold attribute info.
33292 * cs-parser.jay (opt_attribute_target_specifier): Remove production
33293 (attribute_section): Modify production to use 2 different rules to
33294 achieve the same thing. 1 s/r conflict down !
33295 Clean out commented, useless, non-reducing dimension_separator rules.
33297 * class.cs (TypeContainer.attributes): New member to hold list
33298 of attributes for a type.
33299 (Struct::Struct): Modify to take one more argument, the attribute list.
33300 (Class::Class): Ditto.
33301 (Field::Field): Ditto.
33302 (Method::Method): Ditto.
33303 (Property::Property): Ditto.
33305 * cs-parser.jay (struct_declaration): Update constructor call to
33306 pass in the attributes too.
33307 (class_declaration): Ditto.
33308 (constant_declaration): Ditto.
33309 (field_declaration): Ditto.
33310 (method_header): Ditto.
33311 (fixed_parameter): Ditto.
33312 (parameter_array): Ditto.
33313 (property_declaration): Ditto.
33315 * constant.cs (Constant::Constant): Update constructor similarly.
33316 Use System.Collections.
33318 * parameter.cs (Parameter::Parameter): Update as above.
33320 2001-09-02 Ravi Pratap <ravi@ximian.com>
33322 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33323 (TypeContainer.delegates): New member to hold list of delegates.
33325 * cs-parser.jay (delegate_declaration): Implement the action correctly
33326 this time as I seem to be on crack ;-)
33328 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33330 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33331 tell whether an identifier represents a namespace.
33333 * expression.cs (NamespaceExpr): A namespace expression, used only
33334 temporarly during expression resolution.
33335 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33336 utility functions to resolve names on expressions.
33338 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33340 * codegen.cs: Add hook for StatementExpressions.
33342 * class.cs: Fix inverted test for static flag in methods.
33344 2001-09-02 Ravi Pratap <ravi@ximian.com>
33346 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33347 to make it coincide with MS' number.
33348 (Operator::CheckBinaryOperator): Ditto.
33350 * ../errors/errors.txt : Remove error numbers added earlier.
33352 * ../errors/cs1019.cs : Test case for error # 1019
33354 * ../errros/cs1020.cs : Test case for error # 1020
33356 * cs-parser.jay : Clean out commented cruft.
33357 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33358 used anywhere - non-reducing rule.
33359 (namespace_declarations): Non-reducing rule - comment out.
33361 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33362 with TypeContainer::AddEnum.
33364 * delegate.cs : New file for delegate handling classes.
33365 (Delegate): Class for declaring delegates.
33367 * makefile : Update.
33369 * cs-parser.jay (delegate_declaration): Implement.
33371 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33373 * class.cs (Event::Define): Implement.
33374 (Event.EventBuilder): New member.
33376 * class.cs (TypeContainer::Populate): Update to define all enums and events
33378 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33379 readonly fields for all these cases ?
33381 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33383 * class.cs (Property): Revamp to use the convention of making fields readonly.
33384 Accordingly modify code elsewhere.
33386 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33387 the Define method of the Property class.
33389 * class.cs : Clean up applied patch and update references to variables etc. Fix
33391 (TypeContainer::Populate): Update to define all the properties we have. Also
33392 define all enumerations.
33394 * enum.cs (Define): Implement.
33396 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33398 * cs-parser.jay (overloadable_operator): The semantic value is an
33399 enum of the Operator class.
33400 (operator_declarator): Implement actions.
33401 (operator_declaration): Implement.
33403 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33404 validity of definitions.
33405 (Operator::CheckBinaryOperator): Static method to check for binary operators
33406 (TypeContainer::AddOperator): New method to add an operator to a type.
33408 * cs-parser.jay (indexer_declaration): Added line to actually call the
33409 AddIndexer method so it gets added ;-)
33411 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33412 already taken care of by the MS compiler ?
33414 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33416 * class.cs (Operator): New class for operator declarations.
33417 (Operator::OpType): Enum for the various operators.
33419 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33421 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33422 ostensibly handle this in semantic analysis.
33424 * cs-parser.jay (general_catch_clause): Comment out
33425 (specific_catch_clauses, specific_catch_clause): Ditto.
33426 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33427 (catch_args, opt_catch_args): New productions.
33428 (catch_clause): Rewrite to use the new productions above
33429 (catch_clauses): Modify accordingly.
33430 (opt_catch_clauses): New production to use in try_statement
33431 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33432 and re-write the code in the actions to extract the specific and
33433 general catch clauses by being a little smart ;-)
33435 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33436 Hooray, try and catch statements parse fine !
33438 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33440 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33441 string from the hashtable of variables.
33443 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33444 I end up making that mistake ;-)
33445 (catch_clauses): Fixed gross error which made Key and Value of the
33446 DictionaryEntry the same : $1 !!
33448 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33450 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33452 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33453 when the add and remove accessors are specified.
33455 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33457 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33458 information about indexer_declarator.
33459 (indexer_declarator): Implement actions.
33460 (parsing_indexer): New local boolean used to keep track of whether
33461 we are parsing indexers or properties. This is necessary because
33462 implicit_parameters come into picture even for the get accessor in the
33463 case of an indexer.
33464 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33466 * class.cs (Indexer): New class for indexer declarations.
33467 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33468 (TypeContainer::indexers): New member to hold list of indexers for the
33471 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33473 * cs-parser.jay (add_accessor_declaration): Implement action.
33474 (remove_accessor_declaration): Implement action.
33475 (event_accessors_declaration): Implement
33476 (variable_declarators): swap statements for first rule - trivial.
33478 * class.cs (Event): New class to hold information about event
33480 (TypeContainer::AddEvent): New method to add an event to a type
33481 (TypeContainer::events): New member to hold list of events.
33483 * cs-parser.jay (event_declaration): Implement actions.
33485 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33487 * cs-parser.jay (dim_separators): Implement. Make it a string
33488 concatenating all the commas together, just as they appear.
33489 (opt_dim_separators): Modify accordingly
33490 (rank_specifiers): Update accordingly. Basically do the same
33491 thing - instead, collect the brackets here.
33492 (opt_rank_sepcifiers): Modify accordingly.
33493 (array_type): Modify to actually return the complete type string
33494 instead of ignoring the rank_specifiers.
33495 (expression_list): Implement to collect the expressions
33496 (variable_initializer): Implement. We make it a list of expressions
33497 essentially so that we can handle the array_initializer case neatly too.
33498 (variable_initializer_list): Implement.
33499 (array_initializer): Make it a list of variable_initializers
33500 (opt_array_initializer): Modify accordingly.
33502 * expression.cs (New::NType): Add enumeration to help us
33503 keep track of whether we have an object/delegate creation
33504 or an array creation.
33505 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33506 members to hold data about array creation.
33507 (New:New): Modify to update NewType
33508 (New:New): New Overloaded contructor for the array creation
33511 * cs-parser.jay (array_creation_expression): Implement to call
33512 the overloaded New constructor.
33514 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33516 * class.cs (TypeContainer::Constructors): Return member
33517 constructors instead of returning null.
33519 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33521 * typemanager.cs (InitCoreTypes): Initialize the various core
33522 types after we have populated the type manager with the user
33523 defined types (this distinction will be important later while
33524 compiling corlib.dll)
33526 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33527 on Expression Classification. Now all expressions have a method
33528 `Resolve' and a method `Emit'.
33530 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33531 generation from working. Also add some temporary debugging
33534 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33536 * codegen.cs: Lots of code generation pieces. This is only the
33537 beginning, will continue tomorrow with more touches of polish. We
33538 handle the fundamentals of if, while, do, for, return. Others are
33539 trickier and I need to start working on invocations soon.
33541 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33544 * codegen.cs (EmitContext): New struct, used during code
33545 emission to keep a context. Most of the code generation will be
33548 * cs-parser.jay: Add embedded blocks to the list of statements of
33549 this block. So code generation proceeds in a top down fashion.
33551 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33553 * statement.cs: Add support for multiple child blocks.
33555 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33557 * codegen.cs (EmitCode): New function, will emit the code for a
33558 Block of code given a TypeContainer and its ILGenerator.
33560 * statement.cs (Block): Standard public readonly optimization.
33561 (Block::Block constructors): Link children.
33562 (Block::Child): Child Linker.
33563 (Block::EmitVariables): Emits IL variable declarations.
33565 * class.cs: Drop support for MethodGroups here, delay until
33567 (Method::): Applied the same simplification that I did before, and
33568 move from Properties to public readonly fields.
33569 (Method::ParameterTypes): Returns the parameter types for the
33570 function, and implements a cache that will be useful later when I
33571 do error checking and the semantic analysis on the methods is
33573 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33574 and made a method, optional argument tells whether this is a class
33575 or a structure to apply the `has-this' bit.
33576 (Method::GetCallingConvention): Implement, returns the calling
33578 (Method::Define): Defines the type, a second pass is performed
33579 later to populate the methods.
33581 (Constructor::ParameterTypes): implement a cache similar to the
33582 one on Method::ParameterTypes, useful later when we do semantic
33585 (TypeContainer::EmitMethod): New method. Emits methods.
33587 * expression.cs: Removed MethodGroup class from here.
33589 * parameter.cs (Parameters::GetCallingConvention): new method.
33591 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33593 * class.cs (TypeContainer::Populate): Drop RootContext from the
33596 (Constructor::CallingConvention): Returns the calling convention.
33597 (Constructor::ParameterTypes): Returns the constructor parameter
33600 (TypeContainer::AddConstructor): Keep track of default constructor
33601 and the default static constructor.
33603 (Constructor::) Another class that starts using `public readonly'
33604 instead of properties.
33606 (Constructor::IsDefault): Whether this is a default constructor.
33608 (Field::) use readonly public fields instead of properties also.
33610 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33611 track of static constructors; If none is used, turn on
33612 BeforeFieldInit in the TypeAttributes.
33614 * cs-parser.jay (opt_argument_list): now the return can be null
33615 for the cases where there are no arguments.
33617 (constructor_declarator): If there is no implicit `base' or
33618 `this', then invoke the default parent constructor.
33620 * modifiers.cs (MethodAttr): New static function maps a set of
33621 modifiers flags into a MethodAttributes enum
33622 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33623 MethodAttr, TypeAttr to represent the various mappings where the
33624 modifiers are used.
33625 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33627 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33629 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33632 * interface.cs (PopulateIndexer): Implemented the code generator
33633 for interface indexers.
33635 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33637 * interface.cs (InterfaceMemberBase): Now we track the new status
33640 (PopulateProperty): Implement property population. Woohoo! Got
33641 Methods and Properties going today.
33643 Removed all the properties for interfaces, and replaced them with
33644 `public readonly' fields.
33646 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33648 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33649 initialize their hashtables/arraylists only when they are needed
33650 instead of doing this always.
33652 * parameter.cs: Handle refs and out parameters.
33654 * cs-parser.jay: Use an ArrayList to construct the arguments
33655 instead of the ParameterCollection, and then cast that to a
33658 * parameter.cs: Drop the use of ParameterCollection and use
33659 instead arrays of Parameters.
33661 (GetParameterInfo): Use the Type, not the Name when resolving
33664 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33666 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33667 and instead use public readonly fields.
33669 * class.cs: Put back walking code for type containers.
33671 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33673 * class.cs (MakeConstant): Code to define constants.
33675 * rootcontext.cs (LookupType): New function. Used to locate types
33678 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33680 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33681 this System.Reflection code is. Kudos to Microsoft
33683 * typemanager.cs: Implement a type cache and avoid loading all
33684 types at boot time. Wrap in LookupType the internals. This made
33685 the compiler so much faster. Wow. I rule!
33687 * driver.cs: Make sure we always load mscorlib first (for
33688 debugging purposes, nothing really important).
33690 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33691 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33693 * rootcontext.cs: Lookup types on their namespace; Lookup types
33694 on namespaces that have been imported using the `using' keyword.
33696 * class.cs (TypeContainer::TypeAttr): Virtualize.
33697 (Class::TypeAttr): Return attributes suitable for this bad boy.
33698 (Struct::TypeAttr): ditto.
33699 Handle nested classes.
33700 (TypeContainer::) Remove all the type visiting code, it is now
33701 replaced with the rootcontext.cs code
33703 * rootcontext.cs (GetClassBases): Added support for structs.
33705 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33707 * interface.cs, statement.cs, class.cs, parameter.cs,
33708 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33709 Drop use of TypeRefs, and use strings instead.
33711 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33715 * class.cs (Struct::Struct): set the SEALED flags after
33716 checking the modifiers.
33717 (TypeContainer::TypeAttr): new property, returns the
33718 TypeAttributes for a class.
33720 * cs-parser.jay (type_list): Oops, list production was creating a
33721 new list of base types.
33723 * rootcontext.cs (StdLib): New property.
33724 (GetInterfaceTypeByName): returns an interface by type name, and
33725 encapsulates error handling here.
33726 (GetInterfaces): simplified.
33727 (ResolveTree): Encapsulated all the tree resolution here.
33728 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33731 * driver.cs: Add support for --nostdlib, to avoid loading the
33732 default assemblies.
33733 (Main): Do not put tree resolution here.
33735 * rootcontext.cs: Beginning of the class resolution.
33737 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33739 * rootcontext.cs: Provide better error reporting.
33741 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33743 * rootcontext.cs (CreateInterface): Handle the case where there
33744 are no parent interfaces.
33746 (CloseTypes): Routine to flush types at the end.
33747 (CreateInterface): Track types.
33748 (GetInterfaces): Returns an array of Types from the list of
33749 defined interfaces.
33751 * typemanager.c (AddUserType): Mechanism to track user types (puts
33752 the type on the global type hash, and allows us to close it at the
33755 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33757 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33758 RecordInterface instead.
33760 * cs-parser.jay: Updated to reflect changes above.
33762 * decl.cs (Definition): Keep track of the TypeBuilder type that
33763 represents this type here. Not sure we will use it in the long
33764 run, but wont hurt for now.
33766 * driver.cs: Smaller changes to accomodate the new code.
33768 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33771 * rootcontext.cs (CreateInterface): New method, used to create
33772 the System.TypeBuilder type for interfaces.
33773 (ResolveInterfaces): new entry point to resolve the interface
33775 (CodeGen): Property, used to keep track of the code generator.
33777 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33779 * cs-parser.jay: Add a second production for delegate_declaration
33782 (enum_body): Put an opt_comma here instead of putting it on
33783 enum_body or enum_member_declarations so we can handle trailing
33784 commas on enumeration members. Gets rid of a shift/reduce.
33786 (type_list): Need a COMMA in the middle.
33788 (indexer_declaration): Tell tokenizer to recognize get/set
33790 * Remove old targets.
33792 * Re-add the parser target.
33794 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33796 * cs-parser.jay: Add precendence rules for a number of operators
33797 ot reduce the number of shift/reduce conflicts in the grammar.
33799 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33801 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33804 Get rid of old crufty code.
33806 * rootcontext.cs: Use this to keep track of the parsed
33807 representation and the defined types available to the program.
33809 * gen-treedump.cs: adjust for new convention.
33811 * type.cs: Split out the type manager, and the assembly builder
33814 * typemanager.cs: the type manager will live here now.
33816 * cil-codegen.cs: And the code generator here.
33818 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33820 * makefile: Fixed up for easy making.
33822 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33824 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33827 (unary_expression): Expand pre_increment_expression and
33828 post_decrement_expression to reduce a shift/reduce.
33830 2001-07-11 Simon Cozens
33832 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33834 Improve allow_keyword_as_indent name.
33836 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33838 * Adjustments for Beta2.
33840 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33842 * decl.cs: Added `Define' abstract method.
33843 (InTransit): new property, used to catch recursive definitions.
33845 * interface.cs: Implement `Define'.
33847 * modifiers.cs: Map Modifiers.constants to
33848 System.Reflection.TypeAttribute flags.
33850 * class.cs: Keep track of types and user-defined types.
33851 (BuilderInit): New method for creating an assembly
33852 (ResolveType): New function to launch the resolution process, only
33853 used by interfaces for now.
33855 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33856 that are inserted into the name space.
33858 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33860 * ARGH. I have screwed up my tree so many times due to the use of
33861 rsync rather than using CVS. Going to fix this at once.
33863 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33866 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33868 * Experiment successful: Use System.Type rather that our own
33871 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33873 * cs-parser.jay: Removed nsAliases from here.
33875 Use new namespaces, handle `using XXX;'
33877 * namespace.cs: Reimplemented namespace handling, use a recursive
33878 definition of the class. Now we can keep track of using clauses
33879 and catch invalid using clauses.
33881 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33883 * gen-treedump.cs: Adapted for all the renaming.
33885 * expression.cs (Expression): this class now has a Type property
33886 which returns an expression Type.
33888 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33889 `Type', as this has a different meaning now in the base
33891 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33893 * interface.cs, class.cs: Removed from all the sources the
33894 references to signature computation, as we can not do method
33895 signature computation during the parsing time, as we are not
33896 trying to solve at that point distinguishing:
33900 void a (NS.Blah x) {}
33903 Which depending on the context might be valid or not, as we do not
33904 know if Blah is the same thing as NS.Blah at that point.
33906 * Redid everything so the code uses TypeRefs now instead of
33907 Types. TypeRefs are just temporary type placeholders, that need
33908 to be resolved. They initially have a pointer to a string and the
33909 current scope in which they are used. This is used later by the
33910 compiler to resolve the reference to an actual Type.
33912 * DeclSpace is no longer a CIR.Type, and neither are
33913 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33914 are all DeclSpaces, but no Types.
33916 * type.cs (TypeRefManager): This implements the TypeRef manager,
33917 which keeps track of all the types that need to be resolved after
33918 the parsing has finished.
33920 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33922 * ARGH. We are going to have to store `foreach' as a class rather
33923 than resolving it, as we need to verify error 1579 after name
33924 resolution. *OR* we could keep a flag that says `This request to
33925 IEnumerator comes from a foreach statement' which we can then use
33926 to generate the error.
33928 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33930 * class.cs (TypeContainer.AddMethod): we now add methods to the
33931 MethodGroup instead of the method hashtable.
33933 * expression.cs: Add MethodGroup abstraction, which gets us one
33934 step closer to the specification in the way we handle method
33937 * cs-parser.jay (primary_expression): qualified_identifier now
33938 tried to match up an identifier to a local variable reference or
33939 to a parameter reference.
33941 current_local_parameters is now a parser global variable that
33942 points to the current parameters for the block, used during name
33945 (property_declaration): Now creates an implicit `value' argument to
33948 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33950 * parameter.cs: Do not use `param' arguments as part of the
33951 signature, per the spec.
33953 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33955 * decl.cs: Base class for classes, structs and interfaces. This
33956 is the "Declaration Space"
33958 * cs-parser.jay: Use CheckDef for checking declaration errors
33959 instead of having one on each function.
33961 * class.cs: Factor out some code for handling error handling in
33962 accordance to the "Declarations" section in the "Basic Concepts"
33963 chapter in the ECMA C# spec.
33965 * interface.cs: Make all interface member classes derive from
33966 InterfaceMemberBase.
33968 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33970 * Many things: all interfaces are parsed and generated in
33971 gen-treedump. Support for member variables, constructors,
33972 destructors, properties, constants is there.
33974 Beginning of the IL backend, but very little done, just there for
33977 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33979 * cs-parser.jay: Fix labeled statement.
33981 * cs-tokenizer.cs (escape): Escape " and ' always.
33982 ref_line, ref_name: keep track of the line/filename as instructed
33983 by #line by the compiler.
33986 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33988 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33989 to match the values in System.CodeDOM.
33991 Divid renamed to Divide.
33993 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33995 (Statements.set): remove.
33997 * System.CodeDOM/CodeCatchClause.cs: always have a valid
34000 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
34001 falseStatements always have valid values.
34003 * cs-parser.jay: Use System.CodeDOM now.