1 2010-07-09 Marek Safar <marek.safar@gmail.com>
3 * property.cs, parameters.cs: Inflated IndexerSpec parameters.
5 * import.cs: Don't build unused parameters.
7 2010-07-08 Marek Safar <marek.safar@gmail.com>
9 * expression.cs (Invocation): Don't recreate simple-name expression.
11 2010-07-07 Marek Safar <marek.safar@gmail.com>
13 * ecore.cs: Don't report NRE warning for lifted null.
15 2010-07-07 Marek Safar <marek.safar@gmail.com>
17 * typemanager.cs, convert.cs, expression.cs: Another reference
18 equality implementation attack (Fixes #620025, #579058).
20 2010-07-05 Marek Safar <marek.safar@gmail.com>
22 * context.cs, expression.cs, ecore.cs: BaseThis is fully based on
23 this expression (Fixes #619904).
25 2010-07-05 Marek Safar <marek.safar@gmail.com>
27 * membercache.cs, class.cs: Don't use base member to check for
28 property or indexer base implementation.
30 2010-07-03 Marek Safar <marek.safar@gmail.com>
32 * membercache.cs: Copy Membercache member state flags for 2 stage
33 inflate (Fixes #619555).
35 * ecore.cs: Use resolved accessors everywhere.
37 2010-07-02 Marek Safar <marek.safar@gmail.com>
40 * membercache.cs, property.cs: Check accessors of base property and
43 2010-07-02 Marek Safar <marek.safar@gmail.com>
45 * modifiers.cs, membercache.cs, import.cs, class.cs: Moved imported
46 override method checks into import.
48 * expression.cs: Removed redundant check.
50 2010-06-30 Marek Safar <marek.safar@gmail.com>
52 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs,
53 delegate.cs, cs-parser.jay, visit.cs: Use MemberAccess to resolve
54 base access expression, it has all bits done correctly.
56 2010-06-30 Marek Safar <marek.safar@gmail.com>
58 * support.cs: Removed unused code.
60 * ecore.cs: Don't use memberlookup for operators.
62 2010-06-30 Marek Safar <marek.safar@gmail.com>
64 * typemanager.cs, membercache.cs, convert.cs, expression.cs,
65 ecore.cs: Replace remaining MethodLookup with correct user operator
66 lookup (to do correct deep lookup). Clean up most of outstanding
67 quirks in binary operator overload resolution.
69 2010-06-29 Marek Safar <marek.safar@gmail.com>
71 * import.cs: Operators must have between 1 and 2 parameters.
73 * method.cs: Switch destructor to direct membercache lookup
75 2010-06-29 Marek Safar <marek.safar@gmail.com>
77 * driver.cs, expression.cs: Use Membercache for StringConcat when
78 it got all what is needed.
80 2010-06-29 Marek Safar <marek.safar@gmail.com>
82 * membercache.cs, expression.cs, statement.cs, doc.cs, ecore.cs:
83 Changed FindMembers to allocate a new list only when a filter is
84 used. Saves decent chunk of memory and should save even more in the
85 future when the filter is not used that often.
87 2010-06-28 Marek Safar <marek.safar@gmail.com>
89 * field.cs, property.cs, assign.cs, const.cs, expression.cs,
90 ecore.cs, class.cs, cs-parser.jay, enum.cs: Don't use intermediate
91 structure for simple type fields (saves memory and makes few things
92 simpler). Clean up some hacks mostly for events.
94 2010-06-25 Marek Safar <marek.safar@gmail.com>
96 * statement.cs, cs-parser.jay: Don't create expensive block for
99 2010-06-24 Marek Safar <marek.safar@gmail.com>
101 * statement.cs, report.cs: Rethrow internal error when reporting is
104 * ecore.cs: Check for identical name only when simple name is set.
107 2010-06-24 Marek Safar <marek.safar@gmail.com>
109 A fix for bug #616809
110 * generic.cs, expression.cs, ecore.cs: Added a new type expression
111 for open generic type to pass unbound type arguments to typeof
114 2010-06-24 Marek Safar <marek.safar@gmail.com>
116 * statement.cs: Foreach collection implementation refactoring to
117 search for GetEnumerator more preciselly. Fixes #431453 and more
120 * linq.cs, decl.cs, ecore.cs, delegate.cs: Update methodgroup api.
122 2010-06-23 Marek Safar <marek.safar@gmail.com>
124 * cs-parser.jay: Track more locations.
126 2010-06-22 Marek Safar <marek.safar@gmail.com>
128 * cs-tokenizer.cs, location.cs, cs-parser.jay: Track more locations.
130 2010-06-18 Marek Safar <marek.safar@gmail.com>
132 * cs-tokenizer.cs, anonymous.cs, expression.cs, statement.cs,
133 support.cs, location.cs, cs-parser.jay: Some work on full ast mode.
135 2010-06-18 Marek Safar <marek.safar@gmail.com>
137 * convert.cs, typespec.cs, method.cs: Fixed few more dynamic
140 2010-06-18 Marek Safar <marek.safar@gmail.com>
142 * typemanager.cs, namespace.cs: Report more predefined types and
143 imported types collision types as a warning.
144 Fixes #537414, #601157
146 2010-06-18 Marek Safar <marek.safar@gmail.com>
148 * generic.cs: Overrides base method constraint can use method type
151 * import.cs: Removed redundant cache.
153 2010-06-17 Marek Safar <marek.safar@gmail.com>
155 * generic.cs: Propagate type only inflate downwards.
157 2010-06-17 Marek Safar <marek.safar@gmail.com>
159 A fix for bug #614955
160 * method.cs: Do not reject binary dynamic operators.
162 2010-06-17 Marek Safar <marek.safar@gmail.com>
164 * typespec.cs: Internal types have no generic parameters.
167 2010-06-17 Marek Safar <marek.safar@gmail.com>
169 A fix for bug #614955
170 * cs-parser.jay: Correctly set expression mode for default parameter
173 2010-06-17 Marek Safar <marek.safar@gmail.com>
175 A fix for bug #615023
176 * ecore.cs: Resolve dynamic namespace and keyword collision in the
177 favour of the keyword.
179 2010-06-17 Marek Safar <marek.safar@gmail.com>
181 A fix for bug #614917
182 * convert.cs: Allow more undocumented 0 like values to enum type
185 2010-06-17 Marek Safar <marek.safar@gmail.com>
187 * generic.cs, method.cs: Inflate copied type parameters from base
188 class or explicit interfaces.
190 * convert.cs: Fixed conversion between two type parameters.
193 2010-06-16 Marek Safar <marek.safar@gmail.com>
195 * membercache.cs, convert.cs: Correctly resize an array used by
198 2010-06-15 Marek Safar <marek.safar@gmail.com>
200 A fix for bug #599601
201 * dynamic.cs, ecore.cs: A new flag for dynamic resolver to ignore
202 generated member access left expression.
204 2010-06-16 Marek Safar <marek.safar@gmail.com>
206 * expression.cs: Dispatch dynamic invocation solely on left
209 2010-06-16 Marek Safar <marek.safar@gmail.com>
211 * expression.cs, statement.cs: Always persist explicit cast
212 semantic at expression level.
214 2010-06-15 Marek Safar <marek.safar@gmail.com>
216 * expression.cs, attribute.cs: Enable generic type parameters
219 2010-06-15 Marek Safar <marek.safar@gmail.com>
221 A fix for bug #612146
222 * generic.cs: Don't use fixed array for inflated type parameter
223 interface constraints.
225 2010-06-15 Marek Safar <marek.safar@gmail.com>
227 * typespec.cs: ElementTypeSpec has to use its own ITypeDefinition.
229 * report.cs: Unwrap elements for related symbols reporting.
231 2010-06-15 Marek Safar <marek.safar@gmail.com>
233 A fix for bug #612796
234 * cs-tokenizer.cs: Offset correctly keywords the first character
237 2010-06-15 Marek Safar <marek.safar@gmail.com>
239 A fix for bug #613397
240 * expression.cs: Removed too aggressive object initializers
243 2010-06-15 Marek Safar <marek.safar@gmail.com>
245 * parameter.cs, property.cs, membercache.cs, decl.cs, iterators.cs,
246 anonymous.cs, expression.cs, support.cs, method.cs, pending.cs,
247 class.cs, cs-parser.jay: Simplify parsing of accessors by removing
248 any intermediate steps and fake nodes, also saves few MBs of memory.
250 2010-06-11 Marek Safar <marek.safar@gmail.com>
252 * modifiers.cs, rootcontext.cs, location.cs, cs-parser.jay: More
253 precise modifiers parsing.
255 2010-06-09 Marek Safar <marek.safar@gmail.com>
257 * cs-tokenizer.cs, anonymous.cs, expression.cs, cs-parser.jay:
258 Fixed few shift/reduce conflicts.
260 2010-06-09 Marek Safar <marek.safar@gmail.com>
262 * typemanager.cs, parameter.cs, dynamic.cs, typespec.cs,
263 expression.cs, ecore.cs, cs-parser.jay: Fully parse composed type
264 specifiers and stop using string in AST.
266 2010-06-07 Marek Safar <marek.safar@gmail.com>
268 * typemanager.cs, eval.cs, iterators.cs, anonymous.cs, expression.cs
269 method.cs, class.cs, delegate.cs, cs-parser.jay, driver.cs, visit.cs
270 enum.cs: Hold location of predefined types.
272 2010-06-07 Marek Safar <marek.safar@gmail.com>
274 A fix for bug #610878
275 * pending.cs: Clone cached list before modifying.
277 2010-06-04 Marek Safar <marek.safar@gmail.com>
279 * convert.cs, typespec.cs, expression.cs: Start using array member
280 kind for better conversion checks.
282 * import.cs, report.cs: Report better error message for runtime
285 2010-06-04 Marek Safar <marek.safar@gmail.com>
287 * membercache.cs, convert.cs, nullable.cs, expression.cs: Optimize
288 user defined conversion probing and simplify user conversion for
289 nullabe types. Fixes #610940.
291 2010-06-03 Marek Safar <marek.safar@gmail.com>
293 A fix for bug #610919
294 * parameter.cs, property.cs, cs-parser.jay: Use independent implicit
295 parameters for explicit event accessors. Anonymous method capturing
296 won't otherwise work for event implicit parameter.
298 2010-06-02 Marek Safar <marek.safar@gmail.com>
300 A fix for bug #610088
301 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs:
302 Ignore overrides for base overload resolution as for non-base
303 expressions and convert the best candidate to closest override
306 2010-06-01 Marek Safar <marek.safar@gmail.com>
308 A fix for bug #610139
309 * generic.cs, convert.cs: Recursively check effective base interface
311 2010-06-01 Marek Safar <marek.safar@gmail.com>
313 * statement.cs: Handle nullable types and type parameters in using
314 statement, avoid boxing value types. Also fixes #571010
316 2010-06-01 Marek Safar <marek.safar@gmail.com>
318 * convert.cs, expression.cs: Emit unbox for underlying nullable
321 2010-05-29 Marek Safar <marek.safar@gmail.com>
323 A fix for bug #610126
324 * expression.cs: Don't use branch optimization for types bigger than
327 2010-05-28 Marek Safar <marek.safar@gmail.com>
329 A fix for bug #609088
330 * import.cs: Check private modifier correctly.
332 2010-05-28 Marek Safar <marek.safar@gmail.com>
334 A fix for bug #609049
335 * ecore.cs: Don't ignore override methods when looking for base
338 2010-05-27 Marek Safar <marek.safar@gmail.com>
340 A fix for bugs #608007, #572540, #566130, #476358
342 * generic.cs, linq.cs, expression.cs, statement.cs, cs-parser.jay:
343 More tricky refactoring of implicit linq blocks.
345 2010-05-25 Marek Safar <marek.safar@gmail.com>
347 * linq.cs, cs-parser.jay: Keep location for all linq clauses.
349 2010-05-25 Marek Safar <marek.safar@gmail.com>
351 * context.cs, expression.cs, cs-parser.jay: Don't store current
352 block in This expression (it's too early for linq blocks).
354 2010-05-21 Marek Safar <marek.safar@gmail.com>
356 * expression.cs: Use constrained prefix more broadly to avoid boxing.
358 2010-05-20 Marek Safar <marek.safar@gmail.com>
360 A fix for bug #591149
361 * nullable.cs: Don't double wrap same expression.
363 2010-05-20 Marek Safar <marek.safar@gmail.com>
365 A fix for bug #569827
366 * anonymous.cs: Any issued error in probing mode means no match.
368 2010-05-20 Marek Safar <marek.safar@gmail.com>
370 * expression.cs: Search for base indexer using the closest match
373 2010-05-20 Marek Safar <marek.safar@gmail.com>
375 A fix for bug #572071
376 * method.cs: Set override constraints using unexpanded interface
379 2010-05-20 Marek Safar <marek.safar@gmail.com>
381 A fix for bug #572071
382 * ecore.cs: Include secondary extension method lookup in probing
385 2010-05-19 Marek Safar <marek.safar@gmail.com>
387 A fix for bug #515801
388 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
391 2010-05-19 Marek Safar <marek.safar@gmail.com>
393 A fix for bug #515801
394 * pending.cs: Advance counter correctly.
396 2010-05-19 Marek Safar <marek.safar@gmail.com>
398 A fix for bug #480139
399 * method.cs, pending.cs: Indexer override uses base name.
401 2010-05-19 Marek Safar <marek.safar@gmail.com>
403 A fix for bug #424064
404 * generic.cs: Replace original with inflated type parameter on
407 2010-05-19 Marek Safar <marek.safar@gmail.com>
409 A fix for bug #359733
410 * parameter.cs: Extension attribute can be defined in each assembly.
412 2010-05-18 Marek Safar <marek.safar@gmail.com>
414 A fix for bug #446507
415 * method.cs: Only one method can implement an interface.
417 2010-05-18 Marek Safar <marek.safar@gmail.com>
419 A fix for bug #594905
420 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
421 Typed null can be used as a source for expression methods.
423 2010-05-18 Marek Safar <marek.safar@gmail.com>
425 A fix for bug #606551
426 * namespace.cs: Using directive imports only types and not nested
429 2010-05-17 Marek Safar <marek.safar@gmail.com>
431 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
432 delegate.cs: Member instance is resolved after member overload
433 definitely resolves static/instance property of member expression.
434 Fixes #545047, #358848, #456605, #460016, #603299
436 2010-05-12 Marek Safar <marek.safar@gmail.com>
438 A fix for bug #604981
439 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
440 details for nested anonymous methods stories.
442 2010-05-11 Marek Safar <marek.safar@gmail.com>
444 A fix for bug #604735
445 * namespace.cs: Don't report namespace collision.
447 2010-05-11 Marek Safar <marek.safar@gmail.com>
449 A fix for bug #604748
450 * class.cs, typespec.cs: Search full imported attribute hierarchy
453 2010-05-11 Marek Safar <marek.safar@gmail.com>
455 * namespace.cs: Ignore missing dependencies failure at
458 2010-05-11 Marek Safar <marek.safar@gmail.com>
460 A fix for bug #604640
461 * namespace.cs: Don't resolve using constraints too early.
463 2010-05-11 Marek Safar <marek.safar@gmail.com>
465 A fix for bug #604239
466 * generic.cs: Copy partial type constraints to partial container.
468 2010-05-10 Marek Safar <marek.safar@gmail.com>
470 A fix for bug #557210
471 * import.cs: Relax underlying enum field rules.
473 2010-05-10 Marek Safar <marek.safar@gmail.com>
475 A fix for bug #603476
476 * property.cs: Implement IParametersMember for indexer accessors.
478 2010-05-07 Marek Safar <marek.safar@gmail.com>
480 A fix for bug #601141
481 * class.cs: Update all partial modifiers.
483 2010-05-06 Marek Safar <marek.safar@gmail.com>
485 A fix for bug #601708
486 * method.cs, membercache.cs: Destructors cannot be hidden.
488 2010-05-06 Marek Safar <marek.safar@gmail.com>
490 A fix for bug #602551
491 * class.cs: Resursive reference of type definition is allowed.
493 2010-05-06 Marek Safar <marek.safar@gmail.com>
495 * anonymous.cs: Mutate cached storey instance types too.
497 2010-05-06 Marek Safar <marek.safar@gmail.com>
499 A fix for bug #602443
500 * convert.cs: Explicit enum conversion cannot involve user operators
502 2010-05-05 Miguel de Icaza <miguel@novell.com>
504 * class.cs (TypeContainer.DefineBaseTypes)
505 (TypeContainer.CheckRecursiveDefinition): check for the iface not
506 being null, as we could have failed resolution and crashed;
509 * cs-parser.jay: Productions to catch common mistakes when other
510 punctuation operators are used instead of comma. Fixes 571702
512 2010-05-05 Marek Safar <marek.safar@gmail.com>
514 * anonymous.cs: Mutate correct set of constraints.
516 2010-05-05 Marek Safar <marek.safar@gmail.com>
518 A fix for bug #602842
519 * expression.cs: Resolve all array bound arguments.
521 2010-05-05 Marek Safar <marek.safar@gmail.com>
523 * import.cs: Don't import private fields.
525 2010-04-30 Marek Safar <marek.safar@gmail.com>
527 Partially based on patch by <sami.lamti@gmail.com>
529 * eval.cs, ecore.cs: Fixed eval show methods.
531 2010-04-30 Marek Safar <marek.safar@gmail.com>
533 * generic.cs, delegate.cs: Implement output type inference of
534 methodgroup now when the specification was cleared at least little
537 2010-04-29 Marek Safar <marek.safar@gmail.com>
539 A fix for bug #575611
540 * class.cs: Fix recursive unmanaged recursice sruct check.
542 2010-04-29 Marek Safar <marek.safar@gmail.com>
544 A fix for bug #479776
545 * expression.cs: Implement typeof unbounded nested generic types.
547 2010-04-29 Marek Safar <marek.safar@gmail.com>
549 A fix for bug #474953
550 * class.cs: Fix valid recursive base type definition.
552 2010-04-29 Marek Safar <marek.safar@gmail.com>
554 A fix for bug #421737
555 * convert.cs, expression.cs: A boxing conversion exists from a
556 nullable-type to a reference type, if a boxing conversion exists
557 from the underlying non-nullable-value-type to the reference type.
559 2010-04-29 Marek Safar <marek.safar@gmail.com>
561 A fix for bug #376875
562 * import.cs: Import volatile modifier.
564 2010-04-29 Marek Safar <marek.safar@gmail.com>
566 A fix for bug #372412
567 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
570 2010-04-29 Marek Safar <marek.safar@gmail.com>
572 A fix for bug #568955
573 * statements.cs: Handle recursive scope initializers.
575 2010-04-28 Marek Safar <marek.safar@gmail.com>
577 A fix for bug #566511
578 * anonymous.cs: Always get inflated version of hoisted variable
579 on generic type definition.
581 2010-04-28 Marek Safar <marek.safar@gmail.com>
583 * import.cs, membercache.cs: Relax rules for valid properties.
585 2010-04-28 Marek Safar <marek.safar@gmail.com>
587 * import.cs: Intern arrays used in generic arguments.
589 2010-04-28 Marek Safar <marek.safar@gmail.com>
591 A fix for bug #600398
592 * convert.cs: Actually use effective base type for the comparison.
594 2010-04-28 Marek Safar <marek.safar@gmail.com>
596 A fix for bug #600326
597 * ecore.cs: Pass arity to base member lookup.
599 2010-04-28 Marek Safar <marek.safar@gmail.com>
601 A fix for bug #573385
602 * expression.cs: MemberAccess is of generic type based on right
605 2010-05-28 Marek Safar <marek.safar@gmail.com>
607 * cs-tokenizer.cs: Made tab size configurable.
609 2010-05-27 Marek Safar <marek.safar@gmail.com>
611 * attribute.cs: Ensure Obsolete members are defined before doing
614 2010-05-27 Marek Safar <marek.safar@gmail.com>
616 * visit.cs: Add DOM visitor skeleton.
620 2010-05-27 Marek Safar <marek.safar@gmail.com>
622 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
624 2010-05-27 Marek Safar <marek.safar@gmail.com>
626 * *.cs: Major rewrite of compiler internals to better work with
627 unmodified System.Reflection.Emit. Some of the key changes are
628 - TypeSpec replaces reflection specific System.Type.
629 - All Type(TypeSpec) operations are now done in compiler therefore
630 no dependency on SRE to inflate generic members and types or to
631 query unclosed types.
632 - MemberCache is now the only and full hierarchical topology.
633 - Generic constraints are implemented properly.
634 - And as a bonus compilation is on average 30% faster.
636 2010-04-15 Jb Evain <jbevain@novell.com>
638 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
640 2010-04-12 Marek Safar <marek.safar@gmail.com>
642 * expression.cs, attribute.cs, parameter.cs: More attribute type
645 2010-04-12 Marek Safar <marek.safar@gmail.com>
647 A fix for bug #593342
649 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
650 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
651 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
652 codegen.cs: Add custom attribute encoder to deal with unfinished
653 types and easier corlib bootstrap from its own types.
655 2010-03-26 Marek Safar <marek.safar@gmail.com>
657 * cs-parser.jay: Report invalid constraint types.
659 2010-03-16 Jb Evain <jbevain@novell.com>
661 * Makefile: rename the net_2_1 profile to moonlight.
663 2010-03-11 Marek Safar <marek.safar@gmail.com>
665 * statement.cs, cs-parser.jay: Use correct location for empty
668 2010-03-11 Marek Safar <marek.safar@gmail.com>
670 * cs-parser.jay: Disable Location from expression.
672 * generic.cs: Check constraints for overrides in the parser.
674 2010-03-09 Marek Safar <marek.safar@gmail.com>
676 * cs-parser.jay (GetLocation): Use an expression when available.
678 2010-03-04 Marek Safar <marek.safar@gmail.com>
680 A fix for bug #582579
681 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
683 2010-03-04 Marek Safar <marek.safar@gmail.com>
685 A patch by kornelpal@gmail.com
687 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
688 compiler generated classes sealed by default. Emit and close top
689 level compiler generated classes as well.
691 * support.cs: Use RuntimeHelpers.GetHashCode.
693 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
695 * Makefile: We need to use the internal bootstrapping gmcs for
696 net_2_1_bootstrap too now.
698 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
700 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
702 2010-03-02 Marek Safar <marek.safar@gmail.com>
704 * cs-tokenizer.cs: Missed few locations in previous fix.
706 2010-03-02 Marek Safar <marek.safar@gmail.com>
708 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
709 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
710 Report correct location for operator errors.
712 2010-03-02 Marek Safar <marek.safar@gmail.com>
714 * typemanager.cs (IsDynamicType): Don't check external types when
715 the attribute is not external.
717 2010-02-24 Marek Safar <marek.safar@gmail.com>
719 A fix for bug #582579
720 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
723 2010-02-24 Marek Safar <marek.safar@gmail.com>
725 A fix for bug #581804
726 * ecore.cs: Fixed type comparison.
728 2010-02-08 Miguel de Icaza <miguel@novell.com>
730 * namespace.cs (CompletionGetTypesStartingWith): Do not include
731 private types in the completion results.
733 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
736 2010-02-17 Marek Safar <marek.safar@gmail.com>
738 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
741 2010-02-14 Miguel de Icaza <miguel@novell.com>
743 * eval.cs: Do not do the report printer dance unless the user has
744 set the DescribeTypes feature.
746 2010-02-10 Marek Safar <marek.safar@gmail.com>
748 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
750 2010-02-08 Marek Safar <marek.safar@gmail.com>
752 A fix for bug #577029
753 * anonymous.cs: Fixed TypeBuilder* check.
755 2010-02-06 Miguel de Icaza <miguel@novell.com>
757 * eval.cs (CompileBlock): Also undo if there are problems during
758 semantic analysis, fixes various cases where invalid C# code would
759 be reported, but the internal changes would not be undone.
761 2010-02-03 Miguel de Icaza <miguel@novell.com>
763 * driver.cs: Change the --fatal flag to allow a number to be
764 passed, this ignores the first N fatal errors. Useful to debug
765 errors that do not happen on the first hit.
767 * cs-parser.jay (invocation_expression): accept both the
768 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
769 inside an invocation.
771 * driver.cs: Expose FatalErrors.
773 * eval.cs: Initialize the printer's Fatal property from the
774 Driver's FatalError flag, this allows csharp --fatal to work
777 Add support for calling Describe (typeof (TYPE)) if the expression
780 2010-02-02 Marek Safar <marek.safar@gmail.com>
782 A fix for bug #574991
783 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
786 2010-02-02 Marek Safar <marek.safar@gmail.com>
788 A fix for bug #575986
789 * expression.cs: Don't mutate typeof type definitions.
791 2010-01-28 Marek Safar <marek.safar@gmail.com>
793 * decl.cs: Use only one set of modifiers.
795 2010-01-26 Marek Safar <marek.safar@gmail.com>
797 A fix for bug #573329
798 * eval.cs: Don't disable error reporting completely on silent mode.
800 2010-01-25 Marek Safar <marek.safar@gmail.com>
802 A fix for bug #573312
803 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
804 pointer index of unknown size types greater than 2.
806 2010-01-15 Marek Safar <marek.safar@gmail.com>
808 * *.cs: Use only 1 member kind enum.
810 2010-01-15 Marek Safar <marek.safar@gmail.com>
812 * *.cs: Add event specification.
814 2010-01-14 Marek Safar <marek.safar@gmail.com>
816 * membercache.cs: Extracted from decl.cs.
818 * *.cs: Put more infrastructure in place.
820 2010-01-13 Marek Safar <marek.safar@gmail.com>
822 * *.cs: Add property specification, unused yet.
824 2010-01-13 Marek Safar <marek.safar@gmail.com>
826 * property.cs: Move all property based declarations into a new file.
828 2010-01-13 Marek Safar <marek.safar at gmail.com>
830 * expression.cs (Conditional): Resolve reduced expression.
832 2010-01-13 Marek Safar <marek.safar at gmail.com>
834 * *.cs: Introduced non-generic method specification.
836 2010-01-07 Marek Safar <marek.safar@gmail.com>
838 * method.cs: Move all method based declarations into a new file.
840 2010-01-07 Marek Safar <marek.safar@gmail.com>
842 * *.cs: Extract field specification.
844 2009-12-17 Marek Safar <marek.safar@gmail.com>
846 * field.cs: Extracted from class.cs
848 2009-12-15 Marek Safar <marek.safar@gmail.com>
850 * attribute.cs (GetFixedBuffer): Work on field definition only.
852 2009-12-15 Marek Safar <marek.safar@gmail.com>
854 * *.cs: Clean up NET_4_0 conditional where possible.
856 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
858 support.cs (DynamicType): Assembly property returns the assembly builder.
859 This is required due to how compiler context works in corlib.
861 2009-12-14 Marek Safar <marek.safar@gmail.com>
863 A fix for bug #564376
864 * assign.cs (LocalTemporary): Removed no longer needed special
867 2009-12-11 Marek Safar <marek.safar@gmail.com>
869 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
870 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
871 enum for easier debugging.
873 2009-12-10 Marek Safar <marek.safar@gmail.com>
875 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
878 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
881 2009-12-10 Marek Safar <marek.safar@gmail.com>
883 * cs-parser.jay, statement.cs: Handle parser error in code
886 2009-12-10 Marek Safar <marek.safar@gmail.com>
888 * ecore.cs: Ignore base imported methods when they are already
891 * eval.cs: Handle non-existent keys.
893 * report.cs, driver.cs: Make fatal work with console printer only.
895 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
897 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
899 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
901 * typemanager.cs: Add MakeGenericMethod that checks if the method
902 is really the generic method definition.
904 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
905 to inflate generic methods.
907 2009-12-08 Marek Safar <marek.safar@gmail.com>
909 A fix for bug #561149
910 * anonymous.cs: Use actual type parameters when checking for generic
913 2009-12-08 Marek Safar <marek.safar@gmail.com>
915 A fix for bug #561369
916 * expression.cs (DoNumericPromotion): Fixed typo.
918 2009-12-08 Marek Safar <marek.safar@gmail.com>
920 *.cs: Moving to generics world.
922 cs-parser.jay: Removed current_array_type.
924 2009-12-07 Marek Safar <marek.safar@gmail.com>
926 *.cs: Moving to generics world.
928 2009-12-04 Marek Safar <marek.safar@gmail.com>
930 *.cs: Moving to generics world (day 2).
932 2009-12-03 Marek Safar <marek.safar@gmail.com>
934 *.cs: Moving to generics world.
936 2009-12-02 Marek Safar <marek.safar@gmail.com>
938 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
939 Encode dynamic type attribute for elements where attributes cannot
942 2009-12-01 Marek Safar <marek.safar@gmail.com>
944 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
947 2009-12-01 Marek Safar <marek.safar@gmail.com>
949 A fix for bug #360455
950 * class.cs: Never report a unused warning for generic events to
951 workaround wrong expression type.
953 2009-11-30 Marek Safar <marek.safar@gmail.com>
955 A fix for bug #558305
956 * decl.cs, class.cs: Check partial method definitions using correct
959 2009-11-30 Marek Safar <marek.safar@gmail.com>
961 * argument.cs: Don't cache rarely used dynamic flag.
963 2009-11-27 Marek Safar <marek.safar@gmail.com>
965 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
967 2009-11-27 Marek Safar <marek.safar@gmail.com>
969 * ecore.cs (SimpleName): Removed no longer needed in_transit as
970 Resolve is now non-reentrant (saves ~0.6MB for corlib).
972 2009-11-26 Marek Safar <marek.safar@gmail.com>
974 A fix for bug #545081
975 * decl.cs: Check private nested types of nested types recursively.
977 2009-11-26 Marek Safar <marek.safar@gmail.com>
979 A fix for bug #558305
980 * location.cs: Ignore self referencing #line directive
982 2009-11-26 Marek Safar <marek.safar@gmail.com>
984 A fix for bug #558292
985 * class.cs: Allow single unsafe fixed buffer fields.
987 2009-11-26 Marek Safar <marek.safar@gmail.com>
989 * expression: Optimize few more zero-based operations.
991 2009-11-26 Marek Safar <marek.safar@gmail.com>
993 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
994 avoids boxing of literal values.
996 2009-11-26 Marek Safar <marek.safar@gmail.com>
998 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
999 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
1000 codegen.cs: LocatedToken redesing to avoid excessive allocation and
1001 boxing (saves ~7MB for corlib). Also fixes presise token location.
1003 2009-11-25 Marek Safar <marek.safar@gmail.com>
1005 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
1006 common data buckers.
1008 2009-11-24 Marek Safar <marek.safar@gmail.com>
1010 * expression.cs: Lower static array initializer barrier.
1012 * support.cs, driver.cs: Share reader buffer.
1014 2009-11-23 Marek Safar <marek.safar@gmail.com>
1016 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
1018 2009-11-23 Marek Safar <marek.safar@gmail.com>
1020 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
1021 cleanup some obsolete code.
1023 2009-11-20 Marek Safar <marek.safar@gmail.com>
1025 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
1028 2009-11-20 Marek Safar <marek.safar@gmail.com>
1030 * *.cs: Resolved expressions are never resolved again, this helps to
1031 uncover some not easy to find bugs and improve the performance.
1033 2009-11-19 Marek Safar <marek.safar@gmail.com>
1035 * *.cs: Made constant expressions fully compatible with any other
1038 2009-11-19 Marek Safar <marek.safar@gmail.com>
1040 * *.cs: DoResolve is a worker method and has to be protected.
1042 2009-11-18 Marek Safar <marek.safar@gmail.com>
1044 * *.cs: More context specific handling.
1046 2009-11-17 Marek Safar <marek.safar@gmail.com>
1048 * *.cs: More context specific handling.
1050 2009-11-16 Marek Safar <marek.safar@gmail.com>
1052 * dynamic.cs, class.cs: Removed few fixed user types conversions.
1054 * symbolwriter.cs: Uses public ILOffset.
1056 2009-11-13 Marek Safar <marek.safar@gmail.com>
1058 A fix for bug #553650
1059 * generic.cs: Another missing TypeToCoreType, still too many to fix.
1061 2009-11-13 Marek Safar <marek.safar@gmail.com>
1063 A fix for bug #555170
1065 * class.cs, delegate.cs, enum.cs: Constants have to be available
1066 for parameters resolve.
1068 2009-11-12 Marek Safar <marek.safar@gmail.com>
1070 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
1073 2009-11-12 Marek Safar <marek.safar@gmail.com>
1075 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
1076 with a statically known candidate set.
1078 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
1080 * generic.cs: Made type inflation for generic constraint checks
1081 recursive. This fixes BGO #553655.
1083 2009-11-11 Marek Safar <marek.safar@gmail.com>
1085 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
1088 2009-11-10 Marek Safar <marek.safar@gmail.com>
1090 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
1091 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
1092 attribute.cs: Add some dynamic error checking.
1094 2009-11-07 Marek Safar <marek.safar@gmail.com>
1096 A fix for bug #553465
1098 * expression.cs: Fixed mixed version of expression tree anonymous
1101 2009-11-06 Marek Safar <marek.safar@gmail.com>
1103 A fix for bug #553031
1105 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
1106 expression tree version of anonymous type with members declaration.
1108 2009-11-05 Marek Safar <marek.safar@gmail.com>
1110 * parameter.cs: Handle nullable parameter default expression.
1112 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
1113 class.cs, attribute.cs: Check for wrong dynamic arguments.
1115 2009-11-05 Marek Safar <marek.safar@gmail.com>
1117 * statement.cs: Dynamic statements.
1119 2009-11-04 Marek Safar <marek.safar@gmail.com>
1121 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
1122 Compound assignments over dynamic type.
1124 2009-11-03 Marek Safar <marek.safar@gmail.com>
1126 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
1127 constructor arguments.
1129 2009-10-30 Marek Safar <marek.safar@gmail.com>
1131 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
1132 codegen.cs: Unary mutator on dynamic member access expression.
1134 2009-10-29 Marek Safar <marek.safar@gmail.com>
1136 A fix for bug #550580
1137 * convert.cs: Don't eliminate explicit precission casts.
1139 2009-10-28 Marek Safar <marek.safar@gmail.com>
1141 A fix for bug #550404
1143 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
1144 expression.cs, statement.cs, ecore.cs: Quote any nested expression
1147 2009-10-27 Marek Safar <marek.safar@gmail.com>
1149 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
1152 * class.cs: Allow nullable binary user operators.
1154 2009-10-26 Marek Safar <marek.safar@gmail.com>
1156 * expression.cs: Move binary expression optimization at the end of
1159 2009-10-23 Marek Safar <marek.safar@gmail.com>
1161 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
1162 Separate NullConstant from NullLiteral.
1164 2009-10-23 Marek Safar <marek.safar@gmail.com>
1166 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
1167 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
1168 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
1169 ModuleContainer. Add common unclosed member check routine.
1171 2009-10-22 Marek Safar <marek.safar@gmail.com>
1173 * argument.cs: Use literal flag for real literals only.
1175 * dynamic.cs: Use correct return type for custom delegates.
1177 2009-10-22 Marek Safar <marek.safar@gmail.com>
1179 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
1182 2009-10-22 Marek Safar <marek.safar@gmail.com>
1184 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
1186 2009-10-21 Marek Safar <marek.safar@gmail.com>
1188 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
1191 2009-10-21 Marek Safar <marek.safar@gmail.com>
1193 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
1196 2009-10-20 Marek Safar <marek.safar@gmail.com>
1198 * argument.cs, dynamic.cs, expression.cs: Latest API update.
1200 2009-10-19 Marek Safar <marek.safar@gmail.com>
1202 * typemanager.cs, expression.cs: Dynamic array initializer.
1204 2009-10-16 Marek Safar <marek.safar@gmail.com>
1206 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
1209 2009-10-16 Marek Safar <marek.safar@gmail.com>
1211 A fix for bug #493523, #507067
1212 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
1213 standard nullable conversion using underlying standard conversion
1214 and not full conversion.
1216 2009-10-15 Marek Safar <marek.safar@gmail.com>
1218 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
1219 type in VerifyArgumentsCompat.
1221 2009-10-15 Marek Safar <marek.safar@gmail.com>
1223 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1224 Reject variable used with type arguments.
1226 2009-10-14 Marek Safar <marek.safar@gmail.com>
1228 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
1229 Implement dynamic expressions assignment.
1231 2009-10-14 Marek Safar <marek.safar@gmail.com>
1233 * expression.cs: Build underlying expression when resolving unary
1236 2009-10-14 Marek Safar <marek.safar@gmail.com>
1238 * expression.cs: Emit enum array initializer using binary blob.
1240 2009-10-08 Marek Safar <marek.safar@gmail.com>
1242 * typemanager.cs, constant.cs: Optimize decimal constants which fit
1245 2009-10-07 Marek Safar <marek.safar@gmail.com>
1247 * typemanager.cs: Reset object_type.
1249 * assign: Made SimpleAssign public.
1251 2009-10-06 Marek Safar <marek.safar@gmail.com>
1253 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
1254 invocation assembly to IsThisOrFriendAssembly.
1256 2009-10-05 Marek Safar <marek.safar@gmail.com>
1258 * expression.cs: Equality comparison of generic parameter with
1261 2009-10-05 Marek Safar <marek.safar@gmail.com>
1263 A fix for bug #543570
1264 * generic.cs: Import predefined constraints correctly.
1266 2009-10-02 Marek Safar <marek.safar@gmail.com>
1268 * ecore.cs: Don't crash on overloads with optional paremeters where
1269 arguments count overflows.
1271 * parameter.cs: Import optional parameter constants using optional
1274 2009-10-01 Marek Safar <marek.safar@gmail.com>
1276 * Makefile: Default is gmcs compiler.
1278 2009-10-01 Marek Safar <marek.safar@gmail.com>
1280 * cs-parser.jay: Fixed few NRE.
1282 2009-10-01 Marek Safar <marek.safar@gmail.com>
1284 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
1286 2009-09-30 Marek Safar <marek.safar@gmail.com>
1288 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
1289 ShimExpression, ImplicitCast.
1291 2009-09-30 Marek Safar <marek.safar@gmail.com>
1293 A fix for bug #542959
1294 * delegate.cs: Emit correct delegate instance variable when there
1295 are static and non-static overloads.
1297 2009-09-29 Marek Safar <marek.safar@gmail.com>
1299 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
1300 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
1302 2009-09-28 Marek Safar <marek.safar@gmail.com>
1304 A fix for bug #542487
1305 * ecore.cs: Resolve extension methods hidden by properties.
1307 2009-09-25 Marek Safar <marek.safar@gmail.com>
1309 * expression.cs, ecore.cs: More dynamic binary expressions.
1311 2009-09-22 Marek Safar <marek.safar@gmail.com>
1313 * nullable.cs, expression.cs: Fixed null lifted conversion for
1314 bitwise enum operations.
1316 2009-09-22 Marek Safar <marek.safar@gmail.com>
1318 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
1319 values in checked context.
1321 2009-09-22 Marek Safar <marek.safar@gmail.com>
1323 * expression.cs, ecore.cs: Fixed array index constant conversion.
1325 2009-09-20 Miguel de Icaza <miguel@novell.com>
1327 * expression.cs: Do not crash when MemberLookup returns something
1328 that is not a MemberExpr here. Report error 582 instead.
1332 2009-09-18 Marek Safar <marek.safar@gmail.com>
1334 * decl.cs, class.cs: Check protected property accessors.
1336 2009-09-18 Marek Safar <marek.safar@gmail.com>
1338 * dynamic.cs, assign.cs: Dynamic compound assignment.
1340 2009-09-17 Marek Safar <marek.safar@gmail.com>
1342 * expression.cs: Fixed compound assignment explicit conversion.
1344 2009-09-17 Marek Safar <marek.safar@gmail.com>
1346 * expression.cs, ecore.cs: Cannot infer variables from method group.
1348 2009-09-16 Marek Safar <marek.safar@gmail.com>
1350 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
1351 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
1352 codegen.cs: Dynamic binary operations scaffolding.
1354 2009-09-15 Marek Safar <marek.safar@gmail.com>
1356 * expression.cs: Fixes nullable promotion for enum type variables.
1358 2009-09-11 Marek Safar <marek.safar@gmail.com>
1360 * driver.cs, dynamic.cs: Reset more static variables.
1362 2009-09-11 Marek Safar <marek.safar@gmail.com>
1364 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1365 driver.cs: Introduced Expression::MakeExpression.
1367 2009-09-11 Marek Safar <marek.safar@gmail.com>
1369 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1371 2009-09-09 Marek Safar <marek.safar@gmail.com>
1373 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1376 2009-09-09 Marek Safar <marek.safar@gmail.com>
1378 A fix for bug #518707
1379 * expression.cs (Is): Optimize only generic parameter type
1380 expression probing value type generic parameter.
1382 2009-09-09 Marek Safar <marek.safar@gmail.com>
1384 A fix for bug #532571
1385 * ecore.cs: Check for simple name type arguments used with
1388 2009-09-08 Marek Safar <marek.safar@gmail.com>
1390 A fix for bug #497421
1391 * generic.cs (CheckConstraint): Don't use buildin types to check for
1392 parameterless constructor.
1394 2009-09-08 Marek Safar <marek.safar@gmail.com>
1396 A fix for bug #537402
1397 * generic.cs (CheckConstraint): Correctly inflate generic type
1398 arguments when checking generic method.
1400 2009-09-08 Marek Safar <marek.safar@gmail.com>
1402 A fix for bug #536463
1403 * decl.cs (AddToContainer): Don't report collision between explicit
1404 and parameterless non-explicit members.
1406 2009-09-08 Marek Safar <marek.safar@gmail.com>
1408 * eval.cs: Reset more static stuff.
1410 2009-09-07 Marek Safar <marek.safar@gmail.com>
1412 A fix for bug #324625
1413 * expression.cs, ecore.cs: Create nested generic type expression
1414 using declaring and not current type.
1416 2009-09-07 Marek Safar <marek.safar@gmail.com>
1418 * *.cs: Changed Report class to accept various output printers and
1419 be an instance class. An expression resolver can now use different
1420 message reporter for each call and Report.Error can safely throw
1421 an exception. Part of ongoing work to turn mcs into proper library.
1423 2009-09-04 Marek Safar <marek.safar@gmail.com>
1425 * statement.cs, ecore.cs: Removed error reporting from emit code.
1427 2009-09-04 Marek Safar <marek.safar@gmail.com>
1429 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1431 2009-09-03 Marek Safar <marek.safar@gmail.com>
1433 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1434 parser checks out of constructors.
1436 2009-09-02 Marek Safar <marek.safar@gmail.com>
1438 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1440 2009-09-02 Marek Safar <marek.safar@gmail.com>
1442 A fix for bug #535448
1443 * anonymous.cs, class.cs: Copy return label between all contexts.
1445 2009-09-02 Marek Safar <marek.safar@gmail.com>
1447 A fix for bug #535395
1448 * namespace.cs: Resolve context can be null.
1450 2009-08-25 Marek Safar <marek.safar@gmail.com>
1452 A fix for bug #533912
1453 * generic.cs: Use correct context for constraints resolving.
1455 2009-08-25 Marek Safar <marek.safar@gmail.com>
1457 A fix for bug #532630
1458 * driver.cs: Trim conditional symbols.
1460 2009-08-25 Marek Safar <marek.safar@gmail.com>
1462 * context.cs: New file.
1464 * *.exe.sources, *.csproj: Updated.
1466 2009-08-25 Marek Safar <marek.safar@gmail.com>
1468 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1469 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1470 IMembercontext, some small cleanups.
1472 2009-08-24 Marek Safar <marek.safar@gmail.com>
1474 * *.cs: Split ResolveContext and EmitContext.
1476 2009-08-24 Marek Safar <marek.safar@gmail.com>
1478 * *.cs: Only ResolveContext implements IMemberContext.
1480 2009-08-21 Marek Safar <marek.safar@gmail.com>
1482 * *.cs: Renamed IResolveContext to IMemberContext.
1484 2009-08-21 Marek Safar <marek.safar@gmail.com>
1486 * *.cs: Detached ResolveContext from EmitContext.
1488 2009-08-21 Marek Safar <marek.safar@gmail.com>
1490 * codegen.cs: Moved flow-analysis to BlockContext.
1492 2009-08-21 Marek Safar <marek.safar@gmail.com>
1494 * *.cs: Detached BlockContext from EmitContext.
1496 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1498 * statement.cs: avoid nullref when the return value of GetEnumerator()
1499 does not contain any MoveNext() method.
1501 2009-08-19 Marek Safar <marek.safar@gmail.com>
1503 * *.cs: Removed IResolveContext::GenericDeclContainer.
1505 2009-08-19 Marek Safar <marek.safar@gmail.com>
1507 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1509 2009-08-19 Marek Safar <marek.safar@gmail.com>
1511 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1512 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1514 2009-08-18 Marek Safar <marek.safar@gmail.com>
1516 * *.cs: Removed boolean fields from EmitContext.
1518 2009-08-18 Marek Safar <marek.safar@gmail.com>
1520 * *.cs: Add IResolveContext::IsStatic.
1522 2009-08-18 Marek Safar <marek.safar@gmail.com>
1524 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1526 2009-08-17 Marek Safar <marek.safar@gmail.com>
1528 * *.cs: Removed DeclContainer from EmitContext.
1530 2009-08-17 Marek Safar <marek.safar@gmail.com>
1532 * *.cs: Add IResolveContext::CurrentTypeParameters.
1534 2009-08-14 Marek Safar <marek.safar@gmail.com>
1536 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1538 2009-08-14 Marek Safar <marek.safar@gmail.com>
1540 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1541 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1543 2009-08-13 Marek Safar <marek.safar@gmail.com>
1545 * decl.cs: Look in PartialContainer for parent type parameters.
1547 2009-08-13 Marek Safar <marek.safar@gmail.com>
1549 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1550 codegen.cs: Add IResolveContext::LookupTypeParameter.
1552 2009-08-13 Marek Safar <marek.safar@gmail.com>
1554 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1555 Moved resolved logic from Emit to Resolve.
1557 2009-08-13 Marek Safar <marek.safar@gmail.com>
1559 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1560 codegen.cs: Reworked atttributes handling of ResolveContext.
1562 2009-08-12 Marek Safar <marek.safar@gmail.com>
1564 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1565 LookupNamespaceOrType to ResolveContext.
1567 2009-08-12 Marek Safar <marek.safar@gmail.com>
1569 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1570 class.cs: Removed unused parameters and methods.
1572 2009-08-11 Marek Safar <marek.safar@gmail.com>
1574 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1575 codegen.cs: Finding the best common type of a set of expressions for
1578 2009-08-07 Marek Safar <marek.safar@gmail.com>
1580 * dynamic.cs, expression.cs: More dynamic conversions.
1582 2009-08-06 Miguel de Icaza <miguel@novell.com>
1584 * generic.cs: This loop was incorrect, it was increment ii, but
1585 checking for `i'. This was a change introduced to fix #327497,
1588 * class.cs: Catch another case for cs0533 error, fixes #324782.
1590 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1592 * typemanager.cs (GetGenericArguments): SRE returns null for
1593 generic methods on type builder instances if they are not generic
1594 themselves. For example, for Foo<int>::Bar() it returns null, but
1595 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1597 2009-08-05 Marek Safar <marek.safar@gmail.com>
1599 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1600 delegate.cs: Work on dynamic binding.
1602 2009-08-04 Marek Safar <marek.safar@gmail.com>
1604 A second fix for bug #525342
1605 * class.cs: Attach partial method attributes to method
1608 2009-08-03 Marek Safar <marek.safar@gmail.com>
1610 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1613 * rootcontext.cs: Default to langversion v4.
1615 2009-08-03 Marek Safar <marek.safar@gmail.com>
1617 * pending.cs: Check return type before member info is set.
1619 2009-08-03 Marek Safar <marek.safar@gmail.com>
1621 * anonymous.cs: Fully initialize generic hoisted field expression.
1623 2009-08-02 Miguel de Icaza <miguel@novell.com>
1625 * cs-parser.jay: Flag variables declared on the interactive shell
1626 as used to prevent the 168 warning about local variable not being
1629 2009-07-31 Marek Safar <marek.safar@gmail.com>
1631 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1632 attribute.cs: Emit dynamic export attribute.
1634 2009-07-30 Marek Safar <marek.safar@gmail.com>
1636 * expression.cs: More verifier work.
1638 2009-07-29 Marek Safar <marek.safar@gmail.com>
1640 * nullable.cs: Fixed SRE crash during corlib compilation.
1642 2009-07-29 Marek Safar <marek.safar@gmail.com>
1644 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1645 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1646 More TypeManager.TypeToCoreType needed.
1648 2009-07-29 Marek Safar <marek.safar@gmail.com>
1650 * anonymous.cs: Update after recent SRE fixes.
1652 2009-07-28 Marek Safar <marek.safar@gmail.com>
1654 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1655 version of GetFieldHandle for fields of generic types.
1657 2009-07-27 Marek Safar <marek.safar@gmail.com>
1659 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1660 ecore.cs: Add TypeManager.IsDynamicType,
1661 PredefinedAttributes.Dynamic.
1663 2009-07-27 Marek Safar <marek.safar@gmail.com>
1665 A fix for bug #415375
1666 * expression.cs: Fixed object and reference type parameter
1669 2009-07-27 Marek Safar <marek.safar@gmail.com>
1671 A fix for bug #525342
1672 * class.cs: Attach partial method attributes to method
1675 2009-07-24 Marek Safar <marek.safar@gmail.com>
1677 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1680 2009-07-24 Marek Safar <marek.safar@gmail.com>
1682 * anonymous.cs (MutateField): Add imported types handling.
1684 2009-07-23 Marek Safar <marek.safar@gmail.com>
1686 * expression.cs, delegate.cs: Moved arguments resolve into their
1687 counterparts expressions. Removed argument resolve from
1688 CollectionElementInitializer.
1690 2009-07-23 Marek Safar <marek.safar@gmail.com>
1692 A fix for bug #523683
1693 * convert.cs, delegate.cs: Use common overload mechanism for method
1694 group conversion check.
1696 2009-07-22 Marek Safar <marek.safar@gmail.com>
1698 A fix for bug #523899
1699 * generics.cs: Exact type inference with other bound types.
1701 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1703 Don't complain when the same type is implemented by the output
1704 assembly as well as multiple referenced assemblies
1705 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1706 'must_be_unique' flag.
1707 (GlobalRootNamespace): Update to changes.
1708 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1709 already have a type in hand.
1711 2009-07-22 Marek Safar <marek.safar@gmail.com>
1713 * expression.cs: More verifier instrumentation.
1715 * statement.cs: Do proper throw expression conversion.
1717 2009-07-22 Marek Safar <marek.safar@gmail.com>
1719 A fix for bug #522789
1720 * expression.cs: Mutate invocation return type.
1722 2009-07-16 Marek Safar <marek.safar@gmail.com>
1724 * anonymous.cs: Split assignable and readonly generated variable
1727 2009-07-16 Marek Safar <marek.safar@gmail.com>
1729 A fix for bug #521671
1730 * statement.cs: Fixed crash when checking missing type.
1732 2009-07-16 Marek Safar <marek.safar@gmail.com>
1734 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1735 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1736 class.cs, driver.cs: Work on dynamic binding.
1738 * dynamic.cs: New file.
1740 * *.sources, *.proj: Updated.
1742 2009-07-15 Marek Safar <marek.safar@gmail.com>
1744 * expression.cs (Conditional): Avoid double Resolve.
1746 2009-07-13 Marcus Griep <marcus@griep.us>
1748 * ecore.cs: Fix obscure bug with resolving members of interfaces
1749 that hide parent interface members. Fixes bug #444388 and corrects
1752 2009-07-13 Marek Safar <marek.safar@gmail.com>
1754 * expression.cs (LocalVariableReference): Bounce resolve.
1756 2009-07-10 Marek Safar <marek.safar@gmail.com>
1758 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1759 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1762 * support.cs: New dynamic type wrapper.
1764 2009-07-08 Marek Safar <marek.safar@gmail.com>
1766 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1767 typed local variable.
1769 2009-07-06 Marek Safar <marek.safar@gmail.com>
1771 A fix for bug #519005
1772 * anonymous.cs: Use null_type as no return type placeholder.
1774 2009-07-02 Marek Safar <marek.safar@gmail.com>
1776 * generic.cs: Handle type inference of identical type parameters
1777 with different bounds.
1779 2009-07-01 Marek Safar <marek.safar@gmail.com>
1781 * expression.cs, class.cs: Events variance.
1783 * cs-parser.jay: Interface events error messages.
1785 2009-07-01 Marek Safar <marek.safar@gmail.com>
1787 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1789 2009-06-29 Marek Safar <marek.safar@gmail.com>
1791 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1792 parameter expression can be value-type New.
1794 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1796 2009-06-26 Marek Safar <marek.safar@gmail.com>
1798 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1799 Implemented C# 4.0 named arguments.
1801 2009-06-24 Marek Safar <marek.safar@gmail.com>
1803 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1804 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1805 parameter modifier. Also fixes bug #515497.
1807 2009-06-24 Marek Safar <marek.safar@gmail.com>
1809 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1810 arguments expression to be implemented.
1812 *.sources: Add argument.cs
1814 2009-06-23 Marek Safar <marek.safar@gmail.com>
1816 * parameter.cs: Moved GetParameterIndexByName to base class.
1818 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1819 unused AType. Use argument's version of GetExpressionTree.
1821 2009-06-22 Marek Safar <marek.safar@gmail.com>
1823 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1826 2009-06-17 Marek Safar <marek.safar@gmail.com>
1828 A fix for bug #514096
1829 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1831 2009-06-17 Marek Safar <marek.safar@gmail.com>
1833 * expression.cs: The first multi-dimensional array nested array
1834 initializers was not checked.
1836 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1838 2009-06-17 Marek Safar <marek.safar@gmail.com>
1840 A fix for bug #513400
1841 * nullable.cs (EmitEquality): Operands emit could be simplified for
1842 built-in types when we now emit user operators differently.
1844 2009-06-16 Marek Safar <marek.safar@gmail.com>
1846 * ecore.cs: Report inaccessible delegate methods correctly.
1848 2009-06-16 Marek Safar <marek.safar@gmail.com>
1850 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1851 cs-parser.jay: Implemented C# 4.0 optional parameters.
1853 2009-06-16 Marek Safar <marek.safar@gmail.com>
1855 * driver.cs: Removed broken DefineManifestResource.
1857 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1859 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1860 Use $(BOOTSTRAP_PROFILE) instead.
1862 2009-06-12 Jb Evain <jbevain@novell.com>
1864 * rootcontext.cs: add a Platform field.
1865 * driver.cs: handle /platform.
1866 * codegen.cs: pass the proper flags according to
1867 the platform when saving the assembly.
1869 2009-06-11 Marek Safar <marek.safar@gmail.com>
1871 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1872 Add optional parameters grammar.
1874 2009-06-10 Marek Safar <marek.safar@gmail.com>
1876 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1877 driver.cs: Split lang version and metadata version.
1879 2009-06-10 Marek Safar <marek.safar@gmail.com>
1881 * decl.cs: Better overload ctor collision error message.
1883 2009-06-05 Jb Evain <jbevain@novell.com>
1885 * driver.cs (EmbededResource): avoid using an internal method
1886 in gmcs to embed manifest resources.
1888 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1890 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1891 the compiler from older mono versions (like moon's bots)
1893 2009-06-04 Marek Safar <marek.safar@gmail.com>
1895 * namespace.cs (LookupTypeReflection): Ignore collisions between
1898 2009-06-04 Marek Safar <marek.safar@gmail.com>
1900 * codegen.cs: Enabled generic type forwarders.
1902 2009-06-04 Marek Safar <marek.safar@gmail.com>
1904 * dmcs.*: Add another version of SRE compiler.
1906 2009-06-03 Marek Safar <marek.safar@gmail.com>
1908 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1909 generic-mcs.cs: Fixed variant type conversions.
1911 2009-06-02 Marek Safar <marek.safar@gmail.com>
1913 A fix for bug #507863
1914 * codegen.cs: Fixes a crash on invalid string value attribute.
1916 2009-06-01 Marek Safar <marek.safar@gmail.com>
1918 A fix for bug #508334
1919 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1920 cs-parser.jay: Fully import __arglist modifier.
1922 2009-05-29 Marek Safar <marek.safar@gmail.com>
1924 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1925 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1926 actually work with closed generic types.
1928 2009-05-27 Alan McGovern <amcgovern@novell.com>
1930 * class.cs, decl.cs, delegate.cs, parameter.cs:
1931 Fix the build by replacing the use of 'var' with the actual type.
1933 2009-05-27 Marek Safar <marek.safar@gmail.com>
1935 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1936 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1939 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1942 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1943 Marek Safar <marek.safar@gmail.com>
1945 A fix for bug #377509
1946 * parameter.cs: Use predefined and not empty name for implicit
1949 2009-05-21 Marek Safar <marek.safar@gmail.com>
1951 * class.cs: Don't report wrong warnings for event fields.
1953 2009-05-21 Marek Safar <marek.safar@gmail.com>
1955 A fix for bug #504667
1956 * class.cs: Check for static class using parent container instead of
1959 2009-05-08 Marek Safar <marek.safar@gmail.com>
1961 A fix for bug #496922
1962 * expression.cs: Always use temporary variable when using object
1965 2009-04-28 Marek Safar <marek.safar@gmail.com>
1967 A fix for bug #495112
1968 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1971 2009-04-27 Miguel de Icaza <miguel@novell.com>
1973 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1975 2009-04-24 Miguel de Icaza <miguel@novell.com>
1977 * complete.cs: No idea how gonzalo got a null in the list, but
1980 2009-04-24 Miguel de Icaza <miguel@novell.com>
1982 * complete.cs (CompletionElementInitializer): New completion class
1983 to support completing inside a C# 3 element initializer, so this
1984 allows completion for Silverlight situations where it is very
1987 new TextBlock () { Fo<TAB>
1989 (CompletionSimpleName): Expose the prefix that was
1990 passed to the simple name.
1992 * cs-parser.jay (object_or_collection_initializer): Add support
1993 for element_initializers.
1995 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1996 special case completion expressions as this method aggressively
1997 collects data before it operates, and errors were being thrown
1998 earlier than we were able to complete.
2000 2009-04-23 Miguel de Icaza <miguel@novell.com>
2002 * eval.cs: Make getcompletions silent and enable debugging output
2003 if the -v option is passed.
2005 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
2006 Consider looking up the namespace that matches the prefix being
2009 This is part of the support for allowing completions like:
2010 `System.Co<TAB>' to complete to System.Console.
2012 * complete.cs (CompletionSimpleName.AppendResults): Make this
2015 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
2017 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
2018 COMPLETE_COMPLETION as internal.
2020 2009-04-17 Miguel de Icaza <miguel@novell.com>
2022 * complete.cs: Include namespace resolution in simple names as
2023 well as global types and types in the using scope in the
2026 * namespace.cs: Supporting infrastrcture to provide completions
2027 based on the current using scope.
2029 * eval.cs: Introduce an entry point that allows for initialization
2030 to return a list of the files passed on the command line.
2032 2009-04-14 Marek Safar <marek.safar@gmail.com>
2034 A fix for bug #494243
2035 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
2037 2009-04-13 Marek Safar <marek.safar@gmail.com>
2039 A fix for bug #493887
2040 * statement.cs: Don't skip string multi-section with default or
2041 null label when populating string hashtable.
2043 2009-04-06 Marek Safar <marek.safar@gmail.com>
2045 A fix for bug #492329
2046 * expression.cs (New): Load variable when assigning type parameter
2049 2009-04-06 Marek Safar <marek.safar@gmail.com>
2051 A fix for bug #488960
2052 * decl.cs: Compare MVAR types using non-null values.
2054 2009-03-27 Marek Safar <marek.safar@gmail.com>
2056 * typemanager.cs, expression.cs: Removed unused nullable checks.
2058 2009-03-27 Marek Safar <marek.safar@gmail.com>
2060 * *.cs: Removed some gmcs conditionals.
2062 2009-03-26 Marek Safar <marek.safar@gmail.com>
2064 * generic.cs, support.cs: Moved generics stuff out of support.cs
2066 2009-03-24 Marek Safar <marek.safar@gmail.com>
2068 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
2071 2009-03-23 Marek Safar <marek.safar@gmail.com>
2073 * attribute.cs: Consider all members for error reporting when
2074 checking named arguments.
2076 2009-03-23 Marek Safar <marek.safar@gmail.com>
2078 A fix for bug #487625
2079 * namespace.cs: Use a warning for all predefined type conflicts.
2081 2009-03-23 Marek Safar <marek.safar@gmail.com>
2083 A fix for bug #485706
2084 * statement.cs: Explicitly type catch type argument to pass verifier
2087 2009-03-22 Miguel de Icaza <miguel@novell.com>
2089 Initial support to provide code completion facilities to consumers
2090 of the evaluator API.
2092 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
2093 support the completion engine. When we reach the end of the
2094 input stream instead of returning EOF, when this flag is true the
2095 tokenizer instead produces:
2097 One GENERATE_COMPLETION token: this token then must be
2098 handled in the grammar at every point where the user
2099 would likely request a completion.
2101 As many COMPLETE_COMPLETION tokens as necessary. These
2102 tokens are generated to assist the parser in unwinding and
2103 producing a valid parse tree.
2105 The parser rules do not have to be perfect, the parser needs to be
2106 augmented with judicious use of GENERATE_COMPLETION tokens to
2107 improve the areas where we can provide completion and the parser
2108 needs to add support for COMPLETE_COMPLETION tokens in productions
2111 It is common to not have enough support for COMPLETE_COMPLETION
2112 under certain rules and that even if we generated the
2113 GENERATE_COMPLETION token that the resulting tree will be invalid
2114 due to the missing rules that support COMPLETE_COMPLETION.
2116 The final EOF token is produced by having the parser notify the
2117 tokenizer when it reaches the root production that the next token
2120 * support.cs (CompletionResult): New Exception. This exception
2121 is thrown to return the completion results when one of the special
2122 completion expressions is reached.
2124 This exception is thrown by the completing ExpressionStatements
2125 classes that live in complete.cs
2127 * complete.cs (CompletingExpression): a new base class for
2128 completing expressions. This derives from the
2129 ExpressionStatement class and not from Expression as it allows
2130 completion to happen not only where expressions are expected in
2131 the grammar, but also where statements are expected.
2133 (CompletionSimpleName): A new class used to provide completions
2134 for SimpleNames. This currently only resolves to local
2135 variables from the evaluator context (GetVars call).
2137 (CompletionMemberAccess): Implements support for completing member
2140 * cs-parser.jay: Add support for completion in a few places.
2142 * eval.cs (GetCompletions): New public API for the evaluator that
2143 returns a list of possible completions given the input. The
2144 return value is an array of completions
2146 * anonymous.cs (Compatible): If the exception thrown from the
2147 resolved expression is a CompletionResult exception let that one
2148 through instead of printing a diagnostic error in the try/catch.
2150 2009-03-22 Miguel de Icaza <miguel@novell.com>
2154 * driver.cs (Main): Use Environment.Exit to quit quickly and
2155 prevent the compiler from doing the usual wait for helper thread
2158 This is to prevent a slowdown that was reported by Gonzalo on
2161 2009-03-19 Marek Safar <marek.safar@gmail.com>
2163 * ecore.cs: Load build-in types directly instead of accessing
2166 2009-03-18 Marek Safar <marek.safar@gmail.com>
2168 * ecore.cs: Always use unbox.any when available.
2170 2009-03-18 Marek Safar <marek.safar@gmail.com>
2172 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
2174 2009-03-17 Marek Safar <marek.safar@gmail.com>
2176 * generic.cs: Removed obsolete version of type inference.
2178 2009-03-16 Marek Safar <marek.safar@gmail.com>
2180 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
2181 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
2182 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
2183 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
2185 2009-03-11 Marek Safar <marek.safar@gmail.com>
2187 A fix for bug #482996
2188 * anonymous.cs: Make sure we are not infering return type when
2189 checking type compatibility.
2191 2009-03-11 Marek Safar <marek.safar@gmail.com>
2193 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
2194 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
2195 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
2196 attributes in their own structure. Needed when accessing their
2197 properties before they are resolved.
2199 2009-03-09 Marek Safar <marek.safar@gmail.com>
2201 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
2202 hashtable (~10x faster).
2204 * driver.cs: Removed wrong Reset.
2206 2009-03-08 Marek Safar <marek.safar@gmail.com>
2208 * class.cs: Use correct common base type for unmanaged delayed
2211 * rootcontext.cs: Wrap unhandled exception.
2213 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
2215 Make SeekableStreamReader self-tuning and arbitrarily seekable
2216 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
2218 (SeekableStreamReader.Position.set): Use it. Simplify logic
2219 which, as a side-effect, makes it arbitrarily-seekable. Tune the
2220 buffer size when the stream needs to be re-read from the beginning.
2222 2009-03-05 Marek Safar <marek.safar@gmail.com>
2224 A fix for bug #480100
2225 * parameter.cs: A parameter is not hoisted when used directly as ET.
2227 2009-03-04 Marek Safar <marek.safar@gmail.com>
2229 * statement.cs: Fixed an issue when using variable is of interface
2232 2009-03-03 Marek Safar <marek.safar@gmail.com>
2234 A fix for bug #480319
2235 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
2237 2009-03-03 Marek Safar <marek.safar@gmail.com>
2239 A fix for bug #480867
2240 * typemanager.cs, expression.cs, ecore.cs: Changed method group
2241 expression to have no valid type.
2243 2009-03-03 Marek Safar <marek.safar@gmail.com>
2245 A fix for bug #481258
2246 * class.cs: Set extension method flag in partial container.
2248 2009-03-03 Marek Safar <marek.safar@gmail.com>
2250 * statement.cs, typemanager.cs: Use expression for StringEmitter.
2252 * attribute.cs: Add sanity check.
2254 2009-02-27 Marek Safar <marek.safar@gmail.com>
2256 * class.cs: Add external constructor error.
2258 2009-02-26 Marek Safar <marek.safar@gmail.com>
2260 A fix for bug #475354
2261 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
2262 correctly user defined nullable equality operators.
2264 2009-02-25 Marek Safar <marek.safar@gmail.com>
2266 A fix for bug #479532
2267 * expression.cs: Implement NewInitialize::AddressOf.
2269 2009-02-25 Marek Safar <marek.safar@gmail.com>
2271 A fix for bug #413633
2272 * expression.cs: Iterate all base class-constraint types.
2274 2009-02-24 Marek Safar <marek.safar@gmail.com>
2276 A fix for bug #479209
2277 * literal.cs: Mutate null underlying type.
2279 2009-02-24 Marek Safar <marek.safar@gmail.com>
2281 A fix for bug #476295
2282 * convert.cs: Avoid wrapping implicitly convertible reference type.
2284 2009-02-23 Marek Safar <marek.safar@gmail.com>
2286 * iterators.cs: Create MemberName correctly.
2288 2009-02-23 Marek Safar <marek.safar@gmail.com>
2290 A fix for bug #478655
2291 * literal.cs: Check also underlying null type conversion.
2293 2009-02-21 Marek Safar <marek.safar@gmail.com>
2295 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
2297 2009-02-20 Marek Safar <marek.safar@gmail.com>
2299 A fix for bug #477447
2300 * statement.cs: Add reference to correct parent storey when this
2301 is accessible from deep children storey (more than 1 level).
2303 2009-02-19 Marek Safar <marek.safar@gmail.com>
2305 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
2306 * class.cs: Define base type members before setting up member cache.
2308 2009-02-18 Marek Safar <marek.safar@gmail.com>
2310 A fix for bug #477378
2311 * nullable.cs, expression.cs, statement.cs: More precise null type
2314 2009-02-18 Marek Safar <marek.safar@gmail.com>
2316 A fix for bug #472805
2317 * typemanager.cs, namespace.cs: Import only visible extension method
2320 2009-02-18 Marek Safar <marek.safar@gmail.com>
2322 A fix for bug #476895
2323 * attribute.cs: Use correct resolve context for attribute type.
2325 2009-02-18 Marek Safar <marek.safar@gmail.com>
2327 A fix for bug #476266
2328 * anonymous.cs: Mutate multi-dimensional arrays.
2330 2009-02-18 Marek Safar <marek.safar@gmail.com>
2332 A fix for bug #476400
2333 * statement.cs, expression.cs: Removed wrong Dispose optimization.
2335 2009-02-18 Marek Safar <marek.safar@gmail.com>
2337 A fix for bug #476811
2338 * generics.cs: Fixed null-literal check.
2340 2009-02-17 Marek Safar <marek.safar@gmail.com>
2342 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
2343 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
2344 messing with static variables.
2346 2009-02-16 Marek Safar <marek.safar@gmail.com>
2348 A fix for bug #475965
2349 * generics.cs: Check generic parameter type after extracting from
2352 2009-02-16 Marek Safar <marek.safar@gmail.com>
2354 A fix for bug #475823
2355 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
2358 2009-02-14 Marek Safar <marek.safar@gmail.com>
2360 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
2361 Simplified event field definition using backing field and not
2362 field builder directly.
2364 * expression.cs (EmitLdArg): Optimize fast paths.
2366 2009-02-13 Marek Safar <marek.safar@gmail.com>
2368 A fix for bug #475327
2369 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2371 2009-02-13 Marek Safar <marek.safar@gmail.com>
2373 A fix for bug #475342
2374 * cs-parser.jay: Using 'super' instead of 'base' to call base
2375 constructor crashes compiler.
2377 2009-02-13 Marek Safar <marek.safar@gmail.com>
2379 A fix for bug #475354
2380 * expression.cs (Constantify): Add nullable types.
2382 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2384 2009-02-12 Marek Safar <marek.safar@gmail.com>
2386 A fix for bug #475246
2387 * expression.cs: More broken flowanalysis hacking needed.
2389 2009-02-12 Marek Safar <marek.safar@gmail.com>
2391 * attribute.cs: Compare only ref/out array modifiers.
2393 2009-02-11 Marek Safar <marek.safar@gmail.com>
2395 * statement.cs: Use member cache when looking for foreach members.
2397 2009-02-11 Marek Safar <marek.safar@gmail.com>
2399 * expression.cs: Don't expose internal initializer types.
2401 * statement.cs: Check also explicit conversions for goto case.
2403 2009-02-11 Marek Safar <marek.safar@gmail.com>
2405 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2407 2009-02-10 Marek Safar <marek.safar@gmail.com>
2409 * *.cs: Replace null-type with NullLiteral where appropriate.
2411 2009-02-09 Marek Safar <marek.safar@gmail.com>
2413 * expression.cs: Initializer of reference argument use temporary
2414 variable to be verifiable.
2416 * parameter.cs: Share EmitLdArg.
2418 2009-02-09 Marek Safar <marek.safar@gmail.com>
2420 A fix for bug #473559
2421 * class.cs: Fixed: Not reporting error about nested class with the
2424 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2426 Contributed under the MIT/X11 license.
2428 * generic.cs: Added VerifyVariantTypeParameters which performs new
2429 variance verification logic. The old logic, based on the spec, was
2430 wrong because the spec is full of LIES!
2432 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2434 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2437 * ecore.cs: Added calls to the new variance verification logic.
2440 * delegate.cs: Removed calls to the old variance verification logic.
2442 2009-02-06 Marek Safar <marek.safar@gmail.com>
2444 * delegate.cs: Use cached Invoke method directly.
2446 2009-02-06 Marek Safar <marek.safar@gmail.com>
2448 * expression.cs: Emit expression tree for hoisted variable access.
2450 2009-02-04 Marek Safar <marek.safar@gmail.com>
2452 * namespace.cs: Add better extension class check.
2454 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2456 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2458 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2460 This patch adds initial generic variance support to the compiler.
2461 It is contributed under the MIT/X11 license.
2463 * typemanager.cs: Modified ImplementsInterface to check variance.
2464 Added VerifyVariantTypeParameters which checks the specified type to see
2465 if it uses a variant type parameter as a type argument (which is not
2466 allowed). Added IsVariantOf which determins if the first type is a
2467 variant of the second. NOTE: This only supports reference types at
2468 the moment to conform with the current level of VM support. When the
2469 VM supports value types, this will follow step.
2471 * generic.cs: Added the Variance enum. Added a Variance property to
2472 TypeParameter and added variance support to definition phase. Added a
2473 Variance property to TypeParameterName. Also check to make sure that
2474 no variant types appear in generic method parameters.
2476 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2477 keywords if the langversion supports it.
2479 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2480 that variant types are only used in legal positions. Also added
2481 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2484 * decl.cs: Construct TypeParameter with the variance information.
2486 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2487 and ImplicitConversionStandard.
2489 * rootcontext.cs: Added new "Future" language version.
2491 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2492 type parameters are not used as type arguments in interface inheritance.
2493 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2494 parameters are not used as method return types. In MemberBase.
2495 ResolveMemberType, ensure that variant type parameters are not used
2496 as type arguments. Also call VerifyNoVariantTypeParameters on every
2497 set of parameters which are resolved.
2499 * delegate.cs: Modified Delegate.Define to ensure that variant
2500 parameters are not used as type arguments and that a contravariant
2501 parameter is not used as the return type. Also call
2502 VerifyNoVariantTypeParameters on the delegate parameters.
2504 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2505 to specify generic variance.
2507 * driver.cs: Added support for LanguageVersion.Future in the form of
2508 "-langversion:future".
2510 * generic-mcs.cs: Stubbed out new members in generic.cs.
2512 2009-02-03 Marek Safar <marek.safar@gmail.com>
2514 * class.cs, generic.cs: Emit type parameter constraints for nested
2517 2009-02-02 Marek Safar <marek.safar@gmail.com>
2519 A fix for bug #471213
2520 * class.cs: Avoid emitting backing field for abstract event fields.
2522 2009-02-01 Marek Safar <marek.safar@gmail.com>
2524 A fix for bug #359731
2525 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2528 2009-01-30 Marek Safar <marek.safar@gmail.com>
2530 A fix for bug #470767
2531 * statement.cs: Introduced BlockScopeExpression, needed when
2532 expression tree conversion has to emit scope variables.
2534 2009-01-29 Marek Safar <marek.safar@gmail.com>
2536 * class.cs: Remove duplicate CallingConvention.
2538 2009-01-29 Marek Safar <marek.safar@gmail.com>
2540 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2541 when I finally found the right naming convention.
2543 2009-01-29 Marek Safar <marek.safar@gmail.com>
2545 * cs-tokenizer.cs: Put back different open parens optimization.
2547 2009-01-28 Marek Safar <marek.safar@gmail.com>
2549 A fix for bug #470227
2550 * cs-tokenizer.cs: Remove too agressive parser optimization.
2552 2009-01-28 Marek Safar <marek.safar@gmail.com>
2554 A fix for bug #324319
2555 * class.cs: Remove too early base type resolve.
2557 2009-01-27 Marek Safar <marek.safar@gmail.com>
2559 A fix for bug #324319
2560 * ecore.cs: Explicitly type null when assigning to type argument to
2561 make pass verifier check.
2563 2009-01-27 Marek Safar <marek.safar@gmail.com>
2565 * anonymous.cs: Fixed recent regression when initializing captured
2568 2009-01-26 Marek Safar <marek.safar@gmail.com>
2570 A fix for bug #469019
2571 * anonymous.cs: Use all parent type parameters when instantiating
2572 nested generic storey.
2574 2009-01-26 Marek Safar <marek.safar@gmail.com>
2576 * expression.cs: Check for null instance methodgroup expression.
2578 2009-01-26 Marek Safar <marek.safar@gmail.com>
2580 A fix for bug #469244
2581 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2582 instance inside a conditional expression.
2584 2009-01-23 Marek Safar <marek.safar@gmail.com>
2586 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2587 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2588 GetElementType and HasElementType. IsValueType clean up.
2590 2009-01-23 Marek Safar <marek.safar@gmail.com>
2592 * nullable.cs: Use common EmitCall.
2594 * expression.cs: Emit constraint. for virtual calls only.
2596 2009-01-23 Marek Safar <marek.safar@gmail.com>
2598 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2599 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2600 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2603 2009-01-22 Jb Evain <jbevain@novell.com>
2605 * anonymous.cs: make anonymous types' ToString implementation
2606 match what csc outputs.
2608 2009-01-21 Marek Safar <marek.safar@gmail.com>
2610 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2613 2009-01-17 Marek Safar <marek.safar@gmail.com>
2615 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2618 2009-01-16 Marek Safar <marek.safar@gmail.com>
2620 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2623 2009-01-15 Marek Safar <marek.safar@gmail.com>
2625 A fix for bug #466634
2626 * statement.cs: Add reference for nested storey when only this
2629 2009-01-15 Marek Safar <marek.safar@gmail.com>
2631 A fix for bug #466474
2632 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2635 2009-01-15 Marek Safar <marek.safar@gmail.com>
2637 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2638 Fixed nested stories parent referencing process. Also fixes #463985.
2640 2009-01-06 Marek Safar <marek.safar@gmail.com>
2642 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2643 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2644 implementation. Also fixes #463108.
2646 2009-01-05 Marek Safar <marek.safar@gmail.com>
2648 A fix for bug #416109
2649 * decl.cs: Issue correct CLSAttribute warning location.
2651 2009-01-05 Marek Safar <marek.safar@gmail.com>
2653 A fix for bug #456775
2654 * attribute.cs: Use attribute owner scope when resolving attribute
2657 2009-01-05 Marek Safar <marek.safar@gmail.com>
2659 A fix for bug #457257
2660 * decl.cs: Fixed incorrect member declaring type comparison.
2662 2009-01-05 Marek Safar <marek.safar@gmail.com>
2664 A fix for bug #460896
2665 * driver.cs: Handle /RES resources as embeddable.
2667 2009-01-05 Marek Safar <marek.safar@gmail.com>
2669 A fix for bug #462515
2670 * ecore.cs: Report inacessible members upwards.
2672 2009-01-05 Marek Safar <marek.safar@gmail.com>
2674 A fix for bug #463190, #463192
2675 * decl.cs, namespace.cs: Also import internal extension classes.
2677 2009-01-04 Marek Safar <marek.safar@gmail.com>
2679 A fix for bug #463415
2680 * generic.cs: Use right index for RemoveDependentTypes.
2682 2009-01-02 Marek Safar <marek.safar@gmail.com>
2684 A fix for bug #463196
2685 * expression.cs: Fixed enum to null comparison.
2687 2009-01-02 Marek Safar <marek.safar@gmail.com>
2689 A fix for bug #463121
2690 * nullable.cs: Fixed nullable user equality operator comparison.
2692 2009-01-02 Marek Safar <marek.safar@gmail.com>
2694 A fix for bug #462950
2695 * class.cs, decl.cs: Use full explicit name when defining automatic
2696 property backing field.
2698 2009-01-02 Marek Safar <marek.safar@gmail.com>
2700 A fix for bug #462592
2701 * pending.cs: Emit type arguments for generic proxy method.
2703 2008-12-30 Marek Safar <marek.safar@gmail.com>
2705 * expression.cs (As): Mutate all type arguments.
2707 2008-12-29 Marek Safar <marek.safar@gmail.com>
2709 A fix for bug #462622
2710 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2713 2008-12-29 Marek Safar <marek.safar@gmail.com>
2715 A fix for bug #450782
2716 * ecore.cs: Consider more variables of form V.I to be fixed.
2718 2008-12-29 Marek Safar <marek.safar@gmail.com>
2720 A fix for bug #460712
2721 * typemanager.cs: Core types could be imported.
2723 2008-12-28 Marek Safar <marek.safar@gmail.com>
2725 A fix for bugs #460847, #460772, #458049, #457339, #447807
2726 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2727 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2728 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2729 user lambdas used inside query clauses.
2731 2008-12-18 Marek Safar <marek.safar@gmail.com>
2733 A fix for bug #460229
2734 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2736 2008-12-18 Marek Safar <marek.safar@gmail.com>
2738 A fix for bug #459952
2739 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2741 2008-12-18 Marek Safar <marek.safar@gmail.com>
2743 A fix for bug #459630
2744 * convert.cs: Enum to valuetype conversion is not allowed.
2746 2008-12-18 Marek Safar <marek.safar@gmail.com>
2748 A fix for bug #457087
2749 * generic.cs: Don't crash when constraint comes from type
2752 2008-12-16 Marek Safar <marek.safar@gmail.com>
2754 A fix for bug #459221
2755 * anonymous.cs, statement.cs: Delay only captured this
2758 2008-12-12 Marek Safar <marek.safar@gmail.com>
2760 A fix for bug #457489
2761 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2762 and initialization to capture scope initializers correctly.
2764 2008-12-11 Marek Safar <marek.safar@gmail.com>
2766 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2767 ParameterReference refactoring.
2769 2008-12-03 Marek Safar <marek.safar@gmail.com>
2771 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2772 to be imported from any assembly.
2774 2008-12-03 Marek Safar <marek.safar@gmail.com>
2776 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2777 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2778 from anonymous method and lambda expression.
2780 2008-12-01 Marek Safar <marek.safar@gmail.com>
2782 A fix for bug #448560
2783 * expression.cs (As): Box any generic type arguments to be
2786 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2788 Add tripwire for implicit conversion bugs
2789 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2791 (MethodGroupExpr.OverloadResolve): Add sanity check between
2792 IsApplicable and VerifyArgumentsCompat.
2793 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2795 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2797 Fix build break in System.Data_test
2798 * convert.cs (ImplicitConversionExists): Move NullLiteral
2800 (ImplicitStandardConversionExists): ... here.
2802 2008-11-28 Marek Safar <marek.safar@gmail.com>
2804 * literal.cs: Emit correctly explicit null to nullable cast.
2806 2008-11-28 Marek Safar <marek.safar@gmail.com>
2808 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2811 2008-11-28 Marek Safar <marek.safar@gmail.com>
2813 A fix for bug #449005
2814 * convert.cs, nullable.cs: Use only one implicit nullable
2817 2008-11-27 Marek Safar <marek.safar@gmail.com>
2819 * convert.cs, literal.cs: More Convert cleanup is needed.
2821 2008-11-27 Marek Safar <marek.safar@gmail.com>
2823 * decl.cs, class.cs: Fixed misleading error message.
2825 2008-11-26 Marek Safar <marek.safar@gmail.com>
2827 A fix for bug #449005
2828 * nullable.cs (EmitEquality): Disable optimization for user operator
2831 2008-11-25 Marek Safar <marek.safar@gmail.com>
2833 A fix for bug #447027
2834 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2835 with context variables stored as expression instances.
2837 2008-11-25 Marek Safar <marek.safar@gmail.com>
2839 A fix for bug #447027
2840 * delegate.cs: Fixed delegate VerifyMethod logic.
2842 2008-11-24 Marek Safar <marek.safar@gmail.com>
2844 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2847 2008-11-21 Marek Safar <marek.safar@gmail.com>
2849 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2850 member type resolve to follow normal flow, instead of random
2853 2008-11-21 Marek Safar <marek.safar@gmail.com>
2855 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2858 2008-11-21 Marek Safar <marek.safar@gmail.com>
2860 * const.cs: Emit decimal array constant as literal.
2862 2008-11-20 Marek Safar <marek.safar@gmail.com>
2864 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2866 2008-11-19 Marek Safar <marek.safar@gmail.com>
2868 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2869 into real property (saves 8 MB for corlib compilation).
2871 2008-11-19 Marek Safar <marek.safar@gmail.com>
2873 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2874 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2875 generic-mcs.cs: Small cleanup of TypeArguments.
2877 2008-11-18 Marek Safar <marek.safar@gmail.com>
2879 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2880 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2881 of ConstructedType expression, renamed to GenericTypeExpr.
2883 2008-11-17 Marek Safar <marek.safar@gmail.com>
2885 A fix for bug #445303
2886 * location.cs (IsConditionalDefined): Handle undefined global
2889 2008-11-17 Marek Safar <marek.safar@gmail.com>
2891 A fix for bug #444678
2892 * expression.cs (TryReduceConstant): Always create new constant
2895 2008-11-17 Marek Safar <marek.safar@gmail.com>
2897 A fix for bug #444673
2898 * ecore.cs: Ignore open generic types when used as generic type
2901 2008-11-17 Marek Safar <marek.safar@gmail.com>
2903 A fix for bug #445458
2904 * expression.cs, cs-parser.jay: Don't crash when an expression
2907 2008-11-17 Marek Safar <marek.safar@gmail.com>
2909 A fix for bug #445464
2910 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2911 inside unbound type.
2913 2008-11-14 Jb Evain <jbevain@novell.com>
2915 * driver.cs: ignore empty -nowarn argument such as
2916 the one in -nowarn:12,13,,.
2918 2008-11-13 Marek Safar <marek.safar@gmail.com>
2920 A fix for bug #444271
2921 * anonymous.cs: Rescan parent storeys when best candidate was
2924 2008-11-13 Marek Safar <marek.safar@gmail.com>
2926 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2927 useless UnboundTypeExpression.
2929 * attribute.cs: Do check obsolete attribute on generic types.
2931 2008-11-12 Marek Safar <marek.safar@gmail.com>
2933 A fix for bugs #425680, #400139
2934 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2937 2008-11-11 Marek Safar <marek.safar@gmail.com>
2939 A fix for bug #435747
2940 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2941 compound value types assignment. Few micro optimizations added.
2943 2008-11-10 Marek Safar <marek.safar@gmail.com>
2945 A fix for bug #442610
2946 * anonymous.cs (MutateConstructor): More SRE hacking.
2948 2008-11-10 Marek Safar <marek.safar@gmail.com>
2950 A fix for bug #442579
2951 * ecore.cs: Also initialize expanded form of a method with 1 params
2954 2008-11-06 Marek Safar <marek.safar@gmail.com>
2956 * expression.cs (UnaryMutator): Do early l-side check.
2958 2008-11-05 Miguel de Icaza <miguel@novell.com>
2960 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2961 Init, otherwise we would crash later on when checking for friend
2964 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2965 Otherwise we never get any meaningful information as to what
2968 2008-11-05 Marek Safar <marek.safar@gmail.com>
2970 A fix for bug #436318
2971 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2973 2008-11-05 Miguel de Icaza <miguel@novell.com>
2975 * namespace.cs: Turns out that it was a really bad idea to hide
2976 the errors for namespaces not found here in eval mode.
2978 * eval.cs: When we process using clauses, only enter those into
2979 the list of valid using clauses after they have been validated.
2981 The above change gives the proper semantics: it does not
2982 senselessly report the same errors with broken using statements by
2983 never storing them in the first place when they are invalid.
2985 2008-11-05 Marek Safar <marek.safar@gmail.com>
2987 A fix for bug #421839
2988 * cs-parser.jay: Remove expression from coalesce rule to force lower
2989 priority than the assignment operator.
2991 2008-11-05 Marek Safar <marek.safar@gmail.com>
2993 A fix for bug #437875
2994 * nullable.cs: Compile correctly method group operand used with null
2995 coalescing operator.
2997 2008-11-04 Marek Safar <marek.safar@gmail.com>
2999 A fix for bug #434589
3000 * expression.cs (Binary): Ignore lifted conversions when at least
3001 one operand is of reference type.
3003 2008-11-04 Marek Safar <marek.safar@gmail.com>
3005 * cs-parser.jay: Better syntax error report.
3007 2008-11-03 Marek Safar <marek.safar@gmail.com>
3009 A fix for bug #436792
3010 * cs-parser.jay: Use GetLocation to access location.
3012 2008-11-03 Marek Safar <marek.safar@gmail.com>
3014 A fix for bug #440774
3015 * cs-parser.jay: Also set current_array_type when parsing local
3018 2008-11-03 Marek Safar <marek.safar@gmail.com>
3020 A fix for bug #440785
3021 * expression.cs (As): Don't resolve self modifing expression
3024 2008-11-03 Marek Safar <marek.safar@gmail.com>
3026 A fix for bug #439447
3027 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
3029 2008-11-03 Marek Safar <marek.safar@gmail.com>
3031 A fix for bug #437571
3032 * cs-parser.jay: Fixes internal error for invalid expression
3035 2008-10-17 Marek Safar <marek.safar@gmail.com>
3037 * ecore.cs: Resolve correctly ambiguous params delegate methods.
3039 2008-10-17 Marek Safar <marek.safar@gmail.com>
3041 * generic.cs, anonymous.cs: Simplified GetDeclarations.
3043 2008-10-17 Marek Safar <marek.safar@gmail.com>
3045 * cs-tokenizer.cs: More precise cast parsing.
3047 2008-10-16 Martin Baulig <martin@ximian.com>
3049 * anonymous.cs (AnonymousMethodStorey): Put back the
3050 `hoisted_locals' hashtable and use it in EmitType().
3052 2008-10-15 Marek Safar <marek.safar@gmail.com>
3054 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
3055 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
3058 2008-10-14 Marek Safar <marek.safar@gmail.com>
3060 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
3062 2008-10-14 Marek Safar <marek.safar@gmail.com>
3064 * statement.cs: Mutate scope initializers.
3066 2008-10-14 Marek Safar <marek.safar@gmail.com>
3068 * expression.cs: Use typeless value for This constant.
3070 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
3072 2008-10-14 Marek Safar <marek.safar@gmail.com>
3074 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
3077 2008-10-13 Marek Safar <marek.safar@gmail.com>
3079 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
3082 2008-10-13 Marek Safar <marek.safar@gmail.com>
3084 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
3085 parser and tokenizer. Fixes many ambiguities including #433258.
3087 2008-10-10 Marek Safar <marek.safar@gmail.com>
3089 * cs-parser.jay: Fixed missing accessor recovery.
3091 2008-10-10 Marek Safar <marek.safar@gmail.com>
3093 A fix for bug #433701
3094 * expression.cs: Better error message.
3096 2008-10-10 Marek Safar <marek.safar@gmail.com>
3098 * cs-parser.jay, expression.cs: Start reporting real parser errors.
3100 * Makefile: Disabled unused debug symbols.
3102 Also fixes: #320556, #321097, #321656, #321876, #351316
3104 2008-10-09 Miguel de Icaza <miguel@novell.com>
3106 * eval.cs: rename "<interactive>" to "{interactive}", to work
3107 around a requirement in the compiler that this be a valid
3108 filename, and in Windows it is not (433886).
3110 2008-10-09 Marek Safar <marek.safar@gmail.com>
3112 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
3114 2008-10-08 Marek Safar <marek.safar@gmail.com>
3116 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
3117 cs-parser.jay: Generic type declaration and type arguments cleanup.
3119 2008-10-05 Marek Safar <marek.safar@gmail.com>
3121 * cs-parser.jay: Allow parsing weird array creation construct.
3123 2008-10-05 Marek Safar <marek.safar@gmail.com>
3125 * cs-parser.jay: Conflicts reduction.
3127 2008-10-04 Marek Safar <marek.safar@gmail.com>
3129 * cs-parser.jay: Conflicts reduction.
3131 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
3134 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
3135 property. Add a 'count' hint about the use of the shared vector.
3136 Ensure that we don't leak out dirty bits.
3137 (UsageVector.MergeChild): Throw away information about variables
3139 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
3141 2008-10-03 Marek Safar <marek.safar@gmail.com>
3143 A fix for bug #431746
3144 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
3145 parameters when iterator is created.
3147 2008-10-03 Marek Safar <marek.safar@gmail.com>
3149 A fix for bug #431827
3150 * expression.cs: Fixed right based pointer arithmetic operations
3153 2008-10-03 Marek Safar <marek.safar@gmail.com>
3155 A fix for bug #353779
3156 * assign.cs, expression.cs: Fixed compound assignment conversions.
3158 2008-10-02 Marek Safar <marek.safar@gmail.com>
3160 A fix for bug #375262
3161 * statement.cs: Refactor ArrayForeach to be usable with string
3162 indexer. Optimized single dimentional arrays foreach.
3164 2008-10-02 Marek Safar <marek.safar@gmail.com>
3166 A fix for bug #431255
3167 * anonymous.cs, expression.cs: Removed broken optimization.
3169 2008-10-01 Marek Safar <marek.safar@gmail.com>
3171 * anonymous.cs: Use full type parameters of parent generic
3172 containers. Removed unnecessary AddParentStoreyReference call.
3174 2008-10-01 Marek Safar <marek.safar@gmail.com>
3176 A fix for bug #324702
3177 * class.cs: Use better shorter names for explicit interface member
3180 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
3182 2008-10-01 Marek Safar <marek.safar@gmail.com>
3184 * expression.cs: Use new interface to check fixed expression.
3186 2008-10-01 Marek Safar <marek.safar@gmail.com>
3188 A fix for bug #421101
3189 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
3190 interface to check for fixed fixed-buffers.
3192 2008-10-01 Marek Safar <marek.safar@gmail.com>
3194 A fix for bug #429264
3195 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
3197 * delegate.cs: Removed unnecessary casts.
3199 2008-09-30 Marek Safar <marek.safar@gmail.com>
3201 A fix for bug #352151
3202 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
3203 class.cs: Fixed already defined explicit interface members check.
3205 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
3207 cs-tokenizer.cs: Fix typo.
3209 2008-09-28 Miguel de Icaza <miguel@novell.com>
3211 * eval.cs (InteractiveBase): The quit command now just sets a
3212 flag, instead of calling Environment.Exit(), it is milder on
3215 CompiledMethod is now in Mono.CSharp, not nested inside
3216 the Evaluator, it was inconvenient to use.
3218 2008-09-27 Miguel de Icaza <miguel@novell.com>
3220 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
3221 code to be invoked without having to reparse.
3223 2008-09-27 Miguel de Icaza <miguel@novell.com>
3225 * ecore.cs: The recent changes to FieldExpr broke this as well.
3226 Fixes LINQ queries in the interactive shell.
3228 * Multiple files: indentation fixing for the Mono coding
3229 guidelines for the switch statement.
3231 * eval.cs: Make the Evaluator API thread safe.
3233 2008-09-26 Marek Safar <marek.safar@gmail.com>
3235 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
3236 constructor parsing.
3238 2008-09-26 Marek Safar <marek.safar@gmail.com>
3240 A fix for bug #325326
3241 * statement.cs: Check possible mistaken empty statement using
3242 explicit blocks only.
3244 2008-09-25 Miguel de Icaza <miguel@novell.com>
3246 * eval.cs (LoadAssembly, ReferenceAssembly): Call
3247 RootNamespace.ComputeNamespaces to update the internal list of
3248 namespaces, this is no longer done for us.
3250 (InteractiveBase): Use the Evaluator APIs instead of calling into
3253 2008-09-25 Marek Safar <marek.safar@gmail.com>
3255 A fix for bug #429264
3256 * expression.cs: Missing mutator for access to multidimensional
3259 2008-09-25 Marek Safar <marek.safar@gmail.com>
3261 * class.cs, statement: Emit DebuggerHidden attribute for iterator
3264 * driver.cs: Missing input argument check.
3266 2008-09-25 Marek Safar <marek.safar@gmail.com>
3268 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
3269 expression.cs, statement.cs, rootcontext.cs, class.cs,
3270 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
3273 2008-09-24 Miguel de Icaza <miguel@novell.com>
3275 * ecore.cs (FieldExpr): Only initialize eclass when we return a
3276 fully constructed FieldExpr, fixes the regression introduced in
3279 * ecore.cs, expression.cs: Plug back the eclass initialization as
3280 otherwise it regresses `csharp'.
3282 2008-09-24 Marek Safar <marek.safar@gmail.com>
3284 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
3285 ecore.cs, attribute.cs: Moved obsolete method checks from emit
3286 phase to resolve phase. It resolves problems with expression trees
3287 and fixes bugs #323796, #325156.
3289 2008-09-23 Marek Safar <marek.safar@gmail.com>
3291 * codegen.cs: Report better error when symbol writer is missing.
3293 2008-09-23 Marek Safar <marek.safar@gmail.com>
3295 * codegen.cs: Set .NET symbol writer.
3297 * decl.cs: Guard against null generic arguments.
3299 * report.cs: Don't report exactly same additional details.
3301 2008-09-22 Marek Safar <marek.safar@gmail.com>
3303 A fix for bug #324917
3304 * cs-parser.jay: Add missing multidimensional non-expression type
3307 2008-09-22 Marek Safar <marek.safar@gmail.com>
3309 A fix for bug #428191
3310 * anonymous.cs: Create an outer generic fields also for non-storey
3313 2008-09-22 Marek Safar <marek.safar@gmail.com>
3315 A fix for bug #378294
3316 * class.cs: Make fixed size buffers gmcs feature only.
3318 2008-09-22 Marek Safar <marek.safar@gmail.com>
3320 A fix for bug #355622, #324993
3321 * assign.cs, const.cs, class.cs: Create new EmitContext for each
3324 2008-09-19 Marek Safar <marek.safar@gmail.com>
3326 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
3329 2008-09-19 Marek Safar <marek.safar@gmail.com>
3331 A fix for bug #416110
3332 * generic.cs: Struct constraint results in default ctor and
3333 ValueType base type constraint to be set.
3335 2008-09-19 Marek Safar <marek.safar@gmail.com>
3337 A fix for bug #423791
3338 * generic.cs: Fixed params output type type-inference.
3340 2008-09-19 Marek Safar <marek.safar@gmail.com>
3342 * cs-parser.jay, expression.cs: Fixed few expression crashes.
3344 2008-09-19 Marek Safar <marek.safar@gmail.com>
3346 * cs-tokenizer.cs: Don't break on extra partial modifier.
3348 2008-09-19 Marek Safar <marek.safar@gmail.com>
3350 A fix for bug #427592
3351 * generic.cs: Use common parameter resolve method.
3353 2008-09-18 Marek Safar <marek.safar@gmail.com>
3355 A fix for bug #414758
3356 * expression.cs, ecore.cs: Fixed crash when accessing non-static
3359 2008-09-18 Marek Safar <marek.safar@gmail.com>
3361 * driver.cs, namespace.cs: Read types and namespaces after all
3362 requested assemblies are loaded, fixes issues with System.Core
3363 auto-reference, and #419888.
3365 2008-09-18 Marek Safar <marek.safar@gmail.com>
3367 A fix for bug #417705
3368 * cs-parser.jay: Fixed as/is operator expression split.
3370 2008-09-18 Marek Safar <marek.safar@gmail.com>
3372 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3373 Fixed expression tree representation of empty new expression and
3374 new initializer expression.
3376 2008-09-18 Miguel de Icaza <miguel@novell.com>
3378 * eval.cs: Remove warning, keep reference to driver around.
3380 * Hide fields that do not need to be public.
3382 2008-09-17 Marek Safar <marek.safar@gmail.com>
3384 A fix for bug #426385
3385 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3386 conversion for array elements.
3388 2008-09-17 Marek Safar <marek.safar@gmail.com>
3390 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3391 void parsing conflicts.
3393 2008-09-15 Marek Safar <marek.safar@gmail.com>
3395 A fix for bug #425601
3396 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3397 System.Core only when there is no custom ExtensionAttribute
3400 2008-09-15 Miguel de Icaza <miguel@novell.com>
3402 * namespace.cs: Do not report CS0246 (name
3404 2008-09-12 Marek Safar <marek.safar@gmail.com>
3406 A fix for bug #425669
3407 * generic.cs: Don't cache generic static anonymous method
3410 2008-09-12 Marek Safar <marek.safar@gmail.com>
3412 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3413 conflicting constraints.
3415 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3417 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3420 2008-09-12 Marek Safar <marek.safar@gmail.com>
3422 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3423 to null pointer conversion fixes.
3425 2008-09-11 Marek Safar <marek.safar@gmail.com>
3427 * cs-parser.jay, expression.cs: An implicitly typed local variable
3428 declarator cannot use an array initializer.
3430 2008-09-11 Marek Safar <marek.safar@gmail.com>
3432 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3434 2008-09-11 Marek Safar <marek.safar@gmail.com>
3436 * generic.cs (InflatedConstraints): Don't crash when constraints
3439 * cs-parser.jay: const_declarator is a block.
3441 * constant.cs: Check for not allowed NaN conversions.
3443 2008-09-10 Miguel de Icaza <miguel@novell.com>
3445 * driver.cs: Drop --shell argument, the compiler is no longer a
3448 * eval.cs: Move most of the code that deals with evaluation into
3449 this file and document the public API from repl.cs
3451 * repl.cs: Remove from here.
3453 2008-09-10 Marek Safar <marek.safar@gmail.com>
3455 A fix for bug #424684
3456 * generic.cs: Generic class constraints must come first.
3458 2008-09-09 Miguel de Icaza <miguel@novell.com>
3460 * cs-parser.jay: Improve error reporting for syntax errors in
3461 statements and expressions, we now report the expected tokens
3462 instead of reporting the useless "; expected".
3464 Drop the strings from the token declaration, it turns out that
3465 they did not do what I thought they did. Instead they were adding
3466 two sets of tokens to the tables.
3468 2008-09-09 Marek Safar <marek.safar@gmail.com>
3470 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3471 delegate.cs: Share special type check.
3473 2008-09-09 Marek Safar <marek.safar@gmail.com>
3475 A fix for bug #423981
3476 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3478 2008-09-09 Marek Safar <marek.safar@gmail.com>
3480 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3483 2008-09-09 Marek Safar <marek.safar@gmail.com>
3485 A fix for bugs: #324750, #335946
3486 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3487 lookup rule to determine ?-based tokens.
3489 2008-09-08 Miguel de Icaza <miguel@novell.com>
3491 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3492 expressions (like event adding or removing) end up here, so we
3493 need to treat those as statements.
3495 Add LoadAssembly method.
3497 2008-09-04 Miguel de Icaza <miguel@novell.com>
3499 * repl.cs: Add Time method.
3501 2008-09-05 Marek Safar <marek.safar@gmail.com>
3503 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3505 2008-09-05 Miguel de Icaza <miguel@novell.com>
3507 * repl.cs: Add workaround for old compilers.
3509 2008-09-04 Jb Evain <jbevain@novell.com>
3511 * repl.cs (PrettyPrint): pretty print everything that
3512 implements IDictionary, as well as IEnumerables. Also,
3513 add a quit helper property.
3515 2008-09-04 Marek Safar <marek.safar@gmail.com>
3517 * constant.cs: Better error reporting for decimal literals.
3519 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3522 2008-09-04 Marek Safar <marek.safar@gmail.com>
3523 Miguel de Icaza <miguel@novell.com>
3525 A fix for bug #422951
3526 * assign.cs (Assign.DoResolve): Perform the type conversions
3527 checks before we attempt to initialize `New' initializers.
3529 2008-09-04 Marek Safar <marek.safar@gmail.com>
3531 A fix for bug #422853
3532 * delegate.cs (DelegateCreation): Add special handling for
3533 EmptyExpression.Null instance expression which is just another
3534 hack for undecided member instance exression.
3536 2008-09-04 Marek Safar <marek.safar@gmail.com>
3538 * expression.cs, ecore.cs: Emit full expression tree for reduced
3541 2008-09-04 Marek Safar <marek.safar@gmail.com>
3543 * expression.cs (This): Guard against multi-resolving.
3545 * ecore.cs, statement.cs (Throw): Simplified.
3547 * flowanalysis.cs: Also verify event fields.
3549 2008-09-04 Miguel de Icaza <miguel@novell.com>
3551 * assign.cs (Assign.DoResolve): Perform the type conversions
3552 checks before we attempt to initialize `New' initializers.
3554 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3556 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3559 * repl.cs: Update help.
3561 2008-09-03 Miguel de Icaza <miguel@novell.com>
3563 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3564 handling of the default config handling, including the special
3565 treatment of System.Core assembly.
3567 Fixes the REPL processing for LINQ.
3569 2008-09-03 Marek Safar <marek.safar@gmail.com>
3571 A fix for bug #422507
3572 * expression.cs (UnboxCast): Add missing child expression mutator.
3574 2008-09-03 Marek Safar <marek.safar@gmail.com>
3576 * driver.cs: Don't self reference System.Core assembly.
3578 2008-09-03 Marek Safar <marek.safar@gmail.com>
3580 A fix for bug #422507
3581 * expression.cs (StringConcat): Add missing type mutator.
3583 2008-09-03 Marek Safar <marek.safar@gmail.com>
3585 * generic.cs (TypeInferenceContext): Follow equality rule for
3586 constructed type lower bound type inference.
3588 2008-09-02 Miguel de Icaza <miguel@novell.com>
3590 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3591 <dblank@cs.brynmawr.edu> which updates the cursor position on
3594 2008-09-02 Marek Safar <marek.safar@gmail.com>
3596 A fix for bug #367145
3597 * driver.cs: Fixed import of extension methods when using -noconfig
3600 2008-09-02 Marek Safar <marek.safar@gmail.com>
3602 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3603 version from non-generic implementation instead.
3605 2008-09-01 Marek Safar <marek.safar@gmail.com>
3607 A fix for bug #418908
3608 * class.cs: Use AddScopeStatement for field initializers.
3610 2008-09-01 Marek Safar <marek.safar@gmail.com>
3612 A fix for bug #415385
3613 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3615 2008-09-01 Marek Safar <marek.safar@gmail.com>
3617 A fix for bug #421736
3618 * iterators.cs: Don't crash on unreachable iterators.
3620 2008-09-01 Marek Safar <marek.safar@gmail.com>
3622 A fix for bug #421628
3623 * parameter.cs, attribute.cs: Clone also parameter attributes.
3625 2008-08-30 Miguel de Icaza <miguel@novell.com>
3627 * namespace.cs (LookupType): In EvalMode, try to replace
3628 the TypeBuilder from our cache with a Type as Reflection.Emit does
3629 not like to mix code from older assemblies emitted and new
3632 This sounds like a serious Mono bug that prevents multiple
3633 assemblies to be generated and consumed at the same time.
3635 * cs-parser.jay (push_current_class): Do not make interactive
3636 classes internal or private, make them public as we currently
3637 generate each new class in a new assembly.
3639 2008-08-29 Miguel de Icaza <miguel@novell.com>
3641 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3642 remove types that are entered into the global namespace during
3643 parsing so that we can remove them on failure.
3645 * cs-parser.jay: Parsing: we now keep track of types that are
3646 entered into global variables and queue those in case the parsing
3649 This happens in a few situations: during partial-input, we invoke
3650 the parser repeatedly for example with the string "class X", this
3651 would cause X to be registed, and we need to remove this
3652 registration so that another parse attempt later with say "class X {"
3653 would actually work.
3655 Additionally, if there is an error in the resolution phase, for
3656 example: "class X : NonExistant {}" th
3658 * cs-parser.jay: Be more precise with the errors being raised,
3659 instead of flagging all exceptions during parsing to be attributed
3660 to the parsing process, distinguish those from errors happening in
3661 the actions and hint that using -v would produce the actual
3664 * repl.cs: Do not load all compiler references on each reset,
3665 doing the partial reset takes care of this.
3667 2008-08-28 Miguel de Icaza <miguel@novell.com>
3669 * repl.cs: Add support for loading all the files from
3670 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3673 Introduce a micro-parser that is able to deambiguate on its input
3674 whether we are dealing with a compilation unit (namespace, class,
3675 interface, struct, delegate) declaration or a statement. This
3676 allows both declarations and statements to be entered.
3678 Set history size by default to 300 lines.
3680 Instead of distinguishing based on the parser.InteractiveResult,
3681 have only two cases: statements were parsed, or a compilation unit
3682 was. Always pull the Using statement additions from the
3683 compilation unit parse.
3685 * cs-tokenizer.cs: Rename tokens to better describe their intent
3686 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3688 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3689 EvalMode is used to trigger the lookup of global variables while
3690 StatementMode is used turn variable declarations into static
3693 * getline.cs: Allow history size to be set.
3695 2008-08-29 Marek Safar <marek.safar@gmail.com>
3697 A fix for bug #360755
3698 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3700 2008-08-29 Marek Safar <marek.safar@gmail.com>
3702 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3704 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3705 member name, it is too confusing
3707 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3709 * rootcontext.cs: Finally default to warning level 4.
3711 2008-08-28 Marek Safar <marek.safar@gmail.com>
3713 * class.cs (CheckBase): Ignore overloaded operators.
3715 2008-08-28 Marek Safar <marek.safar@gmail.com>
3717 A fix for bug #420830
3718 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3720 2008-08-28 Marek Safar <marek.safar@gmail.com>
3722 A fix for bug #420832
3723 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3725 2008-08-28 Marek Safar <marek.safar@gmail.com>
3727 A fix for bug #420386
3728 * nullables.cs: Fixed logic of nullable user comparison operators involving
3731 2008-08-28 Marek Safar <marek.safar@gmail.com>
3733 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3735 2008-08-27 Miguel de Icaza <miguel@novell.com>
3737 * repl.cs: Add support for aborting the running code with C-c.
3739 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3741 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3743 2008-08-27 Miguel de Icaza <miguel@novell.com>
3745 * cs-parser.jay (interactive_statement_list): A new set of rules
3746 for hosting statements that uses the "interactive_" prefix.
3748 * repl.cs: Add support for parsing `using' as a statement or as a
3749 directive. Deambiguating before passing this to the parser.
3751 We need to distinguish statement_expressions that occur at the
3752 toplevel vs those that occur embedded into expressions.
3754 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3755 that fixes the cursor key handling, and a history bug.
3757 2008-08-26 Miguel de Icaza <miguel@novell.com>
3759 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3760 limitations in Console, instead the 2.0 bootstrap libraries now
3761 include the Console bits.
3763 Also, remove the use of Nullables from getline.cs
3767 Interactive support for the C# compiler. Use gmcs --shell to
3768 enter a read-eval-print loop shell.
3770 Docs: http://www.mono-project.com/CsharpRepl
3772 * sources: include repl.cs here and getline.cs for gmcs.exe,
3773 everything else is getline.cs impaired.
3775 * Makefile: when bootstrapping pass a special flag
3776 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3777 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3778 This distinguishes those two cases.
3780 * repl.cs: Support for a read-eval-print loop. Will be soon
3781 refactored into eval support and then REPL on top of it.
3783 * ecore.cs: If a simplename lookup fails, before erroring out,
3784 if we are in EvalMode to resolve the name to a declaration in the
3787 This means that variable declarations that happened in previous
3788 classes (as repl puts every statement in a separate class) are
3789 made visible in this way.
3791 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3792 triggered an error due to the end of file being reached. This is
3793 used to do multi-line input, and notify the caller that the user
3794 needs to provide more text before a successful parse.
3796 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3797 to drive the evaluation with a custom wrapper.
3799 * driver.cs: Add support for --shell, and refactor some code to be
3802 * namespace.cs: Add support for serializing the contents of the
3803 namespaces and reloading them.
3805 * getline.cs: A managed implementation of ReadLine under
3806 X11/Apache2 license terms. Easy to embed in other applications as
3809 * namespace.cs: Add some functions to save and restore the
3812 * rootcontext.cs: New public field.
3814 * cs-tokenizer.cs: Add support for one of the possible characters
3815 we introduce into the token stream.
3817 This patch does not affect the regular tokenization process, the
3818 only performance hit would happen if there is an invalid character
3819 on the input string.
3821 * support.cs: Move isatty helper routine here.
3823 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3824 code generator for in-memory assemblies.
3826 2008-08-26 Marek Safar <marek.safar@gmail.com>
3828 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3829 parameter cannot be always used as a type.
3831 2008-08-21 Marek Safar <marek.safar@gmail.com>
3833 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3835 2008-08-21 Marek Safar <marek.safar@gmail.com>
3837 * convert.cs: Implement explicit array to IList<T> conversion.
3839 2008-08-20 Marek Safar <marek.safar@gmail.com>
3841 A fix for bug #362740
3842 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3844 2008-08-20 Marek Safar <marek.safar@gmail.com>
3846 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3847 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3848 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3849 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3850 handling to use just one type of infrastructure and deal with generics
3853 2008-07-23 Martin Baulig <martin@ximian.com>
3855 *** Merged this from trunk revision 108527 ***
3858 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3859 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3862 2008-08-15 Marek Safar <marek.safar@gmail.com>
3864 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3867 2008-08-15 Marek Safar <marek.safar@gmail.com>
3869 * delegate.cs: Fixed compiler crash when creating delegate using partial
3872 * typemanager.cs: MulticastDelegate is not a delegate.
3874 2008-08-14 Marek Safar <marek.safar@gmail.com>
3876 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3879 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3881 * cs-parser.jay (type): Allow 'var' in mcs too.
3882 (local_variable_type): Likewise.
3884 2008-08-14 Marek Safar <marek.safar@gmail.com>
3886 * driver.cs: Removed broken -noconfig variants.
3888 2008-08-14 Marek Safar <marek.safar@gmail.com>
3890 A fix for bug #417078
3891 * expression.cs: Emit correctly left side pointer operators.
3893 2008-08-13 Marek Safar <marek.safar@gmail.com>
3895 * generic.cs, lambda.cs: Inflate method generic arguments only.
3897 2008-08-12 Marek Safar <marek.safar@gmail.com>
3899 * class.cs: Fixed struct layout check regression.
3901 2008-08-12 Marek Safar <marek.safar@gmail.com>
3903 * cs-parser.jay, enum.cs: Simplified enum parsing.
3905 * decl.cs: Check all type parameters conflicts.
3907 * expression.cs, statement.cs, attribute.cs: More expression checks.
3909 2008-08-11 Marek Safar <marek.safar@gmail.com>
3911 * generic.cs: Add type inference types restriction.
3913 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3914 anonymous.cs, expression.cs: Allocate less accessor parameters.
3916 2008-08-08 Marek Safar <marek.safar@gmail.com>
3918 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3921 2008-08-08 Marek Safar <marek.safar@gmail.com>
3923 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3925 2008-08-07 Marek Safar <marek.safar@gmail.com>
3927 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3928 Also fixes #362146 and #381592.
3930 2008-08-07 Marek Safar <marek.safar@gmail.com>
3932 * ecore.cs: Reduced constant cannot be used as an attribute value.
3934 * cs-parser.jay: Base expression has to be a type.
3936 * expression.cs (Conditional): Uses ReducedExpression.
3938 2008-08-06 Marek Safar <marek.safar@gmail.com>
3940 A fix for bug #376826
3941 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3942 address of hoisted local variable or parameter cannot be taken.
3944 2008-08-05 Marek Safar <marek.safar@gmail.com>
3946 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3947 anonymous method inside checked/unchecked expression.
3949 2008-08-05 Marek Safar <marek.safar@gmail.com>
3951 * typemanager.cs (IsEqual): Guard against null.
3953 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3954 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3955 routine. Fixed few misleading conversion errors.
3957 2008-08-04 Marek Safar <marek.safar@gmail.com>
3959 * class.cs: Consider generics when checking cycles in struct layout.
3961 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3963 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3965 2008-08-04 Marek Safar <marek.safar@gmail.com>
3967 A fix for bug #414165
3968 * anonymous.cs: Use same anonymous implementation method for all anonymous
3971 2008-08-04 Marek Safar <marek.safar@gmail.com>
3973 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3976 2008-08-04 Marek Safar <marek.safar@gmail.com>
3978 * cs-parser.jay: Typeof argument has to be a type expression.
3980 * namespace.cs: Check alias and namespace definitions collisions.
3982 * class.cs, pending.cs: Moved explicit interface accessor implementation
3985 * delegate.cs, expression.cs: Verify special name invocations.
3987 2008-08-01 Marek Safar <marek.safar@gmail.com>
3989 * cs-parser.jay: Don't choke on empty generic type arguments.
3991 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3993 * expression.cs, ecore.cs: Minor expressions bugs.
3995 2008-08-01 Marek Safar <marek.safar@gmail.com>
3997 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3998 and added more error handling.
4000 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
4002 * modifiers.cs, enum.cs: Fixed.
4004 2008-07-31 Jb Evain <jbevain@novell.com>
4006 * driver.cs: remove -pkg ability of smcs.
4008 2008-07-30 Marek Safar <marek.safar@gmail.com>
4010 * statement.cs (Switch): Correctly set empty default target for single
4013 2008-07-30 Marek Safar <marek.safar@gmail.com>
4015 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
4016 string switch statement implementation to use string dictionary which
4017 significantly (2-8x) improves performance of generated code.
4019 2008-07-29 Marek Safar <marek.safar@gmail.com>
4021 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
4022 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
4024 2008-07-29 Marek Safar <marek.safar@gmail.com>
4026 A fix for bug #412595
4027 * typemanager.cs, convert.cs, expression.cs: Some types are never
4028 convertible to each other.
4030 2008-07-29 Marek Safar <marek.safar@gmail.com>
4032 * nullable.cs (CreateNullConstant): An error messages update.
4034 2008-07-29 Marek Safar <marek.safar@gmail.com>
4036 A fix for bug #412595
4037 * cfold.cs: Don't cast undefined bool constant.
4039 2008-07-29 Martin Baulig <martin@ximian.com>
4042 (SymbolWriter.Reset): New public static method.
4045 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
4047 2008-07-28 Marek Safar <marek.safar@gmail.com>
4049 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
4051 * expression.cs (ElementAccess): Exact size allocation.
4053 2008-07-26 Marek Safar <marek.safar@gmail.com>
4055 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
4057 2008-07-25 Marek Safar <marek.safar@gmail.com>
4059 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
4061 * class.cs: Removed $PRIVATE$ field hack which caused problems during
4064 2008-07-25 Marek Safar <marek.safar@gmail.com>
4066 A fix for bug #412217
4067 * assign.cs: Mutate also assignment type.
4069 2008-07-25 Marek Safar <marek.safar@gmail.com>
4071 A fix for bug #323644
4072 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
4075 2008-07-25 Marek Safar <marek.safar@gmail.com>
4077 A fix for bug #412134
4078 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
4079 non-enumerable operands when overloading equality or bitwise operators.
4081 2008-07-25 Marek Safar <marek.safar@gmail.com>
4083 * anonymous.cs: Cache closed generic anonymous method delegates.
4085 2008-07-24 Marek Safar <marek.safar@gmail.com>
4087 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
4088 anonymous.cs, statement.cs: Always emit anonymous method as static method
4089 when is instance free. Use nesting for nested anynomous methods blocks.
4091 2008-07-23 Marek Safar <marek.safar@gmail.com>
4093 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
4096 2008-07-23 Marek Safar <marek.safar@gmail.com>
4098 * expression.cs: Removed MakeSimpleCall.
4100 2008-07-23 Marek Safar <marek.safar@gmail.com>
4102 A fix for bug #323012
4103 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
4104 Base method implementing interface has to be public.
4106 2008-07-23 Marek Safar <marek.safar@gmail.com>
4108 * cs-parser.jay: Don't break on missing argument.
4110 2008-07-22 Marek Safar <marek.safar@gmail.com>
4112 A fix for bug #320993
4113 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
4114 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
4116 2008-07-22 Marek Safar <marek.safar@gmail.com>
4118 A fix for bug #320748
4119 * convert.cs: Implicit user operators cannot convert to interfaces
4121 2008-07-22 Marek Safar <marek.safar@gmail.com>
4123 A fix for bug #312686
4124 * driver.cs: Ignore empty assembly references.
4126 2008-07-22 Marek Safar <marek.safar@gmail.com>
4128 A fix for bug #387040
4129 * ecore.cs: Skip constrains check for an explicit implementation.
4131 2008-07-21 Marek Safar <marek.safar@gmail.com>
4133 A fix for bug #409045
4134 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
4135 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
4136 identifiers are file specific unless passed as input arguments.
4138 2008-07-21 Marek Safar <marek.safar@gmail.com>
4140 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
4141 to emit UnmanagedMarshal data under 2.0 profile.
4143 2008-07-21 Marek Safar <marek.safar@gmail.com>
4145 A fix for bug #410369
4146 * parameter.cs: Clone correctly ParamsParameter.
4148 2008-07-21 Marek Safar <marek.safar@gmail.com>
4150 * expression.cs (Argument): Always report type for type based expressions
4153 2008-07-18 Marek Safar <marek.safar@gmail.com>
4155 A fix for bug #410666
4156 * anonymous.cs: Correctly initialize generic storey reference.
4158 2008-07-18 Marek Safar <marek.safar@gmail.com>
4160 * convert.cs: Don't box same type arguments.
4162 2008-07-18 Marek Safar <marek.safar@gmail.com>
4164 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
4165 Finished missing generic type mutators.
4167 2008-07-18 Marek Safar <marek.safar@gmail.com>
4169 * iterators.cs, statement.cs: Finished statements CloneTo.
4171 2008-07-18 Marek Safar <marek.safar@gmail.com>
4173 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
4175 * expression.cs: Emit optimized default value expressions in expression tree
4178 2008-07-18 Marek Safar <marek.safar@gmail.com>
4180 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
4182 2008-07-17 Marek Safar <marek.safar@gmail.com>
4184 A fix for bug #367536
4185 * cs-parser.jay: Check static constructor of generic types for an access
4188 2008-07-17 Marek Safar <marek.safar@gmail.com>
4190 A fix for bug #353800
4191 * lambda.cs: Emit ret for contextual statements.
4193 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
4194 up emitting redundant ret for all anonymous methods with return.
4196 2008-07-17 Marek Safar <marek.safar@gmail.com>
4198 A fix for bug #365188
4199 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
4200 create anonymous method storey in unreachable block.
4202 2008-07-17 Marek Safar <marek.safar@gmail.com>
4204 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
4205 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
4206 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
4207 statement.cs: Fixed relevant defects found by Gendarme.
4209 2008-07-17 Marek Safar <marek.safar@gmail.com>
4211 A fix for bug #325291
4212 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
4213 statement.cs: Replaced IAnonymousHost with top level block flag.
4215 2008-07-17 Marek Safar <marek.safar@gmail.com>
4217 * cs-parser.jay: Clean up unused open_parens.
4219 2008-07-17 Marek Safar <marek.safar@gmail.com>
4221 * ecore.cs: Custom error message for a range variable assignment.
4223 2008-07-16 Marek Safar <marek.safar@gmail.com>
4225 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
4228 2008-07-16 Marek Safar <marek.safar@gmail.com>
4230 * literal.cs: Null literal is of object type.
4232 2008-07-16 Marek Safar <marek.safar@gmail.com>
4234 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
4235 expression of nullable equality comparison.
4237 2008-07-15 Marek Safar <marek.safar@gmail.com>
4239 * expression.cs(PointerArithmetic): Removed redundant assignment.
4241 2008-07-15 Marek Safar <marek.safar@gmail.com>
4243 * decl.cs (GetSignatureForError): Report full namespace name for containers.
4245 2008-07-14 Marek Safar <marek.safar@gmail.com>
4247 A fix for bug #408361
4248 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
4249 they are replaced by GetMethod.
4251 2008-07-14 Marek Safar <marek.safar@gmail.com>
4253 A fix for bug #408721 by jeremie.laval@gmail.com
4254 * expression.cs (Indirection): Implemented CloneTo.
4256 2008-07-14 Marek Safar <marek.safar@gmail.com>
4258 * statement.cs (AssignableSlots): Temporary disabled variable initialization
4261 2008-07-14 Marek Safar <marek.safar@gmail.com>
4263 * report.cs (EnableReporting): Don't reinitialize 0-based values.
4265 2008-07-11 Marek Safar <marek.safar@gmail.com>
4267 * linq.cs: Reset tranparent parameter counter in probing mode.
4269 2008-07-11 Marek Safar <marek.safar@gmail.com>
4271 * anonymous.cs: Mutate anonymous method type.
4273 2008-07-11 Marek Safar <marek.safar@gmail.com>
4275 * ecore.cs, anonymous.cs: Mutate field expressions.
4277 2008-07-10 Marek Safar <marek.safar@gmail.com>
4279 A fix for bug #369670
4280 * linq.cs, statement.cs: Use explicit block for query expressions variables.
4282 2008-07-10 Marek Safar <marek.safar@gmail.com>
4284 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
4286 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
4289 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
4290 only one '>', and finds a '>>', abort the generic lookahead.
4292 2008-07-10 Marek Safar <marek.safar@gmail.com>
4294 A fix for bug #319902
4295 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
4297 2008-07-10 Marek Safar <marek.safar@gmail.com>
4299 A fix for bug #406371
4300 * statement.cs: Moved EmitSymbolInfo to Block.
4302 2008-07-09 Marek Safar <marek.safar@gmail.com>
4304 * ecore.cs: Report better error for extension method overload failures.
4306 2008-07-09 Marek Safar <marek.safar@gmail.com>
4308 * expression.cs (Is): No need to box reference values.
4310 2008-07-09 Marek Safar <marek.safar@gmail.com>
4312 * class.cs: Use event resolve context when initializing CreateEmitContext.
4314 2008-07-09 Marek Safar <marek.safar@gmail.com>
4316 A fix for bug #394436
4317 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
4318 method used inside expression trees. Added more LINQ to expression tree
4321 2008-07-08 Marek Safar <marek.safar@gmail.com>
4323 A fix for bug #378189, #370577
4324 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
4327 2008-07-08 Marek Safar <marek.safar@gmail.com>
4329 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
4332 2008-07-08 Marek Safar <marek.safar@gmail.com>
4334 A fix for bug #406702
4335 * anonymous.cs: Always park anonymous method in the nearest parent storey.
4337 2008-07-07 Marek Safar <marek.safar@gmail.com>
4339 A fix for bug #406648
4340 * cs-parser.jay: Report nullable use in mcs for some cases.
4342 2008-07-07 Marek Safar <marek.safar@gmail.com>
4344 * ecore.cs: Improved argument mismatch error messages.
4346 2008-07-07 Marek Safar <marek.safar@gmail.com>
4348 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
4350 2008-07-07 Marek Safar <marek.safar@gmail.com>
4352 * expression.cs (TypeOf): Mutate type argument.
4354 2008-07-04 Marek Safar <marek.safar@gmail.com>
4356 * class.cs: Report missing partial modifier for correct type.
4358 2008-07-04 Marek Safar <marek.safar@gmail.com>
4360 * ecore.cs, expression.cs (VariableReference): Variable property is
4363 2008-07-04 Marek Safar <marek.safar@gmail.com>
4365 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4367 2008-07-04 Marek Safar <marek.safar@gmail.com>
4369 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4372 2008-07-04 Marek Safar <marek.safar@gmail.com>
4374 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4375 anonymous method storey to an instance method when only "this" is hoisted.
4377 2008-07-03 Marek Safar <marek.safar@gmail.com>
4379 A fix for bug #321615
4380 * expression.cs: Pointer comparisons use unsigned operator.
4382 2008-07-03 Marek Safar <marek.safar@gmail.com>
4384 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4386 2008-07-02 Marek Safar <marek.safar@gmail.com>
4388 A fix for bug #404905
4389 * class.cs: Always initialize local unsafe variables.
4391 2008-06-30 Marek Safar <marek.safar@gmail.com>
4393 A fix for bug #396987
4394 * expression.cs (NewInitialize): Clear local temporary variable for next run
4396 2008-06-27 Marek Safar <marek.safar@gmail.com>
4398 A fix for bug #401020
4399 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4401 2008-06-27 Marek Safar <marek.safar@gmail.com>
4403 A fix for bug #398319
4404 * cs-parser.jay: Implemented undocumented base access expression inside
4407 2008-06-26 Marek Safar <marek.safar@gmail.com>
4409 A fix for bug #404227
4410 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4412 2008-06-26 Marek Safar <marek.safar@gmail.com>
4414 A fix for bug #404227
4415 * convert.cs: Fixed explicit array to interface cast.
4417 2008-06-26 Marek Safar <marek.safar@gmail.com>
4419 A fix for bug #403894
4420 * delegate.cs: Mutate DelegateInvocation type.
4422 2008-06-26 Marek Safar <marek.safar@gmail.com>
4424 A fix for bug #379348
4425 * delegate.cs: Box a load of generic parameters.
4427 2008-06-26 Marek Safar <marek.safar@gmail.com>
4429 * expression.cs: Add an array creation arguments mutate.
4431 2008-06-26 Marek Safar <marek.safar@gmail.com>
4433 A fix for bug #386068
4434 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4437 2008-06-25 Marek Safar <marek.safar@gmail.com>
4439 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4442 2008-06-25 Marek Safar <marek.safar@gmail.com>
4444 A fix for bug #403518
4445 * delegate.cs: Type correctly anonymous method new invocation.
4447 2008-06-24 Marek Safar <marek.safar@gmail.com>
4449 A fix for bug #394826
4450 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4453 2008-06-24 Marek Safar <marek.safar@gmail.com>
4455 A fix for bug #394826
4456 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4459 2008-06-24 Marek Safar <marek.safar@gmail.com>
4461 * class.cs: Clone indexer parameters for localized capturing.
4463 2008-06-24 Marek Safar <marek.safar@gmail.com>
4465 A fix for bug #402379
4466 * expression.cs: Don't crash when an object initializer resolve fails.
4468 2008-06-24 Marek Safar <marek.safar@gmail.com>
4470 A fix for bug #402888
4471 * expression.cs: Mutate conditional expression.
4473 2008-06-24 Marek Safar <marek.safar@gmail.com>
4475 A fix for bug #401012
4476 * class.cs: Keep StructLayout in shared container.
4478 2008-06-24 Marek Safar <marek.safar@gmail.com>
4480 A fix for bug #400438
4481 * decl.cs, class.cs: Only properties can be automatically implemented.
4483 2008-06-24 Marek Safar <marek.safar@gmail.com>
4485 * statement.cs (ChangeToIterator): Copy also labels.
4487 2008-06-23 Marek Safar <marek.safar@gmail.com>
4489 * ecore.cs: Pass type argument details to parent extension method.
4491 2008-06-23 Marek Safar <marek.safar@gmail.com>
4493 A fix for bug #375966
4494 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4496 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4498 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4500 2008-06-22 Marek Safar <marek.safar@gmail.com>
4502 A fix for bug #394347
4503 * anonymous.cs: Cache compatible delegates as compatibility check produces
4504 a new method every time.
4506 2008-06-20 Marek Safar <marek.safar@gmail.com>
4508 * anonymous.cs: Propagate storey reference for single references.
4510 2008-06-20 Marek Safar <marek.safar@gmail.com>
4512 A fix for bug #387615
4513 * assign.cs, expression.cs: Correctly clone compound assignment.
4515 2008-06-19 Marek Safar <marek.safar@gmail.com>
4517 A fix for bug #359611, #359604
4518 * anonymous.cs: Mutate all types of hoisted parameters.
4520 2008-06-19 Marek Safar <marek.safar@gmail.com>
4522 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4523 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4524 expression.cs, codegen.cs, statement.cs
4526 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4527 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4529 ** Anonymous methods, lambda expressions rewrite **
4531 Anonymous expressions are now resolved when an explicit block is resolved
4532 and they don't require any registration procedure anymore. Further,
4533 anonymous methods are defined when explicit block is emitted which allows
4534 better control of whole process and opens possibilities for more
4535 optimizations as well as alternative to reverse whole process.
4537 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4538 process consistent and to correctly emit hoisted generic methods when they
4539 have at least 1 hoisted variable.
4541 2008-06-17 Martin Baulig <martin@ximian.com>
4543 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4545 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4546 virtual property; check it in Emit().
4547 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4549 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4551 (Indexer.Define): Likewise.
4553 2008-06-17 Marek Safar <marek.safar@gmail.com>
4555 * convert.cs: Don't use IsInterface on type arguments.
4557 * delegate.cs: DelegateInvocation uses MethodInfo.
4559 * parameter.cs: Removed IsTypeParameter.
4561 * generic-mcs.cs: More missing stuff.
4563 2008-06-16 Martin Baulig <martin@ximian.com>
4566 (Modifiers.DEBUGGER_HIDDEN): New public const.
4569 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4572 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4573 (AbstractPropertyEventMethod): Likewise.
4574 (Constructor.Emit): Likewise.
4575 (SourceMethod.SetCompilerGenerated): Removed.
4577 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4581 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4582 if we're an `IteratorHost'.
4583 (AnonymousMethodMethod..ctor): Don't set
4584 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4587 2008-06-16 Marek Safar <marek.safar@gmail.com>
4589 * statement.cs: Clean-up foreach statements.
4591 2008-06-12 Marek Safar <marek.safar@gmail.com>
4593 * class.cs: Stop using public method which should not exist
4594 (MethodBuilder.SetGenericMethodSignature).
4596 2008-06-11 Martin Baulig <martin@ximian.com>
4599 (Location.LookupFile): Add `CompilationUnit' argument; when given
4600 a relative file name, make it relative to the directory the .cs
4601 file is located in instead of using the current directory.
4603 2008-06-11 Martin Baulig <martin@ximian.com>
4606 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4607 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4608 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4609 (SourceMethod.SetCompilerGenerated): Likewise.
4611 2008-06-11 Marek Safar <marek.safar@gmail.com>
4613 * codegen.cs, driver: Only write symbol file when it's asked for.
4615 2008-06-11 Marek Safar <marek.safar@gmail.com>
4617 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4619 2008-06-10 Martin Baulig <martin@ximian.com>
4621 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4623 2008-06-09 Marek Safar <marek.safar@gmail.com>
4625 A fix for bug #316290
4626 * expression.cs: Include decimal operators in predefined table.
4628 * parameters.cs: More readonlyness.
4630 2008-06-09 Marek Safar <marek.safar@gmail.com>
4632 A fix for bug #397213
4633 * cs-parser.jay: One more missing current_local_parameters reset.
4635 2008-06-09 Marek Safar <marek.safar@gmail.com>
4637 A fix for bug #396633
4638 * class.cs: Host backing field in partial container.
4640 2008-06-09 Marek Safar <marek.safar@gmail.com>
4642 A fix for bug #397068
4643 * expression.cs: Check both operand types when predefined operator is used.
4645 2008-06-05 Martin Baulig <martin@ximian.com>
4647 Merged the `debugger-kahalo' branch.
4650 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4651 we're an iterator method.
4652 (SourceMethod): Reflect latest symbol writer changes;
4653 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4654 now `start_row' and `end_row'.
4655 (Constructor.Emit): Fix the logic whether to emit symbol information.
4657 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4661 (CompilationUnit): New public class; derives from `SourceFile'.
4662 (SourceFileEntry.DefineSymbolInfo): New public method.
4663 (SourceFileEntry.SetChecksum): New public method.
4664 (Location): Encode hidden line numbers by using `column == 255';
4665 the .ctor now accepts `column == -1' to mark a hidden line number.
4666 (Location.Hidden): New public property.
4667 (Location.CheckPoint): Add `CompilationUnit'.
4668 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4669 (Location.Push): Add `CompilationUnit compile_unit' argument.
4670 (Location.CompilationUnit): New public property.
4673 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4675 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4677 * driver.cs: `SourceFile' -> `CompilationUnit'.
4679 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4681 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4683 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4687 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4688 new symbol writer API to also pass the file.
4690 2008-06-05 Marek Safar <marek.safar@gmail.com>
4692 * statement.cs: Emit catch variable assignment using variable expression.
4694 2008-06-05 Marek Safar <marek.safar@gmail.com>
4696 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4697 with other variable types.
4699 2008-06-04 Marek Safar <marek.safar@gmail.com>
4701 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4702 GetLength method emit, it breaks resolve rules.
4704 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4705 Marek Safar <marek.safar@gmail.com>
4707 A fix for bug #395542
4708 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4711 2008-06-02 Marek Safar <marek.safar@gmail.com>
4713 A fix for bug #395287
4714 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4716 2008-05-31 Marek Safar <marek.safar@gmail.com>
4718 A fix for bug #395845
4719 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4720 non-nullable parameter type.
4722 2008-05-31 Marek Safar <marek.safar@gmail.com>
4724 * class.cs: Handle contructor initializer as a statement in top-level block.
4726 2008-05-30 Marek Safar <marek.safar@gmail.com>
4728 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4729 security attributes.
4731 2008-05-24 Marek Safar <marek.safar@gmail.com>
4733 * ecore.cs, expression.cs: Small IVariable refactoring.
4735 2008-05-22 Marek Safar <marek.safar@gmail.com>
4737 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4739 2008-05-21 Marek Safar <marek.safar@gmail.com>
4741 * cs-parser.jay: Removed redundant catch type check.
4743 2008-05-21 Marek Safar <marek.safar@gmail.com>
4745 A fix for bug #390372
4746 * nullable.cs: Set correct return type.
4748 2008-05-21 Marek Safar <marek.safar@gmail.com>
4750 A fix for bug #391062
4751 * typemanager.cs: Fixed crash when comparing null types.
4753 2008-05-21 Marek Safar <marek.safar@gmail.com>
4755 A fix for bug #391871
4756 * cs-parser.jay: Better error handling for invalid catch type.
4758 2008-05-20 Marek Safar <marek.safar@gmail.com>
4760 A fix for bug #392155
4761 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4763 2008-05-15 Marek Safar <marek.safar@gmail.com>
4765 A fix for bug #390666
4766 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4769 2008-05-15 Marek Safar <marek.safar@gmail.com>
4771 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4774 2008-05-13 Marek Safar <marek.safar@gmail.com>
4776 A fix for bug #389625
4777 * delegate.cs, generic.cs: Some progress on method group return type
4780 2008-05-13 Marek Safar <marek.safar@gmail.com>
4782 A fix for bug #378419
4783 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4785 2008-05-12 Marek Safar <marek.safar@gmail.com>
4787 * class.cs (Constructor): Added IsCompilerGenerated.
4789 2008-05-12 Marek Safar <marek.safar@gmail.com>
4791 * expression.cs: Enum binary operators can accept non-enum operand only when
4792 is implicitly convertible to underlying type.
4794 2008-05-12 Marek Safar <marek.safar@gmail.com>
4796 A fix for bug #389272
4797 * support.cs: Workaround System.InvalidOperationException for enums.
4799 2008-05-12 Marek Safar <marek.safar@gmail.com>
4801 A fix for bug #389073
4802 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4804 2008-05-10 Marek Safar <marek.safar@gmail.com>
4806 * driver.cs: Split Parse.
4808 * location.cs (LookupFile): Uses string.Empty.
4810 2008-05-07 Marek Safar <marek.safar@gmail.com>
4812 * expression.cs, parameter.cs: Small ParameterReference clean up.
4814 2008-05-07 Marek Safar <marek.safar@gmail.com>
4816 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4817 hack. Fixes #387502.
4819 2008-05-06 Martin Baulig <martin@ximian.com>
4821 * class.cs (Constructor.Emit): Fix the logic whether to emit
4824 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4827 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4828 InvalidOperationException when the iterator is before the start or
4831 2008-05-06 Marek Safar <marek.safar@gmail.com>
4833 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4834 when left is nullable type.
4836 2008-05-06 Marek Safar <marek.safar@gmail.com>
4838 A fix for bug #386628
4839 * expression.cs (LocalVariableReference): Continue in resolving when
4840 variable is not assigned.
4842 2008-05-05 Marek Safar <marek.safar@gmail.com>
4844 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4845 nullable operations.
4847 2008-05-04 Marek Safar <marek.safar@gmail.com>
4849 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4850 it saves many redundant temporary variables for nullable operations.
4852 2008-05-03 Marek Safar <marek.safar@gmail.com>
4854 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4856 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4859 * nullable.cs: Constant coalescing operator optimizations.
4861 2008-05-03 Marek Safar <marek.safar@gmail.com>
4863 * constant.cs: Use unsigned conversion for values which are unsigned only.
4865 2008-05-03 Marek Safar <marek.safar@gmail.com>
4867 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4868 coalescing operator as it should be.
4870 2008-05-02 Marek Safar <marek.safar@gmail.com>
4872 A fix for bug #371016
4873 * expression.cs: All predefined delegate operators require implicit method
4876 2008-05-02 Marek Safar <marek.safar@gmail.com>
4878 * constant.cs: Emit long constant as uint when fits the range.
4880 * convert.cs, expression.cs: Fixed few unsafe conversions.
4882 2008-05-02 Marek Safar <marek.safar@gmail.com>
4884 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4886 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4889 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4891 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4893 2008-05-01 Marek Safar <marek.safar@gmail.com>
4895 * constant.cs, literal.cs: IsLiteral property for error reporting.
4897 * ecore.cs, expression.cs: Implemented Property expression.
4899 2008-05-01 Marek Safar <marek.safar@gmail.com>
4901 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4903 * nullable.cs: Implemented nullable coalescing null operator.
4905 * ecore.cs, expression.cs: Expression trees work.
4907 2008-05-01 Marek Safar <marek.safar@gmail.com>
4909 * ecore.cs: CreateExpressionTree is finally abstract.
4911 * expression.cs, linq.cs: Updated.
4913 2008-05-01 Marek Safar <marek.safar@gmail.com>
4915 * expression.cs, ecore.cs: Block base access expression inside expression
4918 2008-05-01 Marek Safar <marek.safar@gmail.com>
4920 A fix for bug #385058
4921 * expression.cs: User-defined operator implementations always take
4922 precedence over predefined operator implementations.
4924 2008-04-30 Marek Safar <marek.safar@gmail.com>
4926 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4927 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4928 expression tree conversions.
4930 2008-04-30 Marek Safar <marek.safar@gmail.com>
4932 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4933 operators method details to Operator class.
4935 2008-04-30 Marek Safar <marek.safar@gmail.com>
4937 * anonymous.cs: Pass unsafe flags to anonymous container.
4939 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4940 inside expression tree.
4942 2008-04-29 Martin Baulig <martin@ximian.com>
4944 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4945 (Tokenizer.PopPosition): Also restore the `line'.
4947 2008-04-29 Marek Safar <marek.safar@gmail.com>
4949 * delegate.cs: Implemented Invoke expression.
4951 2008-04-29 Marek Safar <marek.safar@gmail.com>
4953 * expression.cs: Fixed equality reference comparison regression.
4955 2008-04-29 Marek Safar <marek.safar@gmail.com>
4957 * ecore.cs: Clean up EmptyCast hack.
4959 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4960 using correct conversion rules. Also fixes #383993.
4962 2008-04-28 Martin Baulig <martin@ximian.com>
4964 * class.cs (Constructor.Emit): Don't emit debugging information
4965 for generated default .ctor's.
4967 2008-04-28 Marek Safar <marek.safar@gmail.com>
4969 * convert.cs: Empty-cast ushort to int conversion.
4971 2008-04-28 Marek Safar <marek.safar@gmail.com>
4973 A fix for bug #384191
4974 * ecore.cs, expression.cs: Fixed expression cloning.
4976 2008-04-28 Marek Safar <marek.safar@gmail.com>
4978 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4980 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4982 Fix #381559, test-638.cs, test-639.cs
4983 * assign.cs (CompoundAssign.Helper): New wrapper.
4984 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4986 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4987 Pass unconverted expressions to the params array creation expression.
4988 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4989 (PropertyExpr.EmitAssign): Likewise.
4990 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4991 element if it is of kind CompoundAssign.Helper.
4992 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4993 first before anything else.
4994 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4995 (ArrayAccess.LoadArrayAndArguments): Simplify.
4997 2008-04-27 Marek Safar <marek.safar@gmail.com>
4999 * expression.cs: Fixed cloning of typeof(void).
5001 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
5003 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
5004 (Assign.Emit): Likewise. Move it to ...
5005 (CompoundAssign.DoResolve): ... here and ...
5006 (CompoundAssign.Emit): ... here.
5007 (EventAddOrRemove): New helper to handle += and -= on events, and
5008 avoid the use of BinaryDelegates.
5009 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
5010 (EventExpr.EmitAddOrRemove): Improve.
5011 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
5013 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
5014 create VarExprs for 'foo.bar.var'.
5015 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
5016 is a highly inappropriate name for its functionality.
5018 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
5020 Simplify handling of multiple assignments
5021 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
5023 (SimpleAssign): New. Class to be used for normal assignments.
5024 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
5025 * expression.cs, parameter.cs, statement.cs: Likewise.
5027 2008-04-25 Marek Safar <marek.safar@gmail.com>
5029 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
5030 for incompatible underlying types, more to come, uff.
5032 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
5035 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
5036 Handle 'leave_copy'.
5038 2008-04-25 Marek Safar <marek.safar@gmail.com>
5040 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
5042 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
5044 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
5045 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
5046 * statement.cs (While, Do, For): Allow test to have side effects.
5047 (For.DoEmit): Always emit InitStatement.
5050 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
5051 Always create SideEffectConstant.
5052 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
5053 of type EnumConstant.
5055 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
5056 Handle 'right' being SideEffectConstant of type 'bool'.
5058 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
5059 Use left.EmitBranchable instead of open coding it, so as to
5060 improve optimization opportunities.
5062 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
5064 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
5066 (Expression.EmitSideEffect): Document.
5068 2008-04-23 Marek Safar <marek.safar@gmail.com>
5070 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
5072 2008-04-23 Marek Safar <marek.safar@gmail.com>
5074 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
5076 2008-04-23 Marek Safar <marek.safar@gmail.com>
5078 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
5079 conversion to expression tree.
5081 2008-04-23 Marek Safar <marek.safar@gmail.com>
5083 * ecore.cs: Removed unused expression.
5085 2008-04-22 Marek Safar <marek.safar@gmail.com>
5087 * expression.cs: Implemented NegateChecked and New expressions.
5089 2008-04-22 Marek Safar <marek.safar@gmail.com>
5091 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
5093 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
5096 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
5097 needing final 'ret' instruction.
5099 2008-04-22 Marek Safar <marek.safar@gmail.com>
5101 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
5103 2008-04-21 Marek Safar <marek.safar@gmail.com>
5105 * expression.cs: Emit ldnull and not null expression as an instance argument
5106 of static method expression calls.
5108 2008-04-21 Marek Safar <marek.safar@gmail.com>
5110 A fix for bug #378200
5111 * expression.cs: Fixed crash when creating parameterless expression tree
5114 2008-04-21 Marek Safar <marek.safar@gmail.com>
5116 A fix for bug #375297
5117 * anonymous.cs: Fixed crash when inferring from null argument anonymous
5120 2008-04-21 Marek Safar <marek.safar@gmail.com>
5122 A fix for bug #377596
5123 * decl.cs, class.cs: Emit delegate type argument attributes.
5125 2008-04-21 Marek Safar <marek.safar@gmail.com>
5127 A fix for bug #365314
5128 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
5130 2008-04-21 Marek Safar <marek.safar@gmail.com>
5132 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
5135 2008-04-21 Marek Safar <marek.safar@gmail.com>
5137 * generic.cs (TypeParameter): Removed redundant location.
5139 2008-04-19 Marek Safar <marek.safar@gmail.com>
5141 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
5142 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
5143 FullNamedExpression in all declaration type expression, statements will come
5146 2008-04-18 Marek Safar <marek.safar@gmail.com>
5148 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
5149 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
5151 2008-04-18 Marek Safar <marek.safar@gmail.com>
5153 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
5156 2008-04-17 Marek Safar <marek.safar@gmail.com>
5158 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
5161 2008-04-17 Marek Safar <marek.safar@gmail.com>
5163 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
5167 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
5169 Hook up 'EmitSideEffect'
5170 * constant.cs (Constant.EmitSideEffect): New.
5171 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
5172 (SideEffectConstant.EmitSideEffect): New.
5173 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
5174 unconditional branch in EmitBranchable.
5175 (FieldExpr.EmitBranchable): New.
5176 * expression.cs (Unary.EmitSideEffect): New.
5177 (Binary.EmitSideEffect): New.
5178 (VariableReference.EmitSideEffect): New. Do nothing.
5180 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5182 Introduce 'EmitSideEffect'
5183 * ecore.cs (Expression.EmitSideEffect): New.
5184 (TypeCast): Rename from EmptyCast.
5186 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
5187 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
5188 * convert.cs, nullable.cs: Update to changes.
5190 2008-04-16 Marek Safar <marek.safar@gmail.com>
5192 * class.cs, cs-parser.jay: Early check for base types expression.
5194 2008-04-16 Marek Safar <marek.safar@gmail.com>
5196 * decl.cs (MemberName): Declare PrettyName as obsolete.
5198 2008-04-16 Marek Safar <marek.safar@gmail.com>
5200 * namespace.cs: Use MemberName comparison.
5202 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5205 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
5207 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
5208 (MemberName.FullyQualifiedName): New. Provides the functionality
5209 that users assume FullName would have.
5210 * ecore.cs, namespace.cs: Update to changes.
5212 * statement.cs (Using.assign): Make into ExpressionStatement.
5213 (Using.EmitPreTryBody): Simplify.
5215 2008-04-16 Marek Safar <marek.safar@gmail.com>
5217 * report.cs: ColorFormat is protected.
5219 * rootcontext.cs: Unused fields clean-up.
5221 * namespace.cs: Made UsingEntry name private.
5223 2008-04-16 Marek Safar <marek.safar@gmail.com>
5225 * cs-tokenizer.cs, location.cs: Removed unused field.
5227 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
5228 Raja R Harinath <harinath@hurrynot.org>
5231 * constant.cs (SideEffectConstant.value): Rename from 'left'.
5232 (SideEffectConstant.side_effect): Rename from 'right'.
5233 (SideEffectConstant..ctor): Normalize 'side_effect'.
5234 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
5235 value of this constant.
5236 * cfold.cs: Update to changes.
5238 2008-04-15 Marek Safar <marek.safar@gmail.com>
5240 * cs-paser.jay: Removed unused variable.
5242 * driver.cs: Made Compile instance method.
5244 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
5246 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
5248 2008-04-15 Marek Safar <marek.safar@gmail.com>
5250 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
5252 2008-04-13 Jb Evain <jbevain@novell.com>
5254 * namespace.cs: update the System.Core fullname for 2.1
5255 * driver.cs: update the list of required assemblies for 2.1.
5256 Merged from the Moonlight 2 branch.
5258 2008-04-11 Marek Safar <marek.safar@gmail.com>
5260 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
5261 types and user defined operators. User operators arguments has to be checked
5262 for null value before invocation, which also means no operator is called
5263 when any argument is not convertible to unwrapped nullable type.
5265 2008-04-09 Marek Safar <marek.safar@gmail.com>
5267 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
5268 of Unary expressions to follow operator overloading rules precisely.
5269 Also fixes #321794, #323794
5271 2008-04-08 Marek Safar <marek.safar@gmail.com>
5273 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
5276 2008-04-08 Marek Safar <marek.safar@gmail.com>
5278 * expression.cs, ecore.cs: Implemented MemberInit expression.
5280 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
5282 Fix mono/tests/exception4.cs
5283 * statement.cs (ExceptionStatement, TryCatch): Revert to using
5284 ec.NeedReturnLabel () rather emitting a 'nop'.
5286 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
5288 (TryCatch.SomeCodeFollows): Likewise.
5289 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
5290 for 'break', 'continue' and 'return' statements inside a try.
5291 We're fairly sure that the generated IL stream will have more
5292 instructions textually following the try.
5293 (FlowBranchingTryCatch): Likewise.
5295 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
5296 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
5299 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
5300 wrapper -- forward everything to CollectionForeach.
5301 (CollectionForeach.NonDisposableWrapper): New.
5302 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
5303 instead of a pop + branch to end.
5305 2008-04-07 Marek Safar <marek.safar@gmail.com>
5307 A fix for bug #377485
5308 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
5309 Propagate location for extension method groups. Report conversion failure at
5312 2008-04-07 Marek Safar <marek.safar@gmail.com>
5314 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
5315 ListInit and Field expressions.
5317 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
5319 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
5320 Since $PC is always -1 inside the body of MoveNext, the fault
5322 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
5323 * statement.cs (ExceptionStatement.emit_finally): Likewise.
5324 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
5326 The denouement! Fix #324708
5327 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
5328 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
5329 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
5330 'finally' inside the finally clause.
5332 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
5333 inside an iterator. Don't emit the body of the 'finally' inside
5334 the finally clause yet.
5336 Use the ResumableStatement infrastructure for MoveNext ()
5337 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
5338 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
5339 'old_resume_points'. Move dispatcher upfront.
5340 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
5341 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
5342 in an enumerator. This encodes the main fix in this patch series
5343 -- we can only jump into the first instruction of a try from the
5344 outside, but we want to emit try/finally regions in iterators and
5345 resume in the middle of them.
5347 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
5349 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
5350 of NeedReturnLabel here.
5352 Introduce a common point for emitting try/finally to IL
5353 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
5354 features of the various subclasses, which are now driven by ...
5355 (ExceptionStatement.EmitPreTryBody): ... this and ...
5356 (ExceptionStatement.EmitTryBody): ... this and the original
5358 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
5359 Remove DoEmit and update to follow above protocol.
5361 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5362 of the dispatcher are the same, skip emitting the 'switch'.
5363 * iterator.cs (Iterator.EmitDispose): Update to changes.
5365 Clean up handling of 'using' statement
5366 * statement.cs (UsingTemporary): New. Carved out of ...
5367 (Using): ... this. Simplify drastically. Handle exactly
5369 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5370 or Using as appropriate. If there are multiple variable declared,
5371 create nested Using statements.
5372 (resource_acquisition): Kill.
5374 * statement.cs (ExceptionStatement.EmitForDispose): Use
5375 EmitFinallyBody, not EmitFinally.
5377 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5378 * iterator.cs: Update to changes.
5380 Start using the ResumableStatement infrastructure
5381 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5382 (ResumableStatement.EmitForDispose): New.
5383 (ExceptionStatement): Override them.
5384 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5385 EmitForDispose to create the body of the Dispose method. Don't
5388 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5389 * statement.cs (Toplevel.AddResumePoint): ... here.
5390 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5391 * flowanalysis.cs (FlowBranchingIterator): New.
5392 * codegen.cs (EmitContext): Update to changes.
5394 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5395 (Iterator.old_resume_points): Rename from 'resume_points'.
5396 (Iterator.MoveNextStatement): Remove unused class.
5398 New infrastructure for try/finally in iterators (still unused)
5399 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5400 (FlowBranchingToplevel.AddResumePoint): Hook into
5401 ToplevelBlock.AddResumePoint.
5402 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5403 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5404 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5405 resume points and assign program-counter values.
5406 (ExceptionBlock.AddResumePoint): Collect resume points for
5407 de-muxer at the top of try block.
5408 * iterators.cs (Yield.CheckContext): Simplify.
5409 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5411 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5413 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5414 argument to an ExitStatement.
5415 (FlowBranchingException): Refactor saved origins code.
5416 * statement.cs (ExitStatement): Update to cahges.
5417 * iterator.cs (YieldBreak): Likewise.
5419 * statement.cs (ResumableStatement): New. Common base class for
5420 YieldReturn and ExceptionStatement.
5421 (ExitStatement): New. Common base class for Return and YieldBreak.
5422 (Return): Update to changes.
5423 * iterator.cs (YieldBreak): Likewise.
5424 * lambda.cs (ContextualReturn): Likewise.
5427 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5428 emit a meaningful error message.
5430 Fix #324765, #319508
5431 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5432 (VariableInfo.SetAssigned): Set it.
5433 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5434 determine if CS0219 or CS0168 is appropriate. Don't use
5435 flow-analysis information.
5436 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5437 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5438 (EmitContext.EndFlowBranching): ... this.
5440 2008-04-03 Marek Safar <marek.safar@gmail.com>
5442 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5444 2008-04-03 Marek Safar <marek.safar@gmail.com>
5446 A fix for bug #376508
5447 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5448 ImplicitConversionExists.
5450 2008-04-03 Marek Safar <marek.safar@gmail.com>
5452 * expression.cs (Binary): Added remaining binary operators to expression
5455 * nullable.cs: Optimize shift with null argument.
5457 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5459 Fix minor IL regression
5460 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5461 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5462 * cs-parser.jay (try_statement): Update to changes.
5464 * statement.cs (TryFinally.need_exc_block): Delete.
5465 (TryFinally): Update to changes.
5467 Now all ExceptionStatements are unconditional
5468 * statement.cs (CollectionForeach.DisposableWrapper): New.
5469 Extract out the try/finally code into a new wrapper.
5470 (CollectionForeach.Resolve): Use it to simplify the code.
5472 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5474 Start at simplifying ExceptionStatement semantics a bit
5475 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5476 * cs-parser.jay (try_statement): Update to changes.
5477 (opt_catch_clauses): Remove.
5478 * flowanalysis.cs: Update to changes.
5479 (FlowBranching.BranchingType.TryCatch): New.
5480 (FlowBranchingTryCatch): New.
5482 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5483 (FlowBranching.CreateBranching): Update to changes.
5484 (FlowBranchingBlock.AddSibling): Add sanity check.
5485 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5488 * iterators.cs (Iterator.MarkFinally): Remove.
5489 * statement.cs (ExceptionStatement): Update to changes.
5491 Add support for skipping over finally blocks at runtime. First
5492 in a series to fix #324708
5493 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5494 (Iterator.EmitMoveNext): Initialize it.
5495 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5496 branch over the body of the 'finally' clause.
5498 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5500 Avoid lopsided use of Foo/DoFoo names
5501 * statement.cs (ExpressionStatement.EmitFinallyBody):
5502 Rename from EmitFinally.
5503 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5504 * iterator.cs: Update to changes.
5506 2008-04-02 Marek Safar <marek.safar@gmail.com>
5508 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5509 based on UserOperatorCall. More binary nullable operators clean up.
5511 2008-04-02 Martin Baulig <martin@ximian.com>
5513 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5515 2008-04-02 Marek Safar <marek.safar@gmail.com>
5517 * nullable.cs: Merge user and empty conversions when lifting expression
5520 * expression.cs (StringConcat): Implemented expression tree representation.
5522 2008-04-01 Marek Safar <marek.safar@gmail.com>
5524 * nullable.cs: When lifting null literal and a user operator exists, no call
5527 2008-04-01 Marek Safar <marek.safar@gmail.com>
5529 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5532 2008-04-01 Marek Safar <marek.safar@gmail.com>
5534 * nullable.cs, expression.cs: Use namespace instead heavily nested
5535 monster abstract class.
5537 2008-04-01 Marek Safar <marek.safar@gmail.com>
5539 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5540 lifting of null literal and user operators. Clean up of some temporary
5543 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5545 Fix #368224, test-629.cs
5546 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5547 if it crossed an unwind-protect boundary.
5548 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5549 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5550 inside an unwind-protected region.
5551 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5552 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5553 'leave' instead of a 'br' if unwind-protected.
5554 (Iterator.EmitYieldBreak): Likewise.
5556 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5558 * driver.cs: Only define versioninfo resources if no win32 resource
5561 2008-03-28 Marek Safar <marek.safar@gmail.com>
5563 A fix for bug #372375
5564 * convert.cs: Fixed boxing of nullable types.
5566 2008-03-28 Marek Safar <marek.safar@gmail.com>
5568 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5571 2008-03-28 Marek Safar <marek.safar@gmail.com>
5573 A fix for bug #374619
5574 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5576 2008-03-27 Marek Safar <marek.safar@gmail.com>
5578 * lambda.cs: Check return type only for invocation.
5580 2008-03-27 Marek Safar <marek.safar@gmail.com>
5582 A fix for bug #374214
5583 * ecore.cs: Correctly report argument type mismatch.
5585 2008-03-27 Marek Safar <marek.safar@gmail.com>
5587 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5588 and not rely on broken IsEnum.
5590 2008-03-27 Marek Safar <marek.safar@gmail.com>
5592 * nullable.cs: New file, extracted from generic.cs.
5594 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5596 2008-03-27 Marek Safar <marek.safar@gmail.com>
5598 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5599 predefined comparison operators and null literals.
5601 * report.cs: New warning ID.
5603 2008-03-25 Marek Safar <marek.safar@gmail.com>
5605 A fix for bug #370577
5606 * lambda.cs: Check return type too.
5608 2008-03-25 Marek Safar <marek.safar@gmail.com>
5610 A fix for bug #372846
5611 * class.cs: Automatic properties can be declared as unsafe.
5613 2008-03-20 Marek Safar <marek.safar@gmail.com>
5615 * location.cs: Use string based concatenation.
5617 * expression.cs: LiftedBinaryOperator is gmcs only.
5619 2008-03-20 Marek Safar <marek.safar@gmail.com>
5621 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5622 conversions rules and expression trees.
5624 2008-03-19 Marek Safar <marek.safar@gmail.com>
5626 * delegate.cs: Use extension method source as delegate target.
5628 2008-03-19 Marek Safar <marek.safar@gmail.com>
5630 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5631 binary operations to be purely based on binary operations and optimized
5632 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5633 and other ET refactoring.
5635 * typemanager.cs: Fixed warning.
5637 2008-03-17 Marek Safar <marek.safar@gmail.com>
5639 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5641 * symbolwriter.cs: Fixed.
5643 2008-03-17 Marek Safar <marek.safar@gmail.com>
5645 * anonymous.cs, driver.cs: Reset anonymous types counters.
5647 2008-03-17 Marek Safar <marek.safar@gmail.com>
5649 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5651 * class.cs: Use fullname for all type member definitions.
5653 2008-02-19 Martin Baulig <martin@ximian.com>
5656 (IMethodData.EmitExtraSymbolInfo): New interface method.
5657 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5658 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5659 interface method here as an empty public virtual method.
5662 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5663 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5664 CodeGen.SymbolWriter.SetRealMethodName().
5666 2008-02-18 Martin Baulig <martin@ximian.com>
5669 (ScopeInfo.EmitType): Override this and emit debugging
5670 information for captured variables.
5671 (RootScopeInfo.EmitType): Override this and emit symbol
5672 information for a captured `this'.
5674 2008-02-15 Martin Baulig <martin@ximian.com>
5676 * iterators.cs: Emit debugging info.
5679 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5680 (EmitContext.OmitDebuggingInfo): New public property.
5683 (While): Override Emit() and don't emit symbol info there; do it
5684 inside DoEmit() instead.
5685 (Block.Emit): Omit symbol information while emitting the scope
5686 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5688 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5689 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5690 .ctor to make `IsIterator' work.
5692 2008-03-14 Martin Baulig <martin@ximian.com>
5694 * symbolwriter.cs: Added the new symbol writer function from the
5695 debugger's `terrania' branch; temporarily enclose them inside
5696 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5699 2008-03-14 Martin Baulig <martin@ximian.com>
5702 (SymbolWriter): Make this a public static class.
5705 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5706 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5708 2008-03-14 Marek Safar <marek.safar@gmail.com>
5710 A fix for bug #370577
5711 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5714 2008-03-14 Marek Safar <marek.safar@gmail.com>
5716 * typemanager.cs (CSharpName): Made 250 times faster.
5718 2008-03-13 Marek Safar <marek.safar@gmail.com>
5720 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5722 2008-03-12 Marek Safar <marek.safar@gmail.com>
5724 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5725 crash when predefined field does not exist.
5727 2008-03-12 Marek Safar <marek.safar@gmail.com>
5729 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5731 2008-03-12 Marek Safar <marek.safar@gmail.com>
5733 * class.cs (FixedField): Don't crash when contructors are missing.
5735 2008-03-11 Marek Safar <marek.safar@gmail.com>
5737 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5738 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5739 check internal types accessibility for internal and external types.
5740 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5742 2008-03-11 Marek Safar <marek.safar@gmail.com>
5744 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5745 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5746 attribute.cs, statement: Use corect instance of predefined types (work
5747 related to #364674).
5749 2008-03-07 Marek Safar <marek.safar@gmail.com>
5751 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5753 2008-03-07 Marek Safar <marek.safar@gmail.com>
5755 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5756 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5757 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5758 predefined types clean up, delayed predefined types members initialization
5759 (work related to #364674).
5761 2008-03-05 Marek Safar <marek.safar@gmail.com>
5763 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5765 2008-03-05 Marek Safar <marek.safar@gmail.com>
5767 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5768 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5769 predefined types clean up (work related to #364674).
5771 2008-03-04 Marek Safar <marek.safar@gmail.com>
5773 * ecore.cs: Print an error message instead of throwing exception.
5775 2008-03-04 Marek Safar <marek.safar@gmail.com>
5777 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5778 expression.cs, statement.cs: Unififed null literal representation.
5780 2008-03-03 Marek Safar <marek.safar@gmail.com>
5782 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5783 expression.cs: Refactored binary operators resolve phase and improved speed.
5784 The nullable code is still missing and won't work correctly, more fixes
5787 It also fixes #323726, #324312, #324248, and many other unreported issues.
5789 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5791 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5794 2008-02-27 Marek Safar <marek.safar@gmail.com>
5796 * ecore.cs: Clean-up and split BetterConversion.
5798 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5801 * enum.cs (EnumMember.Value): Only access 'value' if
5802 ResolveValue says it's ok.
5803 (EnumMember.DoResolveValue): Don't set prev_member.value.
5804 (Enum.GetDefinition): Reverse arguments of Equals --
5805 EnumMember.Value can return 'null'.
5807 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5809 2008-02-22 Marek Safar <marek.safar@gmail.com>
5811 * generic.cs, expression.cs: More ongoing work on expression trees.
5813 2008-02-21 Marek Safar <marek.safar@gmail.com>
5815 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5816 handle missing matches when mutiple operators exist.
5818 2008-02-20 Marek Safar <marek.safar@gmail.com>
5820 A fix for bug #363218
5821 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5824 2008-02-20 Marek Safar <marek.safar@gmail.com>
5826 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5827 update. This time to deal correctly with SideEffectConstant expression used
5828 as an argument for another constant folding.
5830 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5832 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5835 2008-02-19 Marek Safar <marek.safar@gmail.com>
5837 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5839 2008-02-19 Marek Safar <marek.safar@gmail.com>
5841 A fix for bug #328136
5842 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5843 side is a false constant, because we still need to evaluate the right-hand
5846 * statement.cs (If): Emit two types of boolean constants (simple constant,
5847 side-effect constant).
5849 2008-02-19 Marek Safar <marek.safar@gmail.com>
5851 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5853 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5856 2008-02-18 Marek Safar <marek.safar@gmail.com>
5858 A fix for bug #361457
5859 * ecore.cs (IsApplicable): Params methods have lower priority.
5861 * support.cs: Return correct parameter modifier for params types.
5863 2008-02-18 Marek Safar <marek.safar@gmail.com>
5865 * generic.cs (TypeParameter): Cache attribute target name.
5867 * support.cs: Removed unused variable.
5869 * typemanager.cs: Removed debugging leftover.
5871 * ecore.cs: Use local type instead of a property;
5873 * class.cs (VerifyMembers): Consider also parent to test whether type member
5876 * expression.cs (FullMethodDesc): Removed.
5878 * attribute.cs (IsValidArgumentType): Made static.
5880 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5882 Cleanup to be more readable.
5883 * Makefile (GMCS_PROFILE): Remove.
5884 (COMPILER_NAME): New helper.
5886 2008-02-15 Miguel de Icaza <miguel@novell.com>
5888 * cs-tokenizer.cs: if a conditional expression happens inside a
5889 (...) this also means that we do not need to de-ambiguate between
5890 an parenthesized expression and a cast.
5894 * constant.cs (SideEffectConstant): a constant value that happens
5895 to have a side effect.
5897 Fixes the build regressions introduced by the fix for #359789
5899 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5901 * expression.cs (Conditional.Emit): when emitting the ternary
5902 operator, use local variables to generate code verifiable code.
5904 The verifier cannot infer that the type on stack before the
5905 stloc.0 is executed is of type ParentB. This happens because the
5906 stack merge algorithm uses only parent types when deciding which
5907 is the common type. This is described in Part III 1.8.1.3 of ECMA
5910 This code compiled with mcs is not verifiable under MS. The MS
5911 verifier picks the first common interface of Foo and Bar, which is
5912 wrong, but doesn't use a full join type of the 2 interfaces.
5914 CSC uses a clever hack to compile such code in a verifiable
5915 way. It stores the intermediate values in a local variable with
5920 2008-02-14 Miguel de Icaza <miguel@novell.com>
5922 * expression.cs: Do not fold BitwiseAnd operators when the left
5923 side is a false constant, because we still need to evaluate the
5928 * support.cs: Instead of throwing an InternalErrorException when
5929 the position of the stream is outside the boundary of our buffer,
5930 reset the state of the reader, and restart the reading from the
5931 beginning of the file.
5933 2008-02-14 Marek Safar <marek.safar@gmail.com>
5935 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5937 2008-02-14 Marek Safar <marek.safar@gmail.com>
5939 A fix for bug #361686
5940 * decl.cs: A protected types used inside a private class which parents
5941 derives from the protected class are accessible.
5943 2008-02-13 Marek Safar <marek.safar@gmail.com>
5945 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5946 the parameterless constructor.
5948 2008-02-13 Marek Safar <marek.safar@gmail.com>
5950 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5951 lookup methods to use standard member cache when doing member lookup.
5953 2008-02-12 Marek Safar <marek.safar@gmail.com>
5955 * driver.cs: Don't report full path for referenced module as assembly error.
5957 2008-02-12 Marek Safar <marek.safar@gmail.com>
5959 * Makefile: Fixed `qh' target to work on all machines.
5961 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5962 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5963 and HasElementType with TypeManager implementation.
5965 2008-02-08 Marek Safar <marek.safar@gmail.com>
5967 A fix for bugs #325134, #359749
5968 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5969 first binds point to non-method member expression.
5971 2008-02-08 Marek Safar <marek.safar@gmail.com>
5973 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5975 2008-02-08 Marek Safar <marek.safar@gmail.com>
5977 A fix for bugs #321394, #323028
5978 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5979 Reworked naive IsAccessibleAs implementation to handle nested types.
5981 2008-02-05 Jb Evain <jbevain@novell.com>
5983 * class.cs: use generic type comparison for parameters
5986 2008-02-05 Marek Safar <marek.safar@gmail.com>
5988 A fix for bug #325372
5989 * class.cs: Use generic type comparison when testing method signatures.
5991 2008-02-05 Marek Safar <marek.safar@gmail.com>
5993 A fix for bug #357047
5994 * ecore.cs: Applied C# 3.0 changes to better conversion.
5996 2008-02-05 Marek Safar <marek.safar@gmail.com>
5998 A fix for bug #358374
5999 * cs-parser.jay: Correctly set modifiers for all constructor types.
6001 2008-02-04 Marek Safar <marek.safar@gmail.com>
6003 A fix for bug #355251
6004 * generic.cs: Added base class constraint based type inference.
6006 2008-02-01 Marek Safar <marek.safar@gmail.com>
6008 A fix for bug #357255
6009 * decl.cs: One more missing visibility check.
6011 2008-02-01 Marek Safar <marek.safar@gmail.com>
6013 * support.cs: Fixed broken return.
6015 2008-01-25 Marek Safar <marek.safar@gmail.com>
6017 * report.cs: Correctly reset warnings count after probing.
6019 2008-01-25 Martin Baulig <martin@ximian.com>
6022 (NamespaceEntry.SymbolFileID): Make this work again after
6023 MemberName.ToString() is gone.
6025 2008-01-25 Marek Safar <marek.safar@gmail.com>
6027 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
6030 2008-01-25 Marek Safar <marek.safar@gmail.com>
6032 * generic.cs: Use full implicit conversion for type inference fixing.
6034 2008-01-24 Marek Safar <marek.safar@gmail.com>
6036 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
6037 Fixed user operator conversions.
6039 2008-01-24 Marek Safar <marek.safar@gmail.com>
6041 * generic.cs: Do nullable type to null comparison optimization during
6044 2008-01-24 Marek Safar <marek.safar@gmail.com>
6046 A fix for bug #355163
6047 * generic.cs: Enabled l-value resolve on nullable expressions.
6049 2008-01-24 Marek Safar <marek.safar@gmail.com>
6051 A fix for bug #353986
6052 * class.cs: Ingore static ctors with parameters for any further checks.
6054 2008-01-24 Marek Safar <marek.safar@gmail.com>
6056 A fix for bug #354310
6057 * namespace.cs: Removed redundant check.
6059 2008-01-24 Marek Safar <marek.safar@gmail.com>
6061 A fix for bug #354928
6062 * expression.cs: ElementInitializers can be resolved only once.
6064 2008-01-24 Marek Safar <marek.safar@gmail.com>
6066 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
6067 Condition expressions.
6069 2008-01-23 Marek Safar <marek.safar@gmail.com>
6071 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
6073 2008-01-22 Marek Safar <marek.safar@gmail.com>
6075 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
6078 * generic.cs: Implemented coalesce expression.
6080 2008-01-22 Marek Safar <marek.safar@gmail.com>
6082 A fix for bug #355145
6083 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
6084 expression tree type inference.
6086 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
6089 * expression.cs (Binary.IsUnsignedType): Fix typo.
6091 2008-01-22 Marek Safar <marek.safar@gmail.com>
6093 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
6095 2008-01-22 Marek Safar <marek.safar@gmail.com>
6097 A fix for bug #355161
6098 * ecore.cs, expression.cs: Wider range of extension method supported
6101 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
6103 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
6104 AssemblyBuilder to operate in compiler context. Fixes mcs part of
6107 2008-01-22 Marek Safar <marek.safar@gmail.com>
6109 A fix for bug #355148
6110 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
6112 2008-01-22 Miguel de Icaza <miguel@novell.com>
6114 * expression.cs (CreateExpressionTree): Add support for or and
6115 logical or, and indent following the coding conventions.
6117 * typemanager.cs (LinqExpression): renamed from
6118 ExpressionTreeManager, for a shorter name.
6120 Use TypeManager.CoreLookupType to lookup types from our core
6121 assemblies and turn those into "Type" variables.
6123 Consumers that previously used "Namespace" and "Type" from this
6124 class should instead use the TypeExpression which is a type that
6125 is fully resolved (without involving the regular C# resolution
6128 This typically looks like this:
6130 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
6131 new MemberAccess (texpr, name, type_arguments, loc)
6133 This avoids the problem in: #355178
6135 2008-01-21 Marek Safar <marek.safar@gmail.com>
6137 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
6138 feature in parser only as we do in other cases.
6140 2008-01-21 Marek Safar <marek.safar@gmail.com>
6142 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
6143 typemanager.cs: A refactoring of params arguments to reuse existing
6144 expressions (params -> array initializer) to emit params argument instead
6145 of specialized handling.
6146 It was required by expression tree implementation and it has other benefits
6147 as well, we now apply same optimization for params arguments as we do for
6150 2008-01-18 Marek Safar <marek.safar@gmail.com>
6152 A fix for bug #353526
6153 * generic.cs: A type inference of params arguments may not required any
6154 temporary array creation.
6156 2008-01-18 Marek Safar <marek.safar@gmail.com>
6158 A fix for bug #353534
6159 * generic.cs, ecore.cs, expression.cs: A method group type inference is
6160 supported for delegates only.
6162 2008-01-18 Marek Safar <marek.safar@gmail.com>
6164 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
6165 type for more than 1 candidates.
6167 2008-01-18 Marek Safar <marek.safar@gmail.com>
6169 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
6172 2008-01-16 Marek Safar <marek.safar@gmail.com>
6174 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
6175 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
6176 operator) expressions.
6178 2008-01-16 Zoltan Varga <vargaz@gmail.com>
6180 * statement.cs: Avoid declaring an IL variable for this_variable since it is
6181 not accessed from the generated IL.
6183 2008-01-14 Marek Safar <marek.safar@gmail.com>
6185 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
6186 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
6187 statement.cs: The first expression tree implementation drop, mostly
6188 infrastructure work.
6190 2008-01-14 Marek Safar <marek.safar@gmail.com>
6192 * ecore.cs (IsNestedChild): Refactored.
6194 2008-01-11 Marek Safar <marek.safar@gmail.com>
6196 * lambda.cs: Don't use a cast on unknown expression statement.
6198 2008-01-10 Geoff Norton <gnorton@novell.com>
6200 * cs-tokenizer.cs: One more token to distinguish between method and lambda
6203 2008-01-09 Marek Safar <marek.safar@gmail.com>
6205 * doc.cs: Report better /doc crash details.
6207 2008-01-09 Marek Safar <marek.safar@gmail.com>
6209 A fix for bug #352536
6210 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
6212 2008-01-08 Marek Safar <marek.safar@gmail.com>
6214 A fix for bug #352287
6215 * ecore.cs, expression.cs: Do `this' access checking in all member access
6218 2008-01-08 Marek Safar <marek.safar@gmail.com>
6220 * rootcontext.cs, driver.cs: Switch to linq mode by default.
6222 * report.cs: Reset message stacks.
6224 2008-01-08 Marek Safar <marek.safar@gmail.com>
6226 * generic.cs (InferInPhases): Correctly calculate params position.
6228 2008-01-08 Marek Safar <marek.safar@gmail.com>
6230 * cs-tokenizer.cs: No need to parse full string when parsing lambda
6233 2008-01-07 Marek Safar <marek.safar@gmail.com>
6235 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
6237 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
6239 * driver.cs: Updated --help option.
6241 2008-01-07 Marek Safar <marek.safar@gmail.com>
6243 * generic.cs (InferParamsTypeArguments): Removed.
6244 (InferInPhases): Add params type inference.
6245 (LowerBoundInference): Fixed scoring mechanism.
6247 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
6249 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
6251 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
6252 byte array for unsigned "baked" assemblies.
6254 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
6256 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
6257 array for assemblies that are not strongnamed.
6259 2008-01-04 Marek Safar <marek.safar@gmail.com>
6261 A fix for bug #351481
6262 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
6263 declaring type for nested generic types.
6265 2008-01-04 Marek Safar <marek.safar@gmail.com>
6267 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
6268 instead of ToString.
6270 2008-01-03 Marek Safar <marek.safar@gmail.com>
6272 A fix for bug #351047
6273 * expression.cs (Binary.ResolveOperator): Allow equality operators between
6274 null and structs only when equality and inequality operators are defined
6275 either as an user-operators or predefined operators.
6277 2008-01-03 Marek Safar <marek.safar@gmail.com>
6279 A fix for bug #351047
6280 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
6282 2008-01-03 Marek Safar <marek.safar@gmail.com>
6284 A fix for bug #351257
6285 * cs-tokenizer.cs: Advance line number for '\r' correctly.
6287 2008-01-03 Marek Safar <marek.safar@gmail.com>
6289 A fix for bug #351157
6290 * class.cs (Using): Fixed yet another broken cloning.
6292 (Block): Put back more sensible default value for statements.
6294 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
6296 * codegen.cs: Allow AssemblyVersion with only major version component.
6299 2007-12-29 Marek Safar <marek.safar@gmail.com>
6301 A fix for bug #324654
6302 * class.cs: Use FullName property as member name.
6304 2007-12-28 Marek Safar <marek.safar@gmail.com>
6306 A fix for bug #342117
6307 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
6308 constructor constraint.
6310 2007-12-28 Marek Safar <marek.safar@gmail.com>
6312 A fix for bug #338273
6313 * class.cs (ProbertyBase): Access modifier checks are required for overrides
6316 2007-12-28 Marek Safar <marek.safar@gmail.com>
6318 A fix for bug #350839
6319 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
6321 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6323 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6326 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6328 * statement.cs: Changed some Hashtables to use HybridDictionaries
6329 instead. It was observed that some HashTables only contained a few
6330 items in the vast majority of cases. Since HybridDictionary is
6331 more efficient on small sets (<10 elements), "known_variables"
6332 from class ExplicitBlock as well as "labels" and "constants " from
6333 class Block were changed to HybridDictionaries.
6335 Atsai results: (56216kb->54987kb)
6337 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
6340 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6342 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6345 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6347 * expression.cs: foreach loop to for loop, saved on allocation of
6348 enumerator (59333kb->59141kb)
6350 * statement.cs. Changed foreach loops to for loops, saved on
6351 allocation of enumerator (59141kb->59006kb)
6353 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
6354 when constructed with no specified capacity. This was causing a
6355 few ArrayLists to allocate more memory than they would potentially
6356 need in the Block class and MemberCache class. Setting the
6357 ArrayLists to construct with a capacity of 1 saves some
6358 memory. (56216kb->55585kb)
6360 2007-12-27 Marek Safar <marek.safar@gmail.com>
6362 A fix for bug #347189 (2nd issue)
6363 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6366 2007-12-27 Miguel de Icaza <miguel@novell.com>
6368 * report.cs: Do not use colors if stdout and stderr are not a
6371 2007-12-27 Marek Safar <marek.safar@gmail.com>
6373 A fix for bug #346998
6374 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6377 2007-12-27 Marek Safar <marek.safar@gmail.com>
6379 A fix for bug #343465
6380 * class.cs: Explicit method name for nested types uses dots only.
6382 2007-12-27 Marek Safar <marek.safar@gmail.com>
6384 A fix for bug #343707
6385 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6387 2007-12-27 Marek Safar <marek.safar@gmail.com>
6389 * ecore.cs: Report type inference errors only when arguments count matches
6392 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6394 * expression.cs, report.cs: New warning.
6396 * typemanager.cs: Catch anonymous method type too.
6398 2007-12-23 Marek Safar <marek.safar@gmail.com>
6400 A fix for bug #346379
6401 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6403 2007-12-23 Marek Safar <marek.safar@gmail.com>
6405 A fix for bug #347359
6406 * expression.cs (Invocation): Don't resolve already resolved expression.
6408 2007-12-23 Marek Safar <marek.safar@gmail.com>
6410 A fix for bug #347189
6411 * class.cs (FixedField): Use non-dependent code only in the define phase.
6413 2007-12-23 Marek Safar <marek.safar@gmail.com>
6415 A fix for bug #348076
6416 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6418 2007-12-22 Marek Safar <marek.safar@gmail.com>
6420 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6421 discovered extension methods.
6423 2007-12-22 Marek Safar <marek.safar@gmail.com>
6425 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6428 2007-12-21 Miguel de Icaza <miguel@novell.com>
6430 * report.cs (ErrorMessage): Add support for using colors on
6431 terminals that support it.
6433 2007-12-21 Marek Safar <marek.safar@gmail.com>
6435 * ecore.cs: Use information about expanded params for error reporting.
6437 2007-12-21 Marek Safar <marek.safar@gmail.com>
6439 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6440 and logic for params overloads.
6442 2007-12-15 Miguel de Icaza <miguel@novell.com>
6444 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6445 as this is also created from the parser. Fixes #349034
6447 2007-12-12 Miguel de Icaza <miguel@novell.com>
6449 * statement.cs (Throw.CloneTo): it is valid to have empty
6450 expressions for throw.
6452 2007-12-03 Marek Safar <marek.safar@gmail.com>
6454 * cs-parser.jay: Set delegate constraint parsing region correctly.
6456 2007-12-03 Marek Safar <marek.safar@gmail.com>
6458 A fix for bug #345467
6459 * typemanager.cs (IsEqual): Compare generic parameters position only.
6461 2007-11-28 Marek Safar <marek.safar@gmail.com>
6463 * expression.cs (BaseAccess): Type arguments can be null.
6465 2007-11-27 Raja R Harinath <harinath@gmail.com>
6467 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6468 consistent even when an error has occured.
6469 (Switch.Resolve): Likewise.
6471 2007-11-22 Marek Safar <marek.safar@gmail.com>
6473 A fix for bug #334505
6474 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6477 2007-11-22 Marek Safar <marek.safar@gmail.com>
6479 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6480 refactorings required to resolve extension methods correctly when mixing
6481 generics and non-generics members.
6483 2007-11-20 Marek Safar <marek.safar@gmail.com>
6485 A fix for bug #342584
6486 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6489 2007-11-19 Marek Safar <marek.safar@gmail.com>
6491 A fix for bug #342512
6492 * delegate.cs: Use delegate argument expression when is available. Don't
6493 emit virtual call when class is sealed.
6495 2007-11-16 Marek Safar <marek.safar@gmail.com>
6497 A fix for bug #325423
6498 * assign.cs (FieldInitializer): Use resolved expression for emit.
6500 * class.cs: Print less confusing error message.
6502 2007-11-16 Marek Safar <marek.safar@gmail.com>
6504 * cs-tokenizer.cs: Removed GMCS ifdefs.
6506 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6509 * cs-parser.jay: Disabled nullable check.
6511 * generic-mcs: Copied more generic stuff.
6513 2007-11-16 Marek Safar <marek.safar@gmail.com>
6515 * gcs-parser.jay: Merged to cs-parser.jay.
6517 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6518 * *.csproj, *.sources: Updated to use only jay parser file.
6520 2007-11-16 Marek Safar <marek.safar@gmail.com>
6522 * gcs-parser.jay: Added nullable and default expression feature checks.
6524 2007-11-16 Marek Safar <marek.safar@gmail.com>
6526 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6527 it fixes many TODOs and hidden bugs.
6529 * expression: Removed duplicate error check.
6531 2007-11-15 Marek Safar <marek.safar@gmail.com>
6533 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6534 implicitly type local variable only when it is used in a declaration.
6536 2007-11-15 Marek Safar <marek.safar@gmail.com>
6538 * attribute.cs: Use CS0612 for empty strings.
6540 2007-11-14 Marek Safar <marek.safar@gmail.com>
6542 * lambda.cs, statement.cs: Contextual return may act as a statement.
6544 2007-11-14 Marek Safar <marek.safar@gmail.com>
6546 A fix for a regression cause by #324222
6547 * class.cs: Don't report unused even when it implements an interface.
6549 2007-11-13 Marek Safar <marek.safar@gmail.com>
6551 A fix for bug #341205
6552 * ecore.cs, expression.cs: Method group expression cannot do static
6553 method access with an instance reference check before overloading takes
6556 2007-11-13 Marek Safar <marek.safar@gmail.com>
6558 A fix for bug #325359
6559 * class.cs: Use predictable name for automatically generated property.
6561 2007-11-12 Marek Safar <marek.safar@gmail.com>
6563 A fix for bug #324996
6564 * expression.cs (Is): Handle case where D is nullable and T is not
6567 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6569 2007-11-12 Marek Safar <marek.safar@gmail.com>
6571 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6572 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6573 Flush small error reporting changes.
6575 2007-11-09 Marek Safar <marek.safar@gmail.com>
6577 A fix for bug #324996
6578 * expression.cs: Rewrote Is expression implementation to work with
6579 generics, nullable types, anonymous method. A const result expression
6580 uses existing infrastructure instead of custom not fully-featured one.
6582 2007-11-08 Marek Safar <marek.safar@gmail.com>
6584 A fix for bug #340202
6585 * class.cs: Consider generics for volatile field.
6587 2007-11-08 Marek Safar <marek.safar@gmail.com>
6589 A fix for bug #335594
6590 * expression.cs: Use conversion rules when handling string addition.
6592 2007-11-07 Marek Safar <marek.safar@gmail.com>
6594 A fix for bug #336651
6595 * expression.cs: Fixed a crash when probing is on.
6597 2007-11-07 Marek Safar <marek.safar@gmail.com>
6599 A fix for bug #324242
6600 * covert.cs: Added a conversion from any nullable-type with an
6601 underlying enum-type to the type System.Enum.
6603 2007-11-07 Marek Safar <marek.safar@gmail.com>
6605 A fix for bug #324222
6606 * class.cs: Report all non-used event fields.
6608 2007-11-07 Marek Safar <marek.safar@gmail.com>
6610 A fix for bug #325161
6611 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6612 qualifier for generic types.
6614 2007-11-07 Marek Safar <marek.safar@gmail.com>
6616 A fix for bug #322971
6617 * expression.cs, ecore.cs: Added intermediate result value check for
6620 2007-11-07 Marek Safar <marek.safar@gmail.com>
6622 A fix for bug #324754
6623 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6624 when it was requested.
6626 2007-11-07 Marek Safar <marek.safar@gmail.com>
6628 A fix for bug #325101
6629 * expression.cs: Do type not value comparison for `is' expression.
6631 2007-11-07 Marek Safar <marek.safar@gmail.com>
6633 A fix for bug #320236
6634 * convert.cs: Don't apply user conversion on underlying target type.
6636 2007-11-06 Marek Safar <marek.safar@gmail.com>
6638 * expression.cs: Don't use unresolved expression for error reporting.
6640 2007-11-06 Marek Safar <marek.safar@gmail.com>
6642 A fix for bugs #337712, #324490
6643 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6644 overloading resolution too.
6646 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6647 the process consistent and more robust.
6649 * expression.cs, linq.cs, report.cs: Update.
6651 2007-11-02 Marek Safar <marek.safar@gmail.com>
6653 A fix for bug #332909
6654 * attribute.cs: Resolve attributes in correct context using error
6657 * rootcontext.cs: Define Obsolete attribute members as core members.
6659 2007-11-02 Marek Safar <marek.safar@gmail.com>
6661 * statement.cs: Removed unused methods.
6663 2007-10-31 Wade Berrier <wberrier@novell.com>
6665 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6666 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6669 2007-10-31 Marek Safar <marek.safar@gmail.com>
6671 A fix for bug #338102
6672 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6673 methods registered as non-generics.
6675 2007-10-31 Marek Safar <marek.safar@gmail.com>
6677 A fix for bugs #337712, #324490
6678 * delegate.cs: Delegate covariance and contravariance is not allowed for
6681 2007-10-31 Marek Safar <marek.safar@gmail.com>
6683 A fix for bug #337719
6684 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6687 2007-10-30 Marek Safar <marek.safar@gmail.com>
6689 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6691 2007-10-29 Marek Safar <marek.safar@gmail.com>
6693 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6696 2007-10-29 Raja R Harinath <rharinath@novell.com>
6698 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6700 2007-10-29 Marek Safar <marek.safar@gmail.com>
6702 A fix for bug #334652
6703 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6704 extension methods when we have not found the best candidate in normal
6707 2007-10-27 Marek Safar <marek.safar@gmail.com>
6709 * AssemblyInfo.cs: Keep up-to-date.
6711 2007-10-27 Marek Safar <marek.safar@gmail.com>
6713 * Makefile: Fixed generics compiler name.
6715 2007-10-27 Marek Safar <marek.safar@gmail.com>
6717 * lambda.test: removed, lambda parsing is done differently.
6719 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6721 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6723 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6725 2007-10-27 Marek Safar <marek.safar@gmail.com>
6727 * Makefile, *.sources : All C# compilers are in mcs folder.
6729 * *.cs: Use existing 2_1 define for smcs.
6731 2007-10-26 Marek Safar <marek.safar@gmail.com>
6733 A fix for bug #335847
6734 * assign.cs, expression.cs: Couple of changes to avoid creating a
6735 temporary variable for each object initializer assignment statement. It
6736 simplifies struct initialization too, otherwise two temporary variables
6738 Implemented optimization of redundant default element initializers.
6740 2007-10-25 Marek Safar <marek.safar@gmail.com>
6742 A fix for bug #336766
6743 * expression.cs (Class.CheckBase): Use generic name when method is
6746 2007-10-25 Marek Safar <marek.safar@gmail.com>
6748 A fix for bug #334737
6749 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6750 variable and not variable argument for prepared copies.
6752 2007-10-24 Marek Safar <marek.safar@gmail.com>
6754 A fix for bug #325110
6755 * class.cs, expression.cs, attribute.cs: Use open generic method when
6756 checking conditional attribute.
6758 2007-10-24 Marek Safar <marek.safar@gmail.com>
6760 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6761 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6762 FeatureIsNotAvailable.
6764 2007-10-24 Marek Safar <marek.safar@gmail.com>
6766 ** C# 3.0 Partial methods
6768 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6769 methods support. Because of member cache issue with generics only
6770 non-generics partial methods are fully supported.
6772 2007-10-23 Marek Safar <marek.safar@gmail.com>
6774 * class.cs, decl.cs: Rewrote member overloads check to cope with
6775 generics and to use member cache for member checking. It also improves
6776 performance and fixes remaining overloads issues.
6778 2007-10-20 Marek Safar <marek.safar@gmail.com>
6780 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6781 roottypes.cs, typemanager.cs:
6783 A member cache creation logic changed to add members immediately and
6784 not rely on fallback. The member cache is now only prefered way
6785 how to access and find type declaration members. It saves 5 MB of memory
6786 during MWF compilation and makes code ready for more optimizations and
6787 clean-ups, it's also a pre-requirement for partial methods.
6789 2007-10-18 Raja R Harinath <harinath@gmail.com>
6791 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6792 handling for generic parameters.
6794 2007-10-15 Marek Safar <marek.safar@gmail.com>
6796 * class.cs (FixedField): Removed redundant volatile check.
6798 2007-10-15 Marek Safar <marek.safar@gmail.com>
6800 * class.cs, decl.cs: Fixed overload members verification to do only one
6801 check per possible collision.
6803 2007-10-13 Marek Safar <marek.safar@gmail.com>
6805 A fix for bug #325478
6806 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6807 and create only one disposable flags container.
6809 2007-10-12 Marek Safar <marek.safar@gmail.com>
6811 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6812 * statement.cs (Fixed): Fixed variables cloning.
6814 2007-10-12 Marek Safar <marek.safar@gmail.com>
6816 A fix for bug #333342
6817 * class.cs (EventField): Don't mark value type event as synchronized.
6819 2007-10-12 Marek Safar <marek.safar@gmail.com>
6821 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6822 inference to identify best candidate method correctly.
6823 (ProperyExpr): A range variable is read only and cannot be modified.
6825 2007-10-11 Marek Safar <marek.safar@gmail.com>
6827 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6828 logic to identify best candidate method correctly.
6830 2007-10-11 Marek Safar <marek.safar@gmail.com>
6832 * location.cs (Equals, GetHashCode): Removed.
6834 2007-10-11 Marek Safar <marek.safar@gmail.com>
6836 * report.cs: Implemented message recorder. It is used mainly for lambda
6837 expressions to capture otherwise swallowed error messages.
6839 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6841 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6843 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6845 * expression.cs (MemberAccess): Always report lookup failure.
6847 * location.cs: Implemented Equals, GetHashCode.
6849 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6851 2007-10-10 Jb Evain <jbevain@novell.com>
6853 * codegen.cs: re-enable assembly version check.
6855 2007-10-09 Marek Safar <marek.safar@gmail.com>
6857 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6860 * namespace.cs (UsingAlias): Do correct version check.
6862 2007-10-08 Marek Safar <marek.safar@gmail.com>
6864 * expresison.cs, ecore.cs: Issue extension method error message when
6867 * rootcontext.cs: Added ISO_2 compiler mode option.
6869 2007-10-08 Marek Safar <marek.safar@gmail.com>
6871 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6874 2007-10-08 Marek Safar <marek.safar@gmail.com>
6876 * attribute.cs (GetString, GetBoolean): Work with both literal and
6879 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6880 Moved method overload specific methods to MethodGroupExpr.
6882 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6883 it should be less memory consuming.
6885 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6887 * codegen.cs: remove the assembly version check until the buildbot is
6890 2007-10-07 Jb Evain <jbevain@novell.com>
6892 * attribute.cs (Attribute.GetString): if the value
6893 expression is a StringConstant, return its string value.
6895 2007-10-07 Jb Evain <jbevain@novell.com>
6897 * typemanager.cs: add `assembly_version_attribute_type`.
6898 * codegen.cs: on attribute emission, check that the
6899 AssemblyVersionAttribute doesn't overflow.
6901 2007-10-05 Marek Safar <marek.safar@gmail.com>
6903 A fix for bug #324677
6904 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6905 parent container of a scope container with currently resolved one.
6907 2007-10-05 Marek Safar <marek.safar@gmail.com>
6909 A fix for bug #325534
6910 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6913 2007-10-05 Marek Safar <marek.safar@gmail.com>
6915 A fix for bug #327504
6916 * class.cs (Operator.Define): Refactored implicit and explicit user
6917 operator conversion rules.
6919 2007-10-05 Marek Safar <marek.safar@gmail.com>
6921 A fix for bug #327520
6922 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6924 2007-10-04 Marek Safar <marek.safar@gmail.com>
6926 A fix for bug #328022
6927 * class.cs (MethodData.Define): Use correct method to check whether
6928 a method implementents an accessor.
6930 2007-10-04 Marek Safar <marek.safar@gmail.com>
6932 A fix for bug #330069
6933 * statement.cs (Fixed.Resolve): Read the first array element only when
6934 an array is instantiated.
6936 2007-10-04 Marek Safar <marek.safar@gmail.com>
6938 * expression.cs, assign.cs, generics.cs: Print correct operator when
6939 compound assignment is used.
6941 2007-10-04 Marek Safar <marek.safar@gmail.com>
6943 A fix for bug #325841
6944 * expression.cs (ArrayAccess): Use full argument cloning only for
6945 string compound concatenation.
6947 2007-10-03 Marek Safar <marek.safar@gmail.com>
6949 A fix for bug #328774
6950 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6952 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6955 2007-10-03 Raja R Harinath <rharinath@novell.com>
6958 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6959 Event accessibility checks here. Remove some bogus code that
6960 accidently made GenericMethods work.
6961 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6963 2007-09-25 Marek Safar <marek.safar@gmail.com>
6965 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6967 * statement.cs (Block): Refactored AddVariable to allow error handling
6970 * generic.cs: New stub.
6972 2007-09-23 Marek Safar <marek.safar@gmail.com>
6974 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6977 2007-09-17 Marek Safar <marek.safar@gmail.com>
6979 * class.cs: Use partial container to record whether any partial part
6980 contains static field initializer and therefore default contructor has
6983 2007-09-14 Marek Safar <marek.safar@gmail.com>
6985 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6986 mono-list when only one of two partial parts has defined accessibility
6989 2007-09-14 Marek Safar <marek.safar@gmail.com>
6991 A fix for bug #82845
6993 * class.cs (TypeContainer): Set correct resolve context for all field
6996 2007-09-13 Marek Safar <marek.safar@gmail.com>
6998 * assign.cs: Fixed a crash when field is resolved twice with an error.
7000 * codegen.cs: Changed InFieldInitializer to be flag.
7002 * anonymous.cs, ecore.cs, expression.cs: Update after
7003 IsInFieldInitializer rename.
7005 * const.cs: Removed unused parameter.
7007 * class.cs: Changed the way how we resolve and emit field initializers.
7008 The field initilizers have to have access to contructor block to emit
7009 compiler generated code.
7011 2007-09-13 Marek Safar <marek.safar@gmail.com>
7013 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
7014 generics use TypeContainer instead.
7016 2007-09-12 Marek Safar <marek.safar@gmail.com>
7018 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
7020 * lambda.cs (ResolveParameters): Use more powerful
7021 InflateGenericArgument.
7023 * parameters.cs: Better exception message.
7025 2007-09-10 Marek Safar <marek.safar@gmail.com>
7027 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
7028 correct expression block type.
7030 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
7032 * expression.cs (Invocation): Extracted method group resolve to
7035 2007-09-07 Marek Safar <marek.safar@gmail.com>
7037 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
7038 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
7040 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
7041 generic extension methods.
7043 2007-09-06 Marek Safar <marek.safar@gmail.com>
7045 A fix for bug #82676 (Do I get it right now?)
7046 * convert.cs (Binary.ResolveOperator): An interface is converted to the
7047 object before a standard conversion is applied.
7049 2007-09-06 Marek Safar <marek.safar@gmail.com>
7051 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
7054 2007-09-05 Marek Safar <marek.safar@gmail.com>
7056 A fix for bug #82676
7057 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
7058 non-generic interface types.
7060 2007-09-05 Marek Safar <marek.safar@gmail.com>
7062 A fix for bug #82690
7063 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
7065 2007-09-05 Marek Safar <marek.safar@gmail.com>
7067 A fix for bug #82571
7068 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
7069 modifier for container based methods.
7071 2007-09-05 Marek Safar <marek.safar@gmail.com>
7073 A fix for bug #82676
7074 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
7075 any interface-type T means to any of interface type T.
7077 2007-09-04 Marek Safar <marek.safar@gmail.com>
7079 * namespace.cs: We have 2 versions of System.Core assembly.
7081 2007-09-04 Marek Safar <marek.safar@gmail.com>
7083 A fix for bug #82652
7084 * class.cs (Class.GetClassBases): Compare types and not expressions.
7086 2007-09-04 Marek Safar <marek.safar@gmail.com>
7088 A fix for bug #82620
7089 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
7090 actually never worked before.
7091 (IndexerAccess): Emit prepared arguments before they are modified.
7093 2007-09-04 Marek Safar <marek.safar@gmail.com>
7095 A fix for bug #82563
7096 * assign.cs: Revert wrong fix.
7098 * expression.cs (VariableReference.EmitAssign): Handle ref reference
7100 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
7101 Instead of ldelema/stdind we have to use temporary variables to handle
7102 cases like String.Concat (params string[]).
7104 2007-08-31 Marek Safar <marek.safar@gmail.com>
7106 * class.cs: EmitAttributes to Emit rename.
7108 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
7110 (MemberCore.HasClsCompliantAttribute): Don't depend on
7111 GetClsCompliantAttributeValue execution.
7113 2007-08-31 Marek Safar <marek.safar@gmail.com>
7115 * anonymous.cs: Use shorter type prefix.
7117 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
7120 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
7121 variables when probing is on.
7123 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
7124 unresolved variables.
7125 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
7126 handle transparent identifiers.
7128 2007-08-26 Marek Safar <marek.safar@gmail.com>
7130 * attribute.cs (IsClsCompliant): Add nullable types test.
7132 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
7134 * doc.cs : catch other types of exception than XmlException to
7135 report CS1570. Fixed bug #82565.
7137 2007-08-23 Marek Safar <marek.safar@gmail.com>
7139 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
7140 The number of delegate parameters has to match.
7141 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
7144 2007-08-21 Marek Safar <marek.safar@gmail.com>
7146 * anonymous.cs (AnonymousMethod): Generate private anonymous method
7147 to fix problem with private arguments.
7149 2007-08-20 Marek Safar <marek.safar@gmail.com>
7151 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
7153 * decl.cs (MemberName): Ignore generic type with no generic arguments.
7155 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
7156 empty. Add cloning suport.
7158 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
7160 2007-08-20 Marek Safar <marek.safar@gmail.com>
7162 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
7163 to create EmptyCast. It handles EmptyConstantCast specialization for
7166 2007-08-18 Marek Safar <marek.safar@gmail.com>
7168 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
7169 (EmitArrayArgument): One routine for array arguments.
7170 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
7172 2007-08-17 Marek Safar <marek.safar@gmail.com>
7174 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
7176 2007-08-17 Marek Safar <marek.safar@gmail.com>
7178 * anonymous.cs: MemberLookupFinal update.
7180 * class.cs (ConstructorInitializer): Is expression based.
7182 * delegate.cs: MethodGroupExpr update.
7184 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
7186 (Error_MemberLookupFailed): Customizable error override.
7187 (MethodGroupExpr): Keep queried type for later usage.
7188 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
7191 * expression.cs: Error_MemberLookupFailed refactoring.
7192 (New.DoResolve): Resolve as much as possible.
7193 (ElementInitializer.Error_MemberLookupFailed): Object initializer
7194 customization for invalid member types.
7196 * statement.cs: MethodGroupExpr update.
7198 2007-08-16 Marek Safar <marek.safar@gmail.com>
7200 * modifier.cs (Check): Check all modifiers and not only accessibility
7203 2007-08-16 Marek Safar <marek.safar@gmail.com>
7205 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
7206 type and not an expression.
7208 2007-08-16 Marek Safar <marek.safar@gmail.com>
7210 * statement.cs (Catch.Clone): Type and variable can be null.
7212 2007-08-16 Marek Safar <marek.safar@gmail.com>
7214 A fix for bug #81979
7215 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
7216 I am really not sure whether this is the best fix.
7218 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
7221 2007-08-14 Marek Safar <marek.safar@gmail.com>
7223 ** C# 3.0 Object and collection initializers (major re-write)
7225 * assign.cs (DoResolve): Initializers are not assign related.
7227 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
7228 used during collection or object initialization.
7230 * expression.cs (Error_InvalidArguments): Add initializers specific
7231 messages. More will come later because it requires some general
7233 (New.DoResolve): Better error handling for unsafe types.
7234 (EmptyExpressionStatement): New class.
7235 (ElementInitializer): An object initializer expression.
7236 (CollectionElementInitializer): A collection initializer expression.
7237 (CollectionOrObjectInitializers): A block of object or collection
7239 (NewInitialize): New expression with element/object initializers.
7241 * statement.cs: Reverted object/collection initializer hacks.
7243 * typemanager.cs (CSharpName): Filter __arglist type.
7245 2007-08-09 Marek Safar <marek.safar@gmail.com>
7247 ** C# 3.0 Anonymous Types (update to the latest standard)
7249 * expression.cs (Binary.ResolveOperator): Threat all null based types
7251 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
7252 (AnonymousTypeParameter): Updated.
7254 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
7255 (AnonymousTypeClass): New anonymous type container.
7257 * class.cs (AddField): Return operation result.
7259 * generic.cs: Another empty TypeArguments overload.
7261 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
7262 are stored at top of normal hierarchy.
7264 * typemanager.cs (CSharpName): Filter anonymous types.
7266 2007-08-09 Marek Safar <marek.safar@gmail.com>
7268 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
7269 as single Concat call. How could we miss that :-(
7271 2007-08-08 Marek Safar <marek.safar@gmail.com>
7273 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
7275 2007-08-07 Miguel de Icaza <miguel@novell.com>
7277 * expression.cs: Fix the previous commit, the creation of the
7278 arguments array list needs also to be conditional on the arguments
7281 * class.cs: Add a little bit of help to help narrow down problems.
7283 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
7284 not try to copy in that case.
7286 * driver.cs: When building SMCS, include a new different set of
7287 default assemblies here. Do this here so we can control whether
7288 to include the default assemblies with /noconfig.
7290 2007-08-03 Marek Safar <marek.safar@gmail.com>
7292 A fix for bug #81979
7293 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
7296 2007-08-03 Marek Safar <marek.safar@gmail.com>
7298 A fix for bug #82300
7300 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
7301 we are in probing scope.
7303 2007-08-03 Marek Safar <marek.safar@gmail.com>
7305 A fix for bug #82301
7307 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
7308 (Statement.CloneTo): Clone and not map children blocks.
7310 2007-08-03 Marek Safar <marek.safar@gmail.com>
7312 A fix for bug #82299
7314 * expression.cs (LocalVariableReference.CloneTo): Remap local info
7317 * statement.cs (Statement.CloneTo): Clone variables before statements
7318 to allow remaping of local variables.
7320 2007-08-03 Marek Safar <marek.safar@gmail.com>
7322 A fix for bug #82296
7325 * report.cs: Log crash details for future clone problems.
7327 * statement.cs (Return.Clone): Don't clone non-existent expression.
7329 2007-08-03 Raja R Harinath <harinath@gmail.com>
7331 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
7332 (Class.AddBasesForPart): Move CS0537 check here from ...
7333 * cs-parser.jay (class_declaration): ... here. Move calling of
7334 'AddBasesForPart' to ...
7335 (class_bases): ... here.
7336 (struct_declaration, interface_declaration): Update to changes.
7338 2007-08-02 Marek Safar <marek.safar@gmail.com>
7340 A fix for bug #81923
7342 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
7343 conversion is allowed.
7345 2007-08-02 Marek Safar <marek.safar@gmail.com>
7347 A fix for bug #81564
7349 * ecore.cs (EventExpr): Add IsBase handling.
7351 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
7354 2007-08-02 Raja R Harinath <harinath@gmail.com>
7356 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
7357 * cs-parser.jay: Some whitespace cleanups.
7358 (current_delegate): New.
7360 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
7361 a dummy code block, and use 'type_name' instead of 'member_name'.
7362 (interface_declaration, class_declaration): Likewise.
7363 (delegate_declaration): Likewise. Rearrange slightly and use
7365 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7366 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7368 2007-08-02 Marek Safar <marek.safar@gmail.com>
7370 A fix for bug #82039
7372 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7375 * typemanager.cs (CSharpName): Split to string overload.
7377 2007-08-02 Marek Safar <marek.safar@gmail.com>
7380 * report.cs: Updated warning CS0472.
7382 2007-08-01 Marek Safar <marek.safar@gmail.com>
7384 A fix for bug #82181
7386 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7388 2007-08-01 Marek Safar <marek.safar@gmail.com>
7390 A fix for bug #82277
7391 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7393 2007-08-01 Marek Safar <marek.safar@gmail.com>
7395 ** C# 3.0 Type Inference (major bits are working)
7397 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7398 (.ImplicitStandardConversionExists): Uses compatible.
7399 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7400 (.InferReturnType): New method.
7401 (.Compatible): Refactored.
7402 (.ResolveParameters): Uses factory to create resolved parameters.
7403 (.CompatibleMethod): Add probing mode support.
7404 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7405 clearly distinguish between 2 different operations.
7406 (LambdaMethod): Moved to lambda.cs.
7407 (AnonymousMethod): Removed unused fields and methods.
7408 (AnonymousDelegate): Simplified.
7410 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7412 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7414 * delegate.cs (Delegate): New mehods to reduce code duplication.
7415 (.GetConstructor): New method.
7416 (.GetInvokeMethod): New method.
7417 (DelegateCreation): Updated.
7419 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7421 (OverloadResolve): Made probing little bit faster.
7423 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7426 * generic.cs (TypeInferenceContext): Dummy implementation.
7428 * iterators.cs: Updated after Resolve/Define rename.
7430 * lambda.cs (LambdaExpression)
7431 (.ResolveParameters): Handles both type of arguments and type inference too.
7433 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7434 (InflateTypes): Updated.
7436 * support.cs (InflateTypes): Changed signature and updated.
7438 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7439 (MemberLookup_FindMembers): More MS tricks.
7440 (GetParameterData): Ditto.
7441 (GetDelegateParameters): Uses quick path for dynamic types.
7443 2007-08-01 Marek Safar <marek.safar@gmail.com>
7445 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7448 2007-07-31 Marek Safar <marek.safar@gmail.com>
7450 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7453 2007-07-26 Jb Evain <jbevain@novell.com>
7455 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7456 which takes a boolean 'report_errors', similar to the GetMethod.
7457 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7458 in .net 2.1, do not report errors here.
7460 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7461 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7462 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7465 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7466 of the type InternalsVisibleToAttribute before the first call
7467 to CoreLookupType which is allowed to fail (third boolean parameter
7468 to true). Because, during the resolution for a type that is not
7469 immediately found, we try to check if the type is not defined in
7470 a friend assembly, and to do so, we need the
7471 InternalVisibleToAttribute.
7473 2007-07-23 Miguel de Icaza <miguel@novell.com>
7475 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7476 feature that allows structs to be compared against null and inline
7477 the result as true or false.
7479 Notice that the same code is not permitted inside a generic block
7480 of code that would do:
7482 class Foo<T> where T : struct {
7489 It is only allowed if the type of T is not bound (no where
7490 clause). In my opinion, this CSC 2 behavior is broken but people
7491 seem to be using it (IronRuby does, a few bug reports on bugzilla
7492 have it and some people have complained about it).
7494 All of the users that depend on this behavior have code that is
7497 * report.cs (Warning, Error): make these take object arguments,
7498 not strings, as that allows us to take advantage of Format.
7500 2007-07-20 William Holmes <billholmes54@gmail.com>
7502 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7503 Left member variable for the Count.
7504 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7505 MemberName.CountTypeArguments to avoid a NRE.
7507 This code is contributed under the MIT X11 license
7509 2007-07-18 Marek Safar <marek.safar@gmail.com>
7511 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7513 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7515 * doc.cs : generic method arguments are written as ``x while generic
7516 type arguments are `x. Combined with the previous change, fixed bug
7519 2007-07-18 Raja R Harinath <rharinath@novell.com>
7522 * expression.cs (Binary.ResolveOperator): When converting
7523 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7525 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7527 * doc.cs : when T: or whatever x: is specified, it does not really
7528 check the doc comment's syntax correctness. Fixed bug #82006.
7530 2007-07-18 Marek Safar <marek.safar@gmail.com>
7532 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7533 LambdaExpression better.
7535 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7537 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7539 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7540 as it can be generated.
7542 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7545 * lambda.cs (LambdaExpression): Refactored to share same code with
7546 AnonymousMethodExpression.
7548 2007-07-17 Marek Safar <marek.safar@gmail.com>
7550 * anonymous.cs (MakeName): Include host name for easier debugging.
7551 (LambdaMethod): New class for lambda spcecific stuff.
7553 * attribute.cs: Set EmitContext return type.
7555 * class.cs: Set EmitContext return type.
7557 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7558 with null/void meaning.
7560 * iterators.cs (ContainerType): Implemented.
7562 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7564 * statement.cs (Return): Updated to lambda expressions.
7565 (Block.CloneTo): Parent can be null.
7567 2007-07-13 Marek Safar <marek.safar@gmail.com>
7569 A fix for bug #81917
7570 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7572 * class.cs (FixedField): Check whether field is in unsafe scope.
7574 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7575 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7577 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7580 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7582 2007-07-13 Marek Safar <marek.safar@gmail.com>
7584 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7585 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7588 2007-07-13 Marek Safar <marek.safar@gmail.com>
7590 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7592 2007-07-13 Marek Safar <marek.safar@gmail.com>
7594 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7595 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7597 * codegen.cs(EmitContext): Add ProbingMode flag.
7599 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7601 * driver.cs: For now set both warning values.
7603 * ecore.cs (SimpleName): Name is readonly.
7604 (MethodGroup.OverloadResolve): One quick path for probing.
7606 * expression.cs (Unary): Set Oper r/o.
7607 (Binary): Set Oper r/o.
7608 (ParameterReference): Set few instance variables as r/o.
7609 (ParameterReference.DoResolveBase): Don't capture aruments when
7611 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7612 (Arglist): arguments are private.
7613 (SizeOf): type is private and r/o.
7614 (MemberAccess): arguments are private.
7616 * report.cs: Enhanced reporting on/off capabilities.
7618 * lambda.cs: Uses ec.IsInProbingMode.
7619 (ContextualReturn): Derives from return.
7621 * rootcontext.cs: For now set both warning values.
7623 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7625 (Return.Resolve): Don't die immediately.
7626 (Block.Resolve): Speed-up probing.
7627 (Block.CloneTo): Clone only child blocks.
7629 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7631 * iterators.cs: reverted Miguel's latest change (r81925) as it
7632 breaks the build in System.
7634 2007-07-13 Miguel de Icaza <miguel@novell.com>
7636 * iterators.cs (Yield.CheckContext): Check for the iterator type
7637 also here as we can call into Yield even in codepaths that are not
7639 (MethodOrOperator is the only path that was checked).
7641 In addition to the standard check, use a more specific check for
7642 constructors to report a more verbose error.
7644 2007-07-12 Miguel de Icaza <miguel@novell.com>
7646 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7647 report the warning and continue
7649 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7650 values on the stack on the call to Emit. Use EmitStatement if
7651 possible, or using Emit + Pop if not possible. Fixes #82064
7653 2007-07-12 Raja R Harinath <rharinath@novell.com>
7655 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7656 avoid try...finally in some cases.
7658 2007-07-10 Marek Safar <marek.safar@gmail.com>
7660 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7662 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7663 instead of method. Re-use standard error handling.
7664 (ConstructorInitializer.Emit): Simplified.
7666 * delegate.cs: Updated after Invocation.EmitCall change.
7668 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7669 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7670 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7671 method and don't permanently changing input arguments.
7672 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7673 is resolved it has one of the candidates is the best one which is later
7674 used to emit. Removed a few unused method.
7675 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7677 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7678 (Binary.ResolveOperator): Ditto.
7679 (ConditionalLogicalOperator.DoResolve): Ditto.
7680 (Invocation): Uses method group.
7681 (Invocation.DoResolve): Simplified.
7682 (Invocation.EmitCall): Removed useless is_static.
7683 (Invocation.Emit): Delegate to method group.
7684 (Invocation.EmitStatement): Simplified.
7685 (New): Uses method group.
7686 (MemberAccess.DoResolve): Don't destroy original expression.
7688 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7690 2007-07-04 Marek Safar <marek.safar@gmail.com>
7692 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7695 * lambda.cs: Add custom error message type.
7697 2007-07-03 Marek Safar <marek.safar@gmail.com>
7699 * lambda.cs: Simplified little bit.
7701 * parameter.cs: Introduced ImplicitLambdaParameter.
7702 (Parameters.CreateFullyResolved): New factory instead of ctor.
7706 * delegate.cs: Updated parameter creation.
7708 2007-07-03 Marek Safar <marek.safar@gmail.com>
7710 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7713 * generic.cs: Synchronized with gmcs.
7715 2007-07-03 Marek Safar <marek.safar@gmail.com>
7717 * class.cs (Indexer): Check return type as soon as possible.
7719 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7722 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7724 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7726 * parameter.cs (Parameter): Use expression type when it is available.
7728 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7729 method modifier for the first parameter only.
7731 2007-06-24 Marek Safar <marek.safar@gmail.com>
7733 A fix for bug #81938
7734 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7736 * constant.cs: Tide up an exception message.
7738 2007-06-22 Marek Safar <marek.safar@gmail.com>
7740 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7741 an uninitialized variable is used.
7743 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7745 2007-06-22 Marek Safar <marek.safar@gmail.com>
7747 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7748 not found error handling.
7750 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7752 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7753 (ArrayCreation.DoResolve): Simplified.
7754 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7755 its own resolve process.
7756 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7758 2007-06-20 Marek Safar <marek.safar@gmail.com>
7760 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7763 2007-06-20 Marek Safar <marek.safar@gmail.com>
7765 * cs-tokenizer.cs: Removed var related stuff.
7767 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7768 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7769 a type and a keyword at same time.
7771 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7774 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7775 implicitly typed arrays, more changes will follow.
7777 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7779 2007-06-19 Marek Safar <marek.safar@gmail.com>
7781 * ecore.cs (VarExpr): Removed Handled field.
7783 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7784 build-in assign functionality.
7785 (ForEach.Resolve): Removed all implicitly typed local variable code and
7787 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7788 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7790 2007-06-18 Marek Safar <marek.safar@gmail.com>
7792 * assign.cs: Removed implicitly typed local variable check.
7794 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7795 referencing implicitly typed local variable.
7796 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7799 * statement.cs (Fixed): Removed unsupported implicitly typed local
7802 2007-06-15 Marek Safar <marek.safar@gmail.com>
7804 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7806 2007-06-14 Marek Safar <marek.safar@gmail.com>
7808 A fix for bugs #81855 and #76274
7809 * attribute.cs (AttachTo): Always set owner for global attributes to
7812 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7815 * cs-parser.jay: Assembly and module attributes must precede all other
7816 elements except using clauses and extern alias declarations.
7818 2007-06-13 Marek Safar <marek.safar@gmail.com>
7820 A fix for bug #81748
7822 * expression.cs: More checks for non ISO-1 features.
7824 2007-06-12 Marek Safar <marek.safar@gmail.com>
7826 A fix for bug #81807
7827 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7828 present inside switch statement and it is required by nullable check.
7830 2007-06-12 Marek Safar <marek.safar@gmail.com>
7832 A fix for bug #81840
7833 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7834 when type matching fails.
7836 * namespace.cs: Tiny error message change.
7838 2007-06-12 Marek Safar <marek.safar@gmail.com>
7840 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7841 reporting. Added automatic property check.
7843 * class.cs: Updated after CheckAbstractAndExtern relocation.
7844 (AEventPropertyAccessor.GetSignatureForError): Customized.
7846 2007-06-11 Marek Safar <marek.safar@gmail.com>
7848 * class.cs (DefineBaseTypes): Base type can be undefined.
7850 * ecore.cs (TypeLookup): Minor refactoring.
7851 (DoResolveAsTypeStep): Removed redundant check.
7853 * namespace.cs (Lookup): Removed redundant check.
7855 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7856 ResolveAsTypeTerminal step.
7857 (BootstrapCorlib_*): Simplified.
7858 (PopulateCoreType): Core types can be now external.
7860 2007-06-07 Marek Safar <marek.safar@gmail.com>
7862 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7864 (InferTypeArguments): Infers anonymous expression type arguments.
7865 (Compatible): Split to Compatible and InferTypeArguments.
7867 * lambda.cs: Updated.
7869 2007-06-08 Marek Safar <marek.safar@gmail.com>
7871 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7873 2007-06-07 Raja R Harinath <harinath@gmail.com>
7875 Fix #80477, cs0135-2.cs, cs0135-3.cs
7876 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7877 names to the "known" variables list.
7878 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7879 parameter names are also "known".
7880 (Block.CheckError136): Remove.
7881 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7884 2007-06-07 Marek Safar <marek.safar@gmail.com>
7886 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7888 2007-06-06 Marek Safar <marek.safar@gmail.com>
7890 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7891 internal error not an user error.
7893 * expression.cs (IsApplicable): Refactored to make debugging easier.
7895 * support.cs: More tricks for non-mono runtimes.
7897 * typemanager.cs (CoreLookupType): Made public.
7898 (InitSystemCore): All linq specific stuff moved to linq.cs
7900 2007-06-05 Marek Safar <marek.safar@gmail.com>
7902 * typemanager.cs (CSharpSignature): One more missing build-in types
7904 More tricks for non-mono runtime.
7906 2007-06-05 Raja R Harinath <harinath@gmail.com>
7908 * statement.cs (Block.CheckError136_InParents): Remove.
7909 (Block.AddVariable): Use GetParameterInfo instead.
7910 (ToplevelBlock.ProcessArguments): Likewise.
7912 2007-06-04 Raja R Harinath <rharinath@novell.com>
7914 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7916 (ToplevelBlock.GetParameterInfo): Split out of ...
7917 (ToplevelBlock.GetParameterRefernce): ... this.
7918 (ToplevelBlock.ParameterMap): Remove.
7919 * expression.cs (ParameterReference): Update to use
7920 ToplevelParameterInfo.
7922 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7925 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7926 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7928 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7929 (ToplevelBlock.ProcessParameters) ... here.
7930 (ToplevelBlock..ctor): Invoke it.
7932 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7935 * statement.cs (IKnownVariable): New interface.
7936 (LocalInfo): Implement it.
7937 (ToplevelParameterInfo): New class.
7938 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7939 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7940 GetKnownVariableInfo.
7942 2007-06-03 Raja R Harinath <harinath@gmail.com>
7944 Partly speed up CS0136 error checks.
7945 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7946 'recurse' parameter.
7947 (Block.DoCheckError136): Only check errors in parameters. Move
7948 local variable checks ...
7949 (Block.AddVariable): ... here, and ...
7950 (ToplevelBlock.ResolveMeta): ... here.
7952 2007-06-02 Raja R Harinath <harinath@gmail.com>
7954 * statement.cs (Block.IsChildOf): Remove.
7956 * statement.cs (Statement.Clone): Move special case code ...
7957 (Block.CloneTo): ... here.
7959 2007-05-29 Raja R Harinath <rharinath@novell.com>
7961 * statement.cs (ToplevelBlock.container): Remove field. It's
7962 redundant with 'Parent'.
7963 (ToplevelBlock.ContainerBlock): Remove accessor.
7964 (ToplevelBlock..ctor): Update to changes. Register anonymous
7965 child with parent here, ...
7966 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7968 (start_anonymous): Don't save current_block.
7969 (top_current_block): Remove.
7971 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7972 (Block.Resolve): Update to changes.
7973 (Block..ctor): Move setting of "correct" 'Toplevel'
7974 and 'Explicit' fields to ...
7975 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7977 2007-05-27 Raja R Harinath <harinath@gmail.com>
7980 * statement.cs (Block.Implicit): Remove.
7981 (Block): Update to changes.
7982 * flowanalysis.cs: Likewise.
7984 Mildly speed up CheckInvariantMeaningInBlock
7985 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7986 Recursively call AddKnownVariable to all enclosing blocks.
7987 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7988 Remove recursive calls.
7989 (Block): Update to changes.
7991 New ExplicitBlock invariants
7992 * statement.cs (Block.Explicit): New field. It points to the
7993 immediately enclosing non-implicit block.
7994 (Block..ctor): Maintain the invariant.
7995 * cs-parser.jay: Take advantage of invariant.
7997 Introduce ExplicitBlock
7998 * statement.cs (ExplicitBlock): New.
7999 (ToplevelBlock): Derive from it.
8000 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
8002 (Block.Implicit): Update to changes.
8003 * cs-parser.jay: Update to changes.
8006 * codegen.cs (EmitContext.IsLastStatement): Remove.
8007 * statement.cs (Block.DoEmit): Update to changes.
8009 2007-05-25 Raja R Harinath <rharinath@novell.com>
8011 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
8012 modifying current_block directly.
8014 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
8016 * class.cs: Implemented automatic properties (C# 3.0)
8017 Thanks to Marek for the help.
8019 2007-05-23 Raja R Harinath <rharinath@novell.com>
8021 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
8022 variable as assigned, note also that all its components are
8024 (MyBitVector.SetRange): New. Function to set multiple bits to true.
8026 2007-05-19 Marek Safar <marek.safar@gmail.com>
8028 * anonymous.cs, class.cs: Emit Compiler generated attribute when
8029 member is marked as compiler generated.
8031 * decl.cs (MemberCore): Refactored ModFlags into property.
8033 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
8034 (Check): Check only accessibility modifiers.
8036 2007-05-18 Raja R Harinath <rharinath@novell.com>
8038 Track all assignable slots in one bit array
8039 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
8040 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
8041 logic from VariableMap constructor here. Use the same 'offset'
8042 variable that's later used for computing offsets of local
8044 * flowanalysis.cs (UsageVector.parameters): Remove.
8045 (UsageVector): Update to changes.
8046 (VariableMap): Remove.
8048 Avoid creating ParameterMap in every block
8049 * statement.cs (Block.ParameterMap): Move ...
8050 (ToplevelBlock.ParameterMap): ... here.
8051 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
8053 * flowanalysis.cs (FlowBranching.param_map): Remove.
8054 (FlowBranching.UsageVector): Update to changes.
8055 (FlowBranchingToplevel.CheckOutParameters): Likewise.
8057 * statement.cs (Block.CloneTo): Clone Toplevel field too.
8059 * expression.cs (ParameterReference): Distinguish between block
8060 where parameter was referenced and declared.
8062 2007-05-18 Marek Safar <marek.safar@gmail.com>
8064 * flowanalysis.cs, statement.cs: Put back improved error handling.
8066 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
8070 Imporved object and collection initialization (C# 3.0).
8072 2007-05-15 Marek Safar <marek.safar@gmail.com>
8074 A fix for bug #81380
8075 * expression.cs (Is.DoResolve): Only value types have constant `is'
8078 2007-05-15 Raja R Harinath <rharinath@novell.com>
8080 * statement.cs (ToplevelBlock.child): Remove.
8082 2007-05-15 Raja R Harinath <harinath@gmail.com>
8084 Rationalize ResolveMeta: refactoring
8085 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
8086 out constant handling code into ...
8087 (Block.DoResolveConstants): ... this.
8089 Rationalize ResolveMeta: kill local_map
8090 * statement.cs (Block.local_map, Block.LocalMap): Remove.
8091 (Block.AssignableSlots): New.
8092 (Block.ResolveMeta): Make protected. Don't create a VariableMap
8093 for locals -- move code from VariableMap here. Avoid unnecessary
8095 * flowanalysis.cs (FlowBranching.local_map): Remove.
8096 (FlowBranching..ctor): Use Block.AssignableSlots.
8097 (VariableMap): Remove unused constructors.
8099 2007-05-11 Raja R Harinath <rharinath@novell.com>
8101 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
8103 2007-05-11 Marek Safar <marek.safar@gmail.com>
8105 * typemanager.cs (IsFriendAssembly): Should not be called for building
8108 2007-05-09 Marek Safar <marek.safar@gmail.com>
8110 * literal.cs (NullConstant): Print null in all cases.
8112 * expression.cs (Binary.ResolveOperator): Implemented delegate
8113 comparison based on C# 2.0 changes.
8115 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
8117 This code is contributed under the MIT X11 license
8119 The following enables support for several C# 3.0 language features:
8121 * cs-tokenizer.cs: Added support for the "var" keyword.
8123 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
8124 Added VarExpr class to facilitate type inferencing.
8126 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
8127 to support anonymous types.
8129 * assign.cs: Added support for type inferencing and initialization.
8131 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
8133 * expression.cs: Added implicit array support to ArrayCreation.
8134 Added 5 types and 1 interface:
8136 IInitializable Implementing classes can inject initializing
8137 statements after object instantiation.
8139 Initializer Stores data for object initialization.
8141 AnonymousType An expression for anonymous types.
8143 AnonymousTypeParameter Stores data about an anonymous type's field.
8145 NewInitialize An expression for object initialization.
8147 CollectionInitialize An expression for collection initialization.
8149 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
8152 2007-05-06 Marek Safar <marek.safar@gmail.com>
8154 A fix for bug #81500
8155 * cs-tokenizer.cs: Add special handling for coalescing operator.
8157 2007-05-06 Marek Safar <marek.safar@gmail.com>
8159 A fix for bug #81529
8160 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
8161 its value from base class until it is redefined.
8163 2007-05-02 Raja R Harinath <rharinath@novell.com>
8165 Fix regression in cs0631-3.cs
8166 * cs-parser.jay (operator_declarator): Add opt_attributes to error
8167 fallback. Make error fallback catch more cases.
8169 2007-05-01 Miguel de Icaza <miguel@novell.com>
8171 * cs-parser.jay: Allow parameters in operator declarations to have
8174 2007-04-27 Miguel de Icaza <miguel@novell.com>
8176 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
8179 * lambda.cs (ContextualReturn.Resolve): An expression is valid
8180 inside the ContextualReturn, it does not have to be an
8181 ExpressionStatement.
8183 2007-04-24 Miguel de Icaza <miguel@novell.com>
8185 * lambda.cs (ContextualReturn.Resolve): if the return type is not
8188 2007-04-23 Miguel de Icaza <miguel@novell.com>
8190 * anonymous.cs (AnonymousContainer): split the virtual Resolve
8191 method in two methods: ResolveNoDefine and Resolve.
8193 ResolveNoDefine will stop just after ResolveTopBlock has been
8196 Resolve will then continue by creating a method and issuing the
8197 call to method.Define ().
8199 (AnonymousMethod): Split and implement the new Resolve and
8200 ResolveNoDefine as well.
8202 * lambda.cs (LambdaExpression): Split the anonymous method
8203 resolution code into a separate routine (CoreCompatibilityTest)
8204 from DoCompatibleTest.
8206 (LambdaExpression.TryBuild): New method, this method tries to
8207 build the LambdaExpression with the given set of types to be used
8208 as the types for the various parameters of the lambda expression.
8210 If the compilation succeed with the given types, the infered type
8211 of the Anonymous method is returned, otherwise null is returned.
8213 2007-04-23 Marek Safar <marek.safar@gmail.com>
8215 A fix for bug #81414
8216 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
8218 2007-04-22 Miguel de Icaza <miguel@novell.com>
8220 * cs-tokenizer.cs: Change various identifiers here from the
8221 camelCasing to the recommended Linux-like style for instance
8222 variables from the Coding Guidelines.
8224 2007-04-19 Martin Baulig <martin@ximian.com>
8227 (Convert.ImplicitReferenceConversionCore): Allow conversions from
8228 System.Enum to System.ValueType.
8230 2007-04-13 Martin Baulig <martin@ximian.com>
8232 Rewrote implicit reference conversions. We need to distinguish
8233 between implicit reference conversions (13.1.4) and implicit
8234 boxing conversions (13.1.5).
8236 According to the spec, there's an an implicit conversion
8237 "From a one-dimensional array-type S[] to IList<T> and base
8238 interfaces of this interface, provided there is an implicit
8239 reference conversion from S to T." Note that this does not
8240 include boxing conversions.
8243 (Convert.ImplicitTypeParameterBoxingConversion): New method.
8244 (Convert.ImplicitReferenceConversion): Split into
8245 ImplicitReferenceConversionCore() and
8246 ImplicitBoxingConversionExist().
8247 (Convert.ImplicitReferenceConversionExists): Use the new
8248 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
8250 2007-04-12 Martin Baulig <martin@ximian.com>
8252 * convert.cs (Convert.ImplicitReferenceConversion): Move the
8253 `TypeManager.null_type' checks up to the top of the method.
8255 2007-04-11 Marek Safar <marek.safar@gmail.com>
8257 A fix for bug #81350
8258 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
8261 2007-04-11 Martin Baulig <martin@ximian.com>
8263 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
8264 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
8265 to make this work for generic classes; fixes #79561.
8267 2007-04-11 Martin Baulig <martin@ximian.com>
8269 * expression.cs (As): Add support for nullable types; fixes #79371.
8271 2007-04-11 Martin Baulig <martin@ximian.com>
8273 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
8274 `type.FullName' is null; fixes #80243.
8276 2007-04-11 Martin Baulig <martin@ximian.com>
8278 * expression.cs (Invocation.IsApplicable): Don't modify the method
8279 if type inference succeeded, but the method was not applicable.
8282 2007-04-10 Marek Safar <marek.safar@gmail.com>
8284 A fix for bug #81324
8285 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
8286 internal and external namespaces containers.
8288 2007-04-10 Martin Baulig <martin@ximian.com>
8290 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
8291 TypeManager.DropGenericMethodArguments() so we also call
8292 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
8294 2007-04-10 Martin Baulig <martin@ximian.com>
8296 * iterators.cs (Iterator.CreateIterator): Don't crash if
8297 `method.ReturnType' is null. This happens if something went wrong
8298 while resolving that typ (we already reported an error in this case).
8300 2007-04-10 Martin Baulig <martin@ximian.com>
8302 * expression.cs (New.DoResolve): Don't call CheckComImport() on
8303 generic interfaces; report the CS0144 directly.
8305 2007-04-10 Martin Baulig <martin@ximian.com>
8307 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
8308 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
8310 2007-04-10 Martin Baulig <martin@ximian.com>
8312 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
8314 2007-04-09 Raja R Harinath <rharinath@novell.com>
8317 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
8318 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
8321 * statement.cs (For.Resolve): If resolution fails, use
8324 2007-04-08 Marek Safar <marek.safar@gmail.com>
8326 * anonymous.cs (MakeName): Make faster and zero-based.
8327 (VerifyExplicitParameterCompatibility): Back to mode where generic
8328 parameter is ignored.
8329 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
8331 * class.cs (EmitType): Method can emit another new method.
8333 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
8335 * driver.cs: Updated.
8337 * lambda.cs: Reuse predefined empty parameters.
8339 * parameter.cs: Updated
8341 * support.cs: Implemented InflateTypes.
8343 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
8344 (InitSystemCore): Introduced to isolate 3.0 dependencies.
8346 2007-04-03 Martin Baulig <martin@ximian.com>
8350 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
8351 version of TypeManager.IsOverride() which also works with generic
8354 2007-04-03 Martin Baulig <martin@ximian.com>
8359 (Convert.ExplicitReferenceConversion): We need to cast when
8360 converting from IList<T> to S[].
8362 2007-04-01 Marek Safar <marek.safar@gmail.com>
8364 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8367 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8369 2007-03-31 Marek Safar <marek.safar@gmail.com>
8371 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8372 argument and return type inferring.
8374 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8375 (ReturnType): Turned to property.
8377 * statement.cs (Return): Implemented return type inferring.
8379 * support.cs (ReflectionParameters): Use local types if possible.
8381 2007-03-30 Raja R Harinath <rharinath@novell.com>
8383 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8384 (FlowBranching.UsageVector): Update to changes.
8386 Prepare to kill 'Reachability'
8387 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8388 argument of constructor.
8390 2007-03-29 Raja R Harinath <rharinath@novell.com>
8392 Prepare to kill 'Reachability'
8393 * flowanalysis.cs (UsageVector.is_unreachable): New.
8394 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8395 'reachability', and verify they're consistent.
8398 * expression.cs (New.EmitStatement): Handle type parameters here too.
8400 2007-03-29 Martin Baulig <martin@ximian.com>
8405 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8406 CompilerGeneratedClass.
8407 (ScopeInfo.EmitScopeInstance): Make this protected.
8408 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8409 `ec.CurrentAnonymousMethod.Scope == Scope'.
8411 * statement.cs (Block.ScopeInfo): Make this a property.
8413 2007-03-27 Raja R Harinath <harinath@gmail.com>
8415 Prepare to kill 'Reachability'
8416 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8417 (FlowBranching.UsageVector.Reachability): Remove property.
8418 (FlowBranching.UsageVector.IsUnreachable): New property.
8419 (FlowBranching.UsageVector.ResetBarrier): New.
8420 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8421 * codegen.cs, statement.cs: Update to changes.
8423 2007-03-27 Martin Baulig <martin@ximian.com>
8428 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8431 2007-03-26 Raja R Harinath <rharinath@novell.com>
8433 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8434 instead of TriState. Remove all mention of TriState.
8436 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8437 replaced by a boolean. Add boolean 'is_unreachable' field, check
8438 and maintain invariants.
8440 2007-03-25 Marek Safar <marek.safar@gmail.com>
8442 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8444 2007-03-25 Marek Safar <marek.safar@gmail.com>
8446 * expression.cs: Stop using obsolete 2.0 opcodes.
8448 2007-03-25 Marek Safar <marek.safar@gmail.com>
8450 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8451 one of the latests Martin's fixes.
8453 2007-03-23 Miguel de Icaza <miguel@novell.com>
8455 * expression.cs: On BigEndian systems, swap the bytes, temporary
8456 solution until we get a new bitconverter class.
8458 2007-03-23 Martin Baulig <martin@ximian.com>
8462 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8463 "Method" and "Method`1". Normally, a cache lookup is done on the
8464 "Method" form (ie. without the generic arity), but this one makes
8465 lookups on the full form work as well.
8467 2007-03-22 Raja R Harinath <rharinath@novell.com>
8469 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8472 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8474 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8475 ordered_member_list, to TypeBuilder to store members to be defined
8476 in the order they were parsed in.
8477 - ordered_explicit_member_list contains all properties indexers
8478 and methods that are defined as explicit implementation of an
8479 interface or base class.
8480 - ordered_member_list contains all properties indexers and methods
8481 that are not defined as explicit implementation of an interface
8484 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8485 functionality in these removed classes has been replaced with
8486 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8487 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8489 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8490 to CheckForDuplications inside GetMethod and SetMethod Define Method
8491 to handle method property and indexer name conflicts.
8495 All code is contributed under the MIT/X11 license.
8497 2007-03-20 Martin Baulig <martin@ximian.com>
8499 * class.cs (TypeContainer.Interfaces): Removed; they're now
8500 included in `TypeContainer.Types'.
8502 2007-03-20 Martin Baulig <martin@ximian.com>
8504 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8506 * class.cs (TypeContainer.CreateType): New public method. This is
8507 now called before DefineType() to create the TypeBuilders.
8508 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8509 has already been created by CreateType().
8510 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8511 don't resolve our base classes here; this has been moved into
8512 DefineBaseTypes(). We're now called from CreateType().
8513 (TypeContainer.DefineBaseTypes): New private method; resolve our
8514 base classes here. We're now called from DefineType().
8517 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8518 our types first to create all the TypeBuilders. After that, call
8519 TypeContainer.DefineType() on all the types which'll resolve their
8520 base classes and setup the resolve order.
8522 2007-03-20 Martin Baulig <martin@ximian.com>
8524 * class.cs (TypeContainer.Enums): Removed; they're now included in
8525 `TypeContainer.Types'.
8527 2007-03-20 Martin Baulig <martin@ximian.com>
8530 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8531 (TypeContainer.DoResolveMembers): Call DefineType() on our
8532 `compiler_generated' classes; moved here from DefineNestedTypes().
8535 (RootContext.ResolveTree): Call ResolveMembers() on all
8536 TypeContainer's in the `type_container_resolve_order'.
8538 2007-03-19 Marek Safar <marek.safar@gmail.com>
8540 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8542 2007-03-17 Marek Safar <marek.safar@gmail.com>
8544 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8545 implementation flags.
8547 2007-03-17 Marek Safar <marek.safar@gmail.com>
8549 * class.cs: More optimizations for type parameters.
8551 2007-03-15 Marek Safar <marek.safar@gmail.com>
8553 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8555 * ecore.cs, parameter.cs: More common code for both corlibs.
8557 * typemanager.cs (IsGenericMethod): Simplified.
8559 2007-03-15 Raja R Harinath <rharinath@novell.com>
8561 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8563 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8565 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8566 unconditionally. Simplify explanation.
8567 (Try.Resolve, Using.Resolve): Likewise.
8569 2007-03-15 Martin Baulig <martin@ximian.com>
8573 * decl.cs (DeclSpace): If we're a partial class, use our
8574 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8576 2007-03-15 Raja R Harinath <rharinath@novell.com>
8578 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8580 (FlowBranching.UsageVector): Update to changes.
8581 (FlowBranching.MergeSiblings): Likewise.
8582 * statement.cs: Likewise.
8584 2007-03-15 Martin Baulig <martin@ximian.com>
8589 (MemberCache): Added a special .ctor for type parameters.
8592 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8595 2007-03-09 Martin Baulig <martin@ximian.com>
8597 * enum.cs (Enum): Make this a TypeContainer.
8598 (EnumMember): Derive from `Const'.
8601 (Const.DoResolveValue): New protected virtual method; move most of
8602 the functionality of ResolveValue() here so we can override it in
8604 (Const.CreateConstantReference): Make this virtual.
8606 * class.cs (Kind): Add `Kind.Enum'.
8607 (TypeContainer.Emit): Don't emit the enums here; they're already
8608 in the `RootContext.typecontainer_resolve_order'.
8610 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8611 here; they're already in the `typecontainer_resolve_order'.
8613 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8614 TypeManager.DropGenericTypeArguments().
8617 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8618 (TypeManager.IsEnumType): Likewise.
8619 (TypeManager.EnumToUnderlying): Likewise.
8620 (TypeManager.IsEqual): Add support for enums.
8622 2007-03-12 Raja R Harinath <rharinath@novell.com>
8624 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8625 DefaultParameterValueAttribute to be undefined, say if System.dll
8628 2007-03-11 Marek Safar <marek.safar@gmail.com>
8630 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8633 2007-03-10 Marek Safar <marek.safar@gmail.com>
8635 * class.cs, parameter.cs: Unified parameters verification.
8637 2007-03-08 Martin Baulig <martin@ximian.com>
8639 * cs-parser.jay (constructor_header): Pass the location to the
8640 newly created TopLevelBlock.
8642 2007-03-07 Martin Baulig <martin@ximian.com>
8644 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8646 2007-03-06 Miguel de Icaza <miguel@novell.com>
8648 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8649 with the changes from David, fixes the build.
8651 2007-03-05 David Mitchell <dmitchell@logos.com>
8653 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8654 and its base interfaces to a one-dimensional array type S[],
8655 provided there is an implicit or explicit reference conversion
8658 2007-03-03 Marek Safar <marek.safar@gmail.com>
8660 * cs-tokenizer.cs: Implemented basic linq grammar.
8662 * driver.cs: Set linq lang version on demand.
8664 2007-02-26 Marek Safar <marek.safar@gmail.com>
8666 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8668 2007-02-25 Marek Safar <marek.safar@gmail.com>
8670 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8673 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8675 Check property and event extern attributes.
8677 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8680 2007-02-24 Marek Safar <marek.safar@gmail.com>
8682 A fix for bug #80407
8683 * ecore.cs: Don't report ambiguity error when methods have same parent.
8685 2007-02-23 Marek Safar <marek.safar@gmail.com>
8687 A fix for bug #80878
8688 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8690 2007-02-22 Marek Safar <marek.safar@gmail.com>
8692 * attribute.cs: Enable ExtensionAttribute presence test.
8694 2007-02-22 Marek Safar <marek.safar@gmail.com>
8696 * class.cs: Warn about missing GetHashCode only when Equals is override.
8698 * decl.cs: Check accessibility of type arguments.
8700 * typemanager.cs: Correctly report nullable array.
8702 2007-02-20 Marek Safar <marek.safar@gmail.com>
8704 * class.cs, report.cs: Capture more details when things go wrong.
8706 2007-02-20 Marek Safar <marek.safar@gmail.com>
8708 A fix for bug #80650
8709 * cs-parser.jay: Anonymous container starts at constructor declaration
8710 and not at block beginning because it has to be usable in constructor
8713 * statement.cs: Use context location and not block one for error reporting.
8715 2007-02-18 Marek Safar <marek.safar@gmail.com>
8717 A fix for bug #78712
8718 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8721 2007-02-18 Marek Safar <marek.safar@gmail.com>
8723 A fix for bug #80493 by Atsushi Enomoto
8724 * cs-parser.jay: Ignore invalid attribute target.
8726 2007-02-18 Marek Safar <marek.safar@gmail.com>
8728 * cs-tokenizer.cs: Ignore '\0' as white space character.
8730 2007-02-17 Miguel de Icaza <miguel@novell.com>
8732 * cs-parser.jay: Add support for lambda expressions to the mcs
8735 * lambda.cs: Only clone when we are probing, not on the final call
8736 (Compatible is the final call).
8738 * statement.cs (CloneContext): Introduce class to provide block
8739 remapping during clone.
8741 All statements Clone themselves now.
8743 (Clone): special handling for blocks, when we clone a block, we
8744 register the block inside this routine, as children of the block
8745 might trigger a lookup.
8747 * expression.cs: Add support for CloneContext in all expressions.
8749 2007-02-17 Marek Safar <marek.safar@gmail.com>
8751 A fix for bug #80493
8752 * statement.cs: Report ambiguous warning when interfaces are not related.
8754 2007-02-15 Marek Safar <marek.safar@gmail.com>
8756 C# 3.0 extension methods.
8758 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8759 cannot be used directly.
8761 * class.cs (Class.Emit): Emit extension attribute if any class method
8762 is extension method.
8763 (Method.Define): Add basic extension method validation conditions.
8764 (Method.Emit): Emit extension attribute for method.
8766 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8767 extension method exists. Currently we follow same approach as Microsoft
8768 does, emit even if a method or a class are private but this can change
8771 * cs-parser.jay: Add handling of `this' keyword in method parameters
8774 * decl.cs (DeclSpace.IsStaticClass): New property.
8775 (MemberCache.FindExtensionMethods): Looks for extension methods with
8776 defined name and extension type.
8778 * doc.cs: Updated after OverloadResolve changes.
8780 * driver.cs: Add new soft reference to System.Core.dll.
8782 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8783 (ExtensionMethodGroupExpr): Represents group of extension methods.
8785 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8786 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8787 to MethodGroupExpr and made non-static for easier customization.
8788 (Invocation.DoResolve): Add extension method lookup when no standard
8790 (MemberAccess.DoResolve): Try extension methods if no member exists.
8792 * modifiers.cs: Add METHOD_EXTENSION modifier.
8794 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8795 as well as candidate extension type.
8796 (ComputeNamespaces): When assembly constains extension methods registers
8798 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8799 extension method lookup.
8800 (Namespace.LookupExtensionMethod): Looks for extension method in this
8802 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8803 find a method which matches name and extensionType.
8805 * parameter.cs (Parameter): Add This modifer.
8806 (HasExtensionMethodModifier): New property.
8807 (Resolve): Add extension parameter check.
8808 (ModFlags): turned to property to exclude this modifier as it is not real
8810 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8812 * support.cs (ParameterData): Add ExtensionMethodType.
8813 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8815 * typemanager.cs: Add type and ctor extension attribute type.
8817 2007-02-15 Miguel de Icaza <miguel@novell.com>
8819 * report.cs (DisableErrors, EnableErrors): used to prevent error
8820 output when we are "trying" to compile various methods with
8823 * ecore.cs (Expression): Add Clone method that calls the virtual
8824 CloneTo method. The current CloneTo method in Expression throws
8825 an exception so we can track down all the places where this must
8826 be implemented (not using abstract, because that would be a lot of
8827 up-front-work before we can start testing the implementation
8830 Important: we only need Clone capabilities for expressions created
8831 by the parser, as the expressions we will be cloning are
8832 expressions in the pre-resolved state. This vastly simplifies
8835 (SimpleName): Add CloneTo that does nothing.
8836 (EmptyCast): Add CloneTo.
8838 * expression.cs (Binary): Implement CloneTo.
8839 (Invocation.IsApplicable): Store the current ec in
8840 EmitContext.TempEc and restore it on return. This is used so we
8841 do not have to sprinkle hundres of methods with an extra
8842 EmitContext, we know that the only user is the lambda expression
8843 ImplicitConversionExists code.
8845 (Argument): Add Cloning capabilities.
8846 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8847 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8848 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8849 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8850 IndexerAccess): Add Clone capability.
8852 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8854 (Argument): Add cloning capability.
8856 * assign.cs (Assign): Implement CloneTo.
8858 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8860 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8861 version by calling Convert with the EmitContext (that we are
8862 currently storing in ec, this is not great, but will do for now,
8863 to avoid passing EmitContext parameters to hundreds of functions
8864 that do not need them now).
8866 (SetExpression): Remove, it is not needed.
8868 (ContextualReturn): Implement CloneTo.
8870 * statement.cs (Statement): Implement cloning infrastructure,
8871 similar to expressions.
8873 (Block): Partial implementation of Clone for statements.
8875 (Return): Implement clone.
8877 * constant.cs (Constant.CloneTo): New method, does nothing.
8879 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8880 solution, until we decide how to exactly do this.
8882 2007-02-14 Marek Safar <marek.safar@gmail.com>
8884 A fix for bug #80493
8885 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8886 a property is override we need to use second accessor.
8888 2007-02-13 Marek Safar <marek.safar@gmail.com>
8890 A fix for bug #80418
8891 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8894 2007-02-13 Marek Safar <marek.safar@gmail.com>
8896 Another fix for bug #80749
8897 * pending.cs: Abstract class has priority over interfaces.
8899 2007-02-13 Marek Safar <marek.safar@gmail.com>
8901 Another fix for bug #80749
8902 * pending.cs: Abstract class has priority over interfaces.
8904 2007-02-13 Marek Safar <marek.safar@gmail.com>
8906 Another fix for bug #80749
8907 * pending.cs: Abstract class has priority over interfaces.
8909 2007-02-13 Marek Safar <marek.safar@gmail.com>
8911 Another fix for bug #80749
8912 * pending.cs: Abstract class has priority over interfaces.
8914 2007-02-13 Marek Safar <marek.safar@gmail.com>
8916 * class.cs Better error message.
8918 * driver.cs: Add shorter versions of -optimize option.
8920 2007-02-13 Martin Baulig <martin@ximian.com>
8922 * class.cs (Constructor.Emit): Check the return value of
8923 ec.ResolveTopBlock() and return on error.
8925 2007-02-13 Raja R Harinath <rharinath@novell.com>
8927 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8928 message to fix error message regression.
8930 2007-02-12 Marek Safar <marek.safar@gmail.com>
8932 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8934 2007-02-12 Marek Safar <marek.safar@gmail.com>
8936 A fix for bug #80749
8937 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8938 its parent container.
8940 * class.cs (DefineFieldInitializers): Each initializer can has different
8943 * const.cs: Updated.
8945 2007-02-11 Miguel de Icaza <miguel@novell.com>
8947 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8948 now all the heavy lifting to check that embedded statements or
8949 expressions have the right form is done in the ContextualReturn.
8951 (ContextualReturn): New class.
8953 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8954 method that can be invoked to report 201, so we do not replicate
8957 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8959 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8960 treating tabs as spaces.
8962 2007-02-09 Marek Safar <marek.safar@gmail.com>
8964 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8965 * assign.cs: Use full implicit conversion for right side check.
8967 2007-02-09 Marek Safar <marek.safar@gmail.com>
8969 * statement.cs (Switch): Switch over boolean type is not standardized.
8971 2007-02-08 Marek Safar <marek.safar@gmail.com>
8973 A fix for bug #80755
8974 * decl.cs (FindBaseEvent): Don't use method cache for events.
8976 2007-02-07 Marek Safar <marek.safar@gmail.com>
8978 * cs-parser.jay: Better syntax error handling.
8980 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8981 instead of underlying type value.
8983 2007-02-06 Marek Safar <marek.safar@gmail.com>
8985 * driver.cs: Check define identifier before is registered.
8987 * namespace.cs: Use existing error message.
8989 * report.cs: New warning.
8991 2007-02-06 Marek Safar <marek.safar@gmail.com>
8993 A fix for bug #80742
8994 * expression.cs: Delegate Invoke method can be called directly.
8996 2007-02-06 Marek Safar <marek.safar@gmail.com>
8998 A fix for bug #80676
8999 * class.cs (IsEntryPoint): The Main method can have params modifier.
9001 2007-02-04 Miguel de Icaza <miguel@novell.com>
9003 * parameter.cs (Parameter, Parameters): Add Clone method.
9005 * anonymous.cs (Compatible): Turn method into virtual method, so
9006 LambdaExpression can implement a different behavior.
9008 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
9009 out the basic checking here, so it can be used by
9012 * lambda.cs: Introduce "Compatible" function that will do the
9015 2007-02-02 Marek Safar <marek.safar@gmail.com>
9017 * attribute.cs: Unified one error message.
9019 * class.cs (Class): Use type attributes and not properties to test static
9021 (IsEntryPoint): Don's pass local variable.
9023 * convert.cs: Removed duplicate check.
9025 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
9027 * driver.cs: Don't crash when soft reference does not exist.
9029 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
9030 (UsingEntry): Removed redundant allocation.
9032 * parameter.cs: Add fast path for type parameters.
9034 * support.cs: Don't allocate attribute when it's not used.
9036 2007-01-30 Miguel de Icaza <miguel@novell.com>
9039 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
9040 this into a virtual method, so we can override it in LambdaExpression.
9042 * driver.cs: Improve diagnostics in case of failure.
9044 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
9045 write a function that is slightly more complex and that parses:
9047 type identifier [, type identifier]* )
9049 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
9052 (canEmpty ? i >= 0 : i > 0)
9054 2007-01-30 Raja R Harinath <rharinath@novell.com>
9056 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
9057 exception on possibly valid code.
9059 2007-01-29 Raja R Harinath <rharinath@novell.com>
9061 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
9063 (parse_opt_type_arguments): Remove. It's almost the same as
9065 (parse_namespace_or_typename): Use parse_less_than.
9067 2007-01-28 Miguel de Icaza <miguel@novell.com>
9069 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
9070 this bug took a few hours to find, because the state saved and
9071 restored by PushPosition and PopPosition was ignoring the state of
9072 parse_generic_less_than.
9074 I can also now remove the handling of OP_LT and OP_GT, this solves
9077 * cs-tokenizer.cs: store the location for the ARROW token, we use
9080 (PushPosition, PopPosition): save/restore also `current_token',
9081 restore `parse_generic_less_than' (was missing).
9083 (parse_opt_type_arguments): use parse_type, not
9084 parse_namespace_or_typename to parse types.
9086 * lambda.cs: Empty new file, will eventually have the lambda
9087 expression implementation.
9089 * lambda.test: used to test the internal tokenizer.
9091 * report.cs (FeatureIsNotISO1): Rename from
9092 FeatureIsNotStandardized, because it was about the language level
9093 (1 vs 2) it was not about standarization.
9095 (FeatureRequiresLINQ): New.
9097 * support.cs (SeekableStreamReader): Only require that the reader
9098 is a TextReader, not a StreamReader, so we can plug StringReader.
9100 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
9101 given position in the input stream the following tokens can be
9102 parsed as a type followed by an identifier.
9104 (is_punct): after a '(' if parse_type_and_parameter returns true,
9105 then return a special token OPEN_PARENS_LAMBDA which is used to
9106 avoid reduce/reduce errors in the grammar for the
9107 lambda_expression rules.
9109 (parse_type): implement a type parser inside the
9110 tokenizer, the parser only returns true or false depending on
9111 whether the input at a given position can be parsed as a type.
9113 (peek_token): new method used during type parsing.
9115 2007-01-28 Raja R Harinath <rharinath@novell.com>
9118 * anonymous.cs (ScopeInfo.InflateParameters): New.
9119 (AnonymousContainer.Resolve): Use it to redirect types of
9120 delegate parameters.
9122 2007-01-27 Raja R Harinath <rharinath@novell.com>
9125 * expression.cs (Error_InvalidArguments): Don't use two different
9126 messages for CS1503. Use ExtraInformation and
9127 SymbolRelatedToPreviousError instead.
9130 * decl.cs (DeclSpace.initialize_type_params): Don't access
9131 'type_params' of a partial class directly.
9133 2007-01-26 Miguel de Icaza <miguel@novell.com>
9135 * constant.cs: Removed a handful of out-of-range checks that were
9138 2007-01-25 Marek Safar <marek.safar@gmail.com>
9140 * expression.cs (CheckUselessComparison): Add additional check for char
9143 * namespace.cs: Fixed typo.
9145 2007-01-23 Miguel de Icaza <miguel@novell.com>
9147 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
9148 gone, instead we inline the test, preventing the needless casts to
9149 longs, ulongs and doubles for the parameters, avoiding calls to
9150 methods that overchecked stuff, and instead inlined things
9153 2007-01-20 Marek Safar <marek.safar@gmail.com>
9155 * cs-parser.jay: Better parameter error handling.
9157 2007-01-17 Marek Safar <marek.safar@gmail.com>
9159 A fix for bug #80368, #80522
9160 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
9161 whether array initializer contains constants only.
9162 (ArrayCreation.Emit): Use better formula to decide when
9163 are array initializers for static initialization.
9164 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
9165 have to emit even constants otherwise they are pre-initialized.
9167 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
9168 Raja R Harinath <rharinath@novell.com>
9170 Fix emit order of 'get' vs. 'set'.
9171 * support.cs (Accessors): New.
9172 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
9173 Note the order in which accessors are declared in the source.
9174 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
9175 Refactored from Property.Define and Indexer.Define.
9176 (PropertyBase.DefineAccessors): New helper that calls the above in
9177 appropriate order as noted by the parser.
9178 (Property.Define, Indexer.Define): Update to changes.
9179 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
9181 2007-01-17 Raja R Harinath <rharinath@novell.com>
9183 Fix cs0029-6.cs and gcs0029-2.cs (regression)
9184 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
9185 there's an implicit conversion from the current type to the target
9186 type before converting the underlying constant.
9188 2007-01-16 Marek Safar <marek.safar@gmail.com>
9190 * const.cs (ResolveValue): Updated after constant conversion was made more
9193 * constant.cs (GetAttributableValue): constant to object conversion is
9194 used for attributes only.
9195 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
9196 constant conversions.
9197 (LongConstant.ConvertImplicitly): Ditto.
9199 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
9200 (ImplicitConversionStandard): Handle constant conversion as extra step.
9201 It solves the issue when constant conversion was called indirectly like
9202 inside array initializer and constant folding was skipped.
9204 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
9207 * statement.cs(ImplicitConversionStandard): Updated after constant
9208 conversion was made more generic.
9210 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
9212 * expression.cs (As.DoResolve): Use GenericConstraints instead of
9213 Constraints, solves the problem where the compiler incorrectly
9214 reported that a type parameter was not constrained to a class (Bug
9217 2007-01-14 Marek Habersack <grendello@gmail.com>
9219 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
9221 2007-01-14 Marek Safar <marek.safar@gmail.com>
9223 A fix for bug #80368
9224 * assign.cs (FieldInitializer): New class implements field
9225 initializer statement.
9227 * attribute.cs: Update after FieldMember rename.
9229 * class.cs (PropertyBasedMember): New common class for property based
9231 (InterfaceMemberBase): New base class for all members which can be used as
9232 an interface members.
9233 (MethodCore): Moved really common code to InterfaceMemberBase.
9234 (Method.Define): Equal and GetHasCode detection is relevant for methods
9236 (MethodData.Define): Don't assume that public event implements an
9237 interface automatically.
9238 (MethodData.DefineMethodBuilder): Issue an error even if only extern
9240 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
9241 (FieldMember): Merged with FieldBase.
9242 (EventProperty.AEventPropertyAccessor): New specialization to check whether
9243 event extern modifier can be used.
9244 (EventField.EventFieldAccessor): Moved event field specific code here.
9245 (Event.AllowedModifiers): Even event can be extern.
9246 (Event.FindOutBaseMethod): New override specific to events.
9247 (Indexer.parameters): Reintroduce parameters because base class holds
9248 only properties common data.
9249 (Indexer.CheckForDuplications): Indexers are threated as methods so we
9250 need do extra parameters check.
9252 * const.cs: Update after FieldMember rename.
9254 * decl.cs (MemberCache.FindBaseEvent): New method.
9256 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
9257 to reflect that indexer is now derived from PropertyBased.
9259 * ecore.cs (GetMemberType): Made public.
9260 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
9263 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
9265 * typemanager.cs (CSharpSignature): Correctly print event accessors.
9266 (RegisterEvent): Removed.
9267 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
9268 (GetPrivateFieldOfEvent): Renamed to GetEventField.
9270 2007-01-11 Raja R Harinath <rharinath@novell.com>
9273 * statement.cs (CollectionForeach.TryType): Prefer generic
9274 GetEnumerator over non-generic variant. Fix code to follow comments.
9276 2007-01-09 Raja R Harinath <rharinath@novell.com>
9279 * support.cs (ReflectionParameter): Don't use an invalid index on
9280 the generic parameter data.
9282 2007-01-08 Miguel de Icaza <miguel@novell.com>
9284 * driver.cs: Just add a tiny bit of infrastructure.
9286 2007-01-02 Marek Safar <marek.safar@gmail.com>
9288 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
9289 where field type is struct from current assembly.
9291 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
9294 2007-01-02 Marek Safar <marek.safar@gmail.com>
9296 A fix for bug #80381
9297 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
9300 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
9302 (Namespace.LookupType): Always use core types from corlib when speficied.
9304 * report.cs: A new warning.
9306 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
9307 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
9308 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
9310 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
9311 (InitCoreTypes): Set expression type of object_type and value_type
9312 immediately after lookup.
9314 2007-01-01 Miguel de Icaza <miguel@novell.com>
9316 * cs-tokenizer.cs: Accept Pc class characters (Connector
9317 Punctuation) as valid identifiers. Fixes #78259
9319 * expression.cs (Invocation.DoResolve): Moved the check for the
9320 use of `this' for doing method calls to the Invocation resolution
9321 step, after overload resolution has taken place instead of doing
9322 the check at the low-level `This.DoResolve' level.
9324 The `This.DoResolve'(appens before overload resolution, so it has
9325 no way of knowing if the method that will be called will be
9326 instace or static, triggering an erroneous report for cs0188 (Bug
9329 We now do the check for instance method invocations after we know
9330 what method will be called.
9332 (This.CheckThisUsage): Move the actual use of this structure
9333 checking into its own method and expose it.
9335 * Everywhere that called Error_ValueCannotBeConverted: pass a new
9338 Exceptions: Null.ConvertImplicitly,
9339 Constant.ImplicitConversionRequired as there are too many call
9340 sites for passing the ec.
9342 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
9343 EmitContext, if the value is null, then we do not try to provide
9344 the extra information from the error (If a userdefined conversion
9345 exists, as UserDefinedConversion requires a non null-EmitContext).
9349 2006-12-30 Raja R Harinath <rharinath@novell.com>
9351 * flowanalysis.cs (MyBitVector): Document some invariants.
9352 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
9353 introduced below, and add a couple of others,
9355 2006-12-30 Marek Safar <marek.safar@gmail.com>
9357 * attribute.cs (GetMethodObsoleteAttribute): Uses new
9358 GetPropertyFromAccessor and GetEventFromAccessor.
9360 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
9361 overrides non-obsolete one.
9362 (Indexer.Define): Error message has been moved to the parser.
9364 * cs-parser.jay: Better syntax errors handling.
9366 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9367 when an invocation has no arguments.
9369 * ecore.cs: Removed not used caching.
9371 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9374 * report.cs: Add a new warning.
9376 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9378 * typemanager.cs (enumeration_type): Removed.
9379 (CSharpSignature): Reuses IsSpecialMethod.
9380 (IsEqual): Hack for MS BCL.
9381 (GetPropertyFromAccessor): New method.
9382 (GetEventFromAccessor): New method.
9383 (IsSpecialMethod): Fixed to handle more cases.
9385 2006-12-30 Marek Safar <marek.safar@gmail.com>
9387 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9388 Made white spaces array static.
9390 * ecore.cs (RemoveGenericArity): Optimized.
9392 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9394 (MyBitVector.initialize_vector): Simplified.
9396 2006-12-22 Miguel de Icaza <miguel@novell.com>
9398 * ecore.cs: Am not entirely happy with this hack, but it seems to
9399 address the issue in 80257 (a small test case for
9402 I set the MethodGroupExpr.Type to an internal compiler type
9403 (itself in this case) to force the resolution to take place. Why
9404 it does not take place with a null is beyond me.
9406 2006-12-20 Marek Safar <marek.safar@gmail.com>
9408 A fix for bug #80288
9409 * expression.cs (ResolveOperator): Consider user defined conversion for
9410 logical and operator too.
9411 (EmitBranchable): Optimization for logical and when full constant folding
9412 could not be applied but one operand is constant.
9414 2006-12-19 Marek Safar <marek.safar@gmail.com>
9416 * class.cs (GetClassBases): Write 5 times every day, will never use
9417 FullName for error reporting.
9419 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9421 2006-12-19 Martin Baulig <martin@ximian.com>
9423 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9424 the symbol file info here.
9426 2006-12-18 Marek Safar <marek.safar@gmail.com>
9428 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9429 of `elseif' is taking then following sections are not taking.
9430 Fixes an issue reported on mono mailing list.
9432 2006-12-18 Marek Safar <marek.safar@gmail.com>
9434 A fix for bug #80300
9435 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9436 a caller is not taking.
9438 2006-12-18 Raja R Harinath <rharinath@novell.com>
9440 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9441 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9442 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9443 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9444 * class.cs: Update to changes.
9446 2006-12-17 Marek Safar <marek.safar@gmail.com>
9448 A fix for bug #79934
9449 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9452 * class.cs (ResolveMembers): Register an iterator in current container and
9455 2006-12-16 Raja R Harinath <rharinath@novell.com>
9458 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9459 satisfy a params annotated parameter.
9461 2006-12-16 Marek Safar <marek.safar@gmail.com>
9463 A fix for bug #77014
9464 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9465 paramters correctly and not rely on hacks in Parameters class.
9466 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9468 (Invocation.VerifyArgumentsCompat): Ditto.
9469 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9472 * parameter.cs (HasParams): Don't assume that params is the last one.
9474 * support.cs (ReflectionParameters.ctor): Look for params attribute
9476 (ReflectionParameters.ParameterType): Removed hack when we returned last
9477 parameter for out of range parameters.
9478 (ParameterName, ParameterModifier): Ditto.
9480 2006-12-14 Marek Safar <marek.safar@gmail.com>
9482 A fix for bug #79987
9483 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9484 when assembly is not CLS compliant but type is. I have no idea why is this
9487 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9489 2006-12-13 Miguel de Icaza <miguel@novell.com>
9491 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9492 in struct constructors, they are basically no-ops.
9494 2006-12-12 Marek Safar <marek.safar@gmail.com>
9496 * cs-tokenizer.cs (Position): Save preprocessor status too.
9498 2006-12-12 Marek Safar <marek.safar@gmail.com>
9500 A fix for bug #77794
9501 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9503 2006-12-12 Marek Safar <marek.safar@gmail.com>
9505 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9507 (pp_expr): Report error for an invalid expression.
9508 (handle_preprocessing_directive): Simplified; add more error checking.
9510 2006-12-11 Marek Safar <marek.safar@gmail.com>
9512 A fix for bug #74939
9513 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9514 directives handling.
9516 2006-12-10 Marek Safar <marek.safar@gmail.com>
9518 A fix for bugs #80093, and #75984
9519 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9520 logic, it seems to me as it worked before "by coincidence".
9521 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9522 (cleanup): Enabled endif check.
9524 2006-12-09 Marek Safar <marek.safar@gmail.com>
9526 A fix for bug #80162
9527 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9528 enumerators are never ambiguous.
9530 2006-12-08 Raja R Harinath <rharinath@novell.com>
9533 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9535 2006-12-06 Marek Safar <marek.safar@gmail.com>
9537 A fix for bug #80144
9538 * class.cs (EventProperty.Define): Explicit implementation means
9539 that an even is used.
9541 2006-12-06 Marek Safar <marek.safar@gmail.com>
9543 Fixes the operators implementation (part II)
9545 * cfold.cs (DoConstantNumericPromotions): Renamed to
9546 DoBinaryNumericPromotions and simplified.
9547 (BinaryFold): Couple of conversion fixes; simplified.
9549 * constant.cs, ecore.cs, literal.cs
9550 (ToType): Renamed to ConvertImplicitly.
9551 (Reduce): Renamed to ConvertExplicitly.
9553 * class.cs, convert.cs: Updated.
9555 * expression.cs: TryReduce doesn't throw an exception.
9557 2006-12-01 Marek Safar <marek.safar@gmail.com>
9559 A fix for bug #80108
9560 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9563 2006-11-30 Marek Safar <marek.safar@gmail.com>
9565 Fixes unary operators implementation (part I)
9568 * cfold.cs (Error_CompileTimeOverflow): Made internal
9570 * const.cs (IConstant): Changed to use reference to constant and
9571 not constant itself.
9572 Updated IConstant implementations.
9574 * constant.cs (CreateConstant): New factory method.
9575 Updated IConstant implementation.
9577 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9579 * ecore.cs: Updated to use CreateConstantReference.
9581 * enum.cs: Reflects IConstant changes.
9583 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9585 * literal.cs (NullConstant): Change to be independently usable.
9587 2006-11-29 Martin Baulig <martin@ximian.com>
9589 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9590 we need to emit the scope initializer before calling the base .ctor.
9592 * anonymous.cs: Merged back from the new anonymous methods branch.
9593 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9595 * expression.cs (ParameterReference.DoResolveBase): Create a
9596 "normal" ScopeInfo when capturing parameters rather than using the
9597 root scope; this makes things work with anonymous methods having
9601 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9603 2006-11-22 Marek Safar <marek.safar@gmail.com>
9605 A fix for bug #79987
9606 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9607 check to a base class.
9608 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9609 only when assembly has missing attribute.
9610 * report.cs: Update.
9612 2006-11-21 Marek Safar <marek.safar@gmail.com>
9614 * cs-tokenizer.cs: Merged with gmcs version.
9616 2006-11-20 Marek Safar <marek.safar@gmail.com>
9619 * cs-parser.jay: Better error message when partial keyword is misplaced.
9621 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9623 A fix for bug #79810
9624 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9625 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9626 a RuntimeWrappedException by default.
9628 2006-11-18 Marek Safar <marek.safar@gmail.com>
9630 A fix for bug #79843
9631 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9633 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9635 2006-11-18 Marek Safar <marek.safar@gmail.com>
9637 * driver.cs, namespace.cs: Uses faster IndexOf version.
9639 2006-11-17 Marek Safar <marek.safar@gmail.com>
9641 A fix for bug #79941
9642 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9644 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9645 even if internal name is different.
9646 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9647 (UserDefinedConversion): Simplified as the operators cannot be internal.
9648 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9650 (MethodLookup): Replaced EmitContext with parentType.
9651 * expression.cs: Updated.
9653 2006-11-09 Raja R Harinath <rharinath@novell.com>
9655 * driver.cs (BadAssembly): Handle all the ugliness of
9656 DefineDynamicAssembly.
9658 2006-11-08 Raja R Harinath <rharinath@novell.com>
9660 Address parts of #58244 -- most of what's left is in the runtime
9661 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9662 CS1509 error checks, and handle them for all assembly loads, not
9663 just the first invocation.
9664 (LoadModule): Likewise. Move handling of 'adder_method' ...
9665 * codegen.cs (AssemblyClass.AddModule): ... here.
9667 2006-11-02 Marek Safar <marek.safar@gmail.com>
9669 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9670 IEnumerable<T> is ambiguous.
9672 2006-10-31 Marek Safar <marek.safar@gmail.com>
9674 A fix for bug #67689
9675 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9676 GetEnumerator is ambiguous.
9678 * report.cs: Add new warning.
9680 2006-10-29 Marek Safar <marek.safar@gmail.com>
9682 A fix for bug #78602
9683 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9684 to protected member can be nested type.
9686 2006-10-28 Marek Safar <marek.safar@gmail.com>
9688 A fix for bug #78965
9689 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9690 to protected member must derive from current type.
9692 2006-10-27 Marek Safar <marek.safar@gmail.com>
9694 assign.cs: Reuses error method.
9696 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9697 instead of type for constants.
9698 (Expression.Error_ValueAssignment): Common error method.
9700 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9703 2006-10-27 Marek Safar <marek.safar@gmail.com>
9705 A fix for bug #79081
9706 * expression.cs (MemberAccess.DoResolve): Check nested type
9709 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9711 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9713 2006-10-26 Marek Safar <marek.safar@gmail.com>
9715 A fix for bug #76591
9716 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9718 2006-10-26 Marek Safar <marek.safar@gmail.com>
9720 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9721 type forwarder of the same type multiple times.
9723 2006-10-26 Raja R Harinath <rharinath@novell.com>
9726 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9727 instance as an rvalue, even when we later resolve as an lvalue.
9729 2006-10-25 Martin Baulig <martin@ximian.com>
9731 * anonymous.cs: Fix #79673.
9733 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9735 A fix for bug #79666
9736 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9737 ignored when is optimized (= default value) as its value is already set.
9739 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9741 A fix for bug #79724
9742 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9743 TypeContainer for type lookup.
9745 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9747 A fix for bug #79231
9748 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9749 * expression.cs (OverloadResolve): Always convert type name for
9751 (ResolveNamespaceOrType): Don't confuse a nested type with any
9754 2006-10-18 Martin Baulig <martin@ximian.com>
9756 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9758 2006-10-17 Miguel de Icaza <miguel@novell.com>
9760 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9761 an int32, but requesting an int64 from the conversion
9763 2006-10-12 Martin Baulig <martin@ximian.com>
9766 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9768 2006-10-12 Martin Baulig <martin@ximian.com>
9771 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9773 2006-10-11 Miguel de Icaza <miguel@novell.com>
9775 * convert.cs: Remove broken code: I was doing the "Existance"
9776 tests for Implicit conversions.
9778 2006-10-10 Miguel de Icaza <miguel@novell.com>
9780 * convert.cs: Added one missing case in
9781 ImplicitStandardConversionExists uint64 to intptr.
9785 * typemanager.cs (uintptr_type): another core known type.
9787 * ecore.cs (OperatorCast): routine used to do cast operations that
9788 depend on op_Explicit. We could change some of the Decimal
9789 conversions to use this.
9791 This one has a probe mechanism that checks both types for an op_
9792 which it coudl be used to eliminate two classes: CastToDecimal
9793 and CastFromDecimal.
9795 * convert.cs: Implement the conversions documented in #59800
9797 2006-10-10 Martin Baulig <martin@ximian.com>
9799 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9800 before RootScope.ResolveMembers().
9802 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9803 `CurrentType' if appropriate.
9805 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9807 A fix for bug #78568
9808 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9809 when contains binary operators.
9810 * cs-parser.jay: Updated.
9812 2006-10-09 Martin Baulig <martin@ximian.com>
9815 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9816 moved that into Define() and also do the other type parameter
9817 checks there. Fixes #79094. Added gtest-292.cs.
9820 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9821 since that doesn't include type parameters; don't use `Ldelema'
9822 for type parameters. Fixes #78980. Added gtest-293.cs.
9824 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9827 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9828 conversion is allowed.
9830 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9832 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9833 error reporting when no error occurs.
9835 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9837 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9840 2006-10-06 Raja R Harinath <rharinath@novell.com>
9843 * class.cs (DefineTypeBuilder): Check circular dependencies before
9844 setting the parent of the TypeBuilder.
9845 (CheckRecursiveDefinition): Don't use 'BaseType', since
9846 it may not be valid until after DefineTypeBuilder. Use
9847 'base_type' instead.
9849 2006-10-04 Martin Baulig <martin@ximian.com>
9851 Merged the Anonymous Methods patch.
9853 * anonymous.cs, iterators.cs: The new anonymous methods code.
9855 * statement.cs (Variable): New public abstract class.
9856 (LocalInfo.Variable): New public property.
9857 (LocalInfo.ResolveVariable): New public method.
9858 (Block.Flags): Add `IsIterator'.
9859 (Block.AddVariable): Improved the CS0136 check.
9860 (Block.AnonymousChildren): New public property.
9861 (Block.AddAnonymousChild): New public method.
9862 (ToplevelBlock): Update to use the new anonymous method framework.
9863 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9864 `ToplevelBlock'; this is required to correctly implement the
9866 (Fixed, Using): Use `TemporaryVariable' instead of directly
9867 creating the `LocalBuilder'.
9869 * parameter.cs (Parameter.ResolveVariable): New public method.
9870 (Parameters.ResolveVariable): Likewise.
9872 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9874 * class.cs (TypeContainer): Replaced the `iterators' list and
9875 corresponding methods with a list of `CompilerGeneratedClass'es.
9876 (TypeContainer.ResolveMembers): New public method.
9877 (Method): `IIteratorContainer' has been replaced by
9880 * expression.cs (VariableReference): New public abstract base
9881 class for `LocalVariableReference', `ParameterReference' and
9884 * codegen.cs (EmitContext): Removed `capture_context',
9885 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9886 (EmitContext.EmitThis): Removed.
9888 * cs-parser.jay: Replace `iterator_container' with
9891 2006-10-04 Martin Baulig <martin@ximian.com>
9893 * generic.cs (GenericMethod): Don't make this abstract.
9894 (Constraints.Clone): Added dummy implementation.
9896 2006-10-04 Raja R Harinath <harinath@gmail.com>
9899 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9900 'declspaces'. Avoid allocating arrays willy-nilly.
9903 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9904 cases out of the switch.
9906 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9908 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9909 message when non-generic type is used with the type arguments.
9910 * expression.cs: Updated.
9912 2006-09-28 Raja R Harinath <rharinath@novell.com>
9915 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9916 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9917 Change semantics slightly. Don't insist on having only one
9918 temporary EmptyExpression -- just throttle the creation of new ones.
9921 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9922 non-interfaces too. If no methods are found, don't try to create
9925 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9927 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9930 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9931 us produce better error message.
9933 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9935 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9936 of the `|' operator.
9938 * report.cs: A new warning added.
9940 2006-09-27 Martin Baulig <martin@ximian.com>
9942 * generic.cs (GenericMethod): Don't make this abstract.
9944 2006-09-27 Martin Baulig <martin@ximian.com>
9947 (InternalErrorException): Added overloaded ctor taking a params array.
9949 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9951 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9952 Fixed the cases when same error was reported twice.
9954 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9955 now report symbol information.
9957 2006-09-25 Martin Baulig <martin@ximian.com>
9959 * class.cs: Completely unified with the gmcs version.
9961 2006-09-25 Martin Baulig <martin@ximian.com>
9963 * typemanager.cs (TypeManager.IsNullableType): New public function.
9964 (TypeManager.IsNullableTypeOf): Likewise.
9965 (TypeManager.IsNullableValueType): Likewise.
9967 * class.cs (MethodCore): Added the `GenericMethod' argument from
9968 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9970 2006-09-24 Raja R Harinath <harinath@gmail.com>
9972 * convert.cs: Unify with gmcs version.
9974 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9976 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9977 verify them as well.
9979 * report.cs: New warning.
9981 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9983 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9984 for anonymous block with out argument.
9986 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9988 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9989 not used private events only.
9991 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9993 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9995 * const.cs (Const.Define): Check for constant type.
9996 (Const.IsConstantTypeValid): Looks for valid constant types.
9998 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
10000 * ecore.cs (EmptyConstantCast): New common class for all constant based
10003 * expression.cs (Is.DoResolve): Handle null constant especially.
10004 (New.DoResolve): Check for new void().
10005 (MemberAccess.DoResolve): Cope with all kind of nulls.
10007 * literal.cs (NullConstant): Uses EmptyConstantCast.
10008 (NullDefault): Based on EmptyConstantCast.
10009 (NullLiteral): Uses EmptyConstantCast.
10011 * statement.cs (Block.ResolveMeta): Check for constant type.
10013 2006-09-22 Martin Baulig <martin@ximian.com>
10015 * delegate.cs, attribute.cs: Merged with the gmcs versions.
10017 2006-09-22 Raja R Harinath <rharinath@novell.com>
10019 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
10023 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
10024 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
10027 2006-09-22 Martin Baulig <martin@ximian.com>
10029 * ecore.cs: Merged with the gmcs version.
10031 * generic.cs (ConstructedType): New dummy class.
10032 (TypeArguments): Don't make this abstract.
10035 (TypeManager.IsGenericTypeDefinition): New method.
10036 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
10038 2006-09-22 Raja R Harinath <rharinath@novell.com>
10040 * expression.cs (ComposedCast): Check for arrays of TypedReference
10041 before creating the type, not after.
10043 2006-09-21 Marek Safar <marek.safar@seznam.cz>
10045 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
10046 after ToType change.
10048 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
10049 when constant must be implicitly convertible.
10051 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
10053 * ecore.cs (NullCast): Derives from NullConstant.
10055 * expression.cs (Is.DoResolve): Removed useless variables.
10056 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
10057 (New.Constantify): Add enum support.
10058 (MemberAccess.DoResolve): Add warning when accessing null constant or
10061 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
10064 * literal.cs (NullConstant): New abstract class with common
10065 functionality for all null specializations.
10066 (NullDefault): Represents default(X) when result can be
10068 (NullLiteral): Updated.
10070 * report.cs: Add new warning.
10072 2006-09-21 Martin Baulig <martin@ximian.com>
10074 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
10076 2006-09-21 Martin Baulig <martin@ximian.com>
10078 * generic.cs (GenericConstraints): New dummy class.
10079 (Constraints): Likewise.
10080 (TypeParameter): Likewise.
10081 (TypeParameterName): Likewise.
10082 (GenericMethod): Likewise.
10084 * typemanager.cs (TypeManager.GetGenericArguments): New method.
10086 * decl.cs: Merged with the gmcs version.
10088 2006-09-21 Raja R Harinath <rharinath@novell.com>
10090 * generic.cs (TypeParameter): Implement IMemberContainer.
10091 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
10093 * rootcontext.cs: Unify with gmcs version.
10095 * report.cs: Unify with gmcs version.
10096 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
10097 from gmcs/generics.cs.
10098 * generics.cs (TypeParameter): New dummy class.
10100 * support.cs: Unify with gmcs version.
10102 2006-09-20 Raja R Harinath <rharinath@novell.com>
10104 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
10105 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
10107 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
10108 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
10109 * mcs.exe.sources: Add generic.cs.
10111 * codegen.cs: Unify with gmcs version.
10113 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
10114 (EmitContext): Add GenericDeclContainer implementation.
10115 * decl.cs (MemberCore, DeclSpace): Likewise.
10116 * namespace.cs: Remove #ifdef GMCS_SOURCE.
10118 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
10119 MCS TypeManager has a corresponding dummy method.
10121 2006-09-19 Martin Baulig <martin@ximian.com>
10123 * expression.cs: Completely merged with the gmcs version.
10125 2006-09-19 Martin Baulig <martin@ximian.com>
10127 * expression.cs (Invocation): Merged with the gmcs version.
10128 (ArrayAccess.GetStoreOpcode): Likewise.
10130 2006-09-19 Martin Baulig <martin@ximian.com>
10133 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
10134 (TypeManager.IsGenericMethodDefinition): Likewise.
10136 2006-09-19 Martin Baulig <martin@ximian.com>
10139 (TypeManager.IsEqual): Moved the gmcs implementation here.
10140 (TypeManager.DropGenericTypeArguments): Likewise.
10141 (TypeManager.DropGenericMethodArguments): Likewise.
10142 (TypeManager.GetTypeArguments): Moved here from gmcs.
10143 (TypeManager.HasGenericArguments): Likewise.
10145 2006-09-19 Martin Baulig <martin@ximian.com>
10147 * expression.cs (Binary): Merged with the gmcs version.
10149 2006-09-19 Martin Baulig <martin@ximian.com>
10151 * expression.cs (Probe, As, Is): Merged with the gmcs version.
10153 2006-09-19 Martin Baulig <martin@ximian.com>
10155 * typemanager.cs: Merged with the gmcs version.
10157 2006-09-16 Raja R Harinath <rharinath@novell.com>
10159 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
10160 * driver.cs: Likewise.
10162 2006-09-16 Marek Safar <marek.safar@seznam.cz>
10165 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
10166 only if parent type is class.
10167 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
10170 2006-09-15 Marek Safar <marek.safar@seznam.cz>
10173 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
10175 * typemanager.cs(CSharpName): Converts NullType to null.
10177 2006-09-15 Martin Baulig <martin@ximian.com>
10180 (TypeManager.GetMethodName): Added mcs implementation.
10181 (TypeManager.IsEqual): Likewise.
10184 (SimpleName.RemoveGenericArity): Added dummy implementation.
10186 * pending.cs: Merged with the gmcs version.
10188 2006-09-15 Martin Baulig <martin@ximian.com>
10190 * statement.cs: Merge with the gmcs version.
10192 2006-09-15 Martin Baulig <martin@ximian.com>
10194 * statement.cs (Switch): Merge with the gmcs implementation
10195 (without nullables), which is newer.
10197 2006-09-15 Martin Baulig <martin@ximian.com>
10199 * statement.cs (Block.Variables): Make this public.
10200 (ToplevelBlock.Parameters): Make this a property.
10201 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
10203 2006-09-15 Martin Baulig <martin@ximian.com>
10205 * namespace.cs: Merge with the gmcs version.
10207 2006-09-15 Martin Baulig <martin@ximian.com>
10209 * decl.cs (MemberName): Minor code cleanups.
10211 2006-09-15 Martin Baulig <martin@ximian.com>
10213 * parameter.cs: Merge with the gmcs version.
10215 2006-09-15 Martin Baulig <martin@ximian.com>
10217 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
10218 and an error in mcs.
10220 2006-09-15 Martin Baulig <martin@ximian.com>
10222 * flowanalysis.cs: Merged from GMCS; added the generics code into
10223 a `GMCS_SOURCE' conditional so we can share this file.
10225 2006-09-08 Martin Baulig <martin@ximian.com>
10227 * typemanager.cs (TypeManager.interlocked_type): New public field.
10228 (TypeManager.int_interlocked_compare-exchange): New public field.
10229 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
10230 enumerator types here and call InitGenericCoreTypes().
10231 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
10232 after calling InitEnumUnderlyingTypes().
10235 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
10236 `classes_second_stage'.
10238 2006-09-14 Marek Safar <marek.safar@seznam.cz>
10240 * assign.cs, ecore.cs, expression.cs: Share error message text.
10241 * class.cs (FieldMember.Define): Check for varible of static type.
10242 * driver.cs (LoadAssembly): Uses error output for errors.
10243 * statement.cs: Updated.
10245 2006-09-08 Marek Safar <marek.safar@seznam.cz>
10247 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
10250 2006-09-07 Martin Baulig <martin@ximian.com>
10253 (MainDriver): Revert r62663 from Marek; see #70506 for details.
10255 2006-08-29 Miguel de Icaza <miguel@novell.com>
10257 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
10259 2006-08-17 Miguel de Icaza <miguel@novell.com>
10261 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
10262 #52019 and #79064, the use of the \uXXXX sequence in source code
10263 to represent unicode characters.
10265 2006-08-15 Marek Safar <marek.safar@seznam.cz>
10267 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
10269 * class.cs, ecore.cs, statement.cs: Merged to one error message.
10271 2006-08-13 Miguel de Icaza <miguel@novell.com>
10273 * assign.cs: Catch attempts to assign to a method groups in += and
10276 2006-08-13 Marek Safar <marek.safar@seznam.cz>
10279 * cs-parser.jay: Don't destroy current array type by typeof of array's.
10281 2006-08-12 Marek Safar <marek.safar@seznam.cz>
10283 * class.cs (Method.Define): Issue a warning when generic method looks like
10285 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
10288 2006-08-09 Marek Safar <marek.safar@seznam.cz>
10290 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
10292 * decl.cs (MemberCache.FindMembers): When container is interface we need to
10293 search all base interfaces as a member can be ambiguous.
10294 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
10295 Constructor member type filter.
10296 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
10297 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
10298 reporting for returned memberinfos.
10299 * report.cs: Updated.
10300 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
10301 version to work on all runtimes.
10302 (TypeManager.RealMemberLookup): Removed members filtering.
10304 2006-08-08 Raja R Harinath <rharinath@novell.com>
10306 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
10307 (PropertyExpr.EmitAssign): Likewise.
10308 * expression.cs (Indirection.EmitAssign): Likewise.
10309 (LocalVariableReference.EmitAssign): Likewise.
10310 (ParameterReference.EmitAssign): Likewise.
10311 (Invocation.EmitArguments): Likewise.
10312 (ArrayAccess.EmitAssign): Likewise.
10313 (IndexerAccess.EmitAssign): Likewise.
10314 (This.EmitAssign): Likewise.
10315 (ConditionalLogicalOperator.Emit): Likewise.
10318 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
10319 instead of ArrayList. If the hashtable has a LocalBuilder, don't
10320 leave it in after returning it.
10321 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
10323 2006-08-06 Marek Safar <marek.safar@seznam.cz>
10325 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
10328 2006-08-03 Raja R Harinath <rharinath@novell.com>
10330 Fix cs0146-3.cs and cs0146-4.cs.
10331 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
10332 enclosing types don't depend on the current type.
10334 2006-08-02 Raja R Harinath <rharinath@novell.com>
10337 * class.cs (TypeContainer.DoDefineMembers): Use
10338 FindBaseMemberWithSameName on Parent, since we're interested in
10339 whether we hide inherited members or not.
10340 (FindBaseMemberWithSameName): Make slightly more robust.
10342 Fix the non-generic testcase from #77396
10343 * decl.cs (DeclSpace.DeclContainer): Remove override.
10345 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
10346 declspaces for doppelgangers too.
10347 (UsingEntry): Implement IResolveContext.
10348 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
10349 'this' as the resolve context.
10350 (LocalAliasEntry): Likewise.
10352 Implement parts of #77403
10353 * roottypes.cs (RootDeclSpace): New. Used to represent the
10354 toplevel declaration space. Each namespace declaration introduces
10355 a "partial" root declaretion space.
10356 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
10357 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
10358 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
10359 from 'current_namespace.SlaveDeclSpace'.
10360 (namespace_declaration): Likewise.
10361 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10362 check. It can't happen now.
10363 * decl.cs (DeclSpace.LookupType): Likewise.
10364 * driver.cs (MainDriver): Sanity check.
10366 2006-08-01 Raja R Harinath <rharinath@novell.com>
10368 * decl.cs (DeclSpace.FindNestedType): Remove.
10369 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10370 LookupTypeContainer to get the container of the nested type.
10371 * class.cs (TypeContainer.FindNestedType): Make non-override.
10373 2006-07-31 Raja R Harinath <rharinath@novell.com>
10375 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10376 * class.cs (TypeContainer.PartialContainer): ... here.
10377 (TypeContainer.AddBasesForPart): New helper.
10378 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10380 * cs-parser.jay (current_class): Convert to DeclSpace.
10381 (struct_declaration, interface_declaration, class_declaration):
10382 Use AddBasesForPart instead of .Bases directly.
10383 * const.cs, iterators.cs: Update to changes.
10385 2006-07-28 Raja R Harinath <rharinath@novell.com>
10387 * class.cs (TypeContainer.AddMemberType): Rename from
10388 AddToTypeContainer.
10389 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10390 (AddTypeContainer): New. Combine AddClassOrStruct and
10392 (AddPartial): Update. Add 'is_partial' argument.
10393 * roottypes.cs: Update to changes.
10394 * cs-parser.jay (push_current_class): New helper for handling
10395 current_container and current_class.
10396 (struct_declaration, interface_declaration, class_declaration):
10399 2006-07-26 Raja R Harinath <rharinath@novell.com>
10401 * roottypes.cs: Rename from tree.cs.
10403 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10404 * tree.cs (Tree, ITreeDump): Remove types.
10405 * rootcontext.cs (tree, Tree): Remove fields.
10406 (root, ToplevelTypes): New.
10407 * *.cs: Update to rename.
10409 * tree.cs (Tree.RecordDecl): Remove.
10410 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10412 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10414 2006-07-23 Raja R Harinath <harinath@gmail.com>
10416 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10417 DoFlowAnalysis and OmitStructFlowAnalysis here.
10418 (ec.With): Rename from WithUnsafe and generalize.
10419 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10420 (ec.WithFlowAnalyis): New.
10421 * ecore.cs, expression.cs, statement.cs: Update.
10423 2006-07-22 Raja R Harinath <harinath@gmail.com>
10425 * statement.cs (Block.ResolveMeta): Simplify slightly.
10427 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10428 multiple boolean fields. Convert InUnsafe, constant_check_state,
10429 check_state to flags.
10430 (CheckState, ConstantCheckState): Update.
10431 (InUnsafe): New read-only property.
10432 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10434 (WithUnsafe): New helper similar to WithCheckState.
10435 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10436 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10438 2006-07-21 Raja R Harinath <rharinath@novell.com>
10440 Make comparisons use the same IL irrespective of whether they're
10441 in a 'checked' or 'unchecked' context: one of the issues in #78899
10442 * codegen.cs (EmitContext.CheckState): Make read-only property.
10443 (EmitContext.ConstantCheckState): Likewise.
10444 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10445 helper that implement a save/restore stack for CheckState
10446 values. This is the only way to change check-state.
10447 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10448 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10449 (CheckedExpr.EmitBranchable): New forwarding method.
10450 (UnCheckedExpr): Likewise.
10451 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10452 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10453 (Checked.Resolve, checked.DoEmit): Likewise.
10455 2006-07-20 Miguel de Icaza <miguel@novell.com>
10457 * anonymous.cs: Cache the resolved anonymous delegate, and return
10458 this so that the ResolveTopBlock is only triggered once, not
10461 Currently we trigger ResolvetopBlock twice due to a first pass of
10462 argument check compatibility, and a second pass that does the
10465 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10467 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10469 * rootcontext.cs (Reset): Add helper_classes.
10471 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10474 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10477 2006-07-13 Miguel de Icaza <miguel@novell.com>
10479 * statement.cs (Lock): Handle expressions of type
10480 TypeManager.null_type specially. Fixes #78770
10482 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10484 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10487 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10489 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10490 for accessors as well.
10491 * ecore.cs (EventExpr): Add AccessorTable.
10493 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10496 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10497 for CS0122 where appropriate.
10498 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10500 (Filter): Assembly can be null in the case of top level attributes.
10502 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10506 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10507 is done at global level.
10509 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10511 A fix for #77002, Implemented TypeForwarder support.
10513 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10514 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10515 * typemanager.cs (): Add type_forwarder_attr_type.
10517 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10519 * report.cs: Add CS0469 warning.
10521 2006-06-21 Martin Baulig <martin@ximian.com>
10523 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10524 the `try'-block, so we also report CS0016 etc. there.
10526 2006-06-21 Martin Baulig <martin@ximian.com>
10529 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10531 2006-06-21 Martin Baulig <martin@ximian.com>
10533 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10534 also report CS1686 for parameters.
10536 2006-06-21 Martin Baulig <martin@ximian.com>
10538 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10539 instead of an error if the value is not implicitly convertible to
10540 the switch types; fixes #77964.
10542 2006-06-21 Raja R Harinath <rharinath@novell.com>
10545 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10546 FieldBuilder is null.
10549 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10550 'left' and 'right' before error-checking.
10552 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10554 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10556 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10557 (FieldExpr.DoResolve): likewise.
10558 (PropertyExpr.InstanceResolve): likewise.
10559 (EventExpr.InstanceResolve): likewise.
10561 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10563 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10564 attribute applicable tests for attribute argument.
10566 2006-06-02 Raja R Harinath <rharinath@novell.com>
10569 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10570 (Binary.OverloadResolve_PredefinedIntegral): New.
10571 (Binary.OverloadResolve_PredefinedFloating): New.
10572 (Binary.OverloadResolve_PredefinedString): New.
10573 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10574 Follow the standard more closely, and treat numeric promotions in
10575 terms of overload resolution.
10576 (Binary.CheckShiftArguments): Simplify.
10578 2006-06-01 Raja R Harinath <rharinath@novell.com>
10580 * flowanalysis.cs (MyBitVector): Simplify representation.
10581 (MyBitVector.Clone): Avoid allocating BitArray.
10582 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10583 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10584 (*): Update. Change all references to MyBitVector.And and
10585 MyBitVector.Or to &= and |=.
10587 2006-05-29 Raja R Harinath <rharinath@novell.com>
10589 Fix cs0231-[34].cs.
10590 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10591 to param arguments too.
10593 2006-05-26 Miguel de Icaza <miguel@novell.com>
10595 * cs-parser.jay: Catch another parsing form for arglist being
10596 followed by other arguments. Fixes #78313.
10598 2006-05-24 Raja R Harinath <rharinath@novell.com>
10600 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10601 checking of out parameters to ...
10602 (FlowBranchingToplevel.Merge): ... here.
10603 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10604 set, propagate the origin upward, and only complain if there was
10606 (FlowBranchingException.AddContinueOrigin): Likewise.
10607 (FlowBranchingException.AddReturnOrigin): Likewise.
10608 (FlowBranchingException.AddGotoOrigin): Likewise.
10610 2006-05-23 Raja R Harinath <rharinath@novell.com>
10612 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10613 unreachable, skip it.
10614 (FlowBranchingException.Merge): Always propagate jumps, even if
10615 the finally block renders subsequent code unreachable.
10617 2006-05-18 Raja R Harinath <rharinath@novell.com>
10620 * statement.cs (Goto.Resolve): Move responsibility for resolving
10621 'goto' to FlowBranching.AddGotoOrigin.
10622 (Goto.SetResolvedTarget): New. Callback to set the
10623 LabeledStatement that's the target of the goto.
10624 (Goto.DoEmit): Use Leave instead of Br when crossing an
10625 unwind-protect boundary.
10626 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10627 LookupLabel and adjust to new semantics.
10628 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10629 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10630 Goto.SetResolvedTarget to update target.
10631 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10632 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10633 AddBreakOrigin & co. Delay propagation until ...
10634 (FlowBranchingException.Merge): ... this.
10636 * statement.cs (Block.Resolve): Always depend on flow-branching to
10637 determine unreachability. Kill workaround that originally emitted
10638 only one statement after an "unreachable" label (see infloop in
10641 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10642 This is still "wrong", but anything better would probably need a
10643 multi-pass algorithm.
10644 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10645 usage vector. Force current usage vector to be reachable, to
10646 optimistically signify backward jumps.
10647 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10649 (FlowBranchingLabeled.Merge): New. If no backward jump was
10650 detected, return the original salted-away usage vector instead,
10651 updated with appropriate changes. Print unreachable warning if
10653 * statement.cs (Block.Resolve): Don't print unreachable warning on
10654 a labeled statement.
10656 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10658 * driver.cs: Pass filename without path to AssemblyBuilder's
10659 AddResourceFile. Fixes bug #78407.
10661 2006-05-17 Raja R Harinath <rharinath@novell.com>
10663 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10664 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10665 (FlowBranching.MergeChild): Overwrite
10666 reachability information from Labeled branchings too.
10668 2006-05-16 Raja R Harinath <rharinath@novell.com>
10670 * statement.cs (Goto.Resolve): Merge jump origins here ...
10671 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10673 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10674 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10675 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10676 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10678 * statement.cs (Goto.Resolve): ... not here.
10679 (Goto.Emit): Remove CS1632 check.
10681 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10683 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10686 2006-05-11 Raja R Harinath <rharinath@novell.com>
10688 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10689 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10690 (FlowBranchingException.Label): Likewise.
10692 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10694 (MyBitVector.Or): Use it to avoid losing information (Count).
10695 (FlowBranching.MergeOrigins): Likewise.
10697 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10698 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10699 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10700 (UsageVector.ToString): Simplify.
10701 (UsageVector.MergeSiblings): Move here from ...
10702 (FlowBranching.Merge): ... here.
10703 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10706 2006-05-10 Raja R Harinath <rharinath@novell.com>
10708 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10709 null bitvector is treated as all-true.
10711 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10712 (MyBitVector): Rationalize invariants. 'vector != null' implies
10713 that we have our own copy of the bitvector. Otherwise,
10714 'InheritsFrom == null' implies all inherited bits are true.
10716 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10718 * statement.cs (LocalInfo): Add IsConstant.
10719 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10720 local variable for constants.
10722 2006-05-09 Raja R Harinath <rharinath@novell.com>
10724 * flowanalysis.cs (MyBitVector.Empty): New.
10725 (MyBitVector): Don't allow InheritedFrom to be null.
10726 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10727 (UsageVector, FlowBranching): Update to changes.
10729 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10730 recursion. The 'Parent == null' condition isn't sufficient for
10732 (FlowBranching.AddBreakOrigin): Likewise.
10733 (FlowBranching.AddContinueOrigin): Likewise.
10734 (FlowBranching.AddReturnOrigin): Likewise.
10735 (FlowBranching.StealFinallyClauses): Likewise.
10736 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10737 (FlowBranching.CheckOutParameters): Likewise.
10738 (FlowBranchingToplevel): Terminate all the above recursions here.
10739 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10740 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10742 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10744 (FlowBranchingToplevel): New. Empty for now.
10745 (FlowBranching.MergeTopBlock): Update.
10746 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10747 branching for the anonymous delegate.
10748 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10750 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10751 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10752 information at the start of the merge. Reorganize.
10754 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10756 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10758 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10760 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10761 to newly introduced ctor.
10763 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10764 message to one place.
10765 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10768 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10770 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10772 * ecore.cs (Expression.ResolveAsConstant): Updated.
10774 * statement.cs (ResolveMeta): Updated.
10776 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10778 * cs-parser.jay: __arglist cannot be used in initializer.
10780 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10783 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10786 2006-05-05 Raja R Harinath <rharinath@novell.com>
10788 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10789 (LabeledStatement): Add 'name' parameter.
10790 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10791 (Block.AddLabel): Update to changes.
10792 * cs-parser.jay (labeled_statement): Likewise.
10794 * flowanalysis.cs (BranchingType.Labeled): New.
10795 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10796 (FlowBranchingLabeled): New. Does nothing for now, but will
10797 eventually handle 'goto' flows.
10798 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10799 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10800 that's terminated ...
10801 (Block.Resolve): ... here.
10803 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10804 (UsageVector.MergeFinallyOrigins): Likewise.
10805 (FlowBranching.InTryOrCatch): Likewise.
10806 (FlowBranching.AddFinallyVector): Likewise.
10807 (FlowBranchingException): Update to changes.
10810 * statement.cs (Return.Resolve): Move error checking to ...
10811 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10812 (FlowBranchingException): Handle return origins like break and
10814 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10816 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10819 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10822 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10825 * class.cs (MethodData.Define): Do public accessor check only when method
10826 implements an interface.
10828 2006-05-04 Raja R Harinath <rharinath@novell.com>
10830 Remove special handling of 'break'
10831 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10832 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10833 (UsageVector.Break): Remove.
10834 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10836 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10838 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10839 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10841 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10844 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10845 be the interface member.
10847 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10850 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10851 for emitting small (int) values.
10853 2006-05-03 Raja R Harinath <rharinath@novell.com>
10856 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10857 control-flow passes through the 'finally' after merging-in all the
10858 control-flows from 'try' and the 'catch' clauses.
10860 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10861 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10862 always true at the only non-recursive entry point.
10863 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10864 FlowBranchingBreakable.
10865 (FlowBranchingLoop): Remove.
10866 * statement.cs (Return.DoResolve): Update to changes.
10869 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10870 (FlowBranching.CreateBranching): Handle it: create a
10871 FlowBranchingContinuable.
10872 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10873 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10874 except that it handles the 'continue' command.
10875 (FlowBranching.UsageVector.MergeOrigins): Rename from
10877 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10878 except that it overrides AddContinueOrigin.
10879 (FlowBranchingException): Override AddContinueOrigin, similar to
10881 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10882 Create a new branching around the embedded statement.
10883 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10884 control flow after the embedded statement.
10885 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10887 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10888 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10889 FlowBranchingBreakable.
10890 (FlowBranchingSwitch): Remove.
10893 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10894 error reporting to ...
10895 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10896 Rename from 'AddBreakVector'. Add new location argument. Return
10897 a bool indicating whether the 'break' crosses an unwind-protect.
10898 (FlowBranchingException.AddBreakOrigin): Add.
10899 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10900 flowbranching after updating with the effects of the 'finally'
10902 (FlowBranchingBreakable): New common base class for
10903 FlowBranchingLoop and FlowBranchingSwitch.
10905 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10906 embedded statement.
10907 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10909 2006-05-02 Raja R Harinath <rharinath@novell.com>
10911 * statement.cs (Do.Resolve): If the loop is infinite, set the
10913 (While.Resolve, For.Resolve): Set a barrier after the embedded
10914 statement. There's no direct control flow that goes from the end
10915 of the embedded statement to the end of the loop.
10916 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10917 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10918 above ensure that the reachability is correctly computed.
10920 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10921 (UsageVector.MergeBreakOrigins): If the current path is
10922 unreachable, treat it as if all parameters/locals are initialized.
10923 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10924 infinite loops before merging-in break origins.
10926 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10927 (Reachability.Reachable): Split part into ...
10928 (Reachability.Unreachable): ... this. Simplify.
10929 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10931 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10932 (Reachability.SetThrowsSometimes): Likewise.
10933 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10934 TriState.Always, use corresponding property.
10935 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10936 (Block.Resolve): Likewise. Remove some redundant checks.
10938 2006-05-02 Raja R Harinath <harinath@gmail.com>
10940 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10941 (Reachability.Meet): Don't bother checking AlwaysThrows --
10942 barrier is always set.
10943 (FlowBranchingBlock.Merge): Likewise.
10945 2006-05-01 Raja R Harinath <harinath@gmail.com>
10947 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10948 checks for unreachable.
10950 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10953 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10955 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10956 whether field is really assigned.
10958 2006-04-30 Raja R Harinath <harinath@gmail.com>
10960 * flowanalysis.cs (Reachability): Make 4-argument constructor
10962 (Reachability.Meet): Rename from 'And'. Remove static variant.
10963 (Reachability.Always): Rename from the highly misleading
10964 'Reachability.Never'.
10965 (FlowBranching.Merge): Update to changes. Mark an impossible
10966 situation with a 'throw'.
10967 (*): Update to changes.
10969 2006-04-29 Raja R Harinath <harinath@gmail.com>
10971 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10972 Remove 'Undefined'.
10973 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10974 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10975 (*): Update to changes.
10976 * statement.cs: Update to changes.
10978 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10981 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10983 2006-04-28 Raja R Harinath <harinath@gmail.com>
10985 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10988 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10989 argument to two arguments: an usage-vector and a bool. Move call
10990 to FlowBranching.Merge () ...
10991 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10993 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10994 handling of loop and switch reachability to ...
10995 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10997 2006-04-27 Raja R Harinath <harinath@gmail.com>
10999 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
11000 handling to FlowBranchingLoop.InLoop.
11001 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
11003 2006-04-26 Marek Safar <marek.safar@seznam.cz>
11006 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
11007 anonymous method is allowed from AnonymousContainer here.
11009 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
11011 2006-04-24 Raja R Harinath <rharinath@novell.com>
11014 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
11016 2006-04-23 Marek Safar <marek.safar@seznam.cz>
11019 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
11020 (DoubleConstant.Reduce): Ditto.
11022 2006-04-23 Raja R Harinath <rharinath@novell.com>
11024 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
11025 Remove 'lvalue_right_side' argument. Move parts to ...
11026 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
11027 (LocalVariable.DoResolveLValue): ... these.
11029 2006-04-21 Raja R Harinath <rharinath@novell.com>
11032 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
11033 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
11034 (LocalVariableReference.DoResolveBase): Use it to implement new
11036 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
11037 (Argument.Resolve): Simplify. Move CS1510 check ...
11038 * ecore.cs (Expression.ResolveLValue): ... here.
11039 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
11040 (PropertyExpr.DoResolveLValue): Likewise.
11041 (FieldExpr.Report_AssignToReadonly): Likewise.
11042 (FieldExpr.DoResolve): Add 'out_access' argument. Use
11043 LValueMemberAccess or LValueMemberOutAccess on instance depending
11045 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
11046 DoResolve as appropriate.
11048 2006-04-20 Raja R Harinath <rharinath@novell.com>
11051 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
11052 implicit conversions on 'out' and 'ref' arguments.
11054 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
11055 improve clarity. Remove dead code.
11058 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
11059 (Catch.Resolve): Resolve VarBlock if it exists.
11061 2006-04-19 Miguel de Icaza <miguel@novell.com>
11063 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
11064 twice, this was some residual code, the enumerator was emitted
11065 properly in the two branche of if later.
11067 2006-04-19 Raja R Harinath <rharinath@novell.com>
11069 * expression.cs (Cast.ResolveLValue): Remove. The result of a
11070 cast is never an lvalue.
11071 (Cast.DoResolve, Cast.ResolveRest): Combine.
11072 (Argument.Emit): Simplify slightly. Move 'Expr is
11073 IMemoryLocation' check ...
11074 (Argument.Resolve): ... here.
11075 (Argument.Error_LValueRequired): Remove. Inline into only user.
11077 Simplifications. Fix cs0191-2.cs
11078 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
11079 CS1649 and CS1651 to ...
11080 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
11081 the actual selection of the error code and message to a lookup
11082 table. Add a dummy return value to simplify callsites.
11083 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
11084 readonly fields of other instances of the same type. Move CS0197
11086 * expression.cs (Argument.Resolve): ... here. Simplify code.
11087 Ensure that ec.InRefOutArgumentResolving is only set during LValue
11088 resolution of an out or ref argument. The code simplification
11089 above uses this invariant.
11091 2006-04-18 Raja R Harinath <rharinath@novell.com>
11093 Possibly fix #77752. Fix cs1690-[4-7].cs.
11094 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
11095 CheckMarshallByRefAccess. Drop parameter.
11096 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
11098 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
11099 InstanceExpression.
11100 * report.cs (AllWarnings): Add CS1690.
11101 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
11102 for ref access too.
11103 (LocalVariableReference.DoResolveBase): Update.
11105 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11107 * class.cs (MethodOrOperator): Moved common parts from method class.
11108 detect obsolete attributes.
11109 (Method.Define): Simplified as it reuses code from base.
11110 (Constructor.ValidAttributeTargets): Fixed issue found during
11112 (Destructor.ValidAttributeTargets): Fixed issue found during
11114 (Operator): Finished refactoring set off by #78020. Operator class is now
11115 ordinary method class.
11117 * anonymous.cs: Updated.
11119 * decl.cs (DeclSpace): Add IsGeneric
11121 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11123 * class.cs (Constructor.Emit): Don't emit the attributes twice.
11125 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11127 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
11128 detect obsolete attributes.
11129 (Method.CreateEmitContext): Moved to MethodOrOperator.
11131 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11134 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
11135 customized exception to make crash detection easier.
11136 (MethodOrOperator): Started to work on new base class for methods and
11138 (Method): Derives from MethodOrOperator.
11139 (Constructor.Emit): Emits its own attributes.
11140 (AbstractPropertyEventMethod.Emit): Ditto.
11141 (Operator): Derives from MethodOrOperator, will refactor fully in extra
11143 (Operator.Emit): It's temporary more tricky than should be.
11145 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
11147 * report.cs (InternalErrorException): Add ctor with inner exception.
11149 2006-04-08 Marek Safar <marek.safar@seznam.cz>
11152 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
11155 2006-04-07 Marek Safar <marek.safar@seznam.cz>
11158 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
11161 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11163 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
11164 attribute is present and Guid not.
11165 (Interface.ApplyAttributeBuilder): Ditto.
11167 * attribute.cs: Add error message.
11169 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11173 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
11174 sources (it's composite) so hold them in extra array as they are used in
11175 Emit phase only. It worked in the previous versions by mistake.
11176 (Attribute.Emit): Emit attribute for more owners when exist.
11178 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
11179 it has now different behaviour.
11181 2006-04-04 Marek Safar <marek.safar@seznam.cz>
11183 * constant.cs (Constant.IsDefaultInitializer): New method.
11185 * class.cs: Updated.
11187 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
11188 re-initialize default values. It saves KBs almost for every assembly.
11189 Thanks Zoltan for the idea.
11190 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
11191 (ArrayCreation.DoResolve): Resolve only once.
11192 (ArrayCreation.Emit): Emit static initializer only when it is faster.
11193 (ArrayCreation.GetAttributableValue): Cope with optimized values.
11195 2006-04-03 Zoltan Varga <vargaz@gmail.com>
11197 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
11200 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11202 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
11203 in an embedded statement too.
11205 2006-04-01 Raja R Harinath <rharinath@novell.com>
11208 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
11210 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11214 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
11217 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
11219 2006-03-31 Marek Safar <marek.safar@seznam.cz>
11221 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
11224 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
11225 LocalTemporary change.
11227 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
11229 (ClassOrStruct.DefineFieldInitializers): Implemented static field
11230 initializers optimization.
11231 (ClassOrStruct.TypeAttr): Moved from modifiers.
11232 (Constructor.CheckBase): Don't crash when static ctor has parameters.
11233 (FieldBase.ResolveInitializer): Resolves initializer.
11234 (FieldBase.HasDefaultInitializer): New property.
11236 * cs-parser.jay: Removed message.
11238 * expression.cs (CompilerGeneratedThis): New specialization.
11240 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
11242 2006-03-28 Marek Safar <marek.safar@seznam.cz>
11244 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
11246 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11248 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
11249 be now EnumConstants only.
11251 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11253 * attribute.cs, driver.cs: Reset more caches.
11255 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11257 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
11259 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11261 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
11262 for easier reuse. Updated all overrides.
11263 (IntegralConstant): New base class for all integral constants.
11264 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
11265 of the constant range, report custom error.
11266 (UIntConstant.Reduce): Fixed uint conversion.
11268 * ecore.cs, literal.cs: Reduce updates.
11270 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11274 * class.cs (Constructor.Define): Removed extra if for default ctors.
11275 A patch from Atsushi Enomoto.
11277 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11279 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
11280 GetAttributableValue.
11282 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
11285 * convert.cs (ImplicitConversionRequired): Error message moved to
11288 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
11289 automatic implicit conversion of an output value.
11290 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
11292 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
11294 (TypeOf.GetAttributableValue): Add extra handling for object type.
11296 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
11297 special error message.
11299 2006-03-25 Marek Safar <marek.safar@seznam.cz>
11301 * class.cs (Constructor.Emit): Don't crash when struct ctor is
11303 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
11304 compatible with MS runtime.
11306 2006-03-23 Marek Safar <marek.safar@seznam.cz>
11308 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
11309 attribute arguments here.
11311 * class.cs (Indexer.Define): The check was moved to attribute class.
11313 2006-03-22 Marek Safar <marek.safar@seznam.cz>
11315 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
11316 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
11319 2006-03-22 Raja R Harinath <rharinath@novell.com>
11321 Support ParameterDefaultValueAttribute in gmcs. Also applied to
11322 mcs to keep code differences small.
11323 * attribute.cs (Attribute.GetParameterDefaultValue): New.
11324 * typemanager.cs (parameter_default_value_attribute_type): New.
11325 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
11328 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11330 * expression.cs (StringConcat.Append): Reverted back to no warning state.
11332 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11334 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
11336 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
11339 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
11341 * doc-bootstrap.cs : fix build.
11343 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11345 * expression.cs (StringConcat.Append): Issue a warning when empty string
11346 is going to append.
11348 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11350 * assign.cs (CompoundAssign.ResolveSource): Removed.
11352 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
11355 * class.cs (TypeContainer.FindMethods): Removed.
11356 (TypeContainer.CheckMemberUsage): Made static.
11358 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
11360 * constant.cs (CheckRange): Removed unused type argument.
11361 (CheckUnsigned): Removed unused type argument.
11363 * cs-parser.jay: Updated after MemberAccess clean up.
11364 Uses Length for empty string test.
11366 * cs-tokenizer.cs: Uses Length for empty string test.
11367 (IsCastToken): Made static.
11368 (is_hex): Made static.
11369 (real_type_suffix): Made static.
11371 * decl.cs (SetupCache): Made static.
11372 (OnGenerateDocComment): Removed unused ds argument.
11374 * delegate.cs (VerifyDelegate): Removed unused argument.
11376 * doc.cs: Uses Length for empty string test.
11378 * driver.cs: Uses Length for empty string test.
11380 * enum.cs (IsValidEnumType): Made static
11382 * expression.cs (EnumLiftUp): Removed unused argument.
11383 (ResolveMethodGroup): Ditto.
11384 (BetterConversion): Ditto.
11385 (GetVarargsTypes): Ditto.
11386 (UpdateIndices): Ditto.
11387 (ValidateInitializers): Ditto.
11388 (MemberAccess.ctor): Ditto.
11389 (GetIndexersForType): Ditto.
11391 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11393 * iterators.cs: Updated after MemberAccess clean up.
11395 * location.cs: Uses Length for empty string test.
11397 * namespace.cs: Uses Length for empty string test.
11399 * report.cs (CheckWarningCode): Made static.
11401 * statement.cs (LabeledStatement): Removed unused argument.
11403 * typemanager.cs (FilterNone): Removed.
11405 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11407 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11410 * class.cs: Updated.
11412 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11414 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11416 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11420 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11421 reporting, it's more tricky than I thought.
11423 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11427 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11429 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11430 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11431 Add more error reporting; Fixed issue with params.
11433 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11435 * cs-parser.jay: AnonymousMethod requires host container.
11437 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11439 2006-03-18 Raja R Harinath <harinath@gmail.com>
11441 * class.cs: Change 'TypeContainer ds' constructor argument to
11442 'DeclSpace parent'. Some classes were missed below due to
11443 different naming convention.
11445 * class.cs (MemberCore.Parent): Delete. This makes the
11446 ParentContainer changes below enforceable by the compiler.
11448 Treat pointers to enclosing declaration space as 'DeclSpace', not
11450 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11451 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11453 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11455 (Block.AddThisVariable): Likewise.
11456 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11457 (AbstractPropertyEventMethod.Emit): Likewise.
11458 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11459 (GetMethod.Define, SetMethod.Define): Likewise.
11460 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11461 (DelegateMethod.EmitMethod): Likewise.
11463 Fix regression test-partial-13.cs.
11464 Rationalize use of PartialContainer. Ensure that the partial
11465 class semantics can be tied to type-correctness, i.e., any
11466 violation will cause a compile error.
11467 * class.cs, const.cs: Access all fields that belong to class
11468 TypeContainer via ParentContainer. Arguments of EmitContexts and
11469 Resolve()-like functions still use 'Parent'.
11471 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11472 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11473 (PropertyMethod.CheckModifiers): Remove unused argument.
11474 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11477 2006-03-17 Raja R Harinath <harinath@gmail.com>
11479 Make semantics of PartialContainer simpler.
11480 * decl.cs (DeclSpace.IsPartial): Remove.
11481 * class.cs (TypeContainer.IsPartial): Likewise.
11482 (TypeContainer..ctor): Set PartialContainer to point to self.
11483 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11484 (TypeContainer.FindNestedType): Likewise.
11485 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11487 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11489 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11491 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11493 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11496 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11498 * class.cs (Operator.Define): An error for base conversion was not
11499 reported correctly.
11501 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11503 * iterator.cs : yield break is allowed in try statement which has
11504 catch clauses. Fixed bug #77767.
11506 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11508 A fix for #77593, #77574.
11510 * class.cs (MethodCore.CheckBase): Another if for operator.
11512 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11514 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11517 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11518 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11521 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11524 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11525 Updated after another emitcontext usage was clean up. It should help us to
11526 synchronize with gmcs easier.
11528 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11532 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11533 (Event.Define): ditto
11534 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11536 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11537 Removed redundant code and set NewSlot for Invoke method too.
11539 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11540 (Parameters.MergeGenerated): New method. Use this method when you merge
11541 compiler generated argument with user arguments.
11543 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11545 * attribute.cs (ResolveAsTypeTerminal): Removed.
11547 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11548 specialization for predefined types; 30% speed up.
11549 Finally placed obsolete check to right place.
11550 (Expression.ResolveType): Removed.
11552 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11553 Updated after ResolveType was removed.
11555 * expression.cs (Cast.ctor): Check void cast.
11556 (Binary.ResolveAsTypeTerminal): Is never type.
11557 (Conditional.ResolveAsTypeTerminal): Is never type.
11559 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11561 2006-03-01 Raja R Harinath <rharinath@novell.com>
11564 * expression.cs (ParameterReference.DoResolveBase): Change return
11566 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11570 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11573 * typemanager.cs (GetFullNameSignature): Don't nullref on
11574 protected accessors.
11576 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11578 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11579 these two separated members to simplify the code.
11580 (Attribute.Resolve): Refactored to use new fields and methods.
11581 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11582 implemented obsolete attribute checking.
11583 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11584 implemented obsolete checking again. It look line never ending quest ;-)
11585 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11587 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11589 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11591 *class.cs (Property.Define): Add RegisterProperty call.
11593 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11594 argument groups (only 2).
11596 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11597 encoding expression to arguments.
11598 (Expression.ExprClassToResolveFlags): Just turned to property.
11600 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11601 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11602 optimized as well as implemented support for zero-length attributes.
11604 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11605 Add caching of PropertyInfo's.
11607 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11609 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11610 error multiple times.
11612 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11614 New partial class implementation.
11615 A fix for #77027, #77029, #77403
11617 * attribute.cs (Attributable): Made attributes protected.
11619 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11620 the replacements of ClassPart and PartialContainer.
11621 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11622 (TypeContainer.AddInterface): Ditto.
11623 (TypeContainer.AddPartial): The main method for partial classes. It checks
11624 for errors and merges ModFlags and attributes. At the end class is added to
11625 partial_parts list.
11626 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11628 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11629 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11630 from the rest of partial classes.
11631 (TypeContainer.GetClassBases): Simplified.
11632 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11634 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11635 (TypeContainer.HasExplicitLayout): Uses Flags now.
11636 (PartialContainer): Removed.
11637 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11638 (StaticClass): Was merged with Class.
11639 (Class.GetClassBases): class and static class bases are verified here.
11640 (Class.TypeAttr): Added static attributes when class is static.
11641 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11642 (MemberBase): In some cases we need to call parent container for partial
11643 class. It should be eliminated but it's not easy now.
11645 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11647 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11648 partial classed to accumulate class comments.
11649 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11651 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11653 * driver.cs (MainDriver): Tree.GetDecl was removed.
11655 * modifiers.cs (Modifiers): Add partial modifier.
11657 * tree.cs (Tree.decl): Removed.
11658 (RootTypes): Started to use this class more often for root types
11661 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11665 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11666 external interface does not have an attribute.
11668 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11670 Another prerequisites for new partial classs implementation.
11672 * attribute.cs (Attribute.Equal): Implemented.
11673 (Attribute.Emit): Changed as attributes can be applied more than twice.
11674 (Attributes.Emit): Check for duplicate attributes here.
11676 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11677 as a parameter, clean-up.
11679 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11683 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11684 contains obsolete attribute check which can in some cases look for base
11685 type of current class which is not initialized yet.
11686 (TypeContainer.BaseType): Replacement of ptype.
11688 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11690 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11692 First of prerequisites for new partial classs implemention.
11694 * attribute.cs (Attributable): Extended by ResolveContext;
11695 Attributes finally have correct context for resolving in all cases.
11696 (AttachTo): Attribute owner is assigned here.
11698 * codegen.cs (IResolveContext): Introduce new interface to hold
11699 all information needed in resolving phase.
11700 (EmitContext): Implements IResolveContext; more clean-up needed here.
11702 * decl.cs (MemberCore): Implemented IResolveContext.
11704 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11705 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11706 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11707 Refactored to use new IResolveContext instead of EmitContext; cleanup
11709 2006-02-06 Miguel de Icaza <miguel@novell.com>
11711 * codegen.cs (EmitScopeInitFromBlock): check here the
11712 capture_context, there is no need to make two calls to the
11715 * anonymous.cs: Add some debugging messages that might help me
11716 track other instances of this problem in the future (the
11717 regression of test 467).
11719 * cs-parser.jay: track the variable block, as we need to initalize
11720 any captured variables declared in this block for the "catch"
11721 portion of the "Try" statement.
11723 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11724 scope initialization for captured variables.
11726 Also, move the emit for the variables after the block location has
11729 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11731 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11733 2006-02-02 Miguel de Icaza <miguel@novell.com>
11735 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11736 commit yesterday, the initialization for the roots is necessary.
11737 What is not necessary is the scope activation.
11739 2006-02-02 Raja R Harinath <rharinath@novell.com>
11741 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11742 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11744 (Argument.Resolve): Remove CS0206 checks.
11746 2006-02-01 Miguel de Icaza <miguel@novell.com>
11748 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11749 scopes for all the roots, the scopes will now be emitted when the
11750 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11752 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11753 code. This reduces a lot of existing cruft.
11755 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11756 that the ScopeInfo is generated as we enter the scope, not at the
11757 time of use, which is what we used to do before.
11759 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11760 every time a Block is about to be emitted if we have a
11763 2006-02-01 Raja R Harinath <rharinath@novell.com>
11765 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11767 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11769 * typemanager.cs (cons_param_array_attribute): Make private.
11770 (Reset): Set it to null.
11771 (InitCoreHelpers): Don't initialize it.
11772 (ConsParamArrayAttribute): New. Initialize it as needed.
11773 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11775 2006-01-31 Miguel de Icaza <miguel@novell.com>
11777 * expression.cs: There might be errors reported during the
11778 selection of applicable methods. If there are errors, do not
11779 continue execution as it will lead the compiler to crash.
11781 2006-01-30 Miguel de Icaza <miguel@novell.com>
11783 * expression.cs: Member access is not allowed on anonymous
11784 methods. Fixes #77402.
11786 2006-01-30 Raja R Harinath <rharinath@novell.com>
11789 * cs-parser.jay (VariableDeclaration): Don't set
11790 current_array_type to null.
11791 (field_declaration, event_declaration, declaration_statement):
11792 Set it to null here.
11794 2006-01-28 Raja R Harinath <harinath@gmail.com>
11796 * typemanager.cs (GenericParameterPosition): New.
11799 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11801 * doc.cs : To process "include" elements, first we should create
11802 another list than XmlNodeList, because it could result in node
11803 removal, which could result in that the XmlNodeList gives up
11804 yielding next node.
11806 (Also made code identical to gmcs again.)
11808 2006-01-25 Miguel de Icaza <miguel@novell.com>
11810 * ecore.cs: Introduce an error report that we were not catching
11811 before, if not silent, we must report the error. Gonzalo ran into
11814 2006-01-23 Miguel de Icaza <miguel@novell.com>
11816 A fix for bug: #76957
11818 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11819 ComputeMethodHost before creating the method, this is a new
11822 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11823 that this method references (RegisterScope). The actual scope
11824 where the method is hosted is computed with the ComputeMethodHost
11825 before we create the method.
11827 Moved the Deepest routine here.
11829 (AnonymousContainer.ComputeMethodHost): New routine used to
11830 compute the proper ScopeInfo that will host the anonymous method.
11832 (ScopeInfo): Deal with multiple roots. The problem was that we
11833 did not have a unique root where all ScopeInfos could be hanged
11834 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11837 Remove AdjustMethodScope which is now computed at the end. Remove
11838 LinkScope which did a partial link, instead link all ScopeInfos
11839 before code generation from the new "LinkScopes" routine.
11841 Simplify all the Add* routines as they no longer need to maintain
11842 the tree, they just need to record that they are using variables
11845 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11846 routines to produce the forest of ScopeInfo trees.
11848 * class.cs (TypeContainer.AppendMethod): This is just like
11849 AddMethod, but ensures that an interface implementation method
11850 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11851 methods, but at the end.
11853 We use this functionality to ensure that the generated MoveNext
11854 method in the iterator class is resolved/emitted before the
11855 enumerator methods created.
11857 This is required because the MoveNext method computes the right
11858 ScopeInfo for the method. And the other methods will eventually
11859 need to resolve and fetch information computed from the anonymous
11862 2006-01-21 Raja R Harinath <harinath@gmail.com>
11863 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11865 Fix rest of #76995.
11866 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11867 the 'aliases' hash.
11868 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11869 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11871 2006-01-18 Raja R Harinath <rharinath@novell.com>
11873 Fix #76656, cs0231-2.cs.
11874 * cs-parser.jay (formal_parameter_list): Make error case catch
11876 (parenthesized_expression_0): Add CS1026 check.
11877 (invocation_expression): Remove unused { $$ = lexer.Location }.
11879 2006-01-17 Raja R Harinath <rharinath@novell.com>
11882 * cs-parser.jay (statement_expression): Don't list out the
11883 individual statement-expressions. Convert syntax error into
11886 2006-01-16 Raja R Harinath <rharinath@novell.com>
11889 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11890 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11891 CheckIntermediateModification.
11892 (FieldExpr.DoResolve): Add new two-argument version that
11893 allows us to resolve the InstanceExpression as an lvalue.
11894 The one-argument variant is now just a wrapper.
11895 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11896 Resolve the lhs as an lvalue if the it has a value type.
11897 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11898 from Assign.DoResolve.
11899 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11900 resolved as an lvalue.
11901 (PropertyExpr.DoResolve): Update.
11902 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11903 has a value type. Move CS1612 check here from
11904 CheckIntermediateModification.
11905 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11906 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11907 'right_side' of a ResolveLValue on an 'out' argument.
11908 (EmptyExpression.LValueMemberAccess): New. Used as the
11909 'right_side' of a propagated ResolveLValue on a value type.
11910 (LocalVariableReference.DoResolveBase): Recognize
11911 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11913 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11914 EmptyExpression.Null.
11916 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11918 * typemanager.cs : added IsGenericParameter(). In mcs it always
11920 * doc.cs : for generic parameters, use GenericParameterPosition,
11923 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11925 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11927 2006-01-12 Miguel de Icaza <miguel@novell.com>
11929 This fixes the problem where we used ldfld instead of ldflda to
11930 load the "THIS" pointer on captured parameters, when THIS is a
11931 value type. See bug #77205.
11933 * iterators.cs (CapturedThisReference.Emit): Pass false to
11934 EmitThis (we do not need the address).
11936 * codegen.cs (EmitThis): it needs to know whether we need the
11937 address of `this' or not. This is used by value types.
11939 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11940 every other call passes false.
11942 2006-01-12 Raja R Harinath <rharinath@novell.com>
11945 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11947 * expression.cs (Invocation.OverloadResolve): Update.
11948 (Invocation.DoResolve): Avoid double resolution of invocation.
11950 2006-01-11 Raja R Harinath <rharinath@novell.com>
11953 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11954 unary negation of floating point types as 0-expr; negation cannot
11955 overflow in floating point types.
11958 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11959 on operands of 'void' type.
11962 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11963 and ExclusiveOr for boolean constants too.
11965 2006-01-09 Raja R Harinath <rharinath@novell.com>
11968 * expression.cs (Invocation.OverloadResolve): Replace reflected
11969 override methods with their base virtual methods, rather than
11970 skipping over them.
11971 * typemanager.cs (TypeManager.GetOverride): New.
11973 2006-01-05 Jb Evain <jbevain@gmail.com>
11975 * class.cs (Property.Define, Indexer.Define): do not tag the
11976 properties as SpecialName | RTSpecialName.
11978 2006-01-04 Miguel de Icaza <miguel@novell.com>
11980 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11981 doing a low-level comparission of parameter types. It was lacking
11982 a check for __argslist.
11984 2005-12-30 Miguel de Icaza <miguel@novell.com>
11986 * expression.cs (ParameterReference.DoResolveBase): Allow
11987 reference parameters if they are local to this block.
11989 This allows the ref and out parameters of a delegate to be used in
11990 an anonymous method, for example:
11992 delegate void set (out int x);
11994 set s = delegate (out int x){
11998 This is used by functionality introduced late in the C# language.
12000 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
12001 method that take ref and out parameters.
12003 Fixes #77119 which was a late change in the spec.
12005 2005-12-23 Miguel de Icaza <miguel@novell.com>
12007 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
12008 parent if its the same scope. Fixes #77060.
12010 2005-12-21 Miguel de Icaza <miguel@novell.com>
12012 * driver.cs: Report the case of no source files and no -out:
12015 2005-12-20 Raja R Harinath <rharinath@novell.com>
12018 * expression.cs (ComposedCast.GetSignatureForError): Define.
12020 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12024 * namespace.cs (NamespaceEntry): Add extern_aliases as a
12025 ListDictionary, to contain the ExternAliasEntry entries (in
12026 addition to the NamespaceEntry.aliases hashtable). This field is
12027 shared between the original entry and its doppelganger (bodyless
12029 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
12030 extern_aliases field.
12031 (NamespaceEntry.Lookup): Move the IsImplicit check after the
12032 lookup in extern_aliases.
12034 2005-12-16 Raja R Harinath <rharinath@novell.com>
12037 * class.cs (TypeContainer.Mark_HasEquals): New.
12038 (TypeContainer.Mark_HasGetHashCode): New.
12039 (ClassPart): Override them.
12040 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
12043 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
12044 'parent' argument to the base constructor.
12046 Remove all mention of TypeContainer from decl.cs.
12047 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
12048 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
12049 (DeclSpace.DeclSpace): Likewise.
12050 (DeclSpace.DefineMembers): Remove unused argument.
12051 * cs-parser.jay (pop_current_class): Update to changes. Simplify
12052 debugging check -- we don't care if the debug code throws an
12053 InvalidCastException instead of an InternalErrorException.
12054 * class.cs (TypeContainer.DefineMembers): Update to changes.
12055 (TypeContainer.DoDefineMembers): Likewise.
12056 (TypeContainer.GetMethods): Likewise.
12057 (PropertyMember.Define): Likewise.
12058 (MemberBase.Parent): New property that forwards to
12059 MemberCore.Parent, but ensures that we get a TypeContainer.
12060 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
12061 (RootContext.PopulateTypes): Likewise. Remove special case code
12062 for !RootContext.StdLib: DefineMembers is idempotent.
12064 2005-12-14 Miguel de Icaza <miguel@novell.com>
12066 * convert.cs (ExplicitConversionCore): Check the return value from
12067 ExplicitConversionCore which can return null on failure. Fixes #76914
12069 2005-12-13 Marek Safar <marek.safar@seznam.cz>
12071 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
12073 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
12075 * doc.cs : The search for referenced namespace was insufficient to
12076 get global one as it used to do. Fixed bug #76965.
12078 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
12080 * doc.cs : check name in cref in the last phase that whether it is
12083 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12085 * cs-tokenizer.cs : reverted the latest change: it somehow broke
12088 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12090 * doc.cs : so it turned out that we cannot skip override check for
12091 interface members. Fixed bug #76954.
12093 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12095 * cs-tokenizer.cs : fixed bug #75984:
12096 - #warning and #error should not be handled when the source line
12098 - #line is not checked strictly when the source line is disabled.
12099 - #define and #undef is on the other hand checked strictly at any
12102 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
12104 * cs-tokenizer.cs : missing Location (actually, filename) in one of
12107 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12109 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
12111 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
12112 event initializers.
12113 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
12114 (FieldBase.Initializer): Initializer is now optional.
12115 (EventField.Define): Only event field can have initializer.
12117 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
12119 * const.cs (Const): Reuse initializer.
12121 * cs-parser.jay: Updated after FieldBase changes.
12122 Added current_array_type to simplify array initializers.
12124 * ecore.cs (NullCast.IsDefaultValue): Implemented.
12126 * expression.cs, iterators.cs: Updated.
12128 * namespace.cs (NamespaceEntry): Made UsingFound private.
12130 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12132 * parameterCollection.cs: Obsolete, removed.
12133 * parser.cs: Obsolete, removed.
12135 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12138 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
12140 * enum.cs (Enum.Define): Set obsolete context here.
12142 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12145 - FindDocumentedMember() now expects 1) paramList as null
12146 when "we don't have to check the number of parameters" and
12147 2) Type.EmptyTypes when "there is no arguments".
12148 - Introduced FoundMember struct to hold the exact type which was
12149 used to find the documented member (the above change broke
12150 test-xml-044; it might be better just to use DeclaringType than
12151 what MS does, like this change does, but it depends on usage.)
12153 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12155 * doc.cs : documented member might be from DeclaringType for nested
12156 types. Fixed bug #76782.
12158 2005-12-03 Ben Maurer <bmaurer@ximian.com>
12160 * anonymous.cs: Have the param code handle leaving copies on the
12161 stack etc. Allows anonymous params to take part in the assignment
12162 code (++, +=, etc). Fixes bug #76550
12164 * expression.cs: Handle the prepare_for_load/leave_copy by passing
12165 it down to the anon code.
12167 * iterators.cs: Use dummy var here
12169 * codegen.cs: Handle new vars
12171 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12174 * class.cs (MethodData.Define): Set proper Obsolete context.
12176 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
12178 (FieldExpr.DoResolve): Ditto.
12180 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12183 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
12184 parent is not obsolete.
12186 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
12188 * doc.cs : (FindDocumentedMember) find parameterless members first
12189 and get CS0419 in the early stage. Fixed first case of bug #76727.
12191 2005-11-30 Marek Safar <marek.safar@seznam.cz>
12194 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
12195 no error was reported.
12197 *expression.cs (Binary.DoResolve): left can be null.
12199 2005-11-22 Marek Safar <marek.safar@seznam.cz>
12202 * class.cs (MethodData.Emit): Parameters should be labeled first.
12204 2005-11-21 Marek Safar <marek.safar@seznam.cz>
12207 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
12209 2005-11-18 Marek Safar <marek.safar@seznam.cz>
12211 * attribute.cs (AreParametersCompliant): Moved to Parameter.
12213 * class.cs (MethodCore): Parameter clean up.
12214 (IMethodData): Added ParameterInfo.
12215 (MethodData): Parameter clean up.
12216 (Indexer.Define): Parameter clean up.
12228 * typemanager.cs: Parameter clean up.
12230 * delegate.cs (Define): Get rid of duplicated code.
12232 * expression.cs (ParameterReference): Removed useless parameters
12234 (Invocation): Ditto.
12236 * parameter.cs (ParamsParameter): New class, params specialization.
12237 (ArglistParameter): Attemp to separate arglist.
12238 (Parameter): Refactored to be reusable and faster.
12239 (Parameter.Modifier): Made understandable.
12240 (Parameters): Changed to be used as a class for `this' assembly
12241 parameters. Refactored to use new specialized classes.
12243 * support.cs (ParameterData): Added Types property.
12244 (InternalParameters): Deleted.
12246 2005-08-20 Martin Baulig <martin@ximian.com>
12248 Merging this patch from GMCS to fix #75867.
12250 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12251 scope if we don't already have it.
12253 2005-11-17 Martin Baulig <martin@ximian.com>
12256 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
12257 inherit the scope from our parent. Fixes #76653.
12259 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12261 * doc.cs : the previous patch does not actually fix the bug.
12262 PropertyInfo override check is now implemented and really fixed it.
12263 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
12265 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12267 * doc.cs : apply "override filter" also to properties.
12270 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12272 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
12273 no need to check overrides. For classes, omit those results from
12274 interfaces since they must exist in the class. Fixed bug #76726.
12276 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12278 * typemanager.cs : (GetFullNameSignature) differentiate indexers
12279 with different parameters. Fixed the second problem in #76685.
12281 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12283 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
12284 get expected 'protected' access in CheckValidFamilyAccess()).
12287 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12289 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
12290 Fixed bug #76705. CS1569 was incorrectly commented out.
12292 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12294 * doc.cs : use Invocation.IsOverride() to do real override check.
12295 * expression.cs : made Invocation.IsOverride() internal.
12297 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12299 * doc.cs : use TypeManager.FindMembers() instead of (possible)
12300 TypeBuilder.FindMembers() and filter overriden base members out.
12303 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12305 * doc.cs : ref/out parameters are represented as '@' (instead of
12306 '&' in type FullName). Fixed bug #76630 (additionally crefs).
12308 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12310 * doc.cs : when there was no '.' in cref to methods in doc comment,
12311 then parameters were missing in the output. Fixed bug #76691.
12313 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12315 * driver.cs : don't output docs when there is an error.
12318 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12321 Now it should detect indexers. Fixed primary concern in bug #76685.
12322 Fixed CS0419 message to not show the identical member signature in
12325 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12327 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
12328 instead of Type.FindMembers() since it does not handle events.
12331 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
12333 * codegen.cs: Fixed typo (speficied -> specified).
12335 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12338 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
12340 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12342 * attribute.cs: Changed error message.
12344 * cs-tokenizer.cs: One more check.
12346 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12348 * statement.cs (Block.Resolve): Ignore empty statement.
12350 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12352 * report.cs: Made error/warning methods more strict to avoid
12355 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
12356 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
12357 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
12358 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
12360 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12362 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12363 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12365 * class.cs (TypeContainer.IsComImport): New property.
12366 (Constructor.Define): Create proper ctor for ComImport types.
12368 * expression.cs (New.CheckComImport): Fixed.
12370 2005-11-07 Miguel de Icaza <miguel@novell.com>
12372 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12373 that a parameter has been captured does not mean that we do not
12374 have to do the rest of the processing. This fixes the second part
12375 of #76592. If there was another anonymous method capturing
12376 values in the past, the Scope would never be set for the second
12377 method that captured the same parameter.
12379 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12380 properly manipulate the stack. Second part of fix for #76592.
12382 * expression.cs (New): Add support for invoking "new" on
12383 interfaces that have been flagged with the ComImport attribute and
12384 the CoClass. Fixes #76637
12386 * statement.cs (Try.DoEmit): When a variable is captured, do not
12387 try to emit the vi.LocalBuilder variable as it has been captured.
12388 Create a temporary variable and store the results on the
12389 FieldBuilder. Fixes #76642
12391 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12393 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12395 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12397 * expression.cs (Binary.DoResolve): Added && optimalization.
12399 * typemanager.cs (AddUserType): Removed useless argument.
12401 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12403 * statement.cs (Block.variables): Uses ListDictionary.
12405 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12408 * class.cs (PartialContainer.EmitType): Customized to emit
12409 security attributes.
12410 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12411 for partial classes.
12413 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12416 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12417 access has to be fixed.
12419 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12421 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12424 * ecore.cs (NullCast.Reduce): Implemented.
12426 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12429 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12431 (Foreach.Resolve): Catch null properly.
12433 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12435 * cs-tokenizer.cs: Warning text fix.
12437 * driver.cs: AllWarningNumbers exposed on public interface.
12439 * report.cs (): Reviewed warning numbers.
12440 (IsValidWarning): Use binary search.
12442 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12444 * driver.cs: Implemeted resource visibility.
12445 (Resources): New class for code sharing between /res: and
12448 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12451 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12454 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12457 * ecore.cs (NullCast): Child is contant only.
12459 * literal.cs (NullLiteral.Reduce): null can be converted to any
12462 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12464 * driver.cs: Use Encoding.Default as default code page instead
12467 2005-10-27 Raja R Harinath <rharinath@novell.com>
12470 * expression.cs (Invocation.Error_InvalidArguments): Handle
12471 __arglist parameters.
12472 (Invocation.VerifyArgumentsCompat): Likewise.
12473 * support.cs (ReflectionParameters.GetSignatureForError): Print
12474 __arglist parameters.
12475 (InternalParamters.GetSignatureForError): Likewise.
12476 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12478 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12480 * attribute.cs (GetPropertyValue): Made public.
12482 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12484 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12486 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12489 * driver.cs: Reflect method name change.
12491 * statement.cs (Try.Resolve): Warn when try has both general
12492 exception handlers.
12494 * typemanager.cs: runtime_compatibility_attr_type new predefined
12497 2005-10-26 Raja R Harinath <harinath@gmail.com>
12500 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12501 treat it as an empty parameter list.
12503 2005-10-26 Raja R Harinath <rharinath@novell.com>
12506 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12507 ResolveAsTypeStep silent.
12508 * statement.cs (Block.AddConstant): Mark block as used.
12509 (Block.ResolveMeta): Avoid piling on error messages
12510 if a constant initializer resolution fails.
12512 2005-10-25 Raja R Harinath <rharinath@novell.com>
12514 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12516 (NamespaceEntry.VerifyAllUsing): New.
12517 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12518 behaviour. Delegates actual resolution of alias to ...
12519 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12520 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12522 * driver.cs (Driver.MainDriver): Update.
12524 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12525 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12527 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12529 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12530 RootNamespace.DefineNamespacesForAll.
12532 2005-10-24 Raja R Harinath <harinath@gmail.com>
12534 * typemanager.cs (assemblies, external_aliases, modules)
12535 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12536 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12537 overhead. Move resposibility ...
12538 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12539 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12541 2005-10-23 Raja R Harinath <harinath@gmail.com>
12543 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12544 cached_namespaces. Improve usage.
12545 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12546 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12547 Move from GlobalRootNamespace and simplify.
12548 (RootNamespace.Global): Make instance variable.
12549 (RootNamespace.RootNamespace): Add "alias name" parameter.
12550 (GlobalRootNamespace): Simplify drastically.
12551 (Namespace.Lookup): Don't use GetNamespace.
12552 * typemanager.cs (GetRootNamespace): Rename from
12553 ComputeNamespaceForAlias.
12554 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12556 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12558 * anonymous.cs (AnonymousContainer): Don't crash when container
12561 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12563 * expression.cs (Binary.DoResolve): Warn when comparing same
12566 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12569 * expression.cs (Binary.DoResolve): It looks like there are no
12570 convetsion rules in enum context.
12572 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12574 Add support for extern alias qualifiers.
12575 * typemanager.cs: Move some LookupTypeReflection code
12576 to namespace.cs, to have cleaner code. Added some methods
12577 to help us keep track of the extern aliased references.
12578 * driver.cs: Add suport for extern alias assemblies on command
12579 line and check for their warnings/errors. Also keep track of the
12580 extern aliased assemblies.
12581 * namespace.cs: Move the global functionality of Namespace
12582 to GlobalRootNamespace/RootNamespace. Now the global namespace
12583 is GlobalRootNamespace.Globa. Also the code moved from
12584 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12585 Finally added LocalAliasEntry (AliasEntry before) and
12586 ExternAliasEntry, to handle alias statements.
12587 * cs-parser.jay: Add support in the grammar for extern alias
12589 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12590 Update callings to Namespace (now in GlobalRootNamespace).
12592 2005-10-18 Raja R Harinath <rharinath@novell.com>
12595 * class.cs (TypeContainer.DefineType): Move updating of
12596 topological sort earlier in the code.
12597 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12599 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12602 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12604 * constant.cs (Constant.TryReduce): Moved from Cast class.
12605 (Reduce): Made little bit more OO and fixed missing conversions.
12607 * ecore.cs (Reduce): Implemented.
12608 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12610 * literal.cs (Reduce): Implemented.
12612 * class.cs: Reverted Miguel's wrong commit.
12614 2005-10-14 Miguel de Icaza <miguel@novell.com>
12616 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12618 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12620 * cs-parser.jay, expression.cs : CS0214 was missing error location
12621 for constants. Fixed bug #76404.
12623 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12626 * convert.cs (ExplicitConversionCore): Fixed object->enum
12629 2005-10-10 Raja R Harinath <rharinath@novell.com>
12631 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12632 InstanceExpression.
12633 (PropertyExpr.EmitCall): Likewise.
12634 * expression.cs (Invocation.EmitArguments): Handle case where
12636 (Invocation.EmitCall): Avoid allocating temporary variable if
12637 there are no arguments.
12639 2005-10-07 Raja R Harinath <rharinath@novell.com>
12642 * convert.cs (ImplicitConversionStandard): Move conversion of
12643 void* to arbitrary pointer types ...
12644 (ExplicitConversionStandard): .. here.
12645 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12646 error to always print typenames.
12648 2005-10-07 Raja R Harinath <rharinath@novell.com>
12650 * convert.cs (GetConversionOperator): Rename from
12651 GetConversionOperators. Move operator selection code from ...
12652 (UserDefinedConversion): ... here.
12654 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12656 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12659 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12661 * assign.cs (Assign.DoResolve): Error method changed.
12663 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12665 * const.cs (ResolveValue): Reset in_transit immediately.
12667 * constant.cs: Error method changed.
12669 * convert.cs: Removed useless location parameter.
12670 (ExplicitNumericConversion): Don't do double enum check.
12671 (ExplicitConversionCore): Renamed from ExplicitConversion.
12672 (ExplicitUnsafe): Extracted from ExplicitConversion.
12673 (ExplicitConversion): Uses for error reporting.
12675 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12677 (ResolveBoolean): Uses common error method.
12678 (CastToDecimal): Get rid of ec.
12679 (CastFromDecimal): Optimized.
12680 (ConvCast): Get rid of ec.
12682 * enum.cs (ResolveValue): Reset in_transit immediately.
12683 (Emit): Return after first error.
12685 * expression.cs: Convert changes.
12687 * literal.cs: Error method changed.
12689 * statement.cs: Error method changed.
12691 2005-10-03 Raja R Harinath <rharinath@novell.com>
12693 * support.cs (SeekableStreamReader.Position): Don't error out when
12694 the requested position is just beyond the end of the current
12697 2005-09-28 Raja R Harinath <rharinath@novell.com>
12699 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12700 try to keep in sync with the byte count of the underlying Stream.
12701 However, this limits us to a window size of 2048 characters: i.e.,
12702 the maximum lookahead of our lexer/parser can be 2048 characters.
12704 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12707 * driver.cs: Fix compilation files with full root path.
12709 2005-09-25 Miguel de Icaza <miguel@novell.com>
12711 * report.cs (SymbolRelatedToPreviousError): Format the output so
12712 it does not use an open parenthesis that is never closed.
12714 * driver.cs: Follow coding guidelines
12716 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12719 * const.cs (Const.ResolveValue): Check for assigning non-null
12720 value to reference type.
12722 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12724 * anonymous.cs: Implemented ExprClassName.
12726 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12729 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12732 * class.cs (StaticClass.DefineContainerMembers): Report protected
12735 * codegen.cs: if(ed) PRODUCTION.
12737 * convert.cs (Error_CannotImplicitConversion): Better error
12740 * cs-parser.jay: More error checks.
12742 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12744 * driver.cs (CSCParseOption): Enabled wrong option check.
12746 * ecore.cs (Expression.ExprClassName): Turned to property.
12747 (MemberExpr.CheckIntermediateModification): For checking boxed
12748 value types modification.
12750 * statement.cs (Fixed.Resolve): Expression type must be
12751 convertible to fixed type.
12752 (CollectionForeach.GetEnumeratorFilter,TryType):
12753 Small refactoring for easier error checking.
12755 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12757 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12760 * class.cs (GeneratedBaseInitializer): New class for customization
12761 compiler generated initializers.
12762 (MemberBase.DoDefine): Check Obsolete attribute here.
12763 (FieldMember.DoDefine): Ditto.
12765 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12768 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12769 (MemberCore.GetObsoleteAttribute): Removed argument.
12770 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12771 (MemberCore.CheckObsoleteType): New helper.
12775 * statement.cs: Updates after MemberCore changes.
12777 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12778 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12780 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12781 obsolete attribute for compiler construct.
12782 (As.DoResolve): Cache result.
12784 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12786 2005-09-26 Raja R Harinath <rharinath@novell.com>
12789 * expression.cs (This.VerifyFixed): In a value type T, the type of
12790 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12791 value type R, 'this' is treated as a value parameter.
12793 2005-09-22 Miguel de Icaza <miguel@novell.com>
12795 * statement.cs (Lock): Use the TemporaryVariable class instead of
12796 manually using local variables as those do not work when variables
12799 * ecore.cs: Moved the TemporaryVariable class from being a nested
12800 class inside Foreach to be a public class that can be employed in
12803 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12805 * cs-parser.jay: interface_accessors replaced by
12806 accessor_declarations.
12808 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12811 * statement.cs (GotoCase.Resolve): Convert null constant to
12813 (SwitchLabel.ResolveAndReduce): Ditto.
12814 (SwitchLabel.NullStringCase): Custom null stamp.
12815 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12817 typemanager.cs (CSharpSignature): Don't skip first argument
12820 2005-09-18 Miguel de Icaza <miguel@novell.com>
12822 * driver.cs: Set InEmacs based on the environment variable EMACS.
12824 * location.cs (InEmacs): in this mode, do not report column
12825 location as it confuses Emacs.
12827 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12829 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12830 expression.cs, iterators.cs, literal.cs: Store constants and
12833 * class.cs (MemberBase.ShortName): Pass location.
12835 * cs-parser.jay: Some location fixes.
12837 * ecore.cs (Expression.Location): Made virtual.
12839 2005-09-05 Miguel de Icaza <miguel@novell.com>
12841 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12842 if the underlying types are the same, otherwise we need to produce
12843 code that will do the proper cast.
12845 This was exposed by Marek's constant rewrite which produced
12846 invalid code for the call site:
12848 enum X : long { a }
12849 void Method (X v) {}
12853 This fixes test-49.cs
12855 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12857 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12858 Type/Object should be allowed as well. Fixed bug #75968.
12860 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12862 * expression.cs : (Binary.DoResolve): when one is enum constant and
12863 another is constant 0, then return enum one *as enum type*.
12866 2005-09-02 Raja R Harinath <rharinath@novell.com>
12868 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12872 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12873 flow-branching for LocalVariableReferences in case we were invoked
12874 from a MemberAccess.
12875 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12877 (LocalVariableReference.DoResolveBase): ... this.
12878 (MemberAccess.Resolve): Do the check that was disabled during
12881 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12884 (PartialContainer.Create): check abstract/sealed/static strictly
12885 but abstract/sealed can exist only at one side. Fixed bug #75883.
12887 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12890 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12891 specified, don't default to UnmanagedType.I4.
12893 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12895 * expression.cs : conditional operator should check possibly
12896 incorrect assign expression. Fixed bug #75946.
12898 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12900 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12901 Reverting the change. gmcs is much complex than mcs on this matter.
12903 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12905 * cs-tokenizer.cs : To read another token ahead of the actual
12906 consumption, use new SavedToken and cache token instead of moving
12907 back the stream with SeekableStreamReader (it seemed problematic).
12909 driver.cs : Thus use StreamReader directly.
12910 * support.cs : Thus removed SeekableStreamReader.
12912 2005-08-30 Raja R Harinath <rharinath@novell.com>
12915 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12916 (ScopeInfo.EmitScopeType): Use it to construct field names from
12917 names of captured locals.
12920 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12921 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12922 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12923 (ExplicitConversion): Remove enum cases already handled by
12924 implicit conversion. Move implicit conversion check to the beginning.
12925 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12926 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12927 Don't treat System.Enum as a struct.
12929 2005-08-30 Jb Evain <jbevain@gmail.com>
12931 * attribute.cs: handles as expression in parameters.
12933 2005-08-30 Raja R Harinath <rharinath@novell.com>
12936 * class.cs (TypeContainer.VerifyClsName): Don't use a
12937 PartialContainer when verifying CLS compliance.
12938 (AbstractPropertyEventMethod): Set Parent here, ...
12939 (PropertyMethod): ... not here.
12941 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12943 * attribute.cs : escaped attribute name should not be allowed to be
12944 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12946 2005-08-29 Raja R Harinath <rharinath@novell.com>
12949 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12950 when converting a long constant to unsigned long.
12951 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12952 detect where IsApplicable and VerifyArgumentsCompat disagree.
12954 2005-08-29 Raja R Harinath <rharinath@novell.com>
12955 and Carlos Alberto Cortez <carlos@unixmexico.org>
12958 * class.cs (TypeContainer.CanElideInitializer): New helper.
12959 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12960 can safely emitting the initializer of a field.
12962 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12964 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12965 allowed inside a switch (without loop). Fixed bug #75433.
12967 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12969 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12970 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12972 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12974 * driver.cs : kinda reverting the default encoding changes (not exact
12975 revert since I noticed that "codepage:reset" might not work fine).
12977 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12979 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12980 Location. Now getter and setter store location correctly.
12981 (errors/cs0111-12.cs now reports the expected location.)
12983 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12985 * driver.cs : Use default encoding on the environment.
12986 Removed (now that) extra parameter for SeekableStreamReader.
12987 * support.cs : (SeekableStreamReader) third .ctor() argument for
12988 StreamReader is not required (always true). preamble size could
12989 be acquired in simpler and safe way.
12991 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12993 * cs-parser.jay: report CS0642 at warning level 3
12994 and report CS0642 for an if else statement also
12995 fixes bug #74745. Patch by John Luke (and a bit
12997 Removed extra CS0642 warning check for "while",
12999 * statement.cs: In Block.Resolve(), CS0642 check
13000 is reimplemented to check a sequence of an empty
13001 statement and a block.
13003 Both fix bug #66777.
13005 2005-08-24 Marek Safar <marek.safar@seznam.cz>
13007 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
13008 detection until I fix it.
13010 * cs-tokenizer.cs: Changed error message.
13012 * cs-parser.jay: Fixed 2 error locations.
13014 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
13015 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
13018 * enum.cs (GetSignatureForError): Fixed.
13020 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
13024 * typemanager.cs (RegisterProperty): Removed.
13026 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
13028 2005-08-24 Raja R Harinath <rharinath@novell.com>
13031 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
13032 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
13034 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13036 * expression.cs : tiny fix is required for not warning positive ulong.
13039 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13041 * expression.cs : add CS0652 check for constant and integral
13042 expression. Fixed bug #53974.
13044 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13046 * expression.cs : in DoNumericPromotions(), check if there is implicit
13047 conversion overload for string (to check CS0034). Fixed bug #52492.
13049 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13051 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
13053 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13055 * ecore.cs : report location when it is *not* Null.
13057 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13063 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
13064 correctly. Fixed bug #75721.
13066 2005-08-23 Raja R Harinath <rharinath@novell.com>
13068 * support.cs (SeekableStreamReader.Position): Avoid an expensive
13069 loop that performs 'min (pos, char_count)'.
13072 * expression.cs (Unary.ResolveOperator): Don't discard implicit
13073 converted value in Operator.OnesComplement.
13075 2005-08-22 Ben Maurer <bmaurer@ximian.com>
13077 * anonymous.cs: If the anon method is pulled into a helper class,
13078 it needs to be `internal' not `private'. Fixes runtime behavior on
13081 2005-08-20 Martin Baulig <martin@ximian.com>
13083 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
13084 scope if we don't already have it.
13086 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
13087 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
13090 2005-08-17 Marek Safar <marek.safar@seznam.cz>
13093 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
13094 is a partial class.
13096 2005-08-16 Marek Safar <marek.safar@seznam.cz>
13098 The big constants rewrite
13099 Fix #75746, #75685 and more
13100 As a side effect saved 1MB for MWF ;-)
13102 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
13103 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
13104 enum based for corlib compilation.
13106 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
13109 * class.cs (FixedField.Define): Use ResolveAsConstant.
13111 * const.cs (IConstant): Interface constants and enums.
13112 (Const.ResolveValue): New method for constant resolvning.
13113 (ExternalConstant): Constants from imported assemblies.
13115 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
13116 conversion; like enums.
13117 (Constant.ToType): Converts this constant to different type.
13118 (Constant.Increment): Adds 1.
13120 * convert.cs (ImplicitConversionRequired): Simplified.
13122 * cs-parser.jay: Create EnumMember directly.
13124 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
13126 * doc.cs (GenerateEnumDocComment): Removed.
13128 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
13129 (ConvertIntLiteral): Removed.
13130 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
13132 * enum.cs (EnumMember): Implement IConstant.
13133 (Enum.IsValidEnumConstant): Removed.
13134 (Enum.GetNextDefaultValue): Removed.
13135 (Enum.FindMembers): Updated.
13136 (Enum.GenerateDocComment): Iterate enum members.
13138 * expression.cs (Cast.TryReduce): Handle enums correctly.
13139 (New.Constantify): Made public.
13140 (MemberAccess.DoResolve): Removed contant specific if(s).
13142 * literal.cs (NullLiteral): Implement new abstract methods.
13144 * statement.cs (GotoCase.Resolve): Use new constant methods.
13145 (SwitchLabel.ResolveAndReduce): Use new constant methods.
13147 * typemanager.cs (LookupEnum): Removed.
13148 (IsEnumType): Fixed to work with corlib.
13149 (RegisterConstant): Removed.
13150 (LookupConstant): Removed.
13151 (GetConstant): Changed to work with IConstant.
13153 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
13155 * location.cs : Fixed overflown (>255) column number.
13157 2005-08-03 Raja R Harinath <rharinath@novell.com>
13159 First cut of the qualified-alias-member feature.
13160 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
13162 * cs-parser.jay (DOUBLE_COLON): New token.
13163 (namespace_or_type_name): Add rule for recognizing
13164 qualified-alias-members.
13165 (primary_expression): Likewise.
13166 (element_access): Allow QualifiedAliasMember as a possible
13167 type-bearing expression.
13168 (local_variable_type, local_variable_pointer_type): Likewise.
13169 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
13170 aliases in the current and enclosing namespace declarations.
13171 (NamespaceEntry.UsingAlias): Add CS0440 warning.
13172 * decl.cs (MemberName.is_double_colon): New.
13173 (MemberName.MemberName): Add new constructor for alias-member.
13174 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
13175 * expression.cs (QualifiedAliasMember): New expression type.
13177 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13179 * location.cs : it borked when no argument was specified.
13181 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13183 * location.cs : tiny ToString() format fix.
13185 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13187 * statement.cs : oops, it was missing.
13189 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13191 A set of fixes for precise line/column location.
13194 "token" field now holds a file/line "delta", a line number offset
13195 from the segment, and a column number. See also:
13196 http://lists.ximian.com/pipermail/mono-devel-list/2004-
13197 December/009508.html
13198 Removed static IsNull. Use instance IsNull property instead.
13199 * cs-tokenizer.cs :
13200 For some tokens it stores Location. For Identifier it stores
13201 LocatedToken which is a pair of string name and location.
13202 Column numbers are adjusted only at getChar().
13204 Use Location.ToString() for reporting (it now contains column).
13206 Largely modified to use LocatedToken instead of
13207 string (IDENTIFIER), and to acquire Location from some tokens.
13208 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
13209 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
13211 Now MemberName holds Location. DeclSpace.ctor() receives Location
13212 as a parameter. Removed extra parameters to all derived classes.
13213 Replaced Location.IsNull() with instance property.
13214 * assign.cs, expression.cs :
13215 Added .ctor() overload that omits Location.
13217 Added "nameEscaped" flag that indicates the identifier was escaped
13218 in the source file. This fixes bug #57047.
13220 2005-08-02 Marek Safar <marek.safar@seznam.cz>
13222 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
13223 New method, looking for lo-case imported cls type.
13225 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
13228 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
13230 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
13232 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
13233 all_imported_types.
13234 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
13236 Optimized to save 3.5 MB for SWF compilation.
13238 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13240 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
13241 (PartialContainer.Create): Moved logic AddToContainer.
13242 (PartialContainer.MarkForDuplicationCheck): Shares name.
13244 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
13247 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
13249 (Namespace.GetSignatureForError): New method.
13251 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
13252 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
13254 2005-08-01 Raja R Harinath <rharinath@novell.com>
13257 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
13258 member lookup rather than qualifier_type, since qualifier_type can
13261 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13263 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
13266 2005-07-31 Miguel de Icaza <miguel@novell.com>
13268 * statement.cs: Copy the local exception into the exception
13269 captured local. Fixes 75674
13271 2005-07-31 Raja R Harinath <harinath@gmail.com>
13274 * expression.cs (Invocation.OverloadResolve): Don't report error
13275 CS1501 if error CS1502 has been reported.
13276 (New.DoResolve): Delegate CS1501 reporting to
13277 Invocation.OverloadResolve.
13280 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
13281 invariant-meaning-in-block property in an enclosing block if
13284 2005-07-29 Marek Safar <marek.safar@seznam.cz>
13286 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
13287 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
13288 (Switch.CheckSwitch): Just save 50kb for SWF.
13290 2005-07-27 Martin Baulig <martin@ximian.com>
13292 * anonymous.cs (CaptureContext.AddField): Added
13293 `AnonymousContainer am' argument; compute its toplevel scope if
13294 it's not already computed. Fixes #75649.
13296 2005-07-26 Raja R Harinath <rharinath@novell.com>
13299 * class.cs (Constructor.Emit): Reset block to null if the block
13302 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13304 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
13306 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13308 * class.cs (MethodData.Define): Check whether accessor implementing
13309 interface is public.
13311 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
13313 2005-07-22 Marek Safar <marek.safar@seznam.cz>
13316 * namespace.cs (LookupType): Moved same type check to...
13318 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
13319 with the same name.
13321 2005-07-21 Raja R Harinath <rharinath@novell.com>
13323 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
13324 already found a typebuilder.
13325 * class.cs (MethodCore.IsDuplicateImplementation): Compare
13326 MemberNames, not strings.
13328 * const.cs (Error_ExpressionMustBeConst):
13329 Rename from Error_EpressionMustBeConst.
13330 * const.cs, class.cs, statement.cd: Update.
13332 2005-07-21 Marek Safar <marek.safar@seznam.cz>
13336 * const.cs (Const.LookupConstantValue): Report missing contant expression
13338 (Error_EpressionMustBeConstant): Only one error method.
13340 * class.cs, statement.c: Updated.
13342 2005-07-20 Raja R Harinath <rharinath@novell.com>
13344 * statement.cs (Block.Flags): Add back HasVarargs.
13345 (Block.flags): Make protected.
13346 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
13348 * typemanager.cs (types, typecontainers, user_types): Remove.
13349 (UserTypes, TypeContainers): Likewise.
13350 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
13351 (CleanUp, Reset): Update.
13352 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
13353 (GetNestedType): Use Type.GetNestedType.
13354 (CoreLookupType): Take two arguments, the namespace and the
13355 basename of the type. Update to use the Namespace.Lookup
13357 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
13358 (RealMemberLookup): Use IsNestedChildOf instead of playing with
13359 string concatenation and substring matches.
13360 * class.cs, enum.cs, delegate.cs: Update to changes.
13362 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13364 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13365 Expression and made virtual.
13367 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13368 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13370 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13372 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13375 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13378 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13381 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13382 AssemblyCultureAttribute is not used on executable.
13385 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13387 2005-07-16 Raja R Harinath <rharinath@novell.com>
13390 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13391 New. Reports CS0252/CS0253.
13392 Mostly taken from preliminary patch by Duncak Mak.
13393 (Binary.DoResolveOperator): Store results of operator lookup.
13394 Use them to detect if we need to warn about unintended reference
13397 2005-07-15 Raja R Harinath <rharinath@novell.com>
13400 * namespace.cs (Namespace.Lookup): Add back location parameter.
13401 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13402 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13404 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13405 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13406 (Namespace.LookupType): ... this.
13407 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13409 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13410 purported to handle pointers.
13411 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13414 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13416 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13419 2005-07-15 Raja R Harinath <rharinath@novell.com>
13421 * namespace.cs (Namespace.Lookup): Drop location parameter.
13422 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13423 (NamespaceEntry.Lookup): ... this.
13424 (NamespaceEntry.Error_AmbiguousTypeReference):
13425 Move here from DeclSpace.
13426 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13428 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13429 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13430 Move to NamespaceEntry.
13431 * delegate.cs, expression.cs: Update to changes.
13433 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13435 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13436 CheckAttributeType and refactored.
13437 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13438 ResolveAsTypeTerminal error handling.
13439 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13441 (GetSignatureForError): Print errors in same way.
13444 * codegen.cs: Reflect attribute GetSignatureForError change.
13447 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13449 * namespace.cs (UsingEntry): Refactored to make fields private.
13452 statement.cs: Error_UnexpectedKind has extra parameter.
13454 2005-07-14 Raja R Harinath <rharinath@novell.com>
13456 * ecore.cs (IAlias): Remove.
13457 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13458 that implement the interface.
13459 * namespace.cs (Namespace): Likewise.
13460 (Namespace.declspaces): Renamed from 'defined_names'.
13461 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13462 DeclSpace instead of an IAlias.
13463 * tree.cs (Tree.AddDecl): Update.
13465 2005-07-12 Raja R Harinath <rharinath@novell.com>
13467 * statement.cs (Block.Flags); Remove HasVarargs.
13468 (Block.HasVarargs): Move to ToplevelBlock.
13469 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13470 (Block.Variables): Make protected. Initialize variable hashtable
13472 (Block.AddVariable): Update.
13473 (Block.Resolve): Update to changes.
13474 (ToplevelBlock.HasVarargs): New boolean.
13475 (ToplevelBlock.ThisVariable): Move here from Block.
13476 (ToplevelBlock.AddThisVariable): Likewise.
13477 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13478 * expression.cs (This.ResolveBase): Update to changes.
13479 (ArglistAccess.DoResolve): Likewise.
13481 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13484 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13486 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13487 not used and not used & assigned.
13488 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13490 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13493 * expression.cs (Is.DoResolve): null is never provided type.
13495 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13498 * cs-parser.jay: Less strict event error rule to catch more errors.
13500 2005-07-08 Martin Baulig <martin@ximian.com>
13502 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13503 gettter (allowed) or setter (not allowed).
13505 * class.cs (Accessor): Implement IIteratorContainer.
13506 (Accessor.Yields): New public field.
13507 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13508 per-accessor basis.
13511 (get_accessor_declaration, set_accessor_declaration): Set the
13512 `yields' flag on the accessor, not the property.
13513 (property_declaration): Do the iterators check on a per-accessor
13514 basis and not for the whole property.
13516 2005-07-08 Martin Baulig <martin@ximian.com>
13518 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13519 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13521 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13524 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13525 (ExtractSecurityPermissionSet): Cope with self referencing security
13526 attributes properly.
13528 * driver.cs (SetOutputFile): Made public property OutputFile.
13530 2005-07-07 Raja R Harinath <rharinath@novell.com>
13533 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13534 has_nonstatic_fields. Make into a FieldBase pointer.
13535 (TypeContainer.AddField): Add CS0282 check.
13536 (TypeContainer.EmitType): Update.
13538 2005-07-06 Miguel de Icaza <miguel@novell.com>
13540 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13541 compare if they start with __.
13543 2005-07-06 Raja R Harinath <rharinath@novell.com>
13545 * statement.cs (Switch.SwitchGoverningType): Only look at
13546 UserCasts that don't need implicit standard conversions to one of
13547 the allowed switch types (Fixes test-322.cs).
13548 (LocalInfo.Resolve): Re-enable sanity-test.
13550 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13552 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13554 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13556 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13558 2005-07-06 Raja R Harinath <rharinath@novell.com>
13561 * ecore.cs (SimpleName.GetSignatureForError): Add.
13562 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13563 (MemberAccess.GetSignatureForError): Add.
13565 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13567 The big error and warning messages review.
13597 * typemanager.cs: Updated.
13599 * class.cs: (MethodCore.SetYields): Moved here to share.
13600 (PropertyMethod.Define): Moved iterator setup here.
13602 * iterators.cs: Add orig_method to have full access to parent
13605 2005-07-05 Raja R Harinath <rharinath@novell.com>
13607 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13608 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13609 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13610 variable of struct type.
13611 * expression.cs (Unary.ResolveOperator): Update to change.
13612 (Indirection.VerifyFixed): Likewise.
13613 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13614 (ParameterReference.VerifyFixed): Value parameters are fixed.
13615 (This.VerifyFixed): Treat 'this' as a value parameter.
13616 * statement.cs (LocalInfo.IsFixed): Remove.
13618 2005-07-01 Martin Baulig <martin@ximian.com>
13620 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13621 `ec.EmitThis ()' to get the correct scope.
13623 2005-07-01 Martin Baulig <martin@ximian.com>
13625 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13626 instance is a ParameterReference; fixes #75299.
13628 2005-07-01 Martin Baulig <martin@ximian.com>
13630 Reverted Marek's latest patch (r46725):
13631 - it contains structural changes which are neither mentioned in
13632 the ChangeLog nor explained anywhere; for example the additional
13633 argument of EmitContext's and Iterator's .ctor's and the
13634 TypeContainer.DefineMembers() change.
13635 - structural changes like this should go in in seperate patches
13636 and not be hidden in a huge patch which just seems to affect
13637 warnings and errors.
13638 a big and hard to understand patch.
13639 - it breaks iterators and causes regressions, for instance in
13642 2005-06-30 Raja R Harinath <rharinath@novell.com>
13645 * expression.cs (Indexers.map): Remove.
13646 (Indexers.Append): Filter out inaccessible setters and getters.
13647 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13650 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13651 Refactored from ...
13652 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13653 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13654 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13655 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13657 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13660 * class.cs (FieldBase.GetInitializerExpression): One more field
13663 2005-06-28 Miguel de Icaza <miguel@novell.com>
13665 * pending.cs: Do not define a proxy if the base method is virtual,
13666 it will be picked up by the runtime (bug 75270).
13668 2005-06-08 Martin Baulig <martin@ximian.com>
13670 The big Iterators rewrite :-)
13672 * iterators.cs: Rewrite this to use the anonymous methods framework.
13674 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13675 before the TypeContainers; see 2test-21.cs.
13678 (TypeContainer.DefineType): Don't create a new EmitContext if we
13679 already have one (this only happens if we're an Iterator).
13680 (TypeContainer.Define): Also call Define() on all our iterators.
13681 (Method.CreateEmitContext): Added support for iterators.
13684 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13685 (AnonymousContainer.CreateMethodHost): Moved here from
13686 AnonymousMethod and made abstract.
13687 (AnonymousContainer.CreateScopeType): New abstract method.
13688 (AnonymousContainer.IsIterator): New public property.
13689 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13690 get the ScopeTypeBuilder rather than manually defining it here.
13691 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13694 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13695 before RootContext.DefineTypes().
13697 * codegen.cs (EmitContext.RemapToProxy): Removed.
13698 (EmitContext.CurrentAnonymousMethod): Changed type from
13699 AnonymousMethod -> AnonymousContainer.
13700 (EmitContext.ResolveTopBlock): Protect from being called twice.
13701 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13702 (EmitContext.EmitThis): Removed the iterators hacks; use the
13703 anonymous methods framework for that.
13706 (ToplevelBlock.Container): Make this a property, not a field.
13707 (ToplevelBlock.ReParent): New public method; move the
13708 ToplevelBlock into a new container.
13709 (Foreach.TemporaryVariable): Simplify.
13711 2005-06-05 Martin Baulig <martin@ximian.com>
13713 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13714 (Block.AddTemporaryVariable): New public method; creates a new
13715 `LocalInfo' for a temporary variable.
13716 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13718 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13719 non-iterator variables.
13721 2005-06-05 Martin Baulig <martin@ximian.com>
13723 * statement.cs (Foreach.TemporaryVariable): Create the
13724 LocalBuilder in the Emit phase and not in Resolve since in some
13725 situations, we don't have an ILGenerator during Resolve; see
13726 2test-19.cs for an example.
13728 2005-06-04 Martin Baulig <martin@ximian.com>
13730 **** Merged r45395 from GCS ****
13732 The big Foreach rewrite - Part II.
13734 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13735 with `PropertyInfo ienumerator_getcurrent'.
13737 * codegen.cs (VariableStorage): Removed.
13740 (Foreach): Derive from Statement, not ExceptionStatement.
13741 (Foreach.CollectionForeach): New nested class. Moved all the code
13742 dealing with collection foreach here.
13743 (Foreach.ForeachHelperMethods): Removed.
13744 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13746 2005-05-23 Martin Baulig <martin@ximian.com>
13748 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13749 don't need to. Fix #75014.
13751 2005-05-20 Martin Baulig <martin@ximian.com>
13753 Merged r44808 from GMCS.
13755 * class.cs (TypeContainer.CircularDepException): Removed.
13756 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13757 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13758 (CS0146) and interface (CS0529) dependencies here.
13760 2005-06-21 Raja R Harinath <rharinath@novell.com>
13762 * expression.cs (Invocation.EmitCall): Fix initialization
13763 'this_call' to reflect current behaviour. Fix indentation.
13765 * convert.cs (FindMostEncompassedType): Add two trivial special
13766 cases (number_of_types == 0 || number_of_types == 1).
13767 (FindMostEncompasingType): Likewise.
13769 2005-06-17 Raja R Harinath <rharinath@novell.com>
13771 Some cleanups preparing for the fix of #75283.
13772 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13774 (EventExpr.InstanceResolve): Likewise.
13775 (EventExpr.DoResolve): Remove redundant checks.
13777 2005-06-10 Duncan Mak <duncan@novell.com>
13779 * cs-tokenizer.cs (process_directives): New flag for controlling
13780 the processing of preprocessor directives.
13781 (x_token): After seeing a '#', return Token.NONE instead of going
13782 to handle_preprocessing_directive() when not processing
13783 directives. This avoids unnecessary processing during the token peek in
13788 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13789 the existing error reporting methods instead of Report.Error.
13791 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13792 after Raja's rewrite.
13794 2005-06-08 Miguel de Icaza <miguel@novell.com>
13796 * class.cs: Small fix.
13798 2005-06-08 Raja R Harinath <rharinath@novell.com>
13801 * class.cs (GetPartialBases): Fix return value check of
13802 part.GetClassBases.
13804 2005-06-07 Raja R Harinath <rharinath@novell.com>
13806 Ensure that partial classes are registered in their enclosing
13807 namespace. Initial part of fix of #75160.
13808 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13809 Register declspace with namespace here, not in
13810 DeclSpace.RecordDecl.
13811 * cs-parser.jay: Pass namespace to RecordDecl.
13812 * class.cs (PartialContainer.Create): Likewise.
13813 (ClassPart.DefineType): New sanity-check. Throws an exception if
13815 * decl.cs (Declspace.RecordDecl): Remove.
13816 * namespace.cs (NamespaceEntry.DefineName): Remove.
13818 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13820 * rootcontext.cs: Reset TargetExt as well.
13822 2005-06-03 Raja R Harinath <rharinath@novell.com>
13824 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13825 -langversion:ISO-1.
13827 2005-06-02 Raja R Harinath <rharinath@novell.com>
13829 Fix #75080, cs0119.cs.
13830 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13832 (Expression.Resolve): ... this. Use it. Remove bogus code
13833 allowing ExprClass.Type and ExprClass.Namespace for
13834 ResolveFlags.VariableOrValue.
13835 (Expression.Resolve) [1-argument variant]: Change default resolve
13836 flags based on language version.
13837 (Expression.Error_UnexpectedKind): Use a simple string array
13838 rather than an ArrayList.
13839 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13840 not ExprClass.Type.
13841 (TypeOfVoid.DoResolve): Likewise.
13842 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13843 flags argument -- it always has the same value.
13845 2005-05-31 Raja R Harinath <rharinath@novell.com>
13848 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13849 Use it in the error message.
13850 * assign.cs, expression.cs, statement.cs: Update.
13852 2005-05-30 Raja R Harinath <rharinath@novell.com>
13855 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13856 the "almostMatchedMember" case too.
13857 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13858 that failed the accessibility checks to 'almost_match'.
13860 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13862 * attribute.cs: Use internal MethodBuilder methods to set
13863 ExactSpelling and SetLastError on PInvoke methods, instead
13864 of passing them via charset. Fixes #75060.
13866 2005-05-27 Raja R Harinath <rharinath@novell.com>
13868 * parameter.cs (Parameter): Remove TODO comment.
13869 (Parameter.DefineParameter): Remove Location parameter.
13870 (Parameters.LabelParameters): Likewise.
13871 * class.cs (Constructor.Emit): Update to change.
13872 (MethodData.Emit): Likewise.
13873 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13874 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13876 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13879 Removed Parameters.Location and added Parameter.Location instead.
13880 Removed Location parameter from Emit() and GetSignature().
13887 Modified all related calls.
13889 2005-05-26 Raja R Harinath <rharinath@novell.com>
13891 Improve user-defined conversion handling.
13892 * convert.cs (GetConversionOperators): Rewrite. Return only the
13893 applicable operators.
13894 (AddConversionOperators): New. Helper for GetConversionOperators.
13895 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13896 there is only one most encompassed/encompassing type.
13897 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13898 "applicable operator" handling.
13899 (UserConversion): Move cache here from GetConversionOperators.
13900 Directly cache the chosen operator, rather than the whole
13902 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13903 case. Allow conversion of decimal to sbyte and byte too.
13904 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13905 New static methods. Used to avoid allocating EmptyExpressions in
13908 2005-05-24 Duncan Mak <duncan@novell.com>
13910 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13911 another class, used in Convert.ExplicitNumericConversion.
13912 (CastToDecimal): New class, similar to above, but casts to
13913 System.Decimal, used in Convert.ImplicitNumericConversion and also
13914 in explicit convesion from double/float to decimal.
13916 * convert.cs (ImplicitNumericConversion): Handle implicit
13917 conversions to System.Decimal.
13918 (ExplicitNumericConversion): handle explicit conversions to
13923 2005-05-20 Miguel de Icaza <miguel@novell.com>
13925 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13926 know the type at this stage, just break through. Fixes #75008
13928 2005-05-19 Martin Baulig <martin@ximian.com>
13931 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13932 to disable error reporting.
13934 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13935 here since we don't want to report an error; see the new test-336.cs.
13937 2005-05-19 Raja R Harinath <rharinath@novell.com>
13939 * statement.cs (ToplevelBlock.GetParameterReference)
13940 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13941 Move here from class Block.
13942 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13943 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13945 2005-05-18 Martin Baulig <martin@ximian.com>
13950 (FlowBranching.Reachability): Add non-static public And() and Or()
13952 (FlowBranchingSwitch): New class; do the `break_origins' thing
13953 like in FlowBranchingLoop.
13954 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13955 reachability, not just locals and parameters.
13956 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13957 switch; MergeBreakOrigins() now takes care of that.
13959 2005-05-18 Martin Baulig <martin@ximian.com>
13961 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13962 a loop and may leave it, reset the barrier; fixes #74974.
13964 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13966 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13969 * cs-parser.jay: Catch more lexical errors.
13971 * report.cs: Add one more Error method.
13974 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13976 2005-05-17 Martin Baulig <martin@ximian.com>
13978 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13981 2005-05-16 Raja R Harinath <rharinath@novell.com>
13983 Fix test-382.cs. Emit values of decimal constants.
13984 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13986 (TypeContainer.AddField): ... this.
13987 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13988 with initializers to include 'Const's.
13989 (ClassPart.RegisterFieldForInitialization): Forward to
13991 * const.cs (Const.Const): Pass initializer to base class.
13992 (Const.Define): In case of decimal constants, register them for
13993 initialization in a static constructor.
13995 2005-05-14 Martin Baulig <martin@ximian.com>
13997 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13998 do not call ResolveUnreachable() on unreachable statements in
13999 here, see the comment in the source code.
14001 2005-05-13 Raja R Harinath <rharinath@novell.com>
14004 * expression.cs (BinaryResolveOperator): If one of the operands of
14005 an equality comparison is 'null' and the other is a pointer type,
14006 convert the null to a NullPointer.
14007 * convert.cs (ImplicitReferenceConversion): If the expression is a
14008 NullLiteral and the target type is a pointer type, return a
14009 NullPointer instead.
14010 (ImplicitConversionStandard): Likewise.
14012 2005-05-13 Marek Safar <marek.safar@seznam.cz>
14014 * cs-parser.jay: Set readonly context based on special constructs.
14016 * expression.cs (LocalVariableReference.DoResolveBase): Improved
14017 readonly variable error handling.
14019 * rootcontext.cs (EmitCode): Don't verify members when error
14022 * statement.cs (LocalInfo): Add reaodnly context information.
14023 (SetReadOnlyContext, GetReadOnlyContext): New methods.
14025 2005-05-13 Raja R Harinath <rharinath@novell.com>
14027 * statement.cs (Block.Resolve): Revert change below. Modify fix
14028 for #74041 to initialize 'resolved' to false only for explicit
14029 blocks. Fixes #74873.
14031 2005-05-12 Raja R Harinath <harinath@gmail.com>
14034 * typemanager.cs (unmanaged_enclosing_types): New.
14035 (IsUnmanagedType): Avoid infloops by using
14036 'unmanaged_enclosing_types' to talk with recursive invocations.
14038 2005-05-13 Martin Baulig <martin@ximian.com>
14040 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
14041 instance variable, not a local. Fix #74873.
14042 (Block.ResolveUnreachable): Set it to true here.
14044 2005-05-11 Duncan Mak <duncan@novell.com>
14046 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
14047 continuing to process for 'arg'.
14048 (handle_preprocessing_directive): Check the argument of the #endif
14049 directive and report error CS1025 if there are any trailing
14052 According to the C# spec, having even whitespace after the #endif
14053 directive is illegal; however, because we call arg.TrimEnd ()
14054 beforehand, we have the same behavior as csc, allowing whitespace
14055 after the directive.
14059 2005-05-11 Marek Safar <marek.safar@seznam.cz>
14063 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
14064 (Constructor.GetObsoleteAttribute): Implemented correctly.
14066 2005-05-10 Martin Baulig <martin@ximian.com>
14068 * support.cs (ReflectionParameters.ParameterModifier): Use
14069 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
14070 and `ParameterAttributes.In'. Fixes #74884.
14072 2005-05-10 Marek Safar <marek.safar@seznam.cz>
14074 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
14076 * expression.cs (Argument.GetParameterModifier): Turned to property.
14077 (Invocation.Error_InvalidArguments): Add more descriptive errors.
14079 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
14082 2005-05-09 Raja R Harinath <rharinath@novell.com>
14085 * decl.cs (MemberCache.AddMethods): Register override methods,
14086 rather than non-override methods.
14087 * typemanager.cs (RegisterOverride): New.
14088 (IsOverride): Update.
14090 2005-05-09 Marek Safar <marek.safar@seznam.cz>
14094 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
14095 recursive declaration.
14097 * statement.cs (Block.ResolveMeta): Report any error in resolving.
14099 2005-05-06 Marek Safar <marek.safar@seznam.cz>
14101 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
14103 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
14105 2005-05-05 Raja R Harinath <rharinath@novell.com>
14108 * decl.cs (DeclSpace.FamilyAccessible):
14109 Use TypeManager.IsNestedFamilyAccessible.
14111 Fix reopened #64812.
14112 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
14115 2005-05-04 Raja R Harinath <rharinath@novell.com>
14116 Abin Thomas <projectmonokochi@rediffmail.com>
14117 Anoob V E <projectmonokochi@rediffmail.com>
14118 Harilal P R <projectmonokochi@rediffmail.com>
14121 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
14122 allow access to all static members.
14124 2005-05-04 Martin Baulig <martin@ximian.com>
14126 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
14128 2005-05-04 Martin Baulig <martin@ximian.com>
14132 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
14133 section at the end; make things work if `default' is not the last
14136 2005-05-04 Martin Baulig <martin@ximian.com>
14140 * statement.cs (Switch): Replaced the `got_default' field with a
14141 `default_section' one.
14142 (Switch.CheckSwitch): Set `default_section' here.
14143 (Switch.Resolve): If we're a constant switch and the constant is
14144 not found, use the default section.
14146 2005-05-03 Martin Baulig <martin@ximian.com>
14148 * expression.cs (ArrayAccess.EmitGetLength): New public method.
14150 * statement.cs (Foreach.ArrayForeach): New nested class.
14151 (Foreach.TemporaryVariable): New nested class.
14152 (Foreach.EmitArrayForeach): Removed; this is now in the new
14153 ArrayForeach class.
14155 2005-05-03 Raja R Harinath <rharinath@novell.com>
14157 * pending.cs (BaseImplements): Move the #74773 fix here. This is
14159 (VerifyPendingMethods): Revert change below.
14161 * typemanager.cs (IsOverride, RegisterNonOverride): New.
14162 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
14163 that used to trigger warning -28. Remove warning -28.
14164 * expression.cs (Invocation.OverloadResolve): Use
14165 TypeManager.IsOverride to distinguish override methods.
14168 * pending.cs (VerifyPendingMethods): If a base type implements the
14169 requested interface, don't bother checking individual methods of
14170 the base type. As a side-effect, this prevents the creation of
14171 unnecessary proxies.
14173 2005-05-02 Martin Baulig <martin@ximian.com>
14177 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
14178 Also `And' the locals if the old vector is null.
14179 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
14180 null; in this case we basically reset all the variables.
14182 2005-05-02 Martin Baulig <martin@ximian.com>
14186 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
14187 Added `FlowBranching branching' argument; always `and' the
14188 variables instead of `or'ing them unless we're an infinite loop.
14190 * statement.cs (While.Resolve): Create a new sibling unless we're
14193 2005-05-02 Martin Baulig <martin@ximian.com>
14197 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
14198 arguments; use it instead of creating a new TopLevelBlock.
14199 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
14200 our ConstructorInitializer.
14203 (TopLevelBlock.TopLevelBranching): New public property.
14204 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
14205 and create our `TopLevelBranching'.
14207 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
14208 anonymous method host, use `block.TopLevelBranching' rather than
14209 creating a new branching.
14211 2005-04-20 Miguel de Icaza <miguel@novell.com>
14213 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
14214 a ScopeInfo, if any of the current children is a child of the new
14215 entry, move those children there.
14217 2005-04-30 Martin Baulig <martin@ximian.com>
14219 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
14220 at the beginning of a SwitchSection. Fix #73335.
14222 2005-04-27 Marek Safar <marek.safar@seznam.cz>
14225 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
14227 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
14228 (FieldExpr.DoResolve): Obsolete members are ignored for field
14231 2005-04-26 Marek Safar <marek.safar@seznam.cz>
14233 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
14234 of arrays detection.
14236 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
14238 (Field.VerifyClsCompliance): Volatile fields are not compliant.
14240 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
14243 2005-04-25 Ben Maurer <bmaurer@ximian.com>
14245 * cs-parser.jay: Use the prefered version of -unsafe in error
14248 2005-04-22 Marek Safar <marek.safar@seznam.cz>
14250 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
14253 2005-04-20 John Luke <john.luke@gmail.com>
14255 * driver.cs: fix typo in error message, --outout to --output
14257 2005-04-20 Marek Safar <marek.safar@seznam.cz>
14259 * codegen.cs (InRefOutArgumentResolving): New field.
14261 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
14262 fields outside contructor.
14264 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
14266 2005-04-19 Miguel de Icaza <miguel@novell.com>
14268 * anonymous.cs (CaptureContext.EmitParameterInstance): The
14269 parameter code was not completed ever, so it was not as up-to-date
14270 as local variables. Must finish it.
14272 The bug fix was to compare the Toplevel of the block, not the
14273 current block. Thanks for Ben for pointing this out.
14275 2005-04-19 Raja R Harinath <rharinath@novell.com>
14277 * decl.cs (AddMethods): Use the declaring type of the problem
14278 method to determine if we want to squash a warning.
14280 2005-04-19 Marek Safar <marek.safar@seznam.cz>
14282 * attribute.cs: Removed debug output.
14284 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
14286 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
14289 2005-04-18 Raja R Harinath <rharinath@novell.com>
14292 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
14293 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
14294 all null comparisons against reference types.
14296 2005-04-18 Marek Safar <marek.safar@seznam.cz>
14299 * class.cs (TypeContainer.CircularDepException) New nested
14301 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
14302 (TypeContainer.DefineType): Removed error, reset InTransit before
14304 (Class.DefineType): Throw exception when is in Transit.
14305 Catch exception and report error.
14306 (Struct.DefineType): Throw exception when is in Transit.
14307 Catch exception and report error.
14308 (Interface.DefineType): Throw exception when is in Transit.
14309 Catch exception and report error.
14311 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
14312 handle nested exception handlers.
14314 * flowanalysis.cs (InTryWithCatch): New method, search for try with
14317 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
14318 InFinally and InCatch storage.
14320 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
14321 (Catch.Resolve): Set and Restore ec.InCatch.
14322 (Try.Resolve): Set and Restore ec.InFinally.
14323 (Try.HasCatch): True when try has catch.
14325 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
14327 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
14328 for the same event member, so exclude such cases from warning 419.
14331 2005-04-16 Miguel de Icaza <miguel@novell.com>
14333 * expression.cs (Binary.ResolveOperator): Apply patch from John
14334 Luke to fix bug 59864: operators &, | and ^ on enumerations
14335 require that the same enum type on both sides.
14337 * driver.cs: Add warnings to old flag usage, this is to assist
14338 people who produce Makefiles and hope that the Makefiles will be
14341 * class.cs (TypeContainer.EmitType): Moved the definition of the
14342 special $PRIVATE$ field from the resolve phase to the Emit phase.
14343 During resolve we do not know if we are a struct with
14344 HasExplicitLayout, we know this only after the attributes for the
14347 Set the FieldOffset to zero on the dummy field that we create for
14348 the class. Fixes 74590.
14350 2005-04-16 Raja R Harinath <rharinath@novell.com>
14353 * ecore.cs (PropertyExpr.resolved): New.
14354 (DoResolve): Use it to handle a case of double resolution here.
14355 Handle a case of identical-name-and-type-name.
14356 * expression.cs (ArrayCreation.CheckIndices): Avoid double
14357 resolution by storing the results of expression resolution back
14358 into the "probes" array.
14360 2005-04-15 Raja R Harinath <rharinath@novell.com>
14362 Fix cs0208-7.cs and cs0208-8.cs.
14363 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14364 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14365 error reporting to point out the reason a struct is not unmanaged.
14367 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14369 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14370 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14372 2005-04-13 Raja R Harinath <rharinath@novell.com>
14375 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14376 IdenticalNameAndTypeName here.
14377 (EventExpr.InstanceResolve): Likewise.
14379 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14381 C# 2.0 DefaultCharSetAttribute implementation
14383 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14384 which allows us to set GlobalNamespace for every resolve.
14385 (Attribute.ResolveArguments): Cut from Resolve.
14386 (Attribute.GetCharSetValue): Returns CharSet named argument.
14387 (Attribute.DefinePInvokeMethod): Gets default charset from
14389 (GlobalAttribute.ResolveAsTypeStep): Override.
14390 (GlobalAttribute.ResolveArguments): Override.
14392 * class.cs (TypeAttr): Is protected.
14394 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14395 (ModuleClass.DefaultCharSetType): New memeber.
14396 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14398 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14399 charset from module.
14401 * delegate.cs (TypeAttr): Override.
14402 (Delegate.DefineType): Use this TypeAttr.
14404 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14405 at very early stage (before types are defined) to resolve model
14406 module attributes. It will probably not work with corlib but it
14409 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14410 charset from module.
14412 * typemanager.cs (default_charset_type): New type.
14414 2005-04-13 Raja R Harinath <rharinath@novell.com>
14416 * decl.cs (MemberCache.AddMethods): Don't warn if
14417 System.Object.Finalize has buggy MethodAttributes.
14419 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14422 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14424 * doc.cs : detect ambiguous reference to overloaded members.
14425 Fixed bug #71603. MS 1.1 csc does not detect it.
14427 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14429 * doc.cs : delegates must not be referenced with parameters.
14432 2005-04-12 Miguel de Icaza <miguel@novell.com>
14434 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14436 2005-04-10 Miguel de Icaza <miguel@novell.com>
14438 * driver.cs (MainDriver): Stop processing if the CLS stage found
14441 (CompilerCallableEntryPoint.InvokeCompiler): Always
14442 reset after execution; Take a TextWriter argument for the
14445 * report.cs: Use the error stream instead of hardcoding stderr.
14447 2005-04-09 Miguel de Icaza <miguel@novell.com>
14449 * class.cs: Reduce code paths to test, too small of an
14450 optimization to make it worth the extra testing. Always perform
14453 2005-04-08 Raja R Harinath <rharinath@novell.com>
14456 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14457 operators that had errors reported on them.
14459 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14461 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14463 (Attribute.Resolve): Add named argument type checking.
14465 * class.cs (FixedField.Define): Use IsPrimitiveType
14467 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14469 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14470 unsafe parameter types.
14472 * statement.cs (Using.ResolveExpression): Add better error description.
14474 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14476 2005-04-08 Raja R Harinath <rharinath@novell.com>
14479 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14480 AttributeUsageAttribute in the emitcontext of the attribute class,
14481 not in the emitcontext of the attributable entity it was attached to.
14482 * cs-parser.jay: Use 'current_class', not 'current_container',
14483 when creating a GlobalAttribute.
14485 2005-04-08 Alp Toker <alp@atoker.com>
14487 * pending.cs: The fix to #58413 failed to compile methods implementing
14488 interfaces with/without params modifiers and vice versa, even though
14489 params modifiers aren't part of the signature. Make the modifier check
14490 less strict as in csc.
14492 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14493 Anoob V E <projectmonokochi@rediffmail.com>
14494 Harilal P R <projectmonokochi@rediffmail.com>
14497 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14498 modifiers of pending methods.
14499 (PendingImplementation.PendingImplementation): Initialize it.
14500 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14501 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14502 with ParameterData. Add check for modifiers.
14503 * class.cs (MethodData.Define): Update to changes.
14505 2005-04-07 Raja R Harinath <rharinath@novell.com>
14507 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14509 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14511 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14514 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14517 * typemanager.cs: Registered RequiredAttributeAttribute.
14519 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14521 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14522 Warning CS0169 is back at level 3.
14523 (IMethodData.SetMemberIsUsed): New method.
14525 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14526 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14528 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14530 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14532 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14535 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14538 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14539 to avoid the problems with nested types.
14541 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14542 Anoob V.E <projectmonokochi@rediffmail.com>
14543 Harilal P.R <projectmonokochi@rediffmail.com>
14544 Raja R Harinath <rharinath@novell.com>
14547 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14549 * typemanager (GetConstructor): Make public.
14551 2005-04-05 John Luke <john.luke@gmail.com>
14552 Raja R Harinath <rharinath@novell.com>
14555 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14556 struct too. Return false quicker in a few cases.
14557 (VerifyUnManaged): Use it.
14559 2005-04-05 Raja R Harinath <rharinath@novell.com>
14562 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14563 not 'unreachable_seen'.
14565 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14567 * attribute.cs (Attribute.GetValue): Removed unused.
14569 * codegen.cs (CodeGen.TrimExt): Removed unused.
14571 * cs-parser.jay (output): Removed unused.
14573 * cs-tokenizer.cs (hex_digits): Removed unused.
14575 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14577 * expression.cs (Indirection.LoadExprValue): Removed unused.
14578 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14580 * iterators.cs (Iterator.param_types): Removed unused.
14582 * statement.cs (Goto.block): Removed unused.
14583 (ToplevelBlock.did): Removed unused.
14584 (Switch.ResolveConstantSwitch): Removed unused.
14586 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14588 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14591 2005-04-01 Raja R Harinath <rharinath@novell.com>
14593 Fix #74232 and cs0208-3.cs.
14594 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14595 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14596 unmanaged type. Don't use FieldBuilders when 't' is a
14597 TypeBuilder. Use ModFlags and MemberType fields.
14598 * class.cs (MemberBase.member_type): Rename from MemberType.
14599 (MemberBase.MemberType): New property. Determines member_type on
14601 (MemberBase.DoDefine): Don't initialize MemberType here.
14602 (FieldMember.Define): Likewise.
14604 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14607 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14608 Attributes are emitted there.
14610 2005-04-01 Raja R Harinath <rharinath@novell.com>
14612 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14613 keyword in 'partial enum' too.
14614 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14616 Report from Kamil Skalski <nazgul@omega.pl>.
14619 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14620 have partial containers too.
14622 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14623 in block' checks to Block.CheckInvariantMeaningInBlock.
14624 * statement.cs (Block.GetKnownVariableInfo): Make private.
14625 (Block.IsVariableUsedInChildBlock): Remove.
14626 (Block.IsVariableUsedInBlock): Likewise.
14627 (Block.CheckInvariantMeaningInBlock): New. Show location of
14628 conflicting declaration.
14629 (Block.AddVariable): Make error messages less long-winded and more
14630 specific. Show location of conflicting declaration.
14631 * parameter.cs (Parameters.Location): New readonly property.
14633 2005-03-31 Raja R Harinath <rharinath@novell.com>
14635 Clean up semantics of invoking ResolveMemberAccess.
14636 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14637 can have an instance, ensure that we pass in a non-TypeExpression
14638 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14639 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14640 argument. Update to changes and simplify.
14641 (FieldExpr.Emitinstance): Remove CS0120 check.
14642 (PropertyExpr.EmitInstance): Likewise.
14643 * expression.cs (Argument.Resolve): Likewise.
14644 (Invocation.DoResolve): Update to changes in semantics of
14645 InstanceExpression.
14647 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14650 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14653 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14655 2005-03-31 Raja R Harinath <rharinath@novell.com>
14657 Fix difference in behaviour with commandline invocation.
14658 * driver.cs (Driver.Reset): New.
14659 (CompilerCallableEntryPoint): Call it.
14661 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14662 variable" warnings if the boolean expression failed to resolve.
14664 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14666 * attribute.cs: Fix the union of several permissions when some of them
14667 are unrestricted (so the result isn't an unrestricted permission set).
14670 2005-03-30 Raja R Harinath <rharinath@novell.com>
14672 * ecore.cs (MemberExpr): New class. Convert from interface
14674 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14675 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14677 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14678 (MethodGroupExpr.IsExplicitImpl): Remove.
14679 (Expression.GetFieldFromEvent): Remove.
14680 (SimpleName.MemberStaticCheck): Remove.
14681 (SimpleName.DoSimpleNameResolve): Update to changes.
14682 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14683 (MemberAccess.IdenticalNameAndTypeName): Remove.
14684 (MemberAccess.error176): Move to MemberExpr.
14685 (MemberAccess.DoResolve): Update to changes.
14686 (BaseAccess.DoResolve): Likewise.
14688 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14690 C# 2.0 Conditional attribute class implementation
14692 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14693 Analyzes class whether it has attribute which has ConditionalAttribute
14694 and its condition is not defined.
14696 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14697 (Class.IsExcluded): New method. Search for at least one defined
14698 condition in ConditionalAttribute of attribute class.
14700 2005-03-30 Raja R Harinath <rharinath@novell.com>
14702 * ecore.cs (PropertyExpr): Derive from Expression, not
14703 ExpressionStatement.
14704 (PropertyExpr.EmitStatement): Remove.
14706 2005-03-29 Raja R Harinath <rharinath@novell.com>
14709 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14710 internal field "value__" of an enum be private. The examples for
14711 "value__" that I found on MSDN all used FieldAttributes.Private.
14713 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14714 Don't mention IL method attribute names.
14716 Fix #47991. Remove a TODO.
14717 * statement.cs (Block.Toplevel): Make into a field.
14718 (Block.Parameters): Move into ToplevelBlock.
14719 (Block.known_variables): Rename from child_variable_names.
14720 (Block.Block): Remove variants that take Parameters. Initialize
14721 'Toplevel' with the immediately surrounding toplevel block.
14722 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14723 LocalInfo parameter.
14724 (Block.GetKnownVariableInfo): New.
14725 (Block.IsVariableNameUsedInChildBlock): Update.
14726 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14727 the block, even though it may not be in scope.
14728 (Block.AddVariable): Remove Parameters parameter. Use
14729 Toplevel.Parameters instead.
14730 (Block.AddConstant): Remove Parameters parameter.
14731 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14732 (Block.IsParamaterReference): Likewise.
14733 (Block.IsLocalParameter): Likewise. Simplify a lot.
14734 (ToplevelBlock.Parameters): New. Moved from Block.
14735 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14736 initialize Parameters to a non-null value.
14737 * cs-parser.jay: Update to changes.
14738 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14739 simple names that mean different things in the same block. Use
14740 Block.IsVariableNameUsedInBlock.
14742 2005-03-28 Raja R Harinath <rharinath@novell.com>
14744 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14745 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14746 GetTypeHandle. It is possible for a reflected type to derive from
14747 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14748 System.Array during mscorlib compilation).
14749 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14750 contain a method_hash, don't create one either. Don't create a
14751 deep copy of the base cache's method_hash.
14752 (MemberCache.SetupCache): Rename back from DeepCopy.
14753 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14754 already initialized. If we see an override function, add its
14755 underlying base virtual function to the member_hash too.
14757 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14759 2005-03-26 Raja R Harinath <harinath@acm.org>
14762 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14763 fails to resolve, ensure that the LHS is still resolved as an
14766 2005-03-25 Raja R Harinath <harinath@acm.org>
14768 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14770 (Enum.current_ec): Remove.
14771 (Enum.LookupEnumValue): Remove EmitContext argument.
14772 Just uses the one created during DefineType.
14773 (Enum.FindMembers): Update.
14774 * expression.cs (MemberAccess.DoResolve): Update.
14776 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14778 * assign.cs (Assign.DoResolve): Check for CS1717 when
14779 source and target are same (uses Equals).
14781 * expression.cs (LocalVariableReference, ParameterReference,
14782 This): Implemented Equals, GetHashCode.
14784 * statement.cs (Block.GetParameterReference): Removed useless
14787 2005-03-22 Raja R Harinath <rharinath@novell.com>
14790 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14791 blocks before deciding whether the error is cs0136 or cs0128.
14793 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14794 (using_alias_directive, using_namespace_directive): Pass
14795 MemberName, not an expression to Namespace.UsingAlias and
14797 (MakeName): Use the MemberName of the namespace.
14798 * namespace.cs (Namespace.MemberName): New.
14799 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14800 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14802 * decl.cs (MemberName.Name): Make readonly.
14803 (MemberName.FromDotted): New "constructor".
14804 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14805 (MemberCore.Name): Compute from MemberName on demand.
14806 (MemberCore.SetMemberName): Provide a way to change the
14808 (MemberCore.AddToContainer): Don't take a fullname parameter.
14809 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14810 fully qualified name of the container to the member name.
14811 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14812 only if the type is a member of the root container.
14813 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14814 MemberName.Left rather than searching for an embedded ".".
14815 (PartialContainer.CreatePart): Update to changes in RootContext.
14816 (MemberBase.ShortName): Turn into a property. Use
14817 MemberCore.SetMemberName.
14818 (MemberBase.ExplicitInterfaceName): Remove.
14819 (MemberBase.UpdateMemberName): Remove.
14820 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14821 (PropertyBase.SetMemberName): New override.
14822 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14823 (Tree.GetDecl): New.
14824 (Tree.AllDecls): Rename from Decls.
14825 * attribute.cs, enum.cs, report.cs: Update to changes.
14826 * driver.cs (MainDriver): Use MemberName.FromDotted on
14827 RootContext.MainClass.
14829 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14831 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14834 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14836 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14838 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14839 property accessor modifiers.
14841 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14842 fixed buffer attribute (CS1716).
14843 (PropertyMethod.HasCustomAccessModifier): When property accessor
14844 has custom modifier.
14846 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14848 (PropertyExpr.DoResolveLValue): Add CS0272.
14850 2005-03-17 Miguel de Icaza <miguel@novell.com>
14852 * convert.cs: When converting to a pointer, use the proper Conv.U
14853 or Conv.I depending on the source data type.
14855 * cs-tokenizer.cs: Make the size for large decimal constants,
14858 2005-03-17 Martin Baulig <martin@ximian.com>
14860 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14861 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14863 2005-03-17 Martin Baulig <martin@ximian.com>
14865 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14866 to bool so we can return an error condition.
14867 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14870 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14872 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14875 2005-03-16 Raja R Harinath <rharinath@novell.com>
14877 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14878 Refactor to avoid traversing the list of assemblies, and to avoid
14879 string concatenation.
14880 * typemanager.cs (guid_attr_type): Remove.
14881 (negative_hits, pointers, references): Remove hashes.
14883 (GetConstructedType): New. Uses type_hash to handle constructed
14884 types (arrays, references, pointers).
14885 (GetReferenceType, GetPointerType): Use it.
14886 (GetNestedType): New. Uses type_hash to handle nested types of
14888 (LookupType, LookupTypeDirect): Remove.
14889 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14890 'types' hash and LookupTypeReflection directly.
14891 (params_string, params_object): Use GetConstructedType.
14892 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14894 (Namespace.Lookup): Use cached_types.
14895 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14896 provided by old TypeManager.LookupType.
14897 * rootcontext.cs (MakeFQN): Remove.
14898 * decl.cs (DeclSpace.MakeFQN): Likewise.
14899 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14900 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14901 TypeManager.GetConstructedType.
14902 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14904 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14906 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14909 * cs-parser.jay: Reports CS1527 for any namespace element.
14911 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14914 * expression.cs (ParameterReference.IsAssigned): Changed error to
14916 (Error_WrongNumArguments): Moved CS0245 detection here.
14918 * statement.cs (Return.Resolve): Add CS1622 report.
14920 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14922 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14924 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14926 * attribute.cs expression.cs: Get rid of some allocations.
14928 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14930 * doc.cs : just eliminate the latest change.
14932 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14934 * doc.cs : commented out the latest change. It breaks xml-030.cs
14936 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14938 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14939 fail. So invoke CreateType() in FindDocumentedType().
14941 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14943 * cs-tokenizer.cs : added IsKeyword().
14944 * doc.cs : Detect keyword incorrectly used as identifier.
14945 Allow identifiers prefixed by @.
14947 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14949 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14950 It caused exception in namespace resolving (again!).
14952 * class.cs (Class.ctor): Removed exit.
14953 (PropertyMethod.ctor): ditto.
14955 * codegen.cs (Codegen.Reset): Reset static data.
14956 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14958 * cs-tokenizer.cs (Cleanup): Removed.
14960 * driver.cs (GetSystemDir): Rewrote to one line command.
14961 It caused problem with unloaded dynamic modules.
14962 (UnixParseOption): Removed Exit.
14963 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14964 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14965 Now can be mcs used as library.
14967 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14970 * location.cs (Reset): Reset static data.
14972 * namespace.cs (Reset): Reset static data.
14974 * report.cs (Report.Reset): Reset static data.
14976 * rootcontext.cs (RootContext.Reset): Reset static data.
14978 * tree.cs (RootTypes.ctor): Use Location.Null
14980 * typemanager.cs (TypeManager.Reset): Reset static data.
14981 (CoreLookupType): Removed Exit.
14982 (TypeHandle.Reset): Reset static data.
14984 2005-03-10 Raja R Harinath <rharinath@novell.com>
14987 * typemanager.cs (ComputeNamespaces): Import namespaces from
14988 referenced modules too.
14990 2005-03-09 Raja R Harinath <rharinath@novell.com>
14992 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14995 2005-03-09 Raja R Harinath <rharinath@novell.com>
14997 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14998 enclosing DeclSpace. This ensures that a name-lookup populates
14999 more caches and there are fewer 'TypeExpression's. Carve out
15000 nested type lookup into ...
15001 (LookupNestedTypeInHierarchy): ... this.
15003 2005-03-09 Raja R Harinath <rharinath@novell.com>
15005 Clean up a few partial-class semantics.
15006 Fixes test-357.cs and cs1618-2.cs.
15007 * cs-parser.jay (struct_declaration): Use 'current_class' as
15008 parent of newly-created struct. Remove call to Register ().
15009 Use 'pop_current_class' to complete handing the current struct.
15010 (interface_declaration): Likewise.
15011 (class_declaration): Likewise.
15012 (enum_declaration): Use 'current_class' as parent of newly created
15014 (delegate_declaration): Likewise.
15015 (pop_current_class): New function. This is used to handle closing
15016 up the 'current_class' and 'current_container', and pointing them
15017 to the enclosing class/container.
15018 (CSharpParser): Initialize 'current_class' too.
15019 * decl.cs (MemberCore): Add check for invariant: a partial
15020 container is not a parsed entity, and thus does not enclose any
15022 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
15023 (DeclSpace.BaseTypeExpr): Use it.
15024 (DeclSpace.LookupType): Add check for invariant.
15025 * class.cs (TypeContainer): Add check for invariant: a nested
15026 class should have the same NamespaceEntry as its enclosing class.
15027 (TypeContainer.EmitFieldInitializers): Make virtual.
15028 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
15030 (TypeContainer.Register): Remove.
15031 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
15032 null. Use TypeResolveEmitContext for resolving base types and
15033 interfaces. Move initialization of Parts.TypeBuilder here from
15035 (TypeContainer.DefineNestedTypes): ... here.
15036 (PartialContainer): Take a Namespace not a NamespaceEntry.
15037 (PartialContainer.Create): Don't use Register. Call the
15038 appropriate Add... function directly.
15039 (ClassPart): Take both the PartialContainer and the enclosing
15040 class as constructor arguments.
15041 (ClassPart.EmitFieldInitializers): Override.
15042 (ClassPart.PartFindNestedTypes): Remove.
15043 (FieldBase.GetInitializerExpression): Resolve the initializer
15044 expression in the emit context of the enclosing class.
15045 * tree.cs (RootTypes): Remove Register ().
15047 2005-03-08 Marek Safar <marek.safar@seznam.cz>
15049 * cs-parser.jay: Removed CS0134.
15051 * driver.cs: Removed CS1901.
15053 * expression.cs (SizeOf.DoResolve): Don't report CS0233
15054 for predefined types.
15056 2005-03-07 Duncan Mak <duncan@novell.com>
15058 * codegen.cs (Save): Catch UnauthorizedAccessException as
15059 well. Fixes bug #73454.
15061 2005-03-07 Marek Safar <marek.safar@seznam.cz>
15063 * cs-tokenizer.cs (xtoken): Add CS1035.
15065 * class.cs (MethodData.Define): Add CS0683.
15066 (FieldMember.ctor): Add CS0681.
15068 2005-03-07 Raja R Harinath <rharinath@novell.com>
15070 * ecore.cs (SimpleName.DoResolve): Rename from
15071 SimpleName.DoResolveAllowStatic.
15072 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
15073 Pass 'intermediate' flag to MemberStaticCheck.
15074 (SimpleName.MemberStaticCheck): Skip "static check" only in case
15075 of "intermediate" lookups via MemberAccess.
15076 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
15077 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
15079 2005-03-07 Raja R Harinath <rharinath@novell.com>
15082 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
15083 slipped in because of variable names that are identical to a
15084 builtin type's BCL equivalent ('string String;', 'int Int32;').
15085 (PropertyExpr.EmitInstance): Likewise.
15087 2005-03-04 Marek Safar <marek.safar@seznam.cz>
15089 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
15091 * report.cs (warning_ignore_table): Made public.
15093 2005-03-04 Raja R Harinath <rharinath@novell.com>
15096 * class.cs (MethodData.Emit): Pass 'container' to
15097 container.GetObsoleteAttribute instead of 'container.Parent'.
15099 2005-03-03 Marek Safar <marek.safar@seznam.cz>
15101 * cs-parser.jay: Add 1534 error test.
15103 * iterators.cs (Yield.CheckContext): Add error 1629.
15104 (Iterator.ctor): Save unsafe modifier.
15105 (MoveNextMethod.DoEmit): Restore unsafe context.
15107 * namespace.cs (UsingAlias): Better error message.
15109 2005-03-03 Dan Winship <danw@novell.com>
15111 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
15112 the warning message [#73219]
15114 2005-03-03 Raja R Harinath <rharinath@novell.com>
15116 Fix compile with MCS 1.0.0.0.
15117 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
15118 w_restore to not depend on string constant folding.
15120 2005-03-03 Raja R Harinath <rharinath@novell.com>
15122 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
15123 CS0246 check to users who passed 'silent = false'.
15124 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
15126 (SimpleName.SimpleNameResolve): Update.
15127 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
15128 (MemberAccess.IdenticalNameAndTypeName): Update.
15129 * doc.cs (FindDocumentedTypeNonArray): Update.
15131 2005-03-03 Raja R Harinath <rharinath@novell.com>
15133 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
15134 * parameters.cs (ComputeAndDefineParameters): Remove.
15135 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
15136 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
15137 Use GetParameterInfo.
15139 2005-03-02 Marek Safar <marek.safar@seznam.cz>
15141 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
15143 2005-03-02 Raja R Harinath <rharinath@novell.com>
15145 Unify DeclSpace.LookupType and DeclSpace.FindType.
15146 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
15147 is in charge of defining nested types on demand.
15148 (DeclSpace.LookupType): Use it when the current_type is a
15149 TypeBuilder. Use LookupTypeDirect for reflected types.
15150 (DeclSpace.FindType): Remove.
15151 (DeclSpace.LookupInterfaceOrClass): Likewise.
15152 (DeclSpace.DefineTypeAndParents): Likewise.
15153 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
15154 DeclSpace.LookupType.
15155 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
15156 * typemanager.cs (LookupType): Simplify.
15157 (AddUserType): Remove type from negative_hits.
15158 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
15159 * class.cs (TypeContainer.FindMembers): Move handling of nested
15161 (TypeContainer.FindMembers_NestedTypes): ... here.
15162 (TypeContainer.FindNestedType): Implement override.
15163 (ClassPart.FindNestedType): Delegate to PartialContainer.
15164 (ClassPart.PartFindNestedType): Looks up the nested types of the
15167 2005-03-02 Martin Baulig <martin@ximian.com>
15169 * class.cs (TypeContainer.DoDefineMembers): We also need a default
15170 static constructor in static classes.
15172 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
15174 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
15175 sizeParamIndex is not specified.
15177 2005-03-01 Marek Safar <marek.safar@seznam.cz>
15180 * report.cs (WarningMessage.IsEnabled): Missing null check.
15182 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15184 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
15185 in the fields and not in the properties.
15187 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
15189 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
15192 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15194 * attribute.cs: Small refactoring (improved robustness).
15195 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
15196 (ValidateGuid): Removed.
15197 (Resolve): Removed referenced to above mentioned.
15198 (GetAttributeUsage): Made private and changed to work without
15200 (GetIndexerAttributeValue): Don't crash.
15201 (GetConditionalAttributeValue): Ditto.
15202 (GetClsCompliantAttributeValue): Ditto.
15203 (ExtractSecurityPermissionSet): All attributes exceptions are
15205 (GetPropertyValue): New helper.
15206 (GetMethodImplOptions): New method.
15207 (DefinePInvokeMethod): Reuse common code. Implemented handling of
15208 some missing properties.
15210 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
15211 (Method.ApplyAttributeBuilder): Updated.
15213 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
15216 2005-02-28 Raja R Harinath <rharinath@novell.com>
15219 * report.cs (Report.SymbolRelatedToPreviousError): Handle
15220 non-simple types (array, pointer, reference).
15222 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15224 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
15226 * class.cs (MethodCore.IsDuplicateImplementation): Special error
15228 (Method.CheckBase): Catch wrong destructor here.
15229 (MethodData.Define): Add errors 550, 668.
15231 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
15233 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
15235 * pending.cs (VerifyPendingMethods): Add error 551.
15237 * typemanager.cs (CSharpName): Next error report helper.
15239 2005-02-25 Marek Safar <marek.safar@seznam.cz>
15241 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
15242 attributes. Removed useless attribute double check.
15243 It saves almost 2MBs for corlib.
15245 2005-02-25 Raja R Harinath <rharinath@novell.com>
15248 * statement.cs (ExpressionStatement.Resolve): Make robust to being
15249 called twice in case of error.
15251 2005-02-23 Chris Toshok <toshok@ximian.com>
15253 Fix compiler portions of #72827.
15254 * statement.cs (Block.Emit): call Begin/EndScope on the
15255 EmitContext instead of the ILGenerator.
15257 * codegen.cs (EmitContext.BeginScope): new method, call
15258 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
15260 (EmitContext.BeginScope): same, but EndScope and CloseScope
15262 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
15263 offset and call the superclass's OpenScope(int) with it.
15264 (SymbolWriter.CloseScope): get the current il
15265 offset and call superclass's CloseScope(int) with it.
15267 2005-02-23 Marek Safar <marek.safar@seznam.cz>
15269 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
15270 CS1677 for out and ref as well.
15272 * class.cs (Method.Define): Add error CS1599 detection.
15274 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
15276 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
15278 * delegate.cs (Delegate.Define): Add error CS1599 detection.
15280 * support.cs.cs (ModifierDesc): New helper method.
15282 2005-02-23 Raja R Harinath <rharinath@novell.com>
15283 Abin Thomas <projectmonokochi@rediffmail.com>
15284 Anoob V E <projectmonokochi@rediffmail.com>
15285 Harilal P R <projectmonokochi@rediffmail.com>
15287 Fix #57851, #72718.
15288 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
15289 MemberLookup (used for error reporting) actually returns a result.
15290 Fix error report number (122, not 112).
15292 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
15293 Anoob V E <projectmonokochi@rediffmail.com>
15294 Harilal P R <projectmonokochi@rediffmail.com>
15297 * pending.cs (PendingImplementation.GetAbstractMethods):
15298 Find NonPublic members too.
15300 2005-02-22 Marek Safar <marek.safar@seznam.cz>
15302 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
15305 * class.cs (MethodCore.CheckMethodAgainstBase):
15306 Add error 239 report.
15308 2005-02-21 Raja R Harinath <rharinath@novell.com>
15311 * expression.cs (Invocation.IsApplicable): Make public.
15312 (Invocation.IsParamsMethodApplicable): Likewise.
15313 * delegate.cs (Delegate.VerifyApplicability): Don't use
15314 Invocation.VerifyArgumentCompat for parameter applicability
15315 testing. Use Invocation.IsApplicable and
15316 Invocation.IsParamsMethodApplicable.
15318 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15320 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
15322 * class.cs (Operator.Define): Add error 217 report.
15324 2005-02-21 Raja R Harinath <rharinath@novell.com>
15326 * namespace.cs (UsingEntry.Resolve): Undo change below.
15328 2005-02-21 Raja R Harinath <rharinath@novell.com>
15331 * ecore.cs (Expression.MemberLookupFailed): Add argument to
15332 disable the error message when the extended MemberLookup also
15334 (Expression.MemberLookupFinal): Update.
15335 (SimpleName.DoSimpleNameResolve): Update.
15336 * expression.cs (MemberAccess.ResolveNamespaceOrType):
15337 Don't use MemberLookupFinal.
15338 (New.DoResolve): Update.
15339 (BaseAccess.CommonResolve): Update.
15341 2005-02-21 Raja R Harinath <rharinath@novell.com>
15344 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
15345 occured previously, don't resolve again.
15347 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15350 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
15351 argument. Call ResolveAttributeUsage for unresolved.
15352 when types doesn't match ctor arguments.
15354 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
15355 for nested attribute classes.
15356 (Class.attribute_usage): Removed.
15357 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
15358 for attribute class.
15360 * ecore.cs (IsAttribute): Removed.
15362 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15364 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15366 (attribute_types): Removed.
15367 (EmitCode): Global attributes are emited as the latest.
15369 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15371 * class.cs (EmitFieldInitializers): Don't emit field initializer
15372 for default values when optimilization is on.
15374 * constant.cs (Constant.IsDefaultValue): New property.
15376 * driver.cs: Add /optimize handling.
15380 * literal.cs: Implement new IsDefaultValue property.
15382 * rootcontext.cs (Optimize): New field, holds /optimize option.
15384 2005-02-18 Raja R Harinath <rharinath@novell.com>
15386 Fix crasher in re-opened #72347.
15387 * namespace.cs (Namespace.Lookup): Return null if
15388 DeclSpace.DefineType returns null.
15391 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15393 2005-02-18 Raja R Harinath <rharinath@novell.com>
15395 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15396 now returns null if it cannot resolve to an lvalue.
15397 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15398 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15399 returned null. Remove check for SimpleName.
15400 (EventExpr.DoResolveLValue): New.
15401 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15402 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15404 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15405 avoid CS0131 error.
15406 (Unary.ResolveOperator): Move CS0211 check ...
15407 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15409 (Unary.DoResolveLValue): Simplify.
15410 (AddressOf.DoResolveLValue): New.
15411 (ArrayAccess.DoResolveLValue): New.
15413 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15415 * attribute.cs (Attribute.Resolve): Add arguments casting for
15416 when types doesn't match ctor arguments.
15418 2005-02-16 Raja R Harinath <rharinath@novell.com>
15420 Fix parts of #63202.
15421 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15422 lookup of operator in base type. Ensure that all checks happen
15423 when the operator resolves to an "op_..." method.
15425 2005-02-15 Raja R Harinath <rharinath@novell.com>
15428 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15429 'ignore_cs0104' parameter. Pass it to ...
15430 (NamespaceEntry.Lookup): ... this.
15431 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15432 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15433 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15434 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15435 Update. Request that cs0104 errors be ignored.
15436 (ComposedCast.ResolveAsTypeStep): Update.
15438 2005-02-14 Raja R Harinath <rharinath@novell.com>
15441 * expression.cs (Invocation.BetterFunction): Remove support for
15442 comparing virtual functions and their overrides.
15443 (Invocation.IsOverride): New.
15444 (Invocation.OverloadResolve): Don't consider 'override' functions
15445 during candidate selection. Store them in a lookaside list.
15446 If the selected method is a 'virtual' function, use the list to
15447 find any overrides that are closer to the LHS type.
15449 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15451 * expression.cs (New.DoResolve): Add complex core type reduction.
15452 (New.Constantify): Converts complex core type syntax like 'new int ()'
15453 to simple constant.
15455 2005-02-14 Raja R Harinath <rharinath@novell.com>
15457 * decl.cs (EntryType.EntryType): New constructor to create an
15458 updated copy of a cache entry.
15459 (MemberCache.AddMethods): Use it.
15460 (MemberCache.ClearDeclaredOnly): Remove.
15461 (MemberCache.MemberCache): Update.
15463 2005-02-11 Miguel de Icaza <miguel@novell.com>
15465 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15466 variable. This one is represents the actual low-level declaration
15467 of the method, as opposed to the semantic level `IsStatic'.
15469 An anonymous method which is hosted into a static method might be
15470 actually an instance method. IsStatic would reflect the
15471 container, while MethodIsStatic represents the actual code
15474 * expression.cs (ParameterReference): Use the new MethodIsStatic
15475 instead of IsStatic.
15477 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15478 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15479 set on the current EmitContext.
15481 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15482 resolve our casted expression as an LValue. This triggers the
15483 proper LValue processing that is later required by Assign.
15487 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15489 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15491 C# 2.0 Fixed buffer implementation
15493 * anonymous.cs: Update after RegisterHelperClass renaming.
15495 * attribute.cs (AttributeTester.fixed_buffer_cache):
15496 Cache of external fixed buffers.
15497 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15498 implementation if field is fixed buffer else null.
15501 (TypeContainer.AddField): Accept FieldMember instead of Field.
15502 (FieldBase.IsFieldClsCompliant): Extracted code from
15503 VerifyClsCompliance descendant customization.
15504 (FixedField): New class handles fixed buffer fields.
15505 (FixedFieldExternal): Keeps information about imported fixed
15507 (IFixedField): Make access to internal or external fixed buffer
15510 * cs-parser.jay: Add fixed buffer parsing.
15512 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15515 * expression.cs (Indirection): Extended implementation to accept
15516 fixed buffer field.
15517 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15518 (ElementAccess.MakePointerAccess): Get type as parameter.
15519 (DoResolve): Add fixed buffer field expression conversion.
15520 (DoResolveLValue): Ditto.
15521 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15522 (ArrayPtr): Derives from FixedBufferPtr.
15523 (ArrayPtr.Emit): Add extra emit for array elements.
15525 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15527 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15528 for compiler generated types.
15529 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15531 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15532 and consume less memory.
15533 (Fixed.Resolve): Add fixed buffer case.
15535 * typemanager.cs (compiler_generated_attr_ctor,
15536 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15537 (HasElementType): Add our own implementation to work on every
15540 2005-02-11 Miguel de Icaza <miguel@novell.com>
15542 * anonymous.cs (CaptureContext): Track whether `this' has been
15545 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15546 only captured `this' if it was implicitly done (instance
15547 methods/variables were used).
15549 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15550 `this' must be captured.
15552 2005-01-30 Miguel de Icaza <miguel@novell.com>
15554 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15555 is null it means that there has been no need to capture anything,
15556 so we just create a sibling.
15558 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15560 Just a partial fix. The other half is fairly elusive.
15562 2005-02-10 Raja R Harinath <rharinath@novell.com>
15564 Fix #52586, cs0121-4.cs.
15565 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15566 and return a hashtable.
15567 (MemberCache.ClearDeclaredOnly): New.
15568 (MemberCache.MemberCache): Update to change. Make a deep copy of
15569 the method_hash of a base type too.
15570 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15571 type methods. Overwrite entries with the same MethodHandle so
15572 that the ReflectedType is correct. The process leaves in base
15573 virtual functions and their overrides as distinct entries.
15574 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15575 matters since it was boxed in a ArrayList before.
15576 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15578 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15579 case of a virtual function and its override (choose the overload
15581 (Invocation.OverloadResolve): Avoid 'override' members during
15582 'applicable_type' calculation.
15584 2005-02-09 Raja R Harinath <rharinath@novell.com>
15586 Combine two near-redundant caches.
15587 * typemanager.cs (method_params): Rename from method_internal_params.
15588 (TypeManager.GetParameterData): New. Replace
15589 Invocation.GetParameterData.
15590 (TypeManager.LookupParametersByBuilder): Remove.
15591 * expression.cs (Invocation.method_parameter_cache): Remove.
15592 (Invocation.GetParameterData): Remove.
15594 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15597 2005-02-08 Raja R Harinath <rharinath@novell.com>
15600 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15601 TypeManager.multicast_delegate_type is null, resolve it by looking
15602 up "System.MulticastDelegate".
15603 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15605 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15606 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15607 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15610 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15611 (LabeledStatement.AddReference): New. Set 'referenced'.
15612 (Goto.Resolve): Use it.
15614 2005-02-05 John Luke <john.luke@gmail.com>
15616 * driver.cs: remove duplicate -doc line in Usage ()
15618 2005-02-04 Raja R Harinath <rharinath@novell.com>
15620 * location.cs (Location.AddFile): Fix CS2002 error report.
15622 2005-02-02 Martin Baulig <martin@ximian.com>
15624 * delegate.cs (Delegate.DefineType): Report an internal error if
15625 TypeManager.multicast_delegate_type is null. See bug #72015 for
15628 2005-02-02 Raja R Harinath <rharinath@novell.com>
15630 Fix a crasher in a variant of #31984.
15631 * const.cs (Constant.CheckBase): New override that defers the
15632 new-or-override check in case the base type hasn't been populated
15634 (Constant.Define): Ensure the new-or-override check is performed.
15636 2005-02-01 Duncan Mak <duncan@ximian.com>
15638 * const.cs (LookupConstantValue): Check that `ce' is not null
15639 before calling GetValue ().
15641 2005-02-01 Raja R Harinath <rharinath@novell.com>
15643 Fix test-334.cs (#69519).
15644 * cs-parser.jay (using_alias_directive): Pass in an expression to
15645 NamespaceEntry.UsingAlias.
15646 (using_namespace_directive): Pass in an expression to
15647 NamespaceEntry.Using.
15648 (namespace_name): Don't flatten to a string.
15649 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15650 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15652 (NamespaceEntry.UsingEntry): Likewise.
15653 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15655 (NamespaceEntry.LookupForUsing): Remove.
15656 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15658 (NamespaceEntry.Lookup): Remove support for dotted names.
15660 2005-02-01 Raja R Harinath <rharinath@novell.com>
15662 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15664 (NamespaceEntry.ImplicitParent): Compute on demand.
15665 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15666 parallels the current.
15667 (NamespaceEntry.LookupForUsing): Use it.
15668 (NamespaceEntry.Lookup): If the current namespace-entry is
15669 implicit, don't search aliases and using tables.
15671 2005-02-01 Raja R Harinath <rharinath@novell.com>
15674 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15676 (TypeContainer.BaseCache): Compute on demand.
15677 (TypeContainer.FindMembers): Define constants and types if they're
15678 not already created.
15679 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15681 * const.cs (Constant.Define): Make idempotent.
15683 2005-01-29 Miguel de Icaza <miguel@novell.com>
15685 * pending.cs: Produce better code (no nops produced by using Ldarg
15688 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15689 i - 1' it should be arg + 1.
15693 2005-01-28 Raja R Harinath <rharinath@novell.com>
15695 * attribute.cs (Attribute.CheckAttributeType): Make private
15697 (Attribute.ResolveType): Make virtual.
15698 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15699 handling of RootContext.Tree.Types.
15701 2005-01-27 Raja R Harinath <rharinath@novell.com>
15703 Update attribute-handling to use the SimpleName/MemberAccess
15705 * cs-parser.jay (attribute): Pass in an expression to the
15706 constructors of Attribute and GlobalAttribute.
15707 * attribute.cs (Attribute): Take an expression for the name.
15708 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15709 passed in attribute name expression.
15710 (Attribute.CheckAttributeType): Use it.
15711 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15712 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15713 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15714 argument to prevent error messages if the lookup fails.
15716 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15718 * expression.cs (Indirection): Implemented IVariable interface
15719 to support indirection in AddressOf operator.
15720 (PointerArithmetic.Emit): Add optimalization for case where
15721 result can be precomputed.
15723 2005-01-26 Martin Baulig <martin@ximian.com>
15725 * class.cs (TypeContainer.AttributeTargets): Return the correct
15726 AttributeTargets depending on our `Kind' instead of throwing an
15727 exception; fixes #71632.
15729 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15732 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15735 2005-01-25 Raja R Harinath <rharinath@novell.com>
15738 * expression.cs (MemberAccess.DoResolve): Don't complain with
15739 cs0572 when the LHS of a member access has identical name and type
15742 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15745 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15747 Create custom PermissionSet only for PermissionSetAttribute.
15749 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15752 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15753 delegates in static class.
15755 2005-01-24 Martin Baulig <martin@ximian.com>
15757 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15758 merging an implicit block, just use its reachability.
15760 * statement.cs (Block.Resolve): Make the unreachable code check
15761 work wrt. implicit blocks; see test-337 from #63842.
15763 2005-01-21 Alp Toker <alp@atoker.com>
15765 * cs-parser.jay: destructor_declaration's container is PartialContainer
15766 not Class when partial types are used, so use Kind prop instead of
15769 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15771 * cs-parser.jay: Improve error reporting when an interface
15772 declares new types.
15774 2005-01-20 Dick Porter <dick@ximian.com>
15776 * support.cs: SeekableStreamReader fix from Sandor Dobos
15777 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15778 chars are read. Fixes bug 70369.
15780 2005-01-20 Raja R Harinath <rharinath@novell.com>
15782 * cs-parser.jay (catch_clause): Simplify current_block handling
15785 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15787 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15788 code with ImplicitStandardConversion to handle the implicit
15789 conversion of method groups into valid delegate invocations.
15791 The problem is that in parameter handling we were using this code
15792 path. Fixes bug #64698
15794 2005-01-19 Raja R Harinath <rharinath@novell.com>
15796 * cs-parser.jay: Fix several infelicities.
15797 - Avoid assigning to the parser value stack. Code like
15798 '$3 = null' is unclean. Synthesize a value for the code block
15800 - Avoid using oob_stack for storing location information. Use ...
15801 (_mark_): ... this. New (empty) rule. Saves the current location
15803 (foreach_statement): Avoid using oob_stack for current_block
15804 handling. Use technique used in for_statement and
15805 using_statement. Synthesize a value for the code block to store
15806 additional intermediate information.
15808 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15810 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15811 of a different type is only allowed to private fields of a
15812 containing type, not on fields of a base class.
15814 See test-174.cs and error cs0122-9.cs
15816 2005-01-13 Raja R Harinath <rharinath@novell.com>
15818 Fix test-335.cs (bug #58126).
15819 * cs-parser.jay (argument): Split out non-expression parts of the
15820 rule into 'non_simple_argument'.
15821 (invocation_expression): Support parenthesized invocations with
15822 multiple arguments, and with single non-simple arguments.
15824 2005-01-13 Raja R Harinath <rharinath@novell.com>
15826 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15829 2005-01-12 Raja R Harinath <rharinath@novell.com>
15831 Fix cs0038-1.cs, cs1640-6.cs.
15832 * ecore.cs (Expression.Resolve): Remove special-case for
15833 SimpleName in error-handling.
15834 (Expression.almostMatchedMembers): Relax access permission to
15836 (Expression.MemberLookupFailed): Handle duplicates in
15837 almostMatchedMembers list.
15838 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15839 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15840 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15841 overload if the passed in MemberInfo is a MethodBase.
15843 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15846 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15847 for non-CAS & merge permission sets properly.
15849 2005-01-11 Raja R Harinath <rharinath@novell.com>
15851 Improve standard-compliance of simple name and member access
15852 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15853 * ecore.cs (FullNamedExpression): New abstract base class
15854 for Namespaces and TypeExpressions.
15855 (ResolveFlags.SimpleName): Remove.
15856 (SimpleName): Remove support for dotted names.
15857 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15858 DeclSpace.FindType and DeclSpace.LookupType.
15859 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15860 (Expression.ExprClassName): Make member function.
15861 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15862 a namespace. Remove creation of dotted "SimpleName"s.
15863 (MemberAccess.DoResolve): Likewise.
15864 * decl.cs (DeclSpace.Cache): Make private.
15865 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15866 (DeclSpace.FindType): Update.
15867 (DeclSpace.LookupType): Move here from RootContext. Return a
15868 FullNamedExpression.
15869 * namespace.cs (Namespace): Derive from FullNamedExpression
15870 so that it can be part of expression resolution.
15871 (Namespace.Lookup): Return an FullNamedExpression.
15872 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15874 * rootcontext.cs (NamespaceLookup): Remove.
15875 (LookupType): Move to DeclSpace.
15876 * attribute.cs (CheckAttributeType): Update.
15877 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15878 (FindDocumentedTypeNonArray): Likewise.
15880 2005-01-11 Raja R Harinath <rharinath@novell.com>
15882 Fix cs0509.cs, cs1632.cs.
15883 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15884 is the same as IsInterface.
15885 (TypeContainer.GetClassBases): Likewise.
15886 * statement.cs (LabeledStatement.ig): New field.
15887 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15889 (LabeledStatement.DoEmit): Check that the label was created with
15890 the same ILGenerator.
15892 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15895 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15896 accessors to its properties.
15898 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15899 from accessors to property.
15901 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15904 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15905 only for overrides.
15907 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15909 * attribute.cs: Check for null and empty strings.
15911 I have lost another battle to Paolo.
15913 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15916 * class.cs (PropertyMethod): Set Parent field in ctors.
15917 (SetMethod.InternalParameters): Add unsafe switch hack.
15918 Override MarkForDuplicationCheck where it is appropriate.
15920 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15921 It says whether container allows members with the same name.
15922 Base default is no.
15923 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15924 Removed is_method parameter.
15926 2005-01-06 Duncan Mak <duncan@ximian.com>
15928 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15929 because the previous change led to incorrect reporting of CS1032
15930 ("Cannot define/undefine preprocessor symbols after first token in
15931 file"). Instead of using `tokens_seen' as the only flag that
15932 triggers CS1040, introduce `comments_seen'. This new flag is used
15933 to signify having seen comments on the current line, so it is
15934 unset after a newline.
15936 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15938 * doc.cs : When searching for a type, find nested type too.
15939 This fixes bug #71040.
15941 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15944 - Warn missing member comment on those classes which also does not
15945 have doc comments. Fixed bug #71041.
15946 - Don't warn missing doc comment on default constructor.
15949 2005-01-06 Duncan Mak <duncan@ximian.com>
15951 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15952 comments, set `tokens_seen' to true. This allows us to detect
15953 misplaced preprocessor directives (i.e. not at the beginning of
15954 the a line, nor after whitespaces). In that case, report error
15955 CS1040. This fixes bug #56460.
15957 * cs-parser.jay (interface_member_declaration): Add checks for
15958 IsExplicitImpl, and report CS0541 error if an interface member is
15959 defined as an explicit interface declaration.
15961 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15964 * class.cs (PropertyMethod): Set Parent field in ctors.
15965 (SetMethod.InternalParameters): Add unsafe switch hack.
15967 * decl.cs (MemberCore.Parent): Cannot be readonly.
15969 2005-01-06 Raja R Harinath <rharinath@novell.com>
15971 * decl.cs (DeclSpace.ResolveType): Remove.
15972 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15973 Merge in code from ...
15974 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15975 * class.cs, enum.cs: Update to changes.
15977 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15979 * anonymous.cs: Ensure that we init the scope of our parent if it
15980 has not been initialized yet.
15982 2004-12-30 Duncan Mak <duncan@ximian.com>
15984 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15985 if field.FieldBuilder is null. Fixes #70758.
15987 * convert.cs: Fixed some typos and updated some of the comments.
15988 (ImplicitStandardConversionExists):
15989 (TryImplicitIntConversion): If `target_type' is an interface and
15990 the type of `ic' implements this interface, return true or a new
15991 BoxedCast instead of null. This fixes #70468.
15993 2004-12-29 Duncan Mak <duncan@ximian.com>
15995 * expression.cs (Argument.Emit): Check that Expr is
15996 IMemoryLocation before casting to it, and report CS1510 otherwise.
16000 2004-12-21 Ben Maurer <bmaurer@ximian.com>
16002 * statement.cs (Block.ThisVariable): remove the recursion here, to
16003 make the --profile more sane.
16005 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
16007 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
16008 assembly, by JB Evain.
16010 2004-12-17 Raja R Harinath <rharinath@novell.com>
16012 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
16013 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
16014 "parent" refers to enclosing type/class. "base" refers to superclass.
16016 2004-12-17 Raja R Harinath <rharinath@novell.com>
16018 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
16019 Ensure that we only have GlobalAttributes.
16020 * attribute.cs (Attribute.Emit): Make non-virtual.
16021 (GlobalAttribute.Emit): Remove.
16022 (Attribute.Resolve): Make virtual.
16023 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
16024 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
16025 the argument. Don't create one.
16026 (Attribute.GetObsoleteAttribute): Likewise.
16027 (Attribute.GetClsCompliantAttributeValue): Likewise.
16028 * class.cs, decl.cs: Update to changes.
16030 2004-12-17 Marek Safar <marek.safar@seznam.cz>
16032 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
16034 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
16036 * statement.cs (Foreach.Resolve): Add error 186 report.
16038 2004-12-16 Marek Safar <marek.safar@seznam.cz>
16040 * expression.cs (Conditional.DoResolve): Add warning 429.
16042 * statement.cs (If.Resolve): Add warning 665.
16044 2004-12-16 Raja R Harinath <rharinath@novell.com>
16046 New invariant: RootContext.Tree.Types.NamespaceEntry == null
16047 except when in the parser, and in GlobalAttribute.
16048 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
16049 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
16050 RootContext.Tree.Types.NamespaceEntry once work is done.
16051 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
16052 and resets RootContext.Tree.Types.NamespaceEntry.
16054 2004-12-15 Marek Safar <marek.safar@seznam.cz>
16056 * cs-parser.jay: Don't create a block for every variable.
16058 2004-12-14 Miguel de Icaza <miguel@ximian.com>
16060 * location.cs: Provide extra information.
16062 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
16063 variables from the captured environment, it is the ldarg_0.
16065 2004-12-14 Marek Safar <marek.safar@seznam.cz>
16067 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
16070 * class.cs: Changed warning level for 169 to avoid developer
16071 displeasure from warning flooding. It will be changed back when they
16072 fix most of current BCL warnings.
16074 * RootContext.cs: Pushed default WarningLevel to 3.
16076 * statement.cs: Removed unused variable.
16078 2004-12-14 Marek Safar <marek.safar@seznam.cz>
16080 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
16081 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
16082 Add error 502 report.
16083 (StaticClass.DefineType): Add error 441 report.
16084 (Class.AllowedModifiersProp): New virtual property as temporary
16085 extension to AllowedModifiers.
16086 (Class.DefineType): Add error 418 report. Moved ModFlags check here
16087 to share implementation with StaticClass and don't call virtual
16090 * driver.cs (MainDriver): Add error 1558 test.
16092 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
16093 report. Moved error 36 test here.
16095 * statement.cs (Throw.Resolve): Add error 724 report.
16097 * typemanager.cs: Add out_attribute_type core type.
16099 2004-12-13 Marek Safar <marek.safar@seznam.cz>
16101 * class.cs (TypeContainer.VerifyClsCompliance): Add error
16103 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
16105 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
16108 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
16110 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
16111 Add error 3023 report.
16112 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
16114 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
16117 2004-12-12 John Luke <john.luke@gmail.com>
16119 * driver.cs (AddArgs): take -- into account when
16120 adding arguments, fixes bug 65710
16122 2004-12-12 Martin Baulig <martin@ximian.com>
16124 * expression.cs (Unary.TryReduceNegative): Added support for
16125 SByteConstant and ByteConstant.
16126 (Unary.Reduce): Check error values from TryReduceNegative().
16128 2004-12-10 Marek Safar <marek.safar@seznam.cz>
16130 * attributes.cs (Attribute.Resolve): Avoid multiple error report
16131 and report exception as error 182.
16133 2004-12-10 Raja R Harinath <rharinath@novell.com>
16135 * driver.cs (Main): Fix message when there are warnings.
16137 2004-12-09 Miguel de Icaza <miguel@ximian.com>
16139 * delegate.cs: Fixed my fix from yesterday, sorry about that.
16141 2004-12-09 Marek Safar <marek.safar@seznam.cz>
16143 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
16144 Reduced number of warnings.
16146 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
16148 2004-12-08 Miguel de Icaza <miguel@ximian.com>
16150 * driver.cs: Removed message.
16152 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
16154 2004-12-08 <vargaz@freemail.hu>
16156 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
16158 2004-12-08 Martin Baulig <martin@ximian.com>
16160 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
16161 instead of a CS3002 for properties and indexer.
16163 2004-12-08 Martin Baulig <martin@ximian.com>
16165 * decl.cs (MemberName.ToString): Make this work again.
16167 2004-12-08 Marek Safar <marek.safar@seznam.cz>
16169 * attribute.cs (Resolve): Add error 591 detection.
16171 * class.cs (FieldMember.Define): Add error 1547 detection.
16172 (Indexer.Define): Add error 620 detection.
16173 (Operator.Define): Add error 590 detection.
16175 * ecore.cs: Missing argument for error 79.
16177 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
16180 2004-12-07 Marek Safar <marek.safar@seznam.cz>
16183 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
16186 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
16188 * cs-parser.jay : handle doc comments on implicit/explicit operators.
16189 Some operator comments were suppressed.
16190 * doc.cs : Implicit/explicit operator name in doc comments are like
16191 "op_Explicit(type)~returnType", so added suffix handling.
16193 2004-12-07 Martin Baulig <martin@ximian.com>
16196 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
16197 (MemberCore.GetClsCompliantAttributeValue): Likewise.
16198 (DeclSpace.ec): New protected field; store the EmitContext here.
16199 (DeclSpace.EmitContext): New public property; moved here from
16201 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
16204 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
16205 (Enum.Emit): Don't create a new EmitContext.
16207 * delegate.cs (Delegate.DefineType): Always create the
16210 * iterators.cs (Iterators.DefineIterator): Create a new
16211 EmitContext and store it in `ec'.
16213 2004-08-24 Martin Baulig <martin@ximian.com>
16216 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
16217 this for accessibility checks.
16218 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
16219 IsNestedFamilyAccessible.
16220 (TypeManager.IsSubclassOf): New method, do what the name actually
16223 2004-12-06 Raja R Harinath <rharinath@novell.com>
16225 Fix crash on cs0657-17.cs.
16226 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
16227 Use RootContext.Tree.Types, not 'new RootTypes ()'.
16228 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
16229 the case where the NamespaceEntry gets overwritten.
16231 2004-12-06 Marek Safar <marek.safar@seznam.cz>
16233 Fixed #69195, #56821
16234 * ecore.cs (ResolveBoolean): Tiny refactoring.
16236 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
16237 of right expression resolving when left is false constant and
16238 operator is LogicalAnd OR true constant and operator is LogicalOr.
16240 * statement.cs (ResolveUnreachable): Always reports warning.
16242 2004-12-05 Miguel de Icaza <miguel@ximian.com>
16244 * class.cs: Distinguish between 1721 and 1722 (just a little help
16245 for the programmer).
16247 2004-12-03 Miguel de Icaza <miguel@ximian.com>
16249 * delegate.cs: Only allow this on new versions of the language.
16251 2004-12-02 Duncan Mak <duncan@ximian.com>
16253 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
16255 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
16256 here as a static method. Take an additional bool out parameter
16257 `must_do_cs1540_check' for signaling to InstanceResolve.
16258 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
16259 member field from PropertyExpr class and made it an argument of
16260 the method instead.
16261 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
16262 check for MarshalByRefObject, and report CS0122 instead of CS1540.
16263 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
16264 and `remove_accessor' as well as InstanceResolve: report CS0122
16269 2004-12-03 Raja R Harinath <rharinath@novell.com>
16271 Fix test-327.cs, test-328.cs, and put in early infrastructure
16272 for eventually fixing #52697.
16273 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
16274 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
16275 from other methods.
16276 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
16277 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
16278 (VerifyUsing, error246): Update.
16279 * rootcontext.cs (RootContext.NamespaceLookup): Just use
16280 'NamespaceEntry.LookupNamespaceOrType'.
16282 2004-12-03 Martin Baulig <martin@ximian.com>
16284 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16285 method as our child, call AnonymousMethod.Compatible() on it.
16287 2004-12-03 Raja R Harinath <rharinath@novell.com>
16289 Disable XML documentation support in 'basic' profile.
16290 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
16291 Redirect XmlElement to System.Object.
16292 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
16293 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
16294 * mcs.exe.sources: Add doc-bootstrap.cs.
16295 * doc-bootstrap.cs: New file. Contains empty stub implementation
16298 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
16300 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
16301 comments are allowed.
16303 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16305 * delegate.cs: Add checks for subtypes in paramaters and return values
16306 in VerifyMethod () to add support for Covariance/Contravariance
16309 2004-12-02 Miguel de Icaza <miguel@ximian.com>
16311 * report.cs: Remove extra closing parenthesis.
16313 * convert.cs (Error_CannotImplicitConversion): If the name of the
16314 types are the same, provide some extra information.
16316 * class.cs (FieldBase): Use an unused bit field from the field to
16317 encode the `has_offset' property from the FieldMember. This saves
16318 a couple of Ks on bootstrap compilation.
16320 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16321 method as our child, return the AnonymousMethod resolved
16324 * expression.cs (New.DoResolve): Allow return values from
16325 NewDelegate to also include AnonymousMethods.
16329 2004-12-02 Marek Safar <marek.safar@seznam.cz>
16332 * attribute.cs (Resolve): Improved implementation of params
16333 attribute arguments.
16335 * support.cs (ParameterData): Add HasParams to be faster.
16337 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
16339 all things are for /doc support:
16341 * doc.cs: new file that supports XML documentation generation.
16342 * mcs.exe.sources: added doc.cs.
16344 Handle /doc command line option.
16345 Report error 2006 instead of 5 for missing file name for /doc.
16346 Generate XML documentation when required, after type resolution.
16348 Added support for picking up documentation (/// and /** ... */),
16349 including a new XmlCommentState enumeration.
16351 Added lines to fill Documentation element for field, constant,
16352 property, indexer, method, constructor, destructor, operator, event
16353 and class, struct, interface, delegate, enum.
16354 Added lines to warn incorrect comment.
16356 Added Documentation field (passed only when /doc was specified).
16358 Added DocComment, DocCommentHeader, GenerateDocComment() and
16359 OnGenerateDocComment() and some supporting private members for
16360 /doc feature to MemberCore.
16362 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16364 Added overriden DocCommentHeader.
16366 Added overriden DocCommentHeader and GenerateDocComment().
16368 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16370 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16371 unwrapping the enumeration values, chain to
16372 DoConstantNumericPromotions again, so we can promote things to the
16373 fundamental types (takes care of enums that are bytes, sbytes).
16377 2004-12-01 Raja R Harinath <rharinath@novell.com>
16379 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16380 Fix long-standing bug in type-lookup. Use FindType instead of
16381 LookupType when ec.ResolvingTypeTree.
16382 (Attribute.ResolveType, Attribute.Resolve)
16383 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16385 (Attributes.Search): Remove internal version. Update.
16386 (Attributes.SearchMulti): Update.
16387 (Attributes.GetClsCompliantAttribute): Remove.
16388 (Attributes.GetIndexerNameAttribute): Remove.
16389 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16390 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16391 * class.cs (Indexer.Define): Likewise.
16393 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16396 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16397 MarshallByReference members access.
16399 * expression.cs: Use CheckMarshallByRefAccess;
16400 Better error CS0197 message.
16402 * report.cs: Print whole related error message.
16404 2004-11-30 Raja R Harinath <rharinath@novell.com>
16406 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16407 the current directory to help debugging.
16409 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16411 * class (GetClassBases): Better error 60 report.
16412 (EventProperty): Disabled warning 67 detection.
16414 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16417 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16419 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16422 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16425 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16427 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16429 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16431 * attribute.cs (Attribute.Resolve): Refine error reporting and
16432 report a cs0117 if the identifier does not exist, to distinguish
16433 from 0617 which is a miss-use of the actual identifier.
16435 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16436 between cs0070 and cs0079.
16438 * class.cs (MemberBase.DoDefine): When reporting a wrong
16439 accessibility level, we use MethodCore to compare instead of
16440 Method (this was a regression in some refactoring effort).
16442 So now we correctly report cs0056 again.
16444 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16445 testing the target_type (which was known to be object_type) and
16446 not the source type (which is anonymous_method).
16448 Fixed reporting of error cs1660.
16450 * expression.cs (UserCast.Source): Expose the underlying cast.
16452 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16453 allowed types to find a match to int32 first (most common).
16455 In addition, it ignores any ImplicitUserConversions that did an
16456 internal implicit conversion (as the switch statement allows only
16457 one integral conversion to exist).
16459 * class.cs (PartialContainer.Create): rename `name' to
16460 `member_name' for clarity. Then replace the string calls with a
16461 call to MemberName.GetPartialName, as now using
16462 MemberName.ToString is an error (this is due to the side effects
16463 it had, that were fixed in the past).
16465 This will restore the error reporting on a number of partial class
16466 errors that were missusing this (and getting an exception as a
16467 results, which is now just a plain textual warning, because
16468 yyparse debug output would crash otherwise).
16470 2004-11-26 Raja R Harinath <rharinath@novell.com>
16472 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16474 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16476 * rootcontext.cs (LookupType): Make sure to cache lookups that
16477 don't give us a negative result. This saves about 5% of corlib
16480 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16482 * report.cs (AbstractMessage.Print): messages are sent to stderr
16484 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16485 non-interface in the list of interfaces (at this point, either
16486 parent was properly set, or a base class is being listed in the
16487 interfaces section).
16489 This flags error 1722, and resolves the crash from bug 69259.
16491 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16493 * statement.cs (Using.EmitExpressionFinally): make this work right
16494 for valuetypes. Fixes 69926.
16496 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16498 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16499 converted to an enum" here, before we try to change the underlying
16500 type. This code exists, but it is a different code path than the
16501 one used while encoding constants.
16503 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16504 old bug: when converting from the null literal to a pointer,
16505 return an EmptyCast, not the NullLiteral.
16507 This fixes #69921, the recent null_type changes probably made this
16508 bug more prominent.
16510 (ImplicitReferenceConversionExists): In addition, resynchronized
16511 the code here, so it matches the same code in
16512 ImplicitReferenceConversionExists for the `from any class-type S
16513 to any interface-type T'.
16516 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16518 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16520 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16522 * cs-parser.jay: Use verbosity accordingly.
16524 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16526 * expression.cs (Unary.ResolveOperator): Do not report warning;
16527 AddressOf reads from variable.
16529 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16531 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16535 * attribute.cs (Attributable): Removed CheckTargets.
16536 (Attributes.Emit): Explicit attribute targets are tested here.
16538 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16539 not enabled for interfaces.
16541 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16542 (GetAssemblyName): Ouch next bug there.
16544 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16546 * expression.cs: Error 275 added.
16548 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16550 Fix bug #69177 (Implemented decimal constant support)
16552 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16553 (BinaryFold): Add DecimalConstant.
16555 * const.cs (Define): Decimal constant
16557 (ChangeType): Add decimal type handling.
16558 (LookupConstantValue): Don't set value for decimal type but
16559 emit DecimalConstantAttribute. Needed for constant optimization.
16561 * constant.cs (ToDecimal): New method.
16562 (ConvertToDecimal): New method.
16563 (IntConstant): Implemented ConvertToDecimal.
16564 (DecimalConstant.Emit): Emit optimized version for decimals in
16567 * expression.cs (ResolveOperator): Changed order of constant
16568 reduction to work correctly with native types which have
16569 overloaded operators.
16570 (ResolveMemberAccess): Extract constant value from attribute
16573 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16575 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16576 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16577 (ChangeType): Decimal is special.
16578 (TypeToCoreType): Add decimal type.
16580 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16582 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16585 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16587 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16590 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16592 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16594 * pending.cs (PendingImplementation): Grab only interfaces.
16596 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16598 * statement.cs (ForeachHelperMethods): Add location member and
16599 error 202 detection.
16601 2004-11-19 Raja R Harinath <rharinath@novell.com>
16603 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16604 automatically handled by executable.make.
16605 (PROGRAM): Make profile-specific.
16607 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16609 * expression.cs (DoResolveBase): Fixed wrong warning for out
16612 2004-11-18 Martin Baulig <martin@ximian.com>
16614 Merged latest changes into gmcs. Please keep this comment in
16615 here, it makes it easier for me to see what changed in MCS since
16616 the last time I merged.
16618 2004-11-17 Raja R Harinath <rharinath@novell.com>
16620 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16621 (TypeHandle.GetMemberCache): New.
16622 (TypeHandle.TypeHandle): Update.
16623 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16624 (TypeManager.LookupParentInterfacesCache):
16625 Rename from LookupInterfaceCache. Optimize slightly.
16626 (TypeManager.MemberLookup_FindMembers): Update.
16627 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16628 multi-type variant.
16629 (AddCacheContents): Rename from AddHashtable.
16630 * class.cs (TypeContainer.parent_container): Remove.
16631 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16632 (TypeContainer.DoDefineMembers): Don't initialize it.
16633 Update to name changes.
16635 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16637 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16638 that factors the code to check access modifiers on override.
16640 (PropertyBase): Use the code here.
16642 Patch from Lluis S'anchez, fixes bug #69361.
16644 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16646 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16647 routine that is used to report the use of a captured variable
16648 whose address has been taken.
16650 There are two checks: one when variables are being captured and
16651 the other check is when the address of a variable is taken.
16653 (because an anonymous methods might be resolved before *or* after
16654 the address has been taken) and
16656 * expression.cs (Conditional.DoResolve): Remove the special
16657 casing that Martin added to trueExpr and falseExpr being both
16658 NullLiteral. We get the right behavior now just by introducing
16659 the null_type into the compiler.
16661 * convert.cs (ExplicitConversion): Change the code to use
16662 null_type instead of testing `expr is NullLiteral'.
16663 (ImplicitConversionStandard): use null_type too.
16664 (ImplicitReferenceConversionExists): use null_type too.
16665 (ImplicitReferenceConversion): use null_type too.
16667 * literal.cs: The type of `NullLiteral' is now null_type instead
16669 (Resolve): Set the type here.
16671 * typemanager.cs: Introduce null_type.
16673 2004-11-17 Martin Baulig <martin@ximian.com>
16675 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16676 direction, like FindMembers() does. Fixes #69546, testcase is in
16679 2004-11-16 Martin Baulig <martin@ximian.com>
16681 This is based on a patch from Marek Safar, see bug #69082.
16682 Fixes bugs #63705 and #67130.
16684 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16685 method; create a MemberCache for an interface type and cache the
16688 * decl.cs (IMemberContainer.ParentContainer): Removed.
16689 (IMemberContainer.ParentCache): New property.
16690 (MemberCache.SetupCacheForInterface): Removed.
16691 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16692 to create a cache for an interface's "parent".
16694 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16697 2004-11-16 Martin Baulig <martin@ximian.com>
16699 Merged back from gmcs; these changes already went into gmcs a
16700 couple of weeks ago.
16703 (TypeManager.AddUserType): Removed the `ifaces' argument.
16704 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16706 (TypeManager.AddUserInterface): Removed.
16707 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16709 (TypeManager.GetInterfaces): Likewise.
16710 (TypeManager.GetExplicitInterfaces): Likewise.
16712 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16714 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16715 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16717 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16719 * statement.cs: Avoid adding bools to a hashtable.
16721 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16723 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16724 calling an unsafe method from a safe location.
16726 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16729 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16731 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16733 * namespace.cs (VerifyUsing): use GetPartialName instead of
16736 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16738 * statement.cs (Return.Resolve): Fix regression in typo: if
16739 `in_exc', we have to request a NeedReturnLabel, this was a typo
16740 introduced in the anonymous method check-in. Fixes #69131.
16742 * Indexers were using the ShortName when defining themselves,
16743 causing a regression in the compiler bootstrap when applying the
16744 patch from 2004-11-02 (first part), now they use their full name
16745 and the bug is gone.
16747 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16749 * driver.cs: Strip the path from the names of embedded resources. Fixes
16752 2004-11-04 Raja R Harinath <rharinath@novell.com>
16754 Fix error message regression: cs0104-2.cs.
16755 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16756 (AliasEntry.Resolve): Update.
16757 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16759 (RootContext.LookupType): Update.
16761 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16763 * cs-parser.jay: Add support for handling accessor modifiers
16764 * class: Add support port accessor modifiers and error checking,
16765 define PropertyMethod.Define as virtual (not abstract anymore)
16766 * ecore.cs: Add checking for proeprties access with access modifiers
16767 * iterators.cs: Modify Accessor constructor call based in the modified
16769 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16771 * expression.cs (StringConcat): Handle being called twice,
16772 as when we have a concat in a field init with more than two
16775 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16777 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16778 special case explicit implementations, we should always produce
16779 the .property or .event declaration.
16781 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16782 since it will not return correct data if people use this
16783 unresolved in the presence of using statements (see test-313).
16785 * class.cs (MethodData.Define): If we are an explicit interface
16786 implementation, set the method name to the full name of the
16787 interface plus the name of the method.
16789 Notice that using the method.MethodName.GetFullName() does not
16790 work, as it will only contain the name as declared on the source
16791 file (it can be a shorthand in the presence of using statements)
16792 and not the fully qualifed type name, for example:
16796 class D : ICloneable {
16797 object ICloneable.Clone () {
16801 Would produce a method called `ICloneable.Clone' instead of
16802 `System.ICloneable.Clone'.
16804 * namespace.cs (Alias.Resolve): Use GetPartialName.
16806 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16808 * cs-parser.jay: Add error 1055 report.
16810 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16812 * assign.cs (Assign.DoResolve): Only do the transform of
16813 assignment into a New if the types are compatible, if not, fall
16814 through and let the implicit code deal with the errors and with
16815 the necessary conversions.
16817 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16819 * cs-parser.jay: Add error 1031 report.
16821 * cs-tokenizer.cs: Add location for error 1038.
16823 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16825 * cs-parser.jay: Add error 1016 report.
16827 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16829 * cs-parser.jay: Add errors 1575,1611 report.
16831 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16833 * cs-parser.jay: Add error 1001 report.
16835 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16838 * attribute.cs (GetMarshal): Add method argument for
16839 caller identification.
16841 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16842 agument for GetMarshal and RuntimeMissingSupport.
16844 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16846 * attribute.cs (ExtractSecurityPermissionSet): Removed
16847 TypeManager.code_access_permission_type.
16849 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16851 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16853 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16854 for obsolete use of a variable here. Fixes regression on errors
16855 cs0619-25 and cs0619-26.
16857 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16859 Fix #62358, implemented security attribute encoding.
16861 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16862 Tests permitted SecurityAction for assembly or other types.
16863 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16864 data from SecurityPermissionAttribute to PermisionSet class.
16866 * class.cs (ApplyAttributeBuilder): Added special handling
16867 for System.Security.Permissions.SecurityAttribute based types.
16869 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16870 special handling for System.Security.Permissions.SecurityAttribute
16873 * enum.cs (ApplyAttributeBuilder): Added special handling
16874 for System.Security.Permissions.SecurityAttribute based types.
16876 * parameter.cs (ApplyAttributeBuilder): Added special handling
16877 for System.Security.Permissions.SecurityAttribute based types.
16879 * rootcontext.cs: Next 2 core types.
16881 * typemanager.cs (TypeManager.security_permission_attr_type):
16882 Built in type for the SecurityPermission Attribute.
16883 (code_access_permission_type): Build in type.
16885 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16887 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16888 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16889 all of this information into
16890 EmitContext.EmitCapturedVariableInstance.
16892 * codegen.cs (EmitCapturedVariableInstance): move here the
16893 funcionality of emitting an ldarg.0 in the presence of a
16894 remapping. This centralizes the instance emit code.
16896 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16897 then emit a load of this: it means that we have reached the
16898 topmost ScopeInfo: the one that contains the pointer to the
16899 instance of the class hosting the anonymous method.
16901 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16902 captures to the topmost CaptureContext.
16904 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16906 * expression.cs (LocalVariableReference): Move the knowledge about
16907 the iterators into codegen's EmitCapturedVariableInstance.
16909 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16911 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16912 all code paths return a value from an anonymous method (it is the
16913 same as the 161 error, but for anonymous methods).
16915 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16917 The introduction of anonymous methods in the compiler changed
16918 various ways of doing things in the compiler. The most
16919 significant one is the hard split between the resolution phase
16920 and the emission phases of the compiler.
16922 For instance, routines that referenced local variables no
16923 longer can safely create temporary variables during the
16924 resolution phase: they must do so from the emission phase,
16925 since the variable might have been "captured", hence access to
16926 it can not be done with the local-variable operations from the runtime.
16930 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16931 is a toplevel block.
16933 (ToplevelBlock): A new kind of Block, these are the blocks that
16934 are created by the parser for all toplevel method bodies. These
16935 include methods, accessors and anonymous methods.
16937 These contain some extra information not found in regular blocks:
16938 A pointer to an optional CaptureContext (for tracking captured
16939 local variables and parameters). A pointer to the parent
16942 (Return.Resolve): Catch missmatches when returning a value from an
16943 anonymous method (error 1662).
16944 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16947 (Break.Resolve): ditto.
16949 (SwitchLabel): instead of defining the labels during the
16950 resolution phase, we now turned the public ILLabel and ILLabelCode
16951 labels into methods called GetILLabelCode() and GetILLabel() that
16952 only define the label during the Emit phase.
16954 (GotoCase): Track the SwitchLabel instead of the computed label
16955 (its contained therein). Emit the code by using
16956 SwitchLabel.GetILLabelCode ().
16958 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16959 whether the Local has been captured or not.
16961 (LocalInfo.IsCaptured): New property, used to tell whether the
16962 local has been captured.
16964 * anonymous.cs: Vastly updated to contain the anonymous method
16967 The main classes here are: CaptureContext which tracks any
16968 captured information for a toplevel block and ScopeInfo used to
16969 track the activation frames for various local variables.
16971 Each toplevel block has an optional capture context associated
16972 with it. When a method contains an anonymous method both the
16973 toplevel method and the anonymous method will create a capture
16974 context. When variables or parameters are captured, they are
16975 recorded on the CaptureContext that owns them, for example:
16979 MyDelegate d = delegate {
16984 Here `a' will be recorded as captured on the toplevel
16985 CapturedContext, the inner captured context will not have anything
16986 (it will only have data if local variables or parameters from it
16987 are captured in a nested anonymous method.
16989 The ScopeInfo is used to track the activation frames for local
16990 variables, for example:
16992 for (int i = 0; i < 10; i++)
16993 for (int j = 0; j < 10; j++){
16994 MyDelegate d = delegate {
16999 At runtime this captures a single captured variable `i', but it
17000 captures 10 different versions of the variable `j'. The variable
17001 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
17002 recorded on a child.
17004 The toplevel ScopeInfo will also track information like the `this'
17005 pointer if instance variables were referenced (this is necessary
17006 as the anonymous method lives inside a nested class in the host
17007 type of the method).
17009 (AnonymousMethod): Expanded to track the Toplevel, implement
17010 `AnonymousMethod.Compatible' to tell whether an anonymous method
17011 can be converted to a target delegate type.
17013 The routine now also produces the anonymous method content
17015 (AnonymousDelegate): A helper class that derives from
17016 DelegateCreation, this is used to generate the code necessary to
17017 produce the delegate for the anonymous method that was created.
17019 * assign.cs: API adjustments for new changes in
17020 Convert.ImplicitStandardConversionExists.
17022 * class.cs: Adjustments to cope with the fact that now toplevel
17023 blocks are of type `ToplevelBlock'.
17025 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
17026 insteda of standard blocks.
17028 Flag errors if params arguments are passed to anonymous methods.
17030 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
17031 `CurrentAnonymousMethod' which points to the current Anonymous
17032 Method. The variable points to the AnonymousMethod class that
17033 holds the code being compiled. It is set in the new EmitContext
17034 created for the anonymous method.
17036 (EmitContext.Phase): Introduce a variable and an enumeration to
17037 assist in enforcing some rules about when and where we are allowed
17038 to invoke certain methods (EmitContext.NeedsReturnLabel is the
17039 only one that enfonces this right now).
17041 (EmitContext.HaveCaptureInfo): new helper method that returns
17042 whether we have a CapturedContext initialized.
17044 (EmitContext.CaptureVariable): New method used to register that a
17045 LocalInfo must be flagged for capturing.
17047 (EmitContext.CapturedParameter): New method used to register that a
17048 parameters must be flagged for capturing.
17050 (EmitContext.CapturedField): New method used to register that a
17051 field must be flagged for capturing.
17053 (EmitContext.HaveCapturedVariables,
17054 EmitContext.HaveCapturedFields): Return whether there are captured
17055 variables or fields.
17057 (EmitContext.EmitMethodHostInstance): This is used to emit the
17058 instance for the anonymous method. The instance might be null
17059 (static methods), this (for anonymous methods that capture nothing
17060 and happen to live side-by-side with the current method body) or a
17061 more complicated expression if the method has a CaptureContext.
17063 (EmitContext.EmitTopBlock): Routine that drives the emission of
17064 code: it will first resolve the top block, then emit any metadata
17065 and then emit the code. The split is done so that we can extract
17066 any anonymous methods and flag any captured variables/parameters.
17068 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
17069 during this phase, the ILGenerator should not be used as labels
17070 and local variables declared here might not be accessible to any
17071 code that is part of an anonymous method.
17073 Exceptions to this include the temporary variables that are
17074 created by some statements internally for holding temporary
17077 (EmitContext.EmitMeta): New routine, in charge of emitting all the
17080 (EmitContext.TemporaryReturn): This method is typically called
17081 from the Emit phase, and its the only place where we allow the
17082 ReturnLabel to be defined other than the EmitMeta. The reason is
17083 that otherwise we would have to duplicate a lot of logic in the
17084 Resolve phases of various methods that today is on the Emit
17087 (EmitContext.NeedReturnLabel): This no longer creates the label,
17088 as the ILGenerator is not valid during the resolve phase.
17090 (EmitContext.EmitThis): Extended the knowledge in this class to
17091 work in anonymous methods in addition to iterators.
17093 (EmitContext.EmitCapturedVariableInstance): This emits whatever
17094 code is necessary on the stack to access the instance to a local
17095 variable (the variable will be accessed as a field).
17097 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
17098 EmitContext.EmitAddressOfParameter): Routines to support
17099 parameters (not completed at this point).
17101 Removals: Removed RemapLocal and RemapLocalLValue. We probably
17102 will also remove the parameters.
17104 * convert.cs (Convert): Define a `ConstantEC' which points to a
17105 null. This is just to prefity some code that uses
17106 ImplicitStandardConversion code and do not have an EmitContext
17109 The idea is to flag explicitly that at that point in time, it is
17110 known that the conversion will not trigger the delegate checking
17111 code in implicit conversions (which requires a valid
17114 Everywhere: pass new EmitContext parameter since
17115 ImplicitStandardConversionExists now requires it to check for
17116 anonymous method conversions.
17118 (Convert.ImplicitStandardConversionExists): If the type of an
17119 expression is the anonymous_method_type, and the type is a
17120 delegate, we invoke the AnonymousMethod.Compatible method to check
17121 whether an implicit conversion is possible.
17123 (Convert.ImplicitConversionStandard): Only do implicit method
17124 group conversions if the language level is not ISO_1.
17126 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
17127 MethodInfo for the Invoke method. used by Delegate and
17130 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
17131 method conversions if the target type is a delegate.
17133 Removed extra debugging nops.
17135 (LocalVariableReference): Turn the `local_info' into a public
17138 Add `prepared' field, the same hack used for FieldExprs to cope
17139 with composed assignments, as Local variables do not necessarily
17140 operate purely on the stack as they used to: they can be captured
17143 Add `temp' for a temporary result, like fields.
17145 Refactor DoResolve and DoResolveLValue into DoResolveBase.
17147 It now copes with Local variables that are captured and emits the
17148 proper instance variable to load it from a field in the captured
17151 (ParameterReference.DoResolveBase): During the resolve phase,
17152 capture parameters if we are in an anonymous method.
17154 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
17155 anonymous method, use the EmitContext helper routines to emit the
17156 parameter reference.
17158 * iterators.cs: Set RemapToProxy to true/false during the
17161 * parameters.cs (GetParameterByName): New helper method.
17163 * typemanager.cs (anonymous_method_type) a new type that
17164 represents an anonyous method. This is always an internal type,
17165 used as a fencepost to test against the anonymous-methodness of an
17168 2004-10-20 Marek Safar <marek.safar@seznam.cz>
17170 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
17172 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
17174 2004-10-18 Martin Baulig <martin@ximian.com>
17176 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
17177 `Type' directly, but call ResolveType() on it.
17178 (Catch.Resolve): Likewise.
17179 (Foreach.Resolve): Likewise.
17181 2004-10-18 Martin Baulig <martin@ximian.com>
17183 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
17184 `Type' directly, but call ResolveType() on it.
17185 (Probe.DoResolve): Likewise.
17186 (ArrayCreation.LookupType): Likewise.
17187 (TypeOf.DoResolve): Likewise.
17188 (SizeOf.DoResolve): Likewise.
17190 2004-10-18 Martin Baulig <martin@ximian.com>
17192 * expression.cs (Invocation.BetterFunction): Put back
17193 TypeManager.TypeToCoreType().
17195 2004-10-18 Raja R Harinath <rharinath@novell.com>
17197 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
17200 2004-10-18 Martin Baulig <martin@ximian.com>
17202 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
17203 `Type' directly, but call ResolveType() on it.
17205 2004-10-18 Martin Baulig <martin@ximian.com>
17207 * class.cs (FieldMember.Define): Don't access the TypeExpr's
17208 `Type' directly, but call ResolveType() on it.
17209 (MemberBase.DoDefine): Likewise.
17211 * expression.cs (New.DoResolve): Don't access the TypeExpr's
17212 `Type' directly, but call ResolveType() on it.
17213 (ComposedCast.DoResolveAsTypeStep): Likewise.
17215 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
17216 `Type' directly, but call ResolveType() on it.
17218 2004-10-17 John Luke <john.luke@gmail.com>
17220 * class.cs (Operator.GetSignatureForError): use CSharpName
17222 * parameter.cs (Parameter.GetSignatureForError): Returns
17223 correct name even if was not defined.
17225 2004-10-13 Raja R Harinath <rharinath@novell.com>
17228 * class.cs (TypeContainer.EmitContext): New property.
17229 (DefineNestedTypes): Create an emitcontext for each part.
17230 (MethodCore.DoDefineParameters): Use container's emitcontext.
17231 Pass type array to InternalParameters.
17232 (MemberBase.DoDefine): Use container's emitcontext.
17233 (FieldMember.Define): Likewise.
17234 (Event.Define): Likewise.
17235 (SetMethod.GetParameterInfo): Change argument to EmitContext.
17236 Pass type array to InternalParameters.
17237 (SetIndexerMethod.GetParameterInfo): Likewise.
17238 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
17239 * delegate.cs (Define): Pass emitcontext to
17240 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
17241 array to InternalParameters.
17242 * expression.cs (ParameterReference.DoResolveBase): Pass
17243 emitcontext to GetParameterInfo.
17244 (ComposedCast.DoResolveAsTypeStep): Remove check on
17245 ec.ResolvingTypeTree.
17246 * parameter.cs (Parameter.Resolve): Change argument to
17247 EmitContext. Use ResolveAsTypeTerminal.
17248 (Parameter.GetSignature): Change argument to EmitContext.
17249 (Parameters.ComputeSignature): Likewise.
17250 (Parameters.ComputeParameterTypes): Likewise.
17251 (Parameters.GetParameterInfo): Likewise.
17252 (Parameters.ComputeAndDefineParameterTypes): Likewise.
17253 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
17254 * support.cs (InternalParameters..ctor): Remove variant that takes
17256 * typemanager.cs (system_intptr_expr): New.
17257 (InitExpressionTypes): Initialize it.
17259 2004-10-12 Chris Toshok <toshok@ximian.com>
17261 * cs-parser.jay: fix location for try_statement and catch_clause.
17263 2004-10-11 Martin Baulig <martin@ximian.com>
17265 * report.cs: Don't make --fatal abort on warnings, we have
17266 -warnaserror for that.
17268 2004-10-07 Raja R Harinath <rharinath@novell.com>
17270 More DeclSpace.ResolveType avoidance.
17271 * decl.cs (MemberCore.InUnsafe): New property.
17272 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
17273 with newly created EmitContext.
17274 (FieldMember.Define): Likewise.
17275 * delegate.cs (Delegate.Define): Likewise.
17276 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
17277 only if normal name-lookup fails.
17278 (TypeExpr.DoResolve): Enable error-checking.
17279 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
17280 (SizeOf.DoResolve): Likewise.
17281 (ComposedCast.DoResolveAsTypeStep): Likewise.
17282 (StackAlloc.DoResolve): Likewise.
17283 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
17284 (Block.Unsafe): New property.
17285 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
17286 (Unsafe): Set 'unsafe' flag of contained block.
17287 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
17288 (Fixed.Resolve): Likewise.
17289 (Catch.Resolve): Likewise.
17290 (Using.ResolveLocalVariableDecls): Likewise.
17291 (Foreach.Resolve): Likewise.
17293 2004-10-05 John Luke <john.luke@gmail.com>
17295 * cs-parser.jay: add location to error CS0175
17297 2004-10-04 Miguel de Icaza <miguel@ximian.com>
17299 * ecore.cs (Expression.Constantity): Add support for turning null
17302 * const.cs (Const.Define): Allow constants to be reference types
17303 as long as the value is Null.
17305 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
17307 * namespace.cs (NamespaceEntry.Using): No matter which warning
17308 level is set, check if this namespace name has already been added.
17310 2004-10-03 Ben Maurer <bmaurer@ximian.com>
17312 * expression.cs: reftype [!=]= null should always use br[true,false].
17315 2004-10-03 Marek Safar <marek.safar@seznam.cz>
17318 * attribute.cs: Enum conversion moved to
17319 GetAttributeArgumentExpression to be applied to the all
17322 2004-10-01 Raja R Harinath <rharinath@novell.com>
17324 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
17325 * class.c (TypeContainer.DefineType): Flag error if
17326 base types aren't accessible due to access permissions.
17327 * decl.cs (DeclSpace.ResolveType): Move logic to
17328 Expression.ResolveAsTypeTerminal.
17329 (DeclSpace.ResolveTypeExpr): Thin layer over
17330 Expression.ResolveAsTypeTerminal.
17331 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
17332 Refactor code into NestedAccess. Use it.
17333 (DeclSpace.NestedAccess): New.
17334 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
17335 argument to silence errors. Check access permissions.
17336 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
17337 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
17338 (Cast.DoResolve): Likewise.
17339 (New.DoResolve): Likewise.
17340 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
17341 (TypeOf.DoResolve): Likewise.
17343 * expression.cs (Invocation.BetterConversion): Return the Type of
17344 the better conversion. Implement section 14.4.2.3 more faithfully.
17345 (Invocation.BetterFunction): Make boolean. Make correspondence to
17346 section 14.4.2.2 explicit.
17347 (Invocation.OverloadResolve): Update.
17348 (Invocation): Remove is_base field.
17349 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
17350 (Invocation.Emit): Likewise.
17352 2004-09-27 Raja R Harinath <rharinath@novell.com>
17354 * README: Update to changes.
17356 2004-09-24 Marek Safar <marek.safar@seznam.cz>
17358 * cs-parser.jay: Reverted 642 warning fix.
17360 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17363 * decl.cs (FindMemberWithSameName): Indexer can have more than
17366 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17368 * expression.cs (LocalVariableReference.DoResolveLValue):
17369 Do not report warning 219 for out values.
17370 (EmptyExpression.Null): New member to avoid extra allocations.
17372 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17374 * cs-parser.jay: Fix wrong warning 642 report.
17376 * cs-tokenizer.cs (CheckNextToken): New helper;
17377 Inspect next character if is same as expected.
17379 2004-09-23 Martin Baulig <martin@ximian.com>
17381 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17382 (Convert.ImplicitReferenceConversionExists): Likewise.
17384 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17386 * class.cs (Operator.Define): Add error 448 and 559 report.
17388 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17390 * class.cs (MemberBase.IsTypePermitted): New protected
17391 method for checking error CS0610.
17393 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17395 * class.cs (TypeContainer.HasExplicitLayout): New property
17396 Returns whether container has StructLayout attribute set Explicit.
17397 (FieldMember): New abstract class for consts and fields.
17398 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17399 (Field): Reuse FieldMember.
17401 * const.cs (Const): Reuse FieldMember.
17403 * rootcontext.cs: EmitConstants call moved to class.
17405 2004-09-22 Martin Baulig <martin@ximian.com>
17407 Thanks to Peter Sestoft for this bug report.
17409 * expression.cs (Conditional): If both the `trueExpr' and the
17410 `falseExpr' is a NullLiteral, return a NullLiteral.
17412 2004-09-22 Martin Baulig <martin@ximian.com>
17414 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17415 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17416 for the "get_Current" call.
17418 2004-09-22 Martin Baulig <martin@ximian.com>
17420 Marek and me just fixed one of our oldest bugs: #28562 :-)
17422 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17424 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17425 we're an EnumConstant, just return that.
17426 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17427 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17428 to get the value which'll actually be written into the attribute.
17429 However, we have to use GetValue() to access the attribute's value
17432 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17434 * constant.cs (Constant.IsNegative): New abstract property
17437 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17438 (StackAlloc.DoResolve): Reused IsNegative.
17440 2004-09-21 Martin Baulig <martin@ximian.com>
17442 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17443 if we're used in an iterator, we may be called from different
17446 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17447 we actually have an exception block.
17449 2004-09-20 John Luke <jluke@cfl.rr.com>
17451 * class.cs, cs-parser.jay: Improve the error report for 1520:
17452 report the actual line where the error happens, not where the
17453 class was declared.
17455 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17456 Pass location information that was available elsewhere.
17458 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17460 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17461 runtime to delay sign assemblies.
17463 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17465 * cs-parser.jay: Do not report the stack trace, this is barely
17468 2004-08-22 John Luke <john.luke@gmail.com>
17470 * driver.cs : check that a resource id is not already used
17471 before adding it, report CS1508 if it is, bug #63637
17473 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17475 * ecore.cs: Removed dead code.
17477 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17479 * class.cs: Do not report warning CS0067 on the interfaces.
17481 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17483 * cs-parser.jay: Add error 504 report.
17485 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17487 * rootcontext.cs: WarningLevel is 4 by default now.
17489 * statement.cs (Fixed.Resolve): Do not null
17492 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17495 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17496 deep search when property is not virtual.
17497 (PropertyExpr.ResolveAccessors): Make one call for both
17500 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17503 * statement.cs: Error 152 report constains also location.
17505 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17508 * const.cs: Explicitly set constant as static.
17510 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17513 * cs-parser.jay: Add error 1017 report.
17515 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17517 Fixed bug #59980, #64224
17518 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17520 * typemanager.cs (IsSpecialMethod): Simplified
17522 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17524 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17525 condition with better params.
17527 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17530 * attribute.cs (Resolve): Property has to have both
17533 2004-09-14 Martin Baulig <martin@ximian.com>
17535 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17537 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17540 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17541 called and is obsolete then this member suppress message
17542 when call is inside next [Obsolete] method or type.
17544 * expression.cs: Use TestObsoleteMethodUsage member.
17546 2004-09-14 Martin Baulig <martin@ximian.com>
17548 * cs-parser.jay: Sync a bit with the GMCS version.
17550 2004-09-14 Martin Baulig <martin@ximian.com>
17552 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17553 (CSharpParser.yacc_verbose_flag): New public field.
17555 * genericparser.cs: Removed.
17557 2004-09-14 Raja R Harinath <rharinath@novell.com>
17559 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17561 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17563 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17565 2004-09-10 Martin Baulig <martin@ximian.com>
17567 Backported my MemberName changes from GMCS into MCS.
17569 - we are now using a special `MemberName' class instead of using
17570 strings; in GMCS, the `MemberName' also contains the type
17573 - changed the grammar rules a bit:
17574 * the old `member_name' is now a `namespace_or_type_name':
17575 The rule is that we use `namespace_or_type_name' everywhere
17576 where we expect either a "member name" (GetEnumerator) or a
17577 "member name" with an explicit interface name
17578 (IEnumerable.GetEnumerator).
17579 In GMCS, the explicit interface name may include type arguments
17580 (IEnumerable<T>.GetEnumerator).
17581 * we use `member_name' instead of just `IDENTIFIER' for
17583 The rule is that we use `member_name' wherever a member may
17584 have type parameters in GMCS.
17586 * decl.cs (MemberName): New public class.
17587 (MemberCore.MemberName): New public readonly field.
17588 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17589 (DeclSpace): Likewise.
17591 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17592 * enum.cs (Enum.ctor): Likewise.
17594 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17596 (AliasEntry.ctor): Take a MemberName, not an Expression.
17597 (AliasEntry.UsingAlias): Likewise.
17599 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17600 (IMethodData.MemberName): Changed type from string to MemberName.
17601 (MemberBase.ExplicitInterfaceName): Likewise.
17602 (AbstractPropertyEventMethod.SetupName): Make this private.
17603 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17604 argument; compute the member name here.
17605 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17606 on the `member.MemberName' and the `prefix'.
17608 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17610 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17611 thus, we get a `MemberName' instead of a `string'. These
17612 declarations may have type parameters in GMCS.
17613 (interface_method_declaration, delegate_declaration): Likewise.
17614 (class_declaration, interface_declaration): Likewise.
17615 (method_header): Use `namespace_or_type_name' instead of
17616 `member_name'. We may be an explicit interface implementation.
17617 (property_declaration, event_declaration): Likewise.
17618 (member_name): This is now just an `IDENTIFIER', not a
17619 `namespace_or_type_name'.
17620 (type_name, interface_type): Removed.
17621 (namespace_or_type_name): Return a MemberName, not an Expression.
17622 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17623 call GetTypeExpression() on the MemberName to get an expression.
17624 (IndexerDeclaration.interface_type): Changed type from string to
17626 (MakeName): Operate on MemberName's instead of string's.
17628 2004-09-13 Raja R Harinath <rharinath@novell.com>
17631 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17632 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17633 lookup to avoid symbols introduced by 'using'.
17634 * rootcontext.cs (NamespaceLookup): Update.
17636 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17638 * class.cs (TypeContainer.DoDefineMembers): Do not call
17639 DefineDefaultConstructor for static classes.
17641 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17643 * attribute.cs (Attribute.Resolve): Add error 653 report.
17645 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17647 (Method.ApplyAttributeBuilder): Add error 685 report.
17648 (Operator.Define): Add error 564 report.
17650 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17652 * expression.cs (Invocation.DoResolve): Add error
17653 245 and 250 report.
17655 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17658 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17660 * class.cs (ConstructorInitializer.Resolve):
17661 Wrong error number (515->516).
17663 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17665 * class.cs (Indexer.Define): Add error 631 report.
17667 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17669 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17671 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17673 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17675 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17677 * cs-parser.jay: Added error CS0241 report.
17679 2004-09-10 Raja R Harinath <rharinath@novell.com>
17681 * cs-parser.jay (fixed_statement): Introduce a scope for the
17682 declaration in the 'fixed' statement.
17684 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17686 * cs-parser.jay: Added CS0230 error report.
17688 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17690 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17692 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17694 * expression.cs (Argument.Resolve): Added error CS0192 and
17697 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17699 C# 2.0 #pragma warning feature
17701 * cs-tokenizer.cs (PreProcessPragma): New method;
17702 Handles #pragma directive.
17704 * report.cs (WarningRegions): New class; Support
17705 class for #pragma warning directive. It tests whether
17706 warning is enabled for a given line.
17708 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17710 * const.cs: Add more descriptive error report, tahnks to
17713 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17715 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17717 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17719 * expression.cs: Apply patch from Ben: Remove dead code from
17720 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17721 as that code just threw an exception anwyays.
17723 * const.cs: Remove the call to the turnintoconstant, for details
17726 * literal.cs: The type of the null-literal is the null type; So
17727 we use a placeholder type (literal.cs:System.Null, defined here)
17730 * expression.cs (Conditional.DoResolve): Remove some old code that
17731 is no longer needed, conversions have been fixed.
17733 (ArrayCreationExpression.DoResolve): Return false if we fail to
17734 resolve the inner expression.
17736 2004-09-07 Raja R Harinath <rharinath@novell.com>
17739 * cs-parser.jay (delegate_declaration): Record a delegate
17740 declaration as a type declaration.
17741 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17743 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17745 * parameter.cs: Do not crash if the type can not be resolved.
17747 * expression.cs: Report errors with unsafe pointers, fixes #64896
17749 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17751 * expression.cs: Pointer arith always needs to do a conv.i
17752 if the operand is a long. fix 65320
17754 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17756 Fixed cs0619-37.cs, cs0619-38.cs
17758 * enum.cs (GetObsoleteAttribute): Removed.
17760 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17761 on Enum member is double staged. The first is tested member
17764 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17766 Fixed #56986, #63631, #65231
17768 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17769 adds member to name container.
17770 (TypeContainer.AddToTypeContainer): New method, adds type to
17772 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17773 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17774 AddOperator): Simplified by reusing AddToMemberContainer.
17775 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17777 (Method.CheckForDuplications): Fixed implementation to test all
17779 (MemberBase): Detection whether member is explicit interface
17780 implementation is now in constructor.
17781 (MemberBase.UpdateMemberName): Handles IndexerName.
17782 (Accessor): Changed to keep also location information.
17783 (AbstractPropertyEventMethod): Is derived from MemberCore.
17784 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17785 will be emited or not.
17786 (PropertyBase.AreAccessorsDuplicateImplementation):
17787 Tests whether accessors are not in collision with some method.
17788 (Operator): Is derived from MethodCore to simplify common
17791 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17793 (DeclSpace.AddToContainer): Adds the member to defined_names
17794 table. It tests for duplications and enclosing name conflicts.
17796 * enum.cs (EnumMember): Clean up to reuse the base structures
17798 2004-09-03 Martin Baulig <martin@ximian.com>
17800 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17801 into TypeContainer, to make partial classes work again.
17803 2004-09-03 Martin Baulig <martin@ximian.com>
17805 * rootcontext.cs (RootContext.V2): Removed.
17807 2004-03-23 Martin Baulig <martin@ximian.com>
17809 * expression.cs (Invocation.OverloadResolve): Added `bool
17810 may_fail' argument and use it instead of the Location.IsNull() hack.
17812 2004-09-03 Martin Baulig <martin@ximian.com>
17814 Merged latest changes into gmcs. Please keep this comment in
17815 here, it makes it easier for me to see what changed in MCS since
17816 the last time I merged.
17818 2004-09-03 Raja R Harinath <rharinath@novell.com>
17821 * expression.cs (BetterConversion): Don't allow either conversion
17822 to be null. Remove redundant implicit conversion test when 'q ==
17823 null' -- when this function is invoked, we already know that the
17824 implicit conversion exists.
17825 (BetterFunction): Assume that 'best' is non-null. Remove
17826 redundant reimplementation of IsApplicable when 'best' is null.
17827 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17828 number of arguments.
17829 (IsAncestralType): Extract from OverloadResolve.
17830 (OverloadResolve): Make robust to the MethodGroupExpr being
17831 unsorted. Implement all the logic of Section 14.5.5.1, and
17832 support overloading of methods from multiple applicable types.
17833 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17835 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17836 (RealError, Warning): Append type of report to related symbol.
17838 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17840 * enum.cs: Fixed CLS-Compliance checks for enum members.
17841 Error tests cs3008-8.cs, cs3014-8.cs
17843 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17845 Fixed bug #62342, #63102
17846 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17847 like ImplementMethod.
17849 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17851 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17854 2004-09-02 Martin Baulig <martin@ximian.com>
17856 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17857 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17860 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17862 C# 2.0 Static classes implemented
17864 * class.cs (TypeContainer): instance_constructors,
17865 initialized_fields, initialized_static_fields,
17866 default_constructor, base_inteface_types are protected to be
17867 accessible from StaticClass.
17868 (TypeContainer.DefineDefaultConstructor): New virtual method
17869 for custom default constructor generating
17870 (StaticClass): New class to handle "Static classes" feature.
17872 * cs-parser.jay: Handle static keyword on class like instance
17875 * driver.cs: Added "/langversion" command line switch with two
17876 options (iso-1, default).
17878 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17880 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17882 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17884 * delegate.cs: Style.
17886 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17888 * delegate.cs: Add seperate instance expr field for miguel.
17890 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17892 * PointerArithmetic (Resolve): make sure we are not doing
17893 pointer arith on void*. Also, make sure we are resolved
17894 by not setting eclass until resolve.
17896 All callers: Make sure that PointerArithmetic gets resolved.
17898 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17900 * ArrayCreation (LookupType): If the type does not resolve
17901 to an array, give an error.
17903 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17905 * statement.cs (Try.Resolve): Fixed bug #64222
17907 2004-08-27 Martin Baulig <martin@ximian.com>
17910 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17913 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17915 * ecore.cs (Constantify): Get underlying type via
17916 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17917 Windows in special cases.
17919 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17921 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17922 for obtaining also private methods.
17923 (GetRemoveMethod): Used GetRemoveMethod (true)
17924 for obtaining also private methods.
17926 2004-08-24 Martin Baulig <martin@ximian.com>
17928 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17929 MethodAttributes.HideBySig for operators.
17931 2004-08-23 Martin Baulig <martin@ximian.com>
17933 Back to the old error reporting system :-)
17935 * report.cs (Message): Removed.
17936 (Report.MessageData, ErrorData, WarningData): Removed.
17937 (Report.Error, Warning): Back to the old system.
17939 2004-08-23 Martin Baulig <martin@ximian.com>
17941 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17943 * class.cs (TypeContainer.ParentContainer): New public virtual
17944 method; replaces the explicit interface implementation.
17945 (ClassPart.ParentContainer): Override.
17947 2004-08-23 Martin Baulig <martin@ximian.com>
17949 * statement.cs (Switch): Added support for constant switches; see
17950 #59428 or test-285.cs.
17952 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17955 * statement.cs (GetEnumeratorFilter): Removed useless
17956 logic because C# specs is strict. GetEnumerator must be
17959 2004-08-22 Martin Baulig <martin@ximian.com>
17961 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17962 a switch and may break, reset the barrier. Fixes #59867.
17964 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17966 CLS-Compliance speed up (~5% for corlib)
17968 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17969 New method. Tests container for CLS-Compliant names
17971 * class.cs (TypeContainer.VerifyClsName): New method.
17972 Checks whether container name is CLS Compliant.
17973 (Constructor): Implements IMethodData.
17975 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17976 low-case table for CLS Compliance test.
17977 (MemberCache.VerifyClsParameterConflict): New method.
17978 Checks method parameters for CS3006 error.
17980 * enum.cs (EnumMember): Is derived from MemberCore.
17981 (Enum.VerifyClsName): Optimized for better performance.
17983 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17985 * report.cs: Renamed Error_T to Error and changed all
17988 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17990 * class.cs (TypeContainer.IndexerArrayList): New inner class
17991 container for indexers.
17992 (TypeContainer.DefaultIndexerName): New constant for default
17993 indexer name. Replaced all "Item" with this constant.
17994 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17996 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17997 DefaultMemberAttribute constructor.
17999 2004-08-05 Martin Baulig <martin@ximian.com>
18001 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
18004 2004-08-05 Marek Safar <marek.safar@seznam.cz>
18006 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
18007 multi platforms problem.
18009 * compiler.csproj: Included shared files.
18011 2004-08-04 Marek Safar <marek.safar@seznam.cz>
18013 Fix bug 60333, 55971 in the more general way
18014 * attribute.cs (Attribute.GetAttributeArgumentExpression):
18015 Added arg_type argument for constant conversion.
18016 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
18018 2004-08-04 Marek Safar <marek.safar@seznam.cz>
18021 * class.cs (TypeContainer ): New inner classes MethodArrayList,
18022 OperatorArrayList, MethodCoreArrayList for typecontainer
18023 containers. Changed class member types to these new types.
18024 (MethodArrayList.DefineMembers): Added test for CS0659.
18026 2004-08-04 Miguel de Icaza <miguel@ximian.com>
18028 * cfold.cs: Synchronize the folding with the code in expression.cs
18029 Binary.DoNumericPromotions for uint operands.
18031 * attribute.cs: Revert patch from Raja, it introduced a regression
18032 while building Blam-1.2.1 (hard to isolate a test case).
18034 2004-08-04 Marek Safar <marek.safar@seznam.cz>
18038 (TypeContainer.Define): Renamed to DefineContainerMembers because of
18040 (MethodCore.parent_method): New member. The method we're overriding
18041 if this is an override method.
18042 (MethodCore.CheckBase): Moved from Method class and made common.
18043 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
18045 (MethodCore.CheckForDuplications): New abstract method. For custom
18046 member duplication search in a container
18047 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
18048 method and its return type.
18049 (Event.conflict_symbol): New member. Symbol with same name in the
18053 (MemberCache.FindMemberWithSameName): New method. The method
18054 is looking for conflict with inherited symbols.
18056 2004-08-04 Martin Baulig <martin@ximian.com>
18058 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
18060 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
18062 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18064 * report.cs (Message): New enum for better error, warning reference in
18066 (MessageData): New inner abstract class. It generally handles printing of
18067 error and warning messages.
18068 Removed unused Error, Warning, Message methods.
18070 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18072 Fix for cs0592-8.cs test
18074 (Attributable.ValidAttributeTargets): Made public.
18075 (Attribute.ExplicitTarget): New member for explicit target value.
18076 (Attribute.CheckTargets): Now we translate explicit attribute
18077 target to Target here.
18079 2004-08-03 Ben Maurer <bmaurer@ximian.com>
18081 * ecore.cs (MethodGroupExpr): new IsBase property.
18083 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
18085 * delegate.cs (DelegateCreation): store a MethodGroupExpr
18086 rather than an instance expr.
18088 (DelegateCreation.Emit): Use the method group rather than
18089 the instance expression. Also, if you have base.Foo as the
18090 method for a delegate, make sure to emit ldftn, not ldftnvirt.
18092 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
18094 (NewDelegate.DoResolve): Only check for the existance of Invoke
18095 if the method is going to be needed. Use MethodGroupExpr.
18097 (NewDelegate.Emit): Remove, DelegateCreation implements this.
18099 * expression.cs: For pointer arith., make sure to use
18100 the size of the type, not the size of the pointer to
18103 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18106 * class.cs (Class): Added error CS0502 test.
18108 2004-08-03 John Luke <jluke@cfl.rr.com>
18109 Raja R Harinath <rharinath@novell.com>
18112 * attribute.cs (Attribute.complained_before): New flag.
18113 (Attribute.ResolveType, Attribute.Resolve),
18114 (Attribute.DefinePInvokeMethod): Set it.
18115 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
18117 2004-08-03 Martin Baulig <martin@ximian.com>
18119 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
18120 use a user-defined operator; we still need to do numeric
18121 promotions in case one argument is a builtin type and the other
18122 one has an implicit conversion to that type. Fixes #62322.
18124 2004-08-02 Martin Baulig <martin@ximian.com>
18126 * statement.cs (LocalInfo.Flags): Added `IsThis'.
18127 (LocalInfo.IsThis): New public property.
18128 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
18130 2004-08-01 Martin Baulig <martin@ximian.com>
18132 * class.cs (TypeContainer.GetClassBases): Don't set the default
18133 here since we may get called from GetPartialBases().
18134 (TypeContainer.DefineType): If GetClassBases() didn't return a
18135 parent, use the default one.
18137 2004-07-30 Duncan Mak <duncan@ximian.com>
18139 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
18141 2004-07-30 Martin Baulig <martin@ximian.com>
18143 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
18145 * class.cs (SourceMethod): New public class, derive from the
18146 symbol writer's ISourceMethod.
18147 (Method): Use the new symbol writer API.
18149 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
18150 as argument and use the new symbol writer.
18153 (SourceFile): Implement the symbol writer's ISourceFile.
18154 (Location.SymbolDocument): Removed.
18155 (Location.SourceFile): New public property.
18157 * symbolwriter.cs: Use the new symbol writer API.
18159 2004-07-30 Raja R Harinath <rharinath@novell.com>
18161 * Makefile (install-local): Remove. Functionality moved to
18164 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
18166 * Makefile: Install mcs.exe.config file together with mcs.exe.
18167 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
18168 correct runtime version.
18170 2004-07-25 Martin Baulig <martin@ximian.com>
18173 (TypeContainer.RegisterOrder): Removed, this was unused.
18174 (TypeContainer, interface_order): Removed.
18175 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
18176 TypeContainer as argument since we can also be called with a
18177 `PartialContainer' for a partial class/struct/interface.
18178 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
18179 of checking whether we're an `Interface' - we could be a
18180 `PartialContainer'.
18181 (PartialContainer.Register): Override; call
18182 AddClass()/AddStruct()/AddInterface() on our parent.
18184 * cs-parser.jay (interface_member_declaration): Add things to the
18185 `current_container', not the `current_class'.
18187 * rootcontext.cs (RegisterOrder): The overloaded version which
18188 takes an `Interface' was unused, removed.
18190 * typemanager.cs (TypeManager.LookupInterface): Return a
18191 `TypeContainer', not an `Interface'.
18192 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
18193 contain a `PartialContainer' for an interface, so check it's
18194 `Kind' to figure out what it is.
18196 2004-07-25 Martin Baulig <martin@ximian.com>
18198 * class.cs (Class.DefaultTypeAttributes): New public constant.
18199 (Struct.DefaultTypeAttributes): Likewise.
18200 (Interface.DefaultTypeAttributes): Likewise.
18201 (PartialContainer.TypeAttr): Override this and add the
18202 DefaultTypeAttributes.
18204 2004-07-25 Martin Baulig <martin@ximian.com>
18206 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
18207 we can just use the `Parent' field instead.
18209 2004-07-25 Martin Baulig <martin@ximian.com>
18211 * class.cs (TypeContainer.Emit): Renamed to EmitType().
18213 2004-07-25 Martin Baulig <martin@ximian.com>
18215 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
18216 our parts before defining any methods.
18217 (TypeContainer.VerifyImplements): Make this virtual.
18218 (ClassPart.VerifyImplements): Override and call VerifyImplements()
18219 on our PartialContainer.
18221 2004-07-25 Martin Baulig <martin@ximian.com>
18223 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
18225 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
18226 argument, we can just use the `Parent' field instead.
18229 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
18230 (MemberBase.DoDefine): Likewise.
18232 2004-07-24 Martin Baulig <martin@ximian.com>
18234 * decl.cs (MemberCore.Parent): New public field.
18235 (DeclSpace.Parent): Moved to MemberCore.
18237 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
18238 (MemberBase.ctor): Added TypeContainer argument, pass it to our
18240 (FieldBase, Field, Operator): Likewise.
18241 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
18242 (EventField, Event): Likewise.
18244 2004-07-23 Martin Baulig <martin@ximian.com>
18246 * class.cs (PartialContainer): New public class.
18247 (ClassPart): New public class.
18248 (TypeContainer): Added support for partial classes.
18249 (TypeContainer.GetClassBases): Splitted some of the functionality
18250 out into GetNormalBases() and GetPartialBases().
18252 * cs-tokenizer.cs (Token.PARTIAL): New token.
18253 (Tokenizer.consume_identifier): Added some hacks to recognize
18254 `partial', but only if it's immediately followed by `class',
18255 `struct' or `interface'.
18257 * cs-parser.jay: Added support for partial clases.
18259 2004-07-23 Martin Baulig <martin@ximian.com>
18261 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
18262 a `DeclSpace' and also made it readonly.
18263 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
18264 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
18265 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
18267 * cs-parser.jay: Pass the `current_class', not the
18268 `current_container' (at the moment, this is still the same thing)
18269 to a new Method, Property, Event, Indexer or Constructor.
18271 2004-07-23 Martin Baulig <martin@ximian.com>
18273 * cs-parser.jay (CSharpParser): Added a new `current_class' field
18274 and removed the `current_interface' one.
18275 (struct_declaration, class_declaration, interface_declaration):
18276 Set `current_class' to the newly created class/struct/interface;
18277 set their `Bases' and call Register() before parsing their body.
18279 2004-07-23 Martin Baulig <martin@ximian.com>
18281 * class.cs (Kind): New public enum.
18282 (TypeContainer): Made this class abstract.
18283 (TypeContainer.Kind): New public readonly field.
18284 (TypeContainer.CheckDef): New public method; moved here from
18286 (TypeContainer.Register): New public abstract method.
18287 (TypeContainer.GetPendingImplementations): New public abstract
18289 (TypeContainer.GetClassBases): Removed the `is_class' and
18290 `is_iface' parameters.
18291 (TypeContainer.DefineNestedTypes): Formerly known as
18293 (ClassOrStruct): Made this class abstract.
18295 * tree.cs (RootTypes): New public type.
18297 2004-07-20 Martin Baulig <martin@ximian.com>
18299 * tree.cs (Tree.RecordNamespace): Removed.
18300 (Tree.Namespaces): Removed.
18302 * rootcontext.cs (RootContext.IsNamespace): Removed.
18304 * cs-parser.jay (namespace_declaration): Just create a new
18305 NamespaceEntry here.
18307 2004-07-20 Martin Baulig <martin@ximian.com>
18309 * statement.cs (ExceptionStatement): New abstract class. This is
18310 now used as a base class for everyone who's using `finally'.
18311 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
18312 our local variables before using them.
18314 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
18315 virtual method. This is used by Yield.Resolve() to "steal" an
18316 outer block's `finally' clauses.
18317 (FlowBranchingException): The .ctor now takes an ExceptionStatement
18320 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
18321 version which takes an ExceptionStatement. This version must be
18322 used to create exception branchings.
18325 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
18326 (Iterator.EmitMoveNext): Added exception support; protect the
18327 block with a `fault' clause, properly handle 'finally' clauses.
18328 (Iterator.EmitDispose): Run all the `finally' clauses here.
18330 2004-07-20 Martin Baulig <martin@ximian.com>
18332 * iterator.cs: This is the first of a set of changes in the
18333 iterator code. Match the spec more closely: if we're an
18334 IEnumerable, then GetEnumerator() must be called. The first time
18335 GetEnumerator() is called, it returns the current instance; all
18336 subsequent invocations (if any) must create a copy.
18338 2004-07-19 Miguel de Icaza <miguel@ximian.com>
18340 * expression.cs: Resolve the constant expression before returning
18343 2004-07-19 Martin Baulig <martin@ximian.com>
18345 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
18346 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
18347 the return type of the new EmitContext.
18349 2004-07-18 Martin Baulig <martin@ximian.com>
18351 * class.cs (Property.Define): Fix iterators.
18353 * iterators.cs (Iterator.Define): Moved the
18354 `container.AddInterator (this)' call here from the .ctor; only do
18355 it if we resolved successfully.
18357 2004-07-17 Miguel de Icaza <miguel@ximian.com>
18359 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
18360 `true' for preprocessing directives that we parse. The return
18361 value indicates whether we should return to regular tokenizing or
18362 not, not whether it was parsed successfully.
18364 In the past if we were in: #if false ... #line #endif, we would
18365 resume parsing after `#line'. See bug 61604.
18367 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18368 building: IsEnumType should return true only for enums, not for
18369 enums or System.Enum itself. This fixes #61593.
18371 Likely what happened is that corlib was wrong: mcs depended on
18372 this bug in some places. The bug got fixed, we had to add the
18373 hack, which caused bug 61593.
18375 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18376 that was a workaround for the older conditions.
18378 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18380 * assign.cs: IAssignMethod has a new interface, as documented
18381 inline. All assignment code now uses this new api.
18383 * ecore.cs, expression.cs: All classes which implement
18384 IAssignMethod now use the new interface.
18386 * expression.cs (Invocation): add a hack to EmitCall so that
18387 IndexerAccess can be the target of a compound assignment without
18388 evaluating its arguments twice.
18390 * statement.cs: Handle changes in Invocation api.
18392 2004-07-16 Martin Baulig <martin@ximian.com>
18394 * iterators.cs: Rewrote this. We're now using one single Proxy
18395 class for both the IEnumerable and the IEnumerator interface and
18396 `Iterator' derives from Class so we can use the high-level API.
18398 * class.cs (TypeContainer.AddIterator): New method.
18399 (TypeContainer.DoDefineType): New protected virtual method, which
18400 is called from DefineType().
18401 (TypeContainer.DoDefineMembers): Call DefineType() and
18402 DefineMembers() on all our iterators.
18403 (TypeContainer.Emit): Call Emit() on all our iterators.
18404 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18406 * codegen.cs (EmitContext.CurrentIterator): New public field.
18408 2004-07-15 Martin Baulig <martin@ximian.com>
18411 (TypeManager.not_supported_exception_type): New type.
18413 2004-07-14 Martin Baulig <martin@ximian.com>
18415 * iterators.cs: Use real error numbers.
18417 2004-07-14 Martin Baulig <martin@ximian.com>
18419 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18420 requires this to be a System.Collection.IEnumerable and not a
18421 class implementing that interface.
18422 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18424 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18426 * class.cs: Fixed previous fix, it broke some error tests.
18428 2004-07-12 Martin Baulig <martin@ximian.com>
18430 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18433 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18435 * assign.cs (LocalTemporary): Add new argument: is_address,If
18436 `is_address' is true, then the value that we store is the address
18437 to the real value, and not the value itself.
18439 * ecore.cs (PropertyExpr): use the new local temporary
18440 stuff to allow us to handle X.Y += z (where X is a struct)
18442 2004-07-08 Martin Baulig <martin@ximian.com>
18444 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18445 not always return, just like we're doing in Using.Resolve().
18447 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18449 * cs-parser.jay (fixed_statement): flag this as Pinned.
18451 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18453 * typemanager.cs (TypeManager): Removed MakePinned method, this
18454 mechanism is replaced with the .NET 2.x compatible mechanism of
18455 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18457 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18458 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18459 `IsFixed' property which has a different meaning.
18461 2004-07-02 Raja R Harinath <rharinath@novell.com>
18463 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18464 visible from inside a nested class, not just the names of the
18465 immediately enclosing class.
18466 Fix for bug #60730.
18468 2004-06-24 Raja R Harinath <rharinath@novell.com>
18470 * expression.cs (BetterConversion): Remove buggy special-case
18471 handling of "implicit constant expression conversions". At this
18472 point, we already know that the conversion is possible -- we're
18473 only checking to see which is better.
18475 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18477 * cs-parser.jay: Added error CS0210 test.
18479 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18481 * cs-parser.jay: Added error CS0134 test.
18483 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18486 * cs-parser.jay: Added error CS0145 test.
18488 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18490 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18492 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18494 * expression.cs (StackAlloc.Resolve): The argument may not
18495 be a constant; deal with this case.
18497 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18499 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18500 GetIndexerAttributeValue.
18501 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18503 * class.cs (Indexer.Define): Added error tests for CS0415,
18506 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18508 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18511 2004-06-23 Martin Baulig <martin@ximian.com>
18513 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18514 neither return nor throw, reset the barrier as well. Fixes #60457.
18516 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18518 * class.cs : EventAttributes is now set to None by default.
18519 This fixes bug #60459.
18521 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18524 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18525 Don't throw exception but return null (it's sufficient now).
18527 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18529 * typemanager.cs (GetArgumentTypes): Faster implementation.
18531 2004-06-18 Martin Baulig <martin@ximian.com>
18533 * attribute.cs (Attribute.Resolve): Check whether we're an
18534 EmptyCast which a Constant child. Fixes #60333.
18536 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18538 * statement.cs (EmitCollectionForeach): Account for the fact that
18539 not all valuetypes are in areas which we can take the address of.
18540 For these variables, we store to a temporary variable. Also, make
18541 sure that we dont emit a `callvirt' on a valuetype method.
18543 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18545 * expression.cs (StackAlloc.DoReSolve): Added test for
18546 negative parameter (CS0247).
18548 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18551 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18553 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18556 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18559 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18561 Fix bug #58254 & cs1555.cs, cs1556.cs
18562 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18564 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18566 * cs-parser.jay: Added error CS1669 test for indexers.
18568 2004-06-11 Martin Baulig <martin@ximian.com>
18570 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18571 call this twice: for params and varargs methods.
18573 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18576 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18578 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18580 * attribute.cs (Attribute.GetValidTargets): Made public.
18583 (AbstractPropertyEventMethod): New class for better code sharing.
18584 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18586 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18588 2004-06-11 Raja R Harinath <rharinath@novell.com>
18591 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18592 that the call to Resolve is part of a MemberAccess.
18593 (Expression.Resolve): Use it for SimpleName resolution.
18594 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18595 Add 'intermediate' boolean argument.
18596 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18597 error message when the SimpleName can be resolved ambiguously
18598 between an expression and a type.
18599 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18601 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18602 call on the left-side.
18604 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18607 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18609 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18611 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18613 2004-06-11 Martin Baulig <martin@ximian.com>
18615 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18616 varargs methods if applicable.
18618 2004-06-11 Martin Baulig <martin@ximian.com>
18620 * expression.cs (Invocation.EmitCall): Don't use
18621 `method.CallingConvention == CallingConventions.VarArgs' since the
18622 method could also have `CallingConventions.HasThis'.
18624 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18626 * class.cs (Event.GetSignatureForError): Implemented.
18627 Fixed crash in error test cs3010.cs
18629 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18631 * cs-tokenizer.cs: Change the way we track __arglist to be
18632 consistent with the other keywords.
18634 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18636 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18639 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18641 * codegen.cs: Check that all referenced assemblies have a strongname
18642 before strongnaming the compiled assembly. If not report error CS1577.
18643 Fix bug #56563. Patch by Jackson Harper.
18644 * typemanager.cs: Added a method to return all referenced assemblies.
18645 Fix bug #56563. Patch by Jackson Harper.
18647 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18650 (Method.ApplyAttributeBuilder): Moved and added conditional
18651 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18654 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18656 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18659 * class.cs: (EventField.attribute_targets): Changed default target.
18661 2004-06-08 Martin Baulig <martin@ximian.com>
18663 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18665 2004-06-08 Martin Baulig <martin@ximian.com>
18667 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18669 2004-06-07 Martin Baulig <martin@ximian.com>
18671 Added support for varargs methods.
18673 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18676 * cs-parser.jay: Added support for `__arglist'.
18678 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18680 * expression.cs (Argument.AType): Added `ArgList'.
18681 (Invocation): Added support for varargs methods.
18682 (ArglistAccess): New public class.
18683 (Arglist): New public class.
18685 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18687 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18688 a method's top-level block if the method has varargs.
18690 * support.cs (ReflectionParameters, InternalParameters): Added
18691 support for varargs methods.
18693 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18695 * class.cs: Provide location in indexer error report.
18697 * driver.cs: Use standard names.
18699 * namespace.cs: Catch the use of using after a namespace has been
18700 declared also on using aliases.
18702 2004-06-03 Raja R Harinath <rharinath@novell.com>
18705 * typemanager.cs (closure_private_ok, closure_invocation_type)
18706 (closure_qualifier_type, closure_invocation_assembly)
18707 (FilterWithClosure): Move to ...
18708 (Closure): New internal nested class.
18709 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18710 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18711 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18712 (MemberLookup, MemberLookupFailed): Use it.
18713 * expression.cs (New.DoResolve): Treat the lookup for the
18714 constructor as being qualified by the 'new'ed type.
18715 (Indexers.GetIndexersForTypeOrInterface): Update.
18717 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18720 (GetConditionalAttributeValue): New method. Returns
18721 condition of ConditionalAttribute.
18722 (SearchMulti): New method. Returns all attributes of type 't'.
18723 Use it when attribute is AllowMultiple = true.
18724 (IsConditionalMethodExcluded): New method.
18727 (Method.IsExcluded): Implemented. Returns true if method has conditional
18728 attribute and the conditions is not defined (method is excluded).
18729 (IMethodData): Extended interface for ConditionalAttribute support.
18730 (PropertyMethod.IsExcluded): Implemented.
18733 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18736 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18739 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18741 * expression.cs (ArrayCreationExpression): Make this just an
18742 `expression'. It can't be a statement, so the code here was
18745 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18748 * typemanager.cs (GetFullNameSignature): New method for
18751 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18754 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18755 Use this method when MethodBuilder is null.
18756 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18757 Added test for error CS0626 (MONO reports error for this situation).
18758 (IMethodData.GetSignatureForError): Extended interface.
18760 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18763 (AttributeTester.GetObsoleteAttribute): Returns instance of
18764 ObsoleteAttribute when type is obsolete.
18767 (TypeContainer.VerifyObsoleteAttribute): Override.
18768 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18769 (MethodCode.VerifyObsoleteAttribute): Override.
18770 (MemberBase.VerifyObsoleteAttribute): Override.
18773 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18774 and report proper error.
18777 Delegate.VerifyObsoleteAttribute): Override.
18780 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18781 and report proper error.
18782 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18785 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18789 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18790 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18791 Added test for ObsoleteAttribute.
18794 (Catch): Derived from Statement.
18796 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18798 Fixed bug #59071 & cs0160.cs
18800 * statement.cs (Try.Resolve): Check here whether order of catch
18801 clauses matches their dependencies.
18803 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18805 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18806 caused a regression: #59343. Referencing nested classes from an
18807 assembly stopped working.
18809 2004-05-31 Martin Baulig <martin@ximian.com>
18811 MCS is now frozen for beta 2.
18813 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18815 * convert.cs: add a trivial cache for overload operator resolution.
18817 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18819 * decl.cs: If possible, use lookuptypedirect here. We can only do
18820 this if there is no `.' after the namespace. Avoids using
18821 LookupType, which does lots of slow processing.
18822 (FindNestedType) New method, does what it says :-).
18823 * namespace.cs: use LookupTypeDirect.
18824 * rootcontext.cs: use membercache, if possible.
18825 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18827 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18830 According to the spec,
18832 In a member access of the form E.I, if E is a single identifier,
18833 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18834 field, property, localvariable, or parameter with the same type as
18835 the meaning of E as a type-name (§3.8), then both possible
18836 meanings of E are permitted.
18838 We did not check that E as a simple-name had the same type as E as
18841 This trivial check gives us 5-7% on bootstrap time.
18843 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18845 * expression.cs (Invocation.OverloadResolve): Avoid the
18846 use of hashtables and boxing here by allocating on demand.
18848 2004-05-30 Martin Baulig <martin@ximian.com>
18850 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18851 we're doing a silent lookup. Don't try to lookup nested types in
18852 TypeManager.object_type (thanks to Ben Maurer).
18854 2004-05-30 Martin Baulig <martin@ximian.com>
18856 Committing a patch from Ben Maurer.
18858 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18860 2004-05-29 Martin Baulig <martin@ximian.com>
18862 * class.cs (IMethodData.ShouldIgnore): New method.
18864 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18865 `Location' argument, we don't need it anywhere. Use
18866 `IMethodData.ShouldIgnore ()' instead of
18867 `MethodData.GetMethodFlags ()'.
18868 (TypeManager.AddMethod): Removed.
18869 (TypeManager.AddMethod2): Renamed to AddMethod.
18871 2004-05-29 Martin Baulig <martin@ximian.com>
18873 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18875 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18876 converting from a class type S to an interface type and we already
18877 have an object on the stack, don't box it again. Fixes #52578.
18879 2004-05-29 Martin Baulig <martin@ximian.com>
18881 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18882 Added support for `params' parameters. Fixes #59267.
18884 2004-05-29 Martin Baulig <martin@ximian.com>
18886 * literal.cs (NullPointer): Provide a private .ctor which sets
18887 `type' to TypeManager.object_type. Fixes #59048.
18889 2004-05-29 Martin Baulig <martin@ximian.com>
18891 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18892 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18894 * ecore.cs (EventExpr.instance_expr): Make the field private.
18896 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18898 Fixed bug #50080 & cs0214-2.cs
18899 * expression.cs (Cast.DoResolve): Check unsafe context here.
18901 * statement.cs (Resolve.DoResolve): Likewise.
18903 2004-05-26 Martin Baulig <martin@ximian.com>
18905 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18907 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18908 (RootContext.LookupType): Pass down the `silent' flag.
18910 2004-05-25 Martin Baulig <martin@ximian.com>
18913 (MethodGroupExpr.IdenticalTypeName): New public property.
18914 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18915 expression actually refers to a type.
18917 2004-05-25 Martin Baulig <martin@ximian.com>
18919 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18920 for #56176 and made it actually work.
18922 2004-05-25 Martin Baulig <martin@ximian.com>
18924 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18925 (FieldExpr, PropertyExpr): Override and implement
18926 CacheTemporaries. Fixes #52279.
18928 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18930 * location.cs: In the new compiler listing a file twice is a
18931 warning, not an error.
18933 2004-05-24 Martin Baulig <martin@ximian.com>
18935 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18936 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18938 2004-05-24 Martin Baulig <martin@ximian.com>
18940 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18941 walking the `using' list. Fixes #53921.
18943 2004-05-24 Martin Baulig <martin@ximian.com>
18945 * const.cs (Const.LookupConstantValue): Added support for
18946 EmptyCast's; fixes #55251.
18948 2004-05-24 Martin Baulig <martin@ximian.com>
18950 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18951 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18952 which does the CS0135 check. The reason is that we first need to
18953 check whether the variable actually exists.
18955 2004-05-24 Martin Baulig <martin@ximian.com>
18957 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18958 than RootContext.LookupType() to find the explicit interface
18959 type. Fixes #58584.
18961 2004-05-24 Raja R Harinath <rharinath@novell.com>
18963 * Makefile: Simplify. Use executable.make.
18964 * mcs.exe.sources: New file. List of sources of mcs.exe.
18966 2004-05-24 Anders Carlsson <andersca@gnome.org>
18970 Use the invariant culture when doing String.Compare for CLS case
18973 2004-05-23 Martin Baulig <martin@ximian.com>
18975 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18976 don't have any dots. Fixes #52622, added cs0246-8.cs.
18978 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18980 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18982 * class.cs (MemberBase.Define): Reuse MemberType member for
18983 resolved type. Other methods can use it too.
18985 2004-05-23 Martin Baulig <martin@ximian.com>
18987 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18988 the variable also exists in the current block (otherwise, we need
18989 to report a CS0103). Fixes #58670.
18991 2004-05-23 Martin Baulig <martin@ximian.com>
18993 * flowanalysis.cs (Reachability.Reachable): Compute this
18994 on-the-fly rather than storing it as a field.
18996 2004-05-23 Martin Baulig <martin@ximian.com>
18998 * flowanalysis.cs (Reachability.And): Manually compute the
18999 resulting `barrier' from the reachability.
19001 2004-05-23 Marek Safar <marek.safar@seznam.cz>
19004 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
19005 instance of ObsoleteAttribute when symbol is obsolete.
19008 (IMethodData): Extended interface for ObsoleteAttribute support.
19010 2004-05-22 Marek Safar <marek.safar@seznam.cz>
19012 * attribute.cs: Fix bug #55970
19014 2004-05-22 Marek Safar <marek.safar@seznam.cz>
19018 (GetObsoleteAttribute): New method. Creates the instance of
19020 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
19021 ObsoleteAttribute when member is obsolete.
19022 (AttributeTester.Report_ObsoleteMessage): Common method for
19023 Obsolete error/warning reporting.
19026 (TypeContainer.base_classs_type): New member for storing parent type.
19029 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
19030 for this MemberCore.
19032 2004-05-21 Marek Safar <marek.safar@seznam.cz>
19034 * attribute.cs, const.cs: Fix bug #58590
19036 2004-05-21 Martin Baulig <martin@ximian.com>
19038 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
19039 out parameters if the end of the method is unreachable. Fixes
19042 2004-05-21 Marek Safar <marek.safar@seznam.cz>
19044 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
19045 Hari was right, why extra method.
19047 2004-05-21 Marek Safar <marek.safar@seznam.cz>
19049 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
19051 2004-05-20 Martin Baulig <martin@ximian.com>
19053 Merged this back from gmcs to keep the differences to a minumum.
19055 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
19056 instead of a Declspace.
19057 (Attribute.ResolveType): Likewise.
19058 (Attributes.Search): Likewise.
19059 (Attributes.Contains): Likewise.
19060 (Attributes.GetClsCompliantAttribute): Likewise.
19062 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
19064 (MethodData.ApplyAttributes): Take an EmitContext instead of a
19067 2004-05-19 Marek Safar <marek.safar@seznam.cz>
19069 Fix bug #58688 (MCS does not report error when the same attribute
19072 * attribute.cs (Attribute.Emit): Distinction between null and default.
19074 2004-05-19 Raja R Harinath <rharinath@novell.com>
19076 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
19077 of a top-level attribute without an attribute target.
19078 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
19080 (Attribute.Conditional_GetConditionName),
19081 (Attribute.Obsolete_GetObsoleteMessage): Update.
19082 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
19083 part of ScanForIndexerName.
19084 (Attribute.CanIgnoreInvalidAttribute): New function.
19085 (Attribute.ScanForIndexerName): Move to ...
19086 (Attributes.ScanForIndexerName): ... here.
19087 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
19088 (Attributes.Search): New internal variant that can choose not to
19089 complain if types aren't resolved. The original signature now
19091 (Attributes.GetClsCompliantAttribute): Use internal variant, with
19092 complaints suppressed.
19093 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
19094 only if it not useful.
19095 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
19096 top-level for attributes that are shared between the assembly
19097 and a top-level class.
19098 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
19099 * class.cs: Update to reflect changes.
19100 (DefineIndexers): Fuse loops.
19101 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
19102 a couple more variants of attribute names.
19104 2004-05-18 Marek Safar <marek.safar@seznam.cz>
19106 Fix bug #52585 (Implemented explicit attribute declaration)
19109 (Attributable.ValidAttributeTargets): New abstract method. It gets
19110 list of valid attribute targets for explicit target declaration.
19111 (Attribute.Target): It holds target itself.
19112 (AttributeSection): Removed.
19113 (Attribute.CheckTargets): New method. It checks whether attribute
19114 target is valid for the current element.
19117 (EventProperty): New class. For events that are declared like
19118 property (with add and remove accessors).
19119 (EventField): New class. For events that are declared like field.
19122 * cs-parser.jay: Implemented explicit attribute target declaration.
19124 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
19125 Override ValidAttributeTargets.
19128 (ReturnParameter): Class for applying custom attributes on
19130 (ParameterAtribute): New class. Class for applying custom
19131 attributes on the parameter type.
19133 2004-05-17 Miguel de Icaza <miguel@ximian.com>
19135 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
19138 (Method): Allow UNSAFE here.
19140 * modifiers.cs: Support unsafe reporting.
19142 2004-05-17 Marek Safar <marek.safar@seznam.cz>
19144 * decl.cs: Fix bug #58478.
19146 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19148 * statement.cs: When checking for unreachable code on an EmptyStatement,
19149 set the location. Fixes bug #58488.
19151 2004-05-13 Miguel de Icaza <miguel@ximian.com>
19153 * driver.cs: Add -pkg handling.
19155 From Gonzalo: UseShelLExecute=false
19157 2004-05-12 Marek Safar <marek.safar@seznam.cz>
19160 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
19162 (Attribute.IsClsCompliaceRequired): Moved to base for better
19164 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
19165 when attribute is AttributeUsageAttribute.
19166 (Attribute.GetValidTargets): Simplified.
19167 (Attribute.GetAttributeUsage): New method returns AttributeUsage
19168 attribute for this type.
19169 (Attribute.ApplyAttributes): Method renamed to Emit and make
19171 (GlobalAttributeSection): New class for special handling of global
19172 attributes (assembly, module).
19173 (AttributeSection.Emit): New method.
19175 * class.cs: Implemented Attributable abstract methods.
19176 (MethodCore.LabelParameters): Moved to Parameter class.
19177 (Accessor): Is back simple class.
19178 (PropertyMethod): Implemented Attributable abstract class.
19179 (DelegateMethod): Implemented Attributable abstract class.
19180 (Event): New constructor for disctintion between normal Event
19181 and Event with accessors.
19183 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
19185 * codegen.cs, const.cs, decl.cs, delegate.cs:
19186 (CommonAssemblyModulClass): Implemented Attributable abstract class
19189 * enum.cs: Implement IAttributeSupport interface.
19190 (EnumMember): New class for emum members. Implemented Attributable
19194 (ParameterBase): Is abstract.
19195 (ReturnParameter): New class for easier [return:] attribute handling.
19197 * typemanager.cs: Removed builder_to_attr.
19199 2004-05-11 Raja R Harinath <rharinath@novell.com>
19202 * attribute.cs (Attribute.GetPositionalValue): New function.
19203 * class.cs (TypeContainer.VerifyMembers): New function.
19204 (TypeContainer.Emit): Use it.
19205 (ClassOrStruct): New base class for Class and Struct.
19206 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
19207 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
19209 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
19210 then each non-static field should have a FieldOffset attribute.
19211 Otherwise, none of the fields should have a FieldOffset attribute.
19212 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
19213 and FieldOffset attributes.
19214 * typemanager.cs (TypeManager.struct_layout_attribute_type)
19215 (TypeManager.field_offset_attribute_type): New core types.
19216 (TypeManager.InitCoreTypes): Initialize them.
19218 2004-05-11 Michal Moskal <malekith@pld-linux.org>
19220 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
19221 Return correct type.
19224 2004-05-09 Miguel de Icaza <miguel@ximian.com>
19226 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
19227 be implicitly converted to ulong.
19229 * expression.cs: The logic for allowing operator &, | and ^ worked
19230 was wrong, it worked before because we did not report an error in
19231 an else branch. Fixes 57895.
19233 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
19234 allow volatile fields to be reference types.
19236 2004-05-07 Miguel de Icaza <miguel@ximian.com>
19238 * driver.cs: Add support for /debug-
19240 2004-05-07 Raja R Harinath <rharinath@novell.com>
19242 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
19243 Add a 'complain' parameter to silence errors.
19244 (Attribute.Resolve): Update to changes. Put in sanity check to catch
19245 silently overlooked type-resolutions.
19246 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
19247 to reflect changes.
19248 (Attributes.Search): New function.
19249 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
19250 (Attributes.GetAttributeFullName): Remove hack.
19251 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
19252 Update to reflect changes.
19253 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
19254 Use Attributes.Search instead of nested loops.
19256 2004-05-07 Marek Safar <marek.safar@seznam.cz>
19259 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
19260 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
19261 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
19263 * report.cs: (Report.Warning): Renamed to Warning_T because of
19264 parameter collision.
19266 2004-05-05 Raja R Harinath <rharinath@novell.com>
19268 * expression.cs (MemberAccess.ResolveMemberAccess):
19269 Exit with non-zero status after Report.Error.
19270 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
19272 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
19274 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19276 * support.cs: Don't hang when the file is empty.
19278 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19280 * support.cs: In SeekableStreamReader, compute the preamble size of the
19281 underlying stream. Position changes should take into account that initial
19284 2004-05-03 Todd Berman <tberman@sevenl.net>
19286 * driver.cs: remove unused GetSysVersion function.
19288 2004-05-03 Todd Berman <tberman@sevenl.net>
19290 * driver.cs: Remove the hack from saturday, as well as the hack
19291 from jackson (LoadAssemblyFromGac), also adds the CWD to the
19292 link_paths to get that bit proper.
19294 2004-05-01 Todd Berman <tberman@sevenl.net>
19296 * driver.cs: Try a LoadFrom before a Load, this checks the current
19297 path. This is currently a bug in mono that is be fixed, however, this
19298 provides a workaround for now. This will be removed when the bug
19301 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
19303 * CryptoConvert.cs: Updated to latest version. Fix issue with
19304 incomplete key pairs (#57941).
19306 2004-05-01 Todd Berman <tberman@sevenl.net>
19308 * driver.cs: Remove '.' from path_chars, now System.* loads properly
19311 2004-04-30 Jackson Harper <jackson@ximian.com>
19313 * codegen.cs: Open keys readonly.
19315 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19317 * typemanager.cs: don't report cyclic struct layout when a struct
19318 contains 2 or more fields of the same type. Failed for Pango.AttrShape
19319 which has 2 Pango.Rectangle fields.
19321 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
19323 * expression.cs: Handle IntPtr comparisons with IL code
19324 rather than a method call.
19326 2004-04-29 Martin Baulig <martin@ximian.com>
19328 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
19329 the list of PropertyInfo's in class hierarchy and find the
19330 accessor. Fixes #56013.
19332 2004-04-29 Martin Baulig <martin@ximian.com>
19334 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
19336 2004-04-29 Martin Baulig <martin@ximian.com>
19338 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19340 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
19342 2004-04-29 Martin Baulig <martin@ximian.com>
19344 * class.cs (ConstructorInitializer.Resolve): Check whether the
19345 parent .ctor is accessible. Fixes #52146.
19347 2004-04-29 Martin Baulig <martin@ximian.com>
19349 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19351 * statement.cs (Using.EmitLocalVariableDecls): Use
19352 TypeManager.idisposable_type, not typeof (IDisposable).
19353 (Foreach.EmitCollectionForeach): Added support for valuetypes.
19355 2004-04-29 Martin Baulig <martin@ximian.com>
19357 * class.cs (Event.Define): Don't emit the field and don't set
19358 RTSpecialName and SpecialName for events on interfaces. Fixes
19361 2004-04-29 Raja R Harinath <rharinath@novell.com>
19363 Refactor Attribute.ApplyAttributes.
19364 * attribute.cs (Attributable): New base class for objects that can
19365 have Attributes applied on them.
19366 (Attribute): Make AttributeUsage fields public.
19367 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19368 (Attribute.IsInternalCall): New property.
19369 (Attribute.UsageAttr): Convert to a public read-only property.
19370 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19371 (Attribute.ResolveType, Attribute.Resolve)
19372 (Attribute.ScanForIndexerName): Update to reflect changes.
19373 (Attribute.CheckAttributeTarget): Re-format.
19374 (Attribute.ApplyAttributes): Refactor, to various
19375 Attributable.ApplyAttributeBuilder methods.
19376 * decl.cs (MemberCore): Make Attributable.
19377 * class.cs (Accessor): Make Attributable.
19378 (MethodData.ApplyAttributes): Use proper attribute types, not
19380 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19381 (TypeContainer.ApplyAttributeBuilder)
19382 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19383 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19384 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19385 (Operator.ApplyAttributeBuilder): New factored-out methods.
19386 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19387 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19388 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19389 * parameter.cs (ParameterBase): New Attributable base class
19390 that can also represent Return types.
19391 (Parameter): Update to the changes.
19393 2004-04-29 Jackson Harper <jackson@ximian.com>
19395 * driver.cs: Prefer the corlib system version when looking for
19396 assemblies in the GAC. This is still a hack, but its a better hack
19399 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19401 * decl.cs, enum.cs: Improved error 3005 reporting.
19403 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19404 (related_symbols): New private member for list of symbols
19405 related to reported error/warning.
19407 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19409 2004-04-29 Martin Baulig <martin@ximian.com>
19411 * ecore.cs (Expression.Constantify): If we're an enum and
19412 TypeManager.TypeToCoreType() doesn't give us another type, use
19413 t.UnderlyingSystemType. Fixes #56178.
19415 2004-04-29 Martin Baulig <martin@ximian.com>
19417 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19418 interfaces and for each interface, only add members directly
19419 declared in that interface. Fixes #53255.
19421 2004-04-28 Martin Baulig <martin@ximian.com>
19423 * expression.cs (ConditionalLogicalOperator): Use a temporary
19424 variable for `left' to avoid that we evaluate it more than once;
19427 2004-04-28 Martin Baulig <martin@ximian.com>
19429 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19432 2004-04-28 Martin Baulig <martin@ximian.com>
19434 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19437 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19438 whether the type is not void (CS1547).
19440 2004-04-28 Martin Baulig <martin@ximian.com>
19442 * expression.cs (Unary.DoResolveLValue): Override this and report
19443 CS0131 for anything but Operator.Indirection.
19445 2004-04-28 Martin Baulig <martin@ximian.com>
19447 Committing a patch from Ben Maurer; see bug #50820.
19449 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19452 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19455 2004-04-28 Martin Baulig <martin@ximian.com>
19457 Committing a patch from Ben Maurer; see bug #50820.
19459 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19462 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19465 2004-04-28 Martin Baulig <martin@ximian.com>
19467 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19468 (Block.AddLabel): Call DoLookupLabel() to only search in the
19471 2004-04-28 Martin Baulig <martin@ximian.com>
19473 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19474 comparing StringConstants and NullLiterals in Equality and Inequality.
19476 2004-04-28 Jackson Harper <jackson@ximian.com>
19478 * driver.cs: Attempt to load referenced assemblies from the
19479 GAC. This is the quick and dirty version of this method that
19480 doesnt take into account versions and just takes the first
19481 canidate found. Will be good enough for now as we will not have more
19482 then one version installed into the GAC until I update this method.
19484 2004-04-28 Martin Baulig <martin@ximian.com>
19486 * typemanager.cs (TypeManager.CheckStructCycles): New public
19487 static method to check for cycles in the struct layout.
19489 * rootcontext.cs (RootContext.PopulateTypes): Call
19490 TypeManager.CheckStructCycles() for each TypeContainer.
19491 [Note: We only need to visit each type once.]
19493 2004-04-28 Martin Baulig <martin@ximian.com>
19495 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19497 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19498 success and added `out object value'. Use a `bool resolved' field
19499 to check whether we've already been called rather than
19500 `ConstantValue != null' since this breaks for NullLiterals.
19502 2004-04-28 Raja R Harinath <rharinath@novell.com>
19504 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19505 setting of this flag, since the 'set' method may be non-public.
19507 2004-04-28 Raja R Harinath <rharinath@novell.com>
19509 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19510 check on current_vector.Block.
19512 2004-04-27 Martin Baulig <martin@ximian.com>
19514 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19515 a field initializer. Fixes #56459.
19517 2004-04-27 Martin Baulig <martin@ximian.com>
19519 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19520 we're not attempting to use an indexer. Fixes #52154.
19522 2004-04-27 Martin Baulig <martin@ximian.com>
19524 * statement.cs (Return): Don't create a return label if we don't
19525 need it; reverts my change from January 20th. Thanks to Ben
19528 2004-04-27 Martin Baulig <martin@ximian.com>
19530 According to the spec, `goto' can only leave a nested scope, but
19533 * statement.cs (Block.LookupLabel): Only lookup in the current
19534 block, don't recurse into parent or child blocks.
19535 (Block.AddLabel): Check in parent and child blocks, report
19536 CS0140/CS0158 if we find a duplicate.
19537 (Block): Removed this indexer for label lookups.
19538 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19539 this already does the error reporting for us.
19542 (FlowBranching.UsageVector.Block): New public variable; may be null.
19543 (FlowBranching.CreateSibling): Added `Block' argument.
19544 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19545 label for the target of a `goto' and check whether we're not
19546 leaving a `finally'.
19548 2004-04-27 Martin Baulig <martin@ximian.com>
19550 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19551 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19554 2004-04-27 Martin Baulig <martin@ximian.com>
19556 * statement.cs (Block.AddLabel): Also check for implicit blocks
19557 and added a CS0158 check.
19559 2004-04-27 Martin Baulig <martin@ximian.com>
19561 * flowanalysis.cs (FlowBranchingLoop): New class.
19562 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19563 UsageVector's instead of an ArrayList.
19564 (FlowBranching.Label): Likewise.
19565 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19566 (FlowBranching.AddBreakVector): New method.
19568 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19570 * attribute.cs: Small regression fix: only convert the type if we
19571 the type is different, fixes System.Drawing build.
19573 2004-04-27 Martin Baulig <martin@ximian.com>
19575 * attribute.cs (Attribute.Resolve): If we have a constant value
19576 for a named field or property, implicity convert it to the correct
19579 2004-04-27 Raja R Harinath <rharinath@novell.com>
19581 * statement.cs (Block.Block): Implicit blocks share
19582 'child_variable_names' fields with parent blocks.
19583 (Block.AddChildVariableNames): Remove.
19584 (Block.AddVariable): Mark variable as "used by a child block" in
19585 every surrounding block.
19586 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19587 been used in a child block, complain about violation of "Invariant
19588 meaning in blocks" rule.
19589 * cs-parser.jay (declare_local_variables): Don't use
19590 AddChildVariableNames.
19591 (foreach_statement): Don't create an implicit block: 'foreach'
19592 introduces a scope.
19594 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19596 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19597 converting from 0L to ulong. Fixes 57522.
19599 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19601 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19602 derived class hides via 'new' keyword field from base class (test-242.cs).
19603 TODO: Handle this in the more general way.
19605 * class.cs (CheckBase): Ditto.
19607 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19609 * decl.cs (caching_flags): New member for storing cached values
19611 (MemberCore.Flags): New enum where bit flags for caching_flags
19613 (MemberCore.cls_compliance): Moved to caching_flags.
19614 (DeclSpace.Created): Moved to caching_flags.
19616 * class.cs: Use caching_flags instead of DeclSpace.Created
19618 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19620 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19621 if we are only a derived class, not a nested class.
19623 * typemanager.cs: Same as above, but do this at the MemberLookup
19624 level (used by field and methods, properties are handled in
19625 PropertyExpr). Allow for the qualified access if we are a nested
19628 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19630 * class.cs: Refactoring.
19631 (IMethodData): New inteface; Holds links to parent members
19632 to avoid member duplication (reduced memory allocation).
19633 (Method): Implemented IMethodData interface.
19634 (PropertyBase): New inner classes for get/set methods.
19635 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19636 (Event): New inner classes for add/remove methods.
19637 (Event.DelegateMethod): Implemented IMethodData interface.
19639 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19640 EmitContext (related to class.cs refactoring).
19642 2004-04-21 Raja R Harinath <rharinath@novell.com>
19644 * delegate.cs (Delegate.VerifyApplicability): If the number of
19645 arguments are the same as the number of parameters, first try to
19646 verify applicability ignoring any 'params' modifier on the last
19650 2004-04-16 Raja R Harinath <rharinath@novell.com>
19652 * class.cs (TypeContainer.AddIndexer): Use
19653 'ExplicitInterfaceName' to determine if interface name was
19654 explicitly specified. 'InterfaceType' is not initialized at this time.
19655 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19656 Indexers array is already in the required order. Initialize
19657 'IndexerName' only if there are normal indexers.
19658 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19659 (TypeContainer.Emit): Emit DefaultMember attribute only if
19660 IndexerName is initialized.
19663 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19665 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19668 2004-04-15 Raja R Harinath <rharinath@novell.com>
19670 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19674 * attribute.cs (Attribute.Resolve): Check for duplicate named
19678 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19680 * iterators.cs (MarkYield): track whether we are in an exception,
19681 and generate code accordingly. Use a temporary value to store the
19682 result for our state.
19684 I had ignored a bit the interaction of try/catch with iterators
19685 since their behavior was not entirely obvious, but now it is
19686 possible to verify that our behavior is the same as MS .NET 2.0
19690 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19692 * iterators.cs: Avoid creating temporaries if there is no work to
19695 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19696 Enumerations, use TypeManager.EnumToUnderlying and call
19699 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19702 (This.Emit): Use EmitContext.EmitThis to emit our
19705 (This.EmitAssign): Ditto.
19707 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19708 codepaths, we will move all the functionality into
19711 (FieldExpr.EmitAssign): Ditto.
19713 This fixes several hidden bugs that I uncovered while doing a code
19714 review of this today.
19716 * codegen.cs (EmitThis): reworked so the semantics are more clear
19717 and also support value types "this" instances.
19719 * iterators.cs: Changed so that for iterators in value types, we
19720 do not pass the value type as a parameter.
19722 Initialization of the enumerator helpers is now done in the caller
19723 instead of passing the parameters to the constructors and having
19724 the constructor set the fields.
19726 The fields have now `assembly' visibility instead of private.
19728 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19730 * expression.cs (Argument.Resolve): Check if fields passed as ref
19731 or out are contained in a MarshalByRefObject.
19733 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19734 another compiler type.
19736 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19738 * class.cs (Indexer.Define): use the new name checking method.
19739 Also, return false on an error.
19740 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19741 (is_identifier_[start/part]_character): make static.
19743 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19745 * expression.cs (Binary.ResolveOperator): Do no append strings
19746 twice: since we can be invoked more than once (array evaluation)
19747 on the same concatenation, take care of this here. Based on a fix
19748 from Ben (bug #56454)
19750 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19752 * codegen.cs: Fix another case where CS1548 must be reported (when
19753 delay-sign isn't specified and no private is available #56564). Fix
19754 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19755 error when MCS is used on the MS runtime and we need to delay-sign
19756 (which seems unsupported by AssemblyBuilder - see #56621).
19758 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19760 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19761 (TypeManager.ComputeNamespaces): Faster implementation for
19764 * compiler.csproj: Updated AssemblyName to mcs.
19766 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19768 * rootcontext.cs: Add new types to the boot resolution.
19770 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19771 MulticastDelegate is not allowed.
19773 * typemanager.cs: Add new types to lookup: System.TypedReference
19776 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19777 check for TypedReference or ArgIterator, they are not allowed.
19779 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19780 makes us properly catch 1510 in some conditions (see bug 56016 for
19783 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19785 * CryptoConvert.cs: update from corlib version
19788 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19790 * class.cs (Indexer.Define): Check indexername declaration
19792 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19794 * attribute.cs (IsClsCompliant): Fixed problem with handling
19795 all three states (compliant, not-compliant, undetected).
19797 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19799 * attribute.cs (Attribute): Location is now public.
19800 (Resolve): Store resolved arguments (pos_values) in attribute class.
19801 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19802 (GetClsCompliantAttributeValue): New method that gets
19803 CLSCompliantAttribute value.
19804 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19805 if exists else null.
19806 (AttributeTester): New class for CLS-Compliant verification routines.
19808 * class.cs (Emit): Add CLS-Compliant verification.
19809 (Method.GetSignatureForError): Implemented.
19810 (Constructor.GetSignatureForError): Implemented
19811 (Constructor.HasCompliantArgs): Returns if constructor has
19812 CLS-Compliant arguments.
19813 (Constructor.Emit): Override.
19814 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19815 is needed to test only parameters.
19816 (FieldBase.GetSignatureForError): Implemented.
19817 (TypeContainer): New member for storing base interfaces.
19818 (TypeContainer.FindMembers): Search in base interfaces too.
19820 * codegen.cs (GetClsComplianceAttribute): New method that gets
19821 assembly or module CLSCompliantAttribute value.
19822 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19824 (ModuleClass.Emit): Add error 3012 test.
19826 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19828 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19829 state for all decl types.
19830 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19831 if CLS-Compliant tests are required.
19832 (IsClsCompliaceRequired): New method. Analyze whether code
19833 must be CLS-Compliant.
19834 (IsExposedFromAssembly): New method. Returns true when MemberCore
19835 is exposed from assembly.
19836 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19837 value or gets cached value.
19838 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19839 is explicitly marked with CLSCompliantAttribute.
19840 (IsIdentifierClsCompliant): New abstract method. This method is
19841 used to testing error 3005.
19842 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19843 for identifier and parameters CLS-Compliant testing.
19844 (VerifyClsCompliance): New method. The main virtual method for
19845 CLS-Compliant verifications.
19846 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19847 null. I don't know why is null (too many public members !).
19848 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19849 and get value of first CLSCompliantAttribute that found.
19851 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19852 (VerifyClsCompliance): Override and add extra tests.
19854 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19855 clscheck- disable CLS-Compliant verification event if assembly is has
19856 CLSCompliantAttribute(true).
19858 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19859 ApllyAttribute is now called in emit section as in the other cases.
19860 Possible future Emit integration.
19861 (IsIdentifierClsCompliant): New override.
19862 (VerifyClsCompliance): New override.
19863 (GetEnumeratorName): Returns full enum name.
19865 * parameter.cs (GetSignatureForError): Implemented.
19867 * report.cs (WarningData): New struct for Warning message information.
19868 (LocationOfPreviousError): New method.
19869 (Warning): New method. Reports warning based on the warning table.
19870 (Error_T): New method. Reports error based on the error table.
19872 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19873 verifications are done here.
19875 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19877 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19878 CLSCompliantAttribute.
19879 (all_imported_types): New member holds all imported types from other
19881 (LoadAllImportedTypes): New method fills static table with exported types
19882 from all referenced assemblies.
19883 (Modules): New property returns all assembly modules.
19885 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19887 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19888 throwing a parser error.
19890 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19891 which removes the hardcoded get_/set_ prefixes for properties, as
19892 IL allows for the properties to be named something else.
19896 * expression.cs: Do not override operand before we know if it is
19897 non-null. Fix 56207
19899 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19901 * typemanager.cs: support for pinned variables.
19903 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19905 * decl.cs, typemanager.cs: Avoid using an arraylist
19906 as a buffer if there is only one result set.
19908 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19910 * expression.cs: Make sure you cant call a static method
19911 with an instance expression, bug #56174.
19913 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19915 * class.cs (IsDuplicateImplementation): Improve error reporting to
19916 flag 663 (method only differs in parameter modifier).
19918 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19919 in preprocessor directives.
19921 * location.cs (LookupFile): Allow for the empty path.
19923 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19924 better approach for some of that patch, but its failing with the
19925 CharSet enumeration. For now try/catch will do.
19927 * typemanager.cs: Do not crash if a struct does not have fields.
19930 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19932 * expression.cs: cs0213, cant fix a fixed expression.
19935 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19937 * cs-parser.jay: detect invalid embeded statements gracefully.
19940 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19942 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19945 the invocation type may not be a subclass of the tye of the item/
19946 The type of the item must be a subclass of the invocation item.
19951 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19953 * attribute.cs: Added methods to get a string and a bool from an
19954 attribute. Required to information from AssemblyKeyFileAttribute,
19955 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19956 * codegen.cs: Modified AssemblyName creation to include support for
19957 strongnames. Catch additional exceptions to report them as CS1548.
19958 * compiler.csproj: Updated include CryptoConvert.cs.
19959 * compiler.csproj.user: Removed file - user specific configuration.
19960 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19961 Mono.Security assembly. The original class is maintained and tested in
19962 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19963 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19964 like CSC 8.0 (C# v2) supports.
19965 * Makefile: Added CryptoConvert.cs to mcs sources.
19966 * rootcontext.cs: Added new options for strongnames.
19968 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19970 * driver.cs: For --expect-error, report error code `2'
19971 if the program compiled with no errors, error code `1' if
19972 it compiled with an error other than the one expected.
19974 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19976 * compiler.csproj: Updated for Visual Studio .NET 2003.
19977 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19978 * compiler.sln: Updated for Visual Studio .NET 2003.
19980 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19982 * expression.cs: Fix bug #47234. We basically need to apply the
19983 rule that we prefer the conversion of null to a reference type
19984 when faced with a conversion to 'object' (csc behaviour).
19986 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19988 * statement.cs: Shorter form for foreach, eliminates
19989 a local variable. r=Martin.
19991 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19993 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19994 checks if we can use brtrue/brfalse to test for 0.
19995 * expression.cs: use the above in the test for using brtrue/brfalse.
19996 cleanup code a bit.
19998 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
20000 * expression.cs: Rewrite string concat stuff. Benefits:
20002 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
20003 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
20004 rather than a concat chain.
20006 * typemanager.cs: Add lookups for more concat overloads.
20008 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
20010 * expression.cs: Emit shorter il code for array init.
20027 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
20029 * statement.cs: Before, two switch blocks would be merged if the
20030 total size of the blocks (end_item - begin_item + 1) was less than
20031 two times the combined sizes of the blocks.
20033 Now, it will only merge if after the merge at least half of the
20038 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
20040 * class.cs : csc build fix for GetMethods(). See bug #52503.
20042 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
20044 * expression.cs: Make sure fp comparisons work with NaN.
20045 This fixes bug #54303. Mig approved this patch a long
20046 time ago, but we were not able to test b/c the runtime
20049 2004-03-19 Miguel de Icaza <miguel@ximian.com>
20051 * ecore.cs (TypExpr.GetHashCode): implement this overload.
20053 2004-03-19 Martin Baulig <martin@ximian.com>
20055 * class.cs (MemberCore.IsDuplicateImplementation): Report the
20056 error here and not in our caller.
20058 2004-03-19 Martin Baulig <martin@ximian.com>
20060 * interface.cs: Completely killed this file.
20061 (Interface): We're now a TypeContainer and live in class.cs.
20063 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
20064 argument; we're now also called for interfaces.
20065 (TypeContainer.DefineMembers): Allow this method being called
20067 (TypeContainer.GetMethods): New public method; formerly known as
20068 Interface.GetMethod(). This is used by PendingImplementation.
20069 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
20070 it's now private and non-static.
20071 (Interface): Moved this here; it's now implemented similar to
20073 (Method, Property, Event, Indexer): Added `bool is_interface'
20074 argument to their .ctor's.
20075 (MemberBase.IsInterface): New public field.
20077 * cs-parser.jay: Create normal Method, Property, Event, Indexer
20078 instances instead of InterfaceMethod, InterfaceProperty, etc.
20079 (opt_interface_base): Removed; we now use `opt_class_base' instead.
20080 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
20082 2004-03-19 Martin Baulig <martin@ximian.com>
20084 * class.cs (MethodCore.IsDuplicateImplementation): New private
20085 method which does the CS0111 checking.
20086 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
20087 Use IsDuplicateImplementation().
20089 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
20091 * decl.cs (FindMemberToOverride): New method to find the correct
20092 method or property to override in the base class.
20094 - Make Method/Property use the above method to find the
20095 version in the base class.
20096 - Remove the InheritableMemberSignatureCompare as it is now
20099 This patch makes large code bases much faster to compile, as it is
20100 O(n) rather than O(n^2) to do this validation.
20102 Also, it fixes bug 52458 which is that nested classes are not
20103 taken into account when finding the base class member.
20105 Reviewed/Approved by Martin.
20107 2004-03-17 Marek Safar <marek.safar@seznam.cz>
20109 * interface.cs: In all interface classes removed redundant
20110 member initialization.
20112 2004-03-16 Martin Baulig <martin@ximian.com>
20114 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
20116 2004-03-15 Miguel de Icaza <miguel@ximian.com>
20118 * decl.cs (DefineTypeAndParents): New helper method to define a
20119 type's containers before the type itself is defined; This is a
20120 bug exposed by the recent changes to Windows.Forms when an
20121 implemented interface was defined inside a class that had not been
20124 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
20126 (Check): Loop correctly to report errors modifiers
20127 (UNSAFE was not in the loop, since it was the same as TOP).
20129 * interface.cs: Every interface member now takes a ModFlags,
20130 instead of a "is_new" bool, which we set on the base MemberCore.
20132 Every place where we called "UnsafeOk" in the interface, now we
20133 call the proper member (InterfaceMethod.UnsafeOK) instead to get
20134 the unsafe settings from the member declaration instead of the
20135 container interface.
20137 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
20139 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
20140 `set_indexer_name' to the pending bits (one per type).
20142 We fixed a bug today that was picking the wrong method to
20143 override, since for properties the existing InterfaceMethod code
20144 basically ignored the method name. Now we make sure that the
20145 method name is one of the valid indexer names.
20147 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
20149 * support.cs (SeekableStreamReader): Keep track of stream byte
20150 positions and don't mix them with character offsets to the buffer.
20152 Patch from Gustavo Giráldez
20154 2004-03-15 Marek Safar <marek.safar@seznam.cz>
20156 * interface.cs (InterfaceSetGetBase): Removed double member
20157 initialization, base class does it as well.
20159 2004-03-13 Martin Baulig <martin@ximian.com>
20161 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
20162 when compiling corlib.
20164 2004-03-13 Miguel de Icaza <miguel@ximian.com>
20166 * convert.cs (ExplicitConversion): We were reporting an error on
20167 certain conversions (object_type source to a value type, when the
20168 expression was `null') before we had a chance to pass it through
20169 the user defined conversions.
20171 * driver.cs: Replace / and \ in resource specifications to dots.
20174 * class.cs: Add check for duplicate operators. Fixes 52477
20176 2004-03-11 Miguel de Icaza <miguel@ximian.com>
20178 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
20179 that are in the middle of the statements, not only at the end.
20182 * class.cs (TypeContainer.AddField): No longer set the
20183 `HaveStaticConstructor' flag, now we call it
20184 `UserDefineStaticConstructor' to diferentiate the slightly
20185 semantic difference.
20187 The situation is that we were not adding BeforeFieldInit (from
20188 Modifiers.TypeAttr) to classes that could have it.
20189 BeforeFieldInit should be set to classes that have no static
20194 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
20196 And most importantly Zoltan's comment:
20198 http://bugzilla.ximian.com/show_bug.cgi?id=44229
20200 "I think beforefieldinit means 'it's ok to initialize the type sometime
20201 before its static fields are used', i.e. initialization does not need
20202 to be triggered by the first access to the type. Setting this flag
20203 helps the JIT to compile better code, since it can run the static
20204 constructor at JIT time, and does not need to generate code to call it
20205 (possibly lots of times) at runtime. Unfortunately, mcs does not set
20206 this flag for lots of classes like String.
20208 csc sets this flag if the type does not have an explicit static
20209 constructor. The reasoning seems to be that if there are only static
20210 initalizers for a type, and no static constructor, then the programmer
20211 does not care when this initialization happens, so beforefieldinit
20214 This bug prevents the AOT compiler from being usable, since it
20215 generates so many calls to mono_runtime_class_init that the AOT code
20216 is much slower than the JITted code. The JITted code is faster,
20217 because it does not generate these calls if the vtable is type is
20218 already initialized, which is true in the majority of cases. But the
20219 AOT compiler can't do this."
20221 2004-03-10 Miguel de Icaza <miguel@ximian.com>
20223 * class.cs (MethodData.Emit): Refactor the code so symbolic
20224 information is generated for destructors; For some reasons we
20225 were taking a code path that did not generate symbolic information
20228 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
20230 * class.cs: Create a Constructor.CheckBase method that
20231 takes care of all validation type code. The method
20232 contains some code that was moved from Define.
20234 It also includes new code that checks for duplicate ctors.
20235 This fixes bug #55148.
20237 2004-03-09 Joshua Tauberer <tauberer@for.net>
20239 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
20240 a { ... }-style array creation invokes EmitStaticInitializers
20241 which is not good for reference-type arrays. String, decimal
20242 and now null constants (NullCast) are not counted toward
20243 static initializers.
20245 2004-03-05 Martin Baulig <martin@ximian.com>
20247 * location.cs (SourceFile.HasLineDirective): New public field;
20248 specifies whether the file contains or is referenced by a "#line"
20250 (Location.DefineSymbolDocuments): Ignore source files which
20251 either contain or are referenced by a "#line" directive.
20253 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
20255 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
20256 direct access to our parent, so check the method inline there.
20258 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
20260 * expression.cs (Invocation.EmitCall): Miguel's last commit
20261 caused a regression. If you had:
20266 In Foo the implict this would be null.
20268 2004-02-27 Miguel de Icaza <miguel@ximian.com>
20270 * expression.cs (Invocation.EmitCall): If the method is not
20271 virtual, do not emit a CallVirt to it, use Call.
20273 * typemanager.cs (GetFullNameSignature): Improve the method to
20274 cope with ".ctor" and replace it with the type name.
20276 * class.cs (ConstructorInitializer.Resolve): Now the method takes
20277 as an argument the ConstructorBuilder where it is being defined,
20278 to catch the recursive constructor invocations.
20280 2004-02-26 Miguel de Icaza <miguel@ximian.com>
20282 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
20283 routines to check if a type is an enumerable/enumerator allow
20284 classes that implement the IEnumerable or IEnumerator interfaces.
20286 * class.cs (Property, Operator): Implement IIteratorContainer, and
20287 implement SetYields.
20289 (Property.Define): Do the block swapping for get_methods in the
20290 context of iterators. We need to check if Properties also
20291 include indexers or not.
20293 (Operator): Assign the Block before invoking the
20294 OperatorMethod.Define, so we can trigger the Iterator code
20297 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
20298 Property and Operator classes are not created when we parse the
20299 declarator but until we have the block completed, so we use a
20300 singleton SimpleIteratorContainer.Simple to flag whether the
20301 SetYields has been invoked.
20303 We propagate this setting then to the Property or the Operator to
20304 allow the `yield' to function.
20306 2004-02-25 Marek Safar <marek.safar@seznam.cz>
20308 * codegen.cs: Implemented attribute support for modules.
20309 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
20310 Assembly/Module functionality.
20312 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
20313 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
20314 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
20316 2004-02-16 Marek Safar <marek.safar@seznam.cz>
20318 * interface.cs (FindMembers): The operation is performed on all base
20319 interfaces and not only on the first. It is required for future CLS Compliance patch.
20321 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
20323 * statement.cs, codegen.cs:
20324 This patch deals with patterns such as:
20326 public class List : IEnumerable {
20328 public MyEnumerator GetEnumerator () {
20329 return new MyEnumerator(this);
20332 IEnumerator IEnumerable.GetEnumerator () {
20336 public struct MyEnumerator : IEnumerator {
20341 Before, there were a few things we did wrong:
20342 1) we would emit callvirt on a struct, which is illegal
20343 2) we emited ldarg when we needed to emit ldarga
20344 3) we would mistakenly call the interface methods on an enumerator
20345 type that derived from IEnumerator and was in another assembly. For example:
20347 public class MyEnumerator : IEnumerator
20349 Would have the interface methods called, even if there were public impls of the
20350 method. In a struct, this lead to invalid IL code.
20352 2004-02-11 Marek Safar <marek.safar@seznam.cz>
20354 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
20357 * delegate.cs (Define): Fixed crash when delegate type is undefined.
20359 2004-02-11 Miguel de Icaza <miguel@ximian.com>
20361 * cs-parser.jay: Fix small regression: we were not testing V2
20362 compiler features correctly.
20364 * interface.cs: If the emit context is null, then create one
20366 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20368 * decl.cs (GetSignatureForError): New virtual method to get full name
20369 for error messages.
20371 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20372 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20374 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20375 Duplicated members and code in these classes has been removed.
20376 Better encapsulation in these classes.
20378 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20380 * assign.cs (Assign.DoResolve): When dealing with compound
20381 assignments, there is a new rule in ECMA C# 2.4 (might have been
20382 there before, but it is documented here) that states that in:
20386 If b is of type int, and the `op' is a shift-operator, then the
20387 above is evaluated as:
20391 * expression.cs (Binary.ResolveOperator): Instead of testing for
20392 int/uint/long/ulong, try to implicitly convert to any of those
20393 types and use that in pointer arithmetic.
20395 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20396 method to print information for from the type, not from the
20397 null-method we were given.
20399 2004-02-01 Duncan Mak <duncan@ximian.com>
20401 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20402 parsing for cmd, fixes bug #53694.
20404 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20406 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20407 in the member name duplication tests. Property and operator name duplication
20408 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20410 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20412 * interface.cs (PopulateMethod): Fixed crash when interface method
20413 returns not existing type (error test cs0246-3.cs).
20415 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20417 * cs-parser.jay (interface_accessors): Re-write actions to also
20418 store attributes attached to get and set methods. Fix spelling
20421 (inteface_property_declaration): Modify accordingly.
20423 (InterfaceAccessorInfo): New helper class to store information to pass
20424 around between rules that use interface_accessors.
20426 * interface.cs (Emit): Apply attributes on the get and set
20427 accessors of properties and indexers too.
20429 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20430 right MethodBuilder when applying attributes to the get and set accessors.
20432 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20434 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20436 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20438 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20440 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20442 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20443 changes that treat `yield' specially when present before `break'
20444 or `return' tokens.
20446 * cs-tokenizer.cs: yield is no longer a keyword.
20448 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20450 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20451 setting for default constructors.
20452 For default constructors are almost every time set wrong Modifier. The
20453 generated IL code has been alright. But inside mcs this values was
20454 wrong and this was reason why several of my CLS Compliance tests
20457 2004-01-22 Martin Baulig <martin@ximian.com>
20459 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20460 not a QualifiedIdentifier. This is what `type_name_expression'
20461 was previously doing.
20462 (type_name_expression): Removed; the code is now in
20463 `namespace_or_type_name'.
20464 (qualified_identifier): Removed, use `namespace_or_type_name'
20466 (QualifiedIdentifier): Removed this class.
20468 2004-01-22 Martin Baulig <martin@ximian.com>
20470 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20471 not a string as alias name.
20473 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20475 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20476 #52730 bug, and instead compute correctly the need to use a
20477 temporary variable when requesting an address based on the
20478 static/instace modified of the field and the constructor.
20480 2004-01-21 Martin Baulig <martin@ximian.com>
20482 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20483 class and namespace before looking up aliases. Fixes #52517.
20485 2004-01-21 Martin Baulig <martin@ximian.com>
20487 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20488 assinged in a 'try'; fixes exception4.cs.
20490 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20491 * class.cs : Implemented parameter-less constructor for TypeContainer
20493 * decl.cs: Attributes are now stored here. New property OptAttributes
20495 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20497 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20499 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20501 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20502 (CSharpSignature): New method for indexer and property signature.
20504 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20506 * pending.cs (IsVirtualFilter): Faster implementation.
20508 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20510 * typemanager.cs: Avoid inclusion of same assembly more than once.
20512 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20514 * cs-parser.jay: Fixed problem where the last assembly attribute
20515 has been applied also to following declaration (class, struct, etc.)
20517 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20519 * class.cs: Added error CS0538, CS0539 reporting.
20520 Fixed crash on Microsoft runtime when field type is void.
20522 * cs-parser.jay: Added error CS0537 reporting.
20524 * pending.cs: Added error CS0535 reporting.
20525 Improved error report for errors CS0536, CS0534.
20527 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20529 Merge a few bits from the Anonymous Method MCS tree.
20531 * statement.cs (ToplevelBlock): New class for toplevel methods,
20532 will hold anonymous methods, lifted variables.
20534 * cs-parser.jay: Create toplevel blocks for delegates and for
20535 regular blocks of code.
20537 2004-01-20 Martin Baulig <martin@ximian.com>
20539 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20540 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20541 and `NeedExplicitReturn'; added `IsLastStatement'.
20542 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20543 have a `ReturnLabel' or we're not unreachable.
20545 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20546 child's reachability; don't just override ours with it. Fixes
20547 #58058 (lluis's example).
20548 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20549 InFinally(), InLoop(), InSwitch() and
20550 BreakCrossesTryCatchBoundary() methods.
20552 * statement.cs (Return): Do all error checking in Resolve().
20553 Unless we are the last statement in a top-level block, always
20554 create a return label and jump to it.
20555 (Break, Continue): Do all error checking in Resolve(); also make
20556 sure we aren't leaving a `finally'.
20557 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20558 statement in a top-level block.
20559 (Block.Flags): Added `IsDestructor'.
20560 (Block.IsDestructor): New public property.
20562 2004-01-20 Martin Baulig <martin@ximian.com>
20564 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20566 2004-01-20 Martin Baulig <martin@ximian.com>
20568 * statement.cs (Statement.ResolveUnreachable): New public method.
20569 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20570 (Block.Resolve): Resolve unreachable statements.
20572 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20574 * expression.cs: We need to fix the case where we do
20575 not have a temp variable here.
20577 * assign.cs: Only expression compound assignments need
20578 temporary variables.
20580 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20582 * flowanalysis.cs: Reduce memory allocation in a few ways:
20583 - A block with no variables should not allocate a bit
20585 - A method with no out parameters does not need any tracking
20586 for assignment of the parameters, so we need not allocate
20589 public readonly Type[] VariableTypes;
20590 public readonly string[] VariableNames;
20591 Are redundant. The data is already stored in the variable
20592 map, so we need not allocate another array for it.
20593 - We need to add alot of checks for if (params | locals) == null
20594 due to the first two changes.
20596 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20598 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20599 implement IMemoryLocation, we store a copy on a local variable and
20600 take the address of it. Patch from Benjamin Jemlich
20602 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20603 to use a special "type_name_expression" rule which reduces the
20604 number of "QualifiedIdentifier" classes created, and instead
20605 directly creates MemberAccess expressions.
20607 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20609 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20610 that fixes #52853. Null literal assignment to ValueType
20612 * class.cs (MethodData.Emit): Instead of checking the name of the
20613 method to determine if its a destructor, create a new derived
20614 class from Method called Destructor, and test for that.
20616 * cs-parser.jay: Create a Destructor object instead of a Method.
20618 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20622 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20624 * expression.cs (Binary.ResolveOperator): Perform an implicit
20625 conversion from MethodGroups to their delegate types on the
20626 Addition operation.
20628 * delegate.cs: Introduce a new class DelegateCreation that is the
20629 base class for `NewDelegate' and `ImplicitDelegateCreation',
20630 factor some code in here.
20632 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20633 conversion from MethodGroups to compatible delegate types.
20635 * ecore.cs (Expression.Resolve): Do not flag error 654
20636 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20637 we allow conversions from MethodGroups to delegate types now.
20639 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20640 assignments in v2 either.
20642 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20644 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20645 static read-only fields in ctors.
20647 Applied patch from Benjamin Jemlich
20649 * expression.cs (UnaryMutator): Avoid leaking local variables.
20651 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20653 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20654 here to return true, as they can be used like this:
20656 (XXX) int.MEMBER ()
20658 Fixed 49836 and all the other dups
20660 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20662 * driver.cs: Implement /win32res and /win32icon.
20664 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20666 * cs-parser.jay: Add a rule to improve error handling for the
20667 common mistake of placing modifiers after the type.
20669 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20671 * cs-parser.jay (interface_event_declaration): Catch
20672 initialization of events on interfaces, and report cs0068
20674 * cs-parser.jay (interface_event_declaration): Catch
20675 initialization of events.
20677 * ecore.cs: Better report missing constructors.
20679 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20680 the error reporting done in the wrong place. Fix.
20682 * expression.cs (Binary.ResolveOperator): Catch the
20683 operator + (E x, E y) error earlier, and later allow for implicit
20684 conversions in operator +/- (E e, U x) from U to the underlying
20687 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20688 52596, if the container class is abstract, the default constructor
20689 is protected otherwise its public (before, we were always public).
20691 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20694 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20695 Jemlich that fixes bug #52597, MCS was generating invalid code for
20696 idisposable structs. Thanks to Ben for following up with this
20699 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20701 * driver.cs: Allow assemblies without code to be generated, fixes
20704 2004-01-07 Nick Drochak <ndrochak@gol.com>
20706 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20708 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20710 * cs-parser.jay: Add rules to improve error reporting if fields or
20711 methods are declared at the namespace level (error 116)
20713 * Add rules to catch event add/remove
20715 2004-01-04 David Sheldon <dave-mono@earth.li>
20717 * expression.cs: Added matching ")" to error message for
20720 2004-01-03 Todd Berman <tberman@gentoo.org>
20722 * ecore.cs, attribute.cs:
20723 Applying fix from #52429.
20725 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20727 * ecore.cs, expression.cs, statement.cs:
20728 Total rewrite of how we handle branching. We
20729 now handle complex boolean expressions with fewer
20730 jumps. As well if (x == 0) no longer emits a ceq.
20732 if (x is Foo) is much faster now, because we generate
20735 Overall, we get a pretty big improvement on our benchmark
20736 tests. The code we generate is smaller and more readable.
20738 I did a full two-stage bootstrap. The patch was reviewed
20739 by Martin and Miguel.
20741 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20743 * cs-parser.jay: Make primary_expression not take a QI.
20744 we dont need this because the member_access rule covers
20745 us here. So we replace the rule with just IDENTIFIER.
20747 This has two good effects. First, we remove a s/r conflict.
20748 Second, we allocate many fewer QualifiedIdentifier objects.
20750 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20752 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20753 set the correct information via SRE. This prevents
20754 hanging on the MS runtime. Fixes #29374.
20756 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20758 * convert.cs: correctly handle conversions to value types
20759 from Enum and ValueType as unboxing conversions.
20761 Fixes bug #52569. Patch by Benjamin Jemlich.
20763 2004-01-02 Ravi Pratap <ravi@ximian.com>
20765 * expression.cs (BetterConversion): Prefer int -> uint
20766 over int -> ulong (csc's behaviour). This fixed bug #52046.
20768 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20770 * decl.cs (MemberCache.FindMembers): now returns a
20773 * typemanager.cs: In general, go with with ^^.
20774 (CopyNewMethods): take an IList.
20775 (RealMemberLookup): Only allocate an arraylist
20776 if we copy from two sets of methods.
20778 This change basically does two things:
20779 1) Fewer array lists allocated due to CopyNewMethods.
20780 2) the explicit cast in MemberList costed ALOT.
20782 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20784 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20785 a hashtable to avoid needless string allocations when an identifier is
20786 used more than once (the common case).
20788 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20790 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20791 is broken, it will not return anything. So, we
20792 have to use the information we have in mcs to
20795 * typemanager.cs: Add a cache for GetInterfaces,
20796 since this will now be used more often (due to ^^)
20798 (GetExplicitInterfaces) New method that gets the
20799 declared, not effective, interfaces on a type
20800 builder (eg, if you have interface IFoo, interface
20801 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20804 This patch makes MCS able to bootstrap itself on
20807 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20809 * expression.cs: Remove the Nop's that Miguel put
20812 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20814 * report.cs, codegen.cs: Give the real stack trace to
20815 the error when an exception is thrown.
20817 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20819 * decl.cs: only allocate hashtables for ifaces if
20822 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20824 * expression.cs: fix the error from cs0121-2.cs
20825 (a parent interface has two child interfaces that
20826 have a function with the same name and 0 params
20827 and the function is called through the parent).
20829 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20831 * class.cs, rootcontext.cs, typmanager.cs: do not
20834 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20836 * codegen.cs: remove stack for the ec flow branching.
20837 It is already a linked list, so no need.
20839 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20841 * Makefile: Allow custom profiler here.
20843 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20845 * typemanager.cs (LookupType):
20846 - Use a static char [], because split takes
20847 a param array for args, so it was allocating
20849 - Do not store true in a hashtable, it boxes.
20851 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20853 * flowanalysis.cs: bytify common enums.
20855 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20857 * modifiers.cs: Add a new set of flags for the
20858 flags allowed on explicit interface impls.
20859 * cs-parser.jay: catch the use of modifiers in
20860 interfaces correctly.
20861 * class.cs: catch private void IFoo.Blah ().
20863 All related to bug #50572.
20865 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20867 * decl.cs: Rewrite the consistant accessability checking.
20868 Accessability is not linear, it must be implemented in
20869 a tableish way. Fixes #49704.
20871 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20873 * expression.cs: Handle negation in a checked context.
20874 We must use subtraction from zero. Fixes #38674.
20876 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20878 * class.cs: Ignore static void main in DLLs.
20879 * rootcontext.cs: Handle the target type here,
20880 since we are have to access it from class.cs
20881 * driver.cs: account for the above.
20883 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20885 * report.cs: Give line numbers and files if available.
20887 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20889 * driver.cs: Implement /addmodule.
20891 * typemanager.cs: Change 'modules' field so it now contains Modules not
20894 2003-12-20 Martin Baulig <martin@ximian.com>
20896 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20897 (FieldBase.IsAssigned): Removed this field.
20898 (FieldBase.SetAssigned): New public method.
20899 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20901 2003-12-20 Martin Baulig <martin@ximian.com>
20903 * expression.cs (LocalVariableReference.DoResolve): Don't set
20904 `vi.Used' if we're called from DoResolveLValue().
20906 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20907 returns the usage vector it just merged into the current one -
20908 pass this one to UsageWarning().
20909 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20910 of the `EmitContext', don't call this recursively on our children.
20912 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20914 * driver.cs: Implement /target:module.
20916 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20918 * support.cs (CharArrayHashtable): New helper class.
20920 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20921 char arrays, not strings, so we can avoid creating a string in
20922 consume_identifier if the identifier is a keyword.
20924 2003-12-16 Martin Baulig <martin@ximian.com>
20926 * statement.cs (LocalInfo.Assigned): Removed this property.
20927 (LocalInfo.Flags): Removed `Assigned'.
20928 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20929 and uses flow analysis.
20930 (Block.UsageWarning): Made this method private.
20931 (Block.Resolve): Call UsageWarning() if appropriate.
20933 * expression.cs (LocalVariableReference.DoResolve): Always set
20934 LocalInfo.Used here.
20936 2003-12-13 Martin Baulig <martin@ximian.com>
20938 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20939 any value here; we're now using flow analysis to figure out
20940 whether a statement/block returns a value.
20942 2003-12-13 Martin Baulig <martin@ximian.com>
20944 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20946 (FlowBranching.MergeFinally): Don't call
20947 `branching.CheckOutParameters()' here, this is called in
20949 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20950 when adding the `finally' vector.
20952 2003-12-13 Martin Baulig <martin@ximian.com>
20955 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20956 actually work and also fix #48962.
20958 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20960 * decl.cs: Do not check System.Object for nested types,
20961 since we know it does not have any. Big bang for buck:
20964 Run 1: 8.35 seconds
20965 Run 2: 8.32 seconds
20966 corlib: 17.99 seconds
20968 Run 1: 8.17 seconds
20969 Run 2: 8.17 seconds
20970 corlib: 17.39 seconds
20972 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20974 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20975 time we are returning 0 members, so we save alot here.
20977 2003-12-11 Martin Baulig <martin@ximian.com>
20979 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20980 `MergeChild()', also just take the `FlowBranching' as argument;
20981 call Merge() on it and return the result.
20982 (FlowBranching.Merge): We don't need to do anything if we just
20985 2003-12-11 Martin Baulig <martin@ximian.com>
20987 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20988 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20989 Maurer for this idea.
20991 2003-12-11 Martin Baulig <martin@ximian.com>
20993 * flowanalysis.cs (MergeResult): This class is now gone; we now
20994 use the `UsageVector' for this. The reason for this is that if a
20995 branching just has one sibling, we don't need to "merge" them at
20996 all - that's the next step to do.
20997 (FlowBranching.Merge): We now return a `UsageVector' instead of a
21000 2003-12-11 Martin Baulig <martin@ximian.com>
21002 Reworked flow analyis and made it more precise and bug-free. The
21003 most important change is that we're now using a special `Reachability'
21004 class instead of having "magic" meanings of `FlowReturns'. I'll
21005 do some more cleanups and optimizations and also add some more
21006 documentation this week.
21008 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
21009 largely reworked this class.
21010 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
21011 the new `Reachability' class instead of having "magic" values here.
21012 (FlowBranching): We're now using an instance of `Reachability'
21013 instead of having separate `Returns', `Breaks' etc. fields.
21015 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
21016 based on flow analysis; ignore the return value of block.Emit ().
21018 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
21020 * driver.cs typemanager.cs: Find the mono extensions to corlib even
21021 if they are private.
21023 2003-12-09 Martin Baulig <martin@ximian.com>
21025 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
21026 call them directly on the UsageVector.
21028 2003-12-09 Martin Baulig <martin@ximian.com>
21030 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
21031 Changed return type from `FlowReturns' to `Reachability'.
21033 2003-12-09 Martin Baulig <martin@ximian.com>
21035 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
21036 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
21037 `Reachable' fields with a single `Reachability' one.
21039 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21041 * class.cs (FindMembers): Remove foreach's.
21046 Run 1: 8.74 seconds
21047 Run 2: 8.71 seconds
21050 Run 1: 8.64 seconds
21051 Run 2: 8.58 seconds
21054 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21059 This patch does a few things:
21060 1. EmptyStatement is now a singleton, so it is never reallocated.
21061 2. All blah is EmptyStatement constructs have been changed to
21062 blah == EmptyStatement.Value, which is much faster and valid
21063 now that EmptyStatement is a singleton.
21064 3. When resolving a block, rather than allocating a new array for
21065 the non-empty statements, empty statements are replaced with
21066 EmptyStatement.Value
21067 4. Some recursive functions have been made non-recursive.
21068 Mainly the performance impact is from (3), however (1) and (2) are needed for
21069 this to work. (4) does not make a big difference in normal situations, however
21070 it makes the profile look saner.
21075 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
21076 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
21077 Total memory allocated: 56397 KB
21080 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
21081 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
21082 Total memory allocated: 55666 KB
21084 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21086 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
21087 than the hashtable in a hashtable version
21089 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
21090 we always end up concating a string. This results in a huge perf
21091 loss, because many strings have to be tracked by the GC. In this
21092 patch, we first use a hashtable that works with two keys, so that
21093 the strings do not need to be concat'ed.
21097 Run 1: 8.74 seconds
21098 Run 2: 8.71 seconds
21101 Run 1: 8.65 seconds
21102 Run 2: 8.56 seconds
21104 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21106 * Makefile: Add a new target `do-time' that does a quick and simple
21107 profile, leaving easy to parse output.
21109 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
21111 * codegen.cs (Init): Create the dynamic assembly with
21112 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
21114 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
21116 * support.cs: Make the PtrHashtable use only one
21117 instance of its comparer.
21119 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
21121 * typemanager.cs: Fix lookup of GetNamespaces.
21123 2003-11-29 Miguel de Icaza <miguel@ximian.com>
21125 * expression.cs: Removed redundant line.
21127 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
21128 ArrayLists, use for loops with bounds.
21130 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
21133 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
21134 arraylists, use for loop with bounds.
21136 The above three changes give us a 0.071 second performance
21137 improvement out of 3.294 seconds down to 3.223. On my machine
21138 the above changes reduced the memory usage by 1,387 KB during
21139 compiler bootstrap.
21141 * cs-parser.jay (QualifiedIdentifier): New class used to represent
21142 QualifiedIdentifiers. Before we created a new string through
21143 concatenation, and mostly later on, the result would be
21144 manipulated by DecomposeQI through string manipulation.
21146 This reduced the compiler memory usage for bootstrapping from
21147 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
21148 compile times in 0.05 seconds.
21150 2003-11-28 Dick Porter <dick@ximian.com>
21152 * support.cs: Do string compares with the Invariant culture.
21160 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
21161 the comparison is done with the Invariant culture.
21163 2003-11-27 Miguel de Icaza <miguel@ximian.com>
21165 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
21166 GetEnumerator method.
21168 (ProbeCollectionType): Iterate starting at the most specific type
21169 upwards looking for a GetEnumerator
21171 * expression.cs: Shift count can be up to 31 for int/uint and 63
21174 2003-11-26 Miguel de Icaza <miguel@ximian.com>
21176 * statement.cs (Block.LookupLabel): Also look for the label on the
21177 children blocks. Use a hash table to keep track of visited
21180 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
21181 we actually did transform the other operand, otherwise fall back
21182 to the common codepath that casts to long.
21184 * cs-tokenizer.cs: Use the same code pattern as the int case.
21185 Maybe I should do the parsing myself, and avoid depending on the
21186 Parse routines to get this done.
21188 2003-11-25 Miguel de Icaza <miguel@ximian.com>
21190 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21191 which fixes bug 51347. This time test it.
21193 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
21194 attributes for example can not tell the difference between these.
21195 The difference was only a syntax feature of the language.
21197 * attribute.cs: Apply attributes to delegates.
21199 * delegate.cs: Call the apply attributes method.
21201 2003-11-24 Miguel de Icaza <miguel@ximian.com>
21203 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
21204 comparing 0 vs Byte.MinValue, not the value
21206 (ImplicitConversionRequired): When reporting a conversion error,
21207 use error 31 to print out the constant error instead of the
21210 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21211 which fixes bug 51347.
21213 2003-11-22 Miguel de Icaza <miguel@ximian.com>
21215 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
21216 which fixes the -warnaserror command line option.
21218 2003-11-21 Miguel de Icaza <miguel@ximian.com>
21220 * cfold.cs (DoNumericPromotions): During constant folding of
21221 additions on UIntConstant, special case intconstants with
21222 IntConstants like we do on the expression binary operator.
21224 2003-11-12 Miguel de Icaza <miguel@ximian.com>
21226 * convert.cs (ImplicitReferenceConversion): We were missing a case
21227 (System.Enum are not value types or class types, so we need to
21228 classify them separatedly).
21230 * driver.cs: We do not support error 2007.
21232 2003-11-12 Jackson Harper <jackson@ximian.com>
21234 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
21235 system directory. Also use the full file name so users can
21236 libraries names mscorlib-o-tron.dll in a non system dir.
21238 2003-11-10 Martin Baulig <martin@ximian.com>
21240 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
21241 (TypeManager.InitCoreTypes): Initialize them here, but instead of
21242 calling `ResolveType()' on them, directly assign their `Type'.
21244 2003-11-08 Martin Baulig <martin@ximian.com>
21246 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
21247 return value and the `out parent' parameter.
21248 (TypeContainer.DefineType): Moved the CS0644 check into
21249 GetClassBases(). Don't pass the interface types to the
21250 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
21251 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
21253 * ecore.cs (TypeExpr.IsAttribute): New property.
21254 (TypeExpr.GetInterfaces): New method.
21256 * interface.cs (Interface.GetInterfaceTypeByName): Return a
21257 TypeExpr instead of a Type.
21258 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
21259 (Interface.DefineType): Don't pass the interface types to the
21260 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
21261 them later and then call `TypeBulider.AddInterfaceImplementation()'.
21263 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
21264 instead of a `Type[]'.
21265 (TypeManager.RegisterBuilder): Likewise.
21266 (TypeManager.AddUserInterface): Likewise.
21267 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
21268 `Type[]' and also return a `TypeExpr[]'.
21269 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
21271 2003-11-08 Martin Baulig <martin@ximian.com>
21273 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
21276 2003-11-08 Martin Baulig <martin@ximian.com>
21278 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
21279 TypeManager.ResolveExpressionTypes().
21281 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
21282 instead of an Expression.
21283 (TypeExpr): This is now an abstract base class for `TypeExpression'.
21284 (TypeExpression): New public class; formerly known as `TypeExpr'.
21286 * expression.cs (ComposedCast): Derive from TypeExpr.
21288 * typemanager.cs (TypeManager.system_*_expr): These are now
21289 TypExpr's instead of Expression's.
21290 (TypeManager.ResolveExpressionTypes): New public static function;
21291 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
21294 2003-11-06 Miguel de Icaza <miguel@ximian.com>
21296 * expression.cs (New.DoResolve): Do not dereference value that
21297 might be a null return.
21299 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
21300 sure that the constant value has the right type. Fixes an
21301 unreported bug, similar to 50425.
21303 * const.cs (Const.LookupConstantValue): Call
21304 ImplicitStandardConversionExists before doing a conversion to
21305 avoid havng the TypeManager.ChangeType do conversions.
21307 Reduced the number of casts used
21309 (Const.ChangeType): New routine to enable reuse of the constant
21310 type changing code from statement.
21312 * typemanager.cs (ChangeType): Move common initialization to
21313 static global variables.
21317 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
21318 every value type to go through, even if it was void. Fix that.
21320 * cs-tokenizer.cs: Use is_identifier_start_character on the start
21321 character of the define, and the is_identifier_part_character for
21322 the rest of the string.
21324 2003-11-05 Miguel de Icaza <miguel@ximian.com>
21326 * expression.cs (UnaryMutator.EmitCode): When I updated
21327 LocalVariableReference.DoResolve, I overdid it, and dropped an
21328 optimization done on local variable references.
21330 2003-11-04 Miguel de Icaza <miguel@ximian.com>
21332 * ecore.cs: Convert the return from Ldlen into an int.
21334 2003-10-20 Miguel de Icaza <miguel@ximian.com>
21336 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
21337 the accessibility, this is a special case for toplevel non-public
21338 classes (internal for instance).
21340 2003-10-20 Nick Drochak <ndrochak@gol.com>
21342 * ecore.cs: Fix typo and build. Needed another right paren.
21344 2003-10-19 Miguel de Icaza <miguel@ximian.com>
21346 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
21347 `internal' case regular and protected, but not allowing protected
21348 to be evaluated later. Bug 49840
21350 2003-10-15 Miguel de Icaza <miguel@ximian.com>
21352 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
21353 to kb.Nlast, and not the kb.nFirst to isolate the switch
21356 Extract the underlying type, so enumerations of long/ulong are
21357 treated like long/ulong.
21359 2003-10-14 Miguel de Icaza <miguel@ximian.com>
21361 * expression.cs (New): Overload the meaning of RequestedType to
21362 track the possible creation of the NewDelegate type, since
21363 DoResolve is invoked more than once for new constructors on field
21366 See bugs: #48800 and #37014
21368 * cs-parser.jay (declare_local_constants): Take an arraylist
21369 instead of a single constant.
21371 (local_constant_declaration): It should take a
21372 constant_declarators, not a constant_declarator. Fixes 49487
21374 * convert.cs: Fix error report.
21376 2003-10-13 Jackson Harper <jackson@ximian.com>
21378 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21381 2003-10-09 Martin Baulig <martin@ximian.com>
21383 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21385 (MethodCore.DoDefineParameters): Removed the TypeContainer
21386 argument; use the DeclSpace which was passed to the .ctor instead.
21387 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21388 TypeContainer; we only need a DeclSpace here.
21390 2003-10-09 Martin Baulig <martin@ximian.com>
21392 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21394 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21395 EmitContext's .ctor.
21397 2003-10-09 Martin Baulig <martin@ximian.com>
21399 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21400 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21401 AsAccessible(), moved them as well.
21403 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21405 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21407 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21409 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21411 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21412 generation for >=, as spotted by Paolo, bug 48679.
21413 Patch from David Waite.
21415 * cs-tokenizer.cs: Add handling for #pragma.
21417 * cs-parser.jay: Allow for both yield and yield return in the
21418 syntax. The anti-cobolization of C# fight will go on!
21420 * class.cs (TypeBuilder.DefineType): Catch error condition here
21421 (Parent.DefineType erroring out and returning null).
21423 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21424 coping with enumerations variables, we were mistakenly processing
21425 them as a regular value type instead of built-in types. Fixes the
21428 * typemanager.cs (IsBuiltinOrEnum): New method.
21430 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21432 * cs-parser.jay: Upgrade: yield now needs the return clause.
21434 2003-09-19 Martin Baulig <martin@ximian.com>
21436 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21437 `MemberCache parent' argument. Normally, an interface doesn't
21438 have a parent type except System.Object, but we use this in gmcs
21439 for generic type parameters.
21441 2003-09-18 Martin Baulig <martin@ximian.com>
21443 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21444 on `type.IsInterface'; don't check whether the type has a parent
21445 to determine whether it's an interface.
21447 2003-09-15 Martin Baulig <martin@ximian.com>
21449 * class.cs (TypeContainer.DefineType): Added an error flag to
21450 avoid reporting duplicate CS0146's ("class definition is
21453 * driver.cs (Driver.MainDriver): Abort if
21454 RootContext.ResolveTree() reported any errors.
21456 2003-09-07 Martin Baulig <martin@ximian.com>
21458 * report.cs (Error, Warning): Added overloaded versions which take
21459 a `params object[] args' and call String.Format().
21461 2003-09-07 Martin Baulig <martin@ximian.com>
21463 * decl.cs (DeclSpace..ctor): Don't call
21464 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21465 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21466 (DeclSpace.RecordDecl): New method.
21468 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21470 2003-09-02 Ravi Pratap <ravi@ximian.com>
21472 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21473 value attributes to be applied to ParameterBuilders.
21475 * class.cs (MethodCore.LabelParameters): Make static and more
21476 generic so that it can be used from other places - like interface
21477 methods, for instance.
21479 * interface.cs (Interface.Emit): Call LabelParameters before
21480 emitting attributes on the InterfaceMethod.
21482 2003-08-26 Martin Baulig <martin@ximian.com>
21484 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21485 resolving aliases; fixes #47927.
21487 2003-08-26 Martin Baulig <martin@ximian.com>
21489 * statement.cs (Using.DoResolve): This is internally emitting a
21490 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21491 do not always return. Fixes #47681.
21493 2003-08-26 Martin Baulig <martin@ximian.com>
21495 * decl.cs (MemberCore): Moved WarningNotHiding(),
21496 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21498 (AdditionResult): Make this nested in DeclSpace.
21499 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21500 argument; call NamespaceEntry.Define() unless we're nested in a
21503 * namespace.cs (Namespace.DefineName): New public function. This
21504 is called from DeclSpace's .ctor to add
21505 (Namespace.Lookup): Include DeclSpaces in the lookup.
21507 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21509 * const.cs (Const): Derive from MemberBase, not MemberCore.
21511 2003-08-25 Martin Baulig <martin@ximian.com>
21513 * convert.cs (Convert.ExplicitReferenceConversion): When
21514 converting from an interface type to a class, unbox if the target
21515 type is a struct type. Fixes #47822.
21517 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21519 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21522 2003-08-22 Martin Baulig <martin@ximian.com>
21524 * class.cs (TypeManager.DefineType): When defining a nested type,
21525 call DefineType() on our parent; fixes #47801.
21527 2003-08-22 Martin Baulig <martin@ximian.com>
21529 * class.cs (MethodData.Define): While checking if a method is an
21530 interface implementation, improve the test a bit more to fix #47654.
21532 2003-08-22 Martin Baulig <martin@ximian.com>
21534 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21535 correctly; fixes #47722.
21537 2003-08-22 Martin Baulig <martin@ximian.com>
21539 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21540 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21542 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21544 2003-08-22 Martin Baulig <martin@ximian.com>
21546 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21547 can only be assigned in static constructors. Fixes #47161.
21549 2003-08-22 Martin Baulig <martin@ximian.com>
21551 Rewrote and improved the flow analysis code.
21553 * flowbranching.cs (FlowBranching): Make this class abstract.
21554 (FlowBranching.CreateBranching): New static function to create a
21555 new flow branching.
21556 (FlowBranchingBlock, FlowBranchingException): New classes.
21557 (FlowBranching.UsageVector.Type): New public readonly field.
21558 (FlowBranching.UsageVector.Breaks): Removed the setter.
21559 (FlowBranching.UsageVector.Returns): Removed the setter.
21560 (FlowBranching.UsageVector): Added Break(), Return(),
21561 NeverReachable() and Throw() methods to modify the reachability.
21562 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21563 done by FlowBranching.Merge().
21564 (FlowBranching.UsageVector.MergeChild): New method; merges the
21565 merge result into the current vector.
21566 (FlowBranching.Merge): New abstract method to merge a branching.
21568 2003-08-12 Martin Baulig <martin@ximian.com>
21570 * expression.cs (Indirection.CacheTemporaries): Create the
21571 LocalTemporary with the pointer type, not its element type.
21573 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21575 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21576 token was a keyword or not.
21578 Add `error' options where an IDENTIFIER was expected; Provide
21579 CheckToken and CheckIdentifierToken convenience error reporting
21582 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21584 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21585 NameSpaceEntry NameSpaceEntry.
21587 (LookupInterfaceOrClass): Avoid creating a full qualified name
21588 from namespace and name: avoid doing lookups when we know the
21589 namespace is non-existant. Use new Tree.LookupByNamespace which
21590 looks up DeclSpaces based on their namespace, name pair.
21592 * driver.cs: Provide a new `parser verbose' to display the
21593 exception thrown during parsing. This is turned off by default
21594 now, so the output of a failure from mcs is more graceful.
21596 * namespace.cs: Track all the namespaces defined in a hashtable
21599 (IsNamespace): New method
21601 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21603 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21604 we know that we need to concatenate (full typename can never be
21609 * statement.cs: Use a bitfield; Do not initialize to null things
21610 which are done by the constructor by default.
21612 * cs-parser.jay: bug fix, parameter was 4, not 3.
21614 * expression.cs: Just use the property;
21616 * statement.cs: No need for GetVariableInfo method.
21618 2003-08-08 Martin Baulig <martin@ximian.com>
21620 * flowanalysis.cs (FlowReturns): This is now nested in the
21621 `FlowBranching' class.
21622 (MyBitVector): Moved this here from statement.cs.
21623 (FlowBranching.SiblingType): New enum type.
21624 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21626 2003-08-07 Martin Baulig <martin@ximian.com>
21628 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21629 `FlowBranching' class and called `BranchingType'.
21631 2003-08-07 Martin Baulig <martin@ximian.com>
21633 * flowanalysis.cs: Moved all the control flow analysis code into
21636 2003-08-07 Martin Baulig <martin@ximian.com>
21638 * assign.cs (Assign.DoResolve): `target' must either be an
21639 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21642 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21644 * expression.cs (BinaryMethod): This kind of expression is created by the
21645 Binary class if it determines that the operator has to be handled
21648 (BinaryDelegate): This kind of expression is created if we are
21649 dealing with a + or - operator on delegates.
21651 (Binary): remove method, argumetns, and DelegateOperator: when
21652 dealing with methods,
21654 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21656 * statement.cs (Block): use bitfields for the three extra booleans
21657 we had in use. Remove unused topblock parameter.
21659 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21661 * assign.cs: Drop extra unneeded tests.
21663 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21665 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21667 * statement.cs (Foreach): Use VariableStorage instead of
21670 * codegen.cs (VariableStorage): New class used by clients that
21671 require a variable stored: locals or fields for variables that
21672 need to live across yield.
21674 Maybe provide a convenience api for EmitThis+EmitLoad?
21676 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21679 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21681 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21682 RemapParameterLValue): New methods that are used to turn a
21683 precomputed FieldInfo into an expression like this:
21687 The idea is to use this instead of making LocalVariableReference
21688 have more than one meaning.
21690 * cs-parser.jay: Add error production to BASE.
21692 * ecore.cs: Deal with TypeManager.GetField returning null, which
21693 is now a valid return value.
21695 (FieldExprNoAddress): New expression for Fields whose address can
21698 * expression.cs (LocalVariableReference): During the resolve
21699 phases, create new expressions if we are in a remapping context.
21700 Remove code that dealt with remapping here.
21702 (ParameterReference): same.
21704 (ProxyInstance): New expression, like the `This' expression, but
21705 it is born fully resolved. We know what we are doing, so remove
21706 the errors that are targeted to user-provided uses of `this'.
21708 * statement.cs (Foreach): our variable is now stored as an
21709 Expression; During resolution, follow the protocol, dont just
21710 assume it will return this.
21712 2003-08-06 Martin Baulig <martin@ximian.com>
21714 * support.cs (SeekableStreamReader.cs): New public class.
21716 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21717 SeekableStreamReader instead of the normal StreamReader.
21719 2003-08-04 Martin Baulig <martin@ximian.com>
21721 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21722 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21723 deambiguate casts and delegate invocations.
21724 (parenthesized_expression): Use the new tokens to ensure this is
21725 not a cast of method invocation.
21727 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21728 when reading a `)' and Deambiguate_CloseParens () was previously
21731 * expression.cs (ParenthesizedExpression): New class. This is
21732 just used for the CS0075 test.
21733 (Binary.DoResolve): Check for CS0075.
21735 2003-07-29 Ravi Pratap <ravi@ximian.com>
21737 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21738 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21739 reference comparison.
21741 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21742 examine the ReturnType for equality - this is necessary in the
21743 cases of implicit and explicit operators whose signature also
21744 includes the return type.
21746 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21748 * namespace.cs: Cache the result of the namespace computation,
21749 instead of computing it every time.
21751 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21753 * decl.cs: Use a global arraylist that we reuse over invocations
21754 to avoid excesive memory consumption. Reduces memory usage on an
21755 mcs compile by one meg (45 average).
21757 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21758 private, work around that.
21760 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21762 * literal.cs (IntLiteral): Define Zero and One static literals.
21764 * cs-parser.jay (integer_literal): use static literals to reduce
21765 memory usage for the most used literals (0, 1 and -1). 211kb
21766 reduced in memory usage.
21768 Replace all calls to `new ArrayList' with `new
21769 ArrayList(4)' which is a good average number for most allocations,
21770 and also requires only 16 bytes of memory for its buffer by
21773 This reduced MCS memory usage in seven megabytes for the RSS after
21776 2003-07-28 Ravi Pratap <ravi@ximian.com>
21778 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21779 handle params methods the correct way by forming only one
21780 applicable set with params and normal methods in them. Earlier we
21781 were looking at params methods only if we found no normal methods
21782 which was not the correct thing to do.
21784 (Invocation.BetterFunction): Take separate arguments indicating
21785 when candidate and the best method are params methods in their
21788 This fixes bugs #43367 and #46199.
21790 * attribute.cs: Documentation updates.
21792 (CheckAttribute): Rename to CheckAttributeTarget.
21793 (GetValidPlaces): Rename to GetValidTargets.
21795 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21796 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21800 2003-07-28 Martin Baulig <martin@ximian.com>
21802 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21803 name when looking up the base class of a nested class. Fixes #46977.
21805 2003-07-26 Martin Baulig <martin@ximian.com>
21807 * expression.cs (Indexers.Indexer): New nested struct; contains
21808 getter, setter and the indexer's type.
21809 (Indexers.Properties): This is now an ArrayList of
21810 Indexers.Indexer's.
21811 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21812 indexer doesn't have any getters.
21814 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21815 for embedded property and indexer assignments.
21817 2003-07-26 Martin Baulig <martin@ximian.com>
21819 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21820 preprocessor directive is not the first non-whitespace character
21823 2003-07-26 Martin Baulig <martin@ximian.com>
21825 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21826 namespace parsing, follow the spec more closely.
21828 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21829 NamespaceEntry.Lookup().
21831 2003-07-25 Martin Baulig <martin@ximian.com>
21833 * MethodCore.cs (OverridesSomething): New public field; it's set
21834 from TypeContainer.DefineMembers if this method overrides
21835 something (which doesn't need to be a method). Fix #39462.
21837 2003-07-25 Ravi Pratap <ravi@ximian.com>
21839 * typemanager.cs (GetMembers): Ensure that the list of members is
21840 reversed. This keeps things in sync.
21842 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21843 find an AttributeUsage attribute.
21845 * expression.cs (Invocation.OverloadResolve): Perform the check
21846 which disallows Invoke to be directly called on a Delegate.
21848 (Error_InvokeOnDelegate): Report error cs1533.
21850 2003-07-25 Martin Baulig <martin@ximian.com>
21852 * expression.cs (Indexers.GetIndexersForType): Only look in the
21853 interface hierarchy if the requested type is already an
21854 interface. Fixes #46788 while keeping #46502 fixed.
21856 2003-07-25 Martin Baulig <martin@ximian.com>
21858 * class.cs (TypeContainer.DefineMembers): Check whether all
21859 readonly fields have been assigned and report warning CS0649 if
21862 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21865 2003-07-24 Ravi Pratap <ravi@ximian.com>
21867 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21868 returned from GetMethods to make things consistent with the
21869 assumptions MCS makes about ordering of methods.
21871 This should comprehensively fix bug #45127 and it does :-)
21873 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21874 ordering is actually reverse.
21876 * Clean up some debug messages I left lying around.
21878 * interface.cs (Populate*): Get rid of code which emits attributes
21879 since the stage in which we emit attributes is the 'Emit' stage,
21880 not the define stage.
21882 (Emit): Move attribute emission for interface members here.
21884 2003-07-22 Ravi Pratap <ravi@ximian.com>
21886 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21887 closely: we eliminate methods in base types when we have an
21888 applicable method in a top-level type.
21890 Please see section 14.5.5.1 for an exact description of what goes
21893 This fixes bug #45127 and a host of other related to corlib compilation.
21895 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21896 array is the method corresponding to the top-level type (this is
21897 because of the changes made to icall.c) so we change this
21900 (MethodGroupExpr.Name): This too.
21902 * typemanager.cs (GetElementType): New method which does the right
21903 thing when compiling corlib.
21905 * everywhere: Make use of the above in the relevant places.
21907 2003-07-22 Martin Baulig <martin@ximian.com>
21909 * cs-parser.jay (invocation_expression): Moved
21910 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21911 `cast_expression', but create a InvocationOrCast which later
21912 resolves to either an Invocation or a Cast.
21914 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21915 method; call this before EmitStatement() to make sure that this
21916 expression can be used as a statement.
21918 * expression.cs (InvocationOrCast): New class; resolves to either
21919 an Invocation or a Cast.
21921 * statement.cs (StatementExpression): Call ResolveStatement() on
21922 the ExpressionStatement before emitting it.
21924 2003-07-21 Martin Baulig <martin@ximian.com>
21926 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21927 `ref' and `out' attributes match; fixes #46220.
21928 (MemberAccess.ResolveMemberAccess): You can't reference a type
21929 through an expression; fixes #33180.
21930 (Indexers.GetIndexersForType): Don't return the indexers from
21931 interfaces the class implements; fixes #46502.
21933 2003-07-21 Martin Baulig <martin@ximian.com>
21935 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21936 CS0661 checks; fixes bug #30442.
21938 2003-07-21 Martin Baulig <martin@ximian.com>
21940 * decl.cs (AdditionResult): Added `Error'.
21942 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21944 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21945 makes cs0031.cs actually work.
21947 2003-07-20 Martin Baulig <martin@ximian.com>
21949 * namespace.cs: Fixed that bug which caused a crash when compiling
21950 the debugger's GUI.
21952 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21954 * typemanager.cs (LookupTypeReflection): Never expose types which
21955 are NotPublic, NestedPrivate, NestedAssembly, or
21956 NestedFamANDAssem. We used to return these, and later do a check
21957 that would report a meaningful error, but the problem is that we
21958 would not get the real match, if there was a name override.
21960 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21962 * namespace.cs (Namespace, Name): Do not compute the namespace
21963 name dynamically, compute it in the constructor. This reduced
21964 memory usage by 1697 KB.
21966 * driver.cs: Use --pause to pause at the end.
21968 2003-07-17 Peter Williams <peter@newton.cx>
21970 * Makefile: Change the name of the test target so that it doesn't
21971 conflict with the recursive test target.
21973 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21975 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21976 AddressOf): Do not use EmitThis, that was wrong, use the actual
21979 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21981 * class.cs (MethodData.Define): While checking if a method is an
21982 interface implementation, improve the test: If we are not public
21983 (use new test here: use the computed MethodAttributes directly,
21984 instead of the parsed modifier flags) check if the `implementing'
21985 method comes from an interface or not.
21987 * pending.cs (VerifyPendingMethods): Slightly better error
21990 * makefile: add test target that does the mcs bootstrap.
21992 2003-07-16 Ravi Pratap <ravi@ximian.com>
21994 * interface.cs (Define): Do nothing here since there are no
21995 members to populate etc. Move the attribute emission out of here
21996 since this was just totally the wrong place to put it. Attribute
21997 application happens during the 'Emit' phase, not in the 'Define'
22000 (Emit): Add this method and move the attribute emission here
22002 * rootcontext.cs (EmitCode): Call the Emit method on interface
22005 2003-07-14 Ravi Pratap M <ravi@ximian.com>
22007 * expression.cs (OverloadResolve): Report error only if Location
22008 is not 'Null' which means that there was a probe going on.
22010 2003-07-14 Martin Baulig <martin@ximian.com>
22012 * expression.cs (ConditionalLogicalOperator): New public class to
22013 implement user defined conditional logical operators.
22014 This is section 14.11.2 in the spec and bug #40505.
22016 2003-07-14 Martin Baulig <martin@ximian.com>
22018 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
22020 2003-07-14 Martin Baulig <martin@ximian.com>
22022 * codegen.cs (EmitContext.InFixedInitializer): New public field.
22024 * ecore.cs (IVariable.VerifyFixed): New interface method.
22026 * expression.cs (Unary.ResolveOperator): When resolving the `&'
22027 operator, check whether the variable is actually fixed. Fixes bug
22028 #36055. Set a variable definitely assigned when taking its
22029 address as required by the spec.
22031 * statement.cs (LocalInfo.IsFixed): New field.
22032 (LocalInfo.MakePinned): Set `IsFixed' to true.
22034 2003-07-14 Ravi Pratap M <ravi@ximian.com>
22036 * attribute.cs (Attribute.Resolve): While doing a Member lookup
22037 for .ctors, ensure that we only ask for members declared in the
22038 attribute type (BindingFlags.DeclaredOnly).
22042 * expression.cs (Error_WrongNumArguments): Report error 1501
22043 correctly the way CSC does.
22045 2003-07-13 Martin Baulig <martin@ximian.com>
22047 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
22048 lookup on the fully qualified name, to make things like "X.X" work
22049 where "X.X" is a fully qualified type name, but we also have a
22050 namespace "X" in the using list. Fixes #41975.
22052 2003-07-13 Martin Baulig <martin@ximian.com>
22054 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
22055 function. If we're a CompoundAssign, we need to create an embedded
22056 CompoundAssign, not an embedded Assign.
22057 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
22060 2003-07-13 Martin Baulig <martin@ximian.com>
22062 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
22063 work to fix bug #46088.
22065 2003-07-13 Ravi Pratap <ravi@ximian.com>
22067 * class.cs (Operator.Emit): Do not emit attributes here - it is
22068 taken care of by the Method class that we delegate too. This takes
22069 care of bug #45876.
22071 2003-07-10 Martin Baulig <martin@ximian.com>
22073 * expression.cs (TypeOfVoid): New class.
22074 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
22076 2003-07-10 Martin Baulig <martin@ximian.com>
22078 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
22081 2003-07-10 Martin Baulig <martin@ximian.com>
22083 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
22084 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
22086 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
22088 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
22090 2003-07-10 Martin Baulig <martin@ximian.com>
22092 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
22093 of decimal. Fixes #42850.
22095 NOTE: I also fixed the created byte blob, but this doesn't work on
22096 the MS runtime and csc never produces any byte blobs for decimal
22099 2003-07-10 Martin Baulig <martin@ximian.com>
22101 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
22102 structs; fixes #32068.
22103 (Block.AddChildVariableNames): Fixed #44302.
22105 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22107 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
22109 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22111 * attribute.cs: And this test is onger needed.
22113 2003-07-08 Martin Baulig <martin@ximian.com>
22115 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
22116 inaccessible types. Fixes #36313.
22118 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
22120 * namespace.cs (NamespaceEntry): Create implicit entries for all
22121 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
22122 implicit entries for N1.N2 and N1.
22124 2003-07-08 Martin Baulig <martin@ximian.com>
22126 Rewrote the handling of namespaces to fix a lot of the issues
22127 wrt. `using' aliases etc.
22129 * namespace.cs (Namespace): Splitted this class into a
22130 per-assembly `Namespace' and a per-file `NamespaceEntry'.
22132 * typemanager.cs (TypeManager.IsNamespace): Removed.
22133 (TypeManager.ComputeNamespaces): Only compute namespaces from
22134 loaded assemblies here, not the namespaces from the assembly we're
22135 currently compiling.
22137 2003-07-08 Martin Baulig <martin@ximian.com>
22139 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
22141 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22143 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
22146 I thought about the memory savings here, but LookupTypeReflection
22147 is used under already very constrained scenarios. Compiling
22148 corlib or mcs only exposes one hit, so it would not really reduce
22149 any memory consumption.
22151 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22153 * typemanager.cs: fixes bug #45889 by only adding public types from
22154 other assemblies to the list of known types.
22156 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22158 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
22159 on the type we resolved.
22161 2003-07-05 Martin Baulig <martin@ximian.com>
22163 * pending.cs (PendingImplementation.ParentImplements): Don't
22164 create the proxy if the parent is abstract.
22166 * class.cs (TypeContainer.DefineIndexers): Process explicit
22167 interface implementations first. Fixes #37714.
22169 2003-07-04 Miguel de Icaza <miguel@ximian.com>
22171 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
22172 defined recursively; but since we modify the input parameters
22173 (left is set to `this' temporarily), we reset this value if the
22174 left_is_explicit is false, which gives the original semantics to
22177 * literal.cs (NullPointer): new class used to represent a null
22178 literal in a pointer context.
22180 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
22181 type is a pointer, use a NullPointer object instead of a
22182 NullLiteral. Closes 43687
22184 (ExplicitConversion): Convert pointer values using
22185 the conv opcode to the proper type.
22187 * ecore.cs (New): change ValueTypeVariable property into a method,
22188 that returns whether the valuetype is suitable for being used.
22190 * expression.cs (Binary.DoNumericPromotions): Only return if we
22191 the int constant was a valid uint, and we can return both left and
22192 right as uints. If not, we continue processing, to trigger the
22193 type conversion. This fixes 39018.
22195 * statement.cs (Block.EmitMeta): During constant resolution, set
22196 the CurrentBlock property on the emitcontext, so that we resolve
22197 constants propertly.
22199 2003-07-02 Martin Baulig <martin@ximian.com>
22201 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
22202 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
22204 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
22205 than emitting it here.
22207 * statement.cs: Fixed some more flow analysis bugs.
22209 2003-07-02 Martin Baulig <martin@ximian.com>
22211 * class.cs (MethodData.Define): When implementing interface
22212 methods, set Final unless we're Virtual.
22214 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
22215 check work for interface methods.
22217 2003-07-01 Martin Baulig <martin@ximian.com>
22219 * ecore.cs (EmitContext.This): Replaced this property with a
22220 GetThis() method which takes a Location argument. This ensures
22221 that we get the correct error location for a CS0188.
22223 2003-07-01 Miguel de Icaza <miguel@ximian.com>
22225 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
22226 ImplicitStandardConversion.
22228 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
22230 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
22232 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
22235 2003-06-30 Miguel de Icaza <miguel@ximian.com>
22237 * class.cs (Constructor.Define): Turn off initlocals for unsafe
22240 (MethodData.Define): Turn off initlocals for unsafe methods.
22242 2003-06-29 Miguel de Icaza <miguel@ximian.com>
22244 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
22245 complete; Fixes #37521.
22247 * delegate.cs: Use Modifiers.TypeAttr to compute the
22248 TypeAttributes, instead of rolling our own. This makes the flags
22249 correct for the delegates.
22251 2003-06-28 Miguel de Icaza <miguel@ximian.com>
22253 * class.cs (Constructor.Define): Set the private flag for static
22254 constructors as well.
22256 * cs-parser.jay (statement_expression): Set the return value to
22257 null, to avoid a crash when we catch an error.
22259 2003-06-24 Miguel de Icaza <miguel@ximian.com>
22261 * cs-parser.jay: Applied patch from Jackson that adds support for
22262 extern and unsafe modifiers to destructor declarations.
22264 * expression.cs: Report error 21 if the user is trying to index a
22267 * driver.cs: Add an error message, suggested by the bug report.
22269 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
22270 if we do not have a ": this ()" constructor initializer. Fixes 45149
22272 2003-06-14 Miguel de Icaza <miguel@ximian.com>
22274 * namespace.cs: Add some information to reduce FAQs.
22276 2003-06-13 Miguel de Icaza <miguel@ximian.com>
22278 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
22279 underlying enumeration types. Fixes #43915.
22281 * expression.cs: Treat ushort/short as legal values to be used in
22282 bitwise operations.
22284 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
22286 * delegate.cs: transfer custom attributes for paramenters from
22287 the delegate declaration to Invoke and BeginInvoke.
22289 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
22291 * attribute.cs: handle custom marshalers and emit marshal info
22294 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
22296 * makefile.gnu: Added anonymous.cs to the compiler sources.
22298 2003-05-28 Miguel de Icaza <miguel@ximian.com>
22300 * iterators.cs: Change the name of the proxy class to include two
22303 * cs-parser.jay: Update grammar to include anonymous methods.
22305 * anonymous.cs: new file.
22307 2003-05-27 Miguel de Icaza <miguel@ximian.com>
22309 * class.cs (Field.Define): Add missing test for pointers and
22312 2003-05-27 Ravi Pratap <ravi@ximian.com>
22314 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
22315 we use the stobj opcode.
22317 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
22318 since it wasn't the correct fix.
22320 It still is puzzling that we are required to use stobj for IntPtr
22321 which seems to be a ValueType.
22323 2003-05-26 Miguel de Icaza <miguel@ximian.com>
22325 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
22326 during regular simple name resolution. Now, the trick is that
22327 instead of returning for processing the simplename, we do a
22328 TypeManager.LookupType (ie, a rooted lookup as opposed to a
22329 contextual lookup type). If a match is found, return that, if
22330 not, return for further composition.
22332 This fixes long-standing 30485.
22334 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
22335 using the address to initialize an object, do an Stobj instead of
22336 using the regular Stelem.
22338 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
22339 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
22340 Because if we are a BaseIndexerAccess that value will be true.
22343 * statement.cs (GotoCase.Resolve): Return after reporting an
22344 error, do not attempt to continue.
22346 * expression.cs (PointerArithmetic.Emit): If our operand is a
22347 long, convert our constants to match the operand before
22348 multiplying. Convert to I type before adding. Fixes 43670.
22350 2003-05-14 Ravi Pratap <ravi@ximian.com>
22352 * enum.cs (ImplicitConversionExists) : Rename to
22353 ImplicitEnumConversionExists to remove ambiguity.
22355 * ecore.cs (NullCast): New type of cast expression class which
22356 basically is very similar to EmptyCast with the difference being
22357 it still is a constant since it is used only to cast a null to
22359 (eg. (string) null)
22361 * convert.cs (ImplicitReferenceConversion): When casting a null
22362 literal, we return a NullCast.
22364 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22365 should be around anymore.
22367 The renaming (reported was slightly wrong). Corrections:
22369 ConvertImplicitStandard -> ImplicitConversionStandard
22370 ConvertExplicitStandard -> ExplicitConversionStandard
22372 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22373 before passing them in !
22375 * convert.cs (ImplicitConversionStandard): When comparing for
22376 equal expr and target types, ensure that expr is not a
22379 In general, we must not be checking (expr_type ==
22380 target_type) in the top level conversion methods
22381 (ImplicitConversion, ExplicitConversion etc). This checking is
22382 done in the methods that they delegate to.
22384 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22386 * convert.cs: Move Error_CannotConvertType,
22387 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22388 ImplicitNumericConversion, ImplicitConversionExists,
22389 ImplicitUserConversionExists, StandardConversionExists,
22390 FindMostEncompassedType, FindMostSpecificSource,
22391 FindMostSpecificTarget, ImplicitUserConversion,
22392 ExplicitUserConversion, GetConversionOperators,
22393 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22394 TryImplicitIntConversion, Error_CannotConvertImplicit,
22395 ConvertImplicitRequired, ConvertNumericExplicit,
22396 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22397 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22400 Perform the following renames:
22402 StandardConversionExists -> ImplicitStandardConversionExists
22403 ConvertImplicit -> ImplicitConversion
22404 ConvertImplicitStandard -> ImplicitStandardConversion
22405 TryImplicitIntConversion -> ImplicitIntConversion
22406 ConvertImplicitRequired -> ImplicitConversionRequired
22407 ConvertNumericExplicit -> ExplicitNumericConversion
22408 ConvertReferenceExplicit -> ExplicitReferenceConversion
22409 ConvertExplicit -> ExplicitConversion
22410 ConvertExplicitStandard -> ExplicitStandardConversion
22412 2003-05-19 Martin Baulig <martin@ximian.com>
22414 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22415 (TypeInfo): Added support for structs having structs as fields.
22417 * ecore.cs (FieldExpr): Implement IVariable.
22418 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22419 VariableInfo for the field.
22421 2003-05-18 Martin Baulig <martin@ximian.com>
22423 * expression.cs (This.DoResolve): Report a CS0027 if we're
22424 emitting a field initializer.
22426 2003-05-18 Martin Baulig <martin@ximian.com>
22428 * expression.cs (This.ResolveBase): New public function.
22429 (This.DoResolve): Check for CS0188.
22431 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22434 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22435 `instance_expression' to null if we don't have any non-static
22438 2003-05-18 Martin Baulig <martin@ximian.com>
22440 Reworked the way how local variables and parameters are handled by
22441 the flow analysis code.
22443 * statement.cs (TypeInfo, VariableMap): New public classes.
22444 (VariableInfo): New public class. This is now responsible for
22445 checking whether a variable has been assigned. It is used for
22446 parameters and local variables.
22447 (Block.EmitMeta): Take the InternalParameters as argument; compute
22448 the layout of the flow vectors here.
22449 (Block.LocalMap, Block.ParameterMap): New public properties.
22450 (FlowBranching): The .ctor doesn't get the InternalParameters
22451 anymore since Block.EmitMeta() now computes the layout of the flow
22453 (MyStructInfo): This class is now known as `StructInfo' and nested
22454 in `TypeInfo'; we don't access this directly anymore.
22456 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22457 property and removed IsAssigned(), IsFieldAssigned(),
22458 SetAssigned() and SetFieldAssigned(); we now call them on the
22459 VariableInfo so we don't need to duplicate this code everywhere.
22461 * expression.cs (ParameterReference): Added `Block block' argument
22463 (LocalVariableReference, ParameterReference, This): The new
22464 VariableInfo class is now responsible for all the definite
22467 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22468 IsParameterAssigned, SetParameterAssigned): Removed.
22470 2003-05-18 Martin Baulig <martin@ximian.com>
22472 * typemanager.cs (InitCoreTypes): Try calling
22473 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22474 the 3-args-version. Corlib now also needs our `void_type'.
22475 (GetMethod): Added overloaded version which takes an optional
22476 `bool report_errors' to allow lookups of optional methods.
22478 2003-05-12 Martin Baulig <martin@ximian.com>
22480 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22481 only used for locals and not for parameters.
22483 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22485 * support.cs (InternalParameters.ParameterType): Return the
22486 ExternalType of the parameter.
22488 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22491 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22493 * class.cs (MethodData.Define): Do not set the `newslot' on
22494 interface members, if they are also flagged as "override".
22496 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22497 better code for ++i and i++. This only works for static fields
22498 and local variables.
22500 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22501 want to pull the DeclSpace out of the builder_to_declspace instead
22502 of the TypeBuilder (like in TypeContainer.FindMembers).
22504 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22505 instead of LookupTypeContainer. Fixes the crash on .NET for
22506 looking up interface members.
22508 * const.cs: Create our own emit context during the Definition
22509 stage, so that constants are evaluated in the proper context, when
22510 a recursive definition happens.
22512 2003-05-11 Martin Baulig <martin@ximian.com>
22514 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22515 new block for a switch section.
22516 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22517 the adding/lookup in the switch block. Fixes #39828.
22519 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22521 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22522 functionality: I needed to convert the data after I had performed
22523 the add/sub operation into the operands type size.
22525 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22526 pass the type for the box operation, otherwise the resulting
22527 object would have been of type object.
22529 (BoxedCast): Add constructor to specify the type to box as.
22531 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22533 * iterators.cs: I was reusing the `count' variable inadvertently,
22534 take steps to not allow this to happen.
22536 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22538 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22539 by creating an array at the point where the params starts and
22540 putting all those arguments there, then adjusting the size of the
22543 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22545 * expression.cs (New.AddressOf): Implement interface
22546 IMemoryLocation. This is used when the `new' operator is used in
22547 the context of an invocation to a method on a value type.
22549 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22552 * namespace.cs: Also check the using aliases here.
22554 * driver.cs: Move the test for using validity after the types have
22555 been entered, so we do a single pass that also includes the using
22558 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22559 in the regular case. CreateSiblingForFinally is doing extra
22562 * attribute.cs (GetAttributeArgumentExpression): Store the result
22563 on an out value, and use the return value to indicate failure
22564 instead of using null (which is a valid return for Constant.GetValue).
22566 * statement.cs: Perform the analysis flow for the increment
22567 portion after the statement, because this will be the real flow of
22568 execution. Fixes #42385
22570 * codegen.cs (EmitContext.EmitArgument,
22571 EmitContext.EmitStoreArgument): New helper functions when the
22572 RemapToProxy flag is set.
22574 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22577 Add support for remapping parameters.
22579 * iterators.cs: Propagate parameter values; Store parameter
22580 values in the proxy classes.
22582 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22584 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22585 need a proxy reference; I do not know what I was thinking
22587 * cs-parser.jay (constructor_initializer): catch another error,
22588 and display nice message.
22590 (field_declaration): catch void field declaration
22591 to flag a better error.
22593 * class.cs (MemberBase.CheckBase): Report an error instead of a
22594 warning if a new protected member is declared in a struct.
22595 (Field.Define): catch the error of readonly/volatile.
22597 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22599 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22600 volatile variable is taken
22602 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22604 * statement.cs (Fixed.Resolve): Report an error if we are not in
22607 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22609 * typemanager.cs: reuse the code that handles type clashes for
22610 delegates and enumerations.
22612 * class.cs (Report28): Always report.
22614 * expression.cs (EncodeAsAttribute): Allow nulls here.
22616 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22618 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22619 the functionality for testing whether an expression is valid for
22620 an attribute here. Also handle the case of arrays of elements
22623 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22624 encoding a linear array into an array of objects that are suitable
22625 to be passed to an CustomAttributeBuilder.
22627 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22629 * ecore.cs: (FieldExpr): Handle field remapping here.
22631 * iteratators.cs: Pass the instance variable (if the method is an
22632 instance method) to the constructors, so we can access the field
22633 variables on the class.
22635 TODO: Test this with structs. I think the THIS variable on
22636 structs might have to be a pointer, and not a refenrece
22638 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22640 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22641 local variables to fields in a proxy class.
22643 * iterators.cs (PopulateProxy): Rename our internal fields to
22645 Create a <THIS> field if we are an instance method, so we can
22646 reference our parent container variables.
22647 (MapVariable): Called back from the EmitContext code to enter a
22648 new variable to field mapping into the proxy class (we just create
22652 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22653 for using the remapped locals to fields.
22655 I placed the code here, because that gives the same semantics to
22656 local variables, and only changes the Emit code.
22658 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22659 statements inside iterators.
22660 (VariableInfo): Add a FieldBuilder for the cases when we are
22661 remapping local variables to fields in a proxy class
22663 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22664 current_block != null.
22666 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22667 not cope with strings, as it has been moved to the
22668 TableSwitchEmit. Fixed bug in switch generation.
22670 * expression.cs (New.DoResolve): Provide more context for the user
22671 when reporting an error.
22673 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22676 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22677 check the permissions for it. Note than in a type-resolution
22678 context the check was already present in DeclSpace.ResolveType,
22679 but was missing from the MemberAccess.
22681 (ArrayCreation.CheckIndices): warn if the user has
22682 more nested levels of expressions, but there are no more
22683 dimensions specified. Avoids crash on bug 41906.
22685 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22687 * statement.cs (Block): replace Implicit bool, for a generic
22689 New flag: `Unchecked'. This is used during the EmitMeta phase
22690 (which is out-of-line with the regular Resolve/Emit process for a
22691 statement, as this is done ahead of time, but still gets a chance
22692 to call constant resolve).
22694 (Block.Flags): new enum for adding a new flag.
22696 (Block.EmitMeta): track the state of unchecked.
22698 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22699 to enable constant resolution to work there as well.
22701 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22703 * typemanager.cs (ienumerable_type): Also look up
22704 System.Collections.IEnumerable.
22706 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22708 TODO: Test more than one conditional per method.
22710 * class.cs (Indexer.Define): Report the location where the user is
22711 referencing the unsupported feature.
22713 (MethodData): Overload the use of `conditionals' to
22714 minimize the creation of needless ArrayLists. This saves roughly
22715 212kb on my machine.
22717 (Method): Implement the new IIteratorContainer interface.
22718 (Method.SetYields): Implement the method by setting the ModFlags
22719 to contain METHOD_YIELDS.
22721 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22722 which just got set to null.
22724 * iterators.cs: New file.
22726 (Yield, YieldBreak): New statements.
22728 * statement.cs (Return.Resolve): Flag an error if we are used in
22729 an iterator method.
22731 * codegen.cs (InIterator): New flag set if the code is being
22732 compiled in an iterator method.
22734 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22735 internal modifier, and we just use it to avoid adding extra
22736 fields, as this is seldom used.
22738 * cs-parser.jay: Add yield_statement (yield and yield break).
22740 * driver.cs: New flag -v2 to turn on version 2 features.
22742 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22743 hashtable when v2 is enabled.
22745 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22747 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22748 there is already a namespace defined with this name.
22750 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22751 people upgraded their corlibs.
22753 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22754 always use fully qualified types, no need to use the compiler
22757 (TypeManager.IsNamespace): Use binarysearch.
22759 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22760 AddDelegate): I did not quite use the new IsValid API properly: I
22761 have to pass the short-name and the fullname. I was passing only
22762 the basename instead of the fullname sometimes.
22764 (TypeContainer.DefineType): call NamespaceClash.
22766 * interface.cs (Interface.DefineType): use NamespaceClash before
22769 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22772 * enum.cs: (Enum.DefineType): use NamespaceClash before
22775 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22776 speed increase. First, use the negative_hits cache when we get a
22777 negative. Second, add the type with its full original name
22778 instead of the new . and + encoded name (reflection uses + to
22779 separate type from a nested type). Use LookupTypeReflection
22780 directly which bypasses the type->name hashtable (that we already
22781 know does not contain the type.
22783 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22784 location/container type.
22786 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22788 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22790 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22792 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22793 method is being referenced in the method group from a static
22794 context, and report error 120 if so.
22796 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22799 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22800 is created, we create the A namespace).
22802 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22805 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22807 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22808 invocation to ModuleBuilder.GetType with the same values will
22809 return a new type instance, so we need to cache its return
22812 * expression.cs (Binary.ResolveOperator): Only allow the compare
22813 operators on enums if they are of the same type.
22815 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22816 types of ValueType on their own case. Before we were giving them
22817 the same treatment as objects.
22819 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22820 fullname. Short name is used to compare against container name.
22821 Fullname is used to check against defined namespace names.
22823 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22824 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22826 (Method.CheckBase): Call parent.
22827 (MemberBase.CheckBase): Check for protected members on sealed
22829 (PropertyBase.CheckBase): Call parent.
22830 (Field.Define): Call parent.
22832 * report.cs: Negative error codes are now mapped to 8000 - code,
22833 so that the display is render more nicely.
22835 * typemanager.cs: Do not use try/catch, instead report a regular
22838 (GetPointerType, GetReferenceType): These methods provide
22839 mechanisms to obtain the T* and T& from a T. We had the code
22840 previously scattered around the code base, and it also used
22841 TypeManager.LookupType that would go through plenty of caches.
22842 This one goes directly to the type source.
22844 In some places we did the Type.GetType followed by
22845 ModuleBuilder.GetType, but not in others, so this unifies the
22846 processing as well.
22848 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22849 statements now that we have namespace information.
22851 * typemanager.cs (IsNamespace): New method, returns whether the
22852 string presented is a namespace or not.
22854 (ComputeNamespaces): New public entry point, computes the list of
22855 available namespaces, using the GetNamespaces API call in Mono, or
22856 the slower version in MS.NET.
22858 Now before we start the semantic analysis phase, we have a
22859 complete list of namespaces including everything that the user has
22862 Deleted old code to cache namespaces in .nsc files.
22864 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22866 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22867 class/struct location definition Location for the implicit
22868 constructor location.
22870 (Operator.Define): Use the location of the operator for the
22871 implicit Method definition.
22873 (Constructor.Emit): use the constructor location for the implicit
22874 base initializer constructor.
22876 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22877 and the Expression class now contains two new methods:
22879 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22880 isolate type lookup from the rest of the resolution process.
22882 Since we use Expressions to hold type definitions due to the way
22883 we parse the input we have historically overloaded Resolve to
22884 perform the Type lookups if a special flag is passed. Now this is
22885 eliminated and two methods take their place.
22887 The differences in the two methods between xStep and xTerminal is
22888 that xStep is involved in our current lookup system that uses
22889 SimpleNames to compose a name, while xTerminal is used just to
22890 catch the case where the simplename lookup failed.
22892 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22894 * expression.cs (ResolveMemberAccess): Remove redundant code.
22895 TypeExpr expressions are always born fully resolved.
22897 * interface.cs (PopulateMethod): Do not lookup the types twice.
22898 We were doing it once during SemanticAnalysis and once during
22901 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22902 in local variable type definitions, were being returned as a
22903 SimpleName (we decomposed everything into a string), that is
22904 because primary_expression was being used instead of a type in the
22905 grammar (reduce/reduce conflicts).
22907 The part that was wrong is that we converted the expression into a
22908 string (an oversimplification in one hand, compounded with primary
22909 expressions doing string concatenation).
22915 Would return "A.B.C[]" as a SimpleName. This stopped things like
22916 using clauses from working on this particular context. And a type
22917 was being matched directly against "A.B.C[]".
22919 We now use the correct approach, and allow for ComposedCast to be
22920 part of the unary expression. So the "A.B.C []" become a composed
22921 cast of "A.B.C" (as a nested group of MemberAccess with a
22922 SimpleName at the end) plus the rank composition "[]".
22926 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22928 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22929 for the access level checking.
22931 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22932 `TypeContainer container', because I kept getting confused when I
22933 was debugging this code.
22935 * expression.cs (Indexers): Instead of tracking getters/setters,
22936 we now track them in parallel. We create one arraylist less, but
22937 most importantly it is possible now for the LValue code to find a
22938 matching get for a set.
22940 (IndexerAccess.DoResolveLValue): Update the code.
22941 GetIndexersForType has been modified already to extract all the
22942 indexers from a type. The code assumed it did not.
22944 Also make the code set the correct return type for the indexer.
22945 This was fixed a long time ago for properties, but was missing for
22946 indexers. It used to be void_type.
22948 (Binary.Emit): Test first for doubles instead of
22949 floats, as they are more common.
22951 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22952 when dealing with floats and the <=, >= operators. This fixes bug
22955 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22956 to load the array value by emitting a load on the foreach variable
22957 type. This was incorrect.
22959 We now emit the code to load an element using the the array
22960 variable type, and then we emit the conversion operator.
22964 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22966 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22968 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22970 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22971 test for protection before we test for signatures.
22973 (MethodSignature.ToString): implement.
22975 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22976 to the case where we reduced into a LongConstant.
22978 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22979 depend on whether the information is acurrate, because the
22980 Microsoft runtime will always claim that the array type is public,
22981 regardless of the real state.
22983 If the type is a pointer, another problem happens: the type is
22984 reported as non-public in Microsoft.
22986 In both cases we have to call CheckAccessLevel recursively with
22987 the underlying type as the argument to be tested.
22989 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22991 * assign.cs (Assign.Emit): If we are dealing with a compound
22992 assignment expression, we should use the code path that stores the
22993 intermediate result in a temporary value. This fixes #40903.
22995 *expression.cs (Indirection.ToString): Provide ToString method for
22998 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
23000 * class.cs: Null out fields holding references to Block objects so
23001 they can be garbage collected.
23003 * expression.cs (OverloadResolve): Remove unused local.
23005 2003-04-07 Martin Baulig <martin@ximian.com>
23007 * codegen.cs (EmitContext.CurrentFile): New public field.
23008 (EmitContext.Mark): Use the CurrentFile to check whether the
23009 location is in the correct file.
23010 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
23012 2003-04-07 Martin Baulig <martin@ximian.com>
23014 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
23016 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
23017 location. [FIXME: The location argument which gets passed to this
23018 method is sometimes wrong!]
23020 2003-04-07 Nick Drochak <ndrochak@gol.com>
23022 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
23024 2003-04-07 Miguel de Icaza <miguel@ximian.com>
23026 * expression.cs (Indirection.EmitAssign): We were using the
23027 temporary, but returning immediately instead of continuing the
23030 2003-04-06 Martin Baulig <martin@ximian.com>
23032 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
23033 if it's a nested child, but also deriving from the outer class.
23036 * typemanager.cs (IsNestedChildOf): Make this work if it's a
23037 nested child, but also deriving from the outer class. See
23039 (FilterWithClosure): We may access private members of the outer
23040 class if we're a nested child and deriving from the outer class.
23041 (RealMemberLookup): Only set `closure_private_ok' if the
23042 `original_bf' contained BindingFlags.NonPublic.
23044 2003-04-05 Martin Baulig <martin@ximian.com>
23046 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
23048 2003-04-02 Miguel de Icaza <miguel@ximian.com>
23050 * class.cs (Event.Define): Do not allow abstract events to have
23053 2003-04-01 Miguel de Icaza <miguel@ximian.com>
23055 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
23056 block in event declarations.
23058 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
23059 value type, get its address.
23061 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
23062 leaving a class on the stack instead of a boolean value (int
23063 0/1). Change the code so we compare against null, and then the
23064 result against zero.
23066 * class.cs (TypeContainer.GetClassBases): We were checking for the
23067 parent class being sealed too late.
23069 * expression.cs (Binary.Emit): For <= and >= when dealing with
23070 floating point values, use cgt.un and clt.un instead of cgt and
23073 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
23075 * statement.cs: Apply the same optimization as MS: skip the
23076 GetEnumerator returning an IEnumerator, and use the one returning a
23077 CharEnumerator instead. This allows us to avoid the try-finally block
23080 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
23082 * cs-parser.jay: Attributes cannot be applied to
23083 namespaces. Fixes #40473
23085 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23088 (Add*): check if the name is valid using the full name for constants,
23089 fields, properties and events.
23091 2003-03-28 Miguel de Icaza <miguel@ximian.com>
23093 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
23094 char constants to be part of the enumeration.
23096 * expression.cs (Conditional.DoResolve): Add support for operator
23097 true. Implements the missing functionality from 14.12
23099 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
23100 operator true/false as required by the spec.
23102 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
23103 implicit conversion to boolean.
23105 * statement.cs (Statement.ResolveBoolean): A boolean expression is
23106 also one where the type implements `operator true'.
23108 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
23109 get an expression that will invoke operator true based on an
23112 (GetConversionOperators): Removed the hack that called op_True
23115 (Expression.ResolveBoolean): Move this from Statement.
23117 2003-03-17 Miguel de Icaza <miguel@ximian.com>
23119 * ecore.cs (FieldExpr): do not allow initialization of initonly
23120 fields on derived classes
23122 2003-03-13 Martin Baulig <martin@ximian.com>
23124 * statement.cs (Block.Emit): Call ig.BeginScope() and
23125 ig.EndScope() when compiling with debugging info; call
23126 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
23128 2003-03-08 Miguel de Icaza <miguel@ximian.com>
23130 * expression.cs (Indexers): Do not construct immediately, allow
23131 for new members to be appended as we go. Fixes 38143
23133 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23135 * expression.cs: save/restore context when resolving an unchecked
23138 2003-03-05 Miguel de Icaza <miguel@ximian.com>
23140 * cfold.cs: Catch division by zero in modulus operator during
23143 2003-03-03 Miguel de Icaza <miguel@ximian.com>
23145 * interface.cs (Interface.DefineMembers): Avoid defining members
23148 2003-02-27 Miguel de Icaza <miguel@ximian.com>
23150 * driver.cs: handle the +/- options for -noconfig
23152 * statement.cs (Unckeched.Resolve): Also track the state of
23153 unchecked in the Resolve phase.
23155 2003-02-27 Martin Baulig <martin@ximian.com>
23157 * ecore.cs (Expression.MemberLookup): Don't create a
23158 MethodGroupExpr for something which is not a method. Fixes #38291.
23160 2003-02-25 Miguel de Icaza <miguel@ximian.com>
23162 * class.cs (MemberBase.CheckParameters): Also check that the type
23163 is unmanaged if it is a pointer.
23165 * expression.cs (SizeOf.Resolve): Add location information.
23167 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
23168 a managed type is declared.
23170 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
23171 parameter modifiers as well. Fixes bug 38606
23173 * class.cs: Very sad. Am backing out the speed up changes
23174 introduced by the ArrayList -> Array in the TypeContainer, as they
23175 were not actually that much faster, and introduced a bug (no error
23176 reports on duplicated methods).
23178 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
23179 source first, this will guarantee that we have a valid expression
23180 before calling in lower levels functions that will require a
23181 resolved object. Then use this original_source in the
23182 target.ResolveLValue instead of the original source that was
23185 Another change. Use target.Resolve instead of LValueResolve.
23186 Although we are resolving for LValues, we will let the Assign code
23187 take care of that (it will be called again from Resolve). This
23188 basically allows code like this:
23190 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
23191 class Y { void A (X x) { x [0] += o; }
23193 The problem was that the indexer was trying to resolve for
23194 set_Item (idx, object o) and never finding one. The real set_Item
23195 was set_Item (idx, X). By delaying the process we get the right
23200 2003-02-23 Martin Baulig <martin@ximian.com>
23202 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
23203 while calling DoEmit ().
23205 * codegen.cs (EmitContext.Mark): Don't mark locations in other
23206 source files; if you use the #line directive inside a method, the
23207 compiler stops emitting line numbers for the debugger until it
23208 reaches the end of the method or another #line directive which
23209 restores the original file.
23211 2003-02-23 Martin Baulig <martin@ximian.com>
23213 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
23215 2003-02-23 Martin Baulig <martin@ximian.com>
23217 * statement.cs (Block.AddChildVariableNames): We need to call this
23218 recursively, not just for our immediate children.
23220 2003-02-23 Martin Baulig <martin@ximian.com>
23222 * class.cs (Event.Define): Always make the field private, like csc does.
23224 * typemanager.cs (TypeManager.RealMemberLookup): Make events
23225 actually work, fixes bug #37521.
23227 2003-02-23 Miguel de Icaza <miguel@ximian.com>
23229 * delegate.cs: When creating the various temporary "Parameters"
23230 classes, make sure that we call the ComputeAndDefineParameterTypes
23231 on those new parameters (just like we do with the formal ones), to
23232 allow them to be resolved in the context of the DeclSpace.
23234 This fixes the bug that Dick observed in Bugzilla #38530.
23236 2003-02-22 Miguel de Icaza <miguel@ximian.com>
23238 * expression.cs (ResolveMemberAccess): When resolving a constant,
23239 do not attempt to pull a constant if the value was not able to
23240 generate a valid constant.
23242 * const.cs (LookupConstantValue): Do not report more errors than required.
23244 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23246 * expression.cs: fixes bug #38328.
23248 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23250 * class.cs: Changed all the various members that can be part of a
23251 class from being an ArrayList to be an Array of the right type.
23252 During the DefineType type_list, interface_list, delegate_list and
23253 enum_list are turned into types, interfaces, delegates and enums
23256 And during the member population, indexer_list, event_list,
23257 constant_list, field_list, instance_constructor_list, method_list,
23258 operator_list and property_list are turned into their real arrays.
23260 Although we could probably perform this operation earlier, for
23261 good error reporting we need to keep the lists and remove the
23262 lists for longer than required.
23264 This optimization was triggered by Paolo profiling the compiler
23265 speed on the output of `gen-sample-program.pl' perl script.
23267 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
23268 not crash in methods like MemberLookupFailed that use this field.
23270 This problem arises when the compiler fails to resolve a type
23271 during interface type definition for example.
23273 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23275 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
23276 inherit from System.Object, so we have to stop at null, not only
23277 when reaching System.Object.
23279 2003-02-17 Miguel de Icaza <miguel@ximian.com>
23281 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
23282 DeclaredOnly because the parent indexer might have had a different
23283 name, but did not loop until the top of the hierarchy was reached.
23285 The problem this one fixes is 35492: when a class implemented an
23286 indexer from an interface, we were getting the interface method
23287 (which was abstract) and we were flagging an error (can not invoke
23290 This also keeps bug 33089 functioning, and test-148 functioning.
23292 * typemanager.cs (IsSpecialMethod): The correct way of figuring
23293 out if a method is special is to see if it is declared in a
23294 property or event, or whether it is one of the predefined operator
23295 names. This should fix correctly #36804.
23297 2003-02-15 Miguel de Icaza <miguel@ximian.com>
23299 The goal here is to remove the dependency on EmptyCast.Peel ().
23300 Killing it completely.
23302 The problem is that currently in a number of places where
23303 constants are expected, we have to "probe" for an EmptyCast, and
23304 Peel, which is not the correct thing to do, as this will be
23305 repetitive and will likely lead to errors.
23307 The idea is to remove any EmptyCasts that are used in casts that
23308 can be reduced to constants, so we only have to cope with
23311 This bug hunt was triggered by Bug 37363 and the desire to remove
23312 the duplicate pattern where we were "peeling" emptycasts to check
23313 whether they were constants. Now constants will always be
23316 * ecore.cs: Use an enumconstant here instead of wrapping with
23319 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
23320 throwing me off. By handling this we can get rid of a few hacks.
23322 * statement.cs (Switch): Removed Peel() code.
23324 2003-02-14 Miguel de Icaza <miguel@ximian.com>
23326 * class.cs: Location information for error 508
23328 * expression.cs (New.DoResolve): Add a guard against double
23329 resolution of an expression.
23331 The New DoResolve might be called twice when initializing field
23332 expressions (see EmitFieldInitializers, the call to
23333 GetInitializerExpression will perform a resolve on the expression,
23334 and later the assign will trigger another resolution
23336 This leads to bugs (#37014)
23338 * delegate.cs: The signature for EndInvoke should contain any ref
23339 or out parameters as well. We were not doing this in the past.
23341 * class.cs (Field.Define): Do not overwrite the type definition
23342 inside the `volatile' group. Turns out that volatile enumerations
23343 were changing the type here to perform a validity test, which
23346 2003-02-12 Miguel de Icaza <miguel@ximian.com>
23348 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
23349 and structs, we do not want to load the instance variable
23351 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
23352 enum_type has to be handled like an object reference (implicit
23353 conversions exists from this to object), but the regular IsClass
23354 and IsValueType tests will never return true for this one.
23356 Also we use TypeManager.IsValueType instead of type.IsValueType,
23357 just for consistency with the rest of the code (this is only
23358 needed if we ever use the construct exposed by test-180.cs inside
23359 corlib, which we dont today).
23361 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23363 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23366 2003-02-09 Martin Baulig <martin@ximian.com>
23368 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23369 (Namespace.DefineNamespaces): New static public method; this is
23370 called when we're compiling with debugging to add all namespaces
23371 to the symbol file.
23373 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23374 pass it to the Namespace's .ctor.
23376 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23377 and MethodBase arguments; pass the namespace ID to the symwriter;
23378 pass the MethodBase instead of the token to the symwriter.
23379 (SymbolWriter.DefineNamespace): New method to add a namespace to
23382 2003-02-09 Martin Baulig <martin@ximian.com>
23384 * symbolwriter.cs: New file. This is a wrapper around
23385 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23386 methods here in near future.
23388 2003-02-09 Martin Baulig <martin@ximian.com>
23390 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23391 ILGenerator.MarkSequencePoint() which are actually used by the
23394 2003-02-09 Martin Baulig <martin@ximian.com>
23396 * location.cs (SourceFile): New public sealed class. This
23397 contains the name and an index which is used in the location's token.
23398 (Location): Reserve an appropriate number of bits in the token for
23399 the source file instead of walking over that list, this gives us a
23400 really huge performance improvement when compiling with debugging.
23402 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23403 `SourceFile' argument instead of a string.
23404 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23405 but don't parse/tokenize here, we need to generate the list of all
23406 source files before we do that.
23407 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23410 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23411 instead of a string.
23413 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23416 2003-02-09 Martin Baulig <martin@ximian.com>
23418 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23419 filename on `#line default'.
23421 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23423 * statement.cs: don't clear the pinned var when the fixed statement
23424 returns from the method (fixes bug#37752).
23426 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23428 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23431 2003-02-07 Martin Baulig <martin@ximian.com>
23433 * driver.cs: Removed the `--debug-args' command line argument.
23435 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23436 automatically by the AsssemblyBuilder.
23437 (CodeGen.InitializeSymbolWriter): We don't need to call any
23438 initialization function on the symbol writer anymore. This method
23439 doesn't take any arguments.
23441 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23443 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23444 from referenced assemblies as well.
23446 2003-02-02 Martin Baulig <martin@ximian.com>
23448 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23450 2003-02-02 Martin Baulig <martin@ximian.com>
23452 * class.cs (Constructor.Emit): Open the symbol writer before
23453 emitting the constructor initializer.
23454 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23455 single-stepping through constructor initializers.
23457 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23459 * class.cs: Handle error 549: do not allow virtual methods in
23462 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23464 * decl.cs: Check access levels when resolving types
23466 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23468 * statement.cs: Add parameters and locals set in catch blocks that might
23469 return to set vector
23471 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23473 * class.cs (Operator): Set the SpecialName flags for operators.
23475 * expression.cs (Invocation.DoResolve): Only block calls to
23476 accessors and operators on SpecialName methods.
23478 (Cast.TryReduce): Handle conversions from char constants.
23481 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23483 * statement.cs: small memory and time optimization in FlowBranching.
23485 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23487 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23488 problem that the last fix but in the other sid (Set).
23490 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23491 access when there is no indexer in the hierarchy.
23493 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23495 * class.cs: Combine some if statements.
23497 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23499 * driver.cs: fixed bug #37187.
23501 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23503 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23504 any indexer, it's needed to build a list with all the indexers in the
23505 hierarchy (AllGetters), else we have problems. Fixes #35653.
23507 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23509 * class.cs (MethodData.Define): It is wrong for an interface
23510 implementation to be static in both cases: explicit and implicit.
23511 We were only handling this in one case.
23513 Improve the if situation there to not have negations.
23515 * class.cs (Field.Define): Turns out that we do not need to check
23516 the unsafe bit on field definition, only on usage. Remove the test.
23518 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23520 * driver.cs: use assembly.Location instead of Codebase (the latest
23521 patch made mcs fail when using MS assemblies).
23523 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23525 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23526 get the path to *corlib.dll.
23528 2003-01-21 Nick Drochak <ndrochak@gol.com>
23532 * typemanager.cs: Remove compiler warnings
23534 2003-01-20 Duncan Mak <duncan@ximian.com>
23536 * AssemblyInfo.cs: Bump the version number to 0.19.
23538 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23540 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23542 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23544 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23546 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23548 * cs-parser.jay: Small fix: we were not comparing the constructor
23549 name correctly. Thanks to Zoltan for the initial pointer.
23551 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23553 * cs-tokenizer.cs: Set file name when specified with #line
23555 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23557 * cs-parser.jay: Only perform the constructor checks here if we
23558 are named like the class; This will help provider a better
23559 error. The constructor path is taken when a type definition is
23560 not found, but most likely the user forgot to add the type, so
23561 report that rather than the constructor error.
23563 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23565 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23568 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23570 * cs-parser.jay: Add cleanup call.
23572 2003-01-13 Duncan Mak <duncan@ximian.com>
23574 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23575 consistent with other methods.
23577 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23579 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23581 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23583 * attribute.cs: only set GuidAttr to true when we have a
23586 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23590 * typemanager.cs: fixes to allow mcs compile corlib with the new
23591 Type.IsSubclassOf fix.
23593 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23595 * expression.cs (LocalVariableReference.DoResolve): Classify a
23596 constant as a value, not as a variable. Also, set the type for
23599 * cs-parser.jay (fixed_statement): take a type instead of a
23600 pointer_type, so we can produce a better error message later.
23602 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23605 (For.DoEmit): Make inifinite loops have a
23606 non-conditional branch back.
23608 (Fixed.DoEmit): First populate the pinned variables, then emit the
23609 statement, then clear the variables. Before I was emitting the
23610 code once for each fixed piece.
23613 2003-01-08 Martin Baulig <martin@ximian.com>
23615 * statement.cs (FlowBranching.MergeChild): A break in a
23616 SWITCH_SECTION does not leave a loop. Fixes #36155.
23618 2003-01-08 Martin Baulig <martin@ximian.com>
23620 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23621 lives in the same number space than `param_map'. Fixes #36154.
23623 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23625 * cs-parser.jay (constructor_declaration): Set the
23626 Constructor.ModFlags before probing for it. This makes the
23627 compiler report 514, 515 and 132 (the code was there, but got
23630 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23631 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23632 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23634 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23636 * enum.cs: create the enum static fields using the enum type.
23638 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23640 * class.cs: don't try to create the ParamBuilder for the return
23641 type if it's not needed (and handle it breaking for the ms runtime
23644 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23646 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23648 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23650 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23651 the command. This showed up while compiling the JANET source
23652 code, which used \r as its only newline separator.
23654 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23656 * class.cs (Method.Define): If we are an operator (because it
23657 reuses our code), then set the SpecialName and HideBySig. #36128
23659 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23661 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23662 exception, report error 120 `object reference required'.
23664 * driver.cs: Add --pause option, used during to measure the size
23665 of the process as it goes with --timestamp.
23667 * expression.cs (Invocation.DoResolve): Do not allow methods with
23668 SpecialName to be invoked.
23670 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23672 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23673 number before adding it.
23675 2002-12-21 Ravi Pratap <ravi@ximian.com>
23677 * ecore.cs (StandardImplicitConversion): When in an unsafe
23678 context, we allow conversion between void * to any other pointer
23679 type. This fixes bug #35973.
23681 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23683 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23684 is not thrown when extensionless outputs are used
23686 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23688 * rootcontext.cs: fixed compilation of corlib.
23690 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23692 * attribute.cs (Attributes.Contains): Add new method.
23694 * class.cs (MethodCore.LabelParameters): if the parameter is an
23695 `out' parameter, check that no attribute `[In]' has been passed.
23697 * enum.cs: Handle the `value__' name in an enumeration.
23699 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23701 * decl.cs: Added special case to allow overrides on "protected
23704 2002-12-18 Ravi Pratap <ravi@ximian.com>
23706 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23707 since it makes much more sense.
23709 (Attributes.ctor): Don't require a Location parameter.
23711 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23713 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23714 since we already have that information per attribute.
23716 * everywhere : make appropriate changes.
23718 * class.cs (LabelParameters): Write the code which actually
23719 applies attributes to the return type. We can't do this on the MS
23720 .NET runtime so we flag a warning in the case an exception is
23723 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23725 * const.cs: Handle implicit null conversions here too.
23727 2002-12-17 Ravi Pratap <ravi@ximian.com>
23729 * class.cs (MethodCore.LabelParameters): Remove the extra
23730 Type [] parameter since it is completely unnecessary. Instead
23731 pass in the method's attributes so that we can extract
23732 the "return" attribute.
23734 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23736 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23737 of ignoring it and letting the compile continue.
23739 * typemanager.cs (ChangeType): use an extra argument to return an
23740 error condition instead of throwing an exception.
23742 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23744 * expression.cs (Unary.TryReduce): mimic the code for the regular
23745 code path. Perform an implicit cast in the cases where we can
23746 implicitly convert to one of the integral types, and then reduce
23747 based on that constant. This fixes bug #35483.
23749 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23751 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23753 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23755 * namespace.cs: fixed bug #35489.
23757 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23759 * class.cs: Remove some dead code.
23761 * cs-parser.jay: Estimate the number of methods needed
23762 (RootContext.MethodCount);
23764 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23765 numbers instead of StringBuilders.
23767 * support.cs (PtrHashtable): Add constructor with initial size;
23768 We can now reduce reallocations of the method table.
23770 2002-12-10 Ravi Pratap <ravi@ximian.com>
23772 * attribute.cs (ApplyAttributes): Keep track of the emitted
23773 attributes on a per-target basis. This fixes bug #35413.
23775 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23777 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23778 default to the Windows 1252 encoding.
23780 (UnixParseOption): Support version, thanks to Alp for the missing
23783 * AssemblyInfo.cs: Add nice assembly information.
23785 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23788 * cs-parser.jay: Allow a trailing comma before the close bracked
23789 in the attribute_section production.
23791 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23792 address of the instance was being taken, I will take this out,
23793 because we take the address of the object immediately here.
23795 2002-12-09 Ravi Pratap <ravi@ximian.com>
23797 * typemanager.cs (AreMultipleAllowed): Take care of the most
23798 obvious case where attribute type is not in the current assembly -
23801 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23803 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23804 definitions, instead of doing that afterwards.
23806 Also we use a nice little hack, depending on the constructor, we
23807 know if we are a "composed" name or a simple name. Hence, we
23808 avoid the IndexOf test, and we avoid
23810 * codegen.cs: Add code to assist in a bug reporter to track down
23811 the source of a compiler crash.
23813 2002-12-07 Ravi Pratap <ravi@ximian.com>
23815 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23816 types have been emitted for a given element and flag an error
23817 if something which does not have AllowMultiple set is used more
23820 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23821 attribute types and their corresponding AllowMultiple properties
23823 (AreMultipleAllowed): Check the property for a given type.
23825 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23826 property in the case we have a TypeContainer.
23828 (Attributes.AddAttribute): Detect duplicates and just skip on
23829 adding them. This trivial fix catches a pretty gross error in our
23830 attribute emission - global attributes were being emitted twice!
23832 Bugzilla bug #33187 is now fixed.
23834 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23836 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23837 instead of pp_and).
23839 * expression.cs (Binary.ResolveOperator): I can only use the
23840 Concat (string, string, string) and Concat (string, string,
23841 string, string) if the child is actually a concatenation of
23844 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23846 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23847 context where we need a 2-character lookahead.
23849 * pending.cs (PendingImplementation): Rework so we can keep track
23850 of interface types all the time, and flag those which were
23851 implemented by parents as optional.
23853 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23855 * expression.cs (Binary.ResolveOperator): Use
23856 String.Concat(string,string,string) or
23857 String.Concat(string,string,string,string) when possible.
23859 * typemanager: More helper methods.
23862 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23864 * pending.cs: remove the bogus return from GetMissingInterfaces()
23865 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23867 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23869 * namespace.cs: avoid duplicated 'using xxx' being added to
23870 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23871 when we get more than one 'using' statement for the same namespace.
23872 Report a CS0105 warning for it.
23874 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23876 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23877 of calling getChar/putback, uses internal knowledge of it.
23879 (xtoken): Reorder tokenizer so most common patterns are checked
23880 first. This reduces the compilation time in another 5% (from 8.11s
23881 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23883 The parsing time is 22% of the compilation in mcs, and from that
23884 64% is spent on the tokenization process.
23886 I tried using a binary search for keywords, but this is slower
23887 than the hashtable. Another option would be to do a couple of
23890 * Not use a StringBuilder, instead use an array of chars,
23891 with a set value. Notice that this way we could catch
23892 the 645 error without having to do it *afterwards*.
23894 * We could write a hand-parser to avoid the hashtable
23895 compares altogether.
23897 The identifier consumption process takes 37% of the tokenization
23898 time. Another 15% is spent on is_number. 56% of the time spent
23899 on is_number is spent on Int64.Parse:
23901 * We could probably choose based on the string length to
23902 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23905 Another 3% is spend on wrapping `xtoken' in the `token' function.
23907 Handle 0xa0 as whitespace (#34752)
23909 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23911 * typemanager.cs (IsCLRType): New routine to tell whether a type
23912 is one of the builtin types.
23914 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23915 typecode in more places instead of doing pointer comparissions.
23916 We could leverage some knowledge about the way the typecodes are
23919 New code to cache namespaces in assemblies, it is currently not
23920 invoked, to be used soon.
23922 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23924 * expression.cs (Binary.ResolveOperator): specially handle
23925 strings, and do not perform user-defined operator overloading for
23928 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23930 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23931 internalcall as it is a pretty simple operation; Avoid whenever
23932 possible to call Char.IsLetter.
23934 (consume_identifier): Cut by half the number of
23935 hashtable calls by merging the is_keyword and GetKeyword behavior.
23937 Do not short-circuit, because if we do, we
23938 report errors (ie, #if false && true would produce an invalid
23942 2002-11-24 Martin Baulig <martin@ximian.com>
23944 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23945 check constant ranges and report a CS0221. Fixes #33186.
23947 2002-11-24 Martin Baulig <martin@ximian.com>
23949 * cs-parser.jay: Make this work for uninitialized variable
23950 declarations in the `for' initializer. Fixes #32416.
23952 2002-11-24 Martin Baulig <martin@ximian.com>
23954 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23955 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23957 2002-11-24 Martin Baulig <martin@ximian.com>
23959 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23960 argument; if true, we also check for user-defined conversions.
23961 This is only needed if both arguments are of a user-defined type.
23962 Fixes #30443, added test-175.cs.
23963 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23965 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23967 2002-11-24 Martin Baulig <martin@ximian.com>
23969 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23970 function to get the store opcode.
23971 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23972 only emit the Ldelema if the store opcode is Stobj. You must run
23973 both test-34 and test-167 to test this. Fixes #34529.
23975 2002-11-23 Martin Baulig <martin@ximian.com>
23977 * ecore.cs (Expression.MemberLookup): Added additional
23978 `qualifier_type' argument which is used when we're being called
23979 from MemberAccess.DoResolve() and null if we're called from a
23981 (Expression.MemberLookupFailed): New method to report errors; this
23982 does the CS1540 check and reports the correct error message.
23984 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23985 argument for the CS1540 check and redone the way how we're dealing
23986 with private members. See the comment in the source code for details.
23987 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23988 `closure_start_type' to `closure_qualifier_type' and check whether
23989 it's not null. It was not this filter being broken, it was just
23990 being called with the wrong arguments.
23992 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23993 and pass it the correct `qualifier_type'; this also does the error
23996 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23998 * expression.cs (Invocation.EmitParams): If the we are dealing
23999 with a non-built-in value type, load its address as well.
24001 (ArrayCreation): Use a a pretty constant instead
24002 of the hardcoded value 2. Use 6 instead of 2 for the number of
24003 static initializers.
24005 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
24006 because they are not really value types, just glorified integers.
24008 * driver.cs: Do not append .exe, the CSC compiler does not do it.
24010 * ecore.cs: Remove redundant code for enumerations, make them use
24011 the same code path as everything else, fixes the casting issue
24012 with enumerations in Windows.Forms.
24014 * attribute.cs: Do only cast to string if it is a string, the
24015 validation happens later.
24017 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
24018 people upgrade their corlibs.
24020 * ecore.cs: Oops, enumerations were not following the entire code path
24022 2002-11-21 Miguel de Icaza <miguel@ximian.com>
24024 * typemanager.cs (FilterWithClosure): Commented out the test for
24025 1540 in typemanager.cs, as it has problems when accessing
24026 protected methods from a parent class (see test-174.cs).
24028 * attribute.cs (Attribute.ValidateGuid): new method.
24029 (Attribute.Resolve): Use above.
24031 2002-11-19 Miguel de Icaza <miguel@ximian.com>
24033 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
24035 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
24036 handling for enumerations, as we only needed the TypeContainer
24037 functionality to begin with (this is required for the fix below to
24038 work for enums that reference constants in a container class for
24041 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
24043 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
24044 a valid TypeBuilder to perform lookups on.o
24046 * class.cs (InheritableMemberSignatureCompare): Use true in the
24047 call to GetGetMethod and GetSetMethod, because we are comparing
24048 the signature, and we need to get the methods *even* if they are
24051 (PropertyBase.CheckBase): ditto.
24053 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
24054 GotoCase.Resolve): Use Peel on EmpytCasts.
24056 * ecore.cs (EmptyCast): drop child, add Peel method.
24058 2002-11-17 Martin Baulig <martin@ximian.com>
24060 * ecore.cs (EmptyCast.Child): New public property.
24062 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
24063 label resolved to an EmptyCast. Fixes #34162.
24064 (GotoCase.Resolve): Likewise.
24065 (Block.EmitMeta): Likewise.
24067 2002-11-17 Martin Baulig <martin@ximian.com>
24069 * expression.cs (Invocation.BetterConversion): Prefer int over
24070 uint; short over ushort; long over ulong for integer literals.
24071 Use ImplicitConversionExists instead of StandardConversionExists
24072 since we also need to check for user-defined implicit conversions.
24073 Fixes #34165. Added test-173.cs.
24075 2002-11-16 Martin Baulig <martin@ximian.com>
24077 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
24078 with the `true' and `false' literals. Fixes #33151.
24080 2002-11-16 Martin Baulig <martin@ximian.com>
24082 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
24083 October 22nd; don't do the cs1540 check for static members.
24085 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
24086 now using our own filter here and doing the cs1540 check again.
24088 2002-11-16 Martin Baulig <martin@ximian.com>
24090 * support.cs (InternalParameters): Don't crash if we don't have
24091 any fixed parameters. Fixes #33532.
24093 2002-11-16 Martin Baulig <martin@ximian.com>
24095 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
24096 when looking up static methods to make this work on Windows.
24099 2002-11-16 Martin Baulig <martin@ximian.com>
24101 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
24102 a setter rather than using PropertyInfo.CanWrite.
24104 2002-11-15 Nick Drochak <ndrochak@gol.com>
24106 * class.cs: Allow acces to block member by subclasses. Fixes build
24109 2002-11-14 Martin Baulig <martin@ximian.com>
24111 * class.cs (Constructor.Emit): Added the extern/block check.
24114 2002-11-14 Martin Baulig <martin@ximian.com>
24116 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
24117 iteration while looking for indexers, this is needed because the
24118 indexer may have a different name in our base classes. Fixed the
24119 error reporting (no indexers at all, not get accessor, no
24120 overloaded match). Fixes bug #33089.
24121 (IndexerAccess.DoResolveLValue): Likewise.
24123 2002-11-14 Martin Baulig <martin@ximian.com>
24125 * class.cs (PropertyBase.CheckBase): Make this work for multiple
24126 indexers. Fixes the first part of bug #33089.
24127 (MethodSignature.InheritableMemberSignatureCompare): Added support
24130 2002-11-13 Ravi Pratap <ravi@ximian.com>
24132 * attribute.cs (Attribute.Resolve): Catch the
24133 NullReferenceException and report it since it isn't supposed to
24136 2002-11-12 Miguel de Icaza <miguel@ximian.com>
24138 * expression.cs (Binary.EmitBranchable): Also handle the cases for
24139 LogicalOr and LogicalAnd that can benefit from recursively
24140 handling EmitBranchable. The code now should be nice for Paolo.
24142 2002-11-08 Miguel de Icaza <miguel@ximian.com>
24144 * typemanager.cs (LookupType): Added a negative-hit hashtable for
24145 the Type lookups, as we perform quite a number of lookups on
24146 non-Types. This can be removed once we can deterministically tell
24147 whether we have a type or a namespace in advance.
24149 But this might require special hacks from our corlib.
24153 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
24154 and double which avoids a conversion from an integer to a double.
24156 * expression.cs: tiny optimization, avoid calling IsConstant,
24157 because it effectively performs the lookup twice.
24159 2002-11-06 Miguel de Icaza <miguel@ximian.com>
24161 But a bogus return here to keep the semantics of the old code
24162 until the Mono runtime is fixed.
24164 * pending.cs (GetMissingInterfaces): New method used to remove all
24165 the interfaces that are already implemented by our parent
24166 classes from the list of pending methods.
24168 * interface.cs: Add checks for calls after ResolveTypeExpr.
24170 2002-11-05 Miguel de Icaza <miguel@ximian.com>
24172 * class.cs (Class.Emit): Report warning 67: event not used if the
24173 warning level is beyond 3.
24175 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
24176 being a NullLiteral.
24178 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
24181 * class.cs (TypeContainer.GetClassBases): Cover a missing code
24182 path that might fail if a type can not be resolved.
24184 * expression.cs (Binary.Emit): Emit unsigned versions of the
24187 * driver.cs: use error 5.
24189 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
24191 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
24193 2002-11-01 Miguel de Icaza <miguel@ximian.com>
24195 * cs-parser.jay (switch_section): A beautiful patch from Martin
24196 Baulig that fixed 33094.
24198 2002-10-31 Miguel de Icaza <miguel@ximian.com>
24200 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
24201 Check whether the base is abstract and report an error if so.
24203 * expression.cs (IndexerAccess.DoResolveLValue,
24204 IndexerAccess.DoResolve): ditto.
24206 (Invocation.DoResolve): ditto.
24208 (Invocation.FullMethodDesc): Improve the report string.
24210 * statement.cs (Block): Eliminate IsVariableDefined as it is
24211 basically just a wrapper for GetVariableInfo.
24213 * ecore.cs (SimpleName): Use new
24215 * support.cs (ReflectionParamter.ParameterType): We unwrap the
24216 type, as we return the actual parameter ref/unref state on a
24219 2002-10-30 Miguel de Icaza <miguel@ximian.com>
24221 * support.cs: Return proper flags REF/OUT fixing the previous
24224 * expression.cs: Reverted last patch, that was wrong. Is_ref is
24225 not used to mean `ref' but `ref or out' in ParameterReference
24227 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
24228 full type signature instead of calling TypeManger.CSharpName
24231 * support.cs (InternalParameters.ParameterDesc): Do not compare
24232 directly to the modflags, because REF/OUT will actually be bitsets
24235 * delegate.cs (VerifyMethod): Check also the modifiers.
24237 * cs-tokenizer.cs: Fix bug where floating point values with an
24238 exponent where a sign was missing was ignored.
24240 * driver.cs: Allow multiple assemblies to be specified in a single
24243 2002-10-28 Miguel de Icaza <miguel@ximian.com>
24245 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
24246 because identifiers after a parenthesis would end up in this kind
24247 of production, and we needed to desamiguate it for having casts
24250 (UserDefinedType *) xxx
24252 2002-10-24 Miguel de Icaza <miguel@ximian.com>
24254 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
24255 we should set on the Bindingflags.NonPublic, but not turn on
24256 private_ok. private_ok controls whether a Private member is
24257 returned (this is chekced on the filter routine), while the
24258 BindingFlags.NonPublic just controls whether private/protected
24259 will be allowed. This fixes the problem part of the problem of
24260 private properties being allowed to be used in derived classes.
24262 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
24263 so we can call the children DoResolveLValue method (this will
24264 properly signal errors on lvalue assignments to base properties)
24266 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
24267 getter are null, and we have a property info, we know that this
24268 happened because the lookup failed, so we report an error 122 for
24269 protection level violation.
24271 We also silently return if setter and getter are null in the
24272 resolve functions, this condition only happens if we have flagged
24273 the error before. This is the other half of the problem.
24275 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
24276 not have accessibility information, that is why we were returning
24277 true in the filter function in typemanager.cs.
24279 To properly report 122 (property is inaccessible because of its
24280 protection level) correctly, we report this error in ResolveAccess
24281 by failing if both the setter and the getter are lacking (ie, the
24284 DoResolve and DoLResolve have been modified to check for both
24285 setter/getter being null and returning silently, the reason being
24286 that I did not want to put the knowledge about this error in upper
24289 int old = Report.Errors;
24290 x = new PropertyExpr (...);
24291 if (old != Report.Errors)
24296 So the property expr is returned, but it is invalid, so the error
24297 will be flagged during the resolve process.
24299 * class.cs: Remove InheritablePropertySignatureCompare from the
24300 class, as we no longer depend on the property signature to compute
24301 whether it is possible to implement a method or not.
24303 The reason is that calling PropertyInfo.GetGetMethod will return
24304 null (in .NET, in Mono it works, and we should change this), in
24305 cases where the Get Method does not exist in that particular
24310 class X { public virtual int A { get { return 1; } } }
24312 class Z : Y { public override int A { get { return 2; } } }
24314 Would fail in Z because the parent (Y) would not have the property
24315 defined. So we avoid this completely now (because the alternative
24316 fix was ugly and slow), and we now depend exclusively on the
24319 (PropertyBase.CheckBase): Use a method-base mechanism to find our
24320 reference method, instead of using the property.
24322 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
24323 routines are gone now.
24325 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
24326 names, they were incorrectly named.
24328 * cs-tokenizer.cs: Return are more gentle token on failure.
24330 * pending.cs (PendingImplementation.InterfaceMethod): This routine
24331 had an out-of-sync index variable, which caused it to remove from
24332 the list of pending methods the wrong method sometimes.
24334 2002-10-22 Miguel de Icaza <miguel@ximian.com>
24336 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
24337 CanWrite, because those refer to this particular instance of the
24338 property, and do not take into account the fact that we can
24339 override single members of a property.
24341 Constructor requires an EmitContext. The resolution process does
24342 not happen here, but we need to compute the accessors before,
24343 because the resolution does not always happen for properties.
24345 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
24346 subclass, before we did not update this flag, but we did update
24349 (GetAccessors): Drop this routine, as it did not work in the
24350 presence of partially overwritten set/get methods.
24352 Notice that this broke the cs1540 detection, but that will require
24355 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24359 * driver.cs: issue a warning instead of an error if we don't support
24360 debugging for the platform. Also ignore a couple of errors that may
24361 arise when trying to write the symbols. Undo my previous patch.
24363 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24365 * driver.cs: ignore /debug switch except for Unix platforms.
24367 2002-10-23 Nick Drochak <ndrochak@gol.com>
24369 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24371 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24373 * driver.cs: Do not make mcs-debug conditional, so we do not break
24374 builds that use it.
24376 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24377 review this patch. But basically after all the children variables
24378 have been merged, the value of "Breaks" was not being set to
24379 new_breaks for Switch blocks. I think that it should be set after
24380 it has executed. Currently I set this to the value of new_breaks,
24381 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24382 conservative, but I do not understand this code very well.
24384 I did not break anything in the build, so that is good ;-)
24386 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24388 2002-10-20 Mark Crichton <crichton@gimp.org>
24390 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24392 2002-10-20 Nick Drochak <ndrochak@gol.com>
24394 * cfold.cs: Fixed compile blocker.
24396 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24398 * driver.cs: I was chekcing the key, not the file.
24400 2002-10-19 Ravi Pratap <ravi@ximian.com>
24402 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24403 message that we were generating - we just need to silently return
24406 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24408 * class.cs (Event.Define): Change my previous commit, as this
24409 breaks the debugger. This is a temporary hack, as it seems like
24410 the compiler is generating events incorrectly to begin with.
24412 * expression.cs (Binary.ResolveOperator): Added support for
24413 "U operator - (E x, E y)"
24415 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24418 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24419 init-only variables, but this path did not take into account that
24420 there might be also instance readonly variables. Correct this
24423 This fixes bug 32253
24425 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24428 * driver.cs: Change the extension for modules to `netmodule'
24430 * cs-parser.jay: Improved slightly the location tracking for
24431 the debugger symbols.
24433 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24434 modifiers that were specified instead of the hardcoded value
24435 (FamAndAssem). This was basically ignoring the static modifier,
24436 and others. Fixes 32429.
24438 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24439 fixed a bug in the process (32476)
24441 * expression.cs (ArrayAccess.EmitAssign): Patch from
24442 hwang_rob@yahoo.ca that fixes bug 31834.3
24444 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24446 * driver.cs: Make the module extension .netmodule.
24448 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24450 * driver.cs: Report an error if the resource file is not found
24451 instead of crashing.
24453 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24454 false, like Emit does.
24456 2002-10-16 Nick Drochak <ndrochak@gol.com>
24458 * typemanager.cs: Remove unused private member. Also reported mcs
24459 bug to report this as a warning like csc.
24461 2002-10-15 Martin Baulig <martin@gnome.org>
24463 * statement.cs (Statement.Emit): Made this a virtual method; emits
24464 the line number info and calls DoEmit().
24465 (Statement.DoEmit): New protected abstract method, formerly knows
24466 as Statement.Emit().
24468 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24470 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24472 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24473 have fixed a remaining problem: not every AddXXXX was adding a
24474 fully qualified name.
24476 Now everyone registers a fully qualified name in the DeclSpace as
24477 being defined instead of the partial name.
24479 Downsides: we are slower than we need to be due to the excess
24480 copies and the names being registered this way.
24482 The reason for this is that we currently depend (on the corlib
24483 bootstrap for instance) that types are fully qualified, because
24484 we dump all the types in the namespace, and we should really have
24485 types inserted into the proper namespace, so we can only store the
24486 basenames in the defined_names array.
24488 2002-10-10 Martin Baulig <martin@gnome.org>
24490 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24491 from bug #31834, see the bug report for a testcase which is
24494 2002-10-10 Martin Baulig <martin@gnome.org>
24496 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24497 flow analysis code for this.
24499 * statement.cs (Do, While, For): Tell the flow analysis code about
24501 (FlowBranching.UsageVector): Added support for infinite loops.
24502 (Block.Resolve): Moved the dead code elimination here and use flow
24505 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24507 * class.cs (Field.Define): Catch cycles on struct type
24510 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24511 fields if the fields are static. We only need to check instance
24514 * expression.cs (As.DoResolve): Test for reference type.
24516 * statement.cs (Using.ResolveExpression): Use
24517 ConvertImplicitRequired, not ConvertImplicit which reports an
24519 (Using.ResolveLocalVariableDecls): ditto.
24521 * expression.cs (Binary.ResolveOperator): Report errors in a few
24522 places where we had to.
24524 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24526 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24528 * expression.cs: Use StoreFromPtr instead of extracting the type
24529 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24531 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24532 an enumeration value to a System.Enum, but System.Enum is not a
24533 value type, but an class type, so we need to box.
24535 (Expression.ConvertExplicit): One codepath could return
24536 errors but not flag them. Fix this. Fixes #31853
24538 * parameter.cs (Resolve): Do not allow void as a parameter type.
24540 2002-10-06 Martin Baulig <martin@gnome.org>
24542 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24543 if it's a class type and not a struct. Fixes #31815.
24545 2002-10-06 Martin Baulig <martin@gnome.org>
24547 * statement.cs: Reworked the flow analysis code a bit to make it
24548 usable for dead code elimination.
24550 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24552 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24554 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24556 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24557 to fix the test 165, will investigate deeper.
24559 2002-10-04 Martin Baulig <martin@gnome.org>
24561 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24562 finally blocks actually work.
24563 (Try.Resolve): We don't need to create a sibling for `finally' if
24564 there is no finally block.
24566 2002-10-04 Martin Baulig <martin@gnome.org>
24568 * class.cs (Constructor.Define): The default accessibility for a
24569 non-default constructor is private, not public.
24571 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24573 * class.cs (Constructor): Make AllowedModifiers public, add
24576 * cs-parser.jay: Perform the modifiers test here, as the
24577 constructor for the Constructor class usually receives a zero
24578 because of the way we create it (first we create, later we
24579 customize, and we were never checking the modifiers).
24581 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24582 is a version of LookupTypeReflection that includes the type-name
24583 cache. This can be used as a fast path for functions that know
24584 the fully qualified name and are only calling into *.GetType() to
24585 obtain a composed type.
24587 This is also used by TypeManager.LookupType during its type
24590 (LookupType): We now also track the real type name, as sometimes
24591 we can get a quey for the real type name from things like
24592 ComposedCast. This fixes bug 31422.
24594 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24595 complete type fullname, it does not have to go through the type
24596 resolution system to obtain the composed version of the type (for
24597 obtaining arrays or pointers).
24599 (Conditional.Emit): Use the EmitBoolExpression to
24600 generate nicer code, as requested by Paolo.
24602 (ArrayCreation.CheckIndices): Use the patch from
24603 hwang_rob@yahoo.ca to validate the array initializers.
24605 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24607 * class.cs (ConstructorInitializer.Emit): simplify code by using
24608 Invocation.EmitCall, and at the same time, fix the bugs in calling
24609 parent constructors that took variable arguments.
24611 * ecore.cs (Expression.ConvertNumericExplicit,
24612 Expression.ImplicitNumericConversion): Remove the code that
24613 manually wrapped decimal (InternalTypeConstructor call is now gone
24616 * expression.cs (Cast.TryReduce): Also handle decimal types when
24617 trying to perform a constant fold on the type.
24619 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24621 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24622 that only turned off an error report, and did nothing else.
24624 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24626 * driver.cs: Handle and ignore /fullpaths
24628 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24630 * expression.cs (Binary.ResolveOperator): Catch the case where
24631 DoNumericPromotions returns true,
24633 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24635 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24637 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24640 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24642 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24643 conversion exists, but it is also required that the conversion be
24644 performed. This manifested in "(Type64Enum) 2".
24646 * class.cs (TypeManager.AddMethod): The fix is not to change
24647 AddEnum, because that one was using a fully qualified name (every
24648 DeclSpace derivative does), but to change the AddMethod routine
24649 that was using an un-namespaced name. This now correctly reports
24650 the duplicated name.
24652 Revert patch until I can properly fix it. The issue
24653 is that we have a shared Type space across all namespaces
24654 currently, which is wrong.
24656 Options include making the Namespace a DeclSpace, and merge
24657 current_namespace/current_container in the parser.
24659 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24661 * cs-parser.jay: Improve error reporting when we get a different
24662 kind of expression in local_variable_type and
24663 local_variable_pointer_type.
24665 Propagate this to avoid missleading errors being reported.
24667 * ecore.cs (ImplicitReferenceConversion): treat
24668 TypeManager.value_type as a target just like object_type. As
24673 Is valid, and needs to result in the int 1 being boxed before it
24674 is assigned to the value type v.
24676 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24677 to validate the enumeration name.
24679 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24680 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24681 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24683 * ecore.cs (TryImplicitIntConversion): When doing an
24684 implicit-enumeration-conversion, check if the type is 64-bits and
24685 perform a conversion before passing to EnumConstant.
24687 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24689 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24690 report ambiguous type references. Unlike the MS version, we
24691 report what the ambiguity is. Innovation at work ;-)
24693 (DeclSpace.FindType): Require a location argument to
24694 display when we display an ambiguous error.
24696 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24698 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24700 * expression.cs (EmitDynamicInitializers): Apply patch from
24701 hwang_rob@yahoo.ca that fixes the order in which we emit our
24704 2002-09-21 Martin Baulig <martin@gnome.org>
24706 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24707 delegate takes no arguments.
24709 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24711 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24714 * expression.cs: Extract the underlying type.
24716 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24718 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24720 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24722 * class.cs (TypeContainer.DefineType): We can not use the nice
24723 PackingSize with the size set to 1 DefineType method, because it
24724 will not allow us to define the interfaces that the struct
24727 This completes the fixing of bug 27287
24729 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24730 means also structs. This fixes part of the problem.
24731 (Expresion.ImplicitReferenceConversionExists): ditto.
24733 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24734 error if there were no errors reported during the type lookup
24735 process, to avoid duplicates or redundant errors. Without this
24736 you would get an ambiguous errors plus a type not found. We have
24737 beaten the user enough with the first error.
24739 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24742 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24743 during the resolution process, stop the lookup, this avoids
24744 repeated error reports (same error twice).
24746 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24748 * typemanager.cs (LookupType): Redo the type lookup code to match
24749 the needs of System.Reflection.
24751 The issue is that System.Reflection requires references to nested
24752 types to begin with a "+" sign instead of a dot. So toplevel
24753 types look like: "NameSpace.TopLevelClass", and nested ones look
24754 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24757 2002-09-19 Martin Baulig <martin@gnome.org>
24759 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24760 says that a method always returns or always throws an exception,
24761 don't report the CS0161.
24763 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24764 set `Returns = new_returns'.
24766 2002-09-19 Martin Baulig <martin@gnome.org>
24768 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24769 to an enum constant, check for a CS0176.
24771 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24773 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24774 for operators that must be in pairs and report errors.
24776 * ecore.cs (SimpleName.DoResolveType): During the initial type
24777 resolution process, when we define types recursively, we must
24778 check first for types in our current scope before we perform
24779 lookups in the enclosing scopes.
24781 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24783 (Invocation.VerifyArgumentsCompat): Call
24784 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24785 I thought we were supposed to always call this, but there are a
24786 few places in the code where we dont do it.
24788 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24790 * driver.cs: Add support in -linkres and -resource to specify the
24791 name of the identifier.
24793 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24795 * ecore.cs (StandardConversionExists): Sync with the conversion
24796 code: allow anything-* to void* conversions.
24798 (FindMostSpecificSource): Use an Expression argument
24799 instead of a Type, because we might be handed over a Literal which
24800 gets a few more implicit conversions that plain types do not. So
24801 this information was being lost.
24803 Also, we drop the temporary type-holder expression when not
24806 2002-09-17 Martin Baulig <martin@gnome.org>
24808 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24809 this is an explicit interface implementation.
24811 2002-09-17 Martin Baulig <martin@gnome.org>
24813 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24814 different `IndexerName' attributes.
24816 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24817 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24818 virtual CommonResolve().
24820 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24822 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24823 and convert that to the UnderlyingType.
24825 * statement.cs (Foreach.Resolve): Indexers are just like variables
24826 or PropertyAccesses.
24828 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24829 inside quoted strings, we were not doing this before.
24831 2002-09-16 Martin Baulig <martin@gnome.org>
24833 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24834 resolve it. This is needed for the definite assignment check of the
24835 instance expression, fixes bug #29846.
24836 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24838 2002-09-16 Nick Drochak <ndrochak@gol.com>
24840 * parameter.cs: Fix compile error. Cannot reference static member
24841 from an instance object. Is this an mcs bug?
24843 2002-09-14 Martin Baulig <martin@gnome.org>
24845 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24846 multiple times. Fixes bug #30295, added test-166.cs.
24848 2002-09-14 Martin Baulig <martin@gnome.org>
24850 * statement.cs (Block.Emit): Don't emit unreachable code.
24851 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24852 `break' statements.
24853 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24855 2002-09-14 Martin Baulig <martin@gnome.org>
24857 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24860 2002-09-14 Martin Baulig <martin@gnome.org>
24862 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24863 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24864 be false on the ms runtime.
24866 2002-09-13 Martin Baulig <martin@gnome.org>
24868 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24869 the CS0038 error message.
24871 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24873 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24874 constant inside, return it.
24876 2002-09-12 Martin Baulig <martin@gnome.org>
24878 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24879 implicit conversion can be done between enum types.
24881 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24882 check whether an implicit conversion to the current enum's UnderlyingType
24883 exists and report an error if not.
24885 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24886 without debugging support.
24888 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24889 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24891 2002-09-12 Martin Baulig <martin@gnome.org>
24893 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24895 * ecore.cs (IMemberExpr.DeclaringType): New property.
24896 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24897 nonstatic member of an outer type (CS0038).
24899 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24901 * driver.cs: Activate the using-error detector at warning level
24902 4 (at least for MS-compatible APIs).
24904 * namespace.cs (VerifyUsing): Small buglett fix.
24906 * pending.cs (PendingImplementation): pass the container pointer.
24908 * interface.cs (GetMethods): Allow for recursive definition. Long
24909 term, I would like to move every type to support recursive
24910 definitions, not the current ordering mechanism that we have right
24913 The situation is this: Attributes are handled before interfaces,
24914 so we can apply attributes to interfaces. But some attributes
24915 implement interfaces, we will now handle the simple cases
24916 (recursive definitions will just get an error).
24918 * parameter.cs: Only invalidate types at the end if we fail to
24921 2002-09-09 Martin Baulig <martin@gnome.org>
24923 * ecore.cs (PropertyExpr.Emit): Also check for
24924 TypeManager.system_int_array_get_length so this'll also work when
24925 compiling corlib. Fixes #30003.
24927 2002-09-09 Martin Baulig <martin@gnome.org>
24929 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24930 and throw an exception if we can't get the type's size. Fixed #30040,
24933 2002-09-09 Martin Baulig <martin@gnome.org>
24935 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24937 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24938 context. Fixes bug #30027.
24940 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24941 virtual functions. Fixes bug #30043, added test-164.cs.
24943 2002-09-08 Ravi Pratap <ravi@ximian.com>
24945 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24947 2002-09-08 Nick Drochak <ndrochak@gol.com>
24949 * driver.cs: Use an object to get the windows codepage since it's not a
24952 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24954 * statement.cs (For.Emit): for infinite loops (test == null)
24955 return whether there is a break inside, not always "true".
24957 * namespace.cs (UsingEntry): New struct to hold the name of the
24958 using definition, the location where it is defined, and whether it
24959 has been used in a successful type lookup.
24961 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24966 2002-09-06 Ravi Pratap <ravi@ximian.com>
24968 * attribute.cs : Fix incorrect code which relied on catching
24969 a NullReferenceException to detect a null being passed in
24970 where an object was expected.
24972 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24974 * statement.cs (Try): flag the catch variable as assigned
24976 * expression.cs (Cast): Simplified by using ResolveType instead of
24977 manually resolving.
24979 * statement.cs (Catch): Fix bug by using ResolveType.
24981 2002-09-06 Ravi Pratap <ravi@ximian.com>
24983 * expression.cs (BetterConversion): Special case for when we have
24984 a NullLiteral as the argument and we have to choose between string
24985 and object types - we choose string the way csc does.
24987 * attribute.cs (Attribute.Resolve): Catch the
24988 NullReferenceException and report error #182 since the Mono
24989 runtime no more has the bug and having this exception raised means
24990 we tried to select a constructor which takes an object and is
24993 2002-09-05 Ravi Pratap <ravi@ximian.com>
24995 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24996 message (1502, 1503) when we can't locate a method after overload
24997 resolution. This is much more informative and closes the bug
25000 * interface.cs (PopulateMethod): Return if there are no argument
25001 types. Fixes a NullReferenceException bug.
25003 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
25004 expressions too. Previously we were checking only in one place for
25005 positional arguments leaving out named arguments.
25007 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
25008 type to the enum type is not allowed. Remove code corresponding to
25011 (ConvertNumericExplicit): Allow explicit conversions from
25012 the underlying type to enum type. This precisely follows the spec
25013 and closes a bug filed by Gonzalo.
25015 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25018 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
25020 2002-09-03 Miguel de Icaza <miguel@ximian.com>
25022 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
25023 it was important that we stored the right value after the
25024 reduction in `converted'.
25026 2002-09-04 Martin Baulig <martin@gnome.org>
25028 * location.cs (Location.SymbolDocument): Use full pathnames for the
25031 2002-08-30 Miguel de Icaza <miguel@ximian.com>
25033 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
25034 of the expression resolve mechanism, because that will catch the
25035 SimpleName error failures.
25037 (Conditional): If we can not resolve the
25038 expression, return, do not crash.
25040 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25043 (location): display token name instead of its number.
25045 2002-08-28 Martin Baulig <martin@gnome.org>
25047 * expression.cs (Binary.ResolveOperator): Don't silently return
25048 but return an error if an operator cannot be applied between two
25051 2002-08-28 Martin Baulig <martin@gnome.org>
25053 * class.cs (Constructor.Define): Set the permission attributes
25054 correctly instead of making all constructors public.
25056 2002-08-28 Martin Baulig <martin@gnome.org>
25058 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
25059 for private members before reporting a CS0103; if we find anything,
25062 2002-08-28 Martin Baulig <martin@gnome.org>
25064 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
25065 to check whether `closure_start_type == closure_invocation_type',
25066 we also need to check whether `m.DeclaringType == closure_invocation_type'
25067 before bypassing the permission checks. We might be accessing
25068 protected/private members from the base class.
25069 (TypeManager.RealMemberLookup): Only set private_ok if private
25070 members were requested via BindingFlags.NonPublic.
25072 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
25074 * expression.cs (MemberAccess.ResolveMemberAccess): Set
25075 MethodGroupExpr.IsExplicitImpl if appropriate.
25076 (Invocation.DoResolve): Don't report the CS0120 for explicit
25077 interface implementations.
25079 2002-08-27 Martin Baulig <martin@gnome.org>
25081 * expression.cs (Invocation.DoResolve): If this is a static
25082 method and we don't have an InstanceExpression, we must report
25085 2002-08-25 Martin Baulig <martin@gnome.org>
25087 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
25088 `==' between a valuetype and an object.
25090 2002-08-25 Miguel de Icaza <miguel@ximian.com>
25092 * ecore.cs (TypeExpr): Provide a ToString method.
25094 2002-08-24 Martin Baulig <martin@gnome.org>
25096 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
25097 now called proggie.dbg and it's a binary file.
25099 2002-08-23 Martin Baulig <martin@gnome.org>
25101 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
25103 2002-08-23 Martin Baulig <martin@gnome.org>
25105 * struct.cs (MyStructInfo.ctor): Make this work with empty
25106 structs; it's not allowed to use foreach() on null.
25108 2002-08-23 Martin Baulig <martin@gnome.org>
25110 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
25111 writer the full pathname of the generated assembly.
25113 2002-08-23 Martin Baulig <martin@gnome.org>
25115 * statements.cs (FlowBranching.UsageVector.MergeChildren):
25116 A `finally' block never returns or breaks; improved handling of
25119 2002-08-23 Martin Baulig <martin@gnome.org>
25121 * statement.cs (Throw.Resolve): Allow `throw null'.
25123 2002-08-23 Martin Baulig <martin@gnome.org>
25125 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
25126 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
25127 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
25128 MemberLookup would return a wrong event if this is an explicit
25129 interface implementation and the class has an event with the same
25132 2002-08-23 Martin Baulig <martin@gnome.org>
25134 * statement.cs (Block.AddChildVariableNames): New public method.
25135 (Block.AddChildVariableName): Likewise.
25136 (Block.IsVariableNameUsedInChildBlock): Likewise.
25137 (Block.AddVariable): Check whether a variable name has already
25138 been used in a child block.
25140 * cs-parser.jay (declare_local_variables): Mark all variable names
25141 from the current block as being used in a child block in the
25144 2002-08-23 Martin Baulig <martin@gnome.org>
25146 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
25147 find the symbol writer.
25149 * driver.cs: csc also allows the arguments to /define being
25150 separated by commas, not only by semicolons.
25152 2002-08-23 Martin Baulig <martin@gnome.org>
25154 * interface.cs (Interface.GetMembers): Added static check for events.
25156 2002-08-15 Martin Baulig <martin@gnome.org>
25158 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
25159 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
25161 * ecore.cs (Expression.MemberLookup): Added documentation and explained
25162 why the MethodData.EmitDestructor() change was necessary.
25164 2002-08-20 Martin Baulig <martin@gnome.org>
25166 * class.cs (TypeContainer.FindMembers): Added static check for events.
25168 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
25170 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
25171 use Type.GetEvents(), not Type.FindMembers().
25173 2002-08-20 Martin Baulig <martin@gnome.org>
25175 * decl.cs (MemberCache): Added a special method cache which will
25176 be used for method-only searched. This ensures that a method
25177 search will return a MethodInfo with the correct ReflectedType for
25180 2002-08-20 Martin Baulig <martin@gnome.org>
25182 * decl.cs (DeclSpace.FindMembers): Made this public.
25184 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25186 * delegate.cs: fixed build on windows.
25187 [FIXME: Filed as bug #29150: MCS must report these errors.]
25189 2002-08-19 Ravi Pratap <ravi@ximian.com>
25191 * ecore.cs (StandardConversionExists): Return a false
25192 if we are trying to convert the void type to anything else
25193 since that is not allowed.
25195 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
25196 we flag error 70 in the event an event is trying to be accessed
25197 directly from outside the declaring type.
25199 2002-08-20 Martin Baulig <martin@gnome.org>
25201 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
25202 MemberCache from typemanager.cs to decl.cs.
25204 2002-08-19 Martin Baulig <martin@gnome.org>
25206 * class.cs (TypeContainer): Implement IMemberContainer.
25207 (TypeContainer.DefineMembers): Create the MemberCache.
25208 (TypeContainer.FindMembers): Do better BindingFlags checking; only
25209 return public members if BindingFlags.Public was given, check
25210 whether members are static.
25212 2002-08-16 Martin Baulig <martin@gnome.org>
25214 * decl.cs (DeclSpace.Define): Splitted this in Define and
25215 DefineMembers. DefineMembers is called first and initializes the
25218 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
25219 DefineMembers() on all our DeclSpaces.
25221 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
25222 but call DefineMembers() on all nested interfaces. We call their
25223 Define() in our new Define() function.
25225 * interface.cs (Interface): Implement IMemberContainer.
25226 (Interface.Define): Moved all code except the attribute stuf to
25228 (Interface.DefineMembers): Initialize the member cache.
25230 * typemanager.cs (IMemberFinder): Removed this interface, we don't
25231 need this anymore since we can use MemberCache.FindMembers directly.
25233 2002-08-19 Martin Baulig <martin@gnome.org>
25235 * typemanager.cs (MemberCache): When creating the cache for an
25236 interface type, add all inherited members.
25237 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
25238 to `out bool used_cache' and documented it.
25239 (TypeManager.MemberLookup): If we already used the cache in the first
25240 iteration, we don't need to do the interfaces check.
25242 2002-08-19 Martin Baulig <martin@gnome.org>
25244 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
25245 here from IMemberFinder and don't implement this interface anymore.
25246 (DeclSpace.MemberCache): Moved here from IMemberFinder.
25248 * typemanager.cs (IMemberFinder): This interface is now only used by
25249 classes which actually support the member cache.
25250 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
25251 since we only put DeclSpaces into this Hashtable.
25252 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
25253 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
25255 2002-08-16 Martin Baulig <martin@gnome.org>
25257 * typemanager.cs (ICachingMemberFinder): Removed.
25258 (IMemberFinder.MemberCache): New property.
25259 (TypeManager.FindMembers): Merged this with RealFindMembers().
25260 This function will never be called from TypeManager.MemberLookup()
25261 so we can't use the cache here, just the IMemberFinder.
25262 (TypeManager.MemberLookup_FindMembers): Check whether the
25263 IMemberFinder has a MemberCache and call the cache's FindMembers
25265 (MemberCache): Rewrote larger parts of this yet another time and
25266 cleaned it up a bit.
25268 2002-08-15 Miguel de Icaza <miguel@ximian.com>
25270 * driver.cs (LoadArgs): Support quoting.
25272 (Usage): Show the CSC-like command line arguments.
25274 Improved a few error messages.
25276 2002-08-15 Martin Baulig <martin@gnome.org>
25278 * typemanager.cs (IMemberContainer.Type): New property.
25279 (IMemberContainer.IsInterface): New property.
25281 The following changes are conditional to BROKEN_RUNTIME, which is
25282 defined at the top of the file.
25284 * typemanager.cs (MemberCache.MemberCache): Don't add the base
25285 class'es members, but add all members from TypeHandle.ObjectType
25286 if we're an interface.
25287 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
25288 is the current type.
25289 (MemberCache.CacheEntry.Container): Removed this field.
25290 (TypeHandle.GetMembers): Include inherited members.
25292 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25294 * typemanager.cs: fixed compilation and added a comment on a field that
25297 2002-08-15 Martin Baulig <martin@gnome.org>
25299 * class.cs (ConstructorInitializer.Resolve): In the
25300 Expression.MemberLookup call, use the queried_type as
25303 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
25304 declared' attribute, it's always true.
25305 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
25306 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
25307 temporary wrapper for FindMembers which tells MemberLookup whether
25308 members from the base classes are included in the return value.
25309 This will go away soon.
25310 (TypeManager.MemberLookup): Use this temporary hack here; once the
25311 new MemberCache is completed, we don't need to do the DeclaredOnly
25312 looping here anymore since the MemberCache will take care of this.
25313 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
25314 (MemberCache): When creating the MemberCache for a class, get
25315 members from the current class and all its base classes.
25316 (MemberCache.CacheEntry.Container): New field. This is a
25317 temporary hack until the Mono runtime is fixed to distinguish
25318 between ReflectedType and DeclaringType. It allows us to use MCS
25319 with both the MS runtime and the unfixed Mono runtime without
25320 problems and without accecting performance.
25321 (MemberCache.SearchMembers): The DeclaredOnly looping from
25322 TypeManager.MemberLookup is now done here.
25324 2002-08-14 Martin Baulig <martin@gnome.org>
25326 * statement.cs (MyStructInfo.MyStructInfo): Don't call
25327 Type.GetFields on dynamic types but get the fields from the
25328 corresponding TypeContainer.
25329 (MyStructInfo.GetStructInfo): Added check for enum types.
25331 * typemanager.cs (MemberList.IsSynchronized): Implemented.
25332 (MemberList.SyncRoot): Implemented.
25333 (TypeManager.FilterWithClosure): No need to check permissions if
25334 closure_start_type == closure_invocation_type, don't crash if
25335 closure_invocation_type is null.
25337 2002-08-13 Martin Baulig <martin@gnome.org>
25339 Rewrote TypeContainer.FindMembers to use a member cache. This
25340 gives us a speed increase of about 35% for the self-hosting MCS
25341 build and of about 15-20% for the class libs (both on GNU/Linux).
25343 * report.cs (Timer): New class to get enhanced profiling. This
25344 whole class is "TIMER" conditional since it remarkably slows down
25347 * class.cs (MemberList): New class. This is an IList wrapper
25348 which we're now using instead of passing MemberInfo[]'s around to
25349 avoid copying this array unnecessarily.
25350 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
25351 (ICachingMemberFinder, IMemberContainer): New interface.
25352 (TypeManager.FilterWithClosure): If `criteria' is null, the name
25353 has already been checked, otherwise use it for the name comparision.
25354 (TypeManager.FindMembers): Renamed to RealMemberFinder and
25355 provided wrapper which tries to use ICachingMemberFinder.FindMembers
25356 if possible. Returns a MemberList, not a MemberInfo [].
25357 (TypeHandle): New class, implements IMemberContainer. We create
25358 one instance of this class per type, it contains a MemberCache
25359 which is used to do the member lookups.
25360 (MemberCache): New class. Each instance of this class contains
25361 all members of a type and a name-based hash table.
25362 (MemberCache.FindMembers): This is our new member lookup
25363 function. First, it looks up all members of the requested name in
25364 the hash table. Then, it walks this list and sorts out all
25365 applicable members and returns them.
25367 2002-08-13 Martin Baulig <martin@gnome.org>
25369 In addition to a nice code cleanup, this gives us a performance
25370 increase of about 1.4% on GNU/Linux - not much, but it's already
25371 half a second for the self-hosting MCS compilation.
25373 * typemanager.cs (IMemberFinder): New interface. It is used by
25374 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25375 Enum, Delegate or Interface.
25376 (TypeManager.finder_to_member_finder): New PtrHashtable.
25377 (TypeManager.finder_to_container): Removed.
25378 (TypeManager.finder_to_delegate): Removed.
25379 (TypeManager.finder_to_interface): Removed.
25380 (TypeManager.finder_to_enum): Removed.
25382 * interface.cs (Interface): Implement IMemberFinder.
25384 * delegate.cs (Delegate): Implement IMemberFinder.
25386 * enum.cs (Enum): Implement IMemberFinder.
25388 * class.cs (TypeContainer): Implement IMemberFinder.
25390 2002-08-12 Martin Baulig <martin@gnome.org>
25392 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25394 2002-08-12 Martin Baulig <martin@gnome.org>
25396 * ecore.cs (ITypeExpression): New interface for expressions which
25398 (TypeExpression): Renamed to TypeLookupExpression.
25399 (Expression.DoResolve): If we're doing a types-only lookup, the
25400 expression must implement the ITypeExpression interface and we
25401 call DoResolveType() on it.
25402 (SimpleName): Implement the new ITypeExpression interface.
25403 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25404 hack, the situation that we're only looking up types can't happen
25405 anymore when this method is called. Moved the type lookup code to
25406 DoResolveType() and call it.
25407 (SimpleName.DoResolveType): This ITypeExpression interface method
25408 is now doing the types-only lookup.
25409 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25410 (ResolveFlags): Added MaskExprClass.
25412 * expression.cs (MemberAccess): Implement the ITypeExpression
25414 (MemberAccess.DoResolve): Added support for a types-only lookup
25415 when we're called via ITypeExpression.DoResolveType().
25416 (ComposedCast): Implement the ITypeExpression interface.
25418 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25419 Expression.Resolve() with ResolveFlags.Type instead.
25421 2002-08-12 Martin Baulig <martin@gnome.org>
25423 * interface.cs (Interface.Define): Apply attributes.
25425 * attribute.cs (Attribute.ApplyAttributes): Added support for
25426 interface attributes.
25428 2002-08-11 Martin Baulig <martin@gnome.org>
25430 * statement.cs (Block.Emit): Only check the "this" variable if we
25431 do not always throw an exception.
25433 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25434 whether the property has a set accessor.
25436 2002-08-11 Martin Baulig <martin@gnome.org>
25438 Added control flow analysis support for structs.
25440 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25441 with control flow analysis turned off.
25442 (IVariable): New interface.
25443 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25444 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25445 (FieldExpr.DoResolve): Resolve the instance expression with flow
25446 analysis turned off and do the definite assignment check after the
25447 resolving when we know what the expression will resolve to.
25449 * expression.cs (LocalVariableReference, ParameterReference):
25450 Implement the new IVariable interface, only call the flow analysis
25451 code if ec.DoFlowAnalysis is true.
25452 (This): Added constructor which takes a Block argument. Implement
25453 the new IVariable interface.
25454 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25455 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25456 This does the definite assignment checks for struct members.
25458 * class.cs (Constructor.Emit): If this is a non-static `struct'
25459 constructor which doesn't have any initializer, call
25460 Block.AddThisVariable() to tell the flow analysis code that all
25461 struct elements must be initialized before control returns from
25464 * statement.cs (MyStructInfo): New public class.
25465 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25466 argument to this indexer. If non-zero, check an individual struct
25467 member, not the whole struct.
25468 (FlowBranching.CheckOutParameters): Check struct members.
25469 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25470 overloaded versions of these methods which take an additional
25471 `int field_idx' argument to check struct members.
25472 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25473 overloaded versions of these methods which take an additional
25474 `string field_name' argument to check struct member.s
25475 (VariableInfo): Implement the IVariable interface.
25476 (VariableInfo.StructInfo): New public property. Returns the
25477 MyStructInfo instance of the variable if it's a struct or null.
25478 (Block.AddThisVariable): New public method. This is called from
25479 Constructor.Emit() for non-static `struct' constructor which do
25480 not have any initializer. It creates a special variable for the
25481 "this" instance variable which will be checked by the flow
25482 analysis code to ensure that all of the struct's fields are
25483 initialized before control returns from the constructor.
25484 (UsageVector): Added support for struct members. If a
25485 variable/parameter is a struct with N members, we reserve a slot
25486 in the usage vector for each member. A struct is considered fully
25487 initialized if either the struct itself (slot 0) or all its
25488 members are initialized.
25490 2002-08-08 Martin Baulig <martin@gnome.org>
25492 * driver.cs (Driver.MainDriver): Only report an error CS5001
25493 if there were no compilation errors.
25495 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25496 `UnsafeContext' property to determine whether the parent is in
25497 unsafe context rather than checking the parent's ModFlags:
25498 classes nested in an unsafe class are unsafe as well.
25500 2002-08-08 Martin Baulig <martin@gnome.org>
25502 * statement.cs (UsageVector.MergeChildren): Distinguish between
25503 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25504 we return. Added test17() and test18() to test-154.cs.
25506 2002-08-08 Martin Baulig <martin@gnome.org>
25508 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25509 Family access, make sure the invoking type isn't a subclass of the
25510 queried type (that'd be a CS1540).
25512 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25513 this method which takes an additional `Type invocation_type'.
25515 * expression.cs (BaseAccess.DoResolve): Use the base type as
25516 invocation and query type.
25517 (MemberAccess.DoResolve): If the lookup failed and we're about to
25518 report a CS0122, try a lookup with the ec.ContainerType - if this
25519 succeeds, we must report a CS1540.
25521 2002-08-08 Martin Baulig <martin@gnome.org>
25523 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25524 (MethodGroupExpr): Implement the IMemberExpr interface.
25526 * expression (MemberAccess.ResolveMemberAccess): No need to have
25527 any special code for MethodGroupExprs anymore, they're now
25530 2002-08-08 Martin Baulig <martin@gnome.org>
25532 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25533 Family, FamANDAssem and FamORAssem permissions.
25534 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25536 2002-08-08 Martin Baulig <martin@gnome.org>
25538 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25539 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25542 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25544 * driver.cs: implemented /resource option to embed managed resources.
25546 2002-08-07 Martin Baulig <martin@gnome.org>
25548 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25549 (FieldBase.HasFieldInitializer): New public property.
25550 (FieldBase.GetInitializerExpression): New public method. Resolves and
25551 returns the field initializer and makes sure it is only resolved once.
25552 (TypeContainer.EmitFieldInitializers): Call
25553 FieldBase.GetInitializerExpression to get the initializer, this ensures
25554 that it isn't resolved multiple times.
25556 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25557 the resolving process (SimpleName/MemberLookup) that we're currently
25558 emitting a field initializer (which must not access any instance members,
25559 this is an error CS0236).
25561 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25562 argument, if the `IsFieldInitializer' flag is set, we must report and
25563 error CS0236 and not an error CS0120.
25565 2002-08-07 Martin Baulig <martin@gnome.org>
25567 * ecore.cs (IMemberExpr): New public interface.
25568 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25569 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25570 if the expression is an IMemberExpr.
25572 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25573 to be null, implicitly default to `this' if we're non-static in
25574 this case. Simplified the code a lot by using the new IMemberExpr
25575 interface. Also fixed bug #28176 here.
25577 2002-08-06 Martin Baulig <martin@gnome.org>
25579 * cs-parser.jay (SimpleLookup): Removed. We need to create
25580 ParameterReferences during semantic analysis so that we can do a
25581 type-only search when resolving Cast, TypeOf and SizeOf.
25582 (block): Pass the `current_local_parameters' to the Block's
25585 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25586 argument to the constructor.
25587 (ConstructorInitializer.Resolve): Create a temporary implicit
25588 block with the parameters.
25590 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25591 references here if we aren't doing a type-only search.
25593 * statement.cs (Block): Added constructor which takes a
25594 `Parameters parameters' argument.
25595 (Block.Parameters): New public property.
25597 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25598 to `Parameters' and made it public readonly.
25600 2002-08-06 Martin Baulig <martin@gnome.org>
25602 * ecore.cs (Expression.Warning): Made this public as well.
25604 * report.cs (Report.Debug): Print the contents of collections.
25606 2002-08-06 Martin Baulig <martin@gnome.org>
25608 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25609 used to tell Resolve() which kinds of expressions it may return.
25610 (Expression.Resolve): Added overloaded version of this method which
25611 takes a `ResolveFlags flags' argument. This can be used to tell
25612 Resolve() which kinds of expressions it may return. Reports a
25614 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25615 ResolveFlags.SimpleName.
25616 (Expression.Error118): Added overloaded version of this method which
25617 takes a `ResolveFlags flags' argument. It uses the flags to determine
25618 which kinds of expressions are allowed.
25620 * expression.cs (Argument.ResolveMethodGroup): New public method.
25621 Resolves an argument, but allows a MethodGroup to be returned.
25622 This is used when invoking a delegate.
25624 * TODO: Updated a bit.
25626 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25628 Fixed compilation with csc.
25630 * ecore.cs: Expression.Error made public. Is this correct? Should
25631 Warning be made public too?
25633 * expression.cs: use ea.Location instead of ea.loc.
25634 [FIXME: Filed as bug #28607: MCS must report these errors.]
25636 2002-08-06 Martin Baulig <martin@gnome.org>
25638 * ecore.cs (Expression.loc): Moved the location here instead of
25639 duplicating it in all derived classes.
25640 (Expression.Location): New public property.
25641 (Expression.Error, Expression.Warning): Made them non-static and
25642 removed the location argument.
25643 (Expression.Warning): Added overloaded version which takes an
25644 `int level' argument.
25645 (Expression.Error118): Make this non-static and removed the
25646 expression and location arguments.
25647 (TypeExpr): Added location argument to the constructor.
25649 * expression.cs (StaticCallExpr): Added location argument to
25651 (Indirection, PointerArithmetic): Likewise.
25652 (CheckedExpr, UnCheckedExpr): Likewise.
25653 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25654 (StringPtr): Likewise.
25657 2002-08-05 Martin Baulig <martin@gnome.org>
25659 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25661 * assign.cs (Assign.DoResolve): Check whether the source
25662 expression is a value or variable.
25664 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25665 while resolving the corresponding blocks.
25667 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25668 an error, don't silently return null.
25670 * statement.cs (Block.AddVariable): Do the error reporting here
25671 and distinguish between CS0128 and CS0136.
25672 (Block.DoResolve): Report all unused labels (warning CS0164).
25673 (LabeledStatement): Pass the location to the constructor.
25674 (LabeledStatement.HasBeenReferenced): New property.
25675 (LabeledStatement.Resolve): Set it to true here.
25677 * statement.cs (Return.Emit): Return success even after reporting
25678 a type mismatch error (CS0126 or CS0127), this is what csc does and
25679 it avoids confusing the users with any consecutive errors.
25681 2002-08-05 Martin Baulig <martin@gnome.org>
25683 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25685 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25687 * expression.cs (MemberAccess.DoResolve): Silently return if an
25688 error has already been reported.
25690 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25691 error has already been reported.
25693 2002-08-05 Martin Baulig <martin@gnome.org>
25695 * statement.cs (UsageVector): Only initialize the `parameters'
25696 vector if we actually have any "out" parameters.
25698 2002-08-05 Martin Baulig <martin@gnome.org>
25700 * expression.cs (Binary.ResolveOperator): When combining delegates,
25701 they must have the same type.
25703 2002-08-05 Martin Baulig <martin@gnome.org>
25705 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25706 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25707 work with the ms runtime and we also don't need it: if we're a
25708 PropertyBuilder and not in the `indexer_arguments' hash, then we
25709 are a property and not an indexer.
25711 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25712 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25713 since the latter one doesn't work with the ms runtime.
25715 2002-08-03 Martin Baulig <martin@gnome.org>
25717 Fixed bugs #27998 and #22735.
25719 * class.cs (Method.IsOperator): New public field.
25720 (Method.CheckBase): Report CS0111 if there's already a method
25721 with the same parameters in the current class. Report CS0508 when
25722 attempting to change the return type of an inherited method.
25723 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25724 and it's not marked abstract or extern.
25725 (PropertyBase): New abstract base class for Property and Indexer.
25726 (PropertyBase.CheckBase): Moved here from Property and made it work
25728 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25729 the same so we can reuse it there.
25730 (Property, Indexer): Derive from PropertyBase.
25731 (MethodSignature.inheritable_property_signature_filter): New delegate
25732 to find properties and indexers.
25734 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25735 argument and improved error reporting.
25737 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25738 EmptyReadOnlyParameters and made it a property.
25740 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25741 version of this method which takes a `PropertyInfo indexer'.
25742 (TypeManager.RegisterIndexer): New method.
25744 * class.cs: Added myself as author of this file :-)
25746 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25748 * class.cs: fixed compilation on windoze.
25750 2002-08-03 Martin Baulig <martin@gnome.org>
25752 * interface.cs (Interface.GetInterfaceBases): Check whether all
25753 base interfaces are at least as accessible than the current one.
25755 * class.cs (TypeContainer.GetClassBases): Check whether base types
25756 are at least as accessible than the current type.
25757 (TypeContainer.AsAccessible): Implemented and made non-static.
25758 (MemberBase.CheckParameters): Report errors if the accessibility
25761 * delegate.cs (Delegate.Delegate): The default visibility is
25762 internal for top-level types and private for nested types.
25763 (Delegate.Define): Report errors if the accessibility checks fail.
25765 * enum.cs (Enum.Enum): The default visibility is internal for
25766 top-level types and private for nested types.
25767 (Enum.DefineType): Compute the correct visibility.
25769 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25770 function which takes a `bool is_toplevel' instead of a TypeContainer.
25772 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25775 2002-08-02 Martin Baulig <martin@gnome.org>
25777 * expression.cs (LocalVariableReferenc): Added constructor which
25778 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25779 (LocalVariableReference.IsReadOnly): New property.
25780 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25781 variable is readonly, use our own readonly flag to do this; you can
25782 use the new constructor to get a writable reference to a read-only
25785 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25786 reference to the local variable.
25788 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25790 * rootcontext.cs (ResolveCore): Also include System.Exception
25792 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25793 we reach an EmptyStatement.
25795 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25798 * expression.cs (Binary.ResolveOperator): Check error result in
25801 use brtrue/brfalse directly and avoid compares to null.
25803 2002-08-02 Martin Baulig <martin@gnome.org>
25805 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25806 Fixes bug #28407, added test-155.cs.
25808 2002-08-01 Martin Baulig <martin@gnome.org>
25810 * class.cs (Event.EmitDefaultMethod): Make this work with static
25811 events. Fixes #28311, added verify-3.cs.
25813 2002-08-01 Martin Baulig <martin@gnome.org>
25815 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25816 `is_disposable' fields.
25817 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25818 `hm.is_disposable' if we're using the collection pattern.
25819 (Foreach.EmitCollectionForeach): Use the correct type for the
25820 enumerator's local variable, only emit the try/finally block if
25821 necessary (fixes #27713).
25823 2002-08-01 Martin Baulig <martin@gnome.org>
25825 * ecore.cs (Expression.report118): Renamed to Error118 and made
25828 * statement.cs (Throw.Resolve): Check whether the expression is of
25829 the correct type (CS0118) and whether the type derives from
25830 System.Exception (CS0155).
25831 (Catch.Resolve): New method. Do the type lookup here and check
25832 whether it derives from System.Exception (CS0155).
25833 (Catch.CatchType, Catch.IsGeneral): New public properties.
25835 * typemanager.cs (TypeManager.exception_type): Added.
25837 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25839 * driver.cs: Updated About function.
25841 2002-07-31 Martin Baulig <martin@gnome.org>
25843 Implemented Control Flow Analysis.
25845 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25846 (EmitContext.CurrentBranching): Added.
25847 (EmitContext.StartFlowBranching): Added.
25848 (EmitContext.EndFlowBranching): Added.
25849 (EmitContext.KillFlowBranching): Added.
25850 (EmitContext.IsVariableAssigned): Added.
25851 (EmitContext.SetVariableAssigned): Added.
25852 (EmitContext.IsParameterAssigned): Added.
25853 (EmitContext.SetParameterAssigned): Added.
25854 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25855 Added control flow analysis stuff here.
25857 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25858 resolve the expression as lvalue.
25859 (LocalVariableReference.DoResolve): Check whether the variable has
25860 already been assigned.
25861 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25862 the parameter as assigned here.
25863 (ParameterReference.DoResolve): Check whether the parameter has already
25865 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25866 expression as lvalue.
25868 * statement.cs (FlowBranching): New class for the flow analysis code.
25869 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25870 (LabeledStatement.IsDefined): New public property.
25871 (LabeledStatement.AddUsageVector): New public method to tell flow
25872 analyis that the label may be reached via a forward jump.
25873 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25875 (VariableInfo.Number): New public field. This is used by flow analysis
25876 to number all locals of a block.
25877 (Block.CountVariables): New public property. This is the number of
25878 local variables in this block (including the locals from all parent
25880 (Block.EmitMeta): Number all the variables.
25882 * statement.cs: Added flow analysis support to all classes.
25884 2002-07-31 Martin Baulig <martin@gnome.org>
25886 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25887 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25888 then use this argument.
25890 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25892 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25893 use this to specify /define options.
25895 2002-07-29 Martin Baulig <martin@gnome.org>
25897 * statement.cs (Fixed): Moved all code that does variable lookups
25898 and resolvings from Emit to Resolve.
25900 * statement.cs (For): Moved all code that does variable lookups
25901 and resolvings from Emit to Resolve.
25903 * statement.cs (Using): Moved all code that does variable lookups
25904 and resolvings from Emit to Resolve.
25906 2002-07-29 Martin Baulig <martin@gnome.org>
25908 * attribute.cs (Attribute.Resolve): Explicitly catch a
25909 System.NullReferenceException when creating the
25910 CustromAttributeBuilder and report a different warning message.
25912 2002-07-29 Martin Baulig <martin@gnome.org>
25914 * support.cs (ParameterData.ParameterName): Added method to
25915 get the name of a parameter.
25917 * typemanager.cs (TypeManager.IsValueType): New public method.
25919 2002-07-29 Martin Baulig <martin@gnome.org>
25921 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25922 is a flag which specifies that it's either ref or out.
25923 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25924 the out parameter to `out Parameter.Modifier mod', also set the
25925 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25927 * support.cs (InternalParameters.ParameterModifier): Distinguish
25928 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25929 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25931 * expression.cs (Argument.GetParameterModifier): Distinguish
25932 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25933 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25935 2002-07-29 Martin Baulig <martin@gnome.org>
25937 * expression.cs (ParameterReference.ParameterReference): Added
25938 `Location loc' argument to the constructor.
25940 * cs-parser.jay: Pass location to ParameterReference.
25942 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25944 * statement.cs (Try): Initialize the location.
25946 * cs-parser.jay: pass location to Try.
25948 * expression.cs (Unary.Reduce): Change the prototype to return
25949 whether a constant fold could be performed or not. The result is
25950 returned in an out parameters. In the case of Indirection and
25951 AddressOf, we want to perform the full tests.
25953 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25955 * statement.cs (Statement.Emit): Flag dead code.
25957 2002-07-27 Andrew Birkett <andy@nobugs.org>
25959 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25961 2002-07-27 Martin Baulig <martin@gnome.org>
25963 * class.cs (MethodData.Define): Put back call to
25964 TypeManager.AddMethod(), accidentally commented this out.
25966 * report.cs (Debug): New public method to print debugging information,
25967 this is `[Conditional ("DEBUG")]'.
25969 2002-07-26 Martin Baulig <martin@gnome.org>
25971 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25972 (switch_statement): Push the current_block to the switch_stack and
25973 pop it again when we're done with the switch.
25974 (switch_section): The new block is a child of the current_block.
25975 Fixes bug #24007, added test-152.cs.
25977 2002-07-27 Martin Baulig <martin@gnome.org>
25979 * expression.cs (Invocation.EmitArguments): When calling a varargs
25980 function with only its fixed arguments, we need to pass an empty
25983 2002-07-27 Martin Baulig <martin@gnome.org>
25985 Mono 0.13 has been released.
25987 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25989 * driver.cs: Rename --resource to --linkres, because that is what
25990 we do currently, we dont support --resource yet.
25992 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25994 2002-07-25 Martin Baulig <martin@gnome.org>
25996 * class.cs (MethodData): New public class. This is a `method builder'
25997 class for a method or one accessor of a Property/Indexer/Event.
25998 (MethodData.GetMethodFlags): Moved here from MemberBase.
25999 (MethodData.ApplyAttributes): Likewise.
26000 (MethodData.ApplyObsoleteAttribute): Likewise.
26001 (MethodData.ApplyConditionalAttribute): Likewise.
26002 (MethodData.ApplyDllImportAttribute): Likewise.
26003 (MethodData.CheckAbstractAndExternal): Likewise.
26004 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
26005 (MethodData.Emit): Formerly known as Method.Emit().
26006 (MemberBase): Moved everything which was specific to a single
26007 accessor/method to MethodData.
26008 (Method): Create a new MethodData and call Define() and Emit() on it.
26009 (Property, Indexer, Event): Create a new MethodData objects for each
26010 accessor and call Define() and Emit() on them.
26012 2002-07-25 Martin Baulig <martin@gnome.org>
26014 Made MethodCore derive from MemberBase to reuse the code from there.
26015 MemberBase now also checks for attributes.
26017 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
26018 (MemberBase.GetMethodFlags): Moved here from class Method and marked
26020 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
26021 `CallingConventions cc' and `Attributes opt_attrs' arguments.
26022 (MemberBase.ApplyAttributes): New virtual method; applies the
26023 attributes to a method or accessor.
26024 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
26025 (MemberBase.ApplyConditionalAttribute): Likewise.
26026 (MemberBase.ApplyDllImportAttribute): Likewise.
26027 (MemberBase.CheckAbstractAndExternal): Likewise.
26028 (MethodCore.ParameterTypes): This is now a property instead of a
26029 method, it's initialized from DoDefineParameters().
26030 (MethodCore.ParameterInfo): Removed the set accessor.
26031 (MethodCore.DoDefineParameters): New protected virtual method to
26032 initialize ParameterTypes and ParameterInfo.
26033 (Method.GetReturnType): We can now simply return the MemberType.
26034 (Method.GetMethodFlags): Override the MemberBase version and add
26035 the conditional flags.
26036 (Method.CheckBase): Moved some code from Define() here, call
26037 DoDefineParameters() here.
26038 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
26039 here to avoid some larger code duplication.
26040 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
26041 ensure that abstract and external accessors don't declare a body.
26043 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
26044 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
26045 lookup in the attribute's parent classes, so we need to abort as soon
26046 as we found the first match.
26047 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
26048 the attribute has no arguments.
26050 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
26053 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26055 * cs-parser.jay: reverted previous patch.
26057 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26059 * cs-parser.jay: fixed bug #22119.
26061 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26063 * attribute.cs: fixed compilation. The error was:
26064 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
26065 be assigned to before control leaves the current method."
26066 [FIXME: Filed as bug #28186: MCS must report this error.]
26068 2002-07-25 Martin Baulig <martin@gnome.org>
26070 * attribute.cs (Attribute.Conditional_GetConditionName): New static
26071 method to pull the condition name ouf of a Conditional attribute.
26072 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
26073 the obsolete message and error flag out of an Obsolete attribute.
26075 * class.cs (Method.GetMethodFlags): New public method to get the
26076 TypeManager.MethodFlags for this method.
26077 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
26079 (Method.Define): Get and apply the Obsolete and Conditional attributes;
26080 if we're overriding a virtual function, set the new private variable
26081 `parent_method'; call the new TypeManager.AddMethod().
26083 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
26084 the MethodBuilder and the Method in a PtrHashtable.
26085 (TypeManager.builder_to_method): Added for this purpose.
26086 (TypeManager.MethodFlags): Added IsObsoleteError.
26087 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
26088 Obsolete and Conditional arguments in MethodBuilders. If we discover
26089 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
26090 the message from the attribute.
26092 2002-07-24 Martin Baulig <martin@gnome.org>
26094 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
26095 preprocessor directives, ensure that the argument to #define/#undef is
26096 exactly one identifier and that it's actually an identifier.
26098 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
26101 2002-07-24 Martin Baulig <martin@gnome.org>
26103 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
26104 initialize it to TypeManager.object_type in the constructor.
26105 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
26106 of the `hm.get_current' method if we're using the collection pattern.
26107 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
26108 for the explicit conversion to make it work when we're using the collection
26109 pattern and the `Current' property has a different return type than `object'.
26112 2002-07-24 Martin Baulig <martin@gnome.org>
26114 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
26115 does not match, but don't report any errors. This method is called in
26116 order for all methods in a MethodGroupExpr until a matching method is
26117 found, so we don't want to bail out if the first method doesn't match.
26118 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
26119 matches, report the 123. Fixes #28070.
26121 2002-07-24 Martin Baulig <martin@gnome.org>
26123 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
26124 TypeManager.TypeToCoreType() to the top of the method so the
26125 following equality checks will work. Fixes #28107.
26127 2002-07-24 Martin Baulig <martin@gnome.org>
26129 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
26130 operand is of type uint, and the other operand is of type sbyte,
26131 short or int, the operands are converted to type long." -
26132 Actually do what this comment already told us. Fixes bug #28106,
26135 2002-07-24 Martin Baulig <martin@gnome.org>
26137 * class.cs (MethodBase): New abstract class. This is now a base
26138 class for Property, Indexer and Event to avoid some code duplication
26139 in their Define() and DefineMethods() methods.
26140 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
26141 generic methods for Define() and DefineMethods().
26142 (FieldBase): Derive from MemberBase, not MemberCore.
26143 (Property): Derive from MemberBase, not MemberCore.
26144 (Property.DefineMethod): Moved all the code from this method to the
26145 new MethodBase.DefineAccessor(), just call it with appropriate
26147 (Property.Define): Call the new Property.DoDefine(), this does some
26148 sanity checks and we don't need to duplicate the code everywhere.
26149 (Event): Derive from MemberBase, not MemberCore.
26150 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
26151 accessors, this will also make them work with interface events.
26152 (Indexer): Derive from MemberBase, not MemberCore.
26153 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
26154 (Indexer.Define): Use the new MethodBase functions.
26156 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
26157 argument to the constructor.
26158 (Interface.FindMembers): Added support for interface events.
26159 (Interface.PopluateEvent): Implemented.
26161 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
26163 2002-07-22 Miguel de Icaza <miguel@ximian.com>
26165 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
26166 but this is required to check for a method name being the same as
26167 the containing class.
26171 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26173 * interface.cs: initialize variable.
26175 2002-07-23 Martin Baulig <martin@gnome.org>
26177 Implemented the IndexerName attribute in interfaces.
26179 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
26180 name if this is an explicit interface implementation.
26181 (Indexer.InterfaceIndexerName): New public variable. If we're
26182 implementing an interface indexer, this is the IndexerName in that
26183 interface. Otherwise, it's the IndexerName.
26184 (Indexer.DefineMethod): If we're implementing interface indexer,
26185 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
26186 and Pending.ImplementIndexer methods.
26187 (Indexer.Define): Also define the PropertyBuilder if we're
26188 implementing an interface indexer and this is neither an explicit
26189 interface implementation nor do the IndexerName match the one in
26192 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
26193 If a method is defined here, then we always need to create a proxy
26194 for it. This is used when implementing interface indexers.
26195 (Pending.IsInterfaceIndexer): New public method.
26196 (Pending.ImplementIndexer): New public method.
26197 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
26198 This is used when implementing interface indexers to define a proxy
26200 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
26201 define a proxy if necessary.
26203 * interface.cs (Interface.IndexerName): New public variable.
26204 (Interface.PopulateIndexer): Set the IndexerName.
26205 (Interface.DefineIndexers): New private method. Populate all the
26206 indexers and make sure their IndexerNames match.
26208 * typemanager.cs (IndexerPropertyName): Added support for interface
26211 2002-07-22 Martin Baulig <martin@gnome.org>
26213 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
26214 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
26215 ret if HasReturnLabel.
26216 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
26219 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
26220 and set the ec.LoopBeginTryCatchLevel.
26221 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
26222 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
26223 the current ec.TryCatchLevel, the branch goes out of an exception
26224 block. In this case, we need to use Leave and not Br.
26226 2002-07-22 Martin Baulig <martin@gnome.org>
26228 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
26229 block unless the block does not always return or it is contained in
26230 another try { ... } catch { ... } block. Fixes bug #26506.
26231 Added verify-1.cs to the test suite.
26233 2002-07-22 Martin Baulig <martin@gnome.org>
26235 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
26236 then we do not always return. Fixes bug #24985.
26238 2002-07-22 Martin Baulig <martin@gnome.org>
26240 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
26241 lookup on a per-class level; ie. walk up the class hierarchy until we
26242 found at least one applicable method, then choose the best among them.
26243 Fixes bug #24463 and test-29.cs.
26245 2002-07-22 Martin Baulig <martin@gnome.org>
26247 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
26248 return types of the methods. The return type is not part of the
26249 signature and we must not check it to make the `new' modifier work.
26250 Fixes bug #27999, also added test-147.cs.
26251 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
26253 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
26254 on the method's return type.
26256 2002-07-21 Martin Baulig <martin@gnome.org>
26258 * assign.cs: Make this work if the rightmost source is a constant and
26259 we need to do an implicit type conversion. Also adding a few more tests
26260 to test-38.cs which should have caught this.
26262 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
26263 target in the makefile for this. The makefile.gnu is primarily intended
26264 for end-users who don't want to debug the compiler.
26266 2002-07-21 Martin Baulig <martin@gnome.org>
26268 * assign.cs: Improved the Assign class so it can now handle embedded
26269 assignments (X = Y = Z = something). As a side-effect this'll now also
26270 consume less local variables. test-38.cs now passes with MCS, added
26271 a few new test cases to that test.
26273 2002-07-20 Martin Baulig <martin@gnome.org>
26275 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
26276 instructions. Fixes bug #27977, also added test-146.cs.
26278 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26280 * cs-tokenizer.cs: fixed getHex ().
26282 2002-07-19 Martin Baulig <martin@gnome.org>
26284 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
26285 not Type.GetType() to lookup the array type. This is needed when
26286 we're constructing an array of a user-defined type.
26287 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
26288 single-dimensional arrays, but also for single-dimensial arrays of
26291 2002-07-19 Martin Baulig <martin@gnome.org>
26293 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
26294 this function is called, it's not allowed to share LocalBuilders
26295 among ILGenerators.
26297 2002-07-19 Martin Baulig <martin@gnome.org>
26299 * expression.cs (Argument.Resolve): Report an error 118 when trying
26300 to pass a type as argument.
26302 2002-07-18 Martin Baulig <martin@gnome.org>
26304 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
26305 Conv_R_Un for the signed `long' type.
26307 2002-07-15 Miguel de Icaza <miguel@ximian.com>
26309 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
26310 `expr' for the temporary result, as that will fail if we do
26311 multiple resolves on the same expression.
26313 2002-07-05 Miguel de Icaza <miguel@ximian.com>
26315 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
26316 ec.TypeContainer for looking up aliases.
26318 * class.cs (TypeContainer): Remove LookupAlias from here.
26320 * decl.cs (DeclSpace); Move here.
26322 2002-07-01 Miguel de Icaza <miguel@ximian.com>
26324 * class.cs (FindMembers): Only call filter if the constructor
26325 bulider is not null.
26327 Also handle delegates in `NestedTypes' now. Now we will perform
26328 type lookups using the standard resolution process. This also
26331 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
26332 This uses Expressions (the limited kind that can be parsed by the
26333 tree) instead of strings.
26335 * expression.cs (ComposedCast.ToString): Implement, used to flag
26336 errors since now we have to render expressions.
26338 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
26341 * ecore.cs (SimpleName.ToString): ditto.
26343 * cs-parser.jay: Instead of using strings to assemble types, use
26344 Expressions to assemble the type (using SimpleName, ComposedCast,
26345 MemberAccess). This should fix the type lookups in declarations,
26346 because we were using a different code path for this.
26348 * statement.cs (Block.Resolve): Continue processing statements
26349 even when there is an error.
26351 2002-07-17 Miguel de Icaza <miguel@ximian.com>
26353 * class.cs (Event.Define): Also remove the `remove' method from
26354 the list of pending items.
26356 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
26357 generate more compact code.
26359 2002-07-17 Martin Baulig <martin@gnome.org>
26361 * const.cs (Const.LookupConstantValue): Add support for constant
26362 `unchecked' and `checked' expressions.
26363 Also adding test case test-140.cs for this.
26365 2002-07-17 Martin Baulig <martin@gnome.org>
26367 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26368 check whether mi.ReturnType implements the IEnumerator interface; the
26369 `==' and the IsAssignableFrom() will fail in this situation.
26371 2002-07-16 Ravi Pratap <ravi@ximian.com>
26373 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26376 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26378 * expression.cs: fixed bug #27811.
26380 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26382 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26383 Molaro: when we are a ref, the value already contains a pointer
26384 value, do not take the address of it.
26386 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26387 * removed mb-parser.jay and mb-tokenizer.cs
26389 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26391 * expression.cs: check against the building corlib void type.
26393 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26395 * ecore.cs: fix for valuetype static readonly fields: when
26396 initializing them, we need their address, not the address of a copy.
26398 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26400 * typemanager.cs: register also enum_type in corlib.
26402 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26404 * class.cs: allow calling this (but not base) initializers in structs.
26406 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26408 * ecore.cs: make sure we compare against the building base types
26411 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26413 * typemanager.cs: fix TypeToCoreType() to handle void and object
26414 (corlib gets no more typerefs after this change).
26416 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26418 * expression.cs (ArrayCreation.EmitArrayArguments): use
26419 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26421 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26422 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26423 array indexes, the runtime actually forbids them.
26425 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26426 for array arguments here.
26428 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26429 instead of the default for ValueTypes.
26431 (New.DoEmit): Use IsValueType instead of
26432 IsSubclassOf (value_type)
26433 (New.DoResolve): ditto.
26434 (Invocation.EmitCall): ditto.
26436 * assign.cs (Assign): ditto.
26438 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26439 Statements *are* currently doing part of their resolution during
26442 Expressions do always resolve during resolve, but statements are
26443 only required to propagate resolution to their children.
26445 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26447 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26449 (LoadAssembly): Do not add the dll if it is already specified
26451 (MainDriver): Add the System directory to the link path at the end,
26452 after all the other -L arguments.
26454 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26455 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26456 ldelem.u1) and using the opposite for sbytes.
26458 This fixes Digger, and we can finally run it.
26460 * driver.cs (UnixParseOption): Move the option parsing here.
26461 (CSCParseOption): Implement CSC-like parsing of options.
26463 We now support both modes of operation, the old Unix way, and the
26464 new CSC-like way. This should help those who wanted to make cross
26465 platform makefiles.
26467 The only thing broken is that /r:, /reference: and /lib: are not
26468 implemented, because I want to make those have the same semantics
26469 as the CSC compiler has, and kill once and for all the confussion
26470 around this. Will be doing this tomorrow.
26472 * statement.cs (Unsafe.Resolve): The state is checked during
26473 resolve, not emit, so we have to set the flags for IsUnsfe here.
26475 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26477 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26478 not catch the Error_ObjectRefRequired in SimpleName (as it is
26479 possible to have a class/instance variable name that later gets
26480 deambiguated), we have to check this here.
26482 2002-07-10 Ravi Pratap <ravi@ximian.com>
26484 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26485 make static and put into Expression.
26487 (Event.Define): Register the private field of the event with the
26488 TypeManager so that GetFieldFromEvent can get at it.
26490 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26491 keep track of the private field associated with an event which
26494 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26497 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26499 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26501 * expression.cs (Binary.EmitBranchable): this routine emits the
26502 Binary expression in a branchable context. This basically means:
26503 we need to branch somewhere, not just get the value on the stack.
26505 This works together with Statement.EmitBoolExpression.
26507 * statement.cs (Statement.EmitBoolExpression): Use
26510 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26512 * statement.cs (For): Reduce the number of jumps in loops.
26514 (For): Implement loop inversion for the For statement.
26516 (Break): We can be breaking out of a Try/Catch controlled section
26517 (foreach might have an implicit try/catch clause), so we need to
26518 use Leave instead of Br.
26520 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26521 now). If the instace expression supports IMemoryLocation, we use
26522 the AddressOf method from the IMemoryLocation to extract the
26523 address instead of emitting the instance.
26525 This showed up with `This', as we were emitting the instance
26526 always (Emit) instead of the Address of This. Particularly
26527 interesting when This is a value type, as we dont want the Emit
26528 effect (which was to load the object).
26530 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26532 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26534 * statement.cs (Checked): Set the CheckedState during the resolve
26535 process too, as the ConvCast operations track the checked state on
26536 the resolve process, and not emit.
26538 * cs-parser.jay (namespace_member_declaration): Flag that we have
26539 found a declaration when we do. This is used to flag error 1529
26541 * driver.cs: Report ok when we display the help only.
26543 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26545 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26547 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26549 * cs-tokenizer.cs (define): We also have to track locally the
26550 defines. AllDefines is just used for the Conditional Attribute,
26551 but we also need the local defines for the current source code.
26553 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26555 * statement.cs (While, For, Do): These loops can exit through a
26556 Break statement, use this information to tell whether the
26557 statement is the last piece of code.
26559 (Break): Flag that we break.
26561 * codegen.cs (EmitContexts): New `Breaks' state variable.
26563 2002-07-03 Martin Baulig <martin@gnome.org>
26565 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26566 modifiers in method declarations in structs. Otherwise, you won't
26567 be able to override things like Object.Equals().
26569 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26571 * class.cs (Method, Property, Indexer): Do not allow the public
26572 modifier to be used in explicit interface implementations.
26574 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26575 override modifiers in method declarations in structs
26577 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26579 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26580 integer or real overflow, report an error
26582 2002-07-02 Martin Baulig <martin@gnome.org>
26584 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26585 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26586 to tell the runtime about our newly created System.Object and
26587 System.ValueType types.
26589 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26591 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26592 struct instead of Ldarg/Starg.
26594 2002-07-02 Martin Baulig <martin@gnome.org>
26596 * expression.cs (Indirection.Indirection): Call
26597 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26599 2002-07-02 Martin Baulig <martin@gnome.org>
26601 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26602 ValueType, call TypeManager.TypeToCoreType() on it.
26603 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26604 the OpCodes.Newarr argument.
26606 2002-07-02 Martin Baulig <martin@gnome.org>
26608 * expression.cs (Invocation.EmitCall): When compiling corlib,
26609 replace all calls to the system's System.Array type to calls to
26610 the newly created one.
26612 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26613 System.Array methods.
26614 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26615 from the system's System.Array type which must be replaced.
26617 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26619 * typemanager.cs: load unverifiable_code_ctor so we can build
26620 corlib using the correct type. Avoid using GetTypeCode() with
26622 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26623 TypeManager.object_type to allow building corlib.
26625 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26627 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26629 2002-07-01 Martin Baulig <martin@gnome.org>
26631 * class.cs: Make the last change actually work, we need to check
26632 whether `ifaces != null' to avoid a crash.
26634 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26636 * class.cs: when we build structs without fields that implement
26637 interfaces, we need to add the interfaces separately, since there is
26638 no API to both set the size and add the interfaces at type creation
26641 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26643 * expression.cs: the dimension arguments to the array constructors
26644 need to be converted if they are a long.
26646 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26648 * class.cs: don't emit ldarg.0 if there is no parent constructor
26649 (fixes showstopper for corlib).
26651 2002-06-29 Martin Baulig <martin@gnome.org>
26653 MCS now compiles corlib on GNU/Linux :-)
26655 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26656 ie. check for MethodImplOptions.InternalCall.
26658 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26659 and TypeManager.attribute_type are null, so we must explicitly check
26660 whether parent is not null to find out whether it's an attribute type.
26661 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26662 and SetBuilder, not only if the property is neither abstract nor external.
26663 This is necessary to set the MethodImplOptions on the accessor methods.
26664 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26665 SetBuilder, see Property.Emit().
26667 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26668 populate "System.Object", "System.ValueType" and "System.Attribute" since
26669 they've already been populated from BootCorlib_PopulateCoreTypes().
26671 2002-06-29 Martin Baulig <martin@gnome.org>
26673 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26674 is the NullLiteral, we also need to make sure that target_type is not
26677 2002-06-29 Martin Baulig <martin@gnome.org>
26679 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26680 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26681 before calling BootstrapCorlib_ResolveDelegate ().
26683 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26685 * statement.cs: fixed build-breaker. All tests passed ok.
26687 2002-06-27 Martin Baulig <martin@gnome.org>
26689 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26690 for System.Decimal when compiling corlib.
26692 2002-06-27 Martin Baulig <martin@gnome.org>
26694 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26695 switch blocks which contain nothing but a default clause.
26697 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26699 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26701 2002-06-27 Martin Baulig <martin@gnome.org>
26703 * ecore.cs (PropertyExpr.PropertyExpr): Call
26704 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26706 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26707 is already a TypeBuilder.
26709 2002-06-27 Martin Baulig <martin@gnome.org>
26711 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26712 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26713 the "from an array-type to System.Array" case. This makes it work
26714 when compiling corlib.
26716 2002-06-27 Martin Baulig <martin@gnome.org>
26718 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26719 non-static PropertyExpr, set its InstanceExpression. This makes
26720 the `ICollection.Count' property work in System/Array.cs.
26722 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26724 * driver.cs: Made error handling more consistent. Errors now
26725 tracked by Report class, so many methods which used to return int
26726 now return void. Main() now prints success/failure and
26727 errors/warnings message.
26729 Renamed '--probe' compiler argument to '--expect-error'. Removed
26730 the magic number return values (123 and 124). Now, if the
26731 expected error occurs, the compiler exits with success (exit value
26732 0). If the compilation completes without seeing that particular
26733 error, the compiler exits with failure (exit value 1). The
26734 makefile in mcs/errors has been changed to handle the new behaviour.
26736 * report.cs: Made 'expected error' number a property and renamed
26737 it from 'Probe' to 'ExpectedError'.
26739 * genericparser.cs: Removed error handling support, since it is
26740 now all done by Report class.
26742 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26743 class, so parse() no longer returns an int.
26745 * namespace.cs: Use Report.Error instead of GenericParser.error
26747 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26749 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26750 TypeContainer.AddOperator): At the front of the list put the
26751 explicit implementations, so they get resolved/defined first.
26753 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26755 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26756 interface type is implemented by this TypeContainer. Used during
26757 explicit interface implementation.
26759 (Property.Define, Indexer.Define, Method.Define): Validate that
26760 the given interface in the explicit implementation is one of the
26761 base classes for the containing type.
26763 Also if we are explicitly implementing an interface, but there is
26764 no match in the pending implementation table, report an error.
26766 (Property.Define): Only define the property if we are
26767 not explicitly implementing a property from an interface. Use the
26768 correct name also for those properties (the same CSC uses,
26769 although that is really not needed).
26771 (Property.Emit): Do not emit attributes for explicitly implemented
26772 properties, as there is no TypeBuilder.
26774 (Indexer.Emit): ditto.
26776 Hiding then means that we do not really *implement* a pending
26777 implementation, which makes code fail.
26779 2002-06-22 Martin Baulig <martin@gnome.org>
26781 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26782 the return value of Object.GetType(). [FIXME: we need to do this whenever
26783 we get a type back from the reflection library].
26785 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26787 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26789 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26791 * attribute.cs: Return null if we can not look up the type.
26793 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26794 the interface types found.
26796 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26797 interface types found.
26799 * typemanager.cs (GetInterfaces): Make this routine returns alll
26800 the interfaces and work around the lame differences between
26801 System.Type and System.Reflection.Emit.TypeBuilder in the results
26802 result for GetInterfaces.
26804 (ExpandInterfaces): Given an array of interface types, expand and
26805 eliminate repeated ocurrences of an interface. This expands in
26806 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26809 2002-06-21 Martin Baulig <martin@gnome.org>
26811 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26814 2002-06-21 Martin Baulig <martin@gnome.org>
26816 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26817 and called with one of the core types, return the corresponding typebuilder for
26820 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26823 2002-06-21 Martin Baulig <martin@gnome.org>
26825 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26826 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26827 (Expression.ConvertReferenceExplicit): Likewise.
26829 * expression.cs (ElementAccess.DoResolve): Likewise.
26830 (ElementAccess.DoResolveLValue): Likewise.
26832 2002-06-10 Martin Baulig <martin@gnome.org>
26834 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26835 add the "value" parameter to the parameter list.
26837 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26840 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26842 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26843 the argument to an int, uint, long or ulong, per the spec. Also
26844 catch negative constants in array creation.
26846 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26848 * class.cs: do not allow the same interface to appear twice in
26849 the definition list.
26851 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26853 * ecore.cs: don't use ldlen with System.Array.
26855 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26857 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26859 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26861 * modifiers.cs: produce correct field attributes for protected
26862 internal. Easy fix so miguel can work on ther harder stuff:-)
26864 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26866 * pending.cs: New file. Move the code from class.cs here.
26867 Support clearning the pending flag for all methods (when not doing
26868 explicit interface implementation).
26870 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26872 * rootcontext.cs: added a couple more types needed to bootstrap.
26874 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26876 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26877 constructor in the type, instead of any constructor in the type
26878 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26879 a bug in the Mono runtime when applying the params attribute).
26881 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26882 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26884 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26886 * expression.cs (Unary.ResolveOperator): Use TypeManager
26887 to resolve the type.
26889 2002-06-13 Ravi Pratap <ravi@ximian.com>
26891 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26894 * enum.cs (AddEnumMember): Add support to store the attributes associated
26895 with each member too.
26897 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26898 field builders too - this takes care of the enum member case.
26900 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26902 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26903 address-of operator on both value types and pointers.
26905 2002-06-10 Martin Baulig <martin@gnome.org>
26907 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26908 PropertyBuilder to the `property_builders' list.
26910 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26911 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26912 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26913 find any indexers which are inherited from an interface.
26915 2002-06-09 Martin Baulig <martin@gnome.org>
26917 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26918 the same type as the constant if necessary. There's also a test-130.cs
26921 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26923 * typemanager.cs (TypeManager.ChangeType): Previously known as
26924 Enum.ChangeEnumType().
26926 2002-06-09 Martin Baulig <martin@gnome.org>
26928 * expression.cs (Cast.TryReduce): Added support for consts.
26930 2002-06-08 Ravi Pratap <ravi@ximian.com>
26932 * class.cs (Accessor): Hold attributes information so we can pass
26935 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26936 Modify to pass in attributes attached to the methods.
26938 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26940 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26941 to handle the Accessor kind :-)
26943 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26945 2002-06-08 Martin Baulig <martin@gnome.org>
26947 * expression.cs (Unary.TryReduceNegative): Added support for
26950 2002-06-08 Martin Baulig <martin@gnome.org>
26952 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26953 name can't be found in the `defined_names' - the caller will do a
26954 MemberLookup in this case and thus find methods in System.Enum
26955 such as Enum.IsDefined().
26957 2002-06-08 Martin Baulig <martin@gnome.org>
26959 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26960 Convert.ChangeType() which works with TypeBuilder created types.
26961 (Enum.LookupEnumValue, Enum.Define): Use it here.
26963 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26964 `TypeBuilder.BaseType != null' check.
26965 (TypeContainer.FindMembers): Only lookup parent members if we
26966 actually have a parent.
26967 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26968 (ConstructorInitializer.Resolve): Likewise.
26970 * interface.cs (Interface.FindMembers): Added
26971 `TypeBuilder.BaseType != null' check.
26973 * rootcontext.cs (RootContext.ResolveCore): Added
26974 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26975 classes_second_stage.
26977 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26978 debug_type and trace_type when compiling with --nostdlib.
26980 2002-06-07 Martin Baulig <martin@gnome.org>
26982 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26983 (AddField): Set it to true when adding a non-static field.
26984 (DefineType): Use `have_nonstatic_fields' to find out whether we
26985 have non-static fields, not `Fields != null'.
26987 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26989 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26990 dereferencing a null on the static-field code path)
26992 2002-05-30 Martin Baulig <martin@gnome.org>
26994 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26995 to take command line arguments. Use reflection to call the new
26996 custom `Initialize' function on the symbol writer and pass it the
26997 command line arguments.
26999 * driver.cs (--debug-args): New command line argument to pass command
27000 line arguments to the symbol writer.
27002 2002-05-28 Miguel de Icaza <miguel@ximian.com>
27004 * assign.cs (DoResolve): Forgot to do the implicit conversion to
27005 the target type for indexers and properties. Thanks to Joe for
27008 2002-05-27 Miguel de Icaza <miguel@ximian.com>
27010 * typemanager.cs (MethodFlags): returns the method flags
27011 (Obsolete/ShouldIgnore) that control warning emission and whether
27012 the invocation should be made, or ignored.
27014 * expression.cs (Invocation.Emit): Remove previous hack, we should
27015 not do this on matching a base type, we should do this based on an attribute
27017 Only emit calls to System.Diagnostics.Debug and
27018 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
27019 on the command line.
27021 * rootcontext.cs: Global settings for tracing and debugging.
27023 * cs-tokenizer.cs (define): New utility function to track
27024 defines. Set the global settings for TRACE and DEBUG if found.
27026 2002-05-25 Ravi Pratap <ravi@ximian.com>
27028 * interface.cs (Populate*): Pass in the TypeContainer as well as
27029 the DeclSpace as parameters so that we can create EmitContexts and
27030 then use that to apply attributes etc.
27032 (PopulateMethod, PopulateEvent, PopulateProperty)
27033 (PopulateIndexer): Apply attributes everywhere.
27035 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
27038 (ApplyAttributes): Update accordingly.
27040 We now apply interface attributes for all members too.
27042 2002-05-26 Miguel de Icaza <miguel@ximian.com>
27044 * class.cs (Indexer.Define); Correctly check if we are explicit
27045 implementation (instead of checking the Name for a ".", we
27046 directly look up if the InterfaceType was specified).
27048 Delay the creation of the PropertyBuilder.
27050 Only create the PropertyBuilder if we are not an explicit
27051 interface implementation. This means that explicit interface
27052 implementation members do not participate in regular function
27053 lookups, and hence fixes another major ambiguity problem in
27054 overload resolution (that was the visible effect).
27056 (DefineMethod): Return whether we are doing an interface
27059 * typemanager.cs: Temporary hack until we get attributes in
27060 interfaces (Ravi is working on that) and we get IndexerName
27061 support in interfaces.
27063 * interface.cs: Register the indexers as properties.
27065 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
27066 warning, I have verified that this is a bug in the .NET runtime
27067 (JavaScript suffers of the same problem).
27069 * typemanager.cs (MemberLookup): When looking up members for
27070 interfaces, the parent of an interface is the implicit
27071 System.Object (so we succeed in searches of Object methods in an
27072 interface method invocation. Example: IEnumerable x; x.ToString
27075 2002-05-25 Miguel de Icaza <miguel@ximian.com>
27077 * class.cs (Event): Events should also register if they do
27078 implement the methods that an interface requires.
27080 * typemanager.cs (MemberLookup); use the new GetInterfaces
27083 (GetInterfaces): The code used to lookup interfaces for a type is
27084 used in more than one place, factor it here.
27086 * driver.cs: Track the errors at the bottom of the file, we kept
27089 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
27090 instance if the method we are calling is static!
27092 2002-05-24 Miguel de Icaza <miguel@ximian.com>
27094 * attribute.cs (ApplyAttributes): Make this function filter out
27095 the IndexerName attribute (as that attribute in reality is never
27096 applied) and return the string constant for the IndexerName
27099 * class.cs (TypeContainer.Emit): Validate that all the indexers
27100 have the same IndexerName attribute, and if so, set the
27101 DefaultName attribute on the class.
27103 * typemanager.cs: The return value might contain other stuff (not
27104 only methods). For instance, consider a method with an "Item"
27105 property and an Item method.
27107 * class.cs: If there is a problem with the parameter types,
27110 2002-05-24 Ravi Pratap <ravi@ximian.com>
27112 * ecore.cs (ImplicitConversionExists): Wrapper function which also
27113 looks at user defined conversion after making a call to
27114 StandardConversionExists - we need this for overload resolution.
27116 * expression.cs : Update accordingly the various method calls.
27118 This fixes 2 bugs filed against implicit user defined conversions
27120 2002-05-22 Miguel de Icaza <miguel@ximian.com>
27122 * statement.cs: Track the result of the assignment.
27124 2002-05-21 Miguel de Icaza <miguel@ximian.com>
27126 * expression.cs (MemberAccess): Improved error reporting for
27127 inaccessible members.
27129 2002-05-22 Martin Baulig <martin@gnome.org>
27131 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
27132 itself with debugging support.
27134 2002-05-22 Martin Baulig <martin@gnome.org>
27136 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
27137 Removed, this isn't needed anymore.
27139 2002-05-20 Martin Baulig <martin@gnome.org>
27141 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
27142 be underlying type for an enum.
27144 2002-05-20 Miguel de Icaza <miguel@ximian.com>
27146 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
27147 that splits out the loading of just the core types.
27149 * rootcontext.cs (ResolveCore): Split the struct resolution in
27150 two, so we can load the enumeration underlying types before any
27153 * expression.cs (Is): Bandaid until we fix properly Switch (see
27154 bug #24985 for details).
27156 * typemanager.cs (ImplementsInterface): The hashtable will contain
27157 a null if there are no interfaces implemented.
27159 2002-05-18 Miguel de Icaza <miguel@ximian.com>
27161 * cs-parser.jay (indexer_declarator): It is fine to have array
27164 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27166 * typemanager.cs: (RegisterBuilder): New function used to register
27167 TypeBuilders that implement interfaces. Since
27168 TypeBuilder.GetInterfaces (as usual) does not work with lame
27170 (AddUserType): register interfaces.
27172 (ImplementsInterface): Use the builder_to_ifaces hash if we are
27173 dealing with TypeBuilder. Also, arrays are showing up as
27174 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
27175 methods can not be invoked on them!
27177 * ecore.cs (ExplicitReferenceConversionExists): Made public.
27178 (ImplicitReferenceConversionExists): Split out from
27179 StandardConversionExists.
27181 * expression.cs (As): We were only implementing one of the three
27182 cases for the as operator. We now implement them all.
27183 (Is): Implement the various other cases for Is as well.
27185 * typemanager.cs (CACHE): New define used to control if we want or
27186 not the FindMembers cache. Seems to have a negative impact on
27187 performance currently
27189 (MemberLookup): Nested types have full acess to
27190 enclosing type members
27192 Remove code that coped with instance/static returns for events, we
27193 now catch this in RealFindMembers.
27195 (RealFindMembers): only perform static lookup if the instance
27196 lookup did not return a type or an event.
27198 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27200 * assign.cs (CompoundAssign): We pass more semantic information
27201 now to Compound Assignments than we did before: now we have all
27202 the information at hand, and now we resolve the target *before* we
27203 do the expression expansion, which allows the "CacheValue" method
27204 to have the effect we intended (before, a [x] += 1 would generate
27205 two differen ArrayAccess expressions from the ElementAccess,
27206 during the resolution process).
27208 (CompoundAssign.DoResolve): Resolve target and original_source here.
27210 2002-05-16 Miguel de Icaza <miguel@ximian.com>
27212 * expression.cs (ArrayAccess): dropped debugging information.
27214 * typemanager.cs: Small bug fix: I was always returning i_members,
27215 instead of one of i_members or s_members (depending on which had
27218 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
27219 method is invoked before any code generation takes place, and it
27220 is a mechanism to inform that the expression will be invoked more
27221 than once, and that the method should use temporary values to
27222 avoid having side effects
27224 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
27226 * ecore.cs (Expression.CacheTemporaries): Provide empty default
27229 * expression.cs (Indirection, ArrayAccess): Add support for
27230 CacheTemporaries in these two bad boys.
27232 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
27233 ldobj or ldind_ref.
27234 (StoreFromPtr): Handle stobj as well.
27236 * expression.cs (UnaryMutator): Share more code.
27238 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
27239 down: I was not tracking the Filter function as well, which
27240 was affecting the results of the cache.
27242 2002-05-15 Miguel de Icaza <miguel@ximian.com>
27244 * attribute.cs: Remove the hack to handle the CharSet property on
27247 2002-05-14 Miguel de Icaza <miguel@ximian.com>
27249 * attribute.cs (DoResolve): More uglyness, we now only try to
27250 resolve the attribute partially, to extract the CharSet
27251 information (only if we are a StructLayout attribute). Otherwise
27253 (GetExtraTypeInfo): Add some code to conditionally kill in the
27254 future this. I am more and more convinced that the .NET
27255 framework has special code to handle the attribute setting on
27258 * expression.cs (IsParamsMethodApplicable): Revert my previous
27259 foreach change here, it was wrong.
27261 2002-05-13 Miguel de Icaza <miguel@ximian.com>
27263 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
27264 (pp_expr): do not abort on unknown input, just return.
27265 (eval): abort if there are pending chars.
27267 * attribute.cs (Attribute.Resolve): Positional parameters are
27268 optional. Deal with that case.
27270 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
27271 the Ansi/Unicode/Auto information for the type.
27273 (TypeContainer.DefineType): instantiate the EmitContext here, as
27274 we will be using it during the type definition (to resolve
27275 attributes) and during the emit phase.
27277 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
27278 to pull type information out of the attributes
27280 (Attribute.Resolve): track the constructor builder, and allow for
27281 multiple invocations (structs and classes will use this).
27283 * ecore.cs (MemberLookupFinal): new version with all the
27284 parameters customizable.
27286 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
27287 constructors. Return if the result value is null (as the error
27288 would have been flagged already by MemberLookupFinal)
27290 Do not allow instances of abstract classes or interfaces to be
27293 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
27294 We have to compare the assembly property here when dealing with
27295 FamANDAssem and Assembly access modifiers, because we might be
27296 creating an assembly from *modules* (that means that we are not
27297 getting TypeBuilders for types defined in other modules that are
27298 part of this assembly).
27300 (Method.Emit): If the method is marked abstract and has a body,
27303 (TypeContainer.DefineMembers): If both the defined member and the
27304 parent name match are methods, then do not emit any warnings: let
27305 the Method.Define routine take care of flagging warnings. But if
27306 there is a mismatch (method overrides something else, or method is
27307 overriwritten by something, then emit warning).
27309 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
27310 set to null, this means `do not check for the return type on the
27313 (Method.Define): set the return type for the method signature to
27314 null, so that we get methods with the same name and parameters and
27315 different return types. This is used to flag warning 114 (you are
27316 hiding a method, and you probably want to use the new/override
27319 * typemanager.cs (MemberLookup): Implemented proper access
27320 control, closing a long standing set of bug reports. The problem
27321 was that the Framework only has two bits: Public and NonPublic,
27322 and NonPublic includes private and protected methods, but we need
27323 to enforce the FamANDAssem, FamOrAssem and Family.
27325 2002-05-11 Miguel de Icaza <miguel@ximian.com>
27327 * statement.cs (GotoCase): Return true: Ammounts to giving up
27328 knowledge on whether we return or not, and letting the other case
27329 be responsible for it.
27331 2002-05-10 Miguel de Icaza <miguel@ximian.com>
27333 * driver.cs: Do not load directories for each file processed, only
27334 do it if there is a pattern.
27336 * ecore.cs: Report readonly assigns here as well, as we might have
27337 been resolved only by MemberAccess.
27339 (SimpleName.SimpleNameResolve): Also be useful for LValue
27340 resolution. We need this to propagate assign to local readonly variables
27342 * typemanager.cs: Use a ptrhashtable for the criteria, because we
27343 do not want to reuse potential criteria memory.
27345 * class.cs (MyEventBuilder): Set reflected_type;
27347 * ecore.cs (Constantify): Added support for constifying bools.
27349 (RootContext.LookupType): Added a cache for values looked up in
27350 the declaration space.
27352 * typemanager.cs (FindMembers): Now is a front-end to
27353 RealFindMembers, and provides a two-level hashtable-based cache to
27356 15% performance improvement: from 22.5 to 19.2 seconds.
27358 * expression.cs (IsParamsMethodApplicable): use foreach.
27359 (Invocation.DoResolve): ditto.
27360 (New.DoResolve): ditto.
27361 (ArrayCreation.DoResolve): ditto.
27363 * ecore.cs (FindMostEncompassingType): use foreach.
27365 * delegate.cs (NewDelegate.DoResolve): Use foreach
27367 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27368 (RemoveMethods): use foreach.
27370 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27371 nested foreach statements instead of for, and also break out of
27372 the inner loop once a match is found.
27374 (Invocation.OverloadResolve): Use foreach, simplify the code.
27376 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27378 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27379 we actually unwrap the expression to allow for extra information
27382 * expression.cs: Use Shr_Un on unsigned operations.
27384 2002-05-08 Ravi Pratap <ravi@ximian.com>
27386 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27387 applicable operators was not being considered correctly. This closes
27388 the bug Miguel reported.
27390 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27392 * attribute.cs: check that the type derives from System.Attribute
27393 and report the correct error in that case (moved the duplicate code to
27394 its own method, too).
27396 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27398 * attribute.cs: lookup attribute type name as the spec says: first the
27399 bare attribute name and then name + "Attribute" (nant compiles with
27400 mcs after this fix).
27402 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27404 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27405 Because of the way we parse things, we should try to see if a
27406 UIntConstant can fit in an integer.
27408 2002-05-07 Ravi Pratap <ravi@ximian.com>
27410 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27411 when we are in an explicit context.
27413 (ConvertReferenceExplicit): When converting from Iface type S to Class
27414 T make sure the rules are implemented as an OR.
27416 * parameter.cs (ParameterType): Make it a property for now although the
27417 purpose really isn't anything immediate.
27419 * expression.cs (Is*Applicable): Do better checking on the parameter type
27420 of a ref/out parameter. The ones from the system assemblies are already
27421 marked with the correct type so we don't need to do any correction.
27423 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27424 the object type is standard too so include that.
27426 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27428 * ecore.cs (StandardConversionExists): Augment with missing code:
27429 deal with IntConstant, LongConstants and Enumerations.
27431 * assign.cs: Report the error, instead of failing silently
27433 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27434 typecontainer that they are declared, because the
27435 typecontainer/namespace will have the list of using clauses that
27436 need to be applied.
27438 Assembly Attributes were escaping the normal registration
27441 (EmitCode): Apply attributes within an EmitContext that represents
27442 the container they were declared on.
27444 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27446 2002-05-06 Ravi Pratap <ravi@ximian.com>
27448 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27449 Revamp completely - make much cleaner as we now operate only
27452 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27453 to implement the logic detailed in the spec more correctly.
27455 (UserDefinedConversion): Update accordingly.
27457 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27459 * statement.cs: Return flow analysis information up.
27461 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27464 (token): Do not consume an extra character before calling
27467 2002-05-06 Piers Haken <piersh@friskit.com>
27469 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27471 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27473 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27474 EmitContext during the instance constructor initializer
27475 resolution, to stop access to instance variables.
27477 This is mandated by the spec, last paragraph of the `constructor
27478 initializers' section.
27480 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27482 * cs-parser.jay, class.cs (Accessor): new class used to represent
27483 an accessor (get or set). In the past we used `null' to represent
27484 a missing accessor. But this is ambiguous because there was no
27485 way to tell in abstract indexers/properties if one of them was
27488 Now there is a way of addressing that.
27490 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27491 instead of FindMembers.
27493 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27494 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27496 * attribute.cs: Treat indexers and properties as the same in terms
27497 of applying attributes
27499 * ecore.cs (FindMostEncompassedType): Use statically initialized
27500 EmptyExpressions()s like we do elsewhere to avoid creating useless
27501 objects (and we take this out of the tight loop).
27503 (GetConversionOperators): Move the code to extract the actual
27504 operators to a separate routine to clean things up.
27506 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27508 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27509 events are always registered FieldBuilders.
27511 * class.cs (FieldBase): New class shared by Fields
27513 * delegate.cs: If we are a toplevel delegate, use our full name.
27514 If we are a nested delegate, then only use our tail name.
27516 2002-05-02 Ravi Pratap <ravi@ximian.com>
27518 * expression.cs (IsApplicable): Ensure that we add the "&" to
27519 ref/out types before comparing it with the type of the argument.
27521 (IsParamsMethodApplicable): Ditto.
27523 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27526 * delegate.cs : Handle the case when we have more than one applicable
27527 method. Flag an error only when we finish checking all.
27529 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27531 * expression.cs: Add support for boolean static initializers.
27533 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27535 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27537 * parameter.cs (ComputeParameterTypes,
27538 ComputeAndDefineParameterTypes): Better error handling: now we
27539 clear the `types' cache if we fail during any of the type lookups.
27540 We also return the status code correctly to our caller
27542 * delegate.cs: If we fail to define a delegate, abort the extra
27545 * expression.cs (Binary.ResolveOperator): for
27546 operator==(object,object) and operator !=(object, object) we also
27547 have to verify that there is an implicit conversion from one to
27550 (ArrayAccess.DoResolve): Array Access can operate on
27553 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27555 * assign.cs (CompoundAssign): A new class used as a "flag" that
27556 the assignment actually is happening as part of a compound
27557 assignment operator.
27559 During compound assignment, a few new rules exist to enable things
27566 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27567 to the type of x) if y is implicitly convertible to the type of x,
27568 and the operator is a builtin operator and the return type of the
27569 operator is explicitly convertible to the type of x.
27571 * rootcontext.cs: Reset warning level to 2. 4 catches various
27572 "interesting" features in mcs, we must clean this up at some
27573 point, but currently am trying to kill other bugs ;-)
27575 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27576 in container classes as well.
27578 * expression.cs (Binary.ResolveOperator): Handle string case
27579 before anything else (as operator overloading does emit an error
27580 before doing anything else).
27582 This code could go away when we move to a table driven model, but
27583 i could not come up with a good plan last night.
27585 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27587 * typemanager.cs (CSharpName): reimplementation using regex.
27588 * class.cs: added null check for fields in Emit
27589 * rootcontext.cs: set warninglevel to 4
27591 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27593 * typemanager.cs (CSharpName): reimplemented with Lupus
27596 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27598 * statement.cs (If): correclty implement Resolve, because we were
27599 not catching sem errors in there. The same process is needed
27601 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27604 (Statement.Warning_DeadCodeFound): Factorize code.
27605 (While): Report dead code here too.
27607 (Statement): Added Resolve virtual method to allow
27608 for resolution split from the emit code.
27610 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27612 * statement.cs (EmitBoolExpression): No longer try to resolve the
27614 (MakeBoolean): New utility function that resolve, implicitly
27615 converts to boolean and tags the expression.
27618 (If, Do): Implement dead code elimination.
27619 (While): Implement loop inversion
27621 (Do, While, For, If): Resolve the expression prior to calling our
27624 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27627 - added method Report28 (warning: program has more than one entry point)
27628 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27629 - modified method Method.Define, the part at the end of the method
27631 * rootcontext.cs: added static public Location EntryPointLocation;
27633 * ../errors/cs0028.cs : Add test case for the above warning.
27636 - modified method CSharpName to allow arrays of primitive type to
27637 be printed nicely (e.g. instead of System.Int32[][] it now prints
27639 - added method CSharpSignature: returns the signature of a method
27640 in string format to be used in reporting errors, warnings, etc.
27642 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27645 2002-04-26 Ravi Pratap <ravi@ximian.com>
27647 * delegate.cs (Define): Fix extremely silly bug where I was
27648 setting the type of the 'object' parameter of the BeginInvoke
27649 method to System.IAsyncResult instead of System.Object ;-)
27651 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27653 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27656 (Constructor.Emit): return if we fail to initialize the
27657 constructor. Another door closed!
27659 * expression.cs (New.DoResolve): Improve error message (from -6 to
27660 1501). Use DeclaredOnly lookup to find the exact constructor.
27662 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27663 loop. This is useful.
27665 * cs-parser.jay: Adjust the default parameters so that destructors
27666 have the proper signature.
27668 2002-04-26 Martin Baulig <martin@gnome.org>
27670 * driver.cs (LoadAssembly): If `assembly' contains any characters
27671 which are only valid in path names and not in assembly names
27672 (currently slash, backslash and point), use Assembly.LoadFrom ()
27673 instead of Assembly.Load () on the `assembly' (before iteration
27674 over the link_paths).
27676 2002-04-26 Martin Baulig <martin@gnome.org>
27678 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27680 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27682 * class.cs (Property): use the new typemanager.MemberLookup
27684 (TypeContainer.MemberLookup): Implement using the
27685 TypeManager.MemberLookup now.
27687 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27688 and return MemberInfos, so that these can be used without an
27689 EmitContext (what we had before).
27691 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27693 * expression.cs: Fix the case where the argument to params if the
27694 type of the params. I omitted handling this before. Fixed
27696 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27698 * driver.cs: Call BootCorlib_PopulateCoreType
27700 * class.cs (Property.CheckBase): Check for properties only, not
27703 * interface.cs: Temporary hack: try/catch around the
27704 CustomAttributeBuilder, because I am getting an exception that I
27707 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27708 types whose definitions are required to be there (attributes are
27709 defined before standard types).
27711 Compute definitions as we boot the various types, as they are used
27712 immediately (value_type class will need object_type, but if we do
27713 not initialize object_type, we will pass a null, which will let
27714 the runtime pick the System.Object from the existing corlib, which
27715 is not what we want).
27717 2002-04-22 Patrik Torstensson <totte@labs2.com>
27719 * cs-tokenizer.cs: fixed a number of trim() issues.
27721 2002-04-22 Ravi Pratap <ravi@ximian.com>
27723 * expression.cs (Argument.Type): Ensure that we return the correct
27724 type when we have out or ref parameters [in which case we
27727 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27729 * class.cs (Property, Indexer): Allow extern modifier in there.
27731 * typemanager.cs (InitBaseTypes): Initializes object_type and
27732 value_type, since those will be used early on during the bootstrap
27733 process to compile corlib.
27735 (InitCoreTypes): Move code from here to InitBaseTypes.
27737 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27739 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27740 single-dimension arrays as using the ldlen opcode.
27742 Daniel Lewis discovered this optimization.
27744 * typemanager.cs: Add signature for System.Array::get_Length
27746 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27748 * statement.cs: report the error when the foreach does not apply to an
27749 array nor a collection.
27751 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27753 * expression.cs: Add implicit conversions to the operator ~.
27755 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27757 * typemanager.cs: Locate the decimal constructor.
27759 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27761 * attribute.cs: use the new property of TypeOf.
27762 * expression.cs: added 'get' property around typearg.
27764 These changes fix a build breaker reported by NickD. Is this the
27765 correct way to fix? If not, please, revert my changes and make it
27768 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27770 * attribute.cs: Add support for typeof in attribute invocations.
27771 I am not sure that this is right though.
27773 2002-04-14 Duncan Mak <duncan@ximian.com>
27775 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27776 Binary.Operator.Division case.
27778 2002-04-13 Ravi Pratap <ravi@ximian.com>
27780 * class.cs (DefineType): Ensure that we do a proper check on
27781 attribute types and also register it with the TypeManager.
27783 (TypeContainer.Targets): The default for attribute types is
27784 AttributeTargets.All.
27786 * attribute.cs (ApplyAttributes): Registering the attribute type
27787 is done elsewhere, not when we discover we have a Usage attribute.
27789 2002-04-12 Ravi Pratap <ravi@ximian.com>
27791 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27792 and get rid of is_delegate parameter.
27794 * everywhere : update.
27796 2002-04-12 Ravi Pratap <ravi@ximian.com>
27798 * cs-parser.jay (compilation_unit): Revamp completely to use
27799 some new ideas that I got from Rhys' grammar to solve the problems
27800 with assembly level attributes.
27802 (outer_declaration): New grammar production.
27804 (attribute_sections): Add.
27806 (opt_attributes): Base on attribute_sections
27808 (namespace_declaration): Allow opt_attributes to tackle the case
27809 when we have assembly level attributes - we are clever in this
27812 * attribute.cs (ApplyAttributes): Do not worry about assembly
27813 attributes in the non-global context.
27815 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27816 instead of SetGlobalAttributes.
27818 * class.cs, rootcontext.cs : Ensure we define and generate
27819 attribute types before anything else.
27821 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27822 and flag the new error -20 for the case when the attribute type
27823 does not have valid targets specified. csc does not catch this.
27825 * ../errors/errors.txt : update for error # -20
27827 2002-04-11 Ravi Pratap <ravi@ximian.com>
27829 * support.cs (InternalParameters.ParameterModifier): Do some null
27830 checking and return sane values.
27832 * class.cs (Method.Define): If we are a PInvoke method, ensure
27833 that we are static and extern. Report error # 601
27835 * ../errors/cs0601.cs : Add test case for the above error.
27837 2002-04-07 Ravi Pratap <ravi@ximian.com>
27839 * rootcontext.cs (attribute_types): We need to keep type of
27840 all attribute types separately and emit code for them first.
27842 (RegisterAttribute) : Implement.
27844 * class.cs (DefineType): Check if the current Type is a custom
27845 attribute type and register it accordingly.
27847 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27848 adding the first attribute twice and rename to
27850 (SetGlobalAttributes): this.
27852 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27855 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27856 if we are processing global arguments. Hmm, I am unsure of this.
27858 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27860 * expression.cs: added static array of strings to avoid calling
27861 Enum.ToString () for Operator in Binary. Significant recover of
27864 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27866 * class.cs (FindMembers): Allow the Builders of the various
27867 members to be null. If they are skip them. This only happens
27868 during the PInvoke declaration.
27870 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27872 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27873 failure, so we do not keep going afterwards.
27875 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27876 wanted to pass `false' as the `is_delegate' argument. If this is
27877 the case, why not use delegate_type == null to mean `is_delegate =
27878 false' and anything else as is_delegate = true.
27880 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27882 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27883 code for the section, not the beginning of the tests.
27885 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27887 * cfold.cs: Handle operator + (Enum x, Underlying x)
27889 * expression.cs (Binary): same. Warn about errors where we have
27890 Enum/Enum in operator + as well.
27892 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27895 - added support for switch(bool)
27896 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27897 - add TableSwitchEmit() to handle table-based switch statements
27899 2002-04-05 Ravi Pratap <ravi@ximian.com>
27901 * expression.cs (Invocation.OverloadResolve): Factor out code which
27902 does parameter compatibility checking with arguments so that we can
27903 re-use the code even from Delegate.VerifyApplicability
27905 (VerifyArgumentsCompat): Move above code here.
27907 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27908 and instead make a call to the above method.
27910 2002-03-31 Ravi Pratap <ravi@ximian.com>
27912 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27913 We use it to keep track of classes which are attribute types.
27915 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27917 * delegate.cs (Delegate.Define): Correctly define the types in the
27918 presence of fixed and array parameters.
27920 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27923 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27924 include NonPublic after the first iteration.
27926 * class.cs (Indexer.CheckBase): Only check if both parents are
27929 * cs-parser.jay (accessor_body): If empty, set to null.
27931 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27932 same code path here to resolve constants names that we did have in
27933 MemberAccess.DoResolve. There is too much code duplicated here.
27935 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27937 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27939 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27942 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27943 tokens, numbers and strings.
27945 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27948 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27949 asyncronous parameters and the regular parameters.
27951 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27952 specify the target directory.
27954 * expression.cs: (This.DoResolve): Simplify
27955 (As.Emit): Optimize, do not generate IsInst if the expression is
27956 always of the given type.
27958 (Is.DoResolve): Bug fix, we were reporting both always/never for
27961 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27962 creating too many unnecessary arrays.
27964 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27966 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27967 fields instead of rolling our own initializer. Takes care of all
27968 implicit conversions, and drops unnecessary static checks/argument.
27970 2002-03-31 Dick Porter <dick@ximian.com>
27972 * driver.cs: use the GetDirectories() return values properly, and
27973 use "/" as path separator.
27975 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27977 * expression.cs (Unary): Optimize - - expr into expr.
27978 (Binary): Optimize a + (-b) into a -b.
27980 * codegen.cs (CodeGen): Made all methods static.
27982 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27986 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27987 TypeBuilder property.
27989 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27992 * tree.cs: Removed the various RecordXXXX, and replaced with a
27993 single RecordDecl. Removed all the accessor methods, and just
27994 left a single access point Type
27996 * enum.cs: Rename DefineEnum to DefineType.
27998 * decl.cs: New abstract method `DefineType' used to unify the
27999 Defines for Enumerations, Interfaces, TypeContainers and
28002 (FindType): Moved LookupInterfaceOrClass here. Moved the
28003 LookupBaseClasses method that used to live in class.cs and
28004 interface.cs here, and renamed to FindType.
28006 * delegate.cs: Implement DefineType. Take advantage of the
28007 refactored pattern for locating the parent builder without taking
28008 the parent_builder argument (which we know does not work if we are
28009 nested, and triggering a toplevel definition).
28011 2002-03-28 Miguel de Icaza <miguel@ximian.com>
28013 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
28014 accessibility of a member has changed during override and report
28017 * class.cs (Method.Define, Property.Define): Only complain on
28018 overrides if the method is private, any other accessibility is
28019 fine (and since we just checked the permission is the same, we are
28022 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
28023 and elif are processed always. The other pre-processing
28024 directives are only processed if we are "taking" the path
28026 2002-03-29 Martin Baulig <martin@gnome.org>
28028 * class.cs (Method.Emit): Only emit symbolic debugging info if the
28029 current location is not Null.
28031 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
28032 a separate method so we can profile it.
28034 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
28035 `span.Seconds' are just seconds, but no minutes or hours.
28036 (MainDriver): Profile the CodeGen.SaveSymbols calls.
28038 2002-03-28 Miguel de Icaza <miguel@ximian.com>
28040 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
28041 Remove the gratuitous set of Final:
28043 // If an interface implementation, then we can set Final.
28044 if (((flags & MethodAttributes.Abstract) == 0) &&
28045 implementing.DeclaringType.IsInterface)
28046 flags |= MethodAttributes.Final;
28048 I do not know what I was smoking when I used that.
28051 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
28052 step into fixing the name resolution issues for delegates and
28053 unifying the toplevel name resolution.
28055 2002-03-28 Martin Baulig <martin@gnome.org>
28057 * class.cs (Method.Emit): If we have a symbol writer, call its
28058 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
28059 tell it about the current method.
28061 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
28062 writer that we're going to emit the first byte of IL code for a new
28063 statement (a new source line).
28064 (EmitContext.EmitTopBlock): If we have a symbol writer, call
28065 EmitContext.Mark() before emitting any code.
28067 * location.cs (SymbolDocument): Return null when we're Null.
28069 * statement.cs (Statement): Moved the `Location loc' variable here.
28070 (Statement.EmitBoolExpression): If we have a symbol writer, call
28071 ec.Mark() before emitting any code to tell it that we're at the
28072 beginning of a new statement.
28073 (StatementExpression): Added `Location' argument to the constructor.
28074 (Block): Added public readonly variable `StartLocation' and public
28075 variable `EndLocation'. The latter is to be set using SetEndLocation().
28076 (Block): Added constructor which takes a start and end location.
28077 (Block.SetEndLocation): New method. This sets the end location.
28078 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
28079 local variables we create.
28080 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
28081 each statement and do also mark the begin and end of the block.
28083 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
28084 tell it the current lexer.Location, use Location.Null for the end of the
28086 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
28087 current block, set its end location using SetEndLocation().
28088 (statement_expression): StatementExpression constructor now takes the
28089 lexer.Location as additional argument.
28090 (for_statement, declare_local_variables): Likewise.
28091 (declare_local_variables): When creating a new implicit block, use the
28092 new Block constructor and pass it the lexer.Location.
28094 2002-03-28 Miguel de Icaza <miguel@ximian.com>
28096 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
28097 members also on the parent interfaces recursively.
28099 2002-03-27 Miguel de Icaza <miguel@ximian.com>
28101 * report.cs: Use new formats, since Gonzalo finished the missing
28104 * expression.cs (Binary.ResolveOperator): added missing operator|
28105 operator& and operator^ for bool/bool.
28107 * cs-parser.jay: CheckDef now takes a Location argument that is
28108 used to report errors more precisly (instead of reporting the end
28109 of a definition, we try to track something which is a lot closer
28110 to the source of the problem).
28112 * cs-tokenizer.cs: Track global token use, so we can properly flag
28113 the use of #define/#undef after the first token has been seen.
28115 Also, rename the reportXXXX to Error_DescriptiveName
28117 * decl.cs (DeclSpace.IsTopLevel): Move property here from
28118 TypeContainer, so that Enum and Interface can use this too.
28120 * class.cs (TypeContainer.LookupInterfaceOrClass,
28121 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
28122 `builder' argument. Typically this was used to pass the parent
28123 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
28126 The problem is that a nested class could trigger the definition of
28127 a toplevel class, and the builder would be obviously wrong in that
28130 So we drop this argument, and we compute dynamically the
28131 TypeBuilder/ModuleBuilder (the correct information was available
28132 to us anyways from DeclSpace.Parent)
28134 * interface.cs (Interface.DefineInterface): Drop builder
28135 parameter cleanup like class.cs
28137 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
28140 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
28143 (Try.Emit): Propagate the returns value from the statement.
28145 (Return.Emit): Even if we are leavning
28147 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
28149 * modifiers.cs: Fix the computation of MethodAttributes flags.
28151 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
28153 * driver.cs: allow compilation of files that start with '/'.
28154 Add a default case when checking the argument of --target.
28156 2002-03-25 Miguel de Icaza <miguel@ximian.com>
28158 * interface.cs: Implement the same search algorithm for types in
28159 the interface code.
28161 * delegate.cs: Do not allow multiple definition.
28163 * Recovered ChangeLog that got accidentally amputated
28165 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
28167 * rootcontext.cs: Load manually enum to allow core classes to
28168 contain enumerations.
28170 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
28171 Update to new static methods in TypeManager.
28173 * typemanager.cs (GetMethod, GetConstructor): Use our
28174 implementation of FindMembers to find the members, since during
28175 corlib compilation, the types are TypeBuilders and GetMethod and
28176 GetConstructor do not work.
28178 Make all methods in TypeManager static.
28180 (InitCodeHelpers): Split the functionality from
28181 the InitCodeTypes function.
28183 * driver.cs: Call InitCodeHelpers after we have populated the
28186 * cs-parser.jay (delegate_declaration): we did not used to compute
28187 the delegate name correctly for void delegates.
28189 2002-03-24 Miguel de Icaza <miguel@ximian.com>
28191 * rootcontext.cs (RootContext): Init the interface_resolve_order
28192 and type_container_resolve_order always.
28194 (ResolveCore, BootstrapCorlib_ResolveClass,
28195 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
28196 compiler when compiling with --nostdlib
28198 * class.cs (TypeContainer.DefineType): Check that our parent is
28199 not null. This test is most important when we are bootstraping
28202 * codegen.cs: Split out the symbol writing code.
28204 2002-03-25 Martin Baulig <martin@gnome.org>
28206 * driver.cs (-g): Made -g an alias for --debug.
28208 2002-03-24 Martin Baulig <martin@gnome.org>
28210 * codegen.cs (SymbolWriter): New public variable. Returns the
28211 current symbol writer.
28212 (CodeGen): Added `bool want_debugging_support' argument to the
28213 constructor. If true, tell the ModuleBuild that we want debugging
28214 support and ask it for the ISymbolWriter.
28215 (Save): If we have a symbol writer, call it's Close() method after
28216 saving the assembly.
28218 * driver.c (--debug): New command line argument to create a
28219 debugger information file.
28221 * location.cs (SymbolDocument): New public property. Returns an
28222 ISymbolDocumentWriter object for the current source file or null
28223 if we don't have a symbol writer.
28225 2002-03-21 Miguel de Icaza <miguel@ximian.com>
28227 * driver.cs (LoadAssembly): Correctly return when all the paths
28228 have been tried and not before.
28230 * statement.cs (Switch.Emit): return the actual coverage for this
28231 statement (returns/not-returns)
28233 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
28234 switch of the statement if we are the last switch section. That
28235 kills two problems: try/catch problems (we used to emit an empty
28236 nop at the end) and switch statements where all branches would
28239 2002-03-19 Miguel de Icaza <miguel@ximian.com>
28241 * driver.cs: Add default assemblies (the equivalent to the
28242 Microsoft CSC.RSP file)
28244 * cs-tokenizer.cs: When updating `cols and setting it to zero,
28245 also update tokens_seen and set it to false.
28247 * driver.cs: Implement --recurse for Mike.
28249 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
28250 correctly splitting out the paths.
28252 2002-03-18 Miguel de Icaza <miguel@ximian.com>
28254 * interface.cs (Interface.PopulateProperty): Instead of using
28255 `parent' as the declaration space for the set parameters, use
28258 * support.cs (InternalParameters): InternalParameters constructor
28259 takes a DeclSpace instead of a TypeContainer.
28261 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
28262 types are being initialized, load the address of it before calling
28265 (New): Provide a mechanism to disable the generation of local
28266 value type temporaries when the caller will be providing us with
28267 an address to store it.
28269 (ArrayCreation.EmitDynamicInitializers): Use it.
28271 2002-03-17 Miguel de Icaza <miguel@ximian.com>
28273 * expression.cs (Invocation.EmitArguments): Only probe for array
28274 property if there is more than one argument. Sorry about that.
28276 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
28277 empty param arrays.
28279 * class.cs (Method.LabelParameters): Fix incorrect code path that
28280 prevented the `ParamArrayAttribute' from being applied to the
28283 2002-03-16 Miguel de Icaza <miguel@ximian.com>
28285 * support.cs (ReflectionParameters): Correctly compute whether the
28286 last argument is a params array. Fixes the problem with
28289 * typemanager.cs: Make the assemblies array always be non-null
28290 (empty, but non-null)
28292 * tree.cs (RecordDecl): New function that abstracts the recording
28293 of names. This reports error 101, and provides a pointer to the
28294 previous declaration. Fixes a crash in the compiler.
28296 * cs-parser.jay (constructor_declaration): Update to new grammar,
28297 and provide a constructor_body that can be empty.
28299 2002-03-15 Miguel de Icaza <miguel@ximian.com>
28301 * driver.cs: Add support for --resources.
28303 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
28304 Make all types for the various array helper methods be integer.
28306 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
28307 CheckState to ConvCast.
28309 (ConvCast): Now it takes a `checked' state argument, to avoid
28310 depending on the emit context for the conversion, and just using
28311 the resolve time setting.
28313 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
28314 instead of Invocation.EmitArguments. We do not emit the original
28315 arguments, instead we emit those which have been converted to
28316 unsigned int expressions.
28318 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
28320 * codegen.cs: ditto.
28322 * expression.cs (LocalVariableReference): Drop the use of the
28323 Store function that depended on the variable index.
28325 * statement.cs (VariableInfo): Drop the `Idx' property from this
28326 class, as this is not taking into account the indexes for
28327 temporaries tat we generate during the execution, getting the
28330 * class.cs: First emit class initializers, then call the parent
28333 * expression.cs (Binary): Fix opcode emision.
28334 (UnaryMutator.EmitCode): Support checked code generation
28336 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
28337 matches for events for both the Static and Instance scans,
28338 pointing to the same element. Fix that.
28340 2002-03-14 Miguel de Icaza <miguel@ximian.com>
28342 * rootcontext.cs (ResolveTree): Always set the
28343 interface_resolve_order, because nested interfaces will be calling
28346 * class.cs (GetInterfaceOrClass): Track the same resolution
28347 process used by TypeManager.LookupType. This fixes the nested
28348 type lookups in class declarations (separate path from
28351 (TypeContainer.DefineType): Also define nested interfaces.
28352 (TypeContainer.RegisterOrder): New public function used to
28353 register the order in which child interfaces need to be closed.
28355 Nested interfaces need to be closed after their parents have been
28358 * interface.cs (InterfaceAttr): Put all the logic for computing
28359 the interface attribute here.
28361 (DefineInterface): Register our interface order with the
28362 RootContext or with the TypeContainer depending on the case.
28364 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28366 * cs-parser.jay: rework foreach statement to work with the new
28367 changes to the policy on SimpleNames.
28369 * report.cs: support Stacktrace on warnings as well.
28371 * makefile: drop --unsafe and /unsafe from the compile.
28373 2002-03-13 Ravi Pratap <ravi@ximian.com>
28375 * ecore.cs (StandardConversionExists): Modify to take an Expression
28376 as the first parameter. Ensure we do null -> reference type conversion
28379 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28380 temporary Expression objects.
28382 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28384 * interface.cs: workaround bug in method overloading resolution
28385 (there is already a bugzilla bug for it).
28387 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28389 We could also solve this problem by having a separate path for
28390 performing type lookups, instead of DoResolve, we could have a
28391 ResolveType entry point, and only participating pieces of the
28392 production (simplename, deref, array) would implement this.
28394 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28395 signal SimpleName to only resolve type names and not attempt to
28396 resolve anything else.
28398 * expression.cs (Cast): Set the flag.
28400 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28402 * class.cs: Only report 108 if there is no `new' modifier.
28404 * cs-parser.jay: rework foreach statement to work with the new
28405 changes to the policy on SimpleNames.
28407 * report.cs: support Stacktrace on warnings as well.
28409 * makefile: drop --unsafe and /unsafe from the compile.
28411 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28413 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28414 lookups here, instead of doing that at parse time. This means
28415 that our grammar will not introduce `LocalVariableReferences' as
28416 expressions at this point. That solves the problem of code like
28420 static void Main ()
28424 This is only half the fix. The full fix requires parameters to
28425 also be handled in this way.
28427 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28428 makes the use more obvious of the DeclSpace. The
28429 ec.TypeContainer.TypeBuilder is now only used to pull the
28430 TypeBuilder for it.
28432 My theory is that I can get rid of the TypeBuilder completely from
28433 the EmitContext, and have typecasts where it is used (from
28434 DeclSpace to where it matters).
28436 The only pending problem is that the code that implements Aliases
28437 is on TypeContainer, and probably should go in DeclSpace.
28439 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28440 lookups here, instead of doing that at parse time. This means
28441 that our grammar will not introduce `LocalVariableReferences' as
28442 expressions at this point. That solves the problem of code like
28446 static void Main ()
28450 This is only half the fix. The full fix requires parameters to
28451 also be handled in this way.
28453 * class.cs (Property.DefineMethod): When implementing an interface
28454 method, set newslot, when implementing an abstract method, do not
28455 set the flag (before we tried never setting it, or always setting
28456 it, which is the difference).
28457 (Indexer.DefineMethod): same.
28458 (Method.DefineMethod): same.
28460 * ecore.cs: Only set the status used flag if we get back a Field.
28462 * attribute.cs: Temporary hack, so Paolo can keep working.
28464 2002-03-08 Ravi Pratap <ravi@ximian.com>
28466 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28467 the unmanaged type in the case we have a MarshalAs attribute.
28469 (Resolve): Handle the case when we are parsing the special MarshalAs
28470 attribute [we need to store the unmanaged type to use later]
28472 * typemanager.cs (marshal_as_attr_type): Built in type for the
28473 MarshalAs Attribute.
28475 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28476 on parameters and accordingly set the marshalling info.
28478 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28480 * class.cs: Optimizing slightly by removing redundant code after
28481 we switched to the `NoTypes' return value.
28482 (Property.DefineMethod): use NoTypes here too.
28484 This fixes the bug I introduced in my last batch of changes.
28486 2002-03-05 Ravi Pratap <ravi@ximian.com>
28488 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28490 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28491 Enums since those are types too.
28493 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28495 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28496 thanks to a call during the lookup process.
28498 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28500 * statement.cs (Foreach): Lots of work to accomodate a particular
28501 kind of foreach statement that I had not kept in mind. It is
28502 possible to have foreachs on classes that provide a GetEnumerator
28503 method that return objects that implement the "pattern" for using
28504 a foreach, there is no need to support GetEnumerator
28507 This is needed to compile nant.
28509 * decl.cs: Only report 114 if the member is not `Finalize' and if
28510 the warning level is at least 2.
28512 * class.cs: Moved the compare function from Method to
28515 (MethodSignature.InheritableMemberSignatureCompare): Add new
28516 filter function that is used to extract inheritable methods from a
28519 (Method.Define): Use the new `inheritable_method_signature_filter'
28522 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28525 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28527 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28529 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28531 * expression.cs: Pass location information to
28532 ConvertImplicitStandard.
28534 * class.cs: Added debugging code to track return values from
28537 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28539 * expression.cs (Is.DoResolve): If either side of the `is' is an
28540 interface, do not flag the warning.
28542 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28545 * report.cs: Allow for --fatal to be used with --probe.
28547 * typemanager.cs (NoTypes): Move the definition for the empty Type
28550 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28552 (TypeContainer.DefineProxy): New function used to proxy to parent
28553 implementations when implementing interfaces.
28554 (TypeContainer.ParentImplements): used to lookup if our parent
28555 implements a public function that is required by an interface.
28556 (TypeContainer.VerifyPendingMethods): Hook this up.
28558 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28559 `modules' and `assemblies' arraylists into arrays. We only grow
28560 these are the very early start up of the program, so this improves
28561 the speedof LookupType (nicely measured).
28563 * expression.cs (MakeByteBlob): Replaced unsafe code with
28564 BitConverter, as suggested by Paolo.
28566 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28567 folding of string concatenation, but if either side is a string,
28568 and the other is not, then return null, and let the runtime use
28569 the concatenation on the string plus the object (using
28570 `Object.ToString').
28572 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28574 Constant Folding has been implemented now.
28576 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28577 the error instead on types that are not supported in one's
28580 * constant.cs (Constant and all children): New set of functions to
28581 perform implict and explicit conversions.
28583 * ecore.cs (EnumConstant): Implement the new functions to perform
28584 conversion by proxying to the child expression.
28586 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28587 own separate setting that can not be turned off from the command
28588 line using --unchecked or --checked and is only controlled using
28589 the checked/unchecked statements and expressions. This setting is
28590 used by the constant folder to flag errors.
28592 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28593 ConstantCheckState as well.
28595 During Resolve, they also have to flag the state, because the
28596 constant folder runs completely in the Resolve phase.
28598 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28601 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28603 * cfold.cs: New file, this file contains the constant folder.
28605 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28606 argument to track whether we are using the resulting address to
28607 load or store a value and provide better error messages.
28609 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28610 new AddressOf arguments.
28612 * statement.cs (Foreach.EmitCollectionForeach): Update
28614 * expression.cs (Argument.Emit): Call AddressOf with proper
28615 arguments to track usage.
28617 (New.DoEmit): Call AddressOf with new arguments.
28619 (Unary.Emit): Adjust AddressOf call.
28621 2002-03-01 Ravi Pratap <ravi@ximian.com>
28623 * cs-parser.jay (member_access): Change the case for pre-defined types
28624 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28627 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28630 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28631 essentially like methods and apply attributes like MethodImplOptions to them too.
28633 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28636 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28637 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28640 * Update code everywhere accordingly.
28642 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28644 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28646 2002-02-28 Ravi Pratap <ravi@ximian.com>
28648 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28649 try performing lookups against those instead of jumping straight into using
28650 the 'using' clauses.
28652 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28654 (LookupType): Perform lookups in implicit parents too.
28656 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28657 sequence as RootContext.LookupType.
28659 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28660 the various cases of namespace lookups into this method.
28662 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28664 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28665 in positional arguments)
28667 * class.cs (Operator): Update the AllowedModifiers to contain
28670 * cs-parser.jay: Update operator declaration to allow for the
28671 operator body to be empty.
28673 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28676 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28678 * class.cs (Method.Emit): Label parameters.
28680 * driver.cs: Return 1 or 0 as the program exit code.
28682 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28684 * expression.cs: Special case the `null' object when trying to
28685 auto-compute the type, as anything can be explicitly converted to
28688 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28689 spotting this Paolo.
28691 (Expression.ImplicitNumericConversion): Perform comparissions of
28692 the type using the underlying type in the case of an enumeration
28693 rather than using the enumeration type for the compare.
28695 Cope with the underlying == type case, which is not possible to
28698 (Expression.ConvertNumericExplicit): Perform comparissions of
28699 the type using the underlying type in the case of an enumeration
28700 rather than using the enumeration type for the compare.
28702 * driver.cs: If the user does not supply an extension, assume .exe
28704 * cs-parser.jay (if_statement): Rewrote so that we can track the
28705 location for the if statement.
28707 * expression.cs (Binary.ConstantFold): Only concat strings when
28708 the operation is "+", not everything ;-)
28710 * statement.cs (Statement.EmitBoolExpression): Take a location
28712 (If, While, Do): Track location.
28714 * expression.cs (Binary.ResolveOperator): In the object + string
28715 case, I was missing a call to ConvertImplicit
28717 2002-02-25 Ravi Pratap <ravi@ximian.com>
28719 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28720 Location arguments. Ensure we use RootContext.LookupType to do our work
28721 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28723 * interface.cs (PopulateMethod): Handle the type of the parameter being
28726 * expression.cs (Invocation.BetterFunction): Handle the case when we
28727 have a params method with no fixed arguments and a call is made with no
28730 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28732 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28733 the verbatim-string-literal
28735 * support.cs (InternalParameters.ParameterModifier): handle null
28737 (InternalParameters.ParameterType): ditto.
28739 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28740 duplicating the name of the variable parameter.
28741 (GetParameterByName): Fix bug where we were not looking up array
28742 paramters if they were the only present (thanks Paolo!).
28743 (GetParameterInfo): We only have an empty set of types if both
28744 fixed and array are set to null.
28745 (GetParameterInfo-idx): Handle FixedParameter == null
28747 * cs-parser.jay: Handle the case where there is no catch
28748 statements (missing null test).
28750 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28752 * driver.cs (MainDriver): Be conservative on our command line
28755 Catch DirectoryNotFoundException when calling GetFiles.
28757 (SplitPathAndPattern): Used to split the input specification into
28758 a path and a pattern that we can feed to Directory.GetFiles.
28760 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28762 * statement.cs (Fixed): Implement the last case of the Fixed
28763 statement (string handling).
28765 * expression.cs (StringPtr): New class used to return a char * to
28766 a string; Used by the Fixed statement.
28768 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28770 * expression.cs (Binary.ResolveOperator): Remove redundant
28771 MemberLookup pn parent type.
28772 Optimize union call, we do not need a union if the types are the same.
28773 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28776 Specialize the use of MemberLookup everywhere, instead of using
28777 the default settings.
28779 (StackAlloc): Implement stackalloc keyword.
28781 * cs-parser.jay: Add rule to parse stackalloc.
28783 * driver.cs: Handle /h, /help, /?
28785 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28786 before we supported unsafe code.
28788 * makefile: add --unsafe to the self compilation of mcs.
28790 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28792 * expression.cs (PointerArithmetic): New class that is used to
28793 perform pointer arithmetic.
28794 (Binary.Resolve): Handle pointer arithmetic
28795 Handle pointer comparission.
28796 (ArrayPtr): Utility expression class that is used to take the
28797 address of an array.
28799 (ElementAccess): Implement array access for pointers
28801 * statement.cs (Fixed): Implement fixed statement for arrays, we
28802 are missing one more case before we are done.
28804 * expression.cs (Indirection): Implement EmitAssign and set the
28805 ExprClass to Variable. This allows pointer dereferences to be
28806 treated as variables, and to have values assigned to them.
28808 * ecore.cs (Expression.StoreFromPtr): New utility function to
28809 store values dereferencing.
28811 2002-02-20 Ravi Pratap <ravi@ximian.com>
28813 * expression.cs (Binary.ResolveOperator): Ensure that we are
28814 not trying to operate on a void type - this fixes the reported
28817 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28818 the parent implementation is sealed.
28820 * ../errors/cs0239.cs : Add.
28822 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28824 * typemanager.cs (unverifiable_code_type): Corresponds to
28825 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28826 which have unsafe code in them.
28828 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28831 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28833 * cs-tokenizer.cs: Add support for @"litreal strings"
28835 Make tokenizer accept pre-processor directives
28836 on any column (remove the old C-like limitation).
28838 * rootcontext.cs (EmitCode): Emit any global attributes.
28839 (AddGlobalAttributes): Used to keep track of assembly attributes.
28841 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28843 * cs-parser.jay: Add support for global attributes.
28845 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28847 * expression.cs (Indirection): New helper class. Unary will
28848 create Indirection classes to be able to implement the
28849 IMemoryLocation interface on it.
28851 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28853 * cs-parser.jay (fixed_statement): reference the right statement.
28855 * statement.cs (Fixed.Emit): Finish implementing the fixed
28856 statement for the &x case.
28858 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28860 * class.cs (Property.Define, Method.Define): Remove newslot when
28863 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28864 wrong. NewSlot should only be used if the `new' keyword is present.
28866 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28867 locating our system dir. Sorry about this.
28869 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28871 * driver.cs (GetSystemDir): Compute correctly the location of our
28872 system assemblies. I was using the compiler directory instead of
28873 the library directory.
28875 2002-02-13 Ravi Pratap <ravi@ximian.com>
28877 * expression.cs (BetterFunction): Put back in what Miguel commented out
28878 since it is the correct fix. The problem is elsewhere ;-)
28880 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28881 parameters of the parms method are themselves compatible or not !
28883 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28884 to check that a class implements an interface before saying that an implicit
28885 conversion was allowed. Use ImplementsInterface to do the checking.
28887 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28889 * class.cs (Method.Define): Track whether we are an explicit
28890 implementation or not. And only call DefineMethodOverride if we
28891 are an explicit implementation.
28893 (Property.DefineMethod): Ditto.
28895 2002-02-11 Ravi Pratap <ravi@ximian.com>
28897 * expression.cs (BetterFunction): Catch hideous bug which was
28898 preventing us from detecting ambiguous calls due to implicit casts i.e
28901 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28903 * support.cs (Pair): Remove un-needed method. I figured why I was
28904 getting the error in cs-parser.jay, the variable in a foreach loop
28905 is readonly, and the compiler does not really treat this as a variable.
28907 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28908 instead of EQUALS in grammar.
28910 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28912 * expression.cs (Unary.DoResolve): Check whether the argument is
28915 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28917 * support.cs: Api for Pair to set a value. Despite the fact that
28918 the variables are public the MS C# compiler refuses to compile
28919 code that accesses the field if the variable is part of a foreach
28922 * statement.cs (Fixed): Begin implementation of the fixed
28925 (Block.AddVariable): Return the VariableInfo on success and null
28926 on failure instead of true/false.
28928 * cs-parser.jay (foreach): Catch errors on variables already
28929 defined (we were ignoring this value before) and properly unwind
28930 the block hierarchy
28932 (fixed_statement): grammar for the fixed statement.
28934 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28936 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28937 pointer types to be incretemented.
28939 (SizeOf): Implement.
28941 * cs-parser.jay (pointer_member_access): Implement
28942 expr->IDENTIFIER production.
28944 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28945 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28948 (Unary): Implement indirection.
28950 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28951 use in non-unsafe context).
28953 (SimpleName.DoResolve): Check for pointers in field access on safe
28956 (Expression.LoadFromPtr): Factor the load-indirect code in this
28957 function. This was duplicated in UnboxCast and ParameterReference
28959 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28961 * expression.cs (ComposedCast): report an error if a pointer cast
28962 is used in a safe region.
28964 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28965 pointer type casts in unsafe context.
28967 * codegen.cs (EmitContext): Set up IsUnsafe.
28969 * cs-parser.jay (non_expression_type): Add productions for pointer
28972 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28973 code. We should not use force into static mode if the method is
28974 not virtual. Fixes bug in MIS
28976 * statement.cs (Do.Emit, While.Emit, For.Emit,
28977 Statement.EmitBoolExpression): Add support to Do and While to
28978 propagate infinite loop as `I do return' semantics.
28980 Improve the For case to also test for boolean constants.
28982 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28983 to the list of attributes we can add.
28985 Remove `EmitContext' argument.
28987 * class.cs (Method.Define): Apply parameter attributes.
28988 (Constructor.Define): Apply parameter attributes.
28989 (MethodCore.LabelParameters): Move here the core of labeling
28992 * support.cs (ReflectionParameters.ParameterModifier,
28993 InternalParameters.ParameterModifier): Use IsByRef on the type and
28994 only return the OUT bit for these parameters instead of in/out/ref
28997 This is because I miss-understood things. The ParameterInfo.IsIn
28998 and IsOut represent whether the parameter has the [In] and [Out]
29001 2002-01-22 Miguel de Icaza <miguel@ximian.com>
29003 * ecore.cs (FieldExpr.Emit): Release temporaries.
29005 * assign.cs (LocalTemporary.Release): new function.
29007 * codegen.cs (EmitContext.GetTemporaryStorage,
29008 EmitContext.FreeTemporaryStorage): Rework the way we deal with
29009 temporary storage. Now we can "put back" localbuilders when we
29012 2002-01-21 Miguel de Icaza <miguel@ximian.com>
29014 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
29015 need to make a copy of the variable to generate verifiable code.
29017 2002-01-19 Miguel de Icaza <miguel@ximian.com>
29019 * driver.cs: Compute dynamically the system directory.
29021 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
29022 Slower, but more generally useful. Used by the abstract
29023 registering implementation.
29025 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
29026 the rules for the special rule on Type/instances. First check if
29027 we have the same name, and if so, try that special static path
29028 rather than the instance path.
29030 2002-01-18 Miguel de Icaza <miguel@ximian.com>
29032 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
29035 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
29036 Enum, ValueType, Delegate or Array for non-corlib compiles.
29038 * cs-tokenizer.cs: Catch long identifiers (645)
29040 * typemanager.cs (IndexerPropetyName): Ravi never tested this
29043 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
29044 fix, we were returning too early, so we were not registering
29045 pending methods from abstract classes.
29047 Do not register pending methods if the class is abstract.
29049 * expression.cs (Conditional.DoResolve): Report circular implicit
29050 conversions when we neecd to compute it for conditional
29053 (Is.DoResolve): If the expression is always of the provided type,
29054 flag warning 183. If the expression can not ever be of the
29055 provided type flag warning 184.
29057 * class.cs: Catch 169 as well.
29059 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
29062 2002-01-18 Nick Drochak <ndrochak@gol.com>
29064 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
29066 2002-01-17 Miguel de Icaza <miguel@ximian.com>
29068 * interface.cs: (PopulateMethod): Check for pointers being defined
29069 only if the unsafe context is active.
29070 (PopulateProperty): ditto.
29071 (PopulateIndexer): ditto.
29073 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
29074 specified. If pointers are present, make sure that they are
29075 present in an unsafe context.
29076 (Constructor, Constructor.Define): ditto.
29077 (Field, Field.Define): ditto.
29078 (Property, Property.Define): ditto.
29079 (Event, Event.Define): ditto.
29081 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
29082 hashtable if there are classes or structs defined.
29084 * expression.cs (LocalVariableReference.DoResolve): Simplify this
29085 code, as the constant resolution moved.
29087 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
29088 the metadata, so we can flag error 133.
29090 * decl.cs (MemberCore.UnsafeOK): New function to test that a
29091 pointer is being declared in an unsafe context.
29093 2002-01-16 Miguel de Icaza <miguel@ximian.com>
29095 * modifiers.cs (Modifiers.Check): Require a Location argument.
29096 Report error 227 for Unsafe use.
29098 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
29100 * statement.cs (For.Emit): If the test is null, then report that
29101 we do `return', as we wont reach anything afterwards.
29103 (Switch.SwitchGoverningType): Track the expression that matched
29106 * driver.cs: Allow negative numbers as an error code to flag.
29108 * cs-parser.jay: Handle 1551.
29110 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
29112 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29114 * cs-parser.jay: Report 1518 (type declaration can only contain
29115 class, struct, interface, enum or delegate)
29117 (switch_label): Report 1523 (keywords `case' or `default' must
29120 (opt_switch_sections): Report 1522 (empty switch)
29122 * driver.cs: Report 1515 (response file specified multiple times)
29123 Report 1516 (Source file specified multiple times).
29125 * expression.cs (Argument.Resolve): Signal 1510
29127 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
29128 access not allowed in static code)
29130 2002-01-11 Ravi Pratap <ravi@ximian.com>
29132 * typemanager.cs (IsPointerType): Utility method which we are going
29135 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
29136 the object type, so we take care of that.
29138 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
29140 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
29141 added to non-params parameters :-)
29143 * typemanager.cs (CSharpName): Include 'void' type too.
29145 (void_ptr_type): Include in the set of core types.
29147 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
29150 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
29153 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
29154 completely forgotten about it.
29156 2002-01-10 Ravi Pratap <ravi@ximian.com>
29158 * cs-parser.jay (pointer_type): Add. This begins our implementation
29159 of parsing rules for unsafe code.
29161 (unsafe_statement): Implement.
29163 (embedded_statement): Modify to include the above.
29165 * statement.cs (Unsafe): Implement new class for unsafe blocks.
29167 * codegen.cs (EmitContext.InUnsafe): Add. This determines
29168 if the current context is an unsafe one.
29170 * cs-parser.jay (local_variable_pointer_type): Since local variable types
29171 are handled differently, we need separate rules for them.
29173 (local_variable_declaration): Update to use local_variable_pointer_type
29174 to allow variable declarations of unmanaged pointer types.
29176 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
29177 in unsafe contexts.
29179 * ../errors/cs0214.cs : Add.
29181 2002-01-16 Nick Drochak <ndrochak@gol.com>
29183 * makefile: remove 'response' file when cleaning.
29185 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29187 * cs-parser.jay: Report 1524.
29189 2002-01-14 Miguel de Icaza <miguel@ximian.com>
29191 * typemanager.cs (RegisterMethod): drop checking if we have
29192 registered this from here
29194 2002-01-12 Miguel de Icaza <miguel@ximian.com>
29196 * class.cs (Method.EmitDestructor): Implement calling our base
29199 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
29200 value of InFinally.
29202 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
29203 this routine and will wrap the call in a try/catch block. Deal
29206 2002-01-11 Miguel de Icaza <miguel@ximian.com>
29208 * ecore.cs (Expression.MemberLookup): instead of taking a
29209 parameter `same_type' that was used to tell whether we could
29210 access private members we compute our containing type from the
29213 (FieldExpr): Added partial support for volatile fields. This does
29214 not work for volatile fields exposed from assemblies, as I can not
29215 figure out how to extract the modreq from it.
29217 Updated all the source files to use this.
29219 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
29220 because it is referenced by MemberLookup very often.
29222 2002-01-09 Ravi Pratap <ravi@ximian.com>
29224 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
29225 TypeBuilder.GetCustomAttributes to retrieve what we need.
29227 Get rid of redundant default_member_attr_type as this is the same as
29228 default_member_type which already exists.
29230 * interface.cs, attribute.cs : Update accordingly.
29232 2002-01-08 Miguel de Icaza <miguel@ximian.com>
29234 * typemanager.cs: Enable IndexerPropertyName again. It does not
29235 work for TYpeBuilders though. Ravi, can you please fix this?
29237 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
29239 * expression.cs (Argument.Emit): Handle the case of ref objects
29240 being passed to ref functions;
29242 (ParameterReference.EmitLoad): Loads the content of the pointer
29243 without dereferencing.
29245 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29247 * cs-tokenizer.cs: Implemented the pre-processing expressions.
29249 2002-01-08 Ravi Pratap <ravi@ximian.com>
29251 * class.cs (Indexer.DefineMethod): Incorporate the interface
29252 type in the name of the method if we are doing explicit interface
29255 * expression.cs (ConversionExists): Remove as it is completely obsolete.
29257 (BetterConversion): Fix extremely trivial bug where we were referring to
29258 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
29261 * ../errors/bug16.cs : Add although we have fixed it.
29263 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29265 * expression.cs (BaseIndexer): Begin implementation.
29267 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
29269 * cs-parser.jay (indexer_declarator): Use qualified_identifier
29270 production directly to remove a shift/reduce, and implement
29271 explicit interface implementation.
29273 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
29274 after a floating point suffix.
29276 * expression.cs (DoNumericPromotions): Improved the conversion for
29277 uint/uint. If we have a constant, we avoid doing a typecast to a
29280 * class.cs (Indexer): Implement explicit interface implementation
29283 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
29285 * class.cs: make the default instance constructor public and hidebysig.
29287 2001-01-03 Ravi Pratap <ravi@ximian.com>
29289 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
29290 so we can call it from elsewhere.
29292 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
29293 we emit it internally if the class has a defined indexer; otherwise the user
29294 emits it by decorating the class definition with the DefaultMemberAttribute.
29296 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
29297 attribute is not used on a type which defines an indexer.
29299 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
29300 character when we skip whitespace.
29302 * ../errors/cs0646.cs : Add.
29304 2002-01-03 Miguel de Icaza <miguel@ximian.com>
29306 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
29309 * makefile: Add practical target `mcs3.exe' which builds the third
29310 generation compiler.
29312 * expression.cs (New): Fix structures constructor calling.
29314 * class.cs (Property, Method, Indexer): Emit Final flag on the
29315 method if we are an interface implementation and we are not
29318 * ecore.cs (PropertyExpr): New public field `IsBase', tells
29319 whether this property is referencing a `base' method.
29321 * expression.cs (Invocation.EmitCall): take an extra argument:
29322 is_base, this is used to determine whether the `call' or
29323 `callvirt' opcode should be used.
29326 * delegate.cs: update EmitCall.
29328 * class.cs (Method.Define): Set NewSlot for the cases where we are
29329 not implementing an interface method.
29331 (Property.Define): ditto.
29333 2002-01-02 Miguel de Icaza <miguel@ximian.com>
29335 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
29336 'r'. Allows mcs to parse itself fully.
29338 2002-01-02 Ravi Pratap <ravi@ximian.com>
29340 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
29341 of the number of initializers that require the InitializeArray method.
29343 (CheckIndices): Store the Expression in all cases - not the plain value. Also
29344 update the above field where necessary.
29346 (MakeByteBlob): Update accordingly.
29348 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
29351 (EmitDynamicInitializers): Update in accordance with the new optimization.
29353 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
29354 same OpCode applies.
29356 * cs-parser.jay : Fix some glaring errors I introduced.
29358 2002-01-01 Ravi Pratap <ravi@ximian.com>
29360 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
29361 so that we can check for name clashes there too.
29363 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29364 for interface indexers.
29366 * interfaces.cs (Define): Emit the default member attribute.
29368 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29369 variable was being referred to while setting the value ;-)
29371 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29373 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29374 byte-by-byte information when we know the data is zero.
29376 Make the block always a multiple of 4, because
29377 DefineInitializedData has a bug.
29379 * assign.cs: Fix, we should assign from the temporary, not from
29382 * expression.cs (MakeByteBlob): Fix my incorrect code.
29384 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29386 * typemanager.cs (EnumToUnderlying): This function is used to get
29387 the underlying type from an enumeration, because it does not
29390 * constant.cs: Use the I4_S form for values between -128 and 127.
29392 * statement.cs (Block.LookupLabel): Looks up a label.
29393 (Block): Drop support for labeled blocks.
29395 (LabeledStatement): New kind of statement that represents a label
29398 (Goto): Finally implement this bad boy.
29400 * cs-parser.jay: Update to reflect new mechanism to implement
29403 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29405 * codegen.cs (EmitContext.This): a codegen property that keeps the
29406 a single instance of this instead of creating many different this
29409 * delegate.cs (Delegate.DoResolve): Update to use the property;
29411 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29413 * expression.cs (BaseAccess.DoResolve): Ditto.
29415 2001-12-29 Ravi Pratap <ravi@ximian.com>
29417 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29418 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29420 (InitCoreTypes): Update accordingly.
29422 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29423 so we can quickly store the state.
29425 (ApplyAttributes): Set the correct implementation flags
29426 for InternalCall methods.
29428 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29430 * expression.cs (EmitCall): if a method is not virtual, then do
29431 not use callvirt on it.
29433 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29434 user defined stuff) requires the use of stobj, which takes an
29435 address on the stack instead of an array and an index. So emit
29436 the Ldelema operation for it.
29438 (EmitStoreOpcode): Use stobj for valuetypes.
29440 (UnaryMutator.EmitCode): Use the right 1 value depending on
29441 whether we are dealing with int64/uint64, float or doubles.
29443 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29444 constructors that I implemented last night.
29446 (Constructor.IsDefault): Fix to work properly for static
29449 * cs-parser.jay (CheckDef): report method signature errors.
29450 Update error number 103 to be 132.
29452 * decl.cs: New AdditionResult enumeration value: MethodExists.
29453 Although we do this check for methods later on in the semantic
29454 analysis, catching repeated default constructors is so easy that
29455 we catch these here.
29457 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29460 (ParameterReference.EmitAssign, Emit): handle
29463 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29464 (ArrayAccess.EmitStoreOpcode): ditto.
29466 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29468 * expression.cs (MakeByteBlob): Complete all the missing types
29469 (uint, short, ushort, byte, sbyte)
29471 * class.cs: Only init instance field initializers on instance
29474 Rename `constructors' to instance_constructors.
29476 (TypeContainer.AddConstructor): Only add constructors to the list
29477 if it is not static.
29479 Make sure that we handle default_static_constructor independently
29480 everywhere where we handle instance_constructors
29482 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29484 * class.cs: Do not lookup or create a base initializer for a
29485 static constructor.
29487 (ConstructorInitializer.Resolve): use the proper type to lookup
29490 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29492 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29495 * decl.cs: CloseType is now an virtual method, the default
29496 implementation just closes this type.
29498 2001-12-28 Ravi Pratap <ravi@ximian.com>
29500 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29501 to PreserveSig by default. Also emit HideBySig on such methods.
29503 Basically, set the defaults to standard values.
29505 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29506 argument, if candidate is better, it can't be worse than the best !
29508 (Invocation): Re-write bits to differentiate between methods being
29509 applicable in their expanded form and their normal form - for params
29512 Get rid of use_standard everywhere as only standard conversions are allowed
29513 in overload resolution.
29515 More spec conformance.
29517 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29519 * driver.cs: Add --timestamp, to see where the compiler spends
29522 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29523 `this' in static code.
29525 (SimpleName.DoResolve): Implement in terms of a helper function
29526 that allows static-references to be passed upstream to
29529 (Expression.ResolveWithSimpleName): Resolve specially simple
29530 names when called by MemberAccess to implement the special
29533 (Expression.ImplicitReferenceConversion): Handle conversions from
29534 Null to reference types before others, as Null's type is
29537 * expression.cs (Invocation.EmitCall): Handle the special case of
29538 calling methods declared on a reference type from a ValueType
29539 (Base classes System.Object and System.Enum)
29541 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29542 the left hand side is a TypeExpr, not on every enumeration.
29544 (Binary.Resolve): If types are reference types, then do a cast to
29545 object on operators != and == of both arguments.
29547 * typemanager.cs (FindMembers): Extract instance and static
29548 members if requested.
29550 * interface.cs (PopulateProperty): Use void_type instead of null
29551 as the return type for the setter method.
29553 (PopulateIndexer): ditto.
29555 2001-12-27 Ravi Pratap <ravi@ximian.com>
29557 * support.cs (ReflectionParameters): Fix minor bug where we
29558 were examining the wrong parameter for the ParamArray attribute.
29560 Cope with requests for the type of the parameter at position
29561 greater than the params parameter's. We now return the element
29562 type of the params array as that makes more sense.
29564 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29565 accordingly as we no longer have to extract the element type
29568 (Invocation.OverloadResolve): Update.
29570 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29572 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29573 against IEnumerator, test whether the return value is a descendant
29574 of the IEnumerator interface.
29576 * class.cs (Indexer.Define): Use an auxiliary method to implement
29577 the other bits of the method definition. Begin support for
29578 explicit interface implementation.
29580 (Property.DefineMethod): Use TypeManager.void_type instead of null
29581 for an empty return value.
29583 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29585 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29586 dealing with a FieldExpr which is composed of a FieldBuilder, in
29587 the code path we did extract the constant, but we should have
29588 obtained the underlying value to be able to cast it (otherwise we
29589 end up in an infinite loop, this is what Ravi was running into).
29591 (ArrayCreation.UpdateIndices): Arrays might be empty.
29593 (MemberAccess.ResolveMemberAccess): Add support for section
29594 14.5.4.1 that deals with the special case of E.I when E is a type
29595 and something else, that I can be a reference to a static member.
29597 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29598 handle a particular array type to create byte blobs, it is just
29599 something we dont generate byteblobs for.
29601 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29604 * location.cs (Push): remove the key from the hashtable that we
29605 are about to add. This happens for empty files.
29607 * driver.cs: Dispose files after we have parsed them.
29609 (tokenize): new function that only runs the tokenizer on its
29610 input, for speed testing.
29612 2001-12-26 Ravi Pratap <ravi@ximian.com>
29614 * class.cs (Event.Define): Define the private field only if there
29615 are no accessors defined.
29617 * expression.cs (ResolveMemberAccess): If there is no associated
29618 field with the event, that means we have an event defined with its
29619 own accessors and we should flag error cs0070 since transforming
29620 ourselves into a field is not valid in that case.
29622 * ecore.cs (SimpleName.DoResolve): Same as above.
29624 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29625 and charset to sane values.
29627 2001-12-25 Ravi Pratap <ravi@ximian.com>
29629 * assign.cs (DoResolve): Perform check on events only if they
29630 are being accessed outside the declaring type.
29632 * cs-parser.jay (event_declarations): Update rules to correctly
29633 set the type of the implicit parameter etc.
29635 (add_accessor, remove_accessor): Set current local parameters.
29637 * expression.cs (Binary): For delegate addition and subtraction,
29638 cast the return value from the method into the appropriate delegate
29641 2001-12-24 Ravi Pratap <ravi@ximian.com>
29643 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29644 of these as the workaround is unnecessary.
29646 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29647 delegate data - none of that is needed at all.
29649 Re-write bits to extract the instance expression and the delegate method
29652 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29655 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29656 of attaching attributes instead of duplicating code everywhere.
29658 * everywhere : Update code to do attribute emission using the above method.
29660 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29662 * expression.cs (IsParamsMethodApplicable): if there are not
29663 parameters, return immediately.
29665 * ecore.cs: The 0 literal can be implicity converted to an enum
29668 (SimpleName.DoResolve): First lookup the type, then lookup the
29671 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29672 want to get its address. If the InstanceExpression is not
29673 addressable, store the result in a temporary variable, then get
29676 * codegen.cs: Only display 219 errors on warning level or above.
29678 * expression.cs (ArrayAccess): Make it implement the
29679 IMemoryLocation interface.
29681 (Binary.DoResolve): handle the operator == (object a, object b)
29682 and operator != (object a, object b) without incurring into a
29683 BoxedCast (because 5 != o should never be performed).
29685 Handle binary enumerator operators.
29687 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29688 value type, otherwise use Ldelem_ref.
29690 Use precomputed names;
29692 (AddressOf): Implement address of
29694 * cs-parser.jay (labeled_statement): Fix recursive block
29695 addition by reworking the production.
29697 * expression.cs (New.DoEmit): New has a special case:
29699 If we are dealing with a ValueType, we have a few
29700 situations to deal with:
29702 * The target of New is a ValueType variable, that is
29703 easy, we just pass this as the variable reference
29705 * The target of New is being passed as an argument,
29706 to a boxing operation or a function that takes a
29709 In this case, we need to create a temporary variable
29710 that is the argument of New.
29713 2001-12-23 Ravi Pratap <ravi@ximian.com>
29715 * rootcontext.cs (LookupType): Check that current_type is not null before
29716 going about looking at nested types.
29718 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29719 not implement the IAssignMethod interface any more.
29721 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29722 where we tranform them into FieldExprs if they are being resolved from within
29723 the declaring type.
29725 * ecore.cs (SimpleName.DoResolve): Do the same here.
29727 * assign.cs (DoResolve, Emit): Clean up code considerably.
29729 * ../errors/bug10.cs : Add.
29731 * ../errors/cs0070.cs : Add.
29733 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29735 * assign.cs : Get rid of EventIsLocal everywhere.
29737 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29739 * ecore.cs (ConvertIntLiteral): finished the implementation.
29741 * statement.cs (SwitchLabel): Convert the value we are using as a
29742 key before looking up the table.
29744 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29746 * codegen.cs (EmitTopBlock): Require a Location argument now.
29748 * cs-parser.jay (constructor_declarator): We need to setup
29749 current_local_parameters before we parse the
29750 opt_constructor_initializer, to allow the variables to be bound
29751 to the constructor arguments.
29753 * rootcontext.cs (LookupType): First lookup nested classes in our
29754 class and our parents before we go looking outside our class.
29756 * expression.cs (ConstantFold): Extract/debox the values at the
29759 * rootcontext.cs (EmitCode): Resolve the constants first before we
29760 resolve the types. This is not really needed, but it helps debugging.
29762 * statement.cs: report location.
29764 * cs-parser.jay: pass location to throw statement.
29766 * driver.cs: Small bug fix.
29768 * report.cs: Updated format to be 4-zero filled digits.
29770 2001-12-22 Ravi Pratap <ravi@ximian.com>
29772 * expression.cs (CheckIndices): Fix minor bug where the wrong
29773 variable was being referred to ;-)
29775 (DoEmit): Do not call EmitStaticInitializers when the
29776 underlying type is System.Object.
29778 2001-12-21 Ravi Pratap <ravi@ximian.com>
29780 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29781 and do the usual workaround for SRE.
29783 * class.cs (MyEventBuilder.EventType): New member to get at the type
29784 of the event, quickly.
29786 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29788 * assign.cs (Assign.DoResolve): Handle the case when the target
29789 is an EventExpr and perform the necessary checks.
29791 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29794 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29796 (EventExpr): Set the type in the constructor itself since we
29797 are meant to be born fully resolved.
29799 (EventExpr.Define): Revert code I wrote earlier.
29801 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29802 instance expression is null. The instance expression is a This in that case
29803 or a null, depending on whether it is a static method or not.
29805 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29806 refers to more than one method.
29808 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29809 and accordingly flag errors.
29811 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29813 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29815 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29817 * location.cs (ToString): Provide useful rutine.
29819 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29821 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29822 objects, return the actual integral boxed.
29824 * statement.cs (SwitchLabel): define an ILLabel for each
29827 (Switch.CheckSwitch): If the value is a Literal, extract
29828 the underlying literal.
29830 Also in the unused hashtable we had, add the SwitchLabel so we can
29831 quickly look this value up.
29833 * constant.cs: Implement a bunch of new constants. Rewrite
29834 Literal based on this. Made changes everywhere to adapt to this.
29836 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29837 dereferencing array only once, and also copes with enumrations.
29839 bytes are two bytes wide, not one.
29841 (Cast): Perform constant conversions.
29843 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29844 wrappers to the literals here.
29846 * expression.cs (DoNumericPromotions): long literals can converted
29847 to ulong implicity (this is taken care of elsewhere, but I was
29848 missing this spot).
29850 * ecore.cs (Expression.Literalize): Make the return type Literal,
29851 to improve type checking.
29853 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29855 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29857 * literal.cs: Revert code from ravi that checked the bounds. The
29858 bounds are sane by the definition of the type itself.
29860 * typemanager.cs: Fix implementation of ImplementsInterface. We
29861 need to actually look up in our parent hierarchy for interfaces
29864 * const.cs: Use the underlying type for enumerations
29866 * delegate.cs: Compute the basename for the delegate creation,
29867 that should fix the delegate test case, and restore the correct
29868 Type Lookup semantics in rootcontext
29870 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29871 referencing a nested type with the Reflection API is using the "+"
29874 * cs-parser.jay: Do not require EOF token at the end.
29876 2001-12-20 Ravi Pratap <ravi@ximian.com>
29878 * rootcontext.cs (LookupType): Concatenate type names with
29879 a '.' instead of a '+' The test suite passes again.
29881 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29882 field of the enumeration.
29884 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29885 the case when the member is an EventExpr.
29887 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29888 static has an associated instance expression.
29890 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29892 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29894 * class.cs (Event.Define): Register event and perform appropriate checks
29897 We define the Add and Remove methods even if the use provides none because
29898 in that case, we provide default implementations ourselves.
29900 Define a private field of the type of the event. This is done by the CSC compiler
29901 and we should be doing it too ;-)
29903 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29904 More methods we use in code we generate.
29906 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29909 (InitCoreTypes): Update accordingly for the above.
29911 * class.cs (Event.Emit): Generate code for default accessors that we provide
29913 (EmitDefaultMethod): Do the job in the above.
29915 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29918 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29920 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29921 builders even if we were missing one.
29923 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29924 pass the Basename as our class name instead of the Name. The
29925 basename will be correctly composed for us.
29927 * parameter.cs (Paramters): Now takes a Location argument.
29929 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29930 make all the code call directly LookupType in RootContext and take
29931 this chance to pass the Location information everywhere.
29933 * Everywhere: pass Location information.
29935 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29937 * class.cs (Constructor.Define): Updated way of detecting the
29938 length of the parameters.
29940 (TypeContainer.DefineType): Use basename as the type name for
29943 (TypeContainer.Define): Do not recursively define types here, as
29944 definition is taken care in order by the RootContext.
29946 * tree.cs: Keep track of namespaces in a per-file basis.
29948 * parameter.cs (Parameter.ComputeSignature): Update to use
29951 (Parameters.GetSignature): ditto.
29953 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29954 instead of a TypeContainer.
29956 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29957 resolve names. Because we need to be resolve in our context, not
29960 * driver.cs: Implement response files.
29962 * class.cs (TypeContainer.DefineType): If we are defined, do not
29963 redefine ourselves.
29965 (Event.Emit): Emit the code for add/remove handlers.
29966 (Event.Define): Save the MethodBuilders for add/remove.
29968 * typemanager.cs: Use pair here too.
29970 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29971 DictionaryEntry requires the first argument to be non-null.
29973 (enum_declaration): Compute full name for registering the
29976 (delegate_declaration): Instead of using
29977 formal_parameter_list, use opt_formal_parameter_list as the list
29980 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29981 (EventParsing): New property that controls whether `add' and
29982 `remove' are returned as tokens or identifiers (for events);
29984 2001-12-19 Ravi Pratap <ravi@ximian.com>
29986 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29987 use MyEventBuilder only and let it wrap the real builder for us.
29989 (MyEventBuilder): Revamp constructor etc.
29991 Implement all operations that we perform on EventBuilder in precisely the same
29994 (FindMembers): Update to use the EventBuilder member.
29996 (Event.Emit): Update accordingly.
29998 2001-12-18 Ravi Pratap <ravi@ximian.com>
30000 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
30001 by calling the appropriate methods.
30003 (GetCustomAttributes): Make stubs as they cannot possibly do anything
30006 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
30008 2001-12-17 Ravi Pratap <ravi@ximian.com>
30010 * delegate.cs (Delegate.Populate): Check that the return type
30011 and various parameters types are indeed accessible.
30013 * class.cs (Constructor.Define): Same here.
30015 (Field.Define): Ditto.
30017 (Event.Define): Ditto.
30019 (Operator.Define): Check that the underlying Method defined itself
30020 correctly - so it's MethodBuilder should not be null.
30022 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
30023 expression happens to be null.
30025 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
30026 members but as of now we don't seem to be able to do anything really useful with it.
30028 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
30029 not the EventBuilder.
30031 2001-12-18 Miguel de Icaza <miguel@ximian.com>
30033 * cs-tokenizer.cs: Add support for defines.
30034 Add support for #if, #elif, #else, #endif
30036 (eval_var): evaluates a variable.
30037 (eval): stubbed for evaluating functions.
30039 * cs-parser.jay: Pass the defines information
30041 * driver.cs: Add --define command line option.
30043 * decl.cs: Move MemberCore here.
30045 Make it the base class for DeclSpace. This allows us to catch and
30046 report 108 and 109 for everything now.
30048 * class.cs (TypeContainer.Define): Extract all the members
30049 before populating and emit the warning 108 (new keyword required
30050 to override) instead of having each member implement this.
30052 (MemberCore.Define): New abstract method, we will be using this in
30053 the warning reporting engine in Populate.
30055 (Operator.Define): Adjust to new MemberCore protocol.
30057 * const.cs (Const): This does not derive from Expression, it is a
30058 temporary object we use to create fields, it is a MemberCore.
30060 * class.cs (Method.Define): Allow the entry point to be in a
30063 * driver.cs: Rewrite the argument handler to clean it up a bit.
30065 * rootcontext.cs: Made it just an auxiliary namespace feature by
30066 making everything static.
30068 * driver.cs: Adapt code to use RootContext type name instead of
30071 * delegate.cs: Remove RootContext argument.
30073 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
30076 * class.cs (Event.Define): The lookup can fail.
30078 * cs-tokenizer.cs: Begin implementation of pre-procesor.
30080 * expression.cs: Resolve the this instance before invoking the code.
30082 2001-12-17 Miguel de Icaza <miguel@ximian.com>
30084 * cs-parser.jay: Add a production in element_access that allows
30085 the thing to become a "type" reference. This way we can parse
30086 things like "(string [])" as a type.
30088 Note that this still does not handle the more complex rules of
30092 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
30094 * ecore.cs: (CopyNewMethods): new utility function used to
30095 assemble the list of methods from running FindMembers.
30097 (MemberLookup): Rework FindMembers so that
30099 2001-12-16 Miguel de Icaza <miguel@ximian.com>
30101 * class.cs (TypeContainer): Remove Delegates who fail to be
30104 * delegate.cs (Populate): Verify that we dont get null return
30105 values. TODO: Check for AsAccessible.
30107 * cs-parser.jay: Use basename to emit error 574 (destructor should
30108 have the same name as container class), not the full name.
30110 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
30111 possible representation.
30113 Also implements integer type suffixes U and L.
30115 2001-12-15 Miguel de Icaza <miguel@ximian.com>
30117 * expression.cs (ArrayCreation.DoResolve): We need to do the
30118 argument resolution *always*.
30120 * decl.cs: Make this hold the namespace. Hold the root context as
30122 (LookupType): Move here.
30124 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
30126 * location.cs (Row, Name): Fixed the code, it was always returning
30127 references to the first file.
30129 * interface.cs: Register properties defined through interfaces.
30131 * driver.cs: Add support for globbing on the command line
30133 * class.cs (Field): Make it derive from MemberCore as well.
30136 2001-12-15 Ravi Pratap <ravi@ximian.com>
30138 * class.cs (Event::Define): Check that the type of the event is a delegate
30139 type else flag error #66.
30141 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
30144 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
30145 values of EntryPoint, CharSet etc etc.
30147 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
30149 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
30150 be null and we should ignore this. I am not sure if this is really clean. Apparently,
30151 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
30152 which needs this to do its work.
30154 * ../errors/cs0066.cs : Add.
30156 2001-12-14 Miguel de Icaza <miguel@ximian.com>
30158 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
30161 * class.cs: (MethodSignature.MethodSignature): Removed hack that
30162 clears out the parameters field.
30163 (MemberSignatureCompare): Cleanup
30165 (MemberCore): New base class used to share code between MethodCore
30168 (RegisterRequiredImplementations) BindingFlags.Public requires
30169 either BindingFlags.Instace or Static. Use instance here.
30171 (Property): Refactored code to cope better with the full spec.
30173 * parameter.cs (GetParameterInfo): Return an empty array instead
30176 * class.cs (Property): Abstract or extern properties have no bodies.
30178 * parameter.cs (GetParameterInfo): return a zero-sized array.
30180 * class.cs (TypeContainer.MethodModifiersValid): Move all the
30181 method modifier validation to the typecontainer so we can reuse
30182 this on properties.
30184 (MethodCore.ParameterTypes): return an empty sized array of types.
30186 (Property.Define): Test property modifier validity.
30188 Add tests for sealed/override too.
30190 (Method.Emit): abstract or extern methods have no bodies.
30192 2001-12-14 Ravi Pratap <ravi@ximian.com>
30194 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
30197 (Method::Define, ::Emit): Modify accordingly.
30199 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
30201 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
30203 * makefile: Pass in /unsafe.
30205 2001-12-13 Miguel de Icaza <miguel@ximian.com>
30207 * class.cs (MakeKey): Kill routine.
30209 * class.cs (TypeContainer.Define): Correctly define explicit
30210 method implementations (they require the full interface name plus
30213 * typemanager.cs: Deply the PtrHashtable here and stop using the
30214 lame keys. Things work so much better.
30216 This of course broke everyone who depended on `RegisterMethod' to
30217 do the `test for existance' test. This has to be done elsewhere.
30219 * support.cs (PtrHashtable): A hashtable that avoid comparing with
30220 the object stupid Equals method (because, that like fails all over
30221 the place). We still do not use it.
30223 * class.cs (TypeContainer.SetRequiredInterface,
30224 TypeContainer.RequireMethods): Killed these two routines and moved
30225 all the functionality to RegisterRequiredImplementations.
30227 (TypeContainer.RegisterRequiredImplementations): This routine now
30228 registers all the implementations required in an array for the
30229 interfaces and abstract methods. We use an array of structures
30230 which can be computed ahead of time to reduce memory usage and we
30231 also assume that lookups are cheap as most classes will not
30232 implement too many interfaces.
30234 We also avoid creating too many MethodSignatures.
30236 (TypeContainer.IsInterfaceMethod): Update and optionally does not
30237 clear the "pending" bit if we find that there are problems with
30240 (TypeContainer.VerifyPendingMethods): Update to report errors of
30241 methods that look like implementations but are not.
30243 (TypeContainer.Define): Add support for explicit interface method
30246 2001-12-12 Miguel de Icaza <miguel@ximian.com>
30248 * typemanager.cs: Keep track of the parameters here instead of
30249 being a feature of the TypeContainer.
30251 * class.cs: Drop the registration of parameters here, as
30252 InterfaceMethods are also interface declarations.
30254 * delegate.cs: Register methods with the TypeManager not only with
30255 the TypeContainer. This code was buggy.
30257 * interface.cs: Full registation here.
30259 2001-12-11 Miguel de Icaza <miguel@ximian.com>
30261 * expression.cs: Remove reducer for binary expressions, it can not
30264 * const.cs: Put here the code that used to go into constant.cs
30266 * constant.cs: Put here the code for constants, this is a new base
30267 class for Literals.
30269 * literal.cs: Make Literal derive from Constant.
30271 2001-12-09 Miguel de Icaza <miguel@ximian.com>
30273 * statement.cs (Return.Emit): Report error 157 if the user
30274 attempts to return from a finally block.
30276 (Return.Emit): Instead of emitting a return, jump to the end of
30279 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
30280 LocalBuilder to store the result of the function. ReturnLabel is
30281 the target where we jump.
30284 2001-12-09 Radek Doulik <rodo@ximian.com>
30286 * cs-parser.jay: remember alias in current namespace
30288 * ecore.cs (SimpleName::DoResolve): use aliases for types or
30291 * class.cs (LookupAlias): lookup alias in my_namespace
30293 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
30295 (LookupAlias): lookup alias in this and if needed in parent
30298 2001-12-08 Miguel de Icaza <miguel@ximian.com>
30302 * rootcontext.cs: (ModuleBuilder) Made static, first step into
30303 making things static. I need this to avoid passing the
30304 TypeContainer when calling ParameterType.
30306 * support.cs (InternalParameters.ParameterType): Remove ugly hack
30307 that did string manipulation to compute the type and then call
30308 GetType. Use Parameter.ParameterType instead.
30310 * cs-tokenizer.cs: Consume the suffix for floating values.
30312 * expression.cs (ParameterReference): figure out whether this is a
30313 reference parameter or not. Kill an extra variable by computing
30314 the arg_idx during emission.
30316 * parameter.cs (Parameters.GetParameterInfo): New overloaded
30317 function that returns whether a parameter is an out/ref value or not.
30319 (Parameter.ParameterType): The type of the parameter (base,
30320 without ref/out applied).
30322 (Parameter.Resolve): Perform resolution here.
30323 (Parameter.ExternalType): The full type (with ref/out applied).
30325 * statement.cs (Using.Emit, Using.EmitExpression): Implement
30326 support for expressions on the using statement.
30328 2001-12-07 Miguel de Icaza <miguel@ximian.com>
30330 * statement.cs (Using.EmitLocalVariableDecls): Split the
30331 localvariable handling of the using statement.
30333 (Block.EmitMeta): Keep track of variable count across blocks. We
30334 were reusing slots on separate branches of blocks.
30336 (Try.Emit): Emit the general code block, we were not emitting it.
30338 Check the type of the declaration to be an IDisposable or
30339 something that can be implicity converted to it.
30341 Emit conversions if required.
30343 * ecore.cs (EmptyExpression): New utility class.
30344 (Expression.ImplicitConversionExists): New utility function.
30346 2001-12-06 Miguel de Icaza <miguel@ximian.com>
30348 * statement.cs (Using): Implement.
30350 * expression.cs (LocalVariableReference): Support read only variables.
30352 * statement.cs: Remove the explicit emit for the Leave opcode.
30353 (VariableInfo): Add a readonly field.
30355 2001-12-05 Miguel de Icaza <miguel@ximian.com>
30357 * ecore.cs (ConvCast): new class used to encapsulate the various
30358 explicit integer conversions that works in both checked and
30359 unchecked contexts.
30361 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30362 properly generate the overflow opcodes.
30364 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30366 * statement.cs: The correct type for the EmptyExpression is the
30367 element_type, not the variable type. Ravi pointed this out.
30369 2001-12-04 Ravi Pratap <ravi@ximian.com>
30371 * class.cs (Method::Define): Handle PInvoke methods specially
30372 by using DefinePInvokeMethod instead of the usual one.
30374 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30375 above to do the task of extracting information and defining the method.
30377 2001-12-04 Ravi Pratap <ravi@ximian.com>
30379 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30380 of the condition for string type.
30382 (Emit): Move that here.
30384 (ArrayCreation::CheckIndices): Keep string literals in their expression
30387 (EmitDynamicInitializers): Handle strings appropriately.
30389 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30391 * codegen.cs (EmitContext): Replace multiple variables with a
30392 single pointer to the current Switch statement.
30394 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30397 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30401 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30404 (Foreach.Emit): Foreach on arrays was not setting
30405 up the loop variables (for break/continue).
30407 (GotoCase): Semi-implented.
30409 2001-12-03 Ravi Pratap <ravi@ximian.com>
30411 * attribute.cs (CheckAttribute): Handle system attributes by using
30412 Attribute.GetAttributes to examine information we need.
30414 (GetValidPlaces): Same here.
30416 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30418 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30420 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30422 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30424 (Method::Emit): Handle the case when we are a PInvoke method.
30426 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30428 * expression.cs: Use ResolveWithSimpleName on compound names.
30430 2001-12-02 Ravi Pratap <ravi@ximian.com>
30432 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30433 before trying to reduce it.
30435 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30437 * constant.cs (LookupConstantValue): Implement.
30439 (EmitConstant): Use the above in emitting the constant.
30441 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30442 that are user-defined by doing a LookupConstantValue on them.
30444 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30447 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30449 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30451 (BaseAccess.DoResolve): Implement.
30453 (MemberAccess.DoResolve): Split this routine into a
30454 ResolveMemberAccess routine that can be used independently
30456 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30458 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30459 As that share bits of the implementation. Is returns a boolean,
30460 while As returns the Type that is being probed.
30462 2001-12-01 Ravi Pratap <ravi@ximian.com>
30464 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30465 instead of a Literal - much easier.
30467 (EnumInTransit): Remove - utterly useless :-)
30469 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30471 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30473 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30474 chain when we have no associated expression.
30476 2001-11-30 Ravi Pratap <ravi@ximian.com>
30478 * constant.cs (Define): Use Location while reporting the errror.
30480 Also emit a warning when 'new' is used and there is no inherited
30483 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30486 (LookupEnumValue): Implement to lookup an enum member's value and define it
30489 (Populate): Re-write accordingly to use the above routine.
30491 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30493 * expression.cs (This): Fix prototype for DoResolveLValue to
30494 override the base class DoResolveLValue.
30496 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30499 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30500 (we need to load the address of the field here). This fixes
30503 (FieldExpr.DoResolveLValue): Call the DoResolve
30504 function to initialize the Instance expression.
30506 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30507 correctly the GetEnumerator operation on a value type.
30509 * cs-parser.jay: Add more simple parsing error catches.
30511 * statement.cs (Switch): Add support for string switches.
30512 Handle null specially.
30514 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30516 2001-11-28 Ravi Pratap <ravi@ximian.com>
30518 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30520 (declare_local_constant): New helper function.
30522 * statement.cs (AddConstant): Keep a separate record of constants
30524 (IsConstant): Implement to determine if a variable is a constant.
30526 (GetConstantExpression): Implement.
30528 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30530 * statement.cs (IsVariableDefined): Re-write.
30532 2001-11-27 Ravi Pratap <ravi@ximian.com>
30534 * class.cs (TypeContainer::FindMembers): Look for constants
30535 in the case when we are looking for MemberTypes.Field
30537 * expression.cs (MemberAccess::DoResolve): Check that in the
30538 case we are a FieldExpr and a Literal, we are not being accessed
30539 by an instance reference.
30541 * cs-parser.jay (local_constant_declaration): Implement.
30543 (declaration_statement): Implement for constant declarations.
30545 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30547 * statement.cs (Switch): Catch double defaults.
30549 (Switch): More work on the switch() statement
30550 implementation. It works for integral values now, need to finish
30554 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30556 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30557 integer literals into other integer literals. To be used by
30560 2001-11-24 Ravi Pratap <ravi@ximian.com>
30562 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30565 (EmitDynamicInitializers): Cope with the above since we extract data
30566 directly from ArrayData now.
30568 (ExpectInitializers): Keep track of whether initializers are mandatory
30571 (Bounds): Make it a hashtable to prevent the same dimension being
30572 recorded for every element in that dimension.
30574 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30577 Also fix bug which was causing the indices to be emitted in the reverse
30580 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30582 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30583 unfinished. They do not work, because the underlying code is
30586 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30588 * cs-parser.jay: Remove bogus fixme.
30590 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30591 on Switch statement.
30593 2001-11-23 Ravi Pratap <ravi@ximian.com>
30595 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30598 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30599 parameter. Apparently, any expression is allowed.
30601 (ValidateInitializers): Update accordingly.
30603 (CheckIndices): Fix some tricky bugs thanks to recursion.
30605 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30606 I was being completely brain-dead.
30608 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30609 and re-write acordingly.
30611 (DelegateInvocation): Re-write accordingly.
30613 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30615 (MakeByteBlob): Handle types more correctly.
30617 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30618 initialization from expressions but it is incomplete because I am a complete
30621 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30623 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30624 on If. Basically, we have to return `true' (ie, we do return to
30625 our caller) only if both branches of the if return.
30627 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30628 short-circuit operators, handle them as short circuit operators.
30630 (Cast.DoResolve): Resolve type.
30631 (Cast.Cast): Take an expression as the target type.
30633 * cs-parser.jay (cast_expression): Remove old hack that only
30634 allowed a limited set of types to be handled. Now we take a
30635 unary_expression and we resolve to a type during semantic
30638 Use the grammar productions from Rhys to handle casts (this is
30639 not complete like Rhys syntax yet, we fail to handle that corner
30640 case that C# has regarding (-x), but we will get there.
30642 2001-11-22 Ravi Pratap <ravi@ximian.com>
30644 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30645 field which is an array type.
30647 * cs-parser.jay (declare_local_variables): Support array initialization too.
30649 * typemanager.cs (MakeKey): Implement.
30651 (everywhere): Use the above appropriately.
30653 * cs-parser.jay (for_statement): Update for array initialization while
30654 declaring variables.
30656 * ecore.cs : The error message was correct, it's the variable's names that
30657 were misleading ;-) Make the code more readable.
30659 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30660 the correct type etc.
30662 (ConvertExplicit): Handle Enum types by examining the underlying type.
30664 2001-11-21 Ravi Pratap <ravi@ximian.com>
30666 * parameter.cs (GetCallingConvention): Always return
30667 CallingConventions.Standard for now.
30669 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30671 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30672 and `r' after calling DoNumericPromotions.
30674 * ecore.cs: Fix error message (the types were in the wrong order).
30676 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30677 BindingFlags.Instance as well
30679 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30680 implicit int literal conversion in an empty cast so that we
30681 propagate the right type upstream.
30683 (UnboxCast): new class used to unbox value types.
30684 (Expression.ConvertExplicit): Add explicit type conversions done
30687 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30688 the target type before applying the implicit LongLiterals to ULong
30691 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30693 * cs-parser.jay (for_statement): Reworked the way For works: now
30694 we declare manually any variables that are introduced in
30695 for_initializer to solve the problem of having out-of-band code
30696 emition (that is what got for broken).
30698 (declaration_statement): Perform the actual variable declaration
30699 that used to be done in local_variable_declaration here.
30701 (local_variable_declaration): Do not declare anything, just pass
30702 the information on a DictionaryEntry
30704 2001-11-20 Ravi Pratap <ravi@ximian.com>
30706 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30707 re-write of the logic to now make it recursive.
30709 (UpdateIndices): Re-write accordingly.
30711 Store element data in a separate ArrayData list in the above methods.
30713 (MakeByteBlob): Implement to dump the array data into a byte array.
30715 2001-11-19 Ravi Pratap <ravi@ximian.com>
30717 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30720 * constant.cs (Define): Implement.
30722 (EmitConstant): Re-write fully.
30724 Pass in location info.
30726 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30729 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30730 DictionaryEntry since we need location info too.
30732 (constant_declaration): Update accordingly.
30734 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30735 code into another method : UpdateIndices.
30737 2001-11-18 Ravi Pratap <ravi@ximian.com>
30739 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30740 some type checking etc.
30742 2001-11-17 Ravi Pratap <ravi@ximian.com>
30744 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30745 bits to provide dimension info if the user skips doing that.
30747 Update second constructor to store the rank correctly.
30749 2001-11-16 Ravi Pratap <ravi@ximian.com>
30751 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30752 and try to implement.
30754 * ../errors/cs0150.cs : Add.
30756 * ../errors/cs0178.cs : Add.
30758 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30760 * statement.cs: Implement foreach on multi-dimensional arrays.
30762 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30763 name of the params argument.
30765 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30766 initializing the array.
30768 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30769 we can use this elsewhere.
30771 * statement.cs: Finish implementation of foreach for single
30774 * cs-parser.jay: Use an out-of-band stack to pass information
30775 around, I wonder why I need this.
30777 foreach_block: Make the new foreach_block the current_block.
30779 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30780 function used to return a static Parameters structure. Used for
30781 empty parameters, as those are created very frequently.
30783 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30785 2001-11-15 Ravi Pratap <ravi@ximian.com>
30787 * interface.cs : Default modifier is private, not public. The
30788 make verify test passes again.
30790 2001-11-15 Ravi Pratap <ravi@ximian.com>
30792 * support.cs (ReflectionParameters): Fix logic to determine
30793 whether the last parameter is a params one. Test 9 passes again.
30795 * delegate.cs (Populate): Register the builders we define with
30796 RegisterParameterForBuilder. Test 19 passes again.
30798 * cs-parser.jay (property_declaration): Reference $6 instead
30799 of $$ to get at the location.
30801 (indexer_declaration): Similar stuff.
30803 (attribute): Ditto.
30805 * class.cs (Property): Register parameters for the Get and Set methods
30806 if they exist. Test 23 passes again.
30808 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30809 call to EmitArguments as we are sure there aren't any params arguments.
30810 Test 32 passes again.
30812 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30813 IndexOutOfRangeException.
30815 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30816 Test 33 now passes again.
30818 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30820 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30821 broke a bunch of things. Will have to come up with a better way
30822 of tracking locations.
30824 * statement.cs: Implemented foreach for single dimension arrays.
30826 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30828 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30829 an error. This removes the lookup from the critical path.
30831 * cs-parser.jay: Removed use of temporary_loc, which is completely
30834 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30836 * support.cs (ReflectionParameters.ParameterModifier): Report
30837 whether the argument is a PARAMS argument or not.
30839 * class.cs: Set the attribute `ParamArrayAttribute' on the
30840 parameter argument.
30842 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30843 and cons_param_array_attribute (ConstructorInfo for
30844 ParamArrayAttribute).,
30846 * codegen.cs: Emit the return using the `Return' statement, that
30847 way we can report the error correctly for missing return values.
30849 * class.cs (Method.Emit): Clean up.
30851 * expression.cs (Argument.Resolve): Take another argument: the
30852 location where this argument is used. Notice that this is not
30853 part of the "Argument" class as to reduce the size of the
30854 structure (we know the approximate location anyways).
30856 Test if the argument is a variable-reference, if not, then
30857 complain with a 206.
30859 (Argument.Emit): Emit addresses of variables.
30861 (Argument.FullDesc): Simplify.
30863 (Invocation.DoResolve): Update for Argument.Resolve.
30865 (ElementAccess.DoResolve): ditto.
30867 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30868 method should be virtual, as this method is always virtual.
30870 (NewDelegate.DoResolve): Update for Argument.Resolve.
30872 * class.cs (ConstructorInitializer.DoResolve): ditto.
30874 * attribute.cs (Attribute.Resolve): ditto.
30876 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30878 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30880 * expression.cs (ParameterReference): Drop IStackStorage and implement
30881 IAssignMethod instead.
30883 (LocalVariableReference): ditto.
30885 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30886 IAssignMethod instead.
30888 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30890 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30891 enumerations that are used in heavily used structures derive from
30892 byte in a laughable and pathetic attempt to reduce memory usage.
30893 This is the kind of pre-optimzations that you should not do at
30894 home without adult supervision.
30896 * expression.cs (UnaryMutator): New class, used to handle ++ and
30897 -- separatedly from the other unary operators. Cleans up the
30898 code, and kills the ExpressionStatement dependency in Unary.
30900 (Unary): Removed `method' and `Arguments' from this class, making
30901 it smaller, and moving it all to SimpleCall, so I can reuse this
30902 code in other locations and avoid creating a lot of transient data
30903 strucutres when not required.
30905 * cs-parser.jay: Adjust for new changes.
30907 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30909 * enum.cs (Enum.Populate): If there is a failure during
30912 * cs-parser.jay (opt_enum_base): we used to catch type errors
30913 here, but this is really incorrect. The type error should be
30914 catched during semantic analysis.
30916 2001-12-11 Ravi Pratap <ravi@ximian.com>
30918 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30919 current_local_parameters as expected since I, in my stupidity, had forgotten
30922 * attribute.cs (GetValidPlaces): Fix stupid bug.
30924 * class.cs (Method::Emit): Perform check on applicability of attributes.
30926 (Constructor::Emit): Ditto.
30928 (Field::Emit): Ditto.
30930 (Field.Location): Store location information.
30932 (Property, Event, Indexer, Operator): Ditto.
30934 * cs-parser.jay (field_declaration): Pass in location for each field.
30936 * ../errors/cs0592.cs : Add.
30938 2001-11-12 Ravi Pratap <ravi@ximian.com>
30940 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30942 (InitCoreTypes): Update accordingly.
30944 (RegisterAttrType, LookupAttr): Implement.
30946 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30947 info about the same.
30949 (Resolve): Update to populate the above as necessary.
30951 (Error592): Helper.
30953 (GetValidPlaces): Helper to the above.
30955 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30957 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30959 2001-11-12 Ravi Pratap <ravi@ximian.com>
30961 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30963 * ../errors/cs0617.cs : Add.
30965 2001-11-11 Ravi Pratap <ravi@ximian.com>
30967 * enum.cs (Emit): Rename to Populate to be more consistent with what
30968 we expect it to do and when exactly it is called.
30970 * class.cs, rootcontext.cs : Update accordingly.
30972 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30973 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30975 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30977 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30978 of a fieldinfo using the above, when dealing with a FieldBuilder.
30980 2001-11-10 Ravi Pratap <ravi@ximian.com>
30982 * ../errors/cs0031.cs : Add.
30984 * ../errors/cs1008.cs : Add.
30986 * ../errrors/cs0543.cs : Add.
30988 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30991 (FindMembers): Implement.
30993 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30994 enums and delegates too.
30996 (enum_types): Rename to builder_to_enum.
30998 (delegate_types): Rename to builder_to_delegate.
31000 * delegate.cs (FindMembers): Implement.
31002 2001-11-09 Ravi Pratap <ravi@ximian.com>
31004 * typemanager.cs (IsEnumType): Implement.
31006 * enum.cs (Emit): Re-write parts to account for the underlying type
31007 better and perform checking etc.
31009 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
31010 of the underlying type.
31012 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
31015 * enum.cs (error31): Helper to report error #31.
31017 * cs-parser.jay (enum_declaration): Store location of each member too.
31019 * enum.cs (member_to_location): New hashtable.
31021 (AddEnumMember): Update location hashtable.
31023 (Emit): Use the location of each member while reporting errors.
31025 2001-11-09 Miguel de Icaza <miguel@ximian.com>
31027 * cs-parser.jay: A for_initializer if is a
31028 local_variable_declaration really ammount to have an implicit
31029 block with the variable declaration and no initializer for for.
31031 * statement.cs (For.Emit): Cope with null initializers.
31033 This fixes the infinite loop on for initializers.
31035 2001-11-08 Miguel de Icaza <miguel@ximian.com>
31037 * enum.cs: More cleanup.
31039 * ecore.cs: Remove dead code.
31041 * class.cs (Property.Emit): More simplification.
31042 (Event.Emit): ditto.
31044 Reworked to have less levels of indentation.
31046 2001-11-08 Ravi Pratap <ravi@ximian.com>
31048 * class.cs (Property): Emit attributes.
31058 * enum.cs (Emit): Ditto.
31060 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
31063 * class.cs (Field, Event, etc.): Move attribute generation into the
31064 Emit method everywhere.
31066 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
31067 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
31068 as we had no way of defining nested enums !
31070 * rootcontext.cs : Adjust code accordingly.
31072 * typemanager.cs (AddEnumType): To keep track of enum types separately.
31074 2001-11-07 Ravi Pratap <ravi@ximian.com>
31076 * expression.cs (EvalConstantExpression): Move into ecore.cs
31078 * enum.cs (Enum): Rename some members and make them public and readonly
31079 according to our convention.
31081 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
31084 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
31086 (Enum::Emit): Write a simple version for now which doesn't try to compute
31087 expressions. I shall modify this to be more robust in just a while.
31089 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
31091 (TypeContainer::CloseType): Create the Enum types too.
31093 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
31095 * expression.cs (EvalConstantExpression): Get rid of completely.
31097 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
31098 user-defined values and other cases.
31100 (IsValidEnumLiteral): Helper function.
31102 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
31103 out there in the case we had a literal FieldExpr.
31105 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
31107 (Literalize): Revamp a bit to take two arguments.
31109 (EnumLiteral): New class which derives from Literal to wrap enum literals.
31111 2001-11-06 Ravi Pratap <ravi@ximian.com>
31113 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
31115 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
31117 (Resolve): Use the above to ensure we have proper initializers.
31119 2001-11-05 Ravi Pratap <ravi@ximian.com>
31121 * expression.cs (Expression::EvalConstantExpression): New method to
31122 evaluate constant expressions.
31124 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
31126 2001-11-07 Miguel de Icaza <miguel@ximian.com>
31128 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
31131 (Binary.ResolveOperator): Handle operator != (object a, object b)
31132 and operator == (object a, object b);
31134 (Binary.DoNumericPromotions): Indicate whether the numeric
31135 promotion was possible.
31137 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
31140 Made the ArrayAccess implement interface IAssignMethod instead of
31141 IStackStore as the order in which arguments are passed reflects
31144 * assign.cs: Instead of using expr.ExprClass to select the way of
31145 assinging, probe for the IStackStore/IAssignMethod interfaces.
31147 * typemanager.cs: Load InitializeArray definition.
31149 * rootcontext.cs (RootContext.MakeStaticData): Used to define
31150 static data that can be used to initialize arrays.
31152 2001-11-05 Miguel de Icaza <miguel@ximian.com>
31154 * expression.cs: Handle operator== and operator!= for booleans.
31156 (Conditioal.Reduce): Implement reducer for the ?: operator.
31158 (Conditional.Resolve): Implement dead code elimination.
31160 (Binary.Resolve): Catch string literals and return a new
31161 concatenated string.
31163 (Unary.Reduce): Implement reduction of unary expressions.
31165 * ecore.cs: Split out the expression core handling here.
31167 (Expression.Reduce): New method used to perform constant folding
31168 and CSE. This is needed to support constant-expressions.
31170 * statement.cs (Statement.EmitBoolExpression): Pass true and false
31171 targets, and optimize for !x.
31173 2001-11-04 Ravi Pratap <ravi@ximian.com>
31175 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
31176 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
31177 set custom atttributes.
31179 * literal.cs (Literal::GetValue): New abstract method to return the actual
31180 value of the literal, cast as an object.
31182 (*Literal): Implement GetValue method.
31184 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
31185 expressions to the arraylist but objects of type Argument.
31187 * class.cs (TypeContainer::Emit): Emit our attributes too.
31189 (Method::Emit, Constructor::Emit): Ditto.
31191 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
31192 to be ignoring earlier.
31194 2001-11-03 Ravi Pratap <ravi@ximian.com>
31196 * attribute.cs (AttributeSection::Define): Implement to do the business
31197 of constructing a CustomAttributeBuilder.
31199 (Attribute): New trivial class. Increases readability of code.
31201 * cs-parser.jay : Update accordingly.
31203 (positional_argument_list, named_argument_list, named_argument): New rules
31205 (attribute_arguments): Use the above so that we are more correct.
31207 2001-11-02 Ravi Pratap <ravi@ximian.com>
31209 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
31210 to perform all checks for a method with a params parameter.
31212 (Invocation::OverloadResolve): Update to use the above method and therefore
31213 cope correctly with params method invocations.
31215 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
31218 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
31219 constructors in our parent too because we can't afford to miss out on
31222 * attribute.cs (AttributeSection): New name for the class Attribute
31224 Other trivial changes to improve readability.
31226 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
31227 use the new class names.
31229 2001-11-01 Ravi Pratap <ravi@ximian.com>
31231 * class.cs (Method::Define): Complete definition for params types too
31233 (Indexer::Define): Ditto.
31235 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
31236 Cope everywhere with a request for info about the array parameter.
31238 2001-11-01 Ravi Pratap <ravi@ximian.com>
31240 * tree.cs (RecordNamespace): Fix up to check for the correct key.
31242 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
31243 local_variable_type to extract the string corresponding to the type.
31245 (local_variable_type): Fixup the action to use the new helper method.
31247 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
31250 * expression.cs : Clean out code which uses the above.
31252 2001-10-31 Ravi Pratap <ravi@ximian.com>
31254 * typemanager.cs (RegisterMethod): Check if we already have an existing key
31255 and bale out if necessary by returning a false.
31257 (RegisterProperty): Ditto.
31259 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
31260 and print out appropriate error messages.
31262 * interface.cs (everywhere): Ditto.
31264 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
31265 location to constructor.
31267 * class.cs (Property, Event, Indexer): Update accordingly.
31269 * ../errors/cs111.cs : Added.
31271 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
31272 of a method, as laid down by the spec.
31274 (Invocation::OverloadResolve): Use the above method.
31276 2001-10-31 Ravi Pratap <ravi@ximian.com>
31278 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
31279 now take a TypeContainer and a Parameters object.
31281 (ParameterData): Modify return type of ParameterModifier method to be
31282 Parameter.Modifier and not a string.
31284 (ReflectionParameters, InternalParameters): Update accordingly.
31286 * expression.cs (Argument::GetParameterModifier): Same here.
31288 * support.cs (InternalParameters::ParameterType): Find a better way of determining
31289 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
31290 symbol in it at all so maybe this is only for now.
31292 2001-10-30 Ravi Pratap <ravi@ximian.com>
31294 * support.cs (InternalParameters): Constructor now takes an extra argument
31295 which is the actual Parameters class.
31297 (ParameterDesc): Update to provide info on ref/out modifiers.
31299 * class.cs (everywhere): Update call to InternalParameters to pass in
31300 the second argument too.
31302 * support.cs (ParameterData): Add ParameterModifier, which is a method
31303 to return the modifier info [ref/out etc]
31305 (InternalParameters, ReflectionParameters): Implement the above.
31307 * expression.cs (Argument::ParameterModifier): Similar function to return
31308 info about the argument's modifiers.
31310 (Invocation::OverloadResolve): Update to take into account matching modifiers
31313 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
31314 a new SetFormalParameters object which we pass to InternalParameters.
31316 2001-10-30 Ravi Pratap <ravi@ximian.com>
31318 * expression.cs (NewArray): Merge into the ArrayCreation class.
31320 2001-10-29 Ravi Pratap <ravi@ximian.com>
31322 * expression.cs (NewArray): Merge classes NewBuiltinArray and
31323 NewUserdefinedArray into one as there wasn't much of a use in having
31326 * expression.cs (Argument): Change field's name to ArgType from Type.
31328 (Type): New readonly property which returns the proper type, taking into
31329 account ref/out modifiers.
31331 (everywhere): Adjust code accordingly for the above.
31333 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
31334 whether we are emitting for a ref or out parameter.
31336 * expression.cs (Argument::Emit): Use the above field to set the state.
31338 (LocalVariableReference::Emit): Update to honour the flag and emit the
31341 * parameter.cs (Attributes): Set the correct flags for ref parameters.
31343 * expression.cs (Argument::FullDesc): New function to provide a full desc.
31345 * support.cs (ParameterData): Add method ParameterDesc to the interface.
31347 (ReflectionParameters, InternalParameters): Implement the above method.
31349 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
31352 (Invocation::FullMethodDesc): Ditto.
31354 2001-10-29 Miguel de Icaza <miguel@ximian.com>
31356 * cs-parser.jay: Add extra production for the second form of array
31359 * expression.cs (ArrayCreation): Update to reflect the above
31362 * Small changes to prepare for Array initialization.
31364 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31366 * typemanager.cs (ImplementsInterface): interface might be null;
31367 Deal with this problem;
31369 Also, we do store negative hits on the cache (null values), so use
31370 this instead of calling t.GetInterfaces on the type everytime.
31372 2001-10-28 Ravi Pratap <ravi@ximian.com>
31374 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31376 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31377 split functionality out into different classes.
31379 (New::FormArrayType): Move into NewBuiltinArray.
31381 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31384 (NewBuiltinArray): New class to handle creation of built-in arrays.
31386 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31387 account creation of one-dimensional arrays.
31389 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31391 (NewUserdefinedArray::DoResolve): Implement.
31393 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31395 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31396 we maintain inside the TypeManager. This is necessary to perform lookups on the
31399 (LookupType): Update to perform GetType on the module builders too.
31401 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31403 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31405 2001-10-23 Ravi Pratap <ravi@ximian.com>
31407 * expression.cs (New::DoResolve): Implement guts of array creation.
31409 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31411 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31413 * expression.cs: Fix bug I introduced lsat night that broke
31416 (Expression.Resolve): Report a 246 error (can not resolve name)
31417 if we find a SimpleName in the stream.
31419 (Expression.ResolveLValue): Ditto.
31421 (Expression.ResolveWithSimpleName): This function is a variant of
31422 ResolveName, this one allows SimpleNames to be returned without a
31423 warning. The only consumer of SimpleNames is MemberAccess
31425 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31427 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31428 might arrive here. I have my doubts that this is correct.
31430 * statement.cs (Lock): Implement lock statement.
31432 * cs-parser.jay: Small fixes to support `lock' and `using'
31434 * cs-tokenizer.cs: Remove extra space
31436 * driver.cs: New flag --checked, allows to turn on integer math
31439 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31440 Threading.Monitor.Exit
31442 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31444 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31445 Expression Class to be IndexerAccess.
31447 Notice that Indexer::DoResolve sets the eclass to Value.
31449 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31451 * class.cs (TypeContainer::Emit): Emit code for indexers.
31453 * assign.cs (IAssignMethod): New interface implemented by Indexers
31454 and Properties for handling assignment.
31456 (Assign::Emit): Simplify and reuse code.
31458 * expression.cs (IndexerAccess, PropertyExpr): Implement
31459 IAssignMethod, clean up old code.
31461 2001-10-22 Ravi Pratap <ravi@ximian.com>
31463 * typemanager.cs (ImplementsInterface): New method to determine if a type
31464 implements a given interface. Provides a nice cache too.
31466 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31469 (ConvertReferenceExplicit): Ditto.
31471 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31472 various methods, with correct names etc.
31474 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31475 Operator.UnaryNegation.
31477 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31478 we have a unary plus or minus operator.
31480 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31483 * everywhere : update accordingly.
31485 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31488 * class.cs (Method::Define): For the case where we are implementing a method
31489 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31490 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31492 2001-10-21 Ravi Pratap <ravi@ximian.com>
31494 * interface.cs (FindMembers): Implement to work around S.R.E
31497 * typemanager.cs (IsInterfaceType): Implement.
31499 (FindMembers): Update to handle interface types too.
31501 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31502 use IsAssignableFrom as that is not correct - it doesn't work.
31504 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31505 and accordingly override EmitStatement.
31507 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31508 using the correct logic :-)
31510 2001-10-19 Ravi Pratap <ravi@ximian.com>
31512 * ../errors/cs-11.cs : Add to demonstrate error -11
31514 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31516 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31517 then pass this as a hint to ResolveLValue.
31519 * expression.cs (FieldExpr): Add Location information
31521 (FieldExpr::LValueResolve): Report assignment to readonly
31524 (Expression::ExprClassFromMemberInfo): Pass location information.
31526 (Expression::ResolveLValue): Add new method that resolves an
31529 (Expression::DoResolveLValue): Default invocation calls
31532 (Indexers): New class used to keep track of indexers in a given
31535 (IStackStore): Renamed from LValue, as it did not really describe
31536 what this did. Also ResolveLValue is gone from this interface and
31537 now is part of Expression.
31539 (ElementAccess): Depending on the element access type
31541 * typemanager.cs: Add `indexer_name_type' as a Core type
31542 (System.Runtime.CompilerServices.IndexerNameAttribute)
31544 * statement.cs (Goto): Take a location.
31546 2001-10-18 Ravi Pratap <ravi@ximian.com>
31548 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31549 if two delegates are compatible.
31551 (NewDelegate::DoResolve): Update to take care of the case when
31552 we instantiate a delegate from another delegate.
31554 * typemanager.cs (FindMembers): Don't even try to look up members
31555 of Delegate types for now.
31557 2001-10-18 Ravi Pratap <ravi@ximian.com>
31559 * delegate.cs (NewDelegate): New class to take care of delegate
31562 * expression.cs (New): Split the delegate related code out into
31563 the NewDelegate class.
31565 * delegate.cs (DelegateInvocation): New class to handle delegate
31568 * expression.cs (Invocation): Split out delegate related code into
31569 the DelegateInvocation class.
31571 2001-10-17 Ravi Pratap <ravi@ximian.com>
31573 * expression.cs (New::DoResolve): Implement delegate creation fully
31574 and according to the spec.
31576 (New::DoEmit): Update to handle delegates differently.
31578 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31579 because of which we were printing out arguments in reverse order !
31581 * delegate.cs (VerifyMethod): Implement to check if the given method
31582 matches the delegate.
31584 (FullDelegateDesc): Implement.
31586 (VerifyApplicability): Implement.
31588 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31589 delegate invocations too.
31591 (Invocation::Emit): Ditto.
31593 * ../errors/cs1593.cs : Added.
31595 * ../errors/cs1594.cs : Added.
31597 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31599 2001-10-16 Ravi Pratap <ravi@ximian.com>
31601 * typemanager.cs (intptr_type): Core type for System.IntPtr
31603 (InitCoreTypes): Update for the same.
31605 (iasyncresult_type, asynccallback_type): Ditto.
31607 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31610 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31613 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31614 the builders for the 4 members of a delegate type :-)
31616 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31619 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31621 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31623 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31625 * statement.cs (Break::Emit): Implement.
31626 (Continue::Emit): Implement.
31628 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31629 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31630 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31631 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31634 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31635 properties that track the label for the current loop (begin of the
31636 loop and end of the loop).
31638 2001-10-15 Ravi Pratap <ravi@ximian.com>
31640 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31641 use of emitting anything at all.
31643 * class.cs, rootcontext.cs : Get rid of calls to the same.
31645 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31647 (Populate): Define the constructor correctly and set the implementation
31650 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31653 (AddDelegateType): Implement.
31655 (IsDelegateType): Implement helper method.
31657 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31659 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31660 and accordingly handle it.
31662 * delegate.cs (Populate): Take TypeContainer argument.
31663 Implement bits to define the Invoke method. However, I still haven't figured out
31664 how to take care of the native int bit :-(
31666 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31667 Qualify the name of the delegate, not its return type !
31669 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31672 (StandardConversionExists): Checking for array types turns out to be recursive.
31674 (ConvertReferenceExplicit): Implement array conversion.
31676 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31678 2001-10-12 Ravi Pratap <ravi@ximian.com>
31680 * cs-parser.jay (delegate_declaration): Store the fully qualified
31681 name as it is a type declaration.
31683 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31686 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31687 as TypeContainer::DefineType.
31689 (Populate): Method in which all the definition of the various methods (Invoke)
31692 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31695 (CloseDelegate): Finally creates the delegate.
31697 * class.cs (TypeContainer::DefineType): Update to define delegates.
31698 (Populate, Emit and CloseType): Do the same thing here too.
31700 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31701 delegates in all these operations.
31703 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31705 * expression.cs: LocalTemporary: a new expression used to
31706 reference a temporary that has been created.
31708 * assign.cs: Handle PropertyAccess back here, so that we can
31709 provide the proper semantic access to properties.
31711 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31712 a few more explicit conversions.
31714 * modifiers.cs: `NEW' modifier maps to HideBySig.
31716 * expression.cs (PropertyExpr): Make this into an
31717 ExpressionStatement, and support the EmitStatement code path.
31719 Perform get/set error checking, clean up the interface.
31721 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31722 them into toplevel access objects.
31724 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31726 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31729 * typemanager.cs: Keep track here of our PropertyBuilders again to
31730 work around lameness in SRE.
31732 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31734 * expression.cs (LValue::LValueResolve): New method in the
31735 interface, used to perform a second resolution pass for LValues.
31737 (This::DoResolve): Catch the use of this in static methods.
31739 (This::LValueResolve): Implement.
31741 (This::Store): Remove warning, assigning to `this' in structures
31744 (Invocation::Emit): Deal with invocation of
31745 methods on value types. We need to pass the address to structure
31746 methods rather than the object itself. (The equivalent code to
31747 emit "this" for structures leaves the entire structure on the
31748 stack instead of a pointer to it).
31750 (ParameterReference::DoResolve): Compute the real index for the
31751 argument based on whether the method takes or not a `this' pointer
31752 (ie, the method is static).
31754 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31755 value types returned from functions when we need to invoke a
31756 method on the sturcture.
31759 2001-10-11 Ravi Pratap <ravi@ximian.com>
31761 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31762 defining the type in the Modulebuilder or Typebuilder. This is to take
31763 care of nested types which need to be defined on the TypeBuilder using
31764 DefineNestedMethod.
31766 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31767 methods in RootContext, only ported to be part of TypeContainer.
31769 (TypeContainer::GetInterfaceOrClass): Ditto.
31771 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31773 * interface.cs (Interface::DefineInterface): New method. Does exactly
31774 what RootContext.CreateInterface did earlier, only it takes care of nested types
31777 (Interface::GetInterfaces): Move from RootContext here and port.
31779 (Interface::GetInterfaceByName): Same here.
31781 * rootcontext.cs (ResolveTree): Re-write.
31783 (PopulateTypes): Re-write.
31785 * class.cs (TypeContainer::Populate): Populate nested types too.
31786 (TypeContainer::Emit): Emit nested members too.
31788 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31789 instead just use the name argument passed in as it is already fully
31792 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31793 to TypeContainer mapping to see if a type is user-defined.
31795 * class.cs (TypeContainer::CloseType): Implement.
31797 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31798 the default constructor.
31800 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31803 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31805 * interface.cs (CloseType): Create the type here.
31807 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31810 Remove all the methods which are now in TypeContainer.
31812 2001-10-10 Ravi Pratap <ravi@ximian.com>
31814 * delegate.cs (Define): Re-write bits to define the delegate
31817 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31819 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31821 * expression.cs (ImplicitReferenceConversion): handle null as well
31822 as a source to convert to any reference type.
31824 * statement.cs (Return): Perform any implicit conversions to
31825 expected return type.
31827 Validate use of return statement.
31829 * codegen.cs (EmitContext): Pass the expected return type here.
31831 * class.cs (Method, Constructor, Property): Pass expected return
31832 type to EmitContext.
31834 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31836 * expression.cs: Make DoResolve take an EmitContext instead of a
31839 Replaced `l' and `location' for `loc', for consistency.
31841 (Error, Warning): Remove unneeded Tc argument.
31843 * assign.cs, literal.cs, constant.cs: Update to new calling
31846 * codegen.cs: EmitContext now contains a flag indicating whether
31847 code is being generated in a static method or not.
31849 * cs-parser.jay: DecomposeQI, new function that replaces the old
31850 QualifiedIdentifier. Now we always decompose the assembled
31851 strings from qualified_identifier productions into a group of
31854 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31856 * rootcontext.cs: Deal with field-less struct types correctly now
31857 by passing the size option to Define Type.
31859 * class.cs: Removed hack that created one static field.
31861 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31863 * statement.cs: Moved most of the code generation here.
31865 2001-10-09 Ravi Pratap <ravi@ximian.com>
31867 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31870 (ElementAccess): Remove useless bits for now - keep checks as the spec
31873 2001-10-08 Ravi Pratap <ravi@ximian.com>
31875 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31876 and start performing checks according to the spec.
31878 2001-10-07 Ravi Pratap <ravi@ximian.com>
31880 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31881 rank_specifiers instead.
31883 (rank_specifiers): Change the order in which the rank specifiers are stored
31885 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31887 * expression.cs (ElementAccess): Implement the LValue interface too.
31889 2001-10-06 Ravi Pratap <ravi@ximian.com>
31891 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31892 except that user defined conversions are not included.
31894 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31895 perform the conversion of the return type, if necessary.
31897 (New::DoResolve): Check whether we are creating an array or an object
31898 and accordingly do the needful.
31900 (New::Emit): Same here.
31902 (New::DoResolve): Implement guts of array creation.
31904 (New::FormLookupType): Helper function.
31906 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31908 * codegen.cs: Removed most of the code generation here, and move the
31909 corresponding code generation bits to the statement classes.
31911 Added support for try/catch/finalize and throw.
31913 * cs-parser.jay: Added support for try/catch/finalize.
31915 * class.cs: Catch static methods having the flags override,
31916 virtual or abstract.
31918 * expression.cs (UserCast): This user cast was not really doing
31919 what it was supposed to do. Which is to be born in fully resolved
31920 state. Parts of the resolution were being performed at Emit time!
31924 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31926 * expression.cs: Implicity convert the result from UserCast.
31928 2001-10-05 Ravi Pratap <ravi@ximian.com>
31930 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31931 prevented it from working correctly.
31933 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31934 merely ConvertImplicit.
31936 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31938 * typemanager.cs: Make the LookupTypeContainer function static,
31939 and not per-instance.
31941 * class.cs: Make static FindMembers (the one that takes a Type
31944 * codegen.cs: Add EmitForeach here.
31946 * cs-parser.jay: Make foreach a toplevel object instead of the
31947 inline expansion, as we need to perform semantic analysis on it.
31949 2001-10-05 Ravi Pratap <ravi@ximian.com>
31951 * expression.cs (Expression::ImplicitUserConversion): Rename to
31952 UserDefinedConversion.
31954 (Expression::UserDefinedConversion): Take an extra argument specifying
31955 whether we look for explicit user conversions too.
31957 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31959 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31961 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31962 with the appropriate arguments.
31964 * cs-parser.jay (cast_expression): Record location too.
31966 * expression.cs (Cast): Record location info.
31968 (Expression::ConvertExplicit): Take location argument.
31970 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31971 to determine if we are doing explicit conversions.
31973 (UserCast::Emit): Update accordingly.
31975 (Expression::ConvertExplicit): Report an error if everything fails.
31977 * ../errors/cs0030.cs : Add.
31979 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31981 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31982 virtual and newslot bits.
31984 * class.cs (TypeContainer::RegisterRequiredImplementations):
31985 Record methods we need.
31987 (TypeContainer::MakeKey): Helper function to make keys for
31988 MethodBases, since the Methodbase key is useless.
31990 (TypeContainer::Populate): Call RegisterRequiredImplementations
31991 before defining the methods.
31993 Create a mapping for method_builders_to_methods ahead of time
31994 instead of inside a tight loop.
31996 (::RequireMethods): Accept an object as the data to set into the
31997 hashtable so we can report interface vs abstract method mismatch.
31999 2001-10-03 Miguel de Icaza <miguel@ximian.com>
32001 * report.cs: Make all of it static.
32003 * rootcontext.cs: Drop object_type and value_type computations, as
32004 we have those in the TypeManager anyways.
32006 Drop report instance variable too, now it is a global.
32008 * driver.cs: Use try/catch on command line handling.
32010 Add --probe option to debug the error reporting system with a test
32013 * report.cs: Add support for exiting program when a probe
32014 condition is reached.
32016 2001-10-03 Ravi Pratap <ravi@ximian.com>
32018 * expression.cs (Binary::DoNumericPromotions): Fix the case when
32019 we do a forcible conversion regardless of type, to check if
32020 ForceConversion returns a null.
32022 (Binary::error19): Use location to report error.
32024 (Unary::error23): Use location here too.
32026 * ../errors/cs0019.cs : Check in.
32028 * ../errors/cs0023.cs : Check in.
32030 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
32031 case of a non-null MethodInfo object with a length of 0 !
32033 (Binary::ResolveOperator): Flag error if overload resolution fails to find
32034 an applicable member - according to the spec :-)
32035 Also fix logic to find members in base types.
32037 (Unary::ResolveOperator): Same here.
32039 (Unary::report23): Change name to error23 and make first argument a TypeContainer
32040 as I was getting thoroughly confused between this and error19 :-)
32042 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
32043 (::FindMostEncompassedType): Implement.
32044 (::FindMostEncompassingType): Implement.
32045 (::StandardConversionExists): Implement.
32047 (UserImplicitCast): Re-vamp. We now need info about most specific
32048 source and target types so that we can do the necessary conversions.
32050 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
32051 mathematical union with no duplicates.
32053 2001-10-03 Miguel de Icaza <miguel@ximian.com>
32055 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
32056 in order from base classes to child classes, so that we can in
32057 child classes look up in our parent for method names and
32058 attributes (required for handling abstract, virtual, new, override
32059 constructs: we need to instrospect our base class, and if we dont
32060 populate the classes in order, the introspection might be
32061 incorrect. For example, a method could query its parent before
32062 the parent has any methods and would determine that the parent has
32063 no abstract methods (while it could have had them)).
32065 (RootContext::CreateType): Record the order in which we define the
32068 2001-10-02 Miguel de Icaza <miguel@ximian.com>
32070 * class.cs (TypeContainer::Populate): Also method definitions can
32071 fail now, keep track of this.
32073 (TypeContainer::FindMembers): Implement support for
32074 DeclaredOnly/noDeclaredOnly flag.
32076 (Constructor::Emit) Return the ConstructorBuilder.
32078 (Method::Emit) Return the MethodBuilder.
32079 Check for abstract or virtual methods to be public.
32081 * rootcontext.cs (RootContext::CreateType): Register all the
32082 abstract methods required for the class to be complete and the
32083 interface methods that must be implemented.
32085 * cs-parser.jay: Report error 501 (method requires body if it is
32086 not marked abstract or extern).
32088 * expression.cs (TypeOf::Emit): Implement.
32090 * typemanager.cs: runtime_handle_type, new global type.
32092 * class.cs (Property::Emit): Generate code for properties.
32094 2001-10-02 Ravi Pratap <ravi@ximian.com>
32096 * expression.cs (Unary::ResolveOperator): Find operators on base type
32097 too - we now conform exactly to the spec.
32099 (Binary::ResolveOperator): Same here.
32101 * class.cs (Operator::Define): Fix minor quirk in the tests.
32103 * ../errors/cs0215.cs : Added.
32105 * ../errors/cs0556.cs : Added.
32107 * ../errors/cs0555.cs : Added.
32109 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32111 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
32112 single integer which is really efficient
32114 2001-10-01 Ravi Pratap <ravi@ximian.com>
32116 * expression.cs (Expression::ImplicitUserConversion): Use location
32117 even in the case when we are examining True operators.
32119 * class.cs (Operator::Define): Perform extensive checks to conform
32120 with the rules for operator overloading in the spec.
32122 * expression.cs (Expression::ImplicitReferenceConversion): Implement
32123 some of the other conversions mentioned in the spec.
32125 * typemanager.cs (array_type): New static member for the System.Array built-in
32128 (cloneable_interface): For System.ICloneable interface.
32130 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
32131 we start resolving the tree and populating types.
32133 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
32135 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32137 * expression.cs (Expression::ExprClassFromMemberInfo,
32138 Expression::Literalize): Create literal expressions from
32139 FieldInfos which are literals.
32141 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
32142 type casts, because they were wrong. The test suite in tests
32145 (ImplicitNumericConversion): ushort to ulong requires a widening
32148 Int32 constant to long requires widening cast as well.
32150 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
32151 for integers because the type on the stack is not i4.
32153 2001-09-30 Miguel de Icaza <miguel@ximian.com>
32155 * expression.cs (report118): require location argument.
32157 * parameter.cs: Do not dereference potential null value.
32159 * class.cs: Catch methods that lack the `new' keyword when
32160 overriding a name. Report warnings when `new' is used without
32161 anything being there to override.
32163 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
32165 * class.cs: Only add constructor to hashtable if it is non-null
32166 (as now constructors can fail on define).
32168 (TypeManager, Class, Struct): Take location arguments.
32170 Catch field instance initialization in structs as errors.
32172 accepting_filter: a new filter for FindMembers that is static so
32173 that we dont create an instance per invocation.
32175 (Constructor::Define): Catch errors where a struct constructor is
32178 * cs-parser.jay: Pass location information for various new
32181 * delegate.cs (Delegate): take a location argument.
32183 * driver.cs: Do not call EmitCode if there were problesm in the
32184 Definition of the types, as many Builders wont be there.
32186 * decl.cs (Decl::Decl): Require a location argument.
32188 * cs-tokenizer.cs: Handle properly hex constants that can not fit
32189 into integers, and find the most appropiate integer for it.
32191 * literal.cs: Implement ULongLiteral.
32193 * rootcontext.cs: Provide better information about the location of
32194 failure when CreateType fails.
32196 2001-09-29 Miguel de Icaza <miguel@ximian.com>
32198 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
32201 * expression.cs (Binary::CheckShiftArguments): Add missing type
32203 (Binary::ResolveOperator): Add type to the logical and and logical
32204 or, Bitwise And/Or and Exclusive Or code paths, it was missing
32207 (Binary::DoNumericPromotions): In the case where either argument
32208 is ulong (and most signed types combined with ulong cause an
32209 error) perform implicit integer constant conversions as well.
32211 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32213 * expression.cs (UserImplicitCast): Method should always be
32215 (Invocation::BetterConversion): Simplified test for IntLiteral.
32217 (Expression::ImplicitNumericConversion): Split this routine out.
32218 Put the code that performs implicit constant integer conversions
32221 (Expression::Resolve): Become a wrapper around DoResolve so we can
32222 check eclass and type being set after resolve.
32224 (Invocation::Badness): Remove this dead function
32226 (Binary::ResolveOperator): Do not compute the expensive argumnets
32227 unless we have a union for it.
32229 (Probe::Emit): Is needs to do an isinst and then
32230 compare against null.
32232 (::CanConvert): Added Location argument. If the Location argument
32233 is null (Location.Null), then we do not report errors. This is
32234 used by the `probe' mechanism of the Explicit conversion. We do
32235 not want to generate an error for something that the user
32236 explicitly requested to be casted. But the pipeline for an
32237 explicit cast first tests for potential implicit casts.
32239 So for now, if the Location is null, it means `Probe only' to
32240 avoid adding another argument. Might have to revise this
32243 (ClassCast): New class used to type cast objects into arbitrary
32244 classes (used in Explicit Reference Conversions).
32246 Implement `as' as well.
32248 Reverted all the patches from Ravi below: they were broken:
32250 * The use of `level' as a mechanism to stop recursive
32251 invocations is wrong. That was there just to catch the
32252 bug with a strack trace but not as a way of addressing
32255 To fix the problem we have to *understand* what is going
32256 on and the interactions and come up with a plan, not
32257 just get things going.
32259 * The use of the type conversion cache that I proposed
32260 last night had an open topic: How does this work across
32261 protection domains. A user defined conversion might not
32262 be public in the location where we are applying the
32263 conversion, a different conversion might be selected
32264 (ie, private A->B (better) but public B->A (worse),
32265 inside A, A->B applies, but outside it, B->A will
32268 * On top of that (ie, even if the above is solved),
32269 conversions in a cache need to be abstract. Ie, `To
32270 convert from an Int to a Short use an OpcodeCast', not
32271 `To convert from an Int to a Short use the OpcodeCast on
32272 the variable 5' (which is what this patch was doing).
32274 2001-09-28 Ravi Pratap <ravi@ximian.com>
32276 * expression.cs (Invocation::ConversionExists): Re-write to use
32277 the conversion cache
32279 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
32280 cache all conversions done, not just user-defined ones.
32282 (Invocation::BetterConversion): The real culprit. Use ConversionExists
32283 to determine if a conversion exists instead of acutually trying to
32284 perform the conversion. It's faster too.
32286 (Expression::ConvertExplicit): Modify to use ConversionExists to check
32287 and only then attempt the implicit conversion.
32289 2001-09-28 Ravi Pratap <ravi@ximian.com>
32291 * expression.cs (ConvertImplicit): Use a cache for conversions
32292 already found. Check level of recursion and bail out if necessary.
32294 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32296 * typemanager.cs (string_concat_string_string, string_concat_object_object):
32297 Export standard methods that we expect for string operations.
32299 * statement.cs (Block::UsageWarning): Track usage of variables and
32300 report the errors for not used variables.
32302 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
32305 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32307 * codegen.cs: remove unnneded code
32309 * expression.cs: Removed BuiltinTypeAccess class
32311 Fix the order in which implicit conversions are
32314 The previous fixed dropped support for boxed conversions (adding a
32315 test to the test suite now)
32317 (UserImplicitCast::CanConvert): Remove test for source being null,
32318 that code is broken. We should not feed a null to begin with, if
32319 we do, then we should track the bug where the problem originates
32320 and not try to cover it up here.
32322 Return a resolved expression of type UserImplicitCast on success
32323 rather than true/false. Ravi: this is what I was talking about,
32324 the pattern is to use a static method as a "constructor" for
32327 Also, do not create arguments until the very last minute,
32328 otherwise we always create the arguments even for lookups that
32329 will never be performed.
32331 (UserImplicitCast::Resolve): Eliminate, objects of type
32332 UserImplicitCast are born in a fully resolved state.
32334 * typemanager.cs (InitCoreTypes): Init also value_type
32335 (System.ValueType).
32337 * expression.cs (Cast::Resolve): First resolve the child expression.
32339 (LValue): Add new method AddressOf to be used by
32342 Change the argument of Store to take an EmitContext instead of an
32343 ILGenerator, because things like FieldExpr need to be able to call
32344 their children expression to generate the instance code.
32346 (Expression::Error, Expression::Warning): Sugar functions for
32349 (Expression::MemberLookup): Accept a TypeContainer instead of a
32350 Report as the first argument.
32352 (Expression::ResolvePrimary): Killed. I still want to improve
32353 this as currently the code is just not right.
32355 (Expression::ResolveMemberAccess): Simplify, but it is still
32358 (Unary::Resolve): Catch errors in AddressOf operators.
32360 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
32361 index to a byte for the short-version, or the compiler will choose
32362 the wrong Emit call, which generates the wrong data.
32364 (ParameterReference::Emit, ::Store): same.
32366 (FieldExpr::AddressOf): Implement.
32368 * typemanager.cs: TypeManager: made public variable instead of
32371 * driver.cs: document --fatal.
32373 * report.cs (ErrorMessage, WarningMessage): new names for the old
32374 Error and Warning classes.
32376 * cs-parser.jay (member_access): Turn built-in access to types
32377 into a normal simplename
32379 2001-09-27 Ravi Pratap <ravi@ximian.com>
32381 * expression.cs (Invocation::BetterConversion): Fix to cope
32382 with q being null, since this was introducing a bug.
32384 * expression.cs (ConvertImplicit): Do built-in conversions first.
32386 2001-09-27 Ravi Pratap <ravi@ximian.com>
32388 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32390 2001-09-27 Ravi Pratap <ravi@ximian.com>
32392 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32393 I had introduced long ago (what's new ?).
32395 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32396 the work of all the checking.
32397 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32398 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32400 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32401 that is the right way.
32403 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32404 overloading resolution. Use everywhere instead of cutting and pasting code.
32406 (Binary::ResolveOperator): Use MakeUnionSet.
32408 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32409 we have to convert to bool types. Not complete yet.
32411 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32413 * typemanager.cs (TypeManager::CSharpName): support ushort.
32415 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32416 to provide an expression that performsn an implicit constant int
32417 conversion (section 6.1.6).
32418 (Expression::ConvertImplicitRequired): Reworked to include
32419 implicit constant expression conversions.
32421 (Expression::ConvertNumericExplicit): Finished.
32423 (Invocation::Emit): If InstanceExpression is null, then it means
32424 that we perform a call on this.
32426 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32428 * expression.cs (Unary::Emit): Remove some dead code.
32429 (Probe): Implement Resolve and Emit for `is'.
32430 (Expression::ConvertImplicitRequired): Attempt to do constant
32431 expression conversions here. Maybe should be moved to
32432 ConvertImplicit, but I am not sure.
32433 (Expression::ImplicitLongConstantConversionPossible,
32434 Expression::ImplicitIntConstantConversionPossible): New functions
32435 that tell whether is it possible to apply an implicit constant
32436 expression conversion.
32438 (ConvertNumericExplicit): Started work on explicit numeric
32441 * cs-parser.jay: Update operator constants.
32443 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32444 (Parameters::GetSignature): Hook up VerifyArgs here.
32445 (Parameters::VerifyArgs): Verifies that no two arguments have the
32448 * class.cs (Operator): Update the operator names to reflect the
32449 ones that the spec expects (as we are just stringizing the
32452 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32453 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32454 previous usage did only work for our methods.
32455 (Expression::ConvertImplicit): Handle decimal implicit numeric
32456 conversions as well.
32457 (Expression::InternalTypeConstructor): Used to invoke constructors
32458 on internal types for default promotions.
32460 (Unary::Emit): Implement special handling for the pre/post
32461 increment/decrement for overloaded operators, as they need to have
32462 the same semantics as the other operators.
32464 (Binary::ResolveOperator): ditto.
32465 (Invocation::ConversionExists): ditto.
32466 (UserImplicitCast::Resolve): ditto.
32468 2001-09-26 Ravi Pratap <ravi@ximian.com>
32470 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32471 operator, return after emitting body. Regression tests pass again !
32473 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32474 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32475 (Invocation::OverloadResolve): Ditto.
32476 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32478 * everywhere : update calls to the above methods accordingly.
32480 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32482 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32484 * expression.cs (ExpressionStatement): New base class used for
32485 expressions that can appear in statements, so that we can provide
32486 an alternate path to generate expression that do not leave a value
32489 (Expression::Emit, and all the derivatives): We no longer return
32490 whether a value is left on the stack or not. Every expression
32491 after being emitted leaves a single value on the stack.
32493 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32494 facilties of ExpressionStatement if possible.
32496 * cs-parser.jay: Update statement_expression.
32498 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32500 * driver.cs: Change the wording of message
32502 2001-09-25 Ravi Pratap <ravi@ximian.com>
32504 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32505 the type of the expression to the return type of the method if
32506 we have an overloaded operator match ! The regression tests pass again !
32507 (Unary::ResolveOperator): Ditto.
32509 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32510 to find "op_Implicit", not "implicit" ;-)
32511 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32512 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32514 * everywhere : Correct calls to the above accordingly.
32516 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32517 (ConvertImplicit): Do user-defined conversion if it exists.
32519 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32521 * assign.cs: track location.
32522 (Resolve): Use implicit conversions on assignment.
32524 * literal.cs: Oops. Not good, Emit of short access values should
32525 pass (Bytes) or the wrong argument will be selected.
32527 * expression.cs (Unary::Emit): Emit code for -expr.
32529 (Unary::ResolveOperator): Handle `Substract' for non-constants
32530 (substract from zero from the non-constants).
32531 Deal with Doubles as well.
32533 (Expression::ConvertImplicitRequired): New routine that reports an
32534 error if no implicit conversion exists.
32536 (Invocation::OverloadResolve): Store the converted implicit
32537 expressions if we make them
32539 2001-09-24 Ravi Pratap <ravi@ximian.com>
32541 * class.cs (ConstructorInitializer): Take a Location argument.
32542 (ConstructorBaseInitializer): Same here.
32543 (ConstructorThisInitializer): Same here.
32545 * cs-parser.jay : Update all calls accordingly.
32547 * expression.cs (Unary, Binary, New): Take location argument.
32548 Update accordingly everywhere.
32550 * cs-parser.jay : Update all calls to the above to take a location
32553 * class.cs : Ditto.
32555 2001-09-24 Ravi Pratap <ravi@ximian.com>
32557 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32558 (Invocation::BetterConversion): Same here
32559 (Invocation::ConversionExists): Ditto.
32561 (Invocation::ConversionExists): Implement.
32563 2001-09-22 Ravi Pratap <ravi@ximian.com>
32565 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32566 Also take an additional TypeContainer argument.
32568 * All over : Pass in TypeContainer as argument to OverloadResolve.
32570 * typemanager.cs (CSharpName): Update to check for the string type and return
32573 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32576 2001-09-21 Ravi Pratap <ravi@ximian.com>
32578 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32579 (Invocation::BetterFunction): Implement.
32580 (Invocation::BetterConversion): Implement.
32581 (Invocation::ConversionExists): Skeleton, no implementation yet.
32583 Okay, things work fine !
32585 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32587 * typemanager.cs: declare and load enum_type, delegate_type and
32590 * expression.cs (Expression::Emit): Now emit returns a value that
32591 tells whether a value is left on the stack or not. This strategy
32592 might be reveted tomorrow with a mechanism that would address
32593 multiple assignments.
32594 (Expression::report118): Utility routine to report mismatches on
32597 (Unary::Report23): Report impossible type/operator combination
32600 (Unary::IsIncrementableNumber): Whether the type can be
32601 incremented or decremented with add.
32602 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32604 (Unary::ResolveOperator): Implement ++, !, ~,
32606 (Invocation::Emit): Deal with new Emit convetion.
32608 * All Expression derivatives: Updated their Emit method to return
32609 whether they leave values on the stack or not.
32611 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32612 stack for expressions that are statements.
32614 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32616 * expression.cs (LValue): New interface. Must be implemented by
32618 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32621 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32622 interface for generating code, simplifies the code.
32624 2001-09-20 Ravi Pratap <ravi@ximian.com>
32626 * expression.cs (everywhere): Comment out return statements in ::Resolve
32627 methods to avoid the warnings.
32629 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32631 * driver.cs (parse): Report error 2001 if we can not open the
32634 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32637 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32640 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32641 otherwise nested blocks end up with the same index.
32643 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32645 * expression.cs: Instead of having FIXMEs in the Resolve
32646 functions, throw exceptions so it is obvious that we are facing a
32649 * cs-parser.jay (invocation_expression): Pass Location information.
32651 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32652 Use a basename for those routines because .NET does not like paths
32655 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32658 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32660 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32661 are loading the correct data types (throws an exception if not).
32662 (TypeManager::InitCoreTypes): Use CoreLookupType
32664 * expression.cs (Unary::ResolveOperator): return the child
32665 expression for expressions which are just +expr.
32666 (Unary::ResolveOperator): Return negative literals for -LITERAL
32667 expressions (otherwise they are Unary {Literal}).
32668 (Invocation::Badness): Take into account `Implicit constant
32669 expression conversions'.
32671 * literal.cs (LongLiteral): Implement long literal class.
32672 (IntLiteral): export the `Value' of the intliteral.
32674 2001-09-19 Ravi Pratap <ravi@ximian.com>
32676 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32678 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32679 instead of 'Operator'
32681 * expression.cs (Binary::ResolveOperator): Update accordingly.
32682 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32685 * cs-parser.jay (unary_expression): Update to use the new names.
32687 * gen-treedump.cs (GetUnary): Same here.
32689 * expression.cs (Unary::Resolve): Implement.
32690 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32691 operators are found instead of making noise ;-)
32692 (Unary::ResolveOperator): New method to do precisely the same thing which
32693 Binary::ResolveOperator does for Binary expressions.
32694 (Unary.method, .Arguments): Add.
32695 (Unary::OperName): Implement.
32696 (Unary::ForceConversion): Copy and Paste !
32698 * class.cs (Operator::Define): Fix a small bug for the case when we have
32701 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32702 for the inbuilt operators. Only overloading works for now ;-)
32704 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32706 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32707 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32709 * expression.cs (This::Emit): Implement.
32710 (This::Resolve): Implement.
32711 (TypeOf:Resolve): Implement.
32712 (Expression::ResolveSimpleName): Add an implicit this to instance
32714 (MemberAccess::Resolve): Deal with Parameters and Fields.
32715 Bind instance variable to Field expressions.
32716 (FieldExpr::Instance): New field used to track the expression that
32717 represents the object instance.
32718 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32720 (FieldExpr::Emit): Implement.
32722 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32723 the last instruction contains a return opcode to avoid generating
32724 the last `ret' instruction (this generates correct code, and it is
32725 nice to pass the peverify output).
32727 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32728 initializer for static and instance variables.
32729 (Constructor::Emit): Allow initializer to be null in the case of
32730 static constructors. Only emit initializer for instance
32733 (TypeContainer::FindMembers): Return a null array if there are no
32736 Also fix the code for the MemberTypes.Method branch, as it was not
32737 scanning that for operators (or tried to access null variables before).
32739 * assign.cs (Assign::Emit): Handle instance and static fields.
32743 * driver.cs: Stop compilation if there are parse errors.
32745 * cs-parser.jay (constructor_declaration): Provide default base
32746 initializer for non-static constructors.
32747 (constructor_declarator): Do not provide a default base
32748 initializers if none was specified.
32749 Catch the fact that constructors should not have parameters.
32751 * class.cs: Do not emit parent class initializers for static
32752 constructors, that should be flagged as an error.
32754 2001-09-18 Ravi Pratap <ravi@ximian.com>
32756 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32757 Move back code into TypeContainer::Populate.
32759 2001-09-18 Ravi Pratap <ravi@ximian.com>
32761 * class.cs (TypeContainer::AddConstructor): Fix the check to
32762 compare against Name, not Basename.
32763 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32765 * cs-parser.jay : Update accordingly.
32767 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32768 for methods, don't forget to look into the operators too.
32769 (RegisterMethodBuilder): Helper method to take care of this for
32770 methods, constructors and operators.
32771 (Operator::Define): Completely revamp.
32772 (Operator.OperatorMethod, MethodName): New fields.
32773 (TypeContainer::Populate): Move the registering of builders into
32774 RegisterMethodBuilder.
32775 (Operator::Emit): Re-write.
32777 * expression.cs (Binary::Emit): Comment out code path to emit method
32778 invocation stuff for the case when we have a user defined operator. I am
32779 just not able to get it right !
32781 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32783 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32786 (Expression::MemberLookup): Provide a version that allows to
32787 specify the MemberTypes and BindingFlags.
32789 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32790 so it was not fetching variable information from outer blocks.
32792 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32793 Beforefieldinit as it was buggy.
32795 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32796 that Ravi put here.
32798 * class.cs (Constructor::Emit): Only emit if block is not null.
32799 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32800 deal with this by semantically definining it as if the user had
32803 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32804 constructors as we now "emit" them at a higher level.
32806 (TypeContainer::DefineDefaultConstructor): Used to define the
32807 default constructors if none was provided.
32809 (ConstructorInitializer): Add methods Resolve and Emit.
32811 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32813 2001-09-17 Ravi Pratap <ravi@ximian.com>
32815 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32816 the default constructor builder with our hashtable for methodbuilders
32819 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32820 and argument_count is 0 in which case we have a match.
32821 (Binary::ResolveOperator): More null checking and miscellaneous coding
32824 2001-09-17 Ravi Pratap <ravi@ximian.com>
32826 * rootcontext.cs (IsNameSpace): Compare against null.
32828 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32830 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32831 and Unary::Operator.
32833 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32836 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32837 we have overloaded operators.
32838 (Binary::ResolveOperator): Implement the part which does the operator overload
32841 * class.cs (Operator::Emit): Implement.
32842 (TypeContainer::Emit): Emit the operators we have too.
32844 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32845 the case when we have a user-defined operator.
32847 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32849 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32851 2001-09-16 Ravi Pratap <ravi@ximian.com>
32853 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32854 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32855 (Constructor::Emit): Implement.
32856 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32857 if we have no work to do.
32858 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32861 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32862 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32864 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32867 2001-09-15 Ravi Pratap <ravi@ximian.com>
32869 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32871 (Tree::RecordNamespace): Method to do what the name says ;-)
32872 (Tree::Namespaces): Property to get at the namespaces hashtable.
32874 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32877 * rootcontext.cs (IsNamespace): Fixed it :-)
32879 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32881 * class.cs (TypeContainer::FindMembers): Add support for
32883 (MethodCore): New class that encapsulates both the shared aspects
32884 of a Constructor and a Method.
32885 (Method, Constructor): Factored pieces into MethodCore.
32887 * driver.cs: Added --fatal which makes errors throw exceptions.
32888 Load System assembly as well as part of the standard library.
32890 * report.cs: Allow throwing exceptions on errors for debugging.
32892 * modifiers.cs: Do not use `parent', instead use the real type
32893 container to evaluate permission settings.
32895 * class.cs: Put Ravi's patch back in. He is right, and we will
32896 have to cope with the
32898 2001-09-14 Ravi Pratap <ravi@ximian.com>
32900 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32901 FamORAssem, not FamANDAssem.
32903 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32905 * driver.cs: Added --parse option that only parses its input files
32908 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32909 incorrect. IsTopLevel is not used to tell whether an object is
32910 root_types or not (that can be achieved by testing this ==
32911 root_types). But to see if this is a top-level *class* (not
32912 necessarly our "toplevel" container).
32914 2001-09-14 Ravi Pratap <ravi@ximian.com>
32916 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32917 parent instead of a direct call to GetType.
32919 2001-09-14 Ravi Pratap <ravi@ximian.com>
32921 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32922 Modifiers.TypeAttr. This should just be a call to that method.
32924 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32925 object so that we can determine if we are top-level or not.
32927 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32930 * enum.cs (Enum::Define): Ditto.
32932 * modifiers.cs (FieldAttr): Re-write.
32934 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32935 (TypeContainer::HaveStaticConstructor): New property to provide access
32936 to precisely that info.
32938 * modifiers.cs (MethodAttr): Re-write.
32939 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32941 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32942 of top-level types as claimed.
32944 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32946 * expression.cs (MemberLookup): Fruitless attempt to lookup
32947 constructors. Maybe I need to emit default constructors? That
32948 might be it (currently .NET emits this for me automatically).
32949 (Invocation::OverloadResolve): Cope with Arguments == null.
32950 (Invocation::EmitArguments): new function, shared by the new
32951 constructor and us.
32952 (Invocation::Emit): Handle static and instance methods. Emit
32953 proper call instruction for virtual or non-virtual invocations.
32954 (New::Emit): Implement.
32955 (New::Resolve): Implement.
32956 (MemberAccess:Resolve): Implement.
32957 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32958 to track instances.
32959 (FieldExpr::Resolve): Set type.
32961 * support.cs: Handle empty arguments.
32963 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32964 SimpleLookup): Auxiliary routines to help parse a qualifier
32967 Update qualifier_identifier rule.
32969 * codegen.cs: Removed debugging messages.
32971 * class.cs: Make this a global thing, this acts just as a "key" to
32972 objects that we might have around.
32974 (Populate): Only initialize method_builders_to_methods once.
32976 * expression.cs (PropertyExpr): Initialize type from the
32979 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32980 Resolve pattern. Attempt to implicitly convert value to boolean.
32983 * expression.cs: Set the type for the int32/int32 argument case.
32984 (Binary::ResolveOperator): Set the return type to boolean for
32985 comparission operators
32987 * typemanager.cs: Remove debugging print code.
32989 (Invocation::Resolve): resolve type.
32991 * class.cs: Allocate a MemberInfo of the correct size, as the code
32992 elsewhere depends on the test to reflect the correct contents.
32994 (Method::) Keep track of parameters, due to System.Reflection holes
32996 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32999 (TypeContainer::FindMembers): Use ArrayList and then copy an array
33000 of the exact size and return that.
33002 (Class::LookupMethodByBuilder): New function that maps
33003 MethodBuilders to its methods. Required to locate the information
33004 on methods because System.Reflection bit us again.
33006 * support.cs: New file, contains an interface ParameterData and
33007 two implementations: ReflectionParameters and InternalParameters
33008 used to access Parameter information. We will need to grow this
33011 * expression.cs (Invocation::GetParameterData): implement a cache
33012 and a wrapper around the ParameterData creation for methods.
33013 (Invocation::OverloadResolve): Use new code.
33015 2001-09-13 Ravi Pratap <ravi@ximian.com>
33017 * class.cs (TypeContainer::EmitField): Remove and move into
33018 (Field::Define): here and modify accordingly.
33019 (Field.FieldBuilder): New member.
33020 (TypeContainer::Populate): Update accordingly.
33021 (TypeContainer::FindMembers): Implement.
33023 2001-09-13 Miguel de Icaza <miguel@ximian.com>
33025 * statement.cs: (VariableInfo::VariableType): New field to be
33026 initialized with the full type once it is resolved.
33028 2001-09-12 Miguel de Icaza <miguel@ximian.com>
33030 * parameter.cs (GetParameterInfo): Use a type cache to compute
33031 things only once, and to reuse this information
33033 * expression.cs (LocalVariableReference::Emit): Implement.
33034 (OpcodeCast::Emit): fix.
33036 (ParameterReference::Resolve): Implement.
33037 (ParameterReference::Emit): Implement.
33039 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
33040 that are expressions need to stay as Expressions.
33042 * typemanager.cs (CSharpName): Returns the C# name of a type if
33045 * expression.cs (Expression::ConvertImplicit): New function that
33046 implements implicit type conversions.
33048 (Expression::ImplicitReferenceConversion): Implements implicit
33049 reference conversions.
33051 (EmptyCast): New type for transparent casts.
33053 (OpcodeCast): New type for casts of types that are performed with
33054 a sequence of bytecodes.
33056 (BoxedCast): New type used for casting value types into reference
33057 types. Emits a box opcode.
33059 (Binary::DoNumericPromotions): Implements numeric promotions of
33060 and computation of the Binary::Type.
33062 (Binary::EmitBranchable): Optimization.
33064 (Binary::Emit): Implement code emission for expressions.
33066 * typemanager.cs (TypeManager): Added two new core types: sbyte
33069 2001-09-12 Ravi Pratap <ravi@ximian.com>
33071 * class.cs (TypeContainer::FindMembers): Method which does exactly
33072 what Type.FindMembers does, only we don't have to use reflection. No
33073 implementation yet.
33075 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
33076 typecontainer objects as we need to get at them.
33077 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
33079 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
33080 typecontainer object.
33082 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
33083 of just a Report object.
33085 2001-09-11 Ravi Pratap <ravi@ximian.com>
33087 * class.cs (Event::Define): Go back to using the prefixes "add_" and
33089 (TypeContainer::Populate): Now define the delegates of the type too.
33090 (TypeContainer.Delegates): Property to access the list of delegates defined
33093 * delegates.cs (Delegate::Define): Implement partially.
33095 * modifiers.cs (TypeAttr): Handle more flags.
33097 2001-09-11 Ravi Pratap <ravi@ximian.com>
33099 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
33101 (Operator::Define): Re-write logic to get types by using the LookupType method
33102 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
33103 (Indexer::Define): Ditto.
33104 (Event::Define): Ditto.
33105 (Property::Define): Ditto.
33107 2001-09-10 Ravi Pratap <ravi@ximian.com>
33109 * class.cs (TypeContainer::Populate): Now define operators too.
33110 (TypeContainer.Operators): New property to access the list of operators
33112 (Operator.OperatorMethodBuilder): New member to hold the method builder
33113 for the operator we are defining.
33114 (Operator::Define): Implement.
33116 2001-09-10 Ravi Pratap <ravi@ximian.com>
33118 * class.cs (Event::Define): Make the prefixes of the accessor methods
33119 addOn_ and removeOn_
33121 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
33122 of the location being passed in too. Ideally, this should go later since all
33123 error reporting should be done through the Report object.
33125 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
33126 (Populate): Iterate thru the indexers we have and define them too.
33127 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
33128 for the get and set accessors.
33129 (Indexer::Define): Implement.
33131 2001-09-09 Miguel de Icaza <miguel@ximian.com>
33133 * expression.cs (Binary::Resolve): Beginning of it. I scratched
33134 my previous implementation, did not work.
33136 * typemanager.cs: Add a couple of missing types (the longs).
33138 * literal.cs: Use TypeManager.bool_type instead of getting it.
33140 * expression.cs (EventExpr): New kind of expressions.
33141 (Expressio::ExprClassFromMemberInfo): finish
33143 2001-09-08 Miguel de Icaza <miguel@ximian.com>
33145 * assign.cs: Emit stores to static fields differently.
33147 2001-09-08 Ravi Pratap <ravi@ximian.com>
33149 * Merge in changes and adjust code to tackle conflicts. Backed out my
33150 code in Assign::Resolve ;-)
33152 2001-09-08 Ravi Pratap <ravi@ximian.com>
33154 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
33155 instead Report.Error and also pass in the location.
33156 (CSharpParser::Lexer): New readonly property to return the reference
33157 to the Tokenizer object.
33158 (declare_local_variables): Use Report.Error with location instead of plain
33162 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
33163 (Operator.CheckBinaryOperator): Ditto.
33165 * cs-parser.jay (operator_declarator): Update accordingly.
33167 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
33168 (CheckBinaryOperator): Same here.
33170 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
33171 on the name without any prefixes of namespace names etc. This is because we
33172 already might have something already fully qualified like
33173 'System.Console.WriteLine'
33175 * assign.cs (Resolve): Begin implementation. Stuck ;-)
33177 2001-09-07 Ravi Pratap <ravi@ximian.com>
33179 * cs-tokenizer.cs (location): Return a string which also contains
33182 * expression.cs (ElementAccess): New class for expressions of the
33183 type 'element access.'
33184 (BaseAccess): New class for expressions of the type 'base access.'
33185 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
33188 * cs-parser.jay (element_access): Implement action.
33189 (base_access): Implement actions.
33190 (checked_expression, unchecked_expression): Implement.
33192 * cs-parser.jay (local_variable_type): Correct and implement.
33193 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
33195 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
33197 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
33198 name and the specifiers.
33200 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
33202 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
33203 making them all public ;-)
33205 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
33208 2001-09-07 Miguel de Icaza <miguel@ximian.com>
33210 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
33212 (FieldExpr, PropertyExprs): New resolved expressions.
33213 (SimpleName::MemberStaticCheck): Perform static checks for access
33214 to non-static fields on static methods. Maybe this should be
33215 generalized for MemberAccesses.
33216 (SimpleName::ResolveSimpleName): More work on simple name
33219 * cs-parser.jay (primary_expression/qualified_identifier): track
33220 the parameter index.
33222 * codegen.cs (CodeGen::Save): Catch save exception, report error.
33223 (EmitContext::EmitBoolExpression): Chain to expression generation
33224 instead of temporary hack.
33225 (::EmitStatementExpression): Put generic expression code generation.
33227 * assign.cs (Assign::Emit): Implement variable assignments to
33228 local variables, parameters and fields.
33230 2001-09-06 Miguel de Icaza <miguel@ximian.com>
33232 * statement.cs (Block::GetVariableInfo): New method, returns the
33233 VariableInfo for a variable name in a block.
33234 (Block::GetVariableType): Implement in terms of GetVariableInfo
33236 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
33237 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
33239 2001-09-06 Ravi Pratap <ravi@ximian.com>
33241 * cs-parser.jay (operator_declaration): Continue on my quest : update
33242 to take attributes argument.
33243 (event_declaration): Ditto.
33244 (enum_declaration): Ditto.
33245 (indexer_declaration): Ditto.
33247 * class.cs (Operator::Operator): Update constructor accordingly.
33248 (Event::Event): Ditto.
33250 * delegate.cs (Delegate::Delegate): Same here.
33252 * enum.cs (Enum::Enum): Same here.
33254 2001-09-05 Ravi Pratap <ravi@ximian.com>
33256 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
33258 * ../tests/cs0658.cs : New file to demonstrate error 0658.
33260 * attribute.cs (Attributes): New class to encapsulate all attributes which were
33261 being passed around as an arraylist.
33262 (Attributes::AddAttribute): Method to add attribute sections.
33264 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
33265 (struct_declaration): Update accordingly.
33266 (constant_declaration): Update.
33267 (field_declaration): Update.
33268 (method_header): Update.
33269 (fixed_parameter): Update.
33270 (parameter_array): Ditto.
33271 (property_declaration): Ditto.
33272 (destructor_declaration): Ditto.
33274 * class.cs (Struct::Struct): Update constructors accordingly.
33275 (Class::Class): Ditto.
33276 (Field::Field): Ditto.
33277 (Method::Method): Ditto.
33278 (Property::Property): Ditto.
33279 (TypeContainer::OptAttribute): update property's return type.
33281 * interface.cs (Interface.opt_attributes): New member.
33282 (Interface::Interface): Update to take the extra Attributes argument.
33284 * parameter.cs (Parameter::Parameter): Ditto.
33286 * constant.cs (Constant::Constant): Ditto.
33288 * interface.cs (InterfaceMemberBase): New OptAttributes field.
33289 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
33290 the attributes as a parameter.
33291 (InterfaceProperty): Update constructor call.
33292 (InterfaceEvent): Ditto.
33293 (InterfaceMethod): Ditto.
33294 (InterfaceIndexer): Ditto.
33296 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
33297 pass the attributes too.
33298 (interface_event_declaration): Ditto.
33299 (interface_property_declaration): Ditto.
33300 (interface_method_declaration): Ditto.
33301 (interface_declaration): Ditto.
33303 2001-09-05 Miguel de Icaza <miguel@ximian.com>
33305 * class.cs (Method::Define): Track the "static Main" definition to
33306 create an entry point.
33308 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
33309 EntryPoint if we find it.
33311 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
33312 (EmitContext::ig): Make this variable public.
33314 * driver.cs: Make the default output file be the first file name
33315 with the .exe extension.
33317 Detect empty compilations
33319 Handle various kinds of output targets. Handle --target and
33320 rename -t to --dumper.
33322 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
33323 methods inherited from Expression return now an Expression. This
33324 will is used during the tree rewriting as we resolve them during
33327 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
33328 the spec. Missing entirely is the information about
33329 accessability of elements of it.
33331 (Expression::ExprClassFromMemberInfo): New constructor for
33332 Expressions that creates a fully initialized Expression based on
33333 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
33336 (Invocation::Resolve): Begin implementing resolution of invocations.
33338 * literal.cs (StringLiteral): Implement Emit.
33340 2001-09-05 Ravi Pratap <ravi@ximian.com>
33342 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
33345 2001-09-04 Ravi Pratap <ravi@ximian.com>
33347 * cs-parser.jay (attribute_arguments): Implement actions.
33348 (attribute): Fix bug in production. Implement action.
33349 (attribute_list): Implement.
33350 (attribute_target): Implement.
33351 (attribute_target_specifier, opt_target_specifier): Implement
33352 (CheckAttributeTarget): New method to check if the attribute target
33354 (attribute_section): Implement.
33355 (opt_attributes): Implement.
33357 * attribute.cs : New file to handle attributes.
33358 (Attribute): Class to hold attribute info.
33360 * cs-parser.jay (opt_attribute_target_specifier): Remove production
33361 (attribute_section): Modify production to use 2 different rules to
33362 achieve the same thing. 1 s/r conflict down !
33363 Clean out commented, useless, non-reducing dimension_separator rules.
33365 * class.cs (TypeContainer.attributes): New member to hold list
33366 of attributes for a type.
33367 (Struct::Struct): Modify to take one more argument, the attribute list.
33368 (Class::Class): Ditto.
33369 (Field::Field): Ditto.
33370 (Method::Method): Ditto.
33371 (Property::Property): Ditto.
33373 * cs-parser.jay (struct_declaration): Update constructor call to
33374 pass in the attributes too.
33375 (class_declaration): Ditto.
33376 (constant_declaration): Ditto.
33377 (field_declaration): Ditto.
33378 (method_header): Ditto.
33379 (fixed_parameter): Ditto.
33380 (parameter_array): Ditto.
33381 (property_declaration): Ditto.
33383 * constant.cs (Constant::Constant): Update constructor similarly.
33384 Use System.Collections.
33386 * parameter.cs (Parameter::Parameter): Update as above.
33388 2001-09-02 Ravi Pratap <ravi@ximian.com>
33390 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33391 (TypeContainer.delegates): New member to hold list of delegates.
33393 * cs-parser.jay (delegate_declaration): Implement the action correctly
33394 this time as I seem to be on crack ;-)
33396 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33398 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33399 tell whether an identifier represents a namespace.
33401 * expression.cs (NamespaceExpr): A namespace expression, used only
33402 temporarly during expression resolution.
33403 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33404 utility functions to resolve names on expressions.
33406 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33408 * codegen.cs: Add hook for StatementExpressions.
33410 * class.cs: Fix inverted test for static flag in methods.
33412 2001-09-02 Ravi Pratap <ravi@ximian.com>
33414 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33415 to make it coincide with MS' number.
33416 (Operator::CheckBinaryOperator): Ditto.
33418 * ../errors/errors.txt : Remove error numbers added earlier.
33420 * ../errors/cs1019.cs : Test case for error # 1019
33422 * ../errros/cs1020.cs : Test case for error # 1020
33424 * cs-parser.jay : Clean out commented cruft.
33425 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33426 used anywhere - non-reducing rule.
33427 (namespace_declarations): Non-reducing rule - comment out.
33429 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33430 with TypeContainer::AddEnum.
33432 * delegate.cs : New file for delegate handling classes.
33433 (Delegate): Class for declaring delegates.
33435 * makefile : Update.
33437 * cs-parser.jay (delegate_declaration): Implement.
33439 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33441 * class.cs (Event::Define): Implement.
33442 (Event.EventBuilder): New member.
33444 * class.cs (TypeContainer::Populate): Update to define all enums and events
33446 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33447 readonly fields for all these cases ?
33449 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33451 * class.cs (Property): Revamp to use the convention of making fields readonly.
33452 Accordingly modify code elsewhere.
33454 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33455 the Define method of the Property class.
33457 * class.cs : Clean up applied patch and update references to variables etc. Fix
33459 (TypeContainer::Populate): Update to define all the properties we have. Also
33460 define all enumerations.
33462 * enum.cs (Define): Implement.
33464 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33466 * cs-parser.jay (overloadable_operator): The semantic value is an
33467 enum of the Operator class.
33468 (operator_declarator): Implement actions.
33469 (operator_declaration): Implement.
33471 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33472 validity of definitions.
33473 (Operator::CheckBinaryOperator): Static method to check for binary operators
33474 (TypeContainer::AddOperator): New method to add an operator to a type.
33476 * cs-parser.jay (indexer_declaration): Added line to actually call the
33477 AddIndexer method so it gets added ;-)
33479 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33480 already taken care of by the MS compiler ?
33482 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33484 * class.cs (Operator): New class for operator declarations.
33485 (Operator::OpType): Enum for the various operators.
33487 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33489 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33490 ostensibly handle this in semantic analysis.
33492 * cs-parser.jay (general_catch_clause): Comment out
33493 (specific_catch_clauses, specific_catch_clause): Ditto.
33494 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33495 (catch_args, opt_catch_args): New productions.
33496 (catch_clause): Rewrite to use the new productions above
33497 (catch_clauses): Modify accordingly.
33498 (opt_catch_clauses): New production to use in try_statement
33499 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33500 and re-write the code in the actions to extract the specific and
33501 general catch clauses by being a little smart ;-)
33503 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33504 Hooray, try and catch statements parse fine !
33506 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33508 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33509 string from the hashtable of variables.
33511 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33512 I end up making that mistake ;-)
33513 (catch_clauses): Fixed gross error which made Key and Value of the
33514 DictionaryEntry the same : $1 !!
33516 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33518 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33520 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33521 when the add and remove accessors are specified.
33523 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33525 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33526 information about indexer_declarator.
33527 (indexer_declarator): Implement actions.
33528 (parsing_indexer): New local boolean used to keep track of whether
33529 we are parsing indexers or properties. This is necessary because
33530 implicit_parameters come into picture even for the get accessor in the
33531 case of an indexer.
33532 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33534 * class.cs (Indexer): New class for indexer declarations.
33535 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33536 (TypeContainer::indexers): New member to hold list of indexers for the
33539 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33541 * cs-parser.jay (add_accessor_declaration): Implement action.
33542 (remove_accessor_declaration): Implement action.
33543 (event_accessors_declaration): Implement
33544 (variable_declarators): swap statements for first rule - trivial.
33546 * class.cs (Event): New class to hold information about event
33548 (TypeContainer::AddEvent): New method to add an event to a type
33549 (TypeContainer::events): New member to hold list of events.
33551 * cs-parser.jay (event_declaration): Implement actions.
33553 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33555 * cs-parser.jay (dim_separators): Implement. Make it a string
33556 concatenating all the commas together, just as they appear.
33557 (opt_dim_separators): Modify accordingly
33558 (rank_specifiers): Update accordingly. Basically do the same
33559 thing - instead, collect the brackets here.
33560 (opt_rank_sepcifiers): Modify accordingly.
33561 (array_type): Modify to actually return the complete type string
33562 instead of ignoring the rank_specifiers.
33563 (expression_list): Implement to collect the expressions
33564 (variable_initializer): Implement. We make it a list of expressions
33565 essentially so that we can handle the array_initializer case neatly too.
33566 (variable_initializer_list): Implement.
33567 (array_initializer): Make it a list of variable_initializers
33568 (opt_array_initializer): Modify accordingly.
33570 * expression.cs (New::NType): Add enumeration to help us
33571 keep track of whether we have an object/delegate creation
33572 or an array creation.
33573 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33574 members to hold data about array creation.
33575 (New:New): Modify to update NewType
33576 (New:New): New Overloaded contructor for the array creation
33579 * cs-parser.jay (array_creation_expression): Implement to call
33580 the overloaded New constructor.
33582 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33584 * class.cs (TypeContainer::Constructors): Return member
33585 constructors instead of returning null.
33587 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33589 * typemanager.cs (InitCoreTypes): Initialize the various core
33590 types after we have populated the type manager with the user
33591 defined types (this distinction will be important later while
33592 compiling corlib.dll)
33594 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33595 on Expression Classification. Now all expressions have a method
33596 `Resolve' and a method `Emit'.
33598 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33599 generation from working. Also add some temporary debugging
33602 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33604 * codegen.cs: Lots of code generation pieces. This is only the
33605 beginning, will continue tomorrow with more touches of polish. We
33606 handle the fundamentals of if, while, do, for, return. Others are
33607 trickier and I need to start working on invocations soon.
33609 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33612 * codegen.cs (EmitContext): New struct, used during code
33613 emission to keep a context. Most of the code generation will be
33616 * cs-parser.jay: Add embedded blocks to the list of statements of
33617 this block. So code generation proceeds in a top down fashion.
33619 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33621 * statement.cs: Add support for multiple child blocks.
33623 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33625 * codegen.cs (EmitCode): New function, will emit the code for a
33626 Block of code given a TypeContainer and its ILGenerator.
33628 * statement.cs (Block): Standard public readonly optimization.
33629 (Block::Block constructors): Link children.
33630 (Block::Child): Child Linker.
33631 (Block::EmitVariables): Emits IL variable declarations.
33633 * class.cs: Drop support for MethodGroups here, delay until
33635 (Method::): Applied the same simplification that I did before, and
33636 move from Properties to public readonly fields.
33637 (Method::ParameterTypes): Returns the parameter types for the
33638 function, and implements a cache that will be useful later when I
33639 do error checking and the semantic analysis on the methods is
33641 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33642 and made a method, optional argument tells whether this is a class
33643 or a structure to apply the `has-this' bit.
33644 (Method::GetCallingConvention): Implement, returns the calling
33646 (Method::Define): Defines the type, a second pass is performed
33647 later to populate the methods.
33649 (Constructor::ParameterTypes): implement a cache similar to the
33650 one on Method::ParameterTypes, useful later when we do semantic
33653 (TypeContainer::EmitMethod): New method. Emits methods.
33655 * expression.cs: Removed MethodGroup class from here.
33657 * parameter.cs (Parameters::GetCallingConvention): new method.
33659 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33661 * class.cs (TypeContainer::Populate): Drop RootContext from the
33664 (Constructor::CallingConvention): Returns the calling convention.
33665 (Constructor::ParameterTypes): Returns the constructor parameter
33668 (TypeContainer::AddConstructor): Keep track of default constructor
33669 and the default static constructor.
33671 (Constructor::) Another class that starts using `public readonly'
33672 instead of properties.
33674 (Constructor::IsDefault): Whether this is a default constructor.
33676 (Field::) use readonly public fields instead of properties also.
33678 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33679 track of static constructors; If none is used, turn on
33680 BeforeFieldInit in the TypeAttributes.
33682 * cs-parser.jay (opt_argument_list): now the return can be null
33683 for the cases where there are no arguments.
33685 (constructor_declarator): If there is no implicit `base' or
33686 `this', then invoke the default parent constructor.
33688 * modifiers.cs (MethodAttr): New static function maps a set of
33689 modifiers flags into a MethodAttributes enum
33690 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33691 MethodAttr, TypeAttr to represent the various mappings where the
33692 modifiers are used.
33693 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33695 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33697 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33700 * interface.cs (PopulateIndexer): Implemented the code generator
33701 for interface indexers.
33703 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33705 * interface.cs (InterfaceMemberBase): Now we track the new status
33708 (PopulateProperty): Implement property population. Woohoo! Got
33709 Methods and Properties going today.
33711 Removed all the properties for interfaces, and replaced them with
33712 `public readonly' fields.
33714 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33716 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33717 initialize their hashtables/arraylists only when they are needed
33718 instead of doing this always.
33720 * parameter.cs: Handle refs and out parameters.
33722 * cs-parser.jay: Use an ArrayList to construct the arguments
33723 instead of the ParameterCollection, and then cast that to a
33726 * parameter.cs: Drop the use of ParameterCollection and use
33727 instead arrays of Parameters.
33729 (GetParameterInfo): Use the Type, not the Name when resolving
33732 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33734 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33735 and instead use public readonly fields.
33737 * class.cs: Put back walking code for type containers.
33739 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33741 * class.cs (MakeConstant): Code to define constants.
33743 * rootcontext.cs (LookupType): New function. Used to locate types
33746 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33748 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33749 this System.Reflection code is. Kudos to Microsoft
33751 * typemanager.cs: Implement a type cache and avoid loading all
33752 types at boot time. Wrap in LookupType the internals. This made
33753 the compiler so much faster. Wow. I rule!
33755 * driver.cs: Make sure we always load mscorlib first (for
33756 debugging purposes, nothing really important).
33758 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33759 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33761 * rootcontext.cs: Lookup types on their namespace; Lookup types
33762 on namespaces that have been imported using the `using' keyword.
33764 * class.cs (TypeContainer::TypeAttr): Virtualize.
33765 (Class::TypeAttr): Return attributes suitable for this bad boy.
33766 (Struct::TypeAttr): ditto.
33767 Handle nested classes.
33768 (TypeContainer::) Remove all the type visiting code, it is now
33769 replaced with the rootcontext.cs code
33771 * rootcontext.cs (GetClassBases): Added support for structs.
33773 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33775 * interface.cs, statement.cs, class.cs, parameter.cs,
33776 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33777 Drop use of TypeRefs, and use strings instead.
33779 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33783 * class.cs (Struct::Struct): set the SEALED flags after
33784 checking the modifiers.
33785 (TypeContainer::TypeAttr): new property, returns the
33786 TypeAttributes for a class.
33788 * cs-parser.jay (type_list): Oops, list production was creating a
33789 new list of base types.
33791 * rootcontext.cs (StdLib): New property.
33792 (GetInterfaceTypeByName): returns an interface by type name, and
33793 encapsulates error handling here.
33794 (GetInterfaces): simplified.
33795 (ResolveTree): Encapsulated all the tree resolution here.
33796 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33799 * driver.cs: Add support for --nostdlib, to avoid loading the
33800 default assemblies.
33801 (Main): Do not put tree resolution here.
33803 * rootcontext.cs: Beginning of the class resolution.
33805 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33807 * rootcontext.cs: Provide better error reporting.
33809 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33811 * rootcontext.cs (CreateInterface): Handle the case where there
33812 are no parent interfaces.
33814 (CloseTypes): Routine to flush types at the end.
33815 (CreateInterface): Track types.
33816 (GetInterfaces): Returns an array of Types from the list of
33817 defined interfaces.
33819 * typemanager.c (AddUserType): Mechanism to track user types (puts
33820 the type on the global type hash, and allows us to close it at the
33823 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33825 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33826 RecordInterface instead.
33828 * cs-parser.jay: Updated to reflect changes above.
33830 * decl.cs (Definition): Keep track of the TypeBuilder type that
33831 represents this type here. Not sure we will use it in the long
33832 run, but wont hurt for now.
33834 * driver.cs: Smaller changes to accomodate the new code.
33836 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33839 * rootcontext.cs (CreateInterface): New method, used to create
33840 the System.TypeBuilder type for interfaces.
33841 (ResolveInterfaces): new entry point to resolve the interface
33843 (CodeGen): Property, used to keep track of the code generator.
33845 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33847 * cs-parser.jay: Add a second production for delegate_declaration
33850 (enum_body): Put an opt_comma here instead of putting it on
33851 enum_body or enum_member_declarations so we can handle trailing
33852 commas on enumeration members. Gets rid of a shift/reduce.
33854 (type_list): Need a COMMA in the middle.
33856 (indexer_declaration): Tell tokenizer to recognize get/set
33858 * Remove old targets.
33860 * Re-add the parser target.
33862 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33864 * cs-parser.jay: Add precendence rules for a number of operators
33865 ot reduce the number of shift/reduce conflicts in the grammar.
33867 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33869 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33872 Get rid of old crufty code.
33874 * rootcontext.cs: Use this to keep track of the parsed
33875 representation and the defined types available to the program.
33877 * gen-treedump.cs: adjust for new convention.
33879 * type.cs: Split out the type manager, and the assembly builder
33882 * typemanager.cs: the type manager will live here now.
33884 * cil-codegen.cs: And the code generator here.
33886 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33888 * makefile: Fixed up for easy making.
33890 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33892 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33895 (unary_expression): Expand pre_increment_expression and
33896 post_decrement_expression to reduce a shift/reduce.
33898 2001-07-11 Simon Cozens
33900 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33902 Improve allow_keyword_as_indent name.
33904 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33906 * Adjustments for Beta2.
33908 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33910 * decl.cs: Added `Define' abstract method.
33911 (InTransit): new property, used to catch recursive definitions.
33913 * interface.cs: Implement `Define'.
33915 * modifiers.cs: Map Modifiers.constants to
33916 System.Reflection.TypeAttribute flags.
33918 * class.cs: Keep track of types and user-defined types.
33919 (BuilderInit): New method for creating an assembly
33920 (ResolveType): New function to launch the resolution process, only
33921 used by interfaces for now.
33923 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33924 that are inserted into the name space.
33926 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33928 * ARGH. I have screwed up my tree so many times due to the use of
33929 rsync rather than using CVS. Going to fix this at once.
33931 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33934 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33936 * Experiment successful: Use System.Type rather that our own
33939 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33941 * cs-parser.jay: Removed nsAliases from here.
33943 Use new namespaces, handle `using XXX;'
33945 * namespace.cs: Reimplemented namespace handling, use a recursive
33946 definition of the class. Now we can keep track of using clauses
33947 and catch invalid using clauses.
33949 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33951 * gen-treedump.cs: Adapted for all the renaming.
33953 * expression.cs (Expression): this class now has a Type property
33954 which returns an expression Type.
33956 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33957 `Type', as this has a different meaning now in the base
33959 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33961 * interface.cs, class.cs: Removed from all the sources the
33962 references to signature computation, as we can not do method
33963 signature computation during the parsing time, as we are not
33964 trying to solve at that point distinguishing:
33968 void a (NS.Blah x) {}
33971 Which depending on the context might be valid or not, as we do not
33972 know if Blah is the same thing as NS.Blah at that point.
33974 * Redid everything so the code uses TypeRefs now instead of
33975 Types. TypeRefs are just temporary type placeholders, that need
33976 to be resolved. They initially have a pointer to a string and the
33977 current scope in which they are used. This is used later by the
33978 compiler to resolve the reference to an actual Type.
33980 * DeclSpace is no longer a CIR.Type, and neither are
33981 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33982 are all DeclSpaces, but no Types.
33984 * type.cs (TypeRefManager): This implements the TypeRef manager,
33985 which keeps track of all the types that need to be resolved after
33986 the parsing has finished.
33988 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33990 * ARGH. We are going to have to store `foreach' as a class rather
33991 than resolving it, as we need to verify error 1579 after name
33992 resolution. *OR* we could keep a flag that says `This request to
33993 IEnumerator comes from a foreach statement' which we can then use
33994 to generate the error.
33996 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33998 * class.cs (TypeContainer.AddMethod): we now add methods to the
33999 MethodGroup instead of the method hashtable.
34001 * expression.cs: Add MethodGroup abstraction, which gets us one
34002 step closer to the specification in the way we handle method
34005 * cs-parser.jay (primary_expression): qualified_identifier now
34006 tried to match up an identifier to a local variable reference or
34007 to a parameter reference.
34009 current_local_parameters is now a parser global variable that
34010 points to the current parameters for the block, used during name
34013 (property_declaration): Now creates an implicit `value' argument to
34016 2001-05-09 Miguel de Icaza <miguel@ximian.com>
34018 * parameter.cs: Do not use `param' arguments as part of the
34019 signature, per the spec.
34021 2001-05-08 Miguel de Icaza <miguel@ximian.com>
34023 * decl.cs: Base class for classes, structs and interfaces. This
34024 is the "Declaration Space"
34026 * cs-parser.jay: Use CheckDef for checking declaration errors
34027 instead of having one on each function.
34029 * class.cs: Factor out some code for handling error handling in
34030 accordance to the "Declarations" section in the "Basic Concepts"
34031 chapter in the ECMA C# spec.
34033 * interface.cs: Make all interface member classes derive from
34034 InterfaceMemberBase.
34036 2001-05-07 Miguel de Icaza <miguel@ximian.com>
34038 * Many things: all interfaces are parsed and generated in
34039 gen-treedump. Support for member variables, constructors,
34040 destructors, properties, constants is there.
34042 Beginning of the IL backend, but very little done, just there for
34045 2001-04-29 Miguel de Icaza <miguel@ximian.com>
34047 * cs-parser.jay: Fix labeled statement.
34049 * cs-tokenizer.cs (escape): Escape " and ' always.
34050 ref_line, ref_name: keep track of the line/filename as instructed
34051 by #line by the compiler.
34054 2001-04-27 Miguel de Icaza <miguel@ximian.com>
34056 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
34057 to match the values in System.CodeDOM.
34059 Divid renamed to Divide.
34061 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
34063 (Statements.set): remove.
34065 * System.CodeDOM/CodeCatchClause.cs: always have a valid
34068 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
34069 falseStatements always have valid values.
34071 * cs-parser.jay: Use System.CodeDOM now.