1 2010-06-25 Marek Safar <marek.safar@gmail.com>
3 * statement.cs, cs-parser.jay: Don't create expensive block for
6 2010-06-24 Marek Safar <marek.safar@gmail.com>
8 * statement.cs, report.cs: Rethrow internal error when reporting is
11 * ecore.cs: Check for identical name only when simple name is set.
14 2010-06-24 Marek Safar <marek.safar@gmail.com>
17 * generic.cs, expression.cs, ecore.cs: Added a new type expression
18 for open generic type to pass unbound type arguments to typeof
21 2010-06-24 Marek Safar <marek.safar@gmail.com>
23 * statement.cs: Foreach collection implementation refactoring to
24 search for GetEnumerator more preciselly. Fixes #431453 and more
27 * linq.cs, decl.cs, ecore.cs, delegate.cs: Update methodgroup api.
29 2010-06-23 Marek Safar <marek.safar@gmail.com>
31 * cs-parser.jay: Track more locations.
33 2010-06-22 Marek Safar <marek.safar@gmail.com>
35 * cs-tokenizer.cs, location.cs, cs-parser.jay: Track more locations.
37 2010-06-18 Marek Safar <marek.safar@gmail.com>
39 * cs-tokenizer.cs, anonymous.cs, expression.cs, statement.cs,
40 support.cs, location.cs, cs-parser.jay: Some work on full ast mode.
42 2010-06-18 Marek Safar <marek.safar@gmail.com>
44 * convert.cs, typespec.cs, method.cs: Fixed few more dynamic
47 2010-06-18 Marek Safar <marek.safar@gmail.com>
49 * typemanager.cs, namespace.cs: Report more predefined types and
50 imported types collision types as a warning.
51 Fixes #537414, #601157
53 2010-06-18 Marek Safar <marek.safar@gmail.com>
55 * generic.cs: Overrides base method constraint can use method type
58 * import.cs: Removed redundant cache.
60 2010-06-17 Marek Safar <marek.safar@gmail.com>
62 * generic.cs: Propagate type only inflate downwards.
64 2010-06-17 Marek Safar <marek.safar@gmail.com>
67 * method.cs: Do not reject binary dynamic operators.
69 2010-06-17 Marek Safar <marek.safar@gmail.com>
71 * typespec.cs: Internal types have no generic parameters.
74 2010-06-17 Marek Safar <marek.safar@gmail.com>
77 * cs-parser.jay: Correctly set expression mode for default parameter
80 2010-06-17 Marek Safar <marek.safar@gmail.com>
83 * ecore.cs: Resolve dynamic namespace and keyword collision in the
84 favour of the keyword.
86 2010-06-17 Marek Safar <marek.safar@gmail.com>
89 * convert.cs: Allow more undocumented 0 like values to enum type
92 2010-06-17 Marek Safar <marek.safar@gmail.com>
94 * generic.cs, method.cs: Inflate copied type parameters from base
95 class or explicit interfaces.
97 * convert.cs: Fixed conversion between two type parameters.
100 2010-06-16 Marek Safar <marek.safar@gmail.com>
102 * membercache.cs, convert.cs: Correctly resize an array used by
105 2010-06-15 Marek Safar <marek.safar@gmail.com>
107 A fix for bug #599601
108 * dynamic.cs, ecore.cs: A new flag for dynamic resolver to ignore
109 generated member access left expression.
111 2010-06-16 Marek Safar <marek.safar@gmail.com>
113 * expression.cs: Dispatch dynamic invocation solely on left
116 2010-06-16 Marek Safar <marek.safar@gmail.com>
118 * expression.cs, statement.cs: Always persist explicit cast
119 semantic at expression level.
121 2010-06-15 Marek Safar <marek.safar@gmail.com>
123 * expression.cs, attribute.cs: Enable generic type parameters
126 2010-06-15 Marek Safar <marek.safar@gmail.com>
128 A fix for bug #612146
129 * generic.cs: Don't use fixed array for inflated type parameter
130 interface constraints.
132 2010-06-15 Marek Safar <marek.safar@gmail.com>
134 * typespec.cs: ElementTypeSpec has to use its own ITypeDefinition.
136 * report.cs: Unwrap elements for related symbols reporting.
138 2010-06-15 Marek Safar <marek.safar@gmail.com>
140 A fix for bug #612796
141 * cs-tokenizer.cs: Offset correctly keywords the first character
144 2010-06-15 Marek Safar <marek.safar@gmail.com>
146 A fix for bug #613397
147 * expression.cs: Removed too aggressive object initializers
150 2010-06-15 Marek Safar <marek.safar@gmail.com>
152 * parameter.cs, property.cs, membercache.cs, decl.cs, iterators.cs,
153 anonymous.cs, expression.cs, support.cs, method.cs, pending.cs,
154 class.cs, cs-parser.jay: Simplify parsing of accessors by removing
155 any intermediate steps and fake nodes, also saves few MBs of memory.
157 2010-06-11 Marek Safar <marek.safar@gmail.com>
159 * modifiers.cs, rootcontext.cs, location.cs, cs-parser.jay: More
160 precise modifiers parsing.
162 2010-06-09 Marek Safar <marek.safar@gmail.com>
164 * cs-tokenizer.cs, anonymous.cs, expression.cs, cs-parser.jay:
165 Fixed few shift/reduce conflicts.
167 2010-06-09 Marek Safar <marek.safar@gmail.com>
169 * typemanager.cs, parameter.cs, dynamic.cs, typespec.cs,
170 expression.cs, ecore.cs, cs-parser.jay: Fully parse composed type
171 specifiers and stop using string in AST.
173 2010-06-07 Marek Safar <marek.safar@gmail.com>
175 * typemanager.cs, eval.cs, iterators.cs, anonymous.cs, expression.cs
176 method.cs, class.cs, delegate.cs, cs-parser.jay, driver.cs, visit.cs
177 enum.cs: Hold location of predefined types.
179 2010-06-07 Marek Safar <marek.safar@gmail.com>
181 A fix for bug #610878
182 * pending.cs: Clone cached list before modifying.
184 2010-06-04 Marek Safar <marek.safar@gmail.com>
186 * convert.cs, typespec.cs, expression.cs: Start using array member
187 kind for better conversion checks.
189 * import.cs, report.cs: Report better error message for runtime
192 2010-06-04 Marek Safar <marek.safar@gmail.com>
194 * membercache.cs, convert.cs, nullable.cs, expression.cs: Optimize
195 user defined conversion probing and simplify user conversion for
196 nullabe types. Fixes #610940.
198 2010-06-03 Marek Safar <marek.safar@gmail.com>
200 A fix for bug #610919
201 * parameter.cs, property.cs, cs-parser.jay: Use independent implicit
202 parameters for explicit event accessors. Anonymous method capturing
203 won't otherwise work for event implicit parameter.
205 2010-06-02 Marek Safar <marek.safar@gmail.com>
207 A fix for bug #610088
208 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs:
209 Ignore overrides for base overload resolution as for non-base
210 expressions and convert the best candidate to closest override
213 2010-06-01 Marek Safar <marek.safar@gmail.com>
215 A fix for bug #610139
216 * generic.cs, convert.cs: Recursively check effective base interface
218 2010-06-01 Marek Safar <marek.safar@gmail.com>
220 * statement.cs: Handle nullable types and type parameters in using
221 statement, avoid boxing value types. Also fixes #571010
223 2010-06-01 Marek Safar <marek.safar@gmail.com>
225 * convert.cs, expression.cs: Emit unbox for underlying nullable
228 2010-05-29 Marek Safar <marek.safar@gmail.com>
230 A fix for bug #610126
231 * expression.cs: Don't use branch optimization for types bigger than
234 2010-05-28 Marek Safar <marek.safar@gmail.com>
236 A fix for bug #609088
237 * import.cs: Check private modifier correctly.
239 2010-05-28 Marek Safar <marek.safar@gmail.com>
241 A fix for bug #609049
242 * ecore.cs: Don't ignore override methods when looking for base
245 2010-05-27 Marek Safar <marek.safar@gmail.com>
247 A fix for bugs #608007, #572540, #566130, #476358
249 * generic.cs, linq.cs, expression.cs, statement.cs, cs-parser.jay:
250 More tricky refactoring of implicit linq blocks.
252 2010-05-25 Marek Safar <marek.safar@gmail.com>
254 * linq.cs, cs-parser.jay: Keep location for all linq clauses.
256 2010-05-25 Marek Safar <marek.safar@gmail.com>
258 * context.cs, expression.cs, cs-parser.jay: Don't store current
259 block in This expression (it's too early for linq blocks).
261 2010-05-21 Marek Safar <marek.safar@gmail.com>
263 * expression.cs: Use constrained prefix more broadly to avoid boxing.
265 2010-05-20 Marek Safar <marek.safar@gmail.com>
267 A fix for bug #591149
268 * nullable.cs: Don't double wrap same expression.
270 2010-05-20 Marek Safar <marek.safar@gmail.com>
272 A fix for bug #569827
273 * anonymous.cs: Any issued error in probing mode means no match.
275 2010-05-20 Marek Safar <marek.safar@gmail.com>
277 * expression.cs: Search for base indexer using the closest match
280 2010-05-20 Marek Safar <marek.safar@gmail.com>
282 A fix for bug #572071
283 * method.cs: Set override constraints using unexpanded interface
286 2010-05-20 Marek Safar <marek.safar@gmail.com>
288 A fix for bug #572071
289 * ecore.cs: Include secondary extension method lookup in probing
292 2010-05-19 Marek Safar <marek.safar@gmail.com>
294 A fix for bug #515801
295 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
298 2010-05-19 Marek Safar <marek.safar@gmail.com>
300 A fix for bug #515801
301 * pending.cs: Advance counter correctly.
303 2010-05-19 Marek Safar <marek.safar@gmail.com>
305 A fix for bug #480139
306 * method.cs, pending.cs: Indexer override uses base name.
308 2010-05-19 Marek Safar <marek.safar@gmail.com>
310 A fix for bug #424064
311 * generic.cs: Replace original with inflated type parameter on
314 2010-05-19 Marek Safar <marek.safar@gmail.com>
316 A fix for bug #359733
317 * parameter.cs: Extension attribute can be defined in each assembly.
319 2010-05-18 Marek Safar <marek.safar@gmail.com>
321 A fix for bug #446507
322 * method.cs: Only one method can implement an interface.
324 2010-05-18 Marek Safar <marek.safar@gmail.com>
326 A fix for bug #594905
327 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
328 Typed null can be used as a source for expression methods.
330 2010-05-18 Marek Safar <marek.safar@gmail.com>
332 A fix for bug #606551
333 * namespace.cs: Using directive imports only types and not nested
336 2010-05-17 Marek Safar <marek.safar@gmail.com>
338 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
339 delegate.cs: Member instance is resolved after member overload
340 definitely resolves static/instance property of member expression.
341 Fixes #545047, #358848, #456605, #460016, #603299
343 2010-05-12 Marek Safar <marek.safar@gmail.com>
345 A fix for bug #604981
346 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
347 details for nested anonymous methods stories.
349 2010-05-11 Marek Safar <marek.safar@gmail.com>
351 A fix for bug #604735
352 * namespace.cs: Don't report namespace collision.
354 2010-05-11 Marek Safar <marek.safar@gmail.com>
356 A fix for bug #604748
357 * class.cs, typespec.cs: Search full imported attribute hierarchy
360 2010-05-11 Marek Safar <marek.safar@gmail.com>
362 * namespace.cs: Ignore missing dependencies failure at
365 2010-05-11 Marek Safar <marek.safar@gmail.com>
367 A fix for bug #604640
368 * namespace.cs: Don't resolve using constraints too early.
370 2010-05-11 Marek Safar <marek.safar@gmail.com>
372 A fix for bug #604239
373 * generic.cs: Copy partial type constraints to partial container.
375 2010-05-10 Marek Safar <marek.safar@gmail.com>
377 A fix for bug #557210
378 * import.cs: Relax underlying enum field rules.
380 2010-05-10 Marek Safar <marek.safar@gmail.com>
382 A fix for bug #603476
383 * property.cs: Implement IParametersMember for indexer accessors.
385 2010-05-07 Marek Safar <marek.safar@gmail.com>
387 A fix for bug #601141
388 * class.cs: Update all partial modifiers.
390 2010-05-06 Marek Safar <marek.safar@gmail.com>
392 A fix for bug #601708
393 * method.cs, membercache.cs: Destructors cannot be hidden.
395 2010-05-06 Marek Safar <marek.safar@gmail.com>
397 A fix for bug #602551
398 * class.cs: Resursive reference of type definition is allowed.
400 2010-05-06 Marek Safar <marek.safar@gmail.com>
402 * anonymous.cs: Mutate cached storey instance types too.
404 2010-05-06 Marek Safar <marek.safar@gmail.com>
406 A fix for bug #602443
407 * convert.cs: Explicit enum conversion cannot involve user operators
409 2010-05-05 Miguel de Icaza <miguel@novell.com>
411 * class.cs (TypeContainer.DefineBaseTypes)
412 (TypeContainer.CheckRecursiveDefinition): check for the iface not
413 being null, as we could have failed resolution and crashed;
416 * cs-parser.jay: Productions to catch common mistakes when other
417 punctuation operators are used instead of comma. Fixes 571702
419 2010-05-05 Marek Safar <marek.safar@gmail.com>
421 * anonymous.cs: Mutate correct set of constraints.
423 2010-05-05 Marek Safar <marek.safar@gmail.com>
425 A fix for bug #602842
426 * expression.cs: Resolve all array bound arguments.
428 2010-05-05 Marek Safar <marek.safar@gmail.com>
430 * import.cs: Don't import private fields.
432 2010-04-30 Marek Safar <marek.safar@gmail.com>
434 Partially based on patch by <sami.lamti@gmail.com>
436 * eval.cs, ecore.cs: Fixed eval show methods.
438 2010-04-30 Marek Safar <marek.safar@gmail.com>
440 * generic.cs, delegate.cs: Implement output type inference of
441 methodgroup now when the specification was cleared at least little
444 2010-04-29 Marek Safar <marek.safar@gmail.com>
446 A fix for bug #575611
447 * class.cs: Fix recursive unmanaged recursice sruct check.
449 2010-04-29 Marek Safar <marek.safar@gmail.com>
451 A fix for bug #479776
452 * expression.cs: Implement typeof unbounded nested generic types.
454 2010-04-29 Marek Safar <marek.safar@gmail.com>
456 A fix for bug #474953
457 * class.cs: Fix valid recursive base type definition.
459 2010-04-29 Marek Safar <marek.safar@gmail.com>
461 A fix for bug #421737
462 * convert.cs, expression.cs: A boxing conversion exists from a
463 nullable-type to a reference type, if a boxing conversion exists
464 from the underlying non-nullable-value-type to the reference type.
466 2010-04-29 Marek Safar <marek.safar@gmail.com>
468 A fix for bug #376875
469 * import.cs: Import volatile modifier.
471 2010-04-29 Marek Safar <marek.safar@gmail.com>
473 A fix for bug #372412
474 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
477 2010-04-29 Marek Safar <marek.safar@gmail.com>
479 A fix for bug #568955
480 * statements.cs: Handle recursive scope initializers.
482 2010-04-28 Marek Safar <marek.safar@gmail.com>
484 A fix for bug #566511
485 * anonymous.cs: Always get inflated version of hoisted variable
486 on generic type definition.
488 2010-04-28 Marek Safar <marek.safar@gmail.com>
490 * import.cs, membercache.cs: Relax rules for valid properties.
492 2010-04-28 Marek Safar <marek.safar@gmail.com>
494 * import.cs: Intern arrays used in generic arguments.
496 2010-04-28 Marek Safar <marek.safar@gmail.com>
498 A fix for bug #600398
499 * convert.cs: Actually use effective base type for the comparison.
501 2010-04-28 Marek Safar <marek.safar@gmail.com>
503 A fix for bug #600326
504 * ecore.cs: Pass arity to base member lookup.
506 2010-04-28 Marek Safar <marek.safar@gmail.com>
508 A fix for bug #573385
509 * expression.cs: MemberAccess is of generic type based on right
512 2010-05-28 Marek Safar <marek.safar@gmail.com>
514 * cs-tokenizer.cs: Made tab size configurable.
516 2010-05-27 Marek Safar <marek.safar@gmail.com>
518 * attribute.cs: Ensure Obsolete members are defined before doing
521 2010-05-27 Marek Safar <marek.safar@gmail.com>
523 * visit.cs: Add DOM visitor skeleton.
527 2010-05-27 Marek Safar <marek.safar@gmail.com>
529 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
531 2010-05-27 Marek Safar <marek.safar@gmail.com>
533 * *.cs: Major rewrite of compiler internals to better work with
534 unmodified System.Reflection.Emit. Some of the key changes are
535 - TypeSpec replaces reflection specific System.Type.
536 - All Type(TypeSpec) operations are now done in compiler therefore
537 no dependency on SRE to inflate generic members and types or to
538 query unclosed types.
539 - MemberCache is now the only and full hierarchical topology.
540 - Generic constraints are implemented properly.
541 - And as a bonus compilation is on average 30% faster.
543 2010-04-15 Jb Evain <jbevain@novell.com>
545 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
547 2010-04-12 Marek Safar <marek.safar@gmail.com>
549 * expression.cs, attribute.cs, parameter.cs: More attribute type
552 2010-04-12 Marek Safar <marek.safar@gmail.com>
554 A fix for bug #593342
556 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
557 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
558 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
559 codegen.cs: Add custom attribute encoder to deal with unfinished
560 types and easier corlib bootstrap from its own types.
562 2010-03-26 Marek Safar <marek.safar@gmail.com>
564 * cs-parser.jay: Report invalid constraint types.
566 2010-03-16 Jb Evain <jbevain@novell.com>
568 * Makefile: rename the net_2_1 profile to moonlight.
570 2010-03-11 Marek Safar <marek.safar@gmail.com>
572 * statement.cs, cs-parser.jay: Use correct location for empty
575 2010-03-11 Marek Safar <marek.safar@gmail.com>
577 * cs-parser.jay: Disable Location from expression.
579 * generic.cs: Check constraints for overrides in the parser.
581 2010-03-09 Marek Safar <marek.safar@gmail.com>
583 * cs-parser.jay (GetLocation): Use an expression when available.
585 2010-03-04 Marek Safar <marek.safar@gmail.com>
587 A fix for bug #582579
588 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
590 2010-03-04 Marek Safar <marek.safar@gmail.com>
592 A patch by kornelpal@gmail.com
594 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
595 compiler generated classes sealed by default. Emit and close top
596 level compiler generated classes as well.
598 * support.cs: Use RuntimeHelpers.GetHashCode.
600 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
602 * Makefile: We need to use the internal bootstrapping gmcs for
603 net_2_1_bootstrap too now.
605 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
607 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
609 2010-03-02 Marek Safar <marek.safar@gmail.com>
611 * cs-tokenizer.cs: Missed few locations in previous fix.
613 2010-03-02 Marek Safar <marek.safar@gmail.com>
615 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
616 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
617 Report correct location for operator errors.
619 2010-03-02 Marek Safar <marek.safar@gmail.com>
621 * typemanager.cs (IsDynamicType): Don't check external types when
622 the attribute is not external.
624 2010-02-24 Marek Safar <marek.safar@gmail.com>
626 A fix for bug #582579
627 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
630 2010-02-24 Marek Safar <marek.safar@gmail.com>
632 A fix for bug #581804
633 * ecore.cs: Fixed type comparison.
635 2010-02-08 Miguel de Icaza <miguel@novell.com>
637 * namespace.cs (CompletionGetTypesStartingWith): Do not include
638 private types in the completion results.
640 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
643 2010-02-17 Marek Safar <marek.safar@gmail.com>
645 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
648 2010-02-14 Miguel de Icaza <miguel@novell.com>
650 * eval.cs: Do not do the report printer dance unless the user has
651 set the DescribeTypes feature.
653 2010-02-10 Marek Safar <marek.safar@gmail.com>
655 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
657 2010-02-08 Marek Safar <marek.safar@gmail.com>
659 A fix for bug #577029
660 * anonymous.cs: Fixed TypeBuilder* check.
662 2010-02-06 Miguel de Icaza <miguel@novell.com>
664 * eval.cs (CompileBlock): Also undo if there are problems during
665 semantic analysis, fixes various cases where invalid C# code would
666 be reported, but the internal changes would not be undone.
668 2010-02-03 Miguel de Icaza <miguel@novell.com>
670 * driver.cs: Change the --fatal flag to allow a number to be
671 passed, this ignores the first N fatal errors. Useful to debug
672 errors that do not happen on the first hit.
674 * cs-parser.jay (invocation_expression): accept both the
675 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
676 inside an invocation.
678 * driver.cs: Expose FatalErrors.
680 * eval.cs: Initialize the printer's Fatal property from the
681 Driver's FatalError flag, this allows csharp --fatal to work
684 Add support for calling Describe (typeof (TYPE)) if the expression
687 2010-02-02 Marek Safar <marek.safar@gmail.com>
689 A fix for bug #574991
690 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
693 2010-02-02 Marek Safar <marek.safar@gmail.com>
695 A fix for bug #575986
696 * expression.cs: Don't mutate typeof type definitions.
698 2010-01-28 Marek Safar <marek.safar@gmail.com>
700 * decl.cs: Use only one set of modifiers.
702 2010-01-26 Marek Safar <marek.safar@gmail.com>
704 A fix for bug #573329
705 * eval.cs: Don't disable error reporting completely on silent mode.
707 2010-01-25 Marek Safar <marek.safar@gmail.com>
709 A fix for bug #573312
710 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
711 pointer index of unknown size types greater than 2.
713 2010-01-15 Marek Safar <marek.safar@gmail.com>
715 * *.cs: Use only 1 member kind enum.
717 2010-01-15 Marek Safar <marek.safar@gmail.com>
719 * *.cs: Add event specification.
721 2010-01-14 Marek Safar <marek.safar@gmail.com>
723 * membercache.cs: Extracted from decl.cs.
725 * *.cs: Put more infrastructure in place.
727 2010-01-13 Marek Safar <marek.safar@gmail.com>
729 * *.cs: Add property specification, unused yet.
731 2010-01-13 Marek Safar <marek.safar@gmail.com>
733 * property.cs: Move all property based declarations into a new file.
735 2010-01-13 Marek Safar <marek.safar at gmail.com>
737 * expression.cs (Conditional): Resolve reduced expression.
739 2010-01-13 Marek Safar <marek.safar at gmail.com>
741 * *.cs: Introduced non-generic method specification.
743 2010-01-07 Marek Safar <marek.safar@gmail.com>
745 * method.cs: Move all method based declarations into a new file.
747 2010-01-07 Marek Safar <marek.safar@gmail.com>
749 * *.cs: Extract field specification.
751 2009-12-17 Marek Safar <marek.safar@gmail.com>
753 * field.cs: Extracted from class.cs
755 2009-12-15 Marek Safar <marek.safar@gmail.com>
757 * attribute.cs (GetFixedBuffer): Work on field definition only.
759 2009-12-15 Marek Safar <marek.safar@gmail.com>
761 * *.cs: Clean up NET_4_0 conditional where possible.
763 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
765 support.cs (DynamicType): Assembly property returns the assembly builder.
766 This is required due to how compiler context works in corlib.
768 2009-12-14 Marek Safar <marek.safar@gmail.com>
770 A fix for bug #564376
771 * assign.cs (LocalTemporary): Removed no longer needed special
774 2009-12-11 Marek Safar <marek.safar@gmail.com>
776 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
777 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
778 enum for easier debugging.
780 2009-12-10 Marek Safar <marek.safar@gmail.com>
782 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
785 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
788 2009-12-10 Marek Safar <marek.safar@gmail.com>
790 * cs-parser.jay, statement.cs: Handle parser error in code
793 2009-12-10 Marek Safar <marek.safar@gmail.com>
795 * ecore.cs: Ignore base imported methods when they are already
798 * eval.cs: Handle non-existent keys.
800 * report.cs, driver.cs: Make fatal work with console printer only.
802 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
804 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
806 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
808 * typemanager.cs: Add MakeGenericMethod that checks if the method
809 is really the generic method definition.
811 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
812 to inflate generic methods.
814 2009-12-08 Marek Safar <marek.safar@gmail.com>
816 A fix for bug #561149
817 * anonymous.cs: Use actual type parameters when checking for generic
820 2009-12-08 Marek Safar <marek.safar@gmail.com>
822 A fix for bug #561369
823 * expression.cs (DoNumericPromotion): Fixed typo.
825 2009-12-08 Marek Safar <marek.safar@gmail.com>
827 *.cs: Moving to generics world.
829 cs-parser.jay: Removed current_array_type.
831 2009-12-07 Marek Safar <marek.safar@gmail.com>
833 *.cs: Moving to generics world.
835 2009-12-04 Marek Safar <marek.safar@gmail.com>
837 *.cs: Moving to generics world (day 2).
839 2009-12-03 Marek Safar <marek.safar@gmail.com>
841 *.cs: Moving to generics world.
843 2009-12-02 Marek Safar <marek.safar@gmail.com>
845 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
846 Encode dynamic type attribute for elements where attributes cannot
849 2009-12-01 Marek Safar <marek.safar@gmail.com>
851 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
854 2009-12-01 Marek Safar <marek.safar@gmail.com>
856 A fix for bug #360455
857 * class.cs: Never report a unused warning for generic events to
858 workaround wrong expression type.
860 2009-11-30 Marek Safar <marek.safar@gmail.com>
862 A fix for bug #558305
863 * decl.cs, class.cs: Check partial method definitions using correct
866 2009-11-30 Marek Safar <marek.safar@gmail.com>
868 * argument.cs: Don't cache rarely used dynamic flag.
870 2009-11-27 Marek Safar <marek.safar@gmail.com>
872 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
874 2009-11-27 Marek Safar <marek.safar@gmail.com>
876 * ecore.cs (SimpleName): Removed no longer needed in_transit as
877 Resolve is now non-reentrant (saves ~0.6MB for corlib).
879 2009-11-26 Marek Safar <marek.safar@gmail.com>
881 A fix for bug #545081
882 * decl.cs: Check private nested types of nested types recursively.
884 2009-11-26 Marek Safar <marek.safar@gmail.com>
886 A fix for bug #558305
887 * location.cs: Ignore self referencing #line directive
889 2009-11-26 Marek Safar <marek.safar@gmail.com>
891 A fix for bug #558292
892 * class.cs: Allow single unsafe fixed buffer fields.
894 2009-11-26 Marek Safar <marek.safar@gmail.com>
896 * expression: Optimize few more zero-based operations.
898 2009-11-26 Marek Safar <marek.safar@gmail.com>
900 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
901 avoids boxing of literal values.
903 2009-11-26 Marek Safar <marek.safar@gmail.com>
905 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
906 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
907 codegen.cs: LocatedToken redesing to avoid excessive allocation and
908 boxing (saves ~7MB for corlib). Also fixes presise token location.
910 2009-11-25 Marek Safar <marek.safar@gmail.com>
912 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
915 2009-11-24 Marek Safar <marek.safar@gmail.com>
917 * expression.cs: Lower static array initializer barrier.
919 * support.cs, driver.cs: Share reader buffer.
921 2009-11-23 Marek Safar <marek.safar@gmail.com>
923 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
925 2009-11-23 Marek Safar <marek.safar@gmail.com>
927 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
928 cleanup some obsolete code.
930 2009-11-20 Marek Safar <marek.safar@gmail.com>
932 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
935 2009-11-20 Marek Safar <marek.safar@gmail.com>
937 * *.cs: Resolved expressions are never resolved again, this helps to
938 uncover some not easy to find bugs and improve the performance.
940 2009-11-19 Marek Safar <marek.safar@gmail.com>
942 * *.cs: Made constant expressions fully compatible with any other
945 2009-11-19 Marek Safar <marek.safar@gmail.com>
947 * *.cs: DoResolve is a worker method and has to be protected.
949 2009-11-18 Marek Safar <marek.safar@gmail.com>
951 * *.cs: More context specific handling.
953 2009-11-17 Marek Safar <marek.safar@gmail.com>
955 * *.cs: More context specific handling.
957 2009-11-16 Marek Safar <marek.safar@gmail.com>
959 * dynamic.cs, class.cs: Removed few fixed user types conversions.
961 * symbolwriter.cs: Uses public ILOffset.
963 2009-11-13 Marek Safar <marek.safar@gmail.com>
965 A fix for bug #553650
966 * generic.cs: Another missing TypeToCoreType, still too many to fix.
968 2009-11-13 Marek Safar <marek.safar@gmail.com>
970 A fix for bug #555170
972 * class.cs, delegate.cs, enum.cs: Constants have to be available
973 for parameters resolve.
975 2009-11-12 Marek Safar <marek.safar@gmail.com>
977 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
980 2009-11-12 Marek Safar <marek.safar@gmail.com>
982 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
983 with a statically known candidate set.
985 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
987 * generic.cs: Made type inflation for generic constraint checks
988 recursive. This fixes BGO #553655.
990 2009-11-11 Marek Safar <marek.safar@gmail.com>
992 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
995 2009-11-10 Marek Safar <marek.safar@gmail.com>
997 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
998 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
999 attribute.cs: Add some dynamic error checking.
1001 2009-11-07 Marek Safar <marek.safar@gmail.com>
1003 A fix for bug #553465
1005 * expression.cs: Fixed mixed version of expression tree anonymous
1008 2009-11-06 Marek Safar <marek.safar@gmail.com>
1010 A fix for bug #553031
1012 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
1013 expression tree version of anonymous type with members declaration.
1015 2009-11-05 Marek Safar <marek.safar@gmail.com>
1017 * parameter.cs: Handle nullable parameter default expression.
1019 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
1020 class.cs, attribute.cs: Check for wrong dynamic arguments.
1022 2009-11-05 Marek Safar <marek.safar@gmail.com>
1024 * statement.cs: Dynamic statements.
1026 2009-11-04 Marek Safar <marek.safar@gmail.com>
1028 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
1029 Compound assignments over dynamic type.
1031 2009-11-03 Marek Safar <marek.safar@gmail.com>
1033 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
1034 constructor arguments.
1036 2009-10-30 Marek Safar <marek.safar@gmail.com>
1038 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
1039 codegen.cs: Unary mutator on dynamic member access expression.
1041 2009-10-29 Marek Safar <marek.safar@gmail.com>
1043 A fix for bug #550580
1044 * convert.cs: Don't eliminate explicit precission casts.
1046 2009-10-28 Marek Safar <marek.safar@gmail.com>
1048 A fix for bug #550404
1050 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
1051 expression.cs, statement.cs, ecore.cs: Quote any nested expression
1054 2009-10-27 Marek Safar <marek.safar@gmail.com>
1056 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
1059 * class.cs: Allow nullable binary user operators.
1061 2009-10-26 Marek Safar <marek.safar@gmail.com>
1063 * expression.cs: Move binary expression optimization at the end of
1066 2009-10-23 Marek Safar <marek.safar@gmail.com>
1068 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
1069 Separate NullConstant from NullLiteral.
1071 2009-10-23 Marek Safar <marek.safar@gmail.com>
1073 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
1074 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
1075 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
1076 ModuleContainer. Add common unclosed member check routine.
1078 2009-10-22 Marek Safar <marek.safar@gmail.com>
1080 * argument.cs: Use literal flag for real literals only.
1082 * dynamic.cs: Use correct return type for custom delegates.
1084 2009-10-22 Marek Safar <marek.safar@gmail.com>
1086 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
1089 2009-10-22 Marek Safar <marek.safar@gmail.com>
1091 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
1093 2009-10-21 Marek Safar <marek.safar@gmail.com>
1095 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
1098 2009-10-21 Marek Safar <marek.safar@gmail.com>
1100 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
1103 2009-10-20 Marek Safar <marek.safar@gmail.com>
1105 * argument.cs, dynamic.cs, expression.cs: Latest API update.
1107 2009-10-19 Marek Safar <marek.safar@gmail.com>
1109 * typemanager.cs, expression.cs: Dynamic array initializer.
1111 2009-10-16 Marek Safar <marek.safar@gmail.com>
1113 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
1116 2009-10-16 Marek Safar <marek.safar@gmail.com>
1118 A fix for bug #493523, #507067
1119 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
1120 standard nullable conversion using underlying standard conversion
1121 and not full conversion.
1123 2009-10-15 Marek Safar <marek.safar@gmail.com>
1125 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
1126 type in VerifyArgumentsCompat.
1128 2009-10-15 Marek Safar <marek.safar@gmail.com>
1130 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1131 Reject variable used with type arguments.
1133 2009-10-14 Marek Safar <marek.safar@gmail.com>
1135 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
1136 Implement dynamic expressions assignment.
1138 2009-10-14 Marek Safar <marek.safar@gmail.com>
1140 * expression.cs: Build underlying expression when resolving unary
1143 2009-10-14 Marek Safar <marek.safar@gmail.com>
1145 * expression.cs: Emit enum array initializer using binary blob.
1147 2009-10-08 Marek Safar <marek.safar@gmail.com>
1149 * typemanager.cs, constant.cs: Optimize decimal constants which fit
1152 2009-10-07 Marek Safar <marek.safar@gmail.com>
1154 * typemanager.cs: Reset object_type.
1156 * assign: Made SimpleAssign public.
1158 2009-10-06 Marek Safar <marek.safar@gmail.com>
1160 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
1161 invocation assembly to IsThisOrFriendAssembly.
1163 2009-10-05 Marek Safar <marek.safar@gmail.com>
1165 * expression.cs: Equality comparison of generic parameter with
1168 2009-10-05 Marek Safar <marek.safar@gmail.com>
1170 A fix for bug #543570
1171 * generic.cs: Import predefined constraints correctly.
1173 2009-10-02 Marek Safar <marek.safar@gmail.com>
1175 * ecore.cs: Don't crash on overloads with optional paremeters where
1176 arguments count overflows.
1178 * parameter.cs: Import optional parameter constants using optional
1181 2009-10-01 Marek Safar <marek.safar@gmail.com>
1183 * Makefile: Default is gmcs compiler.
1185 2009-10-01 Marek Safar <marek.safar@gmail.com>
1187 * cs-parser.jay: Fixed few NRE.
1189 2009-10-01 Marek Safar <marek.safar@gmail.com>
1191 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
1193 2009-09-30 Marek Safar <marek.safar@gmail.com>
1195 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
1196 ShimExpression, ImplicitCast.
1198 2009-09-30 Marek Safar <marek.safar@gmail.com>
1200 A fix for bug #542959
1201 * delegate.cs: Emit correct delegate instance variable when there
1202 are static and non-static overloads.
1204 2009-09-29 Marek Safar <marek.safar@gmail.com>
1206 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
1207 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
1209 2009-09-28 Marek Safar <marek.safar@gmail.com>
1211 A fix for bug #542487
1212 * ecore.cs: Resolve extension methods hidden by properties.
1214 2009-09-25 Marek Safar <marek.safar@gmail.com>
1216 * expression.cs, ecore.cs: More dynamic binary expressions.
1218 2009-09-22 Marek Safar <marek.safar@gmail.com>
1220 * nullable.cs, expression.cs: Fixed null lifted conversion for
1221 bitwise enum operations.
1223 2009-09-22 Marek Safar <marek.safar@gmail.com>
1225 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
1226 values in checked context.
1228 2009-09-22 Marek Safar <marek.safar@gmail.com>
1230 * expression.cs, ecore.cs: Fixed array index constant conversion.
1232 2009-09-20 Miguel de Icaza <miguel@novell.com>
1234 * expression.cs: Do not crash when MemberLookup returns something
1235 that is not a MemberExpr here. Report error 582 instead.
1239 2009-09-18 Marek Safar <marek.safar@gmail.com>
1241 * decl.cs, class.cs: Check protected property accessors.
1243 2009-09-18 Marek Safar <marek.safar@gmail.com>
1245 * dynamic.cs, assign.cs: Dynamic compound assignment.
1247 2009-09-17 Marek Safar <marek.safar@gmail.com>
1249 * expression.cs: Fixed compound assignment explicit conversion.
1251 2009-09-17 Marek Safar <marek.safar@gmail.com>
1253 * expression.cs, ecore.cs: Cannot infer variables from method group.
1255 2009-09-16 Marek Safar <marek.safar@gmail.com>
1257 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
1258 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
1259 codegen.cs: Dynamic binary operations scaffolding.
1261 2009-09-15 Marek Safar <marek.safar@gmail.com>
1263 * expression.cs: Fixes nullable promotion for enum type variables.
1265 2009-09-11 Marek Safar <marek.safar@gmail.com>
1267 * driver.cs, dynamic.cs: Reset more static variables.
1269 2009-09-11 Marek Safar <marek.safar@gmail.com>
1271 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1272 driver.cs: Introduced Expression::MakeExpression.
1274 2009-09-11 Marek Safar <marek.safar@gmail.com>
1276 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1278 2009-09-09 Marek Safar <marek.safar@gmail.com>
1280 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1283 2009-09-09 Marek Safar <marek.safar@gmail.com>
1285 A fix for bug #518707
1286 * expression.cs (Is): Optimize only generic parameter type
1287 expression probing value type generic parameter.
1289 2009-09-09 Marek Safar <marek.safar@gmail.com>
1291 A fix for bug #532571
1292 * ecore.cs: Check for simple name type arguments used with
1295 2009-09-08 Marek Safar <marek.safar@gmail.com>
1297 A fix for bug #497421
1298 * generic.cs (CheckConstraint): Don't use buildin types to check for
1299 parameterless constructor.
1301 2009-09-08 Marek Safar <marek.safar@gmail.com>
1303 A fix for bug #537402
1304 * generic.cs (CheckConstraint): Correctly inflate generic type
1305 arguments when checking generic method.
1307 2009-09-08 Marek Safar <marek.safar@gmail.com>
1309 A fix for bug #536463
1310 * decl.cs (AddToContainer): Don't report collision between explicit
1311 and parameterless non-explicit members.
1313 2009-09-08 Marek Safar <marek.safar@gmail.com>
1315 * eval.cs: Reset more static stuff.
1317 2009-09-07 Marek Safar <marek.safar@gmail.com>
1319 A fix for bug #324625
1320 * expression.cs, ecore.cs: Create nested generic type expression
1321 using declaring and not current type.
1323 2009-09-07 Marek Safar <marek.safar@gmail.com>
1325 * *.cs: Changed Report class to accept various output printers and
1326 be an instance class. An expression resolver can now use different
1327 message reporter for each call and Report.Error can safely throw
1328 an exception. Part of ongoing work to turn mcs into proper library.
1330 2009-09-04 Marek Safar <marek.safar@gmail.com>
1332 * statement.cs, ecore.cs: Removed error reporting from emit code.
1334 2009-09-04 Marek Safar <marek.safar@gmail.com>
1336 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1338 2009-09-03 Marek Safar <marek.safar@gmail.com>
1340 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1341 parser checks out of constructors.
1343 2009-09-02 Marek Safar <marek.safar@gmail.com>
1345 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1347 2009-09-02 Marek Safar <marek.safar@gmail.com>
1349 A fix for bug #535448
1350 * anonymous.cs, class.cs: Copy return label between all contexts.
1352 2009-09-02 Marek Safar <marek.safar@gmail.com>
1354 A fix for bug #535395
1355 * namespace.cs: Resolve context can be null.
1357 2009-08-25 Marek Safar <marek.safar@gmail.com>
1359 A fix for bug #533912
1360 * generic.cs: Use correct context for constraints resolving.
1362 2009-08-25 Marek Safar <marek.safar@gmail.com>
1364 A fix for bug #532630
1365 * driver.cs: Trim conditional symbols.
1367 2009-08-25 Marek Safar <marek.safar@gmail.com>
1369 * context.cs: New file.
1371 * *.exe.sources, *.csproj: Updated.
1373 2009-08-25 Marek Safar <marek.safar@gmail.com>
1375 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1376 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1377 IMembercontext, some small cleanups.
1379 2009-08-24 Marek Safar <marek.safar@gmail.com>
1381 * *.cs: Split ResolveContext and EmitContext.
1383 2009-08-24 Marek Safar <marek.safar@gmail.com>
1385 * *.cs: Only ResolveContext implements IMemberContext.
1387 2009-08-21 Marek Safar <marek.safar@gmail.com>
1389 * *.cs: Renamed IResolveContext to IMemberContext.
1391 2009-08-21 Marek Safar <marek.safar@gmail.com>
1393 * *.cs: Detached ResolveContext from EmitContext.
1395 2009-08-21 Marek Safar <marek.safar@gmail.com>
1397 * codegen.cs: Moved flow-analysis to BlockContext.
1399 2009-08-21 Marek Safar <marek.safar@gmail.com>
1401 * *.cs: Detached BlockContext from EmitContext.
1403 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1405 * statement.cs: avoid nullref when the return value of GetEnumerator()
1406 does not contain any MoveNext() method.
1408 2009-08-19 Marek Safar <marek.safar@gmail.com>
1410 * *.cs: Removed IResolveContext::GenericDeclContainer.
1412 2009-08-19 Marek Safar <marek.safar@gmail.com>
1414 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1416 2009-08-19 Marek Safar <marek.safar@gmail.com>
1418 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1419 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1421 2009-08-18 Marek Safar <marek.safar@gmail.com>
1423 * *.cs: Removed boolean fields from EmitContext.
1425 2009-08-18 Marek Safar <marek.safar@gmail.com>
1427 * *.cs: Add IResolveContext::IsStatic.
1429 2009-08-18 Marek Safar <marek.safar@gmail.com>
1431 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1433 2009-08-17 Marek Safar <marek.safar@gmail.com>
1435 * *.cs: Removed DeclContainer from EmitContext.
1437 2009-08-17 Marek Safar <marek.safar@gmail.com>
1439 * *.cs: Add IResolveContext::CurrentTypeParameters.
1441 2009-08-14 Marek Safar <marek.safar@gmail.com>
1443 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1445 2009-08-14 Marek Safar <marek.safar@gmail.com>
1447 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1448 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1450 2009-08-13 Marek Safar <marek.safar@gmail.com>
1452 * decl.cs: Look in PartialContainer for parent type parameters.
1454 2009-08-13 Marek Safar <marek.safar@gmail.com>
1456 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1457 codegen.cs: Add IResolveContext::LookupTypeParameter.
1459 2009-08-13 Marek Safar <marek.safar@gmail.com>
1461 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1462 Moved resolved logic from Emit to Resolve.
1464 2009-08-13 Marek Safar <marek.safar@gmail.com>
1466 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1467 codegen.cs: Reworked atttributes handling of ResolveContext.
1469 2009-08-12 Marek Safar <marek.safar@gmail.com>
1471 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1472 LookupNamespaceOrType to ResolveContext.
1474 2009-08-12 Marek Safar <marek.safar@gmail.com>
1476 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1477 class.cs: Removed unused parameters and methods.
1479 2009-08-11 Marek Safar <marek.safar@gmail.com>
1481 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1482 codegen.cs: Finding the best common type of a set of expressions for
1485 2009-08-07 Marek Safar <marek.safar@gmail.com>
1487 * dynamic.cs, expression.cs: More dynamic conversions.
1489 2009-08-06 Miguel de Icaza <miguel@novell.com>
1491 * generic.cs: This loop was incorrect, it was increment ii, but
1492 checking for `i'. This was a change introduced to fix #327497,
1495 * class.cs: Catch another case for cs0533 error, fixes #324782.
1497 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1499 * typemanager.cs (GetGenericArguments): SRE returns null for
1500 generic methods on type builder instances if they are not generic
1501 themselves. For example, for Foo<int>::Bar() it returns null, but
1502 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1504 2009-08-05 Marek Safar <marek.safar@gmail.com>
1506 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1507 delegate.cs: Work on dynamic binding.
1509 2009-08-04 Marek Safar <marek.safar@gmail.com>
1511 A second fix for bug #525342
1512 * class.cs: Attach partial method attributes to method
1515 2009-08-03 Marek Safar <marek.safar@gmail.com>
1517 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1520 * rootcontext.cs: Default to langversion v4.
1522 2009-08-03 Marek Safar <marek.safar@gmail.com>
1524 * pending.cs: Check return type before member info is set.
1526 2009-08-03 Marek Safar <marek.safar@gmail.com>
1528 * anonymous.cs: Fully initialize generic hoisted field expression.
1530 2009-08-02 Miguel de Icaza <miguel@novell.com>
1532 * cs-parser.jay: Flag variables declared on the interactive shell
1533 as used to prevent the 168 warning about local variable not being
1536 2009-07-31 Marek Safar <marek.safar@gmail.com>
1538 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1539 attribute.cs: Emit dynamic export attribute.
1541 2009-07-30 Marek Safar <marek.safar@gmail.com>
1543 * expression.cs: More verifier work.
1545 2009-07-29 Marek Safar <marek.safar@gmail.com>
1547 * nullable.cs: Fixed SRE crash during corlib compilation.
1549 2009-07-29 Marek Safar <marek.safar@gmail.com>
1551 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1552 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1553 More TypeManager.TypeToCoreType needed.
1555 2009-07-29 Marek Safar <marek.safar@gmail.com>
1557 * anonymous.cs: Update after recent SRE fixes.
1559 2009-07-28 Marek Safar <marek.safar@gmail.com>
1561 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1562 version of GetFieldHandle for fields of generic types.
1564 2009-07-27 Marek Safar <marek.safar@gmail.com>
1566 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1567 ecore.cs: Add TypeManager.IsDynamicType,
1568 PredefinedAttributes.Dynamic.
1570 2009-07-27 Marek Safar <marek.safar@gmail.com>
1572 A fix for bug #415375
1573 * expression.cs: Fixed object and reference type parameter
1576 2009-07-27 Marek Safar <marek.safar@gmail.com>
1578 A fix for bug #525342
1579 * class.cs: Attach partial method attributes to method
1582 2009-07-24 Marek Safar <marek.safar@gmail.com>
1584 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1587 2009-07-24 Marek Safar <marek.safar@gmail.com>
1589 * anonymous.cs (MutateField): Add imported types handling.
1591 2009-07-23 Marek Safar <marek.safar@gmail.com>
1593 * expression.cs, delegate.cs: Moved arguments resolve into their
1594 counterparts expressions. Removed argument resolve from
1595 CollectionElementInitializer.
1597 2009-07-23 Marek Safar <marek.safar@gmail.com>
1599 A fix for bug #523683
1600 * convert.cs, delegate.cs: Use common overload mechanism for method
1601 group conversion check.
1603 2009-07-22 Marek Safar <marek.safar@gmail.com>
1605 A fix for bug #523899
1606 * generics.cs: Exact type inference with other bound types.
1608 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1610 Don't complain when the same type is implemented by the output
1611 assembly as well as multiple referenced assemblies
1612 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1613 'must_be_unique' flag.
1614 (GlobalRootNamespace): Update to changes.
1615 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1616 already have a type in hand.
1618 2009-07-22 Marek Safar <marek.safar@gmail.com>
1620 * expression.cs: More verifier instrumentation.
1622 * statement.cs: Do proper throw expression conversion.
1624 2009-07-22 Marek Safar <marek.safar@gmail.com>
1626 A fix for bug #522789
1627 * expression.cs: Mutate invocation return type.
1629 2009-07-16 Marek Safar <marek.safar@gmail.com>
1631 * anonymous.cs: Split assignable and readonly generated variable
1634 2009-07-16 Marek Safar <marek.safar@gmail.com>
1636 A fix for bug #521671
1637 * statement.cs: Fixed crash when checking missing type.
1639 2009-07-16 Marek Safar <marek.safar@gmail.com>
1641 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1642 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1643 class.cs, driver.cs: Work on dynamic binding.
1645 * dynamic.cs: New file.
1647 * *.sources, *.proj: Updated.
1649 2009-07-15 Marek Safar <marek.safar@gmail.com>
1651 * expression.cs (Conditional): Avoid double Resolve.
1653 2009-07-13 Marcus Griep <marcus@griep.us>
1655 * ecore.cs: Fix obscure bug with resolving members of interfaces
1656 that hide parent interface members. Fixes bug #444388 and corrects
1659 2009-07-13 Marek Safar <marek.safar@gmail.com>
1661 * expression.cs (LocalVariableReference): Bounce resolve.
1663 2009-07-10 Marek Safar <marek.safar@gmail.com>
1665 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1666 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1669 * support.cs: New dynamic type wrapper.
1671 2009-07-08 Marek Safar <marek.safar@gmail.com>
1673 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1674 typed local variable.
1676 2009-07-06 Marek Safar <marek.safar@gmail.com>
1678 A fix for bug #519005
1679 * anonymous.cs: Use null_type as no return type placeholder.
1681 2009-07-02 Marek Safar <marek.safar@gmail.com>
1683 * generic.cs: Handle type inference of identical type parameters
1684 with different bounds.
1686 2009-07-01 Marek Safar <marek.safar@gmail.com>
1688 * expression.cs, class.cs: Events variance.
1690 * cs-parser.jay: Interface events error messages.
1692 2009-07-01 Marek Safar <marek.safar@gmail.com>
1694 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1696 2009-06-29 Marek Safar <marek.safar@gmail.com>
1698 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1699 parameter expression can be value-type New.
1701 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1703 2009-06-26 Marek Safar <marek.safar@gmail.com>
1705 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1706 Implemented C# 4.0 named arguments.
1708 2009-06-24 Marek Safar <marek.safar@gmail.com>
1710 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1711 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1712 parameter modifier. Also fixes bug #515497.
1714 2009-06-24 Marek Safar <marek.safar@gmail.com>
1716 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1717 arguments expression to be implemented.
1719 *.sources: Add argument.cs
1721 2009-06-23 Marek Safar <marek.safar@gmail.com>
1723 * parameter.cs: Moved GetParameterIndexByName to base class.
1725 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1726 unused AType. Use argument's version of GetExpressionTree.
1728 2009-06-22 Marek Safar <marek.safar@gmail.com>
1730 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1733 2009-06-17 Marek Safar <marek.safar@gmail.com>
1735 A fix for bug #514096
1736 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1738 2009-06-17 Marek Safar <marek.safar@gmail.com>
1740 * expression.cs: The first multi-dimensional array nested array
1741 initializers was not checked.
1743 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1745 2009-06-17 Marek Safar <marek.safar@gmail.com>
1747 A fix for bug #513400
1748 * nullable.cs (EmitEquality): Operands emit could be simplified for
1749 built-in types when we now emit user operators differently.
1751 2009-06-16 Marek Safar <marek.safar@gmail.com>
1753 * ecore.cs: Report inaccessible delegate methods correctly.
1755 2009-06-16 Marek Safar <marek.safar@gmail.com>
1757 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1758 cs-parser.jay: Implemented C# 4.0 optional parameters.
1760 2009-06-16 Marek Safar <marek.safar@gmail.com>
1762 * driver.cs: Removed broken DefineManifestResource.
1764 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1766 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1767 Use $(BOOTSTRAP_PROFILE) instead.
1769 2009-06-12 Jb Evain <jbevain@novell.com>
1771 * rootcontext.cs: add a Platform field.
1772 * driver.cs: handle /platform.
1773 * codegen.cs: pass the proper flags according to
1774 the platform when saving the assembly.
1776 2009-06-11 Marek Safar <marek.safar@gmail.com>
1778 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1779 Add optional parameters grammar.
1781 2009-06-10 Marek Safar <marek.safar@gmail.com>
1783 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1784 driver.cs: Split lang version and metadata version.
1786 2009-06-10 Marek Safar <marek.safar@gmail.com>
1788 * decl.cs: Better overload ctor collision error message.
1790 2009-06-05 Jb Evain <jbevain@novell.com>
1792 * driver.cs (EmbededResource): avoid using an internal method
1793 in gmcs to embed manifest resources.
1795 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1797 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1798 the compiler from older mono versions (like moon's bots)
1800 2009-06-04 Marek Safar <marek.safar@gmail.com>
1802 * namespace.cs (LookupTypeReflection): Ignore collisions between
1805 2009-06-04 Marek Safar <marek.safar@gmail.com>
1807 * codegen.cs: Enabled generic type forwarders.
1809 2009-06-04 Marek Safar <marek.safar@gmail.com>
1811 * dmcs.*: Add another version of SRE compiler.
1813 2009-06-03 Marek Safar <marek.safar@gmail.com>
1815 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1816 generic-mcs.cs: Fixed variant type conversions.
1818 2009-06-02 Marek Safar <marek.safar@gmail.com>
1820 A fix for bug #507863
1821 * codegen.cs: Fixes a crash on invalid string value attribute.
1823 2009-06-01 Marek Safar <marek.safar@gmail.com>
1825 A fix for bug #508334
1826 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1827 cs-parser.jay: Fully import __arglist modifier.
1829 2009-05-29 Marek Safar <marek.safar@gmail.com>
1831 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1832 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1833 actually work with closed generic types.
1835 2009-05-27 Alan McGovern <amcgovern@novell.com>
1837 * class.cs, decl.cs, delegate.cs, parameter.cs:
1838 Fix the build by replacing the use of 'var' with the actual type.
1840 2009-05-27 Marek Safar <marek.safar@gmail.com>
1842 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1843 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1846 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1849 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1850 Marek Safar <marek.safar@gmail.com>
1852 A fix for bug #377509
1853 * parameter.cs: Use predefined and not empty name for implicit
1856 2009-05-21 Marek Safar <marek.safar@gmail.com>
1858 * class.cs: Don't report wrong warnings for event fields.
1860 2009-05-21 Marek Safar <marek.safar@gmail.com>
1862 A fix for bug #504667
1863 * class.cs: Check for static class using parent container instead of
1866 2009-05-08 Marek Safar <marek.safar@gmail.com>
1868 A fix for bug #496922
1869 * expression.cs: Always use temporary variable when using object
1872 2009-04-28 Marek Safar <marek.safar@gmail.com>
1874 A fix for bug #495112
1875 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1878 2009-04-27 Miguel de Icaza <miguel@novell.com>
1880 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1882 2009-04-24 Miguel de Icaza <miguel@novell.com>
1884 * complete.cs: No idea how gonzalo got a null in the list, but
1887 2009-04-24 Miguel de Icaza <miguel@novell.com>
1889 * complete.cs (CompletionElementInitializer): New completion class
1890 to support completing inside a C# 3 element initializer, so this
1891 allows completion for Silverlight situations where it is very
1894 new TextBlock () { Fo<TAB>
1896 (CompletionSimpleName): Expose the prefix that was
1897 passed to the simple name.
1899 * cs-parser.jay (object_or_collection_initializer): Add support
1900 for element_initializers.
1902 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1903 special case completion expressions as this method aggressively
1904 collects data before it operates, and errors were being thrown
1905 earlier than we were able to complete.
1907 2009-04-23 Miguel de Icaza <miguel@novell.com>
1909 * eval.cs: Make getcompletions silent and enable debugging output
1910 if the -v option is passed.
1912 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1913 Consider looking up the namespace that matches the prefix being
1916 This is part of the support for allowing completions like:
1917 `System.Co<TAB>' to complete to System.Console.
1919 * complete.cs (CompletionSimpleName.AppendResults): Make this
1922 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1924 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1925 COMPLETE_COMPLETION as internal.
1927 2009-04-17 Miguel de Icaza <miguel@novell.com>
1929 * complete.cs: Include namespace resolution in simple names as
1930 well as global types and types in the using scope in the
1933 * namespace.cs: Supporting infrastrcture to provide completions
1934 based on the current using scope.
1936 * eval.cs: Introduce an entry point that allows for initialization
1937 to return a list of the files passed on the command line.
1939 2009-04-14 Marek Safar <marek.safar@gmail.com>
1941 A fix for bug #494243
1942 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1944 2009-04-13 Marek Safar <marek.safar@gmail.com>
1946 A fix for bug #493887
1947 * statement.cs: Don't skip string multi-section with default or
1948 null label when populating string hashtable.
1950 2009-04-06 Marek Safar <marek.safar@gmail.com>
1952 A fix for bug #492329
1953 * expression.cs (New): Load variable when assigning type parameter
1956 2009-04-06 Marek Safar <marek.safar@gmail.com>
1958 A fix for bug #488960
1959 * decl.cs: Compare MVAR types using non-null values.
1961 2009-03-27 Marek Safar <marek.safar@gmail.com>
1963 * typemanager.cs, expression.cs: Removed unused nullable checks.
1965 2009-03-27 Marek Safar <marek.safar@gmail.com>
1967 * *.cs: Removed some gmcs conditionals.
1969 2009-03-26 Marek Safar <marek.safar@gmail.com>
1971 * generic.cs, support.cs: Moved generics stuff out of support.cs
1973 2009-03-24 Marek Safar <marek.safar@gmail.com>
1975 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1978 2009-03-23 Marek Safar <marek.safar@gmail.com>
1980 * attribute.cs: Consider all members for error reporting when
1981 checking named arguments.
1983 2009-03-23 Marek Safar <marek.safar@gmail.com>
1985 A fix for bug #487625
1986 * namespace.cs: Use a warning for all predefined type conflicts.
1988 2009-03-23 Marek Safar <marek.safar@gmail.com>
1990 A fix for bug #485706
1991 * statement.cs: Explicitly type catch type argument to pass verifier
1994 2009-03-22 Miguel de Icaza <miguel@novell.com>
1996 Initial support to provide code completion facilities to consumers
1997 of the evaluator API.
1999 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
2000 support the completion engine. When we reach the end of the
2001 input stream instead of returning EOF, when this flag is true the
2002 tokenizer instead produces:
2004 One GENERATE_COMPLETION token: this token then must be
2005 handled in the grammar at every point where the user
2006 would likely request a completion.
2008 As many COMPLETE_COMPLETION tokens as necessary. These
2009 tokens are generated to assist the parser in unwinding and
2010 producing a valid parse tree.
2012 The parser rules do not have to be perfect, the parser needs to be
2013 augmented with judicious use of GENERATE_COMPLETION tokens to
2014 improve the areas where we can provide completion and the parser
2015 needs to add support for COMPLETE_COMPLETION tokens in productions
2018 It is common to not have enough support for COMPLETE_COMPLETION
2019 under certain rules and that even if we generated the
2020 GENERATE_COMPLETION token that the resulting tree will be invalid
2021 due to the missing rules that support COMPLETE_COMPLETION.
2023 The final EOF token is produced by having the parser notify the
2024 tokenizer when it reaches the root production that the next token
2027 * support.cs (CompletionResult): New Exception. This exception
2028 is thrown to return the completion results when one of the special
2029 completion expressions is reached.
2031 This exception is thrown by the completing ExpressionStatements
2032 classes that live in complete.cs
2034 * complete.cs (CompletingExpression): a new base class for
2035 completing expressions. This derives from the
2036 ExpressionStatement class and not from Expression as it allows
2037 completion to happen not only where expressions are expected in
2038 the grammar, but also where statements are expected.
2040 (CompletionSimpleName): A new class used to provide completions
2041 for SimpleNames. This currently only resolves to local
2042 variables from the evaluator context (GetVars call).
2044 (CompletionMemberAccess): Implements support for completing member
2047 * cs-parser.jay: Add support for completion in a few places.
2049 * eval.cs (GetCompletions): New public API for the evaluator that
2050 returns a list of possible completions given the input. The
2051 return value is an array of completions
2053 * anonymous.cs (Compatible): If the exception thrown from the
2054 resolved expression is a CompletionResult exception let that one
2055 through instead of printing a diagnostic error in the try/catch.
2057 2009-03-22 Miguel de Icaza <miguel@novell.com>
2061 * driver.cs (Main): Use Environment.Exit to quit quickly and
2062 prevent the compiler from doing the usual wait for helper thread
2065 This is to prevent a slowdown that was reported by Gonzalo on
2068 2009-03-19 Marek Safar <marek.safar@gmail.com>
2070 * ecore.cs: Load build-in types directly instead of accessing
2073 2009-03-18 Marek Safar <marek.safar@gmail.com>
2075 * ecore.cs: Always use unbox.any when available.
2077 2009-03-18 Marek Safar <marek.safar@gmail.com>
2079 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
2081 2009-03-17 Marek Safar <marek.safar@gmail.com>
2083 * generic.cs: Removed obsolete version of type inference.
2085 2009-03-16 Marek Safar <marek.safar@gmail.com>
2087 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
2088 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
2089 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
2090 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
2092 2009-03-11 Marek Safar <marek.safar@gmail.com>
2094 A fix for bug #482996
2095 * anonymous.cs: Make sure we are not infering return type when
2096 checking type compatibility.
2098 2009-03-11 Marek Safar <marek.safar@gmail.com>
2100 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
2101 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
2102 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
2103 attributes in their own structure. Needed when accessing their
2104 properties before they are resolved.
2106 2009-03-09 Marek Safar <marek.safar@gmail.com>
2108 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
2109 hashtable (~10x faster).
2111 * driver.cs: Removed wrong Reset.
2113 2009-03-08 Marek Safar <marek.safar@gmail.com>
2115 * class.cs: Use correct common base type for unmanaged delayed
2118 * rootcontext.cs: Wrap unhandled exception.
2120 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
2122 Make SeekableStreamReader self-tuning and arbitrarily seekable
2123 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
2125 (SeekableStreamReader.Position.set): Use it. Simplify logic
2126 which, as a side-effect, makes it arbitrarily-seekable. Tune the
2127 buffer size when the stream needs to be re-read from the beginning.
2129 2009-03-05 Marek Safar <marek.safar@gmail.com>
2131 A fix for bug #480100
2132 * parameter.cs: A parameter is not hoisted when used directly as ET.
2134 2009-03-04 Marek Safar <marek.safar@gmail.com>
2136 * statement.cs: Fixed an issue when using variable is of interface
2139 2009-03-03 Marek Safar <marek.safar@gmail.com>
2141 A fix for bug #480319
2142 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
2144 2009-03-03 Marek Safar <marek.safar@gmail.com>
2146 A fix for bug #480867
2147 * typemanager.cs, expression.cs, ecore.cs: Changed method group
2148 expression to have no valid type.
2150 2009-03-03 Marek Safar <marek.safar@gmail.com>
2152 A fix for bug #481258
2153 * class.cs: Set extension method flag in partial container.
2155 2009-03-03 Marek Safar <marek.safar@gmail.com>
2157 * statement.cs, typemanager.cs: Use expression for StringEmitter.
2159 * attribute.cs: Add sanity check.
2161 2009-02-27 Marek Safar <marek.safar@gmail.com>
2163 * class.cs: Add external constructor error.
2165 2009-02-26 Marek Safar <marek.safar@gmail.com>
2167 A fix for bug #475354
2168 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
2169 correctly user defined nullable equality operators.
2171 2009-02-25 Marek Safar <marek.safar@gmail.com>
2173 A fix for bug #479532
2174 * expression.cs: Implement NewInitialize::AddressOf.
2176 2009-02-25 Marek Safar <marek.safar@gmail.com>
2178 A fix for bug #413633
2179 * expression.cs: Iterate all base class-constraint types.
2181 2009-02-24 Marek Safar <marek.safar@gmail.com>
2183 A fix for bug #479209
2184 * literal.cs: Mutate null underlying type.
2186 2009-02-24 Marek Safar <marek.safar@gmail.com>
2188 A fix for bug #476295
2189 * convert.cs: Avoid wrapping implicitly convertible reference type.
2191 2009-02-23 Marek Safar <marek.safar@gmail.com>
2193 * iterators.cs: Create MemberName correctly.
2195 2009-02-23 Marek Safar <marek.safar@gmail.com>
2197 A fix for bug #478655
2198 * literal.cs: Check also underlying null type conversion.
2200 2009-02-21 Marek Safar <marek.safar@gmail.com>
2202 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
2204 2009-02-20 Marek Safar <marek.safar@gmail.com>
2206 A fix for bug #477447
2207 * statement.cs: Add reference to correct parent storey when this
2208 is accessible from deep children storey (more than 1 level).
2210 2009-02-19 Marek Safar <marek.safar@gmail.com>
2212 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
2213 * class.cs: Define base type members before setting up member cache.
2215 2009-02-18 Marek Safar <marek.safar@gmail.com>
2217 A fix for bug #477378
2218 * nullable.cs, expression.cs, statement.cs: More precise null type
2221 2009-02-18 Marek Safar <marek.safar@gmail.com>
2223 A fix for bug #472805
2224 * typemanager.cs, namespace.cs: Import only visible extension method
2227 2009-02-18 Marek Safar <marek.safar@gmail.com>
2229 A fix for bug #476895
2230 * attribute.cs: Use correct resolve context for attribute type.
2232 2009-02-18 Marek Safar <marek.safar@gmail.com>
2234 A fix for bug #476266
2235 * anonymous.cs: Mutate multi-dimensional arrays.
2237 2009-02-18 Marek Safar <marek.safar@gmail.com>
2239 A fix for bug #476400
2240 * statement.cs, expression.cs: Removed wrong Dispose optimization.
2242 2009-02-18 Marek Safar <marek.safar@gmail.com>
2244 A fix for bug #476811
2245 * generics.cs: Fixed null-literal check.
2247 2009-02-17 Marek Safar <marek.safar@gmail.com>
2249 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
2250 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
2251 messing with static variables.
2253 2009-02-16 Marek Safar <marek.safar@gmail.com>
2255 A fix for bug #475965
2256 * generics.cs: Check generic parameter type after extracting from
2259 2009-02-16 Marek Safar <marek.safar@gmail.com>
2261 A fix for bug #475823
2262 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
2265 2009-02-14 Marek Safar <marek.safar@gmail.com>
2267 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
2268 Simplified event field definition using backing field and not
2269 field builder directly.
2271 * expression.cs (EmitLdArg): Optimize fast paths.
2273 2009-02-13 Marek Safar <marek.safar@gmail.com>
2275 A fix for bug #475327
2276 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2278 2009-02-13 Marek Safar <marek.safar@gmail.com>
2280 A fix for bug #475342
2281 * cs-parser.jay: Using 'super' instead of 'base' to call base
2282 constructor crashes compiler.
2284 2009-02-13 Marek Safar <marek.safar@gmail.com>
2286 A fix for bug #475354
2287 * expression.cs (Constantify): Add nullable types.
2289 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2291 2009-02-12 Marek Safar <marek.safar@gmail.com>
2293 A fix for bug #475246
2294 * expression.cs: More broken flowanalysis hacking needed.
2296 2009-02-12 Marek Safar <marek.safar@gmail.com>
2298 * attribute.cs: Compare only ref/out array modifiers.
2300 2009-02-11 Marek Safar <marek.safar@gmail.com>
2302 * statement.cs: Use member cache when looking for foreach members.
2304 2009-02-11 Marek Safar <marek.safar@gmail.com>
2306 * expression.cs: Don't expose internal initializer types.
2308 * statement.cs: Check also explicit conversions for goto case.
2310 2009-02-11 Marek Safar <marek.safar@gmail.com>
2312 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2314 2009-02-10 Marek Safar <marek.safar@gmail.com>
2316 * *.cs: Replace null-type with NullLiteral where appropriate.
2318 2009-02-09 Marek Safar <marek.safar@gmail.com>
2320 * expression.cs: Initializer of reference argument use temporary
2321 variable to be verifiable.
2323 * parameter.cs: Share EmitLdArg.
2325 2009-02-09 Marek Safar <marek.safar@gmail.com>
2327 A fix for bug #473559
2328 * class.cs: Fixed: Not reporting error about nested class with the
2331 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2333 Contributed under the MIT/X11 license.
2335 * generic.cs: Added VerifyVariantTypeParameters which performs new
2336 variance verification logic. The old logic, based on the spec, was
2337 wrong because the spec is full of LIES!
2339 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2341 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2344 * ecore.cs: Added calls to the new variance verification logic.
2347 * delegate.cs: Removed calls to the old variance verification logic.
2349 2009-02-06 Marek Safar <marek.safar@gmail.com>
2351 * delegate.cs: Use cached Invoke method directly.
2353 2009-02-06 Marek Safar <marek.safar@gmail.com>
2355 * expression.cs: Emit expression tree for hoisted variable access.
2357 2009-02-04 Marek Safar <marek.safar@gmail.com>
2359 * namespace.cs: Add better extension class check.
2361 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2363 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2365 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2367 This patch adds initial generic variance support to the compiler.
2368 It is contributed under the MIT/X11 license.
2370 * typemanager.cs: Modified ImplementsInterface to check variance.
2371 Added VerifyVariantTypeParameters which checks the specified type to see
2372 if it uses a variant type parameter as a type argument (which is not
2373 allowed). Added IsVariantOf which determins if the first type is a
2374 variant of the second. NOTE: This only supports reference types at
2375 the moment to conform with the current level of VM support. When the
2376 VM supports value types, this will follow step.
2378 * generic.cs: Added the Variance enum. Added a Variance property to
2379 TypeParameter and added variance support to definition phase. Added a
2380 Variance property to TypeParameterName. Also check to make sure that
2381 no variant types appear in generic method parameters.
2383 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2384 keywords if the langversion supports it.
2386 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2387 that variant types are only used in legal positions. Also added
2388 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2391 * decl.cs: Construct TypeParameter with the variance information.
2393 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2394 and ImplicitConversionStandard.
2396 * rootcontext.cs: Added new "Future" language version.
2398 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2399 type parameters are not used as type arguments in interface inheritance.
2400 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2401 parameters are not used as method return types. In MemberBase.
2402 ResolveMemberType, ensure that variant type parameters are not used
2403 as type arguments. Also call VerifyNoVariantTypeParameters on every
2404 set of parameters which are resolved.
2406 * delegate.cs: Modified Delegate.Define to ensure that variant
2407 parameters are not used as type arguments and that a contravariant
2408 parameter is not used as the return type. Also call
2409 VerifyNoVariantTypeParameters on the delegate parameters.
2411 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2412 to specify generic variance.
2414 * driver.cs: Added support for LanguageVersion.Future in the form of
2415 "-langversion:future".
2417 * generic-mcs.cs: Stubbed out new members in generic.cs.
2419 2009-02-03 Marek Safar <marek.safar@gmail.com>
2421 * class.cs, generic.cs: Emit type parameter constraints for nested
2424 2009-02-02 Marek Safar <marek.safar@gmail.com>
2426 A fix for bug #471213
2427 * class.cs: Avoid emitting backing field for abstract event fields.
2429 2009-02-01 Marek Safar <marek.safar@gmail.com>
2431 A fix for bug #359731
2432 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2435 2009-01-30 Marek Safar <marek.safar@gmail.com>
2437 A fix for bug #470767
2438 * statement.cs: Introduced BlockScopeExpression, needed when
2439 expression tree conversion has to emit scope variables.
2441 2009-01-29 Marek Safar <marek.safar@gmail.com>
2443 * class.cs: Remove duplicate CallingConvention.
2445 2009-01-29 Marek Safar <marek.safar@gmail.com>
2447 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2448 when I finally found the right naming convention.
2450 2009-01-29 Marek Safar <marek.safar@gmail.com>
2452 * cs-tokenizer.cs: Put back different open parens optimization.
2454 2009-01-28 Marek Safar <marek.safar@gmail.com>
2456 A fix for bug #470227
2457 * cs-tokenizer.cs: Remove too agressive parser optimization.
2459 2009-01-28 Marek Safar <marek.safar@gmail.com>
2461 A fix for bug #324319
2462 * class.cs: Remove too early base type resolve.
2464 2009-01-27 Marek Safar <marek.safar@gmail.com>
2466 A fix for bug #324319
2467 * ecore.cs: Explicitly type null when assigning to type argument to
2468 make pass verifier check.
2470 2009-01-27 Marek Safar <marek.safar@gmail.com>
2472 * anonymous.cs: Fixed recent regression when initializing captured
2475 2009-01-26 Marek Safar <marek.safar@gmail.com>
2477 A fix for bug #469019
2478 * anonymous.cs: Use all parent type parameters when instantiating
2479 nested generic storey.
2481 2009-01-26 Marek Safar <marek.safar@gmail.com>
2483 * expression.cs: Check for null instance methodgroup expression.
2485 2009-01-26 Marek Safar <marek.safar@gmail.com>
2487 A fix for bug #469244
2488 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2489 instance inside a conditional expression.
2491 2009-01-23 Marek Safar <marek.safar@gmail.com>
2493 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2494 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2495 GetElementType and HasElementType. IsValueType clean up.
2497 2009-01-23 Marek Safar <marek.safar@gmail.com>
2499 * nullable.cs: Use common EmitCall.
2501 * expression.cs: Emit constraint. for virtual calls only.
2503 2009-01-23 Marek Safar <marek.safar@gmail.com>
2505 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2506 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2507 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2510 2009-01-22 Jb Evain <jbevain@novell.com>
2512 * anonymous.cs: make anonymous types' ToString implementation
2513 match what csc outputs.
2515 2009-01-21 Marek Safar <marek.safar@gmail.com>
2517 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2520 2009-01-17 Marek Safar <marek.safar@gmail.com>
2522 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2525 2009-01-16 Marek Safar <marek.safar@gmail.com>
2527 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2530 2009-01-15 Marek Safar <marek.safar@gmail.com>
2532 A fix for bug #466634
2533 * statement.cs: Add reference for nested storey when only this
2536 2009-01-15 Marek Safar <marek.safar@gmail.com>
2538 A fix for bug #466474
2539 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2542 2009-01-15 Marek Safar <marek.safar@gmail.com>
2544 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2545 Fixed nested stories parent referencing process. Also fixes #463985.
2547 2009-01-06 Marek Safar <marek.safar@gmail.com>
2549 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2550 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2551 implementation. Also fixes #463108.
2553 2009-01-05 Marek Safar <marek.safar@gmail.com>
2555 A fix for bug #416109
2556 * decl.cs: Issue correct CLSAttribute warning location.
2558 2009-01-05 Marek Safar <marek.safar@gmail.com>
2560 A fix for bug #456775
2561 * attribute.cs: Use attribute owner scope when resolving attribute
2564 2009-01-05 Marek Safar <marek.safar@gmail.com>
2566 A fix for bug #457257
2567 * decl.cs: Fixed incorrect member declaring type comparison.
2569 2009-01-05 Marek Safar <marek.safar@gmail.com>
2571 A fix for bug #460896
2572 * driver.cs: Handle /RES resources as embeddable.
2574 2009-01-05 Marek Safar <marek.safar@gmail.com>
2576 A fix for bug #462515
2577 * ecore.cs: Report inacessible members upwards.
2579 2009-01-05 Marek Safar <marek.safar@gmail.com>
2581 A fix for bug #463190, #463192
2582 * decl.cs, namespace.cs: Also import internal extension classes.
2584 2009-01-04 Marek Safar <marek.safar@gmail.com>
2586 A fix for bug #463415
2587 * generic.cs: Use right index for RemoveDependentTypes.
2589 2009-01-02 Marek Safar <marek.safar@gmail.com>
2591 A fix for bug #463196
2592 * expression.cs: Fixed enum to null comparison.
2594 2009-01-02 Marek Safar <marek.safar@gmail.com>
2596 A fix for bug #463121
2597 * nullable.cs: Fixed nullable user equality operator comparison.
2599 2009-01-02 Marek Safar <marek.safar@gmail.com>
2601 A fix for bug #462950
2602 * class.cs, decl.cs: Use full explicit name when defining automatic
2603 property backing field.
2605 2009-01-02 Marek Safar <marek.safar@gmail.com>
2607 A fix for bug #462592
2608 * pending.cs: Emit type arguments for generic proxy method.
2610 2008-12-30 Marek Safar <marek.safar@gmail.com>
2612 * expression.cs (As): Mutate all type arguments.
2614 2008-12-29 Marek Safar <marek.safar@gmail.com>
2616 A fix for bug #462622
2617 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2620 2008-12-29 Marek Safar <marek.safar@gmail.com>
2622 A fix for bug #450782
2623 * ecore.cs: Consider more variables of form V.I to be fixed.
2625 2008-12-29 Marek Safar <marek.safar@gmail.com>
2627 A fix for bug #460712
2628 * typemanager.cs: Core types could be imported.
2630 2008-12-28 Marek Safar <marek.safar@gmail.com>
2632 A fix for bugs #460847, #460772, #458049, #457339, #447807
2633 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2634 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2635 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2636 user lambdas used inside query clauses.
2638 2008-12-18 Marek Safar <marek.safar@gmail.com>
2640 A fix for bug #460229
2641 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2643 2008-12-18 Marek Safar <marek.safar@gmail.com>
2645 A fix for bug #459952
2646 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2648 2008-12-18 Marek Safar <marek.safar@gmail.com>
2650 A fix for bug #459630
2651 * convert.cs: Enum to valuetype conversion is not allowed.
2653 2008-12-18 Marek Safar <marek.safar@gmail.com>
2655 A fix for bug #457087
2656 * generic.cs: Don't crash when constraint comes from type
2659 2008-12-16 Marek Safar <marek.safar@gmail.com>
2661 A fix for bug #459221
2662 * anonymous.cs, statement.cs: Delay only captured this
2665 2008-12-12 Marek Safar <marek.safar@gmail.com>
2667 A fix for bug #457489
2668 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2669 and initialization to capture scope initializers correctly.
2671 2008-12-11 Marek Safar <marek.safar@gmail.com>
2673 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2674 ParameterReference refactoring.
2676 2008-12-03 Marek Safar <marek.safar@gmail.com>
2678 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2679 to be imported from any assembly.
2681 2008-12-03 Marek Safar <marek.safar@gmail.com>
2683 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2684 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2685 from anonymous method and lambda expression.
2687 2008-12-01 Marek Safar <marek.safar@gmail.com>
2689 A fix for bug #448560
2690 * expression.cs (As): Box any generic type arguments to be
2693 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2695 Add tripwire for implicit conversion bugs
2696 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2698 (MethodGroupExpr.OverloadResolve): Add sanity check between
2699 IsApplicable and VerifyArgumentsCompat.
2700 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2702 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2704 Fix build break in System.Data_test
2705 * convert.cs (ImplicitConversionExists): Move NullLiteral
2707 (ImplicitStandardConversionExists): ... here.
2709 2008-11-28 Marek Safar <marek.safar@gmail.com>
2711 * literal.cs: Emit correctly explicit null to nullable cast.
2713 2008-11-28 Marek Safar <marek.safar@gmail.com>
2715 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2718 2008-11-28 Marek Safar <marek.safar@gmail.com>
2720 A fix for bug #449005
2721 * convert.cs, nullable.cs: Use only one implicit nullable
2724 2008-11-27 Marek Safar <marek.safar@gmail.com>
2726 * convert.cs, literal.cs: More Convert cleanup is needed.
2728 2008-11-27 Marek Safar <marek.safar@gmail.com>
2730 * decl.cs, class.cs: Fixed misleading error message.
2732 2008-11-26 Marek Safar <marek.safar@gmail.com>
2734 A fix for bug #449005
2735 * nullable.cs (EmitEquality): Disable optimization for user operator
2738 2008-11-25 Marek Safar <marek.safar@gmail.com>
2740 A fix for bug #447027
2741 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2742 with context variables stored as expression instances.
2744 2008-11-25 Marek Safar <marek.safar@gmail.com>
2746 A fix for bug #447027
2747 * delegate.cs: Fixed delegate VerifyMethod logic.
2749 2008-11-24 Marek Safar <marek.safar@gmail.com>
2751 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2754 2008-11-21 Marek Safar <marek.safar@gmail.com>
2756 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2757 member type resolve to follow normal flow, instead of random
2760 2008-11-21 Marek Safar <marek.safar@gmail.com>
2762 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2765 2008-11-21 Marek Safar <marek.safar@gmail.com>
2767 * const.cs: Emit decimal array constant as literal.
2769 2008-11-20 Marek Safar <marek.safar@gmail.com>
2771 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2773 2008-11-19 Marek Safar <marek.safar@gmail.com>
2775 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2776 into real property (saves 8 MB for corlib compilation).
2778 2008-11-19 Marek Safar <marek.safar@gmail.com>
2780 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2781 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2782 generic-mcs.cs: Small cleanup of TypeArguments.
2784 2008-11-18 Marek Safar <marek.safar@gmail.com>
2786 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2787 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2788 of ConstructedType expression, renamed to GenericTypeExpr.
2790 2008-11-17 Marek Safar <marek.safar@gmail.com>
2792 A fix for bug #445303
2793 * location.cs (IsConditionalDefined): Handle undefined global
2796 2008-11-17 Marek Safar <marek.safar@gmail.com>
2798 A fix for bug #444678
2799 * expression.cs (TryReduceConstant): Always create new constant
2802 2008-11-17 Marek Safar <marek.safar@gmail.com>
2804 A fix for bug #444673
2805 * ecore.cs: Ignore open generic types when used as generic type
2808 2008-11-17 Marek Safar <marek.safar@gmail.com>
2810 A fix for bug #445458
2811 * expression.cs, cs-parser.jay: Don't crash when an expression
2814 2008-11-17 Marek Safar <marek.safar@gmail.com>
2816 A fix for bug #445464
2817 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2818 inside unbound type.
2820 2008-11-14 Jb Evain <jbevain@novell.com>
2822 * driver.cs: ignore empty -nowarn argument such as
2823 the one in -nowarn:12,13,,.
2825 2008-11-13 Marek Safar <marek.safar@gmail.com>
2827 A fix for bug #444271
2828 * anonymous.cs: Rescan parent storeys when best candidate was
2831 2008-11-13 Marek Safar <marek.safar@gmail.com>
2833 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2834 useless UnboundTypeExpression.
2836 * attribute.cs: Do check obsolete attribute on generic types.
2838 2008-11-12 Marek Safar <marek.safar@gmail.com>
2840 A fix for bugs #425680, #400139
2841 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2844 2008-11-11 Marek Safar <marek.safar@gmail.com>
2846 A fix for bug #435747
2847 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2848 compound value types assignment. Few micro optimizations added.
2850 2008-11-10 Marek Safar <marek.safar@gmail.com>
2852 A fix for bug #442610
2853 * anonymous.cs (MutateConstructor): More SRE hacking.
2855 2008-11-10 Marek Safar <marek.safar@gmail.com>
2857 A fix for bug #442579
2858 * ecore.cs: Also initialize expanded form of a method with 1 params
2861 2008-11-06 Marek Safar <marek.safar@gmail.com>
2863 * expression.cs (UnaryMutator): Do early l-side check.
2865 2008-11-05 Miguel de Icaza <miguel@novell.com>
2867 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2868 Init, otherwise we would crash later on when checking for friend
2871 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2872 Otherwise we never get any meaningful information as to what
2875 2008-11-05 Marek Safar <marek.safar@gmail.com>
2877 A fix for bug #436318
2878 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2880 2008-11-05 Miguel de Icaza <miguel@novell.com>
2882 * namespace.cs: Turns out that it was a really bad idea to hide
2883 the errors for namespaces not found here in eval mode.
2885 * eval.cs: When we process using clauses, only enter those into
2886 the list of valid using clauses after they have been validated.
2888 The above change gives the proper semantics: it does not
2889 senselessly report the same errors with broken using statements by
2890 never storing them in the first place when they are invalid.
2892 2008-11-05 Marek Safar <marek.safar@gmail.com>
2894 A fix for bug #421839
2895 * cs-parser.jay: Remove expression from coalesce rule to force lower
2896 priority than the assignment operator.
2898 2008-11-05 Marek Safar <marek.safar@gmail.com>
2900 A fix for bug #437875
2901 * nullable.cs: Compile correctly method group operand used with null
2902 coalescing operator.
2904 2008-11-04 Marek Safar <marek.safar@gmail.com>
2906 A fix for bug #434589
2907 * expression.cs (Binary): Ignore lifted conversions when at least
2908 one operand is of reference type.
2910 2008-11-04 Marek Safar <marek.safar@gmail.com>
2912 * cs-parser.jay: Better syntax error report.
2914 2008-11-03 Marek Safar <marek.safar@gmail.com>
2916 A fix for bug #436792
2917 * cs-parser.jay: Use GetLocation to access location.
2919 2008-11-03 Marek Safar <marek.safar@gmail.com>
2921 A fix for bug #440774
2922 * cs-parser.jay: Also set current_array_type when parsing local
2925 2008-11-03 Marek Safar <marek.safar@gmail.com>
2927 A fix for bug #440785
2928 * expression.cs (As): Don't resolve self modifing expression
2931 2008-11-03 Marek Safar <marek.safar@gmail.com>
2933 A fix for bug #439447
2934 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2936 2008-11-03 Marek Safar <marek.safar@gmail.com>
2938 A fix for bug #437571
2939 * cs-parser.jay: Fixes internal error for invalid expression
2942 2008-10-17 Marek Safar <marek.safar@gmail.com>
2944 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2946 2008-10-17 Marek Safar <marek.safar@gmail.com>
2948 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2950 2008-10-17 Marek Safar <marek.safar@gmail.com>
2952 * cs-tokenizer.cs: More precise cast parsing.
2954 2008-10-16 Martin Baulig <martin@ximian.com>
2956 * anonymous.cs (AnonymousMethodStorey): Put back the
2957 `hoisted_locals' hashtable and use it in EmitType().
2959 2008-10-15 Marek Safar <marek.safar@gmail.com>
2961 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2962 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2965 2008-10-14 Marek Safar <marek.safar@gmail.com>
2967 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2969 2008-10-14 Marek Safar <marek.safar@gmail.com>
2971 * statement.cs: Mutate scope initializers.
2973 2008-10-14 Marek Safar <marek.safar@gmail.com>
2975 * expression.cs: Use typeless value for This constant.
2977 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2979 2008-10-14 Marek Safar <marek.safar@gmail.com>
2981 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2984 2008-10-13 Marek Safar <marek.safar@gmail.com>
2986 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2989 2008-10-13 Marek Safar <marek.safar@gmail.com>
2991 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2992 parser and tokenizer. Fixes many ambiguities including #433258.
2994 2008-10-10 Marek Safar <marek.safar@gmail.com>
2996 * cs-parser.jay: Fixed missing accessor recovery.
2998 2008-10-10 Marek Safar <marek.safar@gmail.com>
3000 A fix for bug #433701
3001 * expression.cs: Better error message.
3003 2008-10-10 Marek Safar <marek.safar@gmail.com>
3005 * cs-parser.jay, expression.cs: Start reporting real parser errors.
3007 * Makefile: Disabled unused debug symbols.
3009 Also fixes: #320556, #321097, #321656, #321876, #351316
3011 2008-10-09 Miguel de Icaza <miguel@novell.com>
3013 * eval.cs: rename "<interactive>" to "{interactive}", to work
3014 around a requirement in the compiler that this be a valid
3015 filename, and in Windows it is not (433886).
3017 2008-10-09 Marek Safar <marek.safar@gmail.com>
3019 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
3021 2008-10-08 Marek Safar <marek.safar@gmail.com>
3023 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
3024 cs-parser.jay: Generic type declaration and type arguments cleanup.
3026 2008-10-05 Marek Safar <marek.safar@gmail.com>
3028 * cs-parser.jay: Allow parsing weird array creation construct.
3030 2008-10-05 Marek Safar <marek.safar@gmail.com>
3032 * cs-parser.jay: Conflicts reduction.
3034 2008-10-04 Marek Safar <marek.safar@gmail.com>
3036 * cs-parser.jay: Conflicts reduction.
3038 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
3041 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
3042 property. Add a 'count' hint about the use of the shared vector.
3043 Ensure that we don't leak out dirty bits.
3044 (UsageVector.MergeChild): Throw away information about variables
3046 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
3048 2008-10-03 Marek Safar <marek.safar@gmail.com>
3050 A fix for bug #431746
3051 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
3052 parameters when iterator is created.
3054 2008-10-03 Marek Safar <marek.safar@gmail.com>
3056 A fix for bug #431827
3057 * expression.cs: Fixed right based pointer arithmetic operations
3060 2008-10-03 Marek Safar <marek.safar@gmail.com>
3062 A fix for bug #353779
3063 * assign.cs, expression.cs: Fixed compound assignment conversions.
3065 2008-10-02 Marek Safar <marek.safar@gmail.com>
3067 A fix for bug #375262
3068 * statement.cs: Refactor ArrayForeach to be usable with string
3069 indexer. Optimized single dimentional arrays foreach.
3071 2008-10-02 Marek Safar <marek.safar@gmail.com>
3073 A fix for bug #431255
3074 * anonymous.cs, expression.cs: Removed broken optimization.
3076 2008-10-01 Marek Safar <marek.safar@gmail.com>
3078 * anonymous.cs: Use full type parameters of parent generic
3079 containers. Removed unnecessary AddParentStoreyReference call.
3081 2008-10-01 Marek Safar <marek.safar@gmail.com>
3083 A fix for bug #324702
3084 * class.cs: Use better shorter names for explicit interface member
3087 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
3089 2008-10-01 Marek Safar <marek.safar@gmail.com>
3091 * expression.cs: Use new interface to check fixed expression.
3093 2008-10-01 Marek Safar <marek.safar@gmail.com>
3095 A fix for bug #421101
3096 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
3097 interface to check for fixed fixed-buffers.
3099 2008-10-01 Marek Safar <marek.safar@gmail.com>
3101 A fix for bug #429264
3102 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
3104 * delegate.cs: Removed unnecessary casts.
3106 2008-09-30 Marek Safar <marek.safar@gmail.com>
3108 A fix for bug #352151
3109 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
3110 class.cs: Fixed already defined explicit interface members check.
3112 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
3114 cs-tokenizer.cs: Fix typo.
3116 2008-09-28 Miguel de Icaza <miguel@novell.com>
3118 * eval.cs (InteractiveBase): The quit command now just sets a
3119 flag, instead of calling Environment.Exit(), it is milder on
3122 CompiledMethod is now in Mono.CSharp, not nested inside
3123 the Evaluator, it was inconvenient to use.
3125 2008-09-27 Miguel de Icaza <miguel@novell.com>
3127 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
3128 code to be invoked without having to reparse.
3130 2008-09-27 Miguel de Icaza <miguel@novell.com>
3132 * ecore.cs: The recent changes to FieldExpr broke this as well.
3133 Fixes LINQ queries in the interactive shell.
3135 * Multiple files: indentation fixing for the Mono coding
3136 guidelines for the switch statement.
3138 * eval.cs: Make the Evaluator API thread safe.
3140 2008-09-26 Marek Safar <marek.safar@gmail.com>
3142 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
3143 constructor parsing.
3145 2008-09-26 Marek Safar <marek.safar@gmail.com>
3147 A fix for bug #325326
3148 * statement.cs: Check possible mistaken empty statement using
3149 explicit blocks only.
3151 2008-09-25 Miguel de Icaza <miguel@novell.com>
3153 * eval.cs (LoadAssembly, ReferenceAssembly): Call
3154 RootNamespace.ComputeNamespaces to update the internal list of
3155 namespaces, this is no longer done for us.
3157 (InteractiveBase): Use the Evaluator APIs instead of calling into
3160 2008-09-25 Marek Safar <marek.safar@gmail.com>
3162 A fix for bug #429264
3163 * expression.cs: Missing mutator for access to multidimensional
3166 2008-09-25 Marek Safar <marek.safar@gmail.com>
3168 * class.cs, statement: Emit DebuggerHidden attribute for iterator
3171 * driver.cs: Missing input argument check.
3173 2008-09-25 Marek Safar <marek.safar@gmail.com>
3175 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
3176 expression.cs, statement.cs, rootcontext.cs, class.cs,
3177 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
3180 2008-09-24 Miguel de Icaza <miguel@novell.com>
3182 * ecore.cs (FieldExpr): Only initialize eclass when we return a
3183 fully constructed FieldExpr, fixes the regression introduced in
3186 * ecore.cs, expression.cs: Plug back the eclass initialization as
3187 otherwise it regresses `csharp'.
3189 2008-09-24 Marek Safar <marek.safar@gmail.com>
3191 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
3192 ecore.cs, attribute.cs: Moved obsolete method checks from emit
3193 phase to resolve phase. It resolves problems with expression trees
3194 and fixes bugs #323796, #325156.
3196 2008-09-23 Marek Safar <marek.safar@gmail.com>
3198 * codegen.cs: Report better error when symbol writer is missing.
3200 2008-09-23 Marek Safar <marek.safar@gmail.com>
3202 * codegen.cs: Set .NET symbol writer.
3204 * decl.cs: Guard against null generic arguments.
3206 * report.cs: Don't report exactly same additional details.
3208 2008-09-22 Marek Safar <marek.safar@gmail.com>
3210 A fix for bug #324917
3211 * cs-parser.jay: Add missing multidimensional non-expression type
3214 2008-09-22 Marek Safar <marek.safar@gmail.com>
3216 A fix for bug #428191
3217 * anonymous.cs: Create an outer generic fields also for non-storey
3220 2008-09-22 Marek Safar <marek.safar@gmail.com>
3222 A fix for bug #378294
3223 * class.cs: Make fixed size buffers gmcs feature only.
3225 2008-09-22 Marek Safar <marek.safar@gmail.com>
3227 A fix for bug #355622, #324993
3228 * assign.cs, const.cs, class.cs: Create new EmitContext for each
3231 2008-09-19 Marek Safar <marek.safar@gmail.com>
3233 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
3236 2008-09-19 Marek Safar <marek.safar@gmail.com>
3238 A fix for bug #416110
3239 * generic.cs: Struct constraint results in default ctor and
3240 ValueType base type constraint to be set.
3242 2008-09-19 Marek Safar <marek.safar@gmail.com>
3244 A fix for bug #423791
3245 * generic.cs: Fixed params output type type-inference.
3247 2008-09-19 Marek Safar <marek.safar@gmail.com>
3249 * cs-parser.jay, expression.cs: Fixed few expression crashes.
3251 2008-09-19 Marek Safar <marek.safar@gmail.com>
3253 * cs-tokenizer.cs: Don't break on extra partial modifier.
3255 2008-09-19 Marek Safar <marek.safar@gmail.com>
3257 A fix for bug #427592
3258 * generic.cs: Use common parameter resolve method.
3260 2008-09-18 Marek Safar <marek.safar@gmail.com>
3262 A fix for bug #414758
3263 * expression.cs, ecore.cs: Fixed crash when accessing non-static
3266 2008-09-18 Marek Safar <marek.safar@gmail.com>
3268 * driver.cs, namespace.cs: Read types and namespaces after all
3269 requested assemblies are loaded, fixes issues with System.Core
3270 auto-reference, and #419888.
3272 2008-09-18 Marek Safar <marek.safar@gmail.com>
3274 A fix for bug #417705
3275 * cs-parser.jay: Fixed as/is operator expression split.
3277 2008-09-18 Marek Safar <marek.safar@gmail.com>
3279 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3280 Fixed expression tree representation of empty new expression and
3281 new initializer expression.
3283 2008-09-18 Miguel de Icaza <miguel@novell.com>
3285 * eval.cs: Remove warning, keep reference to driver around.
3287 * Hide fields that do not need to be public.
3289 2008-09-17 Marek Safar <marek.safar@gmail.com>
3291 A fix for bug #426385
3292 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3293 conversion for array elements.
3295 2008-09-17 Marek Safar <marek.safar@gmail.com>
3297 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3298 void parsing conflicts.
3300 2008-09-15 Marek Safar <marek.safar@gmail.com>
3302 A fix for bug #425601
3303 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3304 System.Core only when there is no custom ExtensionAttribute
3307 2008-09-15 Miguel de Icaza <miguel@novell.com>
3309 * namespace.cs: Do not report CS0246 (name
3311 2008-09-12 Marek Safar <marek.safar@gmail.com>
3313 A fix for bug #425669
3314 * generic.cs: Don't cache generic static anonymous method
3317 2008-09-12 Marek Safar <marek.safar@gmail.com>
3319 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3320 conflicting constraints.
3322 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3324 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3327 2008-09-12 Marek Safar <marek.safar@gmail.com>
3329 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3330 to null pointer conversion fixes.
3332 2008-09-11 Marek Safar <marek.safar@gmail.com>
3334 * cs-parser.jay, expression.cs: An implicitly typed local variable
3335 declarator cannot use an array initializer.
3337 2008-09-11 Marek Safar <marek.safar@gmail.com>
3339 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3341 2008-09-11 Marek Safar <marek.safar@gmail.com>
3343 * generic.cs (InflatedConstraints): Don't crash when constraints
3346 * cs-parser.jay: const_declarator is a block.
3348 * constant.cs: Check for not allowed NaN conversions.
3350 2008-09-10 Miguel de Icaza <miguel@novell.com>
3352 * driver.cs: Drop --shell argument, the compiler is no longer a
3355 * eval.cs: Move most of the code that deals with evaluation into
3356 this file and document the public API from repl.cs
3358 * repl.cs: Remove from here.
3360 2008-09-10 Marek Safar <marek.safar@gmail.com>
3362 A fix for bug #424684
3363 * generic.cs: Generic class constraints must come first.
3365 2008-09-09 Miguel de Icaza <miguel@novell.com>
3367 * cs-parser.jay: Improve error reporting for syntax errors in
3368 statements and expressions, we now report the expected tokens
3369 instead of reporting the useless "; expected".
3371 Drop the strings from the token declaration, it turns out that
3372 they did not do what I thought they did. Instead they were adding
3373 two sets of tokens to the tables.
3375 2008-09-09 Marek Safar <marek.safar@gmail.com>
3377 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3378 delegate.cs: Share special type check.
3380 2008-09-09 Marek Safar <marek.safar@gmail.com>
3382 A fix for bug #423981
3383 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3385 2008-09-09 Marek Safar <marek.safar@gmail.com>
3387 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3390 2008-09-09 Marek Safar <marek.safar@gmail.com>
3392 A fix for bugs: #324750, #335946
3393 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3394 lookup rule to determine ?-based tokens.
3396 2008-09-08 Miguel de Icaza <miguel@novell.com>
3398 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3399 expressions (like event adding or removing) end up here, so we
3400 need to treat those as statements.
3402 Add LoadAssembly method.
3404 2008-09-04 Miguel de Icaza <miguel@novell.com>
3406 * repl.cs: Add Time method.
3408 2008-09-05 Marek Safar <marek.safar@gmail.com>
3410 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3412 2008-09-05 Miguel de Icaza <miguel@novell.com>
3414 * repl.cs: Add workaround for old compilers.
3416 2008-09-04 Jb Evain <jbevain@novell.com>
3418 * repl.cs (PrettyPrint): pretty print everything that
3419 implements IDictionary, as well as IEnumerables. Also,
3420 add a quit helper property.
3422 2008-09-04 Marek Safar <marek.safar@gmail.com>
3424 * constant.cs: Better error reporting for decimal literals.
3426 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3429 2008-09-04 Marek Safar <marek.safar@gmail.com>
3430 Miguel de Icaza <miguel@novell.com>
3432 A fix for bug #422951
3433 * assign.cs (Assign.DoResolve): Perform the type conversions
3434 checks before we attempt to initialize `New' initializers.
3436 2008-09-04 Marek Safar <marek.safar@gmail.com>
3438 A fix for bug #422853
3439 * delegate.cs (DelegateCreation): Add special handling for
3440 EmptyExpression.Null instance expression which is just another
3441 hack for undecided member instance exression.
3443 2008-09-04 Marek Safar <marek.safar@gmail.com>
3445 * expression.cs, ecore.cs: Emit full expression tree for reduced
3448 2008-09-04 Marek Safar <marek.safar@gmail.com>
3450 * expression.cs (This): Guard against multi-resolving.
3452 * ecore.cs, statement.cs (Throw): Simplified.
3454 * flowanalysis.cs: Also verify event fields.
3456 2008-09-04 Miguel de Icaza <miguel@novell.com>
3458 * assign.cs (Assign.DoResolve): Perform the type conversions
3459 checks before we attempt to initialize `New' initializers.
3461 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3463 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3466 * repl.cs: Update help.
3468 2008-09-03 Miguel de Icaza <miguel@novell.com>
3470 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3471 handling of the default config handling, including the special
3472 treatment of System.Core assembly.
3474 Fixes the REPL processing for LINQ.
3476 2008-09-03 Marek Safar <marek.safar@gmail.com>
3478 A fix for bug #422507
3479 * expression.cs (UnboxCast): Add missing child expression mutator.
3481 2008-09-03 Marek Safar <marek.safar@gmail.com>
3483 * driver.cs: Don't self reference System.Core assembly.
3485 2008-09-03 Marek Safar <marek.safar@gmail.com>
3487 A fix for bug #422507
3488 * expression.cs (StringConcat): Add missing type mutator.
3490 2008-09-03 Marek Safar <marek.safar@gmail.com>
3492 * generic.cs (TypeInferenceContext): Follow equality rule for
3493 constructed type lower bound type inference.
3495 2008-09-02 Miguel de Icaza <miguel@novell.com>
3497 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3498 <dblank@cs.brynmawr.edu> which updates the cursor position on
3501 2008-09-02 Marek Safar <marek.safar@gmail.com>
3503 A fix for bug #367145
3504 * driver.cs: Fixed import of extension methods when using -noconfig
3507 2008-09-02 Marek Safar <marek.safar@gmail.com>
3509 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3510 version from non-generic implementation instead.
3512 2008-09-01 Marek Safar <marek.safar@gmail.com>
3514 A fix for bug #418908
3515 * class.cs: Use AddScopeStatement for field initializers.
3517 2008-09-01 Marek Safar <marek.safar@gmail.com>
3519 A fix for bug #415385
3520 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3522 2008-09-01 Marek Safar <marek.safar@gmail.com>
3524 A fix for bug #421736
3525 * iterators.cs: Don't crash on unreachable iterators.
3527 2008-09-01 Marek Safar <marek.safar@gmail.com>
3529 A fix for bug #421628
3530 * parameter.cs, attribute.cs: Clone also parameter attributes.
3532 2008-08-30 Miguel de Icaza <miguel@novell.com>
3534 * namespace.cs (LookupType): In EvalMode, try to replace
3535 the TypeBuilder from our cache with a Type as Reflection.Emit does
3536 not like to mix code from older assemblies emitted and new
3539 This sounds like a serious Mono bug that prevents multiple
3540 assemblies to be generated and consumed at the same time.
3542 * cs-parser.jay (push_current_class): Do not make interactive
3543 classes internal or private, make them public as we currently
3544 generate each new class in a new assembly.
3546 2008-08-29 Miguel de Icaza <miguel@novell.com>
3548 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3549 remove types that are entered into the global namespace during
3550 parsing so that we can remove them on failure.
3552 * cs-parser.jay: Parsing: we now keep track of types that are
3553 entered into global variables and queue those in case the parsing
3556 This happens in a few situations: during partial-input, we invoke
3557 the parser repeatedly for example with the string "class X", this
3558 would cause X to be registed, and we need to remove this
3559 registration so that another parse attempt later with say "class X {"
3560 would actually work.
3562 Additionally, if there is an error in the resolution phase, for
3563 example: "class X : NonExistant {}" th
3565 * cs-parser.jay: Be more precise with the errors being raised,
3566 instead of flagging all exceptions during parsing to be attributed
3567 to the parsing process, distinguish those from errors happening in
3568 the actions and hint that using -v would produce the actual
3571 * repl.cs: Do not load all compiler references on each reset,
3572 doing the partial reset takes care of this.
3574 2008-08-28 Miguel de Icaza <miguel@novell.com>
3576 * repl.cs: Add support for loading all the files from
3577 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3580 Introduce a micro-parser that is able to deambiguate on its input
3581 whether we are dealing with a compilation unit (namespace, class,
3582 interface, struct, delegate) declaration or a statement. This
3583 allows both declarations and statements to be entered.
3585 Set history size by default to 300 lines.
3587 Instead of distinguishing based on the parser.InteractiveResult,
3588 have only two cases: statements were parsed, or a compilation unit
3589 was. Always pull the Using statement additions from the
3590 compilation unit parse.
3592 * cs-tokenizer.cs: Rename tokens to better describe their intent
3593 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3595 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3596 EvalMode is used to trigger the lookup of global variables while
3597 StatementMode is used turn variable declarations into static
3600 * getline.cs: Allow history size to be set.
3602 2008-08-29 Marek Safar <marek.safar@gmail.com>
3604 A fix for bug #360755
3605 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3607 2008-08-29 Marek Safar <marek.safar@gmail.com>
3609 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3611 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3612 member name, it is too confusing
3614 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3616 * rootcontext.cs: Finally default to warning level 4.
3618 2008-08-28 Marek Safar <marek.safar@gmail.com>
3620 * class.cs (CheckBase): Ignore overloaded operators.
3622 2008-08-28 Marek Safar <marek.safar@gmail.com>
3624 A fix for bug #420830
3625 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3627 2008-08-28 Marek Safar <marek.safar@gmail.com>
3629 A fix for bug #420832
3630 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3632 2008-08-28 Marek Safar <marek.safar@gmail.com>
3634 A fix for bug #420386
3635 * nullables.cs: Fixed logic of nullable user comparison operators involving
3638 2008-08-28 Marek Safar <marek.safar@gmail.com>
3640 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3642 2008-08-27 Miguel de Icaza <miguel@novell.com>
3644 * repl.cs: Add support for aborting the running code with C-c.
3646 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3648 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3650 2008-08-27 Miguel de Icaza <miguel@novell.com>
3652 * cs-parser.jay (interactive_statement_list): A new set of rules
3653 for hosting statements that uses the "interactive_" prefix.
3655 * repl.cs: Add support for parsing `using' as a statement or as a
3656 directive. Deambiguating before passing this to the parser.
3658 We need to distinguish statement_expressions that occur at the
3659 toplevel vs those that occur embedded into expressions.
3661 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3662 that fixes the cursor key handling, and a history bug.
3664 2008-08-26 Miguel de Icaza <miguel@novell.com>
3666 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3667 limitations in Console, instead the 2.0 bootstrap libraries now
3668 include the Console bits.
3670 Also, remove the use of Nullables from getline.cs
3674 Interactive support for the C# compiler. Use gmcs --shell to
3675 enter a read-eval-print loop shell.
3677 Docs: http://www.mono-project.com/CsharpRepl
3679 * sources: include repl.cs here and getline.cs for gmcs.exe,
3680 everything else is getline.cs impaired.
3682 * Makefile: when bootstrapping pass a special flag
3683 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3684 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3685 This distinguishes those two cases.
3687 * repl.cs: Support for a read-eval-print loop. Will be soon
3688 refactored into eval support and then REPL on top of it.
3690 * ecore.cs: If a simplename lookup fails, before erroring out,
3691 if we are in EvalMode to resolve the name to a declaration in the
3694 This means that variable declarations that happened in previous
3695 classes (as repl puts every statement in a separate class) are
3696 made visible in this way.
3698 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3699 triggered an error due to the end of file being reached. This is
3700 used to do multi-line input, and notify the caller that the user
3701 needs to provide more text before a successful parse.
3703 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3704 to drive the evaluation with a custom wrapper.
3706 * driver.cs: Add support for --shell, and refactor some code to be
3709 * namespace.cs: Add support for serializing the contents of the
3710 namespaces and reloading them.
3712 * getline.cs: A managed implementation of ReadLine under
3713 X11/Apache2 license terms. Easy to embed in other applications as
3716 * namespace.cs: Add some functions to save and restore the
3719 * rootcontext.cs: New public field.
3721 * cs-tokenizer.cs: Add support for one of the possible characters
3722 we introduce into the token stream.
3724 This patch does not affect the regular tokenization process, the
3725 only performance hit would happen if there is an invalid character
3726 on the input string.
3728 * support.cs: Move isatty helper routine here.
3730 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3731 code generator for in-memory assemblies.
3733 2008-08-26 Marek Safar <marek.safar@gmail.com>
3735 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3736 parameter cannot be always used as a type.
3738 2008-08-21 Marek Safar <marek.safar@gmail.com>
3740 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3742 2008-08-21 Marek Safar <marek.safar@gmail.com>
3744 * convert.cs: Implement explicit array to IList<T> conversion.
3746 2008-08-20 Marek Safar <marek.safar@gmail.com>
3748 A fix for bug #362740
3749 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3751 2008-08-20 Marek Safar <marek.safar@gmail.com>
3753 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3754 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3755 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3756 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3757 handling to use just one type of infrastructure and deal with generics
3760 2008-07-23 Martin Baulig <martin@ximian.com>
3762 *** Merged this from trunk revision 108527 ***
3765 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3766 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3769 2008-08-15 Marek Safar <marek.safar@gmail.com>
3771 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3774 2008-08-15 Marek Safar <marek.safar@gmail.com>
3776 * delegate.cs: Fixed compiler crash when creating delegate using partial
3779 * typemanager.cs: MulticastDelegate is not a delegate.
3781 2008-08-14 Marek Safar <marek.safar@gmail.com>
3783 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3786 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3788 * cs-parser.jay (type): Allow 'var' in mcs too.
3789 (local_variable_type): Likewise.
3791 2008-08-14 Marek Safar <marek.safar@gmail.com>
3793 * driver.cs: Removed broken -noconfig variants.
3795 2008-08-14 Marek Safar <marek.safar@gmail.com>
3797 A fix for bug #417078
3798 * expression.cs: Emit correctly left side pointer operators.
3800 2008-08-13 Marek Safar <marek.safar@gmail.com>
3802 * generic.cs, lambda.cs: Inflate method generic arguments only.
3804 2008-08-12 Marek Safar <marek.safar@gmail.com>
3806 * class.cs: Fixed struct layout check regression.
3808 2008-08-12 Marek Safar <marek.safar@gmail.com>
3810 * cs-parser.jay, enum.cs: Simplified enum parsing.
3812 * decl.cs: Check all type parameters conflicts.
3814 * expression.cs, statement.cs, attribute.cs: More expression checks.
3816 2008-08-11 Marek Safar <marek.safar@gmail.com>
3818 * generic.cs: Add type inference types restriction.
3820 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3821 anonymous.cs, expression.cs: Allocate less accessor parameters.
3823 2008-08-08 Marek Safar <marek.safar@gmail.com>
3825 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3828 2008-08-08 Marek Safar <marek.safar@gmail.com>
3830 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3832 2008-08-07 Marek Safar <marek.safar@gmail.com>
3834 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3835 Also fixes #362146 and #381592.
3837 2008-08-07 Marek Safar <marek.safar@gmail.com>
3839 * ecore.cs: Reduced constant cannot be used as an attribute value.
3841 * cs-parser.jay: Base expression has to be a type.
3843 * expression.cs (Conditional): Uses ReducedExpression.
3845 2008-08-06 Marek Safar <marek.safar@gmail.com>
3847 A fix for bug #376826
3848 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3849 address of hoisted local variable or parameter cannot be taken.
3851 2008-08-05 Marek Safar <marek.safar@gmail.com>
3853 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3854 anonymous method inside checked/unchecked expression.
3856 2008-08-05 Marek Safar <marek.safar@gmail.com>
3858 * typemanager.cs (IsEqual): Guard against null.
3860 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3861 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3862 routine. Fixed few misleading conversion errors.
3864 2008-08-04 Marek Safar <marek.safar@gmail.com>
3866 * class.cs: Consider generics when checking cycles in struct layout.
3868 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3870 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3872 2008-08-04 Marek Safar <marek.safar@gmail.com>
3874 A fix for bug #414165
3875 * anonymous.cs: Use same anonymous implementation method for all anonymous
3878 2008-08-04 Marek Safar <marek.safar@gmail.com>
3880 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3883 2008-08-04 Marek Safar <marek.safar@gmail.com>
3885 * cs-parser.jay: Typeof argument has to be a type expression.
3887 * namespace.cs: Check alias and namespace definitions collisions.
3889 * class.cs, pending.cs: Moved explicit interface accessor implementation
3892 * delegate.cs, expression.cs: Verify special name invocations.
3894 2008-08-01 Marek Safar <marek.safar@gmail.com>
3896 * cs-parser.jay: Don't choke on empty generic type arguments.
3898 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3900 * expression.cs, ecore.cs: Minor expressions bugs.
3902 2008-08-01 Marek Safar <marek.safar@gmail.com>
3904 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3905 and added more error handling.
3907 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3909 * modifiers.cs, enum.cs: Fixed.
3911 2008-07-31 Jb Evain <jbevain@novell.com>
3913 * driver.cs: remove -pkg ability of smcs.
3915 2008-07-30 Marek Safar <marek.safar@gmail.com>
3917 * statement.cs (Switch): Correctly set empty default target for single
3920 2008-07-30 Marek Safar <marek.safar@gmail.com>
3922 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3923 string switch statement implementation to use string dictionary which
3924 significantly (2-8x) improves performance of generated code.
3926 2008-07-29 Marek Safar <marek.safar@gmail.com>
3928 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3929 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3931 2008-07-29 Marek Safar <marek.safar@gmail.com>
3933 A fix for bug #412595
3934 * typemanager.cs, convert.cs, expression.cs: Some types are never
3935 convertible to each other.
3937 2008-07-29 Marek Safar <marek.safar@gmail.com>
3939 * nullable.cs (CreateNullConstant): An error messages update.
3941 2008-07-29 Marek Safar <marek.safar@gmail.com>
3943 A fix for bug #412595
3944 * cfold.cs: Don't cast undefined bool constant.
3946 2008-07-29 Martin Baulig <martin@ximian.com>
3949 (SymbolWriter.Reset): New public static method.
3952 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3954 2008-07-28 Marek Safar <marek.safar@gmail.com>
3956 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3958 * expression.cs (ElementAccess): Exact size allocation.
3960 2008-07-26 Marek Safar <marek.safar@gmail.com>
3962 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3964 2008-07-25 Marek Safar <marek.safar@gmail.com>
3966 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3968 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3971 2008-07-25 Marek Safar <marek.safar@gmail.com>
3973 A fix for bug #412217
3974 * assign.cs: Mutate also assignment type.
3976 2008-07-25 Marek Safar <marek.safar@gmail.com>
3978 A fix for bug #323644
3979 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3982 2008-07-25 Marek Safar <marek.safar@gmail.com>
3984 A fix for bug #412134
3985 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3986 non-enumerable operands when overloading equality or bitwise operators.
3988 2008-07-25 Marek Safar <marek.safar@gmail.com>
3990 * anonymous.cs: Cache closed generic anonymous method delegates.
3992 2008-07-24 Marek Safar <marek.safar@gmail.com>
3994 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3995 anonymous.cs, statement.cs: Always emit anonymous method as static method
3996 when is instance free. Use nesting for nested anynomous methods blocks.
3998 2008-07-23 Marek Safar <marek.safar@gmail.com>
4000 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
4003 2008-07-23 Marek Safar <marek.safar@gmail.com>
4005 * expression.cs: Removed MakeSimpleCall.
4007 2008-07-23 Marek Safar <marek.safar@gmail.com>
4009 A fix for bug #323012
4010 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
4011 Base method implementing interface has to be public.
4013 2008-07-23 Marek Safar <marek.safar@gmail.com>
4015 * cs-parser.jay: Don't break on missing argument.
4017 2008-07-22 Marek Safar <marek.safar@gmail.com>
4019 A fix for bug #320993
4020 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
4021 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
4023 2008-07-22 Marek Safar <marek.safar@gmail.com>
4025 A fix for bug #320748
4026 * convert.cs: Implicit user operators cannot convert to interfaces
4028 2008-07-22 Marek Safar <marek.safar@gmail.com>
4030 A fix for bug #312686
4031 * driver.cs: Ignore empty assembly references.
4033 2008-07-22 Marek Safar <marek.safar@gmail.com>
4035 A fix for bug #387040
4036 * ecore.cs: Skip constrains check for an explicit implementation.
4038 2008-07-21 Marek Safar <marek.safar@gmail.com>
4040 A fix for bug #409045
4041 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
4042 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
4043 identifiers are file specific unless passed as input arguments.
4045 2008-07-21 Marek Safar <marek.safar@gmail.com>
4047 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
4048 to emit UnmanagedMarshal data under 2.0 profile.
4050 2008-07-21 Marek Safar <marek.safar@gmail.com>
4052 A fix for bug #410369
4053 * parameter.cs: Clone correctly ParamsParameter.
4055 2008-07-21 Marek Safar <marek.safar@gmail.com>
4057 * expression.cs (Argument): Always report type for type based expressions
4060 2008-07-18 Marek Safar <marek.safar@gmail.com>
4062 A fix for bug #410666
4063 * anonymous.cs: Correctly initialize generic storey reference.
4065 2008-07-18 Marek Safar <marek.safar@gmail.com>
4067 * convert.cs: Don't box same type arguments.
4069 2008-07-18 Marek Safar <marek.safar@gmail.com>
4071 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
4072 Finished missing generic type mutators.
4074 2008-07-18 Marek Safar <marek.safar@gmail.com>
4076 * iterators.cs, statement.cs: Finished statements CloneTo.
4078 2008-07-18 Marek Safar <marek.safar@gmail.com>
4080 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
4082 * expression.cs: Emit optimized default value expressions in expression tree
4085 2008-07-18 Marek Safar <marek.safar@gmail.com>
4087 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
4089 2008-07-17 Marek Safar <marek.safar@gmail.com>
4091 A fix for bug #367536
4092 * cs-parser.jay: Check static constructor of generic types for an access
4095 2008-07-17 Marek Safar <marek.safar@gmail.com>
4097 A fix for bug #353800
4098 * lambda.cs: Emit ret for contextual statements.
4100 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
4101 up emitting redundant ret for all anonymous methods with return.
4103 2008-07-17 Marek Safar <marek.safar@gmail.com>
4105 A fix for bug #365188
4106 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
4107 create anonymous method storey in unreachable block.
4109 2008-07-17 Marek Safar <marek.safar@gmail.com>
4111 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
4112 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
4113 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
4114 statement.cs: Fixed relevant defects found by Gendarme.
4116 2008-07-17 Marek Safar <marek.safar@gmail.com>
4118 A fix for bug #325291
4119 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
4120 statement.cs: Replaced IAnonymousHost with top level block flag.
4122 2008-07-17 Marek Safar <marek.safar@gmail.com>
4124 * cs-parser.jay: Clean up unused open_parens.
4126 2008-07-17 Marek Safar <marek.safar@gmail.com>
4128 * ecore.cs: Custom error message for a range variable assignment.
4130 2008-07-16 Marek Safar <marek.safar@gmail.com>
4132 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
4135 2008-07-16 Marek Safar <marek.safar@gmail.com>
4137 * literal.cs: Null literal is of object type.
4139 2008-07-16 Marek Safar <marek.safar@gmail.com>
4141 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
4142 expression of nullable equality comparison.
4144 2008-07-15 Marek Safar <marek.safar@gmail.com>
4146 * expression.cs(PointerArithmetic): Removed redundant assignment.
4148 2008-07-15 Marek Safar <marek.safar@gmail.com>
4150 * decl.cs (GetSignatureForError): Report full namespace name for containers.
4152 2008-07-14 Marek Safar <marek.safar@gmail.com>
4154 A fix for bug #408361
4155 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
4156 they are replaced by GetMethod.
4158 2008-07-14 Marek Safar <marek.safar@gmail.com>
4160 A fix for bug #408721 by jeremie.laval@gmail.com
4161 * expression.cs (Indirection): Implemented CloneTo.
4163 2008-07-14 Marek Safar <marek.safar@gmail.com>
4165 * statement.cs (AssignableSlots): Temporary disabled variable initialization
4168 2008-07-14 Marek Safar <marek.safar@gmail.com>
4170 * report.cs (EnableReporting): Don't reinitialize 0-based values.
4172 2008-07-11 Marek Safar <marek.safar@gmail.com>
4174 * linq.cs: Reset tranparent parameter counter in probing mode.
4176 2008-07-11 Marek Safar <marek.safar@gmail.com>
4178 * anonymous.cs: Mutate anonymous method type.
4180 2008-07-11 Marek Safar <marek.safar@gmail.com>
4182 * ecore.cs, anonymous.cs: Mutate field expressions.
4184 2008-07-10 Marek Safar <marek.safar@gmail.com>
4186 A fix for bug #369670
4187 * linq.cs, statement.cs: Use explicit block for query expressions variables.
4189 2008-07-10 Marek Safar <marek.safar@gmail.com>
4191 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
4193 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
4196 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
4197 only one '>', and finds a '>>', abort the generic lookahead.
4199 2008-07-10 Marek Safar <marek.safar@gmail.com>
4201 A fix for bug #319902
4202 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
4204 2008-07-10 Marek Safar <marek.safar@gmail.com>
4206 A fix for bug #406371
4207 * statement.cs: Moved EmitSymbolInfo to Block.
4209 2008-07-09 Marek Safar <marek.safar@gmail.com>
4211 * ecore.cs: Report better error for extension method overload failures.
4213 2008-07-09 Marek Safar <marek.safar@gmail.com>
4215 * expression.cs (Is): No need to box reference values.
4217 2008-07-09 Marek Safar <marek.safar@gmail.com>
4219 * class.cs: Use event resolve context when initializing CreateEmitContext.
4221 2008-07-09 Marek Safar <marek.safar@gmail.com>
4223 A fix for bug #394436
4224 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
4225 method used inside expression trees. Added more LINQ to expression tree
4228 2008-07-08 Marek Safar <marek.safar@gmail.com>
4230 A fix for bug #378189, #370577
4231 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
4234 2008-07-08 Marek Safar <marek.safar@gmail.com>
4236 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
4239 2008-07-08 Marek Safar <marek.safar@gmail.com>
4241 A fix for bug #406702
4242 * anonymous.cs: Always park anonymous method in the nearest parent storey.
4244 2008-07-07 Marek Safar <marek.safar@gmail.com>
4246 A fix for bug #406648
4247 * cs-parser.jay: Report nullable use in mcs for some cases.
4249 2008-07-07 Marek Safar <marek.safar@gmail.com>
4251 * ecore.cs: Improved argument mismatch error messages.
4253 2008-07-07 Marek Safar <marek.safar@gmail.com>
4255 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
4257 2008-07-07 Marek Safar <marek.safar@gmail.com>
4259 * expression.cs (TypeOf): Mutate type argument.
4261 2008-07-04 Marek Safar <marek.safar@gmail.com>
4263 * class.cs: Report missing partial modifier for correct type.
4265 2008-07-04 Marek Safar <marek.safar@gmail.com>
4267 * ecore.cs, expression.cs (VariableReference): Variable property is
4270 2008-07-04 Marek Safar <marek.safar@gmail.com>
4272 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4274 2008-07-04 Marek Safar <marek.safar@gmail.com>
4276 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4279 2008-07-04 Marek Safar <marek.safar@gmail.com>
4281 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4282 anonymous method storey to an instance method when only "this" is hoisted.
4284 2008-07-03 Marek Safar <marek.safar@gmail.com>
4286 A fix for bug #321615
4287 * expression.cs: Pointer comparisons use unsigned operator.
4289 2008-07-03 Marek Safar <marek.safar@gmail.com>
4291 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4293 2008-07-02 Marek Safar <marek.safar@gmail.com>
4295 A fix for bug #404905
4296 * class.cs: Always initialize local unsafe variables.
4298 2008-06-30 Marek Safar <marek.safar@gmail.com>
4300 A fix for bug #396987
4301 * expression.cs (NewInitialize): Clear local temporary variable for next run
4303 2008-06-27 Marek Safar <marek.safar@gmail.com>
4305 A fix for bug #401020
4306 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4308 2008-06-27 Marek Safar <marek.safar@gmail.com>
4310 A fix for bug #398319
4311 * cs-parser.jay: Implemented undocumented base access expression inside
4314 2008-06-26 Marek Safar <marek.safar@gmail.com>
4316 A fix for bug #404227
4317 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4319 2008-06-26 Marek Safar <marek.safar@gmail.com>
4321 A fix for bug #404227
4322 * convert.cs: Fixed explicit array to interface cast.
4324 2008-06-26 Marek Safar <marek.safar@gmail.com>
4326 A fix for bug #403894
4327 * delegate.cs: Mutate DelegateInvocation type.
4329 2008-06-26 Marek Safar <marek.safar@gmail.com>
4331 A fix for bug #379348
4332 * delegate.cs: Box a load of generic parameters.
4334 2008-06-26 Marek Safar <marek.safar@gmail.com>
4336 * expression.cs: Add an array creation arguments mutate.
4338 2008-06-26 Marek Safar <marek.safar@gmail.com>
4340 A fix for bug #386068
4341 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4344 2008-06-25 Marek Safar <marek.safar@gmail.com>
4346 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4349 2008-06-25 Marek Safar <marek.safar@gmail.com>
4351 A fix for bug #403518
4352 * delegate.cs: Type correctly anonymous method new invocation.
4354 2008-06-24 Marek Safar <marek.safar@gmail.com>
4356 A fix for bug #394826
4357 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4360 2008-06-24 Marek Safar <marek.safar@gmail.com>
4362 A fix for bug #394826
4363 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4366 2008-06-24 Marek Safar <marek.safar@gmail.com>
4368 * class.cs: Clone indexer parameters for localized capturing.
4370 2008-06-24 Marek Safar <marek.safar@gmail.com>
4372 A fix for bug #402379
4373 * expression.cs: Don't crash when an object initializer resolve fails.
4375 2008-06-24 Marek Safar <marek.safar@gmail.com>
4377 A fix for bug #402888
4378 * expression.cs: Mutate conditional expression.
4380 2008-06-24 Marek Safar <marek.safar@gmail.com>
4382 A fix for bug #401012
4383 * class.cs: Keep StructLayout in shared container.
4385 2008-06-24 Marek Safar <marek.safar@gmail.com>
4387 A fix for bug #400438
4388 * decl.cs, class.cs: Only properties can be automatically implemented.
4390 2008-06-24 Marek Safar <marek.safar@gmail.com>
4392 * statement.cs (ChangeToIterator): Copy also labels.
4394 2008-06-23 Marek Safar <marek.safar@gmail.com>
4396 * ecore.cs: Pass type argument details to parent extension method.
4398 2008-06-23 Marek Safar <marek.safar@gmail.com>
4400 A fix for bug #375966
4401 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4403 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4405 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4407 2008-06-22 Marek Safar <marek.safar@gmail.com>
4409 A fix for bug #394347
4410 * anonymous.cs: Cache compatible delegates as compatibility check produces
4411 a new method every time.
4413 2008-06-20 Marek Safar <marek.safar@gmail.com>
4415 * anonymous.cs: Propagate storey reference for single references.
4417 2008-06-20 Marek Safar <marek.safar@gmail.com>
4419 A fix for bug #387615
4420 * assign.cs, expression.cs: Correctly clone compound assignment.
4422 2008-06-19 Marek Safar <marek.safar@gmail.com>
4424 A fix for bug #359611, #359604
4425 * anonymous.cs: Mutate all types of hoisted parameters.
4427 2008-06-19 Marek Safar <marek.safar@gmail.com>
4429 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4430 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4431 expression.cs, codegen.cs, statement.cs
4433 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4434 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4436 ** Anonymous methods, lambda expressions rewrite **
4438 Anonymous expressions are now resolved when an explicit block is resolved
4439 and they don't require any registration procedure anymore. Further,
4440 anonymous methods are defined when explicit block is emitted which allows
4441 better control of whole process and opens possibilities for more
4442 optimizations as well as alternative to reverse whole process.
4444 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4445 process consistent and to correctly emit hoisted generic methods when they
4446 have at least 1 hoisted variable.
4448 2008-06-17 Martin Baulig <martin@ximian.com>
4450 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4452 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4453 virtual property; check it in Emit().
4454 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4456 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4458 (Indexer.Define): Likewise.
4460 2008-06-17 Marek Safar <marek.safar@gmail.com>
4462 * convert.cs: Don't use IsInterface on type arguments.
4464 * delegate.cs: DelegateInvocation uses MethodInfo.
4466 * parameter.cs: Removed IsTypeParameter.
4468 * generic-mcs.cs: More missing stuff.
4470 2008-06-16 Martin Baulig <martin@ximian.com>
4473 (Modifiers.DEBUGGER_HIDDEN): New public const.
4476 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4479 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4480 (AbstractPropertyEventMethod): Likewise.
4481 (Constructor.Emit): Likewise.
4482 (SourceMethod.SetCompilerGenerated): Removed.
4484 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4488 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4489 if we're an `IteratorHost'.
4490 (AnonymousMethodMethod..ctor): Don't set
4491 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4494 2008-06-16 Marek Safar <marek.safar@gmail.com>
4496 * statement.cs: Clean-up foreach statements.
4498 2008-06-12 Marek Safar <marek.safar@gmail.com>
4500 * class.cs: Stop using public method which should not exist
4501 (MethodBuilder.SetGenericMethodSignature).
4503 2008-06-11 Martin Baulig <martin@ximian.com>
4506 (Location.LookupFile): Add `CompilationUnit' argument; when given
4507 a relative file name, make it relative to the directory the .cs
4508 file is located in instead of using the current directory.
4510 2008-06-11 Martin Baulig <martin@ximian.com>
4513 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4514 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4515 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4516 (SourceMethod.SetCompilerGenerated): Likewise.
4518 2008-06-11 Marek Safar <marek.safar@gmail.com>
4520 * codegen.cs, driver: Only write symbol file when it's asked for.
4522 2008-06-11 Marek Safar <marek.safar@gmail.com>
4524 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4526 2008-06-10 Martin Baulig <martin@ximian.com>
4528 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4530 2008-06-09 Marek Safar <marek.safar@gmail.com>
4532 A fix for bug #316290
4533 * expression.cs: Include decimal operators in predefined table.
4535 * parameters.cs: More readonlyness.
4537 2008-06-09 Marek Safar <marek.safar@gmail.com>
4539 A fix for bug #397213
4540 * cs-parser.jay: One more missing current_local_parameters reset.
4542 2008-06-09 Marek Safar <marek.safar@gmail.com>
4544 A fix for bug #396633
4545 * class.cs: Host backing field in partial container.
4547 2008-06-09 Marek Safar <marek.safar@gmail.com>
4549 A fix for bug #397068
4550 * expression.cs: Check both operand types when predefined operator is used.
4552 2008-06-05 Martin Baulig <martin@ximian.com>
4554 Merged the `debugger-kahalo' branch.
4557 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4558 we're an iterator method.
4559 (SourceMethod): Reflect latest symbol writer changes;
4560 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4561 now `start_row' and `end_row'.
4562 (Constructor.Emit): Fix the logic whether to emit symbol information.
4564 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4568 (CompilationUnit): New public class; derives from `SourceFile'.
4569 (SourceFileEntry.DefineSymbolInfo): New public method.
4570 (SourceFileEntry.SetChecksum): New public method.
4571 (Location): Encode hidden line numbers by using `column == 255';
4572 the .ctor now accepts `column == -1' to mark a hidden line number.
4573 (Location.Hidden): New public property.
4574 (Location.CheckPoint): Add `CompilationUnit'.
4575 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4576 (Location.Push): Add `CompilationUnit compile_unit' argument.
4577 (Location.CompilationUnit): New public property.
4580 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4582 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4584 * driver.cs: `SourceFile' -> `CompilationUnit'.
4586 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4588 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4590 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4594 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4595 new symbol writer API to also pass the file.
4597 2008-06-05 Marek Safar <marek.safar@gmail.com>
4599 * statement.cs: Emit catch variable assignment using variable expression.
4601 2008-06-05 Marek Safar <marek.safar@gmail.com>
4603 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4604 with other variable types.
4606 2008-06-04 Marek Safar <marek.safar@gmail.com>
4608 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4609 GetLength method emit, it breaks resolve rules.
4611 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4612 Marek Safar <marek.safar@gmail.com>
4614 A fix for bug #395542
4615 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4618 2008-06-02 Marek Safar <marek.safar@gmail.com>
4620 A fix for bug #395287
4621 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4623 2008-05-31 Marek Safar <marek.safar@gmail.com>
4625 A fix for bug #395845
4626 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4627 non-nullable parameter type.
4629 2008-05-31 Marek Safar <marek.safar@gmail.com>
4631 * class.cs: Handle contructor initializer as a statement in top-level block.
4633 2008-05-30 Marek Safar <marek.safar@gmail.com>
4635 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4636 security attributes.
4638 2008-05-24 Marek Safar <marek.safar@gmail.com>
4640 * ecore.cs, expression.cs: Small IVariable refactoring.
4642 2008-05-22 Marek Safar <marek.safar@gmail.com>
4644 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4646 2008-05-21 Marek Safar <marek.safar@gmail.com>
4648 * cs-parser.jay: Removed redundant catch type check.
4650 2008-05-21 Marek Safar <marek.safar@gmail.com>
4652 A fix for bug #390372
4653 * nullable.cs: Set correct return type.
4655 2008-05-21 Marek Safar <marek.safar@gmail.com>
4657 A fix for bug #391062
4658 * typemanager.cs: Fixed crash when comparing null types.
4660 2008-05-21 Marek Safar <marek.safar@gmail.com>
4662 A fix for bug #391871
4663 * cs-parser.jay: Better error handling for invalid catch type.
4665 2008-05-20 Marek Safar <marek.safar@gmail.com>
4667 A fix for bug #392155
4668 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4670 2008-05-15 Marek Safar <marek.safar@gmail.com>
4672 A fix for bug #390666
4673 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4676 2008-05-15 Marek Safar <marek.safar@gmail.com>
4678 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4681 2008-05-13 Marek Safar <marek.safar@gmail.com>
4683 A fix for bug #389625
4684 * delegate.cs, generic.cs: Some progress on method group return type
4687 2008-05-13 Marek Safar <marek.safar@gmail.com>
4689 A fix for bug #378419
4690 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4692 2008-05-12 Marek Safar <marek.safar@gmail.com>
4694 * class.cs (Constructor): Added IsCompilerGenerated.
4696 2008-05-12 Marek Safar <marek.safar@gmail.com>
4698 * expression.cs: Enum binary operators can accept non-enum operand only when
4699 is implicitly convertible to underlying type.
4701 2008-05-12 Marek Safar <marek.safar@gmail.com>
4703 A fix for bug #389272
4704 * support.cs: Workaround System.InvalidOperationException for enums.
4706 2008-05-12 Marek Safar <marek.safar@gmail.com>
4708 A fix for bug #389073
4709 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4711 2008-05-10 Marek Safar <marek.safar@gmail.com>
4713 * driver.cs: Split Parse.
4715 * location.cs (LookupFile): Uses string.Empty.
4717 2008-05-07 Marek Safar <marek.safar@gmail.com>
4719 * expression.cs, parameter.cs: Small ParameterReference clean up.
4721 2008-05-07 Marek Safar <marek.safar@gmail.com>
4723 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4724 hack. Fixes #387502.
4726 2008-05-06 Martin Baulig <martin@ximian.com>
4728 * class.cs (Constructor.Emit): Fix the logic whether to emit
4731 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4734 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4735 InvalidOperationException when the iterator is before the start or
4738 2008-05-06 Marek Safar <marek.safar@gmail.com>
4740 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4741 when left is nullable type.
4743 2008-05-06 Marek Safar <marek.safar@gmail.com>
4745 A fix for bug #386628
4746 * expression.cs (LocalVariableReference): Continue in resolving when
4747 variable is not assigned.
4749 2008-05-05 Marek Safar <marek.safar@gmail.com>
4751 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4752 nullable operations.
4754 2008-05-04 Marek Safar <marek.safar@gmail.com>
4756 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4757 it saves many redundant temporary variables for nullable operations.
4759 2008-05-03 Marek Safar <marek.safar@gmail.com>
4761 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4763 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4766 * nullable.cs: Constant coalescing operator optimizations.
4768 2008-05-03 Marek Safar <marek.safar@gmail.com>
4770 * constant.cs: Use unsigned conversion for values which are unsigned only.
4772 2008-05-03 Marek Safar <marek.safar@gmail.com>
4774 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4775 coalescing operator as it should be.
4777 2008-05-02 Marek Safar <marek.safar@gmail.com>
4779 A fix for bug #371016
4780 * expression.cs: All predefined delegate operators require implicit method
4783 2008-05-02 Marek Safar <marek.safar@gmail.com>
4785 * constant.cs: Emit long constant as uint when fits the range.
4787 * convert.cs, expression.cs: Fixed few unsafe conversions.
4789 2008-05-02 Marek Safar <marek.safar@gmail.com>
4791 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4793 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4796 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4798 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4800 2008-05-01 Marek Safar <marek.safar@gmail.com>
4802 * constant.cs, literal.cs: IsLiteral property for error reporting.
4804 * ecore.cs, expression.cs: Implemented Property expression.
4806 2008-05-01 Marek Safar <marek.safar@gmail.com>
4808 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4810 * nullable.cs: Implemented nullable coalescing null operator.
4812 * ecore.cs, expression.cs: Expression trees work.
4814 2008-05-01 Marek Safar <marek.safar@gmail.com>
4816 * ecore.cs: CreateExpressionTree is finally abstract.
4818 * expression.cs, linq.cs: Updated.
4820 2008-05-01 Marek Safar <marek.safar@gmail.com>
4822 * expression.cs, ecore.cs: Block base access expression inside expression
4825 2008-05-01 Marek Safar <marek.safar@gmail.com>
4827 A fix for bug #385058
4828 * expression.cs: User-defined operator implementations always take
4829 precedence over predefined operator implementations.
4831 2008-04-30 Marek Safar <marek.safar@gmail.com>
4833 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4834 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4835 expression tree conversions.
4837 2008-04-30 Marek Safar <marek.safar@gmail.com>
4839 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4840 operators method details to Operator class.
4842 2008-04-30 Marek Safar <marek.safar@gmail.com>
4844 * anonymous.cs: Pass unsafe flags to anonymous container.
4846 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4847 inside expression tree.
4849 2008-04-29 Martin Baulig <martin@ximian.com>
4851 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4852 (Tokenizer.PopPosition): Also restore the `line'.
4854 2008-04-29 Marek Safar <marek.safar@gmail.com>
4856 * delegate.cs: Implemented Invoke expression.
4858 2008-04-29 Marek Safar <marek.safar@gmail.com>
4860 * expression.cs: Fixed equality reference comparison regression.
4862 2008-04-29 Marek Safar <marek.safar@gmail.com>
4864 * ecore.cs: Clean up EmptyCast hack.
4866 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4867 using correct conversion rules. Also fixes #383993.
4869 2008-04-28 Martin Baulig <martin@ximian.com>
4871 * class.cs (Constructor.Emit): Don't emit debugging information
4872 for generated default .ctor's.
4874 2008-04-28 Marek Safar <marek.safar@gmail.com>
4876 * convert.cs: Empty-cast ushort to int conversion.
4878 2008-04-28 Marek Safar <marek.safar@gmail.com>
4880 A fix for bug #384191
4881 * ecore.cs, expression.cs: Fixed expression cloning.
4883 2008-04-28 Marek Safar <marek.safar@gmail.com>
4885 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4887 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4889 Fix #381559, test-638.cs, test-639.cs
4890 * assign.cs (CompoundAssign.Helper): New wrapper.
4891 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4893 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4894 Pass unconverted expressions to the params array creation expression.
4895 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4896 (PropertyExpr.EmitAssign): Likewise.
4897 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4898 element if it is of kind CompoundAssign.Helper.
4899 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4900 first before anything else.
4901 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4902 (ArrayAccess.LoadArrayAndArguments): Simplify.
4904 2008-04-27 Marek Safar <marek.safar@gmail.com>
4906 * expression.cs: Fixed cloning of typeof(void).
4908 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4910 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4911 (Assign.Emit): Likewise. Move it to ...
4912 (CompoundAssign.DoResolve): ... here and ...
4913 (CompoundAssign.Emit): ... here.
4914 (EventAddOrRemove): New helper to handle += and -= on events, and
4915 avoid the use of BinaryDelegates.
4916 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4917 (EventExpr.EmitAddOrRemove): Improve.
4918 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4920 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4921 create VarExprs for 'foo.bar.var'.
4922 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4923 is a highly inappropriate name for its functionality.
4925 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4927 Simplify handling of multiple assignments
4928 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4930 (SimpleAssign): New. Class to be used for normal assignments.
4931 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4932 * expression.cs, parameter.cs, statement.cs: Likewise.
4934 2008-04-25 Marek Safar <marek.safar@gmail.com>
4936 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4937 for incompatible underlying types, more to come, uff.
4939 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4942 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4943 Handle 'leave_copy'.
4945 2008-04-25 Marek Safar <marek.safar@gmail.com>
4947 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4949 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4951 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4952 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4953 * statement.cs (While, Do, For): Allow test to have side effects.
4954 (For.DoEmit): Always emit InitStatement.
4957 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4958 Always create SideEffectConstant.
4959 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4960 of type EnumConstant.
4962 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4963 Handle 'right' being SideEffectConstant of type 'bool'.
4965 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4966 Use left.EmitBranchable instead of open coding it, so as to
4967 improve optimization opportunities.
4969 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4971 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4973 (Expression.EmitSideEffect): Document.
4975 2008-04-23 Marek Safar <marek.safar@gmail.com>
4977 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4979 2008-04-23 Marek Safar <marek.safar@gmail.com>
4981 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4983 2008-04-23 Marek Safar <marek.safar@gmail.com>
4985 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4986 conversion to expression tree.
4988 2008-04-23 Marek Safar <marek.safar@gmail.com>
4990 * ecore.cs: Removed unused expression.
4992 2008-04-22 Marek Safar <marek.safar@gmail.com>
4994 * expression.cs: Implemented NegateChecked and New expressions.
4996 2008-04-22 Marek Safar <marek.safar@gmail.com>
4998 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
5000 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
5003 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
5004 needing final 'ret' instruction.
5006 2008-04-22 Marek Safar <marek.safar@gmail.com>
5008 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
5010 2008-04-21 Marek Safar <marek.safar@gmail.com>
5012 * expression.cs: Emit ldnull and not null expression as an instance argument
5013 of static method expression calls.
5015 2008-04-21 Marek Safar <marek.safar@gmail.com>
5017 A fix for bug #378200
5018 * expression.cs: Fixed crash when creating parameterless expression tree
5021 2008-04-21 Marek Safar <marek.safar@gmail.com>
5023 A fix for bug #375297
5024 * anonymous.cs: Fixed crash when inferring from null argument anonymous
5027 2008-04-21 Marek Safar <marek.safar@gmail.com>
5029 A fix for bug #377596
5030 * decl.cs, class.cs: Emit delegate type argument attributes.
5032 2008-04-21 Marek Safar <marek.safar@gmail.com>
5034 A fix for bug #365314
5035 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
5037 2008-04-21 Marek Safar <marek.safar@gmail.com>
5039 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
5042 2008-04-21 Marek Safar <marek.safar@gmail.com>
5044 * generic.cs (TypeParameter): Removed redundant location.
5046 2008-04-19 Marek Safar <marek.safar@gmail.com>
5048 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
5049 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
5050 FullNamedExpression in all declaration type expression, statements will come
5053 2008-04-18 Marek Safar <marek.safar@gmail.com>
5055 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
5056 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
5058 2008-04-18 Marek Safar <marek.safar@gmail.com>
5060 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
5063 2008-04-17 Marek Safar <marek.safar@gmail.com>
5065 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
5068 2008-04-17 Marek Safar <marek.safar@gmail.com>
5070 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
5074 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
5076 Hook up 'EmitSideEffect'
5077 * constant.cs (Constant.EmitSideEffect): New.
5078 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
5079 (SideEffectConstant.EmitSideEffect): New.
5080 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
5081 unconditional branch in EmitBranchable.
5082 (FieldExpr.EmitBranchable): New.
5083 * expression.cs (Unary.EmitSideEffect): New.
5084 (Binary.EmitSideEffect): New.
5085 (VariableReference.EmitSideEffect): New. Do nothing.
5087 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5089 Introduce 'EmitSideEffect'
5090 * ecore.cs (Expression.EmitSideEffect): New.
5091 (TypeCast): Rename from EmptyCast.
5093 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
5094 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
5095 * convert.cs, nullable.cs: Update to changes.
5097 2008-04-16 Marek Safar <marek.safar@gmail.com>
5099 * class.cs, cs-parser.jay: Early check for base types expression.
5101 2008-04-16 Marek Safar <marek.safar@gmail.com>
5103 * decl.cs (MemberName): Declare PrettyName as obsolete.
5105 2008-04-16 Marek Safar <marek.safar@gmail.com>
5107 * namespace.cs: Use MemberName comparison.
5109 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5112 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
5114 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
5115 (MemberName.FullyQualifiedName): New. Provides the functionality
5116 that users assume FullName would have.
5117 * ecore.cs, namespace.cs: Update to changes.
5119 * statement.cs (Using.assign): Make into ExpressionStatement.
5120 (Using.EmitPreTryBody): Simplify.
5122 2008-04-16 Marek Safar <marek.safar@gmail.com>
5124 * report.cs: ColorFormat is protected.
5126 * rootcontext.cs: Unused fields clean-up.
5128 * namespace.cs: Made UsingEntry name private.
5130 2008-04-16 Marek Safar <marek.safar@gmail.com>
5132 * cs-tokenizer.cs, location.cs: Removed unused field.
5134 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
5135 Raja R Harinath <harinath@hurrynot.org>
5138 * constant.cs (SideEffectConstant.value): Rename from 'left'.
5139 (SideEffectConstant.side_effect): Rename from 'right'.
5140 (SideEffectConstant..ctor): Normalize 'side_effect'.
5141 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
5142 value of this constant.
5143 * cfold.cs: Update to changes.
5145 2008-04-15 Marek Safar <marek.safar@gmail.com>
5147 * cs-paser.jay: Removed unused variable.
5149 * driver.cs: Made Compile instance method.
5151 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
5153 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
5155 2008-04-15 Marek Safar <marek.safar@gmail.com>
5157 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
5159 2008-04-13 Jb Evain <jbevain@novell.com>
5161 * namespace.cs: update the System.Core fullname for 2.1
5162 * driver.cs: update the list of required assemblies for 2.1.
5163 Merged from the Moonlight 2 branch.
5165 2008-04-11 Marek Safar <marek.safar@gmail.com>
5167 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
5168 types and user defined operators. User operators arguments has to be checked
5169 for null value before invocation, which also means no operator is called
5170 when any argument is not convertible to unwrapped nullable type.
5172 2008-04-09 Marek Safar <marek.safar@gmail.com>
5174 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
5175 of Unary expressions to follow operator overloading rules precisely.
5176 Also fixes #321794, #323794
5178 2008-04-08 Marek Safar <marek.safar@gmail.com>
5180 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
5183 2008-04-08 Marek Safar <marek.safar@gmail.com>
5185 * expression.cs, ecore.cs: Implemented MemberInit expression.
5187 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
5189 Fix mono/tests/exception4.cs
5190 * statement.cs (ExceptionStatement, TryCatch): Revert to using
5191 ec.NeedReturnLabel () rather emitting a 'nop'.
5193 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
5195 (TryCatch.SomeCodeFollows): Likewise.
5196 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
5197 for 'break', 'continue' and 'return' statements inside a try.
5198 We're fairly sure that the generated IL stream will have more
5199 instructions textually following the try.
5200 (FlowBranchingTryCatch): Likewise.
5202 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
5203 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
5206 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
5207 wrapper -- forward everything to CollectionForeach.
5208 (CollectionForeach.NonDisposableWrapper): New.
5209 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
5210 instead of a pop + branch to end.
5212 2008-04-07 Marek Safar <marek.safar@gmail.com>
5214 A fix for bug #377485
5215 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
5216 Propagate location for extension method groups. Report conversion failure at
5219 2008-04-07 Marek Safar <marek.safar@gmail.com>
5221 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
5222 ListInit and Field expressions.
5224 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
5226 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
5227 Since $PC is always -1 inside the body of MoveNext, the fault
5229 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
5230 * statement.cs (ExceptionStatement.emit_finally): Likewise.
5231 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
5233 The denouement! Fix #324708
5234 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
5235 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
5236 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
5237 'finally' inside the finally clause.
5239 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
5240 inside an iterator. Don't emit the body of the 'finally' inside
5241 the finally clause yet.
5243 Use the ResumableStatement infrastructure for MoveNext ()
5244 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
5245 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
5246 'old_resume_points'. Move dispatcher upfront.
5247 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
5248 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
5249 in an enumerator. This encodes the main fix in this patch series
5250 -- we can only jump into the first instruction of a try from the
5251 outside, but we want to emit try/finally regions in iterators and
5252 resume in the middle of them.
5254 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
5256 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
5257 of NeedReturnLabel here.
5259 Introduce a common point for emitting try/finally to IL
5260 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
5261 features of the various subclasses, which are now driven by ...
5262 (ExceptionStatement.EmitPreTryBody): ... this and ...
5263 (ExceptionStatement.EmitTryBody): ... this and the original
5265 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
5266 Remove DoEmit and update to follow above protocol.
5268 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5269 of the dispatcher are the same, skip emitting the 'switch'.
5270 * iterator.cs (Iterator.EmitDispose): Update to changes.
5272 Clean up handling of 'using' statement
5273 * statement.cs (UsingTemporary): New. Carved out of ...
5274 (Using): ... this. Simplify drastically. Handle exactly
5276 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5277 or Using as appropriate. If there are multiple variable declared,
5278 create nested Using statements.
5279 (resource_acquisition): Kill.
5281 * statement.cs (ExceptionStatement.EmitForDispose): Use
5282 EmitFinallyBody, not EmitFinally.
5284 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5285 * iterator.cs: Update to changes.
5287 Start using the ResumableStatement infrastructure
5288 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5289 (ResumableStatement.EmitForDispose): New.
5290 (ExceptionStatement): Override them.
5291 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5292 EmitForDispose to create the body of the Dispose method. Don't
5295 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5296 * statement.cs (Toplevel.AddResumePoint): ... here.
5297 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5298 * flowanalysis.cs (FlowBranchingIterator): New.
5299 * codegen.cs (EmitContext): Update to changes.
5301 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5302 (Iterator.old_resume_points): Rename from 'resume_points'.
5303 (Iterator.MoveNextStatement): Remove unused class.
5305 New infrastructure for try/finally in iterators (still unused)
5306 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5307 (FlowBranchingToplevel.AddResumePoint): Hook into
5308 ToplevelBlock.AddResumePoint.
5309 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5310 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5311 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5312 resume points and assign program-counter values.
5313 (ExceptionBlock.AddResumePoint): Collect resume points for
5314 de-muxer at the top of try block.
5315 * iterators.cs (Yield.CheckContext): Simplify.
5316 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5318 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5320 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5321 argument to an ExitStatement.
5322 (FlowBranchingException): Refactor saved origins code.
5323 * statement.cs (ExitStatement): Update to cahges.
5324 * iterator.cs (YieldBreak): Likewise.
5326 * statement.cs (ResumableStatement): New. Common base class for
5327 YieldReturn and ExceptionStatement.
5328 (ExitStatement): New. Common base class for Return and YieldBreak.
5329 (Return): Update to changes.
5330 * iterator.cs (YieldBreak): Likewise.
5331 * lambda.cs (ContextualReturn): Likewise.
5334 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5335 emit a meaningful error message.
5337 Fix #324765, #319508
5338 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5339 (VariableInfo.SetAssigned): Set it.
5340 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5341 determine if CS0219 or CS0168 is appropriate. Don't use
5342 flow-analysis information.
5343 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5344 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5345 (EmitContext.EndFlowBranching): ... this.
5347 2008-04-03 Marek Safar <marek.safar@gmail.com>
5349 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5351 2008-04-03 Marek Safar <marek.safar@gmail.com>
5353 A fix for bug #376508
5354 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5355 ImplicitConversionExists.
5357 2008-04-03 Marek Safar <marek.safar@gmail.com>
5359 * expression.cs (Binary): Added remaining binary operators to expression
5362 * nullable.cs: Optimize shift with null argument.
5364 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5366 Fix minor IL regression
5367 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5368 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5369 * cs-parser.jay (try_statement): Update to changes.
5371 * statement.cs (TryFinally.need_exc_block): Delete.
5372 (TryFinally): Update to changes.
5374 Now all ExceptionStatements are unconditional
5375 * statement.cs (CollectionForeach.DisposableWrapper): New.
5376 Extract out the try/finally code into a new wrapper.
5377 (CollectionForeach.Resolve): Use it to simplify the code.
5379 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5381 Start at simplifying ExceptionStatement semantics a bit
5382 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5383 * cs-parser.jay (try_statement): Update to changes.
5384 (opt_catch_clauses): Remove.
5385 * flowanalysis.cs: Update to changes.
5386 (FlowBranching.BranchingType.TryCatch): New.
5387 (FlowBranchingTryCatch): New.
5389 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5390 (FlowBranching.CreateBranching): Update to changes.
5391 (FlowBranchingBlock.AddSibling): Add sanity check.
5392 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5395 * iterators.cs (Iterator.MarkFinally): Remove.
5396 * statement.cs (ExceptionStatement): Update to changes.
5398 Add support for skipping over finally blocks at runtime. First
5399 in a series to fix #324708
5400 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5401 (Iterator.EmitMoveNext): Initialize it.
5402 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5403 branch over the body of the 'finally' clause.
5405 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5407 Avoid lopsided use of Foo/DoFoo names
5408 * statement.cs (ExpressionStatement.EmitFinallyBody):
5409 Rename from EmitFinally.
5410 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5411 * iterator.cs: Update to changes.
5413 2008-04-02 Marek Safar <marek.safar@gmail.com>
5415 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5416 based on UserOperatorCall. More binary nullable operators clean up.
5418 2008-04-02 Martin Baulig <martin@ximian.com>
5420 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5422 2008-04-02 Marek Safar <marek.safar@gmail.com>
5424 * nullable.cs: Merge user and empty conversions when lifting expression
5427 * expression.cs (StringConcat): Implemented expression tree representation.
5429 2008-04-01 Marek Safar <marek.safar@gmail.com>
5431 * nullable.cs: When lifting null literal and a user operator exists, no call
5434 2008-04-01 Marek Safar <marek.safar@gmail.com>
5436 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5439 2008-04-01 Marek Safar <marek.safar@gmail.com>
5441 * nullable.cs, expression.cs: Use namespace instead heavily nested
5442 monster abstract class.
5444 2008-04-01 Marek Safar <marek.safar@gmail.com>
5446 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5447 lifting of null literal and user operators. Clean up of some temporary
5450 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5452 Fix #368224, test-629.cs
5453 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5454 if it crossed an unwind-protect boundary.
5455 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5456 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5457 inside an unwind-protected region.
5458 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5459 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5460 'leave' instead of a 'br' if unwind-protected.
5461 (Iterator.EmitYieldBreak): Likewise.
5463 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5465 * driver.cs: Only define versioninfo resources if no win32 resource
5468 2008-03-28 Marek Safar <marek.safar@gmail.com>
5470 A fix for bug #372375
5471 * convert.cs: Fixed boxing of nullable types.
5473 2008-03-28 Marek Safar <marek.safar@gmail.com>
5475 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5478 2008-03-28 Marek Safar <marek.safar@gmail.com>
5480 A fix for bug #374619
5481 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5483 2008-03-27 Marek Safar <marek.safar@gmail.com>
5485 * lambda.cs: Check return type only for invocation.
5487 2008-03-27 Marek Safar <marek.safar@gmail.com>
5489 A fix for bug #374214
5490 * ecore.cs: Correctly report argument type mismatch.
5492 2008-03-27 Marek Safar <marek.safar@gmail.com>
5494 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5495 and not rely on broken IsEnum.
5497 2008-03-27 Marek Safar <marek.safar@gmail.com>
5499 * nullable.cs: New file, extracted from generic.cs.
5501 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5503 2008-03-27 Marek Safar <marek.safar@gmail.com>
5505 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5506 predefined comparison operators and null literals.
5508 * report.cs: New warning ID.
5510 2008-03-25 Marek Safar <marek.safar@gmail.com>
5512 A fix for bug #370577
5513 * lambda.cs: Check return type too.
5515 2008-03-25 Marek Safar <marek.safar@gmail.com>
5517 A fix for bug #372846
5518 * class.cs: Automatic properties can be declared as unsafe.
5520 2008-03-20 Marek Safar <marek.safar@gmail.com>
5522 * location.cs: Use string based concatenation.
5524 * expression.cs: LiftedBinaryOperator is gmcs only.
5526 2008-03-20 Marek Safar <marek.safar@gmail.com>
5528 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5529 conversions rules and expression trees.
5531 2008-03-19 Marek Safar <marek.safar@gmail.com>
5533 * delegate.cs: Use extension method source as delegate target.
5535 2008-03-19 Marek Safar <marek.safar@gmail.com>
5537 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5538 binary operations to be purely based on binary operations and optimized
5539 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5540 and other ET refactoring.
5542 * typemanager.cs: Fixed warning.
5544 2008-03-17 Marek Safar <marek.safar@gmail.com>
5546 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5548 * symbolwriter.cs: Fixed.
5550 2008-03-17 Marek Safar <marek.safar@gmail.com>
5552 * anonymous.cs, driver.cs: Reset anonymous types counters.
5554 2008-03-17 Marek Safar <marek.safar@gmail.com>
5556 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5558 * class.cs: Use fullname for all type member definitions.
5560 2008-02-19 Martin Baulig <martin@ximian.com>
5563 (IMethodData.EmitExtraSymbolInfo): New interface method.
5564 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5565 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5566 interface method here as an empty public virtual method.
5569 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5570 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5571 CodeGen.SymbolWriter.SetRealMethodName().
5573 2008-02-18 Martin Baulig <martin@ximian.com>
5576 (ScopeInfo.EmitType): Override this and emit debugging
5577 information for captured variables.
5578 (RootScopeInfo.EmitType): Override this and emit symbol
5579 information for a captured `this'.
5581 2008-02-15 Martin Baulig <martin@ximian.com>
5583 * iterators.cs: Emit debugging info.
5586 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5587 (EmitContext.OmitDebuggingInfo): New public property.
5590 (While): Override Emit() and don't emit symbol info there; do it
5591 inside DoEmit() instead.
5592 (Block.Emit): Omit symbol information while emitting the scope
5593 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5595 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5596 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5597 .ctor to make `IsIterator' work.
5599 2008-03-14 Martin Baulig <martin@ximian.com>
5601 * symbolwriter.cs: Added the new symbol writer function from the
5602 debugger's `terrania' branch; temporarily enclose them inside
5603 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5606 2008-03-14 Martin Baulig <martin@ximian.com>
5609 (SymbolWriter): Make this a public static class.
5612 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5613 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5615 2008-03-14 Marek Safar <marek.safar@gmail.com>
5617 A fix for bug #370577
5618 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5621 2008-03-14 Marek Safar <marek.safar@gmail.com>
5623 * typemanager.cs (CSharpName): Made 250 times faster.
5625 2008-03-13 Marek Safar <marek.safar@gmail.com>
5627 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5629 2008-03-12 Marek Safar <marek.safar@gmail.com>
5631 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5632 crash when predefined field does not exist.
5634 2008-03-12 Marek Safar <marek.safar@gmail.com>
5636 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5638 2008-03-12 Marek Safar <marek.safar@gmail.com>
5640 * class.cs (FixedField): Don't crash when contructors are missing.
5642 2008-03-11 Marek Safar <marek.safar@gmail.com>
5644 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5645 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5646 check internal types accessibility for internal and external types.
5647 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5649 2008-03-11 Marek Safar <marek.safar@gmail.com>
5651 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5652 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5653 attribute.cs, statement: Use corect instance of predefined types (work
5654 related to #364674).
5656 2008-03-07 Marek Safar <marek.safar@gmail.com>
5658 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5660 2008-03-07 Marek Safar <marek.safar@gmail.com>
5662 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5663 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5664 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5665 predefined types clean up, delayed predefined types members initialization
5666 (work related to #364674).
5668 2008-03-05 Marek Safar <marek.safar@gmail.com>
5670 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5672 2008-03-05 Marek Safar <marek.safar@gmail.com>
5674 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5675 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5676 predefined types clean up (work related to #364674).
5678 2008-03-04 Marek Safar <marek.safar@gmail.com>
5680 * ecore.cs: Print an error message instead of throwing exception.
5682 2008-03-04 Marek Safar <marek.safar@gmail.com>
5684 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5685 expression.cs, statement.cs: Unififed null literal representation.
5687 2008-03-03 Marek Safar <marek.safar@gmail.com>
5689 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5690 expression.cs: Refactored binary operators resolve phase and improved speed.
5691 The nullable code is still missing and won't work correctly, more fixes
5694 It also fixes #323726, #324312, #324248, and many other unreported issues.
5696 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5698 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5701 2008-02-27 Marek Safar <marek.safar@gmail.com>
5703 * ecore.cs: Clean-up and split BetterConversion.
5705 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5708 * enum.cs (EnumMember.Value): Only access 'value' if
5709 ResolveValue says it's ok.
5710 (EnumMember.DoResolveValue): Don't set prev_member.value.
5711 (Enum.GetDefinition): Reverse arguments of Equals --
5712 EnumMember.Value can return 'null'.
5714 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5716 2008-02-22 Marek Safar <marek.safar@gmail.com>
5718 * generic.cs, expression.cs: More ongoing work on expression trees.
5720 2008-02-21 Marek Safar <marek.safar@gmail.com>
5722 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5723 handle missing matches when mutiple operators exist.
5725 2008-02-20 Marek Safar <marek.safar@gmail.com>
5727 A fix for bug #363218
5728 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5731 2008-02-20 Marek Safar <marek.safar@gmail.com>
5733 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5734 update. This time to deal correctly with SideEffectConstant expression used
5735 as an argument for another constant folding.
5737 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5739 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5742 2008-02-19 Marek Safar <marek.safar@gmail.com>
5744 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5746 2008-02-19 Marek Safar <marek.safar@gmail.com>
5748 A fix for bug #328136
5749 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5750 side is a false constant, because we still need to evaluate the right-hand
5753 * statement.cs (If): Emit two types of boolean constants (simple constant,
5754 side-effect constant).
5756 2008-02-19 Marek Safar <marek.safar@gmail.com>
5758 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5760 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5763 2008-02-18 Marek Safar <marek.safar@gmail.com>
5765 A fix for bug #361457
5766 * ecore.cs (IsApplicable): Params methods have lower priority.
5768 * support.cs: Return correct parameter modifier for params types.
5770 2008-02-18 Marek Safar <marek.safar@gmail.com>
5772 * generic.cs (TypeParameter): Cache attribute target name.
5774 * support.cs: Removed unused variable.
5776 * typemanager.cs: Removed debugging leftover.
5778 * ecore.cs: Use local type instead of a property;
5780 * class.cs (VerifyMembers): Consider also parent to test whether type member
5783 * expression.cs (FullMethodDesc): Removed.
5785 * attribute.cs (IsValidArgumentType): Made static.
5787 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5789 Cleanup to be more readable.
5790 * Makefile (GMCS_PROFILE): Remove.
5791 (COMPILER_NAME): New helper.
5793 2008-02-15 Miguel de Icaza <miguel@novell.com>
5795 * cs-tokenizer.cs: if a conditional expression happens inside a
5796 (...) this also means that we do not need to de-ambiguate between
5797 an parenthesized expression and a cast.
5801 * constant.cs (SideEffectConstant): a constant value that happens
5802 to have a side effect.
5804 Fixes the build regressions introduced by the fix for #359789
5806 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5808 * expression.cs (Conditional.Emit): when emitting the ternary
5809 operator, use local variables to generate code verifiable code.
5811 The verifier cannot infer that the type on stack before the
5812 stloc.0 is executed is of type ParentB. This happens because the
5813 stack merge algorithm uses only parent types when deciding which
5814 is the common type. This is described in Part III 1.8.1.3 of ECMA
5817 This code compiled with mcs is not verifiable under MS. The MS
5818 verifier picks the first common interface of Foo and Bar, which is
5819 wrong, but doesn't use a full join type of the 2 interfaces.
5821 CSC uses a clever hack to compile such code in a verifiable
5822 way. It stores the intermediate values in a local variable with
5827 2008-02-14 Miguel de Icaza <miguel@novell.com>
5829 * expression.cs: Do not fold BitwiseAnd operators when the left
5830 side is a false constant, because we still need to evaluate the
5835 * support.cs: Instead of throwing an InternalErrorException when
5836 the position of the stream is outside the boundary of our buffer,
5837 reset the state of the reader, and restart the reading from the
5838 beginning of the file.
5840 2008-02-14 Marek Safar <marek.safar@gmail.com>
5842 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5844 2008-02-14 Marek Safar <marek.safar@gmail.com>
5846 A fix for bug #361686
5847 * decl.cs: A protected types used inside a private class which parents
5848 derives from the protected class are accessible.
5850 2008-02-13 Marek Safar <marek.safar@gmail.com>
5852 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5853 the parameterless constructor.
5855 2008-02-13 Marek Safar <marek.safar@gmail.com>
5857 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5858 lookup methods to use standard member cache when doing member lookup.
5860 2008-02-12 Marek Safar <marek.safar@gmail.com>
5862 * driver.cs: Don't report full path for referenced module as assembly error.
5864 2008-02-12 Marek Safar <marek.safar@gmail.com>
5866 * Makefile: Fixed `qh' target to work on all machines.
5868 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5869 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5870 and HasElementType with TypeManager implementation.
5872 2008-02-08 Marek Safar <marek.safar@gmail.com>
5874 A fix for bugs #325134, #359749
5875 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5876 first binds point to non-method member expression.
5878 2008-02-08 Marek Safar <marek.safar@gmail.com>
5880 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5882 2008-02-08 Marek Safar <marek.safar@gmail.com>
5884 A fix for bugs #321394, #323028
5885 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5886 Reworked naive IsAccessibleAs implementation to handle nested types.
5888 2008-02-05 Jb Evain <jbevain@novell.com>
5890 * class.cs: use generic type comparison for parameters
5893 2008-02-05 Marek Safar <marek.safar@gmail.com>
5895 A fix for bug #325372
5896 * class.cs: Use generic type comparison when testing method signatures.
5898 2008-02-05 Marek Safar <marek.safar@gmail.com>
5900 A fix for bug #357047
5901 * ecore.cs: Applied C# 3.0 changes to better conversion.
5903 2008-02-05 Marek Safar <marek.safar@gmail.com>
5905 A fix for bug #358374
5906 * cs-parser.jay: Correctly set modifiers for all constructor types.
5908 2008-02-04 Marek Safar <marek.safar@gmail.com>
5910 A fix for bug #355251
5911 * generic.cs: Added base class constraint based type inference.
5913 2008-02-01 Marek Safar <marek.safar@gmail.com>
5915 A fix for bug #357255
5916 * decl.cs: One more missing visibility check.
5918 2008-02-01 Marek Safar <marek.safar@gmail.com>
5920 * support.cs: Fixed broken return.
5922 2008-01-25 Marek Safar <marek.safar@gmail.com>
5924 * report.cs: Correctly reset warnings count after probing.
5926 2008-01-25 Martin Baulig <martin@ximian.com>
5929 (NamespaceEntry.SymbolFileID): Make this work again after
5930 MemberName.ToString() is gone.
5932 2008-01-25 Marek Safar <marek.safar@gmail.com>
5934 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5937 2008-01-25 Marek Safar <marek.safar@gmail.com>
5939 * generic.cs: Use full implicit conversion for type inference fixing.
5941 2008-01-24 Marek Safar <marek.safar@gmail.com>
5943 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5944 Fixed user operator conversions.
5946 2008-01-24 Marek Safar <marek.safar@gmail.com>
5948 * generic.cs: Do nullable type to null comparison optimization during
5951 2008-01-24 Marek Safar <marek.safar@gmail.com>
5953 A fix for bug #355163
5954 * generic.cs: Enabled l-value resolve on nullable expressions.
5956 2008-01-24 Marek Safar <marek.safar@gmail.com>
5958 A fix for bug #353986
5959 * class.cs: Ingore static ctors with parameters for any further checks.
5961 2008-01-24 Marek Safar <marek.safar@gmail.com>
5963 A fix for bug #354310
5964 * namespace.cs: Removed redundant check.
5966 2008-01-24 Marek Safar <marek.safar@gmail.com>
5968 A fix for bug #354928
5969 * expression.cs: ElementInitializers can be resolved only once.
5971 2008-01-24 Marek Safar <marek.safar@gmail.com>
5973 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5974 Condition expressions.
5976 2008-01-23 Marek Safar <marek.safar@gmail.com>
5978 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5980 2008-01-22 Marek Safar <marek.safar@gmail.com>
5982 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5985 * generic.cs: Implemented coalesce expression.
5987 2008-01-22 Marek Safar <marek.safar@gmail.com>
5989 A fix for bug #355145
5990 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5991 expression tree type inference.
5993 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5996 * expression.cs (Binary.IsUnsignedType): Fix typo.
5998 2008-01-22 Marek Safar <marek.safar@gmail.com>
6000 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
6002 2008-01-22 Marek Safar <marek.safar@gmail.com>
6004 A fix for bug #355161
6005 * ecore.cs, expression.cs: Wider range of extension method supported
6008 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
6010 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
6011 AssemblyBuilder to operate in compiler context. Fixes mcs part of
6014 2008-01-22 Marek Safar <marek.safar@gmail.com>
6016 A fix for bug #355148
6017 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
6019 2008-01-22 Miguel de Icaza <miguel@novell.com>
6021 * expression.cs (CreateExpressionTree): Add support for or and
6022 logical or, and indent following the coding conventions.
6024 * typemanager.cs (LinqExpression): renamed from
6025 ExpressionTreeManager, for a shorter name.
6027 Use TypeManager.CoreLookupType to lookup types from our core
6028 assemblies and turn those into "Type" variables.
6030 Consumers that previously used "Namespace" and "Type" from this
6031 class should instead use the TypeExpression which is a type that
6032 is fully resolved (without involving the regular C# resolution
6035 This typically looks like this:
6037 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
6038 new MemberAccess (texpr, name, type_arguments, loc)
6040 This avoids the problem in: #355178
6042 2008-01-21 Marek Safar <marek.safar@gmail.com>
6044 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
6045 feature in parser only as we do in other cases.
6047 2008-01-21 Marek Safar <marek.safar@gmail.com>
6049 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
6050 typemanager.cs: A refactoring of params arguments to reuse existing
6051 expressions (params -> array initializer) to emit params argument instead
6052 of specialized handling.
6053 It was required by expression tree implementation and it has other benefits
6054 as well, we now apply same optimization for params arguments as we do for
6057 2008-01-18 Marek Safar <marek.safar@gmail.com>
6059 A fix for bug #353526
6060 * generic.cs: A type inference of params arguments may not required any
6061 temporary array creation.
6063 2008-01-18 Marek Safar <marek.safar@gmail.com>
6065 A fix for bug #353534
6066 * generic.cs, ecore.cs, expression.cs: A method group type inference is
6067 supported for delegates only.
6069 2008-01-18 Marek Safar <marek.safar@gmail.com>
6071 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
6072 type for more than 1 candidates.
6074 2008-01-18 Marek Safar <marek.safar@gmail.com>
6076 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
6079 2008-01-16 Marek Safar <marek.safar@gmail.com>
6081 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
6082 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
6083 operator) expressions.
6085 2008-01-16 Zoltan Varga <vargaz@gmail.com>
6087 * statement.cs: Avoid declaring an IL variable for this_variable since it is
6088 not accessed from the generated IL.
6090 2008-01-14 Marek Safar <marek.safar@gmail.com>
6092 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
6093 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
6094 statement.cs: The first expression tree implementation drop, mostly
6095 infrastructure work.
6097 2008-01-14 Marek Safar <marek.safar@gmail.com>
6099 * ecore.cs (IsNestedChild): Refactored.
6101 2008-01-11 Marek Safar <marek.safar@gmail.com>
6103 * lambda.cs: Don't use a cast on unknown expression statement.
6105 2008-01-10 Geoff Norton <gnorton@novell.com>
6107 * cs-tokenizer.cs: One more token to distinguish between method and lambda
6110 2008-01-09 Marek Safar <marek.safar@gmail.com>
6112 * doc.cs: Report better /doc crash details.
6114 2008-01-09 Marek Safar <marek.safar@gmail.com>
6116 A fix for bug #352536
6117 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
6119 2008-01-08 Marek Safar <marek.safar@gmail.com>
6121 A fix for bug #352287
6122 * ecore.cs, expression.cs: Do `this' access checking in all member access
6125 2008-01-08 Marek Safar <marek.safar@gmail.com>
6127 * rootcontext.cs, driver.cs: Switch to linq mode by default.
6129 * report.cs: Reset message stacks.
6131 2008-01-08 Marek Safar <marek.safar@gmail.com>
6133 * generic.cs (InferInPhases): Correctly calculate params position.
6135 2008-01-08 Marek Safar <marek.safar@gmail.com>
6137 * cs-tokenizer.cs: No need to parse full string when parsing lambda
6140 2008-01-07 Marek Safar <marek.safar@gmail.com>
6142 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
6144 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
6146 * driver.cs: Updated --help option.
6148 2008-01-07 Marek Safar <marek.safar@gmail.com>
6150 * generic.cs (InferParamsTypeArguments): Removed.
6151 (InferInPhases): Add params type inference.
6152 (LowerBoundInference): Fixed scoring mechanism.
6154 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
6156 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
6158 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
6159 byte array for unsigned "baked" assemblies.
6161 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
6163 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
6164 array for assemblies that are not strongnamed.
6166 2008-01-04 Marek Safar <marek.safar@gmail.com>
6168 A fix for bug #351481
6169 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
6170 declaring type for nested generic types.
6172 2008-01-04 Marek Safar <marek.safar@gmail.com>
6174 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
6175 instead of ToString.
6177 2008-01-03 Marek Safar <marek.safar@gmail.com>
6179 A fix for bug #351047
6180 * expression.cs (Binary.ResolveOperator): Allow equality operators between
6181 null and structs only when equality and inequality operators are defined
6182 either as an user-operators or predefined operators.
6184 2008-01-03 Marek Safar <marek.safar@gmail.com>
6186 A fix for bug #351047
6187 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
6189 2008-01-03 Marek Safar <marek.safar@gmail.com>
6191 A fix for bug #351257
6192 * cs-tokenizer.cs: Advance line number for '\r' correctly.
6194 2008-01-03 Marek Safar <marek.safar@gmail.com>
6196 A fix for bug #351157
6197 * class.cs (Using): Fixed yet another broken cloning.
6199 (Block): Put back more sensible default value for statements.
6201 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
6203 * codegen.cs: Allow AssemblyVersion with only major version component.
6206 2007-12-29 Marek Safar <marek.safar@gmail.com>
6208 A fix for bug #324654
6209 * class.cs: Use FullName property as member name.
6211 2007-12-28 Marek Safar <marek.safar@gmail.com>
6213 A fix for bug #342117
6214 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
6215 constructor constraint.
6217 2007-12-28 Marek Safar <marek.safar@gmail.com>
6219 A fix for bug #338273
6220 * class.cs (ProbertyBase): Access modifier checks are required for overrides
6223 2007-12-28 Marek Safar <marek.safar@gmail.com>
6225 A fix for bug #350839
6226 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
6228 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6230 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6233 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6235 * statement.cs: Changed some Hashtables to use HybridDictionaries
6236 instead. It was observed that some HashTables only contained a few
6237 items in the vast majority of cases. Since HybridDictionary is
6238 more efficient on small sets (<10 elements), "known_variables"
6239 from class ExplicitBlock as well as "labels" and "constants " from
6240 class Block were changed to HybridDictionaries.
6242 Atsai results: (56216kb->54987kb)
6244 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
6247 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6249 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6252 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6254 * expression.cs: foreach loop to for loop, saved on allocation of
6255 enumerator (59333kb->59141kb)
6257 * statement.cs. Changed foreach loops to for loops, saved on
6258 allocation of enumerator (59141kb->59006kb)
6260 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
6261 when constructed with no specified capacity. This was causing a
6262 few ArrayLists to allocate more memory than they would potentially
6263 need in the Block class and MemberCache class. Setting the
6264 ArrayLists to construct with a capacity of 1 saves some
6265 memory. (56216kb->55585kb)
6267 2007-12-27 Marek Safar <marek.safar@gmail.com>
6269 A fix for bug #347189 (2nd issue)
6270 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6273 2007-12-27 Miguel de Icaza <miguel@novell.com>
6275 * report.cs: Do not use colors if stdout and stderr are not a
6278 2007-12-27 Marek Safar <marek.safar@gmail.com>
6280 A fix for bug #346998
6281 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6284 2007-12-27 Marek Safar <marek.safar@gmail.com>
6286 A fix for bug #343465
6287 * class.cs: Explicit method name for nested types uses dots only.
6289 2007-12-27 Marek Safar <marek.safar@gmail.com>
6291 A fix for bug #343707
6292 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6294 2007-12-27 Marek Safar <marek.safar@gmail.com>
6296 * ecore.cs: Report type inference errors only when arguments count matches
6299 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6301 * expression.cs, report.cs: New warning.
6303 * typemanager.cs: Catch anonymous method type too.
6305 2007-12-23 Marek Safar <marek.safar@gmail.com>
6307 A fix for bug #346379
6308 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6310 2007-12-23 Marek Safar <marek.safar@gmail.com>
6312 A fix for bug #347359
6313 * expression.cs (Invocation): Don't resolve already resolved expression.
6315 2007-12-23 Marek Safar <marek.safar@gmail.com>
6317 A fix for bug #347189
6318 * class.cs (FixedField): Use non-dependent code only in the define phase.
6320 2007-12-23 Marek Safar <marek.safar@gmail.com>
6322 A fix for bug #348076
6323 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6325 2007-12-22 Marek Safar <marek.safar@gmail.com>
6327 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6328 discovered extension methods.
6330 2007-12-22 Marek Safar <marek.safar@gmail.com>
6332 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6335 2007-12-21 Miguel de Icaza <miguel@novell.com>
6337 * report.cs (ErrorMessage): Add support for using colors on
6338 terminals that support it.
6340 2007-12-21 Marek Safar <marek.safar@gmail.com>
6342 * ecore.cs: Use information about expanded params for error reporting.
6344 2007-12-21 Marek Safar <marek.safar@gmail.com>
6346 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6347 and logic for params overloads.
6349 2007-12-15 Miguel de Icaza <miguel@novell.com>
6351 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6352 as this is also created from the parser. Fixes #349034
6354 2007-12-12 Miguel de Icaza <miguel@novell.com>
6356 * statement.cs (Throw.CloneTo): it is valid to have empty
6357 expressions for throw.
6359 2007-12-03 Marek Safar <marek.safar@gmail.com>
6361 * cs-parser.jay: Set delegate constraint parsing region correctly.
6363 2007-12-03 Marek Safar <marek.safar@gmail.com>
6365 A fix for bug #345467
6366 * typemanager.cs (IsEqual): Compare generic parameters position only.
6368 2007-11-28 Marek Safar <marek.safar@gmail.com>
6370 * expression.cs (BaseAccess): Type arguments can be null.
6372 2007-11-27 Raja R Harinath <harinath@gmail.com>
6374 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6375 consistent even when an error has occured.
6376 (Switch.Resolve): Likewise.
6378 2007-11-22 Marek Safar <marek.safar@gmail.com>
6380 A fix for bug #334505
6381 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6384 2007-11-22 Marek Safar <marek.safar@gmail.com>
6386 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6387 refactorings required to resolve extension methods correctly when mixing
6388 generics and non-generics members.
6390 2007-11-20 Marek Safar <marek.safar@gmail.com>
6392 A fix for bug #342584
6393 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6396 2007-11-19 Marek Safar <marek.safar@gmail.com>
6398 A fix for bug #342512
6399 * delegate.cs: Use delegate argument expression when is available. Don't
6400 emit virtual call when class is sealed.
6402 2007-11-16 Marek Safar <marek.safar@gmail.com>
6404 A fix for bug #325423
6405 * assign.cs (FieldInitializer): Use resolved expression for emit.
6407 * class.cs: Print less confusing error message.
6409 2007-11-16 Marek Safar <marek.safar@gmail.com>
6411 * cs-tokenizer.cs: Removed GMCS ifdefs.
6413 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6416 * cs-parser.jay: Disabled nullable check.
6418 * generic-mcs: Copied more generic stuff.
6420 2007-11-16 Marek Safar <marek.safar@gmail.com>
6422 * gcs-parser.jay: Merged to cs-parser.jay.
6424 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6425 * *.csproj, *.sources: Updated to use only jay parser file.
6427 2007-11-16 Marek Safar <marek.safar@gmail.com>
6429 * gcs-parser.jay: Added nullable and default expression feature checks.
6431 2007-11-16 Marek Safar <marek.safar@gmail.com>
6433 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6434 it fixes many TODOs and hidden bugs.
6436 * expression: Removed duplicate error check.
6438 2007-11-15 Marek Safar <marek.safar@gmail.com>
6440 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6441 implicitly type local variable only when it is used in a declaration.
6443 2007-11-15 Marek Safar <marek.safar@gmail.com>
6445 * attribute.cs: Use CS0612 for empty strings.
6447 2007-11-14 Marek Safar <marek.safar@gmail.com>
6449 * lambda.cs, statement.cs: Contextual return may act as a statement.
6451 2007-11-14 Marek Safar <marek.safar@gmail.com>
6453 A fix for a regression cause by #324222
6454 * class.cs: Don't report unused even when it implements an interface.
6456 2007-11-13 Marek Safar <marek.safar@gmail.com>
6458 A fix for bug #341205
6459 * ecore.cs, expression.cs: Method group expression cannot do static
6460 method access with an instance reference check before overloading takes
6463 2007-11-13 Marek Safar <marek.safar@gmail.com>
6465 A fix for bug #325359
6466 * class.cs: Use predictable name for automatically generated property.
6468 2007-11-12 Marek Safar <marek.safar@gmail.com>
6470 A fix for bug #324996
6471 * expression.cs (Is): Handle case where D is nullable and T is not
6474 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6476 2007-11-12 Marek Safar <marek.safar@gmail.com>
6478 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6479 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6480 Flush small error reporting changes.
6482 2007-11-09 Marek Safar <marek.safar@gmail.com>
6484 A fix for bug #324996
6485 * expression.cs: Rewrote Is expression implementation to work with
6486 generics, nullable types, anonymous method. A const result expression
6487 uses existing infrastructure instead of custom not fully-featured one.
6489 2007-11-08 Marek Safar <marek.safar@gmail.com>
6491 A fix for bug #340202
6492 * class.cs: Consider generics for volatile field.
6494 2007-11-08 Marek Safar <marek.safar@gmail.com>
6496 A fix for bug #335594
6497 * expression.cs: Use conversion rules when handling string addition.
6499 2007-11-07 Marek Safar <marek.safar@gmail.com>
6501 A fix for bug #336651
6502 * expression.cs: Fixed a crash when probing is on.
6504 2007-11-07 Marek Safar <marek.safar@gmail.com>
6506 A fix for bug #324242
6507 * covert.cs: Added a conversion from any nullable-type with an
6508 underlying enum-type to the type System.Enum.
6510 2007-11-07 Marek Safar <marek.safar@gmail.com>
6512 A fix for bug #324222
6513 * class.cs: Report all non-used event fields.
6515 2007-11-07 Marek Safar <marek.safar@gmail.com>
6517 A fix for bug #325161
6518 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6519 qualifier for generic types.
6521 2007-11-07 Marek Safar <marek.safar@gmail.com>
6523 A fix for bug #322971
6524 * expression.cs, ecore.cs: Added intermediate result value check for
6527 2007-11-07 Marek Safar <marek.safar@gmail.com>
6529 A fix for bug #324754
6530 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6531 when it was requested.
6533 2007-11-07 Marek Safar <marek.safar@gmail.com>
6535 A fix for bug #325101
6536 * expression.cs: Do type not value comparison for `is' expression.
6538 2007-11-07 Marek Safar <marek.safar@gmail.com>
6540 A fix for bug #320236
6541 * convert.cs: Don't apply user conversion on underlying target type.
6543 2007-11-06 Marek Safar <marek.safar@gmail.com>
6545 * expression.cs: Don't use unresolved expression for error reporting.
6547 2007-11-06 Marek Safar <marek.safar@gmail.com>
6549 A fix for bugs #337712, #324490
6550 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6551 overloading resolution too.
6553 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6554 the process consistent and more robust.
6556 * expression.cs, linq.cs, report.cs: Update.
6558 2007-11-02 Marek Safar <marek.safar@gmail.com>
6560 A fix for bug #332909
6561 * attribute.cs: Resolve attributes in correct context using error
6564 * rootcontext.cs: Define Obsolete attribute members as core members.
6566 2007-11-02 Marek Safar <marek.safar@gmail.com>
6568 * statement.cs: Removed unused methods.
6570 2007-10-31 Wade Berrier <wberrier@novell.com>
6572 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6573 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6576 2007-10-31 Marek Safar <marek.safar@gmail.com>
6578 A fix for bug #338102
6579 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6580 methods registered as non-generics.
6582 2007-10-31 Marek Safar <marek.safar@gmail.com>
6584 A fix for bugs #337712, #324490
6585 * delegate.cs: Delegate covariance and contravariance is not allowed for
6588 2007-10-31 Marek Safar <marek.safar@gmail.com>
6590 A fix for bug #337719
6591 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6594 2007-10-30 Marek Safar <marek.safar@gmail.com>
6596 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6598 2007-10-29 Marek Safar <marek.safar@gmail.com>
6600 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6603 2007-10-29 Raja R Harinath <rharinath@novell.com>
6605 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6607 2007-10-29 Marek Safar <marek.safar@gmail.com>
6609 A fix for bug #334652
6610 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6611 extension methods when we have not found the best candidate in normal
6614 2007-10-27 Marek Safar <marek.safar@gmail.com>
6616 * AssemblyInfo.cs: Keep up-to-date.
6618 2007-10-27 Marek Safar <marek.safar@gmail.com>
6620 * Makefile: Fixed generics compiler name.
6622 2007-10-27 Marek Safar <marek.safar@gmail.com>
6624 * lambda.test: removed, lambda parsing is done differently.
6626 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6628 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6630 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6632 2007-10-27 Marek Safar <marek.safar@gmail.com>
6634 * Makefile, *.sources : All C# compilers are in mcs folder.
6636 * *.cs: Use existing 2_1 define for smcs.
6638 2007-10-26 Marek Safar <marek.safar@gmail.com>
6640 A fix for bug #335847
6641 * assign.cs, expression.cs: Couple of changes to avoid creating a
6642 temporary variable for each object initializer assignment statement. It
6643 simplifies struct initialization too, otherwise two temporary variables
6645 Implemented optimization of redundant default element initializers.
6647 2007-10-25 Marek Safar <marek.safar@gmail.com>
6649 A fix for bug #336766
6650 * expression.cs (Class.CheckBase): Use generic name when method is
6653 2007-10-25 Marek Safar <marek.safar@gmail.com>
6655 A fix for bug #334737
6656 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6657 variable and not variable argument for prepared copies.
6659 2007-10-24 Marek Safar <marek.safar@gmail.com>
6661 A fix for bug #325110
6662 * class.cs, expression.cs, attribute.cs: Use open generic method when
6663 checking conditional attribute.
6665 2007-10-24 Marek Safar <marek.safar@gmail.com>
6667 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6668 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6669 FeatureIsNotAvailable.
6671 2007-10-24 Marek Safar <marek.safar@gmail.com>
6673 ** C# 3.0 Partial methods
6675 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6676 methods support. Because of member cache issue with generics only
6677 non-generics partial methods are fully supported.
6679 2007-10-23 Marek Safar <marek.safar@gmail.com>
6681 * class.cs, decl.cs: Rewrote member overloads check to cope with
6682 generics and to use member cache for member checking. It also improves
6683 performance and fixes remaining overloads issues.
6685 2007-10-20 Marek Safar <marek.safar@gmail.com>
6687 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6688 roottypes.cs, typemanager.cs:
6690 A member cache creation logic changed to add members immediately and
6691 not rely on fallback. The member cache is now only prefered way
6692 how to access and find type declaration members. It saves 5 MB of memory
6693 during MWF compilation and makes code ready for more optimizations and
6694 clean-ups, it's also a pre-requirement for partial methods.
6696 2007-10-18 Raja R Harinath <harinath@gmail.com>
6698 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6699 handling for generic parameters.
6701 2007-10-15 Marek Safar <marek.safar@gmail.com>
6703 * class.cs (FixedField): Removed redundant volatile check.
6705 2007-10-15 Marek Safar <marek.safar@gmail.com>
6707 * class.cs, decl.cs: Fixed overload members verification to do only one
6708 check per possible collision.
6710 2007-10-13 Marek Safar <marek.safar@gmail.com>
6712 A fix for bug #325478
6713 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6714 and create only one disposable flags container.
6716 2007-10-12 Marek Safar <marek.safar@gmail.com>
6718 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6719 * statement.cs (Fixed): Fixed variables cloning.
6721 2007-10-12 Marek Safar <marek.safar@gmail.com>
6723 A fix for bug #333342
6724 * class.cs (EventField): Don't mark value type event as synchronized.
6726 2007-10-12 Marek Safar <marek.safar@gmail.com>
6728 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6729 inference to identify best candidate method correctly.
6730 (ProperyExpr): A range variable is read only and cannot be modified.
6732 2007-10-11 Marek Safar <marek.safar@gmail.com>
6734 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6735 logic to identify best candidate method correctly.
6737 2007-10-11 Marek Safar <marek.safar@gmail.com>
6739 * location.cs (Equals, GetHashCode): Removed.
6741 2007-10-11 Marek Safar <marek.safar@gmail.com>
6743 * report.cs: Implemented message recorder. It is used mainly for lambda
6744 expressions to capture otherwise swallowed error messages.
6746 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6748 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6750 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6752 * expression.cs (MemberAccess): Always report lookup failure.
6754 * location.cs: Implemented Equals, GetHashCode.
6756 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6758 2007-10-10 Jb Evain <jbevain@novell.com>
6760 * codegen.cs: re-enable assembly version check.
6762 2007-10-09 Marek Safar <marek.safar@gmail.com>
6764 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6767 * namespace.cs (UsingAlias): Do correct version check.
6769 2007-10-08 Marek Safar <marek.safar@gmail.com>
6771 * expresison.cs, ecore.cs: Issue extension method error message when
6774 * rootcontext.cs: Added ISO_2 compiler mode option.
6776 2007-10-08 Marek Safar <marek.safar@gmail.com>
6778 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6781 2007-10-08 Marek Safar <marek.safar@gmail.com>
6783 * attribute.cs (GetString, GetBoolean): Work with both literal and
6786 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6787 Moved method overload specific methods to MethodGroupExpr.
6789 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6790 it should be less memory consuming.
6792 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6794 * codegen.cs: remove the assembly version check until the buildbot is
6797 2007-10-07 Jb Evain <jbevain@novell.com>
6799 * attribute.cs (Attribute.GetString): if the value
6800 expression is a StringConstant, return its string value.
6802 2007-10-07 Jb Evain <jbevain@novell.com>
6804 * typemanager.cs: add `assembly_version_attribute_type`.
6805 * codegen.cs: on attribute emission, check that the
6806 AssemblyVersionAttribute doesn't overflow.
6808 2007-10-05 Marek Safar <marek.safar@gmail.com>
6810 A fix for bug #324677
6811 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6812 parent container of a scope container with currently resolved one.
6814 2007-10-05 Marek Safar <marek.safar@gmail.com>
6816 A fix for bug #325534
6817 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6820 2007-10-05 Marek Safar <marek.safar@gmail.com>
6822 A fix for bug #327504
6823 * class.cs (Operator.Define): Refactored implicit and explicit user
6824 operator conversion rules.
6826 2007-10-05 Marek Safar <marek.safar@gmail.com>
6828 A fix for bug #327520
6829 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6831 2007-10-04 Marek Safar <marek.safar@gmail.com>
6833 A fix for bug #328022
6834 * class.cs (MethodData.Define): Use correct method to check whether
6835 a method implementents an accessor.
6837 2007-10-04 Marek Safar <marek.safar@gmail.com>
6839 A fix for bug #330069
6840 * statement.cs (Fixed.Resolve): Read the first array element only when
6841 an array is instantiated.
6843 2007-10-04 Marek Safar <marek.safar@gmail.com>
6845 * expression.cs, assign.cs, generics.cs: Print correct operator when
6846 compound assignment is used.
6848 2007-10-04 Marek Safar <marek.safar@gmail.com>
6850 A fix for bug #325841
6851 * expression.cs (ArrayAccess): Use full argument cloning only for
6852 string compound concatenation.
6854 2007-10-03 Marek Safar <marek.safar@gmail.com>
6856 A fix for bug #328774
6857 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6859 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6862 2007-10-03 Raja R Harinath <rharinath@novell.com>
6865 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6866 Event accessibility checks here. Remove some bogus code that
6867 accidently made GenericMethods work.
6868 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6870 2007-09-25 Marek Safar <marek.safar@gmail.com>
6872 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6874 * statement.cs (Block): Refactored AddVariable to allow error handling
6877 * generic.cs: New stub.
6879 2007-09-23 Marek Safar <marek.safar@gmail.com>
6881 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6884 2007-09-17 Marek Safar <marek.safar@gmail.com>
6886 * class.cs: Use partial container to record whether any partial part
6887 contains static field initializer and therefore default contructor has
6890 2007-09-14 Marek Safar <marek.safar@gmail.com>
6892 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6893 mono-list when only one of two partial parts has defined accessibility
6896 2007-09-14 Marek Safar <marek.safar@gmail.com>
6898 A fix for bug #82845
6900 * class.cs (TypeContainer): Set correct resolve context for all field
6903 2007-09-13 Marek Safar <marek.safar@gmail.com>
6905 * assign.cs: Fixed a crash when field is resolved twice with an error.
6907 * codegen.cs: Changed InFieldInitializer to be flag.
6909 * anonymous.cs, ecore.cs, expression.cs: Update after
6910 IsInFieldInitializer rename.
6912 * const.cs: Removed unused parameter.
6914 * class.cs: Changed the way how we resolve and emit field initializers.
6915 The field initilizers have to have access to contructor block to emit
6916 compiler generated code.
6918 2007-09-13 Marek Safar <marek.safar@gmail.com>
6920 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6921 generics use TypeContainer instead.
6923 2007-09-12 Marek Safar <marek.safar@gmail.com>
6925 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6927 * lambda.cs (ResolveParameters): Use more powerful
6928 InflateGenericArgument.
6930 * parameters.cs: Better exception message.
6932 2007-09-10 Marek Safar <marek.safar@gmail.com>
6934 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6935 correct expression block type.
6937 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6939 * expression.cs (Invocation): Extracted method group resolve to
6942 2007-09-07 Marek Safar <marek.safar@gmail.com>
6944 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6945 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6947 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6948 generic extension methods.
6950 2007-09-06 Marek Safar <marek.safar@gmail.com>
6952 A fix for bug #82676 (Do I get it right now?)
6953 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6954 object before a standard conversion is applied.
6956 2007-09-06 Marek Safar <marek.safar@gmail.com>
6958 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6961 2007-09-05 Marek Safar <marek.safar@gmail.com>
6963 A fix for bug #82676
6964 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6965 non-generic interface types.
6967 2007-09-05 Marek Safar <marek.safar@gmail.com>
6969 A fix for bug #82690
6970 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6972 2007-09-05 Marek Safar <marek.safar@gmail.com>
6974 A fix for bug #82571
6975 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6976 modifier for container based methods.
6978 2007-09-05 Marek Safar <marek.safar@gmail.com>
6980 A fix for bug #82676
6981 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6982 any interface-type T means to any of interface type T.
6984 2007-09-04 Marek Safar <marek.safar@gmail.com>
6986 * namespace.cs: We have 2 versions of System.Core assembly.
6988 2007-09-04 Marek Safar <marek.safar@gmail.com>
6990 A fix for bug #82652
6991 * class.cs (Class.GetClassBases): Compare types and not expressions.
6993 2007-09-04 Marek Safar <marek.safar@gmail.com>
6995 A fix for bug #82620
6996 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6997 actually never worked before.
6998 (IndexerAccess): Emit prepared arguments before they are modified.
7000 2007-09-04 Marek Safar <marek.safar@gmail.com>
7002 A fix for bug #82563
7003 * assign.cs: Revert wrong fix.
7005 * expression.cs (VariableReference.EmitAssign): Handle ref reference
7007 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
7008 Instead of ldelema/stdind we have to use temporary variables to handle
7009 cases like String.Concat (params string[]).
7011 2007-08-31 Marek Safar <marek.safar@gmail.com>
7013 * class.cs: EmitAttributes to Emit rename.
7015 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
7017 (MemberCore.HasClsCompliantAttribute): Don't depend on
7018 GetClsCompliantAttributeValue execution.
7020 2007-08-31 Marek Safar <marek.safar@gmail.com>
7022 * anonymous.cs: Use shorter type prefix.
7024 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
7027 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
7028 variables when probing is on.
7030 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
7031 unresolved variables.
7032 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
7033 handle transparent identifiers.
7035 2007-08-26 Marek Safar <marek.safar@gmail.com>
7037 * attribute.cs (IsClsCompliant): Add nullable types test.
7039 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
7041 * doc.cs : catch other types of exception than XmlException to
7042 report CS1570. Fixed bug #82565.
7044 2007-08-23 Marek Safar <marek.safar@gmail.com>
7046 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
7047 The number of delegate parameters has to match.
7048 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
7051 2007-08-21 Marek Safar <marek.safar@gmail.com>
7053 * anonymous.cs (AnonymousMethod): Generate private anonymous method
7054 to fix problem with private arguments.
7056 2007-08-20 Marek Safar <marek.safar@gmail.com>
7058 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
7060 * decl.cs (MemberName): Ignore generic type with no generic arguments.
7062 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
7063 empty. Add cloning suport.
7065 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
7067 2007-08-20 Marek Safar <marek.safar@gmail.com>
7069 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
7070 to create EmptyCast. It handles EmptyConstantCast specialization for
7073 2007-08-18 Marek Safar <marek.safar@gmail.com>
7075 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
7076 (EmitArrayArgument): One routine for array arguments.
7077 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
7079 2007-08-17 Marek Safar <marek.safar@gmail.com>
7081 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
7083 2007-08-17 Marek Safar <marek.safar@gmail.com>
7085 * anonymous.cs: MemberLookupFinal update.
7087 * class.cs (ConstructorInitializer): Is expression based.
7089 * delegate.cs: MethodGroupExpr update.
7091 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
7093 (Error_MemberLookupFailed): Customizable error override.
7094 (MethodGroupExpr): Keep queried type for later usage.
7095 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
7098 * expression.cs: Error_MemberLookupFailed refactoring.
7099 (New.DoResolve): Resolve as much as possible.
7100 (ElementInitializer.Error_MemberLookupFailed): Object initializer
7101 customization for invalid member types.
7103 * statement.cs: MethodGroupExpr update.
7105 2007-08-16 Marek Safar <marek.safar@gmail.com>
7107 * modifier.cs (Check): Check all modifiers and not only accessibility
7110 2007-08-16 Marek Safar <marek.safar@gmail.com>
7112 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
7113 type and not an expression.
7115 2007-08-16 Marek Safar <marek.safar@gmail.com>
7117 * statement.cs (Catch.Clone): Type and variable can be null.
7119 2007-08-16 Marek Safar <marek.safar@gmail.com>
7121 A fix for bug #81979
7122 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
7123 I am really not sure whether this is the best fix.
7125 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
7128 2007-08-14 Marek Safar <marek.safar@gmail.com>
7130 ** C# 3.0 Object and collection initializers (major re-write)
7132 * assign.cs (DoResolve): Initializers are not assign related.
7134 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
7135 used during collection or object initialization.
7137 * expression.cs (Error_InvalidArguments): Add initializers specific
7138 messages. More will come later because it requires some general
7140 (New.DoResolve): Better error handling for unsafe types.
7141 (EmptyExpressionStatement): New class.
7142 (ElementInitializer): An object initializer expression.
7143 (CollectionElementInitializer): A collection initializer expression.
7144 (CollectionOrObjectInitializers): A block of object or collection
7146 (NewInitialize): New expression with element/object initializers.
7148 * statement.cs: Reverted object/collection initializer hacks.
7150 * typemanager.cs (CSharpName): Filter __arglist type.
7152 2007-08-09 Marek Safar <marek.safar@gmail.com>
7154 ** C# 3.0 Anonymous Types (update to the latest standard)
7156 * expression.cs (Binary.ResolveOperator): Threat all null based types
7158 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
7159 (AnonymousTypeParameter): Updated.
7161 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
7162 (AnonymousTypeClass): New anonymous type container.
7164 * class.cs (AddField): Return operation result.
7166 * generic.cs: Another empty TypeArguments overload.
7168 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
7169 are stored at top of normal hierarchy.
7171 * typemanager.cs (CSharpName): Filter anonymous types.
7173 2007-08-09 Marek Safar <marek.safar@gmail.com>
7175 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
7176 as single Concat call. How could we miss that :-(
7178 2007-08-08 Marek Safar <marek.safar@gmail.com>
7180 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
7182 2007-08-07 Miguel de Icaza <miguel@novell.com>
7184 * expression.cs: Fix the previous commit, the creation of the
7185 arguments array list needs also to be conditional on the arguments
7188 * class.cs: Add a little bit of help to help narrow down problems.
7190 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
7191 not try to copy in that case.
7193 * driver.cs: When building SMCS, include a new different set of
7194 default assemblies here. Do this here so we can control whether
7195 to include the default assemblies with /noconfig.
7197 2007-08-03 Marek Safar <marek.safar@gmail.com>
7199 A fix for bug #81979
7200 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
7203 2007-08-03 Marek Safar <marek.safar@gmail.com>
7205 A fix for bug #82300
7207 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
7208 we are in probing scope.
7210 2007-08-03 Marek Safar <marek.safar@gmail.com>
7212 A fix for bug #82301
7214 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
7215 (Statement.CloneTo): Clone and not map children blocks.
7217 2007-08-03 Marek Safar <marek.safar@gmail.com>
7219 A fix for bug #82299
7221 * expression.cs (LocalVariableReference.CloneTo): Remap local info
7224 * statement.cs (Statement.CloneTo): Clone variables before statements
7225 to allow remaping of local variables.
7227 2007-08-03 Marek Safar <marek.safar@gmail.com>
7229 A fix for bug #82296
7232 * report.cs: Log crash details for future clone problems.
7234 * statement.cs (Return.Clone): Don't clone non-existent expression.
7236 2007-08-03 Raja R Harinath <harinath@gmail.com>
7238 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
7239 (Class.AddBasesForPart): Move CS0537 check here from ...
7240 * cs-parser.jay (class_declaration): ... here. Move calling of
7241 'AddBasesForPart' to ...
7242 (class_bases): ... here.
7243 (struct_declaration, interface_declaration): Update to changes.
7245 2007-08-02 Marek Safar <marek.safar@gmail.com>
7247 A fix for bug #81923
7249 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
7250 conversion is allowed.
7252 2007-08-02 Marek Safar <marek.safar@gmail.com>
7254 A fix for bug #81564
7256 * ecore.cs (EventExpr): Add IsBase handling.
7258 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
7261 2007-08-02 Raja R Harinath <harinath@gmail.com>
7263 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
7264 * cs-parser.jay: Some whitespace cleanups.
7265 (current_delegate): New.
7267 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
7268 a dummy code block, and use 'type_name' instead of 'member_name'.
7269 (interface_declaration, class_declaration): Likewise.
7270 (delegate_declaration): Likewise. Rearrange slightly and use
7272 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7273 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7275 2007-08-02 Marek Safar <marek.safar@gmail.com>
7277 A fix for bug #82039
7279 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7282 * typemanager.cs (CSharpName): Split to string overload.
7284 2007-08-02 Marek Safar <marek.safar@gmail.com>
7287 * report.cs: Updated warning CS0472.
7289 2007-08-01 Marek Safar <marek.safar@gmail.com>
7291 A fix for bug #82181
7293 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7295 2007-08-01 Marek Safar <marek.safar@gmail.com>
7297 A fix for bug #82277
7298 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7300 2007-08-01 Marek Safar <marek.safar@gmail.com>
7302 ** C# 3.0 Type Inference (major bits are working)
7304 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7305 (.ImplicitStandardConversionExists): Uses compatible.
7306 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7307 (.InferReturnType): New method.
7308 (.Compatible): Refactored.
7309 (.ResolveParameters): Uses factory to create resolved parameters.
7310 (.CompatibleMethod): Add probing mode support.
7311 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7312 clearly distinguish between 2 different operations.
7313 (LambdaMethod): Moved to lambda.cs.
7314 (AnonymousMethod): Removed unused fields and methods.
7315 (AnonymousDelegate): Simplified.
7317 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7319 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7321 * delegate.cs (Delegate): New mehods to reduce code duplication.
7322 (.GetConstructor): New method.
7323 (.GetInvokeMethod): New method.
7324 (DelegateCreation): Updated.
7326 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7328 (OverloadResolve): Made probing little bit faster.
7330 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7333 * generic.cs (TypeInferenceContext): Dummy implementation.
7335 * iterators.cs: Updated after Resolve/Define rename.
7337 * lambda.cs (LambdaExpression)
7338 (.ResolveParameters): Handles both type of arguments and type inference too.
7340 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7341 (InflateTypes): Updated.
7343 * support.cs (InflateTypes): Changed signature and updated.
7345 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7346 (MemberLookup_FindMembers): More MS tricks.
7347 (GetParameterData): Ditto.
7348 (GetDelegateParameters): Uses quick path for dynamic types.
7350 2007-08-01 Marek Safar <marek.safar@gmail.com>
7352 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7355 2007-07-31 Marek Safar <marek.safar@gmail.com>
7357 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7360 2007-07-26 Jb Evain <jbevain@novell.com>
7362 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7363 which takes a boolean 'report_errors', similar to the GetMethod.
7364 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7365 in .net 2.1, do not report errors here.
7367 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7368 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7369 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7372 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7373 of the type InternalsVisibleToAttribute before the first call
7374 to CoreLookupType which is allowed to fail (third boolean parameter
7375 to true). Because, during the resolution for a type that is not
7376 immediately found, we try to check if the type is not defined in
7377 a friend assembly, and to do so, we need the
7378 InternalVisibleToAttribute.
7380 2007-07-23 Miguel de Icaza <miguel@novell.com>
7382 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7383 feature that allows structs to be compared against null and inline
7384 the result as true or false.
7386 Notice that the same code is not permitted inside a generic block
7387 of code that would do:
7389 class Foo<T> where T : struct {
7396 It is only allowed if the type of T is not bound (no where
7397 clause). In my opinion, this CSC 2 behavior is broken but people
7398 seem to be using it (IronRuby does, a few bug reports on bugzilla
7399 have it and some people have complained about it).
7401 All of the users that depend on this behavior have code that is
7404 * report.cs (Warning, Error): make these take object arguments,
7405 not strings, as that allows us to take advantage of Format.
7407 2007-07-20 William Holmes <billholmes54@gmail.com>
7409 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7410 Left member variable for the Count.
7411 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7412 MemberName.CountTypeArguments to avoid a NRE.
7414 This code is contributed under the MIT X11 license
7416 2007-07-18 Marek Safar <marek.safar@gmail.com>
7418 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7420 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7422 * doc.cs : generic method arguments are written as ``x while generic
7423 type arguments are `x. Combined with the previous change, fixed bug
7426 2007-07-18 Raja R Harinath <rharinath@novell.com>
7429 * expression.cs (Binary.ResolveOperator): When converting
7430 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7432 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7434 * doc.cs : when T: or whatever x: is specified, it does not really
7435 check the doc comment's syntax correctness. Fixed bug #82006.
7437 2007-07-18 Marek Safar <marek.safar@gmail.com>
7439 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7440 LambdaExpression better.
7442 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7444 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7446 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7447 as it can be generated.
7449 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7452 * lambda.cs (LambdaExpression): Refactored to share same code with
7453 AnonymousMethodExpression.
7455 2007-07-17 Marek Safar <marek.safar@gmail.com>
7457 * anonymous.cs (MakeName): Include host name for easier debugging.
7458 (LambdaMethod): New class for lambda spcecific stuff.
7460 * attribute.cs: Set EmitContext return type.
7462 * class.cs: Set EmitContext return type.
7464 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7465 with null/void meaning.
7467 * iterators.cs (ContainerType): Implemented.
7469 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7471 * statement.cs (Return): Updated to lambda expressions.
7472 (Block.CloneTo): Parent can be null.
7474 2007-07-13 Marek Safar <marek.safar@gmail.com>
7476 A fix for bug #81917
7477 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7479 * class.cs (FixedField): Check whether field is in unsafe scope.
7481 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7482 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7484 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7487 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7489 2007-07-13 Marek Safar <marek.safar@gmail.com>
7491 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7492 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7495 2007-07-13 Marek Safar <marek.safar@gmail.com>
7497 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7499 2007-07-13 Marek Safar <marek.safar@gmail.com>
7501 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7502 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7504 * codegen.cs(EmitContext): Add ProbingMode flag.
7506 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7508 * driver.cs: For now set both warning values.
7510 * ecore.cs (SimpleName): Name is readonly.
7511 (MethodGroup.OverloadResolve): One quick path for probing.
7513 * expression.cs (Unary): Set Oper r/o.
7514 (Binary): Set Oper r/o.
7515 (ParameterReference): Set few instance variables as r/o.
7516 (ParameterReference.DoResolveBase): Don't capture aruments when
7518 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7519 (Arglist): arguments are private.
7520 (SizeOf): type is private and r/o.
7521 (MemberAccess): arguments are private.
7523 * report.cs: Enhanced reporting on/off capabilities.
7525 * lambda.cs: Uses ec.IsInProbingMode.
7526 (ContextualReturn): Derives from return.
7528 * rootcontext.cs: For now set both warning values.
7530 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7532 (Return.Resolve): Don't die immediately.
7533 (Block.Resolve): Speed-up probing.
7534 (Block.CloneTo): Clone only child blocks.
7536 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7538 * iterators.cs: reverted Miguel's latest change (r81925) as it
7539 breaks the build in System.
7541 2007-07-13 Miguel de Icaza <miguel@novell.com>
7543 * iterators.cs (Yield.CheckContext): Check for the iterator type
7544 also here as we can call into Yield even in codepaths that are not
7546 (MethodOrOperator is the only path that was checked).
7548 In addition to the standard check, use a more specific check for
7549 constructors to report a more verbose error.
7551 2007-07-12 Miguel de Icaza <miguel@novell.com>
7553 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7554 report the warning and continue
7556 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7557 values on the stack on the call to Emit. Use EmitStatement if
7558 possible, or using Emit + Pop if not possible. Fixes #82064
7560 2007-07-12 Raja R Harinath <rharinath@novell.com>
7562 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7563 avoid try...finally in some cases.
7565 2007-07-10 Marek Safar <marek.safar@gmail.com>
7567 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7569 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7570 instead of method. Re-use standard error handling.
7571 (ConstructorInitializer.Emit): Simplified.
7573 * delegate.cs: Updated after Invocation.EmitCall change.
7575 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7576 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7577 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7578 method and don't permanently changing input arguments.
7579 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7580 is resolved it has one of the candidates is the best one which is later
7581 used to emit. Removed a few unused method.
7582 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7584 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7585 (Binary.ResolveOperator): Ditto.
7586 (ConditionalLogicalOperator.DoResolve): Ditto.
7587 (Invocation): Uses method group.
7588 (Invocation.DoResolve): Simplified.
7589 (Invocation.EmitCall): Removed useless is_static.
7590 (Invocation.Emit): Delegate to method group.
7591 (Invocation.EmitStatement): Simplified.
7592 (New): Uses method group.
7593 (MemberAccess.DoResolve): Don't destroy original expression.
7595 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7597 2007-07-04 Marek Safar <marek.safar@gmail.com>
7599 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7602 * lambda.cs: Add custom error message type.
7604 2007-07-03 Marek Safar <marek.safar@gmail.com>
7606 * lambda.cs: Simplified little bit.
7608 * parameter.cs: Introduced ImplicitLambdaParameter.
7609 (Parameters.CreateFullyResolved): New factory instead of ctor.
7613 * delegate.cs: Updated parameter creation.
7615 2007-07-03 Marek Safar <marek.safar@gmail.com>
7617 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7620 * generic.cs: Synchronized with gmcs.
7622 2007-07-03 Marek Safar <marek.safar@gmail.com>
7624 * class.cs (Indexer): Check return type as soon as possible.
7626 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7629 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7631 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7633 * parameter.cs (Parameter): Use expression type when it is available.
7635 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7636 method modifier for the first parameter only.
7638 2007-06-24 Marek Safar <marek.safar@gmail.com>
7640 A fix for bug #81938
7641 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7643 * constant.cs: Tide up an exception message.
7645 2007-06-22 Marek Safar <marek.safar@gmail.com>
7647 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7648 an uninitialized variable is used.
7650 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7652 2007-06-22 Marek Safar <marek.safar@gmail.com>
7654 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7655 not found error handling.
7657 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7659 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7660 (ArrayCreation.DoResolve): Simplified.
7661 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7662 its own resolve process.
7663 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7665 2007-06-20 Marek Safar <marek.safar@gmail.com>
7667 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7670 2007-06-20 Marek Safar <marek.safar@gmail.com>
7672 * cs-tokenizer.cs: Removed var related stuff.
7674 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7675 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7676 a type and a keyword at same time.
7678 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7681 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7682 implicitly typed arrays, more changes will follow.
7684 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7686 2007-06-19 Marek Safar <marek.safar@gmail.com>
7688 * ecore.cs (VarExpr): Removed Handled field.
7690 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7691 build-in assign functionality.
7692 (ForEach.Resolve): Removed all implicitly typed local variable code and
7694 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7695 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7697 2007-06-18 Marek Safar <marek.safar@gmail.com>
7699 * assign.cs: Removed implicitly typed local variable check.
7701 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7702 referencing implicitly typed local variable.
7703 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7706 * statement.cs (Fixed): Removed unsupported implicitly typed local
7709 2007-06-15 Marek Safar <marek.safar@gmail.com>
7711 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7713 2007-06-14 Marek Safar <marek.safar@gmail.com>
7715 A fix for bugs #81855 and #76274
7716 * attribute.cs (AttachTo): Always set owner for global attributes to
7719 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7722 * cs-parser.jay: Assembly and module attributes must precede all other
7723 elements except using clauses and extern alias declarations.
7725 2007-06-13 Marek Safar <marek.safar@gmail.com>
7727 A fix for bug #81748
7729 * expression.cs: More checks for non ISO-1 features.
7731 2007-06-12 Marek Safar <marek.safar@gmail.com>
7733 A fix for bug #81807
7734 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7735 present inside switch statement and it is required by nullable check.
7737 2007-06-12 Marek Safar <marek.safar@gmail.com>
7739 A fix for bug #81840
7740 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7741 when type matching fails.
7743 * namespace.cs: Tiny error message change.
7745 2007-06-12 Marek Safar <marek.safar@gmail.com>
7747 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7748 reporting. Added automatic property check.
7750 * class.cs: Updated after CheckAbstractAndExtern relocation.
7751 (AEventPropertyAccessor.GetSignatureForError): Customized.
7753 2007-06-11 Marek Safar <marek.safar@gmail.com>
7755 * class.cs (DefineBaseTypes): Base type can be undefined.
7757 * ecore.cs (TypeLookup): Minor refactoring.
7758 (DoResolveAsTypeStep): Removed redundant check.
7760 * namespace.cs (Lookup): Removed redundant check.
7762 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7763 ResolveAsTypeTerminal step.
7764 (BootstrapCorlib_*): Simplified.
7765 (PopulateCoreType): Core types can be now external.
7767 2007-06-07 Marek Safar <marek.safar@gmail.com>
7769 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7771 (InferTypeArguments): Infers anonymous expression type arguments.
7772 (Compatible): Split to Compatible and InferTypeArguments.
7774 * lambda.cs: Updated.
7776 2007-06-08 Marek Safar <marek.safar@gmail.com>
7778 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7780 2007-06-07 Raja R Harinath <harinath@gmail.com>
7782 Fix #80477, cs0135-2.cs, cs0135-3.cs
7783 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7784 names to the "known" variables list.
7785 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7786 parameter names are also "known".
7787 (Block.CheckError136): Remove.
7788 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7791 2007-06-07 Marek Safar <marek.safar@gmail.com>
7793 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7795 2007-06-06 Marek Safar <marek.safar@gmail.com>
7797 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7798 internal error not an user error.
7800 * expression.cs (IsApplicable): Refactored to make debugging easier.
7802 * support.cs: More tricks for non-mono runtimes.
7804 * typemanager.cs (CoreLookupType): Made public.
7805 (InitSystemCore): All linq specific stuff moved to linq.cs
7807 2007-06-05 Marek Safar <marek.safar@gmail.com>
7809 * typemanager.cs (CSharpSignature): One more missing build-in types
7811 More tricks for non-mono runtime.
7813 2007-06-05 Raja R Harinath <harinath@gmail.com>
7815 * statement.cs (Block.CheckError136_InParents): Remove.
7816 (Block.AddVariable): Use GetParameterInfo instead.
7817 (ToplevelBlock.ProcessArguments): Likewise.
7819 2007-06-04 Raja R Harinath <rharinath@novell.com>
7821 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7823 (ToplevelBlock.GetParameterInfo): Split out of ...
7824 (ToplevelBlock.GetParameterRefernce): ... this.
7825 (ToplevelBlock.ParameterMap): Remove.
7826 * expression.cs (ParameterReference): Update to use
7827 ToplevelParameterInfo.
7829 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7832 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7833 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7835 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7836 (ToplevelBlock.ProcessParameters) ... here.
7837 (ToplevelBlock..ctor): Invoke it.
7839 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7842 * statement.cs (IKnownVariable): New interface.
7843 (LocalInfo): Implement it.
7844 (ToplevelParameterInfo): New class.
7845 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7846 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7847 GetKnownVariableInfo.
7849 2007-06-03 Raja R Harinath <harinath@gmail.com>
7851 Partly speed up CS0136 error checks.
7852 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7853 'recurse' parameter.
7854 (Block.DoCheckError136): Only check errors in parameters. Move
7855 local variable checks ...
7856 (Block.AddVariable): ... here, and ...
7857 (ToplevelBlock.ResolveMeta): ... here.
7859 2007-06-02 Raja R Harinath <harinath@gmail.com>
7861 * statement.cs (Block.IsChildOf): Remove.
7863 * statement.cs (Statement.Clone): Move special case code ...
7864 (Block.CloneTo): ... here.
7866 2007-05-29 Raja R Harinath <rharinath@novell.com>
7868 * statement.cs (ToplevelBlock.container): Remove field. It's
7869 redundant with 'Parent'.
7870 (ToplevelBlock.ContainerBlock): Remove accessor.
7871 (ToplevelBlock..ctor): Update to changes. Register anonymous
7872 child with parent here, ...
7873 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7875 (start_anonymous): Don't save current_block.
7876 (top_current_block): Remove.
7878 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7879 (Block.Resolve): Update to changes.
7880 (Block..ctor): Move setting of "correct" 'Toplevel'
7881 and 'Explicit' fields to ...
7882 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7884 2007-05-27 Raja R Harinath <harinath@gmail.com>
7887 * statement.cs (Block.Implicit): Remove.
7888 (Block): Update to changes.
7889 * flowanalysis.cs: Likewise.
7891 Mildly speed up CheckInvariantMeaningInBlock
7892 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7893 Recursively call AddKnownVariable to all enclosing blocks.
7894 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7895 Remove recursive calls.
7896 (Block): Update to changes.
7898 New ExplicitBlock invariants
7899 * statement.cs (Block.Explicit): New field. It points to the
7900 immediately enclosing non-implicit block.
7901 (Block..ctor): Maintain the invariant.
7902 * cs-parser.jay: Take advantage of invariant.
7904 Introduce ExplicitBlock
7905 * statement.cs (ExplicitBlock): New.
7906 (ToplevelBlock): Derive from it.
7907 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7909 (Block.Implicit): Update to changes.
7910 * cs-parser.jay: Update to changes.
7913 * codegen.cs (EmitContext.IsLastStatement): Remove.
7914 * statement.cs (Block.DoEmit): Update to changes.
7916 2007-05-25 Raja R Harinath <rharinath@novell.com>
7918 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7919 modifying current_block directly.
7921 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7923 * class.cs: Implemented automatic properties (C# 3.0)
7924 Thanks to Marek for the help.
7926 2007-05-23 Raja R Harinath <rharinath@novell.com>
7928 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7929 variable as assigned, note also that all its components are
7931 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7933 2007-05-19 Marek Safar <marek.safar@gmail.com>
7935 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7936 member is marked as compiler generated.
7938 * decl.cs (MemberCore): Refactored ModFlags into property.
7940 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7941 (Check): Check only accessibility modifiers.
7943 2007-05-18 Raja R Harinath <rharinath@novell.com>
7945 Track all assignable slots in one bit array
7946 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7947 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7948 logic from VariableMap constructor here. Use the same 'offset'
7949 variable that's later used for computing offsets of local
7951 * flowanalysis.cs (UsageVector.parameters): Remove.
7952 (UsageVector): Update to changes.
7953 (VariableMap): Remove.
7955 Avoid creating ParameterMap in every block
7956 * statement.cs (Block.ParameterMap): Move ...
7957 (ToplevelBlock.ParameterMap): ... here.
7958 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7960 * flowanalysis.cs (FlowBranching.param_map): Remove.
7961 (FlowBranching.UsageVector): Update to changes.
7962 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7964 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7966 * expression.cs (ParameterReference): Distinguish between block
7967 where parameter was referenced and declared.
7969 2007-05-18 Marek Safar <marek.safar@gmail.com>
7971 * flowanalysis.cs, statement.cs: Put back improved error handling.
7973 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7977 Imporved object and collection initialization (C# 3.0).
7979 2007-05-15 Marek Safar <marek.safar@gmail.com>
7981 A fix for bug #81380
7982 * expression.cs (Is.DoResolve): Only value types have constant `is'
7985 2007-05-15 Raja R Harinath <rharinath@novell.com>
7987 * statement.cs (ToplevelBlock.child): Remove.
7989 2007-05-15 Raja R Harinath <harinath@gmail.com>
7991 Rationalize ResolveMeta: refactoring
7992 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7993 out constant handling code into ...
7994 (Block.DoResolveConstants): ... this.
7996 Rationalize ResolveMeta: kill local_map
7997 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7998 (Block.AssignableSlots): New.
7999 (Block.ResolveMeta): Make protected. Don't create a VariableMap
8000 for locals -- move code from VariableMap here. Avoid unnecessary
8002 * flowanalysis.cs (FlowBranching.local_map): Remove.
8003 (FlowBranching..ctor): Use Block.AssignableSlots.
8004 (VariableMap): Remove unused constructors.
8006 2007-05-11 Raja R Harinath <rharinath@novell.com>
8008 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
8010 2007-05-11 Marek Safar <marek.safar@gmail.com>
8012 * typemanager.cs (IsFriendAssembly): Should not be called for building
8015 2007-05-09 Marek Safar <marek.safar@gmail.com>
8017 * literal.cs (NullConstant): Print null in all cases.
8019 * expression.cs (Binary.ResolveOperator): Implemented delegate
8020 comparison based on C# 2.0 changes.
8022 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
8024 This code is contributed under the MIT X11 license
8026 The following enables support for several C# 3.0 language features:
8028 * cs-tokenizer.cs: Added support for the "var" keyword.
8030 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
8031 Added VarExpr class to facilitate type inferencing.
8033 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
8034 to support anonymous types.
8036 * assign.cs: Added support for type inferencing and initialization.
8038 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
8040 * expression.cs: Added implicit array support to ArrayCreation.
8041 Added 5 types and 1 interface:
8043 IInitializable Implementing classes can inject initializing
8044 statements after object instantiation.
8046 Initializer Stores data for object initialization.
8048 AnonymousType An expression for anonymous types.
8050 AnonymousTypeParameter Stores data about an anonymous type's field.
8052 NewInitialize An expression for object initialization.
8054 CollectionInitialize An expression for collection initialization.
8056 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
8059 2007-05-06 Marek Safar <marek.safar@gmail.com>
8061 A fix for bug #81500
8062 * cs-tokenizer.cs: Add special handling for coalescing operator.
8064 2007-05-06 Marek Safar <marek.safar@gmail.com>
8066 A fix for bug #81529
8067 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
8068 its value from base class until it is redefined.
8070 2007-05-02 Raja R Harinath <rharinath@novell.com>
8072 Fix regression in cs0631-3.cs
8073 * cs-parser.jay (operator_declarator): Add opt_attributes to error
8074 fallback. Make error fallback catch more cases.
8076 2007-05-01 Miguel de Icaza <miguel@novell.com>
8078 * cs-parser.jay: Allow parameters in operator declarations to have
8081 2007-04-27 Miguel de Icaza <miguel@novell.com>
8083 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
8086 * lambda.cs (ContextualReturn.Resolve): An expression is valid
8087 inside the ContextualReturn, it does not have to be an
8088 ExpressionStatement.
8090 2007-04-24 Miguel de Icaza <miguel@novell.com>
8092 * lambda.cs (ContextualReturn.Resolve): if the return type is not
8095 2007-04-23 Miguel de Icaza <miguel@novell.com>
8097 * anonymous.cs (AnonymousContainer): split the virtual Resolve
8098 method in two methods: ResolveNoDefine and Resolve.
8100 ResolveNoDefine will stop just after ResolveTopBlock has been
8103 Resolve will then continue by creating a method and issuing the
8104 call to method.Define ().
8106 (AnonymousMethod): Split and implement the new Resolve and
8107 ResolveNoDefine as well.
8109 * lambda.cs (LambdaExpression): Split the anonymous method
8110 resolution code into a separate routine (CoreCompatibilityTest)
8111 from DoCompatibleTest.
8113 (LambdaExpression.TryBuild): New method, this method tries to
8114 build the LambdaExpression with the given set of types to be used
8115 as the types for the various parameters of the lambda expression.
8117 If the compilation succeed with the given types, the infered type
8118 of the Anonymous method is returned, otherwise null is returned.
8120 2007-04-23 Marek Safar <marek.safar@gmail.com>
8122 A fix for bug #81414
8123 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
8125 2007-04-22 Miguel de Icaza <miguel@novell.com>
8127 * cs-tokenizer.cs: Change various identifiers here from the
8128 camelCasing to the recommended Linux-like style for instance
8129 variables from the Coding Guidelines.
8131 2007-04-19 Martin Baulig <martin@ximian.com>
8134 (Convert.ImplicitReferenceConversionCore): Allow conversions from
8135 System.Enum to System.ValueType.
8137 2007-04-13 Martin Baulig <martin@ximian.com>
8139 Rewrote implicit reference conversions. We need to distinguish
8140 between implicit reference conversions (13.1.4) and implicit
8141 boxing conversions (13.1.5).
8143 According to the spec, there's an an implicit conversion
8144 "From a one-dimensional array-type S[] to IList<T> and base
8145 interfaces of this interface, provided there is an implicit
8146 reference conversion from S to T." Note that this does not
8147 include boxing conversions.
8150 (Convert.ImplicitTypeParameterBoxingConversion): New method.
8151 (Convert.ImplicitReferenceConversion): Split into
8152 ImplicitReferenceConversionCore() and
8153 ImplicitBoxingConversionExist().
8154 (Convert.ImplicitReferenceConversionExists): Use the new
8155 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
8157 2007-04-12 Martin Baulig <martin@ximian.com>
8159 * convert.cs (Convert.ImplicitReferenceConversion): Move the
8160 `TypeManager.null_type' checks up to the top of the method.
8162 2007-04-11 Marek Safar <marek.safar@gmail.com>
8164 A fix for bug #81350
8165 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
8168 2007-04-11 Martin Baulig <martin@ximian.com>
8170 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
8171 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
8172 to make this work for generic classes; fixes #79561.
8174 2007-04-11 Martin Baulig <martin@ximian.com>
8176 * expression.cs (As): Add support for nullable types; fixes #79371.
8178 2007-04-11 Martin Baulig <martin@ximian.com>
8180 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
8181 `type.FullName' is null; fixes #80243.
8183 2007-04-11 Martin Baulig <martin@ximian.com>
8185 * expression.cs (Invocation.IsApplicable): Don't modify the method
8186 if type inference succeeded, but the method was not applicable.
8189 2007-04-10 Marek Safar <marek.safar@gmail.com>
8191 A fix for bug #81324
8192 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
8193 internal and external namespaces containers.
8195 2007-04-10 Martin Baulig <martin@ximian.com>
8197 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
8198 TypeManager.DropGenericMethodArguments() so we also call
8199 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
8201 2007-04-10 Martin Baulig <martin@ximian.com>
8203 * iterators.cs (Iterator.CreateIterator): Don't crash if
8204 `method.ReturnType' is null. This happens if something went wrong
8205 while resolving that typ (we already reported an error in this case).
8207 2007-04-10 Martin Baulig <martin@ximian.com>
8209 * expression.cs (New.DoResolve): Don't call CheckComImport() on
8210 generic interfaces; report the CS0144 directly.
8212 2007-04-10 Martin Baulig <martin@ximian.com>
8214 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
8215 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
8217 2007-04-10 Martin Baulig <martin@ximian.com>
8219 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
8221 2007-04-09 Raja R Harinath <rharinath@novell.com>
8224 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
8225 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
8228 * statement.cs (For.Resolve): If resolution fails, use
8231 2007-04-08 Marek Safar <marek.safar@gmail.com>
8233 * anonymous.cs (MakeName): Make faster and zero-based.
8234 (VerifyExplicitParameterCompatibility): Back to mode where generic
8235 parameter is ignored.
8236 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
8238 * class.cs (EmitType): Method can emit another new method.
8240 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
8242 * driver.cs: Updated.
8244 * lambda.cs: Reuse predefined empty parameters.
8246 * parameter.cs: Updated
8248 * support.cs: Implemented InflateTypes.
8250 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
8251 (InitSystemCore): Introduced to isolate 3.0 dependencies.
8253 2007-04-03 Martin Baulig <martin@ximian.com>
8257 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
8258 version of TypeManager.IsOverride() which also works with generic
8261 2007-04-03 Martin Baulig <martin@ximian.com>
8266 (Convert.ExplicitReferenceConversion): We need to cast when
8267 converting from IList<T> to S[].
8269 2007-04-01 Marek Safar <marek.safar@gmail.com>
8271 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8274 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8276 2007-03-31 Marek Safar <marek.safar@gmail.com>
8278 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8279 argument and return type inferring.
8281 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8282 (ReturnType): Turned to property.
8284 * statement.cs (Return): Implemented return type inferring.
8286 * support.cs (ReflectionParameters): Use local types if possible.
8288 2007-03-30 Raja R Harinath <rharinath@novell.com>
8290 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8291 (FlowBranching.UsageVector): Update to changes.
8293 Prepare to kill 'Reachability'
8294 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8295 argument of constructor.
8297 2007-03-29 Raja R Harinath <rharinath@novell.com>
8299 Prepare to kill 'Reachability'
8300 * flowanalysis.cs (UsageVector.is_unreachable): New.
8301 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8302 'reachability', and verify they're consistent.
8305 * expression.cs (New.EmitStatement): Handle type parameters here too.
8307 2007-03-29 Martin Baulig <martin@ximian.com>
8312 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8313 CompilerGeneratedClass.
8314 (ScopeInfo.EmitScopeInstance): Make this protected.
8315 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8316 `ec.CurrentAnonymousMethod.Scope == Scope'.
8318 * statement.cs (Block.ScopeInfo): Make this a property.
8320 2007-03-27 Raja R Harinath <harinath@gmail.com>
8322 Prepare to kill 'Reachability'
8323 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8324 (FlowBranching.UsageVector.Reachability): Remove property.
8325 (FlowBranching.UsageVector.IsUnreachable): New property.
8326 (FlowBranching.UsageVector.ResetBarrier): New.
8327 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8328 * codegen.cs, statement.cs: Update to changes.
8330 2007-03-27 Martin Baulig <martin@ximian.com>
8335 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8338 2007-03-26 Raja R Harinath <rharinath@novell.com>
8340 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8341 instead of TriState. Remove all mention of TriState.
8343 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8344 replaced by a boolean. Add boolean 'is_unreachable' field, check
8345 and maintain invariants.
8347 2007-03-25 Marek Safar <marek.safar@gmail.com>
8349 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8351 2007-03-25 Marek Safar <marek.safar@gmail.com>
8353 * expression.cs: Stop using obsolete 2.0 opcodes.
8355 2007-03-25 Marek Safar <marek.safar@gmail.com>
8357 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8358 one of the latests Martin's fixes.
8360 2007-03-23 Miguel de Icaza <miguel@novell.com>
8362 * expression.cs: On BigEndian systems, swap the bytes, temporary
8363 solution until we get a new bitconverter class.
8365 2007-03-23 Martin Baulig <martin@ximian.com>
8369 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8370 "Method" and "Method`1". Normally, a cache lookup is done on the
8371 "Method" form (ie. without the generic arity), but this one makes
8372 lookups on the full form work as well.
8374 2007-03-22 Raja R Harinath <rharinath@novell.com>
8376 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8379 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8381 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8382 ordered_member_list, to TypeBuilder to store members to be defined
8383 in the order they were parsed in.
8384 - ordered_explicit_member_list contains all properties indexers
8385 and methods that are defined as explicit implementation of an
8386 interface or base class.
8387 - ordered_member_list contains all properties indexers and methods
8388 that are not defined as explicit implementation of an interface
8391 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8392 functionality in these removed classes has been replaced with
8393 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8394 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8396 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8397 to CheckForDuplications inside GetMethod and SetMethod Define Method
8398 to handle method property and indexer name conflicts.
8402 All code is contributed under the MIT/X11 license.
8404 2007-03-20 Martin Baulig <martin@ximian.com>
8406 * class.cs (TypeContainer.Interfaces): Removed; they're now
8407 included in `TypeContainer.Types'.
8409 2007-03-20 Martin Baulig <martin@ximian.com>
8411 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8413 * class.cs (TypeContainer.CreateType): New public method. This is
8414 now called before DefineType() to create the TypeBuilders.
8415 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8416 has already been created by CreateType().
8417 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8418 don't resolve our base classes here; this has been moved into
8419 DefineBaseTypes(). We're now called from CreateType().
8420 (TypeContainer.DefineBaseTypes): New private method; resolve our
8421 base classes here. We're now called from DefineType().
8424 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8425 our types first to create all the TypeBuilders. After that, call
8426 TypeContainer.DefineType() on all the types which'll resolve their
8427 base classes and setup the resolve order.
8429 2007-03-20 Martin Baulig <martin@ximian.com>
8431 * class.cs (TypeContainer.Enums): Removed; they're now included in
8432 `TypeContainer.Types'.
8434 2007-03-20 Martin Baulig <martin@ximian.com>
8437 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8438 (TypeContainer.DoResolveMembers): Call DefineType() on our
8439 `compiler_generated' classes; moved here from DefineNestedTypes().
8442 (RootContext.ResolveTree): Call ResolveMembers() on all
8443 TypeContainer's in the `type_container_resolve_order'.
8445 2007-03-19 Marek Safar <marek.safar@gmail.com>
8447 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8449 2007-03-17 Marek Safar <marek.safar@gmail.com>
8451 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8452 implementation flags.
8454 2007-03-17 Marek Safar <marek.safar@gmail.com>
8456 * class.cs: More optimizations for type parameters.
8458 2007-03-15 Marek Safar <marek.safar@gmail.com>
8460 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8462 * ecore.cs, parameter.cs: More common code for both corlibs.
8464 * typemanager.cs (IsGenericMethod): Simplified.
8466 2007-03-15 Raja R Harinath <rharinath@novell.com>
8468 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8470 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8472 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8473 unconditionally. Simplify explanation.
8474 (Try.Resolve, Using.Resolve): Likewise.
8476 2007-03-15 Martin Baulig <martin@ximian.com>
8480 * decl.cs (DeclSpace): If we're a partial class, use our
8481 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8483 2007-03-15 Raja R Harinath <rharinath@novell.com>
8485 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8487 (FlowBranching.UsageVector): Update to changes.
8488 (FlowBranching.MergeSiblings): Likewise.
8489 * statement.cs: Likewise.
8491 2007-03-15 Martin Baulig <martin@ximian.com>
8496 (MemberCache): Added a special .ctor for type parameters.
8499 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8502 2007-03-09 Martin Baulig <martin@ximian.com>
8504 * enum.cs (Enum): Make this a TypeContainer.
8505 (EnumMember): Derive from `Const'.
8508 (Const.DoResolveValue): New protected virtual method; move most of
8509 the functionality of ResolveValue() here so we can override it in
8511 (Const.CreateConstantReference): Make this virtual.
8513 * class.cs (Kind): Add `Kind.Enum'.
8514 (TypeContainer.Emit): Don't emit the enums here; they're already
8515 in the `RootContext.typecontainer_resolve_order'.
8517 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8518 here; they're already in the `typecontainer_resolve_order'.
8520 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8521 TypeManager.DropGenericTypeArguments().
8524 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8525 (TypeManager.IsEnumType): Likewise.
8526 (TypeManager.EnumToUnderlying): Likewise.
8527 (TypeManager.IsEqual): Add support for enums.
8529 2007-03-12 Raja R Harinath <rharinath@novell.com>
8531 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8532 DefaultParameterValueAttribute to be undefined, say if System.dll
8535 2007-03-11 Marek Safar <marek.safar@gmail.com>
8537 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8540 2007-03-10 Marek Safar <marek.safar@gmail.com>
8542 * class.cs, parameter.cs: Unified parameters verification.
8544 2007-03-08 Martin Baulig <martin@ximian.com>
8546 * cs-parser.jay (constructor_header): Pass the location to the
8547 newly created TopLevelBlock.
8549 2007-03-07 Martin Baulig <martin@ximian.com>
8551 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8553 2007-03-06 Miguel de Icaza <miguel@novell.com>
8555 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8556 with the changes from David, fixes the build.
8558 2007-03-05 David Mitchell <dmitchell@logos.com>
8560 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8561 and its base interfaces to a one-dimensional array type S[],
8562 provided there is an implicit or explicit reference conversion
8565 2007-03-03 Marek Safar <marek.safar@gmail.com>
8567 * cs-tokenizer.cs: Implemented basic linq grammar.
8569 * driver.cs: Set linq lang version on demand.
8571 2007-02-26 Marek Safar <marek.safar@gmail.com>
8573 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8575 2007-02-25 Marek Safar <marek.safar@gmail.com>
8577 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8580 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8582 Check property and event extern attributes.
8584 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8587 2007-02-24 Marek Safar <marek.safar@gmail.com>
8589 A fix for bug #80407
8590 * ecore.cs: Don't report ambiguity error when methods have same parent.
8592 2007-02-23 Marek Safar <marek.safar@gmail.com>
8594 A fix for bug #80878
8595 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8597 2007-02-22 Marek Safar <marek.safar@gmail.com>
8599 * attribute.cs: Enable ExtensionAttribute presence test.
8601 2007-02-22 Marek Safar <marek.safar@gmail.com>
8603 * class.cs: Warn about missing GetHashCode only when Equals is override.
8605 * decl.cs: Check accessibility of type arguments.
8607 * typemanager.cs: Correctly report nullable array.
8609 2007-02-20 Marek Safar <marek.safar@gmail.com>
8611 * class.cs, report.cs: Capture more details when things go wrong.
8613 2007-02-20 Marek Safar <marek.safar@gmail.com>
8615 A fix for bug #80650
8616 * cs-parser.jay: Anonymous container starts at constructor declaration
8617 and not at block beginning because it has to be usable in constructor
8620 * statement.cs: Use context location and not block one for error reporting.
8622 2007-02-18 Marek Safar <marek.safar@gmail.com>
8624 A fix for bug #78712
8625 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8628 2007-02-18 Marek Safar <marek.safar@gmail.com>
8630 A fix for bug #80493 by Atsushi Enomoto
8631 * cs-parser.jay: Ignore invalid attribute target.
8633 2007-02-18 Marek Safar <marek.safar@gmail.com>
8635 * cs-tokenizer.cs: Ignore '\0' as white space character.
8637 2007-02-17 Miguel de Icaza <miguel@novell.com>
8639 * cs-parser.jay: Add support for lambda expressions to the mcs
8642 * lambda.cs: Only clone when we are probing, not on the final call
8643 (Compatible is the final call).
8645 * statement.cs (CloneContext): Introduce class to provide block
8646 remapping during clone.
8648 All statements Clone themselves now.
8650 (Clone): special handling for blocks, when we clone a block, we
8651 register the block inside this routine, as children of the block
8652 might trigger a lookup.
8654 * expression.cs: Add support for CloneContext in all expressions.
8656 2007-02-17 Marek Safar <marek.safar@gmail.com>
8658 A fix for bug #80493
8659 * statement.cs: Report ambiguous warning when interfaces are not related.
8661 2007-02-15 Marek Safar <marek.safar@gmail.com>
8663 C# 3.0 extension methods.
8665 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8666 cannot be used directly.
8668 * class.cs (Class.Emit): Emit extension attribute if any class method
8669 is extension method.
8670 (Method.Define): Add basic extension method validation conditions.
8671 (Method.Emit): Emit extension attribute for method.
8673 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8674 extension method exists. Currently we follow same approach as Microsoft
8675 does, emit even if a method or a class are private but this can change
8678 * cs-parser.jay: Add handling of `this' keyword in method parameters
8681 * decl.cs (DeclSpace.IsStaticClass): New property.
8682 (MemberCache.FindExtensionMethods): Looks for extension methods with
8683 defined name and extension type.
8685 * doc.cs: Updated after OverloadResolve changes.
8687 * driver.cs: Add new soft reference to System.Core.dll.
8689 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8690 (ExtensionMethodGroupExpr): Represents group of extension methods.
8692 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8693 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8694 to MethodGroupExpr and made non-static for easier customization.
8695 (Invocation.DoResolve): Add extension method lookup when no standard
8697 (MemberAccess.DoResolve): Try extension methods if no member exists.
8699 * modifiers.cs: Add METHOD_EXTENSION modifier.
8701 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8702 as well as candidate extension type.
8703 (ComputeNamespaces): When assembly constains extension methods registers
8705 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8706 extension method lookup.
8707 (Namespace.LookupExtensionMethod): Looks for extension method in this
8709 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8710 find a method which matches name and extensionType.
8712 * parameter.cs (Parameter): Add This modifer.
8713 (HasExtensionMethodModifier): New property.
8714 (Resolve): Add extension parameter check.
8715 (ModFlags): turned to property to exclude this modifier as it is not real
8717 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8719 * support.cs (ParameterData): Add ExtensionMethodType.
8720 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8722 * typemanager.cs: Add type and ctor extension attribute type.
8724 2007-02-15 Miguel de Icaza <miguel@novell.com>
8726 * report.cs (DisableErrors, EnableErrors): used to prevent error
8727 output when we are "trying" to compile various methods with
8730 * ecore.cs (Expression): Add Clone method that calls the virtual
8731 CloneTo method. The current CloneTo method in Expression throws
8732 an exception so we can track down all the places where this must
8733 be implemented (not using abstract, because that would be a lot of
8734 up-front-work before we can start testing the implementation
8737 Important: we only need Clone capabilities for expressions created
8738 by the parser, as the expressions we will be cloning are
8739 expressions in the pre-resolved state. This vastly simplifies
8742 (SimpleName): Add CloneTo that does nothing.
8743 (EmptyCast): Add CloneTo.
8745 * expression.cs (Binary): Implement CloneTo.
8746 (Invocation.IsApplicable): Store the current ec in
8747 EmitContext.TempEc and restore it on return. This is used so we
8748 do not have to sprinkle hundres of methods with an extra
8749 EmitContext, we know that the only user is the lambda expression
8750 ImplicitConversionExists code.
8752 (Argument): Add Cloning capabilities.
8753 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8754 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8755 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8756 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8757 IndexerAccess): Add Clone capability.
8759 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8761 (Argument): Add cloning capability.
8763 * assign.cs (Assign): Implement CloneTo.
8765 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8767 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8768 version by calling Convert with the EmitContext (that we are
8769 currently storing in ec, this is not great, but will do for now,
8770 to avoid passing EmitContext parameters to hundreds of functions
8771 that do not need them now).
8773 (SetExpression): Remove, it is not needed.
8775 (ContextualReturn): Implement CloneTo.
8777 * statement.cs (Statement): Implement cloning infrastructure,
8778 similar to expressions.
8780 (Block): Partial implementation of Clone for statements.
8782 (Return): Implement clone.
8784 * constant.cs (Constant.CloneTo): New method, does nothing.
8786 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8787 solution, until we decide how to exactly do this.
8789 2007-02-14 Marek Safar <marek.safar@gmail.com>
8791 A fix for bug #80493
8792 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8793 a property is override we need to use second accessor.
8795 2007-02-13 Marek Safar <marek.safar@gmail.com>
8797 A fix for bug #80418
8798 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8801 2007-02-13 Marek Safar <marek.safar@gmail.com>
8803 Another fix for bug #80749
8804 * pending.cs: Abstract class has priority over interfaces.
8806 2007-02-13 Marek Safar <marek.safar@gmail.com>
8808 Another fix for bug #80749
8809 * pending.cs: Abstract class has priority over interfaces.
8811 2007-02-13 Marek Safar <marek.safar@gmail.com>
8813 Another fix for bug #80749
8814 * pending.cs: Abstract class has priority over interfaces.
8816 2007-02-13 Marek Safar <marek.safar@gmail.com>
8818 Another fix for bug #80749
8819 * pending.cs: Abstract class has priority over interfaces.
8821 2007-02-13 Marek Safar <marek.safar@gmail.com>
8823 * class.cs Better error message.
8825 * driver.cs: Add shorter versions of -optimize option.
8827 2007-02-13 Martin Baulig <martin@ximian.com>
8829 * class.cs (Constructor.Emit): Check the return value of
8830 ec.ResolveTopBlock() and return on error.
8832 2007-02-13 Raja R Harinath <rharinath@novell.com>
8834 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8835 message to fix error message regression.
8837 2007-02-12 Marek Safar <marek.safar@gmail.com>
8839 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8841 2007-02-12 Marek Safar <marek.safar@gmail.com>
8843 A fix for bug #80749
8844 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8845 its parent container.
8847 * class.cs (DefineFieldInitializers): Each initializer can has different
8850 * const.cs: Updated.
8852 2007-02-11 Miguel de Icaza <miguel@novell.com>
8854 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8855 now all the heavy lifting to check that embedded statements or
8856 expressions have the right form is done in the ContextualReturn.
8858 (ContextualReturn): New class.
8860 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8861 method that can be invoked to report 201, so we do not replicate
8864 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8866 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8867 treating tabs as spaces.
8869 2007-02-09 Marek Safar <marek.safar@gmail.com>
8871 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8872 * assign.cs: Use full implicit conversion for right side check.
8874 2007-02-09 Marek Safar <marek.safar@gmail.com>
8876 * statement.cs (Switch): Switch over boolean type is not standardized.
8878 2007-02-08 Marek Safar <marek.safar@gmail.com>
8880 A fix for bug #80755
8881 * decl.cs (FindBaseEvent): Don't use method cache for events.
8883 2007-02-07 Marek Safar <marek.safar@gmail.com>
8885 * cs-parser.jay: Better syntax error handling.
8887 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8888 instead of underlying type value.
8890 2007-02-06 Marek Safar <marek.safar@gmail.com>
8892 * driver.cs: Check define identifier before is registered.
8894 * namespace.cs: Use existing error message.
8896 * report.cs: New warning.
8898 2007-02-06 Marek Safar <marek.safar@gmail.com>
8900 A fix for bug #80742
8901 * expression.cs: Delegate Invoke method can be called directly.
8903 2007-02-06 Marek Safar <marek.safar@gmail.com>
8905 A fix for bug #80676
8906 * class.cs (IsEntryPoint): The Main method can have params modifier.
8908 2007-02-04 Miguel de Icaza <miguel@novell.com>
8910 * parameter.cs (Parameter, Parameters): Add Clone method.
8912 * anonymous.cs (Compatible): Turn method into virtual method, so
8913 LambdaExpression can implement a different behavior.
8915 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8916 out the basic checking here, so it can be used by
8919 * lambda.cs: Introduce "Compatible" function that will do the
8922 2007-02-02 Marek Safar <marek.safar@gmail.com>
8924 * attribute.cs: Unified one error message.
8926 * class.cs (Class): Use type attributes and not properties to test static
8928 (IsEntryPoint): Don's pass local variable.
8930 * convert.cs: Removed duplicate check.
8932 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8934 * driver.cs: Don't crash when soft reference does not exist.
8936 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8937 (UsingEntry): Removed redundant allocation.
8939 * parameter.cs: Add fast path for type parameters.
8941 * support.cs: Don't allocate attribute when it's not used.
8943 2007-01-30 Miguel de Icaza <miguel@novell.com>
8946 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8947 this into a virtual method, so we can override it in LambdaExpression.
8949 * driver.cs: Improve diagnostics in case of failure.
8951 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8952 write a function that is slightly more complex and that parses:
8954 type identifier [, type identifier]* )
8956 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8959 (canEmpty ? i >= 0 : i > 0)
8961 2007-01-30 Raja R Harinath <rharinath@novell.com>
8963 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8964 exception on possibly valid code.
8966 2007-01-29 Raja R Harinath <rharinath@novell.com>
8968 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8970 (parse_opt_type_arguments): Remove. It's almost the same as
8972 (parse_namespace_or_typename): Use parse_less_than.
8974 2007-01-28 Miguel de Icaza <miguel@novell.com>
8976 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8977 this bug took a few hours to find, because the state saved and
8978 restored by PushPosition and PopPosition was ignoring the state of
8979 parse_generic_less_than.
8981 I can also now remove the handling of OP_LT and OP_GT, this solves
8984 * cs-tokenizer.cs: store the location for the ARROW token, we use
8987 (PushPosition, PopPosition): save/restore also `current_token',
8988 restore `parse_generic_less_than' (was missing).
8990 (parse_opt_type_arguments): use parse_type, not
8991 parse_namespace_or_typename to parse types.
8993 * lambda.cs: Empty new file, will eventually have the lambda
8994 expression implementation.
8996 * lambda.test: used to test the internal tokenizer.
8998 * report.cs (FeatureIsNotISO1): Rename from
8999 FeatureIsNotStandardized, because it was about the language level
9000 (1 vs 2) it was not about standarization.
9002 (FeatureRequiresLINQ): New.
9004 * support.cs (SeekableStreamReader): Only require that the reader
9005 is a TextReader, not a StreamReader, so we can plug StringReader.
9007 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
9008 given position in the input stream the following tokens can be
9009 parsed as a type followed by an identifier.
9011 (is_punct): after a '(' if parse_type_and_parameter returns true,
9012 then return a special token OPEN_PARENS_LAMBDA which is used to
9013 avoid reduce/reduce errors in the grammar for the
9014 lambda_expression rules.
9016 (parse_type): implement a type parser inside the
9017 tokenizer, the parser only returns true or false depending on
9018 whether the input at a given position can be parsed as a type.
9020 (peek_token): new method used during type parsing.
9022 2007-01-28 Raja R Harinath <rharinath@novell.com>
9025 * anonymous.cs (ScopeInfo.InflateParameters): New.
9026 (AnonymousContainer.Resolve): Use it to redirect types of
9027 delegate parameters.
9029 2007-01-27 Raja R Harinath <rharinath@novell.com>
9032 * expression.cs (Error_InvalidArguments): Don't use two different
9033 messages for CS1503. Use ExtraInformation and
9034 SymbolRelatedToPreviousError instead.
9037 * decl.cs (DeclSpace.initialize_type_params): Don't access
9038 'type_params' of a partial class directly.
9040 2007-01-26 Miguel de Icaza <miguel@novell.com>
9042 * constant.cs: Removed a handful of out-of-range checks that were
9045 2007-01-25 Marek Safar <marek.safar@gmail.com>
9047 * expression.cs (CheckUselessComparison): Add additional check for char
9050 * namespace.cs: Fixed typo.
9052 2007-01-23 Miguel de Icaza <miguel@novell.com>
9054 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
9055 gone, instead we inline the test, preventing the needless casts to
9056 longs, ulongs and doubles for the parameters, avoiding calls to
9057 methods that overchecked stuff, and instead inlined things
9060 2007-01-20 Marek Safar <marek.safar@gmail.com>
9062 * cs-parser.jay: Better parameter error handling.
9064 2007-01-17 Marek Safar <marek.safar@gmail.com>
9066 A fix for bug #80368, #80522
9067 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
9068 whether array initializer contains constants only.
9069 (ArrayCreation.Emit): Use better formula to decide when
9070 are array initializers for static initialization.
9071 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
9072 have to emit even constants otherwise they are pre-initialized.
9074 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
9075 Raja R Harinath <rharinath@novell.com>
9077 Fix emit order of 'get' vs. 'set'.
9078 * support.cs (Accessors): New.
9079 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
9080 Note the order in which accessors are declared in the source.
9081 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
9082 Refactored from Property.Define and Indexer.Define.
9083 (PropertyBase.DefineAccessors): New helper that calls the above in
9084 appropriate order as noted by the parser.
9085 (Property.Define, Indexer.Define): Update to changes.
9086 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
9088 2007-01-17 Raja R Harinath <rharinath@novell.com>
9090 Fix cs0029-6.cs and gcs0029-2.cs (regression)
9091 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
9092 there's an implicit conversion from the current type to the target
9093 type before converting the underlying constant.
9095 2007-01-16 Marek Safar <marek.safar@gmail.com>
9097 * const.cs (ResolveValue): Updated after constant conversion was made more
9100 * constant.cs (GetAttributableValue): constant to object conversion is
9101 used for attributes only.
9102 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
9103 constant conversions.
9104 (LongConstant.ConvertImplicitly): Ditto.
9106 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
9107 (ImplicitConversionStandard): Handle constant conversion as extra step.
9108 It solves the issue when constant conversion was called indirectly like
9109 inside array initializer and constant folding was skipped.
9111 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
9114 * statement.cs(ImplicitConversionStandard): Updated after constant
9115 conversion was made more generic.
9117 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
9119 * expression.cs (As.DoResolve): Use GenericConstraints instead of
9120 Constraints, solves the problem where the compiler incorrectly
9121 reported that a type parameter was not constrained to a class (Bug
9124 2007-01-14 Marek Habersack <grendello@gmail.com>
9126 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
9128 2007-01-14 Marek Safar <marek.safar@gmail.com>
9130 A fix for bug #80368
9131 * assign.cs (FieldInitializer): New class implements field
9132 initializer statement.
9134 * attribute.cs: Update after FieldMember rename.
9136 * class.cs (PropertyBasedMember): New common class for property based
9138 (InterfaceMemberBase): New base class for all members which can be used as
9139 an interface members.
9140 (MethodCore): Moved really common code to InterfaceMemberBase.
9141 (Method.Define): Equal and GetHasCode detection is relevant for methods
9143 (MethodData.Define): Don't assume that public event implements an
9144 interface automatically.
9145 (MethodData.DefineMethodBuilder): Issue an error even if only extern
9147 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
9148 (FieldMember): Merged with FieldBase.
9149 (EventProperty.AEventPropertyAccessor): New specialization to check whether
9150 event extern modifier can be used.
9151 (EventField.EventFieldAccessor): Moved event field specific code here.
9152 (Event.AllowedModifiers): Even event can be extern.
9153 (Event.FindOutBaseMethod): New override specific to events.
9154 (Indexer.parameters): Reintroduce parameters because base class holds
9155 only properties common data.
9156 (Indexer.CheckForDuplications): Indexers are threated as methods so we
9157 need do extra parameters check.
9159 * const.cs: Update after FieldMember rename.
9161 * decl.cs (MemberCache.FindBaseEvent): New method.
9163 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
9164 to reflect that indexer is now derived from PropertyBased.
9166 * ecore.cs (GetMemberType): Made public.
9167 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
9170 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
9172 * typemanager.cs (CSharpSignature): Correctly print event accessors.
9173 (RegisterEvent): Removed.
9174 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
9175 (GetPrivateFieldOfEvent): Renamed to GetEventField.
9177 2007-01-11 Raja R Harinath <rharinath@novell.com>
9180 * statement.cs (CollectionForeach.TryType): Prefer generic
9181 GetEnumerator over non-generic variant. Fix code to follow comments.
9183 2007-01-09 Raja R Harinath <rharinath@novell.com>
9186 * support.cs (ReflectionParameter): Don't use an invalid index on
9187 the generic parameter data.
9189 2007-01-08 Miguel de Icaza <miguel@novell.com>
9191 * driver.cs: Just add a tiny bit of infrastructure.
9193 2007-01-02 Marek Safar <marek.safar@gmail.com>
9195 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
9196 where field type is struct from current assembly.
9198 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
9201 2007-01-02 Marek Safar <marek.safar@gmail.com>
9203 A fix for bug #80381
9204 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
9207 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
9209 (Namespace.LookupType): Always use core types from corlib when speficied.
9211 * report.cs: A new warning.
9213 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
9214 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
9215 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
9217 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
9218 (InitCoreTypes): Set expression type of object_type and value_type
9219 immediately after lookup.
9221 2007-01-01 Miguel de Icaza <miguel@novell.com>
9223 * cs-tokenizer.cs: Accept Pc class characters (Connector
9224 Punctuation) as valid identifiers. Fixes #78259
9226 * expression.cs (Invocation.DoResolve): Moved the check for the
9227 use of `this' for doing method calls to the Invocation resolution
9228 step, after overload resolution has taken place instead of doing
9229 the check at the low-level `This.DoResolve' level.
9231 The `This.DoResolve'(appens before overload resolution, so it has
9232 no way of knowing if the method that will be called will be
9233 instace or static, triggering an erroneous report for cs0188 (Bug
9236 We now do the check for instance method invocations after we know
9237 what method will be called.
9239 (This.CheckThisUsage): Move the actual use of this structure
9240 checking into its own method and expose it.
9242 * Everywhere that called Error_ValueCannotBeConverted: pass a new
9245 Exceptions: Null.ConvertImplicitly,
9246 Constant.ImplicitConversionRequired as there are too many call
9247 sites for passing the ec.
9249 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
9250 EmitContext, if the value is null, then we do not try to provide
9251 the extra information from the error (If a userdefined conversion
9252 exists, as UserDefinedConversion requires a non null-EmitContext).
9256 2006-12-30 Raja R Harinath <rharinath@novell.com>
9258 * flowanalysis.cs (MyBitVector): Document some invariants.
9259 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
9260 introduced below, and add a couple of others,
9262 2006-12-30 Marek Safar <marek.safar@gmail.com>
9264 * attribute.cs (GetMethodObsoleteAttribute): Uses new
9265 GetPropertyFromAccessor and GetEventFromAccessor.
9267 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
9268 overrides non-obsolete one.
9269 (Indexer.Define): Error message has been moved to the parser.
9271 * cs-parser.jay: Better syntax errors handling.
9273 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9274 when an invocation has no arguments.
9276 * ecore.cs: Removed not used caching.
9278 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9281 * report.cs: Add a new warning.
9283 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9285 * typemanager.cs (enumeration_type): Removed.
9286 (CSharpSignature): Reuses IsSpecialMethod.
9287 (IsEqual): Hack for MS BCL.
9288 (GetPropertyFromAccessor): New method.
9289 (GetEventFromAccessor): New method.
9290 (IsSpecialMethod): Fixed to handle more cases.
9292 2006-12-30 Marek Safar <marek.safar@gmail.com>
9294 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9295 Made white spaces array static.
9297 * ecore.cs (RemoveGenericArity): Optimized.
9299 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9301 (MyBitVector.initialize_vector): Simplified.
9303 2006-12-22 Miguel de Icaza <miguel@novell.com>
9305 * ecore.cs: Am not entirely happy with this hack, but it seems to
9306 address the issue in 80257 (a small test case for
9309 I set the MethodGroupExpr.Type to an internal compiler type
9310 (itself in this case) to force the resolution to take place. Why
9311 it does not take place with a null is beyond me.
9313 2006-12-20 Marek Safar <marek.safar@gmail.com>
9315 A fix for bug #80288
9316 * expression.cs (ResolveOperator): Consider user defined conversion for
9317 logical and operator too.
9318 (EmitBranchable): Optimization for logical and when full constant folding
9319 could not be applied but one operand is constant.
9321 2006-12-19 Marek Safar <marek.safar@gmail.com>
9323 * class.cs (GetClassBases): Write 5 times every day, will never use
9324 FullName for error reporting.
9326 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9328 2006-12-19 Martin Baulig <martin@ximian.com>
9330 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9331 the symbol file info here.
9333 2006-12-18 Marek Safar <marek.safar@gmail.com>
9335 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9336 of `elseif' is taking then following sections are not taking.
9337 Fixes an issue reported on mono mailing list.
9339 2006-12-18 Marek Safar <marek.safar@gmail.com>
9341 A fix for bug #80300
9342 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9343 a caller is not taking.
9345 2006-12-18 Raja R Harinath <rharinath@novell.com>
9347 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9348 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9349 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9350 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9351 * class.cs: Update to changes.
9353 2006-12-17 Marek Safar <marek.safar@gmail.com>
9355 A fix for bug #79934
9356 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9359 * class.cs (ResolveMembers): Register an iterator in current container and
9362 2006-12-16 Raja R Harinath <rharinath@novell.com>
9365 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9366 satisfy a params annotated parameter.
9368 2006-12-16 Marek Safar <marek.safar@gmail.com>
9370 A fix for bug #77014
9371 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9372 paramters correctly and not rely on hacks in Parameters class.
9373 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9375 (Invocation.VerifyArgumentsCompat): Ditto.
9376 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9379 * parameter.cs (HasParams): Don't assume that params is the last one.
9381 * support.cs (ReflectionParameters.ctor): Look for params attribute
9383 (ReflectionParameters.ParameterType): Removed hack when we returned last
9384 parameter for out of range parameters.
9385 (ParameterName, ParameterModifier): Ditto.
9387 2006-12-14 Marek Safar <marek.safar@gmail.com>
9389 A fix for bug #79987
9390 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9391 when assembly is not CLS compliant but type is. I have no idea why is this
9394 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9396 2006-12-13 Miguel de Icaza <miguel@novell.com>
9398 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9399 in struct constructors, they are basically no-ops.
9401 2006-12-12 Marek Safar <marek.safar@gmail.com>
9403 * cs-tokenizer.cs (Position): Save preprocessor status too.
9405 2006-12-12 Marek Safar <marek.safar@gmail.com>
9407 A fix for bug #77794
9408 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9410 2006-12-12 Marek Safar <marek.safar@gmail.com>
9412 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9414 (pp_expr): Report error for an invalid expression.
9415 (handle_preprocessing_directive): Simplified; add more error checking.
9417 2006-12-11 Marek Safar <marek.safar@gmail.com>
9419 A fix for bug #74939
9420 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9421 directives handling.
9423 2006-12-10 Marek Safar <marek.safar@gmail.com>
9425 A fix for bugs #80093, and #75984
9426 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9427 logic, it seems to me as it worked before "by coincidence".
9428 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9429 (cleanup): Enabled endif check.
9431 2006-12-09 Marek Safar <marek.safar@gmail.com>
9433 A fix for bug #80162
9434 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9435 enumerators are never ambiguous.
9437 2006-12-08 Raja R Harinath <rharinath@novell.com>
9440 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9442 2006-12-06 Marek Safar <marek.safar@gmail.com>
9444 A fix for bug #80144
9445 * class.cs (EventProperty.Define): Explicit implementation means
9446 that an even is used.
9448 2006-12-06 Marek Safar <marek.safar@gmail.com>
9450 Fixes the operators implementation (part II)
9452 * cfold.cs (DoConstantNumericPromotions): Renamed to
9453 DoBinaryNumericPromotions and simplified.
9454 (BinaryFold): Couple of conversion fixes; simplified.
9456 * constant.cs, ecore.cs, literal.cs
9457 (ToType): Renamed to ConvertImplicitly.
9458 (Reduce): Renamed to ConvertExplicitly.
9460 * class.cs, convert.cs: Updated.
9462 * expression.cs: TryReduce doesn't throw an exception.
9464 2006-12-01 Marek Safar <marek.safar@gmail.com>
9466 A fix for bug #80108
9467 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9470 2006-11-30 Marek Safar <marek.safar@gmail.com>
9472 Fixes unary operators implementation (part I)
9475 * cfold.cs (Error_CompileTimeOverflow): Made internal
9477 * const.cs (IConstant): Changed to use reference to constant and
9478 not constant itself.
9479 Updated IConstant implementations.
9481 * constant.cs (CreateConstant): New factory method.
9482 Updated IConstant implementation.
9484 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9486 * ecore.cs: Updated to use CreateConstantReference.
9488 * enum.cs: Reflects IConstant changes.
9490 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9492 * literal.cs (NullConstant): Change to be independently usable.
9494 2006-11-29 Martin Baulig <martin@ximian.com>
9496 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9497 we need to emit the scope initializer before calling the base .ctor.
9499 * anonymous.cs: Merged back from the new anonymous methods branch.
9500 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9502 * expression.cs (ParameterReference.DoResolveBase): Create a
9503 "normal" ScopeInfo when capturing parameters rather than using the
9504 root scope; this makes things work with anonymous methods having
9508 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9510 2006-11-22 Marek Safar <marek.safar@gmail.com>
9512 A fix for bug #79987
9513 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9514 check to a base class.
9515 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9516 only when assembly has missing attribute.
9517 * report.cs: Update.
9519 2006-11-21 Marek Safar <marek.safar@gmail.com>
9521 * cs-tokenizer.cs: Merged with gmcs version.
9523 2006-11-20 Marek Safar <marek.safar@gmail.com>
9526 * cs-parser.jay: Better error message when partial keyword is misplaced.
9528 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9530 A fix for bug #79810
9531 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9532 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9533 a RuntimeWrappedException by default.
9535 2006-11-18 Marek Safar <marek.safar@gmail.com>
9537 A fix for bug #79843
9538 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9540 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9542 2006-11-18 Marek Safar <marek.safar@gmail.com>
9544 * driver.cs, namespace.cs: Uses faster IndexOf version.
9546 2006-11-17 Marek Safar <marek.safar@gmail.com>
9548 A fix for bug #79941
9549 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9551 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9552 even if internal name is different.
9553 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9554 (UserDefinedConversion): Simplified as the operators cannot be internal.
9555 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9557 (MethodLookup): Replaced EmitContext with parentType.
9558 * expression.cs: Updated.
9560 2006-11-09 Raja R Harinath <rharinath@novell.com>
9562 * driver.cs (BadAssembly): Handle all the ugliness of
9563 DefineDynamicAssembly.
9565 2006-11-08 Raja R Harinath <rharinath@novell.com>
9567 Address parts of #58244 -- most of what's left is in the runtime
9568 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9569 CS1509 error checks, and handle them for all assembly loads, not
9570 just the first invocation.
9571 (LoadModule): Likewise. Move handling of 'adder_method' ...
9572 * codegen.cs (AssemblyClass.AddModule): ... here.
9574 2006-11-02 Marek Safar <marek.safar@gmail.com>
9576 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9577 IEnumerable<T> is ambiguous.
9579 2006-10-31 Marek Safar <marek.safar@gmail.com>
9581 A fix for bug #67689
9582 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9583 GetEnumerator is ambiguous.
9585 * report.cs: Add new warning.
9587 2006-10-29 Marek Safar <marek.safar@gmail.com>
9589 A fix for bug #78602
9590 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9591 to protected member can be nested type.
9593 2006-10-28 Marek Safar <marek.safar@gmail.com>
9595 A fix for bug #78965
9596 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9597 to protected member must derive from current type.
9599 2006-10-27 Marek Safar <marek.safar@gmail.com>
9601 assign.cs: Reuses error method.
9603 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9604 instead of type for constants.
9605 (Expression.Error_ValueAssignment): Common error method.
9607 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9610 2006-10-27 Marek Safar <marek.safar@gmail.com>
9612 A fix for bug #79081
9613 * expression.cs (MemberAccess.DoResolve): Check nested type
9616 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9618 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9620 2006-10-26 Marek Safar <marek.safar@gmail.com>
9622 A fix for bug #76591
9623 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9625 2006-10-26 Marek Safar <marek.safar@gmail.com>
9627 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9628 type forwarder of the same type multiple times.
9630 2006-10-26 Raja R Harinath <rharinath@novell.com>
9633 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9634 instance as an rvalue, even when we later resolve as an lvalue.
9636 2006-10-25 Martin Baulig <martin@ximian.com>
9638 * anonymous.cs: Fix #79673.
9640 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9642 A fix for bug #79666
9643 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9644 ignored when is optimized (= default value) as its value is already set.
9646 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9648 A fix for bug #79724
9649 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9650 TypeContainer for type lookup.
9652 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9654 A fix for bug #79231
9655 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9656 * expression.cs (OverloadResolve): Always convert type name for
9658 (ResolveNamespaceOrType): Don't confuse a nested type with any
9661 2006-10-18 Martin Baulig <martin@ximian.com>
9663 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9665 2006-10-17 Miguel de Icaza <miguel@novell.com>
9667 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9668 an int32, but requesting an int64 from the conversion
9670 2006-10-12 Martin Baulig <martin@ximian.com>
9673 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9675 2006-10-12 Martin Baulig <martin@ximian.com>
9678 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9680 2006-10-11 Miguel de Icaza <miguel@novell.com>
9682 * convert.cs: Remove broken code: I was doing the "Existance"
9683 tests for Implicit conversions.
9685 2006-10-10 Miguel de Icaza <miguel@novell.com>
9687 * convert.cs: Added one missing case in
9688 ImplicitStandardConversionExists uint64 to intptr.
9692 * typemanager.cs (uintptr_type): another core known type.
9694 * ecore.cs (OperatorCast): routine used to do cast operations that
9695 depend on op_Explicit. We could change some of the Decimal
9696 conversions to use this.
9698 This one has a probe mechanism that checks both types for an op_
9699 which it coudl be used to eliminate two classes: CastToDecimal
9700 and CastFromDecimal.
9702 * convert.cs: Implement the conversions documented in #59800
9704 2006-10-10 Martin Baulig <martin@ximian.com>
9706 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9707 before RootScope.ResolveMembers().
9709 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9710 `CurrentType' if appropriate.
9712 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9714 A fix for bug #78568
9715 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9716 when contains binary operators.
9717 * cs-parser.jay: Updated.
9719 2006-10-09 Martin Baulig <martin@ximian.com>
9722 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9723 moved that into Define() and also do the other type parameter
9724 checks there. Fixes #79094. Added gtest-292.cs.
9727 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9728 since that doesn't include type parameters; don't use `Ldelema'
9729 for type parameters. Fixes #78980. Added gtest-293.cs.
9731 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9734 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9735 conversion is allowed.
9737 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9739 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9740 error reporting when no error occurs.
9742 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9744 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9747 2006-10-06 Raja R Harinath <rharinath@novell.com>
9750 * class.cs (DefineTypeBuilder): Check circular dependencies before
9751 setting the parent of the TypeBuilder.
9752 (CheckRecursiveDefinition): Don't use 'BaseType', since
9753 it may not be valid until after DefineTypeBuilder. Use
9754 'base_type' instead.
9756 2006-10-04 Martin Baulig <martin@ximian.com>
9758 Merged the Anonymous Methods patch.
9760 * anonymous.cs, iterators.cs: The new anonymous methods code.
9762 * statement.cs (Variable): New public abstract class.
9763 (LocalInfo.Variable): New public property.
9764 (LocalInfo.ResolveVariable): New public method.
9765 (Block.Flags): Add `IsIterator'.
9766 (Block.AddVariable): Improved the CS0136 check.
9767 (Block.AnonymousChildren): New public property.
9768 (Block.AddAnonymousChild): New public method.
9769 (ToplevelBlock): Update to use the new anonymous method framework.
9770 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9771 `ToplevelBlock'; this is required to correctly implement the
9773 (Fixed, Using): Use `TemporaryVariable' instead of directly
9774 creating the `LocalBuilder'.
9776 * parameter.cs (Parameter.ResolveVariable): New public method.
9777 (Parameters.ResolveVariable): Likewise.
9779 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9781 * class.cs (TypeContainer): Replaced the `iterators' list and
9782 corresponding methods with a list of `CompilerGeneratedClass'es.
9783 (TypeContainer.ResolveMembers): New public method.
9784 (Method): `IIteratorContainer' has been replaced by
9787 * expression.cs (VariableReference): New public abstract base
9788 class for `LocalVariableReference', `ParameterReference' and
9791 * codegen.cs (EmitContext): Removed `capture_context',
9792 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9793 (EmitContext.EmitThis): Removed.
9795 * cs-parser.jay: Replace `iterator_container' with
9798 2006-10-04 Martin Baulig <martin@ximian.com>
9800 * generic.cs (GenericMethod): Don't make this abstract.
9801 (Constraints.Clone): Added dummy implementation.
9803 2006-10-04 Raja R Harinath <harinath@gmail.com>
9806 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9807 'declspaces'. Avoid allocating arrays willy-nilly.
9810 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9811 cases out of the switch.
9813 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9815 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9816 message when non-generic type is used with the type arguments.
9817 * expression.cs: Updated.
9819 2006-09-28 Raja R Harinath <rharinath@novell.com>
9822 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9823 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9824 Change semantics slightly. Don't insist on having only one
9825 temporary EmptyExpression -- just throttle the creation of new ones.
9828 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9829 non-interfaces too. If no methods are found, don't try to create
9832 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9834 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9837 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9838 us produce better error message.
9840 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9842 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9843 of the `|' operator.
9845 * report.cs: A new warning added.
9847 2006-09-27 Martin Baulig <martin@ximian.com>
9849 * generic.cs (GenericMethod): Don't make this abstract.
9851 2006-09-27 Martin Baulig <martin@ximian.com>
9854 (InternalErrorException): Added overloaded ctor taking a params array.
9856 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9858 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9859 Fixed the cases when same error was reported twice.
9861 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9862 now report symbol information.
9864 2006-09-25 Martin Baulig <martin@ximian.com>
9866 * class.cs: Completely unified with the gmcs version.
9868 2006-09-25 Martin Baulig <martin@ximian.com>
9870 * typemanager.cs (TypeManager.IsNullableType): New public function.
9871 (TypeManager.IsNullableTypeOf): Likewise.
9872 (TypeManager.IsNullableValueType): Likewise.
9874 * class.cs (MethodCore): Added the `GenericMethod' argument from
9875 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9877 2006-09-24 Raja R Harinath <harinath@gmail.com>
9879 * convert.cs: Unify with gmcs version.
9881 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9883 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9884 verify them as well.
9886 * report.cs: New warning.
9888 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9890 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9891 for anonymous block with out argument.
9893 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9895 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9896 not used private events only.
9898 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9900 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9902 * const.cs (Const.Define): Check for constant type.
9903 (Const.IsConstantTypeValid): Looks for valid constant types.
9905 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9907 * ecore.cs (EmptyConstantCast): New common class for all constant based
9910 * expression.cs (Is.DoResolve): Handle null constant especially.
9911 (New.DoResolve): Check for new void().
9912 (MemberAccess.DoResolve): Cope with all kind of nulls.
9914 * literal.cs (NullConstant): Uses EmptyConstantCast.
9915 (NullDefault): Based on EmptyConstantCast.
9916 (NullLiteral): Uses EmptyConstantCast.
9918 * statement.cs (Block.ResolveMeta): Check for constant type.
9920 2006-09-22 Martin Baulig <martin@ximian.com>
9922 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9924 2006-09-22 Raja R Harinath <rharinath@novell.com>
9926 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9930 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9931 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9934 2006-09-22 Martin Baulig <martin@ximian.com>
9936 * ecore.cs: Merged with the gmcs version.
9938 * generic.cs (ConstructedType): New dummy class.
9939 (TypeArguments): Don't make this abstract.
9942 (TypeManager.IsGenericTypeDefinition): New method.
9943 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9945 2006-09-22 Raja R Harinath <rharinath@novell.com>
9947 * expression.cs (ComposedCast): Check for arrays of TypedReference
9948 before creating the type, not after.
9950 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9952 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9953 after ToType change.
9955 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9956 when constant must be implicitly convertible.
9958 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9960 * ecore.cs (NullCast): Derives from NullConstant.
9962 * expression.cs (Is.DoResolve): Removed useless variables.
9963 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9964 (New.Constantify): Add enum support.
9965 (MemberAccess.DoResolve): Add warning when accessing null constant or
9968 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9971 * literal.cs (NullConstant): New abstract class with common
9972 functionality for all null specializations.
9973 (NullDefault): Represents default(X) when result can be
9975 (NullLiteral): Updated.
9977 * report.cs: Add new warning.
9979 2006-09-21 Martin Baulig <martin@ximian.com>
9981 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9983 2006-09-21 Martin Baulig <martin@ximian.com>
9985 * generic.cs (GenericConstraints): New dummy class.
9986 (Constraints): Likewise.
9987 (TypeParameter): Likewise.
9988 (TypeParameterName): Likewise.
9989 (GenericMethod): Likewise.
9991 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9993 * decl.cs: Merged with the gmcs version.
9995 2006-09-21 Raja R Harinath <rharinath@novell.com>
9997 * generic.cs (TypeParameter): Implement IMemberContainer.
9998 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
10000 * rootcontext.cs: Unify with gmcs version.
10002 * report.cs: Unify with gmcs version.
10003 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
10004 from gmcs/generics.cs.
10005 * generics.cs (TypeParameter): New dummy class.
10007 * support.cs: Unify with gmcs version.
10009 2006-09-20 Raja R Harinath <rharinath@novell.com>
10011 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
10012 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
10014 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
10015 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
10016 * mcs.exe.sources: Add generic.cs.
10018 * codegen.cs: Unify with gmcs version.
10020 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
10021 (EmitContext): Add GenericDeclContainer implementation.
10022 * decl.cs (MemberCore, DeclSpace): Likewise.
10023 * namespace.cs: Remove #ifdef GMCS_SOURCE.
10025 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
10026 MCS TypeManager has a corresponding dummy method.
10028 2006-09-19 Martin Baulig <martin@ximian.com>
10030 * expression.cs: Completely merged with the gmcs version.
10032 2006-09-19 Martin Baulig <martin@ximian.com>
10034 * expression.cs (Invocation): Merged with the gmcs version.
10035 (ArrayAccess.GetStoreOpcode): Likewise.
10037 2006-09-19 Martin Baulig <martin@ximian.com>
10040 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
10041 (TypeManager.IsGenericMethodDefinition): Likewise.
10043 2006-09-19 Martin Baulig <martin@ximian.com>
10046 (TypeManager.IsEqual): Moved the gmcs implementation here.
10047 (TypeManager.DropGenericTypeArguments): Likewise.
10048 (TypeManager.DropGenericMethodArguments): Likewise.
10049 (TypeManager.GetTypeArguments): Moved here from gmcs.
10050 (TypeManager.HasGenericArguments): Likewise.
10052 2006-09-19 Martin Baulig <martin@ximian.com>
10054 * expression.cs (Binary): Merged with the gmcs version.
10056 2006-09-19 Martin Baulig <martin@ximian.com>
10058 * expression.cs (Probe, As, Is): Merged with the gmcs version.
10060 2006-09-19 Martin Baulig <martin@ximian.com>
10062 * typemanager.cs: Merged with the gmcs version.
10064 2006-09-16 Raja R Harinath <rharinath@novell.com>
10066 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
10067 * driver.cs: Likewise.
10069 2006-09-16 Marek Safar <marek.safar@seznam.cz>
10072 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
10073 only if parent type is class.
10074 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
10077 2006-09-15 Marek Safar <marek.safar@seznam.cz>
10080 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
10082 * typemanager.cs(CSharpName): Converts NullType to null.
10084 2006-09-15 Martin Baulig <martin@ximian.com>
10087 (TypeManager.GetMethodName): Added mcs implementation.
10088 (TypeManager.IsEqual): Likewise.
10091 (SimpleName.RemoveGenericArity): Added dummy implementation.
10093 * pending.cs: Merged with the gmcs version.
10095 2006-09-15 Martin Baulig <martin@ximian.com>
10097 * statement.cs: Merge with the gmcs version.
10099 2006-09-15 Martin Baulig <martin@ximian.com>
10101 * statement.cs (Switch): Merge with the gmcs implementation
10102 (without nullables), which is newer.
10104 2006-09-15 Martin Baulig <martin@ximian.com>
10106 * statement.cs (Block.Variables): Make this public.
10107 (ToplevelBlock.Parameters): Make this a property.
10108 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
10110 2006-09-15 Martin Baulig <martin@ximian.com>
10112 * namespace.cs: Merge with the gmcs version.
10114 2006-09-15 Martin Baulig <martin@ximian.com>
10116 * decl.cs (MemberName): Minor code cleanups.
10118 2006-09-15 Martin Baulig <martin@ximian.com>
10120 * parameter.cs: Merge with the gmcs version.
10122 2006-09-15 Martin Baulig <martin@ximian.com>
10124 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
10125 and an error in mcs.
10127 2006-09-15 Martin Baulig <martin@ximian.com>
10129 * flowanalysis.cs: Merged from GMCS; added the generics code into
10130 a `GMCS_SOURCE' conditional so we can share this file.
10132 2006-09-08 Martin Baulig <martin@ximian.com>
10134 * typemanager.cs (TypeManager.interlocked_type): New public field.
10135 (TypeManager.int_interlocked_compare-exchange): New public field.
10136 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
10137 enumerator types here and call InitGenericCoreTypes().
10138 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
10139 after calling InitEnumUnderlyingTypes().
10142 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
10143 `classes_second_stage'.
10145 2006-09-14 Marek Safar <marek.safar@seznam.cz>
10147 * assign.cs, ecore.cs, expression.cs: Share error message text.
10148 * class.cs (FieldMember.Define): Check for varible of static type.
10149 * driver.cs (LoadAssembly): Uses error output for errors.
10150 * statement.cs: Updated.
10152 2006-09-08 Marek Safar <marek.safar@seznam.cz>
10154 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
10157 2006-09-07 Martin Baulig <martin@ximian.com>
10160 (MainDriver): Revert r62663 from Marek; see #70506 for details.
10162 2006-08-29 Miguel de Icaza <miguel@novell.com>
10164 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
10166 2006-08-17 Miguel de Icaza <miguel@novell.com>
10168 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
10169 #52019 and #79064, the use of the \uXXXX sequence in source code
10170 to represent unicode characters.
10172 2006-08-15 Marek Safar <marek.safar@seznam.cz>
10174 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
10176 * class.cs, ecore.cs, statement.cs: Merged to one error message.
10178 2006-08-13 Miguel de Icaza <miguel@novell.com>
10180 * assign.cs: Catch attempts to assign to a method groups in += and
10183 2006-08-13 Marek Safar <marek.safar@seznam.cz>
10186 * cs-parser.jay: Don't destroy current array type by typeof of array's.
10188 2006-08-12 Marek Safar <marek.safar@seznam.cz>
10190 * class.cs (Method.Define): Issue a warning when generic method looks like
10192 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
10195 2006-08-09 Marek Safar <marek.safar@seznam.cz>
10197 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
10199 * decl.cs (MemberCache.FindMembers): When container is interface we need to
10200 search all base interfaces as a member can be ambiguous.
10201 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
10202 Constructor member type filter.
10203 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
10204 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
10205 reporting for returned memberinfos.
10206 * report.cs: Updated.
10207 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
10208 version to work on all runtimes.
10209 (TypeManager.RealMemberLookup): Removed members filtering.
10211 2006-08-08 Raja R Harinath <rharinath@novell.com>
10213 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
10214 (PropertyExpr.EmitAssign): Likewise.
10215 * expression.cs (Indirection.EmitAssign): Likewise.
10216 (LocalVariableReference.EmitAssign): Likewise.
10217 (ParameterReference.EmitAssign): Likewise.
10218 (Invocation.EmitArguments): Likewise.
10219 (ArrayAccess.EmitAssign): Likewise.
10220 (IndexerAccess.EmitAssign): Likewise.
10221 (This.EmitAssign): Likewise.
10222 (ConditionalLogicalOperator.Emit): Likewise.
10225 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
10226 instead of ArrayList. If the hashtable has a LocalBuilder, don't
10227 leave it in after returning it.
10228 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
10230 2006-08-06 Marek Safar <marek.safar@seznam.cz>
10232 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
10235 2006-08-03 Raja R Harinath <rharinath@novell.com>
10237 Fix cs0146-3.cs and cs0146-4.cs.
10238 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
10239 enclosing types don't depend on the current type.
10241 2006-08-02 Raja R Harinath <rharinath@novell.com>
10244 * class.cs (TypeContainer.DoDefineMembers): Use
10245 FindBaseMemberWithSameName on Parent, since we're interested in
10246 whether we hide inherited members or not.
10247 (FindBaseMemberWithSameName): Make slightly more robust.
10249 Fix the non-generic testcase from #77396
10250 * decl.cs (DeclSpace.DeclContainer): Remove override.
10252 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
10253 declspaces for doppelgangers too.
10254 (UsingEntry): Implement IResolveContext.
10255 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
10256 'this' as the resolve context.
10257 (LocalAliasEntry): Likewise.
10259 Implement parts of #77403
10260 * roottypes.cs (RootDeclSpace): New. Used to represent the
10261 toplevel declaration space. Each namespace declaration introduces
10262 a "partial" root declaretion space.
10263 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
10264 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
10265 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
10266 from 'current_namespace.SlaveDeclSpace'.
10267 (namespace_declaration): Likewise.
10268 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10269 check. It can't happen now.
10270 * decl.cs (DeclSpace.LookupType): Likewise.
10271 * driver.cs (MainDriver): Sanity check.
10273 2006-08-01 Raja R Harinath <rharinath@novell.com>
10275 * decl.cs (DeclSpace.FindNestedType): Remove.
10276 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10277 LookupTypeContainer to get the container of the nested type.
10278 * class.cs (TypeContainer.FindNestedType): Make non-override.
10280 2006-07-31 Raja R Harinath <rharinath@novell.com>
10282 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10283 * class.cs (TypeContainer.PartialContainer): ... here.
10284 (TypeContainer.AddBasesForPart): New helper.
10285 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10287 * cs-parser.jay (current_class): Convert to DeclSpace.
10288 (struct_declaration, interface_declaration, class_declaration):
10289 Use AddBasesForPart instead of .Bases directly.
10290 * const.cs, iterators.cs: Update to changes.
10292 2006-07-28 Raja R Harinath <rharinath@novell.com>
10294 * class.cs (TypeContainer.AddMemberType): Rename from
10295 AddToTypeContainer.
10296 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10297 (AddTypeContainer): New. Combine AddClassOrStruct and
10299 (AddPartial): Update. Add 'is_partial' argument.
10300 * roottypes.cs: Update to changes.
10301 * cs-parser.jay (push_current_class): New helper for handling
10302 current_container and current_class.
10303 (struct_declaration, interface_declaration, class_declaration):
10306 2006-07-26 Raja R Harinath <rharinath@novell.com>
10308 * roottypes.cs: Rename from tree.cs.
10310 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10311 * tree.cs (Tree, ITreeDump): Remove types.
10312 * rootcontext.cs (tree, Tree): Remove fields.
10313 (root, ToplevelTypes): New.
10314 * *.cs: Update to rename.
10316 * tree.cs (Tree.RecordDecl): Remove.
10317 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10319 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10321 2006-07-23 Raja R Harinath <harinath@gmail.com>
10323 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10324 DoFlowAnalysis and OmitStructFlowAnalysis here.
10325 (ec.With): Rename from WithUnsafe and generalize.
10326 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10327 (ec.WithFlowAnalyis): New.
10328 * ecore.cs, expression.cs, statement.cs: Update.
10330 2006-07-22 Raja R Harinath <harinath@gmail.com>
10332 * statement.cs (Block.ResolveMeta): Simplify slightly.
10334 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10335 multiple boolean fields. Convert InUnsafe, constant_check_state,
10336 check_state to flags.
10337 (CheckState, ConstantCheckState): Update.
10338 (InUnsafe): New read-only property.
10339 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10341 (WithUnsafe): New helper similar to WithCheckState.
10342 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10343 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10345 2006-07-21 Raja R Harinath <rharinath@novell.com>
10347 Make comparisons use the same IL irrespective of whether they're
10348 in a 'checked' or 'unchecked' context: one of the issues in #78899
10349 * codegen.cs (EmitContext.CheckState): Make read-only property.
10350 (EmitContext.ConstantCheckState): Likewise.
10351 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10352 helper that implement a save/restore stack for CheckState
10353 values. This is the only way to change check-state.
10354 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10355 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10356 (CheckedExpr.EmitBranchable): New forwarding method.
10357 (UnCheckedExpr): Likewise.
10358 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10359 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10360 (Checked.Resolve, checked.DoEmit): Likewise.
10362 2006-07-20 Miguel de Icaza <miguel@novell.com>
10364 * anonymous.cs: Cache the resolved anonymous delegate, and return
10365 this so that the ResolveTopBlock is only triggered once, not
10368 Currently we trigger ResolvetopBlock twice due to a first pass of
10369 argument check compatibility, and a second pass that does the
10372 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10374 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10376 * rootcontext.cs (Reset): Add helper_classes.
10378 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10381 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10384 2006-07-13 Miguel de Icaza <miguel@novell.com>
10386 * statement.cs (Lock): Handle expressions of type
10387 TypeManager.null_type specially. Fixes #78770
10389 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10391 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10394 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10396 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10397 for accessors as well.
10398 * ecore.cs (EventExpr): Add AccessorTable.
10400 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10403 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10404 for CS0122 where appropriate.
10405 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10407 (Filter): Assembly can be null in the case of top level attributes.
10409 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10413 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10414 is done at global level.
10416 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10418 A fix for #77002, Implemented TypeForwarder support.
10420 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10421 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10422 * typemanager.cs (): Add type_forwarder_attr_type.
10424 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10426 * report.cs: Add CS0469 warning.
10428 2006-06-21 Martin Baulig <martin@ximian.com>
10430 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10431 the `try'-block, so we also report CS0016 etc. there.
10433 2006-06-21 Martin Baulig <martin@ximian.com>
10436 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10438 2006-06-21 Martin Baulig <martin@ximian.com>
10440 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10441 also report CS1686 for parameters.
10443 2006-06-21 Martin Baulig <martin@ximian.com>
10445 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10446 instead of an error if the value is not implicitly convertible to
10447 the switch types; fixes #77964.
10449 2006-06-21 Raja R Harinath <rharinath@novell.com>
10452 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10453 FieldBuilder is null.
10456 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10457 'left' and 'right' before error-checking.
10459 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10461 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10463 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10464 (FieldExpr.DoResolve): likewise.
10465 (PropertyExpr.InstanceResolve): likewise.
10466 (EventExpr.InstanceResolve): likewise.
10468 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10470 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10471 attribute applicable tests for attribute argument.
10473 2006-06-02 Raja R Harinath <rharinath@novell.com>
10476 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10477 (Binary.OverloadResolve_PredefinedIntegral): New.
10478 (Binary.OverloadResolve_PredefinedFloating): New.
10479 (Binary.OverloadResolve_PredefinedString): New.
10480 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10481 Follow the standard more closely, and treat numeric promotions in
10482 terms of overload resolution.
10483 (Binary.CheckShiftArguments): Simplify.
10485 2006-06-01 Raja R Harinath <rharinath@novell.com>
10487 * flowanalysis.cs (MyBitVector): Simplify representation.
10488 (MyBitVector.Clone): Avoid allocating BitArray.
10489 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10490 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10491 (*): Update. Change all references to MyBitVector.And and
10492 MyBitVector.Or to &= and |=.
10494 2006-05-29 Raja R Harinath <rharinath@novell.com>
10496 Fix cs0231-[34].cs.
10497 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10498 to param arguments too.
10500 2006-05-26 Miguel de Icaza <miguel@novell.com>
10502 * cs-parser.jay: Catch another parsing form for arglist being
10503 followed by other arguments. Fixes #78313.
10505 2006-05-24 Raja R Harinath <rharinath@novell.com>
10507 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10508 checking of out parameters to ...
10509 (FlowBranchingToplevel.Merge): ... here.
10510 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10511 set, propagate the origin upward, and only complain if there was
10513 (FlowBranchingException.AddContinueOrigin): Likewise.
10514 (FlowBranchingException.AddReturnOrigin): Likewise.
10515 (FlowBranchingException.AddGotoOrigin): Likewise.
10517 2006-05-23 Raja R Harinath <rharinath@novell.com>
10519 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10520 unreachable, skip it.
10521 (FlowBranchingException.Merge): Always propagate jumps, even if
10522 the finally block renders subsequent code unreachable.
10524 2006-05-18 Raja R Harinath <rharinath@novell.com>
10527 * statement.cs (Goto.Resolve): Move responsibility for resolving
10528 'goto' to FlowBranching.AddGotoOrigin.
10529 (Goto.SetResolvedTarget): New. Callback to set the
10530 LabeledStatement that's the target of the goto.
10531 (Goto.DoEmit): Use Leave instead of Br when crossing an
10532 unwind-protect boundary.
10533 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10534 LookupLabel and adjust to new semantics.
10535 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10536 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10537 Goto.SetResolvedTarget to update target.
10538 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10539 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10540 AddBreakOrigin & co. Delay propagation until ...
10541 (FlowBranchingException.Merge): ... this.
10543 * statement.cs (Block.Resolve): Always depend on flow-branching to
10544 determine unreachability. Kill workaround that originally emitted
10545 only one statement after an "unreachable" label (see infloop in
10548 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10549 This is still "wrong", but anything better would probably need a
10550 multi-pass algorithm.
10551 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10552 usage vector. Force current usage vector to be reachable, to
10553 optimistically signify backward jumps.
10554 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10556 (FlowBranchingLabeled.Merge): New. If no backward jump was
10557 detected, return the original salted-away usage vector instead,
10558 updated with appropriate changes. Print unreachable warning if
10560 * statement.cs (Block.Resolve): Don't print unreachable warning on
10561 a labeled statement.
10563 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10565 * driver.cs: Pass filename without path to AssemblyBuilder's
10566 AddResourceFile. Fixes bug #78407.
10568 2006-05-17 Raja R Harinath <rharinath@novell.com>
10570 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10571 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10572 (FlowBranching.MergeChild): Overwrite
10573 reachability information from Labeled branchings too.
10575 2006-05-16 Raja R Harinath <rharinath@novell.com>
10577 * statement.cs (Goto.Resolve): Merge jump origins here ...
10578 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10580 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10581 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10582 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10583 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10585 * statement.cs (Goto.Resolve): ... not here.
10586 (Goto.Emit): Remove CS1632 check.
10588 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10590 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10593 2006-05-11 Raja R Harinath <rharinath@novell.com>
10595 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10596 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10597 (FlowBranchingException.Label): Likewise.
10599 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10601 (MyBitVector.Or): Use it to avoid losing information (Count).
10602 (FlowBranching.MergeOrigins): Likewise.
10604 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10605 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10606 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10607 (UsageVector.ToString): Simplify.
10608 (UsageVector.MergeSiblings): Move here from ...
10609 (FlowBranching.Merge): ... here.
10610 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10613 2006-05-10 Raja R Harinath <rharinath@novell.com>
10615 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10616 null bitvector is treated as all-true.
10618 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10619 (MyBitVector): Rationalize invariants. 'vector != null' implies
10620 that we have our own copy of the bitvector. Otherwise,
10621 'InheritsFrom == null' implies all inherited bits are true.
10623 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10625 * statement.cs (LocalInfo): Add IsConstant.
10626 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10627 local variable for constants.
10629 2006-05-09 Raja R Harinath <rharinath@novell.com>
10631 * flowanalysis.cs (MyBitVector.Empty): New.
10632 (MyBitVector): Don't allow InheritedFrom to be null.
10633 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10634 (UsageVector, FlowBranching): Update to changes.
10636 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10637 recursion. The 'Parent == null' condition isn't sufficient for
10639 (FlowBranching.AddBreakOrigin): Likewise.
10640 (FlowBranching.AddContinueOrigin): Likewise.
10641 (FlowBranching.AddReturnOrigin): Likewise.
10642 (FlowBranching.StealFinallyClauses): Likewise.
10643 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10644 (FlowBranching.CheckOutParameters): Likewise.
10645 (FlowBranchingToplevel): Terminate all the above recursions here.
10646 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10647 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10649 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10651 (FlowBranchingToplevel): New. Empty for now.
10652 (FlowBranching.MergeTopBlock): Update.
10653 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10654 branching for the anonymous delegate.
10655 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10657 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10658 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10659 information at the start of the merge. Reorganize.
10661 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10663 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10665 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10667 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10668 to newly introduced ctor.
10670 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10671 message to one place.
10672 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10675 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10677 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10679 * ecore.cs (Expression.ResolveAsConstant): Updated.
10681 * statement.cs (ResolveMeta): Updated.
10683 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10685 * cs-parser.jay: __arglist cannot be used in initializer.
10687 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10690 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10693 2006-05-05 Raja R Harinath <rharinath@novell.com>
10695 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10696 (LabeledStatement): Add 'name' parameter.
10697 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10698 (Block.AddLabel): Update to changes.
10699 * cs-parser.jay (labeled_statement): Likewise.
10701 * flowanalysis.cs (BranchingType.Labeled): New.
10702 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10703 (FlowBranchingLabeled): New. Does nothing for now, but will
10704 eventually handle 'goto' flows.
10705 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10706 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10707 that's terminated ...
10708 (Block.Resolve): ... here.
10710 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10711 (UsageVector.MergeFinallyOrigins): Likewise.
10712 (FlowBranching.InTryOrCatch): Likewise.
10713 (FlowBranching.AddFinallyVector): Likewise.
10714 (FlowBranchingException): Update to changes.
10717 * statement.cs (Return.Resolve): Move error checking to ...
10718 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10719 (FlowBranchingException): Handle return origins like break and
10721 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10723 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10726 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10729 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10732 * class.cs (MethodData.Define): Do public accessor check only when method
10733 implements an interface.
10735 2006-05-04 Raja R Harinath <rharinath@novell.com>
10737 Remove special handling of 'break'
10738 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10739 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10740 (UsageVector.Break): Remove.
10741 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10743 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10745 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10746 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10748 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10751 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10752 be the interface member.
10754 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10757 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10758 for emitting small (int) values.
10760 2006-05-03 Raja R Harinath <rharinath@novell.com>
10763 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10764 control-flow passes through the 'finally' after merging-in all the
10765 control-flows from 'try' and the 'catch' clauses.
10767 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10768 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10769 always true at the only non-recursive entry point.
10770 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10771 FlowBranchingBreakable.
10772 (FlowBranchingLoop): Remove.
10773 * statement.cs (Return.DoResolve): Update to changes.
10776 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10777 (FlowBranching.CreateBranching): Handle it: create a
10778 FlowBranchingContinuable.
10779 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10780 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10781 except that it handles the 'continue' command.
10782 (FlowBranching.UsageVector.MergeOrigins): Rename from
10784 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10785 except that it overrides AddContinueOrigin.
10786 (FlowBranchingException): Override AddContinueOrigin, similar to
10788 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10789 Create a new branching around the embedded statement.
10790 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10791 control flow after the embedded statement.
10792 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10794 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10795 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10796 FlowBranchingBreakable.
10797 (FlowBranchingSwitch): Remove.
10800 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10801 error reporting to ...
10802 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10803 Rename from 'AddBreakVector'. Add new location argument. Return
10804 a bool indicating whether the 'break' crosses an unwind-protect.
10805 (FlowBranchingException.AddBreakOrigin): Add.
10806 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10807 flowbranching after updating with the effects of the 'finally'
10809 (FlowBranchingBreakable): New common base class for
10810 FlowBranchingLoop and FlowBranchingSwitch.
10812 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10813 embedded statement.
10814 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10816 2006-05-02 Raja R Harinath <rharinath@novell.com>
10818 * statement.cs (Do.Resolve): If the loop is infinite, set the
10820 (While.Resolve, For.Resolve): Set a barrier after the embedded
10821 statement. There's no direct control flow that goes from the end
10822 of the embedded statement to the end of the loop.
10823 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10824 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10825 above ensure that the reachability is correctly computed.
10827 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10828 (UsageVector.MergeBreakOrigins): If the current path is
10829 unreachable, treat it as if all parameters/locals are initialized.
10830 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10831 infinite loops before merging-in break origins.
10833 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10834 (Reachability.Reachable): Split part into ...
10835 (Reachability.Unreachable): ... this. Simplify.
10836 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10838 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10839 (Reachability.SetThrowsSometimes): Likewise.
10840 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10841 TriState.Always, use corresponding property.
10842 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10843 (Block.Resolve): Likewise. Remove some redundant checks.
10845 2006-05-02 Raja R Harinath <harinath@gmail.com>
10847 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10848 (Reachability.Meet): Don't bother checking AlwaysThrows --
10849 barrier is always set.
10850 (FlowBranchingBlock.Merge): Likewise.
10852 2006-05-01 Raja R Harinath <harinath@gmail.com>
10854 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10855 checks for unreachable.
10857 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10860 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10862 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10863 whether field is really assigned.
10865 2006-04-30 Raja R Harinath <harinath@gmail.com>
10867 * flowanalysis.cs (Reachability): Make 4-argument constructor
10869 (Reachability.Meet): Rename from 'And'. Remove static variant.
10870 (Reachability.Always): Rename from the highly misleading
10871 'Reachability.Never'.
10872 (FlowBranching.Merge): Update to changes. Mark an impossible
10873 situation with a 'throw'.
10874 (*): Update to changes.
10876 2006-04-29 Raja R Harinath <harinath@gmail.com>
10878 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10879 Remove 'Undefined'.
10880 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10881 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10882 (*): Update to changes.
10883 * statement.cs: Update to changes.
10885 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10888 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10890 2006-04-28 Raja R Harinath <harinath@gmail.com>
10892 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10895 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10896 argument to two arguments: an usage-vector and a bool. Move call
10897 to FlowBranching.Merge () ...
10898 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10900 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10901 handling of loop and switch reachability to ...
10902 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10904 2006-04-27 Raja R Harinath <harinath@gmail.com>
10906 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10907 handling to FlowBranchingLoop.InLoop.
10908 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10910 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10913 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10914 anonymous method is allowed from AnonymousContainer here.
10916 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10918 2006-04-24 Raja R Harinath <rharinath@novell.com>
10921 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10923 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10926 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10927 (DoubleConstant.Reduce): Ditto.
10929 2006-04-23 Raja R Harinath <rharinath@novell.com>
10931 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10932 Remove 'lvalue_right_side' argument. Move parts to ...
10933 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10934 (LocalVariable.DoResolveLValue): ... these.
10936 2006-04-21 Raja R Harinath <rharinath@novell.com>
10939 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10940 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10941 (LocalVariableReference.DoResolveBase): Use it to implement new
10943 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10944 (Argument.Resolve): Simplify. Move CS1510 check ...
10945 * ecore.cs (Expression.ResolveLValue): ... here.
10946 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10947 (PropertyExpr.DoResolveLValue): Likewise.
10948 (FieldExpr.Report_AssignToReadonly): Likewise.
10949 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10950 LValueMemberAccess or LValueMemberOutAccess on instance depending
10952 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10953 DoResolve as appropriate.
10955 2006-04-20 Raja R Harinath <rharinath@novell.com>
10958 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10959 implicit conversions on 'out' and 'ref' arguments.
10961 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10962 improve clarity. Remove dead code.
10965 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10966 (Catch.Resolve): Resolve VarBlock if it exists.
10968 2006-04-19 Miguel de Icaza <miguel@novell.com>
10970 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10971 twice, this was some residual code, the enumerator was emitted
10972 properly in the two branche of if later.
10974 2006-04-19 Raja R Harinath <rharinath@novell.com>
10976 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10977 cast is never an lvalue.
10978 (Cast.DoResolve, Cast.ResolveRest): Combine.
10979 (Argument.Emit): Simplify slightly. Move 'Expr is
10980 IMemoryLocation' check ...
10981 (Argument.Resolve): ... here.
10982 (Argument.Error_LValueRequired): Remove. Inline into only user.
10984 Simplifications. Fix cs0191-2.cs
10985 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10986 CS1649 and CS1651 to ...
10987 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10988 the actual selection of the error code and message to a lookup
10989 table. Add a dummy return value to simplify callsites.
10990 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10991 readonly fields of other instances of the same type. Move CS0197
10993 * expression.cs (Argument.Resolve): ... here. Simplify code.
10994 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10995 resolution of an out or ref argument. The code simplification
10996 above uses this invariant.
10998 2006-04-18 Raja R Harinath <rharinath@novell.com>
11000 Possibly fix #77752. Fix cs1690-[4-7].cs.
11001 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
11002 CheckMarshallByRefAccess. Drop parameter.
11003 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
11005 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
11006 InstanceExpression.
11007 * report.cs (AllWarnings): Add CS1690.
11008 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
11009 for ref access too.
11010 (LocalVariableReference.DoResolveBase): Update.
11012 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11014 * class.cs (MethodOrOperator): Moved common parts from method class.
11015 detect obsolete attributes.
11016 (Method.Define): Simplified as it reuses code from base.
11017 (Constructor.ValidAttributeTargets): Fixed issue found during
11019 (Destructor.ValidAttributeTargets): Fixed issue found during
11021 (Operator): Finished refactoring set off by #78020. Operator class is now
11022 ordinary method class.
11024 * anonymous.cs: Updated.
11026 * decl.cs (DeclSpace): Add IsGeneric
11028 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11030 * class.cs (Constructor.Emit): Don't emit the attributes twice.
11032 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11034 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
11035 detect obsolete attributes.
11036 (Method.CreateEmitContext): Moved to MethodOrOperator.
11038 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11041 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
11042 customized exception to make crash detection easier.
11043 (MethodOrOperator): Started to work on new base class for methods and
11045 (Method): Derives from MethodOrOperator.
11046 (Constructor.Emit): Emits its own attributes.
11047 (AbstractPropertyEventMethod.Emit): Ditto.
11048 (Operator): Derives from MethodOrOperator, will refactor fully in extra
11050 (Operator.Emit): It's temporary more tricky than should be.
11052 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
11054 * report.cs (InternalErrorException): Add ctor with inner exception.
11056 2006-04-08 Marek Safar <marek.safar@seznam.cz>
11059 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
11062 2006-04-07 Marek Safar <marek.safar@seznam.cz>
11065 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
11068 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11070 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
11071 attribute is present and Guid not.
11072 (Interface.ApplyAttributeBuilder): Ditto.
11074 * attribute.cs: Add error message.
11076 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11080 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
11081 sources (it's composite) so hold them in extra array as they are used in
11082 Emit phase only. It worked in the previous versions by mistake.
11083 (Attribute.Emit): Emit attribute for more owners when exist.
11085 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
11086 it has now different behaviour.
11088 2006-04-04 Marek Safar <marek.safar@seznam.cz>
11090 * constant.cs (Constant.IsDefaultInitializer): New method.
11092 * class.cs: Updated.
11094 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
11095 re-initialize default values. It saves KBs almost for every assembly.
11096 Thanks Zoltan for the idea.
11097 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
11098 (ArrayCreation.DoResolve): Resolve only once.
11099 (ArrayCreation.Emit): Emit static initializer only when it is faster.
11100 (ArrayCreation.GetAttributableValue): Cope with optimized values.
11102 2006-04-03 Zoltan Varga <vargaz@gmail.com>
11104 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
11107 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11109 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
11110 in an embedded statement too.
11112 2006-04-01 Raja R Harinath <rharinath@novell.com>
11115 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
11117 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11121 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
11124 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
11126 2006-03-31 Marek Safar <marek.safar@seznam.cz>
11128 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
11131 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
11132 LocalTemporary change.
11134 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
11136 (ClassOrStruct.DefineFieldInitializers): Implemented static field
11137 initializers optimization.
11138 (ClassOrStruct.TypeAttr): Moved from modifiers.
11139 (Constructor.CheckBase): Don't crash when static ctor has parameters.
11140 (FieldBase.ResolveInitializer): Resolves initializer.
11141 (FieldBase.HasDefaultInitializer): New property.
11143 * cs-parser.jay: Removed message.
11145 * expression.cs (CompilerGeneratedThis): New specialization.
11147 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
11149 2006-03-28 Marek Safar <marek.safar@seznam.cz>
11151 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
11153 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11155 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
11156 be now EnumConstants only.
11158 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11160 * attribute.cs, driver.cs: Reset more caches.
11162 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11164 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
11166 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11168 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
11169 for easier reuse. Updated all overrides.
11170 (IntegralConstant): New base class for all integral constants.
11171 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
11172 of the constant range, report custom error.
11173 (UIntConstant.Reduce): Fixed uint conversion.
11175 * ecore.cs, literal.cs: Reduce updates.
11177 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11181 * class.cs (Constructor.Define): Removed extra if for default ctors.
11182 A patch from Atsushi Enomoto.
11184 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11186 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
11187 GetAttributableValue.
11189 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
11192 * convert.cs (ImplicitConversionRequired): Error message moved to
11195 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
11196 automatic implicit conversion of an output value.
11197 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
11199 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
11201 (TypeOf.GetAttributableValue): Add extra handling for object type.
11203 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
11204 special error message.
11206 2006-03-25 Marek Safar <marek.safar@seznam.cz>
11208 * class.cs (Constructor.Emit): Don't crash when struct ctor is
11210 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
11211 compatible with MS runtime.
11213 2006-03-23 Marek Safar <marek.safar@seznam.cz>
11215 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
11216 attribute arguments here.
11218 * class.cs (Indexer.Define): The check was moved to attribute class.
11220 2006-03-22 Marek Safar <marek.safar@seznam.cz>
11222 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
11223 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
11226 2006-03-22 Raja R Harinath <rharinath@novell.com>
11228 Support ParameterDefaultValueAttribute in gmcs. Also applied to
11229 mcs to keep code differences small.
11230 * attribute.cs (Attribute.GetParameterDefaultValue): New.
11231 * typemanager.cs (parameter_default_value_attribute_type): New.
11232 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
11235 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11237 * expression.cs (StringConcat.Append): Reverted back to no warning state.
11239 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11241 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
11243 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
11246 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
11248 * doc-bootstrap.cs : fix build.
11250 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11252 * expression.cs (StringConcat.Append): Issue a warning when empty string
11253 is going to append.
11255 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11257 * assign.cs (CompoundAssign.ResolveSource): Removed.
11259 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
11262 * class.cs (TypeContainer.FindMethods): Removed.
11263 (TypeContainer.CheckMemberUsage): Made static.
11265 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
11267 * constant.cs (CheckRange): Removed unused type argument.
11268 (CheckUnsigned): Removed unused type argument.
11270 * cs-parser.jay: Updated after MemberAccess clean up.
11271 Uses Length for empty string test.
11273 * cs-tokenizer.cs: Uses Length for empty string test.
11274 (IsCastToken): Made static.
11275 (is_hex): Made static.
11276 (real_type_suffix): Made static.
11278 * decl.cs (SetupCache): Made static.
11279 (OnGenerateDocComment): Removed unused ds argument.
11281 * delegate.cs (VerifyDelegate): Removed unused argument.
11283 * doc.cs: Uses Length for empty string test.
11285 * driver.cs: Uses Length for empty string test.
11287 * enum.cs (IsValidEnumType): Made static
11289 * expression.cs (EnumLiftUp): Removed unused argument.
11290 (ResolveMethodGroup): Ditto.
11291 (BetterConversion): Ditto.
11292 (GetVarargsTypes): Ditto.
11293 (UpdateIndices): Ditto.
11294 (ValidateInitializers): Ditto.
11295 (MemberAccess.ctor): Ditto.
11296 (GetIndexersForType): Ditto.
11298 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11300 * iterators.cs: Updated after MemberAccess clean up.
11302 * location.cs: Uses Length for empty string test.
11304 * namespace.cs: Uses Length for empty string test.
11306 * report.cs (CheckWarningCode): Made static.
11308 * statement.cs (LabeledStatement): Removed unused argument.
11310 * typemanager.cs (FilterNone): Removed.
11312 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11314 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11317 * class.cs: Updated.
11319 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11321 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11323 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11327 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11328 reporting, it's more tricky than I thought.
11330 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11334 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11336 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11337 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11338 Add more error reporting; Fixed issue with params.
11340 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11342 * cs-parser.jay: AnonymousMethod requires host container.
11344 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11346 2006-03-18 Raja R Harinath <harinath@gmail.com>
11348 * class.cs: Change 'TypeContainer ds' constructor argument to
11349 'DeclSpace parent'. Some classes were missed below due to
11350 different naming convention.
11352 * class.cs (MemberCore.Parent): Delete. This makes the
11353 ParentContainer changes below enforceable by the compiler.
11355 Treat pointers to enclosing declaration space as 'DeclSpace', not
11357 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11358 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11360 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11362 (Block.AddThisVariable): Likewise.
11363 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11364 (AbstractPropertyEventMethod.Emit): Likewise.
11365 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11366 (GetMethod.Define, SetMethod.Define): Likewise.
11367 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11368 (DelegateMethod.EmitMethod): Likewise.
11370 Fix regression test-partial-13.cs.
11371 Rationalize use of PartialContainer. Ensure that the partial
11372 class semantics can be tied to type-correctness, i.e., any
11373 violation will cause a compile error.
11374 * class.cs, const.cs: Access all fields that belong to class
11375 TypeContainer via ParentContainer. Arguments of EmitContexts and
11376 Resolve()-like functions still use 'Parent'.
11378 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11379 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11380 (PropertyMethod.CheckModifiers): Remove unused argument.
11381 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11384 2006-03-17 Raja R Harinath <harinath@gmail.com>
11386 Make semantics of PartialContainer simpler.
11387 * decl.cs (DeclSpace.IsPartial): Remove.
11388 * class.cs (TypeContainer.IsPartial): Likewise.
11389 (TypeContainer..ctor): Set PartialContainer to point to self.
11390 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11391 (TypeContainer.FindNestedType): Likewise.
11392 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11394 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11396 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11398 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11400 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11403 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11405 * class.cs (Operator.Define): An error for base conversion was not
11406 reported correctly.
11408 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11410 * iterator.cs : yield break is allowed in try statement which has
11411 catch clauses. Fixed bug #77767.
11413 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11415 A fix for #77593, #77574.
11417 * class.cs (MethodCore.CheckBase): Another if for operator.
11419 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11421 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11424 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11425 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11428 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11431 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11432 Updated after another emitcontext usage was clean up. It should help us to
11433 synchronize with gmcs easier.
11435 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11439 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11440 (Event.Define): ditto
11441 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11443 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11444 Removed redundant code and set NewSlot for Invoke method too.
11446 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11447 (Parameters.MergeGenerated): New method. Use this method when you merge
11448 compiler generated argument with user arguments.
11450 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11452 * attribute.cs (ResolveAsTypeTerminal): Removed.
11454 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11455 specialization for predefined types; 30% speed up.
11456 Finally placed obsolete check to right place.
11457 (Expression.ResolveType): Removed.
11459 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11460 Updated after ResolveType was removed.
11462 * expression.cs (Cast.ctor): Check void cast.
11463 (Binary.ResolveAsTypeTerminal): Is never type.
11464 (Conditional.ResolveAsTypeTerminal): Is never type.
11466 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11468 2006-03-01 Raja R Harinath <rharinath@novell.com>
11471 * expression.cs (ParameterReference.DoResolveBase): Change return
11473 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11477 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11480 * typemanager.cs (GetFullNameSignature): Don't nullref on
11481 protected accessors.
11483 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11485 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11486 these two separated members to simplify the code.
11487 (Attribute.Resolve): Refactored to use new fields and methods.
11488 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11489 implemented obsolete attribute checking.
11490 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11491 implemented obsolete checking again. It look line never ending quest ;-)
11492 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11494 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11496 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11498 *class.cs (Property.Define): Add RegisterProperty call.
11500 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11501 argument groups (only 2).
11503 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11504 encoding expression to arguments.
11505 (Expression.ExprClassToResolveFlags): Just turned to property.
11507 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11508 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11509 optimized as well as implemented support for zero-length attributes.
11511 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11512 Add caching of PropertyInfo's.
11514 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11516 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11517 error multiple times.
11519 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11521 New partial class implementation.
11522 A fix for #77027, #77029, #77403
11524 * attribute.cs (Attributable): Made attributes protected.
11526 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11527 the replacements of ClassPart and PartialContainer.
11528 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11529 (TypeContainer.AddInterface): Ditto.
11530 (TypeContainer.AddPartial): The main method for partial classes. It checks
11531 for errors and merges ModFlags and attributes. At the end class is added to
11532 partial_parts list.
11533 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11535 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11536 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11537 from the rest of partial classes.
11538 (TypeContainer.GetClassBases): Simplified.
11539 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11541 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11542 (TypeContainer.HasExplicitLayout): Uses Flags now.
11543 (PartialContainer): Removed.
11544 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11545 (StaticClass): Was merged with Class.
11546 (Class.GetClassBases): class and static class bases are verified here.
11547 (Class.TypeAttr): Added static attributes when class is static.
11548 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11549 (MemberBase): In some cases we need to call parent container for partial
11550 class. It should be eliminated but it's not easy now.
11552 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11554 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11555 partial classed to accumulate class comments.
11556 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11558 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11560 * driver.cs (MainDriver): Tree.GetDecl was removed.
11562 * modifiers.cs (Modifiers): Add partial modifier.
11564 * tree.cs (Tree.decl): Removed.
11565 (RootTypes): Started to use this class more often for root types
11568 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11572 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11573 external interface does not have an attribute.
11575 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11577 Another prerequisites for new partial classs implementation.
11579 * attribute.cs (Attribute.Equal): Implemented.
11580 (Attribute.Emit): Changed as attributes can be applied more than twice.
11581 (Attributes.Emit): Check for duplicate attributes here.
11583 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11584 as a parameter, clean-up.
11586 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11590 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11591 contains obsolete attribute check which can in some cases look for base
11592 type of current class which is not initialized yet.
11593 (TypeContainer.BaseType): Replacement of ptype.
11595 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11597 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11599 First of prerequisites for new partial classs implemention.
11601 * attribute.cs (Attributable): Extended by ResolveContext;
11602 Attributes finally have correct context for resolving in all cases.
11603 (AttachTo): Attribute owner is assigned here.
11605 * codegen.cs (IResolveContext): Introduce new interface to hold
11606 all information needed in resolving phase.
11607 (EmitContext): Implements IResolveContext; more clean-up needed here.
11609 * decl.cs (MemberCore): Implemented IResolveContext.
11611 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11612 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11613 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11614 Refactored to use new IResolveContext instead of EmitContext; cleanup
11616 2006-02-06 Miguel de Icaza <miguel@novell.com>
11618 * codegen.cs (EmitScopeInitFromBlock): check here the
11619 capture_context, there is no need to make two calls to the
11622 * anonymous.cs: Add some debugging messages that might help me
11623 track other instances of this problem in the future (the
11624 regression of test 467).
11626 * cs-parser.jay: track the variable block, as we need to initalize
11627 any captured variables declared in this block for the "catch"
11628 portion of the "Try" statement.
11630 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11631 scope initialization for captured variables.
11633 Also, move the emit for the variables after the block location has
11636 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11638 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11640 2006-02-02 Miguel de Icaza <miguel@novell.com>
11642 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11643 commit yesterday, the initialization for the roots is necessary.
11644 What is not necessary is the scope activation.
11646 2006-02-02 Raja R Harinath <rharinath@novell.com>
11648 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11649 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11651 (Argument.Resolve): Remove CS0206 checks.
11653 2006-02-01 Miguel de Icaza <miguel@novell.com>
11655 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11656 scopes for all the roots, the scopes will now be emitted when the
11657 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11659 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11660 code. This reduces a lot of existing cruft.
11662 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11663 that the ScopeInfo is generated as we enter the scope, not at the
11664 time of use, which is what we used to do before.
11666 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11667 every time a Block is about to be emitted if we have a
11670 2006-02-01 Raja R Harinath <rharinath@novell.com>
11672 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11674 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11676 * typemanager.cs (cons_param_array_attribute): Make private.
11677 (Reset): Set it to null.
11678 (InitCoreHelpers): Don't initialize it.
11679 (ConsParamArrayAttribute): New. Initialize it as needed.
11680 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11682 2006-01-31 Miguel de Icaza <miguel@novell.com>
11684 * expression.cs: There might be errors reported during the
11685 selection of applicable methods. If there are errors, do not
11686 continue execution as it will lead the compiler to crash.
11688 2006-01-30 Miguel de Icaza <miguel@novell.com>
11690 * expression.cs: Member access is not allowed on anonymous
11691 methods. Fixes #77402.
11693 2006-01-30 Raja R Harinath <rharinath@novell.com>
11696 * cs-parser.jay (VariableDeclaration): Don't set
11697 current_array_type to null.
11698 (field_declaration, event_declaration, declaration_statement):
11699 Set it to null here.
11701 2006-01-28 Raja R Harinath <harinath@gmail.com>
11703 * typemanager.cs (GenericParameterPosition): New.
11706 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11708 * doc.cs : To process "include" elements, first we should create
11709 another list than XmlNodeList, because it could result in node
11710 removal, which could result in that the XmlNodeList gives up
11711 yielding next node.
11713 (Also made code identical to gmcs again.)
11715 2006-01-25 Miguel de Icaza <miguel@novell.com>
11717 * ecore.cs: Introduce an error report that we were not catching
11718 before, if not silent, we must report the error. Gonzalo ran into
11721 2006-01-23 Miguel de Icaza <miguel@novell.com>
11723 A fix for bug: #76957
11725 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11726 ComputeMethodHost before creating the method, this is a new
11729 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11730 that this method references (RegisterScope). The actual scope
11731 where the method is hosted is computed with the ComputeMethodHost
11732 before we create the method.
11734 Moved the Deepest routine here.
11736 (AnonymousContainer.ComputeMethodHost): New routine used to
11737 compute the proper ScopeInfo that will host the anonymous method.
11739 (ScopeInfo): Deal with multiple roots. The problem was that we
11740 did not have a unique root where all ScopeInfos could be hanged
11741 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11744 Remove AdjustMethodScope which is now computed at the end. Remove
11745 LinkScope which did a partial link, instead link all ScopeInfos
11746 before code generation from the new "LinkScopes" routine.
11748 Simplify all the Add* routines as they no longer need to maintain
11749 the tree, they just need to record that they are using variables
11752 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11753 routines to produce the forest of ScopeInfo trees.
11755 * class.cs (TypeContainer.AppendMethod): This is just like
11756 AddMethod, but ensures that an interface implementation method
11757 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11758 methods, but at the end.
11760 We use this functionality to ensure that the generated MoveNext
11761 method in the iterator class is resolved/emitted before the
11762 enumerator methods created.
11764 This is required because the MoveNext method computes the right
11765 ScopeInfo for the method. And the other methods will eventually
11766 need to resolve and fetch information computed from the anonymous
11769 2006-01-21 Raja R Harinath <harinath@gmail.com>
11770 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11772 Fix rest of #76995.
11773 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11774 the 'aliases' hash.
11775 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11776 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11778 2006-01-18 Raja R Harinath <rharinath@novell.com>
11780 Fix #76656, cs0231-2.cs.
11781 * cs-parser.jay (formal_parameter_list): Make error case catch
11783 (parenthesized_expression_0): Add CS1026 check.
11784 (invocation_expression): Remove unused { $$ = lexer.Location }.
11786 2006-01-17 Raja R Harinath <rharinath@novell.com>
11789 * cs-parser.jay (statement_expression): Don't list out the
11790 individual statement-expressions. Convert syntax error into
11793 2006-01-16 Raja R Harinath <rharinath@novell.com>
11796 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11797 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11798 CheckIntermediateModification.
11799 (FieldExpr.DoResolve): Add new two-argument version that
11800 allows us to resolve the InstanceExpression as an lvalue.
11801 The one-argument variant is now just a wrapper.
11802 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11803 Resolve the lhs as an lvalue if the it has a value type.
11804 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11805 from Assign.DoResolve.
11806 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11807 resolved as an lvalue.
11808 (PropertyExpr.DoResolve): Update.
11809 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11810 has a value type. Move CS1612 check here from
11811 CheckIntermediateModification.
11812 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11813 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11814 'right_side' of a ResolveLValue on an 'out' argument.
11815 (EmptyExpression.LValueMemberAccess): New. Used as the
11816 'right_side' of a propagated ResolveLValue on a value type.
11817 (LocalVariableReference.DoResolveBase): Recognize
11818 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11820 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11821 EmptyExpression.Null.
11823 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11825 * typemanager.cs : added IsGenericParameter(). In mcs it always
11827 * doc.cs : for generic parameters, use GenericParameterPosition,
11830 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11832 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11834 2006-01-12 Miguel de Icaza <miguel@novell.com>
11836 This fixes the problem where we used ldfld instead of ldflda to
11837 load the "THIS" pointer on captured parameters, when THIS is a
11838 value type. See bug #77205.
11840 * iterators.cs (CapturedThisReference.Emit): Pass false to
11841 EmitThis (we do not need the address).
11843 * codegen.cs (EmitThis): it needs to know whether we need the
11844 address of `this' or not. This is used by value types.
11846 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11847 every other call passes false.
11849 2006-01-12 Raja R Harinath <rharinath@novell.com>
11852 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11854 * expression.cs (Invocation.OverloadResolve): Update.
11855 (Invocation.DoResolve): Avoid double resolution of invocation.
11857 2006-01-11 Raja R Harinath <rharinath@novell.com>
11860 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11861 unary negation of floating point types as 0-expr; negation cannot
11862 overflow in floating point types.
11865 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11866 on operands of 'void' type.
11869 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11870 and ExclusiveOr for boolean constants too.
11872 2006-01-09 Raja R Harinath <rharinath@novell.com>
11875 * expression.cs (Invocation.OverloadResolve): Replace reflected
11876 override methods with their base virtual methods, rather than
11877 skipping over them.
11878 * typemanager.cs (TypeManager.GetOverride): New.
11880 2006-01-05 Jb Evain <jbevain@gmail.com>
11882 * class.cs (Property.Define, Indexer.Define): do not tag the
11883 properties as SpecialName | RTSpecialName.
11885 2006-01-04 Miguel de Icaza <miguel@novell.com>
11887 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11888 doing a low-level comparission of parameter types. It was lacking
11889 a check for __argslist.
11891 2005-12-30 Miguel de Icaza <miguel@novell.com>
11893 * expression.cs (ParameterReference.DoResolveBase): Allow
11894 reference parameters if they are local to this block.
11896 This allows the ref and out parameters of a delegate to be used in
11897 an anonymous method, for example:
11899 delegate void set (out int x);
11901 set s = delegate (out int x){
11905 This is used by functionality introduced late in the C# language.
11907 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11908 method that take ref and out parameters.
11910 Fixes #77119 which was a late change in the spec.
11912 2005-12-23 Miguel de Icaza <miguel@novell.com>
11914 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11915 parent if its the same scope. Fixes #77060.
11917 2005-12-21 Miguel de Icaza <miguel@novell.com>
11919 * driver.cs: Report the case of no source files and no -out:
11922 2005-12-20 Raja R Harinath <rharinath@novell.com>
11925 * expression.cs (ComposedCast.GetSignatureForError): Define.
11927 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11931 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11932 ListDictionary, to contain the ExternAliasEntry entries (in
11933 addition to the NamespaceEntry.aliases hashtable). This field is
11934 shared between the original entry and its doppelganger (bodyless
11936 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11937 extern_aliases field.
11938 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11939 lookup in extern_aliases.
11941 2005-12-16 Raja R Harinath <rharinath@novell.com>
11944 * class.cs (TypeContainer.Mark_HasEquals): New.
11945 (TypeContainer.Mark_HasGetHashCode): New.
11946 (ClassPart): Override them.
11947 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11950 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11951 'parent' argument to the base constructor.
11953 Remove all mention of TypeContainer from decl.cs.
11954 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11955 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11956 (DeclSpace.DeclSpace): Likewise.
11957 (DeclSpace.DefineMembers): Remove unused argument.
11958 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11959 debugging check -- we don't care if the debug code throws an
11960 InvalidCastException instead of an InternalErrorException.
11961 * class.cs (TypeContainer.DefineMembers): Update to changes.
11962 (TypeContainer.DoDefineMembers): Likewise.
11963 (TypeContainer.GetMethods): Likewise.
11964 (PropertyMember.Define): Likewise.
11965 (MemberBase.Parent): New property that forwards to
11966 MemberCore.Parent, but ensures that we get a TypeContainer.
11967 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11968 (RootContext.PopulateTypes): Likewise. Remove special case code
11969 for !RootContext.StdLib: DefineMembers is idempotent.
11971 2005-12-14 Miguel de Icaza <miguel@novell.com>
11973 * convert.cs (ExplicitConversionCore): Check the return value from
11974 ExplicitConversionCore which can return null on failure. Fixes #76914
11976 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11978 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11980 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11982 * doc.cs : The search for referenced namespace was insufficient to
11983 get global one as it used to do. Fixed bug #76965.
11985 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11987 * doc.cs : check name in cref in the last phase that whether it is
11990 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11992 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11995 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11997 * doc.cs : so it turned out that we cannot skip override check for
11998 interface members. Fixed bug #76954.
12000 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12002 * cs-tokenizer.cs : fixed bug #75984:
12003 - #warning and #error should not be handled when the source line
12005 - #line is not checked strictly when the source line is disabled.
12006 - #define and #undef is on the other hand checked strictly at any
12009 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
12011 * cs-tokenizer.cs : missing Location (actually, filename) in one of
12014 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12016 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
12018 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
12019 event initializers.
12020 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
12021 (FieldBase.Initializer): Initializer is now optional.
12022 (EventField.Define): Only event field can have initializer.
12024 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
12026 * const.cs (Const): Reuse initializer.
12028 * cs-parser.jay: Updated after FieldBase changes.
12029 Added current_array_type to simplify array initializers.
12031 * ecore.cs (NullCast.IsDefaultValue): Implemented.
12033 * expression.cs, iterators.cs: Updated.
12035 * namespace.cs (NamespaceEntry): Made UsingFound private.
12037 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12039 * parameterCollection.cs: Obsolete, removed.
12040 * parser.cs: Obsolete, removed.
12042 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12045 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
12047 * enum.cs (Enum.Define): Set obsolete context here.
12049 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12052 - FindDocumentedMember() now expects 1) paramList as null
12053 when "we don't have to check the number of parameters" and
12054 2) Type.EmptyTypes when "there is no arguments".
12055 - Introduced FoundMember struct to hold the exact type which was
12056 used to find the documented member (the above change broke
12057 test-xml-044; it might be better just to use DeclaringType than
12058 what MS does, like this change does, but it depends on usage.)
12060 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12062 * doc.cs : documented member might be from DeclaringType for nested
12063 types. Fixed bug #76782.
12065 2005-12-03 Ben Maurer <bmaurer@ximian.com>
12067 * anonymous.cs: Have the param code handle leaving copies on the
12068 stack etc. Allows anonymous params to take part in the assignment
12069 code (++, +=, etc). Fixes bug #76550
12071 * expression.cs: Handle the prepare_for_load/leave_copy by passing
12072 it down to the anon code.
12074 * iterators.cs: Use dummy var here
12076 * codegen.cs: Handle new vars
12078 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12081 * class.cs (MethodData.Define): Set proper Obsolete context.
12083 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
12085 (FieldExpr.DoResolve): Ditto.
12087 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12090 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
12091 parent is not obsolete.
12093 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
12095 * doc.cs : (FindDocumentedMember) find parameterless members first
12096 and get CS0419 in the early stage. Fixed first case of bug #76727.
12098 2005-11-30 Marek Safar <marek.safar@seznam.cz>
12101 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
12102 no error was reported.
12104 *expression.cs (Binary.DoResolve): left can be null.
12106 2005-11-22 Marek Safar <marek.safar@seznam.cz>
12109 * class.cs (MethodData.Emit): Parameters should be labeled first.
12111 2005-11-21 Marek Safar <marek.safar@seznam.cz>
12114 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
12116 2005-11-18 Marek Safar <marek.safar@seznam.cz>
12118 * attribute.cs (AreParametersCompliant): Moved to Parameter.
12120 * class.cs (MethodCore): Parameter clean up.
12121 (IMethodData): Added ParameterInfo.
12122 (MethodData): Parameter clean up.
12123 (Indexer.Define): Parameter clean up.
12135 * typemanager.cs: Parameter clean up.
12137 * delegate.cs (Define): Get rid of duplicated code.
12139 * expression.cs (ParameterReference): Removed useless parameters
12141 (Invocation): Ditto.
12143 * parameter.cs (ParamsParameter): New class, params specialization.
12144 (ArglistParameter): Attemp to separate arglist.
12145 (Parameter): Refactored to be reusable and faster.
12146 (Parameter.Modifier): Made understandable.
12147 (Parameters): Changed to be used as a class for `this' assembly
12148 parameters. Refactored to use new specialized classes.
12150 * support.cs (ParameterData): Added Types property.
12151 (InternalParameters): Deleted.
12153 2005-08-20 Martin Baulig <martin@ximian.com>
12155 Merging this patch from GMCS to fix #75867.
12157 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12158 scope if we don't already have it.
12160 2005-11-17 Martin Baulig <martin@ximian.com>
12163 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
12164 inherit the scope from our parent. Fixes #76653.
12166 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12168 * doc.cs : the previous patch does not actually fix the bug.
12169 PropertyInfo override check is now implemented and really fixed it.
12170 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
12172 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12174 * doc.cs : apply "override filter" also to properties.
12177 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12179 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
12180 no need to check overrides. For classes, omit those results from
12181 interfaces since they must exist in the class. Fixed bug #76726.
12183 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12185 * typemanager.cs : (GetFullNameSignature) differentiate indexers
12186 with different parameters. Fixed the second problem in #76685.
12188 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12190 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
12191 get expected 'protected' access in CheckValidFamilyAccess()).
12194 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12196 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
12197 Fixed bug #76705. CS1569 was incorrectly commented out.
12199 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12201 * doc.cs : use Invocation.IsOverride() to do real override check.
12202 * expression.cs : made Invocation.IsOverride() internal.
12204 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12206 * doc.cs : use TypeManager.FindMembers() instead of (possible)
12207 TypeBuilder.FindMembers() and filter overriden base members out.
12210 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12212 * doc.cs : ref/out parameters are represented as '@' (instead of
12213 '&' in type FullName). Fixed bug #76630 (additionally crefs).
12215 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12217 * doc.cs : when there was no '.' in cref to methods in doc comment,
12218 then parameters were missing in the output. Fixed bug #76691.
12220 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12222 * driver.cs : don't output docs when there is an error.
12225 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12228 Now it should detect indexers. Fixed primary concern in bug #76685.
12229 Fixed CS0419 message to not show the identical member signature in
12232 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12234 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
12235 instead of Type.FindMembers() since it does not handle events.
12238 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
12240 * codegen.cs: Fixed typo (speficied -> specified).
12242 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12245 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
12247 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12249 * attribute.cs: Changed error message.
12251 * cs-tokenizer.cs: One more check.
12253 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12255 * statement.cs (Block.Resolve): Ignore empty statement.
12257 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12259 * report.cs: Made error/warning methods more strict to avoid
12262 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
12263 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
12264 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
12265 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
12267 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12269 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12270 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12272 * class.cs (TypeContainer.IsComImport): New property.
12273 (Constructor.Define): Create proper ctor for ComImport types.
12275 * expression.cs (New.CheckComImport): Fixed.
12277 2005-11-07 Miguel de Icaza <miguel@novell.com>
12279 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12280 that a parameter has been captured does not mean that we do not
12281 have to do the rest of the processing. This fixes the second part
12282 of #76592. If there was another anonymous method capturing
12283 values in the past, the Scope would never be set for the second
12284 method that captured the same parameter.
12286 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12287 properly manipulate the stack. Second part of fix for #76592.
12289 * expression.cs (New): Add support for invoking "new" on
12290 interfaces that have been flagged with the ComImport attribute and
12291 the CoClass. Fixes #76637
12293 * statement.cs (Try.DoEmit): When a variable is captured, do not
12294 try to emit the vi.LocalBuilder variable as it has been captured.
12295 Create a temporary variable and store the results on the
12296 FieldBuilder. Fixes #76642
12298 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12300 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12302 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12304 * expression.cs (Binary.DoResolve): Added && optimalization.
12306 * typemanager.cs (AddUserType): Removed useless argument.
12308 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12310 * statement.cs (Block.variables): Uses ListDictionary.
12312 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12315 * class.cs (PartialContainer.EmitType): Customized to emit
12316 security attributes.
12317 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12318 for partial classes.
12320 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12323 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12324 access has to be fixed.
12326 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12328 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12331 * ecore.cs (NullCast.Reduce): Implemented.
12333 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12336 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12338 (Foreach.Resolve): Catch null properly.
12340 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12342 * cs-tokenizer.cs: Warning text fix.
12344 * driver.cs: AllWarningNumbers exposed on public interface.
12346 * report.cs (): Reviewed warning numbers.
12347 (IsValidWarning): Use binary search.
12349 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12351 * driver.cs: Implemeted resource visibility.
12352 (Resources): New class for code sharing between /res: and
12355 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12358 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12361 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12364 * ecore.cs (NullCast): Child is contant only.
12366 * literal.cs (NullLiteral.Reduce): null can be converted to any
12369 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12371 * driver.cs: Use Encoding.Default as default code page instead
12374 2005-10-27 Raja R Harinath <rharinath@novell.com>
12377 * expression.cs (Invocation.Error_InvalidArguments): Handle
12378 __arglist parameters.
12379 (Invocation.VerifyArgumentsCompat): Likewise.
12380 * support.cs (ReflectionParameters.GetSignatureForError): Print
12381 __arglist parameters.
12382 (InternalParamters.GetSignatureForError): Likewise.
12383 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12385 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12387 * attribute.cs (GetPropertyValue): Made public.
12389 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12391 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12393 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12396 * driver.cs: Reflect method name change.
12398 * statement.cs (Try.Resolve): Warn when try has both general
12399 exception handlers.
12401 * typemanager.cs: runtime_compatibility_attr_type new predefined
12404 2005-10-26 Raja R Harinath <harinath@gmail.com>
12407 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12408 treat it as an empty parameter list.
12410 2005-10-26 Raja R Harinath <rharinath@novell.com>
12413 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12414 ResolveAsTypeStep silent.
12415 * statement.cs (Block.AddConstant): Mark block as used.
12416 (Block.ResolveMeta): Avoid piling on error messages
12417 if a constant initializer resolution fails.
12419 2005-10-25 Raja R Harinath <rharinath@novell.com>
12421 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12423 (NamespaceEntry.VerifyAllUsing): New.
12424 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12425 behaviour. Delegates actual resolution of alias to ...
12426 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12427 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12429 * driver.cs (Driver.MainDriver): Update.
12431 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12432 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12434 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12436 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12437 RootNamespace.DefineNamespacesForAll.
12439 2005-10-24 Raja R Harinath <harinath@gmail.com>
12441 * typemanager.cs (assemblies, external_aliases, modules)
12442 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12443 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12444 overhead. Move resposibility ...
12445 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12446 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12448 2005-10-23 Raja R Harinath <harinath@gmail.com>
12450 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12451 cached_namespaces. Improve usage.
12452 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12453 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12454 Move from GlobalRootNamespace and simplify.
12455 (RootNamespace.Global): Make instance variable.
12456 (RootNamespace.RootNamespace): Add "alias name" parameter.
12457 (GlobalRootNamespace): Simplify drastically.
12458 (Namespace.Lookup): Don't use GetNamespace.
12459 * typemanager.cs (GetRootNamespace): Rename from
12460 ComputeNamespaceForAlias.
12461 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12463 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12465 * anonymous.cs (AnonymousContainer): Don't crash when container
12468 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12470 * expression.cs (Binary.DoResolve): Warn when comparing same
12473 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12476 * expression.cs (Binary.DoResolve): It looks like there are no
12477 convetsion rules in enum context.
12479 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12481 Add support for extern alias qualifiers.
12482 * typemanager.cs: Move some LookupTypeReflection code
12483 to namespace.cs, to have cleaner code. Added some methods
12484 to help us keep track of the extern aliased references.
12485 * driver.cs: Add suport for extern alias assemblies on command
12486 line and check for their warnings/errors. Also keep track of the
12487 extern aliased assemblies.
12488 * namespace.cs: Move the global functionality of Namespace
12489 to GlobalRootNamespace/RootNamespace. Now the global namespace
12490 is GlobalRootNamespace.Globa. Also the code moved from
12491 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12492 Finally added LocalAliasEntry (AliasEntry before) and
12493 ExternAliasEntry, to handle alias statements.
12494 * cs-parser.jay: Add support in the grammar for extern alias
12496 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12497 Update callings to Namespace (now in GlobalRootNamespace).
12499 2005-10-18 Raja R Harinath <rharinath@novell.com>
12502 * class.cs (TypeContainer.DefineType): Move updating of
12503 topological sort earlier in the code.
12504 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12506 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12509 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12511 * constant.cs (Constant.TryReduce): Moved from Cast class.
12512 (Reduce): Made little bit more OO and fixed missing conversions.
12514 * ecore.cs (Reduce): Implemented.
12515 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12517 * literal.cs (Reduce): Implemented.
12519 * class.cs: Reverted Miguel's wrong commit.
12521 2005-10-14 Miguel de Icaza <miguel@novell.com>
12523 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12525 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12527 * cs-parser.jay, expression.cs : CS0214 was missing error location
12528 for constants. Fixed bug #76404.
12530 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12533 * convert.cs (ExplicitConversionCore): Fixed object->enum
12536 2005-10-10 Raja R Harinath <rharinath@novell.com>
12538 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12539 InstanceExpression.
12540 (PropertyExpr.EmitCall): Likewise.
12541 * expression.cs (Invocation.EmitArguments): Handle case where
12543 (Invocation.EmitCall): Avoid allocating temporary variable if
12544 there are no arguments.
12546 2005-10-07 Raja R Harinath <rharinath@novell.com>
12549 * convert.cs (ImplicitConversionStandard): Move conversion of
12550 void* to arbitrary pointer types ...
12551 (ExplicitConversionStandard): .. here.
12552 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12553 error to always print typenames.
12555 2005-10-07 Raja R Harinath <rharinath@novell.com>
12557 * convert.cs (GetConversionOperator): Rename from
12558 GetConversionOperators. Move operator selection code from ...
12559 (UserDefinedConversion): ... here.
12561 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12563 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12566 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12568 * assign.cs (Assign.DoResolve): Error method changed.
12570 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12572 * const.cs (ResolveValue): Reset in_transit immediately.
12574 * constant.cs: Error method changed.
12576 * convert.cs: Removed useless location parameter.
12577 (ExplicitNumericConversion): Don't do double enum check.
12578 (ExplicitConversionCore): Renamed from ExplicitConversion.
12579 (ExplicitUnsafe): Extracted from ExplicitConversion.
12580 (ExplicitConversion): Uses for error reporting.
12582 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12584 (ResolveBoolean): Uses common error method.
12585 (CastToDecimal): Get rid of ec.
12586 (CastFromDecimal): Optimized.
12587 (ConvCast): Get rid of ec.
12589 * enum.cs (ResolveValue): Reset in_transit immediately.
12590 (Emit): Return after first error.
12592 * expression.cs: Convert changes.
12594 * literal.cs: Error method changed.
12596 * statement.cs: Error method changed.
12598 2005-10-03 Raja R Harinath <rharinath@novell.com>
12600 * support.cs (SeekableStreamReader.Position): Don't error out when
12601 the requested position is just beyond the end of the current
12604 2005-09-28 Raja R Harinath <rharinath@novell.com>
12606 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12607 try to keep in sync with the byte count of the underlying Stream.
12608 However, this limits us to a window size of 2048 characters: i.e.,
12609 the maximum lookahead of our lexer/parser can be 2048 characters.
12611 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12614 * driver.cs: Fix compilation files with full root path.
12616 2005-09-25 Miguel de Icaza <miguel@novell.com>
12618 * report.cs (SymbolRelatedToPreviousError): Format the output so
12619 it does not use an open parenthesis that is never closed.
12621 * driver.cs: Follow coding guidelines
12623 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12626 * const.cs (Const.ResolveValue): Check for assigning non-null
12627 value to reference type.
12629 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12631 * anonymous.cs: Implemented ExprClassName.
12633 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12636 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12639 * class.cs (StaticClass.DefineContainerMembers): Report protected
12642 * codegen.cs: if(ed) PRODUCTION.
12644 * convert.cs (Error_CannotImplicitConversion): Better error
12647 * cs-parser.jay: More error checks.
12649 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12651 * driver.cs (CSCParseOption): Enabled wrong option check.
12653 * ecore.cs (Expression.ExprClassName): Turned to property.
12654 (MemberExpr.CheckIntermediateModification): For checking boxed
12655 value types modification.
12657 * statement.cs (Fixed.Resolve): Expression type must be
12658 convertible to fixed type.
12659 (CollectionForeach.GetEnumeratorFilter,TryType):
12660 Small refactoring for easier error checking.
12662 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12664 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12667 * class.cs (GeneratedBaseInitializer): New class for customization
12668 compiler generated initializers.
12669 (MemberBase.DoDefine): Check Obsolete attribute here.
12670 (FieldMember.DoDefine): Ditto.
12672 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12675 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12676 (MemberCore.GetObsoleteAttribute): Removed argument.
12677 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12678 (MemberCore.CheckObsoleteType): New helper.
12682 * statement.cs: Updates after MemberCore changes.
12684 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12685 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12687 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12688 obsolete attribute for compiler construct.
12689 (As.DoResolve): Cache result.
12691 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12693 2005-09-26 Raja R Harinath <rharinath@novell.com>
12696 * expression.cs (This.VerifyFixed): In a value type T, the type of
12697 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12698 value type R, 'this' is treated as a value parameter.
12700 2005-09-22 Miguel de Icaza <miguel@novell.com>
12702 * statement.cs (Lock): Use the TemporaryVariable class instead of
12703 manually using local variables as those do not work when variables
12706 * ecore.cs: Moved the TemporaryVariable class from being a nested
12707 class inside Foreach to be a public class that can be employed in
12710 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12712 * cs-parser.jay: interface_accessors replaced by
12713 accessor_declarations.
12715 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12718 * statement.cs (GotoCase.Resolve): Convert null constant to
12720 (SwitchLabel.ResolveAndReduce): Ditto.
12721 (SwitchLabel.NullStringCase): Custom null stamp.
12722 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12724 typemanager.cs (CSharpSignature): Don't skip first argument
12727 2005-09-18 Miguel de Icaza <miguel@novell.com>
12729 * driver.cs: Set InEmacs based on the environment variable EMACS.
12731 * location.cs (InEmacs): in this mode, do not report column
12732 location as it confuses Emacs.
12734 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12736 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12737 expression.cs, iterators.cs, literal.cs: Store constants and
12740 * class.cs (MemberBase.ShortName): Pass location.
12742 * cs-parser.jay: Some location fixes.
12744 * ecore.cs (Expression.Location): Made virtual.
12746 2005-09-05 Miguel de Icaza <miguel@novell.com>
12748 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12749 if the underlying types are the same, otherwise we need to produce
12750 code that will do the proper cast.
12752 This was exposed by Marek's constant rewrite which produced
12753 invalid code for the call site:
12755 enum X : long { a }
12756 void Method (X v) {}
12760 This fixes test-49.cs
12762 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12764 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12765 Type/Object should be allowed as well. Fixed bug #75968.
12767 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12769 * expression.cs : (Binary.DoResolve): when one is enum constant and
12770 another is constant 0, then return enum one *as enum type*.
12773 2005-09-02 Raja R Harinath <rharinath@novell.com>
12775 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12779 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12780 flow-branching for LocalVariableReferences in case we were invoked
12781 from a MemberAccess.
12782 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12784 (LocalVariableReference.DoResolveBase): ... this.
12785 (MemberAccess.Resolve): Do the check that was disabled during
12788 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12791 (PartialContainer.Create): check abstract/sealed/static strictly
12792 but abstract/sealed can exist only at one side. Fixed bug #75883.
12794 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12797 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12798 specified, don't default to UnmanagedType.I4.
12800 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12802 * expression.cs : conditional operator should check possibly
12803 incorrect assign expression. Fixed bug #75946.
12805 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12807 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12808 Reverting the change. gmcs is much complex than mcs on this matter.
12810 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12812 * cs-tokenizer.cs : To read another token ahead of the actual
12813 consumption, use new SavedToken and cache token instead of moving
12814 back the stream with SeekableStreamReader (it seemed problematic).
12816 driver.cs : Thus use StreamReader directly.
12817 * support.cs : Thus removed SeekableStreamReader.
12819 2005-08-30 Raja R Harinath <rharinath@novell.com>
12822 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12823 (ScopeInfo.EmitScopeType): Use it to construct field names from
12824 names of captured locals.
12827 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12828 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12829 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12830 (ExplicitConversion): Remove enum cases already handled by
12831 implicit conversion. Move implicit conversion check to the beginning.
12832 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12833 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12834 Don't treat System.Enum as a struct.
12836 2005-08-30 Jb Evain <jbevain@gmail.com>
12838 * attribute.cs: handles as expression in parameters.
12840 2005-08-30 Raja R Harinath <rharinath@novell.com>
12843 * class.cs (TypeContainer.VerifyClsName): Don't use a
12844 PartialContainer when verifying CLS compliance.
12845 (AbstractPropertyEventMethod): Set Parent here, ...
12846 (PropertyMethod): ... not here.
12848 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12850 * attribute.cs : escaped attribute name should not be allowed to be
12851 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12853 2005-08-29 Raja R Harinath <rharinath@novell.com>
12856 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12857 when converting a long constant to unsigned long.
12858 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12859 detect where IsApplicable and VerifyArgumentsCompat disagree.
12861 2005-08-29 Raja R Harinath <rharinath@novell.com>
12862 and Carlos Alberto Cortez <carlos@unixmexico.org>
12865 * class.cs (TypeContainer.CanElideInitializer): New helper.
12866 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12867 can safely emitting the initializer of a field.
12869 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12871 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12872 allowed inside a switch (without loop). Fixed bug #75433.
12874 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12876 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12877 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12879 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12881 * driver.cs : kinda reverting the default encoding changes (not exact
12882 revert since I noticed that "codepage:reset" might not work fine).
12884 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12886 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12887 Location. Now getter and setter store location correctly.
12888 (errors/cs0111-12.cs now reports the expected location.)
12890 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12892 * driver.cs : Use default encoding on the environment.
12893 Removed (now that) extra parameter for SeekableStreamReader.
12894 * support.cs : (SeekableStreamReader) third .ctor() argument for
12895 StreamReader is not required (always true). preamble size could
12896 be acquired in simpler and safe way.
12898 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12900 * cs-parser.jay: report CS0642 at warning level 3
12901 and report CS0642 for an if else statement also
12902 fixes bug #74745. Patch by John Luke (and a bit
12904 Removed extra CS0642 warning check for "while",
12906 * statement.cs: In Block.Resolve(), CS0642 check
12907 is reimplemented to check a sequence of an empty
12908 statement and a block.
12910 Both fix bug #66777.
12912 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12914 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12915 detection until I fix it.
12917 * cs-tokenizer.cs: Changed error message.
12919 * cs-parser.jay: Fixed 2 error locations.
12921 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12922 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12925 * enum.cs (GetSignatureForError): Fixed.
12927 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12931 * typemanager.cs (RegisterProperty): Removed.
12933 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12935 2005-08-24 Raja R Harinath <rharinath@novell.com>
12938 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12939 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12941 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12943 * expression.cs : tiny fix is required for not warning positive ulong.
12946 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12948 * expression.cs : add CS0652 check for constant and integral
12949 expression. Fixed bug #53974.
12951 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12953 * expression.cs : in DoNumericPromotions(), check if there is implicit
12954 conversion overload for string (to check CS0034). Fixed bug #52492.
12956 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12958 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12960 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12962 * ecore.cs : report location when it is *not* Null.
12964 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12970 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12971 correctly. Fixed bug #75721.
12973 2005-08-23 Raja R Harinath <rharinath@novell.com>
12975 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12976 loop that performs 'min (pos, char_count)'.
12979 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12980 converted value in Operator.OnesComplement.
12982 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12984 * anonymous.cs: If the anon method is pulled into a helper class,
12985 it needs to be `internal' not `private'. Fixes runtime behavior on
12988 2005-08-20 Martin Baulig <martin@ximian.com>
12990 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12991 scope if we don't already have it.
12993 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12994 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12997 2005-08-17 Marek Safar <marek.safar@seznam.cz>
13000 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
13001 is a partial class.
13003 2005-08-16 Marek Safar <marek.safar@seznam.cz>
13005 The big constants rewrite
13006 Fix #75746, #75685 and more
13007 As a side effect saved 1MB for MWF ;-)
13009 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
13010 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
13011 enum based for corlib compilation.
13013 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
13016 * class.cs (FixedField.Define): Use ResolveAsConstant.
13018 * const.cs (IConstant): Interface constants and enums.
13019 (Const.ResolveValue): New method for constant resolvning.
13020 (ExternalConstant): Constants from imported assemblies.
13022 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
13023 conversion; like enums.
13024 (Constant.ToType): Converts this constant to different type.
13025 (Constant.Increment): Adds 1.
13027 * convert.cs (ImplicitConversionRequired): Simplified.
13029 * cs-parser.jay: Create EnumMember directly.
13031 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
13033 * doc.cs (GenerateEnumDocComment): Removed.
13035 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
13036 (ConvertIntLiteral): Removed.
13037 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
13039 * enum.cs (EnumMember): Implement IConstant.
13040 (Enum.IsValidEnumConstant): Removed.
13041 (Enum.GetNextDefaultValue): Removed.
13042 (Enum.FindMembers): Updated.
13043 (Enum.GenerateDocComment): Iterate enum members.
13045 * expression.cs (Cast.TryReduce): Handle enums correctly.
13046 (New.Constantify): Made public.
13047 (MemberAccess.DoResolve): Removed contant specific if(s).
13049 * literal.cs (NullLiteral): Implement new abstract methods.
13051 * statement.cs (GotoCase.Resolve): Use new constant methods.
13052 (SwitchLabel.ResolveAndReduce): Use new constant methods.
13054 * typemanager.cs (LookupEnum): Removed.
13055 (IsEnumType): Fixed to work with corlib.
13056 (RegisterConstant): Removed.
13057 (LookupConstant): Removed.
13058 (GetConstant): Changed to work with IConstant.
13060 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
13062 * location.cs : Fixed overflown (>255) column number.
13064 2005-08-03 Raja R Harinath <rharinath@novell.com>
13066 First cut of the qualified-alias-member feature.
13067 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
13069 * cs-parser.jay (DOUBLE_COLON): New token.
13070 (namespace_or_type_name): Add rule for recognizing
13071 qualified-alias-members.
13072 (primary_expression): Likewise.
13073 (element_access): Allow QualifiedAliasMember as a possible
13074 type-bearing expression.
13075 (local_variable_type, local_variable_pointer_type): Likewise.
13076 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
13077 aliases in the current and enclosing namespace declarations.
13078 (NamespaceEntry.UsingAlias): Add CS0440 warning.
13079 * decl.cs (MemberName.is_double_colon): New.
13080 (MemberName.MemberName): Add new constructor for alias-member.
13081 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
13082 * expression.cs (QualifiedAliasMember): New expression type.
13084 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13086 * location.cs : it borked when no argument was specified.
13088 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13090 * location.cs : tiny ToString() format fix.
13092 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13094 * statement.cs : oops, it was missing.
13096 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13098 A set of fixes for precise line/column location.
13101 "token" field now holds a file/line "delta", a line number offset
13102 from the segment, and a column number. See also:
13103 http://lists.ximian.com/pipermail/mono-devel-list/2004-
13104 December/009508.html
13105 Removed static IsNull. Use instance IsNull property instead.
13106 * cs-tokenizer.cs :
13107 For some tokens it stores Location. For Identifier it stores
13108 LocatedToken which is a pair of string name and location.
13109 Column numbers are adjusted only at getChar().
13111 Use Location.ToString() for reporting (it now contains column).
13113 Largely modified to use LocatedToken instead of
13114 string (IDENTIFIER), and to acquire Location from some tokens.
13115 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
13116 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
13118 Now MemberName holds Location. DeclSpace.ctor() receives Location
13119 as a parameter. Removed extra parameters to all derived classes.
13120 Replaced Location.IsNull() with instance property.
13121 * assign.cs, expression.cs :
13122 Added .ctor() overload that omits Location.
13124 Added "nameEscaped" flag that indicates the identifier was escaped
13125 in the source file. This fixes bug #57047.
13127 2005-08-02 Marek Safar <marek.safar@seznam.cz>
13129 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
13130 New method, looking for lo-case imported cls type.
13132 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
13135 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
13137 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
13139 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
13140 all_imported_types.
13141 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
13143 Optimized to save 3.5 MB for SWF compilation.
13145 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13147 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
13148 (PartialContainer.Create): Moved logic AddToContainer.
13149 (PartialContainer.MarkForDuplicationCheck): Shares name.
13151 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
13154 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
13156 (Namespace.GetSignatureForError): New method.
13158 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
13159 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
13161 2005-08-01 Raja R Harinath <rharinath@novell.com>
13164 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
13165 member lookup rather than qualifier_type, since qualifier_type can
13168 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13170 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
13173 2005-07-31 Miguel de Icaza <miguel@novell.com>
13175 * statement.cs: Copy the local exception into the exception
13176 captured local. Fixes 75674
13178 2005-07-31 Raja R Harinath <harinath@gmail.com>
13181 * expression.cs (Invocation.OverloadResolve): Don't report error
13182 CS1501 if error CS1502 has been reported.
13183 (New.DoResolve): Delegate CS1501 reporting to
13184 Invocation.OverloadResolve.
13187 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
13188 invariant-meaning-in-block property in an enclosing block if
13191 2005-07-29 Marek Safar <marek.safar@seznam.cz>
13193 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
13194 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
13195 (Switch.CheckSwitch): Just save 50kb for SWF.
13197 2005-07-27 Martin Baulig <martin@ximian.com>
13199 * anonymous.cs (CaptureContext.AddField): Added
13200 `AnonymousContainer am' argument; compute its toplevel scope if
13201 it's not already computed. Fixes #75649.
13203 2005-07-26 Raja R Harinath <rharinath@novell.com>
13206 * class.cs (Constructor.Emit): Reset block to null if the block
13209 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13211 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
13213 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13215 * class.cs (MethodData.Define): Check whether accessor implementing
13216 interface is public.
13218 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
13220 2005-07-22 Marek Safar <marek.safar@seznam.cz>
13223 * namespace.cs (LookupType): Moved same type check to...
13225 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
13226 with the same name.
13228 2005-07-21 Raja R Harinath <rharinath@novell.com>
13230 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
13231 already found a typebuilder.
13232 * class.cs (MethodCore.IsDuplicateImplementation): Compare
13233 MemberNames, not strings.
13235 * const.cs (Error_ExpressionMustBeConst):
13236 Rename from Error_EpressionMustBeConst.
13237 * const.cs, class.cs, statement.cd: Update.
13239 2005-07-21 Marek Safar <marek.safar@seznam.cz>
13243 * const.cs (Const.LookupConstantValue): Report missing contant expression
13245 (Error_EpressionMustBeConstant): Only one error method.
13247 * class.cs, statement.c: Updated.
13249 2005-07-20 Raja R Harinath <rharinath@novell.com>
13251 * statement.cs (Block.Flags): Add back HasVarargs.
13252 (Block.flags): Make protected.
13253 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
13255 * typemanager.cs (types, typecontainers, user_types): Remove.
13256 (UserTypes, TypeContainers): Likewise.
13257 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
13258 (CleanUp, Reset): Update.
13259 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
13260 (GetNestedType): Use Type.GetNestedType.
13261 (CoreLookupType): Take two arguments, the namespace and the
13262 basename of the type. Update to use the Namespace.Lookup
13264 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
13265 (RealMemberLookup): Use IsNestedChildOf instead of playing with
13266 string concatenation and substring matches.
13267 * class.cs, enum.cs, delegate.cs: Update to changes.
13269 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13271 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13272 Expression and made virtual.
13274 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13275 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13277 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13279 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13282 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13285 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13288 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13289 AssemblyCultureAttribute is not used on executable.
13292 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13294 2005-07-16 Raja R Harinath <rharinath@novell.com>
13297 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13298 New. Reports CS0252/CS0253.
13299 Mostly taken from preliminary patch by Duncak Mak.
13300 (Binary.DoResolveOperator): Store results of operator lookup.
13301 Use them to detect if we need to warn about unintended reference
13304 2005-07-15 Raja R Harinath <rharinath@novell.com>
13307 * namespace.cs (Namespace.Lookup): Add back location parameter.
13308 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13309 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13311 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13312 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13313 (Namespace.LookupType): ... this.
13314 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13316 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13317 purported to handle pointers.
13318 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13321 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13323 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13326 2005-07-15 Raja R Harinath <rharinath@novell.com>
13328 * namespace.cs (Namespace.Lookup): Drop location parameter.
13329 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13330 (NamespaceEntry.Lookup): ... this.
13331 (NamespaceEntry.Error_AmbiguousTypeReference):
13332 Move here from DeclSpace.
13333 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13335 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13336 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13337 Move to NamespaceEntry.
13338 * delegate.cs, expression.cs: Update to changes.
13340 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13342 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13343 CheckAttributeType and refactored.
13344 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13345 ResolveAsTypeTerminal error handling.
13346 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13348 (GetSignatureForError): Print errors in same way.
13351 * codegen.cs: Reflect attribute GetSignatureForError change.
13354 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13356 * namespace.cs (UsingEntry): Refactored to make fields private.
13359 statement.cs: Error_UnexpectedKind has extra parameter.
13361 2005-07-14 Raja R Harinath <rharinath@novell.com>
13363 * ecore.cs (IAlias): Remove.
13364 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13365 that implement the interface.
13366 * namespace.cs (Namespace): Likewise.
13367 (Namespace.declspaces): Renamed from 'defined_names'.
13368 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13369 DeclSpace instead of an IAlias.
13370 * tree.cs (Tree.AddDecl): Update.
13372 2005-07-12 Raja R Harinath <rharinath@novell.com>
13374 * statement.cs (Block.Flags); Remove HasVarargs.
13375 (Block.HasVarargs): Move to ToplevelBlock.
13376 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13377 (Block.Variables): Make protected. Initialize variable hashtable
13379 (Block.AddVariable): Update.
13380 (Block.Resolve): Update to changes.
13381 (ToplevelBlock.HasVarargs): New boolean.
13382 (ToplevelBlock.ThisVariable): Move here from Block.
13383 (ToplevelBlock.AddThisVariable): Likewise.
13384 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13385 * expression.cs (This.ResolveBase): Update to changes.
13386 (ArglistAccess.DoResolve): Likewise.
13388 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13391 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13393 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13394 not used and not used & assigned.
13395 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13397 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13400 * expression.cs (Is.DoResolve): null is never provided type.
13402 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13405 * cs-parser.jay: Less strict event error rule to catch more errors.
13407 2005-07-08 Martin Baulig <martin@ximian.com>
13409 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13410 gettter (allowed) or setter (not allowed).
13412 * class.cs (Accessor): Implement IIteratorContainer.
13413 (Accessor.Yields): New public field.
13414 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13415 per-accessor basis.
13418 (get_accessor_declaration, set_accessor_declaration): Set the
13419 `yields' flag on the accessor, not the property.
13420 (property_declaration): Do the iterators check on a per-accessor
13421 basis and not for the whole property.
13423 2005-07-08 Martin Baulig <martin@ximian.com>
13425 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13426 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13428 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13431 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13432 (ExtractSecurityPermissionSet): Cope with self referencing security
13433 attributes properly.
13435 * driver.cs (SetOutputFile): Made public property OutputFile.
13437 2005-07-07 Raja R Harinath <rharinath@novell.com>
13440 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13441 has_nonstatic_fields. Make into a FieldBase pointer.
13442 (TypeContainer.AddField): Add CS0282 check.
13443 (TypeContainer.EmitType): Update.
13445 2005-07-06 Miguel de Icaza <miguel@novell.com>
13447 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13448 compare if they start with __.
13450 2005-07-06 Raja R Harinath <rharinath@novell.com>
13452 * statement.cs (Switch.SwitchGoverningType): Only look at
13453 UserCasts that don't need implicit standard conversions to one of
13454 the allowed switch types (Fixes test-322.cs).
13455 (LocalInfo.Resolve): Re-enable sanity-test.
13457 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13459 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13461 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13463 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13465 2005-07-06 Raja R Harinath <rharinath@novell.com>
13468 * ecore.cs (SimpleName.GetSignatureForError): Add.
13469 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13470 (MemberAccess.GetSignatureForError): Add.
13472 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13474 The big error and warning messages review.
13504 * typemanager.cs: Updated.
13506 * class.cs: (MethodCore.SetYields): Moved here to share.
13507 (PropertyMethod.Define): Moved iterator setup here.
13509 * iterators.cs: Add orig_method to have full access to parent
13512 2005-07-05 Raja R Harinath <rharinath@novell.com>
13514 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13515 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13516 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13517 variable of struct type.
13518 * expression.cs (Unary.ResolveOperator): Update to change.
13519 (Indirection.VerifyFixed): Likewise.
13520 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13521 (ParameterReference.VerifyFixed): Value parameters are fixed.
13522 (This.VerifyFixed): Treat 'this' as a value parameter.
13523 * statement.cs (LocalInfo.IsFixed): Remove.
13525 2005-07-01 Martin Baulig <martin@ximian.com>
13527 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13528 `ec.EmitThis ()' to get the correct scope.
13530 2005-07-01 Martin Baulig <martin@ximian.com>
13532 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13533 instance is a ParameterReference; fixes #75299.
13535 2005-07-01 Martin Baulig <martin@ximian.com>
13537 Reverted Marek's latest patch (r46725):
13538 - it contains structural changes which are neither mentioned in
13539 the ChangeLog nor explained anywhere; for example the additional
13540 argument of EmitContext's and Iterator's .ctor's and the
13541 TypeContainer.DefineMembers() change.
13542 - structural changes like this should go in in seperate patches
13543 and not be hidden in a huge patch which just seems to affect
13544 warnings and errors.
13545 a big and hard to understand patch.
13546 - it breaks iterators and causes regressions, for instance in
13549 2005-06-30 Raja R Harinath <rharinath@novell.com>
13552 * expression.cs (Indexers.map): Remove.
13553 (Indexers.Append): Filter out inaccessible setters and getters.
13554 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13557 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13558 Refactored from ...
13559 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13560 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13561 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13562 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13564 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13567 * class.cs (FieldBase.GetInitializerExpression): One more field
13570 2005-06-28 Miguel de Icaza <miguel@novell.com>
13572 * pending.cs: Do not define a proxy if the base method is virtual,
13573 it will be picked up by the runtime (bug 75270).
13575 2005-06-08 Martin Baulig <martin@ximian.com>
13577 The big Iterators rewrite :-)
13579 * iterators.cs: Rewrite this to use the anonymous methods framework.
13581 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13582 before the TypeContainers; see 2test-21.cs.
13585 (TypeContainer.DefineType): Don't create a new EmitContext if we
13586 already have one (this only happens if we're an Iterator).
13587 (TypeContainer.Define): Also call Define() on all our iterators.
13588 (Method.CreateEmitContext): Added support for iterators.
13591 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13592 (AnonymousContainer.CreateMethodHost): Moved here from
13593 AnonymousMethod and made abstract.
13594 (AnonymousContainer.CreateScopeType): New abstract method.
13595 (AnonymousContainer.IsIterator): New public property.
13596 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13597 get the ScopeTypeBuilder rather than manually defining it here.
13598 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13601 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13602 before RootContext.DefineTypes().
13604 * codegen.cs (EmitContext.RemapToProxy): Removed.
13605 (EmitContext.CurrentAnonymousMethod): Changed type from
13606 AnonymousMethod -> AnonymousContainer.
13607 (EmitContext.ResolveTopBlock): Protect from being called twice.
13608 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13609 (EmitContext.EmitThis): Removed the iterators hacks; use the
13610 anonymous methods framework for that.
13613 (ToplevelBlock.Container): Make this a property, not a field.
13614 (ToplevelBlock.ReParent): New public method; move the
13615 ToplevelBlock into a new container.
13616 (Foreach.TemporaryVariable): Simplify.
13618 2005-06-05 Martin Baulig <martin@ximian.com>
13620 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13621 (Block.AddTemporaryVariable): New public method; creates a new
13622 `LocalInfo' for a temporary variable.
13623 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13625 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13626 non-iterator variables.
13628 2005-06-05 Martin Baulig <martin@ximian.com>
13630 * statement.cs (Foreach.TemporaryVariable): Create the
13631 LocalBuilder in the Emit phase and not in Resolve since in some
13632 situations, we don't have an ILGenerator during Resolve; see
13633 2test-19.cs for an example.
13635 2005-06-04 Martin Baulig <martin@ximian.com>
13637 **** Merged r45395 from GCS ****
13639 The big Foreach rewrite - Part II.
13641 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13642 with `PropertyInfo ienumerator_getcurrent'.
13644 * codegen.cs (VariableStorage): Removed.
13647 (Foreach): Derive from Statement, not ExceptionStatement.
13648 (Foreach.CollectionForeach): New nested class. Moved all the code
13649 dealing with collection foreach here.
13650 (Foreach.ForeachHelperMethods): Removed.
13651 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13653 2005-05-23 Martin Baulig <martin@ximian.com>
13655 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13656 don't need to. Fix #75014.
13658 2005-05-20 Martin Baulig <martin@ximian.com>
13660 Merged r44808 from GMCS.
13662 * class.cs (TypeContainer.CircularDepException): Removed.
13663 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13664 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13665 (CS0146) and interface (CS0529) dependencies here.
13667 2005-06-21 Raja R Harinath <rharinath@novell.com>
13669 * expression.cs (Invocation.EmitCall): Fix initialization
13670 'this_call' to reflect current behaviour. Fix indentation.
13672 * convert.cs (FindMostEncompassedType): Add two trivial special
13673 cases (number_of_types == 0 || number_of_types == 1).
13674 (FindMostEncompasingType): Likewise.
13676 2005-06-17 Raja R Harinath <rharinath@novell.com>
13678 Some cleanups preparing for the fix of #75283.
13679 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13681 (EventExpr.InstanceResolve): Likewise.
13682 (EventExpr.DoResolve): Remove redundant checks.
13684 2005-06-10 Duncan Mak <duncan@novell.com>
13686 * cs-tokenizer.cs (process_directives): New flag for controlling
13687 the processing of preprocessor directives.
13688 (x_token): After seeing a '#', return Token.NONE instead of going
13689 to handle_preprocessing_directive() when not processing
13690 directives. This avoids unnecessary processing during the token peek in
13695 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13696 the existing error reporting methods instead of Report.Error.
13698 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13699 after Raja's rewrite.
13701 2005-06-08 Miguel de Icaza <miguel@novell.com>
13703 * class.cs: Small fix.
13705 2005-06-08 Raja R Harinath <rharinath@novell.com>
13708 * class.cs (GetPartialBases): Fix return value check of
13709 part.GetClassBases.
13711 2005-06-07 Raja R Harinath <rharinath@novell.com>
13713 Ensure that partial classes are registered in their enclosing
13714 namespace. Initial part of fix of #75160.
13715 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13716 Register declspace with namespace here, not in
13717 DeclSpace.RecordDecl.
13718 * cs-parser.jay: Pass namespace to RecordDecl.
13719 * class.cs (PartialContainer.Create): Likewise.
13720 (ClassPart.DefineType): New sanity-check. Throws an exception if
13722 * decl.cs (Declspace.RecordDecl): Remove.
13723 * namespace.cs (NamespaceEntry.DefineName): Remove.
13725 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13727 * rootcontext.cs: Reset TargetExt as well.
13729 2005-06-03 Raja R Harinath <rharinath@novell.com>
13731 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13732 -langversion:ISO-1.
13734 2005-06-02 Raja R Harinath <rharinath@novell.com>
13736 Fix #75080, cs0119.cs.
13737 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13739 (Expression.Resolve): ... this. Use it. Remove bogus code
13740 allowing ExprClass.Type and ExprClass.Namespace for
13741 ResolveFlags.VariableOrValue.
13742 (Expression.Resolve) [1-argument variant]: Change default resolve
13743 flags based on language version.
13744 (Expression.Error_UnexpectedKind): Use a simple string array
13745 rather than an ArrayList.
13746 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13747 not ExprClass.Type.
13748 (TypeOfVoid.DoResolve): Likewise.
13749 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13750 flags argument -- it always has the same value.
13752 2005-05-31 Raja R Harinath <rharinath@novell.com>
13755 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13756 Use it in the error message.
13757 * assign.cs, expression.cs, statement.cs: Update.
13759 2005-05-30 Raja R Harinath <rharinath@novell.com>
13762 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13763 the "almostMatchedMember" case too.
13764 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13765 that failed the accessibility checks to 'almost_match'.
13767 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13769 * attribute.cs: Use internal MethodBuilder methods to set
13770 ExactSpelling and SetLastError on PInvoke methods, instead
13771 of passing them via charset. Fixes #75060.
13773 2005-05-27 Raja R Harinath <rharinath@novell.com>
13775 * parameter.cs (Parameter): Remove TODO comment.
13776 (Parameter.DefineParameter): Remove Location parameter.
13777 (Parameters.LabelParameters): Likewise.
13778 * class.cs (Constructor.Emit): Update to change.
13779 (MethodData.Emit): Likewise.
13780 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13781 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13783 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13786 Removed Parameters.Location and added Parameter.Location instead.
13787 Removed Location parameter from Emit() and GetSignature().
13794 Modified all related calls.
13796 2005-05-26 Raja R Harinath <rharinath@novell.com>
13798 Improve user-defined conversion handling.
13799 * convert.cs (GetConversionOperators): Rewrite. Return only the
13800 applicable operators.
13801 (AddConversionOperators): New. Helper for GetConversionOperators.
13802 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13803 there is only one most encompassed/encompassing type.
13804 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13805 "applicable operator" handling.
13806 (UserConversion): Move cache here from GetConversionOperators.
13807 Directly cache the chosen operator, rather than the whole
13809 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13810 case. Allow conversion of decimal to sbyte and byte too.
13811 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13812 New static methods. Used to avoid allocating EmptyExpressions in
13815 2005-05-24 Duncan Mak <duncan@novell.com>
13817 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13818 another class, used in Convert.ExplicitNumericConversion.
13819 (CastToDecimal): New class, similar to above, but casts to
13820 System.Decimal, used in Convert.ImplicitNumericConversion and also
13821 in explicit convesion from double/float to decimal.
13823 * convert.cs (ImplicitNumericConversion): Handle implicit
13824 conversions to System.Decimal.
13825 (ExplicitNumericConversion): handle explicit conversions to
13830 2005-05-20 Miguel de Icaza <miguel@novell.com>
13832 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13833 know the type at this stage, just break through. Fixes #75008
13835 2005-05-19 Martin Baulig <martin@ximian.com>
13838 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13839 to disable error reporting.
13841 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13842 here since we don't want to report an error; see the new test-336.cs.
13844 2005-05-19 Raja R Harinath <rharinath@novell.com>
13846 * statement.cs (ToplevelBlock.GetParameterReference)
13847 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13848 Move here from class Block.
13849 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13850 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13852 2005-05-18 Martin Baulig <martin@ximian.com>
13857 (FlowBranching.Reachability): Add non-static public And() and Or()
13859 (FlowBranchingSwitch): New class; do the `break_origins' thing
13860 like in FlowBranchingLoop.
13861 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13862 reachability, not just locals and parameters.
13863 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13864 switch; MergeBreakOrigins() now takes care of that.
13866 2005-05-18 Martin Baulig <martin@ximian.com>
13868 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13869 a loop and may leave it, reset the barrier; fixes #74974.
13871 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13873 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13876 * cs-parser.jay: Catch more lexical errors.
13878 * report.cs: Add one more Error method.
13881 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13883 2005-05-17 Martin Baulig <martin@ximian.com>
13885 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13888 2005-05-16 Raja R Harinath <rharinath@novell.com>
13890 Fix test-382.cs. Emit values of decimal constants.
13891 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13893 (TypeContainer.AddField): ... this.
13894 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13895 with initializers to include 'Const's.
13896 (ClassPart.RegisterFieldForInitialization): Forward to
13898 * const.cs (Const.Const): Pass initializer to base class.
13899 (Const.Define): In case of decimal constants, register them for
13900 initialization in a static constructor.
13902 2005-05-14 Martin Baulig <martin@ximian.com>
13904 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13905 do not call ResolveUnreachable() on unreachable statements in
13906 here, see the comment in the source code.
13908 2005-05-13 Raja R Harinath <rharinath@novell.com>
13911 * expression.cs (BinaryResolveOperator): If one of the operands of
13912 an equality comparison is 'null' and the other is a pointer type,
13913 convert the null to a NullPointer.
13914 * convert.cs (ImplicitReferenceConversion): If the expression is a
13915 NullLiteral and the target type is a pointer type, return a
13916 NullPointer instead.
13917 (ImplicitConversionStandard): Likewise.
13919 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13921 * cs-parser.jay: Set readonly context based on special constructs.
13923 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13924 readonly variable error handling.
13926 * rootcontext.cs (EmitCode): Don't verify members when error
13929 * statement.cs (LocalInfo): Add reaodnly context information.
13930 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13932 2005-05-13 Raja R Harinath <rharinath@novell.com>
13934 * statement.cs (Block.Resolve): Revert change below. Modify fix
13935 for #74041 to initialize 'resolved' to false only for explicit
13936 blocks. Fixes #74873.
13938 2005-05-12 Raja R Harinath <harinath@gmail.com>
13941 * typemanager.cs (unmanaged_enclosing_types): New.
13942 (IsUnmanagedType): Avoid infloops by using
13943 'unmanaged_enclosing_types' to talk with recursive invocations.
13945 2005-05-13 Martin Baulig <martin@ximian.com>
13947 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13948 instance variable, not a local. Fix #74873.
13949 (Block.ResolveUnreachable): Set it to true here.
13951 2005-05-11 Duncan Mak <duncan@novell.com>
13953 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13954 continuing to process for 'arg'.
13955 (handle_preprocessing_directive): Check the argument of the #endif
13956 directive and report error CS1025 if there are any trailing
13959 According to the C# spec, having even whitespace after the #endif
13960 directive is illegal; however, because we call arg.TrimEnd ()
13961 beforehand, we have the same behavior as csc, allowing whitespace
13962 after the directive.
13966 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13970 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13971 (Constructor.GetObsoleteAttribute): Implemented correctly.
13973 2005-05-10 Martin Baulig <martin@ximian.com>
13975 * support.cs (ReflectionParameters.ParameterModifier): Use
13976 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13977 and `ParameterAttributes.In'. Fixes #74884.
13979 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13981 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13983 * expression.cs (Argument.GetParameterModifier): Turned to property.
13984 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13986 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13989 2005-05-09 Raja R Harinath <rharinath@novell.com>
13992 * decl.cs (MemberCache.AddMethods): Register override methods,
13993 rather than non-override methods.
13994 * typemanager.cs (RegisterOverride): New.
13995 (IsOverride): Update.
13997 2005-05-09 Marek Safar <marek.safar@seznam.cz>
14001 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
14002 recursive declaration.
14004 * statement.cs (Block.ResolveMeta): Report any error in resolving.
14006 2005-05-06 Marek Safar <marek.safar@seznam.cz>
14008 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
14010 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
14012 2005-05-05 Raja R Harinath <rharinath@novell.com>
14015 * decl.cs (DeclSpace.FamilyAccessible):
14016 Use TypeManager.IsNestedFamilyAccessible.
14018 Fix reopened #64812.
14019 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
14022 2005-05-04 Raja R Harinath <rharinath@novell.com>
14023 Abin Thomas <projectmonokochi@rediffmail.com>
14024 Anoob V E <projectmonokochi@rediffmail.com>
14025 Harilal P R <projectmonokochi@rediffmail.com>
14028 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
14029 allow access to all static members.
14031 2005-05-04 Martin Baulig <martin@ximian.com>
14033 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
14035 2005-05-04 Martin Baulig <martin@ximian.com>
14039 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
14040 section at the end; make things work if `default' is not the last
14043 2005-05-04 Martin Baulig <martin@ximian.com>
14047 * statement.cs (Switch): Replaced the `got_default' field with a
14048 `default_section' one.
14049 (Switch.CheckSwitch): Set `default_section' here.
14050 (Switch.Resolve): If we're a constant switch and the constant is
14051 not found, use the default section.
14053 2005-05-03 Martin Baulig <martin@ximian.com>
14055 * expression.cs (ArrayAccess.EmitGetLength): New public method.
14057 * statement.cs (Foreach.ArrayForeach): New nested class.
14058 (Foreach.TemporaryVariable): New nested class.
14059 (Foreach.EmitArrayForeach): Removed; this is now in the new
14060 ArrayForeach class.
14062 2005-05-03 Raja R Harinath <rharinath@novell.com>
14064 * pending.cs (BaseImplements): Move the #74773 fix here. This is
14066 (VerifyPendingMethods): Revert change below.
14068 * typemanager.cs (IsOverride, RegisterNonOverride): New.
14069 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
14070 that used to trigger warning -28. Remove warning -28.
14071 * expression.cs (Invocation.OverloadResolve): Use
14072 TypeManager.IsOverride to distinguish override methods.
14075 * pending.cs (VerifyPendingMethods): If a base type implements the
14076 requested interface, don't bother checking individual methods of
14077 the base type. As a side-effect, this prevents the creation of
14078 unnecessary proxies.
14080 2005-05-02 Martin Baulig <martin@ximian.com>
14084 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
14085 Also `And' the locals if the old vector is null.
14086 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
14087 null; in this case we basically reset all the variables.
14089 2005-05-02 Martin Baulig <martin@ximian.com>
14093 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
14094 Added `FlowBranching branching' argument; always `and' the
14095 variables instead of `or'ing them unless we're an infinite loop.
14097 * statement.cs (While.Resolve): Create a new sibling unless we're
14100 2005-05-02 Martin Baulig <martin@ximian.com>
14104 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
14105 arguments; use it instead of creating a new TopLevelBlock.
14106 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
14107 our ConstructorInitializer.
14110 (TopLevelBlock.TopLevelBranching): New public property.
14111 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
14112 and create our `TopLevelBranching'.
14114 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
14115 anonymous method host, use `block.TopLevelBranching' rather than
14116 creating a new branching.
14118 2005-04-20 Miguel de Icaza <miguel@novell.com>
14120 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
14121 a ScopeInfo, if any of the current children is a child of the new
14122 entry, move those children there.
14124 2005-04-30 Martin Baulig <martin@ximian.com>
14126 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
14127 at the beginning of a SwitchSection. Fix #73335.
14129 2005-04-27 Marek Safar <marek.safar@seznam.cz>
14132 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
14134 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
14135 (FieldExpr.DoResolve): Obsolete members are ignored for field
14138 2005-04-26 Marek Safar <marek.safar@seznam.cz>
14140 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
14141 of arrays detection.
14143 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
14145 (Field.VerifyClsCompliance): Volatile fields are not compliant.
14147 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
14150 2005-04-25 Ben Maurer <bmaurer@ximian.com>
14152 * cs-parser.jay: Use the prefered version of -unsafe in error
14155 2005-04-22 Marek Safar <marek.safar@seznam.cz>
14157 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
14160 2005-04-20 John Luke <john.luke@gmail.com>
14162 * driver.cs: fix typo in error message, --outout to --output
14164 2005-04-20 Marek Safar <marek.safar@seznam.cz>
14166 * codegen.cs (InRefOutArgumentResolving): New field.
14168 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
14169 fields outside contructor.
14171 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
14173 2005-04-19 Miguel de Icaza <miguel@novell.com>
14175 * anonymous.cs (CaptureContext.EmitParameterInstance): The
14176 parameter code was not completed ever, so it was not as up-to-date
14177 as local variables. Must finish it.
14179 The bug fix was to compare the Toplevel of the block, not the
14180 current block. Thanks for Ben for pointing this out.
14182 2005-04-19 Raja R Harinath <rharinath@novell.com>
14184 * decl.cs (AddMethods): Use the declaring type of the problem
14185 method to determine if we want to squash a warning.
14187 2005-04-19 Marek Safar <marek.safar@seznam.cz>
14189 * attribute.cs: Removed debug output.
14191 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
14193 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
14196 2005-04-18 Raja R Harinath <rharinath@novell.com>
14199 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
14200 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
14201 all null comparisons against reference types.
14203 2005-04-18 Marek Safar <marek.safar@seznam.cz>
14206 * class.cs (TypeContainer.CircularDepException) New nested
14208 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
14209 (TypeContainer.DefineType): Removed error, reset InTransit before
14211 (Class.DefineType): Throw exception when is in Transit.
14212 Catch exception and report error.
14213 (Struct.DefineType): Throw exception when is in Transit.
14214 Catch exception and report error.
14215 (Interface.DefineType): Throw exception when is in Transit.
14216 Catch exception and report error.
14218 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
14219 handle nested exception handlers.
14221 * flowanalysis.cs (InTryWithCatch): New method, search for try with
14224 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
14225 InFinally and InCatch storage.
14227 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
14228 (Catch.Resolve): Set and Restore ec.InCatch.
14229 (Try.Resolve): Set and Restore ec.InFinally.
14230 (Try.HasCatch): True when try has catch.
14232 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
14234 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
14235 for the same event member, so exclude such cases from warning 419.
14238 2005-04-16 Miguel de Icaza <miguel@novell.com>
14240 * expression.cs (Binary.ResolveOperator): Apply patch from John
14241 Luke to fix bug 59864: operators &, | and ^ on enumerations
14242 require that the same enum type on both sides.
14244 * driver.cs: Add warnings to old flag usage, this is to assist
14245 people who produce Makefiles and hope that the Makefiles will be
14248 * class.cs (TypeContainer.EmitType): Moved the definition of the
14249 special $PRIVATE$ field from the resolve phase to the Emit phase.
14250 During resolve we do not know if we are a struct with
14251 HasExplicitLayout, we know this only after the attributes for the
14254 Set the FieldOffset to zero on the dummy field that we create for
14255 the class. Fixes 74590.
14257 2005-04-16 Raja R Harinath <rharinath@novell.com>
14260 * ecore.cs (PropertyExpr.resolved): New.
14261 (DoResolve): Use it to handle a case of double resolution here.
14262 Handle a case of identical-name-and-type-name.
14263 * expression.cs (ArrayCreation.CheckIndices): Avoid double
14264 resolution by storing the results of expression resolution back
14265 into the "probes" array.
14267 2005-04-15 Raja R Harinath <rharinath@novell.com>
14269 Fix cs0208-7.cs and cs0208-8.cs.
14270 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14271 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14272 error reporting to point out the reason a struct is not unmanaged.
14274 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14276 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14277 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14279 2005-04-13 Raja R Harinath <rharinath@novell.com>
14282 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14283 IdenticalNameAndTypeName here.
14284 (EventExpr.InstanceResolve): Likewise.
14286 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14288 C# 2.0 DefaultCharSetAttribute implementation
14290 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14291 which allows us to set GlobalNamespace for every resolve.
14292 (Attribute.ResolveArguments): Cut from Resolve.
14293 (Attribute.GetCharSetValue): Returns CharSet named argument.
14294 (Attribute.DefinePInvokeMethod): Gets default charset from
14296 (GlobalAttribute.ResolveAsTypeStep): Override.
14297 (GlobalAttribute.ResolveArguments): Override.
14299 * class.cs (TypeAttr): Is protected.
14301 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14302 (ModuleClass.DefaultCharSetType): New memeber.
14303 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14305 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14306 charset from module.
14308 * delegate.cs (TypeAttr): Override.
14309 (Delegate.DefineType): Use this TypeAttr.
14311 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14312 at very early stage (before types are defined) to resolve model
14313 module attributes. It will probably not work with corlib but it
14316 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14317 charset from module.
14319 * typemanager.cs (default_charset_type): New type.
14321 2005-04-13 Raja R Harinath <rharinath@novell.com>
14323 * decl.cs (MemberCache.AddMethods): Don't warn if
14324 System.Object.Finalize has buggy MethodAttributes.
14326 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14329 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14331 * doc.cs : detect ambiguous reference to overloaded members.
14332 Fixed bug #71603. MS 1.1 csc does not detect it.
14334 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14336 * doc.cs : delegates must not be referenced with parameters.
14339 2005-04-12 Miguel de Icaza <miguel@novell.com>
14341 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14343 2005-04-10 Miguel de Icaza <miguel@novell.com>
14345 * driver.cs (MainDriver): Stop processing if the CLS stage found
14348 (CompilerCallableEntryPoint.InvokeCompiler): Always
14349 reset after execution; Take a TextWriter argument for the
14352 * report.cs: Use the error stream instead of hardcoding stderr.
14354 2005-04-09 Miguel de Icaza <miguel@novell.com>
14356 * class.cs: Reduce code paths to test, too small of an
14357 optimization to make it worth the extra testing. Always perform
14360 2005-04-08 Raja R Harinath <rharinath@novell.com>
14363 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14364 operators that had errors reported on them.
14366 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14368 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14370 (Attribute.Resolve): Add named argument type checking.
14372 * class.cs (FixedField.Define): Use IsPrimitiveType
14374 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14376 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14377 unsafe parameter types.
14379 * statement.cs (Using.ResolveExpression): Add better error description.
14381 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14383 2005-04-08 Raja R Harinath <rharinath@novell.com>
14386 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14387 AttributeUsageAttribute in the emitcontext of the attribute class,
14388 not in the emitcontext of the attributable entity it was attached to.
14389 * cs-parser.jay: Use 'current_class', not 'current_container',
14390 when creating a GlobalAttribute.
14392 2005-04-08 Alp Toker <alp@atoker.com>
14394 * pending.cs: The fix to #58413 failed to compile methods implementing
14395 interfaces with/without params modifiers and vice versa, even though
14396 params modifiers aren't part of the signature. Make the modifier check
14397 less strict as in csc.
14399 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14400 Anoob V E <projectmonokochi@rediffmail.com>
14401 Harilal P R <projectmonokochi@rediffmail.com>
14404 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14405 modifiers of pending methods.
14406 (PendingImplementation.PendingImplementation): Initialize it.
14407 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14408 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14409 with ParameterData. Add check for modifiers.
14410 * class.cs (MethodData.Define): Update to changes.
14412 2005-04-07 Raja R Harinath <rharinath@novell.com>
14414 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14416 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14418 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14421 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14424 * typemanager.cs: Registered RequiredAttributeAttribute.
14426 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14428 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14429 Warning CS0169 is back at level 3.
14430 (IMethodData.SetMemberIsUsed): New method.
14432 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14433 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14435 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14437 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14439 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14442 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14445 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14446 to avoid the problems with nested types.
14448 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14449 Anoob V.E <projectmonokochi@rediffmail.com>
14450 Harilal P.R <projectmonokochi@rediffmail.com>
14451 Raja R Harinath <rharinath@novell.com>
14454 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14456 * typemanager (GetConstructor): Make public.
14458 2005-04-05 John Luke <john.luke@gmail.com>
14459 Raja R Harinath <rharinath@novell.com>
14462 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14463 struct too. Return false quicker in a few cases.
14464 (VerifyUnManaged): Use it.
14466 2005-04-05 Raja R Harinath <rharinath@novell.com>
14469 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14470 not 'unreachable_seen'.
14472 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14474 * attribute.cs (Attribute.GetValue): Removed unused.
14476 * codegen.cs (CodeGen.TrimExt): Removed unused.
14478 * cs-parser.jay (output): Removed unused.
14480 * cs-tokenizer.cs (hex_digits): Removed unused.
14482 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14484 * expression.cs (Indirection.LoadExprValue): Removed unused.
14485 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14487 * iterators.cs (Iterator.param_types): Removed unused.
14489 * statement.cs (Goto.block): Removed unused.
14490 (ToplevelBlock.did): Removed unused.
14491 (Switch.ResolveConstantSwitch): Removed unused.
14493 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14495 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14498 2005-04-01 Raja R Harinath <rharinath@novell.com>
14500 Fix #74232 and cs0208-3.cs.
14501 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14502 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14503 unmanaged type. Don't use FieldBuilders when 't' is a
14504 TypeBuilder. Use ModFlags and MemberType fields.
14505 * class.cs (MemberBase.member_type): Rename from MemberType.
14506 (MemberBase.MemberType): New property. Determines member_type on
14508 (MemberBase.DoDefine): Don't initialize MemberType here.
14509 (FieldMember.Define): Likewise.
14511 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14514 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14515 Attributes are emitted there.
14517 2005-04-01 Raja R Harinath <rharinath@novell.com>
14519 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14520 keyword in 'partial enum' too.
14521 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14523 Report from Kamil Skalski <nazgul@omega.pl>.
14526 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14527 have partial containers too.
14529 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14530 in block' checks to Block.CheckInvariantMeaningInBlock.
14531 * statement.cs (Block.GetKnownVariableInfo): Make private.
14532 (Block.IsVariableUsedInChildBlock): Remove.
14533 (Block.IsVariableUsedInBlock): Likewise.
14534 (Block.CheckInvariantMeaningInBlock): New. Show location of
14535 conflicting declaration.
14536 (Block.AddVariable): Make error messages less long-winded and more
14537 specific. Show location of conflicting declaration.
14538 * parameter.cs (Parameters.Location): New readonly property.
14540 2005-03-31 Raja R Harinath <rharinath@novell.com>
14542 Clean up semantics of invoking ResolveMemberAccess.
14543 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14544 can have an instance, ensure that we pass in a non-TypeExpression
14545 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14546 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14547 argument. Update to changes and simplify.
14548 (FieldExpr.Emitinstance): Remove CS0120 check.
14549 (PropertyExpr.EmitInstance): Likewise.
14550 * expression.cs (Argument.Resolve): Likewise.
14551 (Invocation.DoResolve): Update to changes in semantics of
14552 InstanceExpression.
14554 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14557 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14560 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14562 2005-03-31 Raja R Harinath <rharinath@novell.com>
14564 Fix difference in behaviour with commandline invocation.
14565 * driver.cs (Driver.Reset): New.
14566 (CompilerCallableEntryPoint): Call it.
14568 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14569 variable" warnings if the boolean expression failed to resolve.
14571 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14573 * attribute.cs: Fix the union of several permissions when some of them
14574 are unrestricted (so the result isn't an unrestricted permission set).
14577 2005-03-30 Raja R Harinath <rharinath@novell.com>
14579 * ecore.cs (MemberExpr): New class. Convert from interface
14581 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14582 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14584 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14585 (MethodGroupExpr.IsExplicitImpl): Remove.
14586 (Expression.GetFieldFromEvent): Remove.
14587 (SimpleName.MemberStaticCheck): Remove.
14588 (SimpleName.DoSimpleNameResolve): Update to changes.
14589 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14590 (MemberAccess.IdenticalNameAndTypeName): Remove.
14591 (MemberAccess.error176): Move to MemberExpr.
14592 (MemberAccess.DoResolve): Update to changes.
14593 (BaseAccess.DoResolve): Likewise.
14595 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14597 C# 2.0 Conditional attribute class implementation
14599 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14600 Analyzes class whether it has attribute which has ConditionalAttribute
14601 and its condition is not defined.
14603 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14604 (Class.IsExcluded): New method. Search for at least one defined
14605 condition in ConditionalAttribute of attribute class.
14607 2005-03-30 Raja R Harinath <rharinath@novell.com>
14609 * ecore.cs (PropertyExpr): Derive from Expression, not
14610 ExpressionStatement.
14611 (PropertyExpr.EmitStatement): Remove.
14613 2005-03-29 Raja R Harinath <rharinath@novell.com>
14616 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14617 internal field "value__" of an enum be private. The examples for
14618 "value__" that I found on MSDN all used FieldAttributes.Private.
14620 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14621 Don't mention IL method attribute names.
14623 Fix #47991. Remove a TODO.
14624 * statement.cs (Block.Toplevel): Make into a field.
14625 (Block.Parameters): Move into ToplevelBlock.
14626 (Block.known_variables): Rename from child_variable_names.
14627 (Block.Block): Remove variants that take Parameters. Initialize
14628 'Toplevel' with the immediately surrounding toplevel block.
14629 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14630 LocalInfo parameter.
14631 (Block.GetKnownVariableInfo): New.
14632 (Block.IsVariableNameUsedInChildBlock): Update.
14633 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14634 the block, even though it may not be in scope.
14635 (Block.AddVariable): Remove Parameters parameter. Use
14636 Toplevel.Parameters instead.
14637 (Block.AddConstant): Remove Parameters parameter.
14638 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14639 (Block.IsParamaterReference): Likewise.
14640 (Block.IsLocalParameter): Likewise. Simplify a lot.
14641 (ToplevelBlock.Parameters): New. Moved from Block.
14642 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14643 initialize Parameters to a non-null value.
14644 * cs-parser.jay: Update to changes.
14645 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14646 simple names that mean different things in the same block. Use
14647 Block.IsVariableNameUsedInBlock.
14649 2005-03-28 Raja R Harinath <rharinath@novell.com>
14651 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14652 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14653 GetTypeHandle. It is possible for a reflected type to derive from
14654 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14655 System.Array during mscorlib compilation).
14656 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14657 contain a method_hash, don't create one either. Don't create a
14658 deep copy of the base cache's method_hash.
14659 (MemberCache.SetupCache): Rename back from DeepCopy.
14660 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14661 already initialized. If we see an override function, add its
14662 underlying base virtual function to the member_hash too.
14664 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14666 2005-03-26 Raja R Harinath <harinath@acm.org>
14669 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14670 fails to resolve, ensure that the LHS is still resolved as an
14673 2005-03-25 Raja R Harinath <harinath@acm.org>
14675 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14677 (Enum.current_ec): Remove.
14678 (Enum.LookupEnumValue): Remove EmitContext argument.
14679 Just uses the one created during DefineType.
14680 (Enum.FindMembers): Update.
14681 * expression.cs (MemberAccess.DoResolve): Update.
14683 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14685 * assign.cs (Assign.DoResolve): Check for CS1717 when
14686 source and target are same (uses Equals).
14688 * expression.cs (LocalVariableReference, ParameterReference,
14689 This): Implemented Equals, GetHashCode.
14691 * statement.cs (Block.GetParameterReference): Removed useless
14694 2005-03-22 Raja R Harinath <rharinath@novell.com>
14697 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14698 blocks before deciding whether the error is cs0136 or cs0128.
14700 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14701 (using_alias_directive, using_namespace_directive): Pass
14702 MemberName, not an expression to Namespace.UsingAlias and
14704 (MakeName): Use the MemberName of the namespace.
14705 * namespace.cs (Namespace.MemberName): New.
14706 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14707 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14709 * decl.cs (MemberName.Name): Make readonly.
14710 (MemberName.FromDotted): New "constructor".
14711 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14712 (MemberCore.Name): Compute from MemberName on demand.
14713 (MemberCore.SetMemberName): Provide a way to change the
14715 (MemberCore.AddToContainer): Don't take a fullname parameter.
14716 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14717 fully qualified name of the container to the member name.
14718 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14719 only if the type is a member of the root container.
14720 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14721 MemberName.Left rather than searching for an embedded ".".
14722 (PartialContainer.CreatePart): Update to changes in RootContext.
14723 (MemberBase.ShortName): Turn into a property. Use
14724 MemberCore.SetMemberName.
14725 (MemberBase.ExplicitInterfaceName): Remove.
14726 (MemberBase.UpdateMemberName): Remove.
14727 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14728 (PropertyBase.SetMemberName): New override.
14729 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14730 (Tree.GetDecl): New.
14731 (Tree.AllDecls): Rename from Decls.
14732 * attribute.cs, enum.cs, report.cs: Update to changes.
14733 * driver.cs (MainDriver): Use MemberName.FromDotted on
14734 RootContext.MainClass.
14736 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14738 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14741 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14743 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14745 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14746 property accessor modifiers.
14748 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14749 fixed buffer attribute (CS1716).
14750 (PropertyMethod.HasCustomAccessModifier): When property accessor
14751 has custom modifier.
14753 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14755 (PropertyExpr.DoResolveLValue): Add CS0272.
14757 2005-03-17 Miguel de Icaza <miguel@novell.com>
14759 * convert.cs: When converting to a pointer, use the proper Conv.U
14760 or Conv.I depending on the source data type.
14762 * cs-tokenizer.cs: Make the size for large decimal constants,
14765 2005-03-17 Martin Baulig <martin@ximian.com>
14767 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14768 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14770 2005-03-17 Martin Baulig <martin@ximian.com>
14772 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14773 to bool so we can return an error condition.
14774 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14777 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14779 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14782 2005-03-16 Raja R Harinath <rharinath@novell.com>
14784 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14785 Refactor to avoid traversing the list of assemblies, and to avoid
14786 string concatenation.
14787 * typemanager.cs (guid_attr_type): Remove.
14788 (negative_hits, pointers, references): Remove hashes.
14790 (GetConstructedType): New. Uses type_hash to handle constructed
14791 types (arrays, references, pointers).
14792 (GetReferenceType, GetPointerType): Use it.
14793 (GetNestedType): New. Uses type_hash to handle nested types of
14795 (LookupType, LookupTypeDirect): Remove.
14796 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14797 'types' hash and LookupTypeReflection directly.
14798 (params_string, params_object): Use GetConstructedType.
14799 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14801 (Namespace.Lookup): Use cached_types.
14802 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14803 provided by old TypeManager.LookupType.
14804 * rootcontext.cs (MakeFQN): Remove.
14805 * decl.cs (DeclSpace.MakeFQN): Likewise.
14806 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14807 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14808 TypeManager.GetConstructedType.
14809 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14811 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14813 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14816 * cs-parser.jay: Reports CS1527 for any namespace element.
14818 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14821 * expression.cs (ParameterReference.IsAssigned): Changed error to
14823 (Error_WrongNumArguments): Moved CS0245 detection here.
14825 * statement.cs (Return.Resolve): Add CS1622 report.
14827 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14829 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14831 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14833 * attribute.cs expression.cs: Get rid of some allocations.
14835 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14837 * doc.cs : just eliminate the latest change.
14839 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14841 * doc.cs : commented out the latest change. It breaks xml-030.cs
14843 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14845 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14846 fail. So invoke CreateType() in FindDocumentedType().
14848 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14850 * cs-tokenizer.cs : added IsKeyword().
14851 * doc.cs : Detect keyword incorrectly used as identifier.
14852 Allow identifiers prefixed by @.
14854 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14856 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14857 It caused exception in namespace resolving (again!).
14859 * class.cs (Class.ctor): Removed exit.
14860 (PropertyMethod.ctor): ditto.
14862 * codegen.cs (Codegen.Reset): Reset static data.
14863 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14865 * cs-tokenizer.cs (Cleanup): Removed.
14867 * driver.cs (GetSystemDir): Rewrote to one line command.
14868 It caused problem with unloaded dynamic modules.
14869 (UnixParseOption): Removed Exit.
14870 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14871 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14872 Now can be mcs used as library.
14874 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14877 * location.cs (Reset): Reset static data.
14879 * namespace.cs (Reset): Reset static data.
14881 * report.cs (Report.Reset): Reset static data.
14883 * rootcontext.cs (RootContext.Reset): Reset static data.
14885 * tree.cs (RootTypes.ctor): Use Location.Null
14887 * typemanager.cs (TypeManager.Reset): Reset static data.
14888 (CoreLookupType): Removed Exit.
14889 (TypeHandle.Reset): Reset static data.
14891 2005-03-10 Raja R Harinath <rharinath@novell.com>
14894 * typemanager.cs (ComputeNamespaces): Import namespaces from
14895 referenced modules too.
14897 2005-03-09 Raja R Harinath <rharinath@novell.com>
14899 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14902 2005-03-09 Raja R Harinath <rharinath@novell.com>
14904 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14905 enclosing DeclSpace. This ensures that a name-lookup populates
14906 more caches and there are fewer 'TypeExpression's. Carve out
14907 nested type lookup into ...
14908 (LookupNestedTypeInHierarchy): ... this.
14910 2005-03-09 Raja R Harinath <rharinath@novell.com>
14912 Clean up a few partial-class semantics.
14913 Fixes test-357.cs and cs1618-2.cs.
14914 * cs-parser.jay (struct_declaration): Use 'current_class' as
14915 parent of newly-created struct. Remove call to Register ().
14916 Use 'pop_current_class' to complete handing the current struct.
14917 (interface_declaration): Likewise.
14918 (class_declaration): Likewise.
14919 (enum_declaration): Use 'current_class' as parent of newly created
14921 (delegate_declaration): Likewise.
14922 (pop_current_class): New function. This is used to handle closing
14923 up the 'current_class' and 'current_container', and pointing them
14924 to the enclosing class/container.
14925 (CSharpParser): Initialize 'current_class' too.
14926 * decl.cs (MemberCore): Add check for invariant: a partial
14927 container is not a parsed entity, and thus does not enclose any
14929 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14930 (DeclSpace.BaseTypeExpr): Use it.
14931 (DeclSpace.LookupType): Add check for invariant.
14932 * class.cs (TypeContainer): Add check for invariant: a nested
14933 class should have the same NamespaceEntry as its enclosing class.
14934 (TypeContainer.EmitFieldInitializers): Make virtual.
14935 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14937 (TypeContainer.Register): Remove.
14938 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14939 null. Use TypeResolveEmitContext for resolving base types and
14940 interfaces. Move initialization of Parts.TypeBuilder here from
14942 (TypeContainer.DefineNestedTypes): ... here.
14943 (PartialContainer): Take a Namespace not a NamespaceEntry.
14944 (PartialContainer.Create): Don't use Register. Call the
14945 appropriate Add... function directly.
14946 (ClassPart): Take both the PartialContainer and the enclosing
14947 class as constructor arguments.
14948 (ClassPart.EmitFieldInitializers): Override.
14949 (ClassPart.PartFindNestedTypes): Remove.
14950 (FieldBase.GetInitializerExpression): Resolve the initializer
14951 expression in the emit context of the enclosing class.
14952 * tree.cs (RootTypes): Remove Register ().
14954 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14956 * cs-parser.jay: Removed CS0134.
14958 * driver.cs: Removed CS1901.
14960 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14961 for predefined types.
14963 2005-03-07 Duncan Mak <duncan@novell.com>
14965 * codegen.cs (Save): Catch UnauthorizedAccessException as
14966 well. Fixes bug #73454.
14968 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14970 * cs-tokenizer.cs (xtoken): Add CS1035.
14972 * class.cs (MethodData.Define): Add CS0683.
14973 (FieldMember.ctor): Add CS0681.
14975 2005-03-07 Raja R Harinath <rharinath@novell.com>
14977 * ecore.cs (SimpleName.DoResolve): Rename from
14978 SimpleName.DoResolveAllowStatic.
14979 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14980 Pass 'intermediate' flag to MemberStaticCheck.
14981 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14982 of "intermediate" lookups via MemberAccess.
14983 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14984 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14986 2005-03-07 Raja R Harinath <rharinath@novell.com>
14989 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14990 slipped in because of variable names that are identical to a
14991 builtin type's BCL equivalent ('string String;', 'int Int32;').
14992 (PropertyExpr.EmitInstance): Likewise.
14994 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14996 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14998 * report.cs (warning_ignore_table): Made public.
15000 2005-03-04 Raja R Harinath <rharinath@novell.com>
15003 * class.cs (MethodData.Emit): Pass 'container' to
15004 container.GetObsoleteAttribute instead of 'container.Parent'.
15006 2005-03-03 Marek Safar <marek.safar@seznam.cz>
15008 * cs-parser.jay: Add 1534 error test.
15010 * iterators.cs (Yield.CheckContext): Add error 1629.
15011 (Iterator.ctor): Save unsafe modifier.
15012 (MoveNextMethod.DoEmit): Restore unsafe context.
15014 * namespace.cs (UsingAlias): Better error message.
15016 2005-03-03 Dan Winship <danw@novell.com>
15018 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
15019 the warning message [#73219]
15021 2005-03-03 Raja R Harinath <rharinath@novell.com>
15023 Fix compile with MCS 1.0.0.0.
15024 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
15025 w_restore to not depend on string constant folding.
15027 2005-03-03 Raja R Harinath <rharinath@novell.com>
15029 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
15030 CS0246 check to users who passed 'silent = false'.
15031 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
15033 (SimpleName.SimpleNameResolve): Update.
15034 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
15035 (MemberAccess.IdenticalNameAndTypeName): Update.
15036 * doc.cs (FindDocumentedTypeNonArray): Update.
15038 2005-03-03 Raja R Harinath <rharinath@novell.com>
15040 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
15041 * parameters.cs (ComputeAndDefineParameters): Remove.
15042 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
15043 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
15044 Use GetParameterInfo.
15046 2005-03-02 Marek Safar <marek.safar@seznam.cz>
15048 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
15050 2005-03-02 Raja R Harinath <rharinath@novell.com>
15052 Unify DeclSpace.LookupType and DeclSpace.FindType.
15053 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
15054 is in charge of defining nested types on demand.
15055 (DeclSpace.LookupType): Use it when the current_type is a
15056 TypeBuilder. Use LookupTypeDirect for reflected types.
15057 (DeclSpace.FindType): Remove.
15058 (DeclSpace.LookupInterfaceOrClass): Likewise.
15059 (DeclSpace.DefineTypeAndParents): Likewise.
15060 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
15061 DeclSpace.LookupType.
15062 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
15063 * typemanager.cs (LookupType): Simplify.
15064 (AddUserType): Remove type from negative_hits.
15065 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
15066 * class.cs (TypeContainer.FindMembers): Move handling of nested
15068 (TypeContainer.FindMembers_NestedTypes): ... here.
15069 (TypeContainer.FindNestedType): Implement override.
15070 (ClassPart.FindNestedType): Delegate to PartialContainer.
15071 (ClassPart.PartFindNestedType): Looks up the nested types of the
15074 2005-03-02 Martin Baulig <martin@ximian.com>
15076 * class.cs (TypeContainer.DoDefineMembers): We also need a default
15077 static constructor in static classes.
15079 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
15081 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
15082 sizeParamIndex is not specified.
15084 2005-03-01 Marek Safar <marek.safar@seznam.cz>
15087 * report.cs (WarningMessage.IsEnabled): Missing null check.
15089 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15091 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
15092 in the fields and not in the properties.
15094 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
15096 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
15099 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15101 * attribute.cs: Small refactoring (improved robustness).
15102 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
15103 (ValidateGuid): Removed.
15104 (Resolve): Removed referenced to above mentioned.
15105 (GetAttributeUsage): Made private and changed to work without
15107 (GetIndexerAttributeValue): Don't crash.
15108 (GetConditionalAttributeValue): Ditto.
15109 (GetClsCompliantAttributeValue): Ditto.
15110 (ExtractSecurityPermissionSet): All attributes exceptions are
15112 (GetPropertyValue): New helper.
15113 (GetMethodImplOptions): New method.
15114 (DefinePInvokeMethod): Reuse common code. Implemented handling of
15115 some missing properties.
15117 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
15118 (Method.ApplyAttributeBuilder): Updated.
15120 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
15123 2005-02-28 Raja R Harinath <rharinath@novell.com>
15126 * report.cs (Report.SymbolRelatedToPreviousError): Handle
15127 non-simple types (array, pointer, reference).
15129 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15131 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
15133 * class.cs (MethodCore.IsDuplicateImplementation): Special error
15135 (Method.CheckBase): Catch wrong destructor here.
15136 (MethodData.Define): Add errors 550, 668.
15138 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
15140 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
15142 * pending.cs (VerifyPendingMethods): Add error 551.
15144 * typemanager.cs (CSharpName): Next error report helper.
15146 2005-02-25 Marek Safar <marek.safar@seznam.cz>
15148 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
15149 attributes. Removed useless attribute double check.
15150 It saves almost 2MBs for corlib.
15152 2005-02-25 Raja R Harinath <rharinath@novell.com>
15155 * statement.cs (ExpressionStatement.Resolve): Make robust to being
15156 called twice in case of error.
15158 2005-02-23 Chris Toshok <toshok@ximian.com>
15160 Fix compiler portions of #72827.
15161 * statement.cs (Block.Emit): call Begin/EndScope on the
15162 EmitContext instead of the ILGenerator.
15164 * codegen.cs (EmitContext.BeginScope): new method, call
15165 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
15167 (EmitContext.BeginScope): same, but EndScope and CloseScope
15169 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
15170 offset and call the superclass's OpenScope(int) with it.
15171 (SymbolWriter.CloseScope): get the current il
15172 offset and call superclass's CloseScope(int) with it.
15174 2005-02-23 Marek Safar <marek.safar@seznam.cz>
15176 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
15177 CS1677 for out and ref as well.
15179 * class.cs (Method.Define): Add error CS1599 detection.
15181 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
15183 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
15185 * delegate.cs (Delegate.Define): Add error CS1599 detection.
15187 * support.cs.cs (ModifierDesc): New helper method.
15189 2005-02-23 Raja R Harinath <rharinath@novell.com>
15190 Abin Thomas <projectmonokochi@rediffmail.com>
15191 Anoob V E <projectmonokochi@rediffmail.com>
15192 Harilal P R <projectmonokochi@rediffmail.com>
15194 Fix #57851, #72718.
15195 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
15196 MemberLookup (used for error reporting) actually returns a result.
15197 Fix error report number (122, not 112).
15199 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
15200 Anoob V E <projectmonokochi@rediffmail.com>
15201 Harilal P R <projectmonokochi@rediffmail.com>
15204 * pending.cs (PendingImplementation.GetAbstractMethods):
15205 Find NonPublic members too.
15207 2005-02-22 Marek Safar <marek.safar@seznam.cz>
15209 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
15212 * class.cs (MethodCore.CheckMethodAgainstBase):
15213 Add error 239 report.
15215 2005-02-21 Raja R Harinath <rharinath@novell.com>
15218 * expression.cs (Invocation.IsApplicable): Make public.
15219 (Invocation.IsParamsMethodApplicable): Likewise.
15220 * delegate.cs (Delegate.VerifyApplicability): Don't use
15221 Invocation.VerifyArgumentCompat for parameter applicability
15222 testing. Use Invocation.IsApplicable and
15223 Invocation.IsParamsMethodApplicable.
15225 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15227 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
15229 * class.cs (Operator.Define): Add error 217 report.
15231 2005-02-21 Raja R Harinath <rharinath@novell.com>
15233 * namespace.cs (UsingEntry.Resolve): Undo change below.
15235 2005-02-21 Raja R Harinath <rharinath@novell.com>
15238 * ecore.cs (Expression.MemberLookupFailed): Add argument to
15239 disable the error message when the extended MemberLookup also
15241 (Expression.MemberLookupFinal): Update.
15242 (SimpleName.DoSimpleNameResolve): Update.
15243 * expression.cs (MemberAccess.ResolveNamespaceOrType):
15244 Don't use MemberLookupFinal.
15245 (New.DoResolve): Update.
15246 (BaseAccess.CommonResolve): Update.
15248 2005-02-21 Raja R Harinath <rharinath@novell.com>
15251 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
15252 occured previously, don't resolve again.
15254 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15257 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
15258 argument. Call ResolveAttributeUsage for unresolved.
15259 when types doesn't match ctor arguments.
15261 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
15262 for nested attribute classes.
15263 (Class.attribute_usage): Removed.
15264 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
15265 for attribute class.
15267 * ecore.cs (IsAttribute): Removed.
15269 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15271 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15273 (attribute_types): Removed.
15274 (EmitCode): Global attributes are emited as the latest.
15276 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15278 * class.cs (EmitFieldInitializers): Don't emit field initializer
15279 for default values when optimilization is on.
15281 * constant.cs (Constant.IsDefaultValue): New property.
15283 * driver.cs: Add /optimize handling.
15287 * literal.cs: Implement new IsDefaultValue property.
15289 * rootcontext.cs (Optimize): New field, holds /optimize option.
15291 2005-02-18 Raja R Harinath <rharinath@novell.com>
15293 Fix crasher in re-opened #72347.
15294 * namespace.cs (Namespace.Lookup): Return null if
15295 DeclSpace.DefineType returns null.
15298 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15300 2005-02-18 Raja R Harinath <rharinath@novell.com>
15302 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15303 now returns null if it cannot resolve to an lvalue.
15304 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15305 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15306 returned null. Remove check for SimpleName.
15307 (EventExpr.DoResolveLValue): New.
15308 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15309 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15311 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15312 avoid CS0131 error.
15313 (Unary.ResolveOperator): Move CS0211 check ...
15314 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15316 (Unary.DoResolveLValue): Simplify.
15317 (AddressOf.DoResolveLValue): New.
15318 (ArrayAccess.DoResolveLValue): New.
15320 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15322 * attribute.cs (Attribute.Resolve): Add arguments casting for
15323 when types doesn't match ctor arguments.
15325 2005-02-16 Raja R Harinath <rharinath@novell.com>
15327 Fix parts of #63202.
15328 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15329 lookup of operator in base type. Ensure that all checks happen
15330 when the operator resolves to an "op_..." method.
15332 2005-02-15 Raja R Harinath <rharinath@novell.com>
15335 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15336 'ignore_cs0104' parameter. Pass it to ...
15337 (NamespaceEntry.Lookup): ... this.
15338 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15339 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15340 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15341 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15342 Update. Request that cs0104 errors be ignored.
15343 (ComposedCast.ResolveAsTypeStep): Update.
15345 2005-02-14 Raja R Harinath <rharinath@novell.com>
15348 * expression.cs (Invocation.BetterFunction): Remove support for
15349 comparing virtual functions and their overrides.
15350 (Invocation.IsOverride): New.
15351 (Invocation.OverloadResolve): Don't consider 'override' functions
15352 during candidate selection. Store them in a lookaside list.
15353 If the selected method is a 'virtual' function, use the list to
15354 find any overrides that are closer to the LHS type.
15356 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15358 * expression.cs (New.DoResolve): Add complex core type reduction.
15359 (New.Constantify): Converts complex core type syntax like 'new int ()'
15360 to simple constant.
15362 2005-02-14 Raja R Harinath <rharinath@novell.com>
15364 * decl.cs (EntryType.EntryType): New constructor to create an
15365 updated copy of a cache entry.
15366 (MemberCache.AddMethods): Use it.
15367 (MemberCache.ClearDeclaredOnly): Remove.
15368 (MemberCache.MemberCache): Update.
15370 2005-02-11 Miguel de Icaza <miguel@novell.com>
15372 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15373 variable. This one is represents the actual low-level declaration
15374 of the method, as opposed to the semantic level `IsStatic'.
15376 An anonymous method which is hosted into a static method might be
15377 actually an instance method. IsStatic would reflect the
15378 container, while MethodIsStatic represents the actual code
15381 * expression.cs (ParameterReference): Use the new MethodIsStatic
15382 instead of IsStatic.
15384 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15385 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15386 set on the current EmitContext.
15388 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15389 resolve our casted expression as an LValue. This triggers the
15390 proper LValue processing that is later required by Assign.
15394 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15396 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15398 C# 2.0 Fixed buffer implementation
15400 * anonymous.cs: Update after RegisterHelperClass renaming.
15402 * attribute.cs (AttributeTester.fixed_buffer_cache):
15403 Cache of external fixed buffers.
15404 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15405 implementation if field is fixed buffer else null.
15408 (TypeContainer.AddField): Accept FieldMember instead of Field.
15409 (FieldBase.IsFieldClsCompliant): Extracted code from
15410 VerifyClsCompliance descendant customization.
15411 (FixedField): New class handles fixed buffer fields.
15412 (FixedFieldExternal): Keeps information about imported fixed
15414 (IFixedField): Make access to internal or external fixed buffer
15417 * cs-parser.jay: Add fixed buffer parsing.
15419 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15422 * expression.cs (Indirection): Extended implementation to accept
15423 fixed buffer field.
15424 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15425 (ElementAccess.MakePointerAccess): Get type as parameter.
15426 (DoResolve): Add fixed buffer field expression conversion.
15427 (DoResolveLValue): Ditto.
15428 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15429 (ArrayPtr): Derives from FixedBufferPtr.
15430 (ArrayPtr.Emit): Add extra emit for array elements.
15432 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15434 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15435 for compiler generated types.
15436 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15438 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15439 and consume less memory.
15440 (Fixed.Resolve): Add fixed buffer case.
15442 * typemanager.cs (compiler_generated_attr_ctor,
15443 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15444 (HasElementType): Add our own implementation to work on every
15447 2005-02-11 Miguel de Icaza <miguel@novell.com>
15449 * anonymous.cs (CaptureContext): Track whether `this' has been
15452 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15453 only captured `this' if it was implicitly done (instance
15454 methods/variables were used).
15456 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15457 `this' must be captured.
15459 2005-01-30 Miguel de Icaza <miguel@novell.com>
15461 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15462 is null it means that there has been no need to capture anything,
15463 so we just create a sibling.
15465 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15467 Just a partial fix. The other half is fairly elusive.
15469 2005-02-10 Raja R Harinath <rharinath@novell.com>
15471 Fix #52586, cs0121-4.cs.
15472 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15473 and return a hashtable.
15474 (MemberCache.ClearDeclaredOnly): New.
15475 (MemberCache.MemberCache): Update to change. Make a deep copy of
15476 the method_hash of a base type too.
15477 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15478 type methods. Overwrite entries with the same MethodHandle so
15479 that the ReflectedType is correct. The process leaves in base
15480 virtual functions and their overrides as distinct entries.
15481 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15482 matters since it was boxed in a ArrayList before.
15483 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15485 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15486 case of a virtual function and its override (choose the overload
15488 (Invocation.OverloadResolve): Avoid 'override' members during
15489 'applicable_type' calculation.
15491 2005-02-09 Raja R Harinath <rharinath@novell.com>
15493 Combine two near-redundant caches.
15494 * typemanager.cs (method_params): Rename from method_internal_params.
15495 (TypeManager.GetParameterData): New. Replace
15496 Invocation.GetParameterData.
15497 (TypeManager.LookupParametersByBuilder): Remove.
15498 * expression.cs (Invocation.method_parameter_cache): Remove.
15499 (Invocation.GetParameterData): Remove.
15501 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15504 2005-02-08 Raja R Harinath <rharinath@novell.com>
15507 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15508 TypeManager.multicast_delegate_type is null, resolve it by looking
15509 up "System.MulticastDelegate".
15510 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15512 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15513 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15514 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15517 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15518 (LabeledStatement.AddReference): New. Set 'referenced'.
15519 (Goto.Resolve): Use it.
15521 2005-02-05 John Luke <john.luke@gmail.com>
15523 * driver.cs: remove duplicate -doc line in Usage ()
15525 2005-02-04 Raja R Harinath <rharinath@novell.com>
15527 * location.cs (Location.AddFile): Fix CS2002 error report.
15529 2005-02-02 Martin Baulig <martin@ximian.com>
15531 * delegate.cs (Delegate.DefineType): Report an internal error if
15532 TypeManager.multicast_delegate_type is null. See bug #72015 for
15535 2005-02-02 Raja R Harinath <rharinath@novell.com>
15537 Fix a crasher in a variant of #31984.
15538 * const.cs (Constant.CheckBase): New override that defers the
15539 new-or-override check in case the base type hasn't been populated
15541 (Constant.Define): Ensure the new-or-override check is performed.
15543 2005-02-01 Duncan Mak <duncan@ximian.com>
15545 * const.cs (LookupConstantValue): Check that `ce' is not null
15546 before calling GetValue ().
15548 2005-02-01 Raja R Harinath <rharinath@novell.com>
15550 Fix test-334.cs (#69519).
15551 * cs-parser.jay (using_alias_directive): Pass in an expression to
15552 NamespaceEntry.UsingAlias.
15553 (using_namespace_directive): Pass in an expression to
15554 NamespaceEntry.Using.
15555 (namespace_name): Don't flatten to a string.
15556 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15557 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15559 (NamespaceEntry.UsingEntry): Likewise.
15560 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15562 (NamespaceEntry.LookupForUsing): Remove.
15563 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15565 (NamespaceEntry.Lookup): Remove support for dotted names.
15567 2005-02-01 Raja R Harinath <rharinath@novell.com>
15569 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15571 (NamespaceEntry.ImplicitParent): Compute on demand.
15572 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15573 parallels the current.
15574 (NamespaceEntry.LookupForUsing): Use it.
15575 (NamespaceEntry.Lookup): If the current namespace-entry is
15576 implicit, don't search aliases and using tables.
15578 2005-02-01 Raja R Harinath <rharinath@novell.com>
15581 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15583 (TypeContainer.BaseCache): Compute on demand.
15584 (TypeContainer.FindMembers): Define constants and types if they're
15585 not already created.
15586 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15588 * const.cs (Constant.Define): Make idempotent.
15590 2005-01-29 Miguel de Icaza <miguel@novell.com>
15592 * pending.cs: Produce better code (no nops produced by using Ldarg
15595 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15596 i - 1' it should be arg + 1.
15600 2005-01-28 Raja R Harinath <rharinath@novell.com>
15602 * attribute.cs (Attribute.CheckAttributeType): Make private
15604 (Attribute.ResolveType): Make virtual.
15605 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15606 handling of RootContext.Tree.Types.
15608 2005-01-27 Raja R Harinath <rharinath@novell.com>
15610 Update attribute-handling to use the SimpleName/MemberAccess
15612 * cs-parser.jay (attribute): Pass in an expression to the
15613 constructors of Attribute and GlobalAttribute.
15614 * attribute.cs (Attribute): Take an expression for the name.
15615 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15616 passed in attribute name expression.
15617 (Attribute.CheckAttributeType): Use it.
15618 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15619 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15620 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15621 argument to prevent error messages if the lookup fails.
15623 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15625 * expression.cs (Indirection): Implemented IVariable interface
15626 to support indirection in AddressOf operator.
15627 (PointerArithmetic.Emit): Add optimalization for case where
15628 result can be precomputed.
15630 2005-01-26 Martin Baulig <martin@ximian.com>
15632 * class.cs (TypeContainer.AttributeTargets): Return the correct
15633 AttributeTargets depending on our `Kind' instead of throwing an
15634 exception; fixes #71632.
15636 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15639 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15642 2005-01-25 Raja R Harinath <rharinath@novell.com>
15645 * expression.cs (MemberAccess.DoResolve): Don't complain with
15646 cs0572 when the LHS of a member access has identical name and type
15649 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15652 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15654 Create custom PermissionSet only for PermissionSetAttribute.
15656 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15659 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15660 delegates in static class.
15662 2005-01-24 Martin Baulig <martin@ximian.com>
15664 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15665 merging an implicit block, just use its reachability.
15667 * statement.cs (Block.Resolve): Make the unreachable code check
15668 work wrt. implicit blocks; see test-337 from #63842.
15670 2005-01-21 Alp Toker <alp@atoker.com>
15672 * cs-parser.jay: destructor_declaration's container is PartialContainer
15673 not Class when partial types are used, so use Kind prop instead of
15676 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15678 * cs-parser.jay: Improve error reporting when an interface
15679 declares new types.
15681 2005-01-20 Dick Porter <dick@ximian.com>
15683 * support.cs: SeekableStreamReader fix from Sandor Dobos
15684 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15685 chars are read. Fixes bug 70369.
15687 2005-01-20 Raja R Harinath <rharinath@novell.com>
15689 * cs-parser.jay (catch_clause): Simplify current_block handling
15692 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15694 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15695 code with ImplicitStandardConversion to handle the implicit
15696 conversion of method groups into valid delegate invocations.
15698 The problem is that in parameter handling we were using this code
15699 path. Fixes bug #64698
15701 2005-01-19 Raja R Harinath <rharinath@novell.com>
15703 * cs-parser.jay: Fix several infelicities.
15704 - Avoid assigning to the parser value stack. Code like
15705 '$3 = null' is unclean. Synthesize a value for the code block
15707 - Avoid using oob_stack for storing location information. Use ...
15708 (_mark_): ... this. New (empty) rule. Saves the current location
15710 (foreach_statement): Avoid using oob_stack for current_block
15711 handling. Use technique used in for_statement and
15712 using_statement. Synthesize a value for the code block to store
15713 additional intermediate information.
15715 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15717 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15718 of a different type is only allowed to private fields of a
15719 containing type, not on fields of a base class.
15721 See test-174.cs and error cs0122-9.cs
15723 2005-01-13 Raja R Harinath <rharinath@novell.com>
15725 Fix test-335.cs (bug #58126).
15726 * cs-parser.jay (argument): Split out non-expression parts of the
15727 rule into 'non_simple_argument'.
15728 (invocation_expression): Support parenthesized invocations with
15729 multiple arguments, and with single non-simple arguments.
15731 2005-01-13 Raja R Harinath <rharinath@novell.com>
15733 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15736 2005-01-12 Raja R Harinath <rharinath@novell.com>
15738 Fix cs0038-1.cs, cs1640-6.cs.
15739 * ecore.cs (Expression.Resolve): Remove special-case for
15740 SimpleName in error-handling.
15741 (Expression.almostMatchedMembers): Relax access permission to
15743 (Expression.MemberLookupFailed): Handle duplicates in
15744 almostMatchedMembers list.
15745 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15746 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15747 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15748 overload if the passed in MemberInfo is a MethodBase.
15750 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15753 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15754 for non-CAS & merge permission sets properly.
15756 2005-01-11 Raja R Harinath <rharinath@novell.com>
15758 Improve standard-compliance of simple name and member access
15759 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15760 * ecore.cs (FullNamedExpression): New abstract base class
15761 for Namespaces and TypeExpressions.
15762 (ResolveFlags.SimpleName): Remove.
15763 (SimpleName): Remove support for dotted names.
15764 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15765 DeclSpace.FindType and DeclSpace.LookupType.
15766 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15767 (Expression.ExprClassName): Make member function.
15768 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15769 a namespace. Remove creation of dotted "SimpleName"s.
15770 (MemberAccess.DoResolve): Likewise.
15771 * decl.cs (DeclSpace.Cache): Make private.
15772 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15773 (DeclSpace.FindType): Update.
15774 (DeclSpace.LookupType): Move here from RootContext. Return a
15775 FullNamedExpression.
15776 * namespace.cs (Namespace): Derive from FullNamedExpression
15777 so that it can be part of expression resolution.
15778 (Namespace.Lookup): Return an FullNamedExpression.
15779 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15781 * rootcontext.cs (NamespaceLookup): Remove.
15782 (LookupType): Move to DeclSpace.
15783 * attribute.cs (CheckAttributeType): Update.
15784 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15785 (FindDocumentedTypeNonArray): Likewise.
15787 2005-01-11 Raja R Harinath <rharinath@novell.com>
15789 Fix cs0509.cs, cs1632.cs.
15790 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15791 is the same as IsInterface.
15792 (TypeContainer.GetClassBases): Likewise.
15793 * statement.cs (LabeledStatement.ig): New field.
15794 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15796 (LabeledStatement.DoEmit): Check that the label was created with
15797 the same ILGenerator.
15799 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15802 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15803 accessors to its properties.
15805 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15806 from accessors to property.
15808 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15811 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15812 only for overrides.
15814 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15816 * attribute.cs: Check for null and empty strings.
15818 I have lost another battle to Paolo.
15820 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15823 * class.cs (PropertyMethod): Set Parent field in ctors.
15824 (SetMethod.InternalParameters): Add unsafe switch hack.
15825 Override MarkForDuplicationCheck where it is appropriate.
15827 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15828 It says whether container allows members with the same name.
15829 Base default is no.
15830 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15831 Removed is_method parameter.
15833 2005-01-06 Duncan Mak <duncan@ximian.com>
15835 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15836 because the previous change led to incorrect reporting of CS1032
15837 ("Cannot define/undefine preprocessor symbols after first token in
15838 file"). Instead of using `tokens_seen' as the only flag that
15839 triggers CS1040, introduce `comments_seen'. This new flag is used
15840 to signify having seen comments on the current line, so it is
15841 unset after a newline.
15843 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15845 * doc.cs : When searching for a type, find nested type too.
15846 This fixes bug #71040.
15848 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15851 - Warn missing member comment on those classes which also does not
15852 have doc comments. Fixed bug #71041.
15853 - Don't warn missing doc comment on default constructor.
15856 2005-01-06 Duncan Mak <duncan@ximian.com>
15858 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15859 comments, set `tokens_seen' to true. This allows us to detect
15860 misplaced preprocessor directives (i.e. not at the beginning of
15861 the a line, nor after whitespaces). In that case, report error
15862 CS1040. This fixes bug #56460.
15864 * cs-parser.jay (interface_member_declaration): Add checks for
15865 IsExplicitImpl, and report CS0541 error if an interface member is
15866 defined as an explicit interface declaration.
15868 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15871 * class.cs (PropertyMethod): Set Parent field in ctors.
15872 (SetMethod.InternalParameters): Add unsafe switch hack.
15874 * decl.cs (MemberCore.Parent): Cannot be readonly.
15876 2005-01-06 Raja R Harinath <rharinath@novell.com>
15878 * decl.cs (DeclSpace.ResolveType): Remove.
15879 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15880 Merge in code from ...
15881 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15882 * class.cs, enum.cs: Update to changes.
15884 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15886 * anonymous.cs: Ensure that we init the scope of our parent if it
15887 has not been initialized yet.
15889 2004-12-30 Duncan Mak <duncan@ximian.com>
15891 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15892 if field.FieldBuilder is null. Fixes #70758.
15894 * convert.cs: Fixed some typos and updated some of the comments.
15895 (ImplicitStandardConversionExists):
15896 (TryImplicitIntConversion): If `target_type' is an interface and
15897 the type of `ic' implements this interface, return true or a new
15898 BoxedCast instead of null. This fixes #70468.
15900 2004-12-29 Duncan Mak <duncan@ximian.com>
15902 * expression.cs (Argument.Emit): Check that Expr is
15903 IMemoryLocation before casting to it, and report CS1510 otherwise.
15907 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15909 * statement.cs (Block.ThisVariable): remove the recursion here, to
15910 make the --profile more sane.
15912 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15914 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15915 assembly, by JB Evain.
15917 2004-12-17 Raja R Harinath <rharinath@novell.com>
15919 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15920 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15921 "parent" refers to enclosing type/class. "base" refers to superclass.
15923 2004-12-17 Raja R Harinath <rharinath@novell.com>
15925 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15926 Ensure that we only have GlobalAttributes.
15927 * attribute.cs (Attribute.Emit): Make non-virtual.
15928 (GlobalAttribute.Emit): Remove.
15929 (Attribute.Resolve): Make virtual.
15930 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15931 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15932 the argument. Don't create one.
15933 (Attribute.GetObsoleteAttribute): Likewise.
15934 (Attribute.GetClsCompliantAttributeValue): Likewise.
15935 * class.cs, decl.cs: Update to changes.
15937 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15939 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15941 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15943 * statement.cs (Foreach.Resolve): Add error 186 report.
15945 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15947 * expression.cs (Conditional.DoResolve): Add warning 429.
15949 * statement.cs (If.Resolve): Add warning 665.
15951 2004-12-16 Raja R Harinath <rharinath@novell.com>
15953 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15954 except when in the parser, and in GlobalAttribute.
15955 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15956 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15957 RootContext.Tree.Types.NamespaceEntry once work is done.
15958 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15959 and resets RootContext.Tree.Types.NamespaceEntry.
15961 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15963 * cs-parser.jay: Don't create a block for every variable.
15965 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15967 * location.cs: Provide extra information.
15969 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15970 variables from the captured environment, it is the ldarg_0.
15972 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15974 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15977 * class.cs: Changed warning level for 169 to avoid developer
15978 displeasure from warning flooding. It will be changed back when they
15979 fix most of current BCL warnings.
15981 * RootContext.cs: Pushed default WarningLevel to 3.
15983 * statement.cs: Removed unused variable.
15985 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15987 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15988 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15989 Add error 502 report.
15990 (StaticClass.DefineType): Add error 441 report.
15991 (Class.AllowedModifiersProp): New virtual property as temporary
15992 extension to AllowedModifiers.
15993 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15994 to share implementation with StaticClass and don't call virtual
15997 * driver.cs (MainDriver): Add error 1558 test.
15999 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
16000 report. Moved error 36 test here.
16002 * statement.cs (Throw.Resolve): Add error 724 report.
16004 * typemanager.cs: Add out_attribute_type core type.
16006 2004-12-13 Marek Safar <marek.safar@seznam.cz>
16008 * class.cs (TypeContainer.VerifyClsCompliance): Add error
16010 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
16012 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
16015 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
16017 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
16018 Add error 3023 report.
16019 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
16021 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
16024 2004-12-12 John Luke <john.luke@gmail.com>
16026 * driver.cs (AddArgs): take -- into account when
16027 adding arguments, fixes bug 65710
16029 2004-12-12 Martin Baulig <martin@ximian.com>
16031 * expression.cs (Unary.TryReduceNegative): Added support for
16032 SByteConstant and ByteConstant.
16033 (Unary.Reduce): Check error values from TryReduceNegative().
16035 2004-12-10 Marek Safar <marek.safar@seznam.cz>
16037 * attributes.cs (Attribute.Resolve): Avoid multiple error report
16038 and report exception as error 182.
16040 2004-12-10 Raja R Harinath <rharinath@novell.com>
16042 * driver.cs (Main): Fix message when there are warnings.
16044 2004-12-09 Miguel de Icaza <miguel@ximian.com>
16046 * delegate.cs: Fixed my fix from yesterday, sorry about that.
16048 2004-12-09 Marek Safar <marek.safar@seznam.cz>
16050 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
16051 Reduced number of warnings.
16053 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
16055 2004-12-08 Miguel de Icaza <miguel@ximian.com>
16057 * driver.cs: Removed message.
16059 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
16061 2004-12-08 <vargaz@freemail.hu>
16063 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
16065 2004-12-08 Martin Baulig <martin@ximian.com>
16067 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
16068 instead of a CS3002 for properties and indexer.
16070 2004-12-08 Martin Baulig <martin@ximian.com>
16072 * decl.cs (MemberName.ToString): Make this work again.
16074 2004-12-08 Marek Safar <marek.safar@seznam.cz>
16076 * attribute.cs (Resolve): Add error 591 detection.
16078 * class.cs (FieldMember.Define): Add error 1547 detection.
16079 (Indexer.Define): Add error 620 detection.
16080 (Operator.Define): Add error 590 detection.
16082 * ecore.cs: Missing argument for error 79.
16084 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
16087 2004-12-07 Marek Safar <marek.safar@seznam.cz>
16090 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
16093 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
16095 * cs-parser.jay : handle doc comments on implicit/explicit operators.
16096 Some operator comments were suppressed.
16097 * doc.cs : Implicit/explicit operator name in doc comments are like
16098 "op_Explicit(type)~returnType", so added suffix handling.
16100 2004-12-07 Martin Baulig <martin@ximian.com>
16103 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
16104 (MemberCore.GetClsCompliantAttributeValue): Likewise.
16105 (DeclSpace.ec): New protected field; store the EmitContext here.
16106 (DeclSpace.EmitContext): New public property; moved here from
16108 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
16111 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
16112 (Enum.Emit): Don't create a new EmitContext.
16114 * delegate.cs (Delegate.DefineType): Always create the
16117 * iterators.cs (Iterators.DefineIterator): Create a new
16118 EmitContext and store it in `ec'.
16120 2004-08-24 Martin Baulig <martin@ximian.com>
16123 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
16124 this for accessibility checks.
16125 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
16126 IsNestedFamilyAccessible.
16127 (TypeManager.IsSubclassOf): New method, do what the name actually
16130 2004-12-06 Raja R Harinath <rharinath@novell.com>
16132 Fix crash on cs0657-17.cs.
16133 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
16134 Use RootContext.Tree.Types, not 'new RootTypes ()'.
16135 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
16136 the case where the NamespaceEntry gets overwritten.
16138 2004-12-06 Marek Safar <marek.safar@seznam.cz>
16140 Fixed #69195, #56821
16141 * ecore.cs (ResolveBoolean): Tiny refactoring.
16143 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
16144 of right expression resolving when left is false constant and
16145 operator is LogicalAnd OR true constant and operator is LogicalOr.
16147 * statement.cs (ResolveUnreachable): Always reports warning.
16149 2004-12-05 Miguel de Icaza <miguel@ximian.com>
16151 * class.cs: Distinguish between 1721 and 1722 (just a little help
16152 for the programmer).
16154 2004-12-03 Miguel de Icaza <miguel@ximian.com>
16156 * delegate.cs: Only allow this on new versions of the language.
16158 2004-12-02 Duncan Mak <duncan@ximian.com>
16160 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
16162 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
16163 here as a static method. Take an additional bool out parameter
16164 `must_do_cs1540_check' for signaling to InstanceResolve.
16165 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
16166 member field from PropertyExpr class and made it an argument of
16167 the method instead.
16168 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
16169 check for MarshalByRefObject, and report CS0122 instead of CS1540.
16170 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
16171 and `remove_accessor' as well as InstanceResolve: report CS0122
16176 2004-12-03 Raja R Harinath <rharinath@novell.com>
16178 Fix test-327.cs, test-328.cs, and put in early infrastructure
16179 for eventually fixing #52697.
16180 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
16181 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
16182 from other methods.
16183 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
16184 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
16185 (VerifyUsing, error246): Update.
16186 * rootcontext.cs (RootContext.NamespaceLookup): Just use
16187 'NamespaceEntry.LookupNamespaceOrType'.
16189 2004-12-03 Martin Baulig <martin@ximian.com>
16191 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16192 method as our child, call AnonymousMethod.Compatible() on it.
16194 2004-12-03 Raja R Harinath <rharinath@novell.com>
16196 Disable XML documentation support in 'basic' profile.
16197 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
16198 Redirect XmlElement to System.Object.
16199 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
16200 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
16201 * mcs.exe.sources: Add doc-bootstrap.cs.
16202 * doc-bootstrap.cs: New file. Contains empty stub implementation
16205 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
16207 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
16208 comments are allowed.
16210 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16212 * delegate.cs: Add checks for subtypes in paramaters and return values
16213 in VerifyMethod () to add support for Covariance/Contravariance
16216 2004-12-02 Miguel de Icaza <miguel@ximian.com>
16218 * report.cs: Remove extra closing parenthesis.
16220 * convert.cs (Error_CannotImplicitConversion): If the name of the
16221 types are the same, provide some extra information.
16223 * class.cs (FieldBase): Use an unused bit field from the field to
16224 encode the `has_offset' property from the FieldMember. This saves
16225 a couple of Ks on bootstrap compilation.
16227 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16228 method as our child, return the AnonymousMethod resolved
16231 * expression.cs (New.DoResolve): Allow return values from
16232 NewDelegate to also include AnonymousMethods.
16236 2004-12-02 Marek Safar <marek.safar@seznam.cz>
16239 * attribute.cs (Resolve): Improved implementation of params
16240 attribute arguments.
16242 * support.cs (ParameterData): Add HasParams to be faster.
16244 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
16246 all things are for /doc support:
16248 * doc.cs: new file that supports XML documentation generation.
16249 * mcs.exe.sources: added doc.cs.
16251 Handle /doc command line option.
16252 Report error 2006 instead of 5 for missing file name for /doc.
16253 Generate XML documentation when required, after type resolution.
16255 Added support for picking up documentation (/// and /** ... */),
16256 including a new XmlCommentState enumeration.
16258 Added lines to fill Documentation element for field, constant,
16259 property, indexer, method, constructor, destructor, operator, event
16260 and class, struct, interface, delegate, enum.
16261 Added lines to warn incorrect comment.
16263 Added Documentation field (passed only when /doc was specified).
16265 Added DocComment, DocCommentHeader, GenerateDocComment() and
16266 OnGenerateDocComment() and some supporting private members for
16267 /doc feature to MemberCore.
16269 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16271 Added overriden DocCommentHeader.
16273 Added overriden DocCommentHeader and GenerateDocComment().
16275 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16277 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16278 unwrapping the enumeration values, chain to
16279 DoConstantNumericPromotions again, so we can promote things to the
16280 fundamental types (takes care of enums that are bytes, sbytes).
16284 2004-12-01 Raja R Harinath <rharinath@novell.com>
16286 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16287 Fix long-standing bug in type-lookup. Use FindType instead of
16288 LookupType when ec.ResolvingTypeTree.
16289 (Attribute.ResolveType, Attribute.Resolve)
16290 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16292 (Attributes.Search): Remove internal version. Update.
16293 (Attributes.SearchMulti): Update.
16294 (Attributes.GetClsCompliantAttribute): Remove.
16295 (Attributes.GetIndexerNameAttribute): Remove.
16296 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16297 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16298 * class.cs (Indexer.Define): Likewise.
16300 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16303 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16304 MarshallByReference members access.
16306 * expression.cs: Use CheckMarshallByRefAccess;
16307 Better error CS0197 message.
16309 * report.cs: Print whole related error message.
16311 2004-11-30 Raja R Harinath <rharinath@novell.com>
16313 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16314 the current directory to help debugging.
16316 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16318 * class (GetClassBases): Better error 60 report.
16319 (EventProperty): Disabled warning 67 detection.
16321 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16324 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16326 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16329 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16332 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16334 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16336 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16338 * attribute.cs (Attribute.Resolve): Refine error reporting and
16339 report a cs0117 if the identifier does not exist, to distinguish
16340 from 0617 which is a miss-use of the actual identifier.
16342 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16343 between cs0070 and cs0079.
16345 * class.cs (MemberBase.DoDefine): When reporting a wrong
16346 accessibility level, we use MethodCore to compare instead of
16347 Method (this was a regression in some refactoring effort).
16349 So now we correctly report cs0056 again.
16351 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16352 testing the target_type (which was known to be object_type) and
16353 not the source type (which is anonymous_method).
16355 Fixed reporting of error cs1660.
16357 * expression.cs (UserCast.Source): Expose the underlying cast.
16359 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16360 allowed types to find a match to int32 first (most common).
16362 In addition, it ignores any ImplicitUserConversions that did an
16363 internal implicit conversion (as the switch statement allows only
16364 one integral conversion to exist).
16366 * class.cs (PartialContainer.Create): rename `name' to
16367 `member_name' for clarity. Then replace the string calls with a
16368 call to MemberName.GetPartialName, as now using
16369 MemberName.ToString is an error (this is due to the side effects
16370 it had, that were fixed in the past).
16372 This will restore the error reporting on a number of partial class
16373 errors that were missusing this (and getting an exception as a
16374 results, which is now just a plain textual warning, because
16375 yyparse debug output would crash otherwise).
16377 2004-11-26 Raja R Harinath <rharinath@novell.com>
16379 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16381 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16383 * rootcontext.cs (LookupType): Make sure to cache lookups that
16384 don't give us a negative result. This saves about 5% of corlib
16387 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16389 * report.cs (AbstractMessage.Print): messages are sent to stderr
16391 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16392 non-interface in the list of interfaces (at this point, either
16393 parent was properly set, or a base class is being listed in the
16394 interfaces section).
16396 This flags error 1722, and resolves the crash from bug 69259.
16398 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16400 * statement.cs (Using.EmitExpressionFinally): make this work right
16401 for valuetypes. Fixes 69926.
16403 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16405 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16406 converted to an enum" here, before we try to change the underlying
16407 type. This code exists, but it is a different code path than the
16408 one used while encoding constants.
16410 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16411 old bug: when converting from the null literal to a pointer,
16412 return an EmptyCast, not the NullLiteral.
16414 This fixes #69921, the recent null_type changes probably made this
16415 bug more prominent.
16417 (ImplicitReferenceConversionExists): In addition, resynchronized
16418 the code here, so it matches the same code in
16419 ImplicitReferenceConversionExists for the `from any class-type S
16420 to any interface-type T'.
16423 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16425 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16427 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16429 * cs-parser.jay: Use verbosity accordingly.
16431 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16433 * expression.cs (Unary.ResolveOperator): Do not report warning;
16434 AddressOf reads from variable.
16436 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16438 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16442 * attribute.cs (Attributable): Removed CheckTargets.
16443 (Attributes.Emit): Explicit attribute targets are tested here.
16445 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16446 not enabled for interfaces.
16448 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16449 (GetAssemblyName): Ouch next bug there.
16451 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16453 * expression.cs: Error 275 added.
16455 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16457 Fix bug #69177 (Implemented decimal constant support)
16459 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16460 (BinaryFold): Add DecimalConstant.
16462 * const.cs (Define): Decimal constant
16464 (ChangeType): Add decimal type handling.
16465 (LookupConstantValue): Don't set value for decimal type but
16466 emit DecimalConstantAttribute. Needed for constant optimization.
16468 * constant.cs (ToDecimal): New method.
16469 (ConvertToDecimal): New method.
16470 (IntConstant): Implemented ConvertToDecimal.
16471 (DecimalConstant.Emit): Emit optimized version for decimals in
16474 * expression.cs (ResolveOperator): Changed order of constant
16475 reduction to work correctly with native types which have
16476 overloaded operators.
16477 (ResolveMemberAccess): Extract constant value from attribute
16480 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16482 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16483 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16484 (ChangeType): Decimal is special.
16485 (TypeToCoreType): Add decimal type.
16487 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16489 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16492 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16494 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16497 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16499 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16501 * pending.cs (PendingImplementation): Grab only interfaces.
16503 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16505 * statement.cs (ForeachHelperMethods): Add location member and
16506 error 202 detection.
16508 2004-11-19 Raja R Harinath <rharinath@novell.com>
16510 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16511 automatically handled by executable.make.
16512 (PROGRAM): Make profile-specific.
16514 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16516 * expression.cs (DoResolveBase): Fixed wrong warning for out
16519 2004-11-18 Martin Baulig <martin@ximian.com>
16521 Merged latest changes into gmcs. Please keep this comment in
16522 here, it makes it easier for me to see what changed in MCS since
16523 the last time I merged.
16525 2004-11-17 Raja R Harinath <rharinath@novell.com>
16527 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16528 (TypeHandle.GetMemberCache): New.
16529 (TypeHandle.TypeHandle): Update.
16530 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16531 (TypeManager.LookupParentInterfacesCache):
16532 Rename from LookupInterfaceCache. Optimize slightly.
16533 (TypeManager.MemberLookup_FindMembers): Update.
16534 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16535 multi-type variant.
16536 (AddCacheContents): Rename from AddHashtable.
16537 * class.cs (TypeContainer.parent_container): Remove.
16538 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16539 (TypeContainer.DoDefineMembers): Don't initialize it.
16540 Update to name changes.
16542 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16544 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16545 that factors the code to check access modifiers on override.
16547 (PropertyBase): Use the code here.
16549 Patch from Lluis S'anchez, fixes bug #69361.
16551 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16553 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16554 routine that is used to report the use of a captured variable
16555 whose address has been taken.
16557 There are two checks: one when variables are being captured and
16558 the other check is when the address of a variable is taken.
16560 (because an anonymous methods might be resolved before *or* after
16561 the address has been taken) and
16563 * expression.cs (Conditional.DoResolve): Remove the special
16564 casing that Martin added to trueExpr and falseExpr being both
16565 NullLiteral. We get the right behavior now just by introducing
16566 the null_type into the compiler.
16568 * convert.cs (ExplicitConversion): Change the code to use
16569 null_type instead of testing `expr is NullLiteral'.
16570 (ImplicitConversionStandard): use null_type too.
16571 (ImplicitReferenceConversionExists): use null_type too.
16572 (ImplicitReferenceConversion): use null_type too.
16574 * literal.cs: The type of `NullLiteral' is now null_type instead
16576 (Resolve): Set the type here.
16578 * typemanager.cs: Introduce null_type.
16580 2004-11-17 Martin Baulig <martin@ximian.com>
16582 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16583 direction, like FindMembers() does. Fixes #69546, testcase is in
16586 2004-11-16 Martin Baulig <martin@ximian.com>
16588 This is based on a patch from Marek Safar, see bug #69082.
16589 Fixes bugs #63705 and #67130.
16591 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16592 method; create a MemberCache for an interface type and cache the
16595 * decl.cs (IMemberContainer.ParentContainer): Removed.
16596 (IMemberContainer.ParentCache): New property.
16597 (MemberCache.SetupCacheForInterface): Removed.
16598 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16599 to create a cache for an interface's "parent".
16601 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16604 2004-11-16 Martin Baulig <martin@ximian.com>
16606 Merged back from gmcs; these changes already went into gmcs a
16607 couple of weeks ago.
16610 (TypeManager.AddUserType): Removed the `ifaces' argument.
16611 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16613 (TypeManager.AddUserInterface): Removed.
16614 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16616 (TypeManager.GetInterfaces): Likewise.
16617 (TypeManager.GetExplicitInterfaces): Likewise.
16619 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16621 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16622 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16624 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16626 * statement.cs: Avoid adding bools to a hashtable.
16628 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16630 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16631 calling an unsafe method from a safe location.
16633 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16636 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16638 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16640 * namespace.cs (VerifyUsing): use GetPartialName instead of
16643 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16645 * statement.cs (Return.Resolve): Fix regression in typo: if
16646 `in_exc', we have to request a NeedReturnLabel, this was a typo
16647 introduced in the anonymous method check-in. Fixes #69131.
16649 * Indexers were using the ShortName when defining themselves,
16650 causing a regression in the compiler bootstrap when applying the
16651 patch from 2004-11-02 (first part), now they use their full name
16652 and the bug is gone.
16654 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16656 * driver.cs: Strip the path from the names of embedded resources. Fixes
16659 2004-11-04 Raja R Harinath <rharinath@novell.com>
16661 Fix error message regression: cs0104-2.cs.
16662 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16663 (AliasEntry.Resolve): Update.
16664 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16666 (RootContext.LookupType): Update.
16668 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16670 * cs-parser.jay: Add support for handling accessor modifiers
16671 * class: Add support port accessor modifiers and error checking,
16672 define PropertyMethod.Define as virtual (not abstract anymore)
16673 * ecore.cs: Add checking for proeprties access with access modifiers
16674 * iterators.cs: Modify Accessor constructor call based in the modified
16676 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16678 * expression.cs (StringConcat): Handle being called twice,
16679 as when we have a concat in a field init with more than two
16682 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16684 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16685 special case explicit implementations, we should always produce
16686 the .property or .event declaration.
16688 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16689 since it will not return correct data if people use this
16690 unresolved in the presence of using statements (see test-313).
16692 * class.cs (MethodData.Define): If we are an explicit interface
16693 implementation, set the method name to the full name of the
16694 interface plus the name of the method.
16696 Notice that using the method.MethodName.GetFullName() does not
16697 work, as it will only contain the name as declared on the source
16698 file (it can be a shorthand in the presence of using statements)
16699 and not the fully qualifed type name, for example:
16703 class D : ICloneable {
16704 object ICloneable.Clone () {
16708 Would produce a method called `ICloneable.Clone' instead of
16709 `System.ICloneable.Clone'.
16711 * namespace.cs (Alias.Resolve): Use GetPartialName.
16713 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16715 * cs-parser.jay: Add error 1055 report.
16717 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16719 * assign.cs (Assign.DoResolve): Only do the transform of
16720 assignment into a New if the types are compatible, if not, fall
16721 through and let the implicit code deal with the errors and with
16722 the necessary conversions.
16724 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16726 * cs-parser.jay: Add error 1031 report.
16728 * cs-tokenizer.cs: Add location for error 1038.
16730 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16732 * cs-parser.jay: Add error 1016 report.
16734 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16736 * cs-parser.jay: Add errors 1575,1611 report.
16738 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16740 * cs-parser.jay: Add error 1001 report.
16742 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16745 * attribute.cs (GetMarshal): Add method argument for
16746 caller identification.
16748 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16749 agument for GetMarshal and RuntimeMissingSupport.
16751 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16753 * attribute.cs (ExtractSecurityPermissionSet): Removed
16754 TypeManager.code_access_permission_type.
16756 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16758 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16760 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16761 for obsolete use of a variable here. Fixes regression on errors
16762 cs0619-25 and cs0619-26.
16764 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16766 Fix #62358, implemented security attribute encoding.
16768 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16769 Tests permitted SecurityAction for assembly or other types.
16770 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16771 data from SecurityPermissionAttribute to PermisionSet class.
16773 * class.cs (ApplyAttributeBuilder): Added special handling
16774 for System.Security.Permissions.SecurityAttribute based types.
16776 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16777 special handling for System.Security.Permissions.SecurityAttribute
16780 * enum.cs (ApplyAttributeBuilder): Added special handling
16781 for System.Security.Permissions.SecurityAttribute based types.
16783 * parameter.cs (ApplyAttributeBuilder): Added special handling
16784 for System.Security.Permissions.SecurityAttribute based types.
16786 * rootcontext.cs: Next 2 core types.
16788 * typemanager.cs (TypeManager.security_permission_attr_type):
16789 Built in type for the SecurityPermission Attribute.
16790 (code_access_permission_type): Build in type.
16792 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16794 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16795 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16796 all of this information into
16797 EmitContext.EmitCapturedVariableInstance.
16799 * codegen.cs (EmitCapturedVariableInstance): move here the
16800 funcionality of emitting an ldarg.0 in the presence of a
16801 remapping. This centralizes the instance emit code.
16803 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16804 then emit a load of this: it means that we have reached the
16805 topmost ScopeInfo: the one that contains the pointer to the
16806 instance of the class hosting the anonymous method.
16808 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16809 captures to the topmost CaptureContext.
16811 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16813 * expression.cs (LocalVariableReference): Move the knowledge about
16814 the iterators into codegen's EmitCapturedVariableInstance.
16816 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16818 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16819 all code paths return a value from an anonymous method (it is the
16820 same as the 161 error, but for anonymous methods).
16822 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16824 The introduction of anonymous methods in the compiler changed
16825 various ways of doing things in the compiler. The most
16826 significant one is the hard split between the resolution phase
16827 and the emission phases of the compiler.
16829 For instance, routines that referenced local variables no
16830 longer can safely create temporary variables during the
16831 resolution phase: they must do so from the emission phase,
16832 since the variable might have been "captured", hence access to
16833 it can not be done with the local-variable operations from the runtime.
16837 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16838 is a toplevel block.
16840 (ToplevelBlock): A new kind of Block, these are the blocks that
16841 are created by the parser for all toplevel method bodies. These
16842 include methods, accessors and anonymous methods.
16844 These contain some extra information not found in regular blocks:
16845 A pointer to an optional CaptureContext (for tracking captured
16846 local variables and parameters). A pointer to the parent
16849 (Return.Resolve): Catch missmatches when returning a value from an
16850 anonymous method (error 1662).
16851 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16854 (Break.Resolve): ditto.
16856 (SwitchLabel): instead of defining the labels during the
16857 resolution phase, we now turned the public ILLabel and ILLabelCode
16858 labels into methods called GetILLabelCode() and GetILLabel() that
16859 only define the label during the Emit phase.
16861 (GotoCase): Track the SwitchLabel instead of the computed label
16862 (its contained therein). Emit the code by using
16863 SwitchLabel.GetILLabelCode ().
16865 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16866 whether the Local has been captured or not.
16868 (LocalInfo.IsCaptured): New property, used to tell whether the
16869 local has been captured.
16871 * anonymous.cs: Vastly updated to contain the anonymous method
16874 The main classes here are: CaptureContext which tracks any
16875 captured information for a toplevel block and ScopeInfo used to
16876 track the activation frames for various local variables.
16878 Each toplevel block has an optional capture context associated
16879 with it. When a method contains an anonymous method both the
16880 toplevel method and the anonymous method will create a capture
16881 context. When variables or parameters are captured, they are
16882 recorded on the CaptureContext that owns them, for example:
16886 MyDelegate d = delegate {
16891 Here `a' will be recorded as captured on the toplevel
16892 CapturedContext, the inner captured context will not have anything
16893 (it will only have data if local variables or parameters from it
16894 are captured in a nested anonymous method.
16896 The ScopeInfo is used to track the activation frames for local
16897 variables, for example:
16899 for (int i = 0; i < 10; i++)
16900 for (int j = 0; j < 10; j++){
16901 MyDelegate d = delegate {
16906 At runtime this captures a single captured variable `i', but it
16907 captures 10 different versions of the variable `j'. The variable
16908 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16909 recorded on a child.
16911 The toplevel ScopeInfo will also track information like the `this'
16912 pointer if instance variables were referenced (this is necessary
16913 as the anonymous method lives inside a nested class in the host
16914 type of the method).
16916 (AnonymousMethod): Expanded to track the Toplevel, implement
16917 `AnonymousMethod.Compatible' to tell whether an anonymous method
16918 can be converted to a target delegate type.
16920 The routine now also produces the anonymous method content
16922 (AnonymousDelegate): A helper class that derives from
16923 DelegateCreation, this is used to generate the code necessary to
16924 produce the delegate for the anonymous method that was created.
16926 * assign.cs: API adjustments for new changes in
16927 Convert.ImplicitStandardConversionExists.
16929 * class.cs: Adjustments to cope with the fact that now toplevel
16930 blocks are of type `ToplevelBlock'.
16932 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16933 insteda of standard blocks.
16935 Flag errors if params arguments are passed to anonymous methods.
16937 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16938 `CurrentAnonymousMethod' which points to the current Anonymous
16939 Method. The variable points to the AnonymousMethod class that
16940 holds the code being compiled. It is set in the new EmitContext
16941 created for the anonymous method.
16943 (EmitContext.Phase): Introduce a variable and an enumeration to
16944 assist in enforcing some rules about when and where we are allowed
16945 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16946 only one that enfonces this right now).
16948 (EmitContext.HaveCaptureInfo): new helper method that returns
16949 whether we have a CapturedContext initialized.
16951 (EmitContext.CaptureVariable): New method used to register that a
16952 LocalInfo must be flagged for capturing.
16954 (EmitContext.CapturedParameter): New method used to register that a
16955 parameters must be flagged for capturing.
16957 (EmitContext.CapturedField): New method used to register that a
16958 field must be flagged for capturing.
16960 (EmitContext.HaveCapturedVariables,
16961 EmitContext.HaveCapturedFields): Return whether there are captured
16962 variables or fields.
16964 (EmitContext.EmitMethodHostInstance): This is used to emit the
16965 instance for the anonymous method. The instance might be null
16966 (static methods), this (for anonymous methods that capture nothing
16967 and happen to live side-by-side with the current method body) or a
16968 more complicated expression if the method has a CaptureContext.
16970 (EmitContext.EmitTopBlock): Routine that drives the emission of
16971 code: it will first resolve the top block, then emit any metadata
16972 and then emit the code. The split is done so that we can extract
16973 any anonymous methods and flag any captured variables/parameters.
16975 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16976 during this phase, the ILGenerator should not be used as labels
16977 and local variables declared here might not be accessible to any
16978 code that is part of an anonymous method.
16980 Exceptions to this include the temporary variables that are
16981 created by some statements internally for holding temporary
16984 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16987 (EmitContext.TemporaryReturn): This method is typically called
16988 from the Emit phase, and its the only place where we allow the
16989 ReturnLabel to be defined other than the EmitMeta. The reason is
16990 that otherwise we would have to duplicate a lot of logic in the
16991 Resolve phases of various methods that today is on the Emit
16994 (EmitContext.NeedReturnLabel): This no longer creates the label,
16995 as the ILGenerator is not valid during the resolve phase.
16997 (EmitContext.EmitThis): Extended the knowledge in this class to
16998 work in anonymous methods in addition to iterators.
17000 (EmitContext.EmitCapturedVariableInstance): This emits whatever
17001 code is necessary on the stack to access the instance to a local
17002 variable (the variable will be accessed as a field).
17004 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
17005 EmitContext.EmitAddressOfParameter): Routines to support
17006 parameters (not completed at this point).
17008 Removals: Removed RemapLocal and RemapLocalLValue. We probably
17009 will also remove the parameters.
17011 * convert.cs (Convert): Define a `ConstantEC' which points to a
17012 null. This is just to prefity some code that uses
17013 ImplicitStandardConversion code and do not have an EmitContext
17016 The idea is to flag explicitly that at that point in time, it is
17017 known that the conversion will not trigger the delegate checking
17018 code in implicit conversions (which requires a valid
17021 Everywhere: pass new EmitContext parameter since
17022 ImplicitStandardConversionExists now requires it to check for
17023 anonymous method conversions.
17025 (Convert.ImplicitStandardConversionExists): If the type of an
17026 expression is the anonymous_method_type, and the type is a
17027 delegate, we invoke the AnonymousMethod.Compatible method to check
17028 whether an implicit conversion is possible.
17030 (Convert.ImplicitConversionStandard): Only do implicit method
17031 group conversions if the language level is not ISO_1.
17033 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
17034 MethodInfo for the Invoke method. used by Delegate and
17037 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
17038 method conversions if the target type is a delegate.
17040 Removed extra debugging nops.
17042 (LocalVariableReference): Turn the `local_info' into a public
17045 Add `prepared' field, the same hack used for FieldExprs to cope
17046 with composed assignments, as Local variables do not necessarily
17047 operate purely on the stack as they used to: they can be captured
17050 Add `temp' for a temporary result, like fields.
17052 Refactor DoResolve and DoResolveLValue into DoResolveBase.
17054 It now copes with Local variables that are captured and emits the
17055 proper instance variable to load it from a field in the captured
17058 (ParameterReference.DoResolveBase): During the resolve phase,
17059 capture parameters if we are in an anonymous method.
17061 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
17062 anonymous method, use the EmitContext helper routines to emit the
17063 parameter reference.
17065 * iterators.cs: Set RemapToProxy to true/false during the
17068 * parameters.cs (GetParameterByName): New helper method.
17070 * typemanager.cs (anonymous_method_type) a new type that
17071 represents an anonyous method. This is always an internal type,
17072 used as a fencepost to test against the anonymous-methodness of an
17075 2004-10-20 Marek Safar <marek.safar@seznam.cz>
17077 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
17079 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
17081 2004-10-18 Martin Baulig <martin@ximian.com>
17083 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
17084 `Type' directly, but call ResolveType() on it.
17085 (Catch.Resolve): Likewise.
17086 (Foreach.Resolve): Likewise.
17088 2004-10-18 Martin Baulig <martin@ximian.com>
17090 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
17091 `Type' directly, but call ResolveType() on it.
17092 (Probe.DoResolve): Likewise.
17093 (ArrayCreation.LookupType): Likewise.
17094 (TypeOf.DoResolve): Likewise.
17095 (SizeOf.DoResolve): Likewise.
17097 2004-10-18 Martin Baulig <martin@ximian.com>
17099 * expression.cs (Invocation.BetterFunction): Put back
17100 TypeManager.TypeToCoreType().
17102 2004-10-18 Raja R Harinath <rharinath@novell.com>
17104 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
17107 2004-10-18 Martin Baulig <martin@ximian.com>
17109 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
17110 `Type' directly, but call ResolveType() on it.
17112 2004-10-18 Martin Baulig <martin@ximian.com>
17114 * class.cs (FieldMember.Define): Don't access the TypeExpr's
17115 `Type' directly, but call ResolveType() on it.
17116 (MemberBase.DoDefine): Likewise.
17118 * expression.cs (New.DoResolve): Don't access the TypeExpr's
17119 `Type' directly, but call ResolveType() on it.
17120 (ComposedCast.DoResolveAsTypeStep): Likewise.
17122 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
17123 `Type' directly, but call ResolveType() on it.
17125 2004-10-17 John Luke <john.luke@gmail.com>
17127 * class.cs (Operator.GetSignatureForError): use CSharpName
17129 * parameter.cs (Parameter.GetSignatureForError): Returns
17130 correct name even if was not defined.
17132 2004-10-13 Raja R Harinath <rharinath@novell.com>
17135 * class.cs (TypeContainer.EmitContext): New property.
17136 (DefineNestedTypes): Create an emitcontext for each part.
17137 (MethodCore.DoDefineParameters): Use container's emitcontext.
17138 Pass type array to InternalParameters.
17139 (MemberBase.DoDefine): Use container's emitcontext.
17140 (FieldMember.Define): Likewise.
17141 (Event.Define): Likewise.
17142 (SetMethod.GetParameterInfo): Change argument to EmitContext.
17143 Pass type array to InternalParameters.
17144 (SetIndexerMethod.GetParameterInfo): Likewise.
17145 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
17146 * delegate.cs (Define): Pass emitcontext to
17147 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
17148 array to InternalParameters.
17149 * expression.cs (ParameterReference.DoResolveBase): Pass
17150 emitcontext to GetParameterInfo.
17151 (ComposedCast.DoResolveAsTypeStep): Remove check on
17152 ec.ResolvingTypeTree.
17153 * parameter.cs (Parameter.Resolve): Change argument to
17154 EmitContext. Use ResolveAsTypeTerminal.
17155 (Parameter.GetSignature): Change argument to EmitContext.
17156 (Parameters.ComputeSignature): Likewise.
17157 (Parameters.ComputeParameterTypes): Likewise.
17158 (Parameters.GetParameterInfo): Likewise.
17159 (Parameters.ComputeAndDefineParameterTypes): Likewise.
17160 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
17161 * support.cs (InternalParameters..ctor): Remove variant that takes
17163 * typemanager.cs (system_intptr_expr): New.
17164 (InitExpressionTypes): Initialize it.
17166 2004-10-12 Chris Toshok <toshok@ximian.com>
17168 * cs-parser.jay: fix location for try_statement and catch_clause.
17170 2004-10-11 Martin Baulig <martin@ximian.com>
17172 * report.cs: Don't make --fatal abort on warnings, we have
17173 -warnaserror for that.
17175 2004-10-07 Raja R Harinath <rharinath@novell.com>
17177 More DeclSpace.ResolveType avoidance.
17178 * decl.cs (MemberCore.InUnsafe): New property.
17179 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
17180 with newly created EmitContext.
17181 (FieldMember.Define): Likewise.
17182 * delegate.cs (Delegate.Define): Likewise.
17183 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
17184 only if normal name-lookup fails.
17185 (TypeExpr.DoResolve): Enable error-checking.
17186 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
17187 (SizeOf.DoResolve): Likewise.
17188 (ComposedCast.DoResolveAsTypeStep): Likewise.
17189 (StackAlloc.DoResolve): Likewise.
17190 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
17191 (Block.Unsafe): New property.
17192 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
17193 (Unsafe): Set 'unsafe' flag of contained block.
17194 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
17195 (Fixed.Resolve): Likewise.
17196 (Catch.Resolve): Likewise.
17197 (Using.ResolveLocalVariableDecls): Likewise.
17198 (Foreach.Resolve): Likewise.
17200 2004-10-05 John Luke <john.luke@gmail.com>
17202 * cs-parser.jay: add location to error CS0175
17204 2004-10-04 Miguel de Icaza <miguel@ximian.com>
17206 * ecore.cs (Expression.Constantity): Add support for turning null
17209 * const.cs (Const.Define): Allow constants to be reference types
17210 as long as the value is Null.
17212 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
17214 * namespace.cs (NamespaceEntry.Using): No matter which warning
17215 level is set, check if this namespace name has already been added.
17217 2004-10-03 Ben Maurer <bmaurer@ximian.com>
17219 * expression.cs: reftype [!=]= null should always use br[true,false].
17222 2004-10-03 Marek Safar <marek.safar@seznam.cz>
17225 * attribute.cs: Enum conversion moved to
17226 GetAttributeArgumentExpression to be applied to the all
17229 2004-10-01 Raja R Harinath <rharinath@novell.com>
17231 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
17232 * class.c (TypeContainer.DefineType): Flag error if
17233 base types aren't accessible due to access permissions.
17234 * decl.cs (DeclSpace.ResolveType): Move logic to
17235 Expression.ResolveAsTypeTerminal.
17236 (DeclSpace.ResolveTypeExpr): Thin layer over
17237 Expression.ResolveAsTypeTerminal.
17238 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
17239 Refactor code into NestedAccess. Use it.
17240 (DeclSpace.NestedAccess): New.
17241 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
17242 argument to silence errors. Check access permissions.
17243 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
17244 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
17245 (Cast.DoResolve): Likewise.
17246 (New.DoResolve): Likewise.
17247 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
17248 (TypeOf.DoResolve): Likewise.
17250 * expression.cs (Invocation.BetterConversion): Return the Type of
17251 the better conversion. Implement section 14.4.2.3 more faithfully.
17252 (Invocation.BetterFunction): Make boolean. Make correspondence to
17253 section 14.4.2.2 explicit.
17254 (Invocation.OverloadResolve): Update.
17255 (Invocation): Remove is_base field.
17256 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
17257 (Invocation.Emit): Likewise.
17259 2004-09-27 Raja R Harinath <rharinath@novell.com>
17261 * README: Update to changes.
17263 2004-09-24 Marek Safar <marek.safar@seznam.cz>
17265 * cs-parser.jay: Reverted 642 warning fix.
17267 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17270 * decl.cs (FindMemberWithSameName): Indexer can have more than
17273 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17275 * expression.cs (LocalVariableReference.DoResolveLValue):
17276 Do not report warning 219 for out values.
17277 (EmptyExpression.Null): New member to avoid extra allocations.
17279 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17281 * cs-parser.jay: Fix wrong warning 642 report.
17283 * cs-tokenizer.cs (CheckNextToken): New helper;
17284 Inspect next character if is same as expected.
17286 2004-09-23 Martin Baulig <martin@ximian.com>
17288 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17289 (Convert.ImplicitReferenceConversionExists): Likewise.
17291 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17293 * class.cs (Operator.Define): Add error 448 and 559 report.
17295 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17297 * class.cs (MemberBase.IsTypePermitted): New protected
17298 method for checking error CS0610.
17300 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17302 * class.cs (TypeContainer.HasExplicitLayout): New property
17303 Returns whether container has StructLayout attribute set Explicit.
17304 (FieldMember): New abstract class for consts and fields.
17305 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17306 (Field): Reuse FieldMember.
17308 * const.cs (Const): Reuse FieldMember.
17310 * rootcontext.cs: EmitConstants call moved to class.
17312 2004-09-22 Martin Baulig <martin@ximian.com>
17314 Thanks to Peter Sestoft for this bug report.
17316 * expression.cs (Conditional): If both the `trueExpr' and the
17317 `falseExpr' is a NullLiteral, return a NullLiteral.
17319 2004-09-22 Martin Baulig <martin@ximian.com>
17321 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17322 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17323 for the "get_Current" call.
17325 2004-09-22 Martin Baulig <martin@ximian.com>
17327 Marek and me just fixed one of our oldest bugs: #28562 :-)
17329 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17331 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17332 we're an EnumConstant, just return that.
17333 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17334 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17335 to get the value which'll actually be written into the attribute.
17336 However, we have to use GetValue() to access the attribute's value
17339 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17341 * constant.cs (Constant.IsNegative): New abstract property
17344 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17345 (StackAlloc.DoResolve): Reused IsNegative.
17347 2004-09-21 Martin Baulig <martin@ximian.com>
17349 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17350 if we're used in an iterator, we may be called from different
17353 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17354 we actually have an exception block.
17356 2004-09-20 John Luke <jluke@cfl.rr.com>
17358 * class.cs, cs-parser.jay: Improve the error report for 1520:
17359 report the actual line where the error happens, not where the
17360 class was declared.
17362 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17363 Pass location information that was available elsewhere.
17365 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17367 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17368 runtime to delay sign assemblies.
17370 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17372 * cs-parser.jay: Do not report the stack trace, this is barely
17375 2004-08-22 John Luke <john.luke@gmail.com>
17377 * driver.cs : check that a resource id is not already used
17378 before adding it, report CS1508 if it is, bug #63637
17380 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17382 * ecore.cs: Removed dead code.
17384 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17386 * class.cs: Do not report warning CS0067 on the interfaces.
17388 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17390 * cs-parser.jay: Add error 504 report.
17392 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17394 * rootcontext.cs: WarningLevel is 4 by default now.
17396 * statement.cs (Fixed.Resolve): Do not null
17399 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17402 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17403 deep search when property is not virtual.
17404 (PropertyExpr.ResolveAccessors): Make one call for both
17407 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17410 * statement.cs: Error 152 report constains also location.
17412 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17415 * const.cs: Explicitly set constant as static.
17417 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17420 * cs-parser.jay: Add error 1017 report.
17422 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17424 Fixed bug #59980, #64224
17425 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17427 * typemanager.cs (IsSpecialMethod): Simplified
17429 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17431 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17432 condition with better params.
17434 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17437 * attribute.cs (Resolve): Property has to have both
17440 2004-09-14 Martin Baulig <martin@ximian.com>
17442 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17444 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17447 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17448 called and is obsolete then this member suppress message
17449 when call is inside next [Obsolete] method or type.
17451 * expression.cs: Use TestObsoleteMethodUsage member.
17453 2004-09-14 Martin Baulig <martin@ximian.com>
17455 * cs-parser.jay: Sync a bit with the GMCS version.
17457 2004-09-14 Martin Baulig <martin@ximian.com>
17459 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17460 (CSharpParser.yacc_verbose_flag): New public field.
17462 * genericparser.cs: Removed.
17464 2004-09-14 Raja R Harinath <rharinath@novell.com>
17466 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17468 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17470 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17472 2004-09-10 Martin Baulig <martin@ximian.com>
17474 Backported my MemberName changes from GMCS into MCS.
17476 - we are now using a special `MemberName' class instead of using
17477 strings; in GMCS, the `MemberName' also contains the type
17480 - changed the grammar rules a bit:
17481 * the old `member_name' is now a `namespace_or_type_name':
17482 The rule is that we use `namespace_or_type_name' everywhere
17483 where we expect either a "member name" (GetEnumerator) or a
17484 "member name" with an explicit interface name
17485 (IEnumerable.GetEnumerator).
17486 In GMCS, the explicit interface name may include type arguments
17487 (IEnumerable<T>.GetEnumerator).
17488 * we use `member_name' instead of just `IDENTIFIER' for
17490 The rule is that we use `member_name' wherever a member may
17491 have type parameters in GMCS.
17493 * decl.cs (MemberName): New public class.
17494 (MemberCore.MemberName): New public readonly field.
17495 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17496 (DeclSpace): Likewise.
17498 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17499 * enum.cs (Enum.ctor): Likewise.
17501 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17503 (AliasEntry.ctor): Take a MemberName, not an Expression.
17504 (AliasEntry.UsingAlias): Likewise.
17506 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17507 (IMethodData.MemberName): Changed type from string to MemberName.
17508 (MemberBase.ExplicitInterfaceName): Likewise.
17509 (AbstractPropertyEventMethod.SetupName): Make this private.
17510 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17511 argument; compute the member name here.
17512 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17513 on the `member.MemberName' and the `prefix'.
17515 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17517 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17518 thus, we get a `MemberName' instead of a `string'. These
17519 declarations may have type parameters in GMCS.
17520 (interface_method_declaration, delegate_declaration): Likewise.
17521 (class_declaration, interface_declaration): Likewise.
17522 (method_header): Use `namespace_or_type_name' instead of
17523 `member_name'. We may be an explicit interface implementation.
17524 (property_declaration, event_declaration): Likewise.
17525 (member_name): This is now just an `IDENTIFIER', not a
17526 `namespace_or_type_name'.
17527 (type_name, interface_type): Removed.
17528 (namespace_or_type_name): Return a MemberName, not an Expression.
17529 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17530 call GetTypeExpression() on the MemberName to get an expression.
17531 (IndexerDeclaration.interface_type): Changed type from string to
17533 (MakeName): Operate on MemberName's instead of string's.
17535 2004-09-13 Raja R Harinath <rharinath@novell.com>
17538 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17539 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17540 lookup to avoid symbols introduced by 'using'.
17541 * rootcontext.cs (NamespaceLookup): Update.
17543 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17545 * class.cs (TypeContainer.DoDefineMembers): Do not call
17546 DefineDefaultConstructor for static classes.
17548 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17550 * attribute.cs (Attribute.Resolve): Add error 653 report.
17552 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17554 (Method.ApplyAttributeBuilder): Add error 685 report.
17555 (Operator.Define): Add error 564 report.
17557 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17559 * expression.cs (Invocation.DoResolve): Add error
17560 245 and 250 report.
17562 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17565 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17567 * class.cs (ConstructorInitializer.Resolve):
17568 Wrong error number (515->516).
17570 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17572 * class.cs (Indexer.Define): Add error 631 report.
17574 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17576 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17578 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17580 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17582 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17584 * cs-parser.jay: Added error CS0241 report.
17586 2004-09-10 Raja R Harinath <rharinath@novell.com>
17588 * cs-parser.jay (fixed_statement): Introduce a scope for the
17589 declaration in the 'fixed' statement.
17591 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17593 * cs-parser.jay: Added CS0230 error report.
17595 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17597 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17599 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17601 * expression.cs (Argument.Resolve): Added error CS0192 and
17604 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17606 C# 2.0 #pragma warning feature
17608 * cs-tokenizer.cs (PreProcessPragma): New method;
17609 Handles #pragma directive.
17611 * report.cs (WarningRegions): New class; Support
17612 class for #pragma warning directive. It tests whether
17613 warning is enabled for a given line.
17615 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17617 * const.cs: Add more descriptive error report, tahnks to
17620 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17622 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17624 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17626 * expression.cs: Apply patch from Ben: Remove dead code from
17627 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17628 as that code just threw an exception anwyays.
17630 * const.cs: Remove the call to the turnintoconstant, for details
17633 * literal.cs: The type of the null-literal is the null type; So
17634 we use a placeholder type (literal.cs:System.Null, defined here)
17637 * expression.cs (Conditional.DoResolve): Remove some old code that
17638 is no longer needed, conversions have been fixed.
17640 (ArrayCreationExpression.DoResolve): Return false if we fail to
17641 resolve the inner expression.
17643 2004-09-07 Raja R Harinath <rharinath@novell.com>
17646 * cs-parser.jay (delegate_declaration): Record a delegate
17647 declaration as a type declaration.
17648 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17650 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17652 * parameter.cs: Do not crash if the type can not be resolved.
17654 * expression.cs: Report errors with unsafe pointers, fixes #64896
17656 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17658 * expression.cs: Pointer arith always needs to do a conv.i
17659 if the operand is a long. fix 65320
17661 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17663 Fixed cs0619-37.cs, cs0619-38.cs
17665 * enum.cs (GetObsoleteAttribute): Removed.
17667 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17668 on Enum member is double staged. The first is tested member
17671 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17673 Fixed #56986, #63631, #65231
17675 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17676 adds member to name container.
17677 (TypeContainer.AddToTypeContainer): New method, adds type to
17679 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17680 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17681 AddOperator): Simplified by reusing AddToMemberContainer.
17682 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17684 (Method.CheckForDuplications): Fixed implementation to test all
17686 (MemberBase): Detection whether member is explicit interface
17687 implementation is now in constructor.
17688 (MemberBase.UpdateMemberName): Handles IndexerName.
17689 (Accessor): Changed to keep also location information.
17690 (AbstractPropertyEventMethod): Is derived from MemberCore.
17691 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17692 will be emited or not.
17693 (PropertyBase.AreAccessorsDuplicateImplementation):
17694 Tests whether accessors are not in collision with some method.
17695 (Operator): Is derived from MethodCore to simplify common
17698 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17700 (DeclSpace.AddToContainer): Adds the member to defined_names
17701 table. It tests for duplications and enclosing name conflicts.
17703 * enum.cs (EnumMember): Clean up to reuse the base structures
17705 2004-09-03 Martin Baulig <martin@ximian.com>
17707 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17708 into TypeContainer, to make partial classes work again.
17710 2004-09-03 Martin Baulig <martin@ximian.com>
17712 * rootcontext.cs (RootContext.V2): Removed.
17714 2004-03-23 Martin Baulig <martin@ximian.com>
17716 * expression.cs (Invocation.OverloadResolve): Added `bool
17717 may_fail' argument and use it instead of the Location.IsNull() hack.
17719 2004-09-03 Martin Baulig <martin@ximian.com>
17721 Merged latest changes into gmcs. Please keep this comment in
17722 here, it makes it easier for me to see what changed in MCS since
17723 the last time I merged.
17725 2004-09-03 Raja R Harinath <rharinath@novell.com>
17728 * expression.cs (BetterConversion): Don't allow either conversion
17729 to be null. Remove redundant implicit conversion test when 'q ==
17730 null' -- when this function is invoked, we already know that the
17731 implicit conversion exists.
17732 (BetterFunction): Assume that 'best' is non-null. Remove
17733 redundant reimplementation of IsApplicable when 'best' is null.
17734 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17735 number of arguments.
17736 (IsAncestralType): Extract from OverloadResolve.
17737 (OverloadResolve): Make robust to the MethodGroupExpr being
17738 unsorted. Implement all the logic of Section 14.5.5.1, and
17739 support overloading of methods from multiple applicable types.
17740 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17742 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17743 (RealError, Warning): Append type of report to related symbol.
17745 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17747 * enum.cs: Fixed CLS-Compliance checks for enum members.
17748 Error tests cs3008-8.cs, cs3014-8.cs
17750 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17752 Fixed bug #62342, #63102
17753 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17754 like ImplementMethod.
17756 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17758 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17761 2004-09-02 Martin Baulig <martin@ximian.com>
17763 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17764 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17767 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17769 C# 2.0 Static classes implemented
17771 * class.cs (TypeContainer): instance_constructors,
17772 initialized_fields, initialized_static_fields,
17773 default_constructor, base_inteface_types are protected to be
17774 accessible from StaticClass.
17775 (TypeContainer.DefineDefaultConstructor): New virtual method
17776 for custom default constructor generating
17777 (StaticClass): New class to handle "Static classes" feature.
17779 * cs-parser.jay: Handle static keyword on class like instance
17782 * driver.cs: Added "/langversion" command line switch with two
17783 options (iso-1, default).
17785 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17787 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17789 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17791 * delegate.cs: Style.
17793 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17795 * delegate.cs: Add seperate instance expr field for miguel.
17797 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17799 * PointerArithmetic (Resolve): make sure we are not doing
17800 pointer arith on void*. Also, make sure we are resolved
17801 by not setting eclass until resolve.
17803 All callers: Make sure that PointerArithmetic gets resolved.
17805 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17807 * ArrayCreation (LookupType): If the type does not resolve
17808 to an array, give an error.
17810 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17812 * statement.cs (Try.Resolve): Fixed bug #64222
17814 2004-08-27 Martin Baulig <martin@ximian.com>
17817 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17820 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17822 * ecore.cs (Constantify): Get underlying type via
17823 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17824 Windows in special cases.
17826 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17828 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17829 for obtaining also private methods.
17830 (GetRemoveMethod): Used GetRemoveMethod (true)
17831 for obtaining also private methods.
17833 2004-08-24 Martin Baulig <martin@ximian.com>
17835 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17836 MethodAttributes.HideBySig for operators.
17838 2004-08-23 Martin Baulig <martin@ximian.com>
17840 Back to the old error reporting system :-)
17842 * report.cs (Message): Removed.
17843 (Report.MessageData, ErrorData, WarningData): Removed.
17844 (Report.Error, Warning): Back to the old system.
17846 2004-08-23 Martin Baulig <martin@ximian.com>
17848 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17850 * class.cs (TypeContainer.ParentContainer): New public virtual
17851 method; replaces the explicit interface implementation.
17852 (ClassPart.ParentContainer): Override.
17854 2004-08-23 Martin Baulig <martin@ximian.com>
17856 * statement.cs (Switch): Added support for constant switches; see
17857 #59428 or test-285.cs.
17859 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17862 * statement.cs (GetEnumeratorFilter): Removed useless
17863 logic because C# specs is strict. GetEnumerator must be
17866 2004-08-22 Martin Baulig <martin@ximian.com>
17868 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17869 a switch and may break, reset the barrier. Fixes #59867.
17871 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17873 CLS-Compliance speed up (~5% for corlib)
17875 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17876 New method. Tests container for CLS-Compliant names
17878 * class.cs (TypeContainer.VerifyClsName): New method.
17879 Checks whether container name is CLS Compliant.
17880 (Constructor): Implements IMethodData.
17882 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17883 low-case table for CLS Compliance test.
17884 (MemberCache.VerifyClsParameterConflict): New method.
17885 Checks method parameters for CS3006 error.
17887 * enum.cs (EnumMember): Is derived from MemberCore.
17888 (Enum.VerifyClsName): Optimized for better performance.
17890 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17892 * report.cs: Renamed Error_T to Error and changed all
17895 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17897 * class.cs (TypeContainer.IndexerArrayList): New inner class
17898 container for indexers.
17899 (TypeContainer.DefaultIndexerName): New constant for default
17900 indexer name. Replaced all "Item" with this constant.
17901 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17903 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17904 DefaultMemberAttribute constructor.
17906 2004-08-05 Martin Baulig <martin@ximian.com>
17908 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17911 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17913 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17914 multi platforms problem.
17916 * compiler.csproj: Included shared files.
17918 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17920 Fix bug 60333, 55971 in the more general way
17921 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17922 Added arg_type argument for constant conversion.
17923 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17925 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17928 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17929 OperatorArrayList, MethodCoreArrayList for typecontainer
17930 containers. Changed class member types to these new types.
17931 (MethodArrayList.DefineMembers): Added test for CS0659.
17933 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17935 * cfold.cs: Synchronize the folding with the code in expression.cs
17936 Binary.DoNumericPromotions for uint operands.
17938 * attribute.cs: Revert patch from Raja, it introduced a regression
17939 while building Blam-1.2.1 (hard to isolate a test case).
17941 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17945 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17947 (MethodCore.parent_method): New member. The method we're overriding
17948 if this is an override method.
17949 (MethodCore.CheckBase): Moved from Method class and made common.
17950 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17952 (MethodCore.CheckForDuplications): New abstract method. For custom
17953 member duplication search in a container
17954 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17955 method and its return type.
17956 (Event.conflict_symbol): New member. Symbol with same name in the
17960 (MemberCache.FindMemberWithSameName): New method. The method
17961 is looking for conflict with inherited symbols.
17963 2004-08-04 Martin Baulig <martin@ximian.com>
17965 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17967 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17969 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17971 * report.cs (Message): New enum for better error, warning reference in
17973 (MessageData): New inner abstract class. It generally handles printing of
17974 error and warning messages.
17975 Removed unused Error, Warning, Message methods.
17977 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17979 Fix for cs0592-8.cs test
17981 (Attributable.ValidAttributeTargets): Made public.
17982 (Attribute.ExplicitTarget): New member for explicit target value.
17983 (Attribute.CheckTargets): Now we translate explicit attribute
17984 target to Target here.
17986 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17988 * ecore.cs (MethodGroupExpr): new IsBase property.
17990 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17992 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17993 rather than an instance expr.
17995 (DelegateCreation.Emit): Use the method group rather than
17996 the instance expression. Also, if you have base.Foo as the
17997 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17999 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
18001 (NewDelegate.DoResolve): Only check for the existance of Invoke
18002 if the method is going to be needed. Use MethodGroupExpr.
18004 (NewDelegate.Emit): Remove, DelegateCreation implements this.
18006 * expression.cs: For pointer arith., make sure to use
18007 the size of the type, not the size of the pointer to
18010 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18013 * class.cs (Class): Added error CS0502 test.
18015 2004-08-03 John Luke <jluke@cfl.rr.com>
18016 Raja R Harinath <rharinath@novell.com>
18019 * attribute.cs (Attribute.complained_before): New flag.
18020 (Attribute.ResolveType, Attribute.Resolve),
18021 (Attribute.DefinePInvokeMethod): Set it.
18022 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
18024 2004-08-03 Martin Baulig <martin@ximian.com>
18026 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
18027 use a user-defined operator; we still need to do numeric
18028 promotions in case one argument is a builtin type and the other
18029 one has an implicit conversion to that type. Fixes #62322.
18031 2004-08-02 Martin Baulig <martin@ximian.com>
18033 * statement.cs (LocalInfo.Flags): Added `IsThis'.
18034 (LocalInfo.IsThis): New public property.
18035 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
18037 2004-08-01 Martin Baulig <martin@ximian.com>
18039 * class.cs (TypeContainer.GetClassBases): Don't set the default
18040 here since we may get called from GetPartialBases().
18041 (TypeContainer.DefineType): If GetClassBases() didn't return a
18042 parent, use the default one.
18044 2004-07-30 Duncan Mak <duncan@ximian.com>
18046 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
18048 2004-07-30 Martin Baulig <martin@ximian.com>
18050 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
18052 * class.cs (SourceMethod): New public class, derive from the
18053 symbol writer's ISourceMethod.
18054 (Method): Use the new symbol writer API.
18056 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
18057 as argument and use the new symbol writer.
18060 (SourceFile): Implement the symbol writer's ISourceFile.
18061 (Location.SymbolDocument): Removed.
18062 (Location.SourceFile): New public property.
18064 * symbolwriter.cs: Use the new symbol writer API.
18066 2004-07-30 Raja R Harinath <rharinath@novell.com>
18068 * Makefile (install-local): Remove. Functionality moved to
18071 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
18073 * Makefile: Install mcs.exe.config file together with mcs.exe.
18074 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
18075 correct runtime version.
18077 2004-07-25 Martin Baulig <martin@ximian.com>
18080 (TypeContainer.RegisterOrder): Removed, this was unused.
18081 (TypeContainer, interface_order): Removed.
18082 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
18083 TypeContainer as argument since we can also be called with a
18084 `PartialContainer' for a partial class/struct/interface.
18085 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
18086 of checking whether we're an `Interface' - we could be a
18087 `PartialContainer'.
18088 (PartialContainer.Register): Override; call
18089 AddClass()/AddStruct()/AddInterface() on our parent.
18091 * cs-parser.jay (interface_member_declaration): Add things to the
18092 `current_container', not the `current_class'.
18094 * rootcontext.cs (RegisterOrder): The overloaded version which
18095 takes an `Interface' was unused, removed.
18097 * typemanager.cs (TypeManager.LookupInterface): Return a
18098 `TypeContainer', not an `Interface'.
18099 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
18100 contain a `PartialContainer' for an interface, so check it's
18101 `Kind' to figure out what it is.
18103 2004-07-25 Martin Baulig <martin@ximian.com>
18105 * class.cs (Class.DefaultTypeAttributes): New public constant.
18106 (Struct.DefaultTypeAttributes): Likewise.
18107 (Interface.DefaultTypeAttributes): Likewise.
18108 (PartialContainer.TypeAttr): Override this and add the
18109 DefaultTypeAttributes.
18111 2004-07-25 Martin Baulig <martin@ximian.com>
18113 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
18114 we can just use the `Parent' field instead.
18116 2004-07-25 Martin Baulig <martin@ximian.com>
18118 * class.cs (TypeContainer.Emit): Renamed to EmitType().
18120 2004-07-25 Martin Baulig <martin@ximian.com>
18122 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
18123 our parts before defining any methods.
18124 (TypeContainer.VerifyImplements): Make this virtual.
18125 (ClassPart.VerifyImplements): Override and call VerifyImplements()
18126 on our PartialContainer.
18128 2004-07-25 Martin Baulig <martin@ximian.com>
18130 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
18132 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
18133 argument, we can just use the `Parent' field instead.
18136 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
18137 (MemberBase.DoDefine): Likewise.
18139 2004-07-24 Martin Baulig <martin@ximian.com>
18141 * decl.cs (MemberCore.Parent): New public field.
18142 (DeclSpace.Parent): Moved to MemberCore.
18144 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
18145 (MemberBase.ctor): Added TypeContainer argument, pass it to our
18147 (FieldBase, Field, Operator): Likewise.
18148 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
18149 (EventField, Event): Likewise.
18151 2004-07-23 Martin Baulig <martin@ximian.com>
18153 * class.cs (PartialContainer): New public class.
18154 (ClassPart): New public class.
18155 (TypeContainer): Added support for partial classes.
18156 (TypeContainer.GetClassBases): Splitted some of the functionality
18157 out into GetNormalBases() and GetPartialBases().
18159 * cs-tokenizer.cs (Token.PARTIAL): New token.
18160 (Tokenizer.consume_identifier): Added some hacks to recognize
18161 `partial', but only if it's immediately followed by `class',
18162 `struct' or `interface'.
18164 * cs-parser.jay: Added support for partial clases.
18166 2004-07-23 Martin Baulig <martin@ximian.com>
18168 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
18169 a `DeclSpace' and also made it readonly.
18170 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
18171 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
18172 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
18174 * cs-parser.jay: Pass the `current_class', not the
18175 `current_container' (at the moment, this is still the same thing)
18176 to a new Method, Property, Event, Indexer or Constructor.
18178 2004-07-23 Martin Baulig <martin@ximian.com>
18180 * cs-parser.jay (CSharpParser): Added a new `current_class' field
18181 and removed the `current_interface' one.
18182 (struct_declaration, class_declaration, interface_declaration):
18183 Set `current_class' to the newly created class/struct/interface;
18184 set their `Bases' and call Register() before parsing their body.
18186 2004-07-23 Martin Baulig <martin@ximian.com>
18188 * class.cs (Kind): New public enum.
18189 (TypeContainer): Made this class abstract.
18190 (TypeContainer.Kind): New public readonly field.
18191 (TypeContainer.CheckDef): New public method; moved here from
18193 (TypeContainer.Register): New public abstract method.
18194 (TypeContainer.GetPendingImplementations): New public abstract
18196 (TypeContainer.GetClassBases): Removed the `is_class' and
18197 `is_iface' parameters.
18198 (TypeContainer.DefineNestedTypes): Formerly known as
18200 (ClassOrStruct): Made this class abstract.
18202 * tree.cs (RootTypes): New public type.
18204 2004-07-20 Martin Baulig <martin@ximian.com>
18206 * tree.cs (Tree.RecordNamespace): Removed.
18207 (Tree.Namespaces): Removed.
18209 * rootcontext.cs (RootContext.IsNamespace): Removed.
18211 * cs-parser.jay (namespace_declaration): Just create a new
18212 NamespaceEntry here.
18214 2004-07-20 Martin Baulig <martin@ximian.com>
18216 * statement.cs (ExceptionStatement): New abstract class. This is
18217 now used as a base class for everyone who's using `finally'.
18218 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
18219 our local variables before using them.
18221 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
18222 virtual method. This is used by Yield.Resolve() to "steal" an
18223 outer block's `finally' clauses.
18224 (FlowBranchingException): The .ctor now takes an ExceptionStatement
18227 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
18228 version which takes an ExceptionStatement. This version must be
18229 used to create exception branchings.
18232 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
18233 (Iterator.EmitMoveNext): Added exception support; protect the
18234 block with a `fault' clause, properly handle 'finally' clauses.
18235 (Iterator.EmitDispose): Run all the `finally' clauses here.
18237 2004-07-20 Martin Baulig <martin@ximian.com>
18239 * iterator.cs: This is the first of a set of changes in the
18240 iterator code. Match the spec more closely: if we're an
18241 IEnumerable, then GetEnumerator() must be called. The first time
18242 GetEnumerator() is called, it returns the current instance; all
18243 subsequent invocations (if any) must create a copy.
18245 2004-07-19 Miguel de Icaza <miguel@ximian.com>
18247 * expression.cs: Resolve the constant expression before returning
18250 2004-07-19 Martin Baulig <martin@ximian.com>
18252 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
18253 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
18254 the return type of the new EmitContext.
18256 2004-07-18 Martin Baulig <martin@ximian.com>
18258 * class.cs (Property.Define): Fix iterators.
18260 * iterators.cs (Iterator.Define): Moved the
18261 `container.AddInterator (this)' call here from the .ctor; only do
18262 it if we resolved successfully.
18264 2004-07-17 Miguel de Icaza <miguel@ximian.com>
18266 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
18267 `true' for preprocessing directives that we parse. The return
18268 value indicates whether we should return to regular tokenizing or
18269 not, not whether it was parsed successfully.
18271 In the past if we were in: #if false ... #line #endif, we would
18272 resume parsing after `#line'. See bug 61604.
18274 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18275 building: IsEnumType should return true only for enums, not for
18276 enums or System.Enum itself. This fixes #61593.
18278 Likely what happened is that corlib was wrong: mcs depended on
18279 this bug in some places. The bug got fixed, we had to add the
18280 hack, which caused bug 61593.
18282 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18283 that was a workaround for the older conditions.
18285 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18287 * assign.cs: IAssignMethod has a new interface, as documented
18288 inline. All assignment code now uses this new api.
18290 * ecore.cs, expression.cs: All classes which implement
18291 IAssignMethod now use the new interface.
18293 * expression.cs (Invocation): add a hack to EmitCall so that
18294 IndexerAccess can be the target of a compound assignment without
18295 evaluating its arguments twice.
18297 * statement.cs: Handle changes in Invocation api.
18299 2004-07-16 Martin Baulig <martin@ximian.com>
18301 * iterators.cs: Rewrote this. We're now using one single Proxy
18302 class for both the IEnumerable and the IEnumerator interface and
18303 `Iterator' derives from Class so we can use the high-level API.
18305 * class.cs (TypeContainer.AddIterator): New method.
18306 (TypeContainer.DoDefineType): New protected virtual method, which
18307 is called from DefineType().
18308 (TypeContainer.DoDefineMembers): Call DefineType() and
18309 DefineMembers() on all our iterators.
18310 (TypeContainer.Emit): Call Emit() on all our iterators.
18311 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18313 * codegen.cs (EmitContext.CurrentIterator): New public field.
18315 2004-07-15 Martin Baulig <martin@ximian.com>
18318 (TypeManager.not_supported_exception_type): New type.
18320 2004-07-14 Martin Baulig <martin@ximian.com>
18322 * iterators.cs: Use real error numbers.
18324 2004-07-14 Martin Baulig <martin@ximian.com>
18326 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18327 requires this to be a System.Collection.IEnumerable and not a
18328 class implementing that interface.
18329 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18331 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18333 * class.cs: Fixed previous fix, it broke some error tests.
18335 2004-07-12 Martin Baulig <martin@ximian.com>
18337 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18340 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18342 * assign.cs (LocalTemporary): Add new argument: is_address,If
18343 `is_address' is true, then the value that we store is the address
18344 to the real value, and not the value itself.
18346 * ecore.cs (PropertyExpr): use the new local temporary
18347 stuff to allow us to handle X.Y += z (where X is a struct)
18349 2004-07-08 Martin Baulig <martin@ximian.com>
18351 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18352 not always return, just like we're doing in Using.Resolve().
18354 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18356 * cs-parser.jay (fixed_statement): flag this as Pinned.
18358 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18360 * typemanager.cs (TypeManager): Removed MakePinned method, this
18361 mechanism is replaced with the .NET 2.x compatible mechanism of
18362 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18364 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18365 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18366 `IsFixed' property which has a different meaning.
18368 2004-07-02 Raja R Harinath <rharinath@novell.com>
18370 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18371 visible from inside a nested class, not just the names of the
18372 immediately enclosing class.
18373 Fix for bug #60730.
18375 2004-06-24 Raja R Harinath <rharinath@novell.com>
18377 * expression.cs (BetterConversion): Remove buggy special-case
18378 handling of "implicit constant expression conversions". At this
18379 point, we already know that the conversion is possible -- we're
18380 only checking to see which is better.
18382 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18384 * cs-parser.jay: Added error CS0210 test.
18386 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18388 * cs-parser.jay: Added error CS0134 test.
18390 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18393 * cs-parser.jay: Added error CS0145 test.
18395 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18397 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18399 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18401 * expression.cs (StackAlloc.Resolve): The argument may not
18402 be a constant; deal with this case.
18404 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18406 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18407 GetIndexerAttributeValue.
18408 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18410 * class.cs (Indexer.Define): Added error tests for CS0415,
18413 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18415 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18418 2004-06-23 Martin Baulig <martin@ximian.com>
18420 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18421 neither return nor throw, reset the barrier as well. Fixes #60457.
18423 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18425 * class.cs : EventAttributes is now set to None by default.
18426 This fixes bug #60459.
18428 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18431 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18432 Don't throw exception but return null (it's sufficient now).
18434 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18436 * typemanager.cs (GetArgumentTypes): Faster implementation.
18438 2004-06-18 Martin Baulig <martin@ximian.com>
18440 * attribute.cs (Attribute.Resolve): Check whether we're an
18441 EmptyCast which a Constant child. Fixes #60333.
18443 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18445 * statement.cs (EmitCollectionForeach): Account for the fact that
18446 not all valuetypes are in areas which we can take the address of.
18447 For these variables, we store to a temporary variable. Also, make
18448 sure that we dont emit a `callvirt' on a valuetype method.
18450 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18452 * expression.cs (StackAlloc.DoReSolve): Added test for
18453 negative parameter (CS0247).
18455 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18458 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18460 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18463 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18466 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18468 Fix bug #58254 & cs1555.cs, cs1556.cs
18469 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18471 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18473 * cs-parser.jay: Added error CS1669 test for indexers.
18475 2004-06-11 Martin Baulig <martin@ximian.com>
18477 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18478 call this twice: for params and varargs methods.
18480 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18483 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18485 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18487 * attribute.cs (Attribute.GetValidTargets): Made public.
18490 (AbstractPropertyEventMethod): New class for better code sharing.
18491 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18493 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18495 2004-06-11 Raja R Harinath <rharinath@novell.com>
18498 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18499 that the call to Resolve is part of a MemberAccess.
18500 (Expression.Resolve): Use it for SimpleName resolution.
18501 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18502 Add 'intermediate' boolean argument.
18503 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18504 error message when the SimpleName can be resolved ambiguously
18505 between an expression and a type.
18506 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18508 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18509 call on the left-side.
18511 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18514 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18516 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18518 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18520 2004-06-11 Martin Baulig <martin@ximian.com>
18522 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18523 varargs methods if applicable.
18525 2004-06-11 Martin Baulig <martin@ximian.com>
18527 * expression.cs (Invocation.EmitCall): Don't use
18528 `method.CallingConvention == CallingConventions.VarArgs' since the
18529 method could also have `CallingConventions.HasThis'.
18531 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18533 * class.cs (Event.GetSignatureForError): Implemented.
18534 Fixed crash in error test cs3010.cs
18536 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18538 * cs-tokenizer.cs: Change the way we track __arglist to be
18539 consistent with the other keywords.
18541 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18543 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18546 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18548 * codegen.cs: Check that all referenced assemblies have a strongname
18549 before strongnaming the compiled assembly. If not report error CS1577.
18550 Fix bug #56563. Patch by Jackson Harper.
18551 * typemanager.cs: Added a method to return all referenced assemblies.
18552 Fix bug #56563. Patch by Jackson Harper.
18554 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18557 (Method.ApplyAttributeBuilder): Moved and added conditional
18558 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18561 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18563 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18566 * class.cs: (EventField.attribute_targets): Changed default target.
18568 2004-06-08 Martin Baulig <martin@ximian.com>
18570 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18572 2004-06-08 Martin Baulig <martin@ximian.com>
18574 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18576 2004-06-07 Martin Baulig <martin@ximian.com>
18578 Added support for varargs methods.
18580 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18583 * cs-parser.jay: Added support for `__arglist'.
18585 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18587 * expression.cs (Argument.AType): Added `ArgList'.
18588 (Invocation): Added support for varargs methods.
18589 (ArglistAccess): New public class.
18590 (Arglist): New public class.
18592 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18594 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18595 a method's top-level block if the method has varargs.
18597 * support.cs (ReflectionParameters, InternalParameters): Added
18598 support for varargs methods.
18600 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18602 * class.cs: Provide location in indexer error report.
18604 * driver.cs: Use standard names.
18606 * namespace.cs: Catch the use of using after a namespace has been
18607 declared also on using aliases.
18609 2004-06-03 Raja R Harinath <rharinath@novell.com>
18612 * typemanager.cs (closure_private_ok, closure_invocation_type)
18613 (closure_qualifier_type, closure_invocation_assembly)
18614 (FilterWithClosure): Move to ...
18615 (Closure): New internal nested class.
18616 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18617 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18618 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18619 (MemberLookup, MemberLookupFailed): Use it.
18620 * expression.cs (New.DoResolve): Treat the lookup for the
18621 constructor as being qualified by the 'new'ed type.
18622 (Indexers.GetIndexersForTypeOrInterface): Update.
18624 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18627 (GetConditionalAttributeValue): New method. Returns
18628 condition of ConditionalAttribute.
18629 (SearchMulti): New method. Returns all attributes of type 't'.
18630 Use it when attribute is AllowMultiple = true.
18631 (IsConditionalMethodExcluded): New method.
18634 (Method.IsExcluded): Implemented. Returns true if method has conditional
18635 attribute and the conditions is not defined (method is excluded).
18636 (IMethodData): Extended interface for ConditionalAttribute support.
18637 (PropertyMethod.IsExcluded): Implemented.
18640 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18643 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18646 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18648 * expression.cs (ArrayCreationExpression): Make this just an
18649 `expression'. It can't be a statement, so the code here was
18652 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18655 * typemanager.cs (GetFullNameSignature): New method for
18658 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18661 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18662 Use this method when MethodBuilder is null.
18663 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18664 Added test for error CS0626 (MONO reports error for this situation).
18665 (IMethodData.GetSignatureForError): Extended interface.
18667 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18670 (AttributeTester.GetObsoleteAttribute): Returns instance of
18671 ObsoleteAttribute when type is obsolete.
18674 (TypeContainer.VerifyObsoleteAttribute): Override.
18675 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18676 (MethodCode.VerifyObsoleteAttribute): Override.
18677 (MemberBase.VerifyObsoleteAttribute): Override.
18680 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18681 and report proper error.
18684 Delegate.VerifyObsoleteAttribute): Override.
18687 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18688 and report proper error.
18689 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18692 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18696 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18697 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18698 Added test for ObsoleteAttribute.
18701 (Catch): Derived from Statement.
18703 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18705 Fixed bug #59071 & cs0160.cs
18707 * statement.cs (Try.Resolve): Check here whether order of catch
18708 clauses matches their dependencies.
18710 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18712 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18713 caused a regression: #59343. Referencing nested classes from an
18714 assembly stopped working.
18716 2004-05-31 Martin Baulig <martin@ximian.com>
18718 MCS is now frozen for beta 2.
18720 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18722 * convert.cs: add a trivial cache for overload operator resolution.
18724 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18726 * decl.cs: If possible, use lookuptypedirect here. We can only do
18727 this if there is no `.' after the namespace. Avoids using
18728 LookupType, which does lots of slow processing.
18729 (FindNestedType) New method, does what it says :-).
18730 * namespace.cs: use LookupTypeDirect.
18731 * rootcontext.cs: use membercache, if possible.
18732 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18734 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18737 According to the spec,
18739 In a member access of the form E.I, if E is a single identifier,
18740 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18741 field, property, localvariable, or parameter with the same type as
18742 the meaning of E as a type-name (§3.8), then both possible
18743 meanings of E are permitted.
18745 We did not check that E as a simple-name had the same type as E as
18748 This trivial check gives us 5-7% on bootstrap time.
18750 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18752 * expression.cs (Invocation.OverloadResolve): Avoid the
18753 use of hashtables and boxing here by allocating on demand.
18755 2004-05-30 Martin Baulig <martin@ximian.com>
18757 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18758 we're doing a silent lookup. Don't try to lookup nested types in
18759 TypeManager.object_type (thanks to Ben Maurer).
18761 2004-05-30 Martin Baulig <martin@ximian.com>
18763 Committing a patch from Ben Maurer.
18765 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18767 2004-05-29 Martin Baulig <martin@ximian.com>
18769 * class.cs (IMethodData.ShouldIgnore): New method.
18771 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18772 `Location' argument, we don't need it anywhere. Use
18773 `IMethodData.ShouldIgnore ()' instead of
18774 `MethodData.GetMethodFlags ()'.
18775 (TypeManager.AddMethod): Removed.
18776 (TypeManager.AddMethod2): Renamed to AddMethod.
18778 2004-05-29 Martin Baulig <martin@ximian.com>
18780 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18782 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18783 converting from a class type S to an interface type and we already
18784 have an object on the stack, don't box it again. Fixes #52578.
18786 2004-05-29 Martin Baulig <martin@ximian.com>
18788 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18789 Added support for `params' parameters. Fixes #59267.
18791 2004-05-29 Martin Baulig <martin@ximian.com>
18793 * literal.cs (NullPointer): Provide a private .ctor which sets
18794 `type' to TypeManager.object_type. Fixes #59048.
18796 2004-05-29 Martin Baulig <martin@ximian.com>
18798 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18799 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18801 * ecore.cs (EventExpr.instance_expr): Make the field private.
18803 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18805 Fixed bug #50080 & cs0214-2.cs
18806 * expression.cs (Cast.DoResolve): Check unsafe context here.
18808 * statement.cs (Resolve.DoResolve): Likewise.
18810 2004-05-26 Martin Baulig <martin@ximian.com>
18812 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18814 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18815 (RootContext.LookupType): Pass down the `silent' flag.
18817 2004-05-25 Martin Baulig <martin@ximian.com>
18820 (MethodGroupExpr.IdenticalTypeName): New public property.
18821 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18822 expression actually refers to a type.
18824 2004-05-25 Martin Baulig <martin@ximian.com>
18826 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18827 for #56176 and made it actually work.
18829 2004-05-25 Martin Baulig <martin@ximian.com>
18831 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18832 (FieldExpr, PropertyExpr): Override and implement
18833 CacheTemporaries. Fixes #52279.
18835 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18837 * location.cs: In the new compiler listing a file twice is a
18838 warning, not an error.
18840 2004-05-24 Martin Baulig <martin@ximian.com>
18842 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18843 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18845 2004-05-24 Martin Baulig <martin@ximian.com>
18847 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18848 walking the `using' list. Fixes #53921.
18850 2004-05-24 Martin Baulig <martin@ximian.com>
18852 * const.cs (Const.LookupConstantValue): Added support for
18853 EmptyCast's; fixes #55251.
18855 2004-05-24 Martin Baulig <martin@ximian.com>
18857 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18858 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18859 which does the CS0135 check. The reason is that we first need to
18860 check whether the variable actually exists.
18862 2004-05-24 Martin Baulig <martin@ximian.com>
18864 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18865 than RootContext.LookupType() to find the explicit interface
18866 type. Fixes #58584.
18868 2004-05-24 Raja R Harinath <rharinath@novell.com>
18870 * Makefile: Simplify. Use executable.make.
18871 * mcs.exe.sources: New file. List of sources of mcs.exe.
18873 2004-05-24 Anders Carlsson <andersca@gnome.org>
18877 Use the invariant culture when doing String.Compare for CLS case
18880 2004-05-23 Martin Baulig <martin@ximian.com>
18882 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18883 don't have any dots. Fixes #52622, added cs0246-8.cs.
18885 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18887 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18889 * class.cs (MemberBase.Define): Reuse MemberType member for
18890 resolved type. Other methods can use it too.
18892 2004-05-23 Martin Baulig <martin@ximian.com>
18894 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18895 the variable also exists in the current block (otherwise, we need
18896 to report a CS0103). Fixes #58670.
18898 2004-05-23 Martin Baulig <martin@ximian.com>
18900 * flowanalysis.cs (Reachability.Reachable): Compute this
18901 on-the-fly rather than storing it as a field.
18903 2004-05-23 Martin Baulig <martin@ximian.com>
18905 * flowanalysis.cs (Reachability.And): Manually compute the
18906 resulting `barrier' from the reachability.
18908 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18911 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18912 instance of ObsoleteAttribute when symbol is obsolete.
18915 (IMethodData): Extended interface for ObsoleteAttribute support.
18917 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18919 * attribute.cs: Fix bug #55970
18921 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18925 (GetObsoleteAttribute): New method. Creates the instance of
18927 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18928 ObsoleteAttribute when member is obsolete.
18929 (AttributeTester.Report_ObsoleteMessage): Common method for
18930 Obsolete error/warning reporting.
18933 (TypeContainer.base_classs_type): New member for storing parent type.
18936 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18937 for this MemberCore.
18939 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18941 * attribute.cs, const.cs: Fix bug #58590
18943 2004-05-21 Martin Baulig <martin@ximian.com>
18945 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18946 out parameters if the end of the method is unreachable. Fixes
18949 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18951 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18952 Hari was right, why extra method.
18954 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18956 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18958 2004-05-20 Martin Baulig <martin@ximian.com>
18960 Merged this back from gmcs to keep the differences to a minumum.
18962 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18963 instead of a Declspace.
18964 (Attribute.ResolveType): Likewise.
18965 (Attributes.Search): Likewise.
18966 (Attributes.Contains): Likewise.
18967 (Attributes.GetClsCompliantAttribute): Likewise.
18969 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18971 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18974 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18976 Fix bug #58688 (MCS does not report error when the same attribute
18979 * attribute.cs (Attribute.Emit): Distinction between null and default.
18981 2004-05-19 Raja R Harinath <rharinath@novell.com>
18983 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18984 of a top-level attribute without an attribute target.
18985 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18987 (Attribute.Conditional_GetConditionName),
18988 (Attribute.Obsolete_GetObsoleteMessage): Update.
18989 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18990 part of ScanForIndexerName.
18991 (Attribute.CanIgnoreInvalidAttribute): New function.
18992 (Attribute.ScanForIndexerName): Move to ...
18993 (Attributes.ScanForIndexerName): ... here.
18994 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18995 (Attributes.Search): New internal variant that can choose not to
18996 complain if types aren't resolved. The original signature now
18998 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18999 complaints suppressed.
19000 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
19001 only if it not useful.
19002 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
19003 top-level for attributes that are shared between the assembly
19004 and a top-level class.
19005 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
19006 * class.cs: Update to reflect changes.
19007 (DefineIndexers): Fuse loops.
19008 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
19009 a couple more variants of attribute names.
19011 2004-05-18 Marek Safar <marek.safar@seznam.cz>
19013 Fix bug #52585 (Implemented explicit attribute declaration)
19016 (Attributable.ValidAttributeTargets): New abstract method. It gets
19017 list of valid attribute targets for explicit target declaration.
19018 (Attribute.Target): It holds target itself.
19019 (AttributeSection): Removed.
19020 (Attribute.CheckTargets): New method. It checks whether attribute
19021 target is valid for the current element.
19024 (EventProperty): New class. For events that are declared like
19025 property (with add and remove accessors).
19026 (EventField): New class. For events that are declared like field.
19029 * cs-parser.jay: Implemented explicit attribute target declaration.
19031 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
19032 Override ValidAttributeTargets.
19035 (ReturnParameter): Class for applying custom attributes on
19037 (ParameterAtribute): New class. Class for applying custom
19038 attributes on the parameter type.
19040 2004-05-17 Miguel de Icaza <miguel@ximian.com>
19042 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
19045 (Method): Allow UNSAFE here.
19047 * modifiers.cs: Support unsafe reporting.
19049 2004-05-17 Marek Safar <marek.safar@seznam.cz>
19051 * decl.cs: Fix bug #58478.
19053 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19055 * statement.cs: When checking for unreachable code on an EmptyStatement,
19056 set the location. Fixes bug #58488.
19058 2004-05-13 Miguel de Icaza <miguel@ximian.com>
19060 * driver.cs: Add -pkg handling.
19062 From Gonzalo: UseShelLExecute=false
19064 2004-05-12 Marek Safar <marek.safar@seznam.cz>
19067 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
19069 (Attribute.IsClsCompliaceRequired): Moved to base for better
19071 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
19072 when attribute is AttributeUsageAttribute.
19073 (Attribute.GetValidTargets): Simplified.
19074 (Attribute.GetAttributeUsage): New method returns AttributeUsage
19075 attribute for this type.
19076 (Attribute.ApplyAttributes): Method renamed to Emit and make
19078 (GlobalAttributeSection): New class for special handling of global
19079 attributes (assembly, module).
19080 (AttributeSection.Emit): New method.
19082 * class.cs: Implemented Attributable abstract methods.
19083 (MethodCore.LabelParameters): Moved to Parameter class.
19084 (Accessor): Is back simple class.
19085 (PropertyMethod): Implemented Attributable abstract class.
19086 (DelegateMethod): Implemented Attributable abstract class.
19087 (Event): New constructor for disctintion between normal Event
19088 and Event with accessors.
19090 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
19092 * codegen.cs, const.cs, decl.cs, delegate.cs:
19093 (CommonAssemblyModulClass): Implemented Attributable abstract class
19096 * enum.cs: Implement IAttributeSupport interface.
19097 (EnumMember): New class for emum members. Implemented Attributable
19101 (ParameterBase): Is abstract.
19102 (ReturnParameter): New class for easier [return:] attribute handling.
19104 * typemanager.cs: Removed builder_to_attr.
19106 2004-05-11 Raja R Harinath <rharinath@novell.com>
19109 * attribute.cs (Attribute.GetPositionalValue): New function.
19110 * class.cs (TypeContainer.VerifyMembers): New function.
19111 (TypeContainer.Emit): Use it.
19112 (ClassOrStruct): New base class for Class and Struct.
19113 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
19114 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
19116 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
19117 then each non-static field should have a FieldOffset attribute.
19118 Otherwise, none of the fields should have a FieldOffset attribute.
19119 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
19120 and FieldOffset attributes.
19121 * typemanager.cs (TypeManager.struct_layout_attribute_type)
19122 (TypeManager.field_offset_attribute_type): New core types.
19123 (TypeManager.InitCoreTypes): Initialize them.
19125 2004-05-11 Michal Moskal <malekith@pld-linux.org>
19127 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
19128 Return correct type.
19131 2004-05-09 Miguel de Icaza <miguel@ximian.com>
19133 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
19134 be implicitly converted to ulong.
19136 * expression.cs: The logic for allowing operator &, | and ^ worked
19137 was wrong, it worked before because we did not report an error in
19138 an else branch. Fixes 57895.
19140 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
19141 allow volatile fields to be reference types.
19143 2004-05-07 Miguel de Icaza <miguel@ximian.com>
19145 * driver.cs: Add support for /debug-
19147 2004-05-07 Raja R Harinath <rharinath@novell.com>
19149 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
19150 Add a 'complain' parameter to silence errors.
19151 (Attribute.Resolve): Update to changes. Put in sanity check to catch
19152 silently overlooked type-resolutions.
19153 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
19154 to reflect changes.
19155 (Attributes.Search): New function.
19156 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
19157 (Attributes.GetAttributeFullName): Remove hack.
19158 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
19159 Update to reflect changes.
19160 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
19161 Use Attributes.Search instead of nested loops.
19163 2004-05-07 Marek Safar <marek.safar@seznam.cz>
19166 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
19167 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
19168 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
19170 * report.cs: (Report.Warning): Renamed to Warning_T because of
19171 parameter collision.
19173 2004-05-05 Raja R Harinath <rharinath@novell.com>
19175 * expression.cs (MemberAccess.ResolveMemberAccess):
19176 Exit with non-zero status after Report.Error.
19177 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
19179 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
19181 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19183 * support.cs: Don't hang when the file is empty.
19185 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19187 * support.cs: In SeekableStreamReader, compute the preamble size of the
19188 underlying stream. Position changes should take into account that initial
19191 2004-05-03 Todd Berman <tberman@sevenl.net>
19193 * driver.cs: remove unused GetSysVersion function.
19195 2004-05-03 Todd Berman <tberman@sevenl.net>
19197 * driver.cs: Remove the hack from saturday, as well as the hack
19198 from jackson (LoadAssemblyFromGac), also adds the CWD to the
19199 link_paths to get that bit proper.
19201 2004-05-01 Todd Berman <tberman@sevenl.net>
19203 * driver.cs: Try a LoadFrom before a Load, this checks the current
19204 path. This is currently a bug in mono that is be fixed, however, this
19205 provides a workaround for now. This will be removed when the bug
19208 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
19210 * CryptoConvert.cs: Updated to latest version. Fix issue with
19211 incomplete key pairs (#57941).
19213 2004-05-01 Todd Berman <tberman@sevenl.net>
19215 * driver.cs: Remove '.' from path_chars, now System.* loads properly
19218 2004-04-30 Jackson Harper <jackson@ximian.com>
19220 * codegen.cs: Open keys readonly.
19222 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19224 * typemanager.cs: don't report cyclic struct layout when a struct
19225 contains 2 or more fields of the same type. Failed for Pango.AttrShape
19226 which has 2 Pango.Rectangle fields.
19228 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
19230 * expression.cs: Handle IntPtr comparisons with IL code
19231 rather than a method call.
19233 2004-04-29 Martin Baulig <martin@ximian.com>
19235 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
19236 the list of PropertyInfo's in class hierarchy and find the
19237 accessor. Fixes #56013.
19239 2004-04-29 Martin Baulig <martin@ximian.com>
19241 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
19243 2004-04-29 Martin Baulig <martin@ximian.com>
19245 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19247 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
19249 2004-04-29 Martin Baulig <martin@ximian.com>
19251 * class.cs (ConstructorInitializer.Resolve): Check whether the
19252 parent .ctor is accessible. Fixes #52146.
19254 2004-04-29 Martin Baulig <martin@ximian.com>
19256 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19258 * statement.cs (Using.EmitLocalVariableDecls): Use
19259 TypeManager.idisposable_type, not typeof (IDisposable).
19260 (Foreach.EmitCollectionForeach): Added support for valuetypes.
19262 2004-04-29 Martin Baulig <martin@ximian.com>
19264 * class.cs (Event.Define): Don't emit the field and don't set
19265 RTSpecialName and SpecialName for events on interfaces. Fixes
19268 2004-04-29 Raja R Harinath <rharinath@novell.com>
19270 Refactor Attribute.ApplyAttributes.
19271 * attribute.cs (Attributable): New base class for objects that can
19272 have Attributes applied on them.
19273 (Attribute): Make AttributeUsage fields public.
19274 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19275 (Attribute.IsInternalCall): New property.
19276 (Attribute.UsageAttr): Convert to a public read-only property.
19277 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19278 (Attribute.ResolveType, Attribute.Resolve)
19279 (Attribute.ScanForIndexerName): Update to reflect changes.
19280 (Attribute.CheckAttributeTarget): Re-format.
19281 (Attribute.ApplyAttributes): Refactor, to various
19282 Attributable.ApplyAttributeBuilder methods.
19283 * decl.cs (MemberCore): Make Attributable.
19284 * class.cs (Accessor): Make Attributable.
19285 (MethodData.ApplyAttributes): Use proper attribute types, not
19287 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19288 (TypeContainer.ApplyAttributeBuilder)
19289 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19290 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19291 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19292 (Operator.ApplyAttributeBuilder): New factored-out methods.
19293 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19294 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19295 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19296 * parameter.cs (ParameterBase): New Attributable base class
19297 that can also represent Return types.
19298 (Parameter): Update to the changes.
19300 2004-04-29 Jackson Harper <jackson@ximian.com>
19302 * driver.cs: Prefer the corlib system version when looking for
19303 assemblies in the GAC. This is still a hack, but its a better hack
19306 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19308 * decl.cs, enum.cs: Improved error 3005 reporting.
19310 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19311 (related_symbols): New private member for list of symbols
19312 related to reported error/warning.
19314 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19316 2004-04-29 Martin Baulig <martin@ximian.com>
19318 * ecore.cs (Expression.Constantify): If we're an enum and
19319 TypeManager.TypeToCoreType() doesn't give us another type, use
19320 t.UnderlyingSystemType. Fixes #56178.
19322 2004-04-29 Martin Baulig <martin@ximian.com>
19324 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19325 interfaces and for each interface, only add members directly
19326 declared in that interface. Fixes #53255.
19328 2004-04-28 Martin Baulig <martin@ximian.com>
19330 * expression.cs (ConditionalLogicalOperator): Use a temporary
19331 variable for `left' to avoid that we evaluate it more than once;
19334 2004-04-28 Martin Baulig <martin@ximian.com>
19336 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19339 2004-04-28 Martin Baulig <martin@ximian.com>
19341 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19344 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19345 whether the type is not void (CS1547).
19347 2004-04-28 Martin Baulig <martin@ximian.com>
19349 * expression.cs (Unary.DoResolveLValue): Override this and report
19350 CS0131 for anything but Operator.Indirection.
19352 2004-04-28 Martin Baulig <martin@ximian.com>
19354 Committing a patch from Ben Maurer; see bug #50820.
19356 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19359 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19362 2004-04-28 Martin Baulig <martin@ximian.com>
19364 Committing a patch from Ben Maurer; see bug #50820.
19366 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19369 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19372 2004-04-28 Martin Baulig <martin@ximian.com>
19374 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19375 (Block.AddLabel): Call DoLookupLabel() to only search in the
19378 2004-04-28 Martin Baulig <martin@ximian.com>
19380 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19381 comparing StringConstants and NullLiterals in Equality and Inequality.
19383 2004-04-28 Jackson Harper <jackson@ximian.com>
19385 * driver.cs: Attempt to load referenced assemblies from the
19386 GAC. This is the quick and dirty version of this method that
19387 doesnt take into account versions and just takes the first
19388 canidate found. Will be good enough for now as we will not have more
19389 then one version installed into the GAC until I update this method.
19391 2004-04-28 Martin Baulig <martin@ximian.com>
19393 * typemanager.cs (TypeManager.CheckStructCycles): New public
19394 static method to check for cycles in the struct layout.
19396 * rootcontext.cs (RootContext.PopulateTypes): Call
19397 TypeManager.CheckStructCycles() for each TypeContainer.
19398 [Note: We only need to visit each type once.]
19400 2004-04-28 Martin Baulig <martin@ximian.com>
19402 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19404 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19405 success and added `out object value'. Use a `bool resolved' field
19406 to check whether we've already been called rather than
19407 `ConstantValue != null' since this breaks for NullLiterals.
19409 2004-04-28 Raja R Harinath <rharinath@novell.com>
19411 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19412 setting of this flag, since the 'set' method may be non-public.
19414 2004-04-28 Raja R Harinath <rharinath@novell.com>
19416 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19417 check on current_vector.Block.
19419 2004-04-27 Martin Baulig <martin@ximian.com>
19421 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19422 a field initializer. Fixes #56459.
19424 2004-04-27 Martin Baulig <martin@ximian.com>
19426 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19427 we're not attempting to use an indexer. Fixes #52154.
19429 2004-04-27 Martin Baulig <martin@ximian.com>
19431 * statement.cs (Return): Don't create a return label if we don't
19432 need it; reverts my change from January 20th. Thanks to Ben
19435 2004-04-27 Martin Baulig <martin@ximian.com>
19437 According to the spec, `goto' can only leave a nested scope, but
19440 * statement.cs (Block.LookupLabel): Only lookup in the current
19441 block, don't recurse into parent or child blocks.
19442 (Block.AddLabel): Check in parent and child blocks, report
19443 CS0140/CS0158 if we find a duplicate.
19444 (Block): Removed this indexer for label lookups.
19445 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19446 this already does the error reporting for us.
19449 (FlowBranching.UsageVector.Block): New public variable; may be null.
19450 (FlowBranching.CreateSibling): Added `Block' argument.
19451 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19452 label for the target of a `goto' and check whether we're not
19453 leaving a `finally'.
19455 2004-04-27 Martin Baulig <martin@ximian.com>
19457 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19458 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19461 2004-04-27 Martin Baulig <martin@ximian.com>
19463 * statement.cs (Block.AddLabel): Also check for implicit blocks
19464 and added a CS0158 check.
19466 2004-04-27 Martin Baulig <martin@ximian.com>
19468 * flowanalysis.cs (FlowBranchingLoop): New class.
19469 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19470 UsageVector's instead of an ArrayList.
19471 (FlowBranching.Label): Likewise.
19472 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19473 (FlowBranching.AddBreakVector): New method.
19475 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19477 * attribute.cs: Small regression fix: only convert the type if we
19478 the type is different, fixes System.Drawing build.
19480 2004-04-27 Martin Baulig <martin@ximian.com>
19482 * attribute.cs (Attribute.Resolve): If we have a constant value
19483 for a named field or property, implicity convert it to the correct
19486 2004-04-27 Raja R Harinath <rharinath@novell.com>
19488 * statement.cs (Block.Block): Implicit blocks share
19489 'child_variable_names' fields with parent blocks.
19490 (Block.AddChildVariableNames): Remove.
19491 (Block.AddVariable): Mark variable as "used by a child block" in
19492 every surrounding block.
19493 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19494 been used in a child block, complain about violation of "Invariant
19495 meaning in blocks" rule.
19496 * cs-parser.jay (declare_local_variables): Don't use
19497 AddChildVariableNames.
19498 (foreach_statement): Don't create an implicit block: 'foreach'
19499 introduces a scope.
19501 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19503 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19504 converting from 0L to ulong. Fixes 57522.
19506 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19508 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19509 derived class hides via 'new' keyword field from base class (test-242.cs).
19510 TODO: Handle this in the more general way.
19512 * class.cs (CheckBase): Ditto.
19514 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19516 * decl.cs (caching_flags): New member for storing cached values
19518 (MemberCore.Flags): New enum where bit flags for caching_flags
19520 (MemberCore.cls_compliance): Moved to caching_flags.
19521 (DeclSpace.Created): Moved to caching_flags.
19523 * class.cs: Use caching_flags instead of DeclSpace.Created
19525 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19527 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19528 if we are only a derived class, not a nested class.
19530 * typemanager.cs: Same as above, but do this at the MemberLookup
19531 level (used by field and methods, properties are handled in
19532 PropertyExpr). Allow for the qualified access if we are a nested
19535 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19537 * class.cs: Refactoring.
19538 (IMethodData): New inteface; Holds links to parent members
19539 to avoid member duplication (reduced memory allocation).
19540 (Method): Implemented IMethodData interface.
19541 (PropertyBase): New inner classes for get/set methods.
19542 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19543 (Event): New inner classes for add/remove methods.
19544 (Event.DelegateMethod): Implemented IMethodData interface.
19546 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19547 EmitContext (related to class.cs refactoring).
19549 2004-04-21 Raja R Harinath <rharinath@novell.com>
19551 * delegate.cs (Delegate.VerifyApplicability): If the number of
19552 arguments are the same as the number of parameters, first try to
19553 verify applicability ignoring any 'params' modifier on the last
19557 2004-04-16 Raja R Harinath <rharinath@novell.com>
19559 * class.cs (TypeContainer.AddIndexer): Use
19560 'ExplicitInterfaceName' to determine if interface name was
19561 explicitly specified. 'InterfaceType' is not initialized at this time.
19562 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19563 Indexers array is already in the required order. Initialize
19564 'IndexerName' only if there are normal indexers.
19565 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19566 (TypeContainer.Emit): Emit DefaultMember attribute only if
19567 IndexerName is initialized.
19570 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19572 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19575 2004-04-15 Raja R Harinath <rharinath@novell.com>
19577 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19581 * attribute.cs (Attribute.Resolve): Check for duplicate named
19585 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19587 * iterators.cs (MarkYield): track whether we are in an exception,
19588 and generate code accordingly. Use a temporary value to store the
19589 result for our state.
19591 I had ignored a bit the interaction of try/catch with iterators
19592 since their behavior was not entirely obvious, but now it is
19593 possible to verify that our behavior is the same as MS .NET 2.0
19597 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19599 * iterators.cs: Avoid creating temporaries if there is no work to
19602 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19603 Enumerations, use TypeManager.EnumToUnderlying and call
19606 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19609 (This.Emit): Use EmitContext.EmitThis to emit our
19612 (This.EmitAssign): Ditto.
19614 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19615 codepaths, we will move all the functionality into
19618 (FieldExpr.EmitAssign): Ditto.
19620 This fixes several hidden bugs that I uncovered while doing a code
19621 review of this today.
19623 * codegen.cs (EmitThis): reworked so the semantics are more clear
19624 and also support value types "this" instances.
19626 * iterators.cs: Changed so that for iterators in value types, we
19627 do not pass the value type as a parameter.
19629 Initialization of the enumerator helpers is now done in the caller
19630 instead of passing the parameters to the constructors and having
19631 the constructor set the fields.
19633 The fields have now `assembly' visibility instead of private.
19635 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19637 * expression.cs (Argument.Resolve): Check if fields passed as ref
19638 or out are contained in a MarshalByRefObject.
19640 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19641 another compiler type.
19643 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19645 * class.cs (Indexer.Define): use the new name checking method.
19646 Also, return false on an error.
19647 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19648 (is_identifier_[start/part]_character): make static.
19650 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19652 * expression.cs (Binary.ResolveOperator): Do no append strings
19653 twice: since we can be invoked more than once (array evaluation)
19654 on the same concatenation, take care of this here. Based on a fix
19655 from Ben (bug #56454)
19657 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19659 * codegen.cs: Fix another case where CS1548 must be reported (when
19660 delay-sign isn't specified and no private is available #56564). Fix
19661 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19662 error when MCS is used on the MS runtime and we need to delay-sign
19663 (which seems unsupported by AssemblyBuilder - see #56621).
19665 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19667 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19668 (TypeManager.ComputeNamespaces): Faster implementation for
19671 * compiler.csproj: Updated AssemblyName to mcs.
19673 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19675 * rootcontext.cs: Add new types to the boot resolution.
19677 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19678 MulticastDelegate is not allowed.
19680 * typemanager.cs: Add new types to lookup: System.TypedReference
19683 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19684 check for TypedReference or ArgIterator, they are not allowed.
19686 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19687 makes us properly catch 1510 in some conditions (see bug 56016 for
19690 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19692 * CryptoConvert.cs: update from corlib version
19695 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19697 * class.cs (Indexer.Define): Check indexername declaration
19699 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19701 * attribute.cs (IsClsCompliant): Fixed problem with handling
19702 all three states (compliant, not-compliant, undetected).
19704 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19706 * attribute.cs (Attribute): Location is now public.
19707 (Resolve): Store resolved arguments (pos_values) in attribute class.
19708 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19709 (GetClsCompliantAttributeValue): New method that gets
19710 CLSCompliantAttribute value.
19711 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19712 if exists else null.
19713 (AttributeTester): New class for CLS-Compliant verification routines.
19715 * class.cs (Emit): Add CLS-Compliant verification.
19716 (Method.GetSignatureForError): Implemented.
19717 (Constructor.GetSignatureForError): Implemented
19718 (Constructor.HasCompliantArgs): Returns if constructor has
19719 CLS-Compliant arguments.
19720 (Constructor.Emit): Override.
19721 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19722 is needed to test only parameters.
19723 (FieldBase.GetSignatureForError): Implemented.
19724 (TypeContainer): New member for storing base interfaces.
19725 (TypeContainer.FindMembers): Search in base interfaces too.
19727 * codegen.cs (GetClsComplianceAttribute): New method that gets
19728 assembly or module CLSCompliantAttribute value.
19729 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19731 (ModuleClass.Emit): Add error 3012 test.
19733 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19735 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19736 state for all decl types.
19737 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19738 if CLS-Compliant tests are required.
19739 (IsClsCompliaceRequired): New method. Analyze whether code
19740 must be CLS-Compliant.
19741 (IsExposedFromAssembly): New method. Returns true when MemberCore
19742 is exposed from assembly.
19743 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19744 value or gets cached value.
19745 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19746 is explicitly marked with CLSCompliantAttribute.
19747 (IsIdentifierClsCompliant): New abstract method. This method is
19748 used to testing error 3005.
19749 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19750 for identifier and parameters CLS-Compliant testing.
19751 (VerifyClsCompliance): New method. The main virtual method for
19752 CLS-Compliant verifications.
19753 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19754 null. I don't know why is null (too many public members !).
19755 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19756 and get value of first CLSCompliantAttribute that found.
19758 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19759 (VerifyClsCompliance): Override and add extra tests.
19761 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19762 clscheck- disable CLS-Compliant verification event if assembly is has
19763 CLSCompliantAttribute(true).
19765 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19766 ApllyAttribute is now called in emit section as in the other cases.
19767 Possible future Emit integration.
19768 (IsIdentifierClsCompliant): New override.
19769 (VerifyClsCompliance): New override.
19770 (GetEnumeratorName): Returns full enum name.
19772 * parameter.cs (GetSignatureForError): Implemented.
19774 * report.cs (WarningData): New struct for Warning message information.
19775 (LocationOfPreviousError): New method.
19776 (Warning): New method. Reports warning based on the warning table.
19777 (Error_T): New method. Reports error based on the error table.
19779 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19780 verifications are done here.
19782 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19784 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19785 CLSCompliantAttribute.
19786 (all_imported_types): New member holds all imported types from other
19788 (LoadAllImportedTypes): New method fills static table with exported types
19789 from all referenced assemblies.
19790 (Modules): New property returns all assembly modules.
19792 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19794 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19795 throwing a parser error.
19797 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19798 which removes the hardcoded get_/set_ prefixes for properties, as
19799 IL allows for the properties to be named something else.
19803 * expression.cs: Do not override operand before we know if it is
19804 non-null. Fix 56207
19806 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19808 * typemanager.cs: support for pinned variables.
19810 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19812 * decl.cs, typemanager.cs: Avoid using an arraylist
19813 as a buffer if there is only one result set.
19815 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19817 * expression.cs: Make sure you cant call a static method
19818 with an instance expression, bug #56174.
19820 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19822 * class.cs (IsDuplicateImplementation): Improve error reporting to
19823 flag 663 (method only differs in parameter modifier).
19825 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19826 in preprocessor directives.
19828 * location.cs (LookupFile): Allow for the empty path.
19830 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19831 better approach for some of that patch, but its failing with the
19832 CharSet enumeration. For now try/catch will do.
19834 * typemanager.cs: Do not crash if a struct does not have fields.
19837 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19839 * expression.cs: cs0213, cant fix a fixed expression.
19842 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19844 * cs-parser.jay: detect invalid embeded statements gracefully.
19847 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19849 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19852 the invocation type may not be a subclass of the tye of the item/
19853 The type of the item must be a subclass of the invocation item.
19858 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19860 * attribute.cs: Added methods to get a string and a bool from an
19861 attribute. Required to information from AssemblyKeyFileAttribute,
19862 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19863 * codegen.cs: Modified AssemblyName creation to include support for
19864 strongnames. Catch additional exceptions to report them as CS1548.
19865 * compiler.csproj: Updated include CryptoConvert.cs.
19866 * compiler.csproj.user: Removed file - user specific configuration.
19867 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19868 Mono.Security assembly. The original class is maintained and tested in
19869 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19870 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19871 like CSC 8.0 (C# v2) supports.
19872 * Makefile: Added CryptoConvert.cs to mcs sources.
19873 * rootcontext.cs: Added new options for strongnames.
19875 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19877 * driver.cs: For --expect-error, report error code `2'
19878 if the program compiled with no errors, error code `1' if
19879 it compiled with an error other than the one expected.
19881 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19883 * compiler.csproj: Updated for Visual Studio .NET 2003.
19884 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19885 * compiler.sln: Updated for Visual Studio .NET 2003.
19887 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19889 * expression.cs: Fix bug #47234. We basically need to apply the
19890 rule that we prefer the conversion of null to a reference type
19891 when faced with a conversion to 'object' (csc behaviour).
19893 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19895 * statement.cs: Shorter form for foreach, eliminates
19896 a local variable. r=Martin.
19898 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19900 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19901 checks if we can use brtrue/brfalse to test for 0.
19902 * expression.cs: use the above in the test for using brtrue/brfalse.
19903 cleanup code a bit.
19905 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19907 * expression.cs: Rewrite string concat stuff. Benefits:
19909 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19910 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19911 rather than a concat chain.
19913 * typemanager.cs: Add lookups for more concat overloads.
19915 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19917 * expression.cs: Emit shorter il code for array init.
19934 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19936 * statement.cs: Before, two switch blocks would be merged if the
19937 total size of the blocks (end_item - begin_item + 1) was less than
19938 two times the combined sizes of the blocks.
19940 Now, it will only merge if after the merge at least half of the
19945 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19947 * class.cs : csc build fix for GetMethods(). See bug #52503.
19949 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19951 * expression.cs: Make sure fp comparisons work with NaN.
19952 This fixes bug #54303. Mig approved this patch a long
19953 time ago, but we were not able to test b/c the runtime
19956 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19958 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19960 2004-03-19 Martin Baulig <martin@ximian.com>
19962 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19963 error here and not in our caller.
19965 2004-03-19 Martin Baulig <martin@ximian.com>
19967 * interface.cs: Completely killed this file.
19968 (Interface): We're now a TypeContainer and live in class.cs.
19970 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19971 argument; we're now also called for interfaces.
19972 (TypeContainer.DefineMembers): Allow this method being called
19974 (TypeContainer.GetMethods): New public method; formerly known as
19975 Interface.GetMethod(). This is used by PendingImplementation.
19976 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19977 it's now private and non-static.
19978 (Interface): Moved this here; it's now implemented similar to
19980 (Method, Property, Event, Indexer): Added `bool is_interface'
19981 argument to their .ctor's.
19982 (MemberBase.IsInterface): New public field.
19984 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19985 instances instead of InterfaceMethod, InterfaceProperty, etc.
19986 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19987 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19989 2004-03-19 Martin Baulig <martin@ximian.com>
19991 * class.cs (MethodCore.IsDuplicateImplementation): New private
19992 method which does the CS0111 checking.
19993 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19994 Use IsDuplicateImplementation().
19996 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19998 * decl.cs (FindMemberToOverride): New method to find the correct
19999 method or property to override in the base class.
20001 - Make Method/Property use the above method to find the
20002 version in the base class.
20003 - Remove the InheritableMemberSignatureCompare as it is now
20006 This patch makes large code bases much faster to compile, as it is
20007 O(n) rather than O(n^2) to do this validation.
20009 Also, it fixes bug 52458 which is that nested classes are not
20010 taken into account when finding the base class member.
20012 Reviewed/Approved by Martin.
20014 2004-03-17 Marek Safar <marek.safar@seznam.cz>
20016 * interface.cs: In all interface classes removed redundant
20017 member initialization.
20019 2004-03-16 Martin Baulig <martin@ximian.com>
20021 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
20023 2004-03-15 Miguel de Icaza <miguel@ximian.com>
20025 * decl.cs (DefineTypeAndParents): New helper method to define a
20026 type's containers before the type itself is defined; This is a
20027 bug exposed by the recent changes to Windows.Forms when an
20028 implemented interface was defined inside a class that had not been
20031 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
20033 (Check): Loop correctly to report errors modifiers
20034 (UNSAFE was not in the loop, since it was the same as TOP).
20036 * interface.cs: Every interface member now takes a ModFlags,
20037 instead of a "is_new" bool, which we set on the base MemberCore.
20039 Every place where we called "UnsafeOk" in the interface, now we
20040 call the proper member (InterfaceMethod.UnsafeOK) instead to get
20041 the unsafe settings from the member declaration instead of the
20042 container interface.
20044 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
20046 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
20047 `set_indexer_name' to the pending bits (one per type).
20049 We fixed a bug today that was picking the wrong method to
20050 override, since for properties the existing InterfaceMethod code
20051 basically ignored the method name. Now we make sure that the
20052 method name is one of the valid indexer names.
20054 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
20056 * support.cs (SeekableStreamReader): Keep track of stream byte
20057 positions and don't mix them with character offsets to the buffer.
20059 Patch from Gustavo Giráldez
20061 2004-03-15 Marek Safar <marek.safar@seznam.cz>
20063 * interface.cs (InterfaceSetGetBase): Removed double member
20064 initialization, base class does it as well.
20066 2004-03-13 Martin Baulig <martin@ximian.com>
20068 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
20069 when compiling corlib.
20071 2004-03-13 Miguel de Icaza <miguel@ximian.com>
20073 * convert.cs (ExplicitConversion): We were reporting an error on
20074 certain conversions (object_type source to a value type, when the
20075 expression was `null') before we had a chance to pass it through
20076 the user defined conversions.
20078 * driver.cs: Replace / and \ in resource specifications to dots.
20081 * class.cs: Add check for duplicate operators. Fixes 52477
20083 2004-03-11 Miguel de Icaza <miguel@ximian.com>
20085 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
20086 that are in the middle of the statements, not only at the end.
20089 * class.cs (TypeContainer.AddField): No longer set the
20090 `HaveStaticConstructor' flag, now we call it
20091 `UserDefineStaticConstructor' to diferentiate the slightly
20092 semantic difference.
20094 The situation is that we were not adding BeforeFieldInit (from
20095 Modifiers.TypeAttr) to classes that could have it.
20096 BeforeFieldInit should be set to classes that have no static
20101 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
20103 And most importantly Zoltan's comment:
20105 http://bugzilla.ximian.com/show_bug.cgi?id=44229
20107 "I think beforefieldinit means 'it's ok to initialize the type sometime
20108 before its static fields are used', i.e. initialization does not need
20109 to be triggered by the first access to the type. Setting this flag
20110 helps the JIT to compile better code, since it can run the static
20111 constructor at JIT time, and does not need to generate code to call it
20112 (possibly lots of times) at runtime. Unfortunately, mcs does not set
20113 this flag for lots of classes like String.
20115 csc sets this flag if the type does not have an explicit static
20116 constructor. The reasoning seems to be that if there are only static
20117 initalizers for a type, and no static constructor, then the programmer
20118 does not care when this initialization happens, so beforefieldinit
20121 This bug prevents the AOT compiler from being usable, since it
20122 generates so many calls to mono_runtime_class_init that the AOT code
20123 is much slower than the JITted code. The JITted code is faster,
20124 because it does not generate these calls if the vtable is type is
20125 already initialized, which is true in the majority of cases. But the
20126 AOT compiler can't do this."
20128 2004-03-10 Miguel de Icaza <miguel@ximian.com>
20130 * class.cs (MethodData.Emit): Refactor the code so symbolic
20131 information is generated for destructors; For some reasons we
20132 were taking a code path that did not generate symbolic information
20135 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
20137 * class.cs: Create a Constructor.CheckBase method that
20138 takes care of all validation type code. The method
20139 contains some code that was moved from Define.
20141 It also includes new code that checks for duplicate ctors.
20142 This fixes bug #55148.
20144 2004-03-09 Joshua Tauberer <tauberer@for.net>
20146 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
20147 a { ... }-style array creation invokes EmitStaticInitializers
20148 which is not good for reference-type arrays. String, decimal
20149 and now null constants (NullCast) are not counted toward
20150 static initializers.
20152 2004-03-05 Martin Baulig <martin@ximian.com>
20154 * location.cs (SourceFile.HasLineDirective): New public field;
20155 specifies whether the file contains or is referenced by a "#line"
20157 (Location.DefineSymbolDocuments): Ignore source files which
20158 either contain or are referenced by a "#line" directive.
20160 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
20162 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
20163 direct access to our parent, so check the method inline there.
20165 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
20167 * expression.cs (Invocation.EmitCall): Miguel's last commit
20168 caused a regression. If you had:
20173 In Foo the implict this would be null.
20175 2004-02-27 Miguel de Icaza <miguel@ximian.com>
20177 * expression.cs (Invocation.EmitCall): If the method is not
20178 virtual, do not emit a CallVirt to it, use Call.
20180 * typemanager.cs (GetFullNameSignature): Improve the method to
20181 cope with ".ctor" and replace it with the type name.
20183 * class.cs (ConstructorInitializer.Resolve): Now the method takes
20184 as an argument the ConstructorBuilder where it is being defined,
20185 to catch the recursive constructor invocations.
20187 2004-02-26 Miguel de Icaza <miguel@ximian.com>
20189 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
20190 routines to check if a type is an enumerable/enumerator allow
20191 classes that implement the IEnumerable or IEnumerator interfaces.
20193 * class.cs (Property, Operator): Implement IIteratorContainer, and
20194 implement SetYields.
20196 (Property.Define): Do the block swapping for get_methods in the
20197 context of iterators. We need to check if Properties also
20198 include indexers or not.
20200 (Operator): Assign the Block before invoking the
20201 OperatorMethod.Define, so we can trigger the Iterator code
20204 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
20205 Property and Operator classes are not created when we parse the
20206 declarator but until we have the block completed, so we use a
20207 singleton SimpleIteratorContainer.Simple to flag whether the
20208 SetYields has been invoked.
20210 We propagate this setting then to the Property or the Operator to
20211 allow the `yield' to function.
20213 2004-02-25 Marek Safar <marek.safar@seznam.cz>
20215 * codegen.cs: Implemented attribute support for modules.
20216 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
20217 Assembly/Module functionality.
20219 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
20220 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
20221 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
20223 2004-02-16 Marek Safar <marek.safar@seznam.cz>
20225 * interface.cs (FindMembers): The operation is performed on all base
20226 interfaces and not only on the first. It is required for future CLS Compliance patch.
20228 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
20230 * statement.cs, codegen.cs:
20231 This patch deals with patterns such as:
20233 public class List : IEnumerable {
20235 public MyEnumerator GetEnumerator () {
20236 return new MyEnumerator(this);
20239 IEnumerator IEnumerable.GetEnumerator () {
20243 public struct MyEnumerator : IEnumerator {
20248 Before, there were a few things we did wrong:
20249 1) we would emit callvirt on a struct, which is illegal
20250 2) we emited ldarg when we needed to emit ldarga
20251 3) we would mistakenly call the interface methods on an enumerator
20252 type that derived from IEnumerator and was in another assembly. For example:
20254 public class MyEnumerator : IEnumerator
20256 Would have the interface methods called, even if there were public impls of the
20257 method. In a struct, this lead to invalid IL code.
20259 2004-02-11 Marek Safar <marek.safar@seznam.cz>
20261 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
20264 * delegate.cs (Define): Fixed crash when delegate type is undefined.
20266 2004-02-11 Miguel de Icaza <miguel@ximian.com>
20268 * cs-parser.jay: Fix small regression: we were not testing V2
20269 compiler features correctly.
20271 * interface.cs: If the emit context is null, then create one
20273 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20275 * decl.cs (GetSignatureForError): New virtual method to get full name
20276 for error messages.
20278 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20279 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20281 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20282 Duplicated members and code in these classes has been removed.
20283 Better encapsulation in these classes.
20285 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20287 * assign.cs (Assign.DoResolve): When dealing with compound
20288 assignments, there is a new rule in ECMA C# 2.4 (might have been
20289 there before, but it is documented here) that states that in:
20293 If b is of type int, and the `op' is a shift-operator, then the
20294 above is evaluated as:
20298 * expression.cs (Binary.ResolveOperator): Instead of testing for
20299 int/uint/long/ulong, try to implicitly convert to any of those
20300 types and use that in pointer arithmetic.
20302 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20303 method to print information for from the type, not from the
20304 null-method we were given.
20306 2004-02-01 Duncan Mak <duncan@ximian.com>
20308 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20309 parsing for cmd, fixes bug #53694.
20311 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20313 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20314 in the member name duplication tests. Property and operator name duplication
20315 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20317 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20319 * interface.cs (PopulateMethod): Fixed crash when interface method
20320 returns not existing type (error test cs0246-3.cs).
20322 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20324 * cs-parser.jay (interface_accessors): Re-write actions to also
20325 store attributes attached to get and set methods. Fix spelling
20328 (inteface_property_declaration): Modify accordingly.
20330 (InterfaceAccessorInfo): New helper class to store information to pass
20331 around between rules that use interface_accessors.
20333 * interface.cs (Emit): Apply attributes on the get and set
20334 accessors of properties and indexers too.
20336 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20337 right MethodBuilder when applying attributes to the get and set accessors.
20339 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20341 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20343 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20345 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20347 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20349 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20350 changes that treat `yield' specially when present before `break'
20351 or `return' tokens.
20353 * cs-tokenizer.cs: yield is no longer a keyword.
20355 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20357 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20358 setting for default constructors.
20359 For default constructors are almost every time set wrong Modifier. The
20360 generated IL code has been alright. But inside mcs this values was
20361 wrong and this was reason why several of my CLS Compliance tests
20364 2004-01-22 Martin Baulig <martin@ximian.com>
20366 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20367 not a QualifiedIdentifier. This is what `type_name_expression'
20368 was previously doing.
20369 (type_name_expression): Removed; the code is now in
20370 `namespace_or_type_name'.
20371 (qualified_identifier): Removed, use `namespace_or_type_name'
20373 (QualifiedIdentifier): Removed this class.
20375 2004-01-22 Martin Baulig <martin@ximian.com>
20377 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20378 not a string as alias name.
20380 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20382 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20383 #52730 bug, and instead compute correctly the need to use a
20384 temporary variable when requesting an address based on the
20385 static/instace modified of the field and the constructor.
20387 2004-01-21 Martin Baulig <martin@ximian.com>
20389 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20390 class and namespace before looking up aliases. Fixes #52517.
20392 2004-01-21 Martin Baulig <martin@ximian.com>
20394 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20395 assinged in a 'try'; fixes exception4.cs.
20397 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20398 * class.cs : Implemented parameter-less constructor for TypeContainer
20400 * decl.cs: Attributes are now stored here. New property OptAttributes
20402 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20404 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20406 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20408 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20409 (CSharpSignature): New method for indexer and property signature.
20411 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20413 * pending.cs (IsVirtualFilter): Faster implementation.
20415 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20417 * typemanager.cs: Avoid inclusion of same assembly more than once.
20419 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20421 * cs-parser.jay: Fixed problem where the last assembly attribute
20422 has been applied also to following declaration (class, struct, etc.)
20424 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20426 * class.cs: Added error CS0538, CS0539 reporting.
20427 Fixed crash on Microsoft runtime when field type is void.
20429 * cs-parser.jay: Added error CS0537 reporting.
20431 * pending.cs: Added error CS0535 reporting.
20432 Improved error report for errors CS0536, CS0534.
20434 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20436 Merge a few bits from the Anonymous Method MCS tree.
20438 * statement.cs (ToplevelBlock): New class for toplevel methods,
20439 will hold anonymous methods, lifted variables.
20441 * cs-parser.jay: Create toplevel blocks for delegates and for
20442 regular blocks of code.
20444 2004-01-20 Martin Baulig <martin@ximian.com>
20446 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20447 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20448 and `NeedExplicitReturn'; added `IsLastStatement'.
20449 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20450 have a `ReturnLabel' or we're not unreachable.
20452 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20453 child's reachability; don't just override ours with it. Fixes
20454 #58058 (lluis's example).
20455 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20456 InFinally(), InLoop(), InSwitch() and
20457 BreakCrossesTryCatchBoundary() methods.
20459 * statement.cs (Return): Do all error checking in Resolve().
20460 Unless we are the last statement in a top-level block, always
20461 create a return label and jump to it.
20462 (Break, Continue): Do all error checking in Resolve(); also make
20463 sure we aren't leaving a `finally'.
20464 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20465 statement in a top-level block.
20466 (Block.Flags): Added `IsDestructor'.
20467 (Block.IsDestructor): New public property.
20469 2004-01-20 Martin Baulig <martin@ximian.com>
20471 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20473 2004-01-20 Martin Baulig <martin@ximian.com>
20475 * statement.cs (Statement.ResolveUnreachable): New public method.
20476 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20477 (Block.Resolve): Resolve unreachable statements.
20479 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20481 * expression.cs: We need to fix the case where we do
20482 not have a temp variable here.
20484 * assign.cs: Only expression compound assignments need
20485 temporary variables.
20487 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20489 * flowanalysis.cs: Reduce memory allocation in a few ways:
20490 - A block with no variables should not allocate a bit
20492 - A method with no out parameters does not need any tracking
20493 for assignment of the parameters, so we need not allocate
20496 public readonly Type[] VariableTypes;
20497 public readonly string[] VariableNames;
20498 Are redundant. The data is already stored in the variable
20499 map, so we need not allocate another array for it.
20500 - We need to add alot of checks for if (params | locals) == null
20501 due to the first two changes.
20503 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20505 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20506 implement IMemoryLocation, we store a copy on a local variable and
20507 take the address of it. Patch from Benjamin Jemlich
20509 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20510 to use a special "type_name_expression" rule which reduces the
20511 number of "QualifiedIdentifier" classes created, and instead
20512 directly creates MemberAccess expressions.
20514 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20516 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20517 that fixes #52853. Null literal assignment to ValueType
20519 * class.cs (MethodData.Emit): Instead of checking the name of the
20520 method to determine if its a destructor, create a new derived
20521 class from Method called Destructor, and test for that.
20523 * cs-parser.jay: Create a Destructor object instead of a Method.
20525 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20529 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20531 * expression.cs (Binary.ResolveOperator): Perform an implicit
20532 conversion from MethodGroups to their delegate types on the
20533 Addition operation.
20535 * delegate.cs: Introduce a new class DelegateCreation that is the
20536 base class for `NewDelegate' and `ImplicitDelegateCreation',
20537 factor some code in here.
20539 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20540 conversion from MethodGroups to compatible delegate types.
20542 * ecore.cs (Expression.Resolve): Do not flag error 654
20543 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20544 we allow conversions from MethodGroups to delegate types now.
20546 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20547 assignments in v2 either.
20549 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20551 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20552 static read-only fields in ctors.
20554 Applied patch from Benjamin Jemlich
20556 * expression.cs (UnaryMutator): Avoid leaking local variables.
20558 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20560 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20561 here to return true, as they can be used like this:
20563 (XXX) int.MEMBER ()
20565 Fixed 49836 and all the other dups
20567 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20569 * driver.cs: Implement /win32res and /win32icon.
20571 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20573 * cs-parser.jay: Add a rule to improve error handling for the
20574 common mistake of placing modifiers after the type.
20576 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20578 * cs-parser.jay (interface_event_declaration): Catch
20579 initialization of events on interfaces, and report cs0068
20581 * cs-parser.jay (interface_event_declaration): Catch
20582 initialization of events.
20584 * ecore.cs: Better report missing constructors.
20586 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20587 the error reporting done in the wrong place. Fix.
20589 * expression.cs (Binary.ResolveOperator): Catch the
20590 operator + (E x, E y) error earlier, and later allow for implicit
20591 conversions in operator +/- (E e, U x) from U to the underlying
20594 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20595 52596, if the container class is abstract, the default constructor
20596 is protected otherwise its public (before, we were always public).
20598 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20601 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20602 Jemlich that fixes bug #52597, MCS was generating invalid code for
20603 idisposable structs. Thanks to Ben for following up with this
20606 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20608 * driver.cs: Allow assemblies without code to be generated, fixes
20611 2004-01-07 Nick Drochak <ndrochak@gol.com>
20613 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20615 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20617 * cs-parser.jay: Add rules to improve error reporting if fields or
20618 methods are declared at the namespace level (error 116)
20620 * Add rules to catch event add/remove
20622 2004-01-04 David Sheldon <dave-mono@earth.li>
20624 * expression.cs: Added matching ")" to error message for
20627 2004-01-03 Todd Berman <tberman@gentoo.org>
20629 * ecore.cs, attribute.cs:
20630 Applying fix from #52429.
20632 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20634 * ecore.cs, expression.cs, statement.cs:
20635 Total rewrite of how we handle branching. We
20636 now handle complex boolean expressions with fewer
20637 jumps. As well if (x == 0) no longer emits a ceq.
20639 if (x is Foo) is much faster now, because we generate
20642 Overall, we get a pretty big improvement on our benchmark
20643 tests. The code we generate is smaller and more readable.
20645 I did a full two-stage bootstrap. The patch was reviewed
20646 by Martin and Miguel.
20648 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20650 * cs-parser.jay: Make primary_expression not take a QI.
20651 we dont need this because the member_access rule covers
20652 us here. So we replace the rule with just IDENTIFIER.
20654 This has two good effects. First, we remove a s/r conflict.
20655 Second, we allocate many fewer QualifiedIdentifier objects.
20657 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20659 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20660 set the correct information via SRE. This prevents
20661 hanging on the MS runtime. Fixes #29374.
20663 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20665 * convert.cs: correctly handle conversions to value types
20666 from Enum and ValueType as unboxing conversions.
20668 Fixes bug #52569. Patch by Benjamin Jemlich.
20670 2004-01-02 Ravi Pratap <ravi@ximian.com>
20672 * expression.cs (BetterConversion): Prefer int -> uint
20673 over int -> ulong (csc's behaviour). This fixed bug #52046.
20675 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20677 * decl.cs (MemberCache.FindMembers): now returns a
20680 * typemanager.cs: In general, go with with ^^.
20681 (CopyNewMethods): take an IList.
20682 (RealMemberLookup): Only allocate an arraylist
20683 if we copy from two sets of methods.
20685 This change basically does two things:
20686 1) Fewer array lists allocated due to CopyNewMethods.
20687 2) the explicit cast in MemberList costed ALOT.
20689 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20691 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20692 a hashtable to avoid needless string allocations when an identifier is
20693 used more than once (the common case).
20695 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20697 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20698 is broken, it will not return anything. So, we
20699 have to use the information we have in mcs to
20702 * typemanager.cs: Add a cache for GetInterfaces,
20703 since this will now be used more often (due to ^^)
20705 (GetExplicitInterfaces) New method that gets the
20706 declared, not effective, interfaces on a type
20707 builder (eg, if you have interface IFoo, interface
20708 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20711 This patch makes MCS able to bootstrap itself on
20714 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20716 * expression.cs: Remove the Nop's that Miguel put
20719 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20721 * report.cs, codegen.cs: Give the real stack trace to
20722 the error when an exception is thrown.
20724 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20726 * decl.cs: only allocate hashtables for ifaces if
20729 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20731 * expression.cs: fix the error from cs0121-2.cs
20732 (a parent interface has two child interfaces that
20733 have a function with the same name and 0 params
20734 and the function is called through the parent).
20736 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20738 * class.cs, rootcontext.cs, typmanager.cs: do not
20741 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20743 * codegen.cs: remove stack for the ec flow branching.
20744 It is already a linked list, so no need.
20746 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20748 * Makefile: Allow custom profiler here.
20750 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20752 * typemanager.cs (LookupType):
20753 - Use a static char [], because split takes
20754 a param array for args, so it was allocating
20756 - Do not store true in a hashtable, it boxes.
20758 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20760 * flowanalysis.cs: bytify common enums.
20762 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20764 * modifiers.cs: Add a new set of flags for the
20765 flags allowed on explicit interface impls.
20766 * cs-parser.jay: catch the use of modifiers in
20767 interfaces correctly.
20768 * class.cs: catch private void IFoo.Blah ().
20770 All related to bug #50572.
20772 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20774 * decl.cs: Rewrite the consistant accessability checking.
20775 Accessability is not linear, it must be implemented in
20776 a tableish way. Fixes #49704.
20778 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20780 * expression.cs: Handle negation in a checked context.
20781 We must use subtraction from zero. Fixes #38674.
20783 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20785 * class.cs: Ignore static void main in DLLs.
20786 * rootcontext.cs: Handle the target type here,
20787 since we are have to access it from class.cs
20788 * driver.cs: account for the above.
20790 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20792 * report.cs: Give line numbers and files if available.
20794 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20796 * driver.cs: Implement /addmodule.
20798 * typemanager.cs: Change 'modules' field so it now contains Modules not
20801 2003-12-20 Martin Baulig <martin@ximian.com>
20803 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20804 (FieldBase.IsAssigned): Removed this field.
20805 (FieldBase.SetAssigned): New public method.
20806 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20808 2003-12-20 Martin Baulig <martin@ximian.com>
20810 * expression.cs (LocalVariableReference.DoResolve): Don't set
20811 `vi.Used' if we're called from DoResolveLValue().
20813 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20814 returns the usage vector it just merged into the current one -
20815 pass this one to UsageWarning().
20816 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20817 of the `EmitContext', don't call this recursively on our children.
20819 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20821 * driver.cs: Implement /target:module.
20823 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20825 * support.cs (CharArrayHashtable): New helper class.
20827 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20828 char arrays, not strings, so we can avoid creating a string in
20829 consume_identifier if the identifier is a keyword.
20831 2003-12-16 Martin Baulig <martin@ximian.com>
20833 * statement.cs (LocalInfo.Assigned): Removed this property.
20834 (LocalInfo.Flags): Removed `Assigned'.
20835 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20836 and uses flow analysis.
20837 (Block.UsageWarning): Made this method private.
20838 (Block.Resolve): Call UsageWarning() if appropriate.
20840 * expression.cs (LocalVariableReference.DoResolve): Always set
20841 LocalInfo.Used here.
20843 2003-12-13 Martin Baulig <martin@ximian.com>
20845 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20846 any value here; we're now using flow analysis to figure out
20847 whether a statement/block returns a value.
20849 2003-12-13 Martin Baulig <martin@ximian.com>
20851 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20853 (FlowBranching.MergeFinally): Don't call
20854 `branching.CheckOutParameters()' here, this is called in
20856 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20857 when adding the `finally' vector.
20859 2003-12-13 Martin Baulig <martin@ximian.com>
20862 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20863 actually work and also fix #48962.
20865 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20867 * decl.cs: Do not check System.Object for nested types,
20868 since we know it does not have any. Big bang for buck:
20871 Run 1: 8.35 seconds
20872 Run 2: 8.32 seconds
20873 corlib: 17.99 seconds
20875 Run 1: 8.17 seconds
20876 Run 2: 8.17 seconds
20877 corlib: 17.39 seconds
20879 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20881 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20882 time we are returning 0 members, so we save alot here.
20884 2003-12-11 Martin Baulig <martin@ximian.com>
20886 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20887 `MergeChild()', also just take the `FlowBranching' as argument;
20888 call Merge() on it and return the result.
20889 (FlowBranching.Merge): We don't need to do anything if we just
20892 2003-12-11 Martin Baulig <martin@ximian.com>
20894 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20895 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20896 Maurer for this idea.
20898 2003-12-11 Martin Baulig <martin@ximian.com>
20900 * flowanalysis.cs (MergeResult): This class is now gone; we now
20901 use the `UsageVector' for this. The reason for this is that if a
20902 branching just has one sibling, we don't need to "merge" them at
20903 all - that's the next step to do.
20904 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20907 2003-12-11 Martin Baulig <martin@ximian.com>
20909 Reworked flow analyis and made it more precise and bug-free. The
20910 most important change is that we're now using a special `Reachability'
20911 class instead of having "magic" meanings of `FlowReturns'. I'll
20912 do some more cleanups and optimizations and also add some more
20913 documentation this week.
20915 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20916 largely reworked this class.
20917 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20918 the new `Reachability' class instead of having "magic" values here.
20919 (FlowBranching): We're now using an instance of `Reachability'
20920 instead of having separate `Returns', `Breaks' etc. fields.
20922 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20923 based on flow analysis; ignore the return value of block.Emit ().
20925 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20927 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20928 if they are private.
20930 2003-12-09 Martin Baulig <martin@ximian.com>
20932 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20933 call them directly on the UsageVector.
20935 2003-12-09 Martin Baulig <martin@ximian.com>
20937 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20938 Changed return type from `FlowReturns' to `Reachability'.
20940 2003-12-09 Martin Baulig <martin@ximian.com>
20942 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20943 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20944 `Reachable' fields with a single `Reachability' one.
20946 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20948 * class.cs (FindMembers): Remove foreach's.
20953 Run 1: 8.74 seconds
20954 Run 2: 8.71 seconds
20957 Run 1: 8.64 seconds
20958 Run 2: 8.58 seconds
20961 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20966 This patch does a few things:
20967 1. EmptyStatement is now a singleton, so it is never reallocated.
20968 2. All blah is EmptyStatement constructs have been changed to
20969 blah == EmptyStatement.Value, which is much faster and valid
20970 now that EmptyStatement is a singleton.
20971 3. When resolving a block, rather than allocating a new array for
20972 the non-empty statements, empty statements are replaced with
20973 EmptyStatement.Value
20974 4. Some recursive functions have been made non-recursive.
20975 Mainly the performance impact is from (3), however (1) and (2) are needed for
20976 this to work. (4) does not make a big difference in normal situations, however
20977 it makes the profile look saner.
20982 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20983 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20984 Total memory allocated: 56397 KB
20987 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20988 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20989 Total memory allocated: 55666 KB
20991 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20993 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20994 than the hashtable in a hashtable version
20996 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20997 we always end up concating a string. This results in a huge perf
20998 loss, because many strings have to be tracked by the GC. In this
20999 patch, we first use a hashtable that works with two keys, so that
21000 the strings do not need to be concat'ed.
21004 Run 1: 8.74 seconds
21005 Run 2: 8.71 seconds
21008 Run 1: 8.65 seconds
21009 Run 2: 8.56 seconds
21011 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21013 * Makefile: Add a new target `do-time' that does a quick and simple
21014 profile, leaving easy to parse output.
21016 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
21018 * codegen.cs (Init): Create the dynamic assembly with
21019 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
21021 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
21023 * support.cs: Make the PtrHashtable use only one
21024 instance of its comparer.
21026 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
21028 * typemanager.cs: Fix lookup of GetNamespaces.
21030 2003-11-29 Miguel de Icaza <miguel@ximian.com>
21032 * expression.cs: Removed redundant line.
21034 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
21035 ArrayLists, use for loops with bounds.
21037 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
21040 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
21041 arraylists, use for loop with bounds.
21043 The above three changes give us a 0.071 second performance
21044 improvement out of 3.294 seconds down to 3.223. On my machine
21045 the above changes reduced the memory usage by 1,387 KB during
21046 compiler bootstrap.
21048 * cs-parser.jay (QualifiedIdentifier): New class used to represent
21049 QualifiedIdentifiers. Before we created a new string through
21050 concatenation, and mostly later on, the result would be
21051 manipulated by DecomposeQI through string manipulation.
21053 This reduced the compiler memory usage for bootstrapping from
21054 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
21055 compile times in 0.05 seconds.
21057 2003-11-28 Dick Porter <dick@ximian.com>
21059 * support.cs: Do string compares with the Invariant culture.
21067 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
21068 the comparison is done with the Invariant culture.
21070 2003-11-27 Miguel de Icaza <miguel@ximian.com>
21072 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
21073 GetEnumerator method.
21075 (ProbeCollectionType): Iterate starting at the most specific type
21076 upwards looking for a GetEnumerator
21078 * expression.cs: Shift count can be up to 31 for int/uint and 63
21081 2003-11-26 Miguel de Icaza <miguel@ximian.com>
21083 * statement.cs (Block.LookupLabel): Also look for the label on the
21084 children blocks. Use a hash table to keep track of visited
21087 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
21088 we actually did transform the other operand, otherwise fall back
21089 to the common codepath that casts to long.
21091 * cs-tokenizer.cs: Use the same code pattern as the int case.
21092 Maybe I should do the parsing myself, and avoid depending on the
21093 Parse routines to get this done.
21095 2003-11-25 Miguel de Icaza <miguel@ximian.com>
21097 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21098 which fixes bug 51347. This time test it.
21100 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
21101 attributes for example can not tell the difference between these.
21102 The difference was only a syntax feature of the language.
21104 * attribute.cs: Apply attributes to delegates.
21106 * delegate.cs: Call the apply attributes method.
21108 2003-11-24 Miguel de Icaza <miguel@ximian.com>
21110 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
21111 comparing 0 vs Byte.MinValue, not the value
21113 (ImplicitConversionRequired): When reporting a conversion error,
21114 use error 31 to print out the constant error instead of the
21117 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21118 which fixes bug 51347.
21120 2003-11-22 Miguel de Icaza <miguel@ximian.com>
21122 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
21123 which fixes the -warnaserror command line option.
21125 2003-11-21 Miguel de Icaza <miguel@ximian.com>
21127 * cfold.cs (DoNumericPromotions): During constant folding of
21128 additions on UIntConstant, special case intconstants with
21129 IntConstants like we do on the expression binary operator.
21131 2003-11-12 Miguel de Icaza <miguel@ximian.com>
21133 * convert.cs (ImplicitReferenceConversion): We were missing a case
21134 (System.Enum are not value types or class types, so we need to
21135 classify them separatedly).
21137 * driver.cs: We do not support error 2007.
21139 2003-11-12 Jackson Harper <jackson@ximian.com>
21141 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
21142 system directory. Also use the full file name so users can
21143 libraries names mscorlib-o-tron.dll in a non system dir.
21145 2003-11-10 Martin Baulig <martin@ximian.com>
21147 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
21148 (TypeManager.InitCoreTypes): Initialize them here, but instead of
21149 calling `ResolveType()' on them, directly assign their `Type'.
21151 2003-11-08 Martin Baulig <martin@ximian.com>
21153 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
21154 return value and the `out parent' parameter.
21155 (TypeContainer.DefineType): Moved the CS0644 check into
21156 GetClassBases(). Don't pass the interface types to the
21157 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
21158 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
21160 * ecore.cs (TypeExpr.IsAttribute): New property.
21161 (TypeExpr.GetInterfaces): New method.
21163 * interface.cs (Interface.GetInterfaceTypeByName): Return a
21164 TypeExpr instead of a Type.
21165 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
21166 (Interface.DefineType): Don't pass the interface types to the
21167 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
21168 them later and then call `TypeBulider.AddInterfaceImplementation()'.
21170 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
21171 instead of a `Type[]'.
21172 (TypeManager.RegisterBuilder): Likewise.
21173 (TypeManager.AddUserInterface): Likewise.
21174 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
21175 `Type[]' and also return a `TypeExpr[]'.
21176 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
21178 2003-11-08 Martin Baulig <martin@ximian.com>
21180 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
21183 2003-11-08 Martin Baulig <martin@ximian.com>
21185 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
21186 TypeManager.ResolveExpressionTypes().
21188 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
21189 instead of an Expression.
21190 (TypeExpr): This is now an abstract base class for `TypeExpression'.
21191 (TypeExpression): New public class; formerly known as `TypeExpr'.
21193 * expression.cs (ComposedCast): Derive from TypeExpr.
21195 * typemanager.cs (TypeManager.system_*_expr): These are now
21196 TypExpr's instead of Expression's.
21197 (TypeManager.ResolveExpressionTypes): New public static function;
21198 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
21201 2003-11-06 Miguel de Icaza <miguel@ximian.com>
21203 * expression.cs (New.DoResolve): Do not dereference value that
21204 might be a null return.
21206 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
21207 sure that the constant value has the right type. Fixes an
21208 unreported bug, similar to 50425.
21210 * const.cs (Const.LookupConstantValue): Call
21211 ImplicitStandardConversionExists before doing a conversion to
21212 avoid havng the TypeManager.ChangeType do conversions.
21214 Reduced the number of casts used
21216 (Const.ChangeType): New routine to enable reuse of the constant
21217 type changing code from statement.
21219 * typemanager.cs (ChangeType): Move common initialization to
21220 static global variables.
21224 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
21225 every value type to go through, even if it was void. Fix that.
21227 * cs-tokenizer.cs: Use is_identifier_start_character on the start
21228 character of the define, and the is_identifier_part_character for
21229 the rest of the string.
21231 2003-11-05 Miguel de Icaza <miguel@ximian.com>
21233 * expression.cs (UnaryMutator.EmitCode): When I updated
21234 LocalVariableReference.DoResolve, I overdid it, and dropped an
21235 optimization done on local variable references.
21237 2003-11-04 Miguel de Icaza <miguel@ximian.com>
21239 * ecore.cs: Convert the return from Ldlen into an int.
21241 2003-10-20 Miguel de Icaza <miguel@ximian.com>
21243 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
21244 the accessibility, this is a special case for toplevel non-public
21245 classes (internal for instance).
21247 2003-10-20 Nick Drochak <ndrochak@gol.com>
21249 * ecore.cs: Fix typo and build. Needed another right paren.
21251 2003-10-19 Miguel de Icaza <miguel@ximian.com>
21253 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
21254 `internal' case regular and protected, but not allowing protected
21255 to be evaluated later. Bug 49840
21257 2003-10-15 Miguel de Icaza <miguel@ximian.com>
21259 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
21260 to kb.Nlast, and not the kb.nFirst to isolate the switch
21263 Extract the underlying type, so enumerations of long/ulong are
21264 treated like long/ulong.
21266 2003-10-14 Miguel de Icaza <miguel@ximian.com>
21268 * expression.cs (New): Overload the meaning of RequestedType to
21269 track the possible creation of the NewDelegate type, since
21270 DoResolve is invoked more than once for new constructors on field
21273 See bugs: #48800 and #37014
21275 * cs-parser.jay (declare_local_constants): Take an arraylist
21276 instead of a single constant.
21278 (local_constant_declaration): It should take a
21279 constant_declarators, not a constant_declarator. Fixes 49487
21281 * convert.cs: Fix error report.
21283 2003-10-13 Jackson Harper <jackson@ximian.com>
21285 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21288 2003-10-09 Martin Baulig <martin@ximian.com>
21290 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21292 (MethodCore.DoDefineParameters): Removed the TypeContainer
21293 argument; use the DeclSpace which was passed to the .ctor instead.
21294 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21295 TypeContainer; we only need a DeclSpace here.
21297 2003-10-09 Martin Baulig <martin@ximian.com>
21299 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21301 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21302 EmitContext's .ctor.
21304 2003-10-09 Martin Baulig <martin@ximian.com>
21306 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21307 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21308 AsAccessible(), moved them as well.
21310 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21312 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21314 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21316 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21318 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21319 generation for >=, as spotted by Paolo, bug 48679.
21320 Patch from David Waite.
21322 * cs-tokenizer.cs: Add handling for #pragma.
21324 * cs-parser.jay: Allow for both yield and yield return in the
21325 syntax. The anti-cobolization of C# fight will go on!
21327 * class.cs (TypeBuilder.DefineType): Catch error condition here
21328 (Parent.DefineType erroring out and returning null).
21330 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21331 coping with enumerations variables, we were mistakenly processing
21332 them as a regular value type instead of built-in types. Fixes the
21335 * typemanager.cs (IsBuiltinOrEnum): New method.
21337 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21339 * cs-parser.jay: Upgrade: yield now needs the return clause.
21341 2003-09-19 Martin Baulig <martin@ximian.com>
21343 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21344 `MemberCache parent' argument. Normally, an interface doesn't
21345 have a parent type except System.Object, but we use this in gmcs
21346 for generic type parameters.
21348 2003-09-18 Martin Baulig <martin@ximian.com>
21350 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21351 on `type.IsInterface'; don't check whether the type has a parent
21352 to determine whether it's an interface.
21354 2003-09-15 Martin Baulig <martin@ximian.com>
21356 * class.cs (TypeContainer.DefineType): Added an error flag to
21357 avoid reporting duplicate CS0146's ("class definition is
21360 * driver.cs (Driver.MainDriver): Abort if
21361 RootContext.ResolveTree() reported any errors.
21363 2003-09-07 Martin Baulig <martin@ximian.com>
21365 * report.cs (Error, Warning): Added overloaded versions which take
21366 a `params object[] args' and call String.Format().
21368 2003-09-07 Martin Baulig <martin@ximian.com>
21370 * decl.cs (DeclSpace..ctor): Don't call
21371 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21372 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21373 (DeclSpace.RecordDecl): New method.
21375 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21377 2003-09-02 Ravi Pratap <ravi@ximian.com>
21379 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21380 value attributes to be applied to ParameterBuilders.
21382 * class.cs (MethodCore.LabelParameters): Make static and more
21383 generic so that it can be used from other places - like interface
21384 methods, for instance.
21386 * interface.cs (Interface.Emit): Call LabelParameters before
21387 emitting attributes on the InterfaceMethod.
21389 2003-08-26 Martin Baulig <martin@ximian.com>
21391 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21392 resolving aliases; fixes #47927.
21394 2003-08-26 Martin Baulig <martin@ximian.com>
21396 * statement.cs (Using.DoResolve): This is internally emitting a
21397 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21398 do not always return. Fixes #47681.
21400 2003-08-26 Martin Baulig <martin@ximian.com>
21402 * decl.cs (MemberCore): Moved WarningNotHiding(),
21403 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21405 (AdditionResult): Make this nested in DeclSpace.
21406 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21407 argument; call NamespaceEntry.Define() unless we're nested in a
21410 * namespace.cs (Namespace.DefineName): New public function. This
21411 is called from DeclSpace's .ctor to add
21412 (Namespace.Lookup): Include DeclSpaces in the lookup.
21414 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21416 * const.cs (Const): Derive from MemberBase, not MemberCore.
21418 2003-08-25 Martin Baulig <martin@ximian.com>
21420 * convert.cs (Convert.ExplicitReferenceConversion): When
21421 converting from an interface type to a class, unbox if the target
21422 type is a struct type. Fixes #47822.
21424 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21426 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21429 2003-08-22 Martin Baulig <martin@ximian.com>
21431 * class.cs (TypeManager.DefineType): When defining a nested type,
21432 call DefineType() on our parent; fixes #47801.
21434 2003-08-22 Martin Baulig <martin@ximian.com>
21436 * class.cs (MethodData.Define): While checking if a method is an
21437 interface implementation, improve the test a bit more to fix #47654.
21439 2003-08-22 Martin Baulig <martin@ximian.com>
21441 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21442 correctly; fixes #47722.
21444 2003-08-22 Martin Baulig <martin@ximian.com>
21446 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21447 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21449 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21451 2003-08-22 Martin Baulig <martin@ximian.com>
21453 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21454 can only be assigned in static constructors. Fixes #47161.
21456 2003-08-22 Martin Baulig <martin@ximian.com>
21458 Rewrote and improved the flow analysis code.
21460 * flowbranching.cs (FlowBranching): Make this class abstract.
21461 (FlowBranching.CreateBranching): New static function to create a
21462 new flow branching.
21463 (FlowBranchingBlock, FlowBranchingException): New classes.
21464 (FlowBranching.UsageVector.Type): New public readonly field.
21465 (FlowBranching.UsageVector.Breaks): Removed the setter.
21466 (FlowBranching.UsageVector.Returns): Removed the setter.
21467 (FlowBranching.UsageVector): Added Break(), Return(),
21468 NeverReachable() and Throw() methods to modify the reachability.
21469 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21470 done by FlowBranching.Merge().
21471 (FlowBranching.UsageVector.MergeChild): New method; merges the
21472 merge result into the current vector.
21473 (FlowBranching.Merge): New abstract method to merge a branching.
21475 2003-08-12 Martin Baulig <martin@ximian.com>
21477 * expression.cs (Indirection.CacheTemporaries): Create the
21478 LocalTemporary with the pointer type, not its element type.
21480 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21482 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21483 token was a keyword or not.
21485 Add `error' options where an IDENTIFIER was expected; Provide
21486 CheckToken and CheckIdentifierToken convenience error reporting
21489 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21491 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21492 NameSpaceEntry NameSpaceEntry.
21494 (LookupInterfaceOrClass): Avoid creating a full qualified name
21495 from namespace and name: avoid doing lookups when we know the
21496 namespace is non-existant. Use new Tree.LookupByNamespace which
21497 looks up DeclSpaces based on their namespace, name pair.
21499 * driver.cs: Provide a new `parser verbose' to display the
21500 exception thrown during parsing. This is turned off by default
21501 now, so the output of a failure from mcs is more graceful.
21503 * namespace.cs: Track all the namespaces defined in a hashtable
21506 (IsNamespace): New method
21508 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21510 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21511 we know that we need to concatenate (full typename can never be
21516 * statement.cs: Use a bitfield; Do not initialize to null things
21517 which are done by the constructor by default.
21519 * cs-parser.jay: bug fix, parameter was 4, not 3.
21521 * expression.cs: Just use the property;
21523 * statement.cs: No need for GetVariableInfo method.
21525 2003-08-08 Martin Baulig <martin@ximian.com>
21527 * flowanalysis.cs (FlowReturns): This is now nested in the
21528 `FlowBranching' class.
21529 (MyBitVector): Moved this here from statement.cs.
21530 (FlowBranching.SiblingType): New enum type.
21531 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21533 2003-08-07 Martin Baulig <martin@ximian.com>
21535 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21536 `FlowBranching' class and called `BranchingType'.
21538 2003-08-07 Martin Baulig <martin@ximian.com>
21540 * flowanalysis.cs: Moved all the control flow analysis code into
21543 2003-08-07 Martin Baulig <martin@ximian.com>
21545 * assign.cs (Assign.DoResolve): `target' must either be an
21546 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21549 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21551 * expression.cs (BinaryMethod): This kind of expression is created by the
21552 Binary class if it determines that the operator has to be handled
21555 (BinaryDelegate): This kind of expression is created if we are
21556 dealing with a + or - operator on delegates.
21558 (Binary): remove method, argumetns, and DelegateOperator: when
21559 dealing with methods,
21561 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21563 * statement.cs (Block): use bitfields for the three extra booleans
21564 we had in use. Remove unused topblock parameter.
21566 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21568 * assign.cs: Drop extra unneeded tests.
21570 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21572 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21574 * statement.cs (Foreach): Use VariableStorage instead of
21577 * codegen.cs (VariableStorage): New class used by clients that
21578 require a variable stored: locals or fields for variables that
21579 need to live across yield.
21581 Maybe provide a convenience api for EmitThis+EmitLoad?
21583 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21586 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21588 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21589 RemapParameterLValue): New methods that are used to turn a
21590 precomputed FieldInfo into an expression like this:
21594 The idea is to use this instead of making LocalVariableReference
21595 have more than one meaning.
21597 * cs-parser.jay: Add error production to BASE.
21599 * ecore.cs: Deal with TypeManager.GetField returning null, which
21600 is now a valid return value.
21602 (FieldExprNoAddress): New expression for Fields whose address can
21605 * expression.cs (LocalVariableReference): During the resolve
21606 phases, create new expressions if we are in a remapping context.
21607 Remove code that dealt with remapping here.
21609 (ParameterReference): same.
21611 (ProxyInstance): New expression, like the `This' expression, but
21612 it is born fully resolved. We know what we are doing, so remove
21613 the errors that are targeted to user-provided uses of `this'.
21615 * statement.cs (Foreach): our variable is now stored as an
21616 Expression; During resolution, follow the protocol, dont just
21617 assume it will return this.
21619 2003-08-06 Martin Baulig <martin@ximian.com>
21621 * support.cs (SeekableStreamReader.cs): New public class.
21623 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21624 SeekableStreamReader instead of the normal StreamReader.
21626 2003-08-04 Martin Baulig <martin@ximian.com>
21628 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21629 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21630 deambiguate casts and delegate invocations.
21631 (parenthesized_expression): Use the new tokens to ensure this is
21632 not a cast of method invocation.
21634 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21635 when reading a `)' and Deambiguate_CloseParens () was previously
21638 * expression.cs (ParenthesizedExpression): New class. This is
21639 just used for the CS0075 test.
21640 (Binary.DoResolve): Check for CS0075.
21642 2003-07-29 Ravi Pratap <ravi@ximian.com>
21644 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21645 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21646 reference comparison.
21648 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21649 examine the ReturnType for equality - this is necessary in the
21650 cases of implicit and explicit operators whose signature also
21651 includes the return type.
21653 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21655 * namespace.cs: Cache the result of the namespace computation,
21656 instead of computing it every time.
21658 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21660 * decl.cs: Use a global arraylist that we reuse over invocations
21661 to avoid excesive memory consumption. Reduces memory usage on an
21662 mcs compile by one meg (45 average).
21664 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21665 private, work around that.
21667 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21669 * literal.cs (IntLiteral): Define Zero and One static literals.
21671 * cs-parser.jay (integer_literal): use static literals to reduce
21672 memory usage for the most used literals (0, 1 and -1). 211kb
21673 reduced in memory usage.
21675 Replace all calls to `new ArrayList' with `new
21676 ArrayList(4)' which is a good average number for most allocations,
21677 and also requires only 16 bytes of memory for its buffer by
21680 This reduced MCS memory usage in seven megabytes for the RSS after
21683 2003-07-28 Ravi Pratap <ravi@ximian.com>
21685 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21686 handle params methods the correct way by forming only one
21687 applicable set with params and normal methods in them. Earlier we
21688 were looking at params methods only if we found no normal methods
21689 which was not the correct thing to do.
21691 (Invocation.BetterFunction): Take separate arguments indicating
21692 when candidate and the best method are params methods in their
21695 This fixes bugs #43367 and #46199.
21697 * attribute.cs: Documentation updates.
21699 (CheckAttribute): Rename to CheckAttributeTarget.
21700 (GetValidPlaces): Rename to GetValidTargets.
21702 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21703 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21707 2003-07-28 Martin Baulig <martin@ximian.com>
21709 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21710 name when looking up the base class of a nested class. Fixes #46977.
21712 2003-07-26 Martin Baulig <martin@ximian.com>
21714 * expression.cs (Indexers.Indexer): New nested struct; contains
21715 getter, setter and the indexer's type.
21716 (Indexers.Properties): This is now an ArrayList of
21717 Indexers.Indexer's.
21718 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21719 indexer doesn't have any getters.
21721 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21722 for embedded property and indexer assignments.
21724 2003-07-26 Martin Baulig <martin@ximian.com>
21726 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21727 preprocessor directive is not the first non-whitespace character
21730 2003-07-26 Martin Baulig <martin@ximian.com>
21732 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21733 namespace parsing, follow the spec more closely.
21735 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21736 NamespaceEntry.Lookup().
21738 2003-07-25 Martin Baulig <martin@ximian.com>
21740 * MethodCore.cs (OverridesSomething): New public field; it's set
21741 from TypeContainer.DefineMembers if this method overrides
21742 something (which doesn't need to be a method). Fix #39462.
21744 2003-07-25 Ravi Pratap <ravi@ximian.com>
21746 * typemanager.cs (GetMembers): Ensure that the list of members is
21747 reversed. This keeps things in sync.
21749 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21750 find an AttributeUsage attribute.
21752 * expression.cs (Invocation.OverloadResolve): Perform the check
21753 which disallows Invoke to be directly called on a Delegate.
21755 (Error_InvokeOnDelegate): Report error cs1533.
21757 2003-07-25 Martin Baulig <martin@ximian.com>
21759 * expression.cs (Indexers.GetIndexersForType): Only look in the
21760 interface hierarchy if the requested type is already an
21761 interface. Fixes #46788 while keeping #46502 fixed.
21763 2003-07-25 Martin Baulig <martin@ximian.com>
21765 * class.cs (TypeContainer.DefineMembers): Check whether all
21766 readonly fields have been assigned and report warning CS0649 if
21769 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21772 2003-07-24 Ravi Pratap <ravi@ximian.com>
21774 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21775 returned from GetMethods to make things consistent with the
21776 assumptions MCS makes about ordering of methods.
21778 This should comprehensively fix bug #45127 and it does :-)
21780 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21781 ordering is actually reverse.
21783 * Clean up some debug messages I left lying around.
21785 * interface.cs (Populate*): Get rid of code which emits attributes
21786 since the stage in which we emit attributes is the 'Emit' stage,
21787 not the define stage.
21789 (Emit): Move attribute emission for interface members here.
21791 2003-07-22 Ravi Pratap <ravi@ximian.com>
21793 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21794 closely: we eliminate methods in base types when we have an
21795 applicable method in a top-level type.
21797 Please see section 14.5.5.1 for an exact description of what goes
21800 This fixes bug #45127 and a host of other related to corlib compilation.
21802 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21803 array is the method corresponding to the top-level type (this is
21804 because of the changes made to icall.c) so we change this
21807 (MethodGroupExpr.Name): This too.
21809 * typemanager.cs (GetElementType): New method which does the right
21810 thing when compiling corlib.
21812 * everywhere: Make use of the above in the relevant places.
21814 2003-07-22 Martin Baulig <martin@ximian.com>
21816 * cs-parser.jay (invocation_expression): Moved
21817 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21818 `cast_expression', but create a InvocationOrCast which later
21819 resolves to either an Invocation or a Cast.
21821 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21822 method; call this before EmitStatement() to make sure that this
21823 expression can be used as a statement.
21825 * expression.cs (InvocationOrCast): New class; resolves to either
21826 an Invocation or a Cast.
21828 * statement.cs (StatementExpression): Call ResolveStatement() on
21829 the ExpressionStatement before emitting it.
21831 2003-07-21 Martin Baulig <martin@ximian.com>
21833 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21834 `ref' and `out' attributes match; fixes #46220.
21835 (MemberAccess.ResolveMemberAccess): You can't reference a type
21836 through an expression; fixes #33180.
21837 (Indexers.GetIndexersForType): Don't return the indexers from
21838 interfaces the class implements; fixes #46502.
21840 2003-07-21 Martin Baulig <martin@ximian.com>
21842 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21843 CS0661 checks; fixes bug #30442.
21845 2003-07-21 Martin Baulig <martin@ximian.com>
21847 * decl.cs (AdditionResult): Added `Error'.
21849 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21851 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21852 makes cs0031.cs actually work.
21854 2003-07-20 Martin Baulig <martin@ximian.com>
21856 * namespace.cs: Fixed that bug which caused a crash when compiling
21857 the debugger's GUI.
21859 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21861 * typemanager.cs (LookupTypeReflection): Never expose types which
21862 are NotPublic, NestedPrivate, NestedAssembly, or
21863 NestedFamANDAssem. We used to return these, and later do a check
21864 that would report a meaningful error, but the problem is that we
21865 would not get the real match, if there was a name override.
21867 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21869 * namespace.cs (Namespace, Name): Do not compute the namespace
21870 name dynamically, compute it in the constructor. This reduced
21871 memory usage by 1697 KB.
21873 * driver.cs: Use --pause to pause at the end.
21875 2003-07-17 Peter Williams <peter@newton.cx>
21877 * Makefile: Change the name of the test target so that it doesn't
21878 conflict with the recursive test target.
21880 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21882 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21883 AddressOf): Do not use EmitThis, that was wrong, use the actual
21886 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21888 * class.cs (MethodData.Define): While checking if a method is an
21889 interface implementation, improve the test: If we are not public
21890 (use new test here: use the computed MethodAttributes directly,
21891 instead of the parsed modifier flags) check if the `implementing'
21892 method comes from an interface or not.
21894 * pending.cs (VerifyPendingMethods): Slightly better error
21897 * makefile: add test target that does the mcs bootstrap.
21899 2003-07-16 Ravi Pratap <ravi@ximian.com>
21901 * interface.cs (Define): Do nothing here since there are no
21902 members to populate etc. Move the attribute emission out of here
21903 since this was just totally the wrong place to put it. Attribute
21904 application happens during the 'Emit' phase, not in the 'Define'
21907 (Emit): Add this method and move the attribute emission here
21909 * rootcontext.cs (EmitCode): Call the Emit method on interface
21912 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21914 * expression.cs (OverloadResolve): Report error only if Location
21915 is not 'Null' which means that there was a probe going on.
21917 2003-07-14 Martin Baulig <martin@ximian.com>
21919 * expression.cs (ConditionalLogicalOperator): New public class to
21920 implement user defined conditional logical operators.
21921 This is section 14.11.2 in the spec and bug #40505.
21923 2003-07-14 Martin Baulig <martin@ximian.com>
21925 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21927 2003-07-14 Martin Baulig <martin@ximian.com>
21929 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21931 * ecore.cs (IVariable.VerifyFixed): New interface method.
21933 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21934 operator, check whether the variable is actually fixed. Fixes bug
21935 #36055. Set a variable definitely assigned when taking its
21936 address as required by the spec.
21938 * statement.cs (LocalInfo.IsFixed): New field.
21939 (LocalInfo.MakePinned): Set `IsFixed' to true.
21941 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21943 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21944 for .ctors, ensure that we only ask for members declared in the
21945 attribute type (BindingFlags.DeclaredOnly).
21949 * expression.cs (Error_WrongNumArguments): Report error 1501
21950 correctly the way CSC does.
21952 2003-07-13 Martin Baulig <martin@ximian.com>
21954 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21955 lookup on the fully qualified name, to make things like "X.X" work
21956 where "X.X" is a fully qualified type name, but we also have a
21957 namespace "X" in the using list. Fixes #41975.
21959 2003-07-13 Martin Baulig <martin@ximian.com>
21961 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21962 function. If we're a CompoundAssign, we need to create an embedded
21963 CompoundAssign, not an embedded Assign.
21964 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21967 2003-07-13 Martin Baulig <martin@ximian.com>
21969 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21970 work to fix bug #46088.
21972 2003-07-13 Ravi Pratap <ravi@ximian.com>
21974 * class.cs (Operator.Emit): Do not emit attributes here - it is
21975 taken care of by the Method class that we delegate too. This takes
21976 care of bug #45876.
21978 2003-07-10 Martin Baulig <martin@ximian.com>
21980 * expression.cs (TypeOfVoid): New class.
21981 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21983 2003-07-10 Martin Baulig <martin@ximian.com>
21985 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21988 2003-07-10 Martin Baulig <martin@ximian.com>
21990 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21991 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21993 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21995 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21997 2003-07-10 Martin Baulig <martin@ximian.com>
21999 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
22000 of decimal. Fixes #42850.
22002 NOTE: I also fixed the created byte blob, but this doesn't work on
22003 the MS runtime and csc never produces any byte blobs for decimal
22006 2003-07-10 Martin Baulig <martin@ximian.com>
22008 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
22009 structs; fixes #32068.
22010 (Block.AddChildVariableNames): Fixed #44302.
22012 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22014 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
22016 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22018 * attribute.cs: And this test is onger needed.
22020 2003-07-08 Martin Baulig <martin@ximian.com>
22022 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
22023 inaccessible types. Fixes #36313.
22025 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
22027 * namespace.cs (NamespaceEntry): Create implicit entries for all
22028 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
22029 implicit entries for N1.N2 and N1.
22031 2003-07-08 Martin Baulig <martin@ximian.com>
22033 Rewrote the handling of namespaces to fix a lot of the issues
22034 wrt. `using' aliases etc.
22036 * namespace.cs (Namespace): Splitted this class into a
22037 per-assembly `Namespace' and a per-file `NamespaceEntry'.
22039 * typemanager.cs (TypeManager.IsNamespace): Removed.
22040 (TypeManager.ComputeNamespaces): Only compute namespaces from
22041 loaded assemblies here, not the namespaces from the assembly we're
22042 currently compiling.
22044 2003-07-08 Martin Baulig <martin@ximian.com>
22046 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
22048 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22050 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
22053 I thought about the memory savings here, but LookupTypeReflection
22054 is used under already very constrained scenarios. Compiling
22055 corlib or mcs only exposes one hit, so it would not really reduce
22056 any memory consumption.
22058 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22060 * typemanager.cs: fixes bug #45889 by only adding public types from
22061 other assemblies to the list of known types.
22063 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22065 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
22066 on the type we resolved.
22068 2003-07-05 Martin Baulig <martin@ximian.com>
22070 * pending.cs (PendingImplementation.ParentImplements): Don't
22071 create the proxy if the parent is abstract.
22073 * class.cs (TypeContainer.DefineIndexers): Process explicit
22074 interface implementations first. Fixes #37714.
22076 2003-07-04 Miguel de Icaza <miguel@ximian.com>
22078 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
22079 defined recursively; but since we modify the input parameters
22080 (left is set to `this' temporarily), we reset this value if the
22081 left_is_explicit is false, which gives the original semantics to
22084 * literal.cs (NullPointer): new class used to represent a null
22085 literal in a pointer context.
22087 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
22088 type is a pointer, use a NullPointer object instead of a
22089 NullLiteral. Closes 43687
22091 (ExplicitConversion): Convert pointer values using
22092 the conv opcode to the proper type.
22094 * ecore.cs (New): change ValueTypeVariable property into a method,
22095 that returns whether the valuetype is suitable for being used.
22097 * expression.cs (Binary.DoNumericPromotions): Only return if we
22098 the int constant was a valid uint, and we can return both left and
22099 right as uints. If not, we continue processing, to trigger the
22100 type conversion. This fixes 39018.
22102 * statement.cs (Block.EmitMeta): During constant resolution, set
22103 the CurrentBlock property on the emitcontext, so that we resolve
22104 constants propertly.
22106 2003-07-02 Martin Baulig <martin@ximian.com>
22108 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
22109 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
22111 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
22112 than emitting it here.
22114 * statement.cs: Fixed some more flow analysis bugs.
22116 2003-07-02 Martin Baulig <martin@ximian.com>
22118 * class.cs (MethodData.Define): When implementing interface
22119 methods, set Final unless we're Virtual.
22121 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
22122 check work for interface methods.
22124 2003-07-01 Martin Baulig <martin@ximian.com>
22126 * ecore.cs (EmitContext.This): Replaced this property with a
22127 GetThis() method which takes a Location argument. This ensures
22128 that we get the correct error location for a CS0188.
22130 2003-07-01 Miguel de Icaza <miguel@ximian.com>
22132 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
22133 ImplicitStandardConversion.
22135 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
22137 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
22139 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
22142 2003-06-30 Miguel de Icaza <miguel@ximian.com>
22144 * class.cs (Constructor.Define): Turn off initlocals for unsafe
22147 (MethodData.Define): Turn off initlocals for unsafe methods.
22149 2003-06-29 Miguel de Icaza <miguel@ximian.com>
22151 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
22152 complete; Fixes #37521.
22154 * delegate.cs: Use Modifiers.TypeAttr to compute the
22155 TypeAttributes, instead of rolling our own. This makes the flags
22156 correct for the delegates.
22158 2003-06-28 Miguel de Icaza <miguel@ximian.com>
22160 * class.cs (Constructor.Define): Set the private flag for static
22161 constructors as well.
22163 * cs-parser.jay (statement_expression): Set the return value to
22164 null, to avoid a crash when we catch an error.
22166 2003-06-24 Miguel de Icaza <miguel@ximian.com>
22168 * cs-parser.jay: Applied patch from Jackson that adds support for
22169 extern and unsafe modifiers to destructor declarations.
22171 * expression.cs: Report error 21 if the user is trying to index a
22174 * driver.cs: Add an error message, suggested by the bug report.
22176 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
22177 if we do not have a ": this ()" constructor initializer. Fixes 45149
22179 2003-06-14 Miguel de Icaza <miguel@ximian.com>
22181 * namespace.cs: Add some information to reduce FAQs.
22183 2003-06-13 Miguel de Icaza <miguel@ximian.com>
22185 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
22186 underlying enumeration types. Fixes #43915.
22188 * expression.cs: Treat ushort/short as legal values to be used in
22189 bitwise operations.
22191 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
22193 * delegate.cs: transfer custom attributes for paramenters from
22194 the delegate declaration to Invoke and BeginInvoke.
22196 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
22198 * attribute.cs: handle custom marshalers and emit marshal info
22201 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
22203 * makefile.gnu: Added anonymous.cs to the compiler sources.
22205 2003-05-28 Miguel de Icaza <miguel@ximian.com>
22207 * iterators.cs: Change the name of the proxy class to include two
22210 * cs-parser.jay: Update grammar to include anonymous methods.
22212 * anonymous.cs: new file.
22214 2003-05-27 Miguel de Icaza <miguel@ximian.com>
22216 * class.cs (Field.Define): Add missing test for pointers and
22219 2003-05-27 Ravi Pratap <ravi@ximian.com>
22221 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
22222 we use the stobj opcode.
22224 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
22225 since it wasn't the correct fix.
22227 It still is puzzling that we are required to use stobj for IntPtr
22228 which seems to be a ValueType.
22230 2003-05-26 Miguel de Icaza <miguel@ximian.com>
22232 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
22233 during regular simple name resolution. Now, the trick is that
22234 instead of returning for processing the simplename, we do a
22235 TypeManager.LookupType (ie, a rooted lookup as opposed to a
22236 contextual lookup type). If a match is found, return that, if
22237 not, return for further composition.
22239 This fixes long-standing 30485.
22241 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
22242 using the address to initialize an object, do an Stobj instead of
22243 using the regular Stelem.
22245 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
22246 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
22247 Because if we are a BaseIndexerAccess that value will be true.
22250 * statement.cs (GotoCase.Resolve): Return after reporting an
22251 error, do not attempt to continue.
22253 * expression.cs (PointerArithmetic.Emit): If our operand is a
22254 long, convert our constants to match the operand before
22255 multiplying. Convert to I type before adding. Fixes 43670.
22257 2003-05-14 Ravi Pratap <ravi@ximian.com>
22259 * enum.cs (ImplicitConversionExists) : Rename to
22260 ImplicitEnumConversionExists to remove ambiguity.
22262 * ecore.cs (NullCast): New type of cast expression class which
22263 basically is very similar to EmptyCast with the difference being
22264 it still is a constant since it is used only to cast a null to
22266 (eg. (string) null)
22268 * convert.cs (ImplicitReferenceConversion): When casting a null
22269 literal, we return a NullCast.
22271 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22272 should be around anymore.
22274 The renaming (reported was slightly wrong). Corrections:
22276 ConvertImplicitStandard -> ImplicitConversionStandard
22277 ConvertExplicitStandard -> ExplicitConversionStandard
22279 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22280 before passing them in !
22282 * convert.cs (ImplicitConversionStandard): When comparing for
22283 equal expr and target types, ensure that expr is not a
22286 In general, we must not be checking (expr_type ==
22287 target_type) in the top level conversion methods
22288 (ImplicitConversion, ExplicitConversion etc). This checking is
22289 done in the methods that they delegate to.
22291 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22293 * convert.cs: Move Error_CannotConvertType,
22294 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22295 ImplicitNumericConversion, ImplicitConversionExists,
22296 ImplicitUserConversionExists, StandardConversionExists,
22297 FindMostEncompassedType, FindMostSpecificSource,
22298 FindMostSpecificTarget, ImplicitUserConversion,
22299 ExplicitUserConversion, GetConversionOperators,
22300 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22301 TryImplicitIntConversion, Error_CannotConvertImplicit,
22302 ConvertImplicitRequired, ConvertNumericExplicit,
22303 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22304 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22307 Perform the following renames:
22309 StandardConversionExists -> ImplicitStandardConversionExists
22310 ConvertImplicit -> ImplicitConversion
22311 ConvertImplicitStandard -> ImplicitStandardConversion
22312 TryImplicitIntConversion -> ImplicitIntConversion
22313 ConvertImplicitRequired -> ImplicitConversionRequired
22314 ConvertNumericExplicit -> ExplicitNumericConversion
22315 ConvertReferenceExplicit -> ExplicitReferenceConversion
22316 ConvertExplicit -> ExplicitConversion
22317 ConvertExplicitStandard -> ExplicitStandardConversion
22319 2003-05-19 Martin Baulig <martin@ximian.com>
22321 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22322 (TypeInfo): Added support for structs having structs as fields.
22324 * ecore.cs (FieldExpr): Implement IVariable.
22325 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22326 VariableInfo for the field.
22328 2003-05-18 Martin Baulig <martin@ximian.com>
22330 * expression.cs (This.DoResolve): Report a CS0027 if we're
22331 emitting a field initializer.
22333 2003-05-18 Martin Baulig <martin@ximian.com>
22335 * expression.cs (This.ResolveBase): New public function.
22336 (This.DoResolve): Check for CS0188.
22338 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22341 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22342 `instance_expression' to null if we don't have any non-static
22345 2003-05-18 Martin Baulig <martin@ximian.com>
22347 Reworked the way how local variables and parameters are handled by
22348 the flow analysis code.
22350 * statement.cs (TypeInfo, VariableMap): New public classes.
22351 (VariableInfo): New public class. This is now responsible for
22352 checking whether a variable has been assigned. It is used for
22353 parameters and local variables.
22354 (Block.EmitMeta): Take the InternalParameters as argument; compute
22355 the layout of the flow vectors here.
22356 (Block.LocalMap, Block.ParameterMap): New public properties.
22357 (FlowBranching): The .ctor doesn't get the InternalParameters
22358 anymore since Block.EmitMeta() now computes the layout of the flow
22360 (MyStructInfo): This class is now known as `StructInfo' and nested
22361 in `TypeInfo'; we don't access this directly anymore.
22363 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22364 property and removed IsAssigned(), IsFieldAssigned(),
22365 SetAssigned() and SetFieldAssigned(); we now call them on the
22366 VariableInfo so we don't need to duplicate this code everywhere.
22368 * expression.cs (ParameterReference): Added `Block block' argument
22370 (LocalVariableReference, ParameterReference, This): The new
22371 VariableInfo class is now responsible for all the definite
22374 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22375 IsParameterAssigned, SetParameterAssigned): Removed.
22377 2003-05-18 Martin Baulig <martin@ximian.com>
22379 * typemanager.cs (InitCoreTypes): Try calling
22380 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22381 the 3-args-version. Corlib now also needs our `void_type'.
22382 (GetMethod): Added overloaded version which takes an optional
22383 `bool report_errors' to allow lookups of optional methods.
22385 2003-05-12 Martin Baulig <martin@ximian.com>
22387 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22388 only used for locals and not for parameters.
22390 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22392 * support.cs (InternalParameters.ParameterType): Return the
22393 ExternalType of the parameter.
22395 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22398 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22400 * class.cs (MethodData.Define): Do not set the `newslot' on
22401 interface members, if they are also flagged as "override".
22403 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22404 better code for ++i and i++. This only works for static fields
22405 and local variables.
22407 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22408 want to pull the DeclSpace out of the builder_to_declspace instead
22409 of the TypeBuilder (like in TypeContainer.FindMembers).
22411 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22412 instead of LookupTypeContainer. Fixes the crash on .NET for
22413 looking up interface members.
22415 * const.cs: Create our own emit context during the Definition
22416 stage, so that constants are evaluated in the proper context, when
22417 a recursive definition happens.
22419 2003-05-11 Martin Baulig <martin@ximian.com>
22421 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22422 new block for a switch section.
22423 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22424 the adding/lookup in the switch block. Fixes #39828.
22426 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22428 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22429 functionality: I needed to convert the data after I had performed
22430 the add/sub operation into the operands type size.
22432 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22433 pass the type for the box operation, otherwise the resulting
22434 object would have been of type object.
22436 (BoxedCast): Add constructor to specify the type to box as.
22438 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22440 * iterators.cs: I was reusing the `count' variable inadvertently,
22441 take steps to not allow this to happen.
22443 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22445 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22446 by creating an array at the point where the params starts and
22447 putting all those arguments there, then adjusting the size of the
22450 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22452 * expression.cs (New.AddressOf): Implement interface
22453 IMemoryLocation. This is used when the `new' operator is used in
22454 the context of an invocation to a method on a value type.
22456 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22459 * namespace.cs: Also check the using aliases here.
22461 * driver.cs: Move the test for using validity after the types have
22462 been entered, so we do a single pass that also includes the using
22465 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22466 in the regular case. CreateSiblingForFinally is doing extra
22469 * attribute.cs (GetAttributeArgumentExpression): Store the result
22470 on an out value, and use the return value to indicate failure
22471 instead of using null (which is a valid return for Constant.GetValue).
22473 * statement.cs: Perform the analysis flow for the increment
22474 portion after the statement, because this will be the real flow of
22475 execution. Fixes #42385
22477 * codegen.cs (EmitContext.EmitArgument,
22478 EmitContext.EmitStoreArgument): New helper functions when the
22479 RemapToProxy flag is set.
22481 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22484 Add support for remapping parameters.
22486 * iterators.cs: Propagate parameter values; Store parameter
22487 values in the proxy classes.
22489 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22491 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22492 need a proxy reference; I do not know what I was thinking
22494 * cs-parser.jay (constructor_initializer): catch another error,
22495 and display nice message.
22497 (field_declaration): catch void field declaration
22498 to flag a better error.
22500 * class.cs (MemberBase.CheckBase): Report an error instead of a
22501 warning if a new protected member is declared in a struct.
22502 (Field.Define): catch the error of readonly/volatile.
22504 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22506 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22507 volatile variable is taken
22509 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22511 * statement.cs (Fixed.Resolve): Report an error if we are not in
22514 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22516 * typemanager.cs: reuse the code that handles type clashes for
22517 delegates and enumerations.
22519 * class.cs (Report28): Always report.
22521 * expression.cs (EncodeAsAttribute): Allow nulls here.
22523 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22525 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22526 the functionality for testing whether an expression is valid for
22527 an attribute here. Also handle the case of arrays of elements
22530 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22531 encoding a linear array into an array of objects that are suitable
22532 to be passed to an CustomAttributeBuilder.
22534 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22536 * ecore.cs: (FieldExpr): Handle field remapping here.
22538 * iteratators.cs: Pass the instance variable (if the method is an
22539 instance method) to the constructors, so we can access the field
22540 variables on the class.
22542 TODO: Test this with structs. I think the THIS variable on
22543 structs might have to be a pointer, and not a refenrece
22545 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22547 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22548 local variables to fields in a proxy class.
22550 * iterators.cs (PopulateProxy): Rename our internal fields to
22552 Create a <THIS> field if we are an instance method, so we can
22553 reference our parent container variables.
22554 (MapVariable): Called back from the EmitContext code to enter a
22555 new variable to field mapping into the proxy class (we just create
22559 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22560 for using the remapped locals to fields.
22562 I placed the code here, because that gives the same semantics to
22563 local variables, and only changes the Emit code.
22565 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22566 statements inside iterators.
22567 (VariableInfo): Add a FieldBuilder for the cases when we are
22568 remapping local variables to fields in a proxy class
22570 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22571 current_block != null.
22573 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22574 not cope with strings, as it has been moved to the
22575 TableSwitchEmit. Fixed bug in switch generation.
22577 * expression.cs (New.DoResolve): Provide more context for the user
22578 when reporting an error.
22580 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22583 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22584 check the permissions for it. Note than in a type-resolution
22585 context the check was already present in DeclSpace.ResolveType,
22586 but was missing from the MemberAccess.
22588 (ArrayCreation.CheckIndices): warn if the user has
22589 more nested levels of expressions, but there are no more
22590 dimensions specified. Avoids crash on bug 41906.
22592 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22594 * statement.cs (Block): replace Implicit bool, for a generic
22596 New flag: `Unchecked'. This is used during the EmitMeta phase
22597 (which is out-of-line with the regular Resolve/Emit process for a
22598 statement, as this is done ahead of time, but still gets a chance
22599 to call constant resolve).
22601 (Block.Flags): new enum for adding a new flag.
22603 (Block.EmitMeta): track the state of unchecked.
22605 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22606 to enable constant resolution to work there as well.
22608 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22610 * typemanager.cs (ienumerable_type): Also look up
22611 System.Collections.IEnumerable.
22613 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22615 TODO: Test more than one conditional per method.
22617 * class.cs (Indexer.Define): Report the location where the user is
22618 referencing the unsupported feature.
22620 (MethodData): Overload the use of `conditionals' to
22621 minimize the creation of needless ArrayLists. This saves roughly
22622 212kb on my machine.
22624 (Method): Implement the new IIteratorContainer interface.
22625 (Method.SetYields): Implement the method by setting the ModFlags
22626 to contain METHOD_YIELDS.
22628 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22629 which just got set to null.
22631 * iterators.cs: New file.
22633 (Yield, YieldBreak): New statements.
22635 * statement.cs (Return.Resolve): Flag an error if we are used in
22636 an iterator method.
22638 * codegen.cs (InIterator): New flag set if the code is being
22639 compiled in an iterator method.
22641 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22642 internal modifier, and we just use it to avoid adding extra
22643 fields, as this is seldom used.
22645 * cs-parser.jay: Add yield_statement (yield and yield break).
22647 * driver.cs: New flag -v2 to turn on version 2 features.
22649 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22650 hashtable when v2 is enabled.
22652 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22654 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22655 there is already a namespace defined with this name.
22657 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22658 people upgraded their corlibs.
22660 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22661 always use fully qualified types, no need to use the compiler
22664 (TypeManager.IsNamespace): Use binarysearch.
22666 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22667 AddDelegate): I did not quite use the new IsValid API properly: I
22668 have to pass the short-name and the fullname. I was passing only
22669 the basename instead of the fullname sometimes.
22671 (TypeContainer.DefineType): call NamespaceClash.
22673 * interface.cs (Interface.DefineType): use NamespaceClash before
22676 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22679 * enum.cs: (Enum.DefineType): use NamespaceClash before
22682 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22683 speed increase. First, use the negative_hits cache when we get a
22684 negative. Second, add the type with its full original name
22685 instead of the new . and + encoded name (reflection uses + to
22686 separate type from a nested type). Use LookupTypeReflection
22687 directly which bypasses the type->name hashtable (that we already
22688 know does not contain the type.
22690 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22691 location/container type.
22693 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22695 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22697 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22699 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22700 method is being referenced in the method group from a static
22701 context, and report error 120 if so.
22703 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22706 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22707 is created, we create the A namespace).
22709 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22712 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22714 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22715 invocation to ModuleBuilder.GetType with the same values will
22716 return a new type instance, so we need to cache its return
22719 * expression.cs (Binary.ResolveOperator): Only allow the compare
22720 operators on enums if they are of the same type.
22722 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22723 types of ValueType on their own case. Before we were giving them
22724 the same treatment as objects.
22726 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22727 fullname. Short name is used to compare against container name.
22728 Fullname is used to check against defined namespace names.
22730 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22731 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22733 (Method.CheckBase): Call parent.
22734 (MemberBase.CheckBase): Check for protected members on sealed
22736 (PropertyBase.CheckBase): Call parent.
22737 (Field.Define): Call parent.
22739 * report.cs: Negative error codes are now mapped to 8000 - code,
22740 so that the display is render more nicely.
22742 * typemanager.cs: Do not use try/catch, instead report a regular
22745 (GetPointerType, GetReferenceType): These methods provide
22746 mechanisms to obtain the T* and T& from a T. We had the code
22747 previously scattered around the code base, and it also used
22748 TypeManager.LookupType that would go through plenty of caches.
22749 This one goes directly to the type source.
22751 In some places we did the Type.GetType followed by
22752 ModuleBuilder.GetType, but not in others, so this unifies the
22753 processing as well.
22755 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22756 statements now that we have namespace information.
22758 * typemanager.cs (IsNamespace): New method, returns whether the
22759 string presented is a namespace or not.
22761 (ComputeNamespaces): New public entry point, computes the list of
22762 available namespaces, using the GetNamespaces API call in Mono, or
22763 the slower version in MS.NET.
22765 Now before we start the semantic analysis phase, we have a
22766 complete list of namespaces including everything that the user has
22769 Deleted old code to cache namespaces in .nsc files.
22771 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22773 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22774 class/struct location definition Location for the implicit
22775 constructor location.
22777 (Operator.Define): Use the location of the operator for the
22778 implicit Method definition.
22780 (Constructor.Emit): use the constructor location for the implicit
22781 base initializer constructor.
22783 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22784 and the Expression class now contains two new methods:
22786 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22787 isolate type lookup from the rest of the resolution process.
22789 Since we use Expressions to hold type definitions due to the way
22790 we parse the input we have historically overloaded Resolve to
22791 perform the Type lookups if a special flag is passed. Now this is
22792 eliminated and two methods take their place.
22794 The differences in the two methods between xStep and xTerminal is
22795 that xStep is involved in our current lookup system that uses
22796 SimpleNames to compose a name, while xTerminal is used just to
22797 catch the case where the simplename lookup failed.
22799 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22801 * expression.cs (ResolveMemberAccess): Remove redundant code.
22802 TypeExpr expressions are always born fully resolved.
22804 * interface.cs (PopulateMethod): Do not lookup the types twice.
22805 We were doing it once during SemanticAnalysis and once during
22808 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22809 in local variable type definitions, were being returned as a
22810 SimpleName (we decomposed everything into a string), that is
22811 because primary_expression was being used instead of a type in the
22812 grammar (reduce/reduce conflicts).
22814 The part that was wrong is that we converted the expression into a
22815 string (an oversimplification in one hand, compounded with primary
22816 expressions doing string concatenation).
22822 Would return "A.B.C[]" as a SimpleName. This stopped things like
22823 using clauses from working on this particular context. And a type
22824 was being matched directly against "A.B.C[]".
22826 We now use the correct approach, and allow for ComposedCast to be
22827 part of the unary expression. So the "A.B.C []" become a composed
22828 cast of "A.B.C" (as a nested group of MemberAccess with a
22829 SimpleName at the end) plus the rank composition "[]".
22833 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22835 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22836 for the access level checking.
22838 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22839 `TypeContainer container', because I kept getting confused when I
22840 was debugging this code.
22842 * expression.cs (Indexers): Instead of tracking getters/setters,
22843 we now track them in parallel. We create one arraylist less, but
22844 most importantly it is possible now for the LValue code to find a
22845 matching get for a set.
22847 (IndexerAccess.DoResolveLValue): Update the code.
22848 GetIndexersForType has been modified already to extract all the
22849 indexers from a type. The code assumed it did not.
22851 Also make the code set the correct return type for the indexer.
22852 This was fixed a long time ago for properties, but was missing for
22853 indexers. It used to be void_type.
22855 (Binary.Emit): Test first for doubles instead of
22856 floats, as they are more common.
22858 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22859 when dealing with floats and the <=, >= operators. This fixes bug
22862 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22863 to load the array value by emitting a load on the foreach variable
22864 type. This was incorrect.
22866 We now emit the code to load an element using the the array
22867 variable type, and then we emit the conversion operator.
22871 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22873 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22875 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22877 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22878 test for protection before we test for signatures.
22880 (MethodSignature.ToString): implement.
22882 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22883 to the case where we reduced into a LongConstant.
22885 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22886 depend on whether the information is acurrate, because the
22887 Microsoft runtime will always claim that the array type is public,
22888 regardless of the real state.
22890 If the type is a pointer, another problem happens: the type is
22891 reported as non-public in Microsoft.
22893 In both cases we have to call CheckAccessLevel recursively with
22894 the underlying type as the argument to be tested.
22896 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22898 * assign.cs (Assign.Emit): If we are dealing with a compound
22899 assignment expression, we should use the code path that stores the
22900 intermediate result in a temporary value. This fixes #40903.
22902 *expression.cs (Indirection.ToString): Provide ToString method for
22905 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22907 * class.cs: Null out fields holding references to Block objects so
22908 they can be garbage collected.
22910 * expression.cs (OverloadResolve): Remove unused local.
22912 2003-04-07 Martin Baulig <martin@ximian.com>
22914 * codegen.cs (EmitContext.CurrentFile): New public field.
22915 (EmitContext.Mark): Use the CurrentFile to check whether the
22916 location is in the correct file.
22917 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22919 2003-04-07 Martin Baulig <martin@ximian.com>
22921 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22923 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22924 location. [FIXME: The location argument which gets passed to this
22925 method is sometimes wrong!]
22927 2003-04-07 Nick Drochak <ndrochak@gol.com>
22929 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22931 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22933 * expression.cs (Indirection.EmitAssign): We were using the
22934 temporary, but returning immediately instead of continuing the
22937 2003-04-06 Martin Baulig <martin@ximian.com>
22939 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22940 if it's a nested child, but also deriving from the outer class.
22943 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22944 nested child, but also deriving from the outer class. See
22946 (FilterWithClosure): We may access private members of the outer
22947 class if we're a nested child and deriving from the outer class.
22948 (RealMemberLookup): Only set `closure_private_ok' if the
22949 `original_bf' contained BindingFlags.NonPublic.
22951 2003-04-05 Martin Baulig <martin@ximian.com>
22953 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22955 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22957 * class.cs (Event.Define): Do not allow abstract events to have
22960 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22962 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22963 block in event declarations.
22965 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22966 value type, get its address.
22968 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22969 leaving a class on the stack instead of a boolean value (int
22970 0/1). Change the code so we compare against null, and then the
22971 result against zero.
22973 * class.cs (TypeContainer.GetClassBases): We were checking for the
22974 parent class being sealed too late.
22976 * expression.cs (Binary.Emit): For <= and >= when dealing with
22977 floating point values, use cgt.un and clt.un instead of cgt and
22980 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22982 * statement.cs: Apply the same optimization as MS: skip the
22983 GetEnumerator returning an IEnumerator, and use the one returning a
22984 CharEnumerator instead. This allows us to avoid the try-finally block
22987 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22989 * cs-parser.jay: Attributes cannot be applied to
22990 namespaces. Fixes #40473
22992 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22995 (Add*): check if the name is valid using the full name for constants,
22996 fields, properties and events.
22998 2003-03-28 Miguel de Icaza <miguel@ximian.com>
23000 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
23001 char constants to be part of the enumeration.
23003 * expression.cs (Conditional.DoResolve): Add support for operator
23004 true. Implements the missing functionality from 14.12
23006 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
23007 operator true/false as required by the spec.
23009 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
23010 implicit conversion to boolean.
23012 * statement.cs (Statement.ResolveBoolean): A boolean expression is
23013 also one where the type implements `operator true'.
23015 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
23016 get an expression that will invoke operator true based on an
23019 (GetConversionOperators): Removed the hack that called op_True
23022 (Expression.ResolveBoolean): Move this from Statement.
23024 2003-03-17 Miguel de Icaza <miguel@ximian.com>
23026 * ecore.cs (FieldExpr): do not allow initialization of initonly
23027 fields on derived classes
23029 2003-03-13 Martin Baulig <martin@ximian.com>
23031 * statement.cs (Block.Emit): Call ig.BeginScope() and
23032 ig.EndScope() when compiling with debugging info; call
23033 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
23035 2003-03-08 Miguel de Icaza <miguel@ximian.com>
23037 * expression.cs (Indexers): Do not construct immediately, allow
23038 for new members to be appended as we go. Fixes 38143
23040 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23042 * expression.cs: save/restore context when resolving an unchecked
23045 2003-03-05 Miguel de Icaza <miguel@ximian.com>
23047 * cfold.cs: Catch division by zero in modulus operator during
23050 2003-03-03 Miguel de Icaza <miguel@ximian.com>
23052 * interface.cs (Interface.DefineMembers): Avoid defining members
23055 2003-02-27 Miguel de Icaza <miguel@ximian.com>
23057 * driver.cs: handle the +/- options for -noconfig
23059 * statement.cs (Unckeched.Resolve): Also track the state of
23060 unchecked in the Resolve phase.
23062 2003-02-27 Martin Baulig <martin@ximian.com>
23064 * ecore.cs (Expression.MemberLookup): Don't create a
23065 MethodGroupExpr for something which is not a method. Fixes #38291.
23067 2003-02-25 Miguel de Icaza <miguel@ximian.com>
23069 * class.cs (MemberBase.CheckParameters): Also check that the type
23070 is unmanaged if it is a pointer.
23072 * expression.cs (SizeOf.Resolve): Add location information.
23074 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
23075 a managed type is declared.
23077 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
23078 parameter modifiers as well. Fixes bug 38606
23080 * class.cs: Very sad. Am backing out the speed up changes
23081 introduced by the ArrayList -> Array in the TypeContainer, as they
23082 were not actually that much faster, and introduced a bug (no error
23083 reports on duplicated methods).
23085 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
23086 source first, this will guarantee that we have a valid expression
23087 before calling in lower levels functions that will require a
23088 resolved object. Then use this original_source in the
23089 target.ResolveLValue instead of the original source that was
23092 Another change. Use target.Resolve instead of LValueResolve.
23093 Although we are resolving for LValues, we will let the Assign code
23094 take care of that (it will be called again from Resolve). This
23095 basically allows code like this:
23097 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
23098 class Y { void A (X x) { x [0] += o; }
23100 The problem was that the indexer was trying to resolve for
23101 set_Item (idx, object o) and never finding one. The real set_Item
23102 was set_Item (idx, X). By delaying the process we get the right
23107 2003-02-23 Martin Baulig <martin@ximian.com>
23109 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
23110 while calling DoEmit ().
23112 * codegen.cs (EmitContext.Mark): Don't mark locations in other
23113 source files; if you use the #line directive inside a method, the
23114 compiler stops emitting line numbers for the debugger until it
23115 reaches the end of the method or another #line directive which
23116 restores the original file.
23118 2003-02-23 Martin Baulig <martin@ximian.com>
23120 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
23122 2003-02-23 Martin Baulig <martin@ximian.com>
23124 * statement.cs (Block.AddChildVariableNames): We need to call this
23125 recursively, not just for our immediate children.
23127 2003-02-23 Martin Baulig <martin@ximian.com>
23129 * class.cs (Event.Define): Always make the field private, like csc does.
23131 * typemanager.cs (TypeManager.RealMemberLookup): Make events
23132 actually work, fixes bug #37521.
23134 2003-02-23 Miguel de Icaza <miguel@ximian.com>
23136 * delegate.cs: When creating the various temporary "Parameters"
23137 classes, make sure that we call the ComputeAndDefineParameterTypes
23138 on those new parameters (just like we do with the formal ones), to
23139 allow them to be resolved in the context of the DeclSpace.
23141 This fixes the bug that Dick observed in Bugzilla #38530.
23143 2003-02-22 Miguel de Icaza <miguel@ximian.com>
23145 * expression.cs (ResolveMemberAccess): When resolving a constant,
23146 do not attempt to pull a constant if the value was not able to
23147 generate a valid constant.
23149 * const.cs (LookupConstantValue): Do not report more errors than required.
23151 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23153 * expression.cs: fixes bug #38328.
23155 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23157 * class.cs: Changed all the various members that can be part of a
23158 class from being an ArrayList to be an Array of the right type.
23159 During the DefineType type_list, interface_list, delegate_list and
23160 enum_list are turned into types, interfaces, delegates and enums
23163 And during the member population, indexer_list, event_list,
23164 constant_list, field_list, instance_constructor_list, method_list,
23165 operator_list and property_list are turned into their real arrays.
23167 Although we could probably perform this operation earlier, for
23168 good error reporting we need to keep the lists and remove the
23169 lists for longer than required.
23171 This optimization was triggered by Paolo profiling the compiler
23172 speed on the output of `gen-sample-program.pl' perl script.
23174 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
23175 not crash in methods like MemberLookupFailed that use this field.
23177 This problem arises when the compiler fails to resolve a type
23178 during interface type definition for example.
23180 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23182 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
23183 inherit from System.Object, so we have to stop at null, not only
23184 when reaching System.Object.
23186 2003-02-17 Miguel de Icaza <miguel@ximian.com>
23188 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
23189 DeclaredOnly because the parent indexer might have had a different
23190 name, but did not loop until the top of the hierarchy was reached.
23192 The problem this one fixes is 35492: when a class implemented an
23193 indexer from an interface, we were getting the interface method
23194 (which was abstract) and we were flagging an error (can not invoke
23197 This also keeps bug 33089 functioning, and test-148 functioning.
23199 * typemanager.cs (IsSpecialMethod): The correct way of figuring
23200 out if a method is special is to see if it is declared in a
23201 property or event, or whether it is one of the predefined operator
23202 names. This should fix correctly #36804.
23204 2003-02-15 Miguel de Icaza <miguel@ximian.com>
23206 The goal here is to remove the dependency on EmptyCast.Peel ().
23207 Killing it completely.
23209 The problem is that currently in a number of places where
23210 constants are expected, we have to "probe" for an EmptyCast, and
23211 Peel, which is not the correct thing to do, as this will be
23212 repetitive and will likely lead to errors.
23214 The idea is to remove any EmptyCasts that are used in casts that
23215 can be reduced to constants, so we only have to cope with
23218 This bug hunt was triggered by Bug 37363 and the desire to remove
23219 the duplicate pattern where we were "peeling" emptycasts to check
23220 whether they were constants. Now constants will always be
23223 * ecore.cs: Use an enumconstant here instead of wrapping with
23226 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
23227 throwing me off. By handling this we can get rid of a few hacks.
23229 * statement.cs (Switch): Removed Peel() code.
23231 2003-02-14 Miguel de Icaza <miguel@ximian.com>
23233 * class.cs: Location information for error 508
23235 * expression.cs (New.DoResolve): Add a guard against double
23236 resolution of an expression.
23238 The New DoResolve might be called twice when initializing field
23239 expressions (see EmitFieldInitializers, the call to
23240 GetInitializerExpression will perform a resolve on the expression,
23241 and later the assign will trigger another resolution
23243 This leads to bugs (#37014)
23245 * delegate.cs: The signature for EndInvoke should contain any ref
23246 or out parameters as well. We were not doing this in the past.
23248 * class.cs (Field.Define): Do not overwrite the type definition
23249 inside the `volatile' group. Turns out that volatile enumerations
23250 were changing the type here to perform a validity test, which
23253 2003-02-12 Miguel de Icaza <miguel@ximian.com>
23255 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
23256 and structs, we do not want to load the instance variable
23258 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
23259 enum_type has to be handled like an object reference (implicit
23260 conversions exists from this to object), but the regular IsClass
23261 and IsValueType tests will never return true for this one.
23263 Also we use TypeManager.IsValueType instead of type.IsValueType,
23264 just for consistency with the rest of the code (this is only
23265 needed if we ever use the construct exposed by test-180.cs inside
23266 corlib, which we dont today).
23268 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23270 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23273 2003-02-09 Martin Baulig <martin@ximian.com>
23275 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23276 (Namespace.DefineNamespaces): New static public method; this is
23277 called when we're compiling with debugging to add all namespaces
23278 to the symbol file.
23280 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23281 pass it to the Namespace's .ctor.
23283 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23284 and MethodBase arguments; pass the namespace ID to the symwriter;
23285 pass the MethodBase instead of the token to the symwriter.
23286 (SymbolWriter.DefineNamespace): New method to add a namespace to
23289 2003-02-09 Martin Baulig <martin@ximian.com>
23291 * symbolwriter.cs: New file. This is a wrapper around
23292 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23293 methods here in near future.
23295 2003-02-09 Martin Baulig <martin@ximian.com>
23297 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23298 ILGenerator.MarkSequencePoint() which are actually used by the
23301 2003-02-09 Martin Baulig <martin@ximian.com>
23303 * location.cs (SourceFile): New public sealed class. This
23304 contains the name and an index which is used in the location's token.
23305 (Location): Reserve an appropriate number of bits in the token for
23306 the source file instead of walking over that list, this gives us a
23307 really huge performance improvement when compiling with debugging.
23309 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23310 `SourceFile' argument instead of a string.
23311 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23312 but don't parse/tokenize here, we need to generate the list of all
23313 source files before we do that.
23314 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23317 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23318 instead of a string.
23320 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23323 2003-02-09 Martin Baulig <martin@ximian.com>
23325 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23326 filename on `#line default'.
23328 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23330 * statement.cs: don't clear the pinned var when the fixed statement
23331 returns from the method (fixes bug#37752).
23333 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23335 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23338 2003-02-07 Martin Baulig <martin@ximian.com>
23340 * driver.cs: Removed the `--debug-args' command line argument.
23342 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23343 automatically by the AsssemblyBuilder.
23344 (CodeGen.InitializeSymbolWriter): We don't need to call any
23345 initialization function on the symbol writer anymore. This method
23346 doesn't take any arguments.
23348 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23350 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23351 from referenced assemblies as well.
23353 2003-02-02 Martin Baulig <martin@ximian.com>
23355 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23357 2003-02-02 Martin Baulig <martin@ximian.com>
23359 * class.cs (Constructor.Emit): Open the symbol writer before
23360 emitting the constructor initializer.
23361 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23362 single-stepping through constructor initializers.
23364 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23366 * class.cs: Handle error 549: do not allow virtual methods in
23369 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23371 * decl.cs: Check access levels when resolving types
23373 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23375 * statement.cs: Add parameters and locals set in catch blocks that might
23376 return to set vector
23378 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23380 * class.cs (Operator): Set the SpecialName flags for operators.
23382 * expression.cs (Invocation.DoResolve): Only block calls to
23383 accessors and operators on SpecialName methods.
23385 (Cast.TryReduce): Handle conversions from char constants.
23388 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23390 * statement.cs: small memory and time optimization in FlowBranching.
23392 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23394 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23395 problem that the last fix but in the other sid (Set).
23397 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23398 access when there is no indexer in the hierarchy.
23400 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23402 * class.cs: Combine some if statements.
23404 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23406 * driver.cs: fixed bug #37187.
23408 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23410 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23411 any indexer, it's needed to build a list with all the indexers in the
23412 hierarchy (AllGetters), else we have problems. Fixes #35653.
23414 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23416 * class.cs (MethodData.Define): It is wrong for an interface
23417 implementation to be static in both cases: explicit and implicit.
23418 We were only handling this in one case.
23420 Improve the if situation there to not have negations.
23422 * class.cs (Field.Define): Turns out that we do not need to check
23423 the unsafe bit on field definition, only on usage. Remove the test.
23425 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23427 * driver.cs: use assembly.Location instead of Codebase (the latest
23428 patch made mcs fail when using MS assemblies).
23430 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23432 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23433 get the path to *corlib.dll.
23435 2003-01-21 Nick Drochak <ndrochak@gol.com>
23439 * typemanager.cs: Remove compiler warnings
23441 2003-01-20 Duncan Mak <duncan@ximian.com>
23443 * AssemblyInfo.cs: Bump the version number to 0.19.
23445 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23447 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23449 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23451 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23453 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23455 * cs-parser.jay: Small fix: we were not comparing the constructor
23456 name correctly. Thanks to Zoltan for the initial pointer.
23458 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23460 * cs-tokenizer.cs: Set file name when specified with #line
23462 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23464 * cs-parser.jay: Only perform the constructor checks here if we
23465 are named like the class; This will help provider a better
23466 error. The constructor path is taken when a type definition is
23467 not found, but most likely the user forgot to add the type, so
23468 report that rather than the constructor error.
23470 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23472 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23475 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23477 * cs-parser.jay: Add cleanup call.
23479 2003-01-13 Duncan Mak <duncan@ximian.com>
23481 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23482 consistent with other methods.
23484 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23486 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23488 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23490 * attribute.cs: only set GuidAttr to true when we have a
23493 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23497 * typemanager.cs: fixes to allow mcs compile corlib with the new
23498 Type.IsSubclassOf fix.
23500 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23502 * expression.cs (LocalVariableReference.DoResolve): Classify a
23503 constant as a value, not as a variable. Also, set the type for
23506 * cs-parser.jay (fixed_statement): take a type instead of a
23507 pointer_type, so we can produce a better error message later.
23509 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23512 (For.DoEmit): Make inifinite loops have a
23513 non-conditional branch back.
23515 (Fixed.DoEmit): First populate the pinned variables, then emit the
23516 statement, then clear the variables. Before I was emitting the
23517 code once for each fixed piece.
23520 2003-01-08 Martin Baulig <martin@ximian.com>
23522 * statement.cs (FlowBranching.MergeChild): A break in a
23523 SWITCH_SECTION does not leave a loop. Fixes #36155.
23525 2003-01-08 Martin Baulig <martin@ximian.com>
23527 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23528 lives in the same number space than `param_map'. Fixes #36154.
23530 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23532 * cs-parser.jay (constructor_declaration): Set the
23533 Constructor.ModFlags before probing for it. This makes the
23534 compiler report 514, 515 and 132 (the code was there, but got
23537 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23538 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23539 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23541 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23543 * enum.cs: create the enum static fields using the enum type.
23545 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23547 * class.cs: don't try to create the ParamBuilder for the return
23548 type if it's not needed (and handle it breaking for the ms runtime
23551 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23553 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23555 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23557 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23558 the command. This showed up while compiling the JANET source
23559 code, which used \r as its only newline separator.
23561 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23563 * class.cs (Method.Define): If we are an operator (because it
23564 reuses our code), then set the SpecialName and HideBySig. #36128
23566 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23568 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23569 exception, report error 120 `object reference required'.
23571 * driver.cs: Add --pause option, used during to measure the size
23572 of the process as it goes with --timestamp.
23574 * expression.cs (Invocation.DoResolve): Do not allow methods with
23575 SpecialName to be invoked.
23577 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23579 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23580 number before adding it.
23582 2002-12-21 Ravi Pratap <ravi@ximian.com>
23584 * ecore.cs (StandardImplicitConversion): When in an unsafe
23585 context, we allow conversion between void * to any other pointer
23586 type. This fixes bug #35973.
23588 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23590 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23591 is not thrown when extensionless outputs are used
23593 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23595 * rootcontext.cs: fixed compilation of corlib.
23597 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23599 * attribute.cs (Attributes.Contains): Add new method.
23601 * class.cs (MethodCore.LabelParameters): if the parameter is an
23602 `out' parameter, check that no attribute `[In]' has been passed.
23604 * enum.cs: Handle the `value__' name in an enumeration.
23606 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23608 * decl.cs: Added special case to allow overrides on "protected
23611 2002-12-18 Ravi Pratap <ravi@ximian.com>
23613 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23614 since it makes much more sense.
23616 (Attributes.ctor): Don't require a Location parameter.
23618 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23620 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23621 since we already have that information per attribute.
23623 * everywhere : make appropriate changes.
23625 * class.cs (LabelParameters): Write the code which actually
23626 applies attributes to the return type. We can't do this on the MS
23627 .NET runtime so we flag a warning in the case an exception is
23630 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23632 * const.cs: Handle implicit null conversions here too.
23634 2002-12-17 Ravi Pratap <ravi@ximian.com>
23636 * class.cs (MethodCore.LabelParameters): Remove the extra
23637 Type [] parameter since it is completely unnecessary. Instead
23638 pass in the method's attributes so that we can extract
23639 the "return" attribute.
23641 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23643 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23644 of ignoring it and letting the compile continue.
23646 * typemanager.cs (ChangeType): use an extra argument to return an
23647 error condition instead of throwing an exception.
23649 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23651 * expression.cs (Unary.TryReduce): mimic the code for the regular
23652 code path. Perform an implicit cast in the cases where we can
23653 implicitly convert to one of the integral types, and then reduce
23654 based on that constant. This fixes bug #35483.
23656 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23658 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23660 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23662 * namespace.cs: fixed bug #35489.
23664 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23666 * class.cs: Remove some dead code.
23668 * cs-parser.jay: Estimate the number of methods needed
23669 (RootContext.MethodCount);
23671 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23672 numbers instead of StringBuilders.
23674 * support.cs (PtrHashtable): Add constructor with initial size;
23675 We can now reduce reallocations of the method table.
23677 2002-12-10 Ravi Pratap <ravi@ximian.com>
23679 * attribute.cs (ApplyAttributes): Keep track of the emitted
23680 attributes on a per-target basis. This fixes bug #35413.
23682 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23684 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23685 default to the Windows 1252 encoding.
23687 (UnixParseOption): Support version, thanks to Alp for the missing
23690 * AssemblyInfo.cs: Add nice assembly information.
23692 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23695 * cs-parser.jay: Allow a trailing comma before the close bracked
23696 in the attribute_section production.
23698 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23699 address of the instance was being taken, I will take this out,
23700 because we take the address of the object immediately here.
23702 2002-12-09 Ravi Pratap <ravi@ximian.com>
23704 * typemanager.cs (AreMultipleAllowed): Take care of the most
23705 obvious case where attribute type is not in the current assembly -
23708 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23710 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23711 definitions, instead of doing that afterwards.
23713 Also we use a nice little hack, depending on the constructor, we
23714 know if we are a "composed" name or a simple name. Hence, we
23715 avoid the IndexOf test, and we avoid
23717 * codegen.cs: Add code to assist in a bug reporter to track down
23718 the source of a compiler crash.
23720 2002-12-07 Ravi Pratap <ravi@ximian.com>
23722 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23723 types have been emitted for a given element and flag an error
23724 if something which does not have AllowMultiple set is used more
23727 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23728 attribute types and their corresponding AllowMultiple properties
23730 (AreMultipleAllowed): Check the property for a given type.
23732 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23733 property in the case we have a TypeContainer.
23735 (Attributes.AddAttribute): Detect duplicates and just skip on
23736 adding them. This trivial fix catches a pretty gross error in our
23737 attribute emission - global attributes were being emitted twice!
23739 Bugzilla bug #33187 is now fixed.
23741 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23743 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23744 instead of pp_and).
23746 * expression.cs (Binary.ResolveOperator): I can only use the
23747 Concat (string, string, string) and Concat (string, string,
23748 string, string) if the child is actually a concatenation of
23751 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23753 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23754 context where we need a 2-character lookahead.
23756 * pending.cs (PendingImplementation): Rework so we can keep track
23757 of interface types all the time, and flag those which were
23758 implemented by parents as optional.
23760 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23762 * expression.cs (Binary.ResolveOperator): Use
23763 String.Concat(string,string,string) or
23764 String.Concat(string,string,string,string) when possible.
23766 * typemanager: More helper methods.
23769 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23771 * pending.cs: remove the bogus return from GetMissingInterfaces()
23772 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23774 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23776 * namespace.cs: avoid duplicated 'using xxx' being added to
23777 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23778 when we get more than one 'using' statement for the same namespace.
23779 Report a CS0105 warning for it.
23781 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23783 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23784 of calling getChar/putback, uses internal knowledge of it.
23786 (xtoken): Reorder tokenizer so most common patterns are checked
23787 first. This reduces the compilation time in another 5% (from 8.11s
23788 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23790 The parsing time is 22% of the compilation in mcs, and from that
23791 64% is spent on the tokenization process.
23793 I tried using a binary search for keywords, but this is slower
23794 than the hashtable. Another option would be to do a couple of
23797 * Not use a StringBuilder, instead use an array of chars,
23798 with a set value. Notice that this way we could catch
23799 the 645 error without having to do it *afterwards*.
23801 * We could write a hand-parser to avoid the hashtable
23802 compares altogether.
23804 The identifier consumption process takes 37% of the tokenization
23805 time. Another 15% is spent on is_number. 56% of the time spent
23806 on is_number is spent on Int64.Parse:
23808 * We could probably choose based on the string length to
23809 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23812 Another 3% is spend on wrapping `xtoken' in the `token' function.
23814 Handle 0xa0 as whitespace (#34752)
23816 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23818 * typemanager.cs (IsCLRType): New routine to tell whether a type
23819 is one of the builtin types.
23821 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23822 typecode in more places instead of doing pointer comparissions.
23823 We could leverage some knowledge about the way the typecodes are
23826 New code to cache namespaces in assemblies, it is currently not
23827 invoked, to be used soon.
23829 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23831 * expression.cs (Binary.ResolveOperator): specially handle
23832 strings, and do not perform user-defined operator overloading for
23835 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23837 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23838 internalcall as it is a pretty simple operation; Avoid whenever
23839 possible to call Char.IsLetter.
23841 (consume_identifier): Cut by half the number of
23842 hashtable calls by merging the is_keyword and GetKeyword behavior.
23844 Do not short-circuit, because if we do, we
23845 report errors (ie, #if false && true would produce an invalid
23849 2002-11-24 Martin Baulig <martin@ximian.com>
23851 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23852 check constant ranges and report a CS0221. Fixes #33186.
23854 2002-11-24 Martin Baulig <martin@ximian.com>
23856 * cs-parser.jay: Make this work for uninitialized variable
23857 declarations in the `for' initializer. Fixes #32416.
23859 2002-11-24 Martin Baulig <martin@ximian.com>
23861 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23862 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23864 2002-11-24 Martin Baulig <martin@ximian.com>
23866 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23867 argument; if true, we also check for user-defined conversions.
23868 This is only needed if both arguments are of a user-defined type.
23869 Fixes #30443, added test-175.cs.
23870 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23872 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23874 2002-11-24 Martin Baulig <martin@ximian.com>
23876 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23877 function to get the store opcode.
23878 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23879 only emit the Ldelema if the store opcode is Stobj. You must run
23880 both test-34 and test-167 to test this. Fixes #34529.
23882 2002-11-23 Martin Baulig <martin@ximian.com>
23884 * ecore.cs (Expression.MemberLookup): Added additional
23885 `qualifier_type' argument which is used when we're being called
23886 from MemberAccess.DoResolve() and null if we're called from a
23888 (Expression.MemberLookupFailed): New method to report errors; this
23889 does the CS1540 check and reports the correct error message.
23891 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23892 argument for the CS1540 check and redone the way how we're dealing
23893 with private members. See the comment in the source code for details.
23894 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23895 `closure_start_type' to `closure_qualifier_type' and check whether
23896 it's not null. It was not this filter being broken, it was just
23897 being called with the wrong arguments.
23899 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23900 and pass it the correct `qualifier_type'; this also does the error
23903 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23905 * expression.cs (Invocation.EmitParams): If the we are dealing
23906 with a non-built-in value type, load its address as well.
23908 (ArrayCreation): Use a a pretty constant instead
23909 of the hardcoded value 2. Use 6 instead of 2 for the number of
23910 static initializers.
23912 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23913 because they are not really value types, just glorified integers.
23915 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23917 * ecore.cs: Remove redundant code for enumerations, make them use
23918 the same code path as everything else, fixes the casting issue
23919 with enumerations in Windows.Forms.
23921 * attribute.cs: Do only cast to string if it is a string, the
23922 validation happens later.
23924 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23925 people upgrade their corlibs.
23927 * ecore.cs: Oops, enumerations were not following the entire code path
23929 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23931 * typemanager.cs (FilterWithClosure): Commented out the test for
23932 1540 in typemanager.cs, as it has problems when accessing
23933 protected methods from a parent class (see test-174.cs).
23935 * attribute.cs (Attribute.ValidateGuid): new method.
23936 (Attribute.Resolve): Use above.
23938 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23940 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23942 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23943 handling for enumerations, as we only needed the TypeContainer
23944 functionality to begin with (this is required for the fix below to
23945 work for enums that reference constants in a container class for
23948 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23950 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23951 a valid TypeBuilder to perform lookups on.o
23953 * class.cs (InheritableMemberSignatureCompare): Use true in the
23954 call to GetGetMethod and GetSetMethod, because we are comparing
23955 the signature, and we need to get the methods *even* if they are
23958 (PropertyBase.CheckBase): ditto.
23960 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23961 GotoCase.Resolve): Use Peel on EmpytCasts.
23963 * ecore.cs (EmptyCast): drop child, add Peel method.
23965 2002-11-17 Martin Baulig <martin@ximian.com>
23967 * ecore.cs (EmptyCast.Child): New public property.
23969 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23970 label resolved to an EmptyCast. Fixes #34162.
23971 (GotoCase.Resolve): Likewise.
23972 (Block.EmitMeta): Likewise.
23974 2002-11-17 Martin Baulig <martin@ximian.com>
23976 * expression.cs (Invocation.BetterConversion): Prefer int over
23977 uint; short over ushort; long over ulong for integer literals.
23978 Use ImplicitConversionExists instead of StandardConversionExists
23979 since we also need to check for user-defined implicit conversions.
23980 Fixes #34165. Added test-173.cs.
23982 2002-11-16 Martin Baulig <martin@ximian.com>
23984 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23985 with the `true' and `false' literals. Fixes #33151.
23987 2002-11-16 Martin Baulig <martin@ximian.com>
23989 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23990 October 22nd; don't do the cs1540 check for static members.
23992 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23993 now using our own filter here and doing the cs1540 check again.
23995 2002-11-16 Martin Baulig <martin@ximian.com>
23997 * support.cs (InternalParameters): Don't crash if we don't have
23998 any fixed parameters. Fixes #33532.
24000 2002-11-16 Martin Baulig <martin@ximian.com>
24002 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
24003 when looking up static methods to make this work on Windows.
24006 2002-11-16 Martin Baulig <martin@ximian.com>
24008 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
24009 a setter rather than using PropertyInfo.CanWrite.
24011 2002-11-15 Nick Drochak <ndrochak@gol.com>
24013 * class.cs: Allow acces to block member by subclasses. Fixes build
24016 2002-11-14 Martin Baulig <martin@ximian.com>
24018 * class.cs (Constructor.Emit): Added the extern/block check.
24021 2002-11-14 Martin Baulig <martin@ximian.com>
24023 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
24024 iteration while looking for indexers, this is needed because the
24025 indexer may have a different name in our base classes. Fixed the
24026 error reporting (no indexers at all, not get accessor, no
24027 overloaded match). Fixes bug #33089.
24028 (IndexerAccess.DoResolveLValue): Likewise.
24030 2002-11-14 Martin Baulig <martin@ximian.com>
24032 * class.cs (PropertyBase.CheckBase): Make this work for multiple
24033 indexers. Fixes the first part of bug #33089.
24034 (MethodSignature.InheritableMemberSignatureCompare): Added support
24037 2002-11-13 Ravi Pratap <ravi@ximian.com>
24039 * attribute.cs (Attribute.Resolve): Catch the
24040 NullReferenceException and report it since it isn't supposed to
24043 2002-11-12 Miguel de Icaza <miguel@ximian.com>
24045 * expression.cs (Binary.EmitBranchable): Also handle the cases for
24046 LogicalOr and LogicalAnd that can benefit from recursively
24047 handling EmitBranchable. The code now should be nice for Paolo.
24049 2002-11-08 Miguel de Icaza <miguel@ximian.com>
24051 * typemanager.cs (LookupType): Added a negative-hit hashtable for
24052 the Type lookups, as we perform quite a number of lookups on
24053 non-Types. This can be removed once we can deterministically tell
24054 whether we have a type or a namespace in advance.
24056 But this might require special hacks from our corlib.
24060 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
24061 and double which avoids a conversion from an integer to a double.
24063 * expression.cs: tiny optimization, avoid calling IsConstant,
24064 because it effectively performs the lookup twice.
24066 2002-11-06 Miguel de Icaza <miguel@ximian.com>
24068 But a bogus return here to keep the semantics of the old code
24069 until the Mono runtime is fixed.
24071 * pending.cs (GetMissingInterfaces): New method used to remove all
24072 the interfaces that are already implemented by our parent
24073 classes from the list of pending methods.
24075 * interface.cs: Add checks for calls after ResolveTypeExpr.
24077 2002-11-05 Miguel de Icaza <miguel@ximian.com>
24079 * class.cs (Class.Emit): Report warning 67: event not used if the
24080 warning level is beyond 3.
24082 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
24083 being a NullLiteral.
24085 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
24088 * class.cs (TypeContainer.GetClassBases): Cover a missing code
24089 path that might fail if a type can not be resolved.
24091 * expression.cs (Binary.Emit): Emit unsigned versions of the
24094 * driver.cs: use error 5.
24096 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
24098 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
24100 2002-11-01 Miguel de Icaza <miguel@ximian.com>
24102 * cs-parser.jay (switch_section): A beautiful patch from Martin
24103 Baulig that fixed 33094.
24105 2002-10-31 Miguel de Icaza <miguel@ximian.com>
24107 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
24108 Check whether the base is abstract and report an error if so.
24110 * expression.cs (IndexerAccess.DoResolveLValue,
24111 IndexerAccess.DoResolve): ditto.
24113 (Invocation.DoResolve): ditto.
24115 (Invocation.FullMethodDesc): Improve the report string.
24117 * statement.cs (Block): Eliminate IsVariableDefined as it is
24118 basically just a wrapper for GetVariableInfo.
24120 * ecore.cs (SimpleName): Use new
24122 * support.cs (ReflectionParamter.ParameterType): We unwrap the
24123 type, as we return the actual parameter ref/unref state on a
24126 2002-10-30 Miguel de Icaza <miguel@ximian.com>
24128 * support.cs: Return proper flags REF/OUT fixing the previous
24131 * expression.cs: Reverted last patch, that was wrong. Is_ref is
24132 not used to mean `ref' but `ref or out' in ParameterReference
24134 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
24135 full type signature instead of calling TypeManger.CSharpName
24138 * support.cs (InternalParameters.ParameterDesc): Do not compare
24139 directly to the modflags, because REF/OUT will actually be bitsets
24142 * delegate.cs (VerifyMethod): Check also the modifiers.
24144 * cs-tokenizer.cs: Fix bug where floating point values with an
24145 exponent where a sign was missing was ignored.
24147 * driver.cs: Allow multiple assemblies to be specified in a single
24150 2002-10-28 Miguel de Icaza <miguel@ximian.com>
24152 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
24153 because identifiers after a parenthesis would end up in this kind
24154 of production, and we needed to desamiguate it for having casts
24157 (UserDefinedType *) xxx
24159 2002-10-24 Miguel de Icaza <miguel@ximian.com>
24161 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
24162 we should set on the Bindingflags.NonPublic, but not turn on
24163 private_ok. private_ok controls whether a Private member is
24164 returned (this is chekced on the filter routine), while the
24165 BindingFlags.NonPublic just controls whether private/protected
24166 will be allowed. This fixes the problem part of the problem of
24167 private properties being allowed to be used in derived classes.
24169 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
24170 so we can call the children DoResolveLValue method (this will
24171 properly signal errors on lvalue assignments to base properties)
24173 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
24174 getter are null, and we have a property info, we know that this
24175 happened because the lookup failed, so we report an error 122 for
24176 protection level violation.
24178 We also silently return if setter and getter are null in the
24179 resolve functions, this condition only happens if we have flagged
24180 the error before. This is the other half of the problem.
24182 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
24183 not have accessibility information, that is why we were returning
24184 true in the filter function in typemanager.cs.
24186 To properly report 122 (property is inaccessible because of its
24187 protection level) correctly, we report this error in ResolveAccess
24188 by failing if both the setter and the getter are lacking (ie, the
24191 DoResolve and DoLResolve have been modified to check for both
24192 setter/getter being null and returning silently, the reason being
24193 that I did not want to put the knowledge about this error in upper
24196 int old = Report.Errors;
24197 x = new PropertyExpr (...);
24198 if (old != Report.Errors)
24203 So the property expr is returned, but it is invalid, so the error
24204 will be flagged during the resolve process.
24206 * class.cs: Remove InheritablePropertySignatureCompare from the
24207 class, as we no longer depend on the property signature to compute
24208 whether it is possible to implement a method or not.
24210 The reason is that calling PropertyInfo.GetGetMethod will return
24211 null (in .NET, in Mono it works, and we should change this), in
24212 cases where the Get Method does not exist in that particular
24217 class X { public virtual int A { get { return 1; } } }
24219 class Z : Y { public override int A { get { return 2; } } }
24221 Would fail in Z because the parent (Y) would not have the property
24222 defined. So we avoid this completely now (because the alternative
24223 fix was ugly and slow), and we now depend exclusively on the
24226 (PropertyBase.CheckBase): Use a method-base mechanism to find our
24227 reference method, instead of using the property.
24229 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
24230 routines are gone now.
24232 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
24233 names, they were incorrectly named.
24235 * cs-tokenizer.cs: Return are more gentle token on failure.
24237 * pending.cs (PendingImplementation.InterfaceMethod): This routine
24238 had an out-of-sync index variable, which caused it to remove from
24239 the list of pending methods the wrong method sometimes.
24241 2002-10-22 Miguel de Icaza <miguel@ximian.com>
24243 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
24244 CanWrite, because those refer to this particular instance of the
24245 property, and do not take into account the fact that we can
24246 override single members of a property.
24248 Constructor requires an EmitContext. The resolution process does
24249 not happen here, but we need to compute the accessors before,
24250 because the resolution does not always happen for properties.
24252 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
24253 subclass, before we did not update this flag, but we did update
24256 (GetAccessors): Drop this routine, as it did not work in the
24257 presence of partially overwritten set/get methods.
24259 Notice that this broke the cs1540 detection, but that will require
24262 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24266 * driver.cs: issue a warning instead of an error if we don't support
24267 debugging for the platform. Also ignore a couple of errors that may
24268 arise when trying to write the symbols. Undo my previous patch.
24270 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24272 * driver.cs: ignore /debug switch except for Unix platforms.
24274 2002-10-23 Nick Drochak <ndrochak@gol.com>
24276 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24278 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24280 * driver.cs: Do not make mcs-debug conditional, so we do not break
24281 builds that use it.
24283 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24284 review this patch. But basically after all the children variables
24285 have been merged, the value of "Breaks" was not being set to
24286 new_breaks for Switch blocks. I think that it should be set after
24287 it has executed. Currently I set this to the value of new_breaks,
24288 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24289 conservative, but I do not understand this code very well.
24291 I did not break anything in the build, so that is good ;-)
24293 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24295 2002-10-20 Mark Crichton <crichton@gimp.org>
24297 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24299 2002-10-20 Nick Drochak <ndrochak@gol.com>
24301 * cfold.cs: Fixed compile blocker.
24303 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24305 * driver.cs: I was chekcing the key, not the file.
24307 2002-10-19 Ravi Pratap <ravi@ximian.com>
24309 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24310 message that we were generating - we just need to silently return
24313 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24315 * class.cs (Event.Define): Change my previous commit, as this
24316 breaks the debugger. This is a temporary hack, as it seems like
24317 the compiler is generating events incorrectly to begin with.
24319 * expression.cs (Binary.ResolveOperator): Added support for
24320 "U operator - (E x, E y)"
24322 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24325 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24326 init-only variables, but this path did not take into account that
24327 there might be also instance readonly variables. Correct this
24330 This fixes bug 32253
24332 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24335 * driver.cs: Change the extension for modules to `netmodule'
24337 * cs-parser.jay: Improved slightly the location tracking for
24338 the debugger symbols.
24340 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24341 modifiers that were specified instead of the hardcoded value
24342 (FamAndAssem). This was basically ignoring the static modifier,
24343 and others. Fixes 32429.
24345 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24346 fixed a bug in the process (32476)
24348 * expression.cs (ArrayAccess.EmitAssign): Patch from
24349 hwang_rob@yahoo.ca that fixes bug 31834.3
24351 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24353 * driver.cs: Make the module extension .netmodule.
24355 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24357 * driver.cs: Report an error if the resource file is not found
24358 instead of crashing.
24360 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24361 false, like Emit does.
24363 2002-10-16 Nick Drochak <ndrochak@gol.com>
24365 * typemanager.cs: Remove unused private member. Also reported mcs
24366 bug to report this as a warning like csc.
24368 2002-10-15 Martin Baulig <martin@gnome.org>
24370 * statement.cs (Statement.Emit): Made this a virtual method; emits
24371 the line number info and calls DoEmit().
24372 (Statement.DoEmit): New protected abstract method, formerly knows
24373 as Statement.Emit().
24375 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24377 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24379 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24380 have fixed a remaining problem: not every AddXXXX was adding a
24381 fully qualified name.
24383 Now everyone registers a fully qualified name in the DeclSpace as
24384 being defined instead of the partial name.
24386 Downsides: we are slower than we need to be due to the excess
24387 copies and the names being registered this way.
24389 The reason for this is that we currently depend (on the corlib
24390 bootstrap for instance) that types are fully qualified, because
24391 we dump all the types in the namespace, and we should really have
24392 types inserted into the proper namespace, so we can only store the
24393 basenames in the defined_names array.
24395 2002-10-10 Martin Baulig <martin@gnome.org>
24397 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24398 from bug #31834, see the bug report for a testcase which is
24401 2002-10-10 Martin Baulig <martin@gnome.org>
24403 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24404 flow analysis code for this.
24406 * statement.cs (Do, While, For): Tell the flow analysis code about
24408 (FlowBranching.UsageVector): Added support for infinite loops.
24409 (Block.Resolve): Moved the dead code elimination here and use flow
24412 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24414 * class.cs (Field.Define): Catch cycles on struct type
24417 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24418 fields if the fields are static. We only need to check instance
24421 * expression.cs (As.DoResolve): Test for reference type.
24423 * statement.cs (Using.ResolveExpression): Use
24424 ConvertImplicitRequired, not ConvertImplicit which reports an
24426 (Using.ResolveLocalVariableDecls): ditto.
24428 * expression.cs (Binary.ResolveOperator): Report errors in a few
24429 places where we had to.
24431 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24433 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24435 * expression.cs: Use StoreFromPtr instead of extracting the type
24436 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24438 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24439 an enumeration value to a System.Enum, but System.Enum is not a
24440 value type, but an class type, so we need to box.
24442 (Expression.ConvertExplicit): One codepath could return
24443 errors but not flag them. Fix this. Fixes #31853
24445 * parameter.cs (Resolve): Do not allow void as a parameter type.
24447 2002-10-06 Martin Baulig <martin@gnome.org>
24449 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24450 if it's a class type and not a struct. Fixes #31815.
24452 2002-10-06 Martin Baulig <martin@gnome.org>
24454 * statement.cs: Reworked the flow analysis code a bit to make it
24455 usable for dead code elimination.
24457 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24459 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24461 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24463 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24464 to fix the test 165, will investigate deeper.
24466 2002-10-04 Martin Baulig <martin@gnome.org>
24468 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24469 finally blocks actually work.
24470 (Try.Resolve): We don't need to create a sibling for `finally' if
24471 there is no finally block.
24473 2002-10-04 Martin Baulig <martin@gnome.org>
24475 * class.cs (Constructor.Define): The default accessibility for a
24476 non-default constructor is private, not public.
24478 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24480 * class.cs (Constructor): Make AllowedModifiers public, add
24483 * cs-parser.jay: Perform the modifiers test here, as the
24484 constructor for the Constructor class usually receives a zero
24485 because of the way we create it (first we create, later we
24486 customize, and we were never checking the modifiers).
24488 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24489 is a version of LookupTypeReflection that includes the type-name
24490 cache. This can be used as a fast path for functions that know
24491 the fully qualified name and are only calling into *.GetType() to
24492 obtain a composed type.
24494 This is also used by TypeManager.LookupType during its type
24497 (LookupType): We now also track the real type name, as sometimes
24498 we can get a quey for the real type name from things like
24499 ComposedCast. This fixes bug 31422.
24501 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24502 complete type fullname, it does not have to go through the type
24503 resolution system to obtain the composed version of the type (for
24504 obtaining arrays or pointers).
24506 (Conditional.Emit): Use the EmitBoolExpression to
24507 generate nicer code, as requested by Paolo.
24509 (ArrayCreation.CheckIndices): Use the patch from
24510 hwang_rob@yahoo.ca to validate the array initializers.
24512 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24514 * class.cs (ConstructorInitializer.Emit): simplify code by using
24515 Invocation.EmitCall, and at the same time, fix the bugs in calling
24516 parent constructors that took variable arguments.
24518 * ecore.cs (Expression.ConvertNumericExplicit,
24519 Expression.ImplicitNumericConversion): Remove the code that
24520 manually wrapped decimal (InternalTypeConstructor call is now gone
24523 * expression.cs (Cast.TryReduce): Also handle decimal types when
24524 trying to perform a constant fold on the type.
24526 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24528 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24529 that only turned off an error report, and did nothing else.
24531 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24533 * driver.cs: Handle and ignore /fullpaths
24535 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24537 * expression.cs (Binary.ResolveOperator): Catch the case where
24538 DoNumericPromotions returns true,
24540 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24542 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24544 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24547 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24549 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24550 conversion exists, but it is also required that the conversion be
24551 performed. This manifested in "(Type64Enum) 2".
24553 * class.cs (TypeManager.AddMethod): The fix is not to change
24554 AddEnum, because that one was using a fully qualified name (every
24555 DeclSpace derivative does), but to change the AddMethod routine
24556 that was using an un-namespaced name. This now correctly reports
24557 the duplicated name.
24559 Revert patch until I can properly fix it. The issue
24560 is that we have a shared Type space across all namespaces
24561 currently, which is wrong.
24563 Options include making the Namespace a DeclSpace, and merge
24564 current_namespace/current_container in the parser.
24566 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24568 * cs-parser.jay: Improve error reporting when we get a different
24569 kind of expression in local_variable_type and
24570 local_variable_pointer_type.
24572 Propagate this to avoid missleading errors being reported.
24574 * ecore.cs (ImplicitReferenceConversion): treat
24575 TypeManager.value_type as a target just like object_type. As
24580 Is valid, and needs to result in the int 1 being boxed before it
24581 is assigned to the value type v.
24583 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24584 to validate the enumeration name.
24586 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24587 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24588 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24590 * ecore.cs (TryImplicitIntConversion): When doing an
24591 implicit-enumeration-conversion, check if the type is 64-bits and
24592 perform a conversion before passing to EnumConstant.
24594 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24596 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24597 report ambiguous type references. Unlike the MS version, we
24598 report what the ambiguity is. Innovation at work ;-)
24600 (DeclSpace.FindType): Require a location argument to
24601 display when we display an ambiguous error.
24603 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24605 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24607 * expression.cs (EmitDynamicInitializers): Apply patch from
24608 hwang_rob@yahoo.ca that fixes the order in which we emit our
24611 2002-09-21 Martin Baulig <martin@gnome.org>
24613 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24614 delegate takes no arguments.
24616 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24618 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24621 * expression.cs: Extract the underlying type.
24623 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24625 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24627 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24629 * class.cs (TypeContainer.DefineType): We can not use the nice
24630 PackingSize with the size set to 1 DefineType method, because it
24631 will not allow us to define the interfaces that the struct
24634 This completes the fixing of bug 27287
24636 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24637 means also structs. This fixes part of the problem.
24638 (Expresion.ImplicitReferenceConversionExists): ditto.
24640 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24641 error if there were no errors reported during the type lookup
24642 process, to avoid duplicates or redundant errors. Without this
24643 you would get an ambiguous errors plus a type not found. We have
24644 beaten the user enough with the first error.
24646 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24649 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24650 during the resolution process, stop the lookup, this avoids
24651 repeated error reports (same error twice).
24653 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24655 * typemanager.cs (LookupType): Redo the type lookup code to match
24656 the needs of System.Reflection.
24658 The issue is that System.Reflection requires references to nested
24659 types to begin with a "+" sign instead of a dot. So toplevel
24660 types look like: "NameSpace.TopLevelClass", and nested ones look
24661 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24664 2002-09-19 Martin Baulig <martin@gnome.org>
24666 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24667 says that a method always returns or always throws an exception,
24668 don't report the CS0161.
24670 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24671 set `Returns = new_returns'.
24673 2002-09-19 Martin Baulig <martin@gnome.org>
24675 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24676 to an enum constant, check for a CS0176.
24678 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24680 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24681 for operators that must be in pairs and report errors.
24683 * ecore.cs (SimpleName.DoResolveType): During the initial type
24684 resolution process, when we define types recursively, we must
24685 check first for types in our current scope before we perform
24686 lookups in the enclosing scopes.
24688 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24690 (Invocation.VerifyArgumentsCompat): Call
24691 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24692 I thought we were supposed to always call this, but there are a
24693 few places in the code where we dont do it.
24695 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24697 * driver.cs: Add support in -linkres and -resource to specify the
24698 name of the identifier.
24700 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24702 * ecore.cs (StandardConversionExists): Sync with the conversion
24703 code: allow anything-* to void* conversions.
24705 (FindMostSpecificSource): Use an Expression argument
24706 instead of a Type, because we might be handed over a Literal which
24707 gets a few more implicit conversions that plain types do not. So
24708 this information was being lost.
24710 Also, we drop the temporary type-holder expression when not
24713 2002-09-17 Martin Baulig <martin@gnome.org>
24715 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24716 this is an explicit interface implementation.
24718 2002-09-17 Martin Baulig <martin@gnome.org>
24720 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24721 different `IndexerName' attributes.
24723 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24724 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24725 virtual CommonResolve().
24727 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24729 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24730 and convert that to the UnderlyingType.
24732 * statement.cs (Foreach.Resolve): Indexers are just like variables
24733 or PropertyAccesses.
24735 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24736 inside quoted strings, we were not doing this before.
24738 2002-09-16 Martin Baulig <martin@gnome.org>
24740 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24741 resolve it. This is needed for the definite assignment check of the
24742 instance expression, fixes bug #29846.
24743 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24745 2002-09-16 Nick Drochak <ndrochak@gol.com>
24747 * parameter.cs: Fix compile error. Cannot reference static member
24748 from an instance object. Is this an mcs bug?
24750 2002-09-14 Martin Baulig <martin@gnome.org>
24752 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24753 multiple times. Fixes bug #30295, added test-166.cs.
24755 2002-09-14 Martin Baulig <martin@gnome.org>
24757 * statement.cs (Block.Emit): Don't emit unreachable code.
24758 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24759 `break' statements.
24760 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24762 2002-09-14 Martin Baulig <martin@gnome.org>
24764 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24767 2002-09-14 Martin Baulig <martin@gnome.org>
24769 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24770 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24771 be false on the ms runtime.
24773 2002-09-13 Martin Baulig <martin@gnome.org>
24775 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24776 the CS0038 error message.
24778 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24780 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24781 constant inside, return it.
24783 2002-09-12 Martin Baulig <martin@gnome.org>
24785 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24786 implicit conversion can be done between enum types.
24788 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24789 check whether an implicit conversion to the current enum's UnderlyingType
24790 exists and report an error if not.
24792 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24793 without debugging support.
24795 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24796 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24798 2002-09-12 Martin Baulig <martin@gnome.org>
24800 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24802 * ecore.cs (IMemberExpr.DeclaringType): New property.
24803 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24804 nonstatic member of an outer type (CS0038).
24806 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24808 * driver.cs: Activate the using-error detector at warning level
24809 4 (at least for MS-compatible APIs).
24811 * namespace.cs (VerifyUsing): Small buglett fix.
24813 * pending.cs (PendingImplementation): pass the container pointer.
24815 * interface.cs (GetMethods): Allow for recursive definition. Long
24816 term, I would like to move every type to support recursive
24817 definitions, not the current ordering mechanism that we have right
24820 The situation is this: Attributes are handled before interfaces,
24821 so we can apply attributes to interfaces. But some attributes
24822 implement interfaces, we will now handle the simple cases
24823 (recursive definitions will just get an error).
24825 * parameter.cs: Only invalidate types at the end if we fail to
24828 2002-09-09 Martin Baulig <martin@gnome.org>
24830 * ecore.cs (PropertyExpr.Emit): Also check for
24831 TypeManager.system_int_array_get_length so this'll also work when
24832 compiling corlib. Fixes #30003.
24834 2002-09-09 Martin Baulig <martin@gnome.org>
24836 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24837 and throw an exception if we can't get the type's size. Fixed #30040,
24840 2002-09-09 Martin Baulig <martin@gnome.org>
24842 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24844 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24845 context. Fixes bug #30027.
24847 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24848 virtual functions. Fixes bug #30043, added test-164.cs.
24850 2002-09-08 Ravi Pratap <ravi@ximian.com>
24852 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24854 2002-09-08 Nick Drochak <ndrochak@gol.com>
24856 * driver.cs: Use an object to get the windows codepage since it's not a
24859 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24861 * statement.cs (For.Emit): for infinite loops (test == null)
24862 return whether there is a break inside, not always "true".
24864 * namespace.cs (UsingEntry): New struct to hold the name of the
24865 using definition, the location where it is defined, and whether it
24866 has been used in a successful type lookup.
24868 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24873 2002-09-06 Ravi Pratap <ravi@ximian.com>
24875 * attribute.cs : Fix incorrect code which relied on catching
24876 a NullReferenceException to detect a null being passed in
24877 where an object was expected.
24879 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24881 * statement.cs (Try): flag the catch variable as assigned
24883 * expression.cs (Cast): Simplified by using ResolveType instead of
24884 manually resolving.
24886 * statement.cs (Catch): Fix bug by using ResolveType.
24888 2002-09-06 Ravi Pratap <ravi@ximian.com>
24890 * expression.cs (BetterConversion): Special case for when we have
24891 a NullLiteral as the argument and we have to choose between string
24892 and object types - we choose string the way csc does.
24894 * attribute.cs (Attribute.Resolve): Catch the
24895 NullReferenceException and report error #182 since the Mono
24896 runtime no more has the bug and having this exception raised means
24897 we tried to select a constructor which takes an object and is
24900 2002-09-05 Ravi Pratap <ravi@ximian.com>
24902 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24903 message (1502, 1503) when we can't locate a method after overload
24904 resolution. This is much more informative and closes the bug
24907 * interface.cs (PopulateMethod): Return if there are no argument
24908 types. Fixes a NullReferenceException bug.
24910 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24911 expressions too. Previously we were checking only in one place for
24912 positional arguments leaving out named arguments.
24914 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24915 type to the enum type is not allowed. Remove code corresponding to
24918 (ConvertNumericExplicit): Allow explicit conversions from
24919 the underlying type to enum type. This precisely follows the spec
24920 and closes a bug filed by Gonzalo.
24922 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24925 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24927 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24929 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24930 it was important that we stored the right value after the
24931 reduction in `converted'.
24933 2002-09-04 Martin Baulig <martin@gnome.org>
24935 * location.cs (Location.SymbolDocument): Use full pathnames for the
24938 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24940 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24941 of the expression resolve mechanism, because that will catch the
24942 SimpleName error failures.
24944 (Conditional): If we can not resolve the
24945 expression, return, do not crash.
24947 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24950 (location): display token name instead of its number.
24952 2002-08-28 Martin Baulig <martin@gnome.org>
24954 * expression.cs (Binary.ResolveOperator): Don't silently return
24955 but return an error if an operator cannot be applied between two
24958 2002-08-28 Martin Baulig <martin@gnome.org>
24960 * class.cs (Constructor.Define): Set the permission attributes
24961 correctly instead of making all constructors public.
24963 2002-08-28 Martin Baulig <martin@gnome.org>
24965 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24966 for private members before reporting a CS0103; if we find anything,
24969 2002-08-28 Martin Baulig <martin@gnome.org>
24971 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24972 to check whether `closure_start_type == closure_invocation_type',
24973 we also need to check whether `m.DeclaringType == closure_invocation_type'
24974 before bypassing the permission checks. We might be accessing
24975 protected/private members from the base class.
24976 (TypeManager.RealMemberLookup): Only set private_ok if private
24977 members were requested via BindingFlags.NonPublic.
24979 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24981 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24982 MethodGroupExpr.IsExplicitImpl if appropriate.
24983 (Invocation.DoResolve): Don't report the CS0120 for explicit
24984 interface implementations.
24986 2002-08-27 Martin Baulig <martin@gnome.org>
24988 * expression.cs (Invocation.DoResolve): If this is a static
24989 method and we don't have an InstanceExpression, we must report
24992 2002-08-25 Martin Baulig <martin@gnome.org>
24994 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24995 `==' between a valuetype and an object.
24997 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24999 * ecore.cs (TypeExpr): Provide a ToString method.
25001 2002-08-24 Martin Baulig <martin@gnome.org>
25003 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
25004 now called proggie.dbg and it's a binary file.
25006 2002-08-23 Martin Baulig <martin@gnome.org>
25008 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
25010 2002-08-23 Martin Baulig <martin@gnome.org>
25012 * struct.cs (MyStructInfo.ctor): Make this work with empty
25013 structs; it's not allowed to use foreach() on null.
25015 2002-08-23 Martin Baulig <martin@gnome.org>
25017 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
25018 writer the full pathname of the generated assembly.
25020 2002-08-23 Martin Baulig <martin@gnome.org>
25022 * statements.cs (FlowBranching.UsageVector.MergeChildren):
25023 A `finally' block never returns or breaks; improved handling of
25026 2002-08-23 Martin Baulig <martin@gnome.org>
25028 * statement.cs (Throw.Resolve): Allow `throw null'.
25030 2002-08-23 Martin Baulig <martin@gnome.org>
25032 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
25033 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
25034 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
25035 MemberLookup would return a wrong event if this is an explicit
25036 interface implementation and the class has an event with the same
25039 2002-08-23 Martin Baulig <martin@gnome.org>
25041 * statement.cs (Block.AddChildVariableNames): New public method.
25042 (Block.AddChildVariableName): Likewise.
25043 (Block.IsVariableNameUsedInChildBlock): Likewise.
25044 (Block.AddVariable): Check whether a variable name has already
25045 been used in a child block.
25047 * cs-parser.jay (declare_local_variables): Mark all variable names
25048 from the current block as being used in a child block in the
25051 2002-08-23 Martin Baulig <martin@gnome.org>
25053 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
25054 find the symbol writer.
25056 * driver.cs: csc also allows the arguments to /define being
25057 separated by commas, not only by semicolons.
25059 2002-08-23 Martin Baulig <martin@gnome.org>
25061 * interface.cs (Interface.GetMembers): Added static check for events.
25063 2002-08-15 Martin Baulig <martin@gnome.org>
25065 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
25066 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
25068 * ecore.cs (Expression.MemberLookup): Added documentation and explained
25069 why the MethodData.EmitDestructor() change was necessary.
25071 2002-08-20 Martin Baulig <martin@gnome.org>
25073 * class.cs (TypeContainer.FindMembers): Added static check for events.
25075 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
25077 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
25078 use Type.GetEvents(), not Type.FindMembers().
25080 2002-08-20 Martin Baulig <martin@gnome.org>
25082 * decl.cs (MemberCache): Added a special method cache which will
25083 be used for method-only searched. This ensures that a method
25084 search will return a MethodInfo with the correct ReflectedType for
25087 2002-08-20 Martin Baulig <martin@gnome.org>
25089 * decl.cs (DeclSpace.FindMembers): Made this public.
25091 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25093 * delegate.cs: fixed build on windows.
25094 [FIXME: Filed as bug #29150: MCS must report these errors.]
25096 2002-08-19 Ravi Pratap <ravi@ximian.com>
25098 * ecore.cs (StandardConversionExists): Return a false
25099 if we are trying to convert the void type to anything else
25100 since that is not allowed.
25102 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
25103 we flag error 70 in the event an event is trying to be accessed
25104 directly from outside the declaring type.
25106 2002-08-20 Martin Baulig <martin@gnome.org>
25108 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
25109 MemberCache from typemanager.cs to decl.cs.
25111 2002-08-19 Martin Baulig <martin@gnome.org>
25113 * class.cs (TypeContainer): Implement IMemberContainer.
25114 (TypeContainer.DefineMembers): Create the MemberCache.
25115 (TypeContainer.FindMembers): Do better BindingFlags checking; only
25116 return public members if BindingFlags.Public was given, check
25117 whether members are static.
25119 2002-08-16 Martin Baulig <martin@gnome.org>
25121 * decl.cs (DeclSpace.Define): Splitted this in Define and
25122 DefineMembers. DefineMembers is called first and initializes the
25125 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
25126 DefineMembers() on all our DeclSpaces.
25128 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
25129 but call DefineMembers() on all nested interfaces. We call their
25130 Define() in our new Define() function.
25132 * interface.cs (Interface): Implement IMemberContainer.
25133 (Interface.Define): Moved all code except the attribute stuf to
25135 (Interface.DefineMembers): Initialize the member cache.
25137 * typemanager.cs (IMemberFinder): Removed this interface, we don't
25138 need this anymore since we can use MemberCache.FindMembers directly.
25140 2002-08-19 Martin Baulig <martin@gnome.org>
25142 * typemanager.cs (MemberCache): When creating the cache for an
25143 interface type, add all inherited members.
25144 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
25145 to `out bool used_cache' and documented it.
25146 (TypeManager.MemberLookup): If we already used the cache in the first
25147 iteration, we don't need to do the interfaces check.
25149 2002-08-19 Martin Baulig <martin@gnome.org>
25151 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
25152 here from IMemberFinder and don't implement this interface anymore.
25153 (DeclSpace.MemberCache): Moved here from IMemberFinder.
25155 * typemanager.cs (IMemberFinder): This interface is now only used by
25156 classes which actually support the member cache.
25157 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
25158 since we only put DeclSpaces into this Hashtable.
25159 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
25160 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
25162 2002-08-16 Martin Baulig <martin@gnome.org>
25164 * typemanager.cs (ICachingMemberFinder): Removed.
25165 (IMemberFinder.MemberCache): New property.
25166 (TypeManager.FindMembers): Merged this with RealFindMembers().
25167 This function will never be called from TypeManager.MemberLookup()
25168 so we can't use the cache here, just the IMemberFinder.
25169 (TypeManager.MemberLookup_FindMembers): Check whether the
25170 IMemberFinder has a MemberCache and call the cache's FindMembers
25172 (MemberCache): Rewrote larger parts of this yet another time and
25173 cleaned it up a bit.
25175 2002-08-15 Miguel de Icaza <miguel@ximian.com>
25177 * driver.cs (LoadArgs): Support quoting.
25179 (Usage): Show the CSC-like command line arguments.
25181 Improved a few error messages.
25183 2002-08-15 Martin Baulig <martin@gnome.org>
25185 * typemanager.cs (IMemberContainer.Type): New property.
25186 (IMemberContainer.IsInterface): New property.
25188 The following changes are conditional to BROKEN_RUNTIME, which is
25189 defined at the top of the file.
25191 * typemanager.cs (MemberCache.MemberCache): Don't add the base
25192 class'es members, but add all members from TypeHandle.ObjectType
25193 if we're an interface.
25194 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
25195 is the current type.
25196 (MemberCache.CacheEntry.Container): Removed this field.
25197 (TypeHandle.GetMembers): Include inherited members.
25199 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25201 * typemanager.cs: fixed compilation and added a comment on a field that
25204 2002-08-15 Martin Baulig <martin@gnome.org>
25206 * class.cs (ConstructorInitializer.Resolve): In the
25207 Expression.MemberLookup call, use the queried_type as
25210 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
25211 declared' attribute, it's always true.
25212 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
25213 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
25214 temporary wrapper for FindMembers which tells MemberLookup whether
25215 members from the base classes are included in the return value.
25216 This will go away soon.
25217 (TypeManager.MemberLookup): Use this temporary hack here; once the
25218 new MemberCache is completed, we don't need to do the DeclaredOnly
25219 looping here anymore since the MemberCache will take care of this.
25220 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
25221 (MemberCache): When creating the MemberCache for a class, get
25222 members from the current class and all its base classes.
25223 (MemberCache.CacheEntry.Container): New field. This is a
25224 temporary hack until the Mono runtime is fixed to distinguish
25225 between ReflectedType and DeclaringType. It allows us to use MCS
25226 with both the MS runtime and the unfixed Mono runtime without
25227 problems and without accecting performance.
25228 (MemberCache.SearchMembers): The DeclaredOnly looping from
25229 TypeManager.MemberLookup is now done here.
25231 2002-08-14 Martin Baulig <martin@gnome.org>
25233 * statement.cs (MyStructInfo.MyStructInfo): Don't call
25234 Type.GetFields on dynamic types but get the fields from the
25235 corresponding TypeContainer.
25236 (MyStructInfo.GetStructInfo): Added check for enum types.
25238 * typemanager.cs (MemberList.IsSynchronized): Implemented.
25239 (MemberList.SyncRoot): Implemented.
25240 (TypeManager.FilterWithClosure): No need to check permissions if
25241 closure_start_type == closure_invocation_type, don't crash if
25242 closure_invocation_type is null.
25244 2002-08-13 Martin Baulig <martin@gnome.org>
25246 Rewrote TypeContainer.FindMembers to use a member cache. This
25247 gives us a speed increase of about 35% for the self-hosting MCS
25248 build and of about 15-20% for the class libs (both on GNU/Linux).
25250 * report.cs (Timer): New class to get enhanced profiling. This
25251 whole class is "TIMER" conditional since it remarkably slows down
25254 * class.cs (MemberList): New class. This is an IList wrapper
25255 which we're now using instead of passing MemberInfo[]'s around to
25256 avoid copying this array unnecessarily.
25257 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
25258 (ICachingMemberFinder, IMemberContainer): New interface.
25259 (TypeManager.FilterWithClosure): If `criteria' is null, the name
25260 has already been checked, otherwise use it for the name comparision.
25261 (TypeManager.FindMembers): Renamed to RealMemberFinder and
25262 provided wrapper which tries to use ICachingMemberFinder.FindMembers
25263 if possible. Returns a MemberList, not a MemberInfo [].
25264 (TypeHandle): New class, implements IMemberContainer. We create
25265 one instance of this class per type, it contains a MemberCache
25266 which is used to do the member lookups.
25267 (MemberCache): New class. Each instance of this class contains
25268 all members of a type and a name-based hash table.
25269 (MemberCache.FindMembers): This is our new member lookup
25270 function. First, it looks up all members of the requested name in
25271 the hash table. Then, it walks this list and sorts out all
25272 applicable members and returns them.
25274 2002-08-13 Martin Baulig <martin@gnome.org>
25276 In addition to a nice code cleanup, this gives us a performance
25277 increase of about 1.4% on GNU/Linux - not much, but it's already
25278 half a second for the self-hosting MCS compilation.
25280 * typemanager.cs (IMemberFinder): New interface. It is used by
25281 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25282 Enum, Delegate or Interface.
25283 (TypeManager.finder_to_member_finder): New PtrHashtable.
25284 (TypeManager.finder_to_container): Removed.
25285 (TypeManager.finder_to_delegate): Removed.
25286 (TypeManager.finder_to_interface): Removed.
25287 (TypeManager.finder_to_enum): Removed.
25289 * interface.cs (Interface): Implement IMemberFinder.
25291 * delegate.cs (Delegate): Implement IMemberFinder.
25293 * enum.cs (Enum): Implement IMemberFinder.
25295 * class.cs (TypeContainer): Implement IMemberFinder.
25297 2002-08-12 Martin Baulig <martin@gnome.org>
25299 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25301 2002-08-12 Martin Baulig <martin@gnome.org>
25303 * ecore.cs (ITypeExpression): New interface for expressions which
25305 (TypeExpression): Renamed to TypeLookupExpression.
25306 (Expression.DoResolve): If we're doing a types-only lookup, the
25307 expression must implement the ITypeExpression interface and we
25308 call DoResolveType() on it.
25309 (SimpleName): Implement the new ITypeExpression interface.
25310 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25311 hack, the situation that we're only looking up types can't happen
25312 anymore when this method is called. Moved the type lookup code to
25313 DoResolveType() and call it.
25314 (SimpleName.DoResolveType): This ITypeExpression interface method
25315 is now doing the types-only lookup.
25316 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25317 (ResolveFlags): Added MaskExprClass.
25319 * expression.cs (MemberAccess): Implement the ITypeExpression
25321 (MemberAccess.DoResolve): Added support for a types-only lookup
25322 when we're called via ITypeExpression.DoResolveType().
25323 (ComposedCast): Implement the ITypeExpression interface.
25325 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25326 Expression.Resolve() with ResolveFlags.Type instead.
25328 2002-08-12 Martin Baulig <martin@gnome.org>
25330 * interface.cs (Interface.Define): Apply attributes.
25332 * attribute.cs (Attribute.ApplyAttributes): Added support for
25333 interface attributes.
25335 2002-08-11 Martin Baulig <martin@gnome.org>
25337 * statement.cs (Block.Emit): Only check the "this" variable if we
25338 do not always throw an exception.
25340 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25341 whether the property has a set accessor.
25343 2002-08-11 Martin Baulig <martin@gnome.org>
25345 Added control flow analysis support for structs.
25347 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25348 with control flow analysis turned off.
25349 (IVariable): New interface.
25350 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25351 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25352 (FieldExpr.DoResolve): Resolve the instance expression with flow
25353 analysis turned off and do the definite assignment check after the
25354 resolving when we know what the expression will resolve to.
25356 * expression.cs (LocalVariableReference, ParameterReference):
25357 Implement the new IVariable interface, only call the flow analysis
25358 code if ec.DoFlowAnalysis is true.
25359 (This): Added constructor which takes a Block argument. Implement
25360 the new IVariable interface.
25361 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25362 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25363 This does the definite assignment checks for struct members.
25365 * class.cs (Constructor.Emit): If this is a non-static `struct'
25366 constructor which doesn't have any initializer, call
25367 Block.AddThisVariable() to tell the flow analysis code that all
25368 struct elements must be initialized before control returns from
25371 * statement.cs (MyStructInfo): New public class.
25372 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25373 argument to this indexer. If non-zero, check an individual struct
25374 member, not the whole struct.
25375 (FlowBranching.CheckOutParameters): Check struct members.
25376 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25377 overloaded versions of these methods which take an additional
25378 `int field_idx' argument to check struct members.
25379 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25380 overloaded versions of these methods which take an additional
25381 `string field_name' argument to check struct member.s
25382 (VariableInfo): Implement the IVariable interface.
25383 (VariableInfo.StructInfo): New public property. Returns the
25384 MyStructInfo instance of the variable if it's a struct or null.
25385 (Block.AddThisVariable): New public method. This is called from
25386 Constructor.Emit() for non-static `struct' constructor which do
25387 not have any initializer. It creates a special variable for the
25388 "this" instance variable which will be checked by the flow
25389 analysis code to ensure that all of the struct's fields are
25390 initialized before control returns from the constructor.
25391 (UsageVector): Added support for struct members. If a
25392 variable/parameter is a struct with N members, we reserve a slot
25393 in the usage vector for each member. A struct is considered fully
25394 initialized if either the struct itself (slot 0) or all its
25395 members are initialized.
25397 2002-08-08 Martin Baulig <martin@gnome.org>
25399 * driver.cs (Driver.MainDriver): Only report an error CS5001
25400 if there were no compilation errors.
25402 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25403 `UnsafeContext' property to determine whether the parent is in
25404 unsafe context rather than checking the parent's ModFlags:
25405 classes nested in an unsafe class are unsafe as well.
25407 2002-08-08 Martin Baulig <martin@gnome.org>
25409 * statement.cs (UsageVector.MergeChildren): Distinguish between
25410 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25411 we return. Added test17() and test18() to test-154.cs.
25413 2002-08-08 Martin Baulig <martin@gnome.org>
25415 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25416 Family access, make sure the invoking type isn't a subclass of the
25417 queried type (that'd be a CS1540).
25419 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25420 this method which takes an additional `Type invocation_type'.
25422 * expression.cs (BaseAccess.DoResolve): Use the base type as
25423 invocation and query type.
25424 (MemberAccess.DoResolve): If the lookup failed and we're about to
25425 report a CS0122, try a lookup with the ec.ContainerType - if this
25426 succeeds, we must report a CS1540.
25428 2002-08-08 Martin Baulig <martin@gnome.org>
25430 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25431 (MethodGroupExpr): Implement the IMemberExpr interface.
25433 * expression (MemberAccess.ResolveMemberAccess): No need to have
25434 any special code for MethodGroupExprs anymore, they're now
25437 2002-08-08 Martin Baulig <martin@gnome.org>
25439 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25440 Family, FamANDAssem and FamORAssem permissions.
25441 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25443 2002-08-08 Martin Baulig <martin@gnome.org>
25445 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25446 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25449 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25451 * driver.cs: implemented /resource option to embed managed resources.
25453 2002-08-07 Martin Baulig <martin@gnome.org>
25455 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25456 (FieldBase.HasFieldInitializer): New public property.
25457 (FieldBase.GetInitializerExpression): New public method. Resolves and
25458 returns the field initializer and makes sure it is only resolved once.
25459 (TypeContainer.EmitFieldInitializers): Call
25460 FieldBase.GetInitializerExpression to get the initializer, this ensures
25461 that it isn't resolved multiple times.
25463 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25464 the resolving process (SimpleName/MemberLookup) that we're currently
25465 emitting a field initializer (which must not access any instance members,
25466 this is an error CS0236).
25468 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25469 argument, if the `IsFieldInitializer' flag is set, we must report and
25470 error CS0236 and not an error CS0120.
25472 2002-08-07 Martin Baulig <martin@gnome.org>
25474 * ecore.cs (IMemberExpr): New public interface.
25475 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25476 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25477 if the expression is an IMemberExpr.
25479 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25480 to be null, implicitly default to `this' if we're non-static in
25481 this case. Simplified the code a lot by using the new IMemberExpr
25482 interface. Also fixed bug #28176 here.
25484 2002-08-06 Martin Baulig <martin@gnome.org>
25486 * cs-parser.jay (SimpleLookup): Removed. We need to create
25487 ParameterReferences during semantic analysis so that we can do a
25488 type-only search when resolving Cast, TypeOf and SizeOf.
25489 (block): Pass the `current_local_parameters' to the Block's
25492 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25493 argument to the constructor.
25494 (ConstructorInitializer.Resolve): Create a temporary implicit
25495 block with the parameters.
25497 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25498 references here if we aren't doing a type-only search.
25500 * statement.cs (Block): Added constructor which takes a
25501 `Parameters parameters' argument.
25502 (Block.Parameters): New public property.
25504 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25505 to `Parameters' and made it public readonly.
25507 2002-08-06 Martin Baulig <martin@gnome.org>
25509 * ecore.cs (Expression.Warning): Made this public as well.
25511 * report.cs (Report.Debug): Print the contents of collections.
25513 2002-08-06 Martin Baulig <martin@gnome.org>
25515 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25516 used to tell Resolve() which kinds of expressions it may return.
25517 (Expression.Resolve): Added overloaded version of this method which
25518 takes a `ResolveFlags flags' argument. This can be used to tell
25519 Resolve() which kinds of expressions it may return. Reports a
25521 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25522 ResolveFlags.SimpleName.
25523 (Expression.Error118): Added overloaded version of this method which
25524 takes a `ResolveFlags flags' argument. It uses the flags to determine
25525 which kinds of expressions are allowed.
25527 * expression.cs (Argument.ResolveMethodGroup): New public method.
25528 Resolves an argument, but allows a MethodGroup to be returned.
25529 This is used when invoking a delegate.
25531 * TODO: Updated a bit.
25533 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25535 Fixed compilation with csc.
25537 * ecore.cs: Expression.Error made public. Is this correct? Should
25538 Warning be made public too?
25540 * expression.cs: use ea.Location instead of ea.loc.
25541 [FIXME: Filed as bug #28607: MCS must report these errors.]
25543 2002-08-06 Martin Baulig <martin@gnome.org>
25545 * ecore.cs (Expression.loc): Moved the location here instead of
25546 duplicating it in all derived classes.
25547 (Expression.Location): New public property.
25548 (Expression.Error, Expression.Warning): Made them non-static and
25549 removed the location argument.
25550 (Expression.Warning): Added overloaded version which takes an
25551 `int level' argument.
25552 (Expression.Error118): Make this non-static and removed the
25553 expression and location arguments.
25554 (TypeExpr): Added location argument to the constructor.
25556 * expression.cs (StaticCallExpr): Added location argument to
25558 (Indirection, PointerArithmetic): Likewise.
25559 (CheckedExpr, UnCheckedExpr): Likewise.
25560 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25561 (StringPtr): Likewise.
25564 2002-08-05 Martin Baulig <martin@gnome.org>
25566 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25568 * assign.cs (Assign.DoResolve): Check whether the source
25569 expression is a value or variable.
25571 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25572 while resolving the corresponding blocks.
25574 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25575 an error, don't silently return null.
25577 * statement.cs (Block.AddVariable): Do the error reporting here
25578 and distinguish between CS0128 and CS0136.
25579 (Block.DoResolve): Report all unused labels (warning CS0164).
25580 (LabeledStatement): Pass the location to the constructor.
25581 (LabeledStatement.HasBeenReferenced): New property.
25582 (LabeledStatement.Resolve): Set it to true here.
25584 * statement.cs (Return.Emit): Return success even after reporting
25585 a type mismatch error (CS0126 or CS0127), this is what csc does and
25586 it avoids confusing the users with any consecutive errors.
25588 2002-08-05 Martin Baulig <martin@gnome.org>
25590 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25592 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25594 * expression.cs (MemberAccess.DoResolve): Silently return if an
25595 error has already been reported.
25597 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25598 error has already been reported.
25600 2002-08-05 Martin Baulig <martin@gnome.org>
25602 * statement.cs (UsageVector): Only initialize the `parameters'
25603 vector if we actually have any "out" parameters.
25605 2002-08-05 Martin Baulig <martin@gnome.org>
25607 * expression.cs (Binary.ResolveOperator): When combining delegates,
25608 they must have the same type.
25610 2002-08-05 Martin Baulig <martin@gnome.org>
25612 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25613 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25614 work with the ms runtime and we also don't need it: if we're a
25615 PropertyBuilder and not in the `indexer_arguments' hash, then we
25616 are a property and not an indexer.
25618 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25619 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25620 since the latter one doesn't work with the ms runtime.
25622 2002-08-03 Martin Baulig <martin@gnome.org>
25624 Fixed bugs #27998 and #22735.
25626 * class.cs (Method.IsOperator): New public field.
25627 (Method.CheckBase): Report CS0111 if there's already a method
25628 with the same parameters in the current class. Report CS0508 when
25629 attempting to change the return type of an inherited method.
25630 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25631 and it's not marked abstract or extern.
25632 (PropertyBase): New abstract base class for Property and Indexer.
25633 (PropertyBase.CheckBase): Moved here from Property and made it work
25635 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25636 the same so we can reuse it there.
25637 (Property, Indexer): Derive from PropertyBase.
25638 (MethodSignature.inheritable_property_signature_filter): New delegate
25639 to find properties and indexers.
25641 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25642 argument and improved error reporting.
25644 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25645 EmptyReadOnlyParameters and made it a property.
25647 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25648 version of this method which takes a `PropertyInfo indexer'.
25649 (TypeManager.RegisterIndexer): New method.
25651 * class.cs: Added myself as author of this file :-)
25653 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25655 * class.cs: fixed compilation on windoze.
25657 2002-08-03 Martin Baulig <martin@gnome.org>
25659 * interface.cs (Interface.GetInterfaceBases): Check whether all
25660 base interfaces are at least as accessible than the current one.
25662 * class.cs (TypeContainer.GetClassBases): Check whether base types
25663 are at least as accessible than the current type.
25664 (TypeContainer.AsAccessible): Implemented and made non-static.
25665 (MemberBase.CheckParameters): Report errors if the accessibility
25668 * delegate.cs (Delegate.Delegate): The default visibility is
25669 internal for top-level types and private for nested types.
25670 (Delegate.Define): Report errors if the accessibility checks fail.
25672 * enum.cs (Enum.Enum): The default visibility is internal for
25673 top-level types and private for nested types.
25674 (Enum.DefineType): Compute the correct visibility.
25676 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25677 function which takes a `bool is_toplevel' instead of a TypeContainer.
25679 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25682 2002-08-02 Martin Baulig <martin@gnome.org>
25684 * expression.cs (LocalVariableReferenc): Added constructor which
25685 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25686 (LocalVariableReference.IsReadOnly): New property.
25687 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25688 variable is readonly, use our own readonly flag to do this; you can
25689 use the new constructor to get a writable reference to a read-only
25692 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25693 reference to the local variable.
25695 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25697 * rootcontext.cs (ResolveCore): Also include System.Exception
25699 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25700 we reach an EmptyStatement.
25702 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25705 * expression.cs (Binary.ResolveOperator): Check error result in
25708 use brtrue/brfalse directly and avoid compares to null.
25710 2002-08-02 Martin Baulig <martin@gnome.org>
25712 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25713 Fixes bug #28407, added test-155.cs.
25715 2002-08-01 Martin Baulig <martin@gnome.org>
25717 * class.cs (Event.EmitDefaultMethod): Make this work with static
25718 events. Fixes #28311, added verify-3.cs.
25720 2002-08-01 Martin Baulig <martin@gnome.org>
25722 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25723 `is_disposable' fields.
25724 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25725 `hm.is_disposable' if we're using the collection pattern.
25726 (Foreach.EmitCollectionForeach): Use the correct type for the
25727 enumerator's local variable, only emit the try/finally block if
25728 necessary (fixes #27713).
25730 2002-08-01 Martin Baulig <martin@gnome.org>
25732 * ecore.cs (Expression.report118): Renamed to Error118 and made
25735 * statement.cs (Throw.Resolve): Check whether the expression is of
25736 the correct type (CS0118) and whether the type derives from
25737 System.Exception (CS0155).
25738 (Catch.Resolve): New method. Do the type lookup here and check
25739 whether it derives from System.Exception (CS0155).
25740 (Catch.CatchType, Catch.IsGeneral): New public properties.
25742 * typemanager.cs (TypeManager.exception_type): Added.
25744 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25746 * driver.cs: Updated About function.
25748 2002-07-31 Martin Baulig <martin@gnome.org>
25750 Implemented Control Flow Analysis.
25752 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25753 (EmitContext.CurrentBranching): Added.
25754 (EmitContext.StartFlowBranching): Added.
25755 (EmitContext.EndFlowBranching): Added.
25756 (EmitContext.KillFlowBranching): Added.
25757 (EmitContext.IsVariableAssigned): Added.
25758 (EmitContext.SetVariableAssigned): Added.
25759 (EmitContext.IsParameterAssigned): Added.
25760 (EmitContext.SetParameterAssigned): Added.
25761 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25762 Added control flow analysis stuff here.
25764 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25765 resolve the expression as lvalue.
25766 (LocalVariableReference.DoResolve): Check whether the variable has
25767 already been assigned.
25768 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25769 the parameter as assigned here.
25770 (ParameterReference.DoResolve): Check whether the parameter has already
25772 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25773 expression as lvalue.
25775 * statement.cs (FlowBranching): New class for the flow analysis code.
25776 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25777 (LabeledStatement.IsDefined): New public property.
25778 (LabeledStatement.AddUsageVector): New public method to tell flow
25779 analyis that the label may be reached via a forward jump.
25780 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25782 (VariableInfo.Number): New public field. This is used by flow analysis
25783 to number all locals of a block.
25784 (Block.CountVariables): New public property. This is the number of
25785 local variables in this block (including the locals from all parent
25787 (Block.EmitMeta): Number all the variables.
25789 * statement.cs: Added flow analysis support to all classes.
25791 2002-07-31 Martin Baulig <martin@gnome.org>
25793 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25794 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25795 then use this argument.
25797 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25799 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25800 use this to specify /define options.
25802 2002-07-29 Martin Baulig <martin@gnome.org>
25804 * statement.cs (Fixed): Moved all code that does variable lookups
25805 and resolvings from Emit to Resolve.
25807 * statement.cs (For): Moved all code that does variable lookups
25808 and resolvings from Emit to Resolve.
25810 * statement.cs (Using): Moved all code that does variable lookups
25811 and resolvings from Emit to Resolve.
25813 2002-07-29 Martin Baulig <martin@gnome.org>
25815 * attribute.cs (Attribute.Resolve): Explicitly catch a
25816 System.NullReferenceException when creating the
25817 CustromAttributeBuilder and report a different warning message.
25819 2002-07-29 Martin Baulig <martin@gnome.org>
25821 * support.cs (ParameterData.ParameterName): Added method to
25822 get the name of a parameter.
25824 * typemanager.cs (TypeManager.IsValueType): New public method.
25826 2002-07-29 Martin Baulig <martin@gnome.org>
25828 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25829 is a flag which specifies that it's either ref or out.
25830 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25831 the out parameter to `out Parameter.Modifier mod', also set the
25832 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25834 * support.cs (InternalParameters.ParameterModifier): Distinguish
25835 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25836 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25838 * expression.cs (Argument.GetParameterModifier): Distinguish
25839 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25840 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25842 2002-07-29 Martin Baulig <martin@gnome.org>
25844 * expression.cs (ParameterReference.ParameterReference): Added
25845 `Location loc' argument to the constructor.
25847 * cs-parser.jay: Pass location to ParameterReference.
25849 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25851 * statement.cs (Try): Initialize the location.
25853 * cs-parser.jay: pass location to Try.
25855 * expression.cs (Unary.Reduce): Change the prototype to return
25856 whether a constant fold could be performed or not. The result is
25857 returned in an out parameters. In the case of Indirection and
25858 AddressOf, we want to perform the full tests.
25860 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25862 * statement.cs (Statement.Emit): Flag dead code.
25864 2002-07-27 Andrew Birkett <andy@nobugs.org>
25866 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25868 2002-07-27 Martin Baulig <martin@gnome.org>
25870 * class.cs (MethodData.Define): Put back call to
25871 TypeManager.AddMethod(), accidentally commented this out.
25873 * report.cs (Debug): New public method to print debugging information,
25874 this is `[Conditional ("DEBUG")]'.
25876 2002-07-26 Martin Baulig <martin@gnome.org>
25878 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25879 (switch_statement): Push the current_block to the switch_stack and
25880 pop it again when we're done with the switch.
25881 (switch_section): The new block is a child of the current_block.
25882 Fixes bug #24007, added test-152.cs.
25884 2002-07-27 Martin Baulig <martin@gnome.org>
25886 * expression.cs (Invocation.EmitArguments): When calling a varargs
25887 function with only its fixed arguments, we need to pass an empty
25890 2002-07-27 Martin Baulig <martin@gnome.org>
25892 Mono 0.13 has been released.
25894 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25896 * driver.cs: Rename --resource to --linkres, because that is what
25897 we do currently, we dont support --resource yet.
25899 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25901 2002-07-25 Martin Baulig <martin@gnome.org>
25903 * class.cs (MethodData): New public class. This is a `method builder'
25904 class for a method or one accessor of a Property/Indexer/Event.
25905 (MethodData.GetMethodFlags): Moved here from MemberBase.
25906 (MethodData.ApplyAttributes): Likewise.
25907 (MethodData.ApplyObsoleteAttribute): Likewise.
25908 (MethodData.ApplyConditionalAttribute): Likewise.
25909 (MethodData.ApplyDllImportAttribute): Likewise.
25910 (MethodData.CheckAbstractAndExternal): Likewise.
25911 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25912 (MethodData.Emit): Formerly known as Method.Emit().
25913 (MemberBase): Moved everything which was specific to a single
25914 accessor/method to MethodData.
25915 (Method): Create a new MethodData and call Define() and Emit() on it.
25916 (Property, Indexer, Event): Create a new MethodData objects for each
25917 accessor and call Define() and Emit() on them.
25919 2002-07-25 Martin Baulig <martin@gnome.org>
25921 Made MethodCore derive from MemberBase to reuse the code from there.
25922 MemberBase now also checks for attributes.
25924 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25925 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25927 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25928 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25929 (MemberBase.ApplyAttributes): New virtual method; applies the
25930 attributes to a method or accessor.
25931 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25932 (MemberBase.ApplyConditionalAttribute): Likewise.
25933 (MemberBase.ApplyDllImportAttribute): Likewise.
25934 (MemberBase.CheckAbstractAndExternal): Likewise.
25935 (MethodCore.ParameterTypes): This is now a property instead of a
25936 method, it's initialized from DoDefineParameters().
25937 (MethodCore.ParameterInfo): Removed the set accessor.
25938 (MethodCore.DoDefineParameters): New protected virtual method to
25939 initialize ParameterTypes and ParameterInfo.
25940 (Method.GetReturnType): We can now simply return the MemberType.
25941 (Method.GetMethodFlags): Override the MemberBase version and add
25942 the conditional flags.
25943 (Method.CheckBase): Moved some code from Define() here, call
25944 DoDefineParameters() here.
25945 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25946 here to avoid some larger code duplication.
25947 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25948 ensure that abstract and external accessors don't declare a body.
25950 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25951 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25952 lookup in the attribute's parent classes, so we need to abort as soon
25953 as we found the first match.
25954 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25955 the attribute has no arguments.
25957 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25960 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25962 * cs-parser.jay: reverted previous patch.
25964 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25966 * cs-parser.jay: fixed bug #22119.
25968 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25970 * attribute.cs: fixed compilation. The error was:
25971 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25972 be assigned to before control leaves the current method."
25973 [FIXME: Filed as bug #28186: MCS must report this error.]
25975 2002-07-25 Martin Baulig <martin@gnome.org>
25977 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25978 method to pull the condition name ouf of a Conditional attribute.
25979 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25980 the obsolete message and error flag out of an Obsolete attribute.
25982 * class.cs (Method.GetMethodFlags): New public method to get the
25983 TypeManager.MethodFlags for this method.
25984 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25986 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25987 if we're overriding a virtual function, set the new private variable
25988 `parent_method'; call the new TypeManager.AddMethod().
25990 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25991 the MethodBuilder and the Method in a PtrHashtable.
25992 (TypeManager.builder_to_method): Added for this purpose.
25993 (TypeManager.MethodFlags): Added IsObsoleteError.
25994 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25995 Obsolete and Conditional arguments in MethodBuilders. If we discover
25996 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25997 the message from the attribute.
25999 2002-07-24 Martin Baulig <martin@gnome.org>
26001 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
26002 preprocessor directives, ensure that the argument to #define/#undef is
26003 exactly one identifier and that it's actually an identifier.
26005 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
26008 2002-07-24 Martin Baulig <martin@gnome.org>
26010 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
26011 initialize it to TypeManager.object_type in the constructor.
26012 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
26013 of the `hm.get_current' method if we're using the collection pattern.
26014 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
26015 for the explicit conversion to make it work when we're using the collection
26016 pattern and the `Current' property has a different return type than `object'.
26019 2002-07-24 Martin Baulig <martin@gnome.org>
26021 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
26022 does not match, but don't report any errors. This method is called in
26023 order for all methods in a MethodGroupExpr until a matching method is
26024 found, so we don't want to bail out if the first method doesn't match.
26025 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
26026 matches, report the 123. Fixes #28070.
26028 2002-07-24 Martin Baulig <martin@gnome.org>
26030 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
26031 TypeManager.TypeToCoreType() to the top of the method so the
26032 following equality checks will work. Fixes #28107.
26034 2002-07-24 Martin Baulig <martin@gnome.org>
26036 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
26037 operand is of type uint, and the other operand is of type sbyte,
26038 short or int, the operands are converted to type long." -
26039 Actually do what this comment already told us. Fixes bug #28106,
26042 2002-07-24 Martin Baulig <martin@gnome.org>
26044 * class.cs (MethodBase): New abstract class. This is now a base
26045 class for Property, Indexer and Event to avoid some code duplication
26046 in their Define() and DefineMethods() methods.
26047 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
26048 generic methods for Define() and DefineMethods().
26049 (FieldBase): Derive from MemberBase, not MemberCore.
26050 (Property): Derive from MemberBase, not MemberCore.
26051 (Property.DefineMethod): Moved all the code from this method to the
26052 new MethodBase.DefineAccessor(), just call it with appropriate
26054 (Property.Define): Call the new Property.DoDefine(), this does some
26055 sanity checks and we don't need to duplicate the code everywhere.
26056 (Event): Derive from MemberBase, not MemberCore.
26057 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
26058 accessors, this will also make them work with interface events.
26059 (Indexer): Derive from MemberBase, not MemberCore.
26060 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
26061 (Indexer.Define): Use the new MethodBase functions.
26063 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
26064 argument to the constructor.
26065 (Interface.FindMembers): Added support for interface events.
26066 (Interface.PopluateEvent): Implemented.
26068 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
26070 2002-07-22 Miguel de Icaza <miguel@ximian.com>
26072 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
26073 but this is required to check for a method name being the same as
26074 the containing class.
26078 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26080 * interface.cs: initialize variable.
26082 2002-07-23 Martin Baulig <martin@gnome.org>
26084 Implemented the IndexerName attribute in interfaces.
26086 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
26087 name if this is an explicit interface implementation.
26088 (Indexer.InterfaceIndexerName): New public variable. If we're
26089 implementing an interface indexer, this is the IndexerName in that
26090 interface. Otherwise, it's the IndexerName.
26091 (Indexer.DefineMethod): If we're implementing interface indexer,
26092 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
26093 and Pending.ImplementIndexer methods.
26094 (Indexer.Define): Also define the PropertyBuilder if we're
26095 implementing an interface indexer and this is neither an explicit
26096 interface implementation nor do the IndexerName match the one in
26099 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
26100 If a method is defined here, then we always need to create a proxy
26101 for it. This is used when implementing interface indexers.
26102 (Pending.IsInterfaceIndexer): New public method.
26103 (Pending.ImplementIndexer): New public method.
26104 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
26105 This is used when implementing interface indexers to define a proxy
26107 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
26108 define a proxy if necessary.
26110 * interface.cs (Interface.IndexerName): New public variable.
26111 (Interface.PopulateIndexer): Set the IndexerName.
26112 (Interface.DefineIndexers): New private method. Populate all the
26113 indexers and make sure their IndexerNames match.
26115 * typemanager.cs (IndexerPropertyName): Added support for interface
26118 2002-07-22 Martin Baulig <martin@gnome.org>
26120 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
26121 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
26122 ret if HasReturnLabel.
26123 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
26126 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
26127 and set the ec.LoopBeginTryCatchLevel.
26128 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
26129 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
26130 the current ec.TryCatchLevel, the branch goes out of an exception
26131 block. In this case, we need to use Leave and not Br.
26133 2002-07-22 Martin Baulig <martin@gnome.org>
26135 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
26136 block unless the block does not always return or it is contained in
26137 another try { ... } catch { ... } block. Fixes bug #26506.
26138 Added verify-1.cs to the test suite.
26140 2002-07-22 Martin Baulig <martin@gnome.org>
26142 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
26143 then we do not always return. Fixes bug #24985.
26145 2002-07-22 Martin Baulig <martin@gnome.org>
26147 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
26148 lookup on a per-class level; ie. walk up the class hierarchy until we
26149 found at least one applicable method, then choose the best among them.
26150 Fixes bug #24463 and test-29.cs.
26152 2002-07-22 Martin Baulig <martin@gnome.org>
26154 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
26155 return types of the methods. The return type is not part of the
26156 signature and we must not check it to make the `new' modifier work.
26157 Fixes bug #27999, also added test-147.cs.
26158 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
26160 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
26161 on the method's return type.
26163 2002-07-21 Martin Baulig <martin@gnome.org>
26165 * assign.cs: Make this work if the rightmost source is a constant and
26166 we need to do an implicit type conversion. Also adding a few more tests
26167 to test-38.cs which should have caught this.
26169 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
26170 target in the makefile for this. The makefile.gnu is primarily intended
26171 for end-users who don't want to debug the compiler.
26173 2002-07-21 Martin Baulig <martin@gnome.org>
26175 * assign.cs: Improved the Assign class so it can now handle embedded
26176 assignments (X = Y = Z = something). As a side-effect this'll now also
26177 consume less local variables. test-38.cs now passes with MCS, added
26178 a few new test cases to that test.
26180 2002-07-20 Martin Baulig <martin@gnome.org>
26182 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
26183 instructions. Fixes bug #27977, also added test-146.cs.
26185 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26187 * cs-tokenizer.cs: fixed getHex ().
26189 2002-07-19 Martin Baulig <martin@gnome.org>
26191 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
26192 not Type.GetType() to lookup the array type. This is needed when
26193 we're constructing an array of a user-defined type.
26194 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
26195 single-dimensional arrays, but also for single-dimensial arrays of
26198 2002-07-19 Martin Baulig <martin@gnome.org>
26200 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
26201 this function is called, it's not allowed to share LocalBuilders
26202 among ILGenerators.
26204 2002-07-19 Martin Baulig <martin@gnome.org>
26206 * expression.cs (Argument.Resolve): Report an error 118 when trying
26207 to pass a type as argument.
26209 2002-07-18 Martin Baulig <martin@gnome.org>
26211 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
26212 Conv_R_Un for the signed `long' type.
26214 2002-07-15 Miguel de Icaza <miguel@ximian.com>
26216 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
26217 `expr' for the temporary result, as that will fail if we do
26218 multiple resolves on the same expression.
26220 2002-07-05 Miguel de Icaza <miguel@ximian.com>
26222 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
26223 ec.TypeContainer for looking up aliases.
26225 * class.cs (TypeContainer): Remove LookupAlias from here.
26227 * decl.cs (DeclSpace); Move here.
26229 2002-07-01 Miguel de Icaza <miguel@ximian.com>
26231 * class.cs (FindMembers): Only call filter if the constructor
26232 bulider is not null.
26234 Also handle delegates in `NestedTypes' now. Now we will perform
26235 type lookups using the standard resolution process. This also
26238 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
26239 This uses Expressions (the limited kind that can be parsed by the
26240 tree) instead of strings.
26242 * expression.cs (ComposedCast.ToString): Implement, used to flag
26243 errors since now we have to render expressions.
26245 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
26248 * ecore.cs (SimpleName.ToString): ditto.
26250 * cs-parser.jay: Instead of using strings to assemble types, use
26251 Expressions to assemble the type (using SimpleName, ComposedCast,
26252 MemberAccess). This should fix the type lookups in declarations,
26253 because we were using a different code path for this.
26255 * statement.cs (Block.Resolve): Continue processing statements
26256 even when there is an error.
26258 2002-07-17 Miguel de Icaza <miguel@ximian.com>
26260 * class.cs (Event.Define): Also remove the `remove' method from
26261 the list of pending items.
26263 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
26264 generate more compact code.
26266 2002-07-17 Martin Baulig <martin@gnome.org>
26268 * const.cs (Const.LookupConstantValue): Add support for constant
26269 `unchecked' and `checked' expressions.
26270 Also adding test case test-140.cs for this.
26272 2002-07-17 Martin Baulig <martin@gnome.org>
26274 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26275 check whether mi.ReturnType implements the IEnumerator interface; the
26276 `==' and the IsAssignableFrom() will fail in this situation.
26278 2002-07-16 Ravi Pratap <ravi@ximian.com>
26280 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26283 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26285 * expression.cs: fixed bug #27811.
26287 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26289 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26290 Molaro: when we are a ref, the value already contains a pointer
26291 value, do not take the address of it.
26293 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26294 * removed mb-parser.jay and mb-tokenizer.cs
26296 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26298 * expression.cs: check against the building corlib void type.
26300 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26302 * ecore.cs: fix for valuetype static readonly fields: when
26303 initializing them, we need their address, not the address of a copy.
26305 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26307 * typemanager.cs: register also enum_type in corlib.
26309 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26311 * class.cs: allow calling this (but not base) initializers in structs.
26313 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26315 * ecore.cs: make sure we compare against the building base types
26318 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26320 * typemanager.cs: fix TypeToCoreType() to handle void and object
26321 (corlib gets no more typerefs after this change).
26323 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26325 * expression.cs (ArrayCreation.EmitArrayArguments): use
26326 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26328 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26329 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26330 array indexes, the runtime actually forbids them.
26332 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26333 for array arguments here.
26335 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26336 instead of the default for ValueTypes.
26338 (New.DoEmit): Use IsValueType instead of
26339 IsSubclassOf (value_type)
26340 (New.DoResolve): ditto.
26341 (Invocation.EmitCall): ditto.
26343 * assign.cs (Assign): ditto.
26345 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26346 Statements *are* currently doing part of their resolution during
26349 Expressions do always resolve during resolve, but statements are
26350 only required to propagate resolution to their children.
26352 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26354 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26356 (LoadAssembly): Do not add the dll if it is already specified
26358 (MainDriver): Add the System directory to the link path at the end,
26359 after all the other -L arguments.
26361 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26362 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26363 ldelem.u1) and using the opposite for sbytes.
26365 This fixes Digger, and we can finally run it.
26367 * driver.cs (UnixParseOption): Move the option parsing here.
26368 (CSCParseOption): Implement CSC-like parsing of options.
26370 We now support both modes of operation, the old Unix way, and the
26371 new CSC-like way. This should help those who wanted to make cross
26372 platform makefiles.
26374 The only thing broken is that /r:, /reference: and /lib: are not
26375 implemented, because I want to make those have the same semantics
26376 as the CSC compiler has, and kill once and for all the confussion
26377 around this. Will be doing this tomorrow.
26379 * statement.cs (Unsafe.Resolve): The state is checked during
26380 resolve, not emit, so we have to set the flags for IsUnsfe here.
26382 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26384 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26385 not catch the Error_ObjectRefRequired in SimpleName (as it is
26386 possible to have a class/instance variable name that later gets
26387 deambiguated), we have to check this here.
26389 2002-07-10 Ravi Pratap <ravi@ximian.com>
26391 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26392 make static and put into Expression.
26394 (Event.Define): Register the private field of the event with the
26395 TypeManager so that GetFieldFromEvent can get at it.
26397 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26398 keep track of the private field associated with an event which
26401 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26404 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26406 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26408 * expression.cs (Binary.EmitBranchable): this routine emits the
26409 Binary expression in a branchable context. This basically means:
26410 we need to branch somewhere, not just get the value on the stack.
26412 This works together with Statement.EmitBoolExpression.
26414 * statement.cs (Statement.EmitBoolExpression): Use
26417 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26419 * statement.cs (For): Reduce the number of jumps in loops.
26421 (For): Implement loop inversion for the For statement.
26423 (Break): We can be breaking out of a Try/Catch controlled section
26424 (foreach might have an implicit try/catch clause), so we need to
26425 use Leave instead of Br.
26427 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26428 now). If the instace expression supports IMemoryLocation, we use
26429 the AddressOf method from the IMemoryLocation to extract the
26430 address instead of emitting the instance.
26432 This showed up with `This', as we were emitting the instance
26433 always (Emit) instead of the Address of This. Particularly
26434 interesting when This is a value type, as we dont want the Emit
26435 effect (which was to load the object).
26437 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26439 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26441 * statement.cs (Checked): Set the CheckedState during the resolve
26442 process too, as the ConvCast operations track the checked state on
26443 the resolve process, and not emit.
26445 * cs-parser.jay (namespace_member_declaration): Flag that we have
26446 found a declaration when we do. This is used to flag error 1529
26448 * driver.cs: Report ok when we display the help only.
26450 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26452 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26454 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26456 * cs-tokenizer.cs (define): We also have to track locally the
26457 defines. AllDefines is just used for the Conditional Attribute,
26458 but we also need the local defines for the current source code.
26460 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26462 * statement.cs (While, For, Do): These loops can exit through a
26463 Break statement, use this information to tell whether the
26464 statement is the last piece of code.
26466 (Break): Flag that we break.
26468 * codegen.cs (EmitContexts): New `Breaks' state variable.
26470 2002-07-03 Martin Baulig <martin@gnome.org>
26472 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26473 modifiers in method declarations in structs. Otherwise, you won't
26474 be able to override things like Object.Equals().
26476 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26478 * class.cs (Method, Property, Indexer): Do not allow the public
26479 modifier to be used in explicit interface implementations.
26481 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26482 override modifiers in method declarations in structs
26484 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26486 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26487 integer or real overflow, report an error
26489 2002-07-02 Martin Baulig <martin@gnome.org>
26491 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26492 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26493 to tell the runtime about our newly created System.Object and
26494 System.ValueType types.
26496 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26498 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26499 struct instead of Ldarg/Starg.
26501 2002-07-02 Martin Baulig <martin@gnome.org>
26503 * expression.cs (Indirection.Indirection): Call
26504 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26506 2002-07-02 Martin Baulig <martin@gnome.org>
26508 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26509 ValueType, call TypeManager.TypeToCoreType() on it.
26510 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26511 the OpCodes.Newarr argument.
26513 2002-07-02 Martin Baulig <martin@gnome.org>
26515 * expression.cs (Invocation.EmitCall): When compiling corlib,
26516 replace all calls to the system's System.Array type to calls to
26517 the newly created one.
26519 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26520 System.Array methods.
26521 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26522 from the system's System.Array type which must be replaced.
26524 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26526 * typemanager.cs: load unverifiable_code_ctor so we can build
26527 corlib using the correct type. Avoid using GetTypeCode() with
26529 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26530 TypeManager.object_type to allow building corlib.
26532 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26534 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26536 2002-07-01 Martin Baulig <martin@gnome.org>
26538 * class.cs: Make the last change actually work, we need to check
26539 whether `ifaces != null' to avoid a crash.
26541 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26543 * class.cs: when we build structs without fields that implement
26544 interfaces, we need to add the interfaces separately, since there is
26545 no API to both set the size and add the interfaces at type creation
26548 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26550 * expression.cs: the dimension arguments to the array constructors
26551 need to be converted if they are a long.
26553 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26555 * class.cs: don't emit ldarg.0 if there is no parent constructor
26556 (fixes showstopper for corlib).
26558 2002-06-29 Martin Baulig <martin@gnome.org>
26560 MCS now compiles corlib on GNU/Linux :-)
26562 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26563 ie. check for MethodImplOptions.InternalCall.
26565 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26566 and TypeManager.attribute_type are null, so we must explicitly check
26567 whether parent is not null to find out whether it's an attribute type.
26568 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26569 and SetBuilder, not only if the property is neither abstract nor external.
26570 This is necessary to set the MethodImplOptions on the accessor methods.
26571 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26572 SetBuilder, see Property.Emit().
26574 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26575 populate "System.Object", "System.ValueType" and "System.Attribute" since
26576 they've already been populated from BootCorlib_PopulateCoreTypes().
26578 2002-06-29 Martin Baulig <martin@gnome.org>
26580 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26581 is the NullLiteral, we also need to make sure that target_type is not
26584 2002-06-29 Martin Baulig <martin@gnome.org>
26586 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26587 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26588 before calling BootstrapCorlib_ResolveDelegate ().
26590 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26592 * statement.cs: fixed build-breaker. All tests passed ok.
26594 2002-06-27 Martin Baulig <martin@gnome.org>
26596 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26597 for System.Decimal when compiling corlib.
26599 2002-06-27 Martin Baulig <martin@gnome.org>
26601 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26602 switch blocks which contain nothing but a default clause.
26604 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26606 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26608 2002-06-27 Martin Baulig <martin@gnome.org>
26610 * ecore.cs (PropertyExpr.PropertyExpr): Call
26611 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26613 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26614 is already a TypeBuilder.
26616 2002-06-27 Martin Baulig <martin@gnome.org>
26618 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26619 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26620 the "from an array-type to System.Array" case. This makes it work
26621 when compiling corlib.
26623 2002-06-27 Martin Baulig <martin@gnome.org>
26625 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26626 non-static PropertyExpr, set its InstanceExpression. This makes
26627 the `ICollection.Count' property work in System/Array.cs.
26629 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26631 * driver.cs: Made error handling more consistent. Errors now
26632 tracked by Report class, so many methods which used to return int
26633 now return void. Main() now prints success/failure and
26634 errors/warnings message.
26636 Renamed '--probe' compiler argument to '--expect-error'. Removed
26637 the magic number return values (123 and 124). Now, if the
26638 expected error occurs, the compiler exits with success (exit value
26639 0). If the compilation completes without seeing that particular
26640 error, the compiler exits with failure (exit value 1). The
26641 makefile in mcs/errors has been changed to handle the new behaviour.
26643 * report.cs: Made 'expected error' number a property and renamed
26644 it from 'Probe' to 'ExpectedError'.
26646 * genericparser.cs: Removed error handling support, since it is
26647 now all done by Report class.
26649 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26650 class, so parse() no longer returns an int.
26652 * namespace.cs: Use Report.Error instead of GenericParser.error
26654 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26656 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26657 TypeContainer.AddOperator): At the front of the list put the
26658 explicit implementations, so they get resolved/defined first.
26660 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26662 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26663 interface type is implemented by this TypeContainer. Used during
26664 explicit interface implementation.
26666 (Property.Define, Indexer.Define, Method.Define): Validate that
26667 the given interface in the explicit implementation is one of the
26668 base classes for the containing type.
26670 Also if we are explicitly implementing an interface, but there is
26671 no match in the pending implementation table, report an error.
26673 (Property.Define): Only define the property if we are
26674 not explicitly implementing a property from an interface. Use the
26675 correct name also for those properties (the same CSC uses,
26676 although that is really not needed).
26678 (Property.Emit): Do not emit attributes for explicitly implemented
26679 properties, as there is no TypeBuilder.
26681 (Indexer.Emit): ditto.
26683 Hiding then means that we do not really *implement* a pending
26684 implementation, which makes code fail.
26686 2002-06-22 Martin Baulig <martin@gnome.org>
26688 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26689 the return value of Object.GetType(). [FIXME: we need to do this whenever
26690 we get a type back from the reflection library].
26692 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26694 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26696 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26698 * attribute.cs: Return null if we can not look up the type.
26700 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26701 the interface types found.
26703 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26704 interface types found.
26706 * typemanager.cs (GetInterfaces): Make this routine returns alll
26707 the interfaces and work around the lame differences between
26708 System.Type and System.Reflection.Emit.TypeBuilder in the results
26709 result for GetInterfaces.
26711 (ExpandInterfaces): Given an array of interface types, expand and
26712 eliminate repeated ocurrences of an interface. This expands in
26713 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26716 2002-06-21 Martin Baulig <martin@gnome.org>
26718 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26721 2002-06-21 Martin Baulig <martin@gnome.org>
26723 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26724 and called with one of the core types, return the corresponding typebuilder for
26727 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26730 2002-06-21 Martin Baulig <martin@gnome.org>
26732 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26733 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26734 (Expression.ConvertReferenceExplicit): Likewise.
26736 * expression.cs (ElementAccess.DoResolve): Likewise.
26737 (ElementAccess.DoResolveLValue): Likewise.
26739 2002-06-10 Martin Baulig <martin@gnome.org>
26741 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26742 add the "value" parameter to the parameter list.
26744 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26747 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26749 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26750 the argument to an int, uint, long or ulong, per the spec. Also
26751 catch negative constants in array creation.
26753 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26755 * class.cs: do not allow the same interface to appear twice in
26756 the definition list.
26758 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26760 * ecore.cs: don't use ldlen with System.Array.
26762 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26764 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26766 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26768 * modifiers.cs: produce correct field attributes for protected
26769 internal. Easy fix so miguel can work on ther harder stuff:-)
26771 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26773 * pending.cs: New file. Move the code from class.cs here.
26774 Support clearning the pending flag for all methods (when not doing
26775 explicit interface implementation).
26777 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26779 * rootcontext.cs: added a couple more types needed to bootstrap.
26781 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26783 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26784 constructor in the type, instead of any constructor in the type
26785 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26786 a bug in the Mono runtime when applying the params attribute).
26788 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26789 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26791 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26793 * expression.cs (Unary.ResolveOperator): Use TypeManager
26794 to resolve the type.
26796 2002-06-13 Ravi Pratap <ravi@ximian.com>
26798 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26801 * enum.cs (AddEnumMember): Add support to store the attributes associated
26802 with each member too.
26804 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26805 field builders too - this takes care of the enum member case.
26807 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26809 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26810 address-of operator on both value types and pointers.
26812 2002-06-10 Martin Baulig <martin@gnome.org>
26814 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26815 PropertyBuilder to the `property_builders' list.
26817 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26818 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26819 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26820 find any indexers which are inherited from an interface.
26822 2002-06-09 Martin Baulig <martin@gnome.org>
26824 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26825 the same type as the constant if necessary. There's also a test-130.cs
26828 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26830 * typemanager.cs (TypeManager.ChangeType): Previously known as
26831 Enum.ChangeEnumType().
26833 2002-06-09 Martin Baulig <martin@gnome.org>
26835 * expression.cs (Cast.TryReduce): Added support for consts.
26837 2002-06-08 Ravi Pratap <ravi@ximian.com>
26839 * class.cs (Accessor): Hold attributes information so we can pass
26842 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26843 Modify to pass in attributes attached to the methods.
26845 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26847 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26848 to handle the Accessor kind :-)
26850 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26852 2002-06-08 Martin Baulig <martin@gnome.org>
26854 * expression.cs (Unary.TryReduceNegative): Added support for
26857 2002-06-08 Martin Baulig <martin@gnome.org>
26859 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26860 name can't be found in the `defined_names' - the caller will do a
26861 MemberLookup in this case and thus find methods in System.Enum
26862 such as Enum.IsDefined().
26864 2002-06-08 Martin Baulig <martin@gnome.org>
26866 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26867 Convert.ChangeType() which works with TypeBuilder created types.
26868 (Enum.LookupEnumValue, Enum.Define): Use it here.
26870 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26871 `TypeBuilder.BaseType != null' check.
26872 (TypeContainer.FindMembers): Only lookup parent members if we
26873 actually have a parent.
26874 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26875 (ConstructorInitializer.Resolve): Likewise.
26877 * interface.cs (Interface.FindMembers): Added
26878 `TypeBuilder.BaseType != null' check.
26880 * rootcontext.cs (RootContext.ResolveCore): Added
26881 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26882 classes_second_stage.
26884 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26885 debug_type and trace_type when compiling with --nostdlib.
26887 2002-06-07 Martin Baulig <martin@gnome.org>
26889 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26890 (AddField): Set it to true when adding a non-static field.
26891 (DefineType): Use `have_nonstatic_fields' to find out whether we
26892 have non-static fields, not `Fields != null'.
26894 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26896 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26897 dereferencing a null on the static-field code path)
26899 2002-05-30 Martin Baulig <martin@gnome.org>
26901 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26902 to take command line arguments. Use reflection to call the new
26903 custom `Initialize' function on the symbol writer and pass it the
26904 command line arguments.
26906 * driver.cs (--debug-args): New command line argument to pass command
26907 line arguments to the symbol writer.
26909 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26911 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26912 the target type for indexers and properties. Thanks to Joe for
26915 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26917 * typemanager.cs (MethodFlags): returns the method flags
26918 (Obsolete/ShouldIgnore) that control warning emission and whether
26919 the invocation should be made, or ignored.
26921 * expression.cs (Invocation.Emit): Remove previous hack, we should
26922 not do this on matching a base type, we should do this based on an attribute
26924 Only emit calls to System.Diagnostics.Debug and
26925 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26926 on the command line.
26928 * rootcontext.cs: Global settings for tracing and debugging.
26930 * cs-tokenizer.cs (define): New utility function to track
26931 defines. Set the global settings for TRACE and DEBUG if found.
26933 2002-05-25 Ravi Pratap <ravi@ximian.com>
26935 * interface.cs (Populate*): Pass in the TypeContainer as well as
26936 the DeclSpace as parameters so that we can create EmitContexts and
26937 then use that to apply attributes etc.
26939 (PopulateMethod, PopulateEvent, PopulateProperty)
26940 (PopulateIndexer): Apply attributes everywhere.
26942 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26945 (ApplyAttributes): Update accordingly.
26947 We now apply interface attributes for all members too.
26949 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26951 * class.cs (Indexer.Define); Correctly check if we are explicit
26952 implementation (instead of checking the Name for a ".", we
26953 directly look up if the InterfaceType was specified).
26955 Delay the creation of the PropertyBuilder.
26957 Only create the PropertyBuilder if we are not an explicit
26958 interface implementation. This means that explicit interface
26959 implementation members do not participate in regular function
26960 lookups, and hence fixes another major ambiguity problem in
26961 overload resolution (that was the visible effect).
26963 (DefineMethod): Return whether we are doing an interface
26966 * typemanager.cs: Temporary hack until we get attributes in
26967 interfaces (Ravi is working on that) and we get IndexerName
26968 support in interfaces.
26970 * interface.cs: Register the indexers as properties.
26972 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26973 warning, I have verified that this is a bug in the .NET runtime
26974 (JavaScript suffers of the same problem).
26976 * typemanager.cs (MemberLookup): When looking up members for
26977 interfaces, the parent of an interface is the implicit
26978 System.Object (so we succeed in searches of Object methods in an
26979 interface method invocation. Example: IEnumerable x; x.ToString
26982 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26984 * class.cs (Event): Events should also register if they do
26985 implement the methods that an interface requires.
26987 * typemanager.cs (MemberLookup); use the new GetInterfaces
26990 (GetInterfaces): The code used to lookup interfaces for a type is
26991 used in more than one place, factor it here.
26993 * driver.cs: Track the errors at the bottom of the file, we kept
26996 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26997 instance if the method we are calling is static!
26999 2002-05-24 Miguel de Icaza <miguel@ximian.com>
27001 * attribute.cs (ApplyAttributes): Make this function filter out
27002 the IndexerName attribute (as that attribute in reality is never
27003 applied) and return the string constant for the IndexerName
27006 * class.cs (TypeContainer.Emit): Validate that all the indexers
27007 have the same IndexerName attribute, and if so, set the
27008 DefaultName attribute on the class.
27010 * typemanager.cs: The return value might contain other stuff (not
27011 only methods). For instance, consider a method with an "Item"
27012 property and an Item method.
27014 * class.cs: If there is a problem with the parameter types,
27017 2002-05-24 Ravi Pratap <ravi@ximian.com>
27019 * ecore.cs (ImplicitConversionExists): Wrapper function which also
27020 looks at user defined conversion after making a call to
27021 StandardConversionExists - we need this for overload resolution.
27023 * expression.cs : Update accordingly the various method calls.
27025 This fixes 2 bugs filed against implicit user defined conversions
27027 2002-05-22 Miguel de Icaza <miguel@ximian.com>
27029 * statement.cs: Track the result of the assignment.
27031 2002-05-21 Miguel de Icaza <miguel@ximian.com>
27033 * expression.cs (MemberAccess): Improved error reporting for
27034 inaccessible members.
27036 2002-05-22 Martin Baulig <martin@gnome.org>
27038 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
27039 itself with debugging support.
27041 2002-05-22 Martin Baulig <martin@gnome.org>
27043 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
27044 Removed, this isn't needed anymore.
27046 2002-05-20 Martin Baulig <martin@gnome.org>
27048 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
27049 be underlying type for an enum.
27051 2002-05-20 Miguel de Icaza <miguel@ximian.com>
27053 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
27054 that splits out the loading of just the core types.
27056 * rootcontext.cs (ResolveCore): Split the struct resolution in
27057 two, so we can load the enumeration underlying types before any
27060 * expression.cs (Is): Bandaid until we fix properly Switch (see
27061 bug #24985 for details).
27063 * typemanager.cs (ImplementsInterface): The hashtable will contain
27064 a null if there are no interfaces implemented.
27066 2002-05-18 Miguel de Icaza <miguel@ximian.com>
27068 * cs-parser.jay (indexer_declarator): It is fine to have array
27071 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27073 * typemanager.cs: (RegisterBuilder): New function used to register
27074 TypeBuilders that implement interfaces. Since
27075 TypeBuilder.GetInterfaces (as usual) does not work with lame
27077 (AddUserType): register interfaces.
27079 (ImplementsInterface): Use the builder_to_ifaces hash if we are
27080 dealing with TypeBuilder. Also, arrays are showing up as
27081 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
27082 methods can not be invoked on them!
27084 * ecore.cs (ExplicitReferenceConversionExists): Made public.
27085 (ImplicitReferenceConversionExists): Split out from
27086 StandardConversionExists.
27088 * expression.cs (As): We were only implementing one of the three
27089 cases for the as operator. We now implement them all.
27090 (Is): Implement the various other cases for Is as well.
27092 * typemanager.cs (CACHE): New define used to control if we want or
27093 not the FindMembers cache. Seems to have a negative impact on
27094 performance currently
27096 (MemberLookup): Nested types have full acess to
27097 enclosing type members
27099 Remove code that coped with instance/static returns for events, we
27100 now catch this in RealFindMembers.
27102 (RealFindMembers): only perform static lookup if the instance
27103 lookup did not return a type or an event.
27105 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27107 * assign.cs (CompoundAssign): We pass more semantic information
27108 now to Compound Assignments than we did before: now we have all
27109 the information at hand, and now we resolve the target *before* we
27110 do the expression expansion, which allows the "CacheValue" method
27111 to have the effect we intended (before, a [x] += 1 would generate
27112 two differen ArrayAccess expressions from the ElementAccess,
27113 during the resolution process).
27115 (CompoundAssign.DoResolve): Resolve target and original_source here.
27117 2002-05-16 Miguel de Icaza <miguel@ximian.com>
27119 * expression.cs (ArrayAccess): dropped debugging information.
27121 * typemanager.cs: Small bug fix: I was always returning i_members,
27122 instead of one of i_members or s_members (depending on which had
27125 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
27126 method is invoked before any code generation takes place, and it
27127 is a mechanism to inform that the expression will be invoked more
27128 than once, and that the method should use temporary values to
27129 avoid having side effects
27131 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
27133 * ecore.cs (Expression.CacheTemporaries): Provide empty default
27136 * expression.cs (Indirection, ArrayAccess): Add support for
27137 CacheTemporaries in these two bad boys.
27139 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
27140 ldobj or ldind_ref.
27141 (StoreFromPtr): Handle stobj as well.
27143 * expression.cs (UnaryMutator): Share more code.
27145 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
27146 down: I was not tracking the Filter function as well, which
27147 was affecting the results of the cache.
27149 2002-05-15 Miguel de Icaza <miguel@ximian.com>
27151 * attribute.cs: Remove the hack to handle the CharSet property on
27154 2002-05-14 Miguel de Icaza <miguel@ximian.com>
27156 * attribute.cs (DoResolve): More uglyness, we now only try to
27157 resolve the attribute partially, to extract the CharSet
27158 information (only if we are a StructLayout attribute). Otherwise
27160 (GetExtraTypeInfo): Add some code to conditionally kill in the
27161 future this. I am more and more convinced that the .NET
27162 framework has special code to handle the attribute setting on
27165 * expression.cs (IsParamsMethodApplicable): Revert my previous
27166 foreach change here, it was wrong.
27168 2002-05-13 Miguel de Icaza <miguel@ximian.com>
27170 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
27171 (pp_expr): do not abort on unknown input, just return.
27172 (eval): abort if there are pending chars.
27174 * attribute.cs (Attribute.Resolve): Positional parameters are
27175 optional. Deal with that case.
27177 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
27178 the Ansi/Unicode/Auto information for the type.
27180 (TypeContainer.DefineType): instantiate the EmitContext here, as
27181 we will be using it during the type definition (to resolve
27182 attributes) and during the emit phase.
27184 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
27185 to pull type information out of the attributes
27187 (Attribute.Resolve): track the constructor builder, and allow for
27188 multiple invocations (structs and classes will use this).
27190 * ecore.cs (MemberLookupFinal): new version with all the
27191 parameters customizable.
27193 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
27194 constructors. Return if the result value is null (as the error
27195 would have been flagged already by MemberLookupFinal)
27197 Do not allow instances of abstract classes or interfaces to be
27200 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
27201 We have to compare the assembly property here when dealing with
27202 FamANDAssem and Assembly access modifiers, because we might be
27203 creating an assembly from *modules* (that means that we are not
27204 getting TypeBuilders for types defined in other modules that are
27205 part of this assembly).
27207 (Method.Emit): If the method is marked abstract and has a body,
27210 (TypeContainer.DefineMembers): If both the defined member and the
27211 parent name match are methods, then do not emit any warnings: let
27212 the Method.Define routine take care of flagging warnings. But if
27213 there is a mismatch (method overrides something else, or method is
27214 overriwritten by something, then emit warning).
27216 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
27217 set to null, this means `do not check for the return type on the
27220 (Method.Define): set the return type for the method signature to
27221 null, so that we get methods with the same name and parameters and
27222 different return types. This is used to flag warning 114 (you are
27223 hiding a method, and you probably want to use the new/override
27226 * typemanager.cs (MemberLookup): Implemented proper access
27227 control, closing a long standing set of bug reports. The problem
27228 was that the Framework only has two bits: Public and NonPublic,
27229 and NonPublic includes private and protected methods, but we need
27230 to enforce the FamANDAssem, FamOrAssem and Family.
27232 2002-05-11 Miguel de Icaza <miguel@ximian.com>
27234 * statement.cs (GotoCase): Return true: Ammounts to giving up
27235 knowledge on whether we return or not, and letting the other case
27236 be responsible for it.
27238 2002-05-10 Miguel de Icaza <miguel@ximian.com>
27240 * driver.cs: Do not load directories for each file processed, only
27241 do it if there is a pattern.
27243 * ecore.cs: Report readonly assigns here as well, as we might have
27244 been resolved only by MemberAccess.
27246 (SimpleName.SimpleNameResolve): Also be useful for LValue
27247 resolution. We need this to propagate assign to local readonly variables
27249 * typemanager.cs: Use a ptrhashtable for the criteria, because we
27250 do not want to reuse potential criteria memory.
27252 * class.cs (MyEventBuilder): Set reflected_type;
27254 * ecore.cs (Constantify): Added support for constifying bools.
27256 (RootContext.LookupType): Added a cache for values looked up in
27257 the declaration space.
27259 * typemanager.cs (FindMembers): Now is a front-end to
27260 RealFindMembers, and provides a two-level hashtable-based cache to
27263 15% performance improvement: from 22.5 to 19.2 seconds.
27265 * expression.cs (IsParamsMethodApplicable): use foreach.
27266 (Invocation.DoResolve): ditto.
27267 (New.DoResolve): ditto.
27268 (ArrayCreation.DoResolve): ditto.
27270 * ecore.cs (FindMostEncompassingType): use foreach.
27272 * delegate.cs (NewDelegate.DoResolve): Use foreach
27274 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27275 (RemoveMethods): use foreach.
27277 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27278 nested foreach statements instead of for, and also break out of
27279 the inner loop once a match is found.
27281 (Invocation.OverloadResolve): Use foreach, simplify the code.
27283 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27285 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27286 we actually unwrap the expression to allow for extra information
27289 * expression.cs: Use Shr_Un on unsigned operations.
27291 2002-05-08 Ravi Pratap <ravi@ximian.com>
27293 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27294 applicable operators was not being considered correctly. This closes
27295 the bug Miguel reported.
27297 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27299 * attribute.cs: check that the type derives from System.Attribute
27300 and report the correct error in that case (moved the duplicate code to
27301 its own method, too).
27303 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27305 * attribute.cs: lookup attribute type name as the spec says: first the
27306 bare attribute name and then name + "Attribute" (nant compiles with
27307 mcs after this fix).
27309 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27311 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27312 Because of the way we parse things, we should try to see if a
27313 UIntConstant can fit in an integer.
27315 2002-05-07 Ravi Pratap <ravi@ximian.com>
27317 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27318 when we are in an explicit context.
27320 (ConvertReferenceExplicit): When converting from Iface type S to Class
27321 T make sure the rules are implemented as an OR.
27323 * parameter.cs (ParameterType): Make it a property for now although the
27324 purpose really isn't anything immediate.
27326 * expression.cs (Is*Applicable): Do better checking on the parameter type
27327 of a ref/out parameter. The ones from the system assemblies are already
27328 marked with the correct type so we don't need to do any correction.
27330 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27331 the object type is standard too so include that.
27333 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27335 * ecore.cs (StandardConversionExists): Augment with missing code:
27336 deal with IntConstant, LongConstants and Enumerations.
27338 * assign.cs: Report the error, instead of failing silently
27340 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27341 typecontainer that they are declared, because the
27342 typecontainer/namespace will have the list of using clauses that
27343 need to be applied.
27345 Assembly Attributes were escaping the normal registration
27348 (EmitCode): Apply attributes within an EmitContext that represents
27349 the container they were declared on.
27351 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27353 2002-05-06 Ravi Pratap <ravi@ximian.com>
27355 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27356 Revamp completely - make much cleaner as we now operate only
27359 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27360 to implement the logic detailed in the spec more correctly.
27362 (UserDefinedConversion): Update accordingly.
27364 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27366 * statement.cs: Return flow analysis information up.
27368 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27371 (token): Do not consume an extra character before calling
27374 2002-05-06 Piers Haken <piersh@friskit.com>
27376 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27378 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27380 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27381 EmitContext during the instance constructor initializer
27382 resolution, to stop access to instance variables.
27384 This is mandated by the spec, last paragraph of the `constructor
27385 initializers' section.
27387 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27389 * cs-parser.jay, class.cs (Accessor): new class used to represent
27390 an accessor (get or set). In the past we used `null' to represent
27391 a missing accessor. But this is ambiguous because there was no
27392 way to tell in abstract indexers/properties if one of them was
27395 Now there is a way of addressing that.
27397 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27398 instead of FindMembers.
27400 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27401 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27403 * attribute.cs: Treat indexers and properties as the same in terms
27404 of applying attributes
27406 * ecore.cs (FindMostEncompassedType): Use statically initialized
27407 EmptyExpressions()s like we do elsewhere to avoid creating useless
27408 objects (and we take this out of the tight loop).
27410 (GetConversionOperators): Move the code to extract the actual
27411 operators to a separate routine to clean things up.
27413 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27415 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27416 events are always registered FieldBuilders.
27418 * class.cs (FieldBase): New class shared by Fields
27420 * delegate.cs: If we are a toplevel delegate, use our full name.
27421 If we are a nested delegate, then only use our tail name.
27423 2002-05-02 Ravi Pratap <ravi@ximian.com>
27425 * expression.cs (IsApplicable): Ensure that we add the "&" to
27426 ref/out types before comparing it with the type of the argument.
27428 (IsParamsMethodApplicable): Ditto.
27430 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27433 * delegate.cs : Handle the case when we have more than one applicable
27434 method. Flag an error only when we finish checking all.
27436 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27438 * expression.cs: Add support for boolean static initializers.
27440 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27442 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27444 * parameter.cs (ComputeParameterTypes,
27445 ComputeAndDefineParameterTypes): Better error handling: now we
27446 clear the `types' cache if we fail during any of the type lookups.
27447 We also return the status code correctly to our caller
27449 * delegate.cs: If we fail to define a delegate, abort the extra
27452 * expression.cs (Binary.ResolveOperator): for
27453 operator==(object,object) and operator !=(object, object) we also
27454 have to verify that there is an implicit conversion from one to
27457 (ArrayAccess.DoResolve): Array Access can operate on
27460 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27462 * assign.cs (CompoundAssign): A new class used as a "flag" that
27463 the assignment actually is happening as part of a compound
27464 assignment operator.
27466 During compound assignment, a few new rules exist to enable things
27473 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27474 to the type of x) if y is implicitly convertible to the type of x,
27475 and the operator is a builtin operator and the return type of the
27476 operator is explicitly convertible to the type of x.
27478 * rootcontext.cs: Reset warning level to 2. 4 catches various
27479 "interesting" features in mcs, we must clean this up at some
27480 point, but currently am trying to kill other bugs ;-)
27482 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27483 in container classes as well.
27485 * expression.cs (Binary.ResolveOperator): Handle string case
27486 before anything else (as operator overloading does emit an error
27487 before doing anything else).
27489 This code could go away when we move to a table driven model, but
27490 i could not come up with a good plan last night.
27492 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27494 * typemanager.cs (CSharpName): reimplementation using regex.
27495 * class.cs: added null check for fields in Emit
27496 * rootcontext.cs: set warninglevel to 4
27498 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27500 * typemanager.cs (CSharpName): reimplemented with Lupus
27503 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27505 * statement.cs (If): correclty implement Resolve, because we were
27506 not catching sem errors in there. The same process is needed
27508 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27511 (Statement.Warning_DeadCodeFound): Factorize code.
27512 (While): Report dead code here too.
27514 (Statement): Added Resolve virtual method to allow
27515 for resolution split from the emit code.
27517 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27519 * statement.cs (EmitBoolExpression): No longer try to resolve the
27521 (MakeBoolean): New utility function that resolve, implicitly
27522 converts to boolean and tags the expression.
27525 (If, Do): Implement dead code elimination.
27526 (While): Implement loop inversion
27528 (Do, While, For, If): Resolve the expression prior to calling our
27531 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27534 - added method Report28 (warning: program has more than one entry point)
27535 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27536 - modified method Method.Define, the part at the end of the method
27538 * rootcontext.cs: added static public Location EntryPointLocation;
27540 * ../errors/cs0028.cs : Add test case for the above warning.
27543 - modified method CSharpName to allow arrays of primitive type to
27544 be printed nicely (e.g. instead of System.Int32[][] it now prints
27546 - added method CSharpSignature: returns the signature of a method
27547 in string format to be used in reporting errors, warnings, etc.
27549 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27552 2002-04-26 Ravi Pratap <ravi@ximian.com>
27554 * delegate.cs (Define): Fix extremely silly bug where I was
27555 setting the type of the 'object' parameter of the BeginInvoke
27556 method to System.IAsyncResult instead of System.Object ;-)
27558 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27560 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27563 (Constructor.Emit): return if we fail to initialize the
27564 constructor. Another door closed!
27566 * expression.cs (New.DoResolve): Improve error message (from -6 to
27567 1501). Use DeclaredOnly lookup to find the exact constructor.
27569 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27570 loop. This is useful.
27572 * cs-parser.jay: Adjust the default parameters so that destructors
27573 have the proper signature.
27575 2002-04-26 Martin Baulig <martin@gnome.org>
27577 * driver.cs (LoadAssembly): If `assembly' contains any characters
27578 which are only valid in path names and not in assembly names
27579 (currently slash, backslash and point), use Assembly.LoadFrom ()
27580 instead of Assembly.Load () on the `assembly' (before iteration
27581 over the link_paths).
27583 2002-04-26 Martin Baulig <martin@gnome.org>
27585 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27587 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27589 * class.cs (Property): use the new typemanager.MemberLookup
27591 (TypeContainer.MemberLookup): Implement using the
27592 TypeManager.MemberLookup now.
27594 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27595 and return MemberInfos, so that these can be used without an
27596 EmitContext (what we had before).
27598 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27600 * expression.cs: Fix the case where the argument to params if the
27601 type of the params. I omitted handling this before. Fixed
27603 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27605 * driver.cs: Call BootCorlib_PopulateCoreType
27607 * class.cs (Property.CheckBase): Check for properties only, not
27610 * interface.cs: Temporary hack: try/catch around the
27611 CustomAttributeBuilder, because I am getting an exception that I
27614 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27615 types whose definitions are required to be there (attributes are
27616 defined before standard types).
27618 Compute definitions as we boot the various types, as they are used
27619 immediately (value_type class will need object_type, but if we do
27620 not initialize object_type, we will pass a null, which will let
27621 the runtime pick the System.Object from the existing corlib, which
27622 is not what we want).
27624 2002-04-22 Patrik Torstensson <totte@labs2.com>
27626 * cs-tokenizer.cs: fixed a number of trim() issues.
27628 2002-04-22 Ravi Pratap <ravi@ximian.com>
27630 * expression.cs (Argument.Type): Ensure that we return the correct
27631 type when we have out or ref parameters [in which case we
27634 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27636 * class.cs (Property, Indexer): Allow extern modifier in there.
27638 * typemanager.cs (InitBaseTypes): Initializes object_type and
27639 value_type, since those will be used early on during the bootstrap
27640 process to compile corlib.
27642 (InitCoreTypes): Move code from here to InitBaseTypes.
27644 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27646 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27647 single-dimension arrays as using the ldlen opcode.
27649 Daniel Lewis discovered this optimization.
27651 * typemanager.cs: Add signature for System.Array::get_Length
27653 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27655 * statement.cs: report the error when the foreach does not apply to an
27656 array nor a collection.
27658 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27660 * expression.cs: Add implicit conversions to the operator ~.
27662 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27664 * typemanager.cs: Locate the decimal constructor.
27666 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27668 * attribute.cs: use the new property of TypeOf.
27669 * expression.cs: added 'get' property around typearg.
27671 These changes fix a build breaker reported by NickD. Is this the
27672 correct way to fix? If not, please, revert my changes and make it
27675 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27677 * attribute.cs: Add support for typeof in attribute invocations.
27678 I am not sure that this is right though.
27680 2002-04-14 Duncan Mak <duncan@ximian.com>
27682 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27683 Binary.Operator.Division case.
27685 2002-04-13 Ravi Pratap <ravi@ximian.com>
27687 * class.cs (DefineType): Ensure that we do a proper check on
27688 attribute types and also register it with the TypeManager.
27690 (TypeContainer.Targets): The default for attribute types is
27691 AttributeTargets.All.
27693 * attribute.cs (ApplyAttributes): Registering the attribute type
27694 is done elsewhere, not when we discover we have a Usage attribute.
27696 2002-04-12 Ravi Pratap <ravi@ximian.com>
27698 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27699 and get rid of is_delegate parameter.
27701 * everywhere : update.
27703 2002-04-12 Ravi Pratap <ravi@ximian.com>
27705 * cs-parser.jay (compilation_unit): Revamp completely to use
27706 some new ideas that I got from Rhys' grammar to solve the problems
27707 with assembly level attributes.
27709 (outer_declaration): New grammar production.
27711 (attribute_sections): Add.
27713 (opt_attributes): Base on attribute_sections
27715 (namespace_declaration): Allow opt_attributes to tackle the case
27716 when we have assembly level attributes - we are clever in this
27719 * attribute.cs (ApplyAttributes): Do not worry about assembly
27720 attributes in the non-global context.
27722 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27723 instead of SetGlobalAttributes.
27725 * class.cs, rootcontext.cs : Ensure we define and generate
27726 attribute types before anything else.
27728 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27729 and flag the new error -20 for the case when the attribute type
27730 does not have valid targets specified. csc does not catch this.
27732 * ../errors/errors.txt : update for error # -20
27734 2002-04-11 Ravi Pratap <ravi@ximian.com>
27736 * support.cs (InternalParameters.ParameterModifier): Do some null
27737 checking and return sane values.
27739 * class.cs (Method.Define): If we are a PInvoke method, ensure
27740 that we are static and extern. Report error # 601
27742 * ../errors/cs0601.cs : Add test case for the above error.
27744 2002-04-07 Ravi Pratap <ravi@ximian.com>
27746 * rootcontext.cs (attribute_types): We need to keep type of
27747 all attribute types separately and emit code for them first.
27749 (RegisterAttribute) : Implement.
27751 * class.cs (DefineType): Check if the current Type is a custom
27752 attribute type and register it accordingly.
27754 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27755 adding the first attribute twice and rename to
27757 (SetGlobalAttributes): this.
27759 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27762 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27763 if we are processing global arguments. Hmm, I am unsure of this.
27765 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27767 * expression.cs: added static array of strings to avoid calling
27768 Enum.ToString () for Operator in Binary. Significant recover of
27771 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27773 * class.cs (FindMembers): Allow the Builders of the various
27774 members to be null. If they are skip them. This only happens
27775 during the PInvoke declaration.
27777 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27779 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27780 failure, so we do not keep going afterwards.
27782 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27783 wanted to pass `false' as the `is_delegate' argument. If this is
27784 the case, why not use delegate_type == null to mean `is_delegate =
27785 false' and anything else as is_delegate = true.
27787 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27789 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27790 code for the section, not the beginning of the tests.
27792 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27794 * cfold.cs: Handle operator + (Enum x, Underlying x)
27796 * expression.cs (Binary): same. Warn about errors where we have
27797 Enum/Enum in operator + as well.
27799 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27802 - added support for switch(bool)
27803 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27804 - add TableSwitchEmit() to handle table-based switch statements
27806 2002-04-05 Ravi Pratap <ravi@ximian.com>
27808 * expression.cs (Invocation.OverloadResolve): Factor out code which
27809 does parameter compatibility checking with arguments so that we can
27810 re-use the code even from Delegate.VerifyApplicability
27812 (VerifyArgumentsCompat): Move above code here.
27814 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27815 and instead make a call to the above method.
27817 2002-03-31 Ravi Pratap <ravi@ximian.com>
27819 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27820 We use it to keep track of classes which are attribute types.
27822 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27824 * delegate.cs (Delegate.Define): Correctly define the types in the
27825 presence of fixed and array parameters.
27827 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27830 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27831 include NonPublic after the first iteration.
27833 * class.cs (Indexer.CheckBase): Only check if both parents are
27836 * cs-parser.jay (accessor_body): If empty, set to null.
27838 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27839 same code path here to resolve constants names that we did have in
27840 MemberAccess.DoResolve. There is too much code duplicated here.
27842 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27844 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27846 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27849 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27850 tokens, numbers and strings.
27852 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27855 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27856 asyncronous parameters and the regular parameters.
27858 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27859 specify the target directory.
27861 * expression.cs: (This.DoResolve): Simplify
27862 (As.Emit): Optimize, do not generate IsInst if the expression is
27863 always of the given type.
27865 (Is.DoResolve): Bug fix, we were reporting both always/never for
27868 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27869 creating too many unnecessary arrays.
27871 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27873 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27874 fields instead of rolling our own initializer. Takes care of all
27875 implicit conversions, and drops unnecessary static checks/argument.
27877 2002-03-31 Dick Porter <dick@ximian.com>
27879 * driver.cs: use the GetDirectories() return values properly, and
27880 use "/" as path separator.
27882 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27884 * expression.cs (Unary): Optimize - - expr into expr.
27885 (Binary): Optimize a + (-b) into a -b.
27887 * codegen.cs (CodeGen): Made all methods static.
27889 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27893 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27894 TypeBuilder property.
27896 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27899 * tree.cs: Removed the various RecordXXXX, and replaced with a
27900 single RecordDecl. Removed all the accessor methods, and just
27901 left a single access point Type
27903 * enum.cs: Rename DefineEnum to DefineType.
27905 * decl.cs: New abstract method `DefineType' used to unify the
27906 Defines for Enumerations, Interfaces, TypeContainers and
27909 (FindType): Moved LookupInterfaceOrClass here. Moved the
27910 LookupBaseClasses method that used to live in class.cs and
27911 interface.cs here, and renamed to FindType.
27913 * delegate.cs: Implement DefineType. Take advantage of the
27914 refactored pattern for locating the parent builder without taking
27915 the parent_builder argument (which we know does not work if we are
27916 nested, and triggering a toplevel definition).
27918 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27920 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27921 accessibility of a member has changed during override and report
27924 * class.cs (Method.Define, Property.Define): Only complain on
27925 overrides if the method is private, any other accessibility is
27926 fine (and since we just checked the permission is the same, we are
27929 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27930 and elif are processed always. The other pre-processing
27931 directives are only processed if we are "taking" the path
27933 2002-03-29 Martin Baulig <martin@gnome.org>
27935 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27936 current location is not Null.
27938 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27939 a separate method so we can profile it.
27941 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27942 `span.Seconds' are just seconds, but no minutes or hours.
27943 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27945 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27947 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27948 Remove the gratuitous set of Final:
27950 // If an interface implementation, then we can set Final.
27951 if (((flags & MethodAttributes.Abstract) == 0) &&
27952 implementing.DeclaringType.IsInterface)
27953 flags |= MethodAttributes.Final;
27955 I do not know what I was smoking when I used that.
27958 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27959 step into fixing the name resolution issues for delegates and
27960 unifying the toplevel name resolution.
27962 2002-03-28 Martin Baulig <martin@gnome.org>
27964 * class.cs (Method.Emit): If we have a symbol writer, call its
27965 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27966 tell it about the current method.
27968 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27969 writer that we're going to emit the first byte of IL code for a new
27970 statement (a new source line).
27971 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27972 EmitContext.Mark() before emitting any code.
27974 * location.cs (SymbolDocument): Return null when we're Null.
27976 * statement.cs (Statement): Moved the `Location loc' variable here.
27977 (Statement.EmitBoolExpression): If we have a symbol writer, call
27978 ec.Mark() before emitting any code to tell it that we're at the
27979 beginning of a new statement.
27980 (StatementExpression): Added `Location' argument to the constructor.
27981 (Block): Added public readonly variable `StartLocation' and public
27982 variable `EndLocation'. The latter is to be set using SetEndLocation().
27983 (Block): Added constructor which takes a start and end location.
27984 (Block.SetEndLocation): New method. This sets the end location.
27985 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27986 local variables we create.
27987 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27988 each statement and do also mark the begin and end of the block.
27990 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27991 tell it the current lexer.Location, use Location.Null for the end of the
27993 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27994 current block, set its end location using SetEndLocation().
27995 (statement_expression): StatementExpression constructor now takes the
27996 lexer.Location as additional argument.
27997 (for_statement, declare_local_variables): Likewise.
27998 (declare_local_variables): When creating a new implicit block, use the
27999 new Block constructor and pass it the lexer.Location.
28001 2002-03-28 Miguel de Icaza <miguel@ximian.com>
28003 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
28004 members also on the parent interfaces recursively.
28006 2002-03-27 Miguel de Icaza <miguel@ximian.com>
28008 * report.cs: Use new formats, since Gonzalo finished the missing
28011 * expression.cs (Binary.ResolveOperator): added missing operator|
28012 operator& and operator^ for bool/bool.
28014 * cs-parser.jay: CheckDef now takes a Location argument that is
28015 used to report errors more precisly (instead of reporting the end
28016 of a definition, we try to track something which is a lot closer
28017 to the source of the problem).
28019 * cs-tokenizer.cs: Track global token use, so we can properly flag
28020 the use of #define/#undef after the first token has been seen.
28022 Also, rename the reportXXXX to Error_DescriptiveName
28024 * decl.cs (DeclSpace.IsTopLevel): Move property here from
28025 TypeContainer, so that Enum and Interface can use this too.
28027 * class.cs (TypeContainer.LookupInterfaceOrClass,
28028 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
28029 `builder' argument. Typically this was used to pass the parent
28030 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
28033 The problem is that a nested class could trigger the definition of
28034 a toplevel class, and the builder would be obviously wrong in that
28037 So we drop this argument, and we compute dynamically the
28038 TypeBuilder/ModuleBuilder (the correct information was available
28039 to us anyways from DeclSpace.Parent)
28041 * interface.cs (Interface.DefineInterface): Drop builder
28042 parameter cleanup like class.cs
28044 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
28047 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
28050 (Try.Emit): Propagate the returns value from the statement.
28052 (Return.Emit): Even if we are leavning
28054 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
28056 * modifiers.cs: Fix the computation of MethodAttributes flags.
28058 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
28060 * driver.cs: allow compilation of files that start with '/'.
28061 Add a default case when checking the argument of --target.
28063 2002-03-25 Miguel de Icaza <miguel@ximian.com>
28065 * interface.cs: Implement the same search algorithm for types in
28066 the interface code.
28068 * delegate.cs: Do not allow multiple definition.
28070 * Recovered ChangeLog that got accidentally amputated
28072 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
28074 * rootcontext.cs: Load manually enum to allow core classes to
28075 contain enumerations.
28077 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
28078 Update to new static methods in TypeManager.
28080 * typemanager.cs (GetMethod, GetConstructor): Use our
28081 implementation of FindMembers to find the members, since during
28082 corlib compilation, the types are TypeBuilders and GetMethod and
28083 GetConstructor do not work.
28085 Make all methods in TypeManager static.
28087 (InitCodeHelpers): Split the functionality from
28088 the InitCodeTypes function.
28090 * driver.cs: Call InitCodeHelpers after we have populated the
28093 * cs-parser.jay (delegate_declaration): we did not used to compute
28094 the delegate name correctly for void delegates.
28096 2002-03-24 Miguel de Icaza <miguel@ximian.com>
28098 * rootcontext.cs (RootContext): Init the interface_resolve_order
28099 and type_container_resolve_order always.
28101 (ResolveCore, BootstrapCorlib_ResolveClass,
28102 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
28103 compiler when compiling with --nostdlib
28105 * class.cs (TypeContainer.DefineType): Check that our parent is
28106 not null. This test is most important when we are bootstraping
28109 * codegen.cs: Split out the symbol writing code.
28111 2002-03-25 Martin Baulig <martin@gnome.org>
28113 * driver.cs (-g): Made -g an alias for --debug.
28115 2002-03-24 Martin Baulig <martin@gnome.org>
28117 * codegen.cs (SymbolWriter): New public variable. Returns the
28118 current symbol writer.
28119 (CodeGen): Added `bool want_debugging_support' argument to the
28120 constructor. If true, tell the ModuleBuild that we want debugging
28121 support and ask it for the ISymbolWriter.
28122 (Save): If we have a symbol writer, call it's Close() method after
28123 saving the assembly.
28125 * driver.c (--debug): New command line argument to create a
28126 debugger information file.
28128 * location.cs (SymbolDocument): New public property. Returns an
28129 ISymbolDocumentWriter object for the current source file or null
28130 if we don't have a symbol writer.
28132 2002-03-21 Miguel de Icaza <miguel@ximian.com>
28134 * driver.cs (LoadAssembly): Correctly return when all the paths
28135 have been tried and not before.
28137 * statement.cs (Switch.Emit): return the actual coverage for this
28138 statement (returns/not-returns)
28140 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
28141 switch of the statement if we are the last switch section. That
28142 kills two problems: try/catch problems (we used to emit an empty
28143 nop at the end) and switch statements where all branches would
28146 2002-03-19 Miguel de Icaza <miguel@ximian.com>
28148 * driver.cs: Add default assemblies (the equivalent to the
28149 Microsoft CSC.RSP file)
28151 * cs-tokenizer.cs: When updating `cols and setting it to zero,
28152 also update tokens_seen and set it to false.
28154 * driver.cs: Implement --recurse for Mike.
28156 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
28157 correctly splitting out the paths.
28159 2002-03-18 Miguel de Icaza <miguel@ximian.com>
28161 * interface.cs (Interface.PopulateProperty): Instead of using
28162 `parent' as the declaration space for the set parameters, use
28165 * support.cs (InternalParameters): InternalParameters constructor
28166 takes a DeclSpace instead of a TypeContainer.
28168 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
28169 types are being initialized, load the address of it before calling
28172 (New): Provide a mechanism to disable the generation of local
28173 value type temporaries when the caller will be providing us with
28174 an address to store it.
28176 (ArrayCreation.EmitDynamicInitializers): Use it.
28178 2002-03-17 Miguel de Icaza <miguel@ximian.com>
28180 * expression.cs (Invocation.EmitArguments): Only probe for array
28181 property if there is more than one argument. Sorry about that.
28183 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
28184 empty param arrays.
28186 * class.cs (Method.LabelParameters): Fix incorrect code path that
28187 prevented the `ParamArrayAttribute' from being applied to the
28190 2002-03-16 Miguel de Icaza <miguel@ximian.com>
28192 * support.cs (ReflectionParameters): Correctly compute whether the
28193 last argument is a params array. Fixes the problem with
28196 * typemanager.cs: Make the assemblies array always be non-null
28197 (empty, but non-null)
28199 * tree.cs (RecordDecl): New function that abstracts the recording
28200 of names. This reports error 101, and provides a pointer to the
28201 previous declaration. Fixes a crash in the compiler.
28203 * cs-parser.jay (constructor_declaration): Update to new grammar,
28204 and provide a constructor_body that can be empty.
28206 2002-03-15 Miguel de Icaza <miguel@ximian.com>
28208 * driver.cs: Add support for --resources.
28210 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
28211 Make all types for the various array helper methods be integer.
28213 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
28214 CheckState to ConvCast.
28216 (ConvCast): Now it takes a `checked' state argument, to avoid
28217 depending on the emit context for the conversion, and just using
28218 the resolve time setting.
28220 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
28221 instead of Invocation.EmitArguments. We do not emit the original
28222 arguments, instead we emit those which have been converted to
28223 unsigned int expressions.
28225 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
28227 * codegen.cs: ditto.
28229 * expression.cs (LocalVariableReference): Drop the use of the
28230 Store function that depended on the variable index.
28232 * statement.cs (VariableInfo): Drop the `Idx' property from this
28233 class, as this is not taking into account the indexes for
28234 temporaries tat we generate during the execution, getting the
28237 * class.cs: First emit class initializers, then call the parent
28240 * expression.cs (Binary): Fix opcode emision.
28241 (UnaryMutator.EmitCode): Support checked code generation
28243 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
28244 matches for events for both the Static and Instance scans,
28245 pointing to the same element. Fix that.
28247 2002-03-14 Miguel de Icaza <miguel@ximian.com>
28249 * rootcontext.cs (ResolveTree): Always set the
28250 interface_resolve_order, because nested interfaces will be calling
28253 * class.cs (GetInterfaceOrClass): Track the same resolution
28254 process used by TypeManager.LookupType. This fixes the nested
28255 type lookups in class declarations (separate path from
28258 (TypeContainer.DefineType): Also define nested interfaces.
28259 (TypeContainer.RegisterOrder): New public function used to
28260 register the order in which child interfaces need to be closed.
28262 Nested interfaces need to be closed after their parents have been
28265 * interface.cs (InterfaceAttr): Put all the logic for computing
28266 the interface attribute here.
28268 (DefineInterface): Register our interface order with the
28269 RootContext or with the TypeContainer depending on the case.
28271 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28273 * cs-parser.jay: rework foreach statement to work with the new
28274 changes to the policy on SimpleNames.
28276 * report.cs: support Stacktrace on warnings as well.
28278 * makefile: drop --unsafe and /unsafe from the compile.
28280 2002-03-13 Ravi Pratap <ravi@ximian.com>
28282 * ecore.cs (StandardConversionExists): Modify to take an Expression
28283 as the first parameter. Ensure we do null -> reference type conversion
28286 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28287 temporary Expression objects.
28289 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28291 * interface.cs: workaround bug in method overloading resolution
28292 (there is already a bugzilla bug for it).
28294 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28296 We could also solve this problem by having a separate path for
28297 performing type lookups, instead of DoResolve, we could have a
28298 ResolveType entry point, and only participating pieces of the
28299 production (simplename, deref, array) would implement this.
28301 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28302 signal SimpleName to only resolve type names and not attempt to
28303 resolve anything else.
28305 * expression.cs (Cast): Set the flag.
28307 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28309 * class.cs: Only report 108 if there is no `new' modifier.
28311 * cs-parser.jay: rework foreach statement to work with the new
28312 changes to the policy on SimpleNames.
28314 * report.cs: support Stacktrace on warnings as well.
28316 * makefile: drop --unsafe and /unsafe from the compile.
28318 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28320 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28321 lookups here, instead of doing that at parse time. This means
28322 that our grammar will not introduce `LocalVariableReferences' as
28323 expressions at this point. That solves the problem of code like
28327 static void Main ()
28331 This is only half the fix. The full fix requires parameters to
28332 also be handled in this way.
28334 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28335 makes the use more obvious of the DeclSpace. The
28336 ec.TypeContainer.TypeBuilder is now only used to pull the
28337 TypeBuilder for it.
28339 My theory is that I can get rid of the TypeBuilder completely from
28340 the EmitContext, and have typecasts where it is used (from
28341 DeclSpace to where it matters).
28343 The only pending problem is that the code that implements Aliases
28344 is on TypeContainer, and probably should go in DeclSpace.
28346 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28347 lookups here, instead of doing that at parse time. This means
28348 that our grammar will not introduce `LocalVariableReferences' as
28349 expressions at this point. That solves the problem of code like
28353 static void Main ()
28357 This is only half the fix. The full fix requires parameters to
28358 also be handled in this way.
28360 * class.cs (Property.DefineMethod): When implementing an interface
28361 method, set newslot, when implementing an abstract method, do not
28362 set the flag (before we tried never setting it, or always setting
28363 it, which is the difference).
28364 (Indexer.DefineMethod): same.
28365 (Method.DefineMethod): same.
28367 * ecore.cs: Only set the status used flag if we get back a Field.
28369 * attribute.cs: Temporary hack, so Paolo can keep working.
28371 2002-03-08 Ravi Pratap <ravi@ximian.com>
28373 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28374 the unmanaged type in the case we have a MarshalAs attribute.
28376 (Resolve): Handle the case when we are parsing the special MarshalAs
28377 attribute [we need to store the unmanaged type to use later]
28379 * typemanager.cs (marshal_as_attr_type): Built in type for the
28380 MarshalAs Attribute.
28382 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28383 on parameters and accordingly set the marshalling info.
28385 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28387 * class.cs: Optimizing slightly by removing redundant code after
28388 we switched to the `NoTypes' return value.
28389 (Property.DefineMethod): use NoTypes here too.
28391 This fixes the bug I introduced in my last batch of changes.
28393 2002-03-05 Ravi Pratap <ravi@ximian.com>
28395 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28397 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28398 Enums since those are types too.
28400 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28402 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28403 thanks to a call during the lookup process.
28405 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28407 * statement.cs (Foreach): Lots of work to accomodate a particular
28408 kind of foreach statement that I had not kept in mind. It is
28409 possible to have foreachs on classes that provide a GetEnumerator
28410 method that return objects that implement the "pattern" for using
28411 a foreach, there is no need to support GetEnumerator
28414 This is needed to compile nant.
28416 * decl.cs: Only report 114 if the member is not `Finalize' and if
28417 the warning level is at least 2.
28419 * class.cs: Moved the compare function from Method to
28422 (MethodSignature.InheritableMemberSignatureCompare): Add new
28423 filter function that is used to extract inheritable methods from a
28426 (Method.Define): Use the new `inheritable_method_signature_filter'
28429 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28432 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28434 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28436 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28438 * expression.cs: Pass location information to
28439 ConvertImplicitStandard.
28441 * class.cs: Added debugging code to track return values from
28444 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28446 * expression.cs (Is.DoResolve): If either side of the `is' is an
28447 interface, do not flag the warning.
28449 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28452 * report.cs: Allow for --fatal to be used with --probe.
28454 * typemanager.cs (NoTypes): Move the definition for the empty Type
28457 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28459 (TypeContainer.DefineProxy): New function used to proxy to parent
28460 implementations when implementing interfaces.
28461 (TypeContainer.ParentImplements): used to lookup if our parent
28462 implements a public function that is required by an interface.
28463 (TypeContainer.VerifyPendingMethods): Hook this up.
28465 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28466 `modules' and `assemblies' arraylists into arrays. We only grow
28467 these are the very early start up of the program, so this improves
28468 the speedof LookupType (nicely measured).
28470 * expression.cs (MakeByteBlob): Replaced unsafe code with
28471 BitConverter, as suggested by Paolo.
28473 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28474 folding of string concatenation, but if either side is a string,
28475 and the other is not, then return null, and let the runtime use
28476 the concatenation on the string plus the object (using
28477 `Object.ToString').
28479 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28481 Constant Folding has been implemented now.
28483 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28484 the error instead on types that are not supported in one's
28487 * constant.cs (Constant and all children): New set of functions to
28488 perform implict and explicit conversions.
28490 * ecore.cs (EnumConstant): Implement the new functions to perform
28491 conversion by proxying to the child expression.
28493 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28494 own separate setting that can not be turned off from the command
28495 line using --unchecked or --checked and is only controlled using
28496 the checked/unchecked statements and expressions. This setting is
28497 used by the constant folder to flag errors.
28499 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28500 ConstantCheckState as well.
28502 During Resolve, they also have to flag the state, because the
28503 constant folder runs completely in the Resolve phase.
28505 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28508 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28510 * cfold.cs: New file, this file contains the constant folder.
28512 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28513 argument to track whether we are using the resulting address to
28514 load or store a value and provide better error messages.
28516 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28517 new AddressOf arguments.
28519 * statement.cs (Foreach.EmitCollectionForeach): Update
28521 * expression.cs (Argument.Emit): Call AddressOf with proper
28522 arguments to track usage.
28524 (New.DoEmit): Call AddressOf with new arguments.
28526 (Unary.Emit): Adjust AddressOf call.
28528 2002-03-01 Ravi Pratap <ravi@ximian.com>
28530 * cs-parser.jay (member_access): Change the case for pre-defined types
28531 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28534 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28537 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28538 essentially like methods and apply attributes like MethodImplOptions to them too.
28540 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28543 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28544 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28547 * Update code everywhere accordingly.
28549 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28551 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28553 2002-02-28 Ravi Pratap <ravi@ximian.com>
28555 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28556 try performing lookups against those instead of jumping straight into using
28557 the 'using' clauses.
28559 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28561 (LookupType): Perform lookups in implicit parents too.
28563 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28564 sequence as RootContext.LookupType.
28566 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28567 the various cases of namespace lookups into this method.
28569 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28571 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28572 in positional arguments)
28574 * class.cs (Operator): Update the AllowedModifiers to contain
28577 * cs-parser.jay: Update operator declaration to allow for the
28578 operator body to be empty.
28580 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28583 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28585 * class.cs (Method.Emit): Label parameters.
28587 * driver.cs: Return 1 or 0 as the program exit code.
28589 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28591 * expression.cs: Special case the `null' object when trying to
28592 auto-compute the type, as anything can be explicitly converted to
28595 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28596 spotting this Paolo.
28598 (Expression.ImplicitNumericConversion): Perform comparissions of
28599 the type using the underlying type in the case of an enumeration
28600 rather than using the enumeration type for the compare.
28602 Cope with the underlying == type case, which is not possible to
28605 (Expression.ConvertNumericExplicit): Perform comparissions of
28606 the type using the underlying type in the case of an enumeration
28607 rather than using the enumeration type for the compare.
28609 * driver.cs: If the user does not supply an extension, assume .exe
28611 * cs-parser.jay (if_statement): Rewrote so that we can track the
28612 location for the if statement.
28614 * expression.cs (Binary.ConstantFold): Only concat strings when
28615 the operation is "+", not everything ;-)
28617 * statement.cs (Statement.EmitBoolExpression): Take a location
28619 (If, While, Do): Track location.
28621 * expression.cs (Binary.ResolveOperator): In the object + string
28622 case, I was missing a call to ConvertImplicit
28624 2002-02-25 Ravi Pratap <ravi@ximian.com>
28626 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28627 Location arguments. Ensure we use RootContext.LookupType to do our work
28628 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28630 * interface.cs (PopulateMethod): Handle the type of the parameter being
28633 * expression.cs (Invocation.BetterFunction): Handle the case when we
28634 have a params method with no fixed arguments and a call is made with no
28637 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28639 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28640 the verbatim-string-literal
28642 * support.cs (InternalParameters.ParameterModifier): handle null
28644 (InternalParameters.ParameterType): ditto.
28646 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28647 duplicating the name of the variable parameter.
28648 (GetParameterByName): Fix bug where we were not looking up array
28649 paramters if they were the only present (thanks Paolo!).
28650 (GetParameterInfo): We only have an empty set of types if both
28651 fixed and array are set to null.
28652 (GetParameterInfo-idx): Handle FixedParameter == null
28654 * cs-parser.jay: Handle the case where there is no catch
28655 statements (missing null test).
28657 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28659 * driver.cs (MainDriver): Be conservative on our command line
28662 Catch DirectoryNotFoundException when calling GetFiles.
28664 (SplitPathAndPattern): Used to split the input specification into
28665 a path and a pattern that we can feed to Directory.GetFiles.
28667 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28669 * statement.cs (Fixed): Implement the last case of the Fixed
28670 statement (string handling).
28672 * expression.cs (StringPtr): New class used to return a char * to
28673 a string; Used by the Fixed statement.
28675 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28677 * expression.cs (Binary.ResolveOperator): Remove redundant
28678 MemberLookup pn parent type.
28679 Optimize union call, we do not need a union if the types are the same.
28680 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28683 Specialize the use of MemberLookup everywhere, instead of using
28684 the default settings.
28686 (StackAlloc): Implement stackalloc keyword.
28688 * cs-parser.jay: Add rule to parse stackalloc.
28690 * driver.cs: Handle /h, /help, /?
28692 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28693 before we supported unsafe code.
28695 * makefile: add --unsafe to the self compilation of mcs.
28697 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28699 * expression.cs (PointerArithmetic): New class that is used to
28700 perform pointer arithmetic.
28701 (Binary.Resolve): Handle pointer arithmetic
28702 Handle pointer comparission.
28703 (ArrayPtr): Utility expression class that is used to take the
28704 address of an array.
28706 (ElementAccess): Implement array access for pointers
28708 * statement.cs (Fixed): Implement fixed statement for arrays, we
28709 are missing one more case before we are done.
28711 * expression.cs (Indirection): Implement EmitAssign and set the
28712 ExprClass to Variable. This allows pointer dereferences to be
28713 treated as variables, and to have values assigned to them.
28715 * ecore.cs (Expression.StoreFromPtr): New utility function to
28716 store values dereferencing.
28718 2002-02-20 Ravi Pratap <ravi@ximian.com>
28720 * expression.cs (Binary.ResolveOperator): Ensure that we are
28721 not trying to operate on a void type - this fixes the reported
28724 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28725 the parent implementation is sealed.
28727 * ../errors/cs0239.cs : Add.
28729 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28731 * typemanager.cs (unverifiable_code_type): Corresponds to
28732 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28733 which have unsafe code in them.
28735 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28738 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28740 * cs-tokenizer.cs: Add support for @"litreal strings"
28742 Make tokenizer accept pre-processor directives
28743 on any column (remove the old C-like limitation).
28745 * rootcontext.cs (EmitCode): Emit any global attributes.
28746 (AddGlobalAttributes): Used to keep track of assembly attributes.
28748 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28750 * cs-parser.jay: Add support for global attributes.
28752 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28754 * expression.cs (Indirection): New helper class. Unary will
28755 create Indirection classes to be able to implement the
28756 IMemoryLocation interface on it.
28758 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28760 * cs-parser.jay (fixed_statement): reference the right statement.
28762 * statement.cs (Fixed.Emit): Finish implementing the fixed
28763 statement for the &x case.
28765 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28767 * class.cs (Property.Define, Method.Define): Remove newslot when
28770 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28771 wrong. NewSlot should only be used if the `new' keyword is present.
28773 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28774 locating our system dir. Sorry about this.
28776 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28778 * driver.cs (GetSystemDir): Compute correctly the location of our
28779 system assemblies. I was using the compiler directory instead of
28780 the library directory.
28782 2002-02-13 Ravi Pratap <ravi@ximian.com>
28784 * expression.cs (BetterFunction): Put back in what Miguel commented out
28785 since it is the correct fix. The problem is elsewhere ;-)
28787 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28788 parameters of the parms method are themselves compatible or not !
28790 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28791 to check that a class implements an interface before saying that an implicit
28792 conversion was allowed. Use ImplementsInterface to do the checking.
28794 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28796 * class.cs (Method.Define): Track whether we are an explicit
28797 implementation or not. And only call DefineMethodOverride if we
28798 are an explicit implementation.
28800 (Property.DefineMethod): Ditto.
28802 2002-02-11 Ravi Pratap <ravi@ximian.com>
28804 * expression.cs (BetterFunction): Catch hideous bug which was
28805 preventing us from detecting ambiguous calls due to implicit casts i.e
28808 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28810 * support.cs (Pair): Remove un-needed method. I figured why I was
28811 getting the error in cs-parser.jay, the variable in a foreach loop
28812 is readonly, and the compiler does not really treat this as a variable.
28814 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28815 instead of EQUALS in grammar.
28817 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28819 * expression.cs (Unary.DoResolve): Check whether the argument is
28822 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28824 * support.cs: Api for Pair to set a value. Despite the fact that
28825 the variables are public the MS C# compiler refuses to compile
28826 code that accesses the field if the variable is part of a foreach
28829 * statement.cs (Fixed): Begin implementation of the fixed
28832 (Block.AddVariable): Return the VariableInfo on success and null
28833 on failure instead of true/false.
28835 * cs-parser.jay (foreach): Catch errors on variables already
28836 defined (we were ignoring this value before) and properly unwind
28837 the block hierarchy
28839 (fixed_statement): grammar for the fixed statement.
28841 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28843 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28844 pointer types to be incretemented.
28846 (SizeOf): Implement.
28848 * cs-parser.jay (pointer_member_access): Implement
28849 expr->IDENTIFIER production.
28851 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28852 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28855 (Unary): Implement indirection.
28857 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28858 use in non-unsafe context).
28860 (SimpleName.DoResolve): Check for pointers in field access on safe
28863 (Expression.LoadFromPtr): Factor the load-indirect code in this
28864 function. This was duplicated in UnboxCast and ParameterReference
28866 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28868 * expression.cs (ComposedCast): report an error if a pointer cast
28869 is used in a safe region.
28871 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28872 pointer type casts in unsafe context.
28874 * codegen.cs (EmitContext): Set up IsUnsafe.
28876 * cs-parser.jay (non_expression_type): Add productions for pointer
28879 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28880 code. We should not use force into static mode if the method is
28881 not virtual. Fixes bug in MIS
28883 * statement.cs (Do.Emit, While.Emit, For.Emit,
28884 Statement.EmitBoolExpression): Add support to Do and While to
28885 propagate infinite loop as `I do return' semantics.
28887 Improve the For case to also test for boolean constants.
28889 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28890 to the list of attributes we can add.
28892 Remove `EmitContext' argument.
28894 * class.cs (Method.Define): Apply parameter attributes.
28895 (Constructor.Define): Apply parameter attributes.
28896 (MethodCore.LabelParameters): Move here the core of labeling
28899 * support.cs (ReflectionParameters.ParameterModifier,
28900 InternalParameters.ParameterModifier): Use IsByRef on the type and
28901 only return the OUT bit for these parameters instead of in/out/ref
28904 This is because I miss-understood things. The ParameterInfo.IsIn
28905 and IsOut represent whether the parameter has the [In] and [Out]
28908 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28910 * ecore.cs (FieldExpr.Emit): Release temporaries.
28912 * assign.cs (LocalTemporary.Release): new function.
28914 * codegen.cs (EmitContext.GetTemporaryStorage,
28915 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28916 temporary storage. Now we can "put back" localbuilders when we
28919 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28921 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28922 need to make a copy of the variable to generate verifiable code.
28924 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28926 * driver.cs: Compute dynamically the system directory.
28928 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28929 Slower, but more generally useful. Used by the abstract
28930 registering implementation.
28932 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28933 the rules for the special rule on Type/instances. First check if
28934 we have the same name, and if so, try that special static path
28935 rather than the instance path.
28937 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28939 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28942 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28943 Enum, ValueType, Delegate or Array for non-corlib compiles.
28945 * cs-tokenizer.cs: Catch long identifiers (645)
28947 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28950 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28951 fix, we were returning too early, so we were not registering
28952 pending methods from abstract classes.
28954 Do not register pending methods if the class is abstract.
28956 * expression.cs (Conditional.DoResolve): Report circular implicit
28957 conversions when we neecd to compute it for conditional
28960 (Is.DoResolve): If the expression is always of the provided type,
28961 flag warning 183. If the expression can not ever be of the
28962 provided type flag warning 184.
28964 * class.cs: Catch 169 as well.
28966 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28969 2002-01-18 Nick Drochak <ndrochak@gol.com>
28971 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28973 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28975 * interface.cs: (PopulateMethod): Check for pointers being defined
28976 only if the unsafe context is active.
28977 (PopulateProperty): ditto.
28978 (PopulateIndexer): ditto.
28980 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28981 specified. If pointers are present, make sure that they are
28982 present in an unsafe context.
28983 (Constructor, Constructor.Define): ditto.
28984 (Field, Field.Define): ditto.
28985 (Property, Property.Define): ditto.
28986 (Event, Event.Define): ditto.
28988 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28989 hashtable if there are classes or structs defined.
28991 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28992 code, as the constant resolution moved.
28994 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28995 the metadata, so we can flag error 133.
28997 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28998 pointer is being declared in an unsafe context.
29000 2002-01-16 Miguel de Icaza <miguel@ximian.com>
29002 * modifiers.cs (Modifiers.Check): Require a Location argument.
29003 Report error 227 for Unsafe use.
29005 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
29007 * statement.cs (For.Emit): If the test is null, then report that
29008 we do `return', as we wont reach anything afterwards.
29010 (Switch.SwitchGoverningType): Track the expression that matched
29013 * driver.cs: Allow negative numbers as an error code to flag.
29015 * cs-parser.jay: Handle 1551.
29017 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
29019 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29021 * cs-parser.jay: Report 1518 (type declaration can only contain
29022 class, struct, interface, enum or delegate)
29024 (switch_label): Report 1523 (keywords `case' or `default' must
29027 (opt_switch_sections): Report 1522 (empty switch)
29029 * driver.cs: Report 1515 (response file specified multiple times)
29030 Report 1516 (Source file specified multiple times).
29032 * expression.cs (Argument.Resolve): Signal 1510
29034 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
29035 access not allowed in static code)
29037 2002-01-11 Ravi Pratap <ravi@ximian.com>
29039 * typemanager.cs (IsPointerType): Utility method which we are going
29042 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
29043 the object type, so we take care of that.
29045 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
29047 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
29048 added to non-params parameters :-)
29050 * typemanager.cs (CSharpName): Include 'void' type too.
29052 (void_ptr_type): Include in the set of core types.
29054 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
29057 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
29060 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
29061 completely forgotten about it.
29063 2002-01-10 Ravi Pratap <ravi@ximian.com>
29065 * cs-parser.jay (pointer_type): Add. This begins our implementation
29066 of parsing rules for unsafe code.
29068 (unsafe_statement): Implement.
29070 (embedded_statement): Modify to include the above.
29072 * statement.cs (Unsafe): Implement new class for unsafe blocks.
29074 * codegen.cs (EmitContext.InUnsafe): Add. This determines
29075 if the current context is an unsafe one.
29077 * cs-parser.jay (local_variable_pointer_type): Since local variable types
29078 are handled differently, we need separate rules for them.
29080 (local_variable_declaration): Update to use local_variable_pointer_type
29081 to allow variable declarations of unmanaged pointer types.
29083 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
29084 in unsafe contexts.
29086 * ../errors/cs0214.cs : Add.
29088 2002-01-16 Nick Drochak <ndrochak@gol.com>
29090 * makefile: remove 'response' file when cleaning.
29092 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29094 * cs-parser.jay: Report 1524.
29096 2002-01-14 Miguel de Icaza <miguel@ximian.com>
29098 * typemanager.cs (RegisterMethod): drop checking if we have
29099 registered this from here
29101 2002-01-12 Miguel de Icaza <miguel@ximian.com>
29103 * class.cs (Method.EmitDestructor): Implement calling our base
29106 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
29107 value of InFinally.
29109 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
29110 this routine and will wrap the call in a try/catch block. Deal
29113 2002-01-11 Miguel de Icaza <miguel@ximian.com>
29115 * ecore.cs (Expression.MemberLookup): instead of taking a
29116 parameter `same_type' that was used to tell whether we could
29117 access private members we compute our containing type from the
29120 (FieldExpr): Added partial support for volatile fields. This does
29121 not work for volatile fields exposed from assemblies, as I can not
29122 figure out how to extract the modreq from it.
29124 Updated all the source files to use this.
29126 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
29127 because it is referenced by MemberLookup very often.
29129 2002-01-09 Ravi Pratap <ravi@ximian.com>
29131 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
29132 TypeBuilder.GetCustomAttributes to retrieve what we need.
29134 Get rid of redundant default_member_attr_type as this is the same as
29135 default_member_type which already exists.
29137 * interface.cs, attribute.cs : Update accordingly.
29139 2002-01-08 Miguel de Icaza <miguel@ximian.com>
29141 * typemanager.cs: Enable IndexerPropertyName again. It does not
29142 work for TYpeBuilders though. Ravi, can you please fix this?
29144 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
29146 * expression.cs (Argument.Emit): Handle the case of ref objects
29147 being passed to ref functions;
29149 (ParameterReference.EmitLoad): Loads the content of the pointer
29150 without dereferencing.
29152 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29154 * cs-tokenizer.cs: Implemented the pre-processing expressions.
29156 2002-01-08 Ravi Pratap <ravi@ximian.com>
29158 * class.cs (Indexer.DefineMethod): Incorporate the interface
29159 type in the name of the method if we are doing explicit interface
29162 * expression.cs (ConversionExists): Remove as it is completely obsolete.
29164 (BetterConversion): Fix extremely trivial bug where we were referring to
29165 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
29168 * ../errors/bug16.cs : Add although we have fixed it.
29170 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29172 * expression.cs (BaseIndexer): Begin implementation.
29174 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
29176 * cs-parser.jay (indexer_declarator): Use qualified_identifier
29177 production directly to remove a shift/reduce, and implement
29178 explicit interface implementation.
29180 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
29181 after a floating point suffix.
29183 * expression.cs (DoNumericPromotions): Improved the conversion for
29184 uint/uint. If we have a constant, we avoid doing a typecast to a
29187 * class.cs (Indexer): Implement explicit interface implementation
29190 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
29192 * class.cs: make the default instance constructor public and hidebysig.
29194 2001-01-03 Ravi Pratap <ravi@ximian.com>
29196 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
29197 so we can call it from elsewhere.
29199 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
29200 we emit it internally if the class has a defined indexer; otherwise the user
29201 emits it by decorating the class definition with the DefaultMemberAttribute.
29203 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
29204 attribute is not used on a type which defines an indexer.
29206 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
29207 character when we skip whitespace.
29209 * ../errors/cs0646.cs : Add.
29211 2002-01-03 Miguel de Icaza <miguel@ximian.com>
29213 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
29216 * makefile: Add practical target `mcs3.exe' which builds the third
29217 generation compiler.
29219 * expression.cs (New): Fix structures constructor calling.
29221 * class.cs (Property, Method, Indexer): Emit Final flag on the
29222 method if we are an interface implementation and we are not
29225 * ecore.cs (PropertyExpr): New public field `IsBase', tells
29226 whether this property is referencing a `base' method.
29228 * expression.cs (Invocation.EmitCall): take an extra argument:
29229 is_base, this is used to determine whether the `call' or
29230 `callvirt' opcode should be used.
29233 * delegate.cs: update EmitCall.
29235 * class.cs (Method.Define): Set NewSlot for the cases where we are
29236 not implementing an interface method.
29238 (Property.Define): ditto.
29240 2002-01-02 Miguel de Icaza <miguel@ximian.com>
29242 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
29243 'r'. Allows mcs to parse itself fully.
29245 2002-01-02 Ravi Pratap <ravi@ximian.com>
29247 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
29248 of the number of initializers that require the InitializeArray method.
29250 (CheckIndices): Store the Expression in all cases - not the plain value. Also
29251 update the above field where necessary.
29253 (MakeByteBlob): Update accordingly.
29255 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
29258 (EmitDynamicInitializers): Update in accordance with the new optimization.
29260 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
29261 same OpCode applies.
29263 * cs-parser.jay : Fix some glaring errors I introduced.
29265 2002-01-01 Ravi Pratap <ravi@ximian.com>
29267 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
29268 so that we can check for name clashes there too.
29270 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29271 for interface indexers.
29273 * interfaces.cs (Define): Emit the default member attribute.
29275 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29276 variable was being referred to while setting the value ;-)
29278 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29280 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29281 byte-by-byte information when we know the data is zero.
29283 Make the block always a multiple of 4, because
29284 DefineInitializedData has a bug.
29286 * assign.cs: Fix, we should assign from the temporary, not from
29289 * expression.cs (MakeByteBlob): Fix my incorrect code.
29291 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29293 * typemanager.cs (EnumToUnderlying): This function is used to get
29294 the underlying type from an enumeration, because it does not
29297 * constant.cs: Use the I4_S form for values between -128 and 127.
29299 * statement.cs (Block.LookupLabel): Looks up a label.
29300 (Block): Drop support for labeled blocks.
29302 (LabeledStatement): New kind of statement that represents a label
29305 (Goto): Finally implement this bad boy.
29307 * cs-parser.jay: Update to reflect new mechanism to implement
29310 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29312 * codegen.cs (EmitContext.This): a codegen property that keeps the
29313 a single instance of this instead of creating many different this
29316 * delegate.cs (Delegate.DoResolve): Update to use the property;
29318 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29320 * expression.cs (BaseAccess.DoResolve): Ditto.
29322 2001-12-29 Ravi Pratap <ravi@ximian.com>
29324 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29325 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29327 (InitCoreTypes): Update accordingly.
29329 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29330 so we can quickly store the state.
29332 (ApplyAttributes): Set the correct implementation flags
29333 for InternalCall methods.
29335 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29337 * expression.cs (EmitCall): if a method is not virtual, then do
29338 not use callvirt on it.
29340 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29341 user defined stuff) requires the use of stobj, which takes an
29342 address on the stack instead of an array and an index. So emit
29343 the Ldelema operation for it.
29345 (EmitStoreOpcode): Use stobj for valuetypes.
29347 (UnaryMutator.EmitCode): Use the right 1 value depending on
29348 whether we are dealing with int64/uint64, float or doubles.
29350 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29351 constructors that I implemented last night.
29353 (Constructor.IsDefault): Fix to work properly for static
29356 * cs-parser.jay (CheckDef): report method signature errors.
29357 Update error number 103 to be 132.
29359 * decl.cs: New AdditionResult enumeration value: MethodExists.
29360 Although we do this check for methods later on in the semantic
29361 analysis, catching repeated default constructors is so easy that
29362 we catch these here.
29364 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29367 (ParameterReference.EmitAssign, Emit): handle
29370 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29371 (ArrayAccess.EmitStoreOpcode): ditto.
29373 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29375 * expression.cs (MakeByteBlob): Complete all the missing types
29376 (uint, short, ushort, byte, sbyte)
29378 * class.cs: Only init instance field initializers on instance
29381 Rename `constructors' to instance_constructors.
29383 (TypeContainer.AddConstructor): Only add constructors to the list
29384 if it is not static.
29386 Make sure that we handle default_static_constructor independently
29387 everywhere where we handle instance_constructors
29389 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29391 * class.cs: Do not lookup or create a base initializer for a
29392 static constructor.
29394 (ConstructorInitializer.Resolve): use the proper type to lookup
29397 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29399 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29402 * decl.cs: CloseType is now an virtual method, the default
29403 implementation just closes this type.
29405 2001-12-28 Ravi Pratap <ravi@ximian.com>
29407 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29408 to PreserveSig by default. Also emit HideBySig on such methods.
29410 Basically, set the defaults to standard values.
29412 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29413 argument, if candidate is better, it can't be worse than the best !
29415 (Invocation): Re-write bits to differentiate between methods being
29416 applicable in their expanded form and their normal form - for params
29419 Get rid of use_standard everywhere as only standard conversions are allowed
29420 in overload resolution.
29422 More spec conformance.
29424 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29426 * driver.cs: Add --timestamp, to see where the compiler spends
29429 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29430 `this' in static code.
29432 (SimpleName.DoResolve): Implement in terms of a helper function
29433 that allows static-references to be passed upstream to
29436 (Expression.ResolveWithSimpleName): Resolve specially simple
29437 names when called by MemberAccess to implement the special
29440 (Expression.ImplicitReferenceConversion): Handle conversions from
29441 Null to reference types before others, as Null's type is
29444 * expression.cs (Invocation.EmitCall): Handle the special case of
29445 calling methods declared on a reference type from a ValueType
29446 (Base classes System.Object and System.Enum)
29448 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29449 the left hand side is a TypeExpr, not on every enumeration.
29451 (Binary.Resolve): If types are reference types, then do a cast to
29452 object on operators != and == of both arguments.
29454 * typemanager.cs (FindMembers): Extract instance and static
29455 members if requested.
29457 * interface.cs (PopulateProperty): Use void_type instead of null
29458 as the return type for the setter method.
29460 (PopulateIndexer): ditto.
29462 2001-12-27 Ravi Pratap <ravi@ximian.com>
29464 * support.cs (ReflectionParameters): Fix minor bug where we
29465 were examining the wrong parameter for the ParamArray attribute.
29467 Cope with requests for the type of the parameter at position
29468 greater than the params parameter's. We now return the element
29469 type of the params array as that makes more sense.
29471 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29472 accordingly as we no longer have to extract the element type
29475 (Invocation.OverloadResolve): Update.
29477 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29479 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29480 against IEnumerator, test whether the return value is a descendant
29481 of the IEnumerator interface.
29483 * class.cs (Indexer.Define): Use an auxiliary method to implement
29484 the other bits of the method definition. Begin support for
29485 explicit interface implementation.
29487 (Property.DefineMethod): Use TypeManager.void_type instead of null
29488 for an empty return value.
29490 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29492 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29493 dealing with a FieldExpr which is composed of a FieldBuilder, in
29494 the code path we did extract the constant, but we should have
29495 obtained the underlying value to be able to cast it (otherwise we
29496 end up in an infinite loop, this is what Ravi was running into).
29498 (ArrayCreation.UpdateIndices): Arrays might be empty.
29500 (MemberAccess.ResolveMemberAccess): Add support for section
29501 14.5.4.1 that deals with the special case of E.I when E is a type
29502 and something else, that I can be a reference to a static member.
29504 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29505 handle a particular array type to create byte blobs, it is just
29506 something we dont generate byteblobs for.
29508 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29511 * location.cs (Push): remove the key from the hashtable that we
29512 are about to add. This happens for empty files.
29514 * driver.cs: Dispose files after we have parsed them.
29516 (tokenize): new function that only runs the tokenizer on its
29517 input, for speed testing.
29519 2001-12-26 Ravi Pratap <ravi@ximian.com>
29521 * class.cs (Event.Define): Define the private field only if there
29522 are no accessors defined.
29524 * expression.cs (ResolveMemberAccess): If there is no associated
29525 field with the event, that means we have an event defined with its
29526 own accessors and we should flag error cs0070 since transforming
29527 ourselves into a field is not valid in that case.
29529 * ecore.cs (SimpleName.DoResolve): Same as above.
29531 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29532 and charset to sane values.
29534 2001-12-25 Ravi Pratap <ravi@ximian.com>
29536 * assign.cs (DoResolve): Perform check on events only if they
29537 are being accessed outside the declaring type.
29539 * cs-parser.jay (event_declarations): Update rules to correctly
29540 set the type of the implicit parameter etc.
29542 (add_accessor, remove_accessor): Set current local parameters.
29544 * expression.cs (Binary): For delegate addition and subtraction,
29545 cast the return value from the method into the appropriate delegate
29548 2001-12-24 Ravi Pratap <ravi@ximian.com>
29550 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29551 of these as the workaround is unnecessary.
29553 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29554 delegate data - none of that is needed at all.
29556 Re-write bits to extract the instance expression and the delegate method
29559 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29562 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29563 of attaching attributes instead of duplicating code everywhere.
29565 * everywhere : Update code to do attribute emission using the above method.
29567 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29569 * expression.cs (IsParamsMethodApplicable): if there are not
29570 parameters, return immediately.
29572 * ecore.cs: The 0 literal can be implicity converted to an enum
29575 (SimpleName.DoResolve): First lookup the type, then lookup the
29578 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29579 want to get its address. If the InstanceExpression is not
29580 addressable, store the result in a temporary variable, then get
29583 * codegen.cs: Only display 219 errors on warning level or above.
29585 * expression.cs (ArrayAccess): Make it implement the
29586 IMemoryLocation interface.
29588 (Binary.DoResolve): handle the operator == (object a, object b)
29589 and operator != (object a, object b) without incurring into a
29590 BoxedCast (because 5 != o should never be performed).
29592 Handle binary enumerator operators.
29594 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29595 value type, otherwise use Ldelem_ref.
29597 Use precomputed names;
29599 (AddressOf): Implement address of
29601 * cs-parser.jay (labeled_statement): Fix recursive block
29602 addition by reworking the production.
29604 * expression.cs (New.DoEmit): New has a special case:
29606 If we are dealing with a ValueType, we have a few
29607 situations to deal with:
29609 * The target of New is a ValueType variable, that is
29610 easy, we just pass this as the variable reference
29612 * The target of New is being passed as an argument,
29613 to a boxing operation or a function that takes a
29616 In this case, we need to create a temporary variable
29617 that is the argument of New.
29620 2001-12-23 Ravi Pratap <ravi@ximian.com>
29622 * rootcontext.cs (LookupType): Check that current_type is not null before
29623 going about looking at nested types.
29625 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29626 not implement the IAssignMethod interface any more.
29628 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29629 where we tranform them into FieldExprs if they are being resolved from within
29630 the declaring type.
29632 * ecore.cs (SimpleName.DoResolve): Do the same here.
29634 * assign.cs (DoResolve, Emit): Clean up code considerably.
29636 * ../errors/bug10.cs : Add.
29638 * ../errors/cs0070.cs : Add.
29640 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29642 * assign.cs : Get rid of EventIsLocal everywhere.
29644 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29646 * ecore.cs (ConvertIntLiteral): finished the implementation.
29648 * statement.cs (SwitchLabel): Convert the value we are using as a
29649 key before looking up the table.
29651 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29653 * codegen.cs (EmitTopBlock): Require a Location argument now.
29655 * cs-parser.jay (constructor_declarator): We need to setup
29656 current_local_parameters before we parse the
29657 opt_constructor_initializer, to allow the variables to be bound
29658 to the constructor arguments.
29660 * rootcontext.cs (LookupType): First lookup nested classes in our
29661 class and our parents before we go looking outside our class.
29663 * expression.cs (ConstantFold): Extract/debox the values at the
29666 * rootcontext.cs (EmitCode): Resolve the constants first before we
29667 resolve the types. This is not really needed, but it helps debugging.
29669 * statement.cs: report location.
29671 * cs-parser.jay: pass location to throw statement.
29673 * driver.cs: Small bug fix.
29675 * report.cs: Updated format to be 4-zero filled digits.
29677 2001-12-22 Ravi Pratap <ravi@ximian.com>
29679 * expression.cs (CheckIndices): Fix minor bug where the wrong
29680 variable was being referred to ;-)
29682 (DoEmit): Do not call EmitStaticInitializers when the
29683 underlying type is System.Object.
29685 2001-12-21 Ravi Pratap <ravi@ximian.com>
29687 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29688 and do the usual workaround for SRE.
29690 * class.cs (MyEventBuilder.EventType): New member to get at the type
29691 of the event, quickly.
29693 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29695 * assign.cs (Assign.DoResolve): Handle the case when the target
29696 is an EventExpr and perform the necessary checks.
29698 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29701 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29703 (EventExpr): Set the type in the constructor itself since we
29704 are meant to be born fully resolved.
29706 (EventExpr.Define): Revert code I wrote earlier.
29708 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29709 instance expression is null. The instance expression is a This in that case
29710 or a null, depending on whether it is a static method or not.
29712 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29713 refers to more than one method.
29715 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29716 and accordingly flag errors.
29718 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29720 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29722 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29724 * location.cs (ToString): Provide useful rutine.
29726 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29728 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29729 objects, return the actual integral boxed.
29731 * statement.cs (SwitchLabel): define an ILLabel for each
29734 (Switch.CheckSwitch): If the value is a Literal, extract
29735 the underlying literal.
29737 Also in the unused hashtable we had, add the SwitchLabel so we can
29738 quickly look this value up.
29740 * constant.cs: Implement a bunch of new constants. Rewrite
29741 Literal based on this. Made changes everywhere to adapt to this.
29743 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29744 dereferencing array only once, and also copes with enumrations.
29746 bytes are two bytes wide, not one.
29748 (Cast): Perform constant conversions.
29750 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29751 wrappers to the literals here.
29753 * expression.cs (DoNumericPromotions): long literals can converted
29754 to ulong implicity (this is taken care of elsewhere, but I was
29755 missing this spot).
29757 * ecore.cs (Expression.Literalize): Make the return type Literal,
29758 to improve type checking.
29760 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29762 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29764 * literal.cs: Revert code from ravi that checked the bounds. The
29765 bounds are sane by the definition of the type itself.
29767 * typemanager.cs: Fix implementation of ImplementsInterface. We
29768 need to actually look up in our parent hierarchy for interfaces
29771 * const.cs: Use the underlying type for enumerations
29773 * delegate.cs: Compute the basename for the delegate creation,
29774 that should fix the delegate test case, and restore the correct
29775 Type Lookup semantics in rootcontext
29777 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29778 referencing a nested type with the Reflection API is using the "+"
29781 * cs-parser.jay: Do not require EOF token at the end.
29783 2001-12-20 Ravi Pratap <ravi@ximian.com>
29785 * rootcontext.cs (LookupType): Concatenate type names with
29786 a '.' instead of a '+' The test suite passes again.
29788 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29789 field of the enumeration.
29791 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29792 the case when the member is an EventExpr.
29794 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29795 static has an associated instance expression.
29797 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29799 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29801 * class.cs (Event.Define): Register event and perform appropriate checks
29804 We define the Add and Remove methods even if the use provides none because
29805 in that case, we provide default implementations ourselves.
29807 Define a private field of the type of the event. This is done by the CSC compiler
29808 and we should be doing it too ;-)
29810 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29811 More methods we use in code we generate.
29813 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29816 (InitCoreTypes): Update accordingly for the above.
29818 * class.cs (Event.Emit): Generate code for default accessors that we provide
29820 (EmitDefaultMethod): Do the job in the above.
29822 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29825 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29827 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29828 builders even if we were missing one.
29830 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29831 pass the Basename as our class name instead of the Name. The
29832 basename will be correctly composed for us.
29834 * parameter.cs (Paramters): Now takes a Location argument.
29836 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29837 make all the code call directly LookupType in RootContext and take
29838 this chance to pass the Location information everywhere.
29840 * Everywhere: pass Location information.
29842 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29844 * class.cs (Constructor.Define): Updated way of detecting the
29845 length of the parameters.
29847 (TypeContainer.DefineType): Use basename as the type name for
29850 (TypeContainer.Define): Do not recursively define types here, as
29851 definition is taken care in order by the RootContext.
29853 * tree.cs: Keep track of namespaces in a per-file basis.
29855 * parameter.cs (Parameter.ComputeSignature): Update to use
29858 (Parameters.GetSignature): ditto.
29860 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29861 instead of a TypeContainer.
29863 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29864 resolve names. Because we need to be resolve in our context, not
29867 * driver.cs: Implement response files.
29869 * class.cs (TypeContainer.DefineType): If we are defined, do not
29870 redefine ourselves.
29872 (Event.Emit): Emit the code for add/remove handlers.
29873 (Event.Define): Save the MethodBuilders for add/remove.
29875 * typemanager.cs: Use pair here too.
29877 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29878 DictionaryEntry requires the first argument to be non-null.
29880 (enum_declaration): Compute full name for registering the
29883 (delegate_declaration): Instead of using
29884 formal_parameter_list, use opt_formal_parameter_list as the list
29887 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29888 (EventParsing): New property that controls whether `add' and
29889 `remove' are returned as tokens or identifiers (for events);
29891 2001-12-19 Ravi Pratap <ravi@ximian.com>
29893 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29894 use MyEventBuilder only and let it wrap the real builder for us.
29896 (MyEventBuilder): Revamp constructor etc.
29898 Implement all operations that we perform on EventBuilder in precisely the same
29901 (FindMembers): Update to use the EventBuilder member.
29903 (Event.Emit): Update accordingly.
29905 2001-12-18 Ravi Pratap <ravi@ximian.com>
29907 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29908 by calling the appropriate methods.
29910 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29913 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29915 2001-12-17 Ravi Pratap <ravi@ximian.com>
29917 * delegate.cs (Delegate.Populate): Check that the return type
29918 and various parameters types are indeed accessible.
29920 * class.cs (Constructor.Define): Same here.
29922 (Field.Define): Ditto.
29924 (Event.Define): Ditto.
29926 (Operator.Define): Check that the underlying Method defined itself
29927 correctly - so it's MethodBuilder should not be null.
29929 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29930 expression happens to be null.
29932 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29933 members but as of now we don't seem to be able to do anything really useful with it.
29935 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29936 not the EventBuilder.
29938 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29940 * cs-tokenizer.cs: Add support for defines.
29941 Add support for #if, #elif, #else, #endif
29943 (eval_var): evaluates a variable.
29944 (eval): stubbed for evaluating functions.
29946 * cs-parser.jay: Pass the defines information
29948 * driver.cs: Add --define command line option.
29950 * decl.cs: Move MemberCore here.
29952 Make it the base class for DeclSpace. This allows us to catch and
29953 report 108 and 109 for everything now.
29955 * class.cs (TypeContainer.Define): Extract all the members
29956 before populating and emit the warning 108 (new keyword required
29957 to override) instead of having each member implement this.
29959 (MemberCore.Define): New abstract method, we will be using this in
29960 the warning reporting engine in Populate.
29962 (Operator.Define): Adjust to new MemberCore protocol.
29964 * const.cs (Const): This does not derive from Expression, it is a
29965 temporary object we use to create fields, it is a MemberCore.
29967 * class.cs (Method.Define): Allow the entry point to be in a
29970 * driver.cs: Rewrite the argument handler to clean it up a bit.
29972 * rootcontext.cs: Made it just an auxiliary namespace feature by
29973 making everything static.
29975 * driver.cs: Adapt code to use RootContext type name instead of
29978 * delegate.cs: Remove RootContext argument.
29980 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29983 * class.cs (Event.Define): The lookup can fail.
29985 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29987 * expression.cs: Resolve the this instance before invoking the code.
29989 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29991 * cs-parser.jay: Add a production in element_access that allows
29992 the thing to become a "type" reference. This way we can parse
29993 things like "(string [])" as a type.
29995 Note that this still does not handle the more complex rules of
29999 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
30001 * ecore.cs: (CopyNewMethods): new utility function used to
30002 assemble the list of methods from running FindMembers.
30004 (MemberLookup): Rework FindMembers so that
30006 2001-12-16 Miguel de Icaza <miguel@ximian.com>
30008 * class.cs (TypeContainer): Remove Delegates who fail to be
30011 * delegate.cs (Populate): Verify that we dont get null return
30012 values. TODO: Check for AsAccessible.
30014 * cs-parser.jay: Use basename to emit error 574 (destructor should
30015 have the same name as container class), not the full name.
30017 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
30018 possible representation.
30020 Also implements integer type suffixes U and L.
30022 2001-12-15 Miguel de Icaza <miguel@ximian.com>
30024 * expression.cs (ArrayCreation.DoResolve): We need to do the
30025 argument resolution *always*.
30027 * decl.cs: Make this hold the namespace. Hold the root context as
30029 (LookupType): Move here.
30031 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
30033 * location.cs (Row, Name): Fixed the code, it was always returning
30034 references to the first file.
30036 * interface.cs: Register properties defined through interfaces.
30038 * driver.cs: Add support for globbing on the command line
30040 * class.cs (Field): Make it derive from MemberCore as well.
30043 2001-12-15 Ravi Pratap <ravi@ximian.com>
30045 * class.cs (Event::Define): Check that the type of the event is a delegate
30046 type else flag error #66.
30048 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
30051 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
30052 values of EntryPoint, CharSet etc etc.
30054 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
30056 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
30057 be null and we should ignore this. I am not sure if this is really clean. Apparently,
30058 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
30059 which needs this to do its work.
30061 * ../errors/cs0066.cs : Add.
30063 2001-12-14 Miguel de Icaza <miguel@ximian.com>
30065 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
30068 * class.cs: (MethodSignature.MethodSignature): Removed hack that
30069 clears out the parameters field.
30070 (MemberSignatureCompare): Cleanup
30072 (MemberCore): New base class used to share code between MethodCore
30075 (RegisterRequiredImplementations) BindingFlags.Public requires
30076 either BindingFlags.Instace or Static. Use instance here.
30078 (Property): Refactored code to cope better with the full spec.
30080 * parameter.cs (GetParameterInfo): Return an empty array instead
30083 * class.cs (Property): Abstract or extern properties have no bodies.
30085 * parameter.cs (GetParameterInfo): return a zero-sized array.
30087 * class.cs (TypeContainer.MethodModifiersValid): Move all the
30088 method modifier validation to the typecontainer so we can reuse
30089 this on properties.
30091 (MethodCore.ParameterTypes): return an empty sized array of types.
30093 (Property.Define): Test property modifier validity.
30095 Add tests for sealed/override too.
30097 (Method.Emit): abstract or extern methods have no bodies.
30099 2001-12-14 Ravi Pratap <ravi@ximian.com>
30101 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
30104 (Method::Define, ::Emit): Modify accordingly.
30106 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
30108 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
30110 * makefile: Pass in /unsafe.
30112 2001-12-13 Miguel de Icaza <miguel@ximian.com>
30114 * class.cs (MakeKey): Kill routine.
30116 * class.cs (TypeContainer.Define): Correctly define explicit
30117 method implementations (they require the full interface name plus
30120 * typemanager.cs: Deply the PtrHashtable here and stop using the
30121 lame keys. Things work so much better.
30123 This of course broke everyone who depended on `RegisterMethod' to
30124 do the `test for existance' test. This has to be done elsewhere.
30126 * support.cs (PtrHashtable): A hashtable that avoid comparing with
30127 the object stupid Equals method (because, that like fails all over
30128 the place). We still do not use it.
30130 * class.cs (TypeContainer.SetRequiredInterface,
30131 TypeContainer.RequireMethods): Killed these two routines and moved
30132 all the functionality to RegisterRequiredImplementations.
30134 (TypeContainer.RegisterRequiredImplementations): This routine now
30135 registers all the implementations required in an array for the
30136 interfaces and abstract methods. We use an array of structures
30137 which can be computed ahead of time to reduce memory usage and we
30138 also assume that lookups are cheap as most classes will not
30139 implement too many interfaces.
30141 We also avoid creating too many MethodSignatures.
30143 (TypeContainer.IsInterfaceMethod): Update and optionally does not
30144 clear the "pending" bit if we find that there are problems with
30147 (TypeContainer.VerifyPendingMethods): Update to report errors of
30148 methods that look like implementations but are not.
30150 (TypeContainer.Define): Add support for explicit interface method
30153 2001-12-12 Miguel de Icaza <miguel@ximian.com>
30155 * typemanager.cs: Keep track of the parameters here instead of
30156 being a feature of the TypeContainer.
30158 * class.cs: Drop the registration of parameters here, as
30159 InterfaceMethods are also interface declarations.
30161 * delegate.cs: Register methods with the TypeManager not only with
30162 the TypeContainer. This code was buggy.
30164 * interface.cs: Full registation here.
30166 2001-12-11 Miguel de Icaza <miguel@ximian.com>
30168 * expression.cs: Remove reducer for binary expressions, it can not
30171 * const.cs: Put here the code that used to go into constant.cs
30173 * constant.cs: Put here the code for constants, this is a new base
30174 class for Literals.
30176 * literal.cs: Make Literal derive from Constant.
30178 2001-12-09 Miguel de Icaza <miguel@ximian.com>
30180 * statement.cs (Return.Emit): Report error 157 if the user
30181 attempts to return from a finally block.
30183 (Return.Emit): Instead of emitting a return, jump to the end of
30186 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
30187 LocalBuilder to store the result of the function. ReturnLabel is
30188 the target where we jump.
30191 2001-12-09 Radek Doulik <rodo@ximian.com>
30193 * cs-parser.jay: remember alias in current namespace
30195 * ecore.cs (SimpleName::DoResolve): use aliases for types or
30198 * class.cs (LookupAlias): lookup alias in my_namespace
30200 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
30202 (LookupAlias): lookup alias in this and if needed in parent
30205 2001-12-08 Miguel de Icaza <miguel@ximian.com>
30209 * rootcontext.cs: (ModuleBuilder) Made static, first step into
30210 making things static. I need this to avoid passing the
30211 TypeContainer when calling ParameterType.
30213 * support.cs (InternalParameters.ParameterType): Remove ugly hack
30214 that did string manipulation to compute the type and then call
30215 GetType. Use Parameter.ParameterType instead.
30217 * cs-tokenizer.cs: Consume the suffix for floating values.
30219 * expression.cs (ParameterReference): figure out whether this is a
30220 reference parameter or not. Kill an extra variable by computing
30221 the arg_idx during emission.
30223 * parameter.cs (Parameters.GetParameterInfo): New overloaded
30224 function that returns whether a parameter is an out/ref value or not.
30226 (Parameter.ParameterType): The type of the parameter (base,
30227 without ref/out applied).
30229 (Parameter.Resolve): Perform resolution here.
30230 (Parameter.ExternalType): The full type (with ref/out applied).
30232 * statement.cs (Using.Emit, Using.EmitExpression): Implement
30233 support for expressions on the using statement.
30235 2001-12-07 Miguel de Icaza <miguel@ximian.com>
30237 * statement.cs (Using.EmitLocalVariableDecls): Split the
30238 localvariable handling of the using statement.
30240 (Block.EmitMeta): Keep track of variable count across blocks. We
30241 were reusing slots on separate branches of blocks.
30243 (Try.Emit): Emit the general code block, we were not emitting it.
30245 Check the type of the declaration to be an IDisposable or
30246 something that can be implicity converted to it.
30248 Emit conversions if required.
30250 * ecore.cs (EmptyExpression): New utility class.
30251 (Expression.ImplicitConversionExists): New utility function.
30253 2001-12-06 Miguel de Icaza <miguel@ximian.com>
30255 * statement.cs (Using): Implement.
30257 * expression.cs (LocalVariableReference): Support read only variables.
30259 * statement.cs: Remove the explicit emit for the Leave opcode.
30260 (VariableInfo): Add a readonly field.
30262 2001-12-05 Miguel de Icaza <miguel@ximian.com>
30264 * ecore.cs (ConvCast): new class used to encapsulate the various
30265 explicit integer conversions that works in both checked and
30266 unchecked contexts.
30268 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30269 properly generate the overflow opcodes.
30271 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30273 * statement.cs: The correct type for the EmptyExpression is the
30274 element_type, not the variable type. Ravi pointed this out.
30276 2001-12-04 Ravi Pratap <ravi@ximian.com>
30278 * class.cs (Method::Define): Handle PInvoke methods specially
30279 by using DefinePInvokeMethod instead of the usual one.
30281 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30282 above to do the task of extracting information and defining the method.
30284 2001-12-04 Ravi Pratap <ravi@ximian.com>
30286 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30287 of the condition for string type.
30289 (Emit): Move that here.
30291 (ArrayCreation::CheckIndices): Keep string literals in their expression
30294 (EmitDynamicInitializers): Handle strings appropriately.
30296 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30298 * codegen.cs (EmitContext): Replace multiple variables with a
30299 single pointer to the current Switch statement.
30301 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30304 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30308 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30311 (Foreach.Emit): Foreach on arrays was not setting
30312 up the loop variables (for break/continue).
30314 (GotoCase): Semi-implented.
30316 2001-12-03 Ravi Pratap <ravi@ximian.com>
30318 * attribute.cs (CheckAttribute): Handle system attributes by using
30319 Attribute.GetAttributes to examine information we need.
30321 (GetValidPlaces): Same here.
30323 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30325 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30327 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30329 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30331 (Method::Emit): Handle the case when we are a PInvoke method.
30333 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30335 * expression.cs: Use ResolveWithSimpleName on compound names.
30337 2001-12-02 Ravi Pratap <ravi@ximian.com>
30339 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30340 before trying to reduce it.
30342 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30344 * constant.cs (LookupConstantValue): Implement.
30346 (EmitConstant): Use the above in emitting the constant.
30348 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30349 that are user-defined by doing a LookupConstantValue on them.
30351 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30354 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30356 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30358 (BaseAccess.DoResolve): Implement.
30360 (MemberAccess.DoResolve): Split this routine into a
30361 ResolveMemberAccess routine that can be used independently
30363 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30365 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30366 As that share bits of the implementation. Is returns a boolean,
30367 while As returns the Type that is being probed.
30369 2001-12-01 Ravi Pratap <ravi@ximian.com>
30371 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30372 instead of a Literal - much easier.
30374 (EnumInTransit): Remove - utterly useless :-)
30376 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30378 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30380 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30381 chain when we have no associated expression.
30383 2001-11-30 Ravi Pratap <ravi@ximian.com>
30385 * constant.cs (Define): Use Location while reporting the errror.
30387 Also emit a warning when 'new' is used and there is no inherited
30390 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30393 (LookupEnumValue): Implement to lookup an enum member's value and define it
30396 (Populate): Re-write accordingly to use the above routine.
30398 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30400 * expression.cs (This): Fix prototype for DoResolveLValue to
30401 override the base class DoResolveLValue.
30403 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30406 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30407 (we need to load the address of the field here). This fixes
30410 (FieldExpr.DoResolveLValue): Call the DoResolve
30411 function to initialize the Instance expression.
30413 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30414 correctly the GetEnumerator operation on a value type.
30416 * cs-parser.jay: Add more simple parsing error catches.
30418 * statement.cs (Switch): Add support for string switches.
30419 Handle null specially.
30421 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30423 2001-11-28 Ravi Pratap <ravi@ximian.com>
30425 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30427 (declare_local_constant): New helper function.
30429 * statement.cs (AddConstant): Keep a separate record of constants
30431 (IsConstant): Implement to determine if a variable is a constant.
30433 (GetConstantExpression): Implement.
30435 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30437 * statement.cs (IsVariableDefined): Re-write.
30439 2001-11-27 Ravi Pratap <ravi@ximian.com>
30441 * class.cs (TypeContainer::FindMembers): Look for constants
30442 in the case when we are looking for MemberTypes.Field
30444 * expression.cs (MemberAccess::DoResolve): Check that in the
30445 case we are a FieldExpr and a Literal, we are not being accessed
30446 by an instance reference.
30448 * cs-parser.jay (local_constant_declaration): Implement.
30450 (declaration_statement): Implement for constant declarations.
30452 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30454 * statement.cs (Switch): Catch double defaults.
30456 (Switch): More work on the switch() statement
30457 implementation. It works for integral values now, need to finish
30461 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30463 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30464 integer literals into other integer literals. To be used by
30467 2001-11-24 Ravi Pratap <ravi@ximian.com>
30469 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30472 (EmitDynamicInitializers): Cope with the above since we extract data
30473 directly from ArrayData now.
30475 (ExpectInitializers): Keep track of whether initializers are mandatory
30478 (Bounds): Make it a hashtable to prevent the same dimension being
30479 recorded for every element in that dimension.
30481 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30484 Also fix bug which was causing the indices to be emitted in the reverse
30487 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30489 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30490 unfinished. They do not work, because the underlying code is
30493 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30495 * cs-parser.jay: Remove bogus fixme.
30497 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30498 on Switch statement.
30500 2001-11-23 Ravi Pratap <ravi@ximian.com>
30502 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30505 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30506 parameter. Apparently, any expression is allowed.
30508 (ValidateInitializers): Update accordingly.
30510 (CheckIndices): Fix some tricky bugs thanks to recursion.
30512 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30513 I was being completely brain-dead.
30515 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30516 and re-write acordingly.
30518 (DelegateInvocation): Re-write accordingly.
30520 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30522 (MakeByteBlob): Handle types more correctly.
30524 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30525 initialization from expressions but it is incomplete because I am a complete
30528 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30530 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30531 on If. Basically, we have to return `true' (ie, we do return to
30532 our caller) only if both branches of the if return.
30534 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30535 short-circuit operators, handle them as short circuit operators.
30537 (Cast.DoResolve): Resolve type.
30538 (Cast.Cast): Take an expression as the target type.
30540 * cs-parser.jay (cast_expression): Remove old hack that only
30541 allowed a limited set of types to be handled. Now we take a
30542 unary_expression and we resolve to a type during semantic
30545 Use the grammar productions from Rhys to handle casts (this is
30546 not complete like Rhys syntax yet, we fail to handle that corner
30547 case that C# has regarding (-x), but we will get there.
30549 2001-11-22 Ravi Pratap <ravi@ximian.com>
30551 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30552 field which is an array type.
30554 * cs-parser.jay (declare_local_variables): Support array initialization too.
30556 * typemanager.cs (MakeKey): Implement.
30558 (everywhere): Use the above appropriately.
30560 * cs-parser.jay (for_statement): Update for array initialization while
30561 declaring variables.
30563 * ecore.cs : The error message was correct, it's the variable's names that
30564 were misleading ;-) Make the code more readable.
30566 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30567 the correct type etc.
30569 (ConvertExplicit): Handle Enum types by examining the underlying type.
30571 2001-11-21 Ravi Pratap <ravi@ximian.com>
30573 * parameter.cs (GetCallingConvention): Always return
30574 CallingConventions.Standard for now.
30576 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30578 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30579 and `r' after calling DoNumericPromotions.
30581 * ecore.cs: Fix error message (the types were in the wrong order).
30583 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30584 BindingFlags.Instance as well
30586 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30587 implicit int literal conversion in an empty cast so that we
30588 propagate the right type upstream.
30590 (UnboxCast): new class used to unbox value types.
30591 (Expression.ConvertExplicit): Add explicit type conversions done
30594 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30595 the target type before applying the implicit LongLiterals to ULong
30598 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30600 * cs-parser.jay (for_statement): Reworked the way For works: now
30601 we declare manually any variables that are introduced in
30602 for_initializer to solve the problem of having out-of-band code
30603 emition (that is what got for broken).
30605 (declaration_statement): Perform the actual variable declaration
30606 that used to be done in local_variable_declaration here.
30608 (local_variable_declaration): Do not declare anything, just pass
30609 the information on a DictionaryEntry
30611 2001-11-20 Ravi Pratap <ravi@ximian.com>
30613 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30614 re-write of the logic to now make it recursive.
30616 (UpdateIndices): Re-write accordingly.
30618 Store element data in a separate ArrayData list in the above methods.
30620 (MakeByteBlob): Implement to dump the array data into a byte array.
30622 2001-11-19 Ravi Pratap <ravi@ximian.com>
30624 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30627 * constant.cs (Define): Implement.
30629 (EmitConstant): Re-write fully.
30631 Pass in location info.
30633 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30636 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30637 DictionaryEntry since we need location info too.
30639 (constant_declaration): Update accordingly.
30641 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30642 code into another method : UpdateIndices.
30644 2001-11-18 Ravi Pratap <ravi@ximian.com>
30646 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30647 some type checking etc.
30649 2001-11-17 Ravi Pratap <ravi@ximian.com>
30651 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30652 bits to provide dimension info if the user skips doing that.
30654 Update second constructor to store the rank correctly.
30656 2001-11-16 Ravi Pratap <ravi@ximian.com>
30658 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30659 and try to implement.
30661 * ../errors/cs0150.cs : Add.
30663 * ../errors/cs0178.cs : Add.
30665 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30667 * statement.cs: Implement foreach on multi-dimensional arrays.
30669 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30670 name of the params argument.
30672 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30673 initializing the array.
30675 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30676 we can use this elsewhere.
30678 * statement.cs: Finish implementation of foreach for single
30681 * cs-parser.jay: Use an out-of-band stack to pass information
30682 around, I wonder why I need this.
30684 foreach_block: Make the new foreach_block the current_block.
30686 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30687 function used to return a static Parameters structure. Used for
30688 empty parameters, as those are created very frequently.
30690 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30692 2001-11-15 Ravi Pratap <ravi@ximian.com>
30694 * interface.cs : Default modifier is private, not public. The
30695 make verify test passes again.
30697 2001-11-15 Ravi Pratap <ravi@ximian.com>
30699 * support.cs (ReflectionParameters): Fix logic to determine
30700 whether the last parameter is a params one. Test 9 passes again.
30702 * delegate.cs (Populate): Register the builders we define with
30703 RegisterParameterForBuilder. Test 19 passes again.
30705 * cs-parser.jay (property_declaration): Reference $6 instead
30706 of $$ to get at the location.
30708 (indexer_declaration): Similar stuff.
30710 (attribute): Ditto.
30712 * class.cs (Property): Register parameters for the Get and Set methods
30713 if they exist. Test 23 passes again.
30715 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30716 call to EmitArguments as we are sure there aren't any params arguments.
30717 Test 32 passes again.
30719 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30720 IndexOutOfRangeException.
30722 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30723 Test 33 now passes again.
30725 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30727 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30728 broke a bunch of things. Will have to come up with a better way
30729 of tracking locations.
30731 * statement.cs: Implemented foreach for single dimension arrays.
30733 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30735 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30736 an error. This removes the lookup from the critical path.
30738 * cs-parser.jay: Removed use of temporary_loc, which is completely
30741 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30743 * support.cs (ReflectionParameters.ParameterModifier): Report
30744 whether the argument is a PARAMS argument or not.
30746 * class.cs: Set the attribute `ParamArrayAttribute' on the
30747 parameter argument.
30749 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30750 and cons_param_array_attribute (ConstructorInfo for
30751 ParamArrayAttribute).,
30753 * codegen.cs: Emit the return using the `Return' statement, that
30754 way we can report the error correctly for missing return values.
30756 * class.cs (Method.Emit): Clean up.
30758 * expression.cs (Argument.Resolve): Take another argument: the
30759 location where this argument is used. Notice that this is not
30760 part of the "Argument" class as to reduce the size of the
30761 structure (we know the approximate location anyways).
30763 Test if the argument is a variable-reference, if not, then
30764 complain with a 206.
30766 (Argument.Emit): Emit addresses of variables.
30768 (Argument.FullDesc): Simplify.
30770 (Invocation.DoResolve): Update for Argument.Resolve.
30772 (ElementAccess.DoResolve): ditto.
30774 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30775 method should be virtual, as this method is always virtual.
30777 (NewDelegate.DoResolve): Update for Argument.Resolve.
30779 * class.cs (ConstructorInitializer.DoResolve): ditto.
30781 * attribute.cs (Attribute.Resolve): ditto.
30783 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30785 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30787 * expression.cs (ParameterReference): Drop IStackStorage and implement
30788 IAssignMethod instead.
30790 (LocalVariableReference): ditto.
30792 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30793 IAssignMethod instead.
30795 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30797 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30798 enumerations that are used in heavily used structures derive from
30799 byte in a laughable and pathetic attempt to reduce memory usage.
30800 This is the kind of pre-optimzations that you should not do at
30801 home without adult supervision.
30803 * expression.cs (UnaryMutator): New class, used to handle ++ and
30804 -- separatedly from the other unary operators. Cleans up the
30805 code, and kills the ExpressionStatement dependency in Unary.
30807 (Unary): Removed `method' and `Arguments' from this class, making
30808 it smaller, and moving it all to SimpleCall, so I can reuse this
30809 code in other locations and avoid creating a lot of transient data
30810 strucutres when not required.
30812 * cs-parser.jay: Adjust for new changes.
30814 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30816 * enum.cs (Enum.Populate): If there is a failure during
30819 * cs-parser.jay (opt_enum_base): we used to catch type errors
30820 here, but this is really incorrect. The type error should be
30821 catched during semantic analysis.
30823 2001-12-11 Ravi Pratap <ravi@ximian.com>
30825 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30826 current_local_parameters as expected since I, in my stupidity, had forgotten
30829 * attribute.cs (GetValidPlaces): Fix stupid bug.
30831 * class.cs (Method::Emit): Perform check on applicability of attributes.
30833 (Constructor::Emit): Ditto.
30835 (Field::Emit): Ditto.
30837 (Field.Location): Store location information.
30839 (Property, Event, Indexer, Operator): Ditto.
30841 * cs-parser.jay (field_declaration): Pass in location for each field.
30843 * ../errors/cs0592.cs : Add.
30845 2001-11-12 Ravi Pratap <ravi@ximian.com>
30847 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30849 (InitCoreTypes): Update accordingly.
30851 (RegisterAttrType, LookupAttr): Implement.
30853 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30854 info about the same.
30856 (Resolve): Update to populate the above as necessary.
30858 (Error592): Helper.
30860 (GetValidPlaces): Helper to the above.
30862 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30864 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30866 2001-11-12 Ravi Pratap <ravi@ximian.com>
30868 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30870 * ../errors/cs0617.cs : Add.
30872 2001-11-11 Ravi Pratap <ravi@ximian.com>
30874 * enum.cs (Emit): Rename to Populate to be more consistent with what
30875 we expect it to do and when exactly it is called.
30877 * class.cs, rootcontext.cs : Update accordingly.
30879 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30880 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30882 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30884 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30885 of a fieldinfo using the above, when dealing with a FieldBuilder.
30887 2001-11-10 Ravi Pratap <ravi@ximian.com>
30889 * ../errors/cs0031.cs : Add.
30891 * ../errors/cs1008.cs : Add.
30893 * ../errrors/cs0543.cs : Add.
30895 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30898 (FindMembers): Implement.
30900 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30901 enums and delegates too.
30903 (enum_types): Rename to builder_to_enum.
30905 (delegate_types): Rename to builder_to_delegate.
30907 * delegate.cs (FindMembers): Implement.
30909 2001-11-09 Ravi Pratap <ravi@ximian.com>
30911 * typemanager.cs (IsEnumType): Implement.
30913 * enum.cs (Emit): Re-write parts to account for the underlying type
30914 better and perform checking etc.
30916 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30917 of the underlying type.
30919 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30922 * enum.cs (error31): Helper to report error #31.
30924 * cs-parser.jay (enum_declaration): Store location of each member too.
30926 * enum.cs (member_to_location): New hashtable.
30928 (AddEnumMember): Update location hashtable.
30930 (Emit): Use the location of each member while reporting errors.
30932 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30934 * cs-parser.jay: A for_initializer if is a
30935 local_variable_declaration really ammount to have an implicit
30936 block with the variable declaration and no initializer for for.
30938 * statement.cs (For.Emit): Cope with null initializers.
30940 This fixes the infinite loop on for initializers.
30942 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30944 * enum.cs: More cleanup.
30946 * ecore.cs: Remove dead code.
30948 * class.cs (Property.Emit): More simplification.
30949 (Event.Emit): ditto.
30951 Reworked to have less levels of indentation.
30953 2001-11-08 Ravi Pratap <ravi@ximian.com>
30955 * class.cs (Property): Emit attributes.
30965 * enum.cs (Emit): Ditto.
30967 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30970 * class.cs (Field, Event, etc.): Move attribute generation into the
30971 Emit method everywhere.
30973 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30974 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30975 as we had no way of defining nested enums !
30977 * rootcontext.cs : Adjust code accordingly.
30979 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30981 2001-11-07 Ravi Pratap <ravi@ximian.com>
30983 * expression.cs (EvalConstantExpression): Move into ecore.cs
30985 * enum.cs (Enum): Rename some members and make them public and readonly
30986 according to our convention.
30988 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30991 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30993 (Enum::Emit): Write a simple version for now which doesn't try to compute
30994 expressions. I shall modify this to be more robust in just a while.
30996 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30998 (TypeContainer::CloseType): Create the Enum types too.
31000 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
31002 * expression.cs (EvalConstantExpression): Get rid of completely.
31004 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
31005 user-defined values and other cases.
31007 (IsValidEnumLiteral): Helper function.
31009 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
31010 out there in the case we had a literal FieldExpr.
31012 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
31014 (Literalize): Revamp a bit to take two arguments.
31016 (EnumLiteral): New class which derives from Literal to wrap enum literals.
31018 2001-11-06 Ravi Pratap <ravi@ximian.com>
31020 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
31022 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
31024 (Resolve): Use the above to ensure we have proper initializers.
31026 2001-11-05 Ravi Pratap <ravi@ximian.com>
31028 * expression.cs (Expression::EvalConstantExpression): New method to
31029 evaluate constant expressions.
31031 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
31033 2001-11-07 Miguel de Icaza <miguel@ximian.com>
31035 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
31038 (Binary.ResolveOperator): Handle operator != (object a, object b)
31039 and operator == (object a, object b);
31041 (Binary.DoNumericPromotions): Indicate whether the numeric
31042 promotion was possible.
31044 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
31047 Made the ArrayAccess implement interface IAssignMethod instead of
31048 IStackStore as the order in which arguments are passed reflects
31051 * assign.cs: Instead of using expr.ExprClass to select the way of
31052 assinging, probe for the IStackStore/IAssignMethod interfaces.
31054 * typemanager.cs: Load InitializeArray definition.
31056 * rootcontext.cs (RootContext.MakeStaticData): Used to define
31057 static data that can be used to initialize arrays.
31059 2001-11-05 Miguel de Icaza <miguel@ximian.com>
31061 * expression.cs: Handle operator== and operator!= for booleans.
31063 (Conditioal.Reduce): Implement reducer for the ?: operator.
31065 (Conditional.Resolve): Implement dead code elimination.
31067 (Binary.Resolve): Catch string literals and return a new
31068 concatenated string.
31070 (Unary.Reduce): Implement reduction of unary expressions.
31072 * ecore.cs: Split out the expression core handling here.
31074 (Expression.Reduce): New method used to perform constant folding
31075 and CSE. This is needed to support constant-expressions.
31077 * statement.cs (Statement.EmitBoolExpression): Pass true and false
31078 targets, and optimize for !x.
31080 2001-11-04 Ravi Pratap <ravi@ximian.com>
31082 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
31083 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
31084 set custom atttributes.
31086 * literal.cs (Literal::GetValue): New abstract method to return the actual
31087 value of the literal, cast as an object.
31089 (*Literal): Implement GetValue method.
31091 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
31092 expressions to the arraylist but objects of type Argument.
31094 * class.cs (TypeContainer::Emit): Emit our attributes too.
31096 (Method::Emit, Constructor::Emit): Ditto.
31098 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
31099 to be ignoring earlier.
31101 2001-11-03 Ravi Pratap <ravi@ximian.com>
31103 * attribute.cs (AttributeSection::Define): Implement to do the business
31104 of constructing a CustomAttributeBuilder.
31106 (Attribute): New trivial class. Increases readability of code.
31108 * cs-parser.jay : Update accordingly.
31110 (positional_argument_list, named_argument_list, named_argument): New rules
31112 (attribute_arguments): Use the above so that we are more correct.
31114 2001-11-02 Ravi Pratap <ravi@ximian.com>
31116 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
31117 to perform all checks for a method with a params parameter.
31119 (Invocation::OverloadResolve): Update to use the above method and therefore
31120 cope correctly with params method invocations.
31122 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
31125 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
31126 constructors in our parent too because we can't afford to miss out on
31129 * attribute.cs (AttributeSection): New name for the class Attribute
31131 Other trivial changes to improve readability.
31133 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
31134 use the new class names.
31136 2001-11-01 Ravi Pratap <ravi@ximian.com>
31138 * class.cs (Method::Define): Complete definition for params types too
31140 (Indexer::Define): Ditto.
31142 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
31143 Cope everywhere with a request for info about the array parameter.
31145 2001-11-01 Ravi Pratap <ravi@ximian.com>
31147 * tree.cs (RecordNamespace): Fix up to check for the correct key.
31149 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
31150 local_variable_type to extract the string corresponding to the type.
31152 (local_variable_type): Fixup the action to use the new helper method.
31154 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
31157 * expression.cs : Clean out code which uses the above.
31159 2001-10-31 Ravi Pratap <ravi@ximian.com>
31161 * typemanager.cs (RegisterMethod): Check if we already have an existing key
31162 and bale out if necessary by returning a false.
31164 (RegisterProperty): Ditto.
31166 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
31167 and print out appropriate error messages.
31169 * interface.cs (everywhere): Ditto.
31171 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
31172 location to constructor.
31174 * class.cs (Property, Event, Indexer): Update accordingly.
31176 * ../errors/cs111.cs : Added.
31178 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
31179 of a method, as laid down by the spec.
31181 (Invocation::OverloadResolve): Use the above method.
31183 2001-10-31 Ravi Pratap <ravi@ximian.com>
31185 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
31186 now take a TypeContainer and a Parameters object.
31188 (ParameterData): Modify return type of ParameterModifier method to be
31189 Parameter.Modifier and not a string.
31191 (ReflectionParameters, InternalParameters): Update accordingly.
31193 * expression.cs (Argument::GetParameterModifier): Same here.
31195 * support.cs (InternalParameters::ParameterType): Find a better way of determining
31196 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
31197 symbol in it at all so maybe this is only for now.
31199 2001-10-30 Ravi Pratap <ravi@ximian.com>
31201 * support.cs (InternalParameters): Constructor now takes an extra argument
31202 which is the actual Parameters class.
31204 (ParameterDesc): Update to provide info on ref/out modifiers.
31206 * class.cs (everywhere): Update call to InternalParameters to pass in
31207 the second argument too.
31209 * support.cs (ParameterData): Add ParameterModifier, which is a method
31210 to return the modifier info [ref/out etc]
31212 (InternalParameters, ReflectionParameters): Implement the above.
31214 * expression.cs (Argument::ParameterModifier): Similar function to return
31215 info about the argument's modifiers.
31217 (Invocation::OverloadResolve): Update to take into account matching modifiers
31220 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
31221 a new SetFormalParameters object which we pass to InternalParameters.
31223 2001-10-30 Ravi Pratap <ravi@ximian.com>
31225 * expression.cs (NewArray): Merge into the ArrayCreation class.
31227 2001-10-29 Ravi Pratap <ravi@ximian.com>
31229 * expression.cs (NewArray): Merge classes NewBuiltinArray and
31230 NewUserdefinedArray into one as there wasn't much of a use in having
31233 * expression.cs (Argument): Change field's name to ArgType from Type.
31235 (Type): New readonly property which returns the proper type, taking into
31236 account ref/out modifiers.
31238 (everywhere): Adjust code accordingly for the above.
31240 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
31241 whether we are emitting for a ref or out parameter.
31243 * expression.cs (Argument::Emit): Use the above field to set the state.
31245 (LocalVariableReference::Emit): Update to honour the flag and emit the
31248 * parameter.cs (Attributes): Set the correct flags for ref parameters.
31250 * expression.cs (Argument::FullDesc): New function to provide a full desc.
31252 * support.cs (ParameterData): Add method ParameterDesc to the interface.
31254 (ReflectionParameters, InternalParameters): Implement the above method.
31256 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
31259 (Invocation::FullMethodDesc): Ditto.
31261 2001-10-29 Miguel de Icaza <miguel@ximian.com>
31263 * cs-parser.jay: Add extra production for the second form of array
31266 * expression.cs (ArrayCreation): Update to reflect the above
31269 * Small changes to prepare for Array initialization.
31271 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31273 * typemanager.cs (ImplementsInterface): interface might be null;
31274 Deal with this problem;
31276 Also, we do store negative hits on the cache (null values), so use
31277 this instead of calling t.GetInterfaces on the type everytime.
31279 2001-10-28 Ravi Pratap <ravi@ximian.com>
31281 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31283 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31284 split functionality out into different classes.
31286 (New::FormArrayType): Move into NewBuiltinArray.
31288 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31291 (NewBuiltinArray): New class to handle creation of built-in arrays.
31293 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31294 account creation of one-dimensional arrays.
31296 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31298 (NewUserdefinedArray::DoResolve): Implement.
31300 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31302 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31303 we maintain inside the TypeManager. This is necessary to perform lookups on the
31306 (LookupType): Update to perform GetType on the module builders too.
31308 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31310 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31312 2001-10-23 Ravi Pratap <ravi@ximian.com>
31314 * expression.cs (New::DoResolve): Implement guts of array creation.
31316 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31318 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31320 * expression.cs: Fix bug I introduced lsat night that broke
31323 (Expression.Resolve): Report a 246 error (can not resolve name)
31324 if we find a SimpleName in the stream.
31326 (Expression.ResolveLValue): Ditto.
31328 (Expression.ResolveWithSimpleName): This function is a variant of
31329 ResolveName, this one allows SimpleNames to be returned without a
31330 warning. The only consumer of SimpleNames is MemberAccess
31332 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31334 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31335 might arrive here. I have my doubts that this is correct.
31337 * statement.cs (Lock): Implement lock statement.
31339 * cs-parser.jay: Small fixes to support `lock' and `using'
31341 * cs-tokenizer.cs: Remove extra space
31343 * driver.cs: New flag --checked, allows to turn on integer math
31346 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31347 Threading.Monitor.Exit
31349 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31351 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31352 Expression Class to be IndexerAccess.
31354 Notice that Indexer::DoResolve sets the eclass to Value.
31356 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31358 * class.cs (TypeContainer::Emit): Emit code for indexers.
31360 * assign.cs (IAssignMethod): New interface implemented by Indexers
31361 and Properties for handling assignment.
31363 (Assign::Emit): Simplify and reuse code.
31365 * expression.cs (IndexerAccess, PropertyExpr): Implement
31366 IAssignMethod, clean up old code.
31368 2001-10-22 Ravi Pratap <ravi@ximian.com>
31370 * typemanager.cs (ImplementsInterface): New method to determine if a type
31371 implements a given interface. Provides a nice cache too.
31373 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31376 (ConvertReferenceExplicit): Ditto.
31378 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31379 various methods, with correct names etc.
31381 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31382 Operator.UnaryNegation.
31384 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31385 we have a unary plus or minus operator.
31387 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31390 * everywhere : update accordingly.
31392 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31395 * class.cs (Method::Define): For the case where we are implementing a method
31396 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31397 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31399 2001-10-21 Ravi Pratap <ravi@ximian.com>
31401 * interface.cs (FindMembers): Implement to work around S.R.E
31404 * typemanager.cs (IsInterfaceType): Implement.
31406 (FindMembers): Update to handle interface types too.
31408 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31409 use IsAssignableFrom as that is not correct - it doesn't work.
31411 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31412 and accordingly override EmitStatement.
31414 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31415 using the correct logic :-)
31417 2001-10-19 Ravi Pratap <ravi@ximian.com>
31419 * ../errors/cs-11.cs : Add to demonstrate error -11
31421 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31423 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31424 then pass this as a hint to ResolveLValue.
31426 * expression.cs (FieldExpr): Add Location information
31428 (FieldExpr::LValueResolve): Report assignment to readonly
31431 (Expression::ExprClassFromMemberInfo): Pass location information.
31433 (Expression::ResolveLValue): Add new method that resolves an
31436 (Expression::DoResolveLValue): Default invocation calls
31439 (Indexers): New class used to keep track of indexers in a given
31442 (IStackStore): Renamed from LValue, as it did not really describe
31443 what this did. Also ResolveLValue is gone from this interface and
31444 now is part of Expression.
31446 (ElementAccess): Depending on the element access type
31448 * typemanager.cs: Add `indexer_name_type' as a Core type
31449 (System.Runtime.CompilerServices.IndexerNameAttribute)
31451 * statement.cs (Goto): Take a location.
31453 2001-10-18 Ravi Pratap <ravi@ximian.com>
31455 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31456 if two delegates are compatible.
31458 (NewDelegate::DoResolve): Update to take care of the case when
31459 we instantiate a delegate from another delegate.
31461 * typemanager.cs (FindMembers): Don't even try to look up members
31462 of Delegate types for now.
31464 2001-10-18 Ravi Pratap <ravi@ximian.com>
31466 * delegate.cs (NewDelegate): New class to take care of delegate
31469 * expression.cs (New): Split the delegate related code out into
31470 the NewDelegate class.
31472 * delegate.cs (DelegateInvocation): New class to handle delegate
31475 * expression.cs (Invocation): Split out delegate related code into
31476 the DelegateInvocation class.
31478 2001-10-17 Ravi Pratap <ravi@ximian.com>
31480 * expression.cs (New::DoResolve): Implement delegate creation fully
31481 and according to the spec.
31483 (New::DoEmit): Update to handle delegates differently.
31485 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31486 because of which we were printing out arguments in reverse order !
31488 * delegate.cs (VerifyMethod): Implement to check if the given method
31489 matches the delegate.
31491 (FullDelegateDesc): Implement.
31493 (VerifyApplicability): Implement.
31495 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31496 delegate invocations too.
31498 (Invocation::Emit): Ditto.
31500 * ../errors/cs1593.cs : Added.
31502 * ../errors/cs1594.cs : Added.
31504 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31506 2001-10-16 Ravi Pratap <ravi@ximian.com>
31508 * typemanager.cs (intptr_type): Core type for System.IntPtr
31510 (InitCoreTypes): Update for the same.
31512 (iasyncresult_type, asynccallback_type): Ditto.
31514 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31517 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31520 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31521 the builders for the 4 members of a delegate type :-)
31523 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31526 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31528 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31530 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31532 * statement.cs (Break::Emit): Implement.
31533 (Continue::Emit): Implement.
31535 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31536 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31537 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31538 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31541 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31542 properties that track the label for the current loop (begin of the
31543 loop and end of the loop).
31545 2001-10-15 Ravi Pratap <ravi@ximian.com>
31547 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31548 use of emitting anything at all.
31550 * class.cs, rootcontext.cs : Get rid of calls to the same.
31552 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31554 (Populate): Define the constructor correctly and set the implementation
31557 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31560 (AddDelegateType): Implement.
31562 (IsDelegateType): Implement helper method.
31564 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31566 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31567 and accordingly handle it.
31569 * delegate.cs (Populate): Take TypeContainer argument.
31570 Implement bits to define the Invoke method. However, I still haven't figured out
31571 how to take care of the native int bit :-(
31573 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31574 Qualify the name of the delegate, not its return type !
31576 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31579 (StandardConversionExists): Checking for array types turns out to be recursive.
31581 (ConvertReferenceExplicit): Implement array conversion.
31583 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31585 2001-10-12 Ravi Pratap <ravi@ximian.com>
31587 * cs-parser.jay (delegate_declaration): Store the fully qualified
31588 name as it is a type declaration.
31590 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31593 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31594 as TypeContainer::DefineType.
31596 (Populate): Method in which all the definition of the various methods (Invoke)
31599 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31602 (CloseDelegate): Finally creates the delegate.
31604 * class.cs (TypeContainer::DefineType): Update to define delegates.
31605 (Populate, Emit and CloseType): Do the same thing here too.
31607 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31608 delegates in all these operations.
31610 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31612 * expression.cs: LocalTemporary: a new expression used to
31613 reference a temporary that has been created.
31615 * assign.cs: Handle PropertyAccess back here, so that we can
31616 provide the proper semantic access to properties.
31618 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31619 a few more explicit conversions.
31621 * modifiers.cs: `NEW' modifier maps to HideBySig.
31623 * expression.cs (PropertyExpr): Make this into an
31624 ExpressionStatement, and support the EmitStatement code path.
31626 Perform get/set error checking, clean up the interface.
31628 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31629 them into toplevel access objects.
31631 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31633 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31636 * typemanager.cs: Keep track here of our PropertyBuilders again to
31637 work around lameness in SRE.
31639 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31641 * expression.cs (LValue::LValueResolve): New method in the
31642 interface, used to perform a second resolution pass for LValues.
31644 (This::DoResolve): Catch the use of this in static methods.
31646 (This::LValueResolve): Implement.
31648 (This::Store): Remove warning, assigning to `this' in structures
31651 (Invocation::Emit): Deal with invocation of
31652 methods on value types. We need to pass the address to structure
31653 methods rather than the object itself. (The equivalent code to
31654 emit "this" for structures leaves the entire structure on the
31655 stack instead of a pointer to it).
31657 (ParameterReference::DoResolve): Compute the real index for the
31658 argument based on whether the method takes or not a `this' pointer
31659 (ie, the method is static).
31661 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31662 value types returned from functions when we need to invoke a
31663 method on the sturcture.
31666 2001-10-11 Ravi Pratap <ravi@ximian.com>
31668 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31669 defining the type in the Modulebuilder or Typebuilder. This is to take
31670 care of nested types which need to be defined on the TypeBuilder using
31671 DefineNestedMethod.
31673 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31674 methods in RootContext, only ported to be part of TypeContainer.
31676 (TypeContainer::GetInterfaceOrClass): Ditto.
31678 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31680 * interface.cs (Interface::DefineInterface): New method. Does exactly
31681 what RootContext.CreateInterface did earlier, only it takes care of nested types
31684 (Interface::GetInterfaces): Move from RootContext here and port.
31686 (Interface::GetInterfaceByName): Same here.
31688 * rootcontext.cs (ResolveTree): Re-write.
31690 (PopulateTypes): Re-write.
31692 * class.cs (TypeContainer::Populate): Populate nested types too.
31693 (TypeContainer::Emit): Emit nested members too.
31695 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31696 instead just use the name argument passed in as it is already fully
31699 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31700 to TypeContainer mapping to see if a type is user-defined.
31702 * class.cs (TypeContainer::CloseType): Implement.
31704 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31705 the default constructor.
31707 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31710 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31712 * interface.cs (CloseType): Create the type here.
31714 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31717 Remove all the methods which are now in TypeContainer.
31719 2001-10-10 Ravi Pratap <ravi@ximian.com>
31721 * delegate.cs (Define): Re-write bits to define the delegate
31724 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31726 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31728 * expression.cs (ImplicitReferenceConversion): handle null as well
31729 as a source to convert to any reference type.
31731 * statement.cs (Return): Perform any implicit conversions to
31732 expected return type.
31734 Validate use of return statement.
31736 * codegen.cs (EmitContext): Pass the expected return type here.
31738 * class.cs (Method, Constructor, Property): Pass expected return
31739 type to EmitContext.
31741 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31743 * expression.cs: Make DoResolve take an EmitContext instead of a
31746 Replaced `l' and `location' for `loc', for consistency.
31748 (Error, Warning): Remove unneeded Tc argument.
31750 * assign.cs, literal.cs, constant.cs: Update to new calling
31753 * codegen.cs: EmitContext now contains a flag indicating whether
31754 code is being generated in a static method or not.
31756 * cs-parser.jay: DecomposeQI, new function that replaces the old
31757 QualifiedIdentifier. Now we always decompose the assembled
31758 strings from qualified_identifier productions into a group of
31761 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31763 * rootcontext.cs: Deal with field-less struct types correctly now
31764 by passing the size option to Define Type.
31766 * class.cs: Removed hack that created one static field.
31768 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31770 * statement.cs: Moved most of the code generation here.
31772 2001-10-09 Ravi Pratap <ravi@ximian.com>
31774 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31777 (ElementAccess): Remove useless bits for now - keep checks as the spec
31780 2001-10-08 Ravi Pratap <ravi@ximian.com>
31782 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31783 and start performing checks according to the spec.
31785 2001-10-07 Ravi Pratap <ravi@ximian.com>
31787 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31788 rank_specifiers instead.
31790 (rank_specifiers): Change the order in which the rank specifiers are stored
31792 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31794 * expression.cs (ElementAccess): Implement the LValue interface too.
31796 2001-10-06 Ravi Pratap <ravi@ximian.com>
31798 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31799 except that user defined conversions are not included.
31801 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31802 perform the conversion of the return type, if necessary.
31804 (New::DoResolve): Check whether we are creating an array or an object
31805 and accordingly do the needful.
31807 (New::Emit): Same here.
31809 (New::DoResolve): Implement guts of array creation.
31811 (New::FormLookupType): Helper function.
31813 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31815 * codegen.cs: Removed most of the code generation here, and move the
31816 corresponding code generation bits to the statement classes.
31818 Added support for try/catch/finalize and throw.
31820 * cs-parser.jay: Added support for try/catch/finalize.
31822 * class.cs: Catch static methods having the flags override,
31823 virtual or abstract.
31825 * expression.cs (UserCast): This user cast was not really doing
31826 what it was supposed to do. Which is to be born in fully resolved
31827 state. Parts of the resolution were being performed at Emit time!
31831 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31833 * expression.cs: Implicity convert the result from UserCast.
31835 2001-10-05 Ravi Pratap <ravi@ximian.com>
31837 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31838 prevented it from working correctly.
31840 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31841 merely ConvertImplicit.
31843 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31845 * typemanager.cs: Make the LookupTypeContainer function static,
31846 and not per-instance.
31848 * class.cs: Make static FindMembers (the one that takes a Type
31851 * codegen.cs: Add EmitForeach here.
31853 * cs-parser.jay: Make foreach a toplevel object instead of the
31854 inline expansion, as we need to perform semantic analysis on it.
31856 2001-10-05 Ravi Pratap <ravi@ximian.com>
31858 * expression.cs (Expression::ImplicitUserConversion): Rename to
31859 UserDefinedConversion.
31861 (Expression::UserDefinedConversion): Take an extra argument specifying
31862 whether we look for explicit user conversions too.
31864 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31866 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31868 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31869 with the appropriate arguments.
31871 * cs-parser.jay (cast_expression): Record location too.
31873 * expression.cs (Cast): Record location info.
31875 (Expression::ConvertExplicit): Take location argument.
31877 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31878 to determine if we are doing explicit conversions.
31880 (UserCast::Emit): Update accordingly.
31882 (Expression::ConvertExplicit): Report an error if everything fails.
31884 * ../errors/cs0030.cs : Add.
31886 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31888 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31889 virtual and newslot bits.
31891 * class.cs (TypeContainer::RegisterRequiredImplementations):
31892 Record methods we need.
31894 (TypeContainer::MakeKey): Helper function to make keys for
31895 MethodBases, since the Methodbase key is useless.
31897 (TypeContainer::Populate): Call RegisterRequiredImplementations
31898 before defining the methods.
31900 Create a mapping for method_builders_to_methods ahead of time
31901 instead of inside a tight loop.
31903 (::RequireMethods): Accept an object as the data to set into the
31904 hashtable so we can report interface vs abstract method mismatch.
31906 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31908 * report.cs: Make all of it static.
31910 * rootcontext.cs: Drop object_type and value_type computations, as
31911 we have those in the TypeManager anyways.
31913 Drop report instance variable too, now it is a global.
31915 * driver.cs: Use try/catch on command line handling.
31917 Add --probe option to debug the error reporting system with a test
31920 * report.cs: Add support for exiting program when a probe
31921 condition is reached.
31923 2001-10-03 Ravi Pratap <ravi@ximian.com>
31925 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31926 we do a forcible conversion regardless of type, to check if
31927 ForceConversion returns a null.
31929 (Binary::error19): Use location to report error.
31931 (Unary::error23): Use location here too.
31933 * ../errors/cs0019.cs : Check in.
31935 * ../errors/cs0023.cs : Check in.
31937 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31938 case of a non-null MethodInfo object with a length of 0 !
31940 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31941 an applicable member - according to the spec :-)
31942 Also fix logic to find members in base types.
31944 (Unary::ResolveOperator): Same here.
31946 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31947 as I was getting thoroughly confused between this and error19 :-)
31949 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31950 (::FindMostEncompassedType): Implement.
31951 (::FindMostEncompassingType): Implement.
31952 (::StandardConversionExists): Implement.
31954 (UserImplicitCast): Re-vamp. We now need info about most specific
31955 source and target types so that we can do the necessary conversions.
31957 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31958 mathematical union with no duplicates.
31960 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31962 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31963 in order from base classes to child classes, so that we can in
31964 child classes look up in our parent for method names and
31965 attributes (required for handling abstract, virtual, new, override
31966 constructs: we need to instrospect our base class, and if we dont
31967 populate the classes in order, the introspection might be
31968 incorrect. For example, a method could query its parent before
31969 the parent has any methods and would determine that the parent has
31970 no abstract methods (while it could have had them)).
31972 (RootContext::CreateType): Record the order in which we define the
31975 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31977 * class.cs (TypeContainer::Populate): Also method definitions can
31978 fail now, keep track of this.
31980 (TypeContainer::FindMembers): Implement support for
31981 DeclaredOnly/noDeclaredOnly flag.
31983 (Constructor::Emit) Return the ConstructorBuilder.
31985 (Method::Emit) Return the MethodBuilder.
31986 Check for abstract or virtual methods to be public.
31988 * rootcontext.cs (RootContext::CreateType): Register all the
31989 abstract methods required for the class to be complete and the
31990 interface methods that must be implemented.
31992 * cs-parser.jay: Report error 501 (method requires body if it is
31993 not marked abstract or extern).
31995 * expression.cs (TypeOf::Emit): Implement.
31997 * typemanager.cs: runtime_handle_type, new global type.
31999 * class.cs (Property::Emit): Generate code for properties.
32001 2001-10-02 Ravi Pratap <ravi@ximian.com>
32003 * expression.cs (Unary::ResolveOperator): Find operators on base type
32004 too - we now conform exactly to the spec.
32006 (Binary::ResolveOperator): Same here.
32008 * class.cs (Operator::Define): Fix minor quirk in the tests.
32010 * ../errors/cs0215.cs : Added.
32012 * ../errors/cs0556.cs : Added.
32014 * ../errors/cs0555.cs : Added.
32016 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32018 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
32019 single integer which is really efficient
32021 2001-10-01 Ravi Pratap <ravi@ximian.com>
32023 * expression.cs (Expression::ImplicitUserConversion): Use location
32024 even in the case when we are examining True operators.
32026 * class.cs (Operator::Define): Perform extensive checks to conform
32027 with the rules for operator overloading in the spec.
32029 * expression.cs (Expression::ImplicitReferenceConversion): Implement
32030 some of the other conversions mentioned in the spec.
32032 * typemanager.cs (array_type): New static member for the System.Array built-in
32035 (cloneable_interface): For System.ICloneable interface.
32037 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
32038 we start resolving the tree and populating types.
32040 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
32042 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32044 * expression.cs (Expression::ExprClassFromMemberInfo,
32045 Expression::Literalize): Create literal expressions from
32046 FieldInfos which are literals.
32048 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
32049 type casts, because they were wrong. The test suite in tests
32052 (ImplicitNumericConversion): ushort to ulong requires a widening
32055 Int32 constant to long requires widening cast as well.
32057 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
32058 for integers because the type on the stack is not i4.
32060 2001-09-30 Miguel de Icaza <miguel@ximian.com>
32062 * expression.cs (report118): require location argument.
32064 * parameter.cs: Do not dereference potential null value.
32066 * class.cs: Catch methods that lack the `new' keyword when
32067 overriding a name. Report warnings when `new' is used without
32068 anything being there to override.
32070 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
32072 * class.cs: Only add constructor to hashtable if it is non-null
32073 (as now constructors can fail on define).
32075 (TypeManager, Class, Struct): Take location arguments.
32077 Catch field instance initialization in structs as errors.
32079 accepting_filter: a new filter for FindMembers that is static so
32080 that we dont create an instance per invocation.
32082 (Constructor::Define): Catch errors where a struct constructor is
32085 * cs-parser.jay: Pass location information for various new
32088 * delegate.cs (Delegate): take a location argument.
32090 * driver.cs: Do not call EmitCode if there were problesm in the
32091 Definition of the types, as many Builders wont be there.
32093 * decl.cs (Decl::Decl): Require a location argument.
32095 * cs-tokenizer.cs: Handle properly hex constants that can not fit
32096 into integers, and find the most appropiate integer for it.
32098 * literal.cs: Implement ULongLiteral.
32100 * rootcontext.cs: Provide better information about the location of
32101 failure when CreateType fails.
32103 2001-09-29 Miguel de Icaza <miguel@ximian.com>
32105 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
32108 * expression.cs (Binary::CheckShiftArguments): Add missing type
32110 (Binary::ResolveOperator): Add type to the logical and and logical
32111 or, Bitwise And/Or and Exclusive Or code paths, it was missing
32114 (Binary::DoNumericPromotions): In the case where either argument
32115 is ulong (and most signed types combined with ulong cause an
32116 error) perform implicit integer constant conversions as well.
32118 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32120 * expression.cs (UserImplicitCast): Method should always be
32122 (Invocation::BetterConversion): Simplified test for IntLiteral.
32124 (Expression::ImplicitNumericConversion): Split this routine out.
32125 Put the code that performs implicit constant integer conversions
32128 (Expression::Resolve): Become a wrapper around DoResolve so we can
32129 check eclass and type being set after resolve.
32131 (Invocation::Badness): Remove this dead function
32133 (Binary::ResolveOperator): Do not compute the expensive argumnets
32134 unless we have a union for it.
32136 (Probe::Emit): Is needs to do an isinst and then
32137 compare against null.
32139 (::CanConvert): Added Location argument. If the Location argument
32140 is null (Location.Null), then we do not report errors. This is
32141 used by the `probe' mechanism of the Explicit conversion. We do
32142 not want to generate an error for something that the user
32143 explicitly requested to be casted. But the pipeline for an
32144 explicit cast first tests for potential implicit casts.
32146 So for now, if the Location is null, it means `Probe only' to
32147 avoid adding another argument. Might have to revise this
32150 (ClassCast): New class used to type cast objects into arbitrary
32151 classes (used in Explicit Reference Conversions).
32153 Implement `as' as well.
32155 Reverted all the patches from Ravi below: they were broken:
32157 * The use of `level' as a mechanism to stop recursive
32158 invocations is wrong. That was there just to catch the
32159 bug with a strack trace but not as a way of addressing
32162 To fix the problem we have to *understand* what is going
32163 on and the interactions and come up with a plan, not
32164 just get things going.
32166 * The use of the type conversion cache that I proposed
32167 last night had an open topic: How does this work across
32168 protection domains. A user defined conversion might not
32169 be public in the location where we are applying the
32170 conversion, a different conversion might be selected
32171 (ie, private A->B (better) but public B->A (worse),
32172 inside A, A->B applies, but outside it, B->A will
32175 * On top of that (ie, even if the above is solved),
32176 conversions in a cache need to be abstract. Ie, `To
32177 convert from an Int to a Short use an OpcodeCast', not
32178 `To convert from an Int to a Short use the OpcodeCast on
32179 the variable 5' (which is what this patch was doing).
32181 2001-09-28 Ravi Pratap <ravi@ximian.com>
32183 * expression.cs (Invocation::ConversionExists): Re-write to use
32184 the conversion cache
32186 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
32187 cache all conversions done, not just user-defined ones.
32189 (Invocation::BetterConversion): The real culprit. Use ConversionExists
32190 to determine if a conversion exists instead of acutually trying to
32191 perform the conversion. It's faster too.
32193 (Expression::ConvertExplicit): Modify to use ConversionExists to check
32194 and only then attempt the implicit conversion.
32196 2001-09-28 Ravi Pratap <ravi@ximian.com>
32198 * expression.cs (ConvertImplicit): Use a cache for conversions
32199 already found. Check level of recursion and bail out if necessary.
32201 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32203 * typemanager.cs (string_concat_string_string, string_concat_object_object):
32204 Export standard methods that we expect for string operations.
32206 * statement.cs (Block::UsageWarning): Track usage of variables and
32207 report the errors for not used variables.
32209 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
32212 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32214 * codegen.cs: remove unnneded code
32216 * expression.cs: Removed BuiltinTypeAccess class
32218 Fix the order in which implicit conversions are
32221 The previous fixed dropped support for boxed conversions (adding a
32222 test to the test suite now)
32224 (UserImplicitCast::CanConvert): Remove test for source being null,
32225 that code is broken. We should not feed a null to begin with, if
32226 we do, then we should track the bug where the problem originates
32227 and not try to cover it up here.
32229 Return a resolved expression of type UserImplicitCast on success
32230 rather than true/false. Ravi: this is what I was talking about,
32231 the pattern is to use a static method as a "constructor" for
32234 Also, do not create arguments until the very last minute,
32235 otherwise we always create the arguments even for lookups that
32236 will never be performed.
32238 (UserImplicitCast::Resolve): Eliminate, objects of type
32239 UserImplicitCast are born in a fully resolved state.
32241 * typemanager.cs (InitCoreTypes): Init also value_type
32242 (System.ValueType).
32244 * expression.cs (Cast::Resolve): First resolve the child expression.
32246 (LValue): Add new method AddressOf to be used by
32249 Change the argument of Store to take an EmitContext instead of an
32250 ILGenerator, because things like FieldExpr need to be able to call
32251 their children expression to generate the instance code.
32253 (Expression::Error, Expression::Warning): Sugar functions for
32256 (Expression::MemberLookup): Accept a TypeContainer instead of a
32257 Report as the first argument.
32259 (Expression::ResolvePrimary): Killed. I still want to improve
32260 this as currently the code is just not right.
32262 (Expression::ResolveMemberAccess): Simplify, but it is still
32265 (Unary::Resolve): Catch errors in AddressOf operators.
32267 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
32268 index to a byte for the short-version, or the compiler will choose
32269 the wrong Emit call, which generates the wrong data.
32271 (ParameterReference::Emit, ::Store): same.
32273 (FieldExpr::AddressOf): Implement.
32275 * typemanager.cs: TypeManager: made public variable instead of
32278 * driver.cs: document --fatal.
32280 * report.cs (ErrorMessage, WarningMessage): new names for the old
32281 Error and Warning classes.
32283 * cs-parser.jay (member_access): Turn built-in access to types
32284 into a normal simplename
32286 2001-09-27 Ravi Pratap <ravi@ximian.com>
32288 * expression.cs (Invocation::BetterConversion): Fix to cope
32289 with q being null, since this was introducing a bug.
32291 * expression.cs (ConvertImplicit): Do built-in conversions first.
32293 2001-09-27 Ravi Pratap <ravi@ximian.com>
32295 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32297 2001-09-27 Ravi Pratap <ravi@ximian.com>
32299 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32300 I had introduced long ago (what's new ?).
32302 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32303 the work of all the checking.
32304 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32305 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32307 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32308 that is the right way.
32310 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32311 overloading resolution. Use everywhere instead of cutting and pasting code.
32313 (Binary::ResolveOperator): Use MakeUnionSet.
32315 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32316 we have to convert to bool types. Not complete yet.
32318 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32320 * typemanager.cs (TypeManager::CSharpName): support ushort.
32322 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32323 to provide an expression that performsn an implicit constant int
32324 conversion (section 6.1.6).
32325 (Expression::ConvertImplicitRequired): Reworked to include
32326 implicit constant expression conversions.
32328 (Expression::ConvertNumericExplicit): Finished.
32330 (Invocation::Emit): If InstanceExpression is null, then it means
32331 that we perform a call on this.
32333 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32335 * expression.cs (Unary::Emit): Remove some dead code.
32336 (Probe): Implement Resolve and Emit for `is'.
32337 (Expression::ConvertImplicitRequired): Attempt to do constant
32338 expression conversions here. Maybe should be moved to
32339 ConvertImplicit, but I am not sure.
32340 (Expression::ImplicitLongConstantConversionPossible,
32341 Expression::ImplicitIntConstantConversionPossible): New functions
32342 that tell whether is it possible to apply an implicit constant
32343 expression conversion.
32345 (ConvertNumericExplicit): Started work on explicit numeric
32348 * cs-parser.jay: Update operator constants.
32350 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32351 (Parameters::GetSignature): Hook up VerifyArgs here.
32352 (Parameters::VerifyArgs): Verifies that no two arguments have the
32355 * class.cs (Operator): Update the operator names to reflect the
32356 ones that the spec expects (as we are just stringizing the
32359 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32360 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32361 previous usage did only work for our methods.
32362 (Expression::ConvertImplicit): Handle decimal implicit numeric
32363 conversions as well.
32364 (Expression::InternalTypeConstructor): Used to invoke constructors
32365 on internal types for default promotions.
32367 (Unary::Emit): Implement special handling for the pre/post
32368 increment/decrement for overloaded operators, as they need to have
32369 the same semantics as the other operators.
32371 (Binary::ResolveOperator): ditto.
32372 (Invocation::ConversionExists): ditto.
32373 (UserImplicitCast::Resolve): ditto.
32375 2001-09-26 Ravi Pratap <ravi@ximian.com>
32377 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32378 operator, return after emitting body. Regression tests pass again !
32380 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32381 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32382 (Invocation::OverloadResolve): Ditto.
32383 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32385 * everywhere : update calls to the above methods accordingly.
32387 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32389 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32391 * expression.cs (ExpressionStatement): New base class used for
32392 expressions that can appear in statements, so that we can provide
32393 an alternate path to generate expression that do not leave a value
32396 (Expression::Emit, and all the derivatives): We no longer return
32397 whether a value is left on the stack or not. Every expression
32398 after being emitted leaves a single value on the stack.
32400 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32401 facilties of ExpressionStatement if possible.
32403 * cs-parser.jay: Update statement_expression.
32405 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32407 * driver.cs: Change the wording of message
32409 2001-09-25 Ravi Pratap <ravi@ximian.com>
32411 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32412 the type of the expression to the return type of the method if
32413 we have an overloaded operator match ! The regression tests pass again !
32414 (Unary::ResolveOperator): Ditto.
32416 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32417 to find "op_Implicit", not "implicit" ;-)
32418 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32419 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32421 * everywhere : Correct calls to the above accordingly.
32423 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32424 (ConvertImplicit): Do user-defined conversion if it exists.
32426 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32428 * assign.cs: track location.
32429 (Resolve): Use implicit conversions on assignment.
32431 * literal.cs: Oops. Not good, Emit of short access values should
32432 pass (Bytes) or the wrong argument will be selected.
32434 * expression.cs (Unary::Emit): Emit code for -expr.
32436 (Unary::ResolveOperator): Handle `Substract' for non-constants
32437 (substract from zero from the non-constants).
32438 Deal with Doubles as well.
32440 (Expression::ConvertImplicitRequired): New routine that reports an
32441 error if no implicit conversion exists.
32443 (Invocation::OverloadResolve): Store the converted implicit
32444 expressions if we make them
32446 2001-09-24 Ravi Pratap <ravi@ximian.com>
32448 * class.cs (ConstructorInitializer): Take a Location argument.
32449 (ConstructorBaseInitializer): Same here.
32450 (ConstructorThisInitializer): Same here.
32452 * cs-parser.jay : Update all calls accordingly.
32454 * expression.cs (Unary, Binary, New): Take location argument.
32455 Update accordingly everywhere.
32457 * cs-parser.jay : Update all calls to the above to take a location
32460 * class.cs : Ditto.
32462 2001-09-24 Ravi Pratap <ravi@ximian.com>
32464 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32465 (Invocation::BetterConversion): Same here
32466 (Invocation::ConversionExists): Ditto.
32468 (Invocation::ConversionExists): Implement.
32470 2001-09-22 Ravi Pratap <ravi@ximian.com>
32472 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32473 Also take an additional TypeContainer argument.
32475 * All over : Pass in TypeContainer as argument to OverloadResolve.
32477 * typemanager.cs (CSharpName): Update to check for the string type and return
32480 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32483 2001-09-21 Ravi Pratap <ravi@ximian.com>
32485 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32486 (Invocation::BetterFunction): Implement.
32487 (Invocation::BetterConversion): Implement.
32488 (Invocation::ConversionExists): Skeleton, no implementation yet.
32490 Okay, things work fine !
32492 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32494 * typemanager.cs: declare and load enum_type, delegate_type and
32497 * expression.cs (Expression::Emit): Now emit returns a value that
32498 tells whether a value is left on the stack or not. This strategy
32499 might be reveted tomorrow with a mechanism that would address
32500 multiple assignments.
32501 (Expression::report118): Utility routine to report mismatches on
32504 (Unary::Report23): Report impossible type/operator combination
32507 (Unary::IsIncrementableNumber): Whether the type can be
32508 incremented or decremented with add.
32509 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32511 (Unary::ResolveOperator): Implement ++, !, ~,
32513 (Invocation::Emit): Deal with new Emit convetion.
32515 * All Expression derivatives: Updated their Emit method to return
32516 whether they leave values on the stack or not.
32518 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32519 stack for expressions that are statements.
32521 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32523 * expression.cs (LValue): New interface. Must be implemented by
32525 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32528 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32529 interface for generating code, simplifies the code.
32531 2001-09-20 Ravi Pratap <ravi@ximian.com>
32533 * expression.cs (everywhere): Comment out return statements in ::Resolve
32534 methods to avoid the warnings.
32536 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32538 * driver.cs (parse): Report error 2001 if we can not open the
32541 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32544 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32547 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32548 otherwise nested blocks end up with the same index.
32550 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32552 * expression.cs: Instead of having FIXMEs in the Resolve
32553 functions, throw exceptions so it is obvious that we are facing a
32556 * cs-parser.jay (invocation_expression): Pass Location information.
32558 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32559 Use a basename for those routines because .NET does not like paths
32562 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32565 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32567 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32568 are loading the correct data types (throws an exception if not).
32569 (TypeManager::InitCoreTypes): Use CoreLookupType
32571 * expression.cs (Unary::ResolveOperator): return the child
32572 expression for expressions which are just +expr.
32573 (Unary::ResolveOperator): Return negative literals for -LITERAL
32574 expressions (otherwise they are Unary {Literal}).
32575 (Invocation::Badness): Take into account `Implicit constant
32576 expression conversions'.
32578 * literal.cs (LongLiteral): Implement long literal class.
32579 (IntLiteral): export the `Value' of the intliteral.
32581 2001-09-19 Ravi Pratap <ravi@ximian.com>
32583 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32585 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32586 instead of 'Operator'
32588 * expression.cs (Binary::ResolveOperator): Update accordingly.
32589 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32592 * cs-parser.jay (unary_expression): Update to use the new names.
32594 * gen-treedump.cs (GetUnary): Same here.
32596 * expression.cs (Unary::Resolve): Implement.
32597 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32598 operators are found instead of making noise ;-)
32599 (Unary::ResolveOperator): New method to do precisely the same thing which
32600 Binary::ResolveOperator does for Binary expressions.
32601 (Unary.method, .Arguments): Add.
32602 (Unary::OperName): Implement.
32603 (Unary::ForceConversion): Copy and Paste !
32605 * class.cs (Operator::Define): Fix a small bug for the case when we have
32608 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32609 for the inbuilt operators. Only overloading works for now ;-)
32611 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32613 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32614 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32616 * expression.cs (This::Emit): Implement.
32617 (This::Resolve): Implement.
32618 (TypeOf:Resolve): Implement.
32619 (Expression::ResolveSimpleName): Add an implicit this to instance
32621 (MemberAccess::Resolve): Deal with Parameters and Fields.
32622 Bind instance variable to Field expressions.
32623 (FieldExpr::Instance): New field used to track the expression that
32624 represents the object instance.
32625 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32627 (FieldExpr::Emit): Implement.
32629 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32630 the last instruction contains a return opcode to avoid generating
32631 the last `ret' instruction (this generates correct code, and it is
32632 nice to pass the peverify output).
32634 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32635 initializer for static and instance variables.
32636 (Constructor::Emit): Allow initializer to be null in the case of
32637 static constructors. Only emit initializer for instance
32640 (TypeContainer::FindMembers): Return a null array if there are no
32643 Also fix the code for the MemberTypes.Method branch, as it was not
32644 scanning that for operators (or tried to access null variables before).
32646 * assign.cs (Assign::Emit): Handle instance and static fields.
32650 * driver.cs: Stop compilation if there are parse errors.
32652 * cs-parser.jay (constructor_declaration): Provide default base
32653 initializer for non-static constructors.
32654 (constructor_declarator): Do not provide a default base
32655 initializers if none was specified.
32656 Catch the fact that constructors should not have parameters.
32658 * class.cs: Do not emit parent class initializers for static
32659 constructors, that should be flagged as an error.
32661 2001-09-18 Ravi Pratap <ravi@ximian.com>
32663 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32664 Move back code into TypeContainer::Populate.
32666 2001-09-18 Ravi Pratap <ravi@ximian.com>
32668 * class.cs (TypeContainer::AddConstructor): Fix the check to
32669 compare against Name, not Basename.
32670 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32672 * cs-parser.jay : Update accordingly.
32674 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32675 for methods, don't forget to look into the operators too.
32676 (RegisterMethodBuilder): Helper method to take care of this for
32677 methods, constructors and operators.
32678 (Operator::Define): Completely revamp.
32679 (Operator.OperatorMethod, MethodName): New fields.
32680 (TypeContainer::Populate): Move the registering of builders into
32681 RegisterMethodBuilder.
32682 (Operator::Emit): Re-write.
32684 * expression.cs (Binary::Emit): Comment out code path to emit method
32685 invocation stuff for the case when we have a user defined operator. I am
32686 just not able to get it right !
32688 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32690 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32693 (Expression::MemberLookup): Provide a version that allows to
32694 specify the MemberTypes and BindingFlags.
32696 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32697 so it was not fetching variable information from outer blocks.
32699 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32700 Beforefieldinit as it was buggy.
32702 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32703 that Ravi put here.
32705 * class.cs (Constructor::Emit): Only emit if block is not null.
32706 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32707 deal with this by semantically definining it as if the user had
32710 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32711 constructors as we now "emit" them at a higher level.
32713 (TypeContainer::DefineDefaultConstructor): Used to define the
32714 default constructors if none was provided.
32716 (ConstructorInitializer): Add methods Resolve and Emit.
32718 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32720 2001-09-17 Ravi Pratap <ravi@ximian.com>
32722 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32723 the default constructor builder with our hashtable for methodbuilders
32726 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32727 and argument_count is 0 in which case we have a match.
32728 (Binary::ResolveOperator): More null checking and miscellaneous coding
32731 2001-09-17 Ravi Pratap <ravi@ximian.com>
32733 * rootcontext.cs (IsNameSpace): Compare against null.
32735 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32737 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32738 and Unary::Operator.
32740 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32743 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32744 we have overloaded operators.
32745 (Binary::ResolveOperator): Implement the part which does the operator overload
32748 * class.cs (Operator::Emit): Implement.
32749 (TypeContainer::Emit): Emit the operators we have too.
32751 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32752 the case when we have a user-defined operator.
32754 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32756 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32758 2001-09-16 Ravi Pratap <ravi@ximian.com>
32760 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32761 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32762 (Constructor::Emit): Implement.
32763 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32764 if we have no work to do.
32765 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32768 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32769 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32771 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32774 2001-09-15 Ravi Pratap <ravi@ximian.com>
32776 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32778 (Tree::RecordNamespace): Method to do what the name says ;-)
32779 (Tree::Namespaces): Property to get at the namespaces hashtable.
32781 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32784 * rootcontext.cs (IsNamespace): Fixed it :-)
32786 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32788 * class.cs (TypeContainer::FindMembers): Add support for
32790 (MethodCore): New class that encapsulates both the shared aspects
32791 of a Constructor and a Method.
32792 (Method, Constructor): Factored pieces into MethodCore.
32794 * driver.cs: Added --fatal which makes errors throw exceptions.
32795 Load System assembly as well as part of the standard library.
32797 * report.cs: Allow throwing exceptions on errors for debugging.
32799 * modifiers.cs: Do not use `parent', instead use the real type
32800 container to evaluate permission settings.
32802 * class.cs: Put Ravi's patch back in. He is right, and we will
32803 have to cope with the
32805 2001-09-14 Ravi Pratap <ravi@ximian.com>
32807 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32808 FamORAssem, not FamANDAssem.
32810 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32812 * driver.cs: Added --parse option that only parses its input files
32815 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32816 incorrect. IsTopLevel is not used to tell whether an object is
32817 root_types or not (that can be achieved by testing this ==
32818 root_types). But to see if this is a top-level *class* (not
32819 necessarly our "toplevel" container).
32821 2001-09-14 Ravi Pratap <ravi@ximian.com>
32823 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32824 parent instead of a direct call to GetType.
32826 2001-09-14 Ravi Pratap <ravi@ximian.com>
32828 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32829 Modifiers.TypeAttr. This should just be a call to that method.
32831 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32832 object so that we can determine if we are top-level or not.
32834 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32837 * enum.cs (Enum::Define): Ditto.
32839 * modifiers.cs (FieldAttr): Re-write.
32841 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32842 (TypeContainer::HaveStaticConstructor): New property to provide access
32843 to precisely that info.
32845 * modifiers.cs (MethodAttr): Re-write.
32846 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32848 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32849 of top-level types as claimed.
32851 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32853 * expression.cs (MemberLookup): Fruitless attempt to lookup
32854 constructors. Maybe I need to emit default constructors? That
32855 might be it (currently .NET emits this for me automatically).
32856 (Invocation::OverloadResolve): Cope with Arguments == null.
32857 (Invocation::EmitArguments): new function, shared by the new
32858 constructor and us.
32859 (Invocation::Emit): Handle static and instance methods. Emit
32860 proper call instruction for virtual or non-virtual invocations.
32861 (New::Emit): Implement.
32862 (New::Resolve): Implement.
32863 (MemberAccess:Resolve): Implement.
32864 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32865 to track instances.
32866 (FieldExpr::Resolve): Set type.
32868 * support.cs: Handle empty arguments.
32870 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32871 SimpleLookup): Auxiliary routines to help parse a qualifier
32874 Update qualifier_identifier rule.
32876 * codegen.cs: Removed debugging messages.
32878 * class.cs: Make this a global thing, this acts just as a "key" to
32879 objects that we might have around.
32881 (Populate): Only initialize method_builders_to_methods once.
32883 * expression.cs (PropertyExpr): Initialize type from the
32886 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32887 Resolve pattern. Attempt to implicitly convert value to boolean.
32890 * expression.cs: Set the type for the int32/int32 argument case.
32891 (Binary::ResolveOperator): Set the return type to boolean for
32892 comparission operators
32894 * typemanager.cs: Remove debugging print code.
32896 (Invocation::Resolve): resolve type.
32898 * class.cs: Allocate a MemberInfo of the correct size, as the code
32899 elsewhere depends on the test to reflect the correct contents.
32901 (Method::) Keep track of parameters, due to System.Reflection holes
32903 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32906 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32907 of the exact size and return that.
32909 (Class::LookupMethodByBuilder): New function that maps
32910 MethodBuilders to its methods. Required to locate the information
32911 on methods because System.Reflection bit us again.
32913 * support.cs: New file, contains an interface ParameterData and
32914 two implementations: ReflectionParameters and InternalParameters
32915 used to access Parameter information. We will need to grow this
32918 * expression.cs (Invocation::GetParameterData): implement a cache
32919 and a wrapper around the ParameterData creation for methods.
32920 (Invocation::OverloadResolve): Use new code.
32922 2001-09-13 Ravi Pratap <ravi@ximian.com>
32924 * class.cs (TypeContainer::EmitField): Remove and move into
32925 (Field::Define): here and modify accordingly.
32926 (Field.FieldBuilder): New member.
32927 (TypeContainer::Populate): Update accordingly.
32928 (TypeContainer::FindMembers): Implement.
32930 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32932 * statement.cs: (VariableInfo::VariableType): New field to be
32933 initialized with the full type once it is resolved.
32935 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32937 * parameter.cs (GetParameterInfo): Use a type cache to compute
32938 things only once, and to reuse this information
32940 * expression.cs (LocalVariableReference::Emit): Implement.
32941 (OpcodeCast::Emit): fix.
32943 (ParameterReference::Resolve): Implement.
32944 (ParameterReference::Emit): Implement.
32946 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32947 that are expressions need to stay as Expressions.
32949 * typemanager.cs (CSharpName): Returns the C# name of a type if
32952 * expression.cs (Expression::ConvertImplicit): New function that
32953 implements implicit type conversions.
32955 (Expression::ImplicitReferenceConversion): Implements implicit
32956 reference conversions.
32958 (EmptyCast): New type for transparent casts.
32960 (OpcodeCast): New type for casts of types that are performed with
32961 a sequence of bytecodes.
32963 (BoxedCast): New type used for casting value types into reference
32964 types. Emits a box opcode.
32966 (Binary::DoNumericPromotions): Implements numeric promotions of
32967 and computation of the Binary::Type.
32969 (Binary::EmitBranchable): Optimization.
32971 (Binary::Emit): Implement code emission for expressions.
32973 * typemanager.cs (TypeManager): Added two new core types: sbyte
32976 2001-09-12 Ravi Pratap <ravi@ximian.com>
32978 * class.cs (TypeContainer::FindMembers): Method which does exactly
32979 what Type.FindMembers does, only we don't have to use reflection. No
32980 implementation yet.
32982 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32983 typecontainer objects as we need to get at them.
32984 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32986 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32987 typecontainer object.
32989 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32990 of just a Report object.
32992 2001-09-11 Ravi Pratap <ravi@ximian.com>
32994 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32996 (TypeContainer::Populate): Now define the delegates of the type too.
32997 (TypeContainer.Delegates): Property to access the list of delegates defined
33000 * delegates.cs (Delegate::Define): Implement partially.
33002 * modifiers.cs (TypeAttr): Handle more flags.
33004 2001-09-11 Ravi Pratap <ravi@ximian.com>
33006 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
33008 (Operator::Define): Re-write logic to get types by using the LookupType method
33009 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
33010 (Indexer::Define): Ditto.
33011 (Event::Define): Ditto.
33012 (Property::Define): Ditto.
33014 2001-09-10 Ravi Pratap <ravi@ximian.com>
33016 * class.cs (TypeContainer::Populate): Now define operators too.
33017 (TypeContainer.Operators): New property to access the list of operators
33019 (Operator.OperatorMethodBuilder): New member to hold the method builder
33020 for the operator we are defining.
33021 (Operator::Define): Implement.
33023 2001-09-10 Ravi Pratap <ravi@ximian.com>
33025 * class.cs (Event::Define): Make the prefixes of the accessor methods
33026 addOn_ and removeOn_
33028 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
33029 of the location being passed in too. Ideally, this should go later since all
33030 error reporting should be done through the Report object.
33032 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
33033 (Populate): Iterate thru the indexers we have and define them too.
33034 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
33035 for the get and set accessors.
33036 (Indexer::Define): Implement.
33038 2001-09-09 Miguel de Icaza <miguel@ximian.com>
33040 * expression.cs (Binary::Resolve): Beginning of it. I scratched
33041 my previous implementation, did not work.
33043 * typemanager.cs: Add a couple of missing types (the longs).
33045 * literal.cs: Use TypeManager.bool_type instead of getting it.
33047 * expression.cs (EventExpr): New kind of expressions.
33048 (Expressio::ExprClassFromMemberInfo): finish
33050 2001-09-08 Miguel de Icaza <miguel@ximian.com>
33052 * assign.cs: Emit stores to static fields differently.
33054 2001-09-08 Ravi Pratap <ravi@ximian.com>
33056 * Merge in changes and adjust code to tackle conflicts. Backed out my
33057 code in Assign::Resolve ;-)
33059 2001-09-08 Ravi Pratap <ravi@ximian.com>
33061 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
33062 instead Report.Error and also pass in the location.
33063 (CSharpParser::Lexer): New readonly property to return the reference
33064 to the Tokenizer object.
33065 (declare_local_variables): Use Report.Error with location instead of plain
33069 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
33070 (Operator.CheckBinaryOperator): Ditto.
33072 * cs-parser.jay (operator_declarator): Update accordingly.
33074 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
33075 (CheckBinaryOperator): Same here.
33077 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
33078 on the name without any prefixes of namespace names etc. This is because we
33079 already might have something already fully qualified like
33080 'System.Console.WriteLine'
33082 * assign.cs (Resolve): Begin implementation. Stuck ;-)
33084 2001-09-07 Ravi Pratap <ravi@ximian.com>
33086 * cs-tokenizer.cs (location): Return a string which also contains
33089 * expression.cs (ElementAccess): New class for expressions of the
33090 type 'element access.'
33091 (BaseAccess): New class for expressions of the type 'base access.'
33092 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
33095 * cs-parser.jay (element_access): Implement action.
33096 (base_access): Implement actions.
33097 (checked_expression, unchecked_expression): Implement.
33099 * cs-parser.jay (local_variable_type): Correct and implement.
33100 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
33102 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
33104 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
33105 name and the specifiers.
33107 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
33109 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
33110 making them all public ;-)
33112 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
33115 2001-09-07 Miguel de Icaza <miguel@ximian.com>
33117 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
33119 (FieldExpr, PropertyExprs): New resolved expressions.
33120 (SimpleName::MemberStaticCheck): Perform static checks for access
33121 to non-static fields on static methods. Maybe this should be
33122 generalized for MemberAccesses.
33123 (SimpleName::ResolveSimpleName): More work on simple name
33126 * cs-parser.jay (primary_expression/qualified_identifier): track
33127 the parameter index.
33129 * codegen.cs (CodeGen::Save): Catch save exception, report error.
33130 (EmitContext::EmitBoolExpression): Chain to expression generation
33131 instead of temporary hack.
33132 (::EmitStatementExpression): Put generic expression code generation.
33134 * assign.cs (Assign::Emit): Implement variable assignments to
33135 local variables, parameters and fields.
33137 2001-09-06 Miguel de Icaza <miguel@ximian.com>
33139 * statement.cs (Block::GetVariableInfo): New method, returns the
33140 VariableInfo for a variable name in a block.
33141 (Block::GetVariableType): Implement in terms of GetVariableInfo
33143 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
33144 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
33146 2001-09-06 Ravi Pratap <ravi@ximian.com>
33148 * cs-parser.jay (operator_declaration): Continue on my quest : update
33149 to take attributes argument.
33150 (event_declaration): Ditto.
33151 (enum_declaration): Ditto.
33152 (indexer_declaration): Ditto.
33154 * class.cs (Operator::Operator): Update constructor accordingly.
33155 (Event::Event): Ditto.
33157 * delegate.cs (Delegate::Delegate): Same here.
33159 * enum.cs (Enum::Enum): Same here.
33161 2001-09-05 Ravi Pratap <ravi@ximian.com>
33163 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
33165 * ../tests/cs0658.cs : New file to demonstrate error 0658.
33167 * attribute.cs (Attributes): New class to encapsulate all attributes which were
33168 being passed around as an arraylist.
33169 (Attributes::AddAttribute): Method to add attribute sections.
33171 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
33172 (struct_declaration): Update accordingly.
33173 (constant_declaration): Update.
33174 (field_declaration): Update.
33175 (method_header): Update.
33176 (fixed_parameter): Update.
33177 (parameter_array): Ditto.
33178 (property_declaration): Ditto.
33179 (destructor_declaration): Ditto.
33181 * class.cs (Struct::Struct): Update constructors accordingly.
33182 (Class::Class): Ditto.
33183 (Field::Field): Ditto.
33184 (Method::Method): Ditto.
33185 (Property::Property): Ditto.
33186 (TypeContainer::OptAttribute): update property's return type.
33188 * interface.cs (Interface.opt_attributes): New member.
33189 (Interface::Interface): Update to take the extra Attributes argument.
33191 * parameter.cs (Parameter::Parameter): Ditto.
33193 * constant.cs (Constant::Constant): Ditto.
33195 * interface.cs (InterfaceMemberBase): New OptAttributes field.
33196 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
33197 the attributes as a parameter.
33198 (InterfaceProperty): Update constructor call.
33199 (InterfaceEvent): Ditto.
33200 (InterfaceMethod): Ditto.
33201 (InterfaceIndexer): Ditto.
33203 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
33204 pass the attributes too.
33205 (interface_event_declaration): Ditto.
33206 (interface_property_declaration): Ditto.
33207 (interface_method_declaration): Ditto.
33208 (interface_declaration): Ditto.
33210 2001-09-05 Miguel de Icaza <miguel@ximian.com>
33212 * class.cs (Method::Define): Track the "static Main" definition to
33213 create an entry point.
33215 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
33216 EntryPoint if we find it.
33218 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
33219 (EmitContext::ig): Make this variable public.
33221 * driver.cs: Make the default output file be the first file name
33222 with the .exe extension.
33224 Detect empty compilations
33226 Handle various kinds of output targets. Handle --target and
33227 rename -t to --dumper.
33229 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
33230 methods inherited from Expression return now an Expression. This
33231 will is used during the tree rewriting as we resolve them during
33234 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
33235 the spec. Missing entirely is the information about
33236 accessability of elements of it.
33238 (Expression::ExprClassFromMemberInfo): New constructor for
33239 Expressions that creates a fully initialized Expression based on
33240 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
33243 (Invocation::Resolve): Begin implementing resolution of invocations.
33245 * literal.cs (StringLiteral): Implement Emit.
33247 2001-09-05 Ravi Pratap <ravi@ximian.com>
33249 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
33252 2001-09-04 Ravi Pratap <ravi@ximian.com>
33254 * cs-parser.jay (attribute_arguments): Implement actions.
33255 (attribute): Fix bug in production. Implement action.
33256 (attribute_list): Implement.
33257 (attribute_target): Implement.
33258 (attribute_target_specifier, opt_target_specifier): Implement
33259 (CheckAttributeTarget): New method to check if the attribute target
33261 (attribute_section): Implement.
33262 (opt_attributes): Implement.
33264 * attribute.cs : New file to handle attributes.
33265 (Attribute): Class to hold attribute info.
33267 * cs-parser.jay (opt_attribute_target_specifier): Remove production
33268 (attribute_section): Modify production to use 2 different rules to
33269 achieve the same thing. 1 s/r conflict down !
33270 Clean out commented, useless, non-reducing dimension_separator rules.
33272 * class.cs (TypeContainer.attributes): New member to hold list
33273 of attributes for a type.
33274 (Struct::Struct): Modify to take one more argument, the attribute list.
33275 (Class::Class): Ditto.
33276 (Field::Field): Ditto.
33277 (Method::Method): Ditto.
33278 (Property::Property): Ditto.
33280 * cs-parser.jay (struct_declaration): Update constructor call to
33281 pass in the attributes too.
33282 (class_declaration): Ditto.
33283 (constant_declaration): Ditto.
33284 (field_declaration): Ditto.
33285 (method_header): Ditto.
33286 (fixed_parameter): Ditto.
33287 (parameter_array): Ditto.
33288 (property_declaration): Ditto.
33290 * constant.cs (Constant::Constant): Update constructor similarly.
33291 Use System.Collections.
33293 * parameter.cs (Parameter::Parameter): Update as above.
33295 2001-09-02 Ravi Pratap <ravi@ximian.com>
33297 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33298 (TypeContainer.delegates): New member to hold list of delegates.
33300 * cs-parser.jay (delegate_declaration): Implement the action correctly
33301 this time as I seem to be on crack ;-)
33303 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33305 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33306 tell whether an identifier represents a namespace.
33308 * expression.cs (NamespaceExpr): A namespace expression, used only
33309 temporarly during expression resolution.
33310 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33311 utility functions to resolve names on expressions.
33313 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33315 * codegen.cs: Add hook for StatementExpressions.
33317 * class.cs: Fix inverted test for static flag in methods.
33319 2001-09-02 Ravi Pratap <ravi@ximian.com>
33321 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33322 to make it coincide with MS' number.
33323 (Operator::CheckBinaryOperator): Ditto.
33325 * ../errors/errors.txt : Remove error numbers added earlier.
33327 * ../errors/cs1019.cs : Test case for error # 1019
33329 * ../errros/cs1020.cs : Test case for error # 1020
33331 * cs-parser.jay : Clean out commented cruft.
33332 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33333 used anywhere - non-reducing rule.
33334 (namespace_declarations): Non-reducing rule - comment out.
33336 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33337 with TypeContainer::AddEnum.
33339 * delegate.cs : New file for delegate handling classes.
33340 (Delegate): Class for declaring delegates.
33342 * makefile : Update.
33344 * cs-parser.jay (delegate_declaration): Implement.
33346 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33348 * class.cs (Event::Define): Implement.
33349 (Event.EventBuilder): New member.
33351 * class.cs (TypeContainer::Populate): Update to define all enums and events
33353 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33354 readonly fields for all these cases ?
33356 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33358 * class.cs (Property): Revamp to use the convention of making fields readonly.
33359 Accordingly modify code elsewhere.
33361 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33362 the Define method of the Property class.
33364 * class.cs : Clean up applied patch and update references to variables etc. Fix
33366 (TypeContainer::Populate): Update to define all the properties we have. Also
33367 define all enumerations.
33369 * enum.cs (Define): Implement.
33371 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33373 * cs-parser.jay (overloadable_operator): The semantic value is an
33374 enum of the Operator class.
33375 (operator_declarator): Implement actions.
33376 (operator_declaration): Implement.
33378 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33379 validity of definitions.
33380 (Operator::CheckBinaryOperator): Static method to check for binary operators
33381 (TypeContainer::AddOperator): New method to add an operator to a type.
33383 * cs-parser.jay (indexer_declaration): Added line to actually call the
33384 AddIndexer method so it gets added ;-)
33386 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33387 already taken care of by the MS compiler ?
33389 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33391 * class.cs (Operator): New class for operator declarations.
33392 (Operator::OpType): Enum for the various operators.
33394 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33396 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33397 ostensibly handle this in semantic analysis.
33399 * cs-parser.jay (general_catch_clause): Comment out
33400 (specific_catch_clauses, specific_catch_clause): Ditto.
33401 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33402 (catch_args, opt_catch_args): New productions.
33403 (catch_clause): Rewrite to use the new productions above
33404 (catch_clauses): Modify accordingly.
33405 (opt_catch_clauses): New production to use in try_statement
33406 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33407 and re-write the code in the actions to extract the specific and
33408 general catch clauses by being a little smart ;-)
33410 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33411 Hooray, try and catch statements parse fine !
33413 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33415 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33416 string from the hashtable of variables.
33418 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33419 I end up making that mistake ;-)
33420 (catch_clauses): Fixed gross error which made Key and Value of the
33421 DictionaryEntry the same : $1 !!
33423 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33425 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33427 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33428 when the add and remove accessors are specified.
33430 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33432 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33433 information about indexer_declarator.
33434 (indexer_declarator): Implement actions.
33435 (parsing_indexer): New local boolean used to keep track of whether
33436 we are parsing indexers or properties. This is necessary because
33437 implicit_parameters come into picture even for the get accessor in the
33438 case of an indexer.
33439 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33441 * class.cs (Indexer): New class for indexer declarations.
33442 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33443 (TypeContainer::indexers): New member to hold list of indexers for the
33446 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33448 * cs-parser.jay (add_accessor_declaration): Implement action.
33449 (remove_accessor_declaration): Implement action.
33450 (event_accessors_declaration): Implement
33451 (variable_declarators): swap statements for first rule - trivial.
33453 * class.cs (Event): New class to hold information about event
33455 (TypeContainer::AddEvent): New method to add an event to a type
33456 (TypeContainer::events): New member to hold list of events.
33458 * cs-parser.jay (event_declaration): Implement actions.
33460 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33462 * cs-parser.jay (dim_separators): Implement. Make it a string
33463 concatenating all the commas together, just as they appear.
33464 (opt_dim_separators): Modify accordingly
33465 (rank_specifiers): Update accordingly. Basically do the same
33466 thing - instead, collect the brackets here.
33467 (opt_rank_sepcifiers): Modify accordingly.
33468 (array_type): Modify to actually return the complete type string
33469 instead of ignoring the rank_specifiers.
33470 (expression_list): Implement to collect the expressions
33471 (variable_initializer): Implement. We make it a list of expressions
33472 essentially so that we can handle the array_initializer case neatly too.
33473 (variable_initializer_list): Implement.
33474 (array_initializer): Make it a list of variable_initializers
33475 (opt_array_initializer): Modify accordingly.
33477 * expression.cs (New::NType): Add enumeration to help us
33478 keep track of whether we have an object/delegate creation
33479 or an array creation.
33480 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33481 members to hold data about array creation.
33482 (New:New): Modify to update NewType
33483 (New:New): New Overloaded contructor for the array creation
33486 * cs-parser.jay (array_creation_expression): Implement to call
33487 the overloaded New constructor.
33489 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33491 * class.cs (TypeContainer::Constructors): Return member
33492 constructors instead of returning null.
33494 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33496 * typemanager.cs (InitCoreTypes): Initialize the various core
33497 types after we have populated the type manager with the user
33498 defined types (this distinction will be important later while
33499 compiling corlib.dll)
33501 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33502 on Expression Classification. Now all expressions have a method
33503 `Resolve' and a method `Emit'.
33505 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33506 generation from working. Also add some temporary debugging
33509 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33511 * codegen.cs: Lots of code generation pieces. This is only the
33512 beginning, will continue tomorrow with more touches of polish. We
33513 handle the fundamentals of if, while, do, for, return. Others are
33514 trickier and I need to start working on invocations soon.
33516 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33519 * codegen.cs (EmitContext): New struct, used during code
33520 emission to keep a context. Most of the code generation will be
33523 * cs-parser.jay: Add embedded blocks to the list of statements of
33524 this block. So code generation proceeds in a top down fashion.
33526 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33528 * statement.cs: Add support for multiple child blocks.
33530 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33532 * codegen.cs (EmitCode): New function, will emit the code for a
33533 Block of code given a TypeContainer and its ILGenerator.
33535 * statement.cs (Block): Standard public readonly optimization.
33536 (Block::Block constructors): Link children.
33537 (Block::Child): Child Linker.
33538 (Block::EmitVariables): Emits IL variable declarations.
33540 * class.cs: Drop support for MethodGroups here, delay until
33542 (Method::): Applied the same simplification that I did before, and
33543 move from Properties to public readonly fields.
33544 (Method::ParameterTypes): Returns the parameter types for the
33545 function, and implements a cache that will be useful later when I
33546 do error checking and the semantic analysis on the methods is
33548 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33549 and made a method, optional argument tells whether this is a class
33550 or a structure to apply the `has-this' bit.
33551 (Method::GetCallingConvention): Implement, returns the calling
33553 (Method::Define): Defines the type, a second pass is performed
33554 later to populate the methods.
33556 (Constructor::ParameterTypes): implement a cache similar to the
33557 one on Method::ParameterTypes, useful later when we do semantic
33560 (TypeContainer::EmitMethod): New method. Emits methods.
33562 * expression.cs: Removed MethodGroup class from here.
33564 * parameter.cs (Parameters::GetCallingConvention): new method.
33566 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33568 * class.cs (TypeContainer::Populate): Drop RootContext from the
33571 (Constructor::CallingConvention): Returns the calling convention.
33572 (Constructor::ParameterTypes): Returns the constructor parameter
33575 (TypeContainer::AddConstructor): Keep track of default constructor
33576 and the default static constructor.
33578 (Constructor::) Another class that starts using `public readonly'
33579 instead of properties.
33581 (Constructor::IsDefault): Whether this is a default constructor.
33583 (Field::) use readonly public fields instead of properties also.
33585 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33586 track of static constructors; If none is used, turn on
33587 BeforeFieldInit in the TypeAttributes.
33589 * cs-parser.jay (opt_argument_list): now the return can be null
33590 for the cases where there are no arguments.
33592 (constructor_declarator): If there is no implicit `base' or
33593 `this', then invoke the default parent constructor.
33595 * modifiers.cs (MethodAttr): New static function maps a set of
33596 modifiers flags into a MethodAttributes enum
33597 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33598 MethodAttr, TypeAttr to represent the various mappings where the
33599 modifiers are used.
33600 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33602 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33604 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33607 * interface.cs (PopulateIndexer): Implemented the code generator
33608 for interface indexers.
33610 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33612 * interface.cs (InterfaceMemberBase): Now we track the new status
33615 (PopulateProperty): Implement property population. Woohoo! Got
33616 Methods and Properties going today.
33618 Removed all the properties for interfaces, and replaced them with
33619 `public readonly' fields.
33621 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33623 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33624 initialize their hashtables/arraylists only when they are needed
33625 instead of doing this always.
33627 * parameter.cs: Handle refs and out parameters.
33629 * cs-parser.jay: Use an ArrayList to construct the arguments
33630 instead of the ParameterCollection, and then cast that to a
33633 * parameter.cs: Drop the use of ParameterCollection and use
33634 instead arrays of Parameters.
33636 (GetParameterInfo): Use the Type, not the Name when resolving
33639 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33641 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33642 and instead use public readonly fields.
33644 * class.cs: Put back walking code for type containers.
33646 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33648 * class.cs (MakeConstant): Code to define constants.
33650 * rootcontext.cs (LookupType): New function. Used to locate types
33653 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33655 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33656 this System.Reflection code is. Kudos to Microsoft
33658 * typemanager.cs: Implement a type cache and avoid loading all
33659 types at boot time. Wrap in LookupType the internals. This made
33660 the compiler so much faster. Wow. I rule!
33662 * driver.cs: Make sure we always load mscorlib first (for
33663 debugging purposes, nothing really important).
33665 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33666 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33668 * rootcontext.cs: Lookup types on their namespace; Lookup types
33669 on namespaces that have been imported using the `using' keyword.
33671 * class.cs (TypeContainer::TypeAttr): Virtualize.
33672 (Class::TypeAttr): Return attributes suitable for this bad boy.
33673 (Struct::TypeAttr): ditto.
33674 Handle nested classes.
33675 (TypeContainer::) Remove all the type visiting code, it is now
33676 replaced with the rootcontext.cs code
33678 * rootcontext.cs (GetClassBases): Added support for structs.
33680 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33682 * interface.cs, statement.cs, class.cs, parameter.cs,
33683 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33684 Drop use of TypeRefs, and use strings instead.
33686 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33690 * class.cs (Struct::Struct): set the SEALED flags after
33691 checking the modifiers.
33692 (TypeContainer::TypeAttr): new property, returns the
33693 TypeAttributes for a class.
33695 * cs-parser.jay (type_list): Oops, list production was creating a
33696 new list of base types.
33698 * rootcontext.cs (StdLib): New property.
33699 (GetInterfaceTypeByName): returns an interface by type name, and
33700 encapsulates error handling here.
33701 (GetInterfaces): simplified.
33702 (ResolveTree): Encapsulated all the tree resolution here.
33703 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33706 * driver.cs: Add support for --nostdlib, to avoid loading the
33707 default assemblies.
33708 (Main): Do not put tree resolution here.
33710 * rootcontext.cs: Beginning of the class resolution.
33712 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33714 * rootcontext.cs: Provide better error reporting.
33716 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33718 * rootcontext.cs (CreateInterface): Handle the case where there
33719 are no parent interfaces.
33721 (CloseTypes): Routine to flush types at the end.
33722 (CreateInterface): Track types.
33723 (GetInterfaces): Returns an array of Types from the list of
33724 defined interfaces.
33726 * typemanager.c (AddUserType): Mechanism to track user types (puts
33727 the type on the global type hash, and allows us to close it at the
33730 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33732 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33733 RecordInterface instead.
33735 * cs-parser.jay: Updated to reflect changes above.
33737 * decl.cs (Definition): Keep track of the TypeBuilder type that
33738 represents this type here. Not sure we will use it in the long
33739 run, but wont hurt for now.
33741 * driver.cs: Smaller changes to accomodate the new code.
33743 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33746 * rootcontext.cs (CreateInterface): New method, used to create
33747 the System.TypeBuilder type for interfaces.
33748 (ResolveInterfaces): new entry point to resolve the interface
33750 (CodeGen): Property, used to keep track of the code generator.
33752 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33754 * cs-parser.jay: Add a second production for delegate_declaration
33757 (enum_body): Put an opt_comma here instead of putting it on
33758 enum_body or enum_member_declarations so we can handle trailing
33759 commas on enumeration members. Gets rid of a shift/reduce.
33761 (type_list): Need a COMMA in the middle.
33763 (indexer_declaration): Tell tokenizer to recognize get/set
33765 * Remove old targets.
33767 * Re-add the parser target.
33769 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33771 * cs-parser.jay: Add precendence rules for a number of operators
33772 ot reduce the number of shift/reduce conflicts in the grammar.
33774 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33776 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33779 Get rid of old crufty code.
33781 * rootcontext.cs: Use this to keep track of the parsed
33782 representation and the defined types available to the program.
33784 * gen-treedump.cs: adjust for new convention.
33786 * type.cs: Split out the type manager, and the assembly builder
33789 * typemanager.cs: the type manager will live here now.
33791 * cil-codegen.cs: And the code generator here.
33793 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33795 * makefile: Fixed up for easy making.
33797 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33799 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33802 (unary_expression): Expand pre_increment_expression and
33803 post_decrement_expression to reduce a shift/reduce.
33805 2001-07-11 Simon Cozens
33807 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33809 Improve allow_keyword_as_indent name.
33811 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33813 * Adjustments for Beta2.
33815 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33817 * decl.cs: Added `Define' abstract method.
33818 (InTransit): new property, used to catch recursive definitions.
33820 * interface.cs: Implement `Define'.
33822 * modifiers.cs: Map Modifiers.constants to
33823 System.Reflection.TypeAttribute flags.
33825 * class.cs: Keep track of types and user-defined types.
33826 (BuilderInit): New method for creating an assembly
33827 (ResolveType): New function to launch the resolution process, only
33828 used by interfaces for now.
33830 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33831 that are inserted into the name space.
33833 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33835 * ARGH. I have screwed up my tree so many times due to the use of
33836 rsync rather than using CVS. Going to fix this at once.
33838 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33841 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33843 * Experiment successful: Use System.Type rather that our own
33846 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33848 * cs-parser.jay: Removed nsAliases from here.
33850 Use new namespaces, handle `using XXX;'
33852 * namespace.cs: Reimplemented namespace handling, use a recursive
33853 definition of the class. Now we can keep track of using clauses
33854 and catch invalid using clauses.
33856 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33858 * gen-treedump.cs: Adapted for all the renaming.
33860 * expression.cs (Expression): this class now has a Type property
33861 which returns an expression Type.
33863 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33864 `Type', as this has a different meaning now in the base
33866 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33868 * interface.cs, class.cs: Removed from all the sources the
33869 references to signature computation, as we can not do method
33870 signature computation during the parsing time, as we are not
33871 trying to solve at that point distinguishing:
33875 void a (NS.Blah x) {}
33878 Which depending on the context might be valid or not, as we do not
33879 know if Blah is the same thing as NS.Blah at that point.
33881 * Redid everything so the code uses TypeRefs now instead of
33882 Types. TypeRefs are just temporary type placeholders, that need
33883 to be resolved. They initially have a pointer to a string and the
33884 current scope in which they are used. This is used later by the
33885 compiler to resolve the reference to an actual Type.
33887 * DeclSpace is no longer a CIR.Type, and neither are
33888 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33889 are all DeclSpaces, but no Types.
33891 * type.cs (TypeRefManager): This implements the TypeRef manager,
33892 which keeps track of all the types that need to be resolved after
33893 the parsing has finished.
33895 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33897 * ARGH. We are going to have to store `foreach' as a class rather
33898 than resolving it, as we need to verify error 1579 after name
33899 resolution. *OR* we could keep a flag that says `This request to
33900 IEnumerator comes from a foreach statement' which we can then use
33901 to generate the error.
33903 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33905 * class.cs (TypeContainer.AddMethod): we now add methods to the
33906 MethodGroup instead of the method hashtable.
33908 * expression.cs: Add MethodGroup abstraction, which gets us one
33909 step closer to the specification in the way we handle method
33912 * cs-parser.jay (primary_expression): qualified_identifier now
33913 tried to match up an identifier to a local variable reference or
33914 to a parameter reference.
33916 current_local_parameters is now a parser global variable that
33917 points to the current parameters for the block, used during name
33920 (property_declaration): Now creates an implicit `value' argument to
33923 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33925 * parameter.cs: Do not use `param' arguments as part of the
33926 signature, per the spec.
33928 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33930 * decl.cs: Base class for classes, structs and interfaces. This
33931 is the "Declaration Space"
33933 * cs-parser.jay: Use CheckDef for checking declaration errors
33934 instead of having one on each function.
33936 * class.cs: Factor out some code for handling error handling in
33937 accordance to the "Declarations" section in the "Basic Concepts"
33938 chapter in the ECMA C# spec.
33940 * interface.cs: Make all interface member classes derive from
33941 InterfaceMemberBase.
33943 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33945 * Many things: all interfaces are parsed and generated in
33946 gen-treedump. Support for member variables, constructors,
33947 destructors, properties, constants is there.
33949 Beginning of the IL backend, but very little done, just there for
33952 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33954 * cs-parser.jay: Fix labeled statement.
33956 * cs-tokenizer.cs (escape): Escape " and ' always.
33957 ref_line, ref_name: keep track of the line/filename as instructed
33958 by #line by the compiler.
33961 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33963 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33964 to match the values in System.CodeDOM.
33966 Divid renamed to Divide.
33968 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33970 (Statements.set): remove.
33972 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33975 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33976 falseStatements always have valid values.
33978 * cs-parser.jay: Use System.CodeDOM now.