1 2005-01-27 Marek Safar <marek.safar@seznam.cz>
3 * expression.cs (Indirection): Implemented IVariable interface
4 to support indirection in AddressOf operator.
5 (PointerArithmetic.Emit): Add optimalization for case where
6 result can be precomputed.
8 2005-01-26 Martin Baulig <martin@ximian.com>
10 * class.cs (TypeContainer.AttributeTargets): Return the correct
11 AttributeTargets depending on our `Kind' instead of throwing an
12 exception; fixes #71632.
14 2005-01-26 Marek Safar <marek.safar@seznam.cz>
17 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
20 2005-01-25 Raja R Harinath <rharinath@novell.com>
23 * expression.cs (MemberAccess.DoResolve): Don't complain with
24 cs0572 when the LHS of a member access has identical name and type
27 2005-01-25 Marek Safar <marek.safar@seznam.cz>
30 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
32 Create custom PermissionSet only for PermissionSetAttribute.
34 2005-01-24 Marek Safar <marek.safar@seznam.cz>
37 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
38 delegates in static class.
40 2005-01-24 Martin Baulig <martin@ximian.com>
42 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
43 merging an implicit block, just use its reachability.
45 * statement.cs (Block.Resolve): Make the unreachable code check
46 work wrt. implicit blocks; see test-337 from #63842.
48 2005-01-21 Alp Toker <alp@atoker.com>
50 * cs-parser.jay: destructor_declaration's container is PartialContainer
51 not Class when partial types are used, so use Kind prop instead of
54 2005-01-22 Miguel de Icaza <miguel@ximian.com>
56 * cs-parser.jay: Improve error reporting when an interface
59 2005-01-20 Dick Porter <dick@ximian.com>
61 * support.cs: SeekableStreamReader fix from Sandor Dobos
62 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
63 chars are read. Fixes bug 70369.
65 2005-01-20 Raja R Harinath <rharinath@novell.com>
67 * cs-parser.jay (catch_clause): Simplify current_block handling
70 2005-01-17 Miguel de Icaza <miguel@ximian.com>
72 * convert.cs (ImplicitStandardConversionExists): Synchronize the
73 code with ImplicitStandardConversion to handle the implicit
74 conversion of method groups into valid delegate invocations.
76 The problem is that in parameter handling we were using this code
77 path. Fixes bug #64698
79 2005-01-19 Raja R Harinath <rharinath@novell.com>
81 * cs-parser.jay: Fix several infelicities.
82 - Avoid assigning to the parser value stack. Code like
83 '$3 = null' is unclean. Synthesize a value for the code block
85 - Avoid using oob_stack for storing location information. Use ...
86 (_mark_): ... this. New (empty) rule. Saves the current location
88 (foreach_statement): Avoid using oob_stack for current_block
89 handling. Use technique used in for_statement and
90 using_statement. Synthesize a value for the code block to store
91 additional intermediate information.
93 2005-01-13 Miguel de Icaza <miguel@ximian.com>
95 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
96 of a different type is only allowed to private fields of a
97 containing type, not on fields of a base class.
99 See test-174.cs and error cs0122-9.cs
101 2005-01-13 Raja R Harinath <rharinath@novell.com>
103 Fix test-335.cs (bug #58126).
104 * cs-parser.jay (argument): Split out non-expression parts of the
105 rule into 'non_simple_argument'.
106 (invocation_expression): Support parenthesized invocations with
107 multiple arguments, and with single non-simple arguments.
109 2005-01-13 Raja R Harinath <rharinath@novell.com>
111 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
114 2005-01-12 Raja R Harinath <rharinath@novell.com>
116 Fix cs0038-1.cs, cs1640-6.cs.
117 * ecore.cs (Expression.Resolve): Remove special-case for
118 SimpleName in error-handling.
119 (Expression.almostMatchedMembers): Relax access permission to
121 (Expression.MemberLookupFailed): Handle duplicates in
122 almostMatchedMembers list.
123 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
124 * expression.cs (New.DoResolve): Report CS1540 for more cases.
125 * typemanager.cs (GetFullNameSignature): Use the MethodBase
126 overload if the passed in MemberInfo is a MethodBase.
128 2005-01-12 Marek Safar <marek.safar@seznam.cz>
131 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
132 for non-CAS & merge permission sets properly.
134 2005-01-11 Raja R Harinath <rharinath@novell.com>
136 Improve standard-compliance of simple name and member access
137 resolution. Fixes bugs #52697, #57200, #67520, #69519.
138 * ecore.cs (FullNamedExpression): New abstract base class
139 for Namespaces and TypeExpressions.
140 (ResolveFlags.SimpleName): Remove.
141 (SimpleName): Remove support for dotted names.
142 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
143 DeclSpace.FindType and DeclSpace.LookupType.
144 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
145 (Expression.ExprClassName): Make member function.
146 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
147 a namespace. Remove creation of dotted "SimpleName"s.
148 (MemberAccess.DoResolve): Likewise.
149 * decl.cs (DeclSpace.Cache): Make private.
150 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
151 (DeclSpace.FindType): Update.
152 (DeclSpace.LookupType): Move here from RootContext. Return a
154 * namespace.cs (Namespace): Derive from FullNamedExpression
155 so that it can be part of expression resolution.
156 (Namespace.Lookup): Return an FullNamedExpression.
157 (NamespaceEntry.LookupAlias): Lookup aliases only in current
159 * rootcontext.cs (NamespaceLookup): Remove.
160 (LookupType): Move to DeclSpace.
161 * attribute.cs (CheckAttributeType): Update.
162 * doc.cs (FindDocumentedType): Remove allowAlias argument.
163 (FindDocumentedTypeNonArray): Likewise.
165 2005-01-11 Raja R Harinath <rharinath@novell.com>
167 Fix cs0509.cs, cs1632.cs.
168 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
169 is the same as IsInterface.
170 (TypeContainer.GetClassBases): Likewise.
171 * statement.cs (LabeledStatement.ig): New field.
172 (LabeledStatement.LabelTarget): Save ILGenerator which created the
174 (LabeledStatement.DoEmit): Check that the label was created with
175 the same ILGenerator.
177 2005-01-10 Marek Safar <marek.safar@seznam.cz>
180 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
181 accessors to its properties.
183 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
184 from accessors to property.
186 2005-01-10 Marek Safar <marek.safar@seznam.cz>
189 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
192 2005-01-08 Miguel de Icaza <miguel@ximian.com>
194 * attribute.cs: Check for null and empty strings.
196 I have lost another battle to Paolo.
198 2005-01-07 Marek Safar <marek.safar@seznam.cz>
201 * class.cs (PropertyMethod): Set Parent field in ctors.
202 (SetMethod.InternalParameters): Add unsafe switch hack.
203 Override MarkForDuplicationCheck where it is appropriate.
205 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
206 It says whether container allows members with the same name.
208 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
209 Removed is_method parameter.
211 2005-01-06 Duncan Mak <duncan@ximian.com>
213 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
214 because the previous change led to incorrect reporting of CS1032
215 ("Cannot define/undefine preprocessor symbols after first token in
216 file"). Instead of using `tokens_seen' as the only flag that
217 triggers CS1040, introduce `comments_seen'. This new flag is used
218 to signify having seen comments on the current line, so it is
219 unset after a newline.
221 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
223 * doc.cs : When searching for a type, find nested type too.
224 This fixes bug #71040.
226 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
229 - Warn missing member comment on those classes which also does not
230 have doc comments. Fixed bug #71041.
231 - Don't warn missing doc comment on default constructor.
234 2005-01-06 Duncan Mak <duncan@ximian.com>
236 * cs-tokenizer.cs (xtoken): After handling traditional C-style
237 comments, set `tokens_seen' to true. This allows us to detect
238 misplaced preprocessor directives (i.e. not at the beginning of
239 the a line, nor after whitespaces). In that case, report error
240 CS1040. This fixes bug #56460.
242 * cs-parser.jay (interface_member_declaration): Add checks for
243 IsExplicitImpl, and report CS0541 error if an interface member is
244 defined as an explicit interface declaration.
246 2005-01-06 Marek Safar <marek.safar@seznam.cz>
249 * class.cs (PropertyMethod): Set Parent field in ctors.
250 (SetMethod.InternalParameters): Add unsafe switch hack.
252 * decl.cs (MemberCore.Parent): Cannot be readonly.
254 2005-01-06 Raja R Harinath <rharinath@novell.com>
256 * decl.cs (DeclSpace.ResolveType): Remove.
257 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
258 Merge in code from ...
259 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
260 * class.cs, enum.cs: Update to changes.
262 2005-01-06 Miguel de Icaza <miguel@ximian.com>
264 * anonymous.cs: Ensure that we init the scope of our parent if it
265 has not been initialized yet.
267 2004-12-30 Duncan Mak <duncan@ximian.com>
269 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
270 if field.FieldBuilder is null. Fixes #70758.
272 * convert.cs: Fixed some typos and updated some of the comments.
273 (ImplicitStandardConversionExists):
274 (TryImplicitIntConversion): If `target_type' is an interface and
275 the type of `ic' implements this interface, return true or a new
276 BoxedCast instead of null. This fixes #70468.
278 2004-12-29 Duncan Mak <duncan@ximian.com>
280 * expression.cs (Argument.Emit): Check that Expr is
281 IMemoryLocation before casting to it, and report CS1510 otherwise.
285 2004-12-21 Ben Maurer <bmaurer@ximian.com>
287 * statement.cs (Block.ThisVariable): remove the recursion here, to
288 make the --profile more sane.
290 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
292 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
293 assembly, by JB Evain.
295 2004-12-17 Raja R Harinath <rharinath@novell.com>
297 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
298 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
299 "parent" refers to enclosing type/class. "base" refers to superclass.
301 2004-12-17 Raja R Harinath <rharinath@novell.com>
303 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
304 Ensure that we only have GlobalAttributes.
305 * attribute.cs (Attribute.Emit): Make non-virtual.
306 (GlobalAttribute.Emit): Remove.
307 (Attribute.Resolve): Make virtual.
308 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
309 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
310 the argument. Don't create one.
311 (Attribute.GetObsoleteAttribute): Likewise.
312 (Attribute.GetClsCompliantAttributeValue): Likewise.
313 * class.cs, decl.cs: Update to changes.
315 2004-12-17 Marek Safar <marek.safar@seznam.cz>
317 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
319 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
321 * statement.cs (Foreach.Resolve): Add error 186 report.
323 2004-12-16 Marek Safar <marek.safar@seznam.cz>
325 * expression.cs (Conditional.DoResolve): Add warning 429.
327 * statement.cs (If.Resolve): Add warning 665.
329 2004-12-16 Raja R Harinath <rharinath@novell.com>
331 New invariant: RootContext.Tree.Types.NamespaceEntry == null
332 except when in the parser, and in GlobalAttribute.
333 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
334 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
335 RootContext.Tree.Types.NamespaceEntry once work is done.
336 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
337 and resets RootContext.Tree.Types.NamespaceEntry.
339 2004-12-15 Marek Safar <marek.safar@seznam.cz>
341 * cs-parser.jay: Don't create a block for every variable.
343 2004-12-14 Miguel de Icaza <miguel@ximian.com>
345 * location.cs: Provide extra information.
347 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
348 variables from the captured environment, it is the ldarg_0.
350 2004-12-14 Marek Safar <marek.safar@seznam.cz>
352 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
355 * class.cs: Changed warning level for 169 to avoid developer
356 displeasure from warning flooding. It will be changed back when they
357 fix most of current BCL warnings.
359 * RootContext.cs: Pushed default WarningLevel to 3.
361 * statement.cs: Removed unused variable.
363 2004-12-14 Marek Safar <marek.safar@seznam.cz>
365 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
366 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
367 Add error 502 report.
368 (StaticClass.DefineType): Add error 441 report.
369 (Class.AllowedModifiersProp): New virtual property as temporary
370 extension to AllowedModifiers.
371 (Class.DefineType): Add error 418 report. Moved ModFlags check here
372 to share implementation with StaticClass and don't call virtual
375 * driver.cs (MainDriver): Add error 1558 test.
377 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
378 report. Moved error 36 test here.
380 * statement.cs (Throw.Resolve): Add error 724 report.
382 * typemanager.cs: Add out_attribute_type core type.
384 2004-12-13 Marek Safar <marek.safar@seznam.cz>
386 * class.cs (TypeContainer.VerifyClsCompliance): Add error
388 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
390 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
393 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
395 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
396 Add error 3023 report.
397 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
399 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
402 2004-12-12 John Luke <john.luke@gmail.com>
404 * driver.cs (AddArgs): take -- into account when
405 adding arguments, fixes bug 65710
407 2004-12-12 Martin Baulig <martin@ximian.com>
409 * expression.cs (Unary.TryReduceNegative): Added support for
410 SByteConstant and ByteConstant.
411 (Unary.Reduce): Check error values from TryReduceNegative().
413 2004-12-10 Marek Safar <marek.safar@seznam.cz>
415 * attributes.cs (Attribute.Resolve): Avoid multiple error report
416 and report exception as error 182.
418 2004-12-10 Raja R Harinath <rharinath@novell.com>
420 * driver.cs (Main): Fix message when there are warnings.
422 2004-12-09 Miguel de Icaza <miguel@ximian.com>
424 * delegate.cs: Fixed my fix from yesterday, sorry about that.
426 2004-12-09 Marek Safar <marek.safar@seznam.cz>
428 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
429 Reduced number of warnings.
431 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
433 2004-12-08 Miguel de Icaza <miguel@ximian.com>
435 * driver.cs: Removed message.
437 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
439 2004-12-08 <vargaz@freemail.hu>
441 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
443 2004-12-08 Martin Baulig <martin@ximian.com>
445 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
446 instead of a CS3002 for properties and indexer.
448 2004-12-08 Martin Baulig <martin@ximian.com>
450 * decl.cs (MemberName.ToString): Make this work again.
452 2004-12-08 Marek Safar <marek.safar@seznam.cz>
454 * attribute.cs (Resolve): Add error 591 detection.
456 * class.cs (FieldMember.Define): Add error 1547 detection.
457 (Indexer.Define): Add error 620 detection.
458 (Operator.Define): Add error 590 detection.
460 * ecore.cs: Missing argument for error 79.
462 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
465 2004-12-07 Marek Safar <marek.safar@seznam.cz>
468 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
471 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
473 * cs-parser.jay : handle doc comments on implicit/explicit operators.
474 Some operator comments were suppressed.
475 * doc.cs : Implicit/explicit operator name in doc comments are like
476 "op_Explicit(type)~returnType", so added suffix handling.
478 2004-12-07 Martin Baulig <martin@ximian.com>
481 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
482 (MemberCore.GetClsCompliantAttributeValue): Likewise.
483 (DeclSpace.ec): New protected field; store the EmitContext here.
484 (DeclSpace.EmitContext): New public property; moved here from
486 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
489 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
490 (Enum.Emit): Don't create a new EmitContext.
492 * delegate.cs (Delegate.DefineType): Always create the
495 * iterators.cs (Iterators.DefineIterator): Create a new
496 EmitContext and store it in `ec'.
498 2004-08-24 Martin Baulig <martin@ximian.com>
501 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
502 this for accessibility checks.
503 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
504 IsNestedFamilyAccessible.
505 (TypeManager.IsSubclassOf): New method, do what the name actually
508 2004-12-06 Raja R Harinath <rharinath@novell.com>
510 Fix crash on cs0657-17.cs.
511 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
512 Use RootContext.Tree.Types, not 'new RootTypes ()'.
513 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
514 the case where the NamespaceEntry gets overwritten.
516 2004-12-06 Marek Safar <marek.safar@seznam.cz>
519 * ecore.cs (ResolveBoolean): Tiny refactoring.
521 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
522 of right expression resolving when left is false constant and
523 operator is LogicalAnd OR true constant and operator is LogicalOr.
525 * statement.cs (ResolveUnreachable): Always reports warning.
527 2004-12-05 Miguel de Icaza <miguel@ximian.com>
529 * class.cs: Distinguish between 1721 and 1722 (just a little help
532 2004-12-03 Miguel de Icaza <miguel@ximian.com>
534 * delegate.cs: Only allow this on new versions of the language.
536 2004-12-02 Duncan Mak <duncan@ximian.com>
538 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
540 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
541 here as a static method. Take an additional bool out parameter
542 `must_do_cs1540_check' for signaling to InstanceResolve.
543 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
544 member field from PropertyExpr class and made it an argument of
546 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
547 check for MarshalByRefObject, and report CS0122 instead of CS1540.
548 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
549 and `remove_accessor' as well as InstanceResolve: report CS0122
554 2004-12-03 Raja R Harinath <rharinath@novell.com>
556 Fix test-327.cs, test-328.cs, and put in early infrastructure
557 for eventually fixing #52697.
558 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
559 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
561 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
562 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
563 (VerifyUsing, error246): Update.
564 * rootcontext.cs (RootContext.NamespaceLookup): Just use
565 'NamespaceEntry.LookupNamespaceOrType'.
567 2004-12-03 Martin Baulig <martin@ximian.com>
569 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
570 method as our child, call AnonymousMethod.Compatible() on it.
572 2004-12-03 Raja R Harinath <rharinath@novell.com>
574 Disable XML documentation support in 'basic' profile.
575 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
576 Redirect XmlElement to System.Object.
577 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
578 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
579 * mcs.exe.sources: Add doc-bootstrap.cs.
580 * doc-bootstrap.cs: New file. Contains empty stub implementation
583 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
585 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
586 comments are allowed.
588 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
590 * delegate.cs: Add checks for subtypes in paramaters and return values
591 in VerifyMethod () to add support for Covariance/Contravariance
594 2004-12-02 Miguel de Icaza <miguel@ximian.com>
596 * report.cs: Remove extra closing parenthesis.
598 * convert.cs (Error_CannotImplicitConversion): If the name of the
599 types are the same, provide some extra information.
601 * class.cs (FieldBase): Use an unused bit field from the field to
602 encode the `has_offset' property from the FieldMember. This saves
603 a couple of Ks on bootstrap compilation.
605 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
606 method as our child, return the AnonymousMethod resolved
609 * expression.cs (New.DoResolve): Allow return values from
610 NewDelegate to also include AnonymousMethods.
614 2004-12-02 Marek Safar <marek.safar@seznam.cz>
617 * attribute.cs (Resolve): Improved implementation of params
620 * support.cs (ParameterData): Add HasParams to be faster.
622 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
624 all things are for /doc support:
626 * doc.cs: new file that supports XML documentation generation.
627 * mcs.exe.sources: added doc.cs.
629 Handle /doc command line option.
630 Report error 2006 instead of 5 for missing file name for /doc.
631 Generate XML documentation when required, after type resolution.
633 Added support for picking up documentation (/// and /** ... */),
634 including a new XmlCommentState enumeration.
636 Added lines to fill Documentation element for field, constant,
637 property, indexer, method, constructor, destructor, operator, event
638 and class, struct, interface, delegate, enum.
639 Added lines to warn incorrect comment.
641 Added Documentation field (passed only when /doc was specified).
643 Added DocComment, DocCommentHeader, GenerateDocComment() and
644 OnGenerateDocComment() and some supporting private members for
645 /doc feature to MemberCore.
647 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
649 Added overriden DocCommentHeader.
651 Added overriden DocCommentHeader and GenerateDocComment().
653 2004-12-01 Miguel de Icaza <miguel@ximian.com>
655 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
656 unwrapping the enumeration values, chain to
657 DoConstantNumericPromotions again, so we can promote things to the
658 fundamental types (takes care of enums that are bytes, sbytes).
662 2004-12-01 Raja R Harinath <rharinath@novell.com>
664 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
665 Fix long-standing bug in type-lookup. Use FindType instead of
666 LookupType when ec.ResolvingTypeTree.
667 (Attribute.ResolveType, Attribute.Resolve)
668 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
670 (Attributes.Search): Remove internal version. Update.
671 (Attributes.SearchMulti): Update.
672 (Attributes.GetClsCompliantAttribute): Remove.
673 (Attributes.GetIndexerNameAttribute): Remove.
674 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
675 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
676 * class.cs (Indexer.Define): Likewise.
678 2004-12-01 Marek Safar <marek.safar@seznam.cz>
681 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
682 MarshallByReference members access.
684 * expression.cs: Use CheckMarshallByRefAccess;
685 Better error CS0197 message.
687 * report.cs: Print whole related error message.
689 2004-11-30 Raja R Harinath <rharinath@novell.com>
691 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
692 the current directory to help debugging.
694 2004-11-29 Marek Safar <marek.safar@seznam.cz>
696 * class (GetClassBases): Better error 60 report.
697 (EventProperty): Disabled warning 67 detection.
699 2004-11-29 Marek Safar <marek.safar@seznam.cz>
702 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
704 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
707 2004-11-29 Marek Safar <marek.safar@seznam.cz>
710 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
712 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
714 2004-11-26 Miguel de Icaza <miguel@ximian.com>
716 * attribute.cs (Attribute.Resolve): Refine error reporting and
717 report a cs0117 if the identifier does not exist, to distinguish
718 from 0617 which is a miss-use of the actual identifier.
720 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
721 between cs0070 and cs0079.
723 * class.cs (MemberBase.DoDefine): When reporting a wrong
724 accessibility level, we use MethodCore to compare instead of
725 Method (this was a regression in some refactoring effort).
727 So now we correctly report cs0056 again.
729 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
730 testing the target_type (which was known to be object_type) and
731 not the source type (which is anonymous_method).
733 Fixed reporting of error cs1660.
735 * expression.cs (UserCast.Source): Expose the underlying cast.
737 * statement.cs (Switch.SwitchGoverningType): Sort the list of
738 allowed types to find a match to int32 first (most common).
740 In addition, it ignores any ImplicitUserConversions that did an
741 internal implicit conversion (as the switch statement allows only
742 one integral conversion to exist).
744 * class.cs (PartialContainer.Create): rename `name' to
745 `member_name' for clarity. Then replace the string calls with a
746 call to MemberName.GetPartialName, as now using
747 MemberName.ToString is an error (this is due to the side effects
748 it had, that were fixed in the past).
750 This will restore the error reporting on a number of partial class
751 errors that were missusing this (and getting an exception as a
752 results, which is now just a plain textual warning, because
753 yyparse debug output would crash otherwise).
755 2004-11-26 Raja R Harinath <rharinath@novell.com>
757 * Makefile (PROGRAM_INSTALL_DIR): Remove.
759 2004-11-25 Ben Maurer <bmaurer@ximian.com>
761 * rootcontext.cs (LookupType): Make sure to cache lookups that
762 don't give us a negative result. This saves about 5% of corlib
765 2004-11-25 Miguel de Icaza <miguel@ximian.com>
767 * report.cs (AbstractMessage.Print): messages are sent to stderr
769 * class.cs (TypeContainer.GetClassBases): It is an error to have a
770 non-interface in the list of interfaces (at this point, either
771 parent was properly set, or a base class is being listed in the
774 This flags error 1722, and resolves the crash from bug 69259.
776 2004-11-25 Ben Maurer <bmaurer@ximian.com>
778 * statement.cs (Using.EmitExpressionFinally): make this work right
779 for valuetypes. Fixes 69926.
781 2004-11-25 Miguel de Icaza <miguel@ximian.com>
783 * const.cs (Const.ChangeType): Cope with the "0 literal can be
784 converted to an enum" here, before we try to change the underlying
785 type. This code exists, but it is a different code path than the
786 one used while encoding constants.
788 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
789 old bug: when converting from the null literal to a pointer,
790 return an EmptyCast, not the NullLiteral.
792 This fixes #69921, the recent null_type changes probably made this
795 (ImplicitReferenceConversionExists): In addition, resynchronized
796 the code here, so it matches the same code in
797 ImplicitReferenceConversionExists for the `from any class-type S
798 to any interface-type T'.
801 2004-11-25 Marek Safar <marek.safar@seznam.cz>
803 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
805 2004-11-24 Miguel de Icaza <miguel@ximian.com>
807 * cs-parser.jay: Use verbosity accordingly.
809 2004-11-24 Marek Safar <marek.safar@seznam.cz>
811 * expression.cs (Unary.ResolveOperator): Do not report warning;
812 AddressOf reads from variable.
814 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
816 2004-11-24 Marek Safar <marek.safar@seznam.cz>
820 * attribute.cs (Attributable): Removed CheckTargets.
821 (Attributes.Emit): Explicit attribute targets are tested here.
823 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
824 not enabled for interfaces.
826 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
827 (GetAssemblyName): Ouch next bug there.
829 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
831 * expression.cs: Error 275 added.
833 2004-11-23 Marek Safar <marek.safar@seznam.cz>
835 Fix bug #69177 (Implemented decimal constant support)
837 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
838 (BinaryFold): Add DecimalConstant.
840 * const.cs (Define): Decimal constant
842 (ChangeType): Add decimal type handling.
843 (LookupConstantValue): Don't set value for decimal type but
844 emit DecimalConstantAttribute. Needed for constant optimization.
846 * constant.cs (ToDecimal): New method.
847 (ConvertToDecimal): New method.
848 (IntConstant): Implemented ConvertToDecimal.
849 (DecimalConstant.Emit): Emit optimized version for decimals in
852 * expression.cs (ResolveOperator): Changed order of constant
853 reduction to work correctly with native types which have
854 overloaded operators.
855 (ResolveMemberAccess): Extract constant value from attribute
858 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
860 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
861 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
862 (ChangeType): Decimal is special.
863 (TypeToCoreType): Add decimal type.
865 2004-11-22 Marek Safar <marek.safar@seznam.cz>
867 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
870 2004-11-22 Marek Safar <marek.safar@seznam.cz>
872 * class.cs (EventField.ApplyAttributeBuilder): Fix error
875 2004-11-19 Marek Safar <marek.safar@seznam.cz>
877 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
879 * pending.cs (PendingImplementation): Grab only interfaces.
881 2004-11-19 Marek Safar <marek.safar@seznam.cz>
883 * statement.cs (ForeachHelperMethods): Add location member and
886 2004-11-19 Raja R Harinath <rharinath@novell.com>
888 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
889 automatically handled by executable.make.
890 (PROGRAM): Make profile-specific.
892 2004-11-18 Marek Safar <marek.safar@seznam.cz>
894 * expression.cs (DoResolveBase): Fixed wrong warning for out
897 2004-11-18 Martin Baulig <martin@ximian.com>
899 Merged latest changes into gmcs. Please keep this comment in
900 here, it makes it easier for me to see what changed in MCS since
901 the last time I merged.
903 2004-11-17 Raja R Harinath <rharinath@novell.com>
905 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
906 (TypeHandle.GetMemberCache): New.
907 (TypeHandle.TypeHandle): Update.
908 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
909 (TypeManager.LookupParentInterfacesCache):
910 Rename from LookupInterfaceCache. Optimize slightly.
911 (TypeManager.MemberLookup_FindMembers): Update.
912 * decl.cs (MemberCache.MemberCache): Set Container to null in the
914 (AddCacheContents): Rename from AddHashtable.
915 * class.cs (TypeContainer.parent_container): Remove.
916 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
917 (TypeContainer.DoDefineMembers): Don't initialize it.
918 Update to name changes.
920 2004-11-17 Miguel de Icaza <miguel@ximian.com>
922 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
923 that factors the code to check access modifiers on override.
925 (PropertyBase): Use the code here.
927 Patch from Lluis S'anchez, fixes bug #69361.
929 2004-11-15 Miguel de Icaza <miguel@ximian.com>
931 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
932 routine that is used to report the use of a captured variable
933 whose address has been taken.
935 There are two checks: one when variables are being captured and
936 the other check is when the address of a variable is taken.
938 (because an anonymous methods might be resolved before *or* after
939 the address has been taken) and
941 * expression.cs (Conditional.DoResolve): Remove the special
942 casing that Martin added to trueExpr and falseExpr being both
943 NullLiteral. We get the right behavior now just by introducing
944 the null_type into the compiler.
946 * convert.cs (ExplicitConversion): Change the code to use
947 null_type instead of testing `expr is NullLiteral'.
948 (ImplicitConversionStandard): use null_type too.
949 (ImplicitReferenceConversionExists): use null_type too.
950 (ImplicitReferenceConversion): use null_type too.
952 * literal.cs: The type of `NullLiteral' is now null_type instead
954 (Resolve): Set the type here.
956 * typemanager.cs: Introduce null_type.
958 2004-11-17 Martin Baulig <martin@ximian.com>
960 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
961 direction, like FindMembers() does. Fixes #69546, testcase is in
964 2004-11-16 Martin Baulig <martin@ximian.com>
966 This is based on a patch from Marek Safar, see bug #69082.
967 Fixes bugs #63705 and #67130.
969 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
970 method; create a MemberCache for an interface type and cache the
973 * decl.cs (IMemberContainer.ParentContainer): Removed.
974 (IMemberContainer.ParentCache): New property.
975 (MemberCache.SetupCacheForInterface): Removed.
976 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
977 to create a cache for an interface's "parent".
979 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
982 2004-11-16 Martin Baulig <martin@ximian.com>
984 Merged back from gmcs; these changes already went into gmcs a
988 (TypeManager.AddUserType): Removed the `ifaces' argument.
989 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
991 (TypeManager.AddUserInterface): Removed.
992 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
994 (TypeManager.GetInterfaces): Likewise.
995 (TypeManager.GetExplicitInterfaces): Likewise.
997 * ecore.cs (TypeExpr.GetInterfaces): Removed.
999 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
1000 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
1002 2004-11-14 Ben Maurer <bmaurer@ximian.com>
1004 * statement.cs: Avoid adding bools to a hashtable.
1006 2004-11-07 Miguel de Icaza <miguel@ximian.com>
1008 * expression.cs (Invocation.OverloadResolve): Flag error if we are
1009 calling an unsafe method from a safe location.
1011 2004-11-06 Marek Safar <marek.safar@seznam.cz>
1014 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
1016 2004-11-06 Miguel de Icaza <miguel@ximian.com>
1018 * namespace.cs (VerifyUsing): use GetPartialName instead of
1021 2004-11-05 Miguel de Icaza <miguel@ximian.com>
1023 * statement.cs (Return.Resolve): Fix regression in typo: if
1024 `in_exc', we have to request a NeedReturnLabel, this was a typo
1025 introduced in the anonymous method check-in. Fixes #69131.
1027 * Indexers were using the ShortName when defining themselves,
1028 causing a regression in the compiler bootstrap when applying the
1029 patch from 2004-11-02 (first part), now they use their full name
1030 and the bug is gone.
1032 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
1034 * driver.cs: Strip the path from the names of embedded resources. Fixes
1037 2004-11-04 Raja R Harinath <rharinath@novell.com>
1039 Fix error message regression: cs0104-2.cs.
1040 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
1041 (AliasEntry.Resolve): Update.
1042 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
1044 (RootContext.LookupType): Update.
1046 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
1048 * cs-parser.jay: Add support for handling accessor modifiers
1049 * class: Add support port accessor modifiers and error checking,
1050 define PropertyMethod.Define as virtual (not abstract anymore)
1051 * ecore.cs: Add checking for proeprties access with access modifiers
1052 * iterators.cs: Modify Accessor constructor call based in the modified
1054 2004-11-02 Ben Maurer <bmaurer@ximian.com>
1056 * expression.cs (StringConcat): Handle being called twice,
1057 as when we have a concat in a field init with more than two
1060 2004-11-02 Miguel de Icaza <miguel@ximian.com>
1062 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
1063 special case explicit implementations, we should always produce
1064 the .property or .event declaration.
1066 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
1067 since it will not return correct data if people use this
1068 unresolved in the presence of using statements (see test-313).
1070 * class.cs (MethodData.Define): If we are an explicit interface
1071 implementation, set the method name to the full name of the
1072 interface plus the name of the method.
1074 Notice that using the method.MethodName.GetFullName() does not
1075 work, as it will only contain the name as declared on the source
1076 file (it can be a shorthand in the presence of using statements)
1077 and not the fully qualifed type name, for example:
1081 class D : ICloneable {
1082 object ICloneable.Clone () {
1086 Would produce a method called `ICloneable.Clone' instead of
1087 `System.ICloneable.Clone'.
1089 * namespace.cs (Alias.Resolve): Use GetPartialName.
1091 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1093 * cs-parser.jay: Add error 1055 report.
1095 2004-11-01 Miguel de Icaza <miguel@ximian.com>
1097 * assign.cs (Assign.DoResolve): Only do the transform of
1098 assignment into a New if the types are compatible, if not, fall
1099 through and let the implicit code deal with the errors and with
1100 the necessary conversions.
1102 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1104 * cs-parser.jay: Add error 1031 report.
1106 * cs-tokenizer.cs: Add location for error 1038.
1108 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1110 * cs-parser.jay: Add error 1016 report.
1112 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1114 * cs-parser.jay: Add errors 1575,1611 report.
1116 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1118 * cs-parser.jay: Add error 1001 report.
1120 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1123 * attribute.cs (GetMarshal): Add method argument for
1124 caller identification.
1126 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
1127 agument for GetMarshal and RuntimeMissingSupport.
1129 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1131 * attribute.cs (ExtractSecurityPermissionSet): Removed
1132 TypeManager.code_access_permission_type.
1134 * typemanager.cs: Removed TypeManager.code_access_permission_type.
1136 2004-10-27 Miguel de Icaza <miguel@ximian.com>
1138 * expression.cs (LocalVariableReference.DoResolveLValue): Check
1139 for obsolete use of a variable here. Fixes regression on errors
1140 cs0619-25 and cs0619-26.
1142 2004-10-27 Marek Safar <marek.safar@seznam.cz>
1144 Fix #62358, implemented security attribute encoding.
1146 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
1147 Tests permitted SecurityAction for assembly or other types.
1148 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
1149 data from SecurityPermissionAttribute to PermisionSet class.
1151 * class.cs (ApplyAttributeBuilder): Added special handling
1152 for System.Security.Permissions.SecurityAttribute based types.
1154 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
1155 special handling for System.Security.Permissions.SecurityAttribute
1158 * enum.cs (ApplyAttributeBuilder): Added special handling
1159 for System.Security.Permissions.SecurityAttribute based types.
1161 * parameter.cs (ApplyAttributeBuilder): Added special handling
1162 for System.Security.Permissions.SecurityAttribute based types.
1164 * rootcontext.cs: Next 2 core types.
1166 * typemanager.cs (TypeManager.security_permission_attr_type):
1167 Built in type for the SecurityPermission Attribute.
1168 (code_access_permission_type): Build in type.
1170 2004-10-17 Miguel de Icaza <miguel@ximian.com>
1172 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
1173 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
1174 all of this information into
1175 EmitContext.EmitCapturedVariableInstance.
1177 * codegen.cs (EmitCapturedVariableInstance): move here the
1178 funcionality of emitting an ldarg.0 in the presence of a
1179 remapping. This centralizes the instance emit code.
1181 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
1182 then emit a load of this: it means that we have reached the
1183 topmost ScopeInfo: the one that contains the pointer to the
1184 instance of the class hosting the anonymous method.
1186 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
1187 captures to the topmost CaptureContext.
1189 2004-10-12 Miguel de Icaza <miguel@ximian.com>
1191 * expression.cs (LocalVariableReference): Move the knowledge about
1192 the iterators into codegen's EmitCapturedVariableInstance.
1194 2004-10-11 Miguel de Icaza <miguel@ximian.com>
1196 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
1197 all code paths return a value from an anonymous method (it is the
1198 same as the 161 error, but for anonymous methods).
1200 2004-10-08 Miguel de Icaza <miguel@ximian.com>
1202 The introduction of anonymous methods in the compiler changed
1203 various ways of doing things in the compiler. The most
1204 significant one is the hard split between the resolution phase
1205 and the emission phases of the compiler.
1207 For instance, routines that referenced local variables no
1208 longer can safely create temporary variables during the
1209 resolution phase: they must do so from the emission phase,
1210 since the variable might have been "captured", hence access to
1211 it can not be done with the local-variable operations from the runtime.
1215 (Block.Flags): New flag `IsTopLevel' to indicate that this block
1216 is a toplevel block.
1218 (ToplevelBlock): A new kind of Block, these are the blocks that
1219 are created by the parser for all toplevel method bodies. These
1220 include methods, accessors and anonymous methods.
1222 These contain some extra information not found in regular blocks:
1223 A pointer to an optional CaptureContext (for tracking captured
1224 local variables and parameters). A pointer to the parent
1227 (Return.Resolve): Catch missmatches when returning a value from an
1228 anonymous method (error 1662).
1229 Invoke NeedReturnLabel from the Resolve phase instead of the emit
1232 (Break.Resolve): ditto.
1234 (SwitchLabel): instead of defining the labels during the
1235 resolution phase, we now turned the public ILLabel and ILLabelCode
1236 labels into methods called GetILLabelCode() and GetILLabel() that
1237 only define the label during the Emit phase.
1239 (GotoCase): Track the SwitchLabel instead of the computed label
1240 (its contained therein). Emit the code by using
1241 SwitchLabel.GetILLabelCode ().
1243 (LocalInfo.Flags.Captured): A new flag has been introduce to track
1244 whether the Local has been captured or not.
1246 (LocalInfo.IsCaptured): New property, used to tell whether the
1247 local has been captured.
1249 * anonymous.cs: Vastly updated to contain the anonymous method
1252 The main classes here are: CaptureContext which tracks any
1253 captured information for a toplevel block and ScopeInfo used to
1254 track the activation frames for various local variables.
1256 Each toplevel block has an optional capture context associated
1257 with it. When a method contains an anonymous method both the
1258 toplevel method and the anonymous method will create a capture
1259 context. When variables or parameters are captured, they are
1260 recorded on the CaptureContext that owns them, for example:
1264 MyDelegate d = delegate {
1269 Here `a' will be recorded as captured on the toplevel
1270 CapturedContext, the inner captured context will not have anything
1271 (it will only have data if local variables or parameters from it
1272 are captured in a nested anonymous method.
1274 The ScopeInfo is used to track the activation frames for local
1275 variables, for example:
1277 for (int i = 0; i < 10; i++)
1278 for (int j = 0; j < 10; j++){
1279 MyDelegate d = delegate {
1284 At runtime this captures a single captured variable `i', but it
1285 captures 10 different versions of the variable `j'. The variable
1286 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
1287 recorded on a child.
1289 The toplevel ScopeInfo will also track information like the `this'
1290 pointer if instance variables were referenced (this is necessary
1291 as the anonymous method lives inside a nested class in the host
1292 type of the method).
1294 (AnonymousMethod): Expanded to track the Toplevel, implement
1295 `AnonymousMethod.Compatible' to tell whether an anonymous method
1296 can be converted to a target delegate type.
1298 The routine now also produces the anonymous method content
1300 (AnonymousDelegate): A helper class that derives from
1301 DelegateCreation, this is used to generate the code necessary to
1302 produce the delegate for the anonymous method that was created.
1304 * assign.cs: API adjustments for new changes in
1305 Convert.ImplicitStandardConversionExists.
1307 * class.cs: Adjustments to cope with the fact that now toplevel
1308 blocks are of type `ToplevelBlock'.
1310 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
1311 insteda of standard blocks.
1313 Flag errors if params arguments are passed to anonymous methods.
1315 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
1316 `CurrentAnonymousMethod' which points to the current Anonymous
1317 Method. The variable points to the AnonymousMethod class that
1318 holds the code being compiled. It is set in the new EmitContext
1319 created for the anonymous method.
1321 (EmitContext.Phase): Introduce a variable and an enumeration to
1322 assist in enforcing some rules about when and where we are allowed
1323 to invoke certain methods (EmitContext.NeedsReturnLabel is the
1324 only one that enfonces this right now).
1326 (EmitContext.HaveCaptureInfo): new helper method that returns
1327 whether we have a CapturedContext initialized.
1329 (EmitContext.CaptureVariable): New method used to register that a
1330 LocalInfo must be flagged for capturing.
1332 (EmitContext.CapturedParameter): New method used to register that a
1333 parameters must be flagged for capturing.
1335 (EmitContext.CapturedField): New method used to register that a
1336 field must be flagged for capturing.
1338 (EmitContext.HaveCapturedVariables,
1339 EmitContext.HaveCapturedFields): Return whether there are captured
1340 variables or fields.
1342 (EmitContext.EmitMethodHostInstance): This is used to emit the
1343 instance for the anonymous method. The instance might be null
1344 (static methods), this (for anonymous methods that capture nothing
1345 and happen to live side-by-side with the current method body) or a
1346 more complicated expression if the method has a CaptureContext.
1348 (EmitContext.EmitTopBlock): Routine that drives the emission of
1349 code: it will first resolve the top block, then emit any metadata
1350 and then emit the code. The split is done so that we can extract
1351 any anonymous methods and flag any captured variables/parameters.
1353 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
1354 during this phase, the ILGenerator should not be used as labels
1355 and local variables declared here might not be accessible to any
1356 code that is part of an anonymous method.
1358 Exceptions to this include the temporary variables that are
1359 created by some statements internally for holding temporary
1362 (EmitContext.EmitMeta): New routine, in charge of emitting all the
1365 (EmitContext.TemporaryReturn): This method is typically called
1366 from the Emit phase, and its the only place where we allow the
1367 ReturnLabel to be defined other than the EmitMeta. The reason is
1368 that otherwise we would have to duplicate a lot of logic in the
1369 Resolve phases of various methods that today is on the Emit
1372 (EmitContext.NeedReturnLabel): This no longer creates the label,
1373 as the ILGenerator is not valid during the resolve phase.
1375 (EmitContext.EmitThis): Extended the knowledge in this class to
1376 work in anonymous methods in addition to iterators.
1378 (EmitContext.EmitCapturedVariableInstance): This emits whatever
1379 code is necessary on the stack to access the instance to a local
1380 variable (the variable will be accessed as a field).
1382 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
1383 EmitContext.EmitAddressOfParameter): Routines to support
1384 parameters (not completed at this point).
1386 Removals: Removed RemapLocal and RemapLocalLValue. We probably
1387 will also remove the parameters.
1389 * convert.cs (Convert): Define a `ConstantEC' which points to a
1390 null. This is just to prefity some code that uses
1391 ImplicitStandardConversion code and do not have an EmitContext
1394 The idea is to flag explicitly that at that point in time, it is
1395 known that the conversion will not trigger the delegate checking
1396 code in implicit conversions (which requires a valid
1399 Everywhere: pass new EmitContext parameter since
1400 ImplicitStandardConversionExists now requires it to check for
1401 anonymous method conversions.
1403 (Convert.ImplicitStandardConversionExists): If the type of an
1404 expression is the anonymous_method_type, and the type is a
1405 delegate, we invoke the AnonymousMethod.Compatible method to check
1406 whether an implicit conversion is possible.
1408 (Convert.ImplicitConversionStandard): Only do implicit method
1409 group conversions if the language level is not ISO_1.
1411 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
1412 MethodInfo for the Invoke method. used by Delegate and
1415 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
1416 method conversions if the target type is a delegate.
1418 Removed extra debugging nops.
1420 (LocalVariableReference): Turn the `local_info' into a public
1423 Add `prepared' field, the same hack used for FieldExprs to cope
1424 with composed assignments, as Local variables do not necessarily
1425 operate purely on the stack as they used to: they can be captured
1428 Add `temp' for a temporary result, like fields.
1430 Refactor DoResolve and DoResolveLValue into DoResolveBase.
1432 It now copes with Local variables that are captured and emits the
1433 proper instance variable to load it from a field in the captured
1436 (ParameterReference.DoResolveBase): During the resolve phase,
1437 capture parameters if we are in an anonymous method.
1439 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
1440 anonymous method, use the EmitContext helper routines to emit the
1441 parameter reference.
1443 * iterators.cs: Set RemapToProxy to true/false during the
1446 * parameters.cs (GetParameterByName): New helper method.
1448 * typemanager.cs (anonymous_method_type) a new type that
1449 represents an anonyous method. This is always an internal type,
1450 used as a fencepost to test against the anonymous-methodness of an
1453 2004-10-20 Marek Safar <marek.safar@seznam.cz>
1455 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
1457 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
1459 2004-10-18 Martin Baulig <martin@ximian.com>
1461 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
1462 `Type' directly, but call ResolveType() on it.
1463 (Catch.Resolve): Likewise.
1464 (Foreach.Resolve): Likewise.
1466 2004-10-18 Martin Baulig <martin@ximian.com>
1468 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
1469 `Type' directly, but call ResolveType() on it.
1470 (Probe.DoResolve): Likewise.
1471 (ArrayCreation.LookupType): Likewise.
1472 (TypeOf.DoResolve): Likewise.
1473 (SizeOf.DoResolve): Likewise.
1475 2004-10-18 Martin Baulig <martin@ximian.com>
1477 * expression.cs (Invocation.BetterFunction): Put back
1478 TypeManager.TypeToCoreType().
1480 2004-10-18 Raja R Harinath <rharinath@novell.com>
1482 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
1485 2004-10-18 Martin Baulig <martin@ximian.com>
1487 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
1488 `Type' directly, but call ResolveType() on it.
1490 2004-10-18 Martin Baulig <martin@ximian.com>
1492 * class.cs (FieldMember.Define): Don't access the TypeExpr's
1493 `Type' directly, but call ResolveType() on it.
1494 (MemberBase.DoDefine): Likewise.
1496 * expression.cs (New.DoResolve): Don't access the TypeExpr's
1497 `Type' directly, but call ResolveType() on it.
1498 (ComposedCast.DoResolveAsTypeStep): Likewise.
1500 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
1501 `Type' directly, but call ResolveType() on it.
1503 2004-10-17 John Luke <john.luke@gmail.com>
1505 * class.cs (Operator.GetSignatureForError): use CSharpName
1507 * parameter.cs (Parameter.GetSignatureForError): Returns
1508 correct name even if was not defined.
1510 2004-10-13 Raja R Harinath <rharinath@novell.com>
1513 * class.cs (TypeContainer.EmitContext): New property.
1514 (DefineNestedTypes): Create an emitcontext for each part.
1515 (MethodCore.DoDefineParameters): Use container's emitcontext.
1516 Pass type array to InternalParameters.
1517 (MemberBase.DoDefine): Use container's emitcontext.
1518 (FieldMember.Define): Likewise.
1519 (Event.Define): Likewise.
1520 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1521 Pass type array to InternalParameters.
1522 (SetIndexerMethod.GetParameterInfo): Likewise.
1523 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1524 * delegate.cs (Define): Pass emitcontext to
1525 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1526 array to InternalParameters.
1527 * expression.cs (ParameterReference.DoResolveBase): Pass
1528 emitcontext to GetParameterInfo.
1529 (ComposedCast.DoResolveAsTypeStep): Remove check on
1530 ec.ResolvingTypeTree.
1531 * parameter.cs (Parameter.Resolve): Change argument to
1532 EmitContext. Use ResolveAsTypeTerminal.
1533 (Parameter.GetSignature): Change argument to EmitContext.
1534 (Parameters.ComputeSignature): Likewise.
1535 (Parameters.ComputeParameterTypes): Likewise.
1536 (Parameters.GetParameterInfo): Likewise.
1537 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1538 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1539 * support.cs (InternalParameters..ctor): Remove variant that takes
1541 * typemanager.cs (system_intptr_expr): New.
1542 (InitExpressionTypes): Initialize it.
1544 2004-10-12 Chris Toshok <toshok@ximian.com>
1546 * cs-parser.jay: fix location for try_statement and catch_clause.
1548 2004-10-11 Martin Baulig <martin@ximian.com>
1550 * report.cs: Don't make --fatal abort on warnings, we have
1551 -warnaserror for that.
1553 2004-10-07 Raja R Harinath <rharinath@novell.com>
1555 More DeclSpace.ResolveType avoidance.
1556 * decl.cs (MemberCore.InUnsafe): New property.
1557 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1558 with newly created EmitContext.
1559 (FieldMember.Define): Likewise.
1560 * delegate.cs (Delegate.Define): Likewise.
1561 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1562 only if normal name-lookup fails.
1563 (TypeExpr.DoResolve): Enable error-checking.
1564 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
1565 (SizeOf.DoResolve): Likewise.
1566 (ComposedCast.DoResolveAsTypeStep): Likewise.
1567 (StackAlloc.DoResolve): Likewise.
1568 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
1569 (Block.Unsafe): New property.
1570 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
1571 (Unsafe): Set 'unsafe' flag of contained block.
1572 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
1573 (Fixed.Resolve): Likewise.
1574 (Catch.Resolve): Likewise.
1575 (Using.ResolveLocalVariableDecls): Likewise.
1576 (Foreach.Resolve): Likewise.
1578 2004-10-05 John Luke <john.luke@gmail.com>
1580 * cs-parser.jay: add location to error CS0175
1582 2004-10-04 Miguel de Icaza <miguel@ximian.com>
1584 * ecore.cs (Expression.Constantity): Add support for turning null
1587 * const.cs (Const.Define): Allow constants to be reference types
1588 as long as the value is Null.
1590 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
1592 * namespace.cs (NamespaceEntry.Using): No matter which warning
1593 level is set, check if this namespace name has already been added.
1595 2004-10-03 Ben Maurer <bmaurer@ximian.com>
1597 * expression.cs: reftype [!=]= null should always use br[true,false].
1600 2004-10-03 Marek Safar <marek.safar@seznam.cz>
1603 * attribute.cs: Enum conversion moved to
1604 GetAttributeArgumentExpression to be applied to the all
1607 2004-10-01 Raja R Harinath <rharinath@novell.com>
1609 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
1610 * class.c (TypeContainer.DefineType): Flag error if
1611 base types aren't accessible due to access permissions.
1612 * decl.cs (DeclSpace.ResolveType): Move logic to
1613 Expression.ResolveAsTypeTerminal.
1614 (DeclSpace.ResolveTypeExpr): Thin layer over
1615 Expression.ResolveAsTypeTerminal.
1616 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
1617 Refactor code into NestedAccess. Use it.
1618 (DeclSpace.NestedAccess): New.
1619 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
1620 argument to silence errors. Check access permissions.
1621 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
1622 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
1623 (Cast.DoResolve): Likewise.
1624 (New.DoResolve): Likewise.
1625 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
1626 (TypeOf.DoResolve): Likewise.
1628 * expression.cs (Invocation.BetterConversion): Return the Type of
1629 the better conversion. Implement section 14.4.2.3 more faithfully.
1630 (Invocation.BetterFunction): Make boolean. Make correspondence to
1631 section 14.4.2.2 explicit.
1632 (Invocation.OverloadResolve): Update.
1633 (Invocation): Remove is_base field.
1634 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
1635 (Invocation.Emit): Likewise.
1637 2004-09-27 Raja R Harinath <rharinath@novell.com>
1639 * README: Update to changes.
1641 2004-09-24 Marek Safar <marek.safar@seznam.cz>
1643 * cs-parser.jay: Reverted 642 warning fix.
1645 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1648 * decl.cs (FindMemberWithSameName): Indexer can have more than
1651 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1653 * expression.cs (LocalVariableReference.DoResolveLValue):
1654 Do not report warning 219 for out values.
1655 (EmptyExpression.Null): New member to avoid extra allocations.
1657 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1659 * cs-parser.jay: Fix wrong warning 642 report.
1661 * cs-tokenizer.cs (CheckNextToken): New helper;
1662 Inspect next character if is same as expected.
1664 2004-09-23 Martin Baulig <martin@ximian.com>
1666 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1667 (Convert.ImplicitReferenceConversionExists): Likewise.
1669 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1671 * class.cs (Operator.Define): Add error 448 and 559 report.
1673 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1675 * class.cs (MemberBase.IsTypePermitted): New protected
1676 method for checking error CS0610.
1678 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1680 * class.cs (TypeContainer.HasExplicitLayout): New property
1681 Returns whether container has StructLayout attribute set Explicit.
1682 (FieldMember): New abstract class for consts and fields.
1683 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1684 (Field): Reuse FieldMember.
1686 * const.cs (Const): Reuse FieldMember.
1688 * rootcontext.cs: EmitConstants call moved to class.
1690 2004-09-22 Martin Baulig <martin@ximian.com>
1692 Thanks to Peter Sestoft for this bug report.
1694 * expression.cs (Conditional): If both the `trueExpr' and the
1695 `falseExpr' is a NullLiteral, return a NullLiteral.
1697 2004-09-22 Martin Baulig <martin@ximian.com>
1699 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1700 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1701 for the "get_Current" call.
1703 2004-09-22 Martin Baulig <martin@ximian.com>
1705 Marek and me just fixed one of our oldest bugs: #28562 :-)
1707 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1709 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1710 we're an EnumConstant, just return that.
1711 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1712 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1713 to get the value which'll actually be written into the attribute.
1714 However, we have to use GetValue() to access the attribute's value
1717 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1719 * constant.cs (Constant.IsNegative): New abstract property
1722 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1723 (StackAlloc.DoResolve): Reused IsNegative.
1725 2004-09-21 Martin Baulig <martin@ximian.com>
1727 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
1728 if we're used in an iterator, we may be called from different
1731 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
1732 we actually have an exception block.
1734 2004-09-20 John Luke <jluke@cfl.rr.com>
1736 * class.cs, cs-parser.jay: Improve the error report for 1520:
1737 report the actual line where the error happens, not where the
1740 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
1741 Pass location information that was available elsewhere.
1743 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
1745 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
1746 runtime to delay sign assemblies.
1748 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1750 * cs-parser.jay: Do not report the stack trace, this is barely
1753 2004-08-22 John Luke <john.luke@gmail.com>
1755 * driver.cs : check that a resource id is not already used
1756 before adding it, report CS1508 if it is, bug #63637
1758 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1760 * ecore.cs: Removed dead code.
1762 2004-09-18 Marek Safar <marek.safar@seznam.cz>
1764 * class.cs: Do not report warning CS0067 on the interfaces.
1766 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1768 * cs-parser.jay: Add error 504 report.
1770 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1772 * rootcontext.cs: WarningLevel is 4 by default now.
1774 * statement.cs (Fixed.Resolve): Do not null
1777 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1780 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
1781 deep search when property is not virtual.
1782 (PropertyExpr.ResolveAccessors): Make one call for both
1785 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1788 * statement.cs: Error 152 report constains also location.
1790 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1793 * const.cs: Explicitly set constant as static.
1795 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1798 * cs-parser.jay: Add error 1017 report.
1800 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1802 Fixed bug #59980, #64224
1803 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
1805 * typemanager.cs (IsSpecialMethod): Simplified
1807 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1809 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
1810 condition with better params.
1812 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1815 * attribute.cs (Resolve): Property has to have both
1818 2004-09-14 Martin Baulig <martin@ximian.com>
1820 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1822 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1825 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1826 called and is obsolete then this member suppress message
1827 when call is inside next [Obsolete] method or type.
1829 * expression.cs: Use TestObsoleteMethodUsage member.
1831 2004-09-14 Martin Baulig <martin@ximian.com>
1833 * cs-parser.jay: Sync a bit with the GMCS version.
1835 2004-09-14 Martin Baulig <martin@ximian.com>
1837 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
1838 (CSharpParser.yacc_verbose_flag): New public field.
1840 * genericparser.cs: Removed.
1842 2004-09-14 Raja R Harinath <rharinath@novell.com>
1844 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
1846 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1848 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1850 2004-09-10 Martin Baulig <martin@ximian.com>
1852 Backported my MemberName changes from GMCS into MCS.
1854 - we are now using a special `MemberName' class instead of using
1855 strings; in GMCS, the `MemberName' also contains the type
1858 - changed the grammar rules a bit:
1859 * the old `member_name' is now a `namespace_or_type_name':
1860 The rule is that we use `namespace_or_type_name' everywhere
1861 where we expect either a "member name" (GetEnumerator) or a
1862 "member name" with an explicit interface name
1863 (IEnumerable.GetEnumerator).
1864 In GMCS, the explicit interface name may include type arguments
1865 (IEnumerable<T>.GetEnumerator).
1866 * we use `member_name' instead of just `IDENTIFIER' for
1868 The rule is that we use `member_name' wherever a member may
1869 have type parameters in GMCS.
1871 * decl.cs (MemberName): New public class.
1872 (MemberCore.MemberName): New public readonly field.
1873 (MemberCore.ctor): Take a `MemberName' argument, not a string.
1874 (DeclSpace): Likewise.
1876 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
1877 * enum.cs (Enum.ctor): Likewise.
1879 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
1881 (AliasEntry.ctor): Take a MemberName, not an Expression.
1882 (AliasEntry.UsingAlias): Likewise.
1884 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
1885 (IMethodData.MemberName): Changed type from string to MemberName.
1886 (MemberBase.ExplicitInterfaceName): Likewise.
1887 (AbstractPropertyEventMethod.SetupName): Make this private.
1888 (AbstractPropertyEventMethod.ctor): Added `string prefix'
1889 argument; compute the member name here.
1890 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
1891 on the `member.MemberName' and the `prefix'.
1893 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
1895 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
1896 thus, we get a `MemberName' instead of a `string'. These
1897 declarations may have type parameters in GMCS.
1898 (interface_method_declaration, delegate_declaration): Likewise.
1899 (class_declaration, interface_declaration): Likewise.
1900 (method_header): Use `namespace_or_type_name' instead of
1901 `member_name'. We may be an explicit interface implementation.
1902 (property_declaration, event_declaration): Likewise.
1903 (member_name): This is now just an `IDENTIFIER', not a
1904 `namespace_or_type_name'.
1905 (type_name, interface_type): Removed.
1906 (namespace_or_type_name): Return a MemberName, not an Expression.
1907 (primary_expression): Use `member_name' instead of `IDENTIFIER';
1908 call GetTypeExpression() on the MemberName to get an expression.
1909 (IndexerDeclaration.interface_type): Changed type from string to
1911 (MakeName): Operate on MemberName's instead of string's.
1913 2004-09-13 Raja R Harinath <rharinath@novell.com>
1916 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
1917 (NamespaceEntry.Lookup): Add new argument to flag if we want the
1918 lookup to avoid symbols introduced by 'using'.
1919 * rootcontext.cs (NamespaceLookup): Update.
1921 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1923 * class.cs (TypeContainer.DoDefineMembers): Do not call
1924 DefineDefaultConstructor for static classes.
1926 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1928 * attribute.cs (Attribute.Resolve): Add error 653 report.
1930 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1932 (Method.ApplyAttributeBuilder): Add error 685 report.
1933 (Operator.Define): Add error 564 report.
1935 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1937 * expression.cs (Invocation.DoResolve): Add error
1940 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1943 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1945 * class.cs (ConstructorInitializer.Resolve):
1946 Wrong error number (515->516).
1948 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1950 * class.cs (Indexer.Define): Add error 631 report.
1952 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1954 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1956 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1958 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1960 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1962 * cs-parser.jay: Added error CS0241 report.
1964 2004-09-10 Raja R Harinath <rharinath@novell.com>
1966 * cs-parser.jay (fixed_statement): Introduce a scope for the
1967 declaration in the 'fixed' statement.
1969 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1971 * cs-parser.jay: Added CS0230 error report.
1973 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1975 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1977 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1979 * expression.cs (Argument.Resolve): Added error CS0192 and
1982 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1984 C# 2.0 #pragma warning feature
1986 * cs-tokenizer.cs (PreProcessPragma): New method;
1987 Handles #pragma directive.
1989 * report.cs (WarningRegions): New class; Support
1990 class for #pragma warning directive. It tests whether
1991 warning is enabled for a given line.
1993 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1995 * const.cs: Add more descriptive error report, tahnks to
1998 2004-09-08 Marek Safar <marek.safar@seznam.cz>
2000 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
2002 2004-09-07 Miguel de Icaza <miguel@ximian.com>
2004 * expression.cs: Apply patch from Ben: Remove dead code from
2005 ArrayCreation, and remove the TurnintoConstant call in const.cs,
2006 as that code just threw an exception anwyays.
2008 * const.cs: Remove the call to the turnintoconstant, for details
2011 * literal.cs: The type of the null-literal is the null type; So
2012 we use a placeholder type (literal.cs:System.Null, defined here)
2015 * expression.cs (Conditional.DoResolve): Remove some old code that
2016 is no longer needed, conversions have been fixed.
2018 (ArrayCreationExpression.DoResolve): Return false if we fail to
2019 resolve the inner expression.
2021 2004-09-07 Raja R Harinath <rharinath@novell.com>
2024 * cs-parser.jay (delegate_declaration): Record a delegate
2025 declaration as a type declaration.
2026 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
2028 2004-09-06 Miguel de Icaza <miguel@ximian.com>
2030 * parameter.cs: Do not crash if the type can not be resolved.
2032 * expression.cs: Report errors with unsafe pointers, fixes #64896
2034 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
2036 * expression.cs: Pointer arith always needs to do a conv.i
2037 if the operand is a long. fix 65320
2039 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2041 Fixed cs0619-37.cs, cs0619-38.cs
2043 * enum.cs (GetObsoleteAttribute): Removed.
2045 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
2046 on Enum member is double staged. The first is tested member
2049 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2051 Fixed #56986, #63631, #65231
2053 * class.cs: (TypeContainer.AddToMemberContainer): New method,
2054 adds member to name container.
2055 (TypeContainer.AddToTypeContainer): New method, adds type to
2057 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
2058 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
2059 AddOperator): Simplified by reusing AddToMemberContainer.
2060 (TypeContainer.UserDefinedStaticConstructor): Changed to property
2062 (Method.CheckForDuplications): Fixed implementation to test all
2064 (MemberBase): Detection whether member is explicit interface
2065 implementation is now in constructor.
2066 (MemberBase.UpdateMemberName): Handles IndexerName.
2067 (Accessor): Changed to keep also location information.
2068 (AbstractPropertyEventMethod): Is derived from MemberCore.
2069 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
2070 will be emited or not.
2071 (PropertyBase.AreAccessorsDuplicateImplementation):
2072 Tests whether accessors are not in collision with some method.
2073 (Operator): Is derived from MethodCore to simplify common
2076 * decl.cs (Flags.TestMethodDuplication): Test for duplication
2078 (DeclSpace.AddToContainer): Adds the member to defined_names
2079 table. It tests for duplications and enclosing name conflicts.
2081 * enum.cs (EnumMember): Clean up to reuse the base structures
2083 2004-09-03 Martin Baulig <martin@ximian.com>
2085 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2086 into TypeContainer, to make partial classes work again.
2088 2004-09-03 Martin Baulig <martin@ximian.com>
2090 * rootcontext.cs (RootContext.V2): Removed.
2092 2004-03-23 Martin Baulig <martin@ximian.com>
2094 * expression.cs (Invocation.OverloadResolve): Added `bool
2095 may_fail' argument and use it instead of the Location.IsNull() hack.
2097 2004-09-03 Martin Baulig <martin@ximian.com>
2099 Merged latest changes into gmcs. Please keep this comment in
2100 here, it makes it easier for me to see what changed in MCS since
2101 the last time I merged.
2103 2004-09-03 Raja R Harinath <rharinath@novell.com>
2106 * expression.cs (BetterConversion): Don't allow either conversion
2107 to be null. Remove redundant implicit conversion test when 'q ==
2108 null' -- when this function is invoked, we already know that the
2109 implicit conversion exists.
2110 (BetterFunction): Assume that 'best' is non-null. Remove
2111 redundant reimplementation of IsApplicable when 'best' is null.
2112 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
2113 number of arguments.
2114 (IsAncestralType): Extract from OverloadResolve.
2115 (OverloadResolve): Make robust to the MethodGroupExpr being
2116 unsorted. Implement all the logic of Section 14.5.5.1, and
2117 support overloading of methods from multiple applicable types.
2118 Clean up logic somewhat. Don't pass null methods to BetterFunction.
2120 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
2121 (RealError, Warning): Append type of report to related symbol.
2123 2004-09-03 Marek Safar <marek.safar@seznam.cz>
2125 * enum.cs: Fixed CLS-Compliance checks for enum members.
2126 Error tests cs3008-8.cs, cs3014-8.cs
2128 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2130 Fixed bug #62342, #63102
2131 * class.cs: ImplementIndexer uses member.IsExplicitImpl
2132 like ImplementMethod.
2134 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2136 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2139 2004-09-02 Martin Baulig <martin@ximian.com>
2141 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2142 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2145 2004-09-01 Marek Safar <marek.safar@seznam.cz>
2147 C# 2.0 Static classes implemented
2149 * class.cs (TypeContainer): instance_constructors,
2150 initialized_fields, initialized_static_fields,
2151 default_constructor, base_inteface_types are protected to be
2152 accessible from StaticClass.
2153 (TypeContainer.DefineDefaultConstructor): New virtual method
2154 for custom default constructor generating
2155 (StaticClass): New class to handle "Static classes" feature.
2157 * cs-parser.jay: Handle static keyword on class like instance
2160 * driver.cs: Added "/langversion" command line switch with two
2161 options (iso-1, default).
2163 2004-08-31 Marek Safar <marek.safar@seznam.cz>
2165 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
2167 2004-08-31 Miguel de Icaza <miguel@ximian.com>
2169 * delegate.cs: Style.
2171 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
2173 * delegate.cs: Add seperate instance expr field for miguel.
2175 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2177 * PointerArithmetic (Resolve): make sure we are not doing
2178 pointer arith on void*. Also, make sure we are resolved
2179 by not setting eclass until resolve.
2181 All callers: Make sure that PointerArithmetic gets resolved.
2183 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2185 * ArrayCreation (LookupType): If the type does not resolve
2186 to an array, give an error.
2188 2004-08-27 Marek Safar <marek.safar@seznam.cz>
2190 * statement.cs (Try.Resolve): Fixed bug #64222
2192 2004-08-27 Martin Baulig <martin@ximian.com>
2195 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2198 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2200 * ecore.cs (Constantify): Get underlying type via
2201 System.Enum.GetUnderlyingType to avoid StackOverflow on the
2202 Windows in special cases.
2204 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2206 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
2207 for obtaining also private methods.
2208 (GetRemoveMethod): Used GetRemoveMethod (true)
2209 for obtaining also private methods.
2211 2004-08-24 Martin Baulig <martin@ximian.com>
2213 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
2214 MethodAttributes.HideBySig for operators.
2216 2004-08-23 Martin Baulig <martin@ximian.com>
2218 Back to the old error reporting system :-)
2220 * report.cs (Message): Removed.
2221 (Report.MessageData, ErrorData, WarningData): Removed.
2222 (Report.Error, Warning): Back to the old system.
2224 2004-08-23 Martin Baulig <martin@ximian.com>
2226 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
2228 * class.cs (TypeContainer.ParentContainer): New public virtual
2229 method; replaces the explicit interface implementation.
2230 (ClassPart.ParentContainer): Override.
2232 2004-08-23 Martin Baulig <martin@ximian.com>
2234 * statement.cs (Switch): Added support for constant switches; see
2235 #59428 or test-285.cs.
2237 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2240 * statement.cs (GetEnumeratorFilter): Removed useless
2241 logic because C# specs is strict. GetEnumerator must be
2244 2004-08-22 Martin Baulig <martin@ximian.com>
2246 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2247 a switch and may break, reset the barrier. Fixes #59867.
2249 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2251 CLS-Compliance speed up (~5% for corlib)
2253 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
2254 New method. Tests container for CLS-Compliant names
2256 * class.cs (TypeContainer.VerifyClsName): New method.
2257 Checks whether container name is CLS Compliant.
2258 (Constructor): Implements IMethodData.
2260 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
2261 low-case table for CLS Compliance test.
2262 (MemberCache.VerifyClsParameterConflict): New method.
2263 Checks method parameters for CS3006 error.
2265 * enum.cs (EnumMember): Is derived from MemberCore.
2266 (Enum.VerifyClsName): Optimized for better performance.
2268 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2270 * report.cs: Renamed Error_T to Error and changed all
2273 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2275 * class.cs (TypeContainer.IndexerArrayList): New inner class
2276 container for indexers.
2277 (TypeContainer.DefaultIndexerName): New constant for default
2278 indexer name. Replaced all "Item" with this constant.
2279 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
2281 * typemanager.cs (TypeManager.default_member_ctor): Cache here
2282 DefaultMemberAttribute constructor.
2284 2004-08-05 Martin Baulig <martin@ximian.com>
2286 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
2289 2004-08-05 Marek Safar <marek.safar@seznam.cz>
2291 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
2292 multi platforms problem.
2294 * compiler.csproj: Included shared files.
2296 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2298 Fix bug 60333, 55971 in the more general way
2299 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2300 Added arg_type argument for constant conversion.
2301 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
2303 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2306 * class.cs (TypeContainer ): New inner classes MethodArrayList,
2307 OperatorArrayList, MethodCoreArrayList for typecontainer
2308 containers. Changed class member types to these new types.
2309 (MethodArrayList.DefineMembers): Added test for CS0659.
2311 2004-08-04 Miguel de Icaza <miguel@ximian.com>
2313 * cfold.cs: Synchronize the folding with the code in expression.cs
2314 Binary.DoNumericPromotions for uint operands.
2316 * attribute.cs: Revert patch from Raja, it introduced a regression
2317 while building Blam-1.2.1 (hard to isolate a test case).
2319 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2323 (TypeContainer.Define): Renamed to DefineContainerMembers because of
2325 (MethodCore.parent_method): New member. The method we're overriding
2326 if this is an override method.
2327 (MethodCore.CheckBase): Moved from Method class and made common.
2328 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
2330 (MethodCore.CheckForDuplications): New abstract method. For custom
2331 member duplication search in a container
2332 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
2333 method and its return type.
2334 (Event.conflict_symbol): New member. Symbol with same name in the
2338 (MemberCache.FindMemberWithSameName): New method. The method
2339 is looking for conflict with inherited symbols.
2341 2004-08-04 Martin Baulig <martin@ximian.com>
2343 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
2345 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
2347 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2349 * report.cs (Message): New enum for better error, warning reference in
2351 (MessageData): New inner abstract class. It generally handles printing of
2352 error and warning messages.
2353 Removed unused Error, Warning, Message methods.
2355 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2357 Fix for cs0592-8.cs test
2359 (Attributable.ValidAttributeTargets): Made public.
2360 (Attribute.ExplicitTarget): New member for explicit target value.
2361 (Attribute.CheckTargets): Now we translate explicit attribute
2362 target to Target here.
2364 2004-08-03 Ben Maurer <bmaurer@ximian.com>
2366 * ecore.cs (MethodGroupExpr): new IsBase property.
2368 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
2370 * delegate.cs (DelegateCreation): store a MethodGroupExpr
2371 rather than an instance expr.
2373 (DelegateCreation.Emit): Use the method group rather than
2374 the instance expression. Also, if you have base.Foo as the
2375 method for a delegate, make sure to emit ldftn, not ldftnvirt.
2377 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
2379 (NewDelegate.DoResolve): Only check for the existance of Invoke
2380 if the method is going to be needed. Use MethodGroupExpr.
2382 (NewDelegate.Emit): Remove, DelegateCreation implements this.
2384 * expression.cs: For pointer arith., make sure to use
2385 the size of the type, not the size of the pointer to
2388 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2391 * class.cs (Class): Added error CS0502 test.
2393 2004-08-03 John Luke <jluke@cfl.rr.com>
2394 Raja R Harinath <rharinath@novell.com>
2397 * attribute.cs (Attribute.complained_before): New flag.
2398 (Attribute.ResolveType, Attribute.Resolve),
2399 (Attribute.DefinePInvokeMethod): Set it.
2400 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
2402 2004-08-03 Martin Baulig <martin@ximian.com>
2404 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
2405 use a user-defined operator; we still need to do numeric
2406 promotions in case one argument is a builtin type and the other
2407 one has an implicit conversion to that type. Fixes #62322.
2409 2004-08-02 Martin Baulig <martin@ximian.com>
2411 * statement.cs (LocalInfo.Flags): Added `IsThis'.
2412 (LocalInfo.IsThis): New public property.
2413 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
2415 2004-08-01 Martin Baulig <martin@ximian.com>
2417 * class.cs (TypeContainer.GetClassBases): Don't set the default
2418 here since we may get called from GetPartialBases().
2419 (TypeContainer.DefineType): If GetClassBases() didn't return a
2420 parent, use the default one.
2422 2004-07-30 Duncan Mak <duncan@ximian.com>
2424 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
2426 2004-07-30 Martin Baulig <martin@ximian.com>
2428 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
2430 * class.cs (SourceMethod): New public class, derive from the
2431 symbol writer's ISourceMethod.
2432 (Method): Use the new symbol writer API.
2434 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
2435 as argument and use the new symbol writer.
2438 (SourceFile): Implement the symbol writer's ISourceFile.
2439 (Location.SymbolDocument): Removed.
2440 (Location.SourceFile): New public property.
2442 * symbolwriter.cs: Use the new symbol writer API.
2444 2004-07-30 Raja R Harinath <rharinath@novell.com>
2446 * Makefile (install-local): Remove. Functionality moved to
2449 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
2451 * Makefile: Install mcs.exe.config file together with mcs.exe.
2452 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
2453 correct runtime version.
2455 2004-07-25 Martin Baulig <martin@ximian.com>
2458 (TypeContainer.RegisterOrder): Removed, this was unused.
2459 (TypeContainer, interface_order): Removed.
2460 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
2461 TypeContainer as argument since we can also be called with a
2462 `PartialContainer' for a partial class/struct/interface.
2463 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
2464 of checking whether we're an `Interface' - we could be a
2466 (PartialContainer.Register): Override; call
2467 AddClass()/AddStruct()/AddInterface() on our parent.
2469 * cs-parser.jay (interface_member_declaration): Add things to the
2470 `current_container', not the `current_class'.
2472 * rootcontext.cs (RegisterOrder): The overloaded version which
2473 takes an `Interface' was unused, removed.
2475 * typemanager.cs (TypeManager.LookupInterface): Return a
2476 `TypeContainer', not an `Interface'.
2477 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
2478 contain a `PartialContainer' for an interface, so check it's
2479 `Kind' to figure out what it is.
2481 2004-07-25 Martin Baulig <martin@ximian.com>
2483 * class.cs (Class.DefaultTypeAttributes): New public constant.
2484 (Struct.DefaultTypeAttributes): Likewise.
2485 (Interface.DefaultTypeAttributes): Likewise.
2486 (PartialContainer.TypeAttr): Override this and add the
2487 DefaultTypeAttributes.
2489 2004-07-25 Martin Baulig <martin@ximian.com>
2491 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
2492 we can just use the `Parent' field instead.
2494 2004-07-25 Martin Baulig <martin@ximian.com>
2496 * class.cs (TypeContainer.Emit): Renamed to EmitType().
2498 2004-07-25 Martin Baulig <martin@ximian.com>
2500 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
2501 our parts before defining any methods.
2502 (TypeContainer.VerifyImplements): Make this virtual.
2503 (ClassPart.VerifyImplements): Override and call VerifyImplements()
2504 on our PartialContainer.
2506 2004-07-25 Martin Baulig <martin@ximian.com>
2508 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2510 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2511 argument, we can just use the `Parent' field instead.
2514 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2515 (MemberBase.DoDefine): Likewise.
2517 2004-07-24 Martin Baulig <martin@ximian.com>
2519 * decl.cs (MemberCore.Parent): New public field.
2520 (DeclSpace.Parent): Moved to MemberCore.
2522 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2523 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2525 (FieldBase, Field, Operator): Likewise.
2526 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2527 (EventField, Event): Likewise.
2529 2004-07-23 Martin Baulig <martin@ximian.com>
2531 * class.cs (PartialContainer): New public class.
2532 (ClassPart): New public class.
2533 (TypeContainer): Added support for partial classes.
2534 (TypeContainer.GetClassBases): Splitted some of the functionality
2535 out into GetNormalBases() and GetPartialBases().
2537 * cs-tokenizer.cs (Token.PARTIAL): New token.
2538 (Tokenizer.consume_identifier): Added some hacks to recognize
2539 `partial', but only if it's immediately followed by `class',
2540 `struct' or `interface'.
2542 * cs-parser.jay: Added support for partial clases.
2544 2004-07-23 Martin Baulig <martin@ximian.com>
2546 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2547 a `DeclSpace' and also made it readonly.
2548 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2549 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2550 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2552 * cs-parser.jay: Pass the `current_class', not the
2553 `current_container' (at the moment, this is still the same thing)
2554 to a new Method, Property, Event, Indexer or Constructor.
2556 2004-07-23 Martin Baulig <martin@ximian.com>
2558 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2559 and removed the `current_interface' one.
2560 (struct_declaration, class_declaration, interface_declaration):
2561 Set `current_class' to the newly created class/struct/interface;
2562 set their `Bases' and call Register() before parsing their body.
2564 2004-07-23 Martin Baulig <martin@ximian.com>
2566 * class.cs (Kind): New public enum.
2567 (TypeContainer): Made this class abstract.
2568 (TypeContainer.Kind): New public readonly field.
2569 (TypeContainer.CheckDef): New public method; moved here from
2571 (TypeContainer.Register): New public abstract method.
2572 (TypeContainer.GetPendingImplementations): New public abstract
2574 (TypeContainer.GetClassBases): Removed the `is_class' and
2575 `is_iface' parameters.
2576 (TypeContainer.DefineNestedTypes): Formerly known as
2578 (ClassOrStruct): Made this class abstract.
2580 * tree.cs (RootTypes): New public type.
2582 2004-07-20 Martin Baulig <martin@ximian.com>
2584 * tree.cs (Tree.RecordNamespace): Removed.
2585 (Tree.Namespaces): Removed.
2587 * rootcontext.cs (RootContext.IsNamespace): Removed.
2589 * cs-parser.jay (namespace_declaration): Just create a new
2590 NamespaceEntry here.
2592 2004-07-20 Martin Baulig <martin@ximian.com>
2594 * statement.cs (ExceptionStatement): New abstract class. This is
2595 now used as a base class for everyone who's using `finally'.
2596 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
2597 our local variables before using them.
2599 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
2600 virtual method. This is used by Yield.Resolve() to "steal" an
2601 outer block's `finally' clauses.
2602 (FlowBranchingException): The .ctor now takes an ExceptionStatement
2605 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
2606 version which takes an ExceptionStatement. This version must be
2607 used to create exception branchings.
2610 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
2611 (Iterator.EmitMoveNext): Added exception support; protect the
2612 block with a `fault' clause, properly handle 'finally' clauses.
2613 (Iterator.EmitDispose): Run all the `finally' clauses here.
2615 2004-07-20 Martin Baulig <martin@ximian.com>
2617 * iterator.cs: This is the first of a set of changes in the
2618 iterator code. Match the spec more closely: if we're an
2619 IEnumerable, then GetEnumerator() must be called. The first time
2620 GetEnumerator() is called, it returns the current instance; all
2621 subsequent invocations (if any) must create a copy.
2623 2004-07-19 Miguel de Icaza <miguel@ximian.com>
2625 * expression.cs: Resolve the constant expression before returning
2628 2004-07-19 Martin Baulig <martin@ximian.com>
2630 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
2631 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
2632 the return type of the new EmitContext.
2634 2004-07-18 Martin Baulig <martin@ximian.com>
2636 * class.cs (Property.Define): Fix iterators.
2638 * iterators.cs (Iterator.Define): Moved the
2639 `container.AddInterator (this)' call here from the .ctor; only do
2640 it if we resolved successfully.
2642 2004-07-17 Miguel de Icaza <miguel@ximian.com>
2644 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
2645 `true' for preprocessing directives that we parse. The return
2646 value indicates whether we should return to regular tokenizing or
2647 not, not whether it was parsed successfully.
2649 In the past if we were in: #if false ... #line #endif, we would
2650 resume parsing after `#line'. See bug 61604.
2652 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
2653 building: IsEnumType should return true only for enums, not for
2654 enums or System.Enum itself. This fixes #61593.
2656 Likely what happened is that corlib was wrong: mcs depended on
2657 this bug in some places. The bug got fixed, we had to add the
2658 hack, which caused bug 61593.
2660 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
2661 that was a workaround for the older conditions.
2663 2004-07-16 Ben Maurer <bmaurer@ximian.com>
2665 * assign.cs: IAssignMethod has a new interface, as documented
2666 inline. All assignment code now uses this new api.
2668 * ecore.cs, expression.cs: All classes which implement
2669 IAssignMethod now use the new interface.
2671 * expression.cs (Invocation): add a hack to EmitCall so that
2672 IndexerAccess can be the target of a compound assignment without
2673 evaluating its arguments twice.
2675 * statement.cs: Handle changes in Invocation api.
2677 2004-07-16 Martin Baulig <martin@ximian.com>
2679 * iterators.cs: Rewrote this. We're now using one single Proxy
2680 class for both the IEnumerable and the IEnumerator interface and
2681 `Iterator' derives from Class so we can use the high-level API.
2683 * class.cs (TypeContainer.AddIterator): New method.
2684 (TypeContainer.DoDefineType): New protected virtual method, which
2685 is called from DefineType().
2686 (TypeContainer.DoDefineMembers): Call DefineType() and
2687 DefineMembers() on all our iterators.
2688 (TypeContainer.Emit): Call Emit() on all our iterators.
2689 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2691 * codegen.cs (EmitContext.CurrentIterator): New public field.
2693 2004-07-15 Martin Baulig <martin@ximian.com>
2696 (TypeManager.not_supported_exception_type): New type.
2698 2004-07-14 Martin Baulig <martin@ximian.com>
2700 * iterators.cs: Use real error numbers.
2702 2004-07-14 Martin Baulig <martin@ximian.com>
2704 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2705 requires this to be a System.Collection.IEnumerable and not a
2706 class implementing that interface.
2707 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2709 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2711 * class.cs: Fixed previous fix, it broke some error tests.
2713 2004-07-12 Martin Baulig <martin@ximian.com>
2715 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2718 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2720 * assign.cs (LocalTemporary): Add new argument: is_address,If
2721 `is_address' is true, then the value that we store is the address
2722 to the real value, and not the value itself.
2724 * ecore.cs (PropertyExpr): use the new local temporary
2725 stuff to allow us to handle X.Y += z (where X is a struct)
2727 2004-07-08 Martin Baulig <martin@ximian.com>
2729 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2730 not always return, just like we're doing in Using.Resolve().
2732 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2734 * cs-parser.jay (fixed_statement): flag this as Pinned.
2736 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2738 * typemanager.cs (TypeManager): Removed MakePinned method, this
2739 mechanism is replaced with the .NET 2.x compatible mechanism of
2740 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2742 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2743 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2744 `IsFixed' property which has a different meaning.
2746 2004-07-02 Raja R Harinath <rharinath@novell.com>
2748 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2749 visible from inside a nested class, not just the names of the
2750 immediately enclosing class.
2753 2004-06-24 Raja R Harinath <rharinath@novell.com>
2755 * expression.cs (BetterConversion): Remove buggy special-case
2756 handling of "implicit constant expression conversions". At this
2757 point, we already know that the conversion is possible -- we're
2758 only checking to see which is better.
2760 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2762 * cs-parser.jay: Added error CS0210 test.
2764 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2766 * cs-parser.jay: Added error CS0134 test.
2768 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2771 * cs-parser.jay: Added error CS0145 test.
2773 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2775 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2777 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2779 * expression.cs (StackAlloc.Resolve): The argument may not
2780 be a constant; deal with this case.
2782 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2784 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2785 GetIndexerAttributeValue.
2786 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2788 * class.cs (Indexer.Define): Added error tests for CS0415,
2791 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2793 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2796 2004-06-23 Martin Baulig <martin@ximian.com>
2798 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2799 neither return nor throw, reset the barrier as well. Fixes #60457.
2801 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2803 * class.cs : EventAttributes is now set to None by default.
2804 This fixes bug #60459.
2806 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2809 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2810 Don't throw exception but return null (it's sufficient now).
2812 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2814 * typemanager.cs (GetArgumentTypes): Faster implementation.
2816 2004-06-18 Martin Baulig <martin@ximian.com>
2818 * attribute.cs (Attribute.Resolve): Check whether we're an
2819 EmptyCast which a Constant child. Fixes #60333.
2821 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2823 * statement.cs (EmitCollectionForeach): Account for the fact that
2824 not all valuetypes are in areas which we can take the address of.
2825 For these variables, we store to a temporary variable. Also, make
2826 sure that we dont emit a `callvirt' on a valuetype method.
2828 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2830 * expression.cs (StackAlloc.DoReSolve): Added test for
2831 negative parameter (CS0247).
2833 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2836 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2838 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2841 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2844 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2846 Fix bug #58254 & cs1555.cs, cs1556.cs
2847 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2849 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2851 * cs-parser.jay: Added error CS1669 test for indexers.
2853 2004-06-11 Martin Baulig <martin@ximian.com>
2855 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2856 call this twice: for params and varargs methods.
2858 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2861 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2863 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2865 * attribute.cs (Attribute.GetValidTargets): Made public.
2868 (AbstractPropertyEventMethod): New class for better code sharing.
2869 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2871 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2873 2004-06-11 Raja R Harinath <rharinath@novell.com>
2876 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
2877 that the call to Resolve is part of a MemberAccess.
2878 (Expression.Resolve): Use it for SimpleName resolution.
2879 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
2880 Add 'intermediate' boolean argument.
2881 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
2882 error message when the SimpleName can be resolved ambiguously
2883 between an expression and a type.
2884 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
2886 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
2887 call on the left-side.
2889 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2892 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
2894 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2896 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
2898 2004-06-11 Martin Baulig <martin@ximian.com>
2900 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
2901 varargs methods if applicable.
2903 2004-06-11 Martin Baulig <martin@ximian.com>
2905 * expression.cs (Invocation.EmitCall): Don't use
2906 `method.CallingConvention == CallingConventions.VarArgs' since the
2907 method could also have `CallingConventions.HasThis'.
2909 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2911 * class.cs (Event.GetSignatureForError): Implemented.
2912 Fixed crash in error test cs3010.cs
2914 2004-06-10 Miguel de Icaza <miguel@ximian.com>
2916 * cs-tokenizer.cs: Change the way we track __arglist to be
2917 consistent with the other keywords.
2919 2004-06-09 Miguel de Icaza <miguel@ximian.com>
2921 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
2924 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
2926 * codegen.cs: Check that all referenced assemblies have a strongname
2927 before strongnaming the compiled assembly. If not report error CS1577.
2928 Fix bug #56563. Patch by Jackson Harper.
2929 * typemanager.cs: Added a method to return all referenced assemblies.
2930 Fix bug #56563. Patch by Jackson Harper.
2932 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2935 (Method.ApplyAttributeBuilder): Moved and added conditional
2936 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
2939 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
2941 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2944 * class.cs: (EventField.attribute_targets): Changed default target.
2946 2004-06-08 Martin Baulig <martin@ximian.com>
2948 * expression.cs (Invocation.EmitCall): Enable varargs methods.
2950 2004-06-08 Martin Baulig <martin@ximian.com>
2952 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
2954 2004-06-07 Martin Baulig <martin@ximian.com>
2956 Added support for varargs methods.
2958 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
2961 * cs-parser.jay: Added support for `__arglist'.
2963 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
2965 * expression.cs (Argument.AType): Added `ArgList'.
2966 (Invocation): Added support for varargs methods.
2967 (ArglistAccess): New public class.
2968 (Arglist): New public class.
2970 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
2972 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
2973 a method's top-level block if the method has varargs.
2975 * support.cs (ReflectionParameters, InternalParameters): Added
2976 support for varargs methods.
2978 2004-06-07 Miguel de Icaza <miguel@ximian.com>
2980 * class.cs: Provide location in indexer error report.
2982 * driver.cs: Use standard names.
2984 * namespace.cs: Catch the use of using after a namespace has been
2985 declared also on using aliases.
2987 2004-06-03 Raja R Harinath <rharinath@novell.com>
2990 * typemanager.cs (closure_private_ok, closure_invocation_type)
2991 (closure_qualifier_type, closure_invocation_assembly)
2992 (FilterWithClosure): Move to ...
2993 (Closure): New internal nested class.
2994 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
2995 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
2996 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
2997 (MemberLookup, MemberLookupFailed): Use it.
2998 * expression.cs (New.DoResolve): Treat the lookup for the
2999 constructor as being qualified by the 'new'ed type.
3000 (Indexers.GetIndexersForTypeOrInterface): Update.
3002 2004-06-03 Marek Safar <marek.safar@seznam.cz>
3005 (GetConditionalAttributeValue): New method. Returns
3006 condition of ConditionalAttribute.
3007 (SearchMulti): New method. Returns all attributes of type 't'.
3008 Use it when attribute is AllowMultiple = true.
3009 (IsConditionalMethodExcluded): New method.
3012 (Method.IsExcluded): Implemented. Returns true if method has conditional
3013 attribute and the conditions is not defined (method is excluded).
3014 (IMethodData): Extended interface for ConditionalAttribute support.
3015 (PropertyMethod.IsExcluded): Implemented.
3018 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
3021 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
3024 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
3026 * expression.cs (ArrayCreationExpression): Make this just an
3027 `expression'. It can't be a statement, so the code here was
3030 2004-06-02 Marek Safar <marek.safar@seznam.cz>
3033 * typemanager.cs (GetFullNameSignature): New method for
3036 2004-06-02 Marek Safar <marek.safar@seznam.cz>
3039 * class.cs (MemberBase.GetSignatureForError): New virtual method.
3040 Use this method when MethodBuilder is null.
3041 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
3042 Added test for error CS0626 (MONO reports error for this situation).
3043 (IMethodData.GetSignatureForError): Extended interface.
3045 2004-06-01 Marek Safar <marek.safar@seznam.cz>
3048 (AttributeTester.GetObsoleteAttribute): Returns instance of
3049 ObsoleteAttribute when type is obsolete.
3052 (TypeContainer.VerifyObsoleteAttribute): Override.
3053 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
3054 (MethodCode.VerifyObsoleteAttribute): Override.
3055 (MemberBase.VerifyObsoleteAttribute): Override.
3058 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
3059 and report proper error.
3062 Delegate.VerifyObsoleteAttribute): Override.
3065 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
3066 and report proper error.
3067 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
3070 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
3074 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
3075 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
3076 Added test for ObsoleteAttribute.
3079 (Catch): Derived from Statement.
3081 2004-06-01 Marek Safar <marek.safar@seznam.cz>
3083 Fixed bug #59071 & cs0160.cs
3085 * statement.cs (Try.Resolve): Check here whether order of catch
3086 clauses matches their dependencies.
3088 2004-05-31 Miguel de Icaza <miguel@ximian.com>
3090 * Reverted patch to namespace.cs (Use lookuptypedirect). This
3091 caused a regression: #59343. Referencing nested classes from an
3092 assembly stopped working.
3094 2004-05-31 Martin Baulig <martin@ximian.com>
3096 MCS is now frozen for beta 2.
3098 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3100 * convert.cs: add a trivial cache for overload operator resolution.
3102 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3104 * decl.cs: If possible, use lookuptypedirect here. We can only do
3105 this if there is no `.' after the namespace. Avoids using
3106 LookupType, which does lots of slow processing.
3107 (FindNestedType) New method, does what it says :-).
3108 * namespace.cs: use LookupTypeDirect.
3109 * rootcontext.cs: use membercache, if possible.
3110 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3112 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3115 According to the spec,
3117 In a member access of the form E.I, if E is a single identifier,
3118 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3119 field, property, localvariable, or parameter with the same type as
3120 the meaning of E as a type-name (§3.8), then both possible
3121 meanings of E are permitted.
3123 We did not check that E as a simple-name had the same type as E as
3126 This trivial check gives us 5-7% on bootstrap time.
3128 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3130 * expression.cs (Invocation.OverloadResolve): Avoid the
3131 use of hashtables and boxing here by allocating on demand.
3133 2004-05-30 Martin Baulig <martin@ximian.com>
3135 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3136 we're doing a silent lookup. Don't try to lookup nested types in
3137 TypeManager.object_type (thanks to Ben Maurer).
3139 2004-05-30 Martin Baulig <martin@ximian.com>
3141 Committing a patch from Ben Maurer.
3143 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3145 2004-05-29 Martin Baulig <martin@ximian.com>
3147 * class.cs (IMethodData.ShouldIgnore): New method.
3149 * typemanager.cs (TypeManager.MethodFlags): Don't take a
3150 `Location' argument, we don't need it anywhere. Use
3151 `IMethodData.ShouldIgnore ()' instead of
3152 `MethodData.GetMethodFlags ()'.
3153 (TypeManager.AddMethod): Removed.
3154 (TypeManager.AddMethod2): Renamed to AddMethod.
3156 2004-05-29 Martin Baulig <martin@ximian.com>
3158 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
3160 * convert.cs (Convert.ImplicitReferenceConversion): If we're
3161 converting from a class type S to an interface type and we already
3162 have an object on the stack, don't box it again. Fixes #52578.
3164 2004-05-29 Martin Baulig <martin@ximian.com>
3166 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3167 Added support for `params' parameters. Fixes #59267.
3169 2004-05-29 Martin Baulig <martin@ximian.com>
3171 * literal.cs (NullPointer): Provide a private .ctor which sets
3172 `type' to TypeManager.object_type. Fixes #59048.
3174 2004-05-29 Martin Baulig <martin@ximian.com>
3176 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
3177 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
3179 * ecore.cs (EventExpr.instance_expr): Make the field private.
3181 2004-05-26 Marek Safar <marek.safar@seznam.cz>
3183 Fixed bug #50080 & cs0214-2.cs
3184 * expression.cs (Cast.DoResolve): Check unsafe context here.
3186 * statement.cs (Resolve.DoResolve): Likewise.
3188 2004-05-26 Martin Baulig <martin@ximian.com>
3190 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
3192 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
3193 (RootContext.LookupType): Pass down the `silent' flag.
3195 2004-05-25 Martin Baulig <martin@ximian.com>
3198 (MethodGroupExpr.IdenticalTypeName): New public property.
3199 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
3200 expression actually refers to a type.
3202 2004-05-25 Martin Baulig <martin@ximian.com>
3204 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
3205 for #56176 and made it actually work.
3207 2004-05-25 Martin Baulig <martin@ximian.com>
3209 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
3210 (FieldExpr, PropertyExpr): Override and implement
3211 CacheTemporaries. Fixes #52279.
3213 2004-05-25 Miguel de Icaza <miguel@ximian.com>
3215 * location.cs: In the new compiler listing a file twice is a
3216 warning, not an error.
3218 2004-05-24 Martin Baulig <martin@ximian.com>
3220 * enum.cs (Enum.DefineType): For the `BaseType' to be a
3221 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
3223 2004-05-24 Martin Baulig <martin@ximian.com>
3225 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
3226 walking the `using' list. Fixes #53921.
3228 2004-05-24 Martin Baulig <martin@ximian.com>
3230 * const.cs (Const.LookupConstantValue): Added support for
3231 EmptyCast's; fixes #55251.
3233 2004-05-24 Martin Baulig <martin@ximian.com>
3235 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
3236 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
3237 which does the CS0135 check. The reason is that we first need to
3238 check whether the variable actually exists.
3240 2004-05-24 Martin Baulig <martin@ximian.com>
3242 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
3243 than RootContext.LookupType() to find the explicit interface
3246 2004-05-24 Raja R Harinath <rharinath@novell.com>
3248 * Makefile: Simplify. Use executable.make.
3249 * mcs.exe.sources: New file. List of sources of mcs.exe.
3251 2004-05-24 Anders Carlsson <andersca@gnome.org>
3255 Use the invariant culture when doing String.Compare for CLS case
3258 2004-05-23 Martin Baulig <martin@ximian.com>
3260 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
3261 don't have any dots. Fixes #52622, added cs0246-8.cs.
3263 * namespace.cs (NamespaceEntry.Lookup): Likewise.
3265 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3267 * class.cs (MemberBase.Define): Reuse MemberType member for
3268 resolved type. Other methods can use it too.
3270 2004-05-23 Martin Baulig <martin@ximian.com>
3272 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
3273 the variable also exists in the current block (otherwise, we need
3274 to report a CS0103). Fixes #58670.
3276 2004-05-23 Martin Baulig <martin@ximian.com>
3278 * flowanalysis.cs (Reachability.Reachable): Compute this
3279 on-the-fly rather than storing it as a field.
3281 2004-05-23 Martin Baulig <martin@ximian.com>
3283 * flowanalysis.cs (Reachability.And): Manually compute the
3284 resulting `barrier' from the reachability.
3286 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3289 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
3290 instance of ObsoleteAttribute when symbol is obsolete.
3293 (IMethodData): Extended interface for ObsoleteAttribute support.
3295 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3297 * attribute.cs: Fix bug #55970
3299 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3303 (GetObsoleteAttribute): New method. Creates the instance of
3305 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
3306 ObsoleteAttribute when member is obsolete.
3307 (AttributeTester.Report_ObsoleteMessage): Common method for
3308 Obsolete error/warning reporting.
3311 (TypeContainer.base_classs_type): New member for storing parent type.
3314 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
3315 for this MemberCore.
3317 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3319 * attribute.cs, const.cs: Fix bug #58590
3321 2004-05-21 Martin Baulig <martin@ximian.com>
3323 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
3324 out parameters if the end of the method is unreachable. Fixes
3327 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3329 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
3330 Hari was right, why extra method.
3332 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3334 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
3336 2004-05-20 Martin Baulig <martin@ximian.com>
3338 Merged this back from gmcs to keep the differences to a minumum.
3340 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
3341 instead of a Declspace.
3342 (Attribute.ResolveType): Likewise.
3343 (Attributes.Search): Likewise.
3344 (Attributes.Contains): Likewise.
3345 (Attributes.GetClsCompliantAttribute): Likewise.
3347 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
3349 (MethodData.ApplyAttributes): Take an EmitContext instead of a
3352 2004-05-19 Marek Safar <marek.safar@seznam.cz>
3354 Fix bug #58688 (MCS does not report error when the same attribute
3357 * attribute.cs (Attribute.Emit): Distinction between null and default.
3359 2004-05-19 Raja R Harinath <rharinath@novell.com>
3361 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
3362 of a top-level attribute without an attribute target.
3363 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
3365 (Attribute.Conditional_GetConditionName),
3366 (Attribute.Obsolete_GetObsoleteMessage): Update.
3367 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
3368 part of ScanForIndexerName.
3369 (Attribute.CanIgnoreInvalidAttribute): New function.
3370 (Attribute.ScanForIndexerName): Move to ...
3371 (Attributes.ScanForIndexerName): ... here.
3372 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
3373 (Attributes.Search): New internal variant that can choose not to
3374 complain if types aren't resolved. The original signature now
3376 (Attributes.GetClsCompliantAttribute): Use internal variant, with
3377 complaints suppressed.
3378 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
3379 only if it not useful.
3380 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
3381 top-level for attributes that are shared between the assembly
3382 and a top-level class.
3383 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
3384 * class.cs: Update to reflect changes.
3385 (DefineIndexers): Fuse loops.
3386 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
3387 a couple more variants of attribute names.
3389 2004-05-18 Marek Safar <marek.safar@seznam.cz>
3391 Fix bug #52585 (Implemented explicit attribute declaration)
3394 (Attributable.ValidAttributeTargets): New abstract method. It gets
3395 list of valid attribute targets for explicit target declaration.
3396 (Attribute.Target): It holds target itself.
3397 (AttributeSection): Removed.
3398 (Attribute.CheckTargets): New method. It checks whether attribute
3399 target is valid for the current element.
3402 (EventProperty): New class. For events that are declared like
3403 property (with add and remove accessors).
3404 (EventField): New class. For events that are declared like field.
3407 * cs-parser.jay: Implemented explicit attribute target declaration.
3409 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
3410 Override ValidAttributeTargets.
3413 (ReturnParameter): Class for applying custom attributes on
3415 (ParameterAtribute): New class. Class for applying custom
3416 attributes on the parameter type.
3418 2004-05-17 Miguel de Icaza <miguel@ximian.com>
3420 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
3423 (Method): Allow UNSAFE here.
3425 * modifiers.cs: Support unsafe reporting.
3427 2004-05-17 Marek Safar <marek.safar@seznam.cz>
3429 * decl.cs: Fix bug #58478.
3431 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3433 * statement.cs: When checking for unreachable code on an EmptyStatement,
3434 set the location. Fixes bug #58488.
3436 2004-05-13 Miguel de Icaza <miguel@ximian.com>
3438 * driver.cs: Add -pkg handling.
3440 From Gonzalo: UseShelLExecute=false
3442 2004-05-12 Marek Safar <marek.safar@seznam.cz>
3445 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
3447 (Attribute.IsClsCompliaceRequired): Moved to base for better
3449 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
3450 when attribute is AttributeUsageAttribute.
3451 (Attribute.GetValidTargets): Simplified.
3452 (Attribute.GetAttributeUsage): New method returns AttributeUsage
3453 attribute for this type.
3454 (Attribute.ApplyAttributes): Method renamed to Emit and make
3456 (GlobalAttributeSection): New class for special handling of global
3457 attributes (assembly, module).
3458 (AttributeSection.Emit): New method.
3460 * class.cs: Implemented Attributable abstract methods.
3461 (MethodCore.LabelParameters): Moved to Parameter class.
3462 (Accessor): Is back simple class.
3463 (PropertyMethod): Implemented Attributable abstract class.
3464 (DelegateMethod): Implemented Attributable abstract class.
3465 (Event): New constructor for disctintion between normal Event
3466 and Event with accessors.
3468 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
3470 * codegen.cs, const.cs, decl.cs, delegate.cs:
3471 (CommonAssemblyModulClass): Implemented Attributable abstract class
3474 * enum.cs: Implement IAttributeSupport interface.
3475 (EnumMember): New class for emum members. Implemented Attributable
3479 (ParameterBase): Is abstract.
3480 (ReturnParameter): New class for easier [return:] attribute handling.
3482 * typemanager.cs: Removed builder_to_attr.
3484 2004-05-11 Raja R Harinath <rharinath@novell.com>
3487 * attribute.cs (Attribute.GetPositionalValue): New function.
3488 * class.cs (TypeContainer.VerifyMembers): New function.
3489 (TypeContainer.Emit): Use it.
3490 (ClassOrStruct): New base class for Class and Struct.
3491 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
3492 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
3494 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
3495 then each non-static field should have a FieldOffset attribute.
3496 Otherwise, none of the fields should have a FieldOffset attribute.
3497 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
3498 and FieldOffset attributes.
3499 * typemanager.cs (TypeManager.struct_layout_attribute_type)
3500 (TypeManager.field_offset_attribute_type): New core types.
3501 (TypeManager.InitCoreTypes): Initialize them.
3503 2004-05-11 Michal Moskal <malekith@pld-linux.org>
3505 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
3506 Return correct type.
3509 2004-05-09 Miguel de Icaza <miguel@ximian.com>
3511 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
3512 be implicitly converted to ulong.
3514 * expression.cs: The logic for allowing operator &, | and ^ worked
3515 was wrong, it worked before because we did not report an error in
3516 an else branch. Fixes 57895.
3518 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
3519 allow volatile fields to be reference types.
3521 2004-05-07 Miguel de Icaza <miguel@ximian.com>
3523 * driver.cs: Add support for /debug-
3525 2004-05-07 Raja R Harinath <rharinath@novell.com>
3527 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
3528 Add a 'complain' parameter to silence errors.
3529 (Attribute.Resolve): Update to changes. Put in sanity check to catch
3530 silently overlooked type-resolutions.
3531 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
3533 (Attributes.Search): New function.
3534 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
3535 (Attributes.GetAttributeFullName): Remove hack.
3536 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
3537 Update to reflect changes.
3538 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
3539 Use Attributes.Search instead of nested loops.
3541 2004-05-07 Marek Safar <marek.safar@seznam.cz>
3544 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
3545 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
3546 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
3548 * report.cs: (Report.Warning): Renamed to Warning_T because of
3549 parameter collision.
3551 2004-05-05 Raja R Harinath <rharinath@novell.com>
3553 * expression.cs (MemberAccess.ResolveMemberAccess):
3554 Exit with non-zero status after Report.Error.
3555 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
3557 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
3559 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3561 * support.cs: Don't hang when the file is empty.
3563 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3565 * support.cs: In SeekableStreamReader, compute the preamble size of the
3566 underlying stream. Position changes should take into account that initial
3569 2004-05-03 Todd Berman <tberman@sevenl.net>
3571 * driver.cs: remove unused GetSysVersion function.
3573 2004-05-03 Todd Berman <tberman@sevenl.net>
3575 * driver.cs: Remove the hack from saturday, as well as the hack
3576 from jackson (LoadAssemblyFromGac), also adds the CWD to the
3577 link_paths to get that bit proper.
3579 2004-05-01 Todd Berman <tberman@sevenl.net>
3581 * driver.cs: Try a LoadFrom before a Load, this checks the current
3582 path. This is currently a bug in mono that is be fixed, however, this
3583 provides a workaround for now. This will be removed when the bug
3586 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
3588 * CryptoConvert.cs: Updated to latest version. Fix issue with
3589 incomplete key pairs (#57941).
3591 2004-05-01 Todd Berman <tberman@sevenl.net>
3593 * driver.cs: Remove '.' from path_chars, now System.* loads properly
3596 2004-04-30 Jackson Harper <jackson@ximian.com>
3598 * codegen.cs: Open keys readonly.
3600 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3602 * typemanager.cs: don't report cyclic struct layout when a struct
3603 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3604 which has 2 Pango.Rectangle fields.
3606 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3608 * expression.cs: Handle IntPtr comparisons with IL code
3609 rather than a method call.
3611 2004-04-29 Martin Baulig <martin@ximian.com>
3613 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3614 the list of PropertyInfo's in class hierarchy and find the
3615 accessor. Fixes #56013.
3617 2004-04-29 Martin Baulig <martin@ximian.com>
3619 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3621 2004-04-29 Martin Baulig <martin@ximian.com>
3623 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3625 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3627 2004-04-29 Martin Baulig <martin@ximian.com>
3629 * class.cs (ConstructorInitializer.Resolve): Check whether the
3630 parent .ctor is accessible. Fixes #52146.
3632 2004-04-29 Martin Baulig <martin@ximian.com>
3634 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3636 * statement.cs (Using.EmitLocalVariableDecls): Use
3637 TypeManager.idisposable_type, not typeof (IDisposable).
3638 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3640 2004-04-29 Martin Baulig <martin@ximian.com>
3642 * class.cs (Event.Define): Don't emit the field and don't set
3643 RTSpecialName and SpecialName for events on interfaces. Fixes
3646 2004-04-29 Raja R Harinath <rharinath@novell.com>
3648 Refactor Attribute.ApplyAttributes.
3649 * attribute.cs (Attributable): New base class for objects that can
3650 have Attributes applied on them.
3651 (Attribute): Make AttributeUsage fields public.
3652 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3653 (Attribute.IsInternalCall): New property.
3654 (Attribute.UsageAttr): Convert to a public read-only property.
3655 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3656 (Attribute.ResolveType, Attribute.Resolve)
3657 (Attribute.ScanForIndexerName): Update to reflect changes.
3658 (Attribute.CheckAttributeTarget): Re-format.
3659 (Attribute.ApplyAttributes): Refactor, to various
3660 Attributable.ApplyAttributeBuilder methods.
3661 * decl.cs (MemberCore): Make Attributable.
3662 * class.cs (Accessor): Make Attributable.
3663 (MethodData.ApplyAttributes): Use proper attribute types, not
3665 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3666 (TypeContainer.ApplyAttributeBuilder)
3667 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3668 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3669 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3670 (Operator.ApplyAttributeBuilder): New factored-out methods.
3671 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3672 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3673 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3674 * parameter.cs (ParameterBase): New Attributable base class
3675 that can also represent Return types.
3676 (Parameter): Update to the changes.
3678 2004-04-29 Jackson Harper <jackson@ximian.com>
3680 * driver.cs: Prefer the corlib system version when looking for
3681 assemblies in the GAC. This is still a hack, but its a better hack
3684 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3686 * decl.cs, enum.cs: Improved error 3005 reporting.
3688 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3689 (related_symbols): New private member for list of symbols
3690 related to reported error/warning.
3692 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3694 2004-04-29 Martin Baulig <martin@ximian.com>
3696 * ecore.cs (Expression.Constantify): If we're an enum and
3697 TypeManager.TypeToCoreType() doesn't give us another type, use
3698 t.UnderlyingSystemType. Fixes #56178.
3700 2004-04-29 Martin Baulig <martin@ximian.com>
3702 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3703 interfaces and for each interface, only add members directly
3704 declared in that interface. Fixes #53255.
3706 2004-04-28 Martin Baulig <martin@ximian.com>
3708 * expression.cs (ConditionalLogicalOperator): Use a temporary
3709 variable for `left' to avoid that we evaluate it more than once;
3712 2004-04-28 Martin Baulig <martin@ximian.com>
3714 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3717 2004-04-28 Martin Baulig <martin@ximian.com>
3719 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3722 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3723 whether the type is not void (CS1547).
3725 2004-04-28 Martin Baulig <martin@ximian.com>
3727 * expression.cs (Unary.DoResolveLValue): Override this and report
3728 CS0131 for anything but Operator.Indirection.
3730 2004-04-28 Martin Baulig <martin@ximian.com>
3732 Committing a patch from Ben Maurer; see bug #50820.
3734 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3737 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3740 2004-04-28 Martin Baulig <martin@ximian.com>
3742 Committing a patch from Ben Maurer; see bug #50820.
3744 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3747 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3750 2004-04-28 Martin Baulig <martin@ximian.com>
3752 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3753 (Block.AddLabel): Call DoLookupLabel() to only search in the
3756 2004-04-28 Martin Baulig <martin@ximian.com>
3758 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3759 comparing StringConstants and NullLiterals in Equality and Inequality.
3761 2004-04-28 Jackson Harper <jackson@ximian.com>
3763 * driver.cs: Attempt to load referenced assemblies from the
3764 GAC. This is the quick and dirty version of this method that
3765 doesnt take into account versions and just takes the first
3766 canidate found. Will be good enough for now as we will not have more
3767 then one version installed into the GAC until I update this method.
3769 2004-04-28 Martin Baulig <martin@ximian.com>
3771 * typemanager.cs (TypeManager.CheckStructCycles): New public
3772 static method to check for cycles in the struct layout.
3774 * rootcontext.cs (RootContext.PopulateTypes): Call
3775 TypeManager.CheckStructCycles() for each TypeContainer.
3776 [Note: We only need to visit each type once.]
3778 2004-04-28 Martin Baulig <martin@ximian.com>
3780 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3782 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3783 success and added `out object value'. Use a `bool resolved' field
3784 to check whether we've already been called rather than
3785 `ConstantValue != null' since this breaks for NullLiterals.
3787 2004-04-28 Raja R Harinath <rharinath@novell.com>
3789 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3790 setting of this flag, since the 'set' method may be non-public.
3792 2004-04-28 Raja R Harinath <rharinath@novell.com>
3794 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3795 check on current_vector.Block.
3797 2004-04-27 Martin Baulig <martin@ximian.com>
3799 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3800 a field initializer. Fixes #56459.
3802 2004-04-27 Martin Baulig <martin@ximian.com>
3804 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3805 we're not attempting to use an indexer. Fixes #52154.
3807 2004-04-27 Martin Baulig <martin@ximian.com>
3809 * statement.cs (Return): Don't create a return label if we don't
3810 need it; reverts my change from January 20th. Thanks to Ben
3813 2004-04-27 Martin Baulig <martin@ximian.com>
3815 According to the spec, `goto' can only leave a nested scope, but
3818 * statement.cs (Block.LookupLabel): Only lookup in the current
3819 block, don't recurse into parent or child blocks.
3820 (Block.AddLabel): Check in parent and child blocks, report
3821 CS0140/CS0158 if we find a duplicate.
3822 (Block): Removed this indexer for label lookups.
3823 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3824 this already does the error reporting for us.
3827 (FlowBranching.UsageVector.Block): New public variable; may be null.
3828 (FlowBranching.CreateSibling): Added `Block' argument.
3829 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3830 label for the target of a `goto' and check whether we're not
3831 leaving a `finally'.
3833 2004-04-27 Martin Baulig <martin@ximian.com>
3835 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3836 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3839 2004-04-27 Martin Baulig <martin@ximian.com>
3841 * statement.cs (Block.AddLabel): Also check for implicit blocks
3842 and added a CS0158 check.
3844 2004-04-27 Martin Baulig <martin@ximian.com>
3846 * flowanalysis.cs (FlowBranchingLoop): New class.
3847 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3848 UsageVector's instead of an ArrayList.
3849 (FlowBranching.Label): Likewise.
3850 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3851 (FlowBranching.AddBreakVector): New method.
3853 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3855 * attribute.cs: Small regression fix: only convert the type if we
3856 the type is different, fixes System.Drawing build.
3858 2004-04-27 Martin Baulig <martin@ximian.com>
3860 * attribute.cs (Attribute.Resolve): If we have a constant value
3861 for a named field or property, implicity convert it to the correct
3864 2004-04-27 Raja R Harinath <rharinath@novell.com>
3866 * statement.cs (Block.Block): Implicit blocks share
3867 'child_variable_names' fields with parent blocks.
3868 (Block.AddChildVariableNames): Remove.
3869 (Block.AddVariable): Mark variable as "used by a child block" in
3870 every surrounding block.
3871 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3872 been used in a child block, complain about violation of "Invariant
3873 meaning in blocks" rule.
3874 * cs-parser.jay (declare_local_variables): Don't use
3875 AddChildVariableNames.
3876 (foreach_statement): Don't create an implicit block: 'foreach'
3879 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3881 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3882 converting from 0L to ulong. Fixes 57522.
3884 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3886 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3887 derived class hides via 'new' keyword field from base class (test-242.cs).
3888 TODO: Handle this in the more general way.
3890 * class.cs (CheckBase): Ditto.
3892 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3894 * decl.cs (caching_flags): New member for storing cached values
3896 (MemberCore.Flags): New enum where bit flags for caching_flags
3898 (MemberCore.cls_compliance): Moved to caching_flags.
3899 (DeclSpace.Created): Moved to caching_flags.
3901 * class.cs: Use caching_flags instead of DeclSpace.Created
3903 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3905 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3906 if we are only a derived class, not a nested class.
3908 * typemanager.cs: Same as above, but do this at the MemberLookup
3909 level (used by field and methods, properties are handled in
3910 PropertyExpr). Allow for the qualified access if we are a nested
3913 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3915 * class.cs: Refactoring.
3916 (IMethodData): New inteface; Holds links to parent members
3917 to avoid member duplication (reduced memory allocation).
3918 (Method): Implemented IMethodData interface.
3919 (PropertyBase): New inner classes for get/set methods.
3920 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3921 (Event): New inner classes for add/remove methods.
3922 (Event.DelegateMethod): Implemented IMethodData interface.
3924 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3925 EmitContext (related to class.cs refactoring).
3927 2004-04-21 Raja R Harinath <rharinath@novell.com>
3929 * delegate.cs (Delegate.VerifyApplicability): If the number of
3930 arguments are the same as the number of parameters, first try to
3931 verify applicability ignoring any 'params' modifier on the last
3935 2004-04-16 Raja R Harinath <rharinath@novell.com>
3937 * class.cs (TypeContainer.AddIndexer): Use
3938 'ExplicitInterfaceName' to determine if interface name was
3939 explicitly specified. 'InterfaceType' is not initialized at this time.
3940 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3941 Indexers array is already in the required order. Initialize
3942 'IndexerName' only if there are normal indexers.
3943 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3944 (TypeContainer.Emit): Emit DefaultMember attribute only if
3945 IndexerName is initialized.
3948 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3950 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3953 2004-04-15 Raja R Harinath <rharinath@novell.com>
3955 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3959 * attribute.cs (Attribute.Resolve): Check for duplicate named
3963 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3965 * iterators.cs (MarkYield): track whether we are in an exception,
3966 and generate code accordingly. Use a temporary value to store the
3967 result for our state.
3969 I had ignored a bit the interaction of try/catch with iterators
3970 since their behavior was not entirely obvious, but now it is
3971 possible to verify that our behavior is the same as MS .NET 2.0
3975 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3977 * iterators.cs: Avoid creating temporaries if there is no work to
3980 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3981 Enumerations, use TypeManager.EnumToUnderlying and call
3984 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3987 (This.Emit): Use EmitContext.EmitThis to emit our
3990 (This.EmitAssign): Ditto.
3992 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3993 codepaths, we will move all the functionality into
3996 (FieldExpr.EmitAssign): Ditto.
3998 This fixes several hidden bugs that I uncovered while doing a code
3999 review of this today.
4001 * codegen.cs (EmitThis): reworked so the semantics are more clear
4002 and also support value types "this" instances.
4004 * iterators.cs: Changed so that for iterators in value types, we
4005 do not pass the value type as a parameter.
4007 Initialization of the enumerator helpers is now done in the caller
4008 instead of passing the parameters to the constructors and having
4009 the constructor set the fields.
4011 The fields have now `assembly' visibility instead of private.
4013 2004-04-11 Miguel de Icaza <miguel@ximian.com>
4015 * expression.cs (Argument.Resolve): Check if fields passed as ref
4016 or out are contained in a MarshalByRefObject.
4018 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
4019 another compiler type.
4021 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
4023 * class.cs (Indexer.Define): use the new name checking method.
4024 Also, return false on an error.
4025 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
4026 (is_identifier_[start/part]_character): make static.
4028 2004-04-10 Miguel de Icaza <miguel@ximian.com>
4030 * expression.cs (Binary.ResolveOperator): Do no append strings
4031 twice: since we can be invoked more than once (array evaluation)
4032 on the same concatenation, take care of this here. Based on a fix
4033 from Ben (bug #56454)
4035 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
4037 * codegen.cs: Fix another case where CS1548 must be reported (when
4038 delay-sign isn't specified and no private is available #56564). Fix
4039 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4040 error when MCS is used on the MS runtime and we need to delay-sign
4041 (which seems unsupported by AssemblyBuilder - see #56621).
4043 2004-04-08 Marek Safar <marek.safar@seznam.cz>
4045 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
4046 (TypeManager.ComputeNamespaces): Faster implementation for
4049 * compiler.csproj: Updated AssemblyName to mcs.
4051 2004-04-07 Miguel de Icaza <miguel@ximian.com>
4053 * rootcontext.cs: Add new types to the boot resolution.
4055 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
4056 MulticastDelegate is not allowed.
4058 * typemanager.cs: Add new types to lookup: System.TypedReference
4061 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
4062 check for TypedReference or ArgIterator, they are not allowed.
4064 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
4065 makes us properly catch 1510 in some conditions (see bug 56016 for
4068 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
4070 * CryptoConvert.cs: update from corlib version
4073 2004-04-05 Miguel de Icaza <miguel@ximian.com>
4075 * class.cs (Indexer.Define): Check indexername declaration
4077 2004-04-05 Marek Safar <marek.safar@seznam.cz>
4079 * attribute.cs (IsClsCompliant): Fixed problem with handling
4080 all three states (compliant, not-compliant, undetected).
4082 2004-03-30 Marek Safar <marek.safar@seznam.cz>
4084 * attribute.cs (Attribute): Location is now public.
4085 (Resolve): Store resolved arguments (pos_values) in attribute class.
4086 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
4087 (GetClsCompliantAttributeValue): New method that gets
4088 CLSCompliantAttribute value.
4089 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
4090 if exists else null.
4091 (AttributeTester): New class for CLS-Compliant verification routines.
4093 * class.cs (Emit): Add CLS-Compliant verification.
4094 (Method.GetSignatureForError): Implemented.
4095 (Constructor.GetSignatureForError): Implemented
4096 (Constructor.HasCompliantArgs): Returns if constructor has
4097 CLS-Compliant arguments.
4098 (Constructor.Emit): Override.
4099 (Construcor.IsIdentifierClsCompliant): New method; For constructors
4100 is needed to test only parameters.
4101 (FieldBase.GetSignatureForError): Implemented.
4102 (TypeContainer): New member for storing base interfaces.
4103 (TypeContainer.FindMembers): Search in base interfaces too.
4105 * codegen.cs (GetClsComplianceAttribute): New method that gets
4106 assembly or module CLSCompliantAttribute value.
4107 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
4109 (ModuleClass.Emit): Add error 3012 test.
4111 * const.cs (Emit): Override and call base for CLS-Compliant tests.
4113 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
4114 state for all decl types.
4115 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
4116 if CLS-Compliant tests are required.
4117 (IsClsCompliaceRequired): New method. Analyze whether code
4118 must be CLS-Compliant.
4119 (IsExposedFromAssembly): New method. Returns true when MemberCore
4120 is exposed from assembly.
4121 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
4122 value or gets cached value.
4123 (HasClsCompliantAttribute): New method. Returns true if MemberCore
4124 is explicitly marked with CLSCompliantAttribute.
4125 (IsIdentifierClsCompliant): New abstract method. This method is
4126 used to testing error 3005.
4127 (IsIdentifierAndParamClsCompliant): New method. Common helper method
4128 for identifier and parameters CLS-Compliant testing.
4129 (VerifyClsCompliance): New method. The main virtual method for
4130 CLS-Compliant verifications.
4131 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
4132 null. I don't know why is null (too many public members !).
4133 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
4134 and get value of first CLSCompliantAttribute that found.
4136 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
4137 (VerifyClsCompliance): Override and add extra tests.
4139 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
4140 clscheck- disable CLS-Compliant verification event if assembly is has
4141 CLSCompliantAttribute(true).
4143 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
4144 ApllyAttribute is now called in emit section as in the other cases.
4145 Possible future Emit integration.
4146 (IsIdentifierClsCompliant): New override.
4147 (VerifyClsCompliance): New override.
4148 (GetEnumeratorName): Returns full enum name.
4150 * parameter.cs (GetSignatureForError): Implemented.
4152 * report.cs (WarningData): New struct for Warning message information.
4153 (LocationOfPreviousError): New method.
4154 (Warning): New method. Reports warning based on the warning table.
4155 (Error_T): New method. Reports error based on the error table.
4157 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
4158 verifications are done here.
4160 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
4162 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
4163 CLSCompliantAttribute.
4164 (all_imported_types): New member holds all imported types from other
4166 (LoadAllImportedTypes): New method fills static table with exported types
4167 from all referenced assemblies.
4168 (Modules): New property returns all assembly modules.
4170 2004-03-30 Miguel de Icaza <miguel@ximian.com>
4172 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
4173 throwing a parser error.
4175 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
4176 which removes the hardcoded get_/set_ prefixes for properties, as
4177 IL allows for the properties to be named something else.
4181 * expression.cs: Do not override operand before we know if it is
4184 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4186 * typemanager.cs: support for pinned variables.
4188 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4190 * decl.cs, typemanager.cs: Avoid using an arraylist
4191 as a buffer if there is only one result set.
4193 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4195 * expression.cs: Make sure you cant call a static method
4196 with an instance expression, bug #56174.
4198 2004-03-29 Miguel de Icaza <miguel@ximian.com>
4200 * class.cs (IsDuplicateImplementation): Improve error reporting to
4201 flag 663 (method only differs in parameter modifier).
4203 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
4204 in preprocessor directives.
4206 * location.cs (LookupFile): Allow for the empty path.
4208 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
4209 better approach for some of that patch, but its failing with the
4210 CharSet enumeration. For now try/catch will do.
4212 * typemanager.cs: Do not crash if a struct does not have fields.
4215 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4217 * expression.cs: cs0213, cant fix a fixed expression.
4220 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4222 * cs-parser.jay: detect invalid embeded statements gracefully.
4225 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4227 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
4230 the invocation type may not be a subclass of the tye of the item/
4231 The type of the item must be a subclass of the invocation item.
4236 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
4238 * attribute.cs: Added methods to get a string and a bool from an
4239 attribute. Required to information from AssemblyKeyFileAttribute,
4240 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
4241 * codegen.cs: Modified AssemblyName creation to include support for
4242 strongnames. Catch additional exceptions to report them as CS1548.
4243 * compiler.csproj: Updated include CryptoConvert.cs.
4244 * compiler.csproj.user: Removed file - user specific configuration.
4245 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
4246 Mono.Security assembly. The original class is maintained and tested in
4247 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
4248 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
4249 like CSC 8.0 (C# v2) supports.
4250 * Makefile: Added CryptoConvert.cs to mcs sources.
4251 * rootcontext.cs: Added new options for strongnames.
4253 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
4255 * driver.cs: For --expect-error, report error code `2'
4256 if the program compiled with no errors, error code `1' if
4257 it compiled with an error other than the one expected.
4259 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
4261 * compiler.csproj: Updated for Visual Studio .NET 2003.
4262 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
4263 * compiler.sln: Updated for Visual Studio .NET 2003.
4265 2004-03-24 Ravi Pratap M <ravi@ximian.com>
4267 * expression.cs: Fix bug #47234. We basically need to apply the
4268 rule that we prefer the conversion of null to a reference type
4269 when faced with a conversion to 'object' (csc behaviour).
4271 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4273 * statement.cs: Shorter form for foreach, eliminates
4274 a local variable. r=Martin.
4276 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4278 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
4279 checks if we can use brtrue/brfalse to test for 0.
4280 * expression.cs: use the above in the test for using brtrue/brfalse.
4283 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4285 * expression.cs: Rewrite string concat stuff. Benefits:
4287 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
4288 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
4289 rather than a concat chain.
4291 * typemanager.cs: Add lookups for more concat overloads.
4293 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4295 * expression.cs: Emit shorter il code for array init.
4312 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
4314 * statement.cs: Before, two switch blocks would be merged if the
4315 total size of the blocks (end_item - begin_item + 1) was less than
4316 two times the combined sizes of the blocks.
4318 Now, it will only merge if after the merge at least half of the
4323 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
4325 * class.cs : csc build fix for GetMethods(). See bug #52503.
4327 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
4329 * expression.cs: Make sure fp comparisons work with NaN.
4330 This fixes bug #54303. Mig approved this patch a long
4331 time ago, but we were not able to test b/c the runtime
4334 2004-03-19 Miguel de Icaza <miguel@ximian.com>
4336 * ecore.cs (TypExpr.GetHashCode): implement this overload.
4338 2004-03-19 Martin Baulig <martin@ximian.com>
4340 * class.cs (MemberCore.IsDuplicateImplementation): Report the
4341 error here and not in our caller.
4343 2004-03-19 Martin Baulig <martin@ximian.com>
4345 * interface.cs: Completely killed this file.
4346 (Interface): We're now a TypeContainer and live in class.cs.
4348 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4349 argument; we're now also called for interfaces.
4350 (TypeContainer.DefineMembers): Allow this method being called
4352 (TypeContainer.GetMethods): New public method; formerly known as
4353 Interface.GetMethod(). This is used by PendingImplementation.
4354 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4355 it's now private and non-static.
4356 (Interface): Moved this here; it's now implemented similar to
4358 (Method, Property, Event, Indexer): Added `bool is_interface'
4359 argument to their .ctor's.
4360 (MemberBase.IsInterface): New public field.
4362 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4363 instances instead of InterfaceMethod, InterfaceProperty, etc.
4364 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4365 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4367 2004-03-19 Martin Baulig <martin@ximian.com>
4369 * class.cs (MethodCore.IsDuplicateImplementation): New private
4370 method which does the CS0111 checking.
4371 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4372 Use IsDuplicateImplementation().
4374 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4376 * decl.cs (FindMemberToOverride): New method to find the correct
4377 method or property to override in the base class.
4379 - Make Method/Property use the above method to find the
4380 version in the base class.
4381 - Remove the InheritableMemberSignatureCompare as it is now
4384 This patch makes large code bases much faster to compile, as it is
4385 O(n) rather than O(n^2) to do this validation.
4387 Also, it fixes bug 52458 which is that nested classes are not
4388 taken into account when finding the base class member.
4390 Reviewed/Approved by Martin.
4392 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4394 * interface.cs: In all interface classes removed redundant
4395 member initialization.
4397 2004-03-16 Martin Baulig <martin@ximian.com>
4399 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4401 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4403 * decl.cs (DefineTypeAndParents): New helper method to define a
4404 type's containers before the type itself is defined; This is a
4405 bug exposed by the recent changes to Windows.Forms when an
4406 implemented interface was defined inside a class that had not been
4409 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4411 (Check): Loop correctly to report errors modifiers
4412 (UNSAFE was not in the loop, since it was the same as TOP).
4414 * interface.cs: Every interface member now takes a ModFlags,
4415 instead of a "is_new" bool, which we set on the base MemberCore.
4417 Every place where we called "UnsafeOk" in the interface, now we
4418 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4419 the unsafe settings from the member declaration instead of the
4420 container interface.
4422 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4424 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4425 `set_indexer_name' to the pending bits (one per type).
4427 We fixed a bug today that was picking the wrong method to
4428 override, since for properties the existing InterfaceMethod code
4429 basically ignored the method name. Now we make sure that the
4430 method name is one of the valid indexer names.
4432 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4434 * support.cs (SeekableStreamReader): Keep track of stream byte
4435 positions and don't mix them with character offsets to the buffer.
4437 Patch from Gustavo Giráldez
4439 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4441 * interface.cs (InterfaceSetGetBase): Removed double member
4442 initialization, base class does it as well.
4444 2004-03-13 Martin Baulig <martin@ximian.com>
4446 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4447 when compiling corlib.
4449 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4451 * convert.cs (ExplicitConversion): We were reporting an error on
4452 certain conversions (object_type source to a value type, when the
4453 expression was `null') before we had a chance to pass it through
4454 the user defined conversions.
4456 * driver.cs: Replace / and \ in resource specifications to dots.
4459 * class.cs: Add check for duplicate operators. Fixes 52477
4461 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4463 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4464 that are in the middle of the statements, not only at the end.
4467 * class.cs (TypeContainer.AddField): No longer set the
4468 `HaveStaticConstructor' flag, now we call it
4469 `UserDefineStaticConstructor' to diferentiate the slightly
4470 semantic difference.
4472 The situation is that we were not adding BeforeFieldInit (from
4473 Modifiers.TypeAttr) to classes that could have it.
4474 BeforeFieldInit should be set to classes that have no static
4479 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4481 And most importantly Zoltan's comment:
4483 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4485 "I think beforefieldinit means 'it's ok to initialize the type sometime
4486 before its static fields are used', i.e. initialization does not need
4487 to be triggered by the first access to the type. Setting this flag
4488 helps the JIT to compile better code, since it can run the static
4489 constructor at JIT time, and does not need to generate code to call it
4490 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4491 this flag for lots of classes like String.
4493 csc sets this flag if the type does not have an explicit static
4494 constructor. The reasoning seems to be that if there are only static
4495 initalizers for a type, and no static constructor, then the programmer
4496 does not care when this initialization happens, so beforefieldinit
4499 This bug prevents the AOT compiler from being usable, since it
4500 generates so many calls to mono_runtime_class_init that the AOT code
4501 is much slower than the JITted code. The JITted code is faster,
4502 because it does not generate these calls if the vtable is type is
4503 already initialized, which is true in the majority of cases. But the
4504 AOT compiler can't do this."
4506 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4508 * class.cs (MethodData.Emit): Refactor the code so symbolic
4509 information is generated for destructors; For some reasons we
4510 were taking a code path that did not generate symbolic information
4513 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4515 * class.cs: Create a Constructor.CheckBase method that
4516 takes care of all validation type code. The method
4517 contains some code that was moved from Define.
4519 It also includes new code that checks for duplicate ctors.
4520 This fixes bug #55148.
4522 2004-03-09 Joshua Tauberer <tauberer@for.net>
4524 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4525 a { ... }-style array creation invokes EmitStaticInitializers
4526 which is not good for reference-type arrays. String, decimal
4527 and now null constants (NullCast) are not counted toward
4528 static initializers.
4530 2004-03-05 Martin Baulig <martin@ximian.com>
4532 * location.cs (SourceFile.HasLineDirective): New public field;
4533 specifies whether the file contains or is referenced by a "#line"
4535 (Location.DefineSymbolDocuments): Ignore source files which
4536 either contain or are referenced by a "#line" directive.
4538 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4540 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4541 direct access to our parent, so check the method inline there.
4543 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4545 * expression.cs (Invocation.EmitCall): Miguel's last commit
4546 caused a regression. If you had:
4551 In Foo the implict this would be null.
4553 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4555 * expression.cs (Invocation.EmitCall): If the method is not
4556 virtual, do not emit a CallVirt to it, use Call.
4558 * typemanager.cs (GetFullNameSignature): Improve the method to
4559 cope with ".ctor" and replace it with the type name.
4561 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4562 as an argument the ConstructorBuilder where it is being defined,
4563 to catch the recursive constructor invocations.
4565 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4567 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4568 routines to check if a type is an enumerable/enumerator allow
4569 classes that implement the IEnumerable or IEnumerator interfaces.
4571 * class.cs (Property, Operator): Implement IIteratorContainer, and
4572 implement SetYields.
4574 (Property.Define): Do the block swapping for get_methods in the
4575 context of iterators. We need to check if Properties also
4576 include indexers or not.
4578 (Operator): Assign the Block before invoking the
4579 OperatorMethod.Define, so we can trigger the Iterator code
4582 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4583 Property and Operator classes are not created when we parse the
4584 declarator but until we have the block completed, so we use a
4585 singleton SimpleIteratorContainer.Simple to flag whether the
4586 SetYields has been invoked.
4588 We propagate this setting then to the Property or the Operator to
4589 allow the `yield' to function.
4591 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4593 * codegen.cs: Implemented attribute support for modules.
4594 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4595 Assembly/Module functionality.
4597 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4598 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4599 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4601 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4603 * interface.cs (FindMembers): The operation is performed on all base
4604 interfaces and not only on the first. It is required for future CLS Compliance patch.
4606 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4608 * statement.cs, codegen.cs:
4609 This patch deals with patterns such as:
4611 public class List : IEnumerable {
4613 public MyEnumerator GetEnumerator () {
4614 return new MyEnumerator(this);
4617 IEnumerator IEnumerable.GetEnumerator () {
4621 public struct MyEnumerator : IEnumerator {
4626 Before, there were a few things we did wrong:
4627 1) we would emit callvirt on a struct, which is illegal
4628 2) we emited ldarg when we needed to emit ldarga
4629 3) we would mistakenly call the interface methods on an enumerator
4630 type that derived from IEnumerator and was in another assembly. For example:
4632 public class MyEnumerator : IEnumerator
4634 Would have the interface methods called, even if there were public impls of the
4635 method. In a struct, this lead to invalid IL code.
4637 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4639 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4642 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4644 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4646 * cs-parser.jay: Fix small regression: we were not testing V2
4647 compiler features correctly.
4649 * interface.cs: If the emit context is null, then create one
4651 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4653 * decl.cs (GetSignatureForError): New virtual method to get full name
4656 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4657 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4659 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4660 Duplicated members and code in these classes has been removed.
4661 Better encapsulation in these classes.
4663 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4665 * assign.cs (Assign.DoResolve): When dealing with compound
4666 assignments, there is a new rule in ECMA C# 2.4 (might have been
4667 there before, but it is documented here) that states that in:
4671 If b is of type int, and the `op' is a shift-operator, then the
4672 above is evaluated as:
4676 * expression.cs (Binary.ResolveOperator): Instead of testing for
4677 int/uint/long/ulong, try to implicitly convert to any of those
4678 types and use that in pointer arithmetic.
4680 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4681 method to print information for from the type, not from the
4682 null-method we were given.
4684 2004-02-01 Duncan Mak <duncan@ximian.com>
4686 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4687 parsing for cmd, fixes bug #53694.
4689 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4691 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4692 in the member name duplication tests. Property and operator name duplication
4693 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4695 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4697 * interface.cs (PopulateMethod): Fixed crash when interface method
4698 returns not existing type (error test cs0246-3.cs).
4700 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4702 * cs-parser.jay (interface_accessors): Re-write actions to also
4703 store attributes attached to get and set methods. Fix spelling
4706 (inteface_property_declaration): Modify accordingly.
4708 (InterfaceAccessorInfo): New helper class to store information to pass
4709 around between rules that use interface_accessors.
4711 * interface.cs (Emit): Apply attributes on the get and set
4712 accessors of properties and indexers too.
4714 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4715 right MethodBuilder when applying attributes to the get and set accessors.
4717 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4719 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4721 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4723 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4725 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4727 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4728 changes that treat `yield' specially when present before `break'
4731 * cs-tokenizer.cs: yield is no longer a keyword.
4733 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4735 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4736 setting for default constructors.
4737 For default constructors are almost every time set wrong Modifier. The
4738 generated IL code has been alright. But inside mcs this values was
4739 wrong and this was reason why several of my CLS Compliance tests
4742 2004-01-22 Martin Baulig <martin@ximian.com>
4744 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4745 not a QualifiedIdentifier. This is what `type_name_expression'
4746 was previously doing.
4747 (type_name_expression): Removed; the code is now in
4748 `namespace_or_type_name'.
4749 (qualified_identifier): Removed, use `namespace_or_type_name'
4751 (QualifiedIdentifier): Removed this class.
4753 2004-01-22 Martin Baulig <martin@ximian.com>
4755 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4756 not a string as alias name.
4758 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4760 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4761 #52730 bug, and instead compute correctly the need to use a
4762 temporary variable when requesting an address based on the
4763 static/instace modified of the field and the constructor.
4765 2004-01-21 Martin Baulig <martin@ximian.com>
4767 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4768 class and namespace before looking up aliases. Fixes #52517.
4770 2004-01-21 Martin Baulig <martin@ximian.com>
4772 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4773 assinged in a 'try'; fixes exception4.cs.
4775 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4776 * class.cs : Implemented parameter-less constructor for TypeContainer
4778 * decl.cs: Attributes are now stored here. New property OptAttributes
4780 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4782 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4784 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4786 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4787 (CSharpSignature): New method for indexer and property signature.
4789 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4791 * pending.cs (IsVirtualFilter): Faster implementation.
4793 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4795 * typemanager.cs: Avoid inclusion of same assembly more than once.
4797 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4799 * cs-parser.jay: Fixed problem where the last assembly attribute
4800 has been applied also to following declaration (class, struct, etc.)
4802 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4804 * class.cs: Added error CS0538, CS0539 reporting.
4805 Fixed crash on Microsoft runtime when field type is void.
4807 * cs-parser.jay: Added error CS0537 reporting.
4809 * pending.cs: Added error CS0535 reporting.
4810 Improved error report for errors CS0536, CS0534.
4812 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4814 Merge a few bits from the Anonymous Method MCS tree.
4816 * statement.cs (ToplevelBlock): New class for toplevel methods,
4817 will hold anonymous methods, lifted variables.
4819 * cs-parser.jay: Create toplevel blocks for delegates and for
4820 regular blocks of code.
4822 2004-01-20 Martin Baulig <martin@ximian.com>
4824 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4825 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4826 and `NeedExplicitReturn'; added `IsLastStatement'.
4827 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4828 have a `ReturnLabel' or we're not unreachable.
4830 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4831 child's reachability; don't just override ours with it. Fixes
4832 #58058 (lluis's example).
4833 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4834 InFinally(), InLoop(), InSwitch() and
4835 BreakCrossesTryCatchBoundary() methods.
4837 * statement.cs (Return): Do all error checking in Resolve().
4838 Unless we are the last statement in a top-level block, always
4839 create a return label and jump to it.
4840 (Break, Continue): Do all error checking in Resolve(); also make
4841 sure we aren't leaving a `finally'.
4842 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4843 statement in a top-level block.
4844 (Block.Flags): Added `IsDestructor'.
4845 (Block.IsDestructor): New public property.
4847 2004-01-20 Martin Baulig <martin@ximian.com>
4849 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4851 2004-01-20 Martin Baulig <martin@ximian.com>
4853 * statement.cs (Statement.ResolveUnreachable): New public method.
4854 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4855 (Block.Resolve): Resolve unreachable statements.
4857 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4859 * expression.cs: We need to fix the case where we do
4860 not have a temp variable here.
4862 * assign.cs: Only expression compound assignments need
4863 temporary variables.
4865 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4867 * flowanalysis.cs: Reduce memory allocation in a few ways:
4868 - A block with no variables should not allocate a bit
4870 - A method with no out parameters does not need any tracking
4871 for assignment of the parameters, so we need not allocate
4874 public readonly Type[] VariableTypes;
4875 public readonly string[] VariableNames;
4876 Are redundant. The data is already stored in the variable
4877 map, so we need not allocate another array for it.
4878 - We need to add alot of checks for if (params | locals) == null
4879 due to the first two changes.
4881 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4883 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4884 implement IMemoryLocation, we store a copy on a local variable and
4885 take the address of it. Patch from Benjamin Jemlich
4887 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4888 to use a special "type_name_expression" rule which reduces the
4889 number of "QualifiedIdentifier" classes created, and instead
4890 directly creates MemberAccess expressions.
4892 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4894 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4895 that fixes #52853. Null literal assignment to ValueType
4897 * class.cs (MethodData.Emit): Instead of checking the name of the
4898 method to determine if its a destructor, create a new derived
4899 class from Method called Destructor, and test for that.
4901 * cs-parser.jay: Create a Destructor object instead of a Method.
4903 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4907 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4909 * expression.cs (Binary.ResolveOperator): Perform an implicit
4910 conversion from MethodGroups to their delegate types on the
4913 * delegate.cs: Introduce a new class DelegateCreation that is the
4914 base class for `NewDelegate' and `ImplicitDelegateCreation',
4915 factor some code in here.
4917 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4918 conversion from MethodGroups to compatible delegate types.
4920 * ecore.cs (Expression.Resolve): Do not flag error 654
4921 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4922 we allow conversions from MethodGroups to delegate types now.
4924 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4925 assignments in v2 either.
4927 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4929 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4930 static read-only fields in ctors.
4932 Applied patch from Benjamin Jemlich
4934 * expression.cs (UnaryMutator): Avoid leaking local variables.
4936 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4938 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4939 here to return true, as they can be used like this:
4943 Fixed 49836 and all the other dups
4945 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4947 * driver.cs: Implement /win32res and /win32icon.
4949 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4951 * cs-parser.jay: Add a rule to improve error handling for the
4952 common mistake of placing modifiers after the type.
4954 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4956 * cs-parser.jay (interface_event_declaration): Catch
4957 initialization of events on interfaces, and report cs0068
4959 * cs-parser.jay (interface_event_declaration): Catch
4960 initialization of events.
4962 * ecore.cs: Better report missing constructors.
4964 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4965 the error reporting done in the wrong place. Fix.
4967 * expression.cs (Binary.ResolveOperator): Catch the
4968 operator + (E x, E y) error earlier, and later allow for implicit
4969 conversions in operator +/- (E e, U x) from U to the underlying
4972 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4973 52596, if the container class is abstract, the default constructor
4974 is protected otherwise its public (before, we were always public).
4976 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
4979 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
4980 Jemlich that fixes bug #52597, MCS was generating invalid code for
4981 idisposable structs. Thanks to Ben for following up with this
4984 2004-01-06 Miguel de Icaza <miguel@ximian.com>
4986 * driver.cs: Allow assemblies without code to be generated, fixes
4989 2004-01-07 Nick Drochak <ndrochak@gol.com>
4991 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
4993 2004-01-05 Miguel de Icaza <miguel@ximian.com>
4995 * cs-parser.jay: Add rules to improve error reporting if fields or
4996 methods are declared at the namespace level (error 116)
4998 * Add rules to catch event add/remove
5000 2004-01-04 David Sheldon <dave-mono@earth.li>
5002 * expression.cs: Added matching ")" to error message for
5005 2004-01-03 Todd Berman <tberman@gentoo.org>
5007 * ecore.cs, attribute.cs:
5008 Applying fix from #52429.
5010 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5012 * ecore.cs, expression.cs, statement.cs:
5013 Total rewrite of how we handle branching. We
5014 now handle complex boolean expressions with fewer
5015 jumps. As well if (x == 0) no longer emits a ceq.
5017 if (x is Foo) is much faster now, because we generate
5020 Overall, we get a pretty big improvement on our benchmark
5021 tests. The code we generate is smaller and more readable.
5023 I did a full two-stage bootstrap. The patch was reviewed
5024 by Martin and Miguel.
5026 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5028 * cs-parser.jay: Make primary_expression not take a QI.
5029 we dont need this because the member_access rule covers
5030 us here. So we replace the rule with just IDENTIFIER.
5032 This has two good effects. First, we remove a s/r conflict.
5033 Second, we allocate many fewer QualifiedIdentifier objects.
5035 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5037 * attribute.cs: Handle MarshalAs attributes as pseudo, and
5038 set the correct information via SRE. This prevents
5039 hanging on the MS runtime. Fixes #29374.
5041 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5043 * convert.cs: correctly handle conversions to value types
5044 from Enum and ValueType as unboxing conversions.
5046 Fixes bug #52569. Patch by Benjamin Jemlich.
5048 2004-01-02 Ravi Pratap <ravi@ximian.com>
5050 * expression.cs (BetterConversion): Prefer int -> uint
5051 over int -> ulong (csc's behaviour). This fixed bug #52046.
5053 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
5055 * decl.cs (MemberCache.FindMembers): now returns a
5058 * typemanager.cs: In general, go with with ^^.
5059 (CopyNewMethods): take an IList.
5060 (RealMemberLookup): Only allocate an arraylist
5061 if we copy from two sets of methods.
5063 This change basically does two things:
5064 1) Fewer array lists allocated due to CopyNewMethods.
5065 2) the explicit cast in MemberList costed ALOT.
5067 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
5069 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
5070 a hashtable to avoid needless string allocations when an identifier is
5071 used more than once (the common case).
5073 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5075 * pending.cs: MS's TypeBuilder.GetInterfaces ()
5076 is broken, it will not return anything. So, we
5077 have to use the information we have in mcs to
5080 * typemanager.cs: Add a cache for GetInterfaces,
5081 since this will now be used more often (due to ^^)
5083 (GetExplicitInterfaces) New method that gets the
5084 declared, not effective, interfaces on a type
5085 builder (eg, if you have interface IFoo, interface
5086 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
5089 This patch makes MCS able to bootstrap itself on
5092 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5094 * expression.cs: Remove the Nop's that Miguel put
5097 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5099 * report.cs, codegen.cs: Give the real stack trace to
5100 the error when an exception is thrown.
5102 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5104 * decl.cs: only allocate hashtables for ifaces if
5107 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5109 * expression.cs: fix the error from cs0121-2.cs
5110 (a parent interface has two child interfaces that
5111 have a function with the same name and 0 params
5112 and the function is called through the parent).
5114 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
5116 * class.cs, rootcontext.cs, typmanager.cs: do not
5119 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
5121 * codegen.cs: remove stack for the ec flow branching.
5122 It is already a linked list, so no need.
5124 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
5126 * Makefile: Allow custom profiler here.
5128 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5130 * typemanager.cs (LookupType):
5131 - Use a static char [], because split takes
5132 a param array for args, so it was allocating
5134 - Do not store true in a hashtable, it boxes.
5136 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5138 * flowanalysis.cs: bytify common enums.
5140 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5142 * modifiers.cs: Add a new set of flags for the
5143 flags allowed on explicit interface impls.
5144 * cs-parser.jay: catch the use of modifiers in
5145 interfaces correctly.
5146 * class.cs: catch private void IFoo.Blah ().
5148 All related to bug #50572.
5150 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5152 * decl.cs: Rewrite the consistant accessability checking.
5153 Accessability is not linear, it must be implemented in
5154 a tableish way. Fixes #49704.
5156 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5158 * expression.cs: Handle negation in a checked context.
5159 We must use subtraction from zero. Fixes #38674.
5161 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5163 * class.cs: Ignore static void main in DLLs.
5164 * rootcontext.cs: Handle the target type here,
5165 since we are have to access it from class.cs
5166 * driver.cs: account for the above.
5168 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5170 * report.cs: Give line numbers and files if available.
5172 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
5174 * driver.cs: Implement /addmodule.
5176 * typemanager.cs: Change 'modules' field so it now contains Modules not
5179 2003-12-20 Martin Baulig <martin@ximian.com>
5181 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
5182 (FieldBase.IsAssigned): Removed this field.
5183 (FieldBase.SetAssigned): New public method.
5184 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
5186 2003-12-20 Martin Baulig <martin@ximian.com>
5188 * expression.cs (LocalVariableReference.DoResolve): Don't set
5189 `vi.Used' if we're called from DoResolveLValue().
5191 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
5192 returns the usage vector it just merged into the current one -
5193 pass this one to UsageWarning().
5194 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
5195 of the `EmitContext', don't call this recursively on our children.
5197 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
5199 * driver.cs: Implement /target:module.
5201 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
5203 * support.cs (CharArrayHashtable): New helper class.
5205 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
5206 char arrays, not strings, so we can avoid creating a string in
5207 consume_identifier if the identifier is a keyword.
5209 2003-12-16 Martin Baulig <martin@ximian.com>
5211 * statement.cs (LocalInfo.Assigned): Removed this property.
5212 (LocalInfo.Flags): Removed `Assigned'.
5213 (LocalInfo.IsAssigned): New public method; takes the EmitContext
5214 and uses flow analysis.
5215 (Block.UsageWarning): Made this method private.
5216 (Block.Resolve): Call UsageWarning() if appropriate.
5218 * expression.cs (LocalVariableReference.DoResolve): Always set
5219 LocalInfo.Used here.
5221 2003-12-13 Martin Baulig <martin@ximian.com>
5223 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
5224 any value here; we're now using flow analysis to figure out
5225 whether a statement/block returns a value.
5227 2003-12-13 Martin Baulig <martin@ximian.com>
5229 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
5231 (FlowBranching.MergeFinally): Don't call
5232 `branching.CheckOutParameters()' here, this is called in
5234 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
5235 when adding the `finally' vector.
5237 2003-12-13 Martin Baulig <martin@ximian.com>
5240 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
5241 actually work and also fix #48962.
5243 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
5245 * decl.cs: Do not check System.Object for nested types,
5246 since we know it does not have any. Big bang for buck:
5251 corlib: 17.99 seconds
5255 corlib: 17.39 seconds
5257 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5259 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5260 time we are returning 0 members, so we save alot here.
5262 2003-12-11 Martin Baulig <martin@ximian.com>
5264 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5265 `MergeChild()', also just take the `FlowBranching' as argument;
5266 call Merge() on it and return the result.
5267 (FlowBranching.Merge): We don't need to do anything if we just
5270 2003-12-11 Martin Baulig <martin@ximian.com>
5272 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5273 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5274 Maurer for this idea.
5276 2003-12-11 Martin Baulig <martin@ximian.com>
5278 * flowanalysis.cs (MergeResult): This class is now gone; we now
5279 use the `UsageVector' for this. The reason for this is that if a
5280 branching just has one sibling, we don't need to "merge" them at
5281 all - that's the next step to do.
5282 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5285 2003-12-11 Martin Baulig <martin@ximian.com>
5287 Reworked flow analyis and made it more precise and bug-free. The
5288 most important change is that we're now using a special `Reachability'
5289 class instead of having "magic" meanings of `FlowReturns'. I'll
5290 do some more cleanups and optimizations and also add some more
5291 documentation this week.
5293 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5294 largely reworked this class.
5295 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5296 the new `Reachability' class instead of having "magic" values here.
5297 (FlowBranching): We're now using an instance of `Reachability'
5298 instead of having separate `Returns', `Breaks' etc. fields.
5300 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5301 based on flow analysis; ignore the return value of block.Emit ().
5303 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5305 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5306 if they are private.
5308 2003-12-09 Martin Baulig <martin@ximian.com>
5310 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5311 call them directly on the UsageVector.
5313 2003-12-09 Martin Baulig <martin@ximian.com>
5315 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5316 Changed return type from `FlowReturns' to `Reachability'.
5318 2003-12-09 Martin Baulig <martin@ximian.com>
5320 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5321 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5322 `Reachable' fields with a single `Reachability' one.
5324 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5326 * class.cs (FindMembers): Remove foreach's.
5339 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5344 This patch does a few things:
5345 1. EmptyStatement is now a singleton, so it is never reallocated.
5346 2. All blah is EmptyStatement constructs have been changed to
5347 blah == EmptyStatement.Value, which is much faster and valid
5348 now that EmptyStatement is a singleton.
5349 3. When resolving a block, rather than allocating a new array for
5350 the non-empty statements, empty statements are replaced with
5351 EmptyStatement.Value
5352 4. Some recursive functions have been made non-recursive.
5353 Mainly the performance impact is from (3), however (1) and (2) are needed for
5354 this to work. (4) does not make a big difference in normal situations, however
5355 it makes the profile look saner.
5360 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5361 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5362 Total memory allocated: 56397 KB
5365 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5366 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5367 Total memory allocated: 55666 KB
5369 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5371 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5372 than the hashtable in a hashtable version
5374 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5375 we always end up concating a string. This results in a huge perf
5376 loss, because many strings have to be tracked by the GC. In this
5377 patch, we first use a hashtable that works with two keys, so that
5378 the strings do not need to be concat'ed.
5389 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5391 * Makefile: Add a new target `do-time' that does a quick and simple
5392 profile, leaving easy to parse output.
5394 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5396 * codegen.cs (Init): Create the dynamic assembly with
5397 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5399 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5401 * support.cs: Make the PtrHashtable use only one
5402 instance of its comparer.
5404 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5406 * typemanager.cs: Fix lookup of GetNamespaces.
5408 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5410 * expression.cs: Removed redundant line.
5412 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5413 ArrayLists, use for loops with bounds.
5415 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5418 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5419 arraylists, use for loop with bounds.
5421 The above three changes give us a 0.071 second performance
5422 improvement out of 3.294 seconds down to 3.223. On my machine
5423 the above changes reduced the memory usage by 1,387 KB during
5426 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5427 QualifiedIdentifiers. Before we created a new string through
5428 concatenation, and mostly later on, the result would be
5429 manipulated by DecomposeQI through string manipulation.
5431 This reduced the compiler memory usage for bootstrapping from
5432 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5433 compile times in 0.05 seconds.
5435 2003-11-28 Dick Porter <dick@ximian.com>
5437 * support.cs: Do string compares with the Invariant culture.
5445 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5446 the comparison is done with the Invariant culture.
5448 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5450 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5451 GetEnumerator method.
5453 (ProbeCollectionType): Iterate starting at the most specific type
5454 upwards looking for a GetEnumerator
5456 * expression.cs: Shift count can be up to 31 for int/uint and 63
5459 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5461 * statement.cs (Block.LookupLabel): Also look for the label on the
5462 children blocks. Use a hash table to keep track of visited
5465 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5466 we actually did transform the other operand, otherwise fall back
5467 to the common codepath that casts to long.
5469 * cs-tokenizer.cs: Use the same code pattern as the int case.
5470 Maybe I should do the parsing myself, and avoid depending on the
5471 Parse routines to get this done.
5473 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5475 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5476 which fixes bug 51347. This time test it.
5478 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5479 attributes for example can not tell the difference between these.
5480 The difference was only a syntax feature of the language.
5482 * attribute.cs: Apply attributes to delegates.
5484 * delegate.cs: Call the apply attributes method.
5486 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5488 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5489 comparing 0 vs Byte.MinValue, not the value
5491 (ImplicitConversionRequired): When reporting a conversion error,
5492 use error 31 to print out the constant error instead of the
5495 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5496 which fixes bug 51347.
5498 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5500 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5501 which fixes the -warnaserror command line option.
5503 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5505 * cfold.cs (DoNumericPromotions): During constant folding of
5506 additions on UIntConstant, special case intconstants with
5507 IntConstants like we do on the expression binary operator.
5509 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5511 * convert.cs (ImplicitReferenceConversion): We were missing a case
5512 (System.Enum are not value types or class types, so we need to
5513 classify them separatedly).
5515 * driver.cs: We do not support error 2007.
5517 2003-11-12 Jackson Harper <jackson@ximian.com>
5519 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5520 system directory. Also use the full file name so users can
5521 libraries names mscorlib-o-tron.dll in a non system dir.
5523 2003-11-10 Martin Baulig <martin@ximian.com>
5525 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5526 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5527 calling `ResolveType()' on them, directly assign their `Type'.
5529 2003-11-08 Martin Baulig <martin@ximian.com>
5531 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5532 return value and the `out parent' parameter.
5533 (TypeContainer.DefineType): Moved the CS0644 check into
5534 GetClassBases(). Don't pass the interface types to the
5535 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5536 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5538 * ecore.cs (TypeExpr.IsAttribute): New property.
5539 (TypeExpr.GetInterfaces): New method.
5541 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5542 TypeExpr instead of a Type.
5543 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5544 (Interface.DefineType): Don't pass the interface types to the
5545 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5546 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5548 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5549 instead of a `Type[]'.
5550 (TypeManager.RegisterBuilder): Likewise.
5551 (TypeManager.AddUserInterface): Likewise.
5552 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5553 `Type[]' and also return a `TypeExpr[]'.
5554 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5556 2003-11-08 Martin Baulig <martin@ximian.com>
5558 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5561 2003-11-08 Martin Baulig <martin@ximian.com>
5563 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5564 TypeManager.ResolveExpressionTypes().
5566 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5567 instead of an Expression.
5568 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5569 (TypeExpression): New public class; formerly known as `TypeExpr'.
5571 * expression.cs (ComposedCast): Derive from TypeExpr.
5573 * typemanager.cs (TypeManager.system_*_expr): These are now
5574 TypExpr's instead of Expression's.
5575 (TypeManager.ResolveExpressionTypes): New public static function;
5576 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5579 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5581 * expression.cs (New.DoResolve): Do not dereference value that
5582 might be a null return.
5584 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5585 sure that the constant value has the right type. Fixes an
5586 unreported bug, similar to 50425.
5588 * const.cs (Const.LookupConstantValue): Call
5589 ImplicitStandardConversionExists before doing a conversion to
5590 avoid havng the TypeManager.ChangeType do conversions.
5592 Reduced the number of casts used
5594 (Const.ChangeType): New routine to enable reuse of the constant
5595 type changing code from statement.
5597 * typemanager.cs (ChangeType): Move common initialization to
5598 static global variables.
5602 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5603 every value type to go through, even if it was void. Fix that.
5605 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5606 character of the define, and the is_identifier_part_character for
5607 the rest of the string.
5609 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5611 * expression.cs (UnaryMutator.EmitCode): When I updated
5612 LocalVariableReference.DoResolve, I overdid it, and dropped an
5613 optimization done on local variable references.
5615 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5617 * ecore.cs: Convert the return from Ldlen into an int.
5619 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5621 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5622 the accessibility, this is a special case for toplevel non-public
5623 classes (internal for instance).
5625 2003-10-20 Nick Drochak <ndrochak@gol.com>
5627 * ecore.cs: Fix typo and build. Needed another right paren.
5629 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5631 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5632 `internal' case regular and protected, but not allowing protected
5633 to be evaluated later. Bug 49840
5635 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5637 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5638 to kb.Nlast, and not the kb.nFirst to isolate the switch
5641 Extract the underlying type, so enumerations of long/ulong are
5642 treated like long/ulong.
5644 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5646 * expression.cs (New): Overload the meaning of RequestedType to
5647 track the possible creation of the NewDelegate type, since
5648 DoResolve is invoked more than once for new constructors on field
5651 See bugs: #48800 and #37014
5653 * cs-parser.jay (declare_local_constants): Take an arraylist
5654 instead of a single constant.
5656 (local_constant_declaration): It should take a
5657 constant_declarators, not a constant_declarator. Fixes 49487
5659 * convert.cs: Fix error report.
5661 2003-10-13 Jackson Harper <jackson@ximian.com>
5663 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5666 2003-10-09 Martin Baulig <martin@ximian.com>
5668 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5670 (MethodCore.DoDefineParameters): Removed the TypeContainer
5671 argument; use the DeclSpace which was passed to the .ctor instead.
5672 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5673 TypeContainer; we only need a DeclSpace here.
5675 2003-10-09 Martin Baulig <martin@ximian.com>
5677 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5679 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5680 EmitContext's .ctor.
5682 2003-10-09 Martin Baulig <martin@ximian.com>
5684 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5685 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5686 AsAccessible(), moved them as well.
5688 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5690 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5692 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5694 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5696 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5697 generation for >=, as spotted by Paolo, bug 48679.
5698 Patch from David Waite.
5700 * cs-tokenizer.cs: Add handling for #pragma.
5702 * cs-parser.jay: Allow for both yield and yield return in the
5703 syntax. The anti-cobolization of C# fight will go on!
5705 * class.cs (TypeBuilder.DefineType): Catch error condition here
5706 (Parent.DefineType erroring out and returning null).
5708 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5709 coping with enumerations variables, we were mistakenly processing
5710 them as a regular value type instead of built-in types. Fixes the
5713 * typemanager.cs (IsBuiltinOrEnum): New method.
5715 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5717 * cs-parser.jay: Upgrade: yield now needs the return clause.
5719 2003-09-19 Martin Baulig <martin@ximian.com>
5721 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5722 `MemberCache parent' argument. Normally, an interface doesn't
5723 have a parent type except System.Object, but we use this in gmcs
5724 for generic type parameters.
5726 2003-09-18 Martin Baulig <martin@ximian.com>
5728 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5729 on `type.IsInterface'; don't check whether the type has a parent
5730 to determine whether it's an interface.
5732 2003-09-15 Martin Baulig <martin@ximian.com>
5734 * class.cs (TypeContainer.DefineType): Added an error flag to
5735 avoid reporting duplicate CS0146's ("class definition is
5738 * driver.cs (Driver.MainDriver): Abort if
5739 RootContext.ResolveTree() reported any errors.
5741 2003-09-07 Martin Baulig <martin@ximian.com>
5743 * report.cs (Error, Warning): Added overloaded versions which take
5744 a `params object[] args' and call String.Format().
5746 2003-09-07 Martin Baulig <martin@ximian.com>
5748 * decl.cs (DeclSpace..ctor): Don't call
5749 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5750 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5751 (DeclSpace.RecordDecl): New method.
5753 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5755 2003-09-02 Ravi Pratap <ravi@ximian.com>
5757 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5758 value attributes to be applied to ParameterBuilders.
5760 * class.cs (MethodCore.LabelParameters): Make static and more
5761 generic so that it can be used from other places - like interface
5762 methods, for instance.
5764 * interface.cs (Interface.Emit): Call LabelParameters before
5765 emitting attributes on the InterfaceMethod.
5767 2003-08-26 Martin Baulig <martin@ximian.com>
5769 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5770 resolving aliases; fixes #47927.
5772 2003-08-26 Martin Baulig <martin@ximian.com>
5774 * statement.cs (Using.DoResolve): This is internally emitting a
5775 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5776 do not always return. Fixes #47681.
5778 2003-08-26 Martin Baulig <martin@ximian.com>
5780 * decl.cs (MemberCore): Moved WarningNotHiding(),
5781 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5783 (AdditionResult): Make this nested in DeclSpace.
5784 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5785 argument; call NamespaceEntry.Define() unless we're nested in a
5788 * namespace.cs (Namespace.DefineName): New public function. This
5789 is called from DeclSpace's .ctor to add
5790 (Namespace.Lookup): Include DeclSpaces in the lookup.
5792 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5794 * const.cs (Const): Derive from MemberBase, not MemberCore.
5796 2003-08-25 Martin Baulig <martin@ximian.com>
5798 * convert.cs (Convert.ExplicitReferenceConversion): When
5799 converting from an interface type to a class, unbox if the target
5800 type is a struct type. Fixes #47822.
5802 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5804 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5807 2003-08-22 Martin Baulig <martin@ximian.com>
5809 * class.cs (TypeManager.DefineType): When defining a nested type,
5810 call DefineType() on our parent; fixes #47801.
5812 2003-08-22 Martin Baulig <martin@ximian.com>
5814 * class.cs (MethodData.Define): While checking if a method is an
5815 interface implementation, improve the test a bit more to fix #47654.
5817 2003-08-22 Martin Baulig <martin@ximian.com>
5819 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
5820 correctly; fixes #47722.
5822 2003-08-22 Martin Baulig <martin@ximian.com>
5824 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
5825 LocalVariableReference, ensure it's not read-only. Fixes #47536.
5827 * statement.cs (Fixed.DoResolve): Make all variables read-only.
5829 2003-08-22 Martin Baulig <martin@ximian.com>
5831 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
5832 can only be assigned in static constructors. Fixes #47161.
5834 2003-08-22 Martin Baulig <martin@ximian.com>
5836 Rewrote and improved the flow analysis code.
5838 * flowbranching.cs (FlowBranching): Make this class abstract.
5839 (FlowBranching.CreateBranching): New static function to create a
5841 (FlowBranchingBlock, FlowBranchingException): New classes.
5842 (FlowBranching.UsageVector.Type): New public readonly field.
5843 (FlowBranching.UsageVector.Breaks): Removed the setter.
5844 (FlowBranching.UsageVector.Returns): Removed the setter.
5845 (FlowBranching.UsageVector): Added Break(), Return(),
5846 NeverReachable() and Throw() methods to modify the reachability.
5847 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
5848 done by FlowBranching.Merge().
5849 (FlowBranching.UsageVector.MergeChild): New method; merges the
5850 merge result into the current vector.
5851 (FlowBranching.Merge): New abstract method to merge a branching.
5853 2003-08-12 Martin Baulig <martin@ximian.com>
5855 * expression.cs (Indirection.CacheTemporaries): Create the
5856 LocalTemporary with the pointer type, not its element type.
5858 2003-08-10 Miguel de Icaza <miguel@ximian.com>
5860 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
5861 token was a keyword or not.
5863 Add `error' options where an IDENTIFIER was expected; Provide
5864 CheckToken and CheckIdentifierToken convenience error reporting
5867 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
5869 * decl.cs: Rename `NamespaceEntry Namespace' public field into
5870 NameSpaceEntry NameSpaceEntry.
5872 (LookupInterfaceOrClass): Avoid creating a full qualified name
5873 from namespace and name: avoid doing lookups when we know the
5874 namespace is non-existant. Use new Tree.LookupByNamespace which
5875 looks up DeclSpaces based on their namespace, name pair.
5877 * driver.cs: Provide a new `parser verbose' to display the
5878 exception thrown during parsing. This is turned off by default
5879 now, so the output of a failure from mcs is more graceful.
5881 * namespace.cs: Track all the namespaces defined in a hashtable
5884 (IsNamespace): New method
5886 2003-08-09 Miguel de Icaza <miguel@ximian.com>
5888 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
5889 we know that we need to concatenate (full typename can never be
5894 * statement.cs: Use a bitfield; Do not initialize to null things
5895 which are done by the constructor by default.
5897 * cs-parser.jay: bug fix, parameter was 4, not 3.
5899 * expression.cs: Just use the property;
5901 * statement.cs: No need for GetVariableInfo method.
5903 2003-08-08 Martin Baulig <martin@ximian.com>
5905 * flowanalysis.cs (FlowReturns): This is now nested in the
5906 `FlowBranching' class.
5907 (MyBitVector): Moved this here from statement.cs.
5908 (FlowBranching.SiblingType): New enum type.
5909 (FlowBranching.CreateSibling): Added `SiblingType' argument.
5911 2003-08-07 Martin Baulig <martin@ximian.com>
5913 * flowanalysis.cs (FlowBranchingType): This is now nested in the
5914 `FlowBranching' class and called `BranchingType'.
5916 2003-08-07 Martin Baulig <martin@ximian.com>
5918 * flowanalysis.cs: Moved all the control flow analysis code into
5921 2003-08-07 Martin Baulig <martin@ximian.com>
5923 * assign.cs (Assign.DoResolve): `target' must either be an
5924 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
5927 2003-08-07 Miguel de Icaza <miguel@ximian.com>
5929 * expression.cs (BinaryMethod): This kind of expression is created by the
5930 Binary class if it determines that the operator has to be handled
5933 (BinaryDelegate): This kind of expression is created if we are
5934 dealing with a + or - operator on delegates.
5936 (Binary): remove method, argumetns, and DelegateOperator: when
5937 dealing with methods,
5939 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
5941 * statement.cs (Block): use bitfields for the three extra booleans
5942 we had in use. Remove unused topblock parameter.
5944 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
5946 * assign.cs: Drop extra unneeded tests.
5948 2003-08-06 Miguel de Icaza <miguel@ximian.com>
5950 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
5952 * statement.cs (Foreach): Use VariableStorage instead of
5955 * codegen.cs (VariableStorage): New class used by clients that
5956 require a variable stored: locals or fields for variables that
5957 need to live across yield.
5959 Maybe provide a convenience api for EmitThis+EmitLoad?
5961 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
5964 2003-08-05 Miguel de Icaza <miguel@ximian.com>
5966 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
5967 RemapParameterLValue): New methods that are used to turn a
5968 precomputed FieldInfo into an expression like this:
5972 The idea is to use this instead of making LocalVariableReference
5973 have more than one meaning.
5975 * cs-parser.jay: Add error production to BASE.
5977 * ecore.cs: Deal with TypeManager.GetField returning null, which
5978 is now a valid return value.
5980 (FieldExprNoAddress): New expression for Fields whose address can
5983 * expression.cs (LocalVariableReference): During the resolve
5984 phases, create new expressions if we are in a remapping context.
5985 Remove code that dealt with remapping here.
5987 (ParameterReference): same.
5989 (ProxyInstance): New expression, like the `This' expression, but
5990 it is born fully resolved. We know what we are doing, so remove
5991 the errors that are targeted to user-provided uses of `this'.
5993 * statement.cs (Foreach): our variable is now stored as an
5994 Expression; During resolution, follow the protocol, dont just
5995 assume it will return this.
5997 2003-08-06 Martin Baulig <martin@ximian.com>
5999 * support.cs (SeekableStreamReader.cs): New public class.
6001 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
6002 SeekableStreamReader instead of the normal StreamReader.
6004 2003-08-04 Martin Baulig <martin@ximian.com>
6006 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
6007 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
6008 deambiguate casts and delegate invocations.
6009 (parenthesized_expression): Use the new tokens to ensure this is
6010 not a cast of method invocation.
6012 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
6013 when reading a `)' and Deambiguate_CloseParens () was previously
6016 * expression.cs (ParenthesizedExpression): New class. This is
6017 just used for the CS0075 test.
6018 (Binary.DoResolve): Check for CS0075.
6020 2003-07-29 Ravi Pratap <ravi@ximian.com>
6022 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
6023 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
6024 reference comparison.
6026 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
6027 examine the ReturnType for equality - this is necessary in the
6028 cases of implicit and explicit operators whose signature also
6029 includes the return type.
6031 2003-07-26 Miguel de Icaza <miguel@ximian.com>
6033 * namespace.cs: Cache the result of the namespace computation,
6034 instead of computing it every time.
6036 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6038 * decl.cs: Use a global arraylist that we reuse over invocations
6039 to avoid excesive memory consumption. Reduces memory usage on an
6040 mcs compile by one meg (45 average).
6042 * typemanager.cs (LookupTypeReflection): In .NET pointers are
6043 private, work around that.
6045 2003-07-23 Miguel de Icaza <miguel@ximian.com>
6047 * literal.cs (IntLiteral): Define Zero and One static literals.
6049 * cs-parser.jay (integer_literal): use static literals to reduce
6050 memory usage for the most used literals (0, 1 and -1). 211kb
6051 reduced in memory usage.
6053 Replace all calls to `new ArrayList' with `new
6054 ArrayList(4)' which is a good average number for most allocations,
6055 and also requires only 16 bytes of memory for its buffer by
6058 This reduced MCS memory usage in seven megabytes for the RSS after
6061 2003-07-28 Ravi Pratap <ravi@ximian.com>
6063 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
6064 handle params methods the correct way by forming only one
6065 applicable set with params and normal methods in them. Earlier we
6066 were looking at params methods only if we found no normal methods
6067 which was not the correct thing to do.
6069 (Invocation.BetterFunction): Take separate arguments indicating
6070 when candidate and the best method are params methods in their
6073 This fixes bugs #43367 and #46199.
6075 * attribute.cs: Documentation updates.
6077 (CheckAttribute): Rename to CheckAttributeTarget.
6078 (GetValidPlaces): Rename to GetValidTargets.
6080 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
6081 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
6085 2003-07-28 Martin Baulig <martin@ximian.com>
6087 * class.cs (TypeContainer.DefineMembers): Use the base type's full
6088 name when looking up the base class of a nested class. Fixes #46977.
6090 2003-07-26 Martin Baulig <martin@ximian.com>
6092 * expression.cs (Indexers.Indexer): New nested struct; contains
6093 getter, setter and the indexer's type.
6094 (Indexers.Properties): This is now an ArrayList of
6096 (IndexerAccess.DoResolveLValue): Correctly set the type if the
6097 indexer doesn't have any getters.
6099 * assign.cs (Assign.DoResolve): Also do the implicit conversions
6100 for embedded property and indexer assignments.
6102 2003-07-26 Martin Baulig <martin@ximian.com>
6104 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
6105 preprocessor directive is not the first non-whitespace character
6108 2003-07-26 Martin Baulig <martin@ximian.com>
6110 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
6111 namespace parsing, follow the spec more closely.
6113 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
6114 NamespaceEntry.Lookup().
6116 2003-07-25 Martin Baulig <martin@ximian.com>
6118 * MethodCore.cs (OverridesSomething): New public field; it's set
6119 from TypeContainer.DefineMembers if this method overrides
6120 something (which doesn't need to be a method). Fix #39462.
6122 2003-07-25 Ravi Pratap <ravi@ximian.com>
6124 * typemanager.cs (GetMembers): Ensure that the list of members is
6125 reversed. This keeps things in sync.
6127 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
6128 find an AttributeUsage attribute.
6130 * expression.cs (Invocation.OverloadResolve): Perform the check
6131 which disallows Invoke to be directly called on a Delegate.
6133 (Error_InvokeOnDelegate): Report error cs1533.
6135 2003-07-25 Martin Baulig <martin@ximian.com>
6137 * expression.cs (Indexers.GetIndexersForType): Only look in the
6138 interface hierarchy if the requested type is already an
6139 interface. Fixes #46788 while keeping #46502 fixed.
6141 2003-07-25 Martin Baulig <martin@ximian.com>
6143 * class.cs (TypeContainer.DefineMembers): Check whether all
6144 readonly fields have been assigned and report warning CS0649 if
6147 * statement.cs (LocalInfo.IsFixed): Always return true if this is
6150 2003-07-24 Ravi Pratap <ravi@ximian.com>
6152 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
6153 returned from GetMethods to make things consistent with the
6154 assumptions MCS makes about ordering of methods.
6156 This should comprehensively fix bug #45127 and it does :-)
6158 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
6159 ordering is actually reverse.
6161 * Clean up some debug messages I left lying around.
6163 * interface.cs (Populate*): Get rid of code which emits attributes
6164 since the stage in which we emit attributes is the 'Emit' stage,
6165 not the define stage.
6167 (Emit): Move attribute emission for interface members here.
6169 2003-07-22 Ravi Pratap <ravi@ximian.com>
6171 * expression.cs (Invocation.OverloadResolve): Follow the spec more
6172 closely: we eliminate methods in base types when we have an
6173 applicable method in a top-level type.
6175 Please see section 14.5.5.1 for an exact description of what goes
6178 This fixes bug #45127 and a host of other related to corlib compilation.
6180 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
6181 array is the method corresponding to the top-level type (this is
6182 because of the changes made to icall.c) so we change this
6185 (MethodGroupExpr.Name): This too.
6187 * typemanager.cs (GetElementType): New method which does the right
6188 thing when compiling corlib.
6190 * everywhere: Make use of the above in the relevant places.
6192 2003-07-22 Martin Baulig <martin@ximian.com>
6194 * cs-parser.jay (invocation_expression): Moved
6195 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
6196 `cast_expression', but create a InvocationOrCast which later
6197 resolves to either an Invocation or a Cast.
6199 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
6200 method; call this before EmitStatement() to make sure that this
6201 expression can be used as a statement.
6203 * expression.cs (InvocationOrCast): New class; resolves to either
6204 an Invocation or a Cast.
6206 * statement.cs (StatementExpression): Call ResolveStatement() on
6207 the ExpressionStatement before emitting it.
6209 2003-07-21 Martin Baulig <martin@ximian.com>
6211 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
6212 `ref' and `out' attributes match; fixes #46220.
6213 (MemberAccess.ResolveMemberAccess): You can't reference a type
6214 through an expression; fixes #33180.
6215 (Indexers.GetIndexersForType): Don't return the indexers from
6216 interfaces the class implements; fixes #46502.
6218 2003-07-21 Martin Baulig <martin@ximian.com>
6220 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
6221 CS0661 checks; fixes bug #30442.
6223 2003-07-21 Martin Baulig <martin@ximian.com>
6225 * decl.cs (AdditionResult): Added `Error'.
6227 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
6229 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
6230 makes cs0031.cs actually work.
6232 2003-07-20 Martin Baulig <martin@ximian.com>
6234 * namespace.cs: Fixed that bug which caused a crash when compiling
6237 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6239 * typemanager.cs (LookupTypeReflection): Never expose types which
6240 are NotPublic, NestedPrivate, NestedAssembly, or
6241 NestedFamANDAssem. We used to return these, and later do a check
6242 that would report a meaningful error, but the problem is that we
6243 would not get the real match, if there was a name override.
6245 2003-07-18 Miguel de Icaza <miguel@ximian.com>
6247 * namespace.cs (Namespace, Name): Do not compute the namespace
6248 name dynamically, compute it in the constructor. This reduced
6249 memory usage by 1697 KB.
6251 * driver.cs: Use --pause to pause at the end.
6253 2003-07-17 Peter Williams <peter@newton.cx>
6255 * Makefile: Change the name of the test target so that it doesn't
6256 conflict with the recursive test target.
6258 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6260 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6261 AddressOf): Do not use EmitThis, that was wrong, use the actual
6264 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6266 * class.cs (MethodData.Define): While checking if a method is an
6267 interface implementation, improve the test: If we are not public
6268 (use new test here: use the computed MethodAttributes directly,
6269 instead of the parsed modifier flags) check if the `implementing'
6270 method comes from an interface or not.
6272 * pending.cs (VerifyPendingMethods): Slightly better error
6275 * makefile: add test target that does the mcs bootstrap.
6277 2003-07-16 Ravi Pratap <ravi@ximian.com>
6279 * interface.cs (Define): Do nothing here since there are no
6280 members to populate etc. Move the attribute emission out of here
6281 since this was just totally the wrong place to put it. Attribute
6282 application happens during the 'Emit' phase, not in the 'Define'
6285 (Emit): Add this method and move the attribute emission here
6287 * rootcontext.cs (EmitCode): Call the Emit method on interface
6290 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6292 * expression.cs (OverloadResolve): Report error only if Location
6293 is not 'Null' which means that there was a probe going on.
6295 2003-07-14 Martin Baulig <martin@ximian.com>
6297 * expression.cs (ConditionalLogicalOperator): New public class to
6298 implement user defined conditional logical operators.
6299 This is section 14.11.2 in the spec and bug #40505.
6301 2003-07-14 Martin Baulig <martin@ximian.com>
6303 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6305 2003-07-14 Martin Baulig <martin@ximian.com>
6307 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6309 * ecore.cs (IVariable.VerifyFixed): New interface method.
6311 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6312 operator, check whether the variable is actually fixed. Fixes bug
6313 #36055. Set a variable definitely assigned when taking its
6314 address as required by the spec.
6316 * statement.cs (LocalInfo.IsFixed): New field.
6317 (LocalInfo.MakePinned): Set `IsFixed' to true.
6319 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6321 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6322 for .ctors, ensure that we only ask for members declared in the
6323 attribute type (BindingFlags.DeclaredOnly).
6327 * expression.cs (Error_WrongNumArguments): Report error 1501
6328 correctly the way CSC does.
6330 2003-07-13 Martin Baulig <martin@ximian.com>
6332 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6333 lookup on the fully qualified name, to make things like "X.X" work
6334 where "X.X" is a fully qualified type name, but we also have a
6335 namespace "X" in the using list. Fixes #41975.
6337 2003-07-13 Martin Baulig <martin@ximian.com>
6339 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6340 function. If we're a CompoundAssign, we need to create an embedded
6341 CompoundAssign, not an embedded Assign.
6342 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6345 2003-07-13 Martin Baulig <martin@ximian.com>
6347 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6348 work to fix bug #46088.
6350 2003-07-13 Ravi Pratap <ravi@ximian.com>
6352 * class.cs (Operator.Emit): Do not emit attributes here - it is
6353 taken care of by the Method class that we delegate too. This takes
6356 2003-07-10 Martin Baulig <martin@ximian.com>
6358 * expression.cs (TypeOfVoid): New class.
6359 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6361 2003-07-10 Martin Baulig <martin@ximian.com>
6363 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6366 2003-07-10 Martin Baulig <martin@ximian.com>
6368 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6369 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6371 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6373 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6375 2003-07-10 Martin Baulig <martin@ximian.com>
6377 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6378 of decimal. Fixes #42850.
6380 NOTE: I also fixed the created byte blob, but this doesn't work on
6381 the MS runtime and csc never produces any byte blobs for decimal
6384 2003-07-10 Martin Baulig <martin@ximian.com>
6386 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6387 structs; fixes #32068.
6388 (Block.AddChildVariableNames): Fixed #44302.
6390 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6392 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6394 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6396 * attribute.cs: And this test is onger needed.
6398 2003-07-08 Martin Baulig <martin@ximian.com>
6400 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6401 inaccessible types. Fixes #36313.
6403 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6405 * namespace.cs (NamespaceEntry): Create implicit entries for all
6406 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6407 implicit entries for N1.N2 and N1.
6409 2003-07-08 Martin Baulig <martin@ximian.com>
6411 Rewrote the handling of namespaces to fix a lot of the issues
6412 wrt. `using' aliases etc.
6414 * namespace.cs (Namespace): Splitted this class into a
6415 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6417 * typemanager.cs (TypeManager.IsNamespace): Removed.
6418 (TypeManager.ComputeNamespaces): Only compute namespaces from
6419 loaded assemblies here, not the namespaces from the assembly we're
6420 currently compiling.
6422 2003-07-08 Martin Baulig <martin@ximian.com>
6424 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6426 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6428 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6431 I thought about the memory savings here, but LookupTypeReflection
6432 is used under already very constrained scenarios. Compiling
6433 corlib or mcs only exposes one hit, so it would not really reduce
6434 any memory consumption.
6436 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6438 * typemanager.cs: fixes bug #45889 by only adding public types from
6439 other assemblies to the list of known types.
6441 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6443 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6444 on the type we resolved.
6446 2003-07-05 Martin Baulig <martin@ximian.com>
6448 * pending.cs (PendingImplementation.ParentImplements): Don't
6449 create the proxy if the parent is abstract.
6451 * class.cs (TypeContainer.DefineIndexers): Process explicit
6452 interface implementations first. Fixes #37714.
6454 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6456 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6457 defined recursively; but since we modify the input parameters
6458 (left is set to `this' temporarily), we reset this value if the
6459 left_is_explicit is false, which gives the original semantics to
6462 * literal.cs (NullPointer): new class used to represent a null
6463 literal in a pointer context.
6465 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6466 type is a pointer, use a NullPointer object instead of a
6467 NullLiteral. Closes 43687
6469 (ExplicitConversion): Convert pointer values using
6470 the conv opcode to the proper type.
6472 * ecore.cs (New): change ValueTypeVariable property into a method,
6473 that returns whether the valuetype is suitable for being used.
6475 * expression.cs (Binary.DoNumericPromotions): Only return if we
6476 the int constant was a valid uint, and we can return both left and
6477 right as uints. If not, we continue processing, to trigger the
6478 type conversion. This fixes 39018.
6480 * statement.cs (Block.EmitMeta): During constant resolution, set
6481 the CurrentBlock property on the emitcontext, so that we resolve
6482 constants propertly.
6484 2003-07-02 Martin Baulig <martin@ximian.com>
6486 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6487 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6489 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6490 than emitting it here.
6492 * statement.cs: Fixed some more flow analysis bugs.
6494 2003-07-02 Martin Baulig <martin@ximian.com>
6496 * class.cs (MethodData.Define): When implementing interface
6497 methods, set Final unless we're Virtual.
6499 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6500 check work for interface methods.
6502 2003-07-01 Martin Baulig <martin@ximian.com>
6504 * ecore.cs (EmitContext.This): Replaced this property with a
6505 GetThis() method which takes a Location argument. This ensures
6506 that we get the correct error location for a CS0188.
6508 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6510 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6511 ImplicitStandardConversion.
6513 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6515 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6517 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6520 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6522 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6525 (MethodData.Define): Turn off initlocals for unsafe methods.
6527 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6529 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6530 complete; Fixes #37521.
6532 * delegate.cs: Use Modifiers.TypeAttr to compute the
6533 TypeAttributes, instead of rolling our own. This makes the flags
6534 correct for the delegates.
6536 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6538 * class.cs (Constructor.Define): Set the private flag for static
6539 constructors as well.
6541 * cs-parser.jay (statement_expression): Set the return value to
6542 null, to avoid a crash when we catch an error.
6544 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6546 * cs-parser.jay: Applied patch from Jackson that adds support for
6547 extern and unsafe modifiers to destructor declarations.
6549 * expression.cs: Report error 21 if the user is trying to index a
6552 * driver.cs: Add an error message, suggested by the bug report.
6554 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6555 if we do not have a ": this ()" constructor initializer. Fixes 45149
6557 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6559 * namespace.cs: Add some information to reduce FAQs.
6561 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6563 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6564 underlying enumeration types. Fixes #43915.
6566 * expression.cs: Treat ushort/short as legal values to be used in
6569 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6571 * delegate.cs: transfer custom attributes for paramenters from
6572 the delegate declaration to Invoke and BeginInvoke.
6574 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6576 * attribute.cs: handle custom marshalers and emit marshal info
6579 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6581 * makefile.gnu: Added anonymous.cs to the compiler sources.
6583 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6585 * iterators.cs: Change the name of the proxy class to include two
6588 * cs-parser.jay: Update grammar to include anonymous methods.
6590 * anonymous.cs: new file.
6592 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6594 * class.cs (Field.Define): Add missing test for pointers and
6597 2003-05-27 Ravi Pratap <ravi@ximian.com>
6599 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6600 we use the stobj opcode.
6602 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6603 since it wasn't the correct fix.
6605 It still is puzzling that we are required to use stobj for IntPtr
6606 which seems to be a ValueType.
6608 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6610 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6611 during regular simple name resolution. Now, the trick is that
6612 instead of returning for processing the simplename, we do a
6613 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6614 contextual lookup type). If a match is found, return that, if
6615 not, return for further composition.
6617 This fixes long-standing 30485.
6619 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6620 using the address to initialize an object, do an Stobj instead of
6621 using the regular Stelem.
6623 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6624 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6625 Because if we are a BaseIndexerAccess that value will be true.
6628 * statement.cs (GotoCase.Resolve): Return after reporting an
6629 error, do not attempt to continue.
6631 * expression.cs (PointerArithmetic.Emit): If our operand is a
6632 long, convert our constants to match the operand before
6633 multiplying. Convert to I type before adding. Fixes 43670.
6635 2003-05-14 Ravi Pratap <ravi@ximian.com>
6637 * enum.cs (ImplicitConversionExists) : Rename to
6638 ImplicitEnumConversionExists to remove ambiguity.
6640 * ecore.cs (NullCast): New type of cast expression class which
6641 basically is very similar to EmptyCast with the difference being
6642 it still is a constant since it is used only to cast a null to
6646 * convert.cs (ImplicitReferenceConversion): When casting a null
6647 literal, we return a NullCast.
6649 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6650 should be around anymore.
6652 The renaming (reported was slightly wrong). Corrections:
6654 ConvertImplicitStandard -> ImplicitConversionStandard
6655 ConvertExplicitStandard -> ExplicitConversionStandard
6657 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6658 before passing them in !
6660 * convert.cs (ImplicitConversionStandard): When comparing for
6661 equal expr and target types, ensure that expr is not a
6664 In general, we must not be checking (expr_type ==
6665 target_type) in the top level conversion methods
6666 (ImplicitConversion, ExplicitConversion etc). This checking is
6667 done in the methods that they delegate to.
6669 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6671 * convert.cs: Move Error_CannotConvertType,
6672 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6673 ImplicitNumericConversion, ImplicitConversionExists,
6674 ImplicitUserConversionExists, StandardConversionExists,
6675 FindMostEncompassedType, FindMostSpecificSource,
6676 FindMostSpecificTarget, ImplicitUserConversion,
6677 ExplicitUserConversion, GetConversionOperators,
6678 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6679 TryImplicitIntConversion, Error_CannotConvertImplicit,
6680 ConvertImplicitRequired, ConvertNumericExplicit,
6681 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6682 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6685 Perform the following renames:
6687 StandardConversionExists -> ImplicitStandardConversionExists
6688 ConvertImplicit -> ImplicitConversion
6689 ConvertImplicitStandard -> ImplicitStandardConversion
6690 TryImplicitIntConversion -> ImplicitIntConversion
6691 ConvertImplicitRequired -> ImplicitConversionRequired
6692 ConvertNumericExplicit -> ExplicitNumericConversion
6693 ConvertReferenceExplicit -> ExplicitReferenceConversion
6694 ConvertExplicit -> ExplicitConversion
6695 ConvertExplicitStandard -> ExplicitStandardConversion
6697 2003-05-19 Martin Baulig <martin@ximian.com>
6699 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6700 (TypeInfo): Added support for structs having structs as fields.
6702 * ecore.cs (FieldExpr): Implement IVariable.
6703 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6704 VariableInfo for the field.
6706 2003-05-18 Martin Baulig <martin@ximian.com>
6708 * expression.cs (This.DoResolve): Report a CS0027 if we're
6709 emitting a field initializer.
6711 2003-05-18 Martin Baulig <martin@ximian.com>
6713 * expression.cs (This.ResolveBase): New public function.
6714 (This.DoResolve): Check for CS0188.
6716 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6719 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6720 `instance_expression' to null if we don't have any non-static
6723 2003-05-18 Martin Baulig <martin@ximian.com>
6725 Reworked the way how local variables and parameters are handled by
6726 the flow analysis code.
6728 * statement.cs (TypeInfo, VariableMap): New public classes.
6729 (VariableInfo): New public class. This is now responsible for
6730 checking whether a variable has been assigned. It is used for
6731 parameters and local variables.
6732 (Block.EmitMeta): Take the InternalParameters as argument; compute
6733 the layout of the flow vectors here.
6734 (Block.LocalMap, Block.ParameterMap): New public properties.
6735 (FlowBranching): The .ctor doesn't get the InternalParameters
6736 anymore since Block.EmitMeta() now computes the layout of the flow
6738 (MyStructInfo): This class is now known as `StructInfo' and nested
6739 in `TypeInfo'; we don't access this directly anymore.
6741 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6742 property and removed IsAssigned(), IsFieldAssigned(),
6743 SetAssigned() and SetFieldAssigned(); we now call them on the
6744 VariableInfo so we don't need to duplicate this code everywhere.
6746 * expression.cs (ParameterReference): Added `Block block' argument
6748 (LocalVariableReference, ParameterReference, This): The new
6749 VariableInfo class is now responsible for all the definite
6752 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6753 IsParameterAssigned, SetParameterAssigned): Removed.
6755 2003-05-18 Martin Baulig <martin@ximian.com>
6757 * typemanager.cs (InitCoreTypes): Try calling
6758 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6759 the 3-args-version. Corlib now also needs our `void_type'.
6760 (GetMethod): Added overloaded version which takes an optional
6761 `bool report_errors' to allow lookups of optional methods.
6763 2003-05-12 Martin Baulig <martin@ximian.com>
6765 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6766 only used for locals and not for parameters.
6768 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6770 * support.cs (InternalParameters.ParameterType): Return the
6771 ExternalType of the parameter.
6773 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6776 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6778 * class.cs (MethodData.Define): Do not set the `newslot' on
6779 interface members, if they are also flagged as "override".
6781 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6782 better code for ++i and i++. This only works for static fields
6783 and local variables.
6785 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6786 want to pull the DeclSpace out of the builder_to_declspace instead
6787 of the TypeBuilder (like in TypeContainer.FindMembers).
6789 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6790 instead of LookupTypeContainer. Fixes the crash on .NET for
6791 looking up interface members.
6793 * const.cs: Create our own emit context during the Definition
6794 stage, so that constants are evaluated in the proper context, when
6795 a recursive definition happens.
6797 2003-05-11 Martin Baulig <martin@ximian.com>
6799 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6800 new block for a switch section.
6801 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6802 the adding/lookup in the switch block. Fixes #39828.
6804 2003-05-09 Miguel de Icaza <miguel@ximian.com>
6806 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
6807 functionality: I needed to convert the data after I had performed
6808 the add/sub operation into the operands type size.
6810 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
6811 pass the type for the box operation, otherwise the resulting
6812 object would have been of type object.
6814 (BoxedCast): Add constructor to specify the type to box as.
6816 2003-05-07 Miguel de Icaza <miguel@ximian.com>
6818 * iterators.cs: I was reusing the `count' variable inadvertently,
6819 take steps to not allow this to happen.
6821 2003-05-06 Miguel de Icaza <miguel@ximian.com>
6823 * attribute.cs (Attribute.Resolve): Params attributes are encoded
6824 by creating an array at the point where the params starts and
6825 putting all those arguments there, then adjusting the size of the
6828 2003-05-05 Miguel de Icaza <miguel@ximian.com>
6830 * expression.cs (New.AddressOf): Implement interface
6831 IMemoryLocation. This is used when the `new' operator is used in
6832 the context of an invocation to a method on a value type.
6834 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
6837 * namespace.cs: Also check the using aliases here.
6839 * driver.cs: Move the test for using validity after the types have
6840 been entered, so we do a single pass that also includes the using
6843 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
6844 in the regular case. CreateSiblingForFinally is doing extra
6847 * attribute.cs (GetAttributeArgumentExpression): Store the result
6848 on an out value, and use the return value to indicate failure
6849 instead of using null (which is a valid return for Constant.GetValue).
6851 * statement.cs: Perform the analysis flow for the increment
6852 portion after the statement, because this will be the real flow of
6853 execution. Fixes #42385
6855 * codegen.cs (EmitContext.EmitArgument,
6856 EmitContext.EmitStoreArgument): New helper functions when the
6857 RemapToProxy flag is set.
6859 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
6862 Add support for remapping parameters.
6864 * iterators.cs: Propagate parameter values; Store parameter
6865 values in the proxy classes.
6867 2003-05-04 Miguel de Icaza <miguel@ximian.com>
6869 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
6870 need a proxy reference; I do not know what I was thinking
6872 * cs-parser.jay (constructor_initializer): catch another error,
6873 and display nice message.
6875 (field_declaration): catch void field declaration
6876 to flag a better error.
6878 * class.cs (MemberBase.CheckBase): Report an error instead of a
6879 warning if a new protected member is declared in a struct.
6880 (Field.Define): catch the error of readonly/volatile.
6882 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
6884 (FieldExpr.AddressOf): ditto. Catch error where the address of a
6885 volatile variable is taken
6887 2003-05-02 Miguel de Icaza <miguel@ximian.com>
6889 * statement.cs (Fixed.Resolve): Report an error if we are not in
6892 2003-05-01 Miguel de Icaza <miguel@ximian.com>
6894 * typemanager.cs: reuse the code that handles type clashes for
6895 delegates and enumerations.
6897 * class.cs (Report28): Always report.
6899 * expression.cs (EncodeAsAttribute): Allow nulls here.
6901 2003-04-28 Miguel de Icaza <miguel@ximian.com>
6903 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
6904 the functionality for testing whether an expression is valid for
6905 an attribute here. Also handle the case of arrays of elements
6908 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
6909 encoding a linear array into an array of objects that are suitable
6910 to be passed to an CustomAttributeBuilder.
6912 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
6914 * ecore.cs: (FieldExpr): Handle field remapping here.
6916 * iteratators.cs: Pass the instance variable (if the method is an
6917 instance method) to the constructors, so we can access the field
6918 variables on the class.
6920 TODO: Test this with structs. I think the THIS variable on
6921 structs might have to be a pointer, and not a refenrece
6923 2003-04-27 Miguel de Icaza <miguel@ximian.com>
6925 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
6926 local variables to fields in a proxy class.
6928 * iterators.cs (PopulateProxy): Rename our internal fields to
6930 Create a <THIS> field if we are an instance method, so we can
6931 reference our parent container variables.
6932 (MapVariable): Called back from the EmitContext code to enter a
6933 new variable to field mapping into the proxy class (we just create
6937 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
6938 for using the remapped locals to fields.
6940 I placed the code here, because that gives the same semantics to
6941 local variables, and only changes the Emit code.
6943 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
6944 statements inside iterators.
6945 (VariableInfo): Add a FieldBuilder for the cases when we are
6946 remapping local variables to fields in a proxy class
6948 * ecore.cs (SimpleNameResolve): Avoid testing two times for
6949 current_block != null.
6951 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
6952 not cope with strings, as it has been moved to the
6953 TableSwitchEmit. Fixed bug in switch generation.
6955 * expression.cs (New.DoResolve): Provide more context for the user
6956 when reporting an error.
6958 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
6961 * expression.cs (MemberAccess.DoResolve): When we get a type back,
6962 check the permissions for it. Note than in a type-resolution
6963 context the check was already present in DeclSpace.ResolveType,
6964 but was missing from the MemberAccess.
6966 (ArrayCreation.CheckIndices): warn if the user has
6967 more nested levels of expressions, but there are no more
6968 dimensions specified. Avoids crash on bug 41906.
6970 2003-04-26 Miguel de Icaza <miguel@ximian.com>
6972 * statement.cs (Block): replace Implicit bool, for a generic
6974 New flag: `Unchecked'. This is used during the EmitMeta phase
6975 (which is out-of-line with the regular Resolve/Emit process for a
6976 statement, as this is done ahead of time, but still gets a chance
6977 to call constant resolve).
6979 (Block.Flags): new enum for adding a new flag.
6981 (Block.EmitMeta): track the state of unchecked.
6983 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
6984 to enable constant resolution to work there as well.
6986 2003-04-22 Miguel de Icaza <miguel@ximian.com>
6988 * typemanager.cs (ienumerable_type): Also look up
6989 System.Collections.IEnumerable.
6991 2003-04-21 Miguel de Icaza <miguel@ximian.com>
6993 TODO: Test more than one conditional per method.
6995 * class.cs (Indexer.Define): Report the location where the user is
6996 referencing the unsupported feature.
6998 (MethodData): Overload the use of `conditionals' to
6999 minimize the creation of needless ArrayLists. This saves roughly
7000 212kb on my machine.
7002 (Method): Implement the new IIteratorContainer interface.
7003 (Method.SetYields): Implement the method by setting the ModFlags
7004 to contain METHOD_YIELDS.
7006 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
7007 which just got set to null.
7009 * iterators.cs: New file.
7011 (Yield, YieldBreak): New statements.
7013 * statement.cs (Return.Resolve): Flag an error if we are used in
7016 * codegen.cs (InIterator): New flag set if the code is being
7017 compiled in an iterator method.
7019 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
7020 internal modifier, and we just use it to avoid adding extra
7021 fields, as this is seldom used.
7023 * cs-parser.jay: Add yield_statement (yield and yield break).
7025 * driver.cs: New flag -v2 to turn on version 2 features.
7027 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
7028 hashtable when v2 is enabled.
7030 2003-04-20 Miguel de Icaza <miguel@ximian.com>
7032 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
7033 there is already a namespace defined with this name.
7035 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
7036 people upgraded their corlibs.
7038 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
7039 always use fully qualified types, no need to use the compiler
7042 (TypeManager.IsNamespace): Use binarysearch.
7044 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
7045 AddDelegate): I did not quite use the new IsValid API properly: I
7046 have to pass the short-name and the fullname. I was passing only
7047 the basename instead of the fullname sometimes.
7049 (TypeContainer.DefineType): call NamespaceClash.
7051 * interface.cs (Interface.DefineType): use NamespaceClash before
7054 * delegate.cs (Delegate.DefineType): use NamespaceClash before
7057 * enum.cs: (Enum.DefineType): use NamespaceClash before
7060 * typemanager.cs (: 3-line patch that gives us some tasty 11%
7061 speed increase. First, use the negative_hits cache when we get a
7062 negative. Second, add the type with its full original name
7063 instead of the new . and + encoded name (reflection uses + to
7064 separate type from a nested type). Use LookupTypeReflection
7065 directly which bypasses the type->name hashtable (that we already
7066 know does not contain the type.
7068 * decl.cs (DeclSpace.ResolveTypeExpr): track the
7069 location/container type.
7071 * driver.cs: When passing utf8, use directly the UTF8Encoding.
7073 2003-04-19 Miguel de Icaza <miguel@ximian.com>
7075 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
7077 * delegate.cs (NewDelegate.Resolve): Test whether an instance
7078 method is being referenced in the method group from a static
7079 context, and report error 120 if so.
7081 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
7084 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
7085 is created, we create the A namespace).
7087 * cs-parser.jay: A namespace also introduces a DeclarationFound.
7090 2003-04-18 Miguel de Icaza <miguel@ximian.com>
7092 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
7093 invocation to ModuleBuilder.GetType with the same values will
7094 return a new type instance, so we need to cache its return
7097 * expression.cs (Binary.ResolveOperator): Only allow the compare
7098 operators on enums if they are of the same type.
7100 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
7101 types of ValueType on their own case. Before we were giving them
7102 the same treatment as objects.
7104 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
7105 fullname. Short name is used to compare against container name.
7106 Fullname is used to check against defined namespace names.
7108 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
7109 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
7111 (Method.CheckBase): Call parent.
7112 (MemberBase.CheckBase): Check for protected members on sealed
7114 (PropertyBase.CheckBase): Call parent.
7115 (Field.Define): Call parent.
7117 * report.cs: Negative error codes are now mapped to 8000 - code,
7118 so that the display is render more nicely.
7120 * typemanager.cs: Do not use try/catch, instead report a regular
7123 (GetPointerType, GetReferenceType): These methods provide
7124 mechanisms to obtain the T* and T& from a T. We had the code
7125 previously scattered around the code base, and it also used
7126 TypeManager.LookupType that would go through plenty of caches.
7127 This one goes directly to the type source.
7129 In some places we did the Type.GetType followed by
7130 ModuleBuilder.GetType, but not in others, so this unifies the
7133 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
7134 statements now that we have namespace information.
7136 * typemanager.cs (IsNamespace): New method, returns whether the
7137 string presented is a namespace or not.
7139 (ComputeNamespaces): New public entry point, computes the list of
7140 available namespaces, using the GetNamespaces API call in Mono, or
7141 the slower version in MS.NET.
7143 Now before we start the semantic analysis phase, we have a
7144 complete list of namespaces including everything that the user has
7147 Deleted old code to cache namespaces in .nsc files.
7149 2003-04-17 Miguel de Icaza <miguel@ximian.com>
7151 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
7152 class/struct location definition Location for the implicit
7153 constructor location.
7155 (Operator.Define): Use the location of the operator for the
7156 implicit Method definition.
7158 (Constructor.Emit): use the constructor location for the implicit
7159 base initializer constructor.
7161 * ecore.cs: Remove ITypeExpression. This interface is now gone,
7162 and the Expression class now contains two new methods:
7164 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
7165 isolate type lookup from the rest of the resolution process.
7167 Since we use Expressions to hold type definitions due to the way
7168 we parse the input we have historically overloaded Resolve to
7169 perform the Type lookups if a special flag is passed. Now this is
7170 eliminated and two methods take their place.
7172 The differences in the two methods between xStep and xTerminal is
7173 that xStep is involved in our current lookup system that uses
7174 SimpleNames to compose a name, while xTerminal is used just to
7175 catch the case where the simplename lookup failed.
7177 2003-04-16 Miguel de Icaza <miguel@ximian.com>
7179 * expression.cs (ResolveMemberAccess): Remove redundant code.
7180 TypeExpr expressions are always born fully resolved.
7182 * interface.cs (PopulateMethod): Do not lookup the types twice.
7183 We were doing it once during SemanticAnalysis and once during
7186 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
7187 in local variable type definitions, were being returned as a
7188 SimpleName (we decomposed everything into a string), that is
7189 because primary_expression was being used instead of a type in the
7190 grammar (reduce/reduce conflicts).
7192 The part that was wrong is that we converted the expression into a
7193 string (an oversimplification in one hand, compounded with primary
7194 expressions doing string concatenation).
7200 Would return "A.B.C[]" as a SimpleName. This stopped things like
7201 using clauses from working on this particular context. And a type
7202 was being matched directly against "A.B.C[]".
7204 We now use the correct approach, and allow for ComposedCast to be
7205 part of the unary expression. So the "A.B.C []" become a composed
7206 cast of "A.B.C" (as a nested group of MemberAccess with a
7207 SimpleName at the end) plus the rank composition "[]".
7211 2003-04-10 Miguel de Icaza <miguel@ximian.com>
7213 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
7214 for the access level checking.
7216 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
7217 `TypeContainer container', because I kept getting confused when I
7218 was debugging this code.
7220 * expression.cs (Indexers): Instead of tracking getters/setters,
7221 we now track them in parallel. We create one arraylist less, but
7222 most importantly it is possible now for the LValue code to find a
7223 matching get for a set.
7225 (IndexerAccess.DoResolveLValue): Update the code.
7226 GetIndexersForType has been modified already to extract all the
7227 indexers from a type. The code assumed it did not.
7229 Also make the code set the correct return type for the indexer.
7230 This was fixed a long time ago for properties, but was missing for
7231 indexers. It used to be void_type.
7233 (Binary.Emit): Test first for doubles instead of
7234 floats, as they are more common.
7236 (Binary.EmitBranchable): Use the .un version of the branch opcodes
7237 when dealing with floats and the <=, >= operators. This fixes bug
7240 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
7241 to load the array value by emitting a load on the foreach variable
7242 type. This was incorrect.
7244 We now emit the code to load an element using the the array
7245 variable type, and then we emit the conversion operator.
7249 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
7251 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7253 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7255 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7256 test for protection before we test for signatures.
7258 (MethodSignature.ToString): implement.
7260 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7261 to the case where we reduced into a LongConstant.
7263 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7264 depend on whether the information is acurrate, because the
7265 Microsoft runtime will always claim that the array type is public,
7266 regardless of the real state.
7268 If the type is a pointer, another problem happens: the type is
7269 reported as non-public in Microsoft.
7271 In both cases we have to call CheckAccessLevel recursively with
7272 the underlying type as the argument to be tested.
7274 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7276 * assign.cs (Assign.Emit): If we are dealing with a compound
7277 assignment expression, we should use the code path that stores the
7278 intermediate result in a temporary value. This fixes #40903.
7280 *expression.cs (Indirection.ToString): Provide ToString method for
7283 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7285 * class.cs: Null out fields holding references to Block objects so
7286 they can be garbage collected.
7288 * expression.cs (OverloadResolve): Remove unused local.
7290 2003-04-07 Martin Baulig <martin@ximian.com>
7292 * codegen.cs (EmitContext.CurrentFile): New public field.
7293 (EmitContext.Mark): Use the CurrentFile to check whether the
7294 location is in the correct file.
7295 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7297 2003-04-07 Martin Baulig <martin@ximian.com>
7299 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7301 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7302 location. [FIXME: The location argument which gets passed to this
7303 method is sometimes wrong!]
7305 2003-04-07 Nick Drochak <ndrochak@gol.com>
7307 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7309 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7311 * expression.cs (Indirection.EmitAssign): We were using the
7312 temporary, but returning immediately instead of continuing the
7315 2003-04-06 Martin Baulig <martin@ximian.com>
7317 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7318 if it's a nested child, but also deriving from the outer class.
7321 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7322 nested child, but also deriving from the outer class. See
7324 (FilterWithClosure): We may access private members of the outer
7325 class if we're a nested child and deriving from the outer class.
7326 (RealMemberLookup): Only set `closure_private_ok' if the
7327 `original_bf' contained BindingFlags.NonPublic.
7329 2003-04-05 Martin Baulig <martin@ximian.com>
7331 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
7333 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7335 * class.cs (Event.Define): Do not allow abstract events to have
7338 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7340 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7341 block in event declarations.
7343 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7344 value type, get its address.
7346 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7347 leaving a class on the stack instead of a boolean value (int
7348 0/1). Change the code so we compare against null, and then the
7349 result against zero.
7351 * class.cs (TypeContainer.GetClassBases): We were checking for the
7352 parent class being sealed too late.
7354 * expression.cs (Binary.Emit): For <= and >= when dealing with
7355 floating point values, use cgt.un and clt.un instead of cgt and
7358 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7360 * statement.cs: Apply the same optimization as MS: skip the
7361 GetEnumerator returning an IEnumerator, and use the one returning a
7362 CharEnumerator instead. This allows us to avoid the try-finally block
7365 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7367 * cs-parser.jay: Attributes cannot be applied to
7368 namespaces. Fixes #40473
7370 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7373 (Add*): check if the name is valid using the full name for constants,
7374 fields, properties and events.
7376 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7378 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7379 char constants to be part of the enumeration.
7381 * expression.cs (Conditional.DoResolve): Add support for operator
7382 true. Implements the missing functionality from 14.12
7384 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7385 operator true/false as required by the spec.
7387 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7388 implicit conversion to boolean.
7390 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7391 also one where the type implements `operator true'.
7393 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7394 get an expression that will invoke operator true based on an
7397 (GetConversionOperators): Removed the hack that called op_True
7400 (Expression.ResolveBoolean): Move this from Statement.
7402 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7404 * ecore.cs (FieldExpr): do not allow initialization of initonly
7405 fields on derived classes
7407 2003-03-13 Martin Baulig <martin@ximian.com>
7409 * statement.cs (Block.Emit): Call ig.BeginScope() and
7410 ig.EndScope() when compiling with debugging info; call
7411 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7413 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7415 * expression.cs (Indexers): Do not construct immediately, allow
7416 for new members to be appended as we go. Fixes 38143
7418 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7420 * expression.cs: save/restore context when resolving an unchecked
7423 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7425 * cfold.cs: Catch division by zero in modulus operator during
7428 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7430 * interface.cs (Interface.DefineMembers): Avoid defining members
7433 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7435 * driver.cs: handle the +/- options for -noconfig
7437 * statement.cs (Unckeched.Resolve): Also track the state of
7438 unchecked in the Resolve phase.
7440 2003-02-27 Martin Baulig <martin@ximian.com>
7442 * ecore.cs (Expression.MemberLookup): Don't create a
7443 MethodGroupExpr for something which is not a method. Fixes #38291.
7445 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7447 * class.cs (MemberBase.CheckParameters): Also check that the type
7448 is unmanaged if it is a pointer.
7450 * expression.cs (SizeOf.Resolve): Add location information.
7452 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7453 a managed type is declared.
7455 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7456 parameter modifiers as well. Fixes bug 38606
7458 * class.cs: Very sad. Am backing out the speed up changes
7459 introduced by the ArrayList -> Array in the TypeContainer, as they
7460 were not actually that much faster, and introduced a bug (no error
7461 reports on duplicated methods).
7463 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7464 source first, this will guarantee that we have a valid expression
7465 before calling in lower levels functions that will require a
7466 resolved object. Then use this original_source in the
7467 target.ResolveLValue instead of the original source that was
7470 Another change. Use target.Resolve instead of LValueResolve.
7471 Although we are resolving for LValues, we will let the Assign code
7472 take care of that (it will be called again from Resolve). This
7473 basically allows code like this:
7475 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7476 class Y { void A (X x) { x [0] += o; }
7478 The problem was that the indexer was trying to resolve for
7479 set_Item (idx, object o) and never finding one. The real set_Item
7480 was set_Item (idx, X). By delaying the process we get the right
7485 2003-02-23 Martin Baulig <martin@ximian.com>
7487 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7488 while calling DoEmit ().
7490 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7491 source files; if you use the #line directive inside a method, the
7492 compiler stops emitting line numbers for the debugger until it
7493 reaches the end of the method or another #line directive which
7494 restores the original file.
7496 2003-02-23 Martin Baulig <martin@ximian.com>
7498 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7500 2003-02-23 Martin Baulig <martin@ximian.com>
7502 * statement.cs (Block.AddChildVariableNames): We need to call this
7503 recursively, not just for our immediate children.
7505 2003-02-23 Martin Baulig <martin@ximian.com>
7507 * class.cs (Event.Define): Always make the field private, like csc does.
7509 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7510 actually work, fixes bug #37521.
7512 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7514 * delegate.cs: When creating the various temporary "Parameters"
7515 classes, make sure that we call the ComputeAndDefineParameterTypes
7516 on those new parameters (just like we do with the formal ones), to
7517 allow them to be resolved in the context of the DeclSpace.
7519 This fixes the bug that Dick observed in Bugzilla #38530.
7521 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7523 * expression.cs (ResolveMemberAccess): When resolving a constant,
7524 do not attempt to pull a constant if the value was not able to
7525 generate a valid constant.
7527 * const.cs (LookupConstantValue): Do not report more errors than required.
7529 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7531 * expression.cs: fixes bug #38328.
7533 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7535 * class.cs: Changed all the various members that can be part of a
7536 class from being an ArrayList to be an Array of the right type.
7537 During the DefineType type_list, interface_list, delegate_list and
7538 enum_list are turned into types, interfaces, delegates and enums
7541 And during the member population, indexer_list, event_list,
7542 constant_list, field_list, instance_constructor_list, method_list,
7543 operator_list and property_list are turned into their real arrays.
7545 Although we could probably perform this operation earlier, for
7546 good error reporting we need to keep the lists and remove the
7547 lists for longer than required.
7549 This optimization was triggered by Paolo profiling the compiler
7550 speed on the output of `gen-sample-program.pl' perl script.
7552 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7553 not crash in methods like MemberLookupFailed that use this field.
7555 This problem arises when the compiler fails to resolve a type
7556 during interface type definition for example.
7558 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7560 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7561 inherit from System.Object, so we have to stop at null, not only
7562 when reaching System.Object.
7564 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7566 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7567 DeclaredOnly because the parent indexer might have had a different
7568 name, but did not loop until the top of the hierarchy was reached.
7570 The problem this one fixes is 35492: when a class implemented an
7571 indexer from an interface, we were getting the interface method
7572 (which was abstract) and we were flagging an error (can not invoke
7575 This also keeps bug 33089 functioning, and test-148 functioning.
7577 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7578 out if a method is special is to see if it is declared in a
7579 property or event, or whether it is one of the predefined operator
7580 names. This should fix correctly #36804.
7582 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7584 The goal here is to remove the dependency on EmptyCast.Peel ().
7585 Killing it completely.
7587 The problem is that currently in a number of places where
7588 constants are expected, we have to "probe" for an EmptyCast, and
7589 Peel, which is not the correct thing to do, as this will be
7590 repetitive and will likely lead to errors.
7592 The idea is to remove any EmptyCasts that are used in casts that
7593 can be reduced to constants, so we only have to cope with
7596 This bug hunt was triggered by Bug 37363 and the desire to remove
7597 the duplicate pattern where we were "peeling" emptycasts to check
7598 whether they were constants. Now constants will always be
7601 * ecore.cs: Use an enumconstant here instead of wrapping with
7604 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7605 throwing me off. By handling this we can get rid of a few hacks.
7607 * statement.cs (Switch): Removed Peel() code.
7609 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7611 * class.cs: Location information for error 508
7613 * expression.cs (New.DoResolve): Add a guard against double
7614 resolution of an expression.
7616 The New DoResolve might be called twice when initializing field
7617 expressions (see EmitFieldInitializers, the call to
7618 GetInitializerExpression will perform a resolve on the expression,
7619 and later the assign will trigger another resolution
7621 This leads to bugs (#37014)
7623 * delegate.cs: The signature for EndInvoke should contain any ref
7624 or out parameters as well. We were not doing this in the past.
7626 * class.cs (Field.Define): Do not overwrite the type definition
7627 inside the `volatile' group. Turns out that volatile enumerations
7628 were changing the type here to perform a validity test, which
7631 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7633 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7634 and structs, we do not want to load the instance variable
7636 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7637 enum_type has to be handled like an object reference (implicit
7638 conversions exists from this to object), but the regular IsClass
7639 and IsValueType tests will never return true for this one.
7641 Also we use TypeManager.IsValueType instead of type.IsValueType,
7642 just for consistency with the rest of the code (this is only
7643 needed if we ever use the construct exposed by test-180.cs inside
7644 corlib, which we dont today).
7646 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7648 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7651 2003-02-09 Martin Baulig <martin@ximian.com>
7653 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7654 (Namespace.DefineNamespaces): New static public method; this is
7655 called when we're compiling with debugging to add all namespaces
7658 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7659 pass it to the Namespace's .ctor.
7661 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7662 and MethodBase arguments; pass the namespace ID to the symwriter;
7663 pass the MethodBase instead of the token to the symwriter.
7664 (SymbolWriter.DefineNamespace): New method to add a namespace to
7667 2003-02-09 Martin Baulig <martin@ximian.com>
7669 * symbolwriter.cs: New file. This is a wrapper around
7670 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7671 methods here in near future.
7673 2003-02-09 Martin Baulig <martin@ximian.com>
7675 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7676 ILGenerator.MarkSequencePoint() which are actually used by the
7679 2003-02-09 Martin Baulig <martin@ximian.com>
7681 * location.cs (SourceFile): New public sealed class. This
7682 contains the name and an index which is used in the location's token.
7683 (Location): Reserve an appropriate number of bits in the token for
7684 the source file instead of walking over that list, this gives us a
7685 really huge performance improvement when compiling with debugging.
7687 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7688 `SourceFile' argument instead of a string.
7689 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7690 but don't parse/tokenize here, we need to generate the list of all
7691 source files before we do that.
7692 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7695 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7696 instead of a string.
7698 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7701 2003-02-09 Martin Baulig <martin@ximian.com>
7703 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7704 filename on `#line default'.
7706 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7708 * statement.cs: don't clear the pinned var when the fixed statement
7709 returns from the method (fixes bug#37752).
7711 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7713 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7716 2003-02-07 Martin Baulig <martin@ximian.com>
7718 * driver.cs: Removed the `--debug-args' command line argument.
7720 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7721 automatically by the AsssemblyBuilder.
7722 (CodeGen.InitializeSymbolWriter): We don't need to call any
7723 initialization function on the symbol writer anymore. This method
7724 doesn't take any arguments.
7726 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7728 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7729 from referenced assemblies as well.
7731 2003-02-02 Martin Baulig <martin@ximian.com>
7733 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7735 2003-02-02 Martin Baulig <martin@ximian.com>
7737 * class.cs (Constructor.Emit): Open the symbol writer before
7738 emitting the constructor initializer.
7739 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7740 single-stepping through constructor initializers.
7742 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7744 * class.cs: Handle error 549: do not allow virtual methods in
7747 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7749 * decl.cs: Check access levels when resolving types
7751 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7753 * statement.cs: Add parameters and locals set in catch blocks that might
7754 return to set vector
7756 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7758 * class.cs (Operator): Set the SpecialName flags for operators.
7760 * expression.cs (Invocation.DoResolve): Only block calls to
7761 accessors and operators on SpecialName methods.
7763 (Cast.TryReduce): Handle conversions from char constants.
7766 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7768 * statement.cs: small memory and time optimization in FlowBranching.
7770 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7772 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7773 problem that the last fix but in the other sid (Set).
7775 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7776 access when there is no indexer in the hierarchy.
7778 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
7780 * class.cs: Combine some if statements.
7782 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7784 * driver.cs: fixed bug #37187.
7786 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
7788 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
7789 any indexer, it's needed to build a list with all the indexers in the
7790 hierarchy (AllGetters), else we have problems. Fixes #35653.
7792 2003-01-23 Miguel de Icaza <miguel@ximian.com>
7794 * class.cs (MethodData.Define): It is wrong for an interface
7795 implementation to be static in both cases: explicit and implicit.
7796 We were only handling this in one case.
7798 Improve the if situation there to not have negations.
7800 * class.cs (Field.Define): Turns out that we do not need to check
7801 the unsafe bit on field definition, only on usage. Remove the test.
7803 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7805 * driver.cs: use assembly.Location instead of Codebase (the latest
7806 patch made mcs fail when using MS assemblies).
7808 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
7810 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
7811 get the path to *corlib.dll.
7813 2003-01-21 Nick Drochak <ndrochak@gol.com>
7817 * typemanager.cs: Remove compiler warnings
7819 2003-01-20 Duncan Mak <duncan@ximian.com>
7821 * AssemblyInfo.cs: Bump the version number to 0.19.
7823 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7825 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
7827 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
7829 * class.cs (Constructor::Emit): Emit debugging info for constructors.
7831 2003-01-17 Miguel de Icaza <miguel@ximian.com>
7833 * cs-parser.jay: Small fix: we were not comparing the constructor
7834 name correctly. Thanks to Zoltan for the initial pointer.
7836 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
7838 * cs-tokenizer.cs: Set file name when specified with #line
7840 2003-01-15 Miguel de Icaza <miguel@ximian.com>
7842 * cs-parser.jay: Only perform the constructor checks here if we
7843 are named like the class; This will help provider a better
7844 error. The constructor path is taken when a type definition is
7845 not found, but most likely the user forgot to add the type, so
7846 report that rather than the constructor error.
7848 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
7850 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
7853 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7855 * cs-parser.jay: Add cleanup call.
7857 2003-01-13 Duncan Mak <duncan@ximian.com>
7859 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
7860 consistent with other methods.
7862 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7864 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
7866 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
7868 * attribute.cs: only set GuidAttr to true when we have a
7871 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7875 * typemanager.cs: fixes to allow mcs compile corlib with the new
7876 Type.IsSubclassOf fix.
7878 2003-01-08 Miguel de Icaza <miguel@ximian.com>
7880 * expression.cs (LocalVariableReference.DoResolve): Classify a
7881 constant as a value, not as a variable. Also, set the type for
7884 * cs-parser.jay (fixed_statement): take a type instead of a
7885 pointer_type, so we can produce a better error message later.
7887 * statement.cs (Fixed.Resolve): Flag types that are not pointers
7890 (For.DoEmit): Make inifinite loops have a
7891 non-conditional branch back.
7893 (Fixed.DoEmit): First populate the pinned variables, then emit the
7894 statement, then clear the variables. Before I was emitting the
7895 code once for each fixed piece.
7898 2003-01-08 Martin Baulig <martin@ximian.com>
7900 * statement.cs (FlowBranching.MergeChild): A break in a
7901 SWITCH_SECTION does not leave a loop. Fixes #36155.
7903 2003-01-08 Martin Baulig <martin@ximian.com>
7905 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
7906 lives in the same number space than `param_map'. Fixes #36154.
7908 2003-01-07 Miguel de Icaza <miguel@ximian.com>
7910 * cs-parser.jay (constructor_declaration): Set the
7911 Constructor.ModFlags before probing for it. This makes the
7912 compiler report 514, 515 and 132 (the code was there, but got
7915 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
7916 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
7917 (GotoCase.Resolve): Set `Returns' to ALWAYS.
7919 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
7921 * enum.cs: create the enum static fields using the enum type.
7923 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
7925 * class.cs: don't try to create the ParamBuilder for the return
7926 type if it's not needed (and handle it breaking for the ms runtime
7929 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
7931 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
7933 2002-12-29 Miguel de Icaza <miguel@ximian.com>
7935 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
7936 the command. This showed up while compiling the JANET source
7937 code, which used \r as its only newline separator.
7939 2002-12-28 Miguel de Icaza <miguel@ximian.com>
7941 * class.cs (Method.Define): If we are an operator (because it
7942 reuses our code), then set the SpecialName and HideBySig. #36128
7944 2002-12-22 Miguel de Icaza <miguel@ximian.com>
7946 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
7947 exception, report error 120 `object reference required'.
7949 * driver.cs: Add --pause option, used during to measure the size
7950 of the process as it goes with --timestamp.
7952 * expression.cs (Invocation.DoResolve): Do not allow methods with
7953 SpecialName to be invoked.
7955 2002-12-21 Miguel de Icaza <miguel@ximian.com>
7957 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
7958 number before adding it.
7960 2002-12-21 Ravi Pratap <ravi@ximian.com>
7962 * ecore.cs (StandardImplicitConversion): When in an unsafe
7963 context, we allow conversion between void * to any other pointer
7964 type. This fixes bug #35973.
7966 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
7968 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
7969 is not thrown when extensionless outputs are used
7971 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7973 * rootcontext.cs: fixed compilation of corlib.
7975 2002-12-19 Miguel de Icaza <miguel@ximian.com>
7977 * attribute.cs (Attributes.Contains): Add new method.
7979 * class.cs (MethodCore.LabelParameters): if the parameter is an
7980 `out' parameter, check that no attribute `[In]' has been passed.
7982 * enum.cs: Handle the `value__' name in an enumeration.
7984 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
7986 * decl.cs: Added special case to allow overrides on "protected
7989 2002-12-18 Ravi Pratap <ravi@ximian.com>
7991 * attribute.cs (Attributes.AddAttributeSection): Rename to this
7992 since it makes much more sense.
7994 (Attributes.ctor): Don't require a Location parameter.
7996 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
7998 * attribute.cs (ApplyAttributes): Remove extra Location parameters
7999 since we already have that information per attribute.
8001 * everywhere : make appropriate changes.
8003 * class.cs (LabelParameters): Write the code which actually
8004 applies attributes to the return type. We can't do this on the MS
8005 .NET runtime so we flag a warning in the case an exception is
8008 2002-12-18 Miguel de Icaza <miguel@ximian.com>
8010 * const.cs: Handle implicit null conversions here too.
8012 2002-12-17 Ravi Pratap <ravi@ximian.com>
8014 * class.cs (MethodCore.LabelParameters): Remove the extra
8015 Type [] parameter since it is completely unnecessary. Instead
8016 pass in the method's attributes so that we can extract
8017 the "return" attribute.
8019 2002-12-17 Miguel de Icaza <miguel@ximian.com>
8021 * cs-parser.jay (parse): Use Report.Error to flag errors instead
8022 of ignoring it and letting the compile continue.
8024 * typemanager.cs (ChangeType): use an extra argument to return an
8025 error condition instead of throwing an exception.
8027 2002-12-15 Miguel de Icaza <miguel@ximian.com>
8029 * expression.cs (Unary.TryReduce): mimic the code for the regular
8030 code path. Perform an implicit cast in the cases where we can
8031 implicitly convert to one of the integral types, and then reduce
8032 based on that constant. This fixes bug #35483.
8034 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8036 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
8038 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8040 * namespace.cs: fixed bug #35489.
8042 2002-12-12 Miguel de Icaza <miguel@ximian.com>
8044 * class.cs: Remove some dead code.
8046 * cs-parser.jay: Estimate the number of methods needed
8047 (RootContext.MethodCount);
8049 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
8050 numbers instead of StringBuilders.
8052 * support.cs (PtrHashtable): Add constructor with initial size;
8053 We can now reduce reallocations of the method table.
8055 2002-12-10 Ravi Pratap <ravi@ximian.com>
8057 * attribute.cs (ApplyAttributes): Keep track of the emitted
8058 attributes on a per-target basis. This fixes bug #35413.
8060 2002-12-10 Miguel de Icaza <miguel@ximian.com>
8062 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
8063 default to the Windows 1252 encoding.
8065 (UnixParseOption): Support version, thanks to Alp for the missing
8068 * AssemblyInfo.cs: Add nice assembly information.
8070 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
8073 * cs-parser.jay: Allow a trailing comma before the close bracked
8074 in the attribute_section production.
8076 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
8077 address of the instance was being taken, I will take this out,
8078 because we take the address of the object immediately here.
8080 2002-12-09 Ravi Pratap <ravi@ximian.com>
8082 * typemanager.cs (AreMultipleAllowed): Take care of the most
8083 obvious case where attribute type is not in the current assembly -
8086 2002-12-08 Miguel de Icaza <miguel@ximian.com>
8088 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
8089 definitions, instead of doing that afterwards.
8091 Also we use a nice little hack, depending on the constructor, we
8092 know if we are a "composed" name or a simple name. Hence, we
8093 avoid the IndexOf test, and we avoid
8095 * codegen.cs: Add code to assist in a bug reporter to track down
8096 the source of a compiler crash.
8098 2002-12-07 Ravi Pratap <ravi@ximian.com>
8100 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
8101 types have been emitted for a given element and flag an error
8102 if something which does not have AllowMultiple set is used more
8105 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
8106 attribute types and their corresponding AllowMultiple properties
8108 (AreMultipleAllowed): Check the property for a given type.
8110 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
8111 property in the case we have a TypeContainer.
8113 (Attributes.AddAttribute): Detect duplicates and just skip on
8114 adding them. This trivial fix catches a pretty gross error in our
8115 attribute emission - global attributes were being emitted twice!
8117 Bugzilla bug #33187 is now fixed.
8119 2002-12-06 Miguel de Icaza <miguel@ximian.com>
8121 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
8124 * expression.cs (Binary.ResolveOperator): I can only use the
8125 Concat (string, string, string) and Concat (string, string,
8126 string, string) if the child is actually a concatenation of
8129 2002-12-04 Miguel de Icaza <miguel@ximian.com>
8131 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
8132 context where we need a 2-character lookahead.
8134 * pending.cs (PendingImplementation): Rework so we can keep track
8135 of interface types all the time, and flag those which were
8136 implemented by parents as optional.
8138 2002-12-03 Miguel de Icaza <miguel@ximian.com>
8140 * expression.cs (Binary.ResolveOperator): Use
8141 String.Concat(string,string,string) or
8142 String.Concat(string,string,string,string) when possible.
8144 * typemanager: More helper methods.
8147 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
8149 * pending.cs: remove the bogus return from GetMissingInterfaces()
8150 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
8152 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8154 * namespace.cs: avoid duplicated 'using xxx' being added to
8155 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
8156 when we get more than one 'using' statement for the same namespace.
8157 Report a CS0105 warning for it.
8159 2002-11-30 Miguel de Icaza <miguel@ximian.com>
8161 * cs-tokenizer.cs (consume_identifier): use read directly, instead
8162 of calling getChar/putback, uses internal knowledge of it.
8164 (xtoken): Reorder tokenizer so most common patterns are checked
8165 first. This reduces the compilation time in another 5% (from 8.11s
8166 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
8168 The parsing time is 22% of the compilation in mcs, and from that
8169 64% is spent on the tokenization process.
8171 I tried using a binary search for keywords, but this is slower
8172 than the hashtable. Another option would be to do a couple of
8175 * Not use a StringBuilder, instead use an array of chars,
8176 with a set value. Notice that this way we could catch
8177 the 645 error without having to do it *afterwards*.
8179 * We could write a hand-parser to avoid the hashtable
8180 compares altogether.
8182 The identifier consumption process takes 37% of the tokenization
8183 time. Another 15% is spent on is_number. 56% of the time spent
8184 on is_number is spent on Int64.Parse:
8186 * We could probably choose based on the string length to
8187 use Int32.Parse or Int64.Parse and avoid all the 64-bit
8190 Another 3% is spend on wrapping `xtoken' in the `token' function.
8192 Handle 0xa0 as whitespace (#34752)
8194 2002-11-26 Miguel de Icaza <miguel@ximian.com>
8196 * typemanager.cs (IsCLRType): New routine to tell whether a type
8197 is one of the builtin types.
8199 Maybe it needs to use TypeCodes to be faster. Maybe we could use
8200 typecode in more places instead of doing pointer comparissions.
8201 We could leverage some knowledge about the way the typecodes are
8204 New code to cache namespaces in assemblies, it is currently not
8205 invoked, to be used soon.
8207 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
8209 * expression.cs (Binary.ResolveOperator): specially handle
8210 strings, and do not perform user-defined operator overloading for
8213 2002-11-24 Miguel de Icaza <miguel@ximian.com>
8215 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
8216 internalcall as it is a pretty simple operation; Avoid whenever
8217 possible to call Char.IsLetter.
8219 (consume_identifier): Cut by half the number of
8220 hashtable calls by merging the is_keyword and GetKeyword behavior.
8222 Do not short-circuit, because if we do, we
8223 report errors (ie, #if false && true would produce an invalid
8227 2002-11-24 Martin Baulig <martin@ximian.com>
8229 * expression.cs (Cast.TryReduce): If we're in checked syntax,
8230 check constant ranges and report a CS0221. Fixes #33186.
8232 2002-11-24 Martin Baulig <martin@ximian.com>
8234 * cs-parser.jay: Make this work for uninitialized variable
8235 declarations in the `for' initializer. Fixes #32416.
8237 2002-11-24 Martin Baulig <martin@ximian.com>
8239 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
8240 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
8242 2002-11-24 Martin Baulig <martin@ximian.com>
8244 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
8245 argument; if true, we also check for user-defined conversions.
8246 This is only needed if both arguments are of a user-defined type.
8247 Fixes #30443, added test-175.cs.
8248 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
8250 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
8252 2002-11-24 Martin Baulig <martin@ximian.com>
8254 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8255 function to get the store opcode.
8256 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8257 only emit the Ldelema if the store opcode is Stobj. You must run
8258 both test-34 and test-167 to test this. Fixes #34529.
8260 2002-11-23 Martin Baulig <martin@ximian.com>
8262 * ecore.cs (Expression.MemberLookup): Added additional
8263 `qualifier_type' argument which is used when we're being called
8264 from MemberAccess.DoResolve() and null if we're called from a
8266 (Expression.MemberLookupFailed): New method to report errors; this
8267 does the CS1540 check and reports the correct error message.
8269 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8270 argument for the CS1540 check and redone the way how we're dealing
8271 with private members. See the comment in the source code for details.
8272 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8273 `closure_start_type' to `closure_qualifier_type' and check whether
8274 it's not null. It was not this filter being broken, it was just
8275 being called with the wrong arguments.
8277 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8278 and pass it the correct `qualifier_type'; this also does the error
8281 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8283 * expression.cs (Invocation.EmitParams): If the we are dealing
8284 with a non-built-in value type, load its address as well.
8286 (ArrayCreation): Use a a pretty constant instead
8287 of the hardcoded value 2. Use 6 instead of 2 for the number of
8288 static initializers.
8290 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8291 because they are not really value types, just glorified integers.
8293 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8295 * ecore.cs: Remove redundant code for enumerations, make them use
8296 the same code path as everything else, fixes the casting issue
8297 with enumerations in Windows.Forms.
8299 * attribute.cs: Do only cast to string if it is a string, the
8300 validation happens later.
8302 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8303 people upgrade their corlibs.
8305 * ecore.cs: Oops, enumerations were not following the entire code path
8307 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8309 * typemanager.cs (FilterWithClosure): Commented out the test for
8310 1540 in typemanager.cs, as it has problems when accessing
8311 protected methods from a parent class (see test-174.cs).
8313 * attribute.cs (Attribute.ValidateGuid): new method.
8314 (Attribute.Resolve): Use above.
8316 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8318 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8320 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8321 handling for enumerations, as we only needed the TypeContainer
8322 functionality to begin with (this is required for the fix below to
8323 work for enums that reference constants in a container class for
8326 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8328 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8329 a valid TypeBuilder to perform lookups on.o
8331 * class.cs (InheritableMemberSignatureCompare): Use true in the
8332 call to GetGetMethod and GetSetMethod, because we are comparing
8333 the signature, and we need to get the methods *even* if they are
8336 (PropertyBase.CheckBase): ditto.
8338 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8339 GotoCase.Resolve): Use Peel on EmpytCasts.
8341 * ecore.cs (EmptyCast): drop child, add Peel method.
8343 2002-11-17 Martin Baulig <martin@ximian.com>
8345 * ecore.cs (EmptyCast.Child): New public property.
8347 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8348 label resolved to an EmptyCast. Fixes #34162.
8349 (GotoCase.Resolve): Likewise.
8350 (Block.EmitMeta): Likewise.
8352 2002-11-17 Martin Baulig <martin@ximian.com>
8354 * expression.cs (Invocation.BetterConversion): Prefer int over
8355 uint; short over ushort; long over ulong for integer literals.
8356 Use ImplicitConversionExists instead of StandardConversionExists
8357 since we also need to check for user-defined implicit conversions.
8358 Fixes #34165. Added test-173.cs.
8360 2002-11-16 Martin Baulig <martin@ximian.com>
8362 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8363 with the `true' and `false' literals. Fixes #33151.
8365 2002-11-16 Martin Baulig <martin@ximian.com>
8367 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8368 October 22nd; don't do the cs1540 check for static members.
8370 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8371 now using our own filter here and doing the cs1540 check again.
8373 2002-11-16 Martin Baulig <martin@ximian.com>
8375 * support.cs (InternalParameters): Don't crash if we don't have
8376 any fixed parameters. Fixes #33532.
8378 2002-11-16 Martin Baulig <martin@ximian.com>
8380 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8381 when looking up static methods to make this work on Windows.
8384 2002-11-16 Martin Baulig <martin@ximian.com>
8386 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8387 a setter rather than using PropertyInfo.CanWrite.
8389 2002-11-15 Nick Drochak <ndrochak@gol.com>
8391 * class.cs: Allow acces to block member by subclasses. Fixes build
8394 2002-11-14 Martin Baulig <martin@ximian.com>
8396 * class.cs (Constructor.Emit): Added the extern/block check.
8399 2002-11-14 Martin Baulig <martin@ximian.com>
8401 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8402 iteration while looking for indexers, this is needed because the
8403 indexer may have a different name in our base classes. Fixed the
8404 error reporting (no indexers at all, not get accessor, no
8405 overloaded match). Fixes bug #33089.
8406 (IndexerAccess.DoResolveLValue): Likewise.
8408 2002-11-14 Martin Baulig <martin@ximian.com>
8410 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8411 indexers. Fixes the first part of bug #33089.
8412 (MethodSignature.InheritableMemberSignatureCompare): Added support
8415 2002-11-13 Ravi Pratap <ravi@ximian.com>
8417 * attribute.cs (Attribute.Resolve): Catch the
8418 NullReferenceException and report it since it isn't supposed to
8421 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8423 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8424 LogicalOr and LogicalAnd that can benefit from recursively
8425 handling EmitBranchable. The code now should be nice for Paolo.
8427 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8429 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8430 the Type lookups, as we perform quite a number of lookups on
8431 non-Types. This can be removed once we can deterministically tell
8432 whether we have a type or a namespace in advance.
8434 But this might require special hacks from our corlib.
8438 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8439 and double which avoids a conversion from an integer to a double.
8441 * expression.cs: tiny optimization, avoid calling IsConstant,
8442 because it effectively performs the lookup twice.
8444 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8446 But a bogus return here to keep the semantics of the old code
8447 until the Mono runtime is fixed.
8449 * pending.cs (GetMissingInterfaces): New method used to remove all
8450 the interfaces that are already implemented by our parent
8451 classes from the list of pending methods.
8453 * interface.cs: Add checks for calls after ResolveTypeExpr.
8455 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8457 * class.cs (Class.Emit): Report warning 67: event not used if the
8458 warning level is beyond 3.
8460 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8461 being a NullLiteral.
8463 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8466 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8467 path that might fail if a type can not be resolved.
8469 * expression.cs (Binary.Emit): Emit unsigned versions of the
8472 * driver.cs: use error 5.
8474 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8476 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8478 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8480 * cs-parser.jay (switch_section): A beautiful patch from Martin
8481 Baulig that fixed 33094.
8483 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8485 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8486 Check whether the base is abstract and report an error if so.
8488 * expression.cs (IndexerAccess.DoResolveLValue,
8489 IndexerAccess.DoResolve): ditto.
8491 (Invocation.DoResolve): ditto.
8493 (Invocation.FullMethodDesc): Improve the report string.
8495 * statement.cs (Block): Eliminate IsVariableDefined as it is
8496 basically just a wrapper for GetVariableInfo.
8498 * ecore.cs (SimpleName): Use new
8500 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8501 type, as we return the actual parameter ref/unref state on a
8504 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8506 * support.cs: Return proper flags REF/OUT fixing the previous
8509 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8510 not used to mean `ref' but `ref or out' in ParameterReference
8512 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8513 full type signature instead of calling TypeManger.CSharpName
8516 * support.cs (InternalParameters.ParameterDesc): Do not compare
8517 directly to the modflags, because REF/OUT will actually be bitsets
8520 * delegate.cs (VerifyMethod): Check also the modifiers.
8522 * cs-tokenizer.cs: Fix bug where floating point values with an
8523 exponent where a sign was missing was ignored.
8525 * driver.cs: Allow multiple assemblies to be specified in a single
8528 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8530 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8531 because identifiers after a parenthesis would end up in this kind
8532 of production, and we needed to desamiguate it for having casts
8535 (UserDefinedType *) xxx
8537 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8539 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8540 we should set on the Bindingflags.NonPublic, but not turn on
8541 private_ok. private_ok controls whether a Private member is
8542 returned (this is chekced on the filter routine), while the
8543 BindingFlags.NonPublic just controls whether private/protected
8544 will be allowed. This fixes the problem part of the problem of
8545 private properties being allowed to be used in derived classes.
8547 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8548 so we can call the children DoResolveLValue method (this will
8549 properly signal errors on lvalue assignments to base properties)
8551 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8552 getter are null, and we have a property info, we know that this
8553 happened because the lookup failed, so we report an error 122 for
8554 protection level violation.
8556 We also silently return if setter and getter are null in the
8557 resolve functions, this condition only happens if we have flagged
8558 the error before. This is the other half of the problem.
8560 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8561 not have accessibility information, that is why we were returning
8562 true in the filter function in typemanager.cs.
8564 To properly report 122 (property is inaccessible because of its
8565 protection level) correctly, we report this error in ResolveAccess
8566 by failing if both the setter and the getter are lacking (ie, the
8569 DoResolve and DoLResolve have been modified to check for both
8570 setter/getter being null and returning silently, the reason being
8571 that I did not want to put the knowledge about this error in upper
8574 int old = Report.Errors;
8575 x = new PropertyExpr (...);
8576 if (old != Report.Errors)
8581 So the property expr is returned, but it is invalid, so the error
8582 will be flagged during the resolve process.
8584 * class.cs: Remove InheritablePropertySignatureCompare from the
8585 class, as we no longer depend on the property signature to compute
8586 whether it is possible to implement a method or not.
8588 The reason is that calling PropertyInfo.GetGetMethod will return
8589 null (in .NET, in Mono it works, and we should change this), in
8590 cases where the Get Method does not exist in that particular
8595 class X { public virtual int A { get { return 1; } } }
8597 class Z : Y { public override int A { get { return 2; } } }
8599 Would fail in Z because the parent (Y) would not have the property
8600 defined. So we avoid this completely now (because the alternative
8601 fix was ugly and slow), and we now depend exclusively on the
8604 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8605 reference method, instead of using the property.
8607 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8608 routines are gone now.
8610 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8611 names, they were incorrectly named.
8613 * cs-tokenizer.cs: Return are more gentle token on failure.
8615 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8616 had an out-of-sync index variable, which caused it to remove from
8617 the list of pending methods the wrong method sometimes.
8619 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8621 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8622 CanWrite, because those refer to this particular instance of the
8623 property, and do not take into account the fact that we can
8624 override single members of a property.
8626 Constructor requires an EmitContext. The resolution process does
8627 not happen here, but we need to compute the accessors before,
8628 because the resolution does not always happen for properties.
8630 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8631 subclass, before we did not update this flag, but we did update
8634 (GetAccessors): Drop this routine, as it did not work in the
8635 presence of partially overwritten set/get methods.
8637 Notice that this broke the cs1540 detection, but that will require
8640 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8644 * driver.cs: issue a warning instead of an error if we don't support
8645 debugging for the platform. Also ignore a couple of errors that may
8646 arise when trying to write the symbols. Undo my previous patch.
8648 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8650 * driver.cs: ignore /debug switch except for Unix platforms.
8652 2002-10-23 Nick Drochak <ndrochak@gol.com>
8654 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8656 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8658 * driver.cs: Do not make mcs-debug conditional, so we do not break
8661 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8662 review this patch. But basically after all the children variables
8663 have been merged, the value of "Breaks" was not being set to
8664 new_breaks for Switch blocks. I think that it should be set after
8665 it has executed. Currently I set this to the value of new_breaks,
8666 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8667 conservative, but I do not understand this code very well.
8669 I did not break anything in the build, so that is good ;-)
8671 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8673 2002-10-20 Mark Crichton <crichton@gimp.org>
8675 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8677 2002-10-20 Nick Drochak <ndrochak@gol.com>
8679 * cfold.cs: Fixed compile blocker.
8681 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8683 * driver.cs: I was chekcing the key, not the file.
8685 2002-10-19 Ravi Pratap <ravi@ximian.com>
8687 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8688 message that we were generating - we just need to silently return
8691 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8693 * class.cs (Event.Define): Change my previous commit, as this
8694 breaks the debugger. This is a temporary hack, as it seems like
8695 the compiler is generating events incorrectly to begin with.
8697 * expression.cs (Binary.ResolveOperator): Added support for
8698 "U operator - (E x, E y)"
8700 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8703 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8704 init-only variables, but this path did not take into account that
8705 there might be also instance readonly variables. Correct this
8708 This fixes bug 32253
8710 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8713 * driver.cs: Change the extension for modules to `netmodule'
8715 * cs-parser.jay: Improved slightly the location tracking for
8716 the debugger symbols.
8718 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8719 modifiers that were specified instead of the hardcoded value
8720 (FamAndAssem). This was basically ignoring the static modifier,
8721 and others. Fixes 32429.
8723 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8724 fixed a bug in the process (32476)
8726 * expression.cs (ArrayAccess.EmitAssign): Patch from
8727 hwang_rob@yahoo.ca that fixes bug 31834.3
8729 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8731 * driver.cs: Make the module extension .netmodule.
8733 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8735 * driver.cs: Report an error if the resource file is not found
8736 instead of crashing.
8738 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8739 false, like Emit does.
8741 2002-10-16 Nick Drochak <ndrochak@gol.com>
8743 * typemanager.cs: Remove unused private member. Also reported mcs
8744 bug to report this as a warning like csc.
8746 2002-10-15 Martin Baulig <martin@gnome.org>
8748 * statement.cs (Statement.Emit): Made this a virtual method; emits
8749 the line number info and calls DoEmit().
8750 (Statement.DoEmit): New protected abstract method, formerly knows
8751 as Statement.Emit().
8753 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8755 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8757 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8758 have fixed a remaining problem: not every AddXXXX was adding a
8759 fully qualified name.
8761 Now everyone registers a fully qualified name in the DeclSpace as
8762 being defined instead of the partial name.
8764 Downsides: we are slower than we need to be due to the excess
8765 copies and the names being registered this way.
8767 The reason for this is that we currently depend (on the corlib
8768 bootstrap for instance) that types are fully qualified, because
8769 we dump all the types in the namespace, and we should really have
8770 types inserted into the proper namespace, so we can only store the
8771 basenames in the defined_names array.
8773 2002-10-10 Martin Baulig <martin@gnome.org>
8775 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8776 from bug #31834, see the bug report for a testcase which is
8779 2002-10-10 Martin Baulig <martin@gnome.org>
8781 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
8782 flow analysis code for this.
8784 * statement.cs (Do, While, For): Tell the flow analysis code about
8786 (FlowBranching.UsageVector): Added support for infinite loops.
8787 (Block.Resolve): Moved the dead code elimination here and use flow
8790 2002-10-09 Miguel de Icaza <miguel@ximian.com>
8792 * class.cs (Field.Define): Catch cycles on struct type
8795 * typemanager.cs (IsUnmanagedtype): Do not recursively check
8796 fields if the fields are static. We only need to check instance
8799 * expression.cs (As.DoResolve): Test for reference type.
8801 * statement.cs (Using.ResolveExpression): Use
8802 ConvertImplicitRequired, not ConvertImplicit which reports an
8804 (Using.ResolveLocalVariableDecls): ditto.
8806 * expression.cs (Binary.ResolveOperator): Report errors in a few
8807 places where we had to.
8809 * typemanager.cs (IsUnmanagedtype): Finish implementation.
8811 2002-10-08 Miguel de Icaza <miguel@ximian.com>
8813 * expression.cs: Use StoreFromPtr instead of extracting the type
8814 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
8816 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
8817 an enumeration value to a System.Enum, but System.Enum is not a
8818 value type, but an class type, so we need to box.
8820 (Expression.ConvertExplicit): One codepath could return
8821 errors but not flag them. Fix this. Fixes #31853
8823 * parameter.cs (Resolve): Do not allow void as a parameter type.
8825 2002-10-06 Martin Baulig <martin@gnome.org>
8827 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
8828 if it's a class type and not a struct. Fixes #31815.
8830 2002-10-06 Martin Baulig <martin@gnome.org>
8832 * statement.cs: Reworked the flow analysis code a bit to make it
8833 usable for dead code elimination.
8835 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8837 * cs-parser.jay: allow empty source files. Fixes bug #31781.
8839 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8841 * expression.cs (ComposedCast.DoResolveType): A quick workaround
8842 to fix the test 165, will investigate deeper.
8844 2002-10-04 Martin Baulig <martin@gnome.org>
8846 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
8847 finally blocks actually work.
8848 (Try.Resolve): We don't need to create a sibling for `finally' if
8849 there is no finally block.
8851 2002-10-04 Martin Baulig <martin@gnome.org>
8853 * class.cs (Constructor.Define): The default accessibility for a
8854 non-default constructor is private, not public.
8856 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8858 * class.cs (Constructor): Make AllowedModifiers public, add
8861 * cs-parser.jay: Perform the modifiers test here, as the
8862 constructor for the Constructor class usually receives a zero
8863 because of the way we create it (first we create, later we
8864 customize, and we were never checking the modifiers).
8866 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
8867 is a version of LookupTypeReflection that includes the type-name
8868 cache. This can be used as a fast path for functions that know
8869 the fully qualified name and are only calling into *.GetType() to
8870 obtain a composed type.
8872 This is also used by TypeManager.LookupType during its type
8875 (LookupType): We now also track the real type name, as sometimes
8876 we can get a quey for the real type name from things like
8877 ComposedCast. This fixes bug 31422.
8879 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
8880 complete type fullname, it does not have to go through the type
8881 resolution system to obtain the composed version of the type (for
8882 obtaining arrays or pointers).
8884 (Conditional.Emit): Use the EmitBoolExpression to
8885 generate nicer code, as requested by Paolo.
8887 (ArrayCreation.CheckIndices): Use the patch from
8888 hwang_rob@yahoo.ca to validate the array initializers.
8890 2002-10-03 Miguel de Icaza <miguel@ximian.com>
8892 * class.cs (ConstructorInitializer.Emit): simplify code by using
8893 Invocation.EmitCall, and at the same time, fix the bugs in calling
8894 parent constructors that took variable arguments.
8896 * ecore.cs (Expression.ConvertNumericExplicit,
8897 Expression.ImplicitNumericConversion): Remove the code that
8898 manually wrapped decimal (InternalTypeConstructor call is now gone
8901 * expression.cs (Cast.TryReduce): Also handle decimal types when
8902 trying to perform a constant fold on the type.
8904 * typemanager.cs (IsUnmanagedtype): Partially implemented.
8906 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
8907 that only turned off an error report, and did nothing else.
8909 2002-10-02 Miguel de Icaza <miguel@ximian.com>
8911 * driver.cs: Handle and ignore /fullpaths
8913 2002-10-01 Miguel de Icaza <miguel@ximian.com>
8915 * expression.cs (Binary.ResolveOperator): Catch the case where
8916 DoNumericPromotions returns true,
8918 (Binary.DoNumericPromotions): Simplify the code, and the tests.
8920 2002-09-27 Miguel de Icaza <miguel@ximian.com>
8922 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
8925 2002-09-26 Miguel de Icaza <miguel@ximian.com>
8927 * ecore.cs (ConvertNumericExplicit): It is not enough that the
8928 conversion exists, but it is also required that the conversion be
8929 performed. This manifested in "(Type64Enum) 2".
8931 * class.cs (TypeManager.AddMethod): The fix is not to change
8932 AddEnum, because that one was using a fully qualified name (every
8933 DeclSpace derivative does), but to change the AddMethod routine
8934 that was using an un-namespaced name. This now correctly reports
8935 the duplicated name.
8937 Revert patch until I can properly fix it. The issue
8938 is that we have a shared Type space across all namespaces
8939 currently, which is wrong.
8941 Options include making the Namespace a DeclSpace, and merge
8942 current_namespace/current_container in the parser.
8944 2002-09-25 Miguel de Icaza <miguel@ximian.com>
8946 * cs-parser.jay: Improve error reporting when we get a different
8947 kind of expression in local_variable_type and
8948 local_variable_pointer_type.
8950 Propagate this to avoid missleading errors being reported.
8952 * ecore.cs (ImplicitReferenceConversion): treat
8953 TypeManager.value_type as a target just like object_type. As
8958 Is valid, and needs to result in the int 1 being boxed before it
8959 is assigned to the value type v.
8961 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
8962 to validate the enumeration name.
8964 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
8965 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
8966 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
8968 * ecore.cs (TryImplicitIntConversion): When doing an
8969 implicit-enumeration-conversion, check if the type is 64-bits and
8970 perform a conversion before passing to EnumConstant.
8972 2002-09-23 Miguel de Icaza <miguel@ximian.com>
8974 * decl.cs (Error_AmbiguousTypeReference); New routine used to
8975 report ambiguous type references. Unlike the MS version, we
8976 report what the ambiguity is. Innovation at work ;-)
8978 (DeclSpace.FindType): Require a location argument to
8979 display when we display an ambiguous error.
8981 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
8983 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
8985 * expression.cs (EmitDynamicInitializers): Apply patch from
8986 hwang_rob@yahoo.ca that fixes the order in which we emit our
8989 2002-09-21 Martin Baulig <martin@gnome.org>
8991 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
8992 delegate takes no arguments.
8994 2002-09-20 Miguel de Icaza <miguel@ximian.com>
8996 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
8999 * expression.cs: Extract the underlying type.
9001 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
9003 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
9005 2002-09-19 Miguel de Icaza <miguel@ximian.com>
9007 * class.cs (TypeContainer.DefineType): We can not use the nice
9008 PackingSize with the size set to 1 DefineType method, because it
9009 will not allow us to define the interfaces that the struct
9012 This completes the fixing of bug 27287
9014 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
9015 means also structs. This fixes part of the problem.
9016 (Expresion.ImplicitReferenceConversionExists): ditto.
9018 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
9019 error if there were no errors reported during the type lookup
9020 process, to avoid duplicates or redundant errors. Without this
9021 you would get an ambiguous errors plus a type not found. We have
9022 beaten the user enough with the first error.
9024 (DeclSparce.FindType): Emit a warning if we have an ambiguous
9027 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
9028 during the resolution process, stop the lookup, this avoids
9029 repeated error reports (same error twice).
9031 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
9033 * typemanager.cs (LookupType): Redo the type lookup code to match
9034 the needs of System.Reflection.
9036 The issue is that System.Reflection requires references to nested
9037 types to begin with a "+" sign instead of a dot. So toplevel
9038 types look like: "NameSpace.TopLevelClass", and nested ones look
9039 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
9042 2002-09-19 Martin Baulig <martin@gnome.org>
9044 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
9045 says that a method always returns or always throws an exception,
9046 don't report the CS0161.
9048 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
9049 set `Returns = new_returns'.
9051 2002-09-19 Martin Baulig <martin@gnome.org>
9053 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
9054 to an enum constant, check for a CS0176.
9056 2002-09-18 Miguel de Icaza <miguel@ximian.com>
9058 * class.cs (TypeContainer.CheckPairedOperators): Now we check
9059 for operators that must be in pairs and report errors.
9061 * ecore.cs (SimpleName.DoResolveType): During the initial type
9062 resolution process, when we define types recursively, we must
9063 check first for types in our current scope before we perform
9064 lookups in the enclosing scopes.
9066 * expression.cs (MakeByteBlob): Handle Decimal blobs.
9068 (Invocation.VerifyArgumentsCompat): Call
9069 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
9070 I thought we were supposed to always call this, but there are a
9071 few places in the code where we dont do it.
9073 2002-09-17 Miguel de Icaza <miguel@ximian.com>
9075 * driver.cs: Add support in -linkres and -resource to specify the
9076 name of the identifier.
9078 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9080 * ecore.cs (StandardConversionExists): Sync with the conversion
9081 code: allow anything-* to void* conversions.
9083 (FindMostSpecificSource): Use an Expression argument
9084 instead of a Type, because we might be handed over a Literal which
9085 gets a few more implicit conversions that plain types do not. So
9086 this information was being lost.
9088 Also, we drop the temporary type-holder expression when not
9091 2002-09-17 Martin Baulig <martin@gnome.org>
9093 * class.cs (PropertyBase.CheckBase): Don't check the base class if
9094 this is an explicit interface implementation.
9096 2002-09-17 Martin Baulig <martin@gnome.org>
9098 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
9099 different `IndexerName' attributes.
9101 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
9102 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
9103 virtual CommonResolve().
9105 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9107 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
9108 and convert that to the UnderlyingType.
9110 * statement.cs (Foreach.Resolve): Indexers are just like variables
9111 or PropertyAccesses.
9113 * cs-tokenizer.cs (consume_string): Track line numbers and columns
9114 inside quoted strings, we were not doing this before.
9116 2002-09-16 Martin Baulig <martin@gnome.org>
9118 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
9119 resolve it. This is needed for the definite assignment check of the
9120 instance expression, fixes bug #29846.
9121 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
9123 2002-09-16 Nick Drochak <ndrochak@gol.com>
9125 * parameter.cs: Fix compile error. Cannot reference static member
9126 from an instance object. Is this an mcs bug?
9128 2002-09-14 Martin Baulig <martin@gnome.org>
9130 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
9131 multiple times. Fixes bug #30295, added test-166.cs.
9133 2002-09-14 Martin Baulig <martin@gnome.org>
9135 * statement.cs (Block.Emit): Don't emit unreachable code.
9136 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
9138 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
9140 2002-09-14 Martin Baulig <martin@gnome.org>
9142 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
9145 2002-09-14 Martin Baulig <martin@gnome.org>
9147 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
9148 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
9149 be false on the ms runtime.
9151 2002-09-13 Martin Baulig <martin@gnome.org>
9153 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
9154 the CS0038 error message.
9156 2002-09-12 Miguel de Icaza <miguel@ximian.com>
9158 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
9159 constant inside, return it.
9161 2002-09-12 Martin Baulig <martin@gnome.org>
9163 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
9164 implicit conversion can be done between enum types.
9166 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
9167 check whether an implicit conversion to the current enum's UnderlyingType
9168 exists and report an error if not.
9170 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
9171 without debugging support.
9173 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
9174 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
9176 2002-09-12 Martin Baulig <martin@gnome.org>
9178 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
9180 * ecore.cs (IMemberExpr.DeclaringType): New property.
9181 (SimpleName.SimpleNameResolve): Check whether we're accessing a
9182 nonstatic member of an outer type (CS0038).
9184 2002-09-11 Miguel de Icaza <miguel@ximian.com>
9186 * driver.cs: Activate the using-error detector at warning level
9187 4 (at least for MS-compatible APIs).
9189 * namespace.cs (VerifyUsing): Small buglett fix.
9191 * pending.cs (PendingImplementation): pass the container pointer.
9193 * interface.cs (GetMethods): Allow for recursive definition. Long
9194 term, I would like to move every type to support recursive
9195 definitions, not the current ordering mechanism that we have right
9198 The situation is this: Attributes are handled before interfaces,
9199 so we can apply attributes to interfaces. But some attributes
9200 implement interfaces, we will now handle the simple cases
9201 (recursive definitions will just get an error).
9203 * parameter.cs: Only invalidate types at the end if we fail to
9206 2002-09-09 Martin Baulig <martin@gnome.org>
9208 * ecore.cs (PropertyExpr.Emit): Also check for
9209 TypeManager.system_int_array_get_length so this'll also work when
9210 compiling corlib. Fixes #30003.
9212 2002-09-09 Martin Baulig <martin@gnome.org>
9214 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
9215 and throw an exception if we can't get the type's size. Fixed #30040,
9218 2002-09-09 Martin Baulig <martin@gnome.org>
9220 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
9222 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
9223 context. Fixes bug #30027.
9225 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
9226 virtual functions. Fixes bug #30043, added test-164.cs.
9228 2002-09-08 Ravi Pratap <ravi@ximian.com>
9230 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
9232 2002-09-08 Nick Drochak <ndrochak@gol.com>
9234 * driver.cs: Use an object to get the windows codepage since it's not a
9237 2002-09-08 Miguel de Icaza <miguel@ximian.com>
9239 * statement.cs (For.Emit): for infinite loops (test == null)
9240 return whether there is a break inside, not always "true".
9242 * namespace.cs (UsingEntry): New struct to hold the name of the
9243 using definition, the location where it is defined, and whether it
9244 has been used in a successful type lookup.
9246 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
9251 2002-09-06 Ravi Pratap <ravi@ximian.com>
9253 * attribute.cs : Fix incorrect code which relied on catching
9254 a NullReferenceException to detect a null being passed in
9255 where an object was expected.
9257 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9259 * statement.cs (Try): flag the catch variable as assigned
9261 * expression.cs (Cast): Simplified by using ResolveType instead of
9264 * statement.cs (Catch): Fix bug by using ResolveType.
9266 2002-09-06 Ravi Pratap <ravi@ximian.com>
9268 * expression.cs (BetterConversion): Special case for when we have
9269 a NullLiteral as the argument and we have to choose between string
9270 and object types - we choose string the way csc does.
9272 * attribute.cs (Attribute.Resolve): Catch the
9273 NullReferenceException and report error #182 since the Mono
9274 runtime no more has the bug and having this exception raised means
9275 we tried to select a constructor which takes an object and is
9278 2002-09-05 Ravi Pratap <ravi@ximian.com>
9280 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9281 message (1502, 1503) when we can't locate a method after overload
9282 resolution. This is much more informative and closes the bug
9285 * interface.cs (PopulateMethod): Return if there are no argument
9286 types. Fixes a NullReferenceException bug.
9288 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9289 expressions too. Previously we were checking only in one place for
9290 positional arguments leaving out named arguments.
9292 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9293 type to the enum type is not allowed. Remove code corresponding to
9296 (ConvertNumericExplicit): Allow explicit conversions from
9297 the underlying type to enum type. This precisely follows the spec
9298 and closes a bug filed by Gonzalo.
9300 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9303 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9305 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9307 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9308 it was important that we stored the right value after the
9309 reduction in `converted'.
9311 2002-09-04 Martin Baulig <martin@gnome.org>
9313 * location.cs (Location.SymbolDocument): Use full pathnames for the
9316 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9318 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9319 of the expression resolve mechanism, because that will catch the
9320 SimpleName error failures.
9322 (Conditional): If we can not resolve the
9323 expression, return, do not crash.
9325 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9328 (location): display token name instead of its number.
9330 2002-08-28 Martin Baulig <martin@gnome.org>
9332 * expression.cs (Binary.ResolveOperator): Don't silently return
9333 but return an error if an operator cannot be applied between two
9336 2002-08-28 Martin Baulig <martin@gnome.org>
9338 * class.cs (Constructor.Define): Set the permission attributes
9339 correctly instead of making all constructors public.
9341 2002-08-28 Martin Baulig <martin@gnome.org>
9343 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9344 for private members before reporting a CS0103; if we find anything,
9347 2002-08-28 Martin Baulig <martin@gnome.org>
9349 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9350 to check whether `closure_start_type == closure_invocation_type',
9351 we also need to check whether `m.DeclaringType == closure_invocation_type'
9352 before bypassing the permission checks. We might be accessing
9353 protected/private members from the base class.
9354 (TypeManager.RealMemberLookup): Only set private_ok if private
9355 members were requested via BindingFlags.NonPublic.
9357 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9359 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9360 MethodGroupExpr.IsExplicitImpl if appropriate.
9361 (Invocation.DoResolve): Don't report the CS0120 for explicit
9362 interface implementations.
9364 2002-08-27 Martin Baulig <martin@gnome.org>
9366 * expression.cs (Invocation.DoResolve): If this is a static
9367 method and we don't have an InstanceExpression, we must report
9370 2002-08-25 Martin Baulig <martin@gnome.org>
9372 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9373 `==' between a valuetype and an object.
9375 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9377 * ecore.cs (TypeExpr): Provide a ToString method.
9379 2002-08-24 Martin Baulig <martin@gnome.org>
9381 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9382 now called proggie.dbg and it's a binary file.
9384 2002-08-23 Martin Baulig <martin@gnome.org>
9386 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9388 2002-08-23 Martin Baulig <martin@gnome.org>
9390 * struct.cs (MyStructInfo.ctor): Make this work with empty
9391 structs; it's not allowed to use foreach() on null.
9393 2002-08-23 Martin Baulig <martin@gnome.org>
9395 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9396 writer the full pathname of the generated assembly.
9398 2002-08-23 Martin Baulig <martin@gnome.org>
9400 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9401 A `finally' block never returns or breaks; improved handling of
9404 2002-08-23 Martin Baulig <martin@gnome.org>
9406 * statement.cs (Throw.Resolve): Allow `throw null'.
9408 2002-08-23 Martin Baulig <martin@gnome.org>
9410 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9411 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9412 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9413 MemberLookup would return a wrong event if this is an explicit
9414 interface implementation and the class has an event with the same
9417 2002-08-23 Martin Baulig <martin@gnome.org>
9419 * statement.cs (Block.AddChildVariableNames): New public method.
9420 (Block.AddChildVariableName): Likewise.
9421 (Block.IsVariableNameUsedInChildBlock): Likewise.
9422 (Block.AddVariable): Check whether a variable name has already
9423 been used in a child block.
9425 * cs-parser.jay (declare_local_variables): Mark all variable names
9426 from the current block as being used in a child block in the
9429 2002-08-23 Martin Baulig <martin@gnome.org>
9431 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9432 find the symbol writer.
9434 * driver.cs: csc also allows the arguments to /define being
9435 separated by commas, not only by semicolons.
9437 2002-08-23 Martin Baulig <martin@gnome.org>
9439 * interface.cs (Interface.GetMembers): Added static check for events.
9441 2002-08-15 Martin Baulig <martin@gnome.org>
9443 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9444 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9446 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9447 why the MethodData.EmitDestructor() change was necessary.
9449 2002-08-20 Martin Baulig <martin@gnome.org>
9451 * class.cs (TypeContainer.FindMembers): Added static check for events.
9453 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9455 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9456 use Type.GetEvents(), not Type.FindMembers().
9458 2002-08-20 Martin Baulig <martin@gnome.org>
9460 * decl.cs (MemberCache): Added a special method cache which will
9461 be used for method-only searched. This ensures that a method
9462 search will return a MethodInfo with the correct ReflectedType for
9465 2002-08-20 Martin Baulig <martin@gnome.org>
9467 * decl.cs (DeclSpace.FindMembers): Made this public.
9469 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9471 * delegate.cs: fixed build on windows.
9472 [FIXME: Filed as bug #29150: MCS must report these errors.]
9474 2002-08-19 Ravi Pratap <ravi@ximian.com>
9476 * ecore.cs (StandardConversionExists): Return a false
9477 if we are trying to convert the void type to anything else
9478 since that is not allowed.
9480 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9481 we flag error 70 in the event an event is trying to be accessed
9482 directly from outside the declaring type.
9484 2002-08-20 Martin Baulig <martin@gnome.org>
9486 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9487 MemberCache from typemanager.cs to decl.cs.
9489 2002-08-19 Martin Baulig <martin@gnome.org>
9491 * class.cs (TypeContainer): Implement IMemberContainer.
9492 (TypeContainer.DefineMembers): Create the MemberCache.
9493 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9494 return public members if BindingFlags.Public was given, check
9495 whether members are static.
9497 2002-08-16 Martin Baulig <martin@gnome.org>
9499 * decl.cs (DeclSpace.Define): Splitted this in Define and
9500 DefineMembers. DefineMembers is called first and initializes the
9503 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9504 DefineMembers() on all our DeclSpaces.
9506 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9507 but call DefineMembers() on all nested interfaces. We call their
9508 Define() in our new Define() function.
9510 * interface.cs (Interface): Implement IMemberContainer.
9511 (Interface.Define): Moved all code except the attribute stuf to
9513 (Interface.DefineMembers): Initialize the member cache.
9515 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9516 need this anymore since we can use MemberCache.FindMembers directly.
9518 2002-08-19 Martin Baulig <martin@gnome.org>
9520 * typemanager.cs (MemberCache): When creating the cache for an
9521 interface type, add all inherited members.
9522 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9523 to `out bool used_cache' and documented it.
9524 (TypeManager.MemberLookup): If we already used the cache in the first
9525 iteration, we don't need to do the interfaces check.
9527 2002-08-19 Martin Baulig <martin@gnome.org>
9529 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9530 here from IMemberFinder and don't implement this interface anymore.
9531 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9533 * typemanager.cs (IMemberFinder): This interface is now only used by
9534 classes which actually support the member cache.
9535 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9536 since we only put DeclSpaces into this Hashtable.
9537 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9538 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9540 2002-08-16 Martin Baulig <martin@gnome.org>
9542 * typemanager.cs (ICachingMemberFinder): Removed.
9543 (IMemberFinder.MemberCache): New property.
9544 (TypeManager.FindMembers): Merged this with RealFindMembers().
9545 This function will never be called from TypeManager.MemberLookup()
9546 so we can't use the cache here, just the IMemberFinder.
9547 (TypeManager.MemberLookup_FindMembers): Check whether the
9548 IMemberFinder has a MemberCache and call the cache's FindMembers
9550 (MemberCache): Rewrote larger parts of this yet another time and
9551 cleaned it up a bit.
9553 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9555 * driver.cs (LoadArgs): Support quoting.
9557 (Usage): Show the CSC-like command line arguments.
9559 Improved a few error messages.
9561 2002-08-15 Martin Baulig <martin@gnome.org>
9563 * typemanager.cs (IMemberContainer.Type): New property.
9564 (IMemberContainer.IsInterface): New property.
9566 The following changes are conditional to BROKEN_RUNTIME, which is
9567 defined at the top of the file.
9569 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9570 class'es members, but add all members from TypeHandle.ObjectType
9571 if we're an interface.
9572 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9573 is the current type.
9574 (MemberCache.CacheEntry.Container): Removed this field.
9575 (TypeHandle.GetMembers): Include inherited members.
9577 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9579 * typemanager.cs: fixed compilation and added a comment on a field that
9582 2002-08-15 Martin Baulig <martin@gnome.org>
9584 * class.cs (ConstructorInitializer.Resolve): In the
9585 Expression.MemberLookup call, use the queried_type as
9588 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9589 declared' attribute, it's always true.
9590 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9591 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9592 temporary wrapper for FindMembers which tells MemberLookup whether
9593 members from the base classes are included in the return value.
9594 This will go away soon.
9595 (TypeManager.MemberLookup): Use this temporary hack here; once the
9596 new MemberCache is completed, we don't need to do the DeclaredOnly
9597 looping here anymore since the MemberCache will take care of this.
9598 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9599 (MemberCache): When creating the MemberCache for a class, get
9600 members from the current class and all its base classes.
9601 (MemberCache.CacheEntry.Container): New field. This is a
9602 temporary hack until the Mono runtime is fixed to distinguish
9603 between ReflectedType and DeclaringType. It allows us to use MCS
9604 with both the MS runtime and the unfixed Mono runtime without
9605 problems and without accecting performance.
9606 (MemberCache.SearchMembers): The DeclaredOnly looping from
9607 TypeManager.MemberLookup is now done here.
9609 2002-08-14 Martin Baulig <martin@gnome.org>
9611 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9612 Type.GetFields on dynamic types but get the fields from the
9613 corresponding TypeContainer.
9614 (MyStructInfo.GetStructInfo): Added check for enum types.
9616 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9617 (MemberList.SyncRoot): Implemented.
9618 (TypeManager.FilterWithClosure): No need to check permissions if
9619 closure_start_type == closure_invocation_type, don't crash if
9620 closure_invocation_type is null.
9622 2002-08-13 Martin Baulig <martin@gnome.org>
9624 Rewrote TypeContainer.FindMembers to use a member cache. This
9625 gives us a speed increase of about 35% for the self-hosting MCS
9626 build and of about 15-20% for the class libs (both on GNU/Linux).
9628 * report.cs (Timer): New class to get enhanced profiling. This
9629 whole class is "TIMER" conditional since it remarkably slows down
9632 * class.cs (MemberList): New class. This is an IList wrapper
9633 which we're now using instead of passing MemberInfo[]'s around to
9634 avoid copying this array unnecessarily.
9635 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9636 (ICachingMemberFinder, IMemberContainer): New interface.
9637 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9638 has already been checked, otherwise use it for the name comparision.
9639 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9640 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9641 if possible. Returns a MemberList, not a MemberInfo [].
9642 (TypeHandle): New class, implements IMemberContainer. We create
9643 one instance of this class per type, it contains a MemberCache
9644 which is used to do the member lookups.
9645 (MemberCache): New class. Each instance of this class contains
9646 all members of a type and a name-based hash table.
9647 (MemberCache.FindMembers): This is our new member lookup
9648 function. First, it looks up all members of the requested name in
9649 the hash table. Then, it walks this list and sorts out all
9650 applicable members and returns them.
9652 2002-08-13 Martin Baulig <martin@gnome.org>
9654 In addition to a nice code cleanup, this gives us a performance
9655 increase of about 1.4% on GNU/Linux - not much, but it's already
9656 half a second for the self-hosting MCS compilation.
9658 * typemanager.cs (IMemberFinder): New interface. It is used by
9659 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9660 Enum, Delegate or Interface.
9661 (TypeManager.finder_to_member_finder): New PtrHashtable.
9662 (TypeManager.finder_to_container): Removed.
9663 (TypeManager.finder_to_delegate): Removed.
9664 (TypeManager.finder_to_interface): Removed.
9665 (TypeManager.finder_to_enum): Removed.
9667 * interface.cs (Interface): Implement IMemberFinder.
9669 * delegate.cs (Delegate): Implement IMemberFinder.
9671 * enum.cs (Enum): Implement IMemberFinder.
9673 * class.cs (TypeContainer): Implement IMemberFinder.
9675 2002-08-12 Martin Baulig <martin@gnome.org>
9677 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9679 2002-08-12 Martin Baulig <martin@gnome.org>
9681 * ecore.cs (ITypeExpression): New interface for expressions which
9683 (TypeExpression): Renamed to TypeLookupExpression.
9684 (Expression.DoResolve): If we're doing a types-only lookup, the
9685 expression must implement the ITypeExpression interface and we
9686 call DoResolveType() on it.
9687 (SimpleName): Implement the new ITypeExpression interface.
9688 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9689 hack, the situation that we're only looking up types can't happen
9690 anymore when this method is called. Moved the type lookup code to
9691 DoResolveType() and call it.
9692 (SimpleName.DoResolveType): This ITypeExpression interface method
9693 is now doing the types-only lookup.
9694 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9695 (ResolveFlags): Added MaskExprClass.
9697 * expression.cs (MemberAccess): Implement the ITypeExpression
9699 (MemberAccess.DoResolve): Added support for a types-only lookup
9700 when we're called via ITypeExpression.DoResolveType().
9701 (ComposedCast): Implement the ITypeExpression interface.
9703 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9704 Expression.Resolve() with ResolveFlags.Type instead.
9706 2002-08-12 Martin Baulig <martin@gnome.org>
9708 * interface.cs (Interface.Define): Apply attributes.
9710 * attribute.cs (Attribute.ApplyAttributes): Added support for
9711 interface attributes.
9713 2002-08-11 Martin Baulig <martin@gnome.org>
9715 * statement.cs (Block.Emit): Only check the "this" variable if we
9716 do not always throw an exception.
9718 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9719 whether the property has a set accessor.
9721 2002-08-11 Martin Baulig <martin@gnome.org>
9723 Added control flow analysis support for structs.
9725 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9726 with control flow analysis turned off.
9727 (IVariable): New interface.
9728 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9729 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9730 (FieldExpr.DoResolve): Resolve the instance expression with flow
9731 analysis turned off and do the definite assignment check after the
9732 resolving when we know what the expression will resolve to.
9734 * expression.cs (LocalVariableReference, ParameterReference):
9735 Implement the new IVariable interface, only call the flow analysis
9736 code if ec.DoFlowAnalysis is true.
9737 (This): Added constructor which takes a Block argument. Implement
9738 the new IVariable interface.
9739 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9740 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9741 This does the definite assignment checks for struct members.
9743 * class.cs (Constructor.Emit): If this is a non-static `struct'
9744 constructor which doesn't have any initializer, call
9745 Block.AddThisVariable() to tell the flow analysis code that all
9746 struct elements must be initialized before control returns from
9749 * statement.cs (MyStructInfo): New public class.
9750 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9751 argument to this indexer. If non-zero, check an individual struct
9752 member, not the whole struct.
9753 (FlowBranching.CheckOutParameters): Check struct members.
9754 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9755 overloaded versions of these methods which take an additional
9756 `int field_idx' argument to check struct members.
9757 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9758 overloaded versions of these methods which take an additional
9759 `string field_name' argument to check struct member.s
9760 (VariableInfo): Implement the IVariable interface.
9761 (VariableInfo.StructInfo): New public property. Returns the
9762 MyStructInfo instance of the variable if it's a struct or null.
9763 (Block.AddThisVariable): New public method. This is called from
9764 Constructor.Emit() for non-static `struct' constructor which do
9765 not have any initializer. It creates a special variable for the
9766 "this" instance variable which will be checked by the flow
9767 analysis code to ensure that all of the struct's fields are
9768 initialized before control returns from the constructor.
9769 (UsageVector): Added support for struct members. If a
9770 variable/parameter is a struct with N members, we reserve a slot
9771 in the usage vector for each member. A struct is considered fully
9772 initialized if either the struct itself (slot 0) or all its
9773 members are initialized.
9775 2002-08-08 Martin Baulig <martin@gnome.org>
9777 * driver.cs (Driver.MainDriver): Only report an error CS5001
9778 if there were no compilation errors.
9780 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
9781 `UnsafeContext' property to determine whether the parent is in
9782 unsafe context rather than checking the parent's ModFlags:
9783 classes nested in an unsafe class are unsafe as well.
9785 2002-08-08 Martin Baulig <martin@gnome.org>
9787 * statement.cs (UsageVector.MergeChildren): Distinguish between
9788 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
9789 we return. Added test17() and test18() to test-154.cs.
9791 2002-08-08 Martin Baulig <martin@gnome.org>
9793 * typemanager.cs (TypeManager.FilterWithClosure): If we have
9794 Family access, make sure the invoking type isn't a subclass of the
9795 queried type (that'd be a CS1540).
9797 * ecore.cs (Expression.MemberLookup): Added overloaded version of
9798 this method which takes an additional `Type invocation_type'.
9800 * expression.cs (BaseAccess.DoResolve): Use the base type as
9801 invocation and query type.
9802 (MemberAccess.DoResolve): If the lookup failed and we're about to
9803 report a CS0122, try a lookup with the ec.ContainerType - if this
9804 succeeds, we must report a CS1540.
9806 2002-08-08 Martin Baulig <martin@gnome.org>
9808 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
9809 (MethodGroupExpr): Implement the IMemberExpr interface.
9811 * expression (MemberAccess.ResolveMemberAccess): No need to have
9812 any special code for MethodGroupExprs anymore, they're now
9815 2002-08-08 Martin Baulig <martin@gnome.org>
9817 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
9818 Family, FamANDAssem and FamORAssem permissions.
9819 (TypeManager.IsSubclassOrNestedChildOf): New public method.
9821 2002-08-08 Martin Baulig <martin@gnome.org>
9823 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
9824 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
9827 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
9829 * driver.cs: implemented /resource option to embed managed resources.
9831 2002-08-07 Martin Baulig <martin@gnome.org>
9833 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
9834 (FieldBase.HasFieldInitializer): New public property.
9835 (FieldBase.GetInitializerExpression): New public method. Resolves and
9836 returns the field initializer and makes sure it is only resolved once.
9837 (TypeContainer.EmitFieldInitializers): Call
9838 FieldBase.GetInitializerExpression to get the initializer, this ensures
9839 that it isn't resolved multiple times.
9841 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
9842 the resolving process (SimpleName/MemberLookup) that we're currently
9843 emitting a field initializer (which must not access any instance members,
9844 this is an error CS0236).
9846 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
9847 argument, if the `IsFieldInitializer' flag is set, we must report and
9848 error CS0236 and not an error CS0120.
9850 2002-08-07 Martin Baulig <martin@gnome.org>
9852 * ecore.cs (IMemberExpr): New public interface.
9853 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
9854 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
9855 if the expression is an IMemberExpr.
9857 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
9858 to be null, implicitly default to `this' if we're non-static in
9859 this case. Simplified the code a lot by using the new IMemberExpr
9860 interface. Also fixed bug #28176 here.
9862 2002-08-06 Martin Baulig <martin@gnome.org>
9864 * cs-parser.jay (SimpleLookup): Removed. We need to create
9865 ParameterReferences during semantic analysis so that we can do a
9866 type-only search when resolving Cast, TypeOf and SizeOf.
9867 (block): Pass the `current_local_parameters' to the Block's
9870 * class.cs (ConstructorInitializer): Added `Parameters parameters'
9871 argument to the constructor.
9872 (ConstructorInitializer.Resolve): Create a temporary implicit
9873 block with the parameters.
9875 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
9876 references here if we aren't doing a type-only search.
9878 * statement.cs (Block): Added constructor which takes a
9879 `Parameters parameters' argument.
9880 (Block.Parameters): New public property.
9882 * support.cs (InternalParameters.Parameters): Renamed `parameters'
9883 to `Parameters' and made it public readonly.
9885 2002-08-06 Martin Baulig <martin@gnome.org>
9887 * ecore.cs (Expression.Warning): Made this public as well.
9889 * report.cs (Report.Debug): Print the contents of collections.
9891 2002-08-06 Martin Baulig <martin@gnome.org>
9893 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
9894 used to tell Resolve() which kinds of expressions it may return.
9895 (Expression.Resolve): Added overloaded version of this method which
9896 takes a `ResolveFlags flags' argument. This can be used to tell
9897 Resolve() which kinds of expressions it may return. Reports a
9899 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
9900 ResolveFlags.SimpleName.
9901 (Expression.Error118): Added overloaded version of this method which
9902 takes a `ResolveFlags flags' argument. It uses the flags to determine
9903 which kinds of expressions are allowed.
9905 * expression.cs (Argument.ResolveMethodGroup): New public method.
9906 Resolves an argument, but allows a MethodGroup to be returned.
9907 This is used when invoking a delegate.
9909 * TODO: Updated a bit.
9911 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9913 Fixed compilation with csc.
9915 * ecore.cs: Expression.Error made public. Is this correct? Should
9916 Warning be made public too?
9918 * expression.cs: use ea.Location instead of ea.loc.
9919 [FIXME: Filed as bug #28607: MCS must report these errors.]
9921 2002-08-06 Martin Baulig <martin@gnome.org>
9923 * ecore.cs (Expression.loc): Moved the location here instead of
9924 duplicating it in all derived classes.
9925 (Expression.Location): New public property.
9926 (Expression.Error, Expression.Warning): Made them non-static and
9927 removed the location argument.
9928 (Expression.Warning): Added overloaded version which takes an
9929 `int level' argument.
9930 (Expression.Error118): Make this non-static and removed the
9931 expression and location arguments.
9932 (TypeExpr): Added location argument to the constructor.
9934 * expression.cs (StaticCallExpr): Added location argument to
9936 (Indirection, PointerArithmetic): Likewise.
9937 (CheckedExpr, UnCheckedExpr): Likewise.
9938 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
9939 (StringPtr): Likewise.
9942 2002-08-05 Martin Baulig <martin@gnome.org>
9944 * expression.cs (BaseAccess.DoResolve): Actually report errors.
9946 * assign.cs (Assign.DoResolve): Check whether the source
9947 expression is a value or variable.
9949 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
9950 while resolving the corresponding blocks.
9952 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
9953 an error, don't silently return null.
9955 * statement.cs (Block.AddVariable): Do the error reporting here
9956 and distinguish between CS0128 and CS0136.
9957 (Block.DoResolve): Report all unused labels (warning CS0164).
9958 (LabeledStatement): Pass the location to the constructor.
9959 (LabeledStatement.HasBeenReferenced): New property.
9960 (LabeledStatement.Resolve): Set it to true here.
9962 * statement.cs (Return.Emit): Return success even after reporting
9963 a type mismatch error (CS0126 or CS0127), this is what csc does and
9964 it avoids confusing the users with any consecutive errors.
9966 2002-08-05 Martin Baulig <martin@gnome.org>
9968 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
9970 * const.cs (Const.LookupConstantValue): Catch circular definitions.
9972 * expression.cs (MemberAccess.DoResolve): Silently return if an
9973 error has already been reported.
9975 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
9976 error has already been reported.
9978 2002-08-05 Martin Baulig <martin@gnome.org>
9980 * statement.cs (UsageVector): Only initialize the `parameters'
9981 vector if we actually have any "out" parameters.
9983 2002-08-05 Martin Baulig <martin@gnome.org>
9985 * expression.cs (Binary.ResolveOperator): When combining delegates,
9986 they must have the same type.
9988 2002-08-05 Martin Baulig <martin@gnome.org>
9990 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
9991 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
9992 work with the ms runtime and we also don't need it: if we're a
9993 PropertyBuilder and not in the `indexer_arguments' hash, then we
9994 are a property and not an indexer.
9996 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
9997 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
9998 since the latter one doesn't work with the ms runtime.
10000 2002-08-03 Martin Baulig <martin@gnome.org>
10002 Fixed bugs #27998 and #22735.
10004 * class.cs (Method.IsOperator): New public field.
10005 (Method.CheckBase): Report CS0111 if there's already a method
10006 with the same parameters in the current class. Report CS0508 when
10007 attempting to change the return type of an inherited method.
10008 (MethodData.Emit): Report CS0179 if a method doesn't have a body
10009 and it's not marked abstract or extern.
10010 (PropertyBase): New abstract base class for Property and Indexer.
10011 (PropertyBase.CheckBase): Moved here from Property and made it work
10013 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
10014 the same so we can reuse it there.
10015 (Property, Indexer): Derive from PropertyBase.
10016 (MethodSignature.inheritable_property_signature_filter): New delegate
10017 to find properties and indexers.
10019 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
10020 argument and improved error reporting.
10022 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
10023 EmptyReadOnlyParameters and made it a property.
10025 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
10026 version of this method which takes a `PropertyInfo indexer'.
10027 (TypeManager.RegisterIndexer): New method.
10029 * class.cs: Added myself as author of this file :-)
10031 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10033 * class.cs: fixed compilation on windoze.
10035 2002-08-03 Martin Baulig <martin@gnome.org>
10037 * interface.cs (Interface.GetInterfaceBases): Check whether all
10038 base interfaces are at least as accessible than the current one.
10040 * class.cs (TypeContainer.GetClassBases): Check whether base types
10041 are at least as accessible than the current type.
10042 (TypeContainer.AsAccessible): Implemented and made non-static.
10043 (MemberBase.CheckParameters): Report errors if the accessibility
10046 * delegate.cs (Delegate.Delegate): The default visibility is
10047 internal for top-level types and private for nested types.
10048 (Delegate.Define): Report errors if the accessibility checks fail.
10050 * enum.cs (Enum.Enum): The default visibility is internal for
10051 top-level types and private for nested types.
10052 (Enum.DefineType): Compute the correct visibility.
10054 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
10055 function which takes a `bool is_toplevel' instead of a TypeContainer.
10057 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
10060 2002-08-02 Martin Baulig <martin@gnome.org>
10062 * expression.cs (LocalVariableReferenc): Added constructor which
10063 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
10064 (LocalVariableReference.IsReadOnly): New property.
10065 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
10066 variable is readonly, use our own readonly flag to do this; you can
10067 use the new constructor to get a writable reference to a read-only
10070 * cs-parser.jay (foreach_statement, using_statement): Get a writable
10071 reference to the local variable.
10073 2002-08-01 Miguel de Icaza <miguel@ximian.com>
10075 * rootcontext.cs (ResolveCore): Also include System.Exception
10077 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
10078 we reach an EmptyStatement.
10080 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
10083 * expression.cs (Binary.ResolveOperator): Check error result in
10086 use brtrue/brfalse directly and avoid compares to null.
10088 2002-08-02 Martin Baulig <martin@gnome.org>
10090 * class.cs (TypeContainer.Define): Define all nested interfaces here.
10091 Fixes bug #28407, added test-155.cs.
10093 2002-08-01 Martin Baulig <martin@gnome.org>
10095 * class.cs (Event.EmitDefaultMethod): Make this work with static
10096 events. Fixes #28311, added verify-3.cs.
10098 2002-08-01 Martin Baulig <martin@gnome.org>
10100 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
10101 `is_disposable' fields.
10102 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
10103 `hm.is_disposable' if we're using the collection pattern.
10104 (Foreach.EmitCollectionForeach): Use the correct type for the
10105 enumerator's local variable, only emit the try/finally block if
10106 necessary (fixes #27713).
10108 2002-08-01 Martin Baulig <martin@gnome.org>
10110 * ecore.cs (Expression.report118): Renamed to Error118 and made
10113 * statement.cs (Throw.Resolve): Check whether the expression is of
10114 the correct type (CS0118) and whether the type derives from
10115 System.Exception (CS0155).
10116 (Catch.Resolve): New method. Do the type lookup here and check
10117 whether it derives from System.Exception (CS0155).
10118 (Catch.CatchType, Catch.IsGeneral): New public properties.
10120 * typemanager.cs (TypeManager.exception_type): Added.
10122 2002-07-31 Miguel de Icaza <miguel@ximian.com>
10124 * driver.cs: Updated About function.
10126 2002-07-31 Martin Baulig <martin@gnome.org>
10128 Implemented Control Flow Analysis.
10130 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
10131 (EmitContext.CurrentBranching): Added.
10132 (EmitContext.StartFlowBranching): Added.
10133 (EmitContext.EndFlowBranching): Added.
10134 (EmitContext.KillFlowBranching): Added.
10135 (EmitContext.IsVariableAssigned): Added.
10136 (EmitContext.SetVariableAssigned): Added.
10137 (EmitContext.IsParameterAssigned): Added.
10138 (EmitContext.SetParameterAssigned): Added.
10139 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
10140 Added control flow analysis stuff here.
10142 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
10143 resolve the expression as lvalue.
10144 (LocalVariableReference.DoResolve): Check whether the variable has
10145 already been assigned.
10146 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
10147 the parameter as assigned here.
10148 (ParameterReference.DoResolve): Check whether the parameter has already
10150 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
10151 expression as lvalue.
10153 * statement.cs (FlowBranching): New class for the flow analysis code.
10154 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
10155 (LabeledStatement.IsDefined): New public property.
10156 (LabeledStatement.AddUsageVector): New public method to tell flow
10157 analyis that the label may be reached via a forward jump.
10158 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
10160 (VariableInfo.Number): New public field. This is used by flow analysis
10161 to number all locals of a block.
10162 (Block.CountVariables): New public property. This is the number of
10163 local variables in this block (including the locals from all parent
10165 (Block.EmitMeta): Number all the variables.
10167 * statement.cs: Added flow analysis support to all classes.
10169 2002-07-31 Martin Baulig <martin@gnome.org>
10171 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
10172 To get debugging messages, compile mcs with /define:MCS_DEBUG and
10173 then use this argument.
10175 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
10177 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
10178 use this to specify /define options.
10180 2002-07-29 Martin Baulig <martin@gnome.org>
10182 * statement.cs (Fixed): Moved all code that does variable lookups
10183 and resolvings from Emit to Resolve.
10185 * statement.cs (For): Moved all code that does variable lookups
10186 and resolvings from Emit to Resolve.
10188 * statement.cs (Using): Moved all code that does variable lookups
10189 and resolvings from Emit to Resolve.
10191 2002-07-29 Martin Baulig <martin@gnome.org>
10193 * attribute.cs (Attribute.Resolve): Explicitly catch a
10194 System.NullReferenceException when creating the
10195 CustromAttributeBuilder and report a different warning message.
10197 2002-07-29 Martin Baulig <martin@gnome.org>
10199 * support.cs (ParameterData.ParameterName): Added method to
10200 get the name of a parameter.
10202 * typemanager.cs (TypeManager.IsValueType): New public method.
10204 2002-07-29 Martin Baulig <martin@gnome.org>
10206 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
10207 is a flag which specifies that it's either ref or out.
10208 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
10209 the out parameter to `out Parameter.Modifier mod', also set the
10210 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
10212 * support.cs (InternalParameters.ParameterModifier): Distinguish
10213 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10214 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10216 * expression.cs (Argument.GetParameterModifier): Distinguish
10217 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10218 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10220 2002-07-29 Martin Baulig <martin@gnome.org>
10222 * expression.cs (ParameterReference.ParameterReference): Added
10223 `Location loc' argument to the constructor.
10225 * cs-parser.jay: Pass location to ParameterReference.
10227 2002-07-28 Miguel de Icaza <miguel@ximian.com>
10229 * statement.cs (Try): Initialize the location.
10231 * cs-parser.jay: pass location to Try.
10233 * expression.cs (Unary.Reduce): Change the prototype to return
10234 whether a constant fold could be performed or not. The result is
10235 returned in an out parameters. In the case of Indirection and
10236 AddressOf, we want to perform the full tests.
10238 2002-07-26 Miguel de Icaza <miguel@ximian.com>
10240 * statement.cs (Statement.Emit): Flag dead code.
10242 2002-07-27 Andrew Birkett <andy@nobugs.org>
10244 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
10246 2002-07-27 Martin Baulig <martin@gnome.org>
10248 * class.cs (MethodData.Define): Put back call to
10249 TypeManager.AddMethod(), accidentally commented this out.
10251 * report.cs (Debug): New public method to print debugging information,
10252 this is `[Conditional ("DEBUG")]'.
10254 2002-07-26 Martin Baulig <martin@gnome.org>
10256 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10257 (switch_statement): Push the current_block to the switch_stack and
10258 pop it again when we're done with the switch.
10259 (switch_section): The new block is a child of the current_block.
10260 Fixes bug #24007, added test-152.cs.
10262 2002-07-27 Martin Baulig <martin@gnome.org>
10264 * expression.cs (Invocation.EmitArguments): When calling a varargs
10265 function with only its fixed arguments, we need to pass an empty
10268 2002-07-27 Martin Baulig <martin@gnome.org>
10270 Mono 0.13 has been released.
10272 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10274 * driver.cs: Rename --resource to --linkres, because that is what
10275 we do currently, we dont support --resource yet.
10277 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10279 2002-07-25 Martin Baulig <martin@gnome.org>
10281 * class.cs (MethodData): New public class. This is a `method builder'
10282 class for a method or one accessor of a Property/Indexer/Event.
10283 (MethodData.GetMethodFlags): Moved here from MemberBase.
10284 (MethodData.ApplyAttributes): Likewise.
10285 (MethodData.ApplyObsoleteAttribute): Likewise.
10286 (MethodData.ApplyConditionalAttribute): Likewise.
10287 (MethodData.ApplyDllImportAttribute): Likewise.
10288 (MethodData.CheckAbstractAndExternal): Likewise.
10289 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10290 (MethodData.Emit): Formerly known as Method.Emit().
10291 (MemberBase): Moved everything which was specific to a single
10292 accessor/method to MethodData.
10293 (Method): Create a new MethodData and call Define() and Emit() on it.
10294 (Property, Indexer, Event): Create a new MethodData objects for each
10295 accessor and call Define() and Emit() on them.
10297 2002-07-25 Martin Baulig <martin@gnome.org>
10299 Made MethodCore derive from MemberBase to reuse the code from there.
10300 MemberBase now also checks for attributes.
10302 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10303 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10305 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10306 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10307 (MemberBase.ApplyAttributes): New virtual method; applies the
10308 attributes to a method or accessor.
10309 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10310 (MemberBase.ApplyConditionalAttribute): Likewise.
10311 (MemberBase.ApplyDllImportAttribute): Likewise.
10312 (MemberBase.CheckAbstractAndExternal): Likewise.
10313 (MethodCore.ParameterTypes): This is now a property instead of a
10314 method, it's initialized from DoDefineParameters().
10315 (MethodCore.ParameterInfo): Removed the set accessor.
10316 (MethodCore.DoDefineParameters): New protected virtual method to
10317 initialize ParameterTypes and ParameterInfo.
10318 (Method.GetReturnType): We can now simply return the MemberType.
10319 (Method.GetMethodFlags): Override the MemberBase version and add
10320 the conditional flags.
10321 (Method.CheckBase): Moved some code from Define() here, call
10322 DoDefineParameters() here.
10323 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10324 here to avoid some larger code duplication.
10325 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10326 ensure that abstract and external accessors don't declare a body.
10328 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10329 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10330 lookup in the attribute's parent classes, so we need to abort as soon
10331 as we found the first match.
10332 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10333 the attribute has no arguments.
10335 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10338 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10340 * cs-parser.jay: reverted previous patch.
10342 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10344 * cs-parser.jay: fixed bug #22119.
10346 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10348 * attribute.cs: fixed compilation. The error was:
10349 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10350 be assigned to before control leaves the current method."
10351 [FIXME: Filed as bug #28186: MCS must report this error.]
10353 2002-07-25 Martin Baulig <martin@gnome.org>
10355 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10356 method to pull the condition name ouf of a Conditional attribute.
10357 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10358 the obsolete message and error flag out of an Obsolete attribute.
10360 * class.cs (Method.GetMethodFlags): New public method to get the
10361 TypeManager.MethodFlags for this method.
10362 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10364 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10365 if we're overriding a virtual function, set the new private variable
10366 `parent_method'; call the new TypeManager.AddMethod().
10368 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10369 the MethodBuilder and the Method in a PtrHashtable.
10370 (TypeManager.builder_to_method): Added for this purpose.
10371 (TypeManager.MethodFlags): Added IsObsoleteError.
10372 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10373 Obsolete and Conditional arguments in MethodBuilders. If we discover
10374 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10375 the message from the attribute.
10377 2002-07-24 Martin Baulig <martin@gnome.org>
10379 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10380 preprocessor directives, ensure that the argument to #define/#undef is
10381 exactly one identifier and that it's actually an identifier.
10383 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10386 2002-07-24 Martin Baulig <martin@gnome.org>
10388 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10389 initialize it to TypeManager.object_type in the constructor.
10390 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10391 of the `hm.get_current' method if we're using the collection pattern.
10392 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10393 for the explicit conversion to make it work when we're using the collection
10394 pattern and the `Current' property has a different return type than `object'.
10397 2002-07-24 Martin Baulig <martin@gnome.org>
10399 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10400 does not match, but don't report any errors. This method is called in
10401 order for all methods in a MethodGroupExpr until a matching method is
10402 found, so we don't want to bail out if the first method doesn't match.
10403 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10404 matches, report the 123. Fixes #28070.
10406 2002-07-24 Martin Baulig <martin@gnome.org>
10408 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10409 TypeManager.TypeToCoreType() to the top of the method so the
10410 following equality checks will work. Fixes #28107.
10412 2002-07-24 Martin Baulig <martin@gnome.org>
10414 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10415 operand is of type uint, and the other operand is of type sbyte,
10416 short or int, the operands are converted to type long." -
10417 Actually do what this comment already told us. Fixes bug #28106,
10420 2002-07-24 Martin Baulig <martin@gnome.org>
10422 * class.cs (MethodBase): New abstract class. This is now a base
10423 class for Property, Indexer and Event to avoid some code duplication
10424 in their Define() and DefineMethods() methods.
10425 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10426 generic methods for Define() and DefineMethods().
10427 (FieldBase): Derive from MemberBase, not MemberCore.
10428 (Property): Derive from MemberBase, not MemberCore.
10429 (Property.DefineMethod): Moved all the code from this method to the
10430 new MethodBase.DefineAccessor(), just call it with appropriate
10432 (Property.Define): Call the new Property.DoDefine(), this does some
10433 sanity checks and we don't need to duplicate the code everywhere.
10434 (Event): Derive from MemberBase, not MemberCore.
10435 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10436 accessors, this will also make them work with interface events.
10437 (Indexer): Derive from MemberBase, not MemberCore.
10438 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10439 (Indexer.Define): Use the new MethodBase functions.
10441 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10442 argument to the constructor.
10443 (Interface.FindMembers): Added support for interface events.
10444 (Interface.PopluateEvent): Implemented.
10446 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10448 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10450 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10451 but this is required to check for a method name being the same as
10452 the containing class.
10456 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10458 * interface.cs: initialize variable.
10460 2002-07-23 Martin Baulig <martin@gnome.org>
10462 Implemented the IndexerName attribute in interfaces.
10464 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10465 name if this is an explicit interface implementation.
10466 (Indexer.InterfaceIndexerName): New public variable. If we're
10467 implementing an interface indexer, this is the IndexerName in that
10468 interface. Otherwise, it's the IndexerName.
10469 (Indexer.DefineMethod): If we're implementing interface indexer,
10470 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10471 and Pending.ImplementIndexer methods.
10472 (Indexer.Define): Also define the PropertyBuilder if we're
10473 implementing an interface indexer and this is neither an explicit
10474 interface implementation nor do the IndexerName match the one in
10477 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10478 If a method is defined here, then we always need to create a proxy
10479 for it. This is used when implementing interface indexers.
10480 (Pending.IsInterfaceIndexer): New public method.
10481 (Pending.ImplementIndexer): New public method.
10482 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10483 This is used when implementing interface indexers to define a proxy
10485 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10486 define a proxy if necessary.
10488 * interface.cs (Interface.IndexerName): New public variable.
10489 (Interface.PopulateIndexer): Set the IndexerName.
10490 (Interface.DefineIndexers): New private method. Populate all the
10491 indexers and make sure their IndexerNames match.
10493 * typemanager.cs (IndexerPropertyName): Added support for interface
10496 2002-07-22 Martin Baulig <martin@gnome.org>
10498 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10499 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10500 ret if HasReturnLabel.
10501 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10504 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10505 and set the ec.LoopBeginTryCatchLevel.
10506 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10507 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10508 the current ec.TryCatchLevel, the branch goes out of an exception
10509 block. In this case, we need to use Leave and not Br.
10511 2002-07-22 Martin Baulig <martin@gnome.org>
10513 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10514 block unless the block does not always return or it is contained in
10515 another try { ... } catch { ... } block. Fixes bug #26506.
10516 Added verify-1.cs to the test suite.
10518 2002-07-22 Martin Baulig <martin@gnome.org>
10520 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10521 then we do not always return. Fixes bug #24985.
10523 2002-07-22 Martin Baulig <martin@gnome.org>
10525 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10526 lookup on a per-class level; ie. walk up the class hierarchy until we
10527 found at least one applicable method, then choose the best among them.
10528 Fixes bug #24463 and test-29.cs.
10530 2002-07-22 Martin Baulig <martin@gnome.org>
10532 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10533 return types of the methods. The return type is not part of the
10534 signature and we must not check it to make the `new' modifier work.
10535 Fixes bug #27999, also added test-147.cs.
10536 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10538 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10539 on the method's return type.
10541 2002-07-21 Martin Baulig <martin@gnome.org>
10543 * assign.cs: Make this work if the rightmost source is a constant and
10544 we need to do an implicit type conversion. Also adding a few more tests
10545 to test-38.cs which should have caught this.
10547 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10548 target in the makefile for this. The makefile.gnu is primarily intended
10549 for end-users who don't want to debug the compiler.
10551 2002-07-21 Martin Baulig <martin@gnome.org>
10553 * assign.cs: Improved the Assign class so it can now handle embedded
10554 assignments (X = Y = Z = something). As a side-effect this'll now also
10555 consume less local variables. test-38.cs now passes with MCS, added
10556 a few new test cases to that test.
10558 2002-07-20 Martin Baulig <martin@gnome.org>
10560 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10561 instructions. Fixes bug #27977, also added test-146.cs.
10563 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10565 * cs-tokenizer.cs: fixed getHex ().
10567 2002-07-19 Martin Baulig <martin@gnome.org>
10569 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10570 not Type.GetType() to lookup the array type. This is needed when
10571 we're constructing an array of a user-defined type.
10572 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10573 single-dimensional arrays, but also for single-dimensial arrays of
10576 2002-07-19 Martin Baulig <martin@gnome.org>
10578 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10579 this function is called, it's not allowed to share LocalBuilders
10580 among ILGenerators.
10582 2002-07-19 Martin Baulig <martin@gnome.org>
10584 * expression.cs (Argument.Resolve): Report an error 118 when trying
10585 to pass a type as argument.
10587 2002-07-18 Martin Baulig <martin@gnome.org>
10589 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10590 Conv_R_Un for the signed `long' type.
10592 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10594 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10595 `expr' for the temporary result, as that will fail if we do
10596 multiple resolves on the same expression.
10598 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10600 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10601 ec.TypeContainer for looking up aliases.
10603 * class.cs (TypeContainer): Remove LookupAlias from here.
10605 * decl.cs (DeclSpace); Move here.
10607 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10609 * class.cs (FindMembers): Only call filter if the constructor
10610 bulider is not null.
10612 Also handle delegates in `NestedTypes' now. Now we will perform
10613 type lookups using the standard resolution process. This also
10616 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10617 This uses Expressions (the limited kind that can be parsed by the
10618 tree) instead of strings.
10620 * expression.cs (ComposedCast.ToString): Implement, used to flag
10621 errors since now we have to render expressions.
10623 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10626 * ecore.cs (SimpleName.ToString): ditto.
10628 * cs-parser.jay: Instead of using strings to assemble types, use
10629 Expressions to assemble the type (using SimpleName, ComposedCast,
10630 MemberAccess). This should fix the type lookups in declarations,
10631 because we were using a different code path for this.
10633 * statement.cs (Block.Resolve): Continue processing statements
10634 even when there is an error.
10636 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10638 * class.cs (Event.Define): Also remove the `remove' method from
10639 the list of pending items.
10641 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10642 generate more compact code.
10644 2002-07-17 Martin Baulig <martin@gnome.org>
10646 * const.cs (Const.LookupConstantValue): Add support for constant
10647 `unchecked' and `checked' expressions.
10648 Also adding test case test-140.cs for this.
10650 2002-07-17 Martin Baulig <martin@gnome.org>
10652 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10653 check whether mi.ReturnType implements the IEnumerator interface; the
10654 `==' and the IsAssignableFrom() will fail in this situation.
10656 2002-07-16 Ravi Pratap <ravi@ximian.com>
10658 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10661 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10663 * expression.cs: fixed bug #27811.
10665 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10667 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10668 Molaro: when we are a ref, the value already contains a pointer
10669 value, do not take the address of it.
10671 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10672 * removed mb-parser.jay and mb-tokenizer.cs
10674 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10676 * expression.cs: check against the building corlib void type.
10678 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10680 * ecore.cs: fix for valuetype static readonly fields: when
10681 initializing them, we need their address, not the address of a copy.
10683 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10685 * typemanager.cs: register also enum_type in corlib.
10687 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10689 * class.cs: allow calling this (but not base) initializers in structs.
10691 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10693 * ecore.cs: make sure we compare against the building base types
10696 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10698 * typemanager.cs: fix TypeToCoreType() to handle void and object
10699 (corlib gets no more typerefs after this change).
10701 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10703 * expression.cs (ArrayCreation.EmitArrayArguments): use
10704 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10706 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10707 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10708 array indexes, the runtime actually forbids them.
10710 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10711 for array arguments here.
10713 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10714 instead of the default for ValueTypes.
10716 (New.DoEmit): Use IsValueType instead of
10717 IsSubclassOf (value_type)
10718 (New.DoResolve): ditto.
10719 (Invocation.EmitCall): ditto.
10721 * assign.cs (Assign): ditto.
10723 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10724 Statements *are* currently doing part of their resolution during
10727 Expressions do always resolve during resolve, but statements are
10728 only required to propagate resolution to their children.
10730 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10732 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10734 (LoadAssembly): Do not add the dll if it is already specified
10736 (MainDriver): Add the System directory to the link path at the end,
10737 after all the other -L arguments.
10739 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10740 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10741 ldelem.u1) and using the opposite for sbytes.
10743 This fixes Digger, and we can finally run it.
10745 * driver.cs (UnixParseOption): Move the option parsing here.
10746 (CSCParseOption): Implement CSC-like parsing of options.
10748 We now support both modes of operation, the old Unix way, and the
10749 new CSC-like way. This should help those who wanted to make cross
10750 platform makefiles.
10752 The only thing broken is that /r:, /reference: and /lib: are not
10753 implemented, because I want to make those have the same semantics
10754 as the CSC compiler has, and kill once and for all the confussion
10755 around this. Will be doing this tomorrow.
10757 * statement.cs (Unsafe.Resolve): The state is checked during
10758 resolve, not emit, so we have to set the flags for IsUnsfe here.
10760 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10762 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10763 not catch the Error_ObjectRefRequired in SimpleName (as it is
10764 possible to have a class/instance variable name that later gets
10765 deambiguated), we have to check this here.
10767 2002-07-10 Ravi Pratap <ravi@ximian.com>
10769 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10770 make static and put into Expression.
10772 (Event.Define): Register the private field of the event with the
10773 TypeManager so that GetFieldFromEvent can get at it.
10775 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10776 keep track of the private field associated with an event which
10779 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
10782 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
10784 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10786 * expression.cs (Binary.EmitBranchable): this routine emits the
10787 Binary expression in a branchable context. This basically means:
10788 we need to branch somewhere, not just get the value on the stack.
10790 This works together with Statement.EmitBoolExpression.
10792 * statement.cs (Statement.EmitBoolExpression): Use
10795 2002-07-09 Miguel de Icaza <miguel@ximian.com>
10797 * statement.cs (For): Reduce the number of jumps in loops.
10799 (For): Implement loop inversion for the For statement.
10801 (Break): We can be breaking out of a Try/Catch controlled section
10802 (foreach might have an implicit try/catch clause), so we need to
10803 use Leave instead of Br.
10805 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
10806 now). If the instace expression supports IMemoryLocation, we use
10807 the AddressOf method from the IMemoryLocation to extract the
10808 address instead of emitting the instance.
10810 This showed up with `This', as we were emitting the instance
10811 always (Emit) instead of the Address of This. Particularly
10812 interesting when This is a value type, as we dont want the Emit
10813 effect (which was to load the object).
10815 2002-07-08 Miguel de Icaza <miguel@ximian.com>
10817 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
10819 * statement.cs (Checked): Set the CheckedState during the resolve
10820 process too, as the ConvCast operations track the checked state on
10821 the resolve process, and not emit.
10823 * cs-parser.jay (namespace_member_declaration): Flag that we have
10824 found a declaration when we do. This is used to flag error 1529
10826 * driver.cs: Report ok when we display the help only.
10828 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
10830 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
10832 2002-07-04 Miguel de Icaza <miguel@ximian.com>
10834 * cs-tokenizer.cs (define): We also have to track locally the
10835 defines. AllDefines is just used for the Conditional Attribute,
10836 but we also need the local defines for the current source code.
10838 2002-07-03 Miguel de Icaza <miguel@ximian.com>
10840 * statement.cs (While, For, Do): These loops can exit through a
10841 Break statement, use this information to tell whether the
10842 statement is the last piece of code.
10844 (Break): Flag that we break.
10846 * codegen.cs (EmitContexts): New `Breaks' state variable.
10848 2002-07-03 Martin Baulig <martin@gnome.org>
10850 * class.cs (TypeContainer.MethodModifiersValid): Allow override
10851 modifiers in method declarations in structs. Otherwise, you won't
10852 be able to override things like Object.Equals().
10854 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10856 * class.cs (Method, Property, Indexer): Do not allow the public
10857 modifier to be used in explicit interface implementations.
10859 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
10860 override modifiers in method declarations in structs
10862 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
10864 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
10865 integer or real overflow, report an error
10867 2002-07-02 Martin Baulig <martin@gnome.org>
10869 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
10870 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
10871 to tell the runtime about our newly created System.Object and
10872 System.ValueType types.
10874 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10876 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
10877 struct instead of Ldarg/Starg.
10879 2002-07-02 Martin Baulig <martin@gnome.org>
10881 * expression.cs (Indirection.Indirection): Call
10882 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
10884 2002-07-02 Martin Baulig <martin@gnome.org>
10886 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
10887 ValueType, call TypeManager.TypeToCoreType() on it.
10888 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
10889 the OpCodes.Newarr argument.
10891 2002-07-02 Martin Baulig <martin@gnome.org>
10893 * expression.cs (Invocation.EmitCall): When compiling corlib,
10894 replace all calls to the system's System.Array type to calls to
10895 the newly created one.
10897 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
10898 System.Array methods.
10899 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
10900 from the system's System.Array type which must be replaced.
10902 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
10904 * typemanager.cs: load unverifiable_code_ctor so we can build
10905 corlib using the correct type. Avoid using GetTypeCode() with
10907 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
10908 TypeManager.object_type to allow building corlib.
10910 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
10912 * ecore.cs: handle System.Enum separately in LoadFromPtr().
10914 2002-07-01 Martin Baulig <martin@gnome.org>
10916 * class.cs: Make the last change actually work, we need to check
10917 whether `ifaces != null' to avoid a crash.
10919 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10921 * class.cs: when we build structs without fields that implement
10922 interfaces, we need to add the interfaces separately, since there is
10923 no API to both set the size and add the interfaces at type creation
10926 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10928 * expression.cs: the dimension arguments to the array constructors
10929 need to be converted if they are a long.
10931 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
10933 * class.cs: don't emit ldarg.0 if there is no parent constructor
10934 (fixes showstopper for corlib).
10936 2002-06-29 Martin Baulig <martin@gnome.org>
10938 MCS now compiles corlib on GNU/Linux :-)
10940 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
10941 ie. check for MethodImplOptions.InternalCall.
10943 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
10944 and TypeManager.attribute_type are null, so we must explicitly check
10945 whether parent is not null to find out whether it's an attribute type.
10946 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
10947 and SetBuilder, not only if the property is neither abstract nor external.
10948 This is necessary to set the MethodImplOptions on the accessor methods.
10949 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
10950 SetBuilder, see Property.Emit().
10952 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
10953 populate "System.Object", "System.ValueType" and "System.Attribute" since
10954 they've already been populated from BootCorlib_PopulateCoreTypes().
10956 2002-06-29 Martin Baulig <martin@gnome.org>
10958 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
10959 is the NullLiteral, we also need to make sure that target_type is not
10962 2002-06-29 Martin Baulig <martin@gnome.org>
10964 * rootcontext.cs (RootContext.ResolveCore): We must initialize
10965 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
10966 before calling BootstrapCorlib_ResolveDelegate ().
10968 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10970 * statement.cs: fixed build-breaker. All tests passed ok.
10972 2002-06-27 Martin Baulig <martin@gnome.org>
10974 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
10975 for System.Decimal when compiling corlib.
10977 2002-06-27 Martin Baulig <martin@gnome.org>
10979 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
10980 switch blocks which contain nothing but a default clause.
10982 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
10984 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
10986 2002-06-27 Martin Baulig <martin@gnome.org>
10988 * ecore.cs (PropertyExpr.PropertyExpr): Call
10989 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
10991 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
10992 is already a TypeBuilder.
10994 2002-06-27 Martin Baulig <martin@gnome.org>
10996 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
10997 `target_type == TypeManager.array_type', not IsAssignableFrom() in
10998 the "from an array-type to System.Array" case. This makes it work
10999 when compiling corlib.
11001 2002-06-27 Martin Baulig <martin@gnome.org>
11003 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
11004 non-static PropertyExpr, set its InstanceExpression. This makes
11005 the `ICollection.Count' property work in System/Array.cs.
11007 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
11009 * driver.cs: Made error handling more consistent. Errors now
11010 tracked by Report class, so many methods which used to return int
11011 now return void. Main() now prints success/failure and
11012 errors/warnings message.
11014 Renamed '--probe' compiler argument to '--expect-error'. Removed
11015 the magic number return values (123 and 124). Now, if the
11016 expected error occurs, the compiler exits with success (exit value
11017 0). If the compilation completes without seeing that particular
11018 error, the compiler exits with failure (exit value 1). The
11019 makefile in mcs/errors has been changed to handle the new behaviour.
11021 * report.cs: Made 'expected error' number a property and renamed
11022 it from 'Probe' to 'ExpectedError'.
11024 * genericparser.cs: Removed error handling support, since it is
11025 now all done by Report class.
11027 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
11028 class, so parse() no longer returns an int.
11030 * namespace.cs: Use Report.Error instead of GenericParser.error
11032 2002-06-22 Miguel de Icaza <miguel@ximian.com>
11034 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
11035 TypeContainer.AddOperator): At the front of the list put the
11036 explicit implementations, so they get resolved/defined first.
11038 2002-06-21 Miguel de Icaza <miguel@ximian.com>
11040 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
11041 interface type is implemented by this TypeContainer. Used during
11042 explicit interface implementation.
11044 (Property.Define, Indexer.Define, Method.Define): Validate that
11045 the given interface in the explicit implementation is one of the
11046 base classes for the containing type.
11048 Also if we are explicitly implementing an interface, but there is
11049 no match in the pending implementation table, report an error.
11051 (Property.Define): Only define the property if we are
11052 not explicitly implementing a property from an interface. Use the
11053 correct name also for those properties (the same CSC uses,
11054 although that is really not needed).
11056 (Property.Emit): Do not emit attributes for explicitly implemented
11057 properties, as there is no TypeBuilder.
11059 (Indexer.Emit): ditto.
11061 Hiding then means that we do not really *implement* a pending
11062 implementation, which makes code fail.
11064 2002-06-22 Martin Baulig <martin@gnome.org>
11066 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
11067 the return value of Object.GetType(). [FIXME: we need to do this whenever
11068 we get a type back from the reflection library].
11070 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
11072 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
11074 2002-06-20 Miguel de Icaza <miguel@ximian.com>
11076 * attribute.cs: Return null if we can not look up the type.
11078 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
11079 the interface types found.
11081 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
11082 interface types found.
11084 * typemanager.cs (GetInterfaces): Make this routine returns alll
11085 the interfaces and work around the lame differences between
11086 System.Type and System.Reflection.Emit.TypeBuilder in the results
11087 result for GetInterfaces.
11089 (ExpandInterfaces): Given an array of interface types, expand and
11090 eliminate repeated ocurrences of an interface. This expands in
11091 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
11094 2002-06-21 Martin Baulig <martin@gnome.org>
11096 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
11099 2002-06-21 Martin Baulig <martin@gnome.org>
11101 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
11102 and called with one of the core types, return the corresponding typebuilder for
11105 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
11108 2002-06-21 Martin Baulig <martin@gnome.org>
11110 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
11111 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
11112 (Expression.ConvertReferenceExplicit): Likewise.
11114 * expression.cs (ElementAccess.DoResolve): Likewise.
11115 (ElementAccess.DoResolveLValue): Likewise.
11117 2002-06-10 Martin Baulig <martin@gnome.org>
11119 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
11120 add the "value" parameter to the parameter list.
11122 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
11125 2002-06-19 Miguel de Icaza <miguel@ximian.com>
11127 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
11128 the argument to an int, uint, long or ulong, per the spec. Also
11129 catch negative constants in array creation.
11131 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
11133 * class.cs: do not allow the same interface to appear twice in
11134 the definition list.
11136 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
11138 * ecore.cs: don't use ldlen with System.Array.
11140 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
11142 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
11144 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
11146 * modifiers.cs: produce correct field attributes for protected
11147 internal. Easy fix so miguel can work on ther harder stuff:-)
11149 2002-06-18 Miguel de Icaza <miguel@ximian.com>
11151 * pending.cs: New file. Move the code from class.cs here.
11152 Support clearning the pending flag for all methods (when not doing
11153 explicit interface implementation).
11155 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
11157 * rootcontext.cs: added a couple more types needed to bootstrap.
11159 2002-06-17 Miguel de Icaza <miguel@ximian.com>
11161 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
11162 constructor in the type, instead of any constructor in the type
11163 hierarchy. Thanks to Paolo for finding this bug (it showed up as
11164 a bug in the Mono runtime when applying the params attribute).
11166 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11167 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
11169 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
11171 * expression.cs (Unary.ResolveOperator): Use TypeManager
11172 to resolve the type.
11174 2002-06-13 Ravi Pratap <ravi@ximian.com>
11176 * cs-parser.jay (enum_member_declaration): Pass in the attributes
11179 * enum.cs (AddEnumMember): Add support to store the attributes associated
11180 with each member too.
11182 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
11183 field builders too - this takes care of the enum member case.
11185 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
11187 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
11188 address-of operator on both value types and pointers.
11190 2002-06-10 Martin Baulig <martin@gnome.org>
11192 * interface.cs (Interface.PopulateIndexer): Add the indexer's
11193 PropertyBuilder to the `property_builders' list.
11195 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
11196 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
11197 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
11198 find any indexers which are inherited from an interface.
11200 2002-06-09 Martin Baulig <martin@gnome.org>
11202 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
11203 the same type as the constant if necessary. There's also a test-130.cs
11206 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
11208 * typemanager.cs (TypeManager.ChangeType): Previously known as
11209 Enum.ChangeEnumType().
11211 2002-06-09 Martin Baulig <martin@gnome.org>
11213 * expression.cs (Cast.TryReduce): Added support for consts.
11215 2002-06-08 Ravi Pratap <ravi@ximian.com>
11217 * class.cs (Accessor): Hold attributes information so we can pass
11220 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
11221 Modify to pass in attributes attached to the methods.
11223 (add_accessor_declaration, remove_accessor_declaration): Ditto.
11225 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
11226 to handle the Accessor kind :-)
11228 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
11230 2002-06-08 Martin Baulig <martin@gnome.org>
11232 * expression.cs (Unary.TryReduceNegative): Added support for
11235 2002-06-08 Martin Baulig <martin@gnome.org>
11237 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
11238 name can't be found in the `defined_names' - the caller will do a
11239 MemberLookup in this case and thus find methods in System.Enum
11240 such as Enum.IsDefined().
11242 2002-06-08 Martin Baulig <martin@gnome.org>
11244 * enum.cs (Enum.ChangeEnumType): This is a custom version of
11245 Convert.ChangeType() which works with TypeBuilder created types.
11246 (Enum.LookupEnumValue, Enum.Define): Use it here.
11248 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
11249 `TypeBuilder.BaseType != null' check.
11250 (TypeContainer.FindMembers): Only lookup parent members if we
11251 actually have a parent.
11252 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11253 (ConstructorInitializer.Resolve): Likewise.
11255 * interface.cs (Interface.FindMembers): Added
11256 `TypeBuilder.BaseType != null' check.
11258 * rootcontext.cs (RootContext.ResolveCore): Added
11259 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11260 classes_second_stage.
11262 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11263 debug_type and trace_type when compiling with --nostdlib.
11265 2002-06-07 Martin Baulig <martin@gnome.org>
11267 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11268 (AddField): Set it to true when adding a non-static field.
11269 (DefineType): Use `have_nonstatic_fields' to find out whether we
11270 have non-static fields, not `Fields != null'.
11272 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11274 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11275 dereferencing a null on the static-field code path)
11277 2002-05-30 Martin Baulig <martin@gnome.org>
11279 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11280 to take command line arguments. Use reflection to call the new
11281 custom `Initialize' function on the symbol writer and pass it the
11282 command line arguments.
11284 * driver.cs (--debug-args): New command line argument to pass command
11285 line arguments to the symbol writer.
11287 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11289 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11290 the target type for indexers and properties. Thanks to Joe for
11293 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11295 * typemanager.cs (MethodFlags): returns the method flags
11296 (Obsolete/ShouldIgnore) that control warning emission and whether
11297 the invocation should be made, or ignored.
11299 * expression.cs (Invocation.Emit): Remove previous hack, we should
11300 not do this on matching a base type, we should do this based on an attribute
11302 Only emit calls to System.Diagnostics.Debug and
11303 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11304 on the command line.
11306 * rootcontext.cs: Global settings for tracing and debugging.
11308 * cs-tokenizer.cs (define): New utility function to track
11309 defines. Set the global settings for TRACE and DEBUG if found.
11311 2002-05-25 Ravi Pratap <ravi@ximian.com>
11313 * interface.cs (Populate*): Pass in the TypeContainer as well as
11314 the DeclSpace as parameters so that we can create EmitContexts and
11315 then use that to apply attributes etc.
11317 (PopulateMethod, PopulateEvent, PopulateProperty)
11318 (PopulateIndexer): Apply attributes everywhere.
11320 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11323 (ApplyAttributes): Update accordingly.
11325 We now apply interface attributes for all members too.
11327 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11329 * class.cs (Indexer.Define); Correctly check if we are explicit
11330 implementation (instead of checking the Name for a ".", we
11331 directly look up if the InterfaceType was specified).
11333 Delay the creation of the PropertyBuilder.
11335 Only create the PropertyBuilder if we are not an explicit
11336 interface implementation. This means that explicit interface
11337 implementation members do not participate in regular function
11338 lookups, and hence fixes another major ambiguity problem in
11339 overload resolution (that was the visible effect).
11341 (DefineMethod): Return whether we are doing an interface
11344 * typemanager.cs: Temporary hack until we get attributes in
11345 interfaces (Ravi is working on that) and we get IndexerName
11346 support in interfaces.
11348 * interface.cs: Register the indexers as properties.
11350 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11351 warning, I have verified that this is a bug in the .NET runtime
11352 (JavaScript suffers of the same problem).
11354 * typemanager.cs (MemberLookup): When looking up members for
11355 interfaces, the parent of an interface is the implicit
11356 System.Object (so we succeed in searches of Object methods in an
11357 interface method invocation. Example: IEnumerable x; x.ToString
11360 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11362 * class.cs (Event): Events should also register if they do
11363 implement the methods that an interface requires.
11365 * typemanager.cs (MemberLookup); use the new GetInterfaces
11368 (GetInterfaces): The code used to lookup interfaces for a type is
11369 used in more than one place, factor it here.
11371 * driver.cs: Track the errors at the bottom of the file, we kept
11374 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11375 instance if the method we are calling is static!
11377 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11379 * attribute.cs (ApplyAttributes): Make this function filter out
11380 the IndexerName attribute (as that attribute in reality is never
11381 applied) and return the string constant for the IndexerName
11384 * class.cs (TypeContainer.Emit): Validate that all the indexers
11385 have the same IndexerName attribute, and if so, set the
11386 DefaultName attribute on the class.
11388 * typemanager.cs: The return value might contain other stuff (not
11389 only methods). For instance, consider a method with an "Item"
11390 property and an Item method.
11392 * class.cs: If there is a problem with the parameter types,
11395 2002-05-24 Ravi Pratap <ravi@ximian.com>
11397 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11398 looks at user defined conversion after making a call to
11399 StandardConversionExists - we need this for overload resolution.
11401 * expression.cs : Update accordingly the various method calls.
11403 This fixes 2 bugs filed against implicit user defined conversions
11405 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11407 * statement.cs: Track the result of the assignment.
11409 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11411 * expression.cs (MemberAccess): Improved error reporting for
11412 inaccessible members.
11414 2002-05-22 Martin Baulig <martin@gnome.org>
11416 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11417 itself with debugging support.
11419 2002-05-22 Martin Baulig <martin@gnome.org>
11421 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11422 Removed, this isn't needed anymore.
11424 2002-05-20 Martin Baulig <martin@gnome.org>
11426 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11427 be underlying type for an enum.
11429 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11431 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11432 that splits out the loading of just the core types.
11434 * rootcontext.cs (ResolveCore): Split the struct resolution in
11435 two, so we can load the enumeration underlying types before any
11438 * expression.cs (Is): Bandaid until we fix properly Switch (see
11439 bug #24985 for details).
11441 * typemanager.cs (ImplementsInterface): The hashtable will contain
11442 a null if there are no interfaces implemented.
11444 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11446 * cs-parser.jay (indexer_declarator): It is fine to have array
11449 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11451 * typemanager.cs: (RegisterBuilder): New function used to register
11452 TypeBuilders that implement interfaces. Since
11453 TypeBuilder.GetInterfaces (as usual) does not work with lame
11455 (AddUserType): register interfaces.
11457 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11458 dealing with TypeBuilder. Also, arrays are showing up as
11459 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11460 methods can not be invoked on them!
11462 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11463 (ImplicitReferenceConversionExists): Split out from
11464 StandardConversionExists.
11466 * expression.cs (As): We were only implementing one of the three
11467 cases for the as operator. We now implement them all.
11468 (Is): Implement the various other cases for Is as well.
11470 * typemanager.cs (CACHE): New define used to control if we want or
11471 not the FindMembers cache. Seems to have a negative impact on
11472 performance currently
11474 (MemberLookup): Nested types have full acess to
11475 enclosing type members
11477 Remove code that coped with instance/static returns for events, we
11478 now catch this in RealFindMembers.
11480 (RealFindMembers): only perform static lookup if the instance
11481 lookup did not return a type or an event.
11483 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11485 * assign.cs (CompoundAssign): We pass more semantic information
11486 now to Compound Assignments than we did before: now we have all
11487 the information at hand, and now we resolve the target *before* we
11488 do the expression expansion, which allows the "CacheValue" method
11489 to have the effect we intended (before, a [x] += 1 would generate
11490 two differen ArrayAccess expressions from the ElementAccess,
11491 during the resolution process).
11493 (CompoundAssign.DoResolve): Resolve target and original_source here.
11495 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11497 * expression.cs (ArrayAccess): dropped debugging information.
11499 * typemanager.cs: Small bug fix: I was always returning i_members,
11500 instead of one of i_members or s_members (depending on which had
11503 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11504 method is invoked before any code generation takes place, and it
11505 is a mechanism to inform that the expression will be invoked more
11506 than once, and that the method should use temporary values to
11507 avoid having side effects
11509 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11511 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11514 * expression.cs (Indirection, ArrayAccess): Add support for
11515 CacheTemporaries in these two bad boys.
11517 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11518 ldobj or ldind_ref.
11519 (StoreFromPtr): Handle stobj as well.
11521 * expression.cs (UnaryMutator): Share more code.
11523 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11524 down: I was not tracking the Filter function as well, which
11525 was affecting the results of the cache.
11527 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11529 * attribute.cs: Remove the hack to handle the CharSet property on
11532 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11534 * attribute.cs (DoResolve): More uglyness, we now only try to
11535 resolve the attribute partially, to extract the CharSet
11536 information (only if we are a StructLayout attribute). Otherwise
11538 (GetExtraTypeInfo): Add some code to conditionally kill in the
11539 future this. I am more and more convinced that the .NET
11540 framework has special code to handle the attribute setting on
11543 * expression.cs (IsParamsMethodApplicable): Revert my previous
11544 foreach change here, it was wrong.
11546 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11548 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11549 (pp_expr): do not abort on unknown input, just return.
11550 (eval): abort if there are pending chars.
11552 * attribute.cs (Attribute.Resolve): Positional parameters are
11553 optional. Deal with that case.
11555 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11556 the Ansi/Unicode/Auto information for the type.
11558 (TypeContainer.DefineType): instantiate the EmitContext here, as
11559 we will be using it during the type definition (to resolve
11560 attributes) and during the emit phase.
11562 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11563 to pull type information out of the attributes
11565 (Attribute.Resolve): track the constructor builder, and allow for
11566 multiple invocations (structs and classes will use this).
11568 * ecore.cs (MemberLookupFinal): new version with all the
11569 parameters customizable.
11571 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11572 constructors. Return if the result value is null (as the error
11573 would have been flagged already by MemberLookupFinal)
11575 Do not allow instances of abstract classes or interfaces to be
11578 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11579 We have to compare the assembly property here when dealing with
11580 FamANDAssem and Assembly access modifiers, because we might be
11581 creating an assembly from *modules* (that means that we are not
11582 getting TypeBuilders for types defined in other modules that are
11583 part of this assembly).
11585 (Method.Emit): If the method is marked abstract and has a body,
11588 (TypeContainer.DefineMembers): If both the defined member and the
11589 parent name match are methods, then do not emit any warnings: let
11590 the Method.Define routine take care of flagging warnings. But if
11591 there is a mismatch (method overrides something else, or method is
11592 overriwritten by something, then emit warning).
11594 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11595 set to null, this means `do not check for the return type on the
11598 (Method.Define): set the return type for the method signature to
11599 null, so that we get methods with the same name and parameters and
11600 different return types. This is used to flag warning 114 (you are
11601 hiding a method, and you probably want to use the new/override
11604 * typemanager.cs (MemberLookup): Implemented proper access
11605 control, closing a long standing set of bug reports. The problem
11606 was that the Framework only has two bits: Public and NonPublic,
11607 and NonPublic includes private and protected methods, but we need
11608 to enforce the FamANDAssem, FamOrAssem and Family.
11610 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11612 * statement.cs (GotoCase): Return true: Ammounts to giving up
11613 knowledge on whether we return or not, and letting the other case
11614 be responsible for it.
11616 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11618 * driver.cs: Do not load directories for each file processed, only
11619 do it if there is a pattern.
11621 * ecore.cs: Report readonly assigns here as well, as we might have
11622 been resolved only by MemberAccess.
11624 (SimpleName.SimpleNameResolve): Also be useful for LValue
11625 resolution. We need this to propagate assign to local readonly variables
11627 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11628 do not want to reuse potential criteria memory.
11630 * class.cs (MyEventBuilder): Set reflected_type;
11632 * ecore.cs (Constantify): Added support for constifying bools.
11634 (RootContext.LookupType): Added a cache for values looked up in
11635 the declaration space.
11637 * typemanager.cs (FindMembers): Now is a front-end to
11638 RealFindMembers, and provides a two-level hashtable-based cache to
11641 15% performance improvement: from 22.5 to 19.2 seconds.
11643 * expression.cs (IsParamsMethodApplicable): use foreach.
11644 (Invocation.DoResolve): ditto.
11645 (New.DoResolve): ditto.
11646 (ArrayCreation.DoResolve): ditto.
11648 * ecore.cs (FindMostEncompassingType): use foreach.
11650 * delegate.cs (NewDelegate.DoResolve): Use foreach
11652 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11653 (RemoveMethods): use foreach.
11655 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11656 nested foreach statements instead of for, and also break out of
11657 the inner loop once a match is found.
11659 (Invocation.OverloadResolve): Use foreach, simplify the code.
11661 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11663 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11664 we actually unwrap the expression to allow for extra information
11667 * expression.cs: Use Shr_Un on unsigned operations.
11669 2002-05-08 Ravi Pratap <ravi@ximian.com>
11671 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11672 applicable operators was not being considered correctly. This closes
11673 the bug Miguel reported.
11675 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11677 * attribute.cs: check that the type derives from System.Attribute
11678 and report the correct error in that case (moved the duplicate code to
11679 its own method, too).
11681 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11683 * attribute.cs: lookup attribute type name as the spec says: first the
11684 bare attribute name and then name + "Attribute" (nant compiles with
11685 mcs after this fix).
11687 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11689 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11690 Because of the way we parse things, we should try to see if a
11691 UIntConstant can fit in an integer.
11693 2002-05-07 Ravi Pratap <ravi@ximian.com>
11695 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11696 when we are in an explicit context.
11698 (ConvertReferenceExplicit): When converting from Iface type S to Class
11699 T make sure the rules are implemented as an OR.
11701 * parameter.cs (ParameterType): Make it a property for now although the
11702 purpose really isn't anything immediate.
11704 * expression.cs (Is*Applicable): Do better checking on the parameter type
11705 of a ref/out parameter. The ones from the system assemblies are already
11706 marked with the correct type so we don't need to do any correction.
11708 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11709 the object type is standard too so include that.
11711 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11713 * ecore.cs (StandardConversionExists): Augment with missing code:
11714 deal with IntConstant, LongConstants and Enumerations.
11716 * assign.cs: Report the error, instead of failing silently
11718 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11719 typecontainer that they are declared, because the
11720 typecontainer/namespace will have the list of using clauses that
11721 need to be applied.
11723 Assembly Attributes were escaping the normal registration
11726 (EmitCode): Apply attributes within an EmitContext that represents
11727 the container they were declared on.
11729 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11731 2002-05-06 Ravi Pratap <ravi@ximian.com>
11733 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11734 Revamp completely - make much cleaner as we now operate only
11737 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11738 to implement the logic detailed in the spec more correctly.
11740 (UserDefinedConversion): Update accordingly.
11742 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11744 * statement.cs: Return flow analysis information up.
11746 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11749 (token): Do not consume an extra character before calling
11752 2002-05-06 Piers Haken <piersh@friskit.com>
11754 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11756 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11758 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11759 EmitContext during the instance constructor initializer
11760 resolution, to stop access to instance variables.
11762 This is mandated by the spec, last paragraph of the `constructor
11763 initializers' section.
11765 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11767 * cs-parser.jay, class.cs (Accessor): new class used to represent
11768 an accessor (get or set). In the past we used `null' to represent
11769 a missing accessor. But this is ambiguous because there was no
11770 way to tell in abstract indexers/properties if one of them was
11773 Now there is a way of addressing that.
11775 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11776 instead of FindMembers.
11778 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11779 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
11781 * attribute.cs: Treat indexers and properties as the same in terms
11782 of applying attributes
11784 * ecore.cs (FindMostEncompassedType): Use statically initialized
11785 EmptyExpressions()s like we do elsewhere to avoid creating useless
11786 objects (and we take this out of the tight loop).
11788 (GetConversionOperators): Move the code to extract the actual
11789 operators to a separate routine to clean things up.
11791 2002-05-04 Miguel de Icaza <miguel@ximian.com>
11793 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
11794 events are always registered FieldBuilders.
11796 * class.cs (FieldBase): New class shared by Fields
11798 * delegate.cs: If we are a toplevel delegate, use our full name.
11799 If we are a nested delegate, then only use our tail name.
11801 2002-05-02 Ravi Pratap <ravi@ximian.com>
11803 * expression.cs (IsApplicable): Ensure that we add the "&" to
11804 ref/out types before comparing it with the type of the argument.
11806 (IsParamsMethodApplicable): Ditto.
11808 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
11811 * delegate.cs : Handle the case when we have more than one applicable
11812 method. Flag an error only when we finish checking all.
11814 2002-05-02 Miguel de Icaza <miguel@ximian.com>
11816 * expression.cs: Add support for boolean static initializers.
11818 2002-05-01 Miguel de Icaza <miguel@ximian.com>
11820 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
11822 * parameter.cs (ComputeParameterTypes,
11823 ComputeAndDefineParameterTypes): Better error handling: now we
11824 clear the `types' cache if we fail during any of the type lookups.
11825 We also return the status code correctly to our caller
11827 * delegate.cs: If we fail to define a delegate, abort the extra
11830 * expression.cs (Binary.ResolveOperator): for
11831 operator==(object,object) and operator !=(object, object) we also
11832 have to verify that there is an implicit conversion from one to
11835 (ArrayAccess.DoResolve): Array Access can operate on
11838 2002-04-30 Miguel de Icaza <miguel@ximian.com>
11840 * assign.cs (CompoundAssign): A new class used as a "flag" that
11841 the assignment actually is happening as part of a compound
11842 assignment operator.
11844 During compound assignment, a few new rules exist to enable things
11851 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
11852 to the type of x) if y is implicitly convertible to the type of x,
11853 and the operator is a builtin operator and the return type of the
11854 operator is explicitly convertible to the type of x.
11856 * rootcontext.cs: Reset warning level to 2. 4 catches various
11857 "interesting" features in mcs, we must clean this up at some
11858 point, but currently am trying to kill other bugs ;-)
11860 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
11861 in container classes as well.
11863 * expression.cs (Binary.ResolveOperator): Handle string case
11864 before anything else (as operator overloading does emit an error
11865 before doing anything else).
11867 This code could go away when we move to a table driven model, but
11868 i could not come up with a good plan last night.
11870 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
11872 * typemanager.cs (CSharpName): reimplementation using regex.
11873 * class.cs: added null check for fields in Emit
11874 * rootcontext.cs: set warninglevel to 4
11876 2002-04-29 Miguel de Icaza <miguel@ximian.com>
11878 * typemanager.cs (CSharpName): reimplemented with Lupus
11881 2002-04-28 Miguel de Icaza <miguel@ximian.com>
11883 * statement.cs (If): correclty implement Resolve, because we were
11884 not catching sem errors in there. The same process is needed
11886 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
11889 (Statement.Warning_DeadCodeFound): Factorize code.
11890 (While): Report dead code here too.
11892 (Statement): Added Resolve virtual method to allow
11893 for resolution split from the emit code.
11895 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11897 * statement.cs (EmitBoolExpression): No longer try to resolve the
11899 (MakeBoolean): New utility function that resolve, implicitly
11900 converts to boolean and tags the expression.
11903 (If, Do): Implement dead code elimination.
11904 (While): Implement loop inversion
11906 (Do, While, For, If): Resolve the expression prior to calling our
11909 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
11912 - added method Report28 (warning: program has more than one entry point)
11913 - added method IsEntryPoint, implements paragraph 10.1 of the spec
11914 - modified method Method.Define, the part at the end of the method
11916 * rootcontext.cs: added static public Location EntryPointLocation;
11918 * ../errors/cs0028.cs : Add test case for the above warning.
11921 - modified method CSharpName to allow arrays of primitive type to
11922 be printed nicely (e.g. instead of System.Int32[][] it now prints
11924 - added method CSharpSignature: returns the signature of a method
11925 in string format to be used in reporting errors, warnings, etc.
11927 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
11930 2002-04-26 Ravi Pratap <ravi@ximian.com>
11932 * delegate.cs (Define): Fix extremely silly bug where I was
11933 setting the type of the 'object' parameter of the BeginInvoke
11934 method to System.IAsyncResult instead of System.Object ;-)
11936 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11938 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
11941 (Constructor.Emit): return if we fail to initialize the
11942 constructor. Another door closed!
11944 * expression.cs (New.DoResolve): Improve error message (from -6 to
11945 1501). Use DeclaredOnly lookup to find the exact constructor.
11947 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
11948 loop. This is useful.
11950 * cs-parser.jay: Adjust the default parameters so that destructors
11951 have the proper signature.
11953 2002-04-26 Martin Baulig <martin@gnome.org>
11955 * driver.cs (LoadAssembly): If `assembly' contains any characters
11956 which are only valid in path names and not in assembly names
11957 (currently slash, backslash and point), use Assembly.LoadFrom ()
11958 instead of Assembly.Load () on the `assembly' (before iteration
11959 over the link_paths).
11961 2002-04-26 Martin Baulig <martin@gnome.org>
11963 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
11965 2002-04-25 Miguel de Icaza <miguel@ximian.com>
11967 * class.cs (Property): use the new typemanager.MemberLookup
11969 (TypeContainer.MemberLookup): Implement using the
11970 TypeManager.MemberLookup now.
11972 * typemanager.cs: Make MemberLookup a function of the TypeManager,
11973 and return MemberInfos, so that these can be used without an
11974 EmitContext (what we had before).
11976 2002-04-24 Miguel de Icaza <miguel@ximian.com>
11978 * expression.cs: Fix the case where the argument to params if the
11979 type of the params. I omitted handling this before. Fixed
11981 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11983 * driver.cs: Call BootCorlib_PopulateCoreType
11985 * class.cs (Property.CheckBase): Check for properties only, not
11988 * interface.cs: Temporary hack: try/catch around the
11989 CustomAttributeBuilder, because I am getting an exception that I
11992 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
11993 types whose definitions are required to be there (attributes are
11994 defined before standard types).
11996 Compute definitions as we boot the various types, as they are used
11997 immediately (value_type class will need object_type, but if we do
11998 not initialize object_type, we will pass a null, which will let
11999 the runtime pick the System.Object from the existing corlib, which
12000 is not what we want).
12002 2002-04-22 Patrik Torstensson <totte@labs2.com>
12004 * cs-tokenizer.cs: fixed a number of trim() issues.
12006 2002-04-22 Ravi Pratap <ravi@ximian.com>
12008 * expression.cs (Argument.Type): Ensure that we return the correct
12009 type when we have out or ref parameters [in which case we
12012 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12014 * class.cs (Property, Indexer): Allow extern modifier in there.
12016 * typemanager.cs (InitBaseTypes): Initializes object_type and
12017 value_type, since those will be used early on during the bootstrap
12018 process to compile corlib.
12020 (InitCoreTypes): Move code from here to InitBaseTypes.
12022 2002-04-21 Miguel de Icaza <miguel@ximian.com>
12024 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
12025 single-dimension arrays as using the ldlen opcode.
12027 Daniel Lewis discovered this optimization.
12029 * typemanager.cs: Add signature for System.Array::get_Length
12031 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12033 * statement.cs: report the error when the foreach does not apply to an
12034 array nor a collection.
12036 2002-04-19 Miguel de Icaza <miguel@ximian.com>
12038 * expression.cs: Add implicit conversions to the operator ~.
12040 * constant.cs (DecimalConstant.Emit): Emit decimal value.
12042 * typemanager.cs: Locate the decimal constructor.
12044 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12046 * attribute.cs: use the new property of TypeOf.
12047 * expression.cs: added 'get' property around typearg.
12049 These changes fix a build breaker reported by NickD. Is this the
12050 correct way to fix? If not, please, revert my changes and make it
12053 2002-04-17 Miguel de Icaza <miguel@ximian.com>
12055 * attribute.cs: Add support for typeof in attribute invocations.
12056 I am not sure that this is right though.
12058 2002-04-14 Duncan Mak <duncan@ximian.com>
12060 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
12061 Binary.Operator.Division case.
12063 2002-04-13 Ravi Pratap <ravi@ximian.com>
12065 * class.cs (DefineType): Ensure that we do a proper check on
12066 attribute types and also register it with the TypeManager.
12068 (TypeContainer.Targets): The default for attribute types is
12069 AttributeTargets.All.
12071 * attribute.cs (ApplyAttributes): Registering the attribute type
12072 is done elsewhere, not when we discover we have a Usage attribute.
12074 2002-04-12 Ravi Pratap <ravi@ximian.com>
12076 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
12077 and get rid of is_delegate parameter.
12079 * everywhere : update.
12081 2002-04-12 Ravi Pratap <ravi@ximian.com>
12083 * cs-parser.jay (compilation_unit): Revamp completely to use
12084 some new ideas that I got from Rhys' grammar to solve the problems
12085 with assembly level attributes.
12087 (outer_declaration): New grammar production.
12089 (attribute_sections): Add.
12091 (opt_attributes): Base on attribute_sections
12093 (namespace_declaration): Allow opt_attributes to tackle the case
12094 when we have assembly level attributes - we are clever in this
12097 * attribute.cs (ApplyAttributes): Do not worry about assembly
12098 attributes in the non-global context.
12100 * rootcontext.cs (AddGlobalAttributes): Go back to using this
12101 instead of SetGlobalAttributes.
12103 * class.cs, rootcontext.cs : Ensure we define and generate
12104 attribute types before anything else.
12106 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
12107 and flag the new error -20 for the case when the attribute type
12108 does not have valid targets specified. csc does not catch this.
12110 * ../errors/errors.txt : update for error # -20
12112 2002-04-11 Ravi Pratap <ravi@ximian.com>
12114 * support.cs (InternalParameters.ParameterModifier): Do some null
12115 checking and return sane values.
12117 * class.cs (Method.Define): If we are a PInvoke method, ensure
12118 that we are static and extern. Report error # 601
12120 * ../errors/cs0601.cs : Add test case for the above error.
12122 2002-04-07 Ravi Pratap <ravi@ximian.com>
12124 * rootcontext.cs (attribute_types): We need to keep type of
12125 all attribute types separately and emit code for them first.
12127 (RegisterAttribute) : Implement.
12129 * class.cs (DefineType): Check if the current Type is a custom
12130 attribute type and register it accordingly.
12132 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
12133 adding the first attribute twice and rename to
12135 (SetGlobalAttributes): this.
12137 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
12140 * attribute.cs (ApplyAttributes): Take an additional argument telling us
12141 if we are processing global arguments. Hmm, I am unsure of this.
12143 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12145 * expression.cs: added static array of strings to avoid calling
12146 Enum.ToString () for Operator in Binary. Significant recover of
12149 2002-04-10 Miguel de Icaza <miguel@ximian.com>
12151 * class.cs (FindMembers): Allow the Builders of the various
12152 members to be null. If they are skip them. This only happens
12153 during the PInvoke declaration.
12155 2002-04-09 Miguel de Icaza <miguel@ximian.com>
12157 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
12158 failure, so we do not keep going afterwards.
12160 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
12161 wanted to pass `false' as the `is_delegate' argument. If this is
12162 the case, why not use delegate_type == null to mean `is_delegate =
12163 false' and anything else as is_delegate = true.
12165 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
12167 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
12168 code for the section, not the beginning of the tests.
12170 2002-04-08 Miguel de Icaza <miguel@ximian.com>
12172 * cfold.cs: Handle operator + (Enum x, Underlying x)
12174 * expression.cs (Binary): same. Warn about errors where we have
12175 Enum/Enum in operator + as well.
12177 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
12180 - added support for switch(bool)
12181 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
12182 - add TableSwitchEmit() to handle table-based switch statements
12184 2002-04-05 Ravi Pratap <ravi@ximian.com>
12186 * expression.cs (Invocation.OverloadResolve): Factor out code which
12187 does parameter compatibility checking with arguments so that we can
12188 re-use the code even from Delegate.VerifyApplicability
12190 (VerifyArgumentsCompat): Move above code here.
12192 * delegate.cs (VerifyApplicability): Get rid of duplicate code
12193 and instead make a call to the above method.
12195 2002-03-31 Ravi Pratap <ravi@ximian.com>
12197 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
12198 We use it to keep track of classes which are attribute types.
12200 2002-04-02 Miguel de Icaza <miguel@ximian.com>
12202 * delegate.cs (Delegate.Define): Correctly define the types in the
12203 presence of fixed and array parameters.
12205 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
12208 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
12209 include NonPublic after the first iteration.
12211 * class.cs (Indexer.CheckBase): Only check if both parents are
12214 * cs-parser.jay (accessor_body): If empty, set to null.
12216 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
12217 same code path here to resolve constants names that we did have in
12218 MemberAccess.DoResolve. There is too much code duplicated here.
12220 2002-04-01 Miguel de Icaza <miguel@ximian.com>
12222 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
12224 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
12227 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
12228 tokens, numbers and strings.
12230 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
12233 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
12234 asyncronous parameters and the regular parameters.
12236 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
12237 specify the target directory.
12239 * expression.cs: (This.DoResolve): Simplify
12240 (As.Emit): Optimize, do not generate IsInst if the expression is
12241 always of the given type.
12243 (Is.DoResolve): Bug fix, we were reporting both always/never for
12246 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
12247 creating too many unnecessary arrays.
12249 2002-03-31 Miguel de Icaza <miguel@ximian.com>
12251 * class.cs (EmitFieldInitializer): Use Assign expression to assign
12252 fields instead of rolling our own initializer. Takes care of all
12253 implicit conversions, and drops unnecessary static checks/argument.
12255 2002-03-31 Dick Porter <dick@ximian.com>
12257 * driver.cs: use the GetDirectories() return values properly, and
12258 use "/" as path separator.
12260 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12262 * expression.cs (Unary): Optimize - - expr into expr.
12263 (Binary): Optimize a + (-b) into a -b.
12265 * codegen.cs (CodeGen): Made all methods static.
12267 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12271 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12272 TypeBuilder property.
12274 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12277 * tree.cs: Removed the various RecordXXXX, and replaced with a
12278 single RecordDecl. Removed all the accessor methods, and just
12279 left a single access point Type
12281 * enum.cs: Rename DefineEnum to DefineType.
12283 * decl.cs: New abstract method `DefineType' used to unify the
12284 Defines for Enumerations, Interfaces, TypeContainers and
12287 (FindType): Moved LookupInterfaceOrClass here. Moved the
12288 LookupBaseClasses method that used to live in class.cs and
12289 interface.cs here, and renamed to FindType.
12291 * delegate.cs: Implement DefineType. Take advantage of the
12292 refactored pattern for locating the parent builder without taking
12293 the parent_builder argument (which we know does not work if we are
12294 nested, and triggering a toplevel definition).
12296 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12298 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12299 accessibility of a member has changed during override and report
12302 * class.cs (Method.Define, Property.Define): Only complain on
12303 overrides if the method is private, any other accessibility is
12304 fine (and since we just checked the permission is the same, we are
12307 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12308 and elif are processed always. The other pre-processing
12309 directives are only processed if we are "taking" the path
12311 2002-03-29 Martin Baulig <martin@gnome.org>
12313 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12314 current location is not Null.
12316 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12317 a separate method so we can profile it.
12319 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12320 `span.Seconds' are just seconds, but no minutes or hours.
12321 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12323 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12325 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12326 Remove the gratuitous set of Final:
12328 // If an interface implementation, then we can set Final.
12329 if (((flags & MethodAttributes.Abstract) == 0) &&
12330 implementing.DeclaringType.IsInterface)
12331 flags |= MethodAttributes.Final;
12333 I do not know what I was smoking when I used that.
12336 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12337 step into fixing the name resolution issues for delegates and
12338 unifying the toplevel name resolution.
12340 2002-03-28 Martin Baulig <martin@gnome.org>
12342 * class.cs (Method.Emit): If we have a symbol writer, call its
12343 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12344 tell it about the current method.
12346 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12347 writer that we're going to emit the first byte of IL code for a new
12348 statement (a new source line).
12349 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12350 EmitContext.Mark() before emitting any code.
12352 * location.cs (SymbolDocument): Return null when we're Null.
12354 * statement.cs (Statement): Moved the `Location loc' variable here.
12355 (Statement.EmitBoolExpression): If we have a symbol writer, call
12356 ec.Mark() before emitting any code to tell it that we're at the
12357 beginning of a new statement.
12358 (StatementExpression): Added `Location' argument to the constructor.
12359 (Block): Added public readonly variable `StartLocation' and public
12360 variable `EndLocation'. The latter is to be set using SetEndLocation().
12361 (Block): Added constructor which takes a start and end location.
12362 (Block.SetEndLocation): New method. This sets the end location.
12363 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12364 local variables we create.
12365 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12366 each statement and do also mark the begin and end of the block.
12368 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12369 tell it the current lexer.Location, use Location.Null for the end of the
12371 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12372 current block, set its end location using SetEndLocation().
12373 (statement_expression): StatementExpression constructor now takes the
12374 lexer.Location as additional argument.
12375 (for_statement, declare_local_variables): Likewise.
12376 (declare_local_variables): When creating a new implicit block, use the
12377 new Block constructor and pass it the lexer.Location.
12379 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12381 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12382 members also on the parent interfaces recursively.
12384 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12386 * report.cs: Use new formats, since Gonzalo finished the missing
12389 * expression.cs (Binary.ResolveOperator): added missing operator|
12390 operator& and operator^ for bool/bool.
12392 * cs-parser.jay: CheckDef now takes a Location argument that is
12393 used to report errors more precisly (instead of reporting the end
12394 of a definition, we try to track something which is a lot closer
12395 to the source of the problem).
12397 * cs-tokenizer.cs: Track global token use, so we can properly flag
12398 the use of #define/#undef after the first token has been seen.
12400 Also, rename the reportXXXX to Error_DescriptiveName
12402 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12403 TypeContainer, so that Enum and Interface can use this too.
12405 * class.cs (TypeContainer.LookupInterfaceOrClass,
12406 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12407 `builder' argument. Typically this was used to pass the parent
12408 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12411 The problem is that a nested class could trigger the definition of
12412 a toplevel class, and the builder would be obviously wrong in that
12415 So we drop this argument, and we compute dynamically the
12416 TypeBuilder/ModuleBuilder (the correct information was available
12417 to us anyways from DeclSpace.Parent)
12419 * interface.cs (Interface.DefineInterface): Drop builder
12420 parameter cleanup like class.cs
12422 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12425 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12428 (Try.Emit): Propagate the returns value from the statement.
12430 (Return.Emit): Even if we are leavning
12432 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12434 * modifiers.cs: Fix the computation of MethodAttributes flags.
12436 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12438 * driver.cs: allow compilation of files that start with '/'.
12439 Add a default case when checking the argument of --target.
12441 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12443 * interface.cs: Implement the same search algorithm for types in
12444 the interface code.
12446 * delegate.cs: Do not allow multiple definition.
12448 * Recovered ChangeLog that got accidentally amputated
12450 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12452 * rootcontext.cs: Load manually enum to allow core classes to
12453 contain enumerations.
12455 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12456 Update to new static methods in TypeManager.
12458 * typemanager.cs (GetMethod, GetConstructor): Use our
12459 implementation of FindMembers to find the members, since during
12460 corlib compilation, the types are TypeBuilders and GetMethod and
12461 GetConstructor do not work.
12463 Make all methods in TypeManager static.
12465 (InitCodeHelpers): Split the functionality from
12466 the InitCodeTypes function.
12468 * driver.cs: Call InitCodeHelpers after we have populated the
12471 * cs-parser.jay (delegate_declaration): we did not used to compute
12472 the delegate name correctly for void delegates.
12474 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12476 * rootcontext.cs (RootContext): Init the interface_resolve_order
12477 and type_container_resolve_order always.
12479 (ResolveCore, BootstrapCorlib_ResolveClass,
12480 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12481 compiler when compiling with --nostdlib
12483 * class.cs (TypeContainer.DefineType): Check that our parent is
12484 not null. This test is most important when we are bootstraping
12487 * codegen.cs: Split out the symbol writing code.
12489 2002-03-25 Martin Baulig <martin@gnome.org>
12491 * driver.cs (-g): Made -g an alias for --debug.
12493 2002-03-24 Martin Baulig <martin@gnome.org>
12495 * codegen.cs (SymbolWriter): New public variable. Returns the
12496 current symbol writer.
12497 (CodeGen): Added `bool want_debugging_support' argument to the
12498 constructor. If true, tell the ModuleBuild that we want debugging
12499 support and ask it for the ISymbolWriter.
12500 (Save): If we have a symbol writer, call it's Close() method after
12501 saving the assembly.
12503 * driver.c (--debug): New command line argument to create a
12504 debugger information file.
12506 * location.cs (SymbolDocument): New public property. Returns an
12507 ISymbolDocumentWriter object for the current source file or null
12508 if we don't have a symbol writer.
12510 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12512 * driver.cs (LoadAssembly): Correctly return when all the paths
12513 have been tried and not before.
12515 * statement.cs (Switch.Emit): return the actual coverage for this
12516 statement (returns/not-returns)
12518 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12519 switch of the statement if we are the last switch section. That
12520 kills two problems: try/catch problems (we used to emit an empty
12521 nop at the end) and switch statements where all branches would
12524 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12526 * driver.cs: Add default assemblies (the equivalent to the
12527 Microsoft CSC.RSP file)
12529 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12530 also update tokens_seen and set it to false.
12532 * driver.cs: Implement --recurse for Mike.
12534 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12535 correctly splitting out the paths.
12537 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12539 * interface.cs (Interface.PopulateProperty): Instead of using
12540 `parent' as the declaration space for the set parameters, use
12543 * support.cs (InternalParameters): InternalParameters constructor
12544 takes a DeclSpace instead of a TypeContainer.
12546 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12547 types are being initialized, load the address of it before calling
12550 (New): Provide a mechanism to disable the generation of local
12551 value type temporaries when the caller will be providing us with
12552 an address to store it.
12554 (ArrayCreation.EmitDynamicInitializers): Use it.
12556 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12558 * expression.cs (Invocation.EmitArguments): Only probe for array
12559 property if there is more than one argument. Sorry about that.
12561 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12562 empty param arrays.
12564 * class.cs (Method.LabelParameters): Fix incorrect code path that
12565 prevented the `ParamArrayAttribute' from being applied to the
12568 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12570 * support.cs (ReflectionParameters): Correctly compute whether the
12571 last argument is a params array. Fixes the problem with
12574 * typemanager.cs: Make the assemblies array always be non-null
12575 (empty, but non-null)
12577 * tree.cs (RecordDecl): New function that abstracts the recording
12578 of names. This reports error 101, and provides a pointer to the
12579 previous declaration. Fixes a crash in the compiler.
12581 * cs-parser.jay (constructor_declaration): Update to new grammar,
12582 and provide a constructor_body that can be empty.
12584 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12586 * driver.cs: Add support for --resources.
12588 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12589 Make all types for the various array helper methods be integer.
12591 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12592 CheckState to ConvCast.
12594 (ConvCast): Now it takes a `checked' state argument, to avoid
12595 depending on the emit context for the conversion, and just using
12596 the resolve time setting.
12598 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12599 instead of Invocation.EmitArguments. We do not emit the original
12600 arguments, instead we emit those which have been converted to
12601 unsigned int expressions.
12603 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12605 * codegen.cs: ditto.
12607 * expression.cs (LocalVariableReference): Drop the use of the
12608 Store function that depended on the variable index.
12610 * statement.cs (VariableInfo): Drop the `Idx' property from this
12611 class, as this is not taking into account the indexes for
12612 temporaries tat we generate during the execution, getting the
12615 * class.cs: First emit class initializers, then call the parent
12618 * expression.cs (Binary): Fix opcode emision.
12619 (UnaryMutator.EmitCode): Support checked code generation
12621 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12622 matches for events for both the Static and Instance scans,
12623 pointing to the same element. Fix that.
12625 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12627 * rootcontext.cs (ResolveTree): Always set the
12628 interface_resolve_order, because nested interfaces will be calling
12631 * class.cs (GetInterfaceOrClass): Track the same resolution
12632 process used by TypeManager.LookupType. This fixes the nested
12633 type lookups in class declarations (separate path from
12636 (TypeContainer.DefineType): Also define nested interfaces.
12637 (TypeContainer.RegisterOrder): New public function used to
12638 register the order in which child interfaces need to be closed.
12640 Nested interfaces need to be closed after their parents have been
12643 * interface.cs (InterfaceAttr): Put all the logic for computing
12644 the interface attribute here.
12646 (DefineInterface): Register our interface order with the
12647 RootContext or with the TypeContainer depending on the case.
12649 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12651 * cs-parser.jay: rework foreach statement to work with the new
12652 changes to the policy on SimpleNames.
12654 * report.cs: support Stacktrace on warnings as well.
12656 * makefile: drop --unsafe and /unsafe from the compile.
12658 2002-03-13 Ravi Pratap <ravi@ximian.com>
12660 * ecore.cs (StandardConversionExists): Modify to take an Expression
12661 as the first parameter. Ensure we do null -> reference type conversion
12664 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12665 temporary Expression objects.
12667 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12669 * interface.cs: workaround bug in method overloading resolution
12670 (there is already a bugzilla bug for it).
12672 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12674 We could also solve this problem by having a separate path for
12675 performing type lookups, instead of DoResolve, we could have a
12676 ResolveType entry point, and only participating pieces of the
12677 production (simplename, deref, array) would implement this.
12679 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12680 signal SimpleName to only resolve type names and not attempt to
12681 resolve anything else.
12683 * expression.cs (Cast): Set the flag.
12685 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12687 * class.cs: Only report 108 if there is no `new' modifier.
12689 * cs-parser.jay: rework foreach statement to work with the new
12690 changes to the policy on SimpleNames.
12692 * report.cs: support Stacktrace on warnings as well.
12694 * makefile: drop --unsafe and /unsafe from the compile.
12696 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12698 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12699 lookups here, instead of doing that at parse time. This means
12700 that our grammar will not introduce `LocalVariableReferences' as
12701 expressions at this point. That solves the problem of code like
12705 static void Main ()
12709 This is only half the fix. The full fix requires parameters to
12710 also be handled in this way.
12712 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12713 makes the use more obvious of the DeclSpace. The
12714 ec.TypeContainer.TypeBuilder is now only used to pull the
12715 TypeBuilder for it.
12717 My theory is that I can get rid of the TypeBuilder completely from
12718 the EmitContext, and have typecasts where it is used (from
12719 DeclSpace to where it matters).
12721 The only pending problem is that the code that implements Aliases
12722 is on TypeContainer, and probably should go in DeclSpace.
12724 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12725 lookups here, instead of doing that at parse time. This means
12726 that our grammar will not introduce `LocalVariableReferences' as
12727 expressions at this point. That solves the problem of code like
12731 static void Main ()
12735 This is only half the fix. The full fix requires parameters to
12736 also be handled in this way.
12738 * class.cs (Property.DefineMethod): When implementing an interface
12739 method, set newslot, when implementing an abstract method, do not
12740 set the flag (before we tried never setting it, or always setting
12741 it, which is the difference).
12742 (Indexer.DefineMethod): same.
12743 (Method.DefineMethod): same.
12745 * ecore.cs: Only set the status used flag if we get back a Field.
12747 * attribute.cs: Temporary hack, so Paolo can keep working.
12749 2002-03-08 Ravi Pratap <ravi@ximian.com>
12751 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12752 the unmanaged type in the case we have a MarshalAs attribute.
12754 (Resolve): Handle the case when we are parsing the special MarshalAs
12755 attribute [we need to store the unmanaged type to use later]
12757 * typemanager.cs (marshal_as_attr_type): Built in type for the
12758 MarshalAs Attribute.
12760 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12761 on parameters and accordingly set the marshalling info.
12763 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12765 * class.cs: Optimizing slightly by removing redundant code after
12766 we switched to the `NoTypes' return value.
12767 (Property.DefineMethod): use NoTypes here too.
12769 This fixes the bug I introduced in my last batch of changes.
12771 2002-03-05 Ravi Pratap <ravi@ximian.com>
12773 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12775 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12776 Enums since those are types too.
12778 * cs-parser.jay (enum_declaration): Record enums as we parse them.
12780 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
12781 thanks to a call during the lookup process.
12783 2002-03-07 Miguel de Icaza <miguel@ximian.com>
12785 * statement.cs (Foreach): Lots of work to accomodate a particular
12786 kind of foreach statement that I had not kept in mind. It is
12787 possible to have foreachs on classes that provide a GetEnumerator
12788 method that return objects that implement the "pattern" for using
12789 a foreach, there is no need to support GetEnumerator
12792 This is needed to compile nant.
12794 * decl.cs: Only report 114 if the member is not `Finalize' and if
12795 the warning level is at least 2.
12797 * class.cs: Moved the compare function from Method to
12800 (MethodSignature.InheritableMemberSignatureCompare): Add new
12801 filter function that is used to extract inheritable methods from a
12804 (Method.Define): Use the new `inheritable_method_signature_filter'
12807 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
12810 2002-03-06 Miguel de Icaza <miguel@ximian.com>
12812 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
12814 * cs-parser.jay: Add opt_semicolon to the interface declaration.
12816 * expression.cs: Pass location information to
12817 ConvertImplicitStandard.
12819 * class.cs: Added debugging code to track return values from
12822 2002-03-05 Miguel de Icaza <miguel@ximian.com>
12824 * expression.cs (Is.DoResolve): If either side of the `is' is an
12825 interface, do not flag the warning.
12827 * ecore.cs (ImplicitReferenceConversion): We need a separate test
12830 * report.cs: Allow for --fatal to be used with --probe.
12832 * typemanager.cs (NoTypes): Move the definition for the empty Type
12835 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
12837 (TypeContainer.DefineProxy): New function used to proxy to parent
12838 implementations when implementing interfaces.
12839 (TypeContainer.ParentImplements): used to lookup if our parent
12840 implements a public function that is required by an interface.
12841 (TypeContainer.VerifyPendingMethods): Hook this up.
12843 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
12844 `modules' and `assemblies' arraylists into arrays. We only grow
12845 these are the very early start up of the program, so this improves
12846 the speedof LookupType (nicely measured).
12848 * expression.cs (MakeByteBlob): Replaced unsafe code with
12849 BitConverter, as suggested by Paolo.
12851 * cfold.cs (ConstantFold.Binary): Special case: perform constant
12852 folding of string concatenation, but if either side is a string,
12853 and the other is not, then return null, and let the runtime use
12854 the concatenation on the string plus the object (using
12855 `Object.ToString').
12857 2002-03-04 Miguel de Icaza <miguel@ximian.com>
12859 Constant Folding has been implemented now.
12861 * expression.cs (Unary.Reduce): Do not throw an exception, catch
12862 the error instead on types that are not supported in one's
12865 * constant.cs (Constant and all children): New set of functions to
12866 perform implict and explicit conversions.
12868 * ecore.cs (EnumConstant): Implement the new functions to perform
12869 conversion by proxying to the child expression.
12871 * codegen.cs: (ConstantCheckState): Constant evaluation has its
12872 own separate setting that can not be turned off from the command
12873 line using --unchecked or --checked and is only controlled using
12874 the checked/unchecked statements and expressions. This setting is
12875 used by the constant folder to flag errors.
12877 * expression.cs (CheckedExpr, UncheckedExpr): Set the
12878 ConstantCheckState as well.
12880 During Resolve, they also have to flag the state, because the
12881 constant folder runs completely in the Resolve phase.
12883 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
12886 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12888 * cfold.cs: New file, this file contains the constant folder.
12890 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
12891 argument to track whether we are using the resulting address to
12892 load or store a value and provide better error messages.
12894 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
12895 new AddressOf arguments.
12897 * statement.cs (Foreach.EmitCollectionForeach): Update
12899 * expression.cs (Argument.Emit): Call AddressOf with proper
12900 arguments to track usage.
12902 (New.DoEmit): Call AddressOf with new arguments.
12904 (Unary.Emit): Adjust AddressOf call.
12906 2002-03-01 Ravi Pratap <ravi@ximian.com>
12908 * cs-parser.jay (member_access): Change the case for pre-defined types
12909 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
12912 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
12915 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
12916 essentially like methods and apply attributes like MethodImplOptions to them too.
12918 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
12921 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
12922 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
12925 * Update code everywhere accordingly.
12927 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
12929 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
12931 2002-02-28 Ravi Pratap <ravi@ximian.com>
12933 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
12934 try performing lookups against those instead of jumping straight into using
12935 the 'using' clauses.
12937 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
12939 (LookupType): Perform lookups in implicit parents too.
12941 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
12942 sequence as RootContext.LookupType.
12944 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
12945 the various cases of namespace lookups into this method.
12947 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12949 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
12950 in positional arguments)
12952 * class.cs (Operator): Update the AllowedModifiers to contain
12955 * cs-parser.jay: Update operator declaration to allow for the
12956 operator body to be empty.
12958 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
12961 2002-02-27 Miguel de Icaza <miguel@ximian.com>
12963 * class.cs (Method.Emit): Label parameters.
12965 * driver.cs: Return 1 or 0 as the program exit code.
12967 2002-02-26 Miguel de Icaza <miguel@ximian.com>
12969 * expression.cs: Special case the `null' object when trying to
12970 auto-compute the type, as anything can be explicitly converted to
12973 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
12974 spotting this Paolo.
12976 (Expression.ImplicitNumericConversion): Perform comparissions of
12977 the type using the underlying type in the case of an enumeration
12978 rather than using the enumeration type for the compare.
12980 Cope with the underlying == type case, which is not possible to
12983 (Expression.ConvertNumericExplicit): Perform comparissions of
12984 the type using the underlying type in the case of an enumeration
12985 rather than using the enumeration type for the compare.
12987 * driver.cs: If the user does not supply an extension, assume .exe
12989 * cs-parser.jay (if_statement): Rewrote so that we can track the
12990 location for the if statement.
12992 * expression.cs (Binary.ConstantFold): Only concat strings when
12993 the operation is "+", not everything ;-)
12995 * statement.cs (Statement.EmitBoolExpression): Take a location
12997 (If, While, Do): Track location.
12999 * expression.cs (Binary.ResolveOperator): In the object + string
13000 case, I was missing a call to ConvertImplicit
13002 2002-02-25 Ravi Pratap <ravi@ximian.com>
13004 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
13005 Location arguments. Ensure we use RootContext.LookupType to do our work
13006 and not try to do a direct Type.GetType and ModuleBuilder.GetType
13008 * interface.cs (PopulateMethod): Handle the type of the parameter being
13011 * expression.cs (Invocation.BetterFunction): Handle the case when we
13012 have a params method with no fixed arguments and a call is made with no
13015 2002-02-25 Miguel de Icaza <miguel@ximian.com>
13017 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
13018 the verbatim-string-literal
13020 * support.cs (InternalParameters.ParameterModifier): handle null
13022 (InternalParameters.ParameterType): ditto.
13024 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
13025 duplicating the name of the variable parameter.
13026 (GetParameterByName): Fix bug where we were not looking up array
13027 paramters if they were the only present (thanks Paolo!).
13028 (GetParameterInfo): We only have an empty set of types if both
13029 fixed and array are set to null.
13030 (GetParameterInfo-idx): Handle FixedParameter == null
13032 * cs-parser.jay: Handle the case where there is no catch
13033 statements (missing null test).
13035 2002-02-22 Miguel de Icaza <miguel@ximian.com>
13037 * driver.cs (MainDriver): Be conservative on our command line
13040 Catch DirectoryNotFoundException when calling GetFiles.
13042 (SplitPathAndPattern): Used to split the input specification into
13043 a path and a pattern that we can feed to Directory.GetFiles.
13045 2002-02-21 Miguel de Icaza <miguel@ximian.com>
13047 * statement.cs (Fixed): Implement the last case of the Fixed
13048 statement (string handling).
13050 * expression.cs (StringPtr): New class used to return a char * to
13051 a string; Used by the Fixed statement.
13053 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
13055 * expression.cs (Binary.ResolveOperator): Remove redundant
13056 MemberLookup pn parent type.
13057 Optimize union call, we do not need a union if the types are the same.
13058 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
13061 Specialize the use of MemberLookup everywhere, instead of using
13062 the default settings.
13064 (StackAlloc): Implement stackalloc keyword.
13066 * cs-parser.jay: Add rule to parse stackalloc.
13068 * driver.cs: Handle /h, /help, /?
13070 * expression.cs (MakeByteBlob): Removed the hacks we had in place
13071 before we supported unsafe code.
13073 * makefile: add --unsafe to the self compilation of mcs.
13075 2002-02-20 Miguel de Icaza <miguel@ximian.com>
13077 * expression.cs (PointerArithmetic): New class that is used to
13078 perform pointer arithmetic.
13079 (Binary.Resolve): Handle pointer arithmetic
13080 Handle pointer comparission.
13081 (ArrayPtr): Utility expression class that is used to take the
13082 address of an array.
13084 (ElementAccess): Implement array access for pointers
13086 * statement.cs (Fixed): Implement fixed statement for arrays, we
13087 are missing one more case before we are done.
13089 * expression.cs (Indirection): Implement EmitAssign and set the
13090 ExprClass to Variable. This allows pointer dereferences to be
13091 treated as variables, and to have values assigned to them.
13093 * ecore.cs (Expression.StoreFromPtr): New utility function to
13094 store values dereferencing.
13096 2002-02-20 Ravi Pratap <ravi@ximian.com>
13098 * expression.cs (Binary.ResolveOperator): Ensure that we are
13099 not trying to operate on a void type - this fixes the reported
13102 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
13103 the parent implementation is sealed.
13105 * ../errors/cs0239.cs : Add.
13107 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
13109 * typemanager.cs (unverifiable_code_type): Corresponds to
13110 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
13111 which have unsafe code in them.
13113 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
13116 2002-02-19 Miguel de Icaza <miguel@ximian.com>
13118 * cs-tokenizer.cs: Add support for @"litreal strings"
13120 Make tokenizer accept pre-processor directives
13121 on any column (remove the old C-like limitation).
13123 * rootcontext.cs (EmitCode): Emit any global attributes.
13124 (AddGlobalAttributes): Used to keep track of assembly attributes.
13126 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
13128 * cs-parser.jay: Add support for global attributes.
13130 2002-02-17 Miguel de Icaza <miguel@ximian.com>
13132 * expression.cs (Indirection): New helper class. Unary will
13133 create Indirection classes to be able to implement the
13134 IMemoryLocation interface on it.
13136 2002-02-16 Miguel de Icaza <miguel@ximian.com>
13138 * cs-parser.jay (fixed_statement): reference the right statement.
13140 * statement.cs (Fixed.Emit): Finish implementing the fixed
13141 statement for the &x case.
13143 2002-02-14 Miguel de Icaza <miguel@ximian.com>
13145 * class.cs (Property.Define, Method.Define): Remove newslot when
13148 * modifiers.cs: My use of NewSlot when `Abstract' was set was
13149 wrong. NewSlot should only be used if the `new' keyword is present.
13151 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
13152 locating our system dir. Sorry about this.
13154 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13156 * driver.cs (GetSystemDir): Compute correctly the location of our
13157 system assemblies. I was using the compiler directory instead of
13158 the library directory.
13160 2002-02-13 Ravi Pratap <ravi@ximian.com>
13162 * expression.cs (BetterFunction): Put back in what Miguel commented out
13163 since it is the correct fix. The problem is elsewhere ;-)
13165 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
13166 parameters of the parms method are themselves compatible or not !
13168 (StandardConversionExists): Fix very dangerous bug where we were forgetting
13169 to check that a class implements an interface before saying that an implicit
13170 conversion was allowed. Use ImplementsInterface to do the checking.
13172 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13174 * class.cs (Method.Define): Track whether we are an explicit
13175 implementation or not. And only call DefineMethodOverride if we
13176 are an explicit implementation.
13178 (Property.DefineMethod): Ditto.
13180 2002-02-11 Ravi Pratap <ravi@ximian.com>
13182 * expression.cs (BetterFunction): Catch hideous bug which was
13183 preventing us from detecting ambiguous calls due to implicit casts i.e
13186 2002-01-29 Miguel de Icaza <miguel@ximian.com>
13188 * support.cs (Pair): Remove un-needed method. I figured why I was
13189 getting the error in cs-parser.jay, the variable in a foreach loop
13190 is readonly, and the compiler does not really treat this as a variable.
13192 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
13193 instead of EQUALS in grammar.
13195 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
13197 * expression.cs (Unary.DoResolve): Check whether the argument is
13200 2002-01-28 Miguel de Icaza <miguel@ximian.com>
13202 * support.cs: Api for Pair to set a value. Despite the fact that
13203 the variables are public the MS C# compiler refuses to compile
13204 code that accesses the field if the variable is part of a foreach
13207 * statement.cs (Fixed): Begin implementation of the fixed
13210 (Block.AddVariable): Return the VariableInfo on success and null
13211 on failure instead of true/false.
13213 * cs-parser.jay (foreach): Catch errors on variables already
13214 defined (we were ignoring this value before) and properly unwind
13215 the block hierarchy
13217 (fixed_statement): grammar for the fixed statement.
13219 2002-01-25 Miguel de Icaza <miguel@ximian.com>
13221 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
13222 pointer types to be incretemented.
13224 (SizeOf): Implement.
13226 * cs-parser.jay (pointer_member_access): Implement
13227 expr->IDENTIFIER production.
13229 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
13230 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
13233 (Unary): Implement indirection.
13235 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
13236 use in non-unsafe context).
13238 (SimpleName.DoResolve): Check for pointers in field access on safe
13241 (Expression.LoadFromPtr): Factor the load-indirect code in this
13242 function. This was duplicated in UnboxCast and ParameterReference
13244 2002-01-24 Miguel de Icaza <miguel@ximian.com>
13246 * expression.cs (ComposedCast): report an error if a pointer cast
13247 is used in a safe region.
13249 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
13250 pointer type casts in unsafe context.
13252 * codegen.cs (EmitContext): Set up IsUnsafe.
13254 * cs-parser.jay (non_expression_type): Add productions for pointer
13257 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13258 code. We should not use force into static mode if the method is
13259 not virtual. Fixes bug in MIS
13261 * statement.cs (Do.Emit, While.Emit, For.Emit,
13262 Statement.EmitBoolExpression): Add support to Do and While to
13263 propagate infinite loop as `I do return' semantics.
13265 Improve the For case to also test for boolean constants.
13267 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13268 to the list of attributes we can add.
13270 Remove `EmitContext' argument.
13272 * class.cs (Method.Define): Apply parameter attributes.
13273 (Constructor.Define): Apply parameter attributes.
13274 (MethodCore.LabelParameters): Move here the core of labeling
13277 * support.cs (ReflectionParameters.ParameterModifier,
13278 InternalParameters.ParameterModifier): Use IsByRef on the type and
13279 only return the OUT bit for these parameters instead of in/out/ref
13282 This is because I miss-understood things. The ParameterInfo.IsIn
13283 and IsOut represent whether the parameter has the [In] and [Out]
13286 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13288 * ecore.cs (FieldExpr.Emit): Release temporaries.
13290 * assign.cs (LocalTemporary.Release): new function.
13292 * codegen.cs (EmitContext.GetTemporaryStorage,
13293 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13294 temporary storage. Now we can "put back" localbuilders when we
13297 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13299 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13300 need to make a copy of the variable to generate verifiable code.
13302 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13304 * driver.cs: Compute dynamically the system directory.
13306 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13307 Slower, but more generally useful. Used by the abstract
13308 registering implementation.
13310 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13311 the rules for the special rule on Type/instances. First check if
13312 we have the same name, and if so, try that special static path
13313 rather than the instance path.
13315 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13317 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13320 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13321 Enum, ValueType, Delegate or Array for non-corlib compiles.
13323 * cs-tokenizer.cs: Catch long identifiers (645)
13325 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13328 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13329 fix, we were returning too early, so we were not registering
13330 pending methods from abstract classes.
13332 Do not register pending methods if the class is abstract.
13334 * expression.cs (Conditional.DoResolve): Report circular implicit
13335 conversions when we neecd to compute it for conditional
13338 (Is.DoResolve): If the expression is always of the provided type,
13339 flag warning 183. If the expression can not ever be of the
13340 provided type flag warning 184.
13342 * class.cs: Catch 169 as well.
13344 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13347 2002-01-18 Nick Drochak <ndrochak@gol.com>
13349 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13351 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13353 * interface.cs: (PopulateMethod): Check for pointers being defined
13354 only if the unsafe context is active.
13355 (PopulateProperty): ditto.
13356 (PopulateIndexer): ditto.
13358 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13359 specified. If pointers are present, make sure that they are
13360 present in an unsafe context.
13361 (Constructor, Constructor.Define): ditto.
13362 (Field, Field.Define): ditto.
13363 (Property, Property.Define): ditto.
13364 (Event, Event.Define): ditto.
13366 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13367 hashtable if there are classes or structs defined.
13369 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13370 code, as the constant resolution moved.
13372 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13373 the metadata, so we can flag error 133.
13375 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13376 pointer is being declared in an unsafe context.
13378 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13380 * modifiers.cs (Modifiers.Check): Require a Location argument.
13381 Report error 227 for Unsafe use.
13383 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13385 * statement.cs (For.Emit): If the test is null, then report that
13386 we do `return', as we wont reach anything afterwards.
13388 (Switch.SwitchGoverningType): Track the expression that matched
13391 * driver.cs: Allow negative numbers as an error code to flag.
13393 * cs-parser.jay: Handle 1551.
13395 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13397 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13399 * cs-parser.jay: Report 1518 (type declaration can only contain
13400 class, struct, interface, enum or delegate)
13402 (switch_label): Report 1523 (keywords `case' or `default' must
13405 (opt_switch_sections): Report 1522 (empty switch)
13407 * driver.cs: Report 1515 (response file specified multiple times)
13408 Report 1516 (Source file specified multiple times).
13410 * expression.cs (Argument.Resolve): Signal 1510
13412 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13413 access not allowed in static code)
13415 2002-01-11 Ravi Pratap <ravi@ximian.com>
13417 * typemanager.cs (IsPointerType): Utility method which we are going
13420 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13421 the object type, so we take care of that.
13423 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13425 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13426 added to non-params parameters :-)
13428 * typemanager.cs (CSharpName): Include 'void' type too.
13430 (void_ptr_type): Include in the set of core types.
13432 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13435 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13438 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13439 completely forgotten about it.
13441 2002-01-10 Ravi Pratap <ravi@ximian.com>
13443 * cs-parser.jay (pointer_type): Add. This begins our implementation
13444 of parsing rules for unsafe code.
13446 (unsafe_statement): Implement.
13448 (embedded_statement): Modify to include the above.
13450 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13452 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13453 if the current context is an unsafe one.
13455 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13456 are handled differently, we need separate rules for them.
13458 (local_variable_declaration): Update to use local_variable_pointer_type
13459 to allow variable declarations of unmanaged pointer types.
13461 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13462 in unsafe contexts.
13464 * ../errors/cs0214.cs : Add.
13466 2002-01-16 Nick Drochak <ndrochak@gol.com>
13468 * makefile: remove 'response' file when cleaning.
13470 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13472 * cs-parser.jay: Report 1524.
13474 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13476 * typemanager.cs (RegisterMethod): drop checking if we have
13477 registered this from here
13479 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13481 * class.cs (Method.EmitDestructor): Implement calling our base
13484 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13485 value of InFinally.
13487 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13488 this routine and will wrap the call in a try/catch block. Deal
13491 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13493 * ecore.cs (Expression.MemberLookup): instead of taking a
13494 parameter `same_type' that was used to tell whether we could
13495 access private members we compute our containing type from the
13498 (FieldExpr): Added partial support for volatile fields. This does
13499 not work for volatile fields exposed from assemblies, as I can not
13500 figure out how to extract the modreq from it.
13502 Updated all the source files to use this.
13504 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13505 because it is referenced by MemberLookup very often.
13507 2002-01-09 Ravi Pratap <ravi@ximian.com>
13509 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13510 TypeBuilder.GetCustomAttributes to retrieve what we need.
13512 Get rid of redundant default_member_attr_type as this is the same as
13513 default_member_type which already exists.
13515 * interface.cs, attribute.cs : Update accordingly.
13517 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13519 * typemanager.cs: Enable IndexerPropertyName again. It does not
13520 work for TYpeBuilders though. Ravi, can you please fix this?
13522 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13524 * expression.cs (Argument.Emit): Handle the case of ref objects
13525 being passed to ref functions;
13527 (ParameterReference.EmitLoad): Loads the content of the pointer
13528 without dereferencing.
13530 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13532 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13534 2002-01-08 Ravi Pratap <ravi@ximian.com>
13536 * class.cs (Indexer.DefineMethod): Incorporate the interface
13537 type in the name of the method if we are doing explicit interface
13540 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13542 (BetterConversion): Fix extremely trivial bug where we were referring to
13543 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13546 * ../errors/bug16.cs : Add although we have fixed it.
13548 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13550 * expression.cs (BaseIndexer): Begin implementation.
13552 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13554 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13555 production directly to remove a shift/reduce, and implement
13556 explicit interface implementation.
13558 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13559 after a floating point suffix.
13561 * expression.cs (DoNumericPromotions): Improved the conversion for
13562 uint/uint. If we have a constant, we avoid doing a typecast to a
13565 * class.cs (Indexer): Implement explicit interface implementation
13568 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13570 * class.cs: make the default instance constructor public and hidebysig.
13572 2001-01-03 Ravi Pratap <ravi@ximian.com>
13574 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13575 so we can call it from elsewhere.
13577 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13578 we emit it internally if the class has a defined indexer; otherwise the user
13579 emits it by decorating the class definition with the DefaultMemberAttribute.
13581 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13582 attribute is not used on a type which defines an indexer.
13584 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13585 character when we skip whitespace.
13587 * ../errors/cs0646.cs : Add.
13589 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13591 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13594 * makefile: Add practical target `mcs3.exe' which builds the third
13595 generation compiler.
13597 * expression.cs (New): Fix structures constructor calling.
13599 * class.cs (Property, Method, Indexer): Emit Final flag on the
13600 method if we are an interface implementation and we are not
13603 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13604 whether this property is referencing a `base' method.
13606 * expression.cs (Invocation.EmitCall): take an extra argument:
13607 is_base, this is used to determine whether the `call' or
13608 `callvirt' opcode should be used.
13611 * delegate.cs: update EmitCall.
13613 * class.cs (Method.Define): Set NewSlot for the cases where we are
13614 not implementing an interface method.
13616 (Property.Define): ditto.
13618 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13620 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13621 'r'. Allows mcs to parse itself fully.
13623 2002-01-02 Ravi Pratap <ravi@ximian.com>
13625 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13626 of the number of initializers that require the InitializeArray method.
13628 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13629 update the above field where necessary.
13631 (MakeByteBlob): Update accordingly.
13633 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13636 (EmitDynamicInitializers): Update in accordance with the new optimization.
13638 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13639 same OpCode applies.
13641 * cs-parser.jay : Fix some glaring errors I introduced.
13643 2002-01-01 Ravi Pratap <ravi@ximian.com>
13645 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13646 so that we can check for name clashes there too.
13648 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13649 for interface indexers.
13651 * interfaces.cs (Define): Emit the default member attribute.
13653 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13654 variable was being referred to while setting the value ;-)
13656 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13658 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13659 byte-by-byte information when we know the data is zero.
13661 Make the block always a multiple of 4, because
13662 DefineInitializedData has a bug.
13664 * assign.cs: Fix, we should assign from the temporary, not from
13667 * expression.cs (MakeByteBlob): Fix my incorrect code.
13669 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13671 * typemanager.cs (EnumToUnderlying): This function is used to get
13672 the underlying type from an enumeration, because it does not
13675 * constant.cs: Use the I4_S form for values between -128 and 127.
13677 * statement.cs (Block.LookupLabel): Looks up a label.
13678 (Block): Drop support for labeled blocks.
13680 (LabeledStatement): New kind of statement that represents a label
13683 (Goto): Finally implement this bad boy.
13685 * cs-parser.jay: Update to reflect new mechanism to implement
13688 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13690 * codegen.cs (EmitContext.This): a codegen property that keeps the
13691 a single instance of this instead of creating many different this
13694 * delegate.cs (Delegate.DoResolve): Update to use the property;
13696 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13698 * expression.cs (BaseAccess.DoResolve): Ditto.
13700 2001-12-29 Ravi Pratap <ravi@ximian.com>
13702 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13703 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13705 (InitCoreTypes): Update accordingly.
13707 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13708 so we can quickly store the state.
13710 (ApplyAttributes): Set the correct implementation flags
13711 for InternalCall methods.
13713 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13715 * expression.cs (EmitCall): if a method is not virtual, then do
13716 not use callvirt on it.
13718 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13719 user defined stuff) requires the use of stobj, which takes an
13720 address on the stack instead of an array and an index. So emit
13721 the Ldelema operation for it.
13723 (EmitStoreOpcode): Use stobj for valuetypes.
13725 (UnaryMutator.EmitCode): Use the right 1 value depending on
13726 whether we are dealing with int64/uint64, float or doubles.
13728 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13729 constructors that I implemented last night.
13731 (Constructor.IsDefault): Fix to work properly for static
13734 * cs-parser.jay (CheckDef): report method signature errors.
13735 Update error number 103 to be 132.
13737 * decl.cs: New AdditionResult enumeration value: MethodExists.
13738 Although we do this check for methods later on in the semantic
13739 analysis, catching repeated default constructors is so easy that
13740 we catch these here.
13742 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13745 (ParameterReference.EmitAssign, Emit): handle
13748 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13749 (ArrayAccess.EmitStoreOpcode): ditto.
13751 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13753 * expression.cs (MakeByteBlob): Complete all the missing types
13754 (uint, short, ushort, byte, sbyte)
13756 * class.cs: Only init instance field initializers on instance
13759 Rename `constructors' to instance_constructors.
13761 (TypeContainer.AddConstructor): Only add constructors to the list
13762 if it is not static.
13764 Make sure that we handle default_static_constructor independently
13765 everywhere where we handle instance_constructors
13767 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13769 * class.cs: Do not lookup or create a base initializer for a
13770 static constructor.
13772 (ConstructorInitializer.Resolve): use the proper type to lookup
13775 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13777 * enum.cs, interface.cs: Remove CloseType, this is taken care by
13780 * decl.cs: CloseType is now an virtual method, the default
13781 implementation just closes this type.
13783 2001-12-28 Ravi Pratap <ravi@ximian.com>
13785 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
13786 to PreserveSig by default. Also emit HideBySig on such methods.
13788 Basically, set the defaults to standard values.
13790 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
13791 argument, if candidate is better, it can't be worse than the best !
13793 (Invocation): Re-write bits to differentiate between methods being
13794 applicable in their expanded form and their normal form - for params
13797 Get rid of use_standard everywhere as only standard conversions are allowed
13798 in overload resolution.
13800 More spec conformance.
13802 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13804 * driver.cs: Add --timestamp, to see where the compiler spends
13807 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
13808 `this' in static code.
13810 (SimpleName.DoResolve): Implement in terms of a helper function
13811 that allows static-references to be passed upstream to
13814 (Expression.ResolveWithSimpleName): Resolve specially simple
13815 names when called by MemberAccess to implement the special
13818 (Expression.ImplicitReferenceConversion): Handle conversions from
13819 Null to reference types before others, as Null's type is
13822 * expression.cs (Invocation.EmitCall): Handle the special case of
13823 calling methods declared on a reference type from a ValueType
13824 (Base classes System.Object and System.Enum)
13826 (MemberAccess.Resolve): Only perform lookups on Enumerations if
13827 the left hand side is a TypeExpr, not on every enumeration.
13829 (Binary.Resolve): If types are reference types, then do a cast to
13830 object on operators != and == of both arguments.
13832 * typemanager.cs (FindMembers): Extract instance and static
13833 members if requested.
13835 * interface.cs (PopulateProperty): Use void_type instead of null
13836 as the return type for the setter method.
13838 (PopulateIndexer): ditto.
13840 2001-12-27 Ravi Pratap <ravi@ximian.com>
13842 * support.cs (ReflectionParameters): Fix minor bug where we
13843 were examining the wrong parameter for the ParamArray attribute.
13845 Cope with requests for the type of the parameter at position
13846 greater than the params parameter's. We now return the element
13847 type of the params array as that makes more sense.
13849 * expression.cs (Invocation.IsParamsMethodApplicable): Update
13850 accordingly as we no longer have to extract the element type
13853 (Invocation.OverloadResolve): Update.
13855 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13857 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
13858 against IEnumerator, test whether the return value is a descendant
13859 of the IEnumerator interface.
13861 * class.cs (Indexer.Define): Use an auxiliary method to implement
13862 the other bits of the method definition. Begin support for
13863 explicit interface implementation.
13865 (Property.DefineMethod): Use TypeManager.void_type instead of null
13866 for an empty return value.
13868 2001-12-26 Miguel de Icaza <miguel@ximian.com>
13870 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
13871 dealing with a FieldExpr which is composed of a FieldBuilder, in
13872 the code path we did extract the constant, but we should have
13873 obtained the underlying value to be able to cast it (otherwise we
13874 end up in an infinite loop, this is what Ravi was running into).
13876 (ArrayCreation.UpdateIndices): Arrays might be empty.
13878 (MemberAccess.ResolveMemberAccess): Add support for section
13879 14.5.4.1 that deals with the special case of E.I when E is a type
13880 and something else, that I can be a reference to a static member.
13882 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
13883 handle a particular array type to create byte blobs, it is just
13884 something we dont generate byteblobs for.
13886 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
13889 * location.cs (Push): remove the key from the hashtable that we
13890 are about to add. This happens for empty files.
13892 * driver.cs: Dispose files after we have parsed them.
13894 (tokenize): new function that only runs the tokenizer on its
13895 input, for speed testing.
13897 2001-12-26 Ravi Pratap <ravi@ximian.com>
13899 * class.cs (Event.Define): Define the private field only if there
13900 are no accessors defined.
13902 * expression.cs (ResolveMemberAccess): If there is no associated
13903 field with the event, that means we have an event defined with its
13904 own accessors and we should flag error cs0070 since transforming
13905 ourselves into a field is not valid in that case.
13907 * ecore.cs (SimpleName.DoResolve): Same as above.
13909 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
13910 and charset to sane values.
13912 2001-12-25 Ravi Pratap <ravi@ximian.com>
13914 * assign.cs (DoResolve): Perform check on events only if they
13915 are being accessed outside the declaring type.
13917 * cs-parser.jay (event_declarations): Update rules to correctly
13918 set the type of the implicit parameter etc.
13920 (add_accessor, remove_accessor): Set current local parameters.
13922 * expression.cs (Binary): For delegate addition and subtraction,
13923 cast the return value from the method into the appropriate delegate
13926 2001-12-24 Ravi Pratap <ravi@ximian.com>
13928 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
13929 of these as the workaround is unnecessary.
13931 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
13932 delegate data - none of that is needed at all.
13934 Re-write bits to extract the instance expression and the delegate method
13937 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
13940 * attribute.cs (ApplyAttributes): New method to take care of common tasks
13941 of attaching attributes instead of duplicating code everywhere.
13943 * everywhere : Update code to do attribute emission using the above method.
13945 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13947 * expression.cs (IsParamsMethodApplicable): if there are not
13948 parameters, return immediately.
13950 * ecore.cs: The 0 literal can be implicity converted to an enum
13953 (SimpleName.DoResolve): First lookup the type, then lookup the
13956 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
13957 want to get its address. If the InstanceExpression is not
13958 addressable, store the result in a temporary variable, then get
13961 * codegen.cs: Only display 219 errors on warning level or above.
13963 * expression.cs (ArrayAccess): Make it implement the
13964 IMemoryLocation interface.
13966 (Binary.DoResolve): handle the operator == (object a, object b)
13967 and operator != (object a, object b) without incurring into a
13968 BoxedCast (because 5 != o should never be performed).
13970 Handle binary enumerator operators.
13972 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
13973 value type, otherwise use Ldelem_ref.
13975 Use precomputed names;
13977 (AddressOf): Implement address of
13979 * cs-parser.jay (labeled_statement): Fix recursive block
13980 addition by reworking the production.
13982 * expression.cs (New.DoEmit): New has a special case:
13984 If we are dealing with a ValueType, we have a few
13985 situations to deal with:
13987 * The target of New is a ValueType variable, that is
13988 easy, we just pass this as the variable reference
13990 * The target of New is being passed as an argument,
13991 to a boxing operation or a function that takes a
13994 In this case, we need to create a temporary variable
13995 that is the argument of New.
13998 2001-12-23 Ravi Pratap <ravi@ximian.com>
14000 * rootcontext.cs (LookupType): Check that current_type is not null before
14001 going about looking at nested types.
14003 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
14004 not implement the IAssignMethod interface any more.
14006 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
14007 where we tranform them into FieldExprs if they are being resolved from within
14008 the declaring type.
14010 * ecore.cs (SimpleName.DoResolve): Do the same here.
14012 * assign.cs (DoResolve, Emit): Clean up code considerably.
14014 * ../errors/bug10.cs : Add.
14016 * ../errors/cs0070.cs : Add.
14018 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
14020 * assign.cs : Get rid of EventIsLocal everywhere.
14022 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14024 * ecore.cs (ConvertIntLiteral): finished the implementation.
14026 * statement.cs (SwitchLabel): Convert the value we are using as a
14027 key before looking up the table.
14029 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14031 * codegen.cs (EmitTopBlock): Require a Location argument now.
14033 * cs-parser.jay (constructor_declarator): We need to setup
14034 current_local_parameters before we parse the
14035 opt_constructor_initializer, to allow the variables to be bound
14036 to the constructor arguments.
14038 * rootcontext.cs (LookupType): First lookup nested classes in our
14039 class and our parents before we go looking outside our class.
14041 * expression.cs (ConstantFold): Extract/debox the values at the
14044 * rootcontext.cs (EmitCode): Resolve the constants first before we
14045 resolve the types. This is not really needed, but it helps debugging.
14047 * statement.cs: report location.
14049 * cs-parser.jay: pass location to throw statement.
14051 * driver.cs: Small bug fix.
14053 * report.cs: Updated format to be 4-zero filled digits.
14055 2001-12-22 Ravi Pratap <ravi@ximian.com>
14057 * expression.cs (CheckIndices): Fix minor bug where the wrong
14058 variable was being referred to ;-)
14060 (DoEmit): Do not call EmitStaticInitializers when the
14061 underlying type is System.Object.
14063 2001-12-21 Ravi Pratap <ravi@ximian.com>
14065 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
14066 and do the usual workaround for SRE.
14068 * class.cs (MyEventBuilder.EventType): New member to get at the type
14069 of the event, quickly.
14071 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
14073 * assign.cs (Assign.DoResolve): Handle the case when the target
14074 is an EventExpr and perform the necessary checks.
14076 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
14079 (SimpleName.MemberStaticCheck): Include check for EventExpr.
14081 (EventExpr): Set the type in the constructor itself since we
14082 are meant to be born fully resolved.
14084 (EventExpr.Define): Revert code I wrote earlier.
14086 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
14087 instance expression is null. The instance expression is a This in that case
14088 or a null, depending on whether it is a static method or not.
14090 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
14091 refers to more than one method.
14093 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
14094 and accordingly flag errors.
14096 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14098 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
14100 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14102 * location.cs (ToString): Provide useful rutine.
14104 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14106 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
14107 objects, return the actual integral boxed.
14109 * statement.cs (SwitchLabel): define an ILLabel for each
14112 (Switch.CheckSwitch): If the value is a Literal, extract
14113 the underlying literal.
14115 Also in the unused hashtable we had, add the SwitchLabel so we can
14116 quickly look this value up.
14118 * constant.cs: Implement a bunch of new constants. Rewrite
14119 Literal based on this. Made changes everywhere to adapt to this.
14121 * expression.cs (Expression.MakeByteBlob): Optimize routine by
14122 dereferencing array only once, and also copes with enumrations.
14124 bytes are two bytes wide, not one.
14126 (Cast): Perform constant conversions.
14128 * ecore.cs (TryImplicitIntConversion): Return literals instead of
14129 wrappers to the literals here.
14131 * expression.cs (DoNumericPromotions): long literals can converted
14132 to ulong implicity (this is taken care of elsewhere, but I was
14133 missing this spot).
14135 * ecore.cs (Expression.Literalize): Make the return type Literal,
14136 to improve type checking.
14138 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
14140 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14142 * literal.cs: Revert code from ravi that checked the bounds. The
14143 bounds are sane by the definition of the type itself.
14145 * typemanager.cs: Fix implementation of ImplementsInterface. We
14146 need to actually look up in our parent hierarchy for interfaces
14149 * const.cs: Use the underlying type for enumerations
14151 * delegate.cs: Compute the basename for the delegate creation,
14152 that should fix the delegate test case, and restore the correct
14153 Type Lookup semantics in rootcontext
14155 * rootcontext.cs: Revert Ravi's last patch. The correct way of
14156 referencing a nested type with the Reflection API is using the "+"
14159 * cs-parser.jay: Do not require EOF token at the end.
14161 2001-12-20 Ravi Pratap <ravi@ximian.com>
14163 * rootcontext.cs (LookupType): Concatenate type names with
14164 a '.' instead of a '+' The test suite passes again.
14166 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
14167 field of the enumeration.
14169 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
14170 the case when the member is an EventExpr.
14172 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
14173 static has an associated instance expression.
14175 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
14177 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
14179 * class.cs (Event.Define): Register event and perform appropriate checks
14182 We define the Add and Remove methods even if the use provides none because
14183 in that case, we provide default implementations ourselves.
14185 Define a private field of the type of the event. This is done by the CSC compiler
14186 and we should be doing it too ;-)
14188 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
14189 More methods we use in code we generate.
14191 (multicast_delegate_type, delegate_type): Two separate types since the distinction
14194 (InitCoreTypes): Update accordingly for the above.
14196 * class.cs (Event.Emit): Generate code for default accessors that we provide
14198 (EmitDefaultMethod): Do the job in the above.
14200 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
14203 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14205 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
14206 builders even if we were missing one.
14208 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
14209 pass the Basename as our class name instead of the Name. The
14210 basename will be correctly composed for us.
14212 * parameter.cs (Paramters): Now takes a Location argument.
14214 * decl.cs (DeclSpace.LookupType): Removed convenience function and
14215 make all the code call directly LookupType in RootContext and take
14216 this chance to pass the Location information everywhere.
14218 * Everywhere: pass Location information.
14220 2001-12-19 Miguel de Icaza <miguel@ximian.com>
14222 * class.cs (Constructor.Define): Updated way of detecting the
14223 length of the parameters.
14225 (TypeContainer.DefineType): Use basename as the type name for
14228 (TypeContainer.Define): Do not recursively define types here, as
14229 definition is taken care in order by the RootContext.
14231 * tree.cs: Keep track of namespaces in a per-file basis.
14233 * parameter.cs (Parameter.ComputeSignature): Update to use
14236 (Parameters.GetSignature): ditto.
14238 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
14239 instead of a TypeContainer.
14241 (Interface.SemanticAnalysis): Use `this' instead of our parent to
14242 resolve names. Because we need to be resolve in our context, not
14245 * driver.cs: Implement response files.
14247 * class.cs (TypeContainer.DefineType): If we are defined, do not
14248 redefine ourselves.
14250 (Event.Emit): Emit the code for add/remove handlers.
14251 (Event.Define): Save the MethodBuilders for add/remove.
14253 * typemanager.cs: Use pair here too.
14255 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14256 DictionaryEntry requires the first argument to be non-null.
14258 (enum_declaration): Compute full name for registering the
14261 (delegate_declaration): Instead of using
14262 formal_parameter_list, use opt_formal_parameter_list as the list
14265 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14266 (EventParsing): New property that controls whether `add' and
14267 `remove' are returned as tokens or identifiers (for events);
14269 2001-12-19 Ravi Pratap <ravi@ximian.com>
14271 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14272 use MyEventBuilder only and let it wrap the real builder for us.
14274 (MyEventBuilder): Revamp constructor etc.
14276 Implement all operations that we perform on EventBuilder in precisely the same
14279 (FindMembers): Update to use the EventBuilder member.
14281 (Event.Emit): Update accordingly.
14283 2001-12-18 Ravi Pratap <ravi@ximian.com>
14285 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14286 by calling the appropriate methods.
14288 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14291 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14293 2001-12-17 Ravi Pratap <ravi@ximian.com>
14295 * delegate.cs (Delegate.Populate): Check that the return type
14296 and various parameters types are indeed accessible.
14298 * class.cs (Constructor.Define): Same here.
14300 (Field.Define): Ditto.
14302 (Event.Define): Ditto.
14304 (Operator.Define): Check that the underlying Method defined itself
14305 correctly - so it's MethodBuilder should not be null.
14307 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14308 expression happens to be null.
14310 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14311 members but as of now we don't seem to be able to do anything really useful with it.
14313 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14314 not the EventBuilder.
14316 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14318 * cs-tokenizer.cs: Add support for defines.
14319 Add support for #if, #elif, #else, #endif
14321 (eval_var): evaluates a variable.
14322 (eval): stubbed for evaluating functions.
14324 * cs-parser.jay: Pass the defines information
14326 * driver.cs: Add --define command line option.
14328 * decl.cs: Move MemberCore here.
14330 Make it the base class for DeclSpace. This allows us to catch and
14331 report 108 and 109 for everything now.
14333 * class.cs (TypeContainer.Define): Extract all the members
14334 before populating and emit the warning 108 (new keyword required
14335 to override) instead of having each member implement this.
14337 (MemberCore.Define): New abstract method, we will be using this in
14338 the warning reporting engine in Populate.
14340 (Operator.Define): Adjust to new MemberCore protocol.
14342 * const.cs (Const): This does not derive from Expression, it is a
14343 temporary object we use to create fields, it is a MemberCore.
14345 * class.cs (Method.Define): Allow the entry point to be in a
14348 * driver.cs: Rewrite the argument handler to clean it up a bit.
14350 * rootcontext.cs: Made it just an auxiliary namespace feature by
14351 making everything static.
14353 * driver.cs: Adapt code to use RootContext type name instead of
14356 * delegate.cs: Remove RootContext argument.
14358 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14361 * class.cs (Event.Define): The lookup can fail.
14363 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14365 * expression.cs: Resolve the this instance before invoking the code.
14367 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14369 * cs-parser.jay: Add a production in element_access that allows
14370 the thing to become a "type" reference. This way we can parse
14371 things like "(string [])" as a type.
14373 Note that this still does not handle the more complex rules of
14377 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14379 * ecore.cs: (CopyNewMethods): new utility function used to
14380 assemble the list of methods from running FindMembers.
14382 (MemberLookup): Rework FindMembers so that
14384 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14386 * class.cs (TypeContainer): Remove Delegates who fail to be
14389 * delegate.cs (Populate): Verify that we dont get null return
14390 values. TODO: Check for AsAccessible.
14392 * cs-parser.jay: Use basename to emit error 574 (destructor should
14393 have the same name as container class), not the full name.
14395 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14396 possible representation.
14398 Also implements integer type suffixes U and L.
14400 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14402 * expression.cs (ArrayCreation.DoResolve): We need to do the
14403 argument resolution *always*.
14405 * decl.cs: Make this hold the namespace. Hold the root context as
14407 (LookupType): Move here.
14409 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14411 * location.cs (Row, Name): Fixed the code, it was always returning
14412 references to the first file.
14414 * interface.cs: Register properties defined through interfaces.
14416 * driver.cs: Add support for globbing on the command line
14418 * class.cs (Field): Make it derive from MemberCore as well.
14421 2001-12-15 Ravi Pratap <ravi@ximian.com>
14423 * class.cs (Event::Define): Check that the type of the event is a delegate
14424 type else flag error #66.
14426 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14429 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14430 values of EntryPoint, CharSet etc etc.
14432 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14434 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14435 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14436 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14437 which needs this to do its work.
14439 * ../errors/cs0066.cs : Add.
14441 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14443 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14446 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14447 clears out the parameters field.
14448 (MemberSignatureCompare): Cleanup
14450 (MemberCore): New base class used to share code between MethodCore
14453 (RegisterRequiredImplementations) BindingFlags.Public requires
14454 either BindingFlags.Instace or Static. Use instance here.
14456 (Property): Refactored code to cope better with the full spec.
14458 * parameter.cs (GetParameterInfo): Return an empty array instead
14461 * class.cs (Property): Abstract or extern properties have no bodies.
14463 * parameter.cs (GetParameterInfo): return a zero-sized array.
14465 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14466 method modifier validation to the typecontainer so we can reuse
14467 this on properties.
14469 (MethodCore.ParameterTypes): return an empty sized array of types.
14471 (Property.Define): Test property modifier validity.
14473 Add tests for sealed/override too.
14475 (Method.Emit): abstract or extern methods have no bodies.
14477 2001-12-14 Ravi Pratap <ravi@ximian.com>
14479 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14482 (Method::Define, ::Emit): Modify accordingly.
14484 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14486 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14488 * makefile: Pass in /unsafe.
14490 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14492 * class.cs (MakeKey): Kill routine.
14494 * class.cs (TypeContainer.Define): Correctly define explicit
14495 method implementations (they require the full interface name plus
14498 * typemanager.cs: Deply the PtrHashtable here and stop using the
14499 lame keys. Things work so much better.
14501 This of course broke everyone who depended on `RegisterMethod' to
14502 do the `test for existance' test. This has to be done elsewhere.
14504 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14505 the object stupid Equals method (because, that like fails all over
14506 the place). We still do not use it.
14508 * class.cs (TypeContainer.SetRequiredInterface,
14509 TypeContainer.RequireMethods): Killed these two routines and moved
14510 all the functionality to RegisterRequiredImplementations.
14512 (TypeContainer.RegisterRequiredImplementations): This routine now
14513 registers all the implementations required in an array for the
14514 interfaces and abstract methods. We use an array of structures
14515 which can be computed ahead of time to reduce memory usage and we
14516 also assume that lookups are cheap as most classes will not
14517 implement too many interfaces.
14519 We also avoid creating too many MethodSignatures.
14521 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14522 clear the "pending" bit if we find that there are problems with
14525 (TypeContainer.VerifyPendingMethods): Update to report errors of
14526 methods that look like implementations but are not.
14528 (TypeContainer.Define): Add support for explicit interface method
14531 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14533 * typemanager.cs: Keep track of the parameters here instead of
14534 being a feature of the TypeContainer.
14536 * class.cs: Drop the registration of parameters here, as
14537 InterfaceMethods are also interface declarations.
14539 * delegate.cs: Register methods with the TypeManager not only with
14540 the TypeContainer. This code was buggy.
14542 * interface.cs: Full registation here.
14544 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14546 * expression.cs: Remove reducer for binary expressions, it can not
14549 * const.cs: Put here the code that used to go into constant.cs
14551 * constant.cs: Put here the code for constants, this is a new base
14552 class for Literals.
14554 * literal.cs: Make Literal derive from Constant.
14556 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14558 * statement.cs (Return.Emit): Report error 157 if the user
14559 attempts to return from a finally block.
14561 (Return.Emit): Instead of emitting a return, jump to the end of
14564 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14565 LocalBuilder to store the result of the function. ReturnLabel is
14566 the target where we jump.
14569 2001-12-09 Radek Doulik <rodo@ximian.com>
14571 * cs-parser.jay: remember alias in current namespace
14573 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14576 * class.cs (LookupAlias): lookup alias in my_namespace
14578 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14580 (LookupAlias): lookup alias in this and if needed in parent
14583 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14587 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14588 making things static. I need this to avoid passing the
14589 TypeContainer when calling ParameterType.
14591 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14592 that did string manipulation to compute the type and then call
14593 GetType. Use Parameter.ParameterType instead.
14595 * cs-tokenizer.cs: Consume the suffix for floating values.
14597 * expression.cs (ParameterReference): figure out whether this is a
14598 reference parameter or not. Kill an extra variable by computing
14599 the arg_idx during emission.
14601 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14602 function that returns whether a parameter is an out/ref value or not.
14604 (Parameter.ParameterType): The type of the parameter (base,
14605 without ref/out applied).
14607 (Parameter.Resolve): Perform resolution here.
14608 (Parameter.ExternalType): The full type (with ref/out applied).
14610 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14611 support for expressions on the using statement.
14613 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14615 * statement.cs (Using.EmitLocalVariableDecls): Split the
14616 localvariable handling of the using statement.
14618 (Block.EmitMeta): Keep track of variable count across blocks. We
14619 were reusing slots on separate branches of blocks.
14621 (Try.Emit): Emit the general code block, we were not emitting it.
14623 Check the type of the declaration to be an IDisposable or
14624 something that can be implicity converted to it.
14626 Emit conversions if required.
14628 * ecore.cs (EmptyExpression): New utility class.
14629 (Expression.ImplicitConversionExists): New utility function.
14631 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14633 * statement.cs (Using): Implement.
14635 * expression.cs (LocalVariableReference): Support read only variables.
14637 * statement.cs: Remove the explicit emit for the Leave opcode.
14638 (VariableInfo): Add a readonly field.
14640 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14642 * ecore.cs (ConvCast): new class used to encapsulate the various
14643 explicit integer conversions that works in both checked and
14644 unchecked contexts.
14646 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14647 properly generate the overflow opcodes.
14649 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14651 * statement.cs: The correct type for the EmptyExpression is the
14652 element_type, not the variable type. Ravi pointed this out.
14654 2001-12-04 Ravi Pratap <ravi@ximian.com>
14656 * class.cs (Method::Define): Handle PInvoke methods specially
14657 by using DefinePInvokeMethod instead of the usual one.
14659 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14660 above to do the task of extracting information and defining the method.
14662 2001-12-04 Ravi Pratap <ravi@ximian.com>
14664 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14665 of the condition for string type.
14667 (Emit): Move that here.
14669 (ArrayCreation::CheckIndices): Keep string literals in their expression
14672 (EmitDynamicInitializers): Handle strings appropriately.
14674 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14676 * codegen.cs (EmitContext): Replace multiple variables with a
14677 single pointer to the current Switch statement.
14679 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14682 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14686 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14689 (Foreach.Emit): Foreach on arrays was not setting
14690 up the loop variables (for break/continue).
14692 (GotoCase): Semi-implented.
14694 2001-12-03 Ravi Pratap <ravi@ximian.com>
14696 * attribute.cs (CheckAttribute): Handle system attributes by using
14697 Attribute.GetAttributes to examine information we need.
14699 (GetValidPlaces): Same here.
14701 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14703 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14705 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14707 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14709 (Method::Emit): Handle the case when we are a PInvoke method.
14711 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14713 * expression.cs: Use ResolveWithSimpleName on compound names.
14715 2001-12-02 Ravi Pratap <ravi@ximian.com>
14717 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14718 before trying to reduce it.
14720 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14722 * constant.cs (LookupConstantValue): Implement.
14724 (EmitConstant): Use the above in emitting the constant.
14726 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14727 that are user-defined by doing a LookupConstantValue on them.
14729 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14732 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14734 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14736 (BaseAccess.DoResolve): Implement.
14738 (MemberAccess.DoResolve): Split this routine into a
14739 ResolveMemberAccess routine that can be used independently
14741 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14743 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14744 As that share bits of the implementation. Is returns a boolean,
14745 while As returns the Type that is being probed.
14747 2001-12-01 Ravi Pratap <ravi@ximian.com>
14749 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14750 instead of a Literal - much easier.
14752 (EnumInTransit): Remove - utterly useless :-)
14754 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14756 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14758 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14759 chain when we have no associated expression.
14761 2001-11-30 Ravi Pratap <ravi@ximian.com>
14763 * constant.cs (Define): Use Location while reporting the errror.
14765 Also emit a warning when 'new' is used and there is no inherited
14768 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14771 (LookupEnumValue): Implement to lookup an enum member's value and define it
14774 (Populate): Re-write accordingly to use the above routine.
14776 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14778 * expression.cs (This): Fix prototype for DoResolveLValue to
14779 override the base class DoResolveLValue.
14781 * cs-parser.cs: Report errors cs574 and cs575 (destructor
14784 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
14785 (we need to load the address of the field here). This fixes
14788 (FieldExpr.DoResolveLValue): Call the DoResolve
14789 function to initialize the Instance expression.
14791 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
14792 correctly the GetEnumerator operation on a value type.
14794 * cs-parser.jay: Add more simple parsing error catches.
14796 * statement.cs (Switch): Add support for string switches.
14797 Handle null specially.
14799 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
14801 2001-11-28 Ravi Pratap <ravi@ximian.com>
14803 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
14805 (declare_local_constant): New helper function.
14807 * statement.cs (AddConstant): Keep a separate record of constants
14809 (IsConstant): Implement to determine if a variable is a constant.
14811 (GetConstantExpression): Implement.
14813 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
14815 * statement.cs (IsVariableDefined): Re-write.
14817 2001-11-27 Ravi Pratap <ravi@ximian.com>
14819 * class.cs (TypeContainer::FindMembers): Look for constants
14820 in the case when we are looking for MemberTypes.Field
14822 * expression.cs (MemberAccess::DoResolve): Check that in the
14823 case we are a FieldExpr and a Literal, we are not being accessed
14824 by an instance reference.
14826 * cs-parser.jay (local_constant_declaration): Implement.
14828 (declaration_statement): Implement for constant declarations.
14830 2001-11-26 Miguel de Icaza <miguel@ximian.com>
14832 * statement.cs (Switch): Catch double defaults.
14834 (Switch): More work on the switch() statement
14835 implementation. It works for integral values now, need to finish
14839 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14841 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
14842 integer literals into other integer literals. To be used by
14845 2001-11-24 Ravi Pratap <ravi@ximian.com>
14847 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
14850 (EmitDynamicInitializers): Cope with the above since we extract data
14851 directly from ArrayData now.
14853 (ExpectInitializers): Keep track of whether initializers are mandatory
14856 (Bounds): Make it a hashtable to prevent the same dimension being
14857 recorded for every element in that dimension.
14859 (EmitDynamicInitializers): Fix bug which prevented the Set array method
14862 Also fix bug which was causing the indices to be emitted in the reverse
14865 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14867 * expression.cs (ArrayCreation): Implement the bits that Ravi left
14868 unfinished. They do not work, because the underlying code is
14871 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14873 * cs-parser.jay: Remove bogus fixme.
14875 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
14876 on Switch statement.
14878 2001-11-23 Ravi Pratap <ravi@ximian.com>
14880 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
14883 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
14884 parameter. Apparently, any expression is allowed.
14886 (ValidateInitializers): Update accordingly.
14888 (CheckIndices): Fix some tricky bugs thanks to recursion.
14890 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
14891 I was being completely brain-dead.
14893 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
14894 and re-write acordingly.
14896 (DelegateInvocation): Re-write accordingly.
14898 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
14900 (MakeByteBlob): Handle types more correctly.
14902 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
14903 initialization from expressions but it is incomplete because I am a complete
14906 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14908 * statement.cs (If.Emit): Fix a bug that generated incorrect code
14909 on If. Basically, we have to return `true' (ie, we do return to
14910 our caller) only if both branches of the if return.
14912 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
14913 short-circuit operators, handle them as short circuit operators.
14915 (Cast.DoResolve): Resolve type.
14916 (Cast.Cast): Take an expression as the target type.
14918 * cs-parser.jay (cast_expression): Remove old hack that only
14919 allowed a limited set of types to be handled. Now we take a
14920 unary_expression and we resolve to a type during semantic
14923 Use the grammar productions from Rhys to handle casts (this is
14924 not complete like Rhys syntax yet, we fail to handle that corner
14925 case that C# has regarding (-x), but we will get there.
14927 2001-11-22 Ravi Pratap <ravi@ximian.com>
14929 * class.cs (EmitFieldInitializer): Take care of the case when we have a
14930 field which is an array type.
14932 * cs-parser.jay (declare_local_variables): Support array initialization too.
14934 * typemanager.cs (MakeKey): Implement.
14936 (everywhere): Use the above appropriately.
14938 * cs-parser.jay (for_statement): Update for array initialization while
14939 declaring variables.
14941 * ecore.cs : The error message was correct, it's the variable's names that
14942 were misleading ;-) Make the code more readable.
14944 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
14945 the correct type etc.
14947 (ConvertExplicit): Handle Enum types by examining the underlying type.
14949 2001-11-21 Ravi Pratap <ravi@ximian.com>
14951 * parameter.cs (GetCallingConvention): Always return
14952 CallingConventions.Standard for now.
14954 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14956 * expression.cs (Binary.ResolveOperator): Update the values of `l'
14957 and `r' after calling DoNumericPromotions.
14959 * ecore.cs: Fix error message (the types were in the wrong order).
14961 * statement.cs (Foreach.ProbeCollectionType): Need to pass
14962 BindingFlags.Instance as well
14964 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
14965 implicit int literal conversion in an empty cast so that we
14966 propagate the right type upstream.
14968 (UnboxCast): new class used to unbox value types.
14969 (Expression.ConvertExplicit): Add explicit type conversions done
14972 (Expression.ImplicitNumericConversion): Oops, forgot to test for
14973 the target type before applying the implicit LongLiterals to ULong
14976 2001-11-21 Miguel de Icaza <miguel@ximian.com>
14978 * cs-parser.jay (for_statement): Reworked the way For works: now
14979 we declare manually any variables that are introduced in
14980 for_initializer to solve the problem of having out-of-band code
14981 emition (that is what got for broken).
14983 (declaration_statement): Perform the actual variable declaration
14984 that used to be done in local_variable_declaration here.
14986 (local_variable_declaration): Do not declare anything, just pass
14987 the information on a DictionaryEntry
14989 2001-11-20 Ravi Pratap <ravi@ximian.com>
14991 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
14992 re-write of the logic to now make it recursive.
14994 (UpdateIndices): Re-write accordingly.
14996 Store element data in a separate ArrayData list in the above methods.
14998 (MakeByteBlob): Implement to dump the array data into a byte array.
15000 2001-11-19 Ravi Pratap <ravi@ximian.com>
15002 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
15005 * constant.cs (Define): Implement.
15007 (EmitConstant): Re-write fully.
15009 Pass in location info.
15011 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
15014 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
15015 DictionaryEntry since we need location info too.
15017 (constant_declaration): Update accordingly.
15019 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
15020 code into another method : UpdateIndices.
15022 2001-11-18 Ravi Pratap <ravi@ximian.com>
15024 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
15025 some type checking etc.
15027 2001-11-17 Ravi Pratap <ravi@ximian.com>
15029 * expression.cs (ArrayCreation::ValidateInitializers): Implement
15030 bits to provide dimension info if the user skips doing that.
15032 Update second constructor to store the rank correctly.
15034 2001-11-16 Ravi Pratap <ravi@ximian.com>
15036 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
15037 and try to implement.
15039 * ../errors/cs0150.cs : Add.
15041 * ../errors/cs0178.cs : Add.
15043 2001-11-16 Miguel de Icaza <miguel@ximian.com>
15045 * statement.cs: Implement foreach on multi-dimensional arrays.
15047 * parameter.cs (Parameters.GetParameterByName): Also lookup the
15048 name of the params argument.
15050 * expression.cs: Use EmitStoreOpcode to get the right opcode while
15051 initializing the array.
15053 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
15054 we can use this elsewhere.
15056 * statement.cs: Finish implementation of foreach for single
15059 * cs-parser.jay: Use an out-of-band stack to pass information
15060 around, I wonder why I need this.
15062 foreach_block: Make the new foreach_block the current_block.
15064 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
15065 function used to return a static Parameters structure. Used for
15066 empty parameters, as those are created very frequently.
15068 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
15070 2001-11-15 Ravi Pratap <ravi@ximian.com>
15072 * interface.cs : Default modifier is private, not public. The
15073 make verify test passes again.
15075 2001-11-15 Ravi Pratap <ravi@ximian.com>
15077 * support.cs (ReflectionParameters): Fix logic to determine
15078 whether the last parameter is a params one. Test 9 passes again.
15080 * delegate.cs (Populate): Register the builders we define with
15081 RegisterParameterForBuilder. Test 19 passes again.
15083 * cs-parser.jay (property_declaration): Reference $6 instead
15084 of $$ to get at the location.
15086 (indexer_declaration): Similar stuff.
15088 (attribute): Ditto.
15090 * class.cs (Property): Register parameters for the Get and Set methods
15091 if they exist. Test 23 passes again.
15093 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
15094 call to EmitArguments as we are sure there aren't any params arguments.
15095 Test 32 passes again.
15097 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
15098 IndexOutOfRangeException.
15100 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
15101 Test 33 now passes again.
15103 2001-11-15 Miguel de Icaza <miguel@ximian.com>
15105 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
15106 broke a bunch of things. Will have to come up with a better way
15107 of tracking locations.
15109 * statement.cs: Implemented foreach for single dimension arrays.
15111 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15113 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
15114 an error. This removes the lookup from the critical path.
15116 * cs-parser.jay: Removed use of temporary_loc, which is completely
15119 2001-11-14 Miguel de Icaza <miguel@ximian.com>
15121 * support.cs (ReflectionParameters.ParameterModifier): Report
15122 whether the argument is a PARAMS argument or not.
15124 * class.cs: Set the attribute `ParamArrayAttribute' on the
15125 parameter argument.
15127 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
15128 and cons_param_array_attribute (ConstructorInfo for
15129 ParamArrayAttribute).,
15131 * codegen.cs: Emit the return using the `Return' statement, that
15132 way we can report the error correctly for missing return values.
15134 * class.cs (Method.Emit): Clean up.
15136 * expression.cs (Argument.Resolve): Take another argument: the
15137 location where this argument is used. Notice that this is not
15138 part of the "Argument" class as to reduce the size of the
15139 structure (we know the approximate location anyways).
15141 Test if the argument is a variable-reference, if not, then
15142 complain with a 206.
15144 (Argument.Emit): Emit addresses of variables.
15146 (Argument.FullDesc): Simplify.
15148 (Invocation.DoResolve): Update for Argument.Resolve.
15150 (ElementAccess.DoResolve): ditto.
15152 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
15153 method should be virtual, as this method is always virtual.
15155 (NewDelegate.DoResolve): Update for Argument.Resolve.
15157 * class.cs (ConstructorInitializer.DoResolve): ditto.
15159 * attribute.cs (Attribute.Resolve): ditto.
15161 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15163 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
15165 * expression.cs (ParameterReference): Drop IStackStorage and implement
15166 IAssignMethod instead.
15168 (LocalVariableReference): ditto.
15170 * ecore.cs (FieldExpr): Drop IStackStorage and implement
15171 IAssignMethod instead.
15173 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15175 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
15176 enumerations that are used in heavily used structures derive from
15177 byte in a laughable and pathetic attempt to reduce memory usage.
15178 This is the kind of pre-optimzations that you should not do at
15179 home without adult supervision.
15181 * expression.cs (UnaryMutator): New class, used to handle ++ and
15182 -- separatedly from the other unary operators. Cleans up the
15183 code, and kills the ExpressionStatement dependency in Unary.
15185 (Unary): Removed `method' and `Arguments' from this class, making
15186 it smaller, and moving it all to SimpleCall, so I can reuse this
15187 code in other locations and avoid creating a lot of transient data
15188 strucutres when not required.
15190 * cs-parser.jay: Adjust for new changes.
15192 2001-11-11 Miguel de Icaza <miguel@ximian.com>
15194 * enum.cs (Enum.Populate): If there is a failure during
15197 * cs-parser.jay (opt_enum_base): we used to catch type errors
15198 here, but this is really incorrect. The type error should be
15199 catched during semantic analysis.
15201 2001-12-11 Ravi Pratap <ravi@ximian.com>
15203 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
15204 current_local_parameters as expected since I, in my stupidity, had forgotten
15207 * attribute.cs (GetValidPlaces): Fix stupid bug.
15209 * class.cs (Method::Emit): Perform check on applicability of attributes.
15211 (Constructor::Emit): Ditto.
15213 (Field::Emit): Ditto.
15215 (Field.Location): Store location information.
15217 (Property, Event, Indexer, Operator): Ditto.
15219 * cs-parser.jay (field_declaration): Pass in location for each field.
15221 * ../errors/cs0592.cs : Add.
15223 2001-11-12 Ravi Pratap <ravi@ximian.com>
15225 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
15227 (InitCoreTypes): Update accordingly.
15229 (RegisterAttrType, LookupAttr): Implement.
15231 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
15232 info about the same.
15234 (Resolve): Update to populate the above as necessary.
15236 (Error592): Helper.
15238 (GetValidPlaces): Helper to the above.
15240 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
15242 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
15244 2001-11-12 Ravi Pratap <ravi@ximian.com>
15246 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
15248 * ../errors/cs0617.cs : Add.
15250 2001-11-11 Ravi Pratap <ravi@ximian.com>
15252 * enum.cs (Emit): Rename to Populate to be more consistent with what
15253 we expect it to do and when exactly it is called.
15255 * class.cs, rootcontext.cs : Update accordingly.
15257 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15258 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15260 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15262 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15263 of a fieldinfo using the above, when dealing with a FieldBuilder.
15265 2001-11-10 Ravi Pratap <ravi@ximian.com>
15267 * ../errors/cs0031.cs : Add.
15269 * ../errors/cs1008.cs : Add.
15271 * ../errrors/cs0543.cs : Add.
15273 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15276 (FindMembers): Implement.
15278 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15279 enums and delegates too.
15281 (enum_types): Rename to builder_to_enum.
15283 (delegate_types): Rename to builder_to_delegate.
15285 * delegate.cs (FindMembers): Implement.
15287 2001-11-09 Ravi Pratap <ravi@ximian.com>
15289 * typemanager.cs (IsEnumType): Implement.
15291 * enum.cs (Emit): Re-write parts to account for the underlying type
15292 better and perform checking etc.
15294 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15295 of the underlying type.
15297 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15300 * enum.cs (error31): Helper to report error #31.
15302 * cs-parser.jay (enum_declaration): Store location of each member too.
15304 * enum.cs (member_to_location): New hashtable.
15306 (AddEnumMember): Update location hashtable.
15308 (Emit): Use the location of each member while reporting errors.
15310 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15312 * cs-parser.jay: A for_initializer if is a
15313 local_variable_declaration really ammount to have an implicit
15314 block with the variable declaration and no initializer for for.
15316 * statement.cs (For.Emit): Cope with null initializers.
15318 This fixes the infinite loop on for initializers.
15320 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15322 * enum.cs: More cleanup.
15324 * ecore.cs: Remove dead code.
15326 * class.cs (Property.Emit): More simplification.
15327 (Event.Emit): ditto.
15329 Reworked to have less levels of indentation.
15331 2001-11-08 Ravi Pratap <ravi@ximian.com>
15333 * class.cs (Property): Emit attributes.
15343 * enum.cs (Emit): Ditto.
15345 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15348 * class.cs (Field, Event, etc.): Move attribute generation into the
15349 Emit method everywhere.
15351 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15352 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15353 as we had no way of defining nested enums !
15355 * rootcontext.cs : Adjust code accordingly.
15357 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15359 2001-11-07 Ravi Pratap <ravi@ximian.com>
15361 * expression.cs (EvalConstantExpression): Move into ecore.cs
15363 * enum.cs (Enum): Rename some members and make them public and readonly
15364 according to our convention.
15366 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15369 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15371 (Enum::Emit): Write a simple version for now which doesn't try to compute
15372 expressions. I shall modify this to be more robust in just a while.
15374 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15376 (TypeContainer::CloseType): Create the Enum types too.
15378 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15380 * expression.cs (EvalConstantExpression): Get rid of completely.
15382 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15383 user-defined values and other cases.
15385 (IsValidEnumLiteral): Helper function.
15387 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15388 out there in the case we had a literal FieldExpr.
15390 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15392 (Literalize): Revamp a bit to take two arguments.
15394 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15396 2001-11-06 Ravi Pratap <ravi@ximian.com>
15398 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15400 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15402 (Resolve): Use the above to ensure we have proper initializers.
15404 2001-11-05 Ravi Pratap <ravi@ximian.com>
15406 * expression.cs (Expression::EvalConstantExpression): New method to
15407 evaluate constant expressions.
15409 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15411 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15413 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15416 (Binary.ResolveOperator): Handle operator != (object a, object b)
15417 and operator == (object a, object b);
15419 (Binary.DoNumericPromotions): Indicate whether the numeric
15420 promotion was possible.
15422 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15425 Made the ArrayAccess implement interface IAssignMethod instead of
15426 IStackStore as the order in which arguments are passed reflects
15429 * assign.cs: Instead of using expr.ExprClass to select the way of
15430 assinging, probe for the IStackStore/IAssignMethod interfaces.
15432 * typemanager.cs: Load InitializeArray definition.
15434 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15435 static data that can be used to initialize arrays.
15437 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15439 * expression.cs: Handle operator== and operator!= for booleans.
15441 (Conditioal.Reduce): Implement reducer for the ?: operator.
15443 (Conditional.Resolve): Implement dead code elimination.
15445 (Binary.Resolve): Catch string literals and return a new
15446 concatenated string.
15448 (Unary.Reduce): Implement reduction of unary expressions.
15450 * ecore.cs: Split out the expression core handling here.
15452 (Expression.Reduce): New method used to perform constant folding
15453 and CSE. This is needed to support constant-expressions.
15455 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15456 targets, and optimize for !x.
15458 2001-11-04 Ravi Pratap <ravi@ximian.com>
15460 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15461 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15462 set custom atttributes.
15464 * literal.cs (Literal::GetValue): New abstract method to return the actual
15465 value of the literal, cast as an object.
15467 (*Literal): Implement GetValue method.
15469 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15470 expressions to the arraylist but objects of type Argument.
15472 * class.cs (TypeContainer::Emit): Emit our attributes too.
15474 (Method::Emit, Constructor::Emit): Ditto.
15476 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15477 to be ignoring earlier.
15479 2001-11-03 Ravi Pratap <ravi@ximian.com>
15481 * attribute.cs (AttributeSection::Define): Implement to do the business
15482 of constructing a CustomAttributeBuilder.
15484 (Attribute): New trivial class. Increases readability of code.
15486 * cs-parser.jay : Update accordingly.
15488 (positional_argument_list, named_argument_list, named_argument): New rules
15490 (attribute_arguments): Use the above so that we are more correct.
15492 2001-11-02 Ravi Pratap <ravi@ximian.com>
15494 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15495 to perform all checks for a method with a params parameter.
15497 (Invocation::OverloadResolve): Update to use the above method and therefore
15498 cope correctly with params method invocations.
15500 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15503 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15504 constructors in our parent too because we can't afford to miss out on
15507 * attribute.cs (AttributeSection): New name for the class Attribute
15509 Other trivial changes to improve readability.
15511 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15512 use the new class names.
15514 2001-11-01 Ravi Pratap <ravi@ximian.com>
15516 * class.cs (Method::Define): Complete definition for params types too
15518 (Indexer::Define): Ditto.
15520 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15521 Cope everywhere with a request for info about the array parameter.
15523 2001-11-01 Ravi Pratap <ravi@ximian.com>
15525 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15527 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15528 local_variable_type to extract the string corresponding to the type.
15530 (local_variable_type): Fixup the action to use the new helper method.
15532 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15535 * expression.cs : Clean out code which uses the above.
15537 2001-10-31 Ravi Pratap <ravi@ximian.com>
15539 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15540 and bale out if necessary by returning a false.
15542 (RegisterProperty): Ditto.
15544 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15545 and print out appropriate error messages.
15547 * interface.cs (everywhere): Ditto.
15549 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15550 location to constructor.
15552 * class.cs (Property, Event, Indexer): Update accordingly.
15554 * ../errors/cs111.cs : Added.
15556 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15557 of a method, as laid down by the spec.
15559 (Invocation::OverloadResolve): Use the above method.
15561 2001-10-31 Ravi Pratap <ravi@ximian.com>
15563 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15564 now take a TypeContainer and a Parameters object.
15566 (ParameterData): Modify return type of ParameterModifier method to be
15567 Parameter.Modifier and not a string.
15569 (ReflectionParameters, InternalParameters): Update accordingly.
15571 * expression.cs (Argument::GetParameterModifier): Same here.
15573 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15574 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15575 symbol in it at all so maybe this is only for now.
15577 2001-10-30 Ravi Pratap <ravi@ximian.com>
15579 * support.cs (InternalParameters): Constructor now takes an extra argument
15580 which is the actual Parameters class.
15582 (ParameterDesc): Update to provide info on ref/out modifiers.
15584 * class.cs (everywhere): Update call to InternalParameters to pass in
15585 the second argument too.
15587 * support.cs (ParameterData): Add ParameterModifier, which is a method
15588 to return the modifier info [ref/out etc]
15590 (InternalParameters, ReflectionParameters): Implement the above.
15592 * expression.cs (Argument::ParameterModifier): Similar function to return
15593 info about the argument's modifiers.
15595 (Invocation::OverloadResolve): Update to take into account matching modifiers
15598 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15599 a new SetFormalParameters object which we pass to InternalParameters.
15601 2001-10-30 Ravi Pratap <ravi@ximian.com>
15603 * expression.cs (NewArray): Merge into the ArrayCreation class.
15605 2001-10-29 Ravi Pratap <ravi@ximian.com>
15607 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15608 NewUserdefinedArray into one as there wasn't much of a use in having
15611 * expression.cs (Argument): Change field's name to ArgType from Type.
15613 (Type): New readonly property which returns the proper type, taking into
15614 account ref/out modifiers.
15616 (everywhere): Adjust code accordingly for the above.
15618 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15619 whether we are emitting for a ref or out parameter.
15621 * expression.cs (Argument::Emit): Use the above field to set the state.
15623 (LocalVariableReference::Emit): Update to honour the flag and emit the
15626 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15628 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15630 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15632 (ReflectionParameters, InternalParameters): Implement the above method.
15634 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15637 (Invocation::FullMethodDesc): Ditto.
15639 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15641 * cs-parser.jay: Add extra production for the second form of array
15644 * expression.cs (ArrayCreation): Update to reflect the above
15647 * Small changes to prepare for Array initialization.
15649 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15651 * typemanager.cs (ImplementsInterface): interface might be null;
15652 Deal with this problem;
15654 Also, we do store negative hits on the cache (null values), so use
15655 this instead of calling t.GetInterfaces on the type everytime.
15657 2001-10-28 Ravi Pratap <ravi@ximian.com>
15659 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15661 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15662 split functionality out into different classes.
15664 (New::FormArrayType): Move into NewBuiltinArray.
15666 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15669 (NewBuiltinArray): New class to handle creation of built-in arrays.
15671 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15672 account creation of one-dimensional arrays.
15674 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15676 (NewUserdefinedArray::DoResolve): Implement.
15678 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15680 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15681 we maintain inside the TypeManager. This is necessary to perform lookups on the
15684 (LookupType): Update to perform GetType on the module builders too.
15686 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15688 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15690 2001-10-23 Ravi Pratap <ravi@ximian.com>
15692 * expression.cs (New::DoResolve): Implement guts of array creation.
15694 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15696 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15698 * expression.cs: Fix bug I introduced lsat night that broke
15701 (Expression.Resolve): Report a 246 error (can not resolve name)
15702 if we find a SimpleName in the stream.
15704 (Expression.ResolveLValue): Ditto.
15706 (Expression.ResolveWithSimpleName): This function is a variant of
15707 ResolveName, this one allows SimpleNames to be returned without a
15708 warning. The only consumer of SimpleNames is MemberAccess
15710 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15712 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15713 might arrive here. I have my doubts that this is correct.
15715 * statement.cs (Lock): Implement lock statement.
15717 * cs-parser.jay: Small fixes to support `lock' and `using'
15719 * cs-tokenizer.cs: Remove extra space
15721 * driver.cs: New flag --checked, allows to turn on integer math
15724 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15725 Threading.Monitor.Exit
15727 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15729 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15730 Expression Class to be IndexerAccess.
15732 Notice that Indexer::DoResolve sets the eclass to Value.
15734 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15736 * class.cs (TypeContainer::Emit): Emit code for indexers.
15738 * assign.cs (IAssignMethod): New interface implemented by Indexers
15739 and Properties for handling assignment.
15741 (Assign::Emit): Simplify and reuse code.
15743 * expression.cs (IndexerAccess, PropertyExpr): Implement
15744 IAssignMethod, clean up old code.
15746 2001-10-22 Ravi Pratap <ravi@ximian.com>
15748 * typemanager.cs (ImplementsInterface): New method to determine if a type
15749 implements a given interface. Provides a nice cache too.
15751 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15754 (ConvertReferenceExplicit): Ditto.
15756 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15757 various methods, with correct names etc.
15759 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15760 Operator.UnaryNegation.
15762 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15763 we have a unary plus or minus operator.
15765 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15768 * everywhere : update accordingly.
15770 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15773 * class.cs (Method::Define): For the case where we are implementing a method
15774 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15775 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15777 2001-10-21 Ravi Pratap <ravi@ximian.com>
15779 * interface.cs (FindMembers): Implement to work around S.R.E
15782 * typemanager.cs (IsInterfaceType): Implement.
15784 (FindMembers): Update to handle interface types too.
15786 * expression.cs (ImplicitReferenceConversion): Re-write bits which
15787 use IsAssignableFrom as that is not correct - it doesn't work.
15789 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
15790 and accordingly override EmitStatement.
15792 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
15793 using the correct logic :-)
15795 2001-10-19 Ravi Pratap <ravi@ximian.com>
15797 * ../errors/cs-11.cs : Add to demonstrate error -11
15799 2001-10-17 Miguel de Icaza <miguel@ximian.com>
15801 * assign.cs (Assign::Resolve): Resolve right hand side first, and
15802 then pass this as a hint to ResolveLValue.
15804 * expression.cs (FieldExpr): Add Location information
15806 (FieldExpr::LValueResolve): Report assignment to readonly
15809 (Expression::ExprClassFromMemberInfo): Pass location information.
15811 (Expression::ResolveLValue): Add new method that resolves an
15814 (Expression::DoResolveLValue): Default invocation calls
15817 (Indexers): New class used to keep track of indexers in a given
15820 (IStackStore): Renamed from LValue, as it did not really describe
15821 what this did. Also ResolveLValue is gone from this interface and
15822 now is part of Expression.
15824 (ElementAccess): Depending on the element access type
15826 * typemanager.cs: Add `indexer_name_type' as a Core type
15827 (System.Runtime.CompilerServices.IndexerNameAttribute)
15829 * statement.cs (Goto): Take a location.
15831 2001-10-18 Ravi Pratap <ravi@ximian.com>
15833 * delegate.cs (Delegate::VerifyDelegate): New method to verify
15834 if two delegates are compatible.
15836 (NewDelegate::DoResolve): Update to take care of the case when
15837 we instantiate a delegate from another delegate.
15839 * typemanager.cs (FindMembers): Don't even try to look up members
15840 of Delegate types for now.
15842 2001-10-18 Ravi Pratap <ravi@ximian.com>
15844 * delegate.cs (NewDelegate): New class to take care of delegate
15847 * expression.cs (New): Split the delegate related code out into
15848 the NewDelegate class.
15850 * delegate.cs (DelegateInvocation): New class to handle delegate
15853 * expression.cs (Invocation): Split out delegate related code into
15854 the DelegateInvocation class.
15856 2001-10-17 Ravi Pratap <ravi@ximian.com>
15858 * expression.cs (New::DoResolve): Implement delegate creation fully
15859 and according to the spec.
15861 (New::DoEmit): Update to handle delegates differently.
15863 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
15864 because of which we were printing out arguments in reverse order !
15866 * delegate.cs (VerifyMethod): Implement to check if the given method
15867 matches the delegate.
15869 (FullDelegateDesc): Implement.
15871 (VerifyApplicability): Implement.
15873 * expression.cs (Invocation::DoResolve): Update to accordingly handle
15874 delegate invocations too.
15876 (Invocation::Emit): Ditto.
15878 * ../errors/cs1593.cs : Added.
15880 * ../errors/cs1594.cs : Added.
15882 * delegate.cs (InstanceExpression, TargetMethod): New properties.
15884 2001-10-16 Ravi Pratap <ravi@ximian.com>
15886 * typemanager.cs (intptr_type): Core type for System.IntPtr
15888 (InitCoreTypes): Update for the same.
15890 (iasyncresult_type, asynccallback_type): Ditto.
15892 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
15895 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
15898 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
15899 the builders for the 4 members of a delegate type :-)
15901 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
15904 * expression.cs (New::DoResolve): Implement guts for delegate creation.
15906 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
15908 2001-10-15 Miguel de Icaza <miguel@ximian.com>
15910 * statement.cs (Break::Emit): Implement.
15911 (Continue::Emit): Implement.
15913 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
15914 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
15915 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
15916 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
15919 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
15920 properties that track the label for the current loop (begin of the
15921 loop and end of the loop).
15923 2001-10-15 Ravi Pratap <ravi@ximian.com>
15925 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
15926 use of emitting anything at all.
15928 * class.cs, rootcontext.cs : Get rid of calls to the same.
15930 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
15932 (Populate): Define the constructor correctly and set the implementation
15935 * typemanager.cs (delegate_types): New hashtable to hold delegates that
15938 (AddDelegateType): Implement.
15940 (IsDelegateType): Implement helper method.
15942 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
15944 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
15945 and accordingly handle it.
15947 * delegate.cs (Populate): Take TypeContainer argument.
15948 Implement bits to define the Invoke method. However, I still haven't figured out
15949 how to take care of the native int bit :-(
15951 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
15952 Qualify the name of the delegate, not its return type !
15954 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
15957 (StandardConversionExists): Checking for array types turns out to be recursive.
15959 (ConvertReferenceExplicit): Implement array conversion.
15961 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
15963 2001-10-12 Ravi Pratap <ravi@ximian.com>
15965 * cs-parser.jay (delegate_declaration): Store the fully qualified
15966 name as it is a type declaration.
15968 * delegate.cs (ReturnType, Name): Rename members to these. Make them
15971 (DefineDelegate): Renamed from Define. Does the same thing essentially,
15972 as TypeContainer::DefineType.
15974 (Populate): Method in which all the definition of the various methods (Invoke)
15977 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
15980 (CloseDelegate): Finally creates the delegate.
15982 * class.cs (TypeContainer::DefineType): Update to define delegates.
15983 (Populate, Emit and CloseType): Do the same thing here too.
15985 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
15986 delegates in all these operations.
15988 2001-10-14 Miguel de Icaza <miguel@ximian.com>
15990 * expression.cs: LocalTemporary: a new expression used to
15991 reference a temporary that has been created.
15993 * assign.cs: Handle PropertyAccess back here, so that we can
15994 provide the proper semantic access to properties.
15996 * expression.cs (Expression::ConvertReferenceExplicit): Implement
15997 a few more explicit conversions.
15999 * modifiers.cs: `NEW' modifier maps to HideBySig.
16001 * expression.cs (PropertyExpr): Make this into an
16002 ExpressionStatement, and support the EmitStatement code path.
16004 Perform get/set error checking, clean up the interface.
16006 * assign.cs: recognize PropertyExprs as targets, and if so, turn
16007 them into toplevel access objects.
16009 2001-10-12 Miguel de Icaza <miguel@ximian.com>
16011 * expression.cs: PropertyExpr::PropertyExpr: use work around the
16014 * typemanager.cs: Keep track here of our PropertyBuilders again to
16015 work around lameness in SRE.
16017 2001-10-11 Miguel de Icaza <miguel@ximian.com>
16019 * expression.cs (LValue::LValueResolve): New method in the
16020 interface, used to perform a second resolution pass for LValues.
16022 (This::DoResolve): Catch the use of this in static methods.
16024 (This::LValueResolve): Implement.
16026 (This::Store): Remove warning, assigning to `this' in structures
16029 (Invocation::Emit): Deal with invocation of
16030 methods on value types. We need to pass the address to structure
16031 methods rather than the object itself. (The equivalent code to
16032 emit "this" for structures leaves the entire structure on the
16033 stack instead of a pointer to it).
16035 (ParameterReference::DoResolve): Compute the real index for the
16036 argument based on whether the method takes or not a `this' pointer
16037 (ie, the method is static).
16039 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
16040 value types returned from functions when we need to invoke a
16041 method on the sturcture.
16044 2001-10-11 Ravi Pratap <ravi@ximian.com>
16046 * class.cs (TypeContainer::DefineType): Method to actually do the business of
16047 defining the type in the Modulebuilder or Typebuilder. This is to take
16048 care of nested types which need to be defined on the TypeBuilder using
16049 DefineNestedMethod.
16051 (TypeContainer::GetClassBases): Implement. Essentially the code from the
16052 methods in RootContext, only ported to be part of TypeContainer.
16054 (TypeContainer::GetInterfaceOrClass): Ditto.
16056 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
16058 * interface.cs (Interface::DefineInterface): New method. Does exactly
16059 what RootContext.CreateInterface did earlier, only it takes care of nested types
16062 (Interface::GetInterfaces): Move from RootContext here and port.
16064 (Interface::GetInterfaceByName): Same here.
16066 * rootcontext.cs (ResolveTree): Re-write.
16068 (PopulateTypes): Re-write.
16070 * class.cs (TypeContainer::Populate): Populate nested types too.
16071 (TypeContainer::Emit): Emit nested members too.
16073 * typemanager.cs (AddUserType): Do not make use of the FullName property,
16074 instead just use the name argument passed in as it is already fully
16077 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
16078 to TypeContainer mapping to see if a type is user-defined.
16080 * class.cs (TypeContainer::CloseType): Implement.
16082 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
16083 the default constructor.
16085 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
16088 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
16090 * interface.cs (CloseType): Create the type here.
16092 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
16095 Remove all the methods which are now in TypeContainer.
16097 2001-10-10 Ravi Pratap <ravi@ximian.com>
16099 * delegate.cs (Define): Re-write bits to define the delegate
16102 2001-10-10 Miguel de Icaza <miguel@ximian.com>
16104 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
16106 * expression.cs (ImplicitReferenceConversion): handle null as well
16107 as a source to convert to any reference type.
16109 * statement.cs (Return): Perform any implicit conversions to
16110 expected return type.
16112 Validate use of return statement.
16114 * codegen.cs (EmitContext): Pass the expected return type here.
16116 * class.cs (Method, Constructor, Property): Pass expected return
16117 type to EmitContext.
16119 2001-10-09 Miguel de Icaza <miguel@ximian.com>
16121 * expression.cs: Make DoResolve take an EmitContext instead of a
16124 Replaced `l' and `location' for `loc', for consistency.
16126 (Error, Warning): Remove unneeded Tc argument.
16128 * assign.cs, literal.cs, constant.cs: Update to new calling
16131 * codegen.cs: EmitContext now contains a flag indicating whether
16132 code is being generated in a static method or not.
16134 * cs-parser.jay: DecomposeQI, new function that replaces the old
16135 QualifiedIdentifier. Now we always decompose the assembled
16136 strings from qualified_identifier productions into a group of
16139 2001-10-08 Miguel de Icaza <miguel@ximian.com>
16141 * rootcontext.cs: Deal with field-less struct types correctly now
16142 by passing the size option to Define Type.
16144 * class.cs: Removed hack that created one static field.
16146 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16148 * statement.cs: Moved most of the code generation here.
16150 2001-10-09 Ravi Pratap <ravi@ximian.com>
16152 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
16155 (ElementAccess): Remove useless bits for now - keep checks as the spec
16158 2001-10-08 Ravi Pratap <ravi@ximian.com>
16160 * expression.cs (ElementAccess::DoResolve): Remove my crap code
16161 and start performing checks according to the spec.
16163 2001-10-07 Ravi Pratap <ravi@ximian.com>
16165 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
16166 rank_specifiers instead.
16168 (rank_specifiers): Change the order in which the rank specifiers are stored
16170 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
16172 * expression.cs (ElementAccess): Implement the LValue interface too.
16174 2001-10-06 Ravi Pratap <ravi@ximian.com>
16176 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
16177 except that user defined conversions are not included.
16179 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
16180 perform the conversion of the return type, if necessary.
16182 (New::DoResolve): Check whether we are creating an array or an object
16183 and accordingly do the needful.
16185 (New::Emit): Same here.
16187 (New::DoResolve): Implement guts of array creation.
16189 (New::FormLookupType): Helper function.
16191 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16193 * codegen.cs: Removed most of the code generation here, and move the
16194 corresponding code generation bits to the statement classes.
16196 Added support for try/catch/finalize and throw.
16198 * cs-parser.jay: Added support for try/catch/finalize.
16200 * class.cs: Catch static methods having the flags override,
16201 virtual or abstract.
16203 * expression.cs (UserCast): This user cast was not really doing
16204 what it was supposed to do. Which is to be born in fully resolved
16205 state. Parts of the resolution were being performed at Emit time!
16209 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16211 * expression.cs: Implicity convert the result from UserCast.
16213 2001-10-05 Ravi Pratap <ravi@ximian.com>
16215 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
16216 prevented it from working correctly.
16218 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
16219 merely ConvertImplicit.
16221 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16223 * typemanager.cs: Make the LookupTypeContainer function static,
16224 and not per-instance.
16226 * class.cs: Make static FindMembers (the one that takes a Type
16229 * codegen.cs: Add EmitForeach here.
16231 * cs-parser.jay: Make foreach a toplevel object instead of the
16232 inline expansion, as we need to perform semantic analysis on it.
16234 2001-10-05 Ravi Pratap <ravi@ximian.com>
16236 * expression.cs (Expression::ImplicitUserConversion): Rename to
16237 UserDefinedConversion.
16239 (Expression::UserDefinedConversion): Take an extra argument specifying
16240 whether we look for explicit user conversions too.
16242 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
16244 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
16246 (ExplicitUserConversion): Make it a call to UserDefinedConversion
16247 with the appropriate arguments.
16249 * cs-parser.jay (cast_expression): Record location too.
16251 * expression.cs (Cast): Record location info.
16253 (Expression::ConvertExplicit): Take location argument.
16255 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16256 to determine if we are doing explicit conversions.
16258 (UserCast::Emit): Update accordingly.
16260 (Expression::ConvertExplicit): Report an error if everything fails.
16262 * ../errors/cs0030.cs : Add.
16264 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16266 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16267 virtual and newslot bits.
16269 * class.cs (TypeContainer::RegisterRequiredImplementations):
16270 Record methods we need.
16272 (TypeContainer::MakeKey): Helper function to make keys for
16273 MethodBases, since the Methodbase key is useless.
16275 (TypeContainer::Populate): Call RegisterRequiredImplementations
16276 before defining the methods.
16278 Create a mapping for method_builders_to_methods ahead of time
16279 instead of inside a tight loop.
16281 (::RequireMethods): Accept an object as the data to set into the
16282 hashtable so we can report interface vs abstract method mismatch.
16284 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16286 * report.cs: Make all of it static.
16288 * rootcontext.cs: Drop object_type and value_type computations, as
16289 we have those in the TypeManager anyways.
16291 Drop report instance variable too, now it is a global.
16293 * driver.cs: Use try/catch on command line handling.
16295 Add --probe option to debug the error reporting system with a test
16298 * report.cs: Add support for exiting program when a probe
16299 condition is reached.
16301 2001-10-03 Ravi Pratap <ravi@ximian.com>
16303 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16304 we do a forcible conversion regardless of type, to check if
16305 ForceConversion returns a null.
16307 (Binary::error19): Use location to report error.
16309 (Unary::error23): Use location here too.
16311 * ../errors/cs0019.cs : Check in.
16313 * ../errors/cs0023.cs : Check in.
16315 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16316 case of a non-null MethodInfo object with a length of 0 !
16318 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16319 an applicable member - according to the spec :-)
16320 Also fix logic to find members in base types.
16322 (Unary::ResolveOperator): Same here.
16324 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16325 as I was getting thoroughly confused between this and error19 :-)
16327 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16328 (::FindMostEncompassedType): Implement.
16329 (::FindMostEncompassingType): Implement.
16330 (::StandardConversionExists): Implement.
16332 (UserImplicitCast): Re-vamp. We now need info about most specific
16333 source and target types so that we can do the necessary conversions.
16335 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16336 mathematical union with no duplicates.
16338 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16340 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16341 in order from base classes to child classes, so that we can in
16342 child classes look up in our parent for method names and
16343 attributes (required for handling abstract, virtual, new, override
16344 constructs: we need to instrospect our base class, and if we dont
16345 populate the classes in order, the introspection might be
16346 incorrect. For example, a method could query its parent before
16347 the parent has any methods and would determine that the parent has
16348 no abstract methods (while it could have had them)).
16350 (RootContext::CreateType): Record the order in which we define the
16353 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16355 * class.cs (TypeContainer::Populate): Also method definitions can
16356 fail now, keep track of this.
16358 (TypeContainer::FindMembers): Implement support for
16359 DeclaredOnly/noDeclaredOnly flag.
16361 (Constructor::Emit) Return the ConstructorBuilder.
16363 (Method::Emit) Return the MethodBuilder.
16364 Check for abstract or virtual methods to be public.
16366 * rootcontext.cs (RootContext::CreateType): Register all the
16367 abstract methods required for the class to be complete and the
16368 interface methods that must be implemented.
16370 * cs-parser.jay: Report error 501 (method requires body if it is
16371 not marked abstract or extern).
16373 * expression.cs (TypeOf::Emit): Implement.
16375 * typemanager.cs: runtime_handle_type, new global type.
16377 * class.cs (Property::Emit): Generate code for properties.
16379 2001-10-02 Ravi Pratap <ravi@ximian.com>
16381 * expression.cs (Unary::ResolveOperator): Find operators on base type
16382 too - we now conform exactly to the spec.
16384 (Binary::ResolveOperator): Same here.
16386 * class.cs (Operator::Define): Fix minor quirk in the tests.
16388 * ../errors/cs0215.cs : Added.
16390 * ../errors/cs0556.cs : Added.
16392 * ../errors/cs0555.cs : Added.
16394 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16396 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16397 single integer which is really efficient
16399 2001-10-01 Ravi Pratap <ravi@ximian.com>
16401 * expression.cs (Expression::ImplicitUserConversion): Use location
16402 even in the case when we are examining True operators.
16404 * class.cs (Operator::Define): Perform extensive checks to conform
16405 with the rules for operator overloading in the spec.
16407 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16408 some of the other conversions mentioned in the spec.
16410 * typemanager.cs (array_type): New static member for the System.Array built-in
16413 (cloneable_interface): For System.ICloneable interface.
16415 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16416 we start resolving the tree and populating types.
16418 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16420 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16422 * expression.cs (Expression::ExprClassFromMemberInfo,
16423 Expression::Literalize): Create literal expressions from
16424 FieldInfos which are literals.
16426 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16427 type casts, because they were wrong. The test suite in tests
16430 (ImplicitNumericConversion): ushort to ulong requires a widening
16433 Int32 constant to long requires widening cast as well.
16435 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16436 for integers because the type on the stack is not i4.
16438 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16440 * expression.cs (report118): require location argument.
16442 * parameter.cs: Do not dereference potential null value.
16444 * class.cs: Catch methods that lack the `new' keyword when
16445 overriding a name. Report warnings when `new' is used without
16446 anything being there to override.
16448 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16450 * class.cs: Only add constructor to hashtable if it is non-null
16451 (as now constructors can fail on define).
16453 (TypeManager, Class, Struct): Take location arguments.
16455 Catch field instance initialization in structs as errors.
16457 accepting_filter: a new filter for FindMembers that is static so
16458 that we dont create an instance per invocation.
16460 (Constructor::Define): Catch errors where a struct constructor is
16463 * cs-parser.jay: Pass location information for various new
16466 * delegate.cs (Delegate): take a location argument.
16468 * driver.cs: Do not call EmitCode if there were problesm in the
16469 Definition of the types, as many Builders wont be there.
16471 * decl.cs (Decl::Decl): Require a location argument.
16473 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16474 into integers, and find the most appropiate integer for it.
16476 * literal.cs: Implement ULongLiteral.
16478 * rootcontext.cs: Provide better information about the location of
16479 failure when CreateType fails.
16481 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16483 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16486 * expression.cs (Binary::CheckShiftArguments): Add missing type
16488 (Binary::ResolveOperator): Add type to the logical and and logical
16489 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16492 (Binary::DoNumericPromotions): In the case where either argument
16493 is ulong (and most signed types combined with ulong cause an
16494 error) perform implicit integer constant conversions as well.
16496 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16498 * expression.cs (UserImplicitCast): Method should always be
16500 (Invocation::BetterConversion): Simplified test for IntLiteral.
16502 (Expression::ImplicitNumericConversion): Split this routine out.
16503 Put the code that performs implicit constant integer conversions
16506 (Expression::Resolve): Become a wrapper around DoResolve so we can
16507 check eclass and type being set after resolve.
16509 (Invocation::Badness): Remove this dead function
16511 (Binary::ResolveOperator): Do not compute the expensive argumnets
16512 unless we have a union for it.
16514 (Probe::Emit): Is needs to do an isinst and then
16515 compare against null.
16517 (::CanConvert): Added Location argument. If the Location argument
16518 is null (Location.Null), then we do not report errors. This is
16519 used by the `probe' mechanism of the Explicit conversion. We do
16520 not want to generate an error for something that the user
16521 explicitly requested to be casted. But the pipeline for an
16522 explicit cast first tests for potential implicit casts.
16524 So for now, if the Location is null, it means `Probe only' to
16525 avoid adding another argument. Might have to revise this
16528 (ClassCast): New class used to type cast objects into arbitrary
16529 classes (used in Explicit Reference Conversions).
16531 Implement `as' as well.
16533 Reverted all the patches from Ravi below: they were broken:
16535 * The use of `level' as a mechanism to stop recursive
16536 invocations is wrong. That was there just to catch the
16537 bug with a strack trace but not as a way of addressing
16540 To fix the problem we have to *understand* what is going
16541 on and the interactions and come up with a plan, not
16542 just get things going.
16544 * The use of the type conversion cache that I proposed
16545 last night had an open topic: How does this work across
16546 protection domains. A user defined conversion might not
16547 be public in the location where we are applying the
16548 conversion, a different conversion might be selected
16549 (ie, private A->B (better) but public B->A (worse),
16550 inside A, A->B applies, but outside it, B->A will
16553 * On top of that (ie, even if the above is solved),
16554 conversions in a cache need to be abstract. Ie, `To
16555 convert from an Int to a Short use an OpcodeCast', not
16556 `To convert from an Int to a Short use the OpcodeCast on
16557 the variable 5' (which is what this patch was doing).
16559 2001-09-28 Ravi Pratap <ravi@ximian.com>
16561 * expression.cs (Invocation::ConversionExists): Re-write to use
16562 the conversion cache
16564 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16565 cache all conversions done, not just user-defined ones.
16567 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16568 to determine if a conversion exists instead of acutually trying to
16569 perform the conversion. It's faster too.
16571 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16572 and only then attempt the implicit conversion.
16574 2001-09-28 Ravi Pratap <ravi@ximian.com>
16576 * expression.cs (ConvertImplicit): Use a cache for conversions
16577 already found. Check level of recursion and bail out if necessary.
16579 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16581 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16582 Export standard methods that we expect for string operations.
16584 * statement.cs (Block::UsageWarning): Track usage of variables and
16585 report the errors for not used variables.
16587 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16590 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16592 * codegen.cs: remove unnneded code
16594 * expression.cs: Removed BuiltinTypeAccess class
16596 Fix the order in which implicit conversions are
16599 The previous fixed dropped support for boxed conversions (adding a
16600 test to the test suite now)
16602 (UserImplicitCast::CanConvert): Remove test for source being null,
16603 that code is broken. We should not feed a null to begin with, if
16604 we do, then we should track the bug where the problem originates
16605 and not try to cover it up here.
16607 Return a resolved expression of type UserImplicitCast on success
16608 rather than true/false. Ravi: this is what I was talking about,
16609 the pattern is to use a static method as a "constructor" for
16612 Also, do not create arguments until the very last minute,
16613 otherwise we always create the arguments even for lookups that
16614 will never be performed.
16616 (UserImplicitCast::Resolve): Eliminate, objects of type
16617 UserImplicitCast are born in a fully resolved state.
16619 * typemanager.cs (InitCoreTypes): Init also value_type
16620 (System.ValueType).
16622 * expression.cs (Cast::Resolve): First resolve the child expression.
16624 (LValue): Add new method AddressOf to be used by
16627 Change the argument of Store to take an EmitContext instead of an
16628 ILGenerator, because things like FieldExpr need to be able to call
16629 their children expression to generate the instance code.
16631 (Expression::Error, Expression::Warning): Sugar functions for
16634 (Expression::MemberLookup): Accept a TypeContainer instead of a
16635 Report as the first argument.
16637 (Expression::ResolvePrimary): Killed. I still want to improve
16638 this as currently the code is just not right.
16640 (Expression::ResolveMemberAccess): Simplify, but it is still
16643 (Unary::Resolve): Catch errors in AddressOf operators.
16645 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16646 index to a byte for the short-version, or the compiler will choose
16647 the wrong Emit call, which generates the wrong data.
16649 (ParameterReference::Emit, ::Store): same.
16651 (FieldExpr::AddressOf): Implement.
16653 * typemanager.cs: TypeManager: made public variable instead of
16656 * driver.cs: document --fatal.
16658 * report.cs (ErrorMessage, WarningMessage): new names for the old
16659 Error and Warning classes.
16661 * cs-parser.jay (member_access): Turn built-in access to types
16662 into a normal simplename
16664 2001-09-27 Ravi Pratap <ravi@ximian.com>
16666 * expression.cs (Invocation::BetterConversion): Fix to cope
16667 with q being null, since this was introducing a bug.
16669 * expression.cs (ConvertImplicit): Do built-in conversions first.
16671 2001-09-27 Ravi Pratap <ravi@ximian.com>
16673 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16675 2001-09-27 Ravi Pratap <ravi@ximian.com>
16677 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16678 I had introduced long ago (what's new ?).
16680 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16681 the work of all the checking.
16682 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16683 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16685 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16686 that is the right way.
16688 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16689 overloading resolution. Use everywhere instead of cutting and pasting code.
16691 (Binary::ResolveOperator): Use MakeUnionSet.
16693 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16694 we have to convert to bool types. Not complete yet.
16696 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16698 * typemanager.cs (TypeManager::CSharpName): support ushort.
16700 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16701 to provide an expression that performsn an implicit constant int
16702 conversion (section 6.1.6).
16703 (Expression::ConvertImplicitRequired): Reworked to include
16704 implicit constant expression conversions.
16706 (Expression::ConvertNumericExplicit): Finished.
16708 (Invocation::Emit): If InstanceExpression is null, then it means
16709 that we perform a call on this.
16711 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16713 * expression.cs (Unary::Emit): Remove some dead code.
16714 (Probe): Implement Resolve and Emit for `is'.
16715 (Expression::ConvertImplicitRequired): Attempt to do constant
16716 expression conversions here. Maybe should be moved to
16717 ConvertImplicit, but I am not sure.
16718 (Expression::ImplicitLongConstantConversionPossible,
16719 Expression::ImplicitIntConstantConversionPossible): New functions
16720 that tell whether is it possible to apply an implicit constant
16721 expression conversion.
16723 (ConvertNumericExplicit): Started work on explicit numeric
16726 * cs-parser.jay: Update operator constants.
16728 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16729 (Parameters::GetSignature): Hook up VerifyArgs here.
16730 (Parameters::VerifyArgs): Verifies that no two arguments have the
16733 * class.cs (Operator): Update the operator names to reflect the
16734 ones that the spec expects (as we are just stringizing the
16737 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16738 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16739 previous usage did only work for our methods.
16740 (Expression::ConvertImplicit): Handle decimal implicit numeric
16741 conversions as well.
16742 (Expression::InternalTypeConstructor): Used to invoke constructors
16743 on internal types for default promotions.
16745 (Unary::Emit): Implement special handling for the pre/post
16746 increment/decrement for overloaded operators, as they need to have
16747 the same semantics as the other operators.
16749 (Binary::ResolveOperator): ditto.
16750 (Invocation::ConversionExists): ditto.
16751 (UserImplicitCast::Resolve): ditto.
16753 2001-09-26 Ravi Pratap <ravi@ximian.com>
16755 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16756 operator, return after emitting body. Regression tests pass again !
16758 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16759 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16760 (Invocation::OverloadResolve): Ditto.
16761 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16763 * everywhere : update calls to the above methods accordingly.
16765 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16767 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16769 * expression.cs (ExpressionStatement): New base class used for
16770 expressions that can appear in statements, so that we can provide
16771 an alternate path to generate expression that do not leave a value
16774 (Expression::Emit, and all the derivatives): We no longer return
16775 whether a value is left on the stack or not. Every expression
16776 after being emitted leaves a single value on the stack.
16778 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16779 facilties of ExpressionStatement if possible.
16781 * cs-parser.jay: Update statement_expression.
16783 2001-09-25 Miguel de Icaza <miguel@ximian.com>
16785 * driver.cs: Change the wording of message
16787 2001-09-25 Ravi Pratap <ravi@ximian.com>
16789 * expression.cs (Binary::ResolveOperator): Had forgottten to set
16790 the type of the expression to the return type of the method if
16791 we have an overloaded operator match ! The regression tests pass again !
16792 (Unary::ResolveOperator): Ditto.
16794 * expression.cs (Invocation::ConversionExists): Correct the member lookup
16795 to find "op_Implicit", not "implicit" ;-)
16796 (UserImplicitCast): New class to take care of user-defined implicit conversions.
16797 (ConvertImplicit, ForceConversion): Take TypeContainer argument
16799 * everywhere : Correct calls to the above accordingly.
16801 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
16802 (ConvertImplicit): Do user-defined conversion if it exists.
16804 2001-09-24 Miguel de Icaza <miguel@ximian.com>
16806 * assign.cs: track location.
16807 (Resolve): Use implicit conversions on assignment.
16809 * literal.cs: Oops. Not good, Emit of short access values should
16810 pass (Bytes) or the wrong argument will be selected.
16812 * expression.cs (Unary::Emit): Emit code for -expr.
16814 (Unary::ResolveOperator): Handle `Substract' for non-constants
16815 (substract from zero from the non-constants).
16816 Deal with Doubles as well.
16818 (Expression::ConvertImplicitRequired): New routine that reports an
16819 error if no implicit conversion exists.
16821 (Invocation::OverloadResolve): Store the converted implicit
16822 expressions if we make them
16824 2001-09-24 Ravi Pratap <ravi@ximian.com>
16826 * class.cs (ConstructorInitializer): Take a Location argument.
16827 (ConstructorBaseInitializer): Same here.
16828 (ConstructorThisInitializer): Same here.
16830 * cs-parser.jay : Update all calls accordingly.
16832 * expression.cs (Unary, Binary, New): Take location argument.
16833 Update accordingly everywhere.
16835 * cs-parser.jay : Update all calls to the above to take a location
16838 * class.cs : Ditto.
16840 2001-09-24 Ravi Pratap <ravi@ximian.com>
16842 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
16843 (Invocation::BetterConversion): Same here
16844 (Invocation::ConversionExists): Ditto.
16846 (Invocation::ConversionExists): Implement.
16848 2001-09-22 Ravi Pratap <ravi@ximian.com>
16850 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
16851 Also take an additional TypeContainer argument.
16853 * All over : Pass in TypeContainer as argument to OverloadResolve.
16855 * typemanager.cs (CSharpName): Update to check for the string type and return
16858 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
16861 2001-09-21 Ravi Pratap <ravi@ximian.com>
16863 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
16864 (Invocation::BetterFunction): Implement.
16865 (Invocation::BetterConversion): Implement.
16866 (Invocation::ConversionExists): Skeleton, no implementation yet.
16868 Okay, things work fine !
16870 2001-09-21 Miguel de Icaza <miguel@ximian.com>
16872 * typemanager.cs: declare and load enum_type, delegate_type and
16875 * expression.cs (Expression::Emit): Now emit returns a value that
16876 tells whether a value is left on the stack or not. This strategy
16877 might be reveted tomorrow with a mechanism that would address
16878 multiple assignments.
16879 (Expression::report118): Utility routine to report mismatches on
16882 (Unary::Report23): Report impossible type/operator combination
16885 (Unary::IsIncrementableNumber): Whether the type can be
16886 incremented or decremented with add.
16887 (Unary::ResolveOperator): Also allow enumerations to be bitwise
16889 (Unary::ResolveOperator): Implement ++, !, ~,
16891 (Invocation::Emit): Deal with new Emit convetion.
16893 * All Expression derivatives: Updated their Emit method to return
16894 whether they leave values on the stack or not.
16896 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
16897 stack for expressions that are statements.
16899 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16901 * expression.cs (LValue): New interface. Must be implemented by
16903 (LocalVariableReference, ParameterReference, FieldExpr): Implement
16906 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
16907 interface for generating code, simplifies the code.
16909 2001-09-20 Ravi Pratap <ravi@ximian.com>
16911 * expression.cs (everywhere): Comment out return statements in ::Resolve
16912 methods to avoid the warnings.
16914 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16916 * driver.cs (parse): Report error 2001 if we can not open the
16919 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
16922 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
16925 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
16926 otherwise nested blocks end up with the same index.
16928 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
16930 * expression.cs: Instead of having FIXMEs in the Resolve
16931 functions, throw exceptions so it is obvious that we are facing a
16934 * cs-parser.jay (invocation_expression): Pass Location information.
16936 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
16937 Use a basename for those routines because .NET does not like paths
16940 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
16943 2001-09-19 Miguel de Icaza <miguel@ximian.com>
16945 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
16946 are loading the correct data types (throws an exception if not).
16947 (TypeManager::InitCoreTypes): Use CoreLookupType
16949 * expression.cs (Unary::ResolveOperator): return the child
16950 expression for expressions which are just +expr.
16951 (Unary::ResolveOperator): Return negative literals for -LITERAL
16952 expressions (otherwise they are Unary {Literal}).
16953 (Invocation::Badness): Take into account `Implicit constant
16954 expression conversions'.
16956 * literal.cs (LongLiteral): Implement long literal class.
16957 (IntLiteral): export the `Value' of the intliteral.
16959 2001-09-19 Ravi Pratap <ravi@ximian.com>
16961 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
16963 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
16964 instead of 'Operator'
16966 * expression.cs (Binary::ResolveOperator): Update accordingly.
16967 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
16970 * cs-parser.jay (unary_expression): Update to use the new names.
16972 * gen-treedump.cs (GetUnary): Same here.
16974 * expression.cs (Unary::Resolve): Implement.
16975 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
16976 operators are found instead of making noise ;-)
16977 (Unary::ResolveOperator): New method to do precisely the same thing which
16978 Binary::ResolveOperator does for Binary expressions.
16979 (Unary.method, .Arguments): Add.
16980 (Unary::OperName): Implement.
16981 (Unary::ForceConversion): Copy and Paste !
16983 * class.cs (Operator::Define): Fix a small bug for the case when we have
16986 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
16987 for the inbuilt operators. Only overloading works for now ;-)
16989 2001-09-18 Miguel de Icaza <miguel@ximian.com>
16991 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
16992 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
16994 * expression.cs (This::Emit): Implement.
16995 (This::Resolve): Implement.
16996 (TypeOf:Resolve): Implement.
16997 (Expression::ResolveSimpleName): Add an implicit this to instance
16999 (MemberAccess::Resolve): Deal with Parameters and Fields.
17000 Bind instance variable to Field expressions.
17001 (FieldExpr::Instance): New field used to track the expression that
17002 represents the object instance.
17003 (FieldExpr::Resolve): Track potential errors from MemberLookup not
17005 (FieldExpr::Emit): Implement.
17007 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
17008 the last instruction contains a return opcode to avoid generating
17009 the last `ret' instruction (this generates correct code, and it is
17010 nice to pass the peverify output).
17012 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
17013 initializer for static and instance variables.
17014 (Constructor::Emit): Allow initializer to be null in the case of
17015 static constructors. Only emit initializer for instance
17018 (TypeContainer::FindMembers): Return a null array if there are no
17021 Also fix the code for the MemberTypes.Method branch, as it was not
17022 scanning that for operators (or tried to access null variables before).
17024 * assign.cs (Assign::Emit): Handle instance and static fields.
17028 * driver.cs: Stop compilation if there are parse errors.
17030 * cs-parser.jay (constructor_declaration): Provide default base
17031 initializer for non-static constructors.
17032 (constructor_declarator): Do not provide a default base
17033 initializers if none was specified.
17034 Catch the fact that constructors should not have parameters.
17036 * class.cs: Do not emit parent class initializers for static
17037 constructors, that should be flagged as an error.
17039 2001-09-18 Ravi Pratap <ravi@ximian.com>
17041 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
17042 Move back code into TypeContainer::Populate.
17044 2001-09-18 Ravi Pratap <ravi@ximian.com>
17046 * class.cs (TypeContainer::AddConstructor): Fix the check to
17047 compare against Name, not Basename.
17048 (Operator::OpType): Change Plus and Minus to Add and Subtract.
17050 * cs-parser.jay : Update accordingly.
17052 * class.cs (TypeContainer::FindMembers): For the case where we are searching
17053 for methods, don't forget to look into the operators too.
17054 (RegisterMethodBuilder): Helper method to take care of this for
17055 methods, constructors and operators.
17056 (Operator::Define): Completely revamp.
17057 (Operator.OperatorMethod, MethodName): New fields.
17058 (TypeContainer::Populate): Move the registering of builders into
17059 RegisterMethodBuilder.
17060 (Operator::Emit): Re-write.
17062 * expression.cs (Binary::Emit): Comment out code path to emit method
17063 invocation stuff for the case when we have a user defined operator. I am
17064 just not able to get it right !
17066 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17068 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
17071 (Expression::MemberLookup): Provide a version that allows to
17072 specify the MemberTypes and BindingFlags.
17074 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
17075 so it was not fetching variable information from outer blocks.
17077 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
17078 Beforefieldinit as it was buggy.
17080 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
17081 that Ravi put here.
17083 * class.cs (Constructor::Emit): Only emit if block is not null.
17084 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
17085 deal with this by semantically definining it as if the user had
17088 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
17089 constructors as we now "emit" them at a higher level.
17091 (TypeContainer::DefineDefaultConstructor): Used to define the
17092 default constructors if none was provided.
17094 (ConstructorInitializer): Add methods Resolve and Emit.
17096 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
17098 2001-09-17 Ravi Pratap <ravi@ximian.com>
17100 * class.cs (TypeContainer::EmitDefaultConstructor): Register
17101 the default constructor builder with our hashtable for methodbuilders
17104 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
17105 and argument_count is 0 in which case we have a match.
17106 (Binary::ResolveOperator): More null checking and miscellaneous coding
17109 2001-09-17 Ravi Pratap <ravi@ximian.com>
17111 * rootcontext.cs (IsNameSpace): Compare against null.
17113 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
17115 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
17116 and Unary::Operator.
17118 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
17121 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
17122 we have overloaded operators.
17123 (Binary::ResolveOperator): Implement the part which does the operator overload
17126 * class.cs (Operator::Emit): Implement.
17127 (TypeContainer::Emit): Emit the operators we have too.
17129 * expression.cs (Binary::Emit): Update to emit the appropriate code for
17130 the case when we have a user-defined operator.
17132 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17134 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
17136 2001-09-16 Ravi Pratap <ravi@ximian.com>
17138 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
17139 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
17140 (Constructor::Emit): Implement.
17141 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
17142 if we have no work to do.
17143 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
17146 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
17147 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
17149 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
17152 2001-09-15 Ravi Pratap <ravi@ximian.com>
17154 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
17156 (Tree::RecordNamespace): Method to do what the name says ;-)
17157 (Tree::Namespaces): Property to get at the namespaces hashtable.
17159 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
17162 * rootcontext.cs (IsNamespace): Fixed it :-)
17164 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17166 * class.cs (TypeContainer::FindMembers): Add support for
17168 (MethodCore): New class that encapsulates both the shared aspects
17169 of a Constructor and a Method.
17170 (Method, Constructor): Factored pieces into MethodCore.
17172 * driver.cs: Added --fatal which makes errors throw exceptions.
17173 Load System assembly as well as part of the standard library.
17175 * report.cs: Allow throwing exceptions on errors for debugging.
17177 * modifiers.cs: Do not use `parent', instead use the real type
17178 container to evaluate permission settings.
17180 * class.cs: Put Ravi's patch back in. He is right, and we will
17181 have to cope with the
17183 2001-09-14 Ravi Pratap <ravi@ximian.com>
17185 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
17186 FamORAssem, not FamANDAssem.
17188 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17190 * driver.cs: Added --parse option that only parses its input files
17193 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
17194 incorrect. IsTopLevel is not used to tell whether an object is
17195 root_types or not (that can be achieved by testing this ==
17196 root_types). But to see if this is a top-level *class* (not
17197 necessarly our "toplevel" container).
17199 2001-09-14 Ravi Pratap <ravi@ximian.com>
17201 * enum.cs (Enum::Define): Modify to call the Lookup method on the
17202 parent instead of a direct call to GetType.
17204 2001-09-14 Ravi Pratap <ravi@ximian.com>
17206 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
17207 Modifiers.TypeAttr. This should just be a call to that method.
17209 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
17210 object so that we can determine if we are top-level or not.
17212 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
17215 * enum.cs (Enum::Define): Ditto.
17217 * modifiers.cs (FieldAttr): Re-write.
17219 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
17220 (TypeContainer::HaveStaticConstructor): New property to provide access
17221 to precisely that info.
17223 * modifiers.cs (MethodAttr): Re-write.
17224 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
17226 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
17227 of top-level types as claimed.
17229 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17231 * expression.cs (MemberLookup): Fruitless attempt to lookup
17232 constructors. Maybe I need to emit default constructors? That
17233 might be it (currently .NET emits this for me automatically).
17234 (Invocation::OverloadResolve): Cope with Arguments == null.
17235 (Invocation::EmitArguments): new function, shared by the new
17236 constructor and us.
17237 (Invocation::Emit): Handle static and instance methods. Emit
17238 proper call instruction for virtual or non-virtual invocations.
17239 (New::Emit): Implement.
17240 (New::Resolve): Implement.
17241 (MemberAccess:Resolve): Implement.
17242 (MethodGroupExpr::InstanceExpression): used conforming to the spec
17243 to track instances.
17244 (FieldExpr::Resolve): Set type.
17246 * support.cs: Handle empty arguments.
17248 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
17249 SimpleLookup): Auxiliary routines to help parse a qualifier
17252 Update qualifier_identifier rule.
17254 * codegen.cs: Removed debugging messages.
17256 * class.cs: Make this a global thing, this acts just as a "key" to
17257 objects that we might have around.
17259 (Populate): Only initialize method_builders_to_methods once.
17261 * expression.cs (PropertyExpr): Initialize type from the
17264 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17265 Resolve pattern. Attempt to implicitly convert value to boolean.
17268 * expression.cs: Set the type for the int32/int32 argument case.
17269 (Binary::ResolveOperator): Set the return type to boolean for
17270 comparission operators
17272 * typemanager.cs: Remove debugging print code.
17274 (Invocation::Resolve): resolve type.
17276 * class.cs: Allocate a MemberInfo of the correct size, as the code
17277 elsewhere depends on the test to reflect the correct contents.
17279 (Method::) Keep track of parameters, due to System.Reflection holes
17281 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17284 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17285 of the exact size and return that.
17287 (Class::LookupMethodByBuilder): New function that maps
17288 MethodBuilders to its methods. Required to locate the information
17289 on methods because System.Reflection bit us again.
17291 * support.cs: New file, contains an interface ParameterData and
17292 two implementations: ReflectionParameters and InternalParameters
17293 used to access Parameter information. We will need to grow this
17296 * expression.cs (Invocation::GetParameterData): implement a cache
17297 and a wrapper around the ParameterData creation for methods.
17298 (Invocation::OverloadResolve): Use new code.
17300 2001-09-13 Ravi Pratap <ravi@ximian.com>
17302 * class.cs (TypeContainer::EmitField): Remove and move into
17303 (Field::Define): here and modify accordingly.
17304 (Field.FieldBuilder): New member.
17305 (TypeContainer::Populate): Update accordingly.
17306 (TypeContainer::FindMembers): Implement.
17308 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17310 * statement.cs: (VariableInfo::VariableType): New field to be
17311 initialized with the full type once it is resolved.
17313 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17315 * parameter.cs (GetParameterInfo): Use a type cache to compute
17316 things only once, and to reuse this information
17318 * expression.cs (LocalVariableReference::Emit): Implement.
17319 (OpcodeCast::Emit): fix.
17321 (ParameterReference::Resolve): Implement.
17322 (ParameterReference::Emit): Implement.
17324 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17325 that are expressions need to stay as Expressions.
17327 * typemanager.cs (CSharpName): Returns the C# name of a type if
17330 * expression.cs (Expression::ConvertImplicit): New function that
17331 implements implicit type conversions.
17333 (Expression::ImplicitReferenceConversion): Implements implicit
17334 reference conversions.
17336 (EmptyCast): New type for transparent casts.
17338 (OpcodeCast): New type for casts of types that are performed with
17339 a sequence of bytecodes.
17341 (BoxedCast): New type used for casting value types into reference
17342 types. Emits a box opcode.
17344 (Binary::DoNumericPromotions): Implements numeric promotions of
17345 and computation of the Binary::Type.
17347 (Binary::EmitBranchable): Optimization.
17349 (Binary::Emit): Implement code emission for expressions.
17351 * typemanager.cs (TypeManager): Added two new core types: sbyte
17354 2001-09-12 Ravi Pratap <ravi@ximian.com>
17356 * class.cs (TypeContainer::FindMembers): Method which does exactly
17357 what Type.FindMembers does, only we don't have to use reflection. No
17358 implementation yet.
17360 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17361 typecontainer objects as we need to get at them.
17362 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17364 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17365 typecontainer object.
17367 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17368 of just a Report object.
17370 2001-09-11 Ravi Pratap <ravi@ximian.com>
17372 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17374 (TypeContainer::Populate): Now define the delegates of the type too.
17375 (TypeContainer.Delegates): Property to access the list of delegates defined
17378 * delegates.cs (Delegate::Define): Implement partially.
17380 * modifiers.cs (TypeAttr): Handle more flags.
17382 2001-09-11 Ravi Pratap <ravi@ximian.com>
17384 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17386 (Operator::Define): Re-write logic to get types by using the LookupType method
17387 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17388 (Indexer::Define): Ditto.
17389 (Event::Define): Ditto.
17390 (Property::Define): Ditto.
17392 2001-09-10 Ravi Pratap <ravi@ximian.com>
17394 * class.cs (TypeContainer::Populate): Now define operators too.
17395 (TypeContainer.Operators): New property to access the list of operators
17397 (Operator.OperatorMethodBuilder): New member to hold the method builder
17398 for the operator we are defining.
17399 (Operator::Define): Implement.
17401 2001-09-10 Ravi Pratap <ravi@ximian.com>
17403 * class.cs (Event::Define): Make the prefixes of the accessor methods
17404 addOn_ and removeOn_
17406 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17407 of the location being passed in too. Ideally, this should go later since all
17408 error reporting should be done through the Report object.
17410 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17411 (Populate): Iterate thru the indexers we have and define them too.
17412 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17413 for the get and set accessors.
17414 (Indexer::Define): Implement.
17416 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17418 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17419 my previous implementation, did not work.
17421 * typemanager.cs: Add a couple of missing types (the longs).
17423 * literal.cs: Use TypeManager.bool_type instead of getting it.
17425 * expression.cs (EventExpr): New kind of expressions.
17426 (Expressio::ExprClassFromMemberInfo): finish
17428 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17430 * assign.cs: Emit stores to static fields differently.
17432 2001-09-08 Ravi Pratap <ravi@ximian.com>
17434 * Merge in changes and adjust code to tackle conflicts. Backed out my
17435 code in Assign::Resolve ;-)
17437 2001-09-08 Ravi Pratap <ravi@ximian.com>
17439 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17440 instead Report.Error and also pass in the location.
17441 (CSharpParser::Lexer): New readonly property to return the reference
17442 to the Tokenizer object.
17443 (declare_local_variables): Use Report.Error with location instead of plain
17447 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17448 (Operator.CheckBinaryOperator): Ditto.
17450 * cs-parser.jay (operator_declarator): Update accordingly.
17452 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17453 (CheckBinaryOperator): Same here.
17455 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17456 on the name without any prefixes of namespace names etc. This is because we
17457 already might have something already fully qualified like
17458 'System.Console.WriteLine'
17460 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17462 2001-09-07 Ravi Pratap <ravi@ximian.com>
17464 * cs-tokenizer.cs (location): Return a string which also contains
17467 * expression.cs (ElementAccess): New class for expressions of the
17468 type 'element access.'
17469 (BaseAccess): New class for expressions of the type 'base access.'
17470 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17473 * cs-parser.jay (element_access): Implement action.
17474 (base_access): Implement actions.
17475 (checked_expression, unchecked_expression): Implement.
17477 * cs-parser.jay (local_variable_type): Correct and implement.
17478 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17480 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17482 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17483 name and the specifiers.
17485 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17487 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17488 making them all public ;-)
17490 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17493 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17495 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17497 (FieldExpr, PropertyExprs): New resolved expressions.
17498 (SimpleName::MemberStaticCheck): Perform static checks for access
17499 to non-static fields on static methods. Maybe this should be
17500 generalized for MemberAccesses.
17501 (SimpleName::ResolveSimpleName): More work on simple name
17504 * cs-parser.jay (primary_expression/qualified_identifier): track
17505 the parameter index.
17507 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17508 (EmitContext::EmitBoolExpression): Chain to expression generation
17509 instead of temporary hack.
17510 (::EmitStatementExpression): Put generic expression code generation.
17512 * assign.cs (Assign::Emit): Implement variable assignments to
17513 local variables, parameters and fields.
17515 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17517 * statement.cs (Block::GetVariableInfo): New method, returns the
17518 VariableInfo for a variable name in a block.
17519 (Block::GetVariableType): Implement in terms of GetVariableInfo
17521 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17522 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17524 2001-09-06 Ravi Pratap <ravi@ximian.com>
17526 * cs-parser.jay (operator_declaration): Continue on my quest : update
17527 to take attributes argument.
17528 (event_declaration): Ditto.
17529 (enum_declaration): Ditto.
17530 (indexer_declaration): Ditto.
17532 * class.cs (Operator::Operator): Update constructor accordingly.
17533 (Event::Event): Ditto.
17535 * delegate.cs (Delegate::Delegate): Same here.
17537 * enum.cs (Enum::Enum): Same here.
17539 2001-09-05 Ravi Pratap <ravi@ximian.com>
17541 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17543 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17545 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17546 being passed around as an arraylist.
17547 (Attributes::AddAttribute): Method to add attribute sections.
17549 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17550 (struct_declaration): Update accordingly.
17551 (constant_declaration): Update.
17552 (field_declaration): Update.
17553 (method_header): Update.
17554 (fixed_parameter): Update.
17555 (parameter_array): Ditto.
17556 (property_declaration): Ditto.
17557 (destructor_declaration): Ditto.
17559 * class.cs (Struct::Struct): Update constructors accordingly.
17560 (Class::Class): Ditto.
17561 (Field::Field): Ditto.
17562 (Method::Method): Ditto.
17563 (Property::Property): Ditto.
17564 (TypeContainer::OptAttribute): update property's return type.
17566 * interface.cs (Interface.opt_attributes): New member.
17567 (Interface::Interface): Update to take the extra Attributes argument.
17569 * parameter.cs (Parameter::Parameter): Ditto.
17571 * constant.cs (Constant::Constant): Ditto.
17573 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17574 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17575 the attributes as a parameter.
17576 (InterfaceProperty): Update constructor call.
17577 (InterfaceEvent): Ditto.
17578 (InterfaceMethod): Ditto.
17579 (InterfaceIndexer): Ditto.
17581 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17582 pass the attributes too.
17583 (interface_event_declaration): Ditto.
17584 (interface_property_declaration): Ditto.
17585 (interface_method_declaration): Ditto.
17586 (interface_declaration): Ditto.
17588 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17590 * class.cs (Method::Define): Track the "static Main" definition to
17591 create an entry point.
17593 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17594 EntryPoint if we find it.
17596 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17597 (EmitContext::ig): Make this variable public.
17599 * driver.cs: Make the default output file be the first file name
17600 with the .exe extension.
17602 Detect empty compilations
17604 Handle various kinds of output targets. Handle --target and
17605 rename -t to --dumper.
17607 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17608 methods inherited from Expression return now an Expression. This
17609 will is used during the tree rewriting as we resolve them during
17612 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17613 the spec. Missing entirely is the information about
17614 accessability of elements of it.
17616 (Expression::ExprClassFromMemberInfo): New constructor for
17617 Expressions that creates a fully initialized Expression based on
17618 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17621 (Invocation::Resolve): Begin implementing resolution of invocations.
17623 * literal.cs (StringLiteral): Implement Emit.
17625 2001-09-05 Ravi Pratap <ravi@ximian.com>
17627 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17630 2001-09-04 Ravi Pratap <ravi@ximian.com>
17632 * cs-parser.jay (attribute_arguments): Implement actions.
17633 (attribute): Fix bug in production. Implement action.
17634 (attribute_list): Implement.
17635 (attribute_target): Implement.
17636 (attribute_target_specifier, opt_target_specifier): Implement
17637 (CheckAttributeTarget): New method to check if the attribute target
17639 (attribute_section): Implement.
17640 (opt_attributes): Implement.
17642 * attribute.cs : New file to handle attributes.
17643 (Attribute): Class to hold attribute info.
17645 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17646 (attribute_section): Modify production to use 2 different rules to
17647 achieve the same thing. 1 s/r conflict down !
17648 Clean out commented, useless, non-reducing dimension_separator rules.
17650 * class.cs (TypeContainer.attributes): New member to hold list
17651 of attributes for a type.
17652 (Struct::Struct): Modify to take one more argument, the attribute list.
17653 (Class::Class): Ditto.
17654 (Field::Field): Ditto.
17655 (Method::Method): Ditto.
17656 (Property::Property): Ditto.
17658 * cs-parser.jay (struct_declaration): Update constructor call to
17659 pass in the attributes too.
17660 (class_declaration): Ditto.
17661 (constant_declaration): Ditto.
17662 (field_declaration): Ditto.
17663 (method_header): Ditto.
17664 (fixed_parameter): Ditto.
17665 (parameter_array): Ditto.
17666 (property_declaration): Ditto.
17668 * constant.cs (Constant::Constant): Update constructor similarly.
17669 Use System.Collections.
17671 * parameter.cs (Parameter::Parameter): Update as above.
17673 2001-09-02 Ravi Pratap <ravi@ximian.com>
17675 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17676 (TypeContainer.delegates): New member to hold list of delegates.
17678 * cs-parser.jay (delegate_declaration): Implement the action correctly
17679 this time as I seem to be on crack ;-)
17681 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17683 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17684 tell whether an identifier represents a namespace.
17686 * expression.cs (NamespaceExpr): A namespace expression, used only
17687 temporarly during expression resolution.
17688 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17689 utility functions to resolve names on expressions.
17691 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17693 * codegen.cs: Add hook for StatementExpressions.
17695 * class.cs: Fix inverted test for static flag in methods.
17697 2001-09-02 Ravi Pratap <ravi@ximian.com>
17699 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17700 to make it coincide with MS' number.
17701 (Operator::CheckBinaryOperator): Ditto.
17703 * ../errors/errors.txt : Remove error numbers added earlier.
17705 * ../errors/cs1019.cs : Test case for error # 1019
17707 * ../errros/cs1020.cs : Test case for error # 1020
17709 * cs-parser.jay : Clean out commented cruft.
17710 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17711 used anywhere - non-reducing rule.
17712 (namespace_declarations): Non-reducing rule - comment out.
17714 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17715 with TypeContainer::AddEnum.
17717 * delegate.cs : New file for delegate handling classes.
17718 (Delegate): Class for declaring delegates.
17720 * makefile : Update.
17722 * cs-parser.jay (delegate_declaration): Implement.
17724 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17726 * class.cs (Event::Define): Implement.
17727 (Event.EventBuilder): New member.
17729 * class.cs (TypeContainer::Populate): Update to define all enums and events
17731 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17732 readonly fields for all these cases ?
17734 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17736 * class.cs (Property): Revamp to use the convention of making fields readonly.
17737 Accordingly modify code elsewhere.
17739 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17740 the Define method of the Property class.
17742 * class.cs : Clean up applied patch and update references to variables etc. Fix
17744 (TypeContainer::Populate): Update to define all the properties we have. Also
17745 define all enumerations.
17747 * enum.cs (Define): Implement.
17749 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17751 * cs-parser.jay (overloadable_operator): The semantic value is an
17752 enum of the Operator class.
17753 (operator_declarator): Implement actions.
17754 (operator_declaration): Implement.
17756 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17757 validity of definitions.
17758 (Operator::CheckBinaryOperator): Static method to check for binary operators
17759 (TypeContainer::AddOperator): New method to add an operator to a type.
17761 * cs-parser.jay (indexer_declaration): Added line to actually call the
17762 AddIndexer method so it gets added ;-)
17764 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17765 already taken care of by the MS compiler ?
17767 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17769 * class.cs (Operator): New class for operator declarations.
17770 (Operator::OpType): Enum for the various operators.
17772 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17774 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17775 ostensibly handle this in semantic analysis.
17777 * cs-parser.jay (general_catch_clause): Comment out
17778 (specific_catch_clauses, specific_catch_clause): Ditto.
17779 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
17780 (catch_args, opt_catch_args): New productions.
17781 (catch_clause): Rewrite to use the new productions above
17782 (catch_clauses): Modify accordingly.
17783 (opt_catch_clauses): New production to use in try_statement
17784 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
17785 and re-write the code in the actions to extract the specific and
17786 general catch clauses by being a little smart ;-)
17788 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
17789 Hooray, try and catch statements parse fine !
17791 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17793 * statement.cs (Block::GetVariableType): Fix logic to extract the type
17794 string from the hashtable of variables.
17796 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
17797 I end up making that mistake ;-)
17798 (catch_clauses): Fixed gross error which made Key and Value of the
17799 DictionaryEntry the same : $1 !!
17801 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17803 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
17805 * cs-parser.jay (event_declaration): Correct to remove the semicolon
17806 when the add and remove accessors are specified.
17808 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17810 * cs-parser.jay (IndexerDeclaration): New helper class to hold
17811 information about indexer_declarator.
17812 (indexer_declarator): Implement actions.
17813 (parsing_indexer): New local boolean used to keep track of whether
17814 we are parsing indexers or properties. This is necessary because
17815 implicit_parameters come into picture even for the get accessor in the
17816 case of an indexer.
17817 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
17819 * class.cs (Indexer): New class for indexer declarations.
17820 (TypeContainer::AddIndexer): New method to add an indexer to a type.
17821 (TypeContainer::indexers): New member to hold list of indexers for the
17824 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17826 * cs-parser.jay (add_accessor_declaration): Implement action.
17827 (remove_accessor_declaration): Implement action.
17828 (event_accessors_declaration): Implement
17829 (variable_declarators): swap statements for first rule - trivial.
17831 * class.cs (Event): New class to hold information about event
17833 (TypeContainer::AddEvent): New method to add an event to a type
17834 (TypeContainer::events): New member to hold list of events.
17836 * cs-parser.jay (event_declaration): Implement actions.
17838 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17840 * cs-parser.jay (dim_separators): Implement. Make it a string
17841 concatenating all the commas together, just as they appear.
17842 (opt_dim_separators): Modify accordingly
17843 (rank_specifiers): Update accordingly. Basically do the same
17844 thing - instead, collect the brackets here.
17845 (opt_rank_sepcifiers): Modify accordingly.
17846 (array_type): Modify to actually return the complete type string
17847 instead of ignoring the rank_specifiers.
17848 (expression_list): Implement to collect the expressions
17849 (variable_initializer): Implement. We make it a list of expressions
17850 essentially so that we can handle the array_initializer case neatly too.
17851 (variable_initializer_list): Implement.
17852 (array_initializer): Make it a list of variable_initializers
17853 (opt_array_initializer): Modify accordingly.
17855 * expression.cs (New::NType): Add enumeration to help us
17856 keep track of whether we have an object/delegate creation
17857 or an array creation.
17858 (New:NewType, New::Rank, New::Indices, New::Initializers): New
17859 members to hold data about array creation.
17860 (New:New): Modify to update NewType
17861 (New:New): New Overloaded contructor for the array creation
17864 * cs-parser.jay (array_creation_expression): Implement to call
17865 the overloaded New constructor.
17867 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
17869 * class.cs (TypeContainer::Constructors): Return member
17870 constructors instead of returning null.
17872 2001-08-26 Miguel de Icaza <miguel@ximian.com>
17874 * typemanager.cs (InitCoreTypes): Initialize the various core
17875 types after we have populated the type manager with the user
17876 defined types (this distinction will be important later while
17877 compiling corlib.dll)
17879 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
17880 on Expression Classification. Now all expressions have a method
17881 `Resolve' and a method `Emit'.
17883 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
17884 generation from working. Also add some temporary debugging
17887 2001-08-24 Miguel de Icaza <miguel@ximian.com>
17889 * codegen.cs: Lots of code generation pieces. This is only the
17890 beginning, will continue tomorrow with more touches of polish. We
17891 handle the fundamentals of if, while, do, for, return. Others are
17892 trickier and I need to start working on invocations soon.
17894 * gen-treedump.cs: Bug fix, use s.Increment here instead of
17897 * codegen.cs (EmitContext): New struct, used during code
17898 emission to keep a context. Most of the code generation will be
17901 * cs-parser.jay: Add embedded blocks to the list of statements of
17902 this block. So code generation proceeds in a top down fashion.
17904 2001-08-23 Miguel de Icaza <miguel@ximian.com>
17906 * statement.cs: Add support for multiple child blocks.
17908 2001-08-22 Miguel de Icaza <miguel@ximian.com>
17910 * codegen.cs (EmitCode): New function, will emit the code for a
17911 Block of code given a TypeContainer and its ILGenerator.
17913 * statement.cs (Block): Standard public readonly optimization.
17914 (Block::Block constructors): Link children.
17915 (Block::Child): Child Linker.
17916 (Block::EmitVariables): Emits IL variable declarations.
17918 * class.cs: Drop support for MethodGroups here, delay until
17920 (Method::): Applied the same simplification that I did before, and
17921 move from Properties to public readonly fields.
17922 (Method::ParameterTypes): Returns the parameter types for the
17923 function, and implements a cache that will be useful later when I
17924 do error checking and the semantic analysis on the methods is
17926 (Constructor::GetCallingConvention): Renamed from CallingConvetion
17927 and made a method, optional argument tells whether this is a class
17928 or a structure to apply the `has-this' bit.
17929 (Method::GetCallingConvention): Implement, returns the calling
17931 (Method::Define): Defines the type, a second pass is performed
17932 later to populate the methods.
17934 (Constructor::ParameterTypes): implement a cache similar to the
17935 one on Method::ParameterTypes, useful later when we do semantic
17938 (TypeContainer::EmitMethod): New method. Emits methods.
17940 * expression.cs: Removed MethodGroup class from here.
17942 * parameter.cs (Parameters::GetCallingConvention): new method.
17944 2001-08-21 Miguel de Icaza <miguel@ximian.com>
17946 * class.cs (TypeContainer::Populate): Drop RootContext from the
17949 (Constructor::CallingConvention): Returns the calling convention.
17950 (Constructor::ParameterTypes): Returns the constructor parameter
17953 (TypeContainer::AddConstructor): Keep track of default constructor
17954 and the default static constructor.
17956 (Constructor::) Another class that starts using `public readonly'
17957 instead of properties.
17959 (Constructor::IsDefault): Whether this is a default constructor.
17961 (Field::) use readonly public fields instead of properties also.
17963 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
17964 track of static constructors; If none is used, turn on
17965 BeforeFieldInit in the TypeAttributes.
17967 * cs-parser.jay (opt_argument_list): now the return can be null
17968 for the cases where there are no arguments.
17970 (constructor_declarator): If there is no implicit `base' or
17971 `this', then invoke the default parent constructor.
17973 * modifiers.cs (MethodAttr): New static function maps a set of
17974 modifiers flags into a MethodAttributes enum
17975 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
17976 MethodAttr, TypeAttr to represent the various mappings where the
17977 modifiers are used.
17978 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
17980 2001-08-19 Miguel de Icaza <miguel@ximian.com>
17982 * parameter.cs (GetParameterInfo): Fix bug where there would be no
17985 * interface.cs (PopulateIndexer): Implemented the code generator
17986 for interface indexers.
17988 2001-08-17 Miguel de Icaza <miguel@ximian.com>
17990 * interface.cs (InterfaceMemberBase): Now we track the new status
17993 (PopulateProperty): Implement property population. Woohoo! Got
17994 Methods and Properties going today.
17996 Removed all the properties for interfaces, and replaced them with
17997 `public readonly' fields.
17999 2001-08-16 Miguel de Icaza <miguel@ximian.com>
18001 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
18002 initialize their hashtables/arraylists only when they are needed
18003 instead of doing this always.
18005 * parameter.cs: Handle refs and out parameters.
18007 * cs-parser.jay: Use an ArrayList to construct the arguments
18008 instead of the ParameterCollection, and then cast that to a
18011 * parameter.cs: Drop the use of ParameterCollection and use
18012 instead arrays of Parameters.
18014 (GetParameterInfo): Use the Type, not the Name when resolving
18017 2001-08-13 Miguel de Icaza <miguel@ximian.com>
18019 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
18020 and instead use public readonly fields.
18022 * class.cs: Put back walking code for type containers.
18024 2001-08-11 Miguel de Icaza <miguel@ximian.com>
18026 * class.cs (MakeConstant): Code to define constants.
18028 * rootcontext.cs (LookupType): New function. Used to locate types
18031 2001-08-08 Miguel de Icaza <miguel@ximian.com>
18033 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
18034 this System.Reflection code is. Kudos to Microsoft
18036 * typemanager.cs: Implement a type cache and avoid loading all
18037 types at boot time. Wrap in LookupType the internals. This made
18038 the compiler so much faster. Wow. I rule!
18040 * driver.cs: Make sure we always load mscorlib first (for
18041 debugging purposes, nothing really important).
18043 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
18044 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
18046 * rootcontext.cs: Lookup types on their namespace; Lookup types
18047 on namespaces that have been imported using the `using' keyword.
18049 * class.cs (TypeContainer::TypeAttr): Virtualize.
18050 (Class::TypeAttr): Return attributes suitable for this bad boy.
18051 (Struct::TypeAttr): ditto.
18052 Handle nested classes.
18053 (TypeContainer::) Remove all the type visiting code, it is now
18054 replaced with the rootcontext.cs code
18056 * rootcontext.cs (GetClassBases): Added support for structs.
18058 2001-08-06 Miguel de Icaza <miguel@ximian.com>
18060 * interface.cs, statement.cs, class.cs, parameter.cs,
18061 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
18062 Drop use of TypeRefs, and use strings instead.
18064 2001-08-04 Miguel de Icaza <miguel@ximian.com>
18068 * class.cs (Struct::Struct): set the SEALED flags after
18069 checking the modifiers.
18070 (TypeContainer::TypeAttr): new property, returns the
18071 TypeAttributes for a class.
18073 * cs-parser.jay (type_list): Oops, list production was creating a
18074 new list of base types.
18076 * rootcontext.cs (StdLib): New property.
18077 (GetInterfaceTypeByName): returns an interface by type name, and
18078 encapsulates error handling here.
18079 (GetInterfaces): simplified.
18080 (ResolveTree): Encapsulated all the tree resolution here.
18081 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
18084 * driver.cs: Add support for --nostdlib, to avoid loading the
18085 default assemblies.
18086 (Main): Do not put tree resolution here.
18088 * rootcontext.cs: Beginning of the class resolution.
18090 2001-08-03 Miguel de Icaza <miguel@ximian.com>
18092 * rootcontext.cs: Provide better error reporting.
18094 * cs-parser.jay (interface_base): set our $$ to be interfaces.
18096 * rootcontext.cs (CreateInterface): Handle the case where there
18097 are no parent interfaces.
18099 (CloseTypes): Routine to flush types at the end.
18100 (CreateInterface): Track types.
18101 (GetInterfaces): Returns an array of Types from the list of
18102 defined interfaces.
18104 * typemanager.c (AddUserType): Mechanism to track user types (puts
18105 the type on the global type hash, and allows us to close it at the
18108 2001-08-02 Miguel de Icaza <miguel@ximian.com>
18110 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
18111 RecordInterface instead.
18113 * cs-parser.jay: Updated to reflect changes above.
18115 * decl.cs (Definition): Keep track of the TypeBuilder type that
18116 represents this type here. Not sure we will use it in the long
18117 run, but wont hurt for now.
18119 * driver.cs: Smaller changes to accomodate the new code.
18121 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
18124 * rootcontext.cs (CreateInterface): New method, used to create
18125 the System.TypeBuilder type for interfaces.
18126 (ResolveInterfaces): new entry point to resolve the interface
18128 (CodeGen): Property, used to keep track of the code generator.
18130 2001-07-26 Miguel de Icaza <miguel@ximian.com>
18132 * cs-parser.jay: Add a second production for delegate_declaration
18135 (enum_body): Put an opt_comma here instead of putting it on
18136 enum_body or enum_member_declarations so we can handle trailing
18137 commas on enumeration members. Gets rid of a shift/reduce.
18139 (type_list): Need a COMMA in the middle.
18141 (indexer_declaration): Tell tokenizer to recognize get/set
18143 * Remove old targets.
18145 * Re-add the parser target.
18147 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18149 * cs-parser.jay: Add precendence rules for a number of operators
18150 ot reduce the number of shift/reduce conflicts in the grammar.
18152 2001-07-17 Miguel de Icaza <miguel@ximian.com>
18154 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
18157 Get rid of old crufty code.
18159 * rootcontext.cs: Use this to keep track of the parsed
18160 representation and the defined types available to the program.
18162 * gen-treedump.cs: adjust for new convention.
18164 * type.cs: Split out the type manager, and the assembly builder
18167 * typemanager.cs: the type manager will live here now.
18169 * cil-codegen.cs: And the code generator here.
18171 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
18173 * makefile: Fixed up for easy making.
18175 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18177 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
18180 (unary_expression): Expand pre_increment_expression and
18181 post_decrement_expression to reduce a shift/reduce.
18183 2001-07-11 Simon Cozens
18185 * cs-tokenizer.cs: Hex numbers should begin with a 0.
18187 Improve allow_keyword_as_indent name.
18189 2001-06-19 Miguel de Icaza <miguel@ximian.com>
18191 * Adjustments for Beta2.
18193 2001-06-13 Miguel de Icaza <miguel@ximian.com>
18195 * decl.cs: Added `Define' abstract method.
18196 (InTransit): new property, used to catch recursive definitions.
18198 * interface.cs: Implement `Define'.
18200 * modifiers.cs: Map Modifiers.constants to
18201 System.Reflection.TypeAttribute flags.
18203 * class.cs: Keep track of types and user-defined types.
18204 (BuilderInit): New method for creating an assembly
18205 (ResolveType): New function to launch the resolution process, only
18206 used by interfaces for now.
18208 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
18209 that are inserted into the name space.
18211 2001-06-08 Miguel de Icaza <miguel@ximian.com>
18213 * ARGH. I have screwed up my tree so many times due to the use of
18214 rsync rather than using CVS. Going to fix this at once.
18216 * driver.cs: Objetify driver. Load assemblies, use assemblies to
18219 2001-06-07 Miguel de Icaza <miguel@ximian.com>
18221 * Experiment successful: Use System.Type rather that our own
18224 2001-05-25 Miguel de Icaza <miguel@ximian.com>
18226 * cs-parser.jay: Removed nsAliases from here.
18228 Use new namespaces, handle `using XXX;'
18230 * namespace.cs: Reimplemented namespace handling, use a recursive
18231 definition of the class. Now we can keep track of using clauses
18232 and catch invalid using clauses.
18234 2001-05-24 Miguel de Icaza <miguel@ximian.com>
18236 * gen-treedump.cs: Adapted for all the renaming.
18238 * expression.cs (Expression): this class now has a Type property
18239 which returns an expression Type.
18241 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
18242 `Type', as this has a different meaning now in the base
18244 2001-05-22 Miguel de Icaza <miguel@ximian.com>
18246 * interface.cs, class.cs: Removed from all the sources the
18247 references to signature computation, as we can not do method
18248 signature computation during the parsing time, as we are not
18249 trying to solve at that point distinguishing:
18253 void a (NS.Blah x) {}
18256 Which depending on the context might be valid or not, as we do not
18257 know if Blah is the same thing as NS.Blah at that point.
18259 * Redid everything so the code uses TypeRefs now instead of
18260 Types. TypeRefs are just temporary type placeholders, that need
18261 to be resolved. They initially have a pointer to a string and the
18262 current scope in which they are used. This is used later by the
18263 compiler to resolve the reference to an actual Type.
18265 * DeclSpace is no longer a CIR.Type, and neither are
18266 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18267 are all DeclSpaces, but no Types.
18269 * type.cs (TypeRefManager): This implements the TypeRef manager,
18270 which keeps track of all the types that need to be resolved after
18271 the parsing has finished.
18273 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18275 * ARGH. We are going to have to store `foreach' as a class rather
18276 than resolving it, as we need to verify error 1579 after name
18277 resolution. *OR* we could keep a flag that says `This request to
18278 IEnumerator comes from a foreach statement' which we can then use
18279 to generate the error.
18281 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18283 * class.cs (TypeContainer.AddMethod): we now add methods to the
18284 MethodGroup instead of the method hashtable.
18286 * expression.cs: Add MethodGroup abstraction, which gets us one
18287 step closer to the specification in the way we handle method
18290 * cs-parser.jay (primary_expression): qualified_identifier now
18291 tried to match up an identifier to a local variable reference or
18292 to a parameter reference.
18294 current_local_parameters is now a parser global variable that
18295 points to the current parameters for the block, used during name
18298 (property_declaration): Now creates an implicit `value' argument to
18301 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18303 * parameter.cs: Do not use `param' arguments as part of the
18304 signature, per the spec.
18306 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18308 * decl.cs: Base class for classes, structs and interfaces. This
18309 is the "Declaration Space"
18311 * cs-parser.jay: Use CheckDef for checking declaration errors
18312 instead of having one on each function.
18314 * class.cs: Factor out some code for handling error handling in
18315 accordance to the "Declarations" section in the "Basic Concepts"
18316 chapter in the ECMA C# spec.
18318 * interface.cs: Make all interface member classes derive from
18319 InterfaceMemberBase.
18321 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18323 * Many things: all interfaces are parsed and generated in
18324 gen-treedump. Support for member variables, constructors,
18325 destructors, properties, constants is there.
18327 Beginning of the IL backend, but very little done, just there for
18330 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18332 * cs-parser.jay: Fix labeled statement.
18334 * cs-tokenizer.cs (escape): Escape " and ' always.
18335 ref_line, ref_name: keep track of the line/filename as instructed
18336 by #line by the compiler.
18339 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18341 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18342 to match the values in System.CodeDOM.
18344 Divid renamed to Divide.
18346 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18348 (Statements.set): remove.
18350 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18353 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18354 falseStatements always have valid values.
18356 * cs-parser.jay: Use System.CodeDOM now.