1 2010-06-24 Marek Safar <marek.safar@gmail.com>
4 * generic.cs, expression.cs, ecore.cs: Added a new type expression
5 for open generic type to pass unbound type arguments to typeof
8 2010-06-24 Marek Safar <marek.safar@gmail.com>
10 * statement.cs: Foreach collection implementation refactoring to
11 search for GetEnumerator more preciselly. Fixes #431453 and more
14 * linq.cs, decl.cs, ecore.cs, delegate.cs: Update methodgroup api.
16 2010-06-23 Marek Safar <marek.safar@gmail.com>
18 * cs-parser.jay: Track more locations.
20 2010-06-22 Marek Safar <marek.safar@gmail.com>
22 * cs-tokenizer.cs, location.cs, cs-parser.jay: Track more locations.
24 2010-06-18 Marek Safar <marek.safar@gmail.com>
26 * cs-tokenizer.cs, anonymous.cs, expression.cs, statement.cs,
27 support.cs, location.cs, cs-parser.jay: Some work on full ast mode.
29 2010-06-18 Marek Safar <marek.safar@gmail.com>
31 * convert.cs, typespec.cs, method.cs: Fixed few more dynamic
34 2010-06-18 Marek Safar <marek.safar@gmail.com>
36 * typemanager.cs, namespace.cs: Report more predefined types and
37 imported types collision types as a warning.
38 Fixes #537414, #601157
40 2010-06-18 Marek Safar <marek.safar@gmail.com>
42 * generic.cs: Overrides base method constraint can use method type
45 * import.cs: Removed redundant cache.
47 2010-06-17 Marek Safar <marek.safar@gmail.com>
49 * generic.cs: Propagate type only inflate downwards.
51 2010-06-17 Marek Safar <marek.safar@gmail.com>
54 * method.cs: Do not reject binary dynamic operators.
56 2010-06-17 Marek Safar <marek.safar@gmail.com>
58 * typespec.cs: Internal types have no generic parameters.
61 2010-06-17 Marek Safar <marek.safar@gmail.com>
64 * cs-parser.jay: Correctly set expression mode for default parameter
67 2010-06-17 Marek Safar <marek.safar@gmail.com>
70 * ecore.cs: Resolve dynamic namespace and keyword collision in the
71 favour of the keyword.
73 2010-06-17 Marek Safar <marek.safar@gmail.com>
76 * convert.cs: Allow more undocumented 0 like values to enum type
79 2010-06-17 Marek Safar <marek.safar@gmail.com>
81 * generic.cs, method.cs: Inflate copied type parameters from base
82 class or explicit interfaces.
84 * convert.cs: Fixed conversion between two type parameters.
87 2010-06-16 Marek Safar <marek.safar@gmail.com>
89 * membercache.cs, convert.cs: Correctly resize an array used by
92 2010-06-15 Marek Safar <marek.safar@gmail.com>
95 * dynamic.cs, ecore.cs: A new flag for dynamic resolver to ignore
96 generated member access left expression.
98 2010-06-16 Marek Safar <marek.safar@gmail.com>
100 * expression.cs: Dispatch dynamic invocation solely on left
103 2010-06-16 Marek Safar <marek.safar@gmail.com>
105 * expression.cs, statement.cs: Always persist explicit cast
106 semantic at expression level.
108 2010-06-15 Marek Safar <marek.safar@gmail.com>
110 * expression.cs, attribute.cs: Enable generic type parameters
113 2010-06-15 Marek Safar <marek.safar@gmail.com>
115 A fix for bug #612146
116 * generic.cs: Don't use fixed array for inflated type parameter
117 interface constraints.
119 2010-06-15 Marek Safar <marek.safar@gmail.com>
121 * typespec.cs: ElementTypeSpec has to use its own ITypeDefinition.
123 * report.cs: Unwrap elements for related symbols reporting.
125 2010-06-15 Marek Safar <marek.safar@gmail.com>
127 A fix for bug #612796
128 * cs-tokenizer.cs: Offset correctly keywords the first character
131 2010-06-15 Marek Safar <marek.safar@gmail.com>
133 A fix for bug #613397
134 * expression.cs: Removed too aggressive object initializers
137 2010-06-15 Marek Safar <marek.safar@gmail.com>
139 * parameter.cs, property.cs, membercache.cs, decl.cs, iterators.cs,
140 anonymous.cs, expression.cs, support.cs, method.cs, pending.cs,
141 class.cs, cs-parser.jay: Simplify parsing of accessors by removing
142 any intermediate steps and fake nodes, also saves few MBs of memory.
144 2010-06-11 Marek Safar <marek.safar@gmail.com>
146 * modifiers.cs, rootcontext.cs, location.cs, cs-parser.jay: More
147 precise modifiers parsing.
149 2010-06-09 Marek Safar <marek.safar@gmail.com>
151 * cs-tokenizer.cs, anonymous.cs, expression.cs, cs-parser.jay:
152 Fixed few shift/reduce conflicts.
154 2010-06-09 Marek Safar <marek.safar@gmail.com>
156 * typemanager.cs, parameter.cs, dynamic.cs, typespec.cs,
157 expression.cs, ecore.cs, cs-parser.jay: Fully parse composed type
158 specifiers and stop using string in AST.
160 2010-06-07 Marek Safar <marek.safar@gmail.com>
162 * typemanager.cs, eval.cs, iterators.cs, anonymous.cs, expression.cs
163 method.cs, class.cs, delegate.cs, cs-parser.jay, driver.cs, visit.cs
164 enum.cs: Hold location of predefined types.
166 2010-06-07 Marek Safar <marek.safar@gmail.com>
168 A fix for bug #610878
169 * pending.cs: Clone cached list before modifying.
171 2010-06-04 Marek Safar <marek.safar@gmail.com>
173 * convert.cs, typespec.cs, expression.cs: Start using array member
174 kind for better conversion checks.
176 * import.cs, report.cs: Report better error message for runtime
179 2010-06-04 Marek Safar <marek.safar@gmail.com>
181 * membercache.cs, convert.cs, nullable.cs, expression.cs: Optimize
182 user defined conversion probing and simplify user conversion for
183 nullabe types. Fixes #610940.
185 2010-06-03 Marek Safar <marek.safar@gmail.com>
187 A fix for bug #610919
188 * parameter.cs, property.cs, cs-parser.jay: Use independent implicit
189 parameters for explicit event accessors. Anonymous method capturing
190 won't otherwise work for event implicit parameter.
192 2010-06-02 Marek Safar <marek.safar@gmail.com>
194 A fix for bug #610088
195 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs:
196 Ignore overrides for base overload resolution as for non-base
197 expressions and convert the best candidate to closest override
200 2010-06-01 Marek Safar <marek.safar@gmail.com>
202 A fix for bug #610139
203 * generic.cs, convert.cs: Recursively check effective base interface
205 2010-06-01 Marek Safar <marek.safar@gmail.com>
207 * statement.cs: Handle nullable types and type parameters in using
208 statement, avoid boxing value types. Also fixes #571010
210 2010-06-01 Marek Safar <marek.safar@gmail.com>
212 * convert.cs, expression.cs: Emit unbox for underlying nullable
215 2010-05-29 Marek Safar <marek.safar@gmail.com>
217 A fix for bug #610126
218 * expression.cs: Don't use branch optimization for types bigger than
221 2010-05-28 Marek Safar <marek.safar@gmail.com>
223 A fix for bug #609088
224 * import.cs: Check private modifier correctly.
226 2010-05-28 Marek Safar <marek.safar@gmail.com>
228 A fix for bug #609049
229 * ecore.cs: Don't ignore override methods when looking for base
232 2010-05-27 Marek Safar <marek.safar@gmail.com>
234 A fix for bugs #608007, #572540, #566130, #476358
236 * generic.cs, linq.cs, expression.cs, statement.cs, cs-parser.jay:
237 More tricky refactoring of implicit linq blocks.
239 2010-05-25 Marek Safar <marek.safar@gmail.com>
241 * linq.cs, cs-parser.jay: Keep location for all linq clauses.
243 2010-05-25 Marek Safar <marek.safar@gmail.com>
245 * context.cs, expression.cs, cs-parser.jay: Don't store current
246 block in This expression (it's too early for linq blocks).
248 2010-05-21 Marek Safar <marek.safar@gmail.com>
250 * expression.cs: Use constrained prefix more broadly to avoid boxing.
252 2010-05-20 Marek Safar <marek.safar@gmail.com>
254 A fix for bug #591149
255 * nullable.cs: Don't double wrap same expression.
257 2010-05-20 Marek Safar <marek.safar@gmail.com>
259 A fix for bug #569827
260 * anonymous.cs: Any issued error in probing mode means no match.
262 2010-05-20 Marek Safar <marek.safar@gmail.com>
264 * expression.cs: Search for base indexer using the closest match
267 2010-05-20 Marek Safar <marek.safar@gmail.com>
269 A fix for bug #572071
270 * method.cs: Set override constraints using unexpanded interface
273 2010-05-20 Marek Safar <marek.safar@gmail.com>
275 A fix for bug #572071
276 * ecore.cs: Include secondary extension method lookup in probing
279 2010-05-19 Marek Safar <marek.safar@gmail.com>
281 A fix for bug #515801
282 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
285 2010-05-19 Marek Safar <marek.safar@gmail.com>
287 A fix for bug #515801
288 * pending.cs: Advance counter correctly.
290 2010-05-19 Marek Safar <marek.safar@gmail.com>
292 A fix for bug #480139
293 * method.cs, pending.cs: Indexer override uses base name.
295 2010-05-19 Marek Safar <marek.safar@gmail.com>
297 A fix for bug #424064
298 * generic.cs: Replace original with inflated type parameter on
301 2010-05-19 Marek Safar <marek.safar@gmail.com>
303 A fix for bug #359733
304 * parameter.cs: Extension attribute can be defined in each assembly.
306 2010-05-18 Marek Safar <marek.safar@gmail.com>
308 A fix for bug #446507
309 * method.cs: Only one method can implement an interface.
311 2010-05-18 Marek Safar <marek.safar@gmail.com>
313 A fix for bug #594905
314 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
315 Typed null can be used as a source for expression methods.
317 2010-05-18 Marek Safar <marek.safar@gmail.com>
319 A fix for bug #606551
320 * namespace.cs: Using directive imports only types and not nested
323 2010-05-17 Marek Safar <marek.safar@gmail.com>
325 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
326 delegate.cs: Member instance is resolved after member overload
327 definitely resolves static/instance property of member expression.
328 Fixes #545047, #358848, #456605, #460016, #603299
330 2010-05-12 Marek Safar <marek.safar@gmail.com>
332 A fix for bug #604981
333 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
334 details for nested anonymous methods stories.
336 2010-05-11 Marek Safar <marek.safar@gmail.com>
338 A fix for bug #604735
339 * namespace.cs: Don't report namespace collision.
341 2010-05-11 Marek Safar <marek.safar@gmail.com>
343 A fix for bug #604748
344 * class.cs, typespec.cs: Search full imported attribute hierarchy
347 2010-05-11 Marek Safar <marek.safar@gmail.com>
349 * namespace.cs: Ignore missing dependencies failure at
352 2010-05-11 Marek Safar <marek.safar@gmail.com>
354 A fix for bug #604640
355 * namespace.cs: Don't resolve using constraints too early.
357 2010-05-11 Marek Safar <marek.safar@gmail.com>
359 A fix for bug #604239
360 * generic.cs: Copy partial type constraints to partial container.
362 2010-05-10 Marek Safar <marek.safar@gmail.com>
364 A fix for bug #557210
365 * import.cs: Relax underlying enum field rules.
367 2010-05-10 Marek Safar <marek.safar@gmail.com>
369 A fix for bug #603476
370 * property.cs: Implement IParametersMember for indexer accessors.
372 2010-05-07 Marek Safar <marek.safar@gmail.com>
374 A fix for bug #601141
375 * class.cs: Update all partial modifiers.
377 2010-05-06 Marek Safar <marek.safar@gmail.com>
379 A fix for bug #601708
380 * method.cs, membercache.cs: Destructors cannot be hidden.
382 2010-05-06 Marek Safar <marek.safar@gmail.com>
384 A fix for bug #602551
385 * class.cs: Resursive reference of type definition is allowed.
387 2010-05-06 Marek Safar <marek.safar@gmail.com>
389 * anonymous.cs: Mutate cached storey instance types too.
391 2010-05-06 Marek Safar <marek.safar@gmail.com>
393 A fix for bug #602443
394 * convert.cs: Explicit enum conversion cannot involve user operators
396 2010-05-05 Miguel de Icaza <miguel@novell.com>
398 * class.cs (TypeContainer.DefineBaseTypes)
399 (TypeContainer.CheckRecursiveDefinition): check for the iface not
400 being null, as we could have failed resolution and crashed;
403 * cs-parser.jay: Productions to catch common mistakes when other
404 punctuation operators are used instead of comma. Fixes 571702
406 2010-05-05 Marek Safar <marek.safar@gmail.com>
408 * anonymous.cs: Mutate correct set of constraints.
410 2010-05-05 Marek Safar <marek.safar@gmail.com>
412 A fix for bug #602842
413 * expression.cs: Resolve all array bound arguments.
415 2010-05-05 Marek Safar <marek.safar@gmail.com>
417 * import.cs: Don't import private fields.
419 2010-04-30 Marek Safar <marek.safar@gmail.com>
421 Partially based on patch by <sami.lamti@gmail.com>
423 * eval.cs, ecore.cs: Fixed eval show methods.
425 2010-04-30 Marek Safar <marek.safar@gmail.com>
427 * generic.cs, delegate.cs: Implement output type inference of
428 methodgroup now when the specification was cleared at least little
431 2010-04-29 Marek Safar <marek.safar@gmail.com>
433 A fix for bug #575611
434 * class.cs: Fix recursive unmanaged recursice sruct check.
436 2010-04-29 Marek Safar <marek.safar@gmail.com>
438 A fix for bug #479776
439 * expression.cs: Implement typeof unbounded nested generic types.
441 2010-04-29 Marek Safar <marek.safar@gmail.com>
443 A fix for bug #474953
444 * class.cs: Fix valid recursive base type definition.
446 2010-04-29 Marek Safar <marek.safar@gmail.com>
448 A fix for bug #421737
449 * convert.cs, expression.cs: A boxing conversion exists from a
450 nullable-type to a reference type, if a boxing conversion exists
451 from the underlying non-nullable-value-type to the reference type.
453 2010-04-29 Marek Safar <marek.safar@gmail.com>
455 A fix for bug #376875
456 * import.cs: Import volatile modifier.
458 2010-04-29 Marek Safar <marek.safar@gmail.com>
460 A fix for bug #372412
461 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
464 2010-04-29 Marek Safar <marek.safar@gmail.com>
466 A fix for bug #568955
467 * statements.cs: Handle recursive scope initializers.
469 2010-04-28 Marek Safar <marek.safar@gmail.com>
471 A fix for bug #566511
472 * anonymous.cs: Always get inflated version of hoisted variable
473 on generic type definition.
475 2010-04-28 Marek Safar <marek.safar@gmail.com>
477 * import.cs, membercache.cs: Relax rules for valid properties.
479 2010-04-28 Marek Safar <marek.safar@gmail.com>
481 * import.cs: Intern arrays used in generic arguments.
483 2010-04-28 Marek Safar <marek.safar@gmail.com>
485 A fix for bug #600398
486 * convert.cs: Actually use effective base type for the comparison.
488 2010-04-28 Marek Safar <marek.safar@gmail.com>
490 A fix for bug #600326
491 * ecore.cs: Pass arity to base member lookup.
493 2010-04-28 Marek Safar <marek.safar@gmail.com>
495 A fix for bug #573385
496 * expression.cs: MemberAccess is of generic type based on right
499 2010-05-28 Marek Safar <marek.safar@gmail.com>
501 * cs-tokenizer.cs: Made tab size configurable.
503 2010-05-27 Marek Safar <marek.safar@gmail.com>
505 * attribute.cs: Ensure Obsolete members are defined before doing
508 2010-05-27 Marek Safar <marek.safar@gmail.com>
510 * visit.cs: Add DOM visitor skeleton.
514 2010-05-27 Marek Safar <marek.safar@gmail.com>
516 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
518 2010-05-27 Marek Safar <marek.safar@gmail.com>
520 * *.cs: Major rewrite of compiler internals to better work with
521 unmodified System.Reflection.Emit. Some of the key changes are
522 - TypeSpec replaces reflection specific System.Type.
523 - All Type(TypeSpec) operations are now done in compiler therefore
524 no dependency on SRE to inflate generic members and types or to
525 query unclosed types.
526 - MemberCache is now the only and full hierarchical topology.
527 - Generic constraints are implemented properly.
528 - And as a bonus compilation is on average 30% faster.
530 2010-04-15 Jb Evain <jbevain@novell.com>
532 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
534 2010-04-12 Marek Safar <marek.safar@gmail.com>
536 * expression.cs, attribute.cs, parameter.cs: More attribute type
539 2010-04-12 Marek Safar <marek.safar@gmail.com>
541 A fix for bug #593342
543 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
544 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
545 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
546 codegen.cs: Add custom attribute encoder to deal with unfinished
547 types and easier corlib bootstrap from its own types.
549 2010-03-26 Marek Safar <marek.safar@gmail.com>
551 * cs-parser.jay: Report invalid constraint types.
553 2010-03-16 Jb Evain <jbevain@novell.com>
555 * Makefile: rename the net_2_1 profile to moonlight.
557 2010-03-11 Marek Safar <marek.safar@gmail.com>
559 * statement.cs, cs-parser.jay: Use correct location for empty
562 2010-03-11 Marek Safar <marek.safar@gmail.com>
564 * cs-parser.jay: Disable Location from expression.
566 * generic.cs: Check constraints for overrides in the parser.
568 2010-03-09 Marek Safar <marek.safar@gmail.com>
570 * cs-parser.jay (GetLocation): Use an expression when available.
572 2010-03-04 Marek Safar <marek.safar@gmail.com>
574 A fix for bug #582579
575 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
577 2010-03-04 Marek Safar <marek.safar@gmail.com>
579 A patch by kornelpal@gmail.com
581 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
582 compiler generated classes sealed by default. Emit and close top
583 level compiler generated classes as well.
585 * support.cs: Use RuntimeHelpers.GetHashCode.
587 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
589 * Makefile: We need to use the internal bootstrapping gmcs for
590 net_2_1_bootstrap too now.
592 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
594 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
596 2010-03-02 Marek Safar <marek.safar@gmail.com>
598 * cs-tokenizer.cs: Missed few locations in previous fix.
600 2010-03-02 Marek Safar <marek.safar@gmail.com>
602 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
603 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
604 Report correct location for operator errors.
606 2010-03-02 Marek Safar <marek.safar@gmail.com>
608 * typemanager.cs (IsDynamicType): Don't check external types when
609 the attribute is not external.
611 2010-02-24 Marek Safar <marek.safar@gmail.com>
613 A fix for bug #582579
614 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
617 2010-02-24 Marek Safar <marek.safar@gmail.com>
619 A fix for bug #581804
620 * ecore.cs: Fixed type comparison.
622 2010-02-08 Miguel de Icaza <miguel@novell.com>
624 * namespace.cs (CompletionGetTypesStartingWith): Do not include
625 private types in the completion results.
627 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
630 2010-02-17 Marek Safar <marek.safar@gmail.com>
632 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
635 2010-02-14 Miguel de Icaza <miguel@novell.com>
637 * eval.cs: Do not do the report printer dance unless the user has
638 set the DescribeTypes feature.
640 2010-02-10 Marek Safar <marek.safar@gmail.com>
642 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
644 2010-02-08 Marek Safar <marek.safar@gmail.com>
646 A fix for bug #577029
647 * anonymous.cs: Fixed TypeBuilder* check.
649 2010-02-06 Miguel de Icaza <miguel@novell.com>
651 * eval.cs (CompileBlock): Also undo if there are problems during
652 semantic analysis, fixes various cases where invalid C# code would
653 be reported, but the internal changes would not be undone.
655 2010-02-03 Miguel de Icaza <miguel@novell.com>
657 * driver.cs: Change the --fatal flag to allow a number to be
658 passed, this ignores the first N fatal errors. Useful to debug
659 errors that do not happen on the first hit.
661 * cs-parser.jay (invocation_expression): accept both the
662 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
663 inside an invocation.
665 * driver.cs: Expose FatalErrors.
667 * eval.cs: Initialize the printer's Fatal property from the
668 Driver's FatalError flag, this allows csharp --fatal to work
671 Add support for calling Describe (typeof (TYPE)) if the expression
674 2010-02-02 Marek Safar <marek.safar@gmail.com>
676 A fix for bug #574991
677 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
680 2010-02-02 Marek Safar <marek.safar@gmail.com>
682 A fix for bug #575986
683 * expression.cs: Don't mutate typeof type definitions.
685 2010-01-28 Marek Safar <marek.safar@gmail.com>
687 * decl.cs: Use only one set of modifiers.
689 2010-01-26 Marek Safar <marek.safar@gmail.com>
691 A fix for bug #573329
692 * eval.cs: Don't disable error reporting completely on silent mode.
694 2010-01-25 Marek Safar <marek.safar@gmail.com>
696 A fix for bug #573312
697 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
698 pointer index of unknown size types greater than 2.
700 2010-01-15 Marek Safar <marek.safar@gmail.com>
702 * *.cs: Use only 1 member kind enum.
704 2010-01-15 Marek Safar <marek.safar@gmail.com>
706 * *.cs: Add event specification.
708 2010-01-14 Marek Safar <marek.safar@gmail.com>
710 * membercache.cs: Extracted from decl.cs.
712 * *.cs: Put more infrastructure in place.
714 2010-01-13 Marek Safar <marek.safar@gmail.com>
716 * *.cs: Add property specification, unused yet.
718 2010-01-13 Marek Safar <marek.safar@gmail.com>
720 * property.cs: Move all property based declarations into a new file.
722 2010-01-13 Marek Safar <marek.safar at gmail.com>
724 * expression.cs (Conditional): Resolve reduced expression.
726 2010-01-13 Marek Safar <marek.safar at gmail.com>
728 * *.cs: Introduced non-generic method specification.
730 2010-01-07 Marek Safar <marek.safar@gmail.com>
732 * method.cs: Move all method based declarations into a new file.
734 2010-01-07 Marek Safar <marek.safar@gmail.com>
736 * *.cs: Extract field specification.
738 2009-12-17 Marek Safar <marek.safar@gmail.com>
740 * field.cs: Extracted from class.cs
742 2009-12-15 Marek Safar <marek.safar@gmail.com>
744 * attribute.cs (GetFixedBuffer): Work on field definition only.
746 2009-12-15 Marek Safar <marek.safar@gmail.com>
748 * *.cs: Clean up NET_4_0 conditional where possible.
750 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
752 support.cs (DynamicType): Assembly property returns the assembly builder.
753 This is required due to how compiler context works in corlib.
755 2009-12-14 Marek Safar <marek.safar@gmail.com>
757 A fix for bug #564376
758 * assign.cs (LocalTemporary): Removed no longer needed special
761 2009-12-11 Marek Safar <marek.safar@gmail.com>
763 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
764 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
765 enum for easier debugging.
767 2009-12-10 Marek Safar <marek.safar@gmail.com>
769 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
772 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
775 2009-12-10 Marek Safar <marek.safar@gmail.com>
777 * cs-parser.jay, statement.cs: Handle parser error in code
780 2009-12-10 Marek Safar <marek.safar@gmail.com>
782 * ecore.cs: Ignore base imported methods when they are already
785 * eval.cs: Handle non-existent keys.
787 * report.cs, driver.cs: Make fatal work with console printer only.
789 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
791 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
793 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
795 * typemanager.cs: Add MakeGenericMethod that checks if the method
796 is really the generic method definition.
798 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
799 to inflate generic methods.
801 2009-12-08 Marek Safar <marek.safar@gmail.com>
803 A fix for bug #561149
804 * anonymous.cs: Use actual type parameters when checking for generic
807 2009-12-08 Marek Safar <marek.safar@gmail.com>
809 A fix for bug #561369
810 * expression.cs (DoNumericPromotion): Fixed typo.
812 2009-12-08 Marek Safar <marek.safar@gmail.com>
814 *.cs: Moving to generics world.
816 cs-parser.jay: Removed current_array_type.
818 2009-12-07 Marek Safar <marek.safar@gmail.com>
820 *.cs: Moving to generics world.
822 2009-12-04 Marek Safar <marek.safar@gmail.com>
824 *.cs: Moving to generics world (day 2).
826 2009-12-03 Marek Safar <marek.safar@gmail.com>
828 *.cs: Moving to generics world.
830 2009-12-02 Marek Safar <marek.safar@gmail.com>
832 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
833 Encode dynamic type attribute for elements where attributes cannot
836 2009-12-01 Marek Safar <marek.safar@gmail.com>
838 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
841 2009-12-01 Marek Safar <marek.safar@gmail.com>
843 A fix for bug #360455
844 * class.cs: Never report a unused warning for generic events to
845 workaround wrong expression type.
847 2009-11-30 Marek Safar <marek.safar@gmail.com>
849 A fix for bug #558305
850 * decl.cs, class.cs: Check partial method definitions using correct
853 2009-11-30 Marek Safar <marek.safar@gmail.com>
855 * argument.cs: Don't cache rarely used dynamic flag.
857 2009-11-27 Marek Safar <marek.safar@gmail.com>
859 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
861 2009-11-27 Marek Safar <marek.safar@gmail.com>
863 * ecore.cs (SimpleName): Removed no longer needed in_transit as
864 Resolve is now non-reentrant (saves ~0.6MB for corlib).
866 2009-11-26 Marek Safar <marek.safar@gmail.com>
868 A fix for bug #545081
869 * decl.cs: Check private nested types of nested types recursively.
871 2009-11-26 Marek Safar <marek.safar@gmail.com>
873 A fix for bug #558305
874 * location.cs: Ignore self referencing #line directive
876 2009-11-26 Marek Safar <marek.safar@gmail.com>
878 A fix for bug #558292
879 * class.cs: Allow single unsafe fixed buffer fields.
881 2009-11-26 Marek Safar <marek.safar@gmail.com>
883 * expression: Optimize few more zero-based operations.
885 2009-11-26 Marek Safar <marek.safar@gmail.com>
887 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
888 avoids boxing of literal values.
890 2009-11-26 Marek Safar <marek.safar@gmail.com>
892 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
893 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
894 codegen.cs: LocatedToken redesing to avoid excessive allocation and
895 boxing (saves ~7MB for corlib). Also fixes presise token location.
897 2009-11-25 Marek Safar <marek.safar@gmail.com>
899 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
902 2009-11-24 Marek Safar <marek.safar@gmail.com>
904 * expression.cs: Lower static array initializer barrier.
906 * support.cs, driver.cs: Share reader buffer.
908 2009-11-23 Marek Safar <marek.safar@gmail.com>
910 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
912 2009-11-23 Marek Safar <marek.safar@gmail.com>
914 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
915 cleanup some obsolete code.
917 2009-11-20 Marek Safar <marek.safar@gmail.com>
919 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
922 2009-11-20 Marek Safar <marek.safar@gmail.com>
924 * *.cs: Resolved expressions are never resolved again, this helps to
925 uncover some not easy to find bugs and improve the performance.
927 2009-11-19 Marek Safar <marek.safar@gmail.com>
929 * *.cs: Made constant expressions fully compatible with any other
932 2009-11-19 Marek Safar <marek.safar@gmail.com>
934 * *.cs: DoResolve is a worker method and has to be protected.
936 2009-11-18 Marek Safar <marek.safar@gmail.com>
938 * *.cs: More context specific handling.
940 2009-11-17 Marek Safar <marek.safar@gmail.com>
942 * *.cs: More context specific handling.
944 2009-11-16 Marek Safar <marek.safar@gmail.com>
946 * dynamic.cs, class.cs: Removed few fixed user types conversions.
948 * symbolwriter.cs: Uses public ILOffset.
950 2009-11-13 Marek Safar <marek.safar@gmail.com>
952 A fix for bug #553650
953 * generic.cs: Another missing TypeToCoreType, still too many to fix.
955 2009-11-13 Marek Safar <marek.safar@gmail.com>
957 A fix for bug #555170
959 * class.cs, delegate.cs, enum.cs: Constants have to be available
960 for parameters resolve.
962 2009-11-12 Marek Safar <marek.safar@gmail.com>
964 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
967 2009-11-12 Marek Safar <marek.safar@gmail.com>
969 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
970 with a statically known candidate set.
972 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
974 * generic.cs: Made type inflation for generic constraint checks
975 recursive. This fixes BGO #553655.
977 2009-11-11 Marek Safar <marek.safar@gmail.com>
979 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
982 2009-11-10 Marek Safar <marek.safar@gmail.com>
984 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
985 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
986 attribute.cs: Add some dynamic error checking.
988 2009-11-07 Marek Safar <marek.safar@gmail.com>
990 A fix for bug #553465
992 * expression.cs: Fixed mixed version of expression tree anonymous
995 2009-11-06 Marek Safar <marek.safar@gmail.com>
997 A fix for bug #553031
999 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
1000 expression tree version of anonymous type with members declaration.
1002 2009-11-05 Marek Safar <marek.safar@gmail.com>
1004 * parameter.cs: Handle nullable parameter default expression.
1006 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
1007 class.cs, attribute.cs: Check for wrong dynamic arguments.
1009 2009-11-05 Marek Safar <marek.safar@gmail.com>
1011 * statement.cs: Dynamic statements.
1013 2009-11-04 Marek Safar <marek.safar@gmail.com>
1015 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
1016 Compound assignments over dynamic type.
1018 2009-11-03 Marek Safar <marek.safar@gmail.com>
1020 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
1021 constructor arguments.
1023 2009-10-30 Marek Safar <marek.safar@gmail.com>
1025 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
1026 codegen.cs: Unary mutator on dynamic member access expression.
1028 2009-10-29 Marek Safar <marek.safar@gmail.com>
1030 A fix for bug #550580
1031 * convert.cs: Don't eliminate explicit precission casts.
1033 2009-10-28 Marek Safar <marek.safar@gmail.com>
1035 A fix for bug #550404
1037 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
1038 expression.cs, statement.cs, ecore.cs: Quote any nested expression
1041 2009-10-27 Marek Safar <marek.safar@gmail.com>
1043 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
1046 * class.cs: Allow nullable binary user operators.
1048 2009-10-26 Marek Safar <marek.safar@gmail.com>
1050 * expression.cs: Move binary expression optimization at the end of
1053 2009-10-23 Marek Safar <marek.safar@gmail.com>
1055 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
1056 Separate NullConstant from NullLiteral.
1058 2009-10-23 Marek Safar <marek.safar@gmail.com>
1060 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
1061 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
1062 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
1063 ModuleContainer. Add common unclosed member check routine.
1065 2009-10-22 Marek Safar <marek.safar@gmail.com>
1067 * argument.cs: Use literal flag for real literals only.
1069 * dynamic.cs: Use correct return type for custom delegates.
1071 2009-10-22 Marek Safar <marek.safar@gmail.com>
1073 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
1076 2009-10-22 Marek Safar <marek.safar@gmail.com>
1078 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
1080 2009-10-21 Marek Safar <marek.safar@gmail.com>
1082 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
1085 2009-10-21 Marek Safar <marek.safar@gmail.com>
1087 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
1090 2009-10-20 Marek Safar <marek.safar@gmail.com>
1092 * argument.cs, dynamic.cs, expression.cs: Latest API update.
1094 2009-10-19 Marek Safar <marek.safar@gmail.com>
1096 * typemanager.cs, expression.cs: Dynamic array initializer.
1098 2009-10-16 Marek Safar <marek.safar@gmail.com>
1100 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
1103 2009-10-16 Marek Safar <marek.safar@gmail.com>
1105 A fix for bug #493523, #507067
1106 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
1107 standard nullable conversion using underlying standard conversion
1108 and not full conversion.
1110 2009-10-15 Marek Safar <marek.safar@gmail.com>
1112 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
1113 type in VerifyArgumentsCompat.
1115 2009-10-15 Marek Safar <marek.safar@gmail.com>
1117 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1118 Reject variable used with type arguments.
1120 2009-10-14 Marek Safar <marek.safar@gmail.com>
1122 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
1123 Implement dynamic expressions assignment.
1125 2009-10-14 Marek Safar <marek.safar@gmail.com>
1127 * expression.cs: Build underlying expression when resolving unary
1130 2009-10-14 Marek Safar <marek.safar@gmail.com>
1132 * expression.cs: Emit enum array initializer using binary blob.
1134 2009-10-08 Marek Safar <marek.safar@gmail.com>
1136 * typemanager.cs, constant.cs: Optimize decimal constants which fit
1139 2009-10-07 Marek Safar <marek.safar@gmail.com>
1141 * typemanager.cs: Reset object_type.
1143 * assign: Made SimpleAssign public.
1145 2009-10-06 Marek Safar <marek.safar@gmail.com>
1147 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
1148 invocation assembly to IsThisOrFriendAssembly.
1150 2009-10-05 Marek Safar <marek.safar@gmail.com>
1152 * expression.cs: Equality comparison of generic parameter with
1155 2009-10-05 Marek Safar <marek.safar@gmail.com>
1157 A fix for bug #543570
1158 * generic.cs: Import predefined constraints correctly.
1160 2009-10-02 Marek Safar <marek.safar@gmail.com>
1162 * ecore.cs: Don't crash on overloads with optional paremeters where
1163 arguments count overflows.
1165 * parameter.cs: Import optional parameter constants using optional
1168 2009-10-01 Marek Safar <marek.safar@gmail.com>
1170 * Makefile: Default is gmcs compiler.
1172 2009-10-01 Marek Safar <marek.safar@gmail.com>
1174 * cs-parser.jay: Fixed few NRE.
1176 2009-10-01 Marek Safar <marek.safar@gmail.com>
1178 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
1180 2009-09-30 Marek Safar <marek.safar@gmail.com>
1182 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
1183 ShimExpression, ImplicitCast.
1185 2009-09-30 Marek Safar <marek.safar@gmail.com>
1187 A fix for bug #542959
1188 * delegate.cs: Emit correct delegate instance variable when there
1189 are static and non-static overloads.
1191 2009-09-29 Marek Safar <marek.safar@gmail.com>
1193 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
1194 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
1196 2009-09-28 Marek Safar <marek.safar@gmail.com>
1198 A fix for bug #542487
1199 * ecore.cs: Resolve extension methods hidden by properties.
1201 2009-09-25 Marek Safar <marek.safar@gmail.com>
1203 * expression.cs, ecore.cs: More dynamic binary expressions.
1205 2009-09-22 Marek Safar <marek.safar@gmail.com>
1207 * nullable.cs, expression.cs: Fixed null lifted conversion for
1208 bitwise enum operations.
1210 2009-09-22 Marek Safar <marek.safar@gmail.com>
1212 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
1213 values in checked context.
1215 2009-09-22 Marek Safar <marek.safar@gmail.com>
1217 * expression.cs, ecore.cs: Fixed array index constant conversion.
1219 2009-09-20 Miguel de Icaza <miguel@novell.com>
1221 * expression.cs: Do not crash when MemberLookup returns something
1222 that is not a MemberExpr here. Report error 582 instead.
1226 2009-09-18 Marek Safar <marek.safar@gmail.com>
1228 * decl.cs, class.cs: Check protected property accessors.
1230 2009-09-18 Marek Safar <marek.safar@gmail.com>
1232 * dynamic.cs, assign.cs: Dynamic compound assignment.
1234 2009-09-17 Marek Safar <marek.safar@gmail.com>
1236 * expression.cs: Fixed compound assignment explicit conversion.
1238 2009-09-17 Marek Safar <marek.safar@gmail.com>
1240 * expression.cs, ecore.cs: Cannot infer variables from method group.
1242 2009-09-16 Marek Safar <marek.safar@gmail.com>
1244 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
1245 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
1246 codegen.cs: Dynamic binary operations scaffolding.
1248 2009-09-15 Marek Safar <marek.safar@gmail.com>
1250 * expression.cs: Fixes nullable promotion for enum type variables.
1252 2009-09-11 Marek Safar <marek.safar@gmail.com>
1254 * driver.cs, dynamic.cs: Reset more static variables.
1256 2009-09-11 Marek Safar <marek.safar@gmail.com>
1258 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1259 driver.cs: Introduced Expression::MakeExpression.
1261 2009-09-11 Marek Safar <marek.safar@gmail.com>
1263 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1265 2009-09-09 Marek Safar <marek.safar@gmail.com>
1267 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1270 2009-09-09 Marek Safar <marek.safar@gmail.com>
1272 A fix for bug #518707
1273 * expression.cs (Is): Optimize only generic parameter type
1274 expression probing value type generic parameter.
1276 2009-09-09 Marek Safar <marek.safar@gmail.com>
1278 A fix for bug #532571
1279 * ecore.cs: Check for simple name type arguments used with
1282 2009-09-08 Marek Safar <marek.safar@gmail.com>
1284 A fix for bug #497421
1285 * generic.cs (CheckConstraint): Don't use buildin types to check for
1286 parameterless constructor.
1288 2009-09-08 Marek Safar <marek.safar@gmail.com>
1290 A fix for bug #537402
1291 * generic.cs (CheckConstraint): Correctly inflate generic type
1292 arguments when checking generic method.
1294 2009-09-08 Marek Safar <marek.safar@gmail.com>
1296 A fix for bug #536463
1297 * decl.cs (AddToContainer): Don't report collision between explicit
1298 and parameterless non-explicit members.
1300 2009-09-08 Marek Safar <marek.safar@gmail.com>
1302 * eval.cs: Reset more static stuff.
1304 2009-09-07 Marek Safar <marek.safar@gmail.com>
1306 A fix for bug #324625
1307 * expression.cs, ecore.cs: Create nested generic type expression
1308 using declaring and not current type.
1310 2009-09-07 Marek Safar <marek.safar@gmail.com>
1312 * *.cs: Changed Report class to accept various output printers and
1313 be an instance class. An expression resolver can now use different
1314 message reporter for each call and Report.Error can safely throw
1315 an exception. Part of ongoing work to turn mcs into proper library.
1317 2009-09-04 Marek Safar <marek.safar@gmail.com>
1319 * statement.cs, ecore.cs: Removed error reporting from emit code.
1321 2009-09-04 Marek Safar <marek.safar@gmail.com>
1323 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1325 2009-09-03 Marek Safar <marek.safar@gmail.com>
1327 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1328 parser checks out of constructors.
1330 2009-09-02 Marek Safar <marek.safar@gmail.com>
1332 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1334 2009-09-02 Marek Safar <marek.safar@gmail.com>
1336 A fix for bug #535448
1337 * anonymous.cs, class.cs: Copy return label between all contexts.
1339 2009-09-02 Marek Safar <marek.safar@gmail.com>
1341 A fix for bug #535395
1342 * namespace.cs: Resolve context can be null.
1344 2009-08-25 Marek Safar <marek.safar@gmail.com>
1346 A fix for bug #533912
1347 * generic.cs: Use correct context for constraints resolving.
1349 2009-08-25 Marek Safar <marek.safar@gmail.com>
1351 A fix for bug #532630
1352 * driver.cs: Trim conditional symbols.
1354 2009-08-25 Marek Safar <marek.safar@gmail.com>
1356 * context.cs: New file.
1358 * *.exe.sources, *.csproj: Updated.
1360 2009-08-25 Marek Safar <marek.safar@gmail.com>
1362 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1363 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1364 IMembercontext, some small cleanups.
1366 2009-08-24 Marek Safar <marek.safar@gmail.com>
1368 * *.cs: Split ResolveContext and EmitContext.
1370 2009-08-24 Marek Safar <marek.safar@gmail.com>
1372 * *.cs: Only ResolveContext implements IMemberContext.
1374 2009-08-21 Marek Safar <marek.safar@gmail.com>
1376 * *.cs: Renamed IResolveContext to IMemberContext.
1378 2009-08-21 Marek Safar <marek.safar@gmail.com>
1380 * *.cs: Detached ResolveContext from EmitContext.
1382 2009-08-21 Marek Safar <marek.safar@gmail.com>
1384 * codegen.cs: Moved flow-analysis to BlockContext.
1386 2009-08-21 Marek Safar <marek.safar@gmail.com>
1388 * *.cs: Detached BlockContext from EmitContext.
1390 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1392 * statement.cs: avoid nullref when the return value of GetEnumerator()
1393 does not contain any MoveNext() method.
1395 2009-08-19 Marek Safar <marek.safar@gmail.com>
1397 * *.cs: Removed IResolveContext::GenericDeclContainer.
1399 2009-08-19 Marek Safar <marek.safar@gmail.com>
1401 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1403 2009-08-19 Marek Safar <marek.safar@gmail.com>
1405 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1406 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1408 2009-08-18 Marek Safar <marek.safar@gmail.com>
1410 * *.cs: Removed boolean fields from EmitContext.
1412 2009-08-18 Marek Safar <marek.safar@gmail.com>
1414 * *.cs: Add IResolveContext::IsStatic.
1416 2009-08-18 Marek Safar <marek.safar@gmail.com>
1418 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1420 2009-08-17 Marek Safar <marek.safar@gmail.com>
1422 * *.cs: Removed DeclContainer from EmitContext.
1424 2009-08-17 Marek Safar <marek.safar@gmail.com>
1426 * *.cs: Add IResolveContext::CurrentTypeParameters.
1428 2009-08-14 Marek Safar <marek.safar@gmail.com>
1430 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1432 2009-08-14 Marek Safar <marek.safar@gmail.com>
1434 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1435 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1437 2009-08-13 Marek Safar <marek.safar@gmail.com>
1439 * decl.cs: Look in PartialContainer for parent type parameters.
1441 2009-08-13 Marek Safar <marek.safar@gmail.com>
1443 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1444 codegen.cs: Add IResolveContext::LookupTypeParameter.
1446 2009-08-13 Marek Safar <marek.safar@gmail.com>
1448 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1449 Moved resolved logic from Emit to Resolve.
1451 2009-08-13 Marek Safar <marek.safar@gmail.com>
1453 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1454 codegen.cs: Reworked atttributes handling of ResolveContext.
1456 2009-08-12 Marek Safar <marek.safar@gmail.com>
1458 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1459 LookupNamespaceOrType to ResolveContext.
1461 2009-08-12 Marek Safar <marek.safar@gmail.com>
1463 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1464 class.cs: Removed unused parameters and methods.
1466 2009-08-11 Marek Safar <marek.safar@gmail.com>
1468 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1469 codegen.cs: Finding the best common type of a set of expressions for
1472 2009-08-07 Marek Safar <marek.safar@gmail.com>
1474 * dynamic.cs, expression.cs: More dynamic conversions.
1476 2009-08-06 Miguel de Icaza <miguel@novell.com>
1478 * generic.cs: This loop was incorrect, it was increment ii, but
1479 checking for `i'. This was a change introduced to fix #327497,
1482 * class.cs: Catch another case for cs0533 error, fixes #324782.
1484 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1486 * typemanager.cs (GetGenericArguments): SRE returns null for
1487 generic methods on type builder instances if they are not generic
1488 themselves. For example, for Foo<int>::Bar() it returns null, but
1489 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1491 2009-08-05 Marek Safar <marek.safar@gmail.com>
1493 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1494 delegate.cs: Work on dynamic binding.
1496 2009-08-04 Marek Safar <marek.safar@gmail.com>
1498 A second fix for bug #525342
1499 * class.cs: Attach partial method attributes to method
1502 2009-08-03 Marek Safar <marek.safar@gmail.com>
1504 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1507 * rootcontext.cs: Default to langversion v4.
1509 2009-08-03 Marek Safar <marek.safar@gmail.com>
1511 * pending.cs: Check return type before member info is set.
1513 2009-08-03 Marek Safar <marek.safar@gmail.com>
1515 * anonymous.cs: Fully initialize generic hoisted field expression.
1517 2009-08-02 Miguel de Icaza <miguel@novell.com>
1519 * cs-parser.jay: Flag variables declared on the interactive shell
1520 as used to prevent the 168 warning about local variable not being
1523 2009-07-31 Marek Safar <marek.safar@gmail.com>
1525 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1526 attribute.cs: Emit dynamic export attribute.
1528 2009-07-30 Marek Safar <marek.safar@gmail.com>
1530 * expression.cs: More verifier work.
1532 2009-07-29 Marek Safar <marek.safar@gmail.com>
1534 * nullable.cs: Fixed SRE crash during corlib compilation.
1536 2009-07-29 Marek Safar <marek.safar@gmail.com>
1538 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1539 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1540 More TypeManager.TypeToCoreType needed.
1542 2009-07-29 Marek Safar <marek.safar@gmail.com>
1544 * anonymous.cs: Update after recent SRE fixes.
1546 2009-07-28 Marek Safar <marek.safar@gmail.com>
1548 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1549 version of GetFieldHandle for fields of generic types.
1551 2009-07-27 Marek Safar <marek.safar@gmail.com>
1553 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1554 ecore.cs: Add TypeManager.IsDynamicType,
1555 PredefinedAttributes.Dynamic.
1557 2009-07-27 Marek Safar <marek.safar@gmail.com>
1559 A fix for bug #415375
1560 * expression.cs: Fixed object and reference type parameter
1563 2009-07-27 Marek Safar <marek.safar@gmail.com>
1565 A fix for bug #525342
1566 * class.cs: Attach partial method attributes to method
1569 2009-07-24 Marek Safar <marek.safar@gmail.com>
1571 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1574 2009-07-24 Marek Safar <marek.safar@gmail.com>
1576 * anonymous.cs (MutateField): Add imported types handling.
1578 2009-07-23 Marek Safar <marek.safar@gmail.com>
1580 * expression.cs, delegate.cs: Moved arguments resolve into their
1581 counterparts expressions. Removed argument resolve from
1582 CollectionElementInitializer.
1584 2009-07-23 Marek Safar <marek.safar@gmail.com>
1586 A fix for bug #523683
1587 * convert.cs, delegate.cs: Use common overload mechanism for method
1588 group conversion check.
1590 2009-07-22 Marek Safar <marek.safar@gmail.com>
1592 A fix for bug #523899
1593 * generics.cs: Exact type inference with other bound types.
1595 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1597 Don't complain when the same type is implemented by the output
1598 assembly as well as multiple referenced assemblies
1599 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1600 'must_be_unique' flag.
1601 (GlobalRootNamespace): Update to changes.
1602 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1603 already have a type in hand.
1605 2009-07-22 Marek Safar <marek.safar@gmail.com>
1607 * expression.cs: More verifier instrumentation.
1609 * statement.cs: Do proper throw expression conversion.
1611 2009-07-22 Marek Safar <marek.safar@gmail.com>
1613 A fix for bug #522789
1614 * expression.cs: Mutate invocation return type.
1616 2009-07-16 Marek Safar <marek.safar@gmail.com>
1618 * anonymous.cs: Split assignable and readonly generated variable
1621 2009-07-16 Marek Safar <marek.safar@gmail.com>
1623 A fix for bug #521671
1624 * statement.cs: Fixed crash when checking missing type.
1626 2009-07-16 Marek Safar <marek.safar@gmail.com>
1628 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1629 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1630 class.cs, driver.cs: Work on dynamic binding.
1632 * dynamic.cs: New file.
1634 * *.sources, *.proj: Updated.
1636 2009-07-15 Marek Safar <marek.safar@gmail.com>
1638 * expression.cs (Conditional): Avoid double Resolve.
1640 2009-07-13 Marcus Griep <marcus@griep.us>
1642 * ecore.cs: Fix obscure bug with resolving members of interfaces
1643 that hide parent interface members. Fixes bug #444388 and corrects
1646 2009-07-13 Marek Safar <marek.safar@gmail.com>
1648 * expression.cs (LocalVariableReference): Bounce resolve.
1650 2009-07-10 Marek Safar <marek.safar@gmail.com>
1652 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1653 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1656 * support.cs: New dynamic type wrapper.
1658 2009-07-08 Marek Safar <marek.safar@gmail.com>
1660 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1661 typed local variable.
1663 2009-07-06 Marek Safar <marek.safar@gmail.com>
1665 A fix for bug #519005
1666 * anonymous.cs: Use null_type as no return type placeholder.
1668 2009-07-02 Marek Safar <marek.safar@gmail.com>
1670 * generic.cs: Handle type inference of identical type parameters
1671 with different bounds.
1673 2009-07-01 Marek Safar <marek.safar@gmail.com>
1675 * expression.cs, class.cs: Events variance.
1677 * cs-parser.jay: Interface events error messages.
1679 2009-07-01 Marek Safar <marek.safar@gmail.com>
1681 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1683 2009-06-29 Marek Safar <marek.safar@gmail.com>
1685 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1686 parameter expression can be value-type New.
1688 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1690 2009-06-26 Marek Safar <marek.safar@gmail.com>
1692 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1693 Implemented C# 4.0 named arguments.
1695 2009-06-24 Marek Safar <marek.safar@gmail.com>
1697 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1698 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1699 parameter modifier. Also fixes bug #515497.
1701 2009-06-24 Marek Safar <marek.safar@gmail.com>
1703 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1704 arguments expression to be implemented.
1706 *.sources: Add argument.cs
1708 2009-06-23 Marek Safar <marek.safar@gmail.com>
1710 * parameter.cs: Moved GetParameterIndexByName to base class.
1712 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1713 unused AType. Use argument's version of GetExpressionTree.
1715 2009-06-22 Marek Safar <marek.safar@gmail.com>
1717 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1720 2009-06-17 Marek Safar <marek.safar@gmail.com>
1722 A fix for bug #514096
1723 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1725 2009-06-17 Marek Safar <marek.safar@gmail.com>
1727 * expression.cs: The first multi-dimensional array nested array
1728 initializers was not checked.
1730 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1732 2009-06-17 Marek Safar <marek.safar@gmail.com>
1734 A fix for bug #513400
1735 * nullable.cs (EmitEquality): Operands emit could be simplified for
1736 built-in types when we now emit user operators differently.
1738 2009-06-16 Marek Safar <marek.safar@gmail.com>
1740 * ecore.cs: Report inaccessible delegate methods correctly.
1742 2009-06-16 Marek Safar <marek.safar@gmail.com>
1744 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1745 cs-parser.jay: Implemented C# 4.0 optional parameters.
1747 2009-06-16 Marek Safar <marek.safar@gmail.com>
1749 * driver.cs: Removed broken DefineManifestResource.
1751 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1753 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1754 Use $(BOOTSTRAP_PROFILE) instead.
1756 2009-06-12 Jb Evain <jbevain@novell.com>
1758 * rootcontext.cs: add a Platform field.
1759 * driver.cs: handle /platform.
1760 * codegen.cs: pass the proper flags according to
1761 the platform when saving the assembly.
1763 2009-06-11 Marek Safar <marek.safar@gmail.com>
1765 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1766 Add optional parameters grammar.
1768 2009-06-10 Marek Safar <marek.safar@gmail.com>
1770 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1771 driver.cs: Split lang version and metadata version.
1773 2009-06-10 Marek Safar <marek.safar@gmail.com>
1775 * decl.cs: Better overload ctor collision error message.
1777 2009-06-05 Jb Evain <jbevain@novell.com>
1779 * driver.cs (EmbededResource): avoid using an internal method
1780 in gmcs to embed manifest resources.
1782 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1784 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1785 the compiler from older mono versions (like moon's bots)
1787 2009-06-04 Marek Safar <marek.safar@gmail.com>
1789 * namespace.cs (LookupTypeReflection): Ignore collisions between
1792 2009-06-04 Marek Safar <marek.safar@gmail.com>
1794 * codegen.cs: Enabled generic type forwarders.
1796 2009-06-04 Marek Safar <marek.safar@gmail.com>
1798 * dmcs.*: Add another version of SRE compiler.
1800 2009-06-03 Marek Safar <marek.safar@gmail.com>
1802 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1803 generic-mcs.cs: Fixed variant type conversions.
1805 2009-06-02 Marek Safar <marek.safar@gmail.com>
1807 A fix for bug #507863
1808 * codegen.cs: Fixes a crash on invalid string value attribute.
1810 2009-06-01 Marek Safar <marek.safar@gmail.com>
1812 A fix for bug #508334
1813 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1814 cs-parser.jay: Fully import __arglist modifier.
1816 2009-05-29 Marek Safar <marek.safar@gmail.com>
1818 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1819 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1820 actually work with closed generic types.
1822 2009-05-27 Alan McGovern <amcgovern@novell.com>
1824 * class.cs, decl.cs, delegate.cs, parameter.cs:
1825 Fix the build by replacing the use of 'var' with the actual type.
1827 2009-05-27 Marek Safar <marek.safar@gmail.com>
1829 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1830 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1833 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1836 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1837 Marek Safar <marek.safar@gmail.com>
1839 A fix for bug #377509
1840 * parameter.cs: Use predefined and not empty name for implicit
1843 2009-05-21 Marek Safar <marek.safar@gmail.com>
1845 * class.cs: Don't report wrong warnings for event fields.
1847 2009-05-21 Marek Safar <marek.safar@gmail.com>
1849 A fix for bug #504667
1850 * class.cs: Check for static class using parent container instead of
1853 2009-05-08 Marek Safar <marek.safar@gmail.com>
1855 A fix for bug #496922
1856 * expression.cs: Always use temporary variable when using object
1859 2009-04-28 Marek Safar <marek.safar@gmail.com>
1861 A fix for bug #495112
1862 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1865 2009-04-27 Miguel de Icaza <miguel@novell.com>
1867 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1869 2009-04-24 Miguel de Icaza <miguel@novell.com>
1871 * complete.cs: No idea how gonzalo got a null in the list, but
1874 2009-04-24 Miguel de Icaza <miguel@novell.com>
1876 * complete.cs (CompletionElementInitializer): New completion class
1877 to support completing inside a C# 3 element initializer, so this
1878 allows completion for Silverlight situations where it is very
1881 new TextBlock () { Fo<TAB>
1883 (CompletionSimpleName): Expose the prefix that was
1884 passed to the simple name.
1886 * cs-parser.jay (object_or_collection_initializer): Add support
1887 for element_initializers.
1889 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1890 special case completion expressions as this method aggressively
1891 collects data before it operates, and errors were being thrown
1892 earlier than we were able to complete.
1894 2009-04-23 Miguel de Icaza <miguel@novell.com>
1896 * eval.cs: Make getcompletions silent and enable debugging output
1897 if the -v option is passed.
1899 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1900 Consider looking up the namespace that matches the prefix being
1903 This is part of the support for allowing completions like:
1904 `System.Co<TAB>' to complete to System.Console.
1906 * complete.cs (CompletionSimpleName.AppendResults): Make this
1909 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1911 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1912 COMPLETE_COMPLETION as internal.
1914 2009-04-17 Miguel de Icaza <miguel@novell.com>
1916 * complete.cs: Include namespace resolution in simple names as
1917 well as global types and types in the using scope in the
1920 * namespace.cs: Supporting infrastrcture to provide completions
1921 based on the current using scope.
1923 * eval.cs: Introduce an entry point that allows for initialization
1924 to return a list of the files passed on the command line.
1926 2009-04-14 Marek Safar <marek.safar@gmail.com>
1928 A fix for bug #494243
1929 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1931 2009-04-13 Marek Safar <marek.safar@gmail.com>
1933 A fix for bug #493887
1934 * statement.cs: Don't skip string multi-section with default or
1935 null label when populating string hashtable.
1937 2009-04-06 Marek Safar <marek.safar@gmail.com>
1939 A fix for bug #492329
1940 * expression.cs (New): Load variable when assigning type parameter
1943 2009-04-06 Marek Safar <marek.safar@gmail.com>
1945 A fix for bug #488960
1946 * decl.cs: Compare MVAR types using non-null values.
1948 2009-03-27 Marek Safar <marek.safar@gmail.com>
1950 * typemanager.cs, expression.cs: Removed unused nullable checks.
1952 2009-03-27 Marek Safar <marek.safar@gmail.com>
1954 * *.cs: Removed some gmcs conditionals.
1956 2009-03-26 Marek Safar <marek.safar@gmail.com>
1958 * generic.cs, support.cs: Moved generics stuff out of support.cs
1960 2009-03-24 Marek Safar <marek.safar@gmail.com>
1962 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1965 2009-03-23 Marek Safar <marek.safar@gmail.com>
1967 * attribute.cs: Consider all members for error reporting when
1968 checking named arguments.
1970 2009-03-23 Marek Safar <marek.safar@gmail.com>
1972 A fix for bug #487625
1973 * namespace.cs: Use a warning for all predefined type conflicts.
1975 2009-03-23 Marek Safar <marek.safar@gmail.com>
1977 A fix for bug #485706
1978 * statement.cs: Explicitly type catch type argument to pass verifier
1981 2009-03-22 Miguel de Icaza <miguel@novell.com>
1983 Initial support to provide code completion facilities to consumers
1984 of the evaluator API.
1986 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1987 support the completion engine. When we reach the end of the
1988 input stream instead of returning EOF, when this flag is true the
1989 tokenizer instead produces:
1991 One GENERATE_COMPLETION token: this token then must be
1992 handled in the grammar at every point where the user
1993 would likely request a completion.
1995 As many COMPLETE_COMPLETION tokens as necessary. These
1996 tokens are generated to assist the parser in unwinding and
1997 producing a valid parse tree.
1999 The parser rules do not have to be perfect, the parser needs to be
2000 augmented with judicious use of GENERATE_COMPLETION tokens to
2001 improve the areas where we can provide completion and the parser
2002 needs to add support for COMPLETE_COMPLETION tokens in productions
2005 It is common to not have enough support for COMPLETE_COMPLETION
2006 under certain rules and that even if we generated the
2007 GENERATE_COMPLETION token that the resulting tree will be invalid
2008 due to the missing rules that support COMPLETE_COMPLETION.
2010 The final EOF token is produced by having the parser notify the
2011 tokenizer when it reaches the root production that the next token
2014 * support.cs (CompletionResult): New Exception. This exception
2015 is thrown to return the completion results when one of the special
2016 completion expressions is reached.
2018 This exception is thrown by the completing ExpressionStatements
2019 classes that live in complete.cs
2021 * complete.cs (CompletingExpression): a new base class for
2022 completing expressions. This derives from the
2023 ExpressionStatement class and not from Expression as it allows
2024 completion to happen not only where expressions are expected in
2025 the grammar, but also where statements are expected.
2027 (CompletionSimpleName): A new class used to provide completions
2028 for SimpleNames. This currently only resolves to local
2029 variables from the evaluator context (GetVars call).
2031 (CompletionMemberAccess): Implements support for completing member
2034 * cs-parser.jay: Add support for completion in a few places.
2036 * eval.cs (GetCompletions): New public API for the evaluator that
2037 returns a list of possible completions given the input. The
2038 return value is an array of completions
2040 * anonymous.cs (Compatible): If the exception thrown from the
2041 resolved expression is a CompletionResult exception let that one
2042 through instead of printing a diagnostic error in the try/catch.
2044 2009-03-22 Miguel de Icaza <miguel@novell.com>
2048 * driver.cs (Main): Use Environment.Exit to quit quickly and
2049 prevent the compiler from doing the usual wait for helper thread
2052 This is to prevent a slowdown that was reported by Gonzalo on
2055 2009-03-19 Marek Safar <marek.safar@gmail.com>
2057 * ecore.cs: Load build-in types directly instead of accessing
2060 2009-03-18 Marek Safar <marek.safar@gmail.com>
2062 * ecore.cs: Always use unbox.any when available.
2064 2009-03-18 Marek Safar <marek.safar@gmail.com>
2066 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
2068 2009-03-17 Marek Safar <marek.safar@gmail.com>
2070 * generic.cs: Removed obsolete version of type inference.
2072 2009-03-16 Marek Safar <marek.safar@gmail.com>
2074 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
2075 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
2076 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
2077 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
2079 2009-03-11 Marek Safar <marek.safar@gmail.com>
2081 A fix for bug #482996
2082 * anonymous.cs: Make sure we are not infering return type when
2083 checking type compatibility.
2085 2009-03-11 Marek Safar <marek.safar@gmail.com>
2087 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
2088 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
2089 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
2090 attributes in their own structure. Needed when accessing their
2091 properties before they are resolved.
2093 2009-03-09 Marek Safar <marek.safar@gmail.com>
2095 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
2096 hashtable (~10x faster).
2098 * driver.cs: Removed wrong Reset.
2100 2009-03-08 Marek Safar <marek.safar@gmail.com>
2102 * class.cs: Use correct common base type for unmanaged delayed
2105 * rootcontext.cs: Wrap unhandled exception.
2107 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
2109 Make SeekableStreamReader self-tuning and arbitrarily seekable
2110 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
2112 (SeekableStreamReader.Position.set): Use it. Simplify logic
2113 which, as a side-effect, makes it arbitrarily-seekable. Tune the
2114 buffer size when the stream needs to be re-read from the beginning.
2116 2009-03-05 Marek Safar <marek.safar@gmail.com>
2118 A fix for bug #480100
2119 * parameter.cs: A parameter is not hoisted when used directly as ET.
2121 2009-03-04 Marek Safar <marek.safar@gmail.com>
2123 * statement.cs: Fixed an issue when using variable is of interface
2126 2009-03-03 Marek Safar <marek.safar@gmail.com>
2128 A fix for bug #480319
2129 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
2131 2009-03-03 Marek Safar <marek.safar@gmail.com>
2133 A fix for bug #480867
2134 * typemanager.cs, expression.cs, ecore.cs: Changed method group
2135 expression to have no valid type.
2137 2009-03-03 Marek Safar <marek.safar@gmail.com>
2139 A fix for bug #481258
2140 * class.cs: Set extension method flag in partial container.
2142 2009-03-03 Marek Safar <marek.safar@gmail.com>
2144 * statement.cs, typemanager.cs: Use expression for StringEmitter.
2146 * attribute.cs: Add sanity check.
2148 2009-02-27 Marek Safar <marek.safar@gmail.com>
2150 * class.cs: Add external constructor error.
2152 2009-02-26 Marek Safar <marek.safar@gmail.com>
2154 A fix for bug #475354
2155 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
2156 correctly user defined nullable equality operators.
2158 2009-02-25 Marek Safar <marek.safar@gmail.com>
2160 A fix for bug #479532
2161 * expression.cs: Implement NewInitialize::AddressOf.
2163 2009-02-25 Marek Safar <marek.safar@gmail.com>
2165 A fix for bug #413633
2166 * expression.cs: Iterate all base class-constraint types.
2168 2009-02-24 Marek Safar <marek.safar@gmail.com>
2170 A fix for bug #479209
2171 * literal.cs: Mutate null underlying type.
2173 2009-02-24 Marek Safar <marek.safar@gmail.com>
2175 A fix for bug #476295
2176 * convert.cs: Avoid wrapping implicitly convertible reference type.
2178 2009-02-23 Marek Safar <marek.safar@gmail.com>
2180 * iterators.cs: Create MemberName correctly.
2182 2009-02-23 Marek Safar <marek.safar@gmail.com>
2184 A fix for bug #478655
2185 * literal.cs: Check also underlying null type conversion.
2187 2009-02-21 Marek Safar <marek.safar@gmail.com>
2189 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
2191 2009-02-20 Marek Safar <marek.safar@gmail.com>
2193 A fix for bug #477447
2194 * statement.cs: Add reference to correct parent storey when this
2195 is accessible from deep children storey (more than 1 level).
2197 2009-02-19 Marek Safar <marek.safar@gmail.com>
2199 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
2200 * class.cs: Define base type members before setting up member cache.
2202 2009-02-18 Marek Safar <marek.safar@gmail.com>
2204 A fix for bug #477378
2205 * nullable.cs, expression.cs, statement.cs: More precise null type
2208 2009-02-18 Marek Safar <marek.safar@gmail.com>
2210 A fix for bug #472805
2211 * typemanager.cs, namespace.cs: Import only visible extension method
2214 2009-02-18 Marek Safar <marek.safar@gmail.com>
2216 A fix for bug #476895
2217 * attribute.cs: Use correct resolve context for attribute type.
2219 2009-02-18 Marek Safar <marek.safar@gmail.com>
2221 A fix for bug #476266
2222 * anonymous.cs: Mutate multi-dimensional arrays.
2224 2009-02-18 Marek Safar <marek.safar@gmail.com>
2226 A fix for bug #476400
2227 * statement.cs, expression.cs: Removed wrong Dispose optimization.
2229 2009-02-18 Marek Safar <marek.safar@gmail.com>
2231 A fix for bug #476811
2232 * generics.cs: Fixed null-literal check.
2234 2009-02-17 Marek Safar <marek.safar@gmail.com>
2236 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
2237 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
2238 messing with static variables.
2240 2009-02-16 Marek Safar <marek.safar@gmail.com>
2242 A fix for bug #475965
2243 * generics.cs: Check generic parameter type after extracting from
2246 2009-02-16 Marek Safar <marek.safar@gmail.com>
2248 A fix for bug #475823
2249 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
2252 2009-02-14 Marek Safar <marek.safar@gmail.com>
2254 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
2255 Simplified event field definition using backing field and not
2256 field builder directly.
2258 * expression.cs (EmitLdArg): Optimize fast paths.
2260 2009-02-13 Marek Safar <marek.safar@gmail.com>
2262 A fix for bug #475327
2263 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2265 2009-02-13 Marek Safar <marek.safar@gmail.com>
2267 A fix for bug #475342
2268 * cs-parser.jay: Using 'super' instead of 'base' to call base
2269 constructor crashes compiler.
2271 2009-02-13 Marek Safar <marek.safar@gmail.com>
2273 A fix for bug #475354
2274 * expression.cs (Constantify): Add nullable types.
2276 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2278 2009-02-12 Marek Safar <marek.safar@gmail.com>
2280 A fix for bug #475246
2281 * expression.cs: More broken flowanalysis hacking needed.
2283 2009-02-12 Marek Safar <marek.safar@gmail.com>
2285 * attribute.cs: Compare only ref/out array modifiers.
2287 2009-02-11 Marek Safar <marek.safar@gmail.com>
2289 * statement.cs: Use member cache when looking for foreach members.
2291 2009-02-11 Marek Safar <marek.safar@gmail.com>
2293 * expression.cs: Don't expose internal initializer types.
2295 * statement.cs: Check also explicit conversions for goto case.
2297 2009-02-11 Marek Safar <marek.safar@gmail.com>
2299 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2301 2009-02-10 Marek Safar <marek.safar@gmail.com>
2303 * *.cs: Replace null-type with NullLiteral where appropriate.
2305 2009-02-09 Marek Safar <marek.safar@gmail.com>
2307 * expression.cs: Initializer of reference argument use temporary
2308 variable to be verifiable.
2310 * parameter.cs: Share EmitLdArg.
2312 2009-02-09 Marek Safar <marek.safar@gmail.com>
2314 A fix for bug #473559
2315 * class.cs: Fixed: Not reporting error about nested class with the
2318 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2320 Contributed under the MIT/X11 license.
2322 * generic.cs: Added VerifyVariantTypeParameters which performs new
2323 variance verification logic. The old logic, based on the spec, was
2324 wrong because the spec is full of LIES!
2326 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2328 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2331 * ecore.cs: Added calls to the new variance verification logic.
2334 * delegate.cs: Removed calls to the old variance verification logic.
2336 2009-02-06 Marek Safar <marek.safar@gmail.com>
2338 * delegate.cs: Use cached Invoke method directly.
2340 2009-02-06 Marek Safar <marek.safar@gmail.com>
2342 * expression.cs: Emit expression tree for hoisted variable access.
2344 2009-02-04 Marek Safar <marek.safar@gmail.com>
2346 * namespace.cs: Add better extension class check.
2348 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2350 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2352 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2354 This patch adds initial generic variance support to the compiler.
2355 It is contributed under the MIT/X11 license.
2357 * typemanager.cs: Modified ImplementsInterface to check variance.
2358 Added VerifyVariantTypeParameters which checks the specified type to see
2359 if it uses a variant type parameter as a type argument (which is not
2360 allowed). Added IsVariantOf which determins if the first type is a
2361 variant of the second. NOTE: This only supports reference types at
2362 the moment to conform with the current level of VM support. When the
2363 VM supports value types, this will follow step.
2365 * generic.cs: Added the Variance enum. Added a Variance property to
2366 TypeParameter and added variance support to definition phase. Added a
2367 Variance property to TypeParameterName. Also check to make sure that
2368 no variant types appear in generic method parameters.
2370 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2371 keywords if the langversion supports it.
2373 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2374 that variant types are only used in legal positions. Also added
2375 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2378 * decl.cs: Construct TypeParameter with the variance information.
2380 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2381 and ImplicitConversionStandard.
2383 * rootcontext.cs: Added new "Future" language version.
2385 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2386 type parameters are not used as type arguments in interface inheritance.
2387 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2388 parameters are not used as method return types. In MemberBase.
2389 ResolveMemberType, ensure that variant type parameters are not used
2390 as type arguments. Also call VerifyNoVariantTypeParameters on every
2391 set of parameters which are resolved.
2393 * delegate.cs: Modified Delegate.Define to ensure that variant
2394 parameters are not used as type arguments and that a contravariant
2395 parameter is not used as the return type. Also call
2396 VerifyNoVariantTypeParameters on the delegate parameters.
2398 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2399 to specify generic variance.
2401 * driver.cs: Added support for LanguageVersion.Future in the form of
2402 "-langversion:future".
2404 * generic-mcs.cs: Stubbed out new members in generic.cs.
2406 2009-02-03 Marek Safar <marek.safar@gmail.com>
2408 * class.cs, generic.cs: Emit type parameter constraints for nested
2411 2009-02-02 Marek Safar <marek.safar@gmail.com>
2413 A fix for bug #471213
2414 * class.cs: Avoid emitting backing field for abstract event fields.
2416 2009-02-01 Marek Safar <marek.safar@gmail.com>
2418 A fix for bug #359731
2419 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2422 2009-01-30 Marek Safar <marek.safar@gmail.com>
2424 A fix for bug #470767
2425 * statement.cs: Introduced BlockScopeExpression, needed when
2426 expression tree conversion has to emit scope variables.
2428 2009-01-29 Marek Safar <marek.safar@gmail.com>
2430 * class.cs: Remove duplicate CallingConvention.
2432 2009-01-29 Marek Safar <marek.safar@gmail.com>
2434 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2435 when I finally found the right naming convention.
2437 2009-01-29 Marek Safar <marek.safar@gmail.com>
2439 * cs-tokenizer.cs: Put back different open parens optimization.
2441 2009-01-28 Marek Safar <marek.safar@gmail.com>
2443 A fix for bug #470227
2444 * cs-tokenizer.cs: Remove too agressive parser optimization.
2446 2009-01-28 Marek Safar <marek.safar@gmail.com>
2448 A fix for bug #324319
2449 * class.cs: Remove too early base type resolve.
2451 2009-01-27 Marek Safar <marek.safar@gmail.com>
2453 A fix for bug #324319
2454 * ecore.cs: Explicitly type null when assigning to type argument to
2455 make pass verifier check.
2457 2009-01-27 Marek Safar <marek.safar@gmail.com>
2459 * anonymous.cs: Fixed recent regression when initializing captured
2462 2009-01-26 Marek Safar <marek.safar@gmail.com>
2464 A fix for bug #469019
2465 * anonymous.cs: Use all parent type parameters when instantiating
2466 nested generic storey.
2468 2009-01-26 Marek Safar <marek.safar@gmail.com>
2470 * expression.cs: Check for null instance methodgroup expression.
2472 2009-01-26 Marek Safar <marek.safar@gmail.com>
2474 A fix for bug #469244
2475 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2476 instance inside a conditional expression.
2478 2009-01-23 Marek Safar <marek.safar@gmail.com>
2480 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2481 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2482 GetElementType and HasElementType. IsValueType clean up.
2484 2009-01-23 Marek Safar <marek.safar@gmail.com>
2486 * nullable.cs: Use common EmitCall.
2488 * expression.cs: Emit constraint. for virtual calls only.
2490 2009-01-23 Marek Safar <marek.safar@gmail.com>
2492 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2493 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2494 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2497 2009-01-22 Jb Evain <jbevain@novell.com>
2499 * anonymous.cs: make anonymous types' ToString implementation
2500 match what csc outputs.
2502 2009-01-21 Marek Safar <marek.safar@gmail.com>
2504 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2507 2009-01-17 Marek Safar <marek.safar@gmail.com>
2509 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2512 2009-01-16 Marek Safar <marek.safar@gmail.com>
2514 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2517 2009-01-15 Marek Safar <marek.safar@gmail.com>
2519 A fix for bug #466634
2520 * statement.cs: Add reference for nested storey when only this
2523 2009-01-15 Marek Safar <marek.safar@gmail.com>
2525 A fix for bug #466474
2526 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2529 2009-01-15 Marek Safar <marek.safar@gmail.com>
2531 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2532 Fixed nested stories parent referencing process. Also fixes #463985.
2534 2009-01-06 Marek Safar <marek.safar@gmail.com>
2536 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2537 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2538 implementation. Also fixes #463108.
2540 2009-01-05 Marek Safar <marek.safar@gmail.com>
2542 A fix for bug #416109
2543 * decl.cs: Issue correct CLSAttribute warning location.
2545 2009-01-05 Marek Safar <marek.safar@gmail.com>
2547 A fix for bug #456775
2548 * attribute.cs: Use attribute owner scope when resolving attribute
2551 2009-01-05 Marek Safar <marek.safar@gmail.com>
2553 A fix for bug #457257
2554 * decl.cs: Fixed incorrect member declaring type comparison.
2556 2009-01-05 Marek Safar <marek.safar@gmail.com>
2558 A fix for bug #460896
2559 * driver.cs: Handle /RES resources as embeddable.
2561 2009-01-05 Marek Safar <marek.safar@gmail.com>
2563 A fix for bug #462515
2564 * ecore.cs: Report inacessible members upwards.
2566 2009-01-05 Marek Safar <marek.safar@gmail.com>
2568 A fix for bug #463190, #463192
2569 * decl.cs, namespace.cs: Also import internal extension classes.
2571 2009-01-04 Marek Safar <marek.safar@gmail.com>
2573 A fix for bug #463415
2574 * generic.cs: Use right index for RemoveDependentTypes.
2576 2009-01-02 Marek Safar <marek.safar@gmail.com>
2578 A fix for bug #463196
2579 * expression.cs: Fixed enum to null comparison.
2581 2009-01-02 Marek Safar <marek.safar@gmail.com>
2583 A fix for bug #463121
2584 * nullable.cs: Fixed nullable user equality operator comparison.
2586 2009-01-02 Marek Safar <marek.safar@gmail.com>
2588 A fix for bug #462950
2589 * class.cs, decl.cs: Use full explicit name when defining automatic
2590 property backing field.
2592 2009-01-02 Marek Safar <marek.safar@gmail.com>
2594 A fix for bug #462592
2595 * pending.cs: Emit type arguments for generic proxy method.
2597 2008-12-30 Marek Safar <marek.safar@gmail.com>
2599 * expression.cs (As): Mutate all type arguments.
2601 2008-12-29 Marek Safar <marek.safar@gmail.com>
2603 A fix for bug #462622
2604 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2607 2008-12-29 Marek Safar <marek.safar@gmail.com>
2609 A fix for bug #450782
2610 * ecore.cs: Consider more variables of form V.I to be fixed.
2612 2008-12-29 Marek Safar <marek.safar@gmail.com>
2614 A fix for bug #460712
2615 * typemanager.cs: Core types could be imported.
2617 2008-12-28 Marek Safar <marek.safar@gmail.com>
2619 A fix for bugs #460847, #460772, #458049, #457339, #447807
2620 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2621 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2622 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2623 user lambdas used inside query clauses.
2625 2008-12-18 Marek Safar <marek.safar@gmail.com>
2627 A fix for bug #460229
2628 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2630 2008-12-18 Marek Safar <marek.safar@gmail.com>
2632 A fix for bug #459952
2633 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2635 2008-12-18 Marek Safar <marek.safar@gmail.com>
2637 A fix for bug #459630
2638 * convert.cs: Enum to valuetype conversion is not allowed.
2640 2008-12-18 Marek Safar <marek.safar@gmail.com>
2642 A fix for bug #457087
2643 * generic.cs: Don't crash when constraint comes from type
2646 2008-12-16 Marek Safar <marek.safar@gmail.com>
2648 A fix for bug #459221
2649 * anonymous.cs, statement.cs: Delay only captured this
2652 2008-12-12 Marek Safar <marek.safar@gmail.com>
2654 A fix for bug #457489
2655 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2656 and initialization to capture scope initializers correctly.
2658 2008-12-11 Marek Safar <marek.safar@gmail.com>
2660 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2661 ParameterReference refactoring.
2663 2008-12-03 Marek Safar <marek.safar@gmail.com>
2665 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2666 to be imported from any assembly.
2668 2008-12-03 Marek Safar <marek.safar@gmail.com>
2670 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2671 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2672 from anonymous method and lambda expression.
2674 2008-12-01 Marek Safar <marek.safar@gmail.com>
2676 A fix for bug #448560
2677 * expression.cs (As): Box any generic type arguments to be
2680 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2682 Add tripwire for implicit conversion bugs
2683 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2685 (MethodGroupExpr.OverloadResolve): Add sanity check between
2686 IsApplicable and VerifyArgumentsCompat.
2687 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2689 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2691 Fix build break in System.Data_test
2692 * convert.cs (ImplicitConversionExists): Move NullLiteral
2694 (ImplicitStandardConversionExists): ... here.
2696 2008-11-28 Marek Safar <marek.safar@gmail.com>
2698 * literal.cs: Emit correctly explicit null to nullable cast.
2700 2008-11-28 Marek Safar <marek.safar@gmail.com>
2702 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2705 2008-11-28 Marek Safar <marek.safar@gmail.com>
2707 A fix for bug #449005
2708 * convert.cs, nullable.cs: Use only one implicit nullable
2711 2008-11-27 Marek Safar <marek.safar@gmail.com>
2713 * convert.cs, literal.cs: More Convert cleanup is needed.
2715 2008-11-27 Marek Safar <marek.safar@gmail.com>
2717 * decl.cs, class.cs: Fixed misleading error message.
2719 2008-11-26 Marek Safar <marek.safar@gmail.com>
2721 A fix for bug #449005
2722 * nullable.cs (EmitEquality): Disable optimization for user operator
2725 2008-11-25 Marek Safar <marek.safar@gmail.com>
2727 A fix for bug #447027
2728 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2729 with context variables stored as expression instances.
2731 2008-11-25 Marek Safar <marek.safar@gmail.com>
2733 A fix for bug #447027
2734 * delegate.cs: Fixed delegate VerifyMethod logic.
2736 2008-11-24 Marek Safar <marek.safar@gmail.com>
2738 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2741 2008-11-21 Marek Safar <marek.safar@gmail.com>
2743 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2744 member type resolve to follow normal flow, instead of random
2747 2008-11-21 Marek Safar <marek.safar@gmail.com>
2749 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2752 2008-11-21 Marek Safar <marek.safar@gmail.com>
2754 * const.cs: Emit decimal array constant as literal.
2756 2008-11-20 Marek Safar <marek.safar@gmail.com>
2758 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2760 2008-11-19 Marek Safar <marek.safar@gmail.com>
2762 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2763 into real property (saves 8 MB for corlib compilation).
2765 2008-11-19 Marek Safar <marek.safar@gmail.com>
2767 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2768 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2769 generic-mcs.cs: Small cleanup of TypeArguments.
2771 2008-11-18 Marek Safar <marek.safar@gmail.com>
2773 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2774 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2775 of ConstructedType expression, renamed to GenericTypeExpr.
2777 2008-11-17 Marek Safar <marek.safar@gmail.com>
2779 A fix for bug #445303
2780 * location.cs (IsConditionalDefined): Handle undefined global
2783 2008-11-17 Marek Safar <marek.safar@gmail.com>
2785 A fix for bug #444678
2786 * expression.cs (TryReduceConstant): Always create new constant
2789 2008-11-17 Marek Safar <marek.safar@gmail.com>
2791 A fix for bug #444673
2792 * ecore.cs: Ignore open generic types when used as generic type
2795 2008-11-17 Marek Safar <marek.safar@gmail.com>
2797 A fix for bug #445458
2798 * expression.cs, cs-parser.jay: Don't crash when an expression
2801 2008-11-17 Marek Safar <marek.safar@gmail.com>
2803 A fix for bug #445464
2804 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2805 inside unbound type.
2807 2008-11-14 Jb Evain <jbevain@novell.com>
2809 * driver.cs: ignore empty -nowarn argument such as
2810 the one in -nowarn:12,13,,.
2812 2008-11-13 Marek Safar <marek.safar@gmail.com>
2814 A fix for bug #444271
2815 * anonymous.cs: Rescan parent storeys when best candidate was
2818 2008-11-13 Marek Safar <marek.safar@gmail.com>
2820 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2821 useless UnboundTypeExpression.
2823 * attribute.cs: Do check obsolete attribute on generic types.
2825 2008-11-12 Marek Safar <marek.safar@gmail.com>
2827 A fix for bugs #425680, #400139
2828 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2831 2008-11-11 Marek Safar <marek.safar@gmail.com>
2833 A fix for bug #435747
2834 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2835 compound value types assignment. Few micro optimizations added.
2837 2008-11-10 Marek Safar <marek.safar@gmail.com>
2839 A fix for bug #442610
2840 * anonymous.cs (MutateConstructor): More SRE hacking.
2842 2008-11-10 Marek Safar <marek.safar@gmail.com>
2844 A fix for bug #442579
2845 * ecore.cs: Also initialize expanded form of a method with 1 params
2848 2008-11-06 Marek Safar <marek.safar@gmail.com>
2850 * expression.cs (UnaryMutator): Do early l-side check.
2852 2008-11-05 Miguel de Icaza <miguel@novell.com>
2854 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2855 Init, otherwise we would crash later on when checking for friend
2858 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2859 Otherwise we never get any meaningful information as to what
2862 2008-11-05 Marek Safar <marek.safar@gmail.com>
2864 A fix for bug #436318
2865 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2867 2008-11-05 Miguel de Icaza <miguel@novell.com>
2869 * namespace.cs: Turns out that it was a really bad idea to hide
2870 the errors for namespaces not found here in eval mode.
2872 * eval.cs: When we process using clauses, only enter those into
2873 the list of valid using clauses after they have been validated.
2875 The above change gives the proper semantics: it does not
2876 senselessly report the same errors with broken using statements by
2877 never storing them in the first place when they are invalid.
2879 2008-11-05 Marek Safar <marek.safar@gmail.com>
2881 A fix for bug #421839
2882 * cs-parser.jay: Remove expression from coalesce rule to force lower
2883 priority than the assignment operator.
2885 2008-11-05 Marek Safar <marek.safar@gmail.com>
2887 A fix for bug #437875
2888 * nullable.cs: Compile correctly method group operand used with null
2889 coalescing operator.
2891 2008-11-04 Marek Safar <marek.safar@gmail.com>
2893 A fix for bug #434589
2894 * expression.cs (Binary): Ignore lifted conversions when at least
2895 one operand is of reference type.
2897 2008-11-04 Marek Safar <marek.safar@gmail.com>
2899 * cs-parser.jay: Better syntax error report.
2901 2008-11-03 Marek Safar <marek.safar@gmail.com>
2903 A fix for bug #436792
2904 * cs-parser.jay: Use GetLocation to access location.
2906 2008-11-03 Marek Safar <marek.safar@gmail.com>
2908 A fix for bug #440774
2909 * cs-parser.jay: Also set current_array_type when parsing local
2912 2008-11-03 Marek Safar <marek.safar@gmail.com>
2914 A fix for bug #440785
2915 * expression.cs (As): Don't resolve self modifing expression
2918 2008-11-03 Marek Safar <marek.safar@gmail.com>
2920 A fix for bug #439447
2921 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2923 2008-11-03 Marek Safar <marek.safar@gmail.com>
2925 A fix for bug #437571
2926 * cs-parser.jay: Fixes internal error for invalid expression
2929 2008-10-17 Marek Safar <marek.safar@gmail.com>
2931 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2933 2008-10-17 Marek Safar <marek.safar@gmail.com>
2935 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2937 2008-10-17 Marek Safar <marek.safar@gmail.com>
2939 * cs-tokenizer.cs: More precise cast parsing.
2941 2008-10-16 Martin Baulig <martin@ximian.com>
2943 * anonymous.cs (AnonymousMethodStorey): Put back the
2944 `hoisted_locals' hashtable and use it in EmitType().
2946 2008-10-15 Marek Safar <marek.safar@gmail.com>
2948 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2949 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2952 2008-10-14 Marek Safar <marek.safar@gmail.com>
2954 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2956 2008-10-14 Marek Safar <marek.safar@gmail.com>
2958 * statement.cs: Mutate scope initializers.
2960 2008-10-14 Marek Safar <marek.safar@gmail.com>
2962 * expression.cs: Use typeless value for This constant.
2964 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2966 2008-10-14 Marek Safar <marek.safar@gmail.com>
2968 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2971 2008-10-13 Marek Safar <marek.safar@gmail.com>
2973 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2976 2008-10-13 Marek Safar <marek.safar@gmail.com>
2978 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2979 parser and tokenizer. Fixes many ambiguities including #433258.
2981 2008-10-10 Marek Safar <marek.safar@gmail.com>
2983 * cs-parser.jay: Fixed missing accessor recovery.
2985 2008-10-10 Marek Safar <marek.safar@gmail.com>
2987 A fix for bug #433701
2988 * expression.cs: Better error message.
2990 2008-10-10 Marek Safar <marek.safar@gmail.com>
2992 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2994 * Makefile: Disabled unused debug symbols.
2996 Also fixes: #320556, #321097, #321656, #321876, #351316
2998 2008-10-09 Miguel de Icaza <miguel@novell.com>
3000 * eval.cs: rename "<interactive>" to "{interactive}", to work
3001 around a requirement in the compiler that this be a valid
3002 filename, and in Windows it is not (433886).
3004 2008-10-09 Marek Safar <marek.safar@gmail.com>
3006 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
3008 2008-10-08 Marek Safar <marek.safar@gmail.com>
3010 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
3011 cs-parser.jay: Generic type declaration and type arguments cleanup.
3013 2008-10-05 Marek Safar <marek.safar@gmail.com>
3015 * cs-parser.jay: Allow parsing weird array creation construct.
3017 2008-10-05 Marek Safar <marek.safar@gmail.com>
3019 * cs-parser.jay: Conflicts reduction.
3021 2008-10-04 Marek Safar <marek.safar@gmail.com>
3023 * cs-parser.jay: Conflicts reduction.
3025 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
3028 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
3029 property. Add a 'count' hint about the use of the shared vector.
3030 Ensure that we don't leak out dirty bits.
3031 (UsageVector.MergeChild): Throw away information about variables
3033 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
3035 2008-10-03 Marek Safar <marek.safar@gmail.com>
3037 A fix for bug #431746
3038 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
3039 parameters when iterator is created.
3041 2008-10-03 Marek Safar <marek.safar@gmail.com>
3043 A fix for bug #431827
3044 * expression.cs: Fixed right based pointer arithmetic operations
3047 2008-10-03 Marek Safar <marek.safar@gmail.com>
3049 A fix for bug #353779
3050 * assign.cs, expression.cs: Fixed compound assignment conversions.
3052 2008-10-02 Marek Safar <marek.safar@gmail.com>
3054 A fix for bug #375262
3055 * statement.cs: Refactor ArrayForeach to be usable with string
3056 indexer. Optimized single dimentional arrays foreach.
3058 2008-10-02 Marek Safar <marek.safar@gmail.com>
3060 A fix for bug #431255
3061 * anonymous.cs, expression.cs: Removed broken optimization.
3063 2008-10-01 Marek Safar <marek.safar@gmail.com>
3065 * anonymous.cs: Use full type parameters of parent generic
3066 containers. Removed unnecessary AddParentStoreyReference call.
3068 2008-10-01 Marek Safar <marek.safar@gmail.com>
3070 A fix for bug #324702
3071 * class.cs: Use better shorter names for explicit interface member
3074 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
3076 2008-10-01 Marek Safar <marek.safar@gmail.com>
3078 * expression.cs: Use new interface to check fixed expression.
3080 2008-10-01 Marek Safar <marek.safar@gmail.com>
3082 A fix for bug #421101
3083 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
3084 interface to check for fixed fixed-buffers.
3086 2008-10-01 Marek Safar <marek.safar@gmail.com>
3088 A fix for bug #429264
3089 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
3091 * delegate.cs: Removed unnecessary casts.
3093 2008-09-30 Marek Safar <marek.safar@gmail.com>
3095 A fix for bug #352151
3096 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
3097 class.cs: Fixed already defined explicit interface members check.
3099 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
3101 cs-tokenizer.cs: Fix typo.
3103 2008-09-28 Miguel de Icaza <miguel@novell.com>
3105 * eval.cs (InteractiveBase): The quit command now just sets a
3106 flag, instead of calling Environment.Exit(), it is milder on
3109 CompiledMethod is now in Mono.CSharp, not nested inside
3110 the Evaluator, it was inconvenient to use.
3112 2008-09-27 Miguel de Icaza <miguel@novell.com>
3114 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
3115 code to be invoked without having to reparse.
3117 2008-09-27 Miguel de Icaza <miguel@novell.com>
3119 * ecore.cs: The recent changes to FieldExpr broke this as well.
3120 Fixes LINQ queries in the interactive shell.
3122 * Multiple files: indentation fixing for the Mono coding
3123 guidelines for the switch statement.
3125 * eval.cs: Make the Evaluator API thread safe.
3127 2008-09-26 Marek Safar <marek.safar@gmail.com>
3129 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
3130 constructor parsing.
3132 2008-09-26 Marek Safar <marek.safar@gmail.com>
3134 A fix for bug #325326
3135 * statement.cs: Check possible mistaken empty statement using
3136 explicit blocks only.
3138 2008-09-25 Miguel de Icaza <miguel@novell.com>
3140 * eval.cs (LoadAssembly, ReferenceAssembly): Call
3141 RootNamespace.ComputeNamespaces to update the internal list of
3142 namespaces, this is no longer done for us.
3144 (InteractiveBase): Use the Evaluator APIs instead of calling into
3147 2008-09-25 Marek Safar <marek.safar@gmail.com>
3149 A fix for bug #429264
3150 * expression.cs: Missing mutator for access to multidimensional
3153 2008-09-25 Marek Safar <marek.safar@gmail.com>
3155 * class.cs, statement: Emit DebuggerHidden attribute for iterator
3158 * driver.cs: Missing input argument check.
3160 2008-09-25 Marek Safar <marek.safar@gmail.com>
3162 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
3163 expression.cs, statement.cs, rootcontext.cs, class.cs,
3164 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
3167 2008-09-24 Miguel de Icaza <miguel@novell.com>
3169 * ecore.cs (FieldExpr): Only initialize eclass when we return a
3170 fully constructed FieldExpr, fixes the regression introduced in
3173 * ecore.cs, expression.cs: Plug back the eclass initialization as
3174 otherwise it regresses `csharp'.
3176 2008-09-24 Marek Safar <marek.safar@gmail.com>
3178 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
3179 ecore.cs, attribute.cs: Moved obsolete method checks from emit
3180 phase to resolve phase. It resolves problems with expression trees
3181 and fixes bugs #323796, #325156.
3183 2008-09-23 Marek Safar <marek.safar@gmail.com>
3185 * codegen.cs: Report better error when symbol writer is missing.
3187 2008-09-23 Marek Safar <marek.safar@gmail.com>
3189 * codegen.cs: Set .NET symbol writer.
3191 * decl.cs: Guard against null generic arguments.
3193 * report.cs: Don't report exactly same additional details.
3195 2008-09-22 Marek Safar <marek.safar@gmail.com>
3197 A fix for bug #324917
3198 * cs-parser.jay: Add missing multidimensional non-expression type
3201 2008-09-22 Marek Safar <marek.safar@gmail.com>
3203 A fix for bug #428191
3204 * anonymous.cs: Create an outer generic fields also for non-storey
3207 2008-09-22 Marek Safar <marek.safar@gmail.com>
3209 A fix for bug #378294
3210 * class.cs: Make fixed size buffers gmcs feature only.
3212 2008-09-22 Marek Safar <marek.safar@gmail.com>
3214 A fix for bug #355622, #324993
3215 * assign.cs, const.cs, class.cs: Create new EmitContext for each
3218 2008-09-19 Marek Safar <marek.safar@gmail.com>
3220 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
3223 2008-09-19 Marek Safar <marek.safar@gmail.com>
3225 A fix for bug #416110
3226 * generic.cs: Struct constraint results in default ctor and
3227 ValueType base type constraint to be set.
3229 2008-09-19 Marek Safar <marek.safar@gmail.com>
3231 A fix for bug #423791
3232 * generic.cs: Fixed params output type type-inference.
3234 2008-09-19 Marek Safar <marek.safar@gmail.com>
3236 * cs-parser.jay, expression.cs: Fixed few expression crashes.
3238 2008-09-19 Marek Safar <marek.safar@gmail.com>
3240 * cs-tokenizer.cs: Don't break on extra partial modifier.
3242 2008-09-19 Marek Safar <marek.safar@gmail.com>
3244 A fix for bug #427592
3245 * generic.cs: Use common parameter resolve method.
3247 2008-09-18 Marek Safar <marek.safar@gmail.com>
3249 A fix for bug #414758
3250 * expression.cs, ecore.cs: Fixed crash when accessing non-static
3253 2008-09-18 Marek Safar <marek.safar@gmail.com>
3255 * driver.cs, namespace.cs: Read types and namespaces after all
3256 requested assemblies are loaded, fixes issues with System.Core
3257 auto-reference, and #419888.
3259 2008-09-18 Marek Safar <marek.safar@gmail.com>
3261 A fix for bug #417705
3262 * cs-parser.jay: Fixed as/is operator expression split.
3264 2008-09-18 Marek Safar <marek.safar@gmail.com>
3266 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3267 Fixed expression tree representation of empty new expression and
3268 new initializer expression.
3270 2008-09-18 Miguel de Icaza <miguel@novell.com>
3272 * eval.cs: Remove warning, keep reference to driver around.
3274 * Hide fields that do not need to be public.
3276 2008-09-17 Marek Safar <marek.safar@gmail.com>
3278 A fix for bug #426385
3279 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3280 conversion for array elements.
3282 2008-09-17 Marek Safar <marek.safar@gmail.com>
3284 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3285 void parsing conflicts.
3287 2008-09-15 Marek Safar <marek.safar@gmail.com>
3289 A fix for bug #425601
3290 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3291 System.Core only when there is no custom ExtensionAttribute
3294 2008-09-15 Miguel de Icaza <miguel@novell.com>
3296 * namespace.cs: Do not report CS0246 (name
3298 2008-09-12 Marek Safar <marek.safar@gmail.com>
3300 A fix for bug #425669
3301 * generic.cs: Don't cache generic static anonymous method
3304 2008-09-12 Marek Safar <marek.safar@gmail.com>
3306 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3307 conflicting constraints.
3309 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3311 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3314 2008-09-12 Marek Safar <marek.safar@gmail.com>
3316 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3317 to null pointer conversion fixes.
3319 2008-09-11 Marek Safar <marek.safar@gmail.com>
3321 * cs-parser.jay, expression.cs: An implicitly typed local variable
3322 declarator cannot use an array initializer.
3324 2008-09-11 Marek Safar <marek.safar@gmail.com>
3326 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3328 2008-09-11 Marek Safar <marek.safar@gmail.com>
3330 * generic.cs (InflatedConstraints): Don't crash when constraints
3333 * cs-parser.jay: const_declarator is a block.
3335 * constant.cs: Check for not allowed NaN conversions.
3337 2008-09-10 Miguel de Icaza <miguel@novell.com>
3339 * driver.cs: Drop --shell argument, the compiler is no longer a
3342 * eval.cs: Move most of the code that deals with evaluation into
3343 this file and document the public API from repl.cs
3345 * repl.cs: Remove from here.
3347 2008-09-10 Marek Safar <marek.safar@gmail.com>
3349 A fix for bug #424684
3350 * generic.cs: Generic class constraints must come first.
3352 2008-09-09 Miguel de Icaza <miguel@novell.com>
3354 * cs-parser.jay: Improve error reporting for syntax errors in
3355 statements and expressions, we now report the expected tokens
3356 instead of reporting the useless "; expected".
3358 Drop the strings from the token declaration, it turns out that
3359 they did not do what I thought they did. Instead they were adding
3360 two sets of tokens to the tables.
3362 2008-09-09 Marek Safar <marek.safar@gmail.com>
3364 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3365 delegate.cs: Share special type check.
3367 2008-09-09 Marek Safar <marek.safar@gmail.com>
3369 A fix for bug #423981
3370 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3372 2008-09-09 Marek Safar <marek.safar@gmail.com>
3374 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3377 2008-09-09 Marek Safar <marek.safar@gmail.com>
3379 A fix for bugs: #324750, #335946
3380 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3381 lookup rule to determine ?-based tokens.
3383 2008-09-08 Miguel de Icaza <miguel@novell.com>
3385 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3386 expressions (like event adding or removing) end up here, so we
3387 need to treat those as statements.
3389 Add LoadAssembly method.
3391 2008-09-04 Miguel de Icaza <miguel@novell.com>
3393 * repl.cs: Add Time method.
3395 2008-09-05 Marek Safar <marek.safar@gmail.com>
3397 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3399 2008-09-05 Miguel de Icaza <miguel@novell.com>
3401 * repl.cs: Add workaround for old compilers.
3403 2008-09-04 Jb Evain <jbevain@novell.com>
3405 * repl.cs (PrettyPrint): pretty print everything that
3406 implements IDictionary, as well as IEnumerables. Also,
3407 add a quit helper property.
3409 2008-09-04 Marek Safar <marek.safar@gmail.com>
3411 * constant.cs: Better error reporting for decimal literals.
3413 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3416 2008-09-04 Marek Safar <marek.safar@gmail.com>
3417 Miguel de Icaza <miguel@novell.com>
3419 A fix for bug #422951
3420 * assign.cs (Assign.DoResolve): Perform the type conversions
3421 checks before we attempt to initialize `New' initializers.
3423 2008-09-04 Marek Safar <marek.safar@gmail.com>
3425 A fix for bug #422853
3426 * delegate.cs (DelegateCreation): Add special handling for
3427 EmptyExpression.Null instance expression which is just another
3428 hack for undecided member instance exression.
3430 2008-09-04 Marek Safar <marek.safar@gmail.com>
3432 * expression.cs, ecore.cs: Emit full expression tree for reduced
3435 2008-09-04 Marek Safar <marek.safar@gmail.com>
3437 * expression.cs (This): Guard against multi-resolving.
3439 * ecore.cs, statement.cs (Throw): Simplified.
3441 * flowanalysis.cs: Also verify event fields.
3443 2008-09-04 Miguel de Icaza <miguel@novell.com>
3445 * assign.cs (Assign.DoResolve): Perform the type conversions
3446 checks before we attempt to initialize `New' initializers.
3448 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3450 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3453 * repl.cs: Update help.
3455 2008-09-03 Miguel de Icaza <miguel@novell.com>
3457 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3458 handling of the default config handling, including the special
3459 treatment of System.Core assembly.
3461 Fixes the REPL processing for LINQ.
3463 2008-09-03 Marek Safar <marek.safar@gmail.com>
3465 A fix for bug #422507
3466 * expression.cs (UnboxCast): Add missing child expression mutator.
3468 2008-09-03 Marek Safar <marek.safar@gmail.com>
3470 * driver.cs: Don't self reference System.Core assembly.
3472 2008-09-03 Marek Safar <marek.safar@gmail.com>
3474 A fix for bug #422507
3475 * expression.cs (StringConcat): Add missing type mutator.
3477 2008-09-03 Marek Safar <marek.safar@gmail.com>
3479 * generic.cs (TypeInferenceContext): Follow equality rule for
3480 constructed type lower bound type inference.
3482 2008-09-02 Miguel de Icaza <miguel@novell.com>
3484 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3485 <dblank@cs.brynmawr.edu> which updates the cursor position on
3488 2008-09-02 Marek Safar <marek.safar@gmail.com>
3490 A fix for bug #367145
3491 * driver.cs: Fixed import of extension methods when using -noconfig
3494 2008-09-02 Marek Safar <marek.safar@gmail.com>
3496 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3497 version from non-generic implementation instead.
3499 2008-09-01 Marek Safar <marek.safar@gmail.com>
3501 A fix for bug #418908
3502 * class.cs: Use AddScopeStatement for field initializers.
3504 2008-09-01 Marek Safar <marek.safar@gmail.com>
3506 A fix for bug #415385
3507 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3509 2008-09-01 Marek Safar <marek.safar@gmail.com>
3511 A fix for bug #421736
3512 * iterators.cs: Don't crash on unreachable iterators.
3514 2008-09-01 Marek Safar <marek.safar@gmail.com>
3516 A fix for bug #421628
3517 * parameter.cs, attribute.cs: Clone also parameter attributes.
3519 2008-08-30 Miguel de Icaza <miguel@novell.com>
3521 * namespace.cs (LookupType): In EvalMode, try to replace
3522 the TypeBuilder from our cache with a Type as Reflection.Emit does
3523 not like to mix code from older assemblies emitted and new
3526 This sounds like a serious Mono bug that prevents multiple
3527 assemblies to be generated and consumed at the same time.
3529 * cs-parser.jay (push_current_class): Do not make interactive
3530 classes internal or private, make them public as we currently
3531 generate each new class in a new assembly.
3533 2008-08-29 Miguel de Icaza <miguel@novell.com>
3535 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3536 remove types that are entered into the global namespace during
3537 parsing so that we can remove them on failure.
3539 * cs-parser.jay: Parsing: we now keep track of types that are
3540 entered into global variables and queue those in case the parsing
3543 This happens in a few situations: during partial-input, we invoke
3544 the parser repeatedly for example with the string "class X", this
3545 would cause X to be registed, and we need to remove this
3546 registration so that another parse attempt later with say "class X {"
3547 would actually work.
3549 Additionally, if there is an error in the resolution phase, for
3550 example: "class X : NonExistant {}" th
3552 * cs-parser.jay: Be more precise with the errors being raised,
3553 instead of flagging all exceptions during parsing to be attributed
3554 to the parsing process, distinguish those from errors happening in
3555 the actions and hint that using -v would produce the actual
3558 * repl.cs: Do not load all compiler references on each reset,
3559 doing the partial reset takes care of this.
3561 2008-08-28 Miguel de Icaza <miguel@novell.com>
3563 * repl.cs: Add support for loading all the files from
3564 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3567 Introduce a micro-parser that is able to deambiguate on its input
3568 whether we are dealing with a compilation unit (namespace, class,
3569 interface, struct, delegate) declaration or a statement. This
3570 allows both declarations and statements to be entered.
3572 Set history size by default to 300 lines.
3574 Instead of distinguishing based on the parser.InteractiveResult,
3575 have only two cases: statements were parsed, or a compilation unit
3576 was. Always pull the Using statement additions from the
3577 compilation unit parse.
3579 * cs-tokenizer.cs: Rename tokens to better describe their intent
3580 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3582 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3583 EvalMode is used to trigger the lookup of global variables while
3584 StatementMode is used turn variable declarations into static
3587 * getline.cs: Allow history size to be set.
3589 2008-08-29 Marek Safar <marek.safar@gmail.com>
3591 A fix for bug #360755
3592 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3594 2008-08-29 Marek Safar <marek.safar@gmail.com>
3596 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3598 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3599 member name, it is too confusing
3601 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3603 * rootcontext.cs: Finally default to warning level 4.
3605 2008-08-28 Marek Safar <marek.safar@gmail.com>
3607 * class.cs (CheckBase): Ignore overloaded operators.
3609 2008-08-28 Marek Safar <marek.safar@gmail.com>
3611 A fix for bug #420830
3612 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3614 2008-08-28 Marek Safar <marek.safar@gmail.com>
3616 A fix for bug #420832
3617 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3619 2008-08-28 Marek Safar <marek.safar@gmail.com>
3621 A fix for bug #420386
3622 * nullables.cs: Fixed logic of nullable user comparison operators involving
3625 2008-08-28 Marek Safar <marek.safar@gmail.com>
3627 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3629 2008-08-27 Miguel de Icaza <miguel@novell.com>
3631 * repl.cs: Add support for aborting the running code with C-c.
3633 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3635 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3637 2008-08-27 Miguel de Icaza <miguel@novell.com>
3639 * cs-parser.jay (interactive_statement_list): A new set of rules
3640 for hosting statements that uses the "interactive_" prefix.
3642 * repl.cs: Add support for parsing `using' as a statement or as a
3643 directive. Deambiguating before passing this to the parser.
3645 We need to distinguish statement_expressions that occur at the
3646 toplevel vs those that occur embedded into expressions.
3648 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3649 that fixes the cursor key handling, and a history bug.
3651 2008-08-26 Miguel de Icaza <miguel@novell.com>
3653 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3654 limitations in Console, instead the 2.0 bootstrap libraries now
3655 include the Console bits.
3657 Also, remove the use of Nullables from getline.cs
3661 Interactive support for the C# compiler. Use gmcs --shell to
3662 enter a read-eval-print loop shell.
3664 Docs: http://www.mono-project.com/CsharpRepl
3666 * sources: include repl.cs here and getline.cs for gmcs.exe,
3667 everything else is getline.cs impaired.
3669 * Makefile: when bootstrapping pass a special flag
3670 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3671 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3672 This distinguishes those two cases.
3674 * repl.cs: Support for a read-eval-print loop. Will be soon
3675 refactored into eval support and then REPL on top of it.
3677 * ecore.cs: If a simplename lookup fails, before erroring out,
3678 if we are in EvalMode to resolve the name to a declaration in the
3681 This means that variable declarations that happened in previous
3682 classes (as repl puts every statement in a separate class) are
3683 made visible in this way.
3685 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3686 triggered an error due to the end of file being reached. This is
3687 used to do multi-line input, and notify the caller that the user
3688 needs to provide more text before a successful parse.
3690 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3691 to drive the evaluation with a custom wrapper.
3693 * driver.cs: Add support for --shell, and refactor some code to be
3696 * namespace.cs: Add support for serializing the contents of the
3697 namespaces and reloading them.
3699 * getline.cs: A managed implementation of ReadLine under
3700 X11/Apache2 license terms. Easy to embed in other applications as
3703 * namespace.cs: Add some functions to save and restore the
3706 * rootcontext.cs: New public field.
3708 * cs-tokenizer.cs: Add support for one of the possible characters
3709 we introduce into the token stream.
3711 This patch does not affect the regular tokenization process, the
3712 only performance hit would happen if there is an invalid character
3713 on the input string.
3715 * support.cs: Move isatty helper routine here.
3717 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3718 code generator for in-memory assemblies.
3720 2008-08-26 Marek Safar <marek.safar@gmail.com>
3722 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3723 parameter cannot be always used as a type.
3725 2008-08-21 Marek Safar <marek.safar@gmail.com>
3727 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3729 2008-08-21 Marek Safar <marek.safar@gmail.com>
3731 * convert.cs: Implement explicit array to IList<T> conversion.
3733 2008-08-20 Marek Safar <marek.safar@gmail.com>
3735 A fix for bug #362740
3736 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3738 2008-08-20 Marek Safar <marek.safar@gmail.com>
3740 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3741 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3742 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3743 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3744 handling to use just one type of infrastructure and deal with generics
3747 2008-07-23 Martin Baulig <martin@ximian.com>
3749 *** Merged this from trunk revision 108527 ***
3752 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3753 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3756 2008-08-15 Marek Safar <marek.safar@gmail.com>
3758 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3761 2008-08-15 Marek Safar <marek.safar@gmail.com>
3763 * delegate.cs: Fixed compiler crash when creating delegate using partial
3766 * typemanager.cs: MulticastDelegate is not a delegate.
3768 2008-08-14 Marek Safar <marek.safar@gmail.com>
3770 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3773 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3775 * cs-parser.jay (type): Allow 'var' in mcs too.
3776 (local_variable_type): Likewise.
3778 2008-08-14 Marek Safar <marek.safar@gmail.com>
3780 * driver.cs: Removed broken -noconfig variants.
3782 2008-08-14 Marek Safar <marek.safar@gmail.com>
3784 A fix for bug #417078
3785 * expression.cs: Emit correctly left side pointer operators.
3787 2008-08-13 Marek Safar <marek.safar@gmail.com>
3789 * generic.cs, lambda.cs: Inflate method generic arguments only.
3791 2008-08-12 Marek Safar <marek.safar@gmail.com>
3793 * class.cs: Fixed struct layout check regression.
3795 2008-08-12 Marek Safar <marek.safar@gmail.com>
3797 * cs-parser.jay, enum.cs: Simplified enum parsing.
3799 * decl.cs: Check all type parameters conflicts.
3801 * expression.cs, statement.cs, attribute.cs: More expression checks.
3803 2008-08-11 Marek Safar <marek.safar@gmail.com>
3805 * generic.cs: Add type inference types restriction.
3807 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3808 anonymous.cs, expression.cs: Allocate less accessor parameters.
3810 2008-08-08 Marek Safar <marek.safar@gmail.com>
3812 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3815 2008-08-08 Marek Safar <marek.safar@gmail.com>
3817 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3819 2008-08-07 Marek Safar <marek.safar@gmail.com>
3821 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3822 Also fixes #362146 and #381592.
3824 2008-08-07 Marek Safar <marek.safar@gmail.com>
3826 * ecore.cs: Reduced constant cannot be used as an attribute value.
3828 * cs-parser.jay: Base expression has to be a type.
3830 * expression.cs (Conditional): Uses ReducedExpression.
3832 2008-08-06 Marek Safar <marek.safar@gmail.com>
3834 A fix for bug #376826
3835 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3836 address of hoisted local variable or parameter cannot be taken.
3838 2008-08-05 Marek Safar <marek.safar@gmail.com>
3840 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3841 anonymous method inside checked/unchecked expression.
3843 2008-08-05 Marek Safar <marek.safar@gmail.com>
3845 * typemanager.cs (IsEqual): Guard against null.
3847 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3848 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3849 routine. Fixed few misleading conversion errors.
3851 2008-08-04 Marek Safar <marek.safar@gmail.com>
3853 * class.cs: Consider generics when checking cycles in struct layout.
3855 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3857 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3859 2008-08-04 Marek Safar <marek.safar@gmail.com>
3861 A fix for bug #414165
3862 * anonymous.cs: Use same anonymous implementation method for all anonymous
3865 2008-08-04 Marek Safar <marek.safar@gmail.com>
3867 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3870 2008-08-04 Marek Safar <marek.safar@gmail.com>
3872 * cs-parser.jay: Typeof argument has to be a type expression.
3874 * namespace.cs: Check alias and namespace definitions collisions.
3876 * class.cs, pending.cs: Moved explicit interface accessor implementation
3879 * delegate.cs, expression.cs: Verify special name invocations.
3881 2008-08-01 Marek Safar <marek.safar@gmail.com>
3883 * cs-parser.jay: Don't choke on empty generic type arguments.
3885 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3887 * expression.cs, ecore.cs: Minor expressions bugs.
3889 2008-08-01 Marek Safar <marek.safar@gmail.com>
3891 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3892 and added more error handling.
3894 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3896 * modifiers.cs, enum.cs: Fixed.
3898 2008-07-31 Jb Evain <jbevain@novell.com>
3900 * driver.cs: remove -pkg ability of smcs.
3902 2008-07-30 Marek Safar <marek.safar@gmail.com>
3904 * statement.cs (Switch): Correctly set empty default target for single
3907 2008-07-30 Marek Safar <marek.safar@gmail.com>
3909 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3910 string switch statement implementation to use string dictionary which
3911 significantly (2-8x) improves performance of generated code.
3913 2008-07-29 Marek Safar <marek.safar@gmail.com>
3915 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3916 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3918 2008-07-29 Marek Safar <marek.safar@gmail.com>
3920 A fix for bug #412595
3921 * typemanager.cs, convert.cs, expression.cs: Some types are never
3922 convertible to each other.
3924 2008-07-29 Marek Safar <marek.safar@gmail.com>
3926 * nullable.cs (CreateNullConstant): An error messages update.
3928 2008-07-29 Marek Safar <marek.safar@gmail.com>
3930 A fix for bug #412595
3931 * cfold.cs: Don't cast undefined bool constant.
3933 2008-07-29 Martin Baulig <martin@ximian.com>
3936 (SymbolWriter.Reset): New public static method.
3939 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3941 2008-07-28 Marek Safar <marek.safar@gmail.com>
3943 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3945 * expression.cs (ElementAccess): Exact size allocation.
3947 2008-07-26 Marek Safar <marek.safar@gmail.com>
3949 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3951 2008-07-25 Marek Safar <marek.safar@gmail.com>
3953 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3955 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3958 2008-07-25 Marek Safar <marek.safar@gmail.com>
3960 A fix for bug #412217
3961 * assign.cs: Mutate also assignment type.
3963 2008-07-25 Marek Safar <marek.safar@gmail.com>
3965 A fix for bug #323644
3966 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3969 2008-07-25 Marek Safar <marek.safar@gmail.com>
3971 A fix for bug #412134
3972 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3973 non-enumerable operands when overloading equality or bitwise operators.
3975 2008-07-25 Marek Safar <marek.safar@gmail.com>
3977 * anonymous.cs: Cache closed generic anonymous method delegates.
3979 2008-07-24 Marek Safar <marek.safar@gmail.com>
3981 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3982 anonymous.cs, statement.cs: Always emit anonymous method as static method
3983 when is instance free. Use nesting for nested anynomous methods blocks.
3985 2008-07-23 Marek Safar <marek.safar@gmail.com>
3987 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3990 2008-07-23 Marek Safar <marek.safar@gmail.com>
3992 * expression.cs: Removed MakeSimpleCall.
3994 2008-07-23 Marek Safar <marek.safar@gmail.com>
3996 A fix for bug #323012
3997 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3998 Base method implementing interface has to be public.
4000 2008-07-23 Marek Safar <marek.safar@gmail.com>
4002 * cs-parser.jay: Don't break on missing argument.
4004 2008-07-22 Marek Safar <marek.safar@gmail.com>
4006 A fix for bug #320993
4007 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
4008 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
4010 2008-07-22 Marek Safar <marek.safar@gmail.com>
4012 A fix for bug #320748
4013 * convert.cs: Implicit user operators cannot convert to interfaces
4015 2008-07-22 Marek Safar <marek.safar@gmail.com>
4017 A fix for bug #312686
4018 * driver.cs: Ignore empty assembly references.
4020 2008-07-22 Marek Safar <marek.safar@gmail.com>
4022 A fix for bug #387040
4023 * ecore.cs: Skip constrains check for an explicit implementation.
4025 2008-07-21 Marek Safar <marek.safar@gmail.com>
4027 A fix for bug #409045
4028 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
4029 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
4030 identifiers are file specific unless passed as input arguments.
4032 2008-07-21 Marek Safar <marek.safar@gmail.com>
4034 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
4035 to emit UnmanagedMarshal data under 2.0 profile.
4037 2008-07-21 Marek Safar <marek.safar@gmail.com>
4039 A fix for bug #410369
4040 * parameter.cs: Clone correctly ParamsParameter.
4042 2008-07-21 Marek Safar <marek.safar@gmail.com>
4044 * expression.cs (Argument): Always report type for type based expressions
4047 2008-07-18 Marek Safar <marek.safar@gmail.com>
4049 A fix for bug #410666
4050 * anonymous.cs: Correctly initialize generic storey reference.
4052 2008-07-18 Marek Safar <marek.safar@gmail.com>
4054 * convert.cs: Don't box same type arguments.
4056 2008-07-18 Marek Safar <marek.safar@gmail.com>
4058 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
4059 Finished missing generic type mutators.
4061 2008-07-18 Marek Safar <marek.safar@gmail.com>
4063 * iterators.cs, statement.cs: Finished statements CloneTo.
4065 2008-07-18 Marek Safar <marek.safar@gmail.com>
4067 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
4069 * expression.cs: Emit optimized default value expressions in expression tree
4072 2008-07-18 Marek Safar <marek.safar@gmail.com>
4074 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
4076 2008-07-17 Marek Safar <marek.safar@gmail.com>
4078 A fix for bug #367536
4079 * cs-parser.jay: Check static constructor of generic types for an access
4082 2008-07-17 Marek Safar <marek.safar@gmail.com>
4084 A fix for bug #353800
4085 * lambda.cs: Emit ret for contextual statements.
4087 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
4088 up emitting redundant ret for all anonymous methods with return.
4090 2008-07-17 Marek Safar <marek.safar@gmail.com>
4092 A fix for bug #365188
4093 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
4094 create anonymous method storey in unreachable block.
4096 2008-07-17 Marek Safar <marek.safar@gmail.com>
4098 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
4099 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
4100 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
4101 statement.cs: Fixed relevant defects found by Gendarme.
4103 2008-07-17 Marek Safar <marek.safar@gmail.com>
4105 A fix for bug #325291
4106 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
4107 statement.cs: Replaced IAnonymousHost with top level block flag.
4109 2008-07-17 Marek Safar <marek.safar@gmail.com>
4111 * cs-parser.jay: Clean up unused open_parens.
4113 2008-07-17 Marek Safar <marek.safar@gmail.com>
4115 * ecore.cs: Custom error message for a range variable assignment.
4117 2008-07-16 Marek Safar <marek.safar@gmail.com>
4119 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
4122 2008-07-16 Marek Safar <marek.safar@gmail.com>
4124 * literal.cs: Null literal is of object type.
4126 2008-07-16 Marek Safar <marek.safar@gmail.com>
4128 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
4129 expression of nullable equality comparison.
4131 2008-07-15 Marek Safar <marek.safar@gmail.com>
4133 * expression.cs(PointerArithmetic): Removed redundant assignment.
4135 2008-07-15 Marek Safar <marek.safar@gmail.com>
4137 * decl.cs (GetSignatureForError): Report full namespace name for containers.
4139 2008-07-14 Marek Safar <marek.safar@gmail.com>
4141 A fix for bug #408361
4142 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
4143 they are replaced by GetMethod.
4145 2008-07-14 Marek Safar <marek.safar@gmail.com>
4147 A fix for bug #408721 by jeremie.laval@gmail.com
4148 * expression.cs (Indirection): Implemented CloneTo.
4150 2008-07-14 Marek Safar <marek.safar@gmail.com>
4152 * statement.cs (AssignableSlots): Temporary disabled variable initialization
4155 2008-07-14 Marek Safar <marek.safar@gmail.com>
4157 * report.cs (EnableReporting): Don't reinitialize 0-based values.
4159 2008-07-11 Marek Safar <marek.safar@gmail.com>
4161 * linq.cs: Reset tranparent parameter counter in probing mode.
4163 2008-07-11 Marek Safar <marek.safar@gmail.com>
4165 * anonymous.cs: Mutate anonymous method type.
4167 2008-07-11 Marek Safar <marek.safar@gmail.com>
4169 * ecore.cs, anonymous.cs: Mutate field expressions.
4171 2008-07-10 Marek Safar <marek.safar@gmail.com>
4173 A fix for bug #369670
4174 * linq.cs, statement.cs: Use explicit block for query expressions variables.
4176 2008-07-10 Marek Safar <marek.safar@gmail.com>
4178 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
4180 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
4183 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
4184 only one '>', and finds a '>>', abort the generic lookahead.
4186 2008-07-10 Marek Safar <marek.safar@gmail.com>
4188 A fix for bug #319902
4189 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
4191 2008-07-10 Marek Safar <marek.safar@gmail.com>
4193 A fix for bug #406371
4194 * statement.cs: Moved EmitSymbolInfo to Block.
4196 2008-07-09 Marek Safar <marek.safar@gmail.com>
4198 * ecore.cs: Report better error for extension method overload failures.
4200 2008-07-09 Marek Safar <marek.safar@gmail.com>
4202 * expression.cs (Is): No need to box reference values.
4204 2008-07-09 Marek Safar <marek.safar@gmail.com>
4206 * class.cs: Use event resolve context when initializing CreateEmitContext.
4208 2008-07-09 Marek Safar <marek.safar@gmail.com>
4210 A fix for bug #394436
4211 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
4212 method used inside expression trees. Added more LINQ to expression tree
4215 2008-07-08 Marek Safar <marek.safar@gmail.com>
4217 A fix for bug #378189, #370577
4218 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
4221 2008-07-08 Marek Safar <marek.safar@gmail.com>
4223 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
4226 2008-07-08 Marek Safar <marek.safar@gmail.com>
4228 A fix for bug #406702
4229 * anonymous.cs: Always park anonymous method in the nearest parent storey.
4231 2008-07-07 Marek Safar <marek.safar@gmail.com>
4233 A fix for bug #406648
4234 * cs-parser.jay: Report nullable use in mcs for some cases.
4236 2008-07-07 Marek Safar <marek.safar@gmail.com>
4238 * ecore.cs: Improved argument mismatch error messages.
4240 2008-07-07 Marek Safar <marek.safar@gmail.com>
4242 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
4244 2008-07-07 Marek Safar <marek.safar@gmail.com>
4246 * expression.cs (TypeOf): Mutate type argument.
4248 2008-07-04 Marek Safar <marek.safar@gmail.com>
4250 * class.cs: Report missing partial modifier for correct type.
4252 2008-07-04 Marek Safar <marek.safar@gmail.com>
4254 * ecore.cs, expression.cs (VariableReference): Variable property is
4257 2008-07-04 Marek Safar <marek.safar@gmail.com>
4259 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4261 2008-07-04 Marek Safar <marek.safar@gmail.com>
4263 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4266 2008-07-04 Marek Safar <marek.safar@gmail.com>
4268 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4269 anonymous method storey to an instance method when only "this" is hoisted.
4271 2008-07-03 Marek Safar <marek.safar@gmail.com>
4273 A fix for bug #321615
4274 * expression.cs: Pointer comparisons use unsigned operator.
4276 2008-07-03 Marek Safar <marek.safar@gmail.com>
4278 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4280 2008-07-02 Marek Safar <marek.safar@gmail.com>
4282 A fix for bug #404905
4283 * class.cs: Always initialize local unsafe variables.
4285 2008-06-30 Marek Safar <marek.safar@gmail.com>
4287 A fix for bug #396987
4288 * expression.cs (NewInitialize): Clear local temporary variable for next run
4290 2008-06-27 Marek Safar <marek.safar@gmail.com>
4292 A fix for bug #401020
4293 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4295 2008-06-27 Marek Safar <marek.safar@gmail.com>
4297 A fix for bug #398319
4298 * cs-parser.jay: Implemented undocumented base access expression inside
4301 2008-06-26 Marek Safar <marek.safar@gmail.com>
4303 A fix for bug #404227
4304 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4306 2008-06-26 Marek Safar <marek.safar@gmail.com>
4308 A fix for bug #404227
4309 * convert.cs: Fixed explicit array to interface cast.
4311 2008-06-26 Marek Safar <marek.safar@gmail.com>
4313 A fix for bug #403894
4314 * delegate.cs: Mutate DelegateInvocation type.
4316 2008-06-26 Marek Safar <marek.safar@gmail.com>
4318 A fix for bug #379348
4319 * delegate.cs: Box a load of generic parameters.
4321 2008-06-26 Marek Safar <marek.safar@gmail.com>
4323 * expression.cs: Add an array creation arguments mutate.
4325 2008-06-26 Marek Safar <marek.safar@gmail.com>
4327 A fix for bug #386068
4328 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4331 2008-06-25 Marek Safar <marek.safar@gmail.com>
4333 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4336 2008-06-25 Marek Safar <marek.safar@gmail.com>
4338 A fix for bug #403518
4339 * delegate.cs: Type correctly anonymous method new invocation.
4341 2008-06-24 Marek Safar <marek.safar@gmail.com>
4343 A fix for bug #394826
4344 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4347 2008-06-24 Marek Safar <marek.safar@gmail.com>
4349 A fix for bug #394826
4350 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4353 2008-06-24 Marek Safar <marek.safar@gmail.com>
4355 * class.cs: Clone indexer parameters for localized capturing.
4357 2008-06-24 Marek Safar <marek.safar@gmail.com>
4359 A fix for bug #402379
4360 * expression.cs: Don't crash when an object initializer resolve fails.
4362 2008-06-24 Marek Safar <marek.safar@gmail.com>
4364 A fix for bug #402888
4365 * expression.cs: Mutate conditional expression.
4367 2008-06-24 Marek Safar <marek.safar@gmail.com>
4369 A fix for bug #401012
4370 * class.cs: Keep StructLayout in shared container.
4372 2008-06-24 Marek Safar <marek.safar@gmail.com>
4374 A fix for bug #400438
4375 * decl.cs, class.cs: Only properties can be automatically implemented.
4377 2008-06-24 Marek Safar <marek.safar@gmail.com>
4379 * statement.cs (ChangeToIterator): Copy also labels.
4381 2008-06-23 Marek Safar <marek.safar@gmail.com>
4383 * ecore.cs: Pass type argument details to parent extension method.
4385 2008-06-23 Marek Safar <marek.safar@gmail.com>
4387 A fix for bug #375966
4388 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4390 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4392 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4394 2008-06-22 Marek Safar <marek.safar@gmail.com>
4396 A fix for bug #394347
4397 * anonymous.cs: Cache compatible delegates as compatibility check produces
4398 a new method every time.
4400 2008-06-20 Marek Safar <marek.safar@gmail.com>
4402 * anonymous.cs: Propagate storey reference for single references.
4404 2008-06-20 Marek Safar <marek.safar@gmail.com>
4406 A fix for bug #387615
4407 * assign.cs, expression.cs: Correctly clone compound assignment.
4409 2008-06-19 Marek Safar <marek.safar@gmail.com>
4411 A fix for bug #359611, #359604
4412 * anonymous.cs: Mutate all types of hoisted parameters.
4414 2008-06-19 Marek Safar <marek.safar@gmail.com>
4416 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4417 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4418 expression.cs, codegen.cs, statement.cs
4420 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4421 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4423 ** Anonymous methods, lambda expressions rewrite **
4425 Anonymous expressions are now resolved when an explicit block is resolved
4426 and they don't require any registration procedure anymore. Further,
4427 anonymous methods are defined when explicit block is emitted which allows
4428 better control of whole process and opens possibilities for more
4429 optimizations as well as alternative to reverse whole process.
4431 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4432 process consistent and to correctly emit hoisted generic methods when they
4433 have at least 1 hoisted variable.
4435 2008-06-17 Martin Baulig <martin@ximian.com>
4437 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4439 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4440 virtual property; check it in Emit().
4441 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4443 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4445 (Indexer.Define): Likewise.
4447 2008-06-17 Marek Safar <marek.safar@gmail.com>
4449 * convert.cs: Don't use IsInterface on type arguments.
4451 * delegate.cs: DelegateInvocation uses MethodInfo.
4453 * parameter.cs: Removed IsTypeParameter.
4455 * generic-mcs.cs: More missing stuff.
4457 2008-06-16 Martin Baulig <martin@ximian.com>
4460 (Modifiers.DEBUGGER_HIDDEN): New public const.
4463 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4466 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4467 (AbstractPropertyEventMethod): Likewise.
4468 (Constructor.Emit): Likewise.
4469 (SourceMethod.SetCompilerGenerated): Removed.
4471 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4475 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4476 if we're an `IteratorHost'.
4477 (AnonymousMethodMethod..ctor): Don't set
4478 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4481 2008-06-16 Marek Safar <marek.safar@gmail.com>
4483 * statement.cs: Clean-up foreach statements.
4485 2008-06-12 Marek Safar <marek.safar@gmail.com>
4487 * class.cs: Stop using public method which should not exist
4488 (MethodBuilder.SetGenericMethodSignature).
4490 2008-06-11 Martin Baulig <martin@ximian.com>
4493 (Location.LookupFile): Add `CompilationUnit' argument; when given
4494 a relative file name, make it relative to the directory the .cs
4495 file is located in instead of using the current directory.
4497 2008-06-11 Martin Baulig <martin@ximian.com>
4500 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4501 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4502 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4503 (SourceMethod.SetCompilerGenerated): Likewise.
4505 2008-06-11 Marek Safar <marek.safar@gmail.com>
4507 * codegen.cs, driver: Only write symbol file when it's asked for.
4509 2008-06-11 Marek Safar <marek.safar@gmail.com>
4511 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4513 2008-06-10 Martin Baulig <martin@ximian.com>
4515 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4517 2008-06-09 Marek Safar <marek.safar@gmail.com>
4519 A fix for bug #316290
4520 * expression.cs: Include decimal operators in predefined table.
4522 * parameters.cs: More readonlyness.
4524 2008-06-09 Marek Safar <marek.safar@gmail.com>
4526 A fix for bug #397213
4527 * cs-parser.jay: One more missing current_local_parameters reset.
4529 2008-06-09 Marek Safar <marek.safar@gmail.com>
4531 A fix for bug #396633
4532 * class.cs: Host backing field in partial container.
4534 2008-06-09 Marek Safar <marek.safar@gmail.com>
4536 A fix for bug #397068
4537 * expression.cs: Check both operand types when predefined operator is used.
4539 2008-06-05 Martin Baulig <martin@ximian.com>
4541 Merged the `debugger-kahalo' branch.
4544 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4545 we're an iterator method.
4546 (SourceMethod): Reflect latest symbol writer changes;
4547 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4548 now `start_row' and `end_row'.
4549 (Constructor.Emit): Fix the logic whether to emit symbol information.
4551 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4555 (CompilationUnit): New public class; derives from `SourceFile'.
4556 (SourceFileEntry.DefineSymbolInfo): New public method.
4557 (SourceFileEntry.SetChecksum): New public method.
4558 (Location): Encode hidden line numbers by using `column == 255';
4559 the .ctor now accepts `column == -1' to mark a hidden line number.
4560 (Location.Hidden): New public property.
4561 (Location.CheckPoint): Add `CompilationUnit'.
4562 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4563 (Location.Push): Add `CompilationUnit compile_unit' argument.
4564 (Location.CompilationUnit): New public property.
4567 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4569 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4571 * driver.cs: `SourceFile' -> `CompilationUnit'.
4573 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4575 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4577 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4581 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4582 new symbol writer API to also pass the file.
4584 2008-06-05 Marek Safar <marek.safar@gmail.com>
4586 * statement.cs: Emit catch variable assignment using variable expression.
4588 2008-06-05 Marek Safar <marek.safar@gmail.com>
4590 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4591 with other variable types.
4593 2008-06-04 Marek Safar <marek.safar@gmail.com>
4595 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4596 GetLength method emit, it breaks resolve rules.
4598 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4599 Marek Safar <marek.safar@gmail.com>
4601 A fix for bug #395542
4602 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4605 2008-06-02 Marek Safar <marek.safar@gmail.com>
4607 A fix for bug #395287
4608 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4610 2008-05-31 Marek Safar <marek.safar@gmail.com>
4612 A fix for bug #395845
4613 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4614 non-nullable parameter type.
4616 2008-05-31 Marek Safar <marek.safar@gmail.com>
4618 * class.cs: Handle contructor initializer as a statement in top-level block.
4620 2008-05-30 Marek Safar <marek.safar@gmail.com>
4622 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4623 security attributes.
4625 2008-05-24 Marek Safar <marek.safar@gmail.com>
4627 * ecore.cs, expression.cs: Small IVariable refactoring.
4629 2008-05-22 Marek Safar <marek.safar@gmail.com>
4631 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4633 2008-05-21 Marek Safar <marek.safar@gmail.com>
4635 * cs-parser.jay: Removed redundant catch type check.
4637 2008-05-21 Marek Safar <marek.safar@gmail.com>
4639 A fix for bug #390372
4640 * nullable.cs: Set correct return type.
4642 2008-05-21 Marek Safar <marek.safar@gmail.com>
4644 A fix for bug #391062
4645 * typemanager.cs: Fixed crash when comparing null types.
4647 2008-05-21 Marek Safar <marek.safar@gmail.com>
4649 A fix for bug #391871
4650 * cs-parser.jay: Better error handling for invalid catch type.
4652 2008-05-20 Marek Safar <marek.safar@gmail.com>
4654 A fix for bug #392155
4655 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4657 2008-05-15 Marek Safar <marek.safar@gmail.com>
4659 A fix for bug #390666
4660 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4663 2008-05-15 Marek Safar <marek.safar@gmail.com>
4665 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4668 2008-05-13 Marek Safar <marek.safar@gmail.com>
4670 A fix for bug #389625
4671 * delegate.cs, generic.cs: Some progress on method group return type
4674 2008-05-13 Marek Safar <marek.safar@gmail.com>
4676 A fix for bug #378419
4677 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4679 2008-05-12 Marek Safar <marek.safar@gmail.com>
4681 * class.cs (Constructor): Added IsCompilerGenerated.
4683 2008-05-12 Marek Safar <marek.safar@gmail.com>
4685 * expression.cs: Enum binary operators can accept non-enum operand only when
4686 is implicitly convertible to underlying type.
4688 2008-05-12 Marek Safar <marek.safar@gmail.com>
4690 A fix for bug #389272
4691 * support.cs: Workaround System.InvalidOperationException for enums.
4693 2008-05-12 Marek Safar <marek.safar@gmail.com>
4695 A fix for bug #389073
4696 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4698 2008-05-10 Marek Safar <marek.safar@gmail.com>
4700 * driver.cs: Split Parse.
4702 * location.cs (LookupFile): Uses string.Empty.
4704 2008-05-07 Marek Safar <marek.safar@gmail.com>
4706 * expression.cs, parameter.cs: Small ParameterReference clean up.
4708 2008-05-07 Marek Safar <marek.safar@gmail.com>
4710 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4711 hack. Fixes #387502.
4713 2008-05-06 Martin Baulig <martin@ximian.com>
4715 * class.cs (Constructor.Emit): Fix the logic whether to emit
4718 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4721 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4722 InvalidOperationException when the iterator is before the start or
4725 2008-05-06 Marek Safar <marek.safar@gmail.com>
4727 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4728 when left is nullable type.
4730 2008-05-06 Marek Safar <marek.safar@gmail.com>
4732 A fix for bug #386628
4733 * expression.cs (LocalVariableReference): Continue in resolving when
4734 variable is not assigned.
4736 2008-05-05 Marek Safar <marek.safar@gmail.com>
4738 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4739 nullable operations.
4741 2008-05-04 Marek Safar <marek.safar@gmail.com>
4743 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4744 it saves many redundant temporary variables for nullable operations.
4746 2008-05-03 Marek Safar <marek.safar@gmail.com>
4748 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4750 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4753 * nullable.cs: Constant coalescing operator optimizations.
4755 2008-05-03 Marek Safar <marek.safar@gmail.com>
4757 * constant.cs: Use unsigned conversion for values which are unsigned only.
4759 2008-05-03 Marek Safar <marek.safar@gmail.com>
4761 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4762 coalescing operator as it should be.
4764 2008-05-02 Marek Safar <marek.safar@gmail.com>
4766 A fix for bug #371016
4767 * expression.cs: All predefined delegate operators require implicit method
4770 2008-05-02 Marek Safar <marek.safar@gmail.com>
4772 * constant.cs: Emit long constant as uint when fits the range.
4774 * convert.cs, expression.cs: Fixed few unsafe conversions.
4776 2008-05-02 Marek Safar <marek.safar@gmail.com>
4778 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4780 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4783 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4785 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4787 2008-05-01 Marek Safar <marek.safar@gmail.com>
4789 * constant.cs, literal.cs: IsLiteral property for error reporting.
4791 * ecore.cs, expression.cs: Implemented Property expression.
4793 2008-05-01 Marek Safar <marek.safar@gmail.com>
4795 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4797 * nullable.cs: Implemented nullable coalescing null operator.
4799 * ecore.cs, expression.cs: Expression trees work.
4801 2008-05-01 Marek Safar <marek.safar@gmail.com>
4803 * ecore.cs: CreateExpressionTree is finally abstract.
4805 * expression.cs, linq.cs: Updated.
4807 2008-05-01 Marek Safar <marek.safar@gmail.com>
4809 * expression.cs, ecore.cs: Block base access expression inside expression
4812 2008-05-01 Marek Safar <marek.safar@gmail.com>
4814 A fix for bug #385058
4815 * expression.cs: User-defined operator implementations always take
4816 precedence over predefined operator implementations.
4818 2008-04-30 Marek Safar <marek.safar@gmail.com>
4820 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4821 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4822 expression tree conversions.
4824 2008-04-30 Marek Safar <marek.safar@gmail.com>
4826 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4827 operators method details to Operator class.
4829 2008-04-30 Marek Safar <marek.safar@gmail.com>
4831 * anonymous.cs: Pass unsafe flags to anonymous container.
4833 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4834 inside expression tree.
4836 2008-04-29 Martin Baulig <martin@ximian.com>
4838 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4839 (Tokenizer.PopPosition): Also restore the `line'.
4841 2008-04-29 Marek Safar <marek.safar@gmail.com>
4843 * delegate.cs: Implemented Invoke expression.
4845 2008-04-29 Marek Safar <marek.safar@gmail.com>
4847 * expression.cs: Fixed equality reference comparison regression.
4849 2008-04-29 Marek Safar <marek.safar@gmail.com>
4851 * ecore.cs: Clean up EmptyCast hack.
4853 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4854 using correct conversion rules. Also fixes #383993.
4856 2008-04-28 Martin Baulig <martin@ximian.com>
4858 * class.cs (Constructor.Emit): Don't emit debugging information
4859 for generated default .ctor's.
4861 2008-04-28 Marek Safar <marek.safar@gmail.com>
4863 * convert.cs: Empty-cast ushort to int conversion.
4865 2008-04-28 Marek Safar <marek.safar@gmail.com>
4867 A fix for bug #384191
4868 * ecore.cs, expression.cs: Fixed expression cloning.
4870 2008-04-28 Marek Safar <marek.safar@gmail.com>
4872 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4874 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4876 Fix #381559, test-638.cs, test-639.cs
4877 * assign.cs (CompoundAssign.Helper): New wrapper.
4878 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4880 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4881 Pass unconverted expressions to the params array creation expression.
4882 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4883 (PropertyExpr.EmitAssign): Likewise.
4884 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4885 element if it is of kind CompoundAssign.Helper.
4886 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4887 first before anything else.
4888 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4889 (ArrayAccess.LoadArrayAndArguments): Simplify.
4891 2008-04-27 Marek Safar <marek.safar@gmail.com>
4893 * expression.cs: Fixed cloning of typeof(void).
4895 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4897 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4898 (Assign.Emit): Likewise. Move it to ...
4899 (CompoundAssign.DoResolve): ... here and ...
4900 (CompoundAssign.Emit): ... here.
4901 (EventAddOrRemove): New helper to handle += and -= on events, and
4902 avoid the use of BinaryDelegates.
4903 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4904 (EventExpr.EmitAddOrRemove): Improve.
4905 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4907 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4908 create VarExprs for 'foo.bar.var'.
4909 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4910 is a highly inappropriate name for its functionality.
4912 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4914 Simplify handling of multiple assignments
4915 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4917 (SimpleAssign): New. Class to be used for normal assignments.
4918 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4919 * expression.cs, parameter.cs, statement.cs: Likewise.
4921 2008-04-25 Marek Safar <marek.safar@gmail.com>
4923 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4924 for incompatible underlying types, more to come, uff.
4926 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4929 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4930 Handle 'leave_copy'.
4932 2008-04-25 Marek Safar <marek.safar@gmail.com>
4934 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4936 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4938 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4939 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4940 * statement.cs (While, Do, For): Allow test to have side effects.
4941 (For.DoEmit): Always emit InitStatement.
4944 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4945 Always create SideEffectConstant.
4946 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4947 of type EnumConstant.
4949 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4950 Handle 'right' being SideEffectConstant of type 'bool'.
4952 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4953 Use left.EmitBranchable instead of open coding it, so as to
4954 improve optimization opportunities.
4956 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4958 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4960 (Expression.EmitSideEffect): Document.
4962 2008-04-23 Marek Safar <marek.safar@gmail.com>
4964 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4966 2008-04-23 Marek Safar <marek.safar@gmail.com>
4968 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4970 2008-04-23 Marek Safar <marek.safar@gmail.com>
4972 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4973 conversion to expression tree.
4975 2008-04-23 Marek Safar <marek.safar@gmail.com>
4977 * ecore.cs: Removed unused expression.
4979 2008-04-22 Marek Safar <marek.safar@gmail.com>
4981 * expression.cs: Implemented NegateChecked and New expressions.
4983 2008-04-22 Marek Safar <marek.safar@gmail.com>
4985 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4987 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4990 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4991 needing final 'ret' instruction.
4993 2008-04-22 Marek Safar <marek.safar@gmail.com>
4995 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4997 2008-04-21 Marek Safar <marek.safar@gmail.com>
4999 * expression.cs: Emit ldnull and not null expression as an instance argument
5000 of static method expression calls.
5002 2008-04-21 Marek Safar <marek.safar@gmail.com>
5004 A fix for bug #378200
5005 * expression.cs: Fixed crash when creating parameterless expression tree
5008 2008-04-21 Marek Safar <marek.safar@gmail.com>
5010 A fix for bug #375297
5011 * anonymous.cs: Fixed crash when inferring from null argument anonymous
5014 2008-04-21 Marek Safar <marek.safar@gmail.com>
5016 A fix for bug #377596
5017 * decl.cs, class.cs: Emit delegate type argument attributes.
5019 2008-04-21 Marek Safar <marek.safar@gmail.com>
5021 A fix for bug #365314
5022 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
5024 2008-04-21 Marek Safar <marek.safar@gmail.com>
5026 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
5029 2008-04-21 Marek Safar <marek.safar@gmail.com>
5031 * generic.cs (TypeParameter): Removed redundant location.
5033 2008-04-19 Marek Safar <marek.safar@gmail.com>
5035 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
5036 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
5037 FullNamedExpression in all declaration type expression, statements will come
5040 2008-04-18 Marek Safar <marek.safar@gmail.com>
5042 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
5043 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
5045 2008-04-18 Marek Safar <marek.safar@gmail.com>
5047 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
5050 2008-04-17 Marek Safar <marek.safar@gmail.com>
5052 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
5055 2008-04-17 Marek Safar <marek.safar@gmail.com>
5057 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
5061 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
5063 Hook up 'EmitSideEffect'
5064 * constant.cs (Constant.EmitSideEffect): New.
5065 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
5066 (SideEffectConstant.EmitSideEffect): New.
5067 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
5068 unconditional branch in EmitBranchable.
5069 (FieldExpr.EmitBranchable): New.
5070 * expression.cs (Unary.EmitSideEffect): New.
5071 (Binary.EmitSideEffect): New.
5072 (VariableReference.EmitSideEffect): New. Do nothing.
5074 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5076 Introduce 'EmitSideEffect'
5077 * ecore.cs (Expression.EmitSideEffect): New.
5078 (TypeCast): Rename from EmptyCast.
5080 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
5081 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
5082 * convert.cs, nullable.cs: Update to changes.
5084 2008-04-16 Marek Safar <marek.safar@gmail.com>
5086 * class.cs, cs-parser.jay: Early check for base types expression.
5088 2008-04-16 Marek Safar <marek.safar@gmail.com>
5090 * decl.cs (MemberName): Declare PrettyName as obsolete.
5092 2008-04-16 Marek Safar <marek.safar@gmail.com>
5094 * namespace.cs: Use MemberName comparison.
5096 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5099 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
5101 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
5102 (MemberName.FullyQualifiedName): New. Provides the functionality
5103 that users assume FullName would have.
5104 * ecore.cs, namespace.cs: Update to changes.
5106 * statement.cs (Using.assign): Make into ExpressionStatement.
5107 (Using.EmitPreTryBody): Simplify.
5109 2008-04-16 Marek Safar <marek.safar@gmail.com>
5111 * report.cs: ColorFormat is protected.
5113 * rootcontext.cs: Unused fields clean-up.
5115 * namespace.cs: Made UsingEntry name private.
5117 2008-04-16 Marek Safar <marek.safar@gmail.com>
5119 * cs-tokenizer.cs, location.cs: Removed unused field.
5121 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
5122 Raja R Harinath <harinath@hurrynot.org>
5125 * constant.cs (SideEffectConstant.value): Rename from 'left'.
5126 (SideEffectConstant.side_effect): Rename from 'right'.
5127 (SideEffectConstant..ctor): Normalize 'side_effect'.
5128 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
5129 value of this constant.
5130 * cfold.cs: Update to changes.
5132 2008-04-15 Marek Safar <marek.safar@gmail.com>
5134 * cs-paser.jay: Removed unused variable.
5136 * driver.cs: Made Compile instance method.
5138 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
5140 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
5142 2008-04-15 Marek Safar <marek.safar@gmail.com>
5144 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
5146 2008-04-13 Jb Evain <jbevain@novell.com>
5148 * namespace.cs: update the System.Core fullname for 2.1
5149 * driver.cs: update the list of required assemblies for 2.1.
5150 Merged from the Moonlight 2 branch.
5152 2008-04-11 Marek Safar <marek.safar@gmail.com>
5154 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
5155 types and user defined operators. User operators arguments has to be checked
5156 for null value before invocation, which also means no operator is called
5157 when any argument is not convertible to unwrapped nullable type.
5159 2008-04-09 Marek Safar <marek.safar@gmail.com>
5161 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
5162 of Unary expressions to follow operator overloading rules precisely.
5163 Also fixes #321794, #323794
5165 2008-04-08 Marek Safar <marek.safar@gmail.com>
5167 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
5170 2008-04-08 Marek Safar <marek.safar@gmail.com>
5172 * expression.cs, ecore.cs: Implemented MemberInit expression.
5174 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
5176 Fix mono/tests/exception4.cs
5177 * statement.cs (ExceptionStatement, TryCatch): Revert to using
5178 ec.NeedReturnLabel () rather emitting a 'nop'.
5180 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
5182 (TryCatch.SomeCodeFollows): Likewise.
5183 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
5184 for 'break', 'continue' and 'return' statements inside a try.
5185 We're fairly sure that the generated IL stream will have more
5186 instructions textually following the try.
5187 (FlowBranchingTryCatch): Likewise.
5189 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
5190 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
5193 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
5194 wrapper -- forward everything to CollectionForeach.
5195 (CollectionForeach.NonDisposableWrapper): New.
5196 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
5197 instead of a pop + branch to end.
5199 2008-04-07 Marek Safar <marek.safar@gmail.com>
5201 A fix for bug #377485
5202 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
5203 Propagate location for extension method groups. Report conversion failure at
5206 2008-04-07 Marek Safar <marek.safar@gmail.com>
5208 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
5209 ListInit and Field expressions.
5211 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
5213 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
5214 Since $PC is always -1 inside the body of MoveNext, the fault
5216 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
5217 * statement.cs (ExceptionStatement.emit_finally): Likewise.
5218 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
5220 The denouement! Fix #324708
5221 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
5222 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
5223 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
5224 'finally' inside the finally clause.
5226 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
5227 inside an iterator. Don't emit the body of the 'finally' inside
5228 the finally clause yet.
5230 Use the ResumableStatement infrastructure for MoveNext ()
5231 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
5232 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
5233 'old_resume_points'. Move dispatcher upfront.
5234 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
5235 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
5236 in an enumerator. This encodes the main fix in this patch series
5237 -- we can only jump into the first instruction of a try from the
5238 outside, but we want to emit try/finally regions in iterators and
5239 resume in the middle of them.
5241 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
5243 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
5244 of NeedReturnLabel here.
5246 Introduce a common point for emitting try/finally to IL
5247 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
5248 features of the various subclasses, which are now driven by ...
5249 (ExceptionStatement.EmitPreTryBody): ... this and ...
5250 (ExceptionStatement.EmitTryBody): ... this and the original
5252 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
5253 Remove DoEmit and update to follow above protocol.
5255 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5256 of the dispatcher are the same, skip emitting the 'switch'.
5257 * iterator.cs (Iterator.EmitDispose): Update to changes.
5259 Clean up handling of 'using' statement
5260 * statement.cs (UsingTemporary): New. Carved out of ...
5261 (Using): ... this. Simplify drastically. Handle exactly
5263 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5264 or Using as appropriate. If there are multiple variable declared,
5265 create nested Using statements.
5266 (resource_acquisition): Kill.
5268 * statement.cs (ExceptionStatement.EmitForDispose): Use
5269 EmitFinallyBody, not EmitFinally.
5271 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5272 * iterator.cs: Update to changes.
5274 Start using the ResumableStatement infrastructure
5275 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5276 (ResumableStatement.EmitForDispose): New.
5277 (ExceptionStatement): Override them.
5278 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5279 EmitForDispose to create the body of the Dispose method. Don't
5282 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5283 * statement.cs (Toplevel.AddResumePoint): ... here.
5284 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5285 * flowanalysis.cs (FlowBranchingIterator): New.
5286 * codegen.cs (EmitContext): Update to changes.
5288 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5289 (Iterator.old_resume_points): Rename from 'resume_points'.
5290 (Iterator.MoveNextStatement): Remove unused class.
5292 New infrastructure for try/finally in iterators (still unused)
5293 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5294 (FlowBranchingToplevel.AddResumePoint): Hook into
5295 ToplevelBlock.AddResumePoint.
5296 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5297 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5298 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5299 resume points and assign program-counter values.
5300 (ExceptionBlock.AddResumePoint): Collect resume points for
5301 de-muxer at the top of try block.
5302 * iterators.cs (Yield.CheckContext): Simplify.
5303 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5305 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5307 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5308 argument to an ExitStatement.
5309 (FlowBranchingException): Refactor saved origins code.
5310 * statement.cs (ExitStatement): Update to cahges.
5311 * iterator.cs (YieldBreak): Likewise.
5313 * statement.cs (ResumableStatement): New. Common base class for
5314 YieldReturn and ExceptionStatement.
5315 (ExitStatement): New. Common base class for Return and YieldBreak.
5316 (Return): Update to changes.
5317 * iterator.cs (YieldBreak): Likewise.
5318 * lambda.cs (ContextualReturn): Likewise.
5321 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5322 emit a meaningful error message.
5324 Fix #324765, #319508
5325 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5326 (VariableInfo.SetAssigned): Set it.
5327 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5328 determine if CS0219 or CS0168 is appropriate. Don't use
5329 flow-analysis information.
5330 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5331 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5332 (EmitContext.EndFlowBranching): ... this.
5334 2008-04-03 Marek Safar <marek.safar@gmail.com>
5336 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5338 2008-04-03 Marek Safar <marek.safar@gmail.com>
5340 A fix for bug #376508
5341 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5342 ImplicitConversionExists.
5344 2008-04-03 Marek Safar <marek.safar@gmail.com>
5346 * expression.cs (Binary): Added remaining binary operators to expression
5349 * nullable.cs: Optimize shift with null argument.
5351 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5353 Fix minor IL regression
5354 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5355 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5356 * cs-parser.jay (try_statement): Update to changes.
5358 * statement.cs (TryFinally.need_exc_block): Delete.
5359 (TryFinally): Update to changes.
5361 Now all ExceptionStatements are unconditional
5362 * statement.cs (CollectionForeach.DisposableWrapper): New.
5363 Extract out the try/finally code into a new wrapper.
5364 (CollectionForeach.Resolve): Use it to simplify the code.
5366 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5368 Start at simplifying ExceptionStatement semantics a bit
5369 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5370 * cs-parser.jay (try_statement): Update to changes.
5371 (opt_catch_clauses): Remove.
5372 * flowanalysis.cs: Update to changes.
5373 (FlowBranching.BranchingType.TryCatch): New.
5374 (FlowBranchingTryCatch): New.
5376 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5377 (FlowBranching.CreateBranching): Update to changes.
5378 (FlowBranchingBlock.AddSibling): Add sanity check.
5379 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5382 * iterators.cs (Iterator.MarkFinally): Remove.
5383 * statement.cs (ExceptionStatement): Update to changes.
5385 Add support for skipping over finally blocks at runtime. First
5386 in a series to fix #324708
5387 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5388 (Iterator.EmitMoveNext): Initialize it.
5389 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5390 branch over the body of the 'finally' clause.
5392 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5394 Avoid lopsided use of Foo/DoFoo names
5395 * statement.cs (ExpressionStatement.EmitFinallyBody):
5396 Rename from EmitFinally.
5397 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5398 * iterator.cs: Update to changes.
5400 2008-04-02 Marek Safar <marek.safar@gmail.com>
5402 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5403 based on UserOperatorCall. More binary nullable operators clean up.
5405 2008-04-02 Martin Baulig <martin@ximian.com>
5407 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5409 2008-04-02 Marek Safar <marek.safar@gmail.com>
5411 * nullable.cs: Merge user and empty conversions when lifting expression
5414 * expression.cs (StringConcat): Implemented expression tree representation.
5416 2008-04-01 Marek Safar <marek.safar@gmail.com>
5418 * nullable.cs: When lifting null literal and a user operator exists, no call
5421 2008-04-01 Marek Safar <marek.safar@gmail.com>
5423 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5426 2008-04-01 Marek Safar <marek.safar@gmail.com>
5428 * nullable.cs, expression.cs: Use namespace instead heavily nested
5429 monster abstract class.
5431 2008-04-01 Marek Safar <marek.safar@gmail.com>
5433 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5434 lifting of null literal and user operators. Clean up of some temporary
5437 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5439 Fix #368224, test-629.cs
5440 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5441 if it crossed an unwind-protect boundary.
5442 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5443 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5444 inside an unwind-protected region.
5445 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5446 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5447 'leave' instead of a 'br' if unwind-protected.
5448 (Iterator.EmitYieldBreak): Likewise.
5450 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5452 * driver.cs: Only define versioninfo resources if no win32 resource
5455 2008-03-28 Marek Safar <marek.safar@gmail.com>
5457 A fix for bug #372375
5458 * convert.cs: Fixed boxing of nullable types.
5460 2008-03-28 Marek Safar <marek.safar@gmail.com>
5462 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5465 2008-03-28 Marek Safar <marek.safar@gmail.com>
5467 A fix for bug #374619
5468 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5470 2008-03-27 Marek Safar <marek.safar@gmail.com>
5472 * lambda.cs: Check return type only for invocation.
5474 2008-03-27 Marek Safar <marek.safar@gmail.com>
5476 A fix for bug #374214
5477 * ecore.cs: Correctly report argument type mismatch.
5479 2008-03-27 Marek Safar <marek.safar@gmail.com>
5481 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5482 and not rely on broken IsEnum.
5484 2008-03-27 Marek Safar <marek.safar@gmail.com>
5486 * nullable.cs: New file, extracted from generic.cs.
5488 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5490 2008-03-27 Marek Safar <marek.safar@gmail.com>
5492 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5493 predefined comparison operators and null literals.
5495 * report.cs: New warning ID.
5497 2008-03-25 Marek Safar <marek.safar@gmail.com>
5499 A fix for bug #370577
5500 * lambda.cs: Check return type too.
5502 2008-03-25 Marek Safar <marek.safar@gmail.com>
5504 A fix for bug #372846
5505 * class.cs: Automatic properties can be declared as unsafe.
5507 2008-03-20 Marek Safar <marek.safar@gmail.com>
5509 * location.cs: Use string based concatenation.
5511 * expression.cs: LiftedBinaryOperator is gmcs only.
5513 2008-03-20 Marek Safar <marek.safar@gmail.com>
5515 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5516 conversions rules and expression trees.
5518 2008-03-19 Marek Safar <marek.safar@gmail.com>
5520 * delegate.cs: Use extension method source as delegate target.
5522 2008-03-19 Marek Safar <marek.safar@gmail.com>
5524 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5525 binary operations to be purely based on binary operations and optimized
5526 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5527 and other ET refactoring.
5529 * typemanager.cs: Fixed warning.
5531 2008-03-17 Marek Safar <marek.safar@gmail.com>
5533 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5535 * symbolwriter.cs: Fixed.
5537 2008-03-17 Marek Safar <marek.safar@gmail.com>
5539 * anonymous.cs, driver.cs: Reset anonymous types counters.
5541 2008-03-17 Marek Safar <marek.safar@gmail.com>
5543 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5545 * class.cs: Use fullname for all type member definitions.
5547 2008-02-19 Martin Baulig <martin@ximian.com>
5550 (IMethodData.EmitExtraSymbolInfo): New interface method.
5551 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5552 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5553 interface method here as an empty public virtual method.
5556 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5557 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5558 CodeGen.SymbolWriter.SetRealMethodName().
5560 2008-02-18 Martin Baulig <martin@ximian.com>
5563 (ScopeInfo.EmitType): Override this and emit debugging
5564 information for captured variables.
5565 (RootScopeInfo.EmitType): Override this and emit symbol
5566 information for a captured `this'.
5568 2008-02-15 Martin Baulig <martin@ximian.com>
5570 * iterators.cs: Emit debugging info.
5573 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5574 (EmitContext.OmitDebuggingInfo): New public property.
5577 (While): Override Emit() and don't emit symbol info there; do it
5578 inside DoEmit() instead.
5579 (Block.Emit): Omit symbol information while emitting the scope
5580 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5582 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5583 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5584 .ctor to make `IsIterator' work.
5586 2008-03-14 Martin Baulig <martin@ximian.com>
5588 * symbolwriter.cs: Added the new symbol writer function from the
5589 debugger's `terrania' branch; temporarily enclose them inside
5590 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5593 2008-03-14 Martin Baulig <martin@ximian.com>
5596 (SymbolWriter): Make this a public static class.
5599 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5600 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5602 2008-03-14 Marek Safar <marek.safar@gmail.com>
5604 A fix for bug #370577
5605 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5608 2008-03-14 Marek Safar <marek.safar@gmail.com>
5610 * typemanager.cs (CSharpName): Made 250 times faster.
5612 2008-03-13 Marek Safar <marek.safar@gmail.com>
5614 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5616 2008-03-12 Marek Safar <marek.safar@gmail.com>
5618 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5619 crash when predefined field does not exist.
5621 2008-03-12 Marek Safar <marek.safar@gmail.com>
5623 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5625 2008-03-12 Marek Safar <marek.safar@gmail.com>
5627 * class.cs (FixedField): Don't crash when contructors are missing.
5629 2008-03-11 Marek Safar <marek.safar@gmail.com>
5631 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5632 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5633 check internal types accessibility for internal and external types.
5634 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5636 2008-03-11 Marek Safar <marek.safar@gmail.com>
5638 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5639 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5640 attribute.cs, statement: Use corect instance of predefined types (work
5641 related to #364674).
5643 2008-03-07 Marek Safar <marek.safar@gmail.com>
5645 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5647 2008-03-07 Marek Safar <marek.safar@gmail.com>
5649 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5650 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5651 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5652 predefined types clean up, delayed predefined types members initialization
5653 (work related to #364674).
5655 2008-03-05 Marek Safar <marek.safar@gmail.com>
5657 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5659 2008-03-05 Marek Safar <marek.safar@gmail.com>
5661 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5662 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5663 predefined types clean up (work related to #364674).
5665 2008-03-04 Marek Safar <marek.safar@gmail.com>
5667 * ecore.cs: Print an error message instead of throwing exception.
5669 2008-03-04 Marek Safar <marek.safar@gmail.com>
5671 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5672 expression.cs, statement.cs: Unififed null literal representation.
5674 2008-03-03 Marek Safar <marek.safar@gmail.com>
5676 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5677 expression.cs: Refactored binary operators resolve phase and improved speed.
5678 The nullable code is still missing and won't work correctly, more fixes
5681 It also fixes #323726, #324312, #324248, and many other unreported issues.
5683 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5685 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5688 2008-02-27 Marek Safar <marek.safar@gmail.com>
5690 * ecore.cs: Clean-up and split BetterConversion.
5692 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5695 * enum.cs (EnumMember.Value): Only access 'value' if
5696 ResolveValue says it's ok.
5697 (EnumMember.DoResolveValue): Don't set prev_member.value.
5698 (Enum.GetDefinition): Reverse arguments of Equals --
5699 EnumMember.Value can return 'null'.
5701 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5703 2008-02-22 Marek Safar <marek.safar@gmail.com>
5705 * generic.cs, expression.cs: More ongoing work on expression trees.
5707 2008-02-21 Marek Safar <marek.safar@gmail.com>
5709 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5710 handle missing matches when mutiple operators exist.
5712 2008-02-20 Marek Safar <marek.safar@gmail.com>
5714 A fix for bug #363218
5715 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5718 2008-02-20 Marek Safar <marek.safar@gmail.com>
5720 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5721 update. This time to deal correctly with SideEffectConstant expression used
5722 as an argument for another constant folding.
5724 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5726 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5729 2008-02-19 Marek Safar <marek.safar@gmail.com>
5731 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5733 2008-02-19 Marek Safar <marek.safar@gmail.com>
5735 A fix for bug #328136
5736 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5737 side is a false constant, because we still need to evaluate the right-hand
5740 * statement.cs (If): Emit two types of boolean constants (simple constant,
5741 side-effect constant).
5743 2008-02-19 Marek Safar <marek.safar@gmail.com>
5745 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5747 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5750 2008-02-18 Marek Safar <marek.safar@gmail.com>
5752 A fix for bug #361457
5753 * ecore.cs (IsApplicable): Params methods have lower priority.
5755 * support.cs: Return correct parameter modifier for params types.
5757 2008-02-18 Marek Safar <marek.safar@gmail.com>
5759 * generic.cs (TypeParameter): Cache attribute target name.
5761 * support.cs: Removed unused variable.
5763 * typemanager.cs: Removed debugging leftover.
5765 * ecore.cs: Use local type instead of a property;
5767 * class.cs (VerifyMembers): Consider also parent to test whether type member
5770 * expression.cs (FullMethodDesc): Removed.
5772 * attribute.cs (IsValidArgumentType): Made static.
5774 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5776 Cleanup to be more readable.
5777 * Makefile (GMCS_PROFILE): Remove.
5778 (COMPILER_NAME): New helper.
5780 2008-02-15 Miguel de Icaza <miguel@novell.com>
5782 * cs-tokenizer.cs: if a conditional expression happens inside a
5783 (...) this also means that we do not need to de-ambiguate between
5784 an parenthesized expression and a cast.
5788 * constant.cs (SideEffectConstant): a constant value that happens
5789 to have a side effect.
5791 Fixes the build regressions introduced by the fix for #359789
5793 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5795 * expression.cs (Conditional.Emit): when emitting the ternary
5796 operator, use local variables to generate code verifiable code.
5798 The verifier cannot infer that the type on stack before the
5799 stloc.0 is executed is of type ParentB. This happens because the
5800 stack merge algorithm uses only parent types when deciding which
5801 is the common type. This is described in Part III 1.8.1.3 of ECMA
5804 This code compiled with mcs is not verifiable under MS. The MS
5805 verifier picks the first common interface of Foo and Bar, which is
5806 wrong, but doesn't use a full join type of the 2 interfaces.
5808 CSC uses a clever hack to compile such code in a verifiable
5809 way. It stores the intermediate values in a local variable with
5814 2008-02-14 Miguel de Icaza <miguel@novell.com>
5816 * expression.cs: Do not fold BitwiseAnd operators when the left
5817 side is a false constant, because we still need to evaluate the
5822 * support.cs: Instead of throwing an InternalErrorException when
5823 the position of the stream is outside the boundary of our buffer,
5824 reset the state of the reader, and restart the reading from the
5825 beginning of the file.
5827 2008-02-14 Marek Safar <marek.safar@gmail.com>
5829 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5831 2008-02-14 Marek Safar <marek.safar@gmail.com>
5833 A fix for bug #361686
5834 * decl.cs: A protected types used inside a private class which parents
5835 derives from the protected class are accessible.
5837 2008-02-13 Marek Safar <marek.safar@gmail.com>
5839 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5840 the parameterless constructor.
5842 2008-02-13 Marek Safar <marek.safar@gmail.com>
5844 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5845 lookup methods to use standard member cache when doing member lookup.
5847 2008-02-12 Marek Safar <marek.safar@gmail.com>
5849 * driver.cs: Don't report full path for referenced module as assembly error.
5851 2008-02-12 Marek Safar <marek.safar@gmail.com>
5853 * Makefile: Fixed `qh' target to work on all machines.
5855 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5856 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5857 and HasElementType with TypeManager implementation.
5859 2008-02-08 Marek Safar <marek.safar@gmail.com>
5861 A fix for bugs #325134, #359749
5862 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5863 first binds point to non-method member expression.
5865 2008-02-08 Marek Safar <marek.safar@gmail.com>
5867 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5869 2008-02-08 Marek Safar <marek.safar@gmail.com>
5871 A fix for bugs #321394, #323028
5872 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5873 Reworked naive IsAccessibleAs implementation to handle nested types.
5875 2008-02-05 Jb Evain <jbevain@novell.com>
5877 * class.cs: use generic type comparison for parameters
5880 2008-02-05 Marek Safar <marek.safar@gmail.com>
5882 A fix for bug #325372
5883 * class.cs: Use generic type comparison when testing method signatures.
5885 2008-02-05 Marek Safar <marek.safar@gmail.com>
5887 A fix for bug #357047
5888 * ecore.cs: Applied C# 3.0 changes to better conversion.
5890 2008-02-05 Marek Safar <marek.safar@gmail.com>
5892 A fix for bug #358374
5893 * cs-parser.jay: Correctly set modifiers for all constructor types.
5895 2008-02-04 Marek Safar <marek.safar@gmail.com>
5897 A fix for bug #355251
5898 * generic.cs: Added base class constraint based type inference.
5900 2008-02-01 Marek Safar <marek.safar@gmail.com>
5902 A fix for bug #357255
5903 * decl.cs: One more missing visibility check.
5905 2008-02-01 Marek Safar <marek.safar@gmail.com>
5907 * support.cs: Fixed broken return.
5909 2008-01-25 Marek Safar <marek.safar@gmail.com>
5911 * report.cs: Correctly reset warnings count after probing.
5913 2008-01-25 Martin Baulig <martin@ximian.com>
5916 (NamespaceEntry.SymbolFileID): Make this work again after
5917 MemberName.ToString() is gone.
5919 2008-01-25 Marek Safar <marek.safar@gmail.com>
5921 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5924 2008-01-25 Marek Safar <marek.safar@gmail.com>
5926 * generic.cs: Use full implicit conversion for type inference fixing.
5928 2008-01-24 Marek Safar <marek.safar@gmail.com>
5930 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5931 Fixed user operator conversions.
5933 2008-01-24 Marek Safar <marek.safar@gmail.com>
5935 * generic.cs: Do nullable type to null comparison optimization during
5938 2008-01-24 Marek Safar <marek.safar@gmail.com>
5940 A fix for bug #355163
5941 * generic.cs: Enabled l-value resolve on nullable expressions.
5943 2008-01-24 Marek Safar <marek.safar@gmail.com>
5945 A fix for bug #353986
5946 * class.cs: Ingore static ctors with parameters for any further checks.
5948 2008-01-24 Marek Safar <marek.safar@gmail.com>
5950 A fix for bug #354310
5951 * namespace.cs: Removed redundant check.
5953 2008-01-24 Marek Safar <marek.safar@gmail.com>
5955 A fix for bug #354928
5956 * expression.cs: ElementInitializers can be resolved only once.
5958 2008-01-24 Marek Safar <marek.safar@gmail.com>
5960 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5961 Condition expressions.
5963 2008-01-23 Marek Safar <marek.safar@gmail.com>
5965 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5967 2008-01-22 Marek Safar <marek.safar@gmail.com>
5969 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5972 * generic.cs: Implemented coalesce expression.
5974 2008-01-22 Marek Safar <marek.safar@gmail.com>
5976 A fix for bug #355145
5977 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5978 expression tree type inference.
5980 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5983 * expression.cs (Binary.IsUnsignedType): Fix typo.
5985 2008-01-22 Marek Safar <marek.safar@gmail.com>
5987 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5989 2008-01-22 Marek Safar <marek.safar@gmail.com>
5991 A fix for bug #355161
5992 * ecore.cs, expression.cs: Wider range of extension method supported
5995 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5997 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5998 AssemblyBuilder to operate in compiler context. Fixes mcs part of
6001 2008-01-22 Marek Safar <marek.safar@gmail.com>
6003 A fix for bug #355148
6004 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
6006 2008-01-22 Miguel de Icaza <miguel@novell.com>
6008 * expression.cs (CreateExpressionTree): Add support for or and
6009 logical or, and indent following the coding conventions.
6011 * typemanager.cs (LinqExpression): renamed from
6012 ExpressionTreeManager, for a shorter name.
6014 Use TypeManager.CoreLookupType to lookup types from our core
6015 assemblies and turn those into "Type" variables.
6017 Consumers that previously used "Namespace" and "Type" from this
6018 class should instead use the TypeExpression which is a type that
6019 is fully resolved (without involving the regular C# resolution
6022 This typically looks like this:
6024 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
6025 new MemberAccess (texpr, name, type_arguments, loc)
6027 This avoids the problem in: #355178
6029 2008-01-21 Marek Safar <marek.safar@gmail.com>
6031 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
6032 feature in parser only as we do in other cases.
6034 2008-01-21 Marek Safar <marek.safar@gmail.com>
6036 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
6037 typemanager.cs: A refactoring of params arguments to reuse existing
6038 expressions (params -> array initializer) to emit params argument instead
6039 of specialized handling.
6040 It was required by expression tree implementation and it has other benefits
6041 as well, we now apply same optimization for params arguments as we do for
6044 2008-01-18 Marek Safar <marek.safar@gmail.com>
6046 A fix for bug #353526
6047 * generic.cs: A type inference of params arguments may not required any
6048 temporary array creation.
6050 2008-01-18 Marek Safar <marek.safar@gmail.com>
6052 A fix for bug #353534
6053 * generic.cs, ecore.cs, expression.cs: A method group type inference is
6054 supported for delegates only.
6056 2008-01-18 Marek Safar <marek.safar@gmail.com>
6058 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
6059 type for more than 1 candidates.
6061 2008-01-18 Marek Safar <marek.safar@gmail.com>
6063 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
6066 2008-01-16 Marek Safar <marek.safar@gmail.com>
6068 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
6069 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
6070 operator) expressions.
6072 2008-01-16 Zoltan Varga <vargaz@gmail.com>
6074 * statement.cs: Avoid declaring an IL variable for this_variable since it is
6075 not accessed from the generated IL.
6077 2008-01-14 Marek Safar <marek.safar@gmail.com>
6079 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
6080 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
6081 statement.cs: The first expression tree implementation drop, mostly
6082 infrastructure work.
6084 2008-01-14 Marek Safar <marek.safar@gmail.com>
6086 * ecore.cs (IsNestedChild): Refactored.
6088 2008-01-11 Marek Safar <marek.safar@gmail.com>
6090 * lambda.cs: Don't use a cast on unknown expression statement.
6092 2008-01-10 Geoff Norton <gnorton@novell.com>
6094 * cs-tokenizer.cs: One more token to distinguish between method and lambda
6097 2008-01-09 Marek Safar <marek.safar@gmail.com>
6099 * doc.cs: Report better /doc crash details.
6101 2008-01-09 Marek Safar <marek.safar@gmail.com>
6103 A fix for bug #352536
6104 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
6106 2008-01-08 Marek Safar <marek.safar@gmail.com>
6108 A fix for bug #352287
6109 * ecore.cs, expression.cs: Do `this' access checking in all member access
6112 2008-01-08 Marek Safar <marek.safar@gmail.com>
6114 * rootcontext.cs, driver.cs: Switch to linq mode by default.
6116 * report.cs: Reset message stacks.
6118 2008-01-08 Marek Safar <marek.safar@gmail.com>
6120 * generic.cs (InferInPhases): Correctly calculate params position.
6122 2008-01-08 Marek Safar <marek.safar@gmail.com>
6124 * cs-tokenizer.cs: No need to parse full string when parsing lambda
6127 2008-01-07 Marek Safar <marek.safar@gmail.com>
6129 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
6131 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
6133 * driver.cs: Updated --help option.
6135 2008-01-07 Marek Safar <marek.safar@gmail.com>
6137 * generic.cs (InferParamsTypeArguments): Removed.
6138 (InferInPhases): Add params type inference.
6139 (LowerBoundInference): Fixed scoring mechanism.
6141 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
6143 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
6145 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
6146 byte array for unsigned "baked" assemblies.
6148 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
6150 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
6151 array for assemblies that are not strongnamed.
6153 2008-01-04 Marek Safar <marek.safar@gmail.com>
6155 A fix for bug #351481
6156 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
6157 declaring type for nested generic types.
6159 2008-01-04 Marek Safar <marek.safar@gmail.com>
6161 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
6162 instead of ToString.
6164 2008-01-03 Marek Safar <marek.safar@gmail.com>
6166 A fix for bug #351047
6167 * expression.cs (Binary.ResolveOperator): Allow equality operators between
6168 null and structs only when equality and inequality operators are defined
6169 either as an user-operators or predefined operators.
6171 2008-01-03 Marek Safar <marek.safar@gmail.com>
6173 A fix for bug #351047
6174 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
6176 2008-01-03 Marek Safar <marek.safar@gmail.com>
6178 A fix for bug #351257
6179 * cs-tokenizer.cs: Advance line number for '\r' correctly.
6181 2008-01-03 Marek Safar <marek.safar@gmail.com>
6183 A fix for bug #351157
6184 * class.cs (Using): Fixed yet another broken cloning.
6186 (Block): Put back more sensible default value for statements.
6188 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
6190 * codegen.cs: Allow AssemblyVersion with only major version component.
6193 2007-12-29 Marek Safar <marek.safar@gmail.com>
6195 A fix for bug #324654
6196 * class.cs: Use FullName property as member name.
6198 2007-12-28 Marek Safar <marek.safar@gmail.com>
6200 A fix for bug #342117
6201 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
6202 constructor constraint.
6204 2007-12-28 Marek Safar <marek.safar@gmail.com>
6206 A fix for bug #338273
6207 * class.cs (ProbertyBase): Access modifier checks are required for overrides
6210 2007-12-28 Marek Safar <marek.safar@gmail.com>
6212 A fix for bug #350839
6213 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
6215 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6217 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6220 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6222 * statement.cs: Changed some Hashtables to use HybridDictionaries
6223 instead. It was observed that some HashTables only contained a few
6224 items in the vast majority of cases. Since HybridDictionary is
6225 more efficient on small sets (<10 elements), "known_variables"
6226 from class ExplicitBlock as well as "labels" and "constants " from
6227 class Block were changed to HybridDictionaries.
6229 Atsai results: (56216kb->54987kb)
6231 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
6234 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6236 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6239 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6241 * expression.cs: foreach loop to for loop, saved on allocation of
6242 enumerator (59333kb->59141kb)
6244 * statement.cs. Changed foreach loops to for loops, saved on
6245 allocation of enumerator (59141kb->59006kb)
6247 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
6248 when constructed with no specified capacity. This was causing a
6249 few ArrayLists to allocate more memory than they would potentially
6250 need in the Block class and MemberCache class. Setting the
6251 ArrayLists to construct with a capacity of 1 saves some
6252 memory. (56216kb->55585kb)
6254 2007-12-27 Marek Safar <marek.safar@gmail.com>
6256 A fix for bug #347189 (2nd issue)
6257 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6260 2007-12-27 Miguel de Icaza <miguel@novell.com>
6262 * report.cs: Do not use colors if stdout and stderr are not a
6265 2007-12-27 Marek Safar <marek.safar@gmail.com>
6267 A fix for bug #346998
6268 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6271 2007-12-27 Marek Safar <marek.safar@gmail.com>
6273 A fix for bug #343465
6274 * class.cs: Explicit method name for nested types uses dots only.
6276 2007-12-27 Marek Safar <marek.safar@gmail.com>
6278 A fix for bug #343707
6279 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6281 2007-12-27 Marek Safar <marek.safar@gmail.com>
6283 * ecore.cs: Report type inference errors only when arguments count matches
6286 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6288 * expression.cs, report.cs: New warning.
6290 * typemanager.cs: Catch anonymous method type too.
6292 2007-12-23 Marek Safar <marek.safar@gmail.com>
6294 A fix for bug #346379
6295 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6297 2007-12-23 Marek Safar <marek.safar@gmail.com>
6299 A fix for bug #347359
6300 * expression.cs (Invocation): Don't resolve already resolved expression.
6302 2007-12-23 Marek Safar <marek.safar@gmail.com>
6304 A fix for bug #347189
6305 * class.cs (FixedField): Use non-dependent code only in the define phase.
6307 2007-12-23 Marek Safar <marek.safar@gmail.com>
6309 A fix for bug #348076
6310 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6312 2007-12-22 Marek Safar <marek.safar@gmail.com>
6314 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6315 discovered extension methods.
6317 2007-12-22 Marek Safar <marek.safar@gmail.com>
6319 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6322 2007-12-21 Miguel de Icaza <miguel@novell.com>
6324 * report.cs (ErrorMessage): Add support for using colors on
6325 terminals that support it.
6327 2007-12-21 Marek Safar <marek.safar@gmail.com>
6329 * ecore.cs: Use information about expanded params for error reporting.
6331 2007-12-21 Marek Safar <marek.safar@gmail.com>
6333 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6334 and logic for params overloads.
6336 2007-12-15 Miguel de Icaza <miguel@novell.com>
6338 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6339 as this is also created from the parser. Fixes #349034
6341 2007-12-12 Miguel de Icaza <miguel@novell.com>
6343 * statement.cs (Throw.CloneTo): it is valid to have empty
6344 expressions for throw.
6346 2007-12-03 Marek Safar <marek.safar@gmail.com>
6348 * cs-parser.jay: Set delegate constraint parsing region correctly.
6350 2007-12-03 Marek Safar <marek.safar@gmail.com>
6352 A fix for bug #345467
6353 * typemanager.cs (IsEqual): Compare generic parameters position only.
6355 2007-11-28 Marek Safar <marek.safar@gmail.com>
6357 * expression.cs (BaseAccess): Type arguments can be null.
6359 2007-11-27 Raja R Harinath <harinath@gmail.com>
6361 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6362 consistent even when an error has occured.
6363 (Switch.Resolve): Likewise.
6365 2007-11-22 Marek Safar <marek.safar@gmail.com>
6367 A fix for bug #334505
6368 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6371 2007-11-22 Marek Safar <marek.safar@gmail.com>
6373 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6374 refactorings required to resolve extension methods correctly when mixing
6375 generics and non-generics members.
6377 2007-11-20 Marek Safar <marek.safar@gmail.com>
6379 A fix for bug #342584
6380 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6383 2007-11-19 Marek Safar <marek.safar@gmail.com>
6385 A fix for bug #342512
6386 * delegate.cs: Use delegate argument expression when is available. Don't
6387 emit virtual call when class is sealed.
6389 2007-11-16 Marek Safar <marek.safar@gmail.com>
6391 A fix for bug #325423
6392 * assign.cs (FieldInitializer): Use resolved expression for emit.
6394 * class.cs: Print less confusing error message.
6396 2007-11-16 Marek Safar <marek.safar@gmail.com>
6398 * cs-tokenizer.cs: Removed GMCS ifdefs.
6400 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6403 * cs-parser.jay: Disabled nullable check.
6405 * generic-mcs: Copied more generic stuff.
6407 2007-11-16 Marek Safar <marek.safar@gmail.com>
6409 * gcs-parser.jay: Merged to cs-parser.jay.
6411 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6412 * *.csproj, *.sources: Updated to use only jay parser file.
6414 2007-11-16 Marek Safar <marek.safar@gmail.com>
6416 * gcs-parser.jay: Added nullable and default expression feature checks.
6418 2007-11-16 Marek Safar <marek.safar@gmail.com>
6420 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6421 it fixes many TODOs and hidden bugs.
6423 * expression: Removed duplicate error check.
6425 2007-11-15 Marek Safar <marek.safar@gmail.com>
6427 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6428 implicitly type local variable only when it is used in a declaration.
6430 2007-11-15 Marek Safar <marek.safar@gmail.com>
6432 * attribute.cs: Use CS0612 for empty strings.
6434 2007-11-14 Marek Safar <marek.safar@gmail.com>
6436 * lambda.cs, statement.cs: Contextual return may act as a statement.
6438 2007-11-14 Marek Safar <marek.safar@gmail.com>
6440 A fix for a regression cause by #324222
6441 * class.cs: Don't report unused even when it implements an interface.
6443 2007-11-13 Marek Safar <marek.safar@gmail.com>
6445 A fix for bug #341205
6446 * ecore.cs, expression.cs: Method group expression cannot do static
6447 method access with an instance reference check before overloading takes
6450 2007-11-13 Marek Safar <marek.safar@gmail.com>
6452 A fix for bug #325359
6453 * class.cs: Use predictable name for automatically generated property.
6455 2007-11-12 Marek Safar <marek.safar@gmail.com>
6457 A fix for bug #324996
6458 * expression.cs (Is): Handle case where D is nullable and T is not
6461 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6463 2007-11-12 Marek Safar <marek.safar@gmail.com>
6465 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6466 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6467 Flush small error reporting changes.
6469 2007-11-09 Marek Safar <marek.safar@gmail.com>
6471 A fix for bug #324996
6472 * expression.cs: Rewrote Is expression implementation to work with
6473 generics, nullable types, anonymous method. A const result expression
6474 uses existing infrastructure instead of custom not fully-featured one.
6476 2007-11-08 Marek Safar <marek.safar@gmail.com>
6478 A fix for bug #340202
6479 * class.cs: Consider generics for volatile field.
6481 2007-11-08 Marek Safar <marek.safar@gmail.com>
6483 A fix for bug #335594
6484 * expression.cs: Use conversion rules when handling string addition.
6486 2007-11-07 Marek Safar <marek.safar@gmail.com>
6488 A fix for bug #336651
6489 * expression.cs: Fixed a crash when probing is on.
6491 2007-11-07 Marek Safar <marek.safar@gmail.com>
6493 A fix for bug #324242
6494 * covert.cs: Added a conversion from any nullable-type with an
6495 underlying enum-type to the type System.Enum.
6497 2007-11-07 Marek Safar <marek.safar@gmail.com>
6499 A fix for bug #324222
6500 * class.cs: Report all non-used event fields.
6502 2007-11-07 Marek Safar <marek.safar@gmail.com>
6504 A fix for bug #325161
6505 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6506 qualifier for generic types.
6508 2007-11-07 Marek Safar <marek.safar@gmail.com>
6510 A fix for bug #322971
6511 * expression.cs, ecore.cs: Added intermediate result value check for
6514 2007-11-07 Marek Safar <marek.safar@gmail.com>
6516 A fix for bug #324754
6517 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6518 when it was requested.
6520 2007-11-07 Marek Safar <marek.safar@gmail.com>
6522 A fix for bug #325101
6523 * expression.cs: Do type not value comparison for `is' expression.
6525 2007-11-07 Marek Safar <marek.safar@gmail.com>
6527 A fix for bug #320236
6528 * convert.cs: Don't apply user conversion on underlying target type.
6530 2007-11-06 Marek Safar <marek.safar@gmail.com>
6532 * expression.cs: Don't use unresolved expression for error reporting.
6534 2007-11-06 Marek Safar <marek.safar@gmail.com>
6536 A fix for bugs #337712, #324490
6537 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6538 overloading resolution too.
6540 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6541 the process consistent and more robust.
6543 * expression.cs, linq.cs, report.cs: Update.
6545 2007-11-02 Marek Safar <marek.safar@gmail.com>
6547 A fix for bug #332909
6548 * attribute.cs: Resolve attributes in correct context using error
6551 * rootcontext.cs: Define Obsolete attribute members as core members.
6553 2007-11-02 Marek Safar <marek.safar@gmail.com>
6555 * statement.cs: Removed unused methods.
6557 2007-10-31 Wade Berrier <wberrier@novell.com>
6559 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6560 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6563 2007-10-31 Marek Safar <marek.safar@gmail.com>
6565 A fix for bug #338102
6566 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6567 methods registered as non-generics.
6569 2007-10-31 Marek Safar <marek.safar@gmail.com>
6571 A fix for bugs #337712, #324490
6572 * delegate.cs: Delegate covariance and contravariance is not allowed for
6575 2007-10-31 Marek Safar <marek.safar@gmail.com>
6577 A fix for bug #337719
6578 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6581 2007-10-30 Marek Safar <marek.safar@gmail.com>
6583 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6585 2007-10-29 Marek Safar <marek.safar@gmail.com>
6587 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6590 2007-10-29 Raja R Harinath <rharinath@novell.com>
6592 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6594 2007-10-29 Marek Safar <marek.safar@gmail.com>
6596 A fix for bug #334652
6597 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6598 extension methods when we have not found the best candidate in normal
6601 2007-10-27 Marek Safar <marek.safar@gmail.com>
6603 * AssemblyInfo.cs: Keep up-to-date.
6605 2007-10-27 Marek Safar <marek.safar@gmail.com>
6607 * Makefile: Fixed generics compiler name.
6609 2007-10-27 Marek Safar <marek.safar@gmail.com>
6611 * lambda.test: removed, lambda parsing is done differently.
6613 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6615 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6617 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6619 2007-10-27 Marek Safar <marek.safar@gmail.com>
6621 * Makefile, *.sources : All C# compilers are in mcs folder.
6623 * *.cs: Use existing 2_1 define for smcs.
6625 2007-10-26 Marek Safar <marek.safar@gmail.com>
6627 A fix for bug #335847
6628 * assign.cs, expression.cs: Couple of changes to avoid creating a
6629 temporary variable for each object initializer assignment statement. It
6630 simplifies struct initialization too, otherwise two temporary variables
6632 Implemented optimization of redundant default element initializers.
6634 2007-10-25 Marek Safar <marek.safar@gmail.com>
6636 A fix for bug #336766
6637 * expression.cs (Class.CheckBase): Use generic name when method is
6640 2007-10-25 Marek Safar <marek.safar@gmail.com>
6642 A fix for bug #334737
6643 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6644 variable and not variable argument for prepared copies.
6646 2007-10-24 Marek Safar <marek.safar@gmail.com>
6648 A fix for bug #325110
6649 * class.cs, expression.cs, attribute.cs: Use open generic method when
6650 checking conditional attribute.
6652 2007-10-24 Marek Safar <marek.safar@gmail.com>
6654 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6655 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6656 FeatureIsNotAvailable.
6658 2007-10-24 Marek Safar <marek.safar@gmail.com>
6660 ** C# 3.0 Partial methods
6662 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6663 methods support. Because of member cache issue with generics only
6664 non-generics partial methods are fully supported.
6666 2007-10-23 Marek Safar <marek.safar@gmail.com>
6668 * class.cs, decl.cs: Rewrote member overloads check to cope with
6669 generics and to use member cache for member checking. It also improves
6670 performance and fixes remaining overloads issues.
6672 2007-10-20 Marek Safar <marek.safar@gmail.com>
6674 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6675 roottypes.cs, typemanager.cs:
6677 A member cache creation logic changed to add members immediately and
6678 not rely on fallback. The member cache is now only prefered way
6679 how to access and find type declaration members. It saves 5 MB of memory
6680 during MWF compilation and makes code ready for more optimizations and
6681 clean-ups, it's also a pre-requirement for partial methods.
6683 2007-10-18 Raja R Harinath <harinath@gmail.com>
6685 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6686 handling for generic parameters.
6688 2007-10-15 Marek Safar <marek.safar@gmail.com>
6690 * class.cs (FixedField): Removed redundant volatile check.
6692 2007-10-15 Marek Safar <marek.safar@gmail.com>
6694 * class.cs, decl.cs: Fixed overload members verification to do only one
6695 check per possible collision.
6697 2007-10-13 Marek Safar <marek.safar@gmail.com>
6699 A fix for bug #325478
6700 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6701 and create only one disposable flags container.
6703 2007-10-12 Marek Safar <marek.safar@gmail.com>
6705 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6706 * statement.cs (Fixed): Fixed variables cloning.
6708 2007-10-12 Marek Safar <marek.safar@gmail.com>
6710 A fix for bug #333342
6711 * class.cs (EventField): Don't mark value type event as synchronized.
6713 2007-10-12 Marek Safar <marek.safar@gmail.com>
6715 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6716 inference to identify best candidate method correctly.
6717 (ProperyExpr): A range variable is read only and cannot be modified.
6719 2007-10-11 Marek Safar <marek.safar@gmail.com>
6721 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6722 logic to identify best candidate method correctly.
6724 2007-10-11 Marek Safar <marek.safar@gmail.com>
6726 * location.cs (Equals, GetHashCode): Removed.
6728 2007-10-11 Marek Safar <marek.safar@gmail.com>
6730 * report.cs: Implemented message recorder. It is used mainly for lambda
6731 expressions to capture otherwise swallowed error messages.
6733 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6735 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6737 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6739 * expression.cs (MemberAccess): Always report lookup failure.
6741 * location.cs: Implemented Equals, GetHashCode.
6743 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6745 2007-10-10 Jb Evain <jbevain@novell.com>
6747 * codegen.cs: re-enable assembly version check.
6749 2007-10-09 Marek Safar <marek.safar@gmail.com>
6751 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6754 * namespace.cs (UsingAlias): Do correct version check.
6756 2007-10-08 Marek Safar <marek.safar@gmail.com>
6758 * expresison.cs, ecore.cs: Issue extension method error message when
6761 * rootcontext.cs: Added ISO_2 compiler mode option.
6763 2007-10-08 Marek Safar <marek.safar@gmail.com>
6765 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6768 2007-10-08 Marek Safar <marek.safar@gmail.com>
6770 * attribute.cs (GetString, GetBoolean): Work with both literal and
6773 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6774 Moved method overload specific methods to MethodGroupExpr.
6776 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6777 it should be less memory consuming.
6779 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6781 * codegen.cs: remove the assembly version check until the buildbot is
6784 2007-10-07 Jb Evain <jbevain@novell.com>
6786 * attribute.cs (Attribute.GetString): if the value
6787 expression is a StringConstant, return its string value.
6789 2007-10-07 Jb Evain <jbevain@novell.com>
6791 * typemanager.cs: add `assembly_version_attribute_type`.
6792 * codegen.cs: on attribute emission, check that the
6793 AssemblyVersionAttribute doesn't overflow.
6795 2007-10-05 Marek Safar <marek.safar@gmail.com>
6797 A fix for bug #324677
6798 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6799 parent container of a scope container with currently resolved one.
6801 2007-10-05 Marek Safar <marek.safar@gmail.com>
6803 A fix for bug #325534
6804 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6807 2007-10-05 Marek Safar <marek.safar@gmail.com>
6809 A fix for bug #327504
6810 * class.cs (Operator.Define): Refactored implicit and explicit user
6811 operator conversion rules.
6813 2007-10-05 Marek Safar <marek.safar@gmail.com>
6815 A fix for bug #327520
6816 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6818 2007-10-04 Marek Safar <marek.safar@gmail.com>
6820 A fix for bug #328022
6821 * class.cs (MethodData.Define): Use correct method to check whether
6822 a method implementents an accessor.
6824 2007-10-04 Marek Safar <marek.safar@gmail.com>
6826 A fix for bug #330069
6827 * statement.cs (Fixed.Resolve): Read the first array element only when
6828 an array is instantiated.
6830 2007-10-04 Marek Safar <marek.safar@gmail.com>
6832 * expression.cs, assign.cs, generics.cs: Print correct operator when
6833 compound assignment is used.
6835 2007-10-04 Marek Safar <marek.safar@gmail.com>
6837 A fix for bug #325841
6838 * expression.cs (ArrayAccess): Use full argument cloning only for
6839 string compound concatenation.
6841 2007-10-03 Marek Safar <marek.safar@gmail.com>
6843 A fix for bug #328774
6844 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6846 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6849 2007-10-03 Raja R Harinath <rharinath@novell.com>
6852 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6853 Event accessibility checks here. Remove some bogus code that
6854 accidently made GenericMethods work.
6855 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6857 2007-09-25 Marek Safar <marek.safar@gmail.com>
6859 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6861 * statement.cs (Block): Refactored AddVariable to allow error handling
6864 * generic.cs: New stub.
6866 2007-09-23 Marek Safar <marek.safar@gmail.com>
6868 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6871 2007-09-17 Marek Safar <marek.safar@gmail.com>
6873 * class.cs: Use partial container to record whether any partial part
6874 contains static field initializer and therefore default contructor has
6877 2007-09-14 Marek Safar <marek.safar@gmail.com>
6879 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6880 mono-list when only one of two partial parts has defined accessibility
6883 2007-09-14 Marek Safar <marek.safar@gmail.com>
6885 A fix for bug #82845
6887 * class.cs (TypeContainer): Set correct resolve context for all field
6890 2007-09-13 Marek Safar <marek.safar@gmail.com>
6892 * assign.cs: Fixed a crash when field is resolved twice with an error.
6894 * codegen.cs: Changed InFieldInitializer to be flag.
6896 * anonymous.cs, ecore.cs, expression.cs: Update after
6897 IsInFieldInitializer rename.
6899 * const.cs: Removed unused parameter.
6901 * class.cs: Changed the way how we resolve and emit field initializers.
6902 The field initilizers have to have access to contructor block to emit
6903 compiler generated code.
6905 2007-09-13 Marek Safar <marek.safar@gmail.com>
6907 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6908 generics use TypeContainer instead.
6910 2007-09-12 Marek Safar <marek.safar@gmail.com>
6912 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6914 * lambda.cs (ResolveParameters): Use more powerful
6915 InflateGenericArgument.
6917 * parameters.cs: Better exception message.
6919 2007-09-10 Marek Safar <marek.safar@gmail.com>
6921 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6922 correct expression block type.
6924 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6926 * expression.cs (Invocation): Extracted method group resolve to
6929 2007-09-07 Marek Safar <marek.safar@gmail.com>
6931 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6932 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6934 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6935 generic extension methods.
6937 2007-09-06 Marek Safar <marek.safar@gmail.com>
6939 A fix for bug #82676 (Do I get it right now?)
6940 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6941 object before a standard conversion is applied.
6943 2007-09-06 Marek Safar <marek.safar@gmail.com>
6945 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6948 2007-09-05 Marek Safar <marek.safar@gmail.com>
6950 A fix for bug #82676
6951 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6952 non-generic interface types.
6954 2007-09-05 Marek Safar <marek.safar@gmail.com>
6956 A fix for bug #82690
6957 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6959 2007-09-05 Marek Safar <marek.safar@gmail.com>
6961 A fix for bug #82571
6962 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6963 modifier for container based methods.
6965 2007-09-05 Marek Safar <marek.safar@gmail.com>
6967 A fix for bug #82676
6968 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6969 any interface-type T means to any of interface type T.
6971 2007-09-04 Marek Safar <marek.safar@gmail.com>
6973 * namespace.cs: We have 2 versions of System.Core assembly.
6975 2007-09-04 Marek Safar <marek.safar@gmail.com>
6977 A fix for bug #82652
6978 * class.cs (Class.GetClassBases): Compare types and not expressions.
6980 2007-09-04 Marek Safar <marek.safar@gmail.com>
6982 A fix for bug #82620
6983 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6984 actually never worked before.
6985 (IndexerAccess): Emit prepared arguments before they are modified.
6987 2007-09-04 Marek Safar <marek.safar@gmail.com>
6989 A fix for bug #82563
6990 * assign.cs: Revert wrong fix.
6992 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6994 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6995 Instead of ldelema/stdind we have to use temporary variables to handle
6996 cases like String.Concat (params string[]).
6998 2007-08-31 Marek Safar <marek.safar@gmail.com>
7000 * class.cs: EmitAttributes to Emit rename.
7002 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
7004 (MemberCore.HasClsCompliantAttribute): Don't depend on
7005 GetClsCompliantAttributeValue execution.
7007 2007-08-31 Marek Safar <marek.safar@gmail.com>
7009 * anonymous.cs: Use shorter type prefix.
7011 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
7014 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
7015 variables when probing is on.
7017 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
7018 unresolved variables.
7019 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
7020 handle transparent identifiers.
7022 2007-08-26 Marek Safar <marek.safar@gmail.com>
7024 * attribute.cs (IsClsCompliant): Add nullable types test.
7026 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
7028 * doc.cs : catch other types of exception than XmlException to
7029 report CS1570. Fixed bug #82565.
7031 2007-08-23 Marek Safar <marek.safar@gmail.com>
7033 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
7034 The number of delegate parameters has to match.
7035 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
7038 2007-08-21 Marek Safar <marek.safar@gmail.com>
7040 * anonymous.cs (AnonymousMethod): Generate private anonymous method
7041 to fix problem with private arguments.
7043 2007-08-20 Marek Safar <marek.safar@gmail.com>
7045 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
7047 * decl.cs (MemberName): Ignore generic type with no generic arguments.
7049 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
7050 empty. Add cloning suport.
7052 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
7054 2007-08-20 Marek Safar <marek.safar@gmail.com>
7056 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
7057 to create EmptyCast. It handles EmptyConstantCast specialization for
7060 2007-08-18 Marek Safar <marek.safar@gmail.com>
7062 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
7063 (EmitArrayArgument): One routine for array arguments.
7064 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
7066 2007-08-17 Marek Safar <marek.safar@gmail.com>
7068 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
7070 2007-08-17 Marek Safar <marek.safar@gmail.com>
7072 * anonymous.cs: MemberLookupFinal update.
7074 * class.cs (ConstructorInitializer): Is expression based.
7076 * delegate.cs: MethodGroupExpr update.
7078 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
7080 (Error_MemberLookupFailed): Customizable error override.
7081 (MethodGroupExpr): Keep queried type for later usage.
7082 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
7085 * expression.cs: Error_MemberLookupFailed refactoring.
7086 (New.DoResolve): Resolve as much as possible.
7087 (ElementInitializer.Error_MemberLookupFailed): Object initializer
7088 customization for invalid member types.
7090 * statement.cs: MethodGroupExpr update.
7092 2007-08-16 Marek Safar <marek.safar@gmail.com>
7094 * modifier.cs (Check): Check all modifiers and not only accessibility
7097 2007-08-16 Marek Safar <marek.safar@gmail.com>
7099 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
7100 type and not an expression.
7102 2007-08-16 Marek Safar <marek.safar@gmail.com>
7104 * statement.cs (Catch.Clone): Type and variable can be null.
7106 2007-08-16 Marek Safar <marek.safar@gmail.com>
7108 A fix for bug #81979
7109 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
7110 I am really not sure whether this is the best fix.
7112 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
7115 2007-08-14 Marek Safar <marek.safar@gmail.com>
7117 ** C# 3.0 Object and collection initializers (major re-write)
7119 * assign.cs (DoResolve): Initializers are not assign related.
7121 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
7122 used during collection or object initialization.
7124 * expression.cs (Error_InvalidArguments): Add initializers specific
7125 messages. More will come later because it requires some general
7127 (New.DoResolve): Better error handling for unsafe types.
7128 (EmptyExpressionStatement): New class.
7129 (ElementInitializer): An object initializer expression.
7130 (CollectionElementInitializer): A collection initializer expression.
7131 (CollectionOrObjectInitializers): A block of object or collection
7133 (NewInitialize): New expression with element/object initializers.
7135 * statement.cs: Reverted object/collection initializer hacks.
7137 * typemanager.cs (CSharpName): Filter __arglist type.
7139 2007-08-09 Marek Safar <marek.safar@gmail.com>
7141 ** C# 3.0 Anonymous Types (update to the latest standard)
7143 * expression.cs (Binary.ResolveOperator): Threat all null based types
7145 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
7146 (AnonymousTypeParameter): Updated.
7148 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
7149 (AnonymousTypeClass): New anonymous type container.
7151 * class.cs (AddField): Return operation result.
7153 * generic.cs: Another empty TypeArguments overload.
7155 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
7156 are stored at top of normal hierarchy.
7158 * typemanager.cs (CSharpName): Filter anonymous types.
7160 2007-08-09 Marek Safar <marek.safar@gmail.com>
7162 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
7163 as single Concat call. How could we miss that :-(
7165 2007-08-08 Marek Safar <marek.safar@gmail.com>
7167 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
7169 2007-08-07 Miguel de Icaza <miguel@novell.com>
7171 * expression.cs: Fix the previous commit, the creation of the
7172 arguments array list needs also to be conditional on the arguments
7175 * class.cs: Add a little bit of help to help narrow down problems.
7177 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
7178 not try to copy in that case.
7180 * driver.cs: When building SMCS, include a new different set of
7181 default assemblies here. Do this here so we can control whether
7182 to include the default assemblies with /noconfig.
7184 2007-08-03 Marek Safar <marek.safar@gmail.com>
7186 A fix for bug #81979
7187 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
7190 2007-08-03 Marek Safar <marek.safar@gmail.com>
7192 A fix for bug #82300
7194 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
7195 we are in probing scope.
7197 2007-08-03 Marek Safar <marek.safar@gmail.com>
7199 A fix for bug #82301
7201 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
7202 (Statement.CloneTo): Clone and not map children blocks.
7204 2007-08-03 Marek Safar <marek.safar@gmail.com>
7206 A fix for bug #82299
7208 * expression.cs (LocalVariableReference.CloneTo): Remap local info
7211 * statement.cs (Statement.CloneTo): Clone variables before statements
7212 to allow remaping of local variables.
7214 2007-08-03 Marek Safar <marek.safar@gmail.com>
7216 A fix for bug #82296
7219 * report.cs: Log crash details for future clone problems.
7221 * statement.cs (Return.Clone): Don't clone non-existent expression.
7223 2007-08-03 Raja R Harinath <harinath@gmail.com>
7225 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
7226 (Class.AddBasesForPart): Move CS0537 check here from ...
7227 * cs-parser.jay (class_declaration): ... here. Move calling of
7228 'AddBasesForPart' to ...
7229 (class_bases): ... here.
7230 (struct_declaration, interface_declaration): Update to changes.
7232 2007-08-02 Marek Safar <marek.safar@gmail.com>
7234 A fix for bug #81923
7236 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
7237 conversion is allowed.
7239 2007-08-02 Marek Safar <marek.safar@gmail.com>
7241 A fix for bug #81564
7243 * ecore.cs (EventExpr): Add IsBase handling.
7245 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
7248 2007-08-02 Raja R Harinath <harinath@gmail.com>
7250 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
7251 * cs-parser.jay: Some whitespace cleanups.
7252 (current_delegate): New.
7254 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
7255 a dummy code block, and use 'type_name' instead of 'member_name'.
7256 (interface_declaration, class_declaration): Likewise.
7257 (delegate_declaration): Likewise. Rearrange slightly and use
7259 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7260 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7262 2007-08-02 Marek Safar <marek.safar@gmail.com>
7264 A fix for bug #82039
7266 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7269 * typemanager.cs (CSharpName): Split to string overload.
7271 2007-08-02 Marek Safar <marek.safar@gmail.com>
7274 * report.cs: Updated warning CS0472.
7276 2007-08-01 Marek Safar <marek.safar@gmail.com>
7278 A fix for bug #82181
7280 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7282 2007-08-01 Marek Safar <marek.safar@gmail.com>
7284 A fix for bug #82277
7285 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7287 2007-08-01 Marek Safar <marek.safar@gmail.com>
7289 ** C# 3.0 Type Inference (major bits are working)
7291 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7292 (.ImplicitStandardConversionExists): Uses compatible.
7293 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7294 (.InferReturnType): New method.
7295 (.Compatible): Refactored.
7296 (.ResolveParameters): Uses factory to create resolved parameters.
7297 (.CompatibleMethod): Add probing mode support.
7298 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7299 clearly distinguish between 2 different operations.
7300 (LambdaMethod): Moved to lambda.cs.
7301 (AnonymousMethod): Removed unused fields and methods.
7302 (AnonymousDelegate): Simplified.
7304 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7306 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7308 * delegate.cs (Delegate): New mehods to reduce code duplication.
7309 (.GetConstructor): New method.
7310 (.GetInvokeMethod): New method.
7311 (DelegateCreation): Updated.
7313 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7315 (OverloadResolve): Made probing little bit faster.
7317 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7320 * generic.cs (TypeInferenceContext): Dummy implementation.
7322 * iterators.cs: Updated after Resolve/Define rename.
7324 * lambda.cs (LambdaExpression)
7325 (.ResolveParameters): Handles both type of arguments and type inference too.
7327 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7328 (InflateTypes): Updated.
7330 * support.cs (InflateTypes): Changed signature and updated.
7332 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7333 (MemberLookup_FindMembers): More MS tricks.
7334 (GetParameterData): Ditto.
7335 (GetDelegateParameters): Uses quick path for dynamic types.
7337 2007-08-01 Marek Safar <marek.safar@gmail.com>
7339 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7342 2007-07-31 Marek Safar <marek.safar@gmail.com>
7344 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7347 2007-07-26 Jb Evain <jbevain@novell.com>
7349 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7350 which takes a boolean 'report_errors', similar to the GetMethod.
7351 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7352 in .net 2.1, do not report errors here.
7354 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7355 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7356 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7359 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7360 of the type InternalsVisibleToAttribute before the first call
7361 to CoreLookupType which is allowed to fail (third boolean parameter
7362 to true). Because, during the resolution for a type that is not
7363 immediately found, we try to check if the type is not defined in
7364 a friend assembly, and to do so, we need the
7365 InternalVisibleToAttribute.
7367 2007-07-23 Miguel de Icaza <miguel@novell.com>
7369 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7370 feature that allows structs to be compared against null and inline
7371 the result as true or false.
7373 Notice that the same code is not permitted inside a generic block
7374 of code that would do:
7376 class Foo<T> where T : struct {
7383 It is only allowed if the type of T is not bound (no where
7384 clause). In my opinion, this CSC 2 behavior is broken but people
7385 seem to be using it (IronRuby does, a few bug reports on bugzilla
7386 have it and some people have complained about it).
7388 All of the users that depend on this behavior have code that is
7391 * report.cs (Warning, Error): make these take object arguments,
7392 not strings, as that allows us to take advantage of Format.
7394 2007-07-20 William Holmes <billholmes54@gmail.com>
7396 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7397 Left member variable for the Count.
7398 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7399 MemberName.CountTypeArguments to avoid a NRE.
7401 This code is contributed under the MIT X11 license
7403 2007-07-18 Marek Safar <marek.safar@gmail.com>
7405 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7407 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7409 * doc.cs : generic method arguments are written as ``x while generic
7410 type arguments are `x. Combined with the previous change, fixed bug
7413 2007-07-18 Raja R Harinath <rharinath@novell.com>
7416 * expression.cs (Binary.ResolveOperator): When converting
7417 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7419 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7421 * doc.cs : when T: or whatever x: is specified, it does not really
7422 check the doc comment's syntax correctness. Fixed bug #82006.
7424 2007-07-18 Marek Safar <marek.safar@gmail.com>
7426 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7427 LambdaExpression better.
7429 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7431 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7433 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7434 as it can be generated.
7436 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7439 * lambda.cs (LambdaExpression): Refactored to share same code with
7440 AnonymousMethodExpression.
7442 2007-07-17 Marek Safar <marek.safar@gmail.com>
7444 * anonymous.cs (MakeName): Include host name for easier debugging.
7445 (LambdaMethod): New class for lambda spcecific stuff.
7447 * attribute.cs: Set EmitContext return type.
7449 * class.cs: Set EmitContext return type.
7451 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7452 with null/void meaning.
7454 * iterators.cs (ContainerType): Implemented.
7456 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7458 * statement.cs (Return): Updated to lambda expressions.
7459 (Block.CloneTo): Parent can be null.
7461 2007-07-13 Marek Safar <marek.safar@gmail.com>
7463 A fix for bug #81917
7464 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7466 * class.cs (FixedField): Check whether field is in unsafe scope.
7468 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7469 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7471 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7474 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7476 2007-07-13 Marek Safar <marek.safar@gmail.com>
7478 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7479 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7482 2007-07-13 Marek Safar <marek.safar@gmail.com>
7484 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7486 2007-07-13 Marek Safar <marek.safar@gmail.com>
7488 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7489 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7491 * codegen.cs(EmitContext): Add ProbingMode flag.
7493 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7495 * driver.cs: For now set both warning values.
7497 * ecore.cs (SimpleName): Name is readonly.
7498 (MethodGroup.OverloadResolve): One quick path for probing.
7500 * expression.cs (Unary): Set Oper r/o.
7501 (Binary): Set Oper r/o.
7502 (ParameterReference): Set few instance variables as r/o.
7503 (ParameterReference.DoResolveBase): Don't capture aruments when
7505 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7506 (Arglist): arguments are private.
7507 (SizeOf): type is private and r/o.
7508 (MemberAccess): arguments are private.
7510 * report.cs: Enhanced reporting on/off capabilities.
7512 * lambda.cs: Uses ec.IsInProbingMode.
7513 (ContextualReturn): Derives from return.
7515 * rootcontext.cs: For now set both warning values.
7517 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7519 (Return.Resolve): Don't die immediately.
7520 (Block.Resolve): Speed-up probing.
7521 (Block.CloneTo): Clone only child blocks.
7523 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7525 * iterators.cs: reverted Miguel's latest change (r81925) as it
7526 breaks the build in System.
7528 2007-07-13 Miguel de Icaza <miguel@novell.com>
7530 * iterators.cs (Yield.CheckContext): Check for the iterator type
7531 also here as we can call into Yield even in codepaths that are not
7533 (MethodOrOperator is the only path that was checked).
7535 In addition to the standard check, use a more specific check for
7536 constructors to report a more verbose error.
7538 2007-07-12 Miguel de Icaza <miguel@novell.com>
7540 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7541 report the warning and continue
7543 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7544 values on the stack on the call to Emit. Use EmitStatement if
7545 possible, or using Emit + Pop if not possible. Fixes #82064
7547 2007-07-12 Raja R Harinath <rharinath@novell.com>
7549 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7550 avoid try...finally in some cases.
7552 2007-07-10 Marek Safar <marek.safar@gmail.com>
7554 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7556 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7557 instead of method. Re-use standard error handling.
7558 (ConstructorInitializer.Emit): Simplified.
7560 * delegate.cs: Updated after Invocation.EmitCall change.
7562 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7563 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7564 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7565 method and don't permanently changing input arguments.
7566 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7567 is resolved it has one of the candidates is the best one which is later
7568 used to emit. Removed a few unused method.
7569 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7571 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7572 (Binary.ResolveOperator): Ditto.
7573 (ConditionalLogicalOperator.DoResolve): Ditto.
7574 (Invocation): Uses method group.
7575 (Invocation.DoResolve): Simplified.
7576 (Invocation.EmitCall): Removed useless is_static.
7577 (Invocation.Emit): Delegate to method group.
7578 (Invocation.EmitStatement): Simplified.
7579 (New): Uses method group.
7580 (MemberAccess.DoResolve): Don't destroy original expression.
7582 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7584 2007-07-04 Marek Safar <marek.safar@gmail.com>
7586 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7589 * lambda.cs: Add custom error message type.
7591 2007-07-03 Marek Safar <marek.safar@gmail.com>
7593 * lambda.cs: Simplified little bit.
7595 * parameter.cs: Introduced ImplicitLambdaParameter.
7596 (Parameters.CreateFullyResolved): New factory instead of ctor.
7600 * delegate.cs: Updated parameter creation.
7602 2007-07-03 Marek Safar <marek.safar@gmail.com>
7604 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7607 * generic.cs: Synchronized with gmcs.
7609 2007-07-03 Marek Safar <marek.safar@gmail.com>
7611 * class.cs (Indexer): Check return type as soon as possible.
7613 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7616 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7618 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7620 * parameter.cs (Parameter): Use expression type when it is available.
7622 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7623 method modifier for the first parameter only.
7625 2007-06-24 Marek Safar <marek.safar@gmail.com>
7627 A fix for bug #81938
7628 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7630 * constant.cs: Tide up an exception message.
7632 2007-06-22 Marek Safar <marek.safar@gmail.com>
7634 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7635 an uninitialized variable is used.
7637 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7639 2007-06-22 Marek Safar <marek.safar@gmail.com>
7641 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7642 not found error handling.
7644 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7646 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7647 (ArrayCreation.DoResolve): Simplified.
7648 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7649 its own resolve process.
7650 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7652 2007-06-20 Marek Safar <marek.safar@gmail.com>
7654 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7657 2007-06-20 Marek Safar <marek.safar@gmail.com>
7659 * cs-tokenizer.cs: Removed var related stuff.
7661 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7662 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7663 a type and a keyword at same time.
7665 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7668 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7669 implicitly typed arrays, more changes will follow.
7671 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7673 2007-06-19 Marek Safar <marek.safar@gmail.com>
7675 * ecore.cs (VarExpr): Removed Handled field.
7677 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7678 build-in assign functionality.
7679 (ForEach.Resolve): Removed all implicitly typed local variable code and
7681 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7682 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7684 2007-06-18 Marek Safar <marek.safar@gmail.com>
7686 * assign.cs: Removed implicitly typed local variable check.
7688 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7689 referencing implicitly typed local variable.
7690 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7693 * statement.cs (Fixed): Removed unsupported implicitly typed local
7696 2007-06-15 Marek Safar <marek.safar@gmail.com>
7698 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7700 2007-06-14 Marek Safar <marek.safar@gmail.com>
7702 A fix for bugs #81855 and #76274
7703 * attribute.cs (AttachTo): Always set owner for global attributes to
7706 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7709 * cs-parser.jay: Assembly and module attributes must precede all other
7710 elements except using clauses and extern alias declarations.
7712 2007-06-13 Marek Safar <marek.safar@gmail.com>
7714 A fix for bug #81748
7716 * expression.cs: More checks for non ISO-1 features.
7718 2007-06-12 Marek Safar <marek.safar@gmail.com>
7720 A fix for bug #81807
7721 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7722 present inside switch statement and it is required by nullable check.
7724 2007-06-12 Marek Safar <marek.safar@gmail.com>
7726 A fix for bug #81840
7727 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7728 when type matching fails.
7730 * namespace.cs: Tiny error message change.
7732 2007-06-12 Marek Safar <marek.safar@gmail.com>
7734 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7735 reporting. Added automatic property check.
7737 * class.cs: Updated after CheckAbstractAndExtern relocation.
7738 (AEventPropertyAccessor.GetSignatureForError): Customized.
7740 2007-06-11 Marek Safar <marek.safar@gmail.com>
7742 * class.cs (DefineBaseTypes): Base type can be undefined.
7744 * ecore.cs (TypeLookup): Minor refactoring.
7745 (DoResolveAsTypeStep): Removed redundant check.
7747 * namespace.cs (Lookup): Removed redundant check.
7749 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7750 ResolveAsTypeTerminal step.
7751 (BootstrapCorlib_*): Simplified.
7752 (PopulateCoreType): Core types can be now external.
7754 2007-06-07 Marek Safar <marek.safar@gmail.com>
7756 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7758 (InferTypeArguments): Infers anonymous expression type arguments.
7759 (Compatible): Split to Compatible and InferTypeArguments.
7761 * lambda.cs: Updated.
7763 2007-06-08 Marek Safar <marek.safar@gmail.com>
7765 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7767 2007-06-07 Raja R Harinath <harinath@gmail.com>
7769 Fix #80477, cs0135-2.cs, cs0135-3.cs
7770 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7771 names to the "known" variables list.
7772 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7773 parameter names are also "known".
7774 (Block.CheckError136): Remove.
7775 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7778 2007-06-07 Marek Safar <marek.safar@gmail.com>
7780 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7782 2007-06-06 Marek Safar <marek.safar@gmail.com>
7784 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7785 internal error not an user error.
7787 * expression.cs (IsApplicable): Refactored to make debugging easier.
7789 * support.cs: More tricks for non-mono runtimes.
7791 * typemanager.cs (CoreLookupType): Made public.
7792 (InitSystemCore): All linq specific stuff moved to linq.cs
7794 2007-06-05 Marek Safar <marek.safar@gmail.com>
7796 * typemanager.cs (CSharpSignature): One more missing build-in types
7798 More tricks for non-mono runtime.
7800 2007-06-05 Raja R Harinath <harinath@gmail.com>
7802 * statement.cs (Block.CheckError136_InParents): Remove.
7803 (Block.AddVariable): Use GetParameterInfo instead.
7804 (ToplevelBlock.ProcessArguments): Likewise.
7806 2007-06-04 Raja R Harinath <rharinath@novell.com>
7808 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7810 (ToplevelBlock.GetParameterInfo): Split out of ...
7811 (ToplevelBlock.GetParameterRefernce): ... this.
7812 (ToplevelBlock.ParameterMap): Remove.
7813 * expression.cs (ParameterReference): Update to use
7814 ToplevelParameterInfo.
7816 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7819 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7820 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7822 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7823 (ToplevelBlock.ProcessParameters) ... here.
7824 (ToplevelBlock..ctor): Invoke it.
7826 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7829 * statement.cs (IKnownVariable): New interface.
7830 (LocalInfo): Implement it.
7831 (ToplevelParameterInfo): New class.
7832 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7833 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7834 GetKnownVariableInfo.
7836 2007-06-03 Raja R Harinath <harinath@gmail.com>
7838 Partly speed up CS0136 error checks.
7839 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7840 'recurse' parameter.
7841 (Block.DoCheckError136): Only check errors in parameters. Move
7842 local variable checks ...
7843 (Block.AddVariable): ... here, and ...
7844 (ToplevelBlock.ResolveMeta): ... here.
7846 2007-06-02 Raja R Harinath <harinath@gmail.com>
7848 * statement.cs (Block.IsChildOf): Remove.
7850 * statement.cs (Statement.Clone): Move special case code ...
7851 (Block.CloneTo): ... here.
7853 2007-05-29 Raja R Harinath <rharinath@novell.com>
7855 * statement.cs (ToplevelBlock.container): Remove field. It's
7856 redundant with 'Parent'.
7857 (ToplevelBlock.ContainerBlock): Remove accessor.
7858 (ToplevelBlock..ctor): Update to changes. Register anonymous
7859 child with parent here, ...
7860 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7862 (start_anonymous): Don't save current_block.
7863 (top_current_block): Remove.
7865 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7866 (Block.Resolve): Update to changes.
7867 (Block..ctor): Move setting of "correct" 'Toplevel'
7868 and 'Explicit' fields to ...
7869 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7871 2007-05-27 Raja R Harinath <harinath@gmail.com>
7874 * statement.cs (Block.Implicit): Remove.
7875 (Block): Update to changes.
7876 * flowanalysis.cs: Likewise.
7878 Mildly speed up CheckInvariantMeaningInBlock
7879 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7880 Recursively call AddKnownVariable to all enclosing blocks.
7881 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7882 Remove recursive calls.
7883 (Block): Update to changes.
7885 New ExplicitBlock invariants
7886 * statement.cs (Block.Explicit): New field. It points to the
7887 immediately enclosing non-implicit block.
7888 (Block..ctor): Maintain the invariant.
7889 * cs-parser.jay: Take advantage of invariant.
7891 Introduce ExplicitBlock
7892 * statement.cs (ExplicitBlock): New.
7893 (ToplevelBlock): Derive from it.
7894 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7896 (Block.Implicit): Update to changes.
7897 * cs-parser.jay: Update to changes.
7900 * codegen.cs (EmitContext.IsLastStatement): Remove.
7901 * statement.cs (Block.DoEmit): Update to changes.
7903 2007-05-25 Raja R Harinath <rharinath@novell.com>
7905 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7906 modifying current_block directly.
7908 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7910 * class.cs: Implemented automatic properties (C# 3.0)
7911 Thanks to Marek for the help.
7913 2007-05-23 Raja R Harinath <rharinath@novell.com>
7915 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7916 variable as assigned, note also that all its components are
7918 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7920 2007-05-19 Marek Safar <marek.safar@gmail.com>
7922 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7923 member is marked as compiler generated.
7925 * decl.cs (MemberCore): Refactored ModFlags into property.
7927 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7928 (Check): Check only accessibility modifiers.
7930 2007-05-18 Raja R Harinath <rharinath@novell.com>
7932 Track all assignable slots in one bit array
7933 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7934 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7935 logic from VariableMap constructor here. Use the same 'offset'
7936 variable that's later used for computing offsets of local
7938 * flowanalysis.cs (UsageVector.parameters): Remove.
7939 (UsageVector): Update to changes.
7940 (VariableMap): Remove.
7942 Avoid creating ParameterMap in every block
7943 * statement.cs (Block.ParameterMap): Move ...
7944 (ToplevelBlock.ParameterMap): ... here.
7945 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7947 * flowanalysis.cs (FlowBranching.param_map): Remove.
7948 (FlowBranching.UsageVector): Update to changes.
7949 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7951 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7953 * expression.cs (ParameterReference): Distinguish between block
7954 where parameter was referenced and declared.
7956 2007-05-18 Marek Safar <marek.safar@gmail.com>
7958 * flowanalysis.cs, statement.cs: Put back improved error handling.
7960 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7964 Imporved object and collection initialization (C# 3.0).
7966 2007-05-15 Marek Safar <marek.safar@gmail.com>
7968 A fix for bug #81380
7969 * expression.cs (Is.DoResolve): Only value types have constant `is'
7972 2007-05-15 Raja R Harinath <rharinath@novell.com>
7974 * statement.cs (ToplevelBlock.child): Remove.
7976 2007-05-15 Raja R Harinath <harinath@gmail.com>
7978 Rationalize ResolveMeta: refactoring
7979 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7980 out constant handling code into ...
7981 (Block.DoResolveConstants): ... this.
7983 Rationalize ResolveMeta: kill local_map
7984 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7985 (Block.AssignableSlots): New.
7986 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7987 for locals -- move code from VariableMap here. Avoid unnecessary
7989 * flowanalysis.cs (FlowBranching.local_map): Remove.
7990 (FlowBranching..ctor): Use Block.AssignableSlots.
7991 (VariableMap): Remove unused constructors.
7993 2007-05-11 Raja R Harinath <rharinath@novell.com>
7995 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7997 2007-05-11 Marek Safar <marek.safar@gmail.com>
7999 * typemanager.cs (IsFriendAssembly): Should not be called for building
8002 2007-05-09 Marek Safar <marek.safar@gmail.com>
8004 * literal.cs (NullConstant): Print null in all cases.
8006 * expression.cs (Binary.ResolveOperator): Implemented delegate
8007 comparison based on C# 2.0 changes.
8009 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
8011 This code is contributed under the MIT X11 license
8013 The following enables support for several C# 3.0 language features:
8015 * cs-tokenizer.cs: Added support for the "var" keyword.
8017 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
8018 Added VarExpr class to facilitate type inferencing.
8020 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
8021 to support anonymous types.
8023 * assign.cs: Added support for type inferencing and initialization.
8025 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
8027 * expression.cs: Added implicit array support to ArrayCreation.
8028 Added 5 types and 1 interface:
8030 IInitializable Implementing classes can inject initializing
8031 statements after object instantiation.
8033 Initializer Stores data for object initialization.
8035 AnonymousType An expression for anonymous types.
8037 AnonymousTypeParameter Stores data about an anonymous type's field.
8039 NewInitialize An expression for object initialization.
8041 CollectionInitialize An expression for collection initialization.
8043 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
8046 2007-05-06 Marek Safar <marek.safar@gmail.com>
8048 A fix for bug #81500
8049 * cs-tokenizer.cs: Add special handling for coalescing operator.
8051 2007-05-06 Marek Safar <marek.safar@gmail.com>
8053 A fix for bug #81529
8054 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
8055 its value from base class until it is redefined.
8057 2007-05-02 Raja R Harinath <rharinath@novell.com>
8059 Fix regression in cs0631-3.cs
8060 * cs-parser.jay (operator_declarator): Add opt_attributes to error
8061 fallback. Make error fallback catch more cases.
8063 2007-05-01 Miguel de Icaza <miguel@novell.com>
8065 * cs-parser.jay: Allow parameters in operator declarations to have
8068 2007-04-27 Miguel de Icaza <miguel@novell.com>
8070 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
8073 * lambda.cs (ContextualReturn.Resolve): An expression is valid
8074 inside the ContextualReturn, it does not have to be an
8075 ExpressionStatement.
8077 2007-04-24 Miguel de Icaza <miguel@novell.com>
8079 * lambda.cs (ContextualReturn.Resolve): if the return type is not
8082 2007-04-23 Miguel de Icaza <miguel@novell.com>
8084 * anonymous.cs (AnonymousContainer): split the virtual Resolve
8085 method in two methods: ResolveNoDefine and Resolve.
8087 ResolveNoDefine will stop just after ResolveTopBlock has been
8090 Resolve will then continue by creating a method and issuing the
8091 call to method.Define ().
8093 (AnonymousMethod): Split and implement the new Resolve and
8094 ResolveNoDefine as well.
8096 * lambda.cs (LambdaExpression): Split the anonymous method
8097 resolution code into a separate routine (CoreCompatibilityTest)
8098 from DoCompatibleTest.
8100 (LambdaExpression.TryBuild): New method, this method tries to
8101 build the LambdaExpression with the given set of types to be used
8102 as the types for the various parameters of the lambda expression.
8104 If the compilation succeed with the given types, the infered type
8105 of the Anonymous method is returned, otherwise null is returned.
8107 2007-04-23 Marek Safar <marek.safar@gmail.com>
8109 A fix for bug #81414
8110 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
8112 2007-04-22 Miguel de Icaza <miguel@novell.com>
8114 * cs-tokenizer.cs: Change various identifiers here from the
8115 camelCasing to the recommended Linux-like style for instance
8116 variables from the Coding Guidelines.
8118 2007-04-19 Martin Baulig <martin@ximian.com>
8121 (Convert.ImplicitReferenceConversionCore): Allow conversions from
8122 System.Enum to System.ValueType.
8124 2007-04-13 Martin Baulig <martin@ximian.com>
8126 Rewrote implicit reference conversions. We need to distinguish
8127 between implicit reference conversions (13.1.4) and implicit
8128 boxing conversions (13.1.5).
8130 According to the spec, there's an an implicit conversion
8131 "From a one-dimensional array-type S[] to IList<T> and base
8132 interfaces of this interface, provided there is an implicit
8133 reference conversion from S to T." Note that this does not
8134 include boxing conversions.
8137 (Convert.ImplicitTypeParameterBoxingConversion): New method.
8138 (Convert.ImplicitReferenceConversion): Split into
8139 ImplicitReferenceConversionCore() and
8140 ImplicitBoxingConversionExist().
8141 (Convert.ImplicitReferenceConversionExists): Use the new
8142 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
8144 2007-04-12 Martin Baulig <martin@ximian.com>
8146 * convert.cs (Convert.ImplicitReferenceConversion): Move the
8147 `TypeManager.null_type' checks up to the top of the method.
8149 2007-04-11 Marek Safar <marek.safar@gmail.com>
8151 A fix for bug #81350
8152 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
8155 2007-04-11 Martin Baulig <martin@ximian.com>
8157 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
8158 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
8159 to make this work for generic classes; fixes #79561.
8161 2007-04-11 Martin Baulig <martin@ximian.com>
8163 * expression.cs (As): Add support for nullable types; fixes #79371.
8165 2007-04-11 Martin Baulig <martin@ximian.com>
8167 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
8168 `type.FullName' is null; fixes #80243.
8170 2007-04-11 Martin Baulig <martin@ximian.com>
8172 * expression.cs (Invocation.IsApplicable): Don't modify the method
8173 if type inference succeeded, but the method was not applicable.
8176 2007-04-10 Marek Safar <marek.safar@gmail.com>
8178 A fix for bug #81324
8179 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
8180 internal and external namespaces containers.
8182 2007-04-10 Martin Baulig <martin@ximian.com>
8184 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
8185 TypeManager.DropGenericMethodArguments() so we also call
8186 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
8188 2007-04-10 Martin Baulig <martin@ximian.com>
8190 * iterators.cs (Iterator.CreateIterator): Don't crash if
8191 `method.ReturnType' is null. This happens if something went wrong
8192 while resolving that typ (we already reported an error in this case).
8194 2007-04-10 Martin Baulig <martin@ximian.com>
8196 * expression.cs (New.DoResolve): Don't call CheckComImport() on
8197 generic interfaces; report the CS0144 directly.
8199 2007-04-10 Martin Baulig <martin@ximian.com>
8201 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
8202 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
8204 2007-04-10 Martin Baulig <martin@ximian.com>
8206 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
8208 2007-04-09 Raja R Harinath <rharinath@novell.com>
8211 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
8212 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
8215 * statement.cs (For.Resolve): If resolution fails, use
8218 2007-04-08 Marek Safar <marek.safar@gmail.com>
8220 * anonymous.cs (MakeName): Make faster and zero-based.
8221 (VerifyExplicitParameterCompatibility): Back to mode where generic
8222 parameter is ignored.
8223 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
8225 * class.cs (EmitType): Method can emit another new method.
8227 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
8229 * driver.cs: Updated.
8231 * lambda.cs: Reuse predefined empty parameters.
8233 * parameter.cs: Updated
8235 * support.cs: Implemented InflateTypes.
8237 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
8238 (InitSystemCore): Introduced to isolate 3.0 dependencies.
8240 2007-04-03 Martin Baulig <martin@ximian.com>
8244 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
8245 version of TypeManager.IsOverride() which also works with generic
8248 2007-04-03 Martin Baulig <martin@ximian.com>
8253 (Convert.ExplicitReferenceConversion): We need to cast when
8254 converting from IList<T> to S[].
8256 2007-04-01 Marek Safar <marek.safar@gmail.com>
8258 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8261 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8263 2007-03-31 Marek Safar <marek.safar@gmail.com>
8265 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8266 argument and return type inferring.
8268 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8269 (ReturnType): Turned to property.
8271 * statement.cs (Return): Implemented return type inferring.
8273 * support.cs (ReflectionParameters): Use local types if possible.
8275 2007-03-30 Raja R Harinath <rharinath@novell.com>
8277 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8278 (FlowBranching.UsageVector): Update to changes.
8280 Prepare to kill 'Reachability'
8281 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8282 argument of constructor.
8284 2007-03-29 Raja R Harinath <rharinath@novell.com>
8286 Prepare to kill 'Reachability'
8287 * flowanalysis.cs (UsageVector.is_unreachable): New.
8288 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8289 'reachability', and verify they're consistent.
8292 * expression.cs (New.EmitStatement): Handle type parameters here too.
8294 2007-03-29 Martin Baulig <martin@ximian.com>
8299 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8300 CompilerGeneratedClass.
8301 (ScopeInfo.EmitScopeInstance): Make this protected.
8302 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8303 `ec.CurrentAnonymousMethod.Scope == Scope'.
8305 * statement.cs (Block.ScopeInfo): Make this a property.
8307 2007-03-27 Raja R Harinath <harinath@gmail.com>
8309 Prepare to kill 'Reachability'
8310 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8311 (FlowBranching.UsageVector.Reachability): Remove property.
8312 (FlowBranching.UsageVector.IsUnreachable): New property.
8313 (FlowBranching.UsageVector.ResetBarrier): New.
8314 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8315 * codegen.cs, statement.cs: Update to changes.
8317 2007-03-27 Martin Baulig <martin@ximian.com>
8322 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8325 2007-03-26 Raja R Harinath <rharinath@novell.com>
8327 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8328 instead of TriState. Remove all mention of TriState.
8330 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8331 replaced by a boolean. Add boolean 'is_unreachable' field, check
8332 and maintain invariants.
8334 2007-03-25 Marek Safar <marek.safar@gmail.com>
8336 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8338 2007-03-25 Marek Safar <marek.safar@gmail.com>
8340 * expression.cs: Stop using obsolete 2.0 opcodes.
8342 2007-03-25 Marek Safar <marek.safar@gmail.com>
8344 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8345 one of the latests Martin's fixes.
8347 2007-03-23 Miguel de Icaza <miguel@novell.com>
8349 * expression.cs: On BigEndian systems, swap the bytes, temporary
8350 solution until we get a new bitconverter class.
8352 2007-03-23 Martin Baulig <martin@ximian.com>
8356 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8357 "Method" and "Method`1". Normally, a cache lookup is done on the
8358 "Method" form (ie. without the generic arity), but this one makes
8359 lookups on the full form work as well.
8361 2007-03-22 Raja R Harinath <rharinath@novell.com>
8363 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8366 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8368 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8369 ordered_member_list, to TypeBuilder to store members to be defined
8370 in the order they were parsed in.
8371 - ordered_explicit_member_list contains all properties indexers
8372 and methods that are defined as explicit implementation of an
8373 interface or base class.
8374 - ordered_member_list contains all properties indexers and methods
8375 that are not defined as explicit implementation of an interface
8378 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8379 functionality in these removed classes has been replaced with
8380 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8381 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8383 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8384 to CheckForDuplications inside GetMethod and SetMethod Define Method
8385 to handle method property and indexer name conflicts.
8389 All code is contributed under the MIT/X11 license.
8391 2007-03-20 Martin Baulig <martin@ximian.com>
8393 * class.cs (TypeContainer.Interfaces): Removed; they're now
8394 included in `TypeContainer.Types'.
8396 2007-03-20 Martin Baulig <martin@ximian.com>
8398 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8400 * class.cs (TypeContainer.CreateType): New public method. This is
8401 now called before DefineType() to create the TypeBuilders.
8402 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8403 has already been created by CreateType().
8404 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8405 don't resolve our base classes here; this has been moved into
8406 DefineBaseTypes(). We're now called from CreateType().
8407 (TypeContainer.DefineBaseTypes): New private method; resolve our
8408 base classes here. We're now called from DefineType().
8411 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8412 our types first to create all the TypeBuilders. After that, call
8413 TypeContainer.DefineType() on all the types which'll resolve their
8414 base classes and setup the resolve order.
8416 2007-03-20 Martin Baulig <martin@ximian.com>
8418 * class.cs (TypeContainer.Enums): Removed; they're now included in
8419 `TypeContainer.Types'.
8421 2007-03-20 Martin Baulig <martin@ximian.com>
8424 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8425 (TypeContainer.DoResolveMembers): Call DefineType() on our
8426 `compiler_generated' classes; moved here from DefineNestedTypes().
8429 (RootContext.ResolveTree): Call ResolveMembers() on all
8430 TypeContainer's in the `type_container_resolve_order'.
8432 2007-03-19 Marek Safar <marek.safar@gmail.com>
8434 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8436 2007-03-17 Marek Safar <marek.safar@gmail.com>
8438 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8439 implementation flags.
8441 2007-03-17 Marek Safar <marek.safar@gmail.com>
8443 * class.cs: More optimizations for type parameters.
8445 2007-03-15 Marek Safar <marek.safar@gmail.com>
8447 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8449 * ecore.cs, parameter.cs: More common code for both corlibs.
8451 * typemanager.cs (IsGenericMethod): Simplified.
8453 2007-03-15 Raja R Harinath <rharinath@novell.com>
8455 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8457 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8459 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8460 unconditionally. Simplify explanation.
8461 (Try.Resolve, Using.Resolve): Likewise.
8463 2007-03-15 Martin Baulig <martin@ximian.com>
8467 * decl.cs (DeclSpace): If we're a partial class, use our
8468 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8470 2007-03-15 Raja R Harinath <rharinath@novell.com>
8472 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8474 (FlowBranching.UsageVector): Update to changes.
8475 (FlowBranching.MergeSiblings): Likewise.
8476 * statement.cs: Likewise.
8478 2007-03-15 Martin Baulig <martin@ximian.com>
8483 (MemberCache): Added a special .ctor for type parameters.
8486 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8489 2007-03-09 Martin Baulig <martin@ximian.com>
8491 * enum.cs (Enum): Make this a TypeContainer.
8492 (EnumMember): Derive from `Const'.
8495 (Const.DoResolveValue): New protected virtual method; move most of
8496 the functionality of ResolveValue() here so we can override it in
8498 (Const.CreateConstantReference): Make this virtual.
8500 * class.cs (Kind): Add `Kind.Enum'.
8501 (TypeContainer.Emit): Don't emit the enums here; they're already
8502 in the `RootContext.typecontainer_resolve_order'.
8504 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8505 here; they're already in the `typecontainer_resolve_order'.
8507 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8508 TypeManager.DropGenericTypeArguments().
8511 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8512 (TypeManager.IsEnumType): Likewise.
8513 (TypeManager.EnumToUnderlying): Likewise.
8514 (TypeManager.IsEqual): Add support for enums.
8516 2007-03-12 Raja R Harinath <rharinath@novell.com>
8518 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8519 DefaultParameterValueAttribute to be undefined, say if System.dll
8522 2007-03-11 Marek Safar <marek.safar@gmail.com>
8524 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8527 2007-03-10 Marek Safar <marek.safar@gmail.com>
8529 * class.cs, parameter.cs: Unified parameters verification.
8531 2007-03-08 Martin Baulig <martin@ximian.com>
8533 * cs-parser.jay (constructor_header): Pass the location to the
8534 newly created TopLevelBlock.
8536 2007-03-07 Martin Baulig <martin@ximian.com>
8538 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8540 2007-03-06 Miguel de Icaza <miguel@novell.com>
8542 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8543 with the changes from David, fixes the build.
8545 2007-03-05 David Mitchell <dmitchell@logos.com>
8547 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8548 and its base interfaces to a one-dimensional array type S[],
8549 provided there is an implicit or explicit reference conversion
8552 2007-03-03 Marek Safar <marek.safar@gmail.com>
8554 * cs-tokenizer.cs: Implemented basic linq grammar.
8556 * driver.cs: Set linq lang version on demand.
8558 2007-02-26 Marek Safar <marek.safar@gmail.com>
8560 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8562 2007-02-25 Marek Safar <marek.safar@gmail.com>
8564 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8567 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8569 Check property and event extern attributes.
8571 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8574 2007-02-24 Marek Safar <marek.safar@gmail.com>
8576 A fix for bug #80407
8577 * ecore.cs: Don't report ambiguity error when methods have same parent.
8579 2007-02-23 Marek Safar <marek.safar@gmail.com>
8581 A fix for bug #80878
8582 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8584 2007-02-22 Marek Safar <marek.safar@gmail.com>
8586 * attribute.cs: Enable ExtensionAttribute presence test.
8588 2007-02-22 Marek Safar <marek.safar@gmail.com>
8590 * class.cs: Warn about missing GetHashCode only when Equals is override.
8592 * decl.cs: Check accessibility of type arguments.
8594 * typemanager.cs: Correctly report nullable array.
8596 2007-02-20 Marek Safar <marek.safar@gmail.com>
8598 * class.cs, report.cs: Capture more details when things go wrong.
8600 2007-02-20 Marek Safar <marek.safar@gmail.com>
8602 A fix for bug #80650
8603 * cs-parser.jay: Anonymous container starts at constructor declaration
8604 and not at block beginning because it has to be usable in constructor
8607 * statement.cs: Use context location and not block one for error reporting.
8609 2007-02-18 Marek Safar <marek.safar@gmail.com>
8611 A fix for bug #78712
8612 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8615 2007-02-18 Marek Safar <marek.safar@gmail.com>
8617 A fix for bug #80493 by Atsushi Enomoto
8618 * cs-parser.jay: Ignore invalid attribute target.
8620 2007-02-18 Marek Safar <marek.safar@gmail.com>
8622 * cs-tokenizer.cs: Ignore '\0' as white space character.
8624 2007-02-17 Miguel de Icaza <miguel@novell.com>
8626 * cs-parser.jay: Add support for lambda expressions to the mcs
8629 * lambda.cs: Only clone when we are probing, not on the final call
8630 (Compatible is the final call).
8632 * statement.cs (CloneContext): Introduce class to provide block
8633 remapping during clone.
8635 All statements Clone themselves now.
8637 (Clone): special handling for blocks, when we clone a block, we
8638 register the block inside this routine, as children of the block
8639 might trigger a lookup.
8641 * expression.cs: Add support for CloneContext in all expressions.
8643 2007-02-17 Marek Safar <marek.safar@gmail.com>
8645 A fix for bug #80493
8646 * statement.cs: Report ambiguous warning when interfaces are not related.
8648 2007-02-15 Marek Safar <marek.safar@gmail.com>
8650 C# 3.0 extension methods.
8652 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8653 cannot be used directly.
8655 * class.cs (Class.Emit): Emit extension attribute if any class method
8656 is extension method.
8657 (Method.Define): Add basic extension method validation conditions.
8658 (Method.Emit): Emit extension attribute for method.
8660 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8661 extension method exists. Currently we follow same approach as Microsoft
8662 does, emit even if a method or a class are private but this can change
8665 * cs-parser.jay: Add handling of `this' keyword in method parameters
8668 * decl.cs (DeclSpace.IsStaticClass): New property.
8669 (MemberCache.FindExtensionMethods): Looks for extension methods with
8670 defined name and extension type.
8672 * doc.cs: Updated after OverloadResolve changes.
8674 * driver.cs: Add new soft reference to System.Core.dll.
8676 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8677 (ExtensionMethodGroupExpr): Represents group of extension methods.
8679 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8680 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8681 to MethodGroupExpr and made non-static for easier customization.
8682 (Invocation.DoResolve): Add extension method lookup when no standard
8684 (MemberAccess.DoResolve): Try extension methods if no member exists.
8686 * modifiers.cs: Add METHOD_EXTENSION modifier.
8688 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8689 as well as candidate extension type.
8690 (ComputeNamespaces): When assembly constains extension methods registers
8692 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8693 extension method lookup.
8694 (Namespace.LookupExtensionMethod): Looks for extension method in this
8696 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8697 find a method which matches name and extensionType.
8699 * parameter.cs (Parameter): Add This modifer.
8700 (HasExtensionMethodModifier): New property.
8701 (Resolve): Add extension parameter check.
8702 (ModFlags): turned to property to exclude this modifier as it is not real
8704 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8706 * support.cs (ParameterData): Add ExtensionMethodType.
8707 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8709 * typemanager.cs: Add type and ctor extension attribute type.
8711 2007-02-15 Miguel de Icaza <miguel@novell.com>
8713 * report.cs (DisableErrors, EnableErrors): used to prevent error
8714 output when we are "trying" to compile various methods with
8717 * ecore.cs (Expression): Add Clone method that calls the virtual
8718 CloneTo method. The current CloneTo method in Expression throws
8719 an exception so we can track down all the places where this must
8720 be implemented (not using abstract, because that would be a lot of
8721 up-front-work before we can start testing the implementation
8724 Important: we only need Clone capabilities for expressions created
8725 by the parser, as the expressions we will be cloning are
8726 expressions in the pre-resolved state. This vastly simplifies
8729 (SimpleName): Add CloneTo that does nothing.
8730 (EmptyCast): Add CloneTo.
8732 * expression.cs (Binary): Implement CloneTo.
8733 (Invocation.IsApplicable): Store the current ec in
8734 EmitContext.TempEc and restore it on return. This is used so we
8735 do not have to sprinkle hundres of methods with an extra
8736 EmitContext, we know that the only user is the lambda expression
8737 ImplicitConversionExists code.
8739 (Argument): Add Cloning capabilities.
8740 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8741 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8742 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8743 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8744 IndexerAccess): Add Clone capability.
8746 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8748 (Argument): Add cloning capability.
8750 * assign.cs (Assign): Implement CloneTo.
8752 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8754 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8755 version by calling Convert with the EmitContext (that we are
8756 currently storing in ec, this is not great, but will do for now,
8757 to avoid passing EmitContext parameters to hundreds of functions
8758 that do not need them now).
8760 (SetExpression): Remove, it is not needed.
8762 (ContextualReturn): Implement CloneTo.
8764 * statement.cs (Statement): Implement cloning infrastructure,
8765 similar to expressions.
8767 (Block): Partial implementation of Clone for statements.
8769 (Return): Implement clone.
8771 * constant.cs (Constant.CloneTo): New method, does nothing.
8773 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8774 solution, until we decide how to exactly do this.
8776 2007-02-14 Marek Safar <marek.safar@gmail.com>
8778 A fix for bug #80493
8779 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8780 a property is override we need to use second accessor.
8782 2007-02-13 Marek Safar <marek.safar@gmail.com>
8784 A fix for bug #80418
8785 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8788 2007-02-13 Marek Safar <marek.safar@gmail.com>
8790 Another fix for bug #80749
8791 * pending.cs: Abstract class has priority over interfaces.
8793 2007-02-13 Marek Safar <marek.safar@gmail.com>
8795 Another fix for bug #80749
8796 * pending.cs: Abstract class has priority over interfaces.
8798 2007-02-13 Marek Safar <marek.safar@gmail.com>
8800 Another fix for bug #80749
8801 * pending.cs: Abstract class has priority over interfaces.
8803 2007-02-13 Marek Safar <marek.safar@gmail.com>
8805 Another fix for bug #80749
8806 * pending.cs: Abstract class has priority over interfaces.
8808 2007-02-13 Marek Safar <marek.safar@gmail.com>
8810 * class.cs Better error message.
8812 * driver.cs: Add shorter versions of -optimize option.
8814 2007-02-13 Martin Baulig <martin@ximian.com>
8816 * class.cs (Constructor.Emit): Check the return value of
8817 ec.ResolveTopBlock() and return on error.
8819 2007-02-13 Raja R Harinath <rharinath@novell.com>
8821 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8822 message to fix error message regression.
8824 2007-02-12 Marek Safar <marek.safar@gmail.com>
8826 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8828 2007-02-12 Marek Safar <marek.safar@gmail.com>
8830 A fix for bug #80749
8831 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8832 its parent container.
8834 * class.cs (DefineFieldInitializers): Each initializer can has different
8837 * const.cs: Updated.
8839 2007-02-11 Miguel de Icaza <miguel@novell.com>
8841 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8842 now all the heavy lifting to check that embedded statements or
8843 expressions have the right form is done in the ContextualReturn.
8845 (ContextualReturn): New class.
8847 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8848 method that can be invoked to report 201, so we do not replicate
8851 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8853 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8854 treating tabs as spaces.
8856 2007-02-09 Marek Safar <marek.safar@gmail.com>
8858 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8859 * assign.cs: Use full implicit conversion for right side check.
8861 2007-02-09 Marek Safar <marek.safar@gmail.com>
8863 * statement.cs (Switch): Switch over boolean type is not standardized.
8865 2007-02-08 Marek Safar <marek.safar@gmail.com>
8867 A fix for bug #80755
8868 * decl.cs (FindBaseEvent): Don't use method cache for events.
8870 2007-02-07 Marek Safar <marek.safar@gmail.com>
8872 * cs-parser.jay: Better syntax error handling.
8874 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8875 instead of underlying type value.
8877 2007-02-06 Marek Safar <marek.safar@gmail.com>
8879 * driver.cs: Check define identifier before is registered.
8881 * namespace.cs: Use existing error message.
8883 * report.cs: New warning.
8885 2007-02-06 Marek Safar <marek.safar@gmail.com>
8887 A fix for bug #80742
8888 * expression.cs: Delegate Invoke method can be called directly.
8890 2007-02-06 Marek Safar <marek.safar@gmail.com>
8892 A fix for bug #80676
8893 * class.cs (IsEntryPoint): The Main method can have params modifier.
8895 2007-02-04 Miguel de Icaza <miguel@novell.com>
8897 * parameter.cs (Parameter, Parameters): Add Clone method.
8899 * anonymous.cs (Compatible): Turn method into virtual method, so
8900 LambdaExpression can implement a different behavior.
8902 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8903 out the basic checking here, so it can be used by
8906 * lambda.cs: Introduce "Compatible" function that will do the
8909 2007-02-02 Marek Safar <marek.safar@gmail.com>
8911 * attribute.cs: Unified one error message.
8913 * class.cs (Class): Use type attributes and not properties to test static
8915 (IsEntryPoint): Don's pass local variable.
8917 * convert.cs: Removed duplicate check.
8919 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8921 * driver.cs: Don't crash when soft reference does not exist.
8923 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8924 (UsingEntry): Removed redundant allocation.
8926 * parameter.cs: Add fast path for type parameters.
8928 * support.cs: Don't allocate attribute when it's not used.
8930 2007-01-30 Miguel de Icaza <miguel@novell.com>
8933 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8934 this into a virtual method, so we can override it in LambdaExpression.
8936 * driver.cs: Improve diagnostics in case of failure.
8938 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8939 write a function that is slightly more complex and that parses:
8941 type identifier [, type identifier]* )
8943 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8946 (canEmpty ? i >= 0 : i > 0)
8948 2007-01-30 Raja R Harinath <rharinath@novell.com>
8950 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8951 exception on possibly valid code.
8953 2007-01-29 Raja R Harinath <rharinath@novell.com>
8955 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8957 (parse_opt_type_arguments): Remove. It's almost the same as
8959 (parse_namespace_or_typename): Use parse_less_than.
8961 2007-01-28 Miguel de Icaza <miguel@novell.com>
8963 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8964 this bug took a few hours to find, because the state saved and
8965 restored by PushPosition and PopPosition was ignoring the state of
8966 parse_generic_less_than.
8968 I can also now remove the handling of OP_LT and OP_GT, this solves
8971 * cs-tokenizer.cs: store the location for the ARROW token, we use
8974 (PushPosition, PopPosition): save/restore also `current_token',
8975 restore `parse_generic_less_than' (was missing).
8977 (parse_opt_type_arguments): use parse_type, not
8978 parse_namespace_or_typename to parse types.
8980 * lambda.cs: Empty new file, will eventually have the lambda
8981 expression implementation.
8983 * lambda.test: used to test the internal tokenizer.
8985 * report.cs (FeatureIsNotISO1): Rename from
8986 FeatureIsNotStandardized, because it was about the language level
8987 (1 vs 2) it was not about standarization.
8989 (FeatureRequiresLINQ): New.
8991 * support.cs (SeekableStreamReader): Only require that the reader
8992 is a TextReader, not a StreamReader, so we can plug StringReader.
8994 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8995 given position in the input stream the following tokens can be
8996 parsed as a type followed by an identifier.
8998 (is_punct): after a '(' if parse_type_and_parameter returns true,
8999 then return a special token OPEN_PARENS_LAMBDA which is used to
9000 avoid reduce/reduce errors in the grammar for the
9001 lambda_expression rules.
9003 (parse_type): implement a type parser inside the
9004 tokenizer, the parser only returns true or false depending on
9005 whether the input at a given position can be parsed as a type.
9007 (peek_token): new method used during type parsing.
9009 2007-01-28 Raja R Harinath <rharinath@novell.com>
9012 * anonymous.cs (ScopeInfo.InflateParameters): New.
9013 (AnonymousContainer.Resolve): Use it to redirect types of
9014 delegate parameters.
9016 2007-01-27 Raja R Harinath <rharinath@novell.com>
9019 * expression.cs (Error_InvalidArguments): Don't use two different
9020 messages for CS1503. Use ExtraInformation and
9021 SymbolRelatedToPreviousError instead.
9024 * decl.cs (DeclSpace.initialize_type_params): Don't access
9025 'type_params' of a partial class directly.
9027 2007-01-26 Miguel de Icaza <miguel@novell.com>
9029 * constant.cs: Removed a handful of out-of-range checks that were
9032 2007-01-25 Marek Safar <marek.safar@gmail.com>
9034 * expression.cs (CheckUselessComparison): Add additional check for char
9037 * namespace.cs: Fixed typo.
9039 2007-01-23 Miguel de Icaza <miguel@novell.com>
9041 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
9042 gone, instead we inline the test, preventing the needless casts to
9043 longs, ulongs and doubles for the parameters, avoiding calls to
9044 methods that overchecked stuff, and instead inlined things
9047 2007-01-20 Marek Safar <marek.safar@gmail.com>
9049 * cs-parser.jay: Better parameter error handling.
9051 2007-01-17 Marek Safar <marek.safar@gmail.com>
9053 A fix for bug #80368, #80522
9054 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
9055 whether array initializer contains constants only.
9056 (ArrayCreation.Emit): Use better formula to decide when
9057 are array initializers for static initialization.
9058 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
9059 have to emit even constants otherwise they are pre-initialized.
9061 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
9062 Raja R Harinath <rharinath@novell.com>
9064 Fix emit order of 'get' vs. 'set'.
9065 * support.cs (Accessors): New.
9066 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
9067 Note the order in which accessors are declared in the source.
9068 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
9069 Refactored from Property.Define and Indexer.Define.
9070 (PropertyBase.DefineAccessors): New helper that calls the above in
9071 appropriate order as noted by the parser.
9072 (Property.Define, Indexer.Define): Update to changes.
9073 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
9075 2007-01-17 Raja R Harinath <rharinath@novell.com>
9077 Fix cs0029-6.cs and gcs0029-2.cs (regression)
9078 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
9079 there's an implicit conversion from the current type to the target
9080 type before converting the underlying constant.
9082 2007-01-16 Marek Safar <marek.safar@gmail.com>
9084 * const.cs (ResolveValue): Updated after constant conversion was made more
9087 * constant.cs (GetAttributableValue): constant to object conversion is
9088 used for attributes only.
9089 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
9090 constant conversions.
9091 (LongConstant.ConvertImplicitly): Ditto.
9093 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
9094 (ImplicitConversionStandard): Handle constant conversion as extra step.
9095 It solves the issue when constant conversion was called indirectly like
9096 inside array initializer and constant folding was skipped.
9098 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
9101 * statement.cs(ImplicitConversionStandard): Updated after constant
9102 conversion was made more generic.
9104 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
9106 * expression.cs (As.DoResolve): Use GenericConstraints instead of
9107 Constraints, solves the problem where the compiler incorrectly
9108 reported that a type parameter was not constrained to a class (Bug
9111 2007-01-14 Marek Habersack <grendello@gmail.com>
9113 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
9115 2007-01-14 Marek Safar <marek.safar@gmail.com>
9117 A fix for bug #80368
9118 * assign.cs (FieldInitializer): New class implements field
9119 initializer statement.
9121 * attribute.cs: Update after FieldMember rename.
9123 * class.cs (PropertyBasedMember): New common class for property based
9125 (InterfaceMemberBase): New base class for all members which can be used as
9126 an interface members.
9127 (MethodCore): Moved really common code to InterfaceMemberBase.
9128 (Method.Define): Equal and GetHasCode detection is relevant for methods
9130 (MethodData.Define): Don't assume that public event implements an
9131 interface automatically.
9132 (MethodData.DefineMethodBuilder): Issue an error even if only extern
9134 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
9135 (FieldMember): Merged with FieldBase.
9136 (EventProperty.AEventPropertyAccessor): New specialization to check whether
9137 event extern modifier can be used.
9138 (EventField.EventFieldAccessor): Moved event field specific code here.
9139 (Event.AllowedModifiers): Even event can be extern.
9140 (Event.FindOutBaseMethod): New override specific to events.
9141 (Indexer.parameters): Reintroduce parameters because base class holds
9142 only properties common data.
9143 (Indexer.CheckForDuplications): Indexers are threated as methods so we
9144 need do extra parameters check.
9146 * const.cs: Update after FieldMember rename.
9148 * decl.cs (MemberCache.FindBaseEvent): New method.
9150 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
9151 to reflect that indexer is now derived from PropertyBased.
9153 * ecore.cs (GetMemberType): Made public.
9154 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
9157 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
9159 * typemanager.cs (CSharpSignature): Correctly print event accessors.
9160 (RegisterEvent): Removed.
9161 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
9162 (GetPrivateFieldOfEvent): Renamed to GetEventField.
9164 2007-01-11 Raja R Harinath <rharinath@novell.com>
9167 * statement.cs (CollectionForeach.TryType): Prefer generic
9168 GetEnumerator over non-generic variant. Fix code to follow comments.
9170 2007-01-09 Raja R Harinath <rharinath@novell.com>
9173 * support.cs (ReflectionParameter): Don't use an invalid index on
9174 the generic parameter data.
9176 2007-01-08 Miguel de Icaza <miguel@novell.com>
9178 * driver.cs: Just add a tiny bit of infrastructure.
9180 2007-01-02 Marek Safar <marek.safar@gmail.com>
9182 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
9183 where field type is struct from current assembly.
9185 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
9188 2007-01-02 Marek Safar <marek.safar@gmail.com>
9190 A fix for bug #80381
9191 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
9194 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
9196 (Namespace.LookupType): Always use core types from corlib when speficied.
9198 * report.cs: A new warning.
9200 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
9201 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
9202 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
9204 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
9205 (InitCoreTypes): Set expression type of object_type and value_type
9206 immediately after lookup.
9208 2007-01-01 Miguel de Icaza <miguel@novell.com>
9210 * cs-tokenizer.cs: Accept Pc class characters (Connector
9211 Punctuation) as valid identifiers. Fixes #78259
9213 * expression.cs (Invocation.DoResolve): Moved the check for the
9214 use of `this' for doing method calls to the Invocation resolution
9215 step, after overload resolution has taken place instead of doing
9216 the check at the low-level `This.DoResolve' level.
9218 The `This.DoResolve'(appens before overload resolution, so it has
9219 no way of knowing if the method that will be called will be
9220 instace or static, triggering an erroneous report for cs0188 (Bug
9223 We now do the check for instance method invocations after we know
9224 what method will be called.
9226 (This.CheckThisUsage): Move the actual use of this structure
9227 checking into its own method and expose it.
9229 * Everywhere that called Error_ValueCannotBeConverted: pass a new
9232 Exceptions: Null.ConvertImplicitly,
9233 Constant.ImplicitConversionRequired as there are too many call
9234 sites for passing the ec.
9236 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
9237 EmitContext, if the value is null, then we do not try to provide
9238 the extra information from the error (If a userdefined conversion
9239 exists, as UserDefinedConversion requires a non null-EmitContext).
9243 2006-12-30 Raja R Harinath <rharinath@novell.com>
9245 * flowanalysis.cs (MyBitVector): Document some invariants.
9246 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
9247 introduced below, and add a couple of others,
9249 2006-12-30 Marek Safar <marek.safar@gmail.com>
9251 * attribute.cs (GetMethodObsoleteAttribute): Uses new
9252 GetPropertyFromAccessor and GetEventFromAccessor.
9254 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
9255 overrides non-obsolete one.
9256 (Indexer.Define): Error message has been moved to the parser.
9258 * cs-parser.jay: Better syntax errors handling.
9260 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9261 when an invocation has no arguments.
9263 * ecore.cs: Removed not used caching.
9265 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9268 * report.cs: Add a new warning.
9270 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9272 * typemanager.cs (enumeration_type): Removed.
9273 (CSharpSignature): Reuses IsSpecialMethod.
9274 (IsEqual): Hack for MS BCL.
9275 (GetPropertyFromAccessor): New method.
9276 (GetEventFromAccessor): New method.
9277 (IsSpecialMethod): Fixed to handle more cases.
9279 2006-12-30 Marek Safar <marek.safar@gmail.com>
9281 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9282 Made white spaces array static.
9284 * ecore.cs (RemoveGenericArity): Optimized.
9286 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9288 (MyBitVector.initialize_vector): Simplified.
9290 2006-12-22 Miguel de Icaza <miguel@novell.com>
9292 * ecore.cs: Am not entirely happy with this hack, but it seems to
9293 address the issue in 80257 (a small test case for
9296 I set the MethodGroupExpr.Type to an internal compiler type
9297 (itself in this case) to force the resolution to take place. Why
9298 it does not take place with a null is beyond me.
9300 2006-12-20 Marek Safar <marek.safar@gmail.com>
9302 A fix for bug #80288
9303 * expression.cs (ResolveOperator): Consider user defined conversion for
9304 logical and operator too.
9305 (EmitBranchable): Optimization for logical and when full constant folding
9306 could not be applied but one operand is constant.
9308 2006-12-19 Marek Safar <marek.safar@gmail.com>
9310 * class.cs (GetClassBases): Write 5 times every day, will never use
9311 FullName for error reporting.
9313 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9315 2006-12-19 Martin Baulig <martin@ximian.com>
9317 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9318 the symbol file info here.
9320 2006-12-18 Marek Safar <marek.safar@gmail.com>
9322 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9323 of `elseif' is taking then following sections are not taking.
9324 Fixes an issue reported on mono mailing list.
9326 2006-12-18 Marek Safar <marek.safar@gmail.com>
9328 A fix for bug #80300
9329 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9330 a caller is not taking.
9332 2006-12-18 Raja R Harinath <rharinath@novell.com>
9334 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9335 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9336 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9337 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9338 * class.cs: Update to changes.
9340 2006-12-17 Marek Safar <marek.safar@gmail.com>
9342 A fix for bug #79934
9343 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9346 * class.cs (ResolveMembers): Register an iterator in current container and
9349 2006-12-16 Raja R Harinath <rharinath@novell.com>
9352 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9353 satisfy a params annotated parameter.
9355 2006-12-16 Marek Safar <marek.safar@gmail.com>
9357 A fix for bug #77014
9358 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9359 paramters correctly and not rely on hacks in Parameters class.
9360 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9362 (Invocation.VerifyArgumentsCompat): Ditto.
9363 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9366 * parameter.cs (HasParams): Don't assume that params is the last one.
9368 * support.cs (ReflectionParameters.ctor): Look for params attribute
9370 (ReflectionParameters.ParameterType): Removed hack when we returned last
9371 parameter for out of range parameters.
9372 (ParameterName, ParameterModifier): Ditto.
9374 2006-12-14 Marek Safar <marek.safar@gmail.com>
9376 A fix for bug #79987
9377 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9378 when assembly is not CLS compliant but type is. I have no idea why is this
9381 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9383 2006-12-13 Miguel de Icaza <miguel@novell.com>
9385 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9386 in struct constructors, they are basically no-ops.
9388 2006-12-12 Marek Safar <marek.safar@gmail.com>
9390 * cs-tokenizer.cs (Position): Save preprocessor status too.
9392 2006-12-12 Marek Safar <marek.safar@gmail.com>
9394 A fix for bug #77794
9395 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9397 2006-12-12 Marek Safar <marek.safar@gmail.com>
9399 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9401 (pp_expr): Report error for an invalid expression.
9402 (handle_preprocessing_directive): Simplified; add more error checking.
9404 2006-12-11 Marek Safar <marek.safar@gmail.com>
9406 A fix for bug #74939
9407 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9408 directives handling.
9410 2006-12-10 Marek Safar <marek.safar@gmail.com>
9412 A fix for bugs #80093, and #75984
9413 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9414 logic, it seems to me as it worked before "by coincidence".
9415 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9416 (cleanup): Enabled endif check.
9418 2006-12-09 Marek Safar <marek.safar@gmail.com>
9420 A fix for bug #80162
9421 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9422 enumerators are never ambiguous.
9424 2006-12-08 Raja R Harinath <rharinath@novell.com>
9427 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9429 2006-12-06 Marek Safar <marek.safar@gmail.com>
9431 A fix for bug #80144
9432 * class.cs (EventProperty.Define): Explicit implementation means
9433 that an even is used.
9435 2006-12-06 Marek Safar <marek.safar@gmail.com>
9437 Fixes the operators implementation (part II)
9439 * cfold.cs (DoConstantNumericPromotions): Renamed to
9440 DoBinaryNumericPromotions and simplified.
9441 (BinaryFold): Couple of conversion fixes; simplified.
9443 * constant.cs, ecore.cs, literal.cs
9444 (ToType): Renamed to ConvertImplicitly.
9445 (Reduce): Renamed to ConvertExplicitly.
9447 * class.cs, convert.cs: Updated.
9449 * expression.cs: TryReduce doesn't throw an exception.
9451 2006-12-01 Marek Safar <marek.safar@gmail.com>
9453 A fix for bug #80108
9454 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9457 2006-11-30 Marek Safar <marek.safar@gmail.com>
9459 Fixes unary operators implementation (part I)
9462 * cfold.cs (Error_CompileTimeOverflow): Made internal
9464 * const.cs (IConstant): Changed to use reference to constant and
9465 not constant itself.
9466 Updated IConstant implementations.
9468 * constant.cs (CreateConstant): New factory method.
9469 Updated IConstant implementation.
9471 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9473 * ecore.cs: Updated to use CreateConstantReference.
9475 * enum.cs: Reflects IConstant changes.
9477 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9479 * literal.cs (NullConstant): Change to be independently usable.
9481 2006-11-29 Martin Baulig <martin@ximian.com>
9483 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9484 we need to emit the scope initializer before calling the base .ctor.
9486 * anonymous.cs: Merged back from the new anonymous methods branch.
9487 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9489 * expression.cs (ParameterReference.DoResolveBase): Create a
9490 "normal" ScopeInfo when capturing parameters rather than using the
9491 root scope; this makes things work with anonymous methods having
9495 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9497 2006-11-22 Marek Safar <marek.safar@gmail.com>
9499 A fix for bug #79987
9500 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9501 check to a base class.
9502 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9503 only when assembly has missing attribute.
9504 * report.cs: Update.
9506 2006-11-21 Marek Safar <marek.safar@gmail.com>
9508 * cs-tokenizer.cs: Merged with gmcs version.
9510 2006-11-20 Marek Safar <marek.safar@gmail.com>
9513 * cs-parser.jay: Better error message when partial keyword is misplaced.
9515 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9517 A fix for bug #79810
9518 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9519 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9520 a RuntimeWrappedException by default.
9522 2006-11-18 Marek Safar <marek.safar@gmail.com>
9524 A fix for bug #79843
9525 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9527 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9529 2006-11-18 Marek Safar <marek.safar@gmail.com>
9531 * driver.cs, namespace.cs: Uses faster IndexOf version.
9533 2006-11-17 Marek Safar <marek.safar@gmail.com>
9535 A fix for bug #79941
9536 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9538 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9539 even if internal name is different.
9540 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9541 (UserDefinedConversion): Simplified as the operators cannot be internal.
9542 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9544 (MethodLookup): Replaced EmitContext with parentType.
9545 * expression.cs: Updated.
9547 2006-11-09 Raja R Harinath <rharinath@novell.com>
9549 * driver.cs (BadAssembly): Handle all the ugliness of
9550 DefineDynamicAssembly.
9552 2006-11-08 Raja R Harinath <rharinath@novell.com>
9554 Address parts of #58244 -- most of what's left is in the runtime
9555 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9556 CS1509 error checks, and handle them for all assembly loads, not
9557 just the first invocation.
9558 (LoadModule): Likewise. Move handling of 'adder_method' ...
9559 * codegen.cs (AssemblyClass.AddModule): ... here.
9561 2006-11-02 Marek Safar <marek.safar@gmail.com>
9563 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9564 IEnumerable<T> is ambiguous.
9566 2006-10-31 Marek Safar <marek.safar@gmail.com>
9568 A fix for bug #67689
9569 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9570 GetEnumerator is ambiguous.
9572 * report.cs: Add new warning.
9574 2006-10-29 Marek Safar <marek.safar@gmail.com>
9576 A fix for bug #78602
9577 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9578 to protected member can be nested type.
9580 2006-10-28 Marek Safar <marek.safar@gmail.com>
9582 A fix for bug #78965
9583 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9584 to protected member must derive from current type.
9586 2006-10-27 Marek Safar <marek.safar@gmail.com>
9588 assign.cs: Reuses error method.
9590 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9591 instead of type for constants.
9592 (Expression.Error_ValueAssignment): Common error method.
9594 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9597 2006-10-27 Marek Safar <marek.safar@gmail.com>
9599 A fix for bug #79081
9600 * expression.cs (MemberAccess.DoResolve): Check nested type
9603 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9605 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9607 2006-10-26 Marek Safar <marek.safar@gmail.com>
9609 A fix for bug #76591
9610 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9612 2006-10-26 Marek Safar <marek.safar@gmail.com>
9614 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9615 type forwarder of the same type multiple times.
9617 2006-10-26 Raja R Harinath <rharinath@novell.com>
9620 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9621 instance as an rvalue, even when we later resolve as an lvalue.
9623 2006-10-25 Martin Baulig <martin@ximian.com>
9625 * anonymous.cs: Fix #79673.
9627 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9629 A fix for bug #79666
9630 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9631 ignored when is optimized (= default value) as its value is already set.
9633 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9635 A fix for bug #79724
9636 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9637 TypeContainer for type lookup.
9639 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9641 A fix for bug #79231
9642 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9643 * expression.cs (OverloadResolve): Always convert type name for
9645 (ResolveNamespaceOrType): Don't confuse a nested type with any
9648 2006-10-18 Martin Baulig <martin@ximian.com>
9650 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9652 2006-10-17 Miguel de Icaza <miguel@novell.com>
9654 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9655 an int32, but requesting an int64 from the conversion
9657 2006-10-12 Martin Baulig <martin@ximian.com>
9660 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9662 2006-10-12 Martin Baulig <martin@ximian.com>
9665 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9667 2006-10-11 Miguel de Icaza <miguel@novell.com>
9669 * convert.cs: Remove broken code: I was doing the "Existance"
9670 tests for Implicit conversions.
9672 2006-10-10 Miguel de Icaza <miguel@novell.com>
9674 * convert.cs: Added one missing case in
9675 ImplicitStandardConversionExists uint64 to intptr.
9679 * typemanager.cs (uintptr_type): another core known type.
9681 * ecore.cs (OperatorCast): routine used to do cast operations that
9682 depend on op_Explicit. We could change some of the Decimal
9683 conversions to use this.
9685 This one has a probe mechanism that checks both types for an op_
9686 which it coudl be used to eliminate two classes: CastToDecimal
9687 and CastFromDecimal.
9689 * convert.cs: Implement the conversions documented in #59800
9691 2006-10-10 Martin Baulig <martin@ximian.com>
9693 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9694 before RootScope.ResolveMembers().
9696 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9697 `CurrentType' if appropriate.
9699 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9701 A fix for bug #78568
9702 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9703 when contains binary operators.
9704 * cs-parser.jay: Updated.
9706 2006-10-09 Martin Baulig <martin@ximian.com>
9709 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9710 moved that into Define() and also do the other type parameter
9711 checks there. Fixes #79094. Added gtest-292.cs.
9714 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9715 since that doesn't include type parameters; don't use `Ldelema'
9716 for type parameters. Fixes #78980. Added gtest-293.cs.
9718 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9721 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9722 conversion is allowed.
9724 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9726 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9727 error reporting when no error occurs.
9729 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9731 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9734 2006-10-06 Raja R Harinath <rharinath@novell.com>
9737 * class.cs (DefineTypeBuilder): Check circular dependencies before
9738 setting the parent of the TypeBuilder.
9739 (CheckRecursiveDefinition): Don't use 'BaseType', since
9740 it may not be valid until after DefineTypeBuilder. Use
9741 'base_type' instead.
9743 2006-10-04 Martin Baulig <martin@ximian.com>
9745 Merged the Anonymous Methods patch.
9747 * anonymous.cs, iterators.cs: The new anonymous methods code.
9749 * statement.cs (Variable): New public abstract class.
9750 (LocalInfo.Variable): New public property.
9751 (LocalInfo.ResolveVariable): New public method.
9752 (Block.Flags): Add `IsIterator'.
9753 (Block.AddVariable): Improved the CS0136 check.
9754 (Block.AnonymousChildren): New public property.
9755 (Block.AddAnonymousChild): New public method.
9756 (ToplevelBlock): Update to use the new anonymous method framework.
9757 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9758 `ToplevelBlock'; this is required to correctly implement the
9760 (Fixed, Using): Use `TemporaryVariable' instead of directly
9761 creating the `LocalBuilder'.
9763 * parameter.cs (Parameter.ResolveVariable): New public method.
9764 (Parameters.ResolveVariable): Likewise.
9766 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9768 * class.cs (TypeContainer): Replaced the `iterators' list and
9769 corresponding methods with a list of `CompilerGeneratedClass'es.
9770 (TypeContainer.ResolveMembers): New public method.
9771 (Method): `IIteratorContainer' has been replaced by
9774 * expression.cs (VariableReference): New public abstract base
9775 class for `LocalVariableReference', `ParameterReference' and
9778 * codegen.cs (EmitContext): Removed `capture_context',
9779 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9780 (EmitContext.EmitThis): Removed.
9782 * cs-parser.jay: Replace `iterator_container' with
9785 2006-10-04 Martin Baulig <martin@ximian.com>
9787 * generic.cs (GenericMethod): Don't make this abstract.
9788 (Constraints.Clone): Added dummy implementation.
9790 2006-10-04 Raja R Harinath <harinath@gmail.com>
9793 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9794 'declspaces'. Avoid allocating arrays willy-nilly.
9797 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9798 cases out of the switch.
9800 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9802 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9803 message when non-generic type is used with the type arguments.
9804 * expression.cs: Updated.
9806 2006-09-28 Raja R Harinath <rharinath@novell.com>
9809 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9810 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9811 Change semantics slightly. Don't insist on having only one
9812 temporary EmptyExpression -- just throttle the creation of new ones.
9815 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9816 non-interfaces too. If no methods are found, don't try to create
9819 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9821 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9824 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9825 us produce better error message.
9827 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9829 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9830 of the `|' operator.
9832 * report.cs: A new warning added.
9834 2006-09-27 Martin Baulig <martin@ximian.com>
9836 * generic.cs (GenericMethod): Don't make this abstract.
9838 2006-09-27 Martin Baulig <martin@ximian.com>
9841 (InternalErrorException): Added overloaded ctor taking a params array.
9843 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9845 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9846 Fixed the cases when same error was reported twice.
9848 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9849 now report symbol information.
9851 2006-09-25 Martin Baulig <martin@ximian.com>
9853 * class.cs: Completely unified with the gmcs version.
9855 2006-09-25 Martin Baulig <martin@ximian.com>
9857 * typemanager.cs (TypeManager.IsNullableType): New public function.
9858 (TypeManager.IsNullableTypeOf): Likewise.
9859 (TypeManager.IsNullableValueType): Likewise.
9861 * class.cs (MethodCore): Added the `GenericMethod' argument from
9862 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9864 2006-09-24 Raja R Harinath <harinath@gmail.com>
9866 * convert.cs: Unify with gmcs version.
9868 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9870 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9871 verify them as well.
9873 * report.cs: New warning.
9875 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9877 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9878 for anonymous block with out argument.
9880 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9882 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9883 not used private events only.
9885 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9887 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9889 * const.cs (Const.Define): Check for constant type.
9890 (Const.IsConstantTypeValid): Looks for valid constant types.
9892 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9894 * ecore.cs (EmptyConstantCast): New common class for all constant based
9897 * expression.cs (Is.DoResolve): Handle null constant especially.
9898 (New.DoResolve): Check for new void().
9899 (MemberAccess.DoResolve): Cope with all kind of nulls.
9901 * literal.cs (NullConstant): Uses EmptyConstantCast.
9902 (NullDefault): Based on EmptyConstantCast.
9903 (NullLiteral): Uses EmptyConstantCast.
9905 * statement.cs (Block.ResolveMeta): Check for constant type.
9907 2006-09-22 Martin Baulig <martin@ximian.com>
9909 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9911 2006-09-22 Raja R Harinath <rharinath@novell.com>
9913 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9917 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9918 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9921 2006-09-22 Martin Baulig <martin@ximian.com>
9923 * ecore.cs: Merged with the gmcs version.
9925 * generic.cs (ConstructedType): New dummy class.
9926 (TypeArguments): Don't make this abstract.
9929 (TypeManager.IsGenericTypeDefinition): New method.
9930 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9932 2006-09-22 Raja R Harinath <rharinath@novell.com>
9934 * expression.cs (ComposedCast): Check for arrays of TypedReference
9935 before creating the type, not after.
9937 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9939 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9940 after ToType change.
9942 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9943 when constant must be implicitly convertible.
9945 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9947 * ecore.cs (NullCast): Derives from NullConstant.
9949 * expression.cs (Is.DoResolve): Removed useless variables.
9950 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9951 (New.Constantify): Add enum support.
9952 (MemberAccess.DoResolve): Add warning when accessing null constant or
9955 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9958 * literal.cs (NullConstant): New abstract class with common
9959 functionality for all null specializations.
9960 (NullDefault): Represents default(X) when result can be
9962 (NullLiteral): Updated.
9964 * report.cs: Add new warning.
9966 2006-09-21 Martin Baulig <martin@ximian.com>
9968 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9970 2006-09-21 Martin Baulig <martin@ximian.com>
9972 * generic.cs (GenericConstraints): New dummy class.
9973 (Constraints): Likewise.
9974 (TypeParameter): Likewise.
9975 (TypeParameterName): Likewise.
9976 (GenericMethod): Likewise.
9978 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9980 * decl.cs: Merged with the gmcs version.
9982 2006-09-21 Raja R Harinath <rharinath@novell.com>
9984 * generic.cs (TypeParameter): Implement IMemberContainer.
9985 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9987 * rootcontext.cs: Unify with gmcs version.
9989 * report.cs: Unify with gmcs version.
9990 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9991 from gmcs/generics.cs.
9992 * generics.cs (TypeParameter): New dummy class.
9994 * support.cs: Unify with gmcs version.
9996 2006-09-20 Raja R Harinath <rharinath@novell.com>
9998 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9999 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
10001 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
10002 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
10003 * mcs.exe.sources: Add generic.cs.
10005 * codegen.cs: Unify with gmcs version.
10007 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
10008 (EmitContext): Add GenericDeclContainer implementation.
10009 * decl.cs (MemberCore, DeclSpace): Likewise.
10010 * namespace.cs: Remove #ifdef GMCS_SOURCE.
10012 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
10013 MCS TypeManager has a corresponding dummy method.
10015 2006-09-19 Martin Baulig <martin@ximian.com>
10017 * expression.cs: Completely merged with the gmcs version.
10019 2006-09-19 Martin Baulig <martin@ximian.com>
10021 * expression.cs (Invocation): Merged with the gmcs version.
10022 (ArrayAccess.GetStoreOpcode): Likewise.
10024 2006-09-19 Martin Baulig <martin@ximian.com>
10027 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
10028 (TypeManager.IsGenericMethodDefinition): Likewise.
10030 2006-09-19 Martin Baulig <martin@ximian.com>
10033 (TypeManager.IsEqual): Moved the gmcs implementation here.
10034 (TypeManager.DropGenericTypeArguments): Likewise.
10035 (TypeManager.DropGenericMethodArguments): Likewise.
10036 (TypeManager.GetTypeArguments): Moved here from gmcs.
10037 (TypeManager.HasGenericArguments): Likewise.
10039 2006-09-19 Martin Baulig <martin@ximian.com>
10041 * expression.cs (Binary): Merged with the gmcs version.
10043 2006-09-19 Martin Baulig <martin@ximian.com>
10045 * expression.cs (Probe, As, Is): Merged with the gmcs version.
10047 2006-09-19 Martin Baulig <martin@ximian.com>
10049 * typemanager.cs: Merged with the gmcs version.
10051 2006-09-16 Raja R Harinath <rharinath@novell.com>
10053 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
10054 * driver.cs: Likewise.
10056 2006-09-16 Marek Safar <marek.safar@seznam.cz>
10059 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
10060 only if parent type is class.
10061 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
10064 2006-09-15 Marek Safar <marek.safar@seznam.cz>
10067 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
10069 * typemanager.cs(CSharpName): Converts NullType to null.
10071 2006-09-15 Martin Baulig <martin@ximian.com>
10074 (TypeManager.GetMethodName): Added mcs implementation.
10075 (TypeManager.IsEqual): Likewise.
10078 (SimpleName.RemoveGenericArity): Added dummy implementation.
10080 * pending.cs: Merged with the gmcs version.
10082 2006-09-15 Martin Baulig <martin@ximian.com>
10084 * statement.cs: Merge with the gmcs version.
10086 2006-09-15 Martin Baulig <martin@ximian.com>
10088 * statement.cs (Switch): Merge with the gmcs implementation
10089 (without nullables), which is newer.
10091 2006-09-15 Martin Baulig <martin@ximian.com>
10093 * statement.cs (Block.Variables): Make this public.
10094 (ToplevelBlock.Parameters): Make this a property.
10095 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
10097 2006-09-15 Martin Baulig <martin@ximian.com>
10099 * namespace.cs: Merge with the gmcs version.
10101 2006-09-15 Martin Baulig <martin@ximian.com>
10103 * decl.cs (MemberName): Minor code cleanups.
10105 2006-09-15 Martin Baulig <martin@ximian.com>
10107 * parameter.cs: Merge with the gmcs version.
10109 2006-09-15 Martin Baulig <martin@ximian.com>
10111 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
10112 and an error in mcs.
10114 2006-09-15 Martin Baulig <martin@ximian.com>
10116 * flowanalysis.cs: Merged from GMCS; added the generics code into
10117 a `GMCS_SOURCE' conditional so we can share this file.
10119 2006-09-08 Martin Baulig <martin@ximian.com>
10121 * typemanager.cs (TypeManager.interlocked_type): New public field.
10122 (TypeManager.int_interlocked_compare-exchange): New public field.
10123 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
10124 enumerator types here and call InitGenericCoreTypes().
10125 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
10126 after calling InitEnumUnderlyingTypes().
10129 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
10130 `classes_second_stage'.
10132 2006-09-14 Marek Safar <marek.safar@seznam.cz>
10134 * assign.cs, ecore.cs, expression.cs: Share error message text.
10135 * class.cs (FieldMember.Define): Check for varible of static type.
10136 * driver.cs (LoadAssembly): Uses error output for errors.
10137 * statement.cs: Updated.
10139 2006-09-08 Marek Safar <marek.safar@seznam.cz>
10141 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
10144 2006-09-07 Martin Baulig <martin@ximian.com>
10147 (MainDriver): Revert r62663 from Marek; see #70506 for details.
10149 2006-08-29 Miguel de Icaza <miguel@novell.com>
10151 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
10153 2006-08-17 Miguel de Icaza <miguel@novell.com>
10155 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
10156 #52019 and #79064, the use of the \uXXXX sequence in source code
10157 to represent unicode characters.
10159 2006-08-15 Marek Safar <marek.safar@seznam.cz>
10161 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
10163 * class.cs, ecore.cs, statement.cs: Merged to one error message.
10165 2006-08-13 Miguel de Icaza <miguel@novell.com>
10167 * assign.cs: Catch attempts to assign to a method groups in += and
10170 2006-08-13 Marek Safar <marek.safar@seznam.cz>
10173 * cs-parser.jay: Don't destroy current array type by typeof of array's.
10175 2006-08-12 Marek Safar <marek.safar@seznam.cz>
10177 * class.cs (Method.Define): Issue a warning when generic method looks like
10179 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
10182 2006-08-09 Marek Safar <marek.safar@seznam.cz>
10184 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
10186 * decl.cs (MemberCache.FindMembers): When container is interface we need to
10187 search all base interfaces as a member can be ambiguous.
10188 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
10189 Constructor member type filter.
10190 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
10191 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
10192 reporting for returned memberinfos.
10193 * report.cs: Updated.
10194 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
10195 version to work on all runtimes.
10196 (TypeManager.RealMemberLookup): Removed members filtering.
10198 2006-08-08 Raja R Harinath <rharinath@novell.com>
10200 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
10201 (PropertyExpr.EmitAssign): Likewise.
10202 * expression.cs (Indirection.EmitAssign): Likewise.
10203 (LocalVariableReference.EmitAssign): Likewise.
10204 (ParameterReference.EmitAssign): Likewise.
10205 (Invocation.EmitArguments): Likewise.
10206 (ArrayAccess.EmitAssign): Likewise.
10207 (IndexerAccess.EmitAssign): Likewise.
10208 (This.EmitAssign): Likewise.
10209 (ConditionalLogicalOperator.Emit): Likewise.
10212 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
10213 instead of ArrayList. If the hashtable has a LocalBuilder, don't
10214 leave it in after returning it.
10215 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
10217 2006-08-06 Marek Safar <marek.safar@seznam.cz>
10219 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
10222 2006-08-03 Raja R Harinath <rharinath@novell.com>
10224 Fix cs0146-3.cs and cs0146-4.cs.
10225 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
10226 enclosing types don't depend on the current type.
10228 2006-08-02 Raja R Harinath <rharinath@novell.com>
10231 * class.cs (TypeContainer.DoDefineMembers): Use
10232 FindBaseMemberWithSameName on Parent, since we're interested in
10233 whether we hide inherited members or not.
10234 (FindBaseMemberWithSameName): Make slightly more robust.
10236 Fix the non-generic testcase from #77396
10237 * decl.cs (DeclSpace.DeclContainer): Remove override.
10239 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
10240 declspaces for doppelgangers too.
10241 (UsingEntry): Implement IResolveContext.
10242 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
10243 'this' as the resolve context.
10244 (LocalAliasEntry): Likewise.
10246 Implement parts of #77403
10247 * roottypes.cs (RootDeclSpace): New. Used to represent the
10248 toplevel declaration space. Each namespace declaration introduces
10249 a "partial" root declaretion space.
10250 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
10251 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
10252 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
10253 from 'current_namespace.SlaveDeclSpace'.
10254 (namespace_declaration): Likewise.
10255 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10256 check. It can't happen now.
10257 * decl.cs (DeclSpace.LookupType): Likewise.
10258 * driver.cs (MainDriver): Sanity check.
10260 2006-08-01 Raja R Harinath <rharinath@novell.com>
10262 * decl.cs (DeclSpace.FindNestedType): Remove.
10263 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10264 LookupTypeContainer to get the container of the nested type.
10265 * class.cs (TypeContainer.FindNestedType): Make non-override.
10267 2006-07-31 Raja R Harinath <rharinath@novell.com>
10269 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10270 * class.cs (TypeContainer.PartialContainer): ... here.
10271 (TypeContainer.AddBasesForPart): New helper.
10272 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10274 * cs-parser.jay (current_class): Convert to DeclSpace.
10275 (struct_declaration, interface_declaration, class_declaration):
10276 Use AddBasesForPart instead of .Bases directly.
10277 * const.cs, iterators.cs: Update to changes.
10279 2006-07-28 Raja R Harinath <rharinath@novell.com>
10281 * class.cs (TypeContainer.AddMemberType): Rename from
10282 AddToTypeContainer.
10283 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10284 (AddTypeContainer): New. Combine AddClassOrStruct and
10286 (AddPartial): Update. Add 'is_partial' argument.
10287 * roottypes.cs: Update to changes.
10288 * cs-parser.jay (push_current_class): New helper for handling
10289 current_container and current_class.
10290 (struct_declaration, interface_declaration, class_declaration):
10293 2006-07-26 Raja R Harinath <rharinath@novell.com>
10295 * roottypes.cs: Rename from tree.cs.
10297 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10298 * tree.cs (Tree, ITreeDump): Remove types.
10299 * rootcontext.cs (tree, Tree): Remove fields.
10300 (root, ToplevelTypes): New.
10301 * *.cs: Update to rename.
10303 * tree.cs (Tree.RecordDecl): Remove.
10304 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10306 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10308 2006-07-23 Raja R Harinath <harinath@gmail.com>
10310 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10311 DoFlowAnalysis and OmitStructFlowAnalysis here.
10312 (ec.With): Rename from WithUnsafe and generalize.
10313 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10314 (ec.WithFlowAnalyis): New.
10315 * ecore.cs, expression.cs, statement.cs: Update.
10317 2006-07-22 Raja R Harinath <harinath@gmail.com>
10319 * statement.cs (Block.ResolveMeta): Simplify slightly.
10321 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10322 multiple boolean fields. Convert InUnsafe, constant_check_state,
10323 check_state to flags.
10324 (CheckState, ConstantCheckState): Update.
10325 (InUnsafe): New read-only property.
10326 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10328 (WithUnsafe): New helper similar to WithCheckState.
10329 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10330 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10332 2006-07-21 Raja R Harinath <rharinath@novell.com>
10334 Make comparisons use the same IL irrespective of whether they're
10335 in a 'checked' or 'unchecked' context: one of the issues in #78899
10336 * codegen.cs (EmitContext.CheckState): Make read-only property.
10337 (EmitContext.ConstantCheckState): Likewise.
10338 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10339 helper that implement a save/restore stack for CheckState
10340 values. This is the only way to change check-state.
10341 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10342 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10343 (CheckedExpr.EmitBranchable): New forwarding method.
10344 (UnCheckedExpr): Likewise.
10345 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10346 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10347 (Checked.Resolve, checked.DoEmit): Likewise.
10349 2006-07-20 Miguel de Icaza <miguel@novell.com>
10351 * anonymous.cs: Cache the resolved anonymous delegate, and return
10352 this so that the ResolveTopBlock is only triggered once, not
10355 Currently we trigger ResolvetopBlock twice due to a first pass of
10356 argument check compatibility, and a second pass that does the
10359 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10361 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10363 * rootcontext.cs (Reset): Add helper_classes.
10365 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10368 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10371 2006-07-13 Miguel de Icaza <miguel@novell.com>
10373 * statement.cs (Lock): Handle expressions of type
10374 TypeManager.null_type specially. Fixes #78770
10376 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10378 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10381 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10383 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10384 for accessors as well.
10385 * ecore.cs (EventExpr): Add AccessorTable.
10387 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10390 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10391 for CS0122 where appropriate.
10392 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10394 (Filter): Assembly can be null in the case of top level attributes.
10396 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10400 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10401 is done at global level.
10403 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10405 A fix for #77002, Implemented TypeForwarder support.
10407 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10408 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10409 * typemanager.cs (): Add type_forwarder_attr_type.
10411 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10413 * report.cs: Add CS0469 warning.
10415 2006-06-21 Martin Baulig <martin@ximian.com>
10417 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10418 the `try'-block, so we also report CS0016 etc. there.
10420 2006-06-21 Martin Baulig <martin@ximian.com>
10423 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10425 2006-06-21 Martin Baulig <martin@ximian.com>
10427 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10428 also report CS1686 for parameters.
10430 2006-06-21 Martin Baulig <martin@ximian.com>
10432 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10433 instead of an error if the value is not implicitly convertible to
10434 the switch types; fixes #77964.
10436 2006-06-21 Raja R Harinath <rharinath@novell.com>
10439 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10440 FieldBuilder is null.
10443 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10444 'left' and 'right' before error-checking.
10446 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10448 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10450 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10451 (FieldExpr.DoResolve): likewise.
10452 (PropertyExpr.InstanceResolve): likewise.
10453 (EventExpr.InstanceResolve): likewise.
10455 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10457 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10458 attribute applicable tests for attribute argument.
10460 2006-06-02 Raja R Harinath <rharinath@novell.com>
10463 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10464 (Binary.OverloadResolve_PredefinedIntegral): New.
10465 (Binary.OverloadResolve_PredefinedFloating): New.
10466 (Binary.OverloadResolve_PredefinedString): New.
10467 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10468 Follow the standard more closely, and treat numeric promotions in
10469 terms of overload resolution.
10470 (Binary.CheckShiftArguments): Simplify.
10472 2006-06-01 Raja R Harinath <rharinath@novell.com>
10474 * flowanalysis.cs (MyBitVector): Simplify representation.
10475 (MyBitVector.Clone): Avoid allocating BitArray.
10476 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10477 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10478 (*): Update. Change all references to MyBitVector.And and
10479 MyBitVector.Or to &= and |=.
10481 2006-05-29 Raja R Harinath <rharinath@novell.com>
10483 Fix cs0231-[34].cs.
10484 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10485 to param arguments too.
10487 2006-05-26 Miguel de Icaza <miguel@novell.com>
10489 * cs-parser.jay: Catch another parsing form for arglist being
10490 followed by other arguments. Fixes #78313.
10492 2006-05-24 Raja R Harinath <rharinath@novell.com>
10494 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10495 checking of out parameters to ...
10496 (FlowBranchingToplevel.Merge): ... here.
10497 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10498 set, propagate the origin upward, and only complain if there was
10500 (FlowBranchingException.AddContinueOrigin): Likewise.
10501 (FlowBranchingException.AddReturnOrigin): Likewise.
10502 (FlowBranchingException.AddGotoOrigin): Likewise.
10504 2006-05-23 Raja R Harinath <rharinath@novell.com>
10506 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10507 unreachable, skip it.
10508 (FlowBranchingException.Merge): Always propagate jumps, even if
10509 the finally block renders subsequent code unreachable.
10511 2006-05-18 Raja R Harinath <rharinath@novell.com>
10514 * statement.cs (Goto.Resolve): Move responsibility for resolving
10515 'goto' to FlowBranching.AddGotoOrigin.
10516 (Goto.SetResolvedTarget): New. Callback to set the
10517 LabeledStatement that's the target of the goto.
10518 (Goto.DoEmit): Use Leave instead of Br when crossing an
10519 unwind-protect boundary.
10520 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10521 LookupLabel and adjust to new semantics.
10522 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10523 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10524 Goto.SetResolvedTarget to update target.
10525 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10526 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10527 AddBreakOrigin & co. Delay propagation until ...
10528 (FlowBranchingException.Merge): ... this.
10530 * statement.cs (Block.Resolve): Always depend on flow-branching to
10531 determine unreachability. Kill workaround that originally emitted
10532 only one statement after an "unreachable" label (see infloop in
10535 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10536 This is still "wrong", but anything better would probably need a
10537 multi-pass algorithm.
10538 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10539 usage vector. Force current usage vector to be reachable, to
10540 optimistically signify backward jumps.
10541 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10543 (FlowBranchingLabeled.Merge): New. If no backward jump was
10544 detected, return the original salted-away usage vector instead,
10545 updated with appropriate changes. Print unreachable warning if
10547 * statement.cs (Block.Resolve): Don't print unreachable warning on
10548 a labeled statement.
10550 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10552 * driver.cs: Pass filename without path to AssemblyBuilder's
10553 AddResourceFile. Fixes bug #78407.
10555 2006-05-17 Raja R Harinath <rharinath@novell.com>
10557 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10558 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10559 (FlowBranching.MergeChild): Overwrite
10560 reachability information from Labeled branchings too.
10562 2006-05-16 Raja R Harinath <rharinath@novell.com>
10564 * statement.cs (Goto.Resolve): Merge jump origins here ...
10565 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10567 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10568 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10569 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10570 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10572 * statement.cs (Goto.Resolve): ... not here.
10573 (Goto.Emit): Remove CS1632 check.
10575 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10577 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10580 2006-05-11 Raja R Harinath <rharinath@novell.com>
10582 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10583 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10584 (FlowBranchingException.Label): Likewise.
10586 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10588 (MyBitVector.Or): Use it to avoid losing information (Count).
10589 (FlowBranching.MergeOrigins): Likewise.
10591 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10592 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10593 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10594 (UsageVector.ToString): Simplify.
10595 (UsageVector.MergeSiblings): Move here from ...
10596 (FlowBranching.Merge): ... here.
10597 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10600 2006-05-10 Raja R Harinath <rharinath@novell.com>
10602 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10603 null bitvector is treated as all-true.
10605 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10606 (MyBitVector): Rationalize invariants. 'vector != null' implies
10607 that we have our own copy of the bitvector. Otherwise,
10608 'InheritsFrom == null' implies all inherited bits are true.
10610 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10612 * statement.cs (LocalInfo): Add IsConstant.
10613 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10614 local variable for constants.
10616 2006-05-09 Raja R Harinath <rharinath@novell.com>
10618 * flowanalysis.cs (MyBitVector.Empty): New.
10619 (MyBitVector): Don't allow InheritedFrom to be null.
10620 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10621 (UsageVector, FlowBranching): Update to changes.
10623 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10624 recursion. The 'Parent == null' condition isn't sufficient for
10626 (FlowBranching.AddBreakOrigin): Likewise.
10627 (FlowBranching.AddContinueOrigin): Likewise.
10628 (FlowBranching.AddReturnOrigin): Likewise.
10629 (FlowBranching.StealFinallyClauses): Likewise.
10630 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10631 (FlowBranching.CheckOutParameters): Likewise.
10632 (FlowBranchingToplevel): Terminate all the above recursions here.
10633 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10634 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10636 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10638 (FlowBranchingToplevel): New. Empty for now.
10639 (FlowBranching.MergeTopBlock): Update.
10640 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10641 branching for the anonymous delegate.
10642 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10644 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10645 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10646 information at the start of the merge. Reorganize.
10648 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10650 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10652 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10654 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10655 to newly introduced ctor.
10657 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10658 message to one place.
10659 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10662 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10664 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10666 * ecore.cs (Expression.ResolveAsConstant): Updated.
10668 * statement.cs (ResolveMeta): Updated.
10670 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10672 * cs-parser.jay: __arglist cannot be used in initializer.
10674 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10677 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10680 2006-05-05 Raja R Harinath <rharinath@novell.com>
10682 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10683 (LabeledStatement): Add 'name' parameter.
10684 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10685 (Block.AddLabel): Update to changes.
10686 * cs-parser.jay (labeled_statement): Likewise.
10688 * flowanalysis.cs (BranchingType.Labeled): New.
10689 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10690 (FlowBranchingLabeled): New. Does nothing for now, but will
10691 eventually handle 'goto' flows.
10692 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10693 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10694 that's terminated ...
10695 (Block.Resolve): ... here.
10697 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10698 (UsageVector.MergeFinallyOrigins): Likewise.
10699 (FlowBranching.InTryOrCatch): Likewise.
10700 (FlowBranching.AddFinallyVector): Likewise.
10701 (FlowBranchingException): Update to changes.
10704 * statement.cs (Return.Resolve): Move error checking to ...
10705 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10706 (FlowBranchingException): Handle return origins like break and
10708 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10710 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10713 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10716 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10719 * class.cs (MethodData.Define): Do public accessor check only when method
10720 implements an interface.
10722 2006-05-04 Raja R Harinath <rharinath@novell.com>
10724 Remove special handling of 'break'
10725 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10726 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10727 (UsageVector.Break): Remove.
10728 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10730 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10732 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10733 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10735 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10738 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10739 be the interface member.
10741 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10744 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10745 for emitting small (int) values.
10747 2006-05-03 Raja R Harinath <rharinath@novell.com>
10750 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10751 control-flow passes through the 'finally' after merging-in all the
10752 control-flows from 'try' and the 'catch' clauses.
10754 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10755 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10756 always true at the only non-recursive entry point.
10757 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10758 FlowBranchingBreakable.
10759 (FlowBranchingLoop): Remove.
10760 * statement.cs (Return.DoResolve): Update to changes.
10763 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10764 (FlowBranching.CreateBranching): Handle it: create a
10765 FlowBranchingContinuable.
10766 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10767 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10768 except that it handles the 'continue' command.
10769 (FlowBranching.UsageVector.MergeOrigins): Rename from
10771 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10772 except that it overrides AddContinueOrigin.
10773 (FlowBranchingException): Override AddContinueOrigin, similar to
10775 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10776 Create a new branching around the embedded statement.
10777 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10778 control flow after the embedded statement.
10779 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10781 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10782 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10783 FlowBranchingBreakable.
10784 (FlowBranchingSwitch): Remove.
10787 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10788 error reporting to ...
10789 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10790 Rename from 'AddBreakVector'. Add new location argument. Return
10791 a bool indicating whether the 'break' crosses an unwind-protect.
10792 (FlowBranchingException.AddBreakOrigin): Add.
10793 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10794 flowbranching after updating with the effects of the 'finally'
10796 (FlowBranchingBreakable): New common base class for
10797 FlowBranchingLoop and FlowBranchingSwitch.
10799 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10800 embedded statement.
10801 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10803 2006-05-02 Raja R Harinath <rharinath@novell.com>
10805 * statement.cs (Do.Resolve): If the loop is infinite, set the
10807 (While.Resolve, For.Resolve): Set a barrier after the embedded
10808 statement. There's no direct control flow that goes from the end
10809 of the embedded statement to the end of the loop.
10810 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10811 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10812 above ensure that the reachability is correctly computed.
10814 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10815 (UsageVector.MergeBreakOrigins): If the current path is
10816 unreachable, treat it as if all parameters/locals are initialized.
10817 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10818 infinite loops before merging-in break origins.
10820 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10821 (Reachability.Reachable): Split part into ...
10822 (Reachability.Unreachable): ... this. Simplify.
10823 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10825 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10826 (Reachability.SetThrowsSometimes): Likewise.
10827 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10828 TriState.Always, use corresponding property.
10829 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10830 (Block.Resolve): Likewise. Remove some redundant checks.
10832 2006-05-02 Raja R Harinath <harinath@gmail.com>
10834 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10835 (Reachability.Meet): Don't bother checking AlwaysThrows --
10836 barrier is always set.
10837 (FlowBranchingBlock.Merge): Likewise.
10839 2006-05-01 Raja R Harinath <harinath@gmail.com>
10841 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10842 checks for unreachable.
10844 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10847 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10849 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10850 whether field is really assigned.
10852 2006-04-30 Raja R Harinath <harinath@gmail.com>
10854 * flowanalysis.cs (Reachability): Make 4-argument constructor
10856 (Reachability.Meet): Rename from 'And'. Remove static variant.
10857 (Reachability.Always): Rename from the highly misleading
10858 'Reachability.Never'.
10859 (FlowBranching.Merge): Update to changes. Mark an impossible
10860 situation with a 'throw'.
10861 (*): Update to changes.
10863 2006-04-29 Raja R Harinath <harinath@gmail.com>
10865 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10866 Remove 'Undefined'.
10867 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10868 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10869 (*): Update to changes.
10870 * statement.cs: Update to changes.
10872 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10875 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10877 2006-04-28 Raja R Harinath <harinath@gmail.com>
10879 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10882 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10883 argument to two arguments: an usage-vector and a bool. Move call
10884 to FlowBranching.Merge () ...
10885 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10887 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10888 handling of loop and switch reachability to ...
10889 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10891 2006-04-27 Raja R Harinath <harinath@gmail.com>
10893 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10894 handling to FlowBranchingLoop.InLoop.
10895 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10897 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10900 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10901 anonymous method is allowed from AnonymousContainer here.
10903 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10905 2006-04-24 Raja R Harinath <rharinath@novell.com>
10908 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10910 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10913 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10914 (DoubleConstant.Reduce): Ditto.
10916 2006-04-23 Raja R Harinath <rharinath@novell.com>
10918 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10919 Remove 'lvalue_right_side' argument. Move parts to ...
10920 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10921 (LocalVariable.DoResolveLValue): ... these.
10923 2006-04-21 Raja R Harinath <rharinath@novell.com>
10926 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10927 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10928 (LocalVariableReference.DoResolveBase): Use it to implement new
10930 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10931 (Argument.Resolve): Simplify. Move CS1510 check ...
10932 * ecore.cs (Expression.ResolveLValue): ... here.
10933 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10934 (PropertyExpr.DoResolveLValue): Likewise.
10935 (FieldExpr.Report_AssignToReadonly): Likewise.
10936 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10937 LValueMemberAccess or LValueMemberOutAccess on instance depending
10939 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10940 DoResolve as appropriate.
10942 2006-04-20 Raja R Harinath <rharinath@novell.com>
10945 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10946 implicit conversions on 'out' and 'ref' arguments.
10948 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10949 improve clarity. Remove dead code.
10952 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10953 (Catch.Resolve): Resolve VarBlock if it exists.
10955 2006-04-19 Miguel de Icaza <miguel@novell.com>
10957 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10958 twice, this was some residual code, the enumerator was emitted
10959 properly in the two branche of if later.
10961 2006-04-19 Raja R Harinath <rharinath@novell.com>
10963 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10964 cast is never an lvalue.
10965 (Cast.DoResolve, Cast.ResolveRest): Combine.
10966 (Argument.Emit): Simplify slightly. Move 'Expr is
10967 IMemoryLocation' check ...
10968 (Argument.Resolve): ... here.
10969 (Argument.Error_LValueRequired): Remove. Inline into only user.
10971 Simplifications. Fix cs0191-2.cs
10972 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10973 CS1649 and CS1651 to ...
10974 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10975 the actual selection of the error code and message to a lookup
10976 table. Add a dummy return value to simplify callsites.
10977 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10978 readonly fields of other instances of the same type. Move CS0197
10980 * expression.cs (Argument.Resolve): ... here. Simplify code.
10981 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10982 resolution of an out or ref argument. The code simplification
10983 above uses this invariant.
10985 2006-04-18 Raja R Harinath <rharinath@novell.com>
10987 Possibly fix #77752. Fix cs1690-[4-7].cs.
10988 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10989 CheckMarshallByRefAccess. Drop parameter.
10990 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10992 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10993 InstanceExpression.
10994 * report.cs (AllWarnings): Add CS1690.
10995 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10996 for ref access too.
10997 (LocalVariableReference.DoResolveBase): Update.
10999 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11001 * class.cs (MethodOrOperator): Moved common parts from method class.
11002 detect obsolete attributes.
11003 (Method.Define): Simplified as it reuses code from base.
11004 (Constructor.ValidAttributeTargets): Fixed issue found during
11006 (Destructor.ValidAttributeTargets): Fixed issue found during
11008 (Operator): Finished refactoring set off by #78020. Operator class is now
11009 ordinary method class.
11011 * anonymous.cs: Updated.
11013 * decl.cs (DeclSpace): Add IsGeneric
11015 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11017 * class.cs (Constructor.Emit): Don't emit the attributes twice.
11019 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11021 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
11022 detect obsolete attributes.
11023 (Method.CreateEmitContext): Moved to MethodOrOperator.
11025 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11028 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
11029 customized exception to make crash detection easier.
11030 (MethodOrOperator): Started to work on new base class for methods and
11032 (Method): Derives from MethodOrOperator.
11033 (Constructor.Emit): Emits its own attributes.
11034 (AbstractPropertyEventMethod.Emit): Ditto.
11035 (Operator): Derives from MethodOrOperator, will refactor fully in extra
11037 (Operator.Emit): It's temporary more tricky than should be.
11039 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
11041 * report.cs (InternalErrorException): Add ctor with inner exception.
11043 2006-04-08 Marek Safar <marek.safar@seznam.cz>
11046 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
11049 2006-04-07 Marek Safar <marek.safar@seznam.cz>
11052 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
11055 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11057 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
11058 attribute is present and Guid not.
11059 (Interface.ApplyAttributeBuilder): Ditto.
11061 * attribute.cs: Add error message.
11063 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11067 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
11068 sources (it's composite) so hold them in extra array as they are used in
11069 Emit phase only. It worked in the previous versions by mistake.
11070 (Attribute.Emit): Emit attribute for more owners when exist.
11072 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
11073 it has now different behaviour.
11075 2006-04-04 Marek Safar <marek.safar@seznam.cz>
11077 * constant.cs (Constant.IsDefaultInitializer): New method.
11079 * class.cs: Updated.
11081 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
11082 re-initialize default values. It saves KBs almost for every assembly.
11083 Thanks Zoltan for the idea.
11084 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
11085 (ArrayCreation.DoResolve): Resolve only once.
11086 (ArrayCreation.Emit): Emit static initializer only when it is faster.
11087 (ArrayCreation.GetAttributableValue): Cope with optimized values.
11089 2006-04-03 Zoltan Varga <vargaz@gmail.com>
11091 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
11094 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11096 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
11097 in an embedded statement too.
11099 2006-04-01 Raja R Harinath <rharinath@novell.com>
11102 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
11104 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11108 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
11111 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
11113 2006-03-31 Marek Safar <marek.safar@seznam.cz>
11115 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
11118 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
11119 LocalTemporary change.
11121 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
11123 (ClassOrStruct.DefineFieldInitializers): Implemented static field
11124 initializers optimization.
11125 (ClassOrStruct.TypeAttr): Moved from modifiers.
11126 (Constructor.CheckBase): Don't crash when static ctor has parameters.
11127 (FieldBase.ResolveInitializer): Resolves initializer.
11128 (FieldBase.HasDefaultInitializer): New property.
11130 * cs-parser.jay: Removed message.
11132 * expression.cs (CompilerGeneratedThis): New specialization.
11134 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
11136 2006-03-28 Marek Safar <marek.safar@seznam.cz>
11138 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
11140 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11142 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
11143 be now EnumConstants only.
11145 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11147 * attribute.cs, driver.cs: Reset more caches.
11149 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11151 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
11153 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11155 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
11156 for easier reuse. Updated all overrides.
11157 (IntegralConstant): New base class for all integral constants.
11158 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
11159 of the constant range, report custom error.
11160 (UIntConstant.Reduce): Fixed uint conversion.
11162 * ecore.cs, literal.cs: Reduce updates.
11164 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11168 * class.cs (Constructor.Define): Removed extra if for default ctors.
11169 A patch from Atsushi Enomoto.
11171 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11173 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
11174 GetAttributableValue.
11176 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
11179 * convert.cs (ImplicitConversionRequired): Error message moved to
11182 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
11183 automatic implicit conversion of an output value.
11184 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
11186 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
11188 (TypeOf.GetAttributableValue): Add extra handling for object type.
11190 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
11191 special error message.
11193 2006-03-25 Marek Safar <marek.safar@seznam.cz>
11195 * class.cs (Constructor.Emit): Don't crash when struct ctor is
11197 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
11198 compatible with MS runtime.
11200 2006-03-23 Marek Safar <marek.safar@seznam.cz>
11202 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
11203 attribute arguments here.
11205 * class.cs (Indexer.Define): The check was moved to attribute class.
11207 2006-03-22 Marek Safar <marek.safar@seznam.cz>
11209 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
11210 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
11213 2006-03-22 Raja R Harinath <rharinath@novell.com>
11215 Support ParameterDefaultValueAttribute in gmcs. Also applied to
11216 mcs to keep code differences small.
11217 * attribute.cs (Attribute.GetParameterDefaultValue): New.
11218 * typemanager.cs (parameter_default_value_attribute_type): New.
11219 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
11222 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11224 * expression.cs (StringConcat.Append): Reverted back to no warning state.
11226 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11228 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
11230 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
11233 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
11235 * doc-bootstrap.cs : fix build.
11237 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11239 * expression.cs (StringConcat.Append): Issue a warning when empty string
11240 is going to append.
11242 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11244 * assign.cs (CompoundAssign.ResolveSource): Removed.
11246 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
11249 * class.cs (TypeContainer.FindMethods): Removed.
11250 (TypeContainer.CheckMemberUsage): Made static.
11252 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
11254 * constant.cs (CheckRange): Removed unused type argument.
11255 (CheckUnsigned): Removed unused type argument.
11257 * cs-parser.jay: Updated after MemberAccess clean up.
11258 Uses Length for empty string test.
11260 * cs-tokenizer.cs: Uses Length for empty string test.
11261 (IsCastToken): Made static.
11262 (is_hex): Made static.
11263 (real_type_suffix): Made static.
11265 * decl.cs (SetupCache): Made static.
11266 (OnGenerateDocComment): Removed unused ds argument.
11268 * delegate.cs (VerifyDelegate): Removed unused argument.
11270 * doc.cs: Uses Length for empty string test.
11272 * driver.cs: Uses Length for empty string test.
11274 * enum.cs (IsValidEnumType): Made static
11276 * expression.cs (EnumLiftUp): Removed unused argument.
11277 (ResolveMethodGroup): Ditto.
11278 (BetterConversion): Ditto.
11279 (GetVarargsTypes): Ditto.
11280 (UpdateIndices): Ditto.
11281 (ValidateInitializers): Ditto.
11282 (MemberAccess.ctor): Ditto.
11283 (GetIndexersForType): Ditto.
11285 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11287 * iterators.cs: Updated after MemberAccess clean up.
11289 * location.cs: Uses Length for empty string test.
11291 * namespace.cs: Uses Length for empty string test.
11293 * report.cs (CheckWarningCode): Made static.
11295 * statement.cs (LabeledStatement): Removed unused argument.
11297 * typemanager.cs (FilterNone): Removed.
11299 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11301 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11304 * class.cs: Updated.
11306 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11308 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11310 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11314 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11315 reporting, it's more tricky than I thought.
11317 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11321 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11323 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11324 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11325 Add more error reporting; Fixed issue with params.
11327 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11329 * cs-parser.jay: AnonymousMethod requires host container.
11331 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11333 2006-03-18 Raja R Harinath <harinath@gmail.com>
11335 * class.cs: Change 'TypeContainer ds' constructor argument to
11336 'DeclSpace parent'. Some classes were missed below due to
11337 different naming convention.
11339 * class.cs (MemberCore.Parent): Delete. This makes the
11340 ParentContainer changes below enforceable by the compiler.
11342 Treat pointers to enclosing declaration space as 'DeclSpace', not
11344 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11345 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11347 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11349 (Block.AddThisVariable): Likewise.
11350 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11351 (AbstractPropertyEventMethod.Emit): Likewise.
11352 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11353 (GetMethod.Define, SetMethod.Define): Likewise.
11354 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11355 (DelegateMethod.EmitMethod): Likewise.
11357 Fix regression test-partial-13.cs.
11358 Rationalize use of PartialContainer. Ensure that the partial
11359 class semantics can be tied to type-correctness, i.e., any
11360 violation will cause a compile error.
11361 * class.cs, const.cs: Access all fields that belong to class
11362 TypeContainer via ParentContainer. Arguments of EmitContexts and
11363 Resolve()-like functions still use 'Parent'.
11365 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11366 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11367 (PropertyMethod.CheckModifiers): Remove unused argument.
11368 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11371 2006-03-17 Raja R Harinath <harinath@gmail.com>
11373 Make semantics of PartialContainer simpler.
11374 * decl.cs (DeclSpace.IsPartial): Remove.
11375 * class.cs (TypeContainer.IsPartial): Likewise.
11376 (TypeContainer..ctor): Set PartialContainer to point to self.
11377 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11378 (TypeContainer.FindNestedType): Likewise.
11379 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11381 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11383 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11385 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11387 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11390 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11392 * class.cs (Operator.Define): An error for base conversion was not
11393 reported correctly.
11395 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11397 * iterator.cs : yield break is allowed in try statement which has
11398 catch clauses. Fixed bug #77767.
11400 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11402 A fix for #77593, #77574.
11404 * class.cs (MethodCore.CheckBase): Another if for operator.
11406 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11408 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11411 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11412 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11415 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11418 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11419 Updated after another emitcontext usage was clean up. It should help us to
11420 synchronize with gmcs easier.
11422 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11426 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11427 (Event.Define): ditto
11428 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11430 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11431 Removed redundant code and set NewSlot for Invoke method too.
11433 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11434 (Parameters.MergeGenerated): New method. Use this method when you merge
11435 compiler generated argument with user arguments.
11437 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11439 * attribute.cs (ResolveAsTypeTerminal): Removed.
11441 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11442 specialization for predefined types; 30% speed up.
11443 Finally placed obsolete check to right place.
11444 (Expression.ResolveType): Removed.
11446 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11447 Updated after ResolveType was removed.
11449 * expression.cs (Cast.ctor): Check void cast.
11450 (Binary.ResolveAsTypeTerminal): Is never type.
11451 (Conditional.ResolveAsTypeTerminal): Is never type.
11453 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11455 2006-03-01 Raja R Harinath <rharinath@novell.com>
11458 * expression.cs (ParameterReference.DoResolveBase): Change return
11460 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11464 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11467 * typemanager.cs (GetFullNameSignature): Don't nullref on
11468 protected accessors.
11470 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11472 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11473 these two separated members to simplify the code.
11474 (Attribute.Resolve): Refactored to use new fields and methods.
11475 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11476 implemented obsolete attribute checking.
11477 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11478 implemented obsolete checking again. It look line never ending quest ;-)
11479 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11481 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11483 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11485 *class.cs (Property.Define): Add RegisterProperty call.
11487 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11488 argument groups (only 2).
11490 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11491 encoding expression to arguments.
11492 (Expression.ExprClassToResolveFlags): Just turned to property.
11494 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11495 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11496 optimized as well as implemented support for zero-length attributes.
11498 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11499 Add caching of PropertyInfo's.
11501 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11503 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11504 error multiple times.
11506 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11508 New partial class implementation.
11509 A fix for #77027, #77029, #77403
11511 * attribute.cs (Attributable): Made attributes protected.
11513 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11514 the replacements of ClassPart and PartialContainer.
11515 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11516 (TypeContainer.AddInterface): Ditto.
11517 (TypeContainer.AddPartial): The main method for partial classes. It checks
11518 for errors and merges ModFlags and attributes. At the end class is added to
11519 partial_parts list.
11520 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11522 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11523 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11524 from the rest of partial classes.
11525 (TypeContainer.GetClassBases): Simplified.
11526 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11528 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11529 (TypeContainer.HasExplicitLayout): Uses Flags now.
11530 (PartialContainer): Removed.
11531 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11532 (StaticClass): Was merged with Class.
11533 (Class.GetClassBases): class and static class bases are verified here.
11534 (Class.TypeAttr): Added static attributes when class is static.
11535 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11536 (MemberBase): In some cases we need to call parent container for partial
11537 class. It should be eliminated but it's not easy now.
11539 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11541 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11542 partial classed to accumulate class comments.
11543 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11545 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11547 * driver.cs (MainDriver): Tree.GetDecl was removed.
11549 * modifiers.cs (Modifiers): Add partial modifier.
11551 * tree.cs (Tree.decl): Removed.
11552 (RootTypes): Started to use this class more often for root types
11555 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11559 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11560 external interface does not have an attribute.
11562 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11564 Another prerequisites for new partial classs implementation.
11566 * attribute.cs (Attribute.Equal): Implemented.
11567 (Attribute.Emit): Changed as attributes can be applied more than twice.
11568 (Attributes.Emit): Check for duplicate attributes here.
11570 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11571 as a parameter, clean-up.
11573 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11577 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11578 contains obsolete attribute check which can in some cases look for base
11579 type of current class which is not initialized yet.
11580 (TypeContainer.BaseType): Replacement of ptype.
11582 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11584 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11586 First of prerequisites for new partial classs implemention.
11588 * attribute.cs (Attributable): Extended by ResolveContext;
11589 Attributes finally have correct context for resolving in all cases.
11590 (AttachTo): Attribute owner is assigned here.
11592 * codegen.cs (IResolveContext): Introduce new interface to hold
11593 all information needed in resolving phase.
11594 (EmitContext): Implements IResolveContext; more clean-up needed here.
11596 * decl.cs (MemberCore): Implemented IResolveContext.
11598 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11599 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11600 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11601 Refactored to use new IResolveContext instead of EmitContext; cleanup
11603 2006-02-06 Miguel de Icaza <miguel@novell.com>
11605 * codegen.cs (EmitScopeInitFromBlock): check here the
11606 capture_context, there is no need to make two calls to the
11609 * anonymous.cs: Add some debugging messages that might help me
11610 track other instances of this problem in the future (the
11611 regression of test 467).
11613 * cs-parser.jay: track the variable block, as we need to initalize
11614 any captured variables declared in this block for the "catch"
11615 portion of the "Try" statement.
11617 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11618 scope initialization for captured variables.
11620 Also, move the emit for the variables after the block location has
11623 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11625 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11627 2006-02-02 Miguel de Icaza <miguel@novell.com>
11629 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11630 commit yesterday, the initialization for the roots is necessary.
11631 What is not necessary is the scope activation.
11633 2006-02-02 Raja R Harinath <rharinath@novell.com>
11635 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11636 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11638 (Argument.Resolve): Remove CS0206 checks.
11640 2006-02-01 Miguel de Icaza <miguel@novell.com>
11642 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11643 scopes for all the roots, the scopes will now be emitted when the
11644 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11646 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11647 code. This reduces a lot of existing cruft.
11649 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11650 that the ScopeInfo is generated as we enter the scope, not at the
11651 time of use, which is what we used to do before.
11653 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11654 every time a Block is about to be emitted if we have a
11657 2006-02-01 Raja R Harinath <rharinath@novell.com>
11659 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11661 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11663 * typemanager.cs (cons_param_array_attribute): Make private.
11664 (Reset): Set it to null.
11665 (InitCoreHelpers): Don't initialize it.
11666 (ConsParamArrayAttribute): New. Initialize it as needed.
11667 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11669 2006-01-31 Miguel de Icaza <miguel@novell.com>
11671 * expression.cs: There might be errors reported during the
11672 selection of applicable methods. If there are errors, do not
11673 continue execution as it will lead the compiler to crash.
11675 2006-01-30 Miguel de Icaza <miguel@novell.com>
11677 * expression.cs: Member access is not allowed on anonymous
11678 methods. Fixes #77402.
11680 2006-01-30 Raja R Harinath <rharinath@novell.com>
11683 * cs-parser.jay (VariableDeclaration): Don't set
11684 current_array_type to null.
11685 (field_declaration, event_declaration, declaration_statement):
11686 Set it to null here.
11688 2006-01-28 Raja R Harinath <harinath@gmail.com>
11690 * typemanager.cs (GenericParameterPosition): New.
11693 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11695 * doc.cs : To process "include" elements, first we should create
11696 another list than XmlNodeList, because it could result in node
11697 removal, which could result in that the XmlNodeList gives up
11698 yielding next node.
11700 (Also made code identical to gmcs again.)
11702 2006-01-25 Miguel de Icaza <miguel@novell.com>
11704 * ecore.cs: Introduce an error report that we were not catching
11705 before, if not silent, we must report the error. Gonzalo ran into
11708 2006-01-23 Miguel de Icaza <miguel@novell.com>
11710 A fix for bug: #76957
11712 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11713 ComputeMethodHost before creating the method, this is a new
11716 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11717 that this method references (RegisterScope). The actual scope
11718 where the method is hosted is computed with the ComputeMethodHost
11719 before we create the method.
11721 Moved the Deepest routine here.
11723 (AnonymousContainer.ComputeMethodHost): New routine used to
11724 compute the proper ScopeInfo that will host the anonymous method.
11726 (ScopeInfo): Deal with multiple roots. The problem was that we
11727 did not have a unique root where all ScopeInfos could be hanged
11728 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11731 Remove AdjustMethodScope which is now computed at the end. Remove
11732 LinkScope which did a partial link, instead link all ScopeInfos
11733 before code generation from the new "LinkScopes" routine.
11735 Simplify all the Add* routines as they no longer need to maintain
11736 the tree, they just need to record that they are using variables
11739 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11740 routines to produce the forest of ScopeInfo trees.
11742 * class.cs (TypeContainer.AppendMethod): This is just like
11743 AddMethod, but ensures that an interface implementation method
11744 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11745 methods, but at the end.
11747 We use this functionality to ensure that the generated MoveNext
11748 method in the iterator class is resolved/emitted before the
11749 enumerator methods created.
11751 This is required because the MoveNext method computes the right
11752 ScopeInfo for the method. And the other methods will eventually
11753 need to resolve and fetch information computed from the anonymous
11756 2006-01-21 Raja R Harinath <harinath@gmail.com>
11757 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11759 Fix rest of #76995.
11760 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11761 the 'aliases' hash.
11762 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11763 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11765 2006-01-18 Raja R Harinath <rharinath@novell.com>
11767 Fix #76656, cs0231-2.cs.
11768 * cs-parser.jay (formal_parameter_list): Make error case catch
11770 (parenthesized_expression_0): Add CS1026 check.
11771 (invocation_expression): Remove unused { $$ = lexer.Location }.
11773 2006-01-17 Raja R Harinath <rharinath@novell.com>
11776 * cs-parser.jay (statement_expression): Don't list out the
11777 individual statement-expressions. Convert syntax error into
11780 2006-01-16 Raja R Harinath <rharinath@novell.com>
11783 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11784 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11785 CheckIntermediateModification.
11786 (FieldExpr.DoResolve): Add new two-argument version that
11787 allows us to resolve the InstanceExpression as an lvalue.
11788 The one-argument variant is now just a wrapper.
11789 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11790 Resolve the lhs as an lvalue if the it has a value type.
11791 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11792 from Assign.DoResolve.
11793 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11794 resolved as an lvalue.
11795 (PropertyExpr.DoResolve): Update.
11796 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11797 has a value type. Move CS1612 check here from
11798 CheckIntermediateModification.
11799 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11800 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11801 'right_side' of a ResolveLValue on an 'out' argument.
11802 (EmptyExpression.LValueMemberAccess): New. Used as the
11803 'right_side' of a propagated ResolveLValue on a value type.
11804 (LocalVariableReference.DoResolveBase): Recognize
11805 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11807 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11808 EmptyExpression.Null.
11810 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11812 * typemanager.cs : added IsGenericParameter(). In mcs it always
11814 * doc.cs : for generic parameters, use GenericParameterPosition,
11817 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11819 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11821 2006-01-12 Miguel de Icaza <miguel@novell.com>
11823 This fixes the problem where we used ldfld instead of ldflda to
11824 load the "THIS" pointer on captured parameters, when THIS is a
11825 value type. See bug #77205.
11827 * iterators.cs (CapturedThisReference.Emit): Pass false to
11828 EmitThis (we do not need the address).
11830 * codegen.cs (EmitThis): it needs to know whether we need the
11831 address of `this' or not. This is used by value types.
11833 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11834 every other call passes false.
11836 2006-01-12 Raja R Harinath <rharinath@novell.com>
11839 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11841 * expression.cs (Invocation.OverloadResolve): Update.
11842 (Invocation.DoResolve): Avoid double resolution of invocation.
11844 2006-01-11 Raja R Harinath <rharinath@novell.com>
11847 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11848 unary negation of floating point types as 0-expr; negation cannot
11849 overflow in floating point types.
11852 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11853 on operands of 'void' type.
11856 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11857 and ExclusiveOr for boolean constants too.
11859 2006-01-09 Raja R Harinath <rharinath@novell.com>
11862 * expression.cs (Invocation.OverloadResolve): Replace reflected
11863 override methods with their base virtual methods, rather than
11864 skipping over them.
11865 * typemanager.cs (TypeManager.GetOverride): New.
11867 2006-01-05 Jb Evain <jbevain@gmail.com>
11869 * class.cs (Property.Define, Indexer.Define): do not tag the
11870 properties as SpecialName | RTSpecialName.
11872 2006-01-04 Miguel de Icaza <miguel@novell.com>
11874 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11875 doing a low-level comparission of parameter types. It was lacking
11876 a check for __argslist.
11878 2005-12-30 Miguel de Icaza <miguel@novell.com>
11880 * expression.cs (ParameterReference.DoResolveBase): Allow
11881 reference parameters if they are local to this block.
11883 This allows the ref and out parameters of a delegate to be used in
11884 an anonymous method, for example:
11886 delegate void set (out int x);
11888 set s = delegate (out int x){
11892 This is used by functionality introduced late in the C# language.
11894 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11895 method that take ref and out parameters.
11897 Fixes #77119 which was a late change in the spec.
11899 2005-12-23 Miguel de Icaza <miguel@novell.com>
11901 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11902 parent if its the same scope. Fixes #77060.
11904 2005-12-21 Miguel de Icaza <miguel@novell.com>
11906 * driver.cs: Report the case of no source files and no -out:
11909 2005-12-20 Raja R Harinath <rharinath@novell.com>
11912 * expression.cs (ComposedCast.GetSignatureForError): Define.
11914 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11918 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11919 ListDictionary, to contain the ExternAliasEntry entries (in
11920 addition to the NamespaceEntry.aliases hashtable). This field is
11921 shared between the original entry and its doppelganger (bodyless
11923 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11924 extern_aliases field.
11925 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11926 lookup in extern_aliases.
11928 2005-12-16 Raja R Harinath <rharinath@novell.com>
11931 * class.cs (TypeContainer.Mark_HasEquals): New.
11932 (TypeContainer.Mark_HasGetHashCode): New.
11933 (ClassPart): Override them.
11934 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11937 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11938 'parent' argument to the base constructor.
11940 Remove all mention of TypeContainer from decl.cs.
11941 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11942 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11943 (DeclSpace.DeclSpace): Likewise.
11944 (DeclSpace.DefineMembers): Remove unused argument.
11945 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11946 debugging check -- we don't care if the debug code throws an
11947 InvalidCastException instead of an InternalErrorException.
11948 * class.cs (TypeContainer.DefineMembers): Update to changes.
11949 (TypeContainer.DoDefineMembers): Likewise.
11950 (TypeContainer.GetMethods): Likewise.
11951 (PropertyMember.Define): Likewise.
11952 (MemberBase.Parent): New property that forwards to
11953 MemberCore.Parent, but ensures that we get a TypeContainer.
11954 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11955 (RootContext.PopulateTypes): Likewise. Remove special case code
11956 for !RootContext.StdLib: DefineMembers is idempotent.
11958 2005-12-14 Miguel de Icaza <miguel@novell.com>
11960 * convert.cs (ExplicitConversionCore): Check the return value from
11961 ExplicitConversionCore which can return null on failure. Fixes #76914
11963 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11965 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11967 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11969 * doc.cs : The search for referenced namespace was insufficient to
11970 get global one as it used to do. Fixed bug #76965.
11972 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11974 * doc.cs : check name in cref in the last phase that whether it is
11977 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11979 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11982 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11984 * doc.cs : so it turned out that we cannot skip override check for
11985 interface members. Fixed bug #76954.
11987 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11989 * cs-tokenizer.cs : fixed bug #75984:
11990 - #warning and #error should not be handled when the source line
11992 - #line is not checked strictly when the source line is disabled.
11993 - #define and #undef is on the other hand checked strictly at any
11996 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11998 * cs-tokenizer.cs : missing Location (actually, filename) in one of
12001 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12003 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
12005 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
12006 event initializers.
12007 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
12008 (FieldBase.Initializer): Initializer is now optional.
12009 (EventField.Define): Only event field can have initializer.
12011 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
12013 * const.cs (Const): Reuse initializer.
12015 * cs-parser.jay: Updated after FieldBase changes.
12016 Added current_array_type to simplify array initializers.
12018 * ecore.cs (NullCast.IsDefaultValue): Implemented.
12020 * expression.cs, iterators.cs: Updated.
12022 * namespace.cs (NamespaceEntry): Made UsingFound private.
12024 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12026 * parameterCollection.cs: Obsolete, removed.
12027 * parser.cs: Obsolete, removed.
12029 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12032 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
12034 * enum.cs (Enum.Define): Set obsolete context here.
12036 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12039 - FindDocumentedMember() now expects 1) paramList as null
12040 when "we don't have to check the number of parameters" and
12041 2) Type.EmptyTypes when "there is no arguments".
12042 - Introduced FoundMember struct to hold the exact type which was
12043 used to find the documented member (the above change broke
12044 test-xml-044; it might be better just to use DeclaringType than
12045 what MS does, like this change does, but it depends on usage.)
12047 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12049 * doc.cs : documented member might be from DeclaringType for nested
12050 types. Fixed bug #76782.
12052 2005-12-03 Ben Maurer <bmaurer@ximian.com>
12054 * anonymous.cs: Have the param code handle leaving copies on the
12055 stack etc. Allows anonymous params to take part in the assignment
12056 code (++, +=, etc). Fixes bug #76550
12058 * expression.cs: Handle the prepare_for_load/leave_copy by passing
12059 it down to the anon code.
12061 * iterators.cs: Use dummy var here
12063 * codegen.cs: Handle new vars
12065 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12068 * class.cs (MethodData.Define): Set proper Obsolete context.
12070 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
12072 (FieldExpr.DoResolve): Ditto.
12074 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12077 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
12078 parent is not obsolete.
12080 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
12082 * doc.cs : (FindDocumentedMember) find parameterless members first
12083 and get CS0419 in the early stage. Fixed first case of bug #76727.
12085 2005-11-30 Marek Safar <marek.safar@seznam.cz>
12088 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
12089 no error was reported.
12091 *expression.cs (Binary.DoResolve): left can be null.
12093 2005-11-22 Marek Safar <marek.safar@seznam.cz>
12096 * class.cs (MethodData.Emit): Parameters should be labeled first.
12098 2005-11-21 Marek Safar <marek.safar@seznam.cz>
12101 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
12103 2005-11-18 Marek Safar <marek.safar@seznam.cz>
12105 * attribute.cs (AreParametersCompliant): Moved to Parameter.
12107 * class.cs (MethodCore): Parameter clean up.
12108 (IMethodData): Added ParameterInfo.
12109 (MethodData): Parameter clean up.
12110 (Indexer.Define): Parameter clean up.
12122 * typemanager.cs: Parameter clean up.
12124 * delegate.cs (Define): Get rid of duplicated code.
12126 * expression.cs (ParameterReference): Removed useless parameters
12128 (Invocation): Ditto.
12130 * parameter.cs (ParamsParameter): New class, params specialization.
12131 (ArglistParameter): Attemp to separate arglist.
12132 (Parameter): Refactored to be reusable and faster.
12133 (Parameter.Modifier): Made understandable.
12134 (Parameters): Changed to be used as a class for `this' assembly
12135 parameters. Refactored to use new specialized classes.
12137 * support.cs (ParameterData): Added Types property.
12138 (InternalParameters): Deleted.
12140 2005-08-20 Martin Baulig <martin@ximian.com>
12142 Merging this patch from GMCS to fix #75867.
12144 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12145 scope if we don't already have it.
12147 2005-11-17 Martin Baulig <martin@ximian.com>
12150 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
12151 inherit the scope from our parent. Fixes #76653.
12153 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12155 * doc.cs : the previous patch does not actually fix the bug.
12156 PropertyInfo override check is now implemented and really fixed it.
12157 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
12159 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12161 * doc.cs : apply "override filter" also to properties.
12164 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12166 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
12167 no need to check overrides. For classes, omit those results from
12168 interfaces since they must exist in the class. Fixed bug #76726.
12170 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12172 * typemanager.cs : (GetFullNameSignature) differentiate indexers
12173 with different parameters. Fixed the second problem in #76685.
12175 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12177 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
12178 get expected 'protected' access in CheckValidFamilyAccess()).
12181 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12183 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
12184 Fixed bug #76705. CS1569 was incorrectly commented out.
12186 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12188 * doc.cs : use Invocation.IsOverride() to do real override check.
12189 * expression.cs : made Invocation.IsOverride() internal.
12191 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12193 * doc.cs : use TypeManager.FindMembers() instead of (possible)
12194 TypeBuilder.FindMembers() and filter overriden base members out.
12197 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12199 * doc.cs : ref/out parameters are represented as '@' (instead of
12200 '&' in type FullName). Fixed bug #76630 (additionally crefs).
12202 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12204 * doc.cs : when there was no '.' in cref to methods in doc comment,
12205 then parameters were missing in the output. Fixed bug #76691.
12207 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12209 * driver.cs : don't output docs when there is an error.
12212 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12215 Now it should detect indexers. Fixed primary concern in bug #76685.
12216 Fixed CS0419 message to not show the identical member signature in
12219 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12221 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
12222 instead of Type.FindMembers() since it does not handle events.
12225 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
12227 * codegen.cs: Fixed typo (speficied -> specified).
12229 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12232 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
12234 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12236 * attribute.cs: Changed error message.
12238 * cs-tokenizer.cs: One more check.
12240 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12242 * statement.cs (Block.Resolve): Ignore empty statement.
12244 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12246 * report.cs: Made error/warning methods more strict to avoid
12249 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
12250 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
12251 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
12252 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
12254 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12256 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12257 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12259 * class.cs (TypeContainer.IsComImport): New property.
12260 (Constructor.Define): Create proper ctor for ComImport types.
12262 * expression.cs (New.CheckComImport): Fixed.
12264 2005-11-07 Miguel de Icaza <miguel@novell.com>
12266 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12267 that a parameter has been captured does not mean that we do not
12268 have to do the rest of the processing. This fixes the second part
12269 of #76592. If there was another anonymous method capturing
12270 values in the past, the Scope would never be set for the second
12271 method that captured the same parameter.
12273 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12274 properly manipulate the stack. Second part of fix for #76592.
12276 * expression.cs (New): Add support for invoking "new" on
12277 interfaces that have been flagged with the ComImport attribute and
12278 the CoClass. Fixes #76637
12280 * statement.cs (Try.DoEmit): When a variable is captured, do not
12281 try to emit the vi.LocalBuilder variable as it has been captured.
12282 Create a temporary variable and store the results on the
12283 FieldBuilder. Fixes #76642
12285 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12287 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12289 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12291 * expression.cs (Binary.DoResolve): Added && optimalization.
12293 * typemanager.cs (AddUserType): Removed useless argument.
12295 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12297 * statement.cs (Block.variables): Uses ListDictionary.
12299 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12302 * class.cs (PartialContainer.EmitType): Customized to emit
12303 security attributes.
12304 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12305 for partial classes.
12307 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12310 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12311 access has to be fixed.
12313 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12315 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12318 * ecore.cs (NullCast.Reduce): Implemented.
12320 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12323 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12325 (Foreach.Resolve): Catch null properly.
12327 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12329 * cs-tokenizer.cs: Warning text fix.
12331 * driver.cs: AllWarningNumbers exposed on public interface.
12333 * report.cs (): Reviewed warning numbers.
12334 (IsValidWarning): Use binary search.
12336 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12338 * driver.cs: Implemeted resource visibility.
12339 (Resources): New class for code sharing between /res: and
12342 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12345 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12348 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12351 * ecore.cs (NullCast): Child is contant only.
12353 * literal.cs (NullLiteral.Reduce): null can be converted to any
12356 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12358 * driver.cs: Use Encoding.Default as default code page instead
12361 2005-10-27 Raja R Harinath <rharinath@novell.com>
12364 * expression.cs (Invocation.Error_InvalidArguments): Handle
12365 __arglist parameters.
12366 (Invocation.VerifyArgumentsCompat): Likewise.
12367 * support.cs (ReflectionParameters.GetSignatureForError): Print
12368 __arglist parameters.
12369 (InternalParamters.GetSignatureForError): Likewise.
12370 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12372 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12374 * attribute.cs (GetPropertyValue): Made public.
12376 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12378 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12380 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12383 * driver.cs: Reflect method name change.
12385 * statement.cs (Try.Resolve): Warn when try has both general
12386 exception handlers.
12388 * typemanager.cs: runtime_compatibility_attr_type new predefined
12391 2005-10-26 Raja R Harinath <harinath@gmail.com>
12394 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12395 treat it as an empty parameter list.
12397 2005-10-26 Raja R Harinath <rharinath@novell.com>
12400 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12401 ResolveAsTypeStep silent.
12402 * statement.cs (Block.AddConstant): Mark block as used.
12403 (Block.ResolveMeta): Avoid piling on error messages
12404 if a constant initializer resolution fails.
12406 2005-10-25 Raja R Harinath <rharinath@novell.com>
12408 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12410 (NamespaceEntry.VerifyAllUsing): New.
12411 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12412 behaviour. Delegates actual resolution of alias to ...
12413 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12414 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12416 * driver.cs (Driver.MainDriver): Update.
12418 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12419 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12421 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12423 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12424 RootNamespace.DefineNamespacesForAll.
12426 2005-10-24 Raja R Harinath <harinath@gmail.com>
12428 * typemanager.cs (assemblies, external_aliases, modules)
12429 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12430 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12431 overhead. Move resposibility ...
12432 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12433 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12435 2005-10-23 Raja R Harinath <harinath@gmail.com>
12437 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12438 cached_namespaces. Improve usage.
12439 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12440 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12441 Move from GlobalRootNamespace and simplify.
12442 (RootNamespace.Global): Make instance variable.
12443 (RootNamespace.RootNamespace): Add "alias name" parameter.
12444 (GlobalRootNamespace): Simplify drastically.
12445 (Namespace.Lookup): Don't use GetNamespace.
12446 * typemanager.cs (GetRootNamespace): Rename from
12447 ComputeNamespaceForAlias.
12448 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12450 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12452 * anonymous.cs (AnonymousContainer): Don't crash when container
12455 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12457 * expression.cs (Binary.DoResolve): Warn when comparing same
12460 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12463 * expression.cs (Binary.DoResolve): It looks like there are no
12464 convetsion rules in enum context.
12466 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12468 Add support for extern alias qualifiers.
12469 * typemanager.cs: Move some LookupTypeReflection code
12470 to namespace.cs, to have cleaner code. Added some methods
12471 to help us keep track of the extern aliased references.
12472 * driver.cs: Add suport for extern alias assemblies on command
12473 line and check for their warnings/errors. Also keep track of the
12474 extern aliased assemblies.
12475 * namespace.cs: Move the global functionality of Namespace
12476 to GlobalRootNamespace/RootNamespace. Now the global namespace
12477 is GlobalRootNamespace.Globa. Also the code moved from
12478 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12479 Finally added LocalAliasEntry (AliasEntry before) and
12480 ExternAliasEntry, to handle alias statements.
12481 * cs-parser.jay: Add support in the grammar for extern alias
12483 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12484 Update callings to Namespace (now in GlobalRootNamespace).
12486 2005-10-18 Raja R Harinath <rharinath@novell.com>
12489 * class.cs (TypeContainer.DefineType): Move updating of
12490 topological sort earlier in the code.
12491 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12493 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12496 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12498 * constant.cs (Constant.TryReduce): Moved from Cast class.
12499 (Reduce): Made little bit more OO and fixed missing conversions.
12501 * ecore.cs (Reduce): Implemented.
12502 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12504 * literal.cs (Reduce): Implemented.
12506 * class.cs: Reverted Miguel's wrong commit.
12508 2005-10-14 Miguel de Icaza <miguel@novell.com>
12510 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12512 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12514 * cs-parser.jay, expression.cs : CS0214 was missing error location
12515 for constants. Fixed bug #76404.
12517 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12520 * convert.cs (ExplicitConversionCore): Fixed object->enum
12523 2005-10-10 Raja R Harinath <rharinath@novell.com>
12525 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12526 InstanceExpression.
12527 (PropertyExpr.EmitCall): Likewise.
12528 * expression.cs (Invocation.EmitArguments): Handle case where
12530 (Invocation.EmitCall): Avoid allocating temporary variable if
12531 there are no arguments.
12533 2005-10-07 Raja R Harinath <rharinath@novell.com>
12536 * convert.cs (ImplicitConversionStandard): Move conversion of
12537 void* to arbitrary pointer types ...
12538 (ExplicitConversionStandard): .. here.
12539 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12540 error to always print typenames.
12542 2005-10-07 Raja R Harinath <rharinath@novell.com>
12544 * convert.cs (GetConversionOperator): Rename from
12545 GetConversionOperators. Move operator selection code from ...
12546 (UserDefinedConversion): ... here.
12548 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12550 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12553 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12555 * assign.cs (Assign.DoResolve): Error method changed.
12557 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12559 * const.cs (ResolveValue): Reset in_transit immediately.
12561 * constant.cs: Error method changed.
12563 * convert.cs: Removed useless location parameter.
12564 (ExplicitNumericConversion): Don't do double enum check.
12565 (ExplicitConversionCore): Renamed from ExplicitConversion.
12566 (ExplicitUnsafe): Extracted from ExplicitConversion.
12567 (ExplicitConversion): Uses for error reporting.
12569 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12571 (ResolveBoolean): Uses common error method.
12572 (CastToDecimal): Get rid of ec.
12573 (CastFromDecimal): Optimized.
12574 (ConvCast): Get rid of ec.
12576 * enum.cs (ResolveValue): Reset in_transit immediately.
12577 (Emit): Return after first error.
12579 * expression.cs: Convert changes.
12581 * literal.cs: Error method changed.
12583 * statement.cs: Error method changed.
12585 2005-10-03 Raja R Harinath <rharinath@novell.com>
12587 * support.cs (SeekableStreamReader.Position): Don't error out when
12588 the requested position is just beyond the end of the current
12591 2005-09-28 Raja R Harinath <rharinath@novell.com>
12593 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12594 try to keep in sync with the byte count of the underlying Stream.
12595 However, this limits us to a window size of 2048 characters: i.e.,
12596 the maximum lookahead of our lexer/parser can be 2048 characters.
12598 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12601 * driver.cs: Fix compilation files with full root path.
12603 2005-09-25 Miguel de Icaza <miguel@novell.com>
12605 * report.cs (SymbolRelatedToPreviousError): Format the output so
12606 it does not use an open parenthesis that is never closed.
12608 * driver.cs: Follow coding guidelines
12610 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12613 * const.cs (Const.ResolveValue): Check for assigning non-null
12614 value to reference type.
12616 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12618 * anonymous.cs: Implemented ExprClassName.
12620 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12623 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12626 * class.cs (StaticClass.DefineContainerMembers): Report protected
12629 * codegen.cs: if(ed) PRODUCTION.
12631 * convert.cs (Error_CannotImplicitConversion): Better error
12634 * cs-parser.jay: More error checks.
12636 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12638 * driver.cs (CSCParseOption): Enabled wrong option check.
12640 * ecore.cs (Expression.ExprClassName): Turned to property.
12641 (MemberExpr.CheckIntermediateModification): For checking boxed
12642 value types modification.
12644 * statement.cs (Fixed.Resolve): Expression type must be
12645 convertible to fixed type.
12646 (CollectionForeach.GetEnumeratorFilter,TryType):
12647 Small refactoring for easier error checking.
12649 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12651 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12654 * class.cs (GeneratedBaseInitializer): New class for customization
12655 compiler generated initializers.
12656 (MemberBase.DoDefine): Check Obsolete attribute here.
12657 (FieldMember.DoDefine): Ditto.
12659 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12662 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12663 (MemberCore.GetObsoleteAttribute): Removed argument.
12664 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12665 (MemberCore.CheckObsoleteType): New helper.
12669 * statement.cs: Updates after MemberCore changes.
12671 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12672 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12674 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12675 obsolete attribute for compiler construct.
12676 (As.DoResolve): Cache result.
12678 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12680 2005-09-26 Raja R Harinath <rharinath@novell.com>
12683 * expression.cs (This.VerifyFixed): In a value type T, the type of
12684 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12685 value type R, 'this' is treated as a value parameter.
12687 2005-09-22 Miguel de Icaza <miguel@novell.com>
12689 * statement.cs (Lock): Use the TemporaryVariable class instead of
12690 manually using local variables as those do not work when variables
12693 * ecore.cs: Moved the TemporaryVariable class from being a nested
12694 class inside Foreach to be a public class that can be employed in
12697 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12699 * cs-parser.jay: interface_accessors replaced by
12700 accessor_declarations.
12702 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12705 * statement.cs (GotoCase.Resolve): Convert null constant to
12707 (SwitchLabel.ResolveAndReduce): Ditto.
12708 (SwitchLabel.NullStringCase): Custom null stamp.
12709 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12711 typemanager.cs (CSharpSignature): Don't skip first argument
12714 2005-09-18 Miguel de Icaza <miguel@novell.com>
12716 * driver.cs: Set InEmacs based on the environment variable EMACS.
12718 * location.cs (InEmacs): in this mode, do not report column
12719 location as it confuses Emacs.
12721 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12723 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12724 expression.cs, iterators.cs, literal.cs: Store constants and
12727 * class.cs (MemberBase.ShortName): Pass location.
12729 * cs-parser.jay: Some location fixes.
12731 * ecore.cs (Expression.Location): Made virtual.
12733 2005-09-05 Miguel de Icaza <miguel@novell.com>
12735 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12736 if the underlying types are the same, otherwise we need to produce
12737 code that will do the proper cast.
12739 This was exposed by Marek's constant rewrite which produced
12740 invalid code for the call site:
12742 enum X : long { a }
12743 void Method (X v) {}
12747 This fixes test-49.cs
12749 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12751 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12752 Type/Object should be allowed as well. Fixed bug #75968.
12754 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12756 * expression.cs : (Binary.DoResolve): when one is enum constant and
12757 another is constant 0, then return enum one *as enum type*.
12760 2005-09-02 Raja R Harinath <rharinath@novell.com>
12762 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12766 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12767 flow-branching for LocalVariableReferences in case we were invoked
12768 from a MemberAccess.
12769 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12771 (LocalVariableReference.DoResolveBase): ... this.
12772 (MemberAccess.Resolve): Do the check that was disabled during
12775 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12778 (PartialContainer.Create): check abstract/sealed/static strictly
12779 but abstract/sealed can exist only at one side. Fixed bug #75883.
12781 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12784 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12785 specified, don't default to UnmanagedType.I4.
12787 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12789 * expression.cs : conditional operator should check possibly
12790 incorrect assign expression. Fixed bug #75946.
12792 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12794 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12795 Reverting the change. gmcs is much complex than mcs on this matter.
12797 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12799 * cs-tokenizer.cs : To read another token ahead of the actual
12800 consumption, use new SavedToken and cache token instead of moving
12801 back the stream with SeekableStreamReader (it seemed problematic).
12803 driver.cs : Thus use StreamReader directly.
12804 * support.cs : Thus removed SeekableStreamReader.
12806 2005-08-30 Raja R Harinath <rharinath@novell.com>
12809 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12810 (ScopeInfo.EmitScopeType): Use it to construct field names from
12811 names of captured locals.
12814 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12815 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12816 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12817 (ExplicitConversion): Remove enum cases already handled by
12818 implicit conversion. Move implicit conversion check to the beginning.
12819 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12820 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12821 Don't treat System.Enum as a struct.
12823 2005-08-30 Jb Evain <jbevain@gmail.com>
12825 * attribute.cs: handles as expression in parameters.
12827 2005-08-30 Raja R Harinath <rharinath@novell.com>
12830 * class.cs (TypeContainer.VerifyClsName): Don't use a
12831 PartialContainer when verifying CLS compliance.
12832 (AbstractPropertyEventMethod): Set Parent here, ...
12833 (PropertyMethod): ... not here.
12835 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12837 * attribute.cs : escaped attribute name should not be allowed to be
12838 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12840 2005-08-29 Raja R Harinath <rharinath@novell.com>
12843 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12844 when converting a long constant to unsigned long.
12845 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12846 detect where IsApplicable and VerifyArgumentsCompat disagree.
12848 2005-08-29 Raja R Harinath <rharinath@novell.com>
12849 and Carlos Alberto Cortez <carlos@unixmexico.org>
12852 * class.cs (TypeContainer.CanElideInitializer): New helper.
12853 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12854 can safely emitting the initializer of a field.
12856 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12858 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12859 allowed inside a switch (without loop). Fixed bug #75433.
12861 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12863 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12864 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12866 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12868 * driver.cs : kinda reverting the default encoding changes (not exact
12869 revert since I noticed that "codepage:reset" might not work fine).
12871 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12873 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12874 Location. Now getter and setter store location correctly.
12875 (errors/cs0111-12.cs now reports the expected location.)
12877 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12879 * driver.cs : Use default encoding on the environment.
12880 Removed (now that) extra parameter for SeekableStreamReader.
12881 * support.cs : (SeekableStreamReader) third .ctor() argument for
12882 StreamReader is not required (always true). preamble size could
12883 be acquired in simpler and safe way.
12885 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12887 * cs-parser.jay: report CS0642 at warning level 3
12888 and report CS0642 for an if else statement also
12889 fixes bug #74745. Patch by John Luke (and a bit
12891 Removed extra CS0642 warning check for "while",
12893 * statement.cs: In Block.Resolve(), CS0642 check
12894 is reimplemented to check a sequence of an empty
12895 statement and a block.
12897 Both fix bug #66777.
12899 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12901 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12902 detection until I fix it.
12904 * cs-tokenizer.cs: Changed error message.
12906 * cs-parser.jay: Fixed 2 error locations.
12908 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12909 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12912 * enum.cs (GetSignatureForError): Fixed.
12914 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12918 * typemanager.cs (RegisterProperty): Removed.
12920 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12922 2005-08-24 Raja R Harinath <rharinath@novell.com>
12925 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12926 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12928 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12930 * expression.cs : tiny fix is required for not warning positive ulong.
12933 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12935 * expression.cs : add CS0652 check for constant and integral
12936 expression. Fixed bug #53974.
12938 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12940 * expression.cs : in DoNumericPromotions(), check if there is implicit
12941 conversion overload for string (to check CS0034). Fixed bug #52492.
12943 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12945 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12947 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12949 * ecore.cs : report location when it is *not* Null.
12951 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12957 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12958 correctly. Fixed bug #75721.
12960 2005-08-23 Raja R Harinath <rharinath@novell.com>
12962 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12963 loop that performs 'min (pos, char_count)'.
12966 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12967 converted value in Operator.OnesComplement.
12969 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12971 * anonymous.cs: If the anon method is pulled into a helper class,
12972 it needs to be `internal' not `private'. Fixes runtime behavior on
12975 2005-08-20 Martin Baulig <martin@ximian.com>
12977 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12978 scope if we don't already have it.
12980 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12981 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12984 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12987 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12988 is a partial class.
12990 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12992 The big constants rewrite
12993 Fix #75746, #75685 and more
12994 As a side effect saved 1MB for MWF ;-)
12996 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12997 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12998 enum based for corlib compilation.
13000 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
13003 * class.cs (FixedField.Define): Use ResolveAsConstant.
13005 * const.cs (IConstant): Interface constants and enums.
13006 (Const.ResolveValue): New method for constant resolvning.
13007 (ExternalConstant): Constants from imported assemblies.
13009 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
13010 conversion; like enums.
13011 (Constant.ToType): Converts this constant to different type.
13012 (Constant.Increment): Adds 1.
13014 * convert.cs (ImplicitConversionRequired): Simplified.
13016 * cs-parser.jay: Create EnumMember directly.
13018 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
13020 * doc.cs (GenerateEnumDocComment): Removed.
13022 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
13023 (ConvertIntLiteral): Removed.
13024 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
13026 * enum.cs (EnumMember): Implement IConstant.
13027 (Enum.IsValidEnumConstant): Removed.
13028 (Enum.GetNextDefaultValue): Removed.
13029 (Enum.FindMembers): Updated.
13030 (Enum.GenerateDocComment): Iterate enum members.
13032 * expression.cs (Cast.TryReduce): Handle enums correctly.
13033 (New.Constantify): Made public.
13034 (MemberAccess.DoResolve): Removed contant specific if(s).
13036 * literal.cs (NullLiteral): Implement new abstract methods.
13038 * statement.cs (GotoCase.Resolve): Use new constant methods.
13039 (SwitchLabel.ResolveAndReduce): Use new constant methods.
13041 * typemanager.cs (LookupEnum): Removed.
13042 (IsEnumType): Fixed to work with corlib.
13043 (RegisterConstant): Removed.
13044 (LookupConstant): Removed.
13045 (GetConstant): Changed to work with IConstant.
13047 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
13049 * location.cs : Fixed overflown (>255) column number.
13051 2005-08-03 Raja R Harinath <rharinath@novell.com>
13053 First cut of the qualified-alias-member feature.
13054 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
13056 * cs-parser.jay (DOUBLE_COLON): New token.
13057 (namespace_or_type_name): Add rule for recognizing
13058 qualified-alias-members.
13059 (primary_expression): Likewise.
13060 (element_access): Allow QualifiedAliasMember as a possible
13061 type-bearing expression.
13062 (local_variable_type, local_variable_pointer_type): Likewise.
13063 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
13064 aliases in the current and enclosing namespace declarations.
13065 (NamespaceEntry.UsingAlias): Add CS0440 warning.
13066 * decl.cs (MemberName.is_double_colon): New.
13067 (MemberName.MemberName): Add new constructor for alias-member.
13068 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
13069 * expression.cs (QualifiedAliasMember): New expression type.
13071 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13073 * location.cs : it borked when no argument was specified.
13075 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13077 * location.cs : tiny ToString() format fix.
13079 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13081 * statement.cs : oops, it was missing.
13083 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13085 A set of fixes for precise line/column location.
13088 "token" field now holds a file/line "delta", a line number offset
13089 from the segment, and a column number. See also:
13090 http://lists.ximian.com/pipermail/mono-devel-list/2004-
13091 December/009508.html
13092 Removed static IsNull. Use instance IsNull property instead.
13093 * cs-tokenizer.cs :
13094 For some tokens it stores Location. For Identifier it stores
13095 LocatedToken which is a pair of string name and location.
13096 Column numbers are adjusted only at getChar().
13098 Use Location.ToString() for reporting (it now contains column).
13100 Largely modified to use LocatedToken instead of
13101 string (IDENTIFIER), and to acquire Location from some tokens.
13102 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
13103 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
13105 Now MemberName holds Location. DeclSpace.ctor() receives Location
13106 as a parameter. Removed extra parameters to all derived classes.
13107 Replaced Location.IsNull() with instance property.
13108 * assign.cs, expression.cs :
13109 Added .ctor() overload that omits Location.
13111 Added "nameEscaped" flag that indicates the identifier was escaped
13112 in the source file. This fixes bug #57047.
13114 2005-08-02 Marek Safar <marek.safar@seznam.cz>
13116 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
13117 New method, looking for lo-case imported cls type.
13119 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
13122 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
13124 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
13126 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
13127 all_imported_types.
13128 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
13130 Optimized to save 3.5 MB for SWF compilation.
13132 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13134 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
13135 (PartialContainer.Create): Moved logic AddToContainer.
13136 (PartialContainer.MarkForDuplicationCheck): Shares name.
13138 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
13141 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
13143 (Namespace.GetSignatureForError): New method.
13145 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
13146 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
13148 2005-08-01 Raja R Harinath <rharinath@novell.com>
13151 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
13152 member lookup rather than qualifier_type, since qualifier_type can
13155 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13157 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
13160 2005-07-31 Miguel de Icaza <miguel@novell.com>
13162 * statement.cs: Copy the local exception into the exception
13163 captured local. Fixes 75674
13165 2005-07-31 Raja R Harinath <harinath@gmail.com>
13168 * expression.cs (Invocation.OverloadResolve): Don't report error
13169 CS1501 if error CS1502 has been reported.
13170 (New.DoResolve): Delegate CS1501 reporting to
13171 Invocation.OverloadResolve.
13174 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
13175 invariant-meaning-in-block property in an enclosing block if
13178 2005-07-29 Marek Safar <marek.safar@seznam.cz>
13180 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
13181 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
13182 (Switch.CheckSwitch): Just save 50kb for SWF.
13184 2005-07-27 Martin Baulig <martin@ximian.com>
13186 * anonymous.cs (CaptureContext.AddField): Added
13187 `AnonymousContainer am' argument; compute its toplevel scope if
13188 it's not already computed. Fixes #75649.
13190 2005-07-26 Raja R Harinath <rharinath@novell.com>
13193 * class.cs (Constructor.Emit): Reset block to null if the block
13196 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13198 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
13200 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13202 * class.cs (MethodData.Define): Check whether accessor implementing
13203 interface is public.
13205 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
13207 2005-07-22 Marek Safar <marek.safar@seznam.cz>
13210 * namespace.cs (LookupType): Moved same type check to...
13212 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
13213 with the same name.
13215 2005-07-21 Raja R Harinath <rharinath@novell.com>
13217 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
13218 already found a typebuilder.
13219 * class.cs (MethodCore.IsDuplicateImplementation): Compare
13220 MemberNames, not strings.
13222 * const.cs (Error_ExpressionMustBeConst):
13223 Rename from Error_EpressionMustBeConst.
13224 * const.cs, class.cs, statement.cd: Update.
13226 2005-07-21 Marek Safar <marek.safar@seznam.cz>
13230 * const.cs (Const.LookupConstantValue): Report missing contant expression
13232 (Error_EpressionMustBeConstant): Only one error method.
13234 * class.cs, statement.c: Updated.
13236 2005-07-20 Raja R Harinath <rharinath@novell.com>
13238 * statement.cs (Block.Flags): Add back HasVarargs.
13239 (Block.flags): Make protected.
13240 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
13242 * typemanager.cs (types, typecontainers, user_types): Remove.
13243 (UserTypes, TypeContainers): Likewise.
13244 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
13245 (CleanUp, Reset): Update.
13246 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
13247 (GetNestedType): Use Type.GetNestedType.
13248 (CoreLookupType): Take two arguments, the namespace and the
13249 basename of the type. Update to use the Namespace.Lookup
13251 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
13252 (RealMemberLookup): Use IsNestedChildOf instead of playing with
13253 string concatenation and substring matches.
13254 * class.cs, enum.cs, delegate.cs: Update to changes.
13256 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13258 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13259 Expression and made virtual.
13261 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13262 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13264 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13266 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13269 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13272 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13275 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13276 AssemblyCultureAttribute is not used on executable.
13279 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13281 2005-07-16 Raja R Harinath <rharinath@novell.com>
13284 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13285 New. Reports CS0252/CS0253.
13286 Mostly taken from preliminary patch by Duncak Mak.
13287 (Binary.DoResolveOperator): Store results of operator lookup.
13288 Use them to detect if we need to warn about unintended reference
13291 2005-07-15 Raja R Harinath <rharinath@novell.com>
13294 * namespace.cs (Namespace.Lookup): Add back location parameter.
13295 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13296 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13298 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13299 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13300 (Namespace.LookupType): ... this.
13301 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13303 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13304 purported to handle pointers.
13305 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13308 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13310 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13313 2005-07-15 Raja R Harinath <rharinath@novell.com>
13315 * namespace.cs (Namespace.Lookup): Drop location parameter.
13316 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13317 (NamespaceEntry.Lookup): ... this.
13318 (NamespaceEntry.Error_AmbiguousTypeReference):
13319 Move here from DeclSpace.
13320 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13322 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13323 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13324 Move to NamespaceEntry.
13325 * delegate.cs, expression.cs: Update to changes.
13327 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13329 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13330 CheckAttributeType and refactored.
13331 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13332 ResolveAsTypeTerminal error handling.
13333 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13335 (GetSignatureForError): Print errors in same way.
13338 * codegen.cs: Reflect attribute GetSignatureForError change.
13341 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13343 * namespace.cs (UsingEntry): Refactored to make fields private.
13346 statement.cs: Error_UnexpectedKind has extra parameter.
13348 2005-07-14 Raja R Harinath <rharinath@novell.com>
13350 * ecore.cs (IAlias): Remove.
13351 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13352 that implement the interface.
13353 * namespace.cs (Namespace): Likewise.
13354 (Namespace.declspaces): Renamed from 'defined_names'.
13355 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13356 DeclSpace instead of an IAlias.
13357 * tree.cs (Tree.AddDecl): Update.
13359 2005-07-12 Raja R Harinath <rharinath@novell.com>
13361 * statement.cs (Block.Flags); Remove HasVarargs.
13362 (Block.HasVarargs): Move to ToplevelBlock.
13363 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13364 (Block.Variables): Make protected. Initialize variable hashtable
13366 (Block.AddVariable): Update.
13367 (Block.Resolve): Update to changes.
13368 (ToplevelBlock.HasVarargs): New boolean.
13369 (ToplevelBlock.ThisVariable): Move here from Block.
13370 (ToplevelBlock.AddThisVariable): Likewise.
13371 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13372 * expression.cs (This.ResolveBase): Update to changes.
13373 (ArglistAccess.DoResolve): Likewise.
13375 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13378 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13380 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13381 not used and not used & assigned.
13382 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13384 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13387 * expression.cs (Is.DoResolve): null is never provided type.
13389 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13392 * cs-parser.jay: Less strict event error rule to catch more errors.
13394 2005-07-08 Martin Baulig <martin@ximian.com>
13396 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13397 gettter (allowed) or setter (not allowed).
13399 * class.cs (Accessor): Implement IIteratorContainer.
13400 (Accessor.Yields): New public field.
13401 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13402 per-accessor basis.
13405 (get_accessor_declaration, set_accessor_declaration): Set the
13406 `yields' flag on the accessor, not the property.
13407 (property_declaration): Do the iterators check on a per-accessor
13408 basis and not for the whole property.
13410 2005-07-08 Martin Baulig <martin@ximian.com>
13412 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13413 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13415 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13418 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13419 (ExtractSecurityPermissionSet): Cope with self referencing security
13420 attributes properly.
13422 * driver.cs (SetOutputFile): Made public property OutputFile.
13424 2005-07-07 Raja R Harinath <rharinath@novell.com>
13427 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13428 has_nonstatic_fields. Make into a FieldBase pointer.
13429 (TypeContainer.AddField): Add CS0282 check.
13430 (TypeContainer.EmitType): Update.
13432 2005-07-06 Miguel de Icaza <miguel@novell.com>
13434 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13435 compare if they start with __.
13437 2005-07-06 Raja R Harinath <rharinath@novell.com>
13439 * statement.cs (Switch.SwitchGoverningType): Only look at
13440 UserCasts that don't need implicit standard conversions to one of
13441 the allowed switch types (Fixes test-322.cs).
13442 (LocalInfo.Resolve): Re-enable sanity-test.
13444 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13446 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13448 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13450 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13452 2005-07-06 Raja R Harinath <rharinath@novell.com>
13455 * ecore.cs (SimpleName.GetSignatureForError): Add.
13456 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13457 (MemberAccess.GetSignatureForError): Add.
13459 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13461 The big error and warning messages review.
13491 * typemanager.cs: Updated.
13493 * class.cs: (MethodCore.SetYields): Moved here to share.
13494 (PropertyMethod.Define): Moved iterator setup here.
13496 * iterators.cs: Add orig_method to have full access to parent
13499 2005-07-05 Raja R Harinath <rharinath@novell.com>
13501 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13502 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13503 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13504 variable of struct type.
13505 * expression.cs (Unary.ResolveOperator): Update to change.
13506 (Indirection.VerifyFixed): Likewise.
13507 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13508 (ParameterReference.VerifyFixed): Value parameters are fixed.
13509 (This.VerifyFixed): Treat 'this' as a value parameter.
13510 * statement.cs (LocalInfo.IsFixed): Remove.
13512 2005-07-01 Martin Baulig <martin@ximian.com>
13514 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13515 `ec.EmitThis ()' to get the correct scope.
13517 2005-07-01 Martin Baulig <martin@ximian.com>
13519 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13520 instance is a ParameterReference; fixes #75299.
13522 2005-07-01 Martin Baulig <martin@ximian.com>
13524 Reverted Marek's latest patch (r46725):
13525 - it contains structural changes which are neither mentioned in
13526 the ChangeLog nor explained anywhere; for example the additional
13527 argument of EmitContext's and Iterator's .ctor's and the
13528 TypeContainer.DefineMembers() change.
13529 - structural changes like this should go in in seperate patches
13530 and not be hidden in a huge patch which just seems to affect
13531 warnings and errors.
13532 a big and hard to understand patch.
13533 - it breaks iterators and causes regressions, for instance in
13536 2005-06-30 Raja R Harinath <rharinath@novell.com>
13539 * expression.cs (Indexers.map): Remove.
13540 (Indexers.Append): Filter out inaccessible setters and getters.
13541 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13544 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13545 Refactored from ...
13546 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13547 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13548 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13549 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13551 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13554 * class.cs (FieldBase.GetInitializerExpression): One more field
13557 2005-06-28 Miguel de Icaza <miguel@novell.com>
13559 * pending.cs: Do not define a proxy if the base method is virtual,
13560 it will be picked up by the runtime (bug 75270).
13562 2005-06-08 Martin Baulig <martin@ximian.com>
13564 The big Iterators rewrite :-)
13566 * iterators.cs: Rewrite this to use the anonymous methods framework.
13568 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13569 before the TypeContainers; see 2test-21.cs.
13572 (TypeContainer.DefineType): Don't create a new EmitContext if we
13573 already have one (this only happens if we're an Iterator).
13574 (TypeContainer.Define): Also call Define() on all our iterators.
13575 (Method.CreateEmitContext): Added support for iterators.
13578 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13579 (AnonymousContainer.CreateMethodHost): Moved here from
13580 AnonymousMethod and made abstract.
13581 (AnonymousContainer.CreateScopeType): New abstract method.
13582 (AnonymousContainer.IsIterator): New public property.
13583 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13584 get the ScopeTypeBuilder rather than manually defining it here.
13585 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13588 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13589 before RootContext.DefineTypes().
13591 * codegen.cs (EmitContext.RemapToProxy): Removed.
13592 (EmitContext.CurrentAnonymousMethod): Changed type from
13593 AnonymousMethod -> AnonymousContainer.
13594 (EmitContext.ResolveTopBlock): Protect from being called twice.
13595 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13596 (EmitContext.EmitThis): Removed the iterators hacks; use the
13597 anonymous methods framework for that.
13600 (ToplevelBlock.Container): Make this a property, not a field.
13601 (ToplevelBlock.ReParent): New public method; move the
13602 ToplevelBlock into a new container.
13603 (Foreach.TemporaryVariable): Simplify.
13605 2005-06-05 Martin Baulig <martin@ximian.com>
13607 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13608 (Block.AddTemporaryVariable): New public method; creates a new
13609 `LocalInfo' for a temporary variable.
13610 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13612 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13613 non-iterator variables.
13615 2005-06-05 Martin Baulig <martin@ximian.com>
13617 * statement.cs (Foreach.TemporaryVariable): Create the
13618 LocalBuilder in the Emit phase and not in Resolve since in some
13619 situations, we don't have an ILGenerator during Resolve; see
13620 2test-19.cs for an example.
13622 2005-06-04 Martin Baulig <martin@ximian.com>
13624 **** Merged r45395 from GCS ****
13626 The big Foreach rewrite - Part II.
13628 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13629 with `PropertyInfo ienumerator_getcurrent'.
13631 * codegen.cs (VariableStorage): Removed.
13634 (Foreach): Derive from Statement, not ExceptionStatement.
13635 (Foreach.CollectionForeach): New nested class. Moved all the code
13636 dealing with collection foreach here.
13637 (Foreach.ForeachHelperMethods): Removed.
13638 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13640 2005-05-23 Martin Baulig <martin@ximian.com>
13642 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13643 don't need to. Fix #75014.
13645 2005-05-20 Martin Baulig <martin@ximian.com>
13647 Merged r44808 from GMCS.
13649 * class.cs (TypeContainer.CircularDepException): Removed.
13650 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13651 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13652 (CS0146) and interface (CS0529) dependencies here.
13654 2005-06-21 Raja R Harinath <rharinath@novell.com>
13656 * expression.cs (Invocation.EmitCall): Fix initialization
13657 'this_call' to reflect current behaviour. Fix indentation.
13659 * convert.cs (FindMostEncompassedType): Add two trivial special
13660 cases (number_of_types == 0 || number_of_types == 1).
13661 (FindMostEncompasingType): Likewise.
13663 2005-06-17 Raja R Harinath <rharinath@novell.com>
13665 Some cleanups preparing for the fix of #75283.
13666 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13668 (EventExpr.InstanceResolve): Likewise.
13669 (EventExpr.DoResolve): Remove redundant checks.
13671 2005-06-10 Duncan Mak <duncan@novell.com>
13673 * cs-tokenizer.cs (process_directives): New flag for controlling
13674 the processing of preprocessor directives.
13675 (x_token): After seeing a '#', return Token.NONE instead of going
13676 to handle_preprocessing_directive() when not processing
13677 directives. This avoids unnecessary processing during the token peek in
13682 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13683 the existing error reporting methods instead of Report.Error.
13685 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13686 after Raja's rewrite.
13688 2005-06-08 Miguel de Icaza <miguel@novell.com>
13690 * class.cs: Small fix.
13692 2005-06-08 Raja R Harinath <rharinath@novell.com>
13695 * class.cs (GetPartialBases): Fix return value check of
13696 part.GetClassBases.
13698 2005-06-07 Raja R Harinath <rharinath@novell.com>
13700 Ensure that partial classes are registered in their enclosing
13701 namespace. Initial part of fix of #75160.
13702 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13703 Register declspace with namespace here, not in
13704 DeclSpace.RecordDecl.
13705 * cs-parser.jay: Pass namespace to RecordDecl.
13706 * class.cs (PartialContainer.Create): Likewise.
13707 (ClassPart.DefineType): New sanity-check. Throws an exception if
13709 * decl.cs (Declspace.RecordDecl): Remove.
13710 * namespace.cs (NamespaceEntry.DefineName): Remove.
13712 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13714 * rootcontext.cs: Reset TargetExt as well.
13716 2005-06-03 Raja R Harinath <rharinath@novell.com>
13718 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13719 -langversion:ISO-1.
13721 2005-06-02 Raja R Harinath <rharinath@novell.com>
13723 Fix #75080, cs0119.cs.
13724 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13726 (Expression.Resolve): ... this. Use it. Remove bogus code
13727 allowing ExprClass.Type and ExprClass.Namespace for
13728 ResolveFlags.VariableOrValue.
13729 (Expression.Resolve) [1-argument variant]: Change default resolve
13730 flags based on language version.
13731 (Expression.Error_UnexpectedKind): Use a simple string array
13732 rather than an ArrayList.
13733 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13734 not ExprClass.Type.
13735 (TypeOfVoid.DoResolve): Likewise.
13736 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13737 flags argument -- it always has the same value.
13739 2005-05-31 Raja R Harinath <rharinath@novell.com>
13742 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13743 Use it in the error message.
13744 * assign.cs, expression.cs, statement.cs: Update.
13746 2005-05-30 Raja R Harinath <rharinath@novell.com>
13749 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13750 the "almostMatchedMember" case too.
13751 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13752 that failed the accessibility checks to 'almost_match'.
13754 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13756 * attribute.cs: Use internal MethodBuilder methods to set
13757 ExactSpelling and SetLastError on PInvoke methods, instead
13758 of passing them via charset. Fixes #75060.
13760 2005-05-27 Raja R Harinath <rharinath@novell.com>
13762 * parameter.cs (Parameter): Remove TODO comment.
13763 (Parameter.DefineParameter): Remove Location parameter.
13764 (Parameters.LabelParameters): Likewise.
13765 * class.cs (Constructor.Emit): Update to change.
13766 (MethodData.Emit): Likewise.
13767 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13768 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13770 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13773 Removed Parameters.Location and added Parameter.Location instead.
13774 Removed Location parameter from Emit() and GetSignature().
13781 Modified all related calls.
13783 2005-05-26 Raja R Harinath <rharinath@novell.com>
13785 Improve user-defined conversion handling.
13786 * convert.cs (GetConversionOperators): Rewrite. Return only the
13787 applicable operators.
13788 (AddConversionOperators): New. Helper for GetConversionOperators.
13789 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13790 there is only one most encompassed/encompassing type.
13791 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13792 "applicable operator" handling.
13793 (UserConversion): Move cache here from GetConversionOperators.
13794 Directly cache the chosen operator, rather than the whole
13796 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13797 case. Allow conversion of decimal to sbyte and byte too.
13798 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13799 New static methods. Used to avoid allocating EmptyExpressions in
13802 2005-05-24 Duncan Mak <duncan@novell.com>
13804 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13805 another class, used in Convert.ExplicitNumericConversion.
13806 (CastToDecimal): New class, similar to above, but casts to
13807 System.Decimal, used in Convert.ImplicitNumericConversion and also
13808 in explicit convesion from double/float to decimal.
13810 * convert.cs (ImplicitNumericConversion): Handle implicit
13811 conversions to System.Decimal.
13812 (ExplicitNumericConversion): handle explicit conversions to
13817 2005-05-20 Miguel de Icaza <miguel@novell.com>
13819 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13820 know the type at this stage, just break through. Fixes #75008
13822 2005-05-19 Martin Baulig <martin@ximian.com>
13825 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13826 to disable error reporting.
13828 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13829 here since we don't want to report an error; see the new test-336.cs.
13831 2005-05-19 Raja R Harinath <rharinath@novell.com>
13833 * statement.cs (ToplevelBlock.GetParameterReference)
13834 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13835 Move here from class Block.
13836 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13837 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13839 2005-05-18 Martin Baulig <martin@ximian.com>
13844 (FlowBranching.Reachability): Add non-static public And() and Or()
13846 (FlowBranchingSwitch): New class; do the `break_origins' thing
13847 like in FlowBranchingLoop.
13848 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13849 reachability, not just locals and parameters.
13850 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13851 switch; MergeBreakOrigins() now takes care of that.
13853 2005-05-18 Martin Baulig <martin@ximian.com>
13855 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13856 a loop and may leave it, reset the barrier; fixes #74974.
13858 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13860 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13863 * cs-parser.jay: Catch more lexical errors.
13865 * report.cs: Add one more Error method.
13868 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13870 2005-05-17 Martin Baulig <martin@ximian.com>
13872 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13875 2005-05-16 Raja R Harinath <rharinath@novell.com>
13877 Fix test-382.cs. Emit values of decimal constants.
13878 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13880 (TypeContainer.AddField): ... this.
13881 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13882 with initializers to include 'Const's.
13883 (ClassPart.RegisterFieldForInitialization): Forward to
13885 * const.cs (Const.Const): Pass initializer to base class.
13886 (Const.Define): In case of decimal constants, register them for
13887 initialization in a static constructor.
13889 2005-05-14 Martin Baulig <martin@ximian.com>
13891 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13892 do not call ResolveUnreachable() on unreachable statements in
13893 here, see the comment in the source code.
13895 2005-05-13 Raja R Harinath <rharinath@novell.com>
13898 * expression.cs (BinaryResolveOperator): If one of the operands of
13899 an equality comparison is 'null' and the other is a pointer type,
13900 convert the null to a NullPointer.
13901 * convert.cs (ImplicitReferenceConversion): If the expression is a
13902 NullLiteral and the target type is a pointer type, return a
13903 NullPointer instead.
13904 (ImplicitConversionStandard): Likewise.
13906 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13908 * cs-parser.jay: Set readonly context based on special constructs.
13910 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13911 readonly variable error handling.
13913 * rootcontext.cs (EmitCode): Don't verify members when error
13916 * statement.cs (LocalInfo): Add reaodnly context information.
13917 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13919 2005-05-13 Raja R Harinath <rharinath@novell.com>
13921 * statement.cs (Block.Resolve): Revert change below. Modify fix
13922 for #74041 to initialize 'resolved' to false only for explicit
13923 blocks. Fixes #74873.
13925 2005-05-12 Raja R Harinath <harinath@gmail.com>
13928 * typemanager.cs (unmanaged_enclosing_types): New.
13929 (IsUnmanagedType): Avoid infloops by using
13930 'unmanaged_enclosing_types' to talk with recursive invocations.
13932 2005-05-13 Martin Baulig <martin@ximian.com>
13934 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13935 instance variable, not a local. Fix #74873.
13936 (Block.ResolveUnreachable): Set it to true here.
13938 2005-05-11 Duncan Mak <duncan@novell.com>
13940 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13941 continuing to process for 'arg'.
13942 (handle_preprocessing_directive): Check the argument of the #endif
13943 directive and report error CS1025 if there are any trailing
13946 According to the C# spec, having even whitespace after the #endif
13947 directive is illegal; however, because we call arg.TrimEnd ()
13948 beforehand, we have the same behavior as csc, allowing whitespace
13949 after the directive.
13953 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13957 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13958 (Constructor.GetObsoleteAttribute): Implemented correctly.
13960 2005-05-10 Martin Baulig <martin@ximian.com>
13962 * support.cs (ReflectionParameters.ParameterModifier): Use
13963 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13964 and `ParameterAttributes.In'. Fixes #74884.
13966 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13968 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13970 * expression.cs (Argument.GetParameterModifier): Turned to property.
13971 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13973 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13976 2005-05-09 Raja R Harinath <rharinath@novell.com>
13979 * decl.cs (MemberCache.AddMethods): Register override methods,
13980 rather than non-override methods.
13981 * typemanager.cs (RegisterOverride): New.
13982 (IsOverride): Update.
13984 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13988 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13989 recursive declaration.
13991 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13993 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13995 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13997 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13999 2005-05-05 Raja R Harinath <rharinath@novell.com>
14002 * decl.cs (DeclSpace.FamilyAccessible):
14003 Use TypeManager.IsNestedFamilyAccessible.
14005 Fix reopened #64812.
14006 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
14009 2005-05-04 Raja R Harinath <rharinath@novell.com>
14010 Abin Thomas <projectmonokochi@rediffmail.com>
14011 Anoob V E <projectmonokochi@rediffmail.com>
14012 Harilal P R <projectmonokochi@rediffmail.com>
14015 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
14016 allow access to all static members.
14018 2005-05-04 Martin Baulig <martin@ximian.com>
14020 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
14022 2005-05-04 Martin Baulig <martin@ximian.com>
14026 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
14027 section at the end; make things work if `default' is not the last
14030 2005-05-04 Martin Baulig <martin@ximian.com>
14034 * statement.cs (Switch): Replaced the `got_default' field with a
14035 `default_section' one.
14036 (Switch.CheckSwitch): Set `default_section' here.
14037 (Switch.Resolve): If we're a constant switch and the constant is
14038 not found, use the default section.
14040 2005-05-03 Martin Baulig <martin@ximian.com>
14042 * expression.cs (ArrayAccess.EmitGetLength): New public method.
14044 * statement.cs (Foreach.ArrayForeach): New nested class.
14045 (Foreach.TemporaryVariable): New nested class.
14046 (Foreach.EmitArrayForeach): Removed; this is now in the new
14047 ArrayForeach class.
14049 2005-05-03 Raja R Harinath <rharinath@novell.com>
14051 * pending.cs (BaseImplements): Move the #74773 fix here. This is
14053 (VerifyPendingMethods): Revert change below.
14055 * typemanager.cs (IsOverride, RegisterNonOverride): New.
14056 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
14057 that used to trigger warning -28. Remove warning -28.
14058 * expression.cs (Invocation.OverloadResolve): Use
14059 TypeManager.IsOverride to distinguish override methods.
14062 * pending.cs (VerifyPendingMethods): If a base type implements the
14063 requested interface, don't bother checking individual methods of
14064 the base type. As a side-effect, this prevents the creation of
14065 unnecessary proxies.
14067 2005-05-02 Martin Baulig <martin@ximian.com>
14071 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
14072 Also `And' the locals if the old vector is null.
14073 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
14074 null; in this case we basically reset all the variables.
14076 2005-05-02 Martin Baulig <martin@ximian.com>
14080 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
14081 Added `FlowBranching branching' argument; always `and' the
14082 variables instead of `or'ing them unless we're an infinite loop.
14084 * statement.cs (While.Resolve): Create a new sibling unless we're
14087 2005-05-02 Martin Baulig <martin@ximian.com>
14091 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
14092 arguments; use it instead of creating a new TopLevelBlock.
14093 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
14094 our ConstructorInitializer.
14097 (TopLevelBlock.TopLevelBranching): New public property.
14098 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
14099 and create our `TopLevelBranching'.
14101 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
14102 anonymous method host, use `block.TopLevelBranching' rather than
14103 creating a new branching.
14105 2005-04-20 Miguel de Icaza <miguel@novell.com>
14107 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
14108 a ScopeInfo, if any of the current children is a child of the new
14109 entry, move those children there.
14111 2005-04-30 Martin Baulig <martin@ximian.com>
14113 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
14114 at the beginning of a SwitchSection. Fix #73335.
14116 2005-04-27 Marek Safar <marek.safar@seznam.cz>
14119 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
14121 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
14122 (FieldExpr.DoResolve): Obsolete members are ignored for field
14125 2005-04-26 Marek Safar <marek.safar@seznam.cz>
14127 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
14128 of arrays detection.
14130 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
14132 (Field.VerifyClsCompliance): Volatile fields are not compliant.
14134 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
14137 2005-04-25 Ben Maurer <bmaurer@ximian.com>
14139 * cs-parser.jay: Use the prefered version of -unsafe in error
14142 2005-04-22 Marek Safar <marek.safar@seznam.cz>
14144 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
14147 2005-04-20 John Luke <john.luke@gmail.com>
14149 * driver.cs: fix typo in error message, --outout to --output
14151 2005-04-20 Marek Safar <marek.safar@seznam.cz>
14153 * codegen.cs (InRefOutArgumentResolving): New field.
14155 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
14156 fields outside contructor.
14158 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
14160 2005-04-19 Miguel de Icaza <miguel@novell.com>
14162 * anonymous.cs (CaptureContext.EmitParameterInstance): The
14163 parameter code was not completed ever, so it was not as up-to-date
14164 as local variables. Must finish it.
14166 The bug fix was to compare the Toplevel of the block, not the
14167 current block. Thanks for Ben for pointing this out.
14169 2005-04-19 Raja R Harinath <rharinath@novell.com>
14171 * decl.cs (AddMethods): Use the declaring type of the problem
14172 method to determine if we want to squash a warning.
14174 2005-04-19 Marek Safar <marek.safar@seznam.cz>
14176 * attribute.cs: Removed debug output.
14178 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
14180 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
14183 2005-04-18 Raja R Harinath <rharinath@novell.com>
14186 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
14187 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
14188 all null comparisons against reference types.
14190 2005-04-18 Marek Safar <marek.safar@seznam.cz>
14193 * class.cs (TypeContainer.CircularDepException) New nested
14195 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
14196 (TypeContainer.DefineType): Removed error, reset InTransit before
14198 (Class.DefineType): Throw exception when is in Transit.
14199 Catch exception and report error.
14200 (Struct.DefineType): Throw exception when is in Transit.
14201 Catch exception and report error.
14202 (Interface.DefineType): Throw exception when is in Transit.
14203 Catch exception and report error.
14205 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
14206 handle nested exception handlers.
14208 * flowanalysis.cs (InTryWithCatch): New method, search for try with
14211 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
14212 InFinally and InCatch storage.
14214 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
14215 (Catch.Resolve): Set and Restore ec.InCatch.
14216 (Try.Resolve): Set and Restore ec.InFinally.
14217 (Try.HasCatch): True when try has catch.
14219 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
14221 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
14222 for the same event member, so exclude such cases from warning 419.
14225 2005-04-16 Miguel de Icaza <miguel@novell.com>
14227 * expression.cs (Binary.ResolveOperator): Apply patch from John
14228 Luke to fix bug 59864: operators &, | and ^ on enumerations
14229 require that the same enum type on both sides.
14231 * driver.cs: Add warnings to old flag usage, this is to assist
14232 people who produce Makefiles and hope that the Makefiles will be
14235 * class.cs (TypeContainer.EmitType): Moved the definition of the
14236 special $PRIVATE$ field from the resolve phase to the Emit phase.
14237 During resolve we do not know if we are a struct with
14238 HasExplicitLayout, we know this only after the attributes for the
14241 Set the FieldOffset to zero on the dummy field that we create for
14242 the class. Fixes 74590.
14244 2005-04-16 Raja R Harinath <rharinath@novell.com>
14247 * ecore.cs (PropertyExpr.resolved): New.
14248 (DoResolve): Use it to handle a case of double resolution here.
14249 Handle a case of identical-name-and-type-name.
14250 * expression.cs (ArrayCreation.CheckIndices): Avoid double
14251 resolution by storing the results of expression resolution back
14252 into the "probes" array.
14254 2005-04-15 Raja R Harinath <rharinath@novell.com>
14256 Fix cs0208-7.cs and cs0208-8.cs.
14257 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14258 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14259 error reporting to point out the reason a struct is not unmanaged.
14261 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14263 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14264 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14266 2005-04-13 Raja R Harinath <rharinath@novell.com>
14269 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14270 IdenticalNameAndTypeName here.
14271 (EventExpr.InstanceResolve): Likewise.
14273 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14275 C# 2.0 DefaultCharSetAttribute implementation
14277 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14278 which allows us to set GlobalNamespace for every resolve.
14279 (Attribute.ResolveArguments): Cut from Resolve.
14280 (Attribute.GetCharSetValue): Returns CharSet named argument.
14281 (Attribute.DefinePInvokeMethod): Gets default charset from
14283 (GlobalAttribute.ResolveAsTypeStep): Override.
14284 (GlobalAttribute.ResolveArguments): Override.
14286 * class.cs (TypeAttr): Is protected.
14288 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14289 (ModuleClass.DefaultCharSetType): New memeber.
14290 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14292 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14293 charset from module.
14295 * delegate.cs (TypeAttr): Override.
14296 (Delegate.DefineType): Use this TypeAttr.
14298 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14299 at very early stage (before types are defined) to resolve model
14300 module attributes. It will probably not work with corlib but it
14303 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14304 charset from module.
14306 * typemanager.cs (default_charset_type): New type.
14308 2005-04-13 Raja R Harinath <rharinath@novell.com>
14310 * decl.cs (MemberCache.AddMethods): Don't warn if
14311 System.Object.Finalize has buggy MethodAttributes.
14313 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14316 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14318 * doc.cs : detect ambiguous reference to overloaded members.
14319 Fixed bug #71603. MS 1.1 csc does not detect it.
14321 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14323 * doc.cs : delegates must not be referenced with parameters.
14326 2005-04-12 Miguel de Icaza <miguel@novell.com>
14328 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14330 2005-04-10 Miguel de Icaza <miguel@novell.com>
14332 * driver.cs (MainDriver): Stop processing if the CLS stage found
14335 (CompilerCallableEntryPoint.InvokeCompiler): Always
14336 reset after execution; Take a TextWriter argument for the
14339 * report.cs: Use the error stream instead of hardcoding stderr.
14341 2005-04-09 Miguel de Icaza <miguel@novell.com>
14343 * class.cs: Reduce code paths to test, too small of an
14344 optimization to make it worth the extra testing. Always perform
14347 2005-04-08 Raja R Harinath <rharinath@novell.com>
14350 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14351 operators that had errors reported on them.
14353 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14355 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14357 (Attribute.Resolve): Add named argument type checking.
14359 * class.cs (FixedField.Define): Use IsPrimitiveType
14361 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14363 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14364 unsafe parameter types.
14366 * statement.cs (Using.ResolveExpression): Add better error description.
14368 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14370 2005-04-08 Raja R Harinath <rharinath@novell.com>
14373 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14374 AttributeUsageAttribute in the emitcontext of the attribute class,
14375 not in the emitcontext of the attributable entity it was attached to.
14376 * cs-parser.jay: Use 'current_class', not 'current_container',
14377 when creating a GlobalAttribute.
14379 2005-04-08 Alp Toker <alp@atoker.com>
14381 * pending.cs: The fix to #58413 failed to compile methods implementing
14382 interfaces with/without params modifiers and vice versa, even though
14383 params modifiers aren't part of the signature. Make the modifier check
14384 less strict as in csc.
14386 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14387 Anoob V E <projectmonokochi@rediffmail.com>
14388 Harilal P R <projectmonokochi@rediffmail.com>
14391 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14392 modifiers of pending methods.
14393 (PendingImplementation.PendingImplementation): Initialize it.
14394 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14395 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14396 with ParameterData. Add check for modifiers.
14397 * class.cs (MethodData.Define): Update to changes.
14399 2005-04-07 Raja R Harinath <rharinath@novell.com>
14401 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14403 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14405 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14408 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14411 * typemanager.cs: Registered RequiredAttributeAttribute.
14413 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14415 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14416 Warning CS0169 is back at level 3.
14417 (IMethodData.SetMemberIsUsed): New method.
14419 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14420 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14422 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14424 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14426 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14429 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14432 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14433 to avoid the problems with nested types.
14435 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14436 Anoob V.E <projectmonokochi@rediffmail.com>
14437 Harilal P.R <projectmonokochi@rediffmail.com>
14438 Raja R Harinath <rharinath@novell.com>
14441 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14443 * typemanager (GetConstructor): Make public.
14445 2005-04-05 John Luke <john.luke@gmail.com>
14446 Raja R Harinath <rharinath@novell.com>
14449 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14450 struct too. Return false quicker in a few cases.
14451 (VerifyUnManaged): Use it.
14453 2005-04-05 Raja R Harinath <rharinath@novell.com>
14456 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14457 not 'unreachable_seen'.
14459 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14461 * attribute.cs (Attribute.GetValue): Removed unused.
14463 * codegen.cs (CodeGen.TrimExt): Removed unused.
14465 * cs-parser.jay (output): Removed unused.
14467 * cs-tokenizer.cs (hex_digits): Removed unused.
14469 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14471 * expression.cs (Indirection.LoadExprValue): Removed unused.
14472 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14474 * iterators.cs (Iterator.param_types): Removed unused.
14476 * statement.cs (Goto.block): Removed unused.
14477 (ToplevelBlock.did): Removed unused.
14478 (Switch.ResolveConstantSwitch): Removed unused.
14480 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14482 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14485 2005-04-01 Raja R Harinath <rharinath@novell.com>
14487 Fix #74232 and cs0208-3.cs.
14488 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14489 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14490 unmanaged type. Don't use FieldBuilders when 't' is a
14491 TypeBuilder. Use ModFlags and MemberType fields.
14492 * class.cs (MemberBase.member_type): Rename from MemberType.
14493 (MemberBase.MemberType): New property. Determines member_type on
14495 (MemberBase.DoDefine): Don't initialize MemberType here.
14496 (FieldMember.Define): Likewise.
14498 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14501 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14502 Attributes are emitted there.
14504 2005-04-01 Raja R Harinath <rharinath@novell.com>
14506 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14507 keyword in 'partial enum' too.
14508 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14510 Report from Kamil Skalski <nazgul@omega.pl>.
14513 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14514 have partial containers too.
14516 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14517 in block' checks to Block.CheckInvariantMeaningInBlock.
14518 * statement.cs (Block.GetKnownVariableInfo): Make private.
14519 (Block.IsVariableUsedInChildBlock): Remove.
14520 (Block.IsVariableUsedInBlock): Likewise.
14521 (Block.CheckInvariantMeaningInBlock): New. Show location of
14522 conflicting declaration.
14523 (Block.AddVariable): Make error messages less long-winded and more
14524 specific. Show location of conflicting declaration.
14525 * parameter.cs (Parameters.Location): New readonly property.
14527 2005-03-31 Raja R Harinath <rharinath@novell.com>
14529 Clean up semantics of invoking ResolveMemberAccess.
14530 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14531 can have an instance, ensure that we pass in a non-TypeExpression
14532 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14533 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14534 argument. Update to changes and simplify.
14535 (FieldExpr.Emitinstance): Remove CS0120 check.
14536 (PropertyExpr.EmitInstance): Likewise.
14537 * expression.cs (Argument.Resolve): Likewise.
14538 (Invocation.DoResolve): Update to changes in semantics of
14539 InstanceExpression.
14541 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14544 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14547 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14549 2005-03-31 Raja R Harinath <rharinath@novell.com>
14551 Fix difference in behaviour with commandline invocation.
14552 * driver.cs (Driver.Reset): New.
14553 (CompilerCallableEntryPoint): Call it.
14555 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14556 variable" warnings if the boolean expression failed to resolve.
14558 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14560 * attribute.cs: Fix the union of several permissions when some of them
14561 are unrestricted (so the result isn't an unrestricted permission set).
14564 2005-03-30 Raja R Harinath <rharinath@novell.com>
14566 * ecore.cs (MemberExpr): New class. Convert from interface
14568 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14569 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14571 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14572 (MethodGroupExpr.IsExplicitImpl): Remove.
14573 (Expression.GetFieldFromEvent): Remove.
14574 (SimpleName.MemberStaticCheck): Remove.
14575 (SimpleName.DoSimpleNameResolve): Update to changes.
14576 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14577 (MemberAccess.IdenticalNameAndTypeName): Remove.
14578 (MemberAccess.error176): Move to MemberExpr.
14579 (MemberAccess.DoResolve): Update to changes.
14580 (BaseAccess.DoResolve): Likewise.
14582 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14584 C# 2.0 Conditional attribute class implementation
14586 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14587 Analyzes class whether it has attribute which has ConditionalAttribute
14588 and its condition is not defined.
14590 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14591 (Class.IsExcluded): New method. Search for at least one defined
14592 condition in ConditionalAttribute of attribute class.
14594 2005-03-30 Raja R Harinath <rharinath@novell.com>
14596 * ecore.cs (PropertyExpr): Derive from Expression, not
14597 ExpressionStatement.
14598 (PropertyExpr.EmitStatement): Remove.
14600 2005-03-29 Raja R Harinath <rharinath@novell.com>
14603 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14604 internal field "value__" of an enum be private. The examples for
14605 "value__" that I found on MSDN all used FieldAttributes.Private.
14607 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14608 Don't mention IL method attribute names.
14610 Fix #47991. Remove a TODO.
14611 * statement.cs (Block.Toplevel): Make into a field.
14612 (Block.Parameters): Move into ToplevelBlock.
14613 (Block.known_variables): Rename from child_variable_names.
14614 (Block.Block): Remove variants that take Parameters. Initialize
14615 'Toplevel' with the immediately surrounding toplevel block.
14616 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14617 LocalInfo parameter.
14618 (Block.GetKnownVariableInfo): New.
14619 (Block.IsVariableNameUsedInChildBlock): Update.
14620 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14621 the block, even though it may not be in scope.
14622 (Block.AddVariable): Remove Parameters parameter. Use
14623 Toplevel.Parameters instead.
14624 (Block.AddConstant): Remove Parameters parameter.
14625 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14626 (Block.IsParamaterReference): Likewise.
14627 (Block.IsLocalParameter): Likewise. Simplify a lot.
14628 (ToplevelBlock.Parameters): New. Moved from Block.
14629 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14630 initialize Parameters to a non-null value.
14631 * cs-parser.jay: Update to changes.
14632 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14633 simple names that mean different things in the same block. Use
14634 Block.IsVariableNameUsedInBlock.
14636 2005-03-28 Raja R Harinath <rharinath@novell.com>
14638 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14639 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14640 GetTypeHandle. It is possible for a reflected type to derive from
14641 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14642 System.Array during mscorlib compilation).
14643 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14644 contain a method_hash, don't create one either. Don't create a
14645 deep copy of the base cache's method_hash.
14646 (MemberCache.SetupCache): Rename back from DeepCopy.
14647 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14648 already initialized. If we see an override function, add its
14649 underlying base virtual function to the member_hash too.
14651 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14653 2005-03-26 Raja R Harinath <harinath@acm.org>
14656 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14657 fails to resolve, ensure that the LHS is still resolved as an
14660 2005-03-25 Raja R Harinath <harinath@acm.org>
14662 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14664 (Enum.current_ec): Remove.
14665 (Enum.LookupEnumValue): Remove EmitContext argument.
14666 Just uses the one created during DefineType.
14667 (Enum.FindMembers): Update.
14668 * expression.cs (MemberAccess.DoResolve): Update.
14670 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14672 * assign.cs (Assign.DoResolve): Check for CS1717 when
14673 source and target are same (uses Equals).
14675 * expression.cs (LocalVariableReference, ParameterReference,
14676 This): Implemented Equals, GetHashCode.
14678 * statement.cs (Block.GetParameterReference): Removed useless
14681 2005-03-22 Raja R Harinath <rharinath@novell.com>
14684 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14685 blocks before deciding whether the error is cs0136 or cs0128.
14687 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14688 (using_alias_directive, using_namespace_directive): Pass
14689 MemberName, not an expression to Namespace.UsingAlias and
14691 (MakeName): Use the MemberName of the namespace.
14692 * namespace.cs (Namespace.MemberName): New.
14693 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14694 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14696 * decl.cs (MemberName.Name): Make readonly.
14697 (MemberName.FromDotted): New "constructor".
14698 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14699 (MemberCore.Name): Compute from MemberName on demand.
14700 (MemberCore.SetMemberName): Provide a way to change the
14702 (MemberCore.AddToContainer): Don't take a fullname parameter.
14703 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14704 fully qualified name of the container to the member name.
14705 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14706 only if the type is a member of the root container.
14707 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14708 MemberName.Left rather than searching for an embedded ".".
14709 (PartialContainer.CreatePart): Update to changes in RootContext.
14710 (MemberBase.ShortName): Turn into a property. Use
14711 MemberCore.SetMemberName.
14712 (MemberBase.ExplicitInterfaceName): Remove.
14713 (MemberBase.UpdateMemberName): Remove.
14714 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14715 (PropertyBase.SetMemberName): New override.
14716 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14717 (Tree.GetDecl): New.
14718 (Tree.AllDecls): Rename from Decls.
14719 * attribute.cs, enum.cs, report.cs: Update to changes.
14720 * driver.cs (MainDriver): Use MemberName.FromDotted on
14721 RootContext.MainClass.
14723 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14725 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14728 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14730 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14732 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14733 property accessor modifiers.
14735 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14736 fixed buffer attribute (CS1716).
14737 (PropertyMethod.HasCustomAccessModifier): When property accessor
14738 has custom modifier.
14740 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14742 (PropertyExpr.DoResolveLValue): Add CS0272.
14744 2005-03-17 Miguel de Icaza <miguel@novell.com>
14746 * convert.cs: When converting to a pointer, use the proper Conv.U
14747 or Conv.I depending on the source data type.
14749 * cs-tokenizer.cs: Make the size for large decimal constants,
14752 2005-03-17 Martin Baulig <martin@ximian.com>
14754 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14755 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14757 2005-03-17 Martin Baulig <martin@ximian.com>
14759 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14760 to bool so we can return an error condition.
14761 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14764 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14766 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14769 2005-03-16 Raja R Harinath <rharinath@novell.com>
14771 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14772 Refactor to avoid traversing the list of assemblies, and to avoid
14773 string concatenation.
14774 * typemanager.cs (guid_attr_type): Remove.
14775 (negative_hits, pointers, references): Remove hashes.
14777 (GetConstructedType): New. Uses type_hash to handle constructed
14778 types (arrays, references, pointers).
14779 (GetReferenceType, GetPointerType): Use it.
14780 (GetNestedType): New. Uses type_hash to handle nested types of
14782 (LookupType, LookupTypeDirect): Remove.
14783 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14784 'types' hash and LookupTypeReflection directly.
14785 (params_string, params_object): Use GetConstructedType.
14786 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14788 (Namespace.Lookup): Use cached_types.
14789 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14790 provided by old TypeManager.LookupType.
14791 * rootcontext.cs (MakeFQN): Remove.
14792 * decl.cs (DeclSpace.MakeFQN): Likewise.
14793 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14794 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14795 TypeManager.GetConstructedType.
14796 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14798 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14800 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14803 * cs-parser.jay: Reports CS1527 for any namespace element.
14805 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14808 * expression.cs (ParameterReference.IsAssigned): Changed error to
14810 (Error_WrongNumArguments): Moved CS0245 detection here.
14812 * statement.cs (Return.Resolve): Add CS1622 report.
14814 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14816 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14818 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14820 * attribute.cs expression.cs: Get rid of some allocations.
14822 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14824 * doc.cs : just eliminate the latest change.
14826 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14828 * doc.cs : commented out the latest change. It breaks xml-030.cs
14830 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14832 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14833 fail. So invoke CreateType() in FindDocumentedType().
14835 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14837 * cs-tokenizer.cs : added IsKeyword().
14838 * doc.cs : Detect keyword incorrectly used as identifier.
14839 Allow identifiers prefixed by @.
14841 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14843 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14844 It caused exception in namespace resolving (again!).
14846 * class.cs (Class.ctor): Removed exit.
14847 (PropertyMethod.ctor): ditto.
14849 * codegen.cs (Codegen.Reset): Reset static data.
14850 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14852 * cs-tokenizer.cs (Cleanup): Removed.
14854 * driver.cs (GetSystemDir): Rewrote to one line command.
14855 It caused problem with unloaded dynamic modules.
14856 (UnixParseOption): Removed Exit.
14857 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14858 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14859 Now can be mcs used as library.
14861 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14864 * location.cs (Reset): Reset static data.
14866 * namespace.cs (Reset): Reset static data.
14868 * report.cs (Report.Reset): Reset static data.
14870 * rootcontext.cs (RootContext.Reset): Reset static data.
14872 * tree.cs (RootTypes.ctor): Use Location.Null
14874 * typemanager.cs (TypeManager.Reset): Reset static data.
14875 (CoreLookupType): Removed Exit.
14876 (TypeHandle.Reset): Reset static data.
14878 2005-03-10 Raja R Harinath <rharinath@novell.com>
14881 * typemanager.cs (ComputeNamespaces): Import namespaces from
14882 referenced modules too.
14884 2005-03-09 Raja R Harinath <rharinath@novell.com>
14886 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14889 2005-03-09 Raja R Harinath <rharinath@novell.com>
14891 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14892 enclosing DeclSpace. This ensures that a name-lookup populates
14893 more caches and there are fewer 'TypeExpression's. Carve out
14894 nested type lookup into ...
14895 (LookupNestedTypeInHierarchy): ... this.
14897 2005-03-09 Raja R Harinath <rharinath@novell.com>
14899 Clean up a few partial-class semantics.
14900 Fixes test-357.cs and cs1618-2.cs.
14901 * cs-parser.jay (struct_declaration): Use 'current_class' as
14902 parent of newly-created struct. Remove call to Register ().
14903 Use 'pop_current_class' to complete handing the current struct.
14904 (interface_declaration): Likewise.
14905 (class_declaration): Likewise.
14906 (enum_declaration): Use 'current_class' as parent of newly created
14908 (delegate_declaration): Likewise.
14909 (pop_current_class): New function. This is used to handle closing
14910 up the 'current_class' and 'current_container', and pointing them
14911 to the enclosing class/container.
14912 (CSharpParser): Initialize 'current_class' too.
14913 * decl.cs (MemberCore): Add check for invariant: a partial
14914 container is not a parsed entity, and thus does not enclose any
14916 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14917 (DeclSpace.BaseTypeExpr): Use it.
14918 (DeclSpace.LookupType): Add check for invariant.
14919 * class.cs (TypeContainer): Add check for invariant: a nested
14920 class should have the same NamespaceEntry as its enclosing class.
14921 (TypeContainer.EmitFieldInitializers): Make virtual.
14922 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14924 (TypeContainer.Register): Remove.
14925 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14926 null. Use TypeResolveEmitContext for resolving base types and
14927 interfaces. Move initialization of Parts.TypeBuilder here from
14929 (TypeContainer.DefineNestedTypes): ... here.
14930 (PartialContainer): Take a Namespace not a NamespaceEntry.
14931 (PartialContainer.Create): Don't use Register. Call the
14932 appropriate Add... function directly.
14933 (ClassPart): Take both the PartialContainer and the enclosing
14934 class as constructor arguments.
14935 (ClassPart.EmitFieldInitializers): Override.
14936 (ClassPart.PartFindNestedTypes): Remove.
14937 (FieldBase.GetInitializerExpression): Resolve the initializer
14938 expression in the emit context of the enclosing class.
14939 * tree.cs (RootTypes): Remove Register ().
14941 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14943 * cs-parser.jay: Removed CS0134.
14945 * driver.cs: Removed CS1901.
14947 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14948 for predefined types.
14950 2005-03-07 Duncan Mak <duncan@novell.com>
14952 * codegen.cs (Save): Catch UnauthorizedAccessException as
14953 well. Fixes bug #73454.
14955 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14957 * cs-tokenizer.cs (xtoken): Add CS1035.
14959 * class.cs (MethodData.Define): Add CS0683.
14960 (FieldMember.ctor): Add CS0681.
14962 2005-03-07 Raja R Harinath <rharinath@novell.com>
14964 * ecore.cs (SimpleName.DoResolve): Rename from
14965 SimpleName.DoResolveAllowStatic.
14966 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14967 Pass 'intermediate' flag to MemberStaticCheck.
14968 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14969 of "intermediate" lookups via MemberAccess.
14970 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14971 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14973 2005-03-07 Raja R Harinath <rharinath@novell.com>
14976 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14977 slipped in because of variable names that are identical to a
14978 builtin type's BCL equivalent ('string String;', 'int Int32;').
14979 (PropertyExpr.EmitInstance): Likewise.
14981 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14983 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14985 * report.cs (warning_ignore_table): Made public.
14987 2005-03-04 Raja R Harinath <rharinath@novell.com>
14990 * class.cs (MethodData.Emit): Pass 'container' to
14991 container.GetObsoleteAttribute instead of 'container.Parent'.
14993 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14995 * cs-parser.jay: Add 1534 error test.
14997 * iterators.cs (Yield.CheckContext): Add error 1629.
14998 (Iterator.ctor): Save unsafe modifier.
14999 (MoveNextMethod.DoEmit): Restore unsafe context.
15001 * namespace.cs (UsingAlias): Better error message.
15003 2005-03-03 Dan Winship <danw@novell.com>
15005 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
15006 the warning message [#73219]
15008 2005-03-03 Raja R Harinath <rharinath@novell.com>
15010 Fix compile with MCS 1.0.0.0.
15011 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
15012 w_restore to not depend on string constant folding.
15014 2005-03-03 Raja R Harinath <rharinath@novell.com>
15016 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
15017 CS0246 check to users who passed 'silent = false'.
15018 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
15020 (SimpleName.SimpleNameResolve): Update.
15021 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
15022 (MemberAccess.IdenticalNameAndTypeName): Update.
15023 * doc.cs (FindDocumentedTypeNonArray): Update.
15025 2005-03-03 Raja R Harinath <rharinath@novell.com>
15027 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
15028 * parameters.cs (ComputeAndDefineParameters): Remove.
15029 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
15030 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
15031 Use GetParameterInfo.
15033 2005-03-02 Marek Safar <marek.safar@seznam.cz>
15035 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
15037 2005-03-02 Raja R Harinath <rharinath@novell.com>
15039 Unify DeclSpace.LookupType and DeclSpace.FindType.
15040 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
15041 is in charge of defining nested types on demand.
15042 (DeclSpace.LookupType): Use it when the current_type is a
15043 TypeBuilder. Use LookupTypeDirect for reflected types.
15044 (DeclSpace.FindType): Remove.
15045 (DeclSpace.LookupInterfaceOrClass): Likewise.
15046 (DeclSpace.DefineTypeAndParents): Likewise.
15047 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
15048 DeclSpace.LookupType.
15049 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
15050 * typemanager.cs (LookupType): Simplify.
15051 (AddUserType): Remove type from negative_hits.
15052 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
15053 * class.cs (TypeContainer.FindMembers): Move handling of nested
15055 (TypeContainer.FindMembers_NestedTypes): ... here.
15056 (TypeContainer.FindNestedType): Implement override.
15057 (ClassPart.FindNestedType): Delegate to PartialContainer.
15058 (ClassPart.PartFindNestedType): Looks up the nested types of the
15061 2005-03-02 Martin Baulig <martin@ximian.com>
15063 * class.cs (TypeContainer.DoDefineMembers): We also need a default
15064 static constructor in static classes.
15066 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
15068 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
15069 sizeParamIndex is not specified.
15071 2005-03-01 Marek Safar <marek.safar@seznam.cz>
15074 * report.cs (WarningMessage.IsEnabled): Missing null check.
15076 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15078 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
15079 in the fields and not in the properties.
15081 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
15083 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
15086 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15088 * attribute.cs: Small refactoring (improved robustness).
15089 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
15090 (ValidateGuid): Removed.
15091 (Resolve): Removed referenced to above mentioned.
15092 (GetAttributeUsage): Made private and changed to work without
15094 (GetIndexerAttributeValue): Don't crash.
15095 (GetConditionalAttributeValue): Ditto.
15096 (GetClsCompliantAttributeValue): Ditto.
15097 (ExtractSecurityPermissionSet): All attributes exceptions are
15099 (GetPropertyValue): New helper.
15100 (GetMethodImplOptions): New method.
15101 (DefinePInvokeMethod): Reuse common code. Implemented handling of
15102 some missing properties.
15104 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
15105 (Method.ApplyAttributeBuilder): Updated.
15107 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
15110 2005-02-28 Raja R Harinath <rharinath@novell.com>
15113 * report.cs (Report.SymbolRelatedToPreviousError): Handle
15114 non-simple types (array, pointer, reference).
15116 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15118 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
15120 * class.cs (MethodCore.IsDuplicateImplementation): Special error
15122 (Method.CheckBase): Catch wrong destructor here.
15123 (MethodData.Define): Add errors 550, 668.
15125 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
15127 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
15129 * pending.cs (VerifyPendingMethods): Add error 551.
15131 * typemanager.cs (CSharpName): Next error report helper.
15133 2005-02-25 Marek Safar <marek.safar@seznam.cz>
15135 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
15136 attributes. Removed useless attribute double check.
15137 It saves almost 2MBs for corlib.
15139 2005-02-25 Raja R Harinath <rharinath@novell.com>
15142 * statement.cs (ExpressionStatement.Resolve): Make robust to being
15143 called twice in case of error.
15145 2005-02-23 Chris Toshok <toshok@ximian.com>
15147 Fix compiler portions of #72827.
15148 * statement.cs (Block.Emit): call Begin/EndScope on the
15149 EmitContext instead of the ILGenerator.
15151 * codegen.cs (EmitContext.BeginScope): new method, call
15152 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
15154 (EmitContext.BeginScope): same, but EndScope and CloseScope
15156 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
15157 offset and call the superclass's OpenScope(int) with it.
15158 (SymbolWriter.CloseScope): get the current il
15159 offset and call superclass's CloseScope(int) with it.
15161 2005-02-23 Marek Safar <marek.safar@seznam.cz>
15163 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
15164 CS1677 for out and ref as well.
15166 * class.cs (Method.Define): Add error CS1599 detection.
15168 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
15170 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
15172 * delegate.cs (Delegate.Define): Add error CS1599 detection.
15174 * support.cs.cs (ModifierDesc): New helper method.
15176 2005-02-23 Raja R Harinath <rharinath@novell.com>
15177 Abin Thomas <projectmonokochi@rediffmail.com>
15178 Anoob V E <projectmonokochi@rediffmail.com>
15179 Harilal P R <projectmonokochi@rediffmail.com>
15181 Fix #57851, #72718.
15182 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
15183 MemberLookup (used for error reporting) actually returns a result.
15184 Fix error report number (122, not 112).
15186 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
15187 Anoob V E <projectmonokochi@rediffmail.com>
15188 Harilal P R <projectmonokochi@rediffmail.com>
15191 * pending.cs (PendingImplementation.GetAbstractMethods):
15192 Find NonPublic members too.
15194 2005-02-22 Marek Safar <marek.safar@seznam.cz>
15196 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
15199 * class.cs (MethodCore.CheckMethodAgainstBase):
15200 Add error 239 report.
15202 2005-02-21 Raja R Harinath <rharinath@novell.com>
15205 * expression.cs (Invocation.IsApplicable): Make public.
15206 (Invocation.IsParamsMethodApplicable): Likewise.
15207 * delegate.cs (Delegate.VerifyApplicability): Don't use
15208 Invocation.VerifyArgumentCompat for parameter applicability
15209 testing. Use Invocation.IsApplicable and
15210 Invocation.IsParamsMethodApplicable.
15212 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15214 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
15216 * class.cs (Operator.Define): Add error 217 report.
15218 2005-02-21 Raja R Harinath <rharinath@novell.com>
15220 * namespace.cs (UsingEntry.Resolve): Undo change below.
15222 2005-02-21 Raja R Harinath <rharinath@novell.com>
15225 * ecore.cs (Expression.MemberLookupFailed): Add argument to
15226 disable the error message when the extended MemberLookup also
15228 (Expression.MemberLookupFinal): Update.
15229 (SimpleName.DoSimpleNameResolve): Update.
15230 * expression.cs (MemberAccess.ResolveNamespaceOrType):
15231 Don't use MemberLookupFinal.
15232 (New.DoResolve): Update.
15233 (BaseAccess.CommonResolve): Update.
15235 2005-02-21 Raja R Harinath <rharinath@novell.com>
15238 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
15239 occured previously, don't resolve again.
15241 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15244 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
15245 argument. Call ResolveAttributeUsage for unresolved.
15246 when types doesn't match ctor arguments.
15248 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
15249 for nested attribute classes.
15250 (Class.attribute_usage): Removed.
15251 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
15252 for attribute class.
15254 * ecore.cs (IsAttribute): Removed.
15256 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15258 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15260 (attribute_types): Removed.
15261 (EmitCode): Global attributes are emited as the latest.
15263 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15265 * class.cs (EmitFieldInitializers): Don't emit field initializer
15266 for default values when optimilization is on.
15268 * constant.cs (Constant.IsDefaultValue): New property.
15270 * driver.cs: Add /optimize handling.
15274 * literal.cs: Implement new IsDefaultValue property.
15276 * rootcontext.cs (Optimize): New field, holds /optimize option.
15278 2005-02-18 Raja R Harinath <rharinath@novell.com>
15280 Fix crasher in re-opened #72347.
15281 * namespace.cs (Namespace.Lookup): Return null if
15282 DeclSpace.DefineType returns null.
15285 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15287 2005-02-18 Raja R Harinath <rharinath@novell.com>
15289 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15290 now returns null if it cannot resolve to an lvalue.
15291 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15292 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15293 returned null. Remove check for SimpleName.
15294 (EventExpr.DoResolveLValue): New.
15295 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15296 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15298 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15299 avoid CS0131 error.
15300 (Unary.ResolveOperator): Move CS0211 check ...
15301 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15303 (Unary.DoResolveLValue): Simplify.
15304 (AddressOf.DoResolveLValue): New.
15305 (ArrayAccess.DoResolveLValue): New.
15307 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15309 * attribute.cs (Attribute.Resolve): Add arguments casting for
15310 when types doesn't match ctor arguments.
15312 2005-02-16 Raja R Harinath <rharinath@novell.com>
15314 Fix parts of #63202.
15315 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15316 lookup of operator in base type. Ensure that all checks happen
15317 when the operator resolves to an "op_..." method.
15319 2005-02-15 Raja R Harinath <rharinath@novell.com>
15322 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15323 'ignore_cs0104' parameter. Pass it to ...
15324 (NamespaceEntry.Lookup): ... this.
15325 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15326 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15327 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15328 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15329 Update. Request that cs0104 errors be ignored.
15330 (ComposedCast.ResolveAsTypeStep): Update.
15332 2005-02-14 Raja R Harinath <rharinath@novell.com>
15335 * expression.cs (Invocation.BetterFunction): Remove support for
15336 comparing virtual functions and their overrides.
15337 (Invocation.IsOverride): New.
15338 (Invocation.OverloadResolve): Don't consider 'override' functions
15339 during candidate selection. Store them in a lookaside list.
15340 If the selected method is a 'virtual' function, use the list to
15341 find any overrides that are closer to the LHS type.
15343 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15345 * expression.cs (New.DoResolve): Add complex core type reduction.
15346 (New.Constantify): Converts complex core type syntax like 'new int ()'
15347 to simple constant.
15349 2005-02-14 Raja R Harinath <rharinath@novell.com>
15351 * decl.cs (EntryType.EntryType): New constructor to create an
15352 updated copy of a cache entry.
15353 (MemberCache.AddMethods): Use it.
15354 (MemberCache.ClearDeclaredOnly): Remove.
15355 (MemberCache.MemberCache): Update.
15357 2005-02-11 Miguel de Icaza <miguel@novell.com>
15359 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15360 variable. This one is represents the actual low-level declaration
15361 of the method, as opposed to the semantic level `IsStatic'.
15363 An anonymous method which is hosted into a static method might be
15364 actually an instance method. IsStatic would reflect the
15365 container, while MethodIsStatic represents the actual code
15368 * expression.cs (ParameterReference): Use the new MethodIsStatic
15369 instead of IsStatic.
15371 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15372 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15373 set on the current EmitContext.
15375 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15376 resolve our casted expression as an LValue. This triggers the
15377 proper LValue processing that is later required by Assign.
15381 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15383 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15385 C# 2.0 Fixed buffer implementation
15387 * anonymous.cs: Update after RegisterHelperClass renaming.
15389 * attribute.cs (AttributeTester.fixed_buffer_cache):
15390 Cache of external fixed buffers.
15391 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15392 implementation if field is fixed buffer else null.
15395 (TypeContainer.AddField): Accept FieldMember instead of Field.
15396 (FieldBase.IsFieldClsCompliant): Extracted code from
15397 VerifyClsCompliance descendant customization.
15398 (FixedField): New class handles fixed buffer fields.
15399 (FixedFieldExternal): Keeps information about imported fixed
15401 (IFixedField): Make access to internal or external fixed buffer
15404 * cs-parser.jay: Add fixed buffer parsing.
15406 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15409 * expression.cs (Indirection): Extended implementation to accept
15410 fixed buffer field.
15411 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15412 (ElementAccess.MakePointerAccess): Get type as parameter.
15413 (DoResolve): Add fixed buffer field expression conversion.
15414 (DoResolveLValue): Ditto.
15415 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15416 (ArrayPtr): Derives from FixedBufferPtr.
15417 (ArrayPtr.Emit): Add extra emit for array elements.
15419 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15421 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15422 for compiler generated types.
15423 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15425 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15426 and consume less memory.
15427 (Fixed.Resolve): Add fixed buffer case.
15429 * typemanager.cs (compiler_generated_attr_ctor,
15430 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15431 (HasElementType): Add our own implementation to work on every
15434 2005-02-11 Miguel de Icaza <miguel@novell.com>
15436 * anonymous.cs (CaptureContext): Track whether `this' has been
15439 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15440 only captured `this' if it was implicitly done (instance
15441 methods/variables were used).
15443 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15444 `this' must be captured.
15446 2005-01-30 Miguel de Icaza <miguel@novell.com>
15448 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15449 is null it means that there has been no need to capture anything,
15450 so we just create a sibling.
15452 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15454 Just a partial fix. The other half is fairly elusive.
15456 2005-02-10 Raja R Harinath <rharinath@novell.com>
15458 Fix #52586, cs0121-4.cs.
15459 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15460 and return a hashtable.
15461 (MemberCache.ClearDeclaredOnly): New.
15462 (MemberCache.MemberCache): Update to change. Make a deep copy of
15463 the method_hash of a base type too.
15464 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15465 type methods. Overwrite entries with the same MethodHandle so
15466 that the ReflectedType is correct. The process leaves in base
15467 virtual functions and their overrides as distinct entries.
15468 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15469 matters since it was boxed in a ArrayList before.
15470 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15472 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15473 case of a virtual function and its override (choose the overload
15475 (Invocation.OverloadResolve): Avoid 'override' members during
15476 'applicable_type' calculation.
15478 2005-02-09 Raja R Harinath <rharinath@novell.com>
15480 Combine two near-redundant caches.
15481 * typemanager.cs (method_params): Rename from method_internal_params.
15482 (TypeManager.GetParameterData): New. Replace
15483 Invocation.GetParameterData.
15484 (TypeManager.LookupParametersByBuilder): Remove.
15485 * expression.cs (Invocation.method_parameter_cache): Remove.
15486 (Invocation.GetParameterData): Remove.
15488 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15491 2005-02-08 Raja R Harinath <rharinath@novell.com>
15494 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15495 TypeManager.multicast_delegate_type is null, resolve it by looking
15496 up "System.MulticastDelegate".
15497 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15499 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15500 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15501 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15504 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15505 (LabeledStatement.AddReference): New. Set 'referenced'.
15506 (Goto.Resolve): Use it.
15508 2005-02-05 John Luke <john.luke@gmail.com>
15510 * driver.cs: remove duplicate -doc line in Usage ()
15512 2005-02-04 Raja R Harinath <rharinath@novell.com>
15514 * location.cs (Location.AddFile): Fix CS2002 error report.
15516 2005-02-02 Martin Baulig <martin@ximian.com>
15518 * delegate.cs (Delegate.DefineType): Report an internal error if
15519 TypeManager.multicast_delegate_type is null. See bug #72015 for
15522 2005-02-02 Raja R Harinath <rharinath@novell.com>
15524 Fix a crasher in a variant of #31984.
15525 * const.cs (Constant.CheckBase): New override that defers the
15526 new-or-override check in case the base type hasn't been populated
15528 (Constant.Define): Ensure the new-or-override check is performed.
15530 2005-02-01 Duncan Mak <duncan@ximian.com>
15532 * const.cs (LookupConstantValue): Check that `ce' is not null
15533 before calling GetValue ().
15535 2005-02-01 Raja R Harinath <rharinath@novell.com>
15537 Fix test-334.cs (#69519).
15538 * cs-parser.jay (using_alias_directive): Pass in an expression to
15539 NamespaceEntry.UsingAlias.
15540 (using_namespace_directive): Pass in an expression to
15541 NamespaceEntry.Using.
15542 (namespace_name): Don't flatten to a string.
15543 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15544 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15546 (NamespaceEntry.UsingEntry): Likewise.
15547 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15549 (NamespaceEntry.LookupForUsing): Remove.
15550 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15552 (NamespaceEntry.Lookup): Remove support for dotted names.
15554 2005-02-01 Raja R Harinath <rharinath@novell.com>
15556 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15558 (NamespaceEntry.ImplicitParent): Compute on demand.
15559 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15560 parallels the current.
15561 (NamespaceEntry.LookupForUsing): Use it.
15562 (NamespaceEntry.Lookup): If the current namespace-entry is
15563 implicit, don't search aliases and using tables.
15565 2005-02-01 Raja R Harinath <rharinath@novell.com>
15568 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15570 (TypeContainer.BaseCache): Compute on demand.
15571 (TypeContainer.FindMembers): Define constants and types if they're
15572 not already created.
15573 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15575 * const.cs (Constant.Define): Make idempotent.
15577 2005-01-29 Miguel de Icaza <miguel@novell.com>
15579 * pending.cs: Produce better code (no nops produced by using Ldarg
15582 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15583 i - 1' it should be arg + 1.
15587 2005-01-28 Raja R Harinath <rharinath@novell.com>
15589 * attribute.cs (Attribute.CheckAttributeType): Make private
15591 (Attribute.ResolveType): Make virtual.
15592 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15593 handling of RootContext.Tree.Types.
15595 2005-01-27 Raja R Harinath <rharinath@novell.com>
15597 Update attribute-handling to use the SimpleName/MemberAccess
15599 * cs-parser.jay (attribute): Pass in an expression to the
15600 constructors of Attribute and GlobalAttribute.
15601 * attribute.cs (Attribute): Take an expression for the name.
15602 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15603 passed in attribute name expression.
15604 (Attribute.CheckAttributeType): Use it.
15605 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15606 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15607 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15608 argument to prevent error messages if the lookup fails.
15610 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15612 * expression.cs (Indirection): Implemented IVariable interface
15613 to support indirection in AddressOf operator.
15614 (PointerArithmetic.Emit): Add optimalization for case where
15615 result can be precomputed.
15617 2005-01-26 Martin Baulig <martin@ximian.com>
15619 * class.cs (TypeContainer.AttributeTargets): Return the correct
15620 AttributeTargets depending on our `Kind' instead of throwing an
15621 exception; fixes #71632.
15623 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15626 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15629 2005-01-25 Raja R Harinath <rharinath@novell.com>
15632 * expression.cs (MemberAccess.DoResolve): Don't complain with
15633 cs0572 when the LHS of a member access has identical name and type
15636 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15639 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15641 Create custom PermissionSet only for PermissionSetAttribute.
15643 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15646 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15647 delegates in static class.
15649 2005-01-24 Martin Baulig <martin@ximian.com>
15651 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15652 merging an implicit block, just use its reachability.
15654 * statement.cs (Block.Resolve): Make the unreachable code check
15655 work wrt. implicit blocks; see test-337 from #63842.
15657 2005-01-21 Alp Toker <alp@atoker.com>
15659 * cs-parser.jay: destructor_declaration's container is PartialContainer
15660 not Class when partial types are used, so use Kind prop instead of
15663 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15665 * cs-parser.jay: Improve error reporting when an interface
15666 declares new types.
15668 2005-01-20 Dick Porter <dick@ximian.com>
15670 * support.cs: SeekableStreamReader fix from Sandor Dobos
15671 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15672 chars are read. Fixes bug 70369.
15674 2005-01-20 Raja R Harinath <rharinath@novell.com>
15676 * cs-parser.jay (catch_clause): Simplify current_block handling
15679 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15681 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15682 code with ImplicitStandardConversion to handle the implicit
15683 conversion of method groups into valid delegate invocations.
15685 The problem is that in parameter handling we were using this code
15686 path. Fixes bug #64698
15688 2005-01-19 Raja R Harinath <rharinath@novell.com>
15690 * cs-parser.jay: Fix several infelicities.
15691 - Avoid assigning to the parser value stack. Code like
15692 '$3 = null' is unclean. Synthesize a value for the code block
15694 - Avoid using oob_stack for storing location information. Use ...
15695 (_mark_): ... this. New (empty) rule. Saves the current location
15697 (foreach_statement): Avoid using oob_stack for current_block
15698 handling. Use technique used in for_statement and
15699 using_statement. Synthesize a value for the code block to store
15700 additional intermediate information.
15702 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15704 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15705 of a different type is only allowed to private fields of a
15706 containing type, not on fields of a base class.
15708 See test-174.cs and error cs0122-9.cs
15710 2005-01-13 Raja R Harinath <rharinath@novell.com>
15712 Fix test-335.cs (bug #58126).
15713 * cs-parser.jay (argument): Split out non-expression parts of the
15714 rule into 'non_simple_argument'.
15715 (invocation_expression): Support parenthesized invocations with
15716 multiple arguments, and with single non-simple arguments.
15718 2005-01-13 Raja R Harinath <rharinath@novell.com>
15720 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15723 2005-01-12 Raja R Harinath <rharinath@novell.com>
15725 Fix cs0038-1.cs, cs1640-6.cs.
15726 * ecore.cs (Expression.Resolve): Remove special-case for
15727 SimpleName in error-handling.
15728 (Expression.almostMatchedMembers): Relax access permission to
15730 (Expression.MemberLookupFailed): Handle duplicates in
15731 almostMatchedMembers list.
15732 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15733 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15734 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15735 overload if the passed in MemberInfo is a MethodBase.
15737 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15740 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15741 for non-CAS & merge permission sets properly.
15743 2005-01-11 Raja R Harinath <rharinath@novell.com>
15745 Improve standard-compliance of simple name and member access
15746 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15747 * ecore.cs (FullNamedExpression): New abstract base class
15748 for Namespaces and TypeExpressions.
15749 (ResolveFlags.SimpleName): Remove.
15750 (SimpleName): Remove support for dotted names.
15751 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15752 DeclSpace.FindType and DeclSpace.LookupType.
15753 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15754 (Expression.ExprClassName): Make member function.
15755 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15756 a namespace. Remove creation of dotted "SimpleName"s.
15757 (MemberAccess.DoResolve): Likewise.
15758 * decl.cs (DeclSpace.Cache): Make private.
15759 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15760 (DeclSpace.FindType): Update.
15761 (DeclSpace.LookupType): Move here from RootContext. Return a
15762 FullNamedExpression.
15763 * namespace.cs (Namespace): Derive from FullNamedExpression
15764 so that it can be part of expression resolution.
15765 (Namespace.Lookup): Return an FullNamedExpression.
15766 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15768 * rootcontext.cs (NamespaceLookup): Remove.
15769 (LookupType): Move to DeclSpace.
15770 * attribute.cs (CheckAttributeType): Update.
15771 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15772 (FindDocumentedTypeNonArray): Likewise.
15774 2005-01-11 Raja R Harinath <rharinath@novell.com>
15776 Fix cs0509.cs, cs1632.cs.
15777 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15778 is the same as IsInterface.
15779 (TypeContainer.GetClassBases): Likewise.
15780 * statement.cs (LabeledStatement.ig): New field.
15781 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15783 (LabeledStatement.DoEmit): Check that the label was created with
15784 the same ILGenerator.
15786 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15789 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15790 accessors to its properties.
15792 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15793 from accessors to property.
15795 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15798 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15799 only for overrides.
15801 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15803 * attribute.cs: Check for null and empty strings.
15805 I have lost another battle to Paolo.
15807 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15810 * class.cs (PropertyMethod): Set Parent field in ctors.
15811 (SetMethod.InternalParameters): Add unsafe switch hack.
15812 Override MarkForDuplicationCheck where it is appropriate.
15814 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15815 It says whether container allows members with the same name.
15816 Base default is no.
15817 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15818 Removed is_method parameter.
15820 2005-01-06 Duncan Mak <duncan@ximian.com>
15822 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15823 because the previous change led to incorrect reporting of CS1032
15824 ("Cannot define/undefine preprocessor symbols after first token in
15825 file"). Instead of using `tokens_seen' as the only flag that
15826 triggers CS1040, introduce `comments_seen'. This new flag is used
15827 to signify having seen comments on the current line, so it is
15828 unset after a newline.
15830 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15832 * doc.cs : When searching for a type, find nested type too.
15833 This fixes bug #71040.
15835 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15838 - Warn missing member comment on those classes which also does not
15839 have doc comments. Fixed bug #71041.
15840 - Don't warn missing doc comment on default constructor.
15843 2005-01-06 Duncan Mak <duncan@ximian.com>
15845 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15846 comments, set `tokens_seen' to true. This allows us to detect
15847 misplaced preprocessor directives (i.e. not at the beginning of
15848 the a line, nor after whitespaces). In that case, report error
15849 CS1040. This fixes bug #56460.
15851 * cs-parser.jay (interface_member_declaration): Add checks for
15852 IsExplicitImpl, and report CS0541 error if an interface member is
15853 defined as an explicit interface declaration.
15855 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15858 * class.cs (PropertyMethod): Set Parent field in ctors.
15859 (SetMethod.InternalParameters): Add unsafe switch hack.
15861 * decl.cs (MemberCore.Parent): Cannot be readonly.
15863 2005-01-06 Raja R Harinath <rharinath@novell.com>
15865 * decl.cs (DeclSpace.ResolveType): Remove.
15866 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15867 Merge in code from ...
15868 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15869 * class.cs, enum.cs: Update to changes.
15871 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15873 * anonymous.cs: Ensure that we init the scope of our parent if it
15874 has not been initialized yet.
15876 2004-12-30 Duncan Mak <duncan@ximian.com>
15878 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15879 if field.FieldBuilder is null. Fixes #70758.
15881 * convert.cs: Fixed some typos and updated some of the comments.
15882 (ImplicitStandardConversionExists):
15883 (TryImplicitIntConversion): If `target_type' is an interface and
15884 the type of `ic' implements this interface, return true or a new
15885 BoxedCast instead of null. This fixes #70468.
15887 2004-12-29 Duncan Mak <duncan@ximian.com>
15889 * expression.cs (Argument.Emit): Check that Expr is
15890 IMemoryLocation before casting to it, and report CS1510 otherwise.
15894 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15896 * statement.cs (Block.ThisVariable): remove the recursion here, to
15897 make the --profile more sane.
15899 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15901 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15902 assembly, by JB Evain.
15904 2004-12-17 Raja R Harinath <rharinath@novell.com>
15906 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15907 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15908 "parent" refers to enclosing type/class. "base" refers to superclass.
15910 2004-12-17 Raja R Harinath <rharinath@novell.com>
15912 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15913 Ensure that we only have GlobalAttributes.
15914 * attribute.cs (Attribute.Emit): Make non-virtual.
15915 (GlobalAttribute.Emit): Remove.
15916 (Attribute.Resolve): Make virtual.
15917 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15918 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15919 the argument. Don't create one.
15920 (Attribute.GetObsoleteAttribute): Likewise.
15921 (Attribute.GetClsCompliantAttributeValue): Likewise.
15922 * class.cs, decl.cs: Update to changes.
15924 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15926 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15928 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15930 * statement.cs (Foreach.Resolve): Add error 186 report.
15932 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15934 * expression.cs (Conditional.DoResolve): Add warning 429.
15936 * statement.cs (If.Resolve): Add warning 665.
15938 2004-12-16 Raja R Harinath <rharinath@novell.com>
15940 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15941 except when in the parser, and in GlobalAttribute.
15942 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15943 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15944 RootContext.Tree.Types.NamespaceEntry once work is done.
15945 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15946 and resets RootContext.Tree.Types.NamespaceEntry.
15948 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15950 * cs-parser.jay: Don't create a block for every variable.
15952 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15954 * location.cs: Provide extra information.
15956 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15957 variables from the captured environment, it is the ldarg_0.
15959 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15961 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15964 * class.cs: Changed warning level for 169 to avoid developer
15965 displeasure from warning flooding. It will be changed back when they
15966 fix most of current BCL warnings.
15968 * RootContext.cs: Pushed default WarningLevel to 3.
15970 * statement.cs: Removed unused variable.
15972 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15974 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15975 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15976 Add error 502 report.
15977 (StaticClass.DefineType): Add error 441 report.
15978 (Class.AllowedModifiersProp): New virtual property as temporary
15979 extension to AllowedModifiers.
15980 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15981 to share implementation with StaticClass and don't call virtual
15984 * driver.cs (MainDriver): Add error 1558 test.
15986 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15987 report. Moved error 36 test here.
15989 * statement.cs (Throw.Resolve): Add error 724 report.
15991 * typemanager.cs: Add out_attribute_type core type.
15993 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15995 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15997 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15999 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
16002 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
16004 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
16005 Add error 3023 report.
16006 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
16008 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
16011 2004-12-12 John Luke <john.luke@gmail.com>
16013 * driver.cs (AddArgs): take -- into account when
16014 adding arguments, fixes bug 65710
16016 2004-12-12 Martin Baulig <martin@ximian.com>
16018 * expression.cs (Unary.TryReduceNegative): Added support for
16019 SByteConstant and ByteConstant.
16020 (Unary.Reduce): Check error values from TryReduceNegative().
16022 2004-12-10 Marek Safar <marek.safar@seznam.cz>
16024 * attributes.cs (Attribute.Resolve): Avoid multiple error report
16025 and report exception as error 182.
16027 2004-12-10 Raja R Harinath <rharinath@novell.com>
16029 * driver.cs (Main): Fix message when there are warnings.
16031 2004-12-09 Miguel de Icaza <miguel@ximian.com>
16033 * delegate.cs: Fixed my fix from yesterday, sorry about that.
16035 2004-12-09 Marek Safar <marek.safar@seznam.cz>
16037 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
16038 Reduced number of warnings.
16040 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
16042 2004-12-08 Miguel de Icaza <miguel@ximian.com>
16044 * driver.cs: Removed message.
16046 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
16048 2004-12-08 <vargaz@freemail.hu>
16050 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
16052 2004-12-08 Martin Baulig <martin@ximian.com>
16054 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
16055 instead of a CS3002 for properties and indexer.
16057 2004-12-08 Martin Baulig <martin@ximian.com>
16059 * decl.cs (MemberName.ToString): Make this work again.
16061 2004-12-08 Marek Safar <marek.safar@seznam.cz>
16063 * attribute.cs (Resolve): Add error 591 detection.
16065 * class.cs (FieldMember.Define): Add error 1547 detection.
16066 (Indexer.Define): Add error 620 detection.
16067 (Operator.Define): Add error 590 detection.
16069 * ecore.cs: Missing argument for error 79.
16071 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
16074 2004-12-07 Marek Safar <marek.safar@seznam.cz>
16077 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
16080 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
16082 * cs-parser.jay : handle doc comments on implicit/explicit operators.
16083 Some operator comments were suppressed.
16084 * doc.cs : Implicit/explicit operator name in doc comments are like
16085 "op_Explicit(type)~returnType", so added suffix handling.
16087 2004-12-07 Martin Baulig <martin@ximian.com>
16090 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
16091 (MemberCore.GetClsCompliantAttributeValue): Likewise.
16092 (DeclSpace.ec): New protected field; store the EmitContext here.
16093 (DeclSpace.EmitContext): New public property; moved here from
16095 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
16098 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
16099 (Enum.Emit): Don't create a new EmitContext.
16101 * delegate.cs (Delegate.DefineType): Always create the
16104 * iterators.cs (Iterators.DefineIterator): Create a new
16105 EmitContext and store it in `ec'.
16107 2004-08-24 Martin Baulig <martin@ximian.com>
16110 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
16111 this for accessibility checks.
16112 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
16113 IsNestedFamilyAccessible.
16114 (TypeManager.IsSubclassOf): New method, do what the name actually
16117 2004-12-06 Raja R Harinath <rharinath@novell.com>
16119 Fix crash on cs0657-17.cs.
16120 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
16121 Use RootContext.Tree.Types, not 'new RootTypes ()'.
16122 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
16123 the case where the NamespaceEntry gets overwritten.
16125 2004-12-06 Marek Safar <marek.safar@seznam.cz>
16127 Fixed #69195, #56821
16128 * ecore.cs (ResolveBoolean): Tiny refactoring.
16130 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
16131 of right expression resolving when left is false constant and
16132 operator is LogicalAnd OR true constant and operator is LogicalOr.
16134 * statement.cs (ResolveUnreachable): Always reports warning.
16136 2004-12-05 Miguel de Icaza <miguel@ximian.com>
16138 * class.cs: Distinguish between 1721 and 1722 (just a little help
16139 for the programmer).
16141 2004-12-03 Miguel de Icaza <miguel@ximian.com>
16143 * delegate.cs: Only allow this on new versions of the language.
16145 2004-12-02 Duncan Mak <duncan@ximian.com>
16147 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
16149 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
16150 here as a static method. Take an additional bool out parameter
16151 `must_do_cs1540_check' for signaling to InstanceResolve.
16152 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
16153 member field from PropertyExpr class and made it an argument of
16154 the method instead.
16155 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
16156 check for MarshalByRefObject, and report CS0122 instead of CS1540.
16157 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
16158 and `remove_accessor' as well as InstanceResolve: report CS0122
16163 2004-12-03 Raja R Harinath <rharinath@novell.com>
16165 Fix test-327.cs, test-328.cs, and put in early infrastructure
16166 for eventually fixing #52697.
16167 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
16168 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
16169 from other methods.
16170 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
16171 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
16172 (VerifyUsing, error246): Update.
16173 * rootcontext.cs (RootContext.NamespaceLookup): Just use
16174 'NamespaceEntry.LookupNamespaceOrType'.
16176 2004-12-03 Martin Baulig <martin@ximian.com>
16178 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16179 method as our child, call AnonymousMethod.Compatible() on it.
16181 2004-12-03 Raja R Harinath <rharinath@novell.com>
16183 Disable XML documentation support in 'basic' profile.
16184 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
16185 Redirect XmlElement to System.Object.
16186 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
16187 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
16188 * mcs.exe.sources: Add doc-bootstrap.cs.
16189 * doc-bootstrap.cs: New file. Contains empty stub implementation
16192 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
16194 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
16195 comments are allowed.
16197 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16199 * delegate.cs: Add checks for subtypes in paramaters and return values
16200 in VerifyMethod () to add support for Covariance/Contravariance
16203 2004-12-02 Miguel de Icaza <miguel@ximian.com>
16205 * report.cs: Remove extra closing parenthesis.
16207 * convert.cs (Error_CannotImplicitConversion): If the name of the
16208 types are the same, provide some extra information.
16210 * class.cs (FieldBase): Use an unused bit field from the field to
16211 encode the `has_offset' property from the FieldMember. This saves
16212 a couple of Ks on bootstrap compilation.
16214 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16215 method as our child, return the AnonymousMethod resolved
16218 * expression.cs (New.DoResolve): Allow return values from
16219 NewDelegate to also include AnonymousMethods.
16223 2004-12-02 Marek Safar <marek.safar@seznam.cz>
16226 * attribute.cs (Resolve): Improved implementation of params
16227 attribute arguments.
16229 * support.cs (ParameterData): Add HasParams to be faster.
16231 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
16233 all things are for /doc support:
16235 * doc.cs: new file that supports XML documentation generation.
16236 * mcs.exe.sources: added doc.cs.
16238 Handle /doc command line option.
16239 Report error 2006 instead of 5 for missing file name for /doc.
16240 Generate XML documentation when required, after type resolution.
16242 Added support for picking up documentation (/// and /** ... */),
16243 including a new XmlCommentState enumeration.
16245 Added lines to fill Documentation element for field, constant,
16246 property, indexer, method, constructor, destructor, operator, event
16247 and class, struct, interface, delegate, enum.
16248 Added lines to warn incorrect comment.
16250 Added Documentation field (passed only when /doc was specified).
16252 Added DocComment, DocCommentHeader, GenerateDocComment() and
16253 OnGenerateDocComment() and some supporting private members for
16254 /doc feature to MemberCore.
16256 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16258 Added overriden DocCommentHeader.
16260 Added overriden DocCommentHeader and GenerateDocComment().
16262 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16264 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16265 unwrapping the enumeration values, chain to
16266 DoConstantNumericPromotions again, so we can promote things to the
16267 fundamental types (takes care of enums that are bytes, sbytes).
16271 2004-12-01 Raja R Harinath <rharinath@novell.com>
16273 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16274 Fix long-standing bug in type-lookup. Use FindType instead of
16275 LookupType when ec.ResolvingTypeTree.
16276 (Attribute.ResolveType, Attribute.Resolve)
16277 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16279 (Attributes.Search): Remove internal version. Update.
16280 (Attributes.SearchMulti): Update.
16281 (Attributes.GetClsCompliantAttribute): Remove.
16282 (Attributes.GetIndexerNameAttribute): Remove.
16283 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16284 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16285 * class.cs (Indexer.Define): Likewise.
16287 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16290 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16291 MarshallByReference members access.
16293 * expression.cs: Use CheckMarshallByRefAccess;
16294 Better error CS0197 message.
16296 * report.cs: Print whole related error message.
16298 2004-11-30 Raja R Harinath <rharinath@novell.com>
16300 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16301 the current directory to help debugging.
16303 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16305 * class (GetClassBases): Better error 60 report.
16306 (EventProperty): Disabled warning 67 detection.
16308 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16311 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16313 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16316 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16319 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16321 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16323 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16325 * attribute.cs (Attribute.Resolve): Refine error reporting and
16326 report a cs0117 if the identifier does not exist, to distinguish
16327 from 0617 which is a miss-use of the actual identifier.
16329 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16330 between cs0070 and cs0079.
16332 * class.cs (MemberBase.DoDefine): When reporting a wrong
16333 accessibility level, we use MethodCore to compare instead of
16334 Method (this was a regression in some refactoring effort).
16336 So now we correctly report cs0056 again.
16338 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16339 testing the target_type (which was known to be object_type) and
16340 not the source type (which is anonymous_method).
16342 Fixed reporting of error cs1660.
16344 * expression.cs (UserCast.Source): Expose the underlying cast.
16346 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16347 allowed types to find a match to int32 first (most common).
16349 In addition, it ignores any ImplicitUserConversions that did an
16350 internal implicit conversion (as the switch statement allows only
16351 one integral conversion to exist).
16353 * class.cs (PartialContainer.Create): rename `name' to
16354 `member_name' for clarity. Then replace the string calls with a
16355 call to MemberName.GetPartialName, as now using
16356 MemberName.ToString is an error (this is due to the side effects
16357 it had, that were fixed in the past).
16359 This will restore the error reporting on a number of partial class
16360 errors that were missusing this (and getting an exception as a
16361 results, which is now just a plain textual warning, because
16362 yyparse debug output would crash otherwise).
16364 2004-11-26 Raja R Harinath <rharinath@novell.com>
16366 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16368 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16370 * rootcontext.cs (LookupType): Make sure to cache lookups that
16371 don't give us a negative result. This saves about 5% of corlib
16374 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16376 * report.cs (AbstractMessage.Print): messages are sent to stderr
16378 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16379 non-interface in the list of interfaces (at this point, either
16380 parent was properly set, or a base class is being listed in the
16381 interfaces section).
16383 This flags error 1722, and resolves the crash from bug 69259.
16385 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16387 * statement.cs (Using.EmitExpressionFinally): make this work right
16388 for valuetypes. Fixes 69926.
16390 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16392 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16393 converted to an enum" here, before we try to change the underlying
16394 type. This code exists, but it is a different code path than the
16395 one used while encoding constants.
16397 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16398 old bug: when converting from the null literal to a pointer,
16399 return an EmptyCast, not the NullLiteral.
16401 This fixes #69921, the recent null_type changes probably made this
16402 bug more prominent.
16404 (ImplicitReferenceConversionExists): In addition, resynchronized
16405 the code here, so it matches the same code in
16406 ImplicitReferenceConversionExists for the `from any class-type S
16407 to any interface-type T'.
16410 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16412 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16414 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16416 * cs-parser.jay: Use verbosity accordingly.
16418 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16420 * expression.cs (Unary.ResolveOperator): Do not report warning;
16421 AddressOf reads from variable.
16423 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16425 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16429 * attribute.cs (Attributable): Removed CheckTargets.
16430 (Attributes.Emit): Explicit attribute targets are tested here.
16432 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16433 not enabled for interfaces.
16435 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16436 (GetAssemblyName): Ouch next bug there.
16438 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16440 * expression.cs: Error 275 added.
16442 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16444 Fix bug #69177 (Implemented decimal constant support)
16446 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16447 (BinaryFold): Add DecimalConstant.
16449 * const.cs (Define): Decimal constant
16451 (ChangeType): Add decimal type handling.
16452 (LookupConstantValue): Don't set value for decimal type but
16453 emit DecimalConstantAttribute. Needed for constant optimization.
16455 * constant.cs (ToDecimal): New method.
16456 (ConvertToDecimal): New method.
16457 (IntConstant): Implemented ConvertToDecimal.
16458 (DecimalConstant.Emit): Emit optimized version for decimals in
16461 * expression.cs (ResolveOperator): Changed order of constant
16462 reduction to work correctly with native types which have
16463 overloaded operators.
16464 (ResolveMemberAccess): Extract constant value from attribute
16467 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16469 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16470 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16471 (ChangeType): Decimal is special.
16472 (TypeToCoreType): Add decimal type.
16474 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16476 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16479 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16481 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16484 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16486 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16488 * pending.cs (PendingImplementation): Grab only interfaces.
16490 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16492 * statement.cs (ForeachHelperMethods): Add location member and
16493 error 202 detection.
16495 2004-11-19 Raja R Harinath <rharinath@novell.com>
16497 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16498 automatically handled by executable.make.
16499 (PROGRAM): Make profile-specific.
16501 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16503 * expression.cs (DoResolveBase): Fixed wrong warning for out
16506 2004-11-18 Martin Baulig <martin@ximian.com>
16508 Merged latest changes into gmcs. Please keep this comment in
16509 here, it makes it easier for me to see what changed in MCS since
16510 the last time I merged.
16512 2004-11-17 Raja R Harinath <rharinath@novell.com>
16514 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16515 (TypeHandle.GetMemberCache): New.
16516 (TypeHandle.TypeHandle): Update.
16517 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16518 (TypeManager.LookupParentInterfacesCache):
16519 Rename from LookupInterfaceCache. Optimize slightly.
16520 (TypeManager.MemberLookup_FindMembers): Update.
16521 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16522 multi-type variant.
16523 (AddCacheContents): Rename from AddHashtable.
16524 * class.cs (TypeContainer.parent_container): Remove.
16525 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16526 (TypeContainer.DoDefineMembers): Don't initialize it.
16527 Update to name changes.
16529 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16531 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16532 that factors the code to check access modifiers on override.
16534 (PropertyBase): Use the code here.
16536 Patch from Lluis S'anchez, fixes bug #69361.
16538 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16540 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16541 routine that is used to report the use of a captured variable
16542 whose address has been taken.
16544 There are two checks: one when variables are being captured and
16545 the other check is when the address of a variable is taken.
16547 (because an anonymous methods might be resolved before *or* after
16548 the address has been taken) and
16550 * expression.cs (Conditional.DoResolve): Remove the special
16551 casing that Martin added to trueExpr and falseExpr being both
16552 NullLiteral. We get the right behavior now just by introducing
16553 the null_type into the compiler.
16555 * convert.cs (ExplicitConversion): Change the code to use
16556 null_type instead of testing `expr is NullLiteral'.
16557 (ImplicitConversionStandard): use null_type too.
16558 (ImplicitReferenceConversionExists): use null_type too.
16559 (ImplicitReferenceConversion): use null_type too.
16561 * literal.cs: The type of `NullLiteral' is now null_type instead
16563 (Resolve): Set the type here.
16565 * typemanager.cs: Introduce null_type.
16567 2004-11-17 Martin Baulig <martin@ximian.com>
16569 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16570 direction, like FindMembers() does. Fixes #69546, testcase is in
16573 2004-11-16 Martin Baulig <martin@ximian.com>
16575 This is based on a patch from Marek Safar, see bug #69082.
16576 Fixes bugs #63705 and #67130.
16578 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16579 method; create a MemberCache for an interface type and cache the
16582 * decl.cs (IMemberContainer.ParentContainer): Removed.
16583 (IMemberContainer.ParentCache): New property.
16584 (MemberCache.SetupCacheForInterface): Removed.
16585 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16586 to create a cache for an interface's "parent".
16588 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16591 2004-11-16 Martin Baulig <martin@ximian.com>
16593 Merged back from gmcs; these changes already went into gmcs a
16594 couple of weeks ago.
16597 (TypeManager.AddUserType): Removed the `ifaces' argument.
16598 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16600 (TypeManager.AddUserInterface): Removed.
16601 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16603 (TypeManager.GetInterfaces): Likewise.
16604 (TypeManager.GetExplicitInterfaces): Likewise.
16606 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16608 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16609 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16611 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16613 * statement.cs: Avoid adding bools to a hashtable.
16615 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16617 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16618 calling an unsafe method from a safe location.
16620 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16623 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16625 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16627 * namespace.cs (VerifyUsing): use GetPartialName instead of
16630 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16632 * statement.cs (Return.Resolve): Fix regression in typo: if
16633 `in_exc', we have to request a NeedReturnLabel, this was a typo
16634 introduced in the anonymous method check-in. Fixes #69131.
16636 * Indexers were using the ShortName when defining themselves,
16637 causing a regression in the compiler bootstrap when applying the
16638 patch from 2004-11-02 (first part), now they use their full name
16639 and the bug is gone.
16641 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16643 * driver.cs: Strip the path from the names of embedded resources. Fixes
16646 2004-11-04 Raja R Harinath <rharinath@novell.com>
16648 Fix error message regression: cs0104-2.cs.
16649 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16650 (AliasEntry.Resolve): Update.
16651 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16653 (RootContext.LookupType): Update.
16655 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16657 * cs-parser.jay: Add support for handling accessor modifiers
16658 * class: Add support port accessor modifiers and error checking,
16659 define PropertyMethod.Define as virtual (not abstract anymore)
16660 * ecore.cs: Add checking for proeprties access with access modifiers
16661 * iterators.cs: Modify Accessor constructor call based in the modified
16663 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16665 * expression.cs (StringConcat): Handle being called twice,
16666 as when we have a concat in a field init with more than two
16669 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16671 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16672 special case explicit implementations, we should always produce
16673 the .property or .event declaration.
16675 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16676 since it will not return correct data if people use this
16677 unresolved in the presence of using statements (see test-313).
16679 * class.cs (MethodData.Define): If we are an explicit interface
16680 implementation, set the method name to the full name of the
16681 interface plus the name of the method.
16683 Notice that using the method.MethodName.GetFullName() does not
16684 work, as it will only contain the name as declared on the source
16685 file (it can be a shorthand in the presence of using statements)
16686 and not the fully qualifed type name, for example:
16690 class D : ICloneable {
16691 object ICloneable.Clone () {
16695 Would produce a method called `ICloneable.Clone' instead of
16696 `System.ICloneable.Clone'.
16698 * namespace.cs (Alias.Resolve): Use GetPartialName.
16700 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16702 * cs-parser.jay: Add error 1055 report.
16704 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16706 * assign.cs (Assign.DoResolve): Only do the transform of
16707 assignment into a New if the types are compatible, if not, fall
16708 through and let the implicit code deal with the errors and with
16709 the necessary conversions.
16711 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16713 * cs-parser.jay: Add error 1031 report.
16715 * cs-tokenizer.cs: Add location for error 1038.
16717 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16719 * cs-parser.jay: Add error 1016 report.
16721 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16723 * cs-parser.jay: Add errors 1575,1611 report.
16725 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16727 * cs-parser.jay: Add error 1001 report.
16729 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16732 * attribute.cs (GetMarshal): Add method argument for
16733 caller identification.
16735 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16736 agument for GetMarshal and RuntimeMissingSupport.
16738 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16740 * attribute.cs (ExtractSecurityPermissionSet): Removed
16741 TypeManager.code_access_permission_type.
16743 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16745 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16747 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16748 for obsolete use of a variable here. Fixes regression on errors
16749 cs0619-25 and cs0619-26.
16751 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16753 Fix #62358, implemented security attribute encoding.
16755 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16756 Tests permitted SecurityAction for assembly or other types.
16757 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16758 data from SecurityPermissionAttribute to PermisionSet class.
16760 * class.cs (ApplyAttributeBuilder): Added special handling
16761 for System.Security.Permissions.SecurityAttribute based types.
16763 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16764 special handling for System.Security.Permissions.SecurityAttribute
16767 * enum.cs (ApplyAttributeBuilder): Added special handling
16768 for System.Security.Permissions.SecurityAttribute based types.
16770 * parameter.cs (ApplyAttributeBuilder): Added special handling
16771 for System.Security.Permissions.SecurityAttribute based types.
16773 * rootcontext.cs: Next 2 core types.
16775 * typemanager.cs (TypeManager.security_permission_attr_type):
16776 Built in type for the SecurityPermission Attribute.
16777 (code_access_permission_type): Build in type.
16779 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16781 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16782 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16783 all of this information into
16784 EmitContext.EmitCapturedVariableInstance.
16786 * codegen.cs (EmitCapturedVariableInstance): move here the
16787 funcionality of emitting an ldarg.0 in the presence of a
16788 remapping. This centralizes the instance emit code.
16790 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16791 then emit a load of this: it means that we have reached the
16792 topmost ScopeInfo: the one that contains the pointer to the
16793 instance of the class hosting the anonymous method.
16795 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16796 captures to the topmost CaptureContext.
16798 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16800 * expression.cs (LocalVariableReference): Move the knowledge about
16801 the iterators into codegen's EmitCapturedVariableInstance.
16803 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16805 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16806 all code paths return a value from an anonymous method (it is the
16807 same as the 161 error, but for anonymous methods).
16809 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16811 The introduction of anonymous methods in the compiler changed
16812 various ways of doing things in the compiler. The most
16813 significant one is the hard split between the resolution phase
16814 and the emission phases of the compiler.
16816 For instance, routines that referenced local variables no
16817 longer can safely create temporary variables during the
16818 resolution phase: they must do so from the emission phase,
16819 since the variable might have been "captured", hence access to
16820 it can not be done with the local-variable operations from the runtime.
16824 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16825 is a toplevel block.
16827 (ToplevelBlock): A new kind of Block, these are the blocks that
16828 are created by the parser for all toplevel method bodies. These
16829 include methods, accessors and anonymous methods.
16831 These contain some extra information not found in regular blocks:
16832 A pointer to an optional CaptureContext (for tracking captured
16833 local variables and parameters). A pointer to the parent
16836 (Return.Resolve): Catch missmatches when returning a value from an
16837 anonymous method (error 1662).
16838 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16841 (Break.Resolve): ditto.
16843 (SwitchLabel): instead of defining the labels during the
16844 resolution phase, we now turned the public ILLabel and ILLabelCode
16845 labels into methods called GetILLabelCode() and GetILLabel() that
16846 only define the label during the Emit phase.
16848 (GotoCase): Track the SwitchLabel instead of the computed label
16849 (its contained therein). Emit the code by using
16850 SwitchLabel.GetILLabelCode ().
16852 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16853 whether the Local has been captured or not.
16855 (LocalInfo.IsCaptured): New property, used to tell whether the
16856 local has been captured.
16858 * anonymous.cs: Vastly updated to contain the anonymous method
16861 The main classes here are: CaptureContext which tracks any
16862 captured information for a toplevel block and ScopeInfo used to
16863 track the activation frames for various local variables.
16865 Each toplevel block has an optional capture context associated
16866 with it. When a method contains an anonymous method both the
16867 toplevel method and the anonymous method will create a capture
16868 context. When variables or parameters are captured, they are
16869 recorded on the CaptureContext that owns them, for example:
16873 MyDelegate d = delegate {
16878 Here `a' will be recorded as captured on the toplevel
16879 CapturedContext, the inner captured context will not have anything
16880 (it will only have data if local variables or parameters from it
16881 are captured in a nested anonymous method.
16883 The ScopeInfo is used to track the activation frames for local
16884 variables, for example:
16886 for (int i = 0; i < 10; i++)
16887 for (int j = 0; j < 10; j++){
16888 MyDelegate d = delegate {
16893 At runtime this captures a single captured variable `i', but it
16894 captures 10 different versions of the variable `j'. The variable
16895 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16896 recorded on a child.
16898 The toplevel ScopeInfo will also track information like the `this'
16899 pointer if instance variables were referenced (this is necessary
16900 as the anonymous method lives inside a nested class in the host
16901 type of the method).
16903 (AnonymousMethod): Expanded to track the Toplevel, implement
16904 `AnonymousMethod.Compatible' to tell whether an anonymous method
16905 can be converted to a target delegate type.
16907 The routine now also produces the anonymous method content
16909 (AnonymousDelegate): A helper class that derives from
16910 DelegateCreation, this is used to generate the code necessary to
16911 produce the delegate for the anonymous method that was created.
16913 * assign.cs: API adjustments for new changes in
16914 Convert.ImplicitStandardConversionExists.
16916 * class.cs: Adjustments to cope with the fact that now toplevel
16917 blocks are of type `ToplevelBlock'.
16919 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16920 insteda of standard blocks.
16922 Flag errors if params arguments are passed to anonymous methods.
16924 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16925 `CurrentAnonymousMethod' which points to the current Anonymous
16926 Method. The variable points to the AnonymousMethod class that
16927 holds the code being compiled. It is set in the new EmitContext
16928 created for the anonymous method.
16930 (EmitContext.Phase): Introduce a variable and an enumeration to
16931 assist in enforcing some rules about when and where we are allowed
16932 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16933 only one that enfonces this right now).
16935 (EmitContext.HaveCaptureInfo): new helper method that returns
16936 whether we have a CapturedContext initialized.
16938 (EmitContext.CaptureVariable): New method used to register that a
16939 LocalInfo must be flagged for capturing.
16941 (EmitContext.CapturedParameter): New method used to register that a
16942 parameters must be flagged for capturing.
16944 (EmitContext.CapturedField): New method used to register that a
16945 field must be flagged for capturing.
16947 (EmitContext.HaveCapturedVariables,
16948 EmitContext.HaveCapturedFields): Return whether there are captured
16949 variables or fields.
16951 (EmitContext.EmitMethodHostInstance): This is used to emit the
16952 instance for the anonymous method. The instance might be null
16953 (static methods), this (for anonymous methods that capture nothing
16954 and happen to live side-by-side with the current method body) or a
16955 more complicated expression if the method has a CaptureContext.
16957 (EmitContext.EmitTopBlock): Routine that drives the emission of
16958 code: it will first resolve the top block, then emit any metadata
16959 and then emit the code. The split is done so that we can extract
16960 any anonymous methods and flag any captured variables/parameters.
16962 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16963 during this phase, the ILGenerator should not be used as labels
16964 and local variables declared here might not be accessible to any
16965 code that is part of an anonymous method.
16967 Exceptions to this include the temporary variables that are
16968 created by some statements internally for holding temporary
16971 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16974 (EmitContext.TemporaryReturn): This method is typically called
16975 from the Emit phase, and its the only place where we allow the
16976 ReturnLabel to be defined other than the EmitMeta. The reason is
16977 that otherwise we would have to duplicate a lot of logic in the
16978 Resolve phases of various methods that today is on the Emit
16981 (EmitContext.NeedReturnLabel): This no longer creates the label,
16982 as the ILGenerator is not valid during the resolve phase.
16984 (EmitContext.EmitThis): Extended the knowledge in this class to
16985 work in anonymous methods in addition to iterators.
16987 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16988 code is necessary on the stack to access the instance to a local
16989 variable (the variable will be accessed as a field).
16991 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16992 EmitContext.EmitAddressOfParameter): Routines to support
16993 parameters (not completed at this point).
16995 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16996 will also remove the parameters.
16998 * convert.cs (Convert): Define a `ConstantEC' which points to a
16999 null. This is just to prefity some code that uses
17000 ImplicitStandardConversion code and do not have an EmitContext
17003 The idea is to flag explicitly that at that point in time, it is
17004 known that the conversion will not trigger the delegate checking
17005 code in implicit conversions (which requires a valid
17008 Everywhere: pass new EmitContext parameter since
17009 ImplicitStandardConversionExists now requires it to check for
17010 anonymous method conversions.
17012 (Convert.ImplicitStandardConversionExists): If the type of an
17013 expression is the anonymous_method_type, and the type is a
17014 delegate, we invoke the AnonymousMethod.Compatible method to check
17015 whether an implicit conversion is possible.
17017 (Convert.ImplicitConversionStandard): Only do implicit method
17018 group conversions if the language level is not ISO_1.
17020 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
17021 MethodInfo for the Invoke method. used by Delegate and
17024 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
17025 method conversions if the target type is a delegate.
17027 Removed extra debugging nops.
17029 (LocalVariableReference): Turn the `local_info' into a public
17032 Add `prepared' field, the same hack used for FieldExprs to cope
17033 with composed assignments, as Local variables do not necessarily
17034 operate purely on the stack as they used to: they can be captured
17037 Add `temp' for a temporary result, like fields.
17039 Refactor DoResolve and DoResolveLValue into DoResolveBase.
17041 It now copes with Local variables that are captured and emits the
17042 proper instance variable to load it from a field in the captured
17045 (ParameterReference.DoResolveBase): During the resolve phase,
17046 capture parameters if we are in an anonymous method.
17048 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
17049 anonymous method, use the EmitContext helper routines to emit the
17050 parameter reference.
17052 * iterators.cs: Set RemapToProxy to true/false during the
17055 * parameters.cs (GetParameterByName): New helper method.
17057 * typemanager.cs (anonymous_method_type) a new type that
17058 represents an anonyous method. This is always an internal type,
17059 used as a fencepost to test against the anonymous-methodness of an
17062 2004-10-20 Marek Safar <marek.safar@seznam.cz>
17064 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
17066 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
17068 2004-10-18 Martin Baulig <martin@ximian.com>
17070 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
17071 `Type' directly, but call ResolveType() on it.
17072 (Catch.Resolve): Likewise.
17073 (Foreach.Resolve): Likewise.
17075 2004-10-18 Martin Baulig <martin@ximian.com>
17077 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
17078 `Type' directly, but call ResolveType() on it.
17079 (Probe.DoResolve): Likewise.
17080 (ArrayCreation.LookupType): Likewise.
17081 (TypeOf.DoResolve): Likewise.
17082 (SizeOf.DoResolve): Likewise.
17084 2004-10-18 Martin Baulig <martin@ximian.com>
17086 * expression.cs (Invocation.BetterFunction): Put back
17087 TypeManager.TypeToCoreType().
17089 2004-10-18 Raja R Harinath <rharinath@novell.com>
17091 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
17094 2004-10-18 Martin Baulig <martin@ximian.com>
17096 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
17097 `Type' directly, but call ResolveType() on it.
17099 2004-10-18 Martin Baulig <martin@ximian.com>
17101 * class.cs (FieldMember.Define): Don't access the TypeExpr's
17102 `Type' directly, but call ResolveType() on it.
17103 (MemberBase.DoDefine): Likewise.
17105 * expression.cs (New.DoResolve): Don't access the TypeExpr's
17106 `Type' directly, but call ResolveType() on it.
17107 (ComposedCast.DoResolveAsTypeStep): Likewise.
17109 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
17110 `Type' directly, but call ResolveType() on it.
17112 2004-10-17 John Luke <john.luke@gmail.com>
17114 * class.cs (Operator.GetSignatureForError): use CSharpName
17116 * parameter.cs (Parameter.GetSignatureForError): Returns
17117 correct name even if was not defined.
17119 2004-10-13 Raja R Harinath <rharinath@novell.com>
17122 * class.cs (TypeContainer.EmitContext): New property.
17123 (DefineNestedTypes): Create an emitcontext for each part.
17124 (MethodCore.DoDefineParameters): Use container's emitcontext.
17125 Pass type array to InternalParameters.
17126 (MemberBase.DoDefine): Use container's emitcontext.
17127 (FieldMember.Define): Likewise.
17128 (Event.Define): Likewise.
17129 (SetMethod.GetParameterInfo): Change argument to EmitContext.
17130 Pass type array to InternalParameters.
17131 (SetIndexerMethod.GetParameterInfo): Likewise.
17132 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
17133 * delegate.cs (Define): Pass emitcontext to
17134 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
17135 array to InternalParameters.
17136 * expression.cs (ParameterReference.DoResolveBase): Pass
17137 emitcontext to GetParameterInfo.
17138 (ComposedCast.DoResolveAsTypeStep): Remove check on
17139 ec.ResolvingTypeTree.
17140 * parameter.cs (Parameter.Resolve): Change argument to
17141 EmitContext. Use ResolveAsTypeTerminal.
17142 (Parameter.GetSignature): Change argument to EmitContext.
17143 (Parameters.ComputeSignature): Likewise.
17144 (Parameters.ComputeParameterTypes): Likewise.
17145 (Parameters.GetParameterInfo): Likewise.
17146 (Parameters.ComputeAndDefineParameterTypes): Likewise.
17147 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
17148 * support.cs (InternalParameters..ctor): Remove variant that takes
17150 * typemanager.cs (system_intptr_expr): New.
17151 (InitExpressionTypes): Initialize it.
17153 2004-10-12 Chris Toshok <toshok@ximian.com>
17155 * cs-parser.jay: fix location for try_statement and catch_clause.
17157 2004-10-11 Martin Baulig <martin@ximian.com>
17159 * report.cs: Don't make --fatal abort on warnings, we have
17160 -warnaserror for that.
17162 2004-10-07 Raja R Harinath <rharinath@novell.com>
17164 More DeclSpace.ResolveType avoidance.
17165 * decl.cs (MemberCore.InUnsafe): New property.
17166 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
17167 with newly created EmitContext.
17168 (FieldMember.Define): Likewise.
17169 * delegate.cs (Delegate.Define): Likewise.
17170 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
17171 only if normal name-lookup fails.
17172 (TypeExpr.DoResolve): Enable error-checking.
17173 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
17174 (SizeOf.DoResolve): Likewise.
17175 (ComposedCast.DoResolveAsTypeStep): Likewise.
17176 (StackAlloc.DoResolve): Likewise.
17177 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
17178 (Block.Unsafe): New property.
17179 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
17180 (Unsafe): Set 'unsafe' flag of contained block.
17181 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
17182 (Fixed.Resolve): Likewise.
17183 (Catch.Resolve): Likewise.
17184 (Using.ResolveLocalVariableDecls): Likewise.
17185 (Foreach.Resolve): Likewise.
17187 2004-10-05 John Luke <john.luke@gmail.com>
17189 * cs-parser.jay: add location to error CS0175
17191 2004-10-04 Miguel de Icaza <miguel@ximian.com>
17193 * ecore.cs (Expression.Constantity): Add support for turning null
17196 * const.cs (Const.Define): Allow constants to be reference types
17197 as long as the value is Null.
17199 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
17201 * namespace.cs (NamespaceEntry.Using): No matter which warning
17202 level is set, check if this namespace name has already been added.
17204 2004-10-03 Ben Maurer <bmaurer@ximian.com>
17206 * expression.cs: reftype [!=]= null should always use br[true,false].
17209 2004-10-03 Marek Safar <marek.safar@seznam.cz>
17212 * attribute.cs: Enum conversion moved to
17213 GetAttributeArgumentExpression to be applied to the all
17216 2004-10-01 Raja R Harinath <rharinath@novell.com>
17218 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
17219 * class.c (TypeContainer.DefineType): Flag error if
17220 base types aren't accessible due to access permissions.
17221 * decl.cs (DeclSpace.ResolveType): Move logic to
17222 Expression.ResolveAsTypeTerminal.
17223 (DeclSpace.ResolveTypeExpr): Thin layer over
17224 Expression.ResolveAsTypeTerminal.
17225 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
17226 Refactor code into NestedAccess. Use it.
17227 (DeclSpace.NestedAccess): New.
17228 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
17229 argument to silence errors. Check access permissions.
17230 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
17231 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
17232 (Cast.DoResolve): Likewise.
17233 (New.DoResolve): Likewise.
17234 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
17235 (TypeOf.DoResolve): Likewise.
17237 * expression.cs (Invocation.BetterConversion): Return the Type of
17238 the better conversion. Implement section 14.4.2.3 more faithfully.
17239 (Invocation.BetterFunction): Make boolean. Make correspondence to
17240 section 14.4.2.2 explicit.
17241 (Invocation.OverloadResolve): Update.
17242 (Invocation): Remove is_base field.
17243 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
17244 (Invocation.Emit): Likewise.
17246 2004-09-27 Raja R Harinath <rharinath@novell.com>
17248 * README: Update to changes.
17250 2004-09-24 Marek Safar <marek.safar@seznam.cz>
17252 * cs-parser.jay: Reverted 642 warning fix.
17254 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17257 * decl.cs (FindMemberWithSameName): Indexer can have more than
17260 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17262 * expression.cs (LocalVariableReference.DoResolveLValue):
17263 Do not report warning 219 for out values.
17264 (EmptyExpression.Null): New member to avoid extra allocations.
17266 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17268 * cs-parser.jay: Fix wrong warning 642 report.
17270 * cs-tokenizer.cs (CheckNextToken): New helper;
17271 Inspect next character if is same as expected.
17273 2004-09-23 Martin Baulig <martin@ximian.com>
17275 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17276 (Convert.ImplicitReferenceConversionExists): Likewise.
17278 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17280 * class.cs (Operator.Define): Add error 448 and 559 report.
17282 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17284 * class.cs (MemberBase.IsTypePermitted): New protected
17285 method for checking error CS0610.
17287 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17289 * class.cs (TypeContainer.HasExplicitLayout): New property
17290 Returns whether container has StructLayout attribute set Explicit.
17291 (FieldMember): New abstract class for consts and fields.
17292 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17293 (Field): Reuse FieldMember.
17295 * const.cs (Const): Reuse FieldMember.
17297 * rootcontext.cs: EmitConstants call moved to class.
17299 2004-09-22 Martin Baulig <martin@ximian.com>
17301 Thanks to Peter Sestoft for this bug report.
17303 * expression.cs (Conditional): If both the `trueExpr' and the
17304 `falseExpr' is a NullLiteral, return a NullLiteral.
17306 2004-09-22 Martin Baulig <martin@ximian.com>
17308 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17309 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17310 for the "get_Current" call.
17312 2004-09-22 Martin Baulig <martin@ximian.com>
17314 Marek and me just fixed one of our oldest bugs: #28562 :-)
17316 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17318 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17319 we're an EnumConstant, just return that.
17320 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17321 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17322 to get the value which'll actually be written into the attribute.
17323 However, we have to use GetValue() to access the attribute's value
17326 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17328 * constant.cs (Constant.IsNegative): New abstract property
17331 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17332 (StackAlloc.DoResolve): Reused IsNegative.
17334 2004-09-21 Martin Baulig <martin@ximian.com>
17336 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17337 if we're used in an iterator, we may be called from different
17340 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17341 we actually have an exception block.
17343 2004-09-20 John Luke <jluke@cfl.rr.com>
17345 * class.cs, cs-parser.jay: Improve the error report for 1520:
17346 report the actual line where the error happens, not where the
17347 class was declared.
17349 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17350 Pass location information that was available elsewhere.
17352 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17354 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17355 runtime to delay sign assemblies.
17357 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17359 * cs-parser.jay: Do not report the stack trace, this is barely
17362 2004-08-22 John Luke <john.luke@gmail.com>
17364 * driver.cs : check that a resource id is not already used
17365 before adding it, report CS1508 if it is, bug #63637
17367 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17369 * ecore.cs: Removed dead code.
17371 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17373 * class.cs: Do not report warning CS0067 on the interfaces.
17375 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17377 * cs-parser.jay: Add error 504 report.
17379 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17381 * rootcontext.cs: WarningLevel is 4 by default now.
17383 * statement.cs (Fixed.Resolve): Do not null
17386 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17389 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17390 deep search when property is not virtual.
17391 (PropertyExpr.ResolveAccessors): Make one call for both
17394 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17397 * statement.cs: Error 152 report constains also location.
17399 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17402 * const.cs: Explicitly set constant as static.
17404 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17407 * cs-parser.jay: Add error 1017 report.
17409 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17411 Fixed bug #59980, #64224
17412 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17414 * typemanager.cs (IsSpecialMethod): Simplified
17416 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17418 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17419 condition with better params.
17421 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17424 * attribute.cs (Resolve): Property has to have both
17427 2004-09-14 Martin Baulig <martin@ximian.com>
17429 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17431 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17434 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17435 called and is obsolete then this member suppress message
17436 when call is inside next [Obsolete] method or type.
17438 * expression.cs: Use TestObsoleteMethodUsage member.
17440 2004-09-14 Martin Baulig <martin@ximian.com>
17442 * cs-parser.jay: Sync a bit with the GMCS version.
17444 2004-09-14 Martin Baulig <martin@ximian.com>
17446 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17447 (CSharpParser.yacc_verbose_flag): New public field.
17449 * genericparser.cs: Removed.
17451 2004-09-14 Raja R Harinath <rharinath@novell.com>
17453 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17455 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17457 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17459 2004-09-10 Martin Baulig <martin@ximian.com>
17461 Backported my MemberName changes from GMCS into MCS.
17463 - we are now using a special `MemberName' class instead of using
17464 strings; in GMCS, the `MemberName' also contains the type
17467 - changed the grammar rules a bit:
17468 * the old `member_name' is now a `namespace_or_type_name':
17469 The rule is that we use `namespace_or_type_name' everywhere
17470 where we expect either a "member name" (GetEnumerator) or a
17471 "member name" with an explicit interface name
17472 (IEnumerable.GetEnumerator).
17473 In GMCS, the explicit interface name may include type arguments
17474 (IEnumerable<T>.GetEnumerator).
17475 * we use `member_name' instead of just `IDENTIFIER' for
17477 The rule is that we use `member_name' wherever a member may
17478 have type parameters in GMCS.
17480 * decl.cs (MemberName): New public class.
17481 (MemberCore.MemberName): New public readonly field.
17482 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17483 (DeclSpace): Likewise.
17485 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17486 * enum.cs (Enum.ctor): Likewise.
17488 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17490 (AliasEntry.ctor): Take a MemberName, not an Expression.
17491 (AliasEntry.UsingAlias): Likewise.
17493 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17494 (IMethodData.MemberName): Changed type from string to MemberName.
17495 (MemberBase.ExplicitInterfaceName): Likewise.
17496 (AbstractPropertyEventMethod.SetupName): Make this private.
17497 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17498 argument; compute the member name here.
17499 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17500 on the `member.MemberName' and the `prefix'.
17502 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17504 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17505 thus, we get a `MemberName' instead of a `string'. These
17506 declarations may have type parameters in GMCS.
17507 (interface_method_declaration, delegate_declaration): Likewise.
17508 (class_declaration, interface_declaration): Likewise.
17509 (method_header): Use `namespace_or_type_name' instead of
17510 `member_name'. We may be an explicit interface implementation.
17511 (property_declaration, event_declaration): Likewise.
17512 (member_name): This is now just an `IDENTIFIER', not a
17513 `namespace_or_type_name'.
17514 (type_name, interface_type): Removed.
17515 (namespace_or_type_name): Return a MemberName, not an Expression.
17516 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17517 call GetTypeExpression() on the MemberName to get an expression.
17518 (IndexerDeclaration.interface_type): Changed type from string to
17520 (MakeName): Operate on MemberName's instead of string's.
17522 2004-09-13 Raja R Harinath <rharinath@novell.com>
17525 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17526 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17527 lookup to avoid symbols introduced by 'using'.
17528 * rootcontext.cs (NamespaceLookup): Update.
17530 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17532 * class.cs (TypeContainer.DoDefineMembers): Do not call
17533 DefineDefaultConstructor for static classes.
17535 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17537 * attribute.cs (Attribute.Resolve): Add error 653 report.
17539 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17541 (Method.ApplyAttributeBuilder): Add error 685 report.
17542 (Operator.Define): Add error 564 report.
17544 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17546 * expression.cs (Invocation.DoResolve): Add error
17547 245 and 250 report.
17549 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17552 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17554 * class.cs (ConstructorInitializer.Resolve):
17555 Wrong error number (515->516).
17557 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17559 * class.cs (Indexer.Define): Add error 631 report.
17561 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17563 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17565 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17567 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17569 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17571 * cs-parser.jay: Added error CS0241 report.
17573 2004-09-10 Raja R Harinath <rharinath@novell.com>
17575 * cs-parser.jay (fixed_statement): Introduce a scope for the
17576 declaration in the 'fixed' statement.
17578 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17580 * cs-parser.jay: Added CS0230 error report.
17582 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17584 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17586 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17588 * expression.cs (Argument.Resolve): Added error CS0192 and
17591 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17593 C# 2.0 #pragma warning feature
17595 * cs-tokenizer.cs (PreProcessPragma): New method;
17596 Handles #pragma directive.
17598 * report.cs (WarningRegions): New class; Support
17599 class for #pragma warning directive. It tests whether
17600 warning is enabled for a given line.
17602 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17604 * const.cs: Add more descriptive error report, tahnks to
17607 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17609 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17611 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17613 * expression.cs: Apply patch from Ben: Remove dead code from
17614 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17615 as that code just threw an exception anwyays.
17617 * const.cs: Remove the call to the turnintoconstant, for details
17620 * literal.cs: The type of the null-literal is the null type; So
17621 we use a placeholder type (literal.cs:System.Null, defined here)
17624 * expression.cs (Conditional.DoResolve): Remove some old code that
17625 is no longer needed, conversions have been fixed.
17627 (ArrayCreationExpression.DoResolve): Return false if we fail to
17628 resolve the inner expression.
17630 2004-09-07 Raja R Harinath <rharinath@novell.com>
17633 * cs-parser.jay (delegate_declaration): Record a delegate
17634 declaration as a type declaration.
17635 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17637 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17639 * parameter.cs: Do not crash if the type can not be resolved.
17641 * expression.cs: Report errors with unsafe pointers, fixes #64896
17643 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17645 * expression.cs: Pointer arith always needs to do a conv.i
17646 if the operand is a long. fix 65320
17648 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17650 Fixed cs0619-37.cs, cs0619-38.cs
17652 * enum.cs (GetObsoleteAttribute): Removed.
17654 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17655 on Enum member is double staged. The first is tested member
17658 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17660 Fixed #56986, #63631, #65231
17662 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17663 adds member to name container.
17664 (TypeContainer.AddToTypeContainer): New method, adds type to
17666 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17667 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17668 AddOperator): Simplified by reusing AddToMemberContainer.
17669 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17671 (Method.CheckForDuplications): Fixed implementation to test all
17673 (MemberBase): Detection whether member is explicit interface
17674 implementation is now in constructor.
17675 (MemberBase.UpdateMemberName): Handles IndexerName.
17676 (Accessor): Changed to keep also location information.
17677 (AbstractPropertyEventMethod): Is derived from MemberCore.
17678 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17679 will be emited or not.
17680 (PropertyBase.AreAccessorsDuplicateImplementation):
17681 Tests whether accessors are not in collision with some method.
17682 (Operator): Is derived from MethodCore to simplify common
17685 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17687 (DeclSpace.AddToContainer): Adds the member to defined_names
17688 table. It tests for duplications and enclosing name conflicts.
17690 * enum.cs (EnumMember): Clean up to reuse the base structures
17692 2004-09-03 Martin Baulig <martin@ximian.com>
17694 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17695 into TypeContainer, to make partial classes work again.
17697 2004-09-03 Martin Baulig <martin@ximian.com>
17699 * rootcontext.cs (RootContext.V2): Removed.
17701 2004-03-23 Martin Baulig <martin@ximian.com>
17703 * expression.cs (Invocation.OverloadResolve): Added `bool
17704 may_fail' argument and use it instead of the Location.IsNull() hack.
17706 2004-09-03 Martin Baulig <martin@ximian.com>
17708 Merged latest changes into gmcs. Please keep this comment in
17709 here, it makes it easier for me to see what changed in MCS since
17710 the last time I merged.
17712 2004-09-03 Raja R Harinath <rharinath@novell.com>
17715 * expression.cs (BetterConversion): Don't allow either conversion
17716 to be null. Remove redundant implicit conversion test when 'q ==
17717 null' -- when this function is invoked, we already know that the
17718 implicit conversion exists.
17719 (BetterFunction): Assume that 'best' is non-null. Remove
17720 redundant reimplementation of IsApplicable when 'best' is null.
17721 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17722 number of arguments.
17723 (IsAncestralType): Extract from OverloadResolve.
17724 (OverloadResolve): Make robust to the MethodGroupExpr being
17725 unsorted. Implement all the logic of Section 14.5.5.1, and
17726 support overloading of methods from multiple applicable types.
17727 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17729 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17730 (RealError, Warning): Append type of report to related symbol.
17732 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17734 * enum.cs: Fixed CLS-Compliance checks for enum members.
17735 Error tests cs3008-8.cs, cs3014-8.cs
17737 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17739 Fixed bug #62342, #63102
17740 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17741 like ImplementMethod.
17743 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17745 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17748 2004-09-02 Martin Baulig <martin@ximian.com>
17750 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17751 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17754 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17756 C# 2.0 Static classes implemented
17758 * class.cs (TypeContainer): instance_constructors,
17759 initialized_fields, initialized_static_fields,
17760 default_constructor, base_inteface_types are protected to be
17761 accessible from StaticClass.
17762 (TypeContainer.DefineDefaultConstructor): New virtual method
17763 for custom default constructor generating
17764 (StaticClass): New class to handle "Static classes" feature.
17766 * cs-parser.jay: Handle static keyword on class like instance
17769 * driver.cs: Added "/langversion" command line switch with two
17770 options (iso-1, default).
17772 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17774 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17776 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17778 * delegate.cs: Style.
17780 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17782 * delegate.cs: Add seperate instance expr field for miguel.
17784 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17786 * PointerArithmetic (Resolve): make sure we are not doing
17787 pointer arith on void*. Also, make sure we are resolved
17788 by not setting eclass until resolve.
17790 All callers: Make sure that PointerArithmetic gets resolved.
17792 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17794 * ArrayCreation (LookupType): If the type does not resolve
17795 to an array, give an error.
17797 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17799 * statement.cs (Try.Resolve): Fixed bug #64222
17801 2004-08-27 Martin Baulig <martin@ximian.com>
17804 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17807 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17809 * ecore.cs (Constantify): Get underlying type via
17810 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17811 Windows in special cases.
17813 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17815 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17816 for obtaining also private methods.
17817 (GetRemoveMethod): Used GetRemoveMethod (true)
17818 for obtaining also private methods.
17820 2004-08-24 Martin Baulig <martin@ximian.com>
17822 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17823 MethodAttributes.HideBySig for operators.
17825 2004-08-23 Martin Baulig <martin@ximian.com>
17827 Back to the old error reporting system :-)
17829 * report.cs (Message): Removed.
17830 (Report.MessageData, ErrorData, WarningData): Removed.
17831 (Report.Error, Warning): Back to the old system.
17833 2004-08-23 Martin Baulig <martin@ximian.com>
17835 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17837 * class.cs (TypeContainer.ParentContainer): New public virtual
17838 method; replaces the explicit interface implementation.
17839 (ClassPart.ParentContainer): Override.
17841 2004-08-23 Martin Baulig <martin@ximian.com>
17843 * statement.cs (Switch): Added support for constant switches; see
17844 #59428 or test-285.cs.
17846 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17849 * statement.cs (GetEnumeratorFilter): Removed useless
17850 logic because C# specs is strict. GetEnumerator must be
17853 2004-08-22 Martin Baulig <martin@ximian.com>
17855 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17856 a switch and may break, reset the barrier. Fixes #59867.
17858 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17860 CLS-Compliance speed up (~5% for corlib)
17862 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17863 New method. Tests container for CLS-Compliant names
17865 * class.cs (TypeContainer.VerifyClsName): New method.
17866 Checks whether container name is CLS Compliant.
17867 (Constructor): Implements IMethodData.
17869 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17870 low-case table for CLS Compliance test.
17871 (MemberCache.VerifyClsParameterConflict): New method.
17872 Checks method parameters for CS3006 error.
17874 * enum.cs (EnumMember): Is derived from MemberCore.
17875 (Enum.VerifyClsName): Optimized for better performance.
17877 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17879 * report.cs: Renamed Error_T to Error and changed all
17882 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17884 * class.cs (TypeContainer.IndexerArrayList): New inner class
17885 container for indexers.
17886 (TypeContainer.DefaultIndexerName): New constant for default
17887 indexer name. Replaced all "Item" with this constant.
17888 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17890 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17891 DefaultMemberAttribute constructor.
17893 2004-08-05 Martin Baulig <martin@ximian.com>
17895 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17898 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17900 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17901 multi platforms problem.
17903 * compiler.csproj: Included shared files.
17905 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17907 Fix bug 60333, 55971 in the more general way
17908 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17909 Added arg_type argument for constant conversion.
17910 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17912 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17915 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17916 OperatorArrayList, MethodCoreArrayList for typecontainer
17917 containers. Changed class member types to these new types.
17918 (MethodArrayList.DefineMembers): Added test for CS0659.
17920 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17922 * cfold.cs: Synchronize the folding with the code in expression.cs
17923 Binary.DoNumericPromotions for uint operands.
17925 * attribute.cs: Revert patch from Raja, it introduced a regression
17926 while building Blam-1.2.1 (hard to isolate a test case).
17928 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17932 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17934 (MethodCore.parent_method): New member. The method we're overriding
17935 if this is an override method.
17936 (MethodCore.CheckBase): Moved from Method class and made common.
17937 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17939 (MethodCore.CheckForDuplications): New abstract method. For custom
17940 member duplication search in a container
17941 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17942 method and its return type.
17943 (Event.conflict_symbol): New member. Symbol with same name in the
17947 (MemberCache.FindMemberWithSameName): New method. The method
17948 is looking for conflict with inherited symbols.
17950 2004-08-04 Martin Baulig <martin@ximian.com>
17952 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17954 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17956 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17958 * report.cs (Message): New enum for better error, warning reference in
17960 (MessageData): New inner abstract class. It generally handles printing of
17961 error and warning messages.
17962 Removed unused Error, Warning, Message methods.
17964 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17966 Fix for cs0592-8.cs test
17968 (Attributable.ValidAttributeTargets): Made public.
17969 (Attribute.ExplicitTarget): New member for explicit target value.
17970 (Attribute.CheckTargets): Now we translate explicit attribute
17971 target to Target here.
17973 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17975 * ecore.cs (MethodGroupExpr): new IsBase property.
17977 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17979 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17980 rather than an instance expr.
17982 (DelegateCreation.Emit): Use the method group rather than
17983 the instance expression. Also, if you have base.Foo as the
17984 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17986 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17988 (NewDelegate.DoResolve): Only check for the existance of Invoke
17989 if the method is going to be needed. Use MethodGroupExpr.
17991 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17993 * expression.cs: For pointer arith., make sure to use
17994 the size of the type, not the size of the pointer to
17997 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18000 * class.cs (Class): Added error CS0502 test.
18002 2004-08-03 John Luke <jluke@cfl.rr.com>
18003 Raja R Harinath <rharinath@novell.com>
18006 * attribute.cs (Attribute.complained_before): New flag.
18007 (Attribute.ResolveType, Attribute.Resolve),
18008 (Attribute.DefinePInvokeMethod): Set it.
18009 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
18011 2004-08-03 Martin Baulig <martin@ximian.com>
18013 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
18014 use a user-defined operator; we still need to do numeric
18015 promotions in case one argument is a builtin type and the other
18016 one has an implicit conversion to that type. Fixes #62322.
18018 2004-08-02 Martin Baulig <martin@ximian.com>
18020 * statement.cs (LocalInfo.Flags): Added `IsThis'.
18021 (LocalInfo.IsThis): New public property.
18022 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
18024 2004-08-01 Martin Baulig <martin@ximian.com>
18026 * class.cs (TypeContainer.GetClassBases): Don't set the default
18027 here since we may get called from GetPartialBases().
18028 (TypeContainer.DefineType): If GetClassBases() didn't return a
18029 parent, use the default one.
18031 2004-07-30 Duncan Mak <duncan@ximian.com>
18033 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
18035 2004-07-30 Martin Baulig <martin@ximian.com>
18037 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
18039 * class.cs (SourceMethod): New public class, derive from the
18040 symbol writer's ISourceMethod.
18041 (Method): Use the new symbol writer API.
18043 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
18044 as argument and use the new symbol writer.
18047 (SourceFile): Implement the symbol writer's ISourceFile.
18048 (Location.SymbolDocument): Removed.
18049 (Location.SourceFile): New public property.
18051 * symbolwriter.cs: Use the new symbol writer API.
18053 2004-07-30 Raja R Harinath <rharinath@novell.com>
18055 * Makefile (install-local): Remove. Functionality moved to
18058 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
18060 * Makefile: Install mcs.exe.config file together with mcs.exe.
18061 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
18062 correct runtime version.
18064 2004-07-25 Martin Baulig <martin@ximian.com>
18067 (TypeContainer.RegisterOrder): Removed, this was unused.
18068 (TypeContainer, interface_order): Removed.
18069 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
18070 TypeContainer as argument since we can also be called with a
18071 `PartialContainer' for a partial class/struct/interface.
18072 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
18073 of checking whether we're an `Interface' - we could be a
18074 `PartialContainer'.
18075 (PartialContainer.Register): Override; call
18076 AddClass()/AddStruct()/AddInterface() on our parent.
18078 * cs-parser.jay (interface_member_declaration): Add things to the
18079 `current_container', not the `current_class'.
18081 * rootcontext.cs (RegisterOrder): The overloaded version which
18082 takes an `Interface' was unused, removed.
18084 * typemanager.cs (TypeManager.LookupInterface): Return a
18085 `TypeContainer', not an `Interface'.
18086 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
18087 contain a `PartialContainer' for an interface, so check it's
18088 `Kind' to figure out what it is.
18090 2004-07-25 Martin Baulig <martin@ximian.com>
18092 * class.cs (Class.DefaultTypeAttributes): New public constant.
18093 (Struct.DefaultTypeAttributes): Likewise.
18094 (Interface.DefaultTypeAttributes): Likewise.
18095 (PartialContainer.TypeAttr): Override this and add the
18096 DefaultTypeAttributes.
18098 2004-07-25 Martin Baulig <martin@ximian.com>
18100 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
18101 we can just use the `Parent' field instead.
18103 2004-07-25 Martin Baulig <martin@ximian.com>
18105 * class.cs (TypeContainer.Emit): Renamed to EmitType().
18107 2004-07-25 Martin Baulig <martin@ximian.com>
18109 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
18110 our parts before defining any methods.
18111 (TypeContainer.VerifyImplements): Make this virtual.
18112 (ClassPart.VerifyImplements): Override and call VerifyImplements()
18113 on our PartialContainer.
18115 2004-07-25 Martin Baulig <martin@ximian.com>
18117 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
18119 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
18120 argument, we can just use the `Parent' field instead.
18123 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
18124 (MemberBase.DoDefine): Likewise.
18126 2004-07-24 Martin Baulig <martin@ximian.com>
18128 * decl.cs (MemberCore.Parent): New public field.
18129 (DeclSpace.Parent): Moved to MemberCore.
18131 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
18132 (MemberBase.ctor): Added TypeContainer argument, pass it to our
18134 (FieldBase, Field, Operator): Likewise.
18135 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
18136 (EventField, Event): Likewise.
18138 2004-07-23 Martin Baulig <martin@ximian.com>
18140 * class.cs (PartialContainer): New public class.
18141 (ClassPart): New public class.
18142 (TypeContainer): Added support for partial classes.
18143 (TypeContainer.GetClassBases): Splitted some of the functionality
18144 out into GetNormalBases() and GetPartialBases().
18146 * cs-tokenizer.cs (Token.PARTIAL): New token.
18147 (Tokenizer.consume_identifier): Added some hacks to recognize
18148 `partial', but only if it's immediately followed by `class',
18149 `struct' or `interface'.
18151 * cs-parser.jay: Added support for partial clases.
18153 2004-07-23 Martin Baulig <martin@ximian.com>
18155 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
18156 a `DeclSpace' and also made it readonly.
18157 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
18158 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
18159 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
18161 * cs-parser.jay: Pass the `current_class', not the
18162 `current_container' (at the moment, this is still the same thing)
18163 to a new Method, Property, Event, Indexer or Constructor.
18165 2004-07-23 Martin Baulig <martin@ximian.com>
18167 * cs-parser.jay (CSharpParser): Added a new `current_class' field
18168 and removed the `current_interface' one.
18169 (struct_declaration, class_declaration, interface_declaration):
18170 Set `current_class' to the newly created class/struct/interface;
18171 set their `Bases' and call Register() before parsing their body.
18173 2004-07-23 Martin Baulig <martin@ximian.com>
18175 * class.cs (Kind): New public enum.
18176 (TypeContainer): Made this class abstract.
18177 (TypeContainer.Kind): New public readonly field.
18178 (TypeContainer.CheckDef): New public method; moved here from
18180 (TypeContainer.Register): New public abstract method.
18181 (TypeContainer.GetPendingImplementations): New public abstract
18183 (TypeContainer.GetClassBases): Removed the `is_class' and
18184 `is_iface' parameters.
18185 (TypeContainer.DefineNestedTypes): Formerly known as
18187 (ClassOrStruct): Made this class abstract.
18189 * tree.cs (RootTypes): New public type.
18191 2004-07-20 Martin Baulig <martin@ximian.com>
18193 * tree.cs (Tree.RecordNamespace): Removed.
18194 (Tree.Namespaces): Removed.
18196 * rootcontext.cs (RootContext.IsNamespace): Removed.
18198 * cs-parser.jay (namespace_declaration): Just create a new
18199 NamespaceEntry here.
18201 2004-07-20 Martin Baulig <martin@ximian.com>
18203 * statement.cs (ExceptionStatement): New abstract class. This is
18204 now used as a base class for everyone who's using `finally'.
18205 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
18206 our local variables before using them.
18208 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
18209 virtual method. This is used by Yield.Resolve() to "steal" an
18210 outer block's `finally' clauses.
18211 (FlowBranchingException): The .ctor now takes an ExceptionStatement
18214 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
18215 version which takes an ExceptionStatement. This version must be
18216 used to create exception branchings.
18219 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
18220 (Iterator.EmitMoveNext): Added exception support; protect the
18221 block with a `fault' clause, properly handle 'finally' clauses.
18222 (Iterator.EmitDispose): Run all the `finally' clauses here.
18224 2004-07-20 Martin Baulig <martin@ximian.com>
18226 * iterator.cs: This is the first of a set of changes in the
18227 iterator code. Match the spec more closely: if we're an
18228 IEnumerable, then GetEnumerator() must be called. The first time
18229 GetEnumerator() is called, it returns the current instance; all
18230 subsequent invocations (if any) must create a copy.
18232 2004-07-19 Miguel de Icaza <miguel@ximian.com>
18234 * expression.cs: Resolve the constant expression before returning
18237 2004-07-19 Martin Baulig <martin@ximian.com>
18239 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
18240 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
18241 the return type of the new EmitContext.
18243 2004-07-18 Martin Baulig <martin@ximian.com>
18245 * class.cs (Property.Define): Fix iterators.
18247 * iterators.cs (Iterator.Define): Moved the
18248 `container.AddInterator (this)' call here from the .ctor; only do
18249 it if we resolved successfully.
18251 2004-07-17 Miguel de Icaza <miguel@ximian.com>
18253 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
18254 `true' for preprocessing directives that we parse. The return
18255 value indicates whether we should return to regular tokenizing or
18256 not, not whether it was parsed successfully.
18258 In the past if we were in: #if false ... #line #endif, we would
18259 resume parsing after `#line'. See bug 61604.
18261 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18262 building: IsEnumType should return true only for enums, not for
18263 enums or System.Enum itself. This fixes #61593.
18265 Likely what happened is that corlib was wrong: mcs depended on
18266 this bug in some places. The bug got fixed, we had to add the
18267 hack, which caused bug 61593.
18269 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18270 that was a workaround for the older conditions.
18272 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18274 * assign.cs: IAssignMethod has a new interface, as documented
18275 inline. All assignment code now uses this new api.
18277 * ecore.cs, expression.cs: All classes which implement
18278 IAssignMethod now use the new interface.
18280 * expression.cs (Invocation): add a hack to EmitCall so that
18281 IndexerAccess can be the target of a compound assignment without
18282 evaluating its arguments twice.
18284 * statement.cs: Handle changes in Invocation api.
18286 2004-07-16 Martin Baulig <martin@ximian.com>
18288 * iterators.cs: Rewrote this. We're now using one single Proxy
18289 class for both the IEnumerable and the IEnumerator interface and
18290 `Iterator' derives from Class so we can use the high-level API.
18292 * class.cs (TypeContainer.AddIterator): New method.
18293 (TypeContainer.DoDefineType): New protected virtual method, which
18294 is called from DefineType().
18295 (TypeContainer.DoDefineMembers): Call DefineType() and
18296 DefineMembers() on all our iterators.
18297 (TypeContainer.Emit): Call Emit() on all our iterators.
18298 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18300 * codegen.cs (EmitContext.CurrentIterator): New public field.
18302 2004-07-15 Martin Baulig <martin@ximian.com>
18305 (TypeManager.not_supported_exception_type): New type.
18307 2004-07-14 Martin Baulig <martin@ximian.com>
18309 * iterators.cs: Use real error numbers.
18311 2004-07-14 Martin Baulig <martin@ximian.com>
18313 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18314 requires this to be a System.Collection.IEnumerable and not a
18315 class implementing that interface.
18316 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18318 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18320 * class.cs: Fixed previous fix, it broke some error tests.
18322 2004-07-12 Martin Baulig <martin@ximian.com>
18324 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18327 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18329 * assign.cs (LocalTemporary): Add new argument: is_address,If
18330 `is_address' is true, then the value that we store is the address
18331 to the real value, and not the value itself.
18333 * ecore.cs (PropertyExpr): use the new local temporary
18334 stuff to allow us to handle X.Y += z (where X is a struct)
18336 2004-07-08 Martin Baulig <martin@ximian.com>
18338 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18339 not always return, just like we're doing in Using.Resolve().
18341 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18343 * cs-parser.jay (fixed_statement): flag this as Pinned.
18345 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18347 * typemanager.cs (TypeManager): Removed MakePinned method, this
18348 mechanism is replaced with the .NET 2.x compatible mechanism of
18349 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18351 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18352 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18353 `IsFixed' property which has a different meaning.
18355 2004-07-02 Raja R Harinath <rharinath@novell.com>
18357 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18358 visible from inside a nested class, not just the names of the
18359 immediately enclosing class.
18360 Fix for bug #60730.
18362 2004-06-24 Raja R Harinath <rharinath@novell.com>
18364 * expression.cs (BetterConversion): Remove buggy special-case
18365 handling of "implicit constant expression conversions". At this
18366 point, we already know that the conversion is possible -- we're
18367 only checking to see which is better.
18369 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18371 * cs-parser.jay: Added error CS0210 test.
18373 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18375 * cs-parser.jay: Added error CS0134 test.
18377 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18380 * cs-parser.jay: Added error CS0145 test.
18382 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18384 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18386 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18388 * expression.cs (StackAlloc.Resolve): The argument may not
18389 be a constant; deal with this case.
18391 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18393 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18394 GetIndexerAttributeValue.
18395 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18397 * class.cs (Indexer.Define): Added error tests for CS0415,
18400 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18402 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18405 2004-06-23 Martin Baulig <martin@ximian.com>
18407 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18408 neither return nor throw, reset the barrier as well. Fixes #60457.
18410 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18412 * class.cs : EventAttributes is now set to None by default.
18413 This fixes bug #60459.
18415 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18418 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18419 Don't throw exception but return null (it's sufficient now).
18421 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18423 * typemanager.cs (GetArgumentTypes): Faster implementation.
18425 2004-06-18 Martin Baulig <martin@ximian.com>
18427 * attribute.cs (Attribute.Resolve): Check whether we're an
18428 EmptyCast which a Constant child. Fixes #60333.
18430 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18432 * statement.cs (EmitCollectionForeach): Account for the fact that
18433 not all valuetypes are in areas which we can take the address of.
18434 For these variables, we store to a temporary variable. Also, make
18435 sure that we dont emit a `callvirt' on a valuetype method.
18437 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18439 * expression.cs (StackAlloc.DoReSolve): Added test for
18440 negative parameter (CS0247).
18442 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18445 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18447 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18450 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18453 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18455 Fix bug #58254 & cs1555.cs, cs1556.cs
18456 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18458 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18460 * cs-parser.jay: Added error CS1669 test for indexers.
18462 2004-06-11 Martin Baulig <martin@ximian.com>
18464 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18465 call this twice: for params and varargs methods.
18467 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18470 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18472 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18474 * attribute.cs (Attribute.GetValidTargets): Made public.
18477 (AbstractPropertyEventMethod): New class for better code sharing.
18478 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18480 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18482 2004-06-11 Raja R Harinath <rharinath@novell.com>
18485 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18486 that the call to Resolve is part of a MemberAccess.
18487 (Expression.Resolve): Use it for SimpleName resolution.
18488 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18489 Add 'intermediate' boolean argument.
18490 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18491 error message when the SimpleName can be resolved ambiguously
18492 between an expression and a type.
18493 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18495 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18496 call on the left-side.
18498 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18501 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18503 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18505 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18507 2004-06-11 Martin Baulig <martin@ximian.com>
18509 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18510 varargs methods if applicable.
18512 2004-06-11 Martin Baulig <martin@ximian.com>
18514 * expression.cs (Invocation.EmitCall): Don't use
18515 `method.CallingConvention == CallingConventions.VarArgs' since the
18516 method could also have `CallingConventions.HasThis'.
18518 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18520 * class.cs (Event.GetSignatureForError): Implemented.
18521 Fixed crash in error test cs3010.cs
18523 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18525 * cs-tokenizer.cs: Change the way we track __arglist to be
18526 consistent with the other keywords.
18528 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18530 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18533 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18535 * codegen.cs: Check that all referenced assemblies have a strongname
18536 before strongnaming the compiled assembly. If not report error CS1577.
18537 Fix bug #56563. Patch by Jackson Harper.
18538 * typemanager.cs: Added a method to return all referenced assemblies.
18539 Fix bug #56563. Patch by Jackson Harper.
18541 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18544 (Method.ApplyAttributeBuilder): Moved and added conditional
18545 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18548 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18550 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18553 * class.cs: (EventField.attribute_targets): Changed default target.
18555 2004-06-08 Martin Baulig <martin@ximian.com>
18557 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18559 2004-06-08 Martin Baulig <martin@ximian.com>
18561 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18563 2004-06-07 Martin Baulig <martin@ximian.com>
18565 Added support for varargs methods.
18567 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18570 * cs-parser.jay: Added support for `__arglist'.
18572 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18574 * expression.cs (Argument.AType): Added `ArgList'.
18575 (Invocation): Added support for varargs methods.
18576 (ArglistAccess): New public class.
18577 (Arglist): New public class.
18579 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18581 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18582 a method's top-level block if the method has varargs.
18584 * support.cs (ReflectionParameters, InternalParameters): Added
18585 support for varargs methods.
18587 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18589 * class.cs: Provide location in indexer error report.
18591 * driver.cs: Use standard names.
18593 * namespace.cs: Catch the use of using after a namespace has been
18594 declared also on using aliases.
18596 2004-06-03 Raja R Harinath <rharinath@novell.com>
18599 * typemanager.cs (closure_private_ok, closure_invocation_type)
18600 (closure_qualifier_type, closure_invocation_assembly)
18601 (FilterWithClosure): Move to ...
18602 (Closure): New internal nested class.
18603 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18604 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18605 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18606 (MemberLookup, MemberLookupFailed): Use it.
18607 * expression.cs (New.DoResolve): Treat the lookup for the
18608 constructor as being qualified by the 'new'ed type.
18609 (Indexers.GetIndexersForTypeOrInterface): Update.
18611 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18614 (GetConditionalAttributeValue): New method. Returns
18615 condition of ConditionalAttribute.
18616 (SearchMulti): New method. Returns all attributes of type 't'.
18617 Use it when attribute is AllowMultiple = true.
18618 (IsConditionalMethodExcluded): New method.
18621 (Method.IsExcluded): Implemented. Returns true if method has conditional
18622 attribute and the conditions is not defined (method is excluded).
18623 (IMethodData): Extended interface for ConditionalAttribute support.
18624 (PropertyMethod.IsExcluded): Implemented.
18627 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18630 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18633 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18635 * expression.cs (ArrayCreationExpression): Make this just an
18636 `expression'. It can't be a statement, so the code here was
18639 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18642 * typemanager.cs (GetFullNameSignature): New method for
18645 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18648 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18649 Use this method when MethodBuilder is null.
18650 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18651 Added test for error CS0626 (MONO reports error for this situation).
18652 (IMethodData.GetSignatureForError): Extended interface.
18654 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18657 (AttributeTester.GetObsoleteAttribute): Returns instance of
18658 ObsoleteAttribute when type is obsolete.
18661 (TypeContainer.VerifyObsoleteAttribute): Override.
18662 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18663 (MethodCode.VerifyObsoleteAttribute): Override.
18664 (MemberBase.VerifyObsoleteAttribute): Override.
18667 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18668 and report proper error.
18671 Delegate.VerifyObsoleteAttribute): Override.
18674 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18675 and report proper error.
18676 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18679 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18683 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18684 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18685 Added test for ObsoleteAttribute.
18688 (Catch): Derived from Statement.
18690 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18692 Fixed bug #59071 & cs0160.cs
18694 * statement.cs (Try.Resolve): Check here whether order of catch
18695 clauses matches their dependencies.
18697 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18699 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18700 caused a regression: #59343. Referencing nested classes from an
18701 assembly stopped working.
18703 2004-05-31 Martin Baulig <martin@ximian.com>
18705 MCS is now frozen for beta 2.
18707 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18709 * convert.cs: add a trivial cache for overload operator resolution.
18711 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18713 * decl.cs: If possible, use lookuptypedirect here. We can only do
18714 this if there is no `.' after the namespace. Avoids using
18715 LookupType, which does lots of slow processing.
18716 (FindNestedType) New method, does what it says :-).
18717 * namespace.cs: use LookupTypeDirect.
18718 * rootcontext.cs: use membercache, if possible.
18719 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18721 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18724 According to the spec,
18726 In a member access of the form E.I, if E is a single identifier,
18727 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18728 field, property, localvariable, or parameter with the same type as
18729 the meaning of E as a type-name (§3.8), then both possible
18730 meanings of E are permitted.
18732 We did not check that E as a simple-name had the same type as E as
18735 This trivial check gives us 5-7% on bootstrap time.
18737 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18739 * expression.cs (Invocation.OverloadResolve): Avoid the
18740 use of hashtables and boxing here by allocating on demand.
18742 2004-05-30 Martin Baulig <martin@ximian.com>
18744 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18745 we're doing a silent lookup. Don't try to lookup nested types in
18746 TypeManager.object_type (thanks to Ben Maurer).
18748 2004-05-30 Martin Baulig <martin@ximian.com>
18750 Committing a patch from Ben Maurer.
18752 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18754 2004-05-29 Martin Baulig <martin@ximian.com>
18756 * class.cs (IMethodData.ShouldIgnore): New method.
18758 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18759 `Location' argument, we don't need it anywhere. Use
18760 `IMethodData.ShouldIgnore ()' instead of
18761 `MethodData.GetMethodFlags ()'.
18762 (TypeManager.AddMethod): Removed.
18763 (TypeManager.AddMethod2): Renamed to AddMethod.
18765 2004-05-29 Martin Baulig <martin@ximian.com>
18767 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18769 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18770 converting from a class type S to an interface type and we already
18771 have an object on the stack, don't box it again. Fixes #52578.
18773 2004-05-29 Martin Baulig <martin@ximian.com>
18775 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18776 Added support for `params' parameters. Fixes #59267.
18778 2004-05-29 Martin Baulig <martin@ximian.com>
18780 * literal.cs (NullPointer): Provide a private .ctor which sets
18781 `type' to TypeManager.object_type. Fixes #59048.
18783 2004-05-29 Martin Baulig <martin@ximian.com>
18785 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18786 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18788 * ecore.cs (EventExpr.instance_expr): Make the field private.
18790 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18792 Fixed bug #50080 & cs0214-2.cs
18793 * expression.cs (Cast.DoResolve): Check unsafe context here.
18795 * statement.cs (Resolve.DoResolve): Likewise.
18797 2004-05-26 Martin Baulig <martin@ximian.com>
18799 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18801 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18802 (RootContext.LookupType): Pass down the `silent' flag.
18804 2004-05-25 Martin Baulig <martin@ximian.com>
18807 (MethodGroupExpr.IdenticalTypeName): New public property.
18808 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18809 expression actually refers to a type.
18811 2004-05-25 Martin Baulig <martin@ximian.com>
18813 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18814 for #56176 and made it actually work.
18816 2004-05-25 Martin Baulig <martin@ximian.com>
18818 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18819 (FieldExpr, PropertyExpr): Override and implement
18820 CacheTemporaries. Fixes #52279.
18822 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18824 * location.cs: In the new compiler listing a file twice is a
18825 warning, not an error.
18827 2004-05-24 Martin Baulig <martin@ximian.com>
18829 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18830 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18832 2004-05-24 Martin Baulig <martin@ximian.com>
18834 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18835 walking the `using' list. Fixes #53921.
18837 2004-05-24 Martin Baulig <martin@ximian.com>
18839 * const.cs (Const.LookupConstantValue): Added support for
18840 EmptyCast's; fixes #55251.
18842 2004-05-24 Martin Baulig <martin@ximian.com>
18844 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18845 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18846 which does the CS0135 check. The reason is that we first need to
18847 check whether the variable actually exists.
18849 2004-05-24 Martin Baulig <martin@ximian.com>
18851 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18852 than RootContext.LookupType() to find the explicit interface
18853 type. Fixes #58584.
18855 2004-05-24 Raja R Harinath <rharinath@novell.com>
18857 * Makefile: Simplify. Use executable.make.
18858 * mcs.exe.sources: New file. List of sources of mcs.exe.
18860 2004-05-24 Anders Carlsson <andersca@gnome.org>
18864 Use the invariant culture when doing String.Compare for CLS case
18867 2004-05-23 Martin Baulig <martin@ximian.com>
18869 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18870 don't have any dots. Fixes #52622, added cs0246-8.cs.
18872 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18874 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18876 * class.cs (MemberBase.Define): Reuse MemberType member for
18877 resolved type. Other methods can use it too.
18879 2004-05-23 Martin Baulig <martin@ximian.com>
18881 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18882 the variable also exists in the current block (otherwise, we need
18883 to report a CS0103). Fixes #58670.
18885 2004-05-23 Martin Baulig <martin@ximian.com>
18887 * flowanalysis.cs (Reachability.Reachable): Compute this
18888 on-the-fly rather than storing it as a field.
18890 2004-05-23 Martin Baulig <martin@ximian.com>
18892 * flowanalysis.cs (Reachability.And): Manually compute the
18893 resulting `barrier' from the reachability.
18895 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18898 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18899 instance of ObsoleteAttribute when symbol is obsolete.
18902 (IMethodData): Extended interface for ObsoleteAttribute support.
18904 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18906 * attribute.cs: Fix bug #55970
18908 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18912 (GetObsoleteAttribute): New method. Creates the instance of
18914 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18915 ObsoleteAttribute when member is obsolete.
18916 (AttributeTester.Report_ObsoleteMessage): Common method for
18917 Obsolete error/warning reporting.
18920 (TypeContainer.base_classs_type): New member for storing parent type.
18923 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18924 for this MemberCore.
18926 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18928 * attribute.cs, const.cs: Fix bug #58590
18930 2004-05-21 Martin Baulig <martin@ximian.com>
18932 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18933 out parameters if the end of the method is unreachable. Fixes
18936 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18938 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18939 Hari was right, why extra method.
18941 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18943 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18945 2004-05-20 Martin Baulig <martin@ximian.com>
18947 Merged this back from gmcs to keep the differences to a minumum.
18949 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18950 instead of a Declspace.
18951 (Attribute.ResolveType): Likewise.
18952 (Attributes.Search): Likewise.
18953 (Attributes.Contains): Likewise.
18954 (Attributes.GetClsCompliantAttribute): Likewise.
18956 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18958 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18961 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18963 Fix bug #58688 (MCS does not report error when the same attribute
18966 * attribute.cs (Attribute.Emit): Distinction between null and default.
18968 2004-05-19 Raja R Harinath <rharinath@novell.com>
18970 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18971 of a top-level attribute without an attribute target.
18972 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18974 (Attribute.Conditional_GetConditionName),
18975 (Attribute.Obsolete_GetObsoleteMessage): Update.
18976 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18977 part of ScanForIndexerName.
18978 (Attribute.CanIgnoreInvalidAttribute): New function.
18979 (Attribute.ScanForIndexerName): Move to ...
18980 (Attributes.ScanForIndexerName): ... here.
18981 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18982 (Attributes.Search): New internal variant that can choose not to
18983 complain if types aren't resolved. The original signature now
18985 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18986 complaints suppressed.
18987 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18988 only if it not useful.
18989 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18990 top-level for attributes that are shared between the assembly
18991 and a top-level class.
18992 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18993 * class.cs: Update to reflect changes.
18994 (DefineIndexers): Fuse loops.
18995 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18996 a couple more variants of attribute names.
18998 2004-05-18 Marek Safar <marek.safar@seznam.cz>
19000 Fix bug #52585 (Implemented explicit attribute declaration)
19003 (Attributable.ValidAttributeTargets): New abstract method. It gets
19004 list of valid attribute targets for explicit target declaration.
19005 (Attribute.Target): It holds target itself.
19006 (AttributeSection): Removed.
19007 (Attribute.CheckTargets): New method. It checks whether attribute
19008 target is valid for the current element.
19011 (EventProperty): New class. For events that are declared like
19012 property (with add and remove accessors).
19013 (EventField): New class. For events that are declared like field.
19016 * cs-parser.jay: Implemented explicit attribute target declaration.
19018 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
19019 Override ValidAttributeTargets.
19022 (ReturnParameter): Class for applying custom attributes on
19024 (ParameterAtribute): New class. Class for applying custom
19025 attributes on the parameter type.
19027 2004-05-17 Miguel de Icaza <miguel@ximian.com>
19029 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
19032 (Method): Allow UNSAFE here.
19034 * modifiers.cs: Support unsafe reporting.
19036 2004-05-17 Marek Safar <marek.safar@seznam.cz>
19038 * decl.cs: Fix bug #58478.
19040 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19042 * statement.cs: When checking for unreachable code on an EmptyStatement,
19043 set the location. Fixes bug #58488.
19045 2004-05-13 Miguel de Icaza <miguel@ximian.com>
19047 * driver.cs: Add -pkg handling.
19049 From Gonzalo: UseShelLExecute=false
19051 2004-05-12 Marek Safar <marek.safar@seznam.cz>
19054 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
19056 (Attribute.IsClsCompliaceRequired): Moved to base for better
19058 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
19059 when attribute is AttributeUsageAttribute.
19060 (Attribute.GetValidTargets): Simplified.
19061 (Attribute.GetAttributeUsage): New method returns AttributeUsage
19062 attribute for this type.
19063 (Attribute.ApplyAttributes): Method renamed to Emit and make
19065 (GlobalAttributeSection): New class for special handling of global
19066 attributes (assembly, module).
19067 (AttributeSection.Emit): New method.
19069 * class.cs: Implemented Attributable abstract methods.
19070 (MethodCore.LabelParameters): Moved to Parameter class.
19071 (Accessor): Is back simple class.
19072 (PropertyMethod): Implemented Attributable abstract class.
19073 (DelegateMethod): Implemented Attributable abstract class.
19074 (Event): New constructor for disctintion between normal Event
19075 and Event with accessors.
19077 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
19079 * codegen.cs, const.cs, decl.cs, delegate.cs:
19080 (CommonAssemblyModulClass): Implemented Attributable abstract class
19083 * enum.cs: Implement IAttributeSupport interface.
19084 (EnumMember): New class for emum members. Implemented Attributable
19088 (ParameterBase): Is abstract.
19089 (ReturnParameter): New class for easier [return:] attribute handling.
19091 * typemanager.cs: Removed builder_to_attr.
19093 2004-05-11 Raja R Harinath <rharinath@novell.com>
19096 * attribute.cs (Attribute.GetPositionalValue): New function.
19097 * class.cs (TypeContainer.VerifyMembers): New function.
19098 (TypeContainer.Emit): Use it.
19099 (ClassOrStruct): New base class for Class and Struct.
19100 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
19101 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
19103 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
19104 then each non-static field should have a FieldOffset attribute.
19105 Otherwise, none of the fields should have a FieldOffset attribute.
19106 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
19107 and FieldOffset attributes.
19108 * typemanager.cs (TypeManager.struct_layout_attribute_type)
19109 (TypeManager.field_offset_attribute_type): New core types.
19110 (TypeManager.InitCoreTypes): Initialize them.
19112 2004-05-11 Michal Moskal <malekith@pld-linux.org>
19114 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
19115 Return correct type.
19118 2004-05-09 Miguel de Icaza <miguel@ximian.com>
19120 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
19121 be implicitly converted to ulong.
19123 * expression.cs: The logic for allowing operator &, | and ^ worked
19124 was wrong, it worked before because we did not report an error in
19125 an else branch. Fixes 57895.
19127 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
19128 allow volatile fields to be reference types.
19130 2004-05-07 Miguel de Icaza <miguel@ximian.com>
19132 * driver.cs: Add support for /debug-
19134 2004-05-07 Raja R Harinath <rharinath@novell.com>
19136 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
19137 Add a 'complain' parameter to silence errors.
19138 (Attribute.Resolve): Update to changes. Put in sanity check to catch
19139 silently overlooked type-resolutions.
19140 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
19141 to reflect changes.
19142 (Attributes.Search): New function.
19143 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
19144 (Attributes.GetAttributeFullName): Remove hack.
19145 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
19146 Update to reflect changes.
19147 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
19148 Use Attributes.Search instead of nested loops.
19150 2004-05-07 Marek Safar <marek.safar@seznam.cz>
19153 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
19154 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
19155 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
19157 * report.cs: (Report.Warning): Renamed to Warning_T because of
19158 parameter collision.
19160 2004-05-05 Raja R Harinath <rharinath@novell.com>
19162 * expression.cs (MemberAccess.ResolveMemberAccess):
19163 Exit with non-zero status after Report.Error.
19164 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
19166 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
19168 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19170 * support.cs: Don't hang when the file is empty.
19172 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19174 * support.cs: In SeekableStreamReader, compute the preamble size of the
19175 underlying stream. Position changes should take into account that initial
19178 2004-05-03 Todd Berman <tberman@sevenl.net>
19180 * driver.cs: remove unused GetSysVersion function.
19182 2004-05-03 Todd Berman <tberman@sevenl.net>
19184 * driver.cs: Remove the hack from saturday, as well as the hack
19185 from jackson (LoadAssemblyFromGac), also adds the CWD to the
19186 link_paths to get that bit proper.
19188 2004-05-01 Todd Berman <tberman@sevenl.net>
19190 * driver.cs: Try a LoadFrom before a Load, this checks the current
19191 path. This is currently a bug in mono that is be fixed, however, this
19192 provides a workaround for now. This will be removed when the bug
19195 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
19197 * CryptoConvert.cs: Updated to latest version. Fix issue with
19198 incomplete key pairs (#57941).
19200 2004-05-01 Todd Berman <tberman@sevenl.net>
19202 * driver.cs: Remove '.' from path_chars, now System.* loads properly
19205 2004-04-30 Jackson Harper <jackson@ximian.com>
19207 * codegen.cs: Open keys readonly.
19209 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19211 * typemanager.cs: don't report cyclic struct layout when a struct
19212 contains 2 or more fields of the same type. Failed for Pango.AttrShape
19213 which has 2 Pango.Rectangle fields.
19215 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
19217 * expression.cs: Handle IntPtr comparisons with IL code
19218 rather than a method call.
19220 2004-04-29 Martin Baulig <martin@ximian.com>
19222 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
19223 the list of PropertyInfo's in class hierarchy and find the
19224 accessor. Fixes #56013.
19226 2004-04-29 Martin Baulig <martin@ximian.com>
19228 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
19230 2004-04-29 Martin Baulig <martin@ximian.com>
19232 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19234 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
19236 2004-04-29 Martin Baulig <martin@ximian.com>
19238 * class.cs (ConstructorInitializer.Resolve): Check whether the
19239 parent .ctor is accessible. Fixes #52146.
19241 2004-04-29 Martin Baulig <martin@ximian.com>
19243 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19245 * statement.cs (Using.EmitLocalVariableDecls): Use
19246 TypeManager.idisposable_type, not typeof (IDisposable).
19247 (Foreach.EmitCollectionForeach): Added support for valuetypes.
19249 2004-04-29 Martin Baulig <martin@ximian.com>
19251 * class.cs (Event.Define): Don't emit the field and don't set
19252 RTSpecialName and SpecialName for events on interfaces. Fixes
19255 2004-04-29 Raja R Harinath <rharinath@novell.com>
19257 Refactor Attribute.ApplyAttributes.
19258 * attribute.cs (Attributable): New base class for objects that can
19259 have Attributes applied on them.
19260 (Attribute): Make AttributeUsage fields public.
19261 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19262 (Attribute.IsInternalCall): New property.
19263 (Attribute.UsageAttr): Convert to a public read-only property.
19264 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19265 (Attribute.ResolveType, Attribute.Resolve)
19266 (Attribute.ScanForIndexerName): Update to reflect changes.
19267 (Attribute.CheckAttributeTarget): Re-format.
19268 (Attribute.ApplyAttributes): Refactor, to various
19269 Attributable.ApplyAttributeBuilder methods.
19270 * decl.cs (MemberCore): Make Attributable.
19271 * class.cs (Accessor): Make Attributable.
19272 (MethodData.ApplyAttributes): Use proper attribute types, not
19274 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19275 (TypeContainer.ApplyAttributeBuilder)
19276 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19277 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19278 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19279 (Operator.ApplyAttributeBuilder): New factored-out methods.
19280 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19281 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19282 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19283 * parameter.cs (ParameterBase): New Attributable base class
19284 that can also represent Return types.
19285 (Parameter): Update to the changes.
19287 2004-04-29 Jackson Harper <jackson@ximian.com>
19289 * driver.cs: Prefer the corlib system version when looking for
19290 assemblies in the GAC. This is still a hack, but its a better hack
19293 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19295 * decl.cs, enum.cs: Improved error 3005 reporting.
19297 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19298 (related_symbols): New private member for list of symbols
19299 related to reported error/warning.
19301 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19303 2004-04-29 Martin Baulig <martin@ximian.com>
19305 * ecore.cs (Expression.Constantify): If we're an enum and
19306 TypeManager.TypeToCoreType() doesn't give us another type, use
19307 t.UnderlyingSystemType. Fixes #56178.
19309 2004-04-29 Martin Baulig <martin@ximian.com>
19311 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19312 interfaces and for each interface, only add members directly
19313 declared in that interface. Fixes #53255.
19315 2004-04-28 Martin Baulig <martin@ximian.com>
19317 * expression.cs (ConditionalLogicalOperator): Use a temporary
19318 variable for `left' to avoid that we evaluate it more than once;
19321 2004-04-28 Martin Baulig <martin@ximian.com>
19323 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19326 2004-04-28 Martin Baulig <martin@ximian.com>
19328 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19331 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19332 whether the type is not void (CS1547).
19334 2004-04-28 Martin Baulig <martin@ximian.com>
19336 * expression.cs (Unary.DoResolveLValue): Override this and report
19337 CS0131 for anything but Operator.Indirection.
19339 2004-04-28 Martin Baulig <martin@ximian.com>
19341 Committing a patch from Ben Maurer; see bug #50820.
19343 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19346 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19349 2004-04-28 Martin Baulig <martin@ximian.com>
19351 Committing a patch from Ben Maurer; see bug #50820.
19353 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19356 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19359 2004-04-28 Martin Baulig <martin@ximian.com>
19361 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19362 (Block.AddLabel): Call DoLookupLabel() to only search in the
19365 2004-04-28 Martin Baulig <martin@ximian.com>
19367 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19368 comparing StringConstants and NullLiterals in Equality and Inequality.
19370 2004-04-28 Jackson Harper <jackson@ximian.com>
19372 * driver.cs: Attempt to load referenced assemblies from the
19373 GAC. This is the quick and dirty version of this method that
19374 doesnt take into account versions and just takes the first
19375 canidate found. Will be good enough for now as we will not have more
19376 then one version installed into the GAC until I update this method.
19378 2004-04-28 Martin Baulig <martin@ximian.com>
19380 * typemanager.cs (TypeManager.CheckStructCycles): New public
19381 static method to check for cycles in the struct layout.
19383 * rootcontext.cs (RootContext.PopulateTypes): Call
19384 TypeManager.CheckStructCycles() for each TypeContainer.
19385 [Note: We only need to visit each type once.]
19387 2004-04-28 Martin Baulig <martin@ximian.com>
19389 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19391 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19392 success and added `out object value'. Use a `bool resolved' field
19393 to check whether we've already been called rather than
19394 `ConstantValue != null' since this breaks for NullLiterals.
19396 2004-04-28 Raja R Harinath <rharinath@novell.com>
19398 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19399 setting of this flag, since the 'set' method may be non-public.
19401 2004-04-28 Raja R Harinath <rharinath@novell.com>
19403 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19404 check on current_vector.Block.
19406 2004-04-27 Martin Baulig <martin@ximian.com>
19408 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19409 a field initializer. Fixes #56459.
19411 2004-04-27 Martin Baulig <martin@ximian.com>
19413 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19414 we're not attempting to use an indexer. Fixes #52154.
19416 2004-04-27 Martin Baulig <martin@ximian.com>
19418 * statement.cs (Return): Don't create a return label if we don't
19419 need it; reverts my change from January 20th. Thanks to Ben
19422 2004-04-27 Martin Baulig <martin@ximian.com>
19424 According to the spec, `goto' can only leave a nested scope, but
19427 * statement.cs (Block.LookupLabel): Only lookup in the current
19428 block, don't recurse into parent or child blocks.
19429 (Block.AddLabel): Check in parent and child blocks, report
19430 CS0140/CS0158 if we find a duplicate.
19431 (Block): Removed this indexer for label lookups.
19432 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19433 this already does the error reporting for us.
19436 (FlowBranching.UsageVector.Block): New public variable; may be null.
19437 (FlowBranching.CreateSibling): Added `Block' argument.
19438 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19439 label for the target of a `goto' and check whether we're not
19440 leaving a `finally'.
19442 2004-04-27 Martin Baulig <martin@ximian.com>
19444 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19445 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19448 2004-04-27 Martin Baulig <martin@ximian.com>
19450 * statement.cs (Block.AddLabel): Also check for implicit blocks
19451 and added a CS0158 check.
19453 2004-04-27 Martin Baulig <martin@ximian.com>
19455 * flowanalysis.cs (FlowBranchingLoop): New class.
19456 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19457 UsageVector's instead of an ArrayList.
19458 (FlowBranching.Label): Likewise.
19459 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19460 (FlowBranching.AddBreakVector): New method.
19462 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19464 * attribute.cs: Small regression fix: only convert the type if we
19465 the type is different, fixes System.Drawing build.
19467 2004-04-27 Martin Baulig <martin@ximian.com>
19469 * attribute.cs (Attribute.Resolve): If we have a constant value
19470 for a named field or property, implicity convert it to the correct
19473 2004-04-27 Raja R Harinath <rharinath@novell.com>
19475 * statement.cs (Block.Block): Implicit blocks share
19476 'child_variable_names' fields with parent blocks.
19477 (Block.AddChildVariableNames): Remove.
19478 (Block.AddVariable): Mark variable as "used by a child block" in
19479 every surrounding block.
19480 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19481 been used in a child block, complain about violation of "Invariant
19482 meaning in blocks" rule.
19483 * cs-parser.jay (declare_local_variables): Don't use
19484 AddChildVariableNames.
19485 (foreach_statement): Don't create an implicit block: 'foreach'
19486 introduces a scope.
19488 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19490 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19491 converting from 0L to ulong. Fixes 57522.
19493 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19495 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19496 derived class hides via 'new' keyword field from base class (test-242.cs).
19497 TODO: Handle this in the more general way.
19499 * class.cs (CheckBase): Ditto.
19501 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19503 * decl.cs (caching_flags): New member for storing cached values
19505 (MemberCore.Flags): New enum where bit flags for caching_flags
19507 (MemberCore.cls_compliance): Moved to caching_flags.
19508 (DeclSpace.Created): Moved to caching_flags.
19510 * class.cs: Use caching_flags instead of DeclSpace.Created
19512 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19514 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19515 if we are only a derived class, not a nested class.
19517 * typemanager.cs: Same as above, but do this at the MemberLookup
19518 level (used by field and methods, properties are handled in
19519 PropertyExpr). Allow for the qualified access if we are a nested
19522 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19524 * class.cs: Refactoring.
19525 (IMethodData): New inteface; Holds links to parent members
19526 to avoid member duplication (reduced memory allocation).
19527 (Method): Implemented IMethodData interface.
19528 (PropertyBase): New inner classes for get/set methods.
19529 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19530 (Event): New inner classes for add/remove methods.
19531 (Event.DelegateMethod): Implemented IMethodData interface.
19533 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19534 EmitContext (related to class.cs refactoring).
19536 2004-04-21 Raja R Harinath <rharinath@novell.com>
19538 * delegate.cs (Delegate.VerifyApplicability): If the number of
19539 arguments are the same as the number of parameters, first try to
19540 verify applicability ignoring any 'params' modifier on the last
19544 2004-04-16 Raja R Harinath <rharinath@novell.com>
19546 * class.cs (TypeContainer.AddIndexer): Use
19547 'ExplicitInterfaceName' to determine if interface name was
19548 explicitly specified. 'InterfaceType' is not initialized at this time.
19549 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19550 Indexers array is already in the required order. Initialize
19551 'IndexerName' only if there are normal indexers.
19552 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19553 (TypeContainer.Emit): Emit DefaultMember attribute only if
19554 IndexerName is initialized.
19557 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19559 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19562 2004-04-15 Raja R Harinath <rharinath@novell.com>
19564 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19568 * attribute.cs (Attribute.Resolve): Check for duplicate named
19572 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19574 * iterators.cs (MarkYield): track whether we are in an exception,
19575 and generate code accordingly. Use a temporary value to store the
19576 result for our state.
19578 I had ignored a bit the interaction of try/catch with iterators
19579 since their behavior was not entirely obvious, but now it is
19580 possible to verify that our behavior is the same as MS .NET 2.0
19584 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19586 * iterators.cs: Avoid creating temporaries if there is no work to
19589 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19590 Enumerations, use TypeManager.EnumToUnderlying and call
19593 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19596 (This.Emit): Use EmitContext.EmitThis to emit our
19599 (This.EmitAssign): Ditto.
19601 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19602 codepaths, we will move all the functionality into
19605 (FieldExpr.EmitAssign): Ditto.
19607 This fixes several hidden bugs that I uncovered while doing a code
19608 review of this today.
19610 * codegen.cs (EmitThis): reworked so the semantics are more clear
19611 and also support value types "this" instances.
19613 * iterators.cs: Changed so that for iterators in value types, we
19614 do not pass the value type as a parameter.
19616 Initialization of the enumerator helpers is now done in the caller
19617 instead of passing the parameters to the constructors and having
19618 the constructor set the fields.
19620 The fields have now `assembly' visibility instead of private.
19622 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19624 * expression.cs (Argument.Resolve): Check if fields passed as ref
19625 or out are contained in a MarshalByRefObject.
19627 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19628 another compiler type.
19630 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19632 * class.cs (Indexer.Define): use the new name checking method.
19633 Also, return false on an error.
19634 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19635 (is_identifier_[start/part]_character): make static.
19637 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19639 * expression.cs (Binary.ResolveOperator): Do no append strings
19640 twice: since we can be invoked more than once (array evaluation)
19641 on the same concatenation, take care of this here. Based on a fix
19642 from Ben (bug #56454)
19644 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19646 * codegen.cs: Fix another case where CS1548 must be reported (when
19647 delay-sign isn't specified and no private is available #56564). Fix
19648 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19649 error when MCS is used on the MS runtime and we need to delay-sign
19650 (which seems unsupported by AssemblyBuilder - see #56621).
19652 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19654 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19655 (TypeManager.ComputeNamespaces): Faster implementation for
19658 * compiler.csproj: Updated AssemblyName to mcs.
19660 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19662 * rootcontext.cs: Add new types to the boot resolution.
19664 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19665 MulticastDelegate is not allowed.
19667 * typemanager.cs: Add new types to lookup: System.TypedReference
19670 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19671 check for TypedReference or ArgIterator, they are not allowed.
19673 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19674 makes us properly catch 1510 in some conditions (see bug 56016 for
19677 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19679 * CryptoConvert.cs: update from corlib version
19682 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19684 * class.cs (Indexer.Define): Check indexername declaration
19686 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19688 * attribute.cs (IsClsCompliant): Fixed problem with handling
19689 all three states (compliant, not-compliant, undetected).
19691 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19693 * attribute.cs (Attribute): Location is now public.
19694 (Resolve): Store resolved arguments (pos_values) in attribute class.
19695 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19696 (GetClsCompliantAttributeValue): New method that gets
19697 CLSCompliantAttribute value.
19698 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19699 if exists else null.
19700 (AttributeTester): New class for CLS-Compliant verification routines.
19702 * class.cs (Emit): Add CLS-Compliant verification.
19703 (Method.GetSignatureForError): Implemented.
19704 (Constructor.GetSignatureForError): Implemented
19705 (Constructor.HasCompliantArgs): Returns if constructor has
19706 CLS-Compliant arguments.
19707 (Constructor.Emit): Override.
19708 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19709 is needed to test only parameters.
19710 (FieldBase.GetSignatureForError): Implemented.
19711 (TypeContainer): New member for storing base interfaces.
19712 (TypeContainer.FindMembers): Search in base interfaces too.
19714 * codegen.cs (GetClsComplianceAttribute): New method that gets
19715 assembly or module CLSCompliantAttribute value.
19716 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19718 (ModuleClass.Emit): Add error 3012 test.
19720 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19722 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19723 state for all decl types.
19724 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19725 if CLS-Compliant tests are required.
19726 (IsClsCompliaceRequired): New method. Analyze whether code
19727 must be CLS-Compliant.
19728 (IsExposedFromAssembly): New method. Returns true when MemberCore
19729 is exposed from assembly.
19730 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19731 value or gets cached value.
19732 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19733 is explicitly marked with CLSCompliantAttribute.
19734 (IsIdentifierClsCompliant): New abstract method. This method is
19735 used to testing error 3005.
19736 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19737 for identifier and parameters CLS-Compliant testing.
19738 (VerifyClsCompliance): New method. The main virtual method for
19739 CLS-Compliant verifications.
19740 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19741 null. I don't know why is null (too many public members !).
19742 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19743 and get value of first CLSCompliantAttribute that found.
19745 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19746 (VerifyClsCompliance): Override and add extra tests.
19748 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19749 clscheck- disable CLS-Compliant verification event if assembly is has
19750 CLSCompliantAttribute(true).
19752 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19753 ApllyAttribute is now called in emit section as in the other cases.
19754 Possible future Emit integration.
19755 (IsIdentifierClsCompliant): New override.
19756 (VerifyClsCompliance): New override.
19757 (GetEnumeratorName): Returns full enum name.
19759 * parameter.cs (GetSignatureForError): Implemented.
19761 * report.cs (WarningData): New struct for Warning message information.
19762 (LocationOfPreviousError): New method.
19763 (Warning): New method. Reports warning based on the warning table.
19764 (Error_T): New method. Reports error based on the error table.
19766 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19767 verifications are done here.
19769 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19771 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19772 CLSCompliantAttribute.
19773 (all_imported_types): New member holds all imported types from other
19775 (LoadAllImportedTypes): New method fills static table with exported types
19776 from all referenced assemblies.
19777 (Modules): New property returns all assembly modules.
19779 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19781 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19782 throwing a parser error.
19784 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19785 which removes the hardcoded get_/set_ prefixes for properties, as
19786 IL allows for the properties to be named something else.
19790 * expression.cs: Do not override operand before we know if it is
19791 non-null. Fix 56207
19793 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19795 * typemanager.cs: support for pinned variables.
19797 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19799 * decl.cs, typemanager.cs: Avoid using an arraylist
19800 as a buffer if there is only one result set.
19802 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19804 * expression.cs: Make sure you cant call a static method
19805 with an instance expression, bug #56174.
19807 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19809 * class.cs (IsDuplicateImplementation): Improve error reporting to
19810 flag 663 (method only differs in parameter modifier).
19812 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19813 in preprocessor directives.
19815 * location.cs (LookupFile): Allow for the empty path.
19817 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19818 better approach for some of that patch, but its failing with the
19819 CharSet enumeration. For now try/catch will do.
19821 * typemanager.cs: Do not crash if a struct does not have fields.
19824 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19826 * expression.cs: cs0213, cant fix a fixed expression.
19829 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19831 * cs-parser.jay: detect invalid embeded statements gracefully.
19834 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19836 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19839 the invocation type may not be a subclass of the tye of the item/
19840 The type of the item must be a subclass of the invocation item.
19845 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19847 * attribute.cs: Added methods to get a string and a bool from an
19848 attribute. Required to information from AssemblyKeyFileAttribute,
19849 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19850 * codegen.cs: Modified AssemblyName creation to include support for
19851 strongnames. Catch additional exceptions to report them as CS1548.
19852 * compiler.csproj: Updated include CryptoConvert.cs.
19853 * compiler.csproj.user: Removed file - user specific configuration.
19854 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19855 Mono.Security assembly. The original class is maintained and tested in
19856 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19857 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19858 like CSC 8.0 (C# v2) supports.
19859 * Makefile: Added CryptoConvert.cs to mcs sources.
19860 * rootcontext.cs: Added new options for strongnames.
19862 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19864 * driver.cs: For --expect-error, report error code `2'
19865 if the program compiled with no errors, error code `1' if
19866 it compiled with an error other than the one expected.
19868 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19870 * compiler.csproj: Updated for Visual Studio .NET 2003.
19871 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19872 * compiler.sln: Updated for Visual Studio .NET 2003.
19874 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19876 * expression.cs: Fix bug #47234. We basically need to apply the
19877 rule that we prefer the conversion of null to a reference type
19878 when faced with a conversion to 'object' (csc behaviour).
19880 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19882 * statement.cs: Shorter form for foreach, eliminates
19883 a local variable. r=Martin.
19885 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19887 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19888 checks if we can use brtrue/brfalse to test for 0.
19889 * expression.cs: use the above in the test for using brtrue/brfalse.
19890 cleanup code a bit.
19892 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19894 * expression.cs: Rewrite string concat stuff. Benefits:
19896 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19897 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19898 rather than a concat chain.
19900 * typemanager.cs: Add lookups for more concat overloads.
19902 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19904 * expression.cs: Emit shorter il code for array init.
19921 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19923 * statement.cs: Before, two switch blocks would be merged if the
19924 total size of the blocks (end_item - begin_item + 1) was less than
19925 two times the combined sizes of the blocks.
19927 Now, it will only merge if after the merge at least half of the
19932 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19934 * class.cs : csc build fix for GetMethods(). See bug #52503.
19936 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19938 * expression.cs: Make sure fp comparisons work with NaN.
19939 This fixes bug #54303. Mig approved this patch a long
19940 time ago, but we were not able to test b/c the runtime
19943 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19945 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19947 2004-03-19 Martin Baulig <martin@ximian.com>
19949 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19950 error here and not in our caller.
19952 2004-03-19 Martin Baulig <martin@ximian.com>
19954 * interface.cs: Completely killed this file.
19955 (Interface): We're now a TypeContainer and live in class.cs.
19957 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19958 argument; we're now also called for interfaces.
19959 (TypeContainer.DefineMembers): Allow this method being called
19961 (TypeContainer.GetMethods): New public method; formerly known as
19962 Interface.GetMethod(). This is used by PendingImplementation.
19963 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19964 it's now private and non-static.
19965 (Interface): Moved this here; it's now implemented similar to
19967 (Method, Property, Event, Indexer): Added `bool is_interface'
19968 argument to their .ctor's.
19969 (MemberBase.IsInterface): New public field.
19971 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19972 instances instead of InterfaceMethod, InterfaceProperty, etc.
19973 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19974 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19976 2004-03-19 Martin Baulig <martin@ximian.com>
19978 * class.cs (MethodCore.IsDuplicateImplementation): New private
19979 method which does the CS0111 checking.
19980 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19981 Use IsDuplicateImplementation().
19983 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19985 * decl.cs (FindMemberToOverride): New method to find the correct
19986 method or property to override in the base class.
19988 - Make Method/Property use the above method to find the
19989 version in the base class.
19990 - Remove the InheritableMemberSignatureCompare as it is now
19993 This patch makes large code bases much faster to compile, as it is
19994 O(n) rather than O(n^2) to do this validation.
19996 Also, it fixes bug 52458 which is that nested classes are not
19997 taken into account when finding the base class member.
19999 Reviewed/Approved by Martin.
20001 2004-03-17 Marek Safar <marek.safar@seznam.cz>
20003 * interface.cs: In all interface classes removed redundant
20004 member initialization.
20006 2004-03-16 Martin Baulig <martin@ximian.com>
20008 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
20010 2004-03-15 Miguel de Icaza <miguel@ximian.com>
20012 * decl.cs (DefineTypeAndParents): New helper method to define a
20013 type's containers before the type itself is defined; This is a
20014 bug exposed by the recent changes to Windows.Forms when an
20015 implemented interface was defined inside a class that had not been
20018 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
20020 (Check): Loop correctly to report errors modifiers
20021 (UNSAFE was not in the loop, since it was the same as TOP).
20023 * interface.cs: Every interface member now takes a ModFlags,
20024 instead of a "is_new" bool, which we set on the base MemberCore.
20026 Every place where we called "UnsafeOk" in the interface, now we
20027 call the proper member (InterfaceMethod.UnsafeOK) instead to get
20028 the unsafe settings from the member declaration instead of the
20029 container interface.
20031 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
20033 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
20034 `set_indexer_name' to the pending bits (one per type).
20036 We fixed a bug today that was picking the wrong method to
20037 override, since for properties the existing InterfaceMethod code
20038 basically ignored the method name. Now we make sure that the
20039 method name is one of the valid indexer names.
20041 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
20043 * support.cs (SeekableStreamReader): Keep track of stream byte
20044 positions and don't mix them with character offsets to the buffer.
20046 Patch from Gustavo Giráldez
20048 2004-03-15 Marek Safar <marek.safar@seznam.cz>
20050 * interface.cs (InterfaceSetGetBase): Removed double member
20051 initialization, base class does it as well.
20053 2004-03-13 Martin Baulig <martin@ximian.com>
20055 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
20056 when compiling corlib.
20058 2004-03-13 Miguel de Icaza <miguel@ximian.com>
20060 * convert.cs (ExplicitConversion): We were reporting an error on
20061 certain conversions (object_type source to a value type, when the
20062 expression was `null') before we had a chance to pass it through
20063 the user defined conversions.
20065 * driver.cs: Replace / and \ in resource specifications to dots.
20068 * class.cs: Add check for duplicate operators. Fixes 52477
20070 2004-03-11 Miguel de Icaza <miguel@ximian.com>
20072 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
20073 that are in the middle of the statements, not only at the end.
20076 * class.cs (TypeContainer.AddField): No longer set the
20077 `HaveStaticConstructor' flag, now we call it
20078 `UserDefineStaticConstructor' to diferentiate the slightly
20079 semantic difference.
20081 The situation is that we were not adding BeforeFieldInit (from
20082 Modifiers.TypeAttr) to classes that could have it.
20083 BeforeFieldInit should be set to classes that have no static
20088 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
20090 And most importantly Zoltan's comment:
20092 http://bugzilla.ximian.com/show_bug.cgi?id=44229
20094 "I think beforefieldinit means 'it's ok to initialize the type sometime
20095 before its static fields are used', i.e. initialization does not need
20096 to be triggered by the first access to the type. Setting this flag
20097 helps the JIT to compile better code, since it can run the static
20098 constructor at JIT time, and does not need to generate code to call it
20099 (possibly lots of times) at runtime. Unfortunately, mcs does not set
20100 this flag for lots of classes like String.
20102 csc sets this flag if the type does not have an explicit static
20103 constructor. The reasoning seems to be that if there are only static
20104 initalizers for a type, and no static constructor, then the programmer
20105 does not care when this initialization happens, so beforefieldinit
20108 This bug prevents the AOT compiler from being usable, since it
20109 generates so many calls to mono_runtime_class_init that the AOT code
20110 is much slower than the JITted code. The JITted code is faster,
20111 because it does not generate these calls if the vtable is type is
20112 already initialized, which is true in the majority of cases. But the
20113 AOT compiler can't do this."
20115 2004-03-10 Miguel de Icaza <miguel@ximian.com>
20117 * class.cs (MethodData.Emit): Refactor the code so symbolic
20118 information is generated for destructors; For some reasons we
20119 were taking a code path that did not generate symbolic information
20122 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
20124 * class.cs: Create a Constructor.CheckBase method that
20125 takes care of all validation type code. The method
20126 contains some code that was moved from Define.
20128 It also includes new code that checks for duplicate ctors.
20129 This fixes bug #55148.
20131 2004-03-09 Joshua Tauberer <tauberer@for.net>
20133 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
20134 a { ... }-style array creation invokes EmitStaticInitializers
20135 which is not good for reference-type arrays. String, decimal
20136 and now null constants (NullCast) are not counted toward
20137 static initializers.
20139 2004-03-05 Martin Baulig <martin@ximian.com>
20141 * location.cs (SourceFile.HasLineDirective): New public field;
20142 specifies whether the file contains or is referenced by a "#line"
20144 (Location.DefineSymbolDocuments): Ignore source files which
20145 either contain or are referenced by a "#line" directive.
20147 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
20149 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
20150 direct access to our parent, so check the method inline there.
20152 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
20154 * expression.cs (Invocation.EmitCall): Miguel's last commit
20155 caused a regression. If you had:
20160 In Foo the implict this would be null.
20162 2004-02-27 Miguel de Icaza <miguel@ximian.com>
20164 * expression.cs (Invocation.EmitCall): If the method is not
20165 virtual, do not emit a CallVirt to it, use Call.
20167 * typemanager.cs (GetFullNameSignature): Improve the method to
20168 cope with ".ctor" and replace it with the type name.
20170 * class.cs (ConstructorInitializer.Resolve): Now the method takes
20171 as an argument the ConstructorBuilder where it is being defined,
20172 to catch the recursive constructor invocations.
20174 2004-02-26 Miguel de Icaza <miguel@ximian.com>
20176 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
20177 routines to check if a type is an enumerable/enumerator allow
20178 classes that implement the IEnumerable or IEnumerator interfaces.
20180 * class.cs (Property, Operator): Implement IIteratorContainer, and
20181 implement SetYields.
20183 (Property.Define): Do the block swapping for get_methods in the
20184 context of iterators. We need to check if Properties also
20185 include indexers or not.
20187 (Operator): Assign the Block before invoking the
20188 OperatorMethod.Define, so we can trigger the Iterator code
20191 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
20192 Property and Operator classes are not created when we parse the
20193 declarator but until we have the block completed, so we use a
20194 singleton SimpleIteratorContainer.Simple to flag whether the
20195 SetYields has been invoked.
20197 We propagate this setting then to the Property or the Operator to
20198 allow the `yield' to function.
20200 2004-02-25 Marek Safar <marek.safar@seznam.cz>
20202 * codegen.cs: Implemented attribute support for modules.
20203 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
20204 Assembly/Module functionality.
20206 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
20207 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
20208 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
20210 2004-02-16 Marek Safar <marek.safar@seznam.cz>
20212 * interface.cs (FindMembers): The operation is performed on all base
20213 interfaces and not only on the first. It is required for future CLS Compliance patch.
20215 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
20217 * statement.cs, codegen.cs:
20218 This patch deals with patterns such as:
20220 public class List : IEnumerable {
20222 public MyEnumerator GetEnumerator () {
20223 return new MyEnumerator(this);
20226 IEnumerator IEnumerable.GetEnumerator () {
20230 public struct MyEnumerator : IEnumerator {
20235 Before, there were a few things we did wrong:
20236 1) we would emit callvirt on a struct, which is illegal
20237 2) we emited ldarg when we needed to emit ldarga
20238 3) we would mistakenly call the interface methods on an enumerator
20239 type that derived from IEnumerator and was in another assembly. For example:
20241 public class MyEnumerator : IEnumerator
20243 Would have the interface methods called, even if there were public impls of the
20244 method. In a struct, this lead to invalid IL code.
20246 2004-02-11 Marek Safar <marek.safar@seznam.cz>
20248 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
20251 * delegate.cs (Define): Fixed crash when delegate type is undefined.
20253 2004-02-11 Miguel de Icaza <miguel@ximian.com>
20255 * cs-parser.jay: Fix small regression: we were not testing V2
20256 compiler features correctly.
20258 * interface.cs: If the emit context is null, then create one
20260 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20262 * decl.cs (GetSignatureForError): New virtual method to get full name
20263 for error messages.
20265 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20266 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20268 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20269 Duplicated members and code in these classes has been removed.
20270 Better encapsulation in these classes.
20272 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20274 * assign.cs (Assign.DoResolve): When dealing with compound
20275 assignments, there is a new rule in ECMA C# 2.4 (might have been
20276 there before, but it is documented here) that states that in:
20280 If b is of type int, and the `op' is a shift-operator, then the
20281 above is evaluated as:
20285 * expression.cs (Binary.ResolveOperator): Instead of testing for
20286 int/uint/long/ulong, try to implicitly convert to any of those
20287 types and use that in pointer arithmetic.
20289 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20290 method to print information for from the type, not from the
20291 null-method we were given.
20293 2004-02-01 Duncan Mak <duncan@ximian.com>
20295 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20296 parsing for cmd, fixes bug #53694.
20298 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20300 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20301 in the member name duplication tests. Property and operator name duplication
20302 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20304 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20306 * interface.cs (PopulateMethod): Fixed crash when interface method
20307 returns not existing type (error test cs0246-3.cs).
20309 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20311 * cs-parser.jay (interface_accessors): Re-write actions to also
20312 store attributes attached to get and set methods. Fix spelling
20315 (inteface_property_declaration): Modify accordingly.
20317 (InterfaceAccessorInfo): New helper class to store information to pass
20318 around between rules that use interface_accessors.
20320 * interface.cs (Emit): Apply attributes on the get and set
20321 accessors of properties and indexers too.
20323 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20324 right MethodBuilder when applying attributes to the get and set accessors.
20326 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20328 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20330 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20332 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20334 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20336 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20337 changes that treat `yield' specially when present before `break'
20338 or `return' tokens.
20340 * cs-tokenizer.cs: yield is no longer a keyword.
20342 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20344 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20345 setting for default constructors.
20346 For default constructors are almost every time set wrong Modifier. The
20347 generated IL code has been alright. But inside mcs this values was
20348 wrong and this was reason why several of my CLS Compliance tests
20351 2004-01-22 Martin Baulig <martin@ximian.com>
20353 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20354 not a QualifiedIdentifier. This is what `type_name_expression'
20355 was previously doing.
20356 (type_name_expression): Removed; the code is now in
20357 `namespace_or_type_name'.
20358 (qualified_identifier): Removed, use `namespace_or_type_name'
20360 (QualifiedIdentifier): Removed this class.
20362 2004-01-22 Martin Baulig <martin@ximian.com>
20364 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20365 not a string as alias name.
20367 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20369 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20370 #52730 bug, and instead compute correctly the need to use a
20371 temporary variable when requesting an address based on the
20372 static/instace modified of the field and the constructor.
20374 2004-01-21 Martin Baulig <martin@ximian.com>
20376 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20377 class and namespace before looking up aliases. Fixes #52517.
20379 2004-01-21 Martin Baulig <martin@ximian.com>
20381 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20382 assinged in a 'try'; fixes exception4.cs.
20384 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20385 * class.cs : Implemented parameter-less constructor for TypeContainer
20387 * decl.cs: Attributes are now stored here. New property OptAttributes
20389 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20391 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20393 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20395 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20396 (CSharpSignature): New method for indexer and property signature.
20398 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20400 * pending.cs (IsVirtualFilter): Faster implementation.
20402 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20404 * typemanager.cs: Avoid inclusion of same assembly more than once.
20406 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20408 * cs-parser.jay: Fixed problem where the last assembly attribute
20409 has been applied also to following declaration (class, struct, etc.)
20411 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20413 * class.cs: Added error CS0538, CS0539 reporting.
20414 Fixed crash on Microsoft runtime when field type is void.
20416 * cs-parser.jay: Added error CS0537 reporting.
20418 * pending.cs: Added error CS0535 reporting.
20419 Improved error report for errors CS0536, CS0534.
20421 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20423 Merge a few bits from the Anonymous Method MCS tree.
20425 * statement.cs (ToplevelBlock): New class for toplevel methods,
20426 will hold anonymous methods, lifted variables.
20428 * cs-parser.jay: Create toplevel blocks for delegates and for
20429 regular blocks of code.
20431 2004-01-20 Martin Baulig <martin@ximian.com>
20433 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20434 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20435 and `NeedExplicitReturn'; added `IsLastStatement'.
20436 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20437 have a `ReturnLabel' or we're not unreachable.
20439 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20440 child's reachability; don't just override ours with it. Fixes
20441 #58058 (lluis's example).
20442 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20443 InFinally(), InLoop(), InSwitch() and
20444 BreakCrossesTryCatchBoundary() methods.
20446 * statement.cs (Return): Do all error checking in Resolve().
20447 Unless we are the last statement in a top-level block, always
20448 create a return label and jump to it.
20449 (Break, Continue): Do all error checking in Resolve(); also make
20450 sure we aren't leaving a `finally'.
20451 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20452 statement in a top-level block.
20453 (Block.Flags): Added `IsDestructor'.
20454 (Block.IsDestructor): New public property.
20456 2004-01-20 Martin Baulig <martin@ximian.com>
20458 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20460 2004-01-20 Martin Baulig <martin@ximian.com>
20462 * statement.cs (Statement.ResolveUnreachable): New public method.
20463 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20464 (Block.Resolve): Resolve unreachable statements.
20466 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20468 * expression.cs: We need to fix the case where we do
20469 not have a temp variable here.
20471 * assign.cs: Only expression compound assignments need
20472 temporary variables.
20474 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20476 * flowanalysis.cs: Reduce memory allocation in a few ways:
20477 - A block with no variables should not allocate a bit
20479 - A method with no out parameters does not need any tracking
20480 for assignment of the parameters, so we need not allocate
20483 public readonly Type[] VariableTypes;
20484 public readonly string[] VariableNames;
20485 Are redundant. The data is already stored in the variable
20486 map, so we need not allocate another array for it.
20487 - We need to add alot of checks for if (params | locals) == null
20488 due to the first two changes.
20490 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20492 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20493 implement IMemoryLocation, we store a copy on a local variable and
20494 take the address of it. Patch from Benjamin Jemlich
20496 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20497 to use a special "type_name_expression" rule which reduces the
20498 number of "QualifiedIdentifier" classes created, and instead
20499 directly creates MemberAccess expressions.
20501 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20503 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20504 that fixes #52853. Null literal assignment to ValueType
20506 * class.cs (MethodData.Emit): Instead of checking the name of the
20507 method to determine if its a destructor, create a new derived
20508 class from Method called Destructor, and test for that.
20510 * cs-parser.jay: Create a Destructor object instead of a Method.
20512 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20516 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20518 * expression.cs (Binary.ResolveOperator): Perform an implicit
20519 conversion from MethodGroups to their delegate types on the
20520 Addition operation.
20522 * delegate.cs: Introduce a new class DelegateCreation that is the
20523 base class for `NewDelegate' and `ImplicitDelegateCreation',
20524 factor some code in here.
20526 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20527 conversion from MethodGroups to compatible delegate types.
20529 * ecore.cs (Expression.Resolve): Do not flag error 654
20530 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20531 we allow conversions from MethodGroups to delegate types now.
20533 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20534 assignments in v2 either.
20536 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20538 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20539 static read-only fields in ctors.
20541 Applied patch from Benjamin Jemlich
20543 * expression.cs (UnaryMutator): Avoid leaking local variables.
20545 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20547 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20548 here to return true, as they can be used like this:
20550 (XXX) int.MEMBER ()
20552 Fixed 49836 and all the other dups
20554 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20556 * driver.cs: Implement /win32res and /win32icon.
20558 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20560 * cs-parser.jay: Add a rule to improve error handling for the
20561 common mistake of placing modifiers after the type.
20563 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20565 * cs-parser.jay (interface_event_declaration): Catch
20566 initialization of events on interfaces, and report cs0068
20568 * cs-parser.jay (interface_event_declaration): Catch
20569 initialization of events.
20571 * ecore.cs: Better report missing constructors.
20573 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20574 the error reporting done in the wrong place. Fix.
20576 * expression.cs (Binary.ResolveOperator): Catch the
20577 operator + (E x, E y) error earlier, and later allow for implicit
20578 conversions in operator +/- (E e, U x) from U to the underlying
20581 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20582 52596, if the container class is abstract, the default constructor
20583 is protected otherwise its public (before, we were always public).
20585 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20588 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20589 Jemlich that fixes bug #52597, MCS was generating invalid code for
20590 idisposable structs. Thanks to Ben for following up with this
20593 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20595 * driver.cs: Allow assemblies without code to be generated, fixes
20598 2004-01-07 Nick Drochak <ndrochak@gol.com>
20600 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20602 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20604 * cs-parser.jay: Add rules to improve error reporting if fields or
20605 methods are declared at the namespace level (error 116)
20607 * Add rules to catch event add/remove
20609 2004-01-04 David Sheldon <dave-mono@earth.li>
20611 * expression.cs: Added matching ")" to error message for
20614 2004-01-03 Todd Berman <tberman@gentoo.org>
20616 * ecore.cs, attribute.cs:
20617 Applying fix from #52429.
20619 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20621 * ecore.cs, expression.cs, statement.cs:
20622 Total rewrite of how we handle branching. We
20623 now handle complex boolean expressions with fewer
20624 jumps. As well if (x == 0) no longer emits a ceq.
20626 if (x is Foo) is much faster now, because we generate
20629 Overall, we get a pretty big improvement on our benchmark
20630 tests. The code we generate is smaller and more readable.
20632 I did a full two-stage bootstrap. The patch was reviewed
20633 by Martin and Miguel.
20635 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20637 * cs-parser.jay: Make primary_expression not take a QI.
20638 we dont need this because the member_access rule covers
20639 us here. So we replace the rule with just IDENTIFIER.
20641 This has two good effects. First, we remove a s/r conflict.
20642 Second, we allocate many fewer QualifiedIdentifier objects.
20644 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20646 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20647 set the correct information via SRE. This prevents
20648 hanging on the MS runtime. Fixes #29374.
20650 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20652 * convert.cs: correctly handle conversions to value types
20653 from Enum and ValueType as unboxing conversions.
20655 Fixes bug #52569. Patch by Benjamin Jemlich.
20657 2004-01-02 Ravi Pratap <ravi@ximian.com>
20659 * expression.cs (BetterConversion): Prefer int -> uint
20660 over int -> ulong (csc's behaviour). This fixed bug #52046.
20662 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20664 * decl.cs (MemberCache.FindMembers): now returns a
20667 * typemanager.cs: In general, go with with ^^.
20668 (CopyNewMethods): take an IList.
20669 (RealMemberLookup): Only allocate an arraylist
20670 if we copy from two sets of methods.
20672 This change basically does two things:
20673 1) Fewer array lists allocated due to CopyNewMethods.
20674 2) the explicit cast in MemberList costed ALOT.
20676 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20678 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20679 a hashtable to avoid needless string allocations when an identifier is
20680 used more than once (the common case).
20682 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20684 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20685 is broken, it will not return anything. So, we
20686 have to use the information we have in mcs to
20689 * typemanager.cs: Add a cache for GetInterfaces,
20690 since this will now be used more often (due to ^^)
20692 (GetExplicitInterfaces) New method that gets the
20693 declared, not effective, interfaces on a type
20694 builder (eg, if you have interface IFoo, interface
20695 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20698 This patch makes MCS able to bootstrap itself on
20701 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20703 * expression.cs: Remove the Nop's that Miguel put
20706 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20708 * report.cs, codegen.cs: Give the real stack trace to
20709 the error when an exception is thrown.
20711 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20713 * decl.cs: only allocate hashtables for ifaces if
20716 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20718 * expression.cs: fix the error from cs0121-2.cs
20719 (a parent interface has two child interfaces that
20720 have a function with the same name and 0 params
20721 and the function is called through the parent).
20723 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20725 * class.cs, rootcontext.cs, typmanager.cs: do not
20728 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20730 * codegen.cs: remove stack for the ec flow branching.
20731 It is already a linked list, so no need.
20733 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20735 * Makefile: Allow custom profiler here.
20737 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20739 * typemanager.cs (LookupType):
20740 - Use a static char [], because split takes
20741 a param array for args, so it was allocating
20743 - Do not store true in a hashtable, it boxes.
20745 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20747 * flowanalysis.cs: bytify common enums.
20749 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20751 * modifiers.cs: Add a new set of flags for the
20752 flags allowed on explicit interface impls.
20753 * cs-parser.jay: catch the use of modifiers in
20754 interfaces correctly.
20755 * class.cs: catch private void IFoo.Blah ().
20757 All related to bug #50572.
20759 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20761 * decl.cs: Rewrite the consistant accessability checking.
20762 Accessability is not linear, it must be implemented in
20763 a tableish way. Fixes #49704.
20765 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20767 * expression.cs: Handle negation in a checked context.
20768 We must use subtraction from zero. Fixes #38674.
20770 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20772 * class.cs: Ignore static void main in DLLs.
20773 * rootcontext.cs: Handle the target type here,
20774 since we are have to access it from class.cs
20775 * driver.cs: account for the above.
20777 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20779 * report.cs: Give line numbers and files if available.
20781 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20783 * driver.cs: Implement /addmodule.
20785 * typemanager.cs: Change 'modules' field so it now contains Modules not
20788 2003-12-20 Martin Baulig <martin@ximian.com>
20790 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20791 (FieldBase.IsAssigned): Removed this field.
20792 (FieldBase.SetAssigned): New public method.
20793 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20795 2003-12-20 Martin Baulig <martin@ximian.com>
20797 * expression.cs (LocalVariableReference.DoResolve): Don't set
20798 `vi.Used' if we're called from DoResolveLValue().
20800 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20801 returns the usage vector it just merged into the current one -
20802 pass this one to UsageWarning().
20803 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20804 of the `EmitContext', don't call this recursively on our children.
20806 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20808 * driver.cs: Implement /target:module.
20810 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20812 * support.cs (CharArrayHashtable): New helper class.
20814 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20815 char arrays, not strings, so we can avoid creating a string in
20816 consume_identifier if the identifier is a keyword.
20818 2003-12-16 Martin Baulig <martin@ximian.com>
20820 * statement.cs (LocalInfo.Assigned): Removed this property.
20821 (LocalInfo.Flags): Removed `Assigned'.
20822 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20823 and uses flow analysis.
20824 (Block.UsageWarning): Made this method private.
20825 (Block.Resolve): Call UsageWarning() if appropriate.
20827 * expression.cs (LocalVariableReference.DoResolve): Always set
20828 LocalInfo.Used here.
20830 2003-12-13 Martin Baulig <martin@ximian.com>
20832 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20833 any value here; we're now using flow analysis to figure out
20834 whether a statement/block returns a value.
20836 2003-12-13 Martin Baulig <martin@ximian.com>
20838 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20840 (FlowBranching.MergeFinally): Don't call
20841 `branching.CheckOutParameters()' here, this is called in
20843 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20844 when adding the `finally' vector.
20846 2003-12-13 Martin Baulig <martin@ximian.com>
20849 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20850 actually work and also fix #48962.
20852 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20854 * decl.cs: Do not check System.Object for nested types,
20855 since we know it does not have any. Big bang for buck:
20858 Run 1: 8.35 seconds
20859 Run 2: 8.32 seconds
20860 corlib: 17.99 seconds
20862 Run 1: 8.17 seconds
20863 Run 2: 8.17 seconds
20864 corlib: 17.39 seconds
20866 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20868 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20869 time we are returning 0 members, so we save alot here.
20871 2003-12-11 Martin Baulig <martin@ximian.com>
20873 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20874 `MergeChild()', also just take the `FlowBranching' as argument;
20875 call Merge() on it and return the result.
20876 (FlowBranching.Merge): We don't need to do anything if we just
20879 2003-12-11 Martin Baulig <martin@ximian.com>
20881 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20882 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20883 Maurer for this idea.
20885 2003-12-11 Martin Baulig <martin@ximian.com>
20887 * flowanalysis.cs (MergeResult): This class is now gone; we now
20888 use the `UsageVector' for this. The reason for this is that if a
20889 branching just has one sibling, we don't need to "merge" them at
20890 all - that's the next step to do.
20891 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20894 2003-12-11 Martin Baulig <martin@ximian.com>
20896 Reworked flow analyis and made it more precise and bug-free. The
20897 most important change is that we're now using a special `Reachability'
20898 class instead of having "magic" meanings of `FlowReturns'. I'll
20899 do some more cleanups and optimizations and also add some more
20900 documentation this week.
20902 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20903 largely reworked this class.
20904 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20905 the new `Reachability' class instead of having "magic" values here.
20906 (FlowBranching): We're now using an instance of `Reachability'
20907 instead of having separate `Returns', `Breaks' etc. fields.
20909 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20910 based on flow analysis; ignore the return value of block.Emit ().
20912 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20914 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20915 if they are private.
20917 2003-12-09 Martin Baulig <martin@ximian.com>
20919 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20920 call them directly on the UsageVector.
20922 2003-12-09 Martin Baulig <martin@ximian.com>
20924 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20925 Changed return type from `FlowReturns' to `Reachability'.
20927 2003-12-09 Martin Baulig <martin@ximian.com>
20929 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20930 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20931 `Reachable' fields with a single `Reachability' one.
20933 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20935 * class.cs (FindMembers): Remove foreach's.
20940 Run 1: 8.74 seconds
20941 Run 2: 8.71 seconds
20944 Run 1: 8.64 seconds
20945 Run 2: 8.58 seconds
20948 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20953 This patch does a few things:
20954 1. EmptyStatement is now a singleton, so it is never reallocated.
20955 2. All blah is EmptyStatement constructs have been changed to
20956 blah == EmptyStatement.Value, which is much faster and valid
20957 now that EmptyStatement is a singleton.
20958 3. When resolving a block, rather than allocating a new array for
20959 the non-empty statements, empty statements are replaced with
20960 EmptyStatement.Value
20961 4. Some recursive functions have been made non-recursive.
20962 Mainly the performance impact is from (3), however (1) and (2) are needed for
20963 this to work. (4) does not make a big difference in normal situations, however
20964 it makes the profile look saner.
20969 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20970 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20971 Total memory allocated: 56397 KB
20974 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20975 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20976 Total memory allocated: 55666 KB
20978 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20980 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20981 than the hashtable in a hashtable version
20983 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20984 we always end up concating a string. This results in a huge perf
20985 loss, because many strings have to be tracked by the GC. In this
20986 patch, we first use a hashtable that works with two keys, so that
20987 the strings do not need to be concat'ed.
20991 Run 1: 8.74 seconds
20992 Run 2: 8.71 seconds
20995 Run 1: 8.65 seconds
20996 Run 2: 8.56 seconds
20998 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21000 * Makefile: Add a new target `do-time' that does a quick and simple
21001 profile, leaving easy to parse output.
21003 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
21005 * codegen.cs (Init): Create the dynamic assembly with
21006 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
21008 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
21010 * support.cs: Make the PtrHashtable use only one
21011 instance of its comparer.
21013 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
21015 * typemanager.cs: Fix lookup of GetNamespaces.
21017 2003-11-29 Miguel de Icaza <miguel@ximian.com>
21019 * expression.cs: Removed redundant line.
21021 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
21022 ArrayLists, use for loops with bounds.
21024 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
21027 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
21028 arraylists, use for loop with bounds.
21030 The above three changes give us a 0.071 second performance
21031 improvement out of 3.294 seconds down to 3.223. On my machine
21032 the above changes reduced the memory usage by 1,387 KB during
21033 compiler bootstrap.
21035 * cs-parser.jay (QualifiedIdentifier): New class used to represent
21036 QualifiedIdentifiers. Before we created a new string through
21037 concatenation, and mostly later on, the result would be
21038 manipulated by DecomposeQI through string manipulation.
21040 This reduced the compiler memory usage for bootstrapping from
21041 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
21042 compile times in 0.05 seconds.
21044 2003-11-28 Dick Porter <dick@ximian.com>
21046 * support.cs: Do string compares with the Invariant culture.
21054 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
21055 the comparison is done with the Invariant culture.
21057 2003-11-27 Miguel de Icaza <miguel@ximian.com>
21059 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
21060 GetEnumerator method.
21062 (ProbeCollectionType): Iterate starting at the most specific type
21063 upwards looking for a GetEnumerator
21065 * expression.cs: Shift count can be up to 31 for int/uint and 63
21068 2003-11-26 Miguel de Icaza <miguel@ximian.com>
21070 * statement.cs (Block.LookupLabel): Also look for the label on the
21071 children blocks. Use a hash table to keep track of visited
21074 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
21075 we actually did transform the other operand, otherwise fall back
21076 to the common codepath that casts to long.
21078 * cs-tokenizer.cs: Use the same code pattern as the int case.
21079 Maybe I should do the parsing myself, and avoid depending on the
21080 Parse routines to get this done.
21082 2003-11-25 Miguel de Icaza <miguel@ximian.com>
21084 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21085 which fixes bug 51347. This time test it.
21087 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
21088 attributes for example can not tell the difference between these.
21089 The difference was only a syntax feature of the language.
21091 * attribute.cs: Apply attributes to delegates.
21093 * delegate.cs: Call the apply attributes method.
21095 2003-11-24 Miguel de Icaza <miguel@ximian.com>
21097 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
21098 comparing 0 vs Byte.MinValue, not the value
21100 (ImplicitConversionRequired): When reporting a conversion error,
21101 use error 31 to print out the constant error instead of the
21104 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21105 which fixes bug 51347.
21107 2003-11-22 Miguel de Icaza <miguel@ximian.com>
21109 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
21110 which fixes the -warnaserror command line option.
21112 2003-11-21 Miguel de Icaza <miguel@ximian.com>
21114 * cfold.cs (DoNumericPromotions): During constant folding of
21115 additions on UIntConstant, special case intconstants with
21116 IntConstants like we do on the expression binary operator.
21118 2003-11-12 Miguel de Icaza <miguel@ximian.com>
21120 * convert.cs (ImplicitReferenceConversion): We were missing a case
21121 (System.Enum are not value types or class types, so we need to
21122 classify them separatedly).
21124 * driver.cs: We do not support error 2007.
21126 2003-11-12 Jackson Harper <jackson@ximian.com>
21128 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
21129 system directory. Also use the full file name so users can
21130 libraries names mscorlib-o-tron.dll in a non system dir.
21132 2003-11-10 Martin Baulig <martin@ximian.com>
21134 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
21135 (TypeManager.InitCoreTypes): Initialize them here, but instead of
21136 calling `ResolveType()' on them, directly assign their `Type'.
21138 2003-11-08 Martin Baulig <martin@ximian.com>
21140 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
21141 return value and the `out parent' parameter.
21142 (TypeContainer.DefineType): Moved the CS0644 check into
21143 GetClassBases(). Don't pass the interface types to the
21144 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
21145 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
21147 * ecore.cs (TypeExpr.IsAttribute): New property.
21148 (TypeExpr.GetInterfaces): New method.
21150 * interface.cs (Interface.GetInterfaceTypeByName): Return a
21151 TypeExpr instead of a Type.
21152 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
21153 (Interface.DefineType): Don't pass the interface types to the
21154 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
21155 them later and then call `TypeBulider.AddInterfaceImplementation()'.
21157 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
21158 instead of a `Type[]'.
21159 (TypeManager.RegisterBuilder): Likewise.
21160 (TypeManager.AddUserInterface): Likewise.
21161 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
21162 `Type[]' and also return a `TypeExpr[]'.
21163 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
21165 2003-11-08 Martin Baulig <martin@ximian.com>
21167 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
21170 2003-11-08 Martin Baulig <martin@ximian.com>
21172 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
21173 TypeManager.ResolveExpressionTypes().
21175 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
21176 instead of an Expression.
21177 (TypeExpr): This is now an abstract base class for `TypeExpression'.
21178 (TypeExpression): New public class; formerly known as `TypeExpr'.
21180 * expression.cs (ComposedCast): Derive from TypeExpr.
21182 * typemanager.cs (TypeManager.system_*_expr): These are now
21183 TypExpr's instead of Expression's.
21184 (TypeManager.ResolveExpressionTypes): New public static function;
21185 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
21188 2003-11-06 Miguel de Icaza <miguel@ximian.com>
21190 * expression.cs (New.DoResolve): Do not dereference value that
21191 might be a null return.
21193 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
21194 sure that the constant value has the right type. Fixes an
21195 unreported bug, similar to 50425.
21197 * const.cs (Const.LookupConstantValue): Call
21198 ImplicitStandardConversionExists before doing a conversion to
21199 avoid havng the TypeManager.ChangeType do conversions.
21201 Reduced the number of casts used
21203 (Const.ChangeType): New routine to enable reuse of the constant
21204 type changing code from statement.
21206 * typemanager.cs (ChangeType): Move common initialization to
21207 static global variables.
21211 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
21212 every value type to go through, even if it was void. Fix that.
21214 * cs-tokenizer.cs: Use is_identifier_start_character on the start
21215 character of the define, and the is_identifier_part_character for
21216 the rest of the string.
21218 2003-11-05 Miguel de Icaza <miguel@ximian.com>
21220 * expression.cs (UnaryMutator.EmitCode): When I updated
21221 LocalVariableReference.DoResolve, I overdid it, and dropped an
21222 optimization done on local variable references.
21224 2003-11-04 Miguel de Icaza <miguel@ximian.com>
21226 * ecore.cs: Convert the return from Ldlen into an int.
21228 2003-10-20 Miguel de Icaza <miguel@ximian.com>
21230 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
21231 the accessibility, this is a special case for toplevel non-public
21232 classes (internal for instance).
21234 2003-10-20 Nick Drochak <ndrochak@gol.com>
21236 * ecore.cs: Fix typo and build. Needed another right paren.
21238 2003-10-19 Miguel de Icaza <miguel@ximian.com>
21240 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
21241 `internal' case regular and protected, but not allowing protected
21242 to be evaluated later. Bug 49840
21244 2003-10-15 Miguel de Icaza <miguel@ximian.com>
21246 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
21247 to kb.Nlast, and not the kb.nFirst to isolate the switch
21250 Extract the underlying type, so enumerations of long/ulong are
21251 treated like long/ulong.
21253 2003-10-14 Miguel de Icaza <miguel@ximian.com>
21255 * expression.cs (New): Overload the meaning of RequestedType to
21256 track the possible creation of the NewDelegate type, since
21257 DoResolve is invoked more than once for new constructors on field
21260 See bugs: #48800 and #37014
21262 * cs-parser.jay (declare_local_constants): Take an arraylist
21263 instead of a single constant.
21265 (local_constant_declaration): It should take a
21266 constant_declarators, not a constant_declarator. Fixes 49487
21268 * convert.cs: Fix error report.
21270 2003-10-13 Jackson Harper <jackson@ximian.com>
21272 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21275 2003-10-09 Martin Baulig <martin@ximian.com>
21277 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21279 (MethodCore.DoDefineParameters): Removed the TypeContainer
21280 argument; use the DeclSpace which was passed to the .ctor instead.
21281 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21282 TypeContainer; we only need a DeclSpace here.
21284 2003-10-09 Martin Baulig <martin@ximian.com>
21286 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21288 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21289 EmitContext's .ctor.
21291 2003-10-09 Martin Baulig <martin@ximian.com>
21293 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21294 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21295 AsAccessible(), moved them as well.
21297 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21299 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21301 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21303 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21305 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21306 generation for >=, as spotted by Paolo, bug 48679.
21307 Patch from David Waite.
21309 * cs-tokenizer.cs: Add handling for #pragma.
21311 * cs-parser.jay: Allow for both yield and yield return in the
21312 syntax. The anti-cobolization of C# fight will go on!
21314 * class.cs (TypeBuilder.DefineType): Catch error condition here
21315 (Parent.DefineType erroring out and returning null).
21317 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21318 coping with enumerations variables, we were mistakenly processing
21319 them as a regular value type instead of built-in types. Fixes the
21322 * typemanager.cs (IsBuiltinOrEnum): New method.
21324 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21326 * cs-parser.jay: Upgrade: yield now needs the return clause.
21328 2003-09-19 Martin Baulig <martin@ximian.com>
21330 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21331 `MemberCache parent' argument. Normally, an interface doesn't
21332 have a parent type except System.Object, but we use this in gmcs
21333 for generic type parameters.
21335 2003-09-18 Martin Baulig <martin@ximian.com>
21337 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21338 on `type.IsInterface'; don't check whether the type has a parent
21339 to determine whether it's an interface.
21341 2003-09-15 Martin Baulig <martin@ximian.com>
21343 * class.cs (TypeContainer.DefineType): Added an error flag to
21344 avoid reporting duplicate CS0146's ("class definition is
21347 * driver.cs (Driver.MainDriver): Abort if
21348 RootContext.ResolveTree() reported any errors.
21350 2003-09-07 Martin Baulig <martin@ximian.com>
21352 * report.cs (Error, Warning): Added overloaded versions which take
21353 a `params object[] args' and call String.Format().
21355 2003-09-07 Martin Baulig <martin@ximian.com>
21357 * decl.cs (DeclSpace..ctor): Don't call
21358 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21359 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21360 (DeclSpace.RecordDecl): New method.
21362 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21364 2003-09-02 Ravi Pratap <ravi@ximian.com>
21366 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21367 value attributes to be applied to ParameterBuilders.
21369 * class.cs (MethodCore.LabelParameters): Make static and more
21370 generic so that it can be used from other places - like interface
21371 methods, for instance.
21373 * interface.cs (Interface.Emit): Call LabelParameters before
21374 emitting attributes on the InterfaceMethod.
21376 2003-08-26 Martin Baulig <martin@ximian.com>
21378 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21379 resolving aliases; fixes #47927.
21381 2003-08-26 Martin Baulig <martin@ximian.com>
21383 * statement.cs (Using.DoResolve): This is internally emitting a
21384 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21385 do not always return. Fixes #47681.
21387 2003-08-26 Martin Baulig <martin@ximian.com>
21389 * decl.cs (MemberCore): Moved WarningNotHiding(),
21390 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21392 (AdditionResult): Make this nested in DeclSpace.
21393 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21394 argument; call NamespaceEntry.Define() unless we're nested in a
21397 * namespace.cs (Namespace.DefineName): New public function. This
21398 is called from DeclSpace's .ctor to add
21399 (Namespace.Lookup): Include DeclSpaces in the lookup.
21401 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21403 * const.cs (Const): Derive from MemberBase, not MemberCore.
21405 2003-08-25 Martin Baulig <martin@ximian.com>
21407 * convert.cs (Convert.ExplicitReferenceConversion): When
21408 converting from an interface type to a class, unbox if the target
21409 type is a struct type. Fixes #47822.
21411 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21413 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21416 2003-08-22 Martin Baulig <martin@ximian.com>
21418 * class.cs (TypeManager.DefineType): When defining a nested type,
21419 call DefineType() on our parent; fixes #47801.
21421 2003-08-22 Martin Baulig <martin@ximian.com>
21423 * class.cs (MethodData.Define): While checking if a method is an
21424 interface implementation, improve the test a bit more to fix #47654.
21426 2003-08-22 Martin Baulig <martin@ximian.com>
21428 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21429 correctly; fixes #47722.
21431 2003-08-22 Martin Baulig <martin@ximian.com>
21433 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21434 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21436 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21438 2003-08-22 Martin Baulig <martin@ximian.com>
21440 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21441 can only be assigned in static constructors. Fixes #47161.
21443 2003-08-22 Martin Baulig <martin@ximian.com>
21445 Rewrote and improved the flow analysis code.
21447 * flowbranching.cs (FlowBranching): Make this class abstract.
21448 (FlowBranching.CreateBranching): New static function to create a
21449 new flow branching.
21450 (FlowBranchingBlock, FlowBranchingException): New classes.
21451 (FlowBranching.UsageVector.Type): New public readonly field.
21452 (FlowBranching.UsageVector.Breaks): Removed the setter.
21453 (FlowBranching.UsageVector.Returns): Removed the setter.
21454 (FlowBranching.UsageVector): Added Break(), Return(),
21455 NeverReachable() and Throw() methods to modify the reachability.
21456 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21457 done by FlowBranching.Merge().
21458 (FlowBranching.UsageVector.MergeChild): New method; merges the
21459 merge result into the current vector.
21460 (FlowBranching.Merge): New abstract method to merge a branching.
21462 2003-08-12 Martin Baulig <martin@ximian.com>
21464 * expression.cs (Indirection.CacheTemporaries): Create the
21465 LocalTemporary with the pointer type, not its element type.
21467 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21469 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21470 token was a keyword or not.
21472 Add `error' options where an IDENTIFIER was expected; Provide
21473 CheckToken and CheckIdentifierToken convenience error reporting
21476 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21478 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21479 NameSpaceEntry NameSpaceEntry.
21481 (LookupInterfaceOrClass): Avoid creating a full qualified name
21482 from namespace and name: avoid doing lookups when we know the
21483 namespace is non-existant. Use new Tree.LookupByNamespace which
21484 looks up DeclSpaces based on their namespace, name pair.
21486 * driver.cs: Provide a new `parser verbose' to display the
21487 exception thrown during parsing. This is turned off by default
21488 now, so the output of a failure from mcs is more graceful.
21490 * namespace.cs: Track all the namespaces defined in a hashtable
21493 (IsNamespace): New method
21495 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21497 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21498 we know that we need to concatenate (full typename can never be
21503 * statement.cs: Use a bitfield; Do not initialize to null things
21504 which are done by the constructor by default.
21506 * cs-parser.jay: bug fix, parameter was 4, not 3.
21508 * expression.cs: Just use the property;
21510 * statement.cs: No need for GetVariableInfo method.
21512 2003-08-08 Martin Baulig <martin@ximian.com>
21514 * flowanalysis.cs (FlowReturns): This is now nested in the
21515 `FlowBranching' class.
21516 (MyBitVector): Moved this here from statement.cs.
21517 (FlowBranching.SiblingType): New enum type.
21518 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21520 2003-08-07 Martin Baulig <martin@ximian.com>
21522 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21523 `FlowBranching' class and called `BranchingType'.
21525 2003-08-07 Martin Baulig <martin@ximian.com>
21527 * flowanalysis.cs: Moved all the control flow analysis code into
21530 2003-08-07 Martin Baulig <martin@ximian.com>
21532 * assign.cs (Assign.DoResolve): `target' must either be an
21533 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21536 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21538 * expression.cs (BinaryMethod): This kind of expression is created by the
21539 Binary class if it determines that the operator has to be handled
21542 (BinaryDelegate): This kind of expression is created if we are
21543 dealing with a + or - operator on delegates.
21545 (Binary): remove method, argumetns, and DelegateOperator: when
21546 dealing with methods,
21548 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21550 * statement.cs (Block): use bitfields for the three extra booleans
21551 we had in use. Remove unused topblock parameter.
21553 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21555 * assign.cs: Drop extra unneeded tests.
21557 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21559 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21561 * statement.cs (Foreach): Use VariableStorage instead of
21564 * codegen.cs (VariableStorage): New class used by clients that
21565 require a variable stored: locals or fields for variables that
21566 need to live across yield.
21568 Maybe provide a convenience api for EmitThis+EmitLoad?
21570 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21573 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21575 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21576 RemapParameterLValue): New methods that are used to turn a
21577 precomputed FieldInfo into an expression like this:
21581 The idea is to use this instead of making LocalVariableReference
21582 have more than one meaning.
21584 * cs-parser.jay: Add error production to BASE.
21586 * ecore.cs: Deal with TypeManager.GetField returning null, which
21587 is now a valid return value.
21589 (FieldExprNoAddress): New expression for Fields whose address can
21592 * expression.cs (LocalVariableReference): During the resolve
21593 phases, create new expressions if we are in a remapping context.
21594 Remove code that dealt with remapping here.
21596 (ParameterReference): same.
21598 (ProxyInstance): New expression, like the `This' expression, but
21599 it is born fully resolved. We know what we are doing, so remove
21600 the errors that are targeted to user-provided uses of `this'.
21602 * statement.cs (Foreach): our variable is now stored as an
21603 Expression; During resolution, follow the protocol, dont just
21604 assume it will return this.
21606 2003-08-06 Martin Baulig <martin@ximian.com>
21608 * support.cs (SeekableStreamReader.cs): New public class.
21610 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21611 SeekableStreamReader instead of the normal StreamReader.
21613 2003-08-04 Martin Baulig <martin@ximian.com>
21615 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21616 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21617 deambiguate casts and delegate invocations.
21618 (parenthesized_expression): Use the new tokens to ensure this is
21619 not a cast of method invocation.
21621 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21622 when reading a `)' and Deambiguate_CloseParens () was previously
21625 * expression.cs (ParenthesizedExpression): New class. This is
21626 just used for the CS0075 test.
21627 (Binary.DoResolve): Check for CS0075.
21629 2003-07-29 Ravi Pratap <ravi@ximian.com>
21631 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21632 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21633 reference comparison.
21635 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21636 examine the ReturnType for equality - this is necessary in the
21637 cases of implicit and explicit operators whose signature also
21638 includes the return type.
21640 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21642 * namespace.cs: Cache the result of the namespace computation,
21643 instead of computing it every time.
21645 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21647 * decl.cs: Use a global arraylist that we reuse over invocations
21648 to avoid excesive memory consumption. Reduces memory usage on an
21649 mcs compile by one meg (45 average).
21651 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21652 private, work around that.
21654 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21656 * literal.cs (IntLiteral): Define Zero and One static literals.
21658 * cs-parser.jay (integer_literal): use static literals to reduce
21659 memory usage for the most used literals (0, 1 and -1). 211kb
21660 reduced in memory usage.
21662 Replace all calls to `new ArrayList' with `new
21663 ArrayList(4)' which is a good average number for most allocations,
21664 and also requires only 16 bytes of memory for its buffer by
21667 This reduced MCS memory usage in seven megabytes for the RSS after
21670 2003-07-28 Ravi Pratap <ravi@ximian.com>
21672 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21673 handle params methods the correct way by forming only one
21674 applicable set with params and normal methods in them. Earlier we
21675 were looking at params methods only if we found no normal methods
21676 which was not the correct thing to do.
21678 (Invocation.BetterFunction): Take separate arguments indicating
21679 when candidate and the best method are params methods in their
21682 This fixes bugs #43367 and #46199.
21684 * attribute.cs: Documentation updates.
21686 (CheckAttribute): Rename to CheckAttributeTarget.
21687 (GetValidPlaces): Rename to GetValidTargets.
21689 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21690 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21694 2003-07-28 Martin Baulig <martin@ximian.com>
21696 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21697 name when looking up the base class of a nested class. Fixes #46977.
21699 2003-07-26 Martin Baulig <martin@ximian.com>
21701 * expression.cs (Indexers.Indexer): New nested struct; contains
21702 getter, setter and the indexer's type.
21703 (Indexers.Properties): This is now an ArrayList of
21704 Indexers.Indexer's.
21705 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21706 indexer doesn't have any getters.
21708 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21709 for embedded property and indexer assignments.
21711 2003-07-26 Martin Baulig <martin@ximian.com>
21713 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21714 preprocessor directive is not the first non-whitespace character
21717 2003-07-26 Martin Baulig <martin@ximian.com>
21719 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21720 namespace parsing, follow the spec more closely.
21722 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21723 NamespaceEntry.Lookup().
21725 2003-07-25 Martin Baulig <martin@ximian.com>
21727 * MethodCore.cs (OverridesSomething): New public field; it's set
21728 from TypeContainer.DefineMembers if this method overrides
21729 something (which doesn't need to be a method). Fix #39462.
21731 2003-07-25 Ravi Pratap <ravi@ximian.com>
21733 * typemanager.cs (GetMembers): Ensure that the list of members is
21734 reversed. This keeps things in sync.
21736 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21737 find an AttributeUsage attribute.
21739 * expression.cs (Invocation.OverloadResolve): Perform the check
21740 which disallows Invoke to be directly called on a Delegate.
21742 (Error_InvokeOnDelegate): Report error cs1533.
21744 2003-07-25 Martin Baulig <martin@ximian.com>
21746 * expression.cs (Indexers.GetIndexersForType): Only look in the
21747 interface hierarchy if the requested type is already an
21748 interface. Fixes #46788 while keeping #46502 fixed.
21750 2003-07-25 Martin Baulig <martin@ximian.com>
21752 * class.cs (TypeContainer.DefineMembers): Check whether all
21753 readonly fields have been assigned and report warning CS0649 if
21756 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21759 2003-07-24 Ravi Pratap <ravi@ximian.com>
21761 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21762 returned from GetMethods to make things consistent with the
21763 assumptions MCS makes about ordering of methods.
21765 This should comprehensively fix bug #45127 and it does :-)
21767 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21768 ordering is actually reverse.
21770 * Clean up some debug messages I left lying around.
21772 * interface.cs (Populate*): Get rid of code which emits attributes
21773 since the stage in which we emit attributes is the 'Emit' stage,
21774 not the define stage.
21776 (Emit): Move attribute emission for interface members here.
21778 2003-07-22 Ravi Pratap <ravi@ximian.com>
21780 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21781 closely: we eliminate methods in base types when we have an
21782 applicable method in a top-level type.
21784 Please see section 14.5.5.1 for an exact description of what goes
21787 This fixes bug #45127 and a host of other related to corlib compilation.
21789 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21790 array is the method corresponding to the top-level type (this is
21791 because of the changes made to icall.c) so we change this
21794 (MethodGroupExpr.Name): This too.
21796 * typemanager.cs (GetElementType): New method which does the right
21797 thing when compiling corlib.
21799 * everywhere: Make use of the above in the relevant places.
21801 2003-07-22 Martin Baulig <martin@ximian.com>
21803 * cs-parser.jay (invocation_expression): Moved
21804 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21805 `cast_expression', but create a InvocationOrCast which later
21806 resolves to either an Invocation or a Cast.
21808 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21809 method; call this before EmitStatement() to make sure that this
21810 expression can be used as a statement.
21812 * expression.cs (InvocationOrCast): New class; resolves to either
21813 an Invocation or a Cast.
21815 * statement.cs (StatementExpression): Call ResolveStatement() on
21816 the ExpressionStatement before emitting it.
21818 2003-07-21 Martin Baulig <martin@ximian.com>
21820 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21821 `ref' and `out' attributes match; fixes #46220.
21822 (MemberAccess.ResolveMemberAccess): You can't reference a type
21823 through an expression; fixes #33180.
21824 (Indexers.GetIndexersForType): Don't return the indexers from
21825 interfaces the class implements; fixes #46502.
21827 2003-07-21 Martin Baulig <martin@ximian.com>
21829 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21830 CS0661 checks; fixes bug #30442.
21832 2003-07-21 Martin Baulig <martin@ximian.com>
21834 * decl.cs (AdditionResult): Added `Error'.
21836 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21838 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21839 makes cs0031.cs actually work.
21841 2003-07-20 Martin Baulig <martin@ximian.com>
21843 * namespace.cs: Fixed that bug which caused a crash when compiling
21844 the debugger's GUI.
21846 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21848 * typemanager.cs (LookupTypeReflection): Never expose types which
21849 are NotPublic, NestedPrivate, NestedAssembly, or
21850 NestedFamANDAssem. We used to return these, and later do a check
21851 that would report a meaningful error, but the problem is that we
21852 would not get the real match, if there was a name override.
21854 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21856 * namespace.cs (Namespace, Name): Do not compute the namespace
21857 name dynamically, compute it in the constructor. This reduced
21858 memory usage by 1697 KB.
21860 * driver.cs: Use --pause to pause at the end.
21862 2003-07-17 Peter Williams <peter@newton.cx>
21864 * Makefile: Change the name of the test target so that it doesn't
21865 conflict with the recursive test target.
21867 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21869 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21870 AddressOf): Do not use EmitThis, that was wrong, use the actual
21873 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21875 * class.cs (MethodData.Define): While checking if a method is an
21876 interface implementation, improve the test: If we are not public
21877 (use new test here: use the computed MethodAttributes directly,
21878 instead of the parsed modifier flags) check if the `implementing'
21879 method comes from an interface or not.
21881 * pending.cs (VerifyPendingMethods): Slightly better error
21884 * makefile: add test target that does the mcs bootstrap.
21886 2003-07-16 Ravi Pratap <ravi@ximian.com>
21888 * interface.cs (Define): Do nothing here since there are no
21889 members to populate etc. Move the attribute emission out of here
21890 since this was just totally the wrong place to put it. Attribute
21891 application happens during the 'Emit' phase, not in the 'Define'
21894 (Emit): Add this method and move the attribute emission here
21896 * rootcontext.cs (EmitCode): Call the Emit method on interface
21899 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21901 * expression.cs (OverloadResolve): Report error only if Location
21902 is not 'Null' which means that there was a probe going on.
21904 2003-07-14 Martin Baulig <martin@ximian.com>
21906 * expression.cs (ConditionalLogicalOperator): New public class to
21907 implement user defined conditional logical operators.
21908 This is section 14.11.2 in the spec and bug #40505.
21910 2003-07-14 Martin Baulig <martin@ximian.com>
21912 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21914 2003-07-14 Martin Baulig <martin@ximian.com>
21916 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21918 * ecore.cs (IVariable.VerifyFixed): New interface method.
21920 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21921 operator, check whether the variable is actually fixed. Fixes bug
21922 #36055. Set a variable definitely assigned when taking its
21923 address as required by the spec.
21925 * statement.cs (LocalInfo.IsFixed): New field.
21926 (LocalInfo.MakePinned): Set `IsFixed' to true.
21928 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21930 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21931 for .ctors, ensure that we only ask for members declared in the
21932 attribute type (BindingFlags.DeclaredOnly).
21936 * expression.cs (Error_WrongNumArguments): Report error 1501
21937 correctly the way CSC does.
21939 2003-07-13 Martin Baulig <martin@ximian.com>
21941 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21942 lookup on the fully qualified name, to make things like "X.X" work
21943 where "X.X" is a fully qualified type name, but we also have a
21944 namespace "X" in the using list. Fixes #41975.
21946 2003-07-13 Martin Baulig <martin@ximian.com>
21948 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21949 function. If we're a CompoundAssign, we need to create an embedded
21950 CompoundAssign, not an embedded Assign.
21951 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21954 2003-07-13 Martin Baulig <martin@ximian.com>
21956 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21957 work to fix bug #46088.
21959 2003-07-13 Ravi Pratap <ravi@ximian.com>
21961 * class.cs (Operator.Emit): Do not emit attributes here - it is
21962 taken care of by the Method class that we delegate too. This takes
21963 care of bug #45876.
21965 2003-07-10 Martin Baulig <martin@ximian.com>
21967 * expression.cs (TypeOfVoid): New class.
21968 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21970 2003-07-10 Martin Baulig <martin@ximian.com>
21972 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21975 2003-07-10 Martin Baulig <martin@ximian.com>
21977 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21978 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21980 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21982 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21984 2003-07-10 Martin Baulig <martin@ximian.com>
21986 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21987 of decimal. Fixes #42850.
21989 NOTE: I also fixed the created byte blob, but this doesn't work on
21990 the MS runtime and csc never produces any byte blobs for decimal
21993 2003-07-10 Martin Baulig <martin@ximian.com>
21995 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21996 structs; fixes #32068.
21997 (Block.AddChildVariableNames): Fixed #44302.
21999 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22001 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
22003 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22005 * attribute.cs: And this test is onger needed.
22007 2003-07-08 Martin Baulig <martin@ximian.com>
22009 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
22010 inaccessible types. Fixes #36313.
22012 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
22014 * namespace.cs (NamespaceEntry): Create implicit entries for all
22015 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
22016 implicit entries for N1.N2 and N1.
22018 2003-07-08 Martin Baulig <martin@ximian.com>
22020 Rewrote the handling of namespaces to fix a lot of the issues
22021 wrt. `using' aliases etc.
22023 * namespace.cs (Namespace): Splitted this class into a
22024 per-assembly `Namespace' and a per-file `NamespaceEntry'.
22026 * typemanager.cs (TypeManager.IsNamespace): Removed.
22027 (TypeManager.ComputeNamespaces): Only compute namespaces from
22028 loaded assemblies here, not the namespaces from the assembly we're
22029 currently compiling.
22031 2003-07-08 Martin Baulig <martin@ximian.com>
22033 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
22035 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22037 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
22040 I thought about the memory savings here, but LookupTypeReflection
22041 is used under already very constrained scenarios. Compiling
22042 corlib or mcs only exposes one hit, so it would not really reduce
22043 any memory consumption.
22045 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22047 * typemanager.cs: fixes bug #45889 by only adding public types from
22048 other assemblies to the list of known types.
22050 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22052 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
22053 on the type we resolved.
22055 2003-07-05 Martin Baulig <martin@ximian.com>
22057 * pending.cs (PendingImplementation.ParentImplements): Don't
22058 create the proxy if the parent is abstract.
22060 * class.cs (TypeContainer.DefineIndexers): Process explicit
22061 interface implementations first. Fixes #37714.
22063 2003-07-04 Miguel de Icaza <miguel@ximian.com>
22065 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
22066 defined recursively; but since we modify the input parameters
22067 (left is set to `this' temporarily), we reset this value if the
22068 left_is_explicit is false, which gives the original semantics to
22071 * literal.cs (NullPointer): new class used to represent a null
22072 literal in a pointer context.
22074 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
22075 type is a pointer, use a NullPointer object instead of a
22076 NullLiteral. Closes 43687
22078 (ExplicitConversion): Convert pointer values using
22079 the conv opcode to the proper type.
22081 * ecore.cs (New): change ValueTypeVariable property into a method,
22082 that returns whether the valuetype is suitable for being used.
22084 * expression.cs (Binary.DoNumericPromotions): Only return if we
22085 the int constant was a valid uint, and we can return both left and
22086 right as uints. If not, we continue processing, to trigger the
22087 type conversion. This fixes 39018.
22089 * statement.cs (Block.EmitMeta): During constant resolution, set
22090 the CurrentBlock property on the emitcontext, so that we resolve
22091 constants propertly.
22093 2003-07-02 Martin Baulig <martin@ximian.com>
22095 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
22096 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
22098 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
22099 than emitting it here.
22101 * statement.cs: Fixed some more flow analysis bugs.
22103 2003-07-02 Martin Baulig <martin@ximian.com>
22105 * class.cs (MethodData.Define): When implementing interface
22106 methods, set Final unless we're Virtual.
22108 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
22109 check work for interface methods.
22111 2003-07-01 Martin Baulig <martin@ximian.com>
22113 * ecore.cs (EmitContext.This): Replaced this property with a
22114 GetThis() method which takes a Location argument. This ensures
22115 that we get the correct error location for a CS0188.
22117 2003-07-01 Miguel de Icaza <miguel@ximian.com>
22119 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
22120 ImplicitStandardConversion.
22122 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
22124 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
22126 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
22129 2003-06-30 Miguel de Icaza <miguel@ximian.com>
22131 * class.cs (Constructor.Define): Turn off initlocals for unsafe
22134 (MethodData.Define): Turn off initlocals for unsafe methods.
22136 2003-06-29 Miguel de Icaza <miguel@ximian.com>
22138 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
22139 complete; Fixes #37521.
22141 * delegate.cs: Use Modifiers.TypeAttr to compute the
22142 TypeAttributes, instead of rolling our own. This makes the flags
22143 correct for the delegates.
22145 2003-06-28 Miguel de Icaza <miguel@ximian.com>
22147 * class.cs (Constructor.Define): Set the private flag for static
22148 constructors as well.
22150 * cs-parser.jay (statement_expression): Set the return value to
22151 null, to avoid a crash when we catch an error.
22153 2003-06-24 Miguel de Icaza <miguel@ximian.com>
22155 * cs-parser.jay: Applied patch from Jackson that adds support for
22156 extern and unsafe modifiers to destructor declarations.
22158 * expression.cs: Report error 21 if the user is trying to index a
22161 * driver.cs: Add an error message, suggested by the bug report.
22163 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
22164 if we do not have a ": this ()" constructor initializer. Fixes 45149
22166 2003-06-14 Miguel de Icaza <miguel@ximian.com>
22168 * namespace.cs: Add some information to reduce FAQs.
22170 2003-06-13 Miguel de Icaza <miguel@ximian.com>
22172 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
22173 underlying enumeration types. Fixes #43915.
22175 * expression.cs: Treat ushort/short as legal values to be used in
22176 bitwise operations.
22178 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
22180 * delegate.cs: transfer custom attributes for paramenters from
22181 the delegate declaration to Invoke and BeginInvoke.
22183 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
22185 * attribute.cs: handle custom marshalers and emit marshal info
22188 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
22190 * makefile.gnu: Added anonymous.cs to the compiler sources.
22192 2003-05-28 Miguel de Icaza <miguel@ximian.com>
22194 * iterators.cs: Change the name of the proxy class to include two
22197 * cs-parser.jay: Update grammar to include anonymous methods.
22199 * anonymous.cs: new file.
22201 2003-05-27 Miguel de Icaza <miguel@ximian.com>
22203 * class.cs (Field.Define): Add missing test for pointers and
22206 2003-05-27 Ravi Pratap <ravi@ximian.com>
22208 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
22209 we use the stobj opcode.
22211 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
22212 since it wasn't the correct fix.
22214 It still is puzzling that we are required to use stobj for IntPtr
22215 which seems to be a ValueType.
22217 2003-05-26 Miguel de Icaza <miguel@ximian.com>
22219 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
22220 during regular simple name resolution. Now, the trick is that
22221 instead of returning for processing the simplename, we do a
22222 TypeManager.LookupType (ie, a rooted lookup as opposed to a
22223 contextual lookup type). If a match is found, return that, if
22224 not, return for further composition.
22226 This fixes long-standing 30485.
22228 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
22229 using the address to initialize an object, do an Stobj instead of
22230 using the regular Stelem.
22232 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
22233 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
22234 Because if we are a BaseIndexerAccess that value will be true.
22237 * statement.cs (GotoCase.Resolve): Return after reporting an
22238 error, do not attempt to continue.
22240 * expression.cs (PointerArithmetic.Emit): If our operand is a
22241 long, convert our constants to match the operand before
22242 multiplying. Convert to I type before adding. Fixes 43670.
22244 2003-05-14 Ravi Pratap <ravi@ximian.com>
22246 * enum.cs (ImplicitConversionExists) : Rename to
22247 ImplicitEnumConversionExists to remove ambiguity.
22249 * ecore.cs (NullCast): New type of cast expression class which
22250 basically is very similar to EmptyCast with the difference being
22251 it still is a constant since it is used only to cast a null to
22253 (eg. (string) null)
22255 * convert.cs (ImplicitReferenceConversion): When casting a null
22256 literal, we return a NullCast.
22258 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22259 should be around anymore.
22261 The renaming (reported was slightly wrong). Corrections:
22263 ConvertImplicitStandard -> ImplicitConversionStandard
22264 ConvertExplicitStandard -> ExplicitConversionStandard
22266 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22267 before passing them in !
22269 * convert.cs (ImplicitConversionStandard): When comparing for
22270 equal expr and target types, ensure that expr is not a
22273 In general, we must not be checking (expr_type ==
22274 target_type) in the top level conversion methods
22275 (ImplicitConversion, ExplicitConversion etc). This checking is
22276 done in the methods that they delegate to.
22278 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22280 * convert.cs: Move Error_CannotConvertType,
22281 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22282 ImplicitNumericConversion, ImplicitConversionExists,
22283 ImplicitUserConversionExists, StandardConversionExists,
22284 FindMostEncompassedType, FindMostSpecificSource,
22285 FindMostSpecificTarget, ImplicitUserConversion,
22286 ExplicitUserConversion, GetConversionOperators,
22287 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22288 TryImplicitIntConversion, Error_CannotConvertImplicit,
22289 ConvertImplicitRequired, ConvertNumericExplicit,
22290 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22291 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22294 Perform the following renames:
22296 StandardConversionExists -> ImplicitStandardConversionExists
22297 ConvertImplicit -> ImplicitConversion
22298 ConvertImplicitStandard -> ImplicitStandardConversion
22299 TryImplicitIntConversion -> ImplicitIntConversion
22300 ConvertImplicitRequired -> ImplicitConversionRequired
22301 ConvertNumericExplicit -> ExplicitNumericConversion
22302 ConvertReferenceExplicit -> ExplicitReferenceConversion
22303 ConvertExplicit -> ExplicitConversion
22304 ConvertExplicitStandard -> ExplicitStandardConversion
22306 2003-05-19 Martin Baulig <martin@ximian.com>
22308 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22309 (TypeInfo): Added support for structs having structs as fields.
22311 * ecore.cs (FieldExpr): Implement IVariable.
22312 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22313 VariableInfo for the field.
22315 2003-05-18 Martin Baulig <martin@ximian.com>
22317 * expression.cs (This.DoResolve): Report a CS0027 if we're
22318 emitting a field initializer.
22320 2003-05-18 Martin Baulig <martin@ximian.com>
22322 * expression.cs (This.ResolveBase): New public function.
22323 (This.DoResolve): Check for CS0188.
22325 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22328 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22329 `instance_expression' to null if we don't have any non-static
22332 2003-05-18 Martin Baulig <martin@ximian.com>
22334 Reworked the way how local variables and parameters are handled by
22335 the flow analysis code.
22337 * statement.cs (TypeInfo, VariableMap): New public classes.
22338 (VariableInfo): New public class. This is now responsible for
22339 checking whether a variable has been assigned. It is used for
22340 parameters and local variables.
22341 (Block.EmitMeta): Take the InternalParameters as argument; compute
22342 the layout of the flow vectors here.
22343 (Block.LocalMap, Block.ParameterMap): New public properties.
22344 (FlowBranching): The .ctor doesn't get the InternalParameters
22345 anymore since Block.EmitMeta() now computes the layout of the flow
22347 (MyStructInfo): This class is now known as `StructInfo' and nested
22348 in `TypeInfo'; we don't access this directly anymore.
22350 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22351 property and removed IsAssigned(), IsFieldAssigned(),
22352 SetAssigned() and SetFieldAssigned(); we now call them on the
22353 VariableInfo so we don't need to duplicate this code everywhere.
22355 * expression.cs (ParameterReference): Added `Block block' argument
22357 (LocalVariableReference, ParameterReference, This): The new
22358 VariableInfo class is now responsible for all the definite
22361 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22362 IsParameterAssigned, SetParameterAssigned): Removed.
22364 2003-05-18 Martin Baulig <martin@ximian.com>
22366 * typemanager.cs (InitCoreTypes): Try calling
22367 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22368 the 3-args-version. Corlib now also needs our `void_type'.
22369 (GetMethod): Added overloaded version which takes an optional
22370 `bool report_errors' to allow lookups of optional methods.
22372 2003-05-12 Martin Baulig <martin@ximian.com>
22374 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22375 only used for locals and not for parameters.
22377 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22379 * support.cs (InternalParameters.ParameterType): Return the
22380 ExternalType of the parameter.
22382 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22385 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22387 * class.cs (MethodData.Define): Do not set the `newslot' on
22388 interface members, if they are also flagged as "override".
22390 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22391 better code for ++i and i++. This only works for static fields
22392 and local variables.
22394 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22395 want to pull the DeclSpace out of the builder_to_declspace instead
22396 of the TypeBuilder (like in TypeContainer.FindMembers).
22398 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22399 instead of LookupTypeContainer. Fixes the crash on .NET for
22400 looking up interface members.
22402 * const.cs: Create our own emit context during the Definition
22403 stage, so that constants are evaluated in the proper context, when
22404 a recursive definition happens.
22406 2003-05-11 Martin Baulig <martin@ximian.com>
22408 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22409 new block for a switch section.
22410 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22411 the adding/lookup in the switch block. Fixes #39828.
22413 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22415 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22416 functionality: I needed to convert the data after I had performed
22417 the add/sub operation into the operands type size.
22419 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22420 pass the type for the box operation, otherwise the resulting
22421 object would have been of type object.
22423 (BoxedCast): Add constructor to specify the type to box as.
22425 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22427 * iterators.cs: I was reusing the `count' variable inadvertently,
22428 take steps to not allow this to happen.
22430 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22432 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22433 by creating an array at the point where the params starts and
22434 putting all those arguments there, then adjusting the size of the
22437 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22439 * expression.cs (New.AddressOf): Implement interface
22440 IMemoryLocation. This is used when the `new' operator is used in
22441 the context of an invocation to a method on a value type.
22443 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22446 * namespace.cs: Also check the using aliases here.
22448 * driver.cs: Move the test for using validity after the types have
22449 been entered, so we do a single pass that also includes the using
22452 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22453 in the regular case. CreateSiblingForFinally is doing extra
22456 * attribute.cs (GetAttributeArgumentExpression): Store the result
22457 on an out value, and use the return value to indicate failure
22458 instead of using null (which is a valid return for Constant.GetValue).
22460 * statement.cs: Perform the analysis flow for the increment
22461 portion after the statement, because this will be the real flow of
22462 execution. Fixes #42385
22464 * codegen.cs (EmitContext.EmitArgument,
22465 EmitContext.EmitStoreArgument): New helper functions when the
22466 RemapToProxy flag is set.
22468 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22471 Add support for remapping parameters.
22473 * iterators.cs: Propagate parameter values; Store parameter
22474 values in the proxy classes.
22476 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22478 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22479 need a proxy reference; I do not know what I was thinking
22481 * cs-parser.jay (constructor_initializer): catch another error,
22482 and display nice message.
22484 (field_declaration): catch void field declaration
22485 to flag a better error.
22487 * class.cs (MemberBase.CheckBase): Report an error instead of a
22488 warning if a new protected member is declared in a struct.
22489 (Field.Define): catch the error of readonly/volatile.
22491 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22493 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22494 volatile variable is taken
22496 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22498 * statement.cs (Fixed.Resolve): Report an error if we are not in
22501 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22503 * typemanager.cs: reuse the code that handles type clashes for
22504 delegates and enumerations.
22506 * class.cs (Report28): Always report.
22508 * expression.cs (EncodeAsAttribute): Allow nulls here.
22510 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22512 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22513 the functionality for testing whether an expression is valid for
22514 an attribute here. Also handle the case of arrays of elements
22517 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22518 encoding a linear array into an array of objects that are suitable
22519 to be passed to an CustomAttributeBuilder.
22521 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22523 * ecore.cs: (FieldExpr): Handle field remapping here.
22525 * iteratators.cs: Pass the instance variable (if the method is an
22526 instance method) to the constructors, so we can access the field
22527 variables on the class.
22529 TODO: Test this with structs. I think the THIS variable on
22530 structs might have to be a pointer, and not a refenrece
22532 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22534 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22535 local variables to fields in a proxy class.
22537 * iterators.cs (PopulateProxy): Rename our internal fields to
22539 Create a <THIS> field if we are an instance method, so we can
22540 reference our parent container variables.
22541 (MapVariable): Called back from the EmitContext code to enter a
22542 new variable to field mapping into the proxy class (we just create
22546 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22547 for using the remapped locals to fields.
22549 I placed the code here, because that gives the same semantics to
22550 local variables, and only changes the Emit code.
22552 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22553 statements inside iterators.
22554 (VariableInfo): Add a FieldBuilder for the cases when we are
22555 remapping local variables to fields in a proxy class
22557 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22558 current_block != null.
22560 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22561 not cope with strings, as it has been moved to the
22562 TableSwitchEmit. Fixed bug in switch generation.
22564 * expression.cs (New.DoResolve): Provide more context for the user
22565 when reporting an error.
22567 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22570 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22571 check the permissions for it. Note than in a type-resolution
22572 context the check was already present in DeclSpace.ResolveType,
22573 but was missing from the MemberAccess.
22575 (ArrayCreation.CheckIndices): warn if the user has
22576 more nested levels of expressions, but there are no more
22577 dimensions specified. Avoids crash on bug 41906.
22579 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22581 * statement.cs (Block): replace Implicit bool, for a generic
22583 New flag: `Unchecked'. This is used during the EmitMeta phase
22584 (which is out-of-line with the regular Resolve/Emit process for a
22585 statement, as this is done ahead of time, but still gets a chance
22586 to call constant resolve).
22588 (Block.Flags): new enum for adding a new flag.
22590 (Block.EmitMeta): track the state of unchecked.
22592 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22593 to enable constant resolution to work there as well.
22595 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22597 * typemanager.cs (ienumerable_type): Also look up
22598 System.Collections.IEnumerable.
22600 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22602 TODO: Test more than one conditional per method.
22604 * class.cs (Indexer.Define): Report the location where the user is
22605 referencing the unsupported feature.
22607 (MethodData): Overload the use of `conditionals' to
22608 minimize the creation of needless ArrayLists. This saves roughly
22609 212kb on my machine.
22611 (Method): Implement the new IIteratorContainer interface.
22612 (Method.SetYields): Implement the method by setting the ModFlags
22613 to contain METHOD_YIELDS.
22615 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22616 which just got set to null.
22618 * iterators.cs: New file.
22620 (Yield, YieldBreak): New statements.
22622 * statement.cs (Return.Resolve): Flag an error if we are used in
22623 an iterator method.
22625 * codegen.cs (InIterator): New flag set if the code is being
22626 compiled in an iterator method.
22628 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22629 internal modifier, and we just use it to avoid adding extra
22630 fields, as this is seldom used.
22632 * cs-parser.jay: Add yield_statement (yield and yield break).
22634 * driver.cs: New flag -v2 to turn on version 2 features.
22636 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22637 hashtable when v2 is enabled.
22639 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22641 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22642 there is already a namespace defined with this name.
22644 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22645 people upgraded their corlibs.
22647 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22648 always use fully qualified types, no need to use the compiler
22651 (TypeManager.IsNamespace): Use binarysearch.
22653 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22654 AddDelegate): I did not quite use the new IsValid API properly: I
22655 have to pass the short-name and the fullname. I was passing only
22656 the basename instead of the fullname sometimes.
22658 (TypeContainer.DefineType): call NamespaceClash.
22660 * interface.cs (Interface.DefineType): use NamespaceClash before
22663 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22666 * enum.cs: (Enum.DefineType): use NamespaceClash before
22669 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22670 speed increase. First, use the negative_hits cache when we get a
22671 negative. Second, add the type with its full original name
22672 instead of the new . and + encoded name (reflection uses + to
22673 separate type from a nested type). Use LookupTypeReflection
22674 directly which bypasses the type->name hashtable (that we already
22675 know does not contain the type.
22677 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22678 location/container type.
22680 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22682 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22684 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22686 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22687 method is being referenced in the method group from a static
22688 context, and report error 120 if so.
22690 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22693 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22694 is created, we create the A namespace).
22696 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22699 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22701 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22702 invocation to ModuleBuilder.GetType with the same values will
22703 return a new type instance, so we need to cache its return
22706 * expression.cs (Binary.ResolveOperator): Only allow the compare
22707 operators on enums if they are of the same type.
22709 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22710 types of ValueType on their own case. Before we were giving them
22711 the same treatment as objects.
22713 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22714 fullname. Short name is used to compare against container name.
22715 Fullname is used to check against defined namespace names.
22717 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22718 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22720 (Method.CheckBase): Call parent.
22721 (MemberBase.CheckBase): Check for protected members on sealed
22723 (PropertyBase.CheckBase): Call parent.
22724 (Field.Define): Call parent.
22726 * report.cs: Negative error codes are now mapped to 8000 - code,
22727 so that the display is render more nicely.
22729 * typemanager.cs: Do not use try/catch, instead report a regular
22732 (GetPointerType, GetReferenceType): These methods provide
22733 mechanisms to obtain the T* and T& from a T. We had the code
22734 previously scattered around the code base, and it also used
22735 TypeManager.LookupType that would go through plenty of caches.
22736 This one goes directly to the type source.
22738 In some places we did the Type.GetType followed by
22739 ModuleBuilder.GetType, but not in others, so this unifies the
22740 processing as well.
22742 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22743 statements now that we have namespace information.
22745 * typemanager.cs (IsNamespace): New method, returns whether the
22746 string presented is a namespace or not.
22748 (ComputeNamespaces): New public entry point, computes the list of
22749 available namespaces, using the GetNamespaces API call in Mono, or
22750 the slower version in MS.NET.
22752 Now before we start the semantic analysis phase, we have a
22753 complete list of namespaces including everything that the user has
22756 Deleted old code to cache namespaces in .nsc files.
22758 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22760 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22761 class/struct location definition Location for the implicit
22762 constructor location.
22764 (Operator.Define): Use the location of the operator for the
22765 implicit Method definition.
22767 (Constructor.Emit): use the constructor location for the implicit
22768 base initializer constructor.
22770 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22771 and the Expression class now contains two new methods:
22773 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22774 isolate type lookup from the rest of the resolution process.
22776 Since we use Expressions to hold type definitions due to the way
22777 we parse the input we have historically overloaded Resolve to
22778 perform the Type lookups if a special flag is passed. Now this is
22779 eliminated and two methods take their place.
22781 The differences in the two methods between xStep and xTerminal is
22782 that xStep is involved in our current lookup system that uses
22783 SimpleNames to compose a name, while xTerminal is used just to
22784 catch the case where the simplename lookup failed.
22786 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22788 * expression.cs (ResolveMemberAccess): Remove redundant code.
22789 TypeExpr expressions are always born fully resolved.
22791 * interface.cs (PopulateMethod): Do not lookup the types twice.
22792 We were doing it once during SemanticAnalysis and once during
22795 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22796 in local variable type definitions, were being returned as a
22797 SimpleName (we decomposed everything into a string), that is
22798 because primary_expression was being used instead of a type in the
22799 grammar (reduce/reduce conflicts).
22801 The part that was wrong is that we converted the expression into a
22802 string (an oversimplification in one hand, compounded with primary
22803 expressions doing string concatenation).
22809 Would return "A.B.C[]" as a SimpleName. This stopped things like
22810 using clauses from working on this particular context. And a type
22811 was being matched directly against "A.B.C[]".
22813 We now use the correct approach, and allow for ComposedCast to be
22814 part of the unary expression. So the "A.B.C []" become a composed
22815 cast of "A.B.C" (as a nested group of MemberAccess with a
22816 SimpleName at the end) plus the rank composition "[]".
22820 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22822 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22823 for the access level checking.
22825 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22826 `TypeContainer container', because I kept getting confused when I
22827 was debugging this code.
22829 * expression.cs (Indexers): Instead of tracking getters/setters,
22830 we now track them in parallel. We create one arraylist less, but
22831 most importantly it is possible now for the LValue code to find a
22832 matching get for a set.
22834 (IndexerAccess.DoResolveLValue): Update the code.
22835 GetIndexersForType has been modified already to extract all the
22836 indexers from a type. The code assumed it did not.
22838 Also make the code set the correct return type for the indexer.
22839 This was fixed a long time ago for properties, but was missing for
22840 indexers. It used to be void_type.
22842 (Binary.Emit): Test first for doubles instead of
22843 floats, as they are more common.
22845 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22846 when dealing with floats and the <=, >= operators. This fixes bug
22849 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22850 to load the array value by emitting a load on the foreach variable
22851 type. This was incorrect.
22853 We now emit the code to load an element using the the array
22854 variable type, and then we emit the conversion operator.
22858 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22860 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22862 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22864 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22865 test for protection before we test for signatures.
22867 (MethodSignature.ToString): implement.
22869 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22870 to the case where we reduced into a LongConstant.
22872 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22873 depend on whether the information is acurrate, because the
22874 Microsoft runtime will always claim that the array type is public,
22875 regardless of the real state.
22877 If the type is a pointer, another problem happens: the type is
22878 reported as non-public in Microsoft.
22880 In both cases we have to call CheckAccessLevel recursively with
22881 the underlying type as the argument to be tested.
22883 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22885 * assign.cs (Assign.Emit): If we are dealing with a compound
22886 assignment expression, we should use the code path that stores the
22887 intermediate result in a temporary value. This fixes #40903.
22889 *expression.cs (Indirection.ToString): Provide ToString method for
22892 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22894 * class.cs: Null out fields holding references to Block objects so
22895 they can be garbage collected.
22897 * expression.cs (OverloadResolve): Remove unused local.
22899 2003-04-07 Martin Baulig <martin@ximian.com>
22901 * codegen.cs (EmitContext.CurrentFile): New public field.
22902 (EmitContext.Mark): Use the CurrentFile to check whether the
22903 location is in the correct file.
22904 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22906 2003-04-07 Martin Baulig <martin@ximian.com>
22908 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22910 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22911 location. [FIXME: The location argument which gets passed to this
22912 method is sometimes wrong!]
22914 2003-04-07 Nick Drochak <ndrochak@gol.com>
22916 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22918 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22920 * expression.cs (Indirection.EmitAssign): We were using the
22921 temporary, but returning immediately instead of continuing the
22924 2003-04-06 Martin Baulig <martin@ximian.com>
22926 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22927 if it's a nested child, but also deriving from the outer class.
22930 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22931 nested child, but also deriving from the outer class. See
22933 (FilterWithClosure): We may access private members of the outer
22934 class if we're a nested child and deriving from the outer class.
22935 (RealMemberLookup): Only set `closure_private_ok' if the
22936 `original_bf' contained BindingFlags.NonPublic.
22938 2003-04-05 Martin Baulig <martin@ximian.com>
22940 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22942 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22944 * class.cs (Event.Define): Do not allow abstract events to have
22947 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22949 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22950 block in event declarations.
22952 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22953 value type, get its address.
22955 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22956 leaving a class on the stack instead of a boolean value (int
22957 0/1). Change the code so we compare against null, and then the
22958 result against zero.
22960 * class.cs (TypeContainer.GetClassBases): We were checking for the
22961 parent class being sealed too late.
22963 * expression.cs (Binary.Emit): For <= and >= when dealing with
22964 floating point values, use cgt.un and clt.un instead of cgt and
22967 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22969 * statement.cs: Apply the same optimization as MS: skip the
22970 GetEnumerator returning an IEnumerator, and use the one returning a
22971 CharEnumerator instead. This allows us to avoid the try-finally block
22974 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22976 * cs-parser.jay: Attributes cannot be applied to
22977 namespaces. Fixes #40473
22979 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22982 (Add*): check if the name is valid using the full name for constants,
22983 fields, properties and events.
22985 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22987 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22988 char constants to be part of the enumeration.
22990 * expression.cs (Conditional.DoResolve): Add support for operator
22991 true. Implements the missing functionality from 14.12
22993 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22994 operator true/false as required by the spec.
22996 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22997 implicit conversion to boolean.
22999 * statement.cs (Statement.ResolveBoolean): A boolean expression is
23000 also one where the type implements `operator true'.
23002 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
23003 get an expression that will invoke operator true based on an
23006 (GetConversionOperators): Removed the hack that called op_True
23009 (Expression.ResolveBoolean): Move this from Statement.
23011 2003-03-17 Miguel de Icaza <miguel@ximian.com>
23013 * ecore.cs (FieldExpr): do not allow initialization of initonly
23014 fields on derived classes
23016 2003-03-13 Martin Baulig <martin@ximian.com>
23018 * statement.cs (Block.Emit): Call ig.BeginScope() and
23019 ig.EndScope() when compiling with debugging info; call
23020 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
23022 2003-03-08 Miguel de Icaza <miguel@ximian.com>
23024 * expression.cs (Indexers): Do not construct immediately, allow
23025 for new members to be appended as we go. Fixes 38143
23027 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23029 * expression.cs: save/restore context when resolving an unchecked
23032 2003-03-05 Miguel de Icaza <miguel@ximian.com>
23034 * cfold.cs: Catch division by zero in modulus operator during
23037 2003-03-03 Miguel de Icaza <miguel@ximian.com>
23039 * interface.cs (Interface.DefineMembers): Avoid defining members
23042 2003-02-27 Miguel de Icaza <miguel@ximian.com>
23044 * driver.cs: handle the +/- options for -noconfig
23046 * statement.cs (Unckeched.Resolve): Also track the state of
23047 unchecked in the Resolve phase.
23049 2003-02-27 Martin Baulig <martin@ximian.com>
23051 * ecore.cs (Expression.MemberLookup): Don't create a
23052 MethodGroupExpr for something which is not a method. Fixes #38291.
23054 2003-02-25 Miguel de Icaza <miguel@ximian.com>
23056 * class.cs (MemberBase.CheckParameters): Also check that the type
23057 is unmanaged if it is a pointer.
23059 * expression.cs (SizeOf.Resolve): Add location information.
23061 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
23062 a managed type is declared.
23064 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
23065 parameter modifiers as well. Fixes bug 38606
23067 * class.cs: Very sad. Am backing out the speed up changes
23068 introduced by the ArrayList -> Array in the TypeContainer, as they
23069 were not actually that much faster, and introduced a bug (no error
23070 reports on duplicated methods).
23072 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
23073 source first, this will guarantee that we have a valid expression
23074 before calling in lower levels functions that will require a
23075 resolved object. Then use this original_source in the
23076 target.ResolveLValue instead of the original source that was
23079 Another change. Use target.Resolve instead of LValueResolve.
23080 Although we are resolving for LValues, we will let the Assign code
23081 take care of that (it will be called again from Resolve). This
23082 basically allows code like this:
23084 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
23085 class Y { void A (X x) { x [0] += o; }
23087 The problem was that the indexer was trying to resolve for
23088 set_Item (idx, object o) and never finding one. The real set_Item
23089 was set_Item (idx, X). By delaying the process we get the right
23094 2003-02-23 Martin Baulig <martin@ximian.com>
23096 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
23097 while calling DoEmit ().
23099 * codegen.cs (EmitContext.Mark): Don't mark locations in other
23100 source files; if you use the #line directive inside a method, the
23101 compiler stops emitting line numbers for the debugger until it
23102 reaches the end of the method or another #line directive which
23103 restores the original file.
23105 2003-02-23 Martin Baulig <martin@ximian.com>
23107 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
23109 2003-02-23 Martin Baulig <martin@ximian.com>
23111 * statement.cs (Block.AddChildVariableNames): We need to call this
23112 recursively, not just for our immediate children.
23114 2003-02-23 Martin Baulig <martin@ximian.com>
23116 * class.cs (Event.Define): Always make the field private, like csc does.
23118 * typemanager.cs (TypeManager.RealMemberLookup): Make events
23119 actually work, fixes bug #37521.
23121 2003-02-23 Miguel de Icaza <miguel@ximian.com>
23123 * delegate.cs: When creating the various temporary "Parameters"
23124 classes, make sure that we call the ComputeAndDefineParameterTypes
23125 on those new parameters (just like we do with the formal ones), to
23126 allow them to be resolved in the context of the DeclSpace.
23128 This fixes the bug that Dick observed in Bugzilla #38530.
23130 2003-02-22 Miguel de Icaza <miguel@ximian.com>
23132 * expression.cs (ResolveMemberAccess): When resolving a constant,
23133 do not attempt to pull a constant if the value was not able to
23134 generate a valid constant.
23136 * const.cs (LookupConstantValue): Do not report more errors than required.
23138 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23140 * expression.cs: fixes bug #38328.
23142 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23144 * class.cs: Changed all the various members that can be part of a
23145 class from being an ArrayList to be an Array of the right type.
23146 During the DefineType type_list, interface_list, delegate_list and
23147 enum_list are turned into types, interfaces, delegates and enums
23150 And during the member population, indexer_list, event_list,
23151 constant_list, field_list, instance_constructor_list, method_list,
23152 operator_list and property_list are turned into their real arrays.
23154 Although we could probably perform this operation earlier, for
23155 good error reporting we need to keep the lists and remove the
23156 lists for longer than required.
23158 This optimization was triggered by Paolo profiling the compiler
23159 speed on the output of `gen-sample-program.pl' perl script.
23161 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
23162 not crash in methods like MemberLookupFailed that use this field.
23164 This problem arises when the compiler fails to resolve a type
23165 during interface type definition for example.
23167 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23169 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
23170 inherit from System.Object, so we have to stop at null, not only
23171 when reaching System.Object.
23173 2003-02-17 Miguel de Icaza <miguel@ximian.com>
23175 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
23176 DeclaredOnly because the parent indexer might have had a different
23177 name, but did not loop until the top of the hierarchy was reached.
23179 The problem this one fixes is 35492: when a class implemented an
23180 indexer from an interface, we were getting the interface method
23181 (which was abstract) and we were flagging an error (can not invoke
23184 This also keeps bug 33089 functioning, and test-148 functioning.
23186 * typemanager.cs (IsSpecialMethod): The correct way of figuring
23187 out if a method is special is to see if it is declared in a
23188 property or event, or whether it is one of the predefined operator
23189 names. This should fix correctly #36804.
23191 2003-02-15 Miguel de Icaza <miguel@ximian.com>
23193 The goal here is to remove the dependency on EmptyCast.Peel ().
23194 Killing it completely.
23196 The problem is that currently in a number of places where
23197 constants are expected, we have to "probe" for an EmptyCast, and
23198 Peel, which is not the correct thing to do, as this will be
23199 repetitive and will likely lead to errors.
23201 The idea is to remove any EmptyCasts that are used in casts that
23202 can be reduced to constants, so we only have to cope with
23205 This bug hunt was triggered by Bug 37363 and the desire to remove
23206 the duplicate pattern where we were "peeling" emptycasts to check
23207 whether they were constants. Now constants will always be
23210 * ecore.cs: Use an enumconstant here instead of wrapping with
23213 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
23214 throwing me off. By handling this we can get rid of a few hacks.
23216 * statement.cs (Switch): Removed Peel() code.
23218 2003-02-14 Miguel de Icaza <miguel@ximian.com>
23220 * class.cs: Location information for error 508
23222 * expression.cs (New.DoResolve): Add a guard against double
23223 resolution of an expression.
23225 The New DoResolve might be called twice when initializing field
23226 expressions (see EmitFieldInitializers, the call to
23227 GetInitializerExpression will perform a resolve on the expression,
23228 and later the assign will trigger another resolution
23230 This leads to bugs (#37014)
23232 * delegate.cs: The signature for EndInvoke should contain any ref
23233 or out parameters as well. We were not doing this in the past.
23235 * class.cs (Field.Define): Do not overwrite the type definition
23236 inside the `volatile' group. Turns out that volatile enumerations
23237 were changing the type here to perform a validity test, which
23240 2003-02-12 Miguel de Icaza <miguel@ximian.com>
23242 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
23243 and structs, we do not want to load the instance variable
23245 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
23246 enum_type has to be handled like an object reference (implicit
23247 conversions exists from this to object), but the regular IsClass
23248 and IsValueType tests will never return true for this one.
23250 Also we use TypeManager.IsValueType instead of type.IsValueType,
23251 just for consistency with the rest of the code (this is only
23252 needed if we ever use the construct exposed by test-180.cs inside
23253 corlib, which we dont today).
23255 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23257 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23260 2003-02-09 Martin Baulig <martin@ximian.com>
23262 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23263 (Namespace.DefineNamespaces): New static public method; this is
23264 called when we're compiling with debugging to add all namespaces
23265 to the symbol file.
23267 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23268 pass it to the Namespace's .ctor.
23270 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23271 and MethodBase arguments; pass the namespace ID to the symwriter;
23272 pass the MethodBase instead of the token to the symwriter.
23273 (SymbolWriter.DefineNamespace): New method to add a namespace to
23276 2003-02-09 Martin Baulig <martin@ximian.com>
23278 * symbolwriter.cs: New file. This is a wrapper around
23279 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23280 methods here in near future.
23282 2003-02-09 Martin Baulig <martin@ximian.com>
23284 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23285 ILGenerator.MarkSequencePoint() which are actually used by the
23288 2003-02-09 Martin Baulig <martin@ximian.com>
23290 * location.cs (SourceFile): New public sealed class. This
23291 contains the name and an index which is used in the location's token.
23292 (Location): Reserve an appropriate number of bits in the token for
23293 the source file instead of walking over that list, this gives us a
23294 really huge performance improvement when compiling with debugging.
23296 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23297 `SourceFile' argument instead of a string.
23298 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23299 but don't parse/tokenize here, we need to generate the list of all
23300 source files before we do that.
23301 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23304 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23305 instead of a string.
23307 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23310 2003-02-09 Martin Baulig <martin@ximian.com>
23312 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23313 filename on `#line default'.
23315 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23317 * statement.cs: don't clear the pinned var when the fixed statement
23318 returns from the method (fixes bug#37752).
23320 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23322 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23325 2003-02-07 Martin Baulig <martin@ximian.com>
23327 * driver.cs: Removed the `--debug-args' command line argument.
23329 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23330 automatically by the AsssemblyBuilder.
23331 (CodeGen.InitializeSymbolWriter): We don't need to call any
23332 initialization function on the symbol writer anymore. This method
23333 doesn't take any arguments.
23335 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23337 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23338 from referenced assemblies as well.
23340 2003-02-02 Martin Baulig <martin@ximian.com>
23342 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23344 2003-02-02 Martin Baulig <martin@ximian.com>
23346 * class.cs (Constructor.Emit): Open the symbol writer before
23347 emitting the constructor initializer.
23348 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23349 single-stepping through constructor initializers.
23351 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23353 * class.cs: Handle error 549: do not allow virtual methods in
23356 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23358 * decl.cs: Check access levels when resolving types
23360 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23362 * statement.cs: Add parameters and locals set in catch blocks that might
23363 return to set vector
23365 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23367 * class.cs (Operator): Set the SpecialName flags for operators.
23369 * expression.cs (Invocation.DoResolve): Only block calls to
23370 accessors and operators on SpecialName methods.
23372 (Cast.TryReduce): Handle conversions from char constants.
23375 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23377 * statement.cs: small memory and time optimization in FlowBranching.
23379 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23381 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23382 problem that the last fix but in the other sid (Set).
23384 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23385 access when there is no indexer in the hierarchy.
23387 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23389 * class.cs: Combine some if statements.
23391 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23393 * driver.cs: fixed bug #37187.
23395 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23397 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23398 any indexer, it's needed to build a list with all the indexers in the
23399 hierarchy (AllGetters), else we have problems. Fixes #35653.
23401 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23403 * class.cs (MethodData.Define): It is wrong for an interface
23404 implementation to be static in both cases: explicit and implicit.
23405 We were only handling this in one case.
23407 Improve the if situation there to not have negations.
23409 * class.cs (Field.Define): Turns out that we do not need to check
23410 the unsafe bit on field definition, only on usage. Remove the test.
23412 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23414 * driver.cs: use assembly.Location instead of Codebase (the latest
23415 patch made mcs fail when using MS assemblies).
23417 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23419 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23420 get the path to *corlib.dll.
23422 2003-01-21 Nick Drochak <ndrochak@gol.com>
23426 * typemanager.cs: Remove compiler warnings
23428 2003-01-20 Duncan Mak <duncan@ximian.com>
23430 * AssemblyInfo.cs: Bump the version number to 0.19.
23432 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23434 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23436 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23438 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23440 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23442 * cs-parser.jay: Small fix: we were not comparing the constructor
23443 name correctly. Thanks to Zoltan for the initial pointer.
23445 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23447 * cs-tokenizer.cs: Set file name when specified with #line
23449 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23451 * cs-parser.jay: Only perform the constructor checks here if we
23452 are named like the class; This will help provider a better
23453 error. The constructor path is taken when a type definition is
23454 not found, but most likely the user forgot to add the type, so
23455 report that rather than the constructor error.
23457 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23459 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23462 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23464 * cs-parser.jay: Add cleanup call.
23466 2003-01-13 Duncan Mak <duncan@ximian.com>
23468 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23469 consistent with other methods.
23471 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23473 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23475 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23477 * attribute.cs: only set GuidAttr to true when we have a
23480 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23484 * typemanager.cs: fixes to allow mcs compile corlib with the new
23485 Type.IsSubclassOf fix.
23487 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23489 * expression.cs (LocalVariableReference.DoResolve): Classify a
23490 constant as a value, not as a variable. Also, set the type for
23493 * cs-parser.jay (fixed_statement): take a type instead of a
23494 pointer_type, so we can produce a better error message later.
23496 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23499 (For.DoEmit): Make inifinite loops have a
23500 non-conditional branch back.
23502 (Fixed.DoEmit): First populate the pinned variables, then emit the
23503 statement, then clear the variables. Before I was emitting the
23504 code once for each fixed piece.
23507 2003-01-08 Martin Baulig <martin@ximian.com>
23509 * statement.cs (FlowBranching.MergeChild): A break in a
23510 SWITCH_SECTION does not leave a loop. Fixes #36155.
23512 2003-01-08 Martin Baulig <martin@ximian.com>
23514 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23515 lives in the same number space than `param_map'. Fixes #36154.
23517 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23519 * cs-parser.jay (constructor_declaration): Set the
23520 Constructor.ModFlags before probing for it. This makes the
23521 compiler report 514, 515 and 132 (the code was there, but got
23524 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23525 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23526 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23528 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23530 * enum.cs: create the enum static fields using the enum type.
23532 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23534 * class.cs: don't try to create the ParamBuilder for the return
23535 type if it's not needed (and handle it breaking for the ms runtime
23538 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23540 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23542 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23544 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23545 the command. This showed up while compiling the JANET source
23546 code, which used \r as its only newline separator.
23548 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23550 * class.cs (Method.Define): If we are an operator (because it
23551 reuses our code), then set the SpecialName and HideBySig. #36128
23553 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23555 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23556 exception, report error 120 `object reference required'.
23558 * driver.cs: Add --pause option, used during to measure the size
23559 of the process as it goes with --timestamp.
23561 * expression.cs (Invocation.DoResolve): Do not allow methods with
23562 SpecialName to be invoked.
23564 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23566 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23567 number before adding it.
23569 2002-12-21 Ravi Pratap <ravi@ximian.com>
23571 * ecore.cs (StandardImplicitConversion): When in an unsafe
23572 context, we allow conversion between void * to any other pointer
23573 type. This fixes bug #35973.
23575 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23577 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23578 is not thrown when extensionless outputs are used
23580 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23582 * rootcontext.cs: fixed compilation of corlib.
23584 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23586 * attribute.cs (Attributes.Contains): Add new method.
23588 * class.cs (MethodCore.LabelParameters): if the parameter is an
23589 `out' parameter, check that no attribute `[In]' has been passed.
23591 * enum.cs: Handle the `value__' name in an enumeration.
23593 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23595 * decl.cs: Added special case to allow overrides on "protected
23598 2002-12-18 Ravi Pratap <ravi@ximian.com>
23600 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23601 since it makes much more sense.
23603 (Attributes.ctor): Don't require a Location parameter.
23605 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23607 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23608 since we already have that information per attribute.
23610 * everywhere : make appropriate changes.
23612 * class.cs (LabelParameters): Write the code which actually
23613 applies attributes to the return type. We can't do this on the MS
23614 .NET runtime so we flag a warning in the case an exception is
23617 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23619 * const.cs: Handle implicit null conversions here too.
23621 2002-12-17 Ravi Pratap <ravi@ximian.com>
23623 * class.cs (MethodCore.LabelParameters): Remove the extra
23624 Type [] parameter since it is completely unnecessary. Instead
23625 pass in the method's attributes so that we can extract
23626 the "return" attribute.
23628 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23630 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23631 of ignoring it and letting the compile continue.
23633 * typemanager.cs (ChangeType): use an extra argument to return an
23634 error condition instead of throwing an exception.
23636 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23638 * expression.cs (Unary.TryReduce): mimic the code for the regular
23639 code path. Perform an implicit cast in the cases where we can
23640 implicitly convert to one of the integral types, and then reduce
23641 based on that constant. This fixes bug #35483.
23643 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23645 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23647 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23649 * namespace.cs: fixed bug #35489.
23651 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23653 * class.cs: Remove some dead code.
23655 * cs-parser.jay: Estimate the number of methods needed
23656 (RootContext.MethodCount);
23658 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23659 numbers instead of StringBuilders.
23661 * support.cs (PtrHashtable): Add constructor with initial size;
23662 We can now reduce reallocations of the method table.
23664 2002-12-10 Ravi Pratap <ravi@ximian.com>
23666 * attribute.cs (ApplyAttributes): Keep track of the emitted
23667 attributes on a per-target basis. This fixes bug #35413.
23669 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23671 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23672 default to the Windows 1252 encoding.
23674 (UnixParseOption): Support version, thanks to Alp for the missing
23677 * AssemblyInfo.cs: Add nice assembly information.
23679 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23682 * cs-parser.jay: Allow a trailing comma before the close bracked
23683 in the attribute_section production.
23685 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23686 address of the instance was being taken, I will take this out,
23687 because we take the address of the object immediately here.
23689 2002-12-09 Ravi Pratap <ravi@ximian.com>
23691 * typemanager.cs (AreMultipleAllowed): Take care of the most
23692 obvious case where attribute type is not in the current assembly -
23695 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23697 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23698 definitions, instead of doing that afterwards.
23700 Also we use a nice little hack, depending on the constructor, we
23701 know if we are a "composed" name or a simple name. Hence, we
23702 avoid the IndexOf test, and we avoid
23704 * codegen.cs: Add code to assist in a bug reporter to track down
23705 the source of a compiler crash.
23707 2002-12-07 Ravi Pratap <ravi@ximian.com>
23709 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23710 types have been emitted for a given element and flag an error
23711 if something which does not have AllowMultiple set is used more
23714 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23715 attribute types and their corresponding AllowMultiple properties
23717 (AreMultipleAllowed): Check the property for a given type.
23719 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23720 property in the case we have a TypeContainer.
23722 (Attributes.AddAttribute): Detect duplicates and just skip on
23723 adding them. This trivial fix catches a pretty gross error in our
23724 attribute emission - global attributes were being emitted twice!
23726 Bugzilla bug #33187 is now fixed.
23728 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23730 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23731 instead of pp_and).
23733 * expression.cs (Binary.ResolveOperator): I can only use the
23734 Concat (string, string, string) and Concat (string, string,
23735 string, string) if the child is actually a concatenation of
23738 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23740 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23741 context where we need a 2-character lookahead.
23743 * pending.cs (PendingImplementation): Rework so we can keep track
23744 of interface types all the time, and flag those which were
23745 implemented by parents as optional.
23747 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23749 * expression.cs (Binary.ResolveOperator): Use
23750 String.Concat(string,string,string) or
23751 String.Concat(string,string,string,string) when possible.
23753 * typemanager: More helper methods.
23756 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23758 * pending.cs: remove the bogus return from GetMissingInterfaces()
23759 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23761 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23763 * namespace.cs: avoid duplicated 'using xxx' being added to
23764 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23765 when we get more than one 'using' statement for the same namespace.
23766 Report a CS0105 warning for it.
23768 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23770 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23771 of calling getChar/putback, uses internal knowledge of it.
23773 (xtoken): Reorder tokenizer so most common patterns are checked
23774 first. This reduces the compilation time in another 5% (from 8.11s
23775 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23777 The parsing time is 22% of the compilation in mcs, and from that
23778 64% is spent on the tokenization process.
23780 I tried using a binary search for keywords, but this is slower
23781 than the hashtable. Another option would be to do a couple of
23784 * Not use a StringBuilder, instead use an array of chars,
23785 with a set value. Notice that this way we could catch
23786 the 645 error without having to do it *afterwards*.
23788 * We could write a hand-parser to avoid the hashtable
23789 compares altogether.
23791 The identifier consumption process takes 37% of the tokenization
23792 time. Another 15% is spent on is_number. 56% of the time spent
23793 on is_number is spent on Int64.Parse:
23795 * We could probably choose based on the string length to
23796 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23799 Another 3% is spend on wrapping `xtoken' in the `token' function.
23801 Handle 0xa0 as whitespace (#34752)
23803 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23805 * typemanager.cs (IsCLRType): New routine to tell whether a type
23806 is one of the builtin types.
23808 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23809 typecode in more places instead of doing pointer comparissions.
23810 We could leverage some knowledge about the way the typecodes are
23813 New code to cache namespaces in assemblies, it is currently not
23814 invoked, to be used soon.
23816 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23818 * expression.cs (Binary.ResolveOperator): specially handle
23819 strings, and do not perform user-defined operator overloading for
23822 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23824 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23825 internalcall as it is a pretty simple operation; Avoid whenever
23826 possible to call Char.IsLetter.
23828 (consume_identifier): Cut by half the number of
23829 hashtable calls by merging the is_keyword and GetKeyword behavior.
23831 Do not short-circuit, because if we do, we
23832 report errors (ie, #if false && true would produce an invalid
23836 2002-11-24 Martin Baulig <martin@ximian.com>
23838 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23839 check constant ranges and report a CS0221. Fixes #33186.
23841 2002-11-24 Martin Baulig <martin@ximian.com>
23843 * cs-parser.jay: Make this work for uninitialized variable
23844 declarations in the `for' initializer. Fixes #32416.
23846 2002-11-24 Martin Baulig <martin@ximian.com>
23848 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23849 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23851 2002-11-24 Martin Baulig <martin@ximian.com>
23853 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23854 argument; if true, we also check for user-defined conversions.
23855 This is only needed if both arguments are of a user-defined type.
23856 Fixes #30443, added test-175.cs.
23857 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23859 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23861 2002-11-24 Martin Baulig <martin@ximian.com>
23863 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23864 function to get the store opcode.
23865 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23866 only emit the Ldelema if the store opcode is Stobj. You must run
23867 both test-34 and test-167 to test this. Fixes #34529.
23869 2002-11-23 Martin Baulig <martin@ximian.com>
23871 * ecore.cs (Expression.MemberLookup): Added additional
23872 `qualifier_type' argument which is used when we're being called
23873 from MemberAccess.DoResolve() and null if we're called from a
23875 (Expression.MemberLookupFailed): New method to report errors; this
23876 does the CS1540 check and reports the correct error message.
23878 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23879 argument for the CS1540 check and redone the way how we're dealing
23880 with private members. See the comment in the source code for details.
23881 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23882 `closure_start_type' to `closure_qualifier_type' and check whether
23883 it's not null. It was not this filter being broken, it was just
23884 being called with the wrong arguments.
23886 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23887 and pass it the correct `qualifier_type'; this also does the error
23890 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23892 * expression.cs (Invocation.EmitParams): If the we are dealing
23893 with a non-built-in value type, load its address as well.
23895 (ArrayCreation): Use a a pretty constant instead
23896 of the hardcoded value 2. Use 6 instead of 2 for the number of
23897 static initializers.
23899 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23900 because they are not really value types, just glorified integers.
23902 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23904 * ecore.cs: Remove redundant code for enumerations, make them use
23905 the same code path as everything else, fixes the casting issue
23906 with enumerations in Windows.Forms.
23908 * attribute.cs: Do only cast to string if it is a string, the
23909 validation happens later.
23911 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23912 people upgrade their corlibs.
23914 * ecore.cs: Oops, enumerations were not following the entire code path
23916 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23918 * typemanager.cs (FilterWithClosure): Commented out the test for
23919 1540 in typemanager.cs, as it has problems when accessing
23920 protected methods from a parent class (see test-174.cs).
23922 * attribute.cs (Attribute.ValidateGuid): new method.
23923 (Attribute.Resolve): Use above.
23925 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23927 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23929 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23930 handling for enumerations, as we only needed the TypeContainer
23931 functionality to begin with (this is required for the fix below to
23932 work for enums that reference constants in a container class for
23935 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23937 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23938 a valid TypeBuilder to perform lookups on.o
23940 * class.cs (InheritableMemberSignatureCompare): Use true in the
23941 call to GetGetMethod and GetSetMethod, because we are comparing
23942 the signature, and we need to get the methods *even* if they are
23945 (PropertyBase.CheckBase): ditto.
23947 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23948 GotoCase.Resolve): Use Peel on EmpytCasts.
23950 * ecore.cs (EmptyCast): drop child, add Peel method.
23952 2002-11-17 Martin Baulig <martin@ximian.com>
23954 * ecore.cs (EmptyCast.Child): New public property.
23956 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23957 label resolved to an EmptyCast. Fixes #34162.
23958 (GotoCase.Resolve): Likewise.
23959 (Block.EmitMeta): Likewise.
23961 2002-11-17 Martin Baulig <martin@ximian.com>
23963 * expression.cs (Invocation.BetterConversion): Prefer int over
23964 uint; short over ushort; long over ulong for integer literals.
23965 Use ImplicitConversionExists instead of StandardConversionExists
23966 since we also need to check for user-defined implicit conversions.
23967 Fixes #34165. Added test-173.cs.
23969 2002-11-16 Martin Baulig <martin@ximian.com>
23971 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23972 with the `true' and `false' literals. Fixes #33151.
23974 2002-11-16 Martin Baulig <martin@ximian.com>
23976 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23977 October 22nd; don't do the cs1540 check for static members.
23979 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23980 now using our own filter here and doing the cs1540 check again.
23982 2002-11-16 Martin Baulig <martin@ximian.com>
23984 * support.cs (InternalParameters): Don't crash if we don't have
23985 any fixed parameters. Fixes #33532.
23987 2002-11-16 Martin Baulig <martin@ximian.com>
23989 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23990 when looking up static methods to make this work on Windows.
23993 2002-11-16 Martin Baulig <martin@ximian.com>
23995 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23996 a setter rather than using PropertyInfo.CanWrite.
23998 2002-11-15 Nick Drochak <ndrochak@gol.com>
24000 * class.cs: Allow acces to block member by subclasses. Fixes build
24003 2002-11-14 Martin Baulig <martin@ximian.com>
24005 * class.cs (Constructor.Emit): Added the extern/block check.
24008 2002-11-14 Martin Baulig <martin@ximian.com>
24010 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
24011 iteration while looking for indexers, this is needed because the
24012 indexer may have a different name in our base classes. Fixed the
24013 error reporting (no indexers at all, not get accessor, no
24014 overloaded match). Fixes bug #33089.
24015 (IndexerAccess.DoResolveLValue): Likewise.
24017 2002-11-14 Martin Baulig <martin@ximian.com>
24019 * class.cs (PropertyBase.CheckBase): Make this work for multiple
24020 indexers. Fixes the first part of bug #33089.
24021 (MethodSignature.InheritableMemberSignatureCompare): Added support
24024 2002-11-13 Ravi Pratap <ravi@ximian.com>
24026 * attribute.cs (Attribute.Resolve): Catch the
24027 NullReferenceException and report it since it isn't supposed to
24030 2002-11-12 Miguel de Icaza <miguel@ximian.com>
24032 * expression.cs (Binary.EmitBranchable): Also handle the cases for
24033 LogicalOr and LogicalAnd that can benefit from recursively
24034 handling EmitBranchable. The code now should be nice for Paolo.
24036 2002-11-08 Miguel de Icaza <miguel@ximian.com>
24038 * typemanager.cs (LookupType): Added a negative-hit hashtable for
24039 the Type lookups, as we perform quite a number of lookups on
24040 non-Types. This can be removed once we can deterministically tell
24041 whether we have a type or a namespace in advance.
24043 But this might require special hacks from our corlib.
24047 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
24048 and double which avoids a conversion from an integer to a double.
24050 * expression.cs: tiny optimization, avoid calling IsConstant,
24051 because it effectively performs the lookup twice.
24053 2002-11-06 Miguel de Icaza <miguel@ximian.com>
24055 But a bogus return here to keep the semantics of the old code
24056 until the Mono runtime is fixed.
24058 * pending.cs (GetMissingInterfaces): New method used to remove all
24059 the interfaces that are already implemented by our parent
24060 classes from the list of pending methods.
24062 * interface.cs: Add checks for calls after ResolveTypeExpr.
24064 2002-11-05 Miguel de Icaza <miguel@ximian.com>
24066 * class.cs (Class.Emit): Report warning 67: event not used if the
24067 warning level is beyond 3.
24069 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
24070 being a NullLiteral.
24072 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
24075 * class.cs (TypeContainer.GetClassBases): Cover a missing code
24076 path that might fail if a type can not be resolved.
24078 * expression.cs (Binary.Emit): Emit unsigned versions of the
24081 * driver.cs: use error 5.
24083 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
24085 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
24087 2002-11-01 Miguel de Icaza <miguel@ximian.com>
24089 * cs-parser.jay (switch_section): A beautiful patch from Martin
24090 Baulig that fixed 33094.
24092 2002-10-31 Miguel de Icaza <miguel@ximian.com>
24094 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
24095 Check whether the base is abstract and report an error if so.
24097 * expression.cs (IndexerAccess.DoResolveLValue,
24098 IndexerAccess.DoResolve): ditto.
24100 (Invocation.DoResolve): ditto.
24102 (Invocation.FullMethodDesc): Improve the report string.
24104 * statement.cs (Block): Eliminate IsVariableDefined as it is
24105 basically just a wrapper for GetVariableInfo.
24107 * ecore.cs (SimpleName): Use new
24109 * support.cs (ReflectionParamter.ParameterType): We unwrap the
24110 type, as we return the actual parameter ref/unref state on a
24113 2002-10-30 Miguel de Icaza <miguel@ximian.com>
24115 * support.cs: Return proper flags REF/OUT fixing the previous
24118 * expression.cs: Reverted last patch, that was wrong. Is_ref is
24119 not used to mean `ref' but `ref or out' in ParameterReference
24121 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
24122 full type signature instead of calling TypeManger.CSharpName
24125 * support.cs (InternalParameters.ParameterDesc): Do not compare
24126 directly to the modflags, because REF/OUT will actually be bitsets
24129 * delegate.cs (VerifyMethod): Check also the modifiers.
24131 * cs-tokenizer.cs: Fix bug where floating point values with an
24132 exponent where a sign was missing was ignored.
24134 * driver.cs: Allow multiple assemblies to be specified in a single
24137 2002-10-28 Miguel de Icaza <miguel@ximian.com>
24139 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
24140 because identifiers after a parenthesis would end up in this kind
24141 of production, and we needed to desamiguate it for having casts
24144 (UserDefinedType *) xxx
24146 2002-10-24 Miguel de Icaza <miguel@ximian.com>
24148 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
24149 we should set on the Bindingflags.NonPublic, but not turn on
24150 private_ok. private_ok controls whether a Private member is
24151 returned (this is chekced on the filter routine), while the
24152 BindingFlags.NonPublic just controls whether private/protected
24153 will be allowed. This fixes the problem part of the problem of
24154 private properties being allowed to be used in derived classes.
24156 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
24157 so we can call the children DoResolveLValue method (this will
24158 properly signal errors on lvalue assignments to base properties)
24160 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
24161 getter are null, and we have a property info, we know that this
24162 happened because the lookup failed, so we report an error 122 for
24163 protection level violation.
24165 We also silently return if setter and getter are null in the
24166 resolve functions, this condition only happens if we have flagged
24167 the error before. This is the other half of the problem.
24169 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
24170 not have accessibility information, that is why we were returning
24171 true in the filter function in typemanager.cs.
24173 To properly report 122 (property is inaccessible because of its
24174 protection level) correctly, we report this error in ResolveAccess
24175 by failing if both the setter and the getter are lacking (ie, the
24178 DoResolve and DoLResolve have been modified to check for both
24179 setter/getter being null and returning silently, the reason being
24180 that I did not want to put the knowledge about this error in upper
24183 int old = Report.Errors;
24184 x = new PropertyExpr (...);
24185 if (old != Report.Errors)
24190 So the property expr is returned, but it is invalid, so the error
24191 will be flagged during the resolve process.
24193 * class.cs: Remove InheritablePropertySignatureCompare from the
24194 class, as we no longer depend on the property signature to compute
24195 whether it is possible to implement a method or not.
24197 The reason is that calling PropertyInfo.GetGetMethod will return
24198 null (in .NET, in Mono it works, and we should change this), in
24199 cases where the Get Method does not exist in that particular
24204 class X { public virtual int A { get { return 1; } } }
24206 class Z : Y { public override int A { get { return 2; } } }
24208 Would fail in Z because the parent (Y) would not have the property
24209 defined. So we avoid this completely now (because the alternative
24210 fix was ugly and slow), and we now depend exclusively on the
24213 (PropertyBase.CheckBase): Use a method-base mechanism to find our
24214 reference method, instead of using the property.
24216 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
24217 routines are gone now.
24219 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
24220 names, they were incorrectly named.
24222 * cs-tokenizer.cs: Return are more gentle token on failure.
24224 * pending.cs (PendingImplementation.InterfaceMethod): This routine
24225 had an out-of-sync index variable, which caused it to remove from
24226 the list of pending methods the wrong method sometimes.
24228 2002-10-22 Miguel de Icaza <miguel@ximian.com>
24230 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
24231 CanWrite, because those refer to this particular instance of the
24232 property, and do not take into account the fact that we can
24233 override single members of a property.
24235 Constructor requires an EmitContext. The resolution process does
24236 not happen here, but we need to compute the accessors before,
24237 because the resolution does not always happen for properties.
24239 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
24240 subclass, before we did not update this flag, but we did update
24243 (GetAccessors): Drop this routine, as it did not work in the
24244 presence of partially overwritten set/get methods.
24246 Notice that this broke the cs1540 detection, but that will require
24249 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24253 * driver.cs: issue a warning instead of an error if we don't support
24254 debugging for the platform. Also ignore a couple of errors that may
24255 arise when trying to write the symbols. Undo my previous patch.
24257 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24259 * driver.cs: ignore /debug switch except for Unix platforms.
24261 2002-10-23 Nick Drochak <ndrochak@gol.com>
24263 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24265 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24267 * driver.cs: Do not make mcs-debug conditional, so we do not break
24268 builds that use it.
24270 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24271 review this patch. But basically after all the children variables
24272 have been merged, the value of "Breaks" was not being set to
24273 new_breaks for Switch blocks. I think that it should be set after
24274 it has executed. Currently I set this to the value of new_breaks,
24275 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24276 conservative, but I do not understand this code very well.
24278 I did not break anything in the build, so that is good ;-)
24280 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24282 2002-10-20 Mark Crichton <crichton@gimp.org>
24284 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24286 2002-10-20 Nick Drochak <ndrochak@gol.com>
24288 * cfold.cs: Fixed compile blocker.
24290 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24292 * driver.cs: I was chekcing the key, not the file.
24294 2002-10-19 Ravi Pratap <ravi@ximian.com>
24296 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24297 message that we were generating - we just need to silently return
24300 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24302 * class.cs (Event.Define): Change my previous commit, as this
24303 breaks the debugger. This is a temporary hack, as it seems like
24304 the compiler is generating events incorrectly to begin with.
24306 * expression.cs (Binary.ResolveOperator): Added support for
24307 "U operator - (E x, E y)"
24309 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24312 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24313 init-only variables, but this path did not take into account that
24314 there might be also instance readonly variables. Correct this
24317 This fixes bug 32253
24319 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24322 * driver.cs: Change the extension for modules to `netmodule'
24324 * cs-parser.jay: Improved slightly the location tracking for
24325 the debugger symbols.
24327 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24328 modifiers that were specified instead of the hardcoded value
24329 (FamAndAssem). This was basically ignoring the static modifier,
24330 and others. Fixes 32429.
24332 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24333 fixed a bug in the process (32476)
24335 * expression.cs (ArrayAccess.EmitAssign): Patch from
24336 hwang_rob@yahoo.ca that fixes bug 31834.3
24338 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24340 * driver.cs: Make the module extension .netmodule.
24342 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24344 * driver.cs: Report an error if the resource file is not found
24345 instead of crashing.
24347 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24348 false, like Emit does.
24350 2002-10-16 Nick Drochak <ndrochak@gol.com>
24352 * typemanager.cs: Remove unused private member. Also reported mcs
24353 bug to report this as a warning like csc.
24355 2002-10-15 Martin Baulig <martin@gnome.org>
24357 * statement.cs (Statement.Emit): Made this a virtual method; emits
24358 the line number info and calls DoEmit().
24359 (Statement.DoEmit): New protected abstract method, formerly knows
24360 as Statement.Emit().
24362 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24364 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24366 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24367 have fixed a remaining problem: not every AddXXXX was adding a
24368 fully qualified name.
24370 Now everyone registers a fully qualified name in the DeclSpace as
24371 being defined instead of the partial name.
24373 Downsides: we are slower than we need to be due to the excess
24374 copies and the names being registered this way.
24376 The reason for this is that we currently depend (on the corlib
24377 bootstrap for instance) that types are fully qualified, because
24378 we dump all the types in the namespace, and we should really have
24379 types inserted into the proper namespace, so we can only store the
24380 basenames in the defined_names array.
24382 2002-10-10 Martin Baulig <martin@gnome.org>
24384 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24385 from bug #31834, see the bug report for a testcase which is
24388 2002-10-10 Martin Baulig <martin@gnome.org>
24390 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24391 flow analysis code for this.
24393 * statement.cs (Do, While, For): Tell the flow analysis code about
24395 (FlowBranching.UsageVector): Added support for infinite loops.
24396 (Block.Resolve): Moved the dead code elimination here and use flow
24399 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24401 * class.cs (Field.Define): Catch cycles on struct type
24404 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24405 fields if the fields are static. We only need to check instance
24408 * expression.cs (As.DoResolve): Test for reference type.
24410 * statement.cs (Using.ResolveExpression): Use
24411 ConvertImplicitRequired, not ConvertImplicit which reports an
24413 (Using.ResolveLocalVariableDecls): ditto.
24415 * expression.cs (Binary.ResolveOperator): Report errors in a few
24416 places where we had to.
24418 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24420 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24422 * expression.cs: Use StoreFromPtr instead of extracting the type
24423 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24425 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24426 an enumeration value to a System.Enum, but System.Enum is not a
24427 value type, but an class type, so we need to box.
24429 (Expression.ConvertExplicit): One codepath could return
24430 errors but not flag them. Fix this. Fixes #31853
24432 * parameter.cs (Resolve): Do not allow void as a parameter type.
24434 2002-10-06 Martin Baulig <martin@gnome.org>
24436 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24437 if it's a class type and not a struct. Fixes #31815.
24439 2002-10-06 Martin Baulig <martin@gnome.org>
24441 * statement.cs: Reworked the flow analysis code a bit to make it
24442 usable for dead code elimination.
24444 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24446 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24448 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24450 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24451 to fix the test 165, will investigate deeper.
24453 2002-10-04 Martin Baulig <martin@gnome.org>
24455 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24456 finally blocks actually work.
24457 (Try.Resolve): We don't need to create a sibling for `finally' if
24458 there is no finally block.
24460 2002-10-04 Martin Baulig <martin@gnome.org>
24462 * class.cs (Constructor.Define): The default accessibility for a
24463 non-default constructor is private, not public.
24465 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24467 * class.cs (Constructor): Make AllowedModifiers public, add
24470 * cs-parser.jay: Perform the modifiers test here, as the
24471 constructor for the Constructor class usually receives a zero
24472 because of the way we create it (first we create, later we
24473 customize, and we were never checking the modifiers).
24475 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24476 is a version of LookupTypeReflection that includes the type-name
24477 cache. This can be used as a fast path for functions that know
24478 the fully qualified name and are only calling into *.GetType() to
24479 obtain a composed type.
24481 This is also used by TypeManager.LookupType during its type
24484 (LookupType): We now also track the real type name, as sometimes
24485 we can get a quey for the real type name from things like
24486 ComposedCast. This fixes bug 31422.
24488 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24489 complete type fullname, it does not have to go through the type
24490 resolution system to obtain the composed version of the type (for
24491 obtaining arrays or pointers).
24493 (Conditional.Emit): Use the EmitBoolExpression to
24494 generate nicer code, as requested by Paolo.
24496 (ArrayCreation.CheckIndices): Use the patch from
24497 hwang_rob@yahoo.ca to validate the array initializers.
24499 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24501 * class.cs (ConstructorInitializer.Emit): simplify code by using
24502 Invocation.EmitCall, and at the same time, fix the bugs in calling
24503 parent constructors that took variable arguments.
24505 * ecore.cs (Expression.ConvertNumericExplicit,
24506 Expression.ImplicitNumericConversion): Remove the code that
24507 manually wrapped decimal (InternalTypeConstructor call is now gone
24510 * expression.cs (Cast.TryReduce): Also handle decimal types when
24511 trying to perform a constant fold on the type.
24513 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24515 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24516 that only turned off an error report, and did nothing else.
24518 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24520 * driver.cs: Handle and ignore /fullpaths
24522 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24524 * expression.cs (Binary.ResolveOperator): Catch the case where
24525 DoNumericPromotions returns true,
24527 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24529 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24531 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24534 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24536 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24537 conversion exists, but it is also required that the conversion be
24538 performed. This manifested in "(Type64Enum) 2".
24540 * class.cs (TypeManager.AddMethod): The fix is not to change
24541 AddEnum, because that one was using a fully qualified name (every
24542 DeclSpace derivative does), but to change the AddMethod routine
24543 that was using an un-namespaced name. This now correctly reports
24544 the duplicated name.
24546 Revert patch until I can properly fix it. The issue
24547 is that we have a shared Type space across all namespaces
24548 currently, which is wrong.
24550 Options include making the Namespace a DeclSpace, and merge
24551 current_namespace/current_container in the parser.
24553 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24555 * cs-parser.jay: Improve error reporting when we get a different
24556 kind of expression in local_variable_type and
24557 local_variable_pointer_type.
24559 Propagate this to avoid missleading errors being reported.
24561 * ecore.cs (ImplicitReferenceConversion): treat
24562 TypeManager.value_type as a target just like object_type. As
24567 Is valid, and needs to result in the int 1 being boxed before it
24568 is assigned to the value type v.
24570 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24571 to validate the enumeration name.
24573 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24574 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24575 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24577 * ecore.cs (TryImplicitIntConversion): When doing an
24578 implicit-enumeration-conversion, check if the type is 64-bits and
24579 perform a conversion before passing to EnumConstant.
24581 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24583 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24584 report ambiguous type references. Unlike the MS version, we
24585 report what the ambiguity is. Innovation at work ;-)
24587 (DeclSpace.FindType): Require a location argument to
24588 display when we display an ambiguous error.
24590 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24592 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24594 * expression.cs (EmitDynamicInitializers): Apply patch from
24595 hwang_rob@yahoo.ca that fixes the order in which we emit our
24598 2002-09-21 Martin Baulig <martin@gnome.org>
24600 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24601 delegate takes no arguments.
24603 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24605 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24608 * expression.cs: Extract the underlying type.
24610 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24612 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24614 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24616 * class.cs (TypeContainer.DefineType): We can not use the nice
24617 PackingSize with the size set to 1 DefineType method, because it
24618 will not allow us to define the interfaces that the struct
24621 This completes the fixing of bug 27287
24623 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24624 means also structs. This fixes part of the problem.
24625 (Expresion.ImplicitReferenceConversionExists): ditto.
24627 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24628 error if there were no errors reported during the type lookup
24629 process, to avoid duplicates or redundant errors. Without this
24630 you would get an ambiguous errors plus a type not found. We have
24631 beaten the user enough with the first error.
24633 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24636 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24637 during the resolution process, stop the lookup, this avoids
24638 repeated error reports (same error twice).
24640 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24642 * typemanager.cs (LookupType): Redo the type lookup code to match
24643 the needs of System.Reflection.
24645 The issue is that System.Reflection requires references to nested
24646 types to begin with a "+" sign instead of a dot. So toplevel
24647 types look like: "NameSpace.TopLevelClass", and nested ones look
24648 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24651 2002-09-19 Martin Baulig <martin@gnome.org>
24653 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24654 says that a method always returns or always throws an exception,
24655 don't report the CS0161.
24657 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24658 set `Returns = new_returns'.
24660 2002-09-19 Martin Baulig <martin@gnome.org>
24662 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24663 to an enum constant, check for a CS0176.
24665 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24667 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24668 for operators that must be in pairs and report errors.
24670 * ecore.cs (SimpleName.DoResolveType): During the initial type
24671 resolution process, when we define types recursively, we must
24672 check first for types in our current scope before we perform
24673 lookups in the enclosing scopes.
24675 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24677 (Invocation.VerifyArgumentsCompat): Call
24678 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24679 I thought we were supposed to always call this, but there are a
24680 few places in the code where we dont do it.
24682 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24684 * driver.cs: Add support in -linkres and -resource to specify the
24685 name of the identifier.
24687 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24689 * ecore.cs (StandardConversionExists): Sync with the conversion
24690 code: allow anything-* to void* conversions.
24692 (FindMostSpecificSource): Use an Expression argument
24693 instead of a Type, because we might be handed over a Literal which
24694 gets a few more implicit conversions that plain types do not. So
24695 this information was being lost.
24697 Also, we drop the temporary type-holder expression when not
24700 2002-09-17 Martin Baulig <martin@gnome.org>
24702 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24703 this is an explicit interface implementation.
24705 2002-09-17 Martin Baulig <martin@gnome.org>
24707 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24708 different `IndexerName' attributes.
24710 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24711 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24712 virtual CommonResolve().
24714 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24716 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24717 and convert that to the UnderlyingType.
24719 * statement.cs (Foreach.Resolve): Indexers are just like variables
24720 or PropertyAccesses.
24722 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24723 inside quoted strings, we were not doing this before.
24725 2002-09-16 Martin Baulig <martin@gnome.org>
24727 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24728 resolve it. This is needed for the definite assignment check of the
24729 instance expression, fixes bug #29846.
24730 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24732 2002-09-16 Nick Drochak <ndrochak@gol.com>
24734 * parameter.cs: Fix compile error. Cannot reference static member
24735 from an instance object. Is this an mcs bug?
24737 2002-09-14 Martin Baulig <martin@gnome.org>
24739 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24740 multiple times. Fixes bug #30295, added test-166.cs.
24742 2002-09-14 Martin Baulig <martin@gnome.org>
24744 * statement.cs (Block.Emit): Don't emit unreachable code.
24745 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24746 `break' statements.
24747 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24749 2002-09-14 Martin Baulig <martin@gnome.org>
24751 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24754 2002-09-14 Martin Baulig <martin@gnome.org>
24756 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24757 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24758 be false on the ms runtime.
24760 2002-09-13 Martin Baulig <martin@gnome.org>
24762 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24763 the CS0038 error message.
24765 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24767 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24768 constant inside, return it.
24770 2002-09-12 Martin Baulig <martin@gnome.org>
24772 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24773 implicit conversion can be done between enum types.
24775 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24776 check whether an implicit conversion to the current enum's UnderlyingType
24777 exists and report an error if not.
24779 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24780 without debugging support.
24782 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24783 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24785 2002-09-12 Martin Baulig <martin@gnome.org>
24787 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24789 * ecore.cs (IMemberExpr.DeclaringType): New property.
24790 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24791 nonstatic member of an outer type (CS0038).
24793 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24795 * driver.cs: Activate the using-error detector at warning level
24796 4 (at least for MS-compatible APIs).
24798 * namespace.cs (VerifyUsing): Small buglett fix.
24800 * pending.cs (PendingImplementation): pass the container pointer.
24802 * interface.cs (GetMethods): Allow for recursive definition. Long
24803 term, I would like to move every type to support recursive
24804 definitions, not the current ordering mechanism that we have right
24807 The situation is this: Attributes are handled before interfaces,
24808 so we can apply attributes to interfaces. But some attributes
24809 implement interfaces, we will now handle the simple cases
24810 (recursive definitions will just get an error).
24812 * parameter.cs: Only invalidate types at the end if we fail to
24815 2002-09-09 Martin Baulig <martin@gnome.org>
24817 * ecore.cs (PropertyExpr.Emit): Also check for
24818 TypeManager.system_int_array_get_length so this'll also work when
24819 compiling corlib. Fixes #30003.
24821 2002-09-09 Martin Baulig <martin@gnome.org>
24823 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24824 and throw an exception if we can't get the type's size. Fixed #30040,
24827 2002-09-09 Martin Baulig <martin@gnome.org>
24829 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24831 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24832 context. Fixes bug #30027.
24834 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24835 virtual functions. Fixes bug #30043, added test-164.cs.
24837 2002-09-08 Ravi Pratap <ravi@ximian.com>
24839 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24841 2002-09-08 Nick Drochak <ndrochak@gol.com>
24843 * driver.cs: Use an object to get the windows codepage since it's not a
24846 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24848 * statement.cs (For.Emit): for infinite loops (test == null)
24849 return whether there is a break inside, not always "true".
24851 * namespace.cs (UsingEntry): New struct to hold the name of the
24852 using definition, the location where it is defined, and whether it
24853 has been used in a successful type lookup.
24855 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24860 2002-09-06 Ravi Pratap <ravi@ximian.com>
24862 * attribute.cs : Fix incorrect code which relied on catching
24863 a NullReferenceException to detect a null being passed in
24864 where an object was expected.
24866 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24868 * statement.cs (Try): flag the catch variable as assigned
24870 * expression.cs (Cast): Simplified by using ResolveType instead of
24871 manually resolving.
24873 * statement.cs (Catch): Fix bug by using ResolveType.
24875 2002-09-06 Ravi Pratap <ravi@ximian.com>
24877 * expression.cs (BetterConversion): Special case for when we have
24878 a NullLiteral as the argument and we have to choose between string
24879 and object types - we choose string the way csc does.
24881 * attribute.cs (Attribute.Resolve): Catch the
24882 NullReferenceException and report error #182 since the Mono
24883 runtime no more has the bug and having this exception raised means
24884 we tried to select a constructor which takes an object and is
24887 2002-09-05 Ravi Pratap <ravi@ximian.com>
24889 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24890 message (1502, 1503) when we can't locate a method after overload
24891 resolution. This is much more informative and closes the bug
24894 * interface.cs (PopulateMethod): Return if there are no argument
24895 types. Fixes a NullReferenceException bug.
24897 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24898 expressions too. Previously we were checking only in one place for
24899 positional arguments leaving out named arguments.
24901 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24902 type to the enum type is not allowed. Remove code corresponding to
24905 (ConvertNumericExplicit): Allow explicit conversions from
24906 the underlying type to enum type. This precisely follows the spec
24907 and closes a bug filed by Gonzalo.
24909 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24912 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24914 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24916 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24917 it was important that we stored the right value after the
24918 reduction in `converted'.
24920 2002-09-04 Martin Baulig <martin@gnome.org>
24922 * location.cs (Location.SymbolDocument): Use full pathnames for the
24925 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24927 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24928 of the expression resolve mechanism, because that will catch the
24929 SimpleName error failures.
24931 (Conditional): If we can not resolve the
24932 expression, return, do not crash.
24934 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24937 (location): display token name instead of its number.
24939 2002-08-28 Martin Baulig <martin@gnome.org>
24941 * expression.cs (Binary.ResolveOperator): Don't silently return
24942 but return an error if an operator cannot be applied between two
24945 2002-08-28 Martin Baulig <martin@gnome.org>
24947 * class.cs (Constructor.Define): Set the permission attributes
24948 correctly instead of making all constructors public.
24950 2002-08-28 Martin Baulig <martin@gnome.org>
24952 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24953 for private members before reporting a CS0103; if we find anything,
24956 2002-08-28 Martin Baulig <martin@gnome.org>
24958 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24959 to check whether `closure_start_type == closure_invocation_type',
24960 we also need to check whether `m.DeclaringType == closure_invocation_type'
24961 before bypassing the permission checks. We might be accessing
24962 protected/private members from the base class.
24963 (TypeManager.RealMemberLookup): Only set private_ok if private
24964 members were requested via BindingFlags.NonPublic.
24966 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24968 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24969 MethodGroupExpr.IsExplicitImpl if appropriate.
24970 (Invocation.DoResolve): Don't report the CS0120 for explicit
24971 interface implementations.
24973 2002-08-27 Martin Baulig <martin@gnome.org>
24975 * expression.cs (Invocation.DoResolve): If this is a static
24976 method and we don't have an InstanceExpression, we must report
24979 2002-08-25 Martin Baulig <martin@gnome.org>
24981 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24982 `==' between a valuetype and an object.
24984 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24986 * ecore.cs (TypeExpr): Provide a ToString method.
24988 2002-08-24 Martin Baulig <martin@gnome.org>
24990 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24991 now called proggie.dbg and it's a binary file.
24993 2002-08-23 Martin Baulig <martin@gnome.org>
24995 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24997 2002-08-23 Martin Baulig <martin@gnome.org>
24999 * struct.cs (MyStructInfo.ctor): Make this work with empty
25000 structs; it's not allowed to use foreach() on null.
25002 2002-08-23 Martin Baulig <martin@gnome.org>
25004 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
25005 writer the full pathname of the generated assembly.
25007 2002-08-23 Martin Baulig <martin@gnome.org>
25009 * statements.cs (FlowBranching.UsageVector.MergeChildren):
25010 A `finally' block never returns or breaks; improved handling of
25013 2002-08-23 Martin Baulig <martin@gnome.org>
25015 * statement.cs (Throw.Resolve): Allow `throw null'.
25017 2002-08-23 Martin Baulig <martin@gnome.org>
25019 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
25020 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
25021 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
25022 MemberLookup would return a wrong event if this is an explicit
25023 interface implementation and the class has an event with the same
25026 2002-08-23 Martin Baulig <martin@gnome.org>
25028 * statement.cs (Block.AddChildVariableNames): New public method.
25029 (Block.AddChildVariableName): Likewise.
25030 (Block.IsVariableNameUsedInChildBlock): Likewise.
25031 (Block.AddVariable): Check whether a variable name has already
25032 been used in a child block.
25034 * cs-parser.jay (declare_local_variables): Mark all variable names
25035 from the current block as being used in a child block in the
25038 2002-08-23 Martin Baulig <martin@gnome.org>
25040 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
25041 find the symbol writer.
25043 * driver.cs: csc also allows the arguments to /define being
25044 separated by commas, not only by semicolons.
25046 2002-08-23 Martin Baulig <martin@gnome.org>
25048 * interface.cs (Interface.GetMembers): Added static check for events.
25050 2002-08-15 Martin Baulig <martin@gnome.org>
25052 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
25053 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
25055 * ecore.cs (Expression.MemberLookup): Added documentation and explained
25056 why the MethodData.EmitDestructor() change was necessary.
25058 2002-08-20 Martin Baulig <martin@gnome.org>
25060 * class.cs (TypeContainer.FindMembers): Added static check for events.
25062 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
25064 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
25065 use Type.GetEvents(), not Type.FindMembers().
25067 2002-08-20 Martin Baulig <martin@gnome.org>
25069 * decl.cs (MemberCache): Added a special method cache which will
25070 be used for method-only searched. This ensures that a method
25071 search will return a MethodInfo with the correct ReflectedType for
25074 2002-08-20 Martin Baulig <martin@gnome.org>
25076 * decl.cs (DeclSpace.FindMembers): Made this public.
25078 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25080 * delegate.cs: fixed build on windows.
25081 [FIXME: Filed as bug #29150: MCS must report these errors.]
25083 2002-08-19 Ravi Pratap <ravi@ximian.com>
25085 * ecore.cs (StandardConversionExists): Return a false
25086 if we are trying to convert the void type to anything else
25087 since that is not allowed.
25089 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
25090 we flag error 70 in the event an event is trying to be accessed
25091 directly from outside the declaring type.
25093 2002-08-20 Martin Baulig <martin@gnome.org>
25095 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
25096 MemberCache from typemanager.cs to decl.cs.
25098 2002-08-19 Martin Baulig <martin@gnome.org>
25100 * class.cs (TypeContainer): Implement IMemberContainer.
25101 (TypeContainer.DefineMembers): Create the MemberCache.
25102 (TypeContainer.FindMembers): Do better BindingFlags checking; only
25103 return public members if BindingFlags.Public was given, check
25104 whether members are static.
25106 2002-08-16 Martin Baulig <martin@gnome.org>
25108 * decl.cs (DeclSpace.Define): Splitted this in Define and
25109 DefineMembers. DefineMembers is called first and initializes the
25112 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
25113 DefineMembers() on all our DeclSpaces.
25115 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
25116 but call DefineMembers() on all nested interfaces. We call their
25117 Define() in our new Define() function.
25119 * interface.cs (Interface): Implement IMemberContainer.
25120 (Interface.Define): Moved all code except the attribute stuf to
25122 (Interface.DefineMembers): Initialize the member cache.
25124 * typemanager.cs (IMemberFinder): Removed this interface, we don't
25125 need this anymore since we can use MemberCache.FindMembers directly.
25127 2002-08-19 Martin Baulig <martin@gnome.org>
25129 * typemanager.cs (MemberCache): When creating the cache for an
25130 interface type, add all inherited members.
25131 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
25132 to `out bool used_cache' and documented it.
25133 (TypeManager.MemberLookup): If we already used the cache in the first
25134 iteration, we don't need to do the interfaces check.
25136 2002-08-19 Martin Baulig <martin@gnome.org>
25138 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
25139 here from IMemberFinder and don't implement this interface anymore.
25140 (DeclSpace.MemberCache): Moved here from IMemberFinder.
25142 * typemanager.cs (IMemberFinder): This interface is now only used by
25143 classes which actually support the member cache.
25144 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
25145 since we only put DeclSpaces into this Hashtable.
25146 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
25147 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
25149 2002-08-16 Martin Baulig <martin@gnome.org>
25151 * typemanager.cs (ICachingMemberFinder): Removed.
25152 (IMemberFinder.MemberCache): New property.
25153 (TypeManager.FindMembers): Merged this with RealFindMembers().
25154 This function will never be called from TypeManager.MemberLookup()
25155 so we can't use the cache here, just the IMemberFinder.
25156 (TypeManager.MemberLookup_FindMembers): Check whether the
25157 IMemberFinder has a MemberCache and call the cache's FindMembers
25159 (MemberCache): Rewrote larger parts of this yet another time and
25160 cleaned it up a bit.
25162 2002-08-15 Miguel de Icaza <miguel@ximian.com>
25164 * driver.cs (LoadArgs): Support quoting.
25166 (Usage): Show the CSC-like command line arguments.
25168 Improved a few error messages.
25170 2002-08-15 Martin Baulig <martin@gnome.org>
25172 * typemanager.cs (IMemberContainer.Type): New property.
25173 (IMemberContainer.IsInterface): New property.
25175 The following changes are conditional to BROKEN_RUNTIME, which is
25176 defined at the top of the file.
25178 * typemanager.cs (MemberCache.MemberCache): Don't add the base
25179 class'es members, but add all members from TypeHandle.ObjectType
25180 if we're an interface.
25181 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
25182 is the current type.
25183 (MemberCache.CacheEntry.Container): Removed this field.
25184 (TypeHandle.GetMembers): Include inherited members.
25186 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25188 * typemanager.cs: fixed compilation and added a comment on a field that
25191 2002-08-15 Martin Baulig <martin@gnome.org>
25193 * class.cs (ConstructorInitializer.Resolve): In the
25194 Expression.MemberLookup call, use the queried_type as
25197 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
25198 declared' attribute, it's always true.
25199 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
25200 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
25201 temporary wrapper for FindMembers which tells MemberLookup whether
25202 members from the base classes are included in the return value.
25203 This will go away soon.
25204 (TypeManager.MemberLookup): Use this temporary hack here; once the
25205 new MemberCache is completed, we don't need to do the DeclaredOnly
25206 looping here anymore since the MemberCache will take care of this.
25207 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
25208 (MemberCache): When creating the MemberCache for a class, get
25209 members from the current class and all its base classes.
25210 (MemberCache.CacheEntry.Container): New field. This is a
25211 temporary hack until the Mono runtime is fixed to distinguish
25212 between ReflectedType and DeclaringType. It allows us to use MCS
25213 with both the MS runtime and the unfixed Mono runtime without
25214 problems and without accecting performance.
25215 (MemberCache.SearchMembers): The DeclaredOnly looping from
25216 TypeManager.MemberLookup is now done here.
25218 2002-08-14 Martin Baulig <martin@gnome.org>
25220 * statement.cs (MyStructInfo.MyStructInfo): Don't call
25221 Type.GetFields on dynamic types but get the fields from the
25222 corresponding TypeContainer.
25223 (MyStructInfo.GetStructInfo): Added check for enum types.
25225 * typemanager.cs (MemberList.IsSynchronized): Implemented.
25226 (MemberList.SyncRoot): Implemented.
25227 (TypeManager.FilterWithClosure): No need to check permissions if
25228 closure_start_type == closure_invocation_type, don't crash if
25229 closure_invocation_type is null.
25231 2002-08-13 Martin Baulig <martin@gnome.org>
25233 Rewrote TypeContainer.FindMembers to use a member cache. This
25234 gives us a speed increase of about 35% for the self-hosting MCS
25235 build and of about 15-20% for the class libs (both on GNU/Linux).
25237 * report.cs (Timer): New class to get enhanced profiling. This
25238 whole class is "TIMER" conditional since it remarkably slows down
25241 * class.cs (MemberList): New class. This is an IList wrapper
25242 which we're now using instead of passing MemberInfo[]'s around to
25243 avoid copying this array unnecessarily.
25244 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
25245 (ICachingMemberFinder, IMemberContainer): New interface.
25246 (TypeManager.FilterWithClosure): If `criteria' is null, the name
25247 has already been checked, otherwise use it for the name comparision.
25248 (TypeManager.FindMembers): Renamed to RealMemberFinder and
25249 provided wrapper which tries to use ICachingMemberFinder.FindMembers
25250 if possible. Returns a MemberList, not a MemberInfo [].
25251 (TypeHandle): New class, implements IMemberContainer. We create
25252 one instance of this class per type, it contains a MemberCache
25253 which is used to do the member lookups.
25254 (MemberCache): New class. Each instance of this class contains
25255 all members of a type and a name-based hash table.
25256 (MemberCache.FindMembers): This is our new member lookup
25257 function. First, it looks up all members of the requested name in
25258 the hash table. Then, it walks this list and sorts out all
25259 applicable members and returns them.
25261 2002-08-13 Martin Baulig <martin@gnome.org>
25263 In addition to a nice code cleanup, this gives us a performance
25264 increase of about 1.4% on GNU/Linux - not much, but it's already
25265 half a second for the self-hosting MCS compilation.
25267 * typemanager.cs (IMemberFinder): New interface. It is used by
25268 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25269 Enum, Delegate or Interface.
25270 (TypeManager.finder_to_member_finder): New PtrHashtable.
25271 (TypeManager.finder_to_container): Removed.
25272 (TypeManager.finder_to_delegate): Removed.
25273 (TypeManager.finder_to_interface): Removed.
25274 (TypeManager.finder_to_enum): Removed.
25276 * interface.cs (Interface): Implement IMemberFinder.
25278 * delegate.cs (Delegate): Implement IMemberFinder.
25280 * enum.cs (Enum): Implement IMemberFinder.
25282 * class.cs (TypeContainer): Implement IMemberFinder.
25284 2002-08-12 Martin Baulig <martin@gnome.org>
25286 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25288 2002-08-12 Martin Baulig <martin@gnome.org>
25290 * ecore.cs (ITypeExpression): New interface for expressions which
25292 (TypeExpression): Renamed to TypeLookupExpression.
25293 (Expression.DoResolve): If we're doing a types-only lookup, the
25294 expression must implement the ITypeExpression interface and we
25295 call DoResolveType() on it.
25296 (SimpleName): Implement the new ITypeExpression interface.
25297 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25298 hack, the situation that we're only looking up types can't happen
25299 anymore when this method is called. Moved the type lookup code to
25300 DoResolveType() and call it.
25301 (SimpleName.DoResolveType): This ITypeExpression interface method
25302 is now doing the types-only lookup.
25303 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25304 (ResolveFlags): Added MaskExprClass.
25306 * expression.cs (MemberAccess): Implement the ITypeExpression
25308 (MemberAccess.DoResolve): Added support for a types-only lookup
25309 when we're called via ITypeExpression.DoResolveType().
25310 (ComposedCast): Implement the ITypeExpression interface.
25312 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25313 Expression.Resolve() with ResolveFlags.Type instead.
25315 2002-08-12 Martin Baulig <martin@gnome.org>
25317 * interface.cs (Interface.Define): Apply attributes.
25319 * attribute.cs (Attribute.ApplyAttributes): Added support for
25320 interface attributes.
25322 2002-08-11 Martin Baulig <martin@gnome.org>
25324 * statement.cs (Block.Emit): Only check the "this" variable if we
25325 do not always throw an exception.
25327 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25328 whether the property has a set accessor.
25330 2002-08-11 Martin Baulig <martin@gnome.org>
25332 Added control flow analysis support for structs.
25334 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25335 with control flow analysis turned off.
25336 (IVariable): New interface.
25337 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25338 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25339 (FieldExpr.DoResolve): Resolve the instance expression with flow
25340 analysis turned off and do the definite assignment check after the
25341 resolving when we know what the expression will resolve to.
25343 * expression.cs (LocalVariableReference, ParameterReference):
25344 Implement the new IVariable interface, only call the flow analysis
25345 code if ec.DoFlowAnalysis is true.
25346 (This): Added constructor which takes a Block argument. Implement
25347 the new IVariable interface.
25348 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25349 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25350 This does the definite assignment checks for struct members.
25352 * class.cs (Constructor.Emit): If this is a non-static `struct'
25353 constructor which doesn't have any initializer, call
25354 Block.AddThisVariable() to tell the flow analysis code that all
25355 struct elements must be initialized before control returns from
25358 * statement.cs (MyStructInfo): New public class.
25359 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25360 argument to this indexer. If non-zero, check an individual struct
25361 member, not the whole struct.
25362 (FlowBranching.CheckOutParameters): Check struct members.
25363 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25364 overloaded versions of these methods which take an additional
25365 `int field_idx' argument to check struct members.
25366 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25367 overloaded versions of these methods which take an additional
25368 `string field_name' argument to check struct member.s
25369 (VariableInfo): Implement the IVariable interface.
25370 (VariableInfo.StructInfo): New public property. Returns the
25371 MyStructInfo instance of the variable if it's a struct or null.
25372 (Block.AddThisVariable): New public method. This is called from
25373 Constructor.Emit() for non-static `struct' constructor which do
25374 not have any initializer. It creates a special variable for the
25375 "this" instance variable which will be checked by the flow
25376 analysis code to ensure that all of the struct's fields are
25377 initialized before control returns from the constructor.
25378 (UsageVector): Added support for struct members. If a
25379 variable/parameter is a struct with N members, we reserve a slot
25380 in the usage vector for each member. A struct is considered fully
25381 initialized if either the struct itself (slot 0) or all its
25382 members are initialized.
25384 2002-08-08 Martin Baulig <martin@gnome.org>
25386 * driver.cs (Driver.MainDriver): Only report an error CS5001
25387 if there were no compilation errors.
25389 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25390 `UnsafeContext' property to determine whether the parent is in
25391 unsafe context rather than checking the parent's ModFlags:
25392 classes nested in an unsafe class are unsafe as well.
25394 2002-08-08 Martin Baulig <martin@gnome.org>
25396 * statement.cs (UsageVector.MergeChildren): Distinguish between
25397 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25398 we return. Added test17() and test18() to test-154.cs.
25400 2002-08-08 Martin Baulig <martin@gnome.org>
25402 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25403 Family access, make sure the invoking type isn't a subclass of the
25404 queried type (that'd be a CS1540).
25406 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25407 this method which takes an additional `Type invocation_type'.
25409 * expression.cs (BaseAccess.DoResolve): Use the base type as
25410 invocation and query type.
25411 (MemberAccess.DoResolve): If the lookup failed and we're about to
25412 report a CS0122, try a lookup with the ec.ContainerType - if this
25413 succeeds, we must report a CS1540.
25415 2002-08-08 Martin Baulig <martin@gnome.org>
25417 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25418 (MethodGroupExpr): Implement the IMemberExpr interface.
25420 * expression (MemberAccess.ResolveMemberAccess): No need to have
25421 any special code for MethodGroupExprs anymore, they're now
25424 2002-08-08 Martin Baulig <martin@gnome.org>
25426 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25427 Family, FamANDAssem and FamORAssem permissions.
25428 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25430 2002-08-08 Martin Baulig <martin@gnome.org>
25432 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25433 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25436 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25438 * driver.cs: implemented /resource option to embed managed resources.
25440 2002-08-07 Martin Baulig <martin@gnome.org>
25442 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25443 (FieldBase.HasFieldInitializer): New public property.
25444 (FieldBase.GetInitializerExpression): New public method. Resolves and
25445 returns the field initializer and makes sure it is only resolved once.
25446 (TypeContainer.EmitFieldInitializers): Call
25447 FieldBase.GetInitializerExpression to get the initializer, this ensures
25448 that it isn't resolved multiple times.
25450 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25451 the resolving process (SimpleName/MemberLookup) that we're currently
25452 emitting a field initializer (which must not access any instance members,
25453 this is an error CS0236).
25455 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25456 argument, if the `IsFieldInitializer' flag is set, we must report and
25457 error CS0236 and not an error CS0120.
25459 2002-08-07 Martin Baulig <martin@gnome.org>
25461 * ecore.cs (IMemberExpr): New public interface.
25462 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25463 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25464 if the expression is an IMemberExpr.
25466 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25467 to be null, implicitly default to `this' if we're non-static in
25468 this case. Simplified the code a lot by using the new IMemberExpr
25469 interface. Also fixed bug #28176 here.
25471 2002-08-06 Martin Baulig <martin@gnome.org>
25473 * cs-parser.jay (SimpleLookup): Removed. We need to create
25474 ParameterReferences during semantic analysis so that we can do a
25475 type-only search when resolving Cast, TypeOf and SizeOf.
25476 (block): Pass the `current_local_parameters' to the Block's
25479 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25480 argument to the constructor.
25481 (ConstructorInitializer.Resolve): Create a temporary implicit
25482 block with the parameters.
25484 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25485 references here if we aren't doing a type-only search.
25487 * statement.cs (Block): Added constructor which takes a
25488 `Parameters parameters' argument.
25489 (Block.Parameters): New public property.
25491 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25492 to `Parameters' and made it public readonly.
25494 2002-08-06 Martin Baulig <martin@gnome.org>
25496 * ecore.cs (Expression.Warning): Made this public as well.
25498 * report.cs (Report.Debug): Print the contents of collections.
25500 2002-08-06 Martin Baulig <martin@gnome.org>
25502 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25503 used to tell Resolve() which kinds of expressions it may return.
25504 (Expression.Resolve): Added overloaded version of this method which
25505 takes a `ResolveFlags flags' argument. This can be used to tell
25506 Resolve() which kinds of expressions it may return. Reports a
25508 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25509 ResolveFlags.SimpleName.
25510 (Expression.Error118): Added overloaded version of this method which
25511 takes a `ResolveFlags flags' argument. It uses the flags to determine
25512 which kinds of expressions are allowed.
25514 * expression.cs (Argument.ResolveMethodGroup): New public method.
25515 Resolves an argument, but allows a MethodGroup to be returned.
25516 This is used when invoking a delegate.
25518 * TODO: Updated a bit.
25520 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25522 Fixed compilation with csc.
25524 * ecore.cs: Expression.Error made public. Is this correct? Should
25525 Warning be made public too?
25527 * expression.cs: use ea.Location instead of ea.loc.
25528 [FIXME: Filed as bug #28607: MCS must report these errors.]
25530 2002-08-06 Martin Baulig <martin@gnome.org>
25532 * ecore.cs (Expression.loc): Moved the location here instead of
25533 duplicating it in all derived classes.
25534 (Expression.Location): New public property.
25535 (Expression.Error, Expression.Warning): Made them non-static and
25536 removed the location argument.
25537 (Expression.Warning): Added overloaded version which takes an
25538 `int level' argument.
25539 (Expression.Error118): Make this non-static and removed the
25540 expression and location arguments.
25541 (TypeExpr): Added location argument to the constructor.
25543 * expression.cs (StaticCallExpr): Added location argument to
25545 (Indirection, PointerArithmetic): Likewise.
25546 (CheckedExpr, UnCheckedExpr): Likewise.
25547 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25548 (StringPtr): Likewise.
25551 2002-08-05 Martin Baulig <martin@gnome.org>
25553 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25555 * assign.cs (Assign.DoResolve): Check whether the source
25556 expression is a value or variable.
25558 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25559 while resolving the corresponding blocks.
25561 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25562 an error, don't silently return null.
25564 * statement.cs (Block.AddVariable): Do the error reporting here
25565 and distinguish between CS0128 and CS0136.
25566 (Block.DoResolve): Report all unused labels (warning CS0164).
25567 (LabeledStatement): Pass the location to the constructor.
25568 (LabeledStatement.HasBeenReferenced): New property.
25569 (LabeledStatement.Resolve): Set it to true here.
25571 * statement.cs (Return.Emit): Return success even after reporting
25572 a type mismatch error (CS0126 or CS0127), this is what csc does and
25573 it avoids confusing the users with any consecutive errors.
25575 2002-08-05 Martin Baulig <martin@gnome.org>
25577 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25579 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25581 * expression.cs (MemberAccess.DoResolve): Silently return if an
25582 error has already been reported.
25584 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25585 error has already been reported.
25587 2002-08-05 Martin Baulig <martin@gnome.org>
25589 * statement.cs (UsageVector): Only initialize the `parameters'
25590 vector if we actually have any "out" parameters.
25592 2002-08-05 Martin Baulig <martin@gnome.org>
25594 * expression.cs (Binary.ResolveOperator): When combining delegates,
25595 they must have the same type.
25597 2002-08-05 Martin Baulig <martin@gnome.org>
25599 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25600 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25601 work with the ms runtime and we also don't need it: if we're a
25602 PropertyBuilder and not in the `indexer_arguments' hash, then we
25603 are a property and not an indexer.
25605 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25606 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25607 since the latter one doesn't work with the ms runtime.
25609 2002-08-03 Martin Baulig <martin@gnome.org>
25611 Fixed bugs #27998 and #22735.
25613 * class.cs (Method.IsOperator): New public field.
25614 (Method.CheckBase): Report CS0111 if there's already a method
25615 with the same parameters in the current class. Report CS0508 when
25616 attempting to change the return type of an inherited method.
25617 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25618 and it's not marked abstract or extern.
25619 (PropertyBase): New abstract base class for Property and Indexer.
25620 (PropertyBase.CheckBase): Moved here from Property and made it work
25622 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25623 the same so we can reuse it there.
25624 (Property, Indexer): Derive from PropertyBase.
25625 (MethodSignature.inheritable_property_signature_filter): New delegate
25626 to find properties and indexers.
25628 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25629 argument and improved error reporting.
25631 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25632 EmptyReadOnlyParameters and made it a property.
25634 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25635 version of this method which takes a `PropertyInfo indexer'.
25636 (TypeManager.RegisterIndexer): New method.
25638 * class.cs: Added myself as author of this file :-)
25640 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25642 * class.cs: fixed compilation on windoze.
25644 2002-08-03 Martin Baulig <martin@gnome.org>
25646 * interface.cs (Interface.GetInterfaceBases): Check whether all
25647 base interfaces are at least as accessible than the current one.
25649 * class.cs (TypeContainer.GetClassBases): Check whether base types
25650 are at least as accessible than the current type.
25651 (TypeContainer.AsAccessible): Implemented and made non-static.
25652 (MemberBase.CheckParameters): Report errors if the accessibility
25655 * delegate.cs (Delegate.Delegate): The default visibility is
25656 internal for top-level types and private for nested types.
25657 (Delegate.Define): Report errors if the accessibility checks fail.
25659 * enum.cs (Enum.Enum): The default visibility is internal for
25660 top-level types and private for nested types.
25661 (Enum.DefineType): Compute the correct visibility.
25663 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25664 function which takes a `bool is_toplevel' instead of a TypeContainer.
25666 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25669 2002-08-02 Martin Baulig <martin@gnome.org>
25671 * expression.cs (LocalVariableReferenc): Added constructor which
25672 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25673 (LocalVariableReference.IsReadOnly): New property.
25674 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25675 variable is readonly, use our own readonly flag to do this; you can
25676 use the new constructor to get a writable reference to a read-only
25679 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25680 reference to the local variable.
25682 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25684 * rootcontext.cs (ResolveCore): Also include System.Exception
25686 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25687 we reach an EmptyStatement.
25689 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25692 * expression.cs (Binary.ResolveOperator): Check error result in
25695 use brtrue/brfalse directly and avoid compares to null.
25697 2002-08-02 Martin Baulig <martin@gnome.org>
25699 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25700 Fixes bug #28407, added test-155.cs.
25702 2002-08-01 Martin Baulig <martin@gnome.org>
25704 * class.cs (Event.EmitDefaultMethod): Make this work with static
25705 events. Fixes #28311, added verify-3.cs.
25707 2002-08-01 Martin Baulig <martin@gnome.org>
25709 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25710 `is_disposable' fields.
25711 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25712 `hm.is_disposable' if we're using the collection pattern.
25713 (Foreach.EmitCollectionForeach): Use the correct type for the
25714 enumerator's local variable, only emit the try/finally block if
25715 necessary (fixes #27713).
25717 2002-08-01 Martin Baulig <martin@gnome.org>
25719 * ecore.cs (Expression.report118): Renamed to Error118 and made
25722 * statement.cs (Throw.Resolve): Check whether the expression is of
25723 the correct type (CS0118) and whether the type derives from
25724 System.Exception (CS0155).
25725 (Catch.Resolve): New method. Do the type lookup here and check
25726 whether it derives from System.Exception (CS0155).
25727 (Catch.CatchType, Catch.IsGeneral): New public properties.
25729 * typemanager.cs (TypeManager.exception_type): Added.
25731 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25733 * driver.cs: Updated About function.
25735 2002-07-31 Martin Baulig <martin@gnome.org>
25737 Implemented Control Flow Analysis.
25739 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25740 (EmitContext.CurrentBranching): Added.
25741 (EmitContext.StartFlowBranching): Added.
25742 (EmitContext.EndFlowBranching): Added.
25743 (EmitContext.KillFlowBranching): Added.
25744 (EmitContext.IsVariableAssigned): Added.
25745 (EmitContext.SetVariableAssigned): Added.
25746 (EmitContext.IsParameterAssigned): Added.
25747 (EmitContext.SetParameterAssigned): Added.
25748 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25749 Added control flow analysis stuff here.
25751 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25752 resolve the expression as lvalue.
25753 (LocalVariableReference.DoResolve): Check whether the variable has
25754 already been assigned.
25755 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25756 the parameter as assigned here.
25757 (ParameterReference.DoResolve): Check whether the parameter has already
25759 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25760 expression as lvalue.
25762 * statement.cs (FlowBranching): New class for the flow analysis code.
25763 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25764 (LabeledStatement.IsDefined): New public property.
25765 (LabeledStatement.AddUsageVector): New public method to tell flow
25766 analyis that the label may be reached via a forward jump.
25767 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25769 (VariableInfo.Number): New public field. This is used by flow analysis
25770 to number all locals of a block.
25771 (Block.CountVariables): New public property. This is the number of
25772 local variables in this block (including the locals from all parent
25774 (Block.EmitMeta): Number all the variables.
25776 * statement.cs: Added flow analysis support to all classes.
25778 2002-07-31 Martin Baulig <martin@gnome.org>
25780 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25781 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25782 then use this argument.
25784 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25786 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25787 use this to specify /define options.
25789 2002-07-29 Martin Baulig <martin@gnome.org>
25791 * statement.cs (Fixed): Moved all code that does variable lookups
25792 and resolvings from Emit to Resolve.
25794 * statement.cs (For): Moved all code that does variable lookups
25795 and resolvings from Emit to Resolve.
25797 * statement.cs (Using): Moved all code that does variable lookups
25798 and resolvings from Emit to Resolve.
25800 2002-07-29 Martin Baulig <martin@gnome.org>
25802 * attribute.cs (Attribute.Resolve): Explicitly catch a
25803 System.NullReferenceException when creating the
25804 CustromAttributeBuilder and report a different warning message.
25806 2002-07-29 Martin Baulig <martin@gnome.org>
25808 * support.cs (ParameterData.ParameterName): Added method to
25809 get the name of a parameter.
25811 * typemanager.cs (TypeManager.IsValueType): New public method.
25813 2002-07-29 Martin Baulig <martin@gnome.org>
25815 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25816 is a flag which specifies that it's either ref or out.
25817 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25818 the out parameter to `out Parameter.Modifier mod', also set the
25819 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25821 * support.cs (InternalParameters.ParameterModifier): Distinguish
25822 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25823 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25825 * expression.cs (Argument.GetParameterModifier): Distinguish
25826 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25827 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25829 2002-07-29 Martin Baulig <martin@gnome.org>
25831 * expression.cs (ParameterReference.ParameterReference): Added
25832 `Location loc' argument to the constructor.
25834 * cs-parser.jay: Pass location to ParameterReference.
25836 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25838 * statement.cs (Try): Initialize the location.
25840 * cs-parser.jay: pass location to Try.
25842 * expression.cs (Unary.Reduce): Change the prototype to return
25843 whether a constant fold could be performed or not. The result is
25844 returned in an out parameters. In the case of Indirection and
25845 AddressOf, we want to perform the full tests.
25847 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25849 * statement.cs (Statement.Emit): Flag dead code.
25851 2002-07-27 Andrew Birkett <andy@nobugs.org>
25853 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25855 2002-07-27 Martin Baulig <martin@gnome.org>
25857 * class.cs (MethodData.Define): Put back call to
25858 TypeManager.AddMethod(), accidentally commented this out.
25860 * report.cs (Debug): New public method to print debugging information,
25861 this is `[Conditional ("DEBUG")]'.
25863 2002-07-26 Martin Baulig <martin@gnome.org>
25865 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25866 (switch_statement): Push the current_block to the switch_stack and
25867 pop it again when we're done with the switch.
25868 (switch_section): The new block is a child of the current_block.
25869 Fixes bug #24007, added test-152.cs.
25871 2002-07-27 Martin Baulig <martin@gnome.org>
25873 * expression.cs (Invocation.EmitArguments): When calling a varargs
25874 function with only its fixed arguments, we need to pass an empty
25877 2002-07-27 Martin Baulig <martin@gnome.org>
25879 Mono 0.13 has been released.
25881 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25883 * driver.cs: Rename --resource to --linkres, because that is what
25884 we do currently, we dont support --resource yet.
25886 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25888 2002-07-25 Martin Baulig <martin@gnome.org>
25890 * class.cs (MethodData): New public class. This is a `method builder'
25891 class for a method or one accessor of a Property/Indexer/Event.
25892 (MethodData.GetMethodFlags): Moved here from MemberBase.
25893 (MethodData.ApplyAttributes): Likewise.
25894 (MethodData.ApplyObsoleteAttribute): Likewise.
25895 (MethodData.ApplyConditionalAttribute): Likewise.
25896 (MethodData.ApplyDllImportAttribute): Likewise.
25897 (MethodData.CheckAbstractAndExternal): Likewise.
25898 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25899 (MethodData.Emit): Formerly known as Method.Emit().
25900 (MemberBase): Moved everything which was specific to a single
25901 accessor/method to MethodData.
25902 (Method): Create a new MethodData and call Define() and Emit() on it.
25903 (Property, Indexer, Event): Create a new MethodData objects for each
25904 accessor and call Define() and Emit() on them.
25906 2002-07-25 Martin Baulig <martin@gnome.org>
25908 Made MethodCore derive from MemberBase to reuse the code from there.
25909 MemberBase now also checks for attributes.
25911 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25912 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25914 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25915 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25916 (MemberBase.ApplyAttributes): New virtual method; applies the
25917 attributes to a method or accessor.
25918 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25919 (MemberBase.ApplyConditionalAttribute): Likewise.
25920 (MemberBase.ApplyDllImportAttribute): Likewise.
25921 (MemberBase.CheckAbstractAndExternal): Likewise.
25922 (MethodCore.ParameterTypes): This is now a property instead of a
25923 method, it's initialized from DoDefineParameters().
25924 (MethodCore.ParameterInfo): Removed the set accessor.
25925 (MethodCore.DoDefineParameters): New protected virtual method to
25926 initialize ParameterTypes and ParameterInfo.
25927 (Method.GetReturnType): We can now simply return the MemberType.
25928 (Method.GetMethodFlags): Override the MemberBase version and add
25929 the conditional flags.
25930 (Method.CheckBase): Moved some code from Define() here, call
25931 DoDefineParameters() here.
25932 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25933 here to avoid some larger code duplication.
25934 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25935 ensure that abstract and external accessors don't declare a body.
25937 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25938 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25939 lookup in the attribute's parent classes, so we need to abort as soon
25940 as we found the first match.
25941 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25942 the attribute has no arguments.
25944 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25947 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25949 * cs-parser.jay: reverted previous patch.
25951 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25953 * cs-parser.jay: fixed bug #22119.
25955 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25957 * attribute.cs: fixed compilation. The error was:
25958 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25959 be assigned to before control leaves the current method."
25960 [FIXME: Filed as bug #28186: MCS must report this error.]
25962 2002-07-25 Martin Baulig <martin@gnome.org>
25964 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25965 method to pull the condition name ouf of a Conditional attribute.
25966 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25967 the obsolete message and error flag out of an Obsolete attribute.
25969 * class.cs (Method.GetMethodFlags): New public method to get the
25970 TypeManager.MethodFlags for this method.
25971 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25973 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25974 if we're overriding a virtual function, set the new private variable
25975 `parent_method'; call the new TypeManager.AddMethod().
25977 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25978 the MethodBuilder and the Method in a PtrHashtable.
25979 (TypeManager.builder_to_method): Added for this purpose.
25980 (TypeManager.MethodFlags): Added IsObsoleteError.
25981 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25982 Obsolete and Conditional arguments in MethodBuilders. If we discover
25983 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25984 the message from the attribute.
25986 2002-07-24 Martin Baulig <martin@gnome.org>
25988 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25989 preprocessor directives, ensure that the argument to #define/#undef is
25990 exactly one identifier and that it's actually an identifier.
25992 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25995 2002-07-24 Martin Baulig <martin@gnome.org>
25997 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25998 initialize it to TypeManager.object_type in the constructor.
25999 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
26000 of the `hm.get_current' method if we're using the collection pattern.
26001 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
26002 for the explicit conversion to make it work when we're using the collection
26003 pattern and the `Current' property has a different return type than `object'.
26006 2002-07-24 Martin Baulig <martin@gnome.org>
26008 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
26009 does not match, but don't report any errors. This method is called in
26010 order for all methods in a MethodGroupExpr until a matching method is
26011 found, so we don't want to bail out if the first method doesn't match.
26012 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
26013 matches, report the 123. Fixes #28070.
26015 2002-07-24 Martin Baulig <martin@gnome.org>
26017 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
26018 TypeManager.TypeToCoreType() to the top of the method so the
26019 following equality checks will work. Fixes #28107.
26021 2002-07-24 Martin Baulig <martin@gnome.org>
26023 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
26024 operand is of type uint, and the other operand is of type sbyte,
26025 short or int, the operands are converted to type long." -
26026 Actually do what this comment already told us. Fixes bug #28106,
26029 2002-07-24 Martin Baulig <martin@gnome.org>
26031 * class.cs (MethodBase): New abstract class. This is now a base
26032 class for Property, Indexer and Event to avoid some code duplication
26033 in their Define() and DefineMethods() methods.
26034 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
26035 generic methods for Define() and DefineMethods().
26036 (FieldBase): Derive from MemberBase, not MemberCore.
26037 (Property): Derive from MemberBase, not MemberCore.
26038 (Property.DefineMethod): Moved all the code from this method to the
26039 new MethodBase.DefineAccessor(), just call it with appropriate
26041 (Property.Define): Call the new Property.DoDefine(), this does some
26042 sanity checks and we don't need to duplicate the code everywhere.
26043 (Event): Derive from MemberBase, not MemberCore.
26044 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
26045 accessors, this will also make them work with interface events.
26046 (Indexer): Derive from MemberBase, not MemberCore.
26047 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
26048 (Indexer.Define): Use the new MethodBase functions.
26050 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
26051 argument to the constructor.
26052 (Interface.FindMembers): Added support for interface events.
26053 (Interface.PopluateEvent): Implemented.
26055 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
26057 2002-07-22 Miguel de Icaza <miguel@ximian.com>
26059 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
26060 but this is required to check for a method name being the same as
26061 the containing class.
26065 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26067 * interface.cs: initialize variable.
26069 2002-07-23 Martin Baulig <martin@gnome.org>
26071 Implemented the IndexerName attribute in interfaces.
26073 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
26074 name if this is an explicit interface implementation.
26075 (Indexer.InterfaceIndexerName): New public variable. If we're
26076 implementing an interface indexer, this is the IndexerName in that
26077 interface. Otherwise, it's the IndexerName.
26078 (Indexer.DefineMethod): If we're implementing interface indexer,
26079 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
26080 and Pending.ImplementIndexer methods.
26081 (Indexer.Define): Also define the PropertyBuilder if we're
26082 implementing an interface indexer and this is neither an explicit
26083 interface implementation nor do the IndexerName match the one in
26086 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
26087 If a method is defined here, then we always need to create a proxy
26088 for it. This is used when implementing interface indexers.
26089 (Pending.IsInterfaceIndexer): New public method.
26090 (Pending.ImplementIndexer): New public method.
26091 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
26092 This is used when implementing interface indexers to define a proxy
26094 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
26095 define a proxy if necessary.
26097 * interface.cs (Interface.IndexerName): New public variable.
26098 (Interface.PopulateIndexer): Set the IndexerName.
26099 (Interface.DefineIndexers): New private method. Populate all the
26100 indexers and make sure their IndexerNames match.
26102 * typemanager.cs (IndexerPropertyName): Added support for interface
26105 2002-07-22 Martin Baulig <martin@gnome.org>
26107 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
26108 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
26109 ret if HasReturnLabel.
26110 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
26113 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
26114 and set the ec.LoopBeginTryCatchLevel.
26115 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
26116 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
26117 the current ec.TryCatchLevel, the branch goes out of an exception
26118 block. In this case, we need to use Leave and not Br.
26120 2002-07-22 Martin Baulig <martin@gnome.org>
26122 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
26123 block unless the block does not always return or it is contained in
26124 another try { ... } catch { ... } block. Fixes bug #26506.
26125 Added verify-1.cs to the test suite.
26127 2002-07-22 Martin Baulig <martin@gnome.org>
26129 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
26130 then we do not always return. Fixes bug #24985.
26132 2002-07-22 Martin Baulig <martin@gnome.org>
26134 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
26135 lookup on a per-class level; ie. walk up the class hierarchy until we
26136 found at least one applicable method, then choose the best among them.
26137 Fixes bug #24463 and test-29.cs.
26139 2002-07-22 Martin Baulig <martin@gnome.org>
26141 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
26142 return types of the methods. The return type is not part of the
26143 signature and we must not check it to make the `new' modifier work.
26144 Fixes bug #27999, also added test-147.cs.
26145 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
26147 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
26148 on the method's return type.
26150 2002-07-21 Martin Baulig <martin@gnome.org>
26152 * assign.cs: Make this work if the rightmost source is a constant and
26153 we need to do an implicit type conversion. Also adding a few more tests
26154 to test-38.cs which should have caught this.
26156 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
26157 target in the makefile for this. The makefile.gnu is primarily intended
26158 for end-users who don't want to debug the compiler.
26160 2002-07-21 Martin Baulig <martin@gnome.org>
26162 * assign.cs: Improved the Assign class so it can now handle embedded
26163 assignments (X = Y = Z = something). As a side-effect this'll now also
26164 consume less local variables. test-38.cs now passes with MCS, added
26165 a few new test cases to that test.
26167 2002-07-20 Martin Baulig <martin@gnome.org>
26169 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
26170 instructions. Fixes bug #27977, also added test-146.cs.
26172 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26174 * cs-tokenizer.cs: fixed getHex ().
26176 2002-07-19 Martin Baulig <martin@gnome.org>
26178 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
26179 not Type.GetType() to lookup the array type. This is needed when
26180 we're constructing an array of a user-defined type.
26181 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
26182 single-dimensional arrays, but also for single-dimensial arrays of
26185 2002-07-19 Martin Baulig <martin@gnome.org>
26187 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
26188 this function is called, it's not allowed to share LocalBuilders
26189 among ILGenerators.
26191 2002-07-19 Martin Baulig <martin@gnome.org>
26193 * expression.cs (Argument.Resolve): Report an error 118 when trying
26194 to pass a type as argument.
26196 2002-07-18 Martin Baulig <martin@gnome.org>
26198 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
26199 Conv_R_Un for the signed `long' type.
26201 2002-07-15 Miguel de Icaza <miguel@ximian.com>
26203 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
26204 `expr' for the temporary result, as that will fail if we do
26205 multiple resolves on the same expression.
26207 2002-07-05 Miguel de Icaza <miguel@ximian.com>
26209 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
26210 ec.TypeContainer for looking up aliases.
26212 * class.cs (TypeContainer): Remove LookupAlias from here.
26214 * decl.cs (DeclSpace); Move here.
26216 2002-07-01 Miguel de Icaza <miguel@ximian.com>
26218 * class.cs (FindMembers): Only call filter if the constructor
26219 bulider is not null.
26221 Also handle delegates in `NestedTypes' now. Now we will perform
26222 type lookups using the standard resolution process. This also
26225 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
26226 This uses Expressions (the limited kind that can be parsed by the
26227 tree) instead of strings.
26229 * expression.cs (ComposedCast.ToString): Implement, used to flag
26230 errors since now we have to render expressions.
26232 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
26235 * ecore.cs (SimpleName.ToString): ditto.
26237 * cs-parser.jay: Instead of using strings to assemble types, use
26238 Expressions to assemble the type (using SimpleName, ComposedCast,
26239 MemberAccess). This should fix the type lookups in declarations,
26240 because we were using a different code path for this.
26242 * statement.cs (Block.Resolve): Continue processing statements
26243 even when there is an error.
26245 2002-07-17 Miguel de Icaza <miguel@ximian.com>
26247 * class.cs (Event.Define): Also remove the `remove' method from
26248 the list of pending items.
26250 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
26251 generate more compact code.
26253 2002-07-17 Martin Baulig <martin@gnome.org>
26255 * const.cs (Const.LookupConstantValue): Add support for constant
26256 `unchecked' and `checked' expressions.
26257 Also adding test case test-140.cs for this.
26259 2002-07-17 Martin Baulig <martin@gnome.org>
26261 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26262 check whether mi.ReturnType implements the IEnumerator interface; the
26263 `==' and the IsAssignableFrom() will fail in this situation.
26265 2002-07-16 Ravi Pratap <ravi@ximian.com>
26267 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26270 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26272 * expression.cs: fixed bug #27811.
26274 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26276 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26277 Molaro: when we are a ref, the value already contains a pointer
26278 value, do not take the address of it.
26280 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26281 * removed mb-parser.jay and mb-tokenizer.cs
26283 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26285 * expression.cs: check against the building corlib void type.
26287 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26289 * ecore.cs: fix for valuetype static readonly fields: when
26290 initializing them, we need their address, not the address of a copy.
26292 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26294 * typemanager.cs: register also enum_type in corlib.
26296 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26298 * class.cs: allow calling this (but not base) initializers in structs.
26300 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26302 * ecore.cs: make sure we compare against the building base types
26305 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26307 * typemanager.cs: fix TypeToCoreType() to handle void and object
26308 (corlib gets no more typerefs after this change).
26310 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26312 * expression.cs (ArrayCreation.EmitArrayArguments): use
26313 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26315 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26316 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26317 array indexes, the runtime actually forbids them.
26319 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26320 for array arguments here.
26322 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26323 instead of the default for ValueTypes.
26325 (New.DoEmit): Use IsValueType instead of
26326 IsSubclassOf (value_type)
26327 (New.DoResolve): ditto.
26328 (Invocation.EmitCall): ditto.
26330 * assign.cs (Assign): ditto.
26332 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26333 Statements *are* currently doing part of their resolution during
26336 Expressions do always resolve during resolve, but statements are
26337 only required to propagate resolution to their children.
26339 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26341 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26343 (LoadAssembly): Do not add the dll if it is already specified
26345 (MainDriver): Add the System directory to the link path at the end,
26346 after all the other -L arguments.
26348 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26349 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26350 ldelem.u1) and using the opposite for sbytes.
26352 This fixes Digger, and we can finally run it.
26354 * driver.cs (UnixParseOption): Move the option parsing here.
26355 (CSCParseOption): Implement CSC-like parsing of options.
26357 We now support both modes of operation, the old Unix way, and the
26358 new CSC-like way. This should help those who wanted to make cross
26359 platform makefiles.
26361 The only thing broken is that /r:, /reference: and /lib: are not
26362 implemented, because I want to make those have the same semantics
26363 as the CSC compiler has, and kill once and for all the confussion
26364 around this. Will be doing this tomorrow.
26366 * statement.cs (Unsafe.Resolve): The state is checked during
26367 resolve, not emit, so we have to set the flags for IsUnsfe here.
26369 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26371 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26372 not catch the Error_ObjectRefRequired in SimpleName (as it is
26373 possible to have a class/instance variable name that later gets
26374 deambiguated), we have to check this here.
26376 2002-07-10 Ravi Pratap <ravi@ximian.com>
26378 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26379 make static and put into Expression.
26381 (Event.Define): Register the private field of the event with the
26382 TypeManager so that GetFieldFromEvent can get at it.
26384 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26385 keep track of the private field associated with an event which
26388 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26391 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26393 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26395 * expression.cs (Binary.EmitBranchable): this routine emits the
26396 Binary expression in a branchable context. This basically means:
26397 we need to branch somewhere, not just get the value on the stack.
26399 This works together with Statement.EmitBoolExpression.
26401 * statement.cs (Statement.EmitBoolExpression): Use
26404 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26406 * statement.cs (For): Reduce the number of jumps in loops.
26408 (For): Implement loop inversion for the For statement.
26410 (Break): We can be breaking out of a Try/Catch controlled section
26411 (foreach might have an implicit try/catch clause), so we need to
26412 use Leave instead of Br.
26414 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26415 now). If the instace expression supports IMemoryLocation, we use
26416 the AddressOf method from the IMemoryLocation to extract the
26417 address instead of emitting the instance.
26419 This showed up with `This', as we were emitting the instance
26420 always (Emit) instead of the Address of This. Particularly
26421 interesting when This is a value type, as we dont want the Emit
26422 effect (which was to load the object).
26424 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26426 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26428 * statement.cs (Checked): Set the CheckedState during the resolve
26429 process too, as the ConvCast operations track the checked state on
26430 the resolve process, and not emit.
26432 * cs-parser.jay (namespace_member_declaration): Flag that we have
26433 found a declaration when we do. This is used to flag error 1529
26435 * driver.cs: Report ok when we display the help only.
26437 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26439 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26441 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26443 * cs-tokenizer.cs (define): We also have to track locally the
26444 defines. AllDefines is just used for the Conditional Attribute,
26445 but we also need the local defines for the current source code.
26447 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26449 * statement.cs (While, For, Do): These loops can exit through a
26450 Break statement, use this information to tell whether the
26451 statement is the last piece of code.
26453 (Break): Flag that we break.
26455 * codegen.cs (EmitContexts): New `Breaks' state variable.
26457 2002-07-03 Martin Baulig <martin@gnome.org>
26459 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26460 modifiers in method declarations in structs. Otherwise, you won't
26461 be able to override things like Object.Equals().
26463 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26465 * class.cs (Method, Property, Indexer): Do not allow the public
26466 modifier to be used in explicit interface implementations.
26468 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26469 override modifiers in method declarations in structs
26471 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26473 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26474 integer or real overflow, report an error
26476 2002-07-02 Martin Baulig <martin@gnome.org>
26478 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26479 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26480 to tell the runtime about our newly created System.Object and
26481 System.ValueType types.
26483 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26485 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26486 struct instead of Ldarg/Starg.
26488 2002-07-02 Martin Baulig <martin@gnome.org>
26490 * expression.cs (Indirection.Indirection): Call
26491 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26493 2002-07-02 Martin Baulig <martin@gnome.org>
26495 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26496 ValueType, call TypeManager.TypeToCoreType() on it.
26497 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26498 the OpCodes.Newarr argument.
26500 2002-07-02 Martin Baulig <martin@gnome.org>
26502 * expression.cs (Invocation.EmitCall): When compiling corlib,
26503 replace all calls to the system's System.Array type to calls to
26504 the newly created one.
26506 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26507 System.Array methods.
26508 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26509 from the system's System.Array type which must be replaced.
26511 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26513 * typemanager.cs: load unverifiable_code_ctor so we can build
26514 corlib using the correct type. Avoid using GetTypeCode() with
26516 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26517 TypeManager.object_type to allow building corlib.
26519 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26521 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26523 2002-07-01 Martin Baulig <martin@gnome.org>
26525 * class.cs: Make the last change actually work, we need to check
26526 whether `ifaces != null' to avoid a crash.
26528 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26530 * class.cs: when we build structs without fields that implement
26531 interfaces, we need to add the interfaces separately, since there is
26532 no API to both set the size and add the interfaces at type creation
26535 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26537 * expression.cs: the dimension arguments to the array constructors
26538 need to be converted if they are a long.
26540 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26542 * class.cs: don't emit ldarg.0 if there is no parent constructor
26543 (fixes showstopper for corlib).
26545 2002-06-29 Martin Baulig <martin@gnome.org>
26547 MCS now compiles corlib on GNU/Linux :-)
26549 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26550 ie. check for MethodImplOptions.InternalCall.
26552 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26553 and TypeManager.attribute_type are null, so we must explicitly check
26554 whether parent is not null to find out whether it's an attribute type.
26555 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26556 and SetBuilder, not only if the property is neither abstract nor external.
26557 This is necessary to set the MethodImplOptions on the accessor methods.
26558 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26559 SetBuilder, see Property.Emit().
26561 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26562 populate "System.Object", "System.ValueType" and "System.Attribute" since
26563 they've already been populated from BootCorlib_PopulateCoreTypes().
26565 2002-06-29 Martin Baulig <martin@gnome.org>
26567 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26568 is the NullLiteral, we also need to make sure that target_type is not
26571 2002-06-29 Martin Baulig <martin@gnome.org>
26573 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26574 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26575 before calling BootstrapCorlib_ResolveDelegate ().
26577 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26579 * statement.cs: fixed build-breaker. All tests passed ok.
26581 2002-06-27 Martin Baulig <martin@gnome.org>
26583 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26584 for System.Decimal when compiling corlib.
26586 2002-06-27 Martin Baulig <martin@gnome.org>
26588 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26589 switch blocks which contain nothing but a default clause.
26591 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26593 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26595 2002-06-27 Martin Baulig <martin@gnome.org>
26597 * ecore.cs (PropertyExpr.PropertyExpr): Call
26598 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26600 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26601 is already a TypeBuilder.
26603 2002-06-27 Martin Baulig <martin@gnome.org>
26605 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26606 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26607 the "from an array-type to System.Array" case. This makes it work
26608 when compiling corlib.
26610 2002-06-27 Martin Baulig <martin@gnome.org>
26612 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26613 non-static PropertyExpr, set its InstanceExpression. This makes
26614 the `ICollection.Count' property work in System/Array.cs.
26616 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26618 * driver.cs: Made error handling more consistent. Errors now
26619 tracked by Report class, so many methods which used to return int
26620 now return void. Main() now prints success/failure and
26621 errors/warnings message.
26623 Renamed '--probe' compiler argument to '--expect-error'. Removed
26624 the magic number return values (123 and 124). Now, if the
26625 expected error occurs, the compiler exits with success (exit value
26626 0). If the compilation completes without seeing that particular
26627 error, the compiler exits with failure (exit value 1). The
26628 makefile in mcs/errors has been changed to handle the new behaviour.
26630 * report.cs: Made 'expected error' number a property and renamed
26631 it from 'Probe' to 'ExpectedError'.
26633 * genericparser.cs: Removed error handling support, since it is
26634 now all done by Report class.
26636 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26637 class, so parse() no longer returns an int.
26639 * namespace.cs: Use Report.Error instead of GenericParser.error
26641 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26643 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26644 TypeContainer.AddOperator): At the front of the list put the
26645 explicit implementations, so they get resolved/defined first.
26647 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26649 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26650 interface type is implemented by this TypeContainer. Used during
26651 explicit interface implementation.
26653 (Property.Define, Indexer.Define, Method.Define): Validate that
26654 the given interface in the explicit implementation is one of the
26655 base classes for the containing type.
26657 Also if we are explicitly implementing an interface, but there is
26658 no match in the pending implementation table, report an error.
26660 (Property.Define): Only define the property if we are
26661 not explicitly implementing a property from an interface. Use the
26662 correct name also for those properties (the same CSC uses,
26663 although that is really not needed).
26665 (Property.Emit): Do not emit attributes for explicitly implemented
26666 properties, as there is no TypeBuilder.
26668 (Indexer.Emit): ditto.
26670 Hiding then means that we do not really *implement* a pending
26671 implementation, which makes code fail.
26673 2002-06-22 Martin Baulig <martin@gnome.org>
26675 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26676 the return value of Object.GetType(). [FIXME: we need to do this whenever
26677 we get a type back from the reflection library].
26679 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26681 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26683 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26685 * attribute.cs: Return null if we can not look up the type.
26687 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26688 the interface types found.
26690 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26691 interface types found.
26693 * typemanager.cs (GetInterfaces): Make this routine returns alll
26694 the interfaces and work around the lame differences between
26695 System.Type and System.Reflection.Emit.TypeBuilder in the results
26696 result for GetInterfaces.
26698 (ExpandInterfaces): Given an array of interface types, expand and
26699 eliminate repeated ocurrences of an interface. This expands in
26700 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26703 2002-06-21 Martin Baulig <martin@gnome.org>
26705 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26708 2002-06-21 Martin Baulig <martin@gnome.org>
26710 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26711 and called with one of the core types, return the corresponding typebuilder for
26714 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26717 2002-06-21 Martin Baulig <martin@gnome.org>
26719 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26720 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26721 (Expression.ConvertReferenceExplicit): Likewise.
26723 * expression.cs (ElementAccess.DoResolve): Likewise.
26724 (ElementAccess.DoResolveLValue): Likewise.
26726 2002-06-10 Martin Baulig <martin@gnome.org>
26728 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26729 add the "value" parameter to the parameter list.
26731 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26734 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26736 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26737 the argument to an int, uint, long or ulong, per the spec. Also
26738 catch negative constants in array creation.
26740 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26742 * class.cs: do not allow the same interface to appear twice in
26743 the definition list.
26745 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26747 * ecore.cs: don't use ldlen with System.Array.
26749 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26751 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26753 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26755 * modifiers.cs: produce correct field attributes for protected
26756 internal. Easy fix so miguel can work on ther harder stuff:-)
26758 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26760 * pending.cs: New file. Move the code from class.cs here.
26761 Support clearning the pending flag for all methods (when not doing
26762 explicit interface implementation).
26764 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26766 * rootcontext.cs: added a couple more types needed to bootstrap.
26768 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26770 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26771 constructor in the type, instead of any constructor in the type
26772 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26773 a bug in the Mono runtime when applying the params attribute).
26775 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26776 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26778 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26780 * expression.cs (Unary.ResolveOperator): Use TypeManager
26781 to resolve the type.
26783 2002-06-13 Ravi Pratap <ravi@ximian.com>
26785 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26788 * enum.cs (AddEnumMember): Add support to store the attributes associated
26789 with each member too.
26791 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26792 field builders too - this takes care of the enum member case.
26794 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26796 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26797 address-of operator on both value types and pointers.
26799 2002-06-10 Martin Baulig <martin@gnome.org>
26801 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26802 PropertyBuilder to the `property_builders' list.
26804 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26805 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26806 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26807 find any indexers which are inherited from an interface.
26809 2002-06-09 Martin Baulig <martin@gnome.org>
26811 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26812 the same type as the constant if necessary. There's also a test-130.cs
26815 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26817 * typemanager.cs (TypeManager.ChangeType): Previously known as
26818 Enum.ChangeEnumType().
26820 2002-06-09 Martin Baulig <martin@gnome.org>
26822 * expression.cs (Cast.TryReduce): Added support for consts.
26824 2002-06-08 Ravi Pratap <ravi@ximian.com>
26826 * class.cs (Accessor): Hold attributes information so we can pass
26829 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26830 Modify to pass in attributes attached to the methods.
26832 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26834 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26835 to handle the Accessor kind :-)
26837 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26839 2002-06-08 Martin Baulig <martin@gnome.org>
26841 * expression.cs (Unary.TryReduceNegative): Added support for
26844 2002-06-08 Martin Baulig <martin@gnome.org>
26846 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26847 name can't be found in the `defined_names' - the caller will do a
26848 MemberLookup in this case and thus find methods in System.Enum
26849 such as Enum.IsDefined().
26851 2002-06-08 Martin Baulig <martin@gnome.org>
26853 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26854 Convert.ChangeType() which works with TypeBuilder created types.
26855 (Enum.LookupEnumValue, Enum.Define): Use it here.
26857 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26858 `TypeBuilder.BaseType != null' check.
26859 (TypeContainer.FindMembers): Only lookup parent members if we
26860 actually have a parent.
26861 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26862 (ConstructorInitializer.Resolve): Likewise.
26864 * interface.cs (Interface.FindMembers): Added
26865 `TypeBuilder.BaseType != null' check.
26867 * rootcontext.cs (RootContext.ResolveCore): Added
26868 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26869 classes_second_stage.
26871 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26872 debug_type and trace_type when compiling with --nostdlib.
26874 2002-06-07 Martin Baulig <martin@gnome.org>
26876 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26877 (AddField): Set it to true when adding a non-static field.
26878 (DefineType): Use `have_nonstatic_fields' to find out whether we
26879 have non-static fields, not `Fields != null'.
26881 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26883 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26884 dereferencing a null on the static-field code path)
26886 2002-05-30 Martin Baulig <martin@gnome.org>
26888 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26889 to take command line arguments. Use reflection to call the new
26890 custom `Initialize' function on the symbol writer and pass it the
26891 command line arguments.
26893 * driver.cs (--debug-args): New command line argument to pass command
26894 line arguments to the symbol writer.
26896 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26898 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26899 the target type for indexers and properties. Thanks to Joe for
26902 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26904 * typemanager.cs (MethodFlags): returns the method flags
26905 (Obsolete/ShouldIgnore) that control warning emission and whether
26906 the invocation should be made, or ignored.
26908 * expression.cs (Invocation.Emit): Remove previous hack, we should
26909 not do this on matching a base type, we should do this based on an attribute
26911 Only emit calls to System.Diagnostics.Debug and
26912 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26913 on the command line.
26915 * rootcontext.cs: Global settings for tracing and debugging.
26917 * cs-tokenizer.cs (define): New utility function to track
26918 defines. Set the global settings for TRACE and DEBUG if found.
26920 2002-05-25 Ravi Pratap <ravi@ximian.com>
26922 * interface.cs (Populate*): Pass in the TypeContainer as well as
26923 the DeclSpace as parameters so that we can create EmitContexts and
26924 then use that to apply attributes etc.
26926 (PopulateMethod, PopulateEvent, PopulateProperty)
26927 (PopulateIndexer): Apply attributes everywhere.
26929 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26932 (ApplyAttributes): Update accordingly.
26934 We now apply interface attributes for all members too.
26936 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26938 * class.cs (Indexer.Define); Correctly check if we are explicit
26939 implementation (instead of checking the Name for a ".", we
26940 directly look up if the InterfaceType was specified).
26942 Delay the creation of the PropertyBuilder.
26944 Only create the PropertyBuilder if we are not an explicit
26945 interface implementation. This means that explicit interface
26946 implementation members do not participate in regular function
26947 lookups, and hence fixes another major ambiguity problem in
26948 overload resolution (that was the visible effect).
26950 (DefineMethod): Return whether we are doing an interface
26953 * typemanager.cs: Temporary hack until we get attributes in
26954 interfaces (Ravi is working on that) and we get IndexerName
26955 support in interfaces.
26957 * interface.cs: Register the indexers as properties.
26959 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26960 warning, I have verified that this is a bug in the .NET runtime
26961 (JavaScript suffers of the same problem).
26963 * typemanager.cs (MemberLookup): When looking up members for
26964 interfaces, the parent of an interface is the implicit
26965 System.Object (so we succeed in searches of Object methods in an
26966 interface method invocation. Example: IEnumerable x; x.ToString
26969 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26971 * class.cs (Event): Events should also register if they do
26972 implement the methods that an interface requires.
26974 * typemanager.cs (MemberLookup); use the new GetInterfaces
26977 (GetInterfaces): The code used to lookup interfaces for a type is
26978 used in more than one place, factor it here.
26980 * driver.cs: Track the errors at the bottom of the file, we kept
26983 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26984 instance if the method we are calling is static!
26986 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26988 * attribute.cs (ApplyAttributes): Make this function filter out
26989 the IndexerName attribute (as that attribute in reality is never
26990 applied) and return the string constant for the IndexerName
26993 * class.cs (TypeContainer.Emit): Validate that all the indexers
26994 have the same IndexerName attribute, and if so, set the
26995 DefaultName attribute on the class.
26997 * typemanager.cs: The return value might contain other stuff (not
26998 only methods). For instance, consider a method with an "Item"
26999 property and an Item method.
27001 * class.cs: If there is a problem with the parameter types,
27004 2002-05-24 Ravi Pratap <ravi@ximian.com>
27006 * ecore.cs (ImplicitConversionExists): Wrapper function which also
27007 looks at user defined conversion after making a call to
27008 StandardConversionExists - we need this for overload resolution.
27010 * expression.cs : Update accordingly the various method calls.
27012 This fixes 2 bugs filed against implicit user defined conversions
27014 2002-05-22 Miguel de Icaza <miguel@ximian.com>
27016 * statement.cs: Track the result of the assignment.
27018 2002-05-21 Miguel de Icaza <miguel@ximian.com>
27020 * expression.cs (MemberAccess): Improved error reporting for
27021 inaccessible members.
27023 2002-05-22 Martin Baulig <martin@gnome.org>
27025 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
27026 itself with debugging support.
27028 2002-05-22 Martin Baulig <martin@gnome.org>
27030 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
27031 Removed, this isn't needed anymore.
27033 2002-05-20 Martin Baulig <martin@gnome.org>
27035 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
27036 be underlying type for an enum.
27038 2002-05-20 Miguel de Icaza <miguel@ximian.com>
27040 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
27041 that splits out the loading of just the core types.
27043 * rootcontext.cs (ResolveCore): Split the struct resolution in
27044 two, so we can load the enumeration underlying types before any
27047 * expression.cs (Is): Bandaid until we fix properly Switch (see
27048 bug #24985 for details).
27050 * typemanager.cs (ImplementsInterface): The hashtable will contain
27051 a null if there are no interfaces implemented.
27053 2002-05-18 Miguel de Icaza <miguel@ximian.com>
27055 * cs-parser.jay (indexer_declarator): It is fine to have array
27058 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27060 * typemanager.cs: (RegisterBuilder): New function used to register
27061 TypeBuilders that implement interfaces. Since
27062 TypeBuilder.GetInterfaces (as usual) does not work with lame
27064 (AddUserType): register interfaces.
27066 (ImplementsInterface): Use the builder_to_ifaces hash if we are
27067 dealing with TypeBuilder. Also, arrays are showing up as
27068 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
27069 methods can not be invoked on them!
27071 * ecore.cs (ExplicitReferenceConversionExists): Made public.
27072 (ImplicitReferenceConversionExists): Split out from
27073 StandardConversionExists.
27075 * expression.cs (As): We were only implementing one of the three
27076 cases for the as operator. We now implement them all.
27077 (Is): Implement the various other cases for Is as well.
27079 * typemanager.cs (CACHE): New define used to control if we want or
27080 not the FindMembers cache. Seems to have a negative impact on
27081 performance currently
27083 (MemberLookup): Nested types have full acess to
27084 enclosing type members
27086 Remove code that coped with instance/static returns for events, we
27087 now catch this in RealFindMembers.
27089 (RealFindMembers): only perform static lookup if the instance
27090 lookup did not return a type or an event.
27092 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27094 * assign.cs (CompoundAssign): We pass more semantic information
27095 now to Compound Assignments than we did before: now we have all
27096 the information at hand, and now we resolve the target *before* we
27097 do the expression expansion, which allows the "CacheValue" method
27098 to have the effect we intended (before, a [x] += 1 would generate
27099 two differen ArrayAccess expressions from the ElementAccess,
27100 during the resolution process).
27102 (CompoundAssign.DoResolve): Resolve target and original_source here.
27104 2002-05-16 Miguel de Icaza <miguel@ximian.com>
27106 * expression.cs (ArrayAccess): dropped debugging information.
27108 * typemanager.cs: Small bug fix: I was always returning i_members,
27109 instead of one of i_members or s_members (depending on which had
27112 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
27113 method is invoked before any code generation takes place, and it
27114 is a mechanism to inform that the expression will be invoked more
27115 than once, and that the method should use temporary values to
27116 avoid having side effects
27118 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
27120 * ecore.cs (Expression.CacheTemporaries): Provide empty default
27123 * expression.cs (Indirection, ArrayAccess): Add support for
27124 CacheTemporaries in these two bad boys.
27126 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
27127 ldobj or ldind_ref.
27128 (StoreFromPtr): Handle stobj as well.
27130 * expression.cs (UnaryMutator): Share more code.
27132 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
27133 down: I was not tracking the Filter function as well, which
27134 was affecting the results of the cache.
27136 2002-05-15 Miguel de Icaza <miguel@ximian.com>
27138 * attribute.cs: Remove the hack to handle the CharSet property on
27141 2002-05-14 Miguel de Icaza <miguel@ximian.com>
27143 * attribute.cs (DoResolve): More uglyness, we now only try to
27144 resolve the attribute partially, to extract the CharSet
27145 information (only if we are a StructLayout attribute). Otherwise
27147 (GetExtraTypeInfo): Add some code to conditionally kill in the
27148 future this. I am more and more convinced that the .NET
27149 framework has special code to handle the attribute setting on
27152 * expression.cs (IsParamsMethodApplicable): Revert my previous
27153 foreach change here, it was wrong.
27155 2002-05-13 Miguel de Icaza <miguel@ximian.com>
27157 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
27158 (pp_expr): do not abort on unknown input, just return.
27159 (eval): abort if there are pending chars.
27161 * attribute.cs (Attribute.Resolve): Positional parameters are
27162 optional. Deal with that case.
27164 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
27165 the Ansi/Unicode/Auto information for the type.
27167 (TypeContainer.DefineType): instantiate the EmitContext here, as
27168 we will be using it during the type definition (to resolve
27169 attributes) and during the emit phase.
27171 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
27172 to pull type information out of the attributes
27174 (Attribute.Resolve): track the constructor builder, and allow for
27175 multiple invocations (structs and classes will use this).
27177 * ecore.cs (MemberLookupFinal): new version with all the
27178 parameters customizable.
27180 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
27181 constructors. Return if the result value is null (as the error
27182 would have been flagged already by MemberLookupFinal)
27184 Do not allow instances of abstract classes or interfaces to be
27187 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
27188 We have to compare the assembly property here when dealing with
27189 FamANDAssem and Assembly access modifiers, because we might be
27190 creating an assembly from *modules* (that means that we are not
27191 getting TypeBuilders for types defined in other modules that are
27192 part of this assembly).
27194 (Method.Emit): If the method is marked abstract and has a body,
27197 (TypeContainer.DefineMembers): If both the defined member and the
27198 parent name match are methods, then do not emit any warnings: let
27199 the Method.Define routine take care of flagging warnings. But if
27200 there is a mismatch (method overrides something else, or method is
27201 overriwritten by something, then emit warning).
27203 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
27204 set to null, this means `do not check for the return type on the
27207 (Method.Define): set the return type for the method signature to
27208 null, so that we get methods with the same name and parameters and
27209 different return types. This is used to flag warning 114 (you are
27210 hiding a method, and you probably want to use the new/override
27213 * typemanager.cs (MemberLookup): Implemented proper access
27214 control, closing a long standing set of bug reports. The problem
27215 was that the Framework only has two bits: Public and NonPublic,
27216 and NonPublic includes private and protected methods, but we need
27217 to enforce the FamANDAssem, FamOrAssem and Family.
27219 2002-05-11 Miguel de Icaza <miguel@ximian.com>
27221 * statement.cs (GotoCase): Return true: Ammounts to giving up
27222 knowledge on whether we return or not, and letting the other case
27223 be responsible for it.
27225 2002-05-10 Miguel de Icaza <miguel@ximian.com>
27227 * driver.cs: Do not load directories for each file processed, only
27228 do it if there is a pattern.
27230 * ecore.cs: Report readonly assigns here as well, as we might have
27231 been resolved only by MemberAccess.
27233 (SimpleName.SimpleNameResolve): Also be useful for LValue
27234 resolution. We need this to propagate assign to local readonly variables
27236 * typemanager.cs: Use a ptrhashtable for the criteria, because we
27237 do not want to reuse potential criteria memory.
27239 * class.cs (MyEventBuilder): Set reflected_type;
27241 * ecore.cs (Constantify): Added support for constifying bools.
27243 (RootContext.LookupType): Added a cache for values looked up in
27244 the declaration space.
27246 * typemanager.cs (FindMembers): Now is a front-end to
27247 RealFindMembers, and provides a two-level hashtable-based cache to
27250 15% performance improvement: from 22.5 to 19.2 seconds.
27252 * expression.cs (IsParamsMethodApplicable): use foreach.
27253 (Invocation.DoResolve): ditto.
27254 (New.DoResolve): ditto.
27255 (ArrayCreation.DoResolve): ditto.
27257 * ecore.cs (FindMostEncompassingType): use foreach.
27259 * delegate.cs (NewDelegate.DoResolve): Use foreach
27261 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27262 (RemoveMethods): use foreach.
27264 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27265 nested foreach statements instead of for, and also break out of
27266 the inner loop once a match is found.
27268 (Invocation.OverloadResolve): Use foreach, simplify the code.
27270 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27272 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27273 we actually unwrap the expression to allow for extra information
27276 * expression.cs: Use Shr_Un on unsigned operations.
27278 2002-05-08 Ravi Pratap <ravi@ximian.com>
27280 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27281 applicable operators was not being considered correctly. This closes
27282 the bug Miguel reported.
27284 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27286 * attribute.cs: check that the type derives from System.Attribute
27287 and report the correct error in that case (moved the duplicate code to
27288 its own method, too).
27290 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27292 * attribute.cs: lookup attribute type name as the spec says: first the
27293 bare attribute name and then name + "Attribute" (nant compiles with
27294 mcs after this fix).
27296 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27298 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27299 Because of the way we parse things, we should try to see if a
27300 UIntConstant can fit in an integer.
27302 2002-05-07 Ravi Pratap <ravi@ximian.com>
27304 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27305 when we are in an explicit context.
27307 (ConvertReferenceExplicit): When converting from Iface type S to Class
27308 T make sure the rules are implemented as an OR.
27310 * parameter.cs (ParameterType): Make it a property for now although the
27311 purpose really isn't anything immediate.
27313 * expression.cs (Is*Applicable): Do better checking on the parameter type
27314 of a ref/out parameter. The ones from the system assemblies are already
27315 marked with the correct type so we don't need to do any correction.
27317 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27318 the object type is standard too so include that.
27320 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27322 * ecore.cs (StandardConversionExists): Augment with missing code:
27323 deal with IntConstant, LongConstants and Enumerations.
27325 * assign.cs: Report the error, instead of failing silently
27327 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27328 typecontainer that they are declared, because the
27329 typecontainer/namespace will have the list of using clauses that
27330 need to be applied.
27332 Assembly Attributes were escaping the normal registration
27335 (EmitCode): Apply attributes within an EmitContext that represents
27336 the container they were declared on.
27338 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27340 2002-05-06 Ravi Pratap <ravi@ximian.com>
27342 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27343 Revamp completely - make much cleaner as we now operate only
27346 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27347 to implement the logic detailed in the spec more correctly.
27349 (UserDefinedConversion): Update accordingly.
27351 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27353 * statement.cs: Return flow analysis information up.
27355 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27358 (token): Do not consume an extra character before calling
27361 2002-05-06 Piers Haken <piersh@friskit.com>
27363 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27365 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27367 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27368 EmitContext during the instance constructor initializer
27369 resolution, to stop access to instance variables.
27371 This is mandated by the spec, last paragraph of the `constructor
27372 initializers' section.
27374 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27376 * cs-parser.jay, class.cs (Accessor): new class used to represent
27377 an accessor (get or set). In the past we used `null' to represent
27378 a missing accessor. But this is ambiguous because there was no
27379 way to tell in abstract indexers/properties if one of them was
27382 Now there is a way of addressing that.
27384 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27385 instead of FindMembers.
27387 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27388 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27390 * attribute.cs: Treat indexers and properties as the same in terms
27391 of applying attributes
27393 * ecore.cs (FindMostEncompassedType): Use statically initialized
27394 EmptyExpressions()s like we do elsewhere to avoid creating useless
27395 objects (and we take this out of the tight loop).
27397 (GetConversionOperators): Move the code to extract the actual
27398 operators to a separate routine to clean things up.
27400 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27402 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27403 events are always registered FieldBuilders.
27405 * class.cs (FieldBase): New class shared by Fields
27407 * delegate.cs: If we are a toplevel delegate, use our full name.
27408 If we are a nested delegate, then only use our tail name.
27410 2002-05-02 Ravi Pratap <ravi@ximian.com>
27412 * expression.cs (IsApplicable): Ensure that we add the "&" to
27413 ref/out types before comparing it with the type of the argument.
27415 (IsParamsMethodApplicable): Ditto.
27417 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27420 * delegate.cs : Handle the case when we have more than one applicable
27421 method. Flag an error only when we finish checking all.
27423 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27425 * expression.cs: Add support for boolean static initializers.
27427 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27429 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27431 * parameter.cs (ComputeParameterTypes,
27432 ComputeAndDefineParameterTypes): Better error handling: now we
27433 clear the `types' cache if we fail during any of the type lookups.
27434 We also return the status code correctly to our caller
27436 * delegate.cs: If we fail to define a delegate, abort the extra
27439 * expression.cs (Binary.ResolveOperator): for
27440 operator==(object,object) and operator !=(object, object) we also
27441 have to verify that there is an implicit conversion from one to
27444 (ArrayAccess.DoResolve): Array Access can operate on
27447 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27449 * assign.cs (CompoundAssign): A new class used as a "flag" that
27450 the assignment actually is happening as part of a compound
27451 assignment operator.
27453 During compound assignment, a few new rules exist to enable things
27460 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27461 to the type of x) if y is implicitly convertible to the type of x,
27462 and the operator is a builtin operator and the return type of the
27463 operator is explicitly convertible to the type of x.
27465 * rootcontext.cs: Reset warning level to 2. 4 catches various
27466 "interesting" features in mcs, we must clean this up at some
27467 point, but currently am trying to kill other bugs ;-)
27469 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27470 in container classes as well.
27472 * expression.cs (Binary.ResolveOperator): Handle string case
27473 before anything else (as operator overloading does emit an error
27474 before doing anything else).
27476 This code could go away when we move to a table driven model, but
27477 i could not come up with a good plan last night.
27479 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27481 * typemanager.cs (CSharpName): reimplementation using regex.
27482 * class.cs: added null check for fields in Emit
27483 * rootcontext.cs: set warninglevel to 4
27485 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27487 * typemanager.cs (CSharpName): reimplemented with Lupus
27490 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27492 * statement.cs (If): correclty implement Resolve, because we were
27493 not catching sem errors in there. The same process is needed
27495 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27498 (Statement.Warning_DeadCodeFound): Factorize code.
27499 (While): Report dead code here too.
27501 (Statement): Added Resolve virtual method to allow
27502 for resolution split from the emit code.
27504 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27506 * statement.cs (EmitBoolExpression): No longer try to resolve the
27508 (MakeBoolean): New utility function that resolve, implicitly
27509 converts to boolean and tags the expression.
27512 (If, Do): Implement dead code elimination.
27513 (While): Implement loop inversion
27515 (Do, While, For, If): Resolve the expression prior to calling our
27518 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27521 - added method Report28 (warning: program has more than one entry point)
27522 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27523 - modified method Method.Define, the part at the end of the method
27525 * rootcontext.cs: added static public Location EntryPointLocation;
27527 * ../errors/cs0028.cs : Add test case for the above warning.
27530 - modified method CSharpName to allow arrays of primitive type to
27531 be printed nicely (e.g. instead of System.Int32[][] it now prints
27533 - added method CSharpSignature: returns the signature of a method
27534 in string format to be used in reporting errors, warnings, etc.
27536 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27539 2002-04-26 Ravi Pratap <ravi@ximian.com>
27541 * delegate.cs (Define): Fix extremely silly bug where I was
27542 setting the type of the 'object' parameter of the BeginInvoke
27543 method to System.IAsyncResult instead of System.Object ;-)
27545 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27547 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27550 (Constructor.Emit): return if we fail to initialize the
27551 constructor. Another door closed!
27553 * expression.cs (New.DoResolve): Improve error message (from -6 to
27554 1501). Use DeclaredOnly lookup to find the exact constructor.
27556 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27557 loop. This is useful.
27559 * cs-parser.jay: Adjust the default parameters so that destructors
27560 have the proper signature.
27562 2002-04-26 Martin Baulig <martin@gnome.org>
27564 * driver.cs (LoadAssembly): If `assembly' contains any characters
27565 which are only valid in path names and not in assembly names
27566 (currently slash, backslash and point), use Assembly.LoadFrom ()
27567 instead of Assembly.Load () on the `assembly' (before iteration
27568 over the link_paths).
27570 2002-04-26 Martin Baulig <martin@gnome.org>
27572 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27574 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27576 * class.cs (Property): use the new typemanager.MemberLookup
27578 (TypeContainer.MemberLookup): Implement using the
27579 TypeManager.MemberLookup now.
27581 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27582 and return MemberInfos, so that these can be used without an
27583 EmitContext (what we had before).
27585 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27587 * expression.cs: Fix the case where the argument to params if the
27588 type of the params. I omitted handling this before. Fixed
27590 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27592 * driver.cs: Call BootCorlib_PopulateCoreType
27594 * class.cs (Property.CheckBase): Check for properties only, not
27597 * interface.cs: Temporary hack: try/catch around the
27598 CustomAttributeBuilder, because I am getting an exception that I
27601 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27602 types whose definitions are required to be there (attributes are
27603 defined before standard types).
27605 Compute definitions as we boot the various types, as they are used
27606 immediately (value_type class will need object_type, but if we do
27607 not initialize object_type, we will pass a null, which will let
27608 the runtime pick the System.Object from the existing corlib, which
27609 is not what we want).
27611 2002-04-22 Patrik Torstensson <totte@labs2.com>
27613 * cs-tokenizer.cs: fixed a number of trim() issues.
27615 2002-04-22 Ravi Pratap <ravi@ximian.com>
27617 * expression.cs (Argument.Type): Ensure that we return the correct
27618 type when we have out or ref parameters [in which case we
27621 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27623 * class.cs (Property, Indexer): Allow extern modifier in there.
27625 * typemanager.cs (InitBaseTypes): Initializes object_type and
27626 value_type, since those will be used early on during the bootstrap
27627 process to compile corlib.
27629 (InitCoreTypes): Move code from here to InitBaseTypes.
27631 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27633 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27634 single-dimension arrays as using the ldlen opcode.
27636 Daniel Lewis discovered this optimization.
27638 * typemanager.cs: Add signature for System.Array::get_Length
27640 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27642 * statement.cs: report the error when the foreach does not apply to an
27643 array nor a collection.
27645 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27647 * expression.cs: Add implicit conversions to the operator ~.
27649 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27651 * typemanager.cs: Locate the decimal constructor.
27653 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27655 * attribute.cs: use the new property of TypeOf.
27656 * expression.cs: added 'get' property around typearg.
27658 These changes fix a build breaker reported by NickD. Is this the
27659 correct way to fix? If not, please, revert my changes and make it
27662 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27664 * attribute.cs: Add support for typeof in attribute invocations.
27665 I am not sure that this is right though.
27667 2002-04-14 Duncan Mak <duncan@ximian.com>
27669 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27670 Binary.Operator.Division case.
27672 2002-04-13 Ravi Pratap <ravi@ximian.com>
27674 * class.cs (DefineType): Ensure that we do a proper check on
27675 attribute types and also register it with the TypeManager.
27677 (TypeContainer.Targets): The default for attribute types is
27678 AttributeTargets.All.
27680 * attribute.cs (ApplyAttributes): Registering the attribute type
27681 is done elsewhere, not when we discover we have a Usage attribute.
27683 2002-04-12 Ravi Pratap <ravi@ximian.com>
27685 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27686 and get rid of is_delegate parameter.
27688 * everywhere : update.
27690 2002-04-12 Ravi Pratap <ravi@ximian.com>
27692 * cs-parser.jay (compilation_unit): Revamp completely to use
27693 some new ideas that I got from Rhys' grammar to solve the problems
27694 with assembly level attributes.
27696 (outer_declaration): New grammar production.
27698 (attribute_sections): Add.
27700 (opt_attributes): Base on attribute_sections
27702 (namespace_declaration): Allow opt_attributes to tackle the case
27703 when we have assembly level attributes - we are clever in this
27706 * attribute.cs (ApplyAttributes): Do not worry about assembly
27707 attributes in the non-global context.
27709 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27710 instead of SetGlobalAttributes.
27712 * class.cs, rootcontext.cs : Ensure we define and generate
27713 attribute types before anything else.
27715 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27716 and flag the new error -20 for the case when the attribute type
27717 does not have valid targets specified. csc does not catch this.
27719 * ../errors/errors.txt : update for error # -20
27721 2002-04-11 Ravi Pratap <ravi@ximian.com>
27723 * support.cs (InternalParameters.ParameterModifier): Do some null
27724 checking and return sane values.
27726 * class.cs (Method.Define): If we are a PInvoke method, ensure
27727 that we are static and extern. Report error # 601
27729 * ../errors/cs0601.cs : Add test case for the above error.
27731 2002-04-07 Ravi Pratap <ravi@ximian.com>
27733 * rootcontext.cs (attribute_types): We need to keep type of
27734 all attribute types separately and emit code for them first.
27736 (RegisterAttribute) : Implement.
27738 * class.cs (DefineType): Check if the current Type is a custom
27739 attribute type and register it accordingly.
27741 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27742 adding the first attribute twice and rename to
27744 (SetGlobalAttributes): this.
27746 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27749 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27750 if we are processing global arguments. Hmm, I am unsure of this.
27752 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27754 * expression.cs: added static array of strings to avoid calling
27755 Enum.ToString () for Operator in Binary. Significant recover of
27758 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27760 * class.cs (FindMembers): Allow the Builders of the various
27761 members to be null. If they are skip them. This only happens
27762 during the PInvoke declaration.
27764 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27766 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27767 failure, so we do not keep going afterwards.
27769 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27770 wanted to pass `false' as the `is_delegate' argument. If this is
27771 the case, why not use delegate_type == null to mean `is_delegate =
27772 false' and anything else as is_delegate = true.
27774 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27776 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27777 code for the section, not the beginning of the tests.
27779 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27781 * cfold.cs: Handle operator + (Enum x, Underlying x)
27783 * expression.cs (Binary): same. Warn about errors where we have
27784 Enum/Enum in operator + as well.
27786 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27789 - added support for switch(bool)
27790 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27791 - add TableSwitchEmit() to handle table-based switch statements
27793 2002-04-05 Ravi Pratap <ravi@ximian.com>
27795 * expression.cs (Invocation.OverloadResolve): Factor out code which
27796 does parameter compatibility checking with arguments so that we can
27797 re-use the code even from Delegate.VerifyApplicability
27799 (VerifyArgumentsCompat): Move above code here.
27801 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27802 and instead make a call to the above method.
27804 2002-03-31 Ravi Pratap <ravi@ximian.com>
27806 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27807 We use it to keep track of classes which are attribute types.
27809 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27811 * delegate.cs (Delegate.Define): Correctly define the types in the
27812 presence of fixed and array parameters.
27814 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27817 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27818 include NonPublic after the first iteration.
27820 * class.cs (Indexer.CheckBase): Only check if both parents are
27823 * cs-parser.jay (accessor_body): If empty, set to null.
27825 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27826 same code path here to resolve constants names that we did have in
27827 MemberAccess.DoResolve. There is too much code duplicated here.
27829 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27831 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27833 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27836 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27837 tokens, numbers and strings.
27839 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27842 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27843 asyncronous parameters and the regular parameters.
27845 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27846 specify the target directory.
27848 * expression.cs: (This.DoResolve): Simplify
27849 (As.Emit): Optimize, do not generate IsInst if the expression is
27850 always of the given type.
27852 (Is.DoResolve): Bug fix, we were reporting both always/never for
27855 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27856 creating too many unnecessary arrays.
27858 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27860 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27861 fields instead of rolling our own initializer. Takes care of all
27862 implicit conversions, and drops unnecessary static checks/argument.
27864 2002-03-31 Dick Porter <dick@ximian.com>
27866 * driver.cs: use the GetDirectories() return values properly, and
27867 use "/" as path separator.
27869 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27871 * expression.cs (Unary): Optimize - - expr into expr.
27872 (Binary): Optimize a + (-b) into a -b.
27874 * codegen.cs (CodeGen): Made all methods static.
27876 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27880 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27881 TypeBuilder property.
27883 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27886 * tree.cs: Removed the various RecordXXXX, and replaced with a
27887 single RecordDecl. Removed all the accessor methods, and just
27888 left a single access point Type
27890 * enum.cs: Rename DefineEnum to DefineType.
27892 * decl.cs: New abstract method `DefineType' used to unify the
27893 Defines for Enumerations, Interfaces, TypeContainers and
27896 (FindType): Moved LookupInterfaceOrClass here. Moved the
27897 LookupBaseClasses method that used to live in class.cs and
27898 interface.cs here, and renamed to FindType.
27900 * delegate.cs: Implement DefineType. Take advantage of the
27901 refactored pattern for locating the parent builder without taking
27902 the parent_builder argument (which we know does not work if we are
27903 nested, and triggering a toplevel definition).
27905 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27907 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27908 accessibility of a member has changed during override and report
27911 * class.cs (Method.Define, Property.Define): Only complain on
27912 overrides if the method is private, any other accessibility is
27913 fine (and since we just checked the permission is the same, we are
27916 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27917 and elif are processed always. The other pre-processing
27918 directives are only processed if we are "taking" the path
27920 2002-03-29 Martin Baulig <martin@gnome.org>
27922 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27923 current location is not Null.
27925 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27926 a separate method so we can profile it.
27928 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27929 `span.Seconds' are just seconds, but no minutes or hours.
27930 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27932 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27934 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27935 Remove the gratuitous set of Final:
27937 // If an interface implementation, then we can set Final.
27938 if (((flags & MethodAttributes.Abstract) == 0) &&
27939 implementing.DeclaringType.IsInterface)
27940 flags |= MethodAttributes.Final;
27942 I do not know what I was smoking when I used that.
27945 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27946 step into fixing the name resolution issues for delegates and
27947 unifying the toplevel name resolution.
27949 2002-03-28 Martin Baulig <martin@gnome.org>
27951 * class.cs (Method.Emit): If we have a symbol writer, call its
27952 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27953 tell it about the current method.
27955 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27956 writer that we're going to emit the first byte of IL code for a new
27957 statement (a new source line).
27958 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27959 EmitContext.Mark() before emitting any code.
27961 * location.cs (SymbolDocument): Return null when we're Null.
27963 * statement.cs (Statement): Moved the `Location loc' variable here.
27964 (Statement.EmitBoolExpression): If we have a symbol writer, call
27965 ec.Mark() before emitting any code to tell it that we're at the
27966 beginning of a new statement.
27967 (StatementExpression): Added `Location' argument to the constructor.
27968 (Block): Added public readonly variable `StartLocation' and public
27969 variable `EndLocation'. The latter is to be set using SetEndLocation().
27970 (Block): Added constructor which takes a start and end location.
27971 (Block.SetEndLocation): New method. This sets the end location.
27972 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27973 local variables we create.
27974 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27975 each statement and do also mark the begin and end of the block.
27977 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27978 tell it the current lexer.Location, use Location.Null for the end of the
27980 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27981 current block, set its end location using SetEndLocation().
27982 (statement_expression): StatementExpression constructor now takes the
27983 lexer.Location as additional argument.
27984 (for_statement, declare_local_variables): Likewise.
27985 (declare_local_variables): When creating a new implicit block, use the
27986 new Block constructor and pass it the lexer.Location.
27988 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27990 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27991 members also on the parent interfaces recursively.
27993 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27995 * report.cs: Use new formats, since Gonzalo finished the missing
27998 * expression.cs (Binary.ResolveOperator): added missing operator|
27999 operator& and operator^ for bool/bool.
28001 * cs-parser.jay: CheckDef now takes a Location argument that is
28002 used to report errors more precisly (instead of reporting the end
28003 of a definition, we try to track something which is a lot closer
28004 to the source of the problem).
28006 * cs-tokenizer.cs: Track global token use, so we can properly flag
28007 the use of #define/#undef after the first token has been seen.
28009 Also, rename the reportXXXX to Error_DescriptiveName
28011 * decl.cs (DeclSpace.IsTopLevel): Move property here from
28012 TypeContainer, so that Enum and Interface can use this too.
28014 * class.cs (TypeContainer.LookupInterfaceOrClass,
28015 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
28016 `builder' argument. Typically this was used to pass the parent
28017 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
28020 The problem is that a nested class could trigger the definition of
28021 a toplevel class, and the builder would be obviously wrong in that
28024 So we drop this argument, and we compute dynamically the
28025 TypeBuilder/ModuleBuilder (the correct information was available
28026 to us anyways from DeclSpace.Parent)
28028 * interface.cs (Interface.DefineInterface): Drop builder
28029 parameter cleanup like class.cs
28031 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
28034 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
28037 (Try.Emit): Propagate the returns value from the statement.
28039 (Return.Emit): Even if we are leavning
28041 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
28043 * modifiers.cs: Fix the computation of MethodAttributes flags.
28045 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
28047 * driver.cs: allow compilation of files that start with '/'.
28048 Add a default case when checking the argument of --target.
28050 2002-03-25 Miguel de Icaza <miguel@ximian.com>
28052 * interface.cs: Implement the same search algorithm for types in
28053 the interface code.
28055 * delegate.cs: Do not allow multiple definition.
28057 * Recovered ChangeLog that got accidentally amputated
28059 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
28061 * rootcontext.cs: Load manually enum to allow core classes to
28062 contain enumerations.
28064 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
28065 Update to new static methods in TypeManager.
28067 * typemanager.cs (GetMethod, GetConstructor): Use our
28068 implementation of FindMembers to find the members, since during
28069 corlib compilation, the types are TypeBuilders and GetMethod and
28070 GetConstructor do not work.
28072 Make all methods in TypeManager static.
28074 (InitCodeHelpers): Split the functionality from
28075 the InitCodeTypes function.
28077 * driver.cs: Call InitCodeHelpers after we have populated the
28080 * cs-parser.jay (delegate_declaration): we did not used to compute
28081 the delegate name correctly for void delegates.
28083 2002-03-24 Miguel de Icaza <miguel@ximian.com>
28085 * rootcontext.cs (RootContext): Init the interface_resolve_order
28086 and type_container_resolve_order always.
28088 (ResolveCore, BootstrapCorlib_ResolveClass,
28089 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
28090 compiler when compiling with --nostdlib
28092 * class.cs (TypeContainer.DefineType): Check that our parent is
28093 not null. This test is most important when we are bootstraping
28096 * codegen.cs: Split out the symbol writing code.
28098 2002-03-25 Martin Baulig <martin@gnome.org>
28100 * driver.cs (-g): Made -g an alias for --debug.
28102 2002-03-24 Martin Baulig <martin@gnome.org>
28104 * codegen.cs (SymbolWriter): New public variable. Returns the
28105 current symbol writer.
28106 (CodeGen): Added `bool want_debugging_support' argument to the
28107 constructor. If true, tell the ModuleBuild that we want debugging
28108 support and ask it for the ISymbolWriter.
28109 (Save): If we have a symbol writer, call it's Close() method after
28110 saving the assembly.
28112 * driver.c (--debug): New command line argument to create a
28113 debugger information file.
28115 * location.cs (SymbolDocument): New public property. Returns an
28116 ISymbolDocumentWriter object for the current source file or null
28117 if we don't have a symbol writer.
28119 2002-03-21 Miguel de Icaza <miguel@ximian.com>
28121 * driver.cs (LoadAssembly): Correctly return when all the paths
28122 have been tried and not before.
28124 * statement.cs (Switch.Emit): return the actual coverage for this
28125 statement (returns/not-returns)
28127 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
28128 switch of the statement if we are the last switch section. That
28129 kills two problems: try/catch problems (we used to emit an empty
28130 nop at the end) and switch statements where all branches would
28133 2002-03-19 Miguel de Icaza <miguel@ximian.com>
28135 * driver.cs: Add default assemblies (the equivalent to the
28136 Microsoft CSC.RSP file)
28138 * cs-tokenizer.cs: When updating `cols and setting it to zero,
28139 also update tokens_seen and set it to false.
28141 * driver.cs: Implement --recurse for Mike.
28143 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
28144 correctly splitting out the paths.
28146 2002-03-18 Miguel de Icaza <miguel@ximian.com>
28148 * interface.cs (Interface.PopulateProperty): Instead of using
28149 `parent' as the declaration space for the set parameters, use
28152 * support.cs (InternalParameters): InternalParameters constructor
28153 takes a DeclSpace instead of a TypeContainer.
28155 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
28156 types are being initialized, load the address of it before calling
28159 (New): Provide a mechanism to disable the generation of local
28160 value type temporaries when the caller will be providing us with
28161 an address to store it.
28163 (ArrayCreation.EmitDynamicInitializers): Use it.
28165 2002-03-17 Miguel de Icaza <miguel@ximian.com>
28167 * expression.cs (Invocation.EmitArguments): Only probe for array
28168 property if there is more than one argument. Sorry about that.
28170 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
28171 empty param arrays.
28173 * class.cs (Method.LabelParameters): Fix incorrect code path that
28174 prevented the `ParamArrayAttribute' from being applied to the
28177 2002-03-16 Miguel de Icaza <miguel@ximian.com>
28179 * support.cs (ReflectionParameters): Correctly compute whether the
28180 last argument is a params array. Fixes the problem with
28183 * typemanager.cs: Make the assemblies array always be non-null
28184 (empty, but non-null)
28186 * tree.cs (RecordDecl): New function that abstracts the recording
28187 of names. This reports error 101, and provides a pointer to the
28188 previous declaration. Fixes a crash in the compiler.
28190 * cs-parser.jay (constructor_declaration): Update to new grammar,
28191 and provide a constructor_body that can be empty.
28193 2002-03-15 Miguel de Icaza <miguel@ximian.com>
28195 * driver.cs: Add support for --resources.
28197 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
28198 Make all types for the various array helper methods be integer.
28200 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
28201 CheckState to ConvCast.
28203 (ConvCast): Now it takes a `checked' state argument, to avoid
28204 depending on the emit context for the conversion, and just using
28205 the resolve time setting.
28207 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
28208 instead of Invocation.EmitArguments. We do not emit the original
28209 arguments, instead we emit those which have been converted to
28210 unsigned int expressions.
28212 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
28214 * codegen.cs: ditto.
28216 * expression.cs (LocalVariableReference): Drop the use of the
28217 Store function that depended on the variable index.
28219 * statement.cs (VariableInfo): Drop the `Idx' property from this
28220 class, as this is not taking into account the indexes for
28221 temporaries tat we generate during the execution, getting the
28224 * class.cs: First emit class initializers, then call the parent
28227 * expression.cs (Binary): Fix opcode emision.
28228 (UnaryMutator.EmitCode): Support checked code generation
28230 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
28231 matches for events for both the Static and Instance scans,
28232 pointing to the same element. Fix that.
28234 2002-03-14 Miguel de Icaza <miguel@ximian.com>
28236 * rootcontext.cs (ResolveTree): Always set the
28237 interface_resolve_order, because nested interfaces will be calling
28240 * class.cs (GetInterfaceOrClass): Track the same resolution
28241 process used by TypeManager.LookupType. This fixes the nested
28242 type lookups in class declarations (separate path from
28245 (TypeContainer.DefineType): Also define nested interfaces.
28246 (TypeContainer.RegisterOrder): New public function used to
28247 register the order in which child interfaces need to be closed.
28249 Nested interfaces need to be closed after their parents have been
28252 * interface.cs (InterfaceAttr): Put all the logic for computing
28253 the interface attribute here.
28255 (DefineInterface): Register our interface order with the
28256 RootContext or with the TypeContainer depending on the case.
28258 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28260 * cs-parser.jay: rework foreach statement to work with the new
28261 changes to the policy on SimpleNames.
28263 * report.cs: support Stacktrace on warnings as well.
28265 * makefile: drop --unsafe and /unsafe from the compile.
28267 2002-03-13 Ravi Pratap <ravi@ximian.com>
28269 * ecore.cs (StandardConversionExists): Modify to take an Expression
28270 as the first parameter. Ensure we do null -> reference type conversion
28273 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28274 temporary Expression objects.
28276 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28278 * interface.cs: workaround bug in method overloading resolution
28279 (there is already a bugzilla bug for it).
28281 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28283 We could also solve this problem by having a separate path for
28284 performing type lookups, instead of DoResolve, we could have a
28285 ResolveType entry point, and only participating pieces of the
28286 production (simplename, deref, array) would implement this.
28288 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28289 signal SimpleName to only resolve type names and not attempt to
28290 resolve anything else.
28292 * expression.cs (Cast): Set the flag.
28294 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28296 * class.cs: Only report 108 if there is no `new' modifier.
28298 * cs-parser.jay: rework foreach statement to work with the new
28299 changes to the policy on SimpleNames.
28301 * report.cs: support Stacktrace on warnings as well.
28303 * makefile: drop --unsafe and /unsafe from the compile.
28305 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28307 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28308 lookups here, instead of doing that at parse time. This means
28309 that our grammar will not introduce `LocalVariableReferences' as
28310 expressions at this point. That solves the problem of code like
28314 static void Main ()
28318 This is only half the fix. The full fix requires parameters to
28319 also be handled in this way.
28321 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28322 makes the use more obvious of the DeclSpace. The
28323 ec.TypeContainer.TypeBuilder is now only used to pull the
28324 TypeBuilder for it.
28326 My theory is that I can get rid of the TypeBuilder completely from
28327 the EmitContext, and have typecasts where it is used (from
28328 DeclSpace to where it matters).
28330 The only pending problem is that the code that implements Aliases
28331 is on TypeContainer, and probably should go in DeclSpace.
28333 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28334 lookups here, instead of doing that at parse time. This means
28335 that our grammar will not introduce `LocalVariableReferences' as
28336 expressions at this point. That solves the problem of code like
28340 static void Main ()
28344 This is only half the fix. The full fix requires parameters to
28345 also be handled in this way.
28347 * class.cs (Property.DefineMethod): When implementing an interface
28348 method, set newslot, when implementing an abstract method, do not
28349 set the flag (before we tried never setting it, or always setting
28350 it, which is the difference).
28351 (Indexer.DefineMethod): same.
28352 (Method.DefineMethod): same.
28354 * ecore.cs: Only set the status used flag if we get back a Field.
28356 * attribute.cs: Temporary hack, so Paolo can keep working.
28358 2002-03-08 Ravi Pratap <ravi@ximian.com>
28360 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28361 the unmanaged type in the case we have a MarshalAs attribute.
28363 (Resolve): Handle the case when we are parsing the special MarshalAs
28364 attribute [we need to store the unmanaged type to use later]
28366 * typemanager.cs (marshal_as_attr_type): Built in type for the
28367 MarshalAs Attribute.
28369 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28370 on parameters and accordingly set the marshalling info.
28372 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28374 * class.cs: Optimizing slightly by removing redundant code after
28375 we switched to the `NoTypes' return value.
28376 (Property.DefineMethod): use NoTypes here too.
28378 This fixes the bug I introduced in my last batch of changes.
28380 2002-03-05 Ravi Pratap <ravi@ximian.com>
28382 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28384 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28385 Enums since those are types too.
28387 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28389 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28390 thanks to a call during the lookup process.
28392 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28394 * statement.cs (Foreach): Lots of work to accomodate a particular
28395 kind of foreach statement that I had not kept in mind. It is
28396 possible to have foreachs on classes that provide a GetEnumerator
28397 method that return objects that implement the "pattern" for using
28398 a foreach, there is no need to support GetEnumerator
28401 This is needed to compile nant.
28403 * decl.cs: Only report 114 if the member is not `Finalize' and if
28404 the warning level is at least 2.
28406 * class.cs: Moved the compare function from Method to
28409 (MethodSignature.InheritableMemberSignatureCompare): Add new
28410 filter function that is used to extract inheritable methods from a
28413 (Method.Define): Use the new `inheritable_method_signature_filter'
28416 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28419 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28421 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28423 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28425 * expression.cs: Pass location information to
28426 ConvertImplicitStandard.
28428 * class.cs: Added debugging code to track return values from
28431 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28433 * expression.cs (Is.DoResolve): If either side of the `is' is an
28434 interface, do not flag the warning.
28436 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28439 * report.cs: Allow for --fatal to be used with --probe.
28441 * typemanager.cs (NoTypes): Move the definition for the empty Type
28444 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28446 (TypeContainer.DefineProxy): New function used to proxy to parent
28447 implementations when implementing interfaces.
28448 (TypeContainer.ParentImplements): used to lookup if our parent
28449 implements a public function that is required by an interface.
28450 (TypeContainer.VerifyPendingMethods): Hook this up.
28452 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28453 `modules' and `assemblies' arraylists into arrays. We only grow
28454 these are the very early start up of the program, so this improves
28455 the speedof LookupType (nicely measured).
28457 * expression.cs (MakeByteBlob): Replaced unsafe code with
28458 BitConverter, as suggested by Paolo.
28460 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28461 folding of string concatenation, but if either side is a string,
28462 and the other is not, then return null, and let the runtime use
28463 the concatenation on the string plus the object (using
28464 `Object.ToString').
28466 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28468 Constant Folding has been implemented now.
28470 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28471 the error instead on types that are not supported in one's
28474 * constant.cs (Constant and all children): New set of functions to
28475 perform implict and explicit conversions.
28477 * ecore.cs (EnumConstant): Implement the new functions to perform
28478 conversion by proxying to the child expression.
28480 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28481 own separate setting that can not be turned off from the command
28482 line using --unchecked or --checked and is only controlled using
28483 the checked/unchecked statements and expressions. This setting is
28484 used by the constant folder to flag errors.
28486 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28487 ConstantCheckState as well.
28489 During Resolve, they also have to flag the state, because the
28490 constant folder runs completely in the Resolve phase.
28492 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28495 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28497 * cfold.cs: New file, this file contains the constant folder.
28499 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28500 argument to track whether we are using the resulting address to
28501 load or store a value and provide better error messages.
28503 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28504 new AddressOf arguments.
28506 * statement.cs (Foreach.EmitCollectionForeach): Update
28508 * expression.cs (Argument.Emit): Call AddressOf with proper
28509 arguments to track usage.
28511 (New.DoEmit): Call AddressOf with new arguments.
28513 (Unary.Emit): Adjust AddressOf call.
28515 2002-03-01 Ravi Pratap <ravi@ximian.com>
28517 * cs-parser.jay (member_access): Change the case for pre-defined types
28518 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28521 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28524 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28525 essentially like methods and apply attributes like MethodImplOptions to them too.
28527 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28530 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28531 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28534 * Update code everywhere accordingly.
28536 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28538 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28540 2002-02-28 Ravi Pratap <ravi@ximian.com>
28542 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28543 try performing lookups against those instead of jumping straight into using
28544 the 'using' clauses.
28546 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28548 (LookupType): Perform lookups in implicit parents too.
28550 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28551 sequence as RootContext.LookupType.
28553 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28554 the various cases of namespace lookups into this method.
28556 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28558 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28559 in positional arguments)
28561 * class.cs (Operator): Update the AllowedModifiers to contain
28564 * cs-parser.jay: Update operator declaration to allow for the
28565 operator body to be empty.
28567 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28570 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28572 * class.cs (Method.Emit): Label parameters.
28574 * driver.cs: Return 1 or 0 as the program exit code.
28576 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28578 * expression.cs: Special case the `null' object when trying to
28579 auto-compute the type, as anything can be explicitly converted to
28582 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28583 spotting this Paolo.
28585 (Expression.ImplicitNumericConversion): Perform comparissions of
28586 the type using the underlying type in the case of an enumeration
28587 rather than using the enumeration type for the compare.
28589 Cope with the underlying == type case, which is not possible to
28592 (Expression.ConvertNumericExplicit): Perform comparissions of
28593 the type using the underlying type in the case of an enumeration
28594 rather than using the enumeration type for the compare.
28596 * driver.cs: If the user does not supply an extension, assume .exe
28598 * cs-parser.jay (if_statement): Rewrote so that we can track the
28599 location for the if statement.
28601 * expression.cs (Binary.ConstantFold): Only concat strings when
28602 the operation is "+", not everything ;-)
28604 * statement.cs (Statement.EmitBoolExpression): Take a location
28606 (If, While, Do): Track location.
28608 * expression.cs (Binary.ResolveOperator): In the object + string
28609 case, I was missing a call to ConvertImplicit
28611 2002-02-25 Ravi Pratap <ravi@ximian.com>
28613 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28614 Location arguments. Ensure we use RootContext.LookupType to do our work
28615 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28617 * interface.cs (PopulateMethod): Handle the type of the parameter being
28620 * expression.cs (Invocation.BetterFunction): Handle the case when we
28621 have a params method with no fixed arguments and a call is made with no
28624 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28626 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28627 the verbatim-string-literal
28629 * support.cs (InternalParameters.ParameterModifier): handle null
28631 (InternalParameters.ParameterType): ditto.
28633 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28634 duplicating the name of the variable parameter.
28635 (GetParameterByName): Fix bug where we were not looking up array
28636 paramters if they were the only present (thanks Paolo!).
28637 (GetParameterInfo): We only have an empty set of types if both
28638 fixed and array are set to null.
28639 (GetParameterInfo-idx): Handle FixedParameter == null
28641 * cs-parser.jay: Handle the case where there is no catch
28642 statements (missing null test).
28644 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28646 * driver.cs (MainDriver): Be conservative on our command line
28649 Catch DirectoryNotFoundException when calling GetFiles.
28651 (SplitPathAndPattern): Used to split the input specification into
28652 a path and a pattern that we can feed to Directory.GetFiles.
28654 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28656 * statement.cs (Fixed): Implement the last case of the Fixed
28657 statement (string handling).
28659 * expression.cs (StringPtr): New class used to return a char * to
28660 a string; Used by the Fixed statement.
28662 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28664 * expression.cs (Binary.ResolveOperator): Remove redundant
28665 MemberLookup pn parent type.
28666 Optimize union call, we do not need a union if the types are the same.
28667 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28670 Specialize the use of MemberLookup everywhere, instead of using
28671 the default settings.
28673 (StackAlloc): Implement stackalloc keyword.
28675 * cs-parser.jay: Add rule to parse stackalloc.
28677 * driver.cs: Handle /h, /help, /?
28679 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28680 before we supported unsafe code.
28682 * makefile: add --unsafe to the self compilation of mcs.
28684 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28686 * expression.cs (PointerArithmetic): New class that is used to
28687 perform pointer arithmetic.
28688 (Binary.Resolve): Handle pointer arithmetic
28689 Handle pointer comparission.
28690 (ArrayPtr): Utility expression class that is used to take the
28691 address of an array.
28693 (ElementAccess): Implement array access for pointers
28695 * statement.cs (Fixed): Implement fixed statement for arrays, we
28696 are missing one more case before we are done.
28698 * expression.cs (Indirection): Implement EmitAssign and set the
28699 ExprClass to Variable. This allows pointer dereferences to be
28700 treated as variables, and to have values assigned to them.
28702 * ecore.cs (Expression.StoreFromPtr): New utility function to
28703 store values dereferencing.
28705 2002-02-20 Ravi Pratap <ravi@ximian.com>
28707 * expression.cs (Binary.ResolveOperator): Ensure that we are
28708 not trying to operate on a void type - this fixes the reported
28711 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28712 the parent implementation is sealed.
28714 * ../errors/cs0239.cs : Add.
28716 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28718 * typemanager.cs (unverifiable_code_type): Corresponds to
28719 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28720 which have unsafe code in them.
28722 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28725 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28727 * cs-tokenizer.cs: Add support for @"litreal strings"
28729 Make tokenizer accept pre-processor directives
28730 on any column (remove the old C-like limitation).
28732 * rootcontext.cs (EmitCode): Emit any global attributes.
28733 (AddGlobalAttributes): Used to keep track of assembly attributes.
28735 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28737 * cs-parser.jay: Add support for global attributes.
28739 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28741 * expression.cs (Indirection): New helper class. Unary will
28742 create Indirection classes to be able to implement the
28743 IMemoryLocation interface on it.
28745 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28747 * cs-parser.jay (fixed_statement): reference the right statement.
28749 * statement.cs (Fixed.Emit): Finish implementing the fixed
28750 statement for the &x case.
28752 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28754 * class.cs (Property.Define, Method.Define): Remove newslot when
28757 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28758 wrong. NewSlot should only be used if the `new' keyword is present.
28760 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28761 locating our system dir. Sorry about this.
28763 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28765 * driver.cs (GetSystemDir): Compute correctly the location of our
28766 system assemblies. I was using the compiler directory instead of
28767 the library directory.
28769 2002-02-13 Ravi Pratap <ravi@ximian.com>
28771 * expression.cs (BetterFunction): Put back in what Miguel commented out
28772 since it is the correct fix. The problem is elsewhere ;-)
28774 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28775 parameters of the parms method are themselves compatible or not !
28777 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28778 to check that a class implements an interface before saying that an implicit
28779 conversion was allowed. Use ImplementsInterface to do the checking.
28781 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28783 * class.cs (Method.Define): Track whether we are an explicit
28784 implementation or not. And only call DefineMethodOverride if we
28785 are an explicit implementation.
28787 (Property.DefineMethod): Ditto.
28789 2002-02-11 Ravi Pratap <ravi@ximian.com>
28791 * expression.cs (BetterFunction): Catch hideous bug which was
28792 preventing us from detecting ambiguous calls due to implicit casts i.e
28795 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28797 * support.cs (Pair): Remove un-needed method. I figured why I was
28798 getting the error in cs-parser.jay, the variable in a foreach loop
28799 is readonly, and the compiler does not really treat this as a variable.
28801 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28802 instead of EQUALS in grammar.
28804 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28806 * expression.cs (Unary.DoResolve): Check whether the argument is
28809 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28811 * support.cs: Api for Pair to set a value. Despite the fact that
28812 the variables are public the MS C# compiler refuses to compile
28813 code that accesses the field if the variable is part of a foreach
28816 * statement.cs (Fixed): Begin implementation of the fixed
28819 (Block.AddVariable): Return the VariableInfo on success and null
28820 on failure instead of true/false.
28822 * cs-parser.jay (foreach): Catch errors on variables already
28823 defined (we were ignoring this value before) and properly unwind
28824 the block hierarchy
28826 (fixed_statement): grammar for the fixed statement.
28828 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28830 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28831 pointer types to be incretemented.
28833 (SizeOf): Implement.
28835 * cs-parser.jay (pointer_member_access): Implement
28836 expr->IDENTIFIER production.
28838 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28839 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28842 (Unary): Implement indirection.
28844 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28845 use in non-unsafe context).
28847 (SimpleName.DoResolve): Check for pointers in field access on safe
28850 (Expression.LoadFromPtr): Factor the load-indirect code in this
28851 function. This was duplicated in UnboxCast and ParameterReference
28853 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28855 * expression.cs (ComposedCast): report an error if a pointer cast
28856 is used in a safe region.
28858 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28859 pointer type casts in unsafe context.
28861 * codegen.cs (EmitContext): Set up IsUnsafe.
28863 * cs-parser.jay (non_expression_type): Add productions for pointer
28866 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28867 code. We should not use force into static mode if the method is
28868 not virtual. Fixes bug in MIS
28870 * statement.cs (Do.Emit, While.Emit, For.Emit,
28871 Statement.EmitBoolExpression): Add support to Do and While to
28872 propagate infinite loop as `I do return' semantics.
28874 Improve the For case to also test for boolean constants.
28876 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28877 to the list of attributes we can add.
28879 Remove `EmitContext' argument.
28881 * class.cs (Method.Define): Apply parameter attributes.
28882 (Constructor.Define): Apply parameter attributes.
28883 (MethodCore.LabelParameters): Move here the core of labeling
28886 * support.cs (ReflectionParameters.ParameterModifier,
28887 InternalParameters.ParameterModifier): Use IsByRef on the type and
28888 only return the OUT bit for these parameters instead of in/out/ref
28891 This is because I miss-understood things. The ParameterInfo.IsIn
28892 and IsOut represent whether the parameter has the [In] and [Out]
28895 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28897 * ecore.cs (FieldExpr.Emit): Release temporaries.
28899 * assign.cs (LocalTemporary.Release): new function.
28901 * codegen.cs (EmitContext.GetTemporaryStorage,
28902 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28903 temporary storage. Now we can "put back" localbuilders when we
28906 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28908 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28909 need to make a copy of the variable to generate verifiable code.
28911 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28913 * driver.cs: Compute dynamically the system directory.
28915 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28916 Slower, but more generally useful. Used by the abstract
28917 registering implementation.
28919 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28920 the rules for the special rule on Type/instances. First check if
28921 we have the same name, and if so, try that special static path
28922 rather than the instance path.
28924 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28926 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28929 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28930 Enum, ValueType, Delegate or Array for non-corlib compiles.
28932 * cs-tokenizer.cs: Catch long identifiers (645)
28934 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28937 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28938 fix, we were returning too early, so we were not registering
28939 pending methods from abstract classes.
28941 Do not register pending methods if the class is abstract.
28943 * expression.cs (Conditional.DoResolve): Report circular implicit
28944 conversions when we neecd to compute it for conditional
28947 (Is.DoResolve): If the expression is always of the provided type,
28948 flag warning 183. If the expression can not ever be of the
28949 provided type flag warning 184.
28951 * class.cs: Catch 169 as well.
28953 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28956 2002-01-18 Nick Drochak <ndrochak@gol.com>
28958 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28960 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28962 * interface.cs: (PopulateMethod): Check for pointers being defined
28963 only if the unsafe context is active.
28964 (PopulateProperty): ditto.
28965 (PopulateIndexer): ditto.
28967 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28968 specified. If pointers are present, make sure that they are
28969 present in an unsafe context.
28970 (Constructor, Constructor.Define): ditto.
28971 (Field, Field.Define): ditto.
28972 (Property, Property.Define): ditto.
28973 (Event, Event.Define): ditto.
28975 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28976 hashtable if there are classes or structs defined.
28978 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28979 code, as the constant resolution moved.
28981 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28982 the metadata, so we can flag error 133.
28984 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28985 pointer is being declared in an unsafe context.
28987 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28989 * modifiers.cs (Modifiers.Check): Require a Location argument.
28990 Report error 227 for Unsafe use.
28992 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28994 * statement.cs (For.Emit): If the test is null, then report that
28995 we do `return', as we wont reach anything afterwards.
28997 (Switch.SwitchGoverningType): Track the expression that matched
29000 * driver.cs: Allow negative numbers as an error code to flag.
29002 * cs-parser.jay: Handle 1551.
29004 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
29006 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29008 * cs-parser.jay: Report 1518 (type declaration can only contain
29009 class, struct, interface, enum or delegate)
29011 (switch_label): Report 1523 (keywords `case' or `default' must
29014 (opt_switch_sections): Report 1522 (empty switch)
29016 * driver.cs: Report 1515 (response file specified multiple times)
29017 Report 1516 (Source file specified multiple times).
29019 * expression.cs (Argument.Resolve): Signal 1510
29021 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
29022 access not allowed in static code)
29024 2002-01-11 Ravi Pratap <ravi@ximian.com>
29026 * typemanager.cs (IsPointerType): Utility method which we are going
29029 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
29030 the object type, so we take care of that.
29032 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
29034 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
29035 added to non-params parameters :-)
29037 * typemanager.cs (CSharpName): Include 'void' type too.
29039 (void_ptr_type): Include in the set of core types.
29041 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
29044 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
29047 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
29048 completely forgotten about it.
29050 2002-01-10 Ravi Pratap <ravi@ximian.com>
29052 * cs-parser.jay (pointer_type): Add. This begins our implementation
29053 of parsing rules for unsafe code.
29055 (unsafe_statement): Implement.
29057 (embedded_statement): Modify to include the above.
29059 * statement.cs (Unsafe): Implement new class for unsafe blocks.
29061 * codegen.cs (EmitContext.InUnsafe): Add. This determines
29062 if the current context is an unsafe one.
29064 * cs-parser.jay (local_variable_pointer_type): Since local variable types
29065 are handled differently, we need separate rules for them.
29067 (local_variable_declaration): Update to use local_variable_pointer_type
29068 to allow variable declarations of unmanaged pointer types.
29070 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
29071 in unsafe contexts.
29073 * ../errors/cs0214.cs : Add.
29075 2002-01-16 Nick Drochak <ndrochak@gol.com>
29077 * makefile: remove 'response' file when cleaning.
29079 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29081 * cs-parser.jay: Report 1524.
29083 2002-01-14 Miguel de Icaza <miguel@ximian.com>
29085 * typemanager.cs (RegisterMethod): drop checking if we have
29086 registered this from here
29088 2002-01-12 Miguel de Icaza <miguel@ximian.com>
29090 * class.cs (Method.EmitDestructor): Implement calling our base
29093 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
29094 value of InFinally.
29096 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
29097 this routine and will wrap the call in a try/catch block. Deal
29100 2002-01-11 Miguel de Icaza <miguel@ximian.com>
29102 * ecore.cs (Expression.MemberLookup): instead of taking a
29103 parameter `same_type' that was used to tell whether we could
29104 access private members we compute our containing type from the
29107 (FieldExpr): Added partial support for volatile fields. This does
29108 not work for volatile fields exposed from assemblies, as I can not
29109 figure out how to extract the modreq from it.
29111 Updated all the source files to use this.
29113 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
29114 because it is referenced by MemberLookup very often.
29116 2002-01-09 Ravi Pratap <ravi@ximian.com>
29118 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
29119 TypeBuilder.GetCustomAttributes to retrieve what we need.
29121 Get rid of redundant default_member_attr_type as this is the same as
29122 default_member_type which already exists.
29124 * interface.cs, attribute.cs : Update accordingly.
29126 2002-01-08 Miguel de Icaza <miguel@ximian.com>
29128 * typemanager.cs: Enable IndexerPropertyName again. It does not
29129 work for TYpeBuilders though. Ravi, can you please fix this?
29131 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
29133 * expression.cs (Argument.Emit): Handle the case of ref objects
29134 being passed to ref functions;
29136 (ParameterReference.EmitLoad): Loads the content of the pointer
29137 without dereferencing.
29139 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29141 * cs-tokenizer.cs: Implemented the pre-processing expressions.
29143 2002-01-08 Ravi Pratap <ravi@ximian.com>
29145 * class.cs (Indexer.DefineMethod): Incorporate the interface
29146 type in the name of the method if we are doing explicit interface
29149 * expression.cs (ConversionExists): Remove as it is completely obsolete.
29151 (BetterConversion): Fix extremely trivial bug where we were referring to
29152 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
29155 * ../errors/bug16.cs : Add although we have fixed it.
29157 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29159 * expression.cs (BaseIndexer): Begin implementation.
29161 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
29163 * cs-parser.jay (indexer_declarator): Use qualified_identifier
29164 production directly to remove a shift/reduce, and implement
29165 explicit interface implementation.
29167 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
29168 after a floating point suffix.
29170 * expression.cs (DoNumericPromotions): Improved the conversion for
29171 uint/uint. If we have a constant, we avoid doing a typecast to a
29174 * class.cs (Indexer): Implement explicit interface implementation
29177 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
29179 * class.cs: make the default instance constructor public and hidebysig.
29181 2001-01-03 Ravi Pratap <ravi@ximian.com>
29183 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
29184 so we can call it from elsewhere.
29186 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
29187 we emit it internally if the class has a defined indexer; otherwise the user
29188 emits it by decorating the class definition with the DefaultMemberAttribute.
29190 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
29191 attribute is not used on a type which defines an indexer.
29193 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
29194 character when we skip whitespace.
29196 * ../errors/cs0646.cs : Add.
29198 2002-01-03 Miguel de Icaza <miguel@ximian.com>
29200 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
29203 * makefile: Add practical target `mcs3.exe' which builds the third
29204 generation compiler.
29206 * expression.cs (New): Fix structures constructor calling.
29208 * class.cs (Property, Method, Indexer): Emit Final flag on the
29209 method if we are an interface implementation and we are not
29212 * ecore.cs (PropertyExpr): New public field `IsBase', tells
29213 whether this property is referencing a `base' method.
29215 * expression.cs (Invocation.EmitCall): take an extra argument:
29216 is_base, this is used to determine whether the `call' or
29217 `callvirt' opcode should be used.
29220 * delegate.cs: update EmitCall.
29222 * class.cs (Method.Define): Set NewSlot for the cases where we are
29223 not implementing an interface method.
29225 (Property.Define): ditto.
29227 2002-01-02 Miguel de Icaza <miguel@ximian.com>
29229 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
29230 'r'. Allows mcs to parse itself fully.
29232 2002-01-02 Ravi Pratap <ravi@ximian.com>
29234 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
29235 of the number of initializers that require the InitializeArray method.
29237 (CheckIndices): Store the Expression in all cases - not the plain value. Also
29238 update the above field where necessary.
29240 (MakeByteBlob): Update accordingly.
29242 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
29245 (EmitDynamicInitializers): Update in accordance with the new optimization.
29247 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
29248 same OpCode applies.
29250 * cs-parser.jay : Fix some glaring errors I introduced.
29252 2002-01-01 Ravi Pratap <ravi@ximian.com>
29254 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
29255 so that we can check for name clashes there too.
29257 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29258 for interface indexers.
29260 * interfaces.cs (Define): Emit the default member attribute.
29262 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29263 variable was being referred to while setting the value ;-)
29265 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29267 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29268 byte-by-byte information when we know the data is zero.
29270 Make the block always a multiple of 4, because
29271 DefineInitializedData has a bug.
29273 * assign.cs: Fix, we should assign from the temporary, not from
29276 * expression.cs (MakeByteBlob): Fix my incorrect code.
29278 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29280 * typemanager.cs (EnumToUnderlying): This function is used to get
29281 the underlying type from an enumeration, because it does not
29284 * constant.cs: Use the I4_S form for values between -128 and 127.
29286 * statement.cs (Block.LookupLabel): Looks up a label.
29287 (Block): Drop support for labeled blocks.
29289 (LabeledStatement): New kind of statement that represents a label
29292 (Goto): Finally implement this bad boy.
29294 * cs-parser.jay: Update to reflect new mechanism to implement
29297 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29299 * codegen.cs (EmitContext.This): a codegen property that keeps the
29300 a single instance of this instead of creating many different this
29303 * delegate.cs (Delegate.DoResolve): Update to use the property;
29305 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29307 * expression.cs (BaseAccess.DoResolve): Ditto.
29309 2001-12-29 Ravi Pratap <ravi@ximian.com>
29311 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29312 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29314 (InitCoreTypes): Update accordingly.
29316 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29317 so we can quickly store the state.
29319 (ApplyAttributes): Set the correct implementation flags
29320 for InternalCall methods.
29322 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29324 * expression.cs (EmitCall): if a method is not virtual, then do
29325 not use callvirt on it.
29327 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29328 user defined stuff) requires the use of stobj, which takes an
29329 address on the stack instead of an array and an index. So emit
29330 the Ldelema operation for it.
29332 (EmitStoreOpcode): Use stobj for valuetypes.
29334 (UnaryMutator.EmitCode): Use the right 1 value depending on
29335 whether we are dealing with int64/uint64, float or doubles.
29337 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29338 constructors that I implemented last night.
29340 (Constructor.IsDefault): Fix to work properly for static
29343 * cs-parser.jay (CheckDef): report method signature errors.
29344 Update error number 103 to be 132.
29346 * decl.cs: New AdditionResult enumeration value: MethodExists.
29347 Although we do this check for methods later on in the semantic
29348 analysis, catching repeated default constructors is so easy that
29349 we catch these here.
29351 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29354 (ParameterReference.EmitAssign, Emit): handle
29357 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29358 (ArrayAccess.EmitStoreOpcode): ditto.
29360 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29362 * expression.cs (MakeByteBlob): Complete all the missing types
29363 (uint, short, ushort, byte, sbyte)
29365 * class.cs: Only init instance field initializers on instance
29368 Rename `constructors' to instance_constructors.
29370 (TypeContainer.AddConstructor): Only add constructors to the list
29371 if it is not static.
29373 Make sure that we handle default_static_constructor independently
29374 everywhere where we handle instance_constructors
29376 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29378 * class.cs: Do not lookup or create a base initializer for a
29379 static constructor.
29381 (ConstructorInitializer.Resolve): use the proper type to lookup
29384 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29386 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29389 * decl.cs: CloseType is now an virtual method, the default
29390 implementation just closes this type.
29392 2001-12-28 Ravi Pratap <ravi@ximian.com>
29394 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29395 to PreserveSig by default. Also emit HideBySig on such methods.
29397 Basically, set the defaults to standard values.
29399 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29400 argument, if candidate is better, it can't be worse than the best !
29402 (Invocation): Re-write bits to differentiate between methods being
29403 applicable in their expanded form and their normal form - for params
29406 Get rid of use_standard everywhere as only standard conversions are allowed
29407 in overload resolution.
29409 More spec conformance.
29411 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29413 * driver.cs: Add --timestamp, to see where the compiler spends
29416 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29417 `this' in static code.
29419 (SimpleName.DoResolve): Implement in terms of a helper function
29420 that allows static-references to be passed upstream to
29423 (Expression.ResolveWithSimpleName): Resolve specially simple
29424 names when called by MemberAccess to implement the special
29427 (Expression.ImplicitReferenceConversion): Handle conversions from
29428 Null to reference types before others, as Null's type is
29431 * expression.cs (Invocation.EmitCall): Handle the special case of
29432 calling methods declared on a reference type from a ValueType
29433 (Base classes System.Object and System.Enum)
29435 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29436 the left hand side is a TypeExpr, not on every enumeration.
29438 (Binary.Resolve): If types are reference types, then do a cast to
29439 object on operators != and == of both arguments.
29441 * typemanager.cs (FindMembers): Extract instance and static
29442 members if requested.
29444 * interface.cs (PopulateProperty): Use void_type instead of null
29445 as the return type for the setter method.
29447 (PopulateIndexer): ditto.
29449 2001-12-27 Ravi Pratap <ravi@ximian.com>
29451 * support.cs (ReflectionParameters): Fix minor bug where we
29452 were examining the wrong parameter for the ParamArray attribute.
29454 Cope with requests for the type of the parameter at position
29455 greater than the params parameter's. We now return the element
29456 type of the params array as that makes more sense.
29458 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29459 accordingly as we no longer have to extract the element type
29462 (Invocation.OverloadResolve): Update.
29464 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29466 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29467 against IEnumerator, test whether the return value is a descendant
29468 of the IEnumerator interface.
29470 * class.cs (Indexer.Define): Use an auxiliary method to implement
29471 the other bits of the method definition. Begin support for
29472 explicit interface implementation.
29474 (Property.DefineMethod): Use TypeManager.void_type instead of null
29475 for an empty return value.
29477 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29479 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29480 dealing with a FieldExpr which is composed of a FieldBuilder, in
29481 the code path we did extract the constant, but we should have
29482 obtained the underlying value to be able to cast it (otherwise we
29483 end up in an infinite loop, this is what Ravi was running into).
29485 (ArrayCreation.UpdateIndices): Arrays might be empty.
29487 (MemberAccess.ResolveMemberAccess): Add support for section
29488 14.5.4.1 that deals with the special case of E.I when E is a type
29489 and something else, that I can be a reference to a static member.
29491 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29492 handle a particular array type to create byte blobs, it is just
29493 something we dont generate byteblobs for.
29495 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29498 * location.cs (Push): remove the key from the hashtable that we
29499 are about to add. This happens for empty files.
29501 * driver.cs: Dispose files after we have parsed them.
29503 (tokenize): new function that only runs the tokenizer on its
29504 input, for speed testing.
29506 2001-12-26 Ravi Pratap <ravi@ximian.com>
29508 * class.cs (Event.Define): Define the private field only if there
29509 are no accessors defined.
29511 * expression.cs (ResolveMemberAccess): If there is no associated
29512 field with the event, that means we have an event defined with its
29513 own accessors and we should flag error cs0070 since transforming
29514 ourselves into a field is not valid in that case.
29516 * ecore.cs (SimpleName.DoResolve): Same as above.
29518 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29519 and charset to sane values.
29521 2001-12-25 Ravi Pratap <ravi@ximian.com>
29523 * assign.cs (DoResolve): Perform check on events only if they
29524 are being accessed outside the declaring type.
29526 * cs-parser.jay (event_declarations): Update rules to correctly
29527 set the type of the implicit parameter etc.
29529 (add_accessor, remove_accessor): Set current local parameters.
29531 * expression.cs (Binary): For delegate addition and subtraction,
29532 cast the return value from the method into the appropriate delegate
29535 2001-12-24 Ravi Pratap <ravi@ximian.com>
29537 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29538 of these as the workaround is unnecessary.
29540 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29541 delegate data - none of that is needed at all.
29543 Re-write bits to extract the instance expression and the delegate method
29546 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29549 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29550 of attaching attributes instead of duplicating code everywhere.
29552 * everywhere : Update code to do attribute emission using the above method.
29554 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29556 * expression.cs (IsParamsMethodApplicable): if there are not
29557 parameters, return immediately.
29559 * ecore.cs: The 0 literal can be implicity converted to an enum
29562 (SimpleName.DoResolve): First lookup the type, then lookup the
29565 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29566 want to get its address. If the InstanceExpression is not
29567 addressable, store the result in a temporary variable, then get
29570 * codegen.cs: Only display 219 errors on warning level or above.
29572 * expression.cs (ArrayAccess): Make it implement the
29573 IMemoryLocation interface.
29575 (Binary.DoResolve): handle the operator == (object a, object b)
29576 and operator != (object a, object b) without incurring into a
29577 BoxedCast (because 5 != o should never be performed).
29579 Handle binary enumerator operators.
29581 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29582 value type, otherwise use Ldelem_ref.
29584 Use precomputed names;
29586 (AddressOf): Implement address of
29588 * cs-parser.jay (labeled_statement): Fix recursive block
29589 addition by reworking the production.
29591 * expression.cs (New.DoEmit): New has a special case:
29593 If we are dealing with a ValueType, we have a few
29594 situations to deal with:
29596 * The target of New is a ValueType variable, that is
29597 easy, we just pass this as the variable reference
29599 * The target of New is being passed as an argument,
29600 to a boxing operation or a function that takes a
29603 In this case, we need to create a temporary variable
29604 that is the argument of New.
29607 2001-12-23 Ravi Pratap <ravi@ximian.com>
29609 * rootcontext.cs (LookupType): Check that current_type is not null before
29610 going about looking at nested types.
29612 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29613 not implement the IAssignMethod interface any more.
29615 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29616 where we tranform them into FieldExprs if they are being resolved from within
29617 the declaring type.
29619 * ecore.cs (SimpleName.DoResolve): Do the same here.
29621 * assign.cs (DoResolve, Emit): Clean up code considerably.
29623 * ../errors/bug10.cs : Add.
29625 * ../errors/cs0070.cs : Add.
29627 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29629 * assign.cs : Get rid of EventIsLocal everywhere.
29631 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29633 * ecore.cs (ConvertIntLiteral): finished the implementation.
29635 * statement.cs (SwitchLabel): Convert the value we are using as a
29636 key before looking up the table.
29638 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29640 * codegen.cs (EmitTopBlock): Require a Location argument now.
29642 * cs-parser.jay (constructor_declarator): We need to setup
29643 current_local_parameters before we parse the
29644 opt_constructor_initializer, to allow the variables to be bound
29645 to the constructor arguments.
29647 * rootcontext.cs (LookupType): First lookup nested classes in our
29648 class and our parents before we go looking outside our class.
29650 * expression.cs (ConstantFold): Extract/debox the values at the
29653 * rootcontext.cs (EmitCode): Resolve the constants first before we
29654 resolve the types. This is not really needed, but it helps debugging.
29656 * statement.cs: report location.
29658 * cs-parser.jay: pass location to throw statement.
29660 * driver.cs: Small bug fix.
29662 * report.cs: Updated format to be 4-zero filled digits.
29664 2001-12-22 Ravi Pratap <ravi@ximian.com>
29666 * expression.cs (CheckIndices): Fix minor bug where the wrong
29667 variable was being referred to ;-)
29669 (DoEmit): Do not call EmitStaticInitializers when the
29670 underlying type is System.Object.
29672 2001-12-21 Ravi Pratap <ravi@ximian.com>
29674 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29675 and do the usual workaround for SRE.
29677 * class.cs (MyEventBuilder.EventType): New member to get at the type
29678 of the event, quickly.
29680 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29682 * assign.cs (Assign.DoResolve): Handle the case when the target
29683 is an EventExpr and perform the necessary checks.
29685 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29688 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29690 (EventExpr): Set the type in the constructor itself since we
29691 are meant to be born fully resolved.
29693 (EventExpr.Define): Revert code I wrote earlier.
29695 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29696 instance expression is null. The instance expression is a This in that case
29697 or a null, depending on whether it is a static method or not.
29699 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29700 refers to more than one method.
29702 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29703 and accordingly flag errors.
29705 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29707 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29709 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29711 * location.cs (ToString): Provide useful rutine.
29713 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29715 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29716 objects, return the actual integral boxed.
29718 * statement.cs (SwitchLabel): define an ILLabel for each
29721 (Switch.CheckSwitch): If the value is a Literal, extract
29722 the underlying literal.
29724 Also in the unused hashtable we had, add the SwitchLabel so we can
29725 quickly look this value up.
29727 * constant.cs: Implement a bunch of new constants. Rewrite
29728 Literal based on this. Made changes everywhere to adapt to this.
29730 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29731 dereferencing array only once, and also copes with enumrations.
29733 bytes are two bytes wide, not one.
29735 (Cast): Perform constant conversions.
29737 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29738 wrappers to the literals here.
29740 * expression.cs (DoNumericPromotions): long literals can converted
29741 to ulong implicity (this is taken care of elsewhere, but I was
29742 missing this spot).
29744 * ecore.cs (Expression.Literalize): Make the return type Literal,
29745 to improve type checking.
29747 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29749 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29751 * literal.cs: Revert code from ravi that checked the bounds. The
29752 bounds are sane by the definition of the type itself.
29754 * typemanager.cs: Fix implementation of ImplementsInterface. We
29755 need to actually look up in our parent hierarchy for interfaces
29758 * const.cs: Use the underlying type for enumerations
29760 * delegate.cs: Compute the basename for the delegate creation,
29761 that should fix the delegate test case, and restore the correct
29762 Type Lookup semantics in rootcontext
29764 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29765 referencing a nested type with the Reflection API is using the "+"
29768 * cs-parser.jay: Do not require EOF token at the end.
29770 2001-12-20 Ravi Pratap <ravi@ximian.com>
29772 * rootcontext.cs (LookupType): Concatenate type names with
29773 a '.' instead of a '+' The test suite passes again.
29775 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29776 field of the enumeration.
29778 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29779 the case when the member is an EventExpr.
29781 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29782 static has an associated instance expression.
29784 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29786 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29788 * class.cs (Event.Define): Register event and perform appropriate checks
29791 We define the Add and Remove methods even if the use provides none because
29792 in that case, we provide default implementations ourselves.
29794 Define a private field of the type of the event. This is done by the CSC compiler
29795 and we should be doing it too ;-)
29797 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29798 More methods we use in code we generate.
29800 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29803 (InitCoreTypes): Update accordingly for the above.
29805 * class.cs (Event.Emit): Generate code for default accessors that we provide
29807 (EmitDefaultMethod): Do the job in the above.
29809 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29812 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29814 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29815 builders even if we were missing one.
29817 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29818 pass the Basename as our class name instead of the Name. The
29819 basename will be correctly composed for us.
29821 * parameter.cs (Paramters): Now takes a Location argument.
29823 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29824 make all the code call directly LookupType in RootContext and take
29825 this chance to pass the Location information everywhere.
29827 * Everywhere: pass Location information.
29829 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29831 * class.cs (Constructor.Define): Updated way of detecting the
29832 length of the parameters.
29834 (TypeContainer.DefineType): Use basename as the type name for
29837 (TypeContainer.Define): Do not recursively define types here, as
29838 definition is taken care in order by the RootContext.
29840 * tree.cs: Keep track of namespaces in a per-file basis.
29842 * parameter.cs (Parameter.ComputeSignature): Update to use
29845 (Parameters.GetSignature): ditto.
29847 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29848 instead of a TypeContainer.
29850 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29851 resolve names. Because we need to be resolve in our context, not
29854 * driver.cs: Implement response files.
29856 * class.cs (TypeContainer.DefineType): If we are defined, do not
29857 redefine ourselves.
29859 (Event.Emit): Emit the code for add/remove handlers.
29860 (Event.Define): Save the MethodBuilders for add/remove.
29862 * typemanager.cs: Use pair here too.
29864 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29865 DictionaryEntry requires the first argument to be non-null.
29867 (enum_declaration): Compute full name for registering the
29870 (delegate_declaration): Instead of using
29871 formal_parameter_list, use opt_formal_parameter_list as the list
29874 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29875 (EventParsing): New property that controls whether `add' and
29876 `remove' are returned as tokens or identifiers (for events);
29878 2001-12-19 Ravi Pratap <ravi@ximian.com>
29880 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29881 use MyEventBuilder only and let it wrap the real builder for us.
29883 (MyEventBuilder): Revamp constructor etc.
29885 Implement all operations that we perform on EventBuilder in precisely the same
29888 (FindMembers): Update to use the EventBuilder member.
29890 (Event.Emit): Update accordingly.
29892 2001-12-18 Ravi Pratap <ravi@ximian.com>
29894 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29895 by calling the appropriate methods.
29897 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29900 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29902 2001-12-17 Ravi Pratap <ravi@ximian.com>
29904 * delegate.cs (Delegate.Populate): Check that the return type
29905 and various parameters types are indeed accessible.
29907 * class.cs (Constructor.Define): Same here.
29909 (Field.Define): Ditto.
29911 (Event.Define): Ditto.
29913 (Operator.Define): Check that the underlying Method defined itself
29914 correctly - so it's MethodBuilder should not be null.
29916 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29917 expression happens to be null.
29919 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29920 members but as of now we don't seem to be able to do anything really useful with it.
29922 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29923 not the EventBuilder.
29925 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29927 * cs-tokenizer.cs: Add support for defines.
29928 Add support for #if, #elif, #else, #endif
29930 (eval_var): evaluates a variable.
29931 (eval): stubbed for evaluating functions.
29933 * cs-parser.jay: Pass the defines information
29935 * driver.cs: Add --define command line option.
29937 * decl.cs: Move MemberCore here.
29939 Make it the base class for DeclSpace. This allows us to catch and
29940 report 108 and 109 for everything now.
29942 * class.cs (TypeContainer.Define): Extract all the members
29943 before populating and emit the warning 108 (new keyword required
29944 to override) instead of having each member implement this.
29946 (MemberCore.Define): New abstract method, we will be using this in
29947 the warning reporting engine in Populate.
29949 (Operator.Define): Adjust to new MemberCore protocol.
29951 * const.cs (Const): This does not derive from Expression, it is a
29952 temporary object we use to create fields, it is a MemberCore.
29954 * class.cs (Method.Define): Allow the entry point to be in a
29957 * driver.cs: Rewrite the argument handler to clean it up a bit.
29959 * rootcontext.cs: Made it just an auxiliary namespace feature by
29960 making everything static.
29962 * driver.cs: Adapt code to use RootContext type name instead of
29965 * delegate.cs: Remove RootContext argument.
29967 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29970 * class.cs (Event.Define): The lookup can fail.
29972 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29974 * expression.cs: Resolve the this instance before invoking the code.
29976 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29978 * cs-parser.jay: Add a production in element_access that allows
29979 the thing to become a "type" reference. This way we can parse
29980 things like "(string [])" as a type.
29982 Note that this still does not handle the more complex rules of
29986 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29988 * ecore.cs: (CopyNewMethods): new utility function used to
29989 assemble the list of methods from running FindMembers.
29991 (MemberLookup): Rework FindMembers so that
29993 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29995 * class.cs (TypeContainer): Remove Delegates who fail to be
29998 * delegate.cs (Populate): Verify that we dont get null return
29999 values. TODO: Check for AsAccessible.
30001 * cs-parser.jay: Use basename to emit error 574 (destructor should
30002 have the same name as container class), not the full name.
30004 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
30005 possible representation.
30007 Also implements integer type suffixes U and L.
30009 2001-12-15 Miguel de Icaza <miguel@ximian.com>
30011 * expression.cs (ArrayCreation.DoResolve): We need to do the
30012 argument resolution *always*.
30014 * decl.cs: Make this hold the namespace. Hold the root context as
30016 (LookupType): Move here.
30018 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
30020 * location.cs (Row, Name): Fixed the code, it was always returning
30021 references to the first file.
30023 * interface.cs: Register properties defined through interfaces.
30025 * driver.cs: Add support for globbing on the command line
30027 * class.cs (Field): Make it derive from MemberCore as well.
30030 2001-12-15 Ravi Pratap <ravi@ximian.com>
30032 * class.cs (Event::Define): Check that the type of the event is a delegate
30033 type else flag error #66.
30035 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
30038 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
30039 values of EntryPoint, CharSet etc etc.
30041 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
30043 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
30044 be null and we should ignore this. I am not sure if this is really clean. Apparently,
30045 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
30046 which needs this to do its work.
30048 * ../errors/cs0066.cs : Add.
30050 2001-12-14 Miguel de Icaza <miguel@ximian.com>
30052 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
30055 * class.cs: (MethodSignature.MethodSignature): Removed hack that
30056 clears out the parameters field.
30057 (MemberSignatureCompare): Cleanup
30059 (MemberCore): New base class used to share code between MethodCore
30062 (RegisterRequiredImplementations) BindingFlags.Public requires
30063 either BindingFlags.Instace or Static. Use instance here.
30065 (Property): Refactored code to cope better with the full spec.
30067 * parameter.cs (GetParameterInfo): Return an empty array instead
30070 * class.cs (Property): Abstract or extern properties have no bodies.
30072 * parameter.cs (GetParameterInfo): return a zero-sized array.
30074 * class.cs (TypeContainer.MethodModifiersValid): Move all the
30075 method modifier validation to the typecontainer so we can reuse
30076 this on properties.
30078 (MethodCore.ParameterTypes): return an empty sized array of types.
30080 (Property.Define): Test property modifier validity.
30082 Add tests for sealed/override too.
30084 (Method.Emit): abstract or extern methods have no bodies.
30086 2001-12-14 Ravi Pratap <ravi@ximian.com>
30088 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
30091 (Method::Define, ::Emit): Modify accordingly.
30093 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
30095 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
30097 * makefile: Pass in /unsafe.
30099 2001-12-13 Miguel de Icaza <miguel@ximian.com>
30101 * class.cs (MakeKey): Kill routine.
30103 * class.cs (TypeContainer.Define): Correctly define explicit
30104 method implementations (they require the full interface name plus
30107 * typemanager.cs: Deply the PtrHashtable here and stop using the
30108 lame keys. Things work so much better.
30110 This of course broke everyone who depended on `RegisterMethod' to
30111 do the `test for existance' test. This has to be done elsewhere.
30113 * support.cs (PtrHashtable): A hashtable that avoid comparing with
30114 the object stupid Equals method (because, that like fails all over
30115 the place). We still do not use it.
30117 * class.cs (TypeContainer.SetRequiredInterface,
30118 TypeContainer.RequireMethods): Killed these two routines and moved
30119 all the functionality to RegisterRequiredImplementations.
30121 (TypeContainer.RegisterRequiredImplementations): This routine now
30122 registers all the implementations required in an array for the
30123 interfaces and abstract methods. We use an array of structures
30124 which can be computed ahead of time to reduce memory usage and we
30125 also assume that lookups are cheap as most classes will not
30126 implement too many interfaces.
30128 We also avoid creating too many MethodSignatures.
30130 (TypeContainer.IsInterfaceMethod): Update and optionally does not
30131 clear the "pending" bit if we find that there are problems with
30134 (TypeContainer.VerifyPendingMethods): Update to report errors of
30135 methods that look like implementations but are not.
30137 (TypeContainer.Define): Add support for explicit interface method
30140 2001-12-12 Miguel de Icaza <miguel@ximian.com>
30142 * typemanager.cs: Keep track of the parameters here instead of
30143 being a feature of the TypeContainer.
30145 * class.cs: Drop the registration of parameters here, as
30146 InterfaceMethods are also interface declarations.
30148 * delegate.cs: Register methods with the TypeManager not only with
30149 the TypeContainer. This code was buggy.
30151 * interface.cs: Full registation here.
30153 2001-12-11 Miguel de Icaza <miguel@ximian.com>
30155 * expression.cs: Remove reducer for binary expressions, it can not
30158 * const.cs: Put here the code that used to go into constant.cs
30160 * constant.cs: Put here the code for constants, this is a new base
30161 class for Literals.
30163 * literal.cs: Make Literal derive from Constant.
30165 2001-12-09 Miguel de Icaza <miguel@ximian.com>
30167 * statement.cs (Return.Emit): Report error 157 if the user
30168 attempts to return from a finally block.
30170 (Return.Emit): Instead of emitting a return, jump to the end of
30173 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
30174 LocalBuilder to store the result of the function. ReturnLabel is
30175 the target where we jump.
30178 2001-12-09 Radek Doulik <rodo@ximian.com>
30180 * cs-parser.jay: remember alias in current namespace
30182 * ecore.cs (SimpleName::DoResolve): use aliases for types or
30185 * class.cs (LookupAlias): lookup alias in my_namespace
30187 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
30189 (LookupAlias): lookup alias in this and if needed in parent
30192 2001-12-08 Miguel de Icaza <miguel@ximian.com>
30196 * rootcontext.cs: (ModuleBuilder) Made static, first step into
30197 making things static. I need this to avoid passing the
30198 TypeContainer when calling ParameterType.
30200 * support.cs (InternalParameters.ParameterType): Remove ugly hack
30201 that did string manipulation to compute the type and then call
30202 GetType. Use Parameter.ParameterType instead.
30204 * cs-tokenizer.cs: Consume the suffix for floating values.
30206 * expression.cs (ParameterReference): figure out whether this is a
30207 reference parameter or not. Kill an extra variable by computing
30208 the arg_idx during emission.
30210 * parameter.cs (Parameters.GetParameterInfo): New overloaded
30211 function that returns whether a parameter is an out/ref value or not.
30213 (Parameter.ParameterType): The type of the parameter (base,
30214 without ref/out applied).
30216 (Parameter.Resolve): Perform resolution here.
30217 (Parameter.ExternalType): The full type (with ref/out applied).
30219 * statement.cs (Using.Emit, Using.EmitExpression): Implement
30220 support for expressions on the using statement.
30222 2001-12-07 Miguel de Icaza <miguel@ximian.com>
30224 * statement.cs (Using.EmitLocalVariableDecls): Split the
30225 localvariable handling of the using statement.
30227 (Block.EmitMeta): Keep track of variable count across blocks. We
30228 were reusing slots on separate branches of blocks.
30230 (Try.Emit): Emit the general code block, we were not emitting it.
30232 Check the type of the declaration to be an IDisposable or
30233 something that can be implicity converted to it.
30235 Emit conversions if required.
30237 * ecore.cs (EmptyExpression): New utility class.
30238 (Expression.ImplicitConversionExists): New utility function.
30240 2001-12-06 Miguel de Icaza <miguel@ximian.com>
30242 * statement.cs (Using): Implement.
30244 * expression.cs (LocalVariableReference): Support read only variables.
30246 * statement.cs: Remove the explicit emit for the Leave opcode.
30247 (VariableInfo): Add a readonly field.
30249 2001-12-05 Miguel de Icaza <miguel@ximian.com>
30251 * ecore.cs (ConvCast): new class used to encapsulate the various
30252 explicit integer conversions that works in both checked and
30253 unchecked contexts.
30255 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30256 properly generate the overflow opcodes.
30258 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30260 * statement.cs: The correct type for the EmptyExpression is the
30261 element_type, not the variable type. Ravi pointed this out.
30263 2001-12-04 Ravi Pratap <ravi@ximian.com>
30265 * class.cs (Method::Define): Handle PInvoke methods specially
30266 by using DefinePInvokeMethod instead of the usual one.
30268 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30269 above to do the task of extracting information and defining the method.
30271 2001-12-04 Ravi Pratap <ravi@ximian.com>
30273 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30274 of the condition for string type.
30276 (Emit): Move that here.
30278 (ArrayCreation::CheckIndices): Keep string literals in their expression
30281 (EmitDynamicInitializers): Handle strings appropriately.
30283 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30285 * codegen.cs (EmitContext): Replace multiple variables with a
30286 single pointer to the current Switch statement.
30288 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30291 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30295 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30298 (Foreach.Emit): Foreach on arrays was not setting
30299 up the loop variables (for break/continue).
30301 (GotoCase): Semi-implented.
30303 2001-12-03 Ravi Pratap <ravi@ximian.com>
30305 * attribute.cs (CheckAttribute): Handle system attributes by using
30306 Attribute.GetAttributes to examine information we need.
30308 (GetValidPlaces): Same here.
30310 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30312 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30314 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30316 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30318 (Method::Emit): Handle the case when we are a PInvoke method.
30320 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30322 * expression.cs: Use ResolveWithSimpleName on compound names.
30324 2001-12-02 Ravi Pratap <ravi@ximian.com>
30326 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30327 before trying to reduce it.
30329 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30331 * constant.cs (LookupConstantValue): Implement.
30333 (EmitConstant): Use the above in emitting the constant.
30335 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30336 that are user-defined by doing a LookupConstantValue on them.
30338 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30341 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30343 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30345 (BaseAccess.DoResolve): Implement.
30347 (MemberAccess.DoResolve): Split this routine into a
30348 ResolveMemberAccess routine that can be used independently
30350 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30352 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30353 As that share bits of the implementation. Is returns a boolean,
30354 while As returns the Type that is being probed.
30356 2001-12-01 Ravi Pratap <ravi@ximian.com>
30358 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30359 instead of a Literal - much easier.
30361 (EnumInTransit): Remove - utterly useless :-)
30363 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30365 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30367 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30368 chain when we have no associated expression.
30370 2001-11-30 Ravi Pratap <ravi@ximian.com>
30372 * constant.cs (Define): Use Location while reporting the errror.
30374 Also emit a warning when 'new' is used and there is no inherited
30377 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30380 (LookupEnumValue): Implement to lookup an enum member's value and define it
30383 (Populate): Re-write accordingly to use the above routine.
30385 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30387 * expression.cs (This): Fix prototype for DoResolveLValue to
30388 override the base class DoResolveLValue.
30390 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30393 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30394 (we need to load the address of the field here). This fixes
30397 (FieldExpr.DoResolveLValue): Call the DoResolve
30398 function to initialize the Instance expression.
30400 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30401 correctly the GetEnumerator operation on a value type.
30403 * cs-parser.jay: Add more simple parsing error catches.
30405 * statement.cs (Switch): Add support for string switches.
30406 Handle null specially.
30408 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30410 2001-11-28 Ravi Pratap <ravi@ximian.com>
30412 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30414 (declare_local_constant): New helper function.
30416 * statement.cs (AddConstant): Keep a separate record of constants
30418 (IsConstant): Implement to determine if a variable is a constant.
30420 (GetConstantExpression): Implement.
30422 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30424 * statement.cs (IsVariableDefined): Re-write.
30426 2001-11-27 Ravi Pratap <ravi@ximian.com>
30428 * class.cs (TypeContainer::FindMembers): Look for constants
30429 in the case when we are looking for MemberTypes.Field
30431 * expression.cs (MemberAccess::DoResolve): Check that in the
30432 case we are a FieldExpr and a Literal, we are not being accessed
30433 by an instance reference.
30435 * cs-parser.jay (local_constant_declaration): Implement.
30437 (declaration_statement): Implement for constant declarations.
30439 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30441 * statement.cs (Switch): Catch double defaults.
30443 (Switch): More work on the switch() statement
30444 implementation. It works for integral values now, need to finish
30448 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30450 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30451 integer literals into other integer literals. To be used by
30454 2001-11-24 Ravi Pratap <ravi@ximian.com>
30456 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30459 (EmitDynamicInitializers): Cope with the above since we extract data
30460 directly from ArrayData now.
30462 (ExpectInitializers): Keep track of whether initializers are mandatory
30465 (Bounds): Make it a hashtable to prevent the same dimension being
30466 recorded for every element in that dimension.
30468 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30471 Also fix bug which was causing the indices to be emitted in the reverse
30474 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30476 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30477 unfinished. They do not work, because the underlying code is
30480 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30482 * cs-parser.jay: Remove bogus fixme.
30484 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30485 on Switch statement.
30487 2001-11-23 Ravi Pratap <ravi@ximian.com>
30489 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30492 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30493 parameter. Apparently, any expression is allowed.
30495 (ValidateInitializers): Update accordingly.
30497 (CheckIndices): Fix some tricky bugs thanks to recursion.
30499 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30500 I was being completely brain-dead.
30502 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30503 and re-write acordingly.
30505 (DelegateInvocation): Re-write accordingly.
30507 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30509 (MakeByteBlob): Handle types more correctly.
30511 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30512 initialization from expressions but it is incomplete because I am a complete
30515 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30517 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30518 on If. Basically, we have to return `true' (ie, we do return to
30519 our caller) only if both branches of the if return.
30521 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30522 short-circuit operators, handle them as short circuit operators.
30524 (Cast.DoResolve): Resolve type.
30525 (Cast.Cast): Take an expression as the target type.
30527 * cs-parser.jay (cast_expression): Remove old hack that only
30528 allowed a limited set of types to be handled. Now we take a
30529 unary_expression and we resolve to a type during semantic
30532 Use the grammar productions from Rhys to handle casts (this is
30533 not complete like Rhys syntax yet, we fail to handle that corner
30534 case that C# has regarding (-x), but we will get there.
30536 2001-11-22 Ravi Pratap <ravi@ximian.com>
30538 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30539 field which is an array type.
30541 * cs-parser.jay (declare_local_variables): Support array initialization too.
30543 * typemanager.cs (MakeKey): Implement.
30545 (everywhere): Use the above appropriately.
30547 * cs-parser.jay (for_statement): Update for array initialization while
30548 declaring variables.
30550 * ecore.cs : The error message was correct, it's the variable's names that
30551 were misleading ;-) Make the code more readable.
30553 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30554 the correct type etc.
30556 (ConvertExplicit): Handle Enum types by examining the underlying type.
30558 2001-11-21 Ravi Pratap <ravi@ximian.com>
30560 * parameter.cs (GetCallingConvention): Always return
30561 CallingConventions.Standard for now.
30563 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30565 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30566 and `r' after calling DoNumericPromotions.
30568 * ecore.cs: Fix error message (the types were in the wrong order).
30570 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30571 BindingFlags.Instance as well
30573 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30574 implicit int literal conversion in an empty cast so that we
30575 propagate the right type upstream.
30577 (UnboxCast): new class used to unbox value types.
30578 (Expression.ConvertExplicit): Add explicit type conversions done
30581 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30582 the target type before applying the implicit LongLiterals to ULong
30585 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30587 * cs-parser.jay (for_statement): Reworked the way For works: now
30588 we declare manually any variables that are introduced in
30589 for_initializer to solve the problem of having out-of-band code
30590 emition (that is what got for broken).
30592 (declaration_statement): Perform the actual variable declaration
30593 that used to be done in local_variable_declaration here.
30595 (local_variable_declaration): Do not declare anything, just pass
30596 the information on a DictionaryEntry
30598 2001-11-20 Ravi Pratap <ravi@ximian.com>
30600 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30601 re-write of the logic to now make it recursive.
30603 (UpdateIndices): Re-write accordingly.
30605 Store element data in a separate ArrayData list in the above methods.
30607 (MakeByteBlob): Implement to dump the array data into a byte array.
30609 2001-11-19 Ravi Pratap <ravi@ximian.com>
30611 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30614 * constant.cs (Define): Implement.
30616 (EmitConstant): Re-write fully.
30618 Pass in location info.
30620 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30623 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30624 DictionaryEntry since we need location info too.
30626 (constant_declaration): Update accordingly.
30628 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30629 code into another method : UpdateIndices.
30631 2001-11-18 Ravi Pratap <ravi@ximian.com>
30633 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30634 some type checking etc.
30636 2001-11-17 Ravi Pratap <ravi@ximian.com>
30638 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30639 bits to provide dimension info if the user skips doing that.
30641 Update second constructor to store the rank correctly.
30643 2001-11-16 Ravi Pratap <ravi@ximian.com>
30645 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30646 and try to implement.
30648 * ../errors/cs0150.cs : Add.
30650 * ../errors/cs0178.cs : Add.
30652 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30654 * statement.cs: Implement foreach on multi-dimensional arrays.
30656 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30657 name of the params argument.
30659 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30660 initializing the array.
30662 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30663 we can use this elsewhere.
30665 * statement.cs: Finish implementation of foreach for single
30668 * cs-parser.jay: Use an out-of-band stack to pass information
30669 around, I wonder why I need this.
30671 foreach_block: Make the new foreach_block the current_block.
30673 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30674 function used to return a static Parameters structure. Used for
30675 empty parameters, as those are created very frequently.
30677 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30679 2001-11-15 Ravi Pratap <ravi@ximian.com>
30681 * interface.cs : Default modifier is private, not public. The
30682 make verify test passes again.
30684 2001-11-15 Ravi Pratap <ravi@ximian.com>
30686 * support.cs (ReflectionParameters): Fix logic to determine
30687 whether the last parameter is a params one. Test 9 passes again.
30689 * delegate.cs (Populate): Register the builders we define with
30690 RegisterParameterForBuilder. Test 19 passes again.
30692 * cs-parser.jay (property_declaration): Reference $6 instead
30693 of $$ to get at the location.
30695 (indexer_declaration): Similar stuff.
30697 (attribute): Ditto.
30699 * class.cs (Property): Register parameters for the Get and Set methods
30700 if they exist. Test 23 passes again.
30702 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30703 call to EmitArguments as we are sure there aren't any params arguments.
30704 Test 32 passes again.
30706 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30707 IndexOutOfRangeException.
30709 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30710 Test 33 now passes again.
30712 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30714 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30715 broke a bunch of things. Will have to come up with a better way
30716 of tracking locations.
30718 * statement.cs: Implemented foreach for single dimension arrays.
30720 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30722 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30723 an error. This removes the lookup from the critical path.
30725 * cs-parser.jay: Removed use of temporary_loc, which is completely
30728 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30730 * support.cs (ReflectionParameters.ParameterModifier): Report
30731 whether the argument is a PARAMS argument or not.
30733 * class.cs: Set the attribute `ParamArrayAttribute' on the
30734 parameter argument.
30736 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30737 and cons_param_array_attribute (ConstructorInfo for
30738 ParamArrayAttribute).,
30740 * codegen.cs: Emit the return using the `Return' statement, that
30741 way we can report the error correctly for missing return values.
30743 * class.cs (Method.Emit): Clean up.
30745 * expression.cs (Argument.Resolve): Take another argument: the
30746 location where this argument is used. Notice that this is not
30747 part of the "Argument" class as to reduce the size of the
30748 structure (we know the approximate location anyways).
30750 Test if the argument is a variable-reference, if not, then
30751 complain with a 206.
30753 (Argument.Emit): Emit addresses of variables.
30755 (Argument.FullDesc): Simplify.
30757 (Invocation.DoResolve): Update for Argument.Resolve.
30759 (ElementAccess.DoResolve): ditto.
30761 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30762 method should be virtual, as this method is always virtual.
30764 (NewDelegate.DoResolve): Update for Argument.Resolve.
30766 * class.cs (ConstructorInitializer.DoResolve): ditto.
30768 * attribute.cs (Attribute.Resolve): ditto.
30770 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30772 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30774 * expression.cs (ParameterReference): Drop IStackStorage and implement
30775 IAssignMethod instead.
30777 (LocalVariableReference): ditto.
30779 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30780 IAssignMethod instead.
30782 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30784 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30785 enumerations that are used in heavily used structures derive from
30786 byte in a laughable and pathetic attempt to reduce memory usage.
30787 This is the kind of pre-optimzations that you should not do at
30788 home without adult supervision.
30790 * expression.cs (UnaryMutator): New class, used to handle ++ and
30791 -- separatedly from the other unary operators. Cleans up the
30792 code, and kills the ExpressionStatement dependency in Unary.
30794 (Unary): Removed `method' and `Arguments' from this class, making
30795 it smaller, and moving it all to SimpleCall, so I can reuse this
30796 code in other locations and avoid creating a lot of transient data
30797 strucutres when not required.
30799 * cs-parser.jay: Adjust for new changes.
30801 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30803 * enum.cs (Enum.Populate): If there is a failure during
30806 * cs-parser.jay (opt_enum_base): we used to catch type errors
30807 here, but this is really incorrect. The type error should be
30808 catched during semantic analysis.
30810 2001-12-11 Ravi Pratap <ravi@ximian.com>
30812 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30813 current_local_parameters as expected since I, in my stupidity, had forgotten
30816 * attribute.cs (GetValidPlaces): Fix stupid bug.
30818 * class.cs (Method::Emit): Perform check on applicability of attributes.
30820 (Constructor::Emit): Ditto.
30822 (Field::Emit): Ditto.
30824 (Field.Location): Store location information.
30826 (Property, Event, Indexer, Operator): Ditto.
30828 * cs-parser.jay (field_declaration): Pass in location for each field.
30830 * ../errors/cs0592.cs : Add.
30832 2001-11-12 Ravi Pratap <ravi@ximian.com>
30834 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30836 (InitCoreTypes): Update accordingly.
30838 (RegisterAttrType, LookupAttr): Implement.
30840 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30841 info about the same.
30843 (Resolve): Update to populate the above as necessary.
30845 (Error592): Helper.
30847 (GetValidPlaces): Helper to the above.
30849 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30851 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30853 2001-11-12 Ravi Pratap <ravi@ximian.com>
30855 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30857 * ../errors/cs0617.cs : Add.
30859 2001-11-11 Ravi Pratap <ravi@ximian.com>
30861 * enum.cs (Emit): Rename to Populate to be more consistent with what
30862 we expect it to do and when exactly it is called.
30864 * class.cs, rootcontext.cs : Update accordingly.
30866 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30867 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30869 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30871 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30872 of a fieldinfo using the above, when dealing with a FieldBuilder.
30874 2001-11-10 Ravi Pratap <ravi@ximian.com>
30876 * ../errors/cs0031.cs : Add.
30878 * ../errors/cs1008.cs : Add.
30880 * ../errrors/cs0543.cs : Add.
30882 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30885 (FindMembers): Implement.
30887 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30888 enums and delegates too.
30890 (enum_types): Rename to builder_to_enum.
30892 (delegate_types): Rename to builder_to_delegate.
30894 * delegate.cs (FindMembers): Implement.
30896 2001-11-09 Ravi Pratap <ravi@ximian.com>
30898 * typemanager.cs (IsEnumType): Implement.
30900 * enum.cs (Emit): Re-write parts to account for the underlying type
30901 better and perform checking etc.
30903 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30904 of the underlying type.
30906 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30909 * enum.cs (error31): Helper to report error #31.
30911 * cs-parser.jay (enum_declaration): Store location of each member too.
30913 * enum.cs (member_to_location): New hashtable.
30915 (AddEnumMember): Update location hashtable.
30917 (Emit): Use the location of each member while reporting errors.
30919 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30921 * cs-parser.jay: A for_initializer if is a
30922 local_variable_declaration really ammount to have an implicit
30923 block with the variable declaration and no initializer for for.
30925 * statement.cs (For.Emit): Cope with null initializers.
30927 This fixes the infinite loop on for initializers.
30929 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30931 * enum.cs: More cleanup.
30933 * ecore.cs: Remove dead code.
30935 * class.cs (Property.Emit): More simplification.
30936 (Event.Emit): ditto.
30938 Reworked to have less levels of indentation.
30940 2001-11-08 Ravi Pratap <ravi@ximian.com>
30942 * class.cs (Property): Emit attributes.
30952 * enum.cs (Emit): Ditto.
30954 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30957 * class.cs (Field, Event, etc.): Move attribute generation into the
30958 Emit method everywhere.
30960 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30961 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30962 as we had no way of defining nested enums !
30964 * rootcontext.cs : Adjust code accordingly.
30966 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30968 2001-11-07 Ravi Pratap <ravi@ximian.com>
30970 * expression.cs (EvalConstantExpression): Move into ecore.cs
30972 * enum.cs (Enum): Rename some members and make them public and readonly
30973 according to our convention.
30975 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30978 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30980 (Enum::Emit): Write a simple version for now which doesn't try to compute
30981 expressions. I shall modify this to be more robust in just a while.
30983 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30985 (TypeContainer::CloseType): Create the Enum types too.
30987 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30989 * expression.cs (EvalConstantExpression): Get rid of completely.
30991 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30992 user-defined values and other cases.
30994 (IsValidEnumLiteral): Helper function.
30996 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30997 out there in the case we had a literal FieldExpr.
30999 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
31001 (Literalize): Revamp a bit to take two arguments.
31003 (EnumLiteral): New class which derives from Literal to wrap enum literals.
31005 2001-11-06 Ravi Pratap <ravi@ximian.com>
31007 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
31009 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
31011 (Resolve): Use the above to ensure we have proper initializers.
31013 2001-11-05 Ravi Pratap <ravi@ximian.com>
31015 * expression.cs (Expression::EvalConstantExpression): New method to
31016 evaluate constant expressions.
31018 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
31020 2001-11-07 Miguel de Icaza <miguel@ximian.com>
31022 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
31025 (Binary.ResolveOperator): Handle operator != (object a, object b)
31026 and operator == (object a, object b);
31028 (Binary.DoNumericPromotions): Indicate whether the numeric
31029 promotion was possible.
31031 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
31034 Made the ArrayAccess implement interface IAssignMethod instead of
31035 IStackStore as the order in which arguments are passed reflects
31038 * assign.cs: Instead of using expr.ExprClass to select the way of
31039 assinging, probe for the IStackStore/IAssignMethod interfaces.
31041 * typemanager.cs: Load InitializeArray definition.
31043 * rootcontext.cs (RootContext.MakeStaticData): Used to define
31044 static data that can be used to initialize arrays.
31046 2001-11-05 Miguel de Icaza <miguel@ximian.com>
31048 * expression.cs: Handle operator== and operator!= for booleans.
31050 (Conditioal.Reduce): Implement reducer for the ?: operator.
31052 (Conditional.Resolve): Implement dead code elimination.
31054 (Binary.Resolve): Catch string literals and return a new
31055 concatenated string.
31057 (Unary.Reduce): Implement reduction of unary expressions.
31059 * ecore.cs: Split out the expression core handling here.
31061 (Expression.Reduce): New method used to perform constant folding
31062 and CSE. This is needed to support constant-expressions.
31064 * statement.cs (Statement.EmitBoolExpression): Pass true and false
31065 targets, and optimize for !x.
31067 2001-11-04 Ravi Pratap <ravi@ximian.com>
31069 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
31070 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
31071 set custom atttributes.
31073 * literal.cs (Literal::GetValue): New abstract method to return the actual
31074 value of the literal, cast as an object.
31076 (*Literal): Implement GetValue method.
31078 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
31079 expressions to the arraylist but objects of type Argument.
31081 * class.cs (TypeContainer::Emit): Emit our attributes too.
31083 (Method::Emit, Constructor::Emit): Ditto.
31085 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
31086 to be ignoring earlier.
31088 2001-11-03 Ravi Pratap <ravi@ximian.com>
31090 * attribute.cs (AttributeSection::Define): Implement to do the business
31091 of constructing a CustomAttributeBuilder.
31093 (Attribute): New trivial class. Increases readability of code.
31095 * cs-parser.jay : Update accordingly.
31097 (positional_argument_list, named_argument_list, named_argument): New rules
31099 (attribute_arguments): Use the above so that we are more correct.
31101 2001-11-02 Ravi Pratap <ravi@ximian.com>
31103 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
31104 to perform all checks for a method with a params parameter.
31106 (Invocation::OverloadResolve): Update to use the above method and therefore
31107 cope correctly with params method invocations.
31109 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
31112 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
31113 constructors in our parent too because we can't afford to miss out on
31116 * attribute.cs (AttributeSection): New name for the class Attribute
31118 Other trivial changes to improve readability.
31120 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
31121 use the new class names.
31123 2001-11-01 Ravi Pratap <ravi@ximian.com>
31125 * class.cs (Method::Define): Complete definition for params types too
31127 (Indexer::Define): Ditto.
31129 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
31130 Cope everywhere with a request for info about the array parameter.
31132 2001-11-01 Ravi Pratap <ravi@ximian.com>
31134 * tree.cs (RecordNamespace): Fix up to check for the correct key.
31136 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
31137 local_variable_type to extract the string corresponding to the type.
31139 (local_variable_type): Fixup the action to use the new helper method.
31141 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
31144 * expression.cs : Clean out code which uses the above.
31146 2001-10-31 Ravi Pratap <ravi@ximian.com>
31148 * typemanager.cs (RegisterMethod): Check if we already have an existing key
31149 and bale out if necessary by returning a false.
31151 (RegisterProperty): Ditto.
31153 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
31154 and print out appropriate error messages.
31156 * interface.cs (everywhere): Ditto.
31158 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
31159 location to constructor.
31161 * class.cs (Property, Event, Indexer): Update accordingly.
31163 * ../errors/cs111.cs : Added.
31165 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
31166 of a method, as laid down by the spec.
31168 (Invocation::OverloadResolve): Use the above method.
31170 2001-10-31 Ravi Pratap <ravi@ximian.com>
31172 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
31173 now take a TypeContainer and a Parameters object.
31175 (ParameterData): Modify return type of ParameterModifier method to be
31176 Parameter.Modifier and not a string.
31178 (ReflectionParameters, InternalParameters): Update accordingly.
31180 * expression.cs (Argument::GetParameterModifier): Same here.
31182 * support.cs (InternalParameters::ParameterType): Find a better way of determining
31183 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
31184 symbol in it at all so maybe this is only for now.
31186 2001-10-30 Ravi Pratap <ravi@ximian.com>
31188 * support.cs (InternalParameters): Constructor now takes an extra argument
31189 which is the actual Parameters class.
31191 (ParameterDesc): Update to provide info on ref/out modifiers.
31193 * class.cs (everywhere): Update call to InternalParameters to pass in
31194 the second argument too.
31196 * support.cs (ParameterData): Add ParameterModifier, which is a method
31197 to return the modifier info [ref/out etc]
31199 (InternalParameters, ReflectionParameters): Implement the above.
31201 * expression.cs (Argument::ParameterModifier): Similar function to return
31202 info about the argument's modifiers.
31204 (Invocation::OverloadResolve): Update to take into account matching modifiers
31207 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
31208 a new SetFormalParameters object which we pass to InternalParameters.
31210 2001-10-30 Ravi Pratap <ravi@ximian.com>
31212 * expression.cs (NewArray): Merge into the ArrayCreation class.
31214 2001-10-29 Ravi Pratap <ravi@ximian.com>
31216 * expression.cs (NewArray): Merge classes NewBuiltinArray and
31217 NewUserdefinedArray into one as there wasn't much of a use in having
31220 * expression.cs (Argument): Change field's name to ArgType from Type.
31222 (Type): New readonly property which returns the proper type, taking into
31223 account ref/out modifiers.
31225 (everywhere): Adjust code accordingly for the above.
31227 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
31228 whether we are emitting for a ref or out parameter.
31230 * expression.cs (Argument::Emit): Use the above field to set the state.
31232 (LocalVariableReference::Emit): Update to honour the flag and emit the
31235 * parameter.cs (Attributes): Set the correct flags for ref parameters.
31237 * expression.cs (Argument::FullDesc): New function to provide a full desc.
31239 * support.cs (ParameterData): Add method ParameterDesc to the interface.
31241 (ReflectionParameters, InternalParameters): Implement the above method.
31243 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
31246 (Invocation::FullMethodDesc): Ditto.
31248 2001-10-29 Miguel de Icaza <miguel@ximian.com>
31250 * cs-parser.jay: Add extra production for the second form of array
31253 * expression.cs (ArrayCreation): Update to reflect the above
31256 * Small changes to prepare for Array initialization.
31258 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31260 * typemanager.cs (ImplementsInterface): interface might be null;
31261 Deal with this problem;
31263 Also, we do store negative hits on the cache (null values), so use
31264 this instead of calling t.GetInterfaces on the type everytime.
31266 2001-10-28 Ravi Pratap <ravi@ximian.com>
31268 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31270 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31271 split functionality out into different classes.
31273 (New::FormArrayType): Move into NewBuiltinArray.
31275 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31278 (NewBuiltinArray): New class to handle creation of built-in arrays.
31280 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31281 account creation of one-dimensional arrays.
31283 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31285 (NewUserdefinedArray::DoResolve): Implement.
31287 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31289 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31290 we maintain inside the TypeManager. This is necessary to perform lookups on the
31293 (LookupType): Update to perform GetType on the module builders too.
31295 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31297 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31299 2001-10-23 Ravi Pratap <ravi@ximian.com>
31301 * expression.cs (New::DoResolve): Implement guts of array creation.
31303 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31305 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31307 * expression.cs: Fix bug I introduced lsat night that broke
31310 (Expression.Resolve): Report a 246 error (can not resolve name)
31311 if we find a SimpleName in the stream.
31313 (Expression.ResolveLValue): Ditto.
31315 (Expression.ResolveWithSimpleName): This function is a variant of
31316 ResolveName, this one allows SimpleNames to be returned without a
31317 warning. The only consumer of SimpleNames is MemberAccess
31319 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31321 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31322 might arrive here. I have my doubts that this is correct.
31324 * statement.cs (Lock): Implement lock statement.
31326 * cs-parser.jay: Small fixes to support `lock' and `using'
31328 * cs-tokenizer.cs: Remove extra space
31330 * driver.cs: New flag --checked, allows to turn on integer math
31333 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31334 Threading.Monitor.Exit
31336 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31338 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31339 Expression Class to be IndexerAccess.
31341 Notice that Indexer::DoResolve sets the eclass to Value.
31343 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31345 * class.cs (TypeContainer::Emit): Emit code for indexers.
31347 * assign.cs (IAssignMethod): New interface implemented by Indexers
31348 and Properties for handling assignment.
31350 (Assign::Emit): Simplify and reuse code.
31352 * expression.cs (IndexerAccess, PropertyExpr): Implement
31353 IAssignMethod, clean up old code.
31355 2001-10-22 Ravi Pratap <ravi@ximian.com>
31357 * typemanager.cs (ImplementsInterface): New method to determine if a type
31358 implements a given interface. Provides a nice cache too.
31360 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31363 (ConvertReferenceExplicit): Ditto.
31365 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31366 various methods, with correct names etc.
31368 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31369 Operator.UnaryNegation.
31371 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31372 we have a unary plus or minus operator.
31374 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31377 * everywhere : update accordingly.
31379 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31382 * class.cs (Method::Define): For the case where we are implementing a method
31383 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31384 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31386 2001-10-21 Ravi Pratap <ravi@ximian.com>
31388 * interface.cs (FindMembers): Implement to work around S.R.E
31391 * typemanager.cs (IsInterfaceType): Implement.
31393 (FindMembers): Update to handle interface types too.
31395 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31396 use IsAssignableFrom as that is not correct - it doesn't work.
31398 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31399 and accordingly override EmitStatement.
31401 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31402 using the correct logic :-)
31404 2001-10-19 Ravi Pratap <ravi@ximian.com>
31406 * ../errors/cs-11.cs : Add to demonstrate error -11
31408 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31410 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31411 then pass this as a hint to ResolveLValue.
31413 * expression.cs (FieldExpr): Add Location information
31415 (FieldExpr::LValueResolve): Report assignment to readonly
31418 (Expression::ExprClassFromMemberInfo): Pass location information.
31420 (Expression::ResolveLValue): Add new method that resolves an
31423 (Expression::DoResolveLValue): Default invocation calls
31426 (Indexers): New class used to keep track of indexers in a given
31429 (IStackStore): Renamed from LValue, as it did not really describe
31430 what this did. Also ResolveLValue is gone from this interface and
31431 now is part of Expression.
31433 (ElementAccess): Depending on the element access type
31435 * typemanager.cs: Add `indexer_name_type' as a Core type
31436 (System.Runtime.CompilerServices.IndexerNameAttribute)
31438 * statement.cs (Goto): Take a location.
31440 2001-10-18 Ravi Pratap <ravi@ximian.com>
31442 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31443 if two delegates are compatible.
31445 (NewDelegate::DoResolve): Update to take care of the case when
31446 we instantiate a delegate from another delegate.
31448 * typemanager.cs (FindMembers): Don't even try to look up members
31449 of Delegate types for now.
31451 2001-10-18 Ravi Pratap <ravi@ximian.com>
31453 * delegate.cs (NewDelegate): New class to take care of delegate
31456 * expression.cs (New): Split the delegate related code out into
31457 the NewDelegate class.
31459 * delegate.cs (DelegateInvocation): New class to handle delegate
31462 * expression.cs (Invocation): Split out delegate related code into
31463 the DelegateInvocation class.
31465 2001-10-17 Ravi Pratap <ravi@ximian.com>
31467 * expression.cs (New::DoResolve): Implement delegate creation fully
31468 and according to the spec.
31470 (New::DoEmit): Update to handle delegates differently.
31472 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31473 because of which we were printing out arguments in reverse order !
31475 * delegate.cs (VerifyMethod): Implement to check if the given method
31476 matches the delegate.
31478 (FullDelegateDesc): Implement.
31480 (VerifyApplicability): Implement.
31482 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31483 delegate invocations too.
31485 (Invocation::Emit): Ditto.
31487 * ../errors/cs1593.cs : Added.
31489 * ../errors/cs1594.cs : Added.
31491 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31493 2001-10-16 Ravi Pratap <ravi@ximian.com>
31495 * typemanager.cs (intptr_type): Core type for System.IntPtr
31497 (InitCoreTypes): Update for the same.
31499 (iasyncresult_type, asynccallback_type): Ditto.
31501 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31504 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31507 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31508 the builders for the 4 members of a delegate type :-)
31510 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31513 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31515 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31517 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31519 * statement.cs (Break::Emit): Implement.
31520 (Continue::Emit): Implement.
31522 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31523 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31524 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31525 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31528 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31529 properties that track the label for the current loop (begin of the
31530 loop and end of the loop).
31532 2001-10-15 Ravi Pratap <ravi@ximian.com>
31534 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31535 use of emitting anything at all.
31537 * class.cs, rootcontext.cs : Get rid of calls to the same.
31539 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31541 (Populate): Define the constructor correctly and set the implementation
31544 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31547 (AddDelegateType): Implement.
31549 (IsDelegateType): Implement helper method.
31551 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31553 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31554 and accordingly handle it.
31556 * delegate.cs (Populate): Take TypeContainer argument.
31557 Implement bits to define the Invoke method. However, I still haven't figured out
31558 how to take care of the native int bit :-(
31560 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31561 Qualify the name of the delegate, not its return type !
31563 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31566 (StandardConversionExists): Checking for array types turns out to be recursive.
31568 (ConvertReferenceExplicit): Implement array conversion.
31570 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31572 2001-10-12 Ravi Pratap <ravi@ximian.com>
31574 * cs-parser.jay (delegate_declaration): Store the fully qualified
31575 name as it is a type declaration.
31577 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31580 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31581 as TypeContainer::DefineType.
31583 (Populate): Method in which all the definition of the various methods (Invoke)
31586 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31589 (CloseDelegate): Finally creates the delegate.
31591 * class.cs (TypeContainer::DefineType): Update to define delegates.
31592 (Populate, Emit and CloseType): Do the same thing here too.
31594 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31595 delegates in all these operations.
31597 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31599 * expression.cs: LocalTemporary: a new expression used to
31600 reference a temporary that has been created.
31602 * assign.cs: Handle PropertyAccess back here, so that we can
31603 provide the proper semantic access to properties.
31605 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31606 a few more explicit conversions.
31608 * modifiers.cs: `NEW' modifier maps to HideBySig.
31610 * expression.cs (PropertyExpr): Make this into an
31611 ExpressionStatement, and support the EmitStatement code path.
31613 Perform get/set error checking, clean up the interface.
31615 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31616 them into toplevel access objects.
31618 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31620 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31623 * typemanager.cs: Keep track here of our PropertyBuilders again to
31624 work around lameness in SRE.
31626 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31628 * expression.cs (LValue::LValueResolve): New method in the
31629 interface, used to perform a second resolution pass for LValues.
31631 (This::DoResolve): Catch the use of this in static methods.
31633 (This::LValueResolve): Implement.
31635 (This::Store): Remove warning, assigning to `this' in structures
31638 (Invocation::Emit): Deal with invocation of
31639 methods on value types. We need to pass the address to structure
31640 methods rather than the object itself. (The equivalent code to
31641 emit "this" for structures leaves the entire structure on the
31642 stack instead of a pointer to it).
31644 (ParameterReference::DoResolve): Compute the real index for the
31645 argument based on whether the method takes or not a `this' pointer
31646 (ie, the method is static).
31648 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31649 value types returned from functions when we need to invoke a
31650 method on the sturcture.
31653 2001-10-11 Ravi Pratap <ravi@ximian.com>
31655 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31656 defining the type in the Modulebuilder or Typebuilder. This is to take
31657 care of nested types which need to be defined on the TypeBuilder using
31658 DefineNestedMethod.
31660 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31661 methods in RootContext, only ported to be part of TypeContainer.
31663 (TypeContainer::GetInterfaceOrClass): Ditto.
31665 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31667 * interface.cs (Interface::DefineInterface): New method. Does exactly
31668 what RootContext.CreateInterface did earlier, only it takes care of nested types
31671 (Interface::GetInterfaces): Move from RootContext here and port.
31673 (Interface::GetInterfaceByName): Same here.
31675 * rootcontext.cs (ResolveTree): Re-write.
31677 (PopulateTypes): Re-write.
31679 * class.cs (TypeContainer::Populate): Populate nested types too.
31680 (TypeContainer::Emit): Emit nested members too.
31682 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31683 instead just use the name argument passed in as it is already fully
31686 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31687 to TypeContainer mapping to see if a type is user-defined.
31689 * class.cs (TypeContainer::CloseType): Implement.
31691 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31692 the default constructor.
31694 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31697 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31699 * interface.cs (CloseType): Create the type here.
31701 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31704 Remove all the methods which are now in TypeContainer.
31706 2001-10-10 Ravi Pratap <ravi@ximian.com>
31708 * delegate.cs (Define): Re-write bits to define the delegate
31711 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31713 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31715 * expression.cs (ImplicitReferenceConversion): handle null as well
31716 as a source to convert to any reference type.
31718 * statement.cs (Return): Perform any implicit conversions to
31719 expected return type.
31721 Validate use of return statement.
31723 * codegen.cs (EmitContext): Pass the expected return type here.
31725 * class.cs (Method, Constructor, Property): Pass expected return
31726 type to EmitContext.
31728 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31730 * expression.cs: Make DoResolve take an EmitContext instead of a
31733 Replaced `l' and `location' for `loc', for consistency.
31735 (Error, Warning): Remove unneeded Tc argument.
31737 * assign.cs, literal.cs, constant.cs: Update to new calling
31740 * codegen.cs: EmitContext now contains a flag indicating whether
31741 code is being generated in a static method or not.
31743 * cs-parser.jay: DecomposeQI, new function that replaces the old
31744 QualifiedIdentifier. Now we always decompose the assembled
31745 strings from qualified_identifier productions into a group of
31748 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31750 * rootcontext.cs: Deal with field-less struct types correctly now
31751 by passing the size option to Define Type.
31753 * class.cs: Removed hack that created one static field.
31755 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31757 * statement.cs: Moved most of the code generation here.
31759 2001-10-09 Ravi Pratap <ravi@ximian.com>
31761 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31764 (ElementAccess): Remove useless bits for now - keep checks as the spec
31767 2001-10-08 Ravi Pratap <ravi@ximian.com>
31769 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31770 and start performing checks according to the spec.
31772 2001-10-07 Ravi Pratap <ravi@ximian.com>
31774 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31775 rank_specifiers instead.
31777 (rank_specifiers): Change the order in which the rank specifiers are stored
31779 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31781 * expression.cs (ElementAccess): Implement the LValue interface too.
31783 2001-10-06 Ravi Pratap <ravi@ximian.com>
31785 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31786 except that user defined conversions are not included.
31788 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31789 perform the conversion of the return type, if necessary.
31791 (New::DoResolve): Check whether we are creating an array or an object
31792 and accordingly do the needful.
31794 (New::Emit): Same here.
31796 (New::DoResolve): Implement guts of array creation.
31798 (New::FormLookupType): Helper function.
31800 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31802 * codegen.cs: Removed most of the code generation here, and move the
31803 corresponding code generation bits to the statement classes.
31805 Added support for try/catch/finalize and throw.
31807 * cs-parser.jay: Added support for try/catch/finalize.
31809 * class.cs: Catch static methods having the flags override,
31810 virtual or abstract.
31812 * expression.cs (UserCast): This user cast was not really doing
31813 what it was supposed to do. Which is to be born in fully resolved
31814 state. Parts of the resolution were being performed at Emit time!
31818 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31820 * expression.cs: Implicity convert the result from UserCast.
31822 2001-10-05 Ravi Pratap <ravi@ximian.com>
31824 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31825 prevented it from working correctly.
31827 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31828 merely ConvertImplicit.
31830 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31832 * typemanager.cs: Make the LookupTypeContainer function static,
31833 and not per-instance.
31835 * class.cs: Make static FindMembers (the one that takes a Type
31838 * codegen.cs: Add EmitForeach here.
31840 * cs-parser.jay: Make foreach a toplevel object instead of the
31841 inline expansion, as we need to perform semantic analysis on it.
31843 2001-10-05 Ravi Pratap <ravi@ximian.com>
31845 * expression.cs (Expression::ImplicitUserConversion): Rename to
31846 UserDefinedConversion.
31848 (Expression::UserDefinedConversion): Take an extra argument specifying
31849 whether we look for explicit user conversions too.
31851 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31853 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31855 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31856 with the appropriate arguments.
31858 * cs-parser.jay (cast_expression): Record location too.
31860 * expression.cs (Cast): Record location info.
31862 (Expression::ConvertExplicit): Take location argument.
31864 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31865 to determine if we are doing explicit conversions.
31867 (UserCast::Emit): Update accordingly.
31869 (Expression::ConvertExplicit): Report an error if everything fails.
31871 * ../errors/cs0030.cs : Add.
31873 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31875 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31876 virtual and newslot bits.
31878 * class.cs (TypeContainer::RegisterRequiredImplementations):
31879 Record methods we need.
31881 (TypeContainer::MakeKey): Helper function to make keys for
31882 MethodBases, since the Methodbase key is useless.
31884 (TypeContainer::Populate): Call RegisterRequiredImplementations
31885 before defining the methods.
31887 Create a mapping for method_builders_to_methods ahead of time
31888 instead of inside a tight loop.
31890 (::RequireMethods): Accept an object as the data to set into the
31891 hashtable so we can report interface vs abstract method mismatch.
31893 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31895 * report.cs: Make all of it static.
31897 * rootcontext.cs: Drop object_type and value_type computations, as
31898 we have those in the TypeManager anyways.
31900 Drop report instance variable too, now it is a global.
31902 * driver.cs: Use try/catch on command line handling.
31904 Add --probe option to debug the error reporting system with a test
31907 * report.cs: Add support for exiting program when a probe
31908 condition is reached.
31910 2001-10-03 Ravi Pratap <ravi@ximian.com>
31912 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31913 we do a forcible conversion regardless of type, to check if
31914 ForceConversion returns a null.
31916 (Binary::error19): Use location to report error.
31918 (Unary::error23): Use location here too.
31920 * ../errors/cs0019.cs : Check in.
31922 * ../errors/cs0023.cs : Check in.
31924 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31925 case of a non-null MethodInfo object with a length of 0 !
31927 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31928 an applicable member - according to the spec :-)
31929 Also fix logic to find members in base types.
31931 (Unary::ResolveOperator): Same here.
31933 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31934 as I was getting thoroughly confused between this and error19 :-)
31936 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31937 (::FindMostEncompassedType): Implement.
31938 (::FindMostEncompassingType): Implement.
31939 (::StandardConversionExists): Implement.
31941 (UserImplicitCast): Re-vamp. We now need info about most specific
31942 source and target types so that we can do the necessary conversions.
31944 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31945 mathematical union with no duplicates.
31947 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31949 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31950 in order from base classes to child classes, so that we can in
31951 child classes look up in our parent for method names and
31952 attributes (required for handling abstract, virtual, new, override
31953 constructs: we need to instrospect our base class, and if we dont
31954 populate the classes in order, the introspection might be
31955 incorrect. For example, a method could query its parent before
31956 the parent has any methods and would determine that the parent has
31957 no abstract methods (while it could have had them)).
31959 (RootContext::CreateType): Record the order in which we define the
31962 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31964 * class.cs (TypeContainer::Populate): Also method definitions can
31965 fail now, keep track of this.
31967 (TypeContainer::FindMembers): Implement support for
31968 DeclaredOnly/noDeclaredOnly flag.
31970 (Constructor::Emit) Return the ConstructorBuilder.
31972 (Method::Emit) Return the MethodBuilder.
31973 Check for abstract or virtual methods to be public.
31975 * rootcontext.cs (RootContext::CreateType): Register all the
31976 abstract methods required for the class to be complete and the
31977 interface methods that must be implemented.
31979 * cs-parser.jay: Report error 501 (method requires body if it is
31980 not marked abstract or extern).
31982 * expression.cs (TypeOf::Emit): Implement.
31984 * typemanager.cs: runtime_handle_type, new global type.
31986 * class.cs (Property::Emit): Generate code for properties.
31988 2001-10-02 Ravi Pratap <ravi@ximian.com>
31990 * expression.cs (Unary::ResolveOperator): Find operators on base type
31991 too - we now conform exactly to the spec.
31993 (Binary::ResolveOperator): Same here.
31995 * class.cs (Operator::Define): Fix minor quirk in the tests.
31997 * ../errors/cs0215.cs : Added.
31999 * ../errors/cs0556.cs : Added.
32001 * ../errors/cs0555.cs : Added.
32003 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32005 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
32006 single integer which is really efficient
32008 2001-10-01 Ravi Pratap <ravi@ximian.com>
32010 * expression.cs (Expression::ImplicitUserConversion): Use location
32011 even in the case when we are examining True operators.
32013 * class.cs (Operator::Define): Perform extensive checks to conform
32014 with the rules for operator overloading in the spec.
32016 * expression.cs (Expression::ImplicitReferenceConversion): Implement
32017 some of the other conversions mentioned in the spec.
32019 * typemanager.cs (array_type): New static member for the System.Array built-in
32022 (cloneable_interface): For System.ICloneable interface.
32024 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
32025 we start resolving the tree and populating types.
32027 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
32029 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32031 * expression.cs (Expression::ExprClassFromMemberInfo,
32032 Expression::Literalize): Create literal expressions from
32033 FieldInfos which are literals.
32035 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
32036 type casts, because they were wrong. The test suite in tests
32039 (ImplicitNumericConversion): ushort to ulong requires a widening
32042 Int32 constant to long requires widening cast as well.
32044 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
32045 for integers because the type on the stack is not i4.
32047 2001-09-30 Miguel de Icaza <miguel@ximian.com>
32049 * expression.cs (report118): require location argument.
32051 * parameter.cs: Do not dereference potential null value.
32053 * class.cs: Catch methods that lack the `new' keyword when
32054 overriding a name. Report warnings when `new' is used without
32055 anything being there to override.
32057 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
32059 * class.cs: Only add constructor to hashtable if it is non-null
32060 (as now constructors can fail on define).
32062 (TypeManager, Class, Struct): Take location arguments.
32064 Catch field instance initialization in structs as errors.
32066 accepting_filter: a new filter for FindMembers that is static so
32067 that we dont create an instance per invocation.
32069 (Constructor::Define): Catch errors where a struct constructor is
32072 * cs-parser.jay: Pass location information for various new
32075 * delegate.cs (Delegate): take a location argument.
32077 * driver.cs: Do not call EmitCode if there were problesm in the
32078 Definition of the types, as many Builders wont be there.
32080 * decl.cs (Decl::Decl): Require a location argument.
32082 * cs-tokenizer.cs: Handle properly hex constants that can not fit
32083 into integers, and find the most appropiate integer for it.
32085 * literal.cs: Implement ULongLiteral.
32087 * rootcontext.cs: Provide better information about the location of
32088 failure when CreateType fails.
32090 2001-09-29 Miguel de Icaza <miguel@ximian.com>
32092 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
32095 * expression.cs (Binary::CheckShiftArguments): Add missing type
32097 (Binary::ResolveOperator): Add type to the logical and and logical
32098 or, Bitwise And/Or and Exclusive Or code paths, it was missing
32101 (Binary::DoNumericPromotions): In the case where either argument
32102 is ulong (and most signed types combined with ulong cause an
32103 error) perform implicit integer constant conversions as well.
32105 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32107 * expression.cs (UserImplicitCast): Method should always be
32109 (Invocation::BetterConversion): Simplified test for IntLiteral.
32111 (Expression::ImplicitNumericConversion): Split this routine out.
32112 Put the code that performs implicit constant integer conversions
32115 (Expression::Resolve): Become a wrapper around DoResolve so we can
32116 check eclass and type being set after resolve.
32118 (Invocation::Badness): Remove this dead function
32120 (Binary::ResolveOperator): Do not compute the expensive argumnets
32121 unless we have a union for it.
32123 (Probe::Emit): Is needs to do an isinst and then
32124 compare against null.
32126 (::CanConvert): Added Location argument. If the Location argument
32127 is null (Location.Null), then we do not report errors. This is
32128 used by the `probe' mechanism of the Explicit conversion. We do
32129 not want to generate an error for something that the user
32130 explicitly requested to be casted. But the pipeline for an
32131 explicit cast first tests for potential implicit casts.
32133 So for now, if the Location is null, it means `Probe only' to
32134 avoid adding another argument. Might have to revise this
32137 (ClassCast): New class used to type cast objects into arbitrary
32138 classes (used in Explicit Reference Conversions).
32140 Implement `as' as well.
32142 Reverted all the patches from Ravi below: they were broken:
32144 * The use of `level' as a mechanism to stop recursive
32145 invocations is wrong. That was there just to catch the
32146 bug with a strack trace but not as a way of addressing
32149 To fix the problem we have to *understand* what is going
32150 on and the interactions and come up with a plan, not
32151 just get things going.
32153 * The use of the type conversion cache that I proposed
32154 last night had an open topic: How does this work across
32155 protection domains. A user defined conversion might not
32156 be public in the location where we are applying the
32157 conversion, a different conversion might be selected
32158 (ie, private A->B (better) but public B->A (worse),
32159 inside A, A->B applies, but outside it, B->A will
32162 * On top of that (ie, even if the above is solved),
32163 conversions in a cache need to be abstract. Ie, `To
32164 convert from an Int to a Short use an OpcodeCast', not
32165 `To convert from an Int to a Short use the OpcodeCast on
32166 the variable 5' (which is what this patch was doing).
32168 2001-09-28 Ravi Pratap <ravi@ximian.com>
32170 * expression.cs (Invocation::ConversionExists): Re-write to use
32171 the conversion cache
32173 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
32174 cache all conversions done, not just user-defined ones.
32176 (Invocation::BetterConversion): The real culprit. Use ConversionExists
32177 to determine if a conversion exists instead of acutually trying to
32178 perform the conversion. It's faster too.
32180 (Expression::ConvertExplicit): Modify to use ConversionExists to check
32181 and only then attempt the implicit conversion.
32183 2001-09-28 Ravi Pratap <ravi@ximian.com>
32185 * expression.cs (ConvertImplicit): Use a cache for conversions
32186 already found. Check level of recursion and bail out if necessary.
32188 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32190 * typemanager.cs (string_concat_string_string, string_concat_object_object):
32191 Export standard methods that we expect for string operations.
32193 * statement.cs (Block::UsageWarning): Track usage of variables and
32194 report the errors for not used variables.
32196 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
32199 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32201 * codegen.cs: remove unnneded code
32203 * expression.cs: Removed BuiltinTypeAccess class
32205 Fix the order in which implicit conversions are
32208 The previous fixed dropped support for boxed conversions (adding a
32209 test to the test suite now)
32211 (UserImplicitCast::CanConvert): Remove test for source being null,
32212 that code is broken. We should not feed a null to begin with, if
32213 we do, then we should track the bug where the problem originates
32214 and not try to cover it up here.
32216 Return a resolved expression of type UserImplicitCast on success
32217 rather than true/false. Ravi: this is what I was talking about,
32218 the pattern is to use a static method as a "constructor" for
32221 Also, do not create arguments until the very last minute,
32222 otherwise we always create the arguments even for lookups that
32223 will never be performed.
32225 (UserImplicitCast::Resolve): Eliminate, objects of type
32226 UserImplicitCast are born in a fully resolved state.
32228 * typemanager.cs (InitCoreTypes): Init also value_type
32229 (System.ValueType).
32231 * expression.cs (Cast::Resolve): First resolve the child expression.
32233 (LValue): Add new method AddressOf to be used by
32236 Change the argument of Store to take an EmitContext instead of an
32237 ILGenerator, because things like FieldExpr need to be able to call
32238 their children expression to generate the instance code.
32240 (Expression::Error, Expression::Warning): Sugar functions for
32243 (Expression::MemberLookup): Accept a TypeContainer instead of a
32244 Report as the first argument.
32246 (Expression::ResolvePrimary): Killed. I still want to improve
32247 this as currently the code is just not right.
32249 (Expression::ResolveMemberAccess): Simplify, but it is still
32252 (Unary::Resolve): Catch errors in AddressOf operators.
32254 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
32255 index to a byte for the short-version, or the compiler will choose
32256 the wrong Emit call, which generates the wrong data.
32258 (ParameterReference::Emit, ::Store): same.
32260 (FieldExpr::AddressOf): Implement.
32262 * typemanager.cs: TypeManager: made public variable instead of
32265 * driver.cs: document --fatal.
32267 * report.cs (ErrorMessage, WarningMessage): new names for the old
32268 Error and Warning classes.
32270 * cs-parser.jay (member_access): Turn built-in access to types
32271 into a normal simplename
32273 2001-09-27 Ravi Pratap <ravi@ximian.com>
32275 * expression.cs (Invocation::BetterConversion): Fix to cope
32276 with q being null, since this was introducing a bug.
32278 * expression.cs (ConvertImplicit): Do built-in conversions first.
32280 2001-09-27 Ravi Pratap <ravi@ximian.com>
32282 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32284 2001-09-27 Ravi Pratap <ravi@ximian.com>
32286 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32287 I had introduced long ago (what's new ?).
32289 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32290 the work of all the checking.
32291 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32292 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32294 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32295 that is the right way.
32297 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32298 overloading resolution. Use everywhere instead of cutting and pasting code.
32300 (Binary::ResolveOperator): Use MakeUnionSet.
32302 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32303 we have to convert to bool types. Not complete yet.
32305 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32307 * typemanager.cs (TypeManager::CSharpName): support ushort.
32309 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32310 to provide an expression that performsn an implicit constant int
32311 conversion (section 6.1.6).
32312 (Expression::ConvertImplicitRequired): Reworked to include
32313 implicit constant expression conversions.
32315 (Expression::ConvertNumericExplicit): Finished.
32317 (Invocation::Emit): If InstanceExpression is null, then it means
32318 that we perform a call on this.
32320 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32322 * expression.cs (Unary::Emit): Remove some dead code.
32323 (Probe): Implement Resolve and Emit for `is'.
32324 (Expression::ConvertImplicitRequired): Attempt to do constant
32325 expression conversions here. Maybe should be moved to
32326 ConvertImplicit, but I am not sure.
32327 (Expression::ImplicitLongConstantConversionPossible,
32328 Expression::ImplicitIntConstantConversionPossible): New functions
32329 that tell whether is it possible to apply an implicit constant
32330 expression conversion.
32332 (ConvertNumericExplicit): Started work on explicit numeric
32335 * cs-parser.jay: Update operator constants.
32337 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32338 (Parameters::GetSignature): Hook up VerifyArgs here.
32339 (Parameters::VerifyArgs): Verifies that no two arguments have the
32342 * class.cs (Operator): Update the operator names to reflect the
32343 ones that the spec expects (as we are just stringizing the
32346 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32347 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32348 previous usage did only work for our methods.
32349 (Expression::ConvertImplicit): Handle decimal implicit numeric
32350 conversions as well.
32351 (Expression::InternalTypeConstructor): Used to invoke constructors
32352 on internal types for default promotions.
32354 (Unary::Emit): Implement special handling for the pre/post
32355 increment/decrement for overloaded operators, as they need to have
32356 the same semantics as the other operators.
32358 (Binary::ResolveOperator): ditto.
32359 (Invocation::ConversionExists): ditto.
32360 (UserImplicitCast::Resolve): ditto.
32362 2001-09-26 Ravi Pratap <ravi@ximian.com>
32364 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32365 operator, return after emitting body. Regression tests pass again !
32367 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32368 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32369 (Invocation::OverloadResolve): Ditto.
32370 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32372 * everywhere : update calls to the above methods accordingly.
32374 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32376 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32378 * expression.cs (ExpressionStatement): New base class used for
32379 expressions that can appear in statements, so that we can provide
32380 an alternate path to generate expression that do not leave a value
32383 (Expression::Emit, and all the derivatives): We no longer return
32384 whether a value is left on the stack or not. Every expression
32385 after being emitted leaves a single value on the stack.
32387 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32388 facilties of ExpressionStatement if possible.
32390 * cs-parser.jay: Update statement_expression.
32392 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32394 * driver.cs: Change the wording of message
32396 2001-09-25 Ravi Pratap <ravi@ximian.com>
32398 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32399 the type of the expression to the return type of the method if
32400 we have an overloaded operator match ! The regression tests pass again !
32401 (Unary::ResolveOperator): Ditto.
32403 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32404 to find "op_Implicit", not "implicit" ;-)
32405 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32406 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32408 * everywhere : Correct calls to the above accordingly.
32410 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32411 (ConvertImplicit): Do user-defined conversion if it exists.
32413 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32415 * assign.cs: track location.
32416 (Resolve): Use implicit conversions on assignment.
32418 * literal.cs: Oops. Not good, Emit of short access values should
32419 pass (Bytes) or the wrong argument will be selected.
32421 * expression.cs (Unary::Emit): Emit code for -expr.
32423 (Unary::ResolveOperator): Handle `Substract' for non-constants
32424 (substract from zero from the non-constants).
32425 Deal with Doubles as well.
32427 (Expression::ConvertImplicitRequired): New routine that reports an
32428 error if no implicit conversion exists.
32430 (Invocation::OverloadResolve): Store the converted implicit
32431 expressions if we make them
32433 2001-09-24 Ravi Pratap <ravi@ximian.com>
32435 * class.cs (ConstructorInitializer): Take a Location argument.
32436 (ConstructorBaseInitializer): Same here.
32437 (ConstructorThisInitializer): Same here.
32439 * cs-parser.jay : Update all calls accordingly.
32441 * expression.cs (Unary, Binary, New): Take location argument.
32442 Update accordingly everywhere.
32444 * cs-parser.jay : Update all calls to the above to take a location
32447 * class.cs : Ditto.
32449 2001-09-24 Ravi Pratap <ravi@ximian.com>
32451 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32452 (Invocation::BetterConversion): Same here
32453 (Invocation::ConversionExists): Ditto.
32455 (Invocation::ConversionExists): Implement.
32457 2001-09-22 Ravi Pratap <ravi@ximian.com>
32459 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32460 Also take an additional TypeContainer argument.
32462 * All over : Pass in TypeContainer as argument to OverloadResolve.
32464 * typemanager.cs (CSharpName): Update to check for the string type and return
32467 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32470 2001-09-21 Ravi Pratap <ravi@ximian.com>
32472 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32473 (Invocation::BetterFunction): Implement.
32474 (Invocation::BetterConversion): Implement.
32475 (Invocation::ConversionExists): Skeleton, no implementation yet.
32477 Okay, things work fine !
32479 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32481 * typemanager.cs: declare and load enum_type, delegate_type and
32484 * expression.cs (Expression::Emit): Now emit returns a value that
32485 tells whether a value is left on the stack or not. This strategy
32486 might be reveted tomorrow with a mechanism that would address
32487 multiple assignments.
32488 (Expression::report118): Utility routine to report mismatches on
32491 (Unary::Report23): Report impossible type/operator combination
32494 (Unary::IsIncrementableNumber): Whether the type can be
32495 incremented or decremented with add.
32496 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32498 (Unary::ResolveOperator): Implement ++, !, ~,
32500 (Invocation::Emit): Deal with new Emit convetion.
32502 * All Expression derivatives: Updated their Emit method to return
32503 whether they leave values on the stack or not.
32505 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32506 stack for expressions that are statements.
32508 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32510 * expression.cs (LValue): New interface. Must be implemented by
32512 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32515 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32516 interface for generating code, simplifies the code.
32518 2001-09-20 Ravi Pratap <ravi@ximian.com>
32520 * expression.cs (everywhere): Comment out return statements in ::Resolve
32521 methods to avoid the warnings.
32523 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32525 * driver.cs (parse): Report error 2001 if we can not open the
32528 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32531 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32534 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32535 otherwise nested blocks end up with the same index.
32537 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32539 * expression.cs: Instead of having FIXMEs in the Resolve
32540 functions, throw exceptions so it is obvious that we are facing a
32543 * cs-parser.jay (invocation_expression): Pass Location information.
32545 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32546 Use a basename for those routines because .NET does not like paths
32549 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32552 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32554 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32555 are loading the correct data types (throws an exception if not).
32556 (TypeManager::InitCoreTypes): Use CoreLookupType
32558 * expression.cs (Unary::ResolveOperator): return the child
32559 expression for expressions which are just +expr.
32560 (Unary::ResolveOperator): Return negative literals for -LITERAL
32561 expressions (otherwise they are Unary {Literal}).
32562 (Invocation::Badness): Take into account `Implicit constant
32563 expression conversions'.
32565 * literal.cs (LongLiteral): Implement long literal class.
32566 (IntLiteral): export the `Value' of the intliteral.
32568 2001-09-19 Ravi Pratap <ravi@ximian.com>
32570 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32572 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32573 instead of 'Operator'
32575 * expression.cs (Binary::ResolveOperator): Update accordingly.
32576 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32579 * cs-parser.jay (unary_expression): Update to use the new names.
32581 * gen-treedump.cs (GetUnary): Same here.
32583 * expression.cs (Unary::Resolve): Implement.
32584 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32585 operators are found instead of making noise ;-)
32586 (Unary::ResolveOperator): New method to do precisely the same thing which
32587 Binary::ResolveOperator does for Binary expressions.
32588 (Unary.method, .Arguments): Add.
32589 (Unary::OperName): Implement.
32590 (Unary::ForceConversion): Copy and Paste !
32592 * class.cs (Operator::Define): Fix a small bug for the case when we have
32595 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32596 for the inbuilt operators. Only overloading works for now ;-)
32598 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32600 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32601 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32603 * expression.cs (This::Emit): Implement.
32604 (This::Resolve): Implement.
32605 (TypeOf:Resolve): Implement.
32606 (Expression::ResolveSimpleName): Add an implicit this to instance
32608 (MemberAccess::Resolve): Deal with Parameters and Fields.
32609 Bind instance variable to Field expressions.
32610 (FieldExpr::Instance): New field used to track the expression that
32611 represents the object instance.
32612 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32614 (FieldExpr::Emit): Implement.
32616 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32617 the last instruction contains a return opcode to avoid generating
32618 the last `ret' instruction (this generates correct code, and it is
32619 nice to pass the peverify output).
32621 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32622 initializer for static and instance variables.
32623 (Constructor::Emit): Allow initializer to be null in the case of
32624 static constructors. Only emit initializer for instance
32627 (TypeContainer::FindMembers): Return a null array if there are no
32630 Also fix the code for the MemberTypes.Method branch, as it was not
32631 scanning that for operators (or tried to access null variables before).
32633 * assign.cs (Assign::Emit): Handle instance and static fields.
32637 * driver.cs: Stop compilation if there are parse errors.
32639 * cs-parser.jay (constructor_declaration): Provide default base
32640 initializer for non-static constructors.
32641 (constructor_declarator): Do not provide a default base
32642 initializers if none was specified.
32643 Catch the fact that constructors should not have parameters.
32645 * class.cs: Do not emit parent class initializers for static
32646 constructors, that should be flagged as an error.
32648 2001-09-18 Ravi Pratap <ravi@ximian.com>
32650 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32651 Move back code into TypeContainer::Populate.
32653 2001-09-18 Ravi Pratap <ravi@ximian.com>
32655 * class.cs (TypeContainer::AddConstructor): Fix the check to
32656 compare against Name, not Basename.
32657 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32659 * cs-parser.jay : Update accordingly.
32661 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32662 for methods, don't forget to look into the operators too.
32663 (RegisterMethodBuilder): Helper method to take care of this for
32664 methods, constructors and operators.
32665 (Operator::Define): Completely revamp.
32666 (Operator.OperatorMethod, MethodName): New fields.
32667 (TypeContainer::Populate): Move the registering of builders into
32668 RegisterMethodBuilder.
32669 (Operator::Emit): Re-write.
32671 * expression.cs (Binary::Emit): Comment out code path to emit method
32672 invocation stuff for the case when we have a user defined operator. I am
32673 just not able to get it right !
32675 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32677 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32680 (Expression::MemberLookup): Provide a version that allows to
32681 specify the MemberTypes and BindingFlags.
32683 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32684 so it was not fetching variable information from outer blocks.
32686 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32687 Beforefieldinit as it was buggy.
32689 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32690 that Ravi put here.
32692 * class.cs (Constructor::Emit): Only emit if block is not null.
32693 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32694 deal with this by semantically definining it as if the user had
32697 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32698 constructors as we now "emit" them at a higher level.
32700 (TypeContainer::DefineDefaultConstructor): Used to define the
32701 default constructors if none was provided.
32703 (ConstructorInitializer): Add methods Resolve and Emit.
32705 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32707 2001-09-17 Ravi Pratap <ravi@ximian.com>
32709 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32710 the default constructor builder with our hashtable for methodbuilders
32713 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32714 and argument_count is 0 in which case we have a match.
32715 (Binary::ResolveOperator): More null checking and miscellaneous coding
32718 2001-09-17 Ravi Pratap <ravi@ximian.com>
32720 * rootcontext.cs (IsNameSpace): Compare against null.
32722 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32724 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32725 and Unary::Operator.
32727 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32730 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32731 we have overloaded operators.
32732 (Binary::ResolveOperator): Implement the part which does the operator overload
32735 * class.cs (Operator::Emit): Implement.
32736 (TypeContainer::Emit): Emit the operators we have too.
32738 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32739 the case when we have a user-defined operator.
32741 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32743 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32745 2001-09-16 Ravi Pratap <ravi@ximian.com>
32747 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32748 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32749 (Constructor::Emit): Implement.
32750 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32751 if we have no work to do.
32752 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32755 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32756 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32758 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32761 2001-09-15 Ravi Pratap <ravi@ximian.com>
32763 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32765 (Tree::RecordNamespace): Method to do what the name says ;-)
32766 (Tree::Namespaces): Property to get at the namespaces hashtable.
32768 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32771 * rootcontext.cs (IsNamespace): Fixed it :-)
32773 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32775 * class.cs (TypeContainer::FindMembers): Add support for
32777 (MethodCore): New class that encapsulates both the shared aspects
32778 of a Constructor and a Method.
32779 (Method, Constructor): Factored pieces into MethodCore.
32781 * driver.cs: Added --fatal which makes errors throw exceptions.
32782 Load System assembly as well as part of the standard library.
32784 * report.cs: Allow throwing exceptions on errors for debugging.
32786 * modifiers.cs: Do not use `parent', instead use the real type
32787 container to evaluate permission settings.
32789 * class.cs: Put Ravi's patch back in. He is right, and we will
32790 have to cope with the
32792 2001-09-14 Ravi Pratap <ravi@ximian.com>
32794 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32795 FamORAssem, not FamANDAssem.
32797 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32799 * driver.cs: Added --parse option that only parses its input files
32802 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32803 incorrect. IsTopLevel is not used to tell whether an object is
32804 root_types or not (that can be achieved by testing this ==
32805 root_types). But to see if this is a top-level *class* (not
32806 necessarly our "toplevel" container).
32808 2001-09-14 Ravi Pratap <ravi@ximian.com>
32810 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32811 parent instead of a direct call to GetType.
32813 2001-09-14 Ravi Pratap <ravi@ximian.com>
32815 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32816 Modifiers.TypeAttr. This should just be a call to that method.
32818 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32819 object so that we can determine if we are top-level or not.
32821 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32824 * enum.cs (Enum::Define): Ditto.
32826 * modifiers.cs (FieldAttr): Re-write.
32828 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32829 (TypeContainer::HaveStaticConstructor): New property to provide access
32830 to precisely that info.
32832 * modifiers.cs (MethodAttr): Re-write.
32833 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32835 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32836 of top-level types as claimed.
32838 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32840 * expression.cs (MemberLookup): Fruitless attempt to lookup
32841 constructors. Maybe I need to emit default constructors? That
32842 might be it (currently .NET emits this for me automatically).
32843 (Invocation::OverloadResolve): Cope with Arguments == null.
32844 (Invocation::EmitArguments): new function, shared by the new
32845 constructor and us.
32846 (Invocation::Emit): Handle static and instance methods. Emit
32847 proper call instruction for virtual or non-virtual invocations.
32848 (New::Emit): Implement.
32849 (New::Resolve): Implement.
32850 (MemberAccess:Resolve): Implement.
32851 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32852 to track instances.
32853 (FieldExpr::Resolve): Set type.
32855 * support.cs: Handle empty arguments.
32857 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32858 SimpleLookup): Auxiliary routines to help parse a qualifier
32861 Update qualifier_identifier rule.
32863 * codegen.cs: Removed debugging messages.
32865 * class.cs: Make this a global thing, this acts just as a "key" to
32866 objects that we might have around.
32868 (Populate): Only initialize method_builders_to_methods once.
32870 * expression.cs (PropertyExpr): Initialize type from the
32873 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32874 Resolve pattern. Attempt to implicitly convert value to boolean.
32877 * expression.cs: Set the type for the int32/int32 argument case.
32878 (Binary::ResolveOperator): Set the return type to boolean for
32879 comparission operators
32881 * typemanager.cs: Remove debugging print code.
32883 (Invocation::Resolve): resolve type.
32885 * class.cs: Allocate a MemberInfo of the correct size, as the code
32886 elsewhere depends on the test to reflect the correct contents.
32888 (Method::) Keep track of parameters, due to System.Reflection holes
32890 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32893 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32894 of the exact size and return that.
32896 (Class::LookupMethodByBuilder): New function that maps
32897 MethodBuilders to its methods. Required to locate the information
32898 on methods because System.Reflection bit us again.
32900 * support.cs: New file, contains an interface ParameterData and
32901 two implementations: ReflectionParameters and InternalParameters
32902 used to access Parameter information. We will need to grow this
32905 * expression.cs (Invocation::GetParameterData): implement a cache
32906 and a wrapper around the ParameterData creation for methods.
32907 (Invocation::OverloadResolve): Use new code.
32909 2001-09-13 Ravi Pratap <ravi@ximian.com>
32911 * class.cs (TypeContainer::EmitField): Remove and move into
32912 (Field::Define): here and modify accordingly.
32913 (Field.FieldBuilder): New member.
32914 (TypeContainer::Populate): Update accordingly.
32915 (TypeContainer::FindMembers): Implement.
32917 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32919 * statement.cs: (VariableInfo::VariableType): New field to be
32920 initialized with the full type once it is resolved.
32922 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32924 * parameter.cs (GetParameterInfo): Use a type cache to compute
32925 things only once, and to reuse this information
32927 * expression.cs (LocalVariableReference::Emit): Implement.
32928 (OpcodeCast::Emit): fix.
32930 (ParameterReference::Resolve): Implement.
32931 (ParameterReference::Emit): Implement.
32933 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32934 that are expressions need to stay as Expressions.
32936 * typemanager.cs (CSharpName): Returns the C# name of a type if
32939 * expression.cs (Expression::ConvertImplicit): New function that
32940 implements implicit type conversions.
32942 (Expression::ImplicitReferenceConversion): Implements implicit
32943 reference conversions.
32945 (EmptyCast): New type for transparent casts.
32947 (OpcodeCast): New type for casts of types that are performed with
32948 a sequence of bytecodes.
32950 (BoxedCast): New type used for casting value types into reference
32951 types. Emits a box opcode.
32953 (Binary::DoNumericPromotions): Implements numeric promotions of
32954 and computation of the Binary::Type.
32956 (Binary::EmitBranchable): Optimization.
32958 (Binary::Emit): Implement code emission for expressions.
32960 * typemanager.cs (TypeManager): Added two new core types: sbyte
32963 2001-09-12 Ravi Pratap <ravi@ximian.com>
32965 * class.cs (TypeContainer::FindMembers): Method which does exactly
32966 what Type.FindMembers does, only we don't have to use reflection. No
32967 implementation yet.
32969 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32970 typecontainer objects as we need to get at them.
32971 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32973 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32974 typecontainer object.
32976 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32977 of just a Report object.
32979 2001-09-11 Ravi Pratap <ravi@ximian.com>
32981 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32983 (TypeContainer::Populate): Now define the delegates of the type too.
32984 (TypeContainer.Delegates): Property to access the list of delegates defined
32987 * delegates.cs (Delegate::Define): Implement partially.
32989 * modifiers.cs (TypeAttr): Handle more flags.
32991 2001-09-11 Ravi Pratap <ravi@ximian.com>
32993 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32995 (Operator::Define): Re-write logic to get types by using the LookupType method
32996 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32997 (Indexer::Define): Ditto.
32998 (Event::Define): Ditto.
32999 (Property::Define): Ditto.
33001 2001-09-10 Ravi Pratap <ravi@ximian.com>
33003 * class.cs (TypeContainer::Populate): Now define operators too.
33004 (TypeContainer.Operators): New property to access the list of operators
33006 (Operator.OperatorMethodBuilder): New member to hold the method builder
33007 for the operator we are defining.
33008 (Operator::Define): Implement.
33010 2001-09-10 Ravi Pratap <ravi@ximian.com>
33012 * class.cs (Event::Define): Make the prefixes of the accessor methods
33013 addOn_ and removeOn_
33015 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
33016 of the location being passed in too. Ideally, this should go later since all
33017 error reporting should be done through the Report object.
33019 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
33020 (Populate): Iterate thru the indexers we have and define them too.
33021 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
33022 for the get and set accessors.
33023 (Indexer::Define): Implement.
33025 2001-09-09 Miguel de Icaza <miguel@ximian.com>
33027 * expression.cs (Binary::Resolve): Beginning of it. I scratched
33028 my previous implementation, did not work.
33030 * typemanager.cs: Add a couple of missing types (the longs).
33032 * literal.cs: Use TypeManager.bool_type instead of getting it.
33034 * expression.cs (EventExpr): New kind of expressions.
33035 (Expressio::ExprClassFromMemberInfo): finish
33037 2001-09-08 Miguel de Icaza <miguel@ximian.com>
33039 * assign.cs: Emit stores to static fields differently.
33041 2001-09-08 Ravi Pratap <ravi@ximian.com>
33043 * Merge in changes and adjust code to tackle conflicts. Backed out my
33044 code in Assign::Resolve ;-)
33046 2001-09-08 Ravi Pratap <ravi@ximian.com>
33048 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
33049 instead Report.Error and also pass in the location.
33050 (CSharpParser::Lexer): New readonly property to return the reference
33051 to the Tokenizer object.
33052 (declare_local_variables): Use Report.Error with location instead of plain
33056 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
33057 (Operator.CheckBinaryOperator): Ditto.
33059 * cs-parser.jay (operator_declarator): Update accordingly.
33061 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
33062 (CheckBinaryOperator): Same here.
33064 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
33065 on the name without any prefixes of namespace names etc. This is because we
33066 already might have something already fully qualified like
33067 'System.Console.WriteLine'
33069 * assign.cs (Resolve): Begin implementation. Stuck ;-)
33071 2001-09-07 Ravi Pratap <ravi@ximian.com>
33073 * cs-tokenizer.cs (location): Return a string which also contains
33076 * expression.cs (ElementAccess): New class for expressions of the
33077 type 'element access.'
33078 (BaseAccess): New class for expressions of the type 'base access.'
33079 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
33082 * cs-parser.jay (element_access): Implement action.
33083 (base_access): Implement actions.
33084 (checked_expression, unchecked_expression): Implement.
33086 * cs-parser.jay (local_variable_type): Correct and implement.
33087 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
33089 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
33091 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
33092 name and the specifiers.
33094 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
33096 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
33097 making them all public ;-)
33099 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
33102 2001-09-07 Miguel de Icaza <miguel@ximian.com>
33104 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
33106 (FieldExpr, PropertyExprs): New resolved expressions.
33107 (SimpleName::MemberStaticCheck): Perform static checks for access
33108 to non-static fields on static methods. Maybe this should be
33109 generalized for MemberAccesses.
33110 (SimpleName::ResolveSimpleName): More work on simple name
33113 * cs-parser.jay (primary_expression/qualified_identifier): track
33114 the parameter index.
33116 * codegen.cs (CodeGen::Save): Catch save exception, report error.
33117 (EmitContext::EmitBoolExpression): Chain to expression generation
33118 instead of temporary hack.
33119 (::EmitStatementExpression): Put generic expression code generation.
33121 * assign.cs (Assign::Emit): Implement variable assignments to
33122 local variables, parameters and fields.
33124 2001-09-06 Miguel de Icaza <miguel@ximian.com>
33126 * statement.cs (Block::GetVariableInfo): New method, returns the
33127 VariableInfo for a variable name in a block.
33128 (Block::GetVariableType): Implement in terms of GetVariableInfo
33130 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
33131 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
33133 2001-09-06 Ravi Pratap <ravi@ximian.com>
33135 * cs-parser.jay (operator_declaration): Continue on my quest : update
33136 to take attributes argument.
33137 (event_declaration): Ditto.
33138 (enum_declaration): Ditto.
33139 (indexer_declaration): Ditto.
33141 * class.cs (Operator::Operator): Update constructor accordingly.
33142 (Event::Event): Ditto.
33144 * delegate.cs (Delegate::Delegate): Same here.
33146 * enum.cs (Enum::Enum): Same here.
33148 2001-09-05 Ravi Pratap <ravi@ximian.com>
33150 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
33152 * ../tests/cs0658.cs : New file to demonstrate error 0658.
33154 * attribute.cs (Attributes): New class to encapsulate all attributes which were
33155 being passed around as an arraylist.
33156 (Attributes::AddAttribute): Method to add attribute sections.
33158 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
33159 (struct_declaration): Update accordingly.
33160 (constant_declaration): Update.
33161 (field_declaration): Update.
33162 (method_header): Update.
33163 (fixed_parameter): Update.
33164 (parameter_array): Ditto.
33165 (property_declaration): Ditto.
33166 (destructor_declaration): Ditto.
33168 * class.cs (Struct::Struct): Update constructors accordingly.
33169 (Class::Class): Ditto.
33170 (Field::Field): Ditto.
33171 (Method::Method): Ditto.
33172 (Property::Property): Ditto.
33173 (TypeContainer::OptAttribute): update property's return type.
33175 * interface.cs (Interface.opt_attributes): New member.
33176 (Interface::Interface): Update to take the extra Attributes argument.
33178 * parameter.cs (Parameter::Parameter): Ditto.
33180 * constant.cs (Constant::Constant): Ditto.
33182 * interface.cs (InterfaceMemberBase): New OptAttributes field.
33183 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
33184 the attributes as a parameter.
33185 (InterfaceProperty): Update constructor call.
33186 (InterfaceEvent): Ditto.
33187 (InterfaceMethod): Ditto.
33188 (InterfaceIndexer): Ditto.
33190 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
33191 pass the attributes too.
33192 (interface_event_declaration): Ditto.
33193 (interface_property_declaration): Ditto.
33194 (interface_method_declaration): Ditto.
33195 (interface_declaration): Ditto.
33197 2001-09-05 Miguel de Icaza <miguel@ximian.com>
33199 * class.cs (Method::Define): Track the "static Main" definition to
33200 create an entry point.
33202 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
33203 EntryPoint if we find it.
33205 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
33206 (EmitContext::ig): Make this variable public.
33208 * driver.cs: Make the default output file be the first file name
33209 with the .exe extension.
33211 Detect empty compilations
33213 Handle various kinds of output targets. Handle --target and
33214 rename -t to --dumper.
33216 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
33217 methods inherited from Expression return now an Expression. This
33218 will is used during the tree rewriting as we resolve them during
33221 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
33222 the spec. Missing entirely is the information about
33223 accessability of elements of it.
33225 (Expression::ExprClassFromMemberInfo): New constructor for
33226 Expressions that creates a fully initialized Expression based on
33227 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
33230 (Invocation::Resolve): Begin implementing resolution of invocations.
33232 * literal.cs (StringLiteral): Implement Emit.
33234 2001-09-05 Ravi Pratap <ravi@ximian.com>
33236 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
33239 2001-09-04 Ravi Pratap <ravi@ximian.com>
33241 * cs-parser.jay (attribute_arguments): Implement actions.
33242 (attribute): Fix bug in production. Implement action.
33243 (attribute_list): Implement.
33244 (attribute_target): Implement.
33245 (attribute_target_specifier, opt_target_specifier): Implement
33246 (CheckAttributeTarget): New method to check if the attribute target
33248 (attribute_section): Implement.
33249 (opt_attributes): Implement.
33251 * attribute.cs : New file to handle attributes.
33252 (Attribute): Class to hold attribute info.
33254 * cs-parser.jay (opt_attribute_target_specifier): Remove production
33255 (attribute_section): Modify production to use 2 different rules to
33256 achieve the same thing. 1 s/r conflict down !
33257 Clean out commented, useless, non-reducing dimension_separator rules.
33259 * class.cs (TypeContainer.attributes): New member to hold list
33260 of attributes for a type.
33261 (Struct::Struct): Modify to take one more argument, the attribute list.
33262 (Class::Class): Ditto.
33263 (Field::Field): Ditto.
33264 (Method::Method): Ditto.
33265 (Property::Property): Ditto.
33267 * cs-parser.jay (struct_declaration): Update constructor call to
33268 pass in the attributes too.
33269 (class_declaration): Ditto.
33270 (constant_declaration): Ditto.
33271 (field_declaration): Ditto.
33272 (method_header): Ditto.
33273 (fixed_parameter): Ditto.
33274 (parameter_array): Ditto.
33275 (property_declaration): Ditto.
33277 * constant.cs (Constant::Constant): Update constructor similarly.
33278 Use System.Collections.
33280 * parameter.cs (Parameter::Parameter): Update as above.
33282 2001-09-02 Ravi Pratap <ravi@ximian.com>
33284 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33285 (TypeContainer.delegates): New member to hold list of delegates.
33287 * cs-parser.jay (delegate_declaration): Implement the action correctly
33288 this time as I seem to be on crack ;-)
33290 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33292 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33293 tell whether an identifier represents a namespace.
33295 * expression.cs (NamespaceExpr): A namespace expression, used only
33296 temporarly during expression resolution.
33297 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33298 utility functions to resolve names on expressions.
33300 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33302 * codegen.cs: Add hook for StatementExpressions.
33304 * class.cs: Fix inverted test for static flag in methods.
33306 2001-09-02 Ravi Pratap <ravi@ximian.com>
33308 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33309 to make it coincide with MS' number.
33310 (Operator::CheckBinaryOperator): Ditto.
33312 * ../errors/errors.txt : Remove error numbers added earlier.
33314 * ../errors/cs1019.cs : Test case for error # 1019
33316 * ../errros/cs1020.cs : Test case for error # 1020
33318 * cs-parser.jay : Clean out commented cruft.
33319 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33320 used anywhere - non-reducing rule.
33321 (namespace_declarations): Non-reducing rule - comment out.
33323 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33324 with TypeContainer::AddEnum.
33326 * delegate.cs : New file for delegate handling classes.
33327 (Delegate): Class for declaring delegates.
33329 * makefile : Update.
33331 * cs-parser.jay (delegate_declaration): Implement.
33333 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33335 * class.cs (Event::Define): Implement.
33336 (Event.EventBuilder): New member.
33338 * class.cs (TypeContainer::Populate): Update to define all enums and events
33340 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33341 readonly fields for all these cases ?
33343 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33345 * class.cs (Property): Revamp to use the convention of making fields readonly.
33346 Accordingly modify code elsewhere.
33348 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33349 the Define method of the Property class.
33351 * class.cs : Clean up applied patch and update references to variables etc. Fix
33353 (TypeContainer::Populate): Update to define all the properties we have. Also
33354 define all enumerations.
33356 * enum.cs (Define): Implement.
33358 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33360 * cs-parser.jay (overloadable_operator): The semantic value is an
33361 enum of the Operator class.
33362 (operator_declarator): Implement actions.
33363 (operator_declaration): Implement.
33365 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33366 validity of definitions.
33367 (Operator::CheckBinaryOperator): Static method to check for binary operators
33368 (TypeContainer::AddOperator): New method to add an operator to a type.
33370 * cs-parser.jay (indexer_declaration): Added line to actually call the
33371 AddIndexer method so it gets added ;-)
33373 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33374 already taken care of by the MS compiler ?
33376 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33378 * class.cs (Operator): New class for operator declarations.
33379 (Operator::OpType): Enum for the various operators.
33381 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33383 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33384 ostensibly handle this in semantic analysis.
33386 * cs-parser.jay (general_catch_clause): Comment out
33387 (specific_catch_clauses, specific_catch_clause): Ditto.
33388 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33389 (catch_args, opt_catch_args): New productions.
33390 (catch_clause): Rewrite to use the new productions above
33391 (catch_clauses): Modify accordingly.
33392 (opt_catch_clauses): New production to use in try_statement
33393 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33394 and re-write the code in the actions to extract the specific and
33395 general catch clauses by being a little smart ;-)
33397 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33398 Hooray, try and catch statements parse fine !
33400 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33402 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33403 string from the hashtable of variables.
33405 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33406 I end up making that mistake ;-)
33407 (catch_clauses): Fixed gross error which made Key and Value of the
33408 DictionaryEntry the same : $1 !!
33410 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33412 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33414 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33415 when the add and remove accessors are specified.
33417 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33419 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33420 information about indexer_declarator.
33421 (indexer_declarator): Implement actions.
33422 (parsing_indexer): New local boolean used to keep track of whether
33423 we are parsing indexers or properties. This is necessary because
33424 implicit_parameters come into picture even for the get accessor in the
33425 case of an indexer.
33426 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33428 * class.cs (Indexer): New class for indexer declarations.
33429 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33430 (TypeContainer::indexers): New member to hold list of indexers for the
33433 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33435 * cs-parser.jay (add_accessor_declaration): Implement action.
33436 (remove_accessor_declaration): Implement action.
33437 (event_accessors_declaration): Implement
33438 (variable_declarators): swap statements for first rule - trivial.
33440 * class.cs (Event): New class to hold information about event
33442 (TypeContainer::AddEvent): New method to add an event to a type
33443 (TypeContainer::events): New member to hold list of events.
33445 * cs-parser.jay (event_declaration): Implement actions.
33447 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33449 * cs-parser.jay (dim_separators): Implement. Make it a string
33450 concatenating all the commas together, just as they appear.
33451 (opt_dim_separators): Modify accordingly
33452 (rank_specifiers): Update accordingly. Basically do the same
33453 thing - instead, collect the brackets here.
33454 (opt_rank_sepcifiers): Modify accordingly.
33455 (array_type): Modify to actually return the complete type string
33456 instead of ignoring the rank_specifiers.
33457 (expression_list): Implement to collect the expressions
33458 (variable_initializer): Implement. We make it a list of expressions
33459 essentially so that we can handle the array_initializer case neatly too.
33460 (variable_initializer_list): Implement.
33461 (array_initializer): Make it a list of variable_initializers
33462 (opt_array_initializer): Modify accordingly.
33464 * expression.cs (New::NType): Add enumeration to help us
33465 keep track of whether we have an object/delegate creation
33466 or an array creation.
33467 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33468 members to hold data about array creation.
33469 (New:New): Modify to update NewType
33470 (New:New): New Overloaded contructor for the array creation
33473 * cs-parser.jay (array_creation_expression): Implement to call
33474 the overloaded New constructor.
33476 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33478 * class.cs (TypeContainer::Constructors): Return member
33479 constructors instead of returning null.
33481 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33483 * typemanager.cs (InitCoreTypes): Initialize the various core
33484 types after we have populated the type manager with the user
33485 defined types (this distinction will be important later while
33486 compiling corlib.dll)
33488 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33489 on Expression Classification. Now all expressions have a method
33490 `Resolve' and a method `Emit'.
33492 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33493 generation from working. Also add some temporary debugging
33496 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33498 * codegen.cs: Lots of code generation pieces. This is only the
33499 beginning, will continue tomorrow with more touches of polish. We
33500 handle the fundamentals of if, while, do, for, return. Others are
33501 trickier and I need to start working on invocations soon.
33503 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33506 * codegen.cs (EmitContext): New struct, used during code
33507 emission to keep a context. Most of the code generation will be
33510 * cs-parser.jay: Add embedded blocks to the list of statements of
33511 this block. So code generation proceeds in a top down fashion.
33513 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33515 * statement.cs: Add support for multiple child blocks.
33517 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33519 * codegen.cs (EmitCode): New function, will emit the code for a
33520 Block of code given a TypeContainer and its ILGenerator.
33522 * statement.cs (Block): Standard public readonly optimization.
33523 (Block::Block constructors): Link children.
33524 (Block::Child): Child Linker.
33525 (Block::EmitVariables): Emits IL variable declarations.
33527 * class.cs: Drop support for MethodGroups here, delay until
33529 (Method::): Applied the same simplification that I did before, and
33530 move from Properties to public readonly fields.
33531 (Method::ParameterTypes): Returns the parameter types for the
33532 function, and implements a cache that will be useful later when I
33533 do error checking and the semantic analysis on the methods is
33535 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33536 and made a method, optional argument tells whether this is a class
33537 or a structure to apply the `has-this' bit.
33538 (Method::GetCallingConvention): Implement, returns the calling
33540 (Method::Define): Defines the type, a second pass is performed
33541 later to populate the methods.
33543 (Constructor::ParameterTypes): implement a cache similar to the
33544 one on Method::ParameterTypes, useful later when we do semantic
33547 (TypeContainer::EmitMethod): New method. Emits methods.
33549 * expression.cs: Removed MethodGroup class from here.
33551 * parameter.cs (Parameters::GetCallingConvention): new method.
33553 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33555 * class.cs (TypeContainer::Populate): Drop RootContext from the
33558 (Constructor::CallingConvention): Returns the calling convention.
33559 (Constructor::ParameterTypes): Returns the constructor parameter
33562 (TypeContainer::AddConstructor): Keep track of default constructor
33563 and the default static constructor.
33565 (Constructor::) Another class that starts using `public readonly'
33566 instead of properties.
33568 (Constructor::IsDefault): Whether this is a default constructor.
33570 (Field::) use readonly public fields instead of properties also.
33572 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33573 track of static constructors; If none is used, turn on
33574 BeforeFieldInit in the TypeAttributes.
33576 * cs-parser.jay (opt_argument_list): now the return can be null
33577 for the cases where there are no arguments.
33579 (constructor_declarator): If there is no implicit `base' or
33580 `this', then invoke the default parent constructor.
33582 * modifiers.cs (MethodAttr): New static function maps a set of
33583 modifiers flags into a MethodAttributes enum
33584 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33585 MethodAttr, TypeAttr to represent the various mappings where the
33586 modifiers are used.
33587 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33589 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33591 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33594 * interface.cs (PopulateIndexer): Implemented the code generator
33595 for interface indexers.
33597 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33599 * interface.cs (InterfaceMemberBase): Now we track the new status
33602 (PopulateProperty): Implement property population. Woohoo! Got
33603 Methods and Properties going today.
33605 Removed all the properties for interfaces, and replaced them with
33606 `public readonly' fields.
33608 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33610 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33611 initialize their hashtables/arraylists only when they are needed
33612 instead of doing this always.
33614 * parameter.cs: Handle refs and out parameters.
33616 * cs-parser.jay: Use an ArrayList to construct the arguments
33617 instead of the ParameterCollection, and then cast that to a
33620 * parameter.cs: Drop the use of ParameterCollection and use
33621 instead arrays of Parameters.
33623 (GetParameterInfo): Use the Type, not the Name when resolving
33626 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33628 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33629 and instead use public readonly fields.
33631 * class.cs: Put back walking code for type containers.
33633 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33635 * class.cs (MakeConstant): Code to define constants.
33637 * rootcontext.cs (LookupType): New function. Used to locate types
33640 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33642 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33643 this System.Reflection code is. Kudos to Microsoft
33645 * typemanager.cs: Implement a type cache and avoid loading all
33646 types at boot time. Wrap in LookupType the internals. This made
33647 the compiler so much faster. Wow. I rule!
33649 * driver.cs: Make sure we always load mscorlib first (for
33650 debugging purposes, nothing really important).
33652 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33653 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33655 * rootcontext.cs: Lookup types on their namespace; Lookup types
33656 on namespaces that have been imported using the `using' keyword.
33658 * class.cs (TypeContainer::TypeAttr): Virtualize.
33659 (Class::TypeAttr): Return attributes suitable for this bad boy.
33660 (Struct::TypeAttr): ditto.
33661 Handle nested classes.
33662 (TypeContainer::) Remove all the type visiting code, it is now
33663 replaced with the rootcontext.cs code
33665 * rootcontext.cs (GetClassBases): Added support for structs.
33667 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33669 * interface.cs, statement.cs, class.cs, parameter.cs,
33670 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33671 Drop use of TypeRefs, and use strings instead.
33673 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33677 * class.cs (Struct::Struct): set the SEALED flags after
33678 checking the modifiers.
33679 (TypeContainer::TypeAttr): new property, returns the
33680 TypeAttributes for a class.
33682 * cs-parser.jay (type_list): Oops, list production was creating a
33683 new list of base types.
33685 * rootcontext.cs (StdLib): New property.
33686 (GetInterfaceTypeByName): returns an interface by type name, and
33687 encapsulates error handling here.
33688 (GetInterfaces): simplified.
33689 (ResolveTree): Encapsulated all the tree resolution here.
33690 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33693 * driver.cs: Add support for --nostdlib, to avoid loading the
33694 default assemblies.
33695 (Main): Do not put tree resolution here.
33697 * rootcontext.cs: Beginning of the class resolution.
33699 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33701 * rootcontext.cs: Provide better error reporting.
33703 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33705 * rootcontext.cs (CreateInterface): Handle the case where there
33706 are no parent interfaces.
33708 (CloseTypes): Routine to flush types at the end.
33709 (CreateInterface): Track types.
33710 (GetInterfaces): Returns an array of Types from the list of
33711 defined interfaces.
33713 * typemanager.c (AddUserType): Mechanism to track user types (puts
33714 the type on the global type hash, and allows us to close it at the
33717 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33719 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33720 RecordInterface instead.
33722 * cs-parser.jay: Updated to reflect changes above.
33724 * decl.cs (Definition): Keep track of the TypeBuilder type that
33725 represents this type here. Not sure we will use it in the long
33726 run, but wont hurt for now.
33728 * driver.cs: Smaller changes to accomodate the new code.
33730 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33733 * rootcontext.cs (CreateInterface): New method, used to create
33734 the System.TypeBuilder type for interfaces.
33735 (ResolveInterfaces): new entry point to resolve the interface
33737 (CodeGen): Property, used to keep track of the code generator.
33739 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33741 * cs-parser.jay: Add a second production for delegate_declaration
33744 (enum_body): Put an opt_comma here instead of putting it on
33745 enum_body or enum_member_declarations so we can handle trailing
33746 commas on enumeration members. Gets rid of a shift/reduce.
33748 (type_list): Need a COMMA in the middle.
33750 (indexer_declaration): Tell tokenizer to recognize get/set
33752 * Remove old targets.
33754 * Re-add the parser target.
33756 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33758 * cs-parser.jay: Add precendence rules for a number of operators
33759 ot reduce the number of shift/reduce conflicts in the grammar.
33761 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33763 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33766 Get rid of old crufty code.
33768 * rootcontext.cs: Use this to keep track of the parsed
33769 representation and the defined types available to the program.
33771 * gen-treedump.cs: adjust for new convention.
33773 * type.cs: Split out the type manager, and the assembly builder
33776 * typemanager.cs: the type manager will live here now.
33778 * cil-codegen.cs: And the code generator here.
33780 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33782 * makefile: Fixed up for easy making.
33784 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33786 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33789 (unary_expression): Expand pre_increment_expression and
33790 post_decrement_expression to reduce a shift/reduce.
33792 2001-07-11 Simon Cozens
33794 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33796 Improve allow_keyword_as_indent name.
33798 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33800 * Adjustments for Beta2.
33802 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33804 * decl.cs: Added `Define' abstract method.
33805 (InTransit): new property, used to catch recursive definitions.
33807 * interface.cs: Implement `Define'.
33809 * modifiers.cs: Map Modifiers.constants to
33810 System.Reflection.TypeAttribute flags.
33812 * class.cs: Keep track of types and user-defined types.
33813 (BuilderInit): New method for creating an assembly
33814 (ResolveType): New function to launch the resolution process, only
33815 used by interfaces for now.
33817 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33818 that are inserted into the name space.
33820 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33822 * ARGH. I have screwed up my tree so many times due to the use of
33823 rsync rather than using CVS. Going to fix this at once.
33825 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33828 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33830 * Experiment successful: Use System.Type rather that our own
33833 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33835 * cs-parser.jay: Removed nsAliases from here.
33837 Use new namespaces, handle `using XXX;'
33839 * namespace.cs: Reimplemented namespace handling, use a recursive
33840 definition of the class. Now we can keep track of using clauses
33841 and catch invalid using clauses.
33843 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33845 * gen-treedump.cs: Adapted for all the renaming.
33847 * expression.cs (Expression): this class now has a Type property
33848 which returns an expression Type.
33850 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33851 `Type', as this has a different meaning now in the base
33853 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33855 * interface.cs, class.cs: Removed from all the sources the
33856 references to signature computation, as we can not do method
33857 signature computation during the parsing time, as we are not
33858 trying to solve at that point distinguishing:
33862 void a (NS.Blah x) {}
33865 Which depending on the context might be valid or not, as we do not
33866 know if Blah is the same thing as NS.Blah at that point.
33868 * Redid everything so the code uses TypeRefs now instead of
33869 Types. TypeRefs are just temporary type placeholders, that need
33870 to be resolved. They initially have a pointer to a string and the
33871 current scope in which they are used. This is used later by the
33872 compiler to resolve the reference to an actual Type.
33874 * DeclSpace is no longer a CIR.Type, and neither are
33875 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33876 are all DeclSpaces, but no Types.
33878 * type.cs (TypeRefManager): This implements the TypeRef manager,
33879 which keeps track of all the types that need to be resolved after
33880 the parsing has finished.
33882 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33884 * ARGH. We are going to have to store `foreach' as a class rather
33885 than resolving it, as we need to verify error 1579 after name
33886 resolution. *OR* we could keep a flag that says `This request to
33887 IEnumerator comes from a foreach statement' which we can then use
33888 to generate the error.
33890 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33892 * class.cs (TypeContainer.AddMethod): we now add methods to the
33893 MethodGroup instead of the method hashtable.
33895 * expression.cs: Add MethodGroup abstraction, which gets us one
33896 step closer to the specification in the way we handle method
33899 * cs-parser.jay (primary_expression): qualified_identifier now
33900 tried to match up an identifier to a local variable reference or
33901 to a parameter reference.
33903 current_local_parameters is now a parser global variable that
33904 points to the current parameters for the block, used during name
33907 (property_declaration): Now creates an implicit `value' argument to
33910 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33912 * parameter.cs: Do not use `param' arguments as part of the
33913 signature, per the spec.
33915 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33917 * decl.cs: Base class for classes, structs and interfaces. This
33918 is the "Declaration Space"
33920 * cs-parser.jay: Use CheckDef for checking declaration errors
33921 instead of having one on each function.
33923 * class.cs: Factor out some code for handling error handling in
33924 accordance to the "Declarations" section in the "Basic Concepts"
33925 chapter in the ECMA C# spec.
33927 * interface.cs: Make all interface member classes derive from
33928 InterfaceMemberBase.
33930 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33932 * Many things: all interfaces are parsed and generated in
33933 gen-treedump. Support for member variables, constructors,
33934 destructors, properties, constants is there.
33936 Beginning of the IL backend, but very little done, just there for
33939 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33941 * cs-parser.jay: Fix labeled statement.
33943 * cs-tokenizer.cs (escape): Escape " and ' always.
33944 ref_line, ref_name: keep track of the line/filename as instructed
33945 by #line by the compiler.
33948 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33950 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33951 to match the values in System.CodeDOM.
33953 Divid renamed to Divide.
33955 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33957 (Statements.set): remove.
33959 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33962 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33963 falseStatements always have valid values.
33965 * cs-parser.jay: Use System.CodeDOM now.