1 2005-02-01 Duncan Mak <duncan@ximian.com>
3 * const.cs (LookupConstantValue): Check that `ce' is not null
4 before calling GetValue ().
6 2005-02-01 Raja R Harinath <rharinath@novell.com>
8 Fix test-334.cs (#69519).
9 * cs-parser.jay (using_alias_directive): Pass in an expression to
10 NamespaceEntry.UsingAlias.
11 (using_namespace_directive): Pass in an expression to
13 (namespace_name): Don't flatten to a string.
14 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15 (NamespaceEntry.AliasEntry.Resolve): Lookup using
17 (NamespaceEntry.UsingEntry): Likewise.
18 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
20 (NamespaceEntry.LookupForUsing): Remove.
21 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
23 (NamespaceEntry.Lookup): Remove support for dotted names.
25 2005-02-01 Raja R Harinath <rharinath@novell.com>
27 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
29 (NamespaceEntry.ImplicitParent): Compute on demand.
30 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
31 parallels the current.
32 (NamespaceEntry.LookupForUsing): Use it.
33 (NamespaceEntry.Lookup): If the current namespace-entry is
34 implicit, don't search aliases and using tables.
36 2005-02-01 Raja R Harinath <rharinath@novell.com>
39 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
41 (TypeContainer.BaseCache): Compute on demand.
42 (TypeContainer.FindMembers): Define constants and types if they're
44 (FieldMember.Define): Move resetting of ec.InUnsafe before error
46 * const.cs (Constant.Define): Make idempotent.
48 2005-01-29 Miguel de Icaza <miguel@novell.com>
50 * pending.cs: Produce better code (no nops produced by using Ldarg
53 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
54 i - 1' it should be arg + 1.
58 2005-01-28 Raja R Harinath <rharinath@novell.com>
60 * attribute.cs (Attribute.CheckAttributeType): Make private
62 (Attribute.ResolveType): Make virtual.
63 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
64 handling of RootContext.Tree.Types.
66 2005-01-27 Raja R Harinath <rharinath@novell.com>
68 Update attribute-handling to use the SimpleName/MemberAccess
70 * cs-parser.jay (attribute): Pass in an expression to the
71 constructors of Attribute and GlobalAttribute.
72 * attribute.cs (Attribute): Take an expression for the name.
73 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
74 passed in attribute name expression.
75 (Attribute.CheckAttributeType): Use it.
76 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
77 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
78 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
79 argument to prevent error messages if the lookup fails.
81 2005-01-27 Marek Safar <marek.safar@seznam.cz>
83 * expression.cs (Indirection): Implemented IVariable interface
84 to support indirection in AddressOf operator.
85 (PointerArithmetic.Emit): Add optimalization for case where
86 result can be precomputed.
88 2005-01-26 Martin Baulig <martin@ximian.com>
90 * class.cs (TypeContainer.AttributeTargets): Return the correct
91 AttributeTargets depending on our `Kind' instead of throwing an
92 exception; fixes #71632.
94 2005-01-26 Marek Safar <marek.safar@seznam.cz>
97 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
100 2005-01-25 Raja R Harinath <rharinath@novell.com>
103 * expression.cs (MemberAccess.DoResolve): Don't complain with
104 cs0572 when the LHS of a member access has identical name and type
107 2005-01-25 Marek Safar <marek.safar@seznam.cz>
110 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
112 Create custom PermissionSet only for PermissionSetAttribute.
114 2005-01-24 Marek Safar <marek.safar@seznam.cz>
117 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
118 delegates in static class.
120 2005-01-24 Martin Baulig <martin@ximian.com>
122 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
123 merging an implicit block, just use its reachability.
125 * statement.cs (Block.Resolve): Make the unreachable code check
126 work wrt. implicit blocks; see test-337 from #63842.
128 2005-01-21 Alp Toker <alp@atoker.com>
130 * cs-parser.jay: destructor_declaration's container is PartialContainer
131 not Class when partial types are used, so use Kind prop instead of
134 2005-01-22 Miguel de Icaza <miguel@ximian.com>
136 * cs-parser.jay: Improve error reporting when an interface
139 2005-01-20 Dick Porter <dick@ximian.com>
141 * support.cs: SeekableStreamReader fix from Sandor Dobos
142 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
143 chars are read. Fixes bug 70369.
145 2005-01-20 Raja R Harinath <rharinath@novell.com>
147 * cs-parser.jay (catch_clause): Simplify current_block handling
150 2005-01-17 Miguel de Icaza <miguel@ximian.com>
152 * convert.cs (ImplicitStandardConversionExists): Synchronize the
153 code with ImplicitStandardConversion to handle the implicit
154 conversion of method groups into valid delegate invocations.
156 The problem is that in parameter handling we were using this code
157 path. Fixes bug #64698
159 2005-01-19 Raja R Harinath <rharinath@novell.com>
161 * cs-parser.jay: Fix several infelicities.
162 - Avoid assigning to the parser value stack. Code like
163 '$3 = null' is unclean. Synthesize a value for the code block
165 - Avoid using oob_stack for storing location information. Use ...
166 (_mark_): ... this. New (empty) rule. Saves the current location
168 (foreach_statement): Avoid using oob_stack for current_block
169 handling. Use technique used in for_statement and
170 using_statement. Synthesize a value for the code block to store
171 additional intermediate information.
173 2005-01-13 Miguel de Icaza <miguel@ximian.com>
175 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
176 of a different type is only allowed to private fields of a
177 containing type, not on fields of a base class.
179 See test-174.cs and error cs0122-9.cs
181 2005-01-13 Raja R Harinath <rharinath@novell.com>
183 Fix test-335.cs (bug #58126).
184 * cs-parser.jay (argument): Split out non-expression parts of the
185 rule into 'non_simple_argument'.
186 (invocation_expression): Support parenthesized invocations with
187 multiple arguments, and with single non-simple arguments.
189 2005-01-13 Raja R Harinath <rharinath@novell.com>
191 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
194 2005-01-12 Raja R Harinath <rharinath@novell.com>
196 Fix cs0038-1.cs, cs1640-6.cs.
197 * ecore.cs (Expression.Resolve): Remove special-case for
198 SimpleName in error-handling.
199 (Expression.almostMatchedMembers): Relax access permission to
201 (Expression.MemberLookupFailed): Handle duplicates in
202 almostMatchedMembers list.
203 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
204 * expression.cs (New.DoResolve): Report CS1540 for more cases.
205 * typemanager.cs (GetFullNameSignature): Use the MethodBase
206 overload if the passed in MemberInfo is a MethodBase.
208 2005-01-12 Marek Safar <marek.safar@seznam.cz>
211 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
212 for non-CAS & merge permission sets properly.
214 2005-01-11 Raja R Harinath <rharinath@novell.com>
216 Improve standard-compliance of simple name and member access
217 resolution. Fixes bugs #52697, #57200, #67520, #69519.
218 * ecore.cs (FullNamedExpression): New abstract base class
219 for Namespaces and TypeExpressions.
220 (ResolveFlags.SimpleName): Remove.
221 (SimpleName): Remove support for dotted names.
222 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
223 DeclSpace.FindType and DeclSpace.LookupType.
224 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
225 (Expression.ExprClassName): Make member function.
226 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
227 a namespace. Remove creation of dotted "SimpleName"s.
228 (MemberAccess.DoResolve): Likewise.
229 * decl.cs (DeclSpace.Cache): Make private.
230 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
231 (DeclSpace.FindType): Update.
232 (DeclSpace.LookupType): Move here from RootContext. Return a
234 * namespace.cs (Namespace): Derive from FullNamedExpression
235 so that it can be part of expression resolution.
236 (Namespace.Lookup): Return an FullNamedExpression.
237 (NamespaceEntry.LookupAlias): Lookup aliases only in current
239 * rootcontext.cs (NamespaceLookup): Remove.
240 (LookupType): Move to DeclSpace.
241 * attribute.cs (CheckAttributeType): Update.
242 * doc.cs (FindDocumentedType): Remove allowAlias argument.
243 (FindDocumentedTypeNonArray): Likewise.
245 2005-01-11 Raja R Harinath <rharinath@novell.com>
247 Fix cs0509.cs, cs1632.cs.
248 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
249 is the same as IsInterface.
250 (TypeContainer.GetClassBases): Likewise.
251 * statement.cs (LabeledStatement.ig): New field.
252 (LabeledStatement.LabelTarget): Save ILGenerator which created the
254 (LabeledStatement.DoEmit): Check that the label was created with
255 the same ILGenerator.
257 2005-01-10 Marek Safar <marek.safar@seznam.cz>
260 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
261 accessors to its properties.
263 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
264 from accessors to property.
266 2005-01-10 Marek Safar <marek.safar@seznam.cz>
269 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
272 2005-01-08 Miguel de Icaza <miguel@ximian.com>
274 * attribute.cs: Check for null and empty strings.
276 I have lost another battle to Paolo.
278 2005-01-07 Marek Safar <marek.safar@seznam.cz>
281 * class.cs (PropertyMethod): Set Parent field in ctors.
282 (SetMethod.InternalParameters): Add unsafe switch hack.
283 Override MarkForDuplicationCheck where it is appropriate.
285 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
286 It says whether container allows members with the same name.
288 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
289 Removed is_method parameter.
291 2005-01-06 Duncan Mak <duncan@ximian.com>
293 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
294 because the previous change led to incorrect reporting of CS1032
295 ("Cannot define/undefine preprocessor symbols after first token in
296 file"). Instead of using `tokens_seen' as the only flag that
297 triggers CS1040, introduce `comments_seen'. This new flag is used
298 to signify having seen comments on the current line, so it is
299 unset after a newline.
301 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
303 * doc.cs : When searching for a type, find nested type too.
304 This fixes bug #71040.
306 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
309 - Warn missing member comment on those classes which also does not
310 have doc comments. Fixed bug #71041.
311 - Don't warn missing doc comment on default constructor.
314 2005-01-06 Duncan Mak <duncan@ximian.com>
316 * cs-tokenizer.cs (xtoken): After handling traditional C-style
317 comments, set `tokens_seen' to true. This allows us to detect
318 misplaced preprocessor directives (i.e. not at the beginning of
319 the a line, nor after whitespaces). In that case, report error
320 CS1040. This fixes bug #56460.
322 * cs-parser.jay (interface_member_declaration): Add checks for
323 IsExplicitImpl, and report CS0541 error if an interface member is
324 defined as an explicit interface declaration.
326 2005-01-06 Marek Safar <marek.safar@seznam.cz>
329 * class.cs (PropertyMethod): Set Parent field in ctors.
330 (SetMethod.InternalParameters): Add unsafe switch hack.
332 * decl.cs (MemberCore.Parent): Cannot be readonly.
334 2005-01-06 Raja R Harinath <rharinath@novell.com>
336 * decl.cs (DeclSpace.ResolveType): Remove.
337 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
338 Merge in code from ...
339 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
340 * class.cs, enum.cs: Update to changes.
342 2005-01-06 Miguel de Icaza <miguel@ximian.com>
344 * anonymous.cs: Ensure that we init the scope of our parent if it
345 has not been initialized yet.
347 2004-12-30 Duncan Mak <duncan@ximian.com>
349 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
350 if field.FieldBuilder is null. Fixes #70758.
352 * convert.cs: Fixed some typos and updated some of the comments.
353 (ImplicitStandardConversionExists):
354 (TryImplicitIntConversion): If `target_type' is an interface and
355 the type of `ic' implements this interface, return true or a new
356 BoxedCast instead of null. This fixes #70468.
358 2004-12-29 Duncan Mak <duncan@ximian.com>
360 * expression.cs (Argument.Emit): Check that Expr is
361 IMemoryLocation before casting to it, and report CS1510 otherwise.
365 2004-12-21 Ben Maurer <bmaurer@ximian.com>
367 * statement.cs (Block.ThisVariable): remove the recursion here, to
368 make the --profile more sane.
370 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
372 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
373 assembly, by JB Evain.
375 2004-12-17 Raja R Harinath <rharinath@novell.com>
377 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
378 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
379 "parent" refers to enclosing type/class. "base" refers to superclass.
381 2004-12-17 Raja R Harinath <rharinath@novell.com>
383 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
384 Ensure that we only have GlobalAttributes.
385 * attribute.cs (Attribute.Emit): Make non-virtual.
386 (GlobalAttribute.Emit): Remove.
387 (Attribute.Resolve): Make virtual.
388 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
389 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
390 the argument. Don't create one.
391 (Attribute.GetObsoleteAttribute): Likewise.
392 (Attribute.GetClsCompliantAttributeValue): Likewise.
393 * class.cs, decl.cs: Update to changes.
395 2004-12-17 Marek Safar <marek.safar@seznam.cz>
397 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
399 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
401 * statement.cs (Foreach.Resolve): Add error 186 report.
403 2004-12-16 Marek Safar <marek.safar@seznam.cz>
405 * expression.cs (Conditional.DoResolve): Add warning 429.
407 * statement.cs (If.Resolve): Add warning 665.
409 2004-12-16 Raja R Harinath <rharinath@novell.com>
411 New invariant: RootContext.Tree.Types.NamespaceEntry == null
412 except when in the parser, and in GlobalAttribute.
413 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
414 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
415 RootContext.Tree.Types.NamespaceEntry once work is done.
416 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
417 and resets RootContext.Tree.Types.NamespaceEntry.
419 2004-12-15 Marek Safar <marek.safar@seznam.cz>
421 * cs-parser.jay: Don't create a block for every variable.
423 2004-12-14 Miguel de Icaza <miguel@ximian.com>
425 * location.cs: Provide extra information.
427 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
428 variables from the captured environment, it is the ldarg_0.
430 2004-12-14 Marek Safar <marek.safar@seznam.cz>
432 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
435 * class.cs: Changed warning level for 169 to avoid developer
436 displeasure from warning flooding. It will be changed back when they
437 fix most of current BCL warnings.
439 * RootContext.cs: Pushed default WarningLevel to 3.
441 * statement.cs: Removed unused variable.
443 2004-12-14 Marek Safar <marek.safar@seznam.cz>
445 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
446 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
447 Add error 502 report.
448 (StaticClass.DefineType): Add error 441 report.
449 (Class.AllowedModifiersProp): New virtual property as temporary
450 extension to AllowedModifiers.
451 (Class.DefineType): Add error 418 report. Moved ModFlags check here
452 to share implementation with StaticClass and don't call virtual
455 * driver.cs (MainDriver): Add error 1558 test.
457 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
458 report. Moved error 36 test here.
460 * statement.cs (Throw.Resolve): Add error 724 report.
462 * typemanager.cs: Add out_attribute_type core type.
464 2004-12-13 Marek Safar <marek.safar@seznam.cz>
466 * class.cs (TypeContainer.VerifyClsCompliance): Add error
468 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
470 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
473 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
475 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
476 Add error 3023 report.
477 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
479 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
482 2004-12-12 John Luke <john.luke@gmail.com>
484 * driver.cs (AddArgs): take -- into account when
485 adding arguments, fixes bug 65710
487 2004-12-12 Martin Baulig <martin@ximian.com>
489 * expression.cs (Unary.TryReduceNegative): Added support for
490 SByteConstant and ByteConstant.
491 (Unary.Reduce): Check error values from TryReduceNegative().
493 2004-12-10 Marek Safar <marek.safar@seznam.cz>
495 * attributes.cs (Attribute.Resolve): Avoid multiple error report
496 and report exception as error 182.
498 2004-12-10 Raja R Harinath <rharinath@novell.com>
500 * driver.cs (Main): Fix message when there are warnings.
502 2004-12-09 Miguel de Icaza <miguel@ximian.com>
504 * delegate.cs: Fixed my fix from yesterday, sorry about that.
506 2004-12-09 Marek Safar <marek.safar@seznam.cz>
508 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
509 Reduced number of warnings.
511 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
513 2004-12-08 Miguel de Icaza <miguel@ximian.com>
515 * driver.cs: Removed message.
517 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
519 2004-12-08 <vargaz@freemail.hu>
521 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
523 2004-12-08 Martin Baulig <martin@ximian.com>
525 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
526 instead of a CS3002 for properties and indexer.
528 2004-12-08 Martin Baulig <martin@ximian.com>
530 * decl.cs (MemberName.ToString): Make this work again.
532 2004-12-08 Marek Safar <marek.safar@seznam.cz>
534 * attribute.cs (Resolve): Add error 591 detection.
536 * class.cs (FieldMember.Define): Add error 1547 detection.
537 (Indexer.Define): Add error 620 detection.
538 (Operator.Define): Add error 590 detection.
540 * ecore.cs: Missing argument for error 79.
542 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
545 2004-12-07 Marek Safar <marek.safar@seznam.cz>
548 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
551 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
553 * cs-parser.jay : handle doc comments on implicit/explicit operators.
554 Some operator comments were suppressed.
555 * doc.cs : Implicit/explicit operator name in doc comments are like
556 "op_Explicit(type)~returnType", so added suffix handling.
558 2004-12-07 Martin Baulig <martin@ximian.com>
561 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
562 (MemberCore.GetClsCompliantAttributeValue): Likewise.
563 (DeclSpace.ec): New protected field; store the EmitContext here.
564 (DeclSpace.EmitContext): New public property; moved here from
566 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
569 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
570 (Enum.Emit): Don't create a new EmitContext.
572 * delegate.cs (Delegate.DefineType): Always create the
575 * iterators.cs (Iterators.DefineIterator): Create a new
576 EmitContext and store it in `ec'.
578 2004-08-24 Martin Baulig <martin@ximian.com>
581 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
582 this for accessibility checks.
583 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
584 IsNestedFamilyAccessible.
585 (TypeManager.IsSubclassOf): New method, do what the name actually
588 2004-12-06 Raja R Harinath <rharinath@novell.com>
590 Fix crash on cs0657-17.cs.
591 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
592 Use RootContext.Tree.Types, not 'new RootTypes ()'.
593 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
594 the case where the NamespaceEntry gets overwritten.
596 2004-12-06 Marek Safar <marek.safar@seznam.cz>
599 * ecore.cs (ResolveBoolean): Tiny refactoring.
601 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
602 of right expression resolving when left is false constant and
603 operator is LogicalAnd OR true constant and operator is LogicalOr.
605 * statement.cs (ResolveUnreachable): Always reports warning.
607 2004-12-05 Miguel de Icaza <miguel@ximian.com>
609 * class.cs: Distinguish between 1721 and 1722 (just a little help
612 2004-12-03 Miguel de Icaza <miguel@ximian.com>
614 * delegate.cs: Only allow this on new versions of the language.
616 2004-12-02 Duncan Mak <duncan@ximian.com>
618 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
620 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
621 here as a static method. Take an additional bool out parameter
622 `must_do_cs1540_check' for signaling to InstanceResolve.
623 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
624 member field from PropertyExpr class and made it an argument of
626 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
627 check for MarshalByRefObject, and report CS0122 instead of CS1540.
628 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
629 and `remove_accessor' as well as InstanceResolve: report CS0122
634 2004-12-03 Raja R Harinath <rharinath@novell.com>
636 Fix test-327.cs, test-328.cs, and put in early infrastructure
637 for eventually fixing #52697.
638 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
639 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
641 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
642 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
643 (VerifyUsing, error246): Update.
644 * rootcontext.cs (RootContext.NamespaceLookup): Just use
645 'NamespaceEntry.LookupNamespaceOrType'.
647 2004-12-03 Martin Baulig <martin@ximian.com>
649 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
650 method as our child, call AnonymousMethod.Compatible() on it.
652 2004-12-03 Raja R Harinath <rharinath@novell.com>
654 Disable XML documentation support in 'basic' profile.
655 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
656 Redirect XmlElement to System.Object.
657 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
658 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
659 * mcs.exe.sources: Add doc-bootstrap.cs.
660 * doc-bootstrap.cs: New file. Contains empty stub implementation
663 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
665 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
666 comments are allowed.
668 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
670 * delegate.cs: Add checks for subtypes in paramaters and return values
671 in VerifyMethod () to add support for Covariance/Contravariance
674 2004-12-02 Miguel de Icaza <miguel@ximian.com>
676 * report.cs: Remove extra closing parenthesis.
678 * convert.cs (Error_CannotImplicitConversion): If the name of the
679 types are the same, provide some extra information.
681 * class.cs (FieldBase): Use an unused bit field from the field to
682 encode the `has_offset' property from the FieldMember. This saves
683 a couple of Ks on bootstrap compilation.
685 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
686 method as our child, return the AnonymousMethod resolved
689 * expression.cs (New.DoResolve): Allow return values from
690 NewDelegate to also include AnonymousMethods.
694 2004-12-02 Marek Safar <marek.safar@seznam.cz>
697 * attribute.cs (Resolve): Improved implementation of params
700 * support.cs (ParameterData): Add HasParams to be faster.
702 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
704 all things are for /doc support:
706 * doc.cs: new file that supports XML documentation generation.
707 * mcs.exe.sources: added doc.cs.
709 Handle /doc command line option.
710 Report error 2006 instead of 5 for missing file name for /doc.
711 Generate XML documentation when required, after type resolution.
713 Added support for picking up documentation (/// and /** ... */),
714 including a new XmlCommentState enumeration.
716 Added lines to fill Documentation element for field, constant,
717 property, indexer, method, constructor, destructor, operator, event
718 and class, struct, interface, delegate, enum.
719 Added lines to warn incorrect comment.
721 Added Documentation field (passed only when /doc was specified).
723 Added DocComment, DocCommentHeader, GenerateDocComment() and
724 OnGenerateDocComment() and some supporting private members for
725 /doc feature to MemberCore.
727 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
729 Added overriden DocCommentHeader.
731 Added overriden DocCommentHeader and GenerateDocComment().
733 2004-12-01 Miguel de Icaza <miguel@ximian.com>
735 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
736 unwrapping the enumeration values, chain to
737 DoConstantNumericPromotions again, so we can promote things to the
738 fundamental types (takes care of enums that are bytes, sbytes).
742 2004-12-01 Raja R Harinath <rharinath@novell.com>
744 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
745 Fix long-standing bug in type-lookup. Use FindType instead of
746 LookupType when ec.ResolvingTypeTree.
747 (Attribute.ResolveType, Attribute.Resolve)
748 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
750 (Attributes.Search): Remove internal version. Update.
751 (Attributes.SearchMulti): Update.
752 (Attributes.GetClsCompliantAttribute): Remove.
753 (Attributes.GetIndexerNameAttribute): Remove.
754 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
755 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
756 * class.cs (Indexer.Define): Likewise.
758 2004-12-01 Marek Safar <marek.safar@seznam.cz>
761 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
762 MarshallByReference members access.
764 * expression.cs: Use CheckMarshallByRefAccess;
765 Better error CS0197 message.
767 * report.cs: Print whole related error message.
769 2004-11-30 Raja R Harinath <rharinath@novell.com>
771 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
772 the current directory to help debugging.
774 2004-11-29 Marek Safar <marek.safar@seznam.cz>
776 * class (GetClassBases): Better error 60 report.
777 (EventProperty): Disabled warning 67 detection.
779 2004-11-29 Marek Safar <marek.safar@seznam.cz>
782 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
784 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
787 2004-11-29 Marek Safar <marek.safar@seznam.cz>
790 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
792 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
794 2004-11-26 Miguel de Icaza <miguel@ximian.com>
796 * attribute.cs (Attribute.Resolve): Refine error reporting and
797 report a cs0117 if the identifier does not exist, to distinguish
798 from 0617 which is a miss-use of the actual identifier.
800 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
801 between cs0070 and cs0079.
803 * class.cs (MemberBase.DoDefine): When reporting a wrong
804 accessibility level, we use MethodCore to compare instead of
805 Method (this was a regression in some refactoring effort).
807 So now we correctly report cs0056 again.
809 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
810 testing the target_type (which was known to be object_type) and
811 not the source type (which is anonymous_method).
813 Fixed reporting of error cs1660.
815 * expression.cs (UserCast.Source): Expose the underlying cast.
817 * statement.cs (Switch.SwitchGoverningType): Sort the list of
818 allowed types to find a match to int32 first (most common).
820 In addition, it ignores any ImplicitUserConversions that did an
821 internal implicit conversion (as the switch statement allows only
822 one integral conversion to exist).
824 * class.cs (PartialContainer.Create): rename `name' to
825 `member_name' for clarity. Then replace the string calls with a
826 call to MemberName.GetPartialName, as now using
827 MemberName.ToString is an error (this is due to the side effects
828 it had, that were fixed in the past).
830 This will restore the error reporting on a number of partial class
831 errors that were missusing this (and getting an exception as a
832 results, which is now just a plain textual warning, because
833 yyparse debug output would crash otherwise).
835 2004-11-26 Raja R Harinath <rharinath@novell.com>
837 * Makefile (PROGRAM_INSTALL_DIR): Remove.
839 2004-11-25 Ben Maurer <bmaurer@ximian.com>
841 * rootcontext.cs (LookupType): Make sure to cache lookups that
842 don't give us a negative result. This saves about 5% of corlib
845 2004-11-25 Miguel de Icaza <miguel@ximian.com>
847 * report.cs (AbstractMessage.Print): messages are sent to stderr
849 * class.cs (TypeContainer.GetClassBases): It is an error to have a
850 non-interface in the list of interfaces (at this point, either
851 parent was properly set, or a base class is being listed in the
854 This flags error 1722, and resolves the crash from bug 69259.
856 2004-11-25 Ben Maurer <bmaurer@ximian.com>
858 * statement.cs (Using.EmitExpressionFinally): make this work right
859 for valuetypes. Fixes 69926.
861 2004-11-25 Miguel de Icaza <miguel@ximian.com>
863 * const.cs (Const.ChangeType): Cope with the "0 literal can be
864 converted to an enum" here, before we try to change the underlying
865 type. This code exists, but it is a different code path than the
866 one used while encoding constants.
868 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
869 old bug: when converting from the null literal to a pointer,
870 return an EmptyCast, not the NullLiteral.
872 This fixes #69921, the recent null_type changes probably made this
875 (ImplicitReferenceConversionExists): In addition, resynchronized
876 the code here, so it matches the same code in
877 ImplicitReferenceConversionExists for the `from any class-type S
878 to any interface-type T'.
881 2004-11-25 Marek Safar <marek.safar@seznam.cz>
883 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
885 2004-11-24 Miguel de Icaza <miguel@ximian.com>
887 * cs-parser.jay: Use verbosity accordingly.
889 2004-11-24 Marek Safar <marek.safar@seznam.cz>
891 * expression.cs (Unary.ResolveOperator): Do not report warning;
892 AddressOf reads from variable.
894 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
896 2004-11-24 Marek Safar <marek.safar@seznam.cz>
900 * attribute.cs (Attributable): Removed CheckTargets.
901 (Attributes.Emit): Explicit attribute targets are tested here.
903 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
904 not enabled for interfaces.
906 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
907 (GetAssemblyName): Ouch next bug there.
909 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
911 * expression.cs: Error 275 added.
913 2004-11-23 Marek Safar <marek.safar@seznam.cz>
915 Fix bug #69177 (Implemented decimal constant support)
917 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
918 (BinaryFold): Add DecimalConstant.
920 * const.cs (Define): Decimal constant
922 (ChangeType): Add decimal type handling.
923 (LookupConstantValue): Don't set value for decimal type but
924 emit DecimalConstantAttribute. Needed for constant optimization.
926 * constant.cs (ToDecimal): New method.
927 (ConvertToDecimal): New method.
928 (IntConstant): Implemented ConvertToDecimal.
929 (DecimalConstant.Emit): Emit optimized version for decimals in
932 * expression.cs (ResolveOperator): Changed order of constant
933 reduction to work correctly with native types which have
934 overloaded operators.
935 (ResolveMemberAccess): Extract constant value from attribute
938 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
940 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
941 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
942 (ChangeType): Decimal is special.
943 (TypeToCoreType): Add decimal type.
945 2004-11-22 Marek Safar <marek.safar@seznam.cz>
947 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
950 2004-11-22 Marek Safar <marek.safar@seznam.cz>
952 * class.cs (EventField.ApplyAttributeBuilder): Fix error
955 2004-11-19 Marek Safar <marek.safar@seznam.cz>
957 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
959 * pending.cs (PendingImplementation): Grab only interfaces.
961 2004-11-19 Marek Safar <marek.safar@seznam.cz>
963 * statement.cs (ForeachHelperMethods): Add location member and
966 2004-11-19 Raja R Harinath <rharinath@novell.com>
968 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
969 automatically handled by executable.make.
970 (PROGRAM): Make profile-specific.
972 2004-11-18 Marek Safar <marek.safar@seznam.cz>
974 * expression.cs (DoResolveBase): Fixed wrong warning for out
977 2004-11-18 Martin Baulig <martin@ximian.com>
979 Merged latest changes into gmcs. Please keep this comment in
980 here, it makes it easier for me to see what changed in MCS since
981 the last time I merged.
983 2004-11-17 Raja R Harinath <rharinath@novell.com>
985 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
986 (TypeHandle.GetMemberCache): New.
987 (TypeHandle.TypeHandle): Update.
988 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
989 (TypeManager.LookupParentInterfacesCache):
990 Rename from LookupInterfaceCache. Optimize slightly.
991 (TypeManager.MemberLookup_FindMembers): Update.
992 * decl.cs (MemberCache.MemberCache): Set Container to null in the
994 (AddCacheContents): Rename from AddHashtable.
995 * class.cs (TypeContainer.parent_container): Remove.
996 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
997 (TypeContainer.DoDefineMembers): Don't initialize it.
998 Update to name changes.
1000 2004-11-17 Miguel de Icaza <miguel@ximian.com>
1002 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
1003 that factors the code to check access modifiers on override.
1005 (PropertyBase): Use the code here.
1007 Patch from Lluis S'anchez, fixes bug #69361.
1009 2004-11-15 Miguel de Icaza <miguel@ximian.com>
1011 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
1012 routine that is used to report the use of a captured variable
1013 whose address has been taken.
1015 There are two checks: one when variables are being captured and
1016 the other check is when the address of a variable is taken.
1018 (because an anonymous methods might be resolved before *or* after
1019 the address has been taken) and
1021 * expression.cs (Conditional.DoResolve): Remove the special
1022 casing that Martin added to trueExpr and falseExpr being both
1023 NullLiteral. We get the right behavior now just by introducing
1024 the null_type into the compiler.
1026 * convert.cs (ExplicitConversion): Change the code to use
1027 null_type instead of testing `expr is NullLiteral'.
1028 (ImplicitConversionStandard): use null_type too.
1029 (ImplicitReferenceConversionExists): use null_type too.
1030 (ImplicitReferenceConversion): use null_type too.
1032 * literal.cs: The type of `NullLiteral' is now null_type instead
1034 (Resolve): Set the type here.
1036 * typemanager.cs: Introduce null_type.
1038 2004-11-17 Martin Baulig <martin@ximian.com>
1040 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
1041 direction, like FindMembers() does. Fixes #69546, testcase is in
1044 2004-11-16 Martin Baulig <martin@ximian.com>
1046 This is based on a patch from Marek Safar, see bug #69082.
1047 Fixes bugs #63705 and #67130.
1049 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
1050 method; create a MemberCache for an interface type and cache the
1053 * decl.cs (IMemberContainer.ParentContainer): Removed.
1054 (IMemberContainer.ParentCache): New property.
1055 (MemberCache.SetupCacheForInterface): Removed.
1056 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
1057 to create a cache for an interface's "parent".
1059 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
1062 2004-11-16 Martin Baulig <martin@ximian.com>
1064 Merged back from gmcs; these changes already went into gmcs a
1065 couple of weeks ago.
1068 (TypeManager.AddUserType): Removed the `ifaces' argument.
1069 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
1071 (TypeManager.AddUserInterface): Removed.
1072 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
1074 (TypeManager.GetInterfaces): Likewise.
1075 (TypeManager.GetExplicitInterfaces): Likewise.
1077 * ecore.cs (TypeExpr.GetInterfaces): Removed.
1079 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
1080 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
1082 2004-11-14 Ben Maurer <bmaurer@ximian.com>
1084 * statement.cs: Avoid adding bools to a hashtable.
1086 2004-11-07 Miguel de Icaza <miguel@ximian.com>
1088 * expression.cs (Invocation.OverloadResolve): Flag error if we are
1089 calling an unsafe method from a safe location.
1091 2004-11-06 Marek Safar <marek.safar@seznam.cz>
1094 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
1096 2004-11-06 Miguel de Icaza <miguel@ximian.com>
1098 * namespace.cs (VerifyUsing): use GetPartialName instead of
1101 2004-11-05 Miguel de Icaza <miguel@ximian.com>
1103 * statement.cs (Return.Resolve): Fix regression in typo: if
1104 `in_exc', we have to request a NeedReturnLabel, this was a typo
1105 introduced in the anonymous method check-in. Fixes #69131.
1107 * Indexers were using the ShortName when defining themselves,
1108 causing a regression in the compiler bootstrap when applying the
1109 patch from 2004-11-02 (first part), now they use their full name
1110 and the bug is gone.
1112 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
1114 * driver.cs: Strip the path from the names of embedded resources. Fixes
1117 2004-11-04 Raja R Harinath <rharinath@novell.com>
1119 Fix error message regression: cs0104-2.cs.
1120 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
1121 (AliasEntry.Resolve): Update.
1122 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
1124 (RootContext.LookupType): Update.
1126 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
1128 * cs-parser.jay: Add support for handling accessor modifiers
1129 * class: Add support port accessor modifiers and error checking,
1130 define PropertyMethod.Define as virtual (not abstract anymore)
1131 * ecore.cs: Add checking for proeprties access with access modifiers
1132 * iterators.cs: Modify Accessor constructor call based in the modified
1134 2004-11-02 Ben Maurer <bmaurer@ximian.com>
1136 * expression.cs (StringConcat): Handle being called twice,
1137 as when we have a concat in a field init with more than two
1140 2004-11-02 Miguel de Icaza <miguel@ximian.com>
1142 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
1143 special case explicit implementations, we should always produce
1144 the .property or .event declaration.
1146 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
1147 since it will not return correct data if people use this
1148 unresolved in the presence of using statements (see test-313).
1150 * class.cs (MethodData.Define): If we are an explicit interface
1151 implementation, set the method name to the full name of the
1152 interface plus the name of the method.
1154 Notice that using the method.MethodName.GetFullName() does not
1155 work, as it will only contain the name as declared on the source
1156 file (it can be a shorthand in the presence of using statements)
1157 and not the fully qualifed type name, for example:
1161 class D : ICloneable {
1162 object ICloneable.Clone () {
1166 Would produce a method called `ICloneable.Clone' instead of
1167 `System.ICloneable.Clone'.
1169 * namespace.cs (Alias.Resolve): Use GetPartialName.
1171 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1173 * cs-parser.jay: Add error 1055 report.
1175 2004-11-01 Miguel de Icaza <miguel@ximian.com>
1177 * assign.cs (Assign.DoResolve): Only do the transform of
1178 assignment into a New if the types are compatible, if not, fall
1179 through and let the implicit code deal with the errors and with
1180 the necessary conversions.
1182 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1184 * cs-parser.jay: Add error 1031 report.
1186 * cs-tokenizer.cs: Add location for error 1038.
1188 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1190 * cs-parser.jay: Add error 1016 report.
1192 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1194 * cs-parser.jay: Add errors 1575,1611 report.
1196 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1198 * cs-parser.jay: Add error 1001 report.
1200 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1203 * attribute.cs (GetMarshal): Add method argument for
1204 caller identification.
1206 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
1207 agument for GetMarshal and RuntimeMissingSupport.
1209 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1211 * attribute.cs (ExtractSecurityPermissionSet): Removed
1212 TypeManager.code_access_permission_type.
1214 * typemanager.cs: Removed TypeManager.code_access_permission_type.
1216 2004-10-27 Miguel de Icaza <miguel@ximian.com>
1218 * expression.cs (LocalVariableReference.DoResolveLValue): Check
1219 for obsolete use of a variable here. Fixes regression on errors
1220 cs0619-25 and cs0619-26.
1222 2004-10-27 Marek Safar <marek.safar@seznam.cz>
1224 Fix #62358, implemented security attribute encoding.
1226 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
1227 Tests permitted SecurityAction for assembly or other types.
1228 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
1229 data from SecurityPermissionAttribute to PermisionSet class.
1231 * class.cs (ApplyAttributeBuilder): Added special handling
1232 for System.Security.Permissions.SecurityAttribute based types.
1234 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
1235 special handling for System.Security.Permissions.SecurityAttribute
1238 * enum.cs (ApplyAttributeBuilder): Added special handling
1239 for System.Security.Permissions.SecurityAttribute based types.
1241 * parameter.cs (ApplyAttributeBuilder): Added special handling
1242 for System.Security.Permissions.SecurityAttribute based types.
1244 * rootcontext.cs: Next 2 core types.
1246 * typemanager.cs (TypeManager.security_permission_attr_type):
1247 Built in type for the SecurityPermission Attribute.
1248 (code_access_permission_type): Build in type.
1250 2004-10-17 Miguel de Icaza <miguel@ximian.com>
1252 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
1253 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
1254 all of this information into
1255 EmitContext.EmitCapturedVariableInstance.
1257 * codegen.cs (EmitCapturedVariableInstance): move here the
1258 funcionality of emitting an ldarg.0 in the presence of a
1259 remapping. This centralizes the instance emit code.
1261 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
1262 then emit a load of this: it means that we have reached the
1263 topmost ScopeInfo: the one that contains the pointer to the
1264 instance of the class hosting the anonymous method.
1266 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
1267 captures to the topmost CaptureContext.
1269 2004-10-12 Miguel de Icaza <miguel@ximian.com>
1271 * expression.cs (LocalVariableReference): Move the knowledge about
1272 the iterators into codegen's EmitCapturedVariableInstance.
1274 2004-10-11 Miguel de Icaza <miguel@ximian.com>
1276 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
1277 all code paths return a value from an anonymous method (it is the
1278 same as the 161 error, but for anonymous methods).
1280 2004-10-08 Miguel de Icaza <miguel@ximian.com>
1282 The introduction of anonymous methods in the compiler changed
1283 various ways of doing things in the compiler. The most
1284 significant one is the hard split between the resolution phase
1285 and the emission phases of the compiler.
1287 For instance, routines that referenced local variables no
1288 longer can safely create temporary variables during the
1289 resolution phase: they must do so from the emission phase,
1290 since the variable might have been "captured", hence access to
1291 it can not be done with the local-variable operations from the runtime.
1295 (Block.Flags): New flag `IsTopLevel' to indicate that this block
1296 is a toplevel block.
1298 (ToplevelBlock): A new kind of Block, these are the blocks that
1299 are created by the parser for all toplevel method bodies. These
1300 include methods, accessors and anonymous methods.
1302 These contain some extra information not found in regular blocks:
1303 A pointer to an optional CaptureContext (for tracking captured
1304 local variables and parameters). A pointer to the parent
1307 (Return.Resolve): Catch missmatches when returning a value from an
1308 anonymous method (error 1662).
1309 Invoke NeedReturnLabel from the Resolve phase instead of the emit
1312 (Break.Resolve): ditto.
1314 (SwitchLabel): instead of defining the labels during the
1315 resolution phase, we now turned the public ILLabel and ILLabelCode
1316 labels into methods called GetILLabelCode() and GetILLabel() that
1317 only define the label during the Emit phase.
1319 (GotoCase): Track the SwitchLabel instead of the computed label
1320 (its contained therein). Emit the code by using
1321 SwitchLabel.GetILLabelCode ().
1323 (LocalInfo.Flags.Captured): A new flag has been introduce to track
1324 whether the Local has been captured or not.
1326 (LocalInfo.IsCaptured): New property, used to tell whether the
1327 local has been captured.
1329 * anonymous.cs: Vastly updated to contain the anonymous method
1332 The main classes here are: CaptureContext which tracks any
1333 captured information for a toplevel block and ScopeInfo used to
1334 track the activation frames for various local variables.
1336 Each toplevel block has an optional capture context associated
1337 with it. When a method contains an anonymous method both the
1338 toplevel method and the anonymous method will create a capture
1339 context. When variables or parameters are captured, they are
1340 recorded on the CaptureContext that owns them, for example:
1344 MyDelegate d = delegate {
1349 Here `a' will be recorded as captured on the toplevel
1350 CapturedContext, the inner captured context will not have anything
1351 (it will only have data if local variables or parameters from it
1352 are captured in a nested anonymous method.
1354 The ScopeInfo is used to track the activation frames for local
1355 variables, for example:
1357 for (int i = 0; i < 10; i++)
1358 for (int j = 0; j < 10; j++){
1359 MyDelegate d = delegate {
1364 At runtime this captures a single captured variable `i', but it
1365 captures 10 different versions of the variable `j'. The variable
1366 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
1367 recorded on a child.
1369 The toplevel ScopeInfo will also track information like the `this'
1370 pointer if instance variables were referenced (this is necessary
1371 as the anonymous method lives inside a nested class in the host
1372 type of the method).
1374 (AnonymousMethod): Expanded to track the Toplevel, implement
1375 `AnonymousMethod.Compatible' to tell whether an anonymous method
1376 can be converted to a target delegate type.
1378 The routine now also produces the anonymous method content
1380 (AnonymousDelegate): A helper class that derives from
1381 DelegateCreation, this is used to generate the code necessary to
1382 produce the delegate for the anonymous method that was created.
1384 * assign.cs: API adjustments for new changes in
1385 Convert.ImplicitStandardConversionExists.
1387 * class.cs: Adjustments to cope with the fact that now toplevel
1388 blocks are of type `ToplevelBlock'.
1390 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
1391 insteda of standard blocks.
1393 Flag errors if params arguments are passed to anonymous methods.
1395 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
1396 `CurrentAnonymousMethod' which points to the current Anonymous
1397 Method. The variable points to the AnonymousMethod class that
1398 holds the code being compiled. It is set in the new EmitContext
1399 created for the anonymous method.
1401 (EmitContext.Phase): Introduce a variable and an enumeration to
1402 assist in enforcing some rules about when and where we are allowed
1403 to invoke certain methods (EmitContext.NeedsReturnLabel is the
1404 only one that enfonces this right now).
1406 (EmitContext.HaveCaptureInfo): new helper method that returns
1407 whether we have a CapturedContext initialized.
1409 (EmitContext.CaptureVariable): New method used to register that a
1410 LocalInfo must be flagged for capturing.
1412 (EmitContext.CapturedParameter): New method used to register that a
1413 parameters must be flagged for capturing.
1415 (EmitContext.CapturedField): New method used to register that a
1416 field must be flagged for capturing.
1418 (EmitContext.HaveCapturedVariables,
1419 EmitContext.HaveCapturedFields): Return whether there are captured
1420 variables or fields.
1422 (EmitContext.EmitMethodHostInstance): This is used to emit the
1423 instance for the anonymous method. The instance might be null
1424 (static methods), this (for anonymous methods that capture nothing
1425 and happen to live side-by-side with the current method body) or a
1426 more complicated expression if the method has a CaptureContext.
1428 (EmitContext.EmitTopBlock): Routine that drives the emission of
1429 code: it will first resolve the top block, then emit any metadata
1430 and then emit the code. The split is done so that we can extract
1431 any anonymous methods and flag any captured variables/parameters.
1433 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
1434 during this phase, the ILGenerator should not be used as labels
1435 and local variables declared here might not be accessible to any
1436 code that is part of an anonymous method.
1438 Exceptions to this include the temporary variables that are
1439 created by some statements internally for holding temporary
1442 (EmitContext.EmitMeta): New routine, in charge of emitting all the
1445 (EmitContext.TemporaryReturn): This method is typically called
1446 from the Emit phase, and its the only place where we allow the
1447 ReturnLabel to be defined other than the EmitMeta. The reason is
1448 that otherwise we would have to duplicate a lot of logic in the
1449 Resolve phases of various methods that today is on the Emit
1452 (EmitContext.NeedReturnLabel): This no longer creates the label,
1453 as the ILGenerator is not valid during the resolve phase.
1455 (EmitContext.EmitThis): Extended the knowledge in this class to
1456 work in anonymous methods in addition to iterators.
1458 (EmitContext.EmitCapturedVariableInstance): This emits whatever
1459 code is necessary on the stack to access the instance to a local
1460 variable (the variable will be accessed as a field).
1462 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
1463 EmitContext.EmitAddressOfParameter): Routines to support
1464 parameters (not completed at this point).
1466 Removals: Removed RemapLocal and RemapLocalLValue. We probably
1467 will also remove the parameters.
1469 * convert.cs (Convert): Define a `ConstantEC' which points to a
1470 null. This is just to prefity some code that uses
1471 ImplicitStandardConversion code and do not have an EmitContext
1474 The idea is to flag explicitly that at that point in time, it is
1475 known that the conversion will not trigger the delegate checking
1476 code in implicit conversions (which requires a valid
1479 Everywhere: pass new EmitContext parameter since
1480 ImplicitStandardConversionExists now requires it to check for
1481 anonymous method conversions.
1483 (Convert.ImplicitStandardConversionExists): If the type of an
1484 expression is the anonymous_method_type, and the type is a
1485 delegate, we invoke the AnonymousMethod.Compatible method to check
1486 whether an implicit conversion is possible.
1488 (Convert.ImplicitConversionStandard): Only do implicit method
1489 group conversions if the language level is not ISO_1.
1491 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
1492 MethodInfo for the Invoke method. used by Delegate and
1495 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
1496 method conversions if the target type is a delegate.
1498 Removed extra debugging nops.
1500 (LocalVariableReference): Turn the `local_info' into a public
1503 Add `prepared' field, the same hack used for FieldExprs to cope
1504 with composed assignments, as Local variables do not necessarily
1505 operate purely on the stack as they used to: they can be captured
1508 Add `temp' for a temporary result, like fields.
1510 Refactor DoResolve and DoResolveLValue into DoResolveBase.
1512 It now copes with Local variables that are captured and emits the
1513 proper instance variable to load it from a field in the captured
1516 (ParameterReference.DoResolveBase): During the resolve phase,
1517 capture parameters if we are in an anonymous method.
1519 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
1520 anonymous method, use the EmitContext helper routines to emit the
1521 parameter reference.
1523 * iterators.cs: Set RemapToProxy to true/false during the
1526 * parameters.cs (GetParameterByName): New helper method.
1528 * typemanager.cs (anonymous_method_type) a new type that
1529 represents an anonyous method. This is always an internal type,
1530 used as a fencepost to test against the anonymous-methodness of an
1533 2004-10-20 Marek Safar <marek.safar@seznam.cz>
1535 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
1537 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
1539 2004-10-18 Martin Baulig <martin@ximian.com>
1541 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
1542 `Type' directly, but call ResolveType() on it.
1543 (Catch.Resolve): Likewise.
1544 (Foreach.Resolve): Likewise.
1546 2004-10-18 Martin Baulig <martin@ximian.com>
1548 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
1549 `Type' directly, but call ResolveType() on it.
1550 (Probe.DoResolve): Likewise.
1551 (ArrayCreation.LookupType): Likewise.
1552 (TypeOf.DoResolve): Likewise.
1553 (SizeOf.DoResolve): Likewise.
1555 2004-10-18 Martin Baulig <martin@ximian.com>
1557 * expression.cs (Invocation.BetterFunction): Put back
1558 TypeManager.TypeToCoreType().
1560 2004-10-18 Raja R Harinath <rharinath@novell.com>
1562 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
1565 2004-10-18 Martin Baulig <martin@ximian.com>
1567 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
1568 `Type' directly, but call ResolveType() on it.
1570 2004-10-18 Martin Baulig <martin@ximian.com>
1572 * class.cs (FieldMember.Define): Don't access the TypeExpr's
1573 `Type' directly, but call ResolveType() on it.
1574 (MemberBase.DoDefine): Likewise.
1576 * expression.cs (New.DoResolve): Don't access the TypeExpr's
1577 `Type' directly, but call ResolveType() on it.
1578 (ComposedCast.DoResolveAsTypeStep): Likewise.
1580 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
1581 `Type' directly, but call ResolveType() on it.
1583 2004-10-17 John Luke <john.luke@gmail.com>
1585 * class.cs (Operator.GetSignatureForError): use CSharpName
1587 * parameter.cs (Parameter.GetSignatureForError): Returns
1588 correct name even if was not defined.
1590 2004-10-13 Raja R Harinath <rharinath@novell.com>
1593 * class.cs (TypeContainer.EmitContext): New property.
1594 (DefineNestedTypes): Create an emitcontext for each part.
1595 (MethodCore.DoDefineParameters): Use container's emitcontext.
1596 Pass type array to InternalParameters.
1597 (MemberBase.DoDefine): Use container's emitcontext.
1598 (FieldMember.Define): Likewise.
1599 (Event.Define): Likewise.
1600 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1601 Pass type array to InternalParameters.
1602 (SetIndexerMethod.GetParameterInfo): Likewise.
1603 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1604 * delegate.cs (Define): Pass emitcontext to
1605 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1606 array to InternalParameters.
1607 * expression.cs (ParameterReference.DoResolveBase): Pass
1608 emitcontext to GetParameterInfo.
1609 (ComposedCast.DoResolveAsTypeStep): Remove check on
1610 ec.ResolvingTypeTree.
1611 * parameter.cs (Parameter.Resolve): Change argument to
1612 EmitContext. Use ResolveAsTypeTerminal.
1613 (Parameter.GetSignature): Change argument to EmitContext.
1614 (Parameters.ComputeSignature): Likewise.
1615 (Parameters.ComputeParameterTypes): Likewise.
1616 (Parameters.GetParameterInfo): Likewise.
1617 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1618 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1619 * support.cs (InternalParameters..ctor): Remove variant that takes
1621 * typemanager.cs (system_intptr_expr): New.
1622 (InitExpressionTypes): Initialize it.
1624 2004-10-12 Chris Toshok <toshok@ximian.com>
1626 * cs-parser.jay: fix location for try_statement and catch_clause.
1628 2004-10-11 Martin Baulig <martin@ximian.com>
1630 * report.cs: Don't make --fatal abort on warnings, we have
1631 -warnaserror for that.
1633 2004-10-07 Raja R Harinath <rharinath@novell.com>
1635 More DeclSpace.ResolveType avoidance.
1636 * decl.cs (MemberCore.InUnsafe): New property.
1637 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1638 with newly created EmitContext.
1639 (FieldMember.Define): Likewise.
1640 * delegate.cs (Delegate.Define): Likewise.
1641 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1642 only if normal name-lookup fails.
1643 (TypeExpr.DoResolve): Enable error-checking.
1644 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
1645 (SizeOf.DoResolve): Likewise.
1646 (ComposedCast.DoResolveAsTypeStep): Likewise.
1647 (StackAlloc.DoResolve): Likewise.
1648 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
1649 (Block.Unsafe): New property.
1650 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
1651 (Unsafe): Set 'unsafe' flag of contained block.
1652 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
1653 (Fixed.Resolve): Likewise.
1654 (Catch.Resolve): Likewise.
1655 (Using.ResolveLocalVariableDecls): Likewise.
1656 (Foreach.Resolve): Likewise.
1658 2004-10-05 John Luke <john.luke@gmail.com>
1660 * cs-parser.jay: add location to error CS0175
1662 2004-10-04 Miguel de Icaza <miguel@ximian.com>
1664 * ecore.cs (Expression.Constantity): Add support for turning null
1667 * const.cs (Const.Define): Allow constants to be reference types
1668 as long as the value is Null.
1670 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
1672 * namespace.cs (NamespaceEntry.Using): No matter which warning
1673 level is set, check if this namespace name has already been added.
1675 2004-10-03 Ben Maurer <bmaurer@ximian.com>
1677 * expression.cs: reftype [!=]= null should always use br[true,false].
1680 2004-10-03 Marek Safar <marek.safar@seznam.cz>
1683 * attribute.cs: Enum conversion moved to
1684 GetAttributeArgumentExpression to be applied to the all
1687 2004-10-01 Raja R Harinath <rharinath@novell.com>
1689 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
1690 * class.c (TypeContainer.DefineType): Flag error if
1691 base types aren't accessible due to access permissions.
1692 * decl.cs (DeclSpace.ResolveType): Move logic to
1693 Expression.ResolveAsTypeTerminal.
1694 (DeclSpace.ResolveTypeExpr): Thin layer over
1695 Expression.ResolveAsTypeTerminal.
1696 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
1697 Refactor code into NestedAccess. Use it.
1698 (DeclSpace.NestedAccess): New.
1699 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
1700 argument to silence errors. Check access permissions.
1701 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
1702 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
1703 (Cast.DoResolve): Likewise.
1704 (New.DoResolve): Likewise.
1705 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
1706 (TypeOf.DoResolve): Likewise.
1708 * expression.cs (Invocation.BetterConversion): Return the Type of
1709 the better conversion. Implement section 14.4.2.3 more faithfully.
1710 (Invocation.BetterFunction): Make boolean. Make correspondence to
1711 section 14.4.2.2 explicit.
1712 (Invocation.OverloadResolve): Update.
1713 (Invocation): Remove is_base field.
1714 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
1715 (Invocation.Emit): Likewise.
1717 2004-09-27 Raja R Harinath <rharinath@novell.com>
1719 * README: Update to changes.
1721 2004-09-24 Marek Safar <marek.safar@seznam.cz>
1723 * cs-parser.jay: Reverted 642 warning fix.
1725 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1728 * decl.cs (FindMemberWithSameName): Indexer can have more than
1731 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1733 * expression.cs (LocalVariableReference.DoResolveLValue):
1734 Do not report warning 219 for out values.
1735 (EmptyExpression.Null): New member to avoid extra allocations.
1737 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1739 * cs-parser.jay: Fix wrong warning 642 report.
1741 * cs-tokenizer.cs (CheckNextToken): New helper;
1742 Inspect next character if is same as expected.
1744 2004-09-23 Martin Baulig <martin@ximian.com>
1746 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1747 (Convert.ImplicitReferenceConversionExists): Likewise.
1749 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1751 * class.cs (Operator.Define): Add error 448 and 559 report.
1753 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1755 * class.cs (MemberBase.IsTypePermitted): New protected
1756 method for checking error CS0610.
1758 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1760 * class.cs (TypeContainer.HasExplicitLayout): New property
1761 Returns whether container has StructLayout attribute set Explicit.
1762 (FieldMember): New abstract class for consts and fields.
1763 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1764 (Field): Reuse FieldMember.
1766 * const.cs (Const): Reuse FieldMember.
1768 * rootcontext.cs: EmitConstants call moved to class.
1770 2004-09-22 Martin Baulig <martin@ximian.com>
1772 Thanks to Peter Sestoft for this bug report.
1774 * expression.cs (Conditional): If both the `trueExpr' and the
1775 `falseExpr' is a NullLiteral, return a NullLiteral.
1777 2004-09-22 Martin Baulig <martin@ximian.com>
1779 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1780 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1781 for the "get_Current" call.
1783 2004-09-22 Martin Baulig <martin@ximian.com>
1785 Marek and me just fixed one of our oldest bugs: #28562 :-)
1787 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1789 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1790 we're an EnumConstant, just return that.
1791 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1792 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1793 to get the value which'll actually be written into the attribute.
1794 However, we have to use GetValue() to access the attribute's value
1797 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1799 * constant.cs (Constant.IsNegative): New abstract property
1802 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1803 (StackAlloc.DoResolve): Reused IsNegative.
1805 2004-09-21 Martin Baulig <martin@ximian.com>
1807 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
1808 if we're used in an iterator, we may be called from different
1811 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
1812 we actually have an exception block.
1814 2004-09-20 John Luke <jluke@cfl.rr.com>
1816 * class.cs, cs-parser.jay: Improve the error report for 1520:
1817 report the actual line where the error happens, not where the
1820 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
1821 Pass location information that was available elsewhere.
1823 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
1825 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
1826 runtime to delay sign assemblies.
1828 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1830 * cs-parser.jay: Do not report the stack trace, this is barely
1833 2004-08-22 John Luke <john.luke@gmail.com>
1835 * driver.cs : check that a resource id is not already used
1836 before adding it, report CS1508 if it is, bug #63637
1838 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1840 * ecore.cs: Removed dead code.
1842 2004-09-18 Marek Safar <marek.safar@seznam.cz>
1844 * class.cs: Do not report warning CS0067 on the interfaces.
1846 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1848 * cs-parser.jay: Add error 504 report.
1850 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1852 * rootcontext.cs: WarningLevel is 4 by default now.
1854 * statement.cs (Fixed.Resolve): Do not null
1857 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1860 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
1861 deep search when property is not virtual.
1862 (PropertyExpr.ResolveAccessors): Make one call for both
1865 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1868 * statement.cs: Error 152 report constains also location.
1870 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1873 * const.cs: Explicitly set constant as static.
1875 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1878 * cs-parser.jay: Add error 1017 report.
1880 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1882 Fixed bug #59980, #64224
1883 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
1885 * typemanager.cs (IsSpecialMethod): Simplified
1887 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1889 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
1890 condition with better params.
1892 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1895 * attribute.cs (Resolve): Property has to have both
1898 2004-09-14 Martin Baulig <martin@ximian.com>
1900 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1902 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1905 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1906 called and is obsolete then this member suppress message
1907 when call is inside next [Obsolete] method or type.
1909 * expression.cs: Use TestObsoleteMethodUsage member.
1911 2004-09-14 Martin Baulig <martin@ximian.com>
1913 * cs-parser.jay: Sync a bit with the GMCS version.
1915 2004-09-14 Martin Baulig <martin@ximian.com>
1917 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
1918 (CSharpParser.yacc_verbose_flag): New public field.
1920 * genericparser.cs: Removed.
1922 2004-09-14 Raja R Harinath <rharinath@novell.com>
1924 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
1926 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1928 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1930 2004-09-10 Martin Baulig <martin@ximian.com>
1932 Backported my MemberName changes from GMCS into MCS.
1934 - we are now using a special `MemberName' class instead of using
1935 strings; in GMCS, the `MemberName' also contains the type
1938 - changed the grammar rules a bit:
1939 * the old `member_name' is now a `namespace_or_type_name':
1940 The rule is that we use `namespace_or_type_name' everywhere
1941 where we expect either a "member name" (GetEnumerator) or a
1942 "member name" with an explicit interface name
1943 (IEnumerable.GetEnumerator).
1944 In GMCS, the explicit interface name may include type arguments
1945 (IEnumerable<T>.GetEnumerator).
1946 * we use `member_name' instead of just `IDENTIFIER' for
1948 The rule is that we use `member_name' wherever a member may
1949 have type parameters in GMCS.
1951 * decl.cs (MemberName): New public class.
1952 (MemberCore.MemberName): New public readonly field.
1953 (MemberCore.ctor): Take a `MemberName' argument, not a string.
1954 (DeclSpace): Likewise.
1956 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
1957 * enum.cs (Enum.ctor): Likewise.
1959 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
1961 (AliasEntry.ctor): Take a MemberName, not an Expression.
1962 (AliasEntry.UsingAlias): Likewise.
1964 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
1965 (IMethodData.MemberName): Changed type from string to MemberName.
1966 (MemberBase.ExplicitInterfaceName): Likewise.
1967 (AbstractPropertyEventMethod.SetupName): Make this private.
1968 (AbstractPropertyEventMethod.ctor): Added `string prefix'
1969 argument; compute the member name here.
1970 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
1971 on the `member.MemberName' and the `prefix'.
1973 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
1975 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
1976 thus, we get a `MemberName' instead of a `string'. These
1977 declarations may have type parameters in GMCS.
1978 (interface_method_declaration, delegate_declaration): Likewise.
1979 (class_declaration, interface_declaration): Likewise.
1980 (method_header): Use `namespace_or_type_name' instead of
1981 `member_name'. We may be an explicit interface implementation.
1982 (property_declaration, event_declaration): Likewise.
1983 (member_name): This is now just an `IDENTIFIER', not a
1984 `namespace_or_type_name'.
1985 (type_name, interface_type): Removed.
1986 (namespace_or_type_name): Return a MemberName, not an Expression.
1987 (primary_expression): Use `member_name' instead of `IDENTIFIER';
1988 call GetTypeExpression() on the MemberName to get an expression.
1989 (IndexerDeclaration.interface_type): Changed type from string to
1991 (MakeName): Operate on MemberName's instead of string's.
1993 2004-09-13 Raja R Harinath <rharinath@novell.com>
1996 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
1997 (NamespaceEntry.Lookup): Add new argument to flag if we want the
1998 lookup to avoid symbols introduced by 'using'.
1999 * rootcontext.cs (NamespaceLookup): Update.
2001 2004-09-12 Marek Safar <marek.safar@seznam.cz>
2003 * class.cs (TypeContainer.DoDefineMembers): Do not call
2004 DefineDefaultConstructor for static classes.
2006 2004-09-12 Marek Safar <marek.safar@seznam.cz>
2008 * attribute.cs (Attribute.Resolve): Add error 653 report.
2010 * class.cs (Class.ApplyAttributeBuilder): Add error 641
2012 (Method.ApplyAttributeBuilder): Add error 685 report.
2013 (Operator.Define): Add error 564 report.
2015 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
2017 * expression.cs (Invocation.DoResolve): Add error
2020 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
2023 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2025 * class.cs (ConstructorInitializer.Resolve):
2026 Wrong error number (515->516).
2028 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2030 * class.cs (Indexer.Define): Add error 631 report.
2032 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2034 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
2036 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2038 * expression.cs (Probe.DoResolve): Add error CS0241 report.
2040 2004-09-10 Marek Safar <marek.safar@seznam.cz>
2042 * cs-parser.jay: Added error CS0241 report.
2044 2004-09-10 Raja R Harinath <rharinath@novell.com>
2046 * cs-parser.jay (fixed_statement): Introduce a scope for the
2047 declaration in the 'fixed' statement.
2049 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2051 * cs-parser.jay: Added CS0230 error report.
2053 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2055 * cs-parser.jay: Added errors CS0231 and CS0257 report.
2057 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2059 * expression.cs (Argument.Resolve): Added error CS0192 and
2062 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2064 C# 2.0 #pragma warning feature
2066 * cs-tokenizer.cs (PreProcessPragma): New method;
2067 Handles #pragma directive.
2069 * report.cs (WarningRegions): New class; Support
2070 class for #pragma warning directive. It tests whether
2071 warning is enabled for a given line.
2073 2004-09-08 Miguel de Icaza <miguel@ximian.com>
2075 * const.cs: Add more descriptive error report, tahnks to
2078 2004-09-08 Marek Safar <marek.safar@seznam.cz>
2080 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
2082 2004-09-07 Miguel de Icaza <miguel@ximian.com>
2084 * expression.cs: Apply patch from Ben: Remove dead code from
2085 ArrayCreation, and remove the TurnintoConstant call in const.cs,
2086 as that code just threw an exception anwyays.
2088 * const.cs: Remove the call to the turnintoconstant, for details
2091 * literal.cs: The type of the null-literal is the null type; So
2092 we use a placeholder type (literal.cs:System.Null, defined here)
2095 * expression.cs (Conditional.DoResolve): Remove some old code that
2096 is no longer needed, conversions have been fixed.
2098 (ArrayCreationExpression.DoResolve): Return false if we fail to
2099 resolve the inner expression.
2101 2004-09-07 Raja R Harinath <rharinath@novell.com>
2104 * cs-parser.jay (delegate_declaration): Record a delegate
2105 declaration as a type declaration.
2106 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
2108 2004-09-06 Miguel de Icaza <miguel@ximian.com>
2110 * parameter.cs: Do not crash if the type can not be resolved.
2112 * expression.cs: Report errors with unsafe pointers, fixes #64896
2114 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
2116 * expression.cs: Pointer arith always needs to do a conv.i
2117 if the operand is a long. fix 65320
2119 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2121 Fixed cs0619-37.cs, cs0619-38.cs
2123 * enum.cs (GetObsoleteAttribute): Removed.
2125 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
2126 on Enum member is double staged. The first is tested member
2129 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2131 Fixed #56986, #63631, #65231
2133 * class.cs: (TypeContainer.AddToMemberContainer): New method,
2134 adds member to name container.
2135 (TypeContainer.AddToTypeContainer): New method, adds type to
2137 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
2138 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
2139 AddOperator): Simplified by reusing AddToMemberContainer.
2140 (TypeContainer.UserDefinedStaticConstructor): Changed to property
2142 (Method.CheckForDuplications): Fixed implementation to test all
2144 (MemberBase): Detection whether member is explicit interface
2145 implementation is now in constructor.
2146 (MemberBase.UpdateMemberName): Handles IndexerName.
2147 (Accessor): Changed to keep also location information.
2148 (AbstractPropertyEventMethod): Is derived from MemberCore.
2149 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
2150 will be emited or not.
2151 (PropertyBase.AreAccessorsDuplicateImplementation):
2152 Tests whether accessors are not in collision with some method.
2153 (Operator): Is derived from MethodCore to simplify common
2156 * decl.cs (Flags.TestMethodDuplication): Test for duplication
2158 (DeclSpace.AddToContainer): Adds the member to defined_names
2159 table. It tests for duplications and enclosing name conflicts.
2161 * enum.cs (EnumMember): Clean up to reuse the base structures
2163 2004-09-03 Martin Baulig <martin@ximian.com>
2165 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2166 into TypeContainer, to make partial classes work again.
2168 2004-09-03 Martin Baulig <martin@ximian.com>
2170 * rootcontext.cs (RootContext.V2): Removed.
2172 2004-03-23 Martin Baulig <martin@ximian.com>
2174 * expression.cs (Invocation.OverloadResolve): Added `bool
2175 may_fail' argument and use it instead of the Location.IsNull() hack.
2177 2004-09-03 Martin Baulig <martin@ximian.com>
2179 Merged latest changes into gmcs. Please keep this comment in
2180 here, it makes it easier for me to see what changed in MCS since
2181 the last time I merged.
2183 2004-09-03 Raja R Harinath <rharinath@novell.com>
2186 * expression.cs (BetterConversion): Don't allow either conversion
2187 to be null. Remove redundant implicit conversion test when 'q ==
2188 null' -- when this function is invoked, we already know that the
2189 implicit conversion exists.
2190 (BetterFunction): Assume that 'best' is non-null. Remove
2191 redundant reimplementation of IsApplicable when 'best' is null.
2192 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
2193 number of arguments.
2194 (IsAncestralType): Extract from OverloadResolve.
2195 (OverloadResolve): Make robust to the MethodGroupExpr being
2196 unsorted. Implement all the logic of Section 14.5.5.1, and
2197 support overloading of methods from multiple applicable types.
2198 Clean up logic somewhat. Don't pass null methods to BetterFunction.
2200 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
2201 (RealError, Warning): Append type of report to related symbol.
2203 2004-09-03 Marek Safar <marek.safar@seznam.cz>
2205 * enum.cs: Fixed CLS-Compliance checks for enum members.
2206 Error tests cs3008-8.cs, cs3014-8.cs
2208 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2210 Fixed bug #62342, #63102
2211 * class.cs: ImplementIndexer uses member.IsExplicitImpl
2212 like ImplementMethod.
2214 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2216 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2219 2004-09-02 Martin Baulig <martin@ximian.com>
2221 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2222 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2225 2004-09-01 Marek Safar <marek.safar@seznam.cz>
2227 C# 2.0 Static classes implemented
2229 * class.cs (TypeContainer): instance_constructors,
2230 initialized_fields, initialized_static_fields,
2231 default_constructor, base_inteface_types are protected to be
2232 accessible from StaticClass.
2233 (TypeContainer.DefineDefaultConstructor): New virtual method
2234 for custom default constructor generating
2235 (StaticClass): New class to handle "Static classes" feature.
2237 * cs-parser.jay: Handle static keyword on class like instance
2240 * driver.cs: Added "/langversion" command line switch with two
2241 options (iso-1, default).
2243 2004-08-31 Marek Safar <marek.safar@seznam.cz>
2245 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
2247 2004-08-31 Miguel de Icaza <miguel@ximian.com>
2249 * delegate.cs: Style.
2251 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
2253 * delegate.cs: Add seperate instance expr field for miguel.
2255 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2257 * PointerArithmetic (Resolve): make sure we are not doing
2258 pointer arith on void*. Also, make sure we are resolved
2259 by not setting eclass until resolve.
2261 All callers: Make sure that PointerArithmetic gets resolved.
2263 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2265 * ArrayCreation (LookupType): If the type does not resolve
2266 to an array, give an error.
2268 2004-08-27 Marek Safar <marek.safar@seznam.cz>
2270 * statement.cs (Try.Resolve): Fixed bug #64222
2272 2004-08-27 Martin Baulig <martin@ximian.com>
2275 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2278 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2280 * ecore.cs (Constantify): Get underlying type via
2281 System.Enum.GetUnderlyingType to avoid StackOverflow on the
2282 Windows in special cases.
2284 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2286 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
2287 for obtaining also private methods.
2288 (GetRemoveMethod): Used GetRemoveMethod (true)
2289 for obtaining also private methods.
2291 2004-08-24 Martin Baulig <martin@ximian.com>
2293 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
2294 MethodAttributes.HideBySig for operators.
2296 2004-08-23 Martin Baulig <martin@ximian.com>
2298 Back to the old error reporting system :-)
2300 * report.cs (Message): Removed.
2301 (Report.MessageData, ErrorData, WarningData): Removed.
2302 (Report.Error, Warning): Back to the old system.
2304 2004-08-23 Martin Baulig <martin@ximian.com>
2306 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
2308 * class.cs (TypeContainer.ParentContainer): New public virtual
2309 method; replaces the explicit interface implementation.
2310 (ClassPart.ParentContainer): Override.
2312 2004-08-23 Martin Baulig <martin@ximian.com>
2314 * statement.cs (Switch): Added support for constant switches; see
2315 #59428 or test-285.cs.
2317 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2320 * statement.cs (GetEnumeratorFilter): Removed useless
2321 logic because C# specs is strict. GetEnumerator must be
2324 2004-08-22 Martin Baulig <martin@ximian.com>
2326 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2327 a switch and may break, reset the barrier. Fixes #59867.
2329 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2331 CLS-Compliance speed up (~5% for corlib)
2333 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
2334 New method. Tests container for CLS-Compliant names
2336 * class.cs (TypeContainer.VerifyClsName): New method.
2337 Checks whether container name is CLS Compliant.
2338 (Constructor): Implements IMethodData.
2340 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
2341 low-case table for CLS Compliance test.
2342 (MemberCache.VerifyClsParameterConflict): New method.
2343 Checks method parameters for CS3006 error.
2345 * enum.cs (EnumMember): Is derived from MemberCore.
2346 (Enum.VerifyClsName): Optimized for better performance.
2348 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2350 * report.cs: Renamed Error_T to Error and changed all
2353 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2355 * class.cs (TypeContainer.IndexerArrayList): New inner class
2356 container for indexers.
2357 (TypeContainer.DefaultIndexerName): New constant for default
2358 indexer name. Replaced all "Item" with this constant.
2359 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
2361 * typemanager.cs (TypeManager.default_member_ctor): Cache here
2362 DefaultMemberAttribute constructor.
2364 2004-08-05 Martin Baulig <martin@ximian.com>
2366 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
2369 2004-08-05 Marek Safar <marek.safar@seznam.cz>
2371 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
2372 multi platforms problem.
2374 * compiler.csproj: Included shared files.
2376 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2378 Fix bug 60333, 55971 in the more general way
2379 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2380 Added arg_type argument for constant conversion.
2381 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
2383 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2386 * class.cs (TypeContainer ): New inner classes MethodArrayList,
2387 OperatorArrayList, MethodCoreArrayList for typecontainer
2388 containers. Changed class member types to these new types.
2389 (MethodArrayList.DefineMembers): Added test for CS0659.
2391 2004-08-04 Miguel de Icaza <miguel@ximian.com>
2393 * cfold.cs: Synchronize the folding with the code in expression.cs
2394 Binary.DoNumericPromotions for uint operands.
2396 * attribute.cs: Revert patch from Raja, it introduced a regression
2397 while building Blam-1.2.1 (hard to isolate a test case).
2399 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2403 (TypeContainer.Define): Renamed to DefineContainerMembers because of
2405 (MethodCore.parent_method): New member. The method we're overriding
2406 if this is an override method.
2407 (MethodCore.CheckBase): Moved from Method class and made common.
2408 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
2410 (MethodCore.CheckForDuplications): New abstract method. For custom
2411 member duplication search in a container
2412 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
2413 method and its return type.
2414 (Event.conflict_symbol): New member. Symbol with same name in the
2418 (MemberCache.FindMemberWithSameName): New method. The method
2419 is looking for conflict with inherited symbols.
2421 2004-08-04 Martin Baulig <martin@ximian.com>
2423 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
2425 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
2427 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2429 * report.cs (Message): New enum for better error, warning reference in
2431 (MessageData): New inner abstract class. It generally handles printing of
2432 error and warning messages.
2433 Removed unused Error, Warning, Message methods.
2435 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2437 Fix for cs0592-8.cs test
2439 (Attributable.ValidAttributeTargets): Made public.
2440 (Attribute.ExplicitTarget): New member for explicit target value.
2441 (Attribute.CheckTargets): Now we translate explicit attribute
2442 target to Target here.
2444 2004-08-03 Ben Maurer <bmaurer@ximian.com>
2446 * ecore.cs (MethodGroupExpr): new IsBase property.
2448 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
2450 * delegate.cs (DelegateCreation): store a MethodGroupExpr
2451 rather than an instance expr.
2453 (DelegateCreation.Emit): Use the method group rather than
2454 the instance expression. Also, if you have base.Foo as the
2455 method for a delegate, make sure to emit ldftn, not ldftnvirt.
2457 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
2459 (NewDelegate.DoResolve): Only check for the existance of Invoke
2460 if the method is going to be needed. Use MethodGroupExpr.
2462 (NewDelegate.Emit): Remove, DelegateCreation implements this.
2464 * expression.cs: For pointer arith., make sure to use
2465 the size of the type, not the size of the pointer to
2468 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2471 * class.cs (Class): Added error CS0502 test.
2473 2004-08-03 John Luke <jluke@cfl.rr.com>
2474 Raja R Harinath <rharinath@novell.com>
2477 * attribute.cs (Attribute.complained_before): New flag.
2478 (Attribute.ResolveType, Attribute.Resolve),
2479 (Attribute.DefinePInvokeMethod): Set it.
2480 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
2482 2004-08-03 Martin Baulig <martin@ximian.com>
2484 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
2485 use a user-defined operator; we still need to do numeric
2486 promotions in case one argument is a builtin type and the other
2487 one has an implicit conversion to that type. Fixes #62322.
2489 2004-08-02 Martin Baulig <martin@ximian.com>
2491 * statement.cs (LocalInfo.Flags): Added `IsThis'.
2492 (LocalInfo.IsThis): New public property.
2493 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
2495 2004-08-01 Martin Baulig <martin@ximian.com>
2497 * class.cs (TypeContainer.GetClassBases): Don't set the default
2498 here since we may get called from GetPartialBases().
2499 (TypeContainer.DefineType): If GetClassBases() didn't return a
2500 parent, use the default one.
2502 2004-07-30 Duncan Mak <duncan@ximian.com>
2504 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
2506 2004-07-30 Martin Baulig <martin@ximian.com>
2508 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
2510 * class.cs (SourceMethod): New public class, derive from the
2511 symbol writer's ISourceMethod.
2512 (Method): Use the new symbol writer API.
2514 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
2515 as argument and use the new symbol writer.
2518 (SourceFile): Implement the symbol writer's ISourceFile.
2519 (Location.SymbolDocument): Removed.
2520 (Location.SourceFile): New public property.
2522 * symbolwriter.cs: Use the new symbol writer API.
2524 2004-07-30 Raja R Harinath <rharinath@novell.com>
2526 * Makefile (install-local): Remove. Functionality moved to
2529 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
2531 * Makefile: Install mcs.exe.config file together with mcs.exe.
2532 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
2533 correct runtime version.
2535 2004-07-25 Martin Baulig <martin@ximian.com>
2538 (TypeContainer.RegisterOrder): Removed, this was unused.
2539 (TypeContainer, interface_order): Removed.
2540 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
2541 TypeContainer as argument since we can also be called with a
2542 `PartialContainer' for a partial class/struct/interface.
2543 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
2544 of checking whether we're an `Interface' - we could be a
2546 (PartialContainer.Register): Override; call
2547 AddClass()/AddStruct()/AddInterface() on our parent.
2549 * cs-parser.jay (interface_member_declaration): Add things to the
2550 `current_container', not the `current_class'.
2552 * rootcontext.cs (RegisterOrder): The overloaded version which
2553 takes an `Interface' was unused, removed.
2555 * typemanager.cs (TypeManager.LookupInterface): Return a
2556 `TypeContainer', not an `Interface'.
2557 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
2558 contain a `PartialContainer' for an interface, so check it's
2559 `Kind' to figure out what it is.
2561 2004-07-25 Martin Baulig <martin@ximian.com>
2563 * class.cs (Class.DefaultTypeAttributes): New public constant.
2564 (Struct.DefaultTypeAttributes): Likewise.
2565 (Interface.DefaultTypeAttributes): Likewise.
2566 (PartialContainer.TypeAttr): Override this and add the
2567 DefaultTypeAttributes.
2569 2004-07-25 Martin Baulig <martin@ximian.com>
2571 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
2572 we can just use the `Parent' field instead.
2574 2004-07-25 Martin Baulig <martin@ximian.com>
2576 * class.cs (TypeContainer.Emit): Renamed to EmitType().
2578 2004-07-25 Martin Baulig <martin@ximian.com>
2580 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
2581 our parts before defining any methods.
2582 (TypeContainer.VerifyImplements): Make this virtual.
2583 (ClassPart.VerifyImplements): Override and call VerifyImplements()
2584 on our PartialContainer.
2586 2004-07-25 Martin Baulig <martin@ximian.com>
2588 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2590 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2591 argument, we can just use the `Parent' field instead.
2594 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2595 (MemberBase.DoDefine): Likewise.
2597 2004-07-24 Martin Baulig <martin@ximian.com>
2599 * decl.cs (MemberCore.Parent): New public field.
2600 (DeclSpace.Parent): Moved to MemberCore.
2602 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2603 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2605 (FieldBase, Field, Operator): Likewise.
2606 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2607 (EventField, Event): Likewise.
2609 2004-07-23 Martin Baulig <martin@ximian.com>
2611 * class.cs (PartialContainer): New public class.
2612 (ClassPart): New public class.
2613 (TypeContainer): Added support for partial classes.
2614 (TypeContainer.GetClassBases): Splitted some of the functionality
2615 out into GetNormalBases() and GetPartialBases().
2617 * cs-tokenizer.cs (Token.PARTIAL): New token.
2618 (Tokenizer.consume_identifier): Added some hacks to recognize
2619 `partial', but only if it's immediately followed by `class',
2620 `struct' or `interface'.
2622 * cs-parser.jay: Added support for partial clases.
2624 2004-07-23 Martin Baulig <martin@ximian.com>
2626 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2627 a `DeclSpace' and also made it readonly.
2628 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2629 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2630 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2632 * cs-parser.jay: Pass the `current_class', not the
2633 `current_container' (at the moment, this is still the same thing)
2634 to a new Method, Property, Event, Indexer or Constructor.
2636 2004-07-23 Martin Baulig <martin@ximian.com>
2638 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2639 and removed the `current_interface' one.
2640 (struct_declaration, class_declaration, interface_declaration):
2641 Set `current_class' to the newly created class/struct/interface;
2642 set their `Bases' and call Register() before parsing their body.
2644 2004-07-23 Martin Baulig <martin@ximian.com>
2646 * class.cs (Kind): New public enum.
2647 (TypeContainer): Made this class abstract.
2648 (TypeContainer.Kind): New public readonly field.
2649 (TypeContainer.CheckDef): New public method; moved here from
2651 (TypeContainer.Register): New public abstract method.
2652 (TypeContainer.GetPendingImplementations): New public abstract
2654 (TypeContainer.GetClassBases): Removed the `is_class' and
2655 `is_iface' parameters.
2656 (TypeContainer.DefineNestedTypes): Formerly known as
2658 (ClassOrStruct): Made this class abstract.
2660 * tree.cs (RootTypes): New public type.
2662 2004-07-20 Martin Baulig <martin@ximian.com>
2664 * tree.cs (Tree.RecordNamespace): Removed.
2665 (Tree.Namespaces): Removed.
2667 * rootcontext.cs (RootContext.IsNamespace): Removed.
2669 * cs-parser.jay (namespace_declaration): Just create a new
2670 NamespaceEntry here.
2672 2004-07-20 Martin Baulig <martin@ximian.com>
2674 * statement.cs (ExceptionStatement): New abstract class. This is
2675 now used as a base class for everyone who's using `finally'.
2676 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
2677 our local variables before using them.
2679 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
2680 virtual method. This is used by Yield.Resolve() to "steal" an
2681 outer block's `finally' clauses.
2682 (FlowBranchingException): The .ctor now takes an ExceptionStatement
2685 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
2686 version which takes an ExceptionStatement. This version must be
2687 used to create exception branchings.
2690 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
2691 (Iterator.EmitMoveNext): Added exception support; protect the
2692 block with a `fault' clause, properly handle 'finally' clauses.
2693 (Iterator.EmitDispose): Run all the `finally' clauses here.
2695 2004-07-20 Martin Baulig <martin@ximian.com>
2697 * iterator.cs: This is the first of a set of changes in the
2698 iterator code. Match the spec more closely: if we're an
2699 IEnumerable, then GetEnumerator() must be called. The first time
2700 GetEnumerator() is called, it returns the current instance; all
2701 subsequent invocations (if any) must create a copy.
2703 2004-07-19 Miguel de Icaza <miguel@ximian.com>
2705 * expression.cs: Resolve the constant expression before returning
2708 2004-07-19 Martin Baulig <martin@ximian.com>
2710 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
2711 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
2712 the return type of the new EmitContext.
2714 2004-07-18 Martin Baulig <martin@ximian.com>
2716 * class.cs (Property.Define): Fix iterators.
2718 * iterators.cs (Iterator.Define): Moved the
2719 `container.AddInterator (this)' call here from the .ctor; only do
2720 it if we resolved successfully.
2722 2004-07-17 Miguel de Icaza <miguel@ximian.com>
2724 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
2725 `true' for preprocessing directives that we parse. The return
2726 value indicates whether we should return to regular tokenizing or
2727 not, not whether it was parsed successfully.
2729 In the past if we were in: #if false ... #line #endif, we would
2730 resume parsing after `#line'. See bug 61604.
2732 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
2733 building: IsEnumType should return true only for enums, not for
2734 enums or System.Enum itself. This fixes #61593.
2736 Likely what happened is that corlib was wrong: mcs depended on
2737 this bug in some places. The bug got fixed, we had to add the
2738 hack, which caused bug 61593.
2740 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
2741 that was a workaround for the older conditions.
2743 2004-07-16 Ben Maurer <bmaurer@ximian.com>
2745 * assign.cs: IAssignMethod has a new interface, as documented
2746 inline. All assignment code now uses this new api.
2748 * ecore.cs, expression.cs: All classes which implement
2749 IAssignMethod now use the new interface.
2751 * expression.cs (Invocation): add a hack to EmitCall so that
2752 IndexerAccess can be the target of a compound assignment without
2753 evaluating its arguments twice.
2755 * statement.cs: Handle changes in Invocation api.
2757 2004-07-16 Martin Baulig <martin@ximian.com>
2759 * iterators.cs: Rewrote this. We're now using one single Proxy
2760 class for both the IEnumerable and the IEnumerator interface and
2761 `Iterator' derives from Class so we can use the high-level API.
2763 * class.cs (TypeContainer.AddIterator): New method.
2764 (TypeContainer.DoDefineType): New protected virtual method, which
2765 is called from DefineType().
2766 (TypeContainer.DoDefineMembers): Call DefineType() and
2767 DefineMembers() on all our iterators.
2768 (TypeContainer.Emit): Call Emit() on all our iterators.
2769 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2771 * codegen.cs (EmitContext.CurrentIterator): New public field.
2773 2004-07-15 Martin Baulig <martin@ximian.com>
2776 (TypeManager.not_supported_exception_type): New type.
2778 2004-07-14 Martin Baulig <martin@ximian.com>
2780 * iterators.cs: Use real error numbers.
2782 2004-07-14 Martin Baulig <martin@ximian.com>
2784 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2785 requires this to be a System.Collection.IEnumerable and not a
2786 class implementing that interface.
2787 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2789 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2791 * class.cs: Fixed previous fix, it broke some error tests.
2793 2004-07-12 Martin Baulig <martin@ximian.com>
2795 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2798 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2800 * assign.cs (LocalTemporary): Add new argument: is_address,If
2801 `is_address' is true, then the value that we store is the address
2802 to the real value, and not the value itself.
2804 * ecore.cs (PropertyExpr): use the new local temporary
2805 stuff to allow us to handle X.Y += z (where X is a struct)
2807 2004-07-08 Martin Baulig <martin@ximian.com>
2809 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2810 not always return, just like we're doing in Using.Resolve().
2812 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2814 * cs-parser.jay (fixed_statement): flag this as Pinned.
2816 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2818 * typemanager.cs (TypeManager): Removed MakePinned method, this
2819 mechanism is replaced with the .NET 2.x compatible mechanism of
2820 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2822 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2823 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2824 `IsFixed' property which has a different meaning.
2826 2004-07-02 Raja R Harinath <rharinath@novell.com>
2828 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2829 visible from inside a nested class, not just the names of the
2830 immediately enclosing class.
2833 2004-06-24 Raja R Harinath <rharinath@novell.com>
2835 * expression.cs (BetterConversion): Remove buggy special-case
2836 handling of "implicit constant expression conversions". At this
2837 point, we already know that the conversion is possible -- we're
2838 only checking to see which is better.
2840 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2842 * cs-parser.jay: Added error CS0210 test.
2844 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2846 * cs-parser.jay: Added error CS0134 test.
2848 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2851 * cs-parser.jay: Added error CS0145 test.
2853 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2855 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2857 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2859 * expression.cs (StackAlloc.Resolve): The argument may not
2860 be a constant; deal with this case.
2862 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2864 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2865 GetIndexerAttributeValue.
2866 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2868 * class.cs (Indexer.Define): Added error tests for CS0415,
2871 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2873 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2876 2004-06-23 Martin Baulig <martin@ximian.com>
2878 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2879 neither return nor throw, reset the barrier as well. Fixes #60457.
2881 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2883 * class.cs : EventAttributes is now set to None by default.
2884 This fixes bug #60459.
2886 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2889 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2890 Don't throw exception but return null (it's sufficient now).
2892 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2894 * typemanager.cs (GetArgumentTypes): Faster implementation.
2896 2004-06-18 Martin Baulig <martin@ximian.com>
2898 * attribute.cs (Attribute.Resolve): Check whether we're an
2899 EmptyCast which a Constant child. Fixes #60333.
2901 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2903 * statement.cs (EmitCollectionForeach): Account for the fact that
2904 not all valuetypes are in areas which we can take the address of.
2905 For these variables, we store to a temporary variable. Also, make
2906 sure that we dont emit a `callvirt' on a valuetype method.
2908 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2910 * expression.cs (StackAlloc.DoReSolve): Added test for
2911 negative parameter (CS0247).
2913 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2916 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2918 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2921 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2924 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2926 Fix bug #58254 & cs1555.cs, cs1556.cs
2927 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2929 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2931 * cs-parser.jay: Added error CS1669 test for indexers.
2933 2004-06-11 Martin Baulig <martin@ximian.com>
2935 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2936 call this twice: for params and varargs methods.
2938 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2941 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2943 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2945 * attribute.cs (Attribute.GetValidTargets): Made public.
2948 (AbstractPropertyEventMethod): New class for better code sharing.
2949 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2951 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2953 2004-06-11 Raja R Harinath <rharinath@novell.com>
2956 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
2957 that the call to Resolve is part of a MemberAccess.
2958 (Expression.Resolve): Use it for SimpleName resolution.
2959 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
2960 Add 'intermediate' boolean argument.
2961 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
2962 error message when the SimpleName can be resolved ambiguously
2963 between an expression and a type.
2964 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
2966 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
2967 call on the left-side.
2969 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2972 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
2974 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2976 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
2978 2004-06-11 Martin Baulig <martin@ximian.com>
2980 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
2981 varargs methods if applicable.
2983 2004-06-11 Martin Baulig <martin@ximian.com>
2985 * expression.cs (Invocation.EmitCall): Don't use
2986 `method.CallingConvention == CallingConventions.VarArgs' since the
2987 method could also have `CallingConventions.HasThis'.
2989 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2991 * class.cs (Event.GetSignatureForError): Implemented.
2992 Fixed crash in error test cs3010.cs
2994 2004-06-10 Miguel de Icaza <miguel@ximian.com>
2996 * cs-tokenizer.cs: Change the way we track __arglist to be
2997 consistent with the other keywords.
2999 2004-06-09 Miguel de Icaza <miguel@ximian.com>
3001 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
3004 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
3006 * codegen.cs: Check that all referenced assemblies have a strongname
3007 before strongnaming the compiled assembly. If not report error CS1577.
3008 Fix bug #56563. Patch by Jackson Harper.
3009 * typemanager.cs: Added a method to return all referenced assemblies.
3010 Fix bug #56563. Patch by Jackson Harper.
3012 2004-06-08 Marek Safar <marek.safar@seznam.cz>
3015 (Method.ApplyAttributeBuilder): Moved and added conditional
3016 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
3019 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
3021 2004-06-08 Marek Safar <marek.safar@seznam.cz>
3024 * class.cs: (EventField.attribute_targets): Changed default target.
3026 2004-06-08 Martin Baulig <martin@ximian.com>
3028 * expression.cs (Invocation.EmitCall): Enable varargs methods.
3030 2004-06-08 Martin Baulig <martin@ximian.com>
3032 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
3034 2004-06-07 Martin Baulig <martin@ximian.com>
3036 Added support for varargs methods.
3038 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
3041 * cs-parser.jay: Added support for `__arglist'.
3043 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
3045 * expression.cs (Argument.AType): Added `ArgList'.
3046 (Invocation): Added support for varargs methods.
3047 (ArglistAccess): New public class.
3048 (Arglist): New public class.
3050 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
3052 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
3053 a method's top-level block if the method has varargs.
3055 * support.cs (ReflectionParameters, InternalParameters): Added
3056 support for varargs methods.
3058 2004-06-07 Miguel de Icaza <miguel@ximian.com>
3060 * class.cs: Provide location in indexer error report.
3062 * driver.cs: Use standard names.
3064 * namespace.cs: Catch the use of using after a namespace has been
3065 declared also on using aliases.
3067 2004-06-03 Raja R Harinath <rharinath@novell.com>
3070 * typemanager.cs (closure_private_ok, closure_invocation_type)
3071 (closure_qualifier_type, closure_invocation_assembly)
3072 (FilterWithClosure): Move to ...
3073 (Closure): New internal nested class.
3074 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
3075 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
3076 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
3077 (MemberLookup, MemberLookupFailed): Use it.
3078 * expression.cs (New.DoResolve): Treat the lookup for the
3079 constructor as being qualified by the 'new'ed type.
3080 (Indexers.GetIndexersForTypeOrInterface): Update.
3082 2004-06-03 Marek Safar <marek.safar@seznam.cz>
3085 (GetConditionalAttributeValue): New method. Returns
3086 condition of ConditionalAttribute.
3087 (SearchMulti): New method. Returns all attributes of type 't'.
3088 Use it when attribute is AllowMultiple = true.
3089 (IsConditionalMethodExcluded): New method.
3092 (Method.IsExcluded): Implemented. Returns true if method has conditional
3093 attribute and the conditions is not defined (method is excluded).
3094 (IMethodData): Extended interface for ConditionalAttribute support.
3095 (PropertyMethod.IsExcluded): Implemented.
3098 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
3101 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
3104 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
3106 * expression.cs (ArrayCreationExpression): Make this just an
3107 `expression'. It can't be a statement, so the code here was
3110 2004-06-02 Marek Safar <marek.safar@seznam.cz>
3113 * typemanager.cs (GetFullNameSignature): New method for
3116 2004-06-02 Marek Safar <marek.safar@seznam.cz>
3119 * class.cs (MemberBase.GetSignatureForError): New virtual method.
3120 Use this method when MethodBuilder is null.
3121 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
3122 Added test for error CS0626 (MONO reports error for this situation).
3123 (IMethodData.GetSignatureForError): Extended interface.
3125 2004-06-01 Marek Safar <marek.safar@seznam.cz>
3128 (AttributeTester.GetObsoleteAttribute): Returns instance of
3129 ObsoleteAttribute when type is obsolete.
3132 (TypeContainer.VerifyObsoleteAttribute): Override.
3133 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
3134 (MethodCode.VerifyObsoleteAttribute): Override.
3135 (MemberBase.VerifyObsoleteAttribute): Override.
3138 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
3139 and report proper error.
3142 Delegate.VerifyObsoleteAttribute): Override.
3145 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
3146 and report proper error.
3147 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
3150 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
3154 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
3155 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
3156 Added test for ObsoleteAttribute.
3159 (Catch): Derived from Statement.
3161 2004-06-01 Marek Safar <marek.safar@seznam.cz>
3163 Fixed bug #59071 & cs0160.cs
3165 * statement.cs (Try.Resolve): Check here whether order of catch
3166 clauses matches their dependencies.
3168 2004-05-31 Miguel de Icaza <miguel@ximian.com>
3170 * Reverted patch to namespace.cs (Use lookuptypedirect). This
3171 caused a regression: #59343. Referencing nested classes from an
3172 assembly stopped working.
3174 2004-05-31 Martin Baulig <martin@ximian.com>
3176 MCS is now frozen for beta 2.
3178 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3180 * convert.cs: add a trivial cache for overload operator resolution.
3182 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3184 * decl.cs: If possible, use lookuptypedirect here. We can only do
3185 this if there is no `.' after the namespace. Avoids using
3186 LookupType, which does lots of slow processing.
3187 (FindNestedType) New method, does what it says :-).
3188 * namespace.cs: use LookupTypeDirect.
3189 * rootcontext.cs: use membercache, if possible.
3190 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3192 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3195 According to the spec,
3197 In a member access of the form E.I, if E is a single identifier,
3198 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3199 field, property, localvariable, or parameter with the same type as
3200 the meaning of E as a type-name (§3.8), then both possible
3201 meanings of E are permitted.
3203 We did not check that E as a simple-name had the same type as E as
3206 This trivial check gives us 5-7% on bootstrap time.
3208 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3210 * expression.cs (Invocation.OverloadResolve): Avoid the
3211 use of hashtables and boxing here by allocating on demand.
3213 2004-05-30 Martin Baulig <martin@ximian.com>
3215 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3216 we're doing a silent lookup. Don't try to lookup nested types in
3217 TypeManager.object_type (thanks to Ben Maurer).
3219 2004-05-30 Martin Baulig <martin@ximian.com>
3221 Committing a patch from Ben Maurer.
3223 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3225 2004-05-29 Martin Baulig <martin@ximian.com>
3227 * class.cs (IMethodData.ShouldIgnore): New method.
3229 * typemanager.cs (TypeManager.MethodFlags): Don't take a
3230 `Location' argument, we don't need it anywhere. Use
3231 `IMethodData.ShouldIgnore ()' instead of
3232 `MethodData.GetMethodFlags ()'.
3233 (TypeManager.AddMethod): Removed.
3234 (TypeManager.AddMethod2): Renamed to AddMethod.
3236 2004-05-29 Martin Baulig <martin@ximian.com>
3238 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
3240 * convert.cs (Convert.ImplicitReferenceConversion): If we're
3241 converting from a class type S to an interface type and we already
3242 have an object on the stack, don't box it again. Fixes #52578.
3244 2004-05-29 Martin Baulig <martin@ximian.com>
3246 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3247 Added support for `params' parameters. Fixes #59267.
3249 2004-05-29 Martin Baulig <martin@ximian.com>
3251 * literal.cs (NullPointer): Provide a private .ctor which sets
3252 `type' to TypeManager.object_type. Fixes #59048.
3254 2004-05-29 Martin Baulig <martin@ximian.com>
3256 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
3257 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
3259 * ecore.cs (EventExpr.instance_expr): Make the field private.
3261 2004-05-26 Marek Safar <marek.safar@seznam.cz>
3263 Fixed bug #50080 & cs0214-2.cs
3264 * expression.cs (Cast.DoResolve): Check unsafe context here.
3266 * statement.cs (Resolve.DoResolve): Likewise.
3268 2004-05-26 Martin Baulig <martin@ximian.com>
3270 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
3272 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
3273 (RootContext.LookupType): Pass down the `silent' flag.
3275 2004-05-25 Martin Baulig <martin@ximian.com>
3278 (MethodGroupExpr.IdenticalTypeName): New public property.
3279 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
3280 expression actually refers to a type.
3282 2004-05-25 Martin Baulig <martin@ximian.com>
3284 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
3285 for #56176 and made it actually work.
3287 2004-05-25 Martin Baulig <martin@ximian.com>
3289 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
3290 (FieldExpr, PropertyExpr): Override and implement
3291 CacheTemporaries. Fixes #52279.
3293 2004-05-25 Miguel de Icaza <miguel@ximian.com>
3295 * location.cs: In the new compiler listing a file twice is a
3296 warning, not an error.
3298 2004-05-24 Martin Baulig <martin@ximian.com>
3300 * enum.cs (Enum.DefineType): For the `BaseType' to be a
3301 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
3303 2004-05-24 Martin Baulig <martin@ximian.com>
3305 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
3306 walking the `using' list. Fixes #53921.
3308 2004-05-24 Martin Baulig <martin@ximian.com>
3310 * const.cs (Const.LookupConstantValue): Added support for
3311 EmptyCast's; fixes #55251.
3313 2004-05-24 Martin Baulig <martin@ximian.com>
3315 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
3316 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
3317 which does the CS0135 check. The reason is that we first need to
3318 check whether the variable actually exists.
3320 2004-05-24 Martin Baulig <martin@ximian.com>
3322 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
3323 than RootContext.LookupType() to find the explicit interface
3326 2004-05-24 Raja R Harinath <rharinath@novell.com>
3328 * Makefile: Simplify. Use executable.make.
3329 * mcs.exe.sources: New file. List of sources of mcs.exe.
3331 2004-05-24 Anders Carlsson <andersca@gnome.org>
3335 Use the invariant culture when doing String.Compare for CLS case
3338 2004-05-23 Martin Baulig <martin@ximian.com>
3340 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
3341 don't have any dots. Fixes #52622, added cs0246-8.cs.
3343 * namespace.cs (NamespaceEntry.Lookup): Likewise.
3345 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3347 * class.cs (MemberBase.Define): Reuse MemberType member for
3348 resolved type. Other methods can use it too.
3350 2004-05-23 Martin Baulig <martin@ximian.com>
3352 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
3353 the variable also exists in the current block (otherwise, we need
3354 to report a CS0103). Fixes #58670.
3356 2004-05-23 Martin Baulig <martin@ximian.com>
3358 * flowanalysis.cs (Reachability.Reachable): Compute this
3359 on-the-fly rather than storing it as a field.
3361 2004-05-23 Martin Baulig <martin@ximian.com>
3363 * flowanalysis.cs (Reachability.And): Manually compute the
3364 resulting `barrier' from the reachability.
3366 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3369 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
3370 instance of ObsoleteAttribute when symbol is obsolete.
3373 (IMethodData): Extended interface for ObsoleteAttribute support.
3375 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3377 * attribute.cs: Fix bug #55970
3379 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3383 (GetObsoleteAttribute): New method. Creates the instance of
3385 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
3386 ObsoleteAttribute when member is obsolete.
3387 (AttributeTester.Report_ObsoleteMessage): Common method for
3388 Obsolete error/warning reporting.
3391 (TypeContainer.base_classs_type): New member for storing parent type.
3394 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
3395 for this MemberCore.
3397 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3399 * attribute.cs, const.cs: Fix bug #58590
3401 2004-05-21 Martin Baulig <martin@ximian.com>
3403 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
3404 out parameters if the end of the method is unreachable. Fixes
3407 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3409 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
3410 Hari was right, why extra method.
3412 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3414 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
3416 2004-05-20 Martin Baulig <martin@ximian.com>
3418 Merged this back from gmcs to keep the differences to a minumum.
3420 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
3421 instead of a Declspace.
3422 (Attribute.ResolveType): Likewise.
3423 (Attributes.Search): Likewise.
3424 (Attributes.Contains): Likewise.
3425 (Attributes.GetClsCompliantAttribute): Likewise.
3427 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
3429 (MethodData.ApplyAttributes): Take an EmitContext instead of a
3432 2004-05-19 Marek Safar <marek.safar@seznam.cz>
3434 Fix bug #58688 (MCS does not report error when the same attribute
3437 * attribute.cs (Attribute.Emit): Distinction between null and default.
3439 2004-05-19 Raja R Harinath <rharinath@novell.com>
3441 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
3442 of a top-level attribute without an attribute target.
3443 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
3445 (Attribute.Conditional_GetConditionName),
3446 (Attribute.Obsolete_GetObsoleteMessage): Update.
3447 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
3448 part of ScanForIndexerName.
3449 (Attribute.CanIgnoreInvalidAttribute): New function.
3450 (Attribute.ScanForIndexerName): Move to ...
3451 (Attributes.ScanForIndexerName): ... here.
3452 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
3453 (Attributes.Search): New internal variant that can choose not to
3454 complain if types aren't resolved. The original signature now
3456 (Attributes.GetClsCompliantAttribute): Use internal variant, with
3457 complaints suppressed.
3458 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
3459 only if it not useful.
3460 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
3461 top-level for attributes that are shared between the assembly
3462 and a top-level class.
3463 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
3464 * class.cs: Update to reflect changes.
3465 (DefineIndexers): Fuse loops.
3466 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
3467 a couple more variants of attribute names.
3469 2004-05-18 Marek Safar <marek.safar@seznam.cz>
3471 Fix bug #52585 (Implemented explicit attribute declaration)
3474 (Attributable.ValidAttributeTargets): New abstract method. It gets
3475 list of valid attribute targets for explicit target declaration.
3476 (Attribute.Target): It holds target itself.
3477 (AttributeSection): Removed.
3478 (Attribute.CheckTargets): New method. It checks whether attribute
3479 target is valid for the current element.
3482 (EventProperty): New class. For events that are declared like
3483 property (with add and remove accessors).
3484 (EventField): New class. For events that are declared like field.
3487 * cs-parser.jay: Implemented explicit attribute target declaration.
3489 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
3490 Override ValidAttributeTargets.
3493 (ReturnParameter): Class for applying custom attributes on
3495 (ParameterAtribute): New class. Class for applying custom
3496 attributes on the parameter type.
3498 2004-05-17 Miguel de Icaza <miguel@ximian.com>
3500 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
3503 (Method): Allow UNSAFE here.
3505 * modifiers.cs: Support unsafe reporting.
3507 2004-05-17 Marek Safar <marek.safar@seznam.cz>
3509 * decl.cs: Fix bug #58478.
3511 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3513 * statement.cs: When checking for unreachable code on an EmptyStatement,
3514 set the location. Fixes bug #58488.
3516 2004-05-13 Miguel de Icaza <miguel@ximian.com>
3518 * driver.cs: Add -pkg handling.
3520 From Gonzalo: UseShelLExecute=false
3522 2004-05-12 Marek Safar <marek.safar@seznam.cz>
3525 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
3527 (Attribute.IsClsCompliaceRequired): Moved to base for better
3529 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
3530 when attribute is AttributeUsageAttribute.
3531 (Attribute.GetValidTargets): Simplified.
3532 (Attribute.GetAttributeUsage): New method returns AttributeUsage
3533 attribute for this type.
3534 (Attribute.ApplyAttributes): Method renamed to Emit and make
3536 (GlobalAttributeSection): New class for special handling of global
3537 attributes (assembly, module).
3538 (AttributeSection.Emit): New method.
3540 * class.cs: Implemented Attributable abstract methods.
3541 (MethodCore.LabelParameters): Moved to Parameter class.
3542 (Accessor): Is back simple class.
3543 (PropertyMethod): Implemented Attributable abstract class.
3544 (DelegateMethod): Implemented Attributable abstract class.
3545 (Event): New constructor for disctintion between normal Event
3546 and Event with accessors.
3548 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
3550 * codegen.cs, const.cs, decl.cs, delegate.cs:
3551 (CommonAssemblyModulClass): Implemented Attributable abstract class
3554 * enum.cs: Implement IAttributeSupport interface.
3555 (EnumMember): New class for emum members. Implemented Attributable
3559 (ParameterBase): Is abstract.
3560 (ReturnParameter): New class for easier [return:] attribute handling.
3562 * typemanager.cs: Removed builder_to_attr.
3564 2004-05-11 Raja R Harinath <rharinath@novell.com>
3567 * attribute.cs (Attribute.GetPositionalValue): New function.
3568 * class.cs (TypeContainer.VerifyMembers): New function.
3569 (TypeContainer.Emit): Use it.
3570 (ClassOrStruct): New base class for Class and Struct.
3571 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
3572 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
3574 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
3575 then each non-static field should have a FieldOffset attribute.
3576 Otherwise, none of the fields should have a FieldOffset attribute.
3577 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
3578 and FieldOffset attributes.
3579 * typemanager.cs (TypeManager.struct_layout_attribute_type)
3580 (TypeManager.field_offset_attribute_type): New core types.
3581 (TypeManager.InitCoreTypes): Initialize them.
3583 2004-05-11 Michal Moskal <malekith@pld-linux.org>
3585 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
3586 Return correct type.
3589 2004-05-09 Miguel de Icaza <miguel@ximian.com>
3591 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
3592 be implicitly converted to ulong.
3594 * expression.cs: The logic for allowing operator &, | and ^ worked
3595 was wrong, it worked before because we did not report an error in
3596 an else branch. Fixes 57895.
3598 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
3599 allow volatile fields to be reference types.
3601 2004-05-07 Miguel de Icaza <miguel@ximian.com>
3603 * driver.cs: Add support for /debug-
3605 2004-05-07 Raja R Harinath <rharinath@novell.com>
3607 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
3608 Add a 'complain' parameter to silence errors.
3609 (Attribute.Resolve): Update to changes. Put in sanity check to catch
3610 silently overlooked type-resolutions.
3611 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
3613 (Attributes.Search): New function.
3614 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
3615 (Attributes.GetAttributeFullName): Remove hack.
3616 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
3617 Update to reflect changes.
3618 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
3619 Use Attributes.Search instead of nested loops.
3621 2004-05-07 Marek Safar <marek.safar@seznam.cz>
3624 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
3625 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
3626 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
3628 * report.cs: (Report.Warning): Renamed to Warning_T because of
3629 parameter collision.
3631 2004-05-05 Raja R Harinath <rharinath@novell.com>
3633 * expression.cs (MemberAccess.ResolveMemberAccess):
3634 Exit with non-zero status after Report.Error.
3635 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
3637 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
3639 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3641 * support.cs: Don't hang when the file is empty.
3643 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3645 * support.cs: In SeekableStreamReader, compute the preamble size of the
3646 underlying stream. Position changes should take into account that initial
3649 2004-05-03 Todd Berman <tberman@sevenl.net>
3651 * driver.cs: remove unused GetSysVersion function.
3653 2004-05-03 Todd Berman <tberman@sevenl.net>
3655 * driver.cs: Remove the hack from saturday, as well as the hack
3656 from jackson (LoadAssemblyFromGac), also adds the CWD to the
3657 link_paths to get that bit proper.
3659 2004-05-01 Todd Berman <tberman@sevenl.net>
3661 * driver.cs: Try a LoadFrom before a Load, this checks the current
3662 path. This is currently a bug in mono that is be fixed, however, this
3663 provides a workaround for now. This will be removed when the bug
3666 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
3668 * CryptoConvert.cs: Updated to latest version. Fix issue with
3669 incomplete key pairs (#57941).
3671 2004-05-01 Todd Berman <tberman@sevenl.net>
3673 * driver.cs: Remove '.' from path_chars, now System.* loads properly
3676 2004-04-30 Jackson Harper <jackson@ximian.com>
3678 * codegen.cs: Open keys readonly.
3680 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3682 * typemanager.cs: don't report cyclic struct layout when a struct
3683 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3684 which has 2 Pango.Rectangle fields.
3686 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3688 * expression.cs: Handle IntPtr comparisons with IL code
3689 rather than a method call.
3691 2004-04-29 Martin Baulig <martin@ximian.com>
3693 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3694 the list of PropertyInfo's in class hierarchy and find the
3695 accessor. Fixes #56013.
3697 2004-04-29 Martin Baulig <martin@ximian.com>
3699 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3701 2004-04-29 Martin Baulig <martin@ximian.com>
3703 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3705 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3707 2004-04-29 Martin Baulig <martin@ximian.com>
3709 * class.cs (ConstructorInitializer.Resolve): Check whether the
3710 parent .ctor is accessible. Fixes #52146.
3712 2004-04-29 Martin Baulig <martin@ximian.com>
3714 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3716 * statement.cs (Using.EmitLocalVariableDecls): Use
3717 TypeManager.idisposable_type, not typeof (IDisposable).
3718 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3720 2004-04-29 Martin Baulig <martin@ximian.com>
3722 * class.cs (Event.Define): Don't emit the field and don't set
3723 RTSpecialName and SpecialName for events on interfaces. Fixes
3726 2004-04-29 Raja R Harinath <rharinath@novell.com>
3728 Refactor Attribute.ApplyAttributes.
3729 * attribute.cs (Attributable): New base class for objects that can
3730 have Attributes applied on them.
3731 (Attribute): Make AttributeUsage fields public.
3732 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3733 (Attribute.IsInternalCall): New property.
3734 (Attribute.UsageAttr): Convert to a public read-only property.
3735 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3736 (Attribute.ResolveType, Attribute.Resolve)
3737 (Attribute.ScanForIndexerName): Update to reflect changes.
3738 (Attribute.CheckAttributeTarget): Re-format.
3739 (Attribute.ApplyAttributes): Refactor, to various
3740 Attributable.ApplyAttributeBuilder methods.
3741 * decl.cs (MemberCore): Make Attributable.
3742 * class.cs (Accessor): Make Attributable.
3743 (MethodData.ApplyAttributes): Use proper attribute types, not
3745 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3746 (TypeContainer.ApplyAttributeBuilder)
3747 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3748 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3749 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3750 (Operator.ApplyAttributeBuilder): New factored-out methods.
3751 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3752 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3753 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3754 * parameter.cs (ParameterBase): New Attributable base class
3755 that can also represent Return types.
3756 (Parameter): Update to the changes.
3758 2004-04-29 Jackson Harper <jackson@ximian.com>
3760 * driver.cs: Prefer the corlib system version when looking for
3761 assemblies in the GAC. This is still a hack, but its a better hack
3764 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3766 * decl.cs, enum.cs: Improved error 3005 reporting.
3768 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3769 (related_symbols): New private member for list of symbols
3770 related to reported error/warning.
3772 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3774 2004-04-29 Martin Baulig <martin@ximian.com>
3776 * ecore.cs (Expression.Constantify): If we're an enum and
3777 TypeManager.TypeToCoreType() doesn't give us another type, use
3778 t.UnderlyingSystemType. Fixes #56178.
3780 2004-04-29 Martin Baulig <martin@ximian.com>
3782 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3783 interfaces and for each interface, only add members directly
3784 declared in that interface. Fixes #53255.
3786 2004-04-28 Martin Baulig <martin@ximian.com>
3788 * expression.cs (ConditionalLogicalOperator): Use a temporary
3789 variable for `left' to avoid that we evaluate it more than once;
3792 2004-04-28 Martin Baulig <martin@ximian.com>
3794 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3797 2004-04-28 Martin Baulig <martin@ximian.com>
3799 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3802 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3803 whether the type is not void (CS1547).
3805 2004-04-28 Martin Baulig <martin@ximian.com>
3807 * expression.cs (Unary.DoResolveLValue): Override this and report
3808 CS0131 for anything but Operator.Indirection.
3810 2004-04-28 Martin Baulig <martin@ximian.com>
3812 Committing a patch from Ben Maurer; see bug #50820.
3814 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3817 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3820 2004-04-28 Martin Baulig <martin@ximian.com>
3822 Committing a patch from Ben Maurer; see bug #50820.
3824 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3827 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3830 2004-04-28 Martin Baulig <martin@ximian.com>
3832 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3833 (Block.AddLabel): Call DoLookupLabel() to only search in the
3836 2004-04-28 Martin Baulig <martin@ximian.com>
3838 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3839 comparing StringConstants and NullLiterals in Equality and Inequality.
3841 2004-04-28 Jackson Harper <jackson@ximian.com>
3843 * driver.cs: Attempt to load referenced assemblies from the
3844 GAC. This is the quick and dirty version of this method that
3845 doesnt take into account versions and just takes the first
3846 canidate found. Will be good enough for now as we will not have more
3847 then one version installed into the GAC until I update this method.
3849 2004-04-28 Martin Baulig <martin@ximian.com>
3851 * typemanager.cs (TypeManager.CheckStructCycles): New public
3852 static method to check for cycles in the struct layout.
3854 * rootcontext.cs (RootContext.PopulateTypes): Call
3855 TypeManager.CheckStructCycles() for each TypeContainer.
3856 [Note: We only need to visit each type once.]
3858 2004-04-28 Martin Baulig <martin@ximian.com>
3860 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3862 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3863 success and added `out object value'. Use a `bool resolved' field
3864 to check whether we've already been called rather than
3865 `ConstantValue != null' since this breaks for NullLiterals.
3867 2004-04-28 Raja R Harinath <rharinath@novell.com>
3869 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3870 setting of this flag, since the 'set' method may be non-public.
3872 2004-04-28 Raja R Harinath <rharinath@novell.com>
3874 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3875 check on current_vector.Block.
3877 2004-04-27 Martin Baulig <martin@ximian.com>
3879 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3880 a field initializer. Fixes #56459.
3882 2004-04-27 Martin Baulig <martin@ximian.com>
3884 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3885 we're not attempting to use an indexer. Fixes #52154.
3887 2004-04-27 Martin Baulig <martin@ximian.com>
3889 * statement.cs (Return): Don't create a return label if we don't
3890 need it; reverts my change from January 20th. Thanks to Ben
3893 2004-04-27 Martin Baulig <martin@ximian.com>
3895 According to the spec, `goto' can only leave a nested scope, but
3898 * statement.cs (Block.LookupLabel): Only lookup in the current
3899 block, don't recurse into parent or child blocks.
3900 (Block.AddLabel): Check in parent and child blocks, report
3901 CS0140/CS0158 if we find a duplicate.
3902 (Block): Removed this indexer for label lookups.
3903 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3904 this already does the error reporting for us.
3907 (FlowBranching.UsageVector.Block): New public variable; may be null.
3908 (FlowBranching.CreateSibling): Added `Block' argument.
3909 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3910 label for the target of a `goto' and check whether we're not
3911 leaving a `finally'.
3913 2004-04-27 Martin Baulig <martin@ximian.com>
3915 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3916 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3919 2004-04-27 Martin Baulig <martin@ximian.com>
3921 * statement.cs (Block.AddLabel): Also check for implicit blocks
3922 and added a CS0158 check.
3924 2004-04-27 Martin Baulig <martin@ximian.com>
3926 * flowanalysis.cs (FlowBranchingLoop): New class.
3927 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3928 UsageVector's instead of an ArrayList.
3929 (FlowBranching.Label): Likewise.
3930 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3931 (FlowBranching.AddBreakVector): New method.
3933 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3935 * attribute.cs: Small regression fix: only convert the type if we
3936 the type is different, fixes System.Drawing build.
3938 2004-04-27 Martin Baulig <martin@ximian.com>
3940 * attribute.cs (Attribute.Resolve): If we have a constant value
3941 for a named field or property, implicity convert it to the correct
3944 2004-04-27 Raja R Harinath <rharinath@novell.com>
3946 * statement.cs (Block.Block): Implicit blocks share
3947 'child_variable_names' fields with parent blocks.
3948 (Block.AddChildVariableNames): Remove.
3949 (Block.AddVariable): Mark variable as "used by a child block" in
3950 every surrounding block.
3951 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3952 been used in a child block, complain about violation of "Invariant
3953 meaning in blocks" rule.
3954 * cs-parser.jay (declare_local_variables): Don't use
3955 AddChildVariableNames.
3956 (foreach_statement): Don't create an implicit block: 'foreach'
3959 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3961 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3962 converting from 0L to ulong. Fixes 57522.
3964 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3966 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3967 derived class hides via 'new' keyword field from base class (test-242.cs).
3968 TODO: Handle this in the more general way.
3970 * class.cs (CheckBase): Ditto.
3972 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3974 * decl.cs (caching_flags): New member for storing cached values
3976 (MemberCore.Flags): New enum where bit flags for caching_flags
3978 (MemberCore.cls_compliance): Moved to caching_flags.
3979 (DeclSpace.Created): Moved to caching_flags.
3981 * class.cs: Use caching_flags instead of DeclSpace.Created
3983 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3985 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3986 if we are only a derived class, not a nested class.
3988 * typemanager.cs: Same as above, but do this at the MemberLookup
3989 level (used by field and methods, properties are handled in
3990 PropertyExpr). Allow for the qualified access if we are a nested
3993 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3995 * class.cs: Refactoring.
3996 (IMethodData): New inteface; Holds links to parent members
3997 to avoid member duplication (reduced memory allocation).
3998 (Method): Implemented IMethodData interface.
3999 (PropertyBase): New inner classes for get/set methods.
4000 (PropertyBase.PropertyMethod): Implemented IMethodData interface
4001 (Event): New inner classes for add/remove methods.
4002 (Event.DelegateMethod): Implemented IMethodData interface.
4004 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
4005 EmitContext (related to class.cs refactoring).
4007 2004-04-21 Raja R Harinath <rharinath@novell.com>
4009 * delegate.cs (Delegate.VerifyApplicability): If the number of
4010 arguments are the same as the number of parameters, first try to
4011 verify applicability ignoring any 'params' modifier on the last
4015 2004-04-16 Raja R Harinath <rharinath@novell.com>
4017 * class.cs (TypeContainer.AddIndexer): Use
4018 'ExplicitInterfaceName' to determine if interface name was
4019 explicitly specified. 'InterfaceType' is not initialized at this time.
4020 (TypeContainer.DefineIndexers): Remove use of temporary list. The
4021 Indexers array is already in the required order. Initialize
4022 'IndexerName' only if there are normal indexers.
4023 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
4024 (TypeContainer.Emit): Emit DefaultMember attribute only if
4025 IndexerName is initialized.
4028 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
4030 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
4033 2004-04-15 Raja R Harinath <rharinath@novell.com>
4035 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
4039 * attribute.cs (Attribute.Resolve): Check for duplicate named
4043 2004-04-15 Miguel de Icaza <miguel@ximian.com>
4045 * iterators.cs (MarkYield): track whether we are in an exception,
4046 and generate code accordingly. Use a temporary value to store the
4047 result for our state.
4049 I had ignored a bit the interaction of try/catch with iterators
4050 since their behavior was not entirely obvious, but now it is
4051 possible to verify that our behavior is the same as MS .NET 2.0
4055 2004-04-14 Miguel de Icaza <miguel@ximian.com>
4057 * iterators.cs: Avoid creating temporaries if there is no work to
4060 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
4061 Enumerations, use TypeManager.EnumToUnderlying and call
4064 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
4067 (This.Emit): Use EmitContext.EmitThis to emit our
4070 (This.EmitAssign): Ditto.
4072 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
4073 codepaths, we will move all the functionality into
4076 (FieldExpr.EmitAssign): Ditto.
4078 This fixes several hidden bugs that I uncovered while doing a code
4079 review of this today.
4081 * codegen.cs (EmitThis): reworked so the semantics are more clear
4082 and also support value types "this" instances.
4084 * iterators.cs: Changed so that for iterators in value types, we
4085 do not pass the value type as a parameter.
4087 Initialization of the enumerator helpers is now done in the caller
4088 instead of passing the parameters to the constructors and having
4089 the constructor set the fields.
4091 The fields have now `assembly' visibility instead of private.
4093 2004-04-11 Miguel de Icaza <miguel@ximian.com>
4095 * expression.cs (Argument.Resolve): Check if fields passed as ref
4096 or out are contained in a MarshalByRefObject.
4098 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
4099 another compiler type.
4101 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
4103 * class.cs (Indexer.Define): use the new name checking method.
4104 Also, return false on an error.
4105 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
4106 (is_identifier_[start/part]_character): make static.
4108 2004-04-10 Miguel de Icaza <miguel@ximian.com>
4110 * expression.cs (Binary.ResolveOperator): Do no append strings
4111 twice: since we can be invoked more than once (array evaluation)
4112 on the same concatenation, take care of this here. Based on a fix
4113 from Ben (bug #56454)
4115 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
4117 * codegen.cs: Fix another case where CS1548 must be reported (when
4118 delay-sign isn't specified and no private is available #56564). Fix
4119 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4120 error when MCS is used on the MS runtime and we need to delay-sign
4121 (which seems unsupported by AssemblyBuilder - see #56621).
4123 2004-04-08 Marek Safar <marek.safar@seznam.cz>
4125 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
4126 (TypeManager.ComputeNamespaces): Faster implementation for
4129 * compiler.csproj: Updated AssemblyName to mcs.
4131 2004-04-07 Miguel de Icaza <miguel@ximian.com>
4133 * rootcontext.cs: Add new types to the boot resolution.
4135 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
4136 MulticastDelegate is not allowed.
4138 * typemanager.cs: Add new types to lookup: System.TypedReference
4141 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
4142 check for TypedReference or ArgIterator, they are not allowed.
4144 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
4145 makes us properly catch 1510 in some conditions (see bug 56016 for
4148 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
4150 * CryptoConvert.cs: update from corlib version
4153 2004-04-05 Miguel de Icaza <miguel@ximian.com>
4155 * class.cs (Indexer.Define): Check indexername declaration
4157 2004-04-05 Marek Safar <marek.safar@seznam.cz>
4159 * attribute.cs (IsClsCompliant): Fixed problem with handling
4160 all three states (compliant, not-compliant, undetected).
4162 2004-03-30 Marek Safar <marek.safar@seznam.cz>
4164 * attribute.cs (Attribute): Location is now public.
4165 (Resolve): Store resolved arguments (pos_values) in attribute class.
4166 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
4167 (GetClsCompliantAttributeValue): New method that gets
4168 CLSCompliantAttribute value.
4169 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
4170 if exists else null.
4171 (AttributeTester): New class for CLS-Compliant verification routines.
4173 * class.cs (Emit): Add CLS-Compliant verification.
4174 (Method.GetSignatureForError): Implemented.
4175 (Constructor.GetSignatureForError): Implemented
4176 (Constructor.HasCompliantArgs): Returns if constructor has
4177 CLS-Compliant arguments.
4178 (Constructor.Emit): Override.
4179 (Construcor.IsIdentifierClsCompliant): New method; For constructors
4180 is needed to test only parameters.
4181 (FieldBase.GetSignatureForError): Implemented.
4182 (TypeContainer): New member for storing base interfaces.
4183 (TypeContainer.FindMembers): Search in base interfaces too.
4185 * codegen.cs (GetClsComplianceAttribute): New method that gets
4186 assembly or module CLSCompliantAttribute value.
4187 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
4189 (ModuleClass.Emit): Add error 3012 test.
4191 * const.cs (Emit): Override and call base for CLS-Compliant tests.
4193 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
4194 state for all decl types.
4195 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
4196 if CLS-Compliant tests are required.
4197 (IsClsCompliaceRequired): New method. Analyze whether code
4198 must be CLS-Compliant.
4199 (IsExposedFromAssembly): New method. Returns true when MemberCore
4200 is exposed from assembly.
4201 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
4202 value or gets cached value.
4203 (HasClsCompliantAttribute): New method. Returns true if MemberCore
4204 is explicitly marked with CLSCompliantAttribute.
4205 (IsIdentifierClsCompliant): New abstract method. This method is
4206 used to testing error 3005.
4207 (IsIdentifierAndParamClsCompliant): New method. Common helper method
4208 for identifier and parameters CLS-Compliant testing.
4209 (VerifyClsCompliance): New method. The main virtual method for
4210 CLS-Compliant verifications.
4211 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
4212 null. I don't know why is null (too many public members !).
4213 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
4214 and get value of first CLSCompliantAttribute that found.
4216 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
4217 (VerifyClsCompliance): Override and add extra tests.
4219 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
4220 clscheck- disable CLS-Compliant verification event if assembly is has
4221 CLSCompliantAttribute(true).
4223 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
4224 ApllyAttribute is now called in emit section as in the other cases.
4225 Possible future Emit integration.
4226 (IsIdentifierClsCompliant): New override.
4227 (VerifyClsCompliance): New override.
4228 (GetEnumeratorName): Returns full enum name.
4230 * parameter.cs (GetSignatureForError): Implemented.
4232 * report.cs (WarningData): New struct for Warning message information.
4233 (LocationOfPreviousError): New method.
4234 (Warning): New method. Reports warning based on the warning table.
4235 (Error_T): New method. Reports error based on the error table.
4237 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
4238 verifications are done here.
4240 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
4242 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
4243 CLSCompliantAttribute.
4244 (all_imported_types): New member holds all imported types from other
4246 (LoadAllImportedTypes): New method fills static table with exported types
4247 from all referenced assemblies.
4248 (Modules): New property returns all assembly modules.
4250 2004-03-30 Miguel de Icaza <miguel@ximian.com>
4252 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
4253 throwing a parser error.
4255 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
4256 which removes the hardcoded get_/set_ prefixes for properties, as
4257 IL allows for the properties to be named something else.
4261 * expression.cs: Do not override operand before we know if it is
4264 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4266 * typemanager.cs: support for pinned variables.
4268 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4270 * decl.cs, typemanager.cs: Avoid using an arraylist
4271 as a buffer if there is only one result set.
4273 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4275 * expression.cs: Make sure you cant call a static method
4276 with an instance expression, bug #56174.
4278 2004-03-29 Miguel de Icaza <miguel@ximian.com>
4280 * class.cs (IsDuplicateImplementation): Improve error reporting to
4281 flag 663 (method only differs in parameter modifier).
4283 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
4284 in preprocessor directives.
4286 * location.cs (LookupFile): Allow for the empty path.
4288 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
4289 better approach for some of that patch, but its failing with the
4290 CharSet enumeration. For now try/catch will do.
4292 * typemanager.cs: Do not crash if a struct does not have fields.
4295 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4297 * expression.cs: cs0213, cant fix a fixed expression.
4300 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4302 * cs-parser.jay: detect invalid embeded statements gracefully.
4305 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4307 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
4310 the invocation type may not be a subclass of the tye of the item/
4311 The type of the item must be a subclass of the invocation item.
4316 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
4318 * attribute.cs: Added methods to get a string and a bool from an
4319 attribute. Required to information from AssemblyKeyFileAttribute,
4320 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
4321 * codegen.cs: Modified AssemblyName creation to include support for
4322 strongnames. Catch additional exceptions to report them as CS1548.
4323 * compiler.csproj: Updated include CryptoConvert.cs.
4324 * compiler.csproj.user: Removed file - user specific configuration.
4325 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
4326 Mono.Security assembly. The original class is maintained and tested in
4327 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
4328 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
4329 like CSC 8.0 (C# v2) supports.
4330 * Makefile: Added CryptoConvert.cs to mcs sources.
4331 * rootcontext.cs: Added new options for strongnames.
4333 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
4335 * driver.cs: For --expect-error, report error code `2'
4336 if the program compiled with no errors, error code `1' if
4337 it compiled with an error other than the one expected.
4339 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
4341 * compiler.csproj: Updated for Visual Studio .NET 2003.
4342 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
4343 * compiler.sln: Updated for Visual Studio .NET 2003.
4345 2004-03-24 Ravi Pratap M <ravi@ximian.com>
4347 * expression.cs: Fix bug #47234. We basically need to apply the
4348 rule that we prefer the conversion of null to a reference type
4349 when faced with a conversion to 'object' (csc behaviour).
4351 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4353 * statement.cs: Shorter form for foreach, eliminates
4354 a local variable. r=Martin.
4356 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4358 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
4359 checks if we can use brtrue/brfalse to test for 0.
4360 * expression.cs: use the above in the test for using brtrue/brfalse.
4363 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4365 * expression.cs: Rewrite string concat stuff. Benefits:
4367 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
4368 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
4369 rather than a concat chain.
4371 * typemanager.cs: Add lookups for more concat overloads.
4373 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4375 * expression.cs: Emit shorter il code for array init.
4392 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
4394 * statement.cs: Before, two switch blocks would be merged if the
4395 total size of the blocks (end_item - begin_item + 1) was less than
4396 two times the combined sizes of the blocks.
4398 Now, it will only merge if after the merge at least half of the
4403 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
4405 * class.cs : csc build fix for GetMethods(). See bug #52503.
4407 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
4409 * expression.cs: Make sure fp comparisons work with NaN.
4410 This fixes bug #54303. Mig approved this patch a long
4411 time ago, but we were not able to test b/c the runtime
4414 2004-03-19 Miguel de Icaza <miguel@ximian.com>
4416 * ecore.cs (TypExpr.GetHashCode): implement this overload.
4418 2004-03-19 Martin Baulig <martin@ximian.com>
4420 * class.cs (MemberCore.IsDuplicateImplementation): Report the
4421 error here and not in our caller.
4423 2004-03-19 Martin Baulig <martin@ximian.com>
4425 * interface.cs: Completely killed this file.
4426 (Interface): We're now a TypeContainer and live in class.cs.
4428 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4429 argument; we're now also called for interfaces.
4430 (TypeContainer.DefineMembers): Allow this method being called
4432 (TypeContainer.GetMethods): New public method; formerly known as
4433 Interface.GetMethod(). This is used by PendingImplementation.
4434 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4435 it's now private and non-static.
4436 (Interface): Moved this here; it's now implemented similar to
4438 (Method, Property, Event, Indexer): Added `bool is_interface'
4439 argument to their .ctor's.
4440 (MemberBase.IsInterface): New public field.
4442 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4443 instances instead of InterfaceMethod, InterfaceProperty, etc.
4444 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4445 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4447 2004-03-19 Martin Baulig <martin@ximian.com>
4449 * class.cs (MethodCore.IsDuplicateImplementation): New private
4450 method which does the CS0111 checking.
4451 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4452 Use IsDuplicateImplementation().
4454 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4456 * decl.cs (FindMemberToOverride): New method to find the correct
4457 method or property to override in the base class.
4459 - Make Method/Property use the above method to find the
4460 version in the base class.
4461 - Remove the InheritableMemberSignatureCompare as it is now
4464 This patch makes large code bases much faster to compile, as it is
4465 O(n) rather than O(n^2) to do this validation.
4467 Also, it fixes bug 52458 which is that nested classes are not
4468 taken into account when finding the base class member.
4470 Reviewed/Approved by Martin.
4472 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4474 * interface.cs: In all interface classes removed redundant
4475 member initialization.
4477 2004-03-16 Martin Baulig <martin@ximian.com>
4479 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4481 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4483 * decl.cs (DefineTypeAndParents): New helper method to define a
4484 type's containers before the type itself is defined; This is a
4485 bug exposed by the recent changes to Windows.Forms when an
4486 implemented interface was defined inside a class that had not been
4489 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4491 (Check): Loop correctly to report errors modifiers
4492 (UNSAFE was not in the loop, since it was the same as TOP).
4494 * interface.cs: Every interface member now takes a ModFlags,
4495 instead of a "is_new" bool, which we set on the base MemberCore.
4497 Every place where we called "UnsafeOk" in the interface, now we
4498 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4499 the unsafe settings from the member declaration instead of the
4500 container interface.
4502 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4504 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4505 `set_indexer_name' to the pending bits (one per type).
4507 We fixed a bug today that was picking the wrong method to
4508 override, since for properties the existing InterfaceMethod code
4509 basically ignored the method name. Now we make sure that the
4510 method name is one of the valid indexer names.
4512 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4514 * support.cs (SeekableStreamReader): Keep track of stream byte
4515 positions and don't mix them with character offsets to the buffer.
4517 Patch from Gustavo Giráldez
4519 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4521 * interface.cs (InterfaceSetGetBase): Removed double member
4522 initialization, base class does it as well.
4524 2004-03-13 Martin Baulig <martin@ximian.com>
4526 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4527 when compiling corlib.
4529 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4531 * convert.cs (ExplicitConversion): We were reporting an error on
4532 certain conversions (object_type source to a value type, when the
4533 expression was `null') before we had a chance to pass it through
4534 the user defined conversions.
4536 * driver.cs: Replace / and \ in resource specifications to dots.
4539 * class.cs: Add check for duplicate operators. Fixes 52477
4541 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4543 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4544 that are in the middle of the statements, not only at the end.
4547 * class.cs (TypeContainer.AddField): No longer set the
4548 `HaveStaticConstructor' flag, now we call it
4549 `UserDefineStaticConstructor' to diferentiate the slightly
4550 semantic difference.
4552 The situation is that we were not adding BeforeFieldInit (from
4553 Modifiers.TypeAttr) to classes that could have it.
4554 BeforeFieldInit should be set to classes that have no static
4559 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4561 And most importantly Zoltan's comment:
4563 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4565 "I think beforefieldinit means 'it's ok to initialize the type sometime
4566 before its static fields are used', i.e. initialization does not need
4567 to be triggered by the first access to the type. Setting this flag
4568 helps the JIT to compile better code, since it can run the static
4569 constructor at JIT time, and does not need to generate code to call it
4570 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4571 this flag for lots of classes like String.
4573 csc sets this flag if the type does not have an explicit static
4574 constructor. The reasoning seems to be that if there are only static
4575 initalizers for a type, and no static constructor, then the programmer
4576 does not care when this initialization happens, so beforefieldinit
4579 This bug prevents the AOT compiler from being usable, since it
4580 generates so many calls to mono_runtime_class_init that the AOT code
4581 is much slower than the JITted code. The JITted code is faster,
4582 because it does not generate these calls if the vtable is type is
4583 already initialized, which is true in the majority of cases. But the
4584 AOT compiler can't do this."
4586 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4588 * class.cs (MethodData.Emit): Refactor the code so symbolic
4589 information is generated for destructors; For some reasons we
4590 were taking a code path that did not generate symbolic information
4593 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4595 * class.cs: Create a Constructor.CheckBase method that
4596 takes care of all validation type code. The method
4597 contains some code that was moved from Define.
4599 It also includes new code that checks for duplicate ctors.
4600 This fixes bug #55148.
4602 2004-03-09 Joshua Tauberer <tauberer@for.net>
4604 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4605 a { ... }-style array creation invokes EmitStaticInitializers
4606 which is not good for reference-type arrays. String, decimal
4607 and now null constants (NullCast) are not counted toward
4608 static initializers.
4610 2004-03-05 Martin Baulig <martin@ximian.com>
4612 * location.cs (SourceFile.HasLineDirective): New public field;
4613 specifies whether the file contains or is referenced by a "#line"
4615 (Location.DefineSymbolDocuments): Ignore source files which
4616 either contain or are referenced by a "#line" directive.
4618 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4620 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4621 direct access to our parent, so check the method inline there.
4623 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4625 * expression.cs (Invocation.EmitCall): Miguel's last commit
4626 caused a regression. If you had:
4631 In Foo the implict this would be null.
4633 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4635 * expression.cs (Invocation.EmitCall): If the method is not
4636 virtual, do not emit a CallVirt to it, use Call.
4638 * typemanager.cs (GetFullNameSignature): Improve the method to
4639 cope with ".ctor" and replace it with the type name.
4641 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4642 as an argument the ConstructorBuilder where it is being defined,
4643 to catch the recursive constructor invocations.
4645 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4647 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4648 routines to check if a type is an enumerable/enumerator allow
4649 classes that implement the IEnumerable or IEnumerator interfaces.
4651 * class.cs (Property, Operator): Implement IIteratorContainer, and
4652 implement SetYields.
4654 (Property.Define): Do the block swapping for get_methods in the
4655 context of iterators. We need to check if Properties also
4656 include indexers or not.
4658 (Operator): Assign the Block before invoking the
4659 OperatorMethod.Define, so we can trigger the Iterator code
4662 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4663 Property and Operator classes are not created when we parse the
4664 declarator but until we have the block completed, so we use a
4665 singleton SimpleIteratorContainer.Simple to flag whether the
4666 SetYields has been invoked.
4668 We propagate this setting then to the Property or the Operator to
4669 allow the `yield' to function.
4671 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4673 * codegen.cs: Implemented attribute support for modules.
4674 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4675 Assembly/Module functionality.
4677 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4678 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4679 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4681 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4683 * interface.cs (FindMembers): The operation is performed on all base
4684 interfaces and not only on the first. It is required for future CLS Compliance patch.
4686 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4688 * statement.cs, codegen.cs:
4689 This patch deals with patterns such as:
4691 public class List : IEnumerable {
4693 public MyEnumerator GetEnumerator () {
4694 return new MyEnumerator(this);
4697 IEnumerator IEnumerable.GetEnumerator () {
4701 public struct MyEnumerator : IEnumerator {
4706 Before, there were a few things we did wrong:
4707 1) we would emit callvirt on a struct, which is illegal
4708 2) we emited ldarg when we needed to emit ldarga
4709 3) we would mistakenly call the interface methods on an enumerator
4710 type that derived from IEnumerator and was in another assembly. For example:
4712 public class MyEnumerator : IEnumerator
4714 Would have the interface methods called, even if there were public impls of the
4715 method. In a struct, this lead to invalid IL code.
4717 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4719 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4722 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4724 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4726 * cs-parser.jay: Fix small regression: we were not testing V2
4727 compiler features correctly.
4729 * interface.cs: If the emit context is null, then create one
4731 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4733 * decl.cs (GetSignatureForError): New virtual method to get full name
4736 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4737 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4739 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4740 Duplicated members and code in these classes has been removed.
4741 Better encapsulation in these classes.
4743 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4745 * assign.cs (Assign.DoResolve): When dealing with compound
4746 assignments, there is a new rule in ECMA C# 2.4 (might have been
4747 there before, but it is documented here) that states that in:
4751 If b is of type int, and the `op' is a shift-operator, then the
4752 above is evaluated as:
4756 * expression.cs (Binary.ResolveOperator): Instead of testing for
4757 int/uint/long/ulong, try to implicitly convert to any of those
4758 types and use that in pointer arithmetic.
4760 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4761 method to print information for from the type, not from the
4762 null-method we were given.
4764 2004-02-01 Duncan Mak <duncan@ximian.com>
4766 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4767 parsing for cmd, fixes bug #53694.
4769 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4771 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4772 in the member name duplication tests. Property and operator name duplication
4773 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4775 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4777 * interface.cs (PopulateMethod): Fixed crash when interface method
4778 returns not existing type (error test cs0246-3.cs).
4780 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4782 * cs-parser.jay (interface_accessors): Re-write actions to also
4783 store attributes attached to get and set methods. Fix spelling
4786 (inteface_property_declaration): Modify accordingly.
4788 (InterfaceAccessorInfo): New helper class to store information to pass
4789 around between rules that use interface_accessors.
4791 * interface.cs (Emit): Apply attributes on the get and set
4792 accessors of properties and indexers too.
4794 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4795 right MethodBuilder when applying attributes to the get and set accessors.
4797 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4799 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4801 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4803 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4805 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4807 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4808 changes that treat `yield' specially when present before `break'
4811 * cs-tokenizer.cs: yield is no longer a keyword.
4813 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4815 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4816 setting for default constructors.
4817 For default constructors are almost every time set wrong Modifier. The
4818 generated IL code has been alright. But inside mcs this values was
4819 wrong and this was reason why several of my CLS Compliance tests
4822 2004-01-22 Martin Baulig <martin@ximian.com>
4824 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4825 not a QualifiedIdentifier. This is what `type_name_expression'
4826 was previously doing.
4827 (type_name_expression): Removed; the code is now in
4828 `namespace_or_type_name'.
4829 (qualified_identifier): Removed, use `namespace_or_type_name'
4831 (QualifiedIdentifier): Removed this class.
4833 2004-01-22 Martin Baulig <martin@ximian.com>
4835 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4836 not a string as alias name.
4838 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4840 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4841 #52730 bug, and instead compute correctly the need to use a
4842 temporary variable when requesting an address based on the
4843 static/instace modified of the field and the constructor.
4845 2004-01-21 Martin Baulig <martin@ximian.com>
4847 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4848 class and namespace before looking up aliases. Fixes #52517.
4850 2004-01-21 Martin Baulig <martin@ximian.com>
4852 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4853 assinged in a 'try'; fixes exception4.cs.
4855 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4856 * class.cs : Implemented parameter-less constructor for TypeContainer
4858 * decl.cs: Attributes are now stored here. New property OptAttributes
4860 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4862 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4864 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4866 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4867 (CSharpSignature): New method for indexer and property signature.
4869 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4871 * pending.cs (IsVirtualFilter): Faster implementation.
4873 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4875 * typemanager.cs: Avoid inclusion of same assembly more than once.
4877 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4879 * cs-parser.jay: Fixed problem where the last assembly attribute
4880 has been applied also to following declaration (class, struct, etc.)
4882 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4884 * class.cs: Added error CS0538, CS0539 reporting.
4885 Fixed crash on Microsoft runtime when field type is void.
4887 * cs-parser.jay: Added error CS0537 reporting.
4889 * pending.cs: Added error CS0535 reporting.
4890 Improved error report for errors CS0536, CS0534.
4892 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4894 Merge a few bits from the Anonymous Method MCS tree.
4896 * statement.cs (ToplevelBlock): New class for toplevel methods,
4897 will hold anonymous methods, lifted variables.
4899 * cs-parser.jay: Create toplevel blocks for delegates and for
4900 regular blocks of code.
4902 2004-01-20 Martin Baulig <martin@ximian.com>
4904 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4905 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4906 and `NeedExplicitReturn'; added `IsLastStatement'.
4907 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4908 have a `ReturnLabel' or we're not unreachable.
4910 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4911 child's reachability; don't just override ours with it. Fixes
4912 #58058 (lluis's example).
4913 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4914 InFinally(), InLoop(), InSwitch() and
4915 BreakCrossesTryCatchBoundary() methods.
4917 * statement.cs (Return): Do all error checking in Resolve().
4918 Unless we are the last statement in a top-level block, always
4919 create a return label and jump to it.
4920 (Break, Continue): Do all error checking in Resolve(); also make
4921 sure we aren't leaving a `finally'.
4922 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4923 statement in a top-level block.
4924 (Block.Flags): Added `IsDestructor'.
4925 (Block.IsDestructor): New public property.
4927 2004-01-20 Martin Baulig <martin@ximian.com>
4929 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4931 2004-01-20 Martin Baulig <martin@ximian.com>
4933 * statement.cs (Statement.ResolveUnreachable): New public method.
4934 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4935 (Block.Resolve): Resolve unreachable statements.
4937 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4939 * expression.cs: We need to fix the case where we do
4940 not have a temp variable here.
4942 * assign.cs: Only expression compound assignments need
4943 temporary variables.
4945 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4947 * flowanalysis.cs: Reduce memory allocation in a few ways:
4948 - A block with no variables should not allocate a bit
4950 - A method with no out parameters does not need any tracking
4951 for assignment of the parameters, so we need not allocate
4954 public readonly Type[] VariableTypes;
4955 public readonly string[] VariableNames;
4956 Are redundant. The data is already stored in the variable
4957 map, so we need not allocate another array for it.
4958 - We need to add alot of checks for if (params | locals) == null
4959 due to the first two changes.
4961 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4963 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4964 implement IMemoryLocation, we store a copy on a local variable and
4965 take the address of it. Patch from Benjamin Jemlich
4967 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4968 to use a special "type_name_expression" rule which reduces the
4969 number of "QualifiedIdentifier" classes created, and instead
4970 directly creates MemberAccess expressions.
4972 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4974 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4975 that fixes #52853. Null literal assignment to ValueType
4977 * class.cs (MethodData.Emit): Instead of checking the name of the
4978 method to determine if its a destructor, create a new derived
4979 class from Method called Destructor, and test for that.
4981 * cs-parser.jay: Create a Destructor object instead of a Method.
4983 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4987 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4989 * expression.cs (Binary.ResolveOperator): Perform an implicit
4990 conversion from MethodGroups to their delegate types on the
4993 * delegate.cs: Introduce a new class DelegateCreation that is the
4994 base class for `NewDelegate' and `ImplicitDelegateCreation',
4995 factor some code in here.
4997 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4998 conversion from MethodGroups to compatible delegate types.
5000 * ecore.cs (Expression.Resolve): Do not flag error 654
5001 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
5002 we allow conversions from MethodGroups to delegate types now.
5004 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
5005 assignments in v2 either.
5007 2004-01-10 Miguel de Icaza <miguel@ximian.com>
5009 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
5010 static read-only fields in ctors.
5012 Applied patch from Benjamin Jemlich
5014 * expression.cs (UnaryMutator): Avoid leaking local variables.
5016 2004-01-09 Miguel de Icaza <miguel@ximian.com>
5018 * cs-tokenizer.cs (IsCastToken): Allow the various native types
5019 here to return true, as they can be used like this:
5023 Fixed 49836 and all the other dups
5025 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
5027 * driver.cs: Implement /win32res and /win32icon.
5029 2004-01-08 Miguel de Icaza <miguel@ximian.com>
5031 * cs-parser.jay: Add a rule to improve error handling for the
5032 common mistake of placing modifiers after the type.
5034 2004-01-07 Miguel de Icaza <miguel@ximian.com>
5036 * cs-parser.jay (interface_event_declaration): Catch
5037 initialization of events on interfaces, and report cs0068
5039 * cs-parser.jay (interface_event_declaration): Catch
5040 initialization of events.
5042 * ecore.cs: Better report missing constructors.
5044 * expression.cs (Binary.ResolveOperator): My previous bug fix had
5045 the error reporting done in the wrong place. Fix.
5047 * expression.cs (Binary.ResolveOperator): Catch the
5048 operator + (E x, E y) error earlier, and later allow for implicit
5049 conversions in operator +/- (E e, U x) from U to the underlying
5052 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
5053 52596, if the container class is abstract, the default constructor
5054 is protected otherwise its public (before, we were always public).
5056 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
5059 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
5060 Jemlich that fixes bug #52597, MCS was generating invalid code for
5061 idisposable structs. Thanks to Ben for following up with this
5064 2004-01-06 Miguel de Icaza <miguel@ximian.com>
5066 * driver.cs: Allow assemblies without code to be generated, fixes
5069 2004-01-07 Nick Drochak <ndrochak@gol.com>
5071 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
5073 2004-01-05 Miguel de Icaza <miguel@ximian.com>
5075 * cs-parser.jay: Add rules to improve error reporting if fields or
5076 methods are declared at the namespace level (error 116)
5078 * Add rules to catch event add/remove
5080 2004-01-04 David Sheldon <dave-mono@earth.li>
5082 * expression.cs: Added matching ")" to error message for
5085 2004-01-03 Todd Berman <tberman@gentoo.org>
5087 * ecore.cs, attribute.cs:
5088 Applying fix from #52429.
5090 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5092 * ecore.cs, expression.cs, statement.cs:
5093 Total rewrite of how we handle branching. We
5094 now handle complex boolean expressions with fewer
5095 jumps. As well if (x == 0) no longer emits a ceq.
5097 if (x is Foo) is much faster now, because we generate
5100 Overall, we get a pretty big improvement on our benchmark
5101 tests. The code we generate is smaller and more readable.
5103 I did a full two-stage bootstrap. The patch was reviewed
5104 by Martin and Miguel.
5106 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5108 * cs-parser.jay: Make primary_expression not take a QI.
5109 we dont need this because the member_access rule covers
5110 us here. So we replace the rule with just IDENTIFIER.
5112 This has two good effects. First, we remove a s/r conflict.
5113 Second, we allocate many fewer QualifiedIdentifier objects.
5115 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5117 * attribute.cs: Handle MarshalAs attributes as pseudo, and
5118 set the correct information via SRE. This prevents
5119 hanging on the MS runtime. Fixes #29374.
5121 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5123 * convert.cs: correctly handle conversions to value types
5124 from Enum and ValueType as unboxing conversions.
5126 Fixes bug #52569. Patch by Benjamin Jemlich.
5128 2004-01-02 Ravi Pratap <ravi@ximian.com>
5130 * expression.cs (BetterConversion): Prefer int -> uint
5131 over int -> ulong (csc's behaviour). This fixed bug #52046.
5133 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
5135 * decl.cs (MemberCache.FindMembers): now returns a
5138 * typemanager.cs: In general, go with with ^^.
5139 (CopyNewMethods): take an IList.
5140 (RealMemberLookup): Only allocate an arraylist
5141 if we copy from two sets of methods.
5143 This change basically does two things:
5144 1) Fewer array lists allocated due to CopyNewMethods.
5145 2) the explicit cast in MemberList costed ALOT.
5147 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
5149 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
5150 a hashtable to avoid needless string allocations when an identifier is
5151 used more than once (the common case).
5153 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5155 * pending.cs: MS's TypeBuilder.GetInterfaces ()
5156 is broken, it will not return anything. So, we
5157 have to use the information we have in mcs to
5160 * typemanager.cs: Add a cache for GetInterfaces,
5161 since this will now be used more often (due to ^^)
5163 (GetExplicitInterfaces) New method that gets the
5164 declared, not effective, interfaces on a type
5165 builder (eg, if you have interface IFoo, interface
5166 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
5169 This patch makes MCS able to bootstrap itself on
5172 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5174 * expression.cs: Remove the Nop's that Miguel put
5177 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5179 * report.cs, codegen.cs: Give the real stack trace to
5180 the error when an exception is thrown.
5182 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5184 * decl.cs: only allocate hashtables for ifaces if
5187 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5189 * expression.cs: fix the error from cs0121-2.cs
5190 (a parent interface has two child interfaces that
5191 have a function with the same name and 0 params
5192 and the function is called through the parent).
5194 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
5196 * class.cs, rootcontext.cs, typmanager.cs: do not
5199 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
5201 * codegen.cs: remove stack for the ec flow branching.
5202 It is already a linked list, so no need.
5204 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
5206 * Makefile: Allow custom profiler here.
5208 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5210 * typemanager.cs (LookupType):
5211 - Use a static char [], because split takes
5212 a param array for args, so it was allocating
5214 - Do not store true in a hashtable, it boxes.
5216 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5218 * flowanalysis.cs: bytify common enums.
5220 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5222 * modifiers.cs: Add a new set of flags for the
5223 flags allowed on explicit interface impls.
5224 * cs-parser.jay: catch the use of modifiers in
5225 interfaces correctly.
5226 * class.cs: catch private void IFoo.Blah ().
5228 All related to bug #50572.
5230 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5232 * decl.cs: Rewrite the consistant accessability checking.
5233 Accessability is not linear, it must be implemented in
5234 a tableish way. Fixes #49704.
5236 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5238 * expression.cs: Handle negation in a checked context.
5239 We must use subtraction from zero. Fixes #38674.
5241 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5243 * class.cs: Ignore static void main in DLLs.
5244 * rootcontext.cs: Handle the target type here,
5245 since we are have to access it from class.cs
5246 * driver.cs: account for the above.
5248 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5250 * report.cs: Give line numbers and files if available.
5252 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
5254 * driver.cs: Implement /addmodule.
5256 * typemanager.cs: Change 'modules' field so it now contains Modules not
5259 2003-12-20 Martin Baulig <martin@ximian.com>
5261 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
5262 (FieldBase.IsAssigned): Removed this field.
5263 (FieldBase.SetAssigned): New public method.
5264 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
5266 2003-12-20 Martin Baulig <martin@ximian.com>
5268 * expression.cs (LocalVariableReference.DoResolve): Don't set
5269 `vi.Used' if we're called from DoResolveLValue().
5271 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
5272 returns the usage vector it just merged into the current one -
5273 pass this one to UsageWarning().
5274 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
5275 of the `EmitContext', don't call this recursively on our children.
5277 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
5279 * driver.cs: Implement /target:module.
5281 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
5283 * support.cs (CharArrayHashtable): New helper class.
5285 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
5286 char arrays, not strings, so we can avoid creating a string in
5287 consume_identifier if the identifier is a keyword.
5289 2003-12-16 Martin Baulig <martin@ximian.com>
5291 * statement.cs (LocalInfo.Assigned): Removed this property.
5292 (LocalInfo.Flags): Removed `Assigned'.
5293 (LocalInfo.IsAssigned): New public method; takes the EmitContext
5294 and uses flow analysis.
5295 (Block.UsageWarning): Made this method private.
5296 (Block.Resolve): Call UsageWarning() if appropriate.
5298 * expression.cs (LocalVariableReference.DoResolve): Always set
5299 LocalInfo.Used here.
5301 2003-12-13 Martin Baulig <martin@ximian.com>
5303 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
5304 any value here; we're now using flow analysis to figure out
5305 whether a statement/block returns a value.
5307 2003-12-13 Martin Baulig <martin@ximian.com>
5309 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
5311 (FlowBranching.MergeFinally): Don't call
5312 `branching.CheckOutParameters()' here, this is called in
5314 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
5315 when adding the `finally' vector.
5317 2003-12-13 Martin Baulig <martin@ximian.com>
5320 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
5321 actually work and also fix #48962.
5323 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
5325 * decl.cs: Do not check System.Object for nested types,
5326 since we know it does not have any. Big bang for buck:
5331 corlib: 17.99 seconds
5335 corlib: 17.39 seconds
5337 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5339 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5340 time we are returning 0 members, so we save alot here.
5342 2003-12-11 Martin Baulig <martin@ximian.com>
5344 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5345 `MergeChild()', also just take the `FlowBranching' as argument;
5346 call Merge() on it and return the result.
5347 (FlowBranching.Merge): We don't need to do anything if we just
5350 2003-12-11 Martin Baulig <martin@ximian.com>
5352 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5353 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5354 Maurer for this idea.
5356 2003-12-11 Martin Baulig <martin@ximian.com>
5358 * flowanalysis.cs (MergeResult): This class is now gone; we now
5359 use the `UsageVector' for this. The reason for this is that if a
5360 branching just has one sibling, we don't need to "merge" them at
5361 all - that's the next step to do.
5362 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5365 2003-12-11 Martin Baulig <martin@ximian.com>
5367 Reworked flow analyis and made it more precise and bug-free. The
5368 most important change is that we're now using a special `Reachability'
5369 class instead of having "magic" meanings of `FlowReturns'. I'll
5370 do some more cleanups and optimizations and also add some more
5371 documentation this week.
5373 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5374 largely reworked this class.
5375 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5376 the new `Reachability' class instead of having "magic" values here.
5377 (FlowBranching): We're now using an instance of `Reachability'
5378 instead of having separate `Returns', `Breaks' etc. fields.
5380 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5381 based on flow analysis; ignore the return value of block.Emit ().
5383 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5385 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5386 if they are private.
5388 2003-12-09 Martin Baulig <martin@ximian.com>
5390 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5391 call them directly on the UsageVector.
5393 2003-12-09 Martin Baulig <martin@ximian.com>
5395 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5396 Changed return type from `FlowReturns' to `Reachability'.
5398 2003-12-09 Martin Baulig <martin@ximian.com>
5400 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5401 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5402 `Reachable' fields with a single `Reachability' one.
5404 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5406 * class.cs (FindMembers): Remove foreach's.
5419 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5424 This patch does a few things:
5425 1. EmptyStatement is now a singleton, so it is never reallocated.
5426 2. All blah is EmptyStatement constructs have been changed to
5427 blah == EmptyStatement.Value, which is much faster and valid
5428 now that EmptyStatement is a singleton.
5429 3. When resolving a block, rather than allocating a new array for
5430 the non-empty statements, empty statements are replaced with
5431 EmptyStatement.Value
5432 4. Some recursive functions have been made non-recursive.
5433 Mainly the performance impact is from (3), however (1) and (2) are needed for
5434 this to work. (4) does not make a big difference in normal situations, however
5435 it makes the profile look saner.
5440 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5441 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5442 Total memory allocated: 56397 KB
5445 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5446 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5447 Total memory allocated: 55666 KB
5449 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5451 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5452 than the hashtable in a hashtable version
5454 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5455 we always end up concating a string. This results in a huge perf
5456 loss, because many strings have to be tracked by the GC. In this
5457 patch, we first use a hashtable that works with two keys, so that
5458 the strings do not need to be concat'ed.
5469 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5471 * Makefile: Add a new target `do-time' that does a quick and simple
5472 profile, leaving easy to parse output.
5474 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5476 * codegen.cs (Init): Create the dynamic assembly with
5477 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5479 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5481 * support.cs: Make the PtrHashtable use only one
5482 instance of its comparer.
5484 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5486 * typemanager.cs: Fix lookup of GetNamespaces.
5488 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5490 * expression.cs: Removed redundant line.
5492 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5493 ArrayLists, use for loops with bounds.
5495 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5498 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5499 arraylists, use for loop with bounds.
5501 The above three changes give us a 0.071 second performance
5502 improvement out of 3.294 seconds down to 3.223. On my machine
5503 the above changes reduced the memory usage by 1,387 KB during
5506 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5507 QualifiedIdentifiers. Before we created a new string through
5508 concatenation, and mostly later on, the result would be
5509 manipulated by DecomposeQI through string manipulation.
5511 This reduced the compiler memory usage for bootstrapping from
5512 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5513 compile times in 0.05 seconds.
5515 2003-11-28 Dick Porter <dick@ximian.com>
5517 * support.cs: Do string compares with the Invariant culture.
5525 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5526 the comparison is done with the Invariant culture.
5528 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5530 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5531 GetEnumerator method.
5533 (ProbeCollectionType): Iterate starting at the most specific type
5534 upwards looking for a GetEnumerator
5536 * expression.cs: Shift count can be up to 31 for int/uint and 63
5539 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5541 * statement.cs (Block.LookupLabel): Also look for the label on the
5542 children blocks. Use a hash table to keep track of visited
5545 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5546 we actually did transform the other operand, otherwise fall back
5547 to the common codepath that casts to long.
5549 * cs-tokenizer.cs: Use the same code pattern as the int case.
5550 Maybe I should do the parsing myself, and avoid depending on the
5551 Parse routines to get this done.
5553 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5555 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5556 which fixes bug 51347. This time test it.
5558 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5559 attributes for example can not tell the difference between these.
5560 The difference was only a syntax feature of the language.
5562 * attribute.cs: Apply attributes to delegates.
5564 * delegate.cs: Call the apply attributes method.
5566 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5568 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5569 comparing 0 vs Byte.MinValue, not the value
5571 (ImplicitConversionRequired): When reporting a conversion error,
5572 use error 31 to print out the constant error instead of the
5575 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5576 which fixes bug 51347.
5578 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5580 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5581 which fixes the -warnaserror command line option.
5583 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5585 * cfold.cs (DoNumericPromotions): During constant folding of
5586 additions on UIntConstant, special case intconstants with
5587 IntConstants like we do on the expression binary operator.
5589 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5591 * convert.cs (ImplicitReferenceConversion): We were missing a case
5592 (System.Enum are not value types or class types, so we need to
5593 classify them separatedly).
5595 * driver.cs: We do not support error 2007.
5597 2003-11-12 Jackson Harper <jackson@ximian.com>
5599 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5600 system directory. Also use the full file name so users can
5601 libraries names mscorlib-o-tron.dll in a non system dir.
5603 2003-11-10 Martin Baulig <martin@ximian.com>
5605 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5606 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5607 calling `ResolveType()' on them, directly assign their `Type'.
5609 2003-11-08 Martin Baulig <martin@ximian.com>
5611 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5612 return value and the `out parent' parameter.
5613 (TypeContainer.DefineType): Moved the CS0644 check into
5614 GetClassBases(). Don't pass the interface types to the
5615 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5616 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5618 * ecore.cs (TypeExpr.IsAttribute): New property.
5619 (TypeExpr.GetInterfaces): New method.
5621 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5622 TypeExpr instead of a Type.
5623 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5624 (Interface.DefineType): Don't pass the interface types to the
5625 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5626 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5628 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5629 instead of a `Type[]'.
5630 (TypeManager.RegisterBuilder): Likewise.
5631 (TypeManager.AddUserInterface): Likewise.
5632 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5633 `Type[]' and also return a `TypeExpr[]'.
5634 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5636 2003-11-08 Martin Baulig <martin@ximian.com>
5638 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5641 2003-11-08 Martin Baulig <martin@ximian.com>
5643 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5644 TypeManager.ResolveExpressionTypes().
5646 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5647 instead of an Expression.
5648 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5649 (TypeExpression): New public class; formerly known as `TypeExpr'.
5651 * expression.cs (ComposedCast): Derive from TypeExpr.
5653 * typemanager.cs (TypeManager.system_*_expr): These are now
5654 TypExpr's instead of Expression's.
5655 (TypeManager.ResolveExpressionTypes): New public static function;
5656 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5659 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5661 * expression.cs (New.DoResolve): Do not dereference value that
5662 might be a null return.
5664 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5665 sure that the constant value has the right type. Fixes an
5666 unreported bug, similar to 50425.
5668 * const.cs (Const.LookupConstantValue): Call
5669 ImplicitStandardConversionExists before doing a conversion to
5670 avoid havng the TypeManager.ChangeType do conversions.
5672 Reduced the number of casts used
5674 (Const.ChangeType): New routine to enable reuse of the constant
5675 type changing code from statement.
5677 * typemanager.cs (ChangeType): Move common initialization to
5678 static global variables.
5682 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5683 every value type to go through, even if it was void. Fix that.
5685 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5686 character of the define, and the is_identifier_part_character for
5687 the rest of the string.
5689 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5691 * expression.cs (UnaryMutator.EmitCode): When I updated
5692 LocalVariableReference.DoResolve, I overdid it, and dropped an
5693 optimization done on local variable references.
5695 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5697 * ecore.cs: Convert the return from Ldlen into an int.
5699 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5701 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5702 the accessibility, this is a special case for toplevel non-public
5703 classes (internal for instance).
5705 2003-10-20 Nick Drochak <ndrochak@gol.com>
5707 * ecore.cs: Fix typo and build. Needed another right paren.
5709 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5711 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5712 `internal' case regular and protected, but not allowing protected
5713 to be evaluated later. Bug 49840
5715 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5717 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5718 to kb.Nlast, and not the kb.nFirst to isolate the switch
5721 Extract the underlying type, so enumerations of long/ulong are
5722 treated like long/ulong.
5724 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5726 * expression.cs (New): Overload the meaning of RequestedType to
5727 track the possible creation of the NewDelegate type, since
5728 DoResolve is invoked more than once for new constructors on field
5731 See bugs: #48800 and #37014
5733 * cs-parser.jay (declare_local_constants): Take an arraylist
5734 instead of a single constant.
5736 (local_constant_declaration): It should take a
5737 constant_declarators, not a constant_declarator. Fixes 49487
5739 * convert.cs: Fix error report.
5741 2003-10-13 Jackson Harper <jackson@ximian.com>
5743 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5746 2003-10-09 Martin Baulig <martin@ximian.com>
5748 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5750 (MethodCore.DoDefineParameters): Removed the TypeContainer
5751 argument; use the DeclSpace which was passed to the .ctor instead.
5752 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5753 TypeContainer; we only need a DeclSpace here.
5755 2003-10-09 Martin Baulig <martin@ximian.com>
5757 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5759 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5760 EmitContext's .ctor.
5762 2003-10-09 Martin Baulig <martin@ximian.com>
5764 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5765 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5766 AsAccessible(), moved them as well.
5768 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5770 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5772 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5774 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5776 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5777 generation for >=, as spotted by Paolo, bug 48679.
5778 Patch from David Waite.
5780 * cs-tokenizer.cs: Add handling for #pragma.
5782 * cs-parser.jay: Allow for both yield and yield return in the
5783 syntax. The anti-cobolization of C# fight will go on!
5785 * class.cs (TypeBuilder.DefineType): Catch error condition here
5786 (Parent.DefineType erroring out and returning null).
5788 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5789 coping with enumerations variables, we were mistakenly processing
5790 them as a regular value type instead of built-in types. Fixes the
5793 * typemanager.cs (IsBuiltinOrEnum): New method.
5795 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5797 * cs-parser.jay: Upgrade: yield now needs the return clause.
5799 2003-09-19 Martin Baulig <martin@ximian.com>
5801 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5802 `MemberCache parent' argument. Normally, an interface doesn't
5803 have a parent type except System.Object, but we use this in gmcs
5804 for generic type parameters.
5806 2003-09-18 Martin Baulig <martin@ximian.com>
5808 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5809 on `type.IsInterface'; don't check whether the type has a parent
5810 to determine whether it's an interface.
5812 2003-09-15 Martin Baulig <martin@ximian.com>
5814 * class.cs (TypeContainer.DefineType): Added an error flag to
5815 avoid reporting duplicate CS0146's ("class definition is
5818 * driver.cs (Driver.MainDriver): Abort if
5819 RootContext.ResolveTree() reported any errors.
5821 2003-09-07 Martin Baulig <martin@ximian.com>
5823 * report.cs (Error, Warning): Added overloaded versions which take
5824 a `params object[] args' and call String.Format().
5826 2003-09-07 Martin Baulig <martin@ximian.com>
5828 * decl.cs (DeclSpace..ctor): Don't call
5829 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5830 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5831 (DeclSpace.RecordDecl): New method.
5833 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5835 2003-09-02 Ravi Pratap <ravi@ximian.com>
5837 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5838 value attributes to be applied to ParameterBuilders.
5840 * class.cs (MethodCore.LabelParameters): Make static and more
5841 generic so that it can be used from other places - like interface
5842 methods, for instance.
5844 * interface.cs (Interface.Emit): Call LabelParameters before
5845 emitting attributes on the InterfaceMethod.
5847 2003-08-26 Martin Baulig <martin@ximian.com>
5849 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5850 resolving aliases; fixes #47927.
5852 2003-08-26 Martin Baulig <martin@ximian.com>
5854 * statement.cs (Using.DoResolve): This is internally emitting a
5855 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5856 do not always return. Fixes #47681.
5858 2003-08-26 Martin Baulig <martin@ximian.com>
5860 * decl.cs (MemberCore): Moved WarningNotHiding(),
5861 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5863 (AdditionResult): Make this nested in DeclSpace.
5864 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5865 argument; call NamespaceEntry.Define() unless we're nested in a
5868 * namespace.cs (Namespace.DefineName): New public function. This
5869 is called from DeclSpace's .ctor to add
5870 (Namespace.Lookup): Include DeclSpaces in the lookup.
5872 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5874 * const.cs (Const): Derive from MemberBase, not MemberCore.
5876 2003-08-25 Martin Baulig <martin@ximian.com>
5878 * convert.cs (Convert.ExplicitReferenceConversion): When
5879 converting from an interface type to a class, unbox if the target
5880 type is a struct type. Fixes #47822.
5882 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5884 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5887 2003-08-22 Martin Baulig <martin@ximian.com>
5889 * class.cs (TypeManager.DefineType): When defining a nested type,
5890 call DefineType() on our parent; fixes #47801.
5892 2003-08-22 Martin Baulig <martin@ximian.com>
5894 * class.cs (MethodData.Define): While checking if a method is an
5895 interface implementation, improve the test a bit more to fix #47654.
5897 2003-08-22 Martin Baulig <martin@ximian.com>
5899 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
5900 correctly; fixes #47722.
5902 2003-08-22 Martin Baulig <martin@ximian.com>
5904 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
5905 LocalVariableReference, ensure it's not read-only. Fixes #47536.
5907 * statement.cs (Fixed.DoResolve): Make all variables read-only.
5909 2003-08-22 Martin Baulig <martin@ximian.com>
5911 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
5912 can only be assigned in static constructors. Fixes #47161.
5914 2003-08-22 Martin Baulig <martin@ximian.com>
5916 Rewrote and improved the flow analysis code.
5918 * flowbranching.cs (FlowBranching): Make this class abstract.
5919 (FlowBranching.CreateBranching): New static function to create a
5921 (FlowBranchingBlock, FlowBranchingException): New classes.
5922 (FlowBranching.UsageVector.Type): New public readonly field.
5923 (FlowBranching.UsageVector.Breaks): Removed the setter.
5924 (FlowBranching.UsageVector.Returns): Removed the setter.
5925 (FlowBranching.UsageVector): Added Break(), Return(),
5926 NeverReachable() and Throw() methods to modify the reachability.
5927 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
5928 done by FlowBranching.Merge().
5929 (FlowBranching.UsageVector.MergeChild): New method; merges the
5930 merge result into the current vector.
5931 (FlowBranching.Merge): New abstract method to merge a branching.
5933 2003-08-12 Martin Baulig <martin@ximian.com>
5935 * expression.cs (Indirection.CacheTemporaries): Create the
5936 LocalTemporary with the pointer type, not its element type.
5938 2003-08-10 Miguel de Icaza <miguel@ximian.com>
5940 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
5941 token was a keyword or not.
5943 Add `error' options where an IDENTIFIER was expected; Provide
5944 CheckToken and CheckIdentifierToken convenience error reporting
5947 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
5949 * decl.cs: Rename `NamespaceEntry Namespace' public field into
5950 NameSpaceEntry NameSpaceEntry.
5952 (LookupInterfaceOrClass): Avoid creating a full qualified name
5953 from namespace and name: avoid doing lookups when we know the
5954 namespace is non-existant. Use new Tree.LookupByNamespace which
5955 looks up DeclSpaces based on their namespace, name pair.
5957 * driver.cs: Provide a new `parser verbose' to display the
5958 exception thrown during parsing. This is turned off by default
5959 now, so the output of a failure from mcs is more graceful.
5961 * namespace.cs: Track all the namespaces defined in a hashtable
5964 (IsNamespace): New method
5966 2003-08-09 Miguel de Icaza <miguel@ximian.com>
5968 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
5969 we know that we need to concatenate (full typename can never be
5974 * statement.cs: Use a bitfield; Do not initialize to null things
5975 which are done by the constructor by default.
5977 * cs-parser.jay: bug fix, parameter was 4, not 3.
5979 * expression.cs: Just use the property;
5981 * statement.cs: No need for GetVariableInfo method.
5983 2003-08-08 Martin Baulig <martin@ximian.com>
5985 * flowanalysis.cs (FlowReturns): This is now nested in the
5986 `FlowBranching' class.
5987 (MyBitVector): Moved this here from statement.cs.
5988 (FlowBranching.SiblingType): New enum type.
5989 (FlowBranching.CreateSibling): Added `SiblingType' argument.
5991 2003-08-07 Martin Baulig <martin@ximian.com>
5993 * flowanalysis.cs (FlowBranchingType): This is now nested in the
5994 `FlowBranching' class and called `BranchingType'.
5996 2003-08-07 Martin Baulig <martin@ximian.com>
5998 * flowanalysis.cs: Moved all the control flow analysis code into
6001 2003-08-07 Martin Baulig <martin@ximian.com>
6003 * assign.cs (Assign.DoResolve): `target' must either be an
6004 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
6007 2003-08-07 Miguel de Icaza <miguel@ximian.com>
6009 * expression.cs (BinaryMethod): This kind of expression is created by the
6010 Binary class if it determines that the operator has to be handled
6013 (BinaryDelegate): This kind of expression is created if we are
6014 dealing with a + or - operator on delegates.
6016 (Binary): remove method, argumetns, and DelegateOperator: when
6017 dealing with methods,
6019 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
6021 * statement.cs (Block): use bitfields for the three extra booleans
6022 we had in use. Remove unused topblock parameter.
6024 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
6026 * assign.cs: Drop extra unneeded tests.
6028 2003-08-06 Miguel de Icaza <miguel@ximian.com>
6030 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
6032 * statement.cs (Foreach): Use VariableStorage instead of
6035 * codegen.cs (VariableStorage): New class used by clients that
6036 require a variable stored: locals or fields for variables that
6037 need to live across yield.
6039 Maybe provide a convenience api for EmitThis+EmitLoad?
6041 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
6044 2003-08-05 Miguel de Icaza <miguel@ximian.com>
6046 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
6047 RemapParameterLValue): New methods that are used to turn a
6048 precomputed FieldInfo into an expression like this:
6052 The idea is to use this instead of making LocalVariableReference
6053 have more than one meaning.
6055 * cs-parser.jay: Add error production to BASE.
6057 * ecore.cs: Deal with TypeManager.GetField returning null, which
6058 is now a valid return value.
6060 (FieldExprNoAddress): New expression for Fields whose address can
6063 * expression.cs (LocalVariableReference): During the resolve
6064 phases, create new expressions if we are in a remapping context.
6065 Remove code that dealt with remapping here.
6067 (ParameterReference): same.
6069 (ProxyInstance): New expression, like the `This' expression, but
6070 it is born fully resolved. We know what we are doing, so remove
6071 the errors that are targeted to user-provided uses of `this'.
6073 * statement.cs (Foreach): our variable is now stored as an
6074 Expression; During resolution, follow the protocol, dont just
6075 assume it will return this.
6077 2003-08-06 Martin Baulig <martin@ximian.com>
6079 * support.cs (SeekableStreamReader.cs): New public class.
6081 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
6082 SeekableStreamReader instead of the normal StreamReader.
6084 2003-08-04 Martin Baulig <martin@ximian.com>
6086 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
6087 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
6088 deambiguate casts and delegate invocations.
6089 (parenthesized_expression): Use the new tokens to ensure this is
6090 not a cast of method invocation.
6092 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
6093 when reading a `)' and Deambiguate_CloseParens () was previously
6096 * expression.cs (ParenthesizedExpression): New class. This is
6097 just used for the CS0075 test.
6098 (Binary.DoResolve): Check for CS0075.
6100 2003-07-29 Ravi Pratap <ravi@ximian.com>
6102 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
6103 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
6104 reference comparison.
6106 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
6107 examine the ReturnType for equality - this is necessary in the
6108 cases of implicit and explicit operators whose signature also
6109 includes the return type.
6111 2003-07-26 Miguel de Icaza <miguel@ximian.com>
6113 * namespace.cs: Cache the result of the namespace computation,
6114 instead of computing it every time.
6116 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6118 * decl.cs: Use a global arraylist that we reuse over invocations
6119 to avoid excesive memory consumption. Reduces memory usage on an
6120 mcs compile by one meg (45 average).
6122 * typemanager.cs (LookupTypeReflection): In .NET pointers are
6123 private, work around that.
6125 2003-07-23 Miguel de Icaza <miguel@ximian.com>
6127 * literal.cs (IntLiteral): Define Zero and One static literals.
6129 * cs-parser.jay (integer_literal): use static literals to reduce
6130 memory usage for the most used literals (0, 1 and -1). 211kb
6131 reduced in memory usage.
6133 Replace all calls to `new ArrayList' with `new
6134 ArrayList(4)' which is a good average number for most allocations,
6135 and also requires only 16 bytes of memory for its buffer by
6138 This reduced MCS memory usage in seven megabytes for the RSS after
6141 2003-07-28 Ravi Pratap <ravi@ximian.com>
6143 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
6144 handle params methods the correct way by forming only one
6145 applicable set with params and normal methods in them. Earlier we
6146 were looking at params methods only if we found no normal methods
6147 which was not the correct thing to do.
6149 (Invocation.BetterFunction): Take separate arguments indicating
6150 when candidate and the best method are params methods in their
6153 This fixes bugs #43367 and #46199.
6155 * attribute.cs: Documentation updates.
6157 (CheckAttribute): Rename to CheckAttributeTarget.
6158 (GetValidPlaces): Rename to GetValidTargets.
6160 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
6161 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
6165 2003-07-28 Martin Baulig <martin@ximian.com>
6167 * class.cs (TypeContainer.DefineMembers): Use the base type's full
6168 name when looking up the base class of a nested class. Fixes #46977.
6170 2003-07-26 Martin Baulig <martin@ximian.com>
6172 * expression.cs (Indexers.Indexer): New nested struct; contains
6173 getter, setter and the indexer's type.
6174 (Indexers.Properties): This is now an ArrayList of
6176 (IndexerAccess.DoResolveLValue): Correctly set the type if the
6177 indexer doesn't have any getters.
6179 * assign.cs (Assign.DoResolve): Also do the implicit conversions
6180 for embedded property and indexer assignments.
6182 2003-07-26 Martin Baulig <martin@ximian.com>
6184 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
6185 preprocessor directive is not the first non-whitespace character
6188 2003-07-26 Martin Baulig <martin@ximian.com>
6190 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
6191 namespace parsing, follow the spec more closely.
6193 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
6194 NamespaceEntry.Lookup().
6196 2003-07-25 Martin Baulig <martin@ximian.com>
6198 * MethodCore.cs (OverridesSomething): New public field; it's set
6199 from TypeContainer.DefineMembers if this method overrides
6200 something (which doesn't need to be a method). Fix #39462.
6202 2003-07-25 Ravi Pratap <ravi@ximian.com>
6204 * typemanager.cs (GetMembers): Ensure that the list of members is
6205 reversed. This keeps things in sync.
6207 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
6208 find an AttributeUsage attribute.
6210 * expression.cs (Invocation.OverloadResolve): Perform the check
6211 which disallows Invoke to be directly called on a Delegate.
6213 (Error_InvokeOnDelegate): Report error cs1533.
6215 2003-07-25 Martin Baulig <martin@ximian.com>
6217 * expression.cs (Indexers.GetIndexersForType): Only look in the
6218 interface hierarchy if the requested type is already an
6219 interface. Fixes #46788 while keeping #46502 fixed.
6221 2003-07-25 Martin Baulig <martin@ximian.com>
6223 * class.cs (TypeContainer.DefineMembers): Check whether all
6224 readonly fields have been assigned and report warning CS0649 if
6227 * statement.cs (LocalInfo.IsFixed): Always return true if this is
6230 2003-07-24 Ravi Pratap <ravi@ximian.com>
6232 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
6233 returned from GetMethods to make things consistent with the
6234 assumptions MCS makes about ordering of methods.
6236 This should comprehensively fix bug #45127 and it does :-)
6238 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
6239 ordering is actually reverse.
6241 * Clean up some debug messages I left lying around.
6243 * interface.cs (Populate*): Get rid of code which emits attributes
6244 since the stage in which we emit attributes is the 'Emit' stage,
6245 not the define stage.
6247 (Emit): Move attribute emission for interface members here.
6249 2003-07-22 Ravi Pratap <ravi@ximian.com>
6251 * expression.cs (Invocation.OverloadResolve): Follow the spec more
6252 closely: we eliminate methods in base types when we have an
6253 applicable method in a top-level type.
6255 Please see section 14.5.5.1 for an exact description of what goes
6258 This fixes bug #45127 and a host of other related to corlib compilation.
6260 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
6261 array is the method corresponding to the top-level type (this is
6262 because of the changes made to icall.c) so we change this
6265 (MethodGroupExpr.Name): This too.
6267 * typemanager.cs (GetElementType): New method which does the right
6268 thing when compiling corlib.
6270 * everywhere: Make use of the above in the relevant places.
6272 2003-07-22 Martin Baulig <martin@ximian.com>
6274 * cs-parser.jay (invocation_expression): Moved
6275 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
6276 `cast_expression', but create a InvocationOrCast which later
6277 resolves to either an Invocation or a Cast.
6279 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
6280 method; call this before EmitStatement() to make sure that this
6281 expression can be used as a statement.
6283 * expression.cs (InvocationOrCast): New class; resolves to either
6284 an Invocation or a Cast.
6286 * statement.cs (StatementExpression): Call ResolveStatement() on
6287 the ExpressionStatement before emitting it.
6289 2003-07-21 Martin Baulig <martin@ximian.com>
6291 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
6292 `ref' and `out' attributes match; fixes #46220.
6293 (MemberAccess.ResolveMemberAccess): You can't reference a type
6294 through an expression; fixes #33180.
6295 (Indexers.GetIndexersForType): Don't return the indexers from
6296 interfaces the class implements; fixes #46502.
6298 2003-07-21 Martin Baulig <martin@ximian.com>
6300 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
6301 CS0661 checks; fixes bug #30442.
6303 2003-07-21 Martin Baulig <martin@ximian.com>
6305 * decl.cs (AdditionResult): Added `Error'.
6307 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
6309 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
6310 makes cs0031.cs actually work.
6312 2003-07-20 Martin Baulig <martin@ximian.com>
6314 * namespace.cs: Fixed that bug which caused a crash when compiling
6317 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6319 * typemanager.cs (LookupTypeReflection): Never expose types which
6320 are NotPublic, NestedPrivate, NestedAssembly, or
6321 NestedFamANDAssem. We used to return these, and later do a check
6322 that would report a meaningful error, but the problem is that we
6323 would not get the real match, if there was a name override.
6325 2003-07-18 Miguel de Icaza <miguel@ximian.com>
6327 * namespace.cs (Namespace, Name): Do not compute the namespace
6328 name dynamically, compute it in the constructor. This reduced
6329 memory usage by 1697 KB.
6331 * driver.cs: Use --pause to pause at the end.
6333 2003-07-17 Peter Williams <peter@newton.cx>
6335 * Makefile: Change the name of the test target so that it doesn't
6336 conflict with the recursive test target.
6338 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6340 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6341 AddressOf): Do not use EmitThis, that was wrong, use the actual
6344 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6346 * class.cs (MethodData.Define): While checking if a method is an
6347 interface implementation, improve the test: If we are not public
6348 (use new test here: use the computed MethodAttributes directly,
6349 instead of the parsed modifier flags) check if the `implementing'
6350 method comes from an interface or not.
6352 * pending.cs (VerifyPendingMethods): Slightly better error
6355 * makefile: add test target that does the mcs bootstrap.
6357 2003-07-16 Ravi Pratap <ravi@ximian.com>
6359 * interface.cs (Define): Do nothing here since there are no
6360 members to populate etc. Move the attribute emission out of here
6361 since this was just totally the wrong place to put it. Attribute
6362 application happens during the 'Emit' phase, not in the 'Define'
6365 (Emit): Add this method and move the attribute emission here
6367 * rootcontext.cs (EmitCode): Call the Emit method on interface
6370 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6372 * expression.cs (OverloadResolve): Report error only if Location
6373 is not 'Null' which means that there was a probe going on.
6375 2003-07-14 Martin Baulig <martin@ximian.com>
6377 * expression.cs (ConditionalLogicalOperator): New public class to
6378 implement user defined conditional logical operators.
6379 This is section 14.11.2 in the spec and bug #40505.
6381 2003-07-14 Martin Baulig <martin@ximian.com>
6383 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6385 2003-07-14 Martin Baulig <martin@ximian.com>
6387 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6389 * ecore.cs (IVariable.VerifyFixed): New interface method.
6391 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6392 operator, check whether the variable is actually fixed. Fixes bug
6393 #36055. Set a variable definitely assigned when taking its
6394 address as required by the spec.
6396 * statement.cs (LocalInfo.IsFixed): New field.
6397 (LocalInfo.MakePinned): Set `IsFixed' to true.
6399 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6401 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6402 for .ctors, ensure that we only ask for members declared in the
6403 attribute type (BindingFlags.DeclaredOnly).
6407 * expression.cs (Error_WrongNumArguments): Report error 1501
6408 correctly the way CSC does.
6410 2003-07-13 Martin Baulig <martin@ximian.com>
6412 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6413 lookup on the fully qualified name, to make things like "X.X" work
6414 where "X.X" is a fully qualified type name, but we also have a
6415 namespace "X" in the using list. Fixes #41975.
6417 2003-07-13 Martin Baulig <martin@ximian.com>
6419 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6420 function. If we're a CompoundAssign, we need to create an embedded
6421 CompoundAssign, not an embedded Assign.
6422 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6425 2003-07-13 Martin Baulig <martin@ximian.com>
6427 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6428 work to fix bug #46088.
6430 2003-07-13 Ravi Pratap <ravi@ximian.com>
6432 * class.cs (Operator.Emit): Do not emit attributes here - it is
6433 taken care of by the Method class that we delegate too. This takes
6436 2003-07-10 Martin Baulig <martin@ximian.com>
6438 * expression.cs (TypeOfVoid): New class.
6439 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6441 2003-07-10 Martin Baulig <martin@ximian.com>
6443 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6446 2003-07-10 Martin Baulig <martin@ximian.com>
6448 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6449 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6451 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6453 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6455 2003-07-10 Martin Baulig <martin@ximian.com>
6457 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6458 of decimal. Fixes #42850.
6460 NOTE: I also fixed the created byte blob, but this doesn't work on
6461 the MS runtime and csc never produces any byte blobs for decimal
6464 2003-07-10 Martin Baulig <martin@ximian.com>
6466 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6467 structs; fixes #32068.
6468 (Block.AddChildVariableNames): Fixed #44302.
6470 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6472 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6474 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6476 * attribute.cs: And this test is onger needed.
6478 2003-07-08 Martin Baulig <martin@ximian.com>
6480 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6481 inaccessible types. Fixes #36313.
6483 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6485 * namespace.cs (NamespaceEntry): Create implicit entries for all
6486 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6487 implicit entries for N1.N2 and N1.
6489 2003-07-08 Martin Baulig <martin@ximian.com>
6491 Rewrote the handling of namespaces to fix a lot of the issues
6492 wrt. `using' aliases etc.
6494 * namespace.cs (Namespace): Splitted this class into a
6495 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6497 * typemanager.cs (TypeManager.IsNamespace): Removed.
6498 (TypeManager.ComputeNamespaces): Only compute namespaces from
6499 loaded assemblies here, not the namespaces from the assembly we're
6500 currently compiling.
6502 2003-07-08 Martin Baulig <martin@ximian.com>
6504 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6506 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6508 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6511 I thought about the memory savings here, but LookupTypeReflection
6512 is used under already very constrained scenarios. Compiling
6513 corlib or mcs only exposes one hit, so it would not really reduce
6514 any memory consumption.
6516 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6518 * typemanager.cs: fixes bug #45889 by only adding public types from
6519 other assemblies to the list of known types.
6521 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6523 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6524 on the type we resolved.
6526 2003-07-05 Martin Baulig <martin@ximian.com>
6528 * pending.cs (PendingImplementation.ParentImplements): Don't
6529 create the proxy if the parent is abstract.
6531 * class.cs (TypeContainer.DefineIndexers): Process explicit
6532 interface implementations first. Fixes #37714.
6534 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6536 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6537 defined recursively; but since we modify the input parameters
6538 (left is set to `this' temporarily), we reset this value if the
6539 left_is_explicit is false, which gives the original semantics to
6542 * literal.cs (NullPointer): new class used to represent a null
6543 literal in a pointer context.
6545 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6546 type is a pointer, use a NullPointer object instead of a
6547 NullLiteral. Closes 43687
6549 (ExplicitConversion): Convert pointer values using
6550 the conv opcode to the proper type.
6552 * ecore.cs (New): change ValueTypeVariable property into a method,
6553 that returns whether the valuetype is suitable for being used.
6555 * expression.cs (Binary.DoNumericPromotions): Only return if we
6556 the int constant was a valid uint, and we can return both left and
6557 right as uints. If not, we continue processing, to trigger the
6558 type conversion. This fixes 39018.
6560 * statement.cs (Block.EmitMeta): During constant resolution, set
6561 the CurrentBlock property on the emitcontext, so that we resolve
6562 constants propertly.
6564 2003-07-02 Martin Baulig <martin@ximian.com>
6566 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6567 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6569 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6570 than emitting it here.
6572 * statement.cs: Fixed some more flow analysis bugs.
6574 2003-07-02 Martin Baulig <martin@ximian.com>
6576 * class.cs (MethodData.Define): When implementing interface
6577 methods, set Final unless we're Virtual.
6579 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6580 check work for interface methods.
6582 2003-07-01 Martin Baulig <martin@ximian.com>
6584 * ecore.cs (EmitContext.This): Replaced this property with a
6585 GetThis() method which takes a Location argument. This ensures
6586 that we get the correct error location for a CS0188.
6588 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6590 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6591 ImplicitStandardConversion.
6593 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6595 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6597 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6600 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6602 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6605 (MethodData.Define): Turn off initlocals for unsafe methods.
6607 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6609 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6610 complete; Fixes #37521.
6612 * delegate.cs: Use Modifiers.TypeAttr to compute the
6613 TypeAttributes, instead of rolling our own. This makes the flags
6614 correct for the delegates.
6616 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6618 * class.cs (Constructor.Define): Set the private flag for static
6619 constructors as well.
6621 * cs-parser.jay (statement_expression): Set the return value to
6622 null, to avoid a crash when we catch an error.
6624 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6626 * cs-parser.jay: Applied patch from Jackson that adds support for
6627 extern and unsafe modifiers to destructor declarations.
6629 * expression.cs: Report error 21 if the user is trying to index a
6632 * driver.cs: Add an error message, suggested by the bug report.
6634 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6635 if we do not have a ": this ()" constructor initializer. Fixes 45149
6637 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6639 * namespace.cs: Add some information to reduce FAQs.
6641 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6643 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6644 underlying enumeration types. Fixes #43915.
6646 * expression.cs: Treat ushort/short as legal values to be used in
6649 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6651 * delegate.cs: transfer custom attributes for paramenters from
6652 the delegate declaration to Invoke and BeginInvoke.
6654 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6656 * attribute.cs: handle custom marshalers and emit marshal info
6659 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6661 * makefile.gnu: Added anonymous.cs to the compiler sources.
6663 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6665 * iterators.cs: Change the name of the proxy class to include two
6668 * cs-parser.jay: Update grammar to include anonymous methods.
6670 * anonymous.cs: new file.
6672 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6674 * class.cs (Field.Define): Add missing test for pointers and
6677 2003-05-27 Ravi Pratap <ravi@ximian.com>
6679 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6680 we use the stobj opcode.
6682 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6683 since it wasn't the correct fix.
6685 It still is puzzling that we are required to use stobj for IntPtr
6686 which seems to be a ValueType.
6688 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6690 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6691 during regular simple name resolution. Now, the trick is that
6692 instead of returning for processing the simplename, we do a
6693 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6694 contextual lookup type). If a match is found, return that, if
6695 not, return for further composition.
6697 This fixes long-standing 30485.
6699 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6700 using the address to initialize an object, do an Stobj instead of
6701 using the regular Stelem.
6703 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6704 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6705 Because if we are a BaseIndexerAccess that value will be true.
6708 * statement.cs (GotoCase.Resolve): Return after reporting an
6709 error, do not attempt to continue.
6711 * expression.cs (PointerArithmetic.Emit): If our operand is a
6712 long, convert our constants to match the operand before
6713 multiplying. Convert to I type before adding. Fixes 43670.
6715 2003-05-14 Ravi Pratap <ravi@ximian.com>
6717 * enum.cs (ImplicitConversionExists) : Rename to
6718 ImplicitEnumConversionExists to remove ambiguity.
6720 * ecore.cs (NullCast): New type of cast expression class which
6721 basically is very similar to EmptyCast with the difference being
6722 it still is a constant since it is used only to cast a null to
6726 * convert.cs (ImplicitReferenceConversion): When casting a null
6727 literal, we return a NullCast.
6729 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6730 should be around anymore.
6732 The renaming (reported was slightly wrong). Corrections:
6734 ConvertImplicitStandard -> ImplicitConversionStandard
6735 ConvertExplicitStandard -> ExplicitConversionStandard
6737 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6738 before passing them in !
6740 * convert.cs (ImplicitConversionStandard): When comparing for
6741 equal expr and target types, ensure that expr is not a
6744 In general, we must not be checking (expr_type ==
6745 target_type) in the top level conversion methods
6746 (ImplicitConversion, ExplicitConversion etc). This checking is
6747 done in the methods that they delegate to.
6749 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6751 * convert.cs: Move Error_CannotConvertType,
6752 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6753 ImplicitNumericConversion, ImplicitConversionExists,
6754 ImplicitUserConversionExists, StandardConversionExists,
6755 FindMostEncompassedType, FindMostSpecificSource,
6756 FindMostSpecificTarget, ImplicitUserConversion,
6757 ExplicitUserConversion, GetConversionOperators,
6758 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6759 TryImplicitIntConversion, Error_CannotConvertImplicit,
6760 ConvertImplicitRequired, ConvertNumericExplicit,
6761 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6762 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6765 Perform the following renames:
6767 StandardConversionExists -> ImplicitStandardConversionExists
6768 ConvertImplicit -> ImplicitConversion
6769 ConvertImplicitStandard -> ImplicitStandardConversion
6770 TryImplicitIntConversion -> ImplicitIntConversion
6771 ConvertImplicitRequired -> ImplicitConversionRequired
6772 ConvertNumericExplicit -> ExplicitNumericConversion
6773 ConvertReferenceExplicit -> ExplicitReferenceConversion
6774 ConvertExplicit -> ExplicitConversion
6775 ConvertExplicitStandard -> ExplicitStandardConversion
6777 2003-05-19 Martin Baulig <martin@ximian.com>
6779 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6780 (TypeInfo): Added support for structs having structs as fields.
6782 * ecore.cs (FieldExpr): Implement IVariable.
6783 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6784 VariableInfo for the field.
6786 2003-05-18 Martin Baulig <martin@ximian.com>
6788 * expression.cs (This.DoResolve): Report a CS0027 if we're
6789 emitting a field initializer.
6791 2003-05-18 Martin Baulig <martin@ximian.com>
6793 * expression.cs (This.ResolveBase): New public function.
6794 (This.DoResolve): Check for CS0188.
6796 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6799 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6800 `instance_expression' to null if we don't have any non-static
6803 2003-05-18 Martin Baulig <martin@ximian.com>
6805 Reworked the way how local variables and parameters are handled by
6806 the flow analysis code.
6808 * statement.cs (TypeInfo, VariableMap): New public classes.
6809 (VariableInfo): New public class. This is now responsible for
6810 checking whether a variable has been assigned. It is used for
6811 parameters and local variables.
6812 (Block.EmitMeta): Take the InternalParameters as argument; compute
6813 the layout of the flow vectors here.
6814 (Block.LocalMap, Block.ParameterMap): New public properties.
6815 (FlowBranching): The .ctor doesn't get the InternalParameters
6816 anymore since Block.EmitMeta() now computes the layout of the flow
6818 (MyStructInfo): This class is now known as `StructInfo' and nested
6819 in `TypeInfo'; we don't access this directly anymore.
6821 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6822 property and removed IsAssigned(), IsFieldAssigned(),
6823 SetAssigned() and SetFieldAssigned(); we now call them on the
6824 VariableInfo so we don't need to duplicate this code everywhere.
6826 * expression.cs (ParameterReference): Added `Block block' argument
6828 (LocalVariableReference, ParameterReference, This): The new
6829 VariableInfo class is now responsible for all the definite
6832 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6833 IsParameterAssigned, SetParameterAssigned): Removed.
6835 2003-05-18 Martin Baulig <martin@ximian.com>
6837 * typemanager.cs (InitCoreTypes): Try calling
6838 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6839 the 3-args-version. Corlib now also needs our `void_type'.
6840 (GetMethod): Added overloaded version which takes an optional
6841 `bool report_errors' to allow lookups of optional methods.
6843 2003-05-12 Martin Baulig <martin@ximian.com>
6845 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6846 only used for locals and not for parameters.
6848 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6850 * support.cs (InternalParameters.ParameterType): Return the
6851 ExternalType of the parameter.
6853 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6856 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6858 * class.cs (MethodData.Define): Do not set the `newslot' on
6859 interface members, if they are also flagged as "override".
6861 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6862 better code for ++i and i++. This only works for static fields
6863 and local variables.
6865 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6866 want to pull the DeclSpace out of the builder_to_declspace instead
6867 of the TypeBuilder (like in TypeContainer.FindMembers).
6869 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6870 instead of LookupTypeContainer. Fixes the crash on .NET for
6871 looking up interface members.
6873 * const.cs: Create our own emit context during the Definition
6874 stage, so that constants are evaluated in the proper context, when
6875 a recursive definition happens.
6877 2003-05-11 Martin Baulig <martin@ximian.com>
6879 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6880 new block for a switch section.
6881 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6882 the adding/lookup in the switch block. Fixes #39828.
6884 2003-05-09 Miguel de Icaza <miguel@ximian.com>
6886 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
6887 functionality: I needed to convert the data after I had performed
6888 the add/sub operation into the operands type size.
6890 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
6891 pass the type for the box operation, otherwise the resulting
6892 object would have been of type object.
6894 (BoxedCast): Add constructor to specify the type to box as.
6896 2003-05-07 Miguel de Icaza <miguel@ximian.com>
6898 * iterators.cs: I was reusing the `count' variable inadvertently,
6899 take steps to not allow this to happen.
6901 2003-05-06 Miguel de Icaza <miguel@ximian.com>
6903 * attribute.cs (Attribute.Resolve): Params attributes are encoded
6904 by creating an array at the point where the params starts and
6905 putting all those arguments there, then adjusting the size of the
6908 2003-05-05 Miguel de Icaza <miguel@ximian.com>
6910 * expression.cs (New.AddressOf): Implement interface
6911 IMemoryLocation. This is used when the `new' operator is used in
6912 the context of an invocation to a method on a value type.
6914 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
6917 * namespace.cs: Also check the using aliases here.
6919 * driver.cs: Move the test for using validity after the types have
6920 been entered, so we do a single pass that also includes the using
6923 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
6924 in the regular case. CreateSiblingForFinally is doing extra
6927 * attribute.cs (GetAttributeArgumentExpression): Store the result
6928 on an out value, and use the return value to indicate failure
6929 instead of using null (which is a valid return for Constant.GetValue).
6931 * statement.cs: Perform the analysis flow for the increment
6932 portion after the statement, because this will be the real flow of
6933 execution. Fixes #42385
6935 * codegen.cs (EmitContext.EmitArgument,
6936 EmitContext.EmitStoreArgument): New helper functions when the
6937 RemapToProxy flag is set.
6939 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
6942 Add support for remapping parameters.
6944 * iterators.cs: Propagate parameter values; Store parameter
6945 values in the proxy classes.
6947 2003-05-04 Miguel de Icaza <miguel@ximian.com>
6949 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
6950 need a proxy reference; I do not know what I was thinking
6952 * cs-parser.jay (constructor_initializer): catch another error,
6953 and display nice message.
6955 (field_declaration): catch void field declaration
6956 to flag a better error.
6958 * class.cs (MemberBase.CheckBase): Report an error instead of a
6959 warning if a new protected member is declared in a struct.
6960 (Field.Define): catch the error of readonly/volatile.
6962 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
6964 (FieldExpr.AddressOf): ditto. Catch error where the address of a
6965 volatile variable is taken
6967 2003-05-02 Miguel de Icaza <miguel@ximian.com>
6969 * statement.cs (Fixed.Resolve): Report an error if we are not in
6972 2003-05-01 Miguel de Icaza <miguel@ximian.com>
6974 * typemanager.cs: reuse the code that handles type clashes for
6975 delegates and enumerations.
6977 * class.cs (Report28): Always report.
6979 * expression.cs (EncodeAsAttribute): Allow nulls here.
6981 2003-04-28 Miguel de Icaza <miguel@ximian.com>
6983 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
6984 the functionality for testing whether an expression is valid for
6985 an attribute here. Also handle the case of arrays of elements
6988 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
6989 encoding a linear array into an array of objects that are suitable
6990 to be passed to an CustomAttributeBuilder.
6992 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
6994 * ecore.cs: (FieldExpr): Handle field remapping here.
6996 * iteratators.cs: Pass the instance variable (if the method is an
6997 instance method) to the constructors, so we can access the field
6998 variables on the class.
7000 TODO: Test this with structs. I think the THIS variable on
7001 structs might have to be a pointer, and not a refenrece
7003 2003-04-27 Miguel de Icaza <miguel@ximian.com>
7005 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
7006 local variables to fields in a proxy class.
7008 * iterators.cs (PopulateProxy): Rename our internal fields to
7010 Create a <THIS> field if we are an instance method, so we can
7011 reference our parent container variables.
7012 (MapVariable): Called back from the EmitContext code to enter a
7013 new variable to field mapping into the proxy class (we just create
7017 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
7018 for using the remapped locals to fields.
7020 I placed the code here, because that gives the same semantics to
7021 local variables, and only changes the Emit code.
7023 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
7024 statements inside iterators.
7025 (VariableInfo): Add a FieldBuilder for the cases when we are
7026 remapping local variables to fields in a proxy class
7028 * ecore.cs (SimpleNameResolve): Avoid testing two times for
7029 current_block != null.
7031 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
7032 not cope with strings, as it has been moved to the
7033 TableSwitchEmit. Fixed bug in switch generation.
7035 * expression.cs (New.DoResolve): Provide more context for the user
7036 when reporting an error.
7038 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
7041 * expression.cs (MemberAccess.DoResolve): When we get a type back,
7042 check the permissions for it. Note than in a type-resolution
7043 context the check was already present in DeclSpace.ResolveType,
7044 but was missing from the MemberAccess.
7046 (ArrayCreation.CheckIndices): warn if the user has
7047 more nested levels of expressions, but there are no more
7048 dimensions specified. Avoids crash on bug 41906.
7050 2003-04-26 Miguel de Icaza <miguel@ximian.com>
7052 * statement.cs (Block): replace Implicit bool, for a generic
7054 New flag: `Unchecked'. This is used during the EmitMeta phase
7055 (which is out-of-line with the regular Resolve/Emit process for a
7056 statement, as this is done ahead of time, but still gets a chance
7057 to call constant resolve).
7059 (Block.Flags): new enum for adding a new flag.
7061 (Block.EmitMeta): track the state of unchecked.
7063 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
7064 to enable constant resolution to work there as well.
7066 2003-04-22 Miguel de Icaza <miguel@ximian.com>
7068 * typemanager.cs (ienumerable_type): Also look up
7069 System.Collections.IEnumerable.
7071 2003-04-21 Miguel de Icaza <miguel@ximian.com>
7073 TODO: Test more than one conditional per method.
7075 * class.cs (Indexer.Define): Report the location where the user is
7076 referencing the unsupported feature.
7078 (MethodData): Overload the use of `conditionals' to
7079 minimize the creation of needless ArrayLists. This saves roughly
7080 212kb on my machine.
7082 (Method): Implement the new IIteratorContainer interface.
7083 (Method.SetYields): Implement the method by setting the ModFlags
7084 to contain METHOD_YIELDS.
7086 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
7087 which just got set to null.
7089 * iterators.cs: New file.
7091 (Yield, YieldBreak): New statements.
7093 * statement.cs (Return.Resolve): Flag an error if we are used in
7096 * codegen.cs (InIterator): New flag set if the code is being
7097 compiled in an iterator method.
7099 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
7100 internal modifier, and we just use it to avoid adding extra
7101 fields, as this is seldom used.
7103 * cs-parser.jay: Add yield_statement (yield and yield break).
7105 * driver.cs: New flag -v2 to turn on version 2 features.
7107 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
7108 hashtable when v2 is enabled.
7110 2003-04-20 Miguel de Icaza <miguel@ximian.com>
7112 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
7113 there is already a namespace defined with this name.
7115 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
7116 people upgraded their corlibs.
7118 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
7119 always use fully qualified types, no need to use the compiler
7122 (TypeManager.IsNamespace): Use binarysearch.
7124 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
7125 AddDelegate): I did not quite use the new IsValid API properly: I
7126 have to pass the short-name and the fullname. I was passing only
7127 the basename instead of the fullname sometimes.
7129 (TypeContainer.DefineType): call NamespaceClash.
7131 * interface.cs (Interface.DefineType): use NamespaceClash before
7134 * delegate.cs (Delegate.DefineType): use NamespaceClash before
7137 * enum.cs: (Enum.DefineType): use NamespaceClash before
7140 * typemanager.cs (: 3-line patch that gives us some tasty 11%
7141 speed increase. First, use the negative_hits cache when we get a
7142 negative. Second, add the type with its full original name
7143 instead of the new . and + encoded name (reflection uses + to
7144 separate type from a nested type). Use LookupTypeReflection
7145 directly which bypasses the type->name hashtable (that we already
7146 know does not contain the type.
7148 * decl.cs (DeclSpace.ResolveTypeExpr): track the
7149 location/container type.
7151 * driver.cs: When passing utf8, use directly the UTF8Encoding.
7153 2003-04-19 Miguel de Icaza <miguel@ximian.com>
7155 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
7157 * delegate.cs (NewDelegate.Resolve): Test whether an instance
7158 method is being referenced in the method group from a static
7159 context, and report error 120 if so.
7161 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
7164 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
7165 is created, we create the A namespace).
7167 * cs-parser.jay: A namespace also introduces a DeclarationFound.
7170 2003-04-18 Miguel de Icaza <miguel@ximian.com>
7172 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
7173 invocation to ModuleBuilder.GetType with the same values will
7174 return a new type instance, so we need to cache its return
7177 * expression.cs (Binary.ResolveOperator): Only allow the compare
7178 operators on enums if they are of the same type.
7180 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
7181 types of ValueType on their own case. Before we were giving them
7182 the same treatment as objects.
7184 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
7185 fullname. Short name is used to compare against container name.
7186 Fullname is used to check against defined namespace names.
7188 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
7189 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
7191 (Method.CheckBase): Call parent.
7192 (MemberBase.CheckBase): Check for protected members on sealed
7194 (PropertyBase.CheckBase): Call parent.
7195 (Field.Define): Call parent.
7197 * report.cs: Negative error codes are now mapped to 8000 - code,
7198 so that the display is render more nicely.
7200 * typemanager.cs: Do not use try/catch, instead report a regular
7203 (GetPointerType, GetReferenceType): These methods provide
7204 mechanisms to obtain the T* and T& from a T. We had the code
7205 previously scattered around the code base, and it also used
7206 TypeManager.LookupType that would go through plenty of caches.
7207 This one goes directly to the type source.
7209 In some places we did the Type.GetType followed by
7210 ModuleBuilder.GetType, but not in others, so this unifies the
7213 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
7214 statements now that we have namespace information.
7216 * typemanager.cs (IsNamespace): New method, returns whether the
7217 string presented is a namespace or not.
7219 (ComputeNamespaces): New public entry point, computes the list of
7220 available namespaces, using the GetNamespaces API call in Mono, or
7221 the slower version in MS.NET.
7223 Now before we start the semantic analysis phase, we have a
7224 complete list of namespaces including everything that the user has
7227 Deleted old code to cache namespaces in .nsc files.
7229 2003-04-17 Miguel de Icaza <miguel@ximian.com>
7231 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
7232 class/struct location definition Location for the implicit
7233 constructor location.
7235 (Operator.Define): Use the location of the operator for the
7236 implicit Method definition.
7238 (Constructor.Emit): use the constructor location for the implicit
7239 base initializer constructor.
7241 * ecore.cs: Remove ITypeExpression. This interface is now gone,
7242 and the Expression class now contains two new methods:
7244 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
7245 isolate type lookup from the rest of the resolution process.
7247 Since we use Expressions to hold type definitions due to the way
7248 we parse the input we have historically overloaded Resolve to
7249 perform the Type lookups if a special flag is passed. Now this is
7250 eliminated and two methods take their place.
7252 The differences in the two methods between xStep and xTerminal is
7253 that xStep is involved in our current lookup system that uses
7254 SimpleNames to compose a name, while xTerminal is used just to
7255 catch the case where the simplename lookup failed.
7257 2003-04-16 Miguel de Icaza <miguel@ximian.com>
7259 * expression.cs (ResolveMemberAccess): Remove redundant code.
7260 TypeExpr expressions are always born fully resolved.
7262 * interface.cs (PopulateMethod): Do not lookup the types twice.
7263 We were doing it once during SemanticAnalysis and once during
7266 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
7267 in local variable type definitions, were being returned as a
7268 SimpleName (we decomposed everything into a string), that is
7269 because primary_expression was being used instead of a type in the
7270 grammar (reduce/reduce conflicts).
7272 The part that was wrong is that we converted the expression into a
7273 string (an oversimplification in one hand, compounded with primary
7274 expressions doing string concatenation).
7280 Would return "A.B.C[]" as a SimpleName. This stopped things like
7281 using clauses from working on this particular context. And a type
7282 was being matched directly against "A.B.C[]".
7284 We now use the correct approach, and allow for ComposedCast to be
7285 part of the unary expression. So the "A.B.C []" become a composed
7286 cast of "A.B.C" (as a nested group of MemberAccess with a
7287 SimpleName at the end) plus the rank composition "[]".
7291 2003-04-10 Miguel de Icaza <miguel@ximian.com>
7293 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
7294 for the access level checking.
7296 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
7297 `TypeContainer container', because I kept getting confused when I
7298 was debugging this code.
7300 * expression.cs (Indexers): Instead of tracking getters/setters,
7301 we now track them in parallel. We create one arraylist less, but
7302 most importantly it is possible now for the LValue code to find a
7303 matching get for a set.
7305 (IndexerAccess.DoResolveLValue): Update the code.
7306 GetIndexersForType has been modified already to extract all the
7307 indexers from a type. The code assumed it did not.
7309 Also make the code set the correct return type for the indexer.
7310 This was fixed a long time ago for properties, but was missing for
7311 indexers. It used to be void_type.
7313 (Binary.Emit): Test first for doubles instead of
7314 floats, as they are more common.
7316 (Binary.EmitBranchable): Use the .un version of the branch opcodes
7317 when dealing with floats and the <=, >= operators. This fixes bug
7320 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
7321 to load the array value by emitting a load on the foreach variable
7322 type. This was incorrect.
7324 We now emit the code to load an element using the the array
7325 variable type, and then we emit the conversion operator.
7329 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
7331 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7333 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7335 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7336 test for protection before we test for signatures.
7338 (MethodSignature.ToString): implement.
7340 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7341 to the case where we reduced into a LongConstant.
7343 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7344 depend on whether the information is acurrate, because the
7345 Microsoft runtime will always claim that the array type is public,
7346 regardless of the real state.
7348 If the type is a pointer, another problem happens: the type is
7349 reported as non-public in Microsoft.
7351 In both cases we have to call CheckAccessLevel recursively with
7352 the underlying type as the argument to be tested.
7354 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7356 * assign.cs (Assign.Emit): If we are dealing with a compound
7357 assignment expression, we should use the code path that stores the
7358 intermediate result in a temporary value. This fixes #40903.
7360 *expression.cs (Indirection.ToString): Provide ToString method for
7363 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7365 * class.cs: Null out fields holding references to Block objects so
7366 they can be garbage collected.
7368 * expression.cs (OverloadResolve): Remove unused local.
7370 2003-04-07 Martin Baulig <martin@ximian.com>
7372 * codegen.cs (EmitContext.CurrentFile): New public field.
7373 (EmitContext.Mark): Use the CurrentFile to check whether the
7374 location is in the correct file.
7375 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7377 2003-04-07 Martin Baulig <martin@ximian.com>
7379 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7381 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7382 location. [FIXME: The location argument which gets passed to this
7383 method is sometimes wrong!]
7385 2003-04-07 Nick Drochak <ndrochak@gol.com>
7387 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7389 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7391 * expression.cs (Indirection.EmitAssign): We were using the
7392 temporary, but returning immediately instead of continuing the
7395 2003-04-06 Martin Baulig <martin@ximian.com>
7397 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7398 if it's a nested child, but also deriving from the outer class.
7401 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7402 nested child, but also deriving from the outer class. See
7404 (FilterWithClosure): We may access private members of the outer
7405 class if we're a nested child and deriving from the outer class.
7406 (RealMemberLookup): Only set `closure_private_ok' if the
7407 `original_bf' contained BindingFlags.NonPublic.
7409 2003-04-05 Martin Baulig <martin@ximian.com>
7411 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
7413 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7415 * class.cs (Event.Define): Do not allow abstract events to have
7418 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7420 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7421 block in event declarations.
7423 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7424 value type, get its address.
7426 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7427 leaving a class on the stack instead of a boolean value (int
7428 0/1). Change the code so we compare against null, and then the
7429 result against zero.
7431 * class.cs (TypeContainer.GetClassBases): We were checking for the
7432 parent class being sealed too late.
7434 * expression.cs (Binary.Emit): For <= and >= when dealing with
7435 floating point values, use cgt.un and clt.un instead of cgt and
7438 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7440 * statement.cs: Apply the same optimization as MS: skip the
7441 GetEnumerator returning an IEnumerator, and use the one returning a
7442 CharEnumerator instead. This allows us to avoid the try-finally block
7445 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7447 * cs-parser.jay: Attributes cannot be applied to
7448 namespaces. Fixes #40473
7450 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7453 (Add*): check if the name is valid using the full name for constants,
7454 fields, properties and events.
7456 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7458 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7459 char constants to be part of the enumeration.
7461 * expression.cs (Conditional.DoResolve): Add support for operator
7462 true. Implements the missing functionality from 14.12
7464 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7465 operator true/false as required by the spec.
7467 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7468 implicit conversion to boolean.
7470 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7471 also one where the type implements `operator true'.
7473 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7474 get an expression that will invoke operator true based on an
7477 (GetConversionOperators): Removed the hack that called op_True
7480 (Expression.ResolveBoolean): Move this from Statement.
7482 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7484 * ecore.cs (FieldExpr): do not allow initialization of initonly
7485 fields on derived classes
7487 2003-03-13 Martin Baulig <martin@ximian.com>
7489 * statement.cs (Block.Emit): Call ig.BeginScope() and
7490 ig.EndScope() when compiling with debugging info; call
7491 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7493 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7495 * expression.cs (Indexers): Do not construct immediately, allow
7496 for new members to be appended as we go. Fixes 38143
7498 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7500 * expression.cs: save/restore context when resolving an unchecked
7503 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7505 * cfold.cs: Catch division by zero in modulus operator during
7508 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7510 * interface.cs (Interface.DefineMembers): Avoid defining members
7513 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7515 * driver.cs: handle the +/- options for -noconfig
7517 * statement.cs (Unckeched.Resolve): Also track the state of
7518 unchecked in the Resolve phase.
7520 2003-02-27 Martin Baulig <martin@ximian.com>
7522 * ecore.cs (Expression.MemberLookup): Don't create a
7523 MethodGroupExpr for something which is not a method. Fixes #38291.
7525 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7527 * class.cs (MemberBase.CheckParameters): Also check that the type
7528 is unmanaged if it is a pointer.
7530 * expression.cs (SizeOf.Resolve): Add location information.
7532 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7533 a managed type is declared.
7535 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7536 parameter modifiers as well. Fixes bug 38606
7538 * class.cs: Very sad. Am backing out the speed up changes
7539 introduced by the ArrayList -> Array in the TypeContainer, as they
7540 were not actually that much faster, and introduced a bug (no error
7541 reports on duplicated methods).
7543 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7544 source first, this will guarantee that we have a valid expression
7545 before calling in lower levels functions that will require a
7546 resolved object. Then use this original_source in the
7547 target.ResolveLValue instead of the original source that was
7550 Another change. Use target.Resolve instead of LValueResolve.
7551 Although we are resolving for LValues, we will let the Assign code
7552 take care of that (it will be called again from Resolve). This
7553 basically allows code like this:
7555 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7556 class Y { void A (X x) { x [0] += o; }
7558 The problem was that the indexer was trying to resolve for
7559 set_Item (idx, object o) and never finding one. The real set_Item
7560 was set_Item (idx, X). By delaying the process we get the right
7565 2003-02-23 Martin Baulig <martin@ximian.com>
7567 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7568 while calling DoEmit ().
7570 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7571 source files; if you use the #line directive inside a method, the
7572 compiler stops emitting line numbers for the debugger until it
7573 reaches the end of the method or another #line directive which
7574 restores the original file.
7576 2003-02-23 Martin Baulig <martin@ximian.com>
7578 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7580 2003-02-23 Martin Baulig <martin@ximian.com>
7582 * statement.cs (Block.AddChildVariableNames): We need to call this
7583 recursively, not just for our immediate children.
7585 2003-02-23 Martin Baulig <martin@ximian.com>
7587 * class.cs (Event.Define): Always make the field private, like csc does.
7589 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7590 actually work, fixes bug #37521.
7592 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7594 * delegate.cs: When creating the various temporary "Parameters"
7595 classes, make sure that we call the ComputeAndDefineParameterTypes
7596 on those new parameters (just like we do with the formal ones), to
7597 allow them to be resolved in the context of the DeclSpace.
7599 This fixes the bug that Dick observed in Bugzilla #38530.
7601 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7603 * expression.cs (ResolveMemberAccess): When resolving a constant,
7604 do not attempt to pull a constant if the value was not able to
7605 generate a valid constant.
7607 * const.cs (LookupConstantValue): Do not report more errors than required.
7609 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7611 * expression.cs: fixes bug #38328.
7613 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7615 * class.cs: Changed all the various members that can be part of a
7616 class from being an ArrayList to be an Array of the right type.
7617 During the DefineType type_list, interface_list, delegate_list and
7618 enum_list are turned into types, interfaces, delegates and enums
7621 And during the member population, indexer_list, event_list,
7622 constant_list, field_list, instance_constructor_list, method_list,
7623 operator_list and property_list are turned into their real arrays.
7625 Although we could probably perform this operation earlier, for
7626 good error reporting we need to keep the lists and remove the
7627 lists for longer than required.
7629 This optimization was triggered by Paolo profiling the compiler
7630 speed on the output of `gen-sample-program.pl' perl script.
7632 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7633 not crash in methods like MemberLookupFailed that use this field.
7635 This problem arises when the compiler fails to resolve a type
7636 during interface type definition for example.
7638 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7640 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7641 inherit from System.Object, so we have to stop at null, not only
7642 when reaching System.Object.
7644 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7646 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7647 DeclaredOnly because the parent indexer might have had a different
7648 name, but did not loop until the top of the hierarchy was reached.
7650 The problem this one fixes is 35492: when a class implemented an
7651 indexer from an interface, we were getting the interface method
7652 (which was abstract) and we were flagging an error (can not invoke
7655 This also keeps bug 33089 functioning, and test-148 functioning.
7657 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7658 out if a method is special is to see if it is declared in a
7659 property or event, or whether it is one of the predefined operator
7660 names. This should fix correctly #36804.
7662 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7664 The goal here is to remove the dependency on EmptyCast.Peel ().
7665 Killing it completely.
7667 The problem is that currently in a number of places where
7668 constants are expected, we have to "probe" for an EmptyCast, and
7669 Peel, which is not the correct thing to do, as this will be
7670 repetitive and will likely lead to errors.
7672 The idea is to remove any EmptyCasts that are used in casts that
7673 can be reduced to constants, so we only have to cope with
7676 This bug hunt was triggered by Bug 37363 and the desire to remove
7677 the duplicate pattern where we were "peeling" emptycasts to check
7678 whether they were constants. Now constants will always be
7681 * ecore.cs: Use an enumconstant here instead of wrapping with
7684 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7685 throwing me off. By handling this we can get rid of a few hacks.
7687 * statement.cs (Switch): Removed Peel() code.
7689 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7691 * class.cs: Location information for error 508
7693 * expression.cs (New.DoResolve): Add a guard against double
7694 resolution of an expression.
7696 The New DoResolve might be called twice when initializing field
7697 expressions (see EmitFieldInitializers, the call to
7698 GetInitializerExpression will perform a resolve on the expression,
7699 and later the assign will trigger another resolution
7701 This leads to bugs (#37014)
7703 * delegate.cs: The signature for EndInvoke should contain any ref
7704 or out parameters as well. We were not doing this in the past.
7706 * class.cs (Field.Define): Do not overwrite the type definition
7707 inside the `volatile' group. Turns out that volatile enumerations
7708 were changing the type here to perform a validity test, which
7711 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7713 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7714 and structs, we do not want to load the instance variable
7716 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7717 enum_type has to be handled like an object reference (implicit
7718 conversions exists from this to object), but the regular IsClass
7719 and IsValueType tests will never return true for this one.
7721 Also we use TypeManager.IsValueType instead of type.IsValueType,
7722 just for consistency with the rest of the code (this is only
7723 needed if we ever use the construct exposed by test-180.cs inside
7724 corlib, which we dont today).
7726 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7728 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7731 2003-02-09 Martin Baulig <martin@ximian.com>
7733 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7734 (Namespace.DefineNamespaces): New static public method; this is
7735 called when we're compiling with debugging to add all namespaces
7738 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7739 pass it to the Namespace's .ctor.
7741 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7742 and MethodBase arguments; pass the namespace ID to the symwriter;
7743 pass the MethodBase instead of the token to the symwriter.
7744 (SymbolWriter.DefineNamespace): New method to add a namespace to
7747 2003-02-09 Martin Baulig <martin@ximian.com>
7749 * symbolwriter.cs: New file. This is a wrapper around
7750 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7751 methods here in near future.
7753 2003-02-09 Martin Baulig <martin@ximian.com>
7755 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7756 ILGenerator.MarkSequencePoint() which are actually used by the
7759 2003-02-09 Martin Baulig <martin@ximian.com>
7761 * location.cs (SourceFile): New public sealed class. This
7762 contains the name and an index which is used in the location's token.
7763 (Location): Reserve an appropriate number of bits in the token for
7764 the source file instead of walking over that list, this gives us a
7765 really huge performance improvement when compiling with debugging.
7767 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7768 `SourceFile' argument instead of a string.
7769 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7770 but don't parse/tokenize here, we need to generate the list of all
7771 source files before we do that.
7772 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7775 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7776 instead of a string.
7778 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7781 2003-02-09 Martin Baulig <martin@ximian.com>
7783 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7784 filename on `#line default'.
7786 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7788 * statement.cs: don't clear the pinned var when the fixed statement
7789 returns from the method (fixes bug#37752).
7791 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7793 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7796 2003-02-07 Martin Baulig <martin@ximian.com>
7798 * driver.cs: Removed the `--debug-args' command line argument.
7800 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7801 automatically by the AsssemblyBuilder.
7802 (CodeGen.InitializeSymbolWriter): We don't need to call any
7803 initialization function on the symbol writer anymore. This method
7804 doesn't take any arguments.
7806 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7808 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7809 from referenced assemblies as well.
7811 2003-02-02 Martin Baulig <martin@ximian.com>
7813 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7815 2003-02-02 Martin Baulig <martin@ximian.com>
7817 * class.cs (Constructor.Emit): Open the symbol writer before
7818 emitting the constructor initializer.
7819 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7820 single-stepping through constructor initializers.
7822 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7824 * class.cs: Handle error 549: do not allow virtual methods in
7827 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7829 * decl.cs: Check access levels when resolving types
7831 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7833 * statement.cs: Add parameters and locals set in catch blocks that might
7834 return to set vector
7836 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7838 * class.cs (Operator): Set the SpecialName flags for operators.
7840 * expression.cs (Invocation.DoResolve): Only block calls to
7841 accessors and operators on SpecialName methods.
7843 (Cast.TryReduce): Handle conversions from char constants.
7846 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7848 * statement.cs: small memory and time optimization in FlowBranching.
7850 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7852 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7853 problem that the last fix but in the other sid (Set).
7855 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7856 access when there is no indexer in the hierarchy.
7858 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
7860 * class.cs: Combine some if statements.
7862 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7864 * driver.cs: fixed bug #37187.
7866 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
7868 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
7869 any indexer, it's needed to build a list with all the indexers in the
7870 hierarchy (AllGetters), else we have problems. Fixes #35653.
7872 2003-01-23 Miguel de Icaza <miguel@ximian.com>
7874 * class.cs (MethodData.Define): It is wrong for an interface
7875 implementation to be static in both cases: explicit and implicit.
7876 We were only handling this in one case.
7878 Improve the if situation there to not have negations.
7880 * class.cs (Field.Define): Turns out that we do not need to check
7881 the unsafe bit on field definition, only on usage. Remove the test.
7883 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7885 * driver.cs: use assembly.Location instead of Codebase (the latest
7886 patch made mcs fail when using MS assemblies).
7888 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
7890 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
7891 get the path to *corlib.dll.
7893 2003-01-21 Nick Drochak <ndrochak@gol.com>
7897 * typemanager.cs: Remove compiler warnings
7899 2003-01-20 Duncan Mak <duncan@ximian.com>
7901 * AssemblyInfo.cs: Bump the version number to 0.19.
7903 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7905 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
7907 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
7909 * class.cs (Constructor::Emit): Emit debugging info for constructors.
7911 2003-01-17 Miguel de Icaza <miguel@ximian.com>
7913 * cs-parser.jay: Small fix: we were not comparing the constructor
7914 name correctly. Thanks to Zoltan for the initial pointer.
7916 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
7918 * cs-tokenizer.cs: Set file name when specified with #line
7920 2003-01-15 Miguel de Icaza <miguel@ximian.com>
7922 * cs-parser.jay: Only perform the constructor checks here if we
7923 are named like the class; This will help provider a better
7924 error. The constructor path is taken when a type definition is
7925 not found, but most likely the user forgot to add the type, so
7926 report that rather than the constructor error.
7928 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
7930 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
7933 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7935 * cs-parser.jay: Add cleanup call.
7937 2003-01-13 Duncan Mak <duncan@ximian.com>
7939 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
7940 consistent with other methods.
7942 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7944 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
7946 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
7948 * attribute.cs: only set GuidAttr to true when we have a
7951 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7955 * typemanager.cs: fixes to allow mcs compile corlib with the new
7956 Type.IsSubclassOf fix.
7958 2003-01-08 Miguel de Icaza <miguel@ximian.com>
7960 * expression.cs (LocalVariableReference.DoResolve): Classify a
7961 constant as a value, not as a variable. Also, set the type for
7964 * cs-parser.jay (fixed_statement): take a type instead of a
7965 pointer_type, so we can produce a better error message later.
7967 * statement.cs (Fixed.Resolve): Flag types that are not pointers
7970 (For.DoEmit): Make inifinite loops have a
7971 non-conditional branch back.
7973 (Fixed.DoEmit): First populate the pinned variables, then emit the
7974 statement, then clear the variables. Before I was emitting the
7975 code once for each fixed piece.
7978 2003-01-08 Martin Baulig <martin@ximian.com>
7980 * statement.cs (FlowBranching.MergeChild): A break in a
7981 SWITCH_SECTION does not leave a loop. Fixes #36155.
7983 2003-01-08 Martin Baulig <martin@ximian.com>
7985 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
7986 lives in the same number space than `param_map'. Fixes #36154.
7988 2003-01-07 Miguel de Icaza <miguel@ximian.com>
7990 * cs-parser.jay (constructor_declaration): Set the
7991 Constructor.ModFlags before probing for it. This makes the
7992 compiler report 514, 515 and 132 (the code was there, but got
7995 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
7996 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
7997 (GotoCase.Resolve): Set `Returns' to ALWAYS.
7999 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
8001 * enum.cs: create the enum static fields using the enum type.
8003 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
8005 * class.cs: don't try to create the ParamBuilder for the return
8006 type if it's not needed (and handle it breaking for the ms runtime
8009 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
8011 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
8013 2002-12-29 Miguel de Icaza <miguel@ximian.com>
8015 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
8016 the command. This showed up while compiling the JANET source
8017 code, which used \r as its only newline separator.
8019 2002-12-28 Miguel de Icaza <miguel@ximian.com>
8021 * class.cs (Method.Define): If we are an operator (because it
8022 reuses our code), then set the SpecialName and HideBySig. #36128
8024 2002-12-22 Miguel de Icaza <miguel@ximian.com>
8026 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
8027 exception, report error 120 `object reference required'.
8029 * driver.cs: Add --pause option, used during to measure the size
8030 of the process as it goes with --timestamp.
8032 * expression.cs (Invocation.DoResolve): Do not allow methods with
8033 SpecialName to be invoked.
8035 2002-12-21 Miguel de Icaza <miguel@ximian.com>
8037 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
8038 number before adding it.
8040 2002-12-21 Ravi Pratap <ravi@ximian.com>
8042 * ecore.cs (StandardImplicitConversion): When in an unsafe
8043 context, we allow conversion between void * to any other pointer
8044 type. This fixes bug #35973.
8046 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
8048 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
8049 is not thrown when extensionless outputs are used
8051 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8053 * rootcontext.cs: fixed compilation of corlib.
8055 2002-12-19 Miguel de Icaza <miguel@ximian.com>
8057 * attribute.cs (Attributes.Contains): Add new method.
8059 * class.cs (MethodCore.LabelParameters): if the parameter is an
8060 `out' parameter, check that no attribute `[In]' has been passed.
8062 * enum.cs: Handle the `value__' name in an enumeration.
8064 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
8066 * decl.cs: Added special case to allow overrides on "protected
8069 2002-12-18 Ravi Pratap <ravi@ximian.com>
8071 * attribute.cs (Attributes.AddAttributeSection): Rename to this
8072 since it makes much more sense.
8074 (Attributes.ctor): Don't require a Location parameter.
8076 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
8078 * attribute.cs (ApplyAttributes): Remove extra Location parameters
8079 since we already have that information per attribute.
8081 * everywhere : make appropriate changes.
8083 * class.cs (LabelParameters): Write the code which actually
8084 applies attributes to the return type. We can't do this on the MS
8085 .NET runtime so we flag a warning in the case an exception is
8088 2002-12-18 Miguel de Icaza <miguel@ximian.com>
8090 * const.cs: Handle implicit null conversions here too.
8092 2002-12-17 Ravi Pratap <ravi@ximian.com>
8094 * class.cs (MethodCore.LabelParameters): Remove the extra
8095 Type [] parameter since it is completely unnecessary. Instead
8096 pass in the method's attributes so that we can extract
8097 the "return" attribute.
8099 2002-12-17 Miguel de Icaza <miguel@ximian.com>
8101 * cs-parser.jay (parse): Use Report.Error to flag errors instead
8102 of ignoring it and letting the compile continue.
8104 * typemanager.cs (ChangeType): use an extra argument to return an
8105 error condition instead of throwing an exception.
8107 2002-12-15 Miguel de Icaza <miguel@ximian.com>
8109 * expression.cs (Unary.TryReduce): mimic the code for the regular
8110 code path. Perform an implicit cast in the cases where we can
8111 implicitly convert to one of the integral types, and then reduce
8112 based on that constant. This fixes bug #35483.
8114 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8116 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
8118 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8120 * namespace.cs: fixed bug #35489.
8122 2002-12-12 Miguel de Icaza <miguel@ximian.com>
8124 * class.cs: Remove some dead code.
8126 * cs-parser.jay: Estimate the number of methods needed
8127 (RootContext.MethodCount);
8129 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
8130 numbers instead of StringBuilders.
8132 * support.cs (PtrHashtable): Add constructor with initial size;
8133 We can now reduce reallocations of the method table.
8135 2002-12-10 Ravi Pratap <ravi@ximian.com>
8137 * attribute.cs (ApplyAttributes): Keep track of the emitted
8138 attributes on a per-target basis. This fixes bug #35413.
8140 2002-12-10 Miguel de Icaza <miguel@ximian.com>
8142 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
8143 default to the Windows 1252 encoding.
8145 (UnixParseOption): Support version, thanks to Alp for the missing
8148 * AssemblyInfo.cs: Add nice assembly information.
8150 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
8153 * cs-parser.jay: Allow a trailing comma before the close bracked
8154 in the attribute_section production.
8156 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
8157 address of the instance was being taken, I will take this out,
8158 because we take the address of the object immediately here.
8160 2002-12-09 Ravi Pratap <ravi@ximian.com>
8162 * typemanager.cs (AreMultipleAllowed): Take care of the most
8163 obvious case where attribute type is not in the current assembly -
8166 2002-12-08 Miguel de Icaza <miguel@ximian.com>
8168 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
8169 definitions, instead of doing that afterwards.
8171 Also we use a nice little hack, depending on the constructor, we
8172 know if we are a "composed" name or a simple name. Hence, we
8173 avoid the IndexOf test, and we avoid
8175 * codegen.cs: Add code to assist in a bug reporter to track down
8176 the source of a compiler crash.
8178 2002-12-07 Ravi Pratap <ravi@ximian.com>
8180 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
8181 types have been emitted for a given element and flag an error
8182 if something which does not have AllowMultiple set is used more
8185 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
8186 attribute types and their corresponding AllowMultiple properties
8188 (AreMultipleAllowed): Check the property for a given type.
8190 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
8191 property in the case we have a TypeContainer.
8193 (Attributes.AddAttribute): Detect duplicates and just skip on
8194 adding them. This trivial fix catches a pretty gross error in our
8195 attribute emission - global attributes were being emitted twice!
8197 Bugzilla bug #33187 is now fixed.
8199 2002-12-06 Miguel de Icaza <miguel@ximian.com>
8201 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
8204 * expression.cs (Binary.ResolveOperator): I can only use the
8205 Concat (string, string, string) and Concat (string, string,
8206 string, string) if the child is actually a concatenation of
8209 2002-12-04 Miguel de Icaza <miguel@ximian.com>
8211 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
8212 context where we need a 2-character lookahead.
8214 * pending.cs (PendingImplementation): Rework so we can keep track
8215 of interface types all the time, and flag those which were
8216 implemented by parents as optional.
8218 2002-12-03 Miguel de Icaza <miguel@ximian.com>
8220 * expression.cs (Binary.ResolveOperator): Use
8221 String.Concat(string,string,string) or
8222 String.Concat(string,string,string,string) when possible.
8224 * typemanager: More helper methods.
8227 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
8229 * pending.cs: remove the bogus return from GetMissingInterfaces()
8230 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
8232 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8234 * namespace.cs: avoid duplicated 'using xxx' being added to
8235 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
8236 when we get more than one 'using' statement for the same namespace.
8237 Report a CS0105 warning for it.
8239 2002-11-30 Miguel de Icaza <miguel@ximian.com>
8241 * cs-tokenizer.cs (consume_identifier): use read directly, instead
8242 of calling getChar/putback, uses internal knowledge of it.
8244 (xtoken): Reorder tokenizer so most common patterns are checked
8245 first. This reduces the compilation time in another 5% (from 8.11s
8246 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
8248 The parsing time is 22% of the compilation in mcs, and from that
8249 64% is spent on the tokenization process.
8251 I tried using a binary search for keywords, but this is slower
8252 than the hashtable. Another option would be to do a couple of
8255 * Not use a StringBuilder, instead use an array of chars,
8256 with a set value. Notice that this way we could catch
8257 the 645 error without having to do it *afterwards*.
8259 * We could write a hand-parser to avoid the hashtable
8260 compares altogether.
8262 The identifier consumption process takes 37% of the tokenization
8263 time. Another 15% is spent on is_number. 56% of the time spent
8264 on is_number is spent on Int64.Parse:
8266 * We could probably choose based on the string length to
8267 use Int32.Parse or Int64.Parse and avoid all the 64-bit
8270 Another 3% is spend on wrapping `xtoken' in the `token' function.
8272 Handle 0xa0 as whitespace (#34752)
8274 2002-11-26 Miguel de Icaza <miguel@ximian.com>
8276 * typemanager.cs (IsCLRType): New routine to tell whether a type
8277 is one of the builtin types.
8279 Maybe it needs to use TypeCodes to be faster. Maybe we could use
8280 typecode in more places instead of doing pointer comparissions.
8281 We could leverage some knowledge about the way the typecodes are
8284 New code to cache namespaces in assemblies, it is currently not
8285 invoked, to be used soon.
8287 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
8289 * expression.cs (Binary.ResolveOperator): specially handle
8290 strings, and do not perform user-defined operator overloading for
8293 2002-11-24 Miguel de Icaza <miguel@ximian.com>
8295 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
8296 internalcall as it is a pretty simple operation; Avoid whenever
8297 possible to call Char.IsLetter.
8299 (consume_identifier): Cut by half the number of
8300 hashtable calls by merging the is_keyword and GetKeyword behavior.
8302 Do not short-circuit, because if we do, we
8303 report errors (ie, #if false && true would produce an invalid
8307 2002-11-24 Martin Baulig <martin@ximian.com>
8309 * expression.cs (Cast.TryReduce): If we're in checked syntax,
8310 check constant ranges and report a CS0221. Fixes #33186.
8312 2002-11-24 Martin Baulig <martin@ximian.com>
8314 * cs-parser.jay: Make this work for uninitialized variable
8315 declarations in the `for' initializer. Fixes #32416.
8317 2002-11-24 Martin Baulig <martin@ximian.com>
8319 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
8320 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
8322 2002-11-24 Martin Baulig <martin@ximian.com>
8324 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
8325 argument; if true, we also check for user-defined conversions.
8326 This is only needed if both arguments are of a user-defined type.
8327 Fixes #30443, added test-175.cs.
8328 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
8330 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
8332 2002-11-24 Martin Baulig <martin@ximian.com>
8334 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8335 function to get the store opcode.
8336 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8337 only emit the Ldelema if the store opcode is Stobj. You must run
8338 both test-34 and test-167 to test this. Fixes #34529.
8340 2002-11-23 Martin Baulig <martin@ximian.com>
8342 * ecore.cs (Expression.MemberLookup): Added additional
8343 `qualifier_type' argument which is used when we're being called
8344 from MemberAccess.DoResolve() and null if we're called from a
8346 (Expression.MemberLookupFailed): New method to report errors; this
8347 does the CS1540 check and reports the correct error message.
8349 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8350 argument for the CS1540 check and redone the way how we're dealing
8351 with private members. See the comment in the source code for details.
8352 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8353 `closure_start_type' to `closure_qualifier_type' and check whether
8354 it's not null. It was not this filter being broken, it was just
8355 being called with the wrong arguments.
8357 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8358 and pass it the correct `qualifier_type'; this also does the error
8361 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8363 * expression.cs (Invocation.EmitParams): If the we are dealing
8364 with a non-built-in value type, load its address as well.
8366 (ArrayCreation): Use a a pretty constant instead
8367 of the hardcoded value 2. Use 6 instead of 2 for the number of
8368 static initializers.
8370 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8371 because they are not really value types, just glorified integers.
8373 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8375 * ecore.cs: Remove redundant code for enumerations, make them use
8376 the same code path as everything else, fixes the casting issue
8377 with enumerations in Windows.Forms.
8379 * attribute.cs: Do only cast to string if it is a string, the
8380 validation happens later.
8382 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8383 people upgrade their corlibs.
8385 * ecore.cs: Oops, enumerations were not following the entire code path
8387 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8389 * typemanager.cs (FilterWithClosure): Commented out the test for
8390 1540 in typemanager.cs, as it has problems when accessing
8391 protected methods from a parent class (see test-174.cs).
8393 * attribute.cs (Attribute.ValidateGuid): new method.
8394 (Attribute.Resolve): Use above.
8396 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8398 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8400 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8401 handling for enumerations, as we only needed the TypeContainer
8402 functionality to begin with (this is required for the fix below to
8403 work for enums that reference constants in a container class for
8406 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8408 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8409 a valid TypeBuilder to perform lookups on.o
8411 * class.cs (InheritableMemberSignatureCompare): Use true in the
8412 call to GetGetMethod and GetSetMethod, because we are comparing
8413 the signature, and we need to get the methods *even* if they are
8416 (PropertyBase.CheckBase): ditto.
8418 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8419 GotoCase.Resolve): Use Peel on EmpytCasts.
8421 * ecore.cs (EmptyCast): drop child, add Peel method.
8423 2002-11-17 Martin Baulig <martin@ximian.com>
8425 * ecore.cs (EmptyCast.Child): New public property.
8427 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8428 label resolved to an EmptyCast. Fixes #34162.
8429 (GotoCase.Resolve): Likewise.
8430 (Block.EmitMeta): Likewise.
8432 2002-11-17 Martin Baulig <martin@ximian.com>
8434 * expression.cs (Invocation.BetterConversion): Prefer int over
8435 uint; short over ushort; long over ulong for integer literals.
8436 Use ImplicitConversionExists instead of StandardConversionExists
8437 since we also need to check for user-defined implicit conversions.
8438 Fixes #34165. Added test-173.cs.
8440 2002-11-16 Martin Baulig <martin@ximian.com>
8442 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8443 with the `true' and `false' literals. Fixes #33151.
8445 2002-11-16 Martin Baulig <martin@ximian.com>
8447 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8448 October 22nd; don't do the cs1540 check for static members.
8450 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8451 now using our own filter here and doing the cs1540 check again.
8453 2002-11-16 Martin Baulig <martin@ximian.com>
8455 * support.cs (InternalParameters): Don't crash if we don't have
8456 any fixed parameters. Fixes #33532.
8458 2002-11-16 Martin Baulig <martin@ximian.com>
8460 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8461 when looking up static methods to make this work on Windows.
8464 2002-11-16 Martin Baulig <martin@ximian.com>
8466 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8467 a setter rather than using PropertyInfo.CanWrite.
8469 2002-11-15 Nick Drochak <ndrochak@gol.com>
8471 * class.cs: Allow acces to block member by subclasses. Fixes build
8474 2002-11-14 Martin Baulig <martin@ximian.com>
8476 * class.cs (Constructor.Emit): Added the extern/block check.
8479 2002-11-14 Martin Baulig <martin@ximian.com>
8481 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8482 iteration while looking for indexers, this is needed because the
8483 indexer may have a different name in our base classes. Fixed the
8484 error reporting (no indexers at all, not get accessor, no
8485 overloaded match). Fixes bug #33089.
8486 (IndexerAccess.DoResolveLValue): Likewise.
8488 2002-11-14 Martin Baulig <martin@ximian.com>
8490 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8491 indexers. Fixes the first part of bug #33089.
8492 (MethodSignature.InheritableMemberSignatureCompare): Added support
8495 2002-11-13 Ravi Pratap <ravi@ximian.com>
8497 * attribute.cs (Attribute.Resolve): Catch the
8498 NullReferenceException and report it since it isn't supposed to
8501 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8503 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8504 LogicalOr and LogicalAnd that can benefit from recursively
8505 handling EmitBranchable. The code now should be nice for Paolo.
8507 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8509 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8510 the Type lookups, as we perform quite a number of lookups on
8511 non-Types. This can be removed once we can deterministically tell
8512 whether we have a type or a namespace in advance.
8514 But this might require special hacks from our corlib.
8518 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8519 and double which avoids a conversion from an integer to a double.
8521 * expression.cs: tiny optimization, avoid calling IsConstant,
8522 because it effectively performs the lookup twice.
8524 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8526 But a bogus return here to keep the semantics of the old code
8527 until the Mono runtime is fixed.
8529 * pending.cs (GetMissingInterfaces): New method used to remove all
8530 the interfaces that are already implemented by our parent
8531 classes from the list of pending methods.
8533 * interface.cs: Add checks for calls after ResolveTypeExpr.
8535 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8537 * class.cs (Class.Emit): Report warning 67: event not used if the
8538 warning level is beyond 3.
8540 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8541 being a NullLiteral.
8543 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8546 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8547 path that might fail if a type can not be resolved.
8549 * expression.cs (Binary.Emit): Emit unsigned versions of the
8552 * driver.cs: use error 5.
8554 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8556 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8558 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8560 * cs-parser.jay (switch_section): A beautiful patch from Martin
8561 Baulig that fixed 33094.
8563 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8565 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8566 Check whether the base is abstract and report an error if so.
8568 * expression.cs (IndexerAccess.DoResolveLValue,
8569 IndexerAccess.DoResolve): ditto.
8571 (Invocation.DoResolve): ditto.
8573 (Invocation.FullMethodDesc): Improve the report string.
8575 * statement.cs (Block): Eliminate IsVariableDefined as it is
8576 basically just a wrapper for GetVariableInfo.
8578 * ecore.cs (SimpleName): Use new
8580 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8581 type, as we return the actual parameter ref/unref state on a
8584 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8586 * support.cs: Return proper flags REF/OUT fixing the previous
8589 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8590 not used to mean `ref' but `ref or out' in ParameterReference
8592 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8593 full type signature instead of calling TypeManger.CSharpName
8596 * support.cs (InternalParameters.ParameterDesc): Do not compare
8597 directly to the modflags, because REF/OUT will actually be bitsets
8600 * delegate.cs (VerifyMethod): Check also the modifiers.
8602 * cs-tokenizer.cs: Fix bug where floating point values with an
8603 exponent where a sign was missing was ignored.
8605 * driver.cs: Allow multiple assemblies to be specified in a single
8608 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8610 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8611 because identifiers after a parenthesis would end up in this kind
8612 of production, and we needed to desamiguate it for having casts
8615 (UserDefinedType *) xxx
8617 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8619 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8620 we should set on the Bindingflags.NonPublic, but not turn on
8621 private_ok. private_ok controls whether a Private member is
8622 returned (this is chekced on the filter routine), while the
8623 BindingFlags.NonPublic just controls whether private/protected
8624 will be allowed. This fixes the problem part of the problem of
8625 private properties being allowed to be used in derived classes.
8627 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8628 so we can call the children DoResolveLValue method (this will
8629 properly signal errors on lvalue assignments to base properties)
8631 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8632 getter are null, and we have a property info, we know that this
8633 happened because the lookup failed, so we report an error 122 for
8634 protection level violation.
8636 We also silently return if setter and getter are null in the
8637 resolve functions, this condition only happens if we have flagged
8638 the error before. This is the other half of the problem.
8640 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8641 not have accessibility information, that is why we were returning
8642 true in the filter function in typemanager.cs.
8644 To properly report 122 (property is inaccessible because of its
8645 protection level) correctly, we report this error in ResolveAccess
8646 by failing if both the setter and the getter are lacking (ie, the
8649 DoResolve and DoLResolve have been modified to check for both
8650 setter/getter being null and returning silently, the reason being
8651 that I did not want to put the knowledge about this error in upper
8654 int old = Report.Errors;
8655 x = new PropertyExpr (...);
8656 if (old != Report.Errors)
8661 So the property expr is returned, but it is invalid, so the error
8662 will be flagged during the resolve process.
8664 * class.cs: Remove InheritablePropertySignatureCompare from the
8665 class, as we no longer depend on the property signature to compute
8666 whether it is possible to implement a method or not.
8668 The reason is that calling PropertyInfo.GetGetMethod will return
8669 null (in .NET, in Mono it works, and we should change this), in
8670 cases where the Get Method does not exist in that particular
8675 class X { public virtual int A { get { return 1; } } }
8677 class Z : Y { public override int A { get { return 2; } } }
8679 Would fail in Z because the parent (Y) would not have the property
8680 defined. So we avoid this completely now (because the alternative
8681 fix was ugly and slow), and we now depend exclusively on the
8684 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8685 reference method, instead of using the property.
8687 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8688 routines are gone now.
8690 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8691 names, they were incorrectly named.
8693 * cs-tokenizer.cs: Return are more gentle token on failure.
8695 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8696 had an out-of-sync index variable, which caused it to remove from
8697 the list of pending methods the wrong method sometimes.
8699 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8701 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8702 CanWrite, because those refer to this particular instance of the
8703 property, and do not take into account the fact that we can
8704 override single members of a property.
8706 Constructor requires an EmitContext. The resolution process does
8707 not happen here, but we need to compute the accessors before,
8708 because the resolution does not always happen for properties.
8710 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8711 subclass, before we did not update this flag, but we did update
8714 (GetAccessors): Drop this routine, as it did not work in the
8715 presence of partially overwritten set/get methods.
8717 Notice that this broke the cs1540 detection, but that will require
8720 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8724 * driver.cs: issue a warning instead of an error if we don't support
8725 debugging for the platform. Also ignore a couple of errors that may
8726 arise when trying to write the symbols. Undo my previous patch.
8728 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8730 * driver.cs: ignore /debug switch except for Unix platforms.
8732 2002-10-23 Nick Drochak <ndrochak@gol.com>
8734 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8736 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8738 * driver.cs: Do not make mcs-debug conditional, so we do not break
8741 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8742 review this patch. But basically after all the children variables
8743 have been merged, the value of "Breaks" was not being set to
8744 new_breaks for Switch blocks. I think that it should be set after
8745 it has executed. Currently I set this to the value of new_breaks,
8746 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8747 conservative, but I do not understand this code very well.
8749 I did not break anything in the build, so that is good ;-)
8751 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8753 2002-10-20 Mark Crichton <crichton@gimp.org>
8755 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8757 2002-10-20 Nick Drochak <ndrochak@gol.com>
8759 * cfold.cs: Fixed compile blocker.
8761 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8763 * driver.cs: I was chekcing the key, not the file.
8765 2002-10-19 Ravi Pratap <ravi@ximian.com>
8767 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8768 message that we were generating - we just need to silently return
8771 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8773 * class.cs (Event.Define): Change my previous commit, as this
8774 breaks the debugger. This is a temporary hack, as it seems like
8775 the compiler is generating events incorrectly to begin with.
8777 * expression.cs (Binary.ResolveOperator): Added support for
8778 "U operator - (E x, E y)"
8780 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8783 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8784 init-only variables, but this path did not take into account that
8785 there might be also instance readonly variables. Correct this
8788 This fixes bug 32253
8790 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8793 * driver.cs: Change the extension for modules to `netmodule'
8795 * cs-parser.jay: Improved slightly the location tracking for
8796 the debugger symbols.
8798 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8799 modifiers that were specified instead of the hardcoded value
8800 (FamAndAssem). This was basically ignoring the static modifier,
8801 and others. Fixes 32429.
8803 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8804 fixed a bug in the process (32476)
8806 * expression.cs (ArrayAccess.EmitAssign): Patch from
8807 hwang_rob@yahoo.ca that fixes bug 31834.3
8809 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8811 * driver.cs: Make the module extension .netmodule.
8813 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8815 * driver.cs: Report an error if the resource file is not found
8816 instead of crashing.
8818 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8819 false, like Emit does.
8821 2002-10-16 Nick Drochak <ndrochak@gol.com>
8823 * typemanager.cs: Remove unused private member. Also reported mcs
8824 bug to report this as a warning like csc.
8826 2002-10-15 Martin Baulig <martin@gnome.org>
8828 * statement.cs (Statement.Emit): Made this a virtual method; emits
8829 the line number info and calls DoEmit().
8830 (Statement.DoEmit): New protected abstract method, formerly knows
8831 as Statement.Emit().
8833 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8835 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8837 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8838 have fixed a remaining problem: not every AddXXXX was adding a
8839 fully qualified name.
8841 Now everyone registers a fully qualified name in the DeclSpace as
8842 being defined instead of the partial name.
8844 Downsides: we are slower than we need to be due to the excess
8845 copies and the names being registered this way.
8847 The reason for this is that we currently depend (on the corlib
8848 bootstrap for instance) that types are fully qualified, because
8849 we dump all the types in the namespace, and we should really have
8850 types inserted into the proper namespace, so we can only store the
8851 basenames in the defined_names array.
8853 2002-10-10 Martin Baulig <martin@gnome.org>
8855 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8856 from bug #31834, see the bug report for a testcase which is
8859 2002-10-10 Martin Baulig <martin@gnome.org>
8861 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
8862 flow analysis code for this.
8864 * statement.cs (Do, While, For): Tell the flow analysis code about
8866 (FlowBranching.UsageVector): Added support for infinite loops.
8867 (Block.Resolve): Moved the dead code elimination here and use flow
8870 2002-10-09 Miguel de Icaza <miguel@ximian.com>
8872 * class.cs (Field.Define): Catch cycles on struct type
8875 * typemanager.cs (IsUnmanagedtype): Do not recursively check
8876 fields if the fields are static. We only need to check instance
8879 * expression.cs (As.DoResolve): Test for reference type.
8881 * statement.cs (Using.ResolveExpression): Use
8882 ConvertImplicitRequired, not ConvertImplicit which reports an
8884 (Using.ResolveLocalVariableDecls): ditto.
8886 * expression.cs (Binary.ResolveOperator): Report errors in a few
8887 places where we had to.
8889 * typemanager.cs (IsUnmanagedtype): Finish implementation.
8891 2002-10-08 Miguel de Icaza <miguel@ximian.com>
8893 * expression.cs: Use StoreFromPtr instead of extracting the type
8894 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
8896 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
8897 an enumeration value to a System.Enum, but System.Enum is not a
8898 value type, but an class type, so we need to box.
8900 (Expression.ConvertExplicit): One codepath could return
8901 errors but not flag them. Fix this. Fixes #31853
8903 * parameter.cs (Resolve): Do not allow void as a parameter type.
8905 2002-10-06 Martin Baulig <martin@gnome.org>
8907 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
8908 if it's a class type and not a struct. Fixes #31815.
8910 2002-10-06 Martin Baulig <martin@gnome.org>
8912 * statement.cs: Reworked the flow analysis code a bit to make it
8913 usable for dead code elimination.
8915 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8917 * cs-parser.jay: allow empty source files. Fixes bug #31781.
8919 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8921 * expression.cs (ComposedCast.DoResolveType): A quick workaround
8922 to fix the test 165, will investigate deeper.
8924 2002-10-04 Martin Baulig <martin@gnome.org>
8926 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
8927 finally blocks actually work.
8928 (Try.Resolve): We don't need to create a sibling for `finally' if
8929 there is no finally block.
8931 2002-10-04 Martin Baulig <martin@gnome.org>
8933 * class.cs (Constructor.Define): The default accessibility for a
8934 non-default constructor is private, not public.
8936 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8938 * class.cs (Constructor): Make AllowedModifiers public, add
8941 * cs-parser.jay: Perform the modifiers test here, as the
8942 constructor for the Constructor class usually receives a zero
8943 because of the way we create it (first we create, later we
8944 customize, and we were never checking the modifiers).
8946 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
8947 is a version of LookupTypeReflection that includes the type-name
8948 cache. This can be used as a fast path for functions that know
8949 the fully qualified name and are only calling into *.GetType() to
8950 obtain a composed type.
8952 This is also used by TypeManager.LookupType during its type
8955 (LookupType): We now also track the real type name, as sometimes
8956 we can get a quey for the real type name from things like
8957 ComposedCast. This fixes bug 31422.
8959 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
8960 complete type fullname, it does not have to go through the type
8961 resolution system to obtain the composed version of the type (for
8962 obtaining arrays or pointers).
8964 (Conditional.Emit): Use the EmitBoolExpression to
8965 generate nicer code, as requested by Paolo.
8967 (ArrayCreation.CheckIndices): Use the patch from
8968 hwang_rob@yahoo.ca to validate the array initializers.
8970 2002-10-03 Miguel de Icaza <miguel@ximian.com>
8972 * class.cs (ConstructorInitializer.Emit): simplify code by using
8973 Invocation.EmitCall, and at the same time, fix the bugs in calling
8974 parent constructors that took variable arguments.
8976 * ecore.cs (Expression.ConvertNumericExplicit,
8977 Expression.ImplicitNumericConversion): Remove the code that
8978 manually wrapped decimal (InternalTypeConstructor call is now gone
8981 * expression.cs (Cast.TryReduce): Also handle decimal types when
8982 trying to perform a constant fold on the type.
8984 * typemanager.cs (IsUnmanagedtype): Partially implemented.
8986 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
8987 that only turned off an error report, and did nothing else.
8989 2002-10-02 Miguel de Icaza <miguel@ximian.com>
8991 * driver.cs: Handle and ignore /fullpaths
8993 2002-10-01 Miguel de Icaza <miguel@ximian.com>
8995 * expression.cs (Binary.ResolveOperator): Catch the case where
8996 DoNumericPromotions returns true,
8998 (Binary.DoNumericPromotions): Simplify the code, and the tests.
9000 2002-09-27 Miguel de Icaza <miguel@ximian.com>
9002 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
9005 2002-09-26 Miguel de Icaza <miguel@ximian.com>
9007 * ecore.cs (ConvertNumericExplicit): It is not enough that the
9008 conversion exists, but it is also required that the conversion be
9009 performed. This manifested in "(Type64Enum) 2".
9011 * class.cs (TypeManager.AddMethod): The fix is not to change
9012 AddEnum, because that one was using a fully qualified name (every
9013 DeclSpace derivative does), but to change the AddMethod routine
9014 that was using an un-namespaced name. This now correctly reports
9015 the duplicated name.
9017 Revert patch until I can properly fix it. The issue
9018 is that we have a shared Type space across all namespaces
9019 currently, which is wrong.
9021 Options include making the Namespace a DeclSpace, and merge
9022 current_namespace/current_container in the parser.
9024 2002-09-25 Miguel de Icaza <miguel@ximian.com>
9026 * cs-parser.jay: Improve error reporting when we get a different
9027 kind of expression in local_variable_type and
9028 local_variable_pointer_type.
9030 Propagate this to avoid missleading errors being reported.
9032 * ecore.cs (ImplicitReferenceConversion): treat
9033 TypeManager.value_type as a target just like object_type. As
9038 Is valid, and needs to result in the int 1 being boxed before it
9039 is assigned to the value type v.
9041 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
9042 to validate the enumeration name.
9044 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
9045 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
9046 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
9048 * ecore.cs (TryImplicitIntConversion): When doing an
9049 implicit-enumeration-conversion, check if the type is 64-bits and
9050 perform a conversion before passing to EnumConstant.
9052 2002-09-23 Miguel de Icaza <miguel@ximian.com>
9054 * decl.cs (Error_AmbiguousTypeReference); New routine used to
9055 report ambiguous type references. Unlike the MS version, we
9056 report what the ambiguity is. Innovation at work ;-)
9058 (DeclSpace.FindType): Require a location argument to
9059 display when we display an ambiguous error.
9061 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
9063 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
9065 * expression.cs (EmitDynamicInitializers): Apply patch from
9066 hwang_rob@yahoo.ca that fixes the order in which we emit our
9069 2002-09-21 Martin Baulig <martin@gnome.org>
9071 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
9072 delegate takes no arguments.
9074 2002-09-20 Miguel de Icaza <miguel@ximian.com>
9076 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
9079 * expression.cs: Extract the underlying type.
9081 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
9083 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
9085 2002-09-19 Miguel de Icaza <miguel@ximian.com>
9087 * class.cs (TypeContainer.DefineType): We can not use the nice
9088 PackingSize with the size set to 1 DefineType method, because it
9089 will not allow us to define the interfaces that the struct
9092 This completes the fixing of bug 27287
9094 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
9095 means also structs. This fixes part of the problem.
9096 (Expresion.ImplicitReferenceConversionExists): ditto.
9098 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
9099 error if there were no errors reported during the type lookup
9100 process, to avoid duplicates or redundant errors. Without this
9101 you would get an ambiguous errors plus a type not found. We have
9102 beaten the user enough with the first error.
9104 (DeclSparce.FindType): Emit a warning if we have an ambiguous
9107 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
9108 during the resolution process, stop the lookup, this avoids
9109 repeated error reports (same error twice).
9111 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
9113 * typemanager.cs (LookupType): Redo the type lookup code to match
9114 the needs of System.Reflection.
9116 The issue is that System.Reflection requires references to nested
9117 types to begin with a "+" sign instead of a dot. So toplevel
9118 types look like: "NameSpace.TopLevelClass", and nested ones look
9119 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
9122 2002-09-19 Martin Baulig <martin@gnome.org>
9124 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
9125 says that a method always returns or always throws an exception,
9126 don't report the CS0161.
9128 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
9129 set `Returns = new_returns'.
9131 2002-09-19 Martin Baulig <martin@gnome.org>
9133 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
9134 to an enum constant, check for a CS0176.
9136 2002-09-18 Miguel de Icaza <miguel@ximian.com>
9138 * class.cs (TypeContainer.CheckPairedOperators): Now we check
9139 for operators that must be in pairs and report errors.
9141 * ecore.cs (SimpleName.DoResolveType): During the initial type
9142 resolution process, when we define types recursively, we must
9143 check first for types in our current scope before we perform
9144 lookups in the enclosing scopes.
9146 * expression.cs (MakeByteBlob): Handle Decimal blobs.
9148 (Invocation.VerifyArgumentsCompat): Call
9149 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
9150 I thought we were supposed to always call this, but there are a
9151 few places in the code where we dont do it.
9153 2002-09-17 Miguel de Icaza <miguel@ximian.com>
9155 * driver.cs: Add support in -linkres and -resource to specify the
9156 name of the identifier.
9158 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9160 * ecore.cs (StandardConversionExists): Sync with the conversion
9161 code: allow anything-* to void* conversions.
9163 (FindMostSpecificSource): Use an Expression argument
9164 instead of a Type, because we might be handed over a Literal which
9165 gets a few more implicit conversions that plain types do not. So
9166 this information was being lost.
9168 Also, we drop the temporary type-holder expression when not
9171 2002-09-17 Martin Baulig <martin@gnome.org>
9173 * class.cs (PropertyBase.CheckBase): Don't check the base class if
9174 this is an explicit interface implementation.
9176 2002-09-17 Martin Baulig <martin@gnome.org>
9178 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
9179 different `IndexerName' attributes.
9181 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
9182 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
9183 virtual CommonResolve().
9185 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9187 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
9188 and convert that to the UnderlyingType.
9190 * statement.cs (Foreach.Resolve): Indexers are just like variables
9191 or PropertyAccesses.
9193 * cs-tokenizer.cs (consume_string): Track line numbers and columns
9194 inside quoted strings, we were not doing this before.
9196 2002-09-16 Martin Baulig <martin@gnome.org>
9198 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
9199 resolve it. This is needed for the definite assignment check of the
9200 instance expression, fixes bug #29846.
9201 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
9203 2002-09-16 Nick Drochak <ndrochak@gol.com>
9205 * parameter.cs: Fix compile error. Cannot reference static member
9206 from an instance object. Is this an mcs bug?
9208 2002-09-14 Martin Baulig <martin@gnome.org>
9210 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
9211 multiple times. Fixes bug #30295, added test-166.cs.
9213 2002-09-14 Martin Baulig <martin@gnome.org>
9215 * statement.cs (Block.Emit): Don't emit unreachable code.
9216 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
9218 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
9220 2002-09-14 Martin Baulig <martin@gnome.org>
9222 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
9225 2002-09-14 Martin Baulig <martin@gnome.org>
9227 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
9228 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
9229 be false on the ms runtime.
9231 2002-09-13 Martin Baulig <martin@gnome.org>
9233 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
9234 the CS0038 error message.
9236 2002-09-12 Miguel de Icaza <miguel@ximian.com>
9238 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
9239 constant inside, return it.
9241 2002-09-12 Martin Baulig <martin@gnome.org>
9243 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
9244 implicit conversion can be done between enum types.
9246 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
9247 check whether an implicit conversion to the current enum's UnderlyingType
9248 exists and report an error if not.
9250 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
9251 without debugging support.
9253 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
9254 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
9256 2002-09-12 Martin Baulig <martin@gnome.org>
9258 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
9260 * ecore.cs (IMemberExpr.DeclaringType): New property.
9261 (SimpleName.SimpleNameResolve): Check whether we're accessing a
9262 nonstatic member of an outer type (CS0038).
9264 2002-09-11 Miguel de Icaza <miguel@ximian.com>
9266 * driver.cs: Activate the using-error detector at warning level
9267 4 (at least for MS-compatible APIs).
9269 * namespace.cs (VerifyUsing): Small buglett fix.
9271 * pending.cs (PendingImplementation): pass the container pointer.
9273 * interface.cs (GetMethods): Allow for recursive definition. Long
9274 term, I would like to move every type to support recursive
9275 definitions, not the current ordering mechanism that we have right
9278 The situation is this: Attributes are handled before interfaces,
9279 so we can apply attributes to interfaces. But some attributes
9280 implement interfaces, we will now handle the simple cases
9281 (recursive definitions will just get an error).
9283 * parameter.cs: Only invalidate types at the end if we fail to
9286 2002-09-09 Martin Baulig <martin@gnome.org>
9288 * ecore.cs (PropertyExpr.Emit): Also check for
9289 TypeManager.system_int_array_get_length so this'll also work when
9290 compiling corlib. Fixes #30003.
9292 2002-09-09 Martin Baulig <martin@gnome.org>
9294 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
9295 and throw an exception if we can't get the type's size. Fixed #30040,
9298 2002-09-09 Martin Baulig <martin@gnome.org>
9300 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
9302 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
9303 context. Fixes bug #30027.
9305 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
9306 virtual functions. Fixes bug #30043, added test-164.cs.
9308 2002-09-08 Ravi Pratap <ravi@ximian.com>
9310 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
9312 2002-09-08 Nick Drochak <ndrochak@gol.com>
9314 * driver.cs: Use an object to get the windows codepage since it's not a
9317 2002-09-08 Miguel de Icaza <miguel@ximian.com>
9319 * statement.cs (For.Emit): for infinite loops (test == null)
9320 return whether there is a break inside, not always "true".
9322 * namespace.cs (UsingEntry): New struct to hold the name of the
9323 using definition, the location where it is defined, and whether it
9324 has been used in a successful type lookup.
9326 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
9331 2002-09-06 Ravi Pratap <ravi@ximian.com>
9333 * attribute.cs : Fix incorrect code which relied on catching
9334 a NullReferenceException to detect a null being passed in
9335 where an object was expected.
9337 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9339 * statement.cs (Try): flag the catch variable as assigned
9341 * expression.cs (Cast): Simplified by using ResolveType instead of
9344 * statement.cs (Catch): Fix bug by using ResolveType.
9346 2002-09-06 Ravi Pratap <ravi@ximian.com>
9348 * expression.cs (BetterConversion): Special case for when we have
9349 a NullLiteral as the argument and we have to choose between string
9350 and object types - we choose string the way csc does.
9352 * attribute.cs (Attribute.Resolve): Catch the
9353 NullReferenceException and report error #182 since the Mono
9354 runtime no more has the bug and having this exception raised means
9355 we tried to select a constructor which takes an object and is
9358 2002-09-05 Ravi Pratap <ravi@ximian.com>
9360 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9361 message (1502, 1503) when we can't locate a method after overload
9362 resolution. This is much more informative and closes the bug
9365 * interface.cs (PopulateMethod): Return if there are no argument
9366 types. Fixes a NullReferenceException bug.
9368 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9369 expressions too. Previously we were checking only in one place for
9370 positional arguments leaving out named arguments.
9372 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9373 type to the enum type is not allowed. Remove code corresponding to
9376 (ConvertNumericExplicit): Allow explicit conversions from
9377 the underlying type to enum type. This precisely follows the spec
9378 and closes a bug filed by Gonzalo.
9380 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9383 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9385 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9387 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9388 it was important that we stored the right value after the
9389 reduction in `converted'.
9391 2002-09-04 Martin Baulig <martin@gnome.org>
9393 * location.cs (Location.SymbolDocument): Use full pathnames for the
9396 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9398 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9399 of the expression resolve mechanism, because that will catch the
9400 SimpleName error failures.
9402 (Conditional): If we can not resolve the
9403 expression, return, do not crash.
9405 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9408 (location): display token name instead of its number.
9410 2002-08-28 Martin Baulig <martin@gnome.org>
9412 * expression.cs (Binary.ResolveOperator): Don't silently return
9413 but return an error if an operator cannot be applied between two
9416 2002-08-28 Martin Baulig <martin@gnome.org>
9418 * class.cs (Constructor.Define): Set the permission attributes
9419 correctly instead of making all constructors public.
9421 2002-08-28 Martin Baulig <martin@gnome.org>
9423 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9424 for private members before reporting a CS0103; if we find anything,
9427 2002-08-28 Martin Baulig <martin@gnome.org>
9429 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9430 to check whether `closure_start_type == closure_invocation_type',
9431 we also need to check whether `m.DeclaringType == closure_invocation_type'
9432 before bypassing the permission checks. We might be accessing
9433 protected/private members from the base class.
9434 (TypeManager.RealMemberLookup): Only set private_ok if private
9435 members were requested via BindingFlags.NonPublic.
9437 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9439 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9440 MethodGroupExpr.IsExplicitImpl if appropriate.
9441 (Invocation.DoResolve): Don't report the CS0120 for explicit
9442 interface implementations.
9444 2002-08-27 Martin Baulig <martin@gnome.org>
9446 * expression.cs (Invocation.DoResolve): If this is a static
9447 method and we don't have an InstanceExpression, we must report
9450 2002-08-25 Martin Baulig <martin@gnome.org>
9452 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9453 `==' between a valuetype and an object.
9455 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9457 * ecore.cs (TypeExpr): Provide a ToString method.
9459 2002-08-24 Martin Baulig <martin@gnome.org>
9461 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9462 now called proggie.dbg and it's a binary file.
9464 2002-08-23 Martin Baulig <martin@gnome.org>
9466 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9468 2002-08-23 Martin Baulig <martin@gnome.org>
9470 * struct.cs (MyStructInfo.ctor): Make this work with empty
9471 structs; it's not allowed to use foreach() on null.
9473 2002-08-23 Martin Baulig <martin@gnome.org>
9475 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9476 writer the full pathname of the generated assembly.
9478 2002-08-23 Martin Baulig <martin@gnome.org>
9480 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9481 A `finally' block never returns or breaks; improved handling of
9484 2002-08-23 Martin Baulig <martin@gnome.org>
9486 * statement.cs (Throw.Resolve): Allow `throw null'.
9488 2002-08-23 Martin Baulig <martin@gnome.org>
9490 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9491 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9492 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9493 MemberLookup would return a wrong event if this is an explicit
9494 interface implementation and the class has an event with the same
9497 2002-08-23 Martin Baulig <martin@gnome.org>
9499 * statement.cs (Block.AddChildVariableNames): New public method.
9500 (Block.AddChildVariableName): Likewise.
9501 (Block.IsVariableNameUsedInChildBlock): Likewise.
9502 (Block.AddVariable): Check whether a variable name has already
9503 been used in a child block.
9505 * cs-parser.jay (declare_local_variables): Mark all variable names
9506 from the current block as being used in a child block in the
9509 2002-08-23 Martin Baulig <martin@gnome.org>
9511 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9512 find the symbol writer.
9514 * driver.cs: csc also allows the arguments to /define being
9515 separated by commas, not only by semicolons.
9517 2002-08-23 Martin Baulig <martin@gnome.org>
9519 * interface.cs (Interface.GetMembers): Added static check for events.
9521 2002-08-15 Martin Baulig <martin@gnome.org>
9523 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9524 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9526 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9527 why the MethodData.EmitDestructor() change was necessary.
9529 2002-08-20 Martin Baulig <martin@gnome.org>
9531 * class.cs (TypeContainer.FindMembers): Added static check for events.
9533 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9535 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9536 use Type.GetEvents(), not Type.FindMembers().
9538 2002-08-20 Martin Baulig <martin@gnome.org>
9540 * decl.cs (MemberCache): Added a special method cache which will
9541 be used for method-only searched. This ensures that a method
9542 search will return a MethodInfo with the correct ReflectedType for
9545 2002-08-20 Martin Baulig <martin@gnome.org>
9547 * decl.cs (DeclSpace.FindMembers): Made this public.
9549 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9551 * delegate.cs: fixed build on windows.
9552 [FIXME: Filed as bug #29150: MCS must report these errors.]
9554 2002-08-19 Ravi Pratap <ravi@ximian.com>
9556 * ecore.cs (StandardConversionExists): Return a false
9557 if we are trying to convert the void type to anything else
9558 since that is not allowed.
9560 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9561 we flag error 70 in the event an event is trying to be accessed
9562 directly from outside the declaring type.
9564 2002-08-20 Martin Baulig <martin@gnome.org>
9566 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9567 MemberCache from typemanager.cs to decl.cs.
9569 2002-08-19 Martin Baulig <martin@gnome.org>
9571 * class.cs (TypeContainer): Implement IMemberContainer.
9572 (TypeContainer.DefineMembers): Create the MemberCache.
9573 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9574 return public members if BindingFlags.Public was given, check
9575 whether members are static.
9577 2002-08-16 Martin Baulig <martin@gnome.org>
9579 * decl.cs (DeclSpace.Define): Splitted this in Define and
9580 DefineMembers. DefineMembers is called first and initializes the
9583 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9584 DefineMembers() on all our DeclSpaces.
9586 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9587 but call DefineMembers() on all nested interfaces. We call their
9588 Define() in our new Define() function.
9590 * interface.cs (Interface): Implement IMemberContainer.
9591 (Interface.Define): Moved all code except the attribute stuf to
9593 (Interface.DefineMembers): Initialize the member cache.
9595 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9596 need this anymore since we can use MemberCache.FindMembers directly.
9598 2002-08-19 Martin Baulig <martin@gnome.org>
9600 * typemanager.cs (MemberCache): When creating the cache for an
9601 interface type, add all inherited members.
9602 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9603 to `out bool used_cache' and documented it.
9604 (TypeManager.MemberLookup): If we already used the cache in the first
9605 iteration, we don't need to do the interfaces check.
9607 2002-08-19 Martin Baulig <martin@gnome.org>
9609 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9610 here from IMemberFinder and don't implement this interface anymore.
9611 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9613 * typemanager.cs (IMemberFinder): This interface is now only used by
9614 classes which actually support the member cache.
9615 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9616 since we only put DeclSpaces into this Hashtable.
9617 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9618 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9620 2002-08-16 Martin Baulig <martin@gnome.org>
9622 * typemanager.cs (ICachingMemberFinder): Removed.
9623 (IMemberFinder.MemberCache): New property.
9624 (TypeManager.FindMembers): Merged this with RealFindMembers().
9625 This function will never be called from TypeManager.MemberLookup()
9626 so we can't use the cache here, just the IMemberFinder.
9627 (TypeManager.MemberLookup_FindMembers): Check whether the
9628 IMemberFinder has a MemberCache and call the cache's FindMembers
9630 (MemberCache): Rewrote larger parts of this yet another time and
9631 cleaned it up a bit.
9633 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9635 * driver.cs (LoadArgs): Support quoting.
9637 (Usage): Show the CSC-like command line arguments.
9639 Improved a few error messages.
9641 2002-08-15 Martin Baulig <martin@gnome.org>
9643 * typemanager.cs (IMemberContainer.Type): New property.
9644 (IMemberContainer.IsInterface): New property.
9646 The following changes are conditional to BROKEN_RUNTIME, which is
9647 defined at the top of the file.
9649 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9650 class'es members, but add all members from TypeHandle.ObjectType
9651 if we're an interface.
9652 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9653 is the current type.
9654 (MemberCache.CacheEntry.Container): Removed this field.
9655 (TypeHandle.GetMembers): Include inherited members.
9657 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9659 * typemanager.cs: fixed compilation and added a comment on a field that
9662 2002-08-15 Martin Baulig <martin@gnome.org>
9664 * class.cs (ConstructorInitializer.Resolve): In the
9665 Expression.MemberLookup call, use the queried_type as
9668 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9669 declared' attribute, it's always true.
9670 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9671 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9672 temporary wrapper for FindMembers which tells MemberLookup whether
9673 members from the base classes are included in the return value.
9674 This will go away soon.
9675 (TypeManager.MemberLookup): Use this temporary hack here; once the
9676 new MemberCache is completed, we don't need to do the DeclaredOnly
9677 looping here anymore since the MemberCache will take care of this.
9678 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9679 (MemberCache): When creating the MemberCache for a class, get
9680 members from the current class and all its base classes.
9681 (MemberCache.CacheEntry.Container): New field. This is a
9682 temporary hack until the Mono runtime is fixed to distinguish
9683 between ReflectedType and DeclaringType. It allows us to use MCS
9684 with both the MS runtime and the unfixed Mono runtime without
9685 problems and without accecting performance.
9686 (MemberCache.SearchMembers): The DeclaredOnly looping from
9687 TypeManager.MemberLookup is now done here.
9689 2002-08-14 Martin Baulig <martin@gnome.org>
9691 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9692 Type.GetFields on dynamic types but get the fields from the
9693 corresponding TypeContainer.
9694 (MyStructInfo.GetStructInfo): Added check for enum types.
9696 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9697 (MemberList.SyncRoot): Implemented.
9698 (TypeManager.FilterWithClosure): No need to check permissions if
9699 closure_start_type == closure_invocation_type, don't crash if
9700 closure_invocation_type is null.
9702 2002-08-13 Martin Baulig <martin@gnome.org>
9704 Rewrote TypeContainer.FindMembers to use a member cache. This
9705 gives us a speed increase of about 35% for the self-hosting MCS
9706 build and of about 15-20% for the class libs (both on GNU/Linux).
9708 * report.cs (Timer): New class to get enhanced profiling. This
9709 whole class is "TIMER" conditional since it remarkably slows down
9712 * class.cs (MemberList): New class. This is an IList wrapper
9713 which we're now using instead of passing MemberInfo[]'s around to
9714 avoid copying this array unnecessarily.
9715 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9716 (ICachingMemberFinder, IMemberContainer): New interface.
9717 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9718 has already been checked, otherwise use it for the name comparision.
9719 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9720 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9721 if possible. Returns a MemberList, not a MemberInfo [].
9722 (TypeHandle): New class, implements IMemberContainer. We create
9723 one instance of this class per type, it contains a MemberCache
9724 which is used to do the member lookups.
9725 (MemberCache): New class. Each instance of this class contains
9726 all members of a type and a name-based hash table.
9727 (MemberCache.FindMembers): This is our new member lookup
9728 function. First, it looks up all members of the requested name in
9729 the hash table. Then, it walks this list and sorts out all
9730 applicable members and returns them.
9732 2002-08-13 Martin Baulig <martin@gnome.org>
9734 In addition to a nice code cleanup, this gives us a performance
9735 increase of about 1.4% on GNU/Linux - not much, but it's already
9736 half a second for the self-hosting MCS compilation.
9738 * typemanager.cs (IMemberFinder): New interface. It is used by
9739 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9740 Enum, Delegate or Interface.
9741 (TypeManager.finder_to_member_finder): New PtrHashtable.
9742 (TypeManager.finder_to_container): Removed.
9743 (TypeManager.finder_to_delegate): Removed.
9744 (TypeManager.finder_to_interface): Removed.
9745 (TypeManager.finder_to_enum): Removed.
9747 * interface.cs (Interface): Implement IMemberFinder.
9749 * delegate.cs (Delegate): Implement IMemberFinder.
9751 * enum.cs (Enum): Implement IMemberFinder.
9753 * class.cs (TypeContainer): Implement IMemberFinder.
9755 2002-08-12 Martin Baulig <martin@gnome.org>
9757 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9759 2002-08-12 Martin Baulig <martin@gnome.org>
9761 * ecore.cs (ITypeExpression): New interface for expressions which
9763 (TypeExpression): Renamed to TypeLookupExpression.
9764 (Expression.DoResolve): If we're doing a types-only lookup, the
9765 expression must implement the ITypeExpression interface and we
9766 call DoResolveType() on it.
9767 (SimpleName): Implement the new ITypeExpression interface.
9768 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9769 hack, the situation that we're only looking up types can't happen
9770 anymore when this method is called. Moved the type lookup code to
9771 DoResolveType() and call it.
9772 (SimpleName.DoResolveType): This ITypeExpression interface method
9773 is now doing the types-only lookup.
9774 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9775 (ResolveFlags): Added MaskExprClass.
9777 * expression.cs (MemberAccess): Implement the ITypeExpression
9779 (MemberAccess.DoResolve): Added support for a types-only lookup
9780 when we're called via ITypeExpression.DoResolveType().
9781 (ComposedCast): Implement the ITypeExpression interface.
9783 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9784 Expression.Resolve() with ResolveFlags.Type instead.
9786 2002-08-12 Martin Baulig <martin@gnome.org>
9788 * interface.cs (Interface.Define): Apply attributes.
9790 * attribute.cs (Attribute.ApplyAttributes): Added support for
9791 interface attributes.
9793 2002-08-11 Martin Baulig <martin@gnome.org>
9795 * statement.cs (Block.Emit): Only check the "this" variable if we
9796 do not always throw an exception.
9798 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9799 whether the property has a set accessor.
9801 2002-08-11 Martin Baulig <martin@gnome.org>
9803 Added control flow analysis support for structs.
9805 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9806 with control flow analysis turned off.
9807 (IVariable): New interface.
9808 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9809 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9810 (FieldExpr.DoResolve): Resolve the instance expression with flow
9811 analysis turned off and do the definite assignment check after the
9812 resolving when we know what the expression will resolve to.
9814 * expression.cs (LocalVariableReference, ParameterReference):
9815 Implement the new IVariable interface, only call the flow analysis
9816 code if ec.DoFlowAnalysis is true.
9817 (This): Added constructor which takes a Block argument. Implement
9818 the new IVariable interface.
9819 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9820 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9821 This does the definite assignment checks for struct members.
9823 * class.cs (Constructor.Emit): If this is a non-static `struct'
9824 constructor which doesn't have any initializer, call
9825 Block.AddThisVariable() to tell the flow analysis code that all
9826 struct elements must be initialized before control returns from
9829 * statement.cs (MyStructInfo): New public class.
9830 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9831 argument to this indexer. If non-zero, check an individual struct
9832 member, not the whole struct.
9833 (FlowBranching.CheckOutParameters): Check struct members.
9834 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9835 overloaded versions of these methods which take an additional
9836 `int field_idx' argument to check struct members.
9837 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9838 overloaded versions of these methods which take an additional
9839 `string field_name' argument to check struct member.s
9840 (VariableInfo): Implement the IVariable interface.
9841 (VariableInfo.StructInfo): New public property. Returns the
9842 MyStructInfo instance of the variable if it's a struct or null.
9843 (Block.AddThisVariable): New public method. This is called from
9844 Constructor.Emit() for non-static `struct' constructor which do
9845 not have any initializer. It creates a special variable for the
9846 "this" instance variable which will be checked by the flow
9847 analysis code to ensure that all of the struct's fields are
9848 initialized before control returns from the constructor.
9849 (UsageVector): Added support for struct members. If a
9850 variable/parameter is a struct with N members, we reserve a slot
9851 in the usage vector for each member. A struct is considered fully
9852 initialized if either the struct itself (slot 0) or all its
9853 members are initialized.
9855 2002-08-08 Martin Baulig <martin@gnome.org>
9857 * driver.cs (Driver.MainDriver): Only report an error CS5001
9858 if there were no compilation errors.
9860 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
9861 `UnsafeContext' property to determine whether the parent is in
9862 unsafe context rather than checking the parent's ModFlags:
9863 classes nested in an unsafe class are unsafe as well.
9865 2002-08-08 Martin Baulig <martin@gnome.org>
9867 * statement.cs (UsageVector.MergeChildren): Distinguish between
9868 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
9869 we return. Added test17() and test18() to test-154.cs.
9871 2002-08-08 Martin Baulig <martin@gnome.org>
9873 * typemanager.cs (TypeManager.FilterWithClosure): If we have
9874 Family access, make sure the invoking type isn't a subclass of the
9875 queried type (that'd be a CS1540).
9877 * ecore.cs (Expression.MemberLookup): Added overloaded version of
9878 this method which takes an additional `Type invocation_type'.
9880 * expression.cs (BaseAccess.DoResolve): Use the base type as
9881 invocation and query type.
9882 (MemberAccess.DoResolve): If the lookup failed and we're about to
9883 report a CS0122, try a lookup with the ec.ContainerType - if this
9884 succeeds, we must report a CS1540.
9886 2002-08-08 Martin Baulig <martin@gnome.org>
9888 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
9889 (MethodGroupExpr): Implement the IMemberExpr interface.
9891 * expression (MemberAccess.ResolveMemberAccess): No need to have
9892 any special code for MethodGroupExprs anymore, they're now
9895 2002-08-08 Martin Baulig <martin@gnome.org>
9897 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
9898 Family, FamANDAssem and FamORAssem permissions.
9899 (TypeManager.IsSubclassOrNestedChildOf): New public method.
9901 2002-08-08 Martin Baulig <martin@gnome.org>
9903 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
9904 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
9907 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
9909 * driver.cs: implemented /resource option to embed managed resources.
9911 2002-08-07 Martin Baulig <martin@gnome.org>
9913 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
9914 (FieldBase.HasFieldInitializer): New public property.
9915 (FieldBase.GetInitializerExpression): New public method. Resolves and
9916 returns the field initializer and makes sure it is only resolved once.
9917 (TypeContainer.EmitFieldInitializers): Call
9918 FieldBase.GetInitializerExpression to get the initializer, this ensures
9919 that it isn't resolved multiple times.
9921 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
9922 the resolving process (SimpleName/MemberLookup) that we're currently
9923 emitting a field initializer (which must not access any instance members,
9924 this is an error CS0236).
9926 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
9927 argument, if the `IsFieldInitializer' flag is set, we must report and
9928 error CS0236 and not an error CS0120.
9930 2002-08-07 Martin Baulig <martin@gnome.org>
9932 * ecore.cs (IMemberExpr): New public interface.
9933 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
9934 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
9935 if the expression is an IMemberExpr.
9937 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
9938 to be null, implicitly default to `this' if we're non-static in
9939 this case. Simplified the code a lot by using the new IMemberExpr
9940 interface. Also fixed bug #28176 here.
9942 2002-08-06 Martin Baulig <martin@gnome.org>
9944 * cs-parser.jay (SimpleLookup): Removed. We need to create
9945 ParameterReferences during semantic analysis so that we can do a
9946 type-only search when resolving Cast, TypeOf and SizeOf.
9947 (block): Pass the `current_local_parameters' to the Block's
9950 * class.cs (ConstructorInitializer): Added `Parameters parameters'
9951 argument to the constructor.
9952 (ConstructorInitializer.Resolve): Create a temporary implicit
9953 block with the parameters.
9955 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
9956 references here if we aren't doing a type-only search.
9958 * statement.cs (Block): Added constructor which takes a
9959 `Parameters parameters' argument.
9960 (Block.Parameters): New public property.
9962 * support.cs (InternalParameters.Parameters): Renamed `parameters'
9963 to `Parameters' and made it public readonly.
9965 2002-08-06 Martin Baulig <martin@gnome.org>
9967 * ecore.cs (Expression.Warning): Made this public as well.
9969 * report.cs (Report.Debug): Print the contents of collections.
9971 2002-08-06 Martin Baulig <martin@gnome.org>
9973 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
9974 used to tell Resolve() which kinds of expressions it may return.
9975 (Expression.Resolve): Added overloaded version of this method which
9976 takes a `ResolveFlags flags' argument. This can be used to tell
9977 Resolve() which kinds of expressions it may return. Reports a
9979 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
9980 ResolveFlags.SimpleName.
9981 (Expression.Error118): Added overloaded version of this method which
9982 takes a `ResolveFlags flags' argument. It uses the flags to determine
9983 which kinds of expressions are allowed.
9985 * expression.cs (Argument.ResolveMethodGroup): New public method.
9986 Resolves an argument, but allows a MethodGroup to be returned.
9987 This is used when invoking a delegate.
9989 * TODO: Updated a bit.
9991 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9993 Fixed compilation with csc.
9995 * ecore.cs: Expression.Error made public. Is this correct? Should
9996 Warning be made public too?
9998 * expression.cs: use ea.Location instead of ea.loc.
9999 [FIXME: Filed as bug #28607: MCS must report these errors.]
10001 2002-08-06 Martin Baulig <martin@gnome.org>
10003 * ecore.cs (Expression.loc): Moved the location here instead of
10004 duplicating it in all derived classes.
10005 (Expression.Location): New public property.
10006 (Expression.Error, Expression.Warning): Made them non-static and
10007 removed the location argument.
10008 (Expression.Warning): Added overloaded version which takes an
10009 `int level' argument.
10010 (Expression.Error118): Make this non-static and removed the
10011 expression and location arguments.
10012 (TypeExpr): Added location argument to the constructor.
10014 * expression.cs (StaticCallExpr): Added location argument to
10016 (Indirection, PointerArithmetic): Likewise.
10017 (CheckedExpr, UnCheckedExpr): Likewise.
10018 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
10019 (StringPtr): Likewise.
10022 2002-08-05 Martin Baulig <martin@gnome.org>
10024 * expression.cs (BaseAccess.DoResolve): Actually report errors.
10026 * assign.cs (Assign.DoResolve): Check whether the source
10027 expression is a value or variable.
10029 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
10030 while resolving the corresponding blocks.
10032 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
10033 an error, don't silently return null.
10035 * statement.cs (Block.AddVariable): Do the error reporting here
10036 and distinguish between CS0128 and CS0136.
10037 (Block.DoResolve): Report all unused labels (warning CS0164).
10038 (LabeledStatement): Pass the location to the constructor.
10039 (LabeledStatement.HasBeenReferenced): New property.
10040 (LabeledStatement.Resolve): Set it to true here.
10042 * statement.cs (Return.Emit): Return success even after reporting
10043 a type mismatch error (CS0126 or CS0127), this is what csc does and
10044 it avoids confusing the users with any consecutive errors.
10046 2002-08-05 Martin Baulig <martin@gnome.org>
10048 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
10050 * const.cs (Const.LookupConstantValue): Catch circular definitions.
10052 * expression.cs (MemberAccess.DoResolve): Silently return if an
10053 error has already been reported.
10055 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
10056 error has already been reported.
10058 2002-08-05 Martin Baulig <martin@gnome.org>
10060 * statement.cs (UsageVector): Only initialize the `parameters'
10061 vector if we actually have any "out" parameters.
10063 2002-08-05 Martin Baulig <martin@gnome.org>
10065 * expression.cs (Binary.ResolveOperator): When combining delegates,
10066 they must have the same type.
10068 2002-08-05 Martin Baulig <martin@gnome.org>
10070 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
10071 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
10072 work with the ms runtime and we also don't need it: if we're a
10073 PropertyBuilder and not in the `indexer_arguments' hash, then we
10074 are a property and not an indexer.
10076 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
10077 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
10078 since the latter one doesn't work with the ms runtime.
10080 2002-08-03 Martin Baulig <martin@gnome.org>
10082 Fixed bugs #27998 and #22735.
10084 * class.cs (Method.IsOperator): New public field.
10085 (Method.CheckBase): Report CS0111 if there's already a method
10086 with the same parameters in the current class. Report CS0508 when
10087 attempting to change the return type of an inherited method.
10088 (MethodData.Emit): Report CS0179 if a method doesn't have a body
10089 and it's not marked abstract or extern.
10090 (PropertyBase): New abstract base class for Property and Indexer.
10091 (PropertyBase.CheckBase): Moved here from Property and made it work
10093 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
10094 the same so we can reuse it there.
10095 (Property, Indexer): Derive from PropertyBase.
10096 (MethodSignature.inheritable_property_signature_filter): New delegate
10097 to find properties and indexers.
10099 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
10100 argument and improved error reporting.
10102 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
10103 EmptyReadOnlyParameters and made it a property.
10105 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
10106 version of this method which takes a `PropertyInfo indexer'.
10107 (TypeManager.RegisterIndexer): New method.
10109 * class.cs: Added myself as author of this file :-)
10111 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10113 * class.cs: fixed compilation on windoze.
10115 2002-08-03 Martin Baulig <martin@gnome.org>
10117 * interface.cs (Interface.GetInterfaceBases): Check whether all
10118 base interfaces are at least as accessible than the current one.
10120 * class.cs (TypeContainer.GetClassBases): Check whether base types
10121 are at least as accessible than the current type.
10122 (TypeContainer.AsAccessible): Implemented and made non-static.
10123 (MemberBase.CheckParameters): Report errors if the accessibility
10126 * delegate.cs (Delegate.Delegate): The default visibility is
10127 internal for top-level types and private for nested types.
10128 (Delegate.Define): Report errors if the accessibility checks fail.
10130 * enum.cs (Enum.Enum): The default visibility is internal for
10131 top-level types and private for nested types.
10132 (Enum.DefineType): Compute the correct visibility.
10134 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
10135 function which takes a `bool is_toplevel' instead of a TypeContainer.
10137 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
10140 2002-08-02 Martin Baulig <martin@gnome.org>
10142 * expression.cs (LocalVariableReferenc): Added constructor which
10143 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
10144 (LocalVariableReference.IsReadOnly): New property.
10145 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
10146 variable is readonly, use our own readonly flag to do this; you can
10147 use the new constructor to get a writable reference to a read-only
10150 * cs-parser.jay (foreach_statement, using_statement): Get a writable
10151 reference to the local variable.
10153 2002-08-01 Miguel de Icaza <miguel@ximian.com>
10155 * rootcontext.cs (ResolveCore): Also include System.Exception
10157 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
10158 we reach an EmptyStatement.
10160 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
10163 * expression.cs (Binary.ResolveOperator): Check error result in
10166 use brtrue/brfalse directly and avoid compares to null.
10168 2002-08-02 Martin Baulig <martin@gnome.org>
10170 * class.cs (TypeContainer.Define): Define all nested interfaces here.
10171 Fixes bug #28407, added test-155.cs.
10173 2002-08-01 Martin Baulig <martin@gnome.org>
10175 * class.cs (Event.EmitDefaultMethod): Make this work with static
10176 events. Fixes #28311, added verify-3.cs.
10178 2002-08-01 Martin Baulig <martin@gnome.org>
10180 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
10181 `is_disposable' fields.
10182 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
10183 `hm.is_disposable' if we're using the collection pattern.
10184 (Foreach.EmitCollectionForeach): Use the correct type for the
10185 enumerator's local variable, only emit the try/finally block if
10186 necessary (fixes #27713).
10188 2002-08-01 Martin Baulig <martin@gnome.org>
10190 * ecore.cs (Expression.report118): Renamed to Error118 and made
10193 * statement.cs (Throw.Resolve): Check whether the expression is of
10194 the correct type (CS0118) and whether the type derives from
10195 System.Exception (CS0155).
10196 (Catch.Resolve): New method. Do the type lookup here and check
10197 whether it derives from System.Exception (CS0155).
10198 (Catch.CatchType, Catch.IsGeneral): New public properties.
10200 * typemanager.cs (TypeManager.exception_type): Added.
10202 2002-07-31 Miguel de Icaza <miguel@ximian.com>
10204 * driver.cs: Updated About function.
10206 2002-07-31 Martin Baulig <martin@gnome.org>
10208 Implemented Control Flow Analysis.
10210 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
10211 (EmitContext.CurrentBranching): Added.
10212 (EmitContext.StartFlowBranching): Added.
10213 (EmitContext.EndFlowBranching): Added.
10214 (EmitContext.KillFlowBranching): Added.
10215 (EmitContext.IsVariableAssigned): Added.
10216 (EmitContext.SetVariableAssigned): Added.
10217 (EmitContext.IsParameterAssigned): Added.
10218 (EmitContext.SetParameterAssigned): Added.
10219 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
10220 Added control flow analysis stuff here.
10222 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
10223 resolve the expression as lvalue.
10224 (LocalVariableReference.DoResolve): Check whether the variable has
10225 already been assigned.
10226 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
10227 the parameter as assigned here.
10228 (ParameterReference.DoResolve): Check whether the parameter has already
10230 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
10231 expression as lvalue.
10233 * statement.cs (FlowBranching): New class for the flow analysis code.
10234 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
10235 (LabeledStatement.IsDefined): New public property.
10236 (LabeledStatement.AddUsageVector): New public method to tell flow
10237 analyis that the label may be reached via a forward jump.
10238 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
10240 (VariableInfo.Number): New public field. This is used by flow analysis
10241 to number all locals of a block.
10242 (Block.CountVariables): New public property. This is the number of
10243 local variables in this block (including the locals from all parent
10245 (Block.EmitMeta): Number all the variables.
10247 * statement.cs: Added flow analysis support to all classes.
10249 2002-07-31 Martin Baulig <martin@gnome.org>
10251 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
10252 To get debugging messages, compile mcs with /define:MCS_DEBUG and
10253 then use this argument.
10255 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
10257 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
10258 use this to specify /define options.
10260 2002-07-29 Martin Baulig <martin@gnome.org>
10262 * statement.cs (Fixed): Moved all code that does variable lookups
10263 and resolvings from Emit to Resolve.
10265 * statement.cs (For): Moved all code that does variable lookups
10266 and resolvings from Emit to Resolve.
10268 * statement.cs (Using): Moved all code that does variable lookups
10269 and resolvings from Emit to Resolve.
10271 2002-07-29 Martin Baulig <martin@gnome.org>
10273 * attribute.cs (Attribute.Resolve): Explicitly catch a
10274 System.NullReferenceException when creating the
10275 CustromAttributeBuilder and report a different warning message.
10277 2002-07-29 Martin Baulig <martin@gnome.org>
10279 * support.cs (ParameterData.ParameterName): Added method to
10280 get the name of a parameter.
10282 * typemanager.cs (TypeManager.IsValueType): New public method.
10284 2002-07-29 Martin Baulig <martin@gnome.org>
10286 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
10287 is a flag which specifies that it's either ref or out.
10288 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
10289 the out parameter to `out Parameter.Modifier mod', also set the
10290 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
10292 * support.cs (InternalParameters.ParameterModifier): Distinguish
10293 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10294 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10296 * expression.cs (Argument.GetParameterModifier): Distinguish
10297 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10298 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10300 2002-07-29 Martin Baulig <martin@gnome.org>
10302 * expression.cs (ParameterReference.ParameterReference): Added
10303 `Location loc' argument to the constructor.
10305 * cs-parser.jay: Pass location to ParameterReference.
10307 2002-07-28 Miguel de Icaza <miguel@ximian.com>
10309 * statement.cs (Try): Initialize the location.
10311 * cs-parser.jay: pass location to Try.
10313 * expression.cs (Unary.Reduce): Change the prototype to return
10314 whether a constant fold could be performed or not. The result is
10315 returned in an out parameters. In the case of Indirection and
10316 AddressOf, we want to perform the full tests.
10318 2002-07-26 Miguel de Icaza <miguel@ximian.com>
10320 * statement.cs (Statement.Emit): Flag dead code.
10322 2002-07-27 Andrew Birkett <andy@nobugs.org>
10324 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
10326 2002-07-27 Martin Baulig <martin@gnome.org>
10328 * class.cs (MethodData.Define): Put back call to
10329 TypeManager.AddMethod(), accidentally commented this out.
10331 * report.cs (Debug): New public method to print debugging information,
10332 this is `[Conditional ("DEBUG")]'.
10334 2002-07-26 Martin Baulig <martin@gnome.org>
10336 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10337 (switch_statement): Push the current_block to the switch_stack and
10338 pop it again when we're done with the switch.
10339 (switch_section): The new block is a child of the current_block.
10340 Fixes bug #24007, added test-152.cs.
10342 2002-07-27 Martin Baulig <martin@gnome.org>
10344 * expression.cs (Invocation.EmitArguments): When calling a varargs
10345 function with only its fixed arguments, we need to pass an empty
10348 2002-07-27 Martin Baulig <martin@gnome.org>
10350 Mono 0.13 has been released.
10352 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10354 * driver.cs: Rename --resource to --linkres, because that is what
10355 we do currently, we dont support --resource yet.
10357 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10359 2002-07-25 Martin Baulig <martin@gnome.org>
10361 * class.cs (MethodData): New public class. This is a `method builder'
10362 class for a method or one accessor of a Property/Indexer/Event.
10363 (MethodData.GetMethodFlags): Moved here from MemberBase.
10364 (MethodData.ApplyAttributes): Likewise.
10365 (MethodData.ApplyObsoleteAttribute): Likewise.
10366 (MethodData.ApplyConditionalAttribute): Likewise.
10367 (MethodData.ApplyDllImportAttribute): Likewise.
10368 (MethodData.CheckAbstractAndExternal): Likewise.
10369 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10370 (MethodData.Emit): Formerly known as Method.Emit().
10371 (MemberBase): Moved everything which was specific to a single
10372 accessor/method to MethodData.
10373 (Method): Create a new MethodData and call Define() and Emit() on it.
10374 (Property, Indexer, Event): Create a new MethodData objects for each
10375 accessor and call Define() and Emit() on them.
10377 2002-07-25 Martin Baulig <martin@gnome.org>
10379 Made MethodCore derive from MemberBase to reuse the code from there.
10380 MemberBase now also checks for attributes.
10382 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10383 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10385 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10386 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10387 (MemberBase.ApplyAttributes): New virtual method; applies the
10388 attributes to a method or accessor.
10389 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10390 (MemberBase.ApplyConditionalAttribute): Likewise.
10391 (MemberBase.ApplyDllImportAttribute): Likewise.
10392 (MemberBase.CheckAbstractAndExternal): Likewise.
10393 (MethodCore.ParameterTypes): This is now a property instead of a
10394 method, it's initialized from DoDefineParameters().
10395 (MethodCore.ParameterInfo): Removed the set accessor.
10396 (MethodCore.DoDefineParameters): New protected virtual method to
10397 initialize ParameterTypes and ParameterInfo.
10398 (Method.GetReturnType): We can now simply return the MemberType.
10399 (Method.GetMethodFlags): Override the MemberBase version and add
10400 the conditional flags.
10401 (Method.CheckBase): Moved some code from Define() here, call
10402 DoDefineParameters() here.
10403 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10404 here to avoid some larger code duplication.
10405 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10406 ensure that abstract and external accessors don't declare a body.
10408 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10409 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10410 lookup in the attribute's parent classes, so we need to abort as soon
10411 as we found the first match.
10412 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10413 the attribute has no arguments.
10415 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10418 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10420 * cs-parser.jay: reverted previous patch.
10422 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10424 * cs-parser.jay: fixed bug #22119.
10426 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10428 * attribute.cs: fixed compilation. The error was:
10429 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10430 be assigned to before control leaves the current method."
10431 [FIXME: Filed as bug #28186: MCS must report this error.]
10433 2002-07-25 Martin Baulig <martin@gnome.org>
10435 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10436 method to pull the condition name ouf of a Conditional attribute.
10437 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10438 the obsolete message and error flag out of an Obsolete attribute.
10440 * class.cs (Method.GetMethodFlags): New public method to get the
10441 TypeManager.MethodFlags for this method.
10442 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10444 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10445 if we're overriding a virtual function, set the new private variable
10446 `parent_method'; call the new TypeManager.AddMethod().
10448 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10449 the MethodBuilder and the Method in a PtrHashtable.
10450 (TypeManager.builder_to_method): Added for this purpose.
10451 (TypeManager.MethodFlags): Added IsObsoleteError.
10452 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10453 Obsolete and Conditional arguments in MethodBuilders. If we discover
10454 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10455 the message from the attribute.
10457 2002-07-24 Martin Baulig <martin@gnome.org>
10459 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10460 preprocessor directives, ensure that the argument to #define/#undef is
10461 exactly one identifier and that it's actually an identifier.
10463 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10466 2002-07-24 Martin Baulig <martin@gnome.org>
10468 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10469 initialize it to TypeManager.object_type in the constructor.
10470 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10471 of the `hm.get_current' method if we're using the collection pattern.
10472 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10473 for the explicit conversion to make it work when we're using the collection
10474 pattern and the `Current' property has a different return type than `object'.
10477 2002-07-24 Martin Baulig <martin@gnome.org>
10479 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10480 does not match, but don't report any errors. This method is called in
10481 order for all methods in a MethodGroupExpr until a matching method is
10482 found, so we don't want to bail out if the first method doesn't match.
10483 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10484 matches, report the 123. Fixes #28070.
10486 2002-07-24 Martin Baulig <martin@gnome.org>
10488 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10489 TypeManager.TypeToCoreType() to the top of the method so the
10490 following equality checks will work. Fixes #28107.
10492 2002-07-24 Martin Baulig <martin@gnome.org>
10494 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10495 operand is of type uint, and the other operand is of type sbyte,
10496 short or int, the operands are converted to type long." -
10497 Actually do what this comment already told us. Fixes bug #28106,
10500 2002-07-24 Martin Baulig <martin@gnome.org>
10502 * class.cs (MethodBase): New abstract class. This is now a base
10503 class for Property, Indexer and Event to avoid some code duplication
10504 in their Define() and DefineMethods() methods.
10505 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10506 generic methods for Define() and DefineMethods().
10507 (FieldBase): Derive from MemberBase, not MemberCore.
10508 (Property): Derive from MemberBase, not MemberCore.
10509 (Property.DefineMethod): Moved all the code from this method to the
10510 new MethodBase.DefineAccessor(), just call it with appropriate
10512 (Property.Define): Call the new Property.DoDefine(), this does some
10513 sanity checks and we don't need to duplicate the code everywhere.
10514 (Event): Derive from MemberBase, not MemberCore.
10515 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10516 accessors, this will also make them work with interface events.
10517 (Indexer): Derive from MemberBase, not MemberCore.
10518 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10519 (Indexer.Define): Use the new MethodBase functions.
10521 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10522 argument to the constructor.
10523 (Interface.FindMembers): Added support for interface events.
10524 (Interface.PopluateEvent): Implemented.
10526 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10528 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10530 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10531 but this is required to check for a method name being the same as
10532 the containing class.
10536 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10538 * interface.cs: initialize variable.
10540 2002-07-23 Martin Baulig <martin@gnome.org>
10542 Implemented the IndexerName attribute in interfaces.
10544 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10545 name if this is an explicit interface implementation.
10546 (Indexer.InterfaceIndexerName): New public variable. If we're
10547 implementing an interface indexer, this is the IndexerName in that
10548 interface. Otherwise, it's the IndexerName.
10549 (Indexer.DefineMethod): If we're implementing interface indexer,
10550 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10551 and Pending.ImplementIndexer methods.
10552 (Indexer.Define): Also define the PropertyBuilder if we're
10553 implementing an interface indexer and this is neither an explicit
10554 interface implementation nor do the IndexerName match the one in
10557 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10558 If a method is defined here, then we always need to create a proxy
10559 for it. This is used when implementing interface indexers.
10560 (Pending.IsInterfaceIndexer): New public method.
10561 (Pending.ImplementIndexer): New public method.
10562 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10563 This is used when implementing interface indexers to define a proxy
10565 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10566 define a proxy if necessary.
10568 * interface.cs (Interface.IndexerName): New public variable.
10569 (Interface.PopulateIndexer): Set the IndexerName.
10570 (Interface.DefineIndexers): New private method. Populate all the
10571 indexers and make sure their IndexerNames match.
10573 * typemanager.cs (IndexerPropertyName): Added support for interface
10576 2002-07-22 Martin Baulig <martin@gnome.org>
10578 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10579 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10580 ret if HasReturnLabel.
10581 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10584 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10585 and set the ec.LoopBeginTryCatchLevel.
10586 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10587 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10588 the current ec.TryCatchLevel, the branch goes out of an exception
10589 block. In this case, we need to use Leave and not Br.
10591 2002-07-22 Martin Baulig <martin@gnome.org>
10593 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10594 block unless the block does not always return or it is contained in
10595 another try { ... } catch { ... } block. Fixes bug #26506.
10596 Added verify-1.cs to the test suite.
10598 2002-07-22 Martin Baulig <martin@gnome.org>
10600 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10601 then we do not always return. Fixes bug #24985.
10603 2002-07-22 Martin Baulig <martin@gnome.org>
10605 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10606 lookup on a per-class level; ie. walk up the class hierarchy until we
10607 found at least one applicable method, then choose the best among them.
10608 Fixes bug #24463 and test-29.cs.
10610 2002-07-22 Martin Baulig <martin@gnome.org>
10612 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10613 return types of the methods. The return type is not part of the
10614 signature and we must not check it to make the `new' modifier work.
10615 Fixes bug #27999, also added test-147.cs.
10616 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10618 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10619 on the method's return type.
10621 2002-07-21 Martin Baulig <martin@gnome.org>
10623 * assign.cs: Make this work if the rightmost source is a constant and
10624 we need to do an implicit type conversion. Also adding a few more tests
10625 to test-38.cs which should have caught this.
10627 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10628 target in the makefile for this. The makefile.gnu is primarily intended
10629 for end-users who don't want to debug the compiler.
10631 2002-07-21 Martin Baulig <martin@gnome.org>
10633 * assign.cs: Improved the Assign class so it can now handle embedded
10634 assignments (X = Y = Z = something). As a side-effect this'll now also
10635 consume less local variables. test-38.cs now passes with MCS, added
10636 a few new test cases to that test.
10638 2002-07-20 Martin Baulig <martin@gnome.org>
10640 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10641 instructions. Fixes bug #27977, also added test-146.cs.
10643 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10645 * cs-tokenizer.cs: fixed getHex ().
10647 2002-07-19 Martin Baulig <martin@gnome.org>
10649 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10650 not Type.GetType() to lookup the array type. This is needed when
10651 we're constructing an array of a user-defined type.
10652 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10653 single-dimensional arrays, but also for single-dimensial arrays of
10656 2002-07-19 Martin Baulig <martin@gnome.org>
10658 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10659 this function is called, it's not allowed to share LocalBuilders
10660 among ILGenerators.
10662 2002-07-19 Martin Baulig <martin@gnome.org>
10664 * expression.cs (Argument.Resolve): Report an error 118 when trying
10665 to pass a type as argument.
10667 2002-07-18 Martin Baulig <martin@gnome.org>
10669 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10670 Conv_R_Un for the signed `long' type.
10672 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10674 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10675 `expr' for the temporary result, as that will fail if we do
10676 multiple resolves on the same expression.
10678 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10680 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10681 ec.TypeContainer for looking up aliases.
10683 * class.cs (TypeContainer): Remove LookupAlias from here.
10685 * decl.cs (DeclSpace); Move here.
10687 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10689 * class.cs (FindMembers): Only call filter if the constructor
10690 bulider is not null.
10692 Also handle delegates in `NestedTypes' now. Now we will perform
10693 type lookups using the standard resolution process. This also
10696 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10697 This uses Expressions (the limited kind that can be parsed by the
10698 tree) instead of strings.
10700 * expression.cs (ComposedCast.ToString): Implement, used to flag
10701 errors since now we have to render expressions.
10703 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10706 * ecore.cs (SimpleName.ToString): ditto.
10708 * cs-parser.jay: Instead of using strings to assemble types, use
10709 Expressions to assemble the type (using SimpleName, ComposedCast,
10710 MemberAccess). This should fix the type lookups in declarations,
10711 because we were using a different code path for this.
10713 * statement.cs (Block.Resolve): Continue processing statements
10714 even when there is an error.
10716 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10718 * class.cs (Event.Define): Also remove the `remove' method from
10719 the list of pending items.
10721 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10722 generate more compact code.
10724 2002-07-17 Martin Baulig <martin@gnome.org>
10726 * const.cs (Const.LookupConstantValue): Add support for constant
10727 `unchecked' and `checked' expressions.
10728 Also adding test case test-140.cs for this.
10730 2002-07-17 Martin Baulig <martin@gnome.org>
10732 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10733 check whether mi.ReturnType implements the IEnumerator interface; the
10734 `==' and the IsAssignableFrom() will fail in this situation.
10736 2002-07-16 Ravi Pratap <ravi@ximian.com>
10738 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10741 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10743 * expression.cs: fixed bug #27811.
10745 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10747 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10748 Molaro: when we are a ref, the value already contains a pointer
10749 value, do not take the address of it.
10751 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10752 * removed mb-parser.jay and mb-tokenizer.cs
10754 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10756 * expression.cs: check against the building corlib void type.
10758 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10760 * ecore.cs: fix for valuetype static readonly fields: when
10761 initializing them, we need their address, not the address of a copy.
10763 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10765 * typemanager.cs: register also enum_type in corlib.
10767 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10769 * class.cs: allow calling this (but not base) initializers in structs.
10771 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10773 * ecore.cs: make sure we compare against the building base types
10776 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10778 * typemanager.cs: fix TypeToCoreType() to handle void and object
10779 (corlib gets no more typerefs after this change).
10781 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10783 * expression.cs (ArrayCreation.EmitArrayArguments): use
10784 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10786 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10787 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10788 array indexes, the runtime actually forbids them.
10790 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10791 for array arguments here.
10793 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10794 instead of the default for ValueTypes.
10796 (New.DoEmit): Use IsValueType instead of
10797 IsSubclassOf (value_type)
10798 (New.DoResolve): ditto.
10799 (Invocation.EmitCall): ditto.
10801 * assign.cs (Assign): ditto.
10803 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10804 Statements *are* currently doing part of their resolution during
10807 Expressions do always resolve during resolve, but statements are
10808 only required to propagate resolution to their children.
10810 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10812 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10814 (LoadAssembly): Do not add the dll if it is already specified
10816 (MainDriver): Add the System directory to the link path at the end,
10817 after all the other -L arguments.
10819 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10820 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10821 ldelem.u1) and using the opposite for sbytes.
10823 This fixes Digger, and we can finally run it.
10825 * driver.cs (UnixParseOption): Move the option parsing here.
10826 (CSCParseOption): Implement CSC-like parsing of options.
10828 We now support both modes of operation, the old Unix way, and the
10829 new CSC-like way. This should help those who wanted to make cross
10830 platform makefiles.
10832 The only thing broken is that /r:, /reference: and /lib: are not
10833 implemented, because I want to make those have the same semantics
10834 as the CSC compiler has, and kill once and for all the confussion
10835 around this. Will be doing this tomorrow.
10837 * statement.cs (Unsafe.Resolve): The state is checked during
10838 resolve, not emit, so we have to set the flags for IsUnsfe here.
10840 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10842 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10843 not catch the Error_ObjectRefRequired in SimpleName (as it is
10844 possible to have a class/instance variable name that later gets
10845 deambiguated), we have to check this here.
10847 2002-07-10 Ravi Pratap <ravi@ximian.com>
10849 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10850 make static and put into Expression.
10852 (Event.Define): Register the private field of the event with the
10853 TypeManager so that GetFieldFromEvent can get at it.
10855 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10856 keep track of the private field associated with an event which
10859 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
10862 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
10864 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10866 * expression.cs (Binary.EmitBranchable): this routine emits the
10867 Binary expression in a branchable context. This basically means:
10868 we need to branch somewhere, not just get the value on the stack.
10870 This works together with Statement.EmitBoolExpression.
10872 * statement.cs (Statement.EmitBoolExpression): Use
10875 2002-07-09 Miguel de Icaza <miguel@ximian.com>
10877 * statement.cs (For): Reduce the number of jumps in loops.
10879 (For): Implement loop inversion for the For statement.
10881 (Break): We can be breaking out of a Try/Catch controlled section
10882 (foreach might have an implicit try/catch clause), so we need to
10883 use Leave instead of Br.
10885 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
10886 now). If the instace expression supports IMemoryLocation, we use
10887 the AddressOf method from the IMemoryLocation to extract the
10888 address instead of emitting the instance.
10890 This showed up with `This', as we were emitting the instance
10891 always (Emit) instead of the Address of This. Particularly
10892 interesting when This is a value type, as we dont want the Emit
10893 effect (which was to load the object).
10895 2002-07-08 Miguel de Icaza <miguel@ximian.com>
10897 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
10899 * statement.cs (Checked): Set the CheckedState during the resolve
10900 process too, as the ConvCast operations track the checked state on
10901 the resolve process, and not emit.
10903 * cs-parser.jay (namespace_member_declaration): Flag that we have
10904 found a declaration when we do. This is used to flag error 1529
10906 * driver.cs: Report ok when we display the help only.
10908 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
10910 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
10912 2002-07-04 Miguel de Icaza <miguel@ximian.com>
10914 * cs-tokenizer.cs (define): We also have to track locally the
10915 defines. AllDefines is just used for the Conditional Attribute,
10916 but we also need the local defines for the current source code.
10918 2002-07-03 Miguel de Icaza <miguel@ximian.com>
10920 * statement.cs (While, For, Do): These loops can exit through a
10921 Break statement, use this information to tell whether the
10922 statement is the last piece of code.
10924 (Break): Flag that we break.
10926 * codegen.cs (EmitContexts): New `Breaks' state variable.
10928 2002-07-03 Martin Baulig <martin@gnome.org>
10930 * class.cs (TypeContainer.MethodModifiersValid): Allow override
10931 modifiers in method declarations in structs. Otherwise, you won't
10932 be able to override things like Object.Equals().
10934 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10936 * class.cs (Method, Property, Indexer): Do not allow the public
10937 modifier to be used in explicit interface implementations.
10939 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
10940 override modifiers in method declarations in structs
10942 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
10944 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
10945 integer or real overflow, report an error
10947 2002-07-02 Martin Baulig <martin@gnome.org>
10949 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
10950 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
10951 to tell the runtime about our newly created System.Object and
10952 System.ValueType types.
10954 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10956 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
10957 struct instead of Ldarg/Starg.
10959 2002-07-02 Martin Baulig <martin@gnome.org>
10961 * expression.cs (Indirection.Indirection): Call
10962 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
10964 2002-07-02 Martin Baulig <martin@gnome.org>
10966 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
10967 ValueType, call TypeManager.TypeToCoreType() on it.
10968 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
10969 the OpCodes.Newarr argument.
10971 2002-07-02 Martin Baulig <martin@gnome.org>
10973 * expression.cs (Invocation.EmitCall): When compiling corlib,
10974 replace all calls to the system's System.Array type to calls to
10975 the newly created one.
10977 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
10978 System.Array methods.
10979 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
10980 from the system's System.Array type which must be replaced.
10982 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
10984 * typemanager.cs: load unverifiable_code_ctor so we can build
10985 corlib using the correct type. Avoid using GetTypeCode() with
10987 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
10988 TypeManager.object_type to allow building corlib.
10990 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
10992 * ecore.cs: handle System.Enum separately in LoadFromPtr().
10994 2002-07-01 Martin Baulig <martin@gnome.org>
10996 * class.cs: Make the last change actually work, we need to check
10997 whether `ifaces != null' to avoid a crash.
10999 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11001 * class.cs: when we build structs without fields that implement
11002 interfaces, we need to add the interfaces separately, since there is
11003 no API to both set the size and add the interfaces at type creation
11006 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11008 * expression.cs: the dimension arguments to the array constructors
11009 need to be converted if they are a long.
11011 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
11013 * class.cs: don't emit ldarg.0 if there is no parent constructor
11014 (fixes showstopper for corlib).
11016 2002-06-29 Martin Baulig <martin@gnome.org>
11018 MCS now compiles corlib on GNU/Linux :-)
11020 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
11021 ie. check for MethodImplOptions.InternalCall.
11023 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
11024 and TypeManager.attribute_type are null, so we must explicitly check
11025 whether parent is not null to find out whether it's an attribute type.
11026 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
11027 and SetBuilder, not only if the property is neither abstract nor external.
11028 This is necessary to set the MethodImplOptions on the accessor methods.
11029 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
11030 SetBuilder, see Property.Emit().
11032 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
11033 populate "System.Object", "System.ValueType" and "System.Attribute" since
11034 they've already been populated from BootCorlib_PopulateCoreTypes().
11036 2002-06-29 Martin Baulig <martin@gnome.org>
11038 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
11039 is the NullLiteral, we also need to make sure that target_type is not
11042 2002-06-29 Martin Baulig <martin@gnome.org>
11044 * rootcontext.cs (RootContext.ResolveCore): We must initialize
11045 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
11046 before calling BootstrapCorlib_ResolveDelegate ().
11048 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11050 * statement.cs: fixed build-breaker. All tests passed ok.
11052 2002-06-27 Martin Baulig <martin@gnome.org>
11054 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
11055 for System.Decimal when compiling corlib.
11057 2002-06-27 Martin Baulig <martin@gnome.org>
11059 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
11060 switch blocks which contain nothing but a default clause.
11062 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
11064 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
11066 2002-06-27 Martin Baulig <martin@gnome.org>
11068 * ecore.cs (PropertyExpr.PropertyExpr): Call
11069 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
11071 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
11072 is already a TypeBuilder.
11074 2002-06-27 Martin Baulig <martin@gnome.org>
11076 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
11077 `target_type == TypeManager.array_type', not IsAssignableFrom() in
11078 the "from an array-type to System.Array" case. This makes it work
11079 when compiling corlib.
11081 2002-06-27 Martin Baulig <martin@gnome.org>
11083 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
11084 non-static PropertyExpr, set its InstanceExpression. This makes
11085 the `ICollection.Count' property work in System/Array.cs.
11087 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
11089 * driver.cs: Made error handling more consistent. Errors now
11090 tracked by Report class, so many methods which used to return int
11091 now return void. Main() now prints success/failure and
11092 errors/warnings message.
11094 Renamed '--probe' compiler argument to '--expect-error'. Removed
11095 the magic number return values (123 and 124). Now, if the
11096 expected error occurs, the compiler exits with success (exit value
11097 0). If the compilation completes without seeing that particular
11098 error, the compiler exits with failure (exit value 1). The
11099 makefile in mcs/errors has been changed to handle the new behaviour.
11101 * report.cs: Made 'expected error' number a property and renamed
11102 it from 'Probe' to 'ExpectedError'.
11104 * genericparser.cs: Removed error handling support, since it is
11105 now all done by Report class.
11107 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
11108 class, so parse() no longer returns an int.
11110 * namespace.cs: Use Report.Error instead of GenericParser.error
11112 2002-06-22 Miguel de Icaza <miguel@ximian.com>
11114 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
11115 TypeContainer.AddOperator): At the front of the list put the
11116 explicit implementations, so they get resolved/defined first.
11118 2002-06-21 Miguel de Icaza <miguel@ximian.com>
11120 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
11121 interface type is implemented by this TypeContainer. Used during
11122 explicit interface implementation.
11124 (Property.Define, Indexer.Define, Method.Define): Validate that
11125 the given interface in the explicit implementation is one of the
11126 base classes for the containing type.
11128 Also if we are explicitly implementing an interface, but there is
11129 no match in the pending implementation table, report an error.
11131 (Property.Define): Only define the property if we are
11132 not explicitly implementing a property from an interface. Use the
11133 correct name also for those properties (the same CSC uses,
11134 although that is really not needed).
11136 (Property.Emit): Do not emit attributes for explicitly implemented
11137 properties, as there is no TypeBuilder.
11139 (Indexer.Emit): ditto.
11141 Hiding then means that we do not really *implement* a pending
11142 implementation, which makes code fail.
11144 2002-06-22 Martin Baulig <martin@gnome.org>
11146 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
11147 the return value of Object.GetType(). [FIXME: we need to do this whenever
11148 we get a type back from the reflection library].
11150 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
11152 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
11154 2002-06-20 Miguel de Icaza <miguel@ximian.com>
11156 * attribute.cs: Return null if we can not look up the type.
11158 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
11159 the interface types found.
11161 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
11162 interface types found.
11164 * typemanager.cs (GetInterfaces): Make this routine returns alll
11165 the interfaces and work around the lame differences between
11166 System.Type and System.Reflection.Emit.TypeBuilder in the results
11167 result for GetInterfaces.
11169 (ExpandInterfaces): Given an array of interface types, expand and
11170 eliminate repeated ocurrences of an interface. This expands in
11171 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
11174 2002-06-21 Martin Baulig <martin@gnome.org>
11176 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
11179 2002-06-21 Martin Baulig <martin@gnome.org>
11181 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
11182 and called with one of the core types, return the corresponding typebuilder for
11185 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
11188 2002-06-21 Martin Baulig <martin@gnome.org>
11190 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
11191 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
11192 (Expression.ConvertReferenceExplicit): Likewise.
11194 * expression.cs (ElementAccess.DoResolve): Likewise.
11195 (ElementAccess.DoResolveLValue): Likewise.
11197 2002-06-10 Martin Baulig <martin@gnome.org>
11199 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
11200 add the "value" parameter to the parameter list.
11202 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
11205 2002-06-19 Miguel de Icaza <miguel@ximian.com>
11207 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
11208 the argument to an int, uint, long or ulong, per the spec. Also
11209 catch negative constants in array creation.
11211 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
11213 * class.cs: do not allow the same interface to appear twice in
11214 the definition list.
11216 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
11218 * ecore.cs: don't use ldlen with System.Array.
11220 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
11222 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
11224 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
11226 * modifiers.cs: produce correct field attributes for protected
11227 internal. Easy fix so miguel can work on ther harder stuff:-)
11229 2002-06-18 Miguel de Icaza <miguel@ximian.com>
11231 * pending.cs: New file. Move the code from class.cs here.
11232 Support clearning the pending flag for all methods (when not doing
11233 explicit interface implementation).
11235 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
11237 * rootcontext.cs: added a couple more types needed to bootstrap.
11239 2002-06-17 Miguel de Icaza <miguel@ximian.com>
11241 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
11242 constructor in the type, instead of any constructor in the type
11243 hierarchy. Thanks to Paolo for finding this bug (it showed up as
11244 a bug in the Mono runtime when applying the params attribute).
11246 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11247 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
11249 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
11251 * expression.cs (Unary.ResolveOperator): Use TypeManager
11252 to resolve the type.
11254 2002-06-13 Ravi Pratap <ravi@ximian.com>
11256 * cs-parser.jay (enum_member_declaration): Pass in the attributes
11259 * enum.cs (AddEnumMember): Add support to store the attributes associated
11260 with each member too.
11262 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
11263 field builders too - this takes care of the enum member case.
11265 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
11267 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
11268 address-of operator on both value types and pointers.
11270 2002-06-10 Martin Baulig <martin@gnome.org>
11272 * interface.cs (Interface.PopulateIndexer): Add the indexer's
11273 PropertyBuilder to the `property_builders' list.
11275 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
11276 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
11277 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
11278 find any indexers which are inherited from an interface.
11280 2002-06-09 Martin Baulig <martin@gnome.org>
11282 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
11283 the same type as the constant if necessary. There's also a test-130.cs
11286 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
11288 * typemanager.cs (TypeManager.ChangeType): Previously known as
11289 Enum.ChangeEnumType().
11291 2002-06-09 Martin Baulig <martin@gnome.org>
11293 * expression.cs (Cast.TryReduce): Added support for consts.
11295 2002-06-08 Ravi Pratap <ravi@ximian.com>
11297 * class.cs (Accessor): Hold attributes information so we can pass
11300 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
11301 Modify to pass in attributes attached to the methods.
11303 (add_accessor_declaration, remove_accessor_declaration): Ditto.
11305 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
11306 to handle the Accessor kind :-)
11308 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
11310 2002-06-08 Martin Baulig <martin@gnome.org>
11312 * expression.cs (Unary.TryReduceNegative): Added support for
11315 2002-06-08 Martin Baulig <martin@gnome.org>
11317 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
11318 name can't be found in the `defined_names' - the caller will do a
11319 MemberLookup in this case and thus find methods in System.Enum
11320 such as Enum.IsDefined().
11322 2002-06-08 Martin Baulig <martin@gnome.org>
11324 * enum.cs (Enum.ChangeEnumType): This is a custom version of
11325 Convert.ChangeType() which works with TypeBuilder created types.
11326 (Enum.LookupEnumValue, Enum.Define): Use it here.
11328 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
11329 `TypeBuilder.BaseType != null' check.
11330 (TypeContainer.FindMembers): Only lookup parent members if we
11331 actually have a parent.
11332 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11333 (ConstructorInitializer.Resolve): Likewise.
11335 * interface.cs (Interface.FindMembers): Added
11336 `TypeBuilder.BaseType != null' check.
11338 * rootcontext.cs (RootContext.ResolveCore): Added
11339 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11340 classes_second_stage.
11342 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11343 debug_type and trace_type when compiling with --nostdlib.
11345 2002-06-07 Martin Baulig <martin@gnome.org>
11347 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11348 (AddField): Set it to true when adding a non-static field.
11349 (DefineType): Use `have_nonstatic_fields' to find out whether we
11350 have non-static fields, not `Fields != null'.
11352 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11354 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11355 dereferencing a null on the static-field code path)
11357 2002-05-30 Martin Baulig <martin@gnome.org>
11359 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11360 to take command line arguments. Use reflection to call the new
11361 custom `Initialize' function on the symbol writer and pass it the
11362 command line arguments.
11364 * driver.cs (--debug-args): New command line argument to pass command
11365 line arguments to the symbol writer.
11367 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11369 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11370 the target type for indexers and properties. Thanks to Joe for
11373 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11375 * typemanager.cs (MethodFlags): returns the method flags
11376 (Obsolete/ShouldIgnore) that control warning emission and whether
11377 the invocation should be made, or ignored.
11379 * expression.cs (Invocation.Emit): Remove previous hack, we should
11380 not do this on matching a base type, we should do this based on an attribute
11382 Only emit calls to System.Diagnostics.Debug and
11383 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11384 on the command line.
11386 * rootcontext.cs: Global settings for tracing and debugging.
11388 * cs-tokenizer.cs (define): New utility function to track
11389 defines. Set the global settings for TRACE and DEBUG if found.
11391 2002-05-25 Ravi Pratap <ravi@ximian.com>
11393 * interface.cs (Populate*): Pass in the TypeContainer as well as
11394 the DeclSpace as parameters so that we can create EmitContexts and
11395 then use that to apply attributes etc.
11397 (PopulateMethod, PopulateEvent, PopulateProperty)
11398 (PopulateIndexer): Apply attributes everywhere.
11400 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11403 (ApplyAttributes): Update accordingly.
11405 We now apply interface attributes for all members too.
11407 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11409 * class.cs (Indexer.Define); Correctly check if we are explicit
11410 implementation (instead of checking the Name for a ".", we
11411 directly look up if the InterfaceType was specified).
11413 Delay the creation of the PropertyBuilder.
11415 Only create the PropertyBuilder if we are not an explicit
11416 interface implementation. This means that explicit interface
11417 implementation members do not participate in regular function
11418 lookups, and hence fixes another major ambiguity problem in
11419 overload resolution (that was the visible effect).
11421 (DefineMethod): Return whether we are doing an interface
11424 * typemanager.cs: Temporary hack until we get attributes in
11425 interfaces (Ravi is working on that) and we get IndexerName
11426 support in interfaces.
11428 * interface.cs: Register the indexers as properties.
11430 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11431 warning, I have verified that this is a bug in the .NET runtime
11432 (JavaScript suffers of the same problem).
11434 * typemanager.cs (MemberLookup): When looking up members for
11435 interfaces, the parent of an interface is the implicit
11436 System.Object (so we succeed in searches of Object methods in an
11437 interface method invocation. Example: IEnumerable x; x.ToString
11440 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11442 * class.cs (Event): Events should also register if they do
11443 implement the methods that an interface requires.
11445 * typemanager.cs (MemberLookup); use the new GetInterfaces
11448 (GetInterfaces): The code used to lookup interfaces for a type is
11449 used in more than one place, factor it here.
11451 * driver.cs: Track the errors at the bottom of the file, we kept
11454 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11455 instance if the method we are calling is static!
11457 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11459 * attribute.cs (ApplyAttributes): Make this function filter out
11460 the IndexerName attribute (as that attribute in reality is never
11461 applied) and return the string constant for the IndexerName
11464 * class.cs (TypeContainer.Emit): Validate that all the indexers
11465 have the same IndexerName attribute, and if so, set the
11466 DefaultName attribute on the class.
11468 * typemanager.cs: The return value might contain other stuff (not
11469 only methods). For instance, consider a method with an "Item"
11470 property and an Item method.
11472 * class.cs: If there is a problem with the parameter types,
11475 2002-05-24 Ravi Pratap <ravi@ximian.com>
11477 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11478 looks at user defined conversion after making a call to
11479 StandardConversionExists - we need this for overload resolution.
11481 * expression.cs : Update accordingly the various method calls.
11483 This fixes 2 bugs filed against implicit user defined conversions
11485 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11487 * statement.cs: Track the result of the assignment.
11489 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11491 * expression.cs (MemberAccess): Improved error reporting for
11492 inaccessible members.
11494 2002-05-22 Martin Baulig <martin@gnome.org>
11496 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11497 itself with debugging support.
11499 2002-05-22 Martin Baulig <martin@gnome.org>
11501 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11502 Removed, this isn't needed anymore.
11504 2002-05-20 Martin Baulig <martin@gnome.org>
11506 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11507 be underlying type for an enum.
11509 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11511 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11512 that splits out the loading of just the core types.
11514 * rootcontext.cs (ResolveCore): Split the struct resolution in
11515 two, so we can load the enumeration underlying types before any
11518 * expression.cs (Is): Bandaid until we fix properly Switch (see
11519 bug #24985 for details).
11521 * typemanager.cs (ImplementsInterface): The hashtable will contain
11522 a null if there are no interfaces implemented.
11524 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11526 * cs-parser.jay (indexer_declarator): It is fine to have array
11529 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11531 * typemanager.cs: (RegisterBuilder): New function used to register
11532 TypeBuilders that implement interfaces. Since
11533 TypeBuilder.GetInterfaces (as usual) does not work with lame
11535 (AddUserType): register interfaces.
11537 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11538 dealing with TypeBuilder. Also, arrays are showing up as
11539 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11540 methods can not be invoked on them!
11542 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11543 (ImplicitReferenceConversionExists): Split out from
11544 StandardConversionExists.
11546 * expression.cs (As): We were only implementing one of the three
11547 cases for the as operator. We now implement them all.
11548 (Is): Implement the various other cases for Is as well.
11550 * typemanager.cs (CACHE): New define used to control if we want or
11551 not the FindMembers cache. Seems to have a negative impact on
11552 performance currently
11554 (MemberLookup): Nested types have full acess to
11555 enclosing type members
11557 Remove code that coped with instance/static returns for events, we
11558 now catch this in RealFindMembers.
11560 (RealFindMembers): only perform static lookup if the instance
11561 lookup did not return a type or an event.
11563 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11565 * assign.cs (CompoundAssign): We pass more semantic information
11566 now to Compound Assignments than we did before: now we have all
11567 the information at hand, and now we resolve the target *before* we
11568 do the expression expansion, which allows the "CacheValue" method
11569 to have the effect we intended (before, a [x] += 1 would generate
11570 two differen ArrayAccess expressions from the ElementAccess,
11571 during the resolution process).
11573 (CompoundAssign.DoResolve): Resolve target and original_source here.
11575 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11577 * expression.cs (ArrayAccess): dropped debugging information.
11579 * typemanager.cs: Small bug fix: I was always returning i_members,
11580 instead of one of i_members or s_members (depending on which had
11583 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11584 method is invoked before any code generation takes place, and it
11585 is a mechanism to inform that the expression will be invoked more
11586 than once, and that the method should use temporary values to
11587 avoid having side effects
11589 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11591 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11594 * expression.cs (Indirection, ArrayAccess): Add support for
11595 CacheTemporaries in these two bad boys.
11597 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11598 ldobj or ldind_ref.
11599 (StoreFromPtr): Handle stobj as well.
11601 * expression.cs (UnaryMutator): Share more code.
11603 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11604 down: I was not tracking the Filter function as well, which
11605 was affecting the results of the cache.
11607 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11609 * attribute.cs: Remove the hack to handle the CharSet property on
11612 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11614 * attribute.cs (DoResolve): More uglyness, we now only try to
11615 resolve the attribute partially, to extract the CharSet
11616 information (only if we are a StructLayout attribute). Otherwise
11618 (GetExtraTypeInfo): Add some code to conditionally kill in the
11619 future this. I am more and more convinced that the .NET
11620 framework has special code to handle the attribute setting on
11623 * expression.cs (IsParamsMethodApplicable): Revert my previous
11624 foreach change here, it was wrong.
11626 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11628 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11629 (pp_expr): do not abort on unknown input, just return.
11630 (eval): abort if there are pending chars.
11632 * attribute.cs (Attribute.Resolve): Positional parameters are
11633 optional. Deal with that case.
11635 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11636 the Ansi/Unicode/Auto information for the type.
11638 (TypeContainer.DefineType): instantiate the EmitContext here, as
11639 we will be using it during the type definition (to resolve
11640 attributes) and during the emit phase.
11642 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11643 to pull type information out of the attributes
11645 (Attribute.Resolve): track the constructor builder, and allow for
11646 multiple invocations (structs and classes will use this).
11648 * ecore.cs (MemberLookupFinal): new version with all the
11649 parameters customizable.
11651 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11652 constructors. Return if the result value is null (as the error
11653 would have been flagged already by MemberLookupFinal)
11655 Do not allow instances of abstract classes or interfaces to be
11658 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11659 We have to compare the assembly property here when dealing with
11660 FamANDAssem and Assembly access modifiers, because we might be
11661 creating an assembly from *modules* (that means that we are not
11662 getting TypeBuilders for types defined in other modules that are
11663 part of this assembly).
11665 (Method.Emit): If the method is marked abstract and has a body,
11668 (TypeContainer.DefineMembers): If both the defined member and the
11669 parent name match are methods, then do not emit any warnings: let
11670 the Method.Define routine take care of flagging warnings. But if
11671 there is a mismatch (method overrides something else, or method is
11672 overriwritten by something, then emit warning).
11674 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11675 set to null, this means `do not check for the return type on the
11678 (Method.Define): set the return type for the method signature to
11679 null, so that we get methods with the same name and parameters and
11680 different return types. This is used to flag warning 114 (you are
11681 hiding a method, and you probably want to use the new/override
11684 * typemanager.cs (MemberLookup): Implemented proper access
11685 control, closing a long standing set of bug reports. The problem
11686 was that the Framework only has two bits: Public and NonPublic,
11687 and NonPublic includes private and protected methods, but we need
11688 to enforce the FamANDAssem, FamOrAssem and Family.
11690 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11692 * statement.cs (GotoCase): Return true: Ammounts to giving up
11693 knowledge on whether we return or not, and letting the other case
11694 be responsible for it.
11696 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11698 * driver.cs: Do not load directories for each file processed, only
11699 do it if there is a pattern.
11701 * ecore.cs: Report readonly assigns here as well, as we might have
11702 been resolved only by MemberAccess.
11704 (SimpleName.SimpleNameResolve): Also be useful for LValue
11705 resolution. We need this to propagate assign to local readonly variables
11707 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11708 do not want to reuse potential criteria memory.
11710 * class.cs (MyEventBuilder): Set reflected_type;
11712 * ecore.cs (Constantify): Added support for constifying bools.
11714 (RootContext.LookupType): Added a cache for values looked up in
11715 the declaration space.
11717 * typemanager.cs (FindMembers): Now is a front-end to
11718 RealFindMembers, and provides a two-level hashtable-based cache to
11721 15% performance improvement: from 22.5 to 19.2 seconds.
11723 * expression.cs (IsParamsMethodApplicable): use foreach.
11724 (Invocation.DoResolve): ditto.
11725 (New.DoResolve): ditto.
11726 (ArrayCreation.DoResolve): ditto.
11728 * ecore.cs (FindMostEncompassingType): use foreach.
11730 * delegate.cs (NewDelegate.DoResolve): Use foreach
11732 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11733 (RemoveMethods): use foreach.
11735 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11736 nested foreach statements instead of for, and also break out of
11737 the inner loop once a match is found.
11739 (Invocation.OverloadResolve): Use foreach, simplify the code.
11741 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11743 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11744 we actually unwrap the expression to allow for extra information
11747 * expression.cs: Use Shr_Un on unsigned operations.
11749 2002-05-08 Ravi Pratap <ravi@ximian.com>
11751 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11752 applicable operators was not being considered correctly. This closes
11753 the bug Miguel reported.
11755 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11757 * attribute.cs: check that the type derives from System.Attribute
11758 and report the correct error in that case (moved the duplicate code to
11759 its own method, too).
11761 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11763 * attribute.cs: lookup attribute type name as the spec says: first the
11764 bare attribute name and then name + "Attribute" (nant compiles with
11765 mcs after this fix).
11767 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11769 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11770 Because of the way we parse things, we should try to see if a
11771 UIntConstant can fit in an integer.
11773 2002-05-07 Ravi Pratap <ravi@ximian.com>
11775 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11776 when we are in an explicit context.
11778 (ConvertReferenceExplicit): When converting from Iface type S to Class
11779 T make sure the rules are implemented as an OR.
11781 * parameter.cs (ParameterType): Make it a property for now although the
11782 purpose really isn't anything immediate.
11784 * expression.cs (Is*Applicable): Do better checking on the parameter type
11785 of a ref/out parameter. The ones from the system assemblies are already
11786 marked with the correct type so we don't need to do any correction.
11788 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11789 the object type is standard too so include that.
11791 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11793 * ecore.cs (StandardConversionExists): Augment with missing code:
11794 deal with IntConstant, LongConstants and Enumerations.
11796 * assign.cs: Report the error, instead of failing silently
11798 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11799 typecontainer that they are declared, because the
11800 typecontainer/namespace will have the list of using clauses that
11801 need to be applied.
11803 Assembly Attributes were escaping the normal registration
11806 (EmitCode): Apply attributes within an EmitContext that represents
11807 the container they were declared on.
11809 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11811 2002-05-06 Ravi Pratap <ravi@ximian.com>
11813 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11814 Revamp completely - make much cleaner as we now operate only
11817 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11818 to implement the logic detailed in the spec more correctly.
11820 (UserDefinedConversion): Update accordingly.
11822 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11824 * statement.cs: Return flow analysis information up.
11826 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11829 (token): Do not consume an extra character before calling
11832 2002-05-06 Piers Haken <piersh@friskit.com>
11834 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11836 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11838 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11839 EmitContext during the instance constructor initializer
11840 resolution, to stop access to instance variables.
11842 This is mandated by the spec, last paragraph of the `constructor
11843 initializers' section.
11845 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11847 * cs-parser.jay, class.cs (Accessor): new class used to represent
11848 an accessor (get or set). In the past we used `null' to represent
11849 a missing accessor. But this is ambiguous because there was no
11850 way to tell in abstract indexers/properties if one of them was
11853 Now there is a way of addressing that.
11855 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11856 instead of FindMembers.
11858 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11859 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
11861 * attribute.cs: Treat indexers and properties as the same in terms
11862 of applying attributes
11864 * ecore.cs (FindMostEncompassedType): Use statically initialized
11865 EmptyExpressions()s like we do elsewhere to avoid creating useless
11866 objects (and we take this out of the tight loop).
11868 (GetConversionOperators): Move the code to extract the actual
11869 operators to a separate routine to clean things up.
11871 2002-05-04 Miguel de Icaza <miguel@ximian.com>
11873 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
11874 events are always registered FieldBuilders.
11876 * class.cs (FieldBase): New class shared by Fields
11878 * delegate.cs: If we are a toplevel delegate, use our full name.
11879 If we are a nested delegate, then only use our tail name.
11881 2002-05-02 Ravi Pratap <ravi@ximian.com>
11883 * expression.cs (IsApplicable): Ensure that we add the "&" to
11884 ref/out types before comparing it with the type of the argument.
11886 (IsParamsMethodApplicable): Ditto.
11888 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
11891 * delegate.cs : Handle the case when we have more than one applicable
11892 method. Flag an error only when we finish checking all.
11894 2002-05-02 Miguel de Icaza <miguel@ximian.com>
11896 * expression.cs: Add support for boolean static initializers.
11898 2002-05-01 Miguel de Icaza <miguel@ximian.com>
11900 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
11902 * parameter.cs (ComputeParameterTypes,
11903 ComputeAndDefineParameterTypes): Better error handling: now we
11904 clear the `types' cache if we fail during any of the type lookups.
11905 We also return the status code correctly to our caller
11907 * delegate.cs: If we fail to define a delegate, abort the extra
11910 * expression.cs (Binary.ResolveOperator): for
11911 operator==(object,object) and operator !=(object, object) we also
11912 have to verify that there is an implicit conversion from one to
11915 (ArrayAccess.DoResolve): Array Access can operate on
11918 2002-04-30 Miguel de Icaza <miguel@ximian.com>
11920 * assign.cs (CompoundAssign): A new class used as a "flag" that
11921 the assignment actually is happening as part of a compound
11922 assignment operator.
11924 During compound assignment, a few new rules exist to enable things
11931 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
11932 to the type of x) if y is implicitly convertible to the type of x,
11933 and the operator is a builtin operator and the return type of the
11934 operator is explicitly convertible to the type of x.
11936 * rootcontext.cs: Reset warning level to 2. 4 catches various
11937 "interesting" features in mcs, we must clean this up at some
11938 point, but currently am trying to kill other bugs ;-)
11940 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
11941 in container classes as well.
11943 * expression.cs (Binary.ResolveOperator): Handle string case
11944 before anything else (as operator overloading does emit an error
11945 before doing anything else).
11947 This code could go away when we move to a table driven model, but
11948 i could not come up with a good plan last night.
11950 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
11952 * typemanager.cs (CSharpName): reimplementation using regex.
11953 * class.cs: added null check for fields in Emit
11954 * rootcontext.cs: set warninglevel to 4
11956 2002-04-29 Miguel de Icaza <miguel@ximian.com>
11958 * typemanager.cs (CSharpName): reimplemented with Lupus
11961 2002-04-28 Miguel de Icaza <miguel@ximian.com>
11963 * statement.cs (If): correclty implement Resolve, because we were
11964 not catching sem errors in there. The same process is needed
11966 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
11969 (Statement.Warning_DeadCodeFound): Factorize code.
11970 (While): Report dead code here too.
11972 (Statement): Added Resolve virtual method to allow
11973 for resolution split from the emit code.
11975 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11977 * statement.cs (EmitBoolExpression): No longer try to resolve the
11979 (MakeBoolean): New utility function that resolve, implicitly
11980 converts to boolean and tags the expression.
11983 (If, Do): Implement dead code elimination.
11984 (While): Implement loop inversion
11986 (Do, While, For, If): Resolve the expression prior to calling our
11989 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
11992 - added method Report28 (warning: program has more than one entry point)
11993 - added method IsEntryPoint, implements paragraph 10.1 of the spec
11994 - modified method Method.Define, the part at the end of the method
11996 * rootcontext.cs: added static public Location EntryPointLocation;
11998 * ../errors/cs0028.cs : Add test case for the above warning.
12001 - modified method CSharpName to allow arrays of primitive type to
12002 be printed nicely (e.g. instead of System.Int32[][] it now prints
12004 - added method CSharpSignature: returns the signature of a method
12005 in string format to be used in reporting errors, warnings, etc.
12007 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
12010 2002-04-26 Ravi Pratap <ravi@ximian.com>
12012 * delegate.cs (Define): Fix extremely silly bug where I was
12013 setting the type of the 'object' parameter of the BeginInvoke
12014 method to System.IAsyncResult instead of System.Object ;-)
12016 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12018 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
12021 (Constructor.Emit): return if we fail to initialize the
12022 constructor. Another door closed!
12024 * expression.cs (New.DoResolve): Improve error message (from -6 to
12025 1501). Use DeclaredOnly lookup to find the exact constructor.
12027 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
12028 loop. This is useful.
12030 * cs-parser.jay: Adjust the default parameters so that destructors
12031 have the proper signature.
12033 2002-04-26 Martin Baulig <martin@gnome.org>
12035 * driver.cs (LoadAssembly): If `assembly' contains any characters
12036 which are only valid in path names and not in assembly names
12037 (currently slash, backslash and point), use Assembly.LoadFrom ()
12038 instead of Assembly.Load () on the `assembly' (before iteration
12039 over the link_paths).
12041 2002-04-26 Martin Baulig <martin@gnome.org>
12043 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
12045 2002-04-25 Miguel de Icaza <miguel@ximian.com>
12047 * class.cs (Property): use the new typemanager.MemberLookup
12049 (TypeContainer.MemberLookup): Implement using the
12050 TypeManager.MemberLookup now.
12052 * typemanager.cs: Make MemberLookup a function of the TypeManager,
12053 and return MemberInfos, so that these can be used without an
12054 EmitContext (what we had before).
12056 2002-04-24 Miguel de Icaza <miguel@ximian.com>
12058 * expression.cs: Fix the case where the argument to params if the
12059 type of the params. I omitted handling this before. Fixed
12061 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12063 * driver.cs: Call BootCorlib_PopulateCoreType
12065 * class.cs (Property.CheckBase): Check for properties only, not
12068 * interface.cs: Temporary hack: try/catch around the
12069 CustomAttributeBuilder, because I am getting an exception that I
12072 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
12073 types whose definitions are required to be there (attributes are
12074 defined before standard types).
12076 Compute definitions as we boot the various types, as they are used
12077 immediately (value_type class will need object_type, but if we do
12078 not initialize object_type, we will pass a null, which will let
12079 the runtime pick the System.Object from the existing corlib, which
12080 is not what we want).
12082 2002-04-22 Patrik Torstensson <totte@labs2.com>
12084 * cs-tokenizer.cs: fixed a number of trim() issues.
12086 2002-04-22 Ravi Pratap <ravi@ximian.com>
12088 * expression.cs (Argument.Type): Ensure that we return the correct
12089 type when we have out or ref parameters [in which case we
12092 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12094 * class.cs (Property, Indexer): Allow extern modifier in there.
12096 * typemanager.cs (InitBaseTypes): Initializes object_type and
12097 value_type, since those will be used early on during the bootstrap
12098 process to compile corlib.
12100 (InitCoreTypes): Move code from here to InitBaseTypes.
12102 2002-04-21 Miguel de Icaza <miguel@ximian.com>
12104 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
12105 single-dimension arrays as using the ldlen opcode.
12107 Daniel Lewis discovered this optimization.
12109 * typemanager.cs: Add signature for System.Array::get_Length
12111 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12113 * statement.cs: report the error when the foreach does not apply to an
12114 array nor a collection.
12116 2002-04-19 Miguel de Icaza <miguel@ximian.com>
12118 * expression.cs: Add implicit conversions to the operator ~.
12120 * constant.cs (DecimalConstant.Emit): Emit decimal value.
12122 * typemanager.cs: Locate the decimal constructor.
12124 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12126 * attribute.cs: use the new property of TypeOf.
12127 * expression.cs: added 'get' property around typearg.
12129 These changes fix a build breaker reported by NickD. Is this the
12130 correct way to fix? If not, please, revert my changes and make it
12133 2002-04-17 Miguel de Icaza <miguel@ximian.com>
12135 * attribute.cs: Add support for typeof in attribute invocations.
12136 I am not sure that this is right though.
12138 2002-04-14 Duncan Mak <duncan@ximian.com>
12140 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
12141 Binary.Operator.Division case.
12143 2002-04-13 Ravi Pratap <ravi@ximian.com>
12145 * class.cs (DefineType): Ensure that we do a proper check on
12146 attribute types and also register it with the TypeManager.
12148 (TypeContainer.Targets): The default for attribute types is
12149 AttributeTargets.All.
12151 * attribute.cs (ApplyAttributes): Registering the attribute type
12152 is done elsewhere, not when we discover we have a Usage attribute.
12154 2002-04-12 Ravi Pratap <ravi@ximian.com>
12156 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
12157 and get rid of is_delegate parameter.
12159 * everywhere : update.
12161 2002-04-12 Ravi Pratap <ravi@ximian.com>
12163 * cs-parser.jay (compilation_unit): Revamp completely to use
12164 some new ideas that I got from Rhys' grammar to solve the problems
12165 with assembly level attributes.
12167 (outer_declaration): New grammar production.
12169 (attribute_sections): Add.
12171 (opt_attributes): Base on attribute_sections
12173 (namespace_declaration): Allow opt_attributes to tackle the case
12174 when we have assembly level attributes - we are clever in this
12177 * attribute.cs (ApplyAttributes): Do not worry about assembly
12178 attributes in the non-global context.
12180 * rootcontext.cs (AddGlobalAttributes): Go back to using this
12181 instead of SetGlobalAttributes.
12183 * class.cs, rootcontext.cs : Ensure we define and generate
12184 attribute types before anything else.
12186 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
12187 and flag the new error -20 for the case when the attribute type
12188 does not have valid targets specified. csc does not catch this.
12190 * ../errors/errors.txt : update for error # -20
12192 2002-04-11 Ravi Pratap <ravi@ximian.com>
12194 * support.cs (InternalParameters.ParameterModifier): Do some null
12195 checking and return sane values.
12197 * class.cs (Method.Define): If we are a PInvoke method, ensure
12198 that we are static and extern. Report error # 601
12200 * ../errors/cs0601.cs : Add test case for the above error.
12202 2002-04-07 Ravi Pratap <ravi@ximian.com>
12204 * rootcontext.cs (attribute_types): We need to keep type of
12205 all attribute types separately and emit code for them first.
12207 (RegisterAttribute) : Implement.
12209 * class.cs (DefineType): Check if the current Type is a custom
12210 attribute type and register it accordingly.
12212 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
12213 adding the first attribute twice and rename to
12215 (SetGlobalAttributes): this.
12217 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
12220 * attribute.cs (ApplyAttributes): Take an additional argument telling us
12221 if we are processing global arguments. Hmm, I am unsure of this.
12223 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12225 * expression.cs: added static array of strings to avoid calling
12226 Enum.ToString () for Operator in Binary. Significant recover of
12229 2002-04-10 Miguel de Icaza <miguel@ximian.com>
12231 * class.cs (FindMembers): Allow the Builders of the various
12232 members to be null. If they are skip them. This only happens
12233 during the PInvoke declaration.
12235 2002-04-09 Miguel de Icaza <miguel@ximian.com>
12237 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
12238 failure, so we do not keep going afterwards.
12240 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
12241 wanted to pass `false' as the `is_delegate' argument. If this is
12242 the case, why not use delegate_type == null to mean `is_delegate =
12243 false' and anything else as is_delegate = true.
12245 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
12247 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
12248 code for the section, not the beginning of the tests.
12250 2002-04-08 Miguel de Icaza <miguel@ximian.com>
12252 * cfold.cs: Handle operator + (Enum x, Underlying x)
12254 * expression.cs (Binary): same. Warn about errors where we have
12255 Enum/Enum in operator + as well.
12257 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
12260 - added support for switch(bool)
12261 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
12262 - add TableSwitchEmit() to handle table-based switch statements
12264 2002-04-05 Ravi Pratap <ravi@ximian.com>
12266 * expression.cs (Invocation.OverloadResolve): Factor out code which
12267 does parameter compatibility checking with arguments so that we can
12268 re-use the code even from Delegate.VerifyApplicability
12270 (VerifyArgumentsCompat): Move above code here.
12272 * delegate.cs (VerifyApplicability): Get rid of duplicate code
12273 and instead make a call to the above method.
12275 2002-03-31 Ravi Pratap <ravi@ximian.com>
12277 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
12278 We use it to keep track of classes which are attribute types.
12280 2002-04-02 Miguel de Icaza <miguel@ximian.com>
12282 * delegate.cs (Delegate.Define): Correctly define the types in the
12283 presence of fixed and array parameters.
12285 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
12288 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
12289 include NonPublic after the first iteration.
12291 * class.cs (Indexer.CheckBase): Only check if both parents are
12294 * cs-parser.jay (accessor_body): If empty, set to null.
12296 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
12297 same code path here to resolve constants names that we did have in
12298 MemberAccess.DoResolve. There is too much code duplicated here.
12300 2002-04-01 Miguel de Icaza <miguel@ximian.com>
12302 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
12304 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
12307 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
12308 tokens, numbers and strings.
12310 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
12313 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
12314 asyncronous parameters and the regular parameters.
12316 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
12317 specify the target directory.
12319 * expression.cs: (This.DoResolve): Simplify
12320 (As.Emit): Optimize, do not generate IsInst if the expression is
12321 always of the given type.
12323 (Is.DoResolve): Bug fix, we were reporting both always/never for
12326 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
12327 creating too many unnecessary arrays.
12329 2002-03-31 Miguel de Icaza <miguel@ximian.com>
12331 * class.cs (EmitFieldInitializer): Use Assign expression to assign
12332 fields instead of rolling our own initializer. Takes care of all
12333 implicit conversions, and drops unnecessary static checks/argument.
12335 2002-03-31 Dick Porter <dick@ximian.com>
12337 * driver.cs: use the GetDirectories() return values properly, and
12338 use "/" as path separator.
12340 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12342 * expression.cs (Unary): Optimize - - expr into expr.
12343 (Binary): Optimize a + (-b) into a -b.
12345 * codegen.cs (CodeGen): Made all methods static.
12347 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12351 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12352 TypeBuilder property.
12354 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12357 * tree.cs: Removed the various RecordXXXX, and replaced with a
12358 single RecordDecl. Removed all the accessor methods, and just
12359 left a single access point Type
12361 * enum.cs: Rename DefineEnum to DefineType.
12363 * decl.cs: New abstract method `DefineType' used to unify the
12364 Defines for Enumerations, Interfaces, TypeContainers and
12367 (FindType): Moved LookupInterfaceOrClass here. Moved the
12368 LookupBaseClasses method that used to live in class.cs and
12369 interface.cs here, and renamed to FindType.
12371 * delegate.cs: Implement DefineType. Take advantage of the
12372 refactored pattern for locating the parent builder without taking
12373 the parent_builder argument (which we know does not work if we are
12374 nested, and triggering a toplevel definition).
12376 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12378 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12379 accessibility of a member has changed during override and report
12382 * class.cs (Method.Define, Property.Define): Only complain on
12383 overrides if the method is private, any other accessibility is
12384 fine (and since we just checked the permission is the same, we are
12387 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12388 and elif are processed always. The other pre-processing
12389 directives are only processed if we are "taking" the path
12391 2002-03-29 Martin Baulig <martin@gnome.org>
12393 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12394 current location is not Null.
12396 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12397 a separate method so we can profile it.
12399 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12400 `span.Seconds' are just seconds, but no minutes or hours.
12401 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12403 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12405 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12406 Remove the gratuitous set of Final:
12408 // If an interface implementation, then we can set Final.
12409 if (((flags & MethodAttributes.Abstract) == 0) &&
12410 implementing.DeclaringType.IsInterface)
12411 flags |= MethodAttributes.Final;
12413 I do not know what I was smoking when I used that.
12416 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12417 step into fixing the name resolution issues for delegates and
12418 unifying the toplevel name resolution.
12420 2002-03-28 Martin Baulig <martin@gnome.org>
12422 * class.cs (Method.Emit): If we have a symbol writer, call its
12423 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12424 tell it about the current method.
12426 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12427 writer that we're going to emit the first byte of IL code for a new
12428 statement (a new source line).
12429 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12430 EmitContext.Mark() before emitting any code.
12432 * location.cs (SymbolDocument): Return null when we're Null.
12434 * statement.cs (Statement): Moved the `Location loc' variable here.
12435 (Statement.EmitBoolExpression): If we have a symbol writer, call
12436 ec.Mark() before emitting any code to tell it that we're at the
12437 beginning of a new statement.
12438 (StatementExpression): Added `Location' argument to the constructor.
12439 (Block): Added public readonly variable `StartLocation' and public
12440 variable `EndLocation'. The latter is to be set using SetEndLocation().
12441 (Block): Added constructor which takes a start and end location.
12442 (Block.SetEndLocation): New method. This sets the end location.
12443 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12444 local variables we create.
12445 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12446 each statement and do also mark the begin and end of the block.
12448 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12449 tell it the current lexer.Location, use Location.Null for the end of the
12451 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12452 current block, set its end location using SetEndLocation().
12453 (statement_expression): StatementExpression constructor now takes the
12454 lexer.Location as additional argument.
12455 (for_statement, declare_local_variables): Likewise.
12456 (declare_local_variables): When creating a new implicit block, use the
12457 new Block constructor and pass it the lexer.Location.
12459 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12461 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12462 members also on the parent interfaces recursively.
12464 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12466 * report.cs: Use new formats, since Gonzalo finished the missing
12469 * expression.cs (Binary.ResolveOperator): added missing operator|
12470 operator& and operator^ for bool/bool.
12472 * cs-parser.jay: CheckDef now takes a Location argument that is
12473 used to report errors more precisly (instead of reporting the end
12474 of a definition, we try to track something which is a lot closer
12475 to the source of the problem).
12477 * cs-tokenizer.cs: Track global token use, so we can properly flag
12478 the use of #define/#undef after the first token has been seen.
12480 Also, rename the reportXXXX to Error_DescriptiveName
12482 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12483 TypeContainer, so that Enum and Interface can use this too.
12485 * class.cs (TypeContainer.LookupInterfaceOrClass,
12486 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12487 `builder' argument. Typically this was used to pass the parent
12488 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12491 The problem is that a nested class could trigger the definition of
12492 a toplevel class, and the builder would be obviously wrong in that
12495 So we drop this argument, and we compute dynamically the
12496 TypeBuilder/ModuleBuilder (the correct information was available
12497 to us anyways from DeclSpace.Parent)
12499 * interface.cs (Interface.DefineInterface): Drop builder
12500 parameter cleanup like class.cs
12502 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12505 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12508 (Try.Emit): Propagate the returns value from the statement.
12510 (Return.Emit): Even if we are leavning
12512 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12514 * modifiers.cs: Fix the computation of MethodAttributes flags.
12516 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12518 * driver.cs: allow compilation of files that start with '/'.
12519 Add a default case when checking the argument of --target.
12521 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12523 * interface.cs: Implement the same search algorithm for types in
12524 the interface code.
12526 * delegate.cs: Do not allow multiple definition.
12528 * Recovered ChangeLog that got accidentally amputated
12530 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12532 * rootcontext.cs: Load manually enum to allow core classes to
12533 contain enumerations.
12535 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12536 Update to new static methods in TypeManager.
12538 * typemanager.cs (GetMethod, GetConstructor): Use our
12539 implementation of FindMembers to find the members, since during
12540 corlib compilation, the types are TypeBuilders and GetMethod and
12541 GetConstructor do not work.
12543 Make all methods in TypeManager static.
12545 (InitCodeHelpers): Split the functionality from
12546 the InitCodeTypes function.
12548 * driver.cs: Call InitCodeHelpers after we have populated the
12551 * cs-parser.jay (delegate_declaration): we did not used to compute
12552 the delegate name correctly for void delegates.
12554 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12556 * rootcontext.cs (RootContext): Init the interface_resolve_order
12557 and type_container_resolve_order always.
12559 (ResolveCore, BootstrapCorlib_ResolveClass,
12560 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12561 compiler when compiling with --nostdlib
12563 * class.cs (TypeContainer.DefineType): Check that our parent is
12564 not null. This test is most important when we are bootstraping
12567 * codegen.cs: Split out the symbol writing code.
12569 2002-03-25 Martin Baulig <martin@gnome.org>
12571 * driver.cs (-g): Made -g an alias for --debug.
12573 2002-03-24 Martin Baulig <martin@gnome.org>
12575 * codegen.cs (SymbolWriter): New public variable. Returns the
12576 current symbol writer.
12577 (CodeGen): Added `bool want_debugging_support' argument to the
12578 constructor. If true, tell the ModuleBuild that we want debugging
12579 support and ask it for the ISymbolWriter.
12580 (Save): If we have a symbol writer, call it's Close() method after
12581 saving the assembly.
12583 * driver.c (--debug): New command line argument to create a
12584 debugger information file.
12586 * location.cs (SymbolDocument): New public property. Returns an
12587 ISymbolDocumentWriter object for the current source file or null
12588 if we don't have a symbol writer.
12590 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12592 * driver.cs (LoadAssembly): Correctly return when all the paths
12593 have been tried and not before.
12595 * statement.cs (Switch.Emit): return the actual coverage for this
12596 statement (returns/not-returns)
12598 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12599 switch of the statement if we are the last switch section. That
12600 kills two problems: try/catch problems (we used to emit an empty
12601 nop at the end) and switch statements where all branches would
12604 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12606 * driver.cs: Add default assemblies (the equivalent to the
12607 Microsoft CSC.RSP file)
12609 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12610 also update tokens_seen and set it to false.
12612 * driver.cs: Implement --recurse for Mike.
12614 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12615 correctly splitting out the paths.
12617 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12619 * interface.cs (Interface.PopulateProperty): Instead of using
12620 `parent' as the declaration space for the set parameters, use
12623 * support.cs (InternalParameters): InternalParameters constructor
12624 takes a DeclSpace instead of a TypeContainer.
12626 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12627 types are being initialized, load the address of it before calling
12630 (New): Provide a mechanism to disable the generation of local
12631 value type temporaries when the caller will be providing us with
12632 an address to store it.
12634 (ArrayCreation.EmitDynamicInitializers): Use it.
12636 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12638 * expression.cs (Invocation.EmitArguments): Only probe for array
12639 property if there is more than one argument. Sorry about that.
12641 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12642 empty param arrays.
12644 * class.cs (Method.LabelParameters): Fix incorrect code path that
12645 prevented the `ParamArrayAttribute' from being applied to the
12648 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12650 * support.cs (ReflectionParameters): Correctly compute whether the
12651 last argument is a params array. Fixes the problem with
12654 * typemanager.cs: Make the assemblies array always be non-null
12655 (empty, but non-null)
12657 * tree.cs (RecordDecl): New function that abstracts the recording
12658 of names. This reports error 101, and provides a pointer to the
12659 previous declaration. Fixes a crash in the compiler.
12661 * cs-parser.jay (constructor_declaration): Update to new grammar,
12662 and provide a constructor_body that can be empty.
12664 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12666 * driver.cs: Add support for --resources.
12668 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12669 Make all types for the various array helper methods be integer.
12671 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12672 CheckState to ConvCast.
12674 (ConvCast): Now it takes a `checked' state argument, to avoid
12675 depending on the emit context for the conversion, and just using
12676 the resolve time setting.
12678 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12679 instead of Invocation.EmitArguments. We do not emit the original
12680 arguments, instead we emit those which have been converted to
12681 unsigned int expressions.
12683 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12685 * codegen.cs: ditto.
12687 * expression.cs (LocalVariableReference): Drop the use of the
12688 Store function that depended on the variable index.
12690 * statement.cs (VariableInfo): Drop the `Idx' property from this
12691 class, as this is not taking into account the indexes for
12692 temporaries tat we generate during the execution, getting the
12695 * class.cs: First emit class initializers, then call the parent
12698 * expression.cs (Binary): Fix opcode emision.
12699 (UnaryMutator.EmitCode): Support checked code generation
12701 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12702 matches for events for both the Static and Instance scans,
12703 pointing to the same element. Fix that.
12705 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12707 * rootcontext.cs (ResolveTree): Always set the
12708 interface_resolve_order, because nested interfaces will be calling
12711 * class.cs (GetInterfaceOrClass): Track the same resolution
12712 process used by TypeManager.LookupType. This fixes the nested
12713 type lookups in class declarations (separate path from
12716 (TypeContainer.DefineType): Also define nested interfaces.
12717 (TypeContainer.RegisterOrder): New public function used to
12718 register the order in which child interfaces need to be closed.
12720 Nested interfaces need to be closed after their parents have been
12723 * interface.cs (InterfaceAttr): Put all the logic for computing
12724 the interface attribute here.
12726 (DefineInterface): Register our interface order with the
12727 RootContext or with the TypeContainer depending on the case.
12729 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12731 * cs-parser.jay: rework foreach statement to work with the new
12732 changes to the policy on SimpleNames.
12734 * report.cs: support Stacktrace on warnings as well.
12736 * makefile: drop --unsafe and /unsafe from the compile.
12738 2002-03-13 Ravi Pratap <ravi@ximian.com>
12740 * ecore.cs (StandardConversionExists): Modify to take an Expression
12741 as the first parameter. Ensure we do null -> reference type conversion
12744 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12745 temporary Expression objects.
12747 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12749 * interface.cs: workaround bug in method overloading resolution
12750 (there is already a bugzilla bug for it).
12752 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12754 We could also solve this problem by having a separate path for
12755 performing type lookups, instead of DoResolve, we could have a
12756 ResolveType entry point, and only participating pieces of the
12757 production (simplename, deref, array) would implement this.
12759 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12760 signal SimpleName to only resolve type names and not attempt to
12761 resolve anything else.
12763 * expression.cs (Cast): Set the flag.
12765 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12767 * class.cs: Only report 108 if there is no `new' modifier.
12769 * cs-parser.jay: rework foreach statement to work with the new
12770 changes to the policy on SimpleNames.
12772 * report.cs: support Stacktrace on warnings as well.
12774 * makefile: drop --unsafe and /unsafe from the compile.
12776 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12778 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12779 lookups here, instead of doing that at parse time. This means
12780 that our grammar will not introduce `LocalVariableReferences' as
12781 expressions at this point. That solves the problem of code like
12785 static void Main ()
12789 This is only half the fix. The full fix requires parameters to
12790 also be handled in this way.
12792 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12793 makes the use more obvious of the DeclSpace. The
12794 ec.TypeContainer.TypeBuilder is now only used to pull the
12795 TypeBuilder for it.
12797 My theory is that I can get rid of the TypeBuilder completely from
12798 the EmitContext, and have typecasts where it is used (from
12799 DeclSpace to where it matters).
12801 The only pending problem is that the code that implements Aliases
12802 is on TypeContainer, and probably should go in DeclSpace.
12804 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12805 lookups here, instead of doing that at parse time. This means
12806 that our grammar will not introduce `LocalVariableReferences' as
12807 expressions at this point. That solves the problem of code like
12811 static void Main ()
12815 This is only half the fix. The full fix requires parameters to
12816 also be handled in this way.
12818 * class.cs (Property.DefineMethod): When implementing an interface
12819 method, set newslot, when implementing an abstract method, do not
12820 set the flag (before we tried never setting it, or always setting
12821 it, which is the difference).
12822 (Indexer.DefineMethod): same.
12823 (Method.DefineMethod): same.
12825 * ecore.cs: Only set the status used flag if we get back a Field.
12827 * attribute.cs: Temporary hack, so Paolo can keep working.
12829 2002-03-08 Ravi Pratap <ravi@ximian.com>
12831 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12832 the unmanaged type in the case we have a MarshalAs attribute.
12834 (Resolve): Handle the case when we are parsing the special MarshalAs
12835 attribute [we need to store the unmanaged type to use later]
12837 * typemanager.cs (marshal_as_attr_type): Built in type for the
12838 MarshalAs Attribute.
12840 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12841 on parameters and accordingly set the marshalling info.
12843 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12845 * class.cs: Optimizing slightly by removing redundant code after
12846 we switched to the `NoTypes' return value.
12847 (Property.DefineMethod): use NoTypes here too.
12849 This fixes the bug I introduced in my last batch of changes.
12851 2002-03-05 Ravi Pratap <ravi@ximian.com>
12853 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12855 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12856 Enums since those are types too.
12858 * cs-parser.jay (enum_declaration): Record enums as we parse them.
12860 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
12861 thanks to a call during the lookup process.
12863 2002-03-07 Miguel de Icaza <miguel@ximian.com>
12865 * statement.cs (Foreach): Lots of work to accomodate a particular
12866 kind of foreach statement that I had not kept in mind. It is
12867 possible to have foreachs on classes that provide a GetEnumerator
12868 method that return objects that implement the "pattern" for using
12869 a foreach, there is no need to support GetEnumerator
12872 This is needed to compile nant.
12874 * decl.cs: Only report 114 if the member is not `Finalize' and if
12875 the warning level is at least 2.
12877 * class.cs: Moved the compare function from Method to
12880 (MethodSignature.InheritableMemberSignatureCompare): Add new
12881 filter function that is used to extract inheritable methods from a
12884 (Method.Define): Use the new `inheritable_method_signature_filter'
12887 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
12890 2002-03-06 Miguel de Icaza <miguel@ximian.com>
12892 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
12894 * cs-parser.jay: Add opt_semicolon to the interface declaration.
12896 * expression.cs: Pass location information to
12897 ConvertImplicitStandard.
12899 * class.cs: Added debugging code to track return values from
12902 2002-03-05 Miguel de Icaza <miguel@ximian.com>
12904 * expression.cs (Is.DoResolve): If either side of the `is' is an
12905 interface, do not flag the warning.
12907 * ecore.cs (ImplicitReferenceConversion): We need a separate test
12910 * report.cs: Allow for --fatal to be used with --probe.
12912 * typemanager.cs (NoTypes): Move the definition for the empty Type
12915 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
12917 (TypeContainer.DefineProxy): New function used to proxy to parent
12918 implementations when implementing interfaces.
12919 (TypeContainer.ParentImplements): used to lookup if our parent
12920 implements a public function that is required by an interface.
12921 (TypeContainer.VerifyPendingMethods): Hook this up.
12923 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
12924 `modules' and `assemblies' arraylists into arrays. We only grow
12925 these are the very early start up of the program, so this improves
12926 the speedof LookupType (nicely measured).
12928 * expression.cs (MakeByteBlob): Replaced unsafe code with
12929 BitConverter, as suggested by Paolo.
12931 * cfold.cs (ConstantFold.Binary): Special case: perform constant
12932 folding of string concatenation, but if either side is a string,
12933 and the other is not, then return null, and let the runtime use
12934 the concatenation on the string plus the object (using
12935 `Object.ToString').
12937 2002-03-04 Miguel de Icaza <miguel@ximian.com>
12939 Constant Folding has been implemented now.
12941 * expression.cs (Unary.Reduce): Do not throw an exception, catch
12942 the error instead on types that are not supported in one's
12945 * constant.cs (Constant and all children): New set of functions to
12946 perform implict and explicit conversions.
12948 * ecore.cs (EnumConstant): Implement the new functions to perform
12949 conversion by proxying to the child expression.
12951 * codegen.cs: (ConstantCheckState): Constant evaluation has its
12952 own separate setting that can not be turned off from the command
12953 line using --unchecked or --checked and is only controlled using
12954 the checked/unchecked statements and expressions. This setting is
12955 used by the constant folder to flag errors.
12957 * expression.cs (CheckedExpr, UncheckedExpr): Set the
12958 ConstantCheckState as well.
12960 During Resolve, they also have to flag the state, because the
12961 constant folder runs completely in the Resolve phase.
12963 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
12966 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12968 * cfold.cs: New file, this file contains the constant folder.
12970 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
12971 argument to track whether we are using the resulting address to
12972 load or store a value and provide better error messages.
12974 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
12975 new AddressOf arguments.
12977 * statement.cs (Foreach.EmitCollectionForeach): Update
12979 * expression.cs (Argument.Emit): Call AddressOf with proper
12980 arguments to track usage.
12982 (New.DoEmit): Call AddressOf with new arguments.
12984 (Unary.Emit): Adjust AddressOf call.
12986 2002-03-01 Ravi Pratap <ravi@ximian.com>
12988 * cs-parser.jay (member_access): Change the case for pre-defined types
12989 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
12992 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
12995 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
12996 essentially like methods and apply attributes like MethodImplOptions to them too.
12998 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
13001 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
13002 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
13005 * Update code everywhere accordingly.
13007 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
13009 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
13011 2002-02-28 Ravi Pratap <ravi@ximian.com>
13013 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
13014 try performing lookups against those instead of jumping straight into using
13015 the 'using' clauses.
13017 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
13019 (LookupType): Perform lookups in implicit parents too.
13021 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
13022 sequence as RootContext.LookupType.
13024 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
13025 the various cases of namespace lookups into this method.
13027 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13029 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
13030 in positional arguments)
13032 * class.cs (Operator): Update the AllowedModifiers to contain
13035 * cs-parser.jay: Update operator declaration to allow for the
13036 operator body to be empty.
13038 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
13041 2002-02-27 Miguel de Icaza <miguel@ximian.com>
13043 * class.cs (Method.Emit): Label parameters.
13045 * driver.cs: Return 1 or 0 as the program exit code.
13047 2002-02-26 Miguel de Icaza <miguel@ximian.com>
13049 * expression.cs: Special case the `null' object when trying to
13050 auto-compute the type, as anything can be explicitly converted to
13053 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
13054 spotting this Paolo.
13056 (Expression.ImplicitNumericConversion): Perform comparissions of
13057 the type using the underlying type in the case of an enumeration
13058 rather than using the enumeration type for the compare.
13060 Cope with the underlying == type case, which is not possible to
13063 (Expression.ConvertNumericExplicit): Perform comparissions of
13064 the type using the underlying type in the case of an enumeration
13065 rather than using the enumeration type for the compare.
13067 * driver.cs: If the user does not supply an extension, assume .exe
13069 * cs-parser.jay (if_statement): Rewrote so that we can track the
13070 location for the if statement.
13072 * expression.cs (Binary.ConstantFold): Only concat strings when
13073 the operation is "+", not everything ;-)
13075 * statement.cs (Statement.EmitBoolExpression): Take a location
13077 (If, While, Do): Track location.
13079 * expression.cs (Binary.ResolveOperator): In the object + string
13080 case, I was missing a call to ConvertImplicit
13082 2002-02-25 Ravi Pratap <ravi@ximian.com>
13084 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
13085 Location arguments. Ensure we use RootContext.LookupType to do our work
13086 and not try to do a direct Type.GetType and ModuleBuilder.GetType
13088 * interface.cs (PopulateMethod): Handle the type of the parameter being
13091 * expression.cs (Invocation.BetterFunction): Handle the case when we
13092 have a params method with no fixed arguments and a call is made with no
13095 2002-02-25 Miguel de Icaza <miguel@ximian.com>
13097 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
13098 the verbatim-string-literal
13100 * support.cs (InternalParameters.ParameterModifier): handle null
13102 (InternalParameters.ParameterType): ditto.
13104 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
13105 duplicating the name of the variable parameter.
13106 (GetParameterByName): Fix bug where we were not looking up array
13107 paramters if they were the only present (thanks Paolo!).
13108 (GetParameterInfo): We only have an empty set of types if both
13109 fixed and array are set to null.
13110 (GetParameterInfo-idx): Handle FixedParameter == null
13112 * cs-parser.jay: Handle the case where there is no catch
13113 statements (missing null test).
13115 2002-02-22 Miguel de Icaza <miguel@ximian.com>
13117 * driver.cs (MainDriver): Be conservative on our command line
13120 Catch DirectoryNotFoundException when calling GetFiles.
13122 (SplitPathAndPattern): Used to split the input specification into
13123 a path and a pattern that we can feed to Directory.GetFiles.
13125 2002-02-21 Miguel de Icaza <miguel@ximian.com>
13127 * statement.cs (Fixed): Implement the last case of the Fixed
13128 statement (string handling).
13130 * expression.cs (StringPtr): New class used to return a char * to
13131 a string; Used by the Fixed statement.
13133 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
13135 * expression.cs (Binary.ResolveOperator): Remove redundant
13136 MemberLookup pn parent type.
13137 Optimize union call, we do not need a union if the types are the same.
13138 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
13141 Specialize the use of MemberLookup everywhere, instead of using
13142 the default settings.
13144 (StackAlloc): Implement stackalloc keyword.
13146 * cs-parser.jay: Add rule to parse stackalloc.
13148 * driver.cs: Handle /h, /help, /?
13150 * expression.cs (MakeByteBlob): Removed the hacks we had in place
13151 before we supported unsafe code.
13153 * makefile: add --unsafe to the self compilation of mcs.
13155 2002-02-20 Miguel de Icaza <miguel@ximian.com>
13157 * expression.cs (PointerArithmetic): New class that is used to
13158 perform pointer arithmetic.
13159 (Binary.Resolve): Handle pointer arithmetic
13160 Handle pointer comparission.
13161 (ArrayPtr): Utility expression class that is used to take the
13162 address of an array.
13164 (ElementAccess): Implement array access for pointers
13166 * statement.cs (Fixed): Implement fixed statement for arrays, we
13167 are missing one more case before we are done.
13169 * expression.cs (Indirection): Implement EmitAssign and set the
13170 ExprClass to Variable. This allows pointer dereferences to be
13171 treated as variables, and to have values assigned to them.
13173 * ecore.cs (Expression.StoreFromPtr): New utility function to
13174 store values dereferencing.
13176 2002-02-20 Ravi Pratap <ravi@ximian.com>
13178 * expression.cs (Binary.ResolveOperator): Ensure that we are
13179 not trying to operate on a void type - this fixes the reported
13182 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
13183 the parent implementation is sealed.
13185 * ../errors/cs0239.cs : Add.
13187 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
13189 * typemanager.cs (unverifiable_code_type): Corresponds to
13190 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
13191 which have unsafe code in them.
13193 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
13196 2002-02-19 Miguel de Icaza <miguel@ximian.com>
13198 * cs-tokenizer.cs: Add support for @"litreal strings"
13200 Make tokenizer accept pre-processor directives
13201 on any column (remove the old C-like limitation).
13203 * rootcontext.cs (EmitCode): Emit any global attributes.
13204 (AddGlobalAttributes): Used to keep track of assembly attributes.
13206 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
13208 * cs-parser.jay: Add support for global attributes.
13210 2002-02-17 Miguel de Icaza <miguel@ximian.com>
13212 * expression.cs (Indirection): New helper class. Unary will
13213 create Indirection classes to be able to implement the
13214 IMemoryLocation interface on it.
13216 2002-02-16 Miguel de Icaza <miguel@ximian.com>
13218 * cs-parser.jay (fixed_statement): reference the right statement.
13220 * statement.cs (Fixed.Emit): Finish implementing the fixed
13221 statement for the &x case.
13223 2002-02-14 Miguel de Icaza <miguel@ximian.com>
13225 * class.cs (Property.Define, Method.Define): Remove newslot when
13228 * modifiers.cs: My use of NewSlot when `Abstract' was set was
13229 wrong. NewSlot should only be used if the `new' keyword is present.
13231 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
13232 locating our system dir. Sorry about this.
13234 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13236 * driver.cs (GetSystemDir): Compute correctly the location of our
13237 system assemblies. I was using the compiler directory instead of
13238 the library directory.
13240 2002-02-13 Ravi Pratap <ravi@ximian.com>
13242 * expression.cs (BetterFunction): Put back in what Miguel commented out
13243 since it is the correct fix. The problem is elsewhere ;-)
13245 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
13246 parameters of the parms method are themselves compatible or not !
13248 (StandardConversionExists): Fix very dangerous bug where we were forgetting
13249 to check that a class implements an interface before saying that an implicit
13250 conversion was allowed. Use ImplementsInterface to do the checking.
13252 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13254 * class.cs (Method.Define): Track whether we are an explicit
13255 implementation or not. And only call DefineMethodOverride if we
13256 are an explicit implementation.
13258 (Property.DefineMethod): Ditto.
13260 2002-02-11 Ravi Pratap <ravi@ximian.com>
13262 * expression.cs (BetterFunction): Catch hideous bug which was
13263 preventing us from detecting ambiguous calls due to implicit casts i.e
13266 2002-01-29 Miguel de Icaza <miguel@ximian.com>
13268 * support.cs (Pair): Remove un-needed method. I figured why I was
13269 getting the error in cs-parser.jay, the variable in a foreach loop
13270 is readonly, and the compiler does not really treat this as a variable.
13272 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
13273 instead of EQUALS in grammar.
13275 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
13277 * expression.cs (Unary.DoResolve): Check whether the argument is
13280 2002-01-28 Miguel de Icaza <miguel@ximian.com>
13282 * support.cs: Api for Pair to set a value. Despite the fact that
13283 the variables are public the MS C# compiler refuses to compile
13284 code that accesses the field if the variable is part of a foreach
13287 * statement.cs (Fixed): Begin implementation of the fixed
13290 (Block.AddVariable): Return the VariableInfo on success and null
13291 on failure instead of true/false.
13293 * cs-parser.jay (foreach): Catch errors on variables already
13294 defined (we were ignoring this value before) and properly unwind
13295 the block hierarchy
13297 (fixed_statement): grammar for the fixed statement.
13299 2002-01-25 Miguel de Icaza <miguel@ximian.com>
13301 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
13302 pointer types to be incretemented.
13304 (SizeOf): Implement.
13306 * cs-parser.jay (pointer_member_access): Implement
13307 expr->IDENTIFIER production.
13309 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
13310 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
13313 (Unary): Implement indirection.
13315 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
13316 use in non-unsafe context).
13318 (SimpleName.DoResolve): Check for pointers in field access on safe
13321 (Expression.LoadFromPtr): Factor the load-indirect code in this
13322 function. This was duplicated in UnboxCast and ParameterReference
13324 2002-01-24 Miguel de Icaza <miguel@ximian.com>
13326 * expression.cs (ComposedCast): report an error if a pointer cast
13327 is used in a safe region.
13329 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
13330 pointer type casts in unsafe context.
13332 * codegen.cs (EmitContext): Set up IsUnsafe.
13334 * cs-parser.jay (non_expression_type): Add productions for pointer
13337 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13338 code. We should not use force into static mode if the method is
13339 not virtual. Fixes bug in MIS
13341 * statement.cs (Do.Emit, While.Emit, For.Emit,
13342 Statement.EmitBoolExpression): Add support to Do and While to
13343 propagate infinite loop as `I do return' semantics.
13345 Improve the For case to also test for boolean constants.
13347 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13348 to the list of attributes we can add.
13350 Remove `EmitContext' argument.
13352 * class.cs (Method.Define): Apply parameter attributes.
13353 (Constructor.Define): Apply parameter attributes.
13354 (MethodCore.LabelParameters): Move here the core of labeling
13357 * support.cs (ReflectionParameters.ParameterModifier,
13358 InternalParameters.ParameterModifier): Use IsByRef on the type and
13359 only return the OUT bit for these parameters instead of in/out/ref
13362 This is because I miss-understood things. The ParameterInfo.IsIn
13363 and IsOut represent whether the parameter has the [In] and [Out]
13366 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13368 * ecore.cs (FieldExpr.Emit): Release temporaries.
13370 * assign.cs (LocalTemporary.Release): new function.
13372 * codegen.cs (EmitContext.GetTemporaryStorage,
13373 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13374 temporary storage. Now we can "put back" localbuilders when we
13377 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13379 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13380 need to make a copy of the variable to generate verifiable code.
13382 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13384 * driver.cs: Compute dynamically the system directory.
13386 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13387 Slower, but more generally useful. Used by the abstract
13388 registering implementation.
13390 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13391 the rules for the special rule on Type/instances. First check if
13392 we have the same name, and if so, try that special static path
13393 rather than the instance path.
13395 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13397 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13400 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13401 Enum, ValueType, Delegate or Array for non-corlib compiles.
13403 * cs-tokenizer.cs: Catch long identifiers (645)
13405 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13408 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13409 fix, we were returning too early, so we were not registering
13410 pending methods from abstract classes.
13412 Do not register pending methods if the class is abstract.
13414 * expression.cs (Conditional.DoResolve): Report circular implicit
13415 conversions when we neecd to compute it for conditional
13418 (Is.DoResolve): If the expression is always of the provided type,
13419 flag warning 183. If the expression can not ever be of the
13420 provided type flag warning 184.
13422 * class.cs: Catch 169 as well.
13424 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13427 2002-01-18 Nick Drochak <ndrochak@gol.com>
13429 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13431 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13433 * interface.cs: (PopulateMethod): Check for pointers being defined
13434 only if the unsafe context is active.
13435 (PopulateProperty): ditto.
13436 (PopulateIndexer): ditto.
13438 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13439 specified. If pointers are present, make sure that they are
13440 present in an unsafe context.
13441 (Constructor, Constructor.Define): ditto.
13442 (Field, Field.Define): ditto.
13443 (Property, Property.Define): ditto.
13444 (Event, Event.Define): ditto.
13446 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13447 hashtable if there are classes or structs defined.
13449 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13450 code, as the constant resolution moved.
13452 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13453 the metadata, so we can flag error 133.
13455 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13456 pointer is being declared in an unsafe context.
13458 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13460 * modifiers.cs (Modifiers.Check): Require a Location argument.
13461 Report error 227 for Unsafe use.
13463 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13465 * statement.cs (For.Emit): If the test is null, then report that
13466 we do `return', as we wont reach anything afterwards.
13468 (Switch.SwitchGoverningType): Track the expression that matched
13471 * driver.cs: Allow negative numbers as an error code to flag.
13473 * cs-parser.jay: Handle 1551.
13475 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13477 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13479 * cs-parser.jay: Report 1518 (type declaration can only contain
13480 class, struct, interface, enum or delegate)
13482 (switch_label): Report 1523 (keywords `case' or `default' must
13485 (opt_switch_sections): Report 1522 (empty switch)
13487 * driver.cs: Report 1515 (response file specified multiple times)
13488 Report 1516 (Source file specified multiple times).
13490 * expression.cs (Argument.Resolve): Signal 1510
13492 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13493 access not allowed in static code)
13495 2002-01-11 Ravi Pratap <ravi@ximian.com>
13497 * typemanager.cs (IsPointerType): Utility method which we are going
13500 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13501 the object type, so we take care of that.
13503 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13505 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13506 added to non-params parameters :-)
13508 * typemanager.cs (CSharpName): Include 'void' type too.
13510 (void_ptr_type): Include in the set of core types.
13512 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13515 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13518 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13519 completely forgotten about it.
13521 2002-01-10 Ravi Pratap <ravi@ximian.com>
13523 * cs-parser.jay (pointer_type): Add. This begins our implementation
13524 of parsing rules for unsafe code.
13526 (unsafe_statement): Implement.
13528 (embedded_statement): Modify to include the above.
13530 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13532 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13533 if the current context is an unsafe one.
13535 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13536 are handled differently, we need separate rules for them.
13538 (local_variable_declaration): Update to use local_variable_pointer_type
13539 to allow variable declarations of unmanaged pointer types.
13541 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13542 in unsafe contexts.
13544 * ../errors/cs0214.cs : Add.
13546 2002-01-16 Nick Drochak <ndrochak@gol.com>
13548 * makefile: remove 'response' file when cleaning.
13550 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13552 * cs-parser.jay: Report 1524.
13554 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13556 * typemanager.cs (RegisterMethod): drop checking if we have
13557 registered this from here
13559 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13561 * class.cs (Method.EmitDestructor): Implement calling our base
13564 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13565 value of InFinally.
13567 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13568 this routine and will wrap the call in a try/catch block. Deal
13571 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13573 * ecore.cs (Expression.MemberLookup): instead of taking a
13574 parameter `same_type' that was used to tell whether we could
13575 access private members we compute our containing type from the
13578 (FieldExpr): Added partial support for volatile fields. This does
13579 not work for volatile fields exposed from assemblies, as I can not
13580 figure out how to extract the modreq from it.
13582 Updated all the source files to use this.
13584 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13585 because it is referenced by MemberLookup very often.
13587 2002-01-09 Ravi Pratap <ravi@ximian.com>
13589 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13590 TypeBuilder.GetCustomAttributes to retrieve what we need.
13592 Get rid of redundant default_member_attr_type as this is the same as
13593 default_member_type which already exists.
13595 * interface.cs, attribute.cs : Update accordingly.
13597 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13599 * typemanager.cs: Enable IndexerPropertyName again. It does not
13600 work for TYpeBuilders though. Ravi, can you please fix this?
13602 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13604 * expression.cs (Argument.Emit): Handle the case of ref objects
13605 being passed to ref functions;
13607 (ParameterReference.EmitLoad): Loads the content of the pointer
13608 without dereferencing.
13610 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13612 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13614 2002-01-08 Ravi Pratap <ravi@ximian.com>
13616 * class.cs (Indexer.DefineMethod): Incorporate the interface
13617 type in the name of the method if we are doing explicit interface
13620 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13622 (BetterConversion): Fix extremely trivial bug where we were referring to
13623 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13626 * ../errors/bug16.cs : Add although we have fixed it.
13628 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13630 * expression.cs (BaseIndexer): Begin implementation.
13632 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13634 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13635 production directly to remove a shift/reduce, and implement
13636 explicit interface implementation.
13638 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13639 after a floating point suffix.
13641 * expression.cs (DoNumericPromotions): Improved the conversion for
13642 uint/uint. If we have a constant, we avoid doing a typecast to a
13645 * class.cs (Indexer): Implement explicit interface implementation
13648 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13650 * class.cs: make the default instance constructor public and hidebysig.
13652 2001-01-03 Ravi Pratap <ravi@ximian.com>
13654 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13655 so we can call it from elsewhere.
13657 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13658 we emit it internally if the class has a defined indexer; otherwise the user
13659 emits it by decorating the class definition with the DefaultMemberAttribute.
13661 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13662 attribute is not used on a type which defines an indexer.
13664 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13665 character when we skip whitespace.
13667 * ../errors/cs0646.cs : Add.
13669 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13671 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13674 * makefile: Add practical target `mcs3.exe' which builds the third
13675 generation compiler.
13677 * expression.cs (New): Fix structures constructor calling.
13679 * class.cs (Property, Method, Indexer): Emit Final flag on the
13680 method if we are an interface implementation and we are not
13683 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13684 whether this property is referencing a `base' method.
13686 * expression.cs (Invocation.EmitCall): take an extra argument:
13687 is_base, this is used to determine whether the `call' or
13688 `callvirt' opcode should be used.
13691 * delegate.cs: update EmitCall.
13693 * class.cs (Method.Define): Set NewSlot for the cases where we are
13694 not implementing an interface method.
13696 (Property.Define): ditto.
13698 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13700 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13701 'r'. Allows mcs to parse itself fully.
13703 2002-01-02 Ravi Pratap <ravi@ximian.com>
13705 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13706 of the number of initializers that require the InitializeArray method.
13708 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13709 update the above field where necessary.
13711 (MakeByteBlob): Update accordingly.
13713 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13716 (EmitDynamicInitializers): Update in accordance with the new optimization.
13718 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13719 same OpCode applies.
13721 * cs-parser.jay : Fix some glaring errors I introduced.
13723 2002-01-01 Ravi Pratap <ravi@ximian.com>
13725 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13726 so that we can check for name clashes there too.
13728 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13729 for interface indexers.
13731 * interfaces.cs (Define): Emit the default member attribute.
13733 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13734 variable was being referred to while setting the value ;-)
13736 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13738 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13739 byte-by-byte information when we know the data is zero.
13741 Make the block always a multiple of 4, because
13742 DefineInitializedData has a bug.
13744 * assign.cs: Fix, we should assign from the temporary, not from
13747 * expression.cs (MakeByteBlob): Fix my incorrect code.
13749 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13751 * typemanager.cs (EnumToUnderlying): This function is used to get
13752 the underlying type from an enumeration, because it does not
13755 * constant.cs: Use the I4_S form for values between -128 and 127.
13757 * statement.cs (Block.LookupLabel): Looks up a label.
13758 (Block): Drop support for labeled blocks.
13760 (LabeledStatement): New kind of statement that represents a label
13763 (Goto): Finally implement this bad boy.
13765 * cs-parser.jay: Update to reflect new mechanism to implement
13768 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13770 * codegen.cs (EmitContext.This): a codegen property that keeps the
13771 a single instance of this instead of creating many different this
13774 * delegate.cs (Delegate.DoResolve): Update to use the property;
13776 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13778 * expression.cs (BaseAccess.DoResolve): Ditto.
13780 2001-12-29 Ravi Pratap <ravi@ximian.com>
13782 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13783 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13785 (InitCoreTypes): Update accordingly.
13787 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13788 so we can quickly store the state.
13790 (ApplyAttributes): Set the correct implementation flags
13791 for InternalCall methods.
13793 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13795 * expression.cs (EmitCall): if a method is not virtual, then do
13796 not use callvirt on it.
13798 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13799 user defined stuff) requires the use of stobj, which takes an
13800 address on the stack instead of an array and an index. So emit
13801 the Ldelema operation for it.
13803 (EmitStoreOpcode): Use stobj for valuetypes.
13805 (UnaryMutator.EmitCode): Use the right 1 value depending on
13806 whether we are dealing with int64/uint64, float or doubles.
13808 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13809 constructors that I implemented last night.
13811 (Constructor.IsDefault): Fix to work properly for static
13814 * cs-parser.jay (CheckDef): report method signature errors.
13815 Update error number 103 to be 132.
13817 * decl.cs: New AdditionResult enumeration value: MethodExists.
13818 Although we do this check for methods later on in the semantic
13819 analysis, catching repeated default constructors is so easy that
13820 we catch these here.
13822 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13825 (ParameterReference.EmitAssign, Emit): handle
13828 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13829 (ArrayAccess.EmitStoreOpcode): ditto.
13831 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13833 * expression.cs (MakeByteBlob): Complete all the missing types
13834 (uint, short, ushort, byte, sbyte)
13836 * class.cs: Only init instance field initializers on instance
13839 Rename `constructors' to instance_constructors.
13841 (TypeContainer.AddConstructor): Only add constructors to the list
13842 if it is not static.
13844 Make sure that we handle default_static_constructor independently
13845 everywhere where we handle instance_constructors
13847 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13849 * class.cs: Do not lookup or create a base initializer for a
13850 static constructor.
13852 (ConstructorInitializer.Resolve): use the proper type to lookup
13855 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13857 * enum.cs, interface.cs: Remove CloseType, this is taken care by
13860 * decl.cs: CloseType is now an virtual method, the default
13861 implementation just closes this type.
13863 2001-12-28 Ravi Pratap <ravi@ximian.com>
13865 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
13866 to PreserveSig by default. Also emit HideBySig on such methods.
13868 Basically, set the defaults to standard values.
13870 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
13871 argument, if candidate is better, it can't be worse than the best !
13873 (Invocation): Re-write bits to differentiate between methods being
13874 applicable in their expanded form and their normal form - for params
13877 Get rid of use_standard everywhere as only standard conversions are allowed
13878 in overload resolution.
13880 More spec conformance.
13882 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13884 * driver.cs: Add --timestamp, to see where the compiler spends
13887 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
13888 `this' in static code.
13890 (SimpleName.DoResolve): Implement in terms of a helper function
13891 that allows static-references to be passed upstream to
13894 (Expression.ResolveWithSimpleName): Resolve specially simple
13895 names when called by MemberAccess to implement the special
13898 (Expression.ImplicitReferenceConversion): Handle conversions from
13899 Null to reference types before others, as Null's type is
13902 * expression.cs (Invocation.EmitCall): Handle the special case of
13903 calling methods declared on a reference type from a ValueType
13904 (Base classes System.Object and System.Enum)
13906 (MemberAccess.Resolve): Only perform lookups on Enumerations if
13907 the left hand side is a TypeExpr, not on every enumeration.
13909 (Binary.Resolve): If types are reference types, then do a cast to
13910 object on operators != and == of both arguments.
13912 * typemanager.cs (FindMembers): Extract instance and static
13913 members if requested.
13915 * interface.cs (PopulateProperty): Use void_type instead of null
13916 as the return type for the setter method.
13918 (PopulateIndexer): ditto.
13920 2001-12-27 Ravi Pratap <ravi@ximian.com>
13922 * support.cs (ReflectionParameters): Fix minor bug where we
13923 were examining the wrong parameter for the ParamArray attribute.
13925 Cope with requests for the type of the parameter at position
13926 greater than the params parameter's. We now return the element
13927 type of the params array as that makes more sense.
13929 * expression.cs (Invocation.IsParamsMethodApplicable): Update
13930 accordingly as we no longer have to extract the element type
13933 (Invocation.OverloadResolve): Update.
13935 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13937 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
13938 against IEnumerator, test whether the return value is a descendant
13939 of the IEnumerator interface.
13941 * class.cs (Indexer.Define): Use an auxiliary method to implement
13942 the other bits of the method definition. Begin support for
13943 explicit interface implementation.
13945 (Property.DefineMethod): Use TypeManager.void_type instead of null
13946 for an empty return value.
13948 2001-12-26 Miguel de Icaza <miguel@ximian.com>
13950 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
13951 dealing with a FieldExpr which is composed of a FieldBuilder, in
13952 the code path we did extract the constant, but we should have
13953 obtained the underlying value to be able to cast it (otherwise we
13954 end up in an infinite loop, this is what Ravi was running into).
13956 (ArrayCreation.UpdateIndices): Arrays might be empty.
13958 (MemberAccess.ResolveMemberAccess): Add support for section
13959 14.5.4.1 that deals with the special case of E.I when E is a type
13960 and something else, that I can be a reference to a static member.
13962 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
13963 handle a particular array type to create byte blobs, it is just
13964 something we dont generate byteblobs for.
13966 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
13969 * location.cs (Push): remove the key from the hashtable that we
13970 are about to add. This happens for empty files.
13972 * driver.cs: Dispose files after we have parsed them.
13974 (tokenize): new function that only runs the tokenizer on its
13975 input, for speed testing.
13977 2001-12-26 Ravi Pratap <ravi@ximian.com>
13979 * class.cs (Event.Define): Define the private field only if there
13980 are no accessors defined.
13982 * expression.cs (ResolveMemberAccess): If there is no associated
13983 field with the event, that means we have an event defined with its
13984 own accessors and we should flag error cs0070 since transforming
13985 ourselves into a field is not valid in that case.
13987 * ecore.cs (SimpleName.DoResolve): Same as above.
13989 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
13990 and charset to sane values.
13992 2001-12-25 Ravi Pratap <ravi@ximian.com>
13994 * assign.cs (DoResolve): Perform check on events only if they
13995 are being accessed outside the declaring type.
13997 * cs-parser.jay (event_declarations): Update rules to correctly
13998 set the type of the implicit parameter etc.
14000 (add_accessor, remove_accessor): Set current local parameters.
14002 * expression.cs (Binary): For delegate addition and subtraction,
14003 cast the return value from the method into the appropriate delegate
14006 2001-12-24 Ravi Pratap <ravi@ximian.com>
14008 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
14009 of these as the workaround is unnecessary.
14011 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
14012 delegate data - none of that is needed at all.
14014 Re-write bits to extract the instance expression and the delegate method
14017 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
14020 * attribute.cs (ApplyAttributes): New method to take care of common tasks
14021 of attaching attributes instead of duplicating code everywhere.
14023 * everywhere : Update code to do attribute emission using the above method.
14025 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14027 * expression.cs (IsParamsMethodApplicable): if there are not
14028 parameters, return immediately.
14030 * ecore.cs: The 0 literal can be implicity converted to an enum
14033 (SimpleName.DoResolve): First lookup the type, then lookup the
14036 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
14037 want to get its address. If the InstanceExpression is not
14038 addressable, store the result in a temporary variable, then get
14041 * codegen.cs: Only display 219 errors on warning level or above.
14043 * expression.cs (ArrayAccess): Make it implement the
14044 IMemoryLocation interface.
14046 (Binary.DoResolve): handle the operator == (object a, object b)
14047 and operator != (object a, object b) without incurring into a
14048 BoxedCast (because 5 != o should never be performed).
14050 Handle binary enumerator operators.
14052 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
14053 value type, otherwise use Ldelem_ref.
14055 Use precomputed names;
14057 (AddressOf): Implement address of
14059 * cs-parser.jay (labeled_statement): Fix recursive block
14060 addition by reworking the production.
14062 * expression.cs (New.DoEmit): New has a special case:
14064 If we are dealing with a ValueType, we have a few
14065 situations to deal with:
14067 * The target of New is a ValueType variable, that is
14068 easy, we just pass this as the variable reference
14070 * The target of New is being passed as an argument,
14071 to a boxing operation or a function that takes a
14074 In this case, we need to create a temporary variable
14075 that is the argument of New.
14078 2001-12-23 Ravi Pratap <ravi@ximian.com>
14080 * rootcontext.cs (LookupType): Check that current_type is not null before
14081 going about looking at nested types.
14083 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
14084 not implement the IAssignMethod interface any more.
14086 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
14087 where we tranform them into FieldExprs if they are being resolved from within
14088 the declaring type.
14090 * ecore.cs (SimpleName.DoResolve): Do the same here.
14092 * assign.cs (DoResolve, Emit): Clean up code considerably.
14094 * ../errors/bug10.cs : Add.
14096 * ../errors/cs0070.cs : Add.
14098 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
14100 * assign.cs : Get rid of EventIsLocal everywhere.
14102 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14104 * ecore.cs (ConvertIntLiteral): finished the implementation.
14106 * statement.cs (SwitchLabel): Convert the value we are using as a
14107 key before looking up the table.
14109 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14111 * codegen.cs (EmitTopBlock): Require a Location argument now.
14113 * cs-parser.jay (constructor_declarator): We need to setup
14114 current_local_parameters before we parse the
14115 opt_constructor_initializer, to allow the variables to be bound
14116 to the constructor arguments.
14118 * rootcontext.cs (LookupType): First lookup nested classes in our
14119 class and our parents before we go looking outside our class.
14121 * expression.cs (ConstantFold): Extract/debox the values at the
14124 * rootcontext.cs (EmitCode): Resolve the constants first before we
14125 resolve the types. This is not really needed, but it helps debugging.
14127 * statement.cs: report location.
14129 * cs-parser.jay: pass location to throw statement.
14131 * driver.cs: Small bug fix.
14133 * report.cs: Updated format to be 4-zero filled digits.
14135 2001-12-22 Ravi Pratap <ravi@ximian.com>
14137 * expression.cs (CheckIndices): Fix minor bug where the wrong
14138 variable was being referred to ;-)
14140 (DoEmit): Do not call EmitStaticInitializers when the
14141 underlying type is System.Object.
14143 2001-12-21 Ravi Pratap <ravi@ximian.com>
14145 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
14146 and do the usual workaround for SRE.
14148 * class.cs (MyEventBuilder.EventType): New member to get at the type
14149 of the event, quickly.
14151 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
14153 * assign.cs (Assign.DoResolve): Handle the case when the target
14154 is an EventExpr and perform the necessary checks.
14156 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
14159 (SimpleName.MemberStaticCheck): Include check for EventExpr.
14161 (EventExpr): Set the type in the constructor itself since we
14162 are meant to be born fully resolved.
14164 (EventExpr.Define): Revert code I wrote earlier.
14166 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
14167 instance expression is null. The instance expression is a This in that case
14168 or a null, depending on whether it is a static method or not.
14170 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
14171 refers to more than one method.
14173 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
14174 and accordingly flag errors.
14176 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14178 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
14180 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14182 * location.cs (ToString): Provide useful rutine.
14184 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14186 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
14187 objects, return the actual integral boxed.
14189 * statement.cs (SwitchLabel): define an ILLabel for each
14192 (Switch.CheckSwitch): If the value is a Literal, extract
14193 the underlying literal.
14195 Also in the unused hashtable we had, add the SwitchLabel so we can
14196 quickly look this value up.
14198 * constant.cs: Implement a bunch of new constants. Rewrite
14199 Literal based on this. Made changes everywhere to adapt to this.
14201 * expression.cs (Expression.MakeByteBlob): Optimize routine by
14202 dereferencing array only once, and also copes with enumrations.
14204 bytes are two bytes wide, not one.
14206 (Cast): Perform constant conversions.
14208 * ecore.cs (TryImplicitIntConversion): Return literals instead of
14209 wrappers to the literals here.
14211 * expression.cs (DoNumericPromotions): long literals can converted
14212 to ulong implicity (this is taken care of elsewhere, but I was
14213 missing this spot).
14215 * ecore.cs (Expression.Literalize): Make the return type Literal,
14216 to improve type checking.
14218 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
14220 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14222 * literal.cs: Revert code from ravi that checked the bounds. The
14223 bounds are sane by the definition of the type itself.
14225 * typemanager.cs: Fix implementation of ImplementsInterface. We
14226 need to actually look up in our parent hierarchy for interfaces
14229 * const.cs: Use the underlying type for enumerations
14231 * delegate.cs: Compute the basename for the delegate creation,
14232 that should fix the delegate test case, and restore the correct
14233 Type Lookup semantics in rootcontext
14235 * rootcontext.cs: Revert Ravi's last patch. The correct way of
14236 referencing a nested type with the Reflection API is using the "+"
14239 * cs-parser.jay: Do not require EOF token at the end.
14241 2001-12-20 Ravi Pratap <ravi@ximian.com>
14243 * rootcontext.cs (LookupType): Concatenate type names with
14244 a '.' instead of a '+' The test suite passes again.
14246 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
14247 field of the enumeration.
14249 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
14250 the case when the member is an EventExpr.
14252 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
14253 static has an associated instance expression.
14255 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
14257 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
14259 * class.cs (Event.Define): Register event and perform appropriate checks
14262 We define the Add and Remove methods even if the use provides none because
14263 in that case, we provide default implementations ourselves.
14265 Define a private field of the type of the event. This is done by the CSC compiler
14266 and we should be doing it too ;-)
14268 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
14269 More methods we use in code we generate.
14271 (multicast_delegate_type, delegate_type): Two separate types since the distinction
14274 (InitCoreTypes): Update accordingly for the above.
14276 * class.cs (Event.Emit): Generate code for default accessors that we provide
14278 (EmitDefaultMethod): Do the job in the above.
14280 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
14283 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14285 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
14286 builders even if we were missing one.
14288 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
14289 pass the Basename as our class name instead of the Name. The
14290 basename will be correctly composed for us.
14292 * parameter.cs (Paramters): Now takes a Location argument.
14294 * decl.cs (DeclSpace.LookupType): Removed convenience function and
14295 make all the code call directly LookupType in RootContext and take
14296 this chance to pass the Location information everywhere.
14298 * Everywhere: pass Location information.
14300 2001-12-19 Miguel de Icaza <miguel@ximian.com>
14302 * class.cs (Constructor.Define): Updated way of detecting the
14303 length of the parameters.
14305 (TypeContainer.DefineType): Use basename as the type name for
14308 (TypeContainer.Define): Do not recursively define types here, as
14309 definition is taken care in order by the RootContext.
14311 * tree.cs: Keep track of namespaces in a per-file basis.
14313 * parameter.cs (Parameter.ComputeSignature): Update to use
14316 (Parameters.GetSignature): ditto.
14318 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
14319 instead of a TypeContainer.
14321 (Interface.SemanticAnalysis): Use `this' instead of our parent to
14322 resolve names. Because we need to be resolve in our context, not
14325 * driver.cs: Implement response files.
14327 * class.cs (TypeContainer.DefineType): If we are defined, do not
14328 redefine ourselves.
14330 (Event.Emit): Emit the code for add/remove handlers.
14331 (Event.Define): Save the MethodBuilders for add/remove.
14333 * typemanager.cs: Use pair here too.
14335 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14336 DictionaryEntry requires the first argument to be non-null.
14338 (enum_declaration): Compute full name for registering the
14341 (delegate_declaration): Instead of using
14342 formal_parameter_list, use opt_formal_parameter_list as the list
14345 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14346 (EventParsing): New property that controls whether `add' and
14347 `remove' are returned as tokens or identifiers (for events);
14349 2001-12-19 Ravi Pratap <ravi@ximian.com>
14351 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14352 use MyEventBuilder only and let it wrap the real builder for us.
14354 (MyEventBuilder): Revamp constructor etc.
14356 Implement all operations that we perform on EventBuilder in precisely the same
14359 (FindMembers): Update to use the EventBuilder member.
14361 (Event.Emit): Update accordingly.
14363 2001-12-18 Ravi Pratap <ravi@ximian.com>
14365 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14366 by calling the appropriate methods.
14368 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14371 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14373 2001-12-17 Ravi Pratap <ravi@ximian.com>
14375 * delegate.cs (Delegate.Populate): Check that the return type
14376 and various parameters types are indeed accessible.
14378 * class.cs (Constructor.Define): Same here.
14380 (Field.Define): Ditto.
14382 (Event.Define): Ditto.
14384 (Operator.Define): Check that the underlying Method defined itself
14385 correctly - so it's MethodBuilder should not be null.
14387 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14388 expression happens to be null.
14390 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14391 members but as of now we don't seem to be able to do anything really useful with it.
14393 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14394 not the EventBuilder.
14396 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14398 * cs-tokenizer.cs: Add support for defines.
14399 Add support for #if, #elif, #else, #endif
14401 (eval_var): evaluates a variable.
14402 (eval): stubbed for evaluating functions.
14404 * cs-parser.jay: Pass the defines information
14406 * driver.cs: Add --define command line option.
14408 * decl.cs: Move MemberCore here.
14410 Make it the base class for DeclSpace. This allows us to catch and
14411 report 108 and 109 for everything now.
14413 * class.cs (TypeContainer.Define): Extract all the members
14414 before populating and emit the warning 108 (new keyword required
14415 to override) instead of having each member implement this.
14417 (MemberCore.Define): New abstract method, we will be using this in
14418 the warning reporting engine in Populate.
14420 (Operator.Define): Adjust to new MemberCore protocol.
14422 * const.cs (Const): This does not derive from Expression, it is a
14423 temporary object we use to create fields, it is a MemberCore.
14425 * class.cs (Method.Define): Allow the entry point to be in a
14428 * driver.cs: Rewrite the argument handler to clean it up a bit.
14430 * rootcontext.cs: Made it just an auxiliary namespace feature by
14431 making everything static.
14433 * driver.cs: Adapt code to use RootContext type name instead of
14436 * delegate.cs: Remove RootContext argument.
14438 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14441 * class.cs (Event.Define): The lookup can fail.
14443 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14445 * expression.cs: Resolve the this instance before invoking the code.
14447 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14449 * cs-parser.jay: Add a production in element_access that allows
14450 the thing to become a "type" reference. This way we can parse
14451 things like "(string [])" as a type.
14453 Note that this still does not handle the more complex rules of
14457 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14459 * ecore.cs: (CopyNewMethods): new utility function used to
14460 assemble the list of methods from running FindMembers.
14462 (MemberLookup): Rework FindMembers so that
14464 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14466 * class.cs (TypeContainer): Remove Delegates who fail to be
14469 * delegate.cs (Populate): Verify that we dont get null return
14470 values. TODO: Check for AsAccessible.
14472 * cs-parser.jay: Use basename to emit error 574 (destructor should
14473 have the same name as container class), not the full name.
14475 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14476 possible representation.
14478 Also implements integer type suffixes U and L.
14480 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14482 * expression.cs (ArrayCreation.DoResolve): We need to do the
14483 argument resolution *always*.
14485 * decl.cs: Make this hold the namespace. Hold the root context as
14487 (LookupType): Move here.
14489 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14491 * location.cs (Row, Name): Fixed the code, it was always returning
14492 references to the first file.
14494 * interface.cs: Register properties defined through interfaces.
14496 * driver.cs: Add support for globbing on the command line
14498 * class.cs (Field): Make it derive from MemberCore as well.
14501 2001-12-15 Ravi Pratap <ravi@ximian.com>
14503 * class.cs (Event::Define): Check that the type of the event is a delegate
14504 type else flag error #66.
14506 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14509 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14510 values of EntryPoint, CharSet etc etc.
14512 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14514 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14515 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14516 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14517 which needs this to do its work.
14519 * ../errors/cs0066.cs : Add.
14521 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14523 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14526 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14527 clears out the parameters field.
14528 (MemberSignatureCompare): Cleanup
14530 (MemberCore): New base class used to share code between MethodCore
14533 (RegisterRequiredImplementations) BindingFlags.Public requires
14534 either BindingFlags.Instace or Static. Use instance here.
14536 (Property): Refactored code to cope better with the full spec.
14538 * parameter.cs (GetParameterInfo): Return an empty array instead
14541 * class.cs (Property): Abstract or extern properties have no bodies.
14543 * parameter.cs (GetParameterInfo): return a zero-sized array.
14545 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14546 method modifier validation to the typecontainer so we can reuse
14547 this on properties.
14549 (MethodCore.ParameterTypes): return an empty sized array of types.
14551 (Property.Define): Test property modifier validity.
14553 Add tests for sealed/override too.
14555 (Method.Emit): abstract or extern methods have no bodies.
14557 2001-12-14 Ravi Pratap <ravi@ximian.com>
14559 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14562 (Method::Define, ::Emit): Modify accordingly.
14564 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14566 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14568 * makefile: Pass in /unsafe.
14570 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14572 * class.cs (MakeKey): Kill routine.
14574 * class.cs (TypeContainer.Define): Correctly define explicit
14575 method implementations (they require the full interface name plus
14578 * typemanager.cs: Deply the PtrHashtable here and stop using the
14579 lame keys. Things work so much better.
14581 This of course broke everyone who depended on `RegisterMethod' to
14582 do the `test for existance' test. This has to be done elsewhere.
14584 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14585 the object stupid Equals method (because, that like fails all over
14586 the place). We still do not use it.
14588 * class.cs (TypeContainer.SetRequiredInterface,
14589 TypeContainer.RequireMethods): Killed these two routines and moved
14590 all the functionality to RegisterRequiredImplementations.
14592 (TypeContainer.RegisterRequiredImplementations): This routine now
14593 registers all the implementations required in an array for the
14594 interfaces and abstract methods. We use an array of structures
14595 which can be computed ahead of time to reduce memory usage and we
14596 also assume that lookups are cheap as most classes will not
14597 implement too many interfaces.
14599 We also avoid creating too many MethodSignatures.
14601 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14602 clear the "pending" bit if we find that there are problems with
14605 (TypeContainer.VerifyPendingMethods): Update to report errors of
14606 methods that look like implementations but are not.
14608 (TypeContainer.Define): Add support for explicit interface method
14611 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14613 * typemanager.cs: Keep track of the parameters here instead of
14614 being a feature of the TypeContainer.
14616 * class.cs: Drop the registration of parameters here, as
14617 InterfaceMethods are also interface declarations.
14619 * delegate.cs: Register methods with the TypeManager not only with
14620 the TypeContainer. This code was buggy.
14622 * interface.cs: Full registation here.
14624 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14626 * expression.cs: Remove reducer for binary expressions, it can not
14629 * const.cs: Put here the code that used to go into constant.cs
14631 * constant.cs: Put here the code for constants, this is a new base
14632 class for Literals.
14634 * literal.cs: Make Literal derive from Constant.
14636 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14638 * statement.cs (Return.Emit): Report error 157 if the user
14639 attempts to return from a finally block.
14641 (Return.Emit): Instead of emitting a return, jump to the end of
14644 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14645 LocalBuilder to store the result of the function. ReturnLabel is
14646 the target where we jump.
14649 2001-12-09 Radek Doulik <rodo@ximian.com>
14651 * cs-parser.jay: remember alias in current namespace
14653 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14656 * class.cs (LookupAlias): lookup alias in my_namespace
14658 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14660 (LookupAlias): lookup alias in this and if needed in parent
14663 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14667 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14668 making things static. I need this to avoid passing the
14669 TypeContainer when calling ParameterType.
14671 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14672 that did string manipulation to compute the type and then call
14673 GetType. Use Parameter.ParameterType instead.
14675 * cs-tokenizer.cs: Consume the suffix for floating values.
14677 * expression.cs (ParameterReference): figure out whether this is a
14678 reference parameter or not. Kill an extra variable by computing
14679 the arg_idx during emission.
14681 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14682 function that returns whether a parameter is an out/ref value or not.
14684 (Parameter.ParameterType): The type of the parameter (base,
14685 without ref/out applied).
14687 (Parameter.Resolve): Perform resolution here.
14688 (Parameter.ExternalType): The full type (with ref/out applied).
14690 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14691 support for expressions on the using statement.
14693 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14695 * statement.cs (Using.EmitLocalVariableDecls): Split the
14696 localvariable handling of the using statement.
14698 (Block.EmitMeta): Keep track of variable count across blocks. We
14699 were reusing slots on separate branches of blocks.
14701 (Try.Emit): Emit the general code block, we were not emitting it.
14703 Check the type of the declaration to be an IDisposable or
14704 something that can be implicity converted to it.
14706 Emit conversions if required.
14708 * ecore.cs (EmptyExpression): New utility class.
14709 (Expression.ImplicitConversionExists): New utility function.
14711 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14713 * statement.cs (Using): Implement.
14715 * expression.cs (LocalVariableReference): Support read only variables.
14717 * statement.cs: Remove the explicit emit for the Leave opcode.
14718 (VariableInfo): Add a readonly field.
14720 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14722 * ecore.cs (ConvCast): new class used to encapsulate the various
14723 explicit integer conversions that works in both checked and
14724 unchecked contexts.
14726 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14727 properly generate the overflow opcodes.
14729 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14731 * statement.cs: The correct type for the EmptyExpression is the
14732 element_type, not the variable type. Ravi pointed this out.
14734 2001-12-04 Ravi Pratap <ravi@ximian.com>
14736 * class.cs (Method::Define): Handle PInvoke methods specially
14737 by using DefinePInvokeMethod instead of the usual one.
14739 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14740 above to do the task of extracting information and defining the method.
14742 2001-12-04 Ravi Pratap <ravi@ximian.com>
14744 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14745 of the condition for string type.
14747 (Emit): Move that here.
14749 (ArrayCreation::CheckIndices): Keep string literals in their expression
14752 (EmitDynamicInitializers): Handle strings appropriately.
14754 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14756 * codegen.cs (EmitContext): Replace multiple variables with a
14757 single pointer to the current Switch statement.
14759 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14762 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14766 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14769 (Foreach.Emit): Foreach on arrays was not setting
14770 up the loop variables (for break/continue).
14772 (GotoCase): Semi-implented.
14774 2001-12-03 Ravi Pratap <ravi@ximian.com>
14776 * attribute.cs (CheckAttribute): Handle system attributes by using
14777 Attribute.GetAttributes to examine information we need.
14779 (GetValidPlaces): Same here.
14781 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14783 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14785 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14787 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14789 (Method::Emit): Handle the case when we are a PInvoke method.
14791 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14793 * expression.cs: Use ResolveWithSimpleName on compound names.
14795 2001-12-02 Ravi Pratap <ravi@ximian.com>
14797 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14798 before trying to reduce it.
14800 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14802 * constant.cs (LookupConstantValue): Implement.
14804 (EmitConstant): Use the above in emitting the constant.
14806 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14807 that are user-defined by doing a LookupConstantValue on them.
14809 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14812 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14814 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14816 (BaseAccess.DoResolve): Implement.
14818 (MemberAccess.DoResolve): Split this routine into a
14819 ResolveMemberAccess routine that can be used independently
14821 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14823 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14824 As that share bits of the implementation. Is returns a boolean,
14825 while As returns the Type that is being probed.
14827 2001-12-01 Ravi Pratap <ravi@ximian.com>
14829 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14830 instead of a Literal - much easier.
14832 (EnumInTransit): Remove - utterly useless :-)
14834 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14836 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14838 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14839 chain when we have no associated expression.
14841 2001-11-30 Ravi Pratap <ravi@ximian.com>
14843 * constant.cs (Define): Use Location while reporting the errror.
14845 Also emit a warning when 'new' is used and there is no inherited
14848 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14851 (LookupEnumValue): Implement to lookup an enum member's value and define it
14854 (Populate): Re-write accordingly to use the above routine.
14856 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14858 * expression.cs (This): Fix prototype for DoResolveLValue to
14859 override the base class DoResolveLValue.
14861 * cs-parser.cs: Report errors cs574 and cs575 (destructor
14864 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
14865 (we need to load the address of the field here). This fixes
14868 (FieldExpr.DoResolveLValue): Call the DoResolve
14869 function to initialize the Instance expression.
14871 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
14872 correctly the GetEnumerator operation on a value type.
14874 * cs-parser.jay: Add more simple parsing error catches.
14876 * statement.cs (Switch): Add support for string switches.
14877 Handle null specially.
14879 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
14881 2001-11-28 Ravi Pratap <ravi@ximian.com>
14883 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
14885 (declare_local_constant): New helper function.
14887 * statement.cs (AddConstant): Keep a separate record of constants
14889 (IsConstant): Implement to determine if a variable is a constant.
14891 (GetConstantExpression): Implement.
14893 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
14895 * statement.cs (IsVariableDefined): Re-write.
14897 2001-11-27 Ravi Pratap <ravi@ximian.com>
14899 * class.cs (TypeContainer::FindMembers): Look for constants
14900 in the case when we are looking for MemberTypes.Field
14902 * expression.cs (MemberAccess::DoResolve): Check that in the
14903 case we are a FieldExpr and a Literal, we are not being accessed
14904 by an instance reference.
14906 * cs-parser.jay (local_constant_declaration): Implement.
14908 (declaration_statement): Implement for constant declarations.
14910 2001-11-26 Miguel de Icaza <miguel@ximian.com>
14912 * statement.cs (Switch): Catch double defaults.
14914 (Switch): More work on the switch() statement
14915 implementation. It works for integral values now, need to finish
14919 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14921 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
14922 integer literals into other integer literals. To be used by
14925 2001-11-24 Ravi Pratap <ravi@ximian.com>
14927 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
14930 (EmitDynamicInitializers): Cope with the above since we extract data
14931 directly from ArrayData now.
14933 (ExpectInitializers): Keep track of whether initializers are mandatory
14936 (Bounds): Make it a hashtable to prevent the same dimension being
14937 recorded for every element in that dimension.
14939 (EmitDynamicInitializers): Fix bug which prevented the Set array method
14942 Also fix bug which was causing the indices to be emitted in the reverse
14945 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14947 * expression.cs (ArrayCreation): Implement the bits that Ravi left
14948 unfinished. They do not work, because the underlying code is
14951 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14953 * cs-parser.jay: Remove bogus fixme.
14955 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
14956 on Switch statement.
14958 2001-11-23 Ravi Pratap <ravi@ximian.com>
14960 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
14963 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
14964 parameter. Apparently, any expression is allowed.
14966 (ValidateInitializers): Update accordingly.
14968 (CheckIndices): Fix some tricky bugs thanks to recursion.
14970 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
14971 I was being completely brain-dead.
14973 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
14974 and re-write acordingly.
14976 (DelegateInvocation): Re-write accordingly.
14978 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
14980 (MakeByteBlob): Handle types more correctly.
14982 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
14983 initialization from expressions but it is incomplete because I am a complete
14986 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14988 * statement.cs (If.Emit): Fix a bug that generated incorrect code
14989 on If. Basically, we have to return `true' (ie, we do return to
14990 our caller) only if both branches of the if return.
14992 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
14993 short-circuit operators, handle them as short circuit operators.
14995 (Cast.DoResolve): Resolve type.
14996 (Cast.Cast): Take an expression as the target type.
14998 * cs-parser.jay (cast_expression): Remove old hack that only
14999 allowed a limited set of types to be handled. Now we take a
15000 unary_expression and we resolve to a type during semantic
15003 Use the grammar productions from Rhys to handle casts (this is
15004 not complete like Rhys syntax yet, we fail to handle that corner
15005 case that C# has regarding (-x), but we will get there.
15007 2001-11-22 Ravi Pratap <ravi@ximian.com>
15009 * class.cs (EmitFieldInitializer): Take care of the case when we have a
15010 field which is an array type.
15012 * cs-parser.jay (declare_local_variables): Support array initialization too.
15014 * typemanager.cs (MakeKey): Implement.
15016 (everywhere): Use the above appropriately.
15018 * cs-parser.jay (for_statement): Update for array initialization while
15019 declaring variables.
15021 * ecore.cs : The error message was correct, it's the variable's names that
15022 were misleading ;-) Make the code more readable.
15024 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
15025 the correct type etc.
15027 (ConvertExplicit): Handle Enum types by examining the underlying type.
15029 2001-11-21 Ravi Pratap <ravi@ximian.com>
15031 * parameter.cs (GetCallingConvention): Always return
15032 CallingConventions.Standard for now.
15034 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15036 * expression.cs (Binary.ResolveOperator): Update the values of `l'
15037 and `r' after calling DoNumericPromotions.
15039 * ecore.cs: Fix error message (the types were in the wrong order).
15041 * statement.cs (Foreach.ProbeCollectionType): Need to pass
15042 BindingFlags.Instance as well
15044 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
15045 implicit int literal conversion in an empty cast so that we
15046 propagate the right type upstream.
15048 (UnboxCast): new class used to unbox value types.
15049 (Expression.ConvertExplicit): Add explicit type conversions done
15052 (Expression.ImplicitNumericConversion): Oops, forgot to test for
15053 the target type before applying the implicit LongLiterals to ULong
15056 2001-11-21 Miguel de Icaza <miguel@ximian.com>
15058 * cs-parser.jay (for_statement): Reworked the way For works: now
15059 we declare manually any variables that are introduced in
15060 for_initializer to solve the problem of having out-of-band code
15061 emition (that is what got for broken).
15063 (declaration_statement): Perform the actual variable declaration
15064 that used to be done in local_variable_declaration here.
15066 (local_variable_declaration): Do not declare anything, just pass
15067 the information on a DictionaryEntry
15069 2001-11-20 Ravi Pratap <ravi@ximian.com>
15071 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
15072 re-write of the logic to now make it recursive.
15074 (UpdateIndices): Re-write accordingly.
15076 Store element data in a separate ArrayData list in the above methods.
15078 (MakeByteBlob): Implement to dump the array data into a byte array.
15080 2001-11-19 Ravi Pratap <ravi@ximian.com>
15082 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
15085 * constant.cs (Define): Implement.
15087 (EmitConstant): Re-write fully.
15089 Pass in location info.
15091 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
15094 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
15095 DictionaryEntry since we need location info too.
15097 (constant_declaration): Update accordingly.
15099 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
15100 code into another method : UpdateIndices.
15102 2001-11-18 Ravi Pratap <ravi@ximian.com>
15104 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
15105 some type checking etc.
15107 2001-11-17 Ravi Pratap <ravi@ximian.com>
15109 * expression.cs (ArrayCreation::ValidateInitializers): Implement
15110 bits to provide dimension info if the user skips doing that.
15112 Update second constructor to store the rank correctly.
15114 2001-11-16 Ravi Pratap <ravi@ximian.com>
15116 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
15117 and try to implement.
15119 * ../errors/cs0150.cs : Add.
15121 * ../errors/cs0178.cs : Add.
15123 2001-11-16 Miguel de Icaza <miguel@ximian.com>
15125 * statement.cs: Implement foreach on multi-dimensional arrays.
15127 * parameter.cs (Parameters.GetParameterByName): Also lookup the
15128 name of the params argument.
15130 * expression.cs: Use EmitStoreOpcode to get the right opcode while
15131 initializing the array.
15133 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
15134 we can use this elsewhere.
15136 * statement.cs: Finish implementation of foreach for single
15139 * cs-parser.jay: Use an out-of-band stack to pass information
15140 around, I wonder why I need this.
15142 foreach_block: Make the new foreach_block the current_block.
15144 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
15145 function used to return a static Parameters structure. Used for
15146 empty parameters, as those are created very frequently.
15148 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
15150 2001-11-15 Ravi Pratap <ravi@ximian.com>
15152 * interface.cs : Default modifier is private, not public. The
15153 make verify test passes again.
15155 2001-11-15 Ravi Pratap <ravi@ximian.com>
15157 * support.cs (ReflectionParameters): Fix logic to determine
15158 whether the last parameter is a params one. Test 9 passes again.
15160 * delegate.cs (Populate): Register the builders we define with
15161 RegisterParameterForBuilder. Test 19 passes again.
15163 * cs-parser.jay (property_declaration): Reference $6 instead
15164 of $$ to get at the location.
15166 (indexer_declaration): Similar stuff.
15168 (attribute): Ditto.
15170 * class.cs (Property): Register parameters for the Get and Set methods
15171 if they exist. Test 23 passes again.
15173 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
15174 call to EmitArguments as we are sure there aren't any params arguments.
15175 Test 32 passes again.
15177 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
15178 IndexOutOfRangeException.
15180 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
15181 Test 33 now passes again.
15183 2001-11-15 Miguel de Icaza <miguel@ximian.com>
15185 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
15186 broke a bunch of things. Will have to come up with a better way
15187 of tracking locations.
15189 * statement.cs: Implemented foreach for single dimension arrays.
15191 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15193 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
15194 an error. This removes the lookup from the critical path.
15196 * cs-parser.jay: Removed use of temporary_loc, which is completely
15199 2001-11-14 Miguel de Icaza <miguel@ximian.com>
15201 * support.cs (ReflectionParameters.ParameterModifier): Report
15202 whether the argument is a PARAMS argument or not.
15204 * class.cs: Set the attribute `ParamArrayAttribute' on the
15205 parameter argument.
15207 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
15208 and cons_param_array_attribute (ConstructorInfo for
15209 ParamArrayAttribute).,
15211 * codegen.cs: Emit the return using the `Return' statement, that
15212 way we can report the error correctly for missing return values.
15214 * class.cs (Method.Emit): Clean up.
15216 * expression.cs (Argument.Resolve): Take another argument: the
15217 location where this argument is used. Notice that this is not
15218 part of the "Argument" class as to reduce the size of the
15219 structure (we know the approximate location anyways).
15221 Test if the argument is a variable-reference, if not, then
15222 complain with a 206.
15224 (Argument.Emit): Emit addresses of variables.
15226 (Argument.FullDesc): Simplify.
15228 (Invocation.DoResolve): Update for Argument.Resolve.
15230 (ElementAccess.DoResolve): ditto.
15232 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
15233 method should be virtual, as this method is always virtual.
15235 (NewDelegate.DoResolve): Update for Argument.Resolve.
15237 * class.cs (ConstructorInitializer.DoResolve): ditto.
15239 * attribute.cs (Attribute.Resolve): ditto.
15241 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15243 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
15245 * expression.cs (ParameterReference): Drop IStackStorage and implement
15246 IAssignMethod instead.
15248 (LocalVariableReference): ditto.
15250 * ecore.cs (FieldExpr): Drop IStackStorage and implement
15251 IAssignMethod instead.
15253 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15255 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
15256 enumerations that are used in heavily used structures derive from
15257 byte in a laughable and pathetic attempt to reduce memory usage.
15258 This is the kind of pre-optimzations that you should not do at
15259 home without adult supervision.
15261 * expression.cs (UnaryMutator): New class, used to handle ++ and
15262 -- separatedly from the other unary operators. Cleans up the
15263 code, and kills the ExpressionStatement dependency in Unary.
15265 (Unary): Removed `method' and `Arguments' from this class, making
15266 it smaller, and moving it all to SimpleCall, so I can reuse this
15267 code in other locations and avoid creating a lot of transient data
15268 strucutres when not required.
15270 * cs-parser.jay: Adjust for new changes.
15272 2001-11-11 Miguel de Icaza <miguel@ximian.com>
15274 * enum.cs (Enum.Populate): If there is a failure during
15277 * cs-parser.jay (opt_enum_base): we used to catch type errors
15278 here, but this is really incorrect. The type error should be
15279 catched during semantic analysis.
15281 2001-12-11 Ravi Pratap <ravi@ximian.com>
15283 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
15284 current_local_parameters as expected since I, in my stupidity, had forgotten
15287 * attribute.cs (GetValidPlaces): Fix stupid bug.
15289 * class.cs (Method::Emit): Perform check on applicability of attributes.
15291 (Constructor::Emit): Ditto.
15293 (Field::Emit): Ditto.
15295 (Field.Location): Store location information.
15297 (Property, Event, Indexer, Operator): Ditto.
15299 * cs-parser.jay (field_declaration): Pass in location for each field.
15301 * ../errors/cs0592.cs : Add.
15303 2001-11-12 Ravi Pratap <ravi@ximian.com>
15305 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
15307 (InitCoreTypes): Update accordingly.
15309 (RegisterAttrType, LookupAttr): Implement.
15311 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
15312 info about the same.
15314 (Resolve): Update to populate the above as necessary.
15316 (Error592): Helper.
15318 (GetValidPlaces): Helper to the above.
15320 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
15322 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
15324 2001-11-12 Ravi Pratap <ravi@ximian.com>
15326 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
15328 * ../errors/cs0617.cs : Add.
15330 2001-11-11 Ravi Pratap <ravi@ximian.com>
15332 * enum.cs (Emit): Rename to Populate to be more consistent with what
15333 we expect it to do and when exactly it is called.
15335 * class.cs, rootcontext.cs : Update accordingly.
15337 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15338 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15340 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15342 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15343 of a fieldinfo using the above, when dealing with a FieldBuilder.
15345 2001-11-10 Ravi Pratap <ravi@ximian.com>
15347 * ../errors/cs0031.cs : Add.
15349 * ../errors/cs1008.cs : Add.
15351 * ../errrors/cs0543.cs : Add.
15353 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15356 (FindMembers): Implement.
15358 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15359 enums and delegates too.
15361 (enum_types): Rename to builder_to_enum.
15363 (delegate_types): Rename to builder_to_delegate.
15365 * delegate.cs (FindMembers): Implement.
15367 2001-11-09 Ravi Pratap <ravi@ximian.com>
15369 * typemanager.cs (IsEnumType): Implement.
15371 * enum.cs (Emit): Re-write parts to account for the underlying type
15372 better and perform checking etc.
15374 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15375 of the underlying type.
15377 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15380 * enum.cs (error31): Helper to report error #31.
15382 * cs-parser.jay (enum_declaration): Store location of each member too.
15384 * enum.cs (member_to_location): New hashtable.
15386 (AddEnumMember): Update location hashtable.
15388 (Emit): Use the location of each member while reporting errors.
15390 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15392 * cs-parser.jay: A for_initializer if is a
15393 local_variable_declaration really ammount to have an implicit
15394 block with the variable declaration and no initializer for for.
15396 * statement.cs (For.Emit): Cope with null initializers.
15398 This fixes the infinite loop on for initializers.
15400 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15402 * enum.cs: More cleanup.
15404 * ecore.cs: Remove dead code.
15406 * class.cs (Property.Emit): More simplification.
15407 (Event.Emit): ditto.
15409 Reworked to have less levels of indentation.
15411 2001-11-08 Ravi Pratap <ravi@ximian.com>
15413 * class.cs (Property): Emit attributes.
15423 * enum.cs (Emit): Ditto.
15425 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15428 * class.cs (Field, Event, etc.): Move attribute generation into the
15429 Emit method everywhere.
15431 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15432 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15433 as we had no way of defining nested enums !
15435 * rootcontext.cs : Adjust code accordingly.
15437 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15439 2001-11-07 Ravi Pratap <ravi@ximian.com>
15441 * expression.cs (EvalConstantExpression): Move into ecore.cs
15443 * enum.cs (Enum): Rename some members and make them public and readonly
15444 according to our convention.
15446 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15449 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15451 (Enum::Emit): Write a simple version for now which doesn't try to compute
15452 expressions. I shall modify this to be more robust in just a while.
15454 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15456 (TypeContainer::CloseType): Create the Enum types too.
15458 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15460 * expression.cs (EvalConstantExpression): Get rid of completely.
15462 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15463 user-defined values and other cases.
15465 (IsValidEnumLiteral): Helper function.
15467 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15468 out there in the case we had a literal FieldExpr.
15470 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15472 (Literalize): Revamp a bit to take two arguments.
15474 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15476 2001-11-06 Ravi Pratap <ravi@ximian.com>
15478 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15480 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15482 (Resolve): Use the above to ensure we have proper initializers.
15484 2001-11-05 Ravi Pratap <ravi@ximian.com>
15486 * expression.cs (Expression::EvalConstantExpression): New method to
15487 evaluate constant expressions.
15489 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15491 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15493 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15496 (Binary.ResolveOperator): Handle operator != (object a, object b)
15497 and operator == (object a, object b);
15499 (Binary.DoNumericPromotions): Indicate whether the numeric
15500 promotion was possible.
15502 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15505 Made the ArrayAccess implement interface IAssignMethod instead of
15506 IStackStore as the order in which arguments are passed reflects
15509 * assign.cs: Instead of using expr.ExprClass to select the way of
15510 assinging, probe for the IStackStore/IAssignMethod interfaces.
15512 * typemanager.cs: Load InitializeArray definition.
15514 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15515 static data that can be used to initialize arrays.
15517 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15519 * expression.cs: Handle operator== and operator!= for booleans.
15521 (Conditioal.Reduce): Implement reducer for the ?: operator.
15523 (Conditional.Resolve): Implement dead code elimination.
15525 (Binary.Resolve): Catch string literals and return a new
15526 concatenated string.
15528 (Unary.Reduce): Implement reduction of unary expressions.
15530 * ecore.cs: Split out the expression core handling here.
15532 (Expression.Reduce): New method used to perform constant folding
15533 and CSE. This is needed to support constant-expressions.
15535 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15536 targets, and optimize for !x.
15538 2001-11-04 Ravi Pratap <ravi@ximian.com>
15540 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15541 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15542 set custom atttributes.
15544 * literal.cs (Literal::GetValue): New abstract method to return the actual
15545 value of the literal, cast as an object.
15547 (*Literal): Implement GetValue method.
15549 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15550 expressions to the arraylist but objects of type Argument.
15552 * class.cs (TypeContainer::Emit): Emit our attributes too.
15554 (Method::Emit, Constructor::Emit): Ditto.
15556 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15557 to be ignoring earlier.
15559 2001-11-03 Ravi Pratap <ravi@ximian.com>
15561 * attribute.cs (AttributeSection::Define): Implement to do the business
15562 of constructing a CustomAttributeBuilder.
15564 (Attribute): New trivial class. Increases readability of code.
15566 * cs-parser.jay : Update accordingly.
15568 (positional_argument_list, named_argument_list, named_argument): New rules
15570 (attribute_arguments): Use the above so that we are more correct.
15572 2001-11-02 Ravi Pratap <ravi@ximian.com>
15574 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15575 to perform all checks for a method with a params parameter.
15577 (Invocation::OverloadResolve): Update to use the above method and therefore
15578 cope correctly with params method invocations.
15580 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15583 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15584 constructors in our parent too because we can't afford to miss out on
15587 * attribute.cs (AttributeSection): New name for the class Attribute
15589 Other trivial changes to improve readability.
15591 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15592 use the new class names.
15594 2001-11-01 Ravi Pratap <ravi@ximian.com>
15596 * class.cs (Method::Define): Complete definition for params types too
15598 (Indexer::Define): Ditto.
15600 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15601 Cope everywhere with a request for info about the array parameter.
15603 2001-11-01 Ravi Pratap <ravi@ximian.com>
15605 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15607 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15608 local_variable_type to extract the string corresponding to the type.
15610 (local_variable_type): Fixup the action to use the new helper method.
15612 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15615 * expression.cs : Clean out code which uses the above.
15617 2001-10-31 Ravi Pratap <ravi@ximian.com>
15619 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15620 and bale out if necessary by returning a false.
15622 (RegisterProperty): Ditto.
15624 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15625 and print out appropriate error messages.
15627 * interface.cs (everywhere): Ditto.
15629 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15630 location to constructor.
15632 * class.cs (Property, Event, Indexer): Update accordingly.
15634 * ../errors/cs111.cs : Added.
15636 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15637 of a method, as laid down by the spec.
15639 (Invocation::OverloadResolve): Use the above method.
15641 2001-10-31 Ravi Pratap <ravi@ximian.com>
15643 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15644 now take a TypeContainer and a Parameters object.
15646 (ParameterData): Modify return type of ParameterModifier method to be
15647 Parameter.Modifier and not a string.
15649 (ReflectionParameters, InternalParameters): Update accordingly.
15651 * expression.cs (Argument::GetParameterModifier): Same here.
15653 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15654 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15655 symbol in it at all so maybe this is only for now.
15657 2001-10-30 Ravi Pratap <ravi@ximian.com>
15659 * support.cs (InternalParameters): Constructor now takes an extra argument
15660 which is the actual Parameters class.
15662 (ParameterDesc): Update to provide info on ref/out modifiers.
15664 * class.cs (everywhere): Update call to InternalParameters to pass in
15665 the second argument too.
15667 * support.cs (ParameterData): Add ParameterModifier, which is a method
15668 to return the modifier info [ref/out etc]
15670 (InternalParameters, ReflectionParameters): Implement the above.
15672 * expression.cs (Argument::ParameterModifier): Similar function to return
15673 info about the argument's modifiers.
15675 (Invocation::OverloadResolve): Update to take into account matching modifiers
15678 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15679 a new SetFormalParameters object which we pass to InternalParameters.
15681 2001-10-30 Ravi Pratap <ravi@ximian.com>
15683 * expression.cs (NewArray): Merge into the ArrayCreation class.
15685 2001-10-29 Ravi Pratap <ravi@ximian.com>
15687 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15688 NewUserdefinedArray into one as there wasn't much of a use in having
15691 * expression.cs (Argument): Change field's name to ArgType from Type.
15693 (Type): New readonly property which returns the proper type, taking into
15694 account ref/out modifiers.
15696 (everywhere): Adjust code accordingly for the above.
15698 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15699 whether we are emitting for a ref or out parameter.
15701 * expression.cs (Argument::Emit): Use the above field to set the state.
15703 (LocalVariableReference::Emit): Update to honour the flag and emit the
15706 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15708 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15710 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15712 (ReflectionParameters, InternalParameters): Implement the above method.
15714 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15717 (Invocation::FullMethodDesc): Ditto.
15719 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15721 * cs-parser.jay: Add extra production for the second form of array
15724 * expression.cs (ArrayCreation): Update to reflect the above
15727 * Small changes to prepare for Array initialization.
15729 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15731 * typemanager.cs (ImplementsInterface): interface might be null;
15732 Deal with this problem;
15734 Also, we do store negative hits on the cache (null values), so use
15735 this instead of calling t.GetInterfaces on the type everytime.
15737 2001-10-28 Ravi Pratap <ravi@ximian.com>
15739 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15741 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15742 split functionality out into different classes.
15744 (New::FormArrayType): Move into NewBuiltinArray.
15746 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15749 (NewBuiltinArray): New class to handle creation of built-in arrays.
15751 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15752 account creation of one-dimensional arrays.
15754 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15756 (NewUserdefinedArray::DoResolve): Implement.
15758 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15760 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15761 we maintain inside the TypeManager. This is necessary to perform lookups on the
15764 (LookupType): Update to perform GetType on the module builders too.
15766 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15768 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15770 2001-10-23 Ravi Pratap <ravi@ximian.com>
15772 * expression.cs (New::DoResolve): Implement guts of array creation.
15774 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15776 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15778 * expression.cs: Fix bug I introduced lsat night that broke
15781 (Expression.Resolve): Report a 246 error (can not resolve name)
15782 if we find a SimpleName in the stream.
15784 (Expression.ResolveLValue): Ditto.
15786 (Expression.ResolveWithSimpleName): This function is a variant of
15787 ResolveName, this one allows SimpleNames to be returned without a
15788 warning. The only consumer of SimpleNames is MemberAccess
15790 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15792 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15793 might arrive here. I have my doubts that this is correct.
15795 * statement.cs (Lock): Implement lock statement.
15797 * cs-parser.jay: Small fixes to support `lock' and `using'
15799 * cs-tokenizer.cs: Remove extra space
15801 * driver.cs: New flag --checked, allows to turn on integer math
15804 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15805 Threading.Monitor.Exit
15807 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15809 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15810 Expression Class to be IndexerAccess.
15812 Notice that Indexer::DoResolve sets the eclass to Value.
15814 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15816 * class.cs (TypeContainer::Emit): Emit code for indexers.
15818 * assign.cs (IAssignMethod): New interface implemented by Indexers
15819 and Properties for handling assignment.
15821 (Assign::Emit): Simplify and reuse code.
15823 * expression.cs (IndexerAccess, PropertyExpr): Implement
15824 IAssignMethod, clean up old code.
15826 2001-10-22 Ravi Pratap <ravi@ximian.com>
15828 * typemanager.cs (ImplementsInterface): New method to determine if a type
15829 implements a given interface. Provides a nice cache too.
15831 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15834 (ConvertReferenceExplicit): Ditto.
15836 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15837 various methods, with correct names etc.
15839 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15840 Operator.UnaryNegation.
15842 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15843 we have a unary plus or minus operator.
15845 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15848 * everywhere : update accordingly.
15850 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15853 * class.cs (Method::Define): For the case where we are implementing a method
15854 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15855 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15857 2001-10-21 Ravi Pratap <ravi@ximian.com>
15859 * interface.cs (FindMembers): Implement to work around S.R.E
15862 * typemanager.cs (IsInterfaceType): Implement.
15864 (FindMembers): Update to handle interface types too.
15866 * expression.cs (ImplicitReferenceConversion): Re-write bits which
15867 use IsAssignableFrom as that is not correct - it doesn't work.
15869 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
15870 and accordingly override EmitStatement.
15872 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
15873 using the correct logic :-)
15875 2001-10-19 Ravi Pratap <ravi@ximian.com>
15877 * ../errors/cs-11.cs : Add to demonstrate error -11
15879 2001-10-17 Miguel de Icaza <miguel@ximian.com>
15881 * assign.cs (Assign::Resolve): Resolve right hand side first, and
15882 then pass this as a hint to ResolveLValue.
15884 * expression.cs (FieldExpr): Add Location information
15886 (FieldExpr::LValueResolve): Report assignment to readonly
15889 (Expression::ExprClassFromMemberInfo): Pass location information.
15891 (Expression::ResolveLValue): Add new method that resolves an
15894 (Expression::DoResolveLValue): Default invocation calls
15897 (Indexers): New class used to keep track of indexers in a given
15900 (IStackStore): Renamed from LValue, as it did not really describe
15901 what this did. Also ResolveLValue is gone from this interface and
15902 now is part of Expression.
15904 (ElementAccess): Depending on the element access type
15906 * typemanager.cs: Add `indexer_name_type' as a Core type
15907 (System.Runtime.CompilerServices.IndexerNameAttribute)
15909 * statement.cs (Goto): Take a location.
15911 2001-10-18 Ravi Pratap <ravi@ximian.com>
15913 * delegate.cs (Delegate::VerifyDelegate): New method to verify
15914 if two delegates are compatible.
15916 (NewDelegate::DoResolve): Update to take care of the case when
15917 we instantiate a delegate from another delegate.
15919 * typemanager.cs (FindMembers): Don't even try to look up members
15920 of Delegate types for now.
15922 2001-10-18 Ravi Pratap <ravi@ximian.com>
15924 * delegate.cs (NewDelegate): New class to take care of delegate
15927 * expression.cs (New): Split the delegate related code out into
15928 the NewDelegate class.
15930 * delegate.cs (DelegateInvocation): New class to handle delegate
15933 * expression.cs (Invocation): Split out delegate related code into
15934 the DelegateInvocation class.
15936 2001-10-17 Ravi Pratap <ravi@ximian.com>
15938 * expression.cs (New::DoResolve): Implement delegate creation fully
15939 and according to the spec.
15941 (New::DoEmit): Update to handle delegates differently.
15943 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
15944 because of which we were printing out arguments in reverse order !
15946 * delegate.cs (VerifyMethod): Implement to check if the given method
15947 matches the delegate.
15949 (FullDelegateDesc): Implement.
15951 (VerifyApplicability): Implement.
15953 * expression.cs (Invocation::DoResolve): Update to accordingly handle
15954 delegate invocations too.
15956 (Invocation::Emit): Ditto.
15958 * ../errors/cs1593.cs : Added.
15960 * ../errors/cs1594.cs : Added.
15962 * delegate.cs (InstanceExpression, TargetMethod): New properties.
15964 2001-10-16 Ravi Pratap <ravi@ximian.com>
15966 * typemanager.cs (intptr_type): Core type for System.IntPtr
15968 (InitCoreTypes): Update for the same.
15970 (iasyncresult_type, asynccallback_type): Ditto.
15972 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
15975 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
15978 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
15979 the builders for the 4 members of a delegate type :-)
15981 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
15984 * expression.cs (New::DoResolve): Implement guts for delegate creation.
15986 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
15988 2001-10-15 Miguel de Icaza <miguel@ximian.com>
15990 * statement.cs (Break::Emit): Implement.
15991 (Continue::Emit): Implement.
15993 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
15994 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
15995 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
15996 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
15999 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
16000 properties that track the label for the current loop (begin of the
16001 loop and end of the loop).
16003 2001-10-15 Ravi Pratap <ravi@ximian.com>
16005 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
16006 use of emitting anything at all.
16008 * class.cs, rootcontext.cs : Get rid of calls to the same.
16010 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
16012 (Populate): Define the constructor correctly and set the implementation
16015 * typemanager.cs (delegate_types): New hashtable to hold delegates that
16018 (AddDelegateType): Implement.
16020 (IsDelegateType): Implement helper method.
16022 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
16024 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
16025 and accordingly handle it.
16027 * delegate.cs (Populate): Take TypeContainer argument.
16028 Implement bits to define the Invoke method. However, I still haven't figured out
16029 how to take care of the native int bit :-(
16031 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
16032 Qualify the name of the delegate, not its return type !
16034 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
16037 (StandardConversionExists): Checking for array types turns out to be recursive.
16039 (ConvertReferenceExplicit): Implement array conversion.
16041 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
16043 2001-10-12 Ravi Pratap <ravi@ximian.com>
16045 * cs-parser.jay (delegate_declaration): Store the fully qualified
16046 name as it is a type declaration.
16048 * delegate.cs (ReturnType, Name): Rename members to these. Make them
16051 (DefineDelegate): Renamed from Define. Does the same thing essentially,
16052 as TypeContainer::DefineType.
16054 (Populate): Method in which all the definition of the various methods (Invoke)
16057 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
16060 (CloseDelegate): Finally creates the delegate.
16062 * class.cs (TypeContainer::DefineType): Update to define delegates.
16063 (Populate, Emit and CloseType): Do the same thing here too.
16065 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
16066 delegates in all these operations.
16068 2001-10-14 Miguel de Icaza <miguel@ximian.com>
16070 * expression.cs: LocalTemporary: a new expression used to
16071 reference a temporary that has been created.
16073 * assign.cs: Handle PropertyAccess back here, so that we can
16074 provide the proper semantic access to properties.
16076 * expression.cs (Expression::ConvertReferenceExplicit): Implement
16077 a few more explicit conversions.
16079 * modifiers.cs: `NEW' modifier maps to HideBySig.
16081 * expression.cs (PropertyExpr): Make this into an
16082 ExpressionStatement, and support the EmitStatement code path.
16084 Perform get/set error checking, clean up the interface.
16086 * assign.cs: recognize PropertyExprs as targets, and if so, turn
16087 them into toplevel access objects.
16089 2001-10-12 Miguel de Icaza <miguel@ximian.com>
16091 * expression.cs: PropertyExpr::PropertyExpr: use work around the
16094 * typemanager.cs: Keep track here of our PropertyBuilders again to
16095 work around lameness in SRE.
16097 2001-10-11 Miguel de Icaza <miguel@ximian.com>
16099 * expression.cs (LValue::LValueResolve): New method in the
16100 interface, used to perform a second resolution pass for LValues.
16102 (This::DoResolve): Catch the use of this in static methods.
16104 (This::LValueResolve): Implement.
16106 (This::Store): Remove warning, assigning to `this' in structures
16109 (Invocation::Emit): Deal with invocation of
16110 methods on value types. We need to pass the address to structure
16111 methods rather than the object itself. (The equivalent code to
16112 emit "this" for structures leaves the entire structure on the
16113 stack instead of a pointer to it).
16115 (ParameterReference::DoResolve): Compute the real index for the
16116 argument based on whether the method takes or not a `this' pointer
16117 (ie, the method is static).
16119 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
16120 value types returned from functions when we need to invoke a
16121 method on the sturcture.
16124 2001-10-11 Ravi Pratap <ravi@ximian.com>
16126 * class.cs (TypeContainer::DefineType): Method to actually do the business of
16127 defining the type in the Modulebuilder or Typebuilder. This is to take
16128 care of nested types which need to be defined on the TypeBuilder using
16129 DefineNestedMethod.
16131 (TypeContainer::GetClassBases): Implement. Essentially the code from the
16132 methods in RootContext, only ported to be part of TypeContainer.
16134 (TypeContainer::GetInterfaceOrClass): Ditto.
16136 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
16138 * interface.cs (Interface::DefineInterface): New method. Does exactly
16139 what RootContext.CreateInterface did earlier, only it takes care of nested types
16142 (Interface::GetInterfaces): Move from RootContext here and port.
16144 (Interface::GetInterfaceByName): Same here.
16146 * rootcontext.cs (ResolveTree): Re-write.
16148 (PopulateTypes): Re-write.
16150 * class.cs (TypeContainer::Populate): Populate nested types too.
16151 (TypeContainer::Emit): Emit nested members too.
16153 * typemanager.cs (AddUserType): Do not make use of the FullName property,
16154 instead just use the name argument passed in as it is already fully
16157 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
16158 to TypeContainer mapping to see if a type is user-defined.
16160 * class.cs (TypeContainer::CloseType): Implement.
16162 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
16163 the default constructor.
16165 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
16168 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
16170 * interface.cs (CloseType): Create the type here.
16172 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
16175 Remove all the methods which are now in TypeContainer.
16177 2001-10-10 Ravi Pratap <ravi@ximian.com>
16179 * delegate.cs (Define): Re-write bits to define the delegate
16182 2001-10-10 Miguel de Icaza <miguel@ximian.com>
16184 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
16186 * expression.cs (ImplicitReferenceConversion): handle null as well
16187 as a source to convert to any reference type.
16189 * statement.cs (Return): Perform any implicit conversions to
16190 expected return type.
16192 Validate use of return statement.
16194 * codegen.cs (EmitContext): Pass the expected return type here.
16196 * class.cs (Method, Constructor, Property): Pass expected return
16197 type to EmitContext.
16199 2001-10-09 Miguel de Icaza <miguel@ximian.com>
16201 * expression.cs: Make DoResolve take an EmitContext instead of a
16204 Replaced `l' and `location' for `loc', for consistency.
16206 (Error, Warning): Remove unneeded Tc argument.
16208 * assign.cs, literal.cs, constant.cs: Update to new calling
16211 * codegen.cs: EmitContext now contains a flag indicating whether
16212 code is being generated in a static method or not.
16214 * cs-parser.jay: DecomposeQI, new function that replaces the old
16215 QualifiedIdentifier. Now we always decompose the assembled
16216 strings from qualified_identifier productions into a group of
16219 2001-10-08 Miguel de Icaza <miguel@ximian.com>
16221 * rootcontext.cs: Deal with field-less struct types correctly now
16222 by passing the size option to Define Type.
16224 * class.cs: Removed hack that created one static field.
16226 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16228 * statement.cs: Moved most of the code generation here.
16230 2001-10-09 Ravi Pratap <ravi@ximian.com>
16232 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
16235 (ElementAccess): Remove useless bits for now - keep checks as the spec
16238 2001-10-08 Ravi Pratap <ravi@ximian.com>
16240 * expression.cs (ElementAccess::DoResolve): Remove my crap code
16241 and start performing checks according to the spec.
16243 2001-10-07 Ravi Pratap <ravi@ximian.com>
16245 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
16246 rank_specifiers instead.
16248 (rank_specifiers): Change the order in which the rank specifiers are stored
16250 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
16252 * expression.cs (ElementAccess): Implement the LValue interface too.
16254 2001-10-06 Ravi Pratap <ravi@ximian.com>
16256 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
16257 except that user defined conversions are not included.
16259 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
16260 perform the conversion of the return type, if necessary.
16262 (New::DoResolve): Check whether we are creating an array or an object
16263 and accordingly do the needful.
16265 (New::Emit): Same here.
16267 (New::DoResolve): Implement guts of array creation.
16269 (New::FormLookupType): Helper function.
16271 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16273 * codegen.cs: Removed most of the code generation here, and move the
16274 corresponding code generation bits to the statement classes.
16276 Added support for try/catch/finalize and throw.
16278 * cs-parser.jay: Added support for try/catch/finalize.
16280 * class.cs: Catch static methods having the flags override,
16281 virtual or abstract.
16283 * expression.cs (UserCast): This user cast was not really doing
16284 what it was supposed to do. Which is to be born in fully resolved
16285 state. Parts of the resolution were being performed at Emit time!
16289 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16291 * expression.cs: Implicity convert the result from UserCast.
16293 2001-10-05 Ravi Pratap <ravi@ximian.com>
16295 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
16296 prevented it from working correctly.
16298 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
16299 merely ConvertImplicit.
16301 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16303 * typemanager.cs: Make the LookupTypeContainer function static,
16304 and not per-instance.
16306 * class.cs: Make static FindMembers (the one that takes a Type
16309 * codegen.cs: Add EmitForeach here.
16311 * cs-parser.jay: Make foreach a toplevel object instead of the
16312 inline expansion, as we need to perform semantic analysis on it.
16314 2001-10-05 Ravi Pratap <ravi@ximian.com>
16316 * expression.cs (Expression::ImplicitUserConversion): Rename to
16317 UserDefinedConversion.
16319 (Expression::UserDefinedConversion): Take an extra argument specifying
16320 whether we look for explicit user conversions too.
16322 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
16324 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
16326 (ExplicitUserConversion): Make it a call to UserDefinedConversion
16327 with the appropriate arguments.
16329 * cs-parser.jay (cast_expression): Record location too.
16331 * expression.cs (Cast): Record location info.
16333 (Expression::ConvertExplicit): Take location argument.
16335 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16336 to determine if we are doing explicit conversions.
16338 (UserCast::Emit): Update accordingly.
16340 (Expression::ConvertExplicit): Report an error if everything fails.
16342 * ../errors/cs0030.cs : Add.
16344 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16346 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16347 virtual and newslot bits.
16349 * class.cs (TypeContainer::RegisterRequiredImplementations):
16350 Record methods we need.
16352 (TypeContainer::MakeKey): Helper function to make keys for
16353 MethodBases, since the Methodbase key is useless.
16355 (TypeContainer::Populate): Call RegisterRequiredImplementations
16356 before defining the methods.
16358 Create a mapping for method_builders_to_methods ahead of time
16359 instead of inside a tight loop.
16361 (::RequireMethods): Accept an object as the data to set into the
16362 hashtable so we can report interface vs abstract method mismatch.
16364 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16366 * report.cs: Make all of it static.
16368 * rootcontext.cs: Drop object_type and value_type computations, as
16369 we have those in the TypeManager anyways.
16371 Drop report instance variable too, now it is a global.
16373 * driver.cs: Use try/catch on command line handling.
16375 Add --probe option to debug the error reporting system with a test
16378 * report.cs: Add support for exiting program when a probe
16379 condition is reached.
16381 2001-10-03 Ravi Pratap <ravi@ximian.com>
16383 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16384 we do a forcible conversion regardless of type, to check if
16385 ForceConversion returns a null.
16387 (Binary::error19): Use location to report error.
16389 (Unary::error23): Use location here too.
16391 * ../errors/cs0019.cs : Check in.
16393 * ../errors/cs0023.cs : Check in.
16395 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16396 case of a non-null MethodInfo object with a length of 0 !
16398 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16399 an applicable member - according to the spec :-)
16400 Also fix logic to find members in base types.
16402 (Unary::ResolveOperator): Same here.
16404 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16405 as I was getting thoroughly confused between this and error19 :-)
16407 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16408 (::FindMostEncompassedType): Implement.
16409 (::FindMostEncompassingType): Implement.
16410 (::StandardConversionExists): Implement.
16412 (UserImplicitCast): Re-vamp. We now need info about most specific
16413 source and target types so that we can do the necessary conversions.
16415 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16416 mathematical union with no duplicates.
16418 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16420 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16421 in order from base classes to child classes, so that we can in
16422 child classes look up in our parent for method names and
16423 attributes (required for handling abstract, virtual, new, override
16424 constructs: we need to instrospect our base class, and if we dont
16425 populate the classes in order, the introspection might be
16426 incorrect. For example, a method could query its parent before
16427 the parent has any methods and would determine that the parent has
16428 no abstract methods (while it could have had them)).
16430 (RootContext::CreateType): Record the order in which we define the
16433 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16435 * class.cs (TypeContainer::Populate): Also method definitions can
16436 fail now, keep track of this.
16438 (TypeContainer::FindMembers): Implement support for
16439 DeclaredOnly/noDeclaredOnly flag.
16441 (Constructor::Emit) Return the ConstructorBuilder.
16443 (Method::Emit) Return the MethodBuilder.
16444 Check for abstract or virtual methods to be public.
16446 * rootcontext.cs (RootContext::CreateType): Register all the
16447 abstract methods required for the class to be complete and the
16448 interface methods that must be implemented.
16450 * cs-parser.jay: Report error 501 (method requires body if it is
16451 not marked abstract or extern).
16453 * expression.cs (TypeOf::Emit): Implement.
16455 * typemanager.cs: runtime_handle_type, new global type.
16457 * class.cs (Property::Emit): Generate code for properties.
16459 2001-10-02 Ravi Pratap <ravi@ximian.com>
16461 * expression.cs (Unary::ResolveOperator): Find operators on base type
16462 too - we now conform exactly to the spec.
16464 (Binary::ResolveOperator): Same here.
16466 * class.cs (Operator::Define): Fix minor quirk in the tests.
16468 * ../errors/cs0215.cs : Added.
16470 * ../errors/cs0556.cs : Added.
16472 * ../errors/cs0555.cs : Added.
16474 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16476 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16477 single integer which is really efficient
16479 2001-10-01 Ravi Pratap <ravi@ximian.com>
16481 * expression.cs (Expression::ImplicitUserConversion): Use location
16482 even in the case when we are examining True operators.
16484 * class.cs (Operator::Define): Perform extensive checks to conform
16485 with the rules for operator overloading in the spec.
16487 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16488 some of the other conversions mentioned in the spec.
16490 * typemanager.cs (array_type): New static member for the System.Array built-in
16493 (cloneable_interface): For System.ICloneable interface.
16495 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16496 we start resolving the tree and populating types.
16498 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16500 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16502 * expression.cs (Expression::ExprClassFromMemberInfo,
16503 Expression::Literalize): Create literal expressions from
16504 FieldInfos which are literals.
16506 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16507 type casts, because they were wrong. The test suite in tests
16510 (ImplicitNumericConversion): ushort to ulong requires a widening
16513 Int32 constant to long requires widening cast as well.
16515 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16516 for integers because the type on the stack is not i4.
16518 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16520 * expression.cs (report118): require location argument.
16522 * parameter.cs: Do not dereference potential null value.
16524 * class.cs: Catch methods that lack the `new' keyword when
16525 overriding a name. Report warnings when `new' is used without
16526 anything being there to override.
16528 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16530 * class.cs: Only add constructor to hashtable if it is non-null
16531 (as now constructors can fail on define).
16533 (TypeManager, Class, Struct): Take location arguments.
16535 Catch field instance initialization in structs as errors.
16537 accepting_filter: a new filter for FindMembers that is static so
16538 that we dont create an instance per invocation.
16540 (Constructor::Define): Catch errors where a struct constructor is
16543 * cs-parser.jay: Pass location information for various new
16546 * delegate.cs (Delegate): take a location argument.
16548 * driver.cs: Do not call EmitCode if there were problesm in the
16549 Definition of the types, as many Builders wont be there.
16551 * decl.cs (Decl::Decl): Require a location argument.
16553 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16554 into integers, and find the most appropiate integer for it.
16556 * literal.cs: Implement ULongLiteral.
16558 * rootcontext.cs: Provide better information about the location of
16559 failure when CreateType fails.
16561 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16563 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16566 * expression.cs (Binary::CheckShiftArguments): Add missing type
16568 (Binary::ResolveOperator): Add type to the logical and and logical
16569 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16572 (Binary::DoNumericPromotions): In the case where either argument
16573 is ulong (and most signed types combined with ulong cause an
16574 error) perform implicit integer constant conversions as well.
16576 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16578 * expression.cs (UserImplicitCast): Method should always be
16580 (Invocation::BetterConversion): Simplified test for IntLiteral.
16582 (Expression::ImplicitNumericConversion): Split this routine out.
16583 Put the code that performs implicit constant integer conversions
16586 (Expression::Resolve): Become a wrapper around DoResolve so we can
16587 check eclass and type being set after resolve.
16589 (Invocation::Badness): Remove this dead function
16591 (Binary::ResolveOperator): Do not compute the expensive argumnets
16592 unless we have a union for it.
16594 (Probe::Emit): Is needs to do an isinst and then
16595 compare against null.
16597 (::CanConvert): Added Location argument. If the Location argument
16598 is null (Location.Null), then we do not report errors. This is
16599 used by the `probe' mechanism of the Explicit conversion. We do
16600 not want to generate an error for something that the user
16601 explicitly requested to be casted. But the pipeline for an
16602 explicit cast first tests for potential implicit casts.
16604 So for now, if the Location is null, it means `Probe only' to
16605 avoid adding another argument. Might have to revise this
16608 (ClassCast): New class used to type cast objects into arbitrary
16609 classes (used in Explicit Reference Conversions).
16611 Implement `as' as well.
16613 Reverted all the patches from Ravi below: they were broken:
16615 * The use of `level' as a mechanism to stop recursive
16616 invocations is wrong. That was there just to catch the
16617 bug with a strack trace but not as a way of addressing
16620 To fix the problem we have to *understand* what is going
16621 on and the interactions and come up with a plan, not
16622 just get things going.
16624 * The use of the type conversion cache that I proposed
16625 last night had an open topic: How does this work across
16626 protection domains. A user defined conversion might not
16627 be public in the location where we are applying the
16628 conversion, a different conversion might be selected
16629 (ie, private A->B (better) but public B->A (worse),
16630 inside A, A->B applies, but outside it, B->A will
16633 * On top of that (ie, even if the above is solved),
16634 conversions in a cache need to be abstract. Ie, `To
16635 convert from an Int to a Short use an OpcodeCast', not
16636 `To convert from an Int to a Short use the OpcodeCast on
16637 the variable 5' (which is what this patch was doing).
16639 2001-09-28 Ravi Pratap <ravi@ximian.com>
16641 * expression.cs (Invocation::ConversionExists): Re-write to use
16642 the conversion cache
16644 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16645 cache all conversions done, not just user-defined ones.
16647 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16648 to determine if a conversion exists instead of acutually trying to
16649 perform the conversion. It's faster too.
16651 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16652 and only then attempt the implicit conversion.
16654 2001-09-28 Ravi Pratap <ravi@ximian.com>
16656 * expression.cs (ConvertImplicit): Use a cache for conversions
16657 already found. Check level of recursion and bail out if necessary.
16659 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16661 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16662 Export standard methods that we expect for string operations.
16664 * statement.cs (Block::UsageWarning): Track usage of variables and
16665 report the errors for not used variables.
16667 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16670 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16672 * codegen.cs: remove unnneded code
16674 * expression.cs: Removed BuiltinTypeAccess class
16676 Fix the order in which implicit conversions are
16679 The previous fixed dropped support for boxed conversions (adding a
16680 test to the test suite now)
16682 (UserImplicitCast::CanConvert): Remove test for source being null,
16683 that code is broken. We should not feed a null to begin with, if
16684 we do, then we should track the bug where the problem originates
16685 and not try to cover it up here.
16687 Return a resolved expression of type UserImplicitCast on success
16688 rather than true/false. Ravi: this is what I was talking about,
16689 the pattern is to use a static method as a "constructor" for
16692 Also, do not create arguments until the very last minute,
16693 otherwise we always create the arguments even for lookups that
16694 will never be performed.
16696 (UserImplicitCast::Resolve): Eliminate, objects of type
16697 UserImplicitCast are born in a fully resolved state.
16699 * typemanager.cs (InitCoreTypes): Init also value_type
16700 (System.ValueType).
16702 * expression.cs (Cast::Resolve): First resolve the child expression.
16704 (LValue): Add new method AddressOf to be used by
16707 Change the argument of Store to take an EmitContext instead of an
16708 ILGenerator, because things like FieldExpr need to be able to call
16709 their children expression to generate the instance code.
16711 (Expression::Error, Expression::Warning): Sugar functions for
16714 (Expression::MemberLookup): Accept a TypeContainer instead of a
16715 Report as the first argument.
16717 (Expression::ResolvePrimary): Killed. I still want to improve
16718 this as currently the code is just not right.
16720 (Expression::ResolveMemberAccess): Simplify, but it is still
16723 (Unary::Resolve): Catch errors in AddressOf operators.
16725 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16726 index to a byte for the short-version, or the compiler will choose
16727 the wrong Emit call, which generates the wrong data.
16729 (ParameterReference::Emit, ::Store): same.
16731 (FieldExpr::AddressOf): Implement.
16733 * typemanager.cs: TypeManager: made public variable instead of
16736 * driver.cs: document --fatal.
16738 * report.cs (ErrorMessage, WarningMessage): new names for the old
16739 Error and Warning classes.
16741 * cs-parser.jay (member_access): Turn built-in access to types
16742 into a normal simplename
16744 2001-09-27 Ravi Pratap <ravi@ximian.com>
16746 * expression.cs (Invocation::BetterConversion): Fix to cope
16747 with q being null, since this was introducing a bug.
16749 * expression.cs (ConvertImplicit): Do built-in conversions first.
16751 2001-09-27 Ravi Pratap <ravi@ximian.com>
16753 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16755 2001-09-27 Ravi Pratap <ravi@ximian.com>
16757 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16758 I had introduced long ago (what's new ?).
16760 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16761 the work of all the checking.
16762 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16763 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16765 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16766 that is the right way.
16768 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16769 overloading resolution. Use everywhere instead of cutting and pasting code.
16771 (Binary::ResolveOperator): Use MakeUnionSet.
16773 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16774 we have to convert to bool types. Not complete yet.
16776 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16778 * typemanager.cs (TypeManager::CSharpName): support ushort.
16780 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16781 to provide an expression that performsn an implicit constant int
16782 conversion (section 6.1.6).
16783 (Expression::ConvertImplicitRequired): Reworked to include
16784 implicit constant expression conversions.
16786 (Expression::ConvertNumericExplicit): Finished.
16788 (Invocation::Emit): If InstanceExpression is null, then it means
16789 that we perform a call on this.
16791 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16793 * expression.cs (Unary::Emit): Remove some dead code.
16794 (Probe): Implement Resolve and Emit for `is'.
16795 (Expression::ConvertImplicitRequired): Attempt to do constant
16796 expression conversions here. Maybe should be moved to
16797 ConvertImplicit, but I am not sure.
16798 (Expression::ImplicitLongConstantConversionPossible,
16799 Expression::ImplicitIntConstantConversionPossible): New functions
16800 that tell whether is it possible to apply an implicit constant
16801 expression conversion.
16803 (ConvertNumericExplicit): Started work on explicit numeric
16806 * cs-parser.jay: Update operator constants.
16808 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16809 (Parameters::GetSignature): Hook up VerifyArgs here.
16810 (Parameters::VerifyArgs): Verifies that no two arguments have the
16813 * class.cs (Operator): Update the operator names to reflect the
16814 ones that the spec expects (as we are just stringizing the
16817 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16818 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16819 previous usage did only work for our methods.
16820 (Expression::ConvertImplicit): Handle decimal implicit numeric
16821 conversions as well.
16822 (Expression::InternalTypeConstructor): Used to invoke constructors
16823 on internal types for default promotions.
16825 (Unary::Emit): Implement special handling for the pre/post
16826 increment/decrement for overloaded operators, as they need to have
16827 the same semantics as the other operators.
16829 (Binary::ResolveOperator): ditto.
16830 (Invocation::ConversionExists): ditto.
16831 (UserImplicitCast::Resolve): ditto.
16833 2001-09-26 Ravi Pratap <ravi@ximian.com>
16835 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16836 operator, return after emitting body. Regression tests pass again !
16838 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16839 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16840 (Invocation::OverloadResolve): Ditto.
16841 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16843 * everywhere : update calls to the above methods accordingly.
16845 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16847 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16849 * expression.cs (ExpressionStatement): New base class used for
16850 expressions that can appear in statements, so that we can provide
16851 an alternate path to generate expression that do not leave a value
16854 (Expression::Emit, and all the derivatives): We no longer return
16855 whether a value is left on the stack or not. Every expression
16856 after being emitted leaves a single value on the stack.
16858 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16859 facilties of ExpressionStatement if possible.
16861 * cs-parser.jay: Update statement_expression.
16863 2001-09-25 Miguel de Icaza <miguel@ximian.com>
16865 * driver.cs: Change the wording of message
16867 2001-09-25 Ravi Pratap <ravi@ximian.com>
16869 * expression.cs (Binary::ResolveOperator): Had forgottten to set
16870 the type of the expression to the return type of the method if
16871 we have an overloaded operator match ! The regression tests pass again !
16872 (Unary::ResolveOperator): Ditto.
16874 * expression.cs (Invocation::ConversionExists): Correct the member lookup
16875 to find "op_Implicit", not "implicit" ;-)
16876 (UserImplicitCast): New class to take care of user-defined implicit conversions.
16877 (ConvertImplicit, ForceConversion): Take TypeContainer argument
16879 * everywhere : Correct calls to the above accordingly.
16881 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
16882 (ConvertImplicit): Do user-defined conversion if it exists.
16884 2001-09-24 Miguel de Icaza <miguel@ximian.com>
16886 * assign.cs: track location.
16887 (Resolve): Use implicit conversions on assignment.
16889 * literal.cs: Oops. Not good, Emit of short access values should
16890 pass (Bytes) or the wrong argument will be selected.
16892 * expression.cs (Unary::Emit): Emit code for -expr.
16894 (Unary::ResolveOperator): Handle `Substract' for non-constants
16895 (substract from zero from the non-constants).
16896 Deal with Doubles as well.
16898 (Expression::ConvertImplicitRequired): New routine that reports an
16899 error if no implicit conversion exists.
16901 (Invocation::OverloadResolve): Store the converted implicit
16902 expressions if we make them
16904 2001-09-24 Ravi Pratap <ravi@ximian.com>
16906 * class.cs (ConstructorInitializer): Take a Location argument.
16907 (ConstructorBaseInitializer): Same here.
16908 (ConstructorThisInitializer): Same here.
16910 * cs-parser.jay : Update all calls accordingly.
16912 * expression.cs (Unary, Binary, New): Take location argument.
16913 Update accordingly everywhere.
16915 * cs-parser.jay : Update all calls to the above to take a location
16918 * class.cs : Ditto.
16920 2001-09-24 Ravi Pratap <ravi@ximian.com>
16922 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
16923 (Invocation::BetterConversion): Same here
16924 (Invocation::ConversionExists): Ditto.
16926 (Invocation::ConversionExists): Implement.
16928 2001-09-22 Ravi Pratap <ravi@ximian.com>
16930 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
16931 Also take an additional TypeContainer argument.
16933 * All over : Pass in TypeContainer as argument to OverloadResolve.
16935 * typemanager.cs (CSharpName): Update to check for the string type and return
16938 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
16941 2001-09-21 Ravi Pratap <ravi@ximian.com>
16943 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
16944 (Invocation::BetterFunction): Implement.
16945 (Invocation::BetterConversion): Implement.
16946 (Invocation::ConversionExists): Skeleton, no implementation yet.
16948 Okay, things work fine !
16950 2001-09-21 Miguel de Icaza <miguel@ximian.com>
16952 * typemanager.cs: declare and load enum_type, delegate_type and
16955 * expression.cs (Expression::Emit): Now emit returns a value that
16956 tells whether a value is left on the stack or not. This strategy
16957 might be reveted tomorrow with a mechanism that would address
16958 multiple assignments.
16959 (Expression::report118): Utility routine to report mismatches on
16962 (Unary::Report23): Report impossible type/operator combination
16965 (Unary::IsIncrementableNumber): Whether the type can be
16966 incremented or decremented with add.
16967 (Unary::ResolveOperator): Also allow enumerations to be bitwise
16969 (Unary::ResolveOperator): Implement ++, !, ~,
16971 (Invocation::Emit): Deal with new Emit convetion.
16973 * All Expression derivatives: Updated their Emit method to return
16974 whether they leave values on the stack or not.
16976 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
16977 stack for expressions that are statements.
16979 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16981 * expression.cs (LValue): New interface. Must be implemented by
16983 (LocalVariableReference, ParameterReference, FieldExpr): Implement
16986 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
16987 interface for generating code, simplifies the code.
16989 2001-09-20 Ravi Pratap <ravi@ximian.com>
16991 * expression.cs (everywhere): Comment out return statements in ::Resolve
16992 methods to avoid the warnings.
16994 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16996 * driver.cs (parse): Report error 2001 if we can not open the
16999 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
17002 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
17005 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
17006 otherwise nested blocks end up with the same index.
17008 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
17010 * expression.cs: Instead of having FIXMEs in the Resolve
17011 functions, throw exceptions so it is obvious that we are facing a
17014 * cs-parser.jay (invocation_expression): Pass Location information.
17016 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
17017 Use a basename for those routines because .NET does not like paths
17020 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
17023 2001-09-19 Miguel de Icaza <miguel@ximian.com>
17025 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
17026 are loading the correct data types (throws an exception if not).
17027 (TypeManager::InitCoreTypes): Use CoreLookupType
17029 * expression.cs (Unary::ResolveOperator): return the child
17030 expression for expressions which are just +expr.
17031 (Unary::ResolveOperator): Return negative literals for -LITERAL
17032 expressions (otherwise they are Unary {Literal}).
17033 (Invocation::Badness): Take into account `Implicit constant
17034 expression conversions'.
17036 * literal.cs (LongLiteral): Implement long literal class.
17037 (IntLiteral): export the `Value' of the intliteral.
17039 2001-09-19 Ravi Pratap <ravi@ximian.com>
17041 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
17043 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
17044 instead of 'Operator'
17046 * expression.cs (Binary::ResolveOperator): Update accordingly.
17047 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
17050 * cs-parser.jay (unary_expression): Update to use the new names.
17052 * gen-treedump.cs (GetUnary): Same here.
17054 * expression.cs (Unary::Resolve): Implement.
17055 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
17056 operators are found instead of making noise ;-)
17057 (Unary::ResolveOperator): New method to do precisely the same thing which
17058 Binary::ResolveOperator does for Binary expressions.
17059 (Unary.method, .Arguments): Add.
17060 (Unary::OperName): Implement.
17061 (Unary::ForceConversion): Copy and Paste !
17063 * class.cs (Operator::Define): Fix a small bug for the case when we have
17066 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
17067 for the inbuilt operators. Only overloading works for now ;-)
17069 2001-09-18 Miguel de Icaza <miguel@ximian.com>
17071 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
17072 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
17074 * expression.cs (This::Emit): Implement.
17075 (This::Resolve): Implement.
17076 (TypeOf:Resolve): Implement.
17077 (Expression::ResolveSimpleName): Add an implicit this to instance
17079 (MemberAccess::Resolve): Deal with Parameters and Fields.
17080 Bind instance variable to Field expressions.
17081 (FieldExpr::Instance): New field used to track the expression that
17082 represents the object instance.
17083 (FieldExpr::Resolve): Track potential errors from MemberLookup not
17085 (FieldExpr::Emit): Implement.
17087 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
17088 the last instruction contains a return opcode to avoid generating
17089 the last `ret' instruction (this generates correct code, and it is
17090 nice to pass the peverify output).
17092 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
17093 initializer for static and instance variables.
17094 (Constructor::Emit): Allow initializer to be null in the case of
17095 static constructors. Only emit initializer for instance
17098 (TypeContainer::FindMembers): Return a null array if there are no
17101 Also fix the code for the MemberTypes.Method branch, as it was not
17102 scanning that for operators (or tried to access null variables before).
17104 * assign.cs (Assign::Emit): Handle instance and static fields.
17108 * driver.cs: Stop compilation if there are parse errors.
17110 * cs-parser.jay (constructor_declaration): Provide default base
17111 initializer for non-static constructors.
17112 (constructor_declarator): Do not provide a default base
17113 initializers if none was specified.
17114 Catch the fact that constructors should not have parameters.
17116 * class.cs: Do not emit parent class initializers for static
17117 constructors, that should be flagged as an error.
17119 2001-09-18 Ravi Pratap <ravi@ximian.com>
17121 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
17122 Move back code into TypeContainer::Populate.
17124 2001-09-18 Ravi Pratap <ravi@ximian.com>
17126 * class.cs (TypeContainer::AddConstructor): Fix the check to
17127 compare against Name, not Basename.
17128 (Operator::OpType): Change Plus and Minus to Add and Subtract.
17130 * cs-parser.jay : Update accordingly.
17132 * class.cs (TypeContainer::FindMembers): For the case where we are searching
17133 for methods, don't forget to look into the operators too.
17134 (RegisterMethodBuilder): Helper method to take care of this for
17135 methods, constructors and operators.
17136 (Operator::Define): Completely revamp.
17137 (Operator.OperatorMethod, MethodName): New fields.
17138 (TypeContainer::Populate): Move the registering of builders into
17139 RegisterMethodBuilder.
17140 (Operator::Emit): Re-write.
17142 * expression.cs (Binary::Emit): Comment out code path to emit method
17143 invocation stuff for the case when we have a user defined operator. I am
17144 just not able to get it right !
17146 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17148 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
17151 (Expression::MemberLookup): Provide a version that allows to
17152 specify the MemberTypes and BindingFlags.
17154 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
17155 so it was not fetching variable information from outer blocks.
17157 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
17158 Beforefieldinit as it was buggy.
17160 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
17161 that Ravi put here.
17163 * class.cs (Constructor::Emit): Only emit if block is not null.
17164 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
17165 deal with this by semantically definining it as if the user had
17168 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
17169 constructors as we now "emit" them at a higher level.
17171 (TypeContainer::DefineDefaultConstructor): Used to define the
17172 default constructors if none was provided.
17174 (ConstructorInitializer): Add methods Resolve and Emit.
17176 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
17178 2001-09-17 Ravi Pratap <ravi@ximian.com>
17180 * class.cs (TypeContainer::EmitDefaultConstructor): Register
17181 the default constructor builder with our hashtable for methodbuilders
17184 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
17185 and argument_count is 0 in which case we have a match.
17186 (Binary::ResolveOperator): More null checking and miscellaneous coding
17189 2001-09-17 Ravi Pratap <ravi@ximian.com>
17191 * rootcontext.cs (IsNameSpace): Compare against null.
17193 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
17195 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
17196 and Unary::Operator.
17198 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
17201 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
17202 we have overloaded operators.
17203 (Binary::ResolveOperator): Implement the part which does the operator overload
17206 * class.cs (Operator::Emit): Implement.
17207 (TypeContainer::Emit): Emit the operators we have too.
17209 * expression.cs (Binary::Emit): Update to emit the appropriate code for
17210 the case when we have a user-defined operator.
17212 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17214 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
17216 2001-09-16 Ravi Pratap <ravi@ximian.com>
17218 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
17219 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
17220 (Constructor::Emit): Implement.
17221 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
17222 if we have no work to do.
17223 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
17226 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
17227 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
17229 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
17232 2001-09-15 Ravi Pratap <ravi@ximian.com>
17234 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
17236 (Tree::RecordNamespace): Method to do what the name says ;-)
17237 (Tree::Namespaces): Property to get at the namespaces hashtable.
17239 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
17242 * rootcontext.cs (IsNamespace): Fixed it :-)
17244 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17246 * class.cs (TypeContainer::FindMembers): Add support for
17248 (MethodCore): New class that encapsulates both the shared aspects
17249 of a Constructor and a Method.
17250 (Method, Constructor): Factored pieces into MethodCore.
17252 * driver.cs: Added --fatal which makes errors throw exceptions.
17253 Load System assembly as well as part of the standard library.
17255 * report.cs: Allow throwing exceptions on errors for debugging.
17257 * modifiers.cs: Do not use `parent', instead use the real type
17258 container to evaluate permission settings.
17260 * class.cs: Put Ravi's patch back in. He is right, and we will
17261 have to cope with the
17263 2001-09-14 Ravi Pratap <ravi@ximian.com>
17265 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
17266 FamORAssem, not FamANDAssem.
17268 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17270 * driver.cs: Added --parse option that only parses its input files
17273 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
17274 incorrect. IsTopLevel is not used to tell whether an object is
17275 root_types or not (that can be achieved by testing this ==
17276 root_types). But to see if this is a top-level *class* (not
17277 necessarly our "toplevel" container).
17279 2001-09-14 Ravi Pratap <ravi@ximian.com>
17281 * enum.cs (Enum::Define): Modify to call the Lookup method on the
17282 parent instead of a direct call to GetType.
17284 2001-09-14 Ravi Pratap <ravi@ximian.com>
17286 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
17287 Modifiers.TypeAttr. This should just be a call to that method.
17289 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
17290 object so that we can determine if we are top-level or not.
17292 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
17295 * enum.cs (Enum::Define): Ditto.
17297 * modifiers.cs (FieldAttr): Re-write.
17299 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
17300 (TypeContainer::HaveStaticConstructor): New property to provide access
17301 to precisely that info.
17303 * modifiers.cs (MethodAttr): Re-write.
17304 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
17306 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
17307 of top-level types as claimed.
17309 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17311 * expression.cs (MemberLookup): Fruitless attempt to lookup
17312 constructors. Maybe I need to emit default constructors? That
17313 might be it (currently .NET emits this for me automatically).
17314 (Invocation::OverloadResolve): Cope with Arguments == null.
17315 (Invocation::EmitArguments): new function, shared by the new
17316 constructor and us.
17317 (Invocation::Emit): Handle static and instance methods. Emit
17318 proper call instruction for virtual or non-virtual invocations.
17319 (New::Emit): Implement.
17320 (New::Resolve): Implement.
17321 (MemberAccess:Resolve): Implement.
17322 (MethodGroupExpr::InstanceExpression): used conforming to the spec
17323 to track instances.
17324 (FieldExpr::Resolve): Set type.
17326 * support.cs: Handle empty arguments.
17328 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
17329 SimpleLookup): Auxiliary routines to help parse a qualifier
17332 Update qualifier_identifier rule.
17334 * codegen.cs: Removed debugging messages.
17336 * class.cs: Make this a global thing, this acts just as a "key" to
17337 objects that we might have around.
17339 (Populate): Only initialize method_builders_to_methods once.
17341 * expression.cs (PropertyExpr): Initialize type from the
17344 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17345 Resolve pattern. Attempt to implicitly convert value to boolean.
17348 * expression.cs: Set the type for the int32/int32 argument case.
17349 (Binary::ResolveOperator): Set the return type to boolean for
17350 comparission operators
17352 * typemanager.cs: Remove debugging print code.
17354 (Invocation::Resolve): resolve type.
17356 * class.cs: Allocate a MemberInfo of the correct size, as the code
17357 elsewhere depends on the test to reflect the correct contents.
17359 (Method::) Keep track of parameters, due to System.Reflection holes
17361 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17364 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17365 of the exact size and return that.
17367 (Class::LookupMethodByBuilder): New function that maps
17368 MethodBuilders to its methods. Required to locate the information
17369 on methods because System.Reflection bit us again.
17371 * support.cs: New file, contains an interface ParameterData and
17372 two implementations: ReflectionParameters and InternalParameters
17373 used to access Parameter information. We will need to grow this
17376 * expression.cs (Invocation::GetParameterData): implement a cache
17377 and a wrapper around the ParameterData creation for methods.
17378 (Invocation::OverloadResolve): Use new code.
17380 2001-09-13 Ravi Pratap <ravi@ximian.com>
17382 * class.cs (TypeContainer::EmitField): Remove and move into
17383 (Field::Define): here and modify accordingly.
17384 (Field.FieldBuilder): New member.
17385 (TypeContainer::Populate): Update accordingly.
17386 (TypeContainer::FindMembers): Implement.
17388 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17390 * statement.cs: (VariableInfo::VariableType): New field to be
17391 initialized with the full type once it is resolved.
17393 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17395 * parameter.cs (GetParameterInfo): Use a type cache to compute
17396 things only once, and to reuse this information
17398 * expression.cs (LocalVariableReference::Emit): Implement.
17399 (OpcodeCast::Emit): fix.
17401 (ParameterReference::Resolve): Implement.
17402 (ParameterReference::Emit): Implement.
17404 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17405 that are expressions need to stay as Expressions.
17407 * typemanager.cs (CSharpName): Returns the C# name of a type if
17410 * expression.cs (Expression::ConvertImplicit): New function that
17411 implements implicit type conversions.
17413 (Expression::ImplicitReferenceConversion): Implements implicit
17414 reference conversions.
17416 (EmptyCast): New type for transparent casts.
17418 (OpcodeCast): New type for casts of types that are performed with
17419 a sequence of bytecodes.
17421 (BoxedCast): New type used for casting value types into reference
17422 types. Emits a box opcode.
17424 (Binary::DoNumericPromotions): Implements numeric promotions of
17425 and computation of the Binary::Type.
17427 (Binary::EmitBranchable): Optimization.
17429 (Binary::Emit): Implement code emission for expressions.
17431 * typemanager.cs (TypeManager): Added two new core types: sbyte
17434 2001-09-12 Ravi Pratap <ravi@ximian.com>
17436 * class.cs (TypeContainer::FindMembers): Method which does exactly
17437 what Type.FindMembers does, only we don't have to use reflection. No
17438 implementation yet.
17440 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17441 typecontainer objects as we need to get at them.
17442 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17444 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17445 typecontainer object.
17447 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17448 of just a Report object.
17450 2001-09-11 Ravi Pratap <ravi@ximian.com>
17452 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17454 (TypeContainer::Populate): Now define the delegates of the type too.
17455 (TypeContainer.Delegates): Property to access the list of delegates defined
17458 * delegates.cs (Delegate::Define): Implement partially.
17460 * modifiers.cs (TypeAttr): Handle more flags.
17462 2001-09-11 Ravi Pratap <ravi@ximian.com>
17464 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17466 (Operator::Define): Re-write logic to get types by using the LookupType method
17467 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17468 (Indexer::Define): Ditto.
17469 (Event::Define): Ditto.
17470 (Property::Define): Ditto.
17472 2001-09-10 Ravi Pratap <ravi@ximian.com>
17474 * class.cs (TypeContainer::Populate): Now define operators too.
17475 (TypeContainer.Operators): New property to access the list of operators
17477 (Operator.OperatorMethodBuilder): New member to hold the method builder
17478 for the operator we are defining.
17479 (Operator::Define): Implement.
17481 2001-09-10 Ravi Pratap <ravi@ximian.com>
17483 * class.cs (Event::Define): Make the prefixes of the accessor methods
17484 addOn_ and removeOn_
17486 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17487 of the location being passed in too. Ideally, this should go later since all
17488 error reporting should be done through the Report object.
17490 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17491 (Populate): Iterate thru the indexers we have and define them too.
17492 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17493 for the get and set accessors.
17494 (Indexer::Define): Implement.
17496 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17498 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17499 my previous implementation, did not work.
17501 * typemanager.cs: Add a couple of missing types (the longs).
17503 * literal.cs: Use TypeManager.bool_type instead of getting it.
17505 * expression.cs (EventExpr): New kind of expressions.
17506 (Expressio::ExprClassFromMemberInfo): finish
17508 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17510 * assign.cs: Emit stores to static fields differently.
17512 2001-09-08 Ravi Pratap <ravi@ximian.com>
17514 * Merge in changes and adjust code to tackle conflicts. Backed out my
17515 code in Assign::Resolve ;-)
17517 2001-09-08 Ravi Pratap <ravi@ximian.com>
17519 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17520 instead Report.Error and also pass in the location.
17521 (CSharpParser::Lexer): New readonly property to return the reference
17522 to the Tokenizer object.
17523 (declare_local_variables): Use Report.Error with location instead of plain
17527 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17528 (Operator.CheckBinaryOperator): Ditto.
17530 * cs-parser.jay (operator_declarator): Update accordingly.
17532 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17533 (CheckBinaryOperator): Same here.
17535 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17536 on the name without any prefixes of namespace names etc. This is because we
17537 already might have something already fully qualified like
17538 'System.Console.WriteLine'
17540 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17542 2001-09-07 Ravi Pratap <ravi@ximian.com>
17544 * cs-tokenizer.cs (location): Return a string which also contains
17547 * expression.cs (ElementAccess): New class for expressions of the
17548 type 'element access.'
17549 (BaseAccess): New class for expressions of the type 'base access.'
17550 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17553 * cs-parser.jay (element_access): Implement action.
17554 (base_access): Implement actions.
17555 (checked_expression, unchecked_expression): Implement.
17557 * cs-parser.jay (local_variable_type): Correct and implement.
17558 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17560 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17562 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17563 name and the specifiers.
17565 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17567 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17568 making them all public ;-)
17570 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17573 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17575 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17577 (FieldExpr, PropertyExprs): New resolved expressions.
17578 (SimpleName::MemberStaticCheck): Perform static checks for access
17579 to non-static fields on static methods. Maybe this should be
17580 generalized for MemberAccesses.
17581 (SimpleName::ResolveSimpleName): More work on simple name
17584 * cs-parser.jay (primary_expression/qualified_identifier): track
17585 the parameter index.
17587 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17588 (EmitContext::EmitBoolExpression): Chain to expression generation
17589 instead of temporary hack.
17590 (::EmitStatementExpression): Put generic expression code generation.
17592 * assign.cs (Assign::Emit): Implement variable assignments to
17593 local variables, parameters and fields.
17595 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17597 * statement.cs (Block::GetVariableInfo): New method, returns the
17598 VariableInfo for a variable name in a block.
17599 (Block::GetVariableType): Implement in terms of GetVariableInfo
17601 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17602 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17604 2001-09-06 Ravi Pratap <ravi@ximian.com>
17606 * cs-parser.jay (operator_declaration): Continue on my quest : update
17607 to take attributes argument.
17608 (event_declaration): Ditto.
17609 (enum_declaration): Ditto.
17610 (indexer_declaration): Ditto.
17612 * class.cs (Operator::Operator): Update constructor accordingly.
17613 (Event::Event): Ditto.
17615 * delegate.cs (Delegate::Delegate): Same here.
17617 * enum.cs (Enum::Enum): Same here.
17619 2001-09-05 Ravi Pratap <ravi@ximian.com>
17621 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17623 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17625 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17626 being passed around as an arraylist.
17627 (Attributes::AddAttribute): Method to add attribute sections.
17629 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17630 (struct_declaration): Update accordingly.
17631 (constant_declaration): Update.
17632 (field_declaration): Update.
17633 (method_header): Update.
17634 (fixed_parameter): Update.
17635 (parameter_array): Ditto.
17636 (property_declaration): Ditto.
17637 (destructor_declaration): Ditto.
17639 * class.cs (Struct::Struct): Update constructors accordingly.
17640 (Class::Class): Ditto.
17641 (Field::Field): Ditto.
17642 (Method::Method): Ditto.
17643 (Property::Property): Ditto.
17644 (TypeContainer::OptAttribute): update property's return type.
17646 * interface.cs (Interface.opt_attributes): New member.
17647 (Interface::Interface): Update to take the extra Attributes argument.
17649 * parameter.cs (Parameter::Parameter): Ditto.
17651 * constant.cs (Constant::Constant): Ditto.
17653 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17654 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17655 the attributes as a parameter.
17656 (InterfaceProperty): Update constructor call.
17657 (InterfaceEvent): Ditto.
17658 (InterfaceMethod): Ditto.
17659 (InterfaceIndexer): Ditto.
17661 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17662 pass the attributes too.
17663 (interface_event_declaration): Ditto.
17664 (interface_property_declaration): Ditto.
17665 (interface_method_declaration): Ditto.
17666 (interface_declaration): Ditto.
17668 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17670 * class.cs (Method::Define): Track the "static Main" definition to
17671 create an entry point.
17673 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17674 EntryPoint if we find it.
17676 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17677 (EmitContext::ig): Make this variable public.
17679 * driver.cs: Make the default output file be the first file name
17680 with the .exe extension.
17682 Detect empty compilations
17684 Handle various kinds of output targets. Handle --target and
17685 rename -t to --dumper.
17687 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17688 methods inherited from Expression return now an Expression. This
17689 will is used during the tree rewriting as we resolve them during
17692 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17693 the spec. Missing entirely is the information about
17694 accessability of elements of it.
17696 (Expression::ExprClassFromMemberInfo): New constructor for
17697 Expressions that creates a fully initialized Expression based on
17698 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17701 (Invocation::Resolve): Begin implementing resolution of invocations.
17703 * literal.cs (StringLiteral): Implement Emit.
17705 2001-09-05 Ravi Pratap <ravi@ximian.com>
17707 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17710 2001-09-04 Ravi Pratap <ravi@ximian.com>
17712 * cs-parser.jay (attribute_arguments): Implement actions.
17713 (attribute): Fix bug in production. Implement action.
17714 (attribute_list): Implement.
17715 (attribute_target): Implement.
17716 (attribute_target_specifier, opt_target_specifier): Implement
17717 (CheckAttributeTarget): New method to check if the attribute target
17719 (attribute_section): Implement.
17720 (opt_attributes): Implement.
17722 * attribute.cs : New file to handle attributes.
17723 (Attribute): Class to hold attribute info.
17725 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17726 (attribute_section): Modify production to use 2 different rules to
17727 achieve the same thing. 1 s/r conflict down !
17728 Clean out commented, useless, non-reducing dimension_separator rules.
17730 * class.cs (TypeContainer.attributes): New member to hold list
17731 of attributes for a type.
17732 (Struct::Struct): Modify to take one more argument, the attribute list.
17733 (Class::Class): Ditto.
17734 (Field::Field): Ditto.
17735 (Method::Method): Ditto.
17736 (Property::Property): Ditto.
17738 * cs-parser.jay (struct_declaration): Update constructor call to
17739 pass in the attributes too.
17740 (class_declaration): Ditto.
17741 (constant_declaration): Ditto.
17742 (field_declaration): Ditto.
17743 (method_header): Ditto.
17744 (fixed_parameter): Ditto.
17745 (parameter_array): Ditto.
17746 (property_declaration): Ditto.
17748 * constant.cs (Constant::Constant): Update constructor similarly.
17749 Use System.Collections.
17751 * parameter.cs (Parameter::Parameter): Update as above.
17753 2001-09-02 Ravi Pratap <ravi@ximian.com>
17755 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17756 (TypeContainer.delegates): New member to hold list of delegates.
17758 * cs-parser.jay (delegate_declaration): Implement the action correctly
17759 this time as I seem to be on crack ;-)
17761 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17763 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17764 tell whether an identifier represents a namespace.
17766 * expression.cs (NamespaceExpr): A namespace expression, used only
17767 temporarly during expression resolution.
17768 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17769 utility functions to resolve names on expressions.
17771 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17773 * codegen.cs: Add hook for StatementExpressions.
17775 * class.cs: Fix inverted test for static flag in methods.
17777 2001-09-02 Ravi Pratap <ravi@ximian.com>
17779 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17780 to make it coincide with MS' number.
17781 (Operator::CheckBinaryOperator): Ditto.
17783 * ../errors/errors.txt : Remove error numbers added earlier.
17785 * ../errors/cs1019.cs : Test case for error # 1019
17787 * ../errros/cs1020.cs : Test case for error # 1020
17789 * cs-parser.jay : Clean out commented cruft.
17790 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17791 used anywhere - non-reducing rule.
17792 (namespace_declarations): Non-reducing rule - comment out.
17794 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17795 with TypeContainer::AddEnum.
17797 * delegate.cs : New file for delegate handling classes.
17798 (Delegate): Class for declaring delegates.
17800 * makefile : Update.
17802 * cs-parser.jay (delegate_declaration): Implement.
17804 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17806 * class.cs (Event::Define): Implement.
17807 (Event.EventBuilder): New member.
17809 * class.cs (TypeContainer::Populate): Update to define all enums and events
17811 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17812 readonly fields for all these cases ?
17814 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17816 * class.cs (Property): Revamp to use the convention of making fields readonly.
17817 Accordingly modify code elsewhere.
17819 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17820 the Define method of the Property class.
17822 * class.cs : Clean up applied patch and update references to variables etc. Fix
17824 (TypeContainer::Populate): Update to define all the properties we have. Also
17825 define all enumerations.
17827 * enum.cs (Define): Implement.
17829 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17831 * cs-parser.jay (overloadable_operator): The semantic value is an
17832 enum of the Operator class.
17833 (operator_declarator): Implement actions.
17834 (operator_declaration): Implement.
17836 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17837 validity of definitions.
17838 (Operator::CheckBinaryOperator): Static method to check for binary operators
17839 (TypeContainer::AddOperator): New method to add an operator to a type.
17841 * cs-parser.jay (indexer_declaration): Added line to actually call the
17842 AddIndexer method so it gets added ;-)
17844 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17845 already taken care of by the MS compiler ?
17847 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17849 * class.cs (Operator): New class for operator declarations.
17850 (Operator::OpType): Enum for the various operators.
17852 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17854 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17855 ostensibly handle this in semantic analysis.
17857 * cs-parser.jay (general_catch_clause): Comment out
17858 (specific_catch_clauses, specific_catch_clause): Ditto.
17859 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
17860 (catch_args, opt_catch_args): New productions.
17861 (catch_clause): Rewrite to use the new productions above
17862 (catch_clauses): Modify accordingly.
17863 (opt_catch_clauses): New production to use in try_statement
17864 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
17865 and re-write the code in the actions to extract the specific and
17866 general catch clauses by being a little smart ;-)
17868 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
17869 Hooray, try and catch statements parse fine !
17871 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17873 * statement.cs (Block::GetVariableType): Fix logic to extract the type
17874 string from the hashtable of variables.
17876 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
17877 I end up making that mistake ;-)
17878 (catch_clauses): Fixed gross error which made Key and Value of the
17879 DictionaryEntry the same : $1 !!
17881 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17883 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
17885 * cs-parser.jay (event_declaration): Correct to remove the semicolon
17886 when the add and remove accessors are specified.
17888 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17890 * cs-parser.jay (IndexerDeclaration): New helper class to hold
17891 information about indexer_declarator.
17892 (indexer_declarator): Implement actions.
17893 (parsing_indexer): New local boolean used to keep track of whether
17894 we are parsing indexers or properties. This is necessary because
17895 implicit_parameters come into picture even for the get accessor in the
17896 case of an indexer.
17897 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
17899 * class.cs (Indexer): New class for indexer declarations.
17900 (TypeContainer::AddIndexer): New method to add an indexer to a type.
17901 (TypeContainer::indexers): New member to hold list of indexers for the
17904 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17906 * cs-parser.jay (add_accessor_declaration): Implement action.
17907 (remove_accessor_declaration): Implement action.
17908 (event_accessors_declaration): Implement
17909 (variable_declarators): swap statements for first rule - trivial.
17911 * class.cs (Event): New class to hold information about event
17913 (TypeContainer::AddEvent): New method to add an event to a type
17914 (TypeContainer::events): New member to hold list of events.
17916 * cs-parser.jay (event_declaration): Implement actions.
17918 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17920 * cs-parser.jay (dim_separators): Implement. Make it a string
17921 concatenating all the commas together, just as they appear.
17922 (opt_dim_separators): Modify accordingly
17923 (rank_specifiers): Update accordingly. Basically do the same
17924 thing - instead, collect the brackets here.
17925 (opt_rank_sepcifiers): Modify accordingly.
17926 (array_type): Modify to actually return the complete type string
17927 instead of ignoring the rank_specifiers.
17928 (expression_list): Implement to collect the expressions
17929 (variable_initializer): Implement. We make it a list of expressions
17930 essentially so that we can handle the array_initializer case neatly too.
17931 (variable_initializer_list): Implement.
17932 (array_initializer): Make it a list of variable_initializers
17933 (opt_array_initializer): Modify accordingly.
17935 * expression.cs (New::NType): Add enumeration to help us
17936 keep track of whether we have an object/delegate creation
17937 or an array creation.
17938 (New:NewType, New::Rank, New::Indices, New::Initializers): New
17939 members to hold data about array creation.
17940 (New:New): Modify to update NewType
17941 (New:New): New Overloaded contructor for the array creation
17944 * cs-parser.jay (array_creation_expression): Implement to call
17945 the overloaded New constructor.
17947 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
17949 * class.cs (TypeContainer::Constructors): Return member
17950 constructors instead of returning null.
17952 2001-08-26 Miguel de Icaza <miguel@ximian.com>
17954 * typemanager.cs (InitCoreTypes): Initialize the various core
17955 types after we have populated the type manager with the user
17956 defined types (this distinction will be important later while
17957 compiling corlib.dll)
17959 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
17960 on Expression Classification. Now all expressions have a method
17961 `Resolve' and a method `Emit'.
17963 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
17964 generation from working. Also add some temporary debugging
17967 2001-08-24 Miguel de Icaza <miguel@ximian.com>
17969 * codegen.cs: Lots of code generation pieces. This is only the
17970 beginning, will continue tomorrow with more touches of polish. We
17971 handle the fundamentals of if, while, do, for, return. Others are
17972 trickier and I need to start working on invocations soon.
17974 * gen-treedump.cs: Bug fix, use s.Increment here instead of
17977 * codegen.cs (EmitContext): New struct, used during code
17978 emission to keep a context. Most of the code generation will be
17981 * cs-parser.jay: Add embedded blocks to the list of statements of
17982 this block. So code generation proceeds in a top down fashion.
17984 2001-08-23 Miguel de Icaza <miguel@ximian.com>
17986 * statement.cs: Add support for multiple child blocks.
17988 2001-08-22 Miguel de Icaza <miguel@ximian.com>
17990 * codegen.cs (EmitCode): New function, will emit the code for a
17991 Block of code given a TypeContainer and its ILGenerator.
17993 * statement.cs (Block): Standard public readonly optimization.
17994 (Block::Block constructors): Link children.
17995 (Block::Child): Child Linker.
17996 (Block::EmitVariables): Emits IL variable declarations.
17998 * class.cs: Drop support for MethodGroups here, delay until
18000 (Method::): Applied the same simplification that I did before, and
18001 move from Properties to public readonly fields.
18002 (Method::ParameterTypes): Returns the parameter types for the
18003 function, and implements a cache that will be useful later when I
18004 do error checking and the semantic analysis on the methods is
18006 (Constructor::GetCallingConvention): Renamed from CallingConvetion
18007 and made a method, optional argument tells whether this is a class
18008 or a structure to apply the `has-this' bit.
18009 (Method::GetCallingConvention): Implement, returns the calling
18011 (Method::Define): Defines the type, a second pass is performed
18012 later to populate the methods.
18014 (Constructor::ParameterTypes): implement a cache similar to the
18015 one on Method::ParameterTypes, useful later when we do semantic
18018 (TypeContainer::EmitMethod): New method. Emits methods.
18020 * expression.cs: Removed MethodGroup class from here.
18022 * parameter.cs (Parameters::GetCallingConvention): new method.
18024 2001-08-21 Miguel de Icaza <miguel@ximian.com>
18026 * class.cs (TypeContainer::Populate): Drop RootContext from the
18029 (Constructor::CallingConvention): Returns the calling convention.
18030 (Constructor::ParameterTypes): Returns the constructor parameter
18033 (TypeContainer::AddConstructor): Keep track of default constructor
18034 and the default static constructor.
18036 (Constructor::) Another class that starts using `public readonly'
18037 instead of properties.
18039 (Constructor::IsDefault): Whether this is a default constructor.
18041 (Field::) use readonly public fields instead of properties also.
18043 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
18044 track of static constructors; If none is used, turn on
18045 BeforeFieldInit in the TypeAttributes.
18047 * cs-parser.jay (opt_argument_list): now the return can be null
18048 for the cases where there are no arguments.
18050 (constructor_declarator): If there is no implicit `base' or
18051 `this', then invoke the default parent constructor.
18053 * modifiers.cs (MethodAttr): New static function maps a set of
18054 modifiers flags into a MethodAttributes enum
18055 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
18056 MethodAttr, TypeAttr to represent the various mappings where the
18057 modifiers are used.
18058 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
18060 2001-08-19 Miguel de Icaza <miguel@ximian.com>
18062 * parameter.cs (GetParameterInfo): Fix bug where there would be no
18065 * interface.cs (PopulateIndexer): Implemented the code generator
18066 for interface indexers.
18068 2001-08-17 Miguel de Icaza <miguel@ximian.com>
18070 * interface.cs (InterfaceMemberBase): Now we track the new status
18073 (PopulateProperty): Implement property population. Woohoo! Got
18074 Methods and Properties going today.
18076 Removed all the properties for interfaces, and replaced them with
18077 `public readonly' fields.
18079 2001-08-16 Miguel de Icaza <miguel@ximian.com>
18081 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
18082 initialize their hashtables/arraylists only when they are needed
18083 instead of doing this always.
18085 * parameter.cs: Handle refs and out parameters.
18087 * cs-parser.jay: Use an ArrayList to construct the arguments
18088 instead of the ParameterCollection, and then cast that to a
18091 * parameter.cs: Drop the use of ParameterCollection and use
18092 instead arrays of Parameters.
18094 (GetParameterInfo): Use the Type, not the Name when resolving
18097 2001-08-13 Miguel de Icaza <miguel@ximian.com>
18099 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
18100 and instead use public readonly fields.
18102 * class.cs: Put back walking code for type containers.
18104 2001-08-11 Miguel de Icaza <miguel@ximian.com>
18106 * class.cs (MakeConstant): Code to define constants.
18108 * rootcontext.cs (LookupType): New function. Used to locate types
18111 2001-08-08 Miguel de Icaza <miguel@ximian.com>
18113 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
18114 this System.Reflection code is. Kudos to Microsoft
18116 * typemanager.cs: Implement a type cache and avoid loading all
18117 types at boot time. Wrap in LookupType the internals. This made
18118 the compiler so much faster. Wow. I rule!
18120 * driver.cs: Make sure we always load mscorlib first (for
18121 debugging purposes, nothing really important).
18123 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
18124 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
18126 * rootcontext.cs: Lookup types on their namespace; Lookup types
18127 on namespaces that have been imported using the `using' keyword.
18129 * class.cs (TypeContainer::TypeAttr): Virtualize.
18130 (Class::TypeAttr): Return attributes suitable for this bad boy.
18131 (Struct::TypeAttr): ditto.
18132 Handle nested classes.
18133 (TypeContainer::) Remove all the type visiting code, it is now
18134 replaced with the rootcontext.cs code
18136 * rootcontext.cs (GetClassBases): Added support for structs.
18138 2001-08-06 Miguel de Icaza <miguel@ximian.com>
18140 * interface.cs, statement.cs, class.cs, parameter.cs,
18141 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
18142 Drop use of TypeRefs, and use strings instead.
18144 2001-08-04 Miguel de Icaza <miguel@ximian.com>
18148 * class.cs (Struct::Struct): set the SEALED flags after
18149 checking the modifiers.
18150 (TypeContainer::TypeAttr): new property, returns the
18151 TypeAttributes for a class.
18153 * cs-parser.jay (type_list): Oops, list production was creating a
18154 new list of base types.
18156 * rootcontext.cs (StdLib): New property.
18157 (GetInterfaceTypeByName): returns an interface by type name, and
18158 encapsulates error handling here.
18159 (GetInterfaces): simplified.
18160 (ResolveTree): Encapsulated all the tree resolution here.
18161 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
18164 * driver.cs: Add support for --nostdlib, to avoid loading the
18165 default assemblies.
18166 (Main): Do not put tree resolution here.
18168 * rootcontext.cs: Beginning of the class resolution.
18170 2001-08-03 Miguel de Icaza <miguel@ximian.com>
18172 * rootcontext.cs: Provide better error reporting.
18174 * cs-parser.jay (interface_base): set our $$ to be interfaces.
18176 * rootcontext.cs (CreateInterface): Handle the case where there
18177 are no parent interfaces.
18179 (CloseTypes): Routine to flush types at the end.
18180 (CreateInterface): Track types.
18181 (GetInterfaces): Returns an array of Types from the list of
18182 defined interfaces.
18184 * typemanager.c (AddUserType): Mechanism to track user types (puts
18185 the type on the global type hash, and allows us to close it at the
18188 2001-08-02 Miguel de Icaza <miguel@ximian.com>
18190 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
18191 RecordInterface instead.
18193 * cs-parser.jay: Updated to reflect changes above.
18195 * decl.cs (Definition): Keep track of the TypeBuilder type that
18196 represents this type here. Not sure we will use it in the long
18197 run, but wont hurt for now.
18199 * driver.cs: Smaller changes to accomodate the new code.
18201 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
18204 * rootcontext.cs (CreateInterface): New method, used to create
18205 the System.TypeBuilder type for interfaces.
18206 (ResolveInterfaces): new entry point to resolve the interface
18208 (CodeGen): Property, used to keep track of the code generator.
18210 2001-07-26 Miguel de Icaza <miguel@ximian.com>
18212 * cs-parser.jay: Add a second production for delegate_declaration
18215 (enum_body): Put an opt_comma here instead of putting it on
18216 enum_body or enum_member_declarations so we can handle trailing
18217 commas on enumeration members. Gets rid of a shift/reduce.
18219 (type_list): Need a COMMA in the middle.
18221 (indexer_declaration): Tell tokenizer to recognize get/set
18223 * Remove old targets.
18225 * Re-add the parser target.
18227 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18229 * cs-parser.jay: Add precendence rules for a number of operators
18230 ot reduce the number of shift/reduce conflicts in the grammar.
18232 2001-07-17 Miguel de Icaza <miguel@ximian.com>
18234 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
18237 Get rid of old crufty code.
18239 * rootcontext.cs: Use this to keep track of the parsed
18240 representation and the defined types available to the program.
18242 * gen-treedump.cs: adjust for new convention.
18244 * type.cs: Split out the type manager, and the assembly builder
18247 * typemanager.cs: the type manager will live here now.
18249 * cil-codegen.cs: And the code generator here.
18251 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
18253 * makefile: Fixed up for easy making.
18255 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18257 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
18260 (unary_expression): Expand pre_increment_expression and
18261 post_decrement_expression to reduce a shift/reduce.
18263 2001-07-11 Simon Cozens
18265 * cs-tokenizer.cs: Hex numbers should begin with a 0.
18267 Improve allow_keyword_as_indent name.
18269 2001-06-19 Miguel de Icaza <miguel@ximian.com>
18271 * Adjustments for Beta2.
18273 2001-06-13 Miguel de Icaza <miguel@ximian.com>
18275 * decl.cs: Added `Define' abstract method.
18276 (InTransit): new property, used to catch recursive definitions.
18278 * interface.cs: Implement `Define'.
18280 * modifiers.cs: Map Modifiers.constants to
18281 System.Reflection.TypeAttribute flags.
18283 * class.cs: Keep track of types and user-defined types.
18284 (BuilderInit): New method for creating an assembly
18285 (ResolveType): New function to launch the resolution process, only
18286 used by interfaces for now.
18288 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
18289 that are inserted into the name space.
18291 2001-06-08 Miguel de Icaza <miguel@ximian.com>
18293 * ARGH. I have screwed up my tree so many times due to the use of
18294 rsync rather than using CVS. Going to fix this at once.
18296 * driver.cs: Objetify driver. Load assemblies, use assemblies to
18299 2001-06-07 Miguel de Icaza <miguel@ximian.com>
18301 * Experiment successful: Use System.Type rather that our own
18304 2001-05-25 Miguel de Icaza <miguel@ximian.com>
18306 * cs-parser.jay: Removed nsAliases from here.
18308 Use new namespaces, handle `using XXX;'
18310 * namespace.cs: Reimplemented namespace handling, use a recursive
18311 definition of the class. Now we can keep track of using clauses
18312 and catch invalid using clauses.
18314 2001-05-24 Miguel de Icaza <miguel@ximian.com>
18316 * gen-treedump.cs: Adapted for all the renaming.
18318 * expression.cs (Expression): this class now has a Type property
18319 which returns an expression Type.
18321 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
18322 `Type', as this has a different meaning now in the base
18324 2001-05-22 Miguel de Icaza <miguel@ximian.com>
18326 * interface.cs, class.cs: Removed from all the sources the
18327 references to signature computation, as we can not do method
18328 signature computation during the parsing time, as we are not
18329 trying to solve at that point distinguishing:
18333 void a (NS.Blah x) {}
18336 Which depending on the context might be valid or not, as we do not
18337 know if Blah is the same thing as NS.Blah at that point.
18339 * Redid everything so the code uses TypeRefs now instead of
18340 Types. TypeRefs are just temporary type placeholders, that need
18341 to be resolved. They initially have a pointer to a string and the
18342 current scope in which they are used. This is used later by the
18343 compiler to resolve the reference to an actual Type.
18345 * DeclSpace is no longer a CIR.Type, and neither are
18346 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18347 are all DeclSpaces, but no Types.
18349 * type.cs (TypeRefManager): This implements the TypeRef manager,
18350 which keeps track of all the types that need to be resolved after
18351 the parsing has finished.
18353 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18355 * ARGH. We are going to have to store `foreach' as a class rather
18356 than resolving it, as we need to verify error 1579 after name
18357 resolution. *OR* we could keep a flag that says `This request to
18358 IEnumerator comes from a foreach statement' which we can then use
18359 to generate the error.
18361 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18363 * class.cs (TypeContainer.AddMethod): we now add methods to the
18364 MethodGroup instead of the method hashtable.
18366 * expression.cs: Add MethodGroup abstraction, which gets us one
18367 step closer to the specification in the way we handle method
18370 * cs-parser.jay (primary_expression): qualified_identifier now
18371 tried to match up an identifier to a local variable reference or
18372 to a parameter reference.
18374 current_local_parameters is now a parser global variable that
18375 points to the current parameters for the block, used during name
18378 (property_declaration): Now creates an implicit `value' argument to
18381 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18383 * parameter.cs: Do not use `param' arguments as part of the
18384 signature, per the spec.
18386 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18388 * decl.cs: Base class for classes, structs and interfaces. This
18389 is the "Declaration Space"
18391 * cs-parser.jay: Use CheckDef for checking declaration errors
18392 instead of having one on each function.
18394 * class.cs: Factor out some code for handling error handling in
18395 accordance to the "Declarations" section in the "Basic Concepts"
18396 chapter in the ECMA C# spec.
18398 * interface.cs: Make all interface member classes derive from
18399 InterfaceMemberBase.
18401 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18403 * Many things: all interfaces are parsed and generated in
18404 gen-treedump. Support for member variables, constructors,
18405 destructors, properties, constants is there.
18407 Beginning of the IL backend, but very little done, just there for
18410 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18412 * cs-parser.jay: Fix labeled statement.
18414 * cs-tokenizer.cs (escape): Escape " and ' always.
18415 ref_line, ref_name: keep track of the line/filename as instructed
18416 by #line by the compiler.
18419 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18421 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18422 to match the values in System.CodeDOM.
18424 Divid renamed to Divide.
18426 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18428 (Statements.set): remove.
18430 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18433 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18434 falseStatements always have valid values.
18436 * cs-parser.jay: Use System.CodeDOM now.