1 2008-03-20 Marek Safar <marek.safar@gmail.com>
3 * location.cs: Use string based concatenation.
5 * expression.cs: LiftedBinaryOperator is gmcs only.
7 2008-03-20 Marek Safar <marek.safar@gmail.com>
9 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
10 conversions rules and expression trees.
12 2008-03-19 Marek Safar <marek.safar@gmail.com>
14 * delegate.cs: Use extension method source as delegate target.
16 2008-03-19 Marek Safar <marek.safar@gmail.com>
18 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
19 binary operations to be purely based on binary operations and optimized
20 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
21 and other ET refactoring.
23 * typemanager.cs: Fixed warning.
25 2008-03-17 Marek Safar <marek.safar@gmail.com>
27 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
29 * symbolwriter.cs: Fixed.
31 2008-03-17 Marek Safar <marek.safar@gmail.com>
33 * anonymous.cs, driver.cs: Reset anonymous types counters.
35 2008-03-17 Marek Safar <marek.safar@gmail.com>
37 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
39 * class.cs: Use fullname for all type member definitions.
41 2008-02-19 Martin Baulig <martin@ximian.com>
44 (IMethodData.EmitExtraSymbolInfo): New interface method.
45 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
46 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
47 interface method here as an empty public virtual method.
50 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
51 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
52 CodeGen.SymbolWriter.SetRealMethodName().
54 2008-02-18 Martin Baulig <martin@ximian.com>
57 (ScopeInfo.EmitType): Override this and emit debugging
58 information for captured variables.
59 (RootScopeInfo.EmitType): Override this and emit symbol
60 information for a captured `this'.
62 2008-02-15 Martin Baulig <martin@ximian.com>
64 * iterators.cs: Emit debugging info.
67 (EmitContext.Flags): Add `OmitDebuggingInfo'.
68 (EmitContext.OmitDebuggingInfo): New public property.
71 (While): Override Emit() and don't emit symbol info there; do it
72 inside DoEmit() instead.
73 (Block.Emit): Omit symbol information while emitting the scope
74 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
76 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
77 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
78 .ctor to make `IsIterator' work.
80 2008-03-14 Martin Baulig <martin@ximian.com>
82 * symbolwriter.cs: Added the new symbol writer function from the
83 debugger's `terrania' branch; temporarily enclose them inside
84 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
87 2008-03-14 Martin Baulig <martin@ximian.com>
90 (SymbolWriter): Make this a public static class.
93 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
94 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
96 2008-03-14 Marek Safar <marek.safar@gmail.com>
99 * statement.cs, lambda.cs: Added extra limitations when dealing with void
102 2008-03-14 Marek Safar <marek.safar@gmail.com>
104 * typemanager.cs (CSharpName): Made 250 times faster.
106 2008-03-13 Marek Safar <marek.safar@gmail.com>
108 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
110 2008-03-12 Marek Safar <marek.safar@gmail.com>
112 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
113 crash when predefined field does not exist.
115 2008-03-12 Marek Safar <marek.safar@gmail.com>
117 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
119 2008-03-12 Marek Safar <marek.safar@gmail.com>
121 * class.cs (FixedField): Don't crash when contructors are missing.
123 2008-03-11 Marek Safar <marek.safar@gmail.com>
125 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
126 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
127 check internal types accessibility for internal and external types.
128 Replaced EnumToUnderlying by GetEnumUnderlyingType.
130 2008-03-11 Marek Safar <marek.safar@gmail.com>
132 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
133 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
134 attribute.cs, statement: Use corect instance of predefined types (work
137 2008-03-07 Marek Safar <marek.safar@gmail.com>
139 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
141 2008-03-07 Marek Safar <marek.safar@gmail.com>
143 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
144 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
145 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
146 predefined types clean up, delayed predefined types members initialization
147 (work related to #364674).
149 2008-03-05 Marek Safar <marek.safar@gmail.com>
151 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
153 2008-03-05 Marek Safar <marek.safar@gmail.com>
155 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
156 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
157 predefined types clean up (work related to #364674).
159 2008-03-04 Marek Safar <marek.safar@gmail.com>
161 * ecore.cs: Print an error message instead of throwing exception.
163 2008-03-04 Marek Safar <marek.safar@gmail.com>
165 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
166 expression.cs, statement.cs: Unififed null literal representation.
168 2008-03-03 Marek Safar <marek.safar@gmail.com>
170 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
171 expression.cs: Refactored binary operators resolve phase and improved speed.
172 The nullable code is still missing and won't work correctly, more fixes
175 It also fixes #323726, #324312, #324248, and many other unreported issues.
177 2008-02-29 Zoltan Varga <vargaz@gmail.com>
179 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
182 2008-02-27 Marek Safar <marek.safar@gmail.com>
184 * ecore.cs: Clean-up and split BetterConversion.
186 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
189 * enum.cs (EnumMember.Value): Only access 'value' if
190 ResolveValue says it's ok.
191 (EnumMember.DoResolveValue): Don't set prev_member.value.
192 (Enum.GetDefinition): Reverse arguments of Equals --
193 EnumMember.Value can return 'null'.
195 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
197 2008-02-22 Marek Safar <marek.safar@gmail.com>
199 * generic.cs, expression.cs: More ongoing work on expression trees.
201 2008-02-21 Marek Safar <marek.safar@gmail.com>
203 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
204 handle missing matches when mutiple operators exist.
206 2008-02-20 Marek Safar <marek.safar@gmail.com>
208 A fix for bug #363218
209 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
212 2008-02-20 Marek Safar <marek.safar@gmail.com>
214 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
215 update. This time to deal correctly with SideEffectConstant expression used
216 as an argument for another constant folding.
218 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
220 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
223 2008-02-19 Marek Safar <marek.safar@gmail.com>
225 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
227 2008-02-19 Marek Safar <marek.safar@gmail.com>
229 A fix for bug #328136
230 * expression.cs: Do not fold immediately LogicalAnd operators when the left
231 side is a false constant, because we still need to evaluate the right-hand
234 * statement.cs (If): Emit two types of boolean constants (simple constant,
235 side-effect constant).
237 2008-02-19 Marek Safar <marek.safar@gmail.com>
239 * constant.cs (SideEffectConstant): Don't emit boolean constant.
241 * expression.cs: Fold immediately LogicalAnd operators when both sides are
244 2008-02-18 Marek Safar <marek.safar@gmail.com>
246 A fix for bug #361457
247 * ecore.cs (IsApplicable): Params methods have lower priority.
249 * support.cs: Return correct parameter modifier for params types.
251 2008-02-18 Marek Safar <marek.safar@gmail.com>
253 * generic.cs (TypeParameter): Cache attribute target name.
255 * support.cs: Removed unused variable.
257 * typemanager.cs: Removed debugging leftover.
259 * ecore.cs: Use local type instead of a property;
261 * class.cs (VerifyMembers): Consider also parent to test whether type member
264 * expression.cs (FullMethodDesc): Removed.
266 * attribute.cs (IsValidArgumentType): Made static.
268 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
270 Cleanup to be more readable.
271 * Makefile (GMCS_PROFILE): Remove.
272 (COMPILER_NAME): New helper.
274 2008-02-15 Miguel de Icaza <miguel@novell.com>
276 * cs-tokenizer.cs: if a conditional expression happens inside a
277 (...) this also means that we do not need to de-ambiguate between
278 an parenthesized expression and a cast.
282 * constant.cs (SideEffectConstant): a constant value that happens
283 to have a side effect.
285 Fixes the build regressions introduced by the fix for #359789
287 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
289 * expression.cs (Conditional.Emit): when emitting the ternary
290 operator, use local variables to generate code verifiable code.
292 The verifier cannot infer that the type on stack before the
293 stloc.0 is executed is of type ParentB. This happens because the
294 stack merge algorithm uses only parent types when deciding which
295 is the common type. This is described in Part III 1.8.1.3 of ECMA
298 This code compiled with mcs is not verifiable under MS. The MS
299 verifier picks the first common interface of Foo and Bar, which is
300 wrong, but doesn't use a full join type of the 2 interfaces.
302 CSC uses a clever hack to compile such code in a verifiable
303 way. It stores the intermediate values in a local variable with
308 2008-02-14 Miguel de Icaza <miguel@novell.com>
310 * expression.cs: Do not fold BitwiseAnd operators when the left
311 side is a false constant, because we still need to evaluate the
316 * support.cs: Instead of throwing an InternalErrorException when
317 the position of the stream is outside the boundary of our buffer,
318 reset the state of the reader, and restart the reading from the
319 beginning of the file.
321 2008-02-14 Marek Safar <marek.safar@gmail.com>
323 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
325 2008-02-14 Marek Safar <marek.safar@gmail.com>
327 A fix for bug #361686
328 * decl.cs: A protected types used inside a private class which parents
329 derives from the protected class are accessible.
331 2008-02-13 Marek Safar <marek.safar@gmail.com>
333 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
334 the parameterless constructor.
336 2008-02-13 Marek Safar <marek.safar@gmail.com>
338 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
339 lookup methods to use standard member cache when doing member lookup.
341 2008-02-12 Marek Safar <marek.safar@gmail.com>
343 * driver.cs: Don't report full path for referenced module as assembly error.
345 2008-02-12 Marek Safar <marek.safar@gmail.com>
347 * Makefile: Fixed `qh' target to work on all machines.
349 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
350 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
351 and HasElementType with TypeManager implementation.
353 2008-02-08 Marek Safar <marek.safar@gmail.com>
355 A fix for bugs #325134, #359749
356 * expression.cs, ecore.cs: Try to resolve an extension method even if the
357 first binds point to non-method member expression.
359 2008-02-08 Marek Safar <marek.safar@gmail.com>
361 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
363 2008-02-08 Marek Safar <marek.safar@gmail.com>
365 A fix for bugs #321394, #323028
366 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
367 Reworked naive IsAccessibleAs implementation to handle nested types.
369 2008-02-05 Jb Evain <jbevain@novell.com>
371 * class.cs: use generic type comparison for parameters
374 2008-02-05 Marek Safar <marek.safar@gmail.com>
376 A fix for bug #325372
377 * class.cs: Use generic type comparison when testing method signatures.
379 2008-02-05 Marek Safar <marek.safar@gmail.com>
381 A fix for bug #357047
382 * ecore.cs: Applied C# 3.0 changes to better conversion.
384 2008-02-05 Marek Safar <marek.safar@gmail.com>
386 A fix for bug #358374
387 * cs-parser.jay: Correctly set modifiers for all constructor types.
389 2008-02-04 Marek Safar <marek.safar@gmail.com>
391 A fix for bug #355251
392 * generic.cs: Added base class constraint based type inference.
394 2008-02-01 Marek Safar <marek.safar@gmail.com>
396 A fix for bug #357255
397 * decl.cs: One more missing visibility check.
399 2008-02-01 Marek Safar <marek.safar@gmail.com>
401 * support.cs: Fixed broken return.
403 2008-01-25 Marek Safar <marek.safar@gmail.com>
405 * report.cs: Correctly reset warnings count after probing.
407 2008-01-25 Martin Baulig <martin@ximian.com>
410 (NamespaceEntry.SymbolFileID): Make this work again after
411 MemberName.ToString() is gone.
413 2008-01-25 Marek Safar <marek.safar@gmail.com>
415 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
418 2008-01-25 Marek Safar <marek.safar@gmail.com>
420 * generic.cs: Use full implicit conversion for type inference fixing.
422 2008-01-24 Marek Safar <marek.safar@gmail.com>
424 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
425 Fixed user operator conversions.
427 2008-01-24 Marek Safar <marek.safar@gmail.com>
429 * generic.cs: Do nullable type to null comparison optimization during
432 2008-01-24 Marek Safar <marek.safar@gmail.com>
434 A fix for bug #355163
435 * generic.cs: Enabled l-value resolve on nullable expressions.
437 2008-01-24 Marek Safar <marek.safar@gmail.com>
439 A fix for bug #353986
440 * class.cs: Ingore static ctors with parameters for any further checks.
442 2008-01-24 Marek Safar <marek.safar@gmail.com>
444 A fix for bug #354310
445 * namespace.cs: Removed redundant check.
447 2008-01-24 Marek Safar <marek.safar@gmail.com>
449 A fix for bug #354928
450 * expression.cs: ElementInitializers can be resolved only once.
452 2008-01-24 Marek Safar <marek.safar@gmail.com>
454 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
455 Condition expressions.
457 2008-01-23 Marek Safar <marek.safar@gmail.com>
459 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
461 2008-01-22 Marek Safar <marek.safar@gmail.com>
463 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
466 * generic.cs: Implemented coalesce expression.
468 2008-01-22 Marek Safar <marek.safar@gmail.com>
470 A fix for bug #355145
471 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
472 expression tree type inference.
474 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
477 * expression.cs (Binary.IsUnsignedType): Fix typo.
479 2008-01-22 Marek Safar <marek.safar@gmail.com>
481 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
483 2008-01-22 Marek Safar <marek.safar@gmail.com>
485 A fix for bug #355161
486 * ecore.cs, expression.cs: Wider range of extension method supported
489 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
491 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
492 AssemblyBuilder to operate in compiler context. Fixes mcs part of
495 2008-01-22 Marek Safar <marek.safar@gmail.com>
497 A fix for bug #355148
498 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
500 2008-01-22 Miguel de Icaza <miguel@novell.com>
502 * expression.cs (CreateExpressionTree): Add support for or and
503 logical or, and indent following the coding conventions.
505 * typemanager.cs (LinqExpression): renamed from
506 ExpressionTreeManager, for a shorter name.
508 Use TypeManager.CoreLookupType to lookup types from our core
509 assemblies and turn those into "Type" variables.
511 Consumers that previously used "Namespace" and "Type" from this
512 class should instead use the TypeExpression which is a type that
513 is fully resolved (without involving the regular C# resolution
516 This typically looks like this:
518 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
519 new MemberAccess (texpr, name, type_arguments, loc)
521 This avoids the problem in: #355178
523 2008-01-21 Marek Safar <marek.safar@gmail.com>
525 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
526 feature in parser only as we do in other cases.
528 2008-01-21 Marek Safar <marek.safar@gmail.com>
530 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
531 typemanager.cs: A refactoring of params arguments to reuse existing
532 expressions (params -> array initializer) to emit params argument instead
533 of specialized handling.
534 It was required by expression tree implementation and it has other benefits
535 as well, we now apply same optimization for params arguments as we do for
538 2008-01-18 Marek Safar <marek.safar@gmail.com>
540 A fix for bug #353526
541 * generic.cs: A type inference of params arguments may not required any
542 temporary array creation.
544 2008-01-18 Marek Safar <marek.safar@gmail.com>
546 A fix for bug #353534
547 * generic.cs, ecore.cs, expression.cs: A method group type inference is
548 supported for delegates only.
550 2008-01-18 Marek Safar <marek.safar@gmail.com>
552 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
553 type for more than 1 candidates.
555 2008-01-18 Marek Safar <marek.safar@gmail.com>
557 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
560 2008-01-16 Marek Safar <marek.safar@gmail.com>
562 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
563 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
564 operator) expressions.
566 2008-01-16 Zoltan Varga <vargaz@gmail.com>
568 * statement.cs: Avoid declaring an IL variable for this_variable since it is
569 not accessed from the generated IL.
571 2008-01-14 Marek Safar <marek.safar@gmail.com>
573 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
574 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
575 statement.cs: The first expression tree implementation drop, mostly
578 2008-01-14 Marek Safar <marek.safar@gmail.com>
580 * ecore.cs (IsNestedChild): Refactored.
582 2008-01-11 Marek Safar <marek.safar@gmail.com>
584 * lambda.cs: Don't use a cast on unknown expression statement.
586 2008-01-10 Geoff Norton <gnorton@novell.com>
588 * cs-tokenizer.cs: One more token to distinguish between method and lambda
591 2008-01-09 Marek Safar <marek.safar@gmail.com>
593 * doc.cs: Report better /doc crash details.
595 2008-01-09 Marek Safar <marek.safar@gmail.com>
597 A fix for bug #352536
598 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
600 2008-01-08 Marek Safar <marek.safar@gmail.com>
602 A fix for bug #352287
603 * ecore.cs, expression.cs: Do `this' access checking in all member access
606 2008-01-08 Marek Safar <marek.safar@gmail.com>
608 * rootcontext.cs, driver.cs: Switch to linq mode by default.
610 * report.cs: Reset message stacks.
612 2008-01-08 Marek Safar <marek.safar@gmail.com>
614 * generic.cs (InferInPhases): Correctly calculate params position.
616 2008-01-08 Marek Safar <marek.safar@gmail.com>
618 * cs-tokenizer.cs: No need to parse full string when parsing lambda
621 2008-01-07 Marek Safar <marek.safar@gmail.com>
623 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
625 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
627 * driver.cs: Updated --help option.
629 2008-01-07 Marek Safar <marek.safar@gmail.com>
631 * generic.cs (InferParamsTypeArguments): Removed.
632 (InferInPhases): Add params type inference.
633 (LowerBoundInference): Fixed scoring mechanism.
635 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
637 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
639 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
640 byte array for unsigned "baked" assemblies.
642 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
644 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
645 array for assemblies that are not strongnamed.
647 2008-01-04 Marek Safar <marek.safar@gmail.com>
649 A fix for bug #351481
650 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
651 declaring type for nested generic types.
653 2008-01-04 Marek Safar <marek.safar@gmail.com>
655 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
658 2008-01-03 Marek Safar <marek.safar@gmail.com>
660 A fix for bug #351047
661 * expression.cs (Binary.ResolveOperator): Allow equality operators between
662 null and structs only when equality and inequality operators are defined
663 either as an user-operators or predefined operators.
665 2008-01-03 Marek Safar <marek.safar@gmail.com>
667 A fix for bug #351047
668 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
670 2008-01-03 Marek Safar <marek.safar@gmail.com>
672 A fix for bug #351257
673 * cs-tokenizer.cs: Advance line number for '\r' correctly.
675 2008-01-03 Marek Safar <marek.safar@gmail.com>
677 A fix for bug #351157
678 * class.cs (Using): Fixed yet another broken cloning.
680 (Block): Put back more sensible default value for statements.
682 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
684 * codegen.cs: Allow AssemblyVersion with only major version component.
687 2007-12-29 Marek Safar <marek.safar@gmail.com>
689 A fix for bug #324654
690 * class.cs: Use FullName property as member name.
692 2007-12-28 Marek Safar <marek.safar@gmail.com>
694 A fix for bug #342117
695 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
696 constructor constraint.
698 2007-12-28 Marek Safar <marek.safar@gmail.com>
700 A fix for bug #338273
701 * class.cs (ProbertyBase): Access modifier checks are required for overrides
704 2007-12-28 Marek Safar <marek.safar@gmail.com>
706 A fix for bug #350839
707 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
709 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
711 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
714 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
716 * statement.cs: Changed some Hashtables to use HybridDictionaries
717 instead. It was observed that some HashTables only contained a few
718 items in the vast majority of cases. Since HybridDictionary is
719 more efficient on small sets (<10 elements), "known_variables"
720 from class ExplicitBlock as well as "labels" and "constants " from
721 class Block were changed to HybridDictionaries.
723 Atsai results: (56216kb->54987kb)
725 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
728 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
730 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
733 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
735 * expression.cs: foreach loop to for loop, saved on allocation of
736 enumerator (59333kb->59141kb)
738 * statement.cs. Changed foreach loops to for loops, saved on
739 allocation of enumerator (59141kb->59006kb)
741 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
742 when constructed with no specified capacity. This was causing a
743 few ArrayLists to allocate more memory than they would potentially
744 need in the Block class and MemberCache class. Setting the
745 ArrayLists to construct with a capacity of 1 saves some
746 memory. (56216kb->55585kb)
748 2007-12-27 Marek Safar <marek.safar@gmail.com>
750 A fix for bug #347189 (2nd issue)
751 * expression.cs (MemberAccess): Nested type can be found in base non-generic
754 2007-12-27 Miguel de Icaza <miguel@novell.com>
756 * report.cs: Do not use colors if stdout and stderr are not a
759 2007-12-27 Marek Safar <marek.safar@gmail.com>
761 A fix for bug #346998
762 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
765 2007-12-27 Marek Safar <marek.safar@gmail.com>
767 A fix for bug #343465
768 * class.cs: Explicit method name for nested types uses dots only.
770 2007-12-27 Marek Safar <marek.safar@gmail.com>
772 A fix for bug #343707
773 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
775 2007-12-27 Marek Safar <marek.safar@gmail.com>
777 * ecore.cs: Report type inference errors only when arguments count matches
780 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
782 * expression.cs, report.cs: New warning.
784 * typemanager.cs: Catch anonymous method type too.
786 2007-12-23 Marek Safar <marek.safar@gmail.com>
788 A fix for bug #346379
789 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
791 2007-12-23 Marek Safar <marek.safar@gmail.com>
793 A fix for bug #347359
794 * expression.cs (Invocation): Don't resolve already resolved expression.
796 2007-12-23 Marek Safar <marek.safar@gmail.com>
798 A fix for bug #347189
799 * class.cs (FixedField): Use non-dependent code only in the define phase.
801 2007-12-23 Marek Safar <marek.safar@gmail.com>
803 A fix for bug #348076
804 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
806 2007-12-22 Marek Safar <marek.safar@gmail.com>
808 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
809 discovered extension methods.
811 2007-12-22 Marek Safar <marek.safar@gmail.com>
813 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
816 2007-12-21 Miguel de Icaza <miguel@novell.com>
818 * report.cs (ErrorMessage): Add support for using colors on
819 terminals that support it.
821 2007-12-21 Marek Safar <marek.safar@gmail.com>
823 * ecore.cs: Use information about expanded params for error reporting.
825 2007-12-21 Marek Safar <marek.safar@gmail.com>
827 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
828 and logic for params overloads.
830 2007-12-15 Miguel de Icaza <miguel@novell.com>
832 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
833 as this is also created from the parser. Fixes #349034
835 2007-12-12 Miguel de Icaza <miguel@novell.com>
837 * statement.cs (Throw.CloneTo): it is valid to have empty
838 expressions for throw.
840 2007-12-03 Marek Safar <marek.safar@gmail.com>
842 * cs-parser.jay: Set delegate constraint parsing region correctly.
844 2007-12-03 Marek Safar <marek.safar@gmail.com>
846 A fix for bug #345467
847 * typemanager.cs (IsEqual): Compare generic parameters position only.
849 2007-11-28 Marek Safar <marek.safar@gmail.com>
851 * expression.cs (BaseAccess): Type arguments can be null.
853 2007-11-27 Raja R Harinath <harinath@gmail.com>
855 * statement.cs (Block.Resolve): Ensure flow-branching tree is
856 consistent even when an error has occured.
857 (Switch.Resolve): Likewise.
859 2007-11-22 Marek Safar <marek.safar@gmail.com>
861 A fix for bug #334505
862 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
865 2007-11-22 Marek Safar <marek.safar@gmail.com>
867 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
868 refactorings required to resolve extension methods correctly when mixing
869 generics and non-generics members.
871 2007-11-20 Marek Safar <marek.safar@gmail.com>
873 A fix for bug #342584
874 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
877 2007-11-19 Marek Safar <marek.safar@gmail.com>
879 A fix for bug #342512
880 * delegate.cs: Use delegate argument expression when is available. Don't
881 emit virtual call when class is sealed.
883 2007-11-16 Marek Safar <marek.safar@gmail.com>
885 A fix for bug #325423
886 * assign.cs (FieldInitializer): Use resolved expression for emit.
888 * class.cs: Print less confusing error message.
890 2007-11-16 Marek Safar <marek.safar@gmail.com>
892 * cs-tokenizer.cs: Removed GMCS ifdefs.
894 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
897 * cs-parser.jay: Disabled nullable check.
899 * generic-mcs: Copied more generic stuff.
901 2007-11-16 Marek Safar <marek.safar@gmail.com>
903 * gcs-parser.jay: Merged to cs-parser.jay.
905 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
906 * *.csproj, *.sources: Updated to use only jay parser file.
908 2007-11-16 Marek Safar <marek.safar@gmail.com>
910 * gcs-parser.jay: Added nullable and default expression feature checks.
912 2007-11-16 Marek Safar <marek.safar@gmail.com>
914 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
915 it fixes many TODOs and hidden bugs.
917 * expression: Removed duplicate error check.
919 2007-11-15 Marek Safar <marek.safar@gmail.com>
921 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
922 implicitly type local variable only when it is used in a declaration.
924 2007-11-15 Marek Safar <marek.safar@gmail.com>
926 * attribute.cs: Use CS0612 for empty strings.
928 2007-11-14 Marek Safar <marek.safar@gmail.com>
930 * lambda.cs, statement.cs: Contextual return may act as a statement.
932 2007-11-14 Marek Safar <marek.safar@gmail.com>
934 A fix for a regression cause by #324222
935 * class.cs: Don't report unused even when it implements an interface.
937 2007-11-13 Marek Safar <marek.safar@gmail.com>
939 A fix for bug #341205
940 * ecore.cs, expression.cs: Method group expression cannot do static
941 method access with an instance reference check before overloading takes
944 2007-11-13 Marek Safar <marek.safar@gmail.com>
946 A fix for bug #325359
947 * class.cs: Use predictable name for automatically generated property.
949 2007-11-12 Marek Safar <marek.safar@gmail.com>
951 A fix for bug #324996
952 * expression.cs (Is): Handle case where D is nullable and T is not
955 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
957 2007-11-12 Marek Safar <marek.safar@gmail.com>
959 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
960 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
961 Flush small error reporting changes.
963 2007-11-09 Marek Safar <marek.safar@gmail.com>
965 A fix for bug #324996
966 * expression.cs: Rewrote Is expression implementation to work with
967 generics, nullable types, anonymous method. A const result expression
968 uses existing infrastructure instead of custom not fully-featured one.
970 2007-11-08 Marek Safar <marek.safar@gmail.com>
972 A fix for bug #340202
973 * class.cs: Consider generics for volatile field.
975 2007-11-08 Marek Safar <marek.safar@gmail.com>
977 A fix for bug #335594
978 * expression.cs: Use conversion rules when handling string addition.
980 2007-11-07 Marek Safar <marek.safar@gmail.com>
982 A fix for bug #336651
983 * expression.cs: Fixed a crash when probing is on.
985 2007-11-07 Marek Safar <marek.safar@gmail.com>
987 A fix for bug #324242
988 * covert.cs: Added a conversion from any nullable-type with an
989 underlying enum-type to the type System.Enum.
991 2007-11-07 Marek Safar <marek.safar@gmail.com>
993 A fix for bug #324222
994 * class.cs: Report all non-used event fields.
996 2007-11-07 Marek Safar <marek.safar@gmail.com>
998 A fix for bug #325161
999 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
1000 qualifier for generic types.
1002 2007-11-07 Marek Safar <marek.safar@gmail.com>
1004 A fix for bug #322971
1005 * expression.cs, ecore.cs: Added intermediate result value check for
1008 2007-11-07 Marek Safar <marek.safar@gmail.com>
1010 A fix for bug #324754
1011 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
1012 when it was requested.
1014 2007-11-07 Marek Safar <marek.safar@gmail.com>
1016 A fix for bug #325101
1017 * expression.cs: Do type not value comparison for `is' expression.
1019 2007-11-07 Marek Safar <marek.safar@gmail.com>
1021 A fix for bug #320236
1022 * convert.cs: Don't apply user conversion on underlying target type.
1024 2007-11-06 Marek Safar <marek.safar@gmail.com>
1026 * expression.cs: Don't use unresolved expression for error reporting.
1028 2007-11-06 Marek Safar <marek.safar@gmail.com>
1030 A fix for bugs #337712, #324490
1031 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
1032 overloading resolution too.
1034 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
1035 the process consistent and more robust.
1037 * expression.cs, linq.cs, report.cs: Update.
1039 2007-11-02 Marek Safar <marek.safar@gmail.com>
1041 A fix for bug #332909
1042 * attribute.cs: Resolve attributes in correct context using error
1045 * rootcontext.cs: Define Obsolete attribute members as core members.
1047 2007-11-02 Marek Safar <marek.safar@gmail.com>
1049 * statement.cs: Removed unused methods.
1051 2007-10-31 Wade Berrier <wberrier@novell.com>
1053 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
1054 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
1057 2007-10-31 Marek Safar <marek.safar@gmail.com>
1059 A fix for bug #338102
1060 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
1061 methods registered as non-generics.
1063 2007-10-31 Marek Safar <marek.safar@gmail.com>
1065 A fix for bugs #337712, #324490
1066 * delegate.cs: Delegate covariance and contravariance is not allowed for
1069 2007-10-31 Marek Safar <marek.safar@gmail.com>
1071 A fix for bug #337719
1072 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
1075 2007-10-30 Marek Safar <marek.safar@gmail.com>
1077 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
1079 2007-10-29 Marek Safar <marek.safar@gmail.com>
1081 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
1084 2007-10-29 Raja R Harinath <rharinath@novell.com>
1086 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
1088 2007-10-29 Marek Safar <marek.safar@gmail.com>
1090 A fix for bug #334652
1091 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
1092 extension methods when we have not found the best candidate in normal
1095 2007-10-27 Marek Safar <marek.safar@gmail.com>
1097 * AssemblyInfo.cs: Keep up-to-date.
1099 2007-10-27 Marek Safar <marek.safar@gmail.com>
1101 * Makefile: Fixed generics compiler name.
1103 2007-10-27 Marek Safar <marek.safar@gmail.com>
1105 * lambda.test: removed, lambda parsing is done differently.
1107 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
1109 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
1111 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
1113 2007-10-27 Marek Safar <marek.safar@gmail.com>
1115 * Makefile, *.sources : All C# compilers are in mcs folder.
1117 * *.cs: Use existing 2_1 define for smcs.
1119 2007-10-26 Marek Safar <marek.safar@gmail.com>
1121 A fix for bug #335847
1122 * assign.cs, expression.cs: Couple of changes to avoid creating a
1123 temporary variable for each object initializer assignment statement. It
1124 simplifies struct initialization too, otherwise two temporary variables
1126 Implemented optimization of redundant default element initializers.
1128 2007-10-25 Marek Safar <marek.safar@gmail.com>
1130 A fix for bug #336766
1131 * expression.cs (Class.CheckBase): Use generic name when method is
1134 2007-10-25 Marek Safar <marek.safar@gmail.com>
1136 A fix for bug #334737
1137 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
1138 variable and not variable argument for prepared copies.
1140 2007-10-24 Marek Safar <marek.safar@gmail.com>
1142 A fix for bug #325110
1143 * class.cs, expression.cs, attribute.cs: Use open generic method when
1144 checking conditional attribute.
1146 2007-10-24 Marek Safar <marek.safar@gmail.com>
1148 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
1149 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
1150 FeatureIsNotAvailable.
1152 2007-10-24 Marek Safar <marek.safar@gmail.com>
1154 ** C# 3.0 Partial methods
1156 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
1157 methods support. Because of member cache issue with generics only
1158 non-generics partial methods are fully supported.
1160 2007-10-23 Marek Safar <marek.safar@gmail.com>
1162 * class.cs, decl.cs: Rewrote member overloads check to cope with
1163 generics and to use member cache for member checking. It also improves
1164 performance and fixes remaining overloads issues.
1166 2007-10-20 Marek Safar <marek.safar@gmail.com>
1168 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
1169 roottypes.cs, typemanager.cs:
1171 A member cache creation logic changed to add members immediately and
1172 not rely on fallback. The member cache is now only prefered way
1173 how to access and find type declaration members. It saves 5 MB of memory
1174 during MWF compilation and makes code ready for more optimizations and
1175 clean-ups, it's also a pre-requirement for partial methods.
1177 2007-10-18 Raja R Harinath <harinath@gmail.com>
1179 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
1180 handling for generic parameters.
1182 2007-10-15 Marek Safar <marek.safar@gmail.com>
1184 * class.cs (FixedField): Removed redundant volatile check.
1186 2007-10-15 Marek Safar <marek.safar@gmail.com>
1188 * class.cs, decl.cs: Fixed overload members verification to do only one
1189 check per possible collision.
1191 2007-10-13 Marek Safar <marek.safar@gmail.com>
1193 A fix for bug #325478
1194 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
1195 and create only one disposable flags container.
1197 2007-10-12 Marek Safar <marek.safar@gmail.com>
1199 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
1200 * statement.cs (Fixed): Fixed variables cloning.
1202 2007-10-12 Marek Safar <marek.safar@gmail.com>
1204 A fix for bug #333342
1205 * class.cs (EventField): Don't mark value type event as synchronized.
1207 2007-10-12 Marek Safar <marek.safar@gmail.com>
1209 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
1210 inference to identify best candidate method correctly.
1211 (ProperyExpr): A range variable is read only and cannot be modified.
1213 2007-10-11 Marek Safar <marek.safar@gmail.com>
1215 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
1216 logic to identify best candidate method correctly.
1218 2007-10-11 Marek Safar <marek.safar@gmail.com>
1220 * location.cs (Equals, GetHashCode): Removed.
1222 2007-10-11 Marek Safar <marek.safar@gmail.com>
1224 * report.cs: Implemented message recorder. It is used mainly for lambda
1225 expressions to capture otherwise swallowed error messages.
1227 * anonymous.cs, lambda.cs.cs: Do full parameters check.
1229 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
1231 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
1233 * expression.cs (MemberAccess): Always report lookup failure.
1235 * location.cs: Implemented Equals, GetHashCode.
1237 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
1239 2007-10-10 Jb Evain <jbevain@novell.com>
1241 * codegen.cs: re-enable assembly version check.
1243 2007-10-09 Marek Safar <marek.safar@gmail.com>
1245 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
1248 * namespace.cs (UsingAlias): Do correct version check.
1250 2007-10-08 Marek Safar <marek.safar@gmail.com>
1252 * expresison.cs, ecore.cs: Issue extension method error message when
1255 * rootcontext.cs: Added ISO_2 compiler mode option.
1257 2007-10-08 Marek Safar <marek.safar@gmail.com>
1259 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
1262 2007-10-08 Marek Safar <marek.safar@gmail.com>
1264 * attribute.cs (GetString, GetBoolean): Work with both literal and
1267 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
1268 Moved method overload specific methods to MethodGroupExpr.
1270 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
1271 it should be less memory consuming.
1273 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
1275 * codegen.cs: remove the assembly version check until the buildbot is
1278 2007-10-07 Jb Evain <jbevain@novell.com>
1280 * attribute.cs (Attribute.GetString): if the value
1281 expression is a StringConstant, return its string value.
1283 2007-10-07 Jb Evain <jbevain@novell.com>
1285 * typemanager.cs: add `assembly_version_attribute_type`.
1286 * codegen.cs: on attribute emission, check that the
1287 AssemblyVersionAttribute doesn't overflow.
1289 2007-10-05 Marek Safar <marek.safar@gmail.com>
1291 A fix for bug #324677
1292 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
1293 parent container of a scope container with currently resolved one.
1295 2007-10-05 Marek Safar <marek.safar@gmail.com>
1297 A fix for bug #325534
1298 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
1301 2007-10-05 Marek Safar <marek.safar@gmail.com>
1303 A fix for bug #327504
1304 * class.cs (Operator.Define): Refactored implicit and explicit user
1305 operator conversion rules.
1307 2007-10-05 Marek Safar <marek.safar@gmail.com>
1309 A fix for bug #327520
1310 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
1312 2007-10-04 Marek Safar <marek.safar@gmail.com>
1314 A fix for bug #328022
1315 * class.cs (MethodData.Define): Use correct method to check whether
1316 a method implementents an accessor.
1318 2007-10-04 Marek Safar <marek.safar@gmail.com>
1320 A fix for bug #330069
1321 * statement.cs (Fixed.Resolve): Read the first array element only when
1322 an array is instantiated.
1324 2007-10-04 Marek Safar <marek.safar@gmail.com>
1326 * expression.cs, assign.cs, generics.cs: Print correct operator when
1327 compound assignment is used.
1329 2007-10-04 Marek Safar <marek.safar@gmail.com>
1331 A fix for bug #325841
1332 * expression.cs (ArrayAccess): Use full argument cloning only for
1333 string compound concatenation.
1335 2007-10-03 Marek Safar <marek.safar@gmail.com>
1337 A fix for bug #328774
1338 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
1340 (PropertyExpr.EmitAssign): Fixed string concatenation compound
1343 2007-10-03 Raja R Harinath <rharinath@novell.com>
1346 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
1347 Event accessibility checks here. Remove some bogus code that
1348 accidently made GenericMethods work.
1349 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
1351 2007-09-25 Marek Safar <marek.safar@gmail.com>
1353 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
1355 * statement.cs (Block): Refactored AddVariable to allow error handling
1358 * generic.cs: New stub.
1360 2007-09-23 Marek Safar <marek.safar@gmail.com>
1362 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
1365 2007-09-17 Marek Safar <marek.safar@gmail.com>
1367 * class.cs: Use partial container to record whether any partial part
1368 contains static field initializer and therefore default contructor has
1371 2007-09-14 Marek Safar <marek.safar@gmail.com>
1373 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
1374 mono-list when only one of two partial parts has defined accessibility
1377 2007-09-14 Marek Safar <marek.safar@gmail.com>
1379 A fix for bug #82845
1381 * class.cs (TypeContainer): Set correct resolve context for all field
1384 2007-09-13 Marek Safar <marek.safar@gmail.com>
1386 * assign.cs: Fixed a crash when field is resolved twice with an error.
1388 * codegen.cs: Changed InFieldInitializer to be flag.
1390 * anonymous.cs, ecore.cs, expression.cs: Update after
1391 IsInFieldInitializer rename.
1393 * const.cs: Removed unused parameter.
1395 * class.cs: Changed the way how we resolve and emit field initializers.
1396 The field initilizers have to have access to contructor block to emit
1397 compiler generated code.
1399 2007-09-13 Marek Safar <marek.safar@gmail.com>
1401 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
1402 generics use TypeContainer instead.
1404 2007-09-12 Marek Safar <marek.safar@gmail.com>
1406 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
1408 * lambda.cs (ResolveParameters): Use more powerful
1409 InflateGenericArgument.
1411 * parameters.cs: Better exception message.
1413 2007-09-10 Marek Safar <marek.safar@gmail.com>
1415 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
1416 correct expression block type.
1418 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
1420 * expression.cs (Invocation): Extracted method group resolve to
1423 2007-09-07 Marek Safar <marek.safar@gmail.com>
1425 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
1426 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
1428 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
1429 generic extension methods.
1431 2007-09-06 Marek Safar <marek.safar@gmail.com>
1433 A fix for bug #82676 (Do I get it right now?)
1434 * convert.cs (Binary.ResolveOperator): An interface is converted to the
1435 object before a standard conversion is applied.
1437 2007-09-06 Marek Safar <marek.safar@gmail.com>
1439 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
1442 2007-09-05 Marek Safar <marek.safar@gmail.com>
1444 A fix for bug #82676
1445 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
1446 non-generic interface types.
1448 2007-09-05 Marek Safar <marek.safar@gmail.com>
1450 A fix for bug #82690
1451 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
1453 2007-09-05 Marek Safar <marek.safar@gmail.com>
1455 A fix for bug #82571
1456 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
1457 modifier for container based methods.
1459 2007-09-05 Marek Safar <marek.safar@gmail.com>
1461 A fix for bug #82676
1462 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
1463 any interface-type T means to any of interface type T.
1465 2007-09-04 Marek Safar <marek.safar@gmail.com>
1467 * namespace.cs: We have 2 versions of System.Core assembly.
1469 2007-09-04 Marek Safar <marek.safar@gmail.com>
1471 A fix for bug #82652
1472 * class.cs (Class.GetClassBases): Compare types and not expressions.
1474 2007-09-04 Marek Safar <marek.safar@gmail.com>
1476 A fix for bug #82620
1477 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
1478 actually never worked before.
1479 (IndexerAccess): Emit prepared arguments before they are modified.
1481 2007-09-04 Marek Safar <marek.safar@gmail.com>
1483 A fix for bug #82563
1484 * assign.cs: Revert wrong fix.
1486 * expression.cs (VariableReference.EmitAssign): Handle ref reference
1488 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
1489 Instead of ldelema/stdind we have to use temporary variables to handle
1490 cases like String.Concat (params string[]).
1492 2007-08-31 Marek Safar <marek.safar@gmail.com>
1494 * class.cs: EmitAttributes to Emit rename.
1496 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
1498 (MemberCore.HasClsCompliantAttribute): Don't depend on
1499 GetClsCompliantAttributeValue execution.
1501 2007-08-31 Marek Safar <marek.safar@gmail.com>
1503 * anonymous.cs: Use shorter type prefix.
1505 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
1508 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
1509 variables when probing is on.
1511 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
1512 unresolved variables.
1513 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
1514 handle transparent identifiers.
1516 2007-08-26 Marek Safar <marek.safar@gmail.com>
1518 * attribute.cs (IsClsCompliant): Add nullable types test.
1520 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
1522 * doc.cs : catch other types of exception than XmlException to
1523 report CS1570. Fixed bug #82565.
1525 2007-08-23 Marek Safar <marek.safar@gmail.com>
1527 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
1528 The number of delegate parameters has to match.
1529 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
1532 2007-08-21 Marek Safar <marek.safar@gmail.com>
1534 * anonymous.cs (AnonymousMethod): Generate private anonymous method
1535 to fix problem with private arguments.
1537 2007-08-20 Marek Safar <marek.safar@gmail.com>
1539 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
1541 * decl.cs (MemberName): Ignore generic type with no generic arguments.
1543 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
1544 empty. Add cloning suport.
1546 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
1548 2007-08-20 Marek Safar <marek.safar@gmail.com>
1550 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
1551 to create EmptyCast. It handles EmptyConstantCast specialization for
1554 2007-08-18 Marek Safar <marek.safar@gmail.com>
1556 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
1557 (EmitArrayArgument): One routine for array arguments.
1558 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
1560 2007-08-17 Marek Safar <marek.safar@gmail.com>
1562 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
1564 2007-08-17 Marek Safar <marek.safar@gmail.com>
1566 * anonymous.cs: MemberLookupFinal update.
1568 * class.cs (ConstructorInitializer): Is expression based.
1570 * delegate.cs: MethodGroupExpr update.
1572 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
1574 (Error_MemberLookupFailed): Customizable error override.
1575 (MethodGroupExpr): Keep queried type for later usage.
1576 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
1579 * expression.cs: Error_MemberLookupFailed refactoring.
1580 (New.DoResolve): Resolve as much as possible.
1581 (ElementInitializer.Error_MemberLookupFailed): Object initializer
1582 customization for invalid member types.
1584 * statement.cs: MethodGroupExpr update.
1586 2007-08-16 Marek Safar <marek.safar@gmail.com>
1588 * modifier.cs (Check): Check all modifiers and not only accessibility
1591 2007-08-16 Marek Safar <marek.safar@gmail.com>
1593 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
1594 type and not an expression.
1596 2007-08-16 Marek Safar <marek.safar@gmail.com>
1598 * statement.cs (Catch.Clone): Type and variable can be null.
1600 2007-08-16 Marek Safar <marek.safar@gmail.com>
1602 A fix for bug #81979
1603 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
1604 I am really not sure whether this is the best fix.
1606 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
1609 2007-08-14 Marek Safar <marek.safar@gmail.com>
1611 ** C# 3.0 Object and collection initializers (major re-write)
1613 * assign.cs (DoResolve): Initializers are not assign related.
1615 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
1616 used during collection or object initialization.
1618 * expression.cs (Error_InvalidArguments): Add initializers specific
1619 messages. More will come later because it requires some general
1621 (New.DoResolve): Better error handling for unsafe types.
1622 (EmptyExpressionStatement): New class.
1623 (ElementInitializer): An object initializer expression.
1624 (CollectionElementInitializer): A collection initializer expression.
1625 (CollectionOrObjectInitializers): A block of object or collection
1627 (NewInitialize): New expression with element/object initializers.
1629 * statement.cs: Reverted object/collection initializer hacks.
1631 * typemanager.cs (CSharpName): Filter __arglist type.
1633 2007-08-09 Marek Safar <marek.safar@gmail.com>
1635 ** C# 3.0 Anonymous Types (update to the latest standard)
1637 * expression.cs (Binary.ResolveOperator): Threat all null based types
1639 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
1640 (AnonymousTypeParameter): Updated.
1642 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
1643 (AnonymousTypeClass): New anonymous type container.
1645 * class.cs (AddField): Return operation result.
1647 * generic.cs: Another empty TypeArguments overload.
1649 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
1650 are stored at top of normal hierarchy.
1652 * typemanager.cs (CSharpName): Filter anonymous types.
1654 2007-08-09 Marek Safar <marek.safar@gmail.com>
1656 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
1657 as single Concat call. How could we miss that :-(
1659 2007-08-08 Marek Safar <marek.safar@gmail.com>
1661 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
1663 2007-08-07 Miguel de Icaza <miguel@novell.com>
1665 * expression.cs: Fix the previous commit, the creation of the
1666 arguments array list needs also to be conditional on the arguments
1669 * class.cs: Add a little bit of help to help narrow down problems.
1671 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
1672 not try to copy in that case.
1674 * driver.cs: When building SMCS, include a new different set of
1675 default assemblies here. Do this here so we can control whether
1676 to include the default assemblies with /noconfig.
1678 2007-08-03 Marek Safar <marek.safar@gmail.com>
1680 A fix for bug #81979
1681 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
1684 2007-08-03 Marek Safar <marek.safar@gmail.com>
1686 A fix for bug #82300
1688 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
1689 we are in probing scope.
1691 2007-08-03 Marek Safar <marek.safar@gmail.com>
1693 A fix for bug #82301
1695 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
1696 (Statement.CloneTo): Clone and not map children blocks.
1698 2007-08-03 Marek Safar <marek.safar@gmail.com>
1700 A fix for bug #82299
1702 * expression.cs (LocalVariableReference.CloneTo): Remap local info
1705 * statement.cs (Statement.CloneTo): Clone variables before statements
1706 to allow remaping of local variables.
1708 2007-08-03 Marek Safar <marek.safar@gmail.com>
1710 A fix for bug #82296
1713 * report.cs: Log crash details for future clone problems.
1715 * statement.cs (Return.Clone): Don't clone non-existent expression.
1717 2007-08-03 Raja R Harinath <harinath@gmail.com>
1719 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
1720 (Class.AddBasesForPart): Move CS0537 check here from ...
1721 * cs-parser.jay (class_declaration): ... here. Move calling of
1722 'AddBasesForPart' to ...
1723 (class_bases): ... here.
1724 (struct_declaration, interface_declaration): Update to changes.
1726 2007-08-02 Marek Safar <marek.safar@gmail.com>
1728 A fix for bug #81923
1730 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
1731 conversion is allowed.
1733 2007-08-02 Marek Safar <marek.safar@gmail.com>
1735 A fix for bug #81564
1737 * ecore.cs (EventExpr): Add IsBase handling.
1739 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
1742 2007-08-02 Raja R Harinath <harinath@gmail.com>
1744 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
1745 * cs-parser.jay: Some whitespace cleanups.
1746 (current_delegate): New.
1748 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
1749 a dummy code block, and use 'type_name' instead of 'member_name'.
1750 (interface_declaration, class_declaration): Likewise.
1751 (delegate_declaration): Likewise. Rearrange slightly and use
1753 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
1754 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
1756 2007-08-02 Marek Safar <marek.safar@gmail.com>
1758 A fix for bug #82039
1760 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
1763 * typemanager.cs (CSharpName): Split to string overload.
1765 2007-08-02 Marek Safar <marek.safar@gmail.com>
1768 * report.cs: Updated warning CS0472.
1770 2007-08-01 Marek Safar <marek.safar@gmail.com>
1772 A fix for bug #82181
1774 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
1776 2007-08-01 Marek Safar <marek.safar@gmail.com>
1778 A fix for bug #82277
1779 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
1781 2007-08-01 Marek Safar <marek.safar@gmail.com>
1783 ** C# 3.0 Type Inference (major bits are working)
1785 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
1786 (.ImplicitStandardConversionExists): Uses compatible.
1787 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
1788 (.InferReturnType): New method.
1789 (.Compatible): Refactored.
1790 (.ResolveParameters): Uses factory to create resolved parameters.
1791 (.CompatibleMethod): Add probing mode support.
1792 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
1793 clearly distinguish between 2 different operations.
1794 (LambdaMethod): Moved to lambda.cs.
1795 (AnonymousMethod): Removed unused fields and methods.
1796 (AnonymousDelegate): Simplified.
1798 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
1800 * convert. cs (ImplicitConversionStandard): Compatible works differently.
1802 * delegate.cs (Delegate): New mehods to reduce code duplication.
1803 (.GetConstructor): New method.
1804 (.GetInvokeMethod): New method.
1805 (DelegateCreation): Updated.
1807 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
1809 (OverloadResolve): Made probing little bit faster.
1811 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
1814 * generic.cs (TypeInferenceContext): Dummy implementation.
1816 * iterators.cs: Updated after Resolve/Define rename.
1818 * lambda.cs (LambdaExpression)
1819 (.ResolveParameters): Handles both type of arguments and type inference too.
1821 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
1822 (InflateTypes): Updated.
1824 * support.cs (InflateTypes): Changed signature and updated.
1826 * typemanager.cs (LookupMemberCache): Better dynamic type check.
1827 (MemberLookup_FindMembers): More MS tricks.
1828 (GetParameterData): Ditto.
1829 (GetDelegateParameters): Uses quick path for dynamic types.
1831 2007-08-01 Marek Safar <marek.safar@gmail.com>
1833 * class.cs (MethodData.Define): EmitContext is required for generic stuff
1836 2007-07-31 Marek Safar <marek.safar@gmail.com>
1838 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
1841 2007-07-26 Jb Evain <jbevain@novell.com>
1843 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
1844 which takes a boolean 'report_errors', similar to the GetMethod.
1845 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
1846 in .net 2.1, do not report errors here.
1848 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
1849 System.Runtime.CompilerServices.RequiredAttributeAttribute and
1850 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
1853 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
1854 of the type InternalsVisibleToAttribute before the first call
1855 to CoreLookupType which is allowed to fail (third boolean parameter
1856 to true). Because, during the resolution for a type that is not
1857 immediately found, we try to check if the type is not defined in
1858 a friend assembly, and to do so, we need the
1859 InternalVisibleToAttribute.
1861 2007-07-23 Miguel de Icaza <miguel@novell.com>
1863 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
1864 feature that allows structs to be compared against null and inline
1865 the result as true or false.
1867 Notice that the same code is not permitted inside a generic block
1868 of code that would do:
1870 class Foo<T> where T : struct {
1877 It is only allowed if the type of T is not bound (no where
1878 clause). In my opinion, this CSC 2 behavior is broken but people
1879 seem to be using it (IronRuby does, a few bug reports on bugzilla
1880 have it and some people have complained about it).
1882 All of the users that depend on this behavior have code that is
1885 * report.cs (Warning, Error): make these take object arguments,
1886 not strings, as that allows us to take advantage of Format.
1888 2007-07-20 William Holmes <billholmes54@gmail.com>
1890 * decl.cs: Changed MemberName.CountTypeArguments to also check the
1891 Left member variable for the Count.
1892 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
1893 MemberName.CountTypeArguments to avoid a NRE.
1895 This code is contributed under the MIT X11 license
1897 2007-07-18 Marek Safar <marek.safar@gmail.com>
1899 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
1901 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1903 * doc.cs : generic method arguments are written as ``x while generic
1904 type arguments are `x. Combined with the previous change, fixed bug
1907 2007-07-18 Raja R Harinath <rharinath@novell.com>
1910 * expression.cs (Binary.ResolveOperator): When converting
1911 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
1913 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1915 * doc.cs : when T: or whatever x: is specified, it does not really
1916 check the doc comment's syntax correctness. Fixed bug #82006.
1918 2007-07-18 Marek Safar <marek.safar@gmail.com>
1920 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
1921 LambdaExpression better.
1923 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
1925 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
1927 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
1928 as it can be generated.
1930 * expression.cs (Invocation.Error_InvalidArguments): Show correct
1933 * lambda.cs (LambdaExpression): Refactored to share same code with
1934 AnonymousMethodExpression.
1936 2007-07-17 Marek Safar <marek.safar@gmail.com>
1938 * anonymous.cs (MakeName): Include host name for easier debugging.
1939 (LambdaMethod): New class for lambda spcecific stuff.
1941 * attribute.cs: Set EmitContext return type.
1943 * class.cs: Set EmitContext return type.
1945 * codegen.cs (EmitContext): Return type cannot be null to stop messing
1946 with null/void meaning.
1948 * iterators.cs (ContainerType): Implemented.
1950 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
1952 * statement.cs (Return): Updated to lambda expressions.
1953 (Block.CloneTo): Parent can be null.
1955 2007-07-13 Marek Safar <marek.safar@gmail.com>
1957 A fix for bug #81917
1958 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
1960 * class.cs (FixedField): Check whether field is in unsafe scope.
1962 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
1963 (FieldExpr.Emit): Fixed buffers cannot be volatile.
1965 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
1968 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
1970 2007-07-13 Marek Safar <marek.safar@gmail.com>
1972 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
1973 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
1976 2007-07-13 Marek Safar <marek.safar@gmail.com>
1978 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
1980 2007-07-13 Marek Safar <marek.safar@gmail.com>
1982 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
1983 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
1985 * codegen.cs(EmitContext): Add ProbingMode flag.
1987 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
1989 * driver.cs: For now set both warning values.
1991 * ecore.cs (SimpleName): Name is readonly.
1992 (MethodGroup.OverloadResolve): One quick path for probing.
1994 * expression.cs (Unary): Set Oper r/o.
1995 (Binary): Set Oper r/o.
1996 (ParameterReference): Set few instance variables as r/o.
1997 (ParameterReference.DoResolveBase): Don't capture aruments when
1999 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
2000 (Arglist): arguments are private.
2001 (SizeOf): type is private and r/o.
2002 (MemberAccess): arguments are private.
2004 * report.cs: Enhanced reporting on/off capabilities.
2006 * lambda.cs: Uses ec.IsInProbingMode.
2007 (ContextualReturn): Derives from return.
2009 * rootcontext.cs: For now set both warning values.
2011 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
2013 (Return.Resolve): Don't die immediately.
2014 (Block.Resolve): Speed-up probing.
2015 (Block.CloneTo): Clone only child blocks.
2017 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
2019 * iterators.cs: reverted Miguel's latest change (r81925) as it
2020 breaks the build in System.
2022 2007-07-13 Miguel de Icaza <miguel@novell.com>
2024 * iterators.cs (Yield.CheckContext): Check for the iterator type
2025 also here as we can call into Yield even in codepaths that are not
2027 (MethodOrOperator is the only path that was checked).
2029 In addition to the standard check, use a more specific check for
2030 constructors to report a more verbose error.
2032 2007-07-12 Miguel de Icaza <miguel@novell.com>
2034 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
2035 report the warning and continue
2037 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
2038 values on the stack on the call to Emit. Use EmitStatement if
2039 possible, or using Emit + Pop if not possible. Fixes #82064
2041 2007-07-12 Raja R Harinath <rharinath@novell.com>
2043 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
2044 avoid try...finally in some cases.
2046 2007-07-10 Marek Safar <marek.safar@gmail.com>
2048 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
2050 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
2051 instead of method. Re-use standard error handling.
2052 (ConstructorInitializer.Emit): Simplified.
2054 * delegate.cs: Updated after Invocation.EmitCall change.
2056 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
2057 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
2058 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
2059 method and don't permanently changing input arguments.
2060 (MethodGroupExpr): Introduced resolved best_candidate, when method group
2061 is resolved it has one of the candidates is the best one which is later
2062 used to emit. Removed a few unused method.
2063 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
2065 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
2066 (Binary.ResolveOperator): Ditto.
2067 (ConditionalLogicalOperator.DoResolve): Ditto.
2068 (Invocation): Uses method group.
2069 (Invocation.DoResolve): Simplified.
2070 (Invocation.EmitCall): Removed useless is_static.
2071 (Invocation.Emit): Delegate to method group.
2072 (Invocation.EmitStatement): Simplified.
2073 (New): Uses method group.
2074 (MemberAccess.DoResolve): Don't destroy original expression.
2076 * statement.cs (ForEach.Resolve): Use null for no method arguments.
2078 2007-07-04 Marek Safar <marek.safar@gmail.com>
2080 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
2083 * lambda.cs: Add custom error message type.
2085 2007-07-03 Marek Safar <marek.safar@gmail.com>
2087 * lambda.cs: Simplified little bit.
2089 * parameter.cs: Introduced ImplicitLambdaParameter.
2090 (Parameters.CreateFullyResolved): New factory instead of ctor.
2094 * delegate.cs: Updated parameter creation.
2096 2007-07-03 Marek Safar <marek.safar@gmail.com>
2098 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
2101 * generic.cs: Synchronized with gmcs.
2103 2007-07-03 Marek Safar <marek.safar@gmail.com>
2105 * class.cs (Indexer): Check return type as soon as possible.
2107 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
2110 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
2112 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
2114 * parameter.cs (Parameter): Use expression type when it is available.
2116 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
2117 method modifier for the first parameter only.
2119 2007-06-24 Marek Safar <marek.safar@gmail.com>
2121 A fix for bug #81938
2122 * typemanager.cs (ChangeType): Fixed couple of char conversions.
2124 * constant.cs: Tide up an exception message.
2126 2007-06-22 Marek Safar <marek.safar@gmail.com>
2128 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
2129 an uninitialized variable is used.
2131 * expression.cs (LocalVariableReference.DoResolve): Ditto.
2133 2007-06-22 Marek Safar <marek.safar@gmail.com>
2135 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
2136 not found error handling.
2138 * expression.cs (ArrayCreation): Removed redundant fields and little bit
2140 (ArrayCreation.ResolveArrayElement): To be ready to customization.
2141 (ArrayCreation.DoResolve): Simplified.
2142 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
2143 its own resolve process.
2144 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
2146 2007-06-20 Marek Safar <marek.safar@gmail.com>
2148 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
2151 2007-06-20 Marek Safar <marek.safar@gmail.com>
2153 * cs-tokenizer.cs: Removed var related stuff.
2155 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
2156 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
2157 a type and a keyword at same time.
2159 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
2162 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
2163 implicitly typed arrays, more changes will follow.
2165 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
2167 2007-06-19 Marek Safar <marek.safar@gmail.com>
2169 * ecore.cs (VarExpr): Removed Handled field.
2171 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
2172 build-in assign functionality.
2173 (ForEach.Resolve): Removed all implicitly typed local variable code and
2175 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
2176 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
2178 2007-06-18 Marek Safar <marek.safar@gmail.com>
2180 * assign.cs: Removed implicitly typed local variable check.
2182 * expression.cs (LocalVariableReference.DoResolve): Add check for self
2183 referencing implicitly typed local variable.
2184 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
2187 * statement.cs (Fixed): Removed unsupported implicitly typed local
2190 2007-06-15 Marek Safar <marek.safar@gmail.com>
2192 * decl.cs (MemberName): Moved all Unbound stuff to parser.
2194 2007-06-14 Marek Safar <marek.safar@gmail.com>
2196 A fix for bugs #81855 and #76274
2197 * attribute.cs (AttachTo): Always set owner for global attributes to
2200 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
2203 * cs-parser.jay: Assembly and module attributes must precede all other
2204 elements except using clauses and extern alias declarations.
2206 2007-06-13 Marek Safar <marek.safar@gmail.com>
2208 A fix for bug #81748
2210 * expression.cs: More checks for non ISO-1 features.
2212 2007-06-12 Marek Safar <marek.safar@gmail.com>
2214 A fix for bug #81807
2215 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
2216 present inside switch statement and it is required by nullable check.
2218 2007-06-12 Marek Safar <marek.safar@gmail.com>
2220 A fix for bug #81840
2221 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
2222 when type matching fails.
2224 * namespace.cs: Tiny error message change.
2226 2007-06-12 Marek Safar <marek.safar@gmail.com>
2228 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
2229 reporting. Added automatic property check.
2231 * class.cs: Updated after CheckAbstractAndExtern relocation.
2232 (AEventPropertyAccessor.GetSignatureForError): Customized.
2234 2007-06-11 Marek Safar <marek.safar@gmail.com>
2236 * class.cs (DefineBaseTypes): Base type can be undefined.
2238 * ecore.cs (TypeLookup): Minor refactoring.
2239 (DoResolveAsTypeStep): Removed redundant check.
2241 * namespace.cs (Lookup): Removed redundant check.
2243 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
2244 ResolveAsTypeTerminal step.
2245 (BootstrapCorlib_*): Simplified.
2246 (PopulateCoreType): Core types can be now external.
2248 2007-06-07 Marek Safar <marek.safar@gmail.com>
2250 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
2252 (InferTypeArguments): Infers anonymous expression type arguments.
2253 (Compatible): Split to Compatible and InferTypeArguments.
2255 * lambda.cs: Updated.
2257 2007-06-08 Marek Safar <marek.safar@gmail.com>
2259 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
2261 2007-06-07 Raja R Harinath <harinath@gmail.com>
2263 Fix #80477, cs0135-2.cs, cs0135-3.cs
2264 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
2265 names to the "known" variables list.
2266 (Block.CheckInvariantMeaningInBlock): Handle the fact the
2267 parameter names are also "known".
2268 (Block.CheckError136): Remove.
2269 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
2272 2007-06-07 Marek Safar <marek.safar@gmail.com>
2274 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
2276 2007-06-06 Marek Safar <marek.safar@gmail.com>
2278 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
2279 internal error not an user error.
2281 * expression.cs (IsApplicable): Refactored to make debugging easier.
2283 * support.cs: More tricks for non-mono runtimes.
2285 * typemanager.cs (CoreLookupType): Made public.
2286 (InitSystemCore): All linq specific stuff moved to linq.cs
2288 2007-06-05 Marek Safar <marek.safar@gmail.com>
2290 * typemanager.cs (CSharpSignature): One more missing build-in types
2292 More tricks for non-mono runtime.
2294 2007-06-05 Raja R Harinath <harinath@gmail.com>
2296 * statement.cs (Block.CheckError136_InParents): Remove.
2297 (Block.AddVariable): Use GetParameterInfo instead.
2298 (ToplevelBlock.ProcessArguments): Likewise.
2300 2007-06-04 Raja R Harinath <rharinath@novell.com>
2302 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
2304 (ToplevelBlock.GetParameterInfo): Split out of ...
2305 (ToplevelBlock.GetParameterRefernce): ... this.
2306 (ToplevelBlock.ParameterMap): Remove.
2307 * expression.cs (ParameterReference): Update to use
2308 ToplevelParameterInfo.
2310 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
2313 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
2314 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
2316 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
2317 (ToplevelBlock.ProcessParameters) ... here.
2318 (ToplevelBlock..ctor): Invoke it.
2320 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
2323 * statement.cs (IKnownVariable): New interface.
2324 (LocalInfo): Implement it.
2325 (ToplevelParameterInfo): New class.
2326 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
2327 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
2328 GetKnownVariableInfo.
2330 2007-06-03 Raja R Harinath <harinath@gmail.com>
2332 Partly speed up CS0136 error checks.
2333 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
2334 'recurse' parameter.
2335 (Block.DoCheckError136): Only check errors in parameters. Move
2336 local variable checks ...
2337 (Block.AddVariable): ... here, and ...
2338 (ToplevelBlock.ResolveMeta): ... here.
2340 2007-06-02 Raja R Harinath <harinath@gmail.com>
2342 * statement.cs (Block.IsChildOf): Remove.
2344 * statement.cs (Statement.Clone): Move special case code ...
2345 (Block.CloneTo): ... here.
2347 2007-05-29 Raja R Harinath <rharinath@novell.com>
2349 * statement.cs (ToplevelBlock.container): Remove field. It's
2350 redundant with 'Parent'.
2351 (ToplevelBlock.ContainerBlock): Remove accessor.
2352 (ToplevelBlock..ctor): Update to changes. Register anonymous
2353 child with parent here, ...
2354 * cs-parser.jay (end_anonymous): ... not here. Don't modify
2356 (start_anonymous): Don't save current_block.
2357 (top_current_block): Remove.
2359 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
2360 (Block.Resolve): Update to changes.
2361 (Block..ctor): Move setting of "correct" 'Toplevel'
2362 and 'Explicit' fields to ...
2363 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
2365 2007-05-27 Raja R Harinath <harinath@gmail.com>
2368 * statement.cs (Block.Implicit): Remove.
2369 (Block): Update to changes.
2370 * flowanalysis.cs: Likewise.
2372 Mildly speed up CheckInvariantMeaningInBlock
2373 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
2374 Recursively call AddKnownVariable to all enclosing blocks.
2375 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
2376 Remove recursive calls.
2377 (Block): Update to changes.
2379 New ExplicitBlock invariants
2380 * statement.cs (Block.Explicit): New field. It points to the
2381 immediately enclosing non-implicit block.
2382 (Block..ctor): Maintain the invariant.
2383 * cs-parser.jay: Take advantage of invariant.
2385 Introduce ExplicitBlock
2386 * statement.cs (ExplicitBlock): New.
2387 (ToplevelBlock): Derive from it.
2388 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
2390 (Block.Implicit): Update to changes.
2391 * cs-parser.jay: Update to changes.
2394 * codegen.cs (EmitContext.IsLastStatement): Remove.
2395 * statement.cs (Block.DoEmit): Update to changes.
2397 2007-05-25 Raja R Harinath <rharinath@novell.com>
2399 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
2400 modifying current_block directly.
2402 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
2404 * class.cs: Implemented automatic properties (C# 3.0)
2405 Thanks to Marek for the help.
2407 2007-05-23 Raja R Harinath <rharinath@novell.com>
2409 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
2410 variable as assigned, note also that all its components are
2412 (MyBitVector.SetRange): New. Function to set multiple bits to true.
2414 2007-05-19 Marek Safar <marek.safar@gmail.com>
2416 * anonymous.cs, class.cs: Emit Compiler generated attribute when
2417 member is marked as compiler generated.
2419 * decl.cs (MemberCore): Refactored ModFlags into property.
2421 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
2422 (Check): Check only accessibility modifiers.
2424 2007-05-18 Raja R Harinath <rharinath@novell.com>
2426 Track all assignable slots in one bit array
2427 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
2428 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
2429 logic from VariableMap constructor here. Use the same 'offset'
2430 variable that's later used for computing offsets of local
2432 * flowanalysis.cs (UsageVector.parameters): Remove.
2433 (UsageVector): Update to changes.
2434 (VariableMap): Remove.
2436 Avoid creating ParameterMap in every block
2437 * statement.cs (Block.ParameterMap): Move ...
2438 (ToplevelBlock.ParameterMap): ... here.
2439 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
2441 * flowanalysis.cs (FlowBranching.param_map): Remove.
2442 (FlowBranching.UsageVector): Update to changes.
2443 (FlowBranchingToplevel.CheckOutParameters): Likewise.
2445 * statement.cs (Block.CloneTo): Clone Toplevel field too.
2447 * expression.cs (ParameterReference): Distinguish between block
2448 where parameter was referenced and declared.
2450 2007-05-18 Marek Safar <marek.safar@gmail.com>
2452 * flowanalysis.cs, statement.cs: Put back improved error handling.
2454 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
2458 Imporved object and collection initialization (C# 3.0).
2460 2007-05-15 Marek Safar <marek.safar@gmail.com>
2462 A fix for bug #81380
2463 * expression.cs (Is.DoResolve): Only value types have constant `is'
2466 2007-05-15 Raja R Harinath <rharinath@novell.com>
2468 * statement.cs (ToplevelBlock.child): Remove.
2470 2007-05-15 Raja R Harinath <harinath@gmail.com>
2472 Rationalize ResolveMeta: refactoring
2473 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
2474 out constant handling code into ...
2475 (Block.DoResolveConstants): ... this.
2477 Rationalize ResolveMeta: kill local_map
2478 * statement.cs (Block.local_map, Block.LocalMap): Remove.
2479 (Block.AssignableSlots): New.
2480 (Block.ResolveMeta): Make protected. Don't create a VariableMap
2481 for locals -- move code from VariableMap here. Avoid unnecessary
2483 * flowanalysis.cs (FlowBranching.local_map): Remove.
2484 (FlowBranching..ctor): Use Block.AssignableSlots.
2485 (VariableMap): Remove unused constructors.
2487 2007-05-11 Raja R Harinath <rharinath@novell.com>
2489 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
2491 2007-05-11 Marek Safar <marek.safar@gmail.com>
2493 * typemanager.cs (IsFriendAssembly): Should not be called for building
2496 2007-05-09 Marek Safar <marek.safar@gmail.com>
2498 * literal.cs (NullConstant): Print null in all cases.
2500 * expression.cs (Binary.ResolveOperator): Implemented delegate
2501 comparison based on C# 2.0 changes.
2503 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
2505 This code is contributed under the MIT X11 license
2507 The following enables support for several C# 3.0 language features:
2509 * cs-tokenizer.cs: Added support for the "var" keyword.
2511 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
2512 Added VarExpr class to facilitate type inferencing.
2514 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
2515 to support anonymous types.
2517 * assign.cs: Added support for type inferencing and initialization.
2519 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
2521 * expression.cs: Added implicit array support to ArrayCreation.
2522 Added 5 types and 1 interface:
2524 IInitializable Implementing classes can inject initializing
2525 statements after object instantiation.
2527 Initializer Stores data for object initialization.
2529 AnonymousType An expression for anonymous types.
2531 AnonymousTypeParameter Stores data about an anonymous type's field.
2533 NewInitialize An expression for object initialization.
2535 CollectionInitialize An expression for collection initialization.
2537 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
2540 2007-05-06 Marek Safar <marek.safar@gmail.com>
2542 A fix for bug #81500
2543 * cs-tokenizer.cs: Add special handling for coalescing operator.
2545 2007-05-06 Marek Safar <marek.safar@gmail.com>
2547 A fix for bug #81529
2548 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
2549 its value from base class until it is redefined.
2551 2007-05-02 Raja R Harinath <rharinath@novell.com>
2553 Fix regression in cs0631-3.cs
2554 * cs-parser.jay (operator_declarator): Add opt_attributes to error
2555 fallback. Make error fallback catch more cases.
2557 2007-05-01 Miguel de Icaza <miguel@novell.com>
2559 * cs-parser.jay: Allow parameters in operator declarations to have
2562 2007-04-27 Miguel de Icaza <miguel@novell.com>
2564 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
2567 * lambda.cs (ContextualReturn.Resolve): An expression is valid
2568 inside the ContextualReturn, it does not have to be an
2569 ExpressionStatement.
2571 2007-04-24 Miguel de Icaza <miguel@novell.com>
2573 * lambda.cs (ContextualReturn.Resolve): if the return type is not
2576 2007-04-23 Miguel de Icaza <miguel@novell.com>
2578 * anonymous.cs (AnonymousContainer): split the virtual Resolve
2579 method in two methods: ResolveNoDefine and Resolve.
2581 ResolveNoDefine will stop just after ResolveTopBlock has been
2584 Resolve will then continue by creating a method and issuing the
2585 call to method.Define ().
2587 (AnonymousMethod): Split and implement the new Resolve and
2588 ResolveNoDefine as well.
2590 * lambda.cs (LambdaExpression): Split the anonymous method
2591 resolution code into a separate routine (CoreCompatibilityTest)
2592 from DoCompatibleTest.
2594 (LambdaExpression.TryBuild): New method, this method tries to
2595 build the LambdaExpression with the given set of types to be used
2596 as the types for the various parameters of the lambda expression.
2598 If the compilation succeed with the given types, the infered type
2599 of the Anonymous method is returned, otherwise null is returned.
2601 2007-04-23 Marek Safar <marek.safar@gmail.com>
2603 A fix for bug #81414
2604 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
2606 2007-04-22 Miguel de Icaza <miguel@novell.com>
2608 * cs-tokenizer.cs: Change various identifiers here from the
2609 camelCasing to the recommended Linux-like style for instance
2610 variables from the Coding Guidelines.
2612 2007-04-19 Martin Baulig <martin@ximian.com>
2615 (Convert.ImplicitReferenceConversionCore): Allow conversions from
2616 System.Enum to System.ValueType.
2618 2007-04-13 Martin Baulig <martin@ximian.com>
2620 Rewrote implicit reference conversions. We need to distinguish
2621 between implicit reference conversions (13.1.4) and implicit
2622 boxing conversions (13.1.5).
2624 According to the spec, there's an an implicit conversion
2625 "From a one-dimensional array-type S[] to IList<T> and base
2626 interfaces of this interface, provided there is an implicit
2627 reference conversion from S to T." Note that this does not
2628 include boxing conversions.
2631 (Convert.ImplicitTypeParameterBoxingConversion): New method.
2632 (Convert.ImplicitReferenceConversion): Split into
2633 ImplicitReferenceConversionCore() and
2634 ImplicitBoxingConversionExist().
2635 (Convert.ImplicitReferenceConversionExists): Use the new
2636 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
2638 2007-04-12 Martin Baulig <martin@ximian.com>
2640 * convert.cs (Convert.ImplicitReferenceConversion): Move the
2641 `TypeManager.null_type' checks up to the top of the method.
2643 2007-04-11 Marek Safar <marek.safar@gmail.com>
2645 A fix for bug #81350
2646 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
2649 2007-04-11 Martin Baulig <martin@ximian.com>
2651 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
2652 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
2653 to make this work for generic classes; fixes #79561.
2655 2007-04-11 Martin Baulig <martin@ximian.com>
2657 * expression.cs (As): Add support for nullable types; fixes #79371.
2659 2007-04-11 Martin Baulig <martin@ximian.com>
2661 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
2662 `type.FullName' is null; fixes #80243.
2664 2007-04-11 Martin Baulig <martin@ximian.com>
2666 * expression.cs (Invocation.IsApplicable): Don't modify the method
2667 if type inference succeeded, but the method was not applicable.
2670 2007-04-10 Marek Safar <marek.safar@gmail.com>
2672 A fix for bug #81324
2673 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
2674 internal and external namespaces containers.
2676 2007-04-10 Martin Baulig <martin@ximian.com>
2678 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
2679 TypeManager.DropGenericMethodArguments() so we also call
2680 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
2682 2007-04-10 Martin Baulig <martin@ximian.com>
2684 * iterators.cs (Iterator.CreateIterator): Don't crash if
2685 `method.ReturnType' is null. This happens if something went wrong
2686 while resolving that typ (we already reported an error in this case).
2688 2007-04-10 Martin Baulig <martin@ximian.com>
2690 * expression.cs (New.DoResolve): Don't call CheckComImport() on
2691 generic interfaces; report the CS0144 directly.
2693 2007-04-10 Martin Baulig <martin@ximian.com>
2695 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
2696 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
2698 2007-04-10 Martin Baulig <martin@ximian.com>
2700 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
2702 2007-04-09 Raja R Harinath <rharinath@novell.com>
2705 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
2706 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
2709 * statement.cs (For.Resolve): If resolution fails, use
2712 2007-04-08 Marek Safar <marek.safar@gmail.com>
2714 * anonymous.cs (MakeName): Make faster and zero-based.
2715 (VerifyExplicitParameterCompatibility): Back to mode where generic
2716 parameter is ignored.
2717 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
2719 * class.cs (EmitType): Method can emit another new method.
2721 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
2723 * driver.cs: Updated.
2725 * lambda.cs: Reuse predefined empty parameters.
2727 * parameter.cs: Updated
2729 * support.cs: Implemented InflateTypes.
2731 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
2732 (InitSystemCore): Introduced to isolate 3.0 dependencies.
2734 2007-04-03 Martin Baulig <martin@ximian.com>
2738 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
2739 version of TypeManager.IsOverride() which also works with generic
2742 2007-04-03 Martin Baulig <martin@ximian.com>
2747 (Convert.ExplicitReferenceConversion): We need to cast when
2748 converting from IList<T> to S[].
2750 2007-04-01 Marek Safar <marek.safar@gmail.com>
2752 * decl.cs (FindExtensionMethods): Consider all candidates with same name
2755 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
2757 2007-03-31 Marek Safar <marek.safar@gmail.com>
2759 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
2760 argument and return type inferring.
2762 * codegen.cs (InferReturnType): Flag whether return can be inferred.
2763 (ReturnType): Turned to property.
2765 * statement.cs (Return): Implemented return type inferring.
2767 * support.cs (ReflectionParameters): Use local types if possible.
2769 2007-03-30 Raja R Harinath <rharinath@novell.com>
2771 * flowanalysis.cs (FlowBranching.Reachability): Remove.
2772 (FlowBranching.UsageVector): Update to changes.
2774 Prepare to kill 'Reachability'
2775 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
2776 argument of constructor.
2778 2007-03-29 Raja R Harinath <rharinath@novell.com>
2780 Prepare to kill 'Reachability'
2781 * flowanalysis.cs (UsageVector.is_unreachable): New.
2782 (UsageVector): Update to maintain 'is_unreachable' in parallel to
2783 'reachability', and verify they're consistent.
2786 * expression.cs (New.EmitStatement): Handle type parameters here too.
2788 2007-03-29 Martin Baulig <martin@ximian.com>
2793 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
2794 CompilerGeneratedClass.
2795 (ScopeInfo.EmitScopeInstance): Make this protected.
2796 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
2797 `ec.CurrentAnonymousMethod.Scope == Scope'.
2799 * statement.cs (Block.ScopeInfo): Make this a property.
2801 2007-03-27 Raja R Harinath <harinath@gmail.com>
2803 Prepare to kill 'Reachability'
2804 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
2805 (FlowBranching.UsageVector.Reachability): Remove property.
2806 (FlowBranching.UsageVector.IsUnreachable): New property.
2807 (FlowBranching.UsageVector.ResetBarrier): New.
2808 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
2809 * codegen.cs, statement.cs: Update to changes.
2811 2007-03-27 Martin Baulig <martin@ximian.com>
2816 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
2819 2007-03-26 Raja R Harinath <rharinath@novell.com>
2821 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
2822 instead of TriState. Remove all mention of TriState.
2824 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
2825 replaced by a boolean. Add boolean 'is_unreachable' field, check
2826 and maintain invariants.
2828 2007-03-25 Marek Safar <marek.safar@gmail.com>
2830 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
2832 2007-03-25 Marek Safar <marek.safar@gmail.com>
2834 * expression.cs: Stop using obsolete 2.0 opcodes.
2836 2007-03-25 Marek Safar <marek.safar@gmail.com>
2838 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
2839 one of the latests Martin's fixes.
2841 2007-03-23 Miguel de Icaza <miguel@novell.com>
2843 * expression.cs: On BigEndian systems, swap the bytes, temporary
2844 solution until we get a new bitconverter class.
2846 2007-03-23 Martin Baulig <martin@ximian.com>
2850 * decl.cs (MemberCache.AddMembers): Add generic methods both as
2851 "Method" and "Method`1". Normally, a cache lookup is done on the
2852 "Method" form (ie. without the generic arity), but this one makes
2853 lookups on the full form work as well.
2855 2007-03-22 Raja R Harinath <rharinath@novell.com>
2857 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
2860 2007-03-20 Bill Holmes <billholmes54@gmail.com>
2862 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
2863 ordered_member_list, to TypeBuilder to store members to be defined
2864 in the order they were parsed in.
2865 - ordered_explicit_member_list contains all properties indexers
2866 and methods that are defined as explicit implementation of an
2867 interface or base class.
2868 - ordered_member_list contains all properties indexers and methods
2869 that are not defined as explicit implementation of an interface
2872 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
2873 functionality in these removed classes has been replaced with
2874 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
2875 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
2877 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
2878 to CheckForDuplications inside GetMethod and SetMethod Define Method
2879 to handle method property and indexer name conflicts.
2883 All code is contributed under the MIT/X11 license.
2885 2007-03-20 Martin Baulig <martin@ximian.com>
2887 * class.cs (TypeContainer.Interfaces): Removed; they're now
2888 included in `TypeContainer.Types'.
2890 2007-03-20 Martin Baulig <martin@ximian.com>
2892 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
2894 * class.cs (TypeContainer.CreateType): New public method. This is
2895 now called before DefineType() to create the TypeBuilders.
2896 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
2897 has already been created by CreateType().
2898 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
2899 don't resolve our base classes here; this has been moved into
2900 DefineBaseTypes(). We're now called from CreateType().
2901 (TypeContainer.DefineBaseTypes): New private method; resolve our
2902 base classes here. We're now called from DefineType().
2905 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
2906 our types first to create all the TypeBuilders. After that, call
2907 TypeContainer.DefineType() on all the types which'll resolve their
2908 base classes and setup the resolve order.
2910 2007-03-20 Martin Baulig <martin@ximian.com>
2912 * class.cs (TypeContainer.Enums): Removed; they're now included in
2913 `TypeContainer.Types'.
2915 2007-03-20 Martin Baulig <martin@ximian.com>
2918 (TypeContainer.DefineType): Don't call ResolveMembers() here.
2919 (TypeContainer.DoResolveMembers): Call DefineType() on our
2920 `compiler_generated' classes; moved here from DefineNestedTypes().
2923 (RootContext.ResolveTree): Call ResolveMembers() on all
2924 TypeContainer's in the `type_container_resolve_order'.
2926 2007-03-19 Marek Safar <marek.safar@gmail.com>
2928 * class.cs: Use corlib to handle InternalMethodImplAttribute.
2930 2007-03-17 Marek Safar <marek.safar@gmail.com>
2932 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
2933 implementation flags.
2935 2007-03-17 Marek Safar <marek.safar@gmail.com>
2937 * class.cs: More optimizations for type parameters.
2939 2007-03-15 Marek Safar <marek.safar@gmail.com>
2941 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
2943 * ecore.cs, parameter.cs: More common code for both corlibs.
2945 * typemanager.cs (IsGenericMethod): Simplified.
2947 2007-03-15 Raja R Harinath <rharinath@novell.com>
2949 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2951 * statement.cs, iterators.cs, lambda.cs: Update to changes.
2953 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
2954 unconditionally. Simplify explanation.
2955 (Try.Resolve, Using.Resolve): Likewise.
2957 2007-03-15 Martin Baulig <martin@ximian.com>
2961 * decl.cs (DeclSpace): If we're a partial class, use our
2962 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
2964 2007-03-15 Raja R Harinath <rharinath@novell.com>
2966 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2968 (FlowBranching.UsageVector): Update to changes.
2969 (FlowBranching.MergeSiblings): Likewise.
2970 * statement.cs: Likewise.
2972 2007-03-15 Martin Baulig <martin@ximian.com>
2977 (MemberCache): Added a special .ctor for type parameters.
2980 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
2983 2007-03-09 Martin Baulig <martin@ximian.com>
2985 * enum.cs (Enum): Make this a TypeContainer.
2986 (EnumMember): Derive from `Const'.
2989 (Const.DoResolveValue): New protected virtual method; move most of
2990 the functionality of ResolveValue() here so we can override it in
2992 (Const.CreateConstantReference): Make this virtual.
2994 * class.cs (Kind): Add `Kind.Enum'.
2995 (TypeContainer.Emit): Don't emit the enums here; they're already
2996 in the `RootContext.typecontainer_resolve_order'.
2998 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
2999 here; they're already in the `typecontainer_resolve_order'.
3001 * ecore.cs (EnumConstant.ConvertImplicitly): Add
3002 TypeManager.DropGenericTypeArguments().
3005 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
3006 (TypeManager.IsEnumType): Likewise.
3007 (TypeManager.EnumToUnderlying): Likewise.
3008 (TypeManager.IsEqual): Add support for enums.
3010 2007-03-12 Raja R Harinath <rharinath@novell.com>
3012 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
3013 DefaultParameterValueAttribute to be undefined, say if System.dll
3016 2007-03-11 Marek Safar <marek.safar@gmail.com>
3018 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
3021 2007-03-10 Marek Safar <marek.safar@gmail.com>
3023 * class.cs, parameter.cs: Unified parameters verification.
3025 2007-03-08 Martin Baulig <martin@ximian.com>
3027 * cs-parser.jay (constructor_header): Pass the location to the
3028 newly created TopLevelBlock.
3030 2007-03-07 Martin Baulig <martin@ximian.com>
3032 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
3034 2007-03-06 Miguel de Icaza <miguel@novell.com>
3036 * convert.cs (ExplicitReferenceConversionExists): Sync this method
3037 with the changes from David, fixes the build.
3039 2007-03-05 David Mitchell <dmitchell@logos.com>
3041 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
3042 and its base interfaces to a one-dimensional array type S[],
3043 provided there is an implicit or explicit reference conversion
3046 2007-03-03 Marek Safar <marek.safar@gmail.com>
3048 * cs-tokenizer.cs: Implemented basic linq grammar.
3050 * driver.cs: Set linq lang version on demand.
3052 2007-02-26 Marek Safar <marek.safar@gmail.com>
3054 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
3056 2007-02-25 Marek Safar <marek.safar@gmail.com>
3058 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
3061 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
3063 Check property and event extern attributes.
3065 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
3068 2007-02-24 Marek Safar <marek.safar@gmail.com>
3070 A fix for bug #80407
3071 * ecore.cs: Don't report ambiguity error when methods have same parent.
3073 2007-02-23 Marek Safar <marek.safar@gmail.com>
3075 A fix for bug #80878
3076 * class.cs, cs-parser.jay: Event property can host anonymous methods.
3078 2007-02-22 Marek Safar <marek.safar@gmail.com>
3080 * attribute.cs: Enable ExtensionAttribute presence test.
3082 2007-02-22 Marek Safar <marek.safar@gmail.com>
3084 * class.cs: Warn about missing GetHashCode only when Equals is override.
3086 * decl.cs: Check accessibility of type arguments.
3088 * typemanager.cs: Correctly report nullable array.
3090 2007-02-20 Marek Safar <marek.safar@gmail.com>
3092 * class.cs, report.cs: Capture more details when things go wrong.
3094 2007-02-20 Marek Safar <marek.safar@gmail.com>
3096 A fix for bug #80650
3097 * cs-parser.jay: Anonymous container starts at constructor declaration
3098 and not at block beginning because it has to be usable in constructor
3101 * statement.cs: Use context location and not block one for error reporting.
3103 2007-02-18 Marek Safar <marek.safar@gmail.com>
3105 A fix for bug #78712
3106 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
3109 2007-02-18 Marek Safar <marek.safar@gmail.com>
3111 A fix for bug #80493 by Atsushi Enomoto
3112 * cs-parser.jay: Ignore invalid attribute target.
3114 2007-02-18 Marek Safar <marek.safar@gmail.com>
3116 * cs-tokenizer.cs: Ignore '\0' as white space character.
3118 2007-02-17 Miguel de Icaza <miguel@novell.com>
3120 * cs-parser.jay: Add support for lambda expressions to the mcs
3123 * lambda.cs: Only clone when we are probing, not on the final call
3124 (Compatible is the final call).
3126 * statement.cs (CloneContext): Introduce class to provide block
3127 remapping during clone.
3129 All statements Clone themselves now.
3131 (Clone): special handling for blocks, when we clone a block, we
3132 register the block inside this routine, as children of the block
3133 might trigger a lookup.
3135 * expression.cs: Add support for CloneContext in all expressions.
3137 2007-02-17 Marek Safar <marek.safar@gmail.com>
3139 A fix for bug #80493
3140 * statement.cs: Report ambiguous warning when interfaces are not related.
3142 2007-02-15 Marek Safar <marek.safar@gmail.com>
3144 C# 3.0 extension methods.
3146 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
3147 cannot be used directly.
3149 * class.cs (Class.Emit): Emit extension attribute if any class method
3150 is extension method.
3151 (Method.Define): Add basic extension method validation conditions.
3152 (Method.Emit): Emit extension attribute for method.
3154 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
3155 extension method exists. Currently we follow same approach as Microsoft
3156 does, emit even if a method or a class are private but this can change
3159 * cs-parser.jay: Add handling of `this' keyword in method parameters
3162 * decl.cs (DeclSpace.IsStaticClass): New property.
3163 (MemberCache.FindExtensionMethods): Looks for extension methods with
3164 defined name and extension type.
3166 * doc.cs: Updated after OverloadResolve changes.
3168 * driver.cs: Add new soft reference to System.Core.dll.
3170 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
3171 (ExtensionMethodGroupExpr): Represents group of extension methods.
3173 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
3174 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
3175 to MethodGroupExpr and made non-static for easier customization.
3176 (Invocation.DoResolve): Add extension method lookup when no standard
3178 (MemberAccess.DoResolve): Try extension methods if no member exists.
3180 * modifiers.cs: Add METHOD_EXTENSION modifier.
3182 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
3183 as well as candidate extension type.
3184 (ComputeNamespaces): When assembly constains extension methods registers
3186 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
3187 extension method lookup.
3188 (Namespace.LookupExtensionMethod): Looks for extension method in this
3190 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
3191 find a method which matches name and extensionType.
3193 * parameter.cs (Parameter): Add This modifer.
3194 (HasExtensionMethodModifier): New property.
3195 (Resolve): Add extension parameter check.
3196 (ModFlags): turned to property to exclude this modifier as it is not real
3198 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
3200 * support.cs (ParameterData): Add ExtensionMethodType.
3201 (ReflectionParameters): Implemented ExtensionMethodType interface property.
3203 * typemanager.cs: Add type and ctor extension attribute type.
3205 2007-02-15 Miguel de Icaza <miguel@novell.com>
3207 * report.cs (DisableErrors, EnableErrors): used to prevent error
3208 output when we are "trying" to compile various methods with
3211 * ecore.cs (Expression): Add Clone method that calls the virtual
3212 CloneTo method. The current CloneTo method in Expression throws
3213 an exception so we can track down all the places where this must
3214 be implemented (not using abstract, because that would be a lot of
3215 up-front-work before we can start testing the implementation
3218 Important: we only need Clone capabilities for expressions created
3219 by the parser, as the expressions we will be cloning are
3220 expressions in the pre-resolved state. This vastly simplifies
3223 (SimpleName): Add CloneTo that does nothing.
3224 (EmptyCast): Add CloneTo.
3226 * expression.cs (Binary): Implement CloneTo.
3227 (Invocation.IsApplicable): Store the current ec in
3228 EmitContext.TempEc and restore it on return. This is used so we
3229 do not have to sprinkle hundres of methods with an extra
3230 EmitContext, we know that the only user is the lambda expression
3231 ImplicitConversionExists code.
3233 (Argument): Add Cloning capabilities.
3234 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
3235 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
3236 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
3237 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
3238 IndexerAccess): Add Clone capability.
3240 (LocalVariableReference, This): TODO: needs cloned Block mapping.
3242 (Argument): Add cloning capability.
3244 * assign.cs (Assign): Implement CloneTo.
3246 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
3248 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
3249 version by calling Convert with the EmitContext (that we are
3250 currently storing in ec, this is not great, but will do for now,
3251 to avoid passing EmitContext parameters to hundreds of functions
3252 that do not need them now).
3254 (SetExpression): Remove, it is not needed.
3256 (ContextualReturn): Implement CloneTo.
3258 * statement.cs (Statement): Implement cloning infrastructure,
3259 similar to expressions.
3261 (Block): Partial implementation of Clone for statements.
3263 (Return): Implement clone.
3265 * constant.cs (Constant.CloneTo): New method, does nothing.
3267 * codegen.cs (TempEc): Add a static EmitContext as a temporary
3268 solution, until we decide how to exactly do this.
3270 2007-02-14 Marek Safar <marek.safar@gmail.com>
3272 A fix for bug #80493
3273 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
3274 a property is override we need to use second accessor.
3276 2007-02-13 Marek Safar <marek.safar@gmail.com>
3278 A fix for bug #80418
3279 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
3282 2007-02-13 Marek Safar <marek.safar@gmail.com>
3284 Another fix for bug #80749
3285 * pending.cs: Abstract class has priority over interfaces.
3287 2007-02-13 Marek Safar <marek.safar@gmail.com>
3289 Another fix for bug #80749
3290 * pending.cs: Abstract class has priority over interfaces.
3292 2007-02-13 Marek Safar <marek.safar@gmail.com>
3294 Another fix for bug #80749
3295 * pending.cs: Abstract class has priority over interfaces.
3297 2007-02-13 Marek Safar <marek.safar@gmail.com>
3299 Another fix for bug #80749
3300 * pending.cs: Abstract class has priority over interfaces.
3302 2007-02-13 Marek Safar <marek.safar@gmail.com>
3304 * class.cs Better error message.
3306 * driver.cs: Add shorter versions of -optimize option.
3308 2007-02-13 Martin Baulig <martin@ximian.com>
3310 * class.cs (Constructor.Emit): Check the return value of
3311 ec.ResolveTopBlock() and return on error.
3313 2007-02-13 Raja R Harinath <rharinath@novell.com>
3315 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
3316 message to fix error message regression.
3318 2007-02-12 Marek Safar <marek.safar@gmail.com>
3320 * delegate.cs: Delegate creation expression cannot be of Nullable type.
3322 2007-02-12 Marek Safar <marek.safar@gmail.com>
3324 A fix for bug #80749
3325 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
3326 its parent container.
3328 * class.cs (DefineFieldInitializers): Each initializer can has different
3331 * const.cs: Updated.
3333 2007-02-11 Miguel de Icaza <miguel@novell.com>
3335 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
3336 now all the heavy lifting to check that embedded statements or
3337 expressions have the right form is done in the ContextualReturn.
3339 (ContextualReturn): New class.
3341 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
3342 method that can be invoked to report 201, so we do not replicate
3345 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
3347 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
3348 treating tabs as spaces.
3350 2007-02-09 Marek Safar <marek.safar@gmail.com>
3352 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
3353 * assign.cs: Use full implicit conversion for right side check.
3355 2007-02-09 Marek Safar <marek.safar@gmail.com>
3357 * statement.cs (Switch): Switch over boolean type is not standardized.
3359 2007-02-08 Marek Safar <marek.safar@gmail.com>
3361 A fix for bug #80755
3362 * decl.cs (FindBaseEvent): Don't use method cache for events.
3364 2007-02-07 Marek Safar <marek.safar@gmail.com>
3366 * cs-parser.jay: Better syntax error handling.
3368 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
3369 instead of underlying type value.
3371 2007-02-06 Marek Safar <marek.safar@gmail.com>
3373 * driver.cs: Check define identifier before is registered.
3375 * namespace.cs: Use existing error message.
3377 * report.cs: New warning.
3379 2007-02-06 Marek Safar <marek.safar@gmail.com>
3381 A fix for bug #80742
3382 * expression.cs: Delegate Invoke method can be called directly.
3384 2007-02-06 Marek Safar <marek.safar@gmail.com>
3386 A fix for bug #80676
3387 * class.cs (IsEntryPoint): The Main method can have params modifier.
3389 2007-02-04 Miguel de Icaza <miguel@novell.com>
3391 * parameter.cs (Parameter, Parameters): Add Clone method.
3393 * anonymous.cs (Compatible): Turn method into virtual method, so
3394 LambdaExpression can implement a different behavior.
3396 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
3397 out the basic checking here, so it can be used by
3400 * lambda.cs: Introduce "Compatible" function that will do the
3403 2007-02-02 Marek Safar <marek.safar@gmail.com>
3405 * attribute.cs: Unified one error message.
3407 * class.cs (Class): Use type attributes and not properties to test static
3409 (IsEntryPoint): Don's pass local variable.
3411 * convert.cs: Removed duplicate check.
3413 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
3415 * driver.cs: Don't crash when soft reference does not exist.
3417 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
3418 (UsingEntry): Removed redundant allocation.
3420 * parameter.cs: Add fast path for type parameters.
3422 * support.cs: Don't allocate attribute when it's not used.
3424 2007-01-30 Miguel de Icaza <miguel@novell.com>
3427 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
3428 this into a virtual method, so we can override it in LambdaExpression.
3430 * driver.cs: Improve diagnostics in case of failure.
3432 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
3433 write a function that is slightly more complex and that parses:
3435 type identifier [, type identifier]* )
3437 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
3440 (canEmpty ? i >= 0 : i > 0)
3442 2007-01-30 Raja R Harinath <rharinath@novell.com>
3444 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
3445 exception on possibly valid code.
3447 2007-01-29 Raja R Harinath <rharinath@novell.com>
3449 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
3451 (parse_opt_type_arguments): Remove. It's almost the same as
3453 (parse_namespace_or_typename): Use parse_less_than.
3455 2007-01-28 Miguel de Icaza <miguel@novell.com>
3457 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
3458 this bug took a few hours to find, because the state saved and
3459 restored by PushPosition and PopPosition was ignoring the state of
3460 parse_generic_less_than.
3462 I can also now remove the handling of OP_LT and OP_GT, this solves
3465 * cs-tokenizer.cs: store the location for the ARROW token, we use
3468 (PushPosition, PopPosition): save/restore also `current_token',
3469 restore `parse_generic_less_than' (was missing).
3471 (parse_opt_type_arguments): use parse_type, not
3472 parse_namespace_or_typename to parse types.
3474 * lambda.cs: Empty new file, will eventually have the lambda
3475 expression implementation.
3477 * lambda.test: used to test the internal tokenizer.
3479 * report.cs (FeatureIsNotISO1): Rename from
3480 FeatureIsNotStandardized, because it was about the language level
3481 (1 vs 2) it was not about standarization.
3483 (FeatureRequiresLINQ): New.
3485 * support.cs (SeekableStreamReader): Only require that the reader
3486 is a TextReader, not a StreamReader, so we can plug StringReader.
3488 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
3489 given position in the input stream the following tokens can be
3490 parsed as a type followed by an identifier.
3492 (is_punct): after a '(' if parse_type_and_parameter returns true,
3493 then return a special token OPEN_PARENS_LAMBDA which is used to
3494 avoid reduce/reduce errors in the grammar for the
3495 lambda_expression rules.
3497 (parse_type): implement a type parser inside the
3498 tokenizer, the parser only returns true or false depending on
3499 whether the input at a given position can be parsed as a type.
3501 (peek_token): new method used during type parsing.
3503 2007-01-28 Raja R Harinath <rharinath@novell.com>
3506 * anonymous.cs (ScopeInfo.InflateParameters): New.
3507 (AnonymousContainer.Resolve): Use it to redirect types of
3508 delegate parameters.
3510 2007-01-27 Raja R Harinath <rharinath@novell.com>
3513 * expression.cs (Error_InvalidArguments): Don't use two different
3514 messages for CS1503. Use ExtraInformation and
3515 SymbolRelatedToPreviousError instead.
3518 * decl.cs (DeclSpace.initialize_type_params): Don't access
3519 'type_params' of a partial class directly.
3521 2007-01-26 Miguel de Icaza <miguel@novell.com>
3523 * constant.cs: Removed a handful of out-of-range checks that were
3526 2007-01-25 Marek Safar <marek.safar@gmail.com>
3528 * expression.cs (CheckUselessComparison): Add additional check for char
3531 * namespace.cs: Fixed typo.
3533 2007-01-23 Miguel de Icaza <miguel@novell.com>
3535 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
3536 gone, instead we inline the test, preventing the needless casts to
3537 longs, ulongs and doubles for the parameters, avoiding calls to
3538 methods that overchecked stuff, and instead inlined things
3541 2007-01-20 Marek Safar <marek.safar@gmail.com>
3543 * cs-parser.jay: Better parameter error handling.
3545 2007-01-17 Marek Safar <marek.safar@gmail.com>
3547 A fix for bug #80368, #80522
3548 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
3549 whether array initializer contains constants only.
3550 (ArrayCreation.Emit): Use better formula to decide when
3551 are array initializers for static initialization.
3552 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
3553 have to emit even constants otherwise they are pre-initialized.
3555 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
3556 Raja R Harinath <rharinath@novell.com>
3558 Fix emit order of 'get' vs. 'set'.
3559 * support.cs (Accessors): New.
3560 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
3561 Note the order in which accessors are declared in the source.
3562 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
3563 Refactored from Property.Define and Indexer.Define.
3564 (PropertyBase.DefineAccessors): New helper that calls the above in
3565 appropriate order as noted by the parser.
3566 (Property.Define, Indexer.Define): Update to changes.
3567 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
3569 2007-01-17 Raja R Harinath <rharinath@novell.com>
3571 Fix cs0029-6.cs and gcs0029-2.cs (regression)
3572 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
3573 there's an implicit conversion from the current type to the target
3574 type before converting the underlying constant.
3576 2007-01-16 Marek Safar <marek.safar@gmail.com>
3578 * const.cs (ResolveValue): Updated after constant conversion was made more
3581 * constant.cs (GetAttributableValue): constant to object conversion is
3582 used for attributes only.
3583 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
3584 constant conversions.
3585 (LongConstant.ConvertImplicitly): Ditto.
3587 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
3588 (ImplicitConversionStandard): Handle constant conversion as extra step.
3589 It solves the issue when constant conversion was called indirectly like
3590 inside array initializer and constant folding was skipped.
3592 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
3595 * statement.cs(ImplicitConversionStandard): Updated after constant
3596 conversion was made more generic.
3598 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
3600 * expression.cs (As.DoResolve): Use GenericConstraints instead of
3601 Constraints, solves the problem where the compiler incorrectly
3602 reported that a type parameter was not constrained to a class (Bug
3605 2007-01-14 Marek Habersack <grendello@gmail.com>
3607 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
3609 2007-01-14 Marek Safar <marek.safar@gmail.com>
3611 A fix for bug #80368
3612 * assign.cs (FieldInitializer): New class implements field
3613 initializer statement.
3615 * attribute.cs: Update after FieldMember rename.
3617 * class.cs (PropertyBasedMember): New common class for property based
3619 (InterfaceMemberBase): New base class for all members which can be used as
3620 an interface members.
3621 (MethodCore): Moved really common code to InterfaceMemberBase.
3622 (Method.Define): Equal and GetHasCode detection is relevant for methods
3624 (MethodData.Define): Don't assume that public event implements an
3625 interface automatically.
3626 (MethodData.DefineMethodBuilder): Issue an error even if only extern
3628 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
3629 (FieldMember): Merged with FieldBase.
3630 (EventProperty.AEventPropertyAccessor): New specialization to check whether
3631 event extern modifier can be used.
3632 (EventField.EventFieldAccessor): Moved event field specific code here.
3633 (Event.AllowedModifiers): Even event can be extern.
3634 (Event.FindOutBaseMethod): New override specific to events.
3635 (Indexer.parameters): Reintroduce parameters because base class holds
3636 only properties common data.
3637 (Indexer.CheckForDuplications): Indexers are threated as methods so we
3638 need do extra parameters check.
3640 * const.cs: Update after FieldMember rename.
3642 * decl.cs (MemberCache.FindBaseEvent): New method.
3644 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
3645 to reflect that indexer is now derived from PropertyBased.
3647 * ecore.cs (GetMemberType): Made public.
3648 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
3651 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
3653 * typemanager.cs (CSharpSignature): Correctly print event accessors.
3654 (RegisterEvent): Removed.
3655 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
3656 (GetPrivateFieldOfEvent): Renamed to GetEventField.
3658 2007-01-11 Raja R Harinath <rharinath@novell.com>
3661 * statement.cs (CollectionForeach.TryType): Prefer generic
3662 GetEnumerator over non-generic variant. Fix code to follow comments.
3664 2007-01-09 Raja R Harinath <rharinath@novell.com>
3667 * support.cs (ReflectionParameter): Don't use an invalid index on
3668 the generic parameter data.
3670 2007-01-08 Miguel de Icaza <miguel@novell.com>
3672 * driver.cs: Just add a tiny bit of infrastructure.
3674 2007-01-02 Marek Safar <marek.safar@gmail.com>
3676 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
3677 where field type is struct from current assembly.
3679 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
3682 2007-01-02 Marek Safar <marek.safar@gmail.com>
3684 A fix for bug #80381
3685 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
3688 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
3690 (Namespace.LookupType): Always use core types from corlib when speficied.
3692 * report.cs: A new warning.
3694 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
3695 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
3696 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
3698 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
3699 (InitCoreTypes): Set expression type of object_type and value_type
3700 immediately after lookup.
3702 2007-01-01 Miguel de Icaza <miguel@novell.com>
3704 * cs-tokenizer.cs: Accept Pc class characters (Connector
3705 Punctuation) as valid identifiers. Fixes #78259
3707 * expression.cs (Invocation.DoResolve): Moved the check for the
3708 use of `this' for doing method calls to the Invocation resolution
3709 step, after overload resolution has taken place instead of doing
3710 the check at the low-level `This.DoResolve' level.
3712 The `This.DoResolve'(appens before overload resolution, so it has
3713 no way of knowing if the method that will be called will be
3714 instace or static, triggering an erroneous report for cs0188 (Bug
3717 We now do the check for instance method invocations after we know
3718 what method will be called.
3720 (This.CheckThisUsage): Move the actual use of this structure
3721 checking into its own method and expose it.
3723 * Everywhere that called Error_ValueCannotBeConverted: pass a new
3726 Exceptions: Null.ConvertImplicitly,
3727 Constant.ImplicitConversionRequired as there are too many call
3728 sites for passing the ec.
3730 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
3731 EmitContext, if the value is null, then we do not try to provide
3732 the extra information from the error (If a userdefined conversion
3733 exists, as UserDefinedConversion requires a non null-EmitContext).
3737 2006-12-30 Raja R Harinath <rharinath@novell.com>
3739 * flowanalysis.cs (MyBitVector): Document some invariants.
3740 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
3741 introduced below, and add a couple of others,
3743 2006-12-30 Marek Safar <marek.safar@gmail.com>
3745 * attribute.cs (GetMethodObsoleteAttribute): Uses new
3746 GetPropertyFromAccessor and GetEventFromAccessor.
3748 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
3749 overrides non-obsolete one.
3750 (Indexer.Define): Error message has been moved to the parser.
3752 * cs-parser.jay: Better syntax errors handling.
3754 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
3755 when an invocation has no arguments.
3757 * ecore.cs: Removed not used caching.
3759 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
3762 * report.cs: Add a new warning.
3764 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
3766 * typemanager.cs (enumeration_type): Removed.
3767 (CSharpSignature): Reuses IsSpecialMethod.
3768 (IsEqual): Hack for MS BCL.
3769 (GetPropertyFromAccessor): New method.
3770 (GetEventFromAccessor): New method.
3771 (IsSpecialMethod): Fixed to handle more cases.
3773 2006-12-30 Marek Safar <marek.safar@gmail.com>
3775 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
3776 Made white spaces array static.
3778 * ecore.cs (RemoveGenericArity): Optimized.
3780 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
3782 (MyBitVector.initialize_vector): Simplified.
3784 2006-12-22 Miguel de Icaza <miguel@novell.com>
3786 * ecore.cs: Am not entirely happy with this hack, but it seems to
3787 address the issue in 80257 (a small test case for
3790 I set the MethodGroupExpr.Type to an internal compiler type
3791 (itself in this case) to force the resolution to take place. Why
3792 it does not take place with a null is beyond me.
3794 2006-12-20 Marek Safar <marek.safar@gmail.com>
3796 A fix for bug #80288
3797 * expression.cs (ResolveOperator): Consider user defined conversion for
3798 logical and operator too.
3799 (EmitBranchable): Optimization for logical and when full constant folding
3800 could not be applied but one operand is constant.
3802 2006-12-19 Marek Safar <marek.safar@gmail.com>
3804 * class.cs (GetClassBases): Write 5 times every day, will never use
3805 FullName for error reporting.
3807 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
3809 2006-12-19 Martin Baulig <martin@ximian.com>
3811 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
3812 the symbol file info here.
3814 2006-12-18 Marek Safar <marek.safar@gmail.com>
3816 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
3817 of `elseif' is taking then following sections are not taking.
3818 Fixes an issue reported on mono mailing list.
3820 2006-12-18 Marek Safar <marek.safar@gmail.com>
3822 A fix for bug #80300
3823 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
3824 a caller is not taking.
3826 2006-12-18 Raja R Harinath <rharinath@novell.com>
3828 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
3829 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
3830 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
3831 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
3832 * class.cs: Update to changes.
3834 2006-12-17 Marek Safar <marek.safar@gmail.com>
3836 A fix for bug #79934
3837 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
3840 * class.cs (ResolveMembers): Register an iterator in current container and
3843 2006-12-16 Raja R Harinath <rharinath@novell.com>
3846 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
3847 satisfy a params annotated parameter.
3849 2006-12-16 Marek Safar <marek.safar@gmail.com>
3851 A fix for bug #77014
3852 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
3853 paramters correctly and not rely on hacks in Parameters class.
3854 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
3856 (Invocation.VerifyArgumentsCompat): Ditto.
3857 (Invocation.EmitArguments): Changed to correctly emit params arguments at
3860 * parameter.cs (HasParams): Don't assume that params is the last one.
3862 * support.cs (ReflectionParameters.ctor): Look for params attribute
3864 (ReflectionParameters.ParameterType): Removed hack when we returned last
3865 parameter for out of range parameters.
3866 (ParameterName, ParameterModifier): Ditto.
3868 2006-12-14 Marek Safar <marek.safar@gmail.com>
3870 A fix for bug #79987
3871 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
3872 when assembly is not CLS compliant but type is. I have no idea why is this
3875 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
3877 2006-12-13 Miguel de Icaza <miguel@novell.com>
3879 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
3880 in struct constructors, they are basically no-ops.
3882 2006-12-12 Marek Safar <marek.safar@gmail.com>
3884 * cs-tokenizer.cs (Position): Save preprocessor status too.
3886 2006-12-12 Marek Safar <marek.safar@gmail.com>
3888 A fix for bug #77794
3889 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
3891 2006-12-12 Marek Safar <marek.safar@gmail.com>
3893 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
3895 (pp_expr): Report error for an invalid expression.
3896 (handle_preprocessing_directive): Simplified; add more error checking.
3898 2006-12-11 Marek Safar <marek.safar@gmail.com>
3900 A fix for bug #74939
3901 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
3902 directives handling.
3904 2006-12-10 Marek Safar <marek.safar@gmail.com>
3906 A fix for bugs #80093, and #75984
3907 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
3908 logic, it seems to me as it worked before "by coincidence".
3909 (xtoken): Simplified to use reworked handle_preprocessing_directive.
3910 (cleanup): Enabled endif check.
3912 2006-12-09 Marek Safar <marek.safar@gmail.com>
3914 A fix for bug #80162
3915 * statement.cs (CollectionForeach.TryType): Generics and non-generics
3916 enumerators are never ambiguous.
3918 2006-12-08 Raja R Harinath <rharinath@novell.com>
3921 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
3923 2006-12-06 Marek Safar <marek.safar@gmail.com>
3925 A fix for bug #80144
3926 * class.cs (EventProperty.Define): Explicit implementation means
3927 that an even is used.
3929 2006-12-06 Marek Safar <marek.safar@gmail.com>
3931 Fixes the operators implementation (part II)
3933 * cfold.cs (DoConstantNumericPromotions): Renamed to
3934 DoBinaryNumericPromotions and simplified.
3935 (BinaryFold): Couple of conversion fixes; simplified.
3937 * constant.cs, ecore.cs, literal.cs
3938 (ToType): Renamed to ConvertImplicitly.
3939 (Reduce): Renamed to ConvertExplicitly.
3941 * class.cs, convert.cs: Updated.
3943 * expression.cs: TryReduce doesn't throw an exception.
3945 2006-12-01 Marek Safar <marek.safar@gmail.com>
3947 A fix for bug #80108
3948 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
3951 2006-11-30 Marek Safar <marek.safar@gmail.com>
3953 Fixes unary operators implementation (part I)
3956 * cfold.cs (Error_CompileTimeOverflow): Made internal
3958 * const.cs (IConstant): Changed to use reference to constant and
3959 not constant itself.
3960 Updated IConstant implementations.
3962 * constant.cs (CreateConstant): New factory method.
3963 Updated IConstant implementation.
3965 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
3967 * ecore.cs: Updated to use CreateConstantReference.
3969 * enum.cs: Reflects IConstant changes.
3971 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
3973 * literal.cs (NullConstant): Change to be independently usable.
3975 2006-11-29 Martin Baulig <martin@ximian.com>
3977 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
3978 we need to emit the scope initializer before calling the base .ctor.
3980 * anonymous.cs: Merged back from the new anonymous methods branch.
3981 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
3983 * expression.cs (ParameterReference.DoResolveBase): Create a
3984 "normal" ScopeInfo when capturing parameters rather than using the
3985 root scope; this makes things work with anonymous methods having
3989 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
3991 2006-11-22 Marek Safar <marek.safar@gmail.com>
3993 A fix for bug #79987
3994 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
3995 check to a base class.
3996 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
3997 only when assembly has missing attribute.
3998 * report.cs: Update.
4000 2006-11-21 Marek Safar <marek.safar@gmail.com>
4002 * cs-tokenizer.cs: Merged with gmcs version.
4004 2006-11-20 Marek Safar <marek.safar@gmail.com>
4007 * cs-parser.jay: Better error message when partial keyword is misplaced.
4009 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
4011 A fix for bug #79810
4012 report.cs: CS1058 only applies to 2.0 profile (gmcs).
4013 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
4014 a RuntimeWrappedException by default.
4016 2006-11-18 Marek Safar <marek.safar@gmail.com>
4018 A fix for bug #79843
4019 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
4021 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
4023 2006-11-18 Marek Safar <marek.safar@gmail.com>
4025 * driver.cs, namespace.cs: Uses faster IndexOf version.
4027 2006-11-17 Marek Safar <marek.safar@gmail.com>
4029 A fix for bug #79941
4030 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
4032 (Operator.Define): Implicit/Explicit operator of same type is duplicate
4033 even if internal name is different.
4034 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
4035 (UserDefinedConversion): Simplified as the operators cannot be internal.
4036 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
4038 (MethodLookup): Replaced EmitContext with parentType.
4039 * expression.cs: Updated.
4041 2006-11-09 Raja R Harinath <rharinath@novell.com>
4043 * driver.cs (BadAssembly): Handle all the ugliness of
4044 DefineDynamicAssembly.
4046 2006-11-08 Raja R Harinath <rharinath@novell.com>
4048 Address parts of #58244 -- most of what's left is in the runtime
4049 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
4050 CS1509 error checks, and handle them for all assembly loads, not
4051 just the first invocation.
4052 (LoadModule): Likewise. Move handling of 'adder_method' ...
4053 * codegen.cs (AssemblyClass.AddModule): ... here.
4055 2006-11-02 Marek Safar <marek.safar@gmail.com>
4057 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
4058 IEnumerable<T> is ambiguous.
4060 2006-10-31 Marek Safar <marek.safar@gmail.com>
4062 A fix for bug #67689
4063 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
4064 GetEnumerator is ambiguous.
4066 * report.cs: Add new warning.
4068 2006-10-29 Marek Safar <marek.safar@gmail.com>
4070 A fix for bug #78602
4071 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4072 to protected member can be nested type.
4074 2006-10-28 Marek Safar <marek.safar@gmail.com>
4076 A fix for bug #78965
4077 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4078 to protected member must derive from current type.
4080 2006-10-27 Marek Safar <marek.safar@gmail.com>
4082 assign.cs: Reuses error method.
4084 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
4085 instead of type for constants.
4086 (Expression.Error_ValueAssignment): Common error method.
4088 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
4091 2006-10-27 Marek Safar <marek.safar@gmail.com>
4093 A fix for bug #79081
4094 * expression.cs (MemberAccess.DoResolve): Check nested type
4097 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
4099 * doc.cs : nested delegates were not handled. Fixed bug #79754.
4101 2006-10-26 Marek Safar <marek.safar@gmail.com>
4103 A fix for bug #76591
4104 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
4106 2006-10-26 Marek Safar <marek.safar@gmail.com>
4108 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
4109 type forwarder of the same type multiple times.
4111 2006-10-26 Raja R Harinath <rharinath@novell.com>
4114 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
4115 instance as an rvalue, even when we later resolve as an lvalue.
4117 2006-10-25 Martin Baulig <martin@ximian.com>
4119 * anonymous.cs: Fix #79673.
4121 2006-10-24 Marek Safar <marek.safar@seznam.cz>
4123 A fix for bug #79666
4124 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
4125 ignored when is optimized (= default value) as its value is already set.
4127 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4129 A fix for bug #79724
4130 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
4131 TypeContainer for type lookup.
4133 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4135 A fix for bug #79231
4136 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
4137 * expression.cs (OverloadResolve): Always convert type name for
4139 (ResolveNamespaceOrType): Don't confuse a nested type with any
4142 2006-10-18 Martin Baulig <martin@ximian.com>
4144 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
4146 2006-10-17 Miguel de Icaza <miguel@novell.com>
4148 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
4149 an int32, but requesting an int64 from the conversion
4151 2006-10-12 Martin Baulig <martin@ximian.com>
4154 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
4156 2006-10-12 Martin Baulig <martin@ximian.com>
4159 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
4161 2006-10-11 Miguel de Icaza <miguel@novell.com>
4163 * convert.cs: Remove broken code: I was doing the "Existance"
4164 tests for Implicit conversions.
4166 2006-10-10 Miguel de Icaza <miguel@novell.com>
4168 * convert.cs: Added one missing case in
4169 ImplicitStandardConversionExists uint64 to intptr.
4173 * typemanager.cs (uintptr_type): another core known type.
4175 * ecore.cs (OperatorCast): routine used to do cast operations that
4176 depend on op_Explicit. We could change some of the Decimal
4177 conversions to use this.
4179 This one has a probe mechanism that checks both types for an op_
4180 which it coudl be used to eliminate two classes: CastToDecimal
4181 and CastFromDecimal.
4183 * convert.cs: Implement the conversions documented in #59800
4185 2006-10-10 Martin Baulig <martin@ximian.com>
4187 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
4188 before RootScope.ResolveMembers().
4190 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
4191 `CurrentType' if appropriate.
4193 2006-10-09 Marek Safar <marek.safar@seznam.cz>
4195 A fix for bug #78568
4196 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
4197 when contains binary operators.
4198 * cs-parser.jay: Updated.
4200 2006-10-09 Martin Baulig <martin@ximian.com>
4203 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
4204 moved that into Define() and also do the other type parameter
4205 checks there. Fixes #79094. Added gtest-292.cs.
4208 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
4209 since that doesn't include type parameters; don't use `Ldelema'
4210 for type parameters. Fixes #78980. Added gtest-293.cs.
4212 2006-10-08 Marek Safar <marek.safar@seznam.cz>
4215 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
4216 conversion is allowed.
4218 2006-10-06 Marek Safar <marek.safar@seznam.cz>
4220 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
4221 error reporting when no error occurs.
4223 2006-10-06 Marek Safar <marek.safar@seznam.cz>
4225 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
4228 2006-10-06 Raja R Harinath <rharinath@novell.com>
4231 * class.cs (DefineTypeBuilder): Check circular dependencies before
4232 setting the parent of the TypeBuilder.
4233 (CheckRecursiveDefinition): Don't use 'BaseType', since
4234 it may not be valid until after DefineTypeBuilder. Use
4235 'base_type' instead.
4237 2006-10-04 Martin Baulig <martin@ximian.com>
4239 Merged the Anonymous Methods patch.
4241 * anonymous.cs, iterators.cs: The new anonymous methods code.
4243 * statement.cs (Variable): New public abstract class.
4244 (LocalInfo.Variable): New public property.
4245 (LocalInfo.ResolveVariable): New public method.
4246 (Block.Flags): Add `IsIterator'.
4247 (Block.AddVariable): Improved the CS0136 check.
4248 (Block.AnonymousChildren): New public property.
4249 (Block.AddAnonymousChild): New public method.
4250 (ToplevelBlock): Update to use the new anonymous method framework.
4251 (ToplevelBlock.ctor): `container' is now a `Block' and not a
4252 `ToplevelBlock'; this is required to correctly implement the
4254 (Fixed, Using): Use `TemporaryVariable' instead of directly
4255 creating the `LocalBuilder'.
4257 * parameter.cs (Parameter.ResolveVariable): New public method.
4258 (Parameters.ResolveVariable): Likewise.
4260 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
4262 * class.cs (TypeContainer): Replaced the `iterators' list and
4263 corresponding methods with a list of `CompilerGeneratedClass'es.
4264 (TypeContainer.ResolveMembers): New public method.
4265 (Method): `IIteratorContainer' has been replaced by
4268 * expression.cs (VariableReference): New public abstract base
4269 class for `LocalVariableReference', `ParameterReference' and
4272 * codegen.cs (EmitContext): Removed `capture_context',
4273 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
4274 (EmitContext.EmitThis): Removed.
4276 * cs-parser.jay: Replace `iterator_container' with
4279 2006-10-04 Martin Baulig <martin@ximian.com>
4281 * generic.cs (GenericMethod): Don't make this abstract.
4282 (Constraints.Clone): Added dummy implementation.
4284 2006-10-04 Raja R Harinath <harinath@gmail.com>
4287 * namespace.cs (LookForAnyGenericType): Avoid nullref on
4288 'declspaces'. Avoid allocating arrays willy-nilly.
4291 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
4292 cases out of the switch.
4294 2006-09-28 Marek Safar <marek.safar@seznam.cz>
4296 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
4297 message when non-generic type is used with the type arguments.
4298 * expression.cs: Updated.
4300 2006-09-28 Raja R Harinath <rharinath@novell.com>
4303 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
4304 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
4305 Change semantics slightly. Don't insist on having only one
4306 temporary EmptyExpression -- just throttle the creation of new ones.
4309 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
4310 non-interfaces too. If no methods are found, don't try to create
4313 2006-09-28 Marek Safar <marek.safar@seznam.cz>
4315 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
4318 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
4319 us produce better error message.
4321 2006-09-27 Marek Safar <marek.safar@seznam.cz>
4323 * expression.cs (Binary.ResolveOperator): Warn about a side effect
4324 of the `|' operator.
4326 * report.cs: A new warning added.
4328 2006-09-27 Martin Baulig <martin@ximian.com>
4330 * generic.cs (GenericMethod): Don't make this abstract.
4332 2006-09-27 Martin Baulig <martin@ximian.com>
4335 (InternalErrorException): Added overloaded ctor taking a params array.
4337 2006-09-26 Marek Safar <marek.safar@seznam.cz>
4339 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
4340 Fixed the cases when same error was reported twice.
4342 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
4343 now report symbol information.
4345 2006-09-25 Martin Baulig <martin@ximian.com>
4347 * class.cs: Completely unified with the gmcs version.
4349 2006-09-25 Martin Baulig <martin@ximian.com>
4351 * typemanager.cs (TypeManager.IsNullableType): New public function.
4352 (TypeManager.IsNullableTypeOf): Likewise.
4353 (TypeManager.IsNullableValueType): Likewise.
4355 * class.cs (MethodCore): Added the `GenericMethod' argument from
4356 gmcs and also unified all classes derived from `MethodCore' with gmcs.
4358 2006-09-24 Raja R Harinath <harinath@gmail.com>
4360 * convert.cs: Unify with gmcs version.
4362 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4364 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
4365 verify them as well.
4367 * report.cs: New warning.
4369 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4371 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
4372 for anonymous block with out argument.
4374 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4376 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
4377 not used private events only.
4379 2006-09-23 Marek Safar <marek.safar@seznam.cz>
4381 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
4383 * const.cs (Const.Define): Check for constant type.
4384 (Const.IsConstantTypeValid): Looks for valid constant types.
4386 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
4388 * ecore.cs (EmptyConstantCast): New common class for all constant based
4391 * expression.cs (Is.DoResolve): Handle null constant especially.
4392 (New.DoResolve): Check for new void().
4393 (MemberAccess.DoResolve): Cope with all kind of nulls.
4395 * literal.cs (NullConstant): Uses EmptyConstantCast.
4396 (NullDefault): Based on EmptyConstantCast.
4397 (NullLiteral): Uses EmptyConstantCast.
4399 * statement.cs (Block.ResolveMeta): Check for constant type.
4401 2006-09-22 Martin Baulig <martin@ximian.com>
4403 * delegate.cs, attribute.cs: Merged with the gmcs versions.
4405 2006-09-22 Raja R Harinath <rharinath@novell.com>
4407 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
4411 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
4412 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
4415 2006-09-22 Martin Baulig <martin@ximian.com>
4417 * ecore.cs: Merged with the gmcs version.
4419 * generic.cs (ConstructedType): New dummy class.
4420 (TypeArguments): Don't make this abstract.
4423 (TypeManager.IsGenericTypeDefinition): New method.
4424 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
4426 2006-09-22 Raja R Harinath <rharinath@novell.com>
4428 * expression.cs (ComposedCast): Check for arrays of TypedReference
4429 before creating the type, not after.
4431 2006-09-21 Marek Safar <marek.safar@seznam.cz>
4433 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
4434 after ToType change.
4436 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
4437 when constant must be implicitly convertible.
4439 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
4441 * ecore.cs (NullCast): Derives from NullConstant.
4443 * expression.cs (Is.DoResolve): Removed useless variables.
4444 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
4445 (New.Constantify): Add enum support.
4446 (MemberAccess.DoResolve): Add warning when accessing null constant or
4449 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
4452 * literal.cs (NullConstant): New abstract class with common
4453 functionality for all null specializations.
4454 (NullDefault): Represents default(X) when result can be
4456 (NullLiteral): Updated.
4458 * report.cs: Add new warning.
4460 2006-09-21 Martin Baulig <martin@ximian.com>
4462 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
4464 2006-09-21 Martin Baulig <martin@ximian.com>
4466 * generic.cs (GenericConstraints): New dummy class.
4467 (Constraints): Likewise.
4468 (TypeParameter): Likewise.
4469 (TypeParameterName): Likewise.
4470 (GenericMethod): Likewise.
4472 * typemanager.cs (TypeManager.GetGenericArguments): New method.
4474 * decl.cs: Merged with the gmcs version.
4476 2006-09-21 Raja R Harinath <rharinath@novell.com>
4478 * generic.cs (TypeParameter): Implement IMemberContainer.
4479 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
4481 * rootcontext.cs: Unify with gmcs version.
4483 * report.cs: Unify with gmcs version.
4484 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
4485 from gmcs/generics.cs.
4486 * generics.cs (TypeParameter): New dummy class.
4488 * support.cs: Unify with gmcs version.
4490 2006-09-20 Raja R Harinath <rharinath@novell.com>
4492 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
4493 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
4495 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
4496 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
4497 * mcs.exe.sources: Add generic.cs.
4499 * codegen.cs: Unify with gmcs version.
4501 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
4502 (EmitContext): Add GenericDeclContainer implementation.
4503 * decl.cs (MemberCore, DeclSpace): Likewise.
4504 * namespace.cs: Remove #ifdef GMCS_SOURCE.
4506 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
4507 MCS TypeManager has a corresponding dummy method.
4509 2006-09-19 Martin Baulig <martin@ximian.com>
4511 * expression.cs: Completely merged with the gmcs version.
4513 2006-09-19 Martin Baulig <martin@ximian.com>
4515 * expression.cs (Invocation): Merged with the gmcs version.
4516 (ArrayAccess.GetStoreOpcode): Likewise.
4518 2006-09-19 Martin Baulig <martin@ximian.com>
4521 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
4522 (TypeManager.IsGenericMethodDefinition): Likewise.
4524 2006-09-19 Martin Baulig <martin@ximian.com>
4527 (TypeManager.IsEqual): Moved the gmcs implementation here.
4528 (TypeManager.DropGenericTypeArguments): Likewise.
4529 (TypeManager.DropGenericMethodArguments): Likewise.
4530 (TypeManager.GetTypeArguments): Moved here from gmcs.
4531 (TypeManager.HasGenericArguments): Likewise.
4533 2006-09-19 Martin Baulig <martin@ximian.com>
4535 * expression.cs (Binary): Merged with the gmcs version.
4537 2006-09-19 Martin Baulig <martin@ximian.com>
4539 * expression.cs (Probe, As, Is): Merged with the gmcs version.
4541 2006-09-19 Martin Baulig <martin@ximian.com>
4543 * typemanager.cs: Merged with the gmcs version.
4545 2006-09-16 Raja R Harinath <rharinath@novell.com>
4547 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
4548 * driver.cs: Likewise.
4550 2006-09-16 Marek Safar <marek.safar@seznam.cz>
4553 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
4554 only if parent type is class.
4555 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
4558 2006-09-15 Marek Safar <marek.safar@seznam.cz>
4561 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
4563 * typemanager.cs(CSharpName): Converts NullType to null.
4565 2006-09-15 Martin Baulig <martin@ximian.com>
4568 (TypeManager.GetMethodName): Added mcs implementation.
4569 (TypeManager.IsEqual): Likewise.
4572 (SimpleName.RemoveGenericArity): Added dummy implementation.
4574 * pending.cs: Merged with the gmcs version.
4576 2006-09-15 Martin Baulig <martin@ximian.com>
4578 * statement.cs: Merge with the gmcs version.
4580 2006-09-15 Martin Baulig <martin@ximian.com>
4582 * statement.cs (Switch): Merge with the gmcs implementation
4583 (without nullables), which is newer.
4585 2006-09-15 Martin Baulig <martin@ximian.com>
4587 * statement.cs (Block.Variables): Make this public.
4588 (ToplevelBlock.Parameters): Make this a property.
4589 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
4591 2006-09-15 Martin Baulig <martin@ximian.com>
4593 * namespace.cs: Merge with the gmcs version.
4595 2006-09-15 Martin Baulig <martin@ximian.com>
4597 * decl.cs (MemberName): Minor code cleanups.
4599 2006-09-15 Martin Baulig <martin@ximian.com>
4601 * parameter.cs: Merge with the gmcs version.
4603 2006-09-15 Martin Baulig <martin@ximian.com>
4605 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
4606 and an error in mcs.
4608 2006-09-15 Martin Baulig <martin@ximian.com>
4610 * flowanalysis.cs: Merged from GMCS; added the generics code into
4611 a `GMCS_SOURCE' conditional so we can share this file.
4613 2006-09-08 Martin Baulig <martin@ximian.com>
4615 * typemanager.cs (TypeManager.interlocked_type): New public field.
4616 (TypeManager.int_interlocked_compare-exchange): New public field.
4617 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
4618 enumerator types here and call InitGenericCoreTypes().
4619 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
4620 after calling InitEnumUnderlyingTypes().
4623 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
4624 `classes_second_stage'.
4626 2006-09-14 Marek Safar <marek.safar@seznam.cz>
4628 * assign.cs, ecore.cs, expression.cs: Share error message text.
4629 * class.cs (FieldMember.Define): Check for varible of static type.
4630 * driver.cs (LoadAssembly): Uses error output for errors.
4631 * statement.cs: Updated.
4633 2006-09-08 Marek Safar <marek.safar@seznam.cz>
4635 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
4638 2006-09-07 Martin Baulig <martin@ximian.com>
4641 (MainDriver): Revert r62663 from Marek; see #70506 for details.
4643 2006-08-29 Miguel de Icaza <miguel@novell.com>
4645 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
4647 2006-08-17 Miguel de Icaza <miguel@novell.com>
4649 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
4650 #52019 and #79064, the use of the \uXXXX sequence in source code
4651 to represent unicode characters.
4653 2006-08-15 Marek Safar <marek.safar@seznam.cz>
4655 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
4657 * class.cs, ecore.cs, statement.cs: Merged to one error message.
4659 2006-08-13 Miguel de Icaza <miguel@novell.com>
4661 * assign.cs: Catch attempts to assign to a method groups in += and
4664 2006-08-13 Marek Safar <marek.safar@seznam.cz>
4667 * cs-parser.jay: Don't destroy current array type by typeof of array's.
4669 2006-08-12 Marek Safar <marek.safar@seznam.cz>
4671 * class.cs (Method.Define): Issue a warning when generic method looks like
4673 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
4676 2006-08-09 Marek Safar <marek.safar@seznam.cz>
4678 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
4680 * decl.cs (MemberCache.FindMembers): When container is interface we need to
4681 search all base interfaces as a member can be ambiguous.
4682 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
4683 Constructor member type filter.
4684 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
4685 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
4686 reporting for returned memberinfos.
4687 * report.cs: Updated.
4688 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
4689 version to work on all runtimes.
4690 (TypeManager.RealMemberLookup): Removed members filtering.
4692 2006-08-08 Raja R Harinath <rharinath@novell.com>
4694 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
4695 (PropertyExpr.EmitAssign): Likewise.
4696 * expression.cs (Indirection.EmitAssign): Likewise.
4697 (LocalVariableReference.EmitAssign): Likewise.
4698 (ParameterReference.EmitAssign): Likewise.
4699 (Invocation.EmitArguments): Likewise.
4700 (ArrayAccess.EmitAssign): Likewise.
4701 (IndexerAccess.EmitAssign): Likewise.
4702 (This.EmitAssign): Likewise.
4703 (ConditionalLogicalOperator.Emit): Likewise.
4706 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
4707 instead of ArrayList. If the hashtable has a LocalBuilder, don't
4708 leave it in after returning it.
4709 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
4711 2006-08-06 Marek Safar <marek.safar@seznam.cz>
4713 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
4716 2006-08-03 Raja R Harinath <rharinath@novell.com>
4718 Fix cs0146-3.cs and cs0146-4.cs.
4719 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
4720 enclosing types don't depend on the current type.
4722 2006-08-02 Raja R Harinath <rharinath@novell.com>
4725 * class.cs (TypeContainer.DoDefineMembers): Use
4726 FindBaseMemberWithSameName on Parent, since we're interested in
4727 whether we hide inherited members or not.
4728 (FindBaseMemberWithSameName): Make slightly more robust.
4730 Fix the non-generic testcase from #77396
4731 * decl.cs (DeclSpace.DeclContainer): Remove override.
4733 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
4734 declspaces for doppelgangers too.
4735 (UsingEntry): Implement IResolveContext.
4736 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
4737 'this' as the resolve context.
4738 (LocalAliasEntry): Likewise.
4740 Implement parts of #77403
4741 * roottypes.cs (RootDeclSpace): New. Used to represent the
4742 toplevel declaration space. Each namespace declaration introduces
4743 a "partial" root declaretion space.
4744 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
4745 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
4746 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
4747 from 'current_namespace.SlaveDeclSpace'.
4748 (namespace_declaration): Likewise.
4749 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
4750 check. It can't happen now.
4751 * decl.cs (DeclSpace.LookupType): Likewise.
4752 * driver.cs (MainDriver): Sanity check.
4754 2006-08-01 Raja R Harinath <rharinath@novell.com>
4756 * decl.cs (DeclSpace.FindNestedType): Remove.
4757 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
4758 LookupTypeContainer to get the container of the nested type.
4759 * class.cs (TypeContainer.FindNestedType): Make non-override.
4761 2006-07-31 Raja R Harinath <rharinath@novell.com>
4763 * decl.cs (DeclSpace.PartialContainer): Move field from ...
4764 * class.cs (TypeContainer.PartialContainer): ... here.
4765 (TypeContainer.AddBasesForPart): New helper.
4766 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
4768 * cs-parser.jay (current_class): Convert to DeclSpace.
4769 (struct_declaration, interface_declaration, class_declaration):
4770 Use AddBasesForPart instead of .Bases directly.
4771 * const.cs, iterators.cs: Update to changes.
4773 2006-07-28 Raja R Harinath <rharinath@novell.com>
4775 * class.cs (TypeContainer.AddMemberType): Rename from
4777 (TypeContainer.AddMember): Rename from AddToMemberContainer.
4778 (AddTypeContainer): New. Combine AddClassOrStruct and
4780 (AddPartial): Update. Add 'is_partial' argument.
4781 * roottypes.cs: Update to changes.
4782 * cs-parser.jay (push_current_class): New helper for handling
4783 current_container and current_class.
4784 (struct_declaration, interface_declaration, class_declaration):
4787 2006-07-26 Raja R Harinath <rharinath@novell.com>
4789 * roottypes.cs: Rename from tree.cs.
4791 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
4792 * tree.cs (Tree, ITreeDump): Remove types.
4793 * rootcontext.cs (tree, Tree): Remove fields.
4794 (root, ToplevelTypes): New.
4795 * *.cs: Update to rename.
4797 * tree.cs (Tree.RecordDecl): Remove.
4798 (RootTypes.AddToTypeContainer): Record the toplevel type in its
4800 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
4802 2006-07-23 Raja R Harinath <harinath@gmail.com>
4804 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
4805 DoFlowAnalysis and OmitStructFlowAnalysis here.
4806 (ec.With): Rename from WithUnsafe and generalize.
4807 (ec.WithCheckState): Remove. All users can be handled by 'With'.
4808 (ec.WithFlowAnalyis): New.
4809 * ecore.cs, expression.cs, statement.cs: Update.
4811 2006-07-22 Raja R Harinath <harinath@gmail.com>
4813 * statement.cs (Block.ResolveMeta): Simplify slightly.
4815 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
4816 multiple boolean fields. Convert InUnsafe, constant_check_state,
4817 check_state to flags.
4818 (CheckState, ConstantCheckState): Update.
4819 (InUnsafe): New read-only property.
4820 (FlagsHandle): Rename from CheckStateHandle and convert to handle
4822 (WithUnsafe): New helper similar to WithCheckState.
4823 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
4824 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
4826 2006-07-21 Raja R Harinath <rharinath@novell.com>
4828 Make comparisons use the same IL irrespective of whether they're
4829 in a 'checked' or 'unchecked' context: one of the issues in #78899
4830 * codegen.cs (EmitContext.CheckState): Make read-only property.
4831 (EmitContext.ConstantCheckState): Likewise.
4832 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
4833 helper that implement a save/restore stack for CheckState
4834 values. This is the only way to change check-state.
4835 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
4836 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
4837 (CheckedExpr.EmitBranchable): New forwarding method.
4838 (UnCheckedExpr): Likewise.
4839 * statement.cs (Block.ResolveMeta): Use WithCheckState.
4840 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
4841 (Checked.Resolve, checked.DoEmit): Likewise.
4843 2006-07-20 Miguel de Icaza <miguel@novell.com>
4845 * anonymous.cs: Cache the resolved anonymous delegate, and return
4846 this so that the ResolveTopBlock is only triggered once, not
4849 Currently we trigger ResolvetopBlock twice due to a first pass of
4850 argument check compatibility, and a second pass that does the
4853 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4855 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
4857 * rootcontext.cs (Reset): Add helper_classes.
4859 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4862 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
4865 2006-07-13 Miguel de Icaza <miguel@novell.com>
4867 * statement.cs (Lock): Handle expressions of type
4868 TypeManager.null_type specially. Fixes #78770
4870 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4872 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
4875 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4877 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
4878 for accessors as well.
4879 * ecore.cs (EventExpr): Add AccessorTable.
4881 2006-07-01 Marek Safar <marek.safar@seznam.cz>
4884 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
4885 for CS0122 where appropriate.
4886 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
4888 (Filter): Assembly can be null in the case of top level attributes.
4890 2006-06-25 Marek Safar <marek.safar@seznam.cz>
4894 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
4895 is done at global level.
4897 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4899 A fix for #77002, Implemented TypeForwarder support.
4901 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
4902 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
4903 * typemanager.cs (): Add type_forwarder_attr_type.
4905 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4907 * report.cs: Add CS0469 warning.
4909 2006-06-21 Martin Baulig <martin@ximian.com>
4911 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
4912 the `try'-block, so we also report CS0016 etc. there.
4914 2006-06-21 Martin Baulig <martin@ximian.com>
4917 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
4919 2006-06-21 Martin Baulig <martin@ximian.com>
4921 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
4922 also report CS1686 for parameters.
4924 2006-06-21 Martin Baulig <martin@ximian.com>
4926 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
4927 instead of an error if the value is not implicitly convertible to
4928 the switch types; fixes #77964.
4930 2006-06-21 Raja R Harinath <rharinath@novell.com>
4933 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
4934 FieldBuilder is null.
4937 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
4938 'left' and 'right' before error-checking.
4940 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
4942 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
4944 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
4945 (FieldExpr.DoResolve): likewise.
4946 (PropertyExpr.InstanceResolve): likewise.
4947 (EventExpr.InstanceResolve): likewise.
4949 2006-06-04 Marek Safar <marek.safar@seznam.cz>
4951 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
4952 attribute applicable tests for attribute argument.
4954 2006-06-02 Raja R Harinath <rharinath@novell.com>
4957 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
4958 (Binary.OverloadResolve_PredefinedIntegral): New.
4959 (Binary.OverloadResolve_PredefinedFloating): New.
4960 (Binary.OverloadResolve_PredefinedString): New.
4961 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
4962 Follow the standard more closely, and treat numeric promotions in
4963 terms of overload resolution.
4964 (Binary.CheckShiftArguments): Simplify.
4966 2006-06-01 Raja R Harinath <rharinath@novell.com>
4968 * flowanalysis.cs (MyBitVector): Simplify representation.
4969 (MyBitVector.Clone): Avoid allocating BitArray.
4970 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
4971 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
4972 (*): Update. Change all references to MyBitVector.And and
4973 MyBitVector.Or to &= and |=.
4975 2006-05-29 Raja R Harinath <rharinath@novell.com>
4978 * cs-parser.jay (formal_parameter_list): Extend the pattern below
4979 to param arguments too.
4981 2006-05-26 Miguel de Icaza <miguel@novell.com>
4983 * cs-parser.jay: Catch another parsing form for arglist being
4984 followed by other arguments. Fixes #78313.
4986 2006-05-24 Raja R Harinath <rharinath@novell.com>
4988 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
4989 checking of out parameters to ...
4990 (FlowBranchingToplevel.Merge): ... here.
4991 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
4992 set, propagate the origin upward, and only complain if there was
4994 (FlowBranchingException.AddContinueOrigin): Likewise.
4995 (FlowBranchingException.AddReturnOrigin): Likewise.
4996 (FlowBranchingException.AddGotoOrigin): Likewise.
4998 2006-05-23 Raja R Harinath <rharinath@novell.com>
5000 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
5001 unreachable, skip it.
5002 (FlowBranchingException.Merge): Always propagate jumps, even if
5003 the finally block renders subsequent code unreachable.
5005 2006-05-18 Raja R Harinath <rharinath@novell.com>
5008 * statement.cs (Goto.Resolve): Move responsibility for resolving
5009 'goto' to FlowBranching.AddGotoOrigin.
5010 (Goto.SetResolvedTarget): New. Callback to set the
5011 LabeledStatement that's the target of the goto.
5012 (Goto.DoEmit): Use Leave instead of Br when crossing an
5013 unwind-protect boundary.
5014 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
5015 LookupLabel and adjust to new semantics.
5016 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
5017 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
5018 Goto.SetResolvedTarget to update target.
5019 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
5020 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
5021 AddBreakOrigin & co. Delay propagation until ...
5022 (FlowBranchingException.Merge): ... this.
5024 * statement.cs (Block.Resolve): Always depend on flow-branching to
5025 determine unreachability. Kill workaround that originally emitted
5026 only one statement after an "unreachable" label (see infloop in
5029 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
5030 This is still "wrong", but anything better would probably need a
5031 multi-pass algorithm.
5032 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
5033 usage vector. Force current usage vector to be reachable, to
5034 optimistically signify backward jumps.
5035 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
5037 (FlowBranchingLabeled.Merge): New. If no backward jump was
5038 detected, return the original salted-away usage vector instead,
5039 updated with appropriate changes. Print unreachable warning if
5041 * statement.cs (Block.Resolve): Don't print unreachable warning on
5042 a labeled statement.
5044 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
5046 * driver.cs: Pass filename without path to AssemblyBuilder's
5047 AddResourceFile. Fixes bug #78407.
5049 2006-05-17 Raja R Harinath <rharinath@novell.com>
5051 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
5052 * flowanalysis.cs (FlowBranchingLabeled): ... here.
5053 (FlowBranching.MergeChild): Overwrite
5054 reachability information from Labeled branchings too.
5056 2006-05-16 Raja R Harinath <rharinath@novell.com>
5058 * statement.cs (Goto.Resolve): Merge jump origins here ...
5059 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
5061 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
5062 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
5063 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
5064 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
5066 * statement.cs (Goto.Resolve): ... not here.
5067 (Goto.Emit): Remove CS1632 check.
5069 2006-05-14 Marek Safar <marek.safar@seznam.cz>
5071 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
5074 2006-05-11 Raja R Harinath <rharinath@novell.com>
5076 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
5077 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
5078 (FlowBranchingException.Label): Likewise.
5080 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
5082 (MyBitVector.Or): Use it to avoid losing information (Count).
5083 (FlowBranching.MergeOrigins): Likewise.
5085 * flowanalysis.cs (UsageVector.IsDirty): Remove.
5086 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
5087 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
5088 (UsageVector.ToString): Simplify.
5089 (UsageVector.MergeSiblings): Move here from ...
5090 (FlowBranching.Merge): ... here.
5091 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
5094 2006-05-10 Raja R Harinath <rharinath@novell.com>
5096 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
5097 null bitvector is treated as all-true.
5099 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
5100 (MyBitVector): Rationalize invariants. 'vector != null' implies
5101 that we have our own copy of the bitvector. Otherwise,
5102 'InheritsFrom == null' implies all inherited bits are true.
5104 2006-05-09 Marek Safar <marek.safar@seznam.cz>
5106 * statement.cs (LocalInfo): Add IsConstant.
5107 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
5108 local variable for constants.
5110 2006-05-09 Raja R Harinath <rharinath@novell.com>
5112 * flowanalysis.cs (MyBitVector.Empty): New.
5113 (MyBitVector): Don't allow InheritedFrom to be null.
5114 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
5115 (UsageVector, FlowBranching): Update to changes.
5117 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
5118 recursion. The 'Parent == null' condition isn't sufficient for
5120 (FlowBranching.AddBreakOrigin): Likewise.
5121 (FlowBranching.AddContinueOrigin): Likewise.
5122 (FlowBranching.AddReturnOrigin): Likewise.
5123 (FlowBranching.StealFinallyClauses): Likewise.
5124 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
5125 (FlowBranching.CheckOutParameters): Likewise.
5126 (FlowBranchingToplevel): Terminate all the above recursions here.
5127 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
5128 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
5130 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
5132 (FlowBranchingToplevel): New. Empty for now.
5133 (FlowBranching.MergeTopBlock): Update.
5134 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
5135 branching for the anonymous delegate.
5136 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
5138 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
5139 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
5140 information at the start of the merge. Reorganize.
5142 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5144 * class.cs (MethodData.Define): Method cannot implement interface accessor.
5146 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5148 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
5149 to newly introduced ctor.
5151 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
5152 message to one place.
5153 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
5156 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5158 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
5160 * ecore.cs (Expression.ResolveAsConstant): Updated.
5162 * statement.cs (ResolveMeta): Updated.
5164 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5166 * cs-parser.jay: __arglist cannot be used in initializer.
5168 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5171 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
5174 2006-05-05 Raja R Harinath <rharinath@novell.com>
5176 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
5177 (LabeledStatement): Add 'name' parameter.
5178 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
5179 (Block.AddLabel): Update to changes.
5180 * cs-parser.jay (labeled_statement): Likewise.
5182 * flowanalysis.cs (BranchingType.Labeled): New.
5183 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
5184 (FlowBranchingLabeled): New. Does nothing for now, but will
5185 eventually handle 'goto' flows.
5186 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
5187 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
5188 that's terminated ...
5189 (Block.Resolve): ... here.
5191 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
5192 (UsageVector.MergeFinallyOrigins): Likewise.
5193 (FlowBranching.InTryOrCatch): Likewise.
5194 (FlowBranching.AddFinallyVector): Likewise.
5195 (FlowBranchingException): Update to changes.
5198 * statement.cs (Return.Resolve): Move error checking to ...
5199 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
5200 (FlowBranchingException): Handle return origins like break and
5202 (FlowBranching.UsageVector.CheckOutParameters): Remove.
5204 2006-05-04 Marek Safar <marek.safar@seznam.cz>
5207 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
5210 2006-05-04 Marek Safar <marek.safar@seznam.cz>
5213 * class.cs (MethodData.Define): Do public accessor check only when method
5214 implements an interface.
5216 2006-05-04 Raja R Harinath <rharinath@novell.com>
5218 Remove special handling of 'break'
5219 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
5220 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
5221 (UsageVector.Break): Remove.
5222 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
5224 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
5226 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
5227 UsageVector.Breaks (). Don't set NeedsReturnLabel.
5229 2006-05-03 Marek Safar <marek.safar@seznam.cz>
5232 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
5233 be the interface member.
5235 2006-05-03 Marek Safar <marek.safar@seznam.cz>
5238 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
5239 for emitting small (int) values.
5241 2006-05-03 Raja R Harinath <rharinath@novell.com>
5244 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
5245 control-flow passes through the 'finally' after merging-in all the
5246 control-flows from 'try' and the 'catch' clauses.
5248 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
5249 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
5250 always true at the only non-recursive entry point.
5251 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
5252 FlowBranchingBreakable.
5253 (FlowBranchingLoop): Remove.
5254 * statement.cs (Return.DoResolve): Update to changes.
5257 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
5258 (FlowBranching.CreateBranching): Handle it: create a
5259 FlowBranchingContinuable.
5260 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
5261 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
5262 except that it handles the 'continue' command.
5263 (FlowBranching.UsageVector.MergeOrigins): Rename from
5265 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
5266 except that it overrides AddContinueOrigin.
5267 (FlowBranchingException): Override AddContinueOrigin, similar to
5269 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
5270 Create a new branching around the embedded statement.
5271 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
5272 control flow after the embedded statement.
5273 (Continue.Resolve): Move all error checking to AddContinueOrigin.
5275 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
5276 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
5277 FlowBranchingBreakable.
5278 (FlowBranchingSwitch): Remove.
5281 * statement.cs (Break.Resolve): Simplify. Move responsibility for
5282 error reporting to ...
5283 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
5284 Rename from 'AddBreakVector'. Add new location argument. Return
5285 a bool indicating whether the 'break' crosses an unwind-protect.
5286 (FlowBranchingException.AddBreakOrigin): Add.
5287 (FlowBranchingException.Merge): Propagate 'break's to surrounding
5288 flowbranching after updating with the effects of the 'finally'
5290 (FlowBranchingBreakable): New common base class for
5291 FlowBranchingLoop and FlowBranchingSwitch.
5293 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
5295 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
5297 2006-05-02 Raja R Harinath <rharinath@novell.com>
5299 * statement.cs (Do.Resolve): If the loop is infinite, set the
5301 (While.Resolve, For.Resolve): Set a barrier after the embedded
5302 statement. There's no direct control flow that goes from the end
5303 of the embedded statement to the end of the loop.
5304 * flowanalysis.cs (FlowBranching.Infinite): Remove.
5305 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
5306 above ensure that the reachability is correctly computed.
5308 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
5309 (UsageVector.MergeBreakOrigins): If the current path is
5310 unreachable, treat it as if all parameters/locals are initialized.
5311 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
5312 infinite loops before merging-in break origins.
5314 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
5315 (Reachability.Reachable): Split part into ...
5316 (Reachability.Unreachable): ... this. Simplify.
5317 (Reachability.IsUnreachable): Use 'Unreachable' instead.
5319 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
5320 (Reachability.SetThrowsSometimes): Likewise.
5321 (FlowBranchingBlock.MergeTopBlock): Don't compare against
5322 TriState.Always, use corresponding property.
5323 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
5324 (Block.Resolve): Likewise. Remove some redundant checks.
5326 2006-05-02 Raja R Harinath <harinath@gmail.com>
5328 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
5329 (Reachability.Meet): Don't bother checking AlwaysThrows --
5330 barrier is always set.
5331 (FlowBranchingBlock.Merge): Likewise.
5333 2006-05-01 Raja R Harinath <harinath@gmail.com>
5335 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
5336 checks for unreachable.
5338 2006-05-01 Marek Safar <marek.safar@seznam.cz>
5341 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
5343 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
5344 whether field is really assigned.
5346 2006-04-30 Raja R Harinath <harinath@gmail.com>
5348 * flowanalysis.cs (Reachability): Make 4-argument constructor
5350 (Reachability.Meet): Rename from 'And'. Remove static variant.
5351 (Reachability.Always): Rename from the highly misleading
5352 'Reachability.Never'.
5353 (FlowBranching.Merge): Update to changes. Mark an impossible
5354 situation with a 'throw'.
5355 (*): Update to changes.
5357 2006-04-29 Raja R Harinath <harinath@gmail.com>
5359 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
5361 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
5362 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
5363 (*): Update to changes.
5364 * statement.cs: Update to changes.
5366 2006-04-28 Marek Safar <marek.safar@seznam.cz>
5369 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
5371 2006-04-28 Raja R Harinath <harinath@gmail.com>
5373 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
5376 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
5377 argument to two arguments: an usage-vector and a bool. Move call
5378 to FlowBranching.Merge () ...
5379 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
5381 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
5382 handling of loop and switch reachability to ...
5383 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
5385 2006-04-27 Raja R Harinath <harinath@gmail.com>
5387 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
5388 handling to FlowBranchingLoop.InLoop.
5389 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
5391 2006-04-26 Marek Safar <marek.safar@seznam.cz>
5394 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
5395 anonymous method is allowed from AnonymousContainer here.
5397 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
5399 2006-04-24 Raja R Harinath <rharinath@novell.com>
5402 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
5404 2006-04-23 Marek Safar <marek.safar@seznam.cz>
5407 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
5408 (DoubleConstant.Reduce): Ditto.
5410 2006-04-23 Raja R Harinath <rharinath@novell.com>
5412 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
5413 Remove 'lvalue_right_side' argument. Move parts to ...
5414 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
5415 (LocalVariable.DoResolveLValue): ... these.
5417 2006-04-21 Raja R Harinath <rharinath@novell.com>
5420 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
5421 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
5422 (LocalVariableReference.DoResolveBase): Use it to implement new
5424 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
5425 (Argument.Resolve): Simplify. Move CS1510 check ...
5426 * ecore.cs (Expression.ResolveLValue): ... here.
5427 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
5428 (PropertyExpr.DoResolveLValue): Likewise.
5429 (FieldExpr.Report_AssignToReadonly): Likewise.
5430 (FieldExpr.DoResolve): Add 'out_access' argument. Use
5431 LValueMemberAccess or LValueMemberOutAccess on instance depending
5433 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
5434 DoResolve as appropriate.
5436 2006-04-20 Raja R Harinath <rharinath@novell.com>
5439 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
5440 implicit conversions on 'out' and 'ref' arguments.
5442 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
5443 improve clarity. Remove dead code.
5446 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
5447 (Catch.Resolve): Resolve VarBlock if it exists.
5449 2006-04-19 Miguel de Icaza <miguel@novell.com>
5451 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
5452 twice, this was some residual code, the enumerator was emitted
5453 properly in the two branche of if later.
5455 2006-04-19 Raja R Harinath <rharinath@novell.com>
5457 * expression.cs (Cast.ResolveLValue): Remove. The result of a
5458 cast is never an lvalue.
5459 (Cast.DoResolve, Cast.ResolveRest): Combine.
5460 (Argument.Emit): Simplify slightly. Move 'Expr is
5461 IMemoryLocation' check ...
5462 (Argument.Resolve): ... here.
5463 (Argument.Error_LValueRequired): Remove. Inline into only user.
5465 Simplifications. Fix cs0191-2.cs
5466 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
5467 CS1649 and CS1651 to ...
5468 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
5469 the actual selection of the error code and message to a lookup
5470 table. Add a dummy return value to simplify callsites.
5471 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
5472 readonly fields of other instances of the same type. Move CS0197
5474 * expression.cs (Argument.Resolve): ... here. Simplify code.
5475 Ensure that ec.InRefOutArgumentResolving is only set during LValue
5476 resolution of an out or ref argument. The code simplification
5477 above uses this invariant.
5479 2006-04-18 Raja R Harinath <rharinath@novell.com>
5481 Possibly fix #77752. Fix cs1690-[4-7].cs.
5482 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
5483 CheckMarshallByRefAccess. Drop parameter.
5484 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
5486 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
5488 * report.cs (AllWarnings): Add CS1690.
5489 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
5491 (LocalVariableReference.DoResolveBase): Update.
5493 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5495 * class.cs (MethodOrOperator): Moved common parts from method class.
5496 detect obsolete attributes.
5497 (Method.Define): Simplified as it reuses code from base.
5498 (Constructor.ValidAttributeTargets): Fixed issue found during
5500 (Destructor.ValidAttributeTargets): Fixed issue found during
5502 (Operator): Finished refactoring set off by #78020. Operator class is now
5503 ordinary method class.
5505 * anonymous.cs: Updated.
5507 * decl.cs (DeclSpace): Add IsGeneric
5509 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5511 * class.cs (Constructor.Emit): Don't emit the attributes twice.
5513 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5515 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
5516 detect obsolete attributes.
5517 (Method.CreateEmitContext): Moved to MethodOrOperator.
5519 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5522 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
5523 customized exception to make crash detection easier.
5524 (MethodOrOperator): Started to work on new base class for methods and
5526 (Method): Derives from MethodOrOperator.
5527 (Constructor.Emit): Emits its own attributes.
5528 (AbstractPropertyEventMethod.Emit): Ditto.
5529 (Operator): Derives from MethodOrOperator, will refactor fully in extra
5531 (Operator.Emit): It's temporary more tricky than should be.
5533 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
5535 * report.cs (InternalErrorException): Add ctor with inner exception.
5537 2006-04-08 Marek Safar <marek.safar@seznam.cz>
5540 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
5543 2006-04-07 Marek Safar <marek.safar@seznam.cz>
5546 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
5549 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5551 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
5552 attribute is present and Guid not.
5553 (Interface.ApplyAttributeBuilder): Ditto.
5555 * attribute.cs: Add error message.
5557 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5561 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
5562 sources (it's composite) so hold them in extra array as they are used in
5563 Emit phase only. It worked in the previous versions by mistake.
5564 (Attribute.Emit): Emit attribute for more owners when exist.
5566 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
5567 it has now different behaviour.
5569 2006-04-04 Marek Safar <marek.safar@seznam.cz>
5571 * constant.cs (Constant.IsDefaultInitializer): New method.
5573 * class.cs: Updated.
5575 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
5576 re-initialize default values. It saves KBs almost for every assembly.
5577 Thanks Zoltan for the idea.
5578 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
5579 (ArrayCreation.DoResolve): Resolve only once.
5580 (ArrayCreation.Emit): Emit static initializer only when it is faster.
5581 (ArrayCreation.GetAttributableValue): Cope with optimized values.
5583 2006-04-03 Zoltan Varga <vargaz@gmail.com>
5585 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
5588 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5590 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
5591 in an embedded statement too.
5593 2006-04-01 Raja R Harinath <rharinath@novell.com>
5596 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
5598 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5602 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
5605 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
5607 2006-03-31 Marek Safar <marek.safar@seznam.cz>
5609 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
5612 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
5613 LocalTemporary change.
5615 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
5617 (ClassOrStruct.DefineFieldInitializers): Implemented static field
5618 initializers optimization.
5619 (ClassOrStruct.TypeAttr): Moved from modifiers.
5620 (Constructor.CheckBase): Don't crash when static ctor has parameters.
5621 (FieldBase.ResolveInitializer): Resolves initializer.
5622 (FieldBase.HasDefaultInitializer): New property.
5624 * cs-parser.jay: Removed message.
5626 * expression.cs (CompilerGeneratedThis): New specialization.
5628 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
5630 2006-03-28 Marek Safar <marek.safar@seznam.cz>
5632 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
5634 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5636 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
5637 be now EnumConstants only.
5639 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5641 * attribute.cs, driver.cs: Reset more caches.
5643 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5645 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
5647 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5649 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
5650 for easier reuse. Updated all overrides.
5651 (IntegralConstant): New base class for all integral constants.
5652 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
5653 of the constant range, report custom error.
5654 (UIntConstant.Reduce): Fixed uint conversion.
5656 * ecore.cs, literal.cs: Reduce updates.
5658 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5662 * class.cs (Constructor.Define): Removed extra if for default ctors.
5663 A patch from Atsushi Enomoto.
5665 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5667 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
5668 GetAttributableValue.
5670 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
5673 * convert.cs (ImplicitConversionRequired): Error message moved to
5676 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
5677 automatic implicit conversion of an output value.
5678 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
5680 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
5682 (TypeOf.GetAttributableValue): Add extra handling for object type.
5684 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
5685 special error message.
5687 2006-03-25 Marek Safar <marek.safar@seznam.cz>
5689 * class.cs (Constructor.Emit): Don't crash when struct ctor is
5691 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
5692 compatible with MS runtime.
5694 2006-03-23 Marek Safar <marek.safar@seznam.cz>
5696 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
5697 attribute arguments here.
5699 * class.cs (Indexer.Define): The check was moved to attribute class.
5701 2006-03-22 Marek Safar <marek.safar@seznam.cz>
5703 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
5704 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
5707 2006-03-22 Raja R Harinath <rharinath@novell.com>
5709 Support ParameterDefaultValueAttribute in gmcs. Also applied to
5710 mcs to keep code differences small.
5711 * attribute.cs (Attribute.GetParameterDefaultValue): New.
5712 * typemanager.cs (parameter_default_value_attribute_type): New.
5713 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
5716 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5718 * expression.cs (StringConcat.Append): Reverted back to no warning state.
5720 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5722 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
5724 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
5727 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
5729 * doc-bootstrap.cs : fix build.
5731 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5733 * expression.cs (StringConcat.Append): Issue a warning when empty string
5736 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5738 * assign.cs (CompoundAssign.ResolveSource): Removed.
5740 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
5743 * class.cs (TypeContainer.FindMethods): Removed.
5744 (TypeContainer.CheckMemberUsage): Made static.
5746 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
5748 * constant.cs (CheckRange): Removed unused type argument.
5749 (CheckUnsigned): Removed unused type argument.
5751 * cs-parser.jay: Updated after MemberAccess clean up.
5752 Uses Length for empty string test.
5754 * cs-tokenizer.cs: Uses Length for empty string test.
5755 (IsCastToken): Made static.
5756 (is_hex): Made static.
5757 (real_type_suffix): Made static.
5759 * decl.cs (SetupCache): Made static.
5760 (OnGenerateDocComment): Removed unused ds argument.
5762 * delegate.cs (VerifyDelegate): Removed unused argument.
5764 * doc.cs: Uses Length for empty string test.
5766 * driver.cs: Uses Length for empty string test.
5768 * enum.cs (IsValidEnumType): Made static
5770 * expression.cs (EnumLiftUp): Removed unused argument.
5771 (ResolveMethodGroup): Ditto.
5772 (BetterConversion): Ditto.
5773 (GetVarargsTypes): Ditto.
5774 (UpdateIndices): Ditto.
5775 (ValidateInitializers): Ditto.
5776 (MemberAccess.ctor): Ditto.
5777 (GetIndexersForType): Ditto.
5779 * flowanalysis.cs: (MergeFinally): Removed unused argument.
5781 * iterators.cs: Updated after MemberAccess clean up.
5783 * location.cs: Uses Length for empty string test.
5785 * namespace.cs: Uses Length for empty string test.
5787 * report.cs (CheckWarningCode): Made static.
5789 * statement.cs (LabeledStatement): Removed unused argument.
5791 * typemanager.cs (FilterNone): Removed.
5793 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5795 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
5798 * class.cs: Updated.
5800 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5802 * cs-parser.jay.cs: __arglist is not allowed for delegates.
5804 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5808 * expression.cs (VerifyArgumentsCompat): Reverted to double error
5809 reporting, it's more tricky than I thought.
5811 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5815 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
5817 (AnonymousMethod.ImplicitStandardConversionExists): New method.
5818 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
5819 Add more error reporting; Fixed issue with params.
5821 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
5823 * cs-parser.jay: AnonymousMethod requires host container.
5825 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
5827 2006-03-18 Raja R Harinath <harinath@gmail.com>
5829 * class.cs: Change 'TypeContainer ds' constructor argument to
5830 'DeclSpace parent'. Some classes were missed below due to
5831 different naming convention.
5833 * class.cs (MemberCore.Parent): Delete. This makes the
5834 ParentContainer changes below enforceable by the compiler.
5836 Treat pointers to enclosing declaration space as 'DeclSpace', not
5838 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
5839 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
5841 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
5843 (Block.AddThisVariable): Likewise.
5844 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
5845 (AbstractPropertyEventMethod.Emit): Likewise.
5846 (AbstractPropertyEventMethod.EmitMethod): Likewise.
5847 (GetMethod.Define, SetMethod.Define): Likewise.
5848 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
5849 (DelegateMethod.EmitMethod): Likewise.
5851 Fix regression test-partial-13.cs.
5852 Rationalize use of PartialContainer. Ensure that the partial
5853 class semantics can be tied to type-correctness, i.e., any
5854 violation will cause a compile error.
5855 * class.cs, const.cs: Access all fields that belong to class
5856 TypeContainer via ParentContainer. Arguments of EmitContexts and
5857 Resolve()-like functions still use 'Parent'.
5859 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
5860 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
5861 (PropertyMethod.CheckModifiers): Remove unused argument.
5862 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
5865 2006-03-17 Raja R Harinath <harinath@gmail.com>
5867 Make semantics of PartialContainer simpler.
5868 * decl.cs (DeclSpace.IsPartial): Remove.
5869 * class.cs (TypeContainer.IsPartial): Likewise.
5870 (TypeContainer..ctor): Set PartialContainer to point to self.
5871 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
5872 (TypeContainer.FindNestedType): Likewise.
5873 (MemberCore.ParentContainer): Simplify. Remove deprecation.
5875 2006-03-17 Marek Safar <marek.safar@seznam.cz>
5877 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
5879 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5881 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
5884 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5886 * class.cs (Operator.Define): An error for base conversion was not
5889 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
5891 * iterator.cs : yield break is allowed in try statement which has
5892 catch clauses. Fixed bug #77767.
5894 2006-03-13 Marek Safar <marek.safar@seznam.cz>
5896 A fix for #77593, #77574.
5898 * class.cs (MethodCore.CheckBase): Another if for operator.
5900 2006-03-09 Marek Safar <marek.safar@seznam.cz>
5902 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
5905 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
5906 (DelegateCreation.ImplicitStandardConversionExists): New method for just
5909 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
5912 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
5913 Updated after another emitcontext usage was clean up. It should help us to
5914 synchronize with gmcs easier.
5916 2006-03-04 Marek Safar <marek.safar@seznam.cz>
5920 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
5921 (Event.Define): ditto
5922 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
5924 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
5925 Removed redundant code and set NewSlot for Invoke method too.
5927 * parameter.cs (Parameters.ctor): Add custom, type ctor.
5928 (Parameters.MergeGenerated): New method. Use this method when you merge
5929 compiler generated argument with user arguments.
5931 2006-03-03 Marek Safar <marek.safar@seznam.cz>
5933 * attribute.cs (ResolveAsTypeTerminal): Removed.
5935 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
5936 specialization for predefined types; 30% speed up.
5937 Finally placed obsolete check to right place.
5938 (Expression.ResolveType): Removed.
5940 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
5941 Updated after ResolveType was removed.
5943 * expression.cs (Cast.ctor): Check void cast.
5944 (Binary.ResolveAsTypeTerminal): Is never type.
5945 (Conditional.ResolveAsTypeTerminal): Is never type.
5947 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
5949 2006-03-01 Raja R Harinath <rharinath@novell.com>
5952 * expression.cs (ParameterReference.DoResolveBase): Change return
5954 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
5958 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
5961 * typemanager.cs (GetFullNameSignature): Don't nullref on
5962 protected accessors.
5964 2006-02-27 Marek Safar <marek.safar@seznam.cz>
5966 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
5967 these two separated members to simplify the code.
5968 (Attribute.Resolve): Refactored to use new fields and methods.
5969 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
5970 implemented obsolete attribute checking.
5971 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
5972 implemented obsolete checking again. It look line never ending quest ;-)
5973 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
5975 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
5977 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
5979 *class.cs (Property.Define): Add RegisterProperty call.
5981 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
5982 argument groups (only 2).
5984 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
5985 encoding expression to arguments.
5986 (Expression.ExprClassToResolveFlags): Just turned to property.
5988 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
5989 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
5990 optimized as well as implemented support for zero-length attributes.
5992 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
5993 Add caching of PropertyInfo's.
5995 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5997 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
5998 error multiple times.
6000 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6002 New partial class implementation.
6003 A fix for #77027, #77029, #77403
6005 * attribute.cs (Attributable): Made attributes protected.
6007 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
6008 the replacements of ClassPart and PartialContainer.
6009 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
6010 (TypeContainer.AddInterface): Ditto.
6011 (TypeContainer.AddPartial): The main method for partial classes. It checks
6012 for errors and merges ModFlags and attributes. At the end class is added to
6014 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
6016 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
6017 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
6018 from the rest of partial classes.
6019 (TypeContainer.GetClassBases): Simplified.
6020 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
6022 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
6023 (TypeContainer.HasExplicitLayout): Uses Flags now.
6024 (PartialContainer): Removed.
6025 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
6026 (StaticClass): Was merged with Class.
6027 (Class.GetClassBases): class and static class bases are verified here.
6028 (Class.TypeAttr): Added static attributes when class is static.
6029 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
6030 (MemberBase): In some cases we need to call parent container for partial
6031 class. It should be eliminated but it's not easy now.
6033 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
6035 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
6036 partial classed to accumulate class comments.
6037 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
6039 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
6041 * driver.cs (MainDriver): Tree.GetDecl was removed.
6043 * modifiers.cs (Modifiers): Add partial modifier.
6045 * tree.cs (Tree.decl): Removed.
6046 (RootTypes): Started to use this class more often for root types
6049 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6053 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
6054 external interface does not have an attribute.
6056 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6058 Another prerequisites for new partial classs implementation.
6060 * attribute.cs (Attribute.Equal): Implemented.
6061 (Attribute.Emit): Changed as attributes can be applied more than twice.
6062 (Attributes.Emit): Check for duplicate attributes here.
6064 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
6065 as a parameter, clean-up.
6067 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6071 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
6072 contains obsolete attribute check which can in some cases look for base
6073 type of current class which is not initialized yet.
6074 (TypeContainer.BaseType): Replacement of ptype.
6076 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
6078 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6080 First of prerequisites for new partial classs implemention.
6082 * attribute.cs (Attributable): Extended by ResolveContext;
6083 Attributes finally have correct context for resolving in all cases.
6084 (AttachTo): Attribute owner is assigned here.
6086 * codegen.cs (IResolveContext): Introduce new interface to hold
6087 all information needed in resolving phase.
6088 (EmitContext): Implements IResolveContext; more clean-up needed here.
6090 * decl.cs (MemberCore): Implemented IResolveContext.
6092 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
6093 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
6094 parameter.cs, statement.cs, tree.cs, typemanager.cs:
6095 Refactored to use new IResolveContext instead of EmitContext; cleanup
6097 2006-02-06 Miguel de Icaza <miguel@novell.com>
6099 * codegen.cs (EmitScopeInitFromBlock): check here the
6100 capture_context, there is no need to make two calls to the
6103 * anonymous.cs: Add some debugging messages that might help me
6104 track other instances of this problem in the future (the
6105 regression of test 467).
6107 * cs-parser.jay: track the variable block, as we need to initalize
6108 any captured variables declared in this block for the "catch"
6109 portion of the "Try" statement.
6111 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
6112 scope initialization for captured variables.
6114 Also, move the emit for the variables after the block location has
6117 2006-02-06 Marek Safar <marek.safar@seznam.cz>
6119 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
6121 2006-02-02 Miguel de Icaza <miguel@novell.com>
6123 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
6124 commit yesterday, the initialization for the roots is necessary.
6125 What is not necessary is the scope activation.
6127 2006-02-02 Raja R Harinath <rharinath@novell.com>
6129 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
6130 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
6132 (Argument.Resolve): Remove CS0206 checks.
6134 2006-02-01 Miguel de Icaza <miguel@novell.com>
6136 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
6137 scopes for all the roots, the scopes will now be emitted when the
6138 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
6140 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
6141 code. This reduces a lot of existing cruft.
6143 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
6144 that the ScopeInfo is generated as we enter the scope, not at the
6145 time of use, which is what we used to do before.
6147 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
6148 every time a Block is about to be emitted if we have a
6151 2006-02-01 Raja R Harinath <rharinath@novell.com>
6153 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
6155 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
6157 * typemanager.cs (cons_param_array_attribute): Make private.
6158 (Reset): Set it to null.
6159 (InitCoreHelpers): Don't initialize it.
6160 (ConsParamArrayAttribute): New. Initialize it as needed.
6161 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
6163 2006-01-31 Miguel de Icaza <miguel@novell.com>
6165 * expression.cs: There might be errors reported during the
6166 selection of applicable methods. If there are errors, do not
6167 continue execution as it will lead the compiler to crash.
6169 2006-01-30 Miguel de Icaza <miguel@novell.com>
6171 * expression.cs: Member access is not allowed on anonymous
6172 methods. Fixes #77402.
6174 2006-01-30 Raja R Harinath <rharinath@novell.com>
6177 * cs-parser.jay (VariableDeclaration): Don't set
6178 current_array_type to null.
6179 (field_declaration, event_declaration, declaration_statement):
6180 Set it to null here.
6182 2006-01-28 Raja R Harinath <harinath@gmail.com>
6184 * typemanager.cs (GenericParameterPosition): New.
6187 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
6189 * doc.cs : To process "include" elements, first we should create
6190 another list than XmlNodeList, because it could result in node
6191 removal, which could result in that the XmlNodeList gives up
6194 (Also made code identical to gmcs again.)
6196 2006-01-25 Miguel de Icaza <miguel@novell.com>
6198 * ecore.cs: Introduce an error report that we were not catching
6199 before, if not silent, we must report the error. Gonzalo ran into
6202 2006-01-23 Miguel de Icaza <miguel@novell.com>
6204 A fix for bug: #76957
6206 * iterators.cs (MoveNextMethod.CreateMethodHost): call
6207 ComputeMethodHost before creating the method, this is a new
6210 * anonymous.cs (AnonymousContainer): Now we track all the scopes
6211 that this method references (RegisterScope). The actual scope
6212 where the method is hosted is computed with the ComputeMethodHost
6213 before we create the method.
6215 Moved the Deepest routine here.
6217 (AnonymousContainer.ComputeMethodHost): New routine used to
6218 compute the proper ScopeInfo that will host the anonymous method.
6220 (ScopeInfo): Deal with multiple roots. The problem was that we
6221 did not have a unique root where all ScopeInfos could be hanged
6222 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
6225 Remove AdjustMethodScope which is now computed at the end. Remove
6226 LinkScope which did a partial link, instead link all ScopeInfos
6227 before code generation from the new "LinkScopes" routine.
6229 Simplify all the Add* routines as they no longer need to maintain
6230 the tree, they just need to record that they are using variables
6233 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
6234 routines to produce the forest of ScopeInfo trees.
6236 * class.cs (TypeContainer.AppendMethod): This is just like
6237 AddMethod, but ensures that an interface implementation method
6238 (IEnumerable.XXX) is not inserted at the beginning of the queue of
6239 methods, but at the end.
6241 We use this functionality to ensure that the generated MoveNext
6242 method in the iterator class is resolved/emitted before the
6243 enumerator methods created.
6245 This is required because the MoveNext method computes the right
6246 ScopeInfo for the method. And the other methods will eventually
6247 need to resolve and fetch information computed from the anonymous
6250 2006-01-21 Raja R Harinath <harinath@gmail.com>
6251 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6254 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
6256 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
6257 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
6259 2006-01-18 Raja R Harinath <rharinath@novell.com>
6261 Fix #76656, cs0231-2.cs.
6262 * cs-parser.jay (formal_parameter_list): Make error case catch
6264 (parenthesized_expression_0): Add CS1026 check.
6265 (invocation_expression): Remove unused { $$ = lexer.Location }.
6267 2006-01-17 Raja R Harinath <rharinath@novell.com>
6270 * cs-parser.jay (statement_expression): Don't list out the
6271 individual statement-expressions. Convert syntax error into
6274 2006-01-16 Raja R Harinath <rharinath@novell.com>
6277 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
6278 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
6279 CheckIntermediateModification.
6280 (FieldExpr.DoResolve): Add new two-argument version that
6281 allows us to resolve the InstanceExpression as an lvalue.
6282 The one-argument variant is now just a wrapper.
6283 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
6284 Resolve the lhs as an lvalue if the it has a value type.
6285 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
6286 from Assign.DoResolve.
6287 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
6288 resolved as an lvalue.
6289 (PropertyExpr.DoResolve): Update.
6290 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
6291 has a value type. Move CS1612 check here from
6292 CheckIntermediateModification.
6293 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
6294 * expression.cs (EmptyExpression.OutAccess): New. Used as the
6295 'right_side' of a ResolveLValue on an 'out' argument.
6296 (EmptyExpression.LValueMemberAccess): New. Used as the
6297 'right_side' of a propagated ResolveLValue on a value type.
6298 (LocalVariableReference.DoResolveBase): Recognize
6299 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
6301 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
6302 EmptyExpression.Null.
6304 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
6306 * typemanager.cs : added IsGenericParameter(). In mcs it always
6308 * doc.cs : for generic parameters, use GenericParameterPosition,
6311 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
6313 * expression.cs: Fix Console.WriteLine ((this = x).foo);
6315 2006-01-12 Miguel de Icaza <miguel@novell.com>
6317 This fixes the problem where we used ldfld instead of ldflda to
6318 load the "THIS" pointer on captured parameters, when THIS is a
6319 value type. See bug #77205.
6321 * iterators.cs (CapturedThisReference.Emit): Pass false to
6322 EmitThis (we do not need the address).
6324 * codegen.cs (EmitThis): it needs to know whether we need the
6325 address of `this' or not. This is used by value types.
6327 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
6328 every other call passes false.
6330 2006-01-12 Raja R Harinath <rharinath@novell.com>
6333 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
6335 * expression.cs (Invocation.OverloadResolve): Update.
6336 (Invocation.DoResolve): Avoid double resolution of invocation.
6338 2006-01-11 Raja R Harinath <rharinath@novell.com>
6341 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
6342 unary negation of floating point types as 0-expr; negation cannot
6343 overflow in floating point types.
6346 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
6347 on operands of 'void' type.
6350 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
6351 and ExclusiveOr for boolean constants too.
6353 2006-01-09 Raja R Harinath <rharinath@novell.com>
6356 * expression.cs (Invocation.OverloadResolve): Replace reflected
6357 override methods with their base virtual methods, rather than
6359 * typemanager.cs (TypeManager.GetOverride): New.
6361 2006-01-05 Jb Evain <jbevain@gmail.com>
6363 * class.cs (Property.Define, Indexer.Define): do not tag the
6364 properties as SpecialName | RTSpecialName.
6366 2006-01-04 Miguel de Icaza <miguel@novell.com>
6368 * class.cs (MethodCore.IsDuplicateImplementation): This method was
6369 doing a low-level comparission of parameter types. It was lacking
6370 a check for __argslist.
6372 2005-12-30 Miguel de Icaza <miguel@novell.com>
6374 * expression.cs (ParameterReference.DoResolveBase): Allow
6375 reference parameters if they are local to this block.
6377 This allows the ref and out parameters of a delegate to be used in
6378 an anonymous method, for example:
6380 delegate void set (out int x);
6382 set s = delegate (out int x){
6386 This is used by functionality introduced late in the C# language.
6388 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
6389 method that take ref and out parameters.
6391 Fixes #77119 which was a late change in the spec.
6393 2005-12-23 Miguel de Icaza <miguel@novell.com>
6395 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
6396 parent if its the same scope. Fixes #77060.
6398 2005-12-21 Miguel de Icaza <miguel@novell.com>
6400 * driver.cs: Report the case of no source files and no -out:
6403 2005-12-20 Raja R Harinath <rharinath@novell.com>
6406 * expression.cs (ComposedCast.GetSignatureForError): Define.
6408 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6412 * namespace.cs (NamespaceEntry): Add extern_aliases as a
6413 ListDictionary, to contain the ExternAliasEntry entries (in
6414 addition to the NamespaceEntry.aliases hashtable). This field is
6415 shared between the original entry and its doppelganger (bodyless
6417 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
6418 extern_aliases field.
6419 (NamespaceEntry.Lookup): Move the IsImplicit check after the
6420 lookup in extern_aliases.
6422 2005-12-16 Raja R Harinath <rharinath@novell.com>
6425 * class.cs (TypeContainer.Mark_HasEquals): New.
6426 (TypeContainer.Mark_HasGetHashCode): New.
6427 (ClassPart): Override them.
6428 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
6431 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
6432 'parent' argument to the base constructor.
6434 Remove all mention of TypeContainer from decl.cs.
6435 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
6436 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
6437 (DeclSpace.DeclSpace): Likewise.
6438 (DeclSpace.DefineMembers): Remove unused argument.
6439 * cs-parser.jay (pop_current_class): Update to changes. Simplify
6440 debugging check -- we don't care if the debug code throws an
6441 InvalidCastException instead of an InternalErrorException.
6442 * class.cs (TypeContainer.DefineMembers): Update to changes.
6443 (TypeContainer.DoDefineMembers): Likewise.
6444 (TypeContainer.GetMethods): Likewise.
6445 (PropertyMember.Define): Likewise.
6446 (MemberBase.Parent): New property that forwards to
6447 MemberCore.Parent, but ensures that we get a TypeContainer.
6448 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
6449 (RootContext.PopulateTypes): Likewise. Remove special case code
6450 for !RootContext.StdLib: DefineMembers is idempotent.
6452 2005-12-14 Miguel de Icaza <miguel@novell.com>
6454 * convert.cs (ExplicitConversionCore): Check the return value from
6455 ExplicitConversionCore which can return null on failure. Fixes #76914
6457 2005-12-13 Marek Safar <marek.safar@seznam.cz>
6459 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
6461 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
6463 * doc.cs : The search for referenced namespace was insufficient to
6464 get global one as it used to do. Fixed bug #76965.
6466 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
6468 * doc.cs : check name in cref in the last phase that whether it is
6471 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6473 * cs-tokenizer.cs : reverted the latest change: it somehow broke
6476 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6478 * doc.cs : so it turned out that we cannot skip override check for
6479 interface members. Fixed bug #76954.
6481 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6483 * cs-tokenizer.cs : fixed bug #75984:
6484 - #warning and #error should not be handled when the source line
6486 - #line is not checked strictly when the source line is disabled.
6487 - #define and #undef is on the other hand checked strictly at any
6490 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
6492 * cs-tokenizer.cs : missing Location (actually, filename) in one of
6495 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6497 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
6499 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
6501 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
6502 (FieldBase.Initializer): Initializer is now optional.
6503 (EventField.Define): Only event field can have initializer.
6505 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
6507 * const.cs (Const): Reuse initializer.
6509 * cs-parser.jay: Updated after FieldBase changes.
6510 Added current_array_type to simplify array initializers.
6512 * ecore.cs (NullCast.IsDefaultValue): Implemented.
6514 * expression.cs, iterators.cs: Updated.
6516 * namespace.cs (NamespaceEntry): Made UsingFound private.
6518 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6520 * parameterCollection.cs: Obsolete, removed.
6521 * parser.cs: Obsolete, removed.
6523 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6526 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
6528 * enum.cs (Enum.Define): Set obsolete context here.
6530 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6533 - FindDocumentedMember() now expects 1) paramList as null
6534 when "we don't have to check the number of parameters" and
6535 2) Type.EmptyTypes when "there is no arguments".
6536 - Introduced FoundMember struct to hold the exact type which was
6537 used to find the documented member (the above change broke
6538 test-xml-044; it might be better just to use DeclaringType than
6539 what MS does, like this change does, but it depends on usage.)
6541 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6543 * doc.cs : documented member might be from DeclaringType for nested
6544 types. Fixed bug #76782.
6546 2005-12-03 Ben Maurer <bmaurer@ximian.com>
6548 * anonymous.cs: Have the param code handle leaving copies on the
6549 stack etc. Allows anonymous params to take part in the assignment
6550 code (++, +=, etc). Fixes bug #76550
6552 * expression.cs: Handle the prepare_for_load/leave_copy by passing
6553 it down to the anon code.
6555 * iterators.cs: Use dummy var here
6557 * codegen.cs: Handle new vars
6559 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6562 * class.cs (MethodData.Define): Set proper Obsolete context.
6564 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
6566 (FieldExpr.DoResolve): Ditto.
6568 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6571 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
6572 parent is not obsolete.
6574 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
6576 * doc.cs : (FindDocumentedMember) find parameterless members first
6577 and get CS0419 in the early stage. Fixed first case of bug #76727.
6579 2005-11-30 Marek Safar <marek.safar@seznam.cz>
6582 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
6583 no error was reported.
6585 *expression.cs (Binary.DoResolve): left can be null.
6587 2005-11-22 Marek Safar <marek.safar@seznam.cz>
6590 * class.cs (MethodData.Emit): Parameters should be labeled first.
6592 2005-11-21 Marek Safar <marek.safar@seznam.cz>
6595 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
6597 2005-11-18 Marek Safar <marek.safar@seznam.cz>
6599 * attribute.cs (AreParametersCompliant): Moved to Parameter.
6601 * class.cs (MethodCore): Parameter clean up.
6602 (IMethodData): Added ParameterInfo.
6603 (MethodData): Parameter clean up.
6604 (Indexer.Define): Parameter clean up.
6616 * typemanager.cs: Parameter clean up.
6618 * delegate.cs (Define): Get rid of duplicated code.
6620 * expression.cs (ParameterReference): Removed useless parameters
6622 (Invocation): Ditto.
6624 * parameter.cs (ParamsParameter): New class, params specialization.
6625 (ArglistParameter): Attemp to separate arglist.
6626 (Parameter): Refactored to be reusable and faster.
6627 (Parameter.Modifier): Made understandable.
6628 (Parameters): Changed to be used as a class for `this' assembly
6629 parameters. Refactored to use new specialized classes.
6631 * support.cs (ParameterData): Added Types property.
6632 (InternalParameters): Deleted.
6634 2005-08-20 Martin Baulig <martin@ximian.com>
6636 Merging this patch from GMCS to fix #75867.
6638 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
6639 scope if we don't already have it.
6641 2005-11-17 Martin Baulig <martin@ximian.com>
6644 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
6645 inherit the scope from our parent. Fixes #76653.
6647 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6649 * doc.cs : the previous patch does not actually fix the bug.
6650 PropertyInfo override check is now implemented and really fixed it.
6651 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
6653 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6655 * doc.cs : apply "override filter" also to properties.
6658 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6660 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
6661 no need to check overrides. For classes, omit those results from
6662 interfaces since they must exist in the class. Fixed bug #76726.
6664 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6666 * typemanager.cs : (GetFullNameSignature) differentiate indexers
6667 with different parameters. Fixed the second problem in #76685.
6669 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6671 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
6672 get expected 'protected' access in CheckValidFamilyAccess()).
6675 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6677 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
6678 Fixed bug #76705. CS1569 was incorrectly commented out.
6680 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6682 * doc.cs : use Invocation.IsOverride() to do real override check.
6683 * expression.cs : made Invocation.IsOverride() internal.
6685 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6687 * doc.cs : use TypeManager.FindMembers() instead of (possible)
6688 TypeBuilder.FindMembers() and filter overriden base members out.
6691 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6693 * doc.cs : ref/out parameters are represented as '@' (instead of
6694 '&' in type FullName). Fixed bug #76630 (additionally crefs).
6696 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6698 * doc.cs : when there was no '.' in cref to methods in doc comment,
6699 then parameters were missing in the output. Fixed bug #76691.
6701 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6703 * driver.cs : don't output docs when there is an error.
6706 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6709 Now it should detect indexers. Fixed primary concern in bug #76685.
6710 Fixed CS0419 message to not show the identical member signature in
6713 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6715 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
6716 instead of Type.FindMembers() since it does not handle events.
6719 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
6721 * codegen.cs: Fixed typo (speficied -> specified).
6723 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6726 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
6728 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6730 * attribute.cs: Changed error message.
6732 * cs-tokenizer.cs: One more check.
6734 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6736 * statement.cs (Block.Resolve): Ignore empty statement.
6738 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6740 * report.cs: Made error/warning methods more strict to avoid
6743 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
6744 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
6745 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
6746 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
6748 2005-11-08 Marek Safar <marek.safar@seznam.cz>
6750 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
6751 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
6753 * class.cs (TypeContainer.IsComImport): New property.
6754 (Constructor.Define): Create proper ctor for ComImport types.
6756 * expression.cs (New.CheckComImport): Fixed.
6758 2005-11-07 Miguel de Icaza <miguel@novell.com>
6760 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
6761 that a parameter has been captured does not mean that we do not
6762 have to do the rest of the processing. This fixes the second part
6763 of #76592. If there was another anonymous method capturing
6764 values in the past, the Scope would never be set for the second
6765 method that captured the same parameter.
6767 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
6768 properly manipulate the stack. Second part of fix for #76592.
6770 * expression.cs (New): Add support for invoking "new" on
6771 interfaces that have been flagged with the ComImport attribute and
6772 the CoClass. Fixes #76637
6774 * statement.cs (Try.DoEmit): When a variable is captured, do not
6775 try to emit the vi.LocalBuilder variable as it has been captured.
6776 Create a temporary variable and store the results on the
6777 FieldBuilder. Fixes #76642
6779 2005-11-07 Marek Safar <marek.safar@seznam.cz>
6781 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
6783 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
6785 * expression.cs (Binary.DoResolve): Added && optimalization.
6787 * typemanager.cs (AddUserType): Removed useless argument.
6789 2005-11-04 Marek Safar <marek.safar@seznam.cz>
6791 * statement.cs (Block.variables): Uses ListDictionary.
6793 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6796 * class.cs (PartialContainer.EmitType): Customized to emit
6797 security attributes.
6798 (ClassPart.ApplyAttributeBuilder): Transform security attribute
6799 for partial classes.
6801 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6804 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
6805 access has to be fixed.
6807 * typemanager.cs (IsUnmanagedType): Wrong common field type.
6809 2005-11-01 Marek Safar <marek.safar@seznam.cz>
6812 * ecore.cs (NullCast.Reduce): Implemented.
6814 * expression.cs (ArrayCreation.CheckIndices): Correcly check
6817 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
6819 (Foreach.Resolve): Catch null properly.
6821 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6823 * cs-tokenizer.cs: Warning text fix.
6825 * driver.cs: AllWarningNumbers exposed on public interface.
6827 * report.cs (): Reviewed warning numbers.
6828 (IsValidWarning): Use binary search.
6830 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6832 * driver.cs: Implemeted resource visibility.
6833 (Resources): New class for code sharing between /res: and
6836 2005-10-28 Marek Safar <marek.safar@seznam.cz>
6839 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
6842 * convert (Convert.ImplicitReferenceConversion): NullCast holds
6845 * ecore.cs (NullCast): Child is contant only.
6847 * literal.cs (NullLiteral.Reduce): null can be converted to any
6850 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
6852 * driver.cs: Use Encoding.Default as default code page instead
6855 2005-10-27 Raja R Harinath <rharinath@novell.com>
6858 * expression.cs (Invocation.Error_InvalidArguments): Handle
6859 __arglist parameters.
6860 (Invocation.VerifyArgumentsCompat): Likewise.
6861 * support.cs (ReflectionParameters.GetSignatureForError): Print
6862 __arglist parameters.
6863 (InternalParamters.GetSignatureForError): Likewise.
6864 * parameter.cs (Parameters.GetSignatureForError): Likewise.
6866 2005-10-26 Marek Safar <marek.safar@seznam.cz>
6868 * attribute.cs (GetPropertyValue): Made public.
6870 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
6872 Add new property WrapNonExceptionThrows to handle 2.0 assembly
6874 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
6877 * driver.cs: Reflect method name change.
6879 * statement.cs (Try.Resolve): Warn when try has both general
6882 * typemanager.cs: runtime_compatibility_attr_type new predefined
6885 2005-10-26 Raja R Harinath <harinath@gmail.com>
6888 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
6889 treat it as an empty parameter list.
6891 2005-10-26 Raja R Harinath <rharinath@novell.com>
6894 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
6895 ResolveAsTypeStep silent.
6896 * statement.cs (Block.AddConstant): Mark block as used.
6897 (Block.ResolveMeta): Avoid piling on error messages
6898 if a constant initializer resolution fails.
6900 2005-10-25 Raja R Harinath <rharinath@novell.com>
6902 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
6904 (NamespaceEntry.VerifyAllUsing): New.
6905 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
6906 behaviour. Delegates actual resolution of alias to ...
6907 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
6908 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
6910 * driver.cs (Driver.MainDriver): Update.
6912 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
6913 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
6915 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
6917 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
6918 RootNamespace.DefineNamespacesForAll.
6920 2005-10-24 Raja R Harinath <harinath@gmail.com>
6922 * typemanager.cs (assemblies, external_aliases, modules)
6923 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
6924 (ComputeNamespaces, GetRootNamespace): Remove extra staging
6925 overhead. Move resposibility ...
6926 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
6927 * driver.cs, attribute.cs, codegen.cs: Update to changes.
6929 2005-10-23 Raja R Harinath <harinath@gmail.com>
6931 * namespace.cs (RootNamespace.all_namespaces): Renamed from
6932 cached_namespaces. Improve usage.
6933 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
6934 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
6935 Move from GlobalRootNamespace and simplify.
6936 (RootNamespace.Global): Make instance variable.
6937 (RootNamespace.RootNamespace): Add "alias name" parameter.
6938 (GlobalRootNamespace): Simplify drastically.
6939 (Namespace.Lookup): Don't use GetNamespace.
6940 * typemanager.cs (GetRootNamespace): Rename from
6941 ComputeNamespaceForAlias.
6942 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
6944 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6946 * anonymous.cs (AnonymousContainer): Don't crash when container
6949 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6951 * expression.cs (Binary.DoResolve): Warn when comparing same
6954 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6957 * expression.cs (Binary.DoResolve): It looks like there are no
6958 convetsion rules in enum context.
6960 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6962 Add support for extern alias qualifiers.
6963 * typemanager.cs: Move some LookupTypeReflection code
6964 to namespace.cs, to have cleaner code. Added some methods
6965 to help us keep track of the extern aliased references.
6966 * driver.cs: Add suport for extern alias assemblies on command
6967 line and check for their warnings/errors. Also keep track of the
6968 extern aliased assemblies.
6969 * namespace.cs: Move the global functionality of Namespace
6970 to GlobalRootNamespace/RootNamespace. Now the global namespace
6971 is GlobalRootNamespace.Globa. Also the code moved from
6972 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
6973 Finally added LocalAliasEntry (AliasEntry before) and
6974 ExternAliasEntry, to handle alias statements.
6975 * cs-parser.jay: Add support in the grammar for extern alias
6977 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
6978 Update callings to Namespace (now in GlobalRootNamespace).
6980 2005-10-18 Raja R Harinath <rharinath@novell.com>
6983 * class.cs (TypeContainer.DefineType): Move updating of
6984 topological sort earlier in the code.
6985 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
6987 2005-10-18 Marek Safar <marek.safar@seznam.cz>
6990 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
6992 * constant.cs (Constant.TryReduce): Moved from Cast class.
6993 (Reduce): Made little bit more OO and fixed missing conversions.
6995 * ecore.cs (Reduce): Implemented.
6996 (Binary.EnumLiftUp): New method to upgrade values to enum values.
6998 * literal.cs (Reduce): Implemented.
7000 * class.cs: Reverted Miguel's wrong commit.
7002 2005-10-14 Miguel de Icaza <miguel@novell.com>
7004 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
7006 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
7008 * cs-parser.jay, expression.cs : CS0214 was missing error location
7009 for constants. Fixed bug #76404.
7011 2005-10-11 Marek Safar <marek.safar@seznam.cz>
7014 * convert.cs (ExplicitConversionCore): Fixed object->enum
7017 2005-10-10 Raja R Harinath <rharinath@novell.com>
7019 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
7021 (PropertyExpr.EmitCall): Likewise.
7022 * expression.cs (Invocation.EmitArguments): Handle case where
7024 (Invocation.EmitCall): Avoid allocating temporary variable if
7025 there are no arguments.
7027 2005-10-07 Raja R Harinath <rharinath@novell.com>
7030 * convert.cs (ImplicitConversionStandard): Move conversion of
7031 void* to arbitrary pointer types ...
7032 (ExplicitConversionStandard): .. here.
7033 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
7034 error to always print typenames.
7036 2005-10-07 Raja R Harinath <rharinath@novell.com>
7038 * convert.cs (GetConversionOperator): Rename from
7039 GetConversionOperators. Move operator selection code from ...
7040 (UserDefinedConversion): ... here.
7042 2005-10-06 Marek Safar <marek.safar@seznam.cz>
7044 * convert.cs (ExplicitConversionCore): Removed duplicate enum
7047 2005-10-05 Marek Safar <marek.safar@seznam.cz>
7049 * assign.cs (Assign.DoResolve): Error method changed.
7051 * cfold.cs (DoConstantNumericPromotions): Error method changed.
7053 * const.cs (ResolveValue): Reset in_transit immediately.
7055 * constant.cs: Error method changed.
7057 * convert.cs: Removed useless location parameter.
7058 (ExplicitNumericConversion): Don't do double enum check.
7059 (ExplicitConversionCore): Renamed from ExplicitConversion.
7060 (ExplicitUnsafe): Extracted from ExplicitConversion.
7061 (ExplicitConversion): Uses for error reporting.
7063 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
7065 (ResolveBoolean): Uses common error method.
7066 (CastToDecimal): Get rid of ec.
7067 (CastFromDecimal): Optimized.
7068 (ConvCast): Get rid of ec.
7070 * enum.cs (ResolveValue): Reset in_transit immediately.
7071 (Emit): Return after first error.
7073 * expression.cs: Convert changes.
7075 * literal.cs: Error method changed.
7077 * statement.cs: Error method changed.
7079 2005-10-03 Raja R Harinath <rharinath@novell.com>
7081 * support.cs (SeekableStreamReader.Position): Don't error out when
7082 the requested position is just beyond the end of the current
7085 2005-09-28 Raja R Harinath <rharinath@novell.com>
7087 * support.cs (SeekableStreamReader): Simplify drastically. Don't
7088 try to keep in sync with the byte count of the underlying Stream.
7089 However, this limits us to a window size of 2048 characters: i.e.,
7090 the maximum lookahead of our lexer/parser can be 2048 characters.
7092 2005-09-28 Marek Safar <marek.safar@seznam.cz>
7095 * driver.cs: Fix compilation files with full root path.
7097 2005-09-25 Miguel de Icaza <miguel@novell.com>
7099 * report.cs (SymbolRelatedToPreviousError): Format the output so
7100 it does not use an open parenthesis that is never closed.
7102 * driver.cs: Follow coding guidelines
7104 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7107 * const.cs (Const.ResolveValue): Check for assigning non-null
7108 value to reference type.
7110 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7112 * anonymous.cs: Implemented ExprClassName.
7114 * assign.cs (Assign.DoResolve): Don't chrash when type is not
7117 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
7120 * class.cs (StaticClass.DefineContainerMembers): Report protected
7123 * codegen.cs: if(ed) PRODUCTION.
7125 * convert.cs (Error_CannotImplicitConversion): Better error
7128 * cs-parser.jay: More error checks.
7130 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
7132 * driver.cs (CSCParseOption): Enabled wrong option check.
7134 * ecore.cs (Expression.ExprClassName): Turned to property.
7135 (MemberExpr.CheckIntermediateModification): For checking boxed
7136 value types modification.
7138 * statement.cs (Fixed.Resolve): Expression type must be
7139 convertible to fixed type.
7140 (CollectionForeach.GetEnumeratorFilter,TryType):
7141 Small refactoring for easier error checking.
7143 2005-09-26 Marek Safar <marek.safar@seznam.cz>
7145 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
7148 * class.cs (GeneratedBaseInitializer): New class for customization
7149 compiler generated initializers.
7150 (MemberBase.DoDefine): Check Obsolete attribute here.
7151 (FieldMember.DoDefine): Ditto.
7153 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
7156 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
7157 (MemberCore.GetObsoleteAttribute): Removed argument.
7158 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
7159 (MemberCore.CheckObsoleteType): New helper.
7163 * statement.cs: Updates after MemberCore changes.
7165 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
7166 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
7168 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
7169 obsolete attribute for compiler construct.
7170 (As.DoResolve): Cache result.
7172 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
7174 2005-09-26 Raja R Harinath <rharinath@novell.com>
7177 * expression.cs (This.VerifyFixed): In a value type T, the type of
7178 'this' is T&, iow, 'this' is either an out or ref parameter. In a
7179 value type R, 'this' is treated as a value parameter.
7181 2005-09-22 Miguel de Icaza <miguel@novell.com>
7183 * statement.cs (Lock): Use the TemporaryVariable class instead of
7184 manually using local variables as those do not work when variables
7187 * ecore.cs: Moved the TemporaryVariable class from being a nested
7188 class inside Foreach to be a public class that can be employed in
7191 2005-09-19 Marek Safar <marek.safar@seznam.cz>
7193 * cs-parser.jay: interface_accessors replaced by
7194 accessor_declarations.
7196 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
7199 * statement.cs (GotoCase.Resolve): Convert null constant to
7201 (SwitchLabel.ResolveAndReduce): Ditto.
7202 (SwitchLabel.NullStringCase): Custom null stamp.
7203 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
7205 typemanager.cs (CSharpSignature): Don't skip first argument
7208 2005-09-18 Miguel de Icaza <miguel@novell.com>
7210 * driver.cs: Set InEmacs based on the environment variable EMACS.
7212 * location.cs (InEmacs): in this mode, do not report column
7213 location as it confuses Emacs.
7215 2005-09-16 Marek Safar <marek.safar@seznam.cz>
7217 * cfold.cs, constant.cs, convert.cs, ecore.cs,
7218 expression.cs, iterators.cs, literal.cs: Store constants and
7221 * class.cs (MemberBase.ShortName): Pass location.
7223 * cs-parser.jay: Some location fixes.
7225 * ecore.cs (Expression.Location): Made virtual.
7227 2005-09-05 Miguel de Icaza <miguel@novell.com>
7229 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
7230 if the underlying types are the same, otherwise we need to produce
7231 code that will do the proper cast.
7233 This was exposed by Marek's constant rewrite which produced
7234 invalid code for the call site:
7237 void Method (X v) {}
7241 This fixes test-49.cs
7243 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
7245 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
7246 Type/Object should be allowed as well. Fixed bug #75968.
7248 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
7250 * expression.cs : (Binary.DoResolve): when one is enum constant and
7251 another is constant 0, then return enum one *as enum type*.
7254 2005-09-02 Raja R Harinath <rharinath@novell.com>
7256 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
7260 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
7261 flow-branching for LocalVariableReferences in case we were invoked
7262 from a MemberAccess.
7263 * expression.cs (LocalVariableReference.VerifyAssigned): New.
7265 (LocalVariableReference.DoResolveBase): ... this.
7266 (MemberAccess.Resolve): Do the check that was disabled during
7269 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
7272 (PartialContainer.Create): check abstract/sealed/static strictly
7273 but abstract/sealed can exist only at one side. Fixed bug #75883.
7275 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
7278 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
7279 specified, don't default to UnmanagedType.I4.
7281 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
7283 * expression.cs : conditional operator should check possibly
7284 incorrect assign expression. Fixed bug #75946.
7286 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
7288 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
7289 Reverting the change. gmcs is much complex than mcs on this matter.
7291 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
7293 * cs-tokenizer.cs : To read another token ahead of the actual
7294 consumption, use new SavedToken and cache token instead of moving
7295 back the stream with SeekableStreamReader (it seemed problematic).
7297 driver.cs : Thus use StreamReader directly.
7298 * support.cs : Thus removed SeekableStreamReader.
7300 2005-08-30 Raja R Harinath <rharinath@novell.com>
7303 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
7304 (ScopeInfo.EmitScopeType): Use it to construct field names from
7305 names of captured locals.
7308 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
7309 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
7310 Pass 'target_type' to BoxedCast. Don't default to 'object'.
7311 (ExplicitConversion): Remove enum cases already handled by
7312 implicit conversion. Move implicit conversion check to the beginning.
7313 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
7314 * expression.cs (ArrayCreation.EmitDynamicInitializers):
7315 Don't treat System.Enum as a struct.
7317 2005-08-30 Jb Evain <jbevain@gmail.com>
7319 * attribute.cs: handles as expression in parameters.
7321 2005-08-30 Raja R Harinath <rharinath@novell.com>
7324 * class.cs (TypeContainer.VerifyClsName): Don't use a
7325 PartialContainer when verifying CLS compliance.
7326 (AbstractPropertyEventMethod): Set Parent here, ...
7327 (PropertyMethod): ... not here.
7329 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
7331 * attribute.cs : escaped attribute name should not be allowed to be
7332 resolved (e.g. @class as classAttribute). Fixed bug #75930.
7334 2005-08-29 Raja R Harinath <rharinath@novell.com>
7337 * convert.cs (ImplicitStandardConversionExists): Allow zero also
7338 when converting a long constant to unsigned long.
7339 * expression.cs (Invocation.OverloadResolve): Add sanity check to
7340 detect where IsApplicable and VerifyArgumentsCompat disagree.
7342 2005-08-29 Raja R Harinath <rharinath@novell.com>
7343 and Carlos Alberto Cortez <carlos@unixmexico.org>
7346 * class.cs (TypeContainer.CanElideInitializer): New helper.
7347 (TypeContainer.EmitFieldInitializers): Use it to determine if we
7348 can safely emitting the initializer of a field.
7350 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7352 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
7353 allowed inside a switch (without loop). Fixed bug #75433.
7355 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
7357 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
7358 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
7360 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7362 * driver.cs : kinda reverting the default encoding changes (not exact
7363 revert since I noticed that "codepage:reset" might not work fine).
7365 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7367 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
7368 Location. Now getter and setter store location correctly.
7369 (errors/cs0111-12.cs now reports the expected location.)
7371 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7373 * driver.cs : Use default encoding on the environment.
7374 Removed (now that) extra parameter for SeekableStreamReader.
7375 * support.cs : (SeekableStreamReader) third .ctor() argument for
7376 StreamReader is not required (always true). preamble size could
7377 be acquired in simpler and safe way.
7379 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
7381 * cs-parser.jay: report CS0642 at warning level 3
7382 and report CS0642 for an if else statement also
7383 fixes bug #74745. Patch by John Luke (and a bit
7385 Removed extra CS0642 warning check for "while",
7387 * statement.cs: In Block.Resolve(), CS0642 check
7388 is reimplemented to check a sequence of an empty
7389 statement and a block.
7391 Both fix bug #66777.
7393 2005-08-24 Marek Safar <marek.safar@seznam.cz>
7395 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
7396 detection until I fix it.
7398 * cs-tokenizer.cs: Changed error message.
7400 * cs-parser.jay: Fixed 2 error locations.
7402 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
7403 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
7406 * enum.cs (GetSignatureForError): Fixed.
7408 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
7412 * typemanager.cs (RegisterProperty): Removed.
7414 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
7416 2005-08-24 Raja R Harinath <rharinath@novell.com>
7419 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
7420 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
7422 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7424 * expression.cs : tiny fix is required for not warning positive ulong.
7427 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7429 * expression.cs : add CS0652 check for constant and integral
7430 expression. Fixed bug #53974.
7432 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7434 * expression.cs : in DoNumericPromotions(), check if there is implicit
7435 conversion overload for string (to check CS0034). Fixed bug #52492.
7437 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7439 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
7441 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7443 * ecore.cs : report location when it is *not* Null.
7445 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7451 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
7452 correctly. Fixed bug #75721.
7454 2005-08-23 Raja R Harinath <rharinath@novell.com>
7456 * support.cs (SeekableStreamReader.Position): Avoid an expensive
7457 loop that performs 'min (pos, char_count)'.
7460 * expression.cs (Unary.ResolveOperator): Don't discard implicit
7461 converted value in Operator.OnesComplement.
7463 2005-08-22 Ben Maurer <bmaurer@ximian.com>
7465 * anonymous.cs: If the anon method is pulled into a helper class,
7466 it needs to be `internal' not `private'. Fixes runtime behavior on
7469 2005-08-20 Martin Baulig <martin@ximian.com>
7471 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7472 scope if we don't already have it.
7474 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
7475 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
7478 2005-08-17 Marek Safar <marek.safar@seznam.cz>
7481 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
7484 2005-08-16 Marek Safar <marek.safar@seznam.cz>
7486 The big constants rewrite
7487 Fix #75746, #75685 and more
7488 As a side effect saved 1MB for MWF ;-)
7490 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
7491 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
7492 enum based for corlib compilation.
7494 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
7497 * class.cs (FixedField.Define): Use ResolveAsConstant.
7499 * const.cs (IConstant): Interface constants and enums.
7500 (Const.ResolveValue): New method for constant resolvning.
7501 (ExternalConstant): Constants from imported assemblies.
7503 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
7504 conversion; like enums.
7505 (Constant.ToType): Converts this constant to different type.
7506 (Constant.Increment): Adds 1.
7508 * convert.cs (ImplicitConversionRequired): Simplified.
7510 * cs-parser.jay: Create EnumMember directly.
7512 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
7514 * doc.cs (GenerateEnumDocComment): Removed.
7516 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
7517 (ConvertIntLiteral): Removed.
7518 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
7520 * enum.cs (EnumMember): Implement IConstant.
7521 (Enum.IsValidEnumConstant): Removed.
7522 (Enum.GetNextDefaultValue): Removed.
7523 (Enum.FindMembers): Updated.
7524 (Enum.GenerateDocComment): Iterate enum members.
7526 * expression.cs (Cast.TryReduce): Handle enums correctly.
7527 (New.Constantify): Made public.
7528 (MemberAccess.DoResolve): Removed contant specific if(s).
7530 * literal.cs (NullLiteral): Implement new abstract methods.
7532 * statement.cs (GotoCase.Resolve): Use new constant methods.
7533 (SwitchLabel.ResolveAndReduce): Use new constant methods.
7535 * typemanager.cs (LookupEnum): Removed.
7536 (IsEnumType): Fixed to work with corlib.
7537 (RegisterConstant): Removed.
7538 (LookupConstant): Removed.
7539 (GetConstant): Changed to work with IConstant.
7541 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
7543 * location.cs : Fixed overflown (>255) column number.
7545 2005-08-03 Raja R Harinath <rharinath@novell.com>
7547 First cut of the qualified-alias-member feature.
7548 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
7550 * cs-parser.jay (DOUBLE_COLON): New token.
7551 (namespace_or_type_name): Add rule for recognizing
7552 qualified-alias-members.
7553 (primary_expression): Likewise.
7554 (element_access): Allow QualifiedAliasMember as a possible
7555 type-bearing expression.
7556 (local_variable_type, local_variable_pointer_type): Likewise.
7557 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
7558 aliases in the current and enclosing namespace declarations.
7559 (NamespaceEntry.UsingAlias): Add CS0440 warning.
7560 * decl.cs (MemberName.is_double_colon): New.
7561 (MemberName.MemberName): Add new constructor for alias-member.
7562 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
7563 * expression.cs (QualifiedAliasMember): New expression type.
7565 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7567 * location.cs : it borked when no argument was specified.
7569 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7571 * location.cs : tiny ToString() format fix.
7573 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7575 * statement.cs : oops, it was missing.
7577 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7579 A set of fixes for precise line/column location.
7582 "token" field now holds a file/line "delta", a line number offset
7583 from the segment, and a column number. See also:
7584 http://lists.ximian.com/pipermail/mono-devel-list/2004-
7585 December/009508.html
7586 Removed static IsNull. Use instance IsNull property instead.
7588 For some tokens it stores Location. For Identifier it stores
7589 LocatedToken which is a pair of string name and location.
7590 Column numbers are adjusted only at getChar().
7592 Use Location.ToString() for reporting (it now contains column).
7594 Largely modified to use LocatedToken instead of
7595 string (IDENTIFIER), and to acquire Location from some tokens.
7596 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
7597 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
7599 Now MemberName holds Location. DeclSpace.ctor() receives Location
7600 as a parameter. Removed extra parameters to all derived classes.
7601 Replaced Location.IsNull() with instance property.
7602 * assign.cs, expression.cs :
7603 Added .ctor() overload that omits Location.
7605 Added "nameEscaped" flag that indicates the identifier was escaped
7606 in the source file. This fixes bug #57047.
7608 2005-08-02 Marek Safar <marek.safar@seznam.cz>
7610 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
7611 New method, looking for lo-case imported cls type.
7613 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
7616 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
7618 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
7620 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
7622 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
7624 Optimized to save 3.5 MB for SWF compilation.
7626 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7628 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
7629 (PartialContainer.Create): Moved logic AddToContainer.
7630 (PartialContainer.MarkForDuplicationCheck): Shares name.
7632 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
7635 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
7637 (Namespace.GetSignatureForError): New method.
7639 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
7640 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
7642 2005-08-01 Raja R Harinath <rharinath@novell.com>
7645 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
7646 member lookup rather than qualifier_type, since qualifier_type can
7649 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7651 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
7654 2005-07-31 Miguel de Icaza <miguel@novell.com>
7656 * statement.cs: Copy the local exception into the exception
7657 captured local. Fixes 75674
7659 2005-07-31 Raja R Harinath <harinath@gmail.com>
7662 * expression.cs (Invocation.OverloadResolve): Don't report error
7663 CS1501 if error CS1502 has been reported.
7664 (New.DoResolve): Delegate CS1501 reporting to
7665 Invocation.OverloadResolve.
7668 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
7669 invariant-meaning-in-block property in an enclosing block if
7672 2005-07-29 Marek Safar <marek.safar@seznam.cz>
7674 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
7675 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
7676 (Switch.CheckSwitch): Just save 50kb for SWF.
7678 2005-07-27 Martin Baulig <martin@ximian.com>
7680 * anonymous.cs (CaptureContext.AddField): Added
7681 `AnonymousContainer am' argument; compute its toplevel scope if
7682 it's not already computed. Fixes #75649.
7684 2005-07-26 Raja R Harinath <rharinath@novell.com>
7687 * class.cs (Constructor.Emit): Reset block to null if the block
7690 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7692 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
7694 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7696 * class.cs (MethodData.Define): Check whether accessor implementing
7697 interface is public.
7699 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
7701 2005-07-22 Marek Safar <marek.safar@seznam.cz>
7704 * namespace.cs (LookupType): Moved same type check to...
7706 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
7709 2005-07-21 Raja R Harinath <rharinath@novell.com>
7711 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
7712 already found a typebuilder.
7713 * class.cs (MethodCore.IsDuplicateImplementation): Compare
7714 MemberNames, not strings.
7716 * const.cs (Error_ExpressionMustBeConst):
7717 Rename from Error_EpressionMustBeConst.
7718 * const.cs, class.cs, statement.cd: Update.
7720 2005-07-21 Marek Safar <marek.safar@seznam.cz>
7724 * const.cs (Const.LookupConstantValue): Report missing contant expression
7726 (Error_EpressionMustBeConstant): Only one error method.
7728 * class.cs, statement.c: Updated.
7730 2005-07-20 Raja R Harinath <rharinath@novell.com>
7732 * statement.cs (Block.Flags): Add back HasVarargs.
7733 (Block.flags): Make protected.
7734 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
7736 * typemanager.cs (types, typecontainers, user_types): Remove.
7737 (UserTypes, TypeContainers): Likewise.
7738 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
7739 (CleanUp, Reset): Update.
7740 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
7741 (GetNestedType): Use Type.GetNestedType.
7742 (CoreLookupType): Take two arguments, the namespace and the
7743 basename of the type. Update to use the Namespace.Lookup
7745 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
7746 (RealMemberLookup): Use IsNestedChildOf instead of playing with
7747 string concatenation and substring matches.
7748 * class.cs, enum.cs, delegate.cs: Update to changes.
7750 2005-07-20 Marek Safar <marek.safar@seznam.cz>
7752 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
7753 Expression and made virtual.
7755 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
7756 (ImplicitStandardConversionExists): Fixed `byte' typo ?
7758 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
7760 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
7763 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
7766 2005-07-18 Marek Safar <marek.safar@seznam.cz>
7769 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
7770 AssemblyCultureAttribute is not used on executable.
7773 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
7775 2005-07-16 Raja R Harinath <rharinath@novell.com>
7778 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
7779 New. Reports CS0252/CS0253.
7780 Mostly taken from preliminary patch by Duncak Mak.
7781 (Binary.DoResolveOperator): Store results of operator lookup.
7782 Use them to detect if we need to warn about unintended reference
7785 2005-07-15 Raja R Harinath <rharinath@novell.com>
7788 * namespace.cs (Namespace.Lookup): Add back location parameter.
7789 (Namespace.LookupType): Add CS0436 report. Add location parameter.
7790 * delegate.cs, ecore.cs, expression.cs: Update to changes.
7792 * codegen.cs (EmitContext.DeclSpace): Make readonly.
7793 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
7794 (Namespace.LookupType): ... this.
7795 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
7797 * typemanager.cs (LookupTypeReflection): Remove buggy code that
7798 purported to handle pointers.
7799 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
7802 2005-07-15 Marek Safar <marek.safar@seznam.cz>
7804 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
7807 2005-07-15 Raja R Harinath <rharinath@novell.com>
7809 * namespace.cs (Namespace.Lookup): Drop location parameter.
7810 (NamespaceEntry.LookupAlias): Remove. Merge into ...
7811 (NamespaceEntry.Lookup): ... this.
7812 (NamespaceEntry.Error_AmbiguousTypeReference):
7813 Move here from DeclSpace.
7814 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
7816 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
7817 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
7818 Move to NamespaceEntry.
7819 * delegate.cs, expression.cs: Update to changes.
7821 2005-07-14 Marek Safar <marek.safar@seznam.cz>
7823 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
7824 CheckAttributeType and refactored.
7825 (Attribute.ResolvePossibleAttributeType): Changed to reuse
7826 ResolveAsTypeTerminal error handling.
7827 (ResolveAsTypeTerminal): Introduced because of global attributes extra
7829 (GetSignatureForError): Print errors in same way.
7832 * codegen.cs: Reflect attribute GetSignatureForError change.
7835 * expression.cs: Add silent parameter to ResolveAsTypeStep.
7837 * namespace.cs (UsingEntry): Refactored to make fields private.
7840 statement.cs: Error_UnexpectedKind has extra parameter.
7842 2005-07-14 Raja R Harinath <rharinath@novell.com>
7844 * ecore.cs (IAlias): Remove.
7845 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
7846 that implement the interface.
7847 * namespace.cs (Namespace): Likewise.
7848 (Namespace.declspaces): Renamed from 'defined_names'.
7849 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
7850 DeclSpace instead of an IAlias.
7851 * tree.cs (Tree.AddDecl): Update.
7853 2005-07-12 Raja R Harinath <rharinath@novell.com>
7855 * statement.cs (Block.Flags); Remove HasVarargs.
7856 (Block.HasVarargs): Move to ToplevelBlock.
7857 (Block.ThisVariable, Block.AddThisVariable): Likewise.
7858 (Block.Variables): Make protected. Initialize variable hashtable
7860 (Block.AddVariable): Update.
7861 (Block.Resolve): Update to changes.
7862 (ToplevelBlock.HasVarargs): New boolean.
7863 (ToplevelBlock.ThisVariable): Move here from Block.
7864 (ToplevelBlock.AddThisVariable): Likewise.
7865 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
7866 * expression.cs (This.ResolveBase): Update to changes.
7867 (ArglistAccess.DoResolve): Likewise.
7869 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7872 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
7874 * class.cs (TypeContainer.VerifyMembers): Distinguish between
7875 not used and not used & assigned.
7876 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
7878 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7881 * expression.cs (Is.DoResolve): null is never provided type.
7883 2005-07-08 Marek Safar <marek.safar@seznam.cz>
7886 * cs-parser.jay: Less strict event error rule to catch more errors.
7888 2005-07-08 Martin Baulig <martin@ximian.com>
7890 Fix test-iter-10.cs - distinguish whether we `yield' in a property
7891 gettter (allowed) or setter (not allowed).
7893 * class.cs (Accessor): Implement IIteratorContainer.
7894 (Accessor.Yields): New public field.
7895 (PropertyBase.PropertyMethod.Define): Handle iterators on a
7899 (get_accessor_declaration, set_accessor_declaration): Set the
7900 `yields' flag on the accessor, not the property.
7901 (property_declaration): Do the iterators check on a per-accessor
7902 basis and not for the whole property.
7904 2005-07-08 Martin Baulig <martin@ximian.com>
7906 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
7907 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
7909 2005-07-07 Marek Safar <marek.safar@seznam.cz>
7912 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
7913 (ExtractSecurityPermissionSet): Cope with self referencing security
7914 attributes properly.
7916 * driver.cs (SetOutputFile): Made public property OutputFile.
7918 2005-07-07 Raja R Harinath <rharinath@novell.com>
7921 * class.cs (TypeContainer.first_nonstatic_field): Rename from
7922 has_nonstatic_fields. Make into a FieldBase pointer.
7923 (TypeContainer.AddField): Add CS0282 check.
7924 (TypeContainer.EmitType): Update.
7926 2005-07-06 Miguel de Icaza <miguel@novell.com>
7928 * cs-tokenizer.cs (consume_identifier): Do not create strings to
7929 compare if they start with __.
7931 2005-07-06 Raja R Harinath <rharinath@novell.com>
7933 * statement.cs (Switch.SwitchGoverningType): Only look at
7934 UserCasts that don't need implicit standard conversions to one of
7935 the allowed switch types (Fixes test-322.cs).
7936 (LocalInfo.Resolve): Re-enable sanity-test.
7938 2005-07-06 Marek Safar <marek.safar@seznam.cz>
7940 * cs-tokenizer.cs (consume_identifier): Detect double undescores
7942 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
7944 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
7946 2005-07-06 Raja R Harinath <rharinath@novell.com>
7949 * ecore.cs (SimpleName.GetSignatureForError): Add.
7950 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
7951 (MemberAccess.GetSignatureForError): Add.
7953 2005-07-05 Marek Safar <marek.safar@seznam.cz>
7955 The big error and warning messages review.
7985 * typemanager.cs: Updated.
7987 * class.cs: (MethodCore.SetYields): Moved here to share.
7988 (PropertyMethod.Define): Moved iterator setup here.
7990 * iterators.cs: Add orig_method to have full access to parent
7993 2005-07-05 Raja R Harinath <rharinath@novell.com>
7995 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
7996 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
7997 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
7998 variable of struct type.
7999 * expression.cs (Unary.ResolveOperator): Update to change.
8000 (Indirection.VerifyFixed): Likewise.
8001 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
8002 (ParameterReference.VerifyFixed): Value parameters are fixed.
8003 (This.VerifyFixed): Treat 'this' as a value parameter.
8004 * statement.cs (LocalInfo.IsFixed): Remove.
8006 2005-07-01 Martin Baulig <martin@ximian.com>
8008 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
8009 `ec.EmitThis ()' to get the correct scope.
8011 2005-07-01 Martin Baulig <martin@ximian.com>
8013 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
8014 instance is a ParameterReference; fixes #75299.
8016 2005-07-01 Martin Baulig <martin@ximian.com>
8018 Reverted Marek's latest patch (r46725):
8019 - it contains structural changes which are neither mentioned in
8020 the ChangeLog nor explained anywhere; for example the additional
8021 argument of EmitContext's and Iterator's .ctor's and the
8022 TypeContainer.DefineMembers() change.
8023 - structural changes like this should go in in seperate patches
8024 and not be hidden in a huge patch which just seems to affect
8025 warnings and errors.
8026 a big and hard to understand patch.
8027 - it breaks iterators and causes regressions, for instance in
8030 2005-06-30 Raja R Harinath <rharinath@novell.com>
8033 * expression.cs (Indexers.map): Remove.
8034 (Indexers.Append): Filter out inaccessible setters and getters.
8035 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
8038 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
8040 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
8041 (FieldExpr.Emit, PropertyExpr.Emit): Update.
8042 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
8043 * expression.cs (Invocation.EmitCall): Add CS0120 check.
8045 2005-06-30 Marek Safar <marek.safar@seznam.cz>
8048 * class.cs (FieldBase.GetInitializerExpression): One more field
8051 2005-06-28 Miguel de Icaza <miguel@novell.com>
8053 * pending.cs: Do not define a proxy if the base method is virtual,
8054 it will be picked up by the runtime (bug 75270).
8056 2005-06-08 Martin Baulig <martin@ximian.com>
8058 The big Iterators rewrite :-)
8060 * iterators.cs: Rewrite this to use the anonymous methods framework.
8062 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
8063 before the TypeContainers; see 2test-21.cs.
8066 (TypeContainer.DefineType): Don't create a new EmitContext if we
8067 already have one (this only happens if we're an Iterator).
8068 (TypeContainer.Define): Also call Define() on all our iterators.
8069 (Method.CreateEmitContext): Added support for iterators.
8072 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
8073 (AnonymousContainer.CreateMethodHost): Moved here from
8074 AnonymousMethod and made abstract.
8075 (AnonymousContainer.CreateScopeType): New abstract method.
8076 (AnonymousContainer.IsIterator): New public property.
8077 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
8078 get the ScopeTypeBuilder rather than manually defining it here.
8079 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
8082 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
8083 before RootContext.DefineTypes().
8085 * codegen.cs (EmitContext.RemapToProxy): Removed.
8086 (EmitContext.CurrentAnonymousMethod): Changed type from
8087 AnonymousMethod -> AnonymousContainer.
8088 (EmitContext.ResolveTopBlock): Protect from being called twice.
8089 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
8090 (EmitContext.EmitThis): Removed the iterators hacks; use the
8091 anonymous methods framework for that.
8094 (ToplevelBlock.Container): Make this a property, not a field.
8095 (ToplevelBlock.ReParent): New public method; move the
8096 ToplevelBlock into a new container.
8097 (Foreach.TemporaryVariable): Simplify.
8099 2005-06-05 Martin Baulig <martin@ximian.com>
8101 * statement.cs (LocalInfo.CompilerGenerated): New flag.
8102 (Block.AddTemporaryVariable): New public method; creates a new
8103 `LocalInfo' for a temporary variable.
8104 (Block.EmitMeta): Create the LocalBuilders for all the temporary
8106 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
8107 non-iterator variables.
8109 2005-06-05 Martin Baulig <martin@ximian.com>
8111 * statement.cs (Foreach.TemporaryVariable): Create the
8112 LocalBuilder in the Emit phase and not in Resolve since in some
8113 situations, we don't have an ILGenerator during Resolve; see
8114 2test-19.cs for an example.
8116 2005-06-04 Martin Baulig <martin@ximian.com>
8118 **** Merged r45395 from GCS ****
8120 The big Foreach rewrite - Part II.
8122 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
8123 with `PropertyInfo ienumerator_getcurrent'.
8125 * codegen.cs (VariableStorage): Removed.
8128 (Foreach): Derive from Statement, not ExceptionStatement.
8129 (Foreach.CollectionForeach): New nested class. Moved all the code
8130 dealing with collection foreach here.
8131 (Foreach.ForeachHelperMethods): Removed.
8132 (Foreach.TemporaryVariable): Implement IMemoryLocation.
8134 2005-05-23 Martin Baulig <martin@ximian.com>
8136 * statement.cs (Try.DoResolve): Don't create a `finally' if we
8137 don't need to. Fix #75014.
8139 2005-05-20 Martin Baulig <martin@ximian.com>
8141 Merged r44808 from GMCS.
8143 * class.cs (TypeContainer.CircularDepException): Removed.
8144 (TypeContainer.DefineType): Removed the `InTransit' stuff.
8145 (TypeContainer.CheckRecursiveDefinition): Check for circular class
8146 (CS0146) and interface (CS0529) dependencies here.
8148 2005-06-21 Raja R Harinath <rharinath@novell.com>
8150 * expression.cs (Invocation.EmitCall): Fix initialization
8151 'this_call' to reflect current behaviour. Fix indentation.
8153 * convert.cs (FindMostEncompassedType): Add two trivial special
8154 cases (number_of_types == 0 || number_of_types == 1).
8155 (FindMostEncompasingType): Likewise.
8157 2005-06-17 Raja R Harinath <rharinath@novell.com>
8159 Some cleanups preparing for the fix of #75283.
8160 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
8162 (EventExpr.InstanceResolve): Likewise.
8163 (EventExpr.DoResolve): Remove redundant checks.
8165 2005-06-10 Duncan Mak <duncan@novell.com>
8167 * cs-tokenizer.cs (process_directives): New flag for controlling
8168 the processing of preprocessor directives.
8169 (x_token): After seeing a '#', return Token.NONE instead of going
8170 to handle_preprocessing_directive() when not processing
8171 directives. This avoids unnecessary processing during the token peek in
8176 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
8177 the existing error reporting methods instead of Report.Error.
8179 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
8180 after Raja's rewrite.
8182 2005-06-08 Miguel de Icaza <miguel@novell.com>
8184 * class.cs: Small fix.
8186 2005-06-08 Raja R Harinath <rharinath@novell.com>
8189 * class.cs (GetPartialBases): Fix return value check of
8192 2005-06-07 Raja R Harinath <rharinath@novell.com>
8194 Ensure that partial classes are registered in their enclosing
8195 namespace. Initial part of fix of #75160.
8196 * tree.cs (Tree.RecordDecl): Add new namespace argument.
8197 Register declspace with namespace here, not in
8198 DeclSpace.RecordDecl.
8199 * cs-parser.jay: Pass namespace to RecordDecl.
8200 * class.cs (PartialContainer.Create): Likewise.
8201 (ClassPart.DefineType): New sanity-check. Throws an exception if
8203 * decl.cs (Declspace.RecordDecl): Remove.
8204 * namespace.cs (NamespaceEntry.DefineName): Remove.
8206 2005-06-06 Marek Safar <marek.safar@seznam.cz>
8208 * rootcontext.cs: Reset TargetExt as well.
8210 2005-06-03 Raja R Harinath <rharinath@novell.com>
8212 * ecore.cs (Expression.Resolve): Emit CS0654 error when
8215 2005-06-02 Raja R Harinath <rharinath@novell.com>
8217 Fix #75080, cs0119.cs.
8218 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
8220 (Expression.Resolve): ... this. Use it. Remove bogus code
8221 allowing ExprClass.Type and ExprClass.Namespace for
8222 ResolveFlags.VariableOrValue.
8223 (Expression.Resolve) [1-argument variant]: Change default resolve
8224 flags based on language version.
8225 (Expression.Error_UnexpectedKind): Use a simple string array
8226 rather than an ArrayList.
8227 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
8229 (TypeOfVoid.DoResolve): Likewise.
8230 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
8231 flags argument -- it always has the same value.
8233 2005-05-31 Raja R Harinath <rharinath@novell.com>
8236 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
8237 Use it in the error message.
8238 * assign.cs, expression.cs, statement.cs: Update.
8240 2005-05-30 Raja R Harinath <rharinath@novell.com>
8243 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
8244 the "almostMatchedMember" case too.
8245 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
8246 that failed the accessibility checks to 'almost_match'.
8248 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
8250 * attribute.cs: Use internal MethodBuilder methods to set
8251 ExactSpelling and SetLastError on PInvoke methods, instead
8252 of passing them via charset. Fixes #75060.
8254 2005-05-27 Raja R Harinath <rharinath@novell.com>
8256 * parameter.cs (Parameter): Remove TODO comment.
8257 (Parameter.DefineParameter): Remove Location parameter.
8258 (Parameters.LabelParameters): Likewise.
8259 * class.cs (Constructor.Emit): Update to change.
8260 (MethodData.Emit): Likewise.
8261 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
8262 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
8264 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
8267 Removed Parameters.Location and added Parameter.Location instead.
8268 Removed Location parameter from Emit() and GetSignature().
8275 Modified all related calls.
8277 2005-05-26 Raja R Harinath <rharinath@novell.com>
8279 Improve user-defined conversion handling.
8280 * convert.cs (GetConversionOperators): Rewrite. Return only the
8281 applicable operators.
8282 (AddConversionOperators): New. Helper for GetConversionOperators.
8283 (FindMostEncompassedType, FindMostEncompassingType): Verify that
8284 there is only one most encompassed/encompassing type.
8285 (FindMostSpecificSource, FindMostSpecificTarget): Remove
8286 "applicable operator" handling.
8287 (UserConversion): Move cache here from GetConversionOperators.
8288 Directly cache the chosen operator, rather than the whole
8290 (ExplicitNumericConversion): Fix buggy implementation of Decimal
8291 case. Allow conversion of decimal to sbyte and byte too.
8292 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
8293 New static methods. Used to avoid allocating EmptyExpressions in
8296 2005-05-24 Duncan Mak <duncan@novell.com>
8298 * ecore.cs (CastFromDecimal): New class for casting a decimal to
8299 another class, used in Convert.ExplicitNumericConversion.
8300 (CastToDecimal): New class, similar to above, but casts to
8301 System.Decimal, used in Convert.ImplicitNumericConversion and also
8302 in explicit convesion from double/float to decimal.
8304 * convert.cs (ImplicitNumericConversion): Handle implicit
8305 conversions to System.Decimal.
8306 (ExplicitNumericConversion): handle explicit conversions to
8311 2005-05-20 Miguel de Icaza <miguel@novell.com>
8313 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
8314 know the type at this stage, just break through. Fixes #75008
8316 2005-05-19 Martin Baulig <martin@ximian.com>
8319 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
8320 to disable error reporting.
8322 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
8323 here since we don't want to report an error; see the new test-336.cs.
8325 2005-05-19 Raja R Harinath <rharinath@novell.com>
8327 * statement.cs (ToplevelBlock.GetParameterReference)
8328 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
8329 Move here from class Block.
8330 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
8331 * expression.cs (ParameterReference.DoResolveBase): Likewise.
8333 2005-05-18 Martin Baulig <martin@ximian.com>
8338 (FlowBranching.Reachability): Add non-static public And() and Or()
8340 (FlowBranchingSwitch): New class; do the `break_origins' thing
8341 like in FlowBranchingLoop.
8342 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
8343 reachability, not just locals and parameters.
8344 (FlowBranching.MergeChild): Remove some of the hacks for loop and
8345 switch; MergeBreakOrigins() now takes care of that.
8347 2005-05-18 Martin Baulig <martin@ximian.com>
8349 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
8350 a loop and may leave it, reset the barrier; fixes #74974.
8352 2005-05-17 Marek Safar <marek.safar@seznam.cz>
8354 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
8357 * cs-parser.jay: Catch more lexical errors.
8359 * report.cs: Add one more Error method.
8362 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
8364 2005-05-17 Martin Baulig <martin@ximian.com>
8366 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
8369 2005-05-16 Raja R Harinath <rharinath@novell.com>
8371 Fix test-382.cs. Emit values of decimal constants.
8372 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
8374 (TypeContainer.AddField): ... this.
8375 (TypeContainer.EmitFieldInitializers): Allow the list of fields
8376 with initializers to include 'Const's.
8377 (ClassPart.RegisterFieldForInitialization): Forward to
8379 * const.cs (Const.Const): Pass initializer to base class.
8380 (Const.Define): In case of decimal constants, register them for
8381 initialization in a static constructor.
8383 2005-05-14 Martin Baulig <martin@ximian.com>
8385 * statement.cs (Block.Resolve): Correctly handle unreachable code;
8386 do not call ResolveUnreachable() on unreachable statements in
8387 here, see the comment in the source code.
8389 2005-05-13 Raja R Harinath <rharinath@novell.com>
8392 * expression.cs (BinaryResolveOperator): If one of the operands of
8393 an equality comparison is 'null' and the other is a pointer type,
8394 convert the null to a NullPointer.
8395 * convert.cs (ImplicitReferenceConversion): If the expression is a
8396 NullLiteral and the target type is a pointer type, return a
8397 NullPointer instead.
8398 (ImplicitConversionStandard): Likewise.
8400 2005-05-13 Marek Safar <marek.safar@seznam.cz>
8402 * cs-parser.jay: Set readonly context based on special constructs.
8404 * expression.cs (LocalVariableReference.DoResolveBase): Improved
8405 readonly variable error handling.
8407 * rootcontext.cs (EmitCode): Don't verify members when error
8410 * statement.cs (LocalInfo): Add reaodnly context information.
8411 (SetReadOnlyContext, GetReadOnlyContext): New methods.
8413 2005-05-13 Raja R Harinath <rharinath@novell.com>
8415 * statement.cs (Block.Resolve): Revert change below. Modify fix
8416 for #74041 to initialize 'resolved' to false only for explicit
8417 blocks. Fixes #74873.
8419 2005-05-12 Raja R Harinath <harinath@gmail.com>
8422 * typemanager.cs (unmanaged_enclosing_types): New.
8423 (IsUnmanagedType): Avoid infloops by using
8424 'unmanaged_enclosing_types' to talk with recursive invocations.
8426 2005-05-13 Martin Baulig <martin@ximian.com>
8428 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
8429 instance variable, not a local. Fix #74873.
8430 (Block.ResolveUnreachable): Set it to true here.
8432 2005-05-11 Duncan Mak <duncan@novell.com>
8434 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
8435 continuing to process for 'arg'.
8436 (handle_preprocessing_directive): Check the argument of the #endif
8437 directive and report error CS1025 if there are any trailing
8440 According to the C# spec, having even whitespace after the #endif
8441 directive is illegal; however, because we call arg.TrimEnd ()
8442 beforehand, we have the same behavior as csc, allowing whitespace
8443 after the directive.
8447 2005-05-11 Marek Safar <marek.safar@seznam.cz>
8451 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
8452 (Constructor.GetObsoleteAttribute): Implemented correctly.
8454 2005-05-10 Martin Baulig <martin@ximian.com>
8456 * support.cs (ReflectionParameters.ParameterModifier): Use
8457 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
8458 and `ParameterAttributes.In'. Fixes #74884.
8460 2005-05-10 Marek Safar <marek.safar@seznam.cz>
8462 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
8464 * expression.cs (Argument.GetParameterModifier): Turned to property.
8465 (Invocation.Error_InvalidArguments): Add more descriptive errors.
8467 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
8470 2005-05-09 Raja R Harinath <rharinath@novell.com>
8473 * decl.cs (MemberCache.AddMethods): Register override methods,
8474 rather than non-override methods.
8475 * typemanager.cs (RegisterOverride): New.
8476 (IsOverride): Update.
8478 2005-05-09 Marek Safar <marek.safar@seznam.cz>
8482 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
8483 recursive declaration.
8485 * statement.cs (Block.ResolveMeta): Report any error in resolving.
8487 2005-05-06 Marek Safar <marek.safar@seznam.cz>
8489 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
8491 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
8493 2005-05-05 Raja R Harinath <rharinath@novell.com>
8496 * decl.cs (DeclSpace.FamilyAccessible):
8497 Use TypeManager.IsNestedFamilyAccessible.
8499 Fix reopened #64812.
8500 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
8503 2005-05-04 Raja R Harinath <rharinath@novell.com>
8504 Abin Thomas <projectmonokochi@rediffmail.com>
8505 Anoob V E <projectmonokochi@rediffmail.com>
8506 Harilal P R <projectmonokochi@rediffmail.com>
8509 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
8510 allow access to all static members.
8512 2005-05-04 Martin Baulig <martin@ximian.com>
8514 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
8516 2005-05-04 Martin Baulig <martin@ximian.com>
8520 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
8521 section at the end; make things work if `default' is not the last
8524 2005-05-04 Martin Baulig <martin@ximian.com>
8528 * statement.cs (Switch): Replaced the `got_default' field with a
8529 `default_section' one.
8530 (Switch.CheckSwitch): Set `default_section' here.
8531 (Switch.Resolve): If we're a constant switch and the constant is
8532 not found, use the default section.
8534 2005-05-03 Martin Baulig <martin@ximian.com>
8536 * expression.cs (ArrayAccess.EmitGetLength): New public method.
8538 * statement.cs (Foreach.ArrayForeach): New nested class.
8539 (Foreach.TemporaryVariable): New nested class.
8540 (Foreach.EmitArrayForeach): Removed; this is now in the new
8543 2005-05-03 Raja R Harinath <rharinath@novell.com>
8545 * pending.cs (BaseImplements): Move the #74773 fix here. This is
8547 (VerifyPendingMethods): Revert change below.
8549 * typemanager.cs (IsOverride, RegisterNonOverride): New.
8550 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
8551 that used to trigger warning -28. Remove warning -28.
8552 * expression.cs (Invocation.OverloadResolve): Use
8553 TypeManager.IsOverride to distinguish override methods.
8556 * pending.cs (VerifyPendingMethods): If a base type implements the
8557 requested interface, don't bother checking individual methods of
8558 the base type. As a side-effect, this prevents the creation of
8559 unnecessary proxies.
8561 2005-05-02 Martin Baulig <martin@ximian.com>
8565 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
8566 Also `And' the locals if the old vector is null.
8567 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
8568 null; in this case we basically reset all the variables.
8570 2005-05-02 Martin Baulig <martin@ximian.com>
8574 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
8575 Added `FlowBranching branching' argument; always `and' the
8576 variables instead of `or'ing them unless we're an infinite loop.
8578 * statement.cs (While.Resolve): Create a new sibling unless we're
8581 2005-05-02 Martin Baulig <martin@ximian.com>
8585 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
8586 arguments; use it instead of creating a new TopLevelBlock.
8587 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
8588 our ConstructorInitializer.
8591 (TopLevelBlock.TopLevelBranching): New public property.
8592 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
8593 and create our `TopLevelBranching'.
8595 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
8596 anonymous method host, use `block.TopLevelBranching' rather than
8597 creating a new branching.
8599 2005-04-20 Miguel de Icaza <miguel@novell.com>
8601 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
8602 a ScopeInfo, if any of the current children is a child of the new
8603 entry, move those children there.
8605 2005-04-30 Martin Baulig <martin@ximian.com>
8607 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
8608 at the beginning of a SwitchSection. Fix #73335.
8610 2005-04-27 Marek Safar <marek.safar@seznam.cz>
8613 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
8615 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
8616 (FieldExpr.DoResolve): Obsolete members are ignored for field
8619 2005-04-26 Marek Safar <marek.safar@seznam.cz>
8621 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
8622 of arrays detection.
8624 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
8626 (Field.VerifyClsCompliance): Volatile fields are not compliant.
8628 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
8631 2005-04-25 Ben Maurer <bmaurer@ximian.com>
8633 * cs-parser.jay: Use the prefered version of -unsafe in error
8636 2005-04-22 Marek Safar <marek.safar@seznam.cz>
8638 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
8641 2005-04-20 John Luke <john.luke@gmail.com>
8643 * driver.cs: fix typo in error message, --outout to --output
8645 2005-04-20 Marek Safar <marek.safar@seznam.cz>
8647 * codegen.cs (InRefOutArgumentResolving): New field.
8649 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
8650 fields outside contructor.
8652 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
8654 2005-04-19 Miguel de Icaza <miguel@novell.com>
8656 * anonymous.cs (CaptureContext.EmitParameterInstance): The
8657 parameter code was not completed ever, so it was not as up-to-date
8658 as local variables. Must finish it.
8660 The bug fix was to compare the Toplevel of the block, not the
8661 current block. Thanks for Ben for pointing this out.
8663 2005-04-19 Raja R Harinath <rharinath@novell.com>
8665 * decl.cs (AddMethods): Use the declaring type of the problem
8666 method to determine if we want to squash a warning.
8668 2005-04-19 Marek Safar <marek.safar@seznam.cz>
8670 * attribute.cs: Removed debug output.
8672 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
8674 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
8677 2005-04-18 Raja R Harinath <rharinath@novell.com>
8680 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
8681 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
8682 all null comparisons against reference types.
8684 2005-04-18 Marek Safar <marek.safar@seznam.cz>
8687 * class.cs (TypeContainer.CircularDepException) New nested
8689 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
8690 (TypeContainer.DefineType): Removed error, reset InTransit before
8692 (Class.DefineType): Throw exception when is in Transit.
8693 Catch exception and report error.
8694 (Struct.DefineType): Throw exception when is in Transit.
8695 Catch exception and report error.
8696 (Interface.DefineType): Throw exception when is in Transit.
8697 Catch exception and report error.
8699 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
8700 handle nested exception handlers.
8702 * flowanalysis.cs (InTryWithCatch): New method, search for try with
8705 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
8706 InFinally and InCatch storage.
8708 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
8709 (Catch.Resolve): Set and Restore ec.InCatch.
8710 (Try.Resolve): Set and Restore ec.InFinally.
8711 (Try.HasCatch): True when try has catch.
8713 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
8715 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
8716 for the same event member, so exclude such cases from warning 419.
8719 2005-04-16 Miguel de Icaza <miguel@novell.com>
8721 * expression.cs (Binary.ResolveOperator): Apply patch from John
8722 Luke to fix bug 59864: operators &, | and ^ on enumerations
8723 require that the same enum type on both sides.
8725 * driver.cs: Add warnings to old flag usage, this is to assist
8726 people who produce Makefiles and hope that the Makefiles will be
8729 * class.cs (TypeContainer.EmitType): Moved the definition of the
8730 special $PRIVATE$ field from the resolve phase to the Emit phase.
8731 During resolve we do not know if we are a struct with
8732 HasExplicitLayout, we know this only after the attributes for the
8735 Set the FieldOffset to zero on the dummy field that we create for
8736 the class. Fixes 74590.
8738 2005-04-16 Raja R Harinath <rharinath@novell.com>
8741 * ecore.cs (PropertyExpr.resolved): New.
8742 (DoResolve): Use it to handle a case of double resolution here.
8743 Handle a case of identical-name-and-type-name.
8744 * expression.cs (ArrayCreation.CheckIndices): Avoid double
8745 resolution by storing the results of expression resolution back
8746 into the "probes" array.
8748 2005-04-15 Raja R Harinath <rharinath@novell.com>
8750 Fix cs0208-7.cs and cs0208-8.cs.
8751 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
8752 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
8753 error reporting to point out the reason a struct is not unmanaged.
8755 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8757 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
8758 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
8760 2005-04-13 Raja R Harinath <rharinath@novell.com>
8763 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
8764 IdenticalNameAndTypeName here.
8765 (EventExpr.InstanceResolve): Likewise.
8767 2005-04-13 Marek Safar <marek.safar@seznam.cz>
8769 C# 2.0 DefaultCharSetAttribute implementation
8771 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
8772 which allows us to set GlobalNamespace for every resolve.
8773 (Attribute.ResolveArguments): Cut from Resolve.
8774 (Attribute.GetCharSetValue): Returns CharSet named argument.
8775 (Attribute.DefinePInvokeMethod): Gets default charset from
8777 (GlobalAttribute.ResolveAsTypeStep): Override.
8778 (GlobalAttribute.ResolveArguments): Override.
8780 * class.cs (TypeAttr): Is protected.
8782 * codegen.cs (ModuleClass.DefaultCharSet): New member.
8783 (ModuleClass.DefaultCharSetType): New memeber.
8784 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
8786 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
8787 charset from module.
8789 * delegate.cs (TypeAttr): Override.
8790 (Delegate.DefineType): Use this TypeAttr.
8792 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
8793 at very early stage (before types are defined) to resolve model
8794 module attributes. It will probably not work with corlib but it
8797 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
8798 charset from module.
8800 * typemanager.cs (default_charset_type): New type.
8802 2005-04-13 Raja R Harinath <rharinath@novell.com>
8804 * decl.cs (MemberCache.AddMethods): Don't warn if
8805 System.Object.Finalize has buggy MethodAttributes.
8807 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
8810 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8812 * doc.cs : detect ambiguous reference to overloaded members.
8813 Fixed bug #71603. MS 1.1 csc does not detect it.
8815 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8817 * doc.cs : delegates must not be referenced with parameters.
8820 2005-04-12 Miguel de Icaza <miguel@novell.com>
8822 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
8824 2005-04-10 Miguel de Icaza <miguel@novell.com>
8826 * driver.cs (MainDriver): Stop processing if the CLS stage found
8829 (CompilerCallableEntryPoint.InvokeCompiler): Always
8830 reset after execution; Take a TextWriter argument for the
8833 * report.cs: Use the error stream instead of hardcoding stderr.
8835 2005-04-09 Miguel de Icaza <miguel@novell.com>
8837 * class.cs: Reduce code paths to test, too small of an
8838 optimization to make it worth the extra testing. Always perform
8841 2005-04-08 Raja R Harinath <rharinath@novell.com>
8844 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
8845 operators that had errors reported on them.
8847 2005-04-08 Marek Safar <marek.safar@seznam.cz>
8849 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
8851 (Attribute.Resolve): Add named argument type checking.
8853 * class.cs (FixedField.Define): Use IsPrimitiveType
8855 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
8857 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
8858 unsafe parameter types.
8860 * statement.cs (Using.ResolveExpression): Add better error description.
8862 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
8864 2005-04-08 Raja R Harinath <rharinath@novell.com>
8867 * attribute.cs (Attribute.GetAttributeUsage): Resolve
8868 AttributeUsageAttribute in the emitcontext of the attribute class,
8869 not in the emitcontext of the attributable entity it was attached to.
8870 * cs-parser.jay: Use 'current_class', not 'current_container',
8871 when creating a GlobalAttribute.
8873 2005-04-08 Alp Toker <alp@atoker.com>
8875 * pending.cs: The fix to #58413 failed to compile methods implementing
8876 interfaces with/without params modifiers and vice versa, even though
8877 params modifiers aren't part of the signature. Make the modifier check
8878 less strict as in csc.
8880 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
8881 Anoob V E <projectmonokochi@rediffmail.com>
8882 Harilal P R <projectmonokochi@rediffmail.com>
8885 * pending.cs (TypeAndMethods.mods): New. Store the parameter
8886 modifiers of pending methods.
8887 (PendingImplementation.PendingImplementation): Initialize it.
8888 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
8889 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
8890 with ParameterData. Add check for modifiers.
8891 * class.cs (MethodData.Define): Update to changes.
8893 2005-04-07 Raja R Harinath <rharinath@novell.com>
8895 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
8897 2005-04-07 Marek Safar <marek.safar@seznam.cz>
8899 * class.cs (PropertyMethod.Define): Check private accessor in abstract
8902 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
8905 * typemanager.cs: Registered RequiredAttributeAttribute.
8907 2005-04-06 Marek Safar <marek.safar@seznam.cz>
8909 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
8910 Warning CS0169 is back at level 3.
8911 (IMethodData.SetMemberIsUsed): New method.
8913 * decl.cs (IsUsed): New value; moved from FieldBase.Status
8914 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
8916 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
8918 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
8920 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
8923 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
8926 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
8927 to avoid the problems with nested types.
8929 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
8930 Anoob V.E <projectmonokochi@rediffmail.com>
8931 Harilal P.R <projectmonokochi@rediffmail.com>
8932 Raja R Harinath <rharinath@novell.com>
8935 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
8937 * typemanager (GetConstructor): Make public.
8939 2005-04-05 John Luke <john.luke@gmail.com>
8940 Raja R Harinath <rharinath@novell.com>
8943 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
8944 struct too. Return false quicker in a few cases.
8945 (VerifyUnManaged): Use it.
8947 2005-04-05 Raja R Harinath <rharinath@novell.com>
8950 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
8951 not 'unreachable_seen'.
8953 2005-04-04 Marek Safar <marek.safar@seznam.cz>
8955 * attribute.cs (Attribute.GetValue): Removed unused.
8957 * codegen.cs (CodeGen.TrimExt): Removed unused.
8959 * cs-parser.jay (output): Removed unused.
8961 * cs-tokenizer.cs (hex_digits): Removed unused.
8963 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
8965 * expression.cs (Indirection.LoadExprValue): Removed unused.
8966 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
8968 * iterators.cs (Iterator.param_types): Removed unused.
8970 * statement.cs (Goto.block): Removed unused.
8971 (ToplevelBlock.did): Removed unused.
8972 (Switch.ResolveConstantSwitch): Removed unused.
8974 2005-04-01 Ben Maurer <bmaurer@ximian.com>
8976 * rootcontext.cs: Allow mcs to bootstrap with the compilation
8979 2005-04-01 Raja R Harinath <rharinath@novell.com>
8981 Fix #74232 and cs0208-3.cs.
8982 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
8983 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
8984 unmanaged type. Don't use FieldBuilders when 't' is a
8985 TypeBuilder. Use ModFlags and MemberType fields.
8986 * class.cs (MemberBase.member_type): Rename from MemberType.
8987 (MemberBase.MemberType): New property. Determines member_type on
8989 (MemberBase.DoDefine): Don't initialize MemberType here.
8990 (FieldMember.Define): Likewise.
8992 2005-04-01 Marek Safar <marek.safar@seznam.cz>
8995 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
8996 Attributes are emitted there.
8998 2005-04-01 Raja R Harinath <rharinath@novell.com>
9000 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
9001 keyword in 'partial enum' too.
9002 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
9004 Report from Kamil Skalski <nazgul@omega.pl>.
9007 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
9008 have partial containers too.
9010 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
9011 in block' checks to Block.CheckInvariantMeaningInBlock.
9012 * statement.cs (Block.GetKnownVariableInfo): Make private.
9013 (Block.IsVariableUsedInChildBlock): Remove.
9014 (Block.IsVariableUsedInBlock): Likewise.
9015 (Block.CheckInvariantMeaningInBlock): New. Show location of
9016 conflicting declaration.
9017 (Block.AddVariable): Make error messages less long-winded and more
9018 specific. Show location of conflicting declaration.
9019 * parameter.cs (Parameters.Location): New readonly property.
9021 2005-03-31 Raja R Harinath <rharinath@novell.com>
9023 Clean up semantics of invoking ResolveMemberAccess.
9024 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
9025 can have an instance, ensure that we pass in a non-TypeExpression
9026 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
9027 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
9028 argument. Update to changes and simplify.
9029 (FieldExpr.Emitinstance): Remove CS0120 check.
9030 (PropertyExpr.EmitInstance): Likewise.
9031 * expression.cs (Argument.Resolve): Likewise.
9032 (Invocation.DoResolve): Update to changes in semantics of
9035 2005-03-31 Marek Safar <marek.safar@seznam.cz>
9038 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
9041 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
9043 2005-03-31 Raja R Harinath <rharinath@novell.com>
9045 Fix difference in behaviour with commandline invocation.
9046 * driver.cs (Driver.Reset): New.
9047 (CompilerCallableEntryPoint): Call it.
9049 * statement.cs (If.Resolve): Avoid spurious "uninitialized
9050 variable" warnings if the boolean expression failed to resolve.
9052 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
9054 * attribute.cs: Fix the union of several permissions when some of them
9055 are unrestricted (so the result isn't an unrestricted permission set).
9058 2005-03-30 Raja R Harinath <rharinath@novell.com>
9060 * ecore.cs (MemberExpr): New class. Convert from interface
9062 (MemberExpr.ResolveMemberAccess): Refactor and move here from
9063 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
9065 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
9066 (MethodGroupExpr.IsExplicitImpl): Remove.
9067 (Expression.GetFieldFromEvent): Remove.
9068 (SimpleName.MemberStaticCheck): Remove.
9069 (SimpleName.DoSimpleNameResolve): Update to changes.
9070 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
9071 (MemberAccess.IdenticalNameAndTypeName): Remove.
9072 (MemberAccess.error176): Move to MemberExpr.
9073 (MemberAccess.DoResolve): Update to changes.
9074 (BaseAccess.DoResolve): Likewise.
9076 2005-03-30 Marek Safar <marek.safar@seznam.cz>
9078 C# 2.0 Conditional attribute class implementation
9080 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
9081 Analyzes class whether it has attribute which has ConditionalAttribute
9082 and its condition is not defined.
9084 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
9085 (Class.IsExcluded): New method. Search for at least one defined
9086 condition in ConditionalAttribute of attribute class.
9088 2005-03-30 Raja R Harinath <rharinath@novell.com>
9090 * ecore.cs (PropertyExpr): Derive from Expression, not
9091 ExpressionStatement.
9092 (PropertyExpr.EmitStatement): Remove.
9094 2005-03-29 Raja R Harinath <rharinath@novell.com>
9097 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
9098 internal field "value__" of an enum be private. The examples for
9099 "value__" that I found on MSDN all used FieldAttributes.Private.
9101 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
9102 Don't mention IL method attribute names.
9104 Fix #47991. Remove a TODO.
9105 * statement.cs (Block.Toplevel): Make into a field.
9106 (Block.Parameters): Move into ToplevelBlock.
9107 (Block.known_variables): Rename from child_variable_names.
9108 (Block.Block): Remove variants that take Parameters. Initialize
9109 'Toplevel' with the immediately surrounding toplevel block.
9110 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
9111 LocalInfo parameter.
9112 (Block.GetKnownVariableInfo): New.
9113 (Block.IsVariableNameUsedInChildBlock): Update.
9114 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
9115 the block, even though it may not be in scope.
9116 (Block.AddVariable): Remove Parameters parameter. Use
9117 Toplevel.Parameters instead.
9118 (Block.AddConstant): Remove Parameters parameter.
9119 (Block.GetParameterReference): Update to use Toplevel.Parameters.
9120 (Block.IsParamaterReference): Likewise.
9121 (Block.IsLocalParameter): Likewise. Simplify a lot.
9122 (ToplevelBlock.Parameters): New. Moved from Block.
9123 (ToplevelBlock.ToplevelBlock): Update to changes. Always
9124 initialize Parameters to a non-null value.
9125 * cs-parser.jay: Update to changes.
9126 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
9127 simple names that mean different things in the same block. Use
9128 Block.IsVariableNameUsedInBlock.
9130 2005-03-28 Raja R Harinath <rharinath@novell.com>
9132 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
9133 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
9134 GetTypeHandle. It is possible for a reflected type to derive from
9135 a TypeBuilder (e.g., int[] derives from the TypeBuilder
9136 System.Array during mscorlib compilation).
9137 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
9138 contain a method_hash, don't create one either. Don't create a
9139 deep copy of the base cache's method_hash.
9140 (MemberCache.SetupCache): Rename back from DeepCopy.
9141 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
9142 already initialized. If we see an override function, add its
9143 underlying base virtual function to the member_hash too.
9145 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
9147 2005-03-26 Raja R Harinath <harinath@acm.org>
9150 * assign.cs (Assign.DoResolve): When the RHS of an assignment
9151 fails to resolve, ensure that the LHS is still resolved as an
9154 2005-03-25 Raja R Harinath <harinath@acm.org>
9156 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
9158 (Enum.current_ec): Remove.
9159 (Enum.LookupEnumValue): Remove EmitContext argument.
9160 Just uses the one created during DefineType.
9161 (Enum.FindMembers): Update.
9162 * expression.cs (MemberAccess.DoResolve): Update.
9164 2005-03-22 Marek Safar <marek.safar@seznam.cz>
9166 * assign.cs (Assign.DoResolve): Check for CS1717 when
9167 source and target are same (uses Equals).
9169 * expression.cs (LocalVariableReference, ParameterReference,
9170 This): Implemented Equals, GetHashCode.
9172 * statement.cs (Block.GetParameterReference): Removed useless
9175 2005-03-22 Raja R Harinath <rharinath@novell.com>
9178 * statement.cs (Block.AddVariable): Ensure that we skip implicit
9179 blocks before deciding whether the error is cs0136 or cs0128.
9181 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
9182 (using_alias_directive, using_namespace_directive): Pass
9183 MemberName, not an expression to Namespace.UsingAlias and
9185 (MakeName): Use the MemberName of the namespace.
9186 * namespace.cs (Namespace.MemberName): New.
9187 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
9188 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
9190 * decl.cs (MemberName.Name): Make readonly.
9191 (MemberName.FromDotted): New "constructor".
9192 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
9193 (MemberCore.Name): Compute from MemberName on demand.
9194 (MemberCore.SetMemberName): Provide a way to change the
9196 (MemberCore.AddToContainer): Don't take a fullname parameter.
9197 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
9198 fully qualified name of the container to the member name.
9199 (TypeContainer.AddToTypeContainer): Use a fully qualified name
9200 only if the type is a member of the root container.
9201 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
9202 MemberName.Left rather than searching for an embedded ".".
9203 (PartialContainer.CreatePart): Update to changes in RootContext.
9204 (MemberBase.ShortName): Turn into a property. Use
9205 MemberCore.SetMemberName.
9206 (MemberBase.ExplicitInterfaceName): Remove.
9207 (MemberBase.UpdateMemberName): Remove.
9208 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
9209 (PropertyBase.SetMemberName): New override.
9210 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
9211 (Tree.GetDecl): New.
9212 (Tree.AllDecls): Rename from Decls.
9213 * attribute.cs, enum.cs, report.cs: Update to changes.
9214 * driver.cs (MainDriver): Use MemberName.FromDotted on
9215 RootContext.MainClass.
9217 2005-03-21 Marek Safar <marek.safar@seznam.cz>
9219 * class.cs (FixedField.Define): Check for CS1664 and more sanity
9222 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
9224 2005-03-18 Marek Safar <marek.safar@seznam.cz>
9226 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
9227 property accessor modifiers.
9229 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
9230 fixed buffer attribute (CS1716).
9231 (PropertyMethod.HasCustomAccessModifier): When property accessor
9232 has custom modifier.
9234 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
9236 (PropertyExpr.DoResolveLValue): Add CS0272.
9238 2005-03-17 Miguel de Icaza <miguel@novell.com>
9240 * convert.cs: When converting to a pointer, use the proper Conv.U
9241 or Conv.I depending on the source data type.
9243 * cs-tokenizer.cs: Make the size for large decimal constants,
9246 2005-03-17 Martin Baulig <martin@ximian.com>
9248 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
9249 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
9251 2005-03-17 Martin Baulig <martin@ximian.com>
9253 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
9254 to bool so we can return an error condition.
9255 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
9258 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
9260 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
9263 2005-03-16 Raja R Harinath <rharinath@novell.com>
9265 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
9266 Refactor to avoid traversing the list of assemblies, and to avoid
9267 string concatenation.
9268 * typemanager.cs (guid_attr_type): Remove.
9269 (negative_hits, pointers, references): Remove hashes.
9271 (GetConstructedType): New. Uses type_hash to handle constructed
9272 types (arrays, references, pointers).
9273 (GetReferenceType, GetPointerType): Use it.
9274 (GetNestedType): New. Uses type_hash to handle nested types of
9276 (LookupType, LookupTypeDirect): Remove.
9277 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
9278 'types' hash and LookupTypeReflection directly.
9279 (params_string, params_object): Use GetConstructedType.
9280 * namespace.cs (Namespace.cached_types): New. Cache of reflected
9282 (Namespace.Lookup): Use cached_types.
9283 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
9284 provided by old TypeManager.LookupType.
9285 * rootcontext.cs (MakeFQN): Remove.
9286 * decl.cs (DeclSpace.MakeFQN): Likewise.
9287 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
9288 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
9289 TypeManager.GetConstructedType.
9290 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
9292 2005-03-15 Marek Safar <marek.safar@seznam.cz>
9294 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
9297 * cs-parser.jay: Reports CS1527 for any namespace element.
9299 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
9302 * expression.cs (ParameterReference.IsAssigned): Changed error to
9304 (Error_WrongNumArguments): Moved CS0245 detection here.
9306 * statement.cs (Return.Resolve): Add CS1622 report.
9308 2005-03-11 Marek Safar <marek.safar@seznam.cz>
9310 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
9312 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
9314 * attribute.cs expression.cs: Get rid of some allocations.
9316 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
9318 * doc.cs : just eliminate the latest change.
9320 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9322 * doc.cs : commented out the latest change. It breaks xml-030.cs
9324 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9326 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
9327 fail. So invoke CreateType() in FindDocumentedType().
9329 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9331 * cs-tokenizer.cs : added IsKeyword().
9332 * doc.cs : Detect keyword incorrectly used as identifier.
9333 Allow identifiers prefixed by @.
9335 2005-03-10 Marek Safar <marek.safar@seznam.cz>
9337 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
9338 It caused exception in namespace resolving (again!).
9340 * class.cs (Class.ctor): Removed exit.
9341 (PropertyMethod.ctor): ditto.
9343 * codegen.cs (Codegen.Reset): Reset static data.
9344 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
9346 * cs-tokenizer.cs (Cleanup): Removed.
9348 * driver.cs (GetSystemDir): Rewrote to one line command.
9349 It caused problem with unloaded dynamic modules.
9350 (UnixParseOption): Removed Exit.
9351 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
9352 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
9353 Now can be mcs used as library.
9355 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
9358 * location.cs (Reset): Reset static data.
9360 * namespace.cs (Reset): Reset static data.
9362 * report.cs (Report.Reset): Reset static data.
9364 * rootcontext.cs (RootContext.Reset): Reset static data.
9366 * tree.cs (RootTypes.ctor): Use Location.Null
9368 * typemanager.cs (TypeManager.Reset): Reset static data.
9369 (CoreLookupType): Removed Exit.
9370 (TypeHandle.Reset): Reset static data.
9372 2005-03-10 Raja R Harinath <rharinath@novell.com>
9375 * typemanager.cs (ComputeNamespaces): Import namespaces from
9376 referenced modules too.
9378 2005-03-09 Raja R Harinath <rharinath@novell.com>
9380 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
9383 2005-03-09 Raja R Harinath <rharinath@novell.com>
9385 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
9386 enclosing DeclSpace. This ensures that a name-lookup populates
9387 more caches and there are fewer 'TypeExpression's. Carve out
9388 nested type lookup into ...
9389 (LookupNestedTypeInHierarchy): ... this.
9391 2005-03-09 Raja R Harinath <rharinath@novell.com>
9393 Clean up a few partial-class semantics.
9394 Fixes test-357.cs and cs1618-2.cs.
9395 * cs-parser.jay (struct_declaration): Use 'current_class' as
9396 parent of newly-created struct. Remove call to Register ().
9397 Use 'pop_current_class' to complete handing the current struct.
9398 (interface_declaration): Likewise.
9399 (class_declaration): Likewise.
9400 (enum_declaration): Use 'current_class' as parent of newly created
9402 (delegate_declaration): Likewise.
9403 (pop_current_class): New function. This is used to handle closing
9404 up the 'current_class' and 'current_container', and pointing them
9405 to the enclosing class/container.
9406 (CSharpParser): Initialize 'current_class' too.
9407 * decl.cs (MemberCore): Add check for invariant: a partial
9408 container is not a parsed entity, and thus does not enclose any
9410 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
9411 (DeclSpace.BaseTypeExpr): Use it.
9412 (DeclSpace.LookupType): Add check for invariant.
9413 * class.cs (TypeContainer): Add check for invariant: a nested
9414 class should have the same NamespaceEntry as its enclosing class.
9415 (TypeContainer.EmitFieldInitializers): Make virtual.
9416 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
9418 (TypeContainer.Register): Remove.
9419 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
9420 null. Use TypeResolveEmitContext for resolving base types and
9421 interfaces. Move initialization of Parts.TypeBuilder here from
9423 (TypeContainer.DefineNestedTypes): ... here.
9424 (PartialContainer): Take a Namespace not a NamespaceEntry.
9425 (PartialContainer.Create): Don't use Register. Call the
9426 appropriate Add... function directly.
9427 (ClassPart): Take both the PartialContainer and the enclosing
9428 class as constructor arguments.
9429 (ClassPart.EmitFieldInitializers): Override.
9430 (ClassPart.PartFindNestedTypes): Remove.
9431 (FieldBase.GetInitializerExpression): Resolve the initializer
9432 expression in the emit context of the enclosing class.
9433 * tree.cs (RootTypes): Remove Register ().
9435 2005-03-08 Marek Safar <marek.safar@seznam.cz>
9437 * cs-parser.jay: Removed CS0134.
9439 * driver.cs: Removed CS1901.
9441 * expression.cs (SizeOf.DoResolve): Don't report CS0233
9442 for predefined types.
9444 2005-03-07 Duncan Mak <duncan@novell.com>
9446 * codegen.cs (Save): Catch UnauthorizedAccessException as
9447 well. Fixes bug #73454.
9449 2005-03-07 Marek Safar <marek.safar@seznam.cz>
9451 * cs-tokenizer.cs (xtoken): Add CS1035.
9453 * class.cs (MethodData.Define): Add CS0683.
9454 (FieldMember.ctor): Add CS0681.
9456 2005-03-07 Raja R Harinath <rharinath@novell.com>
9458 * ecore.cs (SimpleName.DoResolve): Rename from
9459 SimpleName.DoResolveAllowStatic.
9460 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
9461 Pass 'intermediate' flag to MemberStaticCheck.
9462 (SimpleName.MemberStaticCheck): Skip "static check" only in case
9463 of "intermediate" lookups via MemberAccess.
9464 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
9465 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
9467 2005-03-07 Raja R Harinath <rharinath@novell.com>
9470 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
9471 slipped in because of variable names that are identical to a
9472 builtin type's BCL equivalent ('string String;', 'int Int32;').
9473 (PropertyExpr.EmitInstance): Likewise.
9475 2005-03-04 Marek Safar <marek.safar@seznam.cz>
9477 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
9479 * report.cs (warning_ignore_table): Made public.
9481 2005-03-04 Raja R Harinath <rharinath@novell.com>
9484 * class.cs (MethodData.Emit): Pass 'container' to
9485 container.GetObsoleteAttribute instead of 'container.Parent'.
9487 2005-03-03 Marek Safar <marek.safar@seznam.cz>
9489 * cs-parser.jay: Add 1534 error test.
9491 * iterators.cs (Yield.CheckContext): Add error 1629.
9492 (Iterator.ctor): Save unsafe modifier.
9493 (MoveNextMethod.DoEmit): Restore unsafe context.
9495 * namespace.cs (UsingAlias): Better error message.
9497 2005-03-03 Dan Winship <danw@novell.com>
9499 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
9500 the warning message [#73219]
9502 2005-03-03 Raja R Harinath <rharinath@novell.com>
9504 Fix compile with MCS 1.0.0.0.
9505 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
9506 w_restore to not depend on string constant folding.
9508 2005-03-03 Raja R Harinath <rharinath@novell.com>
9510 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
9511 CS0246 check to users who passed 'silent = false'.
9512 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
9514 (SimpleName.SimpleNameResolve): Update.
9515 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
9516 (MemberAccess.IdenticalNameAndTypeName): Update.
9517 * doc.cs (FindDocumentedTypeNonArray): Update.
9519 2005-03-03 Raja R Harinath <rharinath@novell.com>
9521 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
9522 * parameters.cs (ComputeAndDefineParameters): Remove.
9523 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
9524 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
9525 Use GetParameterInfo.
9527 2005-03-02 Marek Safar <marek.safar@seznam.cz>
9529 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
9531 2005-03-02 Raja R Harinath <rharinath@novell.com>
9533 Unify DeclSpace.LookupType and DeclSpace.FindType.
9534 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
9535 is in charge of defining nested types on demand.
9536 (DeclSpace.LookupType): Use it when the current_type is a
9537 TypeBuilder. Use LookupTypeDirect for reflected types.
9538 (DeclSpace.FindType): Remove.
9539 (DeclSpace.LookupInterfaceOrClass): Likewise.
9540 (DeclSpace.DefineTypeAndParents): Likewise.
9541 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
9542 DeclSpace.LookupType.
9543 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
9544 * typemanager.cs (LookupType): Simplify.
9545 (AddUserType): Remove type from negative_hits.
9546 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
9547 * class.cs (TypeContainer.FindMembers): Move handling of nested
9549 (TypeContainer.FindMembers_NestedTypes): ... here.
9550 (TypeContainer.FindNestedType): Implement override.
9551 (ClassPart.FindNestedType): Delegate to PartialContainer.
9552 (ClassPart.PartFindNestedType): Looks up the nested types of the
9555 2005-03-02 Martin Baulig <martin@ximian.com>
9557 * class.cs (TypeContainer.DoDefineMembers): We also need a default
9558 static constructor in static classes.
9560 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
9562 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
9563 sizeParamIndex is not specified.
9565 2005-03-01 Marek Safar <marek.safar@seznam.cz>
9568 * report.cs (WarningMessage.IsEnabled): Missing null check.
9570 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9572 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
9573 in the fields and not in the properties.
9575 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
9577 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
9580 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9582 * attribute.cs: Small refactoring (improved robustness).
9583 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
9584 (ValidateGuid): Removed.
9585 (Resolve): Removed referenced to above mentioned.
9586 (GetAttributeUsage): Made private and changed to work without
9588 (GetIndexerAttributeValue): Don't crash.
9589 (GetConditionalAttributeValue): Ditto.
9590 (GetClsCompliantAttributeValue): Ditto.
9591 (ExtractSecurityPermissionSet): All attributes exceptions are
9593 (GetPropertyValue): New helper.
9594 (GetMethodImplOptions): New method.
9595 (DefinePInvokeMethod): Reuse common code. Implemented handling of
9596 some missing properties.
9598 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
9599 (Method.ApplyAttributeBuilder): Updated.
9601 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
9604 2005-02-28 Raja R Harinath <rharinath@novell.com>
9607 * report.cs (Report.SymbolRelatedToPreviousError): Handle
9608 non-simple types (array, pointer, reference).
9610 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9612 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
9614 * class.cs (MethodCore.IsDuplicateImplementation): Special error
9616 (Method.CheckBase): Catch wrong destructor here.
9617 (MethodData.Define): Add errors 550, 668.
9619 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
9621 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
9623 * pending.cs (VerifyPendingMethods): Add error 551.
9625 * typemanager.cs (CSharpName): Next error report helper.
9627 2005-02-25 Marek Safar <marek.safar@seznam.cz>
9629 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
9630 attributes. Removed useless attribute double check.
9631 It saves almost 2MBs for corlib.
9633 2005-02-25 Raja R Harinath <rharinath@novell.com>
9636 * statement.cs (ExpressionStatement.Resolve): Make robust to being
9637 called twice in case of error.
9639 2005-02-23 Chris Toshok <toshok@ximian.com>
9641 Fix compiler portions of #72827.
9642 * statement.cs (Block.Emit): call Begin/EndScope on the
9643 EmitContext instead of the ILGenerator.
9645 * codegen.cs (EmitContext.BeginScope): new method, call
9646 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
9648 (EmitContext.BeginScope): same, but EndScope and CloseScope
9650 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
9651 offset and call the superclass's OpenScope(int) with it.
9652 (SymbolWriter.CloseScope): get the current il
9653 offset and call superclass's CloseScope(int) with it.
9655 2005-02-23 Marek Safar <marek.safar@seznam.cz>
9657 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
9658 CS1677 for out and ref as well.
9660 * class.cs (Method.Define): Add error CS1599 detection.
9662 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
9664 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
9666 * delegate.cs (Delegate.Define): Add error CS1599 detection.
9668 * support.cs.cs (ModifierDesc): New helper method.
9670 2005-02-23 Raja R Harinath <rharinath@novell.com>
9671 Abin Thomas <projectmonokochi@rediffmail.com>
9672 Anoob V E <projectmonokochi@rediffmail.com>
9673 Harilal P R <projectmonokochi@rediffmail.com>
9676 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
9677 MemberLookup (used for error reporting) actually returns a result.
9678 Fix error report number (122, not 112).
9680 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
9681 Anoob V E <projectmonokochi@rediffmail.com>
9682 Harilal P R <projectmonokochi@rediffmail.com>
9685 * pending.cs (PendingImplementation.GetAbstractMethods):
9686 Find NonPublic members too.
9688 2005-02-22 Marek Safar <marek.safar@seznam.cz>
9690 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
9693 * class.cs (MethodCore.CheckMethodAgainstBase):
9694 Add error 239 report.
9696 2005-02-21 Raja R Harinath <rharinath@novell.com>
9699 * expression.cs (Invocation.IsApplicable): Make public.
9700 (Invocation.IsParamsMethodApplicable): Likewise.
9701 * delegate.cs (Delegate.VerifyApplicability): Don't use
9702 Invocation.VerifyArgumentCompat for parameter applicability
9703 testing. Use Invocation.IsApplicable and
9704 Invocation.IsParamsMethodApplicable.
9706 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9708 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
9710 * class.cs (Operator.Define): Add error 217 report.
9712 2005-02-21 Raja R Harinath <rharinath@novell.com>
9714 * namespace.cs (UsingEntry.Resolve): Undo change below.
9716 2005-02-21 Raja R Harinath <rharinath@novell.com>
9719 * ecore.cs (Expression.MemberLookupFailed): Add argument to
9720 disable the error message when the extended MemberLookup also
9722 (Expression.MemberLookupFinal): Update.
9723 (SimpleName.DoSimpleNameResolve): Update.
9724 * expression.cs (MemberAccess.ResolveNamespaceOrType):
9725 Don't use MemberLookupFinal.
9726 (New.DoResolve): Update.
9727 (BaseAccess.CommonResolve): Update.
9729 2005-02-21 Raja R Harinath <rharinath@novell.com>
9732 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
9733 occured previously, don't resolve again.
9735 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9738 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
9739 argument. Call ResolveAttributeUsage for unresolved.
9740 when types doesn't match ctor arguments.
9742 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
9743 for nested attribute classes.
9744 (Class.attribute_usage): Removed.
9745 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
9746 for attribute class.
9748 * ecore.cs (IsAttribute): Removed.
9750 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
9752 * rootcontext.cs (RegisterAttribute): Removed, attributes are
9754 (attribute_types): Removed.
9755 (EmitCode): Global attributes are emited as the latest.
9757 2005-02-18 Marek Safar <marek.safar@seznam.cz>
9759 * class.cs (EmitFieldInitializers): Don't emit field initializer
9760 for default values when optimilization is on.
9762 * constant.cs (Constant.IsDefaultValue): New property.
9764 * driver.cs: Add /optimize handling.
9768 * literal.cs: Implement new IsDefaultValue property.
9770 * rootcontext.cs (Optimize): New field, holds /optimize option.
9772 2005-02-18 Raja R Harinath <rharinath@novell.com>
9774 Fix crasher in re-opened #72347.
9775 * namespace.cs (Namespace.Lookup): Return null if
9776 DeclSpace.DefineType returns null.
9779 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
9781 2005-02-18 Raja R Harinath <rharinath@novell.com>
9783 Fix remainder of #63202. Change semantics of DoResolveLValue: it
9784 now returns null if it cannot resolve to an lvalue.
9785 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
9786 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
9787 returned null. Remove check for SimpleName.
9788 (EventExpr.DoResolveLValue): New.
9789 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
9790 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
9792 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
9794 (Unary.ResolveOperator): Move CS0211 check ...
9795 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
9797 (Unary.DoResolveLValue): Simplify.
9798 (AddressOf.DoResolveLValue): New.
9799 (ArrayAccess.DoResolveLValue): New.
9801 2005-02-16 Marek Safar <marek.safar@seznam.cz>
9803 * attribute.cs (Attribute.Resolve): Add arguments casting for
9804 when types doesn't match ctor arguments.
9806 2005-02-16 Raja R Harinath <rharinath@novell.com>
9808 Fix parts of #63202.
9809 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
9810 lookup of operator in base type. Ensure that all checks happen
9811 when the operator resolves to an "op_..." method.
9813 2005-02-15 Raja R Harinath <rharinath@novell.com>
9816 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
9817 'ignore_cs0104' parameter. Pass it to ...
9818 (NamespaceEntry.Lookup): ... this.
9819 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
9820 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
9821 (TypeLookupExpression.DoResolveAsTypeStep): Update.
9822 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
9823 Update. Request that cs0104 errors be ignored.
9824 (ComposedCast.ResolveAsTypeStep): Update.
9826 2005-02-14 Raja R Harinath <rharinath@novell.com>
9829 * expression.cs (Invocation.BetterFunction): Remove support for
9830 comparing virtual functions and their overrides.
9831 (Invocation.IsOverride): New.
9832 (Invocation.OverloadResolve): Don't consider 'override' functions
9833 during candidate selection. Store them in a lookaside list.
9834 If the selected method is a 'virtual' function, use the list to
9835 find any overrides that are closer to the LHS type.
9837 2005-02-14 Marek Safar <marek.safar@seznam.cz>
9839 * expression.cs (New.DoResolve): Add complex core type reduction.
9840 (New.Constantify): Converts complex core type syntax like 'new int ()'
9843 2005-02-14 Raja R Harinath <rharinath@novell.com>
9845 * decl.cs (EntryType.EntryType): New constructor to create an
9846 updated copy of a cache entry.
9847 (MemberCache.AddMethods): Use it.
9848 (MemberCache.ClearDeclaredOnly): Remove.
9849 (MemberCache.MemberCache): Update.
9851 2005-02-11 Miguel de Icaza <miguel@novell.com>
9853 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
9854 variable. This one is represents the actual low-level declaration
9855 of the method, as opposed to the semantic level `IsStatic'.
9857 An anonymous method which is hosted into a static method might be
9858 actually an instance method. IsStatic would reflect the
9859 container, while MethodIsStatic represents the actual code
9862 * expression.cs (ParameterReference): Use the new MethodIsStatic
9863 instead of IsStatic.
9865 * anonymous.cs (AnonymousMethod.Compatible): Pass the
9866 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
9867 set on the current EmitContext.
9869 * expression.cs (Cast): Overload DoResolveLValue so we can pass
9870 resolve our casted expression as an LValue. This triggers the
9871 proper LValue processing that is later required by Assign.
9875 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
9877 2005-02-11 Marek Safar <marek.safar@seznam.cz>
9879 C# 2.0 Fixed buffer implementation
9881 * anonymous.cs: Update after RegisterHelperClass renaming.
9883 * attribute.cs (AttributeTester.fixed_buffer_cache):
9884 Cache of external fixed buffers.
9885 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
9886 implementation if field is fixed buffer else null.
9889 (TypeContainer.AddField): Accept FieldMember instead of Field.
9890 (FieldBase.IsFieldClsCompliant): Extracted code from
9891 VerifyClsCompliance descendant customization.
9892 (FixedField): New class handles fixed buffer fields.
9893 (FixedFieldExternal): Keeps information about imported fixed
9895 (IFixedField): Make access to internal or external fixed buffer
9898 * cs-parser.jay: Add fixed buffer parsing.
9900 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
9903 * expression.cs (Indirection): Extended implementation to accept
9905 (PointerArithmetic.Emit): Get element from fixed buffer as well.
9906 (ElementAccess.MakePointerAccess): Get type as parameter.
9907 (DoResolve): Add fixed buffer field expression conversion.
9908 (DoResolveLValue): Ditto.
9909 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
9910 (ArrayPtr): Derives from FixedBufferPtr.
9911 (ArrayPtr.Emit): Add extra emit for array elements.
9913 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
9915 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
9916 for compiler generated types.
9917 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
9919 * statement.cs (Fixed): Refactored to be easier add fixed buffer
9920 and consume less memory.
9921 (Fixed.Resolve): Add fixed buffer case.
9923 * typemanager.cs (compiler_generated_attr_ctor,
9924 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
9925 (HasElementType): Add our own implementation to work on every
9928 2005-02-11 Miguel de Icaza <miguel@novell.com>
9930 * anonymous.cs (CaptureContext): Track whether `this' has been
9933 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
9934 only captured `this' if it was implicitly done (instance
9935 methods/variables were used).
9937 * codegen.cs (EmitContext.CaptureThis): New method to flag that
9938 `this' must be captured.
9940 2005-01-30 Miguel de Icaza <miguel@novell.com>
9942 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
9943 is null it means that there has been no need to capture anything,
9944 so we just create a sibling.
9946 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
9948 Just a partial fix. The other half is fairly elusive.
9950 2005-02-10 Raja R Harinath <rharinath@novell.com>
9952 Fix #52586, cs0121-4.cs.
9953 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
9954 and return a hashtable.
9955 (MemberCache.ClearDeclaredOnly): New.
9956 (MemberCache.MemberCache): Update to change. Make a deep copy of
9957 the method_hash of a base type too.
9958 (MemberCache.AddMethods): Adapt to having a deep copy of the base
9959 type methods. Overwrite entries with the same MethodHandle so
9960 that the ReflectedType is correct. The process leaves in base
9961 virtual functions and their overrides as distinct entries.
9962 (CacheEntry): Now a class instead of a struct. It shouldn't alter
9963 matters since it was boxed in a ArrayList before.
9964 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
9966 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
9967 case of a virtual function and its override (choose the overload
9969 (Invocation.OverloadResolve): Avoid 'override' members during
9970 'applicable_type' calculation.
9972 2005-02-09 Raja R Harinath <rharinath@novell.com>
9974 Combine two near-redundant caches.
9975 * typemanager.cs (method_params): Rename from method_internal_params.
9976 (TypeManager.GetParameterData): New. Replace
9977 Invocation.GetParameterData.
9978 (TypeManager.LookupParametersByBuilder): Remove.
9979 * expression.cs (Invocation.method_parameter_cache): Remove.
9980 (Invocation.GetParameterData): Remove.
9982 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
9985 2005-02-08 Raja R Harinath <rharinath@novell.com>
9988 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
9989 TypeManager.multicast_delegate_type is null, resolve it by looking
9990 up "System.MulticastDelegate".
9991 * rootcontext.cs (RootContext.ResolveCore): Simplify.
9993 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
9994 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
9995 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
9998 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
9999 (LabeledStatement.AddReference): New. Set 'referenced'.
10000 (Goto.Resolve): Use it.
10002 2005-02-05 John Luke <john.luke@gmail.com>
10004 * driver.cs: remove duplicate -doc line in Usage ()
10006 2005-02-04 Raja R Harinath <rharinath@novell.com>
10008 * location.cs (Location.AddFile): Fix CS2002 error report.
10010 2005-02-02 Martin Baulig <martin@ximian.com>
10012 * delegate.cs (Delegate.DefineType): Report an internal error if
10013 TypeManager.multicast_delegate_type is null. See bug #72015 for
10016 2005-02-02 Raja R Harinath <rharinath@novell.com>
10018 Fix a crasher in a variant of #31984.
10019 * const.cs (Constant.CheckBase): New override that defers the
10020 new-or-override check in case the base type hasn't been populated
10022 (Constant.Define): Ensure the new-or-override check is performed.
10024 2005-02-01 Duncan Mak <duncan@ximian.com>
10026 * const.cs (LookupConstantValue): Check that `ce' is not null
10027 before calling GetValue ().
10029 2005-02-01 Raja R Harinath <rharinath@novell.com>
10031 Fix test-334.cs (#69519).
10032 * cs-parser.jay (using_alias_directive): Pass in an expression to
10033 NamespaceEntry.UsingAlias.
10034 (using_namespace_directive): Pass in an expression to
10035 NamespaceEntry.Using.
10036 (namespace_name): Don't flatten to a string.
10037 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
10038 (NamespaceEntry.AliasEntry.Resolve): Lookup using
10040 (NamespaceEntry.UsingEntry): Likewise.
10041 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
10043 (NamespaceEntry.LookupForUsing): Remove.
10044 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
10046 (NamespaceEntry.Lookup): Remove support for dotted names.
10048 2005-02-01 Raja R Harinath <rharinath@novell.com>
10050 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
10052 (NamespaceEntry.ImplicitParent): Compute on demand.
10053 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
10054 parallels the current.
10055 (NamespaceEntry.LookupForUsing): Use it.
10056 (NamespaceEntry.Lookup): If the current namespace-entry is
10057 implicit, don't search aliases and using tables.
10059 2005-02-01 Raja R Harinath <rharinath@novell.com>
10062 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
10064 (TypeContainer.BaseCache): Compute on demand.
10065 (TypeContainer.FindMembers): Define constants and types if they're
10066 not already created.
10067 (FieldMember.Define): Move resetting of ec.InUnsafe before error
10069 * const.cs (Constant.Define): Make idempotent.
10071 2005-01-29 Miguel de Icaza <miguel@novell.com>
10073 * pending.cs: Produce better code (no nops produced by using Ldarg
10076 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
10077 i - 1' it should be arg + 1.
10081 2005-01-28 Raja R Harinath <rharinath@novell.com>
10083 * attribute.cs (Attribute.CheckAttributeType): Make private
10085 (Attribute.ResolveType): Make virtual.
10086 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
10087 handling of RootContext.Tree.Types.
10089 2005-01-27 Raja R Harinath <rharinath@novell.com>
10091 Update attribute-handling to use the SimpleName/MemberAccess
10093 * cs-parser.jay (attribute): Pass in an expression to the
10094 constructors of Attribute and GlobalAttribute.
10095 * attribute.cs (Attribute): Take an expression for the name.
10096 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
10097 passed in attribute name expression.
10098 (Attribute.CheckAttributeType): Use it.
10099 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
10100 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
10101 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
10102 argument to prevent error messages if the lookup fails.
10104 2005-01-27 Marek Safar <marek.safar@seznam.cz>
10106 * expression.cs (Indirection): Implemented IVariable interface
10107 to support indirection in AddressOf operator.
10108 (PointerArithmetic.Emit): Add optimalization for case where
10109 result can be precomputed.
10111 2005-01-26 Martin Baulig <martin@ximian.com>
10113 * class.cs (TypeContainer.AttributeTargets): Return the correct
10114 AttributeTargets depending on our `Kind' instead of throwing an
10115 exception; fixes #71632.
10117 2005-01-26 Marek Safar <marek.safar@seznam.cz>
10120 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
10123 2005-01-25 Raja R Harinath <rharinath@novell.com>
10126 * expression.cs (MemberAccess.DoResolve): Don't complain with
10127 cs0572 when the LHS of a member access has identical name and type
10130 2005-01-25 Marek Safar <marek.safar@seznam.cz>
10133 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
10135 Create custom PermissionSet only for PermissionSetAttribute.
10137 2005-01-24 Marek Safar <marek.safar@seznam.cz>
10140 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
10141 delegates in static class.
10143 2005-01-24 Martin Baulig <martin@ximian.com>
10145 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
10146 merging an implicit block, just use its reachability.
10148 * statement.cs (Block.Resolve): Make the unreachable code check
10149 work wrt. implicit blocks; see test-337 from #63842.
10151 2005-01-21 Alp Toker <alp@atoker.com>
10153 * cs-parser.jay: destructor_declaration's container is PartialContainer
10154 not Class when partial types are used, so use Kind prop instead of
10157 2005-01-22 Miguel de Icaza <miguel@ximian.com>
10159 * cs-parser.jay: Improve error reporting when an interface
10160 declares new types.
10162 2005-01-20 Dick Porter <dick@ximian.com>
10164 * support.cs: SeekableStreamReader fix from Sandor Dobos
10165 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
10166 chars are read. Fixes bug 70369.
10168 2005-01-20 Raja R Harinath <rharinath@novell.com>
10170 * cs-parser.jay (catch_clause): Simplify current_block handling
10173 2005-01-17 Miguel de Icaza <miguel@ximian.com>
10175 * convert.cs (ImplicitStandardConversionExists): Synchronize the
10176 code with ImplicitStandardConversion to handle the implicit
10177 conversion of method groups into valid delegate invocations.
10179 The problem is that in parameter handling we were using this code
10180 path. Fixes bug #64698
10182 2005-01-19 Raja R Harinath <rharinath@novell.com>
10184 * cs-parser.jay: Fix several infelicities.
10185 - Avoid assigning to the parser value stack. Code like
10186 '$3 = null' is unclean. Synthesize a value for the code block
10188 - Avoid using oob_stack for storing location information. Use ...
10189 (_mark_): ... this. New (empty) rule. Saves the current location
10191 (foreach_statement): Avoid using oob_stack for current_block
10192 handling. Use technique used in for_statement and
10193 using_statement. Synthesize a value for the code block to store
10194 additional intermediate information.
10196 2005-01-13 Miguel de Icaza <miguel@ximian.com>
10198 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
10199 of a different type is only allowed to private fields of a
10200 containing type, not on fields of a base class.
10202 See test-174.cs and error cs0122-9.cs
10204 2005-01-13 Raja R Harinath <rharinath@novell.com>
10206 Fix test-335.cs (bug #58126).
10207 * cs-parser.jay (argument): Split out non-expression parts of the
10208 rule into 'non_simple_argument'.
10209 (invocation_expression): Support parenthesized invocations with
10210 multiple arguments, and with single non-simple arguments.
10212 2005-01-13 Raja R Harinath <rharinath@novell.com>
10214 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
10217 2005-01-12 Raja R Harinath <rharinath@novell.com>
10219 Fix cs0038-1.cs, cs1640-6.cs.
10220 * ecore.cs (Expression.Resolve): Remove special-case for
10221 SimpleName in error-handling.
10222 (Expression.almostMatchedMembers): Relax access permission to
10224 (Expression.MemberLookupFailed): Handle duplicates in
10225 almostMatchedMembers list.
10226 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
10227 * expression.cs (New.DoResolve): Report CS1540 for more cases.
10228 * typemanager.cs (GetFullNameSignature): Use the MethodBase
10229 overload if the passed in MemberInfo is a MethodBase.
10231 2005-01-12 Marek Safar <marek.safar@seznam.cz>
10234 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
10235 for non-CAS & merge permission sets properly.
10237 2005-01-11 Raja R Harinath <rharinath@novell.com>
10239 Improve standard-compliance of simple name and member access
10240 resolution. Fixes bugs #52697, #57200, #67520, #69519.
10241 * ecore.cs (FullNamedExpression): New abstract base class
10242 for Namespaces and TypeExpressions.
10243 (ResolveFlags.SimpleName): Remove.
10244 (SimpleName): Remove support for dotted names.
10245 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
10246 DeclSpace.FindType and DeclSpace.LookupType.
10247 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
10248 (Expression.ExprClassName): Make member function.
10249 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
10250 a namespace. Remove creation of dotted "SimpleName"s.
10251 (MemberAccess.DoResolve): Likewise.
10252 * decl.cs (DeclSpace.Cache): Make private.
10253 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
10254 (DeclSpace.FindType): Update.
10255 (DeclSpace.LookupType): Move here from RootContext. Return a
10256 FullNamedExpression.
10257 * namespace.cs (Namespace): Derive from FullNamedExpression
10258 so that it can be part of expression resolution.
10259 (Namespace.Lookup): Return an FullNamedExpression.
10260 (NamespaceEntry.LookupAlias): Lookup aliases only in current
10262 * rootcontext.cs (NamespaceLookup): Remove.
10263 (LookupType): Move to DeclSpace.
10264 * attribute.cs (CheckAttributeType): Update.
10265 * doc.cs (FindDocumentedType): Remove allowAlias argument.
10266 (FindDocumentedTypeNonArray): Likewise.
10268 2005-01-11 Raja R Harinath <rharinath@novell.com>
10270 Fix cs0509.cs, cs1632.cs.
10271 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
10272 is the same as IsInterface.
10273 (TypeContainer.GetClassBases): Likewise.
10274 * statement.cs (LabeledStatement.ig): New field.
10275 (LabeledStatement.LabelTarget): Save ILGenerator which created the
10277 (LabeledStatement.DoEmit): Check that the label was created with
10278 the same ILGenerator.
10280 2005-01-10 Marek Safar <marek.safar@seznam.cz>
10283 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
10284 accessors to its properties.
10286 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
10287 from accessors to property.
10289 2005-01-10 Marek Safar <marek.safar@seznam.cz>
10292 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
10293 only for overrides.
10295 2005-01-08 Miguel de Icaza <miguel@ximian.com>
10297 * attribute.cs: Check for null and empty strings.
10299 I have lost another battle to Paolo.
10301 2005-01-07 Marek Safar <marek.safar@seznam.cz>
10304 * class.cs (PropertyMethod): Set Parent field in ctors.
10305 (SetMethod.InternalParameters): Add unsafe switch hack.
10306 Override MarkForDuplicationCheck where it is appropriate.
10308 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
10309 It says whether container allows members with the same name.
10310 Base default is no.
10311 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
10312 Removed is_method parameter.
10314 2005-01-06 Duncan Mak <duncan@ximian.com>
10316 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
10317 because the previous change led to incorrect reporting of CS1032
10318 ("Cannot define/undefine preprocessor symbols after first token in
10319 file"). Instead of using `tokens_seen' as the only flag that
10320 triggers CS1040, introduce `comments_seen'. This new flag is used
10321 to signify having seen comments on the current line, so it is
10322 unset after a newline.
10324 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
10326 * doc.cs : When searching for a type, find nested type too.
10327 This fixes bug #71040.
10329 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
10332 - Warn missing member comment on those classes which also does not
10333 have doc comments. Fixed bug #71041.
10334 - Don't warn missing doc comment on default constructor.
10337 2005-01-06 Duncan Mak <duncan@ximian.com>
10339 * cs-tokenizer.cs (xtoken): After handling traditional C-style
10340 comments, set `tokens_seen' to true. This allows us to detect
10341 misplaced preprocessor directives (i.e. not at the beginning of
10342 the a line, nor after whitespaces). In that case, report error
10343 CS1040. This fixes bug #56460.
10345 * cs-parser.jay (interface_member_declaration): Add checks for
10346 IsExplicitImpl, and report CS0541 error if an interface member is
10347 defined as an explicit interface declaration.
10349 2005-01-06 Marek Safar <marek.safar@seznam.cz>
10352 * class.cs (PropertyMethod): Set Parent field in ctors.
10353 (SetMethod.InternalParameters): Add unsafe switch hack.
10355 * decl.cs (MemberCore.Parent): Cannot be readonly.
10357 2005-01-06 Raja R Harinath <rharinath@novell.com>
10359 * decl.cs (DeclSpace.ResolveType): Remove.
10360 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
10361 Merge in code from ...
10362 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
10363 * class.cs, enum.cs: Update to changes.
10365 2005-01-06 Miguel de Icaza <miguel@ximian.com>
10367 * anonymous.cs: Ensure that we init the scope of our parent if it
10368 has not been initialized yet.
10370 2004-12-30 Duncan Mak <duncan@ximian.com>
10372 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
10373 if field.FieldBuilder is null. Fixes #70758.
10375 * convert.cs: Fixed some typos and updated some of the comments.
10376 (ImplicitStandardConversionExists):
10377 (TryImplicitIntConversion): If `target_type' is an interface and
10378 the type of `ic' implements this interface, return true or a new
10379 BoxedCast instead of null. This fixes #70468.
10381 2004-12-29 Duncan Mak <duncan@ximian.com>
10383 * expression.cs (Argument.Emit): Check that Expr is
10384 IMemoryLocation before casting to it, and report CS1510 otherwise.
10388 2004-12-21 Ben Maurer <bmaurer@ximian.com>
10390 * statement.cs (Block.ThisVariable): remove the recursion here, to
10391 make the --profile more sane.
10393 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
10395 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
10396 assembly, by JB Evain.
10398 2004-12-17 Raja R Harinath <rharinath@novell.com>
10400 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
10401 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
10402 "parent" refers to enclosing type/class. "base" refers to superclass.
10404 2004-12-17 Raja R Harinath <rharinath@novell.com>
10406 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10407 Ensure that we only have GlobalAttributes.
10408 * attribute.cs (Attribute.Emit): Make non-virtual.
10409 (GlobalAttribute.Emit): Remove.
10410 (Attribute.Resolve): Make virtual.
10411 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
10412 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
10413 the argument. Don't create one.
10414 (Attribute.GetObsoleteAttribute): Likewise.
10415 (Attribute.GetClsCompliantAttributeValue): Likewise.
10416 * class.cs, decl.cs: Update to changes.
10418 2004-12-17 Marek Safar <marek.safar@seznam.cz>
10420 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
10422 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
10424 * statement.cs (Foreach.Resolve): Add error 186 report.
10426 2004-12-16 Marek Safar <marek.safar@seznam.cz>
10428 * expression.cs (Conditional.DoResolve): Add warning 429.
10430 * statement.cs (If.Resolve): Add warning 665.
10432 2004-12-16 Raja R Harinath <rharinath@novell.com>
10434 New invariant: RootContext.Tree.Types.NamespaceEntry == null
10435 except when in the parser, and in GlobalAttribute.
10436 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
10437 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
10438 RootContext.Tree.Types.NamespaceEntry once work is done.
10439 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
10440 and resets RootContext.Tree.Types.NamespaceEntry.
10442 2004-12-15 Marek Safar <marek.safar@seznam.cz>
10444 * cs-parser.jay: Don't create a block for every variable.
10446 2004-12-14 Miguel de Icaza <miguel@ximian.com>
10448 * location.cs: Provide extra information.
10450 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
10451 variables from the captured environment, it is the ldarg_0.
10453 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10455 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
10458 * class.cs: Changed warning level for 169 to avoid developer
10459 displeasure from warning flooding. It will be changed back when they
10460 fix most of current BCL warnings.
10462 * RootContext.cs: Pushed default WarningLevel to 3.
10464 * statement.cs: Removed unused variable.
10466 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10468 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
10469 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
10470 Add error 502 report.
10471 (StaticClass.DefineType): Add error 441 report.
10472 (Class.AllowedModifiersProp): New virtual property as temporary
10473 extension to AllowedModifiers.
10474 (Class.DefineType): Add error 418 report. Moved ModFlags check here
10475 to share implementation with StaticClass and don't call virtual
10478 * driver.cs (MainDriver): Add error 1558 test.
10480 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
10481 report. Moved error 36 test here.
10483 * statement.cs (Throw.Resolve): Add error 724 report.
10485 * typemanager.cs: Add out_attribute_type core type.
10487 2004-12-13 Marek Safar <marek.safar@seznam.cz>
10489 * class.cs (TypeContainer.VerifyClsCompliance): Add error
10491 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
10493 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
10496 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
10498 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
10499 Add error 3023 report.
10500 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
10502 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
10505 2004-12-12 John Luke <john.luke@gmail.com>
10507 * driver.cs (AddArgs): take -- into account when
10508 adding arguments, fixes bug 65710
10510 2004-12-12 Martin Baulig <martin@ximian.com>
10512 * expression.cs (Unary.TryReduceNegative): Added support for
10513 SByteConstant and ByteConstant.
10514 (Unary.Reduce): Check error values from TryReduceNegative().
10516 2004-12-10 Marek Safar <marek.safar@seznam.cz>
10518 * attributes.cs (Attribute.Resolve): Avoid multiple error report
10519 and report exception as error 182.
10521 2004-12-10 Raja R Harinath <rharinath@novell.com>
10523 * driver.cs (Main): Fix message when there are warnings.
10525 2004-12-09 Miguel de Icaza <miguel@ximian.com>
10527 * delegate.cs: Fixed my fix from yesterday, sorry about that.
10529 2004-12-09 Marek Safar <marek.safar@seznam.cz>
10531 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
10532 Reduced number of warnings.
10534 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
10536 2004-12-08 Miguel de Icaza <miguel@ximian.com>
10538 * driver.cs: Removed message.
10540 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
10542 2004-12-08 <vargaz@freemail.hu>
10544 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
10546 2004-12-08 Martin Baulig <martin@ximian.com>
10548 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
10549 instead of a CS3002 for properties and indexer.
10551 2004-12-08 Martin Baulig <martin@ximian.com>
10553 * decl.cs (MemberName.ToString): Make this work again.
10555 2004-12-08 Marek Safar <marek.safar@seznam.cz>
10557 * attribute.cs (Resolve): Add error 591 detection.
10559 * class.cs (FieldMember.Define): Add error 1547 detection.
10560 (Indexer.Define): Add error 620 detection.
10561 (Operator.Define): Add error 590 detection.
10563 * ecore.cs: Missing argument for error 79.
10565 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
10568 2004-12-07 Marek Safar <marek.safar@seznam.cz>
10571 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
10574 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
10576 * cs-parser.jay : handle doc comments on implicit/explicit operators.
10577 Some operator comments were suppressed.
10578 * doc.cs : Implicit/explicit operator name in doc comments are like
10579 "op_Explicit(type)~returnType", so added suffix handling.
10581 2004-12-07 Martin Baulig <martin@ximian.com>
10584 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
10585 (MemberCore.GetClsCompliantAttributeValue): Likewise.
10586 (DeclSpace.ec): New protected field; store the EmitContext here.
10587 (DeclSpace.EmitContext): New public property; moved here from
10589 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
10592 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
10593 (Enum.Emit): Don't create a new EmitContext.
10595 * delegate.cs (Delegate.DefineType): Always create the
10598 * iterators.cs (Iterators.DefineIterator): Create a new
10599 EmitContext and store it in `ec'.
10601 2004-08-24 Martin Baulig <martin@ximian.com>
10604 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
10605 this for accessibility checks.
10606 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
10607 IsNestedFamilyAccessible.
10608 (TypeManager.IsSubclassOf): New method, do what the name actually
10611 2004-12-06 Raja R Harinath <rharinath@novell.com>
10613 Fix crash on cs0657-17.cs.
10614 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10615 Use RootContext.Tree.Types, not 'new RootTypes ()'.
10616 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
10617 the case where the NamespaceEntry gets overwritten.
10619 2004-12-06 Marek Safar <marek.safar@seznam.cz>
10621 Fixed #69195, #56821
10622 * ecore.cs (ResolveBoolean): Tiny refactoring.
10624 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
10625 of right expression resolving when left is false constant and
10626 operator is LogicalAnd OR true constant and operator is LogicalOr.
10628 * statement.cs (ResolveUnreachable): Always reports warning.
10630 2004-12-05 Miguel de Icaza <miguel@ximian.com>
10632 * class.cs: Distinguish between 1721 and 1722 (just a little help
10633 for the programmer).
10635 2004-12-03 Miguel de Icaza <miguel@ximian.com>
10637 * delegate.cs: Only allow this on new versions of the language.
10639 2004-12-02 Duncan Mak <duncan@ximian.com>
10641 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
10643 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
10644 here as a static method. Take an additional bool out parameter
10645 `must_do_cs1540_check' for signaling to InstanceResolve.
10646 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
10647 member field from PropertyExpr class and made it an argument of
10648 the method instead.
10649 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
10650 check for MarshalByRefObject, and report CS0122 instead of CS1540.
10651 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
10652 and `remove_accessor' as well as InstanceResolve: report CS0122
10657 2004-12-03 Raja R Harinath <rharinath@novell.com>
10659 Fix test-327.cs, test-328.cs, and put in early infrastructure
10660 for eventually fixing #52697.
10661 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
10662 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
10663 from other methods.
10664 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
10665 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
10666 (VerifyUsing, error246): Update.
10667 * rootcontext.cs (RootContext.NamespaceLookup): Just use
10668 'NamespaceEntry.LookupNamespaceOrType'.
10670 2004-12-03 Martin Baulig <martin@ximian.com>
10672 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10673 method as our child, call AnonymousMethod.Compatible() on it.
10675 2004-12-03 Raja R Harinath <rharinath@novell.com>
10677 Disable XML documentation support in 'basic' profile.
10678 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
10679 Redirect XmlElement to System.Object.
10680 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
10681 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
10682 * mcs.exe.sources: Add doc-bootstrap.cs.
10683 * doc-bootstrap.cs: New file. Contains empty stub implementation
10686 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
10688 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
10689 comments are allowed.
10691 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10693 * delegate.cs: Add checks for subtypes in paramaters and return values
10694 in VerifyMethod () to add support for Covariance/Contravariance
10697 2004-12-02 Miguel de Icaza <miguel@ximian.com>
10699 * report.cs: Remove extra closing parenthesis.
10701 * convert.cs (Error_CannotImplicitConversion): If the name of the
10702 types are the same, provide some extra information.
10704 * class.cs (FieldBase): Use an unused bit field from the field to
10705 encode the `has_offset' property from the FieldMember. This saves
10706 a couple of Ks on bootstrap compilation.
10708 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10709 method as our child, return the AnonymousMethod resolved
10712 * expression.cs (New.DoResolve): Allow return values from
10713 NewDelegate to also include AnonymousMethods.
10717 2004-12-02 Marek Safar <marek.safar@seznam.cz>
10720 * attribute.cs (Resolve): Improved implementation of params
10721 attribute arguments.
10723 * support.cs (ParameterData): Add HasParams to be faster.
10725 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
10727 all things are for /doc support:
10729 * doc.cs: new file that supports XML documentation generation.
10730 * mcs.exe.sources: added doc.cs.
10732 Handle /doc command line option.
10733 Report error 2006 instead of 5 for missing file name for /doc.
10734 Generate XML documentation when required, after type resolution.
10736 Added support for picking up documentation (/// and /** ... */),
10737 including a new XmlCommentState enumeration.
10739 Added lines to fill Documentation element for field, constant,
10740 property, indexer, method, constructor, destructor, operator, event
10741 and class, struct, interface, delegate, enum.
10742 Added lines to warn incorrect comment.
10744 Added Documentation field (passed only when /doc was specified).
10746 Added DocComment, DocCommentHeader, GenerateDocComment() and
10747 OnGenerateDocComment() and some supporting private members for
10748 /doc feature to MemberCore.
10750 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
10752 Added overriden DocCommentHeader.
10754 Added overriden DocCommentHeader and GenerateDocComment().
10756 2004-12-01 Miguel de Icaza <miguel@ximian.com>
10758 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
10759 unwrapping the enumeration values, chain to
10760 DoConstantNumericPromotions again, so we can promote things to the
10761 fundamental types (takes care of enums that are bytes, sbytes).
10765 2004-12-01 Raja R Harinath <rharinath@novell.com>
10767 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
10768 Fix long-standing bug in type-lookup. Use FindType instead of
10769 LookupType when ec.ResolvingTypeTree.
10770 (Attribute.ResolveType, Attribute.Resolve)
10771 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
10773 (Attributes.Search): Remove internal version. Update.
10774 (Attributes.SearchMulti): Update.
10775 (Attributes.GetClsCompliantAttribute): Remove.
10776 (Attributes.GetIndexerNameAttribute): Remove.
10777 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
10778 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
10779 * class.cs (Indexer.Define): Likewise.
10781 2004-12-01 Marek Safar <marek.safar@seznam.cz>
10784 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
10785 MarshallByReference members access.
10787 * expression.cs: Use CheckMarshallByRefAccess;
10788 Better error CS0197 message.
10790 * report.cs: Print whole related error message.
10792 2004-11-30 Raja R Harinath <rharinath@novell.com>
10794 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
10795 the current directory to help debugging.
10797 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10799 * class (GetClassBases): Better error 60 report.
10800 (EventProperty): Disabled warning 67 detection.
10802 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10805 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
10807 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
10810 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10813 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
10815 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
10817 2004-11-26 Miguel de Icaza <miguel@ximian.com>
10819 * attribute.cs (Attribute.Resolve): Refine error reporting and
10820 report a cs0117 if the identifier does not exist, to distinguish
10821 from 0617 which is a miss-use of the actual identifier.
10823 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
10824 between cs0070 and cs0079.
10826 * class.cs (MemberBase.DoDefine): When reporting a wrong
10827 accessibility level, we use MethodCore to compare instead of
10828 Method (this was a regression in some refactoring effort).
10830 So now we correctly report cs0056 again.
10832 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
10833 testing the target_type (which was known to be object_type) and
10834 not the source type (which is anonymous_method).
10836 Fixed reporting of error cs1660.
10838 * expression.cs (UserCast.Source): Expose the underlying cast.
10840 * statement.cs (Switch.SwitchGoverningType): Sort the list of
10841 allowed types to find a match to int32 first (most common).
10843 In addition, it ignores any ImplicitUserConversions that did an
10844 internal implicit conversion (as the switch statement allows only
10845 one integral conversion to exist).
10847 * class.cs (PartialContainer.Create): rename `name' to
10848 `member_name' for clarity. Then replace the string calls with a
10849 call to MemberName.GetPartialName, as now using
10850 MemberName.ToString is an error (this is due to the side effects
10851 it had, that were fixed in the past).
10853 This will restore the error reporting on a number of partial class
10854 errors that were missusing this (and getting an exception as a
10855 results, which is now just a plain textual warning, because
10856 yyparse debug output would crash otherwise).
10858 2004-11-26 Raja R Harinath <rharinath@novell.com>
10860 * Makefile (PROGRAM_INSTALL_DIR): Remove.
10862 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10864 * rootcontext.cs (LookupType): Make sure to cache lookups that
10865 don't give us a negative result. This saves about 5% of corlib
10868 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10870 * report.cs (AbstractMessage.Print): messages are sent to stderr
10872 * class.cs (TypeContainer.GetClassBases): It is an error to have a
10873 non-interface in the list of interfaces (at this point, either
10874 parent was properly set, or a base class is being listed in the
10875 interfaces section).
10877 This flags error 1722, and resolves the crash from bug 69259.
10879 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10881 * statement.cs (Using.EmitExpressionFinally): make this work right
10882 for valuetypes. Fixes 69926.
10884 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10886 * const.cs (Const.ChangeType): Cope with the "0 literal can be
10887 converted to an enum" here, before we try to change the underlying
10888 type. This code exists, but it is a different code path than the
10889 one used while encoding constants.
10891 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
10892 old bug: when converting from the null literal to a pointer,
10893 return an EmptyCast, not the NullLiteral.
10895 This fixes #69921, the recent null_type changes probably made this
10896 bug more prominent.
10898 (ImplicitReferenceConversionExists): In addition, resynchronized
10899 the code here, so it matches the same code in
10900 ImplicitReferenceConversionExists for the `from any class-type S
10901 to any interface-type T'.
10904 2004-11-25 Marek Safar <marek.safar@seznam.cz>
10906 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
10908 2004-11-24 Miguel de Icaza <miguel@ximian.com>
10910 * cs-parser.jay: Use verbosity accordingly.
10912 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10914 * expression.cs (Unary.ResolveOperator): Do not report warning;
10915 AddressOf reads from variable.
10917 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
10919 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10923 * attribute.cs (Attributable): Removed CheckTargets.
10924 (Attributes.Emit): Explicit attribute targets are tested here.
10926 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
10927 not enabled for interfaces.
10929 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
10930 (GetAssemblyName): Ouch next bug there.
10932 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10934 * expression.cs: Error 275 added.
10936 2004-11-23 Marek Safar <marek.safar@seznam.cz>
10938 Fix bug #69177 (Implemented decimal constant support)
10940 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
10941 (BinaryFold): Add DecimalConstant.
10943 * const.cs (Define): Decimal constant
10945 (ChangeType): Add decimal type handling.
10946 (LookupConstantValue): Don't set value for decimal type but
10947 emit DecimalConstantAttribute. Needed for constant optimization.
10949 * constant.cs (ToDecimal): New method.
10950 (ConvertToDecimal): New method.
10951 (IntConstant): Implemented ConvertToDecimal.
10952 (DecimalConstant.Emit): Emit optimized version for decimals in
10955 * expression.cs (ResolveOperator): Changed order of constant
10956 reduction to work correctly with native types which have
10957 overloaded operators.
10958 (ResolveMemberAccess): Extract constant value from attribute
10961 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
10963 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
10964 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
10965 (ChangeType): Decimal is special.
10966 (TypeToCoreType): Add decimal type.
10968 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10970 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
10973 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10975 * class.cs (EventField.ApplyAttributeBuilder): Fix error
10978 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10980 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
10982 * pending.cs (PendingImplementation): Grab only interfaces.
10984 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10986 * statement.cs (ForeachHelperMethods): Add location member and
10987 error 202 detection.
10989 2004-11-19 Raja R Harinath <rharinath@novell.com>
10991 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
10992 automatically handled by executable.make.
10993 (PROGRAM): Make profile-specific.
10995 2004-11-18 Marek Safar <marek.safar@seznam.cz>
10997 * expression.cs (DoResolveBase): Fixed wrong warning for out
11000 2004-11-18 Martin Baulig <martin@ximian.com>
11002 Merged latest changes into gmcs. Please keep this comment in
11003 here, it makes it easier for me to see what changed in MCS since
11004 the last time I merged.
11006 2004-11-17 Raja R Harinath <rharinath@novell.com>
11008 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
11009 (TypeHandle.GetMemberCache): New.
11010 (TypeHandle.TypeHandle): Update.
11011 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
11012 (TypeManager.LookupParentInterfacesCache):
11013 Rename from LookupInterfaceCache. Optimize slightly.
11014 (TypeManager.MemberLookup_FindMembers): Update.
11015 * decl.cs (MemberCache.MemberCache): Set Container to null in the
11016 multi-type variant.
11017 (AddCacheContents): Rename from AddHashtable.
11018 * class.cs (TypeContainer.parent_container): Remove.
11019 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
11020 (TypeContainer.DoDefineMembers): Don't initialize it.
11021 Update to name changes.
11023 2004-11-17 Miguel de Icaza <miguel@ximian.com>
11025 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
11026 that factors the code to check access modifiers on override.
11028 (PropertyBase): Use the code here.
11030 Patch from Lluis S'anchez, fixes bug #69361.
11032 2004-11-15 Miguel de Icaza <miguel@ximian.com>
11034 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
11035 routine that is used to report the use of a captured variable
11036 whose address has been taken.
11038 There are two checks: one when variables are being captured and
11039 the other check is when the address of a variable is taken.
11041 (because an anonymous methods might be resolved before *or* after
11042 the address has been taken) and
11044 * expression.cs (Conditional.DoResolve): Remove the special
11045 casing that Martin added to trueExpr and falseExpr being both
11046 NullLiteral. We get the right behavior now just by introducing
11047 the null_type into the compiler.
11049 * convert.cs (ExplicitConversion): Change the code to use
11050 null_type instead of testing `expr is NullLiteral'.
11051 (ImplicitConversionStandard): use null_type too.
11052 (ImplicitReferenceConversionExists): use null_type too.
11053 (ImplicitReferenceConversion): use null_type too.
11055 * literal.cs: The type of `NullLiteral' is now null_type instead
11057 (Resolve): Set the type here.
11059 * typemanager.cs: Introduce null_type.
11061 2004-11-17 Martin Baulig <martin@ximian.com>
11063 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
11064 direction, like FindMembers() does. Fixes #69546, testcase is in
11067 2004-11-16 Martin Baulig <martin@ximian.com>
11069 This is based on a patch from Marek Safar, see bug #69082.
11070 Fixes bugs #63705 and #67130.
11072 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
11073 method; create a MemberCache for an interface type and cache the
11076 * decl.cs (IMemberContainer.ParentContainer): Removed.
11077 (IMemberContainer.ParentCache): New property.
11078 (MemberCache.SetupCacheForInterface): Removed.
11079 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
11080 to create a cache for an interface's "parent".
11082 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
11085 2004-11-16 Martin Baulig <martin@ximian.com>
11087 Merged back from gmcs; these changes already went into gmcs a
11088 couple of weeks ago.
11091 (TypeManager.AddUserType): Removed the `ifaces' argument.
11092 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
11094 (TypeManager.AddUserInterface): Removed.
11095 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
11097 (TypeManager.GetInterfaces): Likewise.
11098 (TypeManager.GetExplicitInterfaces): Likewise.
11100 * ecore.cs (TypeExpr.GetInterfaces): Removed.
11102 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
11103 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
11105 2004-11-14 Ben Maurer <bmaurer@ximian.com>
11107 * statement.cs: Avoid adding bools to a hashtable.
11109 2004-11-07 Miguel de Icaza <miguel@ximian.com>
11111 * expression.cs (Invocation.OverloadResolve): Flag error if we are
11112 calling an unsafe method from a safe location.
11114 2004-11-06 Marek Safar <marek.safar@seznam.cz>
11117 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
11119 2004-11-06 Miguel de Icaza <miguel@ximian.com>
11121 * namespace.cs (VerifyUsing): use GetPartialName instead of
11124 2004-11-05 Miguel de Icaza <miguel@ximian.com>
11126 * statement.cs (Return.Resolve): Fix regression in typo: if
11127 `in_exc', we have to request a NeedReturnLabel, this was a typo
11128 introduced in the anonymous method check-in. Fixes #69131.
11130 * Indexers were using the ShortName when defining themselves,
11131 causing a regression in the compiler bootstrap when applying the
11132 patch from 2004-11-02 (first part), now they use their full name
11133 and the bug is gone.
11135 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
11137 * driver.cs: Strip the path from the names of embedded resources. Fixes
11140 2004-11-04 Raja R Harinath <rharinath@novell.com>
11142 Fix error message regression: cs0104-2.cs.
11143 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
11144 (AliasEntry.Resolve): Update.
11145 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
11147 (RootContext.LookupType): Update.
11149 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
11151 * cs-parser.jay: Add support for handling accessor modifiers
11152 * class: Add support port accessor modifiers and error checking,
11153 define PropertyMethod.Define as virtual (not abstract anymore)
11154 * ecore.cs: Add checking for proeprties access with access modifiers
11155 * iterators.cs: Modify Accessor constructor call based in the modified
11157 2004-11-02 Ben Maurer <bmaurer@ximian.com>
11159 * expression.cs (StringConcat): Handle being called twice,
11160 as when we have a concat in a field init with more than two
11163 2004-11-02 Miguel de Icaza <miguel@ximian.com>
11165 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
11166 special case explicit implementations, we should always produce
11167 the .property or .event declaration.
11169 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
11170 since it will not return correct data if people use this
11171 unresolved in the presence of using statements (see test-313).
11173 * class.cs (MethodData.Define): If we are an explicit interface
11174 implementation, set the method name to the full name of the
11175 interface plus the name of the method.
11177 Notice that using the method.MethodName.GetFullName() does not
11178 work, as it will only contain the name as declared on the source
11179 file (it can be a shorthand in the presence of using statements)
11180 and not the fully qualifed type name, for example:
11184 class D : ICloneable {
11185 object ICloneable.Clone () {
11189 Would produce a method called `ICloneable.Clone' instead of
11190 `System.ICloneable.Clone'.
11192 * namespace.cs (Alias.Resolve): Use GetPartialName.
11194 2004-11-01 Marek Safar <marek.safar@seznam.cz>
11196 * cs-parser.jay: Add error 1055 report.
11198 2004-11-01 Miguel de Icaza <miguel@ximian.com>
11200 * assign.cs (Assign.DoResolve): Only do the transform of
11201 assignment into a New if the types are compatible, if not, fall
11202 through and let the implicit code deal with the errors and with
11203 the necessary conversions.
11205 2004-11-01 Marek Safar <marek.safar@seznam.cz>
11207 * cs-parser.jay: Add error 1031 report.
11209 * cs-tokenizer.cs: Add location for error 1038.
11211 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11213 * cs-parser.jay: Add error 1016 report.
11215 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11217 * cs-parser.jay: Add errors 1575,1611 report.
11219 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11221 * cs-parser.jay: Add error 1001 report.
11223 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11226 * attribute.cs (GetMarshal): Add method argument for
11227 caller identification.
11229 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
11230 agument for GetMarshal and RuntimeMissingSupport.
11232 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11234 * attribute.cs (ExtractSecurityPermissionSet): Removed
11235 TypeManager.code_access_permission_type.
11237 * typemanager.cs: Removed TypeManager.code_access_permission_type.
11239 2004-10-27 Miguel de Icaza <miguel@ximian.com>
11241 * expression.cs (LocalVariableReference.DoResolveLValue): Check
11242 for obsolete use of a variable here. Fixes regression on errors
11243 cs0619-25 and cs0619-26.
11245 2004-10-27 Marek Safar <marek.safar@seznam.cz>
11247 Fix #62358, implemented security attribute encoding.
11249 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
11250 Tests permitted SecurityAction for assembly or other types.
11251 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
11252 data from SecurityPermissionAttribute to PermisionSet class.
11254 * class.cs (ApplyAttributeBuilder): Added special handling
11255 for System.Security.Permissions.SecurityAttribute based types.
11257 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
11258 special handling for System.Security.Permissions.SecurityAttribute
11261 * enum.cs (ApplyAttributeBuilder): Added special handling
11262 for System.Security.Permissions.SecurityAttribute based types.
11264 * parameter.cs (ApplyAttributeBuilder): Added special handling
11265 for System.Security.Permissions.SecurityAttribute based types.
11267 * rootcontext.cs: Next 2 core types.
11269 * typemanager.cs (TypeManager.security_permission_attr_type):
11270 Built in type for the SecurityPermission Attribute.
11271 (code_access_permission_type): Build in type.
11273 2004-10-17 Miguel de Icaza <miguel@ximian.com>
11275 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
11276 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
11277 all of this information into
11278 EmitContext.EmitCapturedVariableInstance.
11280 * codegen.cs (EmitCapturedVariableInstance): move here the
11281 funcionality of emitting an ldarg.0 in the presence of a
11282 remapping. This centralizes the instance emit code.
11284 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
11285 then emit a load of this: it means that we have reached the
11286 topmost ScopeInfo: the one that contains the pointer to the
11287 instance of the class hosting the anonymous method.
11289 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
11290 captures to the topmost CaptureContext.
11292 2004-10-12 Miguel de Icaza <miguel@ximian.com>
11294 * expression.cs (LocalVariableReference): Move the knowledge about
11295 the iterators into codegen's EmitCapturedVariableInstance.
11297 2004-10-11 Miguel de Icaza <miguel@ximian.com>
11299 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
11300 all code paths return a value from an anonymous method (it is the
11301 same as the 161 error, but for anonymous methods).
11303 2004-10-08 Miguel de Icaza <miguel@ximian.com>
11305 The introduction of anonymous methods in the compiler changed
11306 various ways of doing things in the compiler. The most
11307 significant one is the hard split between the resolution phase
11308 and the emission phases of the compiler.
11310 For instance, routines that referenced local variables no
11311 longer can safely create temporary variables during the
11312 resolution phase: they must do so from the emission phase,
11313 since the variable might have been "captured", hence access to
11314 it can not be done with the local-variable operations from the runtime.
11318 (Block.Flags): New flag `IsTopLevel' to indicate that this block
11319 is a toplevel block.
11321 (ToplevelBlock): A new kind of Block, these are the blocks that
11322 are created by the parser for all toplevel method bodies. These
11323 include methods, accessors and anonymous methods.
11325 These contain some extra information not found in regular blocks:
11326 A pointer to an optional CaptureContext (for tracking captured
11327 local variables and parameters). A pointer to the parent
11330 (Return.Resolve): Catch missmatches when returning a value from an
11331 anonymous method (error 1662).
11332 Invoke NeedReturnLabel from the Resolve phase instead of the emit
11335 (Break.Resolve): ditto.
11337 (SwitchLabel): instead of defining the labels during the
11338 resolution phase, we now turned the public ILLabel and ILLabelCode
11339 labels into methods called GetILLabelCode() and GetILLabel() that
11340 only define the label during the Emit phase.
11342 (GotoCase): Track the SwitchLabel instead of the computed label
11343 (its contained therein). Emit the code by using
11344 SwitchLabel.GetILLabelCode ().
11346 (LocalInfo.Flags.Captured): A new flag has been introduce to track
11347 whether the Local has been captured or not.
11349 (LocalInfo.IsCaptured): New property, used to tell whether the
11350 local has been captured.
11352 * anonymous.cs: Vastly updated to contain the anonymous method
11355 The main classes here are: CaptureContext which tracks any
11356 captured information for a toplevel block and ScopeInfo used to
11357 track the activation frames for various local variables.
11359 Each toplevel block has an optional capture context associated
11360 with it. When a method contains an anonymous method both the
11361 toplevel method and the anonymous method will create a capture
11362 context. When variables or parameters are captured, they are
11363 recorded on the CaptureContext that owns them, for example:
11367 MyDelegate d = delegate {
11372 Here `a' will be recorded as captured on the toplevel
11373 CapturedContext, the inner captured context will not have anything
11374 (it will only have data if local variables or parameters from it
11375 are captured in a nested anonymous method.
11377 The ScopeInfo is used to track the activation frames for local
11378 variables, for example:
11380 for (int i = 0; i < 10; i++)
11381 for (int j = 0; j < 10; j++){
11382 MyDelegate d = delegate {
11387 At runtime this captures a single captured variable `i', but it
11388 captures 10 different versions of the variable `j'. The variable
11389 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
11390 recorded on a child.
11392 The toplevel ScopeInfo will also track information like the `this'
11393 pointer if instance variables were referenced (this is necessary
11394 as the anonymous method lives inside a nested class in the host
11395 type of the method).
11397 (AnonymousMethod): Expanded to track the Toplevel, implement
11398 `AnonymousMethod.Compatible' to tell whether an anonymous method
11399 can be converted to a target delegate type.
11401 The routine now also produces the anonymous method content
11403 (AnonymousDelegate): A helper class that derives from
11404 DelegateCreation, this is used to generate the code necessary to
11405 produce the delegate for the anonymous method that was created.
11407 * assign.cs: API adjustments for new changes in
11408 Convert.ImplicitStandardConversionExists.
11410 * class.cs: Adjustments to cope with the fact that now toplevel
11411 blocks are of type `ToplevelBlock'.
11413 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
11414 insteda of standard blocks.
11416 Flag errors if params arguments are passed to anonymous methods.
11418 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
11419 `CurrentAnonymousMethod' which points to the current Anonymous
11420 Method. The variable points to the AnonymousMethod class that
11421 holds the code being compiled. It is set in the new EmitContext
11422 created for the anonymous method.
11424 (EmitContext.Phase): Introduce a variable and an enumeration to
11425 assist in enforcing some rules about when and where we are allowed
11426 to invoke certain methods (EmitContext.NeedsReturnLabel is the
11427 only one that enfonces this right now).
11429 (EmitContext.HaveCaptureInfo): new helper method that returns
11430 whether we have a CapturedContext initialized.
11432 (EmitContext.CaptureVariable): New method used to register that a
11433 LocalInfo must be flagged for capturing.
11435 (EmitContext.CapturedParameter): New method used to register that a
11436 parameters must be flagged for capturing.
11438 (EmitContext.CapturedField): New method used to register that a
11439 field must be flagged for capturing.
11441 (EmitContext.HaveCapturedVariables,
11442 EmitContext.HaveCapturedFields): Return whether there are captured
11443 variables or fields.
11445 (EmitContext.EmitMethodHostInstance): This is used to emit the
11446 instance for the anonymous method. The instance might be null
11447 (static methods), this (for anonymous methods that capture nothing
11448 and happen to live side-by-side with the current method body) or a
11449 more complicated expression if the method has a CaptureContext.
11451 (EmitContext.EmitTopBlock): Routine that drives the emission of
11452 code: it will first resolve the top block, then emit any metadata
11453 and then emit the code. The split is done so that we can extract
11454 any anonymous methods and flag any captured variables/parameters.
11456 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
11457 during this phase, the ILGenerator should not be used as labels
11458 and local variables declared here might not be accessible to any
11459 code that is part of an anonymous method.
11461 Exceptions to this include the temporary variables that are
11462 created by some statements internally for holding temporary
11465 (EmitContext.EmitMeta): New routine, in charge of emitting all the
11468 (EmitContext.TemporaryReturn): This method is typically called
11469 from the Emit phase, and its the only place where we allow the
11470 ReturnLabel to be defined other than the EmitMeta. The reason is
11471 that otherwise we would have to duplicate a lot of logic in the
11472 Resolve phases of various methods that today is on the Emit
11475 (EmitContext.NeedReturnLabel): This no longer creates the label,
11476 as the ILGenerator is not valid during the resolve phase.
11478 (EmitContext.EmitThis): Extended the knowledge in this class to
11479 work in anonymous methods in addition to iterators.
11481 (EmitContext.EmitCapturedVariableInstance): This emits whatever
11482 code is necessary on the stack to access the instance to a local
11483 variable (the variable will be accessed as a field).
11485 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
11486 EmitContext.EmitAddressOfParameter): Routines to support
11487 parameters (not completed at this point).
11489 Removals: Removed RemapLocal and RemapLocalLValue. We probably
11490 will also remove the parameters.
11492 * convert.cs (Convert): Define a `ConstantEC' which points to a
11493 null. This is just to prefity some code that uses
11494 ImplicitStandardConversion code and do not have an EmitContext
11497 The idea is to flag explicitly that at that point in time, it is
11498 known that the conversion will not trigger the delegate checking
11499 code in implicit conversions (which requires a valid
11502 Everywhere: pass new EmitContext parameter since
11503 ImplicitStandardConversionExists now requires it to check for
11504 anonymous method conversions.
11506 (Convert.ImplicitStandardConversionExists): If the type of an
11507 expression is the anonymous_method_type, and the type is a
11508 delegate, we invoke the AnonymousMethod.Compatible method to check
11509 whether an implicit conversion is possible.
11511 (Convert.ImplicitConversionStandard): Only do implicit method
11512 group conversions if the language level is not ISO_1.
11514 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
11515 MethodInfo for the Invoke method. used by Delegate and
11518 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
11519 method conversions if the target type is a delegate.
11521 Removed extra debugging nops.
11523 (LocalVariableReference): Turn the `local_info' into a public
11526 Add `prepared' field, the same hack used for FieldExprs to cope
11527 with composed assignments, as Local variables do not necessarily
11528 operate purely on the stack as they used to: they can be captured
11531 Add `temp' for a temporary result, like fields.
11533 Refactor DoResolve and DoResolveLValue into DoResolveBase.
11535 It now copes with Local variables that are captured and emits the
11536 proper instance variable to load it from a field in the captured
11539 (ParameterReference.DoResolveBase): During the resolve phase,
11540 capture parameters if we are in an anonymous method.
11542 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
11543 anonymous method, use the EmitContext helper routines to emit the
11544 parameter reference.
11546 * iterators.cs: Set RemapToProxy to true/false during the
11549 * parameters.cs (GetParameterByName): New helper method.
11551 * typemanager.cs (anonymous_method_type) a new type that
11552 represents an anonyous method. This is always an internal type,
11553 used as a fencepost to test against the anonymous-methodness of an
11556 2004-10-20 Marek Safar <marek.safar@seznam.cz>
11558 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
11560 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
11562 2004-10-18 Martin Baulig <martin@ximian.com>
11564 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
11565 `Type' directly, but call ResolveType() on it.
11566 (Catch.Resolve): Likewise.
11567 (Foreach.Resolve): Likewise.
11569 2004-10-18 Martin Baulig <martin@ximian.com>
11571 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
11572 `Type' directly, but call ResolveType() on it.
11573 (Probe.DoResolve): Likewise.
11574 (ArrayCreation.LookupType): Likewise.
11575 (TypeOf.DoResolve): Likewise.
11576 (SizeOf.DoResolve): Likewise.
11578 2004-10-18 Martin Baulig <martin@ximian.com>
11580 * expression.cs (Invocation.BetterFunction): Put back
11581 TypeManager.TypeToCoreType().
11583 2004-10-18 Raja R Harinath <rharinath@novell.com>
11585 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
11588 2004-10-18 Martin Baulig <martin@ximian.com>
11590 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
11591 `Type' directly, but call ResolveType() on it.
11593 2004-10-18 Martin Baulig <martin@ximian.com>
11595 * class.cs (FieldMember.Define): Don't access the TypeExpr's
11596 `Type' directly, but call ResolveType() on it.
11597 (MemberBase.DoDefine): Likewise.
11599 * expression.cs (New.DoResolve): Don't access the TypeExpr's
11600 `Type' directly, but call ResolveType() on it.
11601 (ComposedCast.DoResolveAsTypeStep): Likewise.
11603 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
11604 `Type' directly, but call ResolveType() on it.
11606 2004-10-17 John Luke <john.luke@gmail.com>
11608 * class.cs (Operator.GetSignatureForError): use CSharpName
11610 * parameter.cs (Parameter.GetSignatureForError): Returns
11611 correct name even if was not defined.
11613 2004-10-13 Raja R Harinath <rharinath@novell.com>
11616 * class.cs (TypeContainer.EmitContext): New property.
11617 (DefineNestedTypes): Create an emitcontext for each part.
11618 (MethodCore.DoDefineParameters): Use container's emitcontext.
11619 Pass type array to InternalParameters.
11620 (MemberBase.DoDefine): Use container's emitcontext.
11621 (FieldMember.Define): Likewise.
11622 (Event.Define): Likewise.
11623 (SetMethod.GetParameterInfo): Change argument to EmitContext.
11624 Pass type array to InternalParameters.
11625 (SetIndexerMethod.GetParameterInfo): Likewise.
11626 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
11627 * delegate.cs (Define): Pass emitcontext to
11628 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
11629 array to InternalParameters.
11630 * expression.cs (ParameterReference.DoResolveBase): Pass
11631 emitcontext to GetParameterInfo.
11632 (ComposedCast.DoResolveAsTypeStep): Remove check on
11633 ec.ResolvingTypeTree.
11634 * parameter.cs (Parameter.Resolve): Change argument to
11635 EmitContext. Use ResolveAsTypeTerminal.
11636 (Parameter.GetSignature): Change argument to EmitContext.
11637 (Parameters.ComputeSignature): Likewise.
11638 (Parameters.ComputeParameterTypes): Likewise.
11639 (Parameters.GetParameterInfo): Likewise.
11640 (Parameters.ComputeAndDefineParameterTypes): Likewise.
11641 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
11642 * support.cs (InternalParameters..ctor): Remove variant that takes
11644 * typemanager.cs (system_intptr_expr): New.
11645 (InitExpressionTypes): Initialize it.
11647 2004-10-12 Chris Toshok <toshok@ximian.com>
11649 * cs-parser.jay: fix location for try_statement and catch_clause.
11651 2004-10-11 Martin Baulig <martin@ximian.com>
11653 * report.cs: Don't make --fatal abort on warnings, we have
11654 -warnaserror for that.
11656 2004-10-07 Raja R Harinath <rharinath@novell.com>
11658 More DeclSpace.ResolveType avoidance.
11659 * decl.cs (MemberCore.InUnsafe): New property.
11660 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
11661 with newly created EmitContext.
11662 (FieldMember.Define): Likewise.
11663 * delegate.cs (Delegate.Define): Likewise.
11664 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
11665 only if normal name-lookup fails.
11666 (TypeExpr.DoResolve): Enable error-checking.
11667 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
11668 (SizeOf.DoResolve): Likewise.
11669 (ComposedCast.DoResolveAsTypeStep): Likewise.
11670 (StackAlloc.DoResolve): Likewise.
11671 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
11672 (Block.Unsafe): New property.
11673 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
11674 (Unsafe): Set 'unsafe' flag of contained block.
11675 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
11676 (Fixed.Resolve): Likewise.
11677 (Catch.Resolve): Likewise.
11678 (Using.ResolveLocalVariableDecls): Likewise.
11679 (Foreach.Resolve): Likewise.
11681 2004-10-05 John Luke <john.luke@gmail.com>
11683 * cs-parser.jay: add location to error CS0175
11685 2004-10-04 Miguel de Icaza <miguel@ximian.com>
11687 * ecore.cs (Expression.Constantity): Add support for turning null
11690 * const.cs (Const.Define): Allow constants to be reference types
11691 as long as the value is Null.
11693 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
11695 * namespace.cs (NamespaceEntry.Using): No matter which warning
11696 level is set, check if this namespace name has already been added.
11698 2004-10-03 Ben Maurer <bmaurer@ximian.com>
11700 * expression.cs: reftype [!=]= null should always use br[true,false].
11703 2004-10-03 Marek Safar <marek.safar@seznam.cz>
11706 * attribute.cs: Enum conversion moved to
11707 GetAttributeArgumentExpression to be applied to the all
11710 2004-10-01 Raja R Harinath <rharinath@novell.com>
11712 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
11713 * class.c (TypeContainer.DefineType): Flag error if
11714 base types aren't accessible due to access permissions.
11715 * decl.cs (DeclSpace.ResolveType): Move logic to
11716 Expression.ResolveAsTypeTerminal.
11717 (DeclSpace.ResolveTypeExpr): Thin layer over
11718 Expression.ResolveAsTypeTerminal.
11719 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
11720 Refactor code into NestedAccess. Use it.
11721 (DeclSpace.NestedAccess): New.
11722 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
11723 argument to silence errors. Check access permissions.
11724 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
11725 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
11726 (Cast.DoResolve): Likewise.
11727 (New.DoResolve): Likewise.
11728 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
11729 (TypeOf.DoResolve): Likewise.
11731 * expression.cs (Invocation.BetterConversion): Return the Type of
11732 the better conversion. Implement section 14.4.2.3 more faithfully.
11733 (Invocation.BetterFunction): Make boolean. Make correspondence to
11734 section 14.4.2.2 explicit.
11735 (Invocation.OverloadResolve): Update.
11736 (Invocation): Remove is_base field.
11737 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
11738 (Invocation.Emit): Likewise.
11740 2004-09-27 Raja R Harinath <rharinath@novell.com>
11742 * README: Update to changes.
11744 2004-09-24 Marek Safar <marek.safar@seznam.cz>
11746 * cs-parser.jay: Reverted 642 warning fix.
11748 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11751 * decl.cs (FindMemberWithSameName): Indexer can have more than
11754 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11756 * expression.cs (LocalVariableReference.DoResolveLValue):
11757 Do not report warning 219 for out values.
11758 (EmptyExpression.Null): New member to avoid extra allocations.
11760 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11762 * cs-parser.jay: Fix wrong warning 642 report.
11764 * cs-tokenizer.cs (CheckNextToken): New helper;
11765 Inspect next character if is same as expected.
11767 2004-09-23 Martin Baulig <martin@ximian.com>
11769 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
11770 (Convert.ImplicitReferenceConversionExists): Likewise.
11772 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11774 * class.cs (Operator.Define): Add error 448 and 559 report.
11776 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11778 * class.cs (MemberBase.IsTypePermitted): New protected
11779 method for checking error CS0610.
11781 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11783 * class.cs (TypeContainer.HasExplicitLayout): New property
11784 Returns whether container has StructLayout attribute set Explicit.
11785 (FieldMember): New abstract class for consts and fields.
11786 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
11787 (Field): Reuse FieldMember.
11789 * const.cs (Const): Reuse FieldMember.
11791 * rootcontext.cs: EmitConstants call moved to class.
11793 2004-09-22 Martin Baulig <martin@ximian.com>
11795 Thanks to Peter Sestoft for this bug report.
11797 * expression.cs (Conditional): If both the `trueExpr' and the
11798 `falseExpr' is a NullLiteral, return a NullLiteral.
11800 2004-09-22 Martin Baulig <martin@ximian.com>
11802 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
11803 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
11804 for the "get_Current" call.
11806 2004-09-22 Martin Baulig <martin@ximian.com>
11808 Marek and me just fixed one of our oldest bugs: #28562 :-)
11810 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
11812 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
11813 we're an EnumConstant, just return that.
11814 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
11815 an EnumConstant. In this case, we need to use GetValueAsEnumType()
11816 to get the value which'll actually be written into the attribute.
11817 However, we have to use GetValue() to access the attribute's value
11820 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11822 * constant.cs (Constant.IsNegative): New abstract property
11825 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
11826 (StackAlloc.DoResolve): Reused IsNegative.
11828 2004-09-21 Martin Baulig <martin@ximian.com>
11830 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
11831 if we're used in an iterator, we may be called from different
11834 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
11835 we actually have an exception block.
11837 2004-09-20 John Luke <jluke@cfl.rr.com>
11839 * class.cs, cs-parser.jay: Improve the error report for 1520:
11840 report the actual line where the error happens, not where the
11841 class was declared.
11843 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
11844 Pass location information that was available elsewhere.
11846 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
11848 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
11849 runtime to delay sign assemblies.
11851 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11853 * cs-parser.jay: Do not report the stack trace, this is barely
11856 2004-08-22 John Luke <john.luke@gmail.com>
11858 * driver.cs : check that a resource id is not already used
11859 before adding it, report CS1508 if it is, bug #63637
11861 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11863 * ecore.cs: Removed dead code.
11865 2004-09-18 Marek Safar <marek.safar@seznam.cz>
11867 * class.cs: Do not report warning CS0067 on the interfaces.
11869 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11871 * cs-parser.jay: Add error 504 report.
11873 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11875 * rootcontext.cs: WarningLevel is 4 by default now.
11877 * statement.cs (Fixed.Resolve): Do not null
11880 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11883 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
11884 deep search when property is not virtual.
11885 (PropertyExpr.ResolveAccessors): Make one call for both
11888 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11891 * statement.cs: Error 152 report constains also location.
11893 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11896 * const.cs: Explicitly set constant as static.
11898 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11901 * cs-parser.jay: Add error 1017 report.
11903 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11905 Fixed bug #59980, #64224
11906 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
11908 * typemanager.cs (IsSpecialMethod): Simplified
11910 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11912 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
11913 condition with better params.
11915 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11918 * attribute.cs (Resolve): Property has to have both
11921 2004-09-14 Martin Baulig <martin@ximian.com>
11923 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
11925 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11928 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
11929 called and is obsolete then this member suppress message
11930 when call is inside next [Obsolete] method or type.
11932 * expression.cs: Use TestObsoleteMethodUsage member.
11934 2004-09-14 Martin Baulig <martin@ximian.com>
11936 * cs-parser.jay: Sync a bit with the GMCS version.
11938 2004-09-14 Martin Baulig <martin@ximian.com>
11940 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
11941 (CSharpParser.yacc_verbose_flag): New public field.
11943 * genericparser.cs: Removed.
11945 2004-09-14 Raja R Harinath <rharinath@novell.com>
11947 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
11949 2004-09-13 Marek Safar <marek.safar@seznam.cz>
11951 * class.cs (MethodCore.CheckBase): Fix bug #65757.
11953 2004-09-10 Martin Baulig <martin@ximian.com>
11955 Backported my MemberName changes from GMCS into MCS.
11957 - we are now using a special `MemberName' class instead of using
11958 strings; in GMCS, the `MemberName' also contains the type
11961 - changed the grammar rules a bit:
11962 * the old `member_name' is now a `namespace_or_type_name':
11963 The rule is that we use `namespace_or_type_name' everywhere
11964 where we expect either a "member name" (GetEnumerator) or a
11965 "member name" with an explicit interface name
11966 (IEnumerable.GetEnumerator).
11967 In GMCS, the explicit interface name may include type arguments
11968 (IEnumerable<T>.GetEnumerator).
11969 * we use `member_name' instead of just `IDENTIFIER' for
11971 The rule is that we use `member_name' wherever a member may
11972 have type parameters in GMCS.
11974 * decl.cs (MemberName): New public class.
11975 (MemberCore.MemberName): New public readonly field.
11976 (MemberCore.ctor): Take a `MemberName' argument, not a string.
11977 (DeclSpace): Likewise.
11979 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
11980 * enum.cs (Enum.ctor): Likewise.
11982 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
11984 (AliasEntry.ctor): Take a MemberName, not an Expression.
11985 (AliasEntry.UsingAlias): Likewise.
11987 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
11988 (IMethodData.MemberName): Changed type from string to MemberName.
11989 (MemberBase.ExplicitInterfaceName): Likewise.
11990 (AbstractPropertyEventMethod.SetupName): Make this private.
11991 (AbstractPropertyEventMethod.ctor): Added `string prefix'
11992 argument; compute the member name here.
11993 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
11994 on the `member.MemberName' and the `prefix'.
11996 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
11998 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
11999 thus, we get a `MemberName' instead of a `string'. These
12000 declarations may have type parameters in GMCS.
12001 (interface_method_declaration, delegate_declaration): Likewise.
12002 (class_declaration, interface_declaration): Likewise.
12003 (method_header): Use `namespace_or_type_name' instead of
12004 `member_name'. We may be an explicit interface implementation.
12005 (property_declaration, event_declaration): Likewise.
12006 (member_name): This is now just an `IDENTIFIER', not a
12007 `namespace_or_type_name'.
12008 (type_name, interface_type): Removed.
12009 (namespace_or_type_name): Return a MemberName, not an Expression.
12010 (primary_expression): Use `member_name' instead of `IDENTIFIER';
12011 call GetTypeExpression() on the MemberName to get an expression.
12012 (IndexerDeclaration.interface_type): Changed type from string to
12014 (MakeName): Operate on MemberName's instead of string's.
12016 2004-09-13 Raja R Harinath <rharinath@novell.com>
12019 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
12020 (NamespaceEntry.Lookup): Add new argument to flag if we want the
12021 lookup to avoid symbols introduced by 'using'.
12022 * rootcontext.cs (NamespaceLookup): Update.
12024 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12026 * class.cs (TypeContainer.DoDefineMembers): Do not call
12027 DefineDefaultConstructor for static classes.
12029 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12031 * attribute.cs (Attribute.Resolve): Add error 653 report.
12033 * class.cs (Class.ApplyAttributeBuilder): Add error 641
12035 (Method.ApplyAttributeBuilder): Add error 685 report.
12036 (Operator.Define): Add error 564 report.
12038 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
12040 * expression.cs (Invocation.DoResolve): Add error
12041 245 and 250 report.
12043 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
12046 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12048 * class.cs (ConstructorInitializer.Resolve):
12049 Wrong error number (515->516).
12051 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12053 * class.cs (Indexer.Define): Add error 631 report.
12055 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12057 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
12059 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12061 * expression.cs (Probe.DoResolve): Add error CS0241 report.
12063 2004-09-10 Marek Safar <marek.safar@seznam.cz>
12065 * cs-parser.jay: Added error CS0241 report.
12067 2004-09-10 Raja R Harinath <rharinath@novell.com>
12069 * cs-parser.jay (fixed_statement): Introduce a scope for the
12070 declaration in the 'fixed' statement.
12072 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12074 * cs-parser.jay: Added CS0230 error report.
12076 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12078 * cs-parser.jay: Added errors CS0231 and CS0257 report.
12080 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12082 * expression.cs (Argument.Resolve): Added error CS0192 and
12085 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12087 C# 2.0 #pragma warning feature
12089 * cs-tokenizer.cs (PreProcessPragma): New method;
12090 Handles #pragma directive.
12092 * report.cs (WarningRegions): New class; Support
12093 class for #pragma warning directive. It tests whether
12094 warning is enabled for a given line.
12096 2004-09-08 Miguel de Icaza <miguel@ximian.com>
12098 * const.cs: Add more descriptive error report, tahnks to
12101 2004-09-08 Marek Safar <marek.safar@seznam.cz>
12103 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
12105 2004-09-07 Miguel de Icaza <miguel@ximian.com>
12107 * expression.cs: Apply patch from Ben: Remove dead code from
12108 ArrayCreation, and remove the TurnintoConstant call in const.cs,
12109 as that code just threw an exception anwyays.
12111 * const.cs: Remove the call to the turnintoconstant, for details
12114 * literal.cs: The type of the null-literal is the null type; So
12115 we use a placeholder type (literal.cs:System.Null, defined here)
12118 * expression.cs (Conditional.DoResolve): Remove some old code that
12119 is no longer needed, conversions have been fixed.
12121 (ArrayCreationExpression.DoResolve): Return false if we fail to
12122 resolve the inner expression.
12124 2004-09-07 Raja R Harinath <rharinath@novell.com>
12127 * cs-parser.jay (delegate_declaration): Record a delegate
12128 declaration as a type declaration.
12129 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
12131 2004-09-06 Miguel de Icaza <miguel@ximian.com>
12133 * parameter.cs: Do not crash if the type can not be resolved.
12135 * expression.cs: Report errors with unsafe pointers, fixes #64896
12137 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
12139 * expression.cs: Pointer arith always needs to do a conv.i
12140 if the operand is a long. fix 65320
12142 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12144 Fixed cs0619-37.cs, cs0619-38.cs
12146 * enum.cs (GetObsoleteAttribute): Removed.
12148 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
12149 on Enum member is double staged. The first is tested member
12152 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12154 Fixed #56986, #63631, #65231
12156 * class.cs: (TypeContainer.AddToMemberContainer): New method,
12157 adds member to name container.
12158 (TypeContainer.AddToTypeContainer): New method, adds type to
12160 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
12161 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
12162 AddOperator): Simplified by reusing AddToMemberContainer.
12163 (TypeContainer.UserDefinedStaticConstructor): Changed to property
12165 (Method.CheckForDuplications): Fixed implementation to test all
12167 (MemberBase): Detection whether member is explicit interface
12168 implementation is now in constructor.
12169 (MemberBase.UpdateMemberName): Handles IndexerName.
12170 (Accessor): Changed to keep also location information.
12171 (AbstractPropertyEventMethod): Is derived from MemberCore.
12172 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
12173 will be emited or not.
12174 (PropertyBase.AreAccessorsDuplicateImplementation):
12175 Tests whether accessors are not in collision with some method.
12176 (Operator): Is derived from MethodCore to simplify common
12179 * decl.cs (Flags.TestMethodDuplication): Test for duplication
12181 (DeclSpace.AddToContainer): Adds the member to defined_names
12182 table. It tests for duplications and enclosing name conflicts.
12184 * enum.cs (EnumMember): Clean up to reuse the base structures
12186 2004-09-03 Martin Baulig <martin@ximian.com>
12188 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
12189 into TypeContainer, to make partial classes work again.
12191 2004-09-03 Martin Baulig <martin@ximian.com>
12193 * rootcontext.cs (RootContext.V2): Removed.
12195 2004-03-23 Martin Baulig <martin@ximian.com>
12197 * expression.cs (Invocation.OverloadResolve): Added `bool
12198 may_fail' argument and use it instead of the Location.IsNull() hack.
12200 2004-09-03 Martin Baulig <martin@ximian.com>
12202 Merged latest changes into gmcs. Please keep this comment in
12203 here, it makes it easier for me to see what changed in MCS since
12204 the last time I merged.
12206 2004-09-03 Raja R Harinath <rharinath@novell.com>
12209 * expression.cs (BetterConversion): Don't allow either conversion
12210 to be null. Remove redundant implicit conversion test when 'q ==
12211 null' -- when this function is invoked, we already know that the
12212 implicit conversion exists.
12213 (BetterFunction): Assume that 'best' is non-null. Remove
12214 redundant reimplementation of IsApplicable when 'best' is null.
12215 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
12216 number of arguments.
12217 (IsAncestralType): Extract from OverloadResolve.
12218 (OverloadResolve): Make robust to the MethodGroupExpr being
12219 unsorted. Implement all the logic of Section 14.5.5.1, and
12220 support overloading of methods from multiple applicable types.
12221 Clean up logic somewhat. Don't pass null methods to BetterFunction.
12223 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
12224 (RealError, Warning): Append type of report to related symbol.
12226 2004-09-03 Marek Safar <marek.safar@seznam.cz>
12228 * enum.cs: Fixed CLS-Compliance checks for enum members.
12229 Error tests cs3008-8.cs, cs3014-8.cs
12231 2004-09-02 Marek Safar <marek.safar@seznam.cz>
12233 Fixed bug #62342, #63102
12234 * class.cs: ImplementIndexer uses member.IsExplicitImpl
12235 like ImplementMethod.
12237 2004-09-02 Marek Safar <marek.safar@seznam.cz>
12239 * attribute.cs (Attribute.GetAttributeArgumentExpression):
12242 2004-09-02 Martin Baulig <martin@ximian.com>
12244 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
12245 TypeManager.GetArgumentTypes() rather than calling GetParameters()
12248 2004-09-01 Marek Safar <marek.safar@seznam.cz>
12250 C# 2.0 Static classes implemented
12252 * class.cs (TypeContainer): instance_constructors,
12253 initialized_fields, initialized_static_fields,
12254 default_constructor, base_inteface_types are protected to be
12255 accessible from StaticClass.
12256 (TypeContainer.DefineDefaultConstructor): New virtual method
12257 for custom default constructor generating
12258 (StaticClass): New class to handle "Static classes" feature.
12260 * cs-parser.jay: Handle static keyword on class like instance
12263 * driver.cs: Added "/langversion" command line switch with two
12264 options (iso-1, default).
12266 2004-08-31 Marek Safar <marek.safar@seznam.cz>
12268 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
12270 2004-08-31 Miguel de Icaza <miguel@ximian.com>
12272 * delegate.cs: Style.
12274 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
12276 * delegate.cs: Add seperate instance expr field for miguel.
12278 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
12280 * PointerArithmetic (Resolve): make sure we are not doing
12281 pointer arith on void*. Also, make sure we are resolved
12282 by not setting eclass until resolve.
12284 All callers: Make sure that PointerArithmetic gets resolved.
12286 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
12288 * ArrayCreation (LookupType): If the type does not resolve
12289 to an array, give an error.
12291 2004-08-27 Marek Safar <marek.safar@seznam.cz>
12293 * statement.cs (Try.Resolve): Fixed bug #64222
12295 2004-08-27 Martin Baulig <martin@ximian.com>
12298 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
12301 2004-08-26 Marek Safar <marek.safar@seznam.cz>
12303 * ecore.cs (Constantify): Get underlying type via
12304 System.Enum.GetUnderlyingType to avoid StackOverflow on the
12305 Windows in special cases.
12307 2004-08-26 Marek Safar <marek.safar@seznam.cz>
12309 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
12310 for obtaining also private methods.
12311 (GetRemoveMethod): Used GetRemoveMethod (true)
12312 for obtaining also private methods.
12314 2004-08-24 Martin Baulig <martin@ximian.com>
12316 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
12317 MethodAttributes.HideBySig for operators.
12319 2004-08-23 Martin Baulig <martin@ximian.com>
12321 Back to the old error reporting system :-)
12323 * report.cs (Message): Removed.
12324 (Report.MessageData, ErrorData, WarningData): Removed.
12325 (Report.Error, Warning): Back to the old system.
12327 2004-08-23 Martin Baulig <martin@ximian.com>
12329 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
12331 * class.cs (TypeContainer.ParentContainer): New public virtual
12332 method; replaces the explicit interface implementation.
12333 (ClassPart.ParentContainer): Override.
12335 2004-08-23 Martin Baulig <martin@ximian.com>
12337 * statement.cs (Switch): Added support for constant switches; see
12338 #59428 or test-285.cs.
12340 2004-08-22 Marek Safar <marek.safar@seznam.cz>
12343 * statement.cs (GetEnumeratorFilter): Removed useless
12344 logic because C# specs is strict. GetEnumerator must be
12347 2004-08-22 Martin Baulig <martin@ximian.com>
12349 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
12350 a switch and may break, reset the barrier. Fixes #59867.
12352 2004-08-22 Marek Safar <marek.safar@seznam.cz>
12354 CLS-Compliance speed up (~5% for corlib)
12356 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
12357 New method. Tests container for CLS-Compliant names
12359 * class.cs (TypeContainer.VerifyClsName): New method.
12360 Checks whether container name is CLS Compliant.
12361 (Constructor): Implements IMethodData.
12363 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
12364 low-case table for CLS Compliance test.
12365 (MemberCache.VerifyClsParameterConflict): New method.
12366 Checks method parameters for CS3006 error.
12368 * enum.cs (EnumMember): Is derived from MemberCore.
12369 (Enum.VerifyClsName): Optimized for better performance.
12371 2004-08-06 Marek Safar <marek.safar@seznam.cz>
12373 * report.cs: Renamed Error_T to Error and changed all
12376 2004-08-06 Marek Safar <marek.safar@seznam.cz>
12378 * class.cs (TypeContainer.IndexerArrayList): New inner class
12379 container for indexers.
12380 (TypeContainer.DefaultIndexerName): New constant for default
12381 indexer name. Replaced all "Item" with this constant.
12382 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
12384 * typemanager.cs (TypeManager.default_member_ctor): Cache here
12385 DefaultMemberAttribute constructor.
12387 2004-08-05 Martin Baulig <martin@ximian.com>
12389 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
12392 2004-08-05 Marek Safar <marek.safar@seznam.cz>
12394 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
12395 multi platforms problem.
12397 * compiler.csproj: Included shared files.
12399 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12401 Fix bug 60333, 55971 in the more general way
12402 * attribute.cs (Attribute.GetAttributeArgumentExpression):
12403 Added arg_type argument for constant conversion.
12404 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
12406 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12409 * class.cs (TypeContainer ): New inner classes MethodArrayList,
12410 OperatorArrayList, MethodCoreArrayList for typecontainer
12411 containers. Changed class member types to these new types.
12412 (MethodArrayList.DefineMembers): Added test for CS0659.
12414 2004-08-04 Miguel de Icaza <miguel@ximian.com>
12416 * cfold.cs: Synchronize the folding with the code in expression.cs
12417 Binary.DoNumericPromotions for uint operands.
12419 * attribute.cs: Revert patch from Raja, it introduced a regression
12420 while building Blam-1.2.1 (hard to isolate a test case).
12422 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12426 (TypeContainer.Define): Renamed to DefineContainerMembers because of
12428 (MethodCore.parent_method): New member. The method we're overriding
12429 if this is an override method.
12430 (MethodCore.CheckBase): Moved from Method class and made common.
12431 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
12433 (MethodCore.CheckForDuplications): New abstract method. For custom
12434 member duplication search in a container
12435 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
12436 method and its return type.
12437 (Event.conflict_symbol): New member. Symbol with same name in the
12441 (MemberCache.FindMemberWithSameName): New method. The method
12442 is looking for conflict with inherited symbols.
12444 2004-08-04 Martin Baulig <martin@ximian.com>
12446 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
12448 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
12450 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12452 * report.cs (Message): New enum for better error, warning reference in
12454 (MessageData): New inner abstract class. It generally handles printing of
12455 error and warning messages.
12456 Removed unused Error, Warning, Message methods.
12458 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12460 Fix for cs0592-8.cs test
12462 (Attributable.ValidAttributeTargets): Made public.
12463 (Attribute.ExplicitTarget): New member for explicit target value.
12464 (Attribute.CheckTargets): Now we translate explicit attribute
12465 target to Target here.
12467 2004-08-03 Ben Maurer <bmaurer@ximian.com>
12469 * ecore.cs (MethodGroupExpr): new IsBase property.
12471 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
12473 * delegate.cs (DelegateCreation): store a MethodGroupExpr
12474 rather than an instance expr.
12476 (DelegateCreation.Emit): Use the method group rather than
12477 the instance expression. Also, if you have base.Foo as the
12478 method for a delegate, make sure to emit ldftn, not ldftnvirt.
12480 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
12482 (NewDelegate.DoResolve): Only check for the existance of Invoke
12483 if the method is going to be needed. Use MethodGroupExpr.
12485 (NewDelegate.Emit): Remove, DelegateCreation implements this.
12487 * expression.cs: For pointer arith., make sure to use
12488 the size of the type, not the size of the pointer to
12491 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12494 * class.cs (Class): Added error CS0502 test.
12496 2004-08-03 John Luke <jluke@cfl.rr.com>
12497 Raja R Harinath <rharinath@novell.com>
12500 * attribute.cs (Attribute.complained_before): New flag.
12501 (Attribute.ResolveType, Attribute.Resolve),
12502 (Attribute.DefinePInvokeMethod): Set it.
12503 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
12505 2004-08-03 Martin Baulig <martin@ximian.com>
12507 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
12508 use a user-defined operator; we still need to do numeric
12509 promotions in case one argument is a builtin type and the other
12510 one has an implicit conversion to that type. Fixes #62322.
12512 2004-08-02 Martin Baulig <martin@ximian.com>
12514 * statement.cs (LocalInfo.Flags): Added `IsThis'.
12515 (LocalInfo.IsThis): New public property.
12516 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
12518 2004-08-01 Martin Baulig <martin@ximian.com>
12520 * class.cs (TypeContainer.GetClassBases): Don't set the default
12521 here since we may get called from GetPartialBases().
12522 (TypeContainer.DefineType): If GetClassBases() didn't return a
12523 parent, use the default one.
12525 2004-07-30 Duncan Mak <duncan@ximian.com>
12527 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
12529 2004-07-30 Martin Baulig <martin@ximian.com>
12531 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
12533 * class.cs (SourceMethod): New public class, derive from the
12534 symbol writer's ISourceMethod.
12535 (Method): Use the new symbol writer API.
12537 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
12538 as argument and use the new symbol writer.
12541 (SourceFile): Implement the symbol writer's ISourceFile.
12542 (Location.SymbolDocument): Removed.
12543 (Location.SourceFile): New public property.
12545 * symbolwriter.cs: Use the new symbol writer API.
12547 2004-07-30 Raja R Harinath <rharinath@novell.com>
12549 * Makefile (install-local): Remove. Functionality moved to
12552 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
12554 * Makefile: Install mcs.exe.config file together with mcs.exe.
12555 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
12556 correct runtime version.
12558 2004-07-25 Martin Baulig <martin@ximian.com>
12561 (TypeContainer.RegisterOrder): Removed, this was unused.
12562 (TypeContainer, interface_order): Removed.
12563 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
12564 TypeContainer as argument since we can also be called with a
12565 `PartialContainer' for a partial class/struct/interface.
12566 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
12567 of checking whether we're an `Interface' - we could be a
12568 `PartialContainer'.
12569 (PartialContainer.Register): Override; call
12570 AddClass()/AddStruct()/AddInterface() on our parent.
12572 * cs-parser.jay (interface_member_declaration): Add things to the
12573 `current_container', not the `current_class'.
12575 * rootcontext.cs (RegisterOrder): The overloaded version which
12576 takes an `Interface' was unused, removed.
12578 * typemanager.cs (TypeManager.LookupInterface): Return a
12579 `TypeContainer', not an `Interface'.
12580 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
12581 contain a `PartialContainer' for an interface, so check it's
12582 `Kind' to figure out what it is.
12584 2004-07-25 Martin Baulig <martin@ximian.com>
12586 * class.cs (Class.DefaultTypeAttributes): New public constant.
12587 (Struct.DefaultTypeAttributes): Likewise.
12588 (Interface.DefaultTypeAttributes): Likewise.
12589 (PartialContainer.TypeAttr): Override this and add the
12590 DefaultTypeAttributes.
12592 2004-07-25 Martin Baulig <martin@ximian.com>
12594 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
12595 we can just use the `Parent' field instead.
12597 2004-07-25 Martin Baulig <martin@ximian.com>
12599 * class.cs (TypeContainer.Emit): Renamed to EmitType().
12601 2004-07-25 Martin Baulig <martin@ximian.com>
12603 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
12604 our parts before defining any methods.
12605 (TypeContainer.VerifyImplements): Make this virtual.
12606 (ClassPart.VerifyImplements): Override and call VerifyImplements()
12607 on our PartialContainer.
12609 2004-07-25 Martin Baulig <martin@ximian.com>
12611 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
12613 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
12614 argument, we can just use the `Parent' field instead.
12617 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
12618 (MemberBase.DoDefine): Likewise.
12620 2004-07-24 Martin Baulig <martin@ximian.com>
12622 * decl.cs (MemberCore.Parent): New public field.
12623 (DeclSpace.Parent): Moved to MemberCore.
12625 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
12626 (MemberBase.ctor): Added TypeContainer argument, pass it to our
12628 (FieldBase, Field, Operator): Likewise.
12629 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
12630 (EventField, Event): Likewise.
12632 2004-07-23 Martin Baulig <martin@ximian.com>
12634 * class.cs (PartialContainer): New public class.
12635 (ClassPart): New public class.
12636 (TypeContainer): Added support for partial classes.
12637 (TypeContainer.GetClassBases): Splitted some of the functionality
12638 out into GetNormalBases() and GetPartialBases().
12640 * cs-tokenizer.cs (Token.PARTIAL): New token.
12641 (Tokenizer.consume_identifier): Added some hacks to recognize
12642 `partial', but only if it's immediately followed by `class',
12643 `struct' or `interface'.
12645 * cs-parser.jay: Added support for partial clases.
12647 2004-07-23 Martin Baulig <martin@ximian.com>
12649 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
12650 a `DeclSpace' and also made it readonly.
12651 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
12652 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
12653 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
12655 * cs-parser.jay: Pass the `current_class', not the
12656 `current_container' (at the moment, this is still the same thing)
12657 to a new Method, Property, Event, Indexer or Constructor.
12659 2004-07-23 Martin Baulig <martin@ximian.com>
12661 * cs-parser.jay (CSharpParser): Added a new `current_class' field
12662 and removed the `current_interface' one.
12663 (struct_declaration, class_declaration, interface_declaration):
12664 Set `current_class' to the newly created class/struct/interface;
12665 set their `Bases' and call Register() before parsing their body.
12667 2004-07-23 Martin Baulig <martin@ximian.com>
12669 * class.cs (Kind): New public enum.
12670 (TypeContainer): Made this class abstract.
12671 (TypeContainer.Kind): New public readonly field.
12672 (TypeContainer.CheckDef): New public method; moved here from
12674 (TypeContainer.Register): New public abstract method.
12675 (TypeContainer.GetPendingImplementations): New public abstract
12677 (TypeContainer.GetClassBases): Removed the `is_class' and
12678 `is_iface' parameters.
12679 (TypeContainer.DefineNestedTypes): Formerly known as
12681 (ClassOrStruct): Made this class abstract.
12683 * tree.cs (RootTypes): New public type.
12685 2004-07-20 Martin Baulig <martin@ximian.com>
12687 * tree.cs (Tree.RecordNamespace): Removed.
12688 (Tree.Namespaces): Removed.
12690 * rootcontext.cs (RootContext.IsNamespace): Removed.
12692 * cs-parser.jay (namespace_declaration): Just create a new
12693 NamespaceEntry here.
12695 2004-07-20 Martin Baulig <martin@ximian.com>
12697 * statement.cs (ExceptionStatement): New abstract class. This is
12698 now used as a base class for everyone who's using `finally'.
12699 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
12700 our local variables before using them.
12702 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
12703 virtual method. This is used by Yield.Resolve() to "steal" an
12704 outer block's `finally' clauses.
12705 (FlowBranchingException): The .ctor now takes an ExceptionStatement
12708 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
12709 version which takes an ExceptionStatement. This version must be
12710 used to create exception branchings.
12713 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
12714 (Iterator.EmitMoveNext): Added exception support; protect the
12715 block with a `fault' clause, properly handle 'finally' clauses.
12716 (Iterator.EmitDispose): Run all the `finally' clauses here.
12718 2004-07-20 Martin Baulig <martin@ximian.com>
12720 * iterator.cs: This is the first of a set of changes in the
12721 iterator code. Match the spec more closely: if we're an
12722 IEnumerable, then GetEnumerator() must be called. The first time
12723 GetEnumerator() is called, it returns the current instance; all
12724 subsequent invocations (if any) must create a copy.
12726 2004-07-19 Miguel de Icaza <miguel@ximian.com>
12728 * expression.cs: Resolve the constant expression before returning
12731 2004-07-19 Martin Baulig <martin@ximian.com>
12733 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
12734 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
12735 the return type of the new EmitContext.
12737 2004-07-18 Martin Baulig <martin@ximian.com>
12739 * class.cs (Property.Define): Fix iterators.
12741 * iterators.cs (Iterator.Define): Moved the
12742 `container.AddInterator (this)' call here from the .ctor; only do
12743 it if we resolved successfully.
12745 2004-07-17 Miguel de Icaza <miguel@ximian.com>
12747 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
12748 `true' for preprocessing directives that we parse. The return
12749 value indicates whether we should return to regular tokenizing or
12750 not, not whether it was parsed successfully.
12752 In the past if we were in: #if false ... #line #endif, we would
12753 resume parsing after `#line'. See bug 61604.
12755 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
12756 building: IsEnumType should return true only for enums, not for
12757 enums or System.Enum itself. This fixes #61593.
12759 Likely what happened is that corlib was wrong: mcs depended on
12760 this bug in some places. The bug got fixed, we had to add the
12761 hack, which caused bug 61593.
12763 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
12764 that was a workaround for the older conditions.
12766 2004-07-16 Ben Maurer <bmaurer@ximian.com>
12768 * assign.cs: IAssignMethod has a new interface, as documented
12769 inline. All assignment code now uses this new api.
12771 * ecore.cs, expression.cs: All classes which implement
12772 IAssignMethod now use the new interface.
12774 * expression.cs (Invocation): add a hack to EmitCall so that
12775 IndexerAccess can be the target of a compound assignment without
12776 evaluating its arguments twice.
12778 * statement.cs: Handle changes in Invocation api.
12780 2004-07-16 Martin Baulig <martin@ximian.com>
12782 * iterators.cs: Rewrote this. We're now using one single Proxy
12783 class for both the IEnumerable and the IEnumerator interface and
12784 `Iterator' derives from Class so we can use the high-level API.
12786 * class.cs (TypeContainer.AddIterator): New method.
12787 (TypeContainer.DoDefineType): New protected virtual method, which
12788 is called from DefineType().
12789 (TypeContainer.DoDefineMembers): Call DefineType() and
12790 DefineMembers() on all our iterators.
12791 (TypeContainer.Emit): Call Emit() on all our iterators.
12792 (TypeContainer.CloseType): Call CloseType() on all our iterators.
12794 * codegen.cs (EmitContext.CurrentIterator): New public field.
12796 2004-07-15 Martin Baulig <martin@ximian.com>
12799 (TypeManager.not_supported_exception_type): New type.
12801 2004-07-14 Martin Baulig <martin@ximian.com>
12803 * iterators.cs: Use real error numbers.
12805 2004-07-14 Martin Baulig <martin@ximian.com>
12807 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
12808 requires this to be a System.Collection.IEnumerable and not a
12809 class implementing that interface.
12810 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
12812 2004-07-13 Marek Safar <marek.safar@seznam.cz>
12814 * class.cs: Fixed previous fix, it broke some error tests.
12816 2004-07-12 Martin Baulig <martin@ximian.com>
12818 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
12821 2004-07-09 Miguel de Icaza <miguel@ximian.com>
12823 * assign.cs (LocalTemporary): Add new argument: is_address,If
12824 `is_address' is true, then the value that we store is the address
12825 to the real value, and not the value itself.
12827 * ecore.cs (PropertyExpr): use the new local temporary
12828 stuff to allow us to handle X.Y += z (where X is a struct)
12830 2004-07-08 Martin Baulig <martin@ximian.com>
12832 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
12833 not always return, just like we're doing in Using.Resolve().
12835 2004-07-07 Miguel de Icaza <miguel@ximian.com>
12837 * cs-parser.jay (fixed_statement): flag this as Pinned.
12839 2004-07-06 Miguel de Icaza <miguel@ximian.com>
12841 * typemanager.cs (TypeManager): Removed MakePinned method, this
12842 mechanism is replaced with the .NET 2.x compatible mechanism of
12843 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
12845 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
12846 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
12847 `IsFixed' property which has a different meaning.
12849 2004-07-02 Raja R Harinath <rharinath@novell.com>
12851 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
12852 visible from inside a nested class, not just the names of the
12853 immediately enclosing class.
12854 Fix for bug #60730.
12856 2004-06-24 Raja R Harinath <rharinath@novell.com>
12858 * expression.cs (BetterConversion): Remove buggy special-case
12859 handling of "implicit constant expression conversions". At this
12860 point, we already know that the conversion is possible -- we're
12861 only checking to see which is better.
12863 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12865 * cs-parser.jay: Added error CS0210 test.
12867 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12869 * cs-parser.jay: Added error CS0134 test.
12871 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12874 * cs-parser.jay: Added error CS0145 test.
12876 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12878 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
12880 2004-06-23 Ben Maurer <bmaurer@ximian.com>
12882 * expression.cs (StackAlloc.Resolve): The argument may not
12883 be a constant; deal with this case.
12885 2004-06-23 Marek Safar <marek.safar@seznam.cz>
12887 * attribute.cs (IndexerName_GetIndexerName): Renamed to
12888 GetIndexerAttributeValue.
12889 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
12891 * class.cs (Indexer.Define): Added error tests for CS0415,
12894 2004-06-23 Miguel de Icaza <miguel@ximian.com>
12896 * attribute.cs (Attribute.Resolve): Keep field code in sync with
12899 2004-06-23 Martin Baulig <martin@ximian.com>
12901 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
12902 neither return nor throw, reset the barrier as well. Fixes #60457.
12904 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
12906 * class.cs : EventAttributes is now set to None by default.
12907 This fixes bug #60459.
12909 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12912 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12913 Don't throw exception but return null (it's sufficient now).
12915 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12917 * typemanager.cs (GetArgumentTypes): Faster implementation.
12919 2004-06-18 Martin Baulig <martin@ximian.com>
12921 * attribute.cs (Attribute.Resolve): Check whether we're an
12922 EmptyCast which a Constant child. Fixes #60333.
12924 2004-06-17 Ben Maurer <bmaurer@ximian.com>
12926 * statement.cs (EmitCollectionForeach): Account for the fact that
12927 not all valuetypes are in areas which we can take the address of.
12928 For these variables, we store to a temporary variable. Also, make
12929 sure that we dont emit a `callvirt' on a valuetype method.
12931 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12933 * expression.cs (StackAlloc.DoReSolve): Added test for
12934 negative parameter (CS0247).
12936 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12939 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
12941 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12944 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
12947 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12949 Fix bug #58254 & cs1555.cs, cs1556.cs
12950 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
12952 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12954 * cs-parser.jay: Added error CS1669 test for indexers.
12956 2004-06-11 Martin Baulig <martin@ximian.com>
12958 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
12959 call this twice: for params and varargs methods.
12961 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12964 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
12966 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12968 * attribute.cs (Attribute.GetValidTargets): Made public.
12971 (AbstractPropertyEventMethod): New class for better code sharing.
12972 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
12974 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
12976 2004-06-11 Raja R Harinath <rharinath@novell.com>
12979 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
12980 that the call to Resolve is part of a MemberAccess.
12981 (Expression.Resolve): Use it for SimpleName resolution.
12982 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
12983 Add 'intermediate' boolean argument.
12984 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
12985 error message when the SimpleName can be resolved ambiguously
12986 between an expression and a type.
12987 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
12989 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
12990 call on the left-side.
12992 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12995 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
12997 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12999 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
13001 2004-06-11 Martin Baulig <martin@ximian.com>
13003 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
13004 varargs methods if applicable.
13006 2004-06-11 Martin Baulig <martin@ximian.com>
13008 * expression.cs (Invocation.EmitCall): Don't use
13009 `method.CallingConvention == CallingConventions.VarArgs' since the
13010 method could also have `CallingConventions.HasThis'.
13012 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13014 * class.cs (Event.GetSignatureForError): Implemented.
13015 Fixed crash in error test cs3010.cs
13017 2004-06-10 Miguel de Icaza <miguel@ximian.com>
13019 * cs-tokenizer.cs: Change the way we track __arglist to be
13020 consistent with the other keywords.
13022 2004-06-09 Miguel de Icaza <miguel@ximian.com>
13024 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
13027 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
13029 * codegen.cs: Check that all referenced assemblies have a strongname
13030 before strongnaming the compiled assembly. If not report error CS1577.
13031 Fix bug #56563. Patch by Jackson Harper.
13032 * typemanager.cs: Added a method to return all referenced assemblies.
13033 Fix bug #56563. Patch by Jackson Harper.
13035 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13038 (Method.ApplyAttributeBuilder): Moved and added conditional
13039 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
13042 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
13044 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13047 * class.cs: (EventField.attribute_targets): Changed default target.
13049 2004-06-08 Martin Baulig <martin@ximian.com>
13051 * expression.cs (Invocation.EmitCall): Enable varargs methods.
13053 2004-06-08 Martin Baulig <martin@ximian.com>
13055 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
13057 2004-06-07 Martin Baulig <martin@ximian.com>
13059 Added support for varargs methods.
13061 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
13064 * cs-parser.jay: Added support for `__arglist'.
13066 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
13068 * expression.cs (Argument.AType): Added `ArgList'.
13069 (Invocation): Added support for varargs methods.
13070 (ArglistAccess): New public class.
13071 (Arglist): New public class.
13073 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
13075 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
13076 a method's top-level block if the method has varargs.
13078 * support.cs (ReflectionParameters, InternalParameters): Added
13079 support for varargs methods.
13081 2004-06-07 Miguel de Icaza <miguel@ximian.com>
13083 * class.cs: Provide location in indexer error report.
13085 * driver.cs: Use standard names.
13087 * namespace.cs: Catch the use of using after a namespace has been
13088 declared also on using aliases.
13090 2004-06-03 Raja R Harinath <rharinath@novell.com>
13093 * typemanager.cs (closure_private_ok, closure_invocation_type)
13094 (closure_qualifier_type, closure_invocation_assembly)
13095 (FilterWithClosure): Move to ...
13096 (Closure): New internal nested class.
13097 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
13098 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
13099 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
13100 (MemberLookup, MemberLookupFailed): Use it.
13101 * expression.cs (New.DoResolve): Treat the lookup for the
13102 constructor as being qualified by the 'new'ed type.
13103 (Indexers.GetIndexersForTypeOrInterface): Update.
13105 2004-06-03 Marek Safar <marek.safar@seznam.cz>
13108 (GetConditionalAttributeValue): New method. Returns
13109 condition of ConditionalAttribute.
13110 (SearchMulti): New method. Returns all attributes of type 't'.
13111 Use it when attribute is AllowMultiple = true.
13112 (IsConditionalMethodExcluded): New method.
13115 (Method.IsExcluded): Implemented. Returns true if method has conditional
13116 attribute and the conditions is not defined (method is excluded).
13117 (IMethodData): Extended interface for ConditionalAttribute support.
13118 (PropertyMethod.IsExcluded): Implemented.
13121 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
13124 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
13127 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
13129 * expression.cs (ArrayCreationExpression): Make this just an
13130 `expression'. It can't be a statement, so the code here was
13133 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13136 * typemanager.cs (GetFullNameSignature): New method for
13139 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13142 * class.cs (MemberBase.GetSignatureForError): New virtual method.
13143 Use this method when MethodBuilder is null.
13144 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
13145 Added test for error CS0626 (MONO reports error for this situation).
13146 (IMethodData.GetSignatureForError): Extended interface.
13148 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13151 (AttributeTester.GetObsoleteAttribute): Returns instance of
13152 ObsoleteAttribute when type is obsolete.
13155 (TypeContainer.VerifyObsoleteAttribute): Override.
13156 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
13157 (MethodCode.VerifyObsoleteAttribute): Override.
13158 (MemberBase.VerifyObsoleteAttribute): Override.
13161 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
13162 and report proper error.
13165 Delegate.VerifyObsoleteAttribute): Override.
13168 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
13169 and report proper error.
13170 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
13173 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
13177 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
13178 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
13179 Added test for ObsoleteAttribute.
13182 (Catch): Derived from Statement.
13184 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13186 Fixed bug #59071 & cs0160.cs
13188 * statement.cs (Try.Resolve): Check here whether order of catch
13189 clauses matches their dependencies.
13191 2004-05-31 Miguel de Icaza <miguel@ximian.com>
13193 * Reverted patch to namespace.cs (Use lookuptypedirect). This
13194 caused a regression: #59343. Referencing nested classes from an
13195 assembly stopped working.
13197 2004-05-31 Martin Baulig <martin@ximian.com>
13199 MCS is now frozen for beta 2.
13201 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13203 * convert.cs: add a trivial cache for overload operator resolution.
13205 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13207 * decl.cs: If possible, use lookuptypedirect here. We can only do
13208 this if there is no `.' after the namespace. Avoids using
13209 LookupType, which does lots of slow processing.
13210 (FindNestedType) New method, does what it says :-).
13211 * namespace.cs: use LookupTypeDirect.
13212 * rootcontext.cs: use membercache, if possible.
13213 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
13215 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13218 According to the spec,
13220 In a member access of the form E.I, if E is a single identifier,
13221 and if the meaning of E as a simple-name (§7.5.2) is a constant,
13222 field, property, localvariable, or parameter with the same type as
13223 the meaning of E as a type-name (§3.8), then both possible
13224 meanings of E are permitted.
13226 We did not check that E as a simple-name had the same type as E as
13229 This trivial check gives us 5-7% on bootstrap time.
13231 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13233 * expression.cs (Invocation.OverloadResolve): Avoid the
13234 use of hashtables and boxing here by allocating on demand.
13236 2004-05-30 Martin Baulig <martin@ximian.com>
13238 * rootcontext.cs (RootContext.LookupType): Don't cache things if
13239 we're doing a silent lookup. Don't try to lookup nested types in
13240 TypeManager.object_type (thanks to Ben Maurer).
13242 2004-05-30 Martin Baulig <martin@ximian.com>
13244 Committing a patch from Ben Maurer.
13246 * rootcontext.cs (RootContext.LookupType): Cache negative results.
13248 2004-05-29 Martin Baulig <martin@ximian.com>
13250 * class.cs (IMethodData.ShouldIgnore): New method.
13252 * typemanager.cs (TypeManager.MethodFlags): Don't take a
13253 `Location' argument, we don't need it anywhere. Use
13254 `IMethodData.ShouldIgnore ()' instead of
13255 `MethodData.GetMethodFlags ()'.
13256 (TypeManager.AddMethod): Removed.
13257 (TypeManager.AddMethod2): Renamed to AddMethod.
13259 2004-05-29 Martin Baulig <martin@ximian.com>
13261 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
13263 * convert.cs (Convert.ImplicitReferenceConversion): If we're
13264 converting from a class type S to an interface type and we already
13265 have an object on the stack, don't box it again. Fixes #52578.
13267 2004-05-29 Martin Baulig <martin@ximian.com>
13269 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
13270 Added support for `params' parameters. Fixes #59267.
13272 2004-05-29 Martin Baulig <martin@ximian.com>
13274 * literal.cs (NullPointer): Provide a private .ctor which sets
13275 `type' to TypeManager.object_type. Fixes #59048.
13277 2004-05-29 Martin Baulig <martin@ximian.com>
13279 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
13280 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
13282 * ecore.cs (EventExpr.instance_expr): Make the field private.
13284 2004-05-26 Marek Safar <marek.safar@seznam.cz>
13286 Fixed bug #50080 & cs0214-2.cs
13287 * expression.cs (Cast.DoResolve): Check unsafe context here.
13289 * statement.cs (Resolve.DoResolve): Likewise.
13291 2004-05-26 Martin Baulig <martin@ximian.com>
13293 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
13295 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
13296 (RootContext.LookupType): Pass down the `silent' flag.
13298 2004-05-25 Martin Baulig <martin@ximian.com>
13301 (MethodGroupExpr.IdenticalTypeName): New public property.
13302 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
13303 expression actually refers to a type.
13305 2004-05-25 Martin Baulig <martin@ximian.com>
13307 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
13308 for #56176 and made it actually work.
13310 2004-05-25 Martin Baulig <martin@ximian.com>
13312 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
13313 (FieldExpr, PropertyExpr): Override and implement
13314 CacheTemporaries. Fixes #52279.
13316 2004-05-25 Miguel de Icaza <miguel@ximian.com>
13318 * location.cs: In the new compiler listing a file twice is a
13319 warning, not an error.
13321 2004-05-24 Martin Baulig <martin@ximian.com>
13323 * enum.cs (Enum.DefineType): For the `BaseType' to be a
13324 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
13326 2004-05-24 Martin Baulig <martin@ximian.com>
13328 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
13329 walking the `using' list. Fixes #53921.
13331 2004-05-24 Martin Baulig <martin@ximian.com>
13333 * const.cs (Const.LookupConstantValue): Added support for
13334 EmptyCast's; fixes #55251.
13336 2004-05-24 Martin Baulig <martin@ximian.com>
13338 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
13339 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
13340 which does the CS0135 check. The reason is that we first need to
13341 check whether the variable actually exists.
13343 2004-05-24 Martin Baulig <martin@ximian.com>
13345 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
13346 than RootContext.LookupType() to find the explicit interface
13347 type. Fixes #58584.
13349 2004-05-24 Raja R Harinath <rharinath@novell.com>
13351 * Makefile: Simplify. Use executable.make.
13352 * mcs.exe.sources: New file. List of sources of mcs.exe.
13354 2004-05-24 Anders Carlsson <andersca@gnome.org>
13358 Use the invariant culture when doing String.Compare for CLS case
13361 2004-05-23 Martin Baulig <martin@ximian.com>
13363 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
13364 don't have any dots. Fixes #52622, added cs0246-8.cs.
13366 * namespace.cs (NamespaceEntry.Lookup): Likewise.
13368 2004-05-23 Marek Safar <marek.safar@seznam.cz>
13370 * class.cs (MemberBase.Define): Reuse MemberType member for
13371 resolved type. Other methods can use it too.
13373 2004-05-23 Martin Baulig <martin@ximian.com>
13375 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
13376 the variable also exists in the current block (otherwise, we need
13377 to report a CS0103). Fixes #58670.
13379 2004-05-23 Martin Baulig <martin@ximian.com>
13381 * flowanalysis.cs (Reachability.Reachable): Compute this
13382 on-the-fly rather than storing it as a field.
13384 2004-05-23 Martin Baulig <martin@ximian.com>
13386 * flowanalysis.cs (Reachability.And): Manually compute the
13387 resulting `barrier' from the reachability.
13389 2004-05-23 Marek Safar <marek.safar@seznam.cz>
13392 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
13393 instance of ObsoleteAttribute when symbol is obsolete.
13396 (IMethodData): Extended interface for ObsoleteAttribute support.
13398 2004-05-22 Marek Safar <marek.safar@seznam.cz>
13400 * attribute.cs: Fix bug #55970
13402 2004-05-22 Marek Safar <marek.safar@seznam.cz>
13406 (GetObsoleteAttribute): New method. Creates the instance of
13408 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
13409 ObsoleteAttribute when member is obsolete.
13410 (AttributeTester.Report_ObsoleteMessage): Common method for
13411 Obsolete error/warning reporting.
13414 (TypeContainer.base_classs_type): New member for storing parent type.
13417 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
13418 for this MemberCore.
13420 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13422 * attribute.cs, const.cs: Fix bug #58590
13424 2004-05-21 Martin Baulig <martin@ximian.com>
13426 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
13427 out parameters if the end of the method is unreachable. Fixes
13430 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13432 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
13433 Hari was right, why extra method.
13435 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13437 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
13439 2004-05-20 Martin Baulig <martin@ximian.com>
13441 Merged this back from gmcs to keep the differences to a minumum.
13443 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
13444 instead of a Declspace.
13445 (Attribute.ResolveType): Likewise.
13446 (Attributes.Search): Likewise.
13447 (Attributes.Contains): Likewise.
13448 (Attributes.GetClsCompliantAttribute): Likewise.
13450 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
13452 (MethodData.ApplyAttributes): Take an EmitContext instead of a
13455 2004-05-19 Marek Safar <marek.safar@seznam.cz>
13457 Fix bug #58688 (MCS does not report error when the same attribute
13460 * attribute.cs (Attribute.Emit): Distinction between null and default.
13462 2004-05-19 Raja R Harinath <rharinath@novell.com>
13464 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
13465 of a top-level attribute without an attribute target.
13466 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
13468 (Attribute.Conditional_GetConditionName),
13469 (Attribute.Obsolete_GetObsoleteMessage): Update.
13470 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
13471 part of ScanForIndexerName.
13472 (Attribute.CanIgnoreInvalidAttribute): New function.
13473 (Attribute.ScanForIndexerName): Move to ...
13474 (Attributes.ScanForIndexerName): ... here.
13475 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
13476 (Attributes.Search): New internal variant that can choose not to
13477 complain if types aren't resolved. The original signature now
13479 (Attributes.GetClsCompliantAttribute): Use internal variant, with
13480 complaints suppressed.
13481 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
13482 only if it not useful.
13483 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
13484 top-level for attributes that are shared between the assembly
13485 and a top-level class.
13486 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
13487 * class.cs: Update to reflect changes.
13488 (DefineIndexers): Fuse loops.
13489 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
13490 a couple more variants of attribute names.
13492 2004-05-18 Marek Safar <marek.safar@seznam.cz>
13494 Fix bug #52585 (Implemented explicit attribute declaration)
13497 (Attributable.ValidAttributeTargets): New abstract method. It gets
13498 list of valid attribute targets for explicit target declaration.
13499 (Attribute.Target): It holds target itself.
13500 (AttributeSection): Removed.
13501 (Attribute.CheckTargets): New method. It checks whether attribute
13502 target is valid for the current element.
13505 (EventProperty): New class. For events that are declared like
13506 property (with add and remove accessors).
13507 (EventField): New class. For events that are declared like field.
13510 * cs-parser.jay: Implemented explicit attribute target declaration.
13512 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
13513 Override ValidAttributeTargets.
13516 (ReturnParameter): Class for applying custom attributes on
13518 (ParameterAtribute): New class. Class for applying custom
13519 attributes on the parameter type.
13521 2004-05-17 Miguel de Icaza <miguel@ximian.com>
13523 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
13526 (Method): Allow UNSAFE here.
13528 * modifiers.cs: Support unsafe reporting.
13530 2004-05-17 Marek Safar <marek.safar@seznam.cz>
13532 * decl.cs: Fix bug #58478.
13534 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13536 * statement.cs: When checking for unreachable code on an EmptyStatement,
13537 set the location. Fixes bug #58488.
13539 2004-05-13 Miguel de Icaza <miguel@ximian.com>
13541 * driver.cs: Add -pkg handling.
13543 From Gonzalo: UseShelLExecute=false
13545 2004-05-12 Marek Safar <marek.safar@seznam.cz>
13548 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
13550 (Attribute.IsClsCompliaceRequired): Moved to base for better
13552 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
13553 when attribute is AttributeUsageAttribute.
13554 (Attribute.GetValidTargets): Simplified.
13555 (Attribute.GetAttributeUsage): New method returns AttributeUsage
13556 attribute for this type.
13557 (Attribute.ApplyAttributes): Method renamed to Emit and make
13559 (GlobalAttributeSection): New class for special handling of global
13560 attributes (assembly, module).
13561 (AttributeSection.Emit): New method.
13563 * class.cs: Implemented Attributable abstract methods.
13564 (MethodCore.LabelParameters): Moved to Parameter class.
13565 (Accessor): Is back simple class.
13566 (PropertyMethod): Implemented Attributable abstract class.
13567 (DelegateMethod): Implemented Attributable abstract class.
13568 (Event): New constructor for disctintion between normal Event
13569 and Event with accessors.
13571 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
13573 * codegen.cs, const.cs, decl.cs, delegate.cs:
13574 (CommonAssemblyModulClass): Implemented Attributable abstract class
13577 * enum.cs: Implement IAttributeSupport interface.
13578 (EnumMember): New class for emum members. Implemented Attributable
13582 (ParameterBase): Is abstract.
13583 (ReturnParameter): New class for easier [return:] attribute handling.
13585 * typemanager.cs: Removed builder_to_attr.
13587 2004-05-11 Raja R Harinath <rharinath@novell.com>
13590 * attribute.cs (Attribute.GetPositionalValue): New function.
13591 * class.cs (TypeContainer.VerifyMembers): New function.
13592 (TypeContainer.Emit): Use it.
13593 (ClassOrStruct): New base class for Class and Struct.
13594 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
13595 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
13597 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
13598 then each non-static field should have a FieldOffset attribute.
13599 Otherwise, none of the fields should have a FieldOffset attribute.
13600 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
13601 and FieldOffset attributes.
13602 * typemanager.cs (TypeManager.struct_layout_attribute_type)
13603 (TypeManager.field_offset_attribute_type): New core types.
13604 (TypeManager.InitCoreTypes): Initialize them.
13606 2004-05-11 Michal Moskal <malekith@pld-linux.org>
13608 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
13609 Return correct type.
13612 2004-05-09 Miguel de Icaza <miguel@ximian.com>
13614 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
13615 be implicitly converted to ulong.
13617 * expression.cs: The logic for allowing operator &, | and ^ worked
13618 was wrong, it worked before because we did not report an error in
13619 an else branch. Fixes 57895.
13621 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
13622 allow volatile fields to be reference types.
13624 2004-05-07 Miguel de Icaza <miguel@ximian.com>
13626 * driver.cs: Add support for /debug-
13628 2004-05-07 Raja R Harinath <rharinath@novell.com>
13630 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
13631 Add a 'complain' parameter to silence errors.
13632 (Attribute.Resolve): Update to changes. Put in sanity check to catch
13633 silently overlooked type-resolutions.
13634 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
13635 to reflect changes.
13636 (Attributes.Search): New function.
13637 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
13638 (Attributes.GetAttributeFullName): Remove hack.
13639 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
13640 Update to reflect changes.
13641 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
13642 Use Attributes.Search instead of nested loops.
13644 2004-05-07 Marek Safar <marek.safar@seznam.cz>
13647 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
13648 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
13649 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
13651 * report.cs: (Report.Warning): Renamed to Warning_T because of
13652 parameter collision.
13654 2004-05-05 Raja R Harinath <rharinath@novell.com>
13656 * expression.cs (MemberAccess.ResolveMemberAccess):
13657 Exit with non-zero status after Report.Error.
13658 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
13660 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
13662 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13664 * support.cs: Don't hang when the file is empty.
13666 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13668 * support.cs: In SeekableStreamReader, compute the preamble size of the
13669 underlying stream. Position changes should take into account that initial
13672 2004-05-03 Todd Berman <tberman@sevenl.net>
13674 * driver.cs: remove unused GetSysVersion function.
13676 2004-05-03 Todd Berman <tberman@sevenl.net>
13678 * driver.cs: Remove the hack from saturday, as well as the hack
13679 from jackson (LoadAssemblyFromGac), also adds the CWD to the
13680 link_paths to get that bit proper.
13682 2004-05-01 Todd Berman <tberman@sevenl.net>
13684 * driver.cs: Try a LoadFrom before a Load, this checks the current
13685 path. This is currently a bug in mono that is be fixed, however, this
13686 provides a workaround for now. This will be removed when the bug
13689 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
13691 * CryptoConvert.cs: Updated to latest version. Fix issue with
13692 incomplete key pairs (#57941).
13694 2004-05-01 Todd Berman <tberman@sevenl.net>
13696 * driver.cs: Remove '.' from path_chars, now System.* loads properly
13699 2004-04-30 Jackson Harper <jackson@ximian.com>
13701 * codegen.cs: Open keys readonly.
13703 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13705 * typemanager.cs: don't report cyclic struct layout when a struct
13706 contains 2 or more fields of the same type. Failed for Pango.AttrShape
13707 which has 2 Pango.Rectangle fields.
13709 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
13711 * expression.cs: Handle IntPtr comparisons with IL code
13712 rather than a method call.
13714 2004-04-29 Martin Baulig <martin@ximian.com>
13716 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
13717 the list of PropertyInfo's in class hierarchy and find the
13718 accessor. Fixes #56013.
13720 2004-04-29 Martin Baulig <martin@ximian.com>
13722 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
13724 2004-04-29 Martin Baulig <martin@ximian.com>
13726 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13728 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
13730 2004-04-29 Martin Baulig <martin@ximian.com>
13732 * class.cs (ConstructorInitializer.Resolve): Check whether the
13733 parent .ctor is accessible. Fixes #52146.
13735 2004-04-29 Martin Baulig <martin@ximian.com>
13737 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13739 * statement.cs (Using.EmitLocalVariableDecls): Use
13740 TypeManager.idisposable_type, not typeof (IDisposable).
13741 (Foreach.EmitCollectionForeach): Added support for valuetypes.
13743 2004-04-29 Martin Baulig <martin@ximian.com>
13745 * class.cs (Event.Define): Don't emit the field and don't set
13746 RTSpecialName and SpecialName for events on interfaces. Fixes
13749 2004-04-29 Raja R Harinath <rharinath@novell.com>
13751 Refactor Attribute.ApplyAttributes.
13752 * attribute.cs (Attributable): New base class for objects that can
13753 have Attributes applied on them.
13754 (Attribute): Make AttributeUsage fields public.
13755 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
13756 (Attribute.IsInternalCall): New property.
13757 (Attribute.UsageAttr): Convert to a public read-only property.
13758 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
13759 (Attribute.ResolveType, Attribute.Resolve)
13760 (Attribute.ScanForIndexerName): Update to reflect changes.
13761 (Attribute.CheckAttributeTarget): Re-format.
13762 (Attribute.ApplyAttributes): Refactor, to various
13763 Attributable.ApplyAttributeBuilder methods.
13764 * decl.cs (MemberCore): Make Attributable.
13765 * class.cs (Accessor): Make Attributable.
13766 (MethodData.ApplyAttributes): Use proper attribute types, not
13768 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
13769 (TypeContainer.ApplyAttributeBuilder)
13770 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
13771 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
13772 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
13773 (Operator.ApplyAttributeBuilder): New factored-out methods.
13774 * const.cs (Const.ApplyAttributeBuilder): Likewise.
13775 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
13776 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
13777 * parameter.cs (ParameterBase): New Attributable base class
13778 that can also represent Return types.
13779 (Parameter): Update to the changes.
13781 2004-04-29 Jackson Harper <jackson@ximian.com>
13783 * driver.cs: Prefer the corlib system version when looking for
13784 assemblies in the GAC. This is still a hack, but its a better hack
13787 2004-04-29 Marek Safar <marek.safar@seznam.cz>
13789 * decl.cs, enum.cs: Improved error 3005 reporting.
13791 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
13792 (related_symbols): New private member for list of symbols
13793 related to reported error/warning.
13795 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
13797 2004-04-29 Martin Baulig <martin@ximian.com>
13799 * ecore.cs (Expression.Constantify): If we're an enum and
13800 TypeManager.TypeToCoreType() doesn't give us another type, use
13801 t.UnderlyingSystemType. Fixes #56178.
13803 2004-04-29 Martin Baulig <martin@ximian.com>
13805 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
13806 interfaces and for each interface, only add members directly
13807 declared in that interface. Fixes #53255.
13809 2004-04-28 Martin Baulig <martin@ximian.com>
13811 * expression.cs (ConditionalLogicalOperator): Use a temporary
13812 variable for `left' to avoid that we evaluate it more than once;
13815 2004-04-28 Martin Baulig <martin@ximian.com>
13817 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
13820 2004-04-28 Martin Baulig <martin@ximian.com>
13822 * statement.cs (LocalInfo.Resolve): Check whether the type is not
13825 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
13826 whether the type is not void (CS1547).
13828 2004-04-28 Martin Baulig <martin@ximian.com>
13830 * expression.cs (Unary.DoResolveLValue): Override this and report
13831 CS0131 for anything but Operator.Indirection.
13833 2004-04-28 Martin Baulig <martin@ximian.com>
13835 Committing a patch from Ben Maurer; see bug #50820.
13837 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13840 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13843 2004-04-28 Martin Baulig <martin@ximian.com>
13845 Committing a patch from Ben Maurer; see bug #50820.
13847 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13850 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13853 2004-04-28 Martin Baulig <martin@ximian.com>
13855 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
13856 (Block.AddLabel): Call DoLookupLabel() to only search in the
13859 2004-04-28 Martin Baulig <martin@ximian.com>
13861 * cfold.cs (ConstantFold.BinaryFold): Added special support for
13862 comparing StringConstants and NullLiterals in Equality and Inequality.
13864 2004-04-28 Jackson Harper <jackson@ximian.com>
13866 * driver.cs: Attempt to load referenced assemblies from the
13867 GAC. This is the quick and dirty version of this method that
13868 doesnt take into account versions and just takes the first
13869 canidate found. Will be good enough for now as we will not have more
13870 then one version installed into the GAC until I update this method.
13872 2004-04-28 Martin Baulig <martin@ximian.com>
13874 * typemanager.cs (TypeManager.CheckStructCycles): New public
13875 static method to check for cycles in the struct layout.
13877 * rootcontext.cs (RootContext.PopulateTypes): Call
13878 TypeManager.CheckStructCycles() for each TypeContainer.
13879 [Note: We only need to visit each type once.]
13881 2004-04-28 Martin Baulig <martin@ximian.com>
13883 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
13885 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
13886 success and added `out object value'. Use a `bool resolved' field
13887 to check whether we've already been called rather than
13888 `ConstantValue != null' since this breaks for NullLiterals.
13890 2004-04-28 Raja R Harinath <rharinath@novell.com>
13892 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
13893 setting of this flag, since the 'set' method may be non-public.
13895 2004-04-28 Raja R Harinath <rharinath@novell.com>
13897 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
13898 check on current_vector.Block.
13900 2004-04-27 Martin Baulig <martin@ximian.com>
13902 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
13903 a field initializer. Fixes #56459.
13905 2004-04-27 Martin Baulig <martin@ximian.com>
13907 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
13908 we're not attempting to use an indexer. Fixes #52154.
13910 2004-04-27 Martin Baulig <martin@ximian.com>
13912 * statement.cs (Return): Don't create a return label if we don't
13913 need it; reverts my change from January 20th. Thanks to Ben
13916 2004-04-27 Martin Baulig <martin@ximian.com>
13918 According to the spec, `goto' can only leave a nested scope, but
13921 * statement.cs (Block.LookupLabel): Only lookup in the current
13922 block, don't recurse into parent or child blocks.
13923 (Block.AddLabel): Check in parent and child blocks, report
13924 CS0140/CS0158 if we find a duplicate.
13925 (Block): Removed this indexer for label lookups.
13926 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
13927 this already does the error reporting for us.
13930 (FlowBranching.UsageVector.Block): New public variable; may be null.
13931 (FlowBranching.CreateSibling): Added `Block' argument.
13932 (FlowBranching.LookupLabel): New public virtual method. Lookup a
13933 label for the target of a `goto' and check whether we're not
13934 leaving a `finally'.
13936 2004-04-27 Martin Baulig <martin@ximian.com>
13938 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13939 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
13942 2004-04-27 Martin Baulig <martin@ximian.com>
13944 * statement.cs (Block.AddLabel): Also check for implicit blocks
13945 and added a CS0158 check.
13947 2004-04-27 Martin Baulig <martin@ximian.com>
13949 * flowanalysis.cs (FlowBranchingLoop): New class.
13950 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
13951 UsageVector's instead of an ArrayList.
13952 (FlowBranching.Label): Likewise.
13953 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
13954 (FlowBranching.AddBreakVector): New method.
13956 2004-04-27 Miguel de Icaza <miguel@ximian.com>
13958 * attribute.cs: Small regression fix: only convert the type if we
13959 the type is different, fixes System.Drawing build.
13961 2004-04-27 Martin Baulig <martin@ximian.com>
13963 * attribute.cs (Attribute.Resolve): If we have a constant value
13964 for a named field or property, implicity convert it to the correct
13967 2004-04-27 Raja R Harinath <rharinath@novell.com>
13969 * statement.cs (Block.Block): Implicit blocks share
13970 'child_variable_names' fields with parent blocks.
13971 (Block.AddChildVariableNames): Remove.
13972 (Block.AddVariable): Mark variable as "used by a child block" in
13973 every surrounding block.
13974 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
13975 been used in a child block, complain about violation of "Invariant
13976 meaning in blocks" rule.
13977 * cs-parser.jay (declare_local_variables): Don't use
13978 AddChildVariableNames.
13979 (foreach_statement): Don't create an implicit block: 'foreach'
13980 introduces a scope.
13982 2004-04-23 Miguel de Icaza <miguel@ximian.com>
13984 * convert.cs (ImplicitNumericConversion): 0 is also positive when
13985 converting from 0L to ulong. Fixes 57522.
13987 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13989 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
13990 derived class hides via 'new' keyword field from base class (test-242.cs).
13991 TODO: Handle this in the more general way.
13993 * class.cs (CheckBase): Ditto.
13995 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13997 * decl.cs (caching_flags): New member for storing cached values
13999 (MemberCore.Flags): New enum where bit flags for caching_flags
14001 (MemberCore.cls_compliance): Moved to caching_flags.
14002 (DeclSpace.Created): Moved to caching_flags.
14004 * class.cs: Use caching_flags instead of DeclSpace.Created
14006 2004-04-21 Miguel de Icaza <miguel@ximian.com>
14008 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
14009 if we are only a derived class, not a nested class.
14011 * typemanager.cs: Same as above, but do this at the MemberLookup
14012 level (used by field and methods, properties are handled in
14013 PropertyExpr). Allow for the qualified access if we are a nested
14016 2004-04-21 Marek Safar <marek.safar@seznam.cz>
14018 * class.cs: Refactoring.
14019 (IMethodData): New inteface; Holds links to parent members
14020 to avoid member duplication (reduced memory allocation).
14021 (Method): Implemented IMethodData interface.
14022 (PropertyBase): New inner classes for get/set methods.
14023 (PropertyBase.PropertyMethod): Implemented IMethodData interface
14024 (Event): New inner classes for add/remove methods.
14025 (Event.DelegateMethod): Implemented IMethodData interface.
14027 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
14028 EmitContext (related to class.cs refactoring).
14030 2004-04-21 Raja R Harinath <rharinath@novell.com>
14032 * delegate.cs (Delegate.VerifyApplicability): If the number of
14033 arguments are the same as the number of parameters, first try to
14034 verify applicability ignoring any 'params' modifier on the last
14038 2004-04-16 Raja R Harinath <rharinath@novell.com>
14040 * class.cs (TypeContainer.AddIndexer): Use
14041 'ExplicitInterfaceName' to determine if interface name was
14042 explicitly specified. 'InterfaceType' is not initialized at this time.
14043 (TypeContainer.DefineIndexers): Remove use of temporary list. The
14044 Indexers array is already in the required order. Initialize
14045 'IndexerName' only if there are normal indexers.
14046 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
14047 (TypeContainer.Emit): Emit DefaultMember attribute only if
14048 IndexerName is initialized.
14051 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
14053 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
14056 2004-04-15 Raja R Harinath <rharinath@novell.com>
14058 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
14062 * attribute.cs (Attribute.Resolve): Check for duplicate named
14066 2004-04-15 Miguel de Icaza <miguel@ximian.com>
14068 * iterators.cs (MarkYield): track whether we are in an exception,
14069 and generate code accordingly. Use a temporary value to store the
14070 result for our state.
14072 I had ignored a bit the interaction of try/catch with iterators
14073 since their behavior was not entirely obvious, but now it is
14074 possible to verify that our behavior is the same as MS .NET 2.0
14078 2004-04-14 Miguel de Icaza <miguel@ximian.com>
14080 * iterators.cs: Avoid creating temporaries if there is no work to
14083 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
14084 Enumerations, use TypeManager.EnumToUnderlying and call
14087 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
14090 (This.Emit): Use EmitContext.EmitThis to emit our
14093 (This.EmitAssign): Ditto.
14095 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
14096 codepaths, we will move all the functionality into
14099 (FieldExpr.EmitAssign): Ditto.
14101 This fixes several hidden bugs that I uncovered while doing a code
14102 review of this today.
14104 * codegen.cs (EmitThis): reworked so the semantics are more clear
14105 and also support value types "this" instances.
14107 * iterators.cs: Changed so that for iterators in value types, we
14108 do not pass the value type as a parameter.
14110 Initialization of the enumerator helpers is now done in the caller
14111 instead of passing the parameters to the constructors and having
14112 the constructor set the fields.
14114 The fields have now `assembly' visibility instead of private.
14116 2004-04-11 Miguel de Icaza <miguel@ximian.com>
14118 * expression.cs (Argument.Resolve): Check if fields passed as ref
14119 or out are contained in a MarshalByRefObject.
14121 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
14122 another compiler type.
14124 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
14126 * class.cs (Indexer.Define): use the new name checking method.
14127 Also, return false on an error.
14128 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
14129 (is_identifier_[start/part]_character): make static.
14131 2004-04-10 Miguel de Icaza <miguel@ximian.com>
14133 * expression.cs (Binary.ResolveOperator): Do no append strings
14134 twice: since we can be invoked more than once (array evaluation)
14135 on the same concatenation, take care of this here. Based on a fix
14136 from Ben (bug #56454)
14138 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
14140 * codegen.cs: Fix another case where CS1548 must be reported (when
14141 delay-sign isn't specified and no private is available #56564). Fix
14142 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
14143 error when MCS is used on the MS runtime and we need to delay-sign
14144 (which seems unsupported by AssemblyBuilder - see #56621).
14146 2004-04-08 Marek Safar <marek.safar@seznam.cz>
14148 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
14149 (TypeManager.ComputeNamespaces): Faster implementation for
14152 * compiler.csproj: Updated AssemblyName to mcs.
14154 2004-04-07 Miguel de Icaza <miguel@ximian.com>
14156 * rootcontext.cs: Add new types to the boot resolution.
14158 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
14159 MulticastDelegate is not allowed.
14161 * typemanager.cs: Add new types to lookup: System.TypedReference
14164 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
14165 check for TypedReference or ArgIterator, they are not allowed.
14167 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
14168 makes us properly catch 1510 in some conditions (see bug 56016 for
14171 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
14173 * CryptoConvert.cs: update from corlib version
14176 2004-04-05 Miguel de Icaza <miguel@ximian.com>
14178 * class.cs (Indexer.Define): Check indexername declaration
14180 2004-04-05 Marek Safar <marek.safar@seznam.cz>
14182 * attribute.cs (IsClsCompliant): Fixed problem with handling
14183 all three states (compliant, not-compliant, undetected).
14185 2004-03-30 Marek Safar <marek.safar@seznam.cz>
14187 * attribute.cs (Attribute): Location is now public.
14188 (Resolve): Store resolved arguments (pos_values) in attribute class.
14189 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
14190 (GetClsCompliantAttributeValue): New method that gets
14191 CLSCompliantAttribute value.
14192 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
14193 if exists else null.
14194 (AttributeTester): New class for CLS-Compliant verification routines.
14196 * class.cs (Emit): Add CLS-Compliant verification.
14197 (Method.GetSignatureForError): Implemented.
14198 (Constructor.GetSignatureForError): Implemented
14199 (Constructor.HasCompliantArgs): Returns if constructor has
14200 CLS-Compliant arguments.
14201 (Constructor.Emit): Override.
14202 (Construcor.IsIdentifierClsCompliant): New method; For constructors
14203 is needed to test only parameters.
14204 (FieldBase.GetSignatureForError): Implemented.
14205 (TypeContainer): New member for storing base interfaces.
14206 (TypeContainer.FindMembers): Search in base interfaces too.
14208 * codegen.cs (GetClsComplianceAttribute): New method that gets
14209 assembly or module CLSCompliantAttribute value.
14210 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
14212 (ModuleClass.Emit): Add error 3012 test.
14214 * const.cs (Emit): Override and call base for CLS-Compliant tests.
14216 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
14217 state for all decl types.
14218 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
14219 if CLS-Compliant tests are required.
14220 (IsClsCompliaceRequired): New method. Analyze whether code
14221 must be CLS-Compliant.
14222 (IsExposedFromAssembly): New method. Returns true when MemberCore
14223 is exposed from assembly.
14224 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
14225 value or gets cached value.
14226 (HasClsCompliantAttribute): New method. Returns true if MemberCore
14227 is explicitly marked with CLSCompliantAttribute.
14228 (IsIdentifierClsCompliant): New abstract method. This method is
14229 used to testing error 3005.
14230 (IsIdentifierAndParamClsCompliant): New method. Common helper method
14231 for identifier and parameters CLS-Compliant testing.
14232 (VerifyClsCompliance): New method. The main virtual method for
14233 CLS-Compliant verifications.
14234 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
14235 null. I don't know why is null (too many public members !).
14236 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
14237 and get value of first CLSCompliantAttribute that found.
14239 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
14240 (VerifyClsCompliance): Override and add extra tests.
14242 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
14243 clscheck- disable CLS-Compliant verification event if assembly is has
14244 CLSCompliantAttribute(true).
14246 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
14247 ApllyAttribute is now called in emit section as in the other cases.
14248 Possible future Emit integration.
14249 (IsIdentifierClsCompliant): New override.
14250 (VerifyClsCompliance): New override.
14251 (GetEnumeratorName): Returns full enum name.
14253 * parameter.cs (GetSignatureForError): Implemented.
14255 * report.cs (WarningData): New struct for Warning message information.
14256 (LocationOfPreviousError): New method.
14257 (Warning): New method. Reports warning based on the warning table.
14258 (Error_T): New method. Reports error based on the error table.
14260 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
14261 verifications are done here.
14263 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
14265 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
14266 CLSCompliantAttribute.
14267 (all_imported_types): New member holds all imported types from other
14269 (LoadAllImportedTypes): New method fills static table with exported types
14270 from all referenced assemblies.
14271 (Modules): New property returns all assembly modules.
14273 2004-03-30 Miguel de Icaza <miguel@ximian.com>
14275 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
14276 throwing a parser error.
14278 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
14279 which removes the hardcoded get_/set_ prefixes for properties, as
14280 IL allows for the properties to be named something else.
14284 * expression.cs: Do not override operand before we know if it is
14285 non-null. Fix 56207
14287 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
14289 * typemanager.cs: support for pinned variables.
14291 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
14293 * decl.cs, typemanager.cs: Avoid using an arraylist
14294 as a buffer if there is only one result set.
14296 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
14298 * expression.cs: Make sure you cant call a static method
14299 with an instance expression, bug #56174.
14301 2004-03-29 Miguel de Icaza <miguel@ximian.com>
14303 * class.cs (IsDuplicateImplementation): Improve error reporting to
14304 flag 663 (method only differs in parameter modifier).
14306 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
14307 in preprocessor directives.
14309 * location.cs (LookupFile): Allow for the empty path.
14311 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
14312 better approach for some of that patch, but its failing with the
14313 CharSet enumeration. For now try/catch will do.
14315 * typemanager.cs: Do not crash if a struct does not have fields.
14318 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14320 * expression.cs: cs0213, cant fix a fixed expression.
14323 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14325 * cs-parser.jay: detect invalid embeded statements gracefully.
14328 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14330 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
14333 the invocation type may not be a subclass of the tye of the item/
14334 The type of the item must be a subclass of the invocation item.
14339 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
14341 * attribute.cs: Added methods to get a string and a bool from an
14342 attribute. Required to information from AssemblyKeyFileAttribute,
14343 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
14344 * codegen.cs: Modified AssemblyName creation to include support for
14345 strongnames. Catch additional exceptions to report them as CS1548.
14346 * compiler.csproj: Updated include CryptoConvert.cs.
14347 * compiler.csproj.user: Removed file - user specific configuration.
14348 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
14349 Mono.Security assembly. The original class is maintained and tested in
14350 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
14351 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
14352 like CSC 8.0 (C# v2) supports.
14353 * Makefile: Added CryptoConvert.cs to mcs sources.
14354 * rootcontext.cs: Added new options for strongnames.
14356 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
14358 * driver.cs: For --expect-error, report error code `2'
14359 if the program compiled with no errors, error code `1' if
14360 it compiled with an error other than the one expected.
14362 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
14364 * compiler.csproj: Updated for Visual Studio .NET 2003.
14365 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
14366 * compiler.sln: Updated for Visual Studio .NET 2003.
14368 2004-03-24 Ravi Pratap M <ravi@ximian.com>
14370 * expression.cs: Fix bug #47234. We basically need to apply the
14371 rule that we prefer the conversion of null to a reference type
14372 when faced with a conversion to 'object' (csc behaviour).
14374 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14376 * statement.cs: Shorter form for foreach, eliminates
14377 a local variable. r=Martin.
14379 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14381 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
14382 checks if we can use brtrue/brfalse to test for 0.
14383 * expression.cs: use the above in the test for using brtrue/brfalse.
14384 cleanup code a bit.
14386 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14388 * expression.cs: Rewrite string concat stuff. Benefits:
14390 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
14391 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
14392 rather than a concat chain.
14394 * typemanager.cs: Add lookups for more concat overloads.
14396 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14398 * expression.cs: Emit shorter il code for array init.
14415 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
14417 * statement.cs: Before, two switch blocks would be merged if the
14418 total size of the blocks (end_item - begin_item + 1) was less than
14419 two times the combined sizes of the blocks.
14421 Now, it will only merge if after the merge at least half of the
14426 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
14428 * class.cs : csc build fix for GetMethods(). See bug #52503.
14430 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
14432 * expression.cs: Make sure fp comparisons work with NaN.
14433 This fixes bug #54303. Mig approved this patch a long
14434 time ago, but we were not able to test b/c the runtime
14437 2004-03-19 Miguel de Icaza <miguel@ximian.com>
14439 * ecore.cs (TypExpr.GetHashCode): implement this overload.
14441 2004-03-19 Martin Baulig <martin@ximian.com>
14443 * class.cs (MemberCore.IsDuplicateImplementation): Report the
14444 error here and not in our caller.
14446 2004-03-19 Martin Baulig <martin@ximian.com>
14448 * interface.cs: Completely killed this file.
14449 (Interface): We're now a TypeContainer and live in class.cs.
14451 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
14452 argument; we're now also called for interfaces.
14453 (TypeContainer.DefineMembers): Allow this method being called
14455 (TypeContainer.GetMethods): New public method; formerly known as
14456 Interface.GetMethod(). This is used by PendingImplementation.
14457 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
14458 it's now private and non-static.
14459 (Interface): Moved this here; it's now implemented similar to
14461 (Method, Property, Event, Indexer): Added `bool is_interface'
14462 argument to their .ctor's.
14463 (MemberBase.IsInterface): New public field.
14465 * cs-parser.jay: Create normal Method, Property, Event, Indexer
14466 instances instead of InterfaceMethod, InterfaceProperty, etc.
14467 (opt_interface_base): Removed; we now use `opt_class_base' instead.
14468 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
14470 2004-03-19 Martin Baulig <martin@ximian.com>
14472 * class.cs (MethodCore.IsDuplicateImplementation): New private
14473 method which does the CS0111 checking.
14474 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
14475 Use IsDuplicateImplementation().
14477 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
14479 * decl.cs (FindMemberToOverride): New method to find the correct
14480 method or property to override in the base class.
14482 - Make Method/Property use the above method to find the
14483 version in the base class.
14484 - Remove the InheritableMemberSignatureCompare as it is now
14487 This patch makes large code bases much faster to compile, as it is
14488 O(n) rather than O(n^2) to do this validation.
14490 Also, it fixes bug 52458 which is that nested classes are not
14491 taken into account when finding the base class member.
14493 Reviewed/Approved by Martin.
14495 2004-03-17 Marek Safar <marek.safar@seznam.cz>
14497 * interface.cs: In all interface classes removed redundant
14498 member initialization.
14500 2004-03-16 Martin Baulig <martin@ximian.com>
14502 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
14504 2004-03-15 Miguel de Icaza <miguel@ximian.com>
14506 * decl.cs (DefineTypeAndParents): New helper method to define a
14507 type's containers before the type itself is defined; This is a
14508 bug exposed by the recent changes to Windows.Forms when an
14509 implemented interface was defined inside a class that had not been
14512 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
14514 (Check): Loop correctly to report errors modifiers
14515 (UNSAFE was not in the loop, since it was the same as TOP).
14517 * interface.cs: Every interface member now takes a ModFlags,
14518 instead of a "is_new" bool, which we set on the base MemberCore.
14520 Every place where we called "UnsafeOk" in the interface, now we
14521 call the proper member (InterfaceMethod.UnsafeOK) instead to get
14522 the unsafe settings from the member declaration instead of the
14523 container interface.
14525 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
14527 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
14528 `set_indexer_name' to the pending bits (one per type).
14530 We fixed a bug today that was picking the wrong method to
14531 override, since for properties the existing InterfaceMethod code
14532 basically ignored the method name. Now we make sure that the
14533 method name is one of the valid indexer names.
14535 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
14537 * support.cs (SeekableStreamReader): Keep track of stream byte
14538 positions and don't mix them with character offsets to the buffer.
14540 Patch from Gustavo Giráldez
14542 2004-03-15 Marek Safar <marek.safar@seznam.cz>
14544 * interface.cs (InterfaceSetGetBase): Removed double member
14545 initialization, base class does it as well.
14547 2004-03-13 Martin Baulig <martin@ximian.com>
14549 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
14550 when compiling corlib.
14552 2004-03-13 Miguel de Icaza <miguel@ximian.com>
14554 * convert.cs (ExplicitConversion): We were reporting an error on
14555 certain conversions (object_type source to a value type, when the
14556 expression was `null') before we had a chance to pass it through
14557 the user defined conversions.
14559 * driver.cs: Replace / and \ in resource specifications to dots.
14562 * class.cs: Add check for duplicate operators. Fixes 52477
14564 2004-03-11 Miguel de Icaza <miguel@ximian.com>
14566 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
14567 that are in the middle of the statements, not only at the end.
14570 * class.cs (TypeContainer.AddField): No longer set the
14571 `HaveStaticConstructor' flag, now we call it
14572 `UserDefineStaticConstructor' to diferentiate the slightly
14573 semantic difference.
14575 The situation is that we were not adding BeforeFieldInit (from
14576 Modifiers.TypeAttr) to classes that could have it.
14577 BeforeFieldInit should be set to classes that have no static
14582 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
14584 And most importantly Zoltan's comment:
14586 http://bugzilla.ximian.com/show_bug.cgi?id=44229
14588 "I think beforefieldinit means 'it's ok to initialize the type sometime
14589 before its static fields are used', i.e. initialization does not need
14590 to be triggered by the first access to the type. Setting this flag
14591 helps the JIT to compile better code, since it can run the static
14592 constructor at JIT time, and does not need to generate code to call it
14593 (possibly lots of times) at runtime. Unfortunately, mcs does not set
14594 this flag for lots of classes like String.
14596 csc sets this flag if the type does not have an explicit static
14597 constructor. The reasoning seems to be that if there are only static
14598 initalizers for a type, and no static constructor, then the programmer
14599 does not care when this initialization happens, so beforefieldinit
14602 This bug prevents the AOT compiler from being usable, since it
14603 generates so many calls to mono_runtime_class_init that the AOT code
14604 is much slower than the JITted code. The JITted code is faster,
14605 because it does not generate these calls if the vtable is type is
14606 already initialized, which is true in the majority of cases. But the
14607 AOT compiler can't do this."
14609 2004-03-10 Miguel de Icaza <miguel@ximian.com>
14611 * class.cs (MethodData.Emit): Refactor the code so symbolic
14612 information is generated for destructors; For some reasons we
14613 were taking a code path that did not generate symbolic information
14616 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
14618 * class.cs: Create a Constructor.CheckBase method that
14619 takes care of all validation type code. The method
14620 contains some code that was moved from Define.
14622 It also includes new code that checks for duplicate ctors.
14623 This fixes bug #55148.
14625 2004-03-09 Joshua Tauberer <tauberer@for.net>
14627 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
14628 a { ... }-style array creation invokes EmitStaticInitializers
14629 which is not good for reference-type arrays. String, decimal
14630 and now null constants (NullCast) are not counted toward
14631 static initializers.
14633 2004-03-05 Martin Baulig <martin@ximian.com>
14635 * location.cs (SourceFile.HasLineDirective): New public field;
14636 specifies whether the file contains or is referenced by a "#line"
14638 (Location.DefineSymbolDocuments): Ignore source files which
14639 either contain or are referenced by a "#line" directive.
14641 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
14643 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
14644 direct access to our parent, so check the method inline there.
14646 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
14648 * expression.cs (Invocation.EmitCall): Miguel's last commit
14649 caused a regression. If you had:
14654 In Foo the implict this would be null.
14656 2004-02-27 Miguel de Icaza <miguel@ximian.com>
14658 * expression.cs (Invocation.EmitCall): If the method is not
14659 virtual, do not emit a CallVirt to it, use Call.
14661 * typemanager.cs (GetFullNameSignature): Improve the method to
14662 cope with ".ctor" and replace it with the type name.
14664 * class.cs (ConstructorInitializer.Resolve): Now the method takes
14665 as an argument the ConstructorBuilder where it is being defined,
14666 to catch the recursive constructor invocations.
14668 2004-02-26 Miguel de Icaza <miguel@ximian.com>
14670 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
14671 routines to check if a type is an enumerable/enumerator allow
14672 classes that implement the IEnumerable or IEnumerator interfaces.
14674 * class.cs (Property, Operator): Implement IIteratorContainer, and
14675 implement SetYields.
14677 (Property.Define): Do the block swapping for get_methods in the
14678 context of iterators. We need to check if Properties also
14679 include indexers or not.
14681 (Operator): Assign the Block before invoking the
14682 OperatorMethod.Define, so we can trigger the Iterator code
14685 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
14686 Property and Operator classes are not created when we parse the
14687 declarator but until we have the block completed, so we use a
14688 singleton SimpleIteratorContainer.Simple to flag whether the
14689 SetYields has been invoked.
14691 We propagate this setting then to the Property or the Operator to
14692 allow the `yield' to function.
14694 2004-02-25 Marek Safar <marek.safar@seznam.cz>
14696 * codegen.cs: Implemented attribute support for modules.
14697 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
14698 Assembly/Module functionality.
14700 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
14701 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
14702 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
14704 2004-02-16 Marek Safar <marek.safar@seznam.cz>
14706 * interface.cs (FindMembers): The operation is performed on all base
14707 interfaces and not only on the first. It is required for future CLS Compliance patch.
14709 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
14711 * statement.cs, codegen.cs:
14712 This patch deals with patterns such as:
14714 public class List : IEnumerable {
14716 public MyEnumerator GetEnumerator () {
14717 return new MyEnumerator(this);
14720 IEnumerator IEnumerable.GetEnumerator () {
14724 public struct MyEnumerator : IEnumerator {
14729 Before, there were a few things we did wrong:
14730 1) we would emit callvirt on a struct, which is illegal
14731 2) we emited ldarg when we needed to emit ldarga
14732 3) we would mistakenly call the interface methods on an enumerator
14733 type that derived from IEnumerator and was in another assembly. For example:
14735 public class MyEnumerator : IEnumerator
14737 Would have the interface methods called, even if there were public impls of the
14738 method. In a struct, this lead to invalid IL code.
14740 2004-02-11 Marek Safar <marek.safar@seznam.cz>
14742 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
14745 * delegate.cs (Define): Fixed crash when delegate type is undefined.
14747 2004-02-11 Miguel de Icaza <miguel@ximian.com>
14749 * cs-parser.jay: Fix small regression: we were not testing V2
14750 compiler features correctly.
14752 * interface.cs: If the emit context is null, then create one
14754 2004-02-09 Marek Safar <marek.safar@seznam.cz>
14756 * decl.cs (GetSignatureForError): New virtual method to get full name
14757 for error messages.
14759 * attribute.cs (IAttributeSupport): New interface for attribute setting.
14760 Now it is possible to rewrite ApplyAttributes method to be less if/else.
14762 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
14763 Duplicated members and code in these classes has been removed.
14764 Better encapsulation in these classes.
14766 2004-02-07 Miguel de Icaza <miguel@ximian.com>
14768 * assign.cs (Assign.DoResolve): When dealing with compound
14769 assignments, there is a new rule in ECMA C# 2.4 (might have been
14770 there before, but it is documented here) that states that in:
14774 If b is of type int, and the `op' is a shift-operator, then the
14775 above is evaluated as:
14779 * expression.cs (Binary.ResolveOperator): Instead of testing for
14780 int/uint/long/ulong, try to implicitly convert to any of those
14781 types and use that in pointer arithmetic.
14783 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
14784 method to print information for from the type, not from the
14785 null-method we were given.
14787 2004-02-01 Duncan Mak <duncan@ximian.com>
14789 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
14790 parsing for cmd, fixes bug #53694.
14792 2004-02-04 Marek Safar <marek.safar@seznam.cz>
14794 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
14795 in the member name duplication tests. Property and operator name duplication
14796 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
14798 2004-02-03 Marek Safar <marek.safar@seznam.cz>
14800 * interface.cs (PopulateMethod): Fixed crash when interface method
14801 returns not existing type (error test cs0246-3.cs).
14803 2004-02-02 Ravi Pratap M <ravi@ximian.com>
14805 * cs-parser.jay (interface_accessors): Re-write actions to also
14806 store attributes attached to get and set methods. Fix spelling
14809 (inteface_property_declaration): Modify accordingly.
14811 (InterfaceAccessorInfo): New helper class to store information to pass
14812 around between rules that use interface_accessors.
14814 * interface.cs (Emit): Apply attributes on the get and set
14815 accessors of properties and indexers too.
14817 * attribute.cs (ApplyAttributes): Modify accordingly to use the
14818 right MethodBuilder when applying attributes to the get and set accessors.
14820 2004-01-31 Miguel de Icaza <miguel@ximian.com>
14822 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
14824 2004-01-26 Miguel de Icaza <miguel@ximian.com>
14826 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
14828 2004-01-25 Miguel de Icaza <miguel@ximian.com>
14830 * cs-parser.jay: Remove YIELD token, instead use the new grammar
14831 changes that treat `yield' specially when present before `break'
14832 or `return' tokens.
14834 * cs-tokenizer.cs: yield is no longer a keyword.
14836 2004-01-23 Marek Safar <marek.safar@seznam.cz>
14838 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
14839 setting for default constructors.
14840 For default constructors are almost every time set wrong Modifier. The
14841 generated IL code has been alright. But inside mcs this values was
14842 wrong and this was reason why several of my CLS Compliance tests
14845 2004-01-22 Martin Baulig <martin@ximian.com>
14847 * cs-parser.jay (namespace_or_type_name): Return an Expression,
14848 not a QualifiedIdentifier. This is what `type_name_expression'
14849 was previously doing.
14850 (type_name_expression): Removed; the code is now in
14851 `namespace_or_type_name'.
14852 (qualified_identifier): Removed, use `namespace_or_type_name'
14854 (QualifiedIdentifier): Removed this class.
14856 2004-01-22 Martin Baulig <martin@ximian.com>
14858 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
14859 not a string as alias name.
14861 2004-01-21 Miguel de Icaza <miguel@ximian.com>
14863 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
14864 #52730 bug, and instead compute correctly the need to use a
14865 temporary variable when requesting an address based on the
14866 static/instace modified of the field and the constructor.
14868 2004-01-21 Martin Baulig <martin@ximian.com>
14870 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
14871 class and namespace before looking up aliases. Fixes #52517.
14873 2004-01-21 Martin Baulig <martin@ximian.com>
14875 * flowanalysis.cs (UsageVector.Merge): Allow variables being
14876 assinged in a 'try'; fixes exception4.cs.
14878 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14879 * class.cs : Implemented parameter-less constructor for TypeContainer
14881 * decl.cs: Attributes are now stored here. New property OptAttributes
14883 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
14885 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
14887 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14889 * typemanager.cs (CSharpSignature): Now reports also inner class name.
14890 (CSharpSignature): New method for indexer and property signature.
14892 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14894 * pending.cs (IsVirtualFilter): Faster implementation.
14896 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14898 * typemanager.cs: Avoid inclusion of same assembly more than once.
14900 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14902 * cs-parser.jay: Fixed problem where the last assembly attribute
14903 has been applied also to following declaration (class, struct, etc.)
14905 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14907 * class.cs: Added error CS0538, CS0539 reporting.
14908 Fixed crash on Microsoft runtime when field type is void.
14910 * cs-parser.jay: Added error CS0537 reporting.
14912 * pending.cs: Added error CS0535 reporting.
14913 Improved error report for errors CS0536, CS0534.
14915 2004-01-20 Miguel de Icaza <miguel@ximian.com>
14917 Merge a few bits from the Anonymous Method MCS tree.
14919 * statement.cs (ToplevelBlock): New class for toplevel methods,
14920 will hold anonymous methods, lifted variables.
14922 * cs-parser.jay: Create toplevel blocks for delegates and for
14923 regular blocks of code.
14925 2004-01-20 Martin Baulig <martin@ximian.com>
14927 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
14928 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
14929 and `NeedExplicitReturn'; added `IsLastStatement'.
14930 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
14931 have a `ReturnLabel' or we're not unreachable.
14933 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
14934 child's reachability; don't just override ours with it. Fixes
14935 #58058 (lluis's example).
14936 (FlowBranching): Added public InTryOrCatch(), InCatch(),
14937 InFinally(), InLoop(), InSwitch() and
14938 BreakCrossesTryCatchBoundary() methods.
14940 * statement.cs (Return): Do all error checking in Resolve().
14941 Unless we are the last statement in a top-level block, always
14942 create a return label and jump to it.
14943 (Break, Continue): Do all error checking in Resolve(); also make
14944 sure we aren't leaving a `finally'.
14945 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
14946 statement in a top-level block.
14947 (Block.Flags): Added `IsDestructor'.
14948 (Block.IsDestructor): New public property.
14950 2004-01-20 Martin Baulig <martin@ximian.com>
14952 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
14954 2004-01-20 Martin Baulig <martin@ximian.com>
14956 * statement.cs (Statement.ResolveUnreachable): New public method.
14957 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
14958 (Block.Resolve): Resolve unreachable statements.
14960 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14962 * expression.cs: We need to fix the case where we do
14963 not have a temp variable here.
14965 * assign.cs: Only expression compound assignments need
14966 temporary variables.
14968 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14970 * flowanalysis.cs: Reduce memory allocation in a few ways:
14971 - A block with no variables should not allocate a bit
14973 - A method with no out parameters does not need any tracking
14974 for assignment of the parameters, so we need not allocate
14977 public readonly Type[] VariableTypes;
14978 public readonly string[] VariableNames;
14979 Are redundant. The data is already stored in the variable
14980 map, so we need not allocate another array for it.
14981 - We need to add alot of checks for if (params | locals) == null
14982 due to the first two changes.
14984 2004-01-18 Miguel de Icaza <miguel@ximian.com>
14986 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
14987 implement IMemoryLocation, we store a copy on a local variable and
14988 take the address of it. Patch from Benjamin Jemlich
14990 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
14991 to use a special "type_name_expression" rule which reduces the
14992 number of "QualifiedIdentifier" classes created, and instead
14993 directly creates MemberAccess expressions.
14995 2004-01-17 Miguel de Icaza <miguel@ximian.com>
14997 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
14998 that fixes #52853. Null literal assignment to ValueType
15000 * class.cs (MethodData.Emit): Instead of checking the name of the
15001 method to determine if its a destructor, create a new derived
15002 class from Method called Destructor, and test for that.
15004 * cs-parser.jay: Create a Destructor object instead of a Method.
15006 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
15010 2004-01-16 Miguel de Icaza <miguel@ximian.com>
15012 * expression.cs (Binary.ResolveOperator): Perform an implicit
15013 conversion from MethodGroups to their delegate types on the
15014 Addition operation.
15016 * delegate.cs: Introduce a new class DelegateCreation that is the
15017 base class for `NewDelegate' and `ImplicitDelegateCreation',
15018 factor some code in here.
15020 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
15021 conversion from MethodGroups to compatible delegate types.
15023 * ecore.cs (Expression.Resolve): Do not flag error 654
15024 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
15025 we allow conversions from MethodGroups to delegate types now.
15027 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
15028 assignments in v2 either.
15030 2004-01-10 Miguel de Icaza <miguel@ximian.com>
15032 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
15033 static read-only fields in ctors.
15035 Applied patch from Benjamin Jemlich
15037 * expression.cs (UnaryMutator): Avoid leaking local variables.
15039 2004-01-09 Miguel de Icaza <miguel@ximian.com>
15041 * cs-tokenizer.cs (IsCastToken): Allow the various native types
15042 here to return true, as they can be used like this:
15044 (XXX) int.MEMBER ()
15046 Fixed 49836 and all the other dups
15048 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
15050 * driver.cs: Implement /win32res and /win32icon.
15052 2004-01-08 Miguel de Icaza <miguel@ximian.com>
15054 * cs-parser.jay: Add a rule to improve error handling for the
15055 common mistake of placing modifiers after the type.
15057 2004-01-07 Miguel de Icaza <miguel@ximian.com>
15059 * cs-parser.jay (interface_event_declaration): Catch
15060 initialization of events on interfaces, and report cs0068
15062 * cs-parser.jay (interface_event_declaration): Catch
15063 initialization of events.
15065 * ecore.cs: Better report missing constructors.
15067 * expression.cs (Binary.ResolveOperator): My previous bug fix had
15068 the error reporting done in the wrong place. Fix.
15070 * expression.cs (Binary.ResolveOperator): Catch the
15071 operator + (E x, E y) error earlier, and later allow for implicit
15072 conversions in operator +/- (E e, U x) from U to the underlying
15075 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
15076 52596, if the container class is abstract, the default constructor
15077 is protected otherwise its public (before, we were always public).
15079 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
15082 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
15083 Jemlich that fixes bug #52597, MCS was generating invalid code for
15084 idisposable structs. Thanks to Ben for following up with this
15087 2004-01-06 Miguel de Icaza <miguel@ximian.com>
15089 * driver.cs: Allow assemblies without code to be generated, fixes
15092 2004-01-07 Nick Drochak <ndrochak@gol.com>
15094 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
15096 2004-01-05 Miguel de Icaza <miguel@ximian.com>
15098 * cs-parser.jay: Add rules to improve error reporting if fields or
15099 methods are declared at the namespace level (error 116)
15101 * Add rules to catch event add/remove
15103 2004-01-04 David Sheldon <dave-mono@earth.li>
15105 * expression.cs: Added matching ")" to error message for
15108 2004-01-03 Todd Berman <tberman@gentoo.org>
15110 * ecore.cs, attribute.cs:
15111 Applying fix from #52429.
15113 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15115 * ecore.cs, expression.cs, statement.cs:
15116 Total rewrite of how we handle branching. We
15117 now handle complex boolean expressions with fewer
15118 jumps. As well if (x == 0) no longer emits a ceq.
15120 if (x is Foo) is much faster now, because we generate
15123 Overall, we get a pretty big improvement on our benchmark
15124 tests. The code we generate is smaller and more readable.
15126 I did a full two-stage bootstrap. The patch was reviewed
15127 by Martin and Miguel.
15129 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15131 * cs-parser.jay: Make primary_expression not take a QI.
15132 we dont need this because the member_access rule covers
15133 us here. So we replace the rule with just IDENTIFIER.
15135 This has two good effects. First, we remove a s/r conflict.
15136 Second, we allocate many fewer QualifiedIdentifier objects.
15138 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15140 * attribute.cs: Handle MarshalAs attributes as pseudo, and
15141 set the correct information via SRE. This prevents
15142 hanging on the MS runtime. Fixes #29374.
15144 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15146 * convert.cs: correctly handle conversions to value types
15147 from Enum and ValueType as unboxing conversions.
15149 Fixes bug #52569. Patch by Benjamin Jemlich.
15151 2004-01-02 Ravi Pratap <ravi@ximian.com>
15153 * expression.cs (BetterConversion): Prefer int -> uint
15154 over int -> ulong (csc's behaviour). This fixed bug #52046.
15156 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
15158 * decl.cs (MemberCache.FindMembers): now returns a
15161 * typemanager.cs: In general, go with with ^^.
15162 (CopyNewMethods): take an IList.
15163 (RealMemberLookup): Only allocate an arraylist
15164 if we copy from two sets of methods.
15166 This change basically does two things:
15167 1) Fewer array lists allocated due to CopyNewMethods.
15168 2) the explicit cast in MemberList costed ALOT.
15170 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
15172 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
15173 a hashtable to avoid needless string allocations when an identifier is
15174 used more than once (the common case).
15176 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
15178 * pending.cs: MS's TypeBuilder.GetInterfaces ()
15179 is broken, it will not return anything. So, we
15180 have to use the information we have in mcs to
15183 * typemanager.cs: Add a cache for GetInterfaces,
15184 since this will now be used more often (due to ^^)
15186 (GetExplicitInterfaces) New method that gets the
15187 declared, not effective, interfaces on a type
15188 builder (eg, if you have interface IFoo, interface
15189 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
15192 This patch makes MCS able to bootstrap itself on
15195 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
15197 * expression.cs: Remove the Nop's that Miguel put
15200 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15202 * report.cs, codegen.cs: Give the real stack trace to
15203 the error when an exception is thrown.
15205 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15207 * decl.cs: only allocate hashtables for ifaces if
15210 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15212 * expression.cs: fix the error from cs0121-2.cs
15213 (a parent interface has two child interfaces that
15214 have a function with the same name and 0 params
15215 and the function is called through the parent).
15217 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
15219 * class.cs, rootcontext.cs, typmanager.cs: do not
15222 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
15224 * codegen.cs: remove stack for the ec flow branching.
15225 It is already a linked list, so no need.
15227 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
15229 * Makefile: Allow custom profiler here.
15231 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
15233 * typemanager.cs (LookupType):
15234 - Use a static char [], because split takes
15235 a param array for args, so it was allocating
15237 - Do not store true in a hashtable, it boxes.
15239 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
15241 * flowanalysis.cs: bytify common enums.
15243 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
15245 * modifiers.cs: Add a new set of flags for the
15246 flags allowed on explicit interface impls.
15247 * cs-parser.jay: catch the use of modifiers in
15248 interfaces correctly.
15249 * class.cs: catch private void IFoo.Blah ().
15251 All related to bug #50572.
15253 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
15255 * decl.cs: Rewrite the consistant accessability checking.
15256 Accessability is not linear, it must be implemented in
15257 a tableish way. Fixes #49704.
15259 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
15261 * expression.cs: Handle negation in a checked context.
15262 We must use subtraction from zero. Fixes #38674.
15264 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
15266 * class.cs: Ignore static void main in DLLs.
15267 * rootcontext.cs: Handle the target type here,
15268 since we are have to access it from class.cs
15269 * driver.cs: account for the above.
15271 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
15273 * report.cs: Give line numbers and files if available.
15275 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
15277 * driver.cs: Implement /addmodule.
15279 * typemanager.cs: Change 'modules' field so it now contains Modules not
15282 2003-12-20 Martin Baulig <martin@ximian.com>
15284 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
15285 (FieldBase.IsAssigned): Removed this field.
15286 (FieldBase.SetAssigned): New public method.
15287 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
15289 2003-12-20 Martin Baulig <martin@ximian.com>
15291 * expression.cs (LocalVariableReference.DoResolve): Don't set
15292 `vi.Used' if we're called from DoResolveLValue().
15294 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
15295 returns the usage vector it just merged into the current one -
15296 pass this one to UsageWarning().
15297 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
15298 of the `EmitContext', don't call this recursively on our children.
15300 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
15302 * driver.cs: Implement /target:module.
15304 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
15306 * support.cs (CharArrayHashtable): New helper class.
15308 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
15309 char arrays, not strings, so we can avoid creating a string in
15310 consume_identifier if the identifier is a keyword.
15312 2003-12-16 Martin Baulig <martin@ximian.com>
15314 * statement.cs (LocalInfo.Assigned): Removed this property.
15315 (LocalInfo.Flags): Removed `Assigned'.
15316 (LocalInfo.IsAssigned): New public method; takes the EmitContext
15317 and uses flow analysis.
15318 (Block.UsageWarning): Made this method private.
15319 (Block.Resolve): Call UsageWarning() if appropriate.
15321 * expression.cs (LocalVariableReference.DoResolve): Always set
15322 LocalInfo.Used here.
15324 2003-12-13 Martin Baulig <martin@ximian.com>
15326 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
15327 any value here; we're now using flow analysis to figure out
15328 whether a statement/block returns a value.
15330 2003-12-13 Martin Baulig <martin@ximian.com>
15332 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
15334 (FlowBranching.MergeFinally): Don't call
15335 `branching.CheckOutParameters()' here, this is called in
15337 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
15338 when adding the `finally' vector.
15340 2003-12-13 Martin Baulig <martin@ximian.com>
15343 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
15344 actually work and also fix #48962.
15346 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
15348 * decl.cs: Do not check System.Object for nested types,
15349 since we know it does not have any. Big bang for buck:
15352 Run 1: 8.35 seconds
15353 Run 2: 8.32 seconds
15354 corlib: 17.99 seconds
15356 Run 1: 8.17 seconds
15357 Run 2: 8.17 seconds
15358 corlib: 17.39 seconds
15360 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
15362 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
15363 time we are returning 0 members, so we save alot here.
15365 2003-12-11 Martin Baulig <martin@ximian.com>
15367 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
15368 `MergeChild()', also just take the `FlowBranching' as argument;
15369 call Merge() on it and return the result.
15370 (FlowBranching.Merge): We don't need to do anything if we just
15373 2003-12-11 Martin Baulig <martin@ximian.com>
15375 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
15376 them in an `ArrayList' to reduce memory usage. Thanks to Ben
15377 Maurer for this idea.
15379 2003-12-11 Martin Baulig <martin@ximian.com>
15381 * flowanalysis.cs (MergeResult): This class is now gone; we now
15382 use the `UsageVector' for this. The reason for this is that if a
15383 branching just has one sibling, we don't need to "merge" them at
15384 all - that's the next step to do.
15385 (FlowBranching.Merge): We now return a `UsageVector' instead of a
15388 2003-12-11 Martin Baulig <martin@ximian.com>
15390 Reworked flow analyis and made it more precise and bug-free. The
15391 most important change is that we're now using a special `Reachability'
15392 class instead of having "magic" meanings of `FlowReturns'. I'll
15393 do some more cleanups and optimizations and also add some more
15394 documentation this week.
15396 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
15397 largely reworked this class.
15398 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
15399 the new `Reachability' class instead of having "magic" values here.
15400 (FlowBranching): We're now using an instance of `Reachability'
15401 instead of having separate `Returns', `Breaks' etc. fields.
15403 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
15404 based on flow analysis; ignore the return value of block.Emit ().
15406 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
15408 * driver.cs typemanager.cs: Find the mono extensions to corlib even
15409 if they are private.
15411 2003-12-09 Martin Baulig <martin@ximian.com>
15413 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
15414 call them directly on the UsageVector.
15416 2003-12-09 Martin Baulig <martin@ximian.com>
15418 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
15419 Changed return type from `FlowReturns' to `Reachability'.
15421 2003-12-09 Martin Baulig <martin@ximian.com>
15423 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
15424 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
15425 `Reachable' fields with a single `Reachability' one.
15427 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15429 * class.cs (FindMembers): Remove foreach's.
15434 Run 1: 8.74 seconds
15435 Run 2: 8.71 seconds
15438 Run 1: 8.64 seconds
15439 Run 2: 8.58 seconds
15442 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15447 This patch does a few things:
15448 1. EmptyStatement is now a singleton, so it is never reallocated.
15449 2. All blah is EmptyStatement constructs have been changed to
15450 blah == EmptyStatement.Value, which is much faster and valid
15451 now that EmptyStatement is a singleton.
15452 3. When resolving a block, rather than allocating a new array for
15453 the non-empty statements, empty statements are replaced with
15454 EmptyStatement.Value
15455 4. Some recursive functions have been made non-recursive.
15456 Mainly the performance impact is from (3), however (1) and (2) are needed for
15457 this to work. (4) does not make a big difference in normal situations, however
15458 it makes the profile look saner.
15463 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15464 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15465 Total memory allocated: 56397 KB
15468 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
15469 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
15470 Total memory allocated: 55666 KB
15472 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15474 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
15475 than the hashtable in a hashtable version
15477 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
15478 we always end up concating a string. This results in a huge perf
15479 loss, because many strings have to be tracked by the GC. In this
15480 patch, we first use a hashtable that works with two keys, so that
15481 the strings do not need to be concat'ed.
15485 Run 1: 8.74 seconds
15486 Run 2: 8.71 seconds
15489 Run 1: 8.65 seconds
15490 Run 2: 8.56 seconds
15492 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15494 * Makefile: Add a new target `do-time' that does a quick and simple
15495 profile, leaving easy to parse output.
15497 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
15499 * codegen.cs (Init): Create the dynamic assembly with
15500 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
15502 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
15504 * support.cs: Make the PtrHashtable use only one
15505 instance of its comparer.
15507 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
15509 * typemanager.cs: Fix lookup of GetNamespaces.
15511 2003-11-29 Miguel de Icaza <miguel@ximian.com>
15513 * expression.cs: Removed redundant line.
15515 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
15516 ArrayLists, use for loops with bounds.
15518 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
15521 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
15522 arraylists, use for loop with bounds.
15524 The above three changes give us a 0.071 second performance
15525 improvement out of 3.294 seconds down to 3.223. On my machine
15526 the above changes reduced the memory usage by 1,387 KB during
15527 compiler bootstrap.
15529 * cs-parser.jay (QualifiedIdentifier): New class used to represent
15530 QualifiedIdentifiers. Before we created a new string through
15531 concatenation, and mostly later on, the result would be
15532 manipulated by DecomposeQI through string manipulation.
15534 This reduced the compiler memory usage for bootstrapping from
15535 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
15536 compile times in 0.05 seconds.
15538 2003-11-28 Dick Porter <dick@ximian.com>
15540 * support.cs: Do string compares with the Invariant culture.
15548 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
15549 the comparison is done with the Invariant culture.
15551 2003-11-27 Miguel de Icaza <miguel@ximian.com>
15553 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
15554 GetEnumerator method.
15556 (ProbeCollectionType): Iterate starting at the most specific type
15557 upwards looking for a GetEnumerator
15559 * expression.cs: Shift count can be up to 31 for int/uint and 63
15562 2003-11-26 Miguel de Icaza <miguel@ximian.com>
15564 * statement.cs (Block.LookupLabel): Also look for the label on the
15565 children blocks. Use a hash table to keep track of visited
15568 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
15569 we actually did transform the other operand, otherwise fall back
15570 to the common codepath that casts to long.
15572 * cs-tokenizer.cs: Use the same code pattern as the int case.
15573 Maybe I should do the parsing myself, and avoid depending on the
15574 Parse routines to get this done.
15576 2003-11-25 Miguel de Icaza <miguel@ximian.com>
15578 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15579 which fixes bug 51347. This time test it.
15581 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
15582 attributes for example can not tell the difference between these.
15583 The difference was only a syntax feature of the language.
15585 * attribute.cs: Apply attributes to delegates.
15587 * delegate.cs: Call the apply attributes method.
15589 2003-11-24 Miguel de Icaza <miguel@ximian.com>
15591 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
15592 comparing 0 vs Byte.MinValue, not the value
15594 (ImplicitConversionRequired): When reporting a conversion error,
15595 use error 31 to print out the constant error instead of the
15598 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15599 which fixes bug 51347.
15601 2003-11-22 Miguel de Icaza <miguel@ximian.com>
15603 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
15604 which fixes the -warnaserror command line option.
15606 2003-11-21 Miguel de Icaza <miguel@ximian.com>
15608 * cfold.cs (DoNumericPromotions): During constant folding of
15609 additions on UIntConstant, special case intconstants with
15610 IntConstants like we do on the expression binary operator.
15612 2003-11-12 Miguel de Icaza <miguel@ximian.com>
15614 * convert.cs (ImplicitReferenceConversion): We were missing a case
15615 (System.Enum are not value types or class types, so we need to
15616 classify them separatedly).
15618 * driver.cs: We do not support error 2007.
15620 2003-11-12 Jackson Harper <jackson@ximian.com>
15622 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
15623 system directory. Also use the full file name so users can
15624 libraries names mscorlib-o-tron.dll in a non system dir.
15626 2003-11-10 Martin Baulig <martin@ximian.com>
15628 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
15629 (TypeManager.InitCoreTypes): Initialize them here, but instead of
15630 calling `ResolveType()' on them, directly assign their `Type'.
15632 2003-11-08 Martin Baulig <martin@ximian.com>
15634 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
15635 return value and the `out parent' parameter.
15636 (TypeContainer.DefineType): Moved the CS0644 check into
15637 GetClassBases(). Don't pass the interface types to the
15638 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
15639 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
15641 * ecore.cs (TypeExpr.IsAttribute): New property.
15642 (TypeExpr.GetInterfaces): New method.
15644 * interface.cs (Interface.GetInterfaceTypeByName): Return a
15645 TypeExpr instead of a Type.
15646 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
15647 (Interface.DefineType): Don't pass the interface types to the
15648 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
15649 them later and then call `TypeBulider.AddInterfaceImplementation()'.
15651 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
15652 instead of a `Type[]'.
15653 (TypeManager.RegisterBuilder): Likewise.
15654 (TypeManager.AddUserInterface): Likewise.
15655 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
15656 `Type[]' and also return a `TypeExpr[]'.
15657 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
15659 2003-11-08 Martin Baulig <martin@ximian.com>
15661 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
15664 2003-11-08 Martin Baulig <martin@ximian.com>
15666 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
15667 TypeManager.ResolveExpressionTypes().
15669 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
15670 instead of an Expression.
15671 (TypeExpr): This is now an abstract base class for `TypeExpression'.
15672 (TypeExpression): New public class; formerly known as `TypeExpr'.
15674 * expression.cs (ComposedCast): Derive from TypeExpr.
15676 * typemanager.cs (TypeManager.system_*_expr): These are now
15677 TypExpr's instead of Expression's.
15678 (TypeManager.ResolveExpressionTypes): New public static function;
15679 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
15682 2003-11-06 Miguel de Icaza <miguel@ximian.com>
15684 * expression.cs (New.DoResolve): Do not dereference value that
15685 might be a null return.
15687 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
15688 sure that the constant value has the right type. Fixes an
15689 unreported bug, similar to 50425.
15691 * const.cs (Const.LookupConstantValue): Call
15692 ImplicitStandardConversionExists before doing a conversion to
15693 avoid havng the TypeManager.ChangeType do conversions.
15695 Reduced the number of casts used
15697 (Const.ChangeType): New routine to enable reuse of the constant
15698 type changing code from statement.
15700 * typemanager.cs (ChangeType): Move common initialization to
15701 static global variables.
15705 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
15706 every value type to go through, even if it was void. Fix that.
15708 * cs-tokenizer.cs: Use is_identifier_start_character on the start
15709 character of the define, and the is_identifier_part_character for
15710 the rest of the string.
15712 2003-11-05 Miguel de Icaza <miguel@ximian.com>
15714 * expression.cs (UnaryMutator.EmitCode): When I updated
15715 LocalVariableReference.DoResolve, I overdid it, and dropped an
15716 optimization done on local variable references.
15718 2003-11-04 Miguel de Icaza <miguel@ximian.com>
15720 * ecore.cs: Convert the return from Ldlen into an int.
15722 2003-10-20 Miguel de Icaza <miguel@ximian.com>
15724 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
15725 the accessibility, this is a special case for toplevel non-public
15726 classes (internal for instance).
15728 2003-10-20 Nick Drochak <ndrochak@gol.com>
15730 * ecore.cs: Fix typo and build. Needed another right paren.
15732 2003-10-19 Miguel de Icaza <miguel@ximian.com>
15734 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
15735 `internal' case regular and protected, but not allowing protected
15736 to be evaluated later. Bug 49840
15738 2003-10-15 Miguel de Icaza <miguel@ximian.com>
15740 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
15741 to kb.Nlast, and not the kb.nFirst to isolate the switch
15744 Extract the underlying type, so enumerations of long/ulong are
15745 treated like long/ulong.
15747 2003-10-14 Miguel de Icaza <miguel@ximian.com>
15749 * expression.cs (New): Overload the meaning of RequestedType to
15750 track the possible creation of the NewDelegate type, since
15751 DoResolve is invoked more than once for new constructors on field
15754 See bugs: #48800 and #37014
15756 * cs-parser.jay (declare_local_constants): Take an arraylist
15757 instead of a single constant.
15759 (local_constant_declaration): It should take a
15760 constant_declarators, not a constant_declarator. Fixes 49487
15762 * convert.cs: Fix error report.
15764 2003-10-13 Jackson Harper <jackson@ximian.com>
15766 * typemanager.cs (TypeToCoreType): Add float and double this fixes
15769 2003-10-09 Martin Baulig <martin@ximian.com>
15771 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
15773 (MethodCore.DoDefineParameters): Removed the TypeContainer
15774 argument; use the DeclSpace which was passed to the .ctor instead.
15775 (MethodCore.CheckParameter): Take a DeclSpace instead of a
15776 TypeContainer; we only need a DeclSpace here.
15778 2003-10-09 Martin Baulig <martin@ximian.com>
15780 * class.cs (MethodData): Added additional `DeclSpace ds' argument
15782 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
15783 EmitContext's .ctor.
15785 2003-10-09 Martin Baulig <martin@ximian.com>
15787 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
15788 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
15789 AsAccessible(), moved them as well.
15791 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
15793 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
15795 * cs-parser.jay : Renamed yyName to yyNames related to jay.
15797 2003-10-07 Miguel de Icaza <miguel@ximian.com>
15799 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
15800 generation for >=, as spotted by Paolo, bug 48679.
15801 Patch from David Waite.
15803 * cs-tokenizer.cs: Add handling for #pragma.
15805 * cs-parser.jay: Allow for both yield and yield return in the
15806 syntax. The anti-cobolization of C# fight will go on!
15808 * class.cs (TypeBuilder.DefineType): Catch error condition here
15809 (Parent.DefineType erroring out and returning null).
15811 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15812 coping with enumerations variables, we were mistakenly processing
15813 them as a regular value type instead of built-in types. Fixes the
15816 * typemanager.cs (IsBuiltinOrEnum): New method.
15818 2003-09-30 Miguel de Icaza <miguel@ximian.com>
15820 * cs-parser.jay: Upgrade: yield now needs the return clause.
15822 2003-09-19 Martin Baulig <martin@ximian.com>
15824 * decl.cs (MemberCache.SetupCacheForInterface): Take a
15825 `MemberCache parent' argument. Normally, an interface doesn't
15826 have a parent type except System.Object, but we use this in gmcs
15827 for generic type parameters.
15829 2003-09-18 Martin Baulig <martin@ximian.com>
15831 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
15832 on `type.IsInterface'; don't check whether the type has a parent
15833 to determine whether it's an interface.
15835 2003-09-15 Martin Baulig <martin@ximian.com>
15837 * class.cs (TypeContainer.DefineType): Added an error flag to
15838 avoid reporting duplicate CS0146's ("class definition is
15841 * driver.cs (Driver.MainDriver): Abort if
15842 RootContext.ResolveTree() reported any errors.
15844 2003-09-07 Martin Baulig <martin@ximian.com>
15846 * report.cs (Error, Warning): Added overloaded versions which take
15847 a `params object[] args' and call String.Format().
15849 2003-09-07 Martin Baulig <martin@ximian.com>
15851 * decl.cs (DeclSpace..ctor): Don't call
15852 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
15853 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
15854 (DeclSpace.RecordDecl): New method.
15856 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
15858 2003-09-02 Ravi Pratap <ravi@ximian.com>
15860 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
15861 value attributes to be applied to ParameterBuilders.
15863 * class.cs (MethodCore.LabelParameters): Make static and more
15864 generic so that it can be used from other places - like interface
15865 methods, for instance.
15867 * interface.cs (Interface.Emit): Call LabelParameters before
15868 emitting attributes on the InterfaceMethod.
15870 2003-08-26 Martin Baulig <martin@ximian.com>
15872 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
15873 resolving aliases; fixes #47927.
15875 2003-08-26 Martin Baulig <martin@ximian.com>
15877 * statement.cs (Using.DoResolve): This is internally emitting a
15878 try/finally clause, so we need to set ec.NeedExplicitReturn if we
15879 do not always return. Fixes #47681.
15881 2003-08-26 Martin Baulig <martin@ximian.com>
15883 * decl.cs (MemberCore): Moved WarningNotHiding(),
15884 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
15886 (AdditionResult): Make this nested in DeclSpace.
15887 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
15888 argument; call NamespaceEntry.Define() unless we're nested in a
15891 * namespace.cs (Namespace.DefineName): New public function. This
15892 is called from DeclSpace's .ctor to add
15893 (Namespace.Lookup): Include DeclSpaces in the lookup.
15895 * class.cs (Operator): Derive from MemberBase, not MemberCore.
15897 * const.cs (Const): Derive from MemberBase, not MemberCore.
15899 2003-08-25 Martin Baulig <martin@ximian.com>
15901 * convert.cs (Convert.ExplicitReferenceConversion): When
15902 converting from an interface type to a class, unbox if the target
15903 type is a struct type. Fixes #47822.
15905 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15907 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
15910 2003-08-22 Martin Baulig <martin@ximian.com>
15912 * class.cs (TypeManager.DefineType): When defining a nested type,
15913 call DefineType() on our parent; fixes #47801.
15915 2003-08-22 Martin Baulig <martin@ximian.com>
15917 * class.cs (MethodData.Define): While checking if a method is an
15918 interface implementation, improve the test a bit more to fix #47654.
15920 2003-08-22 Martin Baulig <martin@ximian.com>
15922 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
15923 correctly; fixes #47722.
15925 2003-08-22 Martin Baulig <martin@ximian.com>
15927 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
15928 LocalVariableReference, ensure it's not read-only. Fixes #47536.
15930 * statement.cs (Fixed.DoResolve): Make all variables read-only.
15932 2003-08-22 Martin Baulig <martin@ximian.com>
15934 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
15935 can only be assigned in static constructors. Fixes #47161.
15937 2003-08-22 Martin Baulig <martin@ximian.com>
15939 Rewrote and improved the flow analysis code.
15941 * flowbranching.cs (FlowBranching): Make this class abstract.
15942 (FlowBranching.CreateBranching): New static function to create a
15943 new flow branching.
15944 (FlowBranchingBlock, FlowBranchingException): New classes.
15945 (FlowBranching.UsageVector.Type): New public readonly field.
15946 (FlowBranching.UsageVector.Breaks): Removed the setter.
15947 (FlowBranching.UsageVector.Returns): Removed the setter.
15948 (FlowBranching.UsageVector): Added Break(), Return(),
15949 NeverReachable() and Throw() methods to modify the reachability.
15950 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
15951 done by FlowBranching.Merge().
15952 (FlowBranching.UsageVector.MergeChild): New method; merges the
15953 merge result into the current vector.
15954 (FlowBranching.Merge): New abstract method to merge a branching.
15956 2003-08-12 Martin Baulig <martin@ximian.com>
15958 * expression.cs (Indirection.CacheTemporaries): Create the
15959 LocalTemporary with the pointer type, not its element type.
15961 2003-08-10 Miguel de Icaza <miguel@ximian.com>
15963 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
15964 token was a keyword or not.
15966 Add `error' options where an IDENTIFIER was expected; Provide
15967 CheckToken and CheckIdentifierToken convenience error reporting
15970 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
15972 * decl.cs: Rename `NamespaceEntry Namespace' public field into
15973 NameSpaceEntry NameSpaceEntry.
15975 (LookupInterfaceOrClass): Avoid creating a full qualified name
15976 from namespace and name: avoid doing lookups when we know the
15977 namespace is non-existant. Use new Tree.LookupByNamespace which
15978 looks up DeclSpaces based on their namespace, name pair.
15980 * driver.cs: Provide a new `parser verbose' to display the
15981 exception thrown during parsing. This is turned off by default
15982 now, so the output of a failure from mcs is more graceful.
15984 * namespace.cs: Track all the namespaces defined in a hashtable
15987 (IsNamespace): New method
15989 2003-08-09 Miguel de Icaza <miguel@ximian.com>
15991 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
15992 we know that we need to concatenate (full typename can never be
15997 * statement.cs: Use a bitfield; Do not initialize to null things
15998 which are done by the constructor by default.
16000 * cs-parser.jay: bug fix, parameter was 4, not 3.
16002 * expression.cs: Just use the property;
16004 * statement.cs: No need for GetVariableInfo method.
16006 2003-08-08 Martin Baulig <martin@ximian.com>
16008 * flowanalysis.cs (FlowReturns): This is now nested in the
16009 `FlowBranching' class.
16010 (MyBitVector): Moved this here from statement.cs.
16011 (FlowBranching.SiblingType): New enum type.
16012 (FlowBranching.CreateSibling): Added `SiblingType' argument.
16014 2003-08-07 Martin Baulig <martin@ximian.com>
16016 * flowanalysis.cs (FlowBranchingType): This is now nested in the
16017 `FlowBranching' class and called `BranchingType'.
16019 2003-08-07 Martin Baulig <martin@ximian.com>
16021 * flowanalysis.cs: Moved all the control flow analysis code into
16024 2003-08-07 Martin Baulig <martin@ximian.com>
16026 * assign.cs (Assign.DoResolve): `target' must either be an
16027 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
16030 2003-08-07 Miguel de Icaza <miguel@ximian.com>
16032 * expression.cs (BinaryMethod): This kind of expression is created by the
16033 Binary class if it determines that the operator has to be handled
16036 (BinaryDelegate): This kind of expression is created if we are
16037 dealing with a + or - operator on delegates.
16039 (Binary): remove method, argumetns, and DelegateOperator: when
16040 dealing with methods,
16042 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
16044 * statement.cs (Block): use bitfields for the three extra booleans
16045 we had in use. Remove unused topblock parameter.
16047 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
16049 * assign.cs: Drop extra unneeded tests.
16051 2003-08-06 Miguel de Icaza <miguel@ximian.com>
16053 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
16055 * statement.cs (Foreach): Use VariableStorage instead of
16058 * codegen.cs (VariableStorage): New class used by clients that
16059 require a variable stored: locals or fields for variables that
16060 need to live across yield.
16062 Maybe provide a convenience api for EmitThis+EmitLoad?
16064 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
16067 2003-08-05 Miguel de Icaza <miguel@ximian.com>
16069 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
16070 RemapParameterLValue): New methods that are used to turn a
16071 precomputed FieldInfo into an expression like this:
16075 The idea is to use this instead of making LocalVariableReference
16076 have more than one meaning.
16078 * cs-parser.jay: Add error production to BASE.
16080 * ecore.cs: Deal with TypeManager.GetField returning null, which
16081 is now a valid return value.
16083 (FieldExprNoAddress): New expression for Fields whose address can
16086 * expression.cs (LocalVariableReference): During the resolve
16087 phases, create new expressions if we are in a remapping context.
16088 Remove code that dealt with remapping here.
16090 (ParameterReference): same.
16092 (ProxyInstance): New expression, like the `This' expression, but
16093 it is born fully resolved. We know what we are doing, so remove
16094 the errors that are targeted to user-provided uses of `this'.
16096 * statement.cs (Foreach): our variable is now stored as an
16097 Expression; During resolution, follow the protocol, dont just
16098 assume it will return this.
16100 2003-08-06 Martin Baulig <martin@ximian.com>
16102 * support.cs (SeekableStreamReader.cs): New public class.
16104 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
16105 SeekableStreamReader instead of the normal StreamReader.
16107 2003-08-04 Martin Baulig <martin@ximian.com>
16109 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
16110 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
16111 deambiguate casts and delegate invocations.
16112 (parenthesized_expression): Use the new tokens to ensure this is
16113 not a cast of method invocation.
16115 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
16116 when reading a `)' and Deambiguate_CloseParens () was previously
16119 * expression.cs (ParenthesizedExpression): New class. This is
16120 just used for the CS0075 test.
16121 (Binary.DoResolve): Check for CS0075.
16123 2003-07-29 Ravi Pratap <ravi@ximian.com>
16125 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
16126 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
16127 reference comparison.
16129 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
16130 examine the ReturnType for equality - this is necessary in the
16131 cases of implicit and explicit operators whose signature also
16132 includes the return type.
16134 2003-07-26 Miguel de Icaza <miguel@ximian.com>
16136 * namespace.cs: Cache the result of the namespace computation,
16137 instead of computing it every time.
16139 2003-07-24 Miguel de Icaza <miguel@ximian.com>
16141 * decl.cs: Use a global arraylist that we reuse over invocations
16142 to avoid excesive memory consumption. Reduces memory usage on an
16143 mcs compile by one meg (45 average).
16145 * typemanager.cs (LookupTypeReflection): In .NET pointers are
16146 private, work around that.
16148 2003-07-23 Miguel de Icaza <miguel@ximian.com>
16150 * literal.cs (IntLiteral): Define Zero and One static literals.
16152 * cs-parser.jay (integer_literal): use static literals to reduce
16153 memory usage for the most used literals (0, 1 and -1). 211kb
16154 reduced in memory usage.
16156 Replace all calls to `new ArrayList' with `new
16157 ArrayList(4)' which is a good average number for most allocations,
16158 and also requires only 16 bytes of memory for its buffer by
16161 This reduced MCS memory usage in seven megabytes for the RSS after
16164 2003-07-28 Ravi Pratap <ravi@ximian.com>
16166 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
16167 handle params methods the correct way by forming only one
16168 applicable set with params and normal methods in them. Earlier we
16169 were looking at params methods only if we found no normal methods
16170 which was not the correct thing to do.
16172 (Invocation.BetterFunction): Take separate arguments indicating
16173 when candidate and the best method are params methods in their
16176 This fixes bugs #43367 and #46199.
16178 * attribute.cs: Documentation updates.
16180 (CheckAttribute): Rename to CheckAttributeTarget.
16181 (GetValidPlaces): Rename to GetValidTargets.
16183 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
16184 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
16188 2003-07-28 Martin Baulig <martin@ximian.com>
16190 * class.cs (TypeContainer.DefineMembers): Use the base type's full
16191 name when looking up the base class of a nested class. Fixes #46977.
16193 2003-07-26 Martin Baulig <martin@ximian.com>
16195 * expression.cs (Indexers.Indexer): New nested struct; contains
16196 getter, setter and the indexer's type.
16197 (Indexers.Properties): This is now an ArrayList of
16198 Indexers.Indexer's.
16199 (IndexerAccess.DoResolveLValue): Correctly set the type if the
16200 indexer doesn't have any getters.
16202 * assign.cs (Assign.DoResolve): Also do the implicit conversions
16203 for embedded property and indexer assignments.
16205 2003-07-26 Martin Baulig <martin@ximian.com>
16207 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
16208 preprocessor directive is not the first non-whitespace character
16211 2003-07-26 Martin Baulig <martin@ximian.com>
16213 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
16214 namespace parsing, follow the spec more closely.
16216 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
16217 NamespaceEntry.Lookup().
16219 2003-07-25 Martin Baulig <martin@ximian.com>
16221 * MethodCore.cs (OverridesSomething): New public field; it's set
16222 from TypeContainer.DefineMembers if this method overrides
16223 something (which doesn't need to be a method). Fix #39462.
16225 2003-07-25 Ravi Pratap <ravi@ximian.com>
16227 * typemanager.cs (GetMembers): Ensure that the list of members is
16228 reversed. This keeps things in sync.
16230 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
16231 find an AttributeUsage attribute.
16233 * expression.cs (Invocation.OverloadResolve): Perform the check
16234 which disallows Invoke to be directly called on a Delegate.
16236 (Error_InvokeOnDelegate): Report error cs1533.
16238 2003-07-25 Martin Baulig <martin@ximian.com>
16240 * expression.cs (Indexers.GetIndexersForType): Only look in the
16241 interface hierarchy if the requested type is already an
16242 interface. Fixes #46788 while keeping #46502 fixed.
16244 2003-07-25 Martin Baulig <martin@ximian.com>
16246 * class.cs (TypeContainer.DefineMembers): Check whether all
16247 readonly fields have been assigned and report warning CS0649 if
16250 * statement.cs (LocalInfo.IsFixed): Always return true if this is
16253 2003-07-24 Ravi Pratap <ravi@ximian.com>
16255 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
16256 returned from GetMethods to make things consistent with the
16257 assumptions MCS makes about ordering of methods.
16259 This should comprehensively fix bug #45127 and it does :-)
16261 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
16262 ordering is actually reverse.
16264 * Clean up some debug messages I left lying around.
16266 * interface.cs (Populate*): Get rid of code which emits attributes
16267 since the stage in which we emit attributes is the 'Emit' stage,
16268 not the define stage.
16270 (Emit): Move attribute emission for interface members here.
16272 2003-07-22 Ravi Pratap <ravi@ximian.com>
16274 * expression.cs (Invocation.OverloadResolve): Follow the spec more
16275 closely: we eliminate methods in base types when we have an
16276 applicable method in a top-level type.
16278 Please see section 14.5.5.1 for an exact description of what goes
16281 This fixes bug #45127 and a host of other related to corlib compilation.
16283 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
16284 array is the method corresponding to the top-level type (this is
16285 because of the changes made to icall.c) so we change this
16288 (MethodGroupExpr.Name): This too.
16290 * typemanager.cs (GetElementType): New method which does the right
16291 thing when compiling corlib.
16293 * everywhere: Make use of the above in the relevant places.
16295 2003-07-22 Martin Baulig <martin@ximian.com>
16297 * cs-parser.jay (invocation_expression): Moved
16298 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
16299 `cast_expression', but create a InvocationOrCast which later
16300 resolves to either an Invocation or a Cast.
16302 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
16303 method; call this before EmitStatement() to make sure that this
16304 expression can be used as a statement.
16306 * expression.cs (InvocationOrCast): New class; resolves to either
16307 an Invocation or a Cast.
16309 * statement.cs (StatementExpression): Call ResolveStatement() on
16310 the ExpressionStatement before emitting it.
16312 2003-07-21 Martin Baulig <martin@ximian.com>
16314 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
16315 `ref' and `out' attributes match; fixes #46220.
16316 (MemberAccess.ResolveMemberAccess): You can't reference a type
16317 through an expression; fixes #33180.
16318 (Indexers.GetIndexersForType): Don't return the indexers from
16319 interfaces the class implements; fixes #46502.
16321 2003-07-21 Martin Baulig <martin@ximian.com>
16323 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
16324 CS0661 checks; fixes bug #30442.
16326 2003-07-21 Martin Baulig <martin@ximian.com>
16328 * decl.cs (AdditionResult): Added `Error'.
16330 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
16332 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
16333 makes cs0031.cs actually work.
16335 2003-07-20 Martin Baulig <martin@ximian.com>
16337 * namespace.cs: Fixed that bug which caused a crash when compiling
16338 the debugger's GUI.
16340 2003-07-20 Miguel de Icaza <miguel@ximian.com>
16342 * typemanager.cs (LookupTypeReflection): Never expose types which
16343 are NotPublic, NestedPrivate, NestedAssembly, or
16344 NestedFamANDAssem. We used to return these, and later do a check
16345 that would report a meaningful error, but the problem is that we
16346 would not get the real match, if there was a name override.
16348 2003-07-18 Miguel de Icaza <miguel@ximian.com>
16350 * namespace.cs (Namespace, Name): Do not compute the namespace
16351 name dynamically, compute it in the constructor. This reduced
16352 memory usage by 1697 KB.
16354 * driver.cs: Use --pause to pause at the end.
16356 2003-07-17 Peter Williams <peter@newton.cx>
16358 * Makefile: Change the name of the test target so that it doesn't
16359 conflict with the recursive test target.
16361 2003-07-17 Miguel de Icaza <miguel@ximian.com>
16363 * expression.cs (LocalVariableReference.Emit, EmitAssign,
16364 AddressOf): Do not use EmitThis, that was wrong, use the actual
16367 2003-07-15 Miguel de Icaza <miguel@ximian.com>
16369 * class.cs (MethodData.Define): While checking if a method is an
16370 interface implementation, improve the test: If we are not public
16371 (use new test here: use the computed MethodAttributes directly,
16372 instead of the parsed modifier flags) check if the `implementing'
16373 method comes from an interface or not.
16375 * pending.cs (VerifyPendingMethods): Slightly better error
16378 * makefile: add test target that does the mcs bootstrap.
16380 2003-07-16 Ravi Pratap <ravi@ximian.com>
16382 * interface.cs (Define): Do nothing here since there are no
16383 members to populate etc. Move the attribute emission out of here
16384 since this was just totally the wrong place to put it. Attribute
16385 application happens during the 'Emit' phase, not in the 'Define'
16388 (Emit): Add this method and move the attribute emission here
16390 * rootcontext.cs (EmitCode): Call the Emit method on interface
16393 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16395 * expression.cs (OverloadResolve): Report error only if Location
16396 is not 'Null' which means that there was a probe going on.
16398 2003-07-14 Martin Baulig <martin@ximian.com>
16400 * expression.cs (ConditionalLogicalOperator): New public class to
16401 implement user defined conditional logical operators.
16402 This is section 14.11.2 in the spec and bug #40505.
16404 2003-07-14 Martin Baulig <martin@ximian.com>
16406 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
16408 2003-07-14 Martin Baulig <martin@ximian.com>
16410 * codegen.cs (EmitContext.InFixedInitializer): New public field.
16412 * ecore.cs (IVariable.VerifyFixed): New interface method.
16414 * expression.cs (Unary.ResolveOperator): When resolving the `&'
16415 operator, check whether the variable is actually fixed. Fixes bug
16416 #36055. Set a variable definitely assigned when taking its
16417 address as required by the spec.
16419 * statement.cs (LocalInfo.IsFixed): New field.
16420 (LocalInfo.MakePinned): Set `IsFixed' to true.
16422 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16424 * attribute.cs (Attribute.Resolve): While doing a Member lookup
16425 for .ctors, ensure that we only ask for members declared in the
16426 attribute type (BindingFlags.DeclaredOnly).
16430 * expression.cs (Error_WrongNumArguments): Report error 1501
16431 correctly the way CSC does.
16433 2003-07-13 Martin Baulig <martin@ximian.com>
16435 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
16436 lookup on the fully qualified name, to make things like "X.X" work
16437 where "X.X" is a fully qualified type name, but we also have a
16438 namespace "X" in the using list. Fixes #41975.
16440 2003-07-13 Martin Baulig <martin@ximian.com>
16442 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
16443 function. If we're a CompoundAssign, we need to create an embedded
16444 CompoundAssign, not an embedded Assign.
16445 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
16448 2003-07-13 Martin Baulig <martin@ximian.com>
16450 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
16451 work to fix bug #46088.
16453 2003-07-13 Ravi Pratap <ravi@ximian.com>
16455 * class.cs (Operator.Emit): Do not emit attributes here - it is
16456 taken care of by the Method class that we delegate too. This takes
16457 care of bug #45876.
16459 2003-07-10 Martin Baulig <martin@ximian.com>
16461 * expression.cs (TypeOfVoid): New class.
16462 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
16464 2003-07-10 Martin Baulig <martin@ximian.com>
16466 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
16469 2003-07-10 Martin Baulig <martin@ximian.com>
16471 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
16472 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
16474 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
16476 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
16478 2003-07-10 Martin Baulig <martin@ximian.com>
16480 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
16481 of decimal. Fixes #42850.
16483 NOTE: I also fixed the created byte blob, but this doesn't work on
16484 the MS runtime and csc never produces any byte blobs for decimal
16487 2003-07-10 Martin Baulig <martin@ximian.com>
16489 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
16490 structs; fixes #32068.
16491 (Block.AddChildVariableNames): Fixed #44302.
16493 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16495 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
16497 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16499 * attribute.cs: And this test is onger needed.
16501 2003-07-08 Martin Baulig <martin@ximian.com>
16503 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
16504 inaccessible types. Fixes #36313.
16506 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
16508 * namespace.cs (NamespaceEntry): Create implicit entries for all
16509 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
16510 implicit entries for N1.N2 and N1.
16512 2003-07-08 Martin Baulig <martin@ximian.com>
16514 Rewrote the handling of namespaces to fix a lot of the issues
16515 wrt. `using' aliases etc.
16517 * namespace.cs (Namespace): Splitted this class into a
16518 per-assembly `Namespace' and a per-file `NamespaceEntry'.
16520 * typemanager.cs (TypeManager.IsNamespace): Removed.
16521 (TypeManager.ComputeNamespaces): Only compute namespaces from
16522 loaded assemblies here, not the namespaces from the assembly we're
16523 currently compiling.
16525 2003-07-08 Martin Baulig <martin@ximian.com>
16527 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
16529 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16531 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
16534 I thought about the memory savings here, but LookupTypeReflection
16535 is used under already very constrained scenarios. Compiling
16536 corlib or mcs only exposes one hit, so it would not really reduce
16537 any memory consumption.
16539 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16541 * typemanager.cs: fixes bug #45889 by only adding public types from
16542 other assemblies to the list of known types.
16544 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16546 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
16547 on the type we resolved.
16549 2003-07-05 Martin Baulig <martin@ximian.com>
16551 * pending.cs (PendingImplementation.ParentImplements): Don't
16552 create the proxy if the parent is abstract.
16554 * class.cs (TypeContainer.DefineIndexers): Process explicit
16555 interface implementations first. Fixes #37714.
16557 2003-07-04 Miguel de Icaza <miguel@ximian.com>
16559 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
16560 defined recursively; but since we modify the input parameters
16561 (left is set to `this' temporarily), we reset this value if the
16562 left_is_explicit is false, which gives the original semantics to
16565 * literal.cs (NullPointer): new class used to represent a null
16566 literal in a pointer context.
16568 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
16569 type is a pointer, use a NullPointer object instead of a
16570 NullLiteral. Closes 43687
16572 (ExplicitConversion): Convert pointer values using
16573 the conv opcode to the proper type.
16575 * ecore.cs (New): change ValueTypeVariable property into a method,
16576 that returns whether the valuetype is suitable for being used.
16578 * expression.cs (Binary.DoNumericPromotions): Only return if we
16579 the int constant was a valid uint, and we can return both left and
16580 right as uints. If not, we continue processing, to trigger the
16581 type conversion. This fixes 39018.
16583 * statement.cs (Block.EmitMeta): During constant resolution, set
16584 the CurrentBlock property on the emitcontext, so that we resolve
16585 constants propertly.
16587 2003-07-02 Martin Baulig <martin@ximian.com>
16589 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
16590 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
16592 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
16593 than emitting it here.
16595 * statement.cs: Fixed some more flow analysis bugs.
16597 2003-07-02 Martin Baulig <martin@ximian.com>
16599 * class.cs (MethodData.Define): When implementing interface
16600 methods, set Final unless we're Virtual.
16602 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
16603 check work for interface methods.
16605 2003-07-01 Martin Baulig <martin@ximian.com>
16607 * ecore.cs (EmitContext.This): Replaced this property with a
16608 GetThis() method which takes a Location argument. This ensures
16609 that we get the correct error location for a CS0188.
16611 2003-07-01 Miguel de Icaza <miguel@ximian.com>
16613 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
16614 ImplicitStandardConversion.
16616 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
16618 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
16620 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
16623 2003-06-30 Miguel de Icaza <miguel@ximian.com>
16625 * class.cs (Constructor.Define): Turn off initlocals for unsafe
16628 (MethodData.Define): Turn off initlocals for unsafe methods.
16630 2003-06-29 Miguel de Icaza <miguel@ximian.com>
16632 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
16633 complete; Fixes #37521.
16635 * delegate.cs: Use Modifiers.TypeAttr to compute the
16636 TypeAttributes, instead of rolling our own. This makes the flags
16637 correct for the delegates.
16639 2003-06-28 Miguel de Icaza <miguel@ximian.com>
16641 * class.cs (Constructor.Define): Set the private flag for static
16642 constructors as well.
16644 * cs-parser.jay (statement_expression): Set the return value to
16645 null, to avoid a crash when we catch an error.
16647 2003-06-24 Miguel de Icaza <miguel@ximian.com>
16649 * cs-parser.jay: Applied patch from Jackson that adds support for
16650 extern and unsafe modifiers to destructor declarations.
16652 * expression.cs: Report error 21 if the user is trying to index a
16655 * driver.cs: Add an error message, suggested by the bug report.
16657 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
16658 if we do not have a ": this ()" constructor initializer. Fixes 45149
16660 2003-06-14 Miguel de Icaza <miguel@ximian.com>
16662 * namespace.cs: Add some information to reduce FAQs.
16664 2003-06-13 Miguel de Icaza <miguel@ximian.com>
16666 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
16667 underlying enumeration types. Fixes #43915.
16669 * expression.cs: Treat ushort/short as legal values to be used in
16670 bitwise operations.
16672 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
16674 * delegate.cs: transfer custom attributes for paramenters from
16675 the delegate declaration to Invoke and BeginInvoke.
16677 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
16679 * attribute.cs: handle custom marshalers and emit marshal info
16682 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
16684 * makefile.gnu: Added anonymous.cs to the compiler sources.
16686 2003-05-28 Miguel de Icaza <miguel@ximian.com>
16688 * iterators.cs: Change the name of the proxy class to include two
16691 * cs-parser.jay: Update grammar to include anonymous methods.
16693 * anonymous.cs: new file.
16695 2003-05-27 Miguel de Icaza <miguel@ximian.com>
16697 * class.cs (Field.Define): Add missing test for pointers and
16700 2003-05-27 Ravi Pratap <ravi@ximian.com>
16702 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
16703 we use the stobj opcode.
16705 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
16706 since it wasn't the correct fix.
16708 It still is puzzling that we are required to use stobj for IntPtr
16709 which seems to be a ValueType.
16711 2003-05-26 Miguel de Icaza <miguel@ximian.com>
16713 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
16714 during regular simple name resolution. Now, the trick is that
16715 instead of returning for processing the simplename, we do a
16716 TypeManager.LookupType (ie, a rooted lookup as opposed to a
16717 contextual lookup type). If a match is found, return that, if
16718 not, return for further composition.
16720 This fixes long-standing 30485.
16722 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16723 using the address to initialize an object, do an Stobj instead of
16724 using the regular Stelem.
16726 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
16727 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
16728 Because if we are a BaseIndexerAccess that value will be true.
16731 * statement.cs (GotoCase.Resolve): Return after reporting an
16732 error, do not attempt to continue.
16734 * expression.cs (PointerArithmetic.Emit): If our operand is a
16735 long, convert our constants to match the operand before
16736 multiplying. Convert to I type before adding. Fixes 43670.
16738 2003-05-14 Ravi Pratap <ravi@ximian.com>
16740 * enum.cs (ImplicitConversionExists) : Rename to
16741 ImplicitEnumConversionExists to remove ambiguity.
16743 * ecore.cs (NullCast): New type of cast expression class which
16744 basically is very similar to EmptyCast with the difference being
16745 it still is a constant since it is used only to cast a null to
16747 (eg. (string) null)
16749 * convert.cs (ImplicitReferenceConversion): When casting a null
16750 literal, we return a NullCast.
16752 * literal.cs (NullLiteralTyped): Remove - I don't see why this
16753 should be around anymore.
16755 The renaming (reported was slightly wrong). Corrections:
16757 ConvertImplicitStandard -> ImplicitConversionStandard
16758 ConvertExplicitStandard -> ExplicitConversionStandard
16760 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
16761 before passing them in !
16763 * convert.cs (ImplicitConversionStandard): When comparing for
16764 equal expr and target types, ensure that expr is not a
16767 In general, we must not be checking (expr_type ==
16768 target_type) in the top level conversion methods
16769 (ImplicitConversion, ExplicitConversion etc). This checking is
16770 done in the methods that they delegate to.
16772 2003-05-20 Miguel de Icaza <miguel@ximian.com>
16774 * convert.cs: Move Error_CannotConvertType,
16775 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
16776 ImplicitNumericConversion, ImplicitConversionExists,
16777 ImplicitUserConversionExists, StandardConversionExists,
16778 FindMostEncompassedType, FindMostSpecificSource,
16779 FindMostSpecificTarget, ImplicitUserConversion,
16780 ExplicitUserConversion, GetConversionOperators,
16781 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
16782 TryImplicitIntConversion, Error_CannotConvertImplicit,
16783 ConvertImplicitRequired, ConvertNumericExplicit,
16784 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
16785 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
16788 Perform the following renames:
16790 StandardConversionExists -> ImplicitStandardConversionExists
16791 ConvertImplicit -> ImplicitConversion
16792 ConvertImplicitStandard -> ImplicitStandardConversion
16793 TryImplicitIntConversion -> ImplicitIntConversion
16794 ConvertImplicitRequired -> ImplicitConversionRequired
16795 ConvertNumericExplicit -> ExplicitNumericConversion
16796 ConvertReferenceExplicit -> ExplicitReferenceConversion
16797 ConvertExplicit -> ExplicitConversion
16798 ConvertExplicitStandard -> ExplicitStandardConversion
16800 2003-05-19 Martin Baulig <martin@ximian.com>
16802 * statement.cs (TypeInfo.StructInfo): Made this type protected.
16803 (TypeInfo): Added support for structs having structs as fields.
16805 * ecore.cs (FieldExpr): Implement IVariable.
16806 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
16807 VariableInfo for the field.
16809 2003-05-18 Martin Baulig <martin@ximian.com>
16811 * expression.cs (This.DoResolve): Report a CS0027 if we're
16812 emitting a field initializer.
16814 2003-05-18 Martin Baulig <martin@ximian.com>
16816 * expression.cs (This.ResolveBase): New public function.
16817 (This.DoResolve): Check for CS0188.
16819 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
16822 * ecore.cs (MethodGroupExpr.DoResolve): Set the
16823 `instance_expression' to null if we don't have any non-static
16826 2003-05-18 Martin Baulig <martin@ximian.com>
16828 Reworked the way how local variables and parameters are handled by
16829 the flow analysis code.
16831 * statement.cs (TypeInfo, VariableMap): New public classes.
16832 (VariableInfo): New public class. This is now responsible for
16833 checking whether a variable has been assigned. It is used for
16834 parameters and local variables.
16835 (Block.EmitMeta): Take the InternalParameters as argument; compute
16836 the layout of the flow vectors here.
16837 (Block.LocalMap, Block.ParameterMap): New public properties.
16838 (FlowBranching): The .ctor doesn't get the InternalParameters
16839 anymore since Block.EmitMeta() now computes the layout of the flow
16841 (MyStructInfo): This class is now known as `StructInfo' and nested
16842 in `TypeInfo'; we don't access this directly anymore.
16844 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
16845 property and removed IsAssigned(), IsFieldAssigned(),
16846 SetAssigned() and SetFieldAssigned(); we now call them on the
16847 VariableInfo so we don't need to duplicate this code everywhere.
16849 * expression.cs (ParameterReference): Added `Block block' argument
16851 (LocalVariableReference, ParameterReference, This): The new
16852 VariableInfo class is now responsible for all the definite
16855 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
16856 IsParameterAssigned, SetParameterAssigned): Removed.
16858 2003-05-18 Martin Baulig <martin@ximian.com>
16860 * typemanager.cs (InitCoreTypes): Try calling
16861 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
16862 the 3-args-version. Corlib now also needs our `void_type'.
16863 (GetMethod): Added overloaded version which takes an optional
16864 `bool report_errors' to allow lookups of optional methods.
16866 2003-05-12 Martin Baulig <martin@ximian.com>
16868 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
16869 only used for locals and not for parameters.
16871 2003-05-12 Miguel de Icaza <miguel@ximian.com>
16873 * support.cs (InternalParameters.ParameterType): Return the
16874 ExternalType of the parameter.
16876 * parameter.cs (Parameter.ExternalType): drop the two arguments,
16879 2003-05-11 Miguel de Icaza <miguel@ximian.com>
16881 * class.cs (MethodData.Define): Do not set the `newslot' on
16882 interface members, if they are also flagged as "override".
16884 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
16885 better code for ++i and i++. This only works for static fields
16886 and local variables.
16888 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
16889 want to pull the DeclSpace out of the builder_to_declspace instead
16890 of the TypeBuilder (like in TypeContainer.FindMembers).
16892 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
16893 instead of LookupTypeContainer. Fixes the crash on .NET for
16894 looking up interface members.
16896 * const.cs: Create our own emit context during the Definition
16897 stage, so that constants are evaluated in the proper context, when
16898 a recursive definition happens.
16900 2003-05-11 Martin Baulig <martin@ximian.com>
16902 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
16903 new block for a switch section.
16904 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
16905 the adding/lookup in the switch block. Fixes #39828.
16907 2003-05-09 Miguel de Icaza <miguel@ximian.com>
16909 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
16910 functionality: I needed to convert the data after I had performed
16911 the add/sub operation into the operands type size.
16913 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
16914 pass the type for the box operation, otherwise the resulting
16915 object would have been of type object.
16917 (BoxedCast): Add constructor to specify the type to box as.
16919 2003-05-07 Miguel de Icaza <miguel@ximian.com>
16921 * iterators.cs: I was reusing the `count' variable inadvertently,
16922 take steps to not allow this to happen.
16924 2003-05-06 Miguel de Icaza <miguel@ximian.com>
16926 * attribute.cs (Attribute.Resolve): Params attributes are encoded
16927 by creating an array at the point where the params starts and
16928 putting all those arguments there, then adjusting the size of the
16931 2003-05-05 Miguel de Icaza <miguel@ximian.com>
16933 * expression.cs (New.AddressOf): Implement interface
16934 IMemoryLocation. This is used when the `new' operator is used in
16935 the context of an invocation to a method on a value type.
16937 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
16940 * namespace.cs: Also check the using aliases here.
16942 * driver.cs: Move the test for using validity after the types have
16943 been entered, so we do a single pass that also includes the using
16946 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
16947 in the regular case. CreateSiblingForFinally is doing extra
16950 * attribute.cs (GetAttributeArgumentExpression): Store the result
16951 on an out value, and use the return value to indicate failure
16952 instead of using null (which is a valid return for Constant.GetValue).
16954 * statement.cs: Perform the analysis flow for the increment
16955 portion after the statement, because this will be the real flow of
16956 execution. Fixes #42385
16958 * codegen.cs (EmitContext.EmitArgument,
16959 EmitContext.EmitStoreArgument): New helper functions when the
16960 RemapToProxy flag is set.
16962 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
16965 Add support for remapping parameters.
16967 * iterators.cs: Propagate parameter values; Store parameter
16968 values in the proxy classes.
16970 2003-05-04 Miguel de Icaza <miguel@ximian.com>
16972 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
16973 need a proxy reference; I do not know what I was thinking
16975 * cs-parser.jay (constructor_initializer): catch another error,
16976 and display nice message.
16978 (field_declaration): catch void field declaration
16979 to flag a better error.
16981 * class.cs (MemberBase.CheckBase): Report an error instead of a
16982 warning if a new protected member is declared in a struct.
16983 (Field.Define): catch the error of readonly/volatile.
16985 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
16987 (FieldExpr.AddressOf): ditto. Catch error where the address of a
16988 volatile variable is taken
16990 2003-05-02 Miguel de Icaza <miguel@ximian.com>
16992 * statement.cs (Fixed.Resolve): Report an error if we are not in
16995 2003-05-01 Miguel de Icaza <miguel@ximian.com>
16997 * typemanager.cs: reuse the code that handles type clashes for
16998 delegates and enumerations.
17000 * class.cs (Report28): Always report.
17002 * expression.cs (EncodeAsAttribute): Allow nulls here.
17004 2003-04-28 Miguel de Icaza <miguel@ximian.com>
17006 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
17007 the functionality for testing whether an expression is valid for
17008 an attribute here. Also handle the case of arrays of elements
17011 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
17012 encoding a linear array into an array of objects that are suitable
17013 to be passed to an CustomAttributeBuilder.
17015 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
17017 * ecore.cs: (FieldExpr): Handle field remapping here.
17019 * iteratators.cs: Pass the instance variable (if the method is an
17020 instance method) to the constructors, so we can access the field
17021 variables on the class.
17023 TODO: Test this with structs. I think the THIS variable on
17024 structs might have to be a pointer, and not a refenrece
17026 2003-04-27 Miguel de Icaza <miguel@ximian.com>
17028 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
17029 local variables to fields in a proxy class.
17031 * iterators.cs (PopulateProxy): Rename our internal fields to
17033 Create a <THIS> field if we are an instance method, so we can
17034 reference our parent container variables.
17035 (MapVariable): Called back from the EmitContext code to enter a
17036 new variable to field mapping into the proxy class (we just create
17040 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
17041 for using the remapped locals to fields.
17043 I placed the code here, because that gives the same semantics to
17044 local variables, and only changes the Emit code.
17046 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
17047 statements inside iterators.
17048 (VariableInfo): Add a FieldBuilder for the cases when we are
17049 remapping local variables to fields in a proxy class
17051 * ecore.cs (SimpleNameResolve): Avoid testing two times for
17052 current_block != null.
17054 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
17055 not cope with strings, as it has been moved to the
17056 TableSwitchEmit. Fixed bug in switch generation.
17058 * expression.cs (New.DoResolve): Provide more context for the user
17059 when reporting an error.
17061 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
17064 * expression.cs (MemberAccess.DoResolve): When we get a type back,
17065 check the permissions for it. Note than in a type-resolution
17066 context the check was already present in DeclSpace.ResolveType,
17067 but was missing from the MemberAccess.
17069 (ArrayCreation.CheckIndices): warn if the user has
17070 more nested levels of expressions, but there are no more
17071 dimensions specified. Avoids crash on bug 41906.
17073 2003-04-26 Miguel de Icaza <miguel@ximian.com>
17075 * statement.cs (Block): replace Implicit bool, for a generic
17077 New flag: `Unchecked'. This is used during the EmitMeta phase
17078 (which is out-of-line with the regular Resolve/Emit process for a
17079 statement, as this is done ahead of time, but still gets a chance
17080 to call constant resolve).
17082 (Block.Flags): new enum for adding a new flag.
17084 (Block.EmitMeta): track the state of unchecked.
17086 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
17087 to enable constant resolution to work there as well.
17089 2003-04-22 Miguel de Icaza <miguel@ximian.com>
17091 * typemanager.cs (ienumerable_type): Also look up
17092 System.Collections.IEnumerable.
17094 2003-04-21 Miguel de Icaza <miguel@ximian.com>
17096 TODO: Test more than one conditional per method.
17098 * class.cs (Indexer.Define): Report the location where the user is
17099 referencing the unsupported feature.
17101 (MethodData): Overload the use of `conditionals' to
17102 minimize the creation of needless ArrayLists. This saves roughly
17103 212kb on my machine.
17105 (Method): Implement the new IIteratorContainer interface.
17106 (Method.SetYields): Implement the method by setting the ModFlags
17107 to contain METHOD_YIELDS.
17109 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
17110 which just got set to null.
17112 * iterators.cs: New file.
17114 (Yield, YieldBreak): New statements.
17116 * statement.cs (Return.Resolve): Flag an error if we are used in
17117 an iterator method.
17119 * codegen.cs (InIterator): New flag set if the code is being
17120 compiled in an iterator method.
17122 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
17123 internal modifier, and we just use it to avoid adding extra
17124 fields, as this is seldom used.
17126 * cs-parser.jay: Add yield_statement (yield and yield break).
17128 * driver.cs: New flag -v2 to turn on version 2 features.
17130 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
17131 hashtable when v2 is enabled.
17133 2003-04-20 Miguel de Icaza <miguel@ximian.com>
17135 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
17136 there is already a namespace defined with this name.
17138 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
17139 people upgraded their corlibs.
17141 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
17142 always use fully qualified types, no need to use the compiler
17145 (TypeManager.IsNamespace): Use binarysearch.
17147 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
17148 AddDelegate): I did not quite use the new IsValid API properly: I
17149 have to pass the short-name and the fullname. I was passing only
17150 the basename instead of the fullname sometimes.
17152 (TypeContainer.DefineType): call NamespaceClash.
17154 * interface.cs (Interface.DefineType): use NamespaceClash before
17157 * delegate.cs (Delegate.DefineType): use NamespaceClash before
17160 * enum.cs: (Enum.DefineType): use NamespaceClash before
17163 * typemanager.cs (: 3-line patch that gives us some tasty 11%
17164 speed increase. First, use the negative_hits cache when we get a
17165 negative. Second, add the type with its full original name
17166 instead of the new . and + encoded name (reflection uses + to
17167 separate type from a nested type). Use LookupTypeReflection
17168 directly which bypasses the type->name hashtable (that we already
17169 know does not contain the type.
17171 * decl.cs (DeclSpace.ResolveTypeExpr): track the
17172 location/container type.
17174 * driver.cs: When passing utf8, use directly the UTF8Encoding.
17176 2003-04-19 Miguel de Icaza <miguel@ximian.com>
17178 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
17180 * delegate.cs (NewDelegate.Resolve): Test whether an instance
17181 method is being referenced in the method group from a static
17182 context, and report error 120 if so.
17184 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
17187 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
17188 is created, we create the A namespace).
17190 * cs-parser.jay: A namespace also introduces a DeclarationFound.
17193 2003-04-18 Miguel de Icaza <miguel@ximian.com>
17195 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
17196 invocation to ModuleBuilder.GetType with the same values will
17197 return a new type instance, so we need to cache its return
17200 * expression.cs (Binary.ResolveOperator): Only allow the compare
17201 operators on enums if they are of the same type.
17203 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
17204 types of ValueType on their own case. Before we were giving them
17205 the same treatment as objects.
17207 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
17208 fullname. Short name is used to compare against container name.
17209 Fullname is used to check against defined namespace names.
17211 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
17212 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
17214 (Method.CheckBase): Call parent.
17215 (MemberBase.CheckBase): Check for protected members on sealed
17217 (PropertyBase.CheckBase): Call parent.
17218 (Field.Define): Call parent.
17220 * report.cs: Negative error codes are now mapped to 8000 - code,
17221 so that the display is render more nicely.
17223 * typemanager.cs: Do not use try/catch, instead report a regular
17226 (GetPointerType, GetReferenceType): These methods provide
17227 mechanisms to obtain the T* and T& from a T. We had the code
17228 previously scattered around the code base, and it also used
17229 TypeManager.LookupType that would go through plenty of caches.
17230 This one goes directly to the type source.
17232 In some places we did the Type.GetType followed by
17233 ModuleBuilder.GetType, but not in others, so this unifies the
17234 processing as well.
17236 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
17237 statements now that we have namespace information.
17239 * typemanager.cs (IsNamespace): New method, returns whether the
17240 string presented is a namespace or not.
17242 (ComputeNamespaces): New public entry point, computes the list of
17243 available namespaces, using the GetNamespaces API call in Mono, or
17244 the slower version in MS.NET.
17246 Now before we start the semantic analysis phase, we have a
17247 complete list of namespaces including everything that the user has
17250 Deleted old code to cache namespaces in .nsc files.
17252 2003-04-17 Miguel de Icaza <miguel@ximian.com>
17254 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
17255 class/struct location definition Location for the implicit
17256 constructor location.
17258 (Operator.Define): Use the location of the operator for the
17259 implicit Method definition.
17261 (Constructor.Emit): use the constructor location for the implicit
17262 base initializer constructor.
17264 * ecore.cs: Remove ITypeExpression. This interface is now gone,
17265 and the Expression class now contains two new methods:
17267 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
17268 isolate type lookup from the rest of the resolution process.
17270 Since we use Expressions to hold type definitions due to the way
17271 we parse the input we have historically overloaded Resolve to
17272 perform the Type lookups if a special flag is passed. Now this is
17273 eliminated and two methods take their place.
17275 The differences in the two methods between xStep and xTerminal is
17276 that xStep is involved in our current lookup system that uses
17277 SimpleNames to compose a name, while xTerminal is used just to
17278 catch the case where the simplename lookup failed.
17280 2003-04-16 Miguel de Icaza <miguel@ximian.com>
17282 * expression.cs (ResolveMemberAccess): Remove redundant code.
17283 TypeExpr expressions are always born fully resolved.
17285 * interface.cs (PopulateMethod): Do not lookup the types twice.
17286 We were doing it once during SemanticAnalysis and once during
17289 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
17290 in local variable type definitions, were being returned as a
17291 SimpleName (we decomposed everything into a string), that is
17292 because primary_expression was being used instead of a type in the
17293 grammar (reduce/reduce conflicts).
17295 The part that was wrong is that we converted the expression into a
17296 string (an oversimplification in one hand, compounded with primary
17297 expressions doing string concatenation).
17303 Would return "A.B.C[]" as a SimpleName. This stopped things like
17304 using clauses from working on this particular context. And a type
17305 was being matched directly against "A.B.C[]".
17307 We now use the correct approach, and allow for ComposedCast to be
17308 part of the unary expression. So the "A.B.C []" become a composed
17309 cast of "A.B.C" (as a nested group of MemberAccess with a
17310 SimpleName at the end) plus the rank composition "[]".
17314 2003-04-10 Miguel de Icaza <miguel@ximian.com>
17316 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
17317 for the access level checking.
17319 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
17320 `TypeContainer container', because I kept getting confused when I
17321 was debugging this code.
17323 * expression.cs (Indexers): Instead of tracking getters/setters,
17324 we now track them in parallel. We create one arraylist less, but
17325 most importantly it is possible now for the LValue code to find a
17326 matching get for a set.
17328 (IndexerAccess.DoResolveLValue): Update the code.
17329 GetIndexersForType has been modified already to extract all the
17330 indexers from a type. The code assumed it did not.
17332 Also make the code set the correct return type for the indexer.
17333 This was fixed a long time ago for properties, but was missing for
17334 indexers. It used to be void_type.
17336 (Binary.Emit): Test first for doubles instead of
17337 floats, as they are more common.
17339 (Binary.EmitBranchable): Use the .un version of the branch opcodes
17340 when dealing with floats and the <=, >= operators. This fixes bug
17343 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
17344 to load the array value by emitting a load on the foreach variable
17345 type. This was incorrect.
17347 We now emit the code to load an element using the the array
17348 variable type, and then we emit the conversion operator.
17352 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
17354 * attribute.cs: Avoid allocation of ArrayLists in the common case.
17356 2003-04-09 Miguel de Icaza <miguel@ximian.com>
17358 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
17359 test for protection before we test for signatures.
17361 (MethodSignature.ToString): implement.
17363 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
17364 to the case where we reduced into a LongConstant.
17366 * decl.cs (CheckAccessLevel): If the type is an array, we can not
17367 depend on whether the information is acurrate, because the
17368 Microsoft runtime will always claim that the array type is public,
17369 regardless of the real state.
17371 If the type is a pointer, another problem happens: the type is
17372 reported as non-public in Microsoft.
17374 In both cases we have to call CheckAccessLevel recursively with
17375 the underlying type as the argument to be tested.
17377 2003-04-08 Miguel de Icaza <miguel@ximian.com>
17379 * assign.cs (Assign.Emit): If we are dealing with a compound
17380 assignment expression, we should use the code path that stores the
17381 intermediate result in a temporary value. This fixes #40903.
17383 *expression.cs (Indirection.ToString): Provide ToString method for
17386 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
17388 * class.cs: Null out fields holding references to Block objects so
17389 they can be garbage collected.
17391 * expression.cs (OverloadResolve): Remove unused local.
17393 2003-04-07 Martin Baulig <martin@ximian.com>
17395 * codegen.cs (EmitContext.CurrentFile): New public field.
17396 (EmitContext.Mark): Use the CurrentFile to check whether the
17397 location is in the correct file.
17398 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
17400 2003-04-07 Martin Baulig <martin@ximian.com>
17402 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
17404 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
17405 location. [FIXME: The location argument which gets passed to this
17406 method is sometimes wrong!]
17408 2003-04-07 Nick Drochak <ndrochak@gol.com>
17410 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
17412 2003-04-07 Miguel de Icaza <miguel@ximian.com>
17414 * expression.cs (Indirection.EmitAssign): We were using the
17415 temporary, but returning immediately instead of continuing the
17418 2003-04-06 Martin Baulig <martin@ximian.com>
17420 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
17421 if it's a nested child, but also deriving from the outer class.
17424 * typemanager.cs (IsNestedChildOf): Make this work if it's a
17425 nested child, but also deriving from the outer class. See
17427 (FilterWithClosure): We may access private members of the outer
17428 class if we're a nested child and deriving from the outer class.
17429 (RealMemberLookup): Only set `closure_private_ok' if the
17430 `original_bf' contained BindingFlags.NonPublic.
17432 2003-04-05 Martin Baulig <martin@ximian.com>
17434 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
17436 2003-04-02 Miguel de Icaza <miguel@ximian.com>
17438 * class.cs (Event.Define): Do not allow abstract events to have
17441 2003-04-01 Miguel de Icaza <miguel@ximian.com>
17443 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
17444 block in event declarations.
17446 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
17447 value type, get its address.
17449 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
17450 leaving a class on the stack instead of a boolean value (int
17451 0/1). Change the code so we compare against null, and then the
17452 result against zero.
17454 * class.cs (TypeContainer.GetClassBases): We were checking for the
17455 parent class being sealed too late.
17457 * expression.cs (Binary.Emit): For <= and >= when dealing with
17458 floating point values, use cgt.un and clt.un instead of cgt and
17461 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
17463 * statement.cs: Apply the same optimization as MS: skip the
17464 GetEnumerator returning an IEnumerator, and use the one returning a
17465 CharEnumerator instead. This allows us to avoid the try-finally block
17468 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
17470 * cs-parser.jay: Attributes cannot be applied to
17471 namespaces. Fixes #40473
17473 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17476 (Add*): check if the name is valid using the full name for constants,
17477 fields, properties and events.
17479 2003-03-28 Miguel de Icaza <miguel@ximian.com>
17481 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
17482 char constants to be part of the enumeration.
17484 * expression.cs (Conditional.DoResolve): Add support for operator
17485 true. Implements the missing functionality from 14.12
17487 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
17488 operator true/false as required by the spec.
17490 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
17491 implicit conversion to boolean.
17493 * statement.cs (Statement.ResolveBoolean): A boolean expression is
17494 also one where the type implements `operator true'.
17496 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
17497 get an expression that will invoke operator true based on an
17500 (GetConversionOperators): Removed the hack that called op_True
17503 (Expression.ResolveBoolean): Move this from Statement.
17505 2003-03-17 Miguel de Icaza <miguel@ximian.com>
17507 * ecore.cs (FieldExpr): do not allow initialization of initonly
17508 fields on derived classes
17510 2003-03-13 Martin Baulig <martin@ximian.com>
17512 * statement.cs (Block.Emit): Call ig.BeginScope() and
17513 ig.EndScope() when compiling with debugging info; call
17514 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
17516 2003-03-08 Miguel de Icaza <miguel@ximian.com>
17518 * expression.cs (Indexers): Do not construct immediately, allow
17519 for new members to be appended as we go. Fixes 38143
17521 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17523 * expression.cs: save/restore context when resolving an unchecked
17526 2003-03-05 Miguel de Icaza <miguel@ximian.com>
17528 * cfold.cs: Catch division by zero in modulus operator during
17531 2003-03-03 Miguel de Icaza <miguel@ximian.com>
17533 * interface.cs (Interface.DefineMembers): Avoid defining members
17536 2003-02-27 Miguel de Icaza <miguel@ximian.com>
17538 * driver.cs: handle the +/- options for -noconfig
17540 * statement.cs (Unckeched.Resolve): Also track the state of
17541 unchecked in the Resolve phase.
17543 2003-02-27 Martin Baulig <martin@ximian.com>
17545 * ecore.cs (Expression.MemberLookup): Don't create a
17546 MethodGroupExpr for something which is not a method. Fixes #38291.
17548 2003-02-25 Miguel de Icaza <miguel@ximian.com>
17550 * class.cs (MemberBase.CheckParameters): Also check that the type
17551 is unmanaged if it is a pointer.
17553 * expression.cs (SizeOf.Resolve): Add location information.
17555 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
17556 a managed type is declared.
17558 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
17559 parameter modifiers as well. Fixes bug 38606
17561 * class.cs: Very sad. Am backing out the speed up changes
17562 introduced by the ArrayList -> Array in the TypeContainer, as they
17563 were not actually that much faster, and introduced a bug (no error
17564 reports on duplicated methods).
17566 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
17567 source first, this will guarantee that we have a valid expression
17568 before calling in lower levels functions that will require a
17569 resolved object. Then use this original_source in the
17570 target.ResolveLValue instead of the original source that was
17573 Another change. Use target.Resolve instead of LValueResolve.
17574 Although we are resolving for LValues, we will let the Assign code
17575 take care of that (it will be called again from Resolve). This
17576 basically allows code like this:
17578 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
17579 class Y { void A (X x) { x [0] += o; }
17581 The problem was that the indexer was trying to resolve for
17582 set_Item (idx, object o) and never finding one. The real set_Item
17583 was set_Item (idx, X). By delaying the process we get the right
17588 2003-02-23 Martin Baulig <martin@ximian.com>
17590 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
17591 while calling DoEmit ().
17593 * codegen.cs (EmitContext.Mark): Don't mark locations in other
17594 source files; if you use the #line directive inside a method, the
17595 compiler stops emitting line numbers for the debugger until it
17596 reaches the end of the method or another #line directive which
17597 restores the original file.
17599 2003-02-23 Martin Baulig <martin@ximian.com>
17601 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
17603 2003-02-23 Martin Baulig <martin@ximian.com>
17605 * statement.cs (Block.AddChildVariableNames): We need to call this
17606 recursively, not just for our immediate children.
17608 2003-02-23 Martin Baulig <martin@ximian.com>
17610 * class.cs (Event.Define): Always make the field private, like csc does.
17612 * typemanager.cs (TypeManager.RealMemberLookup): Make events
17613 actually work, fixes bug #37521.
17615 2003-02-23 Miguel de Icaza <miguel@ximian.com>
17617 * delegate.cs: When creating the various temporary "Parameters"
17618 classes, make sure that we call the ComputeAndDefineParameterTypes
17619 on those new parameters (just like we do with the formal ones), to
17620 allow them to be resolved in the context of the DeclSpace.
17622 This fixes the bug that Dick observed in Bugzilla #38530.
17624 2003-02-22 Miguel de Icaza <miguel@ximian.com>
17626 * expression.cs (ResolveMemberAccess): When resolving a constant,
17627 do not attempt to pull a constant if the value was not able to
17628 generate a valid constant.
17630 * const.cs (LookupConstantValue): Do not report more errors than required.
17632 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17634 * expression.cs: fixes bug #38328.
17636 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17638 * class.cs: Changed all the various members that can be part of a
17639 class from being an ArrayList to be an Array of the right type.
17640 During the DefineType type_list, interface_list, delegate_list and
17641 enum_list are turned into types, interfaces, delegates and enums
17644 And during the member population, indexer_list, event_list,
17645 constant_list, field_list, instance_constructor_list, method_list,
17646 operator_list and property_list are turned into their real arrays.
17648 Although we could probably perform this operation earlier, for
17649 good error reporting we need to keep the lists and remove the
17650 lists for longer than required.
17652 This optimization was triggered by Paolo profiling the compiler
17653 speed on the output of `gen-sample-program.pl' perl script.
17655 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
17656 not crash in methods like MemberLookupFailed that use this field.
17658 This problem arises when the compiler fails to resolve a type
17659 during interface type definition for example.
17661 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17663 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
17664 inherit from System.Object, so we have to stop at null, not only
17665 when reaching System.Object.
17667 2003-02-17 Miguel de Icaza <miguel@ximian.com>
17669 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
17670 DeclaredOnly because the parent indexer might have had a different
17671 name, but did not loop until the top of the hierarchy was reached.
17673 The problem this one fixes is 35492: when a class implemented an
17674 indexer from an interface, we were getting the interface method
17675 (which was abstract) and we were flagging an error (can not invoke
17678 This also keeps bug 33089 functioning, and test-148 functioning.
17680 * typemanager.cs (IsSpecialMethod): The correct way of figuring
17681 out if a method is special is to see if it is declared in a
17682 property or event, or whether it is one of the predefined operator
17683 names. This should fix correctly #36804.
17685 2003-02-15 Miguel de Icaza <miguel@ximian.com>
17687 The goal here is to remove the dependency on EmptyCast.Peel ().
17688 Killing it completely.
17690 The problem is that currently in a number of places where
17691 constants are expected, we have to "probe" for an EmptyCast, and
17692 Peel, which is not the correct thing to do, as this will be
17693 repetitive and will likely lead to errors.
17695 The idea is to remove any EmptyCasts that are used in casts that
17696 can be reduced to constants, so we only have to cope with
17699 This bug hunt was triggered by Bug 37363 and the desire to remove
17700 the duplicate pattern where we were "peeling" emptycasts to check
17701 whether they were constants. Now constants will always be
17704 * ecore.cs: Use an enumconstant here instead of wrapping with
17707 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
17708 throwing me off. By handling this we can get rid of a few hacks.
17710 * statement.cs (Switch): Removed Peel() code.
17712 2003-02-14 Miguel de Icaza <miguel@ximian.com>
17714 * class.cs: Location information for error 508
17716 * expression.cs (New.DoResolve): Add a guard against double
17717 resolution of an expression.
17719 The New DoResolve might be called twice when initializing field
17720 expressions (see EmitFieldInitializers, the call to
17721 GetInitializerExpression will perform a resolve on the expression,
17722 and later the assign will trigger another resolution
17724 This leads to bugs (#37014)
17726 * delegate.cs: The signature for EndInvoke should contain any ref
17727 or out parameters as well. We were not doing this in the past.
17729 * class.cs (Field.Define): Do not overwrite the type definition
17730 inside the `volatile' group. Turns out that volatile enumerations
17731 were changing the type here to perform a validity test, which
17734 2003-02-12 Miguel de Icaza <miguel@ximian.com>
17736 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
17737 and structs, we do not want to load the instance variable
17739 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
17740 enum_type has to be handled like an object reference (implicit
17741 conversions exists from this to object), but the regular IsClass
17742 and IsValueType tests will never return true for this one.
17744 Also we use TypeManager.IsValueType instead of type.IsValueType,
17745 just for consistency with the rest of the code (this is only
17746 needed if we ever use the construct exposed by test-180.cs inside
17747 corlib, which we dont today).
17749 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
17751 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
17754 2003-02-09 Martin Baulig <martin@ximian.com>
17756 * namespace.cs (Namespace..ctor): Added SourceFile argument.
17757 (Namespace.DefineNamespaces): New static public method; this is
17758 called when we're compiling with debugging to add all namespaces
17759 to the symbol file.
17761 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
17762 pass it to the Namespace's .ctor.
17764 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
17765 and MethodBase arguments; pass the namespace ID to the symwriter;
17766 pass the MethodBase instead of the token to the symwriter.
17767 (SymbolWriter.DefineNamespace): New method to add a namespace to
17770 2003-02-09 Martin Baulig <martin@ximian.com>
17772 * symbolwriter.cs: New file. This is a wrapper around
17773 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
17774 methods here in near future.
17776 2003-02-09 Martin Baulig <martin@ximian.com>
17778 * codegen.cs (EmitContext.Mark): Just pass the arguments to
17779 ILGenerator.MarkSequencePoint() which are actually used by the
17782 2003-02-09 Martin Baulig <martin@ximian.com>
17784 * location.cs (SourceFile): New public sealed class. This
17785 contains the name and an index which is used in the location's token.
17786 (Location): Reserve an appropriate number of bits in the token for
17787 the source file instead of walking over that list, this gives us a
17788 really huge performance improvement when compiling with debugging.
17790 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
17791 `SourceFile' argument instead of a string.
17792 (Driver.ProcessFile): Add all the files via Location.AddFile(),
17793 but don't parse/tokenize here, we need to generate the list of all
17794 source files before we do that.
17795 (Driver.ProcessFiles): New static function. Parses/tokenizes all
17798 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
17799 instead of a string.
17801 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
17804 2003-02-09 Martin Baulig <martin@ximian.com>
17806 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
17807 filename on `#line default'.
17809 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
17811 * statement.cs: don't clear the pinned var when the fixed statement
17812 returns from the method (fixes bug#37752).
17814 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
17816 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
17819 2003-02-07 Martin Baulig <martin@ximian.com>
17821 * driver.cs: Removed the `--debug-args' command line argument.
17823 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
17824 automatically by the AsssemblyBuilder.
17825 (CodeGen.InitializeSymbolWriter): We don't need to call any
17826 initialization function on the symbol writer anymore. This method
17827 doesn't take any arguments.
17829 2003-02-03 Miguel de Icaza <miguel@ximian.com>
17831 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
17832 from referenced assemblies as well.
17834 2003-02-02 Martin Baulig <martin@ximian.com>
17836 * class.cs (MethodData.Emit): Generate debugging info for external methods.
17838 2003-02-02 Martin Baulig <martin@ximian.com>
17840 * class.cs (Constructor.Emit): Open the symbol writer before
17841 emitting the constructor initializer.
17842 (ConstructorInitializer.Emit): Call ec.Mark() to allow
17843 single-stepping through constructor initializers.
17845 2003-01-30 Miguel de Icaza <miguel@ximian.com>
17847 * class.cs: Handle error 549: do not allow virtual methods in
17850 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
17852 * decl.cs: Check access levels when resolving types
17854 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
17856 * statement.cs: Add parameters and locals set in catch blocks that might
17857 return to set vector
17859 2003-01-29 Miguel de Icaza <miguel@ximian.com>
17861 * class.cs (Operator): Set the SpecialName flags for operators.
17863 * expression.cs (Invocation.DoResolve): Only block calls to
17864 accessors and operators on SpecialName methods.
17866 (Cast.TryReduce): Handle conversions from char constants.
17869 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
17871 * statement.cs: small memory and time optimization in FlowBranching.
17873 2003-01-28 Pedro Mart <yoros@wanadoo.es>
17875 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
17876 problem that the last fix but in the other sid (Set).
17878 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
17879 access when there is no indexer in the hierarchy.
17881 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
17883 * class.cs: Combine some if statements.
17885 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17887 * driver.cs: fixed bug #37187.
17889 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
17891 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
17892 any indexer, it's needed to build a list with all the indexers in the
17893 hierarchy (AllGetters), else we have problems. Fixes #35653.
17895 2003-01-23 Miguel de Icaza <miguel@ximian.com>
17897 * class.cs (MethodData.Define): It is wrong for an interface
17898 implementation to be static in both cases: explicit and implicit.
17899 We were only handling this in one case.
17901 Improve the if situation there to not have negations.
17903 * class.cs (Field.Define): Turns out that we do not need to check
17904 the unsafe bit on field definition, only on usage. Remove the test.
17906 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17908 * driver.cs: use assembly.Location instead of Codebase (the latest
17909 patch made mcs fail when using MS assemblies).
17911 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
17913 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
17914 get the path to *corlib.dll.
17916 2003-01-21 Nick Drochak <ndrochak@gol.com>
17920 * typemanager.cs: Remove compiler warnings
17922 2003-01-20 Duncan Mak <duncan@ximian.com>
17924 * AssemblyInfo.cs: Bump the version number to 0.19.
17926 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17928 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
17930 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
17932 * class.cs (Constructor::Emit): Emit debugging info for constructors.
17934 2003-01-17 Miguel de Icaza <miguel@ximian.com>
17936 * cs-parser.jay: Small fix: we were not comparing the constructor
17937 name correctly. Thanks to Zoltan for the initial pointer.
17939 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
17941 * cs-tokenizer.cs: Set file name when specified with #line
17943 2003-01-15 Miguel de Icaza <miguel@ximian.com>
17945 * cs-parser.jay: Only perform the constructor checks here if we
17946 are named like the class; This will help provider a better
17947 error. The constructor path is taken when a type definition is
17948 not found, but most likely the user forgot to add the type, so
17949 report that rather than the constructor error.
17951 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
17953 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
17956 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17958 * cs-parser.jay: Add cleanup call.
17960 2003-01-13 Duncan Mak <duncan@ximian.com>
17962 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
17963 consistent with other methods.
17965 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17967 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
17969 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
17971 * attribute.cs: only set GuidAttr to true when we have a
17974 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17978 * typemanager.cs: fixes to allow mcs compile corlib with the new
17979 Type.IsSubclassOf fix.
17981 2003-01-08 Miguel de Icaza <miguel@ximian.com>
17983 * expression.cs (LocalVariableReference.DoResolve): Classify a
17984 constant as a value, not as a variable. Also, set the type for
17987 * cs-parser.jay (fixed_statement): take a type instead of a
17988 pointer_type, so we can produce a better error message later.
17990 * statement.cs (Fixed.Resolve): Flag types that are not pointers
17993 (For.DoEmit): Make inifinite loops have a
17994 non-conditional branch back.
17996 (Fixed.DoEmit): First populate the pinned variables, then emit the
17997 statement, then clear the variables. Before I was emitting the
17998 code once for each fixed piece.
18001 2003-01-08 Martin Baulig <martin@ximian.com>
18003 * statement.cs (FlowBranching.MergeChild): A break in a
18004 SWITCH_SECTION does not leave a loop. Fixes #36155.
18006 2003-01-08 Martin Baulig <martin@ximian.com>
18008 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
18009 lives in the same number space than `param_map'. Fixes #36154.
18011 2003-01-07 Miguel de Icaza <miguel@ximian.com>
18013 * cs-parser.jay (constructor_declaration): Set the
18014 Constructor.ModFlags before probing for it. This makes the
18015 compiler report 514, 515 and 132 (the code was there, but got
18018 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
18019 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
18020 (GotoCase.Resolve): Set `Returns' to ALWAYS.
18022 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
18024 * enum.cs: create the enum static fields using the enum type.
18026 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
18028 * class.cs: don't try to create the ParamBuilder for the return
18029 type if it's not needed (and handle it breaking for the ms runtime
18032 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
18034 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
18036 2002-12-29 Miguel de Icaza <miguel@ximian.com>
18038 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
18039 the command. This showed up while compiling the JANET source
18040 code, which used \r as its only newline separator.
18042 2002-12-28 Miguel de Icaza <miguel@ximian.com>
18044 * class.cs (Method.Define): If we are an operator (because it
18045 reuses our code), then set the SpecialName and HideBySig. #36128
18047 2002-12-22 Miguel de Icaza <miguel@ximian.com>
18049 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
18050 exception, report error 120 `object reference required'.
18052 * driver.cs: Add --pause option, used during to measure the size
18053 of the process as it goes with --timestamp.
18055 * expression.cs (Invocation.DoResolve): Do not allow methods with
18056 SpecialName to be invoked.
18058 2002-12-21 Miguel de Icaza <miguel@ximian.com>
18060 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
18061 number before adding it.
18063 2002-12-21 Ravi Pratap <ravi@ximian.com>
18065 * ecore.cs (StandardImplicitConversion): When in an unsafe
18066 context, we allow conversion between void * to any other pointer
18067 type. This fixes bug #35973.
18069 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
18071 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
18072 is not thrown when extensionless outputs are used
18074 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18076 * rootcontext.cs: fixed compilation of corlib.
18078 2002-12-19 Miguel de Icaza <miguel@ximian.com>
18080 * attribute.cs (Attributes.Contains): Add new method.
18082 * class.cs (MethodCore.LabelParameters): if the parameter is an
18083 `out' parameter, check that no attribute `[In]' has been passed.
18085 * enum.cs: Handle the `value__' name in an enumeration.
18087 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
18089 * decl.cs: Added special case to allow overrides on "protected
18092 2002-12-18 Ravi Pratap <ravi@ximian.com>
18094 * attribute.cs (Attributes.AddAttributeSection): Rename to this
18095 since it makes much more sense.
18097 (Attributes.ctor): Don't require a Location parameter.
18099 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
18101 * attribute.cs (ApplyAttributes): Remove extra Location parameters
18102 since we already have that information per attribute.
18104 * everywhere : make appropriate changes.
18106 * class.cs (LabelParameters): Write the code which actually
18107 applies attributes to the return type. We can't do this on the MS
18108 .NET runtime so we flag a warning in the case an exception is
18111 2002-12-18 Miguel de Icaza <miguel@ximian.com>
18113 * const.cs: Handle implicit null conversions here too.
18115 2002-12-17 Ravi Pratap <ravi@ximian.com>
18117 * class.cs (MethodCore.LabelParameters): Remove the extra
18118 Type [] parameter since it is completely unnecessary. Instead
18119 pass in the method's attributes so that we can extract
18120 the "return" attribute.
18122 2002-12-17 Miguel de Icaza <miguel@ximian.com>
18124 * cs-parser.jay (parse): Use Report.Error to flag errors instead
18125 of ignoring it and letting the compile continue.
18127 * typemanager.cs (ChangeType): use an extra argument to return an
18128 error condition instead of throwing an exception.
18130 2002-12-15 Miguel de Icaza <miguel@ximian.com>
18132 * expression.cs (Unary.TryReduce): mimic the code for the regular
18133 code path. Perform an implicit cast in the cases where we can
18134 implicitly convert to one of the integral types, and then reduce
18135 based on that constant. This fixes bug #35483.
18137 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18139 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
18141 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18143 * namespace.cs: fixed bug #35489.
18145 2002-12-12 Miguel de Icaza <miguel@ximian.com>
18147 * class.cs: Remove some dead code.
18149 * cs-parser.jay: Estimate the number of methods needed
18150 (RootContext.MethodCount);
18152 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
18153 numbers instead of StringBuilders.
18155 * support.cs (PtrHashtable): Add constructor with initial size;
18156 We can now reduce reallocations of the method table.
18158 2002-12-10 Ravi Pratap <ravi@ximian.com>
18160 * attribute.cs (ApplyAttributes): Keep track of the emitted
18161 attributes on a per-target basis. This fixes bug #35413.
18163 2002-12-10 Miguel de Icaza <miguel@ximian.com>
18165 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
18166 default to the Windows 1252 encoding.
18168 (UnixParseOption): Support version, thanks to Alp for the missing
18171 * AssemblyInfo.cs: Add nice assembly information.
18173 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
18176 * cs-parser.jay: Allow a trailing comma before the close bracked
18177 in the attribute_section production.
18179 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
18180 address of the instance was being taken, I will take this out,
18181 because we take the address of the object immediately here.
18183 2002-12-09 Ravi Pratap <ravi@ximian.com>
18185 * typemanager.cs (AreMultipleAllowed): Take care of the most
18186 obvious case where attribute type is not in the current assembly -
18189 2002-12-08 Miguel de Icaza <miguel@ximian.com>
18191 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
18192 definitions, instead of doing that afterwards.
18194 Also we use a nice little hack, depending on the constructor, we
18195 know if we are a "composed" name or a simple name. Hence, we
18196 avoid the IndexOf test, and we avoid
18198 * codegen.cs: Add code to assist in a bug reporter to track down
18199 the source of a compiler crash.
18201 2002-12-07 Ravi Pratap <ravi@ximian.com>
18203 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
18204 types have been emitted for a given element and flag an error
18205 if something which does not have AllowMultiple set is used more
18208 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
18209 attribute types and their corresponding AllowMultiple properties
18211 (AreMultipleAllowed): Check the property for a given type.
18213 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
18214 property in the case we have a TypeContainer.
18216 (Attributes.AddAttribute): Detect duplicates and just skip on
18217 adding them. This trivial fix catches a pretty gross error in our
18218 attribute emission - global attributes were being emitted twice!
18220 Bugzilla bug #33187 is now fixed.
18222 2002-12-06 Miguel de Icaza <miguel@ximian.com>
18224 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
18225 instead of pp_and).
18227 * expression.cs (Binary.ResolveOperator): I can only use the
18228 Concat (string, string, string) and Concat (string, string,
18229 string, string) if the child is actually a concatenation of
18232 2002-12-04 Miguel de Icaza <miguel@ximian.com>
18234 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
18235 context where we need a 2-character lookahead.
18237 * pending.cs (PendingImplementation): Rework so we can keep track
18238 of interface types all the time, and flag those which were
18239 implemented by parents as optional.
18241 2002-12-03 Miguel de Icaza <miguel@ximian.com>
18243 * expression.cs (Binary.ResolveOperator): Use
18244 String.Concat(string,string,string) or
18245 String.Concat(string,string,string,string) when possible.
18247 * typemanager: More helper methods.
18250 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
18252 * pending.cs: remove the bogus return from GetMissingInterfaces()
18253 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
18255 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18257 * namespace.cs: avoid duplicated 'using xxx' being added to
18258 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
18259 when we get more than one 'using' statement for the same namespace.
18260 Report a CS0105 warning for it.
18262 2002-11-30 Miguel de Icaza <miguel@ximian.com>
18264 * cs-tokenizer.cs (consume_identifier): use read directly, instead
18265 of calling getChar/putback, uses internal knowledge of it.
18267 (xtoken): Reorder tokenizer so most common patterns are checked
18268 first. This reduces the compilation time in another 5% (from 8.11s
18269 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
18271 The parsing time is 22% of the compilation in mcs, and from that
18272 64% is spent on the tokenization process.
18274 I tried using a binary search for keywords, but this is slower
18275 than the hashtable. Another option would be to do a couple of
18278 * Not use a StringBuilder, instead use an array of chars,
18279 with a set value. Notice that this way we could catch
18280 the 645 error without having to do it *afterwards*.
18282 * We could write a hand-parser to avoid the hashtable
18283 compares altogether.
18285 The identifier consumption process takes 37% of the tokenization
18286 time. Another 15% is spent on is_number. 56% of the time spent
18287 on is_number is spent on Int64.Parse:
18289 * We could probably choose based on the string length to
18290 use Int32.Parse or Int64.Parse and avoid all the 64-bit
18293 Another 3% is spend on wrapping `xtoken' in the `token' function.
18295 Handle 0xa0 as whitespace (#34752)
18297 2002-11-26 Miguel de Icaza <miguel@ximian.com>
18299 * typemanager.cs (IsCLRType): New routine to tell whether a type
18300 is one of the builtin types.
18302 Maybe it needs to use TypeCodes to be faster. Maybe we could use
18303 typecode in more places instead of doing pointer comparissions.
18304 We could leverage some knowledge about the way the typecodes are
18307 New code to cache namespaces in assemblies, it is currently not
18308 invoked, to be used soon.
18310 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
18312 * expression.cs (Binary.ResolveOperator): specially handle
18313 strings, and do not perform user-defined operator overloading for
18316 2002-11-24 Miguel de Icaza <miguel@ximian.com>
18318 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
18319 internalcall as it is a pretty simple operation; Avoid whenever
18320 possible to call Char.IsLetter.
18322 (consume_identifier): Cut by half the number of
18323 hashtable calls by merging the is_keyword and GetKeyword behavior.
18325 Do not short-circuit, because if we do, we
18326 report errors (ie, #if false && true would produce an invalid
18330 2002-11-24 Martin Baulig <martin@ximian.com>
18332 * expression.cs (Cast.TryReduce): If we're in checked syntax,
18333 check constant ranges and report a CS0221. Fixes #33186.
18335 2002-11-24 Martin Baulig <martin@ximian.com>
18337 * cs-parser.jay: Make this work for uninitialized variable
18338 declarations in the `for' initializer. Fixes #32416.
18340 2002-11-24 Martin Baulig <martin@ximian.com>
18342 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
18343 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
18345 2002-11-24 Martin Baulig <martin@ximian.com>
18347 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
18348 argument; if true, we also check for user-defined conversions.
18349 This is only needed if both arguments are of a user-defined type.
18350 Fixes #30443, added test-175.cs.
18351 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
18353 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
18355 2002-11-24 Martin Baulig <martin@ximian.com>
18357 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
18358 function to get the store opcode.
18359 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
18360 only emit the Ldelema if the store opcode is Stobj. You must run
18361 both test-34 and test-167 to test this. Fixes #34529.
18363 2002-11-23 Martin Baulig <martin@ximian.com>
18365 * ecore.cs (Expression.MemberLookup): Added additional
18366 `qualifier_type' argument which is used when we're being called
18367 from MemberAccess.DoResolve() and null if we're called from a
18369 (Expression.MemberLookupFailed): New method to report errors; this
18370 does the CS1540 check and reports the correct error message.
18372 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
18373 argument for the CS1540 check and redone the way how we're dealing
18374 with private members. See the comment in the source code for details.
18375 (FilterWithClosure): Reverted this back to revision 1.197; renamed
18376 `closure_start_type' to `closure_qualifier_type' and check whether
18377 it's not null. It was not this filter being broken, it was just
18378 being called with the wrong arguments.
18380 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
18381 and pass it the correct `qualifier_type'; this also does the error
18384 2002-11-22 Miguel de Icaza <miguel@ximian.com>
18386 * expression.cs (Invocation.EmitParams): If the we are dealing
18387 with a non-built-in value type, load its address as well.
18389 (ArrayCreation): Use a a pretty constant instead
18390 of the hardcoded value 2. Use 6 instead of 2 for the number of
18391 static initializers.
18393 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
18394 because they are not really value types, just glorified integers.
18396 * driver.cs: Do not append .exe, the CSC compiler does not do it.
18398 * ecore.cs: Remove redundant code for enumerations, make them use
18399 the same code path as everything else, fixes the casting issue
18400 with enumerations in Windows.Forms.
18402 * attribute.cs: Do only cast to string if it is a string, the
18403 validation happens later.
18405 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
18406 people upgrade their corlibs.
18408 * ecore.cs: Oops, enumerations were not following the entire code path
18410 2002-11-21 Miguel de Icaza <miguel@ximian.com>
18412 * typemanager.cs (FilterWithClosure): Commented out the test for
18413 1540 in typemanager.cs, as it has problems when accessing
18414 protected methods from a parent class (see test-174.cs).
18416 * attribute.cs (Attribute.ValidateGuid): new method.
18417 (Attribute.Resolve): Use above.
18419 2002-11-19 Miguel de Icaza <miguel@ximian.com>
18421 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
18423 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
18424 handling for enumerations, as we only needed the TypeContainer
18425 functionality to begin with (this is required for the fix below to
18426 work for enums that reference constants in a container class for
18429 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
18431 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
18432 a valid TypeBuilder to perform lookups on.o
18434 * class.cs (InheritableMemberSignatureCompare): Use true in the
18435 call to GetGetMethod and GetSetMethod, because we are comparing
18436 the signature, and we need to get the methods *even* if they are
18439 (PropertyBase.CheckBase): ditto.
18441 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
18442 GotoCase.Resolve): Use Peel on EmpytCasts.
18444 * ecore.cs (EmptyCast): drop child, add Peel method.
18446 2002-11-17 Martin Baulig <martin@ximian.com>
18448 * ecore.cs (EmptyCast.Child): New public property.
18450 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
18451 label resolved to an EmptyCast. Fixes #34162.
18452 (GotoCase.Resolve): Likewise.
18453 (Block.EmitMeta): Likewise.
18455 2002-11-17 Martin Baulig <martin@ximian.com>
18457 * expression.cs (Invocation.BetterConversion): Prefer int over
18458 uint; short over ushort; long over ulong for integer literals.
18459 Use ImplicitConversionExists instead of StandardConversionExists
18460 since we also need to check for user-defined implicit conversions.
18461 Fixes #34165. Added test-173.cs.
18463 2002-11-16 Martin Baulig <martin@ximian.com>
18465 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
18466 with the `true' and `false' literals. Fixes #33151.
18468 2002-11-16 Martin Baulig <martin@ximian.com>
18470 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
18471 October 22nd; don't do the cs1540 check for static members.
18473 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
18474 now using our own filter here and doing the cs1540 check again.
18476 2002-11-16 Martin Baulig <martin@ximian.com>
18478 * support.cs (InternalParameters): Don't crash if we don't have
18479 any fixed parameters. Fixes #33532.
18481 2002-11-16 Martin Baulig <martin@ximian.com>
18483 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
18484 when looking up static methods to make this work on Windows.
18487 2002-11-16 Martin Baulig <martin@ximian.com>
18489 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
18490 a setter rather than using PropertyInfo.CanWrite.
18492 2002-11-15 Nick Drochak <ndrochak@gol.com>
18494 * class.cs: Allow acces to block member by subclasses. Fixes build
18497 2002-11-14 Martin Baulig <martin@ximian.com>
18499 * class.cs (Constructor.Emit): Added the extern/block check.
18502 2002-11-14 Martin Baulig <martin@ximian.com>
18504 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
18505 iteration while looking for indexers, this is needed because the
18506 indexer may have a different name in our base classes. Fixed the
18507 error reporting (no indexers at all, not get accessor, no
18508 overloaded match). Fixes bug #33089.
18509 (IndexerAccess.DoResolveLValue): Likewise.
18511 2002-11-14 Martin Baulig <martin@ximian.com>
18513 * class.cs (PropertyBase.CheckBase): Make this work for multiple
18514 indexers. Fixes the first part of bug #33089.
18515 (MethodSignature.InheritableMemberSignatureCompare): Added support
18518 2002-11-13 Ravi Pratap <ravi@ximian.com>
18520 * attribute.cs (Attribute.Resolve): Catch the
18521 NullReferenceException and report it since it isn't supposed to
18524 2002-11-12 Miguel de Icaza <miguel@ximian.com>
18526 * expression.cs (Binary.EmitBranchable): Also handle the cases for
18527 LogicalOr and LogicalAnd that can benefit from recursively
18528 handling EmitBranchable. The code now should be nice for Paolo.
18530 2002-11-08 Miguel de Icaza <miguel@ximian.com>
18532 * typemanager.cs (LookupType): Added a negative-hit hashtable for
18533 the Type lookups, as we perform quite a number of lookups on
18534 non-Types. This can be removed once we can deterministically tell
18535 whether we have a type or a namespace in advance.
18537 But this might require special hacks from our corlib.
18541 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
18542 and double which avoids a conversion from an integer to a double.
18544 * expression.cs: tiny optimization, avoid calling IsConstant,
18545 because it effectively performs the lookup twice.
18547 2002-11-06 Miguel de Icaza <miguel@ximian.com>
18549 But a bogus return here to keep the semantics of the old code
18550 until the Mono runtime is fixed.
18552 * pending.cs (GetMissingInterfaces): New method used to remove all
18553 the interfaces that are already implemented by our parent
18554 classes from the list of pending methods.
18556 * interface.cs: Add checks for calls after ResolveTypeExpr.
18558 2002-11-05 Miguel de Icaza <miguel@ximian.com>
18560 * class.cs (Class.Emit): Report warning 67: event not used if the
18561 warning level is beyond 3.
18563 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
18564 being a NullLiteral.
18566 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
18569 * class.cs (TypeContainer.GetClassBases): Cover a missing code
18570 path that might fail if a type can not be resolved.
18572 * expression.cs (Binary.Emit): Emit unsigned versions of the
18575 * driver.cs: use error 5.
18577 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
18579 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
18581 2002-11-01 Miguel de Icaza <miguel@ximian.com>
18583 * cs-parser.jay (switch_section): A beautiful patch from Martin
18584 Baulig that fixed 33094.
18586 2002-10-31 Miguel de Icaza <miguel@ximian.com>
18588 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
18589 Check whether the base is abstract and report an error if so.
18591 * expression.cs (IndexerAccess.DoResolveLValue,
18592 IndexerAccess.DoResolve): ditto.
18594 (Invocation.DoResolve): ditto.
18596 (Invocation.FullMethodDesc): Improve the report string.
18598 * statement.cs (Block): Eliminate IsVariableDefined as it is
18599 basically just a wrapper for GetVariableInfo.
18601 * ecore.cs (SimpleName): Use new
18603 * support.cs (ReflectionParamter.ParameterType): We unwrap the
18604 type, as we return the actual parameter ref/unref state on a
18607 2002-10-30 Miguel de Icaza <miguel@ximian.com>
18609 * support.cs: Return proper flags REF/OUT fixing the previous
18612 * expression.cs: Reverted last patch, that was wrong. Is_ref is
18613 not used to mean `ref' but `ref or out' in ParameterReference
18615 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
18616 full type signature instead of calling TypeManger.CSharpName
18619 * support.cs (InternalParameters.ParameterDesc): Do not compare
18620 directly to the modflags, because REF/OUT will actually be bitsets
18623 * delegate.cs (VerifyMethod): Check also the modifiers.
18625 * cs-tokenizer.cs: Fix bug where floating point values with an
18626 exponent where a sign was missing was ignored.
18628 * driver.cs: Allow multiple assemblies to be specified in a single
18631 2002-10-28 Miguel de Icaza <miguel@ximian.com>
18633 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
18634 because identifiers after a parenthesis would end up in this kind
18635 of production, and we needed to desamiguate it for having casts
18638 (UserDefinedType *) xxx
18640 2002-10-24 Miguel de Icaza <miguel@ximian.com>
18642 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
18643 we should set on the Bindingflags.NonPublic, but not turn on
18644 private_ok. private_ok controls whether a Private member is
18645 returned (this is chekced on the filter routine), while the
18646 BindingFlags.NonPublic just controls whether private/protected
18647 will be allowed. This fixes the problem part of the problem of
18648 private properties being allowed to be used in derived classes.
18650 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
18651 so we can call the children DoResolveLValue method (this will
18652 properly signal errors on lvalue assignments to base properties)
18654 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
18655 getter are null, and we have a property info, we know that this
18656 happened because the lookup failed, so we report an error 122 for
18657 protection level violation.
18659 We also silently return if setter and getter are null in the
18660 resolve functions, this condition only happens if we have flagged
18661 the error before. This is the other half of the problem.
18663 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
18664 not have accessibility information, that is why we were returning
18665 true in the filter function in typemanager.cs.
18667 To properly report 122 (property is inaccessible because of its
18668 protection level) correctly, we report this error in ResolveAccess
18669 by failing if both the setter and the getter are lacking (ie, the
18672 DoResolve and DoLResolve have been modified to check for both
18673 setter/getter being null and returning silently, the reason being
18674 that I did not want to put the knowledge about this error in upper
18677 int old = Report.Errors;
18678 x = new PropertyExpr (...);
18679 if (old != Report.Errors)
18684 So the property expr is returned, but it is invalid, so the error
18685 will be flagged during the resolve process.
18687 * class.cs: Remove InheritablePropertySignatureCompare from the
18688 class, as we no longer depend on the property signature to compute
18689 whether it is possible to implement a method or not.
18691 The reason is that calling PropertyInfo.GetGetMethod will return
18692 null (in .NET, in Mono it works, and we should change this), in
18693 cases where the Get Method does not exist in that particular
18698 class X { public virtual int A { get { return 1; } } }
18700 class Z : Y { public override int A { get { return 2; } } }
18702 Would fail in Z because the parent (Y) would not have the property
18703 defined. So we avoid this completely now (because the alternative
18704 fix was ugly and slow), and we now depend exclusively on the
18707 (PropertyBase.CheckBase): Use a method-base mechanism to find our
18708 reference method, instead of using the property.
18710 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
18711 routines are gone now.
18713 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
18714 names, they were incorrectly named.
18716 * cs-tokenizer.cs: Return are more gentle token on failure.
18718 * pending.cs (PendingImplementation.InterfaceMethod): This routine
18719 had an out-of-sync index variable, which caused it to remove from
18720 the list of pending methods the wrong method sometimes.
18722 2002-10-22 Miguel de Icaza <miguel@ximian.com>
18724 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
18725 CanWrite, because those refer to this particular instance of the
18726 property, and do not take into account the fact that we can
18727 override single members of a property.
18729 Constructor requires an EmitContext. The resolution process does
18730 not happen here, but we need to compute the accessors before,
18731 because the resolution does not always happen for properties.
18733 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
18734 subclass, before we did not update this flag, but we did update
18737 (GetAccessors): Drop this routine, as it did not work in the
18738 presence of partially overwritten set/get methods.
18740 Notice that this broke the cs1540 detection, but that will require
18743 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18747 * driver.cs: issue a warning instead of an error if we don't support
18748 debugging for the platform. Also ignore a couple of errors that may
18749 arise when trying to write the symbols. Undo my previous patch.
18751 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18753 * driver.cs: ignore /debug switch except for Unix platforms.
18755 2002-10-23 Nick Drochak <ndrochak@gol.com>
18757 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
18759 2002-10-21 Miguel de Icaza <miguel@ximian.com>
18761 * driver.cs: Do not make mcs-debug conditional, so we do not break
18762 builds that use it.
18764 * statement.cs (UsageVector.MergeChildren): I would like Martin to
18765 review this patch. But basically after all the children variables
18766 have been merged, the value of "Breaks" was not being set to
18767 new_breaks for Switch blocks. I think that it should be set after
18768 it has executed. Currently I set this to the value of new_breaks,
18769 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
18770 conservative, but I do not understand this code very well.
18772 I did not break anything in the build, so that is good ;-)
18774 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
18776 2002-10-20 Mark Crichton <crichton@gimp.org>
18778 * cfold.cs: Fixed compile blocker. Really fixed it this time.
18780 2002-10-20 Nick Drochak <ndrochak@gol.com>
18782 * cfold.cs: Fixed compile blocker.
18784 2002-10-20 Miguel de Icaza <miguel@ximian.com>
18786 * driver.cs: I was chekcing the key, not the file.
18788 2002-10-19 Ravi Pratap <ravi@ximian.com>
18790 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
18791 message that we were generating - we just need to silently return
18794 2002-10-19 Miguel de Icaza <miguel@ximian.com>
18796 * class.cs (Event.Define): Change my previous commit, as this
18797 breaks the debugger. This is a temporary hack, as it seems like
18798 the compiler is generating events incorrectly to begin with.
18800 * expression.cs (Binary.ResolveOperator): Added support for
18801 "U operator - (E x, E y)"
18803 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
18806 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
18807 init-only variables, but this path did not take into account that
18808 there might be also instance readonly variables. Correct this
18811 This fixes bug 32253
18813 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
18816 * driver.cs: Change the extension for modules to `netmodule'
18818 * cs-parser.jay: Improved slightly the location tracking for
18819 the debugger symbols.
18821 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
18822 modifiers that were specified instead of the hardcoded value
18823 (FamAndAssem). This was basically ignoring the static modifier,
18824 and others. Fixes 32429.
18826 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
18827 fixed a bug in the process (32476)
18829 * expression.cs (ArrayAccess.EmitAssign): Patch from
18830 hwang_rob@yahoo.ca that fixes bug 31834.3
18832 2002-10-18 Miguel de Icaza <miguel@ximian.com>
18834 * driver.cs: Make the module extension .netmodule.
18836 2002-10-16 Miguel de Icaza <miguel@ximian.com>
18838 * driver.cs: Report an error if the resource file is not found
18839 instead of crashing.
18841 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
18842 false, like Emit does.
18844 2002-10-16 Nick Drochak <ndrochak@gol.com>
18846 * typemanager.cs: Remove unused private member. Also reported mcs
18847 bug to report this as a warning like csc.
18849 2002-10-15 Martin Baulig <martin@gnome.org>
18851 * statement.cs (Statement.Emit): Made this a virtual method; emits
18852 the line number info and calls DoEmit().
18853 (Statement.DoEmit): New protected abstract method, formerly knows
18854 as Statement.Emit().
18856 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
18858 2002-10-11 Miguel de Icaza <miguel@ximian.com>
18860 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
18861 have fixed a remaining problem: not every AddXXXX was adding a
18862 fully qualified name.
18864 Now everyone registers a fully qualified name in the DeclSpace as
18865 being defined instead of the partial name.
18867 Downsides: we are slower than we need to be due to the excess
18868 copies and the names being registered this way.
18870 The reason for this is that we currently depend (on the corlib
18871 bootstrap for instance) that types are fully qualified, because
18872 we dump all the types in the namespace, and we should really have
18873 types inserted into the proper namespace, so we can only store the
18874 basenames in the defined_names array.
18876 2002-10-10 Martin Baulig <martin@gnome.org>
18878 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
18879 from bug #31834, see the bug report for a testcase which is
18882 2002-10-10 Martin Baulig <martin@gnome.org>
18884 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
18885 flow analysis code for this.
18887 * statement.cs (Do, While, For): Tell the flow analysis code about
18889 (FlowBranching.UsageVector): Added support for infinite loops.
18890 (Block.Resolve): Moved the dead code elimination here and use flow
18893 2002-10-09 Miguel de Icaza <miguel@ximian.com>
18895 * class.cs (Field.Define): Catch cycles on struct type
18898 * typemanager.cs (IsUnmanagedtype): Do not recursively check
18899 fields if the fields are static. We only need to check instance
18902 * expression.cs (As.DoResolve): Test for reference type.
18904 * statement.cs (Using.ResolveExpression): Use
18905 ConvertImplicitRequired, not ConvertImplicit which reports an
18907 (Using.ResolveLocalVariableDecls): ditto.
18909 * expression.cs (Binary.ResolveOperator): Report errors in a few
18910 places where we had to.
18912 * typemanager.cs (IsUnmanagedtype): Finish implementation.
18914 2002-10-08 Miguel de Icaza <miguel@ximian.com>
18916 * expression.cs: Use StoreFromPtr instead of extracting the type
18917 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
18919 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
18920 an enumeration value to a System.Enum, but System.Enum is not a
18921 value type, but an class type, so we need to box.
18923 (Expression.ConvertExplicit): One codepath could return
18924 errors but not flag them. Fix this. Fixes #31853
18926 * parameter.cs (Resolve): Do not allow void as a parameter type.
18928 2002-10-06 Martin Baulig <martin@gnome.org>
18930 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
18931 if it's a class type and not a struct. Fixes #31815.
18933 2002-10-06 Martin Baulig <martin@gnome.org>
18935 * statement.cs: Reworked the flow analysis code a bit to make it
18936 usable for dead code elimination.
18938 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18940 * cs-parser.jay: allow empty source files. Fixes bug #31781.
18942 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18944 * expression.cs (ComposedCast.DoResolveType): A quick workaround
18945 to fix the test 165, will investigate deeper.
18947 2002-10-04 Martin Baulig <martin@gnome.org>
18949 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
18950 finally blocks actually work.
18951 (Try.Resolve): We don't need to create a sibling for `finally' if
18952 there is no finally block.
18954 2002-10-04 Martin Baulig <martin@gnome.org>
18956 * class.cs (Constructor.Define): The default accessibility for a
18957 non-default constructor is private, not public.
18959 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18961 * class.cs (Constructor): Make AllowedModifiers public, add
18964 * cs-parser.jay: Perform the modifiers test here, as the
18965 constructor for the Constructor class usually receives a zero
18966 because of the way we create it (first we create, later we
18967 customize, and we were never checking the modifiers).
18969 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
18970 is a version of LookupTypeReflection that includes the type-name
18971 cache. This can be used as a fast path for functions that know
18972 the fully qualified name and are only calling into *.GetType() to
18973 obtain a composed type.
18975 This is also used by TypeManager.LookupType during its type
18978 (LookupType): We now also track the real type name, as sometimes
18979 we can get a quey for the real type name from things like
18980 ComposedCast. This fixes bug 31422.
18982 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
18983 complete type fullname, it does not have to go through the type
18984 resolution system to obtain the composed version of the type (for
18985 obtaining arrays or pointers).
18987 (Conditional.Emit): Use the EmitBoolExpression to
18988 generate nicer code, as requested by Paolo.
18990 (ArrayCreation.CheckIndices): Use the patch from
18991 hwang_rob@yahoo.ca to validate the array initializers.
18993 2002-10-03 Miguel de Icaza <miguel@ximian.com>
18995 * class.cs (ConstructorInitializer.Emit): simplify code by using
18996 Invocation.EmitCall, and at the same time, fix the bugs in calling
18997 parent constructors that took variable arguments.
18999 * ecore.cs (Expression.ConvertNumericExplicit,
19000 Expression.ImplicitNumericConversion): Remove the code that
19001 manually wrapped decimal (InternalTypeConstructor call is now gone
19004 * expression.cs (Cast.TryReduce): Also handle decimal types when
19005 trying to perform a constant fold on the type.
19007 * typemanager.cs (IsUnmanagedtype): Partially implemented.
19009 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
19010 that only turned off an error report, and did nothing else.
19012 2002-10-02 Miguel de Icaza <miguel@ximian.com>
19014 * driver.cs: Handle and ignore /fullpaths
19016 2002-10-01 Miguel de Icaza <miguel@ximian.com>
19018 * expression.cs (Binary.ResolveOperator): Catch the case where
19019 DoNumericPromotions returns true,
19021 (Binary.DoNumericPromotions): Simplify the code, and the tests.
19023 2002-09-27 Miguel de Icaza <miguel@ximian.com>
19025 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
19028 2002-09-26 Miguel de Icaza <miguel@ximian.com>
19030 * ecore.cs (ConvertNumericExplicit): It is not enough that the
19031 conversion exists, but it is also required that the conversion be
19032 performed. This manifested in "(Type64Enum) 2".
19034 * class.cs (TypeManager.AddMethod): The fix is not to change
19035 AddEnum, because that one was using a fully qualified name (every
19036 DeclSpace derivative does), but to change the AddMethod routine
19037 that was using an un-namespaced name. This now correctly reports
19038 the duplicated name.
19040 Revert patch until I can properly fix it. The issue
19041 is that we have a shared Type space across all namespaces
19042 currently, which is wrong.
19044 Options include making the Namespace a DeclSpace, and merge
19045 current_namespace/current_container in the parser.
19047 2002-09-25 Miguel de Icaza <miguel@ximian.com>
19049 * cs-parser.jay: Improve error reporting when we get a different
19050 kind of expression in local_variable_type and
19051 local_variable_pointer_type.
19053 Propagate this to avoid missleading errors being reported.
19055 * ecore.cs (ImplicitReferenceConversion): treat
19056 TypeManager.value_type as a target just like object_type. As
19061 Is valid, and needs to result in the int 1 being boxed before it
19062 is assigned to the value type v.
19064 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
19065 to validate the enumeration name.
19067 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
19068 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
19069 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
19071 * ecore.cs (TryImplicitIntConversion): When doing an
19072 implicit-enumeration-conversion, check if the type is 64-bits and
19073 perform a conversion before passing to EnumConstant.
19075 2002-09-23 Miguel de Icaza <miguel@ximian.com>
19077 * decl.cs (Error_AmbiguousTypeReference); New routine used to
19078 report ambiguous type references. Unlike the MS version, we
19079 report what the ambiguity is. Innovation at work ;-)
19081 (DeclSpace.FindType): Require a location argument to
19082 display when we display an ambiguous error.
19084 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
19086 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
19088 * expression.cs (EmitDynamicInitializers): Apply patch from
19089 hwang_rob@yahoo.ca that fixes the order in which we emit our
19092 2002-09-21 Martin Baulig <martin@gnome.org>
19094 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
19095 delegate takes no arguments.
19097 2002-09-20 Miguel de Icaza <miguel@ximian.com>
19099 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
19102 * expression.cs: Extract the underlying type.
19104 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
19106 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
19108 2002-09-19 Miguel de Icaza <miguel@ximian.com>
19110 * class.cs (TypeContainer.DefineType): We can not use the nice
19111 PackingSize with the size set to 1 DefineType method, because it
19112 will not allow us to define the interfaces that the struct
19115 This completes the fixing of bug 27287
19117 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
19118 means also structs. This fixes part of the problem.
19119 (Expresion.ImplicitReferenceConversionExists): ditto.
19121 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
19122 error if there were no errors reported during the type lookup
19123 process, to avoid duplicates or redundant errors. Without this
19124 you would get an ambiguous errors plus a type not found. We have
19125 beaten the user enough with the first error.
19127 (DeclSparce.FindType): Emit a warning if we have an ambiguous
19130 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
19131 during the resolution process, stop the lookup, this avoids
19132 repeated error reports (same error twice).
19134 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
19136 * typemanager.cs (LookupType): Redo the type lookup code to match
19137 the needs of System.Reflection.
19139 The issue is that System.Reflection requires references to nested
19140 types to begin with a "+" sign instead of a dot. So toplevel
19141 types look like: "NameSpace.TopLevelClass", and nested ones look
19142 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
19145 2002-09-19 Martin Baulig <martin@gnome.org>
19147 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
19148 says that a method always returns or always throws an exception,
19149 don't report the CS0161.
19151 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
19152 set `Returns = new_returns'.
19154 2002-09-19 Martin Baulig <martin@gnome.org>
19156 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
19157 to an enum constant, check for a CS0176.
19159 2002-09-18 Miguel de Icaza <miguel@ximian.com>
19161 * class.cs (TypeContainer.CheckPairedOperators): Now we check
19162 for operators that must be in pairs and report errors.
19164 * ecore.cs (SimpleName.DoResolveType): During the initial type
19165 resolution process, when we define types recursively, we must
19166 check first for types in our current scope before we perform
19167 lookups in the enclosing scopes.
19169 * expression.cs (MakeByteBlob): Handle Decimal blobs.
19171 (Invocation.VerifyArgumentsCompat): Call
19172 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
19173 I thought we were supposed to always call this, but there are a
19174 few places in the code where we dont do it.
19176 2002-09-17 Miguel de Icaza <miguel@ximian.com>
19178 * driver.cs: Add support in -linkres and -resource to specify the
19179 name of the identifier.
19181 2002-09-16 Miguel de Icaza <miguel@ximian.com>
19183 * ecore.cs (StandardConversionExists): Sync with the conversion
19184 code: allow anything-* to void* conversions.
19186 (FindMostSpecificSource): Use an Expression argument
19187 instead of a Type, because we might be handed over a Literal which
19188 gets a few more implicit conversions that plain types do not. So
19189 this information was being lost.
19191 Also, we drop the temporary type-holder expression when not
19194 2002-09-17 Martin Baulig <martin@gnome.org>
19196 * class.cs (PropertyBase.CheckBase): Don't check the base class if
19197 this is an explicit interface implementation.
19199 2002-09-17 Martin Baulig <martin@gnome.org>
19201 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
19202 different `IndexerName' attributes.
19204 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
19205 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
19206 virtual CommonResolve().
19208 2002-09-16 Miguel de Icaza <miguel@ximian.com>
19210 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
19211 and convert that to the UnderlyingType.
19213 * statement.cs (Foreach.Resolve): Indexers are just like variables
19214 or PropertyAccesses.
19216 * cs-tokenizer.cs (consume_string): Track line numbers and columns
19217 inside quoted strings, we were not doing this before.
19219 2002-09-16 Martin Baulig <martin@gnome.org>
19221 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
19222 resolve it. This is needed for the definite assignment check of the
19223 instance expression, fixes bug #29846.
19224 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
19226 2002-09-16 Nick Drochak <ndrochak@gol.com>
19228 * parameter.cs: Fix compile error. Cannot reference static member
19229 from an instance object. Is this an mcs bug?
19231 2002-09-14 Martin Baulig <martin@gnome.org>
19233 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
19234 multiple times. Fixes bug #30295, added test-166.cs.
19236 2002-09-14 Martin Baulig <martin@gnome.org>
19238 * statement.cs (Block.Emit): Don't emit unreachable code.
19239 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
19240 `break' statements.
19241 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
19243 2002-09-14 Martin Baulig <martin@gnome.org>
19245 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
19248 2002-09-14 Martin Baulig <martin@gnome.org>
19250 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
19251 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
19252 be false on the ms runtime.
19254 2002-09-13 Martin Baulig <martin@gnome.org>
19256 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
19257 the CS0038 error message.
19259 2002-09-12 Miguel de Icaza <miguel@ximian.com>
19261 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
19262 constant inside, return it.
19264 2002-09-12 Martin Baulig <martin@gnome.org>
19266 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
19267 implicit conversion can be done between enum types.
19269 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
19270 check whether an implicit conversion to the current enum's UnderlyingType
19271 exists and report an error if not.
19273 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
19274 without debugging support.
19276 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
19277 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
19279 2002-09-12 Martin Baulig <martin@gnome.org>
19281 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
19283 * ecore.cs (IMemberExpr.DeclaringType): New property.
19284 (SimpleName.SimpleNameResolve): Check whether we're accessing a
19285 nonstatic member of an outer type (CS0038).
19287 2002-09-11 Miguel de Icaza <miguel@ximian.com>
19289 * driver.cs: Activate the using-error detector at warning level
19290 4 (at least for MS-compatible APIs).
19292 * namespace.cs (VerifyUsing): Small buglett fix.
19294 * pending.cs (PendingImplementation): pass the container pointer.
19296 * interface.cs (GetMethods): Allow for recursive definition. Long
19297 term, I would like to move every type to support recursive
19298 definitions, not the current ordering mechanism that we have right
19301 The situation is this: Attributes are handled before interfaces,
19302 so we can apply attributes to interfaces. But some attributes
19303 implement interfaces, we will now handle the simple cases
19304 (recursive definitions will just get an error).
19306 * parameter.cs: Only invalidate types at the end if we fail to
19309 2002-09-09 Martin Baulig <martin@gnome.org>
19311 * ecore.cs (PropertyExpr.Emit): Also check for
19312 TypeManager.system_int_array_get_length so this'll also work when
19313 compiling corlib. Fixes #30003.
19315 2002-09-09 Martin Baulig <martin@gnome.org>
19317 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
19318 and throw an exception if we can't get the type's size. Fixed #30040,
19321 2002-09-09 Martin Baulig <martin@gnome.org>
19323 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
19325 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
19326 context. Fixes bug #30027.
19328 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
19329 virtual functions. Fixes bug #30043, added test-164.cs.
19331 2002-09-08 Ravi Pratap <ravi@ximian.com>
19333 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
19335 2002-09-08 Nick Drochak <ndrochak@gol.com>
19337 * driver.cs: Use an object to get the windows codepage since it's not a
19340 2002-09-08 Miguel de Icaza <miguel@ximian.com>
19342 * statement.cs (For.Emit): for infinite loops (test == null)
19343 return whether there is a break inside, not always "true".
19345 * namespace.cs (UsingEntry): New struct to hold the name of the
19346 using definition, the location where it is defined, and whether it
19347 has been used in a successful type lookup.
19349 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
19354 2002-09-06 Ravi Pratap <ravi@ximian.com>
19356 * attribute.cs : Fix incorrect code which relied on catching
19357 a NullReferenceException to detect a null being passed in
19358 where an object was expected.
19360 2002-09-06 Miguel de Icaza <miguel@ximian.com>
19362 * statement.cs (Try): flag the catch variable as assigned
19364 * expression.cs (Cast): Simplified by using ResolveType instead of
19365 manually resolving.
19367 * statement.cs (Catch): Fix bug by using ResolveType.
19369 2002-09-06 Ravi Pratap <ravi@ximian.com>
19371 * expression.cs (BetterConversion): Special case for when we have
19372 a NullLiteral as the argument and we have to choose between string
19373 and object types - we choose string the way csc does.
19375 * attribute.cs (Attribute.Resolve): Catch the
19376 NullReferenceException and report error #182 since the Mono
19377 runtime no more has the bug and having this exception raised means
19378 we tried to select a constructor which takes an object and is
19381 2002-09-05 Ravi Pratap <ravi@ximian.com>
19383 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
19384 message (1502, 1503) when we can't locate a method after overload
19385 resolution. This is much more informative and closes the bug
19388 * interface.cs (PopulateMethod): Return if there are no argument
19389 types. Fixes a NullReferenceException bug.
19391 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
19392 expressions too. Previously we were checking only in one place for
19393 positional arguments leaving out named arguments.
19395 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
19396 type to the enum type is not allowed. Remove code corresponding to
19399 (ConvertNumericExplicit): Allow explicit conversions from
19400 the underlying type to enum type. This precisely follows the spec
19401 and closes a bug filed by Gonzalo.
19403 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19406 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
19408 2002-09-03 Miguel de Icaza <miguel@ximian.com>
19410 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
19411 it was important that we stored the right value after the
19412 reduction in `converted'.
19414 2002-09-04 Martin Baulig <martin@gnome.org>
19416 * location.cs (Location.SymbolDocument): Use full pathnames for the
19419 2002-08-30 Miguel de Icaza <miguel@ximian.com>
19421 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
19422 of the expression resolve mechanism, because that will catch the
19423 SimpleName error failures.
19425 (Conditional): If we can not resolve the
19426 expression, return, do not crash.
19428 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19431 (location): display token name instead of its number.
19433 2002-08-28 Martin Baulig <martin@gnome.org>
19435 * expression.cs (Binary.ResolveOperator): Don't silently return
19436 but return an error if an operator cannot be applied between two
19439 2002-08-28 Martin Baulig <martin@gnome.org>
19441 * class.cs (Constructor.Define): Set the permission attributes
19442 correctly instead of making all constructors public.
19444 2002-08-28 Martin Baulig <martin@gnome.org>
19446 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
19447 for private members before reporting a CS0103; if we find anything,
19450 2002-08-28 Martin Baulig <martin@gnome.org>
19452 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
19453 to check whether `closure_start_type == closure_invocation_type',
19454 we also need to check whether `m.DeclaringType == closure_invocation_type'
19455 before bypassing the permission checks. We might be accessing
19456 protected/private members from the base class.
19457 (TypeManager.RealMemberLookup): Only set private_ok if private
19458 members were requested via BindingFlags.NonPublic.
19460 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
19462 * expression.cs (MemberAccess.ResolveMemberAccess): Set
19463 MethodGroupExpr.IsExplicitImpl if appropriate.
19464 (Invocation.DoResolve): Don't report the CS0120 for explicit
19465 interface implementations.
19467 2002-08-27 Martin Baulig <martin@gnome.org>
19469 * expression.cs (Invocation.DoResolve): If this is a static
19470 method and we don't have an InstanceExpression, we must report
19473 2002-08-25 Martin Baulig <martin@gnome.org>
19475 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
19476 `==' between a valuetype and an object.
19478 2002-08-25 Miguel de Icaza <miguel@ximian.com>
19480 * ecore.cs (TypeExpr): Provide a ToString method.
19482 2002-08-24 Martin Baulig <martin@gnome.org>
19484 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
19485 now called proggie.dbg and it's a binary file.
19487 2002-08-23 Martin Baulig <martin@gnome.org>
19489 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
19491 2002-08-23 Martin Baulig <martin@gnome.org>
19493 * struct.cs (MyStructInfo.ctor): Make this work with empty
19494 structs; it's not allowed to use foreach() on null.
19496 2002-08-23 Martin Baulig <martin@gnome.org>
19498 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
19499 writer the full pathname of the generated assembly.
19501 2002-08-23 Martin Baulig <martin@gnome.org>
19503 * statements.cs (FlowBranching.UsageVector.MergeChildren):
19504 A `finally' block never returns or breaks; improved handling of
19507 2002-08-23 Martin Baulig <martin@gnome.org>
19509 * statement.cs (Throw.Resolve): Allow `throw null'.
19511 2002-08-23 Martin Baulig <martin@gnome.org>
19513 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
19514 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
19515 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
19516 MemberLookup would return a wrong event if this is an explicit
19517 interface implementation and the class has an event with the same
19520 2002-08-23 Martin Baulig <martin@gnome.org>
19522 * statement.cs (Block.AddChildVariableNames): New public method.
19523 (Block.AddChildVariableName): Likewise.
19524 (Block.IsVariableNameUsedInChildBlock): Likewise.
19525 (Block.AddVariable): Check whether a variable name has already
19526 been used in a child block.
19528 * cs-parser.jay (declare_local_variables): Mark all variable names
19529 from the current block as being used in a child block in the
19532 2002-08-23 Martin Baulig <martin@gnome.org>
19534 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
19535 find the symbol writer.
19537 * driver.cs: csc also allows the arguments to /define being
19538 separated by commas, not only by semicolons.
19540 2002-08-23 Martin Baulig <martin@gnome.org>
19542 * interface.cs (Interface.GetMembers): Added static check for events.
19544 2002-08-15 Martin Baulig <martin@gnome.org>
19546 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
19547 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
19549 * ecore.cs (Expression.MemberLookup): Added documentation and explained
19550 why the MethodData.EmitDestructor() change was necessary.
19552 2002-08-20 Martin Baulig <martin@gnome.org>
19554 * class.cs (TypeContainer.FindMembers): Added static check for events.
19556 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
19558 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
19559 use Type.GetEvents(), not Type.FindMembers().
19561 2002-08-20 Martin Baulig <martin@gnome.org>
19563 * decl.cs (MemberCache): Added a special method cache which will
19564 be used for method-only searched. This ensures that a method
19565 search will return a MethodInfo with the correct ReflectedType for
19568 2002-08-20 Martin Baulig <martin@gnome.org>
19570 * decl.cs (DeclSpace.FindMembers): Made this public.
19572 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19574 * delegate.cs: fixed build on windows.
19575 [FIXME: Filed as bug #29150: MCS must report these errors.]
19577 2002-08-19 Ravi Pratap <ravi@ximian.com>
19579 * ecore.cs (StandardConversionExists): Return a false
19580 if we are trying to convert the void type to anything else
19581 since that is not allowed.
19583 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
19584 we flag error 70 in the event an event is trying to be accessed
19585 directly from outside the declaring type.
19587 2002-08-20 Martin Baulig <martin@gnome.org>
19589 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
19590 MemberCache from typemanager.cs to decl.cs.
19592 2002-08-19 Martin Baulig <martin@gnome.org>
19594 * class.cs (TypeContainer): Implement IMemberContainer.
19595 (TypeContainer.DefineMembers): Create the MemberCache.
19596 (TypeContainer.FindMembers): Do better BindingFlags checking; only
19597 return public members if BindingFlags.Public was given, check
19598 whether members are static.
19600 2002-08-16 Martin Baulig <martin@gnome.org>
19602 * decl.cs (DeclSpace.Define): Splitted this in Define and
19603 DefineMembers. DefineMembers is called first and initializes the
19606 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
19607 DefineMembers() on all our DeclSpaces.
19609 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
19610 but call DefineMembers() on all nested interfaces. We call their
19611 Define() in our new Define() function.
19613 * interface.cs (Interface): Implement IMemberContainer.
19614 (Interface.Define): Moved all code except the attribute stuf to
19616 (Interface.DefineMembers): Initialize the member cache.
19618 * typemanager.cs (IMemberFinder): Removed this interface, we don't
19619 need this anymore since we can use MemberCache.FindMembers directly.
19621 2002-08-19 Martin Baulig <martin@gnome.org>
19623 * typemanager.cs (MemberCache): When creating the cache for an
19624 interface type, add all inherited members.
19625 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
19626 to `out bool used_cache' and documented it.
19627 (TypeManager.MemberLookup): If we already used the cache in the first
19628 iteration, we don't need to do the interfaces check.
19630 2002-08-19 Martin Baulig <martin@gnome.org>
19632 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
19633 here from IMemberFinder and don't implement this interface anymore.
19634 (DeclSpace.MemberCache): Moved here from IMemberFinder.
19636 * typemanager.cs (IMemberFinder): This interface is now only used by
19637 classes which actually support the member cache.
19638 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
19639 since we only put DeclSpaces into this Hashtable.
19640 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
19641 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
19643 2002-08-16 Martin Baulig <martin@gnome.org>
19645 * typemanager.cs (ICachingMemberFinder): Removed.
19646 (IMemberFinder.MemberCache): New property.
19647 (TypeManager.FindMembers): Merged this with RealFindMembers().
19648 This function will never be called from TypeManager.MemberLookup()
19649 so we can't use the cache here, just the IMemberFinder.
19650 (TypeManager.MemberLookup_FindMembers): Check whether the
19651 IMemberFinder has a MemberCache and call the cache's FindMembers
19653 (MemberCache): Rewrote larger parts of this yet another time and
19654 cleaned it up a bit.
19656 2002-08-15 Miguel de Icaza <miguel@ximian.com>
19658 * driver.cs (LoadArgs): Support quoting.
19660 (Usage): Show the CSC-like command line arguments.
19662 Improved a few error messages.
19664 2002-08-15 Martin Baulig <martin@gnome.org>
19666 * typemanager.cs (IMemberContainer.Type): New property.
19667 (IMemberContainer.IsInterface): New property.
19669 The following changes are conditional to BROKEN_RUNTIME, which is
19670 defined at the top of the file.
19672 * typemanager.cs (MemberCache.MemberCache): Don't add the base
19673 class'es members, but add all members from TypeHandle.ObjectType
19674 if we're an interface.
19675 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
19676 is the current type.
19677 (MemberCache.CacheEntry.Container): Removed this field.
19678 (TypeHandle.GetMembers): Include inherited members.
19680 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19682 * typemanager.cs: fixed compilation and added a comment on a field that
19685 2002-08-15 Martin Baulig <martin@gnome.org>
19687 * class.cs (ConstructorInitializer.Resolve): In the
19688 Expression.MemberLookup call, use the queried_type as
19691 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
19692 declared' attribute, it's always true.
19693 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
19694 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
19695 temporary wrapper for FindMembers which tells MemberLookup whether
19696 members from the base classes are included in the return value.
19697 This will go away soon.
19698 (TypeManager.MemberLookup): Use this temporary hack here; once the
19699 new MemberCache is completed, we don't need to do the DeclaredOnly
19700 looping here anymore since the MemberCache will take care of this.
19701 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
19702 (MemberCache): When creating the MemberCache for a class, get
19703 members from the current class and all its base classes.
19704 (MemberCache.CacheEntry.Container): New field. This is a
19705 temporary hack until the Mono runtime is fixed to distinguish
19706 between ReflectedType and DeclaringType. It allows us to use MCS
19707 with both the MS runtime and the unfixed Mono runtime without
19708 problems and without accecting performance.
19709 (MemberCache.SearchMembers): The DeclaredOnly looping from
19710 TypeManager.MemberLookup is now done here.
19712 2002-08-14 Martin Baulig <martin@gnome.org>
19714 * statement.cs (MyStructInfo.MyStructInfo): Don't call
19715 Type.GetFields on dynamic types but get the fields from the
19716 corresponding TypeContainer.
19717 (MyStructInfo.GetStructInfo): Added check for enum types.
19719 * typemanager.cs (MemberList.IsSynchronized): Implemented.
19720 (MemberList.SyncRoot): Implemented.
19721 (TypeManager.FilterWithClosure): No need to check permissions if
19722 closure_start_type == closure_invocation_type, don't crash if
19723 closure_invocation_type is null.
19725 2002-08-13 Martin Baulig <martin@gnome.org>
19727 Rewrote TypeContainer.FindMembers to use a member cache. This
19728 gives us a speed increase of about 35% for the self-hosting MCS
19729 build and of about 15-20% for the class libs (both on GNU/Linux).
19731 * report.cs (Timer): New class to get enhanced profiling. This
19732 whole class is "TIMER" conditional since it remarkably slows down
19735 * class.cs (MemberList): New class. This is an IList wrapper
19736 which we're now using instead of passing MemberInfo[]'s around to
19737 avoid copying this array unnecessarily.
19738 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
19739 (ICachingMemberFinder, IMemberContainer): New interface.
19740 (TypeManager.FilterWithClosure): If `criteria' is null, the name
19741 has already been checked, otherwise use it for the name comparision.
19742 (TypeManager.FindMembers): Renamed to RealMemberFinder and
19743 provided wrapper which tries to use ICachingMemberFinder.FindMembers
19744 if possible. Returns a MemberList, not a MemberInfo [].
19745 (TypeHandle): New class, implements IMemberContainer. We create
19746 one instance of this class per type, it contains a MemberCache
19747 which is used to do the member lookups.
19748 (MemberCache): New class. Each instance of this class contains
19749 all members of a type and a name-based hash table.
19750 (MemberCache.FindMembers): This is our new member lookup
19751 function. First, it looks up all members of the requested name in
19752 the hash table. Then, it walks this list and sorts out all
19753 applicable members and returns them.
19755 2002-08-13 Martin Baulig <martin@gnome.org>
19757 In addition to a nice code cleanup, this gives us a performance
19758 increase of about 1.4% on GNU/Linux - not much, but it's already
19759 half a second for the self-hosting MCS compilation.
19761 * typemanager.cs (IMemberFinder): New interface. It is used by
19762 TypeManager.FindMembers to call FindMembers on a TypeContainer,
19763 Enum, Delegate or Interface.
19764 (TypeManager.finder_to_member_finder): New PtrHashtable.
19765 (TypeManager.finder_to_container): Removed.
19766 (TypeManager.finder_to_delegate): Removed.
19767 (TypeManager.finder_to_interface): Removed.
19768 (TypeManager.finder_to_enum): Removed.
19770 * interface.cs (Interface): Implement IMemberFinder.
19772 * delegate.cs (Delegate): Implement IMemberFinder.
19774 * enum.cs (Enum): Implement IMemberFinder.
19776 * class.cs (TypeContainer): Implement IMemberFinder.
19778 2002-08-12 Martin Baulig <martin@gnome.org>
19780 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
19782 2002-08-12 Martin Baulig <martin@gnome.org>
19784 * ecore.cs (ITypeExpression): New interface for expressions which
19786 (TypeExpression): Renamed to TypeLookupExpression.
19787 (Expression.DoResolve): If we're doing a types-only lookup, the
19788 expression must implement the ITypeExpression interface and we
19789 call DoResolveType() on it.
19790 (SimpleName): Implement the new ITypeExpression interface.
19791 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
19792 hack, the situation that we're only looking up types can't happen
19793 anymore when this method is called. Moved the type lookup code to
19794 DoResolveType() and call it.
19795 (SimpleName.DoResolveType): This ITypeExpression interface method
19796 is now doing the types-only lookup.
19797 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
19798 (ResolveFlags): Added MaskExprClass.
19800 * expression.cs (MemberAccess): Implement the ITypeExpression
19802 (MemberAccess.DoResolve): Added support for a types-only lookup
19803 when we're called via ITypeExpression.DoResolveType().
19804 (ComposedCast): Implement the ITypeExpression interface.
19806 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
19807 Expression.Resolve() with ResolveFlags.Type instead.
19809 2002-08-12 Martin Baulig <martin@gnome.org>
19811 * interface.cs (Interface.Define): Apply attributes.
19813 * attribute.cs (Attribute.ApplyAttributes): Added support for
19814 interface attributes.
19816 2002-08-11 Martin Baulig <martin@gnome.org>
19818 * statement.cs (Block.Emit): Only check the "this" variable if we
19819 do not always throw an exception.
19821 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
19822 whether the property has a set accessor.
19824 2002-08-11 Martin Baulig <martin@gnome.org>
19826 Added control flow analysis support for structs.
19828 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
19829 with control flow analysis turned off.
19830 (IVariable): New interface.
19831 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
19832 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
19833 (FieldExpr.DoResolve): Resolve the instance expression with flow
19834 analysis turned off and do the definite assignment check after the
19835 resolving when we know what the expression will resolve to.
19837 * expression.cs (LocalVariableReference, ParameterReference):
19838 Implement the new IVariable interface, only call the flow analysis
19839 code if ec.DoFlowAnalysis is true.
19840 (This): Added constructor which takes a Block argument. Implement
19841 the new IVariable interface.
19842 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
19843 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
19844 This does the definite assignment checks for struct members.
19846 * class.cs (Constructor.Emit): If this is a non-static `struct'
19847 constructor which doesn't have any initializer, call
19848 Block.AddThisVariable() to tell the flow analysis code that all
19849 struct elements must be initialized before control returns from
19852 * statement.cs (MyStructInfo): New public class.
19853 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
19854 argument to this indexer. If non-zero, check an individual struct
19855 member, not the whole struct.
19856 (FlowBranching.CheckOutParameters): Check struct members.
19857 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
19858 overloaded versions of these methods which take an additional
19859 `int field_idx' argument to check struct members.
19860 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
19861 overloaded versions of these methods which take an additional
19862 `string field_name' argument to check struct member.s
19863 (VariableInfo): Implement the IVariable interface.
19864 (VariableInfo.StructInfo): New public property. Returns the
19865 MyStructInfo instance of the variable if it's a struct or null.
19866 (Block.AddThisVariable): New public method. This is called from
19867 Constructor.Emit() for non-static `struct' constructor which do
19868 not have any initializer. It creates a special variable for the
19869 "this" instance variable which will be checked by the flow
19870 analysis code to ensure that all of the struct's fields are
19871 initialized before control returns from the constructor.
19872 (UsageVector): Added support for struct members. If a
19873 variable/parameter is a struct with N members, we reserve a slot
19874 in the usage vector for each member. A struct is considered fully
19875 initialized if either the struct itself (slot 0) or all its
19876 members are initialized.
19878 2002-08-08 Martin Baulig <martin@gnome.org>
19880 * driver.cs (Driver.MainDriver): Only report an error CS5001
19881 if there were no compilation errors.
19883 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
19884 `UnsafeContext' property to determine whether the parent is in
19885 unsafe context rather than checking the parent's ModFlags:
19886 classes nested in an unsafe class are unsafe as well.
19888 2002-08-08 Martin Baulig <martin@gnome.org>
19890 * statement.cs (UsageVector.MergeChildren): Distinguish between
19891 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
19892 we return. Added test17() and test18() to test-154.cs.
19894 2002-08-08 Martin Baulig <martin@gnome.org>
19896 * typemanager.cs (TypeManager.FilterWithClosure): If we have
19897 Family access, make sure the invoking type isn't a subclass of the
19898 queried type (that'd be a CS1540).
19900 * ecore.cs (Expression.MemberLookup): Added overloaded version of
19901 this method which takes an additional `Type invocation_type'.
19903 * expression.cs (BaseAccess.DoResolve): Use the base type as
19904 invocation and query type.
19905 (MemberAccess.DoResolve): If the lookup failed and we're about to
19906 report a CS0122, try a lookup with the ec.ContainerType - if this
19907 succeeds, we must report a CS1540.
19909 2002-08-08 Martin Baulig <martin@gnome.org>
19911 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
19912 (MethodGroupExpr): Implement the IMemberExpr interface.
19914 * expression (MemberAccess.ResolveMemberAccess): No need to have
19915 any special code for MethodGroupExprs anymore, they're now
19918 2002-08-08 Martin Baulig <martin@gnome.org>
19920 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
19921 Family, FamANDAssem and FamORAssem permissions.
19922 (TypeManager.IsSubclassOrNestedChildOf): New public method.
19924 2002-08-08 Martin Baulig <martin@gnome.org>
19926 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
19927 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
19930 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
19932 * driver.cs: implemented /resource option to embed managed resources.
19934 2002-08-07 Martin Baulig <martin@gnome.org>
19936 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
19937 (FieldBase.HasFieldInitializer): New public property.
19938 (FieldBase.GetInitializerExpression): New public method. Resolves and
19939 returns the field initializer and makes sure it is only resolved once.
19940 (TypeContainer.EmitFieldInitializers): Call
19941 FieldBase.GetInitializerExpression to get the initializer, this ensures
19942 that it isn't resolved multiple times.
19944 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
19945 the resolving process (SimpleName/MemberLookup) that we're currently
19946 emitting a field initializer (which must not access any instance members,
19947 this is an error CS0236).
19949 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
19950 argument, if the `IsFieldInitializer' flag is set, we must report and
19951 error CS0236 and not an error CS0120.
19953 2002-08-07 Martin Baulig <martin@gnome.org>
19955 * ecore.cs (IMemberExpr): New public interface.
19956 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
19957 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
19958 if the expression is an IMemberExpr.
19960 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
19961 to be null, implicitly default to `this' if we're non-static in
19962 this case. Simplified the code a lot by using the new IMemberExpr
19963 interface. Also fixed bug #28176 here.
19965 2002-08-06 Martin Baulig <martin@gnome.org>
19967 * cs-parser.jay (SimpleLookup): Removed. We need to create
19968 ParameterReferences during semantic analysis so that we can do a
19969 type-only search when resolving Cast, TypeOf and SizeOf.
19970 (block): Pass the `current_local_parameters' to the Block's
19973 * class.cs (ConstructorInitializer): Added `Parameters parameters'
19974 argument to the constructor.
19975 (ConstructorInitializer.Resolve): Create a temporary implicit
19976 block with the parameters.
19978 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
19979 references here if we aren't doing a type-only search.
19981 * statement.cs (Block): Added constructor which takes a
19982 `Parameters parameters' argument.
19983 (Block.Parameters): New public property.
19985 * support.cs (InternalParameters.Parameters): Renamed `parameters'
19986 to `Parameters' and made it public readonly.
19988 2002-08-06 Martin Baulig <martin@gnome.org>
19990 * ecore.cs (Expression.Warning): Made this public as well.
19992 * report.cs (Report.Debug): Print the contents of collections.
19994 2002-08-06 Martin Baulig <martin@gnome.org>
19996 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
19997 used to tell Resolve() which kinds of expressions it may return.
19998 (Expression.Resolve): Added overloaded version of this method which
19999 takes a `ResolveFlags flags' argument. This can be used to tell
20000 Resolve() which kinds of expressions it may return. Reports a
20002 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
20003 ResolveFlags.SimpleName.
20004 (Expression.Error118): Added overloaded version of this method which
20005 takes a `ResolveFlags flags' argument. It uses the flags to determine
20006 which kinds of expressions are allowed.
20008 * expression.cs (Argument.ResolveMethodGroup): New public method.
20009 Resolves an argument, but allows a MethodGroup to be returned.
20010 This is used when invoking a delegate.
20012 * TODO: Updated a bit.
20014 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20016 Fixed compilation with csc.
20018 * ecore.cs: Expression.Error made public. Is this correct? Should
20019 Warning be made public too?
20021 * expression.cs: use ea.Location instead of ea.loc.
20022 [FIXME: Filed as bug #28607: MCS must report these errors.]
20024 2002-08-06 Martin Baulig <martin@gnome.org>
20026 * ecore.cs (Expression.loc): Moved the location here instead of
20027 duplicating it in all derived classes.
20028 (Expression.Location): New public property.
20029 (Expression.Error, Expression.Warning): Made them non-static and
20030 removed the location argument.
20031 (Expression.Warning): Added overloaded version which takes an
20032 `int level' argument.
20033 (Expression.Error118): Make this non-static and removed the
20034 expression and location arguments.
20035 (TypeExpr): Added location argument to the constructor.
20037 * expression.cs (StaticCallExpr): Added location argument to
20039 (Indirection, PointerArithmetic): Likewise.
20040 (CheckedExpr, UnCheckedExpr): Likewise.
20041 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
20042 (StringPtr): Likewise.
20045 2002-08-05 Martin Baulig <martin@gnome.org>
20047 * expression.cs (BaseAccess.DoResolve): Actually report errors.
20049 * assign.cs (Assign.DoResolve): Check whether the source
20050 expression is a value or variable.
20052 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
20053 while resolving the corresponding blocks.
20055 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
20056 an error, don't silently return null.
20058 * statement.cs (Block.AddVariable): Do the error reporting here
20059 and distinguish between CS0128 and CS0136.
20060 (Block.DoResolve): Report all unused labels (warning CS0164).
20061 (LabeledStatement): Pass the location to the constructor.
20062 (LabeledStatement.HasBeenReferenced): New property.
20063 (LabeledStatement.Resolve): Set it to true here.
20065 * statement.cs (Return.Emit): Return success even after reporting
20066 a type mismatch error (CS0126 or CS0127), this is what csc does and
20067 it avoids confusing the users with any consecutive errors.
20069 2002-08-05 Martin Baulig <martin@gnome.org>
20071 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
20073 * const.cs (Const.LookupConstantValue): Catch circular definitions.
20075 * expression.cs (MemberAccess.DoResolve): Silently return if an
20076 error has already been reported.
20078 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
20079 error has already been reported.
20081 2002-08-05 Martin Baulig <martin@gnome.org>
20083 * statement.cs (UsageVector): Only initialize the `parameters'
20084 vector if we actually have any "out" parameters.
20086 2002-08-05 Martin Baulig <martin@gnome.org>
20088 * expression.cs (Binary.ResolveOperator): When combining delegates,
20089 they must have the same type.
20091 2002-08-05 Martin Baulig <martin@gnome.org>
20093 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
20094 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
20095 work with the ms runtime and we also don't need it: if we're a
20096 PropertyBuilder and not in the `indexer_arguments' hash, then we
20097 are a property and not an indexer.
20099 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
20100 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
20101 since the latter one doesn't work with the ms runtime.
20103 2002-08-03 Martin Baulig <martin@gnome.org>
20105 Fixed bugs #27998 and #22735.
20107 * class.cs (Method.IsOperator): New public field.
20108 (Method.CheckBase): Report CS0111 if there's already a method
20109 with the same parameters in the current class. Report CS0508 when
20110 attempting to change the return type of an inherited method.
20111 (MethodData.Emit): Report CS0179 if a method doesn't have a body
20112 and it's not marked abstract or extern.
20113 (PropertyBase): New abstract base class for Property and Indexer.
20114 (PropertyBase.CheckBase): Moved here from Property and made it work
20116 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
20117 the same so we can reuse it there.
20118 (Property, Indexer): Derive from PropertyBase.
20119 (MethodSignature.inheritable_property_signature_filter): New delegate
20120 to find properties and indexers.
20122 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
20123 argument and improved error reporting.
20125 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
20126 EmptyReadOnlyParameters and made it a property.
20128 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
20129 version of this method which takes a `PropertyInfo indexer'.
20130 (TypeManager.RegisterIndexer): New method.
20132 * class.cs: Added myself as author of this file :-)
20134 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20136 * class.cs: fixed compilation on windoze.
20138 2002-08-03 Martin Baulig <martin@gnome.org>
20140 * interface.cs (Interface.GetInterfaceBases): Check whether all
20141 base interfaces are at least as accessible than the current one.
20143 * class.cs (TypeContainer.GetClassBases): Check whether base types
20144 are at least as accessible than the current type.
20145 (TypeContainer.AsAccessible): Implemented and made non-static.
20146 (MemberBase.CheckParameters): Report errors if the accessibility
20149 * delegate.cs (Delegate.Delegate): The default visibility is
20150 internal for top-level types and private for nested types.
20151 (Delegate.Define): Report errors if the accessibility checks fail.
20153 * enum.cs (Enum.Enum): The default visibility is internal for
20154 top-level types and private for nested types.
20155 (Enum.DefineType): Compute the correct visibility.
20157 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
20158 function which takes a `bool is_toplevel' instead of a TypeContainer.
20160 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
20163 2002-08-02 Martin Baulig <martin@gnome.org>
20165 * expression.cs (LocalVariableReferenc): Added constructor which
20166 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
20167 (LocalVariableReference.IsReadOnly): New property.
20168 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
20169 variable is readonly, use our own readonly flag to do this; you can
20170 use the new constructor to get a writable reference to a read-only
20173 * cs-parser.jay (foreach_statement, using_statement): Get a writable
20174 reference to the local variable.
20176 2002-08-01 Miguel de Icaza <miguel@ximian.com>
20178 * rootcontext.cs (ResolveCore): Also include System.Exception
20180 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
20181 we reach an EmptyStatement.
20183 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
20186 * expression.cs (Binary.ResolveOperator): Check error result in
20189 use brtrue/brfalse directly and avoid compares to null.
20191 2002-08-02 Martin Baulig <martin@gnome.org>
20193 * class.cs (TypeContainer.Define): Define all nested interfaces here.
20194 Fixes bug #28407, added test-155.cs.
20196 2002-08-01 Martin Baulig <martin@gnome.org>
20198 * class.cs (Event.EmitDefaultMethod): Make this work with static
20199 events. Fixes #28311, added verify-3.cs.
20201 2002-08-01 Martin Baulig <martin@gnome.org>
20203 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
20204 `is_disposable' fields.
20205 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
20206 `hm.is_disposable' if we're using the collection pattern.
20207 (Foreach.EmitCollectionForeach): Use the correct type for the
20208 enumerator's local variable, only emit the try/finally block if
20209 necessary (fixes #27713).
20211 2002-08-01 Martin Baulig <martin@gnome.org>
20213 * ecore.cs (Expression.report118): Renamed to Error118 and made
20216 * statement.cs (Throw.Resolve): Check whether the expression is of
20217 the correct type (CS0118) and whether the type derives from
20218 System.Exception (CS0155).
20219 (Catch.Resolve): New method. Do the type lookup here and check
20220 whether it derives from System.Exception (CS0155).
20221 (Catch.CatchType, Catch.IsGeneral): New public properties.
20223 * typemanager.cs (TypeManager.exception_type): Added.
20225 2002-07-31 Miguel de Icaza <miguel@ximian.com>
20227 * driver.cs: Updated About function.
20229 2002-07-31 Martin Baulig <martin@gnome.org>
20231 Implemented Control Flow Analysis.
20233 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
20234 (EmitContext.CurrentBranching): Added.
20235 (EmitContext.StartFlowBranching): Added.
20236 (EmitContext.EndFlowBranching): Added.
20237 (EmitContext.KillFlowBranching): Added.
20238 (EmitContext.IsVariableAssigned): Added.
20239 (EmitContext.SetVariableAssigned): Added.
20240 (EmitContext.IsParameterAssigned): Added.
20241 (EmitContext.SetParameterAssigned): Added.
20242 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
20243 Added control flow analysis stuff here.
20245 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
20246 resolve the expression as lvalue.
20247 (LocalVariableReference.DoResolve): Check whether the variable has
20248 already been assigned.
20249 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
20250 the parameter as assigned here.
20251 (ParameterReference.DoResolve): Check whether the parameter has already
20253 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
20254 expression as lvalue.
20256 * statement.cs (FlowBranching): New class for the flow analysis code.
20257 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
20258 (LabeledStatement.IsDefined): New public property.
20259 (LabeledStatement.AddUsageVector): New public method to tell flow
20260 analyis that the label may be reached via a forward jump.
20261 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
20263 (VariableInfo.Number): New public field. This is used by flow analysis
20264 to number all locals of a block.
20265 (Block.CountVariables): New public property. This is the number of
20266 local variables in this block (including the locals from all parent
20268 (Block.EmitMeta): Number all the variables.
20270 * statement.cs: Added flow analysis support to all classes.
20272 2002-07-31 Martin Baulig <martin@gnome.org>
20274 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
20275 To get debugging messages, compile mcs with /define:MCS_DEBUG and
20276 then use this argument.
20278 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
20280 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
20281 use this to specify /define options.
20283 2002-07-29 Martin Baulig <martin@gnome.org>
20285 * statement.cs (Fixed): Moved all code that does variable lookups
20286 and resolvings from Emit to Resolve.
20288 * statement.cs (For): Moved all code that does variable lookups
20289 and resolvings from Emit to Resolve.
20291 * statement.cs (Using): Moved all code that does variable lookups
20292 and resolvings from Emit to Resolve.
20294 2002-07-29 Martin Baulig <martin@gnome.org>
20296 * attribute.cs (Attribute.Resolve): Explicitly catch a
20297 System.NullReferenceException when creating the
20298 CustromAttributeBuilder and report a different warning message.
20300 2002-07-29 Martin Baulig <martin@gnome.org>
20302 * support.cs (ParameterData.ParameterName): Added method to
20303 get the name of a parameter.
20305 * typemanager.cs (TypeManager.IsValueType): New public method.
20307 2002-07-29 Martin Baulig <martin@gnome.org>
20309 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
20310 is a flag which specifies that it's either ref or out.
20311 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
20312 the out parameter to `out Parameter.Modifier mod', also set the
20313 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
20315 * support.cs (InternalParameters.ParameterModifier): Distinguish
20316 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
20317 Parameter.Modifier.ISBYREF flag if it's either ref or out.
20319 * expression.cs (Argument.GetParameterModifier): Distinguish
20320 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
20321 Parameter.Modifier.ISBYREF flag if it's either ref or out.
20323 2002-07-29 Martin Baulig <martin@gnome.org>
20325 * expression.cs (ParameterReference.ParameterReference): Added
20326 `Location loc' argument to the constructor.
20328 * cs-parser.jay: Pass location to ParameterReference.
20330 2002-07-28 Miguel de Icaza <miguel@ximian.com>
20332 * statement.cs (Try): Initialize the location.
20334 * cs-parser.jay: pass location to Try.
20336 * expression.cs (Unary.Reduce): Change the prototype to return
20337 whether a constant fold could be performed or not. The result is
20338 returned in an out parameters. In the case of Indirection and
20339 AddressOf, we want to perform the full tests.
20341 2002-07-26 Miguel de Icaza <miguel@ximian.com>
20343 * statement.cs (Statement.Emit): Flag dead code.
20345 2002-07-27 Andrew Birkett <andy@nobugs.org>
20347 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
20349 2002-07-27 Martin Baulig <martin@gnome.org>
20351 * class.cs (MethodData.Define): Put back call to
20352 TypeManager.AddMethod(), accidentally commented this out.
20354 * report.cs (Debug): New public method to print debugging information,
20355 this is `[Conditional ("DEBUG")]'.
20357 2002-07-26 Martin Baulig <martin@gnome.org>
20359 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
20360 (switch_statement): Push the current_block to the switch_stack and
20361 pop it again when we're done with the switch.
20362 (switch_section): The new block is a child of the current_block.
20363 Fixes bug #24007, added test-152.cs.
20365 2002-07-27 Martin Baulig <martin@gnome.org>
20367 * expression.cs (Invocation.EmitArguments): When calling a varargs
20368 function with only its fixed arguments, we need to pass an empty
20371 2002-07-27 Martin Baulig <martin@gnome.org>
20373 Mono 0.13 has been released.
20375 2002-07-25 Miguel de Icaza <miguel@ximian.com>
20377 * driver.cs: Rename --resource to --linkres, because that is what
20378 we do currently, we dont support --resource yet.
20380 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
20382 2002-07-25 Martin Baulig <martin@gnome.org>
20384 * class.cs (MethodData): New public class. This is a `method builder'
20385 class for a method or one accessor of a Property/Indexer/Event.
20386 (MethodData.GetMethodFlags): Moved here from MemberBase.
20387 (MethodData.ApplyAttributes): Likewise.
20388 (MethodData.ApplyObsoleteAttribute): Likewise.
20389 (MethodData.ApplyConditionalAttribute): Likewise.
20390 (MethodData.ApplyDllImportAttribute): Likewise.
20391 (MethodData.CheckAbstractAndExternal): Likewise.
20392 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
20393 (MethodData.Emit): Formerly known as Method.Emit().
20394 (MemberBase): Moved everything which was specific to a single
20395 accessor/method to MethodData.
20396 (Method): Create a new MethodData and call Define() and Emit() on it.
20397 (Property, Indexer, Event): Create a new MethodData objects for each
20398 accessor and call Define() and Emit() on them.
20400 2002-07-25 Martin Baulig <martin@gnome.org>
20402 Made MethodCore derive from MemberBase to reuse the code from there.
20403 MemberBase now also checks for attributes.
20405 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
20406 (MemberBase.GetMethodFlags): Moved here from class Method and marked
20408 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
20409 `CallingConventions cc' and `Attributes opt_attrs' arguments.
20410 (MemberBase.ApplyAttributes): New virtual method; applies the
20411 attributes to a method or accessor.
20412 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
20413 (MemberBase.ApplyConditionalAttribute): Likewise.
20414 (MemberBase.ApplyDllImportAttribute): Likewise.
20415 (MemberBase.CheckAbstractAndExternal): Likewise.
20416 (MethodCore.ParameterTypes): This is now a property instead of a
20417 method, it's initialized from DoDefineParameters().
20418 (MethodCore.ParameterInfo): Removed the set accessor.
20419 (MethodCore.DoDefineParameters): New protected virtual method to
20420 initialize ParameterTypes and ParameterInfo.
20421 (Method.GetReturnType): We can now simply return the MemberType.
20422 (Method.GetMethodFlags): Override the MemberBase version and add
20423 the conditional flags.
20424 (Method.CheckBase): Moved some code from Define() here, call
20425 DoDefineParameters() here.
20426 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
20427 here to avoid some larger code duplication.
20428 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
20429 ensure that abstract and external accessors don't declare a body.
20431 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
20432 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
20433 lookup in the attribute's parent classes, so we need to abort as soon
20434 as we found the first match.
20435 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
20436 the attribute has no arguments.
20438 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
20441 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20443 * cs-parser.jay: reverted previous patch.
20445 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20447 * cs-parser.jay: fixed bug #22119.
20449 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20451 * attribute.cs: fixed compilation. The error was:
20452 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
20453 be assigned to before control leaves the current method."
20454 [FIXME: Filed as bug #28186: MCS must report this error.]
20456 2002-07-25 Martin Baulig <martin@gnome.org>
20458 * attribute.cs (Attribute.Conditional_GetConditionName): New static
20459 method to pull the condition name ouf of a Conditional attribute.
20460 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
20461 the obsolete message and error flag out of an Obsolete attribute.
20463 * class.cs (Method.GetMethodFlags): New public method to get the
20464 TypeManager.MethodFlags for this method.
20465 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
20467 (Method.Define): Get and apply the Obsolete and Conditional attributes;
20468 if we're overriding a virtual function, set the new private variable
20469 `parent_method'; call the new TypeManager.AddMethod().
20471 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
20472 the MethodBuilder and the Method in a PtrHashtable.
20473 (TypeManager.builder_to_method): Added for this purpose.
20474 (TypeManager.MethodFlags): Added IsObsoleteError.
20475 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
20476 Obsolete and Conditional arguments in MethodBuilders. If we discover
20477 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
20478 the message from the attribute.
20480 2002-07-24 Martin Baulig <martin@gnome.org>
20482 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
20483 preprocessor directives, ensure that the argument to #define/#undef is
20484 exactly one identifier and that it's actually an identifier.
20486 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
20489 2002-07-24 Martin Baulig <martin@gnome.org>
20491 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
20492 initialize it to TypeManager.object_type in the constructor.
20493 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
20494 of the `hm.get_current' method if we're using the collection pattern.
20495 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
20496 for the explicit conversion to make it work when we're using the collection
20497 pattern and the `Current' property has a different return type than `object'.
20500 2002-07-24 Martin Baulig <martin@gnome.org>
20502 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
20503 does not match, but don't report any errors. This method is called in
20504 order for all methods in a MethodGroupExpr until a matching method is
20505 found, so we don't want to bail out if the first method doesn't match.
20506 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
20507 matches, report the 123. Fixes #28070.
20509 2002-07-24 Martin Baulig <martin@gnome.org>
20511 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
20512 TypeManager.TypeToCoreType() to the top of the method so the
20513 following equality checks will work. Fixes #28107.
20515 2002-07-24 Martin Baulig <martin@gnome.org>
20517 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
20518 operand is of type uint, and the other operand is of type sbyte,
20519 short or int, the operands are converted to type long." -
20520 Actually do what this comment already told us. Fixes bug #28106,
20523 2002-07-24 Martin Baulig <martin@gnome.org>
20525 * class.cs (MethodBase): New abstract class. This is now a base
20526 class for Property, Indexer and Event to avoid some code duplication
20527 in their Define() and DefineMethods() methods.
20528 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
20529 generic methods for Define() and DefineMethods().
20530 (FieldBase): Derive from MemberBase, not MemberCore.
20531 (Property): Derive from MemberBase, not MemberCore.
20532 (Property.DefineMethod): Moved all the code from this method to the
20533 new MethodBase.DefineAccessor(), just call it with appropriate
20535 (Property.Define): Call the new Property.DoDefine(), this does some
20536 sanity checks and we don't need to duplicate the code everywhere.
20537 (Event): Derive from MemberBase, not MemberCore.
20538 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
20539 accessors, this will also make them work with interface events.
20540 (Indexer): Derive from MemberBase, not MemberCore.
20541 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
20542 (Indexer.Define): Use the new MethodBase functions.
20544 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
20545 argument to the constructor.
20546 (Interface.FindMembers): Added support for interface events.
20547 (Interface.PopluateEvent): Implemented.
20549 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
20551 2002-07-22 Miguel de Icaza <miguel@ximian.com>
20553 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
20554 but this is required to check for a method name being the same as
20555 the containing class.
20559 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20561 * interface.cs: initialize variable.
20563 2002-07-23 Martin Baulig <martin@gnome.org>
20565 Implemented the IndexerName attribute in interfaces.
20567 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
20568 name if this is an explicit interface implementation.
20569 (Indexer.InterfaceIndexerName): New public variable. If we're
20570 implementing an interface indexer, this is the IndexerName in that
20571 interface. Otherwise, it's the IndexerName.
20572 (Indexer.DefineMethod): If we're implementing interface indexer,
20573 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
20574 and Pending.ImplementIndexer methods.
20575 (Indexer.Define): Also define the PropertyBuilder if we're
20576 implementing an interface indexer and this is neither an explicit
20577 interface implementation nor do the IndexerName match the one in
20580 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
20581 If a method is defined here, then we always need to create a proxy
20582 for it. This is used when implementing interface indexers.
20583 (Pending.IsInterfaceIndexer): New public method.
20584 (Pending.ImplementIndexer): New public method.
20585 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
20586 This is used when implementing interface indexers to define a proxy
20588 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
20589 define a proxy if necessary.
20591 * interface.cs (Interface.IndexerName): New public variable.
20592 (Interface.PopulateIndexer): Set the IndexerName.
20593 (Interface.DefineIndexers): New private method. Populate all the
20594 indexers and make sure their IndexerNames match.
20596 * typemanager.cs (IndexerPropertyName): Added support for interface
20599 2002-07-22 Martin Baulig <martin@gnome.org>
20601 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
20602 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
20603 ret if HasReturnLabel.
20604 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
20607 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
20608 and set the ec.LoopBeginTryCatchLevel.
20609 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
20610 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
20611 the current ec.TryCatchLevel, the branch goes out of an exception
20612 block. In this case, we need to use Leave and not Br.
20614 2002-07-22 Martin Baulig <martin@gnome.org>
20616 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
20617 block unless the block does not always return or it is contained in
20618 another try { ... } catch { ... } block. Fixes bug #26506.
20619 Added verify-1.cs to the test suite.
20621 2002-07-22 Martin Baulig <martin@gnome.org>
20623 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
20624 then we do not always return. Fixes bug #24985.
20626 2002-07-22 Martin Baulig <martin@gnome.org>
20628 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
20629 lookup on a per-class level; ie. walk up the class hierarchy until we
20630 found at least one applicable method, then choose the best among them.
20631 Fixes bug #24463 and test-29.cs.
20633 2002-07-22 Martin Baulig <martin@gnome.org>
20635 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
20636 return types of the methods. The return type is not part of the
20637 signature and we must not check it to make the `new' modifier work.
20638 Fixes bug #27999, also added test-147.cs.
20639 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
20641 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
20642 on the method's return type.
20644 2002-07-21 Martin Baulig <martin@gnome.org>
20646 * assign.cs: Make this work if the rightmost source is a constant and
20647 we need to do an implicit type conversion. Also adding a few more tests
20648 to test-38.cs which should have caught this.
20650 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
20651 target in the makefile for this. The makefile.gnu is primarily intended
20652 for end-users who don't want to debug the compiler.
20654 2002-07-21 Martin Baulig <martin@gnome.org>
20656 * assign.cs: Improved the Assign class so it can now handle embedded
20657 assignments (X = Y = Z = something). As a side-effect this'll now also
20658 consume less local variables. test-38.cs now passes with MCS, added
20659 a few new test cases to that test.
20661 2002-07-20 Martin Baulig <martin@gnome.org>
20663 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
20664 instructions. Fixes bug #27977, also added test-146.cs.
20666 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20668 * cs-tokenizer.cs: fixed getHex ().
20670 2002-07-19 Martin Baulig <martin@gnome.org>
20672 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
20673 not Type.GetType() to lookup the array type. This is needed when
20674 we're constructing an array of a user-defined type.
20675 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
20676 single-dimensional arrays, but also for single-dimensial arrays of
20679 2002-07-19 Martin Baulig <martin@gnome.org>
20681 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
20682 this function is called, it's not allowed to share LocalBuilders
20683 among ILGenerators.
20685 2002-07-19 Martin Baulig <martin@gnome.org>
20687 * expression.cs (Argument.Resolve): Report an error 118 when trying
20688 to pass a type as argument.
20690 2002-07-18 Martin Baulig <martin@gnome.org>
20692 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
20693 Conv_R_Un for the signed `long' type.
20695 2002-07-15 Miguel de Icaza <miguel@ximian.com>
20697 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
20698 `expr' for the temporary result, as that will fail if we do
20699 multiple resolves on the same expression.
20701 2002-07-05 Miguel de Icaza <miguel@ximian.com>
20703 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
20704 ec.TypeContainer for looking up aliases.
20706 * class.cs (TypeContainer): Remove LookupAlias from here.
20708 * decl.cs (DeclSpace); Move here.
20710 2002-07-01 Miguel de Icaza <miguel@ximian.com>
20712 * class.cs (FindMembers): Only call filter if the constructor
20713 bulider is not null.
20715 Also handle delegates in `NestedTypes' now. Now we will perform
20716 type lookups using the standard resolution process. This also
20719 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
20720 This uses Expressions (the limited kind that can be parsed by the
20721 tree) instead of strings.
20723 * expression.cs (ComposedCast.ToString): Implement, used to flag
20724 errors since now we have to render expressions.
20726 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
20729 * ecore.cs (SimpleName.ToString): ditto.
20731 * cs-parser.jay: Instead of using strings to assemble types, use
20732 Expressions to assemble the type (using SimpleName, ComposedCast,
20733 MemberAccess). This should fix the type lookups in declarations,
20734 because we were using a different code path for this.
20736 * statement.cs (Block.Resolve): Continue processing statements
20737 even when there is an error.
20739 2002-07-17 Miguel de Icaza <miguel@ximian.com>
20741 * class.cs (Event.Define): Also remove the `remove' method from
20742 the list of pending items.
20744 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
20745 generate more compact code.
20747 2002-07-17 Martin Baulig <martin@gnome.org>
20749 * const.cs (Const.LookupConstantValue): Add support for constant
20750 `unchecked' and `checked' expressions.
20751 Also adding test case test-140.cs for this.
20753 2002-07-17 Martin Baulig <martin@gnome.org>
20755 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
20756 check whether mi.ReturnType implements the IEnumerator interface; the
20757 `==' and the IsAssignableFrom() will fail in this situation.
20759 2002-07-16 Ravi Pratap <ravi@ximian.com>
20761 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
20764 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20766 * expression.cs: fixed bug #27811.
20768 2002-07-14 Miguel de Icaza <miguel@ximian.com>
20770 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
20771 Molaro: when we are a ref, the value already contains a pointer
20772 value, do not take the address of it.
20774 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20775 * removed mb-parser.jay and mb-tokenizer.cs
20777 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20779 * expression.cs: check against the building corlib void type.
20781 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
20783 * ecore.cs: fix for valuetype static readonly fields: when
20784 initializing them, we need their address, not the address of a copy.
20786 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
20788 * typemanager.cs: register also enum_type in corlib.
20790 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20792 * class.cs: allow calling this (but not base) initializers in structs.
20794 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
20796 * ecore.cs: make sure we compare against the building base types
20799 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
20801 * typemanager.cs: fix TypeToCoreType() to handle void and object
20802 (corlib gets no more typerefs after this change).
20804 2002-07-12 Miguel de Icaza <miguel@ximian.com>
20806 * expression.cs (ArrayCreation.EmitArrayArguments): use
20807 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
20809 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
20810 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
20811 array indexes, the runtime actually forbids them.
20813 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
20814 for array arguments here.
20816 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
20817 instead of the default for ValueTypes.
20819 (New.DoEmit): Use IsValueType instead of
20820 IsSubclassOf (value_type)
20821 (New.DoResolve): ditto.
20822 (Invocation.EmitCall): ditto.
20824 * assign.cs (Assign): ditto.
20826 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
20827 Statements *are* currently doing part of their resolution during
20830 Expressions do always resolve during resolve, but statements are
20831 only required to propagate resolution to their children.
20833 2002-07-11 Miguel de Icaza <miguel@ximian.com>
20835 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
20837 (LoadAssembly): Do not add the dll if it is already specified
20839 (MainDriver): Add the System directory to the link path at the end,
20840 after all the other -L arguments.
20842 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
20843 wrong opcode for loading bytes and bools (ldelem.i1 instead of
20844 ldelem.u1) and using the opposite for sbytes.
20846 This fixes Digger, and we can finally run it.
20848 * driver.cs (UnixParseOption): Move the option parsing here.
20849 (CSCParseOption): Implement CSC-like parsing of options.
20851 We now support both modes of operation, the old Unix way, and the
20852 new CSC-like way. This should help those who wanted to make cross
20853 platform makefiles.
20855 The only thing broken is that /r:, /reference: and /lib: are not
20856 implemented, because I want to make those have the same semantics
20857 as the CSC compiler has, and kill once and for all the confussion
20858 around this. Will be doing this tomorrow.
20860 * statement.cs (Unsafe.Resolve): The state is checked during
20861 resolve, not emit, so we have to set the flags for IsUnsfe here.
20863 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20865 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
20866 not catch the Error_ObjectRefRequired in SimpleName (as it is
20867 possible to have a class/instance variable name that later gets
20868 deambiguated), we have to check this here.
20870 2002-07-10 Ravi Pratap <ravi@ximian.com>
20872 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
20873 make static and put into Expression.
20875 (Event.Define): Register the private field of the event with the
20876 TypeManager so that GetFieldFromEvent can get at it.
20878 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
20879 keep track of the private field associated with an event which
20882 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
20885 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
20887 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20889 * expression.cs (Binary.EmitBranchable): this routine emits the
20890 Binary expression in a branchable context. This basically means:
20891 we need to branch somewhere, not just get the value on the stack.
20893 This works together with Statement.EmitBoolExpression.
20895 * statement.cs (Statement.EmitBoolExpression): Use
20898 2002-07-09 Miguel de Icaza <miguel@ximian.com>
20900 * statement.cs (For): Reduce the number of jumps in loops.
20902 (For): Implement loop inversion for the For statement.
20904 (Break): We can be breaking out of a Try/Catch controlled section
20905 (foreach might have an implicit try/catch clause), so we need to
20906 use Leave instead of Br.
20908 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
20909 now). If the instace expression supports IMemoryLocation, we use
20910 the AddressOf method from the IMemoryLocation to extract the
20911 address instead of emitting the instance.
20913 This showed up with `This', as we were emitting the instance
20914 always (Emit) instead of the Address of This. Particularly
20915 interesting when This is a value type, as we dont want the Emit
20916 effect (which was to load the object).
20918 2002-07-08 Miguel de Icaza <miguel@ximian.com>
20920 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
20922 * statement.cs (Checked): Set the CheckedState during the resolve
20923 process too, as the ConvCast operations track the checked state on
20924 the resolve process, and not emit.
20926 * cs-parser.jay (namespace_member_declaration): Flag that we have
20927 found a declaration when we do. This is used to flag error 1529
20929 * driver.cs: Report ok when we display the help only.
20931 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
20933 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
20935 2002-07-04 Miguel de Icaza <miguel@ximian.com>
20937 * cs-tokenizer.cs (define): We also have to track locally the
20938 defines. AllDefines is just used for the Conditional Attribute,
20939 but we also need the local defines for the current source code.
20941 2002-07-03 Miguel de Icaza <miguel@ximian.com>
20943 * statement.cs (While, For, Do): These loops can exit through a
20944 Break statement, use this information to tell whether the
20945 statement is the last piece of code.
20947 (Break): Flag that we break.
20949 * codegen.cs (EmitContexts): New `Breaks' state variable.
20951 2002-07-03 Martin Baulig <martin@gnome.org>
20953 * class.cs (TypeContainer.MethodModifiersValid): Allow override
20954 modifiers in method declarations in structs. Otherwise, you won't
20955 be able to override things like Object.Equals().
20957 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20959 * class.cs (Method, Property, Indexer): Do not allow the public
20960 modifier to be used in explicit interface implementations.
20962 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
20963 override modifiers in method declarations in structs
20965 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
20967 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
20968 integer or real overflow, report an error
20970 2002-07-02 Martin Baulig <martin@gnome.org>
20972 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
20973 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
20974 to tell the runtime about our newly created System.Object and
20975 System.ValueType types.
20977 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20979 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
20980 struct instead of Ldarg/Starg.
20982 2002-07-02 Martin Baulig <martin@gnome.org>
20984 * expression.cs (Indirection.Indirection): Call
20985 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
20987 2002-07-02 Martin Baulig <martin@gnome.org>
20989 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
20990 ValueType, call TypeManager.TypeToCoreType() on it.
20991 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
20992 the OpCodes.Newarr argument.
20994 2002-07-02 Martin Baulig <martin@gnome.org>
20996 * expression.cs (Invocation.EmitCall): When compiling corlib,
20997 replace all calls to the system's System.Array type to calls to
20998 the newly created one.
21000 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
21001 System.Array methods.
21002 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
21003 from the system's System.Array type which must be replaced.
21005 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
21007 * typemanager.cs: load unverifiable_code_ctor so we can build
21008 corlib using the correct type. Avoid using GetTypeCode() with
21010 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
21011 TypeManager.object_type to allow building corlib.
21013 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
21015 * ecore.cs: handle System.Enum separately in LoadFromPtr().
21017 2002-07-01 Martin Baulig <martin@gnome.org>
21019 * class.cs: Make the last change actually work, we need to check
21020 whether `ifaces != null' to avoid a crash.
21022 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21024 * class.cs: when we build structs without fields that implement
21025 interfaces, we need to add the interfaces separately, since there is
21026 no API to both set the size and add the interfaces at type creation
21029 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21031 * expression.cs: the dimension arguments to the array constructors
21032 need to be converted if they are a long.
21034 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
21036 * class.cs: don't emit ldarg.0 if there is no parent constructor
21037 (fixes showstopper for corlib).
21039 2002-06-29 Martin Baulig <martin@gnome.org>
21041 MCS now compiles corlib on GNU/Linux :-)
21043 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
21044 ie. check for MethodImplOptions.InternalCall.
21046 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
21047 and TypeManager.attribute_type are null, so we must explicitly check
21048 whether parent is not null to find out whether it's an attribute type.
21049 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
21050 and SetBuilder, not only if the property is neither abstract nor external.
21051 This is necessary to set the MethodImplOptions on the accessor methods.
21052 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
21053 SetBuilder, see Property.Emit().
21055 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
21056 populate "System.Object", "System.ValueType" and "System.Attribute" since
21057 they've already been populated from BootCorlib_PopulateCoreTypes().
21059 2002-06-29 Martin Baulig <martin@gnome.org>
21061 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
21062 is the NullLiteral, we also need to make sure that target_type is not
21065 2002-06-29 Martin Baulig <martin@gnome.org>
21067 * rootcontext.cs (RootContext.ResolveCore): We must initialize
21068 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
21069 before calling BootstrapCorlib_ResolveDelegate ().
21071 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21073 * statement.cs: fixed build-breaker. All tests passed ok.
21075 2002-06-27 Martin Baulig <martin@gnome.org>
21077 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
21078 for System.Decimal when compiling corlib.
21080 2002-06-27 Martin Baulig <martin@gnome.org>
21082 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
21083 switch blocks which contain nothing but a default clause.
21085 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
21087 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
21089 2002-06-27 Martin Baulig <martin@gnome.org>
21091 * ecore.cs (PropertyExpr.PropertyExpr): Call
21092 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
21094 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
21095 is already a TypeBuilder.
21097 2002-06-27 Martin Baulig <martin@gnome.org>
21099 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
21100 `target_type == TypeManager.array_type', not IsAssignableFrom() in
21101 the "from an array-type to System.Array" case. This makes it work
21102 when compiling corlib.
21104 2002-06-27 Martin Baulig <martin@gnome.org>
21106 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
21107 non-static PropertyExpr, set its InstanceExpression. This makes
21108 the `ICollection.Count' property work in System/Array.cs.
21110 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
21112 * driver.cs: Made error handling more consistent. Errors now
21113 tracked by Report class, so many methods which used to return int
21114 now return void. Main() now prints success/failure and
21115 errors/warnings message.
21117 Renamed '--probe' compiler argument to '--expect-error'. Removed
21118 the magic number return values (123 and 124). Now, if the
21119 expected error occurs, the compiler exits with success (exit value
21120 0). If the compilation completes without seeing that particular
21121 error, the compiler exits with failure (exit value 1). The
21122 makefile in mcs/errors has been changed to handle the new behaviour.
21124 * report.cs: Made 'expected error' number a property and renamed
21125 it from 'Probe' to 'ExpectedError'.
21127 * genericparser.cs: Removed error handling support, since it is
21128 now all done by Report class.
21130 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
21131 class, so parse() no longer returns an int.
21133 * namespace.cs: Use Report.Error instead of GenericParser.error
21135 2002-06-22 Miguel de Icaza <miguel@ximian.com>
21137 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
21138 TypeContainer.AddOperator): At the front of the list put the
21139 explicit implementations, so they get resolved/defined first.
21141 2002-06-21 Miguel de Icaza <miguel@ximian.com>
21143 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
21144 interface type is implemented by this TypeContainer. Used during
21145 explicit interface implementation.
21147 (Property.Define, Indexer.Define, Method.Define): Validate that
21148 the given interface in the explicit implementation is one of the
21149 base classes for the containing type.
21151 Also if we are explicitly implementing an interface, but there is
21152 no match in the pending implementation table, report an error.
21154 (Property.Define): Only define the property if we are
21155 not explicitly implementing a property from an interface. Use the
21156 correct name also for those properties (the same CSC uses,
21157 although that is really not needed).
21159 (Property.Emit): Do not emit attributes for explicitly implemented
21160 properties, as there is no TypeBuilder.
21162 (Indexer.Emit): ditto.
21164 Hiding then means that we do not really *implement* a pending
21165 implementation, which makes code fail.
21167 2002-06-22 Martin Baulig <martin@gnome.org>
21169 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
21170 the return value of Object.GetType(). [FIXME: we need to do this whenever
21171 we get a type back from the reflection library].
21173 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
21175 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
21177 2002-06-20 Miguel de Icaza <miguel@ximian.com>
21179 * attribute.cs: Return null if we can not look up the type.
21181 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
21182 the interface types found.
21184 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
21185 interface types found.
21187 * typemanager.cs (GetInterfaces): Make this routine returns alll
21188 the interfaces and work around the lame differences between
21189 System.Type and System.Reflection.Emit.TypeBuilder in the results
21190 result for GetInterfaces.
21192 (ExpandInterfaces): Given an array of interface types, expand and
21193 eliminate repeated ocurrences of an interface. This expands in
21194 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
21197 2002-06-21 Martin Baulig <martin@gnome.org>
21199 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
21202 2002-06-21 Martin Baulig <martin@gnome.org>
21204 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
21205 and called with one of the core types, return the corresponding typebuilder for
21208 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
21211 2002-06-21 Martin Baulig <martin@gnome.org>
21213 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
21214 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
21215 (Expression.ConvertReferenceExplicit): Likewise.
21217 * expression.cs (ElementAccess.DoResolve): Likewise.
21218 (ElementAccess.DoResolveLValue): Likewise.
21220 2002-06-10 Martin Baulig <martin@gnome.org>
21222 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
21223 add the "value" parameter to the parameter list.
21225 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
21228 2002-06-19 Miguel de Icaza <miguel@ximian.com>
21230 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
21231 the argument to an int, uint, long or ulong, per the spec. Also
21232 catch negative constants in array creation.
21234 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
21236 * class.cs: do not allow the same interface to appear twice in
21237 the definition list.
21239 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
21241 * ecore.cs: don't use ldlen with System.Array.
21243 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
21245 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
21247 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
21249 * modifiers.cs: produce correct field attributes for protected
21250 internal. Easy fix so miguel can work on ther harder stuff:-)
21252 2002-06-18 Miguel de Icaza <miguel@ximian.com>
21254 * pending.cs: New file. Move the code from class.cs here.
21255 Support clearning the pending flag for all methods (when not doing
21256 explicit interface implementation).
21258 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
21260 * rootcontext.cs: added a couple more types needed to bootstrap.
21262 2002-06-17 Miguel de Icaza <miguel@ximian.com>
21264 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
21265 constructor in the type, instead of any constructor in the type
21266 hierarchy. Thanks to Paolo for finding this bug (it showed up as
21267 a bug in the Mono runtime when applying the params attribute).
21269 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
21270 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
21272 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
21274 * expression.cs (Unary.ResolveOperator): Use TypeManager
21275 to resolve the type.
21277 2002-06-13 Ravi Pratap <ravi@ximian.com>
21279 * cs-parser.jay (enum_member_declaration): Pass in the attributes
21282 * enum.cs (AddEnumMember): Add support to store the attributes associated
21283 with each member too.
21285 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
21286 field builders too - this takes care of the enum member case.
21288 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
21290 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
21291 address-of operator on both value types and pointers.
21293 2002-06-10 Martin Baulig <martin@gnome.org>
21295 * interface.cs (Interface.PopulateIndexer): Add the indexer's
21296 PropertyBuilder to the `property_builders' list.
21298 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
21299 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
21300 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
21301 find any indexers which are inherited from an interface.
21303 2002-06-09 Martin Baulig <martin@gnome.org>
21305 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
21306 the same type as the constant if necessary. There's also a test-130.cs
21309 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
21311 * typemanager.cs (TypeManager.ChangeType): Previously known as
21312 Enum.ChangeEnumType().
21314 2002-06-09 Martin Baulig <martin@gnome.org>
21316 * expression.cs (Cast.TryReduce): Added support for consts.
21318 2002-06-08 Ravi Pratap <ravi@ximian.com>
21320 * class.cs (Accessor): Hold attributes information so we can pass
21323 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
21324 Modify to pass in attributes attached to the methods.
21326 (add_accessor_declaration, remove_accessor_declaration): Ditto.
21328 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
21329 to handle the Accessor kind :-)
21331 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
21333 2002-06-08 Martin Baulig <martin@gnome.org>
21335 * expression.cs (Unary.TryReduceNegative): Added support for
21338 2002-06-08 Martin Baulig <martin@gnome.org>
21340 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
21341 name can't be found in the `defined_names' - the caller will do a
21342 MemberLookup in this case and thus find methods in System.Enum
21343 such as Enum.IsDefined().
21345 2002-06-08 Martin Baulig <martin@gnome.org>
21347 * enum.cs (Enum.ChangeEnumType): This is a custom version of
21348 Convert.ChangeType() which works with TypeBuilder created types.
21349 (Enum.LookupEnumValue, Enum.Define): Use it here.
21351 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
21352 `TypeBuilder.BaseType != null' check.
21353 (TypeContainer.FindMembers): Only lookup parent members if we
21354 actually have a parent.
21355 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
21356 (ConstructorInitializer.Resolve): Likewise.
21358 * interface.cs (Interface.FindMembers): Added
21359 `TypeBuilder.BaseType != null' check.
21361 * rootcontext.cs (RootContext.ResolveCore): Added
21362 "System.Runtime.CompilerServices.IndexerNameAttribute" to
21363 classes_second_stage.
21365 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
21366 debug_type and trace_type when compiling with --nostdlib.
21368 2002-06-07 Martin Baulig <martin@gnome.org>
21370 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
21371 (AddField): Set it to true when adding a non-static field.
21372 (DefineType): Use `have_nonstatic_fields' to find out whether we
21373 have non-static fields, not `Fields != null'.
21375 2002-06-02 Miguel de Icaza <miguel@ximian.com>
21377 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
21378 dereferencing a null on the static-field code path)
21380 2002-05-30 Martin Baulig <martin@gnome.org>
21382 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
21383 to take command line arguments. Use reflection to call the new
21384 custom `Initialize' function on the symbol writer and pass it the
21385 command line arguments.
21387 * driver.cs (--debug-args): New command line argument to pass command
21388 line arguments to the symbol writer.
21390 2002-05-28 Miguel de Icaza <miguel@ximian.com>
21392 * assign.cs (DoResolve): Forgot to do the implicit conversion to
21393 the target type for indexers and properties. Thanks to Joe for
21396 2002-05-27 Miguel de Icaza <miguel@ximian.com>
21398 * typemanager.cs (MethodFlags): returns the method flags
21399 (Obsolete/ShouldIgnore) that control warning emission and whether
21400 the invocation should be made, or ignored.
21402 * expression.cs (Invocation.Emit): Remove previous hack, we should
21403 not do this on matching a base type, we should do this based on an attribute
21405 Only emit calls to System.Diagnostics.Debug and
21406 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
21407 on the command line.
21409 * rootcontext.cs: Global settings for tracing and debugging.
21411 * cs-tokenizer.cs (define): New utility function to track
21412 defines. Set the global settings for TRACE and DEBUG if found.
21414 2002-05-25 Ravi Pratap <ravi@ximian.com>
21416 * interface.cs (Populate*): Pass in the TypeContainer as well as
21417 the DeclSpace as parameters so that we can create EmitContexts and
21418 then use that to apply attributes etc.
21420 (PopulateMethod, PopulateEvent, PopulateProperty)
21421 (PopulateIndexer): Apply attributes everywhere.
21423 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
21426 (ApplyAttributes): Update accordingly.
21428 We now apply interface attributes for all members too.
21430 2002-05-26 Miguel de Icaza <miguel@ximian.com>
21432 * class.cs (Indexer.Define); Correctly check if we are explicit
21433 implementation (instead of checking the Name for a ".", we
21434 directly look up if the InterfaceType was specified).
21436 Delay the creation of the PropertyBuilder.
21438 Only create the PropertyBuilder if we are not an explicit
21439 interface implementation. This means that explicit interface
21440 implementation members do not participate in regular function
21441 lookups, and hence fixes another major ambiguity problem in
21442 overload resolution (that was the visible effect).
21444 (DefineMethod): Return whether we are doing an interface
21447 * typemanager.cs: Temporary hack until we get attributes in
21448 interfaces (Ravi is working on that) and we get IndexerName
21449 support in interfaces.
21451 * interface.cs: Register the indexers as properties.
21453 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
21454 warning, I have verified that this is a bug in the .NET runtime
21455 (JavaScript suffers of the same problem).
21457 * typemanager.cs (MemberLookup): When looking up members for
21458 interfaces, the parent of an interface is the implicit
21459 System.Object (so we succeed in searches of Object methods in an
21460 interface method invocation. Example: IEnumerable x; x.ToString
21463 2002-05-25 Miguel de Icaza <miguel@ximian.com>
21465 * class.cs (Event): Events should also register if they do
21466 implement the methods that an interface requires.
21468 * typemanager.cs (MemberLookup); use the new GetInterfaces
21471 (GetInterfaces): The code used to lookup interfaces for a type is
21472 used in more than one place, factor it here.
21474 * driver.cs: Track the errors at the bottom of the file, we kept
21477 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
21478 instance if the method we are calling is static!
21480 2002-05-24 Miguel de Icaza <miguel@ximian.com>
21482 * attribute.cs (ApplyAttributes): Make this function filter out
21483 the IndexerName attribute (as that attribute in reality is never
21484 applied) and return the string constant for the IndexerName
21487 * class.cs (TypeContainer.Emit): Validate that all the indexers
21488 have the same IndexerName attribute, and if so, set the
21489 DefaultName attribute on the class.
21491 * typemanager.cs: The return value might contain other stuff (not
21492 only methods). For instance, consider a method with an "Item"
21493 property and an Item method.
21495 * class.cs: If there is a problem with the parameter types,
21498 2002-05-24 Ravi Pratap <ravi@ximian.com>
21500 * ecore.cs (ImplicitConversionExists): Wrapper function which also
21501 looks at user defined conversion after making a call to
21502 StandardConversionExists - we need this for overload resolution.
21504 * expression.cs : Update accordingly the various method calls.
21506 This fixes 2 bugs filed against implicit user defined conversions
21508 2002-05-22 Miguel de Icaza <miguel@ximian.com>
21510 * statement.cs: Track the result of the assignment.
21512 2002-05-21 Miguel de Icaza <miguel@ximian.com>
21514 * expression.cs (MemberAccess): Improved error reporting for
21515 inaccessible members.
21517 2002-05-22 Martin Baulig <martin@gnome.org>
21519 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
21520 itself with debugging support.
21522 2002-05-22 Martin Baulig <martin@gnome.org>
21524 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
21525 Removed, this isn't needed anymore.
21527 2002-05-20 Martin Baulig <martin@gnome.org>
21529 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
21530 be underlying type for an enum.
21532 2002-05-20 Miguel de Icaza <miguel@ximian.com>
21534 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
21535 that splits out the loading of just the core types.
21537 * rootcontext.cs (ResolveCore): Split the struct resolution in
21538 two, so we can load the enumeration underlying types before any
21541 * expression.cs (Is): Bandaid until we fix properly Switch (see
21542 bug #24985 for details).
21544 * typemanager.cs (ImplementsInterface): The hashtable will contain
21545 a null if there are no interfaces implemented.
21547 2002-05-18 Miguel de Icaza <miguel@ximian.com>
21549 * cs-parser.jay (indexer_declarator): It is fine to have array
21552 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21554 * typemanager.cs: (RegisterBuilder): New function used to register
21555 TypeBuilders that implement interfaces. Since
21556 TypeBuilder.GetInterfaces (as usual) does not work with lame
21558 (AddUserType): register interfaces.
21560 (ImplementsInterface): Use the builder_to_ifaces hash if we are
21561 dealing with TypeBuilder. Also, arrays are showing up as
21562 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
21563 methods can not be invoked on them!
21565 * ecore.cs (ExplicitReferenceConversionExists): Made public.
21566 (ImplicitReferenceConversionExists): Split out from
21567 StandardConversionExists.
21569 * expression.cs (As): We were only implementing one of the three
21570 cases for the as operator. We now implement them all.
21571 (Is): Implement the various other cases for Is as well.
21573 * typemanager.cs (CACHE): New define used to control if we want or
21574 not the FindMembers cache. Seems to have a negative impact on
21575 performance currently
21577 (MemberLookup): Nested types have full acess to
21578 enclosing type members
21580 Remove code that coped with instance/static returns for events, we
21581 now catch this in RealFindMembers.
21583 (RealFindMembers): only perform static lookup if the instance
21584 lookup did not return a type or an event.
21586 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21588 * assign.cs (CompoundAssign): We pass more semantic information
21589 now to Compound Assignments than we did before: now we have all
21590 the information at hand, and now we resolve the target *before* we
21591 do the expression expansion, which allows the "CacheValue" method
21592 to have the effect we intended (before, a [x] += 1 would generate
21593 two differen ArrayAccess expressions from the ElementAccess,
21594 during the resolution process).
21596 (CompoundAssign.DoResolve): Resolve target and original_source here.
21598 2002-05-16 Miguel de Icaza <miguel@ximian.com>
21600 * expression.cs (ArrayAccess): dropped debugging information.
21602 * typemanager.cs: Small bug fix: I was always returning i_members,
21603 instead of one of i_members or s_members (depending on which had
21606 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
21607 method is invoked before any code generation takes place, and it
21608 is a mechanism to inform that the expression will be invoked more
21609 than once, and that the method should use temporary values to
21610 avoid having side effects
21612 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
21614 * ecore.cs (Expression.CacheTemporaries): Provide empty default
21617 * expression.cs (Indirection, ArrayAccess): Add support for
21618 CacheTemporaries in these two bad boys.
21620 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
21621 ldobj or ldind_ref.
21622 (StoreFromPtr): Handle stobj as well.
21624 * expression.cs (UnaryMutator): Share more code.
21626 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
21627 down: I was not tracking the Filter function as well, which
21628 was affecting the results of the cache.
21630 2002-05-15 Miguel de Icaza <miguel@ximian.com>
21632 * attribute.cs: Remove the hack to handle the CharSet property on
21635 2002-05-14 Miguel de Icaza <miguel@ximian.com>
21637 * attribute.cs (DoResolve): More uglyness, we now only try to
21638 resolve the attribute partially, to extract the CharSet
21639 information (only if we are a StructLayout attribute). Otherwise
21641 (GetExtraTypeInfo): Add some code to conditionally kill in the
21642 future this. I am more and more convinced that the .NET
21643 framework has special code to handle the attribute setting on
21646 * expression.cs (IsParamsMethodApplicable): Revert my previous
21647 foreach change here, it was wrong.
21649 2002-05-13 Miguel de Icaza <miguel@ximian.com>
21651 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
21652 (pp_expr): do not abort on unknown input, just return.
21653 (eval): abort if there are pending chars.
21655 * attribute.cs (Attribute.Resolve): Positional parameters are
21656 optional. Deal with that case.
21658 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
21659 the Ansi/Unicode/Auto information for the type.
21661 (TypeContainer.DefineType): instantiate the EmitContext here, as
21662 we will be using it during the type definition (to resolve
21663 attributes) and during the emit phase.
21665 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
21666 to pull type information out of the attributes
21668 (Attribute.Resolve): track the constructor builder, and allow for
21669 multiple invocations (structs and classes will use this).
21671 * ecore.cs (MemberLookupFinal): new version with all the
21672 parameters customizable.
21674 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
21675 constructors. Return if the result value is null (as the error
21676 would have been flagged already by MemberLookupFinal)
21678 Do not allow instances of abstract classes or interfaces to be
21681 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
21682 We have to compare the assembly property here when dealing with
21683 FamANDAssem and Assembly access modifiers, because we might be
21684 creating an assembly from *modules* (that means that we are not
21685 getting TypeBuilders for types defined in other modules that are
21686 part of this assembly).
21688 (Method.Emit): If the method is marked abstract and has a body,
21691 (TypeContainer.DefineMembers): If both the defined member and the
21692 parent name match are methods, then do not emit any warnings: let
21693 the Method.Define routine take care of flagging warnings. But if
21694 there is a mismatch (method overrides something else, or method is
21695 overriwritten by something, then emit warning).
21697 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
21698 set to null, this means `do not check for the return type on the
21701 (Method.Define): set the return type for the method signature to
21702 null, so that we get methods with the same name and parameters and
21703 different return types. This is used to flag warning 114 (you are
21704 hiding a method, and you probably want to use the new/override
21707 * typemanager.cs (MemberLookup): Implemented proper access
21708 control, closing a long standing set of bug reports. The problem
21709 was that the Framework only has two bits: Public and NonPublic,
21710 and NonPublic includes private and protected methods, but we need
21711 to enforce the FamANDAssem, FamOrAssem and Family.
21713 2002-05-11 Miguel de Icaza <miguel@ximian.com>
21715 * statement.cs (GotoCase): Return true: Ammounts to giving up
21716 knowledge on whether we return or not, and letting the other case
21717 be responsible for it.
21719 2002-05-10 Miguel de Icaza <miguel@ximian.com>
21721 * driver.cs: Do not load directories for each file processed, only
21722 do it if there is a pattern.
21724 * ecore.cs: Report readonly assigns here as well, as we might have
21725 been resolved only by MemberAccess.
21727 (SimpleName.SimpleNameResolve): Also be useful for LValue
21728 resolution. We need this to propagate assign to local readonly variables
21730 * typemanager.cs: Use a ptrhashtable for the criteria, because we
21731 do not want to reuse potential criteria memory.
21733 * class.cs (MyEventBuilder): Set reflected_type;
21735 * ecore.cs (Constantify): Added support for constifying bools.
21737 (RootContext.LookupType): Added a cache for values looked up in
21738 the declaration space.
21740 * typemanager.cs (FindMembers): Now is a front-end to
21741 RealFindMembers, and provides a two-level hashtable-based cache to
21744 15% performance improvement: from 22.5 to 19.2 seconds.
21746 * expression.cs (IsParamsMethodApplicable): use foreach.
21747 (Invocation.DoResolve): ditto.
21748 (New.DoResolve): ditto.
21749 (ArrayCreation.DoResolve): ditto.
21751 * ecore.cs (FindMostEncompassingType): use foreach.
21753 * delegate.cs (NewDelegate.DoResolve): Use foreach
21755 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
21756 (RemoveMethods): use foreach.
21758 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
21759 nested foreach statements instead of for, and also break out of
21760 the inner loop once a match is found.
21762 (Invocation.OverloadResolve): Use foreach, simplify the code.
21764 2002-05-08 Miguel de Icaza <miguel@ximian.com>
21766 * cfold.cs (BinaryFold): During an enumeration evaluation context,
21767 we actually unwrap the expression to allow for extra information
21770 * expression.cs: Use Shr_Un on unsigned operations.
21772 2002-05-08 Ravi Pratap <ravi@ximian.com>
21774 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
21775 applicable operators was not being considered correctly. This closes
21776 the bug Miguel reported.
21778 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
21780 * attribute.cs: check that the type derives from System.Attribute
21781 and report the correct error in that case (moved the duplicate code to
21782 its own method, too).
21784 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
21786 * attribute.cs: lookup attribute type name as the spec says: first the
21787 bare attribute name and then name + "Attribute" (nant compiles with
21788 mcs after this fix).
21790 2002-05-07 Miguel de Icaza <miguel@ximian.com>
21792 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
21793 Because of the way we parse things, we should try to see if a
21794 UIntConstant can fit in an integer.
21796 2002-05-07 Ravi Pratap <ravi@ximian.com>
21798 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
21799 when we are in an explicit context.
21801 (ConvertReferenceExplicit): When converting from Iface type S to Class
21802 T make sure the rules are implemented as an OR.
21804 * parameter.cs (ParameterType): Make it a property for now although the
21805 purpose really isn't anything immediate.
21807 * expression.cs (Is*Applicable): Do better checking on the parameter type
21808 of a ref/out parameter. The ones from the system assemblies are already
21809 marked with the correct type so we don't need to do any correction.
21811 * ecore.cs (StandardConversionExists): Conversion from Interface types to
21812 the object type is standard too so include that.
21814 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21816 * ecore.cs (StandardConversionExists): Augment with missing code:
21817 deal with IntConstant, LongConstants and Enumerations.
21819 * assign.cs: Report the error, instead of failing silently
21821 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
21822 typecontainer that they are declared, because the
21823 typecontainer/namespace will have the list of using clauses that
21824 need to be applied.
21826 Assembly Attributes were escaping the normal registration
21829 (EmitCode): Apply attributes within an EmitContext that represents
21830 the container they were declared on.
21832 * cs-parser.jay: Track bases for structs. How did I get this wrong?
21834 2002-05-06 Ravi Pratap <ravi@ximian.com>
21836 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
21837 Revamp completely - make much cleaner as we now operate only
21840 (FindMostSpecificSource, FindMostSpecificTarget): New methods
21841 to implement the logic detailed in the spec more correctly.
21843 (UserDefinedConversion): Update accordingly.
21845 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21847 * statement.cs: Return flow analysis information up.
21849 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
21852 (token): Do not consume an extra character before calling
21855 2002-05-06 Piers Haken <piersh@friskit.com>
21857 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
21859 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21861 * class.cs (Constructor.Emit): Set the IsStatic flag in the
21862 EmitContext during the instance constructor initializer
21863 resolution, to stop access to instance variables.
21865 This is mandated by the spec, last paragraph of the `constructor
21866 initializers' section.
21868 2002-05-05 Miguel de Icaza <miguel@ximian.com>
21870 * cs-parser.jay, class.cs (Accessor): new class used to represent
21871 an accessor (get or set). In the past we used `null' to represent
21872 a missing accessor. But this is ambiguous because there was no
21873 way to tell in abstract indexers/properties if one of them was
21876 Now there is a way of addressing that.
21878 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
21879 instead of FindMembers.
21881 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
21882 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
21884 * attribute.cs: Treat indexers and properties as the same in terms
21885 of applying attributes
21887 * ecore.cs (FindMostEncompassedType): Use statically initialized
21888 EmptyExpressions()s like we do elsewhere to avoid creating useless
21889 objects (and we take this out of the tight loop).
21891 (GetConversionOperators): Move the code to extract the actual
21892 operators to a separate routine to clean things up.
21894 2002-05-04 Miguel de Icaza <miguel@ximian.com>
21896 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
21897 events are always registered FieldBuilders.
21899 * class.cs (FieldBase): New class shared by Fields
21901 * delegate.cs: If we are a toplevel delegate, use our full name.
21902 If we are a nested delegate, then only use our tail name.
21904 2002-05-02 Ravi Pratap <ravi@ximian.com>
21906 * expression.cs (IsApplicable): Ensure that we add the "&" to
21907 ref/out types before comparing it with the type of the argument.
21909 (IsParamsMethodApplicable): Ditto.
21911 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
21914 * delegate.cs : Handle the case when we have more than one applicable
21915 method. Flag an error only when we finish checking all.
21917 2002-05-02 Miguel de Icaza <miguel@ximian.com>
21919 * expression.cs: Add support for boolean static initializers.
21921 2002-05-01 Miguel de Icaza <miguel@ximian.com>
21923 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
21925 * parameter.cs (ComputeParameterTypes,
21926 ComputeAndDefineParameterTypes): Better error handling: now we
21927 clear the `types' cache if we fail during any of the type lookups.
21928 We also return the status code correctly to our caller
21930 * delegate.cs: If we fail to define a delegate, abort the extra
21933 * expression.cs (Binary.ResolveOperator): for
21934 operator==(object,object) and operator !=(object, object) we also
21935 have to verify that there is an implicit conversion from one to
21938 (ArrayAccess.DoResolve): Array Access can operate on
21941 2002-04-30 Miguel de Icaza <miguel@ximian.com>
21943 * assign.cs (CompoundAssign): A new class used as a "flag" that
21944 the assignment actually is happening as part of a compound
21945 assignment operator.
21947 During compound assignment, a few new rules exist to enable things
21954 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
21955 to the type of x) if y is implicitly convertible to the type of x,
21956 and the operator is a builtin operator and the return type of the
21957 operator is explicitly convertible to the type of x.
21959 * rootcontext.cs: Reset warning level to 2. 4 catches various
21960 "interesting" features in mcs, we must clean this up at some
21961 point, but currently am trying to kill other bugs ;-)
21963 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
21964 in container classes as well.
21966 * expression.cs (Binary.ResolveOperator): Handle string case
21967 before anything else (as operator overloading does emit an error
21968 before doing anything else).
21970 This code could go away when we move to a table driven model, but
21971 i could not come up with a good plan last night.
21973 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
21975 * typemanager.cs (CSharpName): reimplementation using regex.
21976 * class.cs: added null check for fields in Emit
21977 * rootcontext.cs: set warninglevel to 4
21979 2002-04-29 Miguel de Icaza <miguel@ximian.com>
21981 * typemanager.cs (CSharpName): reimplemented with Lupus
21984 2002-04-28 Miguel de Icaza <miguel@ximian.com>
21986 * statement.cs (If): correclty implement Resolve, because we were
21987 not catching sem errors in there. The same process is needed
21989 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
21992 (Statement.Warning_DeadCodeFound): Factorize code.
21993 (While): Report dead code here too.
21995 (Statement): Added Resolve virtual method to allow
21996 for resolution split from the emit code.
21998 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22000 * statement.cs (EmitBoolExpression): No longer try to resolve the
22002 (MakeBoolean): New utility function that resolve, implicitly
22003 converts to boolean and tags the expression.
22006 (If, Do): Implement dead code elimination.
22007 (While): Implement loop inversion
22009 (Do, While, For, If): Resolve the expression prior to calling our
22012 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
22015 - added method Report28 (warning: program has more than one entry point)
22016 - added method IsEntryPoint, implements paragraph 10.1 of the spec
22017 - modified method Method.Define, the part at the end of the method
22019 * rootcontext.cs: added static public Location EntryPointLocation;
22021 * ../errors/cs0028.cs : Add test case for the above warning.
22024 - modified method CSharpName to allow arrays of primitive type to
22025 be printed nicely (e.g. instead of System.Int32[][] it now prints
22027 - added method CSharpSignature: returns the signature of a method
22028 in string format to be used in reporting errors, warnings, etc.
22030 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
22033 2002-04-26 Ravi Pratap <ravi@ximian.com>
22035 * delegate.cs (Define): Fix extremely silly bug where I was
22036 setting the type of the 'object' parameter of the BeginInvoke
22037 method to System.IAsyncResult instead of System.Object ;-)
22039 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22041 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
22044 (Constructor.Emit): return if we fail to initialize the
22045 constructor. Another door closed!
22047 * expression.cs (New.DoResolve): Improve error message (from -6 to
22048 1501). Use DeclaredOnly lookup to find the exact constructor.
22050 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
22051 loop. This is useful.
22053 * cs-parser.jay: Adjust the default parameters so that destructors
22054 have the proper signature.
22056 2002-04-26 Martin Baulig <martin@gnome.org>
22058 * driver.cs (LoadAssembly): If `assembly' contains any characters
22059 which are only valid in path names and not in assembly names
22060 (currently slash, backslash and point), use Assembly.LoadFrom ()
22061 instead of Assembly.Load () on the `assembly' (before iteration
22062 over the link_paths).
22064 2002-04-26 Martin Baulig <martin@gnome.org>
22066 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
22068 2002-04-25 Miguel de Icaza <miguel@ximian.com>
22070 * class.cs (Property): use the new typemanager.MemberLookup
22072 (TypeContainer.MemberLookup): Implement using the
22073 TypeManager.MemberLookup now.
22075 * typemanager.cs: Make MemberLookup a function of the TypeManager,
22076 and return MemberInfos, so that these can be used without an
22077 EmitContext (what we had before).
22079 2002-04-24 Miguel de Icaza <miguel@ximian.com>
22081 * expression.cs: Fix the case where the argument to params if the
22082 type of the params. I omitted handling this before. Fixed
22084 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22086 * driver.cs: Call BootCorlib_PopulateCoreType
22088 * class.cs (Property.CheckBase): Check for properties only, not
22091 * interface.cs: Temporary hack: try/catch around the
22092 CustomAttributeBuilder, because I am getting an exception that I
22095 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
22096 types whose definitions are required to be there (attributes are
22097 defined before standard types).
22099 Compute definitions as we boot the various types, as they are used
22100 immediately (value_type class will need object_type, but if we do
22101 not initialize object_type, we will pass a null, which will let
22102 the runtime pick the System.Object from the existing corlib, which
22103 is not what we want).
22105 2002-04-22 Patrik Torstensson <totte@labs2.com>
22107 * cs-tokenizer.cs: fixed a number of trim() issues.
22109 2002-04-22 Ravi Pratap <ravi@ximian.com>
22111 * expression.cs (Argument.Type): Ensure that we return the correct
22112 type when we have out or ref parameters [in which case we
22115 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22117 * class.cs (Property, Indexer): Allow extern modifier in there.
22119 * typemanager.cs (InitBaseTypes): Initializes object_type and
22120 value_type, since those will be used early on during the bootstrap
22121 process to compile corlib.
22123 (InitCoreTypes): Move code from here to InitBaseTypes.
22125 2002-04-21 Miguel de Icaza <miguel@ximian.com>
22127 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
22128 single-dimension arrays as using the ldlen opcode.
22130 Daniel Lewis discovered this optimization.
22132 * typemanager.cs: Add signature for System.Array::get_Length
22134 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22136 * statement.cs: report the error when the foreach does not apply to an
22137 array nor a collection.
22139 2002-04-19 Miguel de Icaza <miguel@ximian.com>
22141 * expression.cs: Add implicit conversions to the operator ~.
22143 * constant.cs (DecimalConstant.Emit): Emit decimal value.
22145 * typemanager.cs: Locate the decimal constructor.
22147 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22149 * attribute.cs: use the new property of TypeOf.
22150 * expression.cs: added 'get' property around typearg.
22152 These changes fix a build breaker reported by NickD. Is this the
22153 correct way to fix? If not, please, revert my changes and make it
22156 2002-04-17 Miguel de Icaza <miguel@ximian.com>
22158 * attribute.cs: Add support for typeof in attribute invocations.
22159 I am not sure that this is right though.
22161 2002-04-14 Duncan Mak <duncan@ximian.com>
22163 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
22164 Binary.Operator.Division case.
22166 2002-04-13 Ravi Pratap <ravi@ximian.com>
22168 * class.cs (DefineType): Ensure that we do a proper check on
22169 attribute types and also register it with the TypeManager.
22171 (TypeContainer.Targets): The default for attribute types is
22172 AttributeTargets.All.
22174 * attribute.cs (ApplyAttributes): Registering the attribute type
22175 is done elsewhere, not when we discover we have a Usage attribute.
22177 2002-04-12 Ravi Pratap <ravi@ximian.com>
22179 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
22180 and get rid of is_delegate parameter.
22182 * everywhere : update.
22184 2002-04-12 Ravi Pratap <ravi@ximian.com>
22186 * cs-parser.jay (compilation_unit): Revamp completely to use
22187 some new ideas that I got from Rhys' grammar to solve the problems
22188 with assembly level attributes.
22190 (outer_declaration): New grammar production.
22192 (attribute_sections): Add.
22194 (opt_attributes): Base on attribute_sections
22196 (namespace_declaration): Allow opt_attributes to tackle the case
22197 when we have assembly level attributes - we are clever in this
22200 * attribute.cs (ApplyAttributes): Do not worry about assembly
22201 attributes in the non-global context.
22203 * rootcontext.cs (AddGlobalAttributes): Go back to using this
22204 instead of SetGlobalAttributes.
22206 * class.cs, rootcontext.cs : Ensure we define and generate
22207 attribute types before anything else.
22209 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
22210 and flag the new error -20 for the case when the attribute type
22211 does not have valid targets specified. csc does not catch this.
22213 * ../errors/errors.txt : update for error # -20
22215 2002-04-11 Ravi Pratap <ravi@ximian.com>
22217 * support.cs (InternalParameters.ParameterModifier): Do some null
22218 checking and return sane values.
22220 * class.cs (Method.Define): If we are a PInvoke method, ensure
22221 that we are static and extern. Report error # 601
22223 * ../errors/cs0601.cs : Add test case for the above error.
22225 2002-04-07 Ravi Pratap <ravi@ximian.com>
22227 * rootcontext.cs (attribute_types): We need to keep type of
22228 all attribute types separately and emit code for them first.
22230 (RegisterAttribute) : Implement.
22232 * class.cs (DefineType): Check if the current Type is a custom
22233 attribute type and register it accordingly.
22235 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
22236 adding the first attribute twice and rename to
22238 (SetGlobalAttributes): this.
22240 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
22243 * attribute.cs (ApplyAttributes): Take an additional argument telling us
22244 if we are processing global arguments. Hmm, I am unsure of this.
22246 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22248 * expression.cs: added static array of strings to avoid calling
22249 Enum.ToString () for Operator in Binary. Significant recover of
22252 2002-04-10 Miguel de Icaza <miguel@ximian.com>
22254 * class.cs (FindMembers): Allow the Builders of the various
22255 members to be null. If they are skip them. This only happens
22256 during the PInvoke declaration.
22258 2002-04-09 Miguel de Icaza <miguel@ximian.com>
22260 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
22261 failure, so we do not keep going afterwards.
22263 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
22264 wanted to pass `false' as the `is_delegate' argument. If this is
22265 the case, why not use delegate_type == null to mean `is_delegate =
22266 false' and anything else as is_delegate = true.
22268 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
22270 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
22271 code for the section, not the beginning of the tests.
22273 2002-04-08 Miguel de Icaza <miguel@ximian.com>
22275 * cfold.cs: Handle operator + (Enum x, Underlying x)
22277 * expression.cs (Binary): same. Warn about errors where we have
22278 Enum/Enum in operator + as well.
22280 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
22283 - added support for switch(bool)
22284 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
22285 - add TableSwitchEmit() to handle table-based switch statements
22287 2002-04-05 Ravi Pratap <ravi@ximian.com>
22289 * expression.cs (Invocation.OverloadResolve): Factor out code which
22290 does parameter compatibility checking with arguments so that we can
22291 re-use the code even from Delegate.VerifyApplicability
22293 (VerifyArgumentsCompat): Move above code here.
22295 * delegate.cs (VerifyApplicability): Get rid of duplicate code
22296 and instead make a call to the above method.
22298 2002-03-31 Ravi Pratap <ravi@ximian.com>
22300 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
22301 We use it to keep track of classes which are attribute types.
22303 2002-04-02 Miguel de Icaza <miguel@ximian.com>
22305 * delegate.cs (Delegate.Define): Correctly define the types in the
22306 presence of fixed and array parameters.
22308 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
22311 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
22312 include NonPublic after the first iteration.
22314 * class.cs (Indexer.CheckBase): Only check if both parents are
22317 * cs-parser.jay (accessor_body): If empty, set to null.
22319 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
22320 same code path here to resolve constants names that we did have in
22321 MemberAccess.DoResolve. There is too much code duplicated here.
22323 2002-04-01 Miguel de Icaza <miguel@ximian.com>
22325 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
22327 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
22330 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
22331 tokens, numbers and strings.
22333 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
22336 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
22337 asyncronous parameters and the regular parameters.
22339 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
22340 specify the target directory.
22342 * expression.cs: (This.DoResolve): Simplify
22343 (As.Emit): Optimize, do not generate IsInst if the expression is
22344 always of the given type.
22346 (Is.DoResolve): Bug fix, we were reporting both always/never for
22349 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
22350 creating too many unnecessary arrays.
22352 2002-03-31 Miguel de Icaza <miguel@ximian.com>
22354 * class.cs (EmitFieldInitializer): Use Assign expression to assign
22355 fields instead of rolling our own initializer. Takes care of all
22356 implicit conversions, and drops unnecessary static checks/argument.
22358 2002-03-31 Dick Porter <dick@ximian.com>
22360 * driver.cs: use the GetDirectories() return values properly, and
22361 use "/" as path separator.
22363 2002-03-30 Miguel de Icaza <miguel@ximian.com>
22365 * expression.cs (Unary): Optimize - - expr into expr.
22366 (Binary): Optimize a + (-b) into a -b.
22368 * codegen.cs (CodeGen): Made all methods static.
22370 2002-03-29 Miguel de Icaza <miguel@ximian.com>
22374 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
22375 TypeBuilder property.
22377 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
22380 * tree.cs: Removed the various RecordXXXX, and replaced with a
22381 single RecordDecl. Removed all the accessor methods, and just
22382 left a single access point Type
22384 * enum.cs: Rename DefineEnum to DefineType.
22386 * decl.cs: New abstract method `DefineType' used to unify the
22387 Defines for Enumerations, Interfaces, TypeContainers and
22390 (FindType): Moved LookupInterfaceOrClass here. Moved the
22391 LookupBaseClasses method that used to live in class.cs and
22392 interface.cs here, and renamed to FindType.
22394 * delegate.cs: Implement DefineType. Take advantage of the
22395 refactored pattern for locating the parent builder without taking
22396 the parent_builder argument (which we know does not work if we are
22397 nested, and triggering a toplevel definition).
22399 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22401 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
22402 accessibility of a member has changed during override and report
22405 * class.cs (Method.Define, Property.Define): Only complain on
22406 overrides if the method is private, any other accessibility is
22407 fine (and since we just checked the permission is the same, we are
22410 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
22411 and elif are processed always. The other pre-processing
22412 directives are only processed if we are "taking" the path
22414 2002-03-29 Martin Baulig <martin@gnome.org>
22416 * class.cs (Method.Emit): Only emit symbolic debugging info if the
22417 current location is not Null.
22419 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
22420 a separate method so we can profile it.
22422 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
22423 `span.Seconds' are just seconds, but no minutes or hours.
22424 (MainDriver): Profile the CodeGen.SaveSymbols calls.
22426 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22428 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
22429 Remove the gratuitous set of Final:
22431 // If an interface implementation, then we can set Final.
22432 if (((flags & MethodAttributes.Abstract) == 0) &&
22433 implementing.DeclaringType.IsInterface)
22434 flags |= MethodAttributes.Final;
22436 I do not know what I was smoking when I used that.
22439 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
22440 step into fixing the name resolution issues for delegates and
22441 unifying the toplevel name resolution.
22443 2002-03-28 Martin Baulig <martin@gnome.org>
22445 * class.cs (Method.Emit): If we have a symbol writer, call its
22446 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
22447 tell it about the current method.
22449 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
22450 writer that we're going to emit the first byte of IL code for a new
22451 statement (a new source line).
22452 (EmitContext.EmitTopBlock): If we have a symbol writer, call
22453 EmitContext.Mark() before emitting any code.
22455 * location.cs (SymbolDocument): Return null when we're Null.
22457 * statement.cs (Statement): Moved the `Location loc' variable here.
22458 (Statement.EmitBoolExpression): If we have a symbol writer, call
22459 ec.Mark() before emitting any code to tell it that we're at the
22460 beginning of a new statement.
22461 (StatementExpression): Added `Location' argument to the constructor.
22462 (Block): Added public readonly variable `StartLocation' and public
22463 variable `EndLocation'. The latter is to be set using SetEndLocation().
22464 (Block): Added constructor which takes a start and end location.
22465 (Block.SetEndLocation): New method. This sets the end location.
22466 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
22467 local variables we create.
22468 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
22469 each statement and do also mark the begin and end of the block.
22471 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
22472 tell it the current lexer.Location, use Location.Null for the end of the
22474 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
22475 current block, set its end location using SetEndLocation().
22476 (statement_expression): StatementExpression constructor now takes the
22477 lexer.Location as additional argument.
22478 (for_statement, declare_local_variables): Likewise.
22479 (declare_local_variables): When creating a new implicit block, use the
22480 new Block constructor and pass it the lexer.Location.
22482 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22484 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
22485 members also on the parent interfaces recursively.
22487 2002-03-27 Miguel de Icaza <miguel@ximian.com>
22489 * report.cs: Use new formats, since Gonzalo finished the missing
22492 * expression.cs (Binary.ResolveOperator): added missing operator|
22493 operator& and operator^ for bool/bool.
22495 * cs-parser.jay: CheckDef now takes a Location argument that is
22496 used to report errors more precisly (instead of reporting the end
22497 of a definition, we try to track something which is a lot closer
22498 to the source of the problem).
22500 * cs-tokenizer.cs: Track global token use, so we can properly flag
22501 the use of #define/#undef after the first token has been seen.
22503 Also, rename the reportXXXX to Error_DescriptiveName
22505 * decl.cs (DeclSpace.IsTopLevel): Move property here from
22506 TypeContainer, so that Enum and Interface can use this too.
22508 * class.cs (TypeContainer.LookupInterfaceOrClass,
22509 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
22510 `builder' argument. Typically this was used to pass the parent
22511 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
22514 The problem is that a nested class could trigger the definition of
22515 a toplevel class, and the builder would be obviously wrong in that
22518 So we drop this argument, and we compute dynamically the
22519 TypeBuilder/ModuleBuilder (the correct information was available
22520 to us anyways from DeclSpace.Parent)
22522 * interface.cs (Interface.DefineInterface): Drop builder
22523 parameter cleanup like class.cs
22525 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
22528 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
22531 (Try.Emit): Propagate the returns value from the statement.
22533 (Return.Emit): Even if we are leavning
22535 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
22537 * modifiers.cs: Fix the computation of MethodAttributes flags.
22539 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
22541 * driver.cs: allow compilation of files that start with '/'.
22542 Add a default case when checking the argument of --target.
22544 2002-03-25 Miguel de Icaza <miguel@ximian.com>
22546 * interface.cs: Implement the same search algorithm for types in
22547 the interface code.
22549 * delegate.cs: Do not allow multiple definition.
22551 * Recovered ChangeLog that got accidentally amputated
22553 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
22555 * rootcontext.cs: Load manually enum to allow core classes to
22556 contain enumerations.
22558 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
22559 Update to new static methods in TypeManager.
22561 * typemanager.cs (GetMethod, GetConstructor): Use our
22562 implementation of FindMembers to find the members, since during
22563 corlib compilation, the types are TypeBuilders and GetMethod and
22564 GetConstructor do not work.
22566 Make all methods in TypeManager static.
22568 (InitCodeHelpers): Split the functionality from
22569 the InitCodeTypes function.
22571 * driver.cs: Call InitCodeHelpers after we have populated the
22574 * cs-parser.jay (delegate_declaration): we did not used to compute
22575 the delegate name correctly for void delegates.
22577 2002-03-24 Miguel de Icaza <miguel@ximian.com>
22579 * rootcontext.cs (RootContext): Init the interface_resolve_order
22580 and type_container_resolve_order always.
22582 (ResolveCore, BootstrapCorlib_ResolveClass,
22583 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
22584 compiler when compiling with --nostdlib
22586 * class.cs (TypeContainer.DefineType): Check that our parent is
22587 not null. This test is most important when we are bootstraping
22590 * codegen.cs: Split out the symbol writing code.
22592 2002-03-25 Martin Baulig <martin@gnome.org>
22594 * driver.cs (-g): Made -g an alias for --debug.
22596 2002-03-24 Martin Baulig <martin@gnome.org>
22598 * codegen.cs (SymbolWriter): New public variable. Returns the
22599 current symbol writer.
22600 (CodeGen): Added `bool want_debugging_support' argument to the
22601 constructor. If true, tell the ModuleBuild that we want debugging
22602 support and ask it for the ISymbolWriter.
22603 (Save): If we have a symbol writer, call it's Close() method after
22604 saving the assembly.
22606 * driver.c (--debug): New command line argument to create a
22607 debugger information file.
22609 * location.cs (SymbolDocument): New public property. Returns an
22610 ISymbolDocumentWriter object for the current source file or null
22611 if we don't have a symbol writer.
22613 2002-03-21 Miguel de Icaza <miguel@ximian.com>
22615 * driver.cs (LoadAssembly): Correctly return when all the paths
22616 have been tried and not before.
22618 * statement.cs (Switch.Emit): return the actual coverage for this
22619 statement (returns/not-returns)
22621 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
22622 switch of the statement if we are the last switch section. That
22623 kills two problems: try/catch problems (we used to emit an empty
22624 nop at the end) and switch statements where all branches would
22627 2002-03-19 Miguel de Icaza <miguel@ximian.com>
22629 * driver.cs: Add default assemblies (the equivalent to the
22630 Microsoft CSC.RSP file)
22632 * cs-tokenizer.cs: When updating `cols and setting it to zero,
22633 also update tokens_seen and set it to false.
22635 * driver.cs: Implement --recurse for Mike.
22637 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
22638 correctly splitting out the paths.
22640 2002-03-18 Miguel de Icaza <miguel@ximian.com>
22642 * interface.cs (Interface.PopulateProperty): Instead of using
22643 `parent' as the declaration space for the set parameters, use
22646 * support.cs (InternalParameters): InternalParameters constructor
22647 takes a DeclSpace instead of a TypeContainer.
22649 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
22650 types are being initialized, load the address of it before calling
22653 (New): Provide a mechanism to disable the generation of local
22654 value type temporaries when the caller will be providing us with
22655 an address to store it.
22657 (ArrayCreation.EmitDynamicInitializers): Use it.
22659 2002-03-17 Miguel de Icaza <miguel@ximian.com>
22661 * expression.cs (Invocation.EmitArguments): Only probe for array
22662 property if there is more than one argument. Sorry about that.
22664 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
22665 empty param arrays.
22667 * class.cs (Method.LabelParameters): Fix incorrect code path that
22668 prevented the `ParamArrayAttribute' from being applied to the
22671 2002-03-16 Miguel de Icaza <miguel@ximian.com>
22673 * support.cs (ReflectionParameters): Correctly compute whether the
22674 last argument is a params array. Fixes the problem with
22677 * typemanager.cs: Make the assemblies array always be non-null
22678 (empty, but non-null)
22680 * tree.cs (RecordDecl): New function that abstracts the recording
22681 of names. This reports error 101, and provides a pointer to the
22682 previous declaration. Fixes a crash in the compiler.
22684 * cs-parser.jay (constructor_declaration): Update to new grammar,
22685 and provide a constructor_body that can be empty.
22687 2002-03-15 Miguel de Icaza <miguel@ximian.com>
22689 * driver.cs: Add support for --resources.
22691 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
22692 Make all types for the various array helper methods be integer.
22694 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
22695 CheckState to ConvCast.
22697 (ConvCast): Now it takes a `checked' state argument, to avoid
22698 depending on the emit context for the conversion, and just using
22699 the resolve time setting.
22701 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
22702 instead of Invocation.EmitArguments. We do not emit the original
22703 arguments, instead we emit those which have been converted to
22704 unsigned int expressions.
22706 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
22708 * codegen.cs: ditto.
22710 * expression.cs (LocalVariableReference): Drop the use of the
22711 Store function that depended on the variable index.
22713 * statement.cs (VariableInfo): Drop the `Idx' property from this
22714 class, as this is not taking into account the indexes for
22715 temporaries tat we generate during the execution, getting the
22718 * class.cs: First emit class initializers, then call the parent
22721 * expression.cs (Binary): Fix opcode emision.
22722 (UnaryMutator.EmitCode): Support checked code generation
22724 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
22725 matches for events for both the Static and Instance scans,
22726 pointing to the same element. Fix that.
22728 2002-03-14 Miguel de Icaza <miguel@ximian.com>
22730 * rootcontext.cs (ResolveTree): Always set the
22731 interface_resolve_order, because nested interfaces will be calling
22734 * class.cs (GetInterfaceOrClass): Track the same resolution
22735 process used by TypeManager.LookupType. This fixes the nested
22736 type lookups in class declarations (separate path from
22739 (TypeContainer.DefineType): Also define nested interfaces.
22740 (TypeContainer.RegisterOrder): New public function used to
22741 register the order in which child interfaces need to be closed.
22743 Nested interfaces need to be closed after their parents have been
22746 * interface.cs (InterfaceAttr): Put all the logic for computing
22747 the interface attribute here.
22749 (DefineInterface): Register our interface order with the
22750 RootContext or with the TypeContainer depending on the case.
22752 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22754 * cs-parser.jay: rework foreach statement to work with the new
22755 changes to the policy on SimpleNames.
22757 * report.cs: support Stacktrace on warnings as well.
22759 * makefile: drop --unsafe and /unsafe from the compile.
22761 2002-03-13 Ravi Pratap <ravi@ximian.com>
22763 * ecore.cs (StandardConversionExists): Modify to take an Expression
22764 as the first parameter. Ensure we do null -> reference type conversion
22767 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
22768 temporary Expression objects.
22770 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
22772 * interface.cs: workaround bug in method overloading resolution
22773 (there is already a bugzilla bug for it).
22775 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22777 We could also solve this problem by having a separate path for
22778 performing type lookups, instead of DoResolve, we could have a
22779 ResolveType entry point, and only participating pieces of the
22780 production (simplename, deref, array) would implement this.
22782 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
22783 signal SimpleName to only resolve type names and not attempt to
22784 resolve anything else.
22786 * expression.cs (Cast): Set the flag.
22788 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
22790 * class.cs: Only report 108 if there is no `new' modifier.
22792 * cs-parser.jay: rework foreach statement to work with the new
22793 changes to the policy on SimpleNames.
22795 * report.cs: support Stacktrace on warnings as well.
22797 * makefile: drop --unsafe and /unsafe from the compile.
22799 2002-03-11 Miguel de Icaza <miguel@ximian.com>
22801 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22802 lookups here, instead of doing that at parse time. This means
22803 that our grammar will not introduce `LocalVariableReferences' as
22804 expressions at this point. That solves the problem of code like
22808 static void Main ()
22812 This is only half the fix. The full fix requires parameters to
22813 also be handled in this way.
22815 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
22816 makes the use more obvious of the DeclSpace. The
22817 ec.TypeContainer.TypeBuilder is now only used to pull the
22818 TypeBuilder for it.
22820 My theory is that I can get rid of the TypeBuilder completely from
22821 the EmitContext, and have typecasts where it is used (from
22822 DeclSpace to where it matters).
22824 The only pending problem is that the code that implements Aliases
22825 is on TypeContainer, and probably should go in DeclSpace.
22827 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22828 lookups here, instead of doing that at parse time. This means
22829 that our grammar will not introduce `LocalVariableReferences' as
22830 expressions at this point. That solves the problem of code like
22834 static void Main ()
22838 This is only half the fix. The full fix requires parameters to
22839 also be handled in this way.
22841 * class.cs (Property.DefineMethod): When implementing an interface
22842 method, set newslot, when implementing an abstract method, do not
22843 set the flag (before we tried never setting it, or always setting
22844 it, which is the difference).
22845 (Indexer.DefineMethod): same.
22846 (Method.DefineMethod): same.
22848 * ecore.cs: Only set the status used flag if we get back a Field.
22850 * attribute.cs: Temporary hack, so Paolo can keep working.
22852 2002-03-08 Ravi Pratap <ravi@ximian.com>
22854 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
22855 the unmanaged type in the case we have a MarshalAs attribute.
22857 (Resolve): Handle the case when we are parsing the special MarshalAs
22858 attribute [we need to store the unmanaged type to use later]
22860 * typemanager.cs (marshal_as_attr_type): Built in type for the
22861 MarshalAs Attribute.
22863 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
22864 on parameters and accordingly set the marshalling info.
22866 2002-03-09 Miguel de Icaza <miguel@ximian.com>
22868 * class.cs: Optimizing slightly by removing redundant code after
22869 we switched to the `NoTypes' return value.
22870 (Property.DefineMethod): use NoTypes here too.
22872 This fixes the bug I introduced in my last batch of changes.
22874 2002-03-05 Ravi Pratap <ravi@ximian.com>
22876 * tree.cs (RecordEnum): Add. We now keep track of enums too.
22878 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
22879 Enums since those are types too.
22881 * cs-parser.jay (enum_declaration): Record enums as we parse them.
22883 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
22884 thanks to a call during the lookup process.
22886 2002-03-07 Miguel de Icaza <miguel@ximian.com>
22888 * statement.cs (Foreach): Lots of work to accomodate a particular
22889 kind of foreach statement that I had not kept in mind. It is
22890 possible to have foreachs on classes that provide a GetEnumerator
22891 method that return objects that implement the "pattern" for using
22892 a foreach, there is no need to support GetEnumerator
22895 This is needed to compile nant.
22897 * decl.cs: Only report 114 if the member is not `Finalize' and if
22898 the warning level is at least 2.
22900 * class.cs: Moved the compare function from Method to
22903 (MethodSignature.InheritableMemberSignatureCompare): Add new
22904 filter function that is used to extract inheritable methods from a
22907 (Method.Define): Use the new `inheritable_method_signature_filter'
22910 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
22913 2002-03-06 Miguel de Icaza <miguel@ximian.com>
22915 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
22917 * cs-parser.jay: Add opt_semicolon to the interface declaration.
22919 * expression.cs: Pass location information to
22920 ConvertImplicitStandard.
22922 * class.cs: Added debugging code to track return values from
22925 2002-03-05 Miguel de Icaza <miguel@ximian.com>
22927 * expression.cs (Is.DoResolve): If either side of the `is' is an
22928 interface, do not flag the warning.
22930 * ecore.cs (ImplicitReferenceConversion): We need a separate test
22933 * report.cs: Allow for --fatal to be used with --probe.
22935 * typemanager.cs (NoTypes): Move the definition for the empty Type
22938 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
22940 (TypeContainer.DefineProxy): New function used to proxy to parent
22941 implementations when implementing interfaces.
22942 (TypeContainer.ParentImplements): used to lookup if our parent
22943 implements a public function that is required by an interface.
22944 (TypeContainer.VerifyPendingMethods): Hook this up.
22946 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
22947 `modules' and `assemblies' arraylists into arrays. We only grow
22948 these are the very early start up of the program, so this improves
22949 the speedof LookupType (nicely measured).
22951 * expression.cs (MakeByteBlob): Replaced unsafe code with
22952 BitConverter, as suggested by Paolo.
22954 * cfold.cs (ConstantFold.Binary): Special case: perform constant
22955 folding of string concatenation, but if either side is a string,
22956 and the other is not, then return null, and let the runtime use
22957 the concatenation on the string plus the object (using
22958 `Object.ToString').
22960 2002-03-04 Miguel de Icaza <miguel@ximian.com>
22962 Constant Folding has been implemented now.
22964 * expression.cs (Unary.Reduce): Do not throw an exception, catch
22965 the error instead on types that are not supported in one's
22968 * constant.cs (Constant and all children): New set of functions to
22969 perform implict and explicit conversions.
22971 * ecore.cs (EnumConstant): Implement the new functions to perform
22972 conversion by proxying to the child expression.
22974 * codegen.cs: (ConstantCheckState): Constant evaluation has its
22975 own separate setting that can not be turned off from the command
22976 line using --unchecked or --checked and is only controlled using
22977 the checked/unchecked statements and expressions. This setting is
22978 used by the constant folder to flag errors.
22980 * expression.cs (CheckedExpr, UncheckedExpr): Set the
22981 ConstantCheckState as well.
22983 During Resolve, they also have to flag the state, because the
22984 constant folder runs completely in the Resolve phase.
22986 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
22989 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22991 * cfold.cs: New file, this file contains the constant folder.
22993 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
22994 argument to track whether we are using the resulting address to
22995 load or store a value and provide better error messages.
22997 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
22998 new AddressOf arguments.
23000 * statement.cs (Foreach.EmitCollectionForeach): Update
23002 * expression.cs (Argument.Emit): Call AddressOf with proper
23003 arguments to track usage.
23005 (New.DoEmit): Call AddressOf with new arguments.
23007 (Unary.Emit): Adjust AddressOf call.
23009 2002-03-01 Ravi Pratap <ravi@ximian.com>
23011 * cs-parser.jay (member_access): Change the case for pre-defined types
23012 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
23015 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
23018 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
23019 essentially like methods and apply attributes like MethodImplOptions to them too.
23021 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
23024 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
23025 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
23028 * Update code everywhere accordingly.
23030 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
23032 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
23034 2002-02-28 Ravi Pratap <ravi@ximian.com>
23036 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
23037 try performing lookups against those instead of jumping straight into using
23038 the 'using' clauses.
23040 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
23042 (LookupType): Perform lookups in implicit parents too.
23044 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
23045 sequence as RootContext.LookupType.
23047 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
23048 the various cases of namespace lookups into this method.
23050 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23052 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
23053 in positional arguments)
23055 * class.cs (Operator): Update the AllowedModifiers to contain
23058 * cs-parser.jay: Update operator declaration to allow for the
23059 operator body to be empty.
23061 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
23064 2002-02-27 Miguel de Icaza <miguel@ximian.com>
23066 * class.cs (Method.Emit): Label parameters.
23068 * driver.cs: Return 1 or 0 as the program exit code.
23070 2002-02-26 Miguel de Icaza <miguel@ximian.com>
23072 * expression.cs: Special case the `null' object when trying to
23073 auto-compute the type, as anything can be explicitly converted to
23076 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
23077 spotting this Paolo.
23079 (Expression.ImplicitNumericConversion): Perform comparissions of
23080 the type using the underlying type in the case of an enumeration
23081 rather than using the enumeration type for the compare.
23083 Cope with the underlying == type case, which is not possible to
23086 (Expression.ConvertNumericExplicit): Perform comparissions of
23087 the type using the underlying type in the case of an enumeration
23088 rather than using the enumeration type for the compare.
23090 * driver.cs: If the user does not supply an extension, assume .exe
23092 * cs-parser.jay (if_statement): Rewrote so that we can track the
23093 location for the if statement.
23095 * expression.cs (Binary.ConstantFold): Only concat strings when
23096 the operation is "+", not everything ;-)
23098 * statement.cs (Statement.EmitBoolExpression): Take a location
23100 (If, While, Do): Track location.
23102 * expression.cs (Binary.ResolveOperator): In the object + string
23103 case, I was missing a call to ConvertImplicit
23105 2002-02-25 Ravi Pratap <ravi@ximian.com>
23107 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
23108 Location arguments. Ensure we use RootContext.LookupType to do our work
23109 and not try to do a direct Type.GetType and ModuleBuilder.GetType
23111 * interface.cs (PopulateMethod): Handle the type of the parameter being
23114 * expression.cs (Invocation.BetterFunction): Handle the case when we
23115 have a params method with no fixed arguments and a call is made with no
23118 2002-02-25 Miguel de Icaza <miguel@ximian.com>
23120 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
23121 the verbatim-string-literal
23123 * support.cs (InternalParameters.ParameterModifier): handle null
23125 (InternalParameters.ParameterType): ditto.
23127 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
23128 duplicating the name of the variable parameter.
23129 (GetParameterByName): Fix bug where we were not looking up array
23130 paramters if they were the only present (thanks Paolo!).
23131 (GetParameterInfo): We only have an empty set of types if both
23132 fixed and array are set to null.
23133 (GetParameterInfo-idx): Handle FixedParameter == null
23135 * cs-parser.jay: Handle the case where there is no catch
23136 statements (missing null test).
23138 2002-02-22 Miguel de Icaza <miguel@ximian.com>
23140 * driver.cs (MainDriver): Be conservative on our command line
23143 Catch DirectoryNotFoundException when calling GetFiles.
23145 (SplitPathAndPattern): Used to split the input specification into
23146 a path and a pattern that we can feed to Directory.GetFiles.
23148 2002-02-21 Miguel de Icaza <miguel@ximian.com>
23150 * statement.cs (Fixed): Implement the last case of the Fixed
23151 statement (string handling).
23153 * expression.cs (StringPtr): New class used to return a char * to
23154 a string; Used by the Fixed statement.
23156 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
23158 * expression.cs (Binary.ResolveOperator): Remove redundant
23159 MemberLookup pn parent type.
23160 Optimize union call, we do not need a union if the types are the same.
23161 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
23164 Specialize the use of MemberLookup everywhere, instead of using
23165 the default settings.
23167 (StackAlloc): Implement stackalloc keyword.
23169 * cs-parser.jay: Add rule to parse stackalloc.
23171 * driver.cs: Handle /h, /help, /?
23173 * expression.cs (MakeByteBlob): Removed the hacks we had in place
23174 before we supported unsafe code.
23176 * makefile: add --unsafe to the self compilation of mcs.
23178 2002-02-20 Miguel de Icaza <miguel@ximian.com>
23180 * expression.cs (PointerArithmetic): New class that is used to
23181 perform pointer arithmetic.
23182 (Binary.Resolve): Handle pointer arithmetic
23183 Handle pointer comparission.
23184 (ArrayPtr): Utility expression class that is used to take the
23185 address of an array.
23187 (ElementAccess): Implement array access for pointers
23189 * statement.cs (Fixed): Implement fixed statement for arrays, we
23190 are missing one more case before we are done.
23192 * expression.cs (Indirection): Implement EmitAssign and set the
23193 ExprClass to Variable. This allows pointer dereferences to be
23194 treated as variables, and to have values assigned to them.
23196 * ecore.cs (Expression.StoreFromPtr): New utility function to
23197 store values dereferencing.
23199 2002-02-20 Ravi Pratap <ravi@ximian.com>
23201 * expression.cs (Binary.ResolveOperator): Ensure that we are
23202 not trying to operate on a void type - this fixes the reported
23205 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
23206 the parent implementation is sealed.
23208 * ../errors/cs0239.cs : Add.
23210 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
23212 * typemanager.cs (unverifiable_code_type): Corresponds to
23213 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
23214 which have unsafe code in them.
23216 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
23219 2002-02-19 Miguel de Icaza <miguel@ximian.com>
23221 * cs-tokenizer.cs: Add support for @"litreal strings"
23223 Make tokenizer accept pre-processor directives
23224 on any column (remove the old C-like limitation).
23226 * rootcontext.cs (EmitCode): Emit any global attributes.
23227 (AddGlobalAttributes): Used to keep track of assembly attributes.
23229 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
23231 * cs-parser.jay: Add support for global attributes.
23233 2002-02-17 Miguel de Icaza <miguel@ximian.com>
23235 * expression.cs (Indirection): New helper class. Unary will
23236 create Indirection classes to be able to implement the
23237 IMemoryLocation interface on it.
23239 2002-02-16 Miguel de Icaza <miguel@ximian.com>
23241 * cs-parser.jay (fixed_statement): reference the right statement.
23243 * statement.cs (Fixed.Emit): Finish implementing the fixed
23244 statement for the &x case.
23246 2002-02-14 Miguel de Icaza <miguel@ximian.com>
23248 * class.cs (Property.Define, Method.Define): Remove newslot when
23251 * modifiers.cs: My use of NewSlot when `Abstract' was set was
23252 wrong. NewSlot should only be used if the `new' keyword is present.
23254 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
23255 locating our system dir. Sorry about this.
23257 2002-02-13 Miguel de Icaza <miguel@ximian.com>
23259 * driver.cs (GetSystemDir): Compute correctly the location of our
23260 system assemblies. I was using the compiler directory instead of
23261 the library directory.
23263 2002-02-13 Ravi Pratap <ravi@ximian.com>
23265 * expression.cs (BetterFunction): Put back in what Miguel commented out
23266 since it is the correct fix. The problem is elsewhere ;-)
23268 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
23269 parameters of the parms method are themselves compatible or not !
23271 (StandardConversionExists): Fix very dangerous bug where we were forgetting
23272 to check that a class implements an interface before saying that an implicit
23273 conversion was allowed. Use ImplementsInterface to do the checking.
23275 2002-02-13 Miguel de Icaza <miguel@ximian.com>
23277 * class.cs (Method.Define): Track whether we are an explicit
23278 implementation or not. And only call DefineMethodOverride if we
23279 are an explicit implementation.
23281 (Property.DefineMethod): Ditto.
23283 2002-02-11 Ravi Pratap <ravi@ximian.com>
23285 * expression.cs (BetterFunction): Catch hideous bug which was
23286 preventing us from detecting ambiguous calls due to implicit casts i.e
23289 2002-01-29 Miguel de Icaza <miguel@ximian.com>
23291 * support.cs (Pair): Remove un-needed method. I figured why I was
23292 getting the error in cs-parser.jay, the variable in a foreach loop
23293 is readonly, and the compiler does not really treat this as a variable.
23295 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
23296 instead of EQUALS in grammar.
23298 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
23300 * expression.cs (Unary.DoResolve): Check whether the argument is
23303 2002-01-28 Miguel de Icaza <miguel@ximian.com>
23305 * support.cs: Api for Pair to set a value. Despite the fact that
23306 the variables are public the MS C# compiler refuses to compile
23307 code that accesses the field if the variable is part of a foreach
23310 * statement.cs (Fixed): Begin implementation of the fixed
23313 (Block.AddVariable): Return the VariableInfo on success and null
23314 on failure instead of true/false.
23316 * cs-parser.jay (foreach): Catch errors on variables already
23317 defined (we were ignoring this value before) and properly unwind
23318 the block hierarchy
23320 (fixed_statement): grammar for the fixed statement.
23322 2002-01-25 Miguel de Icaza <miguel@ximian.com>
23324 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
23325 pointer types to be incretemented.
23327 (SizeOf): Implement.
23329 * cs-parser.jay (pointer_member_access): Implement
23330 expr->IDENTIFIER production.
23332 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
23333 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
23336 (Unary): Implement indirection.
23338 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
23339 use in non-unsafe context).
23341 (SimpleName.DoResolve): Check for pointers in field access on safe
23344 (Expression.LoadFromPtr): Factor the load-indirect code in this
23345 function. This was duplicated in UnboxCast and ParameterReference
23347 2002-01-24 Miguel de Icaza <miguel@ximian.com>
23349 * expression.cs (ComposedCast): report an error if a pointer cast
23350 is used in a safe region.
23352 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
23353 pointer type casts in unsafe context.
23355 * codegen.cs (EmitContext): Set up IsUnsafe.
23357 * cs-parser.jay (non_expression_type): Add productions for pointer
23360 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
23361 code. We should not use force into static mode if the method is
23362 not virtual. Fixes bug in MIS
23364 * statement.cs (Do.Emit, While.Emit, For.Emit,
23365 Statement.EmitBoolExpression): Add support to Do and While to
23366 propagate infinite loop as `I do return' semantics.
23368 Improve the For case to also test for boolean constants.
23370 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
23371 to the list of attributes we can add.
23373 Remove `EmitContext' argument.
23375 * class.cs (Method.Define): Apply parameter attributes.
23376 (Constructor.Define): Apply parameter attributes.
23377 (MethodCore.LabelParameters): Move here the core of labeling
23380 * support.cs (ReflectionParameters.ParameterModifier,
23381 InternalParameters.ParameterModifier): Use IsByRef on the type and
23382 only return the OUT bit for these parameters instead of in/out/ref
23385 This is because I miss-understood things. The ParameterInfo.IsIn
23386 and IsOut represent whether the parameter has the [In] and [Out]
23389 2002-01-22 Miguel de Icaza <miguel@ximian.com>
23391 * ecore.cs (FieldExpr.Emit): Release temporaries.
23393 * assign.cs (LocalTemporary.Release): new function.
23395 * codegen.cs (EmitContext.GetTemporaryStorage,
23396 EmitContext.FreeTemporaryStorage): Rework the way we deal with
23397 temporary storage. Now we can "put back" localbuilders when we
23400 2002-01-21 Miguel de Icaza <miguel@ximian.com>
23402 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
23403 need to make a copy of the variable to generate verifiable code.
23405 2002-01-19 Miguel de Icaza <miguel@ximian.com>
23407 * driver.cs: Compute dynamically the system directory.
23409 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
23410 Slower, but more generally useful. Used by the abstract
23411 registering implementation.
23413 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
23414 the rules for the special rule on Type/instances. First check if
23415 we have the same name, and if so, try that special static path
23416 rather than the instance path.
23418 2002-01-18 Miguel de Icaza <miguel@ximian.com>
23420 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
23423 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
23424 Enum, ValueType, Delegate or Array for non-corlib compiles.
23426 * cs-tokenizer.cs: Catch long identifiers (645)
23428 * typemanager.cs (IndexerPropetyName): Ravi never tested this
23431 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
23432 fix, we were returning too early, so we were not registering
23433 pending methods from abstract classes.
23435 Do not register pending methods if the class is abstract.
23437 * expression.cs (Conditional.DoResolve): Report circular implicit
23438 conversions when we neecd to compute it for conditional
23441 (Is.DoResolve): If the expression is always of the provided type,
23442 flag warning 183. If the expression can not ever be of the
23443 provided type flag warning 184.
23445 * class.cs: Catch 169 as well.
23447 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
23450 2002-01-18 Nick Drochak <ndrochak@gol.com>
23452 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
23454 2002-01-17 Miguel de Icaza <miguel@ximian.com>
23456 * interface.cs: (PopulateMethod): Check for pointers being defined
23457 only if the unsafe context is active.
23458 (PopulateProperty): ditto.
23459 (PopulateIndexer): ditto.
23461 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
23462 specified. If pointers are present, make sure that they are
23463 present in an unsafe context.
23464 (Constructor, Constructor.Define): ditto.
23465 (Field, Field.Define): ditto.
23466 (Property, Property.Define): ditto.
23467 (Event, Event.Define): ditto.
23469 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
23470 hashtable if there are classes or structs defined.
23472 * expression.cs (LocalVariableReference.DoResolve): Simplify this
23473 code, as the constant resolution moved.
23475 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
23476 the metadata, so we can flag error 133.
23478 * decl.cs (MemberCore.UnsafeOK): New function to test that a
23479 pointer is being declared in an unsafe context.
23481 2002-01-16 Miguel de Icaza <miguel@ximian.com>
23483 * modifiers.cs (Modifiers.Check): Require a Location argument.
23484 Report error 227 for Unsafe use.
23486 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
23488 * statement.cs (For.Emit): If the test is null, then report that
23489 we do `return', as we wont reach anything afterwards.
23491 (Switch.SwitchGoverningType): Track the expression that matched
23494 * driver.cs: Allow negative numbers as an error code to flag.
23496 * cs-parser.jay: Handle 1551.
23498 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
23500 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23502 * cs-parser.jay: Report 1518 (type declaration can only contain
23503 class, struct, interface, enum or delegate)
23505 (switch_label): Report 1523 (keywords `case' or `default' must
23508 (opt_switch_sections): Report 1522 (empty switch)
23510 * driver.cs: Report 1515 (response file specified multiple times)
23511 Report 1516 (Source file specified multiple times).
23513 * expression.cs (Argument.Resolve): Signal 1510
23515 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
23516 access not allowed in static code)
23518 2002-01-11 Ravi Pratap <ravi@ximian.com>
23520 * typemanager.cs (IsPointerType): Utility method which we are going
23523 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
23524 the object type, so we take care of that.
23526 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
23528 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
23529 added to non-params parameters :-)
23531 * typemanager.cs (CSharpName): Include 'void' type too.
23533 (void_ptr_type): Include in the set of core types.
23535 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
23538 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
23541 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
23542 completely forgotten about it.
23544 2002-01-10 Ravi Pratap <ravi@ximian.com>
23546 * cs-parser.jay (pointer_type): Add. This begins our implementation
23547 of parsing rules for unsafe code.
23549 (unsafe_statement): Implement.
23551 (embedded_statement): Modify to include the above.
23553 * statement.cs (Unsafe): Implement new class for unsafe blocks.
23555 * codegen.cs (EmitContext.InUnsafe): Add. This determines
23556 if the current context is an unsafe one.
23558 * cs-parser.jay (local_variable_pointer_type): Since local variable types
23559 are handled differently, we need separate rules for them.
23561 (local_variable_declaration): Update to use local_variable_pointer_type
23562 to allow variable declarations of unmanaged pointer types.
23564 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
23565 in unsafe contexts.
23567 * ../errors/cs0214.cs : Add.
23569 2002-01-16 Nick Drochak <ndrochak@gol.com>
23571 * makefile: remove 'response' file when cleaning.
23573 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23575 * cs-parser.jay: Report 1524.
23577 2002-01-14 Miguel de Icaza <miguel@ximian.com>
23579 * typemanager.cs (RegisterMethod): drop checking if we have
23580 registered this from here
23582 2002-01-12 Miguel de Icaza <miguel@ximian.com>
23584 * class.cs (Method.EmitDestructor): Implement calling our base
23587 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
23588 value of InFinally.
23590 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
23591 this routine and will wrap the call in a try/catch block. Deal
23594 2002-01-11 Miguel de Icaza <miguel@ximian.com>
23596 * ecore.cs (Expression.MemberLookup): instead of taking a
23597 parameter `same_type' that was used to tell whether we could
23598 access private members we compute our containing type from the
23601 (FieldExpr): Added partial support for volatile fields. This does
23602 not work for volatile fields exposed from assemblies, as I can not
23603 figure out how to extract the modreq from it.
23605 Updated all the source files to use this.
23607 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
23608 because it is referenced by MemberLookup very often.
23610 2002-01-09 Ravi Pratap <ravi@ximian.com>
23612 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
23613 TypeBuilder.GetCustomAttributes to retrieve what we need.
23615 Get rid of redundant default_member_attr_type as this is the same as
23616 default_member_type which already exists.
23618 * interface.cs, attribute.cs : Update accordingly.
23620 2002-01-08 Miguel de Icaza <miguel@ximian.com>
23622 * typemanager.cs: Enable IndexerPropertyName again. It does not
23623 work for TYpeBuilders though. Ravi, can you please fix this?
23625 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
23627 * expression.cs (Argument.Emit): Handle the case of ref objects
23628 being passed to ref functions;
23630 (ParameterReference.EmitLoad): Loads the content of the pointer
23631 without dereferencing.
23633 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23635 * cs-tokenizer.cs: Implemented the pre-processing expressions.
23637 2002-01-08 Ravi Pratap <ravi@ximian.com>
23639 * class.cs (Indexer.DefineMethod): Incorporate the interface
23640 type in the name of the method if we are doing explicit interface
23643 * expression.cs (ConversionExists): Remove as it is completely obsolete.
23645 (BetterConversion): Fix extremely trivial bug where we were referring to
23646 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
23649 * ../errors/bug16.cs : Add although we have fixed it.
23651 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23653 * expression.cs (BaseIndexer): Begin implementation.
23655 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
23657 * cs-parser.jay (indexer_declarator): Use qualified_identifier
23658 production directly to remove a shift/reduce, and implement
23659 explicit interface implementation.
23661 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
23662 after a floating point suffix.
23664 * expression.cs (DoNumericPromotions): Improved the conversion for
23665 uint/uint. If we have a constant, we avoid doing a typecast to a
23668 * class.cs (Indexer): Implement explicit interface implementation
23671 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
23673 * class.cs: make the default instance constructor public and hidebysig.
23675 2001-01-03 Ravi Pratap <ravi@ximian.com>
23677 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
23678 so we can call it from elsewhere.
23680 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
23681 we emit it internally if the class has a defined indexer; otherwise the user
23682 emits it by decorating the class definition with the DefaultMemberAttribute.
23684 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
23685 attribute is not used on a type which defines an indexer.
23687 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
23688 character when we skip whitespace.
23690 * ../errors/cs0646.cs : Add.
23692 2002-01-03 Miguel de Icaza <miguel@ximian.com>
23694 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
23697 * makefile: Add practical target `mcs3.exe' which builds the third
23698 generation compiler.
23700 * expression.cs (New): Fix structures constructor calling.
23702 * class.cs (Property, Method, Indexer): Emit Final flag on the
23703 method if we are an interface implementation and we are not
23706 * ecore.cs (PropertyExpr): New public field `IsBase', tells
23707 whether this property is referencing a `base' method.
23709 * expression.cs (Invocation.EmitCall): take an extra argument:
23710 is_base, this is used to determine whether the `call' or
23711 `callvirt' opcode should be used.
23714 * delegate.cs: update EmitCall.
23716 * class.cs (Method.Define): Set NewSlot for the cases where we are
23717 not implementing an interface method.
23719 (Property.Define): ditto.
23721 2002-01-02 Miguel de Icaza <miguel@ximian.com>
23723 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
23724 'r'. Allows mcs to parse itself fully.
23726 2002-01-02 Ravi Pratap <ravi@ximian.com>
23728 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
23729 of the number of initializers that require the InitializeArray method.
23731 (CheckIndices): Store the Expression in all cases - not the plain value. Also
23732 update the above field where necessary.
23734 (MakeByteBlob): Update accordingly.
23736 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
23739 (EmitDynamicInitializers): Update in accordance with the new optimization.
23741 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
23742 same OpCode applies.
23744 * cs-parser.jay : Fix some glaring errors I introduced.
23746 2002-01-01 Ravi Pratap <ravi@ximian.com>
23748 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
23749 so that we can check for name clashes there too.
23751 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
23752 for interface indexers.
23754 * interfaces.cs (Define): Emit the default member attribute.
23756 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
23757 variable was being referred to while setting the value ;-)
23759 2002-01-01 Miguel de Icaza <miguel@ximian.com>
23761 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
23762 byte-by-byte information when we know the data is zero.
23764 Make the block always a multiple of 4, because
23765 DefineInitializedData has a bug.
23767 * assign.cs: Fix, we should assign from the temporary, not from
23770 * expression.cs (MakeByteBlob): Fix my incorrect code.
23772 2001-12-31 Miguel de Icaza <miguel@ximian.com>
23774 * typemanager.cs (EnumToUnderlying): This function is used to get
23775 the underlying type from an enumeration, because it does not
23778 * constant.cs: Use the I4_S form for values between -128 and 127.
23780 * statement.cs (Block.LookupLabel): Looks up a label.
23781 (Block): Drop support for labeled blocks.
23783 (LabeledStatement): New kind of statement that represents a label
23786 (Goto): Finally implement this bad boy.
23788 * cs-parser.jay: Update to reflect new mechanism to implement
23791 2001-12-30 Miguel de Icaza <miguel@ximian.com>
23793 * codegen.cs (EmitContext.This): a codegen property that keeps the
23794 a single instance of this instead of creating many different this
23797 * delegate.cs (Delegate.DoResolve): Update to use the property;
23799 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
23801 * expression.cs (BaseAccess.DoResolve): Ditto.
23803 2001-12-29 Ravi Pratap <ravi@ximian.com>
23805 * typemanager.cs (methodimpl_attr_type): Add to hold the type
23806 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
23808 (InitCoreTypes): Update accordingly.
23810 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
23811 so we can quickly store the state.
23813 (ApplyAttributes): Set the correct implementation flags
23814 for InternalCall methods.
23816 2001-12-29 Miguel de Icaza <miguel@ximian.com>
23818 * expression.cs (EmitCall): if a method is not virtual, then do
23819 not use callvirt on it.
23821 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
23822 user defined stuff) requires the use of stobj, which takes an
23823 address on the stack instead of an array and an index. So emit
23824 the Ldelema operation for it.
23826 (EmitStoreOpcode): Use stobj for valuetypes.
23828 (UnaryMutator.EmitCode): Use the right 1 value depending on
23829 whether we are dealing with int64/uint64, float or doubles.
23831 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
23832 constructors that I implemented last night.
23834 (Constructor.IsDefault): Fix to work properly for static
23837 * cs-parser.jay (CheckDef): report method signature errors.
23838 Update error number 103 to be 132.
23840 * decl.cs: New AdditionResult enumeration value: MethodExists.
23841 Although we do this check for methods later on in the semantic
23842 analysis, catching repeated default constructors is so easy that
23843 we catch these here.
23845 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
23848 (ParameterReference.EmitAssign, Emit): handle
23851 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
23852 (ArrayAccess.EmitStoreOpcode): ditto.
23854 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
23856 * expression.cs (MakeByteBlob): Complete all the missing types
23857 (uint, short, ushort, byte, sbyte)
23859 * class.cs: Only init instance field initializers on instance
23862 Rename `constructors' to instance_constructors.
23864 (TypeContainer.AddConstructor): Only add constructors to the list
23865 if it is not static.
23867 Make sure that we handle default_static_constructor independently
23868 everywhere where we handle instance_constructors
23870 2001-12-28 Miguel de Icaza <miguel@ximian.com>
23872 * class.cs: Do not lookup or create a base initializer for a
23873 static constructor.
23875 (ConstructorInitializer.Resolve): use the proper type to lookup
23878 * cs-parser.jay: Report error 1585 (modifiers between type and name).
23880 * enum.cs, interface.cs: Remove CloseType, this is taken care by
23883 * decl.cs: CloseType is now an virtual method, the default
23884 implementation just closes this type.
23886 2001-12-28 Ravi Pratap <ravi@ximian.com>
23888 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
23889 to PreserveSig by default. Also emit HideBySig on such methods.
23891 Basically, set the defaults to standard values.
23893 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
23894 argument, if candidate is better, it can't be worse than the best !
23896 (Invocation): Re-write bits to differentiate between methods being
23897 applicable in their expanded form and their normal form - for params
23900 Get rid of use_standard everywhere as only standard conversions are allowed
23901 in overload resolution.
23903 More spec conformance.
23905 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23907 * driver.cs: Add --timestamp, to see where the compiler spends
23910 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
23911 `this' in static code.
23913 (SimpleName.DoResolve): Implement in terms of a helper function
23914 that allows static-references to be passed upstream to
23917 (Expression.ResolveWithSimpleName): Resolve specially simple
23918 names when called by MemberAccess to implement the special
23921 (Expression.ImplicitReferenceConversion): Handle conversions from
23922 Null to reference types before others, as Null's type is
23925 * expression.cs (Invocation.EmitCall): Handle the special case of
23926 calling methods declared on a reference type from a ValueType
23927 (Base classes System.Object and System.Enum)
23929 (MemberAccess.Resolve): Only perform lookups on Enumerations if
23930 the left hand side is a TypeExpr, not on every enumeration.
23932 (Binary.Resolve): If types are reference types, then do a cast to
23933 object on operators != and == of both arguments.
23935 * typemanager.cs (FindMembers): Extract instance and static
23936 members if requested.
23938 * interface.cs (PopulateProperty): Use void_type instead of null
23939 as the return type for the setter method.
23941 (PopulateIndexer): ditto.
23943 2001-12-27 Ravi Pratap <ravi@ximian.com>
23945 * support.cs (ReflectionParameters): Fix minor bug where we
23946 were examining the wrong parameter for the ParamArray attribute.
23948 Cope with requests for the type of the parameter at position
23949 greater than the params parameter's. We now return the element
23950 type of the params array as that makes more sense.
23952 * expression.cs (Invocation.IsParamsMethodApplicable): Update
23953 accordingly as we no longer have to extract the element type
23956 (Invocation.OverloadResolve): Update.
23958 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23960 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
23961 against IEnumerator, test whether the return value is a descendant
23962 of the IEnumerator interface.
23964 * class.cs (Indexer.Define): Use an auxiliary method to implement
23965 the other bits of the method definition. Begin support for
23966 explicit interface implementation.
23968 (Property.DefineMethod): Use TypeManager.void_type instead of null
23969 for an empty return value.
23971 2001-12-26 Miguel de Icaza <miguel@ximian.com>
23973 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
23974 dealing with a FieldExpr which is composed of a FieldBuilder, in
23975 the code path we did extract the constant, but we should have
23976 obtained the underlying value to be able to cast it (otherwise we
23977 end up in an infinite loop, this is what Ravi was running into).
23979 (ArrayCreation.UpdateIndices): Arrays might be empty.
23981 (MemberAccess.ResolveMemberAccess): Add support for section
23982 14.5.4.1 that deals with the special case of E.I when E is a type
23983 and something else, that I can be a reference to a static member.
23985 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
23986 handle a particular array type to create byte blobs, it is just
23987 something we dont generate byteblobs for.
23989 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
23992 * location.cs (Push): remove the key from the hashtable that we
23993 are about to add. This happens for empty files.
23995 * driver.cs: Dispose files after we have parsed them.
23997 (tokenize): new function that only runs the tokenizer on its
23998 input, for speed testing.
24000 2001-12-26 Ravi Pratap <ravi@ximian.com>
24002 * class.cs (Event.Define): Define the private field only if there
24003 are no accessors defined.
24005 * expression.cs (ResolveMemberAccess): If there is no associated
24006 field with the event, that means we have an event defined with its
24007 own accessors and we should flag error cs0070 since transforming
24008 ourselves into a field is not valid in that case.
24010 * ecore.cs (SimpleName.DoResolve): Same as above.
24012 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
24013 and charset to sane values.
24015 2001-12-25 Ravi Pratap <ravi@ximian.com>
24017 * assign.cs (DoResolve): Perform check on events only if they
24018 are being accessed outside the declaring type.
24020 * cs-parser.jay (event_declarations): Update rules to correctly
24021 set the type of the implicit parameter etc.
24023 (add_accessor, remove_accessor): Set current local parameters.
24025 * expression.cs (Binary): For delegate addition and subtraction,
24026 cast the return value from the method into the appropriate delegate
24029 2001-12-24 Ravi Pratap <ravi@ximian.com>
24031 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
24032 of these as the workaround is unnecessary.
24034 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
24035 delegate data - none of that is needed at all.
24037 Re-write bits to extract the instance expression and the delegate method
24040 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
24043 * attribute.cs (ApplyAttributes): New method to take care of common tasks
24044 of attaching attributes instead of duplicating code everywhere.
24046 * everywhere : Update code to do attribute emission using the above method.
24048 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24050 * expression.cs (IsParamsMethodApplicable): if there are not
24051 parameters, return immediately.
24053 * ecore.cs: The 0 literal can be implicity converted to an enum
24056 (SimpleName.DoResolve): First lookup the type, then lookup the
24059 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
24060 want to get its address. If the InstanceExpression is not
24061 addressable, store the result in a temporary variable, then get
24064 * codegen.cs: Only display 219 errors on warning level or above.
24066 * expression.cs (ArrayAccess): Make it implement the
24067 IMemoryLocation interface.
24069 (Binary.DoResolve): handle the operator == (object a, object b)
24070 and operator != (object a, object b) without incurring into a
24071 BoxedCast (because 5 != o should never be performed).
24073 Handle binary enumerator operators.
24075 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
24076 value type, otherwise use Ldelem_ref.
24078 Use precomputed names;
24080 (AddressOf): Implement address of
24082 * cs-parser.jay (labeled_statement): Fix recursive block
24083 addition by reworking the production.
24085 * expression.cs (New.DoEmit): New has a special case:
24087 If we are dealing with a ValueType, we have a few
24088 situations to deal with:
24090 * The target of New is a ValueType variable, that is
24091 easy, we just pass this as the variable reference
24093 * The target of New is being passed as an argument,
24094 to a boxing operation or a function that takes a
24097 In this case, we need to create a temporary variable
24098 that is the argument of New.
24101 2001-12-23 Ravi Pratap <ravi@ximian.com>
24103 * rootcontext.cs (LookupType): Check that current_type is not null before
24104 going about looking at nested types.
24106 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
24107 not implement the IAssignMethod interface any more.
24109 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
24110 where we tranform them into FieldExprs if they are being resolved from within
24111 the declaring type.
24113 * ecore.cs (SimpleName.DoResolve): Do the same here.
24115 * assign.cs (DoResolve, Emit): Clean up code considerably.
24117 * ../errors/bug10.cs : Add.
24119 * ../errors/cs0070.cs : Add.
24121 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
24123 * assign.cs : Get rid of EventIsLocal everywhere.
24125 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24127 * ecore.cs (ConvertIntLiteral): finished the implementation.
24129 * statement.cs (SwitchLabel): Convert the value we are using as a
24130 key before looking up the table.
24132 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24134 * codegen.cs (EmitTopBlock): Require a Location argument now.
24136 * cs-parser.jay (constructor_declarator): We need to setup
24137 current_local_parameters before we parse the
24138 opt_constructor_initializer, to allow the variables to be bound
24139 to the constructor arguments.
24141 * rootcontext.cs (LookupType): First lookup nested classes in our
24142 class and our parents before we go looking outside our class.
24144 * expression.cs (ConstantFold): Extract/debox the values at the
24147 * rootcontext.cs (EmitCode): Resolve the constants first before we
24148 resolve the types. This is not really needed, but it helps debugging.
24150 * statement.cs: report location.
24152 * cs-parser.jay: pass location to throw statement.
24154 * driver.cs: Small bug fix.
24156 * report.cs: Updated format to be 4-zero filled digits.
24158 2001-12-22 Ravi Pratap <ravi@ximian.com>
24160 * expression.cs (CheckIndices): Fix minor bug where the wrong
24161 variable was being referred to ;-)
24163 (DoEmit): Do not call EmitStaticInitializers when the
24164 underlying type is System.Object.
24166 2001-12-21 Ravi Pratap <ravi@ximian.com>
24168 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
24169 and do the usual workaround for SRE.
24171 * class.cs (MyEventBuilder.EventType): New member to get at the type
24172 of the event, quickly.
24174 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
24176 * assign.cs (Assign.DoResolve): Handle the case when the target
24177 is an EventExpr and perform the necessary checks.
24179 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
24182 (SimpleName.MemberStaticCheck): Include check for EventExpr.
24184 (EventExpr): Set the type in the constructor itself since we
24185 are meant to be born fully resolved.
24187 (EventExpr.Define): Revert code I wrote earlier.
24189 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
24190 instance expression is null. The instance expression is a This in that case
24191 or a null, depending on whether it is a static method or not.
24193 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
24194 refers to more than one method.
24196 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
24197 and accordingly flag errors.
24199 2001-12-21 Miguel de Icaza <miguel@ximian.com>
24201 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
24203 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24205 * location.cs (ToString): Provide useful rutine.
24207 2001-12-21 Miguel de Icaza <miguel@ximian.com>
24209 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
24210 objects, return the actual integral boxed.
24212 * statement.cs (SwitchLabel): define an ILLabel for each
24215 (Switch.CheckSwitch): If the value is a Literal, extract
24216 the underlying literal.
24218 Also in the unused hashtable we had, add the SwitchLabel so we can
24219 quickly look this value up.
24221 * constant.cs: Implement a bunch of new constants. Rewrite
24222 Literal based on this. Made changes everywhere to adapt to this.
24224 * expression.cs (Expression.MakeByteBlob): Optimize routine by
24225 dereferencing array only once, and also copes with enumrations.
24227 bytes are two bytes wide, not one.
24229 (Cast): Perform constant conversions.
24231 * ecore.cs (TryImplicitIntConversion): Return literals instead of
24232 wrappers to the literals here.
24234 * expression.cs (DoNumericPromotions): long literals can converted
24235 to ulong implicity (this is taken care of elsewhere, but I was
24236 missing this spot).
24238 * ecore.cs (Expression.Literalize): Make the return type Literal,
24239 to improve type checking.
24241 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
24243 2001-12-20 Miguel de Icaza <miguel@ximian.com>
24245 * literal.cs: Revert code from ravi that checked the bounds. The
24246 bounds are sane by the definition of the type itself.
24248 * typemanager.cs: Fix implementation of ImplementsInterface. We
24249 need to actually look up in our parent hierarchy for interfaces
24252 * const.cs: Use the underlying type for enumerations
24254 * delegate.cs: Compute the basename for the delegate creation,
24255 that should fix the delegate test case, and restore the correct
24256 Type Lookup semantics in rootcontext
24258 * rootcontext.cs: Revert Ravi's last patch. The correct way of
24259 referencing a nested type with the Reflection API is using the "+"
24262 * cs-parser.jay: Do not require EOF token at the end.
24264 2001-12-20 Ravi Pratap <ravi@ximian.com>
24266 * rootcontext.cs (LookupType): Concatenate type names with
24267 a '.' instead of a '+' The test suite passes again.
24269 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
24270 field of the enumeration.
24272 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
24273 the case when the member is an EventExpr.
24275 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
24276 static has an associated instance expression.
24278 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
24280 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
24282 * class.cs (Event.Define): Register event and perform appropriate checks
24285 We define the Add and Remove methods even if the use provides none because
24286 in that case, we provide default implementations ourselves.
24288 Define a private field of the type of the event. This is done by the CSC compiler
24289 and we should be doing it too ;-)
24291 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
24292 More methods we use in code we generate.
24294 (multicast_delegate_type, delegate_type): Two separate types since the distinction
24297 (InitCoreTypes): Update accordingly for the above.
24299 * class.cs (Event.Emit): Generate code for default accessors that we provide
24301 (EmitDefaultMethod): Do the job in the above.
24303 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
24306 2001-12-20 Miguel de Icaza <miguel@ximian.com>
24308 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
24309 builders even if we were missing one.
24311 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
24312 pass the Basename as our class name instead of the Name. The
24313 basename will be correctly composed for us.
24315 * parameter.cs (Paramters): Now takes a Location argument.
24317 * decl.cs (DeclSpace.LookupType): Removed convenience function and
24318 make all the code call directly LookupType in RootContext and take
24319 this chance to pass the Location information everywhere.
24321 * Everywhere: pass Location information.
24323 2001-12-19 Miguel de Icaza <miguel@ximian.com>
24325 * class.cs (Constructor.Define): Updated way of detecting the
24326 length of the parameters.
24328 (TypeContainer.DefineType): Use basename as the type name for
24331 (TypeContainer.Define): Do not recursively define types here, as
24332 definition is taken care in order by the RootContext.
24334 * tree.cs: Keep track of namespaces in a per-file basis.
24336 * parameter.cs (Parameter.ComputeSignature): Update to use
24339 (Parameters.GetSignature): ditto.
24341 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
24342 instead of a TypeContainer.
24344 (Interface.SemanticAnalysis): Use `this' instead of our parent to
24345 resolve names. Because we need to be resolve in our context, not
24348 * driver.cs: Implement response files.
24350 * class.cs (TypeContainer.DefineType): If we are defined, do not
24351 redefine ourselves.
24353 (Event.Emit): Emit the code for add/remove handlers.
24354 (Event.Define): Save the MethodBuilders for add/remove.
24356 * typemanager.cs: Use pair here too.
24358 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
24359 DictionaryEntry requires the first argument to be non-null.
24361 (enum_declaration): Compute full name for registering the
24364 (delegate_declaration): Instead of using
24365 formal_parameter_list, use opt_formal_parameter_list as the list
24368 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
24369 (EventParsing): New property that controls whether `add' and
24370 `remove' are returned as tokens or identifiers (for events);
24372 2001-12-19 Ravi Pratap <ravi@ximian.com>
24374 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
24375 use MyEventBuilder only and let it wrap the real builder for us.
24377 (MyEventBuilder): Revamp constructor etc.
24379 Implement all operations that we perform on EventBuilder in precisely the same
24382 (FindMembers): Update to use the EventBuilder member.
24384 (Event.Emit): Update accordingly.
24386 2001-12-18 Ravi Pratap <ravi@ximian.com>
24388 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
24389 by calling the appropriate methods.
24391 (GetCustomAttributes): Make stubs as they cannot possibly do anything
24394 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
24396 2001-12-17 Ravi Pratap <ravi@ximian.com>
24398 * delegate.cs (Delegate.Populate): Check that the return type
24399 and various parameters types are indeed accessible.
24401 * class.cs (Constructor.Define): Same here.
24403 (Field.Define): Ditto.
24405 (Event.Define): Ditto.
24407 (Operator.Define): Check that the underlying Method defined itself
24408 correctly - so it's MethodBuilder should not be null.
24410 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
24411 expression happens to be null.
24413 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
24414 members but as of now we don't seem to be able to do anything really useful with it.
24416 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
24417 not the EventBuilder.
24419 2001-12-18 Miguel de Icaza <miguel@ximian.com>
24421 * cs-tokenizer.cs: Add support for defines.
24422 Add support for #if, #elif, #else, #endif
24424 (eval_var): evaluates a variable.
24425 (eval): stubbed for evaluating functions.
24427 * cs-parser.jay: Pass the defines information
24429 * driver.cs: Add --define command line option.
24431 * decl.cs: Move MemberCore here.
24433 Make it the base class for DeclSpace. This allows us to catch and
24434 report 108 and 109 for everything now.
24436 * class.cs (TypeContainer.Define): Extract all the members
24437 before populating and emit the warning 108 (new keyword required
24438 to override) instead of having each member implement this.
24440 (MemberCore.Define): New abstract method, we will be using this in
24441 the warning reporting engine in Populate.
24443 (Operator.Define): Adjust to new MemberCore protocol.
24445 * const.cs (Const): This does not derive from Expression, it is a
24446 temporary object we use to create fields, it is a MemberCore.
24448 * class.cs (Method.Define): Allow the entry point to be in a
24451 * driver.cs: Rewrite the argument handler to clean it up a bit.
24453 * rootcontext.cs: Made it just an auxiliary namespace feature by
24454 making everything static.
24456 * driver.cs: Adapt code to use RootContext type name instead of
24459 * delegate.cs: Remove RootContext argument.
24461 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
24464 * class.cs (Event.Define): The lookup can fail.
24466 * cs-tokenizer.cs: Begin implementation of pre-procesor.
24468 * expression.cs: Resolve the this instance before invoking the code.
24470 2001-12-17 Miguel de Icaza <miguel@ximian.com>
24472 * cs-parser.jay: Add a production in element_access that allows
24473 the thing to become a "type" reference. This way we can parse
24474 things like "(string [])" as a type.
24476 Note that this still does not handle the more complex rules of
24480 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
24482 * ecore.cs: (CopyNewMethods): new utility function used to
24483 assemble the list of methods from running FindMembers.
24485 (MemberLookup): Rework FindMembers so that
24487 2001-12-16 Miguel de Icaza <miguel@ximian.com>
24489 * class.cs (TypeContainer): Remove Delegates who fail to be
24492 * delegate.cs (Populate): Verify that we dont get null return
24493 values. TODO: Check for AsAccessible.
24495 * cs-parser.jay: Use basename to emit error 574 (destructor should
24496 have the same name as container class), not the full name.
24498 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
24499 possible representation.
24501 Also implements integer type suffixes U and L.
24503 2001-12-15 Miguel de Icaza <miguel@ximian.com>
24505 * expression.cs (ArrayCreation.DoResolve): We need to do the
24506 argument resolution *always*.
24508 * decl.cs: Make this hold the namespace. Hold the root context as
24510 (LookupType): Move here.
24512 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
24514 * location.cs (Row, Name): Fixed the code, it was always returning
24515 references to the first file.
24517 * interface.cs: Register properties defined through interfaces.
24519 * driver.cs: Add support for globbing on the command line
24521 * class.cs (Field): Make it derive from MemberCore as well.
24524 2001-12-15 Ravi Pratap <ravi@ximian.com>
24526 * class.cs (Event::Define): Check that the type of the event is a delegate
24527 type else flag error #66.
24529 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
24532 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
24533 values of EntryPoint, CharSet etc etc.
24535 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
24537 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
24538 be null and we should ignore this. I am not sure if this is really clean. Apparently,
24539 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
24540 which needs this to do its work.
24542 * ../errors/cs0066.cs : Add.
24544 2001-12-14 Miguel de Icaza <miguel@ximian.com>
24546 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
24549 * class.cs: (MethodSignature.MethodSignature): Removed hack that
24550 clears out the parameters field.
24551 (MemberSignatureCompare): Cleanup
24553 (MemberCore): New base class used to share code between MethodCore
24556 (RegisterRequiredImplementations) BindingFlags.Public requires
24557 either BindingFlags.Instace or Static. Use instance here.
24559 (Property): Refactored code to cope better with the full spec.
24561 * parameter.cs (GetParameterInfo): Return an empty array instead
24564 * class.cs (Property): Abstract or extern properties have no bodies.
24566 * parameter.cs (GetParameterInfo): return a zero-sized array.
24568 * class.cs (TypeContainer.MethodModifiersValid): Move all the
24569 method modifier validation to the typecontainer so we can reuse
24570 this on properties.
24572 (MethodCore.ParameterTypes): return an empty sized array of types.
24574 (Property.Define): Test property modifier validity.
24576 Add tests for sealed/override too.
24578 (Method.Emit): abstract or extern methods have no bodies.
24580 2001-12-14 Ravi Pratap <ravi@ximian.com>
24582 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
24585 (Method::Define, ::Emit): Modify accordingly.
24587 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
24589 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
24591 * makefile: Pass in /unsafe.
24593 2001-12-13 Miguel de Icaza <miguel@ximian.com>
24595 * class.cs (MakeKey): Kill routine.
24597 * class.cs (TypeContainer.Define): Correctly define explicit
24598 method implementations (they require the full interface name plus
24601 * typemanager.cs: Deply the PtrHashtable here and stop using the
24602 lame keys. Things work so much better.
24604 This of course broke everyone who depended on `RegisterMethod' to
24605 do the `test for existance' test. This has to be done elsewhere.
24607 * support.cs (PtrHashtable): A hashtable that avoid comparing with
24608 the object stupid Equals method (because, that like fails all over
24609 the place). We still do not use it.
24611 * class.cs (TypeContainer.SetRequiredInterface,
24612 TypeContainer.RequireMethods): Killed these two routines and moved
24613 all the functionality to RegisterRequiredImplementations.
24615 (TypeContainer.RegisterRequiredImplementations): This routine now
24616 registers all the implementations required in an array for the
24617 interfaces and abstract methods. We use an array of structures
24618 which can be computed ahead of time to reduce memory usage and we
24619 also assume that lookups are cheap as most classes will not
24620 implement too many interfaces.
24622 We also avoid creating too many MethodSignatures.
24624 (TypeContainer.IsInterfaceMethod): Update and optionally does not
24625 clear the "pending" bit if we find that there are problems with
24628 (TypeContainer.VerifyPendingMethods): Update to report errors of
24629 methods that look like implementations but are not.
24631 (TypeContainer.Define): Add support for explicit interface method
24634 2001-12-12 Miguel de Icaza <miguel@ximian.com>
24636 * typemanager.cs: Keep track of the parameters here instead of
24637 being a feature of the TypeContainer.
24639 * class.cs: Drop the registration of parameters here, as
24640 InterfaceMethods are also interface declarations.
24642 * delegate.cs: Register methods with the TypeManager not only with
24643 the TypeContainer. This code was buggy.
24645 * interface.cs: Full registation here.
24647 2001-12-11 Miguel de Icaza <miguel@ximian.com>
24649 * expression.cs: Remove reducer for binary expressions, it can not
24652 * const.cs: Put here the code that used to go into constant.cs
24654 * constant.cs: Put here the code for constants, this is a new base
24655 class for Literals.
24657 * literal.cs: Make Literal derive from Constant.
24659 2001-12-09 Miguel de Icaza <miguel@ximian.com>
24661 * statement.cs (Return.Emit): Report error 157 if the user
24662 attempts to return from a finally block.
24664 (Return.Emit): Instead of emitting a return, jump to the end of
24667 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
24668 LocalBuilder to store the result of the function. ReturnLabel is
24669 the target where we jump.
24672 2001-12-09 Radek Doulik <rodo@ximian.com>
24674 * cs-parser.jay: remember alias in current namespace
24676 * ecore.cs (SimpleName::DoResolve): use aliases for types or
24679 * class.cs (LookupAlias): lookup alias in my_namespace
24681 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
24683 (LookupAlias): lookup alias in this and if needed in parent
24686 2001-12-08 Miguel de Icaza <miguel@ximian.com>
24690 * rootcontext.cs: (ModuleBuilder) Made static, first step into
24691 making things static. I need this to avoid passing the
24692 TypeContainer when calling ParameterType.
24694 * support.cs (InternalParameters.ParameterType): Remove ugly hack
24695 that did string manipulation to compute the type and then call
24696 GetType. Use Parameter.ParameterType instead.
24698 * cs-tokenizer.cs: Consume the suffix for floating values.
24700 * expression.cs (ParameterReference): figure out whether this is a
24701 reference parameter or not. Kill an extra variable by computing
24702 the arg_idx during emission.
24704 * parameter.cs (Parameters.GetParameterInfo): New overloaded
24705 function that returns whether a parameter is an out/ref value or not.
24707 (Parameter.ParameterType): The type of the parameter (base,
24708 without ref/out applied).
24710 (Parameter.Resolve): Perform resolution here.
24711 (Parameter.ExternalType): The full type (with ref/out applied).
24713 * statement.cs (Using.Emit, Using.EmitExpression): Implement
24714 support for expressions on the using statement.
24716 2001-12-07 Miguel de Icaza <miguel@ximian.com>
24718 * statement.cs (Using.EmitLocalVariableDecls): Split the
24719 localvariable handling of the using statement.
24721 (Block.EmitMeta): Keep track of variable count across blocks. We
24722 were reusing slots on separate branches of blocks.
24724 (Try.Emit): Emit the general code block, we were not emitting it.
24726 Check the type of the declaration to be an IDisposable or
24727 something that can be implicity converted to it.
24729 Emit conversions if required.
24731 * ecore.cs (EmptyExpression): New utility class.
24732 (Expression.ImplicitConversionExists): New utility function.
24734 2001-12-06 Miguel de Icaza <miguel@ximian.com>
24736 * statement.cs (Using): Implement.
24738 * expression.cs (LocalVariableReference): Support read only variables.
24740 * statement.cs: Remove the explicit emit for the Leave opcode.
24741 (VariableInfo): Add a readonly field.
24743 2001-12-05 Miguel de Icaza <miguel@ximian.com>
24745 * ecore.cs (ConvCast): new class used to encapsulate the various
24746 explicit integer conversions that works in both checked and
24747 unchecked contexts.
24749 (Expression.ConvertNumericExplicit): Use new ConvCast class to
24750 properly generate the overflow opcodes.
24752 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24754 * statement.cs: The correct type for the EmptyExpression is the
24755 element_type, not the variable type. Ravi pointed this out.
24757 2001-12-04 Ravi Pratap <ravi@ximian.com>
24759 * class.cs (Method::Define): Handle PInvoke methods specially
24760 by using DefinePInvokeMethod instead of the usual one.
24762 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
24763 above to do the task of extracting information and defining the method.
24765 2001-12-04 Ravi Pratap <ravi@ximian.com>
24767 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
24768 of the condition for string type.
24770 (Emit): Move that here.
24772 (ArrayCreation::CheckIndices): Keep string literals in their expression
24775 (EmitDynamicInitializers): Handle strings appropriately.
24777 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24779 * codegen.cs (EmitContext): Replace multiple variables with a
24780 single pointer to the current Switch statement.
24782 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
24785 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24789 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
24792 (Foreach.Emit): Foreach on arrays was not setting
24793 up the loop variables (for break/continue).
24795 (GotoCase): Semi-implented.
24797 2001-12-03 Ravi Pratap <ravi@ximian.com>
24799 * attribute.cs (CheckAttribute): Handle system attributes by using
24800 Attribute.GetAttributes to examine information we need.
24802 (GetValidPlaces): Same here.
24804 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
24806 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
24808 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
24810 (Method::Define): Set appropriate flags if we have a DllImport attribute.
24812 (Method::Emit): Handle the case when we are a PInvoke method.
24814 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24816 * expression.cs: Use ResolveWithSimpleName on compound names.
24818 2001-12-02 Ravi Pratap <ravi@ximian.com>
24820 * constant.cs (EmitConstant): Make sure we resolve the associated expression
24821 before trying to reduce it.
24823 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
24825 * constant.cs (LookupConstantValue): Implement.
24827 (EmitConstant): Use the above in emitting the constant.
24829 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
24830 that are user-defined by doing a LookupConstantValue on them.
24832 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
24835 2001-11-29 Miguel de Icaza <miguel@ximian.com>
24837 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
24839 (BaseAccess.DoResolve): Implement.
24841 (MemberAccess.DoResolve): Split this routine into a
24842 ResolveMemberAccess routine that can be used independently
24844 2001-11-28 Miguel de Icaza <miguel@ximian.com>
24846 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
24847 As that share bits of the implementation. Is returns a boolean,
24848 while As returns the Type that is being probed.
24850 2001-12-01 Ravi Pratap <ravi@ximian.com>
24852 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
24853 instead of a Literal - much easier.
24855 (EnumInTransit): Remove - utterly useless :-)
24857 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
24859 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
24861 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
24862 chain when we have no associated expression.
24864 2001-11-30 Ravi Pratap <ravi@ximian.com>
24866 * constant.cs (Define): Use Location while reporting the errror.
24868 Also emit a warning when 'new' is used and there is no inherited
24871 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
24874 (LookupEnumValue): Implement to lookup an enum member's value and define it
24877 (Populate): Re-write accordingly to use the above routine.
24879 2001-11-27 Miguel de Icaza <miguel@ximian.com>
24881 * expression.cs (This): Fix prototype for DoResolveLValue to
24882 override the base class DoResolveLValue.
24884 * cs-parser.cs: Report errors cs574 and cs575 (destructor
24887 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
24888 (we need to load the address of the field here). This fixes
24891 (FieldExpr.DoResolveLValue): Call the DoResolve
24892 function to initialize the Instance expression.
24894 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
24895 correctly the GetEnumerator operation on a value type.
24897 * cs-parser.jay: Add more simple parsing error catches.
24899 * statement.cs (Switch): Add support for string switches.
24900 Handle null specially.
24902 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
24904 2001-11-28 Ravi Pratap <ravi@ximian.com>
24906 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
24908 (declare_local_constant): New helper function.
24910 * statement.cs (AddConstant): Keep a separate record of constants
24912 (IsConstant): Implement to determine if a variable is a constant.
24914 (GetConstantExpression): Implement.
24916 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
24918 * statement.cs (IsVariableDefined): Re-write.
24920 2001-11-27 Ravi Pratap <ravi@ximian.com>
24922 * class.cs (TypeContainer::FindMembers): Look for constants
24923 in the case when we are looking for MemberTypes.Field
24925 * expression.cs (MemberAccess::DoResolve): Check that in the
24926 case we are a FieldExpr and a Literal, we are not being accessed
24927 by an instance reference.
24929 * cs-parser.jay (local_constant_declaration): Implement.
24931 (declaration_statement): Implement for constant declarations.
24933 2001-11-26 Miguel de Icaza <miguel@ximian.com>
24935 * statement.cs (Switch): Catch double defaults.
24937 (Switch): More work on the switch() statement
24938 implementation. It works for integral values now, need to finish
24942 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24944 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
24945 integer literals into other integer literals. To be used by
24948 2001-11-24 Ravi Pratap <ravi@ximian.com>
24950 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
24953 (EmitDynamicInitializers): Cope with the above since we extract data
24954 directly from ArrayData now.
24956 (ExpectInitializers): Keep track of whether initializers are mandatory
24959 (Bounds): Make it a hashtable to prevent the same dimension being
24960 recorded for every element in that dimension.
24962 (EmitDynamicInitializers): Fix bug which prevented the Set array method
24965 Also fix bug which was causing the indices to be emitted in the reverse
24968 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24970 * expression.cs (ArrayCreation): Implement the bits that Ravi left
24971 unfinished. They do not work, because the underlying code is
24974 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24976 * cs-parser.jay: Remove bogus fixme.
24978 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
24979 on Switch statement.
24981 2001-11-23 Ravi Pratap <ravi@ximian.com>
24983 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
24986 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
24987 parameter. Apparently, any expression is allowed.
24989 (ValidateInitializers): Update accordingly.
24991 (CheckIndices): Fix some tricky bugs thanks to recursion.
24993 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
24994 I was being completely brain-dead.
24996 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
24997 and re-write acordingly.
24999 (DelegateInvocation): Re-write accordingly.
25001 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
25003 (MakeByteBlob): Handle types more correctly.
25005 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
25006 initialization from expressions but it is incomplete because I am a complete
25009 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25011 * statement.cs (If.Emit): Fix a bug that generated incorrect code
25012 on If. Basically, we have to return `true' (ie, we do return to
25013 our caller) only if both branches of the if return.
25015 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
25016 short-circuit operators, handle them as short circuit operators.
25018 (Cast.DoResolve): Resolve type.
25019 (Cast.Cast): Take an expression as the target type.
25021 * cs-parser.jay (cast_expression): Remove old hack that only
25022 allowed a limited set of types to be handled. Now we take a
25023 unary_expression and we resolve to a type during semantic
25026 Use the grammar productions from Rhys to handle casts (this is
25027 not complete like Rhys syntax yet, we fail to handle that corner
25028 case that C# has regarding (-x), but we will get there.
25030 2001-11-22 Ravi Pratap <ravi@ximian.com>
25032 * class.cs (EmitFieldInitializer): Take care of the case when we have a
25033 field which is an array type.
25035 * cs-parser.jay (declare_local_variables): Support array initialization too.
25037 * typemanager.cs (MakeKey): Implement.
25039 (everywhere): Use the above appropriately.
25041 * cs-parser.jay (for_statement): Update for array initialization while
25042 declaring variables.
25044 * ecore.cs : The error message was correct, it's the variable's names that
25045 were misleading ;-) Make the code more readable.
25047 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
25048 the correct type etc.
25050 (ConvertExplicit): Handle Enum types by examining the underlying type.
25052 2001-11-21 Ravi Pratap <ravi@ximian.com>
25054 * parameter.cs (GetCallingConvention): Always return
25055 CallingConventions.Standard for now.
25057 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25059 * expression.cs (Binary.ResolveOperator): Update the values of `l'
25060 and `r' after calling DoNumericPromotions.
25062 * ecore.cs: Fix error message (the types were in the wrong order).
25064 * statement.cs (Foreach.ProbeCollectionType): Need to pass
25065 BindingFlags.Instance as well
25067 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
25068 implicit int literal conversion in an empty cast so that we
25069 propagate the right type upstream.
25071 (UnboxCast): new class used to unbox value types.
25072 (Expression.ConvertExplicit): Add explicit type conversions done
25075 (Expression.ImplicitNumericConversion): Oops, forgot to test for
25076 the target type before applying the implicit LongLiterals to ULong
25079 2001-11-21 Miguel de Icaza <miguel@ximian.com>
25081 * cs-parser.jay (for_statement): Reworked the way For works: now
25082 we declare manually any variables that are introduced in
25083 for_initializer to solve the problem of having out-of-band code
25084 emition (that is what got for broken).
25086 (declaration_statement): Perform the actual variable declaration
25087 that used to be done in local_variable_declaration here.
25089 (local_variable_declaration): Do not declare anything, just pass
25090 the information on a DictionaryEntry
25092 2001-11-20 Ravi Pratap <ravi@ximian.com>
25094 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
25095 re-write of the logic to now make it recursive.
25097 (UpdateIndices): Re-write accordingly.
25099 Store element data in a separate ArrayData list in the above methods.
25101 (MakeByteBlob): Implement to dump the array data into a byte array.
25103 2001-11-19 Ravi Pratap <ravi@ximian.com>
25105 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
25108 * constant.cs (Define): Implement.
25110 (EmitConstant): Re-write fully.
25112 Pass in location info.
25114 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
25117 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
25118 DictionaryEntry since we need location info too.
25120 (constant_declaration): Update accordingly.
25122 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
25123 code into another method : UpdateIndices.
25125 2001-11-18 Ravi Pratap <ravi@ximian.com>
25127 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
25128 some type checking etc.
25130 2001-11-17 Ravi Pratap <ravi@ximian.com>
25132 * expression.cs (ArrayCreation::ValidateInitializers): Implement
25133 bits to provide dimension info if the user skips doing that.
25135 Update second constructor to store the rank correctly.
25137 2001-11-16 Ravi Pratap <ravi@ximian.com>
25139 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
25140 and try to implement.
25142 * ../errors/cs0150.cs : Add.
25144 * ../errors/cs0178.cs : Add.
25146 2001-11-16 Miguel de Icaza <miguel@ximian.com>
25148 * statement.cs: Implement foreach on multi-dimensional arrays.
25150 * parameter.cs (Parameters.GetParameterByName): Also lookup the
25151 name of the params argument.
25153 * expression.cs: Use EmitStoreOpcode to get the right opcode while
25154 initializing the array.
25156 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
25157 we can use this elsewhere.
25159 * statement.cs: Finish implementation of foreach for single
25162 * cs-parser.jay: Use an out-of-band stack to pass information
25163 around, I wonder why I need this.
25165 foreach_block: Make the new foreach_block the current_block.
25167 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
25168 function used to return a static Parameters structure. Used for
25169 empty parameters, as those are created very frequently.
25171 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
25173 2001-11-15 Ravi Pratap <ravi@ximian.com>
25175 * interface.cs : Default modifier is private, not public. The
25176 make verify test passes again.
25178 2001-11-15 Ravi Pratap <ravi@ximian.com>
25180 * support.cs (ReflectionParameters): Fix logic to determine
25181 whether the last parameter is a params one. Test 9 passes again.
25183 * delegate.cs (Populate): Register the builders we define with
25184 RegisterParameterForBuilder. Test 19 passes again.
25186 * cs-parser.jay (property_declaration): Reference $6 instead
25187 of $$ to get at the location.
25189 (indexer_declaration): Similar stuff.
25191 (attribute): Ditto.
25193 * class.cs (Property): Register parameters for the Get and Set methods
25194 if they exist. Test 23 passes again.
25196 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
25197 call to EmitArguments as we are sure there aren't any params arguments.
25198 Test 32 passes again.
25200 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
25201 IndexOutOfRangeException.
25203 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
25204 Test 33 now passes again.
25206 2001-11-15 Miguel de Icaza <miguel@ximian.com>
25208 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
25209 broke a bunch of things. Will have to come up with a better way
25210 of tracking locations.
25212 * statement.cs: Implemented foreach for single dimension arrays.
25214 2001-11-09 Miguel de Icaza <miguel@ximian.com>
25216 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
25217 an error. This removes the lookup from the critical path.
25219 * cs-parser.jay: Removed use of temporary_loc, which is completely
25222 2001-11-14 Miguel de Icaza <miguel@ximian.com>
25224 * support.cs (ReflectionParameters.ParameterModifier): Report
25225 whether the argument is a PARAMS argument or not.
25227 * class.cs: Set the attribute `ParamArrayAttribute' on the
25228 parameter argument.
25230 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
25231 and cons_param_array_attribute (ConstructorInfo for
25232 ParamArrayAttribute).,
25234 * codegen.cs: Emit the return using the `Return' statement, that
25235 way we can report the error correctly for missing return values.
25237 * class.cs (Method.Emit): Clean up.
25239 * expression.cs (Argument.Resolve): Take another argument: the
25240 location where this argument is used. Notice that this is not
25241 part of the "Argument" class as to reduce the size of the
25242 structure (we know the approximate location anyways).
25244 Test if the argument is a variable-reference, if not, then
25245 complain with a 206.
25247 (Argument.Emit): Emit addresses of variables.
25249 (Argument.FullDesc): Simplify.
25251 (Invocation.DoResolve): Update for Argument.Resolve.
25253 (ElementAccess.DoResolve): ditto.
25255 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
25256 method should be virtual, as this method is always virtual.
25258 (NewDelegate.DoResolve): Update for Argument.Resolve.
25260 * class.cs (ConstructorInitializer.DoResolve): ditto.
25262 * attribute.cs (Attribute.Resolve): ditto.
25264 2001-11-13 Miguel de Icaza <miguel@ximian.com>
25266 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
25268 * expression.cs (ParameterReference): Drop IStackStorage and implement
25269 IAssignMethod instead.
25271 (LocalVariableReference): ditto.
25273 * ecore.cs (FieldExpr): Drop IStackStorage and implement
25274 IAssignMethod instead.
25276 2001-11-13 Miguel de Icaza <miguel@ximian.com>
25278 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
25279 enumerations that are used in heavily used structures derive from
25280 byte in a laughable and pathetic attempt to reduce memory usage.
25281 This is the kind of pre-optimzations that you should not do at
25282 home without adult supervision.
25284 * expression.cs (UnaryMutator): New class, used to handle ++ and
25285 -- separatedly from the other unary operators. Cleans up the
25286 code, and kills the ExpressionStatement dependency in Unary.
25288 (Unary): Removed `method' and `Arguments' from this class, making
25289 it smaller, and moving it all to SimpleCall, so I can reuse this
25290 code in other locations and avoid creating a lot of transient data
25291 strucutres when not required.
25293 * cs-parser.jay: Adjust for new changes.
25295 2001-11-11 Miguel de Icaza <miguel@ximian.com>
25297 * enum.cs (Enum.Populate): If there is a failure during
25300 * cs-parser.jay (opt_enum_base): we used to catch type errors
25301 here, but this is really incorrect. The type error should be
25302 catched during semantic analysis.
25304 2001-12-11 Ravi Pratap <ravi@ximian.com>
25306 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
25307 current_local_parameters as expected since I, in my stupidity, had forgotten
25310 * attribute.cs (GetValidPlaces): Fix stupid bug.
25312 * class.cs (Method::Emit): Perform check on applicability of attributes.
25314 (Constructor::Emit): Ditto.
25316 (Field::Emit): Ditto.
25318 (Field.Location): Store location information.
25320 (Property, Event, Indexer, Operator): Ditto.
25322 * cs-parser.jay (field_declaration): Pass in location for each field.
25324 * ../errors/cs0592.cs : Add.
25326 2001-11-12 Ravi Pratap <ravi@ximian.com>
25328 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
25330 (InitCoreTypes): Update accordingly.
25332 (RegisterAttrType, LookupAttr): Implement.
25334 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
25335 info about the same.
25337 (Resolve): Update to populate the above as necessary.
25339 (Error592): Helper.
25341 (GetValidPlaces): Helper to the above.
25343 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
25345 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
25347 2001-11-12 Ravi Pratap <ravi@ximian.com>
25349 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
25351 * ../errors/cs0617.cs : Add.
25353 2001-11-11 Ravi Pratap <ravi@ximian.com>
25355 * enum.cs (Emit): Rename to Populate to be more consistent with what
25356 we expect it to do and when exactly it is called.
25358 * class.cs, rootcontext.cs : Update accordingly.
25360 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
25361 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
25363 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
25365 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
25366 of a fieldinfo using the above, when dealing with a FieldBuilder.
25368 2001-11-10 Ravi Pratap <ravi@ximian.com>
25370 * ../errors/cs0031.cs : Add.
25372 * ../errors/cs1008.cs : Add.
25374 * ../errrors/cs0543.cs : Add.
25376 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
25379 (FindMembers): Implement.
25381 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
25382 enums and delegates too.
25384 (enum_types): Rename to builder_to_enum.
25386 (delegate_types): Rename to builder_to_delegate.
25388 * delegate.cs (FindMembers): Implement.
25390 2001-11-09 Ravi Pratap <ravi@ximian.com>
25392 * typemanager.cs (IsEnumType): Implement.
25394 * enum.cs (Emit): Re-write parts to account for the underlying type
25395 better and perform checking etc.
25397 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
25398 of the underlying type.
25400 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
25403 * enum.cs (error31): Helper to report error #31.
25405 * cs-parser.jay (enum_declaration): Store location of each member too.
25407 * enum.cs (member_to_location): New hashtable.
25409 (AddEnumMember): Update location hashtable.
25411 (Emit): Use the location of each member while reporting errors.
25413 2001-11-09 Miguel de Icaza <miguel@ximian.com>
25415 * cs-parser.jay: A for_initializer if is a
25416 local_variable_declaration really ammount to have an implicit
25417 block with the variable declaration and no initializer for for.
25419 * statement.cs (For.Emit): Cope with null initializers.
25421 This fixes the infinite loop on for initializers.
25423 2001-11-08 Miguel de Icaza <miguel@ximian.com>
25425 * enum.cs: More cleanup.
25427 * ecore.cs: Remove dead code.
25429 * class.cs (Property.Emit): More simplification.
25430 (Event.Emit): ditto.
25432 Reworked to have less levels of indentation.
25434 2001-11-08 Ravi Pratap <ravi@ximian.com>
25436 * class.cs (Property): Emit attributes.
25446 * enum.cs (Emit): Ditto.
25448 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
25451 * class.cs (Field, Event, etc.): Move attribute generation into the
25452 Emit method everywhere.
25454 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
25455 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
25456 as we had no way of defining nested enums !
25458 * rootcontext.cs : Adjust code accordingly.
25460 * typemanager.cs (AddEnumType): To keep track of enum types separately.
25462 2001-11-07 Ravi Pratap <ravi@ximian.com>
25464 * expression.cs (EvalConstantExpression): Move into ecore.cs
25466 * enum.cs (Enum): Rename some members and make them public and readonly
25467 according to our convention.
25469 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
25472 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
25474 (Enum::Emit): Write a simple version for now which doesn't try to compute
25475 expressions. I shall modify this to be more robust in just a while.
25477 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
25479 (TypeContainer::CloseType): Create the Enum types too.
25481 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
25483 * expression.cs (EvalConstantExpression): Get rid of completely.
25485 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
25486 user-defined values and other cases.
25488 (IsValidEnumLiteral): Helper function.
25490 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
25491 out there in the case we had a literal FieldExpr.
25493 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
25495 (Literalize): Revamp a bit to take two arguments.
25497 (EnumLiteral): New class which derives from Literal to wrap enum literals.
25499 2001-11-06 Ravi Pratap <ravi@ximian.com>
25501 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
25503 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
25505 (Resolve): Use the above to ensure we have proper initializers.
25507 2001-11-05 Ravi Pratap <ravi@ximian.com>
25509 * expression.cs (Expression::EvalConstantExpression): New method to
25510 evaluate constant expressions.
25512 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
25514 2001-11-07 Miguel de Icaza <miguel@ximian.com>
25516 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
25519 (Binary.ResolveOperator): Handle operator != (object a, object b)
25520 and operator == (object a, object b);
25522 (Binary.DoNumericPromotions): Indicate whether the numeric
25523 promotion was possible.
25525 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
25528 Made the ArrayAccess implement interface IAssignMethod instead of
25529 IStackStore as the order in which arguments are passed reflects
25532 * assign.cs: Instead of using expr.ExprClass to select the way of
25533 assinging, probe for the IStackStore/IAssignMethod interfaces.
25535 * typemanager.cs: Load InitializeArray definition.
25537 * rootcontext.cs (RootContext.MakeStaticData): Used to define
25538 static data that can be used to initialize arrays.
25540 2001-11-05 Miguel de Icaza <miguel@ximian.com>
25542 * expression.cs: Handle operator== and operator!= for booleans.
25544 (Conditioal.Reduce): Implement reducer for the ?: operator.
25546 (Conditional.Resolve): Implement dead code elimination.
25548 (Binary.Resolve): Catch string literals and return a new
25549 concatenated string.
25551 (Unary.Reduce): Implement reduction of unary expressions.
25553 * ecore.cs: Split out the expression core handling here.
25555 (Expression.Reduce): New method used to perform constant folding
25556 and CSE. This is needed to support constant-expressions.
25558 * statement.cs (Statement.EmitBoolExpression): Pass true and false
25559 targets, and optimize for !x.
25561 2001-11-04 Ravi Pratap <ravi@ximian.com>
25563 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
25564 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
25565 set custom atttributes.
25567 * literal.cs (Literal::GetValue): New abstract method to return the actual
25568 value of the literal, cast as an object.
25570 (*Literal): Implement GetValue method.
25572 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
25573 expressions to the arraylist but objects of type Argument.
25575 * class.cs (TypeContainer::Emit): Emit our attributes too.
25577 (Method::Emit, Constructor::Emit): Ditto.
25579 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
25580 to be ignoring earlier.
25582 2001-11-03 Ravi Pratap <ravi@ximian.com>
25584 * attribute.cs (AttributeSection::Define): Implement to do the business
25585 of constructing a CustomAttributeBuilder.
25587 (Attribute): New trivial class. Increases readability of code.
25589 * cs-parser.jay : Update accordingly.
25591 (positional_argument_list, named_argument_list, named_argument): New rules
25593 (attribute_arguments): Use the above so that we are more correct.
25595 2001-11-02 Ravi Pratap <ravi@ximian.com>
25597 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
25598 to perform all checks for a method with a params parameter.
25600 (Invocation::OverloadResolve): Update to use the above method and therefore
25601 cope correctly with params method invocations.
25603 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
25606 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
25607 constructors in our parent too because we can't afford to miss out on
25610 * attribute.cs (AttributeSection): New name for the class Attribute
25612 Other trivial changes to improve readability.
25614 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
25615 use the new class names.
25617 2001-11-01 Ravi Pratap <ravi@ximian.com>
25619 * class.cs (Method::Define): Complete definition for params types too
25621 (Indexer::Define): Ditto.
25623 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
25624 Cope everywhere with a request for info about the array parameter.
25626 2001-11-01 Ravi Pratap <ravi@ximian.com>
25628 * tree.cs (RecordNamespace): Fix up to check for the correct key.
25630 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
25631 local_variable_type to extract the string corresponding to the type.
25633 (local_variable_type): Fixup the action to use the new helper method.
25635 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
25638 * expression.cs : Clean out code which uses the above.
25640 2001-10-31 Ravi Pratap <ravi@ximian.com>
25642 * typemanager.cs (RegisterMethod): Check if we already have an existing key
25643 and bale out if necessary by returning a false.
25645 (RegisterProperty): Ditto.
25647 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
25648 and print out appropriate error messages.
25650 * interface.cs (everywhere): Ditto.
25652 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
25653 location to constructor.
25655 * class.cs (Property, Event, Indexer): Update accordingly.
25657 * ../errors/cs111.cs : Added.
25659 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
25660 of a method, as laid down by the spec.
25662 (Invocation::OverloadResolve): Use the above method.
25664 2001-10-31 Ravi Pratap <ravi@ximian.com>
25666 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
25667 now take a TypeContainer and a Parameters object.
25669 (ParameterData): Modify return type of ParameterModifier method to be
25670 Parameter.Modifier and not a string.
25672 (ReflectionParameters, InternalParameters): Update accordingly.
25674 * expression.cs (Argument::GetParameterModifier): Same here.
25676 * support.cs (InternalParameters::ParameterType): Find a better way of determining
25677 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
25678 symbol in it at all so maybe this is only for now.
25680 2001-10-30 Ravi Pratap <ravi@ximian.com>
25682 * support.cs (InternalParameters): Constructor now takes an extra argument
25683 which is the actual Parameters class.
25685 (ParameterDesc): Update to provide info on ref/out modifiers.
25687 * class.cs (everywhere): Update call to InternalParameters to pass in
25688 the second argument too.
25690 * support.cs (ParameterData): Add ParameterModifier, which is a method
25691 to return the modifier info [ref/out etc]
25693 (InternalParameters, ReflectionParameters): Implement the above.
25695 * expression.cs (Argument::ParameterModifier): Similar function to return
25696 info about the argument's modifiers.
25698 (Invocation::OverloadResolve): Update to take into account matching modifiers
25701 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
25702 a new SetFormalParameters object which we pass to InternalParameters.
25704 2001-10-30 Ravi Pratap <ravi@ximian.com>
25706 * expression.cs (NewArray): Merge into the ArrayCreation class.
25708 2001-10-29 Ravi Pratap <ravi@ximian.com>
25710 * expression.cs (NewArray): Merge classes NewBuiltinArray and
25711 NewUserdefinedArray into one as there wasn't much of a use in having
25714 * expression.cs (Argument): Change field's name to ArgType from Type.
25716 (Type): New readonly property which returns the proper type, taking into
25717 account ref/out modifiers.
25719 (everywhere): Adjust code accordingly for the above.
25721 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
25722 whether we are emitting for a ref or out parameter.
25724 * expression.cs (Argument::Emit): Use the above field to set the state.
25726 (LocalVariableReference::Emit): Update to honour the flag and emit the
25729 * parameter.cs (Attributes): Set the correct flags for ref parameters.
25731 * expression.cs (Argument::FullDesc): New function to provide a full desc.
25733 * support.cs (ParameterData): Add method ParameterDesc to the interface.
25735 (ReflectionParameters, InternalParameters): Implement the above method.
25737 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
25740 (Invocation::FullMethodDesc): Ditto.
25742 2001-10-29 Miguel de Icaza <miguel@ximian.com>
25744 * cs-parser.jay: Add extra production for the second form of array
25747 * expression.cs (ArrayCreation): Update to reflect the above
25750 * Small changes to prepare for Array initialization.
25752 2001-10-28 Miguel de Icaza <miguel@ximian.com>
25754 * typemanager.cs (ImplementsInterface): interface might be null;
25755 Deal with this problem;
25757 Also, we do store negative hits on the cache (null values), so use
25758 this instead of calling t.GetInterfaces on the type everytime.
25760 2001-10-28 Ravi Pratap <ravi@ximian.com>
25762 * typemanager.cs (IsBuiltinType): New method to help determine the same.
25764 * expression.cs (New::DoResolve): Get rid of array creation code and instead
25765 split functionality out into different classes.
25767 (New::FormArrayType): Move into NewBuiltinArray.
25769 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
25772 (NewBuiltinArray): New class to handle creation of built-in arrays.
25774 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
25775 account creation of one-dimensional arrays.
25777 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
25779 (NewUserdefinedArray::DoResolve): Implement.
25781 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
25783 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
25784 we maintain inside the TypeManager. This is necessary to perform lookups on the
25787 (LookupType): Update to perform GetType on the module builders too.
25789 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
25791 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
25793 2001-10-23 Ravi Pratap <ravi@ximian.com>
25795 * expression.cs (New::DoResolve): Implement guts of array creation.
25797 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
25799 2001-10-27 Miguel de Icaza <miguel@ximian.com>
25801 * expression.cs: Fix bug I introduced lsat night that broke
25804 (Expression.Resolve): Report a 246 error (can not resolve name)
25805 if we find a SimpleName in the stream.
25807 (Expression.ResolveLValue): Ditto.
25809 (Expression.ResolveWithSimpleName): This function is a variant of
25810 ResolveName, this one allows SimpleNames to be returned without a
25811 warning. The only consumer of SimpleNames is MemberAccess
25813 2001-10-26 Miguel de Icaza <miguel@ximian.com>
25815 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
25816 might arrive here. I have my doubts that this is correct.
25818 * statement.cs (Lock): Implement lock statement.
25820 * cs-parser.jay: Small fixes to support `lock' and `using'
25822 * cs-tokenizer.cs: Remove extra space
25824 * driver.cs: New flag --checked, allows to turn on integer math
25827 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
25828 Threading.Monitor.Exit
25830 2001-10-23 Miguel de Icaza <miguel@ximian.com>
25832 * expression.cs (IndexerAccess::DoResolveLValue): Set the
25833 Expression Class to be IndexerAccess.
25835 Notice that Indexer::DoResolve sets the eclass to Value.
25837 2001-10-22 Miguel de Icaza <miguel@ximian.com>
25839 * class.cs (TypeContainer::Emit): Emit code for indexers.
25841 * assign.cs (IAssignMethod): New interface implemented by Indexers
25842 and Properties for handling assignment.
25844 (Assign::Emit): Simplify and reuse code.
25846 * expression.cs (IndexerAccess, PropertyExpr): Implement
25847 IAssignMethod, clean up old code.
25849 2001-10-22 Ravi Pratap <ravi@ximian.com>
25851 * typemanager.cs (ImplementsInterface): New method to determine if a type
25852 implements a given interface. Provides a nice cache too.
25854 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
25857 (ConvertReferenceExplicit): Ditto.
25859 * delegate.cs (Delegate::Populate): Update to define the parameters on the
25860 various methods, with correct names etc.
25862 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
25863 Operator.UnaryNegation.
25865 * cs-parser.jay (operator_declarator): Be a little clever in the case where
25866 we have a unary plus or minus operator.
25868 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
25871 * everywhere : update accordingly.
25873 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
25876 * class.cs (Method::Define): For the case where we are implementing a method
25877 inherited from an interface, we need to set the MethodAttributes.Final flag too.
25878 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
25880 2001-10-21 Ravi Pratap <ravi@ximian.com>
25882 * interface.cs (FindMembers): Implement to work around S.R.E
25885 * typemanager.cs (IsInterfaceType): Implement.
25887 (FindMembers): Update to handle interface types too.
25889 * expression.cs (ImplicitReferenceConversion): Re-write bits which
25890 use IsAssignableFrom as that is not correct - it doesn't work.
25892 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
25893 and accordingly override EmitStatement.
25895 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
25896 using the correct logic :-)
25898 2001-10-19 Ravi Pratap <ravi@ximian.com>
25900 * ../errors/cs-11.cs : Add to demonstrate error -11
25902 2001-10-17 Miguel de Icaza <miguel@ximian.com>
25904 * assign.cs (Assign::Resolve): Resolve right hand side first, and
25905 then pass this as a hint to ResolveLValue.
25907 * expression.cs (FieldExpr): Add Location information
25909 (FieldExpr::LValueResolve): Report assignment to readonly
25912 (Expression::ExprClassFromMemberInfo): Pass location information.
25914 (Expression::ResolveLValue): Add new method that resolves an
25917 (Expression::DoResolveLValue): Default invocation calls
25920 (Indexers): New class used to keep track of indexers in a given
25923 (IStackStore): Renamed from LValue, as it did not really describe
25924 what this did. Also ResolveLValue is gone from this interface and
25925 now is part of Expression.
25927 (ElementAccess): Depending on the element access type
25929 * typemanager.cs: Add `indexer_name_type' as a Core type
25930 (System.Runtime.CompilerServices.IndexerNameAttribute)
25932 * statement.cs (Goto): Take a location.
25934 2001-10-18 Ravi Pratap <ravi@ximian.com>
25936 * delegate.cs (Delegate::VerifyDelegate): New method to verify
25937 if two delegates are compatible.
25939 (NewDelegate::DoResolve): Update to take care of the case when
25940 we instantiate a delegate from another delegate.
25942 * typemanager.cs (FindMembers): Don't even try to look up members
25943 of Delegate types for now.
25945 2001-10-18 Ravi Pratap <ravi@ximian.com>
25947 * delegate.cs (NewDelegate): New class to take care of delegate
25950 * expression.cs (New): Split the delegate related code out into
25951 the NewDelegate class.
25953 * delegate.cs (DelegateInvocation): New class to handle delegate
25956 * expression.cs (Invocation): Split out delegate related code into
25957 the DelegateInvocation class.
25959 2001-10-17 Ravi Pratap <ravi@ximian.com>
25961 * expression.cs (New::DoResolve): Implement delegate creation fully
25962 and according to the spec.
25964 (New::DoEmit): Update to handle delegates differently.
25966 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
25967 because of which we were printing out arguments in reverse order !
25969 * delegate.cs (VerifyMethod): Implement to check if the given method
25970 matches the delegate.
25972 (FullDelegateDesc): Implement.
25974 (VerifyApplicability): Implement.
25976 * expression.cs (Invocation::DoResolve): Update to accordingly handle
25977 delegate invocations too.
25979 (Invocation::Emit): Ditto.
25981 * ../errors/cs1593.cs : Added.
25983 * ../errors/cs1594.cs : Added.
25985 * delegate.cs (InstanceExpression, TargetMethod): New properties.
25987 2001-10-16 Ravi Pratap <ravi@ximian.com>
25989 * typemanager.cs (intptr_type): Core type for System.IntPtr
25991 (InitCoreTypes): Update for the same.
25993 (iasyncresult_type, asynccallback_type): Ditto.
25995 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
25998 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
26001 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
26002 the builders for the 4 members of a delegate type :-)
26004 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
26007 * expression.cs (New::DoResolve): Implement guts for delegate creation.
26009 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
26011 2001-10-15 Miguel de Icaza <miguel@ximian.com>
26013 * statement.cs (Break::Emit): Implement.
26014 (Continue::Emit): Implement.
26016 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
26017 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
26018 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
26019 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
26022 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
26023 properties that track the label for the current loop (begin of the
26024 loop and end of the loop).
26026 2001-10-15 Ravi Pratap <ravi@ximian.com>
26028 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
26029 use of emitting anything at all.
26031 * class.cs, rootcontext.cs : Get rid of calls to the same.
26033 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
26035 (Populate): Define the constructor correctly and set the implementation
26038 * typemanager.cs (delegate_types): New hashtable to hold delegates that
26041 (AddDelegateType): Implement.
26043 (IsDelegateType): Implement helper method.
26045 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
26047 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
26048 and accordingly handle it.
26050 * delegate.cs (Populate): Take TypeContainer argument.
26051 Implement bits to define the Invoke method. However, I still haven't figured out
26052 how to take care of the native int bit :-(
26054 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
26055 Qualify the name of the delegate, not its return type !
26057 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
26060 (StandardConversionExists): Checking for array types turns out to be recursive.
26062 (ConvertReferenceExplicit): Implement array conversion.
26064 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
26066 2001-10-12 Ravi Pratap <ravi@ximian.com>
26068 * cs-parser.jay (delegate_declaration): Store the fully qualified
26069 name as it is a type declaration.
26071 * delegate.cs (ReturnType, Name): Rename members to these. Make them
26074 (DefineDelegate): Renamed from Define. Does the same thing essentially,
26075 as TypeContainer::DefineType.
26077 (Populate): Method in which all the definition of the various methods (Invoke)
26080 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
26083 (CloseDelegate): Finally creates the delegate.
26085 * class.cs (TypeContainer::DefineType): Update to define delegates.
26086 (Populate, Emit and CloseType): Do the same thing here too.
26088 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
26089 delegates in all these operations.
26091 2001-10-14 Miguel de Icaza <miguel@ximian.com>
26093 * expression.cs: LocalTemporary: a new expression used to
26094 reference a temporary that has been created.
26096 * assign.cs: Handle PropertyAccess back here, so that we can
26097 provide the proper semantic access to properties.
26099 * expression.cs (Expression::ConvertReferenceExplicit): Implement
26100 a few more explicit conversions.
26102 * modifiers.cs: `NEW' modifier maps to HideBySig.
26104 * expression.cs (PropertyExpr): Make this into an
26105 ExpressionStatement, and support the EmitStatement code path.
26107 Perform get/set error checking, clean up the interface.
26109 * assign.cs: recognize PropertyExprs as targets, and if so, turn
26110 them into toplevel access objects.
26112 2001-10-12 Miguel de Icaza <miguel@ximian.com>
26114 * expression.cs: PropertyExpr::PropertyExpr: use work around the
26117 * typemanager.cs: Keep track here of our PropertyBuilders again to
26118 work around lameness in SRE.
26120 2001-10-11 Miguel de Icaza <miguel@ximian.com>
26122 * expression.cs (LValue::LValueResolve): New method in the
26123 interface, used to perform a second resolution pass for LValues.
26125 (This::DoResolve): Catch the use of this in static methods.
26127 (This::LValueResolve): Implement.
26129 (This::Store): Remove warning, assigning to `this' in structures
26132 (Invocation::Emit): Deal with invocation of
26133 methods on value types. We need to pass the address to structure
26134 methods rather than the object itself. (The equivalent code to
26135 emit "this" for structures leaves the entire structure on the
26136 stack instead of a pointer to it).
26138 (ParameterReference::DoResolve): Compute the real index for the
26139 argument based on whether the method takes or not a `this' pointer
26140 (ie, the method is static).
26142 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
26143 value types returned from functions when we need to invoke a
26144 method on the sturcture.
26147 2001-10-11 Ravi Pratap <ravi@ximian.com>
26149 * class.cs (TypeContainer::DefineType): Method to actually do the business of
26150 defining the type in the Modulebuilder or Typebuilder. This is to take
26151 care of nested types which need to be defined on the TypeBuilder using
26152 DefineNestedMethod.
26154 (TypeContainer::GetClassBases): Implement. Essentially the code from the
26155 methods in RootContext, only ported to be part of TypeContainer.
26157 (TypeContainer::GetInterfaceOrClass): Ditto.
26159 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
26161 * interface.cs (Interface::DefineInterface): New method. Does exactly
26162 what RootContext.CreateInterface did earlier, only it takes care of nested types
26165 (Interface::GetInterfaces): Move from RootContext here and port.
26167 (Interface::GetInterfaceByName): Same here.
26169 * rootcontext.cs (ResolveTree): Re-write.
26171 (PopulateTypes): Re-write.
26173 * class.cs (TypeContainer::Populate): Populate nested types too.
26174 (TypeContainer::Emit): Emit nested members too.
26176 * typemanager.cs (AddUserType): Do not make use of the FullName property,
26177 instead just use the name argument passed in as it is already fully
26180 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
26181 to TypeContainer mapping to see if a type is user-defined.
26183 * class.cs (TypeContainer::CloseType): Implement.
26185 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
26186 the default constructor.
26188 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
26191 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
26193 * interface.cs (CloseType): Create the type here.
26195 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
26198 Remove all the methods which are now in TypeContainer.
26200 2001-10-10 Ravi Pratap <ravi@ximian.com>
26202 * delegate.cs (Define): Re-write bits to define the delegate
26205 2001-10-10 Miguel de Icaza <miguel@ximian.com>
26207 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
26209 * expression.cs (ImplicitReferenceConversion): handle null as well
26210 as a source to convert to any reference type.
26212 * statement.cs (Return): Perform any implicit conversions to
26213 expected return type.
26215 Validate use of return statement.
26217 * codegen.cs (EmitContext): Pass the expected return type here.
26219 * class.cs (Method, Constructor, Property): Pass expected return
26220 type to EmitContext.
26222 2001-10-09 Miguel de Icaza <miguel@ximian.com>
26224 * expression.cs: Make DoResolve take an EmitContext instead of a
26227 Replaced `l' and `location' for `loc', for consistency.
26229 (Error, Warning): Remove unneeded Tc argument.
26231 * assign.cs, literal.cs, constant.cs: Update to new calling
26234 * codegen.cs: EmitContext now contains a flag indicating whether
26235 code is being generated in a static method or not.
26237 * cs-parser.jay: DecomposeQI, new function that replaces the old
26238 QualifiedIdentifier. Now we always decompose the assembled
26239 strings from qualified_identifier productions into a group of
26242 2001-10-08 Miguel de Icaza <miguel@ximian.com>
26244 * rootcontext.cs: Deal with field-less struct types correctly now
26245 by passing the size option to Define Type.
26247 * class.cs: Removed hack that created one static field.
26249 2001-10-07 Miguel de Icaza <miguel@ximian.com>
26251 * statement.cs: Moved most of the code generation here.
26253 2001-10-09 Ravi Pratap <ravi@ximian.com>
26255 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
26258 (ElementAccess): Remove useless bits for now - keep checks as the spec
26261 2001-10-08 Ravi Pratap <ravi@ximian.com>
26263 * expression.cs (ElementAccess::DoResolve): Remove my crap code
26264 and start performing checks according to the spec.
26266 2001-10-07 Ravi Pratap <ravi@ximian.com>
26268 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
26269 rank_specifiers instead.
26271 (rank_specifiers): Change the order in which the rank specifiers are stored
26273 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
26275 * expression.cs (ElementAccess): Implement the LValue interface too.
26277 2001-10-06 Ravi Pratap <ravi@ximian.com>
26279 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
26280 except that user defined conversions are not included.
26282 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
26283 perform the conversion of the return type, if necessary.
26285 (New::DoResolve): Check whether we are creating an array or an object
26286 and accordingly do the needful.
26288 (New::Emit): Same here.
26290 (New::DoResolve): Implement guts of array creation.
26292 (New::FormLookupType): Helper function.
26294 2001-10-07 Miguel de Icaza <miguel@ximian.com>
26296 * codegen.cs: Removed most of the code generation here, and move the
26297 corresponding code generation bits to the statement classes.
26299 Added support for try/catch/finalize and throw.
26301 * cs-parser.jay: Added support for try/catch/finalize.
26303 * class.cs: Catch static methods having the flags override,
26304 virtual or abstract.
26306 * expression.cs (UserCast): This user cast was not really doing
26307 what it was supposed to do. Which is to be born in fully resolved
26308 state. Parts of the resolution were being performed at Emit time!
26312 2001-10-05 Miguel de Icaza <miguel@ximian.com>
26314 * expression.cs: Implicity convert the result from UserCast.
26316 2001-10-05 Ravi Pratap <ravi@ximian.com>
26318 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
26319 prevented it from working correctly.
26321 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
26322 merely ConvertImplicit.
26324 2001-10-05 Miguel de Icaza <miguel@ximian.com>
26326 * typemanager.cs: Make the LookupTypeContainer function static,
26327 and not per-instance.
26329 * class.cs: Make static FindMembers (the one that takes a Type
26332 * codegen.cs: Add EmitForeach here.
26334 * cs-parser.jay: Make foreach a toplevel object instead of the
26335 inline expansion, as we need to perform semantic analysis on it.
26337 2001-10-05 Ravi Pratap <ravi@ximian.com>
26339 * expression.cs (Expression::ImplicitUserConversion): Rename to
26340 UserDefinedConversion.
26342 (Expression::UserDefinedConversion): Take an extra argument specifying
26343 whether we look for explicit user conversions too.
26345 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
26347 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
26349 (ExplicitUserConversion): Make it a call to UserDefinedConversion
26350 with the appropriate arguments.
26352 * cs-parser.jay (cast_expression): Record location too.
26354 * expression.cs (Cast): Record location info.
26356 (Expression::ConvertExplicit): Take location argument.
26358 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
26359 to determine if we are doing explicit conversions.
26361 (UserCast::Emit): Update accordingly.
26363 (Expression::ConvertExplicit): Report an error if everything fails.
26365 * ../errors/cs0030.cs : Add.
26367 2001-10-04 Miguel de Icaza <miguel@ximian.com>
26369 * modifiers.cs: If the ABSTRACT keyword is present, also set the
26370 virtual and newslot bits.
26372 * class.cs (TypeContainer::RegisterRequiredImplementations):
26373 Record methods we need.
26375 (TypeContainer::MakeKey): Helper function to make keys for
26376 MethodBases, since the Methodbase key is useless.
26378 (TypeContainer::Populate): Call RegisterRequiredImplementations
26379 before defining the methods.
26381 Create a mapping for method_builders_to_methods ahead of time
26382 instead of inside a tight loop.
26384 (::RequireMethods): Accept an object as the data to set into the
26385 hashtable so we can report interface vs abstract method mismatch.
26387 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26389 * report.cs: Make all of it static.
26391 * rootcontext.cs: Drop object_type and value_type computations, as
26392 we have those in the TypeManager anyways.
26394 Drop report instance variable too, now it is a global.
26396 * driver.cs: Use try/catch on command line handling.
26398 Add --probe option to debug the error reporting system with a test
26401 * report.cs: Add support for exiting program when a probe
26402 condition is reached.
26404 2001-10-03 Ravi Pratap <ravi@ximian.com>
26406 * expression.cs (Binary::DoNumericPromotions): Fix the case when
26407 we do a forcible conversion regardless of type, to check if
26408 ForceConversion returns a null.
26410 (Binary::error19): Use location to report error.
26412 (Unary::error23): Use location here too.
26414 * ../errors/cs0019.cs : Check in.
26416 * ../errors/cs0023.cs : Check in.
26418 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
26419 case of a non-null MethodInfo object with a length of 0 !
26421 (Binary::ResolveOperator): Flag error if overload resolution fails to find
26422 an applicable member - according to the spec :-)
26423 Also fix logic to find members in base types.
26425 (Unary::ResolveOperator): Same here.
26427 (Unary::report23): Change name to error23 and make first argument a TypeContainer
26428 as I was getting thoroughly confused between this and error19 :-)
26430 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
26431 (::FindMostEncompassedType): Implement.
26432 (::FindMostEncompassingType): Implement.
26433 (::StandardConversionExists): Implement.
26435 (UserImplicitCast): Re-vamp. We now need info about most specific
26436 source and target types so that we can do the necessary conversions.
26438 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
26439 mathematical union with no duplicates.
26441 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26443 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
26444 in order from base classes to child classes, so that we can in
26445 child classes look up in our parent for method names and
26446 attributes (required for handling abstract, virtual, new, override
26447 constructs: we need to instrospect our base class, and if we dont
26448 populate the classes in order, the introspection might be
26449 incorrect. For example, a method could query its parent before
26450 the parent has any methods and would determine that the parent has
26451 no abstract methods (while it could have had them)).
26453 (RootContext::CreateType): Record the order in which we define the
26456 2001-10-02 Miguel de Icaza <miguel@ximian.com>
26458 * class.cs (TypeContainer::Populate): Also method definitions can
26459 fail now, keep track of this.
26461 (TypeContainer::FindMembers): Implement support for
26462 DeclaredOnly/noDeclaredOnly flag.
26464 (Constructor::Emit) Return the ConstructorBuilder.
26466 (Method::Emit) Return the MethodBuilder.
26467 Check for abstract or virtual methods to be public.
26469 * rootcontext.cs (RootContext::CreateType): Register all the
26470 abstract methods required for the class to be complete and the
26471 interface methods that must be implemented.
26473 * cs-parser.jay: Report error 501 (method requires body if it is
26474 not marked abstract or extern).
26476 * expression.cs (TypeOf::Emit): Implement.
26478 * typemanager.cs: runtime_handle_type, new global type.
26480 * class.cs (Property::Emit): Generate code for properties.
26482 2001-10-02 Ravi Pratap <ravi@ximian.com>
26484 * expression.cs (Unary::ResolveOperator): Find operators on base type
26485 too - we now conform exactly to the spec.
26487 (Binary::ResolveOperator): Same here.
26489 * class.cs (Operator::Define): Fix minor quirk in the tests.
26491 * ../errors/cs0215.cs : Added.
26493 * ../errors/cs0556.cs : Added.
26495 * ../errors/cs0555.cs : Added.
26497 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26499 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
26500 single integer which is really efficient
26502 2001-10-01 Ravi Pratap <ravi@ximian.com>
26504 * expression.cs (Expression::ImplicitUserConversion): Use location
26505 even in the case when we are examining True operators.
26507 * class.cs (Operator::Define): Perform extensive checks to conform
26508 with the rules for operator overloading in the spec.
26510 * expression.cs (Expression::ImplicitReferenceConversion): Implement
26511 some of the other conversions mentioned in the spec.
26513 * typemanager.cs (array_type): New static member for the System.Array built-in
26516 (cloneable_interface): For System.ICloneable interface.
26518 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
26519 we start resolving the tree and populating types.
26521 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
26523 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26525 * expression.cs (Expression::ExprClassFromMemberInfo,
26526 Expression::Literalize): Create literal expressions from
26527 FieldInfos which are literals.
26529 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
26530 type casts, because they were wrong. The test suite in tests
26533 (ImplicitNumericConversion): ushort to ulong requires a widening
26536 Int32 constant to long requires widening cast as well.
26538 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
26539 for integers because the type on the stack is not i4.
26541 2001-09-30 Miguel de Icaza <miguel@ximian.com>
26543 * expression.cs (report118): require location argument.
26545 * parameter.cs: Do not dereference potential null value.
26547 * class.cs: Catch methods that lack the `new' keyword when
26548 overriding a name. Report warnings when `new' is used without
26549 anything being there to override.
26551 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
26553 * class.cs: Only add constructor to hashtable if it is non-null
26554 (as now constructors can fail on define).
26556 (TypeManager, Class, Struct): Take location arguments.
26558 Catch field instance initialization in structs as errors.
26560 accepting_filter: a new filter for FindMembers that is static so
26561 that we dont create an instance per invocation.
26563 (Constructor::Define): Catch errors where a struct constructor is
26566 * cs-parser.jay: Pass location information for various new
26569 * delegate.cs (Delegate): take a location argument.
26571 * driver.cs: Do not call EmitCode if there were problesm in the
26572 Definition of the types, as many Builders wont be there.
26574 * decl.cs (Decl::Decl): Require a location argument.
26576 * cs-tokenizer.cs: Handle properly hex constants that can not fit
26577 into integers, and find the most appropiate integer for it.
26579 * literal.cs: Implement ULongLiteral.
26581 * rootcontext.cs: Provide better information about the location of
26582 failure when CreateType fails.
26584 2001-09-29 Miguel de Icaza <miguel@ximian.com>
26586 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
26589 * expression.cs (Binary::CheckShiftArguments): Add missing type
26591 (Binary::ResolveOperator): Add type to the logical and and logical
26592 or, Bitwise And/Or and Exclusive Or code paths, it was missing
26595 (Binary::DoNumericPromotions): In the case where either argument
26596 is ulong (and most signed types combined with ulong cause an
26597 error) perform implicit integer constant conversions as well.
26599 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26601 * expression.cs (UserImplicitCast): Method should always be
26603 (Invocation::BetterConversion): Simplified test for IntLiteral.
26605 (Expression::ImplicitNumericConversion): Split this routine out.
26606 Put the code that performs implicit constant integer conversions
26609 (Expression::Resolve): Become a wrapper around DoResolve so we can
26610 check eclass and type being set after resolve.
26612 (Invocation::Badness): Remove this dead function
26614 (Binary::ResolveOperator): Do not compute the expensive argumnets
26615 unless we have a union for it.
26617 (Probe::Emit): Is needs to do an isinst and then
26618 compare against null.
26620 (::CanConvert): Added Location argument. If the Location argument
26621 is null (Location.Null), then we do not report errors. This is
26622 used by the `probe' mechanism of the Explicit conversion. We do
26623 not want to generate an error for something that the user
26624 explicitly requested to be casted. But the pipeline for an
26625 explicit cast first tests for potential implicit casts.
26627 So for now, if the Location is null, it means `Probe only' to
26628 avoid adding another argument. Might have to revise this
26631 (ClassCast): New class used to type cast objects into arbitrary
26632 classes (used in Explicit Reference Conversions).
26634 Implement `as' as well.
26636 Reverted all the patches from Ravi below: they were broken:
26638 * The use of `level' as a mechanism to stop recursive
26639 invocations is wrong. That was there just to catch the
26640 bug with a strack trace but not as a way of addressing
26643 To fix the problem we have to *understand* what is going
26644 on and the interactions and come up with a plan, not
26645 just get things going.
26647 * The use of the type conversion cache that I proposed
26648 last night had an open topic: How does this work across
26649 protection domains. A user defined conversion might not
26650 be public in the location where we are applying the
26651 conversion, a different conversion might be selected
26652 (ie, private A->B (better) but public B->A (worse),
26653 inside A, A->B applies, but outside it, B->A will
26656 * On top of that (ie, even if the above is solved),
26657 conversions in a cache need to be abstract. Ie, `To
26658 convert from an Int to a Short use an OpcodeCast', not
26659 `To convert from an Int to a Short use the OpcodeCast on
26660 the variable 5' (which is what this patch was doing).
26662 2001-09-28 Ravi Pratap <ravi@ximian.com>
26664 * expression.cs (Invocation::ConversionExists): Re-write to use
26665 the conversion cache
26667 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
26668 cache all conversions done, not just user-defined ones.
26670 (Invocation::BetterConversion): The real culprit. Use ConversionExists
26671 to determine if a conversion exists instead of acutually trying to
26672 perform the conversion. It's faster too.
26674 (Expression::ConvertExplicit): Modify to use ConversionExists to check
26675 and only then attempt the implicit conversion.
26677 2001-09-28 Ravi Pratap <ravi@ximian.com>
26679 * expression.cs (ConvertImplicit): Use a cache for conversions
26680 already found. Check level of recursion and bail out if necessary.
26682 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26684 * typemanager.cs (string_concat_string_string, string_concat_object_object):
26685 Export standard methods that we expect for string operations.
26687 * statement.cs (Block::UsageWarning): Track usage of variables and
26688 report the errors for not used variables.
26690 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
26693 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26695 * codegen.cs: remove unnneded code
26697 * expression.cs: Removed BuiltinTypeAccess class
26699 Fix the order in which implicit conversions are
26702 The previous fixed dropped support for boxed conversions (adding a
26703 test to the test suite now)
26705 (UserImplicitCast::CanConvert): Remove test for source being null,
26706 that code is broken. We should not feed a null to begin with, if
26707 we do, then we should track the bug where the problem originates
26708 and not try to cover it up here.
26710 Return a resolved expression of type UserImplicitCast on success
26711 rather than true/false. Ravi: this is what I was talking about,
26712 the pattern is to use a static method as a "constructor" for
26715 Also, do not create arguments until the very last minute,
26716 otherwise we always create the arguments even for lookups that
26717 will never be performed.
26719 (UserImplicitCast::Resolve): Eliminate, objects of type
26720 UserImplicitCast are born in a fully resolved state.
26722 * typemanager.cs (InitCoreTypes): Init also value_type
26723 (System.ValueType).
26725 * expression.cs (Cast::Resolve): First resolve the child expression.
26727 (LValue): Add new method AddressOf to be used by
26730 Change the argument of Store to take an EmitContext instead of an
26731 ILGenerator, because things like FieldExpr need to be able to call
26732 their children expression to generate the instance code.
26734 (Expression::Error, Expression::Warning): Sugar functions for
26737 (Expression::MemberLookup): Accept a TypeContainer instead of a
26738 Report as the first argument.
26740 (Expression::ResolvePrimary): Killed. I still want to improve
26741 this as currently the code is just not right.
26743 (Expression::ResolveMemberAccess): Simplify, but it is still
26746 (Unary::Resolve): Catch errors in AddressOf operators.
26748 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
26749 index to a byte for the short-version, or the compiler will choose
26750 the wrong Emit call, which generates the wrong data.
26752 (ParameterReference::Emit, ::Store): same.
26754 (FieldExpr::AddressOf): Implement.
26756 * typemanager.cs: TypeManager: made public variable instead of
26759 * driver.cs: document --fatal.
26761 * report.cs (ErrorMessage, WarningMessage): new names for the old
26762 Error and Warning classes.
26764 * cs-parser.jay (member_access): Turn built-in access to types
26765 into a normal simplename
26767 2001-09-27 Ravi Pratap <ravi@ximian.com>
26769 * expression.cs (Invocation::BetterConversion): Fix to cope
26770 with q being null, since this was introducing a bug.
26772 * expression.cs (ConvertImplicit): Do built-in conversions first.
26774 2001-09-27 Ravi Pratap <ravi@ximian.com>
26776 * expression.cs (UserImplicitCast::Resolve): Fix bug.
26778 2001-09-27 Ravi Pratap <ravi@ximian.com>
26780 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
26781 I had introduced long ago (what's new ?).
26783 * expression.cs (UserImplicitCast::CanConvert): Static method to do
26784 the work of all the checking.
26785 (ConvertImplicit): Call CanConvert and only then create object if necessary.
26786 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
26788 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
26789 that is the right way.
26791 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
26792 overloading resolution. Use everywhere instead of cutting and pasting code.
26794 (Binary::ResolveOperator): Use MakeUnionSet.
26796 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
26797 we have to convert to bool types. Not complete yet.
26799 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26801 * typemanager.cs (TypeManager::CSharpName): support ushort.
26803 * expression.cs (Expression::TryImplicitIntConversion): Attempts
26804 to provide an expression that performsn an implicit constant int
26805 conversion (section 6.1.6).
26806 (Expression::ConvertImplicitRequired): Reworked to include
26807 implicit constant expression conversions.
26809 (Expression::ConvertNumericExplicit): Finished.
26811 (Invocation::Emit): If InstanceExpression is null, then it means
26812 that we perform a call on this.
26814 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26816 * expression.cs (Unary::Emit): Remove some dead code.
26817 (Probe): Implement Resolve and Emit for `is'.
26818 (Expression::ConvertImplicitRequired): Attempt to do constant
26819 expression conversions here. Maybe should be moved to
26820 ConvertImplicit, but I am not sure.
26821 (Expression::ImplicitLongConstantConversionPossible,
26822 Expression::ImplicitIntConstantConversionPossible): New functions
26823 that tell whether is it possible to apply an implicit constant
26824 expression conversion.
26826 (ConvertNumericExplicit): Started work on explicit numeric
26829 * cs-parser.jay: Update operator constants.
26831 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
26832 (Parameters::GetSignature): Hook up VerifyArgs here.
26833 (Parameters::VerifyArgs): Verifies that no two arguments have the
26836 * class.cs (Operator): Update the operator names to reflect the
26837 ones that the spec expects (as we are just stringizing the
26840 * expression.cs (Unary::ResolveOperator): Fix bug: Use
26841 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
26842 previous usage did only work for our methods.
26843 (Expression::ConvertImplicit): Handle decimal implicit numeric
26844 conversions as well.
26845 (Expression::InternalTypeConstructor): Used to invoke constructors
26846 on internal types for default promotions.
26848 (Unary::Emit): Implement special handling for the pre/post
26849 increment/decrement for overloaded operators, as they need to have
26850 the same semantics as the other operators.
26852 (Binary::ResolveOperator): ditto.
26853 (Invocation::ConversionExists): ditto.
26854 (UserImplicitCast::Resolve): ditto.
26856 2001-09-26 Ravi Pratap <ravi@ximian.com>
26858 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
26859 operator, return after emitting body. Regression tests pass again !
26861 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
26862 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
26863 (Invocation::OverloadResolve): Ditto.
26864 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
26866 * everywhere : update calls to the above methods accordingly.
26868 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26870 * assign.cs (Assign): Make it inherit from ExpressionStatement.
26872 * expression.cs (ExpressionStatement): New base class used for
26873 expressions that can appear in statements, so that we can provide
26874 an alternate path to generate expression that do not leave a value
26877 (Expression::Emit, and all the derivatives): We no longer return
26878 whether a value is left on the stack or not. Every expression
26879 after being emitted leaves a single value on the stack.
26881 * codegen.cs (EmitContext::EmitStatementExpression): Use the
26882 facilties of ExpressionStatement if possible.
26884 * cs-parser.jay: Update statement_expression.
26886 2001-09-25 Miguel de Icaza <miguel@ximian.com>
26888 * driver.cs: Change the wording of message
26890 2001-09-25 Ravi Pratap <ravi@ximian.com>
26892 * expression.cs (Binary::ResolveOperator): Had forgottten to set
26893 the type of the expression to the return type of the method if
26894 we have an overloaded operator match ! The regression tests pass again !
26895 (Unary::ResolveOperator): Ditto.
26897 * expression.cs (Invocation::ConversionExists): Correct the member lookup
26898 to find "op_Implicit", not "implicit" ;-)
26899 (UserImplicitCast): New class to take care of user-defined implicit conversions.
26900 (ConvertImplicit, ForceConversion): Take TypeContainer argument
26902 * everywhere : Correct calls to the above accordingly.
26904 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
26905 (ConvertImplicit): Do user-defined conversion if it exists.
26907 2001-09-24 Miguel de Icaza <miguel@ximian.com>
26909 * assign.cs: track location.
26910 (Resolve): Use implicit conversions on assignment.
26912 * literal.cs: Oops. Not good, Emit of short access values should
26913 pass (Bytes) or the wrong argument will be selected.
26915 * expression.cs (Unary::Emit): Emit code for -expr.
26917 (Unary::ResolveOperator): Handle `Substract' for non-constants
26918 (substract from zero from the non-constants).
26919 Deal with Doubles as well.
26921 (Expression::ConvertImplicitRequired): New routine that reports an
26922 error if no implicit conversion exists.
26924 (Invocation::OverloadResolve): Store the converted implicit
26925 expressions if we make them
26927 2001-09-24 Ravi Pratap <ravi@ximian.com>
26929 * class.cs (ConstructorInitializer): Take a Location argument.
26930 (ConstructorBaseInitializer): Same here.
26931 (ConstructorThisInitializer): Same here.
26933 * cs-parser.jay : Update all calls accordingly.
26935 * expression.cs (Unary, Binary, New): Take location argument.
26936 Update accordingly everywhere.
26938 * cs-parser.jay : Update all calls to the above to take a location
26941 * class.cs : Ditto.
26943 2001-09-24 Ravi Pratap <ravi@ximian.com>
26945 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
26946 (Invocation::BetterConversion): Same here
26947 (Invocation::ConversionExists): Ditto.
26949 (Invocation::ConversionExists): Implement.
26951 2001-09-22 Ravi Pratap <ravi@ximian.com>
26953 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
26954 Also take an additional TypeContainer argument.
26956 * All over : Pass in TypeContainer as argument to OverloadResolve.
26958 * typemanager.cs (CSharpName): Update to check for the string type and return
26961 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
26964 2001-09-21 Ravi Pratap <ravi@ximian.com>
26966 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
26967 (Invocation::BetterFunction): Implement.
26968 (Invocation::BetterConversion): Implement.
26969 (Invocation::ConversionExists): Skeleton, no implementation yet.
26971 Okay, things work fine !
26973 2001-09-21 Miguel de Icaza <miguel@ximian.com>
26975 * typemanager.cs: declare and load enum_type, delegate_type and
26978 * expression.cs (Expression::Emit): Now emit returns a value that
26979 tells whether a value is left on the stack or not. This strategy
26980 might be reveted tomorrow with a mechanism that would address
26981 multiple assignments.
26982 (Expression::report118): Utility routine to report mismatches on
26985 (Unary::Report23): Report impossible type/operator combination
26988 (Unary::IsIncrementableNumber): Whether the type can be
26989 incremented or decremented with add.
26990 (Unary::ResolveOperator): Also allow enumerations to be bitwise
26992 (Unary::ResolveOperator): Implement ++, !, ~,
26994 (Invocation::Emit): Deal with new Emit convetion.
26996 * All Expression derivatives: Updated their Emit method to return
26997 whether they leave values on the stack or not.
26999 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
27000 stack for expressions that are statements.
27002 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27004 * expression.cs (LValue): New interface. Must be implemented by
27006 (LocalVariableReference, ParameterReference, FieldExpr): Implement
27009 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
27010 interface for generating code, simplifies the code.
27012 2001-09-20 Ravi Pratap <ravi@ximian.com>
27014 * expression.cs (everywhere): Comment out return statements in ::Resolve
27015 methods to avoid the warnings.
27017 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27019 * driver.cs (parse): Report error 2001 if we can not open the
27022 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
27025 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
27028 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
27029 otherwise nested blocks end up with the same index.
27031 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
27033 * expression.cs: Instead of having FIXMEs in the Resolve
27034 functions, throw exceptions so it is obvious that we are facing a
27037 * cs-parser.jay (invocation_expression): Pass Location information.
27039 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
27040 Use a basename for those routines because .NET does not like paths
27043 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
27046 2001-09-19 Miguel de Icaza <miguel@ximian.com>
27048 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
27049 are loading the correct data types (throws an exception if not).
27050 (TypeManager::InitCoreTypes): Use CoreLookupType
27052 * expression.cs (Unary::ResolveOperator): return the child
27053 expression for expressions which are just +expr.
27054 (Unary::ResolveOperator): Return negative literals for -LITERAL
27055 expressions (otherwise they are Unary {Literal}).
27056 (Invocation::Badness): Take into account `Implicit constant
27057 expression conversions'.
27059 * literal.cs (LongLiteral): Implement long literal class.
27060 (IntLiteral): export the `Value' of the intliteral.
27062 2001-09-19 Ravi Pratap <ravi@ximian.com>
27064 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
27066 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
27067 instead of 'Operator'
27069 * expression.cs (Binary::ResolveOperator): Update accordingly.
27070 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
27073 * cs-parser.jay (unary_expression): Update to use the new names.
27075 * gen-treedump.cs (GetUnary): Same here.
27077 * expression.cs (Unary::Resolve): Implement.
27078 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
27079 operators are found instead of making noise ;-)
27080 (Unary::ResolveOperator): New method to do precisely the same thing which
27081 Binary::ResolveOperator does for Binary expressions.
27082 (Unary.method, .Arguments): Add.
27083 (Unary::OperName): Implement.
27084 (Unary::ForceConversion): Copy and Paste !
27086 * class.cs (Operator::Define): Fix a small bug for the case when we have
27089 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
27090 for the inbuilt operators. Only overloading works for now ;-)
27092 2001-09-18 Miguel de Icaza <miguel@ximian.com>
27094 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
27095 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
27097 * expression.cs (This::Emit): Implement.
27098 (This::Resolve): Implement.
27099 (TypeOf:Resolve): Implement.
27100 (Expression::ResolveSimpleName): Add an implicit this to instance
27102 (MemberAccess::Resolve): Deal with Parameters and Fields.
27103 Bind instance variable to Field expressions.
27104 (FieldExpr::Instance): New field used to track the expression that
27105 represents the object instance.
27106 (FieldExpr::Resolve): Track potential errors from MemberLookup not
27108 (FieldExpr::Emit): Implement.
27110 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
27111 the last instruction contains a return opcode to avoid generating
27112 the last `ret' instruction (this generates correct code, and it is
27113 nice to pass the peverify output).
27115 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
27116 initializer for static and instance variables.
27117 (Constructor::Emit): Allow initializer to be null in the case of
27118 static constructors. Only emit initializer for instance
27121 (TypeContainer::FindMembers): Return a null array if there are no
27124 Also fix the code for the MemberTypes.Method branch, as it was not
27125 scanning that for operators (or tried to access null variables before).
27127 * assign.cs (Assign::Emit): Handle instance and static fields.
27131 * driver.cs: Stop compilation if there are parse errors.
27133 * cs-parser.jay (constructor_declaration): Provide default base
27134 initializer for non-static constructors.
27135 (constructor_declarator): Do not provide a default base
27136 initializers if none was specified.
27137 Catch the fact that constructors should not have parameters.
27139 * class.cs: Do not emit parent class initializers for static
27140 constructors, that should be flagged as an error.
27142 2001-09-18 Ravi Pratap <ravi@ximian.com>
27144 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
27145 Move back code into TypeContainer::Populate.
27147 2001-09-18 Ravi Pratap <ravi@ximian.com>
27149 * class.cs (TypeContainer::AddConstructor): Fix the check to
27150 compare against Name, not Basename.
27151 (Operator::OpType): Change Plus and Minus to Add and Subtract.
27153 * cs-parser.jay : Update accordingly.
27155 * class.cs (TypeContainer::FindMembers): For the case where we are searching
27156 for methods, don't forget to look into the operators too.
27157 (RegisterMethodBuilder): Helper method to take care of this for
27158 methods, constructors and operators.
27159 (Operator::Define): Completely revamp.
27160 (Operator.OperatorMethod, MethodName): New fields.
27161 (TypeContainer::Populate): Move the registering of builders into
27162 RegisterMethodBuilder.
27163 (Operator::Emit): Re-write.
27165 * expression.cs (Binary::Emit): Comment out code path to emit method
27166 invocation stuff for the case when we have a user defined operator. I am
27167 just not able to get it right !
27169 2001-09-17 Miguel de Icaza <miguel@ximian.com>
27171 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
27174 (Expression::MemberLookup): Provide a version that allows to
27175 specify the MemberTypes and BindingFlags.
27177 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
27178 so it was not fetching variable information from outer blocks.
27180 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
27181 Beforefieldinit as it was buggy.
27183 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
27184 that Ravi put here.
27186 * class.cs (Constructor::Emit): Only emit if block is not null.
27187 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
27188 deal with this by semantically definining it as if the user had
27191 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
27192 constructors as we now "emit" them at a higher level.
27194 (TypeContainer::DefineDefaultConstructor): Used to define the
27195 default constructors if none was provided.
27197 (ConstructorInitializer): Add methods Resolve and Emit.
27199 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
27201 2001-09-17 Ravi Pratap <ravi@ximian.com>
27203 * class.cs (TypeContainer::EmitDefaultConstructor): Register
27204 the default constructor builder with our hashtable for methodbuilders
27207 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
27208 and argument_count is 0 in which case we have a match.
27209 (Binary::ResolveOperator): More null checking and miscellaneous coding
27212 2001-09-17 Ravi Pratap <ravi@ximian.com>
27214 * rootcontext.cs (IsNameSpace): Compare against null.
27216 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
27218 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
27219 and Unary::Operator.
27221 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
27224 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
27225 we have overloaded operators.
27226 (Binary::ResolveOperator): Implement the part which does the operator overload
27229 * class.cs (Operator::Emit): Implement.
27230 (TypeContainer::Emit): Emit the operators we have too.
27232 * expression.cs (Binary::Emit): Update to emit the appropriate code for
27233 the case when we have a user-defined operator.
27235 2001-09-17 Miguel de Icaza <miguel@ximian.com>
27237 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
27239 2001-09-16 Ravi Pratap <ravi@ximian.com>
27241 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
27242 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
27243 (Constructor::Emit): Implement.
27244 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
27245 if we have no work to do.
27246 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
27249 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
27250 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
27252 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
27255 2001-09-15 Ravi Pratap <ravi@ximian.com>
27257 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
27259 (Tree::RecordNamespace): Method to do what the name says ;-)
27260 (Tree::Namespaces): Property to get at the namespaces hashtable.
27262 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
27265 * rootcontext.cs (IsNamespace): Fixed it :-)
27267 2001-09-14 Miguel de Icaza <miguel@ximian.com>
27269 * class.cs (TypeContainer::FindMembers): Add support for
27271 (MethodCore): New class that encapsulates both the shared aspects
27272 of a Constructor and a Method.
27273 (Method, Constructor): Factored pieces into MethodCore.
27275 * driver.cs: Added --fatal which makes errors throw exceptions.
27276 Load System assembly as well as part of the standard library.
27278 * report.cs: Allow throwing exceptions on errors for debugging.
27280 * modifiers.cs: Do not use `parent', instead use the real type
27281 container to evaluate permission settings.
27283 * class.cs: Put Ravi's patch back in. He is right, and we will
27284 have to cope with the
27286 2001-09-14 Ravi Pratap <ravi@ximian.com>
27288 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
27289 FamORAssem, not FamANDAssem.
27291 2001-09-14 Miguel de Icaza <miguel@ximian.com>
27293 * driver.cs: Added --parse option that only parses its input files
27296 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
27297 incorrect. IsTopLevel is not used to tell whether an object is
27298 root_types or not (that can be achieved by testing this ==
27299 root_types). But to see if this is a top-level *class* (not
27300 necessarly our "toplevel" container).
27302 2001-09-14 Ravi Pratap <ravi@ximian.com>
27304 * enum.cs (Enum::Define): Modify to call the Lookup method on the
27305 parent instead of a direct call to GetType.
27307 2001-09-14 Ravi Pratap <ravi@ximian.com>
27309 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
27310 Modifiers.TypeAttr. This should just be a call to that method.
27312 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
27313 object so that we can determine if we are top-level or not.
27315 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
27318 * enum.cs (Enum::Define): Ditto.
27320 * modifiers.cs (FieldAttr): Re-write.
27322 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
27323 (TypeContainer::HaveStaticConstructor): New property to provide access
27324 to precisely that info.
27326 * modifiers.cs (MethodAttr): Re-write.
27327 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
27329 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
27330 of top-level types as claimed.
27332 2001-09-13 Miguel de Icaza <miguel@ximian.com>
27334 * expression.cs (MemberLookup): Fruitless attempt to lookup
27335 constructors. Maybe I need to emit default constructors? That
27336 might be it (currently .NET emits this for me automatically).
27337 (Invocation::OverloadResolve): Cope with Arguments == null.
27338 (Invocation::EmitArguments): new function, shared by the new
27339 constructor and us.
27340 (Invocation::Emit): Handle static and instance methods. Emit
27341 proper call instruction for virtual or non-virtual invocations.
27342 (New::Emit): Implement.
27343 (New::Resolve): Implement.
27344 (MemberAccess:Resolve): Implement.
27345 (MethodGroupExpr::InstanceExpression): used conforming to the spec
27346 to track instances.
27347 (FieldExpr::Resolve): Set type.
27349 * support.cs: Handle empty arguments.
27351 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
27352 SimpleLookup): Auxiliary routines to help parse a qualifier
27355 Update qualifier_identifier rule.
27357 * codegen.cs: Removed debugging messages.
27359 * class.cs: Make this a global thing, this acts just as a "key" to
27360 objects that we might have around.
27362 (Populate): Only initialize method_builders_to_methods once.
27364 * expression.cs (PropertyExpr): Initialize type from the
27367 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
27368 Resolve pattern. Attempt to implicitly convert value to boolean.
27371 * expression.cs: Set the type for the int32/int32 argument case.
27372 (Binary::ResolveOperator): Set the return type to boolean for
27373 comparission operators
27375 * typemanager.cs: Remove debugging print code.
27377 (Invocation::Resolve): resolve type.
27379 * class.cs: Allocate a MemberInfo of the correct size, as the code
27380 elsewhere depends on the test to reflect the correct contents.
27382 (Method::) Keep track of parameters, due to System.Reflection holes
27384 (TypeContainer::Populate): Keep track of MethodBuilders to Method
27387 (TypeContainer::FindMembers): Use ArrayList and then copy an array
27388 of the exact size and return that.
27390 (Class::LookupMethodByBuilder): New function that maps
27391 MethodBuilders to its methods. Required to locate the information
27392 on methods because System.Reflection bit us again.
27394 * support.cs: New file, contains an interface ParameterData and
27395 two implementations: ReflectionParameters and InternalParameters
27396 used to access Parameter information. We will need to grow this
27399 * expression.cs (Invocation::GetParameterData): implement a cache
27400 and a wrapper around the ParameterData creation for methods.
27401 (Invocation::OverloadResolve): Use new code.
27403 2001-09-13 Ravi Pratap <ravi@ximian.com>
27405 * class.cs (TypeContainer::EmitField): Remove and move into
27406 (Field::Define): here and modify accordingly.
27407 (Field.FieldBuilder): New member.
27408 (TypeContainer::Populate): Update accordingly.
27409 (TypeContainer::FindMembers): Implement.
27411 2001-09-13 Miguel de Icaza <miguel@ximian.com>
27413 * statement.cs: (VariableInfo::VariableType): New field to be
27414 initialized with the full type once it is resolved.
27416 2001-09-12 Miguel de Icaza <miguel@ximian.com>
27418 * parameter.cs (GetParameterInfo): Use a type cache to compute
27419 things only once, and to reuse this information
27421 * expression.cs (LocalVariableReference::Emit): Implement.
27422 (OpcodeCast::Emit): fix.
27424 (ParameterReference::Resolve): Implement.
27425 (ParameterReference::Emit): Implement.
27427 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
27428 that are expressions need to stay as Expressions.
27430 * typemanager.cs (CSharpName): Returns the C# name of a type if
27433 * expression.cs (Expression::ConvertImplicit): New function that
27434 implements implicit type conversions.
27436 (Expression::ImplicitReferenceConversion): Implements implicit
27437 reference conversions.
27439 (EmptyCast): New type for transparent casts.
27441 (OpcodeCast): New type for casts of types that are performed with
27442 a sequence of bytecodes.
27444 (BoxedCast): New type used for casting value types into reference
27445 types. Emits a box opcode.
27447 (Binary::DoNumericPromotions): Implements numeric promotions of
27448 and computation of the Binary::Type.
27450 (Binary::EmitBranchable): Optimization.
27452 (Binary::Emit): Implement code emission for expressions.
27454 * typemanager.cs (TypeManager): Added two new core types: sbyte
27457 2001-09-12 Ravi Pratap <ravi@ximian.com>
27459 * class.cs (TypeContainer::FindMembers): Method which does exactly
27460 what Type.FindMembers does, only we don't have to use reflection. No
27461 implementation yet.
27463 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
27464 typecontainer objects as we need to get at them.
27465 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
27467 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
27468 typecontainer object.
27470 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
27471 of just a Report object.
27473 2001-09-11 Ravi Pratap <ravi@ximian.com>
27475 * class.cs (Event::Define): Go back to using the prefixes "add_" and
27477 (TypeContainer::Populate): Now define the delegates of the type too.
27478 (TypeContainer.Delegates): Property to access the list of delegates defined
27481 * delegates.cs (Delegate::Define): Implement partially.
27483 * modifiers.cs (TypeAttr): Handle more flags.
27485 2001-09-11 Ravi Pratap <ravi@ximian.com>
27487 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
27489 (Operator::Define): Re-write logic to get types by using the LookupType method
27490 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
27491 (Indexer::Define): Ditto.
27492 (Event::Define): Ditto.
27493 (Property::Define): Ditto.
27495 2001-09-10 Ravi Pratap <ravi@ximian.com>
27497 * class.cs (TypeContainer::Populate): Now define operators too.
27498 (TypeContainer.Operators): New property to access the list of operators
27500 (Operator.OperatorMethodBuilder): New member to hold the method builder
27501 for the operator we are defining.
27502 (Operator::Define): Implement.
27504 2001-09-10 Ravi Pratap <ravi@ximian.com>
27506 * class.cs (Event::Define): Make the prefixes of the accessor methods
27507 addOn_ and removeOn_
27509 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
27510 of the location being passed in too. Ideally, this should go later since all
27511 error reporting should be done through the Report object.
27513 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
27514 (Populate): Iterate thru the indexers we have and define them too.
27515 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
27516 for the get and set accessors.
27517 (Indexer::Define): Implement.
27519 2001-09-09 Miguel de Icaza <miguel@ximian.com>
27521 * expression.cs (Binary::Resolve): Beginning of it. I scratched
27522 my previous implementation, did not work.
27524 * typemanager.cs: Add a couple of missing types (the longs).
27526 * literal.cs: Use TypeManager.bool_type instead of getting it.
27528 * expression.cs (EventExpr): New kind of expressions.
27529 (Expressio::ExprClassFromMemberInfo): finish
27531 2001-09-08 Miguel de Icaza <miguel@ximian.com>
27533 * assign.cs: Emit stores to static fields differently.
27535 2001-09-08 Ravi Pratap <ravi@ximian.com>
27537 * Merge in changes and adjust code to tackle conflicts. Backed out my
27538 code in Assign::Resolve ;-)
27540 2001-09-08 Ravi Pratap <ravi@ximian.com>
27542 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
27543 instead Report.Error and also pass in the location.
27544 (CSharpParser::Lexer): New readonly property to return the reference
27545 to the Tokenizer object.
27546 (declare_local_variables): Use Report.Error with location instead of plain
27550 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
27551 (Operator.CheckBinaryOperator): Ditto.
27553 * cs-parser.jay (operator_declarator): Update accordingly.
27555 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
27556 (CheckBinaryOperator): Same here.
27558 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
27559 on the name without any prefixes of namespace names etc. This is because we
27560 already might have something already fully qualified like
27561 'System.Console.WriteLine'
27563 * assign.cs (Resolve): Begin implementation. Stuck ;-)
27565 2001-09-07 Ravi Pratap <ravi@ximian.com>
27567 * cs-tokenizer.cs (location): Return a string which also contains
27570 * expression.cs (ElementAccess): New class for expressions of the
27571 type 'element access.'
27572 (BaseAccess): New class for expressions of the type 'base access.'
27573 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
27576 * cs-parser.jay (element_access): Implement action.
27577 (base_access): Implement actions.
27578 (checked_expression, unchecked_expression): Implement.
27580 * cs-parser.jay (local_variable_type): Correct and implement.
27581 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
27583 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
27585 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
27586 name and the specifiers.
27588 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
27590 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
27591 making them all public ;-)
27593 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
27596 2001-09-07 Miguel de Icaza <miguel@ximian.com>
27598 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
27600 (FieldExpr, PropertyExprs): New resolved expressions.
27601 (SimpleName::MemberStaticCheck): Perform static checks for access
27602 to non-static fields on static methods. Maybe this should be
27603 generalized for MemberAccesses.
27604 (SimpleName::ResolveSimpleName): More work on simple name
27607 * cs-parser.jay (primary_expression/qualified_identifier): track
27608 the parameter index.
27610 * codegen.cs (CodeGen::Save): Catch save exception, report error.
27611 (EmitContext::EmitBoolExpression): Chain to expression generation
27612 instead of temporary hack.
27613 (::EmitStatementExpression): Put generic expression code generation.
27615 * assign.cs (Assign::Emit): Implement variable assignments to
27616 local variables, parameters and fields.
27618 2001-09-06 Miguel de Icaza <miguel@ximian.com>
27620 * statement.cs (Block::GetVariableInfo): New method, returns the
27621 VariableInfo for a variable name in a block.
27622 (Block::GetVariableType): Implement in terms of GetVariableInfo
27624 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
27625 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
27627 2001-09-06 Ravi Pratap <ravi@ximian.com>
27629 * cs-parser.jay (operator_declaration): Continue on my quest : update
27630 to take attributes argument.
27631 (event_declaration): Ditto.
27632 (enum_declaration): Ditto.
27633 (indexer_declaration): Ditto.
27635 * class.cs (Operator::Operator): Update constructor accordingly.
27636 (Event::Event): Ditto.
27638 * delegate.cs (Delegate::Delegate): Same here.
27640 * enum.cs (Enum::Enum): Same here.
27642 2001-09-05 Ravi Pratap <ravi@ximian.com>
27644 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
27646 * ../tests/cs0658.cs : New file to demonstrate error 0658.
27648 * attribute.cs (Attributes): New class to encapsulate all attributes which were
27649 being passed around as an arraylist.
27650 (Attributes::AddAttribute): Method to add attribute sections.
27652 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
27653 (struct_declaration): Update accordingly.
27654 (constant_declaration): Update.
27655 (field_declaration): Update.
27656 (method_header): Update.
27657 (fixed_parameter): Update.
27658 (parameter_array): Ditto.
27659 (property_declaration): Ditto.
27660 (destructor_declaration): Ditto.
27662 * class.cs (Struct::Struct): Update constructors accordingly.
27663 (Class::Class): Ditto.
27664 (Field::Field): Ditto.
27665 (Method::Method): Ditto.
27666 (Property::Property): Ditto.
27667 (TypeContainer::OptAttribute): update property's return type.
27669 * interface.cs (Interface.opt_attributes): New member.
27670 (Interface::Interface): Update to take the extra Attributes argument.
27672 * parameter.cs (Parameter::Parameter): Ditto.
27674 * constant.cs (Constant::Constant): Ditto.
27676 * interface.cs (InterfaceMemberBase): New OptAttributes field.
27677 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
27678 the attributes as a parameter.
27679 (InterfaceProperty): Update constructor call.
27680 (InterfaceEvent): Ditto.
27681 (InterfaceMethod): Ditto.
27682 (InterfaceIndexer): Ditto.
27684 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
27685 pass the attributes too.
27686 (interface_event_declaration): Ditto.
27687 (interface_property_declaration): Ditto.
27688 (interface_method_declaration): Ditto.
27689 (interface_declaration): Ditto.
27691 2001-09-05 Miguel de Icaza <miguel@ximian.com>
27693 * class.cs (Method::Define): Track the "static Main" definition to
27694 create an entry point.
27696 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
27697 EntryPoint if we find it.
27699 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
27700 (EmitContext::ig): Make this variable public.
27702 * driver.cs: Make the default output file be the first file name
27703 with the .exe extension.
27705 Detect empty compilations
27707 Handle various kinds of output targets. Handle --target and
27708 rename -t to --dumper.
27710 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
27711 methods inherited from Expression return now an Expression. This
27712 will is used during the tree rewriting as we resolve them during
27715 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
27716 the spec. Missing entirely is the information about
27717 accessability of elements of it.
27719 (Expression::ExprClassFromMemberInfo): New constructor for
27720 Expressions that creates a fully initialized Expression based on
27721 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
27724 (Invocation::Resolve): Begin implementing resolution of invocations.
27726 * literal.cs (StringLiteral): Implement Emit.
27728 2001-09-05 Ravi Pratap <ravi@ximian.com>
27730 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
27733 2001-09-04 Ravi Pratap <ravi@ximian.com>
27735 * cs-parser.jay (attribute_arguments): Implement actions.
27736 (attribute): Fix bug in production. Implement action.
27737 (attribute_list): Implement.
27738 (attribute_target): Implement.
27739 (attribute_target_specifier, opt_target_specifier): Implement
27740 (CheckAttributeTarget): New method to check if the attribute target
27742 (attribute_section): Implement.
27743 (opt_attributes): Implement.
27745 * attribute.cs : New file to handle attributes.
27746 (Attribute): Class to hold attribute info.
27748 * cs-parser.jay (opt_attribute_target_specifier): Remove production
27749 (attribute_section): Modify production to use 2 different rules to
27750 achieve the same thing. 1 s/r conflict down !
27751 Clean out commented, useless, non-reducing dimension_separator rules.
27753 * class.cs (TypeContainer.attributes): New member to hold list
27754 of attributes for a type.
27755 (Struct::Struct): Modify to take one more argument, the attribute list.
27756 (Class::Class): Ditto.
27757 (Field::Field): Ditto.
27758 (Method::Method): Ditto.
27759 (Property::Property): Ditto.
27761 * cs-parser.jay (struct_declaration): Update constructor call to
27762 pass in the attributes too.
27763 (class_declaration): Ditto.
27764 (constant_declaration): Ditto.
27765 (field_declaration): Ditto.
27766 (method_header): Ditto.
27767 (fixed_parameter): Ditto.
27768 (parameter_array): Ditto.
27769 (property_declaration): Ditto.
27771 * constant.cs (Constant::Constant): Update constructor similarly.
27772 Use System.Collections.
27774 * parameter.cs (Parameter::Parameter): Update as above.
27776 2001-09-02 Ravi Pratap <ravi@ximian.com>
27778 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
27779 (TypeContainer.delegates): New member to hold list of delegates.
27781 * cs-parser.jay (delegate_declaration): Implement the action correctly
27782 this time as I seem to be on crack ;-)
27784 2001-09-02 Miguel de Icaza <miguel@ximian.com>
27786 * rootcontext.cs (RootContext::IsNamespace): new function, used to
27787 tell whether an identifier represents a namespace.
27789 * expression.cs (NamespaceExpr): A namespace expression, used only
27790 temporarly during expression resolution.
27791 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
27792 utility functions to resolve names on expressions.
27794 2001-09-01 Miguel de Icaza <miguel@ximian.com>
27796 * codegen.cs: Add hook for StatementExpressions.
27798 * class.cs: Fix inverted test for static flag in methods.
27800 2001-09-02 Ravi Pratap <ravi@ximian.com>
27802 * class.cs (Operator::CheckUnaryOperator): Correct error number used
27803 to make it coincide with MS' number.
27804 (Operator::CheckBinaryOperator): Ditto.
27806 * ../errors/errors.txt : Remove error numbers added earlier.
27808 * ../errors/cs1019.cs : Test case for error # 1019
27810 * ../errros/cs1020.cs : Test case for error # 1020
27812 * cs-parser.jay : Clean out commented cruft.
27813 (dimension_separators, dimension_separator): Comment out. Ostensibly not
27814 used anywhere - non-reducing rule.
27815 (namespace_declarations): Non-reducing rule - comment out.
27817 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
27818 with TypeContainer::AddEnum.
27820 * delegate.cs : New file for delegate handling classes.
27821 (Delegate): Class for declaring delegates.
27823 * makefile : Update.
27825 * cs-parser.jay (delegate_declaration): Implement.
27827 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
27829 * class.cs (Event::Define): Implement.
27830 (Event.EventBuilder): New member.
27832 * class.cs (TypeContainer::Populate): Update to define all enums and events
27834 (Events): New property for the events arraylist we hold. Shouldn't we move to using
27835 readonly fields for all these cases ?
27837 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27839 * class.cs (Property): Revamp to use the convention of making fields readonly.
27840 Accordingly modify code elsewhere.
27842 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
27843 the Define method of the Property class.
27845 * class.cs : Clean up applied patch and update references to variables etc. Fix
27847 (TypeContainer::Populate): Update to define all the properties we have. Also
27848 define all enumerations.
27850 * enum.cs (Define): Implement.
27852 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27854 * cs-parser.jay (overloadable_operator): The semantic value is an
27855 enum of the Operator class.
27856 (operator_declarator): Implement actions.
27857 (operator_declaration): Implement.
27859 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
27860 validity of definitions.
27861 (Operator::CheckBinaryOperator): Static method to check for binary operators
27862 (TypeContainer::AddOperator): New method to add an operator to a type.
27864 * cs-parser.jay (indexer_declaration): Added line to actually call the
27865 AddIndexer method so it gets added ;-)
27867 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
27868 already taken care of by the MS compiler ?
27870 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27872 * class.cs (Operator): New class for operator declarations.
27873 (Operator::OpType): Enum for the various operators.
27875 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27877 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
27878 ostensibly handle this in semantic analysis.
27880 * cs-parser.jay (general_catch_clause): Comment out
27881 (specific_catch_clauses, specific_catch_clause): Ditto.
27882 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
27883 (catch_args, opt_catch_args): New productions.
27884 (catch_clause): Rewrite to use the new productions above
27885 (catch_clauses): Modify accordingly.
27886 (opt_catch_clauses): New production to use in try_statement
27887 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
27888 and re-write the code in the actions to extract the specific and
27889 general catch clauses by being a little smart ;-)
27891 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
27892 Hooray, try and catch statements parse fine !
27894 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27896 * statement.cs (Block::GetVariableType): Fix logic to extract the type
27897 string from the hashtable of variables.
27899 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
27900 I end up making that mistake ;-)
27901 (catch_clauses): Fixed gross error which made Key and Value of the
27902 DictionaryEntry the same : $1 !!
27904 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27906 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
27908 * cs-parser.jay (event_declaration): Correct to remove the semicolon
27909 when the add and remove accessors are specified.
27911 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27913 * cs-parser.jay (IndexerDeclaration): New helper class to hold
27914 information about indexer_declarator.
27915 (indexer_declarator): Implement actions.
27916 (parsing_indexer): New local boolean used to keep track of whether
27917 we are parsing indexers or properties. This is necessary because
27918 implicit_parameters come into picture even for the get accessor in the
27919 case of an indexer.
27920 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
27922 * class.cs (Indexer): New class for indexer declarations.
27923 (TypeContainer::AddIndexer): New method to add an indexer to a type.
27924 (TypeContainer::indexers): New member to hold list of indexers for the
27927 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27929 * cs-parser.jay (add_accessor_declaration): Implement action.
27930 (remove_accessor_declaration): Implement action.
27931 (event_accessors_declaration): Implement
27932 (variable_declarators): swap statements for first rule - trivial.
27934 * class.cs (Event): New class to hold information about event
27936 (TypeContainer::AddEvent): New method to add an event to a type
27937 (TypeContainer::events): New member to hold list of events.
27939 * cs-parser.jay (event_declaration): Implement actions.
27941 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27943 * cs-parser.jay (dim_separators): Implement. Make it a string
27944 concatenating all the commas together, just as they appear.
27945 (opt_dim_separators): Modify accordingly
27946 (rank_specifiers): Update accordingly. Basically do the same
27947 thing - instead, collect the brackets here.
27948 (opt_rank_sepcifiers): Modify accordingly.
27949 (array_type): Modify to actually return the complete type string
27950 instead of ignoring the rank_specifiers.
27951 (expression_list): Implement to collect the expressions
27952 (variable_initializer): Implement. We make it a list of expressions
27953 essentially so that we can handle the array_initializer case neatly too.
27954 (variable_initializer_list): Implement.
27955 (array_initializer): Make it a list of variable_initializers
27956 (opt_array_initializer): Modify accordingly.
27958 * expression.cs (New::NType): Add enumeration to help us
27959 keep track of whether we have an object/delegate creation
27960 or an array creation.
27961 (New:NewType, New::Rank, New::Indices, New::Initializers): New
27962 members to hold data about array creation.
27963 (New:New): Modify to update NewType
27964 (New:New): New Overloaded contructor for the array creation
27967 * cs-parser.jay (array_creation_expression): Implement to call
27968 the overloaded New constructor.
27970 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
27972 * class.cs (TypeContainer::Constructors): Return member
27973 constructors instead of returning null.
27975 2001-08-26 Miguel de Icaza <miguel@ximian.com>
27977 * typemanager.cs (InitCoreTypes): Initialize the various core
27978 types after we have populated the type manager with the user
27979 defined types (this distinction will be important later while
27980 compiling corlib.dll)
27982 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
27983 on Expression Classification. Now all expressions have a method
27984 `Resolve' and a method `Emit'.
27986 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
27987 generation from working. Also add some temporary debugging
27990 2001-08-24 Miguel de Icaza <miguel@ximian.com>
27992 * codegen.cs: Lots of code generation pieces. This is only the
27993 beginning, will continue tomorrow with more touches of polish. We
27994 handle the fundamentals of if, while, do, for, return. Others are
27995 trickier and I need to start working on invocations soon.
27997 * gen-treedump.cs: Bug fix, use s.Increment here instead of
28000 * codegen.cs (EmitContext): New struct, used during code
28001 emission to keep a context. Most of the code generation will be
28004 * cs-parser.jay: Add embedded blocks to the list of statements of
28005 this block. So code generation proceeds in a top down fashion.
28007 2001-08-23 Miguel de Icaza <miguel@ximian.com>
28009 * statement.cs: Add support for multiple child blocks.
28011 2001-08-22 Miguel de Icaza <miguel@ximian.com>
28013 * codegen.cs (EmitCode): New function, will emit the code for a
28014 Block of code given a TypeContainer and its ILGenerator.
28016 * statement.cs (Block): Standard public readonly optimization.
28017 (Block::Block constructors): Link children.
28018 (Block::Child): Child Linker.
28019 (Block::EmitVariables): Emits IL variable declarations.
28021 * class.cs: Drop support for MethodGroups here, delay until
28023 (Method::): Applied the same simplification that I did before, and
28024 move from Properties to public readonly fields.
28025 (Method::ParameterTypes): Returns the parameter types for the
28026 function, and implements a cache that will be useful later when I
28027 do error checking and the semantic analysis on the methods is
28029 (Constructor::GetCallingConvention): Renamed from CallingConvetion
28030 and made a method, optional argument tells whether this is a class
28031 or a structure to apply the `has-this' bit.
28032 (Method::GetCallingConvention): Implement, returns the calling
28034 (Method::Define): Defines the type, a second pass is performed
28035 later to populate the methods.
28037 (Constructor::ParameterTypes): implement a cache similar to the
28038 one on Method::ParameterTypes, useful later when we do semantic
28041 (TypeContainer::EmitMethod): New method. Emits methods.
28043 * expression.cs: Removed MethodGroup class from here.
28045 * parameter.cs (Parameters::GetCallingConvention): new method.
28047 2001-08-21 Miguel de Icaza <miguel@ximian.com>
28049 * class.cs (TypeContainer::Populate): Drop RootContext from the
28052 (Constructor::CallingConvention): Returns the calling convention.
28053 (Constructor::ParameterTypes): Returns the constructor parameter
28056 (TypeContainer::AddConstructor): Keep track of default constructor
28057 and the default static constructor.
28059 (Constructor::) Another class that starts using `public readonly'
28060 instead of properties.
28062 (Constructor::IsDefault): Whether this is a default constructor.
28064 (Field::) use readonly public fields instead of properties also.
28066 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
28067 track of static constructors; If none is used, turn on
28068 BeforeFieldInit in the TypeAttributes.
28070 * cs-parser.jay (opt_argument_list): now the return can be null
28071 for the cases where there are no arguments.
28073 (constructor_declarator): If there is no implicit `base' or
28074 `this', then invoke the default parent constructor.
28076 * modifiers.cs (MethodAttr): New static function maps a set of
28077 modifiers flags into a MethodAttributes enum
28078 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
28079 MethodAttr, TypeAttr to represent the various mappings where the
28080 modifiers are used.
28081 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
28083 2001-08-19 Miguel de Icaza <miguel@ximian.com>
28085 * parameter.cs (GetParameterInfo): Fix bug where there would be no
28088 * interface.cs (PopulateIndexer): Implemented the code generator
28089 for interface indexers.
28091 2001-08-17 Miguel de Icaza <miguel@ximian.com>
28093 * interface.cs (InterfaceMemberBase): Now we track the new status
28096 (PopulateProperty): Implement property population. Woohoo! Got
28097 Methods and Properties going today.
28099 Removed all the properties for interfaces, and replaced them with
28100 `public readonly' fields.
28102 2001-08-16 Miguel de Icaza <miguel@ximian.com>
28104 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
28105 initialize their hashtables/arraylists only when they are needed
28106 instead of doing this always.
28108 * parameter.cs: Handle refs and out parameters.
28110 * cs-parser.jay: Use an ArrayList to construct the arguments
28111 instead of the ParameterCollection, and then cast that to a
28114 * parameter.cs: Drop the use of ParameterCollection and use
28115 instead arrays of Parameters.
28117 (GetParameterInfo): Use the Type, not the Name when resolving
28120 2001-08-13 Miguel de Icaza <miguel@ximian.com>
28122 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
28123 and instead use public readonly fields.
28125 * class.cs: Put back walking code for type containers.
28127 2001-08-11 Miguel de Icaza <miguel@ximian.com>
28129 * class.cs (MakeConstant): Code to define constants.
28131 * rootcontext.cs (LookupType): New function. Used to locate types
28134 2001-08-08 Miguel de Icaza <miguel@ximian.com>
28136 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
28137 this System.Reflection code is. Kudos to Microsoft
28139 * typemanager.cs: Implement a type cache and avoid loading all
28140 types at boot time. Wrap in LookupType the internals. This made
28141 the compiler so much faster. Wow. I rule!
28143 * driver.cs: Make sure we always load mscorlib first (for
28144 debugging purposes, nothing really important).
28146 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
28147 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
28149 * rootcontext.cs: Lookup types on their namespace; Lookup types
28150 on namespaces that have been imported using the `using' keyword.
28152 * class.cs (TypeContainer::TypeAttr): Virtualize.
28153 (Class::TypeAttr): Return attributes suitable for this bad boy.
28154 (Struct::TypeAttr): ditto.
28155 Handle nested classes.
28156 (TypeContainer::) Remove all the type visiting code, it is now
28157 replaced with the rootcontext.cs code
28159 * rootcontext.cs (GetClassBases): Added support for structs.
28161 2001-08-06 Miguel de Icaza <miguel@ximian.com>
28163 * interface.cs, statement.cs, class.cs, parameter.cs,
28164 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
28165 Drop use of TypeRefs, and use strings instead.
28167 2001-08-04 Miguel de Icaza <miguel@ximian.com>
28171 * class.cs (Struct::Struct): set the SEALED flags after
28172 checking the modifiers.
28173 (TypeContainer::TypeAttr): new property, returns the
28174 TypeAttributes for a class.
28176 * cs-parser.jay (type_list): Oops, list production was creating a
28177 new list of base types.
28179 * rootcontext.cs (StdLib): New property.
28180 (GetInterfaceTypeByName): returns an interface by type name, and
28181 encapsulates error handling here.
28182 (GetInterfaces): simplified.
28183 (ResolveTree): Encapsulated all the tree resolution here.
28184 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
28187 * driver.cs: Add support for --nostdlib, to avoid loading the
28188 default assemblies.
28189 (Main): Do not put tree resolution here.
28191 * rootcontext.cs: Beginning of the class resolution.
28193 2001-08-03 Miguel de Icaza <miguel@ximian.com>
28195 * rootcontext.cs: Provide better error reporting.
28197 * cs-parser.jay (interface_base): set our $$ to be interfaces.
28199 * rootcontext.cs (CreateInterface): Handle the case where there
28200 are no parent interfaces.
28202 (CloseTypes): Routine to flush types at the end.
28203 (CreateInterface): Track types.
28204 (GetInterfaces): Returns an array of Types from the list of
28205 defined interfaces.
28207 * typemanager.c (AddUserType): Mechanism to track user types (puts
28208 the type on the global type hash, and allows us to close it at the
28211 2001-08-02 Miguel de Icaza <miguel@ximian.com>
28213 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
28214 RecordInterface instead.
28216 * cs-parser.jay: Updated to reflect changes above.
28218 * decl.cs (Definition): Keep track of the TypeBuilder type that
28219 represents this type here. Not sure we will use it in the long
28220 run, but wont hurt for now.
28222 * driver.cs: Smaller changes to accomodate the new code.
28224 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
28227 * rootcontext.cs (CreateInterface): New method, used to create
28228 the System.TypeBuilder type for interfaces.
28229 (ResolveInterfaces): new entry point to resolve the interface
28231 (CodeGen): Property, used to keep track of the code generator.
28233 2001-07-26 Miguel de Icaza <miguel@ximian.com>
28235 * cs-parser.jay: Add a second production for delegate_declaration
28238 (enum_body): Put an opt_comma here instead of putting it on
28239 enum_body or enum_member_declarations so we can handle trailing
28240 commas on enumeration members. Gets rid of a shift/reduce.
28242 (type_list): Need a COMMA in the middle.
28244 (indexer_declaration): Tell tokenizer to recognize get/set
28246 * Remove old targets.
28248 * Re-add the parser target.
28250 2001-07-13 Simon Cozens <simon@simon-cozens.org>
28252 * cs-parser.jay: Add precendence rules for a number of operators
28253 ot reduce the number of shift/reduce conflicts in the grammar.
28255 2001-07-17 Miguel de Icaza <miguel@ximian.com>
28257 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
28260 Get rid of old crufty code.
28262 * rootcontext.cs: Use this to keep track of the parsed
28263 representation and the defined types available to the program.
28265 * gen-treedump.cs: adjust for new convention.
28267 * type.cs: Split out the type manager, and the assembly builder
28270 * typemanager.cs: the type manager will live here now.
28272 * cil-codegen.cs: And the code generator here.
28274 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
28276 * makefile: Fixed up for easy making.
28278 2001-07-13 Simon Cozens <simon@simon-cozens.org>
28280 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
28283 (unary_expression): Expand pre_increment_expression and
28284 post_decrement_expression to reduce a shift/reduce.
28286 2001-07-11 Simon Cozens
28288 * cs-tokenizer.cs: Hex numbers should begin with a 0.
28290 Improve allow_keyword_as_indent name.
28292 2001-06-19 Miguel de Icaza <miguel@ximian.com>
28294 * Adjustments for Beta2.
28296 2001-06-13 Miguel de Icaza <miguel@ximian.com>
28298 * decl.cs: Added `Define' abstract method.
28299 (InTransit): new property, used to catch recursive definitions.
28301 * interface.cs: Implement `Define'.
28303 * modifiers.cs: Map Modifiers.constants to
28304 System.Reflection.TypeAttribute flags.
28306 * class.cs: Keep track of types and user-defined types.
28307 (BuilderInit): New method for creating an assembly
28308 (ResolveType): New function to launch the resolution process, only
28309 used by interfaces for now.
28311 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
28312 that are inserted into the name space.
28314 2001-06-08 Miguel de Icaza <miguel@ximian.com>
28316 * ARGH. I have screwed up my tree so many times due to the use of
28317 rsync rather than using CVS. Going to fix this at once.
28319 * driver.cs: Objetify driver. Load assemblies, use assemblies to
28322 2001-06-07 Miguel de Icaza <miguel@ximian.com>
28324 * Experiment successful: Use System.Type rather that our own
28327 2001-05-25 Miguel de Icaza <miguel@ximian.com>
28329 * cs-parser.jay: Removed nsAliases from here.
28331 Use new namespaces, handle `using XXX;'
28333 * namespace.cs: Reimplemented namespace handling, use a recursive
28334 definition of the class. Now we can keep track of using clauses
28335 and catch invalid using clauses.
28337 2001-05-24 Miguel de Icaza <miguel@ximian.com>
28339 * gen-treedump.cs: Adapted for all the renaming.
28341 * expression.cs (Expression): this class now has a Type property
28342 which returns an expression Type.
28344 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
28345 `Type', as this has a different meaning now in the base
28347 2001-05-22 Miguel de Icaza <miguel@ximian.com>
28349 * interface.cs, class.cs: Removed from all the sources the
28350 references to signature computation, as we can not do method
28351 signature computation during the parsing time, as we are not
28352 trying to solve at that point distinguishing:
28356 void a (NS.Blah x) {}
28359 Which depending on the context might be valid or not, as we do not
28360 know if Blah is the same thing as NS.Blah at that point.
28362 * Redid everything so the code uses TypeRefs now instead of
28363 Types. TypeRefs are just temporary type placeholders, that need
28364 to be resolved. They initially have a pointer to a string and the
28365 current scope in which they are used. This is used later by the
28366 compiler to resolve the reference to an actual Type.
28368 * DeclSpace is no longer a CIR.Type, and neither are
28369 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
28370 are all DeclSpaces, but no Types.
28372 * type.cs (TypeRefManager): This implements the TypeRef manager,
28373 which keeps track of all the types that need to be resolved after
28374 the parsing has finished.
28376 2001-05-13 Miguel de Icaza <miguel@ximian.com>
28378 * ARGH. We are going to have to store `foreach' as a class rather
28379 than resolving it, as we need to verify error 1579 after name
28380 resolution. *OR* we could keep a flag that says `This request to
28381 IEnumerator comes from a foreach statement' which we can then use
28382 to generate the error.
28384 2001-05-10 Miguel de Icaza <miguel@ximian.com>
28386 * class.cs (TypeContainer.AddMethod): we now add methods to the
28387 MethodGroup instead of the method hashtable.
28389 * expression.cs: Add MethodGroup abstraction, which gets us one
28390 step closer to the specification in the way we handle method
28393 * cs-parser.jay (primary_expression): qualified_identifier now
28394 tried to match up an identifier to a local variable reference or
28395 to a parameter reference.
28397 current_local_parameters is now a parser global variable that
28398 points to the current parameters for the block, used during name
28401 (property_declaration): Now creates an implicit `value' argument to
28404 2001-05-09 Miguel de Icaza <miguel@ximian.com>
28406 * parameter.cs: Do not use `param' arguments as part of the
28407 signature, per the spec.
28409 2001-05-08 Miguel de Icaza <miguel@ximian.com>
28411 * decl.cs: Base class for classes, structs and interfaces. This
28412 is the "Declaration Space"
28414 * cs-parser.jay: Use CheckDef for checking declaration errors
28415 instead of having one on each function.
28417 * class.cs: Factor out some code for handling error handling in
28418 accordance to the "Declarations" section in the "Basic Concepts"
28419 chapter in the ECMA C# spec.
28421 * interface.cs: Make all interface member classes derive from
28422 InterfaceMemberBase.
28424 2001-05-07 Miguel de Icaza <miguel@ximian.com>
28426 * Many things: all interfaces are parsed and generated in
28427 gen-treedump. Support for member variables, constructors,
28428 destructors, properties, constants is there.
28430 Beginning of the IL backend, but very little done, just there for
28433 2001-04-29 Miguel de Icaza <miguel@ximian.com>
28435 * cs-parser.jay: Fix labeled statement.
28437 * cs-tokenizer.cs (escape): Escape " and ' always.
28438 ref_line, ref_name: keep track of the line/filename as instructed
28439 by #line by the compiler.
28442 2001-04-27 Miguel de Icaza <miguel@ximian.com>
28444 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
28445 to match the values in System.CodeDOM.
28447 Divid renamed to Divide.
28449 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
28451 (Statements.set): remove.
28453 * System.CodeDOM/CodeCatchClause.cs: always have a valid
28456 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
28457 falseStatements always have valid values.
28459 * cs-parser.jay: Use System.CodeDOM now.