1 2008-05-01 Marek Safar <marek.safar@gmail.com>
3 * constant.cs, literal.cs: IsLiteral property for error reporting.
5 * ecore.cs, expression.cs: Implemented Property expression.
7 2008-05-01 Marek Safar <marek.safar@gmail.com>
9 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
11 * nullable.cs: Implemented nullable coalescing null operator.
13 * ecore.cs, expression.cs: Expression trees work.
15 2008-05-01 Marek Safar <marek.safar@gmail.com>
17 * ecore.cs: CreateExpressionTree is finally abstract.
19 * expression.cs, linq.cs: Updated.
21 2008-05-01 Marek Safar <marek.safar@gmail.com>
23 * expression.cs, ecore.cs: Block base access expression inside expression
26 2008-05-01 Marek Safar <marek.safar@gmail.com>
29 * expression.cs: User-defined operator implementations always take
30 precedence over predefined operator implementations.
32 2008-04-30 Marek Safar <marek.safar@gmail.com>
34 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
35 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
36 expression tree conversions.
38 2008-04-30 Marek Safar <marek.safar@gmail.com>
40 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
41 operators method details to Operator class.
43 2008-04-30 Marek Safar <marek.safar@gmail.com>
45 * anonymous.cs: Pass unsafe flags to anonymous container.
47 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
48 inside expression tree.
50 2008-04-29 Martin Baulig <martin@ximian.com>
52 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
53 (Tokenizer.PopPosition): Also restore the `line'.
55 2008-04-29 Marek Safar <marek.safar@gmail.com>
57 * delegate.cs: Implemented Invoke expression.
59 2008-04-29 Marek Safar <marek.safar@gmail.com>
61 * expression.cs: Fixed equality reference comparison regression.
63 2008-04-29 Marek Safar <marek.safar@gmail.com>
65 * ecore.cs: Clean up EmptyCast hack.
67 * expression.cs, nullable.cs: Implemented enum binary and unary operations
68 using correct conversion rules. Also fixes #383993.
70 2008-04-28 Martin Baulig <martin@ximian.com>
72 * class.cs (Constructor.Emit): Don't emit debugging information
73 for generated default .ctor's.
75 2008-04-28 Marek Safar <marek.safar@gmail.com>
77 * convert.cs: Empty-cast ushort to int conversion.
79 2008-04-28 Marek Safar <marek.safar@gmail.com>
82 * ecore.cs, expression.cs: Fixed expression cloning.
84 2008-04-28 Marek Safar <marek.safar@gmail.com>
86 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
88 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
90 Fix #381559, test-638.cs, test-639.cs
91 * assign.cs (CompoundAssign.Helper): New wrapper.
92 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
94 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
95 Pass unconverted expressions to the params array creation expression.
96 (FieldExpr.EmitAssign): Don't special-case StringConcat.
97 (PropertyExpr.EmitAssign): Likewise.
98 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
99 element if it is of kind CompoundAssign.Helper.
100 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
101 first before anything else.
102 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
103 (ArrayAccess.LoadArrayAndArguments): Simplify.
105 2008-04-27 Marek Safar <marek.safar@gmail.com>
107 * expression.cs: Fixed cloning of typeof(void).
109 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
111 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
112 (Assign.Emit): Likewise. Move it to ...
113 (CompoundAssign.DoResolve): ... here and ...
114 (CompoundAssign.Emit): ... here.
115 (EventAddOrRemove): New helper to handle += and -= on events, and
116 avoid the use of BinaryDelegates.
117 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
118 (EventExpr.EmitAddOrRemove): Improve.
119 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
121 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
122 create VarExprs for 'foo.bar.var'.
123 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
124 is a highly inappropriate name for its functionality.
126 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
128 Simplify handling of multiple assignments
129 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
131 (SimpleAssign): New. Class to be used for normal assignments.
132 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
133 * expression.cs, parameter.cs, statement.cs: Likewise.
135 2008-04-25 Marek Safar <marek.safar@gmail.com>
137 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
138 for incompatible underlying types, more to come, uff.
140 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
143 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
146 2008-04-25 Marek Safar <marek.safar@gmail.com>
148 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
150 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
152 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
153 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
154 * statement.cs (While, Do, For): Allow test to have side effects.
155 (For.DoEmit): Always emit InitStatement.
158 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
159 Always create SideEffectConstant.
160 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
161 of type EnumConstant.
163 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
164 Handle 'right' being SideEffectConstant of type 'bool'.
166 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
167 Use left.EmitBranchable instead of open coding it, so as to
168 improve optimization opportunities.
170 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
172 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
174 (Expression.EmitSideEffect): Document.
176 2008-04-23 Marek Safar <marek.safar@gmail.com>
178 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
180 2008-04-23 Marek Safar <marek.safar@gmail.com>
182 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
184 2008-04-23 Marek Safar <marek.safar@gmail.com>
186 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
187 conversion to expression tree.
189 2008-04-23 Marek Safar <marek.safar@gmail.com>
191 * ecore.cs: Removed unused expression.
193 2008-04-22 Marek Safar <marek.safar@gmail.com>
195 * expression.cs: Implemented NegateChecked and New expressions.
197 2008-04-22 Marek Safar <marek.safar@gmail.com>
199 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
201 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
204 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
205 needing final 'ret' instruction.
207 2008-04-22 Marek Safar <marek.safar@gmail.com>
209 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
211 2008-04-21 Marek Safar <marek.safar@gmail.com>
213 * expression.cs: Emit ldnull and not null expression as an instance argument
214 of static method expression calls.
216 2008-04-21 Marek Safar <marek.safar@gmail.com>
218 A fix for bug #378200
219 * expression.cs: Fixed crash when creating parameterless expression tree
222 2008-04-21 Marek Safar <marek.safar@gmail.com>
224 A fix for bug #375297
225 * anonymous.cs: Fixed crash when inferring from null argument anonymous
228 2008-04-21 Marek Safar <marek.safar@gmail.com>
230 A fix for bug #377596
231 * decl.cs, class.cs: Emit delegate type argument attributes.
233 2008-04-21 Marek Safar <marek.safar@gmail.com>
235 A fix for bug #365314
236 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
238 2008-04-21 Marek Safar <marek.safar@gmail.com>
240 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
243 2008-04-21 Marek Safar <marek.safar@gmail.com>
245 * generic.cs (TypeParameter): Removed redundant location.
247 2008-04-19 Marek Safar <marek.safar@gmail.com>
249 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
250 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
251 FullNamedExpression in all declaration type expression, statements will come
254 2008-04-18 Marek Safar <marek.safar@gmail.com>
256 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
257 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
259 2008-04-18 Marek Safar <marek.safar@gmail.com>
261 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
264 2008-04-17 Marek Safar <marek.safar@gmail.com>
266 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
269 2008-04-17 Marek Safar <marek.safar@gmail.com>
271 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
275 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
277 Hook up 'EmitSideEffect'
278 * constant.cs (Constant.EmitSideEffect): New.
279 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
280 (SideEffectConstant.EmitSideEffect): New.
281 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
282 unconditional branch in EmitBranchable.
283 (FieldExpr.EmitBranchable): New.
284 * expression.cs (Unary.EmitSideEffect): New.
285 (Binary.EmitSideEffect): New.
286 (VariableReference.EmitSideEffect): New. Do nothing.
288 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
290 Introduce 'EmitSideEffect'
291 * ecore.cs (Expression.EmitSideEffect): New.
292 (TypeCast): Rename from EmptyCast.
294 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
295 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
296 * convert.cs, nullable.cs: Update to changes.
298 2008-04-16 Marek Safar <marek.safar@gmail.com>
300 * class.cs, cs-parser.jay: Early check for base types expression.
302 2008-04-16 Marek Safar <marek.safar@gmail.com>
304 * decl.cs (MemberName): Declare PrettyName as obsolete.
306 2008-04-16 Marek Safar <marek.safar@gmail.com>
308 * namespace.cs: Use MemberName comparison.
310 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
313 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
315 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
316 (MemberName.FullyQualifiedName): New. Provides the functionality
317 that users assume FullName would have.
318 * ecore.cs, namespace.cs: Update to changes.
320 * statement.cs (Using.assign): Make into ExpressionStatement.
321 (Using.EmitPreTryBody): Simplify.
323 2008-04-16 Marek Safar <marek.safar@gmail.com>
325 * report.cs: ColorFormat is protected.
327 * rootcontext.cs: Unused fields clean-up.
329 * namespace.cs: Made UsingEntry name private.
331 2008-04-16 Marek Safar <marek.safar@gmail.com>
333 * cs-tokenizer.cs, location.cs: Removed unused field.
335 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
336 Raja R Harinath <harinath@hurrynot.org>
339 * constant.cs (SideEffectConstant.value): Rename from 'left'.
340 (SideEffectConstant.side_effect): Rename from 'right'.
341 (SideEffectConstant..ctor): Normalize 'side_effect'.
342 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
343 value of this constant.
344 * cfold.cs: Update to changes.
346 2008-04-15 Marek Safar <marek.safar@gmail.com>
348 * cs-paser.jay: Removed unused variable.
350 * driver.cs: Made Compile instance method.
352 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
354 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
356 2008-04-15 Marek Safar <marek.safar@gmail.com>
358 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
360 2008-04-13 Jb Evain <jbevain@novell.com>
362 * namespace.cs: update the System.Core fullname for 2.1
363 * driver.cs: update the list of required assemblies for 2.1.
364 Merged from the Moonlight 2 branch.
366 2008-04-11 Marek Safar <marek.safar@gmail.com>
368 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
369 types and user defined operators. User operators arguments has to be checked
370 for null value before invocation, which also means no operator is called
371 when any argument is not convertible to unwrapped nullable type.
373 2008-04-09 Marek Safar <marek.safar@gmail.com>
375 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
376 of Unary expressions to follow operator overloading rules precisely.
377 Also fixes #321794, #323794
379 2008-04-08 Marek Safar <marek.safar@gmail.com>
381 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
384 2008-04-08 Marek Safar <marek.safar@gmail.com>
386 * expression.cs, ecore.cs: Implemented MemberInit expression.
388 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
390 Fix mono/tests/exception4.cs
391 * statement.cs (ExceptionStatement, TryCatch): Revert to using
392 ec.NeedReturnLabel () rather emitting a 'nop'.
394 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
396 (TryCatch.SomeCodeFollows): Likewise.
397 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
398 for 'break', 'continue' and 'return' statements inside a try.
399 We're fairly sure that the generated IL stream will have more
400 instructions textually following the try.
401 (FlowBranchingTryCatch): Likewise.
403 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
404 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
407 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
408 wrapper -- forward everything to CollectionForeach.
409 (CollectionForeach.NonDisposableWrapper): New.
410 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
411 instead of a pop + branch to end.
413 2008-04-07 Marek Safar <marek.safar@gmail.com>
415 A fix for bug #377485
416 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
417 Propagate location for extension method groups. Report conversion failure at
420 2008-04-07 Marek Safar <marek.safar@gmail.com>
422 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
423 ListInit and Field expressions.
425 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
427 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
428 Since $PC is always -1 inside the body of MoveNext, the fault
430 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
431 * statement.cs (ExceptionStatement.emit_finally): Likewise.
432 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
434 The denouement! Fix #324708
435 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
436 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
437 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
438 'finally' inside the finally clause.
440 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
441 inside an iterator. Don't emit the body of the 'finally' inside
442 the finally clause yet.
444 Use the ResumableStatement infrastructure for MoveNext ()
445 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
446 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
447 'old_resume_points'. Move dispatcher upfront.
448 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
449 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
450 in an enumerator. This encodes the main fix in this patch series
451 -- we can only jump into the first instruction of a try from the
452 outside, but we want to emit try/finally regions in iterators and
453 resume in the middle of them.
455 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
457 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
458 of NeedReturnLabel here.
460 Introduce a common point for emitting try/finally to IL
461 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
462 features of the various subclasses, which are now driven by ...
463 (ExceptionStatement.EmitPreTryBody): ... this and ...
464 (ExceptionStatement.EmitTryBody): ... this and the original
466 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
467 Remove DoEmit and update to follow above protocol.
469 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
470 of the dispatcher are the same, skip emitting the 'switch'.
471 * iterator.cs (Iterator.EmitDispose): Update to changes.
473 Clean up handling of 'using' statement
474 * statement.cs (UsingTemporary): New. Carved out of ...
475 (Using): ... this. Simplify drastically. Handle exactly
477 * cs-parser.jay (using_statement): Split. Create UsingTemporary
478 or Using as appropriate. If there are multiple variable declared,
479 create nested Using statements.
480 (resource_acquisition): Kill.
482 * statement.cs (ExceptionStatement.EmitForDispose): Use
483 EmitFinallyBody, not EmitFinally.
485 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
486 * iterator.cs: Update to changes.
488 Start using the ResumableStatement infrastructure
489 * statement.cs (ResumeableStatement.PrepareForDispose): New.
490 (ResumableStatement.EmitForDispose): New.
491 (ExceptionStatement): Override them.
492 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
493 EmitForDispose to create the body of the Dispose method. Don't
496 * iterator.cs (Iterator.AddResumePoint): Move here from ...
497 * statement.cs (Toplevel.AddResumePoint): ... here.
498 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
499 * flowanalysis.cs (FlowBranchingIterator): New.
500 * codegen.cs (EmitContext): Update to changes.
502 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
503 (Iterator.old_resume_points): Rename from 'resume_points'.
504 (Iterator.MoveNextStatement): Remove unused class.
506 New infrastructure for try/finally in iterators (still unused)
507 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
508 (FlowBranchingToplevel.AddResumePoint): Hook into
509 ToplevelBlock.AddResumePoint.
510 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
511 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
512 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
513 resume points and assign program-counter values.
514 (ExceptionBlock.AddResumePoint): Collect resume points for
515 de-muxer at the top of try block.
516 * iterators.cs (Yield.CheckContext): Simplify.
517 (Yield.Resolve): Use FlowBranching.AddResumePoint.
519 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
521 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
522 argument to an ExitStatement.
523 (FlowBranchingException): Refactor saved origins code.
524 * statement.cs (ExitStatement): Update to cahges.
525 * iterator.cs (YieldBreak): Likewise.
527 * statement.cs (ResumableStatement): New. Common base class for
528 YieldReturn and ExceptionStatement.
529 (ExitStatement): New. Common base class for Return and YieldBreak.
530 (Return): Update to changes.
531 * iterator.cs (YieldBreak): Likewise.
532 * lambda.cs (ContextualReturn): Likewise.
535 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
536 emit a meaningful error message.
539 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
540 (VariableInfo.SetAssigned): Set it.
541 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
542 determine if CS0219 or CS0168 is appropriate. Don't use
543 flow-analysis information.
544 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
545 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
546 (EmitContext.EndFlowBranching): ... this.
548 2008-04-03 Marek Safar <marek.safar@gmail.com>
550 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
552 2008-04-03 Marek Safar <marek.safar@gmail.com>
554 A fix for bug #376508
555 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
556 ImplicitConversionExists.
558 2008-04-03 Marek Safar <marek.safar@gmail.com>
560 * expression.cs (Binary): Added remaining binary operators to expression
563 * nullable.cs: Optimize shift with null argument.
565 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
567 Fix minor IL regression
568 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
569 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
570 * cs-parser.jay (try_statement): Update to changes.
572 * statement.cs (TryFinally.need_exc_block): Delete.
573 (TryFinally): Update to changes.
575 Now all ExceptionStatements are unconditional
576 * statement.cs (CollectionForeach.DisposableWrapper): New.
577 Extract out the try/finally code into a new wrapper.
578 (CollectionForeach.Resolve): Use it to simplify the code.
580 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
582 Start at simplifying ExceptionStatement semantics a bit
583 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
584 * cs-parser.jay (try_statement): Update to changes.
585 (opt_catch_clauses): Remove.
586 * flowanalysis.cs: Update to changes.
587 (FlowBranching.BranchingType.TryCatch): New.
588 (FlowBranchingTryCatch): New.
590 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
591 (FlowBranching.CreateBranching): Update to changes.
592 (FlowBranchingBlock.AddSibling): Add sanity check.
593 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
596 * iterators.cs (Iterator.MarkFinally): Remove.
597 * statement.cs (ExceptionStatement): Update to changes.
599 Add support for skipping over finally blocks at runtime. First
600 in a series to fix #324708
601 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
602 (Iterator.EmitMoveNext): Initialize it.
603 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
604 branch over the body of the 'finally' clause.
606 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
608 Avoid lopsided use of Foo/DoFoo names
609 * statement.cs (ExpressionStatement.EmitFinallyBody):
610 Rename from EmitFinally.
611 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
612 * iterator.cs: Update to changes.
614 2008-04-02 Marek Safar <marek.safar@gmail.com>
616 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
617 based on UserOperatorCall. More binary nullable operators clean up.
619 2008-04-02 Martin Baulig <martin@ximian.com>
621 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
623 2008-04-02 Marek Safar <marek.safar@gmail.com>
625 * nullable.cs: Merge user and empty conversions when lifting expression
628 * expression.cs (StringConcat): Implemented expression tree representation.
630 2008-04-01 Marek Safar <marek.safar@gmail.com>
632 * nullable.cs: When lifting null literal and a user operator exists, no call
635 2008-04-01 Marek Safar <marek.safar@gmail.com>
637 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
640 2008-04-01 Marek Safar <marek.safar@gmail.com>
642 * nullable.cs, expression.cs: Use namespace instead heavily nested
643 monster abstract class.
645 2008-04-01 Marek Safar <marek.safar@gmail.com>
647 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
648 lifting of null literal and user operators. Clean up of some temporary
651 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
653 Fix #368224, test-629.cs
654 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
655 if it crossed an unwind-protect boundary.
656 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
657 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
658 inside an unwind-protected region.
659 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
660 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
661 'leave' instead of a 'br' if unwind-protected.
662 (Iterator.EmitYieldBreak): Likewise.
664 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
666 * driver.cs: Only define versioninfo resources if no win32 resource
669 2008-03-28 Marek Safar <marek.safar@gmail.com>
671 A fix for bug #372375
672 * convert.cs: Fixed boxing of nullable types.
674 2008-03-28 Marek Safar <marek.safar@gmail.com>
676 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
679 2008-03-28 Marek Safar <marek.safar@gmail.com>
681 A fix for bug #374619
682 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
684 2008-03-27 Marek Safar <marek.safar@gmail.com>
686 * lambda.cs: Check return type only for invocation.
688 2008-03-27 Marek Safar <marek.safar@gmail.com>
690 A fix for bug #374214
691 * ecore.cs: Correctly report argument type mismatch.
693 2008-03-27 Marek Safar <marek.safar@gmail.com>
695 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
696 and not rely on broken IsEnum.
698 2008-03-27 Marek Safar <marek.safar@gmail.com>
700 * nullable.cs: New file, extracted from generic.cs.
702 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
704 2008-03-27 Marek Safar <marek.safar@gmail.com>
706 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
707 predefined comparison operators and null literals.
709 * report.cs: New warning ID.
711 2008-03-25 Marek Safar <marek.safar@gmail.com>
713 A fix for bug #370577
714 * lambda.cs: Check return type too.
716 2008-03-25 Marek Safar <marek.safar@gmail.com>
718 A fix for bug #372846
719 * class.cs: Automatic properties can be declared as unsafe.
721 2008-03-20 Marek Safar <marek.safar@gmail.com>
723 * location.cs: Use string based concatenation.
725 * expression.cs: LiftedBinaryOperator is gmcs only.
727 2008-03-20 Marek Safar <marek.safar@gmail.com>
729 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
730 conversions rules and expression trees.
732 2008-03-19 Marek Safar <marek.safar@gmail.com>
734 * delegate.cs: Use extension method source as delegate target.
736 2008-03-19 Marek Safar <marek.safar@gmail.com>
738 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
739 binary operations to be purely based on binary operations and optimized
740 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
741 and other ET refactoring.
743 * typemanager.cs: Fixed warning.
745 2008-03-17 Marek Safar <marek.safar@gmail.com>
747 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
749 * symbolwriter.cs: Fixed.
751 2008-03-17 Marek Safar <marek.safar@gmail.com>
753 * anonymous.cs, driver.cs: Reset anonymous types counters.
755 2008-03-17 Marek Safar <marek.safar@gmail.com>
757 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
759 * class.cs: Use fullname for all type member definitions.
761 2008-02-19 Martin Baulig <martin@ximian.com>
764 (IMethodData.EmitExtraSymbolInfo): New interface method.
765 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
766 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
767 interface method here as an empty public virtual method.
770 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
771 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
772 CodeGen.SymbolWriter.SetRealMethodName().
774 2008-02-18 Martin Baulig <martin@ximian.com>
777 (ScopeInfo.EmitType): Override this and emit debugging
778 information for captured variables.
779 (RootScopeInfo.EmitType): Override this and emit symbol
780 information for a captured `this'.
782 2008-02-15 Martin Baulig <martin@ximian.com>
784 * iterators.cs: Emit debugging info.
787 (EmitContext.Flags): Add `OmitDebuggingInfo'.
788 (EmitContext.OmitDebuggingInfo): New public property.
791 (While): Override Emit() and don't emit symbol info there; do it
792 inside DoEmit() instead.
793 (Block.Emit): Omit symbol information while emitting the scope
794 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
796 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
797 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
798 .ctor to make `IsIterator' work.
800 2008-03-14 Martin Baulig <martin@ximian.com>
802 * symbolwriter.cs: Added the new symbol writer function from the
803 debugger's `terrania' branch; temporarily enclose them inside
804 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
807 2008-03-14 Martin Baulig <martin@ximian.com>
810 (SymbolWriter): Make this a public static class.
813 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
814 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
816 2008-03-14 Marek Safar <marek.safar@gmail.com>
818 A fix for bug #370577
819 * statement.cs, lambda.cs: Added extra limitations when dealing with void
822 2008-03-14 Marek Safar <marek.safar@gmail.com>
824 * typemanager.cs (CSharpName): Made 250 times faster.
826 2008-03-13 Marek Safar <marek.safar@gmail.com>
828 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
830 2008-03-12 Marek Safar <marek.safar@gmail.com>
832 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
833 crash when predefined field does not exist.
835 2008-03-12 Marek Safar <marek.safar@gmail.com>
837 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
839 2008-03-12 Marek Safar <marek.safar@gmail.com>
841 * class.cs (FixedField): Don't crash when contructors are missing.
843 2008-03-11 Marek Safar <marek.safar@gmail.com>
845 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
846 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
847 check internal types accessibility for internal and external types.
848 Replaced EnumToUnderlying by GetEnumUnderlyingType.
850 2008-03-11 Marek Safar <marek.safar@gmail.com>
852 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
853 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
854 attribute.cs, statement: Use corect instance of predefined types (work
857 2008-03-07 Marek Safar <marek.safar@gmail.com>
859 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
861 2008-03-07 Marek Safar <marek.safar@gmail.com>
863 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
864 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
865 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
866 predefined types clean up, delayed predefined types members initialization
867 (work related to #364674).
869 2008-03-05 Marek Safar <marek.safar@gmail.com>
871 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
873 2008-03-05 Marek Safar <marek.safar@gmail.com>
875 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
876 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
877 predefined types clean up (work related to #364674).
879 2008-03-04 Marek Safar <marek.safar@gmail.com>
881 * ecore.cs: Print an error message instead of throwing exception.
883 2008-03-04 Marek Safar <marek.safar@gmail.com>
885 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
886 expression.cs, statement.cs: Unififed null literal representation.
888 2008-03-03 Marek Safar <marek.safar@gmail.com>
890 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
891 expression.cs: Refactored binary operators resolve phase and improved speed.
892 The nullable code is still missing and won't work correctly, more fixes
895 It also fixes #323726, #324312, #324248, and many other unreported issues.
897 2008-02-29 Zoltan Varga <vargaz@gmail.com>
899 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
902 2008-02-27 Marek Safar <marek.safar@gmail.com>
904 * ecore.cs: Clean-up and split BetterConversion.
906 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
909 * enum.cs (EnumMember.Value): Only access 'value' if
910 ResolveValue says it's ok.
911 (EnumMember.DoResolveValue): Don't set prev_member.value.
912 (Enum.GetDefinition): Reverse arguments of Equals --
913 EnumMember.Value can return 'null'.
915 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
917 2008-02-22 Marek Safar <marek.safar@gmail.com>
919 * generic.cs, expression.cs: More ongoing work on expression trees.
921 2008-02-21 Marek Safar <marek.safar@gmail.com>
923 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
924 handle missing matches when mutiple operators exist.
926 2008-02-20 Marek Safar <marek.safar@gmail.com>
928 A fix for bug #363218
929 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
932 2008-02-20 Marek Safar <marek.safar@gmail.com>
934 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
935 update. This time to deal correctly with SideEffectConstant expression used
936 as an argument for another constant folding.
938 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
940 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
943 2008-02-19 Marek Safar <marek.safar@gmail.com>
945 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
947 2008-02-19 Marek Safar <marek.safar@gmail.com>
949 A fix for bug #328136
950 * expression.cs: Do not fold immediately LogicalAnd operators when the left
951 side is a false constant, because we still need to evaluate the right-hand
954 * statement.cs (If): Emit two types of boolean constants (simple constant,
955 side-effect constant).
957 2008-02-19 Marek Safar <marek.safar@gmail.com>
959 * constant.cs (SideEffectConstant): Don't emit boolean constant.
961 * expression.cs: Fold immediately LogicalAnd operators when both sides are
964 2008-02-18 Marek Safar <marek.safar@gmail.com>
966 A fix for bug #361457
967 * ecore.cs (IsApplicable): Params methods have lower priority.
969 * support.cs: Return correct parameter modifier for params types.
971 2008-02-18 Marek Safar <marek.safar@gmail.com>
973 * generic.cs (TypeParameter): Cache attribute target name.
975 * support.cs: Removed unused variable.
977 * typemanager.cs: Removed debugging leftover.
979 * ecore.cs: Use local type instead of a property;
981 * class.cs (VerifyMembers): Consider also parent to test whether type member
984 * expression.cs (FullMethodDesc): Removed.
986 * attribute.cs (IsValidArgumentType): Made static.
988 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
990 Cleanup to be more readable.
991 * Makefile (GMCS_PROFILE): Remove.
992 (COMPILER_NAME): New helper.
994 2008-02-15 Miguel de Icaza <miguel@novell.com>
996 * cs-tokenizer.cs: if a conditional expression happens inside a
997 (...) this also means that we do not need to de-ambiguate between
998 an parenthesized expression and a cast.
1002 * constant.cs (SideEffectConstant): a constant value that happens
1003 to have a side effect.
1005 Fixes the build regressions introduced by the fix for #359789
1007 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
1009 * expression.cs (Conditional.Emit): when emitting the ternary
1010 operator, use local variables to generate code verifiable code.
1012 The verifier cannot infer that the type on stack before the
1013 stloc.0 is executed is of type ParentB. This happens because the
1014 stack merge algorithm uses only parent types when deciding which
1015 is the common type. This is described in Part III 1.8.1.3 of ECMA
1018 This code compiled with mcs is not verifiable under MS. The MS
1019 verifier picks the first common interface of Foo and Bar, which is
1020 wrong, but doesn't use a full join type of the 2 interfaces.
1022 CSC uses a clever hack to compile such code in a verifiable
1023 way. It stores the intermediate values in a local variable with
1028 2008-02-14 Miguel de Icaza <miguel@novell.com>
1030 * expression.cs: Do not fold BitwiseAnd operators when the left
1031 side is a false constant, because we still need to evaluate the
1036 * support.cs: Instead of throwing an InternalErrorException when
1037 the position of the stream is outside the boundary of our buffer,
1038 reset the state of the reader, and restart the reading from the
1039 beginning of the file.
1041 2008-02-14 Marek Safar <marek.safar@gmail.com>
1043 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
1045 2008-02-14 Marek Safar <marek.safar@gmail.com>
1047 A fix for bug #361686
1048 * decl.cs: A protected types used inside a private class which parents
1049 derives from the protected class are accessible.
1051 2008-02-13 Marek Safar <marek.safar@gmail.com>
1053 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
1054 the parameterless constructor.
1056 2008-02-13 Marek Safar <marek.safar@gmail.com>
1058 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
1059 lookup methods to use standard member cache when doing member lookup.
1061 2008-02-12 Marek Safar <marek.safar@gmail.com>
1063 * driver.cs: Don't report full path for referenced module as assembly error.
1065 2008-02-12 Marek Safar <marek.safar@gmail.com>
1067 * Makefile: Fixed `qh' target to work on all machines.
1069 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
1070 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
1071 and HasElementType with TypeManager implementation.
1073 2008-02-08 Marek Safar <marek.safar@gmail.com>
1075 A fix for bugs #325134, #359749
1076 * expression.cs, ecore.cs: Try to resolve an extension method even if the
1077 first binds point to non-method member expression.
1079 2008-02-08 Marek Safar <marek.safar@gmail.com>
1081 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
1083 2008-02-08 Marek Safar <marek.safar@gmail.com>
1085 A fix for bugs #321394, #323028
1086 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
1087 Reworked naive IsAccessibleAs implementation to handle nested types.
1089 2008-02-05 Jb Evain <jbevain@novell.com>
1091 * class.cs: use generic type comparison for parameters
1094 2008-02-05 Marek Safar <marek.safar@gmail.com>
1096 A fix for bug #325372
1097 * class.cs: Use generic type comparison when testing method signatures.
1099 2008-02-05 Marek Safar <marek.safar@gmail.com>
1101 A fix for bug #357047
1102 * ecore.cs: Applied C# 3.0 changes to better conversion.
1104 2008-02-05 Marek Safar <marek.safar@gmail.com>
1106 A fix for bug #358374
1107 * cs-parser.jay: Correctly set modifiers for all constructor types.
1109 2008-02-04 Marek Safar <marek.safar@gmail.com>
1111 A fix for bug #355251
1112 * generic.cs: Added base class constraint based type inference.
1114 2008-02-01 Marek Safar <marek.safar@gmail.com>
1116 A fix for bug #357255
1117 * decl.cs: One more missing visibility check.
1119 2008-02-01 Marek Safar <marek.safar@gmail.com>
1121 * support.cs: Fixed broken return.
1123 2008-01-25 Marek Safar <marek.safar@gmail.com>
1125 * report.cs: Correctly reset warnings count after probing.
1127 2008-01-25 Martin Baulig <martin@ximian.com>
1130 (NamespaceEntry.SymbolFileID): Make this work again after
1131 MemberName.ToString() is gone.
1133 2008-01-25 Marek Safar <marek.safar@gmail.com>
1135 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
1138 2008-01-25 Marek Safar <marek.safar@gmail.com>
1140 * generic.cs: Use full implicit conversion for type inference fixing.
1142 2008-01-24 Marek Safar <marek.safar@gmail.com>
1144 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
1145 Fixed user operator conversions.
1147 2008-01-24 Marek Safar <marek.safar@gmail.com>
1149 * generic.cs: Do nullable type to null comparison optimization during
1152 2008-01-24 Marek Safar <marek.safar@gmail.com>
1154 A fix for bug #355163
1155 * generic.cs: Enabled l-value resolve on nullable expressions.
1157 2008-01-24 Marek Safar <marek.safar@gmail.com>
1159 A fix for bug #353986
1160 * class.cs: Ingore static ctors with parameters for any further checks.
1162 2008-01-24 Marek Safar <marek.safar@gmail.com>
1164 A fix for bug #354310
1165 * namespace.cs: Removed redundant check.
1167 2008-01-24 Marek Safar <marek.safar@gmail.com>
1169 A fix for bug #354928
1170 * expression.cs: ElementInitializers can be resolved only once.
1172 2008-01-24 Marek Safar <marek.safar@gmail.com>
1174 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
1175 Condition expressions.
1177 2008-01-23 Marek Safar <marek.safar@gmail.com>
1179 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
1181 2008-01-22 Marek Safar <marek.safar@gmail.com>
1183 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
1186 * generic.cs: Implemented coalesce expression.
1188 2008-01-22 Marek Safar <marek.safar@gmail.com>
1190 A fix for bug #355145
1191 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
1192 expression tree type inference.
1194 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
1197 * expression.cs (Binary.IsUnsignedType): Fix typo.
1199 2008-01-22 Marek Safar <marek.safar@gmail.com>
1201 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
1203 2008-01-22 Marek Safar <marek.safar@gmail.com>
1205 A fix for bug #355161
1206 * ecore.cs, expression.cs: Wider range of extension method supported
1209 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
1211 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
1212 AssemblyBuilder to operate in compiler context. Fixes mcs part of
1215 2008-01-22 Marek Safar <marek.safar@gmail.com>
1217 A fix for bug #355148
1218 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
1220 2008-01-22 Miguel de Icaza <miguel@novell.com>
1222 * expression.cs (CreateExpressionTree): Add support for or and
1223 logical or, and indent following the coding conventions.
1225 * typemanager.cs (LinqExpression): renamed from
1226 ExpressionTreeManager, for a shorter name.
1228 Use TypeManager.CoreLookupType to lookup types from our core
1229 assemblies and turn those into "Type" variables.
1231 Consumers that previously used "Namespace" and "Type" from this
1232 class should instead use the TypeExpression which is a type that
1233 is fully resolved (without involving the regular C# resolution
1236 This typically looks like this:
1238 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
1239 new MemberAccess (texpr, name, type_arguments, loc)
1241 This avoids the problem in: #355178
1243 2008-01-21 Marek Safar <marek.safar@gmail.com>
1245 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
1246 feature in parser only as we do in other cases.
1248 2008-01-21 Marek Safar <marek.safar@gmail.com>
1250 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
1251 typemanager.cs: A refactoring of params arguments to reuse existing
1252 expressions (params -> array initializer) to emit params argument instead
1253 of specialized handling.
1254 It was required by expression tree implementation and it has other benefits
1255 as well, we now apply same optimization for params arguments as we do for
1258 2008-01-18 Marek Safar <marek.safar@gmail.com>
1260 A fix for bug #353526
1261 * generic.cs: A type inference of params arguments may not required any
1262 temporary array creation.
1264 2008-01-18 Marek Safar <marek.safar@gmail.com>
1266 A fix for bug #353534
1267 * generic.cs, ecore.cs, expression.cs: A method group type inference is
1268 supported for delegates only.
1270 2008-01-18 Marek Safar <marek.safar@gmail.com>
1272 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
1273 type for more than 1 candidates.
1275 2008-01-18 Marek Safar <marek.safar@gmail.com>
1277 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
1280 2008-01-16 Marek Safar <marek.safar@gmail.com>
1282 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
1283 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
1284 operator) expressions.
1286 2008-01-16 Zoltan Varga <vargaz@gmail.com>
1288 * statement.cs: Avoid declaring an IL variable for this_variable since it is
1289 not accessed from the generated IL.
1291 2008-01-14 Marek Safar <marek.safar@gmail.com>
1293 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
1294 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
1295 statement.cs: The first expression tree implementation drop, mostly
1296 infrastructure work.
1298 2008-01-14 Marek Safar <marek.safar@gmail.com>
1300 * ecore.cs (IsNestedChild): Refactored.
1302 2008-01-11 Marek Safar <marek.safar@gmail.com>
1304 * lambda.cs: Don't use a cast on unknown expression statement.
1306 2008-01-10 Geoff Norton <gnorton@novell.com>
1308 * cs-tokenizer.cs: One more token to distinguish between method and lambda
1311 2008-01-09 Marek Safar <marek.safar@gmail.com>
1313 * doc.cs: Report better /doc crash details.
1315 2008-01-09 Marek Safar <marek.safar@gmail.com>
1317 A fix for bug #352536
1318 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
1320 2008-01-08 Marek Safar <marek.safar@gmail.com>
1322 A fix for bug #352287
1323 * ecore.cs, expression.cs: Do `this' access checking in all member access
1326 2008-01-08 Marek Safar <marek.safar@gmail.com>
1328 * rootcontext.cs, driver.cs: Switch to linq mode by default.
1330 * report.cs: Reset message stacks.
1332 2008-01-08 Marek Safar <marek.safar@gmail.com>
1334 * generic.cs (InferInPhases): Correctly calculate params position.
1336 2008-01-08 Marek Safar <marek.safar@gmail.com>
1338 * cs-tokenizer.cs: No need to parse full string when parsing lambda
1341 2008-01-07 Marek Safar <marek.safar@gmail.com>
1343 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
1345 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
1347 * driver.cs: Updated --help option.
1349 2008-01-07 Marek Safar <marek.safar@gmail.com>
1351 * generic.cs (InferParamsTypeArguments): Removed.
1352 (InferInPhases): Add params type inference.
1353 (LowerBoundInference): Fixed scoring mechanism.
1355 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
1357 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
1359 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
1360 byte array for unsigned "baked" assemblies.
1362 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
1364 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
1365 array for assemblies that are not strongnamed.
1367 2008-01-04 Marek Safar <marek.safar@gmail.com>
1369 A fix for bug #351481
1370 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
1371 declaring type for nested generic types.
1373 2008-01-04 Marek Safar <marek.safar@gmail.com>
1375 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
1376 instead of ToString.
1378 2008-01-03 Marek Safar <marek.safar@gmail.com>
1380 A fix for bug #351047
1381 * expression.cs (Binary.ResolveOperator): Allow equality operators between
1382 null and structs only when equality and inequality operators are defined
1383 either as an user-operators or predefined operators.
1385 2008-01-03 Marek Safar <marek.safar@gmail.com>
1387 A fix for bug #351047
1388 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
1390 2008-01-03 Marek Safar <marek.safar@gmail.com>
1392 A fix for bug #351257
1393 * cs-tokenizer.cs: Advance line number for '\r' correctly.
1395 2008-01-03 Marek Safar <marek.safar@gmail.com>
1397 A fix for bug #351157
1398 * class.cs (Using): Fixed yet another broken cloning.
1400 (Block): Put back more sensible default value for statements.
1402 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
1404 * codegen.cs: Allow AssemblyVersion with only major version component.
1407 2007-12-29 Marek Safar <marek.safar@gmail.com>
1409 A fix for bug #324654
1410 * class.cs: Use FullName property as member name.
1412 2007-12-28 Marek Safar <marek.safar@gmail.com>
1414 A fix for bug #342117
1415 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
1416 constructor constraint.
1418 2007-12-28 Marek Safar <marek.safar@gmail.com>
1420 A fix for bug #338273
1421 * class.cs (ProbertyBase): Access modifier checks are required for overrides
1424 2007-12-28 Marek Safar <marek.safar@gmail.com>
1426 A fix for bug #350839
1427 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
1429 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1431 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1434 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1436 * statement.cs: Changed some Hashtables to use HybridDictionaries
1437 instead. It was observed that some HashTables only contained a few
1438 items in the vast majority of cases. Since HybridDictionary is
1439 more efficient on small sets (<10 elements), "known_variables"
1440 from class ExplicitBlock as well as "labels" and "constants " from
1441 class Block were changed to HybridDictionaries.
1443 Atsai results: (56216kb->54987kb)
1445 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
1448 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1450 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1453 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1455 * expression.cs: foreach loop to for loop, saved on allocation of
1456 enumerator (59333kb->59141kb)
1458 * statement.cs. Changed foreach loops to for loops, saved on
1459 allocation of enumerator (59141kb->59006kb)
1461 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
1462 when constructed with no specified capacity. This was causing a
1463 few ArrayLists to allocate more memory than they would potentially
1464 need in the Block class and MemberCache class. Setting the
1465 ArrayLists to construct with a capacity of 1 saves some
1466 memory. (56216kb->55585kb)
1468 2007-12-27 Marek Safar <marek.safar@gmail.com>
1470 A fix for bug #347189 (2nd issue)
1471 * expression.cs (MemberAccess): Nested type can be found in base non-generic
1474 2007-12-27 Miguel de Icaza <miguel@novell.com>
1476 * report.cs: Do not use colors if stdout and stderr are not a
1479 2007-12-27 Marek Safar <marek.safar@gmail.com>
1481 A fix for bug #346998
1482 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
1485 2007-12-27 Marek Safar <marek.safar@gmail.com>
1487 A fix for bug #343465
1488 * class.cs: Explicit method name for nested types uses dots only.
1490 2007-12-27 Marek Safar <marek.safar@gmail.com>
1492 A fix for bug #343707
1493 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
1495 2007-12-27 Marek Safar <marek.safar@gmail.com>
1497 * ecore.cs: Report type inference errors only when arguments count matches
1500 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
1502 * expression.cs, report.cs: New warning.
1504 * typemanager.cs: Catch anonymous method type too.
1506 2007-12-23 Marek Safar <marek.safar@gmail.com>
1508 A fix for bug #346379
1509 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
1511 2007-12-23 Marek Safar <marek.safar@gmail.com>
1513 A fix for bug #347359
1514 * expression.cs (Invocation): Don't resolve already resolved expression.
1516 2007-12-23 Marek Safar <marek.safar@gmail.com>
1518 A fix for bug #347189
1519 * class.cs (FixedField): Use non-dependent code only in the define phase.
1521 2007-12-23 Marek Safar <marek.safar@gmail.com>
1523 A fix for bug #348076
1524 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
1526 2007-12-22 Marek Safar <marek.safar@gmail.com>
1528 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
1529 discovered extension methods.
1531 2007-12-22 Marek Safar <marek.safar@gmail.com>
1533 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
1536 2007-12-21 Miguel de Icaza <miguel@novell.com>
1538 * report.cs (ErrorMessage): Add support for using colors on
1539 terminals that support it.
1541 2007-12-21 Marek Safar <marek.safar@gmail.com>
1543 * ecore.cs: Use information about expanded params for error reporting.
1545 2007-12-21 Marek Safar <marek.safar@gmail.com>
1547 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
1548 and logic for params overloads.
1550 2007-12-15 Miguel de Icaza <miguel@novell.com>
1552 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
1553 as this is also created from the parser. Fixes #349034
1555 2007-12-12 Miguel de Icaza <miguel@novell.com>
1557 * statement.cs (Throw.CloneTo): it is valid to have empty
1558 expressions for throw.
1560 2007-12-03 Marek Safar <marek.safar@gmail.com>
1562 * cs-parser.jay: Set delegate constraint parsing region correctly.
1564 2007-12-03 Marek Safar <marek.safar@gmail.com>
1566 A fix for bug #345467
1567 * typemanager.cs (IsEqual): Compare generic parameters position only.
1569 2007-11-28 Marek Safar <marek.safar@gmail.com>
1571 * expression.cs (BaseAccess): Type arguments can be null.
1573 2007-11-27 Raja R Harinath <harinath@gmail.com>
1575 * statement.cs (Block.Resolve): Ensure flow-branching tree is
1576 consistent even when an error has occured.
1577 (Switch.Resolve): Likewise.
1579 2007-11-22 Marek Safar <marek.safar@gmail.com>
1581 A fix for bug #334505
1582 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
1585 2007-11-22 Marek Safar <marek.safar@gmail.com>
1587 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
1588 refactorings required to resolve extension methods correctly when mixing
1589 generics and non-generics members.
1591 2007-11-20 Marek Safar <marek.safar@gmail.com>
1593 A fix for bug #342584
1594 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
1597 2007-11-19 Marek Safar <marek.safar@gmail.com>
1599 A fix for bug #342512
1600 * delegate.cs: Use delegate argument expression when is available. Don't
1601 emit virtual call when class is sealed.
1603 2007-11-16 Marek Safar <marek.safar@gmail.com>
1605 A fix for bug #325423
1606 * assign.cs (FieldInitializer): Use resolved expression for emit.
1608 * class.cs: Print less confusing error message.
1610 2007-11-16 Marek Safar <marek.safar@gmail.com>
1612 * cs-tokenizer.cs: Removed GMCS ifdefs.
1614 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
1617 * cs-parser.jay: Disabled nullable check.
1619 * generic-mcs: Copied more generic stuff.
1621 2007-11-16 Marek Safar <marek.safar@gmail.com>
1623 * gcs-parser.jay: Merged to cs-parser.jay.
1625 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
1626 * *.csproj, *.sources: Updated to use only jay parser file.
1628 2007-11-16 Marek Safar <marek.safar@gmail.com>
1630 * gcs-parser.jay: Added nullable and default expression feature checks.
1632 2007-11-16 Marek Safar <marek.safar@gmail.com>
1634 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
1635 it fixes many TODOs and hidden bugs.
1637 * expression: Removed duplicate error check.
1639 2007-11-15 Marek Safar <marek.safar@gmail.com>
1641 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
1642 implicitly type local variable only when it is used in a declaration.
1644 2007-11-15 Marek Safar <marek.safar@gmail.com>
1646 * attribute.cs: Use CS0612 for empty strings.
1648 2007-11-14 Marek Safar <marek.safar@gmail.com>
1650 * lambda.cs, statement.cs: Contextual return may act as a statement.
1652 2007-11-14 Marek Safar <marek.safar@gmail.com>
1654 A fix for a regression cause by #324222
1655 * class.cs: Don't report unused even when it implements an interface.
1657 2007-11-13 Marek Safar <marek.safar@gmail.com>
1659 A fix for bug #341205
1660 * ecore.cs, expression.cs: Method group expression cannot do static
1661 method access with an instance reference check before overloading takes
1664 2007-11-13 Marek Safar <marek.safar@gmail.com>
1666 A fix for bug #325359
1667 * class.cs: Use predictable name for automatically generated property.
1669 2007-11-12 Marek Safar <marek.safar@gmail.com>
1671 A fix for bug #324996
1672 * expression.cs (Is): Handle case where D is nullable and T is not
1675 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
1677 2007-11-12 Marek Safar <marek.safar@gmail.com>
1679 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
1680 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
1681 Flush small error reporting changes.
1683 2007-11-09 Marek Safar <marek.safar@gmail.com>
1685 A fix for bug #324996
1686 * expression.cs: Rewrote Is expression implementation to work with
1687 generics, nullable types, anonymous method. A const result expression
1688 uses existing infrastructure instead of custom not fully-featured one.
1690 2007-11-08 Marek Safar <marek.safar@gmail.com>
1692 A fix for bug #340202
1693 * class.cs: Consider generics for volatile field.
1695 2007-11-08 Marek Safar <marek.safar@gmail.com>
1697 A fix for bug #335594
1698 * expression.cs: Use conversion rules when handling string addition.
1700 2007-11-07 Marek Safar <marek.safar@gmail.com>
1702 A fix for bug #336651
1703 * expression.cs: Fixed a crash when probing is on.
1705 2007-11-07 Marek Safar <marek.safar@gmail.com>
1707 A fix for bug #324242
1708 * covert.cs: Added a conversion from any nullable-type with an
1709 underlying enum-type to the type System.Enum.
1711 2007-11-07 Marek Safar <marek.safar@gmail.com>
1713 A fix for bug #324222
1714 * class.cs: Report all non-used event fields.
1716 2007-11-07 Marek Safar <marek.safar@gmail.com>
1718 A fix for bug #325161
1719 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
1720 qualifier for generic types.
1722 2007-11-07 Marek Safar <marek.safar@gmail.com>
1724 A fix for bug #322971
1725 * expression.cs, ecore.cs: Added intermediate result value check for
1728 2007-11-07 Marek Safar <marek.safar@gmail.com>
1730 A fix for bug #324754
1731 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
1732 when it was requested.
1734 2007-11-07 Marek Safar <marek.safar@gmail.com>
1736 A fix for bug #325101
1737 * expression.cs: Do type not value comparison for `is' expression.
1739 2007-11-07 Marek Safar <marek.safar@gmail.com>
1741 A fix for bug #320236
1742 * convert.cs: Don't apply user conversion on underlying target type.
1744 2007-11-06 Marek Safar <marek.safar@gmail.com>
1746 * expression.cs: Don't use unresolved expression for error reporting.
1748 2007-11-06 Marek Safar <marek.safar@gmail.com>
1750 A fix for bugs #337712, #324490
1751 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
1752 overloading resolution too.
1754 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
1755 the process consistent and more robust.
1757 * expression.cs, linq.cs, report.cs: Update.
1759 2007-11-02 Marek Safar <marek.safar@gmail.com>
1761 A fix for bug #332909
1762 * attribute.cs: Resolve attributes in correct context using error
1765 * rootcontext.cs: Define Obsolete attribute members as core members.
1767 2007-11-02 Marek Safar <marek.safar@gmail.com>
1769 * statement.cs: Removed unused methods.
1771 2007-10-31 Wade Berrier <wberrier@novell.com>
1773 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
1774 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
1777 2007-10-31 Marek Safar <marek.safar@gmail.com>
1779 A fix for bug #338102
1780 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
1781 methods registered as non-generics.
1783 2007-10-31 Marek Safar <marek.safar@gmail.com>
1785 A fix for bugs #337712, #324490
1786 * delegate.cs: Delegate covariance and contravariance is not allowed for
1789 2007-10-31 Marek Safar <marek.safar@gmail.com>
1791 A fix for bug #337719
1792 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
1795 2007-10-30 Marek Safar <marek.safar@gmail.com>
1797 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
1799 2007-10-29 Marek Safar <marek.safar@gmail.com>
1801 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
1804 2007-10-29 Raja R Harinath <rharinath@novell.com>
1806 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
1808 2007-10-29 Marek Safar <marek.safar@gmail.com>
1810 A fix for bug #334652
1811 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
1812 extension methods when we have not found the best candidate in normal
1815 2007-10-27 Marek Safar <marek.safar@gmail.com>
1817 * AssemblyInfo.cs: Keep up-to-date.
1819 2007-10-27 Marek Safar <marek.safar@gmail.com>
1821 * Makefile: Fixed generics compiler name.
1823 2007-10-27 Marek Safar <marek.safar@gmail.com>
1825 * lambda.test: removed, lambda parsing is done differently.
1827 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
1829 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
1831 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
1833 2007-10-27 Marek Safar <marek.safar@gmail.com>
1835 * Makefile, *.sources : All C# compilers are in mcs folder.
1837 * *.cs: Use existing 2_1 define for smcs.
1839 2007-10-26 Marek Safar <marek.safar@gmail.com>
1841 A fix for bug #335847
1842 * assign.cs, expression.cs: Couple of changes to avoid creating a
1843 temporary variable for each object initializer assignment statement. It
1844 simplifies struct initialization too, otherwise two temporary variables
1846 Implemented optimization of redundant default element initializers.
1848 2007-10-25 Marek Safar <marek.safar@gmail.com>
1850 A fix for bug #336766
1851 * expression.cs (Class.CheckBase): Use generic name when method is
1854 2007-10-25 Marek Safar <marek.safar@gmail.com>
1856 A fix for bug #334737
1857 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
1858 variable and not variable argument for prepared copies.
1860 2007-10-24 Marek Safar <marek.safar@gmail.com>
1862 A fix for bug #325110
1863 * class.cs, expression.cs, attribute.cs: Use open generic method when
1864 checking conditional attribute.
1866 2007-10-24 Marek Safar <marek.safar@gmail.com>
1868 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
1869 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
1870 FeatureIsNotAvailable.
1872 2007-10-24 Marek Safar <marek.safar@gmail.com>
1874 ** C# 3.0 Partial methods
1876 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
1877 methods support. Because of member cache issue with generics only
1878 non-generics partial methods are fully supported.
1880 2007-10-23 Marek Safar <marek.safar@gmail.com>
1882 * class.cs, decl.cs: Rewrote member overloads check to cope with
1883 generics and to use member cache for member checking. It also improves
1884 performance and fixes remaining overloads issues.
1886 2007-10-20 Marek Safar <marek.safar@gmail.com>
1888 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
1889 roottypes.cs, typemanager.cs:
1891 A member cache creation logic changed to add members immediately and
1892 not rely on fallback. The member cache is now only prefered way
1893 how to access and find type declaration members. It saves 5 MB of memory
1894 during MWF compilation and makes code ready for more optimizations and
1895 clean-ups, it's also a pre-requirement for partial methods.
1897 2007-10-18 Raja R Harinath <harinath@gmail.com>
1899 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
1900 handling for generic parameters.
1902 2007-10-15 Marek Safar <marek.safar@gmail.com>
1904 * class.cs (FixedField): Removed redundant volatile check.
1906 2007-10-15 Marek Safar <marek.safar@gmail.com>
1908 * class.cs, decl.cs: Fixed overload members verification to do only one
1909 check per possible collision.
1911 2007-10-13 Marek Safar <marek.safar@gmail.com>
1913 A fix for bug #325478
1914 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
1915 and create only one disposable flags container.
1917 2007-10-12 Marek Safar <marek.safar@gmail.com>
1919 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
1920 * statement.cs (Fixed): Fixed variables cloning.
1922 2007-10-12 Marek Safar <marek.safar@gmail.com>
1924 A fix for bug #333342
1925 * class.cs (EventField): Don't mark value type event as synchronized.
1927 2007-10-12 Marek Safar <marek.safar@gmail.com>
1929 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
1930 inference to identify best candidate method correctly.
1931 (ProperyExpr): A range variable is read only and cannot be modified.
1933 2007-10-11 Marek Safar <marek.safar@gmail.com>
1935 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
1936 logic to identify best candidate method correctly.
1938 2007-10-11 Marek Safar <marek.safar@gmail.com>
1940 * location.cs (Equals, GetHashCode): Removed.
1942 2007-10-11 Marek Safar <marek.safar@gmail.com>
1944 * report.cs: Implemented message recorder. It is used mainly for lambda
1945 expressions to capture otherwise swallowed error messages.
1947 * anonymous.cs, lambda.cs.cs: Do full parameters check.
1949 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
1951 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
1953 * expression.cs (MemberAccess): Always report lookup failure.
1955 * location.cs: Implemented Equals, GetHashCode.
1957 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
1959 2007-10-10 Jb Evain <jbevain@novell.com>
1961 * codegen.cs: re-enable assembly version check.
1963 2007-10-09 Marek Safar <marek.safar@gmail.com>
1965 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
1968 * namespace.cs (UsingAlias): Do correct version check.
1970 2007-10-08 Marek Safar <marek.safar@gmail.com>
1972 * expresison.cs, ecore.cs: Issue extension method error message when
1975 * rootcontext.cs: Added ISO_2 compiler mode option.
1977 2007-10-08 Marek Safar <marek.safar@gmail.com>
1979 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
1982 2007-10-08 Marek Safar <marek.safar@gmail.com>
1984 * attribute.cs (GetString, GetBoolean): Work with both literal and
1987 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
1988 Moved method overload specific methods to MethodGroupExpr.
1990 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
1991 it should be less memory consuming.
1993 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
1995 * codegen.cs: remove the assembly version check until the buildbot is
1998 2007-10-07 Jb Evain <jbevain@novell.com>
2000 * attribute.cs (Attribute.GetString): if the value
2001 expression is a StringConstant, return its string value.
2003 2007-10-07 Jb Evain <jbevain@novell.com>
2005 * typemanager.cs: add `assembly_version_attribute_type`.
2006 * codegen.cs: on attribute emission, check that the
2007 AssemblyVersionAttribute doesn't overflow.
2009 2007-10-05 Marek Safar <marek.safar@gmail.com>
2011 A fix for bug #324677
2012 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
2013 parent container of a scope container with currently resolved one.
2015 2007-10-05 Marek Safar <marek.safar@gmail.com>
2017 A fix for bug #325534
2018 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
2021 2007-10-05 Marek Safar <marek.safar@gmail.com>
2023 A fix for bug #327504
2024 * class.cs (Operator.Define): Refactored implicit and explicit user
2025 operator conversion rules.
2027 2007-10-05 Marek Safar <marek.safar@gmail.com>
2029 A fix for bug #327520
2030 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
2032 2007-10-04 Marek Safar <marek.safar@gmail.com>
2034 A fix for bug #328022
2035 * class.cs (MethodData.Define): Use correct method to check whether
2036 a method implementents an accessor.
2038 2007-10-04 Marek Safar <marek.safar@gmail.com>
2040 A fix for bug #330069
2041 * statement.cs (Fixed.Resolve): Read the first array element only when
2042 an array is instantiated.
2044 2007-10-04 Marek Safar <marek.safar@gmail.com>
2046 * expression.cs, assign.cs, generics.cs: Print correct operator when
2047 compound assignment is used.
2049 2007-10-04 Marek Safar <marek.safar@gmail.com>
2051 A fix for bug #325841
2052 * expression.cs (ArrayAccess): Use full argument cloning only for
2053 string compound concatenation.
2055 2007-10-03 Marek Safar <marek.safar@gmail.com>
2057 A fix for bug #328774
2058 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
2060 (PropertyExpr.EmitAssign): Fixed string concatenation compound
2063 2007-10-03 Raja R Harinath <rharinath@novell.com>
2066 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
2067 Event accessibility checks here. Remove some bogus code that
2068 accidently made GenericMethods work.
2069 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
2071 2007-09-25 Marek Safar <marek.safar@gmail.com>
2073 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
2075 * statement.cs (Block): Refactored AddVariable to allow error handling
2078 * generic.cs: New stub.
2080 2007-09-23 Marek Safar <marek.safar@gmail.com>
2082 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
2085 2007-09-17 Marek Safar <marek.safar@gmail.com>
2087 * class.cs: Use partial container to record whether any partial part
2088 contains static field initializer and therefore default contructor has
2091 2007-09-14 Marek Safar <marek.safar@gmail.com>
2093 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
2094 mono-list when only one of two partial parts has defined accessibility
2097 2007-09-14 Marek Safar <marek.safar@gmail.com>
2099 A fix for bug #82845
2101 * class.cs (TypeContainer): Set correct resolve context for all field
2104 2007-09-13 Marek Safar <marek.safar@gmail.com>
2106 * assign.cs: Fixed a crash when field is resolved twice with an error.
2108 * codegen.cs: Changed InFieldInitializer to be flag.
2110 * anonymous.cs, ecore.cs, expression.cs: Update after
2111 IsInFieldInitializer rename.
2113 * const.cs: Removed unused parameter.
2115 * class.cs: Changed the way how we resolve and emit field initializers.
2116 The field initilizers have to have access to contructor block to emit
2117 compiler generated code.
2119 2007-09-13 Marek Safar <marek.safar@gmail.com>
2121 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
2122 generics use TypeContainer instead.
2124 2007-09-12 Marek Safar <marek.safar@gmail.com>
2126 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
2128 * lambda.cs (ResolveParameters): Use more powerful
2129 InflateGenericArgument.
2131 * parameters.cs: Better exception message.
2133 2007-09-10 Marek Safar <marek.safar@gmail.com>
2135 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
2136 correct expression block type.
2138 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
2140 * expression.cs (Invocation): Extracted method group resolve to
2143 2007-09-07 Marek Safar <marek.safar@gmail.com>
2145 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
2146 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
2148 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
2149 generic extension methods.
2151 2007-09-06 Marek Safar <marek.safar@gmail.com>
2153 A fix for bug #82676 (Do I get it right now?)
2154 * convert.cs (Binary.ResolveOperator): An interface is converted to the
2155 object before a standard conversion is applied.
2157 2007-09-06 Marek Safar <marek.safar@gmail.com>
2159 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
2162 2007-09-05 Marek Safar <marek.safar@gmail.com>
2164 A fix for bug #82676
2165 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
2166 non-generic interface types.
2168 2007-09-05 Marek Safar <marek.safar@gmail.com>
2170 A fix for bug #82690
2171 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
2173 2007-09-05 Marek Safar <marek.safar@gmail.com>
2175 A fix for bug #82571
2176 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
2177 modifier for container based methods.
2179 2007-09-05 Marek Safar <marek.safar@gmail.com>
2181 A fix for bug #82676
2182 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
2183 any interface-type T means to any of interface type T.
2185 2007-09-04 Marek Safar <marek.safar@gmail.com>
2187 * namespace.cs: We have 2 versions of System.Core assembly.
2189 2007-09-04 Marek Safar <marek.safar@gmail.com>
2191 A fix for bug #82652
2192 * class.cs (Class.GetClassBases): Compare types and not expressions.
2194 2007-09-04 Marek Safar <marek.safar@gmail.com>
2196 A fix for bug #82620
2197 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
2198 actually never worked before.
2199 (IndexerAccess): Emit prepared arguments before they are modified.
2201 2007-09-04 Marek Safar <marek.safar@gmail.com>
2203 A fix for bug #82563
2204 * assign.cs: Revert wrong fix.
2206 * expression.cs (VariableReference.EmitAssign): Handle ref reference
2208 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
2209 Instead of ldelema/stdind we have to use temporary variables to handle
2210 cases like String.Concat (params string[]).
2212 2007-08-31 Marek Safar <marek.safar@gmail.com>
2214 * class.cs: EmitAttributes to Emit rename.
2216 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
2218 (MemberCore.HasClsCompliantAttribute): Don't depend on
2219 GetClsCompliantAttributeValue execution.
2221 2007-08-31 Marek Safar <marek.safar@gmail.com>
2223 * anonymous.cs: Use shorter type prefix.
2225 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
2228 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
2229 variables when probing is on.
2231 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
2232 unresolved variables.
2233 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
2234 handle transparent identifiers.
2236 2007-08-26 Marek Safar <marek.safar@gmail.com>
2238 * attribute.cs (IsClsCompliant): Add nullable types test.
2240 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
2242 * doc.cs : catch other types of exception than XmlException to
2243 report CS1570. Fixed bug #82565.
2245 2007-08-23 Marek Safar <marek.safar@gmail.com>
2247 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
2248 The number of delegate parameters has to match.
2249 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
2252 2007-08-21 Marek Safar <marek.safar@gmail.com>
2254 * anonymous.cs (AnonymousMethod): Generate private anonymous method
2255 to fix problem with private arguments.
2257 2007-08-20 Marek Safar <marek.safar@gmail.com>
2259 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
2261 * decl.cs (MemberName): Ignore generic type with no generic arguments.
2263 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
2264 empty. Add cloning suport.
2266 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
2268 2007-08-20 Marek Safar <marek.safar@gmail.com>
2270 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
2271 to create EmptyCast. It handles EmptyConstantCast specialization for
2274 2007-08-18 Marek Safar <marek.safar@gmail.com>
2276 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
2277 (EmitArrayArgument): One routine for array arguments.
2278 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
2280 2007-08-17 Marek Safar <marek.safar@gmail.com>
2282 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
2284 2007-08-17 Marek Safar <marek.safar@gmail.com>
2286 * anonymous.cs: MemberLookupFinal update.
2288 * class.cs (ConstructorInitializer): Is expression based.
2290 * delegate.cs: MethodGroupExpr update.
2292 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
2294 (Error_MemberLookupFailed): Customizable error override.
2295 (MethodGroupExpr): Keep queried type for later usage.
2296 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
2299 * expression.cs: Error_MemberLookupFailed refactoring.
2300 (New.DoResolve): Resolve as much as possible.
2301 (ElementInitializer.Error_MemberLookupFailed): Object initializer
2302 customization for invalid member types.
2304 * statement.cs: MethodGroupExpr update.
2306 2007-08-16 Marek Safar <marek.safar@gmail.com>
2308 * modifier.cs (Check): Check all modifiers and not only accessibility
2311 2007-08-16 Marek Safar <marek.safar@gmail.com>
2313 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
2314 type and not an expression.
2316 2007-08-16 Marek Safar <marek.safar@gmail.com>
2318 * statement.cs (Catch.Clone): Type and variable can be null.
2320 2007-08-16 Marek Safar <marek.safar@gmail.com>
2322 A fix for bug #81979
2323 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
2324 I am really not sure whether this is the best fix.
2326 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
2329 2007-08-14 Marek Safar <marek.safar@gmail.com>
2331 ** C# 3.0 Object and collection initializers (major re-write)
2333 * assign.cs (DoResolve): Initializers are not assign related.
2335 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
2336 used during collection or object initialization.
2338 * expression.cs (Error_InvalidArguments): Add initializers specific
2339 messages. More will come later because it requires some general
2341 (New.DoResolve): Better error handling for unsafe types.
2342 (EmptyExpressionStatement): New class.
2343 (ElementInitializer): An object initializer expression.
2344 (CollectionElementInitializer): A collection initializer expression.
2345 (CollectionOrObjectInitializers): A block of object or collection
2347 (NewInitialize): New expression with element/object initializers.
2349 * statement.cs: Reverted object/collection initializer hacks.
2351 * typemanager.cs (CSharpName): Filter __arglist type.
2353 2007-08-09 Marek Safar <marek.safar@gmail.com>
2355 ** C# 3.0 Anonymous Types (update to the latest standard)
2357 * expression.cs (Binary.ResolveOperator): Threat all null based types
2359 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
2360 (AnonymousTypeParameter): Updated.
2362 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
2363 (AnonymousTypeClass): New anonymous type container.
2365 * class.cs (AddField): Return operation result.
2367 * generic.cs: Another empty TypeArguments overload.
2369 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
2370 are stored at top of normal hierarchy.
2372 * typemanager.cs (CSharpName): Filter anonymous types.
2374 2007-08-09 Marek Safar <marek.safar@gmail.com>
2376 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
2377 as single Concat call. How could we miss that :-(
2379 2007-08-08 Marek Safar <marek.safar@gmail.com>
2381 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
2383 2007-08-07 Miguel de Icaza <miguel@novell.com>
2385 * expression.cs: Fix the previous commit, the creation of the
2386 arguments array list needs also to be conditional on the arguments
2389 * class.cs: Add a little bit of help to help narrow down problems.
2391 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
2392 not try to copy in that case.
2394 * driver.cs: When building SMCS, include a new different set of
2395 default assemblies here. Do this here so we can control whether
2396 to include the default assemblies with /noconfig.
2398 2007-08-03 Marek Safar <marek.safar@gmail.com>
2400 A fix for bug #81979
2401 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
2404 2007-08-03 Marek Safar <marek.safar@gmail.com>
2406 A fix for bug #82300
2408 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
2409 we are in probing scope.
2411 2007-08-03 Marek Safar <marek.safar@gmail.com>
2413 A fix for bug #82301
2415 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
2416 (Statement.CloneTo): Clone and not map children blocks.
2418 2007-08-03 Marek Safar <marek.safar@gmail.com>
2420 A fix for bug #82299
2422 * expression.cs (LocalVariableReference.CloneTo): Remap local info
2425 * statement.cs (Statement.CloneTo): Clone variables before statements
2426 to allow remaping of local variables.
2428 2007-08-03 Marek Safar <marek.safar@gmail.com>
2430 A fix for bug #82296
2433 * report.cs: Log crash details for future clone problems.
2435 * statement.cs (Return.Clone): Don't clone non-existent expression.
2437 2007-08-03 Raja R Harinath <harinath@gmail.com>
2439 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
2440 (Class.AddBasesForPart): Move CS0537 check here from ...
2441 * cs-parser.jay (class_declaration): ... here. Move calling of
2442 'AddBasesForPart' to ...
2443 (class_bases): ... here.
2444 (struct_declaration, interface_declaration): Update to changes.
2446 2007-08-02 Marek Safar <marek.safar@gmail.com>
2448 A fix for bug #81923
2450 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
2451 conversion is allowed.
2453 2007-08-02 Marek Safar <marek.safar@gmail.com>
2455 A fix for bug #81564
2457 * ecore.cs (EventExpr): Add IsBase handling.
2459 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
2462 2007-08-02 Raja R Harinath <harinath@gmail.com>
2464 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
2465 * cs-parser.jay: Some whitespace cleanups.
2466 (current_delegate): New.
2468 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
2469 a dummy code block, and use 'type_name' instead of 'member_name'.
2470 (interface_declaration, class_declaration): Likewise.
2471 (delegate_declaration): Likewise. Rearrange slightly and use
2473 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
2474 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
2476 2007-08-02 Marek Safar <marek.safar@gmail.com>
2478 A fix for bug #82039
2480 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
2483 * typemanager.cs (CSharpName): Split to string overload.
2485 2007-08-02 Marek Safar <marek.safar@gmail.com>
2488 * report.cs: Updated warning CS0472.
2490 2007-08-01 Marek Safar <marek.safar@gmail.com>
2492 A fix for bug #82181
2494 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
2496 2007-08-01 Marek Safar <marek.safar@gmail.com>
2498 A fix for bug #82277
2499 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
2501 2007-08-01 Marek Safar <marek.safar@gmail.com>
2503 ** C# 3.0 Type Inference (major bits are working)
2505 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
2506 (.ImplicitStandardConversionExists): Uses compatible.
2507 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
2508 (.InferReturnType): New method.
2509 (.Compatible): Refactored.
2510 (.ResolveParameters): Uses factory to create resolved parameters.
2511 (.CompatibleMethod): Add probing mode support.
2512 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
2513 clearly distinguish between 2 different operations.
2514 (LambdaMethod): Moved to lambda.cs.
2515 (AnonymousMethod): Removed unused fields and methods.
2516 (AnonymousDelegate): Simplified.
2518 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
2520 * convert. cs (ImplicitConversionStandard): Compatible works differently.
2522 * delegate.cs (Delegate): New mehods to reduce code duplication.
2523 (.GetConstructor): New method.
2524 (.GetInvokeMethod): New method.
2525 (DelegateCreation): Updated.
2527 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
2529 (OverloadResolve): Made probing little bit faster.
2531 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
2534 * generic.cs (TypeInferenceContext): Dummy implementation.
2536 * iterators.cs: Updated after Resolve/Define rename.
2538 * lambda.cs (LambdaExpression)
2539 (.ResolveParameters): Handles both type of arguments and type inference too.
2541 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
2542 (InflateTypes): Updated.
2544 * support.cs (InflateTypes): Changed signature and updated.
2546 * typemanager.cs (LookupMemberCache): Better dynamic type check.
2547 (MemberLookup_FindMembers): More MS tricks.
2548 (GetParameterData): Ditto.
2549 (GetDelegateParameters): Uses quick path for dynamic types.
2551 2007-08-01 Marek Safar <marek.safar@gmail.com>
2553 * class.cs (MethodData.Define): EmitContext is required for generic stuff
2556 2007-07-31 Marek Safar <marek.safar@gmail.com>
2558 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
2561 2007-07-26 Jb Evain <jbevain@novell.com>
2563 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
2564 which takes a boolean 'report_errors', similar to the GetMethod.
2565 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
2566 in .net 2.1, do not report errors here.
2568 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
2569 System.Runtime.CompilerServices.RequiredAttributeAttribute and
2570 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
2573 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
2574 of the type InternalsVisibleToAttribute before the first call
2575 to CoreLookupType which is allowed to fail (third boolean parameter
2576 to true). Because, during the resolution for a type that is not
2577 immediately found, we try to check if the type is not defined in
2578 a friend assembly, and to do so, we need the
2579 InternalVisibleToAttribute.
2581 2007-07-23 Miguel de Icaza <miguel@novell.com>
2583 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
2584 feature that allows structs to be compared against null and inline
2585 the result as true or false.
2587 Notice that the same code is not permitted inside a generic block
2588 of code that would do:
2590 class Foo<T> where T : struct {
2597 It is only allowed if the type of T is not bound (no where
2598 clause). In my opinion, this CSC 2 behavior is broken but people
2599 seem to be using it (IronRuby does, a few bug reports on bugzilla
2600 have it and some people have complained about it).
2602 All of the users that depend on this behavior have code that is
2605 * report.cs (Warning, Error): make these take object arguments,
2606 not strings, as that allows us to take advantage of Format.
2608 2007-07-20 William Holmes <billholmes54@gmail.com>
2610 * decl.cs: Changed MemberName.CountTypeArguments to also check the
2611 Left member variable for the Count.
2612 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
2613 MemberName.CountTypeArguments to avoid a NRE.
2615 This code is contributed under the MIT X11 license
2617 2007-07-18 Marek Safar <marek.safar@gmail.com>
2619 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
2621 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2623 * doc.cs : generic method arguments are written as ``x while generic
2624 type arguments are `x. Combined with the previous change, fixed bug
2627 2007-07-18 Raja R Harinath <rharinath@novell.com>
2630 * expression.cs (Binary.ResolveOperator): When converting
2631 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
2633 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2635 * doc.cs : when T: or whatever x: is specified, it does not really
2636 check the doc comment's syntax correctness. Fixed bug #82006.
2638 2007-07-18 Marek Safar <marek.safar@gmail.com>
2640 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
2641 LambdaExpression better.
2643 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
2645 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
2647 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
2648 as it can be generated.
2650 * expression.cs (Invocation.Error_InvalidArguments): Show correct
2653 * lambda.cs (LambdaExpression): Refactored to share same code with
2654 AnonymousMethodExpression.
2656 2007-07-17 Marek Safar <marek.safar@gmail.com>
2658 * anonymous.cs (MakeName): Include host name for easier debugging.
2659 (LambdaMethod): New class for lambda spcecific stuff.
2661 * attribute.cs: Set EmitContext return type.
2663 * class.cs: Set EmitContext return type.
2665 * codegen.cs (EmitContext): Return type cannot be null to stop messing
2666 with null/void meaning.
2668 * iterators.cs (ContainerType): Implemented.
2670 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
2672 * statement.cs (Return): Updated to lambda expressions.
2673 (Block.CloneTo): Parent can be null.
2675 2007-07-13 Marek Safar <marek.safar@gmail.com>
2677 A fix for bug #81917
2678 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
2680 * class.cs (FixedField): Check whether field is in unsafe scope.
2682 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
2683 (FieldExpr.Emit): Fixed buffers cannot be volatile.
2685 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
2688 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
2690 2007-07-13 Marek Safar <marek.safar@gmail.com>
2692 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
2693 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
2696 2007-07-13 Marek Safar <marek.safar@gmail.com>
2698 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
2700 2007-07-13 Marek Safar <marek.safar@gmail.com>
2702 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
2703 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
2705 * codegen.cs(EmitContext): Add ProbingMode flag.
2707 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
2709 * driver.cs: For now set both warning values.
2711 * ecore.cs (SimpleName): Name is readonly.
2712 (MethodGroup.OverloadResolve): One quick path for probing.
2714 * expression.cs (Unary): Set Oper r/o.
2715 (Binary): Set Oper r/o.
2716 (ParameterReference): Set few instance variables as r/o.
2717 (ParameterReference.DoResolveBase): Don't capture aruments when
2719 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
2720 (Arglist): arguments are private.
2721 (SizeOf): type is private and r/o.
2722 (MemberAccess): arguments are private.
2724 * report.cs: Enhanced reporting on/off capabilities.
2726 * lambda.cs: Uses ec.IsInProbingMode.
2727 (ContextualReturn): Derives from return.
2729 * rootcontext.cs: For now set both warning values.
2731 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
2733 (Return.Resolve): Don't die immediately.
2734 (Block.Resolve): Speed-up probing.
2735 (Block.CloneTo): Clone only child blocks.
2737 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
2739 * iterators.cs: reverted Miguel's latest change (r81925) as it
2740 breaks the build in System.
2742 2007-07-13 Miguel de Icaza <miguel@novell.com>
2744 * iterators.cs (Yield.CheckContext): Check for the iterator type
2745 also here as we can call into Yield even in codepaths that are not
2747 (MethodOrOperator is the only path that was checked).
2749 In addition to the standard check, use a more specific check for
2750 constructors to report a more verbose error.
2752 2007-07-12 Miguel de Icaza <miguel@novell.com>
2754 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
2755 report the warning and continue
2757 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
2758 values on the stack on the call to Emit. Use EmitStatement if
2759 possible, or using Emit + Pop if not possible. Fixes #82064
2761 2007-07-12 Raja R Harinath <rharinath@novell.com>
2763 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
2764 avoid try...finally in some cases.
2766 2007-07-10 Marek Safar <marek.safar@gmail.com>
2768 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
2770 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
2771 instead of method. Re-use standard error handling.
2772 (ConstructorInitializer.Emit): Simplified.
2774 * delegate.cs: Updated after Invocation.EmitCall change.
2776 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
2777 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
2778 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
2779 method and don't permanently changing input arguments.
2780 (MethodGroupExpr): Introduced resolved best_candidate, when method group
2781 is resolved it has one of the candidates is the best one which is later
2782 used to emit. Removed a few unused method.
2783 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
2785 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
2786 (Binary.ResolveOperator): Ditto.
2787 (ConditionalLogicalOperator.DoResolve): Ditto.
2788 (Invocation): Uses method group.
2789 (Invocation.DoResolve): Simplified.
2790 (Invocation.EmitCall): Removed useless is_static.
2791 (Invocation.Emit): Delegate to method group.
2792 (Invocation.EmitStatement): Simplified.
2793 (New): Uses method group.
2794 (MemberAccess.DoResolve): Don't destroy original expression.
2796 * statement.cs (ForEach.Resolve): Use null for no method arguments.
2798 2007-07-04 Marek Safar <marek.safar@gmail.com>
2800 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
2803 * lambda.cs: Add custom error message type.
2805 2007-07-03 Marek Safar <marek.safar@gmail.com>
2807 * lambda.cs: Simplified little bit.
2809 * parameter.cs: Introduced ImplicitLambdaParameter.
2810 (Parameters.CreateFullyResolved): New factory instead of ctor.
2814 * delegate.cs: Updated parameter creation.
2816 2007-07-03 Marek Safar <marek.safar@gmail.com>
2818 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
2821 * generic.cs: Synchronized with gmcs.
2823 2007-07-03 Marek Safar <marek.safar@gmail.com>
2825 * class.cs (Indexer): Check return type as soon as possible.
2827 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
2830 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
2832 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
2834 * parameter.cs (Parameter): Use expression type when it is available.
2836 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
2837 method modifier for the first parameter only.
2839 2007-06-24 Marek Safar <marek.safar@gmail.com>
2841 A fix for bug #81938
2842 * typemanager.cs (ChangeType): Fixed couple of char conversions.
2844 * constant.cs: Tide up an exception message.
2846 2007-06-22 Marek Safar <marek.safar@gmail.com>
2848 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
2849 an uninitialized variable is used.
2851 * expression.cs (LocalVariableReference.DoResolve): Ditto.
2853 2007-06-22 Marek Safar <marek.safar@gmail.com>
2855 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
2856 not found error handling.
2858 * expression.cs (ArrayCreation): Removed redundant fields and little bit
2860 (ArrayCreation.ResolveArrayElement): To be ready to customization.
2861 (ArrayCreation.DoResolve): Simplified.
2862 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
2863 its own resolve process.
2864 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
2866 2007-06-20 Marek Safar <marek.safar@gmail.com>
2868 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
2871 2007-06-20 Marek Safar <marek.safar@gmail.com>
2873 * cs-tokenizer.cs: Removed var related stuff.
2875 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
2876 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
2877 a type and a keyword at same time.
2879 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
2882 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
2883 implicitly typed arrays, more changes will follow.
2885 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
2887 2007-06-19 Marek Safar <marek.safar@gmail.com>
2889 * ecore.cs (VarExpr): Removed Handled field.
2891 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
2892 build-in assign functionality.
2893 (ForEach.Resolve): Removed all implicitly typed local variable code and
2895 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
2896 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
2898 2007-06-18 Marek Safar <marek.safar@gmail.com>
2900 * assign.cs: Removed implicitly typed local variable check.
2902 * expression.cs (LocalVariableReference.DoResolve): Add check for self
2903 referencing implicitly typed local variable.
2904 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
2907 * statement.cs (Fixed): Removed unsupported implicitly typed local
2910 2007-06-15 Marek Safar <marek.safar@gmail.com>
2912 * decl.cs (MemberName): Moved all Unbound stuff to parser.
2914 2007-06-14 Marek Safar <marek.safar@gmail.com>
2916 A fix for bugs #81855 and #76274
2917 * attribute.cs (AttachTo): Always set owner for global attributes to
2920 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
2923 * cs-parser.jay: Assembly and module attributes must precede all other
2924 elements except using clauses and extern alias declarations.
2926 2007-06-13 Marek Safar <marek.safar@gmail.com>
2928 A fix for bug #81748
2930 * expression.cs: More checks for non ISO-1 features.
2932 2007-06-12 Marek Safar <marek.safar@gmail.com>
2934 A fix for bug #81807
2935 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
2936 present inside switch statement and it is required by nullable check.
2938 2007-06-12 Marek Safar <marek.safar@gmail.com>
2940 A fix for bug #81840
2941 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
2942 when type matching fails.
2944 * namespace.cs: Tiny error message change.
2946 2007-06-12 Marek Safar <marek.safar@gmail.com>
2948 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
2949 reporting. Added automatic property check.
2951 * class.cs: Updated after CheckAbstractAndExtern relocation.
2952 (AEventPropertyAccessor.GetSignatureForError): Customized.
2954 2007-06-11 Marek Safar <marek.safar@gmail.com>
2956 * class.cs (DefineBaseTypes): Base type can be undefined.
2958 * ecore.cs (TypeLookup): Minor refactoring.
2959 (DoResolveAsTypeStep): Removed redundant check.
2961 * namespace.cs (Lookup): Removed redundant check.
2963 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
2964 ResolveAsTypeTerminal step.
2965 (BootstrapCorlib_*): Simplified.
2966 (PopulateCoreType): Core types can be now external.
2968 2007-06-07 Marek Safar <marek.safar@gmail.com>
2970 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
2972 (InferTypeArguments): Infers anonymous expression type arguments.
2973 (Compatible): Split to Compatible and InferTypeArguments.
2975 * lambda.cs: Updated.
2977 2007-06-08 Marek Safar <marek.safar@gmail.com>
2979 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
2981 2007-06-07 Raja R Harinath <harinath@gmail.com>
2983 Fix #80477, cs0135-2.cs, cs0135-3.cs
2984 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
2985 names to the "known" variables list.
2986 (Block.CheckInvariantMeaningInBlock): Handle the fact the
2987 parameter names are also "known".
2988 (Block.CheckError136): Remove.
2989 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
2992 2007-06-07 Marek Safar <marek.safar@gmail.com>
2994 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
2996 2007-06-06 Marek Safar <marek.safar@gmail.com>
2998 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
2999 internal error not an user error.
3001 * expression.cs (IsApplicable): Refactored to make debugging easier.
3003 * support.cs: More tricks for non-mono runtimes.
3005 * typemanager.cs (CoreLookupType): Made public.
3006 (InitSystemCore): All linq specific stuff moved to linq.cs
3008 2007-06-05 Marek Safar <marek.safar@gmail.com>
3010 * typemanager.cs (CSharpSignature): One more missing build-in types
3012 More tricks for non-mono runtime.
3014 2007-06-05 Raja R Harinath <harinath@gmail.com>
3016 * statement.cs (Block.CheckError136_InParents): Remove.
3017 (Block.AddVariable): Use GetParameterInfo instead.
3018 (ToplevelBlock.ProcessArguments): Likewise.
3020 2007-06-04 Raja R Harinath <rharinath@novell.com>
3022 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
3024 (ToplevelBlock.GetParameterInfo): Split out of ...
3025 (ToplevelBlock.GetParameterRefernce): ... this.
3026 (ToplevelBlock.ParameterMap): Remove.
3027 * expression.cs (ParameterReference): Update to use
3028 ToplevelParameterInfo.
3030 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
3033 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
3034 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
3036 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
3037 (ToplevelBlock.ProcessParameters) ... here.
3038 (ToplevelBlock..ctor): Invoke it.
3040 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
3043 * statement.cs (IKnownVariable): New interface.
3044 (LocalInfo): Implement it.
3045 (ToplevelParameterInfo): New class.
3046 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
3047 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
3048 GetKnownVariableInfo.
3050 2007-06-03 Raja R Harinath <harinath@gmail.com>
3052 Partly speed up CS0136 error checks.
3053 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
3054 'recurse' parameter.
3055 (Block.DoCheckError136): Only check errors in parameters. Move
3056 local variable checks ...
3057 (Block.AddVariable): ... here, and ...
3058 (ToplevelBlock.ResolveMeta): ... here.
3060 2007-06-02 Raja R Harinath <harinath@gmail.com>
3062 * statement.cs (Block.IsChildOf): Remove.
3064 * statement.cs (Statement.Clone): Move special case code ...
3065 (Block.CloneTo): ... here.
3067 2007-05-29 Raja R Harinath <rharinath@novell.com>
3069 * statement.cs (ToplevelBlock.container): Remove field. It's
3070 redundant with 'Parent'.
3071 (ToplevelBlock.ContainerBlock): Remove accessor.
3072 (ToplevelBlock..ctor): Update to changes. Register anonymous
3073 child with parent here, ...
3074 * cs-parser.jay (end_anonymous): ... not here. Don't modify
3076 (start_anonymous): Don't save current_block.
3077 (top_current_block): Remove.
3079 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
3080 (Block.Resolve): Update to changes.
3081 (Block..ctor): Move setting of "correct" 'Toplevel'
3082 and 'Explicit' fields to ...
3083 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
3085 2007-05-27 Raja R Harinath <harinath@gmail.com>
3088 * statement.cs (Block.Implicit): Remove.
3089 (Block): Update to changes.
3090 * flowanalysis.cs: Likewise.
3092 Mildly speed up CheckInvariantMeaningInBlock
3093 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
3094 Recursively call AddKnownVariable to all enclosing blocks.
3095 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
3096 Remove recursive calls.
3097 (Block): Update to changes.
3099 New ExplicitBlock invariants
3100 * statement.cs (Block.Explicit): New field. It points to the
3101 immediately enclosing non-implicit block.
3102 (Block..ctor): Maintain the invariant.
3103 * cs-parser.jay: Take advantage of invariant.
3105 Introduce ExplicitBlock
3106 * statement.cs (ExplicitBlock): New.
3107 (ToplevelBlock): Derive from it.
3108 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
3110 (Block.Implicit): Update to changes.
3111 * cs-parser.jay: Update to changes.
3114 * codegen.cs (EmitContext.IsLastStatement): Remove.
3115 * statement.cs (Block.DoEmit): Update to changes.
3117 2007-05-25 Raja R Harinath <rharinath@novell.com>
3119 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
3120 modifying current_block directly.
3122 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
3124 * class.cs: Implemented automatic properties (C# 3.0)
3125 Thanks to Marek for the help.
3127 2007-05-23 Raja R Harinath <rharinath@novell.com>
3129 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
3130 variable as assigned, note also that all its components are
3132 (MyBitVector.SetRange): New. Function to set multiple bits to true.
3134 2007-05-19 Marek Safar <marek.safar@gmail.com>
3136 * anonymous.cs, class.cs: Emit Compiler generated attribute when
3137 member is marked as compiler generated.
3139 * decl.cs (MemberCore): Refactored ModFlags into property.
3141 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
3142 (Check): Check only accessibility modifiers.
3144 2007-05-18 Raja R Harinath <rharinath@novell.com>
3146 Track all assignable slots in one bit array
3147 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
3148 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
3149 logic from VariableMap constructor here. Use the same 'offset'
3150 variable that's later used for computing offsets of local
3152 * flowanalysis.cs (UsageVector.parameters): Remove.
3153 (UsageVector): Update to changes.
3154 (VariableMap): Remove.
3156 Avoid creating ParameterMap in every block
3157 * statement.cs (Block.ParameterMap): Move ...
3158 (ToplevelBlock.ParameterMap): ... here.
3159 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
3161 * flowanalysis.cs (FlowBranching.param_map): Remove.
3162 (FlowBranching.UsageVector): Update to changes.
3163 (FlowBranchingToplevel.CheckOutParameters): Likewise.
3165 * statement.cs (Block.CloneTo): Clone Toplevel field too.
3167 * expression.cs (ParameterReference): Distinguish between block
3168 where parameter was referenced and declared.
3170 2007-05-18 Marek Safar <marek.safar@gmail.com>
3172 * flowanalysis.cs, statement.cs: Put back improved error handling.
3174 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
3178 Imporved object and collection initialization (C# 3.0).
3180 2007-05-15 Marek Safar <marek.safar@gmail.com>
3182 A fix for bug #81380
3183 * expression.cs (Is.DoResolve): Only value types have constant `is'
3186 2007-05-15 Raja R Harinath <rharinath@novell.com>
3188 * statement.cs (ToplevelBlock.child): Remove.
3190 2007-05-15 Raja R Harinath <harinath@gmail.com>
3192 Rationalize ResolveMeta: refactoring
3193 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
3194 out constant handling code into ...
3195 (Block.DoResolveConstants): ... this.
3197 Rationalize ResolveMeta: kill local_map
3198 * statement.cs (Block.local_map, Block.LocalMap): Remove.
3199 (Block.AssignableSlots): New.
3200 (Block.ResolveMeta): Make protected. Don't create a VariableMap
3201 for locals -- move code from VariableMap here. Avoid unnecessary
3203 * flowanalysis.cs (FlowBranching.local_map): Remove.
3204 (FlowBranching..ctor): Use Block.AssignableSlots.
3205 (VariableMap): Remove unused constructors.
3207 2007-05-11 Raja R Harinath <rharinath@novell.com>
3209 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
3211 2007-05-11 Marek Safar <marek.safar@gmail.com>
3213 * typemanager.cs (IsFriendAssembly): Should not be called for building
3216 2007-05-09 Marek Safar <marek.safar@gmail.com>
3218 * literal.cs (NullConstant): Print null in all cases.
3220 * expression.cs (Binary.ResolveOperator): Implemented delegate
3221 comparison based on C# 2.0 changes.
3223 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
3225 This code is contributed under the MIT X11 license
3227 The following enables support for several C# 3.0 language features:
3229 * cs-tokenizer.cs: Added support for the "var" keyword.
3231 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
3232 Added VarExpr class to facilitate type inferencing.
3234 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
3235 to support anonymous types.
3237 * assign.cs: Added support for type inferencing and initialization.
3239 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
3241 * expression.cs: Added implicit array support to ArrayCreation.
3242 Added 5 types and 1 interface:
3244 IInitializable Implementing classes can inject initializing
3245 statements after object instantiation.
3247 Initializer Stores data for object initialization.
3249 AnonymousType An expression for anonymous types.
3251 AnonymousTypeParameter Stores data about an anonymous type's field.
3253 NewInitialize An expression for object initialization.
3255 CollectionInitialize An expression for collection initialization.
3257 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
3260 2007-05-06 Marek Safar <marek.safar@gmail.com>
3262 A fix for bug #81500
3263 * cs-tokenizer.cs: Add special handling for coalescing operator.
3265 2007-05-06 Marek Safar <marek.safar@gmail.com>
3267 A fix for bug #81529
3268 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
3269 its value from base class until it is redefined.
3271 2007-05-02 Raja R Harinath <rharinath@novell.com>
3273 Fix regression in cs0631-3.cs
3274 * cs-parser.jay (operator_declarator): Add opt_attributes to error
3275 fallback. Make error fallback catch more cases.
3277 2007-05-01 Miguel de Icaza <miguel@novell.com>
3279 * cs-parser.jay: Allow parameters in operator declarations to have
3282 2007-04-27 Miguel de Icaza <miguel@novell.com>
3284 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
3287 * lambda.cs (ContextualReturn.Resolve): An expression is valid
3288 inside the ContextualReturn, it does not have to be an
3289 ExpressionStatement.
3291 2007-04-24 Miguel de Icaza <miguel@novell.com>
3293 * lambda.cs (ContextualReturn.Resolve): if the return type is not
3296 2007-04-23 Miguel de Icaza <miguel@novell.com>
3298 * anonymous.cs (AnonymousContainer): split the virtual Resolve
3299 method in two methods: ResolveNoDefine and Resolve.
3301 ResolveNoDefine will stop just after ResolveTopBlock has been
3304 Resolve will then continue by creating a method and issuing the
3305 call to method.Define ().
3307 (AnonymousMethod): Split and implement the new Resolve and
3308 ResolveNoDefine as well.
3310 * lambda.cs (LambdaExpression): Split the anonymous method
3311 resolution code into a separate routine (CoreCompatibilityTest)
3312 from DoCompatibleTest.
3314 (LambdaExpression.TryBuild): New method, this method tries to
3315 build the LambdaExpression with the given set of types to be used
3316 as the types for the various parameters of the lambda expression.
3318 If the compilation succeed with the given types, the infered type
3319 of the Anonymous method is returned, otherwise null is returned.
3321 2007-04-23 Marek Safar <marek.safar@gmail.com>
3323 A fix for bug #81414
3324 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
3326 2007-04-22 Miguel de Icaza <miguel@novell.com>
3328 * cs-tokenizer.cs: Change various identifiers here from the
3329 camelCasing to the recommended Linux-like style for instance
3330 variables from the Coding Guidelines.
3332 2007-04-19 Martin Baulig <martin@ximian.com>
3335 (Convert.ImplicitReferenceConversionCore): Allow conversions from
3336 System.Enum to System.ValueType.
3338 2007-04-13 Martin Baulig <martin@ximian.com>
3340 Rewrote implicit reference conversions. We need to distinguish
3341 between implicit reference conversions (13.1.4) and implicit
3342 boxing conversions (13.1.5).
3344 According to the spec, there's an an implicit conversion
3345 "From a one-dimensional array-type S[] to IList<T> and base
3346 interfaces of this interface, provided there is an implicit
3347 reference conversion from S to T." Note that this does not
3348 include boxing conversions.
3351 (Convert.ImplicitTypeParameterBoxingConversion): New method.
3352 (Convert.ImplicitReferenceConversion): Split into
3353 ImplicitReferenceConversionCore() and
3354 ImplicitBoxingConversionExist().
3355 (Convert.ImplicitReferenceConversionExists): Use the new
3356 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
3358 2007-04-12 Martin Baulig <martin@ximian.com>
3360 * convert.cs (Convert.ImplicitReferenceConversion): Move the
3361 `TypeManager.null_type' checks up to the top of the method.
3363 2007-04-11 Marek Safar <marek.safar@gmail.com>
3365 A fix for bug #81350
3366 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
3369 2007-04-11 Martin Baulig <martin@ximian.com>
3371 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
3372 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
3373 to make this work for generic classes; fixes #79561.
3375 2007-04-11 Martin Baulig <martin@ximian.com>
3377 * expression.cs (As): Add support for nullable types; fixes #79371.
3379 2007-04-11 Martin Baulig <martin@ximian.com>
3381 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
3382 `type.FullName' is null; fixes #80243.
3384 2007-04-11 Martin Baulig <martin@ximian.com>
3386 * expression.cs (Invocation.IsApplicable): Don't modify the method
3387 if type inference succeeded, but the method was not applicable.
3390 2007-04-10 Marek Safar <marek.safar@gmail.com>
3392 A fix for bug #81324
3393 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
3394 internal and external namespaces containers.
3396 2007-04-10 Martin Baulig <martin@ximian.com>
3398 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
3399 TypeManager.DropGenericMethodArguments() so we also call
3400 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
3402 2007-04-10 Martin Baulig <martin@ximian.com>
3404 * iterators.cs (Iterator.CreateIterator): Don't crash if
3405 `method.ReturnType' is null. This happens if something went wrong
3406 while resolving that typ (we already reported an error in this case).
3408 2007-04-10 Martin Baulig <martin@ximian.com>
3410 * expression.cs (New.DoResolve): Don't call CheckComImport() on
3411 generic interfaces; report the CS0144 directly.
3413 2007-04-10 Martin Baulig <martin@ximian.com>
3415 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
3416 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
3418 2007-04-10 Martin Baulig <martin@ximian.com>
3420 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
3422 2007-04-09 Raja R Harinath <rharinath@novell.com>
3425 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
3426 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
3429 * statement.cs (For.Resolve): If resolution fails, use
3432 2007-04-08 Marek Safar <marek.safar@gmail.com>
3434 * anonymous.cs (MakeName): Make faster and zero-based.
3435 (VerifyExplicitParameterCompatibility): Back to mode where generic
3436 parameter is ignored.
3437 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
3439 * class.cs (EmitType): Method can emit another new method.
3441 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
3443 * driver.cs: Updated.
3445 * lambda.cs: Reuse predefined empty parameters.
3447 * parameter.cs: Updated
3449 * support.cs: Implemented InflateTypes.
3451 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
3452 (InitSystemCore): Introduced to isolate 3.0 dependencies.
3454 2007-04-03 Martin Baulig <martin@ximian.com>
3458 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
3459 version of TypeManager.IsOverride() which also works with generic
3462 2007-04-03 Martin Baulig <martin@ximian.com>
3467 (Convert.ExplicitReferenceConversion): We need to cast when
3468 converting from IList<T> to S[].
3470 2007-04-01 Marek Safar <marek.safar@gmail.com>
3472 * decl.cs (FindExtensionMethods): Consider all candidates with same name
3475 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
3477 2007-03-31 Marek Safar <marek.safar@gmail.com>
3479 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
3480 argument and return type inferring.
3482 * codegen.cs (InferReturnType): Flag whether return can be inferred.
3483 (ReturnType): Turned to property.
3485 * statement.cs (Return): Implemented return type inferring.
3487 * support.cs (ReflectionParameters): Use local types if possible.
3489 2007-03-30 Raja R Harinath <rharinath@novell.com>
3491 * flowanalysis.cs (FlowBranching.Reachability): Remove.
3492 (FlowBranching.UsageVector): Update to changes.
3494 Prepare to kill 'Reachability'
3495 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
3496 argument of constructor.
3498 2007-03-29 Raja R Harinath <rharinath@novell.com>
3500 Prepare to kill 'Reachability'
3501 * flowanalysis.cs (UsageVector.is_unreachable): New.
3502 (UsageVector): Update to maintain 'is_unreachable' in parallel to
3503 'reachability', and verify they're consistent.
3506 * expression.cs (New.EmitStatement): Handle type parameters here too.
3508 2007-03-29 Martin Baulig <martin@ximian.com>
3513 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
3514 CompilerGeneratedClass.
3515 (ScopeInfo.EmitScopeInstance): Make this protected.
3516 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
3517 `ec.CurrentAnonymousMethod.Scope == Scope'.
3519 * statement.cs (Block.ScopeInfo): Make this a property.
3521 2007-03-27 Raja R Harinath <harinath@gmail.com>
3523 Prepare to kill 'Reachability'
3524 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
3525 (FlowBranching.UsageVector.Reachability): Remove property.
3526 (FlowBranching.UsageVector.IsUnreachable): New property.
3527 (FlowBranching.UsageVector.ResetBarrier): New.
3528 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
3529 * codegen.cs, statement.cs: Update to changes.
3531 2007-03-27 Martin Baulig <martin@ximian.com>
3536 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
3539 2007-03-26 Raja R Harinath <rharinath@novell.com>
3541 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
3542 instead of TriState. Remove all mention of TriState.
3544 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
3545 replaced by a boolean. Add boolean 'is_unreachable' field, check
3546 and maintain invariants.
3548 2007-03-25 Marek Safar <marek.safar@gmail.com>
3550 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
3552 2007-03-25 Marek Safar <marek.safar@gmail.com>
3554 * expression.cs: Stop using obsolete 2.0 opcodes.
3556 2007-03-25 Marek Safar <marek.safar@gmail.com>
3558 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
3559 one of the latests Martin's fixes.
3561 2007-03-23 Miguel de Icaza <miguel@novell.com>
3563 * expression.cs: On BigEndian systems, swap the bytes, temporary
3564 solution until we get a new bitconverter class.
3566 2007-03-23 Martin Baulig <martin@ximian.com>
3570 * decl.cs (MemberCache.AddMembers): Add generic methods both as
3571 "Method" and "Method`1". Normally, a cache lookup is done on the
3572 "Method" form (ie. without the generic arity), but this one makes
3573 lookups on the full form work as well.
3575 2007-03-22 Raja R Harinath <rharinath@novell.com>
3577 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
3580 2007-03-20 Bill Holmes <billholmes54@gmail.com>
3582 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
3583 ordered_member_list, to TypeBuilder to store members to be defined
3584 in the order they were parsed in.
3585 - ordered_explicit_member_list contains all properties indexers
3586 and methods that are defined as explicit implementation of an
3587 interface or base class.
3588 - ordered_member_list contains all properties indexers and methods
3589 that are not defined as explicit implementation of an interface
3592 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
3593 functionality in these removed classes has been replaced with
3594 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
3595 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
3597 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
3598 to CheckForDuplications inside GetMethod and SetMethod Define Method
3599 to handle method property and indexer name conflicts.
3603 All code is contributed under the MIT/X11 license.
3605 2007-03-20 Martin Baulig <martin@ximian.com>
3607 * class.cs (TypeContainer.Interfaces): Removed; they're now
3608 included in `TypeContainer.Types'.
3610 2007-03-20 Martin Baulig <martin@ximian.com>
3612 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
3614 * class.cs (TypeContainer.CreateType): New public method. This is
3615 now called before DefineType() to create the TypeBuilders.
3616 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
3617 has already been created by CreateType().
3618 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
3619 don't resolve our base classes here; this has been moved into
3620 DefineBaseTypes(). We're now called from CreateType().
3621 (TypeContainer.DefineBaseTypes): New private method; resolve our
3622 base classes here. We're now called from DefineType().
3625 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
3626 our types first to create all the TypeBuilders. After that, call
3627 TypeContainer.DefineType() on all the types which'll resolve their
3628 base classes and setup the resolve order.
3630 2007-03-20 Martin Baulig <martin@ximian.com>
3632 * class.cs (TypeContainer.Enums): Removed; they're now included in
3633 `TypeContainer.Types'.
3635 2007-03-20 Martin Baulig <martin@ximian.com>
3638 (TypeContainer.DefineType): Don't call ResolveMembers() here.
3639 (TypeContainer.DoResolveMembers): Call DefineType() on our
3640 `compiler_generated' classes; moved here from DefineNestedTypes().
3643 (RootContext.ResolveTree): Call ResolveMembers() on all
3644 TypeContainer's in the `type_container_resolve_order'.
3646 2007-03-19 Marek Safar <marek.safar@gmail.com>
3648 * class.cs: Use corlib to handle InternalMethodImplAttribute.
3650 2007-03-17 Marek Safar <marek.safar@gmail.com>
3652 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
3653 implementation flags.
3655 2007-03-17 Marek Safar <marek.safar@gmail.com>
3657 * class.cs: More optimizations for type parameters.
3659 2007-03-15 Marek Safar <marek.safar@gmail.com>
3661 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
3663 * ecore.cs, parameter.cs: More common code for both corlibs.
3665 * typemanager.cs (IsGenericMethod): Simplified.
3667 2007-03-15 Raja R Harinath <rharinath@novell.com>
3669 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3671 * statement.cs, iterators.cs, lambda.cs: Update to changes.
3673 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
3674 unconditionally. Simplify explanation.
3675 (Try.Resolve, Using.Resolve): Likewise.
3677 2007-03-15 Martin Baulig <martin@ximian.com>
3681 * decl.cs (DeclSpace): If we're a partial class, use our
3682 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
3684 2007-03-15 Raja R Harinath <rharinath@novell.com>
3686 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3688 (FlowBranching.UsageVector): Update to changes.
3689 (FlowBranching.MergeSiblings): Likewise.
3690 * statement.cs: Likewise.
3692 2007-03-15 Martin Baulig <martin@ximian.com>
3697 (MemberCache): Added a special .ctor for type parameters.
3700 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
3703 2007-03-09 Martin Baulig <martin@ximian.com>
3705 * enum.cs (Enum): Make this a TypeContainer.
3706 (EnumMember): Derive from `Const'.
3709 (Const.DoResolveValue): New protected virtual method; move most of
3710 the functionality of ResolveValue() here so we can override it in
3712 (Const.CreateConstantReference): Make this virtual.
3714 * class.cs (Kind): Add `Kind.Enum'.
3715 (TypeContainer.Emit): Don't emit the enums here; they're already
3716 in the `RootContext.typecontainer_resolve_order'.
3718 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
3719 here; they're already in the `typecontainer_resolve_order'.
3721 * ecore.cs (EnumConstant.ConvertImplicitly): Add
3722 TypeManager.DropGenericTypeArguments().
3725 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
3726 (TypeManager.IsEnumType): Likewise.
3727 (TypeManager.EnumToUnderlying): Likewise.
3728 (TypeManager.IsEqual): Add support for enums.
3730 2007-03-12 Raja R Harinath <rharinath@novell.com>
3732 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
3733 DefaultParameterValueAttribute to be undefined, say if System.dll
3736 2007-03-11 Marek Safar <marek.safar@gmail.com>
3738 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
3741 2007-03-10 Marek Safar <marek.safar@gmail.com>
3743 * class.cs, parameter.cs: Unified parameters verification.
3745 2007-03-08 Martin Baulig <martin@ximian.com>
3747 * cs-parser.jay (constructor_header): Pass the location to the
3748 newly created TopLevelBlock.
3750 2007-03-07 Martin Baulig <martin@ximian.com>
3752 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
3754 2007-03-06 Miguel de Icaza <miguel@novell.com>
3756 * convert.cs (ExplicitReferenceConversionExists): Sync this method
3757 with the changes from David, fixes the build.
3759 2007-03-05 David Mitchell <dmitchell@logos.com>
3761 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
3762 and its base interfaces to a one-dimensional array type S[],
3763 provided there is an implicit or explicit reference conversion
3766 2007-03-03 Marek Safar <marek.safar@gmail.com>
3768 * cs-tokenizer.cs: Implemented basic linq grammar.
3770 * driver.cs: Set linq lang version on demand.
3772 2007-02-26 Marek Safar <marek.safar@gmail.com>
3774 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
3776 2007-02-25 Marek Safar <marek.safar@gmail.com>
3778 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
3781 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
3783 Check property and event extern attributes.
3785 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
3788 2007-02-24 Marek Safar <marek.safar@gmail.com>
3790 A fix for bug #80407
3791 * ecore.cs: Don't report ambiguity error when methods have same parent.
3793 2007-02-23 Marek Safar <marek.safar@gmail.com>
3795 A fix for bug #80878
3796 * class.cs, cs-parser.jay: Event property can host anonymous methods.
3798 2007-02-22 Marek Safar <marek.safar@gmail.com>
3800 * attribute.cs: Enable ExtensionAttribute presence test.
3802 2007-02-22 Marek Safar <marek.safar@gmail.com>
3804 * class.cs: Warn about missing GetHashCode only when Equals is override.
3806 * decl.cs: Check accessibility of type arguments.
3808 * typemanager.cs: Correctly report nullable array.
3810 2007-02-20 Marek Safar <marek.safar@gmail.com>
3812 * class.cs, report.cs: Capture more details when things go wrong.
3814 2007-02-20 Marek Safar <marek.safar@gmail.com>
3816 A fix for bug #80650
3817 * cs-parser.jay: Anonymous container starts at constructor declaration
3818 and not at block beginning because it has to be usable in constructor
3821 * statement.cs: Use context location and not block one for error reporting.
3823 2007-02-18 Marek Safar <marek.safar@gmail.com>
3825 A fix for bug #78712
3826 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
3829 2007-02-18 Marek Safar <marek.safar@gmail.com>
3831 A fix for bug #80493 by Atsushi Enomoto
3832 * cs-parser.jay: Ignore invalid attribute target.
3834 2007-02-18 Marek Safar <marek.safar@gmail.com>
3836 * cs-tokenizer.cs: Ignore '\0' as white space character.
3838 2007-02-17 Miguel de Icaza <miguel@novell.com>
3840 * cs-parser.jay: Add support for lambda expressions to the mcs
3843 * lambda.cs: Only clone when we are probing, not on the final call
3844 (Compatible is the final call).
3846 * statement.cs (CloneContext): Introduce class to provide block
3847 remapping during clone.
3849 All statements Clone themselves now.
3851 (Clone): special handling for blocks, when we clone a block, we
3852 register the block inside this routine, as children of the block
3853 might trigger a lookup.
3855 * expression.cs: Add support for CloneContext in all expressions.
3857 2007-02-17 Marek Safar <marek.safar@gmail.com>
3859 A fix for bug #80493
3860 * statement.cs: Report ambiguous warning when interfaces are not related.
3862 2007-02-15 Marek Safar <marek.safar@gmail.com>
3864 C# 3.0 extension methods.
3866 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
3867 cannot be used directly.
3869 * class.cs (Class.Emit): Emit extension attribute if any class method
3870 is extension method.
3871 (Method.Define): Add basic extension method validation conditions.
3872 (Method.Emit): Emit extension attribute for method.
3874 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
3875 extension method exists. Currently we follow same approach as Microsoft
3876 does, emit even if a method or a class are private but this can change
3879 * cs-parser.jay: Add handling of `this' keyword in method parameters
3882 * decl.cs (DeclSpace.IsStaticClass): New property.
3883 (MemberCache.FindExtensionMethods): Looks for extension methods with
3884 defined name and extension type.
3886 * doc.cs: Updated after OverloadResolve changes.
3888 * driver.cs: Add new soft reference to System.Core.dll.
3890 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
3891 (ExtensionMethodGroupExpr): Represents group of extension methods.
3893 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
3894 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
3895 to MethodGroupExpr and made non-static for easier customization.
3896 (Invocation.DoResolve): Add extension method lookup when no standard
3898 (MemberAccess.DoResolve): Try extension methods if no member exists.
3900 * modifiers.cs: Add METHOD_EXTENSION modifier.
3902 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
3903 as well as candidate extension type.
3904 (ComputeNamespaces): When assembly constains extension methods registers
3906 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
3907 extension method lookup.
3908 (Namespace.LookupExtensionMethod): Looks for extension method in this
3910 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
3911 find a method which matches name and extensionType.
3913 * parameter.cs (Parameter): Add This modifer.
3914 (HasExtensionMethodModifier): New property.
3915 (Resolve): Add extension parameter check.
3916 (ModFlags): turned to property to exclude this modifier as it is not real
3918 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
3920 * support.cs (ParameterData): Add ExtensionMethodType.
3921 (ReflectionParameters): Implemented ExtensionMethodType interface property.
3923 * typemanager.cs: Add type and ctor extension attribute type.
3925 2007-02-15 Miguel de Icaza <miguel@novell.com>
3927 * report.cs (DisableErrors, EnableErrors): used to prevent error
3928 output when we are "trying" to compile various methods with
3931 * ecore.cs (Expression): Add Clone method that calls the virtual
3932 CloneTo method. The current CloneTo method in Expression throws
3933 an exception so we can track down all the places where this must
3934 be implemented (not using abstract, because that would be a lot of
3935 up-front-work before we can start testing the implementation
3938 Important: we only need Clone capabilities for expressions created
3939 by the parser, as the expressions we will be cloning are
3940 expressions in the pre-resolved state. This vastly simplifies
3943 (SimpleName): Add CloneTo that does nothing.
3944 (EmptyCast): Add CloneTo.
3946 * expression.cs (Binary): Implement CloneTo.
3947 (Invocation.IsApplicable): Store the current ec in
3948 EmitContext.TempEc and restore it on return. This is used so we
3949 do not have to sprinkle hundres of methods with an extra
3950 EmitContext, we know that the only user is the lambda expression
3951 ImplicitConversionExists code.
3953 (Argument): Add Cloning capabilities.
3954 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
3955 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
3956 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
3957 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
3958 IndexerAccess): Add Clone capability.
3960 (LocalVariableReference, This): TODO: needs cloned Block mapping.
3962 (Argument): Add cloning capability.
3964 * assign.cs (Assign): Implement CloneTo.
3966 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
3968 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
3969 version by calling Convert with the EmitContext (that we are
3970 currently storing in ec, this is not great, but will do for now,
3971 to avoid passing EmitContext parameters to hundreds of functions
3972 that do not need them now).
3974 (SetExpression): Remove, it is not needed.
3976 (ContextualReturn): Implement CloneTo.
3978 * statement.cs (Statement): Implement cloning infrastructure,
3979 similar to expressions.
3981 (Block): Partial implementation of Clone for statements.
3983 (Return): Implement clone.
3985 * constant.cs (Constant.CloneTo): New method, does nothing.
3987 * codegen.cs (TempEc): Add a static EmitContext as a temporary
3988 solution, until we decide how to exactly do this.
3990 2007-02-14 Marek Safar <marek.safar@gmail.com>
3992 A fix for bug #80493
3993 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
3994 a property is override we need to use second accessor.
3996 2007-02-13 Marek Safar <marek.safar@gmail.com>
3998 A fix for bug #80418
3999 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
4002 2007-02-13 Marek Safar <marek.safar@gmail.com>
4004 Another fix for bug #80749
4005 * pending.cs: Abstract class has priority over interfaces.
4007 2007-02-13 Marek Safar <marek.safar@gmail.com>
4009 Another fix for bug #80749
4010 * pending.cs: Abstract class has priority over interfaces.
4012 2007-02-13 Marek Safar <marek.safar@gmail.com>
4014 Another fix for bug #80749
4015 * pending.cs: Abstract class has priority over interfaces.
4017 2007-02-13 Marek Safar <marek.safar@gmail.com>
4019 Another fix for bug #80749
4020 * pending.cs: Abstract class has priority over interfaces.
4022 2007-02-13 Marek Safar <marek.safar@gmail.com>
4024 * class.cs Better error message.
4026 * driver.cs: Add shorter versions of -optimize option.
4028 2007-02-13 Martin Baulig <martin@ximian.com>
4030 * class.cs (Constructor.Emit): Check the return value of
4031 ec.ResolveTopBlock() and return on error.
4033 2007-02-13 Raja R Harinath <rharinath@novell.com>
4035 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
4036 message to fix error message regression.
4038 2007-02-12 Marek Safar <marek.safar@gmail.com>
4040 * delegate.cs: Delegate creation expression cannot be of Nullable type.
4042 2007-02-12 Marek Safar <marek.safar@gmail.com>
4044 A fix for bug #80749
4045 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
4046 its parent container.
4048 * class.cs (DefineFieldInitializers): Each initializer can has different
4051 * const.cs: Updated.
4053 2007-02-11 Miguel de Icaza <miguel@novell.com>
4055 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
4056 now all the heavy lifting to check that embedded statements or
4057 expressions have the right form is done in the ContextualReturn.
4059 (ContextualReturn): New class.
4061 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
4062 method that can be invoked to report 201, so we do not replicate
4065 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
4067 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
4068 treating tabs as spaces.
4070 2007-02-09 Marek Safar <marek.safar@gmail.com>
4072 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
4073 * assign.cs: Use full implicit conversion for right side check.
4075 2007-02-09 Marek Safar <marek.safar@gmail.com>
4077 * statement.cs (Switch): Switch over boolean type is not standardized.
4079 2007-02-08 Marek Safar <marek.safar@gmail.com>
4081 A fix for bug #80755
4082 * decl.cs (FindBaseEvent): Don't use method cache for events.
4084 2007-02-07 Marek Safar <marek.safar@gmail.com>
4086 * cs-parser.jay: Better syntax error handling.
4088 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
4089 instead of underlying type value.
4091 2007-02-06 Marek Safar <marek.safar@gmail.com>
4093 * driver.cs: Check define identifier before is registered.
4095 * namespace.cs: Use existing error message.
4097 * report.cs: New warning.
4099 2007-02-06 Marek Safar <marek.safar@gmail.com>
4101 A fix for bug #80742
4102 * expression.cs: Delegate Invoke method can be called directly.
4104 2007-02-06 Marek Safar <marek.safar@gmail.com>
4106 A fix for bug #80676
4107 * class.cs (IsEntryPoint): The Main method can have params modifier.
4109 2007-02-04 Miguel de Icaza <miguel@novell.com>
4111 * parameter.cs (Parameter, Parameters): Add Clone method.
4113 * anonymous.cs (Compatible): Turn method into virtual method, so
4114 LambdaExpression can implement a different behavior.
4116 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
4117 out the basic checking here, so it can be used by
4120 * lambda.cs: Introduce "Compatible" function that will do the
4123 2007-02-02 Marek Safar <marek.safar@gmail.com>
4125 * attribute.cs: Unified one error message.
4127 * class.cs (Class): Use type attributes and not properties to test static
4129 (IsEntryPoint): Don's pass local variable.
4131 * convert.cs: Removed duplicate check.
4133 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
4135 * driver.cs: Don't crash when soft reference does not exist.
4137 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
4138 (UsingEntry): Removed redundant allocation.
4140 * parameter.cs: Add fast path for type parameters.
4142 * support.cs: Don't allocate attribute when it's not used.
4144 2007-01-30 Miguel de Icaza <miguel@novell.com>
4147 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
4148 this into a virtual method, so we can override it in LambdaExpression.
4150 * driver.cs: Improve diagnostics in case of failure.
4152 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
4153 write a function that is slightly more complex and that parses:
4155 type identifier [, type identifier]* )
4157 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
4160 (canEmpty ? i >= 0 : i > 0)
4162 2007-01-30 Raja R Harinath <rharinath@novell.com>
4164 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
4165 exception on possibly valid code.
4167 2007-01-29 Raja R Harinath <rharinath@novell.com>
4169 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
4171 (parse_opt_type_arguments): Remove. It's almost the same as
4173 (parse_namespace_or_typename): Use parse_less_than.
4175 2007-01-28 Miguel de Icaza <miguel@novell.com>
4177 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
4178 this bug took a few hours to find, because the state saved and
4179 restored by PushPosition and PopPosition was ignoring the state of
4180 parse_generic_less_than.
4182 I can also now remove the handling of OP_LT and OP_GT, this solves
4185 * cs-tokenizer.cs: store the location for the ARROW token, we use
4188 (PushPosition, PopPosition): save/restore also `current_token',
4189 restore `parse_generic_less_than' (was missing).
4191 (parse_opt_type_arguments): use parse_type, not
4192 parse_namespace_or_typename to parse types.
4194 * lambda.cs: Empty new file, will eventually have the lambda
4195 expression implementation.
4197 * lambda.test: used to test the internal tokenizer.
4199 * report.cs (FeatureIsNotISO1): Rename from
4200 FeatureIsNotStandardized, because it was about the language level
4201 (1 vs 2) it was not about standarization.
4203 (FeatureRequiresLINQ): New.
4205 * support.cs (SeekableStreamReader): Only require that the reader
4206 is a TextReader, not a StreamReader, so we can plug StringReader.
4208 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
4209 given position in the input stream the following tokens can be
4210 parsed as a type followed by an identifier.
4212 (is_punct): after a '(' if parse_type_and_parameter returns true,
4213 then return a special token OPEN_PARENS_LAMBDA which is used to
4214 avoid reduce/reduce errors in the grammar for the
4215 lambda_expression rules.
4217 (parse_type): implement a type parser inside the
4218 tokenizer, the parser only returns true or false depending on
4219 whether the input at a given position can be parsed as a type.
4221 (peek_token): new method used during type parsing.
4223 2007-01-28 Raja R Harinath <rharinath@novell.com>
4226 * anonymous.cs (ScopeInfo.InflateParameters): New.
4227 (AnonymousContainer.Resolve): Use it to redirect types of
4228 delegate parameters.
4230 2007-01-27 Raja R Harinath <rharinath@novell.com>
4233 * expression.cs (Error_InvalidArguments): Don't use two different
4234 messages for CS1503. Use ExtraInformation and
4235 SymbolRelatedToPreviousError instead.
4238 * decl.cs (DeclSpace.initialize_type_params): Don't access
4239 'type_params' of a partial class directly.
4241 2007-01-26 Miguel de Icaza <miguel@novell.com>
4243 * constant.cs: Removed a handful of out-of-range checks that were
4246 2007-01-25 Marek Safar <marek.safar@gmail.com>
4248 * expression.cs (CheckUselessComparison): Add additional check for char
4251 * namespace.cs: Fixed typo.
4253 2007-01-23 Miguel de Icaza <miguel@novell.com>
4255 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
4256 gone, instead we inline the test, preventing the needless casts to
4257 longs, ulongs and doubles for the parameters, avoiding calls to
4258 methods that overchecked stuff, and instead inlined things
4261 2007-01-20 Marek Safar <marek.safar@gmail.com>
4263 * cs-parser.jay: Better parameter error handling.
4265 2007-01-17 Marek Safar <marek.safar@gmail.com>
4267 A fix for bug #80368, #80522
4268 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
4269 whether array initializer contains constants only.
4270 (ArrayCreation.Emit): Use better formula to decide when
4271 are array initializers for static initialization.
4272 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
4273 have to emit even constants otherwise they are pre-initialized.
4275 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
4276 Raja R Harinath <rharinath@novell.com>
4278 Fix emit order of 'get' vs. 'set'.
4279 * support.cs (Accessors): New.
4280 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
4281 Note the order in which accessors are declared in the source.
4282 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
4283 Refactored from Property.Define and Indexer.Define.
4284 (PropertyBase.DefineAccessors): New helper that calls the above in
4285 appropriate order as noted by the parser.
4286 (Property.Define, Indexer.Define): Update to changes.
4287 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
4289 2007-01-17 Raja R Harinath <rharinath@novell.com>
4291 Fix cs0029-6.cs and gcs0029-2.cs (regression)
4292 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
4293 there's an implicit conversion from the current type to the target
4294 type before converting the underlying constant.
4296 2007-01-16 Marek Safar <marek.safar@gmail.com>
4298 * const.cs (ResolveValue): Updated after constant conversion was made more
4301 * constant.cs (GetAttributableValue): constant to object conversion is
4302 used for attributes only.
4303 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
4304 constant conversions.
4305 (LongConstant.ConvertImplicitly): Ditto.
4307 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
4308 (ImplicitConversionStandard): Handle constant conversion as extra step.
4309 It solves the issue when constant conversion was called indirectly like
4310 inside array initializer and constant folding was skipped.
4312 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
4315 * statement.cs(ImplicitConversionStandard): Updated after constant
4316 conversion was made more generic.
4318 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
4320 * expression.cs (As.DoResolve): Use GenericConstraints instead of
4321 Constraints, solves the problem where the compiler incorrectly
4322 reported that a type parameter was not constrained to a class (Bug
4325 2007-01-14 Marek Habersack <grendello@gmail.com>
4327 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
4329 2007-01-14 Marek Safar <marek.safar@gmail.com>
4331 A fix for bug #80368
4332 * assign.cs (FieldInitializer): New class implements field
4333 initializer statement.
4335 * attribute.cs: Update after FieldMember rename.
4337 * class.cs (PropertyBasedMember): New common class for property based
4339 (InterfaceMemberBase): New base class for all members which can be used as
4340 an interface members.
4341 (MethodCore): Moved really common code to InterfaceMemberBase.
4342 (Method.Define): Equal and GetHasCode detection is relevant for methods
4344 (MethodData.Define): Don't assume that public event implements an
4345 interface automatically.
4346 (MethodData.DefineMethodBuilder): Issue an error even if only extern
4348 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
4349 (FieldMember): Merged with FieldBase.
4350 (EventProperty.AEventPropertyAccessor): New specialization to check whether
4351 event extern modifier can be used.
4352 (EventField.EventFieldAccessor): Moved event field specific code here.
4353 (Event.AllowedModifiers): Even event can be extern.
4354 (Event.FindOutBaseMethod): New override specific to events.
4355 (Indexer.parameters): Reintroduce parameters because base class holds
4356 only properties common data.
4357 (Indexer.CheckForDuplications): Indexers are threated as methods so we
4358 need do extra parameters check.
4360 * const.cs: Update after FieldMember rename.
4362 * decl.cs (MemberCache.FindBaseEvent): New method.
4364 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
4365 to reflect that indexer is now derived from PropertyBased.
4367 * ecore.cs (GetMemberType): Made public.
4368 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
4371 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
4373 * typemanager.cs (CSharpSignature): Correctly print event accessors.
4374 (RegisterEvent): Removed.
4375 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
4376 (GetPrivateFieldOfEvent): Renamed to GetEventField.
4378 2007-01-11 Raja R Harinath <rharinath@novell.com>
4381 * statement.cs (CollectionForeach.TryType): Prefer generic
4382 GetEnumerator over non-generic variant. Fix code to follow comments.
4384 2007-01-09 Raja R Harinath <rharinath@novell.com>
4387 * support.cs (ReflectionParameter): Don't use an invalid index on
4388 the generic parameter data.
4390 2007-01-08 Miguel de Icaza <miguel@novell.com>
4392 * driver.cs: Just add a tiny bit of infrastructure.
4394 2007-01-02 Marek Safar <marek.safar@gmail.com>
4396 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
4397 where field type is struct from current assembly.
4399 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
4402 2007-01-02 Marek Safar <marek.safar@gmail.com>
4404 A fix for bug #80381
4405 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
4408 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
4410 (Namespace.LookupType): Always use core types from corlib when speficied.
4412 * report.cs: A new warning.
4414 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
4415 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
4416 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
4418 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
4419 (InitCoreTypes): Set expression type of object_type and value_type
4420 immediately after lookup.
4422 2007-01-01 Miguel de Icaza <miguel@novell.com>
4424 * cs-tokenizer.cs: Accept Pc class characters (Connector
4425 Punctuation) as valid identifiers. Fixes #78259
4427 * expression.cs (Invocation.DoResolve): Moved the check for the
4428 use of `this' for doing method calls to the Invocation resolution
4429 step, after overload resolution has taken place instead of doing
4430 the check at the low-level `This.DoResolve' level.
4432 The `This.DoResolve'(appens before overload resolution, so it has
4433 no way of knowing if the method that will be called will be
4434 instace or static, triggering an erroneous report for cs0188 (Bug
4437 We now do the check for instance method invocations after we know
4438 what method will be called.
4440 (This.CheckThisUsage): Move the actual use of this structure
4441 checking into its own method and expose it.
4443 * Everywhere that called Error_ValueCannotBeConverted: pass a new
4446 Exceptions: Null.ConvertImplicitly,
4447 Constant.ImplicitConversionRequired as there are too many call
4448 sites for passing the ec.
4450 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
4451 EmitContext, if the value is null, then we do not try to provide
4452 the extra information from the error (If a userdefined conversion
4453 exists, as UserDefinedConversion requires a non null-EmitContext).
4457 2006-12-30 Raja R Harinath <rharinath@novell.com>
4459 * flowanalysis.cs (MyBitVector): Document some invariants.
4460 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
4461 introduced below, and add a couple of others,
4463 2006-12-30 Marek Safar <marek.safar@gmail.com>
4465 * attribute.cs (GetMethodObsoleteAttribute): Uses new
4466 GetPropertyFromAccessor and GetEventFromAccessor.
4468 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
4469 overrides non-obsolete one.
4470 (Indexer.Define): Error message has been moved to the parser.
4472 * cs-parser.jay: Better syntax errors handling.
4474 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
4475 when an invocation has no arguments.
4477 * ecore.cs: Removed not used caching.
4479 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
4482 * report.cs: Add a new warning.
4484 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
4486 * typemanager.cs (enumeration_type): Removed.
4487 (CSharpSignature): Reuses IsSpecialMethod.
4488 (IsEqual): Hack for MS BCL.
4489 (GetPropertyFromAccessor): New method.
4490 (GetEventFromAccessor): New method.
4491 (IsSpecialMethod): Fixed to handle more cases.
4493 2006-12-30 Marek Safar <marek.safar@gmail.com>
4495 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
4496 Made white spaces array static.
4498 * ecore.cs (RemoveGenericArity): Optimized.
4500 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
4502 (MyBitVector.initialize_vector): Simplified.
4504 2006-12-22 Miguel de Icaza <miguel@novell.com>
4506 * ecore.cs: Am not entirely happy with this hack, but it seems to
4507 address the issue in 80257 (a small test case for
4510 I set the MethodGroupExpr.Type to an internal compiler type
4511 (itself in this case) to force the resolution to take place. Why
4512 it does not take place with a null is beyond me.
4514 2006-12-20 Marek Safar <marek.safar@gmail.com>
4516 A fix for bug #80288
4517 * expression.cs (ResolveOperator): Consider user defined conversion for
4518 logical and operator too.
4519 (EmitBranchable): Optimization for logical and when full constant folding
4520 could not be applied but one operand is constant.
4522 2006-12-19 Marek Safar <marek.safar@gmail.com>
4524 * class.cs (GetClassBases): Write 5 times every day, will never use
4525 FullName for error reporting.
4527 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
4529 2006-12-19 Martin Baulig <martin@ximian.com>
4531 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
4532 the symbol file info here.
4534 2006-12-18 Marek Safar <marek.safar@gmail.com>
4536 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
4537 of `elseif' is taking then following sections are not taking.
4538 Fixes an issue reported on mono mailing list.
4540 2006-12-18 Marek Safar <marek.safar@gmail.com>
4542 A fix for bug #80300
4543 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
4544 a caller is not taking.
4546 2006-12-18 Raja R Harinath <rharinath@novell.com>
4548 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
4549 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
4550 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
4551 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
4552 * class.cs: Update to changes.
4554 2006-12-17 Marek Safar <marek.safar@gmail.com>
4556 A fix for bug #79934
4557 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
4560 * class.cs (ResolveMembers): Register an iterator in current container and
4563 2006-12-16 Raja R Harinath <rharinath@novell.com>
4566 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
4567 satisfy a params annotated parameter.
4569 2006-12-16 Marek Safar <marek.safar@gmail.com>
4571 A fix for bug #77014
4572 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
4573 paramters correctly and not rely on hacks in Parameters class.
4574 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
4576 (Invocation.VerifyArgumentsCompat): Ditto.
4577 (Invocation.EmitArguments): Changed to correctly emit params arguments at
4580 * parameter.cs (HasParams): Don't assume that params is the last one.
4582 * support.cs (ReflectionParameters.ctor): Look for params attribute
4584 (ReflectionParameters.ParameterType): Removed hack when we returned last
4585 parameter for out of range parameters.
4586 (ParameterName, ParameterModifier): Ditto.
4588 2006-12-14 Marek Safar <marek.safar@gmail.com>
4590 A fix for bug #79987
4591 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
4592 when assembly is not CLS compliant but type is. I have no idea why is this
4595 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
4597 2006-12-13 Miguel de Icaza <miguel@novell.com>
4599 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
4600 in struct constructors, they are basically no-ops.
4602 2006-12-12 Marek Safar <marek.safar@gmail.com>
4604 * cs-tokenizer.cs (Position): Save preprocessor status too.
4606 2006-12-12 Marek Safar <marek.safar@gmail.com>
4608 A fix for bug #77794
4609 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
4611 2006-12-12 Marek Safar <marek.safar@gmail.com>
4613 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
4615 (pp_expr): Report error for an invalid expression.
4616 (handle_preprocessing_directive): Simplified; add more error checking.
4618 2006-12-11 Marek Safar <marek.safar@gmail.com>
4620 A fix for bug #74939
4621 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
4622 directives handling.
4624 2006-12-10 Marek Safar <marek.safar@gmail.com>
4626 A fix for bugs #80093, and #75984
4627 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
4628 logic, it seems to me as it worked before "by coincidence".
4629 (xtoken): Simplified to use reworked handle_preprocessing_directive.
4630 (cleanup): Enabled endif check.
4632 2006-12-09 Marek Safar <marek.safar@gmail.com>
4634 A fix for bug #80162
4635 * statement.cs (CollectionForeach.TryType): Generics and non-generics
4636 enumerators are never ambiguous.
4638 2006-12-08 Raja R Harinath <rharinath@novell.com>
4641 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
4643 2006-12-06 Marek Safar <marek.safar@gmail.com>
4645 A fix for bug #80144
4646 * class.cs (EventProperty.Define): Explicit implementation means
4647 that an even is used.
4649 2006-12-06 Marek Safar <marek.safar@gmail.com>
4651 Fixes the operators implementation (part II)
4653 * cfold.cs (DoConstantNumericPromotions): Renamed to
4654 DoBinaryNumericPromotions and simplified.
4655 (BinaryFold): Couple of conversion fixes; simplified.
4657 * constant.cs, ecore.cs, literal.cs
4658 (ToType): Renamed to ConvertImplicitly.
4659 (Reduce): Renamed to ConvertExplicitly.
4661 * class.cs, convert.cs: Updated.
4663 * expression.cs: TryReduce doesn't throw an exception.
4665 2006-12-01 Marek Safar <marek.safar@gmail.com>
4667 A fix for bug #80108
4668 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
4671 2006-11-30 Marek Safar <marek.safar@gmail.com>
4673 Fixes unary operators implementation (part I)
4676 * cfold.cs (Error_CompileTimeOverflow): Made internal
4678 * const.cs (IConstant): Changed to use reference to constant and
4679 not constant itself.
4680 Updated IConstant implementations.
4682 * constant.cs (CreateConstant): New factory method.
4683 Updated IConstant implementation.
4685 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
4687 * ecore.cs: Updated to use CreateConstantReference.
4689 * enum.cs: Reflects IConstant changes.
4691 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
4693 * literal.cs (NullConstant): Change to be independently usable.
4695 2006-11-29 Martin Baulig <martin@ximian.com>
4697 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
4698 we need to emit the scope initializer before calling the base .ctor.
4700 * anonymous.cs: Merged back from the new anonymous methods branch.
4701 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
4703 * expression.cs (ParameterReference.DoResolveBase): Create a
4704 "normal" ScopeInfo when capturing parameters rather than using the
4705 root scope; this makes things work with anonymous methods having
4709 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
4711 2006-11-22 Marek Safar <marek.safar@gmail.com>
4713 A fix for bug #79987
4714 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
4715 check to a base class.
4716 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
4717 only when assembly has missing attribute.
4718 * report.cs: Update.
4720 2006-11-21 Marek Safar <marek.safar@gmail.com>
4722 * cs-tokenizer.cs: Merged with gmcs version.
4724 2006-11-20 Marek Safar <marek.safar@gmail.com>
4727 * cs-parser.jay: Better error message when partial keyword is misplaced.
4729 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
4731 A fix for bug #79810
4732 report.cs: CS1058 only applies to 2.0 profile (gmcs).
4733 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
4734 a RuntimeWrappedException by default.
4736 2006-11-18 Marek Safar <marek.safar@gmail.com>
4738 A fix for bug #79843
4739 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
4741 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
4743 2006-11-18 Marek Safar <marek.safar@gmail.com>
4745 * driver.cs, namespace.cs: Uses faster IndexOf version.
4747 2006-11-17 Marek Safar <marek.safar@gmail.com>
4749 A fix for bug #79941
4750 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
4752 (Operator.Define): Implicit/Explicit operator of same type is duplicate
4753 even if internal name is different.
4754 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
4755 (UserDefinedConversion): Simplified as the operators cannot be internal.
4756 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
4758 (MethodLookup): Replaced EmitContext with parentType.
4759 * expression.cs: Updated.
4761 2006-11-09 Raja R Harinath <rharinath@novell.com>
4763 * driver.cs (BadAssembly): Handle all the ugliness of
4764 DefineDynamicAssembly.
4766 2006-11-08 Raja R Harinath <rharinath@novell.com>
4768 Address parts of #58244 -- most of what's left is in the runtime
4769 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
4770 CS1509 error checks, and handle them for all assembly loads, not
4771 just the first invocation.
4772 (LoadModule): Likewise. Move handling of 'adder_method' ...
4773 * codegen.cs (AssemblyClass.AddModule): ... here.
4775 2006-11-02 Marek Safar <marek.safar@gmail.com>
4777 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
4778 IEnumerable<T> is ambiguous.
4780 2006-10-31 Marek Safar <marek.safar@gmail.com>
4782 A fix for bug #67689
4783 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
4784 GetEnumerator is ambiguous.
4786 * report.cs: Add new warning.
4788 2006-10-29 Marek Safar <marek.safar@gmail.com>
4790 A fix for bug #78602
4791 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4792 to protected member can be nested type.
4794 2006-10-28 Marek Safar <marek.safar@gmail.com>
4796 A fix for bug #78965
4797 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4798 to protected member must derive from current type.
4800 2006-10-27 Marek Safar <marek.safar@gmail.com>
4802 assign.cs: Reuses error method.
4804 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
4805 instead of type for constants.
4806 (Expression.Error_ValueAssignment): Common error method.
4808 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
4811 2006-10-27 Marek Safar <marek.safar@gmail.com>
4813 A fix for bug #79081
4814 * expression.cs (MemberAccess.DoResolve): Check nested type
4817 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
4819 * doc.cs : nested delegates were not handled. Fixed bug #79754.
4821 2006-10-26 Marek Safar <marek.safar@gmail.com>
4823 A fix for bug #76591
4824 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
4826 2006-10-26 Marek Safar <marek.safar@gmail.com>
4828 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
4829 type forwarder of the same type multiple times.
4831 2006-10-26 Raja R Harinath <rharinath@novell.com>
4834 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
4835 instance as an rvalue, even when we later resolve as an lvalue.
4837 2006-10-25 Martin Baulig <martin@ximian.com>
4839 * anonymous.cs: Fix #79673.
4841 2006-10-24 Marek Safar <marek.safar@seznam.cz>
4843 A fix for bug #79666
4844 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
4845 ignored when is optimized (= default value) as its value is already set.
4847 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4849 A fix for bug #79724
4850 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
4851 TypeContainer for type lookup.
4853 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4855 A fix for bug #79231
4856 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
4857 * expression.cs (OverloadResolve): Always convert type name for
4859 (ResolveNamespaceOrType): Don't confuse a nested type with any
4862 2006-10-18 Martin Baulig <martin@ximian.com>
4864 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
4866 2006-10-17 Miguel de Icaza <miguel@novell.com>
4868 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
4869 an int32, but requesting an int64 from the conversion
4871 2006-10-12 Martin Baulig <martin@ximian.com>
4874 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
4876 2006-10-12 Martin Baulig <martin@ximian.com>
4879 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
4881 2006-10-11 Miguel de Icaza <miguel@novell.com>
4883 * convert.cs: Remove broken code: I was doing the "Existance"
4884 tests for Implicit conversions.
4886 2006-10-10 Miguel de Icaza <miguel@novell.com>
4888 * convert.cs: Added one missing case in
4889 ImplicitStandardConversionExists uint64 to intptr.
4893 * typemanager.cs (uintptr_type): another core known type.
4895 * ecore.cs (OperatorCast): routine used to do cast operations that
4896 depend on op_Explicit. We could change some of the Decimal
4897 conversions to use this.
4899 This one has a probe mechanism that checks both types for an op_
4900 which it coudl be used to eliminate two classes: CastToDecimal
4901 and CastFromDecimal.
4903 * convert.cs: Implement the conversions documented in #59800
4905 2006-10-10 Martin Baulig <martin@ximian.com>
4907 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
4908 before RootScope.ResolveMembers().
4910 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
4911 `CurrentType' if appropriate.
4913 2006-10-09 Marek Safar <marek.safar@seznam.cz>
4915 A fix for bug #78568
4916 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
4917 when contains binary operators.
4918 * cs-parser.jay: Updated.
4920 2006-10-09 Martin Baulig <martin@ximian.com>
4923 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
4924 moved that into Define() and also do the other type parameter
4925 checks there. Fixes #79094. Added gtest-292.cs.
4928 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
4929 since that doesn't include type parameters; don't use `Ldelema'
4930 for type parameters. Fixes #78980. Added gtest-293.cs.
4932 2006-10-08 Marek Safar <marek.safar@seznam.cz>
4935 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
4936 conversion is allowed.
4938 2006-10-06 Marek Safar <marek.safar@seznam.cz>
4940 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
4941 error reporting when no error occurs.
4943 2006-10-06 Marek Safar <marek.safar@seznam.cz>
4945 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
4948 2006-10-06 Raja R Harinath <rharinath@novell.com>
4951 * class.cs (DefineTypeBuilder): Check circular dependencies before
4952 setting the parent of the TypeBuilder.
4953 (CheckRecursiveDefinition): Don't use 'BaseType', since
4954 it may not be valid until after DefineTypeBuilder. Use
4955 'base_type' instead.
4957 2006-10-04 Martin Baulig <martin@ximian.com>
4959 Merged the Anonymous Methods patch.
4961 * anonymous.cs, iterators.cs: The new anonymous methods code.
4963 * statement.cs (Variable): New public abstract class.
4964 (LocalInfo.Variable): New public property.
4965 (LocalInfo.ResolveVariable): New public method.
4966 (Block.Flags): Add `IsIterator'.
4967 (Block.AddVariable): Improved the CS0136 check.
4968 (Block.AnonymousChildren): New public property.
4969 (Block.AddAnonymousChild): New public method.
4970 (ToplevelBlock): Update to use the new anonymous method framework.
4971 (ToplevelBlock.ctor): `container' is now a `Block' and not a
4972 `ToplevelBlock'; this is required to correctly implement the
4974 (Fixed, Using): Use `TemporaryVariable' instead of directly
4975 creating the `LocalBuilder'.
4977 * parameter.cs (Parameter.ResolveVariable): New public method.
4978 (Parameters.ResolveVariable): Likewise.
4980 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
4982 * class.cs (TypeContainer): Replaced the `iterators' list and
4983 corresponding methods with a list of `CompilerGeneratedClass'es.
4984 (TypeContainer.ResolveMembers): New public method.
4985 (Method): `IIteratorContainer' has been replaced by
4988 * expression.cs (VariableReference): New public abstract base
4989 class for `LocalVariableReference', `ParameterReference' and
4992 * codegen.cs (EmitContext): Removed `capture_context',
4993 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
4994 (EmitContext.EmitThis): Removed.
4996 * cs-parser.jay: Replace `iterator_container' with
4999 2006-10-04 Martin Baulig <martin@ximian.com>
5001 * generic.cs (GenericMethod): Don't make this abstract.
5002 (Constraints.Clone): Added dummy implementation.
5004 2006-10-04 Raja R Harinath <harinath@gmail.com>
5007 * namespace.cs (LookForAnyGenericType): Avoid nullref on
5008 'declspaces'. Avoid allocating arrays willy-nilly.
5011 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
5012 cases out of the switch.
5014 2006-09-28 Marek Safar <marek.safar@seznam.cz>
5016 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
5017 message when non-generic type is used with the type arguments.
5018 * expression.cs: Updated.
5020 2006-09-28 Raja R Harinath <rharinath@novell.com>
5023 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
5024 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5025 Change semantics slightly. Don't insist on having only one
5026 temporary EmptyExpression -- just throttle the creation of new ones.
5029 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
5030 non-interfaces too. If no methods are found, don't try to create
5033 2006-09-28 Marek Safar <marek.safar@seznam.cz>
5035 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
5038 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
5039 us produce better error message.
5041 2006-09-27 Marek Safar <marek.safar@seznam.cz>
5043 * expression.cs (Binary.ResolveOperator): Warn about a side effect
5044 of the `|' operator.
5046 * report.cs: A new warning added.
5048 2006-09-27 Martin Baulig <martin@ximian.com>
5050 * generic.cs (GenericMethod): Don't make this abstract.
5052 2006-09-27 Martin Baulig <martin@ximian.com>
5055 (InternalErrorException): Added overloaded ctor taking a params array.
5057 2006-09-26 Marek Safar <marek.safar@seznam.cz>
5059 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
5060 Fixed the cases when same error was reported twice.
5062 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
5063 now report symbol information.
5065 2006-09-25 Martin Baulig <martin@ximian.com>
5067 * class.cs: Completely unified with the gmcs version.
5069 2006-09-25 Martin Baulig <martin@ximian.com>
5071 * typemanager.cs (TypeManager.IsNullableType): New public function.
5072 (TypeManager.IsNullableTypeOf): Likewise.
5073 (TypeManager.IsNullableValueType): Likewise.
5075 * class.cs (MethodCore): Added the `GenericMethod' argument from
5076 gmcs and also unified all classes derived from `MethodCore' with gmcs.
5078 2006-09-24 Raja R Harinath <harinath@gmail.com>
5080 * convert.cs: Unify with gmcs version.
5082 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5084 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
5085 verify them as well.
5087 * report.cs: New warning.
5089 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5091 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
5092 for anonymous block with out argument.
5094 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5096 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
5097 not used private events only.
5099 2006-09-23 Marek Safar <marek.safar@seznam.cz>
5101 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
5103 * const.cs (Const.Define): Check for constant type.
5104 (Const.IsConstantTypeValid): Looks for valid constant types.
5106 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
5108 * ecore.cs (EmptyConstantCast): New common class for all constant based
5111 * expression.cs (Is.DoResolve): Handle null constant especially.
5112 (New.DoResolve): Check for new void().
5113 (MemberAccess.DoResolve): Cope with all kind of nulls.
5115 * literal.cs (NullConstant): Uses EmptyConstantCast.
5116 (NullDefault): Based on EmptyConstantCast.
5117 (NullLiteral): Uses EmptyConstantCast.
5119 * statement.cs (Block.ResolveMeta): Check for constant type.
5121 2006-09-22 Martin Baulig <martin@ximian.com>
5123 * delegate.cs, attribute.cs: Merged with the gmcs versions.
5125 2006-09-22 Raja R Harinath <rharinath@novell.com>
5127 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
5131 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
5132 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
5135 2006-09-22 Martin Baulig <martin@ximian.com>
5137 * ecore.cs: Merged with the gmcs version.
5139 * generic.cs (ConstructedType): New dummy class.
5140 (TypeArguments): Don't make this abstract.
5143 (TypeManager.IsGenericTypeDefinition): New method.
5144 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
5146 2006-09-22 Raja R Harinath <rharinath@novell.com>
5148 * expression.cs (ComposedCast): Check for arrays of TypedReference
5149 before creating the type, not after.
5151 2006-09-21 Marek Safar <marek.safar@seznam.cz>
5153 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
5154 after ToType change.
5156 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
5157 when constant must be implicitly convertible.
5159 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
5161 * ecore.cs (NullCast): Derives from NullConstant.
5163 * expression.cs (Is.DoResolve): Removed useless variables.
5164 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
5165 (New.Constantify): Add enum support.
5166 (MemberAccess.DoResolve): Add warning when accessing null constant or
5169 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
5172 * literal.cs (NullConstant): New abstract class with common
5173 functionality for all null specializations.
5174 (NullDefault): Represents default(X) when result can be
5176 (NullLiteral): Updated.
5178 * report.cs: Add new warning.
5180 2006-09-21 Martin Baulig <martin@ximian.com>
5182 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
5184 2006-09-21 Martin Baulig <martin@ximian.com>
5186 * generic.cs (GenericConstraints): New dummy class.
5187 (Constraints): Likewise.
5188 (TypeParameter): Likewise.
5189 (TypeParameterName): Likewise.
5190 (GenericMethod): Likewise.
5192 * typemanager.cs (TypeManager.GetGenericArguments): New method.
5194 * decl.cs: Merged with the gmcs version.
5196 2006-09-21 Raja R Harinath <rharinath@novell.com>
5198 * generic.cs (TypeParameter): Implement IMemberContainer.
5199 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
5201 * rootcontext.cs: Unify with gmcs version.
5203 * report.cs: Unify with gmcs version.
5204 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
5205 from gmcs/generics.cs.
5206 * generics.cs (TypeParameter): New dummy class.
5208 * support.cs: Unify with gmcs version.
5210 2006-09-20 Raja R Harinath <rharinath@novell.com>
5212 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
5213 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
5215 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
5216 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
5217 * mcs.exe.sources: Add generic.cs.
5219 * codegen.cs: Unify with gmcs version.
5221 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
5222 (EmitContext): Add GenericDeclContainer implementation.
5223 * decl.cs (MemberCore, DeclSpace): Likewise.
5224 * namespace.cs: Remove #ifdef GMCS_SOURCE.
5226 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
5227 MCS TypeManager has a corresponding dummy method.
5229 2006-09-19 Martin Baulig <martin@ximian.com>
5231 * expression.cs: Completely merged with the gmcs version.
5233 2006-09-19 Martin Baulig <martin@ximian.com>
5235 * expression.cs (Invocation): Merged with the gmcs version.
5236 (ArrayAccess.GetStoreOpcode): Likewise.
5238 2006-09-19 Martin Baulig <martin@ximian.com>
5241 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
5242 (TypeManager.IsGenericMethodDefinition): Likewise.
5244 2006-09-19 Martin Baulig <martin@ximian.com>
5247 (TypeManager.IsEqual): Moved the gmcs implementation here.
5248 (TypeManager.DropGenericTypeArguments): Likewise.
5249 (TypeManager.DropGenericMethodArguments): Likewise.
5250 (TypeManager.GetTypeArguments): Moved here from gmcs.
5251 (TypeManager.HasGenericArguments): Likewise.
5253 2006-09-19 Martin Baulig <martin@ximian.com>
5255 * expression.cs (Binary): Merged with the gmcs version.
5257 2006-09-19 Martin Baulig <martin@ximian.com>
5259 * expression.cs (Probe, As, Is): Merged with the gmcs version.
5261 2006-09-19 Martin Baulig <martin@ximian.com>
5263 * typemanager.cs: Merged with the gmcs version.
5265 2006-09-16 Raja R Harinath <rharinath@novell.com>
5267 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
5268 * driver.cs: Likewise.
5270 2006-09-16 Marek Safar <marek.safar@seznam.cz>
5273 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
5274 only if parent type is class.
5275 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
5278 2006-09-15 Marek Safar <marek.safar@seznam.cz>
5281 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
5283 * typemanager.cs(CSharpName): Converts NullType to null.
5285 2006-09-15 Martin Baulig <martin@ximian.com>
5288 (TypeManager.GetMethodName): Added mcs implementation.
5289 (TypeManager.IsEqual): Likewise.
5292 (SimpleName.RemoveGenericArity): Added dummy implementation.
5294 * pending.cs: Merged with the gmcs version.
5296 2006-09-15 Martin Baulig <martin@ximian.com>
5298 * statement.cs: Merge with the gmcs version.
5300 2006-09-15 Martin Baulig <martin@ximian.com>
5302 * statement.cs (Switch): Merge with the gmcs implementation
5303 (without nullables), which is newer.
5305 2006-09-15 Martin Baulig <martin@ximian.com>
5307 * statement.cs (Block.Variables): Make this public.
5308 (ToplevelBlock.Parameters): Make this a property.
5309 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
5311 2006-09-15 Martin Baulig <martin@ximian.com>
5313 * namespace.cs: Merge with the gmcs version.
5315 2006-09-15 Martin Baulig <martin@ximian.com>
5317 * decl.cs (MemberName): Minor code cleanups.
5319 2006-09-15 Martin Baulig <martin@ximian.com>
5321 * parameter.cs: Merge with the gmcs version.
5323 2006-09-15 Martin Baulig <martin@ximian.com>
5325 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
5326 and an error in mcs.
5328 2006-09-15 Martin Baulig <martin@ximian.com>
5330 * flowanalysis.cs: Merged from GMCS; added the generics code into
5331 a `GMCS_SOURCE' conditional so we can share this file.
5333 2006-09-08 Martin Baulig <martin@ximian.com>
5335 * typemanager.cs (TypeManager.interlocked_type): New public field.
5336 (TypeManager.int_interlocked_compare-exchange): New public field.
5337 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
5338 enumerator types here and call InitGenericCoreTypes().
5339 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
5340 after calling InitEnumUnderlyingTypes().
5343 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
5344 `classes_second_stage'.
5346 2006-09-14 Marek Safar <marek.safar@seznam.cz>
5348 * assign.cs, ecore.cs, expression.cs: Share error message text.
5349 * class.cs (FieldMember.Define): Check for varible of static type.
5350 * driver.cs (LoadAssembly): Uses error output for errors.
5351 * statement.cs: Updated.
5353 2006-09-08 Marek Safar <marek.safar@seznam.cz>
5355 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
5358 2006-09-07 Martin Baulig <martin@ximian.com>
5361 (MainDriver): Revert r62663 from Marek; see #70506 for details.
5363 2006-08-29 Miguel de Icaza <miguel@novell.com>
5365 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
5367 2006-08-17 Miguel de Icaza <miguel@novell.com>
5369 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
5370 #52019 and #79064, the use of the \uXXXX sequence in source code
5371 to represent unicode characters.
5373 2006-08-15 Marek Safar <marek.safar@seznam.cz>
5375 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
5377 * class.cs, ecore.cs, statement.cs: Merged to one error message.
5379 2006-08-13 Miguel de Icaza <miguel@novell.com>
5381 * assign.cs: Catch attempts to assign to a method groups in += and
5384 2006-08-13 Marek Safar <marek.safar@seznam.cz>
5387 * cs-parser.jay: Don't destroy current array type by typeof of array's.
5389 2006-08-12 Marek Safar <marek.safar@seznam.cz>
5391 * class.cs (Method.Define): Issue a warning when generic method looks like
5393 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
5396 2006-08-09 Marek Safar <marek.safar@seznam.cz>
5398 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
5400 * decl.cs (MemberCache.FindMembers): When container is interface we need to
5401 search all base interfaces as a member can be ambiguous.
5402 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
5403 Constructor member type filter.
5404 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
5405 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
5406 reporting for returned memberinfos.
5407 * report.cs: Updated.
5408 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
5409 version to work on all runtimes.
5410 (TypeManager.RealMemberLookup): Removed members filtering.
5412 2006-08-08 Raja R Harinath <rharinath@novell.com>
5414 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
5415 (PropertyExpr.EmitAssign): Likewise.
5416 * expression.cs (Indirection.EmitAssign): Likewise.
5417 (LocalVariableReference.EmitAssign): Likewise.
5418 (ParameterReference.EmitAssign): Likewise.
5419 (Invocation.EmitArguments): Likewise.
5420 (ArrayAccess.EmitAssign): Likewise.
5421 (IndexerAccess.EmitAssign): Likewise.
5422 (This.EmitAssign): Likewise.
5423 (ConditionalLogicalOperator.Emit): Likewise.
5426 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
5427 instead of ArrayList. If the hashtable has a LocalBuilder, don't
5428 leave it in after returning it.
5429 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
5431 2006-08-06 Marek Safar <marek.safar@seznam.cz>
5433 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
5436 2006-08-03 Raja R Harinath <rharinath@novell.com>
5438 Fix cs0146-3.cs and cs0146-4.cs.
5439 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
5440 enclosing types don't depend on the current type.
5442 2006-08-02 Raja R Harinath <rharinath@novell.com>
5445 * class.cs (TypeContainer.DoDefineMembers): Use
5446 FindBaseMemberWithSameName on Parent, since we're interested in
5447 whether we hide inherited members or not.
5448 (FindBaseMemberWithSameName): Make slightly more robust.
5450 Fix the non-generic testcase from #77396
5451 * decl.cs (DeclSpace.DeclContainer): Remove override.
5453 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
5454 declspaces for doppelgangers too.
5455 (UsingEntry): Implement IResolveContext.
5456 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
5457 'this' as the resolve context.
5458 (LocalAliasEntry): Likewise.
5460 Implement parts of #77403
5461 * roottypes.cs (RootDeclSpace): New. Used to represent the
5462 toplevel declaration space. Each namespace declaration introduces
5463 a "partial" root declaretion space.
5464 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
5465 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
5466 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
5467 from 'current_namespace.SlaveDeclSpace'.
5468 (namespace_declaration): Likewise.
5469 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
5470 check. It can't happen now.
5471 * decl.cs (DeclSpace.LookupType): Likewise.
5472 * driver.cs (MainDriver): Sanity check.
5474 2006-08-01 Raja R Harinath <rharinath@novell.com>
5476 * decl.cs (DeclSpace.FindNestedType): Remove.
5477 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
5478 LookupTypeContainer to get the container of the nested type.
5479 * class.cs (TypeContainer.FindNestedType): Make non-override.
5481 2006-07-31 Raja R Harinath <rharinath@novell.com>
5483 * decl.cs (DeclSpace.PartialContainer): Move field from ...
5484 * class.cs (TypeContainer.PartialContainer): ... here.
5485 (TypeContainer.AddBasesForPart): New helper.
5486 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
5488 * cs-parser.jay (current_class): Convert to DeclSpace.
5489 (struct_declaration, interface_declaration, class_declaration):
5490 Use AddBasesForPart instead of .Bases directly.
5491 * const.cs, iterators.cs: Update to changes.
5493 2006-07-28 Raja R Harinath <rharinath@novell.com>
5495 * class.cs (TypeContainer.AddMemberType): Rename from
5497 (TypeContainer.AddMember): Rename from AddToMemberContainer.
5498 (AddTypeContainer): New. Combine AddClassOrStruct and
5500 (AddPartial): Update. Add 'is_partial' argument.
5501 * roottypes.cs: Update to changes.
5502 * cs-parser.jay (push_current_class): New helper for handling
5503 current_container and current_class.
5504 (struct_declaration, interface_declaration, class_declaration):
5507 2006-07-26 Raja R Harinath <rharinath@novell.com>
5509 * roottypes.cs: Rename from tree.cs.
5511 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
5512 * tree.cs (Tree, ITreeDump): Remove types.
5513 * rootcontext.cs (tree, Tree): Remove fields.
5514 (root, ToplevelTypes): New.
5515 * *.cs: Update to rename.
5517 * tree.cs (Tree.RecordDecl): Remove.
5518 (RootTypes.AddToTypeContainer): Record the toplevel type in its
5520 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
5522 2006-07-23 Raja R Harinath <harinath@gmail.com>
5524 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
5525 DoFlowAnalysis and OmitStructFlowAnalysis here.
5526 (ec.With): Rename from WithUnsafe and generalize.
5527 (ec.WithCheckState): Remove. All users can be handled by 'With'.
5528 (ec.WithFlowAnalyis): New.
5529 * ecore.cs, expression.cs, statement.cs: Update.
5531 2006-07-22 Raja R Harinath <harinath@gmail.com>
5533 * statement.cs (Block.ResolveMeta): Simplify slightly.
5535 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
5536 multiple boolean fields. Convert InUnsafe, constant_check_state,
5537 check_state to flags.
5538 (CheckState, ConstantCheckState): Update.
5539 (InUnsafe): New read-only property.
5540 (FlagsHandle): Rename from CheckStateHandle and convert to handle
5542 (WithUnsafe): New helper similar to WithCheckState.
5543 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
5544 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
5546 2006-07-21 Raja R Harinath <rharinath@novell.com>
5548 Make comparisons use the same IL irrespective of whether they're
5549 in a 'checked' or 'unchecked' context: one of the issues in #78899
5550 * codegen.cs (EmitContext.CheckState): Make read-only property.
5551 (EmitContext.ConstantCheckState): Likewise.
5552 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
5553 helper that implement a save/restore stack for CheckState
5554 values. This is the only way to change check-state.
5555 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
5556 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
5557 (CheckedExpr.EmitBranchable): New forwarding method.
5558 (UnCheckedExpr): Likewise.
5559 * statement.cs (Block.ResolveMeta): Use WithCheckState.
5560 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
5561 (Checked.Resolve, checked.DoEmit): Likewise.
5563 2006-07-20 Miguel de Icaza <miguel@novell.com>
5565 * anonymous.cs: Cache the resolved anonymous delegate, and return
5566 this so that the ResolveTopBlock is only triggered once, not
5569 Currently we trigger ResolvetopBlock twice due to a first pass of
5570 argument check compatibility, and a second pass that does the
5573 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5575 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
5577 * rootcontext.cs (Reset): Add helper_classes.
5579 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5582 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
5585 2006-07-13 Miguel de Icaza <miguel@novell.com>
5587 * statement.cs (Lock): Handle expressions of type
5588 TypeManager.null_type specially. Fixes #78770
5590 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5592 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
5595 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5597 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
5598 for accessors as well.
5599 * ecore.cs (EventExpr): Add AccessorTable.
5601 2006-07-01 Marek Safar <marek.safar@seznam.cz>
5604 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
5605 for CS0122 where appropriate.
5606 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
5608 (Filter): Assembly can be null in the case of top level attributes.
5610 2006-06-25 Marek Safar <marek.safar@seznam.cz>
5614 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
5615 is done at global level.
5617 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5619 A fix for #77002, Implemented TypeForwarder support.
5621 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
5622 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
5623 * typemanager.cs (): Add type_forwarder_attr_type.
5625 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5627 * report.cs: Add CS0469 warning.
5629 2006-06-21 Martin Baulig <martin@ximian.com>
5631 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
5632 the `try'-block, so we also report CS0016 etc. there.
5634 2006-06-21 Martin Baulig <martin@ximian.com>
5637 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
5639 2006-06-21 Martin Baulig <martin@ximian.com>
5641 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
5642 also report CS1686 for parameters.
5644 2006-06-21 Martin Baulig <martin@ximian.com>
5646 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
5647 instead of an error if the value is not implicitly convertible to
5648 the switch types; fixes #77964.
5650 2006-06-21 Raja R Harinath <rharinath@novell.com>
5653 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
5654 FieldBuilder is null.
5657 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
5658 'left' and 'right' before error-checking.
5660 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
5662 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
5664 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
5665 (FieldExpr.DoResolve): likewise.
5666 (PropertyExpr.InstanceResolve): likewise.
5667 (EventExpr.InstanceResolve): likewise.
5669 2006-06-04 Marek Safar <marek.safar@seznam.cz>
5671 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
5672 attribute applicable tests for attribute argument.
5674 2006-06-02 Raja R Harinath <rharinath@novell.com>
5677 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
5678 (Binary.OverloadResolve_PredefinedIntegral): New.
5679 (Binary.OverloadResolve_PredefinedFloating): New.
5680 (Binary.OverloadResolve_PredefinedString): New.
5681 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
5682 Follow the standard more closely, and treat numeric promotions in
5683 terms of overload resolution.
5684 (Binary.CheckShiftArguments): Simplify.
5686 2006-06-01 Raja R Harinath <rharinath@novell.com>
5688 * flowanalysis.cs (MyBitVector): Simplify representation.
5689 (MyBitVector.Clone): Avoid allocating BitArray.
5690 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
5691 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
5692 (*): Update. Change all references to MyBitVector.And and
5693 MyBitVector.Or to &= and |=.
5695 2006-05-29 Raja R Harinath <rharinath@novell.com>
5698 * cs-parser.jay (formal_parameter_list): Extend the pattern below
5699 to param arguments too.
5701 2006-05-26 Miguel de Icaza <miguel@novell.com>
5703 * cs-parser.jay: Catch another parsing form for arglist being
5704 followed by other arguments. Fixes #78313.
5706 2006-05-24 Raja R Harinath <rharinath@novell.com>
5708 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
5709 checking of out parameters to ...
5710 (FlowBranchingToplevel.Merge): ... here.
5711 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
5712 set, propagate the origin upward, and only complain if there was
5714 (FlowBranchingException.AddContinueOrigin): Likewise.
5715 (FlowBranchingException.AddReturnOrigin): Likewise.
5716 (FlowBranchingException.AddGotoOrigin): Likewise.
5718 2006-05-23 Raja R Harinath <rharinath@novell.com>
5720 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
5721 unreachable, skip it.
5722 (FlowBranchingException.Merge): Always propagate jumps, even if
5723 the finally block renders subsequent code unreachable.
5725 2006-05-18 Raja R Harinath <rharinath@novell.com>
5728 * statement.cs (Goto.Resolve): Move responsibility for resolving
5729 'goto' to FlowBranching.AddGotoOrigin.
5730 (Goto.SetResolvedTarget): New. Callback to set the
5731 LabeledStatement that's the target of the goto.
5732 (Goto.DoEmit): Use Leave instead of Br when crossing an
5733 unwind-protect boundary.
5734 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
5735 LookupLabel and adjust to new semantics.
5736 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
5737 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
5738 Goto.SetResolvedTarget to update target.
5739 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
5740 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
5741 AddBreakOrigin & co. Delay propagation until ...
5742 (FlowBranchingException.Merge): ... this.
5744 * statement.cs (Block.Resolve): Always depend on flow-branching to
5745 determine unreachability. Kill workaround that originally emitted
5746 only one statement after an "unreachable" label (see infloop in
5749 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
5750 This is still "wrong", but anything better would probably need a
5751 multi-pass algorithm.
5752 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
5753 usage vector. Force current usage vector to be reachable, to
5754 optimistically signify backward jumps.
5755 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
5757 (FlowBranchingLabeled.Merge): New. If no backward jump was
5758 detected, return the original salted-away usage vector instead,
5759 updated with appropriate changes. Print unreachable warning if
5761 * statement.cs (Block.Resolve): Don't print unreachable warning on
5762 a labeled statement.
5764 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
5766 * driver.cs: Pass filename without path to AssemblyBuilder's
5767 AddResourceFile. Fixes bug #78407.
5769 2006-05-17 Raja R Harinath <rharinath@novell.com>
5771 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
5772 * flowanalysis.cs (FlowBranchingLabeled): ... here.
5773 (FlowBranching.MergeChild): Overwrite
5774 reachability information from Labeled branchings too.
5776 2006-05-16 Raja R Harinath <rharinath@novell.com>
5778 * statement.cs (Goto.Resolve): Merge jump origins here ...
5779 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
5781 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
5782 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
5783 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
5784 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
5786 * statement.cs (Goto.Resolve): ... not here.
5787 (Goto.Emit): Remove CS1632 check.
5789 2006-05-14 Marek Safar <marek.safar@seznam.cz>
5791 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
5794 2006-05-11 Raja R Harinath <rharinath@novell.com>
5796 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
5797 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
5798 (FlowBranchingException.Label): Likewise.
5800 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
5802 (MyBitVector.Or): Use it to avoid losing information (Count).
5803 (FlowBranching.MergeOrigins): Likewise.
5805 * flowanalysis.cs (UsageVector.IsDirty): Remove.
5806 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
5807 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
5808 (UsageVector.ToString): Simplify.
5809 (UsageVector.MergeSiblings): Move here from ...
5810 (FlowBranching.Merge): ... here.
5811 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
5814 2006-05-10 Raja R Harinath <rharinath@novell.com>
5816 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
5817 null bitvector is treated as all-true.
5819 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
5820 (MyBitVector): Rationalize invariants. 'vector != null' implies
5821 that we have our own copy of the bitvector. Otherwise,
5822 'InheritsFrom == null' implies all inherited bits are true.
5824 2006-05-09 Marek Safar <marek.safar@seznam.cz>
5826 * statement.cs (LocalInfo): Add IsConstant.
5827 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
5828 local variable for constants.
5830 2006-05-09 Raja R Harinath <rharinath@novell.com>
5832 * flowanalysis.cs (MyBitVector.Empty): New.
5833 (MyBitVector): Don't allow InheritedFrom to be null.
5834 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
5835 (UsageVector, FlowBranching): Update to changes.
5837 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
5838 recursion. The 'Parent == null' condition isn't sufficient for
5840 (FlowBranching.AddBreakOrigin): Likewise.
5841 (FlowBranching.AddContinueOrigin): Likewise.
5842 (FlowBranching.AddReturnOrigin): Likewise.
5843 (FlowBranching.StealFinallyClauses): Likewise.
5844 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
5845 (FlowBranching.CheckOutParameters): Likewise.
5846 (FlowBranchingToplevel): Terminate all the above recursions here.
5847 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
5848 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
5850 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
5852 (FlowBranchingToplevel): New. Empty for now.
5853 (FlowBranching.MergeTopBlock): Update.
5854 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
5855 branching for the anonymous delegate.
5856 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
5858 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
5859 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
5860 information at the start of the merge. Reorganize.
5862 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5864 * class.cs (MethodData.Define): Method cannot implement interface accessor.
5866 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5868 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
5869 to newly introduced ctor.
5871 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
5872 message to one place.
5873 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
5876 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5878 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
5880 * ecore.cs (Expression.ResolveAsConstant): Updated.
5882 * statement.cs (ResolveMeta): Updated.
5884 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5886 * cs-parser.jay: __arglist cannot be used in initializer.
5888 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5891 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
5894 2006-05-05 Raja R Harinath <rharinath@novell.com>
5896 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
5897 (LabeledStatement): Add 'name' parameter.
5898 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
5899 (Block.AddLabel): Update to changes.
5900 * cs-parser.jay (labeled_statement): Likewise.
5902 * flowanalysis.cs (BranchingType.Labeled): New.
5903 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
5904 (FlowBranchingLabeled): New. Does nothing for now, but will
5905 eventually handle 'goto' flows.
5906 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
5907 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
5908 that's terminated ...
5909 (Block.Resolve): ... here.
5911 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
5912 (UsageVector.MergeFinallyOrigins): Likewise.
5913 (FlowBranching.InTryOrCatch): Likewise.
5914 (FlowBranching.AddFinallyVector): Likewise.
5915 (FlowBranchingException): Update to changes.
5918 * statement.cs (Return.Resolve): Move error checking to ...
5919 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
5920 (FlowBranchingException): Handle return origins like break and
5922 (FlowBranching.UsageVector.CheckOutParameters): Remove.
5924 2006-05-04 Marek Safar <marek.safar@seznam.cz>
5927 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
5930 2006-05-04 Marek Safar <marek.safar@seznam.cz>
5933 * class.cs (MethodData.Define): Do public accessor check only when method
5934 implements an interface.
5936 2006-05-04 Raja R Harinath <rharinath@novell.com>
5938 Remove special handling of 'break'
5939 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
5940 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
5941 (UsageVector.Break): Remove.
5942 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
5944 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
5946 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
5947 UsageVector.Breaks (). Don't set NeedsReturnLabel.
5949 2006-05-03 Marek Safar <marek.safar@seznam.cz>
5952 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
5953 be the interface member.
5955 2006-05-03 Marek Safar <marek.safar@seznam.cz>
5958 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
5959 for emitting small (int) values.
5961 2006-05-03 Raja R Harinath <rharinath@novell.com>
5964 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
5965 control-flow passes through the 'finally' after merging-in all the
5966 control-flows from 'try' and the 'catch' clauses.
5968 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
5969 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
5970 always true at the only non-recursive entry point.
5971 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
5972 FlowBranchingBreakable.
5973 (FlowBranchingLoop): Remove.
5974 * statement.cs (Return.DoResolve): Update to changes.
5977 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
5978 (FlowBranching.CreateBranching): Handle it: create a
5979 FlowBranchingContinuable.
5980 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
5981 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
5982 except that it handles the 'continue' command.
5983 (FlowBranching.UsageVector.MergeOrigins): Rename from
5985 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
5986 except that it overrides AddContinueOrigin.
5987 (FlowBranchingException): Override AddContinueOrigin, similar to
5989 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
5990 Create a new branching around the embedded statement.
5991 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
5992 control flow after the embedded statement.
5993 (Continue.Resolve): Move all error checking to AddContinueOrigin.
5995 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
5996 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
5997 FlowBranchingBreakable.
5998 (FlowBranchingSwitch): Remove.
6001 * statement.cs (Break.Resolve): Simplify. Move responsibility for
6002 error reporting to ...
6003 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
6004 Rename from 'AddBreakVector'. Add new location argument. Return
6005 a bool indicating whether the 'break' crosses an unwind-protect.
6006 (FlowBranchingException.AddBreakOrigin): Add.
6007 (FlowBranchingException.Merge): Propagate 'break's to surrounding
6008 flowbranching after updating with the effects of the 'finally'
6010 (FlowBranchingBreakable): New common base class for
6011 FlowBranchingLoop and FlowBranchingSwitch.
6013 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
6015 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
6017 2006-05-02 Raja R Harinath <rharinath@novell.com>
6019 * statement.cs (Do.Resolve): If the loop is infinite, set the
6021 (While.Resolve, For.Resolve): Set a barrier after the embedded
6022 statement. There's no direct control flow that goes from the end
6023 of the embedded statement to the end of the loop.
6024 * flowanalysis.cs (FlowBranching.Infinite): Remove.
6025 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
6026 above ensure that the reachability is correctly computed.
6028 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
6029 (UsageVector.MergeBreakOrigins): If the current path is
6030 unreachable, treat it as if all parameters/locals are initialized.
6031 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
6032 infinite loops before merging-in break origins.
6034 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
6035 (Reachability.Reachable): Split part into ...
6036 (Reachability.Unreachable): ... this. Simplify.
6037 (Reachability.IsUnreachable): Use 'Unreachable' instead.
6039 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
6040 (Reachability.SetThrowsSometimes): Likewise.
6041 (FlowBranchingBlock.MergeTopBlock): Don't compare against
6042 TriState.Always, use corresponding property.
6043 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
6044 (Block.Resolve): Likewise. Remove some redundant checks.
6046 2006-05-02 Raja R Harinath <harinath@gmail.com>
6048 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
6049 (Reachability.Meet): Don't bother checking AlwaysThrows --
6050 barrier is always set.
6051 (FlowBranchingBlock.Merge): Likewise.
6053 2006-05-01 Raja R Harinath <harinath@gmail.com>
6055 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
6056 checks for unreachable.
6058 2006-05-01 Marek Safar <marek.safar@seznam.cz>
6061 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
6063 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
6064 whether field is really assigned.
6066 2006-04-30 Raja R Harinath <harinath@gmail.com>
6068 * flowanalysis.cs (Reachability): Make 4-argument constructor
6070 (Reachability.Meet): Rename from 'And'. Remove static variant.
6071 (Reachability.Always): Rename from the highly misleading
6072 'Reachability.Never'.
6073 (FlowBranching.Merge): Update to changes. Mark an impossible
6074 situation with a 'throw'.
6075 (*): Update to changes.
6077 2006-04-29 Raja R Harinath <harinath@gmail.com>
6079 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
6081 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
6082 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
6083 (*): Update to changes.
6084 * statement.cs: Update to changes.
6086 2006-04-28 Marek Safar <marek.safar@seznam.cz>
6089 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
6091 2006-04-28 Raja R Harinath <harinath@gmail.com>
6093 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
6096 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
6097 argument to two arguments: an usage-vector and a bool. Move call
6098 to FlowBranching.Merge () ...
6099 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
6101 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
6102 handling of loop and switch reachability to ...
6103 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
6105 2006-04-27 Raja R Harinath <harinath@gmail.com>
6107 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
6108 handling to FlowBranchingLoop.InLoop.
6109 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
6111 2006-04-26 Marek Safar <marek.safar@seznam.cz>
6114 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
6115 anonymous method is allowed from AnonymousContainer here.
6117 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
6119 2006-04-24 Raja R Harinath <rharinath@novell.com>
6122 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
6124 2006-04-23 Marek Safar <marek.safar@seznam.cz>
6127 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
6128 (DoubleConstant.Reduce): Ditto.
6130 2006-04-23 Raja R Harinath <rharinath@novell.com>
6132 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
6133 Remove 'lvalue_right_side' argument. Move parts to ...
6134 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
6135 (LocalVariable.DoResolveLValue): ... these.
6137 2006-04-21 Raja R Harinath <rharinath@novell.com>
6140 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
6141 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
6142 (LocalVariableReference.DoResolveBase): Use it to implement new
6144 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
6145 (Argument.Resolve): Simplify. Move CS1510 check ...
6146 * ecore.cs (Expression.ResolveLValue): ... here.
6147 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
6148 (PropertyExpr.DoResolveLValue): Likewise.
6149 (FieldExpr.Report_AssignToReadonly): Likewise.
6150 (FieldExpr.DoResolve): Add 'out_access' argument. Use
6151 LValueMemberAccess or LValueMemberOutAccess on instance depending
6153 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
6154 DoResolve as appropriate.
6156 2006-04-20 Raja R Harinath <rharinath@novell.com>
6159 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
6160 implicit conversions on 'out' and 'ref' arguments.
6162 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
6163 improve clarity. Remove dead code.
6166 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
6167 (Catch.Resolve): Resolve VarBlock if it exists.
6169 2006-04-19 Miguel de Icaza <miguel@novell.com>
6171 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
6172 twice, this was some residual code, the enumerator was emitted
6173 properly in the two branche of if later.
6175 2006-04-19 Raja R Harinath <rharinath@novell.com>
6177 * expression.cs (Cast.ResolveLValue): Remove. The result of a
6178 cast is never an lvalue.
6179 (Cast.DoResolve, Cast.ResolveRest): Combine.
6180 (Argument.Emit): Simplify slightly. Move 'Expr is
6181 IMemoryLocation' check ...
6182 (Argument.Resolve): ... here.
6183 (Argument.Error_LValueRequired): Remove. Inline into only user.
6185 Simplifications. Fix cs0191-2.cs
6186 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
6187 CS1649 and CS1651 to ...
6188 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
6189 the actual selection of the error code and message to a lookup
6190 table. Add a dummy return value to simplify callsites.
6191 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
6192 readonly fields of other instances of the same type. Move CS0197
6194 * expression.cs (Argument.Resolve): ... here. Simplify code.
6195 Ensure that ec.InRefOutArgumentResolving is only set during LValue
6196 resolution of an out or ref argument. The code simplification
6197 above uses this invariant.
6199 2006-04-18 Raja R Harinath <rharinath@novell.com>
6201 Possibly fix #77752. Fix cs1690-[4-7].cs.
6202 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
6203 CheckMarshallByRefAccess. Drop parameter.
6204 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
6206 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
6208 * report.cs (AllWarnings): Add CS1690.
6209 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
6211 (LocalVariableReference.DoResolveBase): Update.
6213 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6215 * class.cs (MethodOrOperator): Moved common parts from method class.
6216 detect obsolete attributes.
6217 (Method.Define): Simplified as it reuses code from base.
6218 (Constructor.ValidAttributeTargets): Fixed issue found during
6220 (Destructor.ValidAttributeTargets): Fixed issue found during
6222 (Operator): Finished refactoring set off by #78020. Operator class is now
6223 ordinary method class.
6225 * anonymous.cs: Updated.
6227 * decl.cs (DeclSpace): Add IsGeneric
6229 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6231 * class.cs (Constructor.Emit): Don't emit the attributes twice.
6233 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6235 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
6236 detect obsolete attributes.
6237 (Method.CreateEmitContext): Moved to MethodOrOperator.
6239 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6242 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
6243 customized exception to make crash detection easier.
6244 (MethodOrOperator): Started to work on new base class for methods and
6246 (Method): Derives from MethodOrOperator.
6247 (Constructor.Emit): Emits its own attributes.
6248 (AbstractPropertyEventMethod.Emit): Ditto.
6249 (Operator): Derives from MethodOrOperator, will refactor fully in extra
6251 (Operator.Emit): It's temporary more tricky than should be.
6253 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
6255 * report.cs (InternalErrorException): Add ctor with inner exception.
6257 2006-04-08 Marek Safar <marek.safar@seznam.cz>
6260 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
6263 2006-04-07 Marek Safar <marek.safar@seznam.cz>
6266 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
6269 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6271 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
6272 attribute is present and Guid not.
6273 (Interface.ApplyAttributeBuilder): Ditto.
6275 * attribute.cs: Add error message.
6277 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6281 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
6282 sources (it's composite) so hold them in extra array as they are used in
6283 Emit phase only. It worked in the previous versions by mistake.
6284 (Attribute.Emit): Emit attribute for more owners when exist.
6286 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
6287 it has now different behaviour.
6289 2006-04-04 Marek Safar <marek.safar@seznam.cz>
6291 * constant.cs (Constant.IsDefaultInitializer): New method.
6293 * class.cs: Updated.
6295 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
6296 re-initialize default values. It saves KBs almost for every assembly.
6297 Thanks Zoltan for the idea.
6298 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
6299 (ArrayCreation.DoResolve): Resolve only once.
6300 (ArrayCreation.Emit): Emit static initializer only when it is faster.
6301 (ArrayCreation.GetAttributableValue): Cope with optimized values.
6303 2006-04-03 Zoltan Varga <vargaz@gmail.com>
6305 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
6308 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6310 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
6311 in an embedded statement too.
6313 2006-04-01 Raja R Harinath <rharinath@novell.com>
6316 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
6318 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6322 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
6325 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
6327 2006-03-31 Marek Safar <marek.safar@seznam.cz>
6329 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
6332 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
6333 LocalTemporary change.
6335 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
6337 (ClassOrStruct.DefineFieldInitializers): Implemented static field
6338 initializers optimization.
6339 (ClassOrStruct.TypeAttr): Moved from modifiers.
6340 (Constructor.CheckBase): Don't crash when static ctor has parameters.
6341 (FieldBase.ResolveInitializer): Resolves initializer.
6342 (FieldBase.HasDefaultInitializer): New property.
6344 * cs-parser.jay: Removed message.
6346 * expression.cs (CompilerGeneratedThis): New specialization.
6348 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
6350 2006-03-28 Marek Safar <marek.safar@seznam.cz>
6352 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
6354 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6356 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
6357 be now EnumConstants only.
6359 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6361 * attribute.cs, driver.cs: Reset more caches.
6363 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6365 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
6367 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6369 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
6370 for easier reuse. Updated all overrides.
6371 (IntegralConstant): New base class for all integral constants.
6372 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
6373 of the constant range, report custom error.
6374 (UIntConstant.Reduce): Fixed uint conversion.
6376 * ecore.cs, literal.cs: Reduce updates.
6378 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6382 * class.cs (Constructor.Define): Removed extra if for default ctors.
6383 A patch from Atsushi Enomoto.
6385 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6387 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
6388 GetAttributableValue.
6390 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
6393 * convert.cs (ImplicitConversionRequired): Error message moved to
6396 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
6397 automatic implicit conversion of an output value.
6398 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
6400 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
6402 (TypeOf.GetAttributableValue): Add extra handling for object type.
6404 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
6405 special error message.
6407 2006-03-25 Marek Safar <marek.safar@seznam.cz>
6409 * class.cs (Constructor.Emit): Don't crash when struct ctor is
6411 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
6412 compatible with MS runtime.
6414 2006-03-23 Marek Safar <marek.safar@seznam.cz>
6416 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
6417 attribute arguments here.
6419 * class.cs (Indexer.Define): The check was moved to attribute class.
6421 2006-03-22 Marek Safar <marek.safar@seznam.cz>
6423 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
6424 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
6427 2006-03-22 Raja R Harinath <rharinath@novell.com>
6429 Support ParameterDefaultValueAttribute in gmcs. Also applied to
6430 mcs to keep code differences small.
6431 * attribute.cs (Attribute.GetParameterDefaultValue): New.
6432 * typemanager.cs (parameter_default_value_attribute_type): New.
6433 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
6436 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6438 * expression.cs (StringConcat.Append): Reverted back to no warning state.
6440 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6442 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
6444 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
6447 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
6449 * doc-bootstrap.cs : fix build.
6451 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6453 * expression.cs (StringConcat.Append): Issue a warning when empty string
6456 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6458 * assign.cs (CompoundAssign.ResolveSource): Removed.
6460 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
6463 * class.cs (TypeContainer.FindMethods): Removed.
6464 (TypeContainer.CheckMemberUsage): Made static.
6466 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
6468 * constant.cs (CheckRange): Removed unused type argument.
6469 (CheckUnsigned): Removed unused type argument.
6471 * cs-parser.jay: Updated after MemberAccess clean up.
6472 Uses Length for empty string test.
6474 * cs-tokenizer.cs: Uses Length for empty string test.
6475 (IsCastToken): Made static.
6476 (is_hex): Made static.
6477 (real_type_suffix): Made static.
6479 * decl.cs (SetupCache): Made static.
6480 (OnGenerateDocComment): Removed unused ds argument.
6482 * delegate.cs (VerifyDelegate): Removed unused argument.
6484 * doc.cs: Uses Length for empty string test.
6486 * driver.cs: Uses Length for empty string test.
6488 * enum.cs (IsValidEnumType): Made static
6490 * expression.cs (EnumLiftUp): Removed unused argument.
6491 (ResolveMethodGroup): Ditto.
6492 (BetterConversion): Ditto.
6493 (GetVarargsTypes): Ditto.
6494 (UpdateIndices): Ditto.
6495 (ValidateInitializers): Ditto.
6496 (MemberAccess.ctor): Ditto.
6497 (GetIndexersForType): Ditto.
6499 * flowanalysis.cs: (MergeFinally): Removed unused argument.
6501 * iterators.cs: Updated after MemberAccess clean up.
6503 * location.cs: Uses Length for empty string test.
6505 * namespace.cs: Uses Length for empty string test.
6507 * report.cs (CheckWarningCode): Made static.
6509 * statement.cs (LabeledStatement): Removed unused argument.
6511 * typemanager.cs (FilterNone): Removed.
6513 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6515 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
6518 * class.cs: Updated.
6520 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6522 * cs-parser.jay.cs: __arglist is not allowed for delegates.
6524 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6528 * expression.cs (VerifyArgumentsCompat): Reverted to double error
6529 reporting, it's more tricky than I thought.
6531 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6535 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
6537 (AnonymousMethod.ImplicitStandardConversionExists): New method.
6538 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
6539 Add more error reporting; Fixed issue with params.
6541 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
6543 * cs-parser.jay: AnonymousMethod requires host container.
6545 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
6547 2006-03-18 Raja R Harinath <harinath@gmail.com>
6549 * class.cs: Change 'TypeContainer ds' constructor argument to
6550 'DeclSpace parent'. Some classes were missed below due to
6551 different naming convention.
6553 * class.cs (MemberCore.Parent): Delete. This makes the
6554 ParentContainer changes below enforceable by the compiler.
6556 Treat pointers to enclosing declaration space as 'DeclSpace', not
6558 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
6559 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
6561 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
6563 (Block.AddThisVariable): Likewise.
6564 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
6565 (AbstractPropertyEventMethod.Emit): Likewise.
6566 (AbstractPropertyEventMethod.EmitMethod): Likewise.
6567 (GetMethod.Define, SetMethod.Define): Likewise.
6568 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
6569 (DelegateMethod.EmitMethod): Likewise.
6571 Fix regression test-partial-13.cs.
6572 Rationalize use of PartialContainer. Ensure that the partial
6573 class semantics can be tied to type-correctness, i.e., any
6574 violation will cause a compile error.
6575 * class.cs, const.cs: Access all fields that belong to class
6576 TypeContainer via ParentContainer. Arguments of EmitContexts and
6577 Resolve()-like functions still use 'Parent'.
6579 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
6580 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
6581 (PropertyMethod.CheckModifiers): Remove unused argument.
6582 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
6585 2006-03-17 Raja R Harinath <harinath@gmail.com>
6587 Make semantics of PartialContainer simpler.
6588 * decl.cs (DeclSpace.IsPartial): Remove.
6589 * class.cs (TypeContainer.IsPartial): Likewise.
6590 (TypeContainer..ctor): Set PartialContainer to point to self.
6591 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
6592 (TypeContainer.FindNestedType): Likewise.
6593 (MemberCore.ParentContainer): Simplify. Remove deprecation.
6595 2006-03-17 Marek Safar <marek.safar@seznam.cz>
6597 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
6599 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6601 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
6604 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6606 * class.cs (Operator.Define): An error for base conversion was not
6609 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
6611 * iterator.cs : yield break is allowed in try statement which has
6612 catch clauses. Fixed bug #77767.
6614 2006-03-13 Marek Safar <marek.safar@seznam.cz>
6616 A fix for #77593, #77574.
6618 * class.cs (MethodCore.CheckBase): Another if for operator.
6620 2006-03-09 Marek Safar <marek.safar@seznam.cz>
6622 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
6625 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
6626 (DelegateCreation.ImplicitStandardConversionExists): New method for just
6629 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
6632 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
6633 Updated after another emitcontext usage was clean up. It should help us to
6634 synchronize with gmcs easier.
6636 2006-03-04 Marek Safar <marek.safar@seznam.cz>
6640 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
6641 (Event.Define): ditto
6642 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
6644 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
6645 Removed redundant code and set NewSlot for Invoke method too.
6647 * parameter.cs (Parameters.ctor): Add custom, type ctor.
6648 (Parameters.MergeGenerated): New method. Use this method when you merge
6649 compiler generated argument with user arguments.
6651 2006-03-03 Marek Safar <marek.safar@seznam.cz>
6653 * attribute.cs (ResolveAsTypeTerminal): Removed.
6655 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
6656 specialization for predefined types; 30% speed up.
6657 Finally placed obsolete check to right place.
6658 (Expression.ResolveType): Removed.
6660 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
6661 Updated after ResolveType was removed.
6663 * expression.cs (Cast.ctor): Check void cast.
6664 (Binary.ResolveAsTypeTerminal): Is never type.
6665 (Conditional.ResolveAsTypeTerminal): Is never type.
6667 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
6669 2006-03-01 Raja R Harinath <rharinath@novell.com>
6672 * expression.cs (ParameterReference.DoResolveBase): Change return
6674 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
6678 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
6681 * typemanager.cs (GetFullNameSignature): Don't nullref on
6682 protected accessors.
6684 2006-02-27 Marek Safar <marek.safar@seznam.cz>
6686 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
6687 these two separated members to simplify the code.
6688 (Attribute.Resolve): Refactored to use new fields and methods.
6689 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
6690 implemented obsolete attribute checking.
6691 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
6692 implemented obsolete checking again. It look line never ending quest ;-)
6693 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
6695 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
6697 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
6699 *class.cs (Property.Define): Add RegisterProperty call.
6701 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
6702 argument groups (only 2).
6704 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
6705 encoding expression to arguments.
6706 (Expression.ExprClassToResolveFlags): Just turned to property.
6708 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
6709 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
6710 optimized as well as implemented support for zero-length attributes.
6712 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
6713 Add caching of PropertyInfo's.
6715 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6717 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
6718 error multiple times.
6720 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6722 New partial class implementation.
6723 A fix for #77027, #77029, #77403
6725 * attribute.cs (Attributable): Made attributes protected.
6727 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
6728 the replacements of ClassPart and PartialContainer.
6729 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
6730 (TypeContainer.AddInterface): Ditto.
6731 (TypeContainer.AddPartial): The main method for partial classes. It checks
6732 for errors and merges ModFlags and attributes. At the end class is added to
6734 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
6736 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
6737 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
6738 from the rest of partial classes.
6739 (TypeContainer.GetClassBases): Simplified.
6740 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
6742 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
6743 (TypeContainer.HasExplicitLayout): Uses Flags now.
6744 (PartialContainer): Removed.
6745 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
6746 (StaticClass): Was merged with Class.
6747 (Class.GetClassBases): class and static class bases are verified here.
6748 (Class.TypeAttr): Added static attributes when class is static.
6749 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
6750 (MemberBase): In some cases we need to call parent container for partial
6751 class. It should be eliminated but it's not easy now.
6753 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
6755 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
6756 partial classed to accumulate class comments.
6757 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
6759 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
6761 * driver.cs (MainDriver): Tree.GetDecl was removed.
6763 * modifiers.cs (Modifiers): Add partial modifier.
6765 * tree.cs (Tree.decl): Removed.
6766 (RootTypes): Started to use this class more often for root types
6769 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6773 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
6774 external interface does not have an attribute.
6776 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6778 Another prerequisites for new partial classs implementation.
6780 * attribute.cs (Attribute.Equal): Implemented.
6781 (Attribute.Emit): Changed as attributes can be applied more than twice.
6782 (Attributes.Emit): Check for duplicate attributes here.
6784 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
6785 as a parameter, clean-up.
6787 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6791 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
6792 contains obsolete attribute check which can in some cases look for base
6793 type of current class which is not initialized yet.
6794 (TypeContainer.BaseType): Replacement of ptype.
6796 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
6798 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6800 First of prerequisites for new partial classs implemention.
6802 * attribute.cs (Attributable): Extended by ResolveContext;
6803 Attributes finally have correct context for resolving in all cases.
6804 (AttachTo): Attribute owner is assigned here.
6806 * codegen.cs (IResolveContext): Introduce new interface to hold
6807 all information needed in resolving phase.
6808 (EmitContext): Implements IResolveContext; more clean-up needed here.
6810 * decl.cs (MemberCore): Implemented IResolveContext.
6812 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
6813 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
6814 parameter.cs, statement.cs, tree.cs, typemanager.cs:
6815 Refactored to use new IResolveContext instead of EmitContext; cleanup
6817 2006-02-06 Miguel de Icaza <miguel@novell.com>
6819 * codegen.cs (EmitScopeInitFromBlock): check here the
6820 capture_context, there is no need to make two calls to the
6823 * anonymous.cs: Add some debugging messages that might help me
6824 track other instances of this problem in the future (the
6825 regression of test 467).
6827 * cs-parser.jay: track the variable block, as we need to initalize
6828 any captured variables declared in this block for the "catch"
6829 portion of the "Try" statement.
6831 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
6832 scope initialization for captured variables.
6834 Also, move the emit for the variables after the block location has
6837 2006-02-06 Marek Safar <marek.safar@seznam.cz>
6839 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
6841 2006-02-02 Miguel de Icaza <miguel@novell.com>
6843 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
6844 commit yesterday, the initialization for the roots is necessary.
6845 What is not necessary is the scope activation.
6847 2006-02-02 Raja R Harinath <rharinath@novell.com>
6849 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
6850 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
6852 (Argument.Resolve): Remove CS0206 checks.
6854 2006-02-01 Miguel de Icaza <miguel@novell.com>
6856 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
6857 scopes for all the roots, the scopes will now be emitted when the
6858 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
6860 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
6861 code. This reduces a lot of existing cruft.
6863 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
6864 that the ScopeInfo is generated as we enter the scope, not at the
6865 time of use, which is what we used to do before.
6867 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
6868 every time a Block is about to be emitted if we have a
6871 2006-02-01 Raja R Harinath <rharinath@novell.com>
6873 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
6875 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
6877 * typemanager.cs (cons_param_array_attribute): Make private.
6878 (Reset): Set it to null.
6879 (InitCoreHelpers): Don't initialize it.
6880 (ConsParamArrayAttribute): New. Initialize it as needed.
6881 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
6883 2006-01-31 Miguel de Icaza <miguel@novell.com>
6885 * expression.cs: There might be errors reported during the
6886 selection of applicable methods. If there are errors, do not
6887 continue execution as it will lead the compiler to crash.
6889 2006-01-30 Miguel de Icaza <miguel@novell.com>
6891 * expression.cs: Member access is not allowed on anonymous
6892 methods. Fixes #77402.
6894 2006-01-30 Raja R Harinath <rharinath@novell.com>
6897 * cs-parser.jay (VariableDeclaration): Don't set
6898 current_array_type to null.
6899 (field_declaration, event_declaration, declaration_statement):
6900 Set it to null here.
6902 2006-01-28 Raja R Harinath <harinath@gmail.com>
6904 * typemanager.cs (GenericParameterPosition): New.
6907 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
6909 * doc.cs : To process "include" elements, first we should create
6910 another list than XmlNodeList, because it could result in node
6911 removal, which could result in that the XmlNodeList gives up
6914 (Also made code identical to gmcs again.)
6916 2006-01-25 Miguel de Icaza <miguel@novell.com>
6918 * ecore.cs: Introduce an error report that we were not catching
6919 before, if not silent, we must report the error. Gonzalo ran into
6922 2006-01-23 Miguel de Icaza <miguel@novell.com>
6924 A fix for bug: #76957
6926 * iterators.cs (MoveNextMethod.CreateMethodHost): call
6927 ComputeMethodHost before creating the method, this is a new
6930 * anonymous.cs (AnonymousContainer): Now we track all the scopes
6931 that this method references (RegisterScope). The actual scope
6932 where the method is hosted is computed with the ComputeMethodHost
6933 before we create the method.
6935 Moved the Deepest routine here.
6937 (AnonymousContainer.ComputeMethodHost): New routine used to
6938 compute the proper ScopeInfo that will host the anonymous method.
6940 (ScopeInfo): Deal with multiple roots. The problem was that we
6941 did not have a unique root where all ScopeInfos could be hanged
6942 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
6945 Remove AdjustMethodScope which is now computed at the end. Remove
6946 LinkScope which did a partial link, instead link all ScopeInfos
6947 before code generation from the new "LinkScopes" routine.
6949 Simplify all the Add* routines as they no longer need to maintain
6950 the tree, they just need to record that they are using variables
6953 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
6954 routines to produce the forest of ScopeInfo trees.
6956 * class.cs (TypeContainer.AppendMethod): This is just like
6957 AddMethod, but ensures that an interface implementation method
6958 (IEnumerable.XXX) is not inserted at the beginning of the queue of
6959 methods, but at the end.
6961 We use this functionality to ensure that the generated MoveNext
6962 method in the iterator class is resolved/emitted before the
6963 enumerator methods created.
6965 This is required because the MoveNext method computes the right
6966 ScopeInfo for the method. And the other methods will eventually
6967 need to resolve and fetch information computed from the anonymous
6970 2006-01-21 Raja R Harinath <harinath@gmail.com>
6971 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6974 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
6976 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
6977 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
6979 2006-01-18 Raja R Harinath <rharinath@novell.com>
6981 Fix #76656, cs0231-2.cs.
6982 * cs-parser.jay (formal_parameter_list): Make error case catch
6984 (parenthesized_expression_0): Add CS1026 check.
6985 (invocation_expression): Remove unused { $$ = lexer.Location }.
6987 2006-01-17 Raja R Harinath <rharinath@novell.com>
6990 * cs-parser.jay (statement_expression): Don't list out the
6991 individual statement-expressions. Convert syntax error into
6994 2006-01-16 Raja R Harinath <rharinath@novell.com>
6997 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
6998 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
6999 CheckIntermediateModification.
7000 (FieldExpr.DoResolve): Add new two-argument version that
7001 allows us to resolve the InstanceExpression as an lvalue.
7002 The one-argument variant is now just a wrapper.
7003 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
7004 Resolve the lhs as an lvalue if the it has a value type.
7005 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
7006 from Assign.DoResolve.
7007 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
7008 resolved as an lvalue.
7009 (PropertyExpr.DoResolve): Update.
7010 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
7011 has a value type. Move CS1612 check here from
7012 CheckIntermediateModification.
7013 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
7014 * expression.cs (EmptyExpression.OutAccess): New. Used as the
7015 'right_side' of a ResolveLValue on an 'out' argument.
7016 (EmptyExpression.LValueMemberAccess): New. Used as the
7017 'right_side' of a propagated ResolveLValue on a value type.
7018 (LocalVariableReference.DoResolveBase): Recognize
7019 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
7021 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
7022 EmptyExpression.Null.
7024 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
7026 * typemanager.cs : added IsGenericParameter(). In mcs it always
7028 * doc.cs : for generic parameters, use GenericParameterPosition,
7031 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
7033 * expression.cs: Fix Console.WriteLine ((this = x).foo);
7035 2006-01-12 Miguel de Icaza <miguel@novell.com>
7037 This fixes the problem where we used ldfld instead of ldflda to
7038 load the "THIS" pointer on captured parameters, when THIS is a
7039 value type. See bug #77205.
7041 * iterators.cs (CapturedThisReference.Emit): Pass false to
7042 EmitThis (we do not need the address).
7044 * codegen.cs (EmitThis): it needs to know whether we need the
7045 address of `this' or not. This is used by value types.
7047 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
7048 every other call passes false.
7050 2006-01-12 Raja R Harinath <rharinath@novell.com>
7053 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
7055 * expression.cs (Invocation.OverloadResolve): Update.
7056 (Invocation.DoResolve): Avoid double resolution of invocation.
7058 2006-01-11 Raja R Harinath <rharinath@novell.com>
7061 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
7062 unary negation of floating point types as 0-expr; negation cannot
7063 overflow in floating point types.
7066 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
7067 on operands of 'void' type.
7070 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
7071 and ExclusiveOr for boolean constants too.
7073 2006-01-09 Raja R Harinath <rharinath@novell.com>
7076 * expression.cs (Invocation.OverloadResolve): Replace reflected
7077 override methods with their base virtual methods, rather than
7079 * typemanager.cs (TypeManager.GetOverride): New.
7081 2006-01-05 Jb Evain <jbevain@gmail.com>
7083 * class.cs (Property.Define, Indexer.Define): do not tag the
7084 properties as SpecialName | RTSpecialName.
7086 2006-01-04 Miguel de Icaza <miguel@novell.com>
7088 * class.cs (MethodCore.IsDuplicateImplementation): This method was
7089 doing a low-level comparission of parameter types. It was lacking
7090 a check for __argslist.
7092 2005-12-30 Miguel de Icaza <miguel@novell.com>
7094 * expression.cs (ParameterReference.DoResolveBase): Allow
7095 reference parameters if they are local to this block.
7097 This allows the ref and out parameters of a delegate to be used in
7098 an anonymous method, for example:
7100 delegate void set (out int x);
7102 set s = delegate (out int x){
7106 This is used by functionality introduced late in the C# language.
7108 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
7109 method that take ref and out parameters.
7111 Fixes #77119 which was a late change in the spec.
7113 2005-12-23 Miguel de Icaza <miguel@novell.com>
7115 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
7116 parent if its the same scope. Fixes #77060.
7118 2005-12-21 Miguel de Icaza <miguel@novell.com>
7120 * driver.cs: Report the case of no source files and no -out:
7123 2005-12-20 Raja R Harinath <rharinath@novell.com>
7126 * expression.cs (ComposedCast.GetSignatureForError): Define.
7128 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7132 * namespace.cs (NamespaceEntry): Add extern_aliases as a
7133 ListDictionary, to contain the ExternAliasEntry entries (in
7134 addition to the NamespaceEntry.aliases hashtable). This field is
7135 shared between the original entry and its doppelganger (bodyless
7137 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
7138 extern_aliases field.
7139 (NamespaceEntry.Lookup): Move the IsImplicit check after the
7140 lookup in extern_aliases.
7142 2005-12-16 Raja R Harinath <rharinath@novell.com>
7145 * class.cs (TypeContainer.Mark_HasEquals): New.
7146 (TypeContainer.Mark_HasGetHashCode): New.
7147 (ClassPart): Override them.
7148 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
7151 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
7152 'parent' argument to the base constructor.
7154 Remove all mention of TypeContainer from decl.cs.
7155 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
7156 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
7157 (DeclSpace.DeclSpace): Likewise.
7158 (DeclSpace.DefineMembers): Remove unused argument.
7159 * cs-parser.jay (pop_current_class): Update to changes. Simplify
7160 debugging check -- we don't care if the debug code throws an
7161 InvalidCastException instead of an InternalErrorException.
7162 * class.cs (TypeContainer.DefineMembers): Update to changes.
7163 (TypeContainer.DoDefineMembers): Likewise.
7164 (TypeContainer.GetMethods): Likewise.
7165 (PropertyMember.Define): Likewise.
7166 (MemberBase.Parent): New property that forwards to
7167 MemberCore.Parent, but ensures that we get a TypeContainer.
7168 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
7169 (RootContext.PopulateTypes): Likewise. Remove special case code
7170 for !RootContext.StdLib: DefineMembers is idempotent.
7172 2005-12-14 Miguel de Icaza <miguel@novell.com>
7174 * convert.cs (ExplicitConversionCore): Check the return value from
7175 ExplicitConversionCore which can return null on failure. Fixes #76914
7177 2005-12-13 Marek Safar <marek.safar@seznam.cz>
7179 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
7181 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
7183 * doc.cs : The search for referenced namespace was insufficient to
7184 get global one as it used to do. Fixed bug #76965.
7186 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
7188 * doc.cs : check name in cref in the last phase that whether it is
7191 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7193 * cs-tokenizer.cs : reverted the latest change: it somehow broke
7196 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7198 * doc.cs : so it turned out that we cannot skip override check for
7199 interface members. Fixed bug #76954.
7201 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7203 * cs-tokenizer.cs : fixed bug #75984:
7204 - #warning and #error should not be handled when the source line
7206 - #line is not checked strictly when the source line is disabled.
7207 - #define and #undef is on the other hand checked strictly at any
7210 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
7212 * cs-tokenizer.cs : missing Location (actually, filename) in one of
7215 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7217 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
7219 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
7221 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
7222 (FieldBase.Initializer): Initializer is now optional.
7223 (EventField.Define): Only event field can have initializer.
7225 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
7227 * const.cs (Const): Reuse initializer.
7229 * cs-parser.jay: Updated after FieldBase changes.
7230 Added current_array_type to simplify array initializers.
7232 * ecore.cs (NullCast.IsDefaultValue): Implemented.
7234 * expression.cs, iterators.cs: Updated.
7236 * namespace.cs (NamespaceEntry): Made UsingFound private.
7238 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7240 * parameterCollection.cs: Obsolete, removed.
7241 * parser.cs: Obsolete, removed.
7243 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7246 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
7248 * enum.cs (Enum.Define): Set obsolete context here.
7250 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7253 - FindDocumentedMember() now expects 1) paramList as null
7254 when "we don't have to check the number of parameters" and
7255 2) Type.EmptyTypes when "there is no arguments".
7256 - Introduced FoundMember struct to hold the exact type which was
7257 used to find the documented member (the above change broke
7258 test-xml-044; it might be better just to use DeclaringType than
7259 what MS does, like this change does, but it depends on usage.)
7261 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7263 * doc.cs : documented member might be from DeclaringType for nested
7264 types. Fixed bug #76782.
7266 2005-12-03 Ben Maurer <bmaurer@ximian.com>
7268 * anonymous.cs: Have the param code handle leaving copies on the
7269 stack etc. Allows anonymous params to take part in the assignment
7270 code (++, +=, etc). Fixes bug #76550
7272 * expression.cs: Handle the prepare_for_load/leave_copy by passing
7273 it down to the anon code.
7275 * iterators.cs: Use dummy var here
7277 * codegen.cs: Handle new vars
7279 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7282 * class.cs (MethodData.Define): Set proper Obsolete context.
7284 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
7286 (FieldExpr.DoResolve): Ditto.
7288 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7291 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
7292 parent is not obsolete.
7294 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
7296 * doc.cs : (FindDocumentedMember) find parameterless members first
7297 and get CS0419 in the early stage. Fixed first case of bug #76727.
7299 2005-11-30 Marek Safar <marek.safar@seznam.cz>
7302 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
7303 no error was reported.
7305 *expression.cs (Binary.DoResolve): left can be null.
7307 2005-11-22 Marek Safar <marek.safar@seznam.cz>
7310 * class.cs (MethodData.Emit): Parameters should be labeled first.
7312 2005-11-21 Marek Safar <marek.safar@seznam.cz>
7315 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
7317 2005-11-18 Marek Safar <marek.safar@seznam.cz>
7319 * attribute.cs (AreParametersCompliant): Moved to Parameter.
7321 * class.cs (MethodCore): Parameter clean up.
7322 (IMethodData): Added ParameterInfo.
7323 (MethodData): Parameter clean up.
7324 (Indexer.Define): Parameter clean up.
7336 * typemanager.cs: Parameter clean up.
7338 * delegate.cs (Define): Get rid of duplicated code.
7340 * expression.cs (ParameterReference): Removed useless parameters
7342 (Invocation): Ditto.
7344 * parameter.cs (ParamsParameter): New class, params specialization.
7345 (ArglistParameter): Attemp to separate arglist.
7346 (Parameter): Refactored to be reusable and faster.
7347 (Parameter.Modifier): Made understandable.
7348 (Parameters): Changed to be used as a class for `this' assembly
7349 parameters. Refactored to use new specialized classes.
7351 * support.cs (ParameterData): Added Types property.
7352 (InternalParameters): Deleted.
7354 2005-08-20 Martin Baulig <martin@ximian.com>
7356 Merging this patch from GMCS to fix #75867.
7358 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7359 scope if we don't already have it.
7361 2005-11-17 Martin Baulig <martin@ximian.com>
7364 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
7365 inherit the scope from our parent. Fixes #76653.
7367 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7369 * doc.cs : the previous patch does not actually fix the bug.
7370 PropertyInfo override check is now implemented and really fixed it.
7371 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
7373 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7375 * doc.cs : apply "override filter" also to properties.
7378 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7380 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
7381 no need to check overrides. For classes, omit those results from
7382 interfaces since they must exist in the class. Fixed bug #76726.
7384 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7386 * typemanager.cs : (GetFullNameSignature) differentiate indexers
7387 with different parameters. Fixed the second problem in #76685.
7389 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7391 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
7392 get expected 'protected' access in CheckValidFamilyAccess()).
7395 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7397 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
7398 Fixed bug #76705. CS1569 was incorrectly commented out.
7400 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7402 * doc.cs : use Invocation.IsOverride() to do real override check.
7403 * expression.cs : made Invocation.IsOverride() internal.
7405 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7407 * doc.cs : use TypeManager.FindMembers() instead of (possible)
7408 TypeBuilder.FindMembers() and filter overriden base members out.
7411 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7413 * doc.cs : ref/out parameters are represented as '@' (instead of
7414 '&' in type FullName). Fixed bug #76630 (additionally crefs).
7416 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7418 * doc.cs : when there was no '.' in cref to methods in doc comment,
7419 then parameters were missing in the output. Fixed bug #76691.
7421 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7423 * driver.cs : don't output docs when there is an error.
7426 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7429 Now it should detect indexers. Fixed primary concern in bug #76685.
7430 Fixed CS0419 message to not show the identical member signature in
7433 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7435 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
7436 instead of Type.FindMembers() since it does not handle events.
7439 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
7441 * codegen.cs: Fixed typo (speficied -> specified).
7443 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7446 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
7448 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7450 * attribute.cs: Changed error message.
7452 * cs-tokenizer.cs: One more check.
7454 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7456 * statement.cs (Block.Resolve): Ignore empty statement.
7458 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7460 * report.cs: Made error/warning methods more strict to avoid
7463 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
7464 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
7465 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
7466 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
7468 2005-11-08 Marek Safar <marek.safar@seznam.cz>
7470 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
7471 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
7473 * class.cs (TypeContainer.IsComImport): New property.
7474 (Constructor.Define): Create proper ctor for ComImport types.
7476 * expression.cs (New.CheckComImport): Fixed.
7478 2005-11-07 Miguel de Icaza <miguel@novell.com>
7480 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
7481 that a parameter has been captured does not mean that we do not
7482 have to do the rest of the processing. This fixes the second part
7483 of #76592. If there was another anonymous method capturing
7484 values in the past, the Scope would never be set for the second
7485 method that captured the same parameter.
7487 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
7488 properly manipulate the stack. Second part of fix for #76592.
7490 * expression.cs (New): Add support for invoking "new" on
7491 interfaces that have been flagged with the ComImport attribute and
7492 the CoClass. Fixes #76637
7494 * statement.cs (Try.DoEmit): When a variable is captured, do not
7495 try to emit the vi.LocalBuilder variable as it has been captured.
7496 Create a temporary variable and store the results on the
7497 FieldBuilder. Fixes #76642
7499 2005-11-07 Marek Safar <marek.safar@seznam.cz>
7501 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
7503 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
7505 * expression.cs (Binary.DoResolve): Added && optimalization.
7507 * typemanager.cs (AddUserType): Removed useless argument.
7509 2005-11-04 Marek Safar <marek.safar@seznam.cz>
7511 * statement.cs (Block.variables): Uses ListDictionary.
7513 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7516 * class.cs (PartialContainer.EmitType): Customized to emit
7517 security attributes.
7518 (ClassPart.ApplyAttributeBuilder): Transform security attribute
7519 for partial classes.
7521 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7524 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
7525 access has to be fixed.
7527 * typemanager.cs (IsUnmanagedType): Wrong common field type.
7529 2005-11-01 Marek Safar <marek.safar@seznam.cz>
7532 * ecore.cs (NullCast.Reduce): Implemented.
7534 * expression.cs (ArrayCreation.CheckIndices): Correcly check
7537 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
7539 (Foreach.Resolve): Catch null properly.
7541 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7543 * cs-tokenizer.cs: Warning text fix.
7545 * driver.cs: AllWarningNumbers exposed on public interface.
7547 * report.cs (): Reviewed warning numbers.
7548 (IsValidWarning): Use binary search.
7550 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7552 * driver.cs: Implemeted resource visibility.
7553 (Resources): New class for code sharing between /res: and
7556 2005-10-28 Marek Safar <marek.safar@seznam.cz>
7559 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
7562 * convert (Convert.ImplicitReferenceConversion): NullCast holds
7565 * ecore.cs (NullCast): Child is contant only.
7567 * literal.cs (NullLiteral.Reduce): null can be converted to any
7570 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
7572 * driver.cs: Use Encoding.Default as default code page instead
7575 2005-10-27 Raja R Harinath <rharinath@novell.com>
7578 * expression.cs (Invocation.Error_InvalidArguments): Handle
7579 __arglist parameters.
7580 (Invocation.VerifyArgumentsCompat): Likewise.
7581 * support.cs (ReflectionParameters.GetSignatureForError): Print
7582 __arglist parameters.
7583 (InternalParamters.GetSignatureForError): Likewise.
7584 * parameter.cs (Parameters.GetSignatureForError): Likewise.
7586 2005-10-26 Marek Safar <marek.safar@seznam.cz>
7588 * attribute.cs (GetPropertyValue): Made public.
7590 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
7592 Add new property WrapNonExceptionThrows to handle 2.0 assembly
7594 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
7597 * driver.cs: Reflect method name change.
7599 * statement.cs (Try.Resolve): Warn when try has both general
7602 * typemanager.cs: runtime_compatibility_attr_type new predefined
7605 2005-10-26 Raja R Harinath <harinath@gmail.com>
7608 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
7609 treat it as an empty parameter list.
7611 2005-10-26 Raja R Harinath <rharinath@novell.com>
7614 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
7615 ResolveAsTypeStep silent.
7616 * statement.cs (Block.AddConstant): Mark block as used.
7617 (Block.ResolveMeta): Avoid piling on error messages
7618 if a constant initializer resolution fails.
7620 2005-10-25 Raja R Harinath <rharinath@novell.com>
7622 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
7624 (NamespaceEntry.VerifyAllUsing): New.
7625 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
7626 behaviour. Delegates actual resolution of alias to ...
7627 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
7628 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
7630 * driver.cs (Driver.MainDriver): Update.
7632 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
7633 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
7635 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
7637 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
7638 RootNamespace.DefineNamespacesForAll.
7640 2005-10-24 Raja R Harinath <harinath@gmail.com>
7642 * typemanager.cs (assemblies, external_aliases, modules)
7643 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
7644 (ComputeNamespaces, GetRootNamespace): Remove extra staging
7645 overhead. Move resposibility ...
7646 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
7647 * driver.cs, attribute.cs, codegen.cs: Update to changes.
7649 2005-10-23 Raja R Harinath <harinath@gmail.com>
7651 * namespace.cs (RootNamespace.all_namespaces): Renamed from
7652 cached_namespaces. Improve usage.
7653 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
7654 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
7655 Move from GlobalRootNamespace and simplify.
7656 (RootNamespace.Global): Make instance variable.
7657 (RootNamespace.RootNamespace): Add "alias name" parameter.
7658 (GlobalRootNamespace): Simplify drastically.
7659 (Namespace.Lookup): Don't use GetNamespace.
7660 * typemanager.cs (GetRootNamespace): Rename from
7661 ComputeNamespaceForAlias.
7662 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
7664 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7666 * anonymous.cs (AnonymousContainer): Don't crash when container
7669 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7671 * expression.cs (Binary.DoResolve): Warn when comparing same
7674 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7677 * expression.cs (Binary.DoResolve): It looks like there are no
7678 convetsion rules in enum context.
7680 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7682 Add support for extern alias qualifiers.
7683 * typemanager.cs: Move some LookupTypeReflection code
7684 to namespace.cs, to have cleaner code. Added some methods
7685 to help us keep track of the extern aliased references.
7686 * driver.cs: Add suport for extern alias assemblies on command
7687 line and check for their warnings/errors. Also keep track of the
7688 extern aliased assemblies.
7689 * namespace.cs: Move the global functionality of Namespace
7690 to GlobalRootNamespace/RootNamespace. Now the global namespace
7691 is GlobalRootNamespace.Globa. Also the code moved from
7692 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
7693 Finally added LocalAliasEntry (AliasEntry before) and
7694 ExternAliasEntry, to handle alias statements.
7695 * cs-parser.jay: Add support in the grammar for extern alias
7697 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
7698 Update callings to Namespace (now in GlobalRootNamespace).
7700 2005-10-18 Raja R Harinath <rharinath@novell.com>
7703 * class.cs (TypeContainer.DefineType): Move updating of
7704 topological sort earlier in the code.
7705 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
7707 2005-10-18 Marek Safar <marek.safar@seznam.cz>
7710 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
7712 * constant.cs (Constant.TryReduce): Moved from Cast class.
7713 (Reduce): Made little bit more OO and fixed missing conversions.
7715 * ecore.cs (Reduce): Implemented.
7716 (Binary.EnumLiftUp): New method to upgrade values to enum values.
7718 * literal.cs (Reduce): Implemented.
7720 * class.cs: Reverted Miguel's wrong commit.
7722 2005-10-14 Miguel de Icaza <miguel@novell.com>
7724 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
7726 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
7728 * cs-parser.jay, expression.cs : CS0214 was missing error location
7729 for constants. Fixed bug #76404.
7731 2005-10-11 Marek Safar <marek.safar@seznam.cz>
7734 * convert.cs (ExplicitConversionCore): Fixed object->enum
7737 2005-10-10 Raja R Harinath <rharinath@novell.com>
7739 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
7741 (PropertyExpr.EmitCall): Likewise.
7742 * expression.cs (Invocation.EmitArguments): Handle case where
7744 (Invocation.EmitCall): Avoid allocating temporary variable if
7745 there are no arguments.
7747 2005-10-07 Raja R Harinath <rharinath@novell.com>
7750 * convert.cs (ImplicitConversionStandard): Move conversion of
7751 void* to arbitrary pointer types ...
7752 (ExplicitConversionStandard): .. here.
7753 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
7754 error to always print typenames.
7756 2005-10-07 Raja R Harinath <rharinath@novell.com>
7758 * convert.cs (GetConversionOperator): Rename from
7759 GetConversionOperators. Move operator selection code from ...
7760 (UserDefinedConversion): ... here.
7762 2005-10-06 Marek Safar <marek.safar@seznam.cz>
7764 * convert.cs (ExplicitConversionCore): Removed duplicate enum
7767 2005-10-05 Marek Safar <marek.safar@seznam.cz>
7769 * assign.cs (Assign.DoResolve): Error method changed.
7771 * cfold.cs (DoConstantNumericPromotions): Error method changed.
7773 * const.cs (ResolveValue): Reset in_transit immediately.
7775 * constant.cs: Error method changed.
7777 * convert.cs: Removed useless location parameter.
7778 (ExplicitNumericConversion): Don't do double enum check.
7779 (ExplicitConversionCore): Renamed from ExplicitConversion.
7780 (ExplicitUnsafe): Extracted from ExplicitConversion.
7781 (ExplicitConversion): Uses for error reporting.
7783 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
7785 (ResolveBoolean): Uses common error method.
7786 (CastToDecimal): Get rid of ec.
7787 (CastFromDecimal): Optimized.
7788 (ConvCast): Get rid of ec.
7790 * enum.cs (ResolveValue): Reset in_transit immediately.
7791 (Emit): Return after first error.
7793 * expression.cs: Convert changes.
7795 * literal.cs: Error method changed.
7797 * statement.cs: Error method changed.
7799 2005-10-03 Raja R Harinath <rharinath@novell.com>
7801 * support.cs (SeekableStreamReader.Position): Don't error out when
7802 the requested position is just beyond the end of the current
7805 2005-09-28 Raja R Harinath <rharinath@novell.com>
7807 * support.cs (SeekableStreamReader): Simplify drastically. Don't
7808 try to keep in sync with the byte count of the underlying Stream.
7809 However, this limits us to a window size of 2048 characters: i.e.,
7810 the maximum lookahead of our lexer/parser can be 2048 characters.
7812 2005-09-28 Marek Safar <marek.safar@seznam.cz>
7815 * driver.cs: Fix compilation files with full root path.
7817 2005-09-25 Miguel de Icaza <miguel@novell.com>
7819 * report.cs (SymbolRelatedToPreviousError): Format the output so
7820 it does not use an open parenthesis that is never closed.
7822 * driver.cs: Follow coding guidelines
7824 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7827 * const.cs (Const.ResolveValue): Check for assigning non-null
7828 value to reference type.
7830 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7832 * anonymous.cs: Implemented ExprClassName.
7834 * assign.cs (Assign.DoResolve): Don't chrash when type is not
7837 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
7840 * class.cs (StaticClass.DefineContainerMembers): Report protected
7843 * codegen.cs: if(ed) PRODUCTION.
7845 * convert.cs (Error_CannotImplicitConversion): Better error
7848 * cs-parser.jay: More error checks.
7850 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
7852 * driver.cs (CSCParseOption): Enabled wrong option check.
7854 * ecore.cs (Expression.ExprClassName): Turned to property.
7855 (MemberExpr.CheckIntermediateModification): For checking boxed
7856 value types modification.
7858 * statement.cs (Fixed.Resolve): Expression type must be
7859 convertible to fixed type.
7860 (CollectionForeach.GetEnumeratorFilter,TryType):
7861 Small refactoring for easier error checking.
7863 2005-09-26 Marek Safar <marek.safar@seznam.cz>
7865 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
7868 * class.cs (GeneratedBaseInitializer): New class for customization
7869 compiler generated initializers.
7870 (MemberBase.DoDefine): Check Obsolete attribute here.
7871 (FieldMember.DoDefine): Ditto.
7873 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
7876 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
7877 (MemberCore.GetObsoleteAttribute): Removed argument.
7878 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
7879 (MemberCore.CheckObsoleteType): New helper.
7883 * statement.cs: Updates after MemberCore changes.
7885 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
7886 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
7888 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
7889 obsolete attribute for compiler construct.
7890 (As.DoResolve): Cache result.
7892 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
7894 2005-09-26 Raja R Harinath <rharinath@novell.com>
7897 * expression.cs (This.VerifyFixed): In a value type T, the type of
7898 'this' is T&, iow, 'this' is either an out or ref parameter. In a
7899 value type R, 'this' is treated as a value parameter.
7901 2005-09-22 Miguel de Icaza <miguel@novell.com>
7903 * statement.cs (Lock): Use the TemporaryVariable class instead of
7904 manually using local variables as those do not work when variables
7907 * ecore.cs: Moved the TemporaryVariable class from being a nested
7908 class inside Foreach to be a public class that can be employed in
7911 2005-09-19 Marek Safar <marek.safar@seznam.cz>
7913 * cs-parser.jay: interface_accessors replaced by
7914 accessor_declarations.
7916 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
7919 * statement.cs (GotoCase.Resolve): Convert null constant to
7921 (SwitchLabel.ResolveAndReduce): Ditto.
7922 (SwitchLabel.NullStringCase): Custom null stamp.
7923 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
7925 typemanager.cs (CSharpSignature): Don't skip first argument
7928 2005-09-18 Miguel de Icaza <miguel@novell.com>
7930 * driver.cs: Set InEmacs based on the environment variable EMACS.
7932 * location.cs (InEmacs): in this mode, do not report column
7933 location as it confuses Emacs.
7935 2005-09-16 Marek Safar <marek.safar@seznam.cz>
7937 * cfold.cs, constant.cs, convert.cs, ecore.cs,
7938 expression.cs, iterators.cs, literal.cs: Store constants and
7941 * class.cs (MemberBase.ShortName): Pass location.
7943 * cs-parser.jay: Some location fixes.
7945 * ecore.cs (Expression.Location): Made virtual.
7947 2005-09-05 Miguel de Icaza <miguel@novell.com>
7949 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
7950 if the underlying types are the same, otherwise we need to produce
7951 code that will do the proper cast.
7953 This was exposed by Marek's constant rewrite which produced
7954 invalid code for the call site:
7957 void Method (X v) {}
7961 This fixes test-49.cs
7963 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
7965 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
7966 Type/Object should be allowed as well. Fixed bug #75968.
7968 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
7970 * expression.cs : (Binary.DoResolve): when one is enum constant and
7971 another is constant 0, then return enum one *as enum type*.
7974 2005-09-02 Raja R Harinath <rharinath@novell.com>
7976 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
7980 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
7981 flow-branching for LocalVariableReferences in case we were invoked
7982 from a MemberAccess.
7983 * expression.cs (LocalVariableReference.VerifyAssigned): New.
7985 (LocalVariableReference.DoResolveBase): ... this.
7986 (MemberAccess.Resolve): Do the check that was disabled during
7989 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
7992 (PartialContainer.Create): check abstract/sealed/static strictly
7993 but abstract/sealed can exist only at one side. Fixed bug #75883.
7995 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
7998 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
7999 specified, don't default to UnmanagedType.I4.
8001 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
8003 * expression.cs : conditional operator should check possibly
8004 incorrect assign expression. Fixed bug #75946.
8006 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
8008 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
8009 Reverting the change. gmcs is much complex than mcs on this matter.
8011 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
8013 * cs-tokenizer.cs : To read another token ahead of the actual
8014 consumption, use new SavedToken and cache token instead of moving
8015 back the stream with SeekableStreamReader (it seemed problematic).
8017 driver.cs : Thus use StreamReader directly.
8018 * support.cs : Thus removed SeekableStreamReader.
8020 2005-08-30 Raja R Harinath <rharinath@novell.com>
8023 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
8024 (ScopeInfo.EmitScopeType): Use it to construct field names from
8025 names of captured locals.
8028 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
8029 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
8030 Pass 'target_type' to BoxedCast. Don't default to 'object'.
8031 (ExplicitConversion): Remove enum cases already handled by
8032 implicit conversion. Move implicit conversion check to the beginning.
8033 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
8034 * expression.cs (ArrayCreation.EmitDynamicInitializers):
8035 Don't treat System.Enum as a struct.
8037 2005-08-30 Jb Evain <jbevain@gmail.com>
8039 * attribute.cs: handles as expression in parameters.
8041 2005-08-30 Raja R Harinath <rharinath@novell.com>
8044 * class.cs (TypeContainer.VerifyClsName): Don't use a
8045 PartialContainer when verifying CLS compliance.
8046 (AbstractPropertyEventMethod): Set Parent here, ...
8047 (PropertyMethod): ... not here.
8049 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
8051 * attribute.cs : escaped attribute name should not be allowed to be
8052 resolved (e.g. @class as classAttribute). Fixed bug #75930.
8054 2005-08-29 Raja R Harinath <rharinath@novell.com>
8057 * convert.cs (ImplicitStandardConversionExists): Allow zero also
8058 when converting a long constant to unsigned long.
8059 * expression.cs (Invocation.OverloadResolve): Add sanity check to
8060 detect where IsApplicable and VerifyArgumentsCompat disagree.
8062 2005-08-29 Raja R Harinath <rharinath@novell.com>
8063 and Carlos Alberto Cortez <carlos@unixmexico.org>
8066 * class.cs (TypeContainer.CanElideInitializer): New helper.
8067 (TypeContainer.EmitFieldInitializers): Use it to determine if we
8068 can safely emitting the initializer of a field.
8070 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8072 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
8073 allowed inside a switch (without loop). Fixed bug #75433.
8075 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
8077 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
8078 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
8080 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8082 * driver.cs : kinda reverting the default encoding changes (not exact
8083 revert since I noticed that "codepage:reset" might not work fine).
8085 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8087 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
8088 Location. Now getter and setter store location correctly.
8089 (errors/cs0111-12.cs now reports the expected location.)
8091 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8093 * driver.cs : Use default encoding on the environment.
8094 Removed (now that) extra parameter for SeekableStreamReader.
8095 * support.cs : (SeekableStreamReader) third .ctor() argument for
8096 StreamReader is not required (always true). preamble size could
8097 be acquired in simpler and safe way.
8099 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
8101 * cs-parser.jay: report CS0642 at warning level 3
8102 and report CS0642 for an if else statement also
8103 fixes bug #74745. Patch by John Luke (and a bit
8105 Removed extra CS0642 warning check for "while",
8107 * statement.cs: In Block.Resolve(), CS0642 check
8108 is reimplemented to check a sequence of an empty
8109 statement and a block.
8111 Both fix bug #66777.
8113 2005-08-24 Marek Safar <marek.safar@seznam.cz>
8115 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
8116 detection until I fix it.
8118 * cs-tokenizer.cs: Changed error message.
8120 * cs-parser.jay: Fixed 2 error locations.
8122 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
8123 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
8126 * enum.cs (GetSignatureForError): Fixed.
8128 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
8132 * typemanager.cs (RegisterProperty): Removed.
8134 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
8136 2005-08-24 Raja R Harinath <rharinath@novell.com>
8139 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
8140 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
8142 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8144 * expression.cs : tiny fix is required for not warning positive ulong.
8147 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8149 * expression.cs : add CS0652 check for constant and integral
8150 expression. Fixed bug #53974.
8152 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8154 * expression.cs : in DoNumericPromotions(), check if there is implicit
8155 conversion overload for string (to check CS0034). Fixed bug #52492.
8157 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8159 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
8161 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8163 * ecore.cs : report location when it is *not* Null.
8165 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8171 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
8172 correctly. Fixed bug #75721.
8174 2005-08-23 Raja R Harinath <rharinath@novell.com>
8176 * support.cs (SeekableStreamReader.Position): Avoid an expensive
8177 loop that performs 'min (pos, char_count)'.
8180 * expression.cs (Unary.ResolveOperator): Don't discard implicit
8181 converted value in Operator.OnesComplement.
8183 2005-08-22 Ben Maurer <bmaurer@ximian.com>
8185 * anonymous.cs: If the anon method is pulled into a helper class,
8186 it needs to be `internal' not `private'. Fixes runtime behavior on
8189 2005-08-20 Martin Baulig <martin@ximian.com>
8191 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
8192 scope if we don't already have it.
8194 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
8195 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
8198 2005-08-17 Marek Safar <marek.safar@seznam.cz>
8201 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
8204 2005-08-16 Marek Safar <marek.safar@seznam.cz>
8206 The big constants rewrite
8207 Fix #75746, #75685 and more
8208 As a side effect saved 1MB for MWF ;-)
8210 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
8211 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
8212 enum based for corlib compilation.
8214 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
8217 * class.cs (FixedField.Define): Use ResolveAsConstant.
8219 * const.cs (IConstant): Interface constants and enums.
8220 (Const.ResolveValue): New method for constant resolvning.
8221 (ExternalConstant): Constants from imported assemblies.
8223 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
8224 conversion; like enums.
8225 (Constant.ToType): Converts this constant to different type.
8226 (Constant.Increment): Adds 1.
8228 * convert.cs (ImplicitConversionRequired): Simplified.
8230 * cs-parser.jay: Create EnumMember directly.
8232 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
8234 * doc.cs (GenerateEnumDocComment): Removed.
8236 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
8237 (ConvertIntLiteral): Removed.
8238 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
8240 * enum.cs (EnumMember): Implement IConstant.
8241 (Enum.IsValidEnumConstant): Removed.
8242 (Enum.GetNextDefaultValue): Removed.
8243 (Enum.FindMembers): Updated.
8244 (Enum.GenerateDocComment): Iterate enum members.
8246 * expression.cs (Cast.TryReduce): Handle enums correctly.
8247 (New.Constantify): Made public.
8248 (MemberAccess.DoResolve): Removed contant specific if(s).
8250 * literal.cs (NullLiteral): Implement new abstract methods.
8252 * statement.cs (GotoCase.Resolve): Use new constant methods.
8253 (SwitchLabel.ResolveAndReduce): Use new constant methods.
8255 * typemanager.cs (LookupEnum): Removed.
8256 (IsEnumType): Fixed to work with corlib.
8257 (RegisterConstant): Removed.
8258 (LookupConstant): Removed.
8259 (GetConstant): Changed to work with IConstant.
8261 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
8263 * location.cs : Fixed overflown (>255) column number.
8265 2005-08-03 Raja R Harinath <rharinath@novell.com>
8267 First cut of the qualified-alias-member feature.
8268 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
8270 * cs-parser.jay (DOUBLE_COLON): New token.
8271 (namespace_or_type_name): Add rule for recognizing
8272 qualified-alias-members.
8273 (primary_expression): Likewise.
8274 (element_access): Allow QualifiedAliasMember as a possible
8275 type-bearing expression.
8276 (local_variable_type, local_variable_pointer_type): Likewise.
8277 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
8278 aliases in the current and enclosing namespace declarations.
8279 (NamespaceEntry.UsingAlias): Add CS0440 warning.
8280 * decl.cs (MemberName.is_double_colon): New.
8281 (MemberName.MemberName): Add new constructor for alias-member.
8282 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
8283 * expression.cs (QualifiedAliasMember): New expression type.
8285 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8287 * location.cs : it borked when no argument was specified.
8289 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8291 * location.cs : tiny ToString() format fix.
8293 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8295 * statement.cs : oops, it was missing.
8297 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8299 A set of fixes for precise line/column location.
8302 "token" field now holds a file/line "delta", a line number offset
8303 from the segment, and a column number. See also:
8304 http://lists.ximian.com/pipermail/mono-devel-list/2004-
8305 December/009508.html
8306 Removed static IsNull. Use instance IsNull property instead.
8308 For some tokens it stores Location. For Identifier it stores
8309 LocatedToken which is a pair of string name and location.
8310 Column numbers are adjusted only at getChar().
8312 Use Location.ToString() for reporting (it now contains column).
8314 Largely modified to use LocatedToken instead of
8315 string (IDENTIFIER), and to acquire Location from some tokens.
8316 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
8317 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
8319 Now MemberName holds Location. DeclSpace.ctor() receives Location
8320 as a parameter. Removed extra parameters to all derived classes.
8321 Replaced Location.IsNull() with instance property.
8322 * assign.cs, expression.cs :
8323 Added .ctor() overload that omits Location.
8325 Added "nameEscaped" flag that indicates the identifier was escaped
8326 in the source file. This fixes bug #57047.
8328 2005-08-02 Marek Safar <marek.safar@seznam.cz>
8330 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
8331 New method, looking for lo-case imported cls type.
8333 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
8336 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
8338 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
8340 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
8342 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
8344 Optimized to save 3.5 MB for SWF compilation.
8346 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8348 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
8349 (PartialContainer.Create): Moved logic AddToContainer.
8350 (PartialContainer.MarkForDuplicationCheck): Shares name.
8352 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
8355 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
8357 (Namespace.GetSignatureForError): New method.
8359 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
8360 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
8362 2005-08-01 Raja R Harinath <rharinath@novell.com>
8365 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
8366 member lookup rather than qualifier_type, since qualifier_type can
8369 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8371 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
8374 2005-07-31 Miguel de Icaza <miguel@novell.com>
8376 * statement.cs: Copy the local exception into the exception
8377 captured local. Fixes 75674
8379 2005-07-31 Raja R Harinath <harinath@gmail.com>
8382 * expression.cs (Invocation.OverloadResolve): Don't report error
8383 CS1501 if error CS1502 has been reported.
8384 (New.DoResolve): Delegate CS1501 reporting to
8385 Invocation.OverloadResolve.
8388 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
8389 invariant-meaning-in-block property in an enclosing block if
8392 2005-07-29 Marek Safar <marek.safar@seznam.cz>
8394 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
8395 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
8396 (Switch.CheckSwitch): Just save 50kb for SWF.
8398 2005-07-27 Martin Baulig <martin@ximian.com>
8400 * anonymous.cs (CaptureContext.AddField): Added
8401 `AnonymousContainer am' argument; compute its toplevel scope if
8402 it's not already computed. Fixes #75649.
8404 2005-07-26 Raja R Harinath <rharinath@novell.com>
8407 * class.cs (Constructor.Emit): Reset block to null if the block
8410 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8412 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
8414 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8416 * class.cs (MethodData.Define): Check whether accessor implementing
8417 interface is public.
8419 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
8421 2005-07-22 Marek Safar <marek.safar@seznam.cz>
8424 * namespace.cs (LookupType): Moved same type check to...
8426 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
8429 2005-07-21 Raja R Harinath <rharinath@novell.com>
8431 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
8432 already found a typebuilder.
8433 * class.cs (MethodCore.IsDuplicateImplementation): Compare
8434 MemberNames, not strings.
8436 * const.cs (Error_ExpressionMustBeConst):
8437 Rename from Error_EpressionMustBeConst.
8438 * const.cs, class.cs, statement.cd: Update.
8440 2005-07-21 Marek Safar <marek.safar@seznam.cz>
8444 * const.cs (Const.LookupConstantValue): Report missing contant expression
8446 (Error_EpressionMustBeConstant): Only one error method.
8448 * class.cs, statement.c: Updated.
8450 2005-07-20 Raja R Harinath <rharinath@novell.com>
8452 * statement.cs (Block.Flags): Add back HasVarargs.
8453 (Block.flags): Make protected.
8454 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
8456 * typemanager.cs (types, typecontainers, user_types): Remove.
8457 (UserTypes, TypeContainers): Likewise.
8458 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
8459 (CleanUp, Reset): Update.
8460 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
8461 (GetNestedType): Use Type.GetNestedType.
8462 (CoreLookupType): Take two arguments, the namespace and the
8463 basename of the type. Update to use the Namespace.Lookup
8465 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
8466 (RealMemberLookup): Use IsNestedChildOf instead of playing with
8467 string concatenation and substring matches.
8468 * class.cs, enum.cs, delegate.cs: Update to changes.
8470 2005-07-20 Marek Safar <marek.safar@seznam.cz>
8472 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
8473 Expression and made virtual.
8475 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
8476 (ImplicitStandardConversionExists): Fixed `byte' typo ?
8478 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
8480 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
8483 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
8486 2005-07-18 Marek Safar <marek.safar@seznam.cz>
8489 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
8490 AssemblyCultureAttribute is not used on executable.
8493 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
8495 2005-07-16 Raja R Harinath <rharinath@novell.com>
8498 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
8499 New. Reports CS0252/CS0253.
8500 Mostly taken from preliminary patch by Duncak Mak.
8501 (Binary.DoResolveOperator): Store results of operator lookup.
8502 Use them to detect if we need to warn about unintended reference
8505 2005-07-15 Raja R Harinath <rharinath@novell.com>
8508 * namespace.cs (Namespace.Lookup): Add back location parameter.
8509 (Namespace.LookupType): Add CS0436 report. Add location parameter.
8510 * delegate.cs, ecore.cs, expression.cs: Update to changes.
8512 * codegen.cs (EmitContext.DeclSpace): Make readonly.
8513 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
8514 (Namespace.LookupType): ... this.
8515 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
8517 * typemanager.cs (LookupTypeReflection): Remove buggy code that
8518 purported to handle pointers.
8519 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
8522 2005-07-15 Marek Safar <marek.safar@seznam.cz>
8524 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
8527 2005-07-15 Raja R Harinath <rharinath@novell.com>
8529 * namespace.cs (Namespace.Lookup): Drop location parameter.
8530 (NamespaceEntry.LookupAlias): Remove. Merge into ...
8531 (NamespaceEntry.Lookup): ... this.
8532 (NamespaceEntry.Error_AmbiguousTypeReference):
8533 Move here from DeclSpace.
8534 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
8536 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
8537 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
8538 Move to NamespaceEntry.
8539 * delegate.cs, expression.cs: Update to changes.
8541 2005-07-14 Marek Safar <marek.safar@seznam.cz>
8543 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
8544 CheckAttributeType and refactored.
8545 (Attribute.ResolvePossibleAttributeType): Changed to reuse
8546 ResolveAsTypeTerminal error handling.
8547 (ResolveAsTypeTerminal): Introduced because of global attributes extra
8549 (GetSignatureForError): Print errors in same way.
8552 * codegen.cs: Reflect attribute GetSignatureForError change.
8555 * expression.cs: Add silent parameter to ResolveAsTypeStep.
8557 * namespace.cs (UsingEntry): Refactored to make fields private.
8560 statement.cs: Error_UnexpectedKind has extra parameter.
8562 2005-07-14 Raja R Harinath <rharinath@novell.com>
8564 * ecore.cs (IAlias): Remove.
8565 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
8566 that implement the interface.
8567 * namespace.cs (Namespace): Likewise.
8568 (Namespace.declspaces): Renamed from 'defined_names'.
8569 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
8570 DeclSpace instead of an IAlias.
8571 * tree.cs (Tree.AddDecl): Update.
8573 2005-07-12 Raja R Harinath <rharinath@novell.com>
8575 * statement.cs (Block.Flags); Remove HasVarargs.
8576 (Block.HasVarargs): Move to ToplevelBlock.
8577 (Block.ThisVariable, Block.AddThisVariable): Likewise.
8578 (Block.Variables): Make protected. Initialize variable hashtable
8580 (Block.AddVariable): Update.
8581 (Block.Resolve): Update to changes.
8582 (ToplevelBlock.HasVarargs): New boolean.
8583 (ToplevelBlock.ThisVariable): Move here from Block.
8584 (ToplevelBlock.AddThisVariable): Likewise.
8585 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
8586 * expression.cs (This.ResolveBase): Update to changes.
8587 (ArglistAccess.DoResolve): Likewise.
8589 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8592 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
8594 * class.cs (TypeContainer.VerifyMembers): Distinguish between
8595 not used and not used & assigned.
8596 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
8598 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8601 * expression.cs (Is.DoResolve): null is never provided type.
8603 2005-07-08 Marek Safar <marek.safar@seznam.cz>
8606 * cs-parser.jay: Less strict event error rule to catch more errors.
8608 2005-07-08 Martin Baulig <martin@ximian.com>
8610 Fix test-iter-10.cs - distinguish whether we `yield' in a property
8611 gettter (allowed) or setter (not allowed).
8613 * class.cs (Accessor): Implement IIteratorContainer.
8614 (Accessor.Yields): New public field.
8615 (PropertyBase.PropertyMethod.Define): Handle iterators on a
8619 (get_accessor_declaration, set_accessor_declaration): Set the
8620 `yields' flag on the accessor, not the property.
8621 (property_declaration): Do the iterators check on a per-accessor
8622 basis and not for the whole property.
8624 2005-07-08 Martin Baulig <martin@ximian.com>
8626 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
8627 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
8629 2005-07-07 Marek Safar <marek.safar@seznam.cz>
8632 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
8633 (ExtractSecurityPermissionSet): Cope with self referencing security
8634 attributes properly.
8636 * driver.cs (SetOutputFile): Made public property OutputFile.
8638 2005-07-07 Raja R Harinath <rharinath@novell.com>
8641 * class.cs (TypeContainer.first_nonstatic_field): Rename from
8642 has_nonstatic_fields. Make into a FieldBase pointer.
8643 (TypeContainer.AddField): Add CS0282 check.
8644 (TypeContainer.EmitType): Update.
8646 2005-07-06 Miguel de Icaza <miguel@novell.com>
8648 * cs-tokenizer.cs (consume_identifier): Do not create strings to
8649 compare if they start with __.
8651 2005-07-06 Raja R Harinath <rharinath@novell.com>
8653 * statement.cs (Switch.SwitchGoverningType): Only look at
8654 UserCasts that don't need implicit standard conversions to one of
8655 the allowed switch types (Fixes test-322.cs).
8656 (LocalInfo.Resolve): Re-enable sanity-test.
8658 2005-07-06 Marek Safar <marek.safar@seznam.cz>
8660 * cs-tokenizer.cs (consume_identifier): Detect double undescores
8662 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
8664 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
8666 2005-07-06 Raja R Harinath <rharinath@novell.com>
8669 * ecore.cs (SimpleName.GetSignatureForError): Add.
8670 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
8671 (MemberAccess.GetSignatureForError): Add.
8673 2005-07-05 Marek Safar <marek.safar@seznam.cz>
8675 The big error and warning messages review.
8705 * typemanager.cs: Updated.
8707 * class.cs: (MethodCore.SetYields): Moved here to share.
8708 (PropertyMethod.Define): Moved iterator setup here.
8710 * iterators.cs: Add orig_method to have full access to parent
8713 2005-07-05 Raja R Harinath <rharinath@novell.com>
8715 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
8716 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
8717 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
8718 variable of struct type.
8719 * expression.cs (Unary.ResolveOperator): Update to change.
8720 (Indirection.VerifyFixed): Likewise.
8721 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
8722 (ParameterReference.VerifyFixed): Value parameters are fixed.
8723 (This.VerifyFixed): Treat 'this' as a value parameter.
8724 * statement.cs (LocalInfo.IsFixed): Remove.
8726 2005-07-01 Martin Baulig <martin@ximian.com>
8728 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
8729 `ec.EmitThis ()' to get the correct scope.
8731 2005-07-01 Martin Baulig <martin@ximian.com>
8733 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
8734 instance is a ParameterReference; fixes #75299.
8736 2005-07-01 Martin Baulig <martin@ximian.com>
8738 Reverted Marek's latest patch (r46725):
8739 - it contains structural changes which are neither mentioned in
8740 the ChangeLog nor explained anywhere; for example the additional
8741 argument of EmitContext's and Iterator's .ctor's and the
8742 TypeContainer.DefineMembers() change.
8743 - structural changes like this should go in in seperate patches
8744 and not be hidden in a huge patch which just seems to affect
8745 warnings and errors.
8746 a big and hard to understand patch.
8747 - it breaks iterators and causes regressions, for instance in
8750 2005-06-30 Raja R Harinath <rharinath@novell.com>
8753 * expression.cs (Indexers.map): Remove.
8754 (Indexers.Append): Filter out inaccessible setters and getters.
8755 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
8758 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
8760 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
8761 (FieldExpr.Emit, PropertyExpr.Emit): Update.
8762 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
8763 * expression.cs (Invocation.EmitCall): Add CS0120 check.
8765 2005-06-30 Marek Safar <marek.safar@seznam.cz>
8768 * class.cs (FieldBase.GetInitializerExpression): One more field
8771 2005-06-28 Miguel de Icaza <miguel@novell.com>
8773 * pending.cs: Do not define a proxy if the base method is virtual,
8774 it will be picked up by the runtime (bug 75270).
8776 2005-06-08 Martin Baulig <martin@ximian.com>
8778 The big Iterators rewrite :-)
8780 * iterators.cs: Rewrite this to use the anonymous methods framework.
8782 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
8783 before the TypeContainers; see 2test-21.cs.
8786 (TypeContainer.DefineType): Don't create a new EmitContext if we
8787 already have one (this only happens if we're an Iterator).
8788 (TypeContainer.Define): Also call Define() on all our iterators.
8789 (Method.CreateEmitContext): Added support for iterators.
8792 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
8793 (AnonymousContainer.CreateMethodHost): Moved here from
8794 AnonymousMethod and made abstract.
8795 (AnonymousContainer.CreateScopeType): New abstract method.
8796 (AnonymousContainer.IsIterator): New public property.
8797 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
8798 get the ScopeTypeBuilder rather than manually defining it here.
8799 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
8802 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
8803 before RootContext.DefineTypes().
8805 * codegen.cs (EmitContext.RemapToProxy): Removed.
8806 (EmitContext.CurrentAnonymousMethod): Changed type from
8807 AnonymousMethod -> AnonymousContainer.
8808 (EmitContext.ResolveTopBlock): Protect from being called twice.
8809 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
8810 (EmitContext.EmitThis): Removed the iterators hacks; use the
8811 anonymous methods framework for that.
8814 (ToplevelBlock.Container): Make this a property, not a field.
8815 (ToplevelBlock.ReParent): New public method; move the
8816 ToplevelBlock into a new container.
8817 (Foreach.TemporaryVariable): Simplify.
8819 2005-06-05 Martin Baulig <martin@ximian.com>
8821 * statement.cs (LocalInfo.CompilerGenerated): New flag.
8822 (Block.AddTemporaryVariable): New public method; creates a new
8823 `LocalInfo' for a temporary variable.
8824 (Block.EmitMeta): Create the LocalBuilders for all the temporary
8826 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
8827 non-iterator variables.
8829 2005-06-05 Martin Baulig <martin@ximian.com>
8831 * statement.cs (Foreach.TemporaryVariable): Create the
8832 LocalBuilder in the Emit phase and not in Resolve since in some
8833 situations, we don't have an ILGenerator during Resolve; see
8834 2test-19.cs for an example.
8836 2005-06-04 Martin Baulig <martin@ximian.com>
8838 **** Merged r45395 from GCS ****
8840 The big Foreach rewrite - Part II.
8842 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
8843 with `PropertyInfo ienumerator_getcurrent'.
8845 * codegen.cs (VariableStorage): Removed.
8848 (Foreach): Derive from Statement, not ExceptionStatement.
8849 (Foreach.CollectionForeach): New nested class. Moved all the code
8850 dealing with collection foreach here.
8851 (Foreach.ForeachHelperMethods): Removed.
8852 (Foreach.TemporaryVariable): Implement IMemoryLocation.
8854 2005-05-23 Martin Baulig <martin@ximian.com>
8856 * statement.cs (Try.DoResolve): Don't create a `finally' if we
8857 don't need to. Fix #75014.
8859 2005-05-20 Martin Baulig <martin@ximian.com>
8861 Merged r44808 from GMCS.
8863 * class.cs (TypeContainer.CircularDepException): Removed.
8864 (TypeContainer.DefineType): Removed the `InTransit' stuff.
8865 (TypeContainer.CheckRecursiveDefinition): Check for circular class
8866 (CS0146) and interface (CS0529) dependencies here.
8868 2005-06-21 Raja R Harinath <rharinath@novell.com>
8870 * expression.cs (Invocation.EmitCall): Fix initialization
8871 'this_call' to reflect current behaviour. Fix indentation.
8873 * convert.cs (FindMostEncompassedType): Add two trivial special
8874 cases (number_of_types == 0 || number_of_types == 1).
8875 (FindMostEncompasingType): Likewise.
8877 2005-06-17 Raja R Harinath <rharinath@novell.com>
8879 Some cleanups preparing for the fix of #75283.
8880 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
8882 (EventExpr.InstanceResolve): Likewise.
8883 (EventExpr.DoResolve): Remove redundant checks.
8885 2005-06-10 Duncan Mak <duncan@novell.com>
8887 * cs-tokenizer.cs (process_directives): New flag for controlling
8888 the processing of preprocessor directives.
8889 (x_token): After seeing a '#', return Token.NONE instead of going
8890 to handle_preprocessing_directive() when not processing
8891 directives. This avoids unnecessary processing during the token peek in
8896 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
8897 the existing error reporting methods instead of Report.Error.
8899 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
8900 after Raja's rewrite.
8902 2005-06-08 Miguel de Icaza <miguel@novell.com>
8904 * class.cs: Small fix.
8906 2005-06-08 Raja R Harinath <rharinath@novell.com>
8909 * class.cs (GetPartialBases): Fix return value check of
8912 2005-06-07 Raja R Harinath <rharinath@novell.com>
8914 Ensure that partial classes are registered in their enclosing
8915 namespace. Initial part of fix of #75160.
8916 * tree.cs (Tree.RecordDecl): Add new namespace argument.
8917 Register declspace with namespace here, not in
8918 DeclSpace.RecordDecl.
8919 * cs-parser.jay: Pass namespace to RecordDecl.
8920 * class.cs (PartialContainer.Create): Likewise.
8921 (ClassPart.DefineType): New sanity-check. Throws an exception if
8923 * decl.cs (Declspace.RecordDecl): Remove.
8924 * namespace.cs (NamespaceEntry.DefineName): Remove.
8926 2005-06-06 Marek Safar <marek.safar@seznam.cz>
8928 * rootcontext.cs: Reset TargetExt as well.
8930 2005-06-03 Raja R Harinath <rharinath@novell.com>
8932 * ecore.cs (Expression.Resolve): Emit CS0654 error when
8935 2005-06-02 Raja R Harinath <rharinath@novell.com>
8937 Fix #75080, cs0119.cs.
8938 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
8940 (Expression.Resolve): ... this. Use it. Remove bogus code
8941 allowing ExprClass.Type and ExprClass.Namespace for
8942 ResolveFlags.VariableOrValue.
8943 (Expression.Resolve) [1-argument variant]: Change default resolve
8944 flags based on language version.
8945 (Expression.Error_UnexpectedKind): Use a simple string array
8946 rather than an ArrayList.
8947 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
8949 (TypeOfVoid.DoResolve): Likewise.
8950 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
8951 flags argument -- it always has the same value.
8953 2005-05-31 Raja R Harinath <rharinath@novell.com>
8956 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
8957 Use it in the error message.
8958 * assign.cs, expression.cs, statement.cs: Update.
8960 2005-05-30 Raja R Harinath <rharinath@novell.com>
8963 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
8964 the "almostMatchedMember" case too.
8965 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
8966 that failed the accessibility checks to 'almost_match'.
8968 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
8970 * attribute.cs: Use internal MethodBuilder methods to set
8971 ExactSpelling and SetLastError on PInvoke methods, instead
8972 of passing them via charset. Fixes #75060.
8974 2005-05-27 Raja R Harinath <rharinath@novell.com>
8976 * parameter.cs (Parameter): Remove TODO comment.
8977 (Parameter.DefineParameter): Remove Location parameter.
8978 (Parameters.LabelParameters): Likewise.
8979 * class.cs (Constructor.Emit): Update to change.
8980 (MethodData.Emit): Likewise.
8981 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
8982 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
8984 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
8987 Removed Parameters.Location and added Parameter.Location instead.
8988 Removed Location parameter from Emit() and GetSignature().
8995 Modified all related calls.
8997 2005-05-26 Raja R Harinath <rharinath@novell.com>
8999 Improve user-defined conversion handling.
9000 * convert.cs (GetConversionOperators): Rewrite. Return only the
9001 applicable operators.
9002 (AddConversionOperators): New. Helper for GetConversionOperators.
9003 (FindMostEncompassedType, FindMostEncompassingType): Verify that
9004 there is only one most encompassed/encompassing type.
9005 (FindMostSpecificSource, FindMostSpecificTarget): Remove
9006 "applicable operator" handling.
9007 (UserConversion): Move cache here from GetConversionOperators.
9008 Directly cache the chosen operator, rather than the whole
9010 (ExplicitNumericConversion): Fix buggy implementation of Decimal
9011 case. Allow conversion of decimal to sbyte and byte too.
9012 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9013 New static methods. Used to avoid allocating EmptyExpressions in
9016 2005-05-24 Duncan Mak <duncan@novell.com>
9018 * ecore.cs (CastFromDecimal): New class for casting a decimal to
9019 another class, used in Convert.ExplicitNumericConversion.
9020 (CastToDecimal): New class, similar to above, but casts to
9021 System.Decimal, used in Convert.ImplicitNumericConversion and also
9022 in explicit convesion from double/float to decimal.
9024 * convert.cs (ImplicitNumericConversion): Handle implicit
9025 conversions to System.Decimal.
9026 (ExplicitNumericConversion): handle explicit conversions to
9031 2005-05-20 Miguel de Icaza <miguel@novell.com>
9033 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
9034 know the type at this stage, just break through. Fixes #75008
9036 2005-05-19 Martin Baulig <martin@ximian.com>
9039 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
9040 to disable error reporting.
9042 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
9043 here since we don't want to report an error; see the new test-336.cs.
9045 2005-05-19 Raja R Harinath <rharinath@novell.com>
9047 * statement.cs (ToplevelBlock.GetParameterReference)
9048 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
9049 Move here from class Block.
9050 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
9051 * expression.cs (ParameterReference.DoResolveBase): Likewise.
9053 2005-05-18 Martin Baulig <martin@ximian.com>
9058 (FlowBranching.Reachability): Add non-static public And() and Or()
9060 (FlowBranchingSwitch): New class; do the `break_origins' thing
9061 like in FlowBranchingLoop.
9062 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
9063 reachability, not just locals and parameters.
9064 (FlowBranching.MergeChild): Remove some of the hacks for loop and
9065 switch; MergeBreakOrigins() now takes care of that.
9067 2005-05-18 Martin Baulig <martin@ximian.com>
9069 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9070 a loop and may leave it, reset the barrier; fixes #74974.
9072 2005-05-17 Marek Safar <marek.safar@seznam.cz>
9074 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
9077 * cs-parser.jay: Catch more lexical errors.
9079 * report.cs: Add one more Error method.
9082 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
9084 2005-05-17 Martin Baulig <martin@ximian.com>
9086 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
9089 2005-05-16 Raja R Harinath <rharinath@novell.com>
9091 Fix test-382.cs. Emit values of decimal constants.
9092 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
9094 (TypeContainer.AddField): ... this.
9095 (TypeContainer.EmitFieldInitializers): Allow the list of fields
9096 with initializers to include 'Const's.
9097 (ClassPart.RegisterFieldForInitialization): Forward to
9099 * const.cs (Const.Const): Pass initializer to base class.
9100 (Const.Define): In case of decimal constants, register them for
9101 initialization in a static constructor.
9103 2005-05-14 Martin Baulig <martin@ximian.com>
9105 * statement.cs (Block.Resolve): Correctly handle unreachable code;
9106 do not call ResolveUnreachable() on unreachable statements in
9107 here, see the comment in the source code.
9109 2005-05-13 Raja R Harinath <rharinath@novell.com>
9112 * expression.cs (BinaryResolveOperator): If one of the operands of
9113 an equality comparison is 'null' and the other is a pointer type,
9114 convert the null to a NullPointer.
9115 * convert.cs (ImplicitReferenceConversion): If the expression is a
9116 NullLiteral and the target type is a pointer type, return a
9117 NullPointer instead.
9118 (ImplicitConversionStandard): Likewise.
9120 2005-05-13 Marek Safar <marek.safar@seznam.cz>
9122 * cs-parser.jay: Set readonly context based on special constructs.
9124 * expression.cs (LocalVariableReference.DoResolveBase): Improved
9125 readonly variable error handling.
9127 * rootcontext.cs (EmitCode): Don't verify members when error
9130 * statement.cs (LocalInfo): Add reaodnly context information.
9131 (SetReadOnlyContext, GetReadOnlyContext): New methods.
9133 2005-05-13 Raja R Harinath <rharinath@novell.com>
9135 * statement.cs (Block.Resolve): Revert change below. Modify fix
9136 for #74041 to initialize 'resolved' to false only for explicit
9137 blocks. Fixes #74873.
9139 2005-05-12 Raja R Harinath <harinath@gmail.com>
9142 * typemanager.cs (unmanaged_enclosing_types): New.
9143 (IsUnmanagedType): Avoid infloops by using
9144 'unmanaged_enclosing_types' to talk with recursive invocations.
9146 2005-05-13 Martin Baulig <martin@ximian.com>
9148 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
9149 instance variable, not a local. Fix #74873.
9150 (Block.ResolveUnreachable): Set it to true here.
9152 2005-05-11 Duncan Mak <duncan@novell.com>
9154 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
9155 continuing to process for 'arg'.
9156 (handle_preprocessing_directive): Check the argument of the #endif
9157 directive and report error CS1025 if there are any trailing
9160 According to the C# spec, having even whitespace after the #endif
9161 directive is illegal; however, because we call arg.TrimEnd ()
9162 beforehand, we have the same behavior as csc, allowing whitespace
9163 after the directive.
9167 2005-05-11 Marek Safar <marek.safar@seznam.cz>
9171 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
9172 (Constructor.GetObsoleteAttribute): Implemented correctly.
9174 2005-05-10 Martin Baulig <martin@ximian.com>
9176 * support.cs (ReflectionParameters.ParameterModifier): Use
9177 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
9178 and `ParameterAttributes.In'. Fixes #74884.
9180 2005-05-10 Marek Safar <marek.safar@seznam.cz>
9182 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
9184 * expression.cs (Argument.GetParameterModifier): Turned to property.
9185 (Invocation.Error_InvalidArguments): Add more descriptive errors.
9187 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
9190 2005-05-09 Raja R Harinath <rharinath@novell.com>
9193 * decl.cs (MemberCache.AddMethods): Register override methods,
9194 rather than non-override methods.
9195 * typemanager.cs (RegisterOverride): New.
9196 (IsOverride): Update.
9198 2005-05-09 Marek Safar <marek.safar@seznam.cz>
9202 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
9203 recursive declaration.
9205 * statement.cs (Block.ResolveMeta): Report any error in resolving.
9207 2005-05-06 Marek Safar <marek.safar@seznam.cz>
9209 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
9211 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
9213 2005-05-05 Raja R Harinath <rharinath@novell.com>
9216 * decl.cs (DeclSpace.FamilyAccessible):
9217 Use TypeManager.IsNestedFamilyAccessible.
9219 Fix reopened #64812.
9220 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
9223 2005-05-04 Raja R Harinath <rharinath@novell.com>
9224 Abin Thomas <projectmonokochi@rediffmail.com>
9225 Anoob V E <projectmonokochi@rediffmail.com>
9226 Harilal P R <projectmonokochi@rediffmail.com>
9229 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
9230 allow access to all static members.
9232 2005-05-04 Martin Baulig <martin@ximian.com>
9234 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
9236 2005-05-04 Martin Baulig <martin@ximian.com>
9240 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
9241 section at the end; make things work if `default' is not the last
9244 2005-05-04 Martin Baulig <martin@ximian.com>
9248 * statement.cs (Switch): Replaced the `got_default' field with a
9249 `default_section' one.
9250 (Switch.CheckSwitch): Set `default_section' here.
9251 (Switch.Resolve): If we're a constant switch and the constant is
9252 not found, use the default section.
9254 2005-05-03 Martin Baulig <martin@ximian.com>
9256 * expression.cs (ArrayAccess.EmitGetLength): New public method.
9258 * statement.cs (Foreach.ArrayForeach): New nested class.
9259 (Foreach.TemporaryVariable): New nested class.
9260 (Foreach.EmitArrayForeach): Removed; this is now in the new
9263 2005-05-03 Raja R Harinath <rharinath@novell.com>
9265 * pending.cs (BaseImplements): Move the #74773 fix here. This is
9267 (VerifyPendingMethods): Revert change below.
9269 * typemanager.cs (IsOverride, RegisterNonOverride): New.
9270 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
9271 that used to trigger warning -28. Remove warning -28.
9272 * expression.cs (Invocation.OverloadResolve): Use
9273 TypeManager.IsOverride to distinguish override methods.
9276 * pending.cs (VerifyPendingMethods): If a base type implements the
9277 requested interface, don't bother checking individual methods of
9278 the base type. As a side-effect, this prevents the creation of
9279 unnecessary proxies.
9281 2005-05-02 Martin Baulig <martin@ximian.com>
9285 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9286 Also `And' the locals if the old vector is null.
9287 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
9288 null; in this case we basically reset all the variables.
9290 2005-05-02 Martin Baulig <martin@ximian.com>
9294 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
9295 Added `FlowBranching branching' argument; always `and' the
9296 variables instead of `or'ing them unless we're an infinite loop.
9298 * statement.cs (While.Resolve): Create a new sibling unless we're
9301 2005-05-02 Martin Baulig <martin@ximian.com>
9305 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
9306 arguments; use it instead of creating a new TopLevelBlock.
9307 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
9308 our ConstructorInitializer.
9311 (TopLevelBlock.TopLevelBranching): New public property.
9312 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
9313 and create our `TopLevelBranching'.
9315 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
9316 anonymous method host, use `block.TopLevelBranching' rather than
9317 creating a new branching.
9319 2005-04-20 Miguel de Icaza <miguel@novell.com>
9321 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
9322 a ScopeInfo, if any of the current children is a child of the new
9323 entry, move those children there.
9325 2005-04-30 Martin Baulig <martin@ximian.com>
9327 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
9328 at the beginning of a SwitchSection. Fix #73335.
9330 2005-04-27 Marek Safar <marek.safar@seznam.cz>
9333 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
9335 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
9336 (FieldExpr.DoResolve): Obsolete members are ignored for field
9339 2005-04-26 Marek Safar <marek.safar@seznam.cz>
9341 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
9342 of arrays detection.
9344 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
9346 (Field.VerifyClsCompliance): Volatile fields are not compliant.
9348 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
9351 2005-04-25 Ben Maurer <bmaurer@ximian.com>
9353 * cs-parser.jay: Use the prefered version of -unsafe in error
9356 2005-04-22 Marek Safar <marek.safar@seznam.cz>
9358 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
9361 2005-04-20 John Luke <john.luke@gmail.com>
9363 * driver.cs: fix typo in error message, --outout to --output
9365 2005-04-20 Marek Safar <marek.safar@seznam.cz>
9367 * codegen.cs (InRefOutArgumentResolving): New field.
9369 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
9370 fields outside contructor.
9372 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
9374 2005-04-19 Miguel de Icaza <miguel@novell.com>
9376 * anonymous.cs (CaptureContext.EmitParameterInstance): The
9377 parameter code was not completed ever, so it was not as up-to-date
9378 as local variables. Must finish it.
9380 The bug fix was to compare the Toplevel of the block, not the
9381 current block. Thanks for Ben for pointing this out.
9383 2005-04-19 Raja R Harinath <rharinath@novell.com>
9385 * decl.cs (AddMethods): Use the declaring type of the problem
9386 method to determine if we want to squash a warning.
9388 2005-04-19 Marek Safar <marek.safar@seznam.cz>
9390 * attribute.cs: Removed debug output.
9392 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
9394 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
9397 2005-04-18 Raja R Harinath <rharinath@novell.com>
9400 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
9401 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
9402 all null comparisons against reference types.
9404 2005-04-18 Marek Safar <marek.safar@seznam.cz>
9407 * class.cs (TypeContainer.CircularDepException) New nested
9409 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
9410 (TypeContainer.DefineType): Removed error, reset InTransit before
9412 (Class.DefineType): Throw exception when is in Transit.
9413 Catch exception and report error.
9414 (Struct.DefineType): Throw exception when is in Transit.
9415 Catch exception and report error.
9416 (Interface.DefineType): Throw exception when is in Transit.
9417 Catch exception and report error.
9419 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
9420 handle nested exception handlers.
9422 * flowanalysis.cs (InTryWithCatch): New method, search for try with
9425 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
9426 InFinally and InCatch storage.
9428 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
9429 (Catch.Resolve): Set and Restore ec.InCatch.
9430 (Try.Resolve): Set and Restore ec.InFinally.
9431 (Try.HasCatch): True when try has catch.
9433 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
9435 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
9436 for the same event member, so exclude such cases from warning 419.
9439 2005-04-16 Miguel de Icaza <miguel@novell.com>
9441 * expression.cs (Binary.ResolveOperator): Apply patch from John
9442 Luke to fix bug 59864: operators &, | and ^ on enumerations
9443 require that the same enum type on both sides.
9445 * driver.cs: Add warnings to old flag usage, this is to assist
9446 people who produce Makefiles and hope that the Makefiles will be
9449 * class.cs (TypeContainer.EmitType): Moved the definition of the
9450 special $PRIVATE$ field from the resolve phase to the Emit phase.
9451 During resolve we do not know if we are a struct with
9452 HasExplicitLayout, we know this only after the attributes for the
9455 Set the FieldOffset to zero on the dummy field that we create for
9456 the class. Fixes 74590.
9458 2005-04-16 Raja R Harinath <rharinath@novell.com>
9461 * ecore.cs (PropertyExpr.resolved): New.
9462 (DoResolve): Use it to handle a case of double resolution here.
9463 Handle a case of identical-name-and-type-name.
9464 * expression.cs (ArrayCreation.CheckIndices): Avoid double
9465 resolution by storing the results of expression resolution back
9466 into the "probes" array.
9468 2005-04-15 Raja R Harinath <rharinath@novell.com>
9470 Fix cs0208-7.cs and cs0208-8.cs.
9471 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
9472 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
9473 error reporting to point out the reason a struct is not unmanaged.
9475 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9477 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
9478 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
9480 2005-04-13 Raja R Harinath <rharinath@novell.com>
9483 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
9484 IdenticalNameAndTypeName here.
9485 (EventExpr.InstanceResolve): Likewise.
9487 2005-04-13 Marek Safar <marek.safar@seznam.cz>
9489 C# 2.0 DefaultCharSetAttribute implementation
9491 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
9492 which allows us to set GlobalNamespace for every resolve.
9493 (Attribute.ResolveArguments): Cut from Resolve.
9494 (Attribute.GetCharSetValue): Returns CharSet named argument.
9495 (Attribute.DefinePInvokeMethod): Gets default charset from
9497 (GlobalAttribute.ResolveAsTypeStep): Override.
9498 (GlobalAttribute.ResolveArguments): Override.
9500 * class.cs (TypeAttr): Is protected.
9502 * codegen.cs (ModuleClass.DefaultCharSet): New member.
9503 (ModuleClass.DefaultCharSetType): New memeber.
9504 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
9506 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
9507 charset from module.
9509 * delegate.cs (TypeAttr): Override.
9510 (Delegate.DefineType): Use this TypeAttr.
9512 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
9513 at very early stage (before types are defined) to resolve model
9514 module attributes. It will probably not work with corlib but it
9517 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
9518 charset from module.
9520 * typemanager.cs (default_charset_type): New type.
9522 2005-04-13 Raja R Harinath <rharinath@novell.com>
9524 * decl.cs (MemberCache.AddMethods): Don't warn if
9525 System.Object.Finalize has buggy MethodAttributes.
9527 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
9530 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9532 * doc.cs : detect ambiguous reference to overloaded members.
9533 Fixed bug #71603. MS 1.1 csc does not detect it.
9535 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9537 * doc.cs : delegates must not be referenced with parameters.
9540 2005-04-12 Miguel de Icaza <miguel@novell.com>
9542 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
9544 2005-04-10 Miguel de Icaza <miguel@novell.com>
9546 * driver.cs (MainDriver): Stop processing if the CLS stage found
9549 (CompilerCallableEntryPoint.InvokeCompiler): Always
9550 reset after execution; Take a TextWriter argument for the
9553 * report.cs: Use the error stream instead of hardcoding stderr.
9555 2005-04-09 Miguel de Icaza <miguel@novell.com>
9557 * class.cs: Reduce code paths to test, too small of an
9558 optimization to make it worth the extra testing. Always perform
9561 2005-04-08 Raja R Harinath <rharinath@novell.com>
9564 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
9565 operators that had errors reported on them.
9567 2005-04-08 Marek Safar <marek.safar@seznam.cz>
9569 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
9571 (Attribute.Resolve): Add named argument type checking.
9573 * class.cs (FixedField.Define): Use IsPrimitiveType
9575 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
9577 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
9578 unsafe parameter types.
9580 * statement.cs (Using.ResolveExpression): Add better error description.
9582 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
9584 2005-04-08 Raja R Harinath <rharinath@novell.com>
9587 * attribute.cs (Attribute.GetAttributeUsage): Resolve
9588 AttributeUsageAttribute in the emitcontext of the attribute class,
9589 not in the emitcontext of the attributable entity it was attached to.
9590 * cs-parser.jay: Use 'current_class', not 'current_container',
9591 when creating a GlobalAttribute.
9593 2005-04-08 Alp Toker <alp@atoker.com>
9595 * pending.cs: The fix to #58413 failed to compile methods implementing
9596 interfaces with/without params modifiers and vice versa, even though
9597 params modifiers aren't part of the signature. Make the modifier check
9598 less strict as in csc.
9600 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
9601 Anoob V E <projectmonokochi@rediffmail.com>
9602 Harilal P R <projectmonokochi@rediffmail.com>
9605 * pending.cs (TypeAndMethods.mods): New. Store the parameter
9606 modifiers of pending methods.
9607 (PendingImplementation.PendingImplementation): Initialize it.
9608 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
9609 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
9610 with ParameterData. Add check for modifiers.
9611 * class.cs (MethodData.Define): Update to changes.
9613 2005-04-07 Raja R Harinath <rharinath@novell.com>
9615 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
9617 2005-04-07 Marek Safar <marek.safar@seznam.cz>
9619 * class.cs (PropertyMethod.Define): Check private accessor in abstract
9622 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
9625 * typemanager.cs: Registered RequiredAttributeAttribute.
9627 2005-04-06 Marek Safar <marek.safar@seznam.cz>
9629 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
9630 Warning CS0169 is back at level 3.
9631 (IMethodData.SetMemberIsUsed): New method.
9633 * decl.cs (IsUsed): New value; moved from FieldBase.Status
9634 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
9636 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
9638 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
9640 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
9643 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
9646 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
9647 to avoid the problems with nested types.
9649 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
9650 Anoob V.E <projectmonokochi@rediffmail.com>
9651 Harilal P.R <projectmonokochi@rediffmail.com>
9652 Raja R Harinath <rharinath@novell.com>
9655 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
9657 * typemanager (GetConstructor): Make public.
9659 2005-04-05 John Luke <john.luke@gmail.com>
9660 Raja R Harinath <rharinath@novell.com>
9663 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
9664 struct too. Return false quicker in a few cases.
9665 (VerifyUnManaged): Use it.
9667 2005-04-05 Raja R Harinath <rharinath@novell.com>
9670 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
9671 not 'unreachable_seen'.
9673 2005-04-04 Marek Safar <marek.safar@seznam.cz>
9675 * attribute.cs (Attribute.GetValue): Removed unused.
9677 * codegen.cs (CodeGen.TrimExt): Removed unused.
9679 * cs-parser.jay (output): Removed unused.
9681 * cs-tokenizer.cs (hex_digits): Removed unused.
9683 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
9685 * expression.cs (Indirection.LoadExprValue): Removed unused.
9686 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
9688 * iterators.cs (Iterator.param_types): Removed unused.
9690 * statement.cs (Goto.block): Removed unused.
9691 (ToplevelBlock.did): Removed unused.
9692 (Switch.ResolveConstantSwitch): Removed unused.
9694 2005-04-01 Ben Maurer <bmaurer@ximian.com>
9696 * rootcontext.cs: Allow mcs to bootstrap with the compilation
9699 2005-04-01 Raja R Harinath <rharinath@novell.com>
9701 Fix #74232 and cs0208-3.cs.
9702 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
9703 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
9704 unmanaged type. Don't use FieldBuilders when 't' is a
9705 TypeBuilder. Use ModFlags and MemberType fields.
9706 * class.cs (MemberBase.member_type): Rename from MemberType.
9707 (MemberBase.MemberType): New property. Determines member_type on
9709 (MemberBase.DoDefine): Don't initialize MemberType here.
9710 (FieldMember.Define): Likewise.
9712 2005-04-01 Marek Safar <marek.safar@seznam.cz>
9715 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
9716 Attributes are emitted there.
9718 2005-04-01 Raja R Harinath <rharinath@novell.com>
9720 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
9721 keyword in 'partial enum' too.
9722 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
9724 Report from Kamil Skalski <nazgul@omega.pl>.
9727 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
9728 have partial containers too.
9730 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
9731 in block' checks to Block.CheckInvariantMeaningInBlock.
9732 * statement.cs (Block.GetKnownVariableInfo): Make private.
9733 (Block.IsVariableUsedInChildBlock): Remove.
9734 (Block.IsVariableUsedInBlock): Likewise.
9735 (Block.CheckInvariantMeaningInBlock): New. Show location of
9736 conflicting declaration.
9737 (Block.AddVariable): Make error messages less long-winded and more
9738 specific. Show location of conflicting declaration.
9739 * parameter.cs (Parameters.Location): New readonly property.
9741 2005-03-31 Raja R Harinath <rharinath@novell.com>
9743 Clean up semantics of invoking ResolveMemberAccess.
9744 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
9745 can have an instance, ensure that we pass in a non-TypeExpression
9746 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
9747 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
9748 argument. Update to changes and simplify.
9749 (FieldExpr.Emitinstance): Remove CS0120 check.
9750 (PropertyExpr.EmitInstance): Likewise.
9751 * expression.cs (Argument.Resolve): Likewise.
9752 (Invocation.DoResolve): Update to changes in semantics of
9755 2005-03-31 Marek Safar <marek.safar@seznam.cz>
9758 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
9761 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
9763 2005-03-31 Raja R Harinath <rharinath@novell.com>
9765 Fix difference in behaviour with commandline invocation.
9766 * driver.cs (Driver.Reset): New.
9767 (CompilerCallableEntryPoint): Call it.
9769 * statement.cs (If.Resolve): Avoid spurious "uninitialized
9770 variable" warnings if the boolean expression failed to resolve.
9772 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
9774 * attribute.cs: Fix the union of several permissions when some of them
9775 are unrestricted (so the result isn't an unrestricted permission set).
9778 2005-03-30 Raja R Harinath <rharinath@novell.com>
9780 * ecore.cs (MemberExpr): New class. Convert from interface
9782 (MemberExpr.ResolveMemberAccess): Refactor and move here from
9783 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
9785 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
9786 (MethodGroupExpr.IsExplicitImpl): Remove.
9787 (Expression.GetFieldFromEvent): Remove.
9788 (SimpleName.MemberStaticCheck): Remove.
9789 (SimpleName.DoSimpleNameResolve): Update to changes.
9790 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
9791 (MemberAccess.IdenticalNameAndTypeName): Remove.
9792 (MemberAccess.error176): Move to MemberExpr.
9793 (MemberAccess.DoResolve): Update to changes.
9794 (BaseAccess.DoResolve): Likewise.
9796 2005-03-30 Marek Safar <marek.safar@seznam.cz>
9798 C# 2.0 Conditional attribute class implementation
9800 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
9801 Analyzes class whether it has attribute which has ConditionalAttribute
9802 and its condition is not defined.
9804 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
9805 (Class.IsExcluded): New method. Search for at least one defined
9806 condition in ConditionalAttribute of attribute class.
9808 2005-03-30 Raja R Harinath <rharinath@novell.com>
9810 * ecore.cs (PropertyExpr): Derive from Expression, not
9811 ExpressionStatement.
9812 (PropertyExpr.EmitStatement): Remove.
9814 2005-03-29 Raja R Harinath <rharinath@novell.com>
9817 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
9818 internal field "value__" of an enum be private. The examples for
9819 "value__" that I found on MSDN all used FieldAttributes.Private.
9821 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
9822 Don't mention IL method attribute names.
9824 Fix #47991. Remove a TODO.
9825 * statement.cs (Block.Toplevel): Make into a field.
9826 (Block.Parameters): Move into ToplevelBlock.
9827 (Block.known_variables): Rename from child_variable_names.
9828 (Block.Block): Remove variants that take Parameters. Initialize
9829 'Toplevel' with the immediately surrounding toplevel block.
9830 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
9831 LocalInfo parameter.
9832 (Block.GetKnownVariableInfo): New.
9833 (Block.IsVariableNameUsedInChildBlock): Update.
9834 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
9835 the block, even though it may not be in scope.
9836 (Block.AddVariable): Remove Parameters parameter. Use
9837 Toplevel.Parameters instead.
9838 (Block.AddConstant): Remove Parameters parameter.
9839 (Block.GetParameterReference): Update to use Toplevel.Parameters.
9840 (Block.IsParamaterReference): Likewise.
9841 (Block.IsLocalParameter): Likewise. Simplify a lot.
9842 (ToplevelBlock.Parameters): New. Moved from Block.
9843 (ToplevelBlock.ToplevelBlock): Update to changes. Always
9844 initialize Parameters to a non-null value.
9845 * cs-parser.jay: Update to changes.
9846 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
9847 simple names that mean different things in the same block. Use
9848 Block.IsVariableNameUsedInBlock.
9850 2005-03-28 Raja R Harinath <rharinath@novell.com>
9852 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
9853 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
9854 GetTypeHandle. It is possible for a reflected type to derive from
9855 a TypeBuilder (e.g., int[] derives from the TypeBuilder
9856 System.Array during mscorlib compilation).
9857 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
9858 contain a method_hash, don't create one either. Don't create a
9859 deep copy of the base cache's method_hash.
9860 (MemberCache.SetupCache): Rename back from DeepCopy.
9861 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
9862 already initialized. If we see an override function, add its
9863 underlying base virtual function to the member_hash too.
9865 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
9867 2005-03-26 Raja R Harinath <harinath@acm.org>
9870 * assign.cs (Assign.DoResolve): When the RHS of an assignment
9871 fails to resolve, ensure that the LHS is still resolved as an
9874 2005-03-25 Raja R Harinath <harinath@acm.org>
9876 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
9878 (Enum.current_ec): Remove.
9879 (Enum.LookupEnumValue): Remove EmitContext argument.
9880 Just uses the one created during DefineType.
9881 (Enum.FindMembers): Update.
9882 * expression.cs (MemberAccess.DoResolve): Update.
9884 2005-03-22 Marek Safar <marek.safar@seznam.cz>
9886 * assign.cs (Assign.DoResolve): Check for CS1717 when
9887 source and target are same (uses Equals).
9889 * expression.cs (LocalVariableReference, ParameterReference,
9890 This): Implemented Equals, GetHashCode.
9892 * statement.cs (Block.GetParameterReference): Removed useless
9895 2005-03-22 Raja R Harinath <rharinath@novell.com>
9898 * statement.cs (Block.AddVariable): Ensure that we skip implicit
9899 blocks before deciding whether the error is cs0136 or cs0128.
9901 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
9902 (using_alias_directive, using_namespace_directive): Pass
9903 MemberName, not an expression to Namespace.UsingAlias and
9905 (MakeName): Use the MemberName of the namespace.
9906 * namespace.cs (Namespace.MemberName): New.
9907 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
9908 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
9910 * decl.cs (MemberName.Name): Make readonly.
9911 (MemberName.FromDotted): New "constructor".
9912 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
9913 (MemberCore.Name): Compute from MemberName on demand.
9914 (MemberCore.SetMemberName): Provide a way to change the
9916 (MemberCore.AddToContainer): Don't take a fullname parameter.
9917 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
9918 fully qualified name of the container to the member name.
9919 (TypeContainer.AddToTypeContainer): Use a fully qualified name
9920 only if the type is a member of the root container.
9921 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
9922 MemberName.Left rather than searching for an embedded ".".
9923 (PartialContainer.CreatePart): Update to changes in RootContext.
9924 (MemberBase.ShortName): Turn into a property. Use
9925 MemberCore.SetMemberName.
9926 (MemberBase.ExplicitInterfaceName): Remove.
9927 (MemberBase.UpdateMemberName): Remove.
9928 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
9929 (PropertyBase.SetMemberName): New override.
9930 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
9931 (Tree.GetDecl): New.
9932 (Tree.AllDecls): Rename from Decls.
9933 * attribute.cs, enum.cs, report.cs: Update to changes.
9934 * driver.cs (MainDriver): Use MemberName.FromDotted on
9935 RootContext.MainClass.
9937 2005-03-21 Marek Safar <marek.safar@seznam.cz>
9939 * class.cs (FixedField.Define): Check for CS1664 and more sanity
9942 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
9944 2005-03-18 Marek Safar <marek.safar@seznam.cz>
9946 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
9947 property accessor modifiers.
9949 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
9950 fixed buffer attribute (CS1716).
9951 (PropertyMethod.HasCustomAccessModifier): When property accessor
9952 has custom modifier.
9954 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
9956 (PropertyExpr.DoResolveLValue): Add CS0272.
9958 2005-03-17 Miguel de Icaza <miguel@novell.com>
9960 * convert.cs: When converting to a pointer, use the proper Conv.U
9961 or Conv.I depending on the source data type.
9963 * cs-tokenizer.cs: Make the size for large decimal constants,
9966 2005-03-17 Martin Baulig <martin@ximian.com>
9968 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
9969 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
9971 2005-03-17 Martin Baulig <martin@ximian.com>
9973 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
9974 to bool so we can return an error condition.
9975 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
9978 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
9980 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
9983 2005-03-16 Raja R Harinath <rharinath@novell.com>
9985 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
9986 Refactor to avoid traversing the list of assemblies, and to avoid
9987 string concatenation.
9988 * typemanager.cs (guid_attr_type): Remove.
9989 (negative_hits, pointers, references): Remove hashes.
9991 (GetConstructedType): New. Uses type_hash to handle constructed
9992 types (arrays, references, pointers).
9993 (GetReferenceType, GetPointerType): Use it.
9994 (GetNestedType): New. Uses type_hash to handle nested types of
9996 (LookupType, LookupTypeDirect): Remove.
9997 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
9998 'types' hash and LookupTypeReflection directly.
9999 (params_string, params_object): Use GetConstructedType.
10000 * namespace.cs (Namespace.cached_types): New. Cache of reflected
10002 (Namespace.Lookup): Use cached_types.
10003 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
10004 provided by old TypeManager.LookupType.
10005 * rootcontext.cs (MakeFQN): Remove.
10006 * decl.cs (DeclSpace.MakeFQN): Likewise.
10007 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
10008 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
10009 TypeManager.GetConstructedType.
10010 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
10012 2005-03-15 Marek Safar <marek.safar@seznam.cz>
10014 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
10017 * cs-parser.jay: Reports CS1527 for any namespace element.
10019 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
10022 * expression.cs (ParameterReference.IsAssigned): Changed error to
10024 (Error_WrongNumArguments): Moved CS0245 detection here.
10026 * statement.cs (Return.Resolve): Add CS1622 report.
10028 2005-03-11 Marek Safar <marek.safar@seznam.cz>
10030 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
10032 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
10034 * attribute.cs expression.cs: Get rid of some allocations.
10036 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
10038 * doc.cs : just eliminate the latest change.
10040 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10042 * doc.cs : commented out the latest change. It breaks xml-030.cs
10044 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10046 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
10047 fail. So invoke CreateType() in FindDocumentedType().
10049 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10051 * cs-tokenizer.cs : added IsKeyword().
10052 * doc.cs : Detect keyword incorrectly used as identifier.
10053 Allow identifiers prefixed by @.
10055 2005-03-10 Marek Safar <marek.safar@seznam.cz>
10057 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
10058 It caused exception in namespace resolving (again!).
10060 * class.cs (Class.ctor): Removed exit.
10061 (PropertyMethod.ctor): ditto.
10063 * codegen.cs (Codegen.Reset): Reset static data.
10064 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
10066 * cs-tokenizer.cs (Cleanup): Removed.
10068 * driver.cs (GetSystemDir): Rewrote to one line command.
10069 It caused problem with unloaded dynamic modules.
10070 (UnixParseOption): Removed Exit.
10071 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
10072 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
10073 Now can be mcs used as library.
10075 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
10078 * location.cs (Reset): Reset static data.
10080 * namespace.cs (Reset): Reset static data.
10082 * report.cs (Report.Reset): Reset static data.
10084 * rootcontext.cs (RootContext.Reset): Reset static data.
10086 * tree.cs (RootTypes.ctor): Use Location.Null
10088 * typemanager.cs (TypeManager.Reset): Reset static data.
10089 (CoreLookupType): Removed Exit.
10090 (TypeHandle.Reset): Reset static data.
10092 2005-03-10 Raja R Harinath <rharinath@novell.com>
10095 * typemanager.cs (ComputeNamespaces): Import namespaces from
10096 referenced modules too.
10098 2005-03-09 Raja R Harinath <rharinath@novell.com>
10100 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
10103 2005-03-09 Raja R Harinath <rharinath@novell.com>
10105 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
10106 enclosing DeclSpace. This ensures that a name-lookup populates
10107 more caches and there are fewer 'TypeExpression's. Carve out
10108 nested type lookup into ...
10109 (LookupNestedTypeInHierarchy): ... this.
10111 2005-03-09 Raja R Harinath <rharinath@novell.com>
10113 Clean up a few partial-class semantics.
10114 Fixes test-357.cs and cs1618-2.cs.
10115 * cs-parser.jay (struct_declaration): Use 'current_class' as
10116 parent of newly-created struct. Remove call to Register ().
10117 Use 'pop_current_class' to complete handing the current struct.
10118 (interface_declaration): Likewise.
10119 (class_declaration): Likewise.
10120 (enum_declaration): Use 'current_class' as parent of newly created
10122 (delegate_declaration): Likewise.
10123 (pop_current_class): New function. This is used to handle closing
10124 up the 'current_class' and 'current_container', and pointing them
10125 to the enclosing class/container.
10126 (CSharpParser): Initialize 'current_class' too.
10127 * decl.cs (MemberCore): Add check for invariant: a partial
10128 container is not a parsed entity, and thus does not enclose any
10130 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
10131 (DeclSpace.BaseTypeExpr): Use it.
10132 (DeclSpace.LookupType): Add check for invariant.
10133 * class.cs (TypeContainer): Add check for invariant: a nested
10134 class should have the same NamespaceEntry as its enclosing class.
10135 (TypeContainer.EmitFieldInitializers): Make virtual.
10136 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
10138 (TypeContainer.Register): Remove.
10139 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
10140 null. Use TypeResolveEmitContext for resolving base types and
10141 interfaces. Move initialization of Parts.TypeBuilder here from
10143 (TypeContainer.DefineNestedTypes): ... here.
10144 (PartialContainer): Take a Namespace not a NamespaceEntry.
10145 (PartialContainer.Create): Don't use Register. Call the
10146 appropriate Add... function directly.
10147 (ClassPart): Take both the PartialContainer and the enclosing
10148 class as constructor arguments.
10149 (ClassPart.EmitFieldInitializers): Override.
10150 (ClassPart.PartFindNestedTypes): Remove.
10151 (FieldBase.GetInitializerExpression): Resolve the initializer
10152 expression in the emit context of the enclosing class.
10153 * tree.cs (RootTypes): Remove Register ().
10155 2005-03-08 Marek Safar <marek.safar@seznam.cz>
10157 * cs-parser.jay: Removed CS0134.
10159 * driver.cs: Removed CS1901.
10161 * expression.cs (SizeOf.DoResolve): Don't report CS0233
10162 for predefined types.
10164 2005-03-07 Duncan Mak <duncan@novell.com>
10166 * codegen.cs (Save): Catch UnauthorizedAccessException as
10167 well. Fixes bug #73454.
10169 2005-03-07 Marek Safar <marek.safar@seznam.cz>
10171 * cs-tokenizer.cs (xtoken): Add CS1035.
10173 * class.cs (MethodData.Define): Add CS0683.
10174 (FieldMember.ctor): Add CS0681.
10176 2005-03-07 Raja R Harinath <rharinath@novell.com>
10178 * ecore.cs (SimpleName.DoResolve): Rename from
10179 SimpleName.DoResolveAllowStatic.
10180 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
10181 Pass 'intermediate' flag to MemberStaticCheck.
10182 (SimpleName.MemberStaticCheck): Skip "static check" only in case
10183 of "intermediate" lookups via MemberAccess.
10184 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
10185 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
10187 2005-03-07 Raja R Harinath <rharinath@novell.com>
10190 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
10191 slipped in because of variable names that are identical to a
10192 builtin type's BCL equivalent ('string String;', 'int Int32;').
10193 (PropertyExpr.EmitInstance): Likewise.
10195 2005-03-04 Marek Safar <marek.safar@seznam.cz>
10197 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
10199 * report.cs (warning_ignore_table): Made public.
10201 2005-03-04 Raja R Harinath <rharinath@novell.com>
10204 * class.cs (MethodData.Emit): Pass 'container' to
10205 container.GetObsoleteAttribute instead of 'container.Parent'.
10207 2005-03-03 Marek Safar <marek.safar@seznam.cz>
10209 * cs-parser.jay: Add 1534 error test.
10211 * iterators.cs (Yield.CheckContext): Add error 1629.
10212 (Iterator.ctor): Save unsafe modifier.
10213 (MoveNextMethod.DoEmit): Restore unsafe context.
10215 * namespace.cs (UsingAlias): Better error message.
10217 2005-03-03 Dan Winship <danw@novell.com>
10219 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
10220 the warning message [#73219]
10222 2005-03-03 Raja R Harinath <rharinath@novell.com>
10224 Fix compile with MCS 1.0.0.0.
10225 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
10226 w_restore to not depend on string constant folding.
10228 2005-03-03 Raja R Harinath <rharinath@novell.com>
10230 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
10231 CS0246 check to users who passed 'silent = false'.
10232 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
10234 (SimpleName.SimpleNameResolve): Update.
10235 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
10236 (MemberAccess.IdenticalNameAndTypeName): Update.
10237 * doc.cs (FindDocumentedTypeNonArray): Update.
10239 2005-03-03 Raja R Harinath <rharinath@novell.com>
10241 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
10242 * parameters.cs (ComputeAndDefineParameters): Remove.
10243 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
10244 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
10245 Use GetParameterInfo.
10247 2005-03-02 Marek Safar <marek.safar@seznam.cz>
10249 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
10251 2005-03-02 Raja R Harinath <rharinath@novell.com>
10253 Unify DeclSpace.LookupType and DeclSpace.FindType.
10254 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
10255 is in charge of defining nested types on demand.
10256 (DeclSpace.LookupType): Use it when the current_type is a
10257 TypeBuilder. Use LookupTypeDirect for reflected types.
10258 (DeclSpace.FindType): Remove.
10259 (DeclSpace.LookupInterfaceOrClass): Likewise.
10260 (DeclSpace.DefineTypeAndParents): Likewise.
10261 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
10262 DeclSpace.LookupType.
10263 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
10264 * typemanager.cs (LookupType): Simplify.
10265 (AddUserType): Remove type from negative_hits.
10266 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
10267 * class.cs (TypeContainer.FindMembers): Move handling of nested
10269 (TypeContainer.FindMembers_NestedTypes): ... here.
10270 (TypeContainer.FindNestedType): Implement override.
10271 (ClassPart.FindNestedType): Delegate to PartialContainer.
10272 (ClassPart.PartFindNestedType): Looks up the nested types of the
10275 2005-03-02 Martin Baulig <martin@ximian.com>
10277 * class.cs (TypeContainer.DoDefineMembers): We also need a default
10278 static constructor in static classes.
10280 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
10282 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
10283 sizeParamIndex is not specified.
10285 2005-03-01 Marek Safar <marek.safar@seznam.cz>
10288 * report.cs (WarningMessage.IsEnabled): Missing null check.
10290 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10292 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
10293 in the fields and not in the properties.
10295 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
10297 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
10300 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10302 * attribute.cs: Small refactoring (improved robustness).
10303 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
10304 (ValidateGuid): Removed.
10305 (Resolve): Removed referenced to above mentioned.
10306 (GetAttributeUsage): Made private and changed to work without
10308 (GetIndexerAttributeValue): Don't crash.
10309 (GetConditionalAttributeValue): Ditto.
10310 (GetClsCompliantAttributeValue): Ditto.
10311 (ExtractSecurityPermissionSet): All attributes exceptions are
10313 (GetPropertyValue): New helper.
10314 (GetMethodImplOptions): New method.
10315 (DefinePInvokeMethod): Reuse common code. Implemented handling of
10316 some missing properties.
10318 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
10319 (Method.ApplyAttributeBuilder): Updated.
10321 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
10324 2005-02-28 Raja R Harinath <rharinath@novell.com>
10327 * report.cs (Report.SymbolRelatedToPreviousError): Handle
10328 non-simple types (array, pointer, reference).
10330 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10332 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
10334 * class.cs (MethodCore.IsDuplicateImplementation): Special error
10336 (Method.CheckBase): Catch wrong destructor here.
10337 (MethodData.Define): Add errors 550, 668.
10339 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
10341 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
10343 * pending.cs (VerifyPendingMethods): Add error 551.
10345 * typemanager.cs (CSharpName): Next error report helper.
10347 2005-02-25 Marek Safar <marek.safar@seznam.cz>
10349 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
10350 attributes. Removed useless attribute double check.
10351 It saves almost 2MBs for corlib.
10353 2005-02-25 Raja R Harinath <rharinath@novell.com>
10356 * statement.cs (ExpressionStatement.Resolve): Make robust to being
10357 called twice in case of error.
10359 2005-02-23 Chris Toshok <toshok@ximian.com>
10361 Fix compiler portions of #72827.
10362 * statement.cs (Block.Emit): call Begin/EndScope on the
10363 EmitContext instead of the ILGenerator.
10365 * codegen.cs (EmitContext.BeginScope): new method, call
10366 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
10368 (EmitContext.BeginScope): same, but EndScope and CloseScope
10370 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
10371 offset and call the superclass's OpenScope(int) with it.
10372 (SymbolWriter.CloseScope): get the current il
10373 offset and call superclass's CloseScope(int) with it.
10375 2005-02-23 Marek Safar <marek.safar@seznam.cz>
10377 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
10378 CS1677 for out and ref as well.
10380 * class.cs (Method.Define): Add error CS1599 detection.
10382 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
10384 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
10386 * delegate.cs (Delegate.Define): Add error CS1599 detection.
10388 * support.cs.cs (ModifierDesc): New helper method.
10390 2005-02-23 Raja R Harinath <rharinath@novell.com>
10391 Abin Thomas <projectmonokochi@rediffmail.com>
10392 Anoob V E <projectmonokochi@rediffmail.com>
10393 Harilal P R <projectmonokochi@rediffmail.com>
10395 Fix #57851, #72718.
10396 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
10397 MemberLookup (used for error reporting) actually returns a result.
10398 Fix error report number (122, not 112).
10400 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
10401 Anoob V E <projectmonokochi@rediffmail.com>
10402 Harilal P R <projectmonokochi@rediffmail.com>
10405 * pending.cs (PendingImplementation.GetAbstractMethods):
10406 Find NonPublic members too.
10408 2005-02-22 Marek Safar <marek.safar@seznam.cz>
10410 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
10413 * class.cs (MethodCore.CheckMethodAgainstBase):
10414 Add error 239 report.
10416 2005-02-21 Raja R Harinath <rharinath@novell.com>
10419 * expression.cs (Invocation.IsApplicable): Make public.
10420 (Invocation.IsParamsMethodApplicable): Likewise.
10421 * delegate.cs (Delegate.VerifyApplicability): Don't use
10422 Invocation.VerifyArgumentCompat for parameter applicability
10423 testing. Use Invocation.IsApplicable and
10424 Invocation.IsParamsMethodApplicable.
10426 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10428 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
10430 * class.cs (Operator.Define): Add error 217 report.
10432 2005-02-21 Raja R Harinath <rharinath@novell.com>
10434 * namespace.cs (UsingEntry.Resolve): Undo change below.
10436 2005-02-21 Raja R Harinath <rharinath@novell.com>
10439 * ecore.cs (Expression.MemberLookupFailed): Add argument to
10440 disable the error message when the extended MemberLookup also
10442 (Expression.MemberLookupFinal): Update.
10443 (SimpleName.DoSimpleNameResolve): Update.
10444 * expression.cs (MemberAccess.ResolveNamespaceOrType):
10445 Don't use MemberLookupFinal.
10446 (New.DoResolve): Update.
10447 (BaseAccess.CommonResolve): Update.
10449 2005-02-21 Raja R Harinath <rharinath@novell.com>
10452 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
10453 occured previously, don't resolve again.
10455 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10458 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
10459 argument. Call ResolveAttributeUsage for unresolved.
10460 when types doesn't match ctor arguments.
10462 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
10463 for nested attribute classes.
10464 (Class.attribute_usage): Removed.
10465 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
10466 for attribute class.
10468 * ecore.cs (IsAttribute): Removed.
10470 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
10472 * rootcontext.cs (RegisterAttribute): Removed, attributes are
10474 (attribute_types): Removed.
10475 (EmitCode): Global attributes are emited as the latest.
10477 2005-02-18 Marek Safar <marek.safar@seznam.cz>
10479 * class.cs (EmitFieldInitializers): Don't emit field initializer
10480 for default values when optimilization is on.
10482 * constant.cs (Constant.IsDefaultValue): New property.
10484 * driver.cs: Add /optimize handling.
10488 * literal.cs: Implement new IsDefaultValue property.
10490 * rootcontext.cs (Optimize): New field, holds /optimize option.
10492 2005-02-18 Raja R Harinath <rharinath@novell.com>
10494 Fix crasher in re-opened #72347.
10495 * namespace.cs (Namespace.Lookup): Return null if
10496 DeclSpace.DefineType returns null.
10499 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
10501 2005-02-18 Raja R Harinath <rharinath@novell.com>
10503 Fix remainder of #63202. Change semantics of DoResolveLValue: it
10504 now returns null if it cannot resolve to an lvalue.
10505 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
10506 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
10507 returned null. Remove check for SimpleName.
10508 (EventExpr.DoResolveLValue): New.
10509 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
10510 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
10512 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
10513 avoid CS0131 error.
10514 (Unary.ResolveOperator): Move CS0211 check ...
10515 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
10517 (Unary.DoResolveLValue): Simplify.
10518 (AddressOf.DoResolveLValue): New.
10519 (ArrayAccess.DoResolveLValue): New.
10521 2005-02-16 Marek Safar <marek.safar@seznam.cz>
10523 * attribute.cs (Attribute.Resolve): Add arguments casting for
10524 when types doesn't match ctor arguments.
10526 2005-02-16 Raja R Harinath <rharinath@novell.com>
10528 Fix parts of #63202.
10529 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
10530 lookup of operator in base type. Ensure that all checks happen
10531 when the operator resolves to an "op_..." method.
10533 2005-02-15 Raja R Harinath <rharinath@novell.com>
10536 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
10537 'ignore_cs0104' parameter. Pass it to ...
10538 (NamespaceEntry.Lookup): ... this.
10539 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
10540 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
10541 (TypeLookupExpression.DoResolveAsTypeStep): Update.
10542 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
10543 Update. Request that cs0104 errors be ignored.
10544 (ComposedCast.ResolveAsTypeStep): Update.
10546 2005-02-14 Raja R Harinath <rharinath@novell.com>
10549 * expression.cs (Invocation.BetterFunction): Remove support for
10550 comparing virtual functions and their overrides.
10551 (Invocation.IsOverride): New.
10552 (Invocation.OverloadResolve): Don't consider 'override' functions
10553 during candidate selection. Store them in a lookaside list.
10554 If the selected method is a 'virtual' function, use the list to
10555 find any overrides that are closer to the LHS type.
10557 2005-02-14 Marek Safar <marek.safar@seznam.cz>
10559 * expression.cs (New.DoResolve): Add complex core type reduction.
10560 (New.Constantify): Converts complex core type syntax like 'new int ()'
10561 to simple constant.
10563 2005-02-14 Raja R Harinath <rharinath@novell.com>
10565 * decl.cs (EntryType.EntryType): New constructor to create an
10566 updated copy of a cache entry.
10567 (MemberCache.AddMethods): Use it.
10568 (MemberCache.ClearDeclaredOnly): Remove.
10569 (MemberCache.MemberCache): Update.
10571 2005-02-11 Miguel de Icaza <miguel@novell.com>
10573 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
10574 variable. This one is represents the actual low-level declaration
10575 of the method, as opposed to the semantic level `IsStatic'.
10577 An anonymous method which is hosted into a static method might be
10578 actually an instance method. IsStatic would reflect the
10579 container, while MethodIsStatic represents the actual code
10582 * expression.cs (ParameterReference): Use the new MethodIsStatic
10583 instead of IsStatic.
10585 * anonymous.cs (AnonymousMethod.Compatible): Pass the
10586 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
10587 set on the current EmitContext.
10589 * expression.cs (Cast): Overload DoResolveLValue so we can pass
10590 resolve our casted expression as an LValue. This triggers the
10591 proper LValue processing that is later required by Assign.
10595 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
10597 2005-02-11 Marek Safar <marek.safar@seznam.cz>
10599 C# 2.0 Fixed buffer implementation
10601 * anonymous.cs: Update after RegisterHelperClass renaming.
10603 * attribute.cs (AttributeTester.fixed_buffer_cache):
10604 Cache of external fixed buffers.
10605 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
10606 implementation if field is fixed buffer else null.
10609 (TypeContainer.AddField): Accept FieldMember instead of Field.
10610 (FieldBase.IsFieldClsCompliant): Extracted code from
10611 VerifyClsCompliance descendant customization.
10612 (FixedField): New class handles fixed buffer fields.
10613 (FixedFieldExternal): Keeps information about imported fixed
10615 (IFixedField): Make access to internal or external fixed buffer
10618 * cs-parser.jay: Add fixed buffer parsing.
10620 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
10623 * expression.cs (Indirection): Extended implementation to accept
10624 fixed buffer field.
10625 (PointerArithmetic.Emit): Get element from fixed buffer as well.
10626 (ElementAccess.MakePointerAccess): Get type as parameter.
10627 (DoResolve): Add fixed buffer field expression conversion.
10628 (DoResolveLValue): Ditto.
10629 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
10630 (ArrayPtr): Derives from FixedBufferPtr.
10631 (ArrayPtr.Emit): Add extra emit for array elements.
10633 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
10635 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
10636 for compiler generated types.
10637 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
10639 * statement.cs (Fixed): Refactored to be easier add fixed buffer
10640 and consume less memory.
10641 (Fixed.Resolve): Add fixed buffer case.
10643 * typemanager.cs (compiler_generated_attr_ctor,
10644 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
10645 (HasElementType): Add our own implementation to work on every
10648 2005-02-11 Miguel de Icaza <miguel@novell.com>
10650 * anonymous.cs (CaptureContext): Track whether `this' has been
10653 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
10654 only captured `this' if it was implicitly done (instance
10655 methods/variables were used).
10657 * codegen.cs (EmitContext.CaptureThis): New method to flag that
10658 `this' must be captured.
10660 2005-01-30 Miguel de Icaza <miguel@novell.com>
10662 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
10663 is null it means that there has been no need to capture anything,
10664 so we just create a sibling.
10666 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
10668 Just a partial fix. The other half is fairly elusive.
10670 2005-02-10 Raja R Harinath <rharinath@novell.com>
10672 Fix #52586, cs0121-4.cs.
10673 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
10674 and return a hashtable.
10675 (MemberCache.ClearDeclaredOnly): New.
10676 (MemberCache.MemberCache): Update to change. Make a deep copy of
10677 the method_hash of a base type too.
10678 (MemberCache.AddMethods): Adapt to having a deep copy of the base
10679 type methods. Overwrite entries with the same MethodHandle so
10680 that the ReflectedType is correct. The process leaves in base
10681 virtual functions and their overrides as distinct entries.
10682 (CacheEntry): Now a class instead of a struct. It shouldn't alter
10683 matters since it was boxed in a ArrayList before.
10684 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
10686 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
10687 case of a virtual function and its override (choose the overload
10689 (Invocation.OverloadResolve): Avoid 'override' members during
10690 'applicable_type' calculation.
10692 2005-02-09 Raja R Harinath <rharinath@novell.com>
10694 Combine two near-redundant caches.
10695 * typemanager.cs (method_params): Rename from method_internal_params.
10696 (TypeManager.GetParameterData): New. Replace
10697 Invocation.GetParameterData.
10698 (TypeManager.LookupParametersByBuilder): Remove.
10699 * expression.cs (Invocation.method_parameter_cache): Remove.
10700 (Invocation.GetParameterData): Remove.
10702 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
10705 2005-02-08 Raja R Harinath <rharinath@novell.com>
10708 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
10709 TypeManager.multicast_delegate_type is null, resolve it by looking
10710 up "System.MulticastDelegate".
10711 * rootcontext.cs (RootContext.ResolveCore): Simplify.
10713 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
10714 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
10715 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
10718 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
10719 (LabeledStatement.AddReference): New. Set 'referenced'.
10720 (Goto.Resolve): Use it.
10722 2005-02-05 John Luke <john.luke@gmail.com>
10724 * driver.cs: remove duplicate -doc line in Usage ()
10726 2005-02-04 Raja R Harinath <rharinath@novell.com>
10728 * location.cs (Location.AddFile): Fix CS2002 error report.
10730 2005-02-02 Martin Baulig <martin@ximian.com>
10732 * delegate.cs (Delegate.DefineType): Report an internal error if
10733 TypeManager.multicast_delegate_type is null. See bug #72015 for
10736 2005-02-02 Raja R Harinath <rharinath@novell.com>
10738 Fix a crasher in a variant of #31984.
10739 * const.cs (Constant.CheckBase): New override that defers the
10740 new-or-override check in case the base type hasn't been populated
10742 (Constant.Define): Ensure the new-or-override check is performed.
10744 2005-02-01 Duncan Mak <duncan@ximian.com>
10746 * const.cs (LookupConstantValue): Check that `ce' is not null
10747 before calling GetValue ().
10749 2005-02-01 Raja R Harinath <rharinath@novell.com>
10751 Fix test-334.cs (#69519).
10752 * cs-parser.jay (using_alias_directive): Pass in an expression to
10753 NamespaceEntry.UsingAlias.
10754 (using_namespace_directive): Pass in an expression to
10755 NamespaceEntry.Using.
10756 (namespace_name): Don't flatten to a string.
10757 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
10758 (NamespaceEntry.AliasEntry.Resolve): Lookup using
10760 (NamespaceEntry.UsingEntry): Likewise.
10761 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
10763 (NamespaceEntry.LookupForUsing): Remove.
10764 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
10766 (NamespaceEntry.Lookup): Remove support for dotted names.
10768 2005-02-01 Raja R Harinath <rharinath@novell.com>
10770 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
10772 (NamespaceEntry.ImplicitParent): Compute on demand.
10773 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
10774 parallels the current.
10775 (NamespaceEntry.LookupForUsing): Use it.
10776 (NamespaceEntry.Lookup): If the current namespace-entry is
10777 implicit, don't search aliases and using tables.
10779 2005-02-01 Raja R Harinath <rharinath@novell.com>
10782 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
10784 (TypeContainer.BaseCache): Compute on demand.
10785 (TypeContainer.FindMembers): Define constants and types if they're
10786 not already created.
10787 (FieldMember.Define): Move resetting of ec.InUnsafe before error
10789 * const.cs (Constant.Define): Make idempotent.
10791 2005-01-29 Miguel de Icaza <miguel@novell.com>
10793 * pending.cs: Produce better code (no nops produced by using Ldarg
10796 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
10797 i - 1' it should be arg + 1.
10801 2005-01-28 Raja R Harinath <rharinath@novell.com>
10803 * attribute.cs (Attribute.CheckAttributeType): Make private
10805 (Attribute.ResolveType): Make virtual.
10806 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
10807 handling of RootContext.Tree.Types.
10809 2005-01-27 Raja R Harinath <rharinath@novell.com>
10811 Update attribute-handling to use the SimpleName/MemberAccess
10813 * cs-parser.jay (attribute): Pass in an expression to the
10814 constructors of Attribute and GlobalAttribute.
10815 * attribute.cs (Attribute): Take an expression for the name.
10816 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
10817 passed in attribute name expression.
10818 (Attribute.CheckAttributeType): Use it.
10819 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
10820 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
10821 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
10822 argument to prevent error messages if the lookup fails.
10824 2005-01-27 Marek Safar <marek.safar@seznam.cz>
10826 * expression.cs (Indirection): Implemented IVariable interface
10827 to support indirection in AddressOf operator.
10828 (PointerArithmetic.Emit): Add optimalization for case where
10829 result can be precomputed.
10831 2005-01-26 Martin Baulig <martin@ximian.com>
10833 * class.cs (TypeContainer.AttributeTargets): Return the correct
10834 AttributeTargets depending on our `Kind' instead of throwing an
10835 exception; fixes #71632.
10837 2005-01-26 Marek Safar <marek.safar@seznam.cz>
10840 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
10843 2005-01-25 Raja R Harinath <rharinath@novell.com>
10846 * expression.cs (MemberAccess.DoResolve): Don't complain with
10847 cs0572 when the LHS of a member access has identical name and type
10850 2005-01-25 Marek Safar <marek.safar@seznam.cz>
10853 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
10855 Create custom PermissionSet only for PermissionSetAttribute.
10857 2005-01-24 Marek Safar <marek.safar@seznam.cz>
10860 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
10861 delegates in static class.
10863 2005-01-24 Martin Baulig <martin@ximian.com>
10865 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
10866 merging an implicit block, just use its reachability.
10868 * statement.cs (Block.Resolve): Make the unreachable code check
10869 work wrt. implicit blocks; see test-337 from #63842.
10871 2005-01-21 Alp Toker <alp@atoker.com>
10873 * cs-parser.jay: destructor_declaration's container is PartialContainer
10874 not Class when partial types are used, so use Kind prop instead of
10877 2005-01-22 Miguel de Icaza <miguel@ximian.com>
10879 * cs-parser.jay: Improve error reporting when an interface
10880 declares new types.
10882 2005-01-20 Dick Porter <dick@ximian.com>
10884 * support.cs: SeekableStreamReader fix from Sandor Dobos
10885 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
10886 chars are read. Fixes bug 70369.
10888 2005-01-20 Raja R Harinath <rharinath@novell.com>
10890 * cs-parser.jay (catch_clause): Simplify current_block handling
10893 2005-01-17 Miguel de Icaza <miguel@ximian.com>
10895 * convert.cs (ImplicitStandardConversionExists): Synchronize the
10896 code with ImplicitStandardConversion to handle the implicit
10897 conversion of method groups into valid delegate invocations.
10899 The problem is that in parameter handling we were using this code
10900 path. Fixes bug #64698
10902 2005-01-19 Raja R Harinath <rharinath@novell.com>
10904 * cs-parser.jay: Fix several infelicities.
10905 - Avoid assigning to the parser value stack. Code like
10906 '$3 = null' is unclean. Synthesize a value for the code block
10908 - Avoid using oob_stack for storing location information. Use ...
10909 (_mark_): ... this. New (empty) rule. Saves the current location
10911 (foreach_statement): Avoid using oob_stack for current_block
10912 handling. Use technique used in for_statement and
10913 using_statement. Synthesize a value for the code block to store
10914 additional intermediate information.
10916 2005-01-13 Miguel de Icaza <miguel@ximian.com>
10918 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
10919 of a different type is only allowed to private fields of a
10920 containing type, not on fields of a base class.
10922 See test-174.cs and error cs0122-9.cs
10924 2005-01-13 Raja R Harinath <rharinath@novell.com>
10926 Fix test-335.cs (bug #58126).
10927 * cs-parser.jay (argument): Split out non-expression parts of the
10928 rule into 'non_simple_argument'.
10929 (invocation_expression): Support parenthesized invocations with
10930 multiple arguments, and with single non-simple arguments.
10932 2005-01-13 Raja R Harinath <rharinath@novell.com>
10934 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
10937 2005-01-12 Raja R Harinath <rharinath@novell.com>
10939 Fix cs0038-1.cs, cs1640-6.cs.
10940 * ecore.cs (Expression.Resolve): Remove special-case for
10941 SimpleName in error-handling.
10942 (Expression.almostMatchedMembers): Relax access permission to
10944 (Expression.MemberLookupFailed): Handle duplicates in
10945 almostMatchedMembers list.
10946 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
10947 * expression.cs (New.DoResolve): Report CS1540 for more cases.
10948 * typemanager.cs (GetFullNameSignature): Use the MethodBase
10949 overload if the passed in MemberInfo is a MethodBase.
10951 2005-01-12 Marek Safar <marek.safar@seznam.cz>
10954 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
10955 for non-CAS & merge permission sets properly.
10957 2005-01-11 Raja R Harinath <rharinath@novell.com>
10959 Improve standard-compliance of simple name and member access
10960 resolution. Fixes bugs #52697, #57200, #67520, #69519.
10961 * ecore.cs (FullNamedExpression): New abstract base class
10962 for Namespaces and TypeExpressions.
10963 (ResolveFlags.SimpleName): Remove.
10964 (SimpleName): Remove support for dotted names.
10965 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
10966 DeclSpace.FindType and DeclSpace.LookupType.
10967 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
10968 (Expression.ExprClassName): Make member function.
10969 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
10970 a namespace. Remove creation of dotted "SimpleName"s.
10971 (MemberAccess.DoResolve): Likewise.
10972 * decl.cs (DeclSpace.Cache): Make private.
10973 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
10974 (DeclSpace.FindType): Update.
10975 (DeclSpace.LookupType): Move here from RootContext. Return a
10976 FullNamedExpression.
10977 * namespace.cs (Namespace): Derive from FullNamedExpression
10978 so that it can be part of expression resolution.
10979 (Namespace.Lookup): Return an FullNamedExpression.
10980 (NamespaceEntry.LookupAlias): Lookup aliases only in current
10982 * rootcontext.cs (NamespaceLookup): Remove.
10983 (LookupType): Move to DeclSpace.
10984 * attribute.cs (CheckAttributeType): Update.
10985 * doc.cs (FindDocumentedType): Remove allowAlias argument.
10986 (FindDocumentedTypeNonArray): Likewise.
10988 2005-01-11 Raja R Harinath <rharinath@novell.com>
10990 Fix cs0509.cs, cs1632.cs.
10991 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
10992 is the same as IsInterface.
10993 (TypeContainer.GetClassBases): Likewise.
10994 * statement.cs (LabeledStatement.ig): New field.
10995 (LabeledStatement.LabelTarget): Save ILGenerator which created the
10997 (LabeledStatement.DoEmit): Check that the label was created with
10998 the same ILGenerator.
11000 2005-01-10 Marek Safar <marek.safar@seznam.cz>
11003 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
11004 accessors to its properties.
11006 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
11007 from accessors to property.
11009 2005-01-10 Marek Safar <marek.safar@seznam.cz>
11012 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
11013 only for overrides.
11015 2005-01-08 Miguel de Icaza <miguel@ximian.com>
11017 * attribute.cs: Check for null and empty strings.
11019 I have lost another battle to Paolo.
11021 2005-01-07 Marek Safar <marek.safar@seznam.cz>
11024 * class.cs (PropertyMethod): Set Parent field in ctors.
11025 (SetMethod.InternalParameters): Add unsafe switch hack.
11026 Override MarkForDuplicationCheck where it is appropriate.
11028 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
11029 It says whether container allows members with the same name.
11030 Base default is no.
11031 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
11032 Removed is_method parameter.
11034 2005-01-06 Duncan Mak <duncan@ximian.com>
11036 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
11037 because the previous change led to incorrect reporting of CS1032
11038 ("Cannot define/undefine preprocessor symbols after first token in
11039 file"). Instead of using `tokens_seen' as the only flag that
11040 triggers CS1040, introduce `comments_seen'. This new flag is used
11041 to signify having seen comments on the current line, so it is
11042 unset after a newline.
11044 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
11046 * doc.cs : When searching for a type, find nested type too.
11047 This fixes bug #71040.
11049 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
11052 - Warn missing member comment on those classes which also does not
11053 have doc comments. Fixed bug #71041.
11054 - Don't warn missing doc comment on default constructor.
11057 2005-01-06 Duncan Mak <duncan@ximian.com>
11059 * cs-tokenizer.cs (xtoken): After handling traditional C-style
11060 comments, set `tokens_seen' to true. This allows us to detect
11061 misplaced preprocessor directives (i.e. not at the beginning of
11062 the a line, nor after whitespaces). In that case, report error
11063 CS1040. This fixes bug #56460.
11065 * cs-parser.jay (interface_member_declaration): Add checks for
11066 IsExplicitImpl, and report CS0541 error if an interface member is
11067 defined as an explicit interface declaration.
11069 2005-01-06 Marek Safar <marek.safar@seznam.cz>
11072 * class.cs (PropertyMethod): Set Parent field in ctors.
11073 (SetMethod.InternalParameters): Add unsafe switch hack.
11075 * decl.cs (MemberCore.Parent): Cannot be readonly.
11077 2005-01-06 Raja R Harinath <rharinath@novell.com>
11079 * decl.cs (DeclSpace.ResolveType): Remove.
11080 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
11081 Merge in code from ...
11082 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
11083 * class.cs, enum.cs: Update to changes.
11085 2005-01-06 Miguel de Icaza <miguel@ximian.com>
11087 * anonymous.cs: Ensure that we init the scope of our parent if it
11088 has not been initialized yet.
11090 2004-12-30 Duncan Mak <duncan@ximian.com>
11092 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
11093 if field.FieldBuilder is null. Fixes #70758.
11095 * convert.cs: Fixed some typos and updated some of the comments.
11096 (ImplicitStandardConversionExists):
11097 (TryImplicitIntConversion): If `target_type' is an interface and
11098 the type of `ic' implements this interface, return true or a new
11099 BoxedCast instead of null. This fixes #70468.
11101 2004-12-29 Duncan Mak <duncan@ximian.com>
11103 * expression.cs (Argument.Emit): Check that Expr is
11104 IMemoryLocation before casting to it, and report CS1510 otherwise.
11108 2004-12-21 Ben Maurer <bmaurer@ximian.com>
11110 * statement.cs (Block.ThisVariable): remove the recursion here, to
11111 make the --profile more sane.
11113 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
11115 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
11116 assembly, by JB Evain.
11118 2004-12-17 Raja R Harinath <rharinath@novell.com>
11120 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
11121 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
11122 "parent" refers to enclosing type/class. "base" refers to superclass.
11124 2004-12-17 Raja R Harinath <rharinath@novell.com>
11126 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11127 Ensure that we only have GlobalAttributes.
11128 * attribute.cs (Attribute.Emit): Make non-virtual.
11129 (GlobalAttribute.Emit): Remove.
11130 (Attribute.Resolve): Make virtual.
11131 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
11132 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
11133 the argument. Don't create one.
11134 (Attribute.GetObsoleteAttribute): Likewise.
11135 (Attribute.GetClsCompliantAttributeValue): Likewise.
11136 * class.cs, decl.cs: Update to changes.
11138 2004-12-17 Marek Safar <marek.safar@seznam.cz>
11140 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
11142 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
11144 * statement.cs (Foreach.Resolve): Add error 186 report.
11146 2004-12-16 Marek Safar <marek.safar@seznam.cz>
11148 * expression.cs (Conditional.DoResolve): Add warning 429.
11150 * statement.cs (If.Resolve): Add warning 665.
11152 2004-12-16 Raja R Harinath <rharinath@novell.com>
11154 New invariant: RootContext.Tree.Types.NamespaceEntry == null
11155 except when in the parser, and in GlobalAttribute.
11156 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
11157 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
11158 RootContext.Tree.Types.NamespaceEntry once work is done.
11159 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
11160 and resets RootContext.Tree.Types.NamespaceEntry.
11162 2004-12-15 Marek Safar <marek.safar@seznam.cz>
11164 * cs-parser.jay: Don't create a block for every variable.
11166 2004-12-14 Miguel de Icaza <miguel@ximian.com>
11168 * location.cs: Provide extra information.
11170 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
11171 variables from the captured environment, it is the ldarg_0.
11173 2004-12-14 Marek Safar <marek.safar@seznam.cz>
11175 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
11178 * class.cs: Changed warning level for 169 to avoid developer
11179 displeasure from warning flooding. It will be changed back when they
11180 fix most of current BCL warnings.
11182 * RootContext.cs: Pushed default WarningLevel to 3.
11184 * statement.cs: Removed unused variable.
11186 2004-12-14 Marek Safar <marek.safar@seznam.cz>
11188 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
11189 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
11190 Add error 502 report.
11191 (StaticClass.DefineType): Add error 441 report.
11192 (Class.AllowedModifiersProp): New virtual property as temporary
11193 extension to AllowedModifiers.
11194 (Class.DefineType): Add error 418 report. Moved ModFlags check here
11195 to share implementation with StaticClass and don't call virtual
11198 * driver.cs (MainDriver): Add error 1558 test.
11200 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
11201 report. Moved error 36 test here.
11203 * statement.cs (Throw.Resolve): Add error 724 report.
11205 * typemanager.cs: Add out_attribute_type core type.
11207 2004-12-13 Marek Safar <marek.safar@seznam.cz>
11209 * class.cs (TypeContainer.VerifyClsCompliance): Add error
11211 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
11213 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
11216 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
11218 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
11219 Add error 3023 report.
11220 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
11222 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
11225 2004-12-12 John Luke <john.luke@gmail.com>
11227 * driver.cs (AddArgs): take -- into account when
11228 adding arguments, fixes bug 65710
11230 2004-12-12 Martin Baulig <martin@ximian.com>
11232 * expression.cs (Unary.TryReduceNegative): Added support for
11233 SByteConstant and ByteConstant.
11234 (Unary.Reduce): Check error values from TryReduceNegative().
11236 2004-12-10 Marek Safar <marek.safar@seznam.cz>
11238 * attributes.cs (Attribute.Resolve): Avoid multiple error report
11239 and report exception as error 182.
11241 2004-12-10 Raja R Harinath <rharinath@novell.com>
11243 * driver.cs (Main): Fix message when there are warnings.
11245 2004-12-09 Miguel de Icaza <miguel@ximian.com>
11247 * delegate.cs: Fixed my fix from yesterday, sorry about that.
11249 2004-12-09 Marek Safar <marek.safar@seznam.cz>
11251 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
11252 Reduced number of warnings.
11254 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
11256 2004-12-08 Miguel de Icaza <miguel@ximian.com>
11258 * driver.cs: Removed message.
11260 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
11262 2004-12-08 <vargaz@freemail.hu>
11264 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
11266 2004-12-08 Martin Baulig <martin@ximian.com>
11268 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
11269 instead of a CS3002 for properties and indexer.
11271 2004-12-08 Martin Baulig <martin@ximian.com>
11273 * decl.cs (MemberName.ToString): Make this work again.
11275 2004-12-08 Marek Safar <marek.safar@seznam.cz>
11277 * attribute.cs (Resolve): Add error 591 detection.
11279 * class.cs (FieldMember.Define): Add error 1547 detection.
11280 (Indexer.Define): Add error 620 detection.
11281 (Operator.Define): Add error 590 detection.
11283 * ecore.cs: Missing argument for error 79.
11285 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
11288 2004-12-07 Marek Safar <marek.safar@seznam.cz>
11291 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
11294 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
11296 * cs-parser.jay : handle doc comments on implicit/explicit operators.
11297 Some operator comments were suppressed.
11298 * doc.cs : Implicit/explicit operator name in doc comments are like
11299 "op_Explicit(type)~returnType", so added suffix handling.
11301 2004-12-07 Martin Baulig <martin@ximian.com>
11304 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
11305 (MemberCore.GetClsCompliantAttributeValue): Likewise.
11306 (DeclSpace.ec): New protected field; store the EmitContext here.
11307 (DeclSpace.EmitContext): New public property; moved here from
11309 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
11312 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
11313 (Enum.Emit): Don't create a new EmitContext.
11315 * delegate.cs (Delegate.DefineType): Always create the
11318 * iterators.cs (Iterators.DefineIterator): Create a new
11319 EmitContext and store it in `ec'.
11321 2004-08-24 Martin Baulig <martin@ximian.com>
11324 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
11325 this for accessibility checks.
11326 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
11327 IsNestedFamilyAccessible.
11328 (TypeManager.IsSubclassOf): New method, do what the name actually
11331 2004-12-06 Raja R Harinath <rharinath@novell.com>
11333 Fix crash on cs0657-17.cs.
11334 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11335 Use RootContext.Tree.Types, not 'new RootTypes ()'.
11336 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
11337 the case where the NamespaceEntry gets overwritten.
11339 2004-12-06 Marek Safar <marek.safar@seznam.cz>
11341 Fixed #69195, #56821
11342 * ecore.cs (ResolveBoolean): Tiny refactoring.
11344 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
11345 of right expression resolving when left is false constant and
11346 operator is LogicalAnd OR true constant and operator is LogicalOr.
11348 * statement.cs (ResolveUnreachable): Always reports warning.
11350 2004-12-05 Miguel de Icaza <miguel@ximian.com>
11352 * class.cs: Distinguish between 1721 and 1722 (just a little help
11353 for the programmer).
11355 2004-12-03 Miguel de Icaza <miguel@ximian.com>
11357 * delegate.cs: Only allow this on new versions of the language.
11359 2004-12-02 Duncan Mak <duncan@ximian.com>
11361 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
11363 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
11364 here as a static method. Take an additional bool out parameter
11365 `must_do_cs1540_check' for signaling to InstanceResolve.
11366 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
11367 member field from PropertyExpr class and made it an argument of
11368 the method instead.
11369 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
11370 check for MarshalByRefObject, and report CS0122 instead of CS1540.
11371 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
11372 and `remove_accessor' as well as InstanceResolve: report CS0122
11377 2004-12-03 Raja R Harinath <rharinath@novell.com>
11379 Fix test-327.cs, test-328.cs, and put in early infrastructure
11380 for eventually fixing #52697.
11381 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
11382 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
11383 from other methods.
11384 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
11385 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
11386 (VerifyUsing, error246): Update.
11387 * rootcontext.cs (RootContext.NamespaceLookup): Just use
11388 'NamespaceEntry.LookupNamespaceOrType'.
11390 2004-12-03 Martin Baulig <martin@ximian.com>
11392 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11393 method as our child, call AnonymousMethod.Compatible() on it.
11395 2004-12-03 Raja R Harinath <rharinath@novell.com>
11397 Disable XML documentation support in 'basic' profile.
11398 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
11399 Redirect XmlElement to System.Object.
11400 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
11401 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
11402 * mcs.exe.sources: Add doc-bootstrap.cs.
11403 * doc-bootstrap.cs: New file. Contains empty stub implementation
11406 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
11408 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
11409 comments are allowed.
11411 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11413 * delegate.cs: Add checks for subtypes in paramaters and return values
11414 in VerifyMethod () to add support for Covariance/Contravariance
11417 2004-12-02 Miguel de Icaza <miguel@ximian.com>
11419 * report.cs: Remove extra closing parenthesis.
11421 * convert.cs (Error_CannotImplicitConversion): If the name of the
11422 types are the same, provide some extra information.
11424 * class.cs (FieldBase): Use an unused bit field from the field to
11425 encode the `has_offset' property from the FieldMember. This saves
11426 a couple of Ks on bootstrap compilation.
11428 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11429 method as our child, return the AnonymousMethod resolved
11432 * expression.cs (New.DoResolve): Allow return values from
11433 NewDelegate to also include AnonymousMethods.
11437 2004-12-02 Marek Safar <marek.safar@seznam.cz>
11440 * attribute.cs (Resolve): Improved implementation of params
11441 attribute arguments.
11443 * support.cs (ParameterData): Add HasParams to be faster.
11445 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
11447 all things are for /doc support:
11449 * doc.cs: new file that supports XML documentation generation.
11450 * mcs.exe.sources: added doc.cs.
11452 Handle /doc command line option.
11453 Report error 2006 instead of 5 for missing file name for /doc.
11454 Generate XML documentation when required, after type resolution.
11456 Added support for picking up documentation (/// and /** ... */),
11457 including a new XmlCommentState enumeration.
11459 Added lines to fill Documentation element for field, constant,
11460 property, indexer, method, constructor, destructor, operator, event
11461 and class, struct, interface, delegate, enum.
11462 Added lines to warn incorrect comment.
11464 Added Documentation field (passed only when /doc was specified).
11466 Added DocComment, DocCommentHeader, GenerateDocComment() and
11467 OnGenerateDocComment() and some supporting private members for
11468 /doc feature to MemberCore.
11470 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
11472 Added overriden DocCommentHeader.
11474 Added overriden DocCommentHeader and GenerateDocComment().
11476 2004-12-01 Miguel de Icaza <miguel@ximian.com>
11478 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
11479 unwrapping the enumeration values, chain to
11480 DoConstantNumericPromotions again, so we can promote things to the
11481 fundamental types (takes care of enums that are bytes, sbytes).
11485 2004-12-01 Raja R Harinath <rharinath@novell.com>
11487 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
11488 Fix long-standing bug in type-lookup. Use FindType instead of
11489 LookupType when ec.ResolvingTypeTree.
11490 (Attribute.ResolveType, Attribute.Resolve)
11491 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
11493 (Attributes.Search): Remove internal version. Update.
11494 (Attributes.SearchMulti): Update.
11495 (Attributes.GetClsCompliantAttribute): Remove.
11496 (Attributes.GetIndexerNameAttribute): Remove.
11497 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
11498 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
11499 * class.cs (Indexer.Define): Likewise.
11501 2004-12-01 Marek Safar <marek.safar@seznam.cz>
11504 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
11505 MarshallByReference members access.
11507 * expression.cs: Use CheckMarshallByRefAccess;
11508 Better error CS0197 message.
11510 * report.cs: Print whole related error message.
11512 2004-11-30 Raja R Harinath <rharinath@novell.com>
11514 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
11515 the current directory to help debugging.
11517 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11519 * class (GetClassBases): Better error 60 report.
11520 (EventProperty): Disabled warning 67 detection.
11522 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11525 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
11527 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
11530 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11533 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
11535 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
11537 2004-11-26 Miguel de Icaza <miguel@ximian.com>
11539 * attribute.cs (Attribute.Resolve): Refine error reporting and
11540 report a cs0117 if the identifier does not exist, to distinguish
11541 from 0617 which is a miss-use of the actual identifier.
11543 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
11544 between cs0070 and cs0079.
11546 * class.cs (MemberBase.DoDefine): When reporting a wrong
11547 accessibility level, we use MethodCore to compare instead of
11548 Method (this was a regression in some refactoring effort).
11550 So now we correctly report cs0056 again.
11552 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
11553 testing the target_type (which was known to be object_type) and
11554 not the source type (which is anonymous_method).
11556 Fixed reporting of error cs1660.
11558 * expression.cs (UserCast.Source): Expose the underlying cast.
11560 * statement.cs (Switch.SwitchGoverningType): Sort the list of
11561 allowed types to find a match to int32 first (most common).
11563 In addition, it ignores any ImplicitUserConversions that did an
11564 internal implicit conversion (as the switch statement allows only
11565 one integral conversion to exist).
11567 * class.cs (PartialContainer.Create): rename `name' to
11568 `member_name' for clarity. Then replace the string calls with a
11569 call to MemberName.GetPartialName, as now using
11570 MemberName.ToString is an error (this is due to the side effects
11571 it had, that were fixed in the past).
11573 This will restore the error reporting on a number of partial class
11574 errors that were missusing this (and getting an exception as a
11575 results, which is now just a plain textual warning, because
11576 yyparse debug output would crash otherwise).
11578 2004-11-26 Raja R Harinath <rharinath@novell.com>
11580 * Makefile (PROGRAM_INSTALL_DIR): Remove.
11582 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11584 * rootcontext.cs (LookupType): Make sure to cache lookups that
11585 don't give us a negative result. This saves about 5% of corlib
11588 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11590 * report.cs (AbstractMessage.Print): messages are sent to stderr
11592 * class.cs (TypeContainer.GetClassBases): It is an error to have a
11593 non-interface in the list of interfaces (at this point, either
11594 parent was properly set, or a base class is being listed in the
11595 interfaces section).
11597 This flags error 1722, and resolves the crash from bug 69259.
11599 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11601 * statement.cs (Using.EmitExpressionFinally): make this work right
11602 for valuetypes. Fixes 69926.
11604 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11606 * const.cs (Const.ChangeType): Cope with the "0 literal can be
11607 converted to an enum" here, before we try to change the underlying
11608 type. This code exists, but it is a different code path than the
11609 one used while encoding constants.
11611 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
11612 old bug: when converting from the null literal to a pointer,
11613 return an EmptyCast, not the NullLiteral.
11615 This fixes #69921, the recent null_type changes probably made this
11616 bug more prominent.
11618 (ImplicitReferenceConversionExists): In addition, resynchronized
11619 the code here, so it matches the same code in
11620 ImplicitReferenceConversionExists for the `from any class-type S
11621 to any interface-type T'.
11624 2004-11-25 Marek Safar <marek.safar@seznam.cz>
11626 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
11628 2004-11-24 Miguel de Icaza <miguel@ximian.com>
11630 * cs-parser.jay: Use verbosity accordingly.
11632 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11634 * expression.cs (Unary.ResolveOperator): Do not report warning;
11635 AddressOf reads from variable.
11637 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
11639 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11643 * attribute.cs (Attributable): Removed CheckTargets.
11644 (Attributes.Emit): Explicit attribute targets are tested here.
11646 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
11647 not enabled for interfaces.
11649 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
11650 (GetAssemblyName): Ouch next bug there.
11652 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11654 * expression.cs: Error 275 added.
11656 2004-11-23 Marek Safar <marek.safar@seznam.cz>
11658 Fix bug #69177 (Implemented decimal constant support)
11660 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
11661 (BinaryFold): Add DecimalConstant.
11663 * const.cs (Define): Decimal constant
11665 (ChangeType): Add decimal type handling.
11666 (LookupConstantValue): Don't set value for decimal type but
11667 emit DecimalConstantAttribute. Needed for constant optimization.
11669 * constant.cs (ToDecimal): New method.
11670 (ConvertToDecimal): New method.
11671 (IntConstant): Implemented ConvertToDecimal.
11672 (DecimalConstant.Emit): Emit optimized version for decimals in
11675 * expression.cs (ResolveOperator): Changed order of constant
11676 reduction to work correctly with native types which have
11677 overloaded operators.
11678 (ResolveMemberAccess): Extract constant value from attribute
11681 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
11683 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
11684 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
11685 (ChangeType): Decimal is special.
11686 (TypeToCoreType): Add decimal type.
11688 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11690 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
11693 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11695 * class.cs (EventField.ApplyAttributeBuilder): Fix error
11698 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11700 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
11702 * pending.cs (PendingImplementation): Grab only interfaces.
11704 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11706 * statement.cs (ForeachHelperMethods): Add location member and
11707 error 202 detection.
11709 2004-11-19 Raja R Harinath <rharinath@novell.com>
11711 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
11712 automatically handled by executable.make.
11713 (PROGRAM): Make profile-specific.
11715 2004-11-18 Marek Safar <marek.safar@seznam.cz>
11717 * expression.cs (DoResolveBase): Fixed wrong warning for out
11720 2004-11-18 Martin Baulig <martin@ximian.com>
11722 Merged latest changes into gmcs. Please keep this comment in
11723 here, it makes it easier for me to see what changed in MCS since
11724 the last time I merged.
11726 2004-11-17 Raja R Harinath <rharinath@novell.com>
11728 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
11729 (TypeHandle.GetMemberCache): New.
11730 (TypeHandle.TypeHandle): Update.
11731 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
11732 (TypeManager.LookupParentInterfacesCache):
11733 Rename from LookupInterfaceCache. Optimize slightly.
11734 (TypeManager.MemberLookup_FindMembers): Update.
11735 * decl.cs (MemberCache.MemberCache): Set Container to null in the
11736 multi-type variant.
11737 (AddCacheContents): Rename from AddHashtable.
11738 * class.cs (TypeContainer.parent_container): Remove.
11739 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
11740 (TypeContainer.DoDefineMembers): Don't initialize it.
11741 Update to name changes.
11743 2004-11-17 Miguel de Icaza <miguel@ximian.com>
11745 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
11746 that factors the code to check access modifiers on override.
11748 (PropertyBase): Use the code here.
11750 Patch from Lluis S'anchez, fixes bug #69361.
11752 2004-11-15 Miguel de Icaza <miguel@ximian.com>
11754 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
11755 routine that is used to report the use of a captured variable
11756 whose address has been taken.
11758 There are two checks: one when variables are being captured and
11759 the other check is when the address of a variable is taken.
11761 (because an anonymous methods might be resolved before *or* after
11762 the address has been taken) and
11764 * expression.cs (Conditional.DoResolve): Remove the special
11765 casing that Martin added to trueExpr and falseExpr being both
11766 NullLiteral. We get the right behavior now just by introducing
11767 the null_type into the compiler.
11769 * convert.cs (ExplicitConversion): Change the code to use
11770 null_type instead of testing `expr is NullLiteral'.
11771 (ImplicitConversionStandard): use null_type too.
11772 (ImplicitReferenceConversionExists): use null_type too.
11773 (ImplicitReferenceConversion): use null_type too.
11775 * literal.cs: The type of `NullLiteral' is now null_type instead
11777 (Resolve): Set the type here.
11779 * typemanager.cs: Introduce null_type.
11781 2004-11-17 Martin Baulig <martin@ximian.com>
11783 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
11784 direction, like FindMembers() does. Fixes #69546, testcase is in
11787 2004-11-16 Martin Baulig <martin@ximian.com>
11789 This is based on a patch from Marek Safar, see bug #69082.
11790 Fixes bugs #63705 and #67130.
11792 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
11793 method; create a MemberCache for an interface type and cache the
11796 * decl.cs (IMemberContainer.ParentContainer): Removed.
11797 (IMemberContainer.ParentCache): New property.
11798 (MemberCache.SetupCacheForInterface): Removed.
11799 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
11800 to create a cache for an interface's "parent".
11802 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
11805 2004-11-16 Martin Baulig <martin@ximian.com>
11807 Merged back from gmcs; these changes already went into gmcs a
11808 couple of weeks ago.
11811 (TypeManager.AddUserType): Removed the `ifaces' argument.
11812 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
11814 (TypeManager.AddUserInterface): Removed.
11815 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
11817 (TypeManager.GetInterfaces): Likewise.
11818 (TypeManager.GetExplicitInterfaces): Likewise.
11820 * ecore.cs (TypeExpr.GetInterfaces): Removed.
11822 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
11823 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
11825 2004-11-14 Ben Maurer <bmaurer@ximian.com>
11827 * statement.cs: Avoid adding bools to a hashtable.
11829 2004-11-07 Miguel de Icaza <miguel@ximian.com>
11831 * expression.cs (Invocation.OverloadResolve): Flag error if we are
11832 calling an unsafe method from a safe location.
11834 2004-11-06 Marek Safar <marek.safar@seznam.cz>
11837 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
11839 2004-11-06 Miguel de Icaza <miguel@ximian.com>
11841 * namespace.cs (VerifyUsing): use GetPartialName instead of
11844 2004-11-05 Miguel de Icaza <miguel@ximian.com>
11846 * statement.cs (Return.Resolve): Fix regression in typo: if
11847 `in_exc', we have to request a NeedReturnLabel, this was a typo
11848 introduced in the anonymous method check-in. Fixes #69131.
11850 * Indexers were using the ShortName when defining themselves,
11851 causing a regression in the compiler bootstrap when applying the
11852 patch from 2004-11-02 (first part), now they use their full name
11853 and the bug is gone.
11855 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
11857 * driver.cs: Strip the path from the names of embedded resources. Fixes
11860 2004-11-04 Raja R Harinath <rharinath@novell.com>
11862 Fix error message regression: cs0104-2.cs.
11863 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
11864 (AliasEntry.Resolve): Update.
11865 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
11867 (RootContext.LookupType): Update.
11869 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
11871 * cs-parser.jay: Add support for handling accessor modifiers
11872 * class: Add support port accessor modifiers and error checking,
11873 define PropertyMethod.Define as virtual (not abstract anymore)
11874 * ecore.cs: Add checking for proeprties access with access modifiers
11875 * iterators.cs: Modify Accessor constructor call based in the modified
11877 2004-11-02 Ben Maurer <bmaurer@ximian.com>
11879 * expression.cs (StringConcat): Handle being called twice,
11880 as when we have a concat in a field init with more than two
11883 2004-11-02 Miguel de Icaza <miguel@ximian.com>
11885 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
11886 special case explicit implementations, we should always produce
11887 the .property or .event declaration.
11889 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
11890 since it will not return correct data if people use this
11891 unresolved in the presence of using statements (see test-313).
11893 * class.cs (MethodData.Define): If we are an explicit interface
11894 implementation, set the method name to the full name of the
11895 interface plus the name of the method.
11897 Notice that using the method.MethodName.GetFullName() does not
11898 work, as it will only contain the name as declared on the source
11899 file (it can be a shorthand in the presence of using statements)
11900 and not the fully qualifed type name, for example:
11904 class D : ICloneable {
11905 object ICloneable.Clone () {
11909 Would produce a method called `ICloneable.Clone' instead of
11910 `System.ICloneable.Clone'.
11912 * namespace.cs (Alias.Resolve): Use GetPartialName.
11914 2004-11-01 Marek Safar <marek.safar@seznam.cz>
11916 * cs-parser.jay: Add error 1055 report.
11918 2004-11-01 Miguel de Icaza <miguel@ximian.com>
11920 * assign.cs (Assign.DoResolve): Only do the transform of
11921 assignment into a New if the types are compatible, if not, fall
11922 through and let the implicit code deal with the errors and with
11923 the necessary conversions.
11925 2004-11-01 Marek Safar <marek.safar@seznam.cz>
11927 * cs-parser.jay: Add error 1031 report.
11929 * cs-tokenizer.cs: Add location for error 1038.
11931 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11933 * cs-parser.jay: Add error 1016 report.
11935 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11937 * cs-parser.jay: Add errors 1575,1611 report.
11939 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11941 * cs-parser.jay: Add error 1001 report.
11943 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11946 * attribute.cs (GetMarshal): Add method argument for
11947 caller identification.
11949 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
11950 agument for GetMarshal and RuntimeMissingSupport.
11952 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11954 * attribute.cs (ExtractSecurityPermissionSet): Removed
11955 TypeManager.code_access_permission_type.
11957 * typemanager.cs: Removed TypeManager.code_access_permission_type.
11959 2004-10-27 Miguel de Icaza <miguel@ximian.com>
11961 * expression.cs (LocalVariableReference.DoResolveLValue): Check
11962 for obsolete use of a variable here. Fixes regression on errors
11963 cs0619-25 and cs0619-26.
11965 2004-10-27 Marek Safar <marek.safar@seznam.cz>
11967 Fix #62358, implemented security attribute encoding.
11969 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
11970 Tests permitted SecurityAction for assembly or other types.
11971 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
11972 data from SecurityPermissionAttribute to PermisionSet class.
11974 * class.cs (ApplyAttributeBuilder): Added special handling
11975 for System.Security.Permissions.SecurityAttribute based types.
11977 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
11978 special handling for System.Security.Permissions.SecurityAttribute
11981 * enum.cs (ApplyAttributeBuilder): Added special handling
11982 for System.Security.Permissions.SecurityAttribute based types.
11984 * parameter.cs (ApplyAttributeBuilder): Added special handling
11985 for System.Security.Permissions.SecurityAttribute based types.
11987 * rootcontext.cs: Next 2 core types.
11989 * typemanager.cs (TypeManager.security_permission_attr_type):
11990 Built in type for the SecurityPermission Attribute.
11991 (code_access_permission_type): Build in type.
11993 2004-10-17 Miguel de Icaza <miguel@ximian.com>
11995 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
11996 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
11997 all of this information into
11998 EmitContext.EmitCapturedVariableInstance.
12000 * codegen.cs (EmitCapturedVariableInstance): move here the
12001 funcionality of emitting an ldarg.0 in the presence of a
12002 remapping. This centralizes the instance emit code.
12004 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
12005 then emit a load of this: it means that we have reached the
12006 topmost ScopeInfo: the one that contains the pointer to the
12007 instance of the class hosting the anonymous method.
12009 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
12010 captures to the topmost CaptureContext.
12012 2004-10-12 Miguel de Icaza <miguel@ximian.com>
12014 * expression.cs (LocalVariableReference): Move the knowledge about
12015 the iterators into codegen's EmitCapturedVariableInstance.
12017 2004-10-11 Miguel de Icaza <miguel@ximian.com>
12019 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
12020 all code paths return a value from an anonymous method (it is the
12021 same as the 161 error, but for anonymous methods).
12023 2004-10-08 Miguel de Icaza <miguel@ximian.com>
12025 The introduction of anonymous methods in the compiler changed
12026 various ways of doing things in the compiler. The most
12027 significant one is the hard split between the resolution phase
12028 and the emission phases of the compiler.
12030 For instance, routines that referenced local variables no
12031 longer can safely create temporary variables during the
12032 resolution phase: they must do so from the emission phase,
12033 since the variable might have been "captured", hence access to
12034 it can not be done with the local-variable operations from the runtime.
12038 (Block.Flags): New flag `IsTopLevel' to indicate that this block
12039 is a toplevel block.
12041 (ToplevelBlock): A new kind of Block, these are the blocks that
12042 are created by the parser for all toplevel method bodies. These
12043 include methods, accessors and anonymous methods.
12045 These contain some extra information not found in regular blocks:
12046 A pointer to an optional CaptureContext (for tracking captured
12047 local variables and parameters). A pointer to the parent
12050 (Return.Resolve): Catch missmatches when returning a value from an
12051 anonymous method (error 1662).
12052 Invoke NeedReturnLabel from the Resolve phase instead of the emit
12055 (Break.Resolve): ditto.
12057 (SwitchLabel): instead of defining the labels during the
12058 resolution phase, we now turned the public ILLabel and ILLabelCode
12059 labels into methods called GetILLabelCode() and GetILLabel() that
12060 only define the label during the Emit phase.
12062 (GotoCase): Track the SwitchLabel instead of the computed label
12063 (its contained therein). Emit the code by using
12064 SwitchLabel.GetILLabelCode ().
12066 (LocalInfo.Flags.Captured): A new flag has been introduce to track
12067 whether the Local has been captured or not.
12069 (LocalInfo.IsCaptured): New property, used to tell whether the
12070 local has been captured.
12072 * anonymous.cs: Vastly updated to contain the anonymous method
12075 The main classes here are: CaptureContext which tracks any
12076 captured information for a toplevel block and ScopeInfo used to
12077 track the activation frames for various local variables.
12079 Each toplevel block has an optional capture context associated
12080 with it. When a method contains an anonymous method both the
12081 toplevel method and the anonymous method will create a capture
12082 context. When variables or parameters are captured, they are
12083 recorded on the CaptureContext that owns them, for example:
12087 MyDelegate d = delegate {
12092 Here `a' will be recorded as captured on the toplevel
12093 CapturedContext, the inner captured context will not have anything
12094 (it will only have data if local variables or parameters from it
12095 are captured in a nested anonymous method.
12097 The ScopeInfo is used to track the activation frames for local
12098 variables, for example:
12100 for (int i = 0; i < 10; i++)
12101 for (int j = 0; j < 10; j++){
12102 MyDelegate d = delegate {
12107 At runtime this captures a single captured variable `i', but it
12108 captures 10 different versions of the variable `j'. The variable
12109 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
12110 recorded on a child.
12112 The toplevel ScopeInfo will also track information like the `this'
12113 pointer if instance variables were referenced (this is necessary
12114 as the anonymous method lives inside a nested class in the host
12115 type of the method).
12117 (AnonymousMethod): Expanded to track the Toplevel, implement
12118 `AnonymousMethod.Compatible' to tell whether an anonymous method
12119 can be converted to a target delegate type.
12121 The routine now also produces the anonymous method content
12123 (AnonymousDelegate): A helper class that derives from
12124 DelegateCreation, this is used to generate the code necessary to
12125 produce the delegate for the anonymous method that was created.
12127 * assign.cs: API adjustments for new changes in
12128 Convert.ImplicitStandardConversionExists.
12130 * class.cs: Adjustments to cope with the fact that now toplevel
12131 blocks are of type `ToplevelBlock'.
12133 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
12134 insteda of standard blocks.
12136 Flag errors if params arguments are passed to anonymous methods.
12138 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
12139 `CurrentAnonymousMethod' which points to the current Anonymous
12140 Method. The variable points to the AnonymousMethod class that
12141 holds the code being compiled. It is set in the new EmitContext
12142 created for the anonymous method.
12144 (EmitContext.Phase): Introduce a variable and an enumeration to
12145 assist in enforcing some rules about when and where we are allowed
12146 to invoke certain methods (EmitContext.NeedsReturnLabel is the
12147 only one that enfonces this right now).
12149 (EmitContext.HaveCaptureInfo): new helper method that returns
12150 whether we have a CapturedContext initialized.
12152 (EmitContext.CaptureVariable): New method used to register that a
12153 LocalInfo must be flagged for capturing.
12155 (EmitContext.CapturedParameter): New method used to register that a
12156 parameters must be flagged for capturing.
12158 (EmitContext.CapturedField): New method used to register that a
12159 field must be flagged for capturing.
12161 (EmitContext.HaveCapturedVariables,
12162 EmitContext.HaveCapturedFields): Return whether there are captured
12163 variables or fields.
12165 (EmitContext.EmitMethodHostInstance): This is used to emit the
12166 instance for the anonymous method. The instance might be null
12167 (static methods), this (for anonymous methods that capture nothing
12168 and happen to live side-by-side with the current method body) or a
12169 more complicated expression if the method has a CaptureContext.
12171 (EmitContext.EmitTopBlock): Routine that drives the emission of
12172 code: it will first resolve the top block, then emit any metadata
12173 and then emit the code. The split is done so that we can extract
12174 any anonymous methods and flag any captured variables/parameters.
12176 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
12177 during this phase, the ILGenerator should not be used as labels
12178 and local variables declared here might not be accessible to any
12179 code that is part of an anonymous method.
12181 Exceptions to this include the temporary variables that are
12182 created by some statements internally for holding temporary
12185 (EmitContext.EmitMeta): New routine, in charge of emitting all the
12188 (EmitContext.TemporaryReturn): This method is typically called
12189 from the Emit phase, and its the only place where we allow the
12190 ReturnLabel to be defined other than the EmitMeta. The reason is
12191 that otherwise we would have to duplicate a lot of logic in the
12192 Resolve phases of various methods that today is on the Emit
12195 (EmitContext.NeedReturnLabel): This no longer creates the label,
12196 as the ILGenerator is not valid during the resolve phase.
12198 (EmitContext.EmitThis): Extended the knowledge in this class to
12199 work in anonymous methods in addition to iterators.
12201 (EmitContext.EmitCapturedVariableInstance): This emits whatever
12202 code is necessary on the stack to access the instance to a local
12203 variable (the variable will be accessed as a field).
12205 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
12206 EmitContext.EmitAddressOfParameter): Routines to support
12207 parameters (not completed at this point).
12209 Removals: Removed RemapLocal and RemapLocalLValue. We probably
12210 will also remove the parameters.
12212 * convert.cs (Convert): Define a `ConstantEC' which points to a
12213 null. This is just to prefity some code that uses
12214 ImplicitStandardConversion code and do not have an EmitContext
12217 The idea is to flag explicitly that at that point in time, it is
12218 known that the conversion will not trigger the delegate checking
12219 code in implicit conversions (which requires a valid
12222 Everywhere: pass new EmitContext parameter since
12223 ImplicitStandardConversionExists now requires it to check for
12224 anonymous method conversions.
12226 (Convert.ImplicitStandardConversionExists): If the type of an
12227 expression is the anonymous_method_type, and the type is a
12228 delegate, we invoke the AnonymousMethod.Compatible method to check
12229 whether an implicit conversion is possible.
12231 (Convert.ImplicitConversionStandard): Only do implicit method
12232 group conversions if the language level is not ISO_1.
12234 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
12235 MethodInfo for the Invoke method. used by Delegate and
12238 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
12239 method conversions if the target type is a delegate.
12241 Removed extra debugging nops.
12243 (LocalVariableReference): Turn the `local_info' into a public
12246 Add `prepared' field, the same hack used for FieldExprs to cope
12247 with composed assignments, as Local variables do not necessarily
12248 operate purely on the stack as they used to: they can be captured
12251 Add `temp' for a temporary result, like fields.
12253 Refactor DoResolve and DoResolveLValue into DoResolveBase.
12255 It now copes with Local variables that are captured and emits the
12256 proper instance variable to load it from a field in the captured
12259 (ParameterReference.DoResolveBase): During the resolve phase,
12260 capture parameters if we are in an anonymous method.
12262 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
12263 anonymous method, use the EmitContext helper routines to emit the
12264 parameter reference.
12266 * iterators.cs: Set RemapToProxy to true/false during the
12269 * parameters.cs (GetParameterByName): New helper method.
12271 * typemanager.cs (anonymous_method_type) a new type that
12272 represents an anonyous method. This is always an internal type,
12273 used as a fencepost to test against the anonymous-methodness of an
12276 2004-10-20 Marek Safar <marek.safar@seznam.cz>
12278 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
12280 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
12282 2004-10-18 Martin Baulig <martin@ximian.com>
12284 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
12285 `Type' directly, but call ResolveType() on it.
12286 (Catch.Resolve): Likewise.
12287 (Foreach.Resolve): Likewise.
12289 2004-10-18 Martin Baulig <martin@ximian.com>
12291 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
12292 `Type' directly, but call ResolveType() on it.
12293 (Probe.DoResolve): Likewise.
12294 (ArrayCreation.LookupType): Likewise.
12295 (TypeOf.DoResolve): Likewise.
12296 (SizeOf.DoResolve): Likewise.
12298 2004-10-18 Martin Baulig <martin@ximian.com>
12300 * expression.cs (Invocation.BetterFunction): Put back
12301 TypeManager.TypeToCoreType().
12303 2004-10-18 Raja R Harinath <rharinath@novell.com>
12305 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
12308 2004-10-18 Martin Baulig <martin@ximian.com>
12310 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
12311 `Type' directly, but call ResolveType() on it.
12313 2004-10-18 Martin Baulig <martin@ximian.com>
12315 * class.cs (FieldMember.Define): Don't access the TypeExpr's
12316 `Type' directly, but call ResolveType() on it.
12317 (MemberBase.DoDefine): Likewise.
12319 * expression.cs (New.DoResolve): Don't access the TypeExpr's
12320 `Type' directly, but call ResolveType() on it.
12321 (ComposedCast.DoResolveAsTypeStep): Likewise.
12323 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
12324 `Type' directly, but call ResolveType() on it.
12326 2004-10-17 John Luke <john.luke@gmail.com>
12328 * class.cs (Operator.GetSignatureForError): use CSharpName
12330 * parameter.cs (Parameter.GetSignatureForError): Returns
12331 correct name even if was not defined.
12333 2004-10-13 Raja R Harinath <rharinath@novell.com>
12336 * class.cs (TypeContainer.EmitContext): New property.
12337 (DefineNestedTypes): Create an emitcontext for each part.
12338 (MethodCore.DoDefineParameters): Use container's emitcontext.
12339 Pass type array to InternalParameters.
12340 (MemberBase.DoDefine): Use container's emitcontext.
12341 (FieldMember.Define): Likewise.
12342 (Event.Define): Likewise.
12343 (SetMethod.GetParameterInfo): Change argument to EmitContext.
12344 Pass type array to InternalParameters.
12345 (SetIndexerMethod.GetParameterInfo): Likewise.
12346 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
12347 * delegate.cs (Define): Pass emitcontext to
12348 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
12349 array to InternalParameters.
12350 * expression.cs (ParameterReference.DoResolveBase): Pass
12351 emitcontext to GetParameterInfo.
12352 (ComposedCast.DoResolveAsTypeStep): Remove check on
12353 ec.ResolvingTypeTree.
12354 * parameter.cs (Parameter.Resolve): Change argument to
12355 EmitContext. Use ResolveAsTypeTerminal.
12356 (Parameter.GetSignature): Change argument to EmitContext.
12357 (Parameters.ComputeSignature): Likewise.
12358 (Parameters.ComputeParameterTypes): Likewise.
12359 (Parameters.GetParameterInfo): Likewise.
12360 (Parameters.ComputeAndDefineParameterTypes): Likewise.
12361 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
12362 * support.cs (InternalParameters..ctor): Remove variant that takes
12364 * typemanager.cs (system_intptr_expr): New.
12365 (InitExpressionTypes): Initialize it.
12367 2004-10-12 Chris Toshok <toshok@ximian.com>
12369 * cs-parser.jay: fix location for try_statement and catch_clause.
12371 2004-10-11 Martin Baulig <martin@ximian.com>
12373 * report.cs: Don't make --fatal abort on warnings, we have
12374 -warnaserror for that.
12376 2004-10-07 Raja R Harinath <rharinath@novell.com>
12378 More DeclSpace.ResolveType avoidance.
12379 * decl.cs (MemberCore.InUnsafe): New property.
12380 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
12381 with newly created EmitContext.
12382 (FieldMember.Define): Likewise.
12383 * delegate.cs (Delegate.Define): Likewise.
12384 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
12385 only if normal name-lookup fails.
12386 (TypeExpr.DoResolve): Enable error-checking.
12387 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
12388 (SizeOf.DoResolve): Likewise.
12389 (ComposedCast.DoResolveAsTypeStep): Likewise.
12390 (StackAlloc.DoResolve): Likewise.
12391 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
12392 (Block.Unsafe): New property.
12393 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
12394 (Unsafe): Set 'unsafe' flag of contained block.
12395 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
12396 (Fixed.Resolve): Likewise.
12397 (Catch.Resolve): Likewise.
12398 (Using.ResolveLocalVariableDecls): Likewise.
12399 (Foreach.Resolve): Likewise.
12401 2004-10-05 John Luke <john.luke@gmail.com>
12403 * cs-parser.jay: add location to error CS0175
12405 2004-10-04 Miguel de Icaza <miguel@ximian.com>
12407 * ecore.cs (Expression.Constantity): Add support for turning null
12410 * const.cs (Const.Define): Allow constants to be reference types
12411 as long as the value is Null.
12413 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
12415 * namespace.cs (NamespaceEntry.Using): No matter which warning
12416 level is set, check if this namespace name has already been added.
12418 2004-10-03 Ben Maurer <bmaurer@ximian.com>
12420 * expression.cs: reftype [!=]= null should always use br[true,false].
12423 2004-10-03 Marek Safar <marek.safar@seznam.cz>
12426 * attribute.cs: Enum conversion moved to
12427 GetAttributeArgumentExpression to be applied to the all
12430 2004-10-01 Raja R Harinath <rharinath@novell.com>
12432 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
12433 * class.c (TypeContainer.DefineType): Flag error if
12434 base types aren't accessible due to access permissions.
12435 * decl.cs (DeclSpace.ResolveType): Move logic to
12436 Expression.ResolveAsTypeTerminal.
12437 (DeclSpace.ResolveTypeExpr): Thin layer over
12438 Expression.ResolveAsTypeTerminal.
12439 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
12440 Refactor code into NestedAccess. Use it.
12441 (DeclSpace.NestedAccess): New.
12442 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
12443 argument to silence errors. Check access permissions.
12444 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
12445 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
12446 (Cast.DoResolve): Likewise.
12447 (New.DoResolve): Likewise.
12448 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
12449 (TypeOf.DoResolve): Likewise.
12451 * expression.cs (Invocation.BetterConversion): Return the Type of
12452 the better conversion. Implement section 14.4.2.3 more faithfully.
12453 (Invocation.BetterFunction): Make boolean. Make correspondence to
12454 section 14.4.2.2 explicit.
12455 (Invocation.OverloadResolve): Update.
12456 (Invocation): Remove is_base field.
12457 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
12458 (Invocation.Emit): Likewise.
12460 2004-09-27 Raja R Harinath <rharinath@novell.com>
12462 * README: Update to changes.
12464 2004-09-24 Marek Safar <marek.safar@seznam.cz>
12466 * cs-parser.jay: Reverted 642 warning fix.
12468 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12471 * decl.cs (FindMemberWithSameName): Indexer can have more than
12474 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12476 * expression.cs (LocalVariableReference.DoResolveLValue):
12477 Do not report warning 219 for out values.
12478 (EmptyExpression.Null): New member to avoid extra allocations.
12480 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12482 * cs-parser.jay: Fix wrong warning 642 report.
12484 * cs-tokenizer.cs (CheckNextToken): New helper;
12485 Inspect next character if is same as expected.
12487 2004-09-23 Martin Baulig <martin@ximian.com>
12489 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
12490 (Convert.ImplicitReferenceConversionExists): Likewise.
12492 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12494 * class.cs (Operator.Define): Add error 448 and 559 report.
12496 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12498 * class.cs (MemberBase.IsTypePermitted): New protected
12499 method for checking error CS0610.
12501 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12503 * class.cs (TypeContainer.HasExplicitLayout): New property
12504 Returns whether container has StructLayout attribute set Explicit.
12505 (FieldMember): New abstract class for consts and fields.
12506 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
12507 (Field): Reuse FieldMember.
12509 * const.cs (Const): Reuse FieldMember.
12511 * rootcontext.cs: EmitConstants call moved to class.
12513 2004-09-22 Martin Baulig <martin@ximian.com>
12515 Thanks to Peter Sestoft for this bug report.
12517 * expression.cs (Conditional): If both the `trueExpr' and the
12518 `falseExpr' is a NullLiteral, return a NullLiteral.
12520 2004-09-22 Martin Baulig <martin@ximian.com>
12522 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
12523 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
12524 for the "get_Current" call.
12526 2004-09-22 Martin Baulig <martin@ximian.com>
12528 Marek and me just fixed one of our oldest bugs: #28562 :-)
12530 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
12532 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
12533 we're an EnumConstant, just return that.
12534 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
12535 an EnumConstant. In this case, we need to use GetValueAsEnumType()
12536 to get the value which'll actually be written into the attribute.
12537 However, we have to use GetValue() to access the attribute's value
12540 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12542 * constant.cs (Constant.IsNegative): New abstract property
12545 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
12546 (StackAlloc.DoResolve): Reused IsNegative.
12548 2004-09-21 Martin Baulig <martin@ximian.com>
12550 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
12551 if we're used in an iterator, we may be called from different
12554 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
12555 we actually have an exception block.
12557 2004-09-20 John Luke <jluke@cfl.rr.com>
12559 * class.cs, cs-parser.jay: Improve the error report for 1520:
12560 report the actual line where the error happens, not where the
12561 class was declared.
12563 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
12564 Pass location information that was available elsewhere.
12566 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
12568 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
12569 runtime to delay sign assemblies.
12571 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12573 * cs-parser.jay: Do not report the stack trace, this is barely
12576 2004-08-22 John Luke <john.luke@gmail.com>
12578 * driver.cs : check that a resource id is not already used
12579 before adding it, report CS1508 if it is, bug #63637
12581 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12583 * ecore.cs: Removed dead code.
12585 2004-09-18 Marek Safar <marek.safar@seznam.cz>
12587 * class.cs: Do not report warning CS0067 on the interfaces.
12589 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12591 * cs-parser.jay: Add error 504 report.
12593 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12595 * rootcontext.cs: WarningLevel is 4 by default now.
12597 * statement.cs (Fixed.Resolve): Do not null
12600 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12603 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
12604 deep search when property is not virtual.
12605 (PropertyExpr.ResolveAccessors): Make one call for both
12608 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12611 * statement.cs: Error 152 report constains also location.
12613 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12616 * const.cs: Explicitly set constant as static.
12618 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12621 * cs-parser.jay: Add error 1017 report.
12623 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12625 Fixed bug #59980, #64224
12626 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
12628 * typemanager.cs (IsSpecialMethod): Simplified
12630 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12632 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
12633 condition with better params.
12635 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12638 * attribute.cs (Resolve): Property has to have both
12641 2004-09-14 Martin Baulig <martin@ximian.com>
12643 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
12645 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12648 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
12649 called and is obsolete then this member suppress message
12650 when call is inside next [Obsolete] method or type.
12652 * expression.cs: Use TestObsoleteMethodUsage member.
12654 2004-09-14 Martin Baulig <martin@ximian.com>
12656 * cs-parser.jay: Sync a bit with the GMCS version.
12658 2004-09-14 Martin Baulig <martin@ximian.com>
12660 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
12661 (CSharpParser.yacc_verbose_flag): New public field.
12663 * genericparser.cs: Removed.
12665 2004-09-14 Raja R Harinath <rharinath@novell.com>
12667 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
12669 2004-09-13 Marek Safar <marek.safar@seznam.cz>
12671 * class.cs (MethodCore.CheckBase): Fix bug #65757.
12673 2004-09-10 Martin Baulig <martin@ximian.com>
12675 Backported my MemberName changes from GMCS into MCS.
12677 - we are now using a special `MemberName' class instead of using
12678 strings; in GMCS, the `MemberName' also contains the type
12681 - changed the grammar rules a bit:
12682 * the old `member_name' is now a `namespace_or_type_name':
12683 The rule is that we use `namespace_or_type_name' everywhere
12684 where we expect either a "member name" (GetEnumerator) or a
12685 "member name" with an explicit interface name
12686 (IEnumerable.GetEnumerator).
12687 In GMCS, the explicit interface name may include type arguments
12688 (IEnumerable<T>.GetEnumerator).
12689 * we use `member_name' instead of just `IDENTIFIER' for
12691 The rule is that we use `member_name' wherever a member may
12692 have type parameters in GMCS.
12694 * decl.cs (MemberName): New public class.
12695 (MemberCore.MemberName): New public readonly field.
12696 (MemberCore.ctor): Take a `MemberName' argument, not a string.
12697 (DeclSpace): Likewise.
12699 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
12700 * enum.cs (Enum.ctor): Likewise.
12702 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
12704 (AliasEntry.ctor): Take a MemberName, not an Expression.
12705 (AliasEntry.UsingAlias): Likewise.
12707 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
12708 (IMethodData.MemberName): Changed type from string to MemberName.
12709 (MemberBase.ExplicitInterfaceName): Likewise.
12710 (AbstractPropertyEventMethod.SetupName): Make this private.
12711 (AbstractPropertyEventMethod.ctor): Added `string prefix'
12712 argument; compute the member name here.
12713 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
12714 on the `member.MemberName' and the `prefix'.
12716 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
12718 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
12719 thus, we get a `MemberName' instead of a `string'. These
12720 declarations may have type parameters in GMCS.
12721 (interface_method_declaration, delegate_declaration): Likewise.
12722 (class_declaration, interface_declaration): Likewise.
12723 (method_header): Use `namespace_or_type_name' instead of
12724 `member_name'. We may be an explicit interface implementation.
12725 (property_declaration, event_declaration): Likewise.
12726 (member_name): This is now just an `IDENTIFIER', not a
12727 `namespace_or_type_name'.
12728 (type_name, interface_type): Removed.
12729 (namespace_or_type_name): Return a MemberName, not an Expression.
12730 (primary_expression): Use `member_name' instead of `IDENTIFIER';
12731 call GetTypeExpression() on the MemberName to get an expression.
12732 (IndexerDeclaration.interface_type): Changed type from string to
12734 (MakeName): Operate on MemberName's instead of string's.
12736 2004-09-13 Raja R Harinath <rharinath@novell.com>
12739 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
12740 (NamespaceEntry.Lookup): Add new argument to flag if we want the
12741 lookup to avoid symbols introduced by 'using'.
12742 * rootcontext.cs (NamespaceLookup): Update.
12744 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12746 * class.cs (TypeContainer.DoDefineMembers): Do not call
12747 DefineDefaultConstructor for static classes.
12749 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12751 * attribute.cs (Attribute.Resolve): Add error 653 report.
12753 * class.cs (Class.ApplyAttributeBuilder): Add error 641
12755 (Method.ApplyAttributeBuilder): Add error 685 report.
12756 (Operator.Define): Add error 564 report.
12758 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
12760 * expression.cs (Invocation.DoResolve): Add error
12761 245 and 250 report.
12763 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
12766 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12768 * class.cs (ConstructorInitializer.Resolve):
12769 Wrong error number (515->516).
12771 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12773 * class.cs (Indexer.Define): Add error 631 report.
12775 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12777 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
12779 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12781 * expression.cs (Probe.DoResolve): Add error CS0241 report.
12783 2004-09-10 Marek Safar <marek.safar@seznam.cz>
12785 * cs-parser.jay: Added error CS0241 report.
12787 2004-09-10 Raja R Harinath <rharinath@novell.com>
12789 * cs-parser.jay (fixed_statement): Introduce a scope for the
12790 declaration in the 'fixed' statement.
12792 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12794 * cs-parser.jay: Added CS0230 error report.
12796 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12798 * cs-parser.jay: Added errors CS0231 and CS0257 report.
12800 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12802 * expression.cs (Argument.Resolve): Added error CS0192 and
12805 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12807 C# 2.0 #pragma warning feature
12809 * cs-tokenizer.cs (PreProcessPragma): New method;
12810 Handles #pragma directive.
12812 * report.cs (WarningRegions): New class; Support
12813 class for #pragma warning directive. It tests whether
12814 warning is enabled for a given line.
12816 2004-09-08 Miguel de Icaza <miguel@ximian.com>
12818 * const.cs: Add more descriptive error report, tahnks to
12821 2004-09-08 Marek Safar <marek.safar@seznam.cz>
12823 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
12825 2004-09-07 Miguel de Icaza <miguel@ximian.com>
12827 * expression.cs: Apply patch from Ben: Remove dead code from
12828 ArrayCreation, and remove the TurnintoConstant call in const.cs,
12829 as that code just threw an exception anwyays.
12831 * const.cs: Remove the call to the turnintoconstant, for details
12834 * literal.cs: The type of the null-literal is the null type; So
12835 we use a placeholder type (literal.cs:System.Null, defined here)
12838 * expression.cs (Conditional.DoResolve): Remove some old code that
12839 is no longer needed, conversions have been fixed.
12841 (ArrayCreationExpression.DoResolve): Return false if we fail to
12842 resolve the inner expression.
12844 2004-09-07 Raja R Harinath <rharinath@novell.com>
12847 * cs-parser.jay (delegate_declaration): Record a delegate
12848 declaration as a type declaration.
12849 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
12851 2004-09-06 Miguel de Icaza <miguel@ximian.com>
12853 * parameter.cs: Do not crash if the type can not be resolved.
12855 * expression.cs: Report errors with unsafe pointers, fixes #64896
12857 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
12859 * expression.cs: Pointer arith always needs to do a conv.i
12860 if the operand is a long. fix 65320
12862 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12864 Fixed cs0619-37.cs, cs0619-38.cs
12866 * enum.cs (GetObsoleteAttribute): Removed.
12868 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
12869 on Enum member is double staged. The first is tested member
12872 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12874 Fixed #56986, #63631, #65231
12876 * class.cs: (TypeContainer.AddToMemberContainer): New method,
12877 adds member to name container.
12878 (TypeContainer.AddToTypeContainer): New method, adds type to
12880 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
12881 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
12882 AddOperator): Simplified by reusing AddToMemberContainer.
12883 (TypeContainer.UserDefinedStaticConstructor): Changed to property
12885 (Method.CheckForDuplications): Fixed implementation to test all
12887 (MemberBase): Detection whether member is explicit interface
12888 implementation is now in constructor.
12889 (MemberBase.UpdateMemberName): Handles IndexerName.
12890 (Accessor): Changed to keep also location information.
12891 (AbstractPropertyEventMethod): Is derived from MemberCore.
12892 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
12893 will be emited or not.
12894 (PropertyBase.AreAccessorsDuplicateImplementation):
12895 Tests whether accessors are not in collision with some method.
12896 (Operator): Is derived from MethodCore to simplify common
12899 * decl.cs (Flags.TestMethodDuplication): Test for duplication
12901 (DeclSpace.AddToContainer): Adds the member to defined_names
12902 table. It tests for duplications and enclosing name conflicts.
12904 * enum.cs (EnumMember): Clean up to reuse the base structures
12906 2004-09-03 Martin Baulig <martin@ximian.com>
12908 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
12909 into TypeContainer, to make partial classes work again.
12911 2004-09-03 Martin Baulig <martin@ximian.com>
12913 * rootcontext.cs (RootContext.V2): Removed.
12915 2004-03-23 Martin Baulig <martin@ximian.com>
12917 * expression.cs (Invocation.OverloadResolve): Added `bool
12918 may_fail' argument and use it instead of the Location.IsNull() hack.
12920 2004-09-03 Martin Baulig <martin@ximian.com>
12922 Merged latest changes into gmcs. Please keep this comment in
12923 here, it makes it easier for me to see what changed in MCS since
12924 the last time I merged.
12926 2004-09-03 Raja R Harinath <rharinath@novell.com>
12929 * expression.cs (BetterConversion): Don't allow either conversion
12930 to be null. Remove redundant implicit conversion test when 'q ==
12931 null' -- when this function is invoked, we already know that the
12932 implicit conversion exists.
12933 (BetterFunction): Assume that 'best' is non-null. Remove
12934 redundant reimplementation of IsApplicable when 'best' is null.
12935 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
12936 number of arguments.
12937 (IsAncestralType): Extract from OverloadResolve.
12938 (OverloadResolve): Make robust to the MethodGroupExpr being
12939 unsorted. Implement all the logic of Section 14.5.5.1, and
12940 support overloading of methods from multiple applicable types.
12941 Clean up logic somewhat. Don't pass null methods to BetterFunction.
12943 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
12944 (RealError, Warning): Append type of report to related symbol.
12946 2004-09-03 Marek Safar <marek.safar@seznam.cz>
12948 * enum.cs: Fixed CLS-Compliance checks for enum members.
12949 Error tests cs3008-8.cs, cs3014-8.cs
12951 2004-09-02 Marek Safar <marek.safar@seznam.cz>
12953 Fixed bug #62342, #63102
12954 * class.cs: ImplementIndexer uses member.IsExplicitImpl
12955 like ImplementMethod.
12957 2004-09-02 Marek Safar <marek.safar@seznam.cz>
12959 * attribute.cs (Attribute.GetAttributeArgumentExpression):
12962 2004-09-02 Martin Baulig <martin@ximian.com>
12964 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
12965 TypeManager.GetArgumentTypes() rather than calling GetParameters()
12968 2004-09-01 Marek Safar <marek.safar@seznam.cz>
12970 C# 2.0 Static classes implemented
12972 * class.cs (TypeContainer): instance_constructors,
12973 initialized_fields, initialized_static_fields,
12974 default_constructor, base_inteface_types are protected to be
12975 accessible from StaticClass.
12976 (TypeContainer.DefineDefaultConstructor): New virtual method
12977 for custom default constructor generating
12978 (StaticClass): New class to handle "Static classes" feature.
12980 * cs-parser.jay: Handle static keyword on class like instance
12983 * driver.cs: Added "/langversion" command line switch with two
12984 options (iso-1, default).
12986 2004-08-31 Marek Safar <marek.safar@seznam.cz>
12988 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
12990 2004-08-31 Miguel de Icaza <miguel@ximian.com>
12992 * delegate.cs: Style.
12994 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
12996 * delegate.cs: Add seperate instance expr field for miguel.
12998 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
13000 * PointerArithmetic (Resolve): make sure we are not doing
13001 pointer arith on void*. Also, make sure we are resolved
13002 by not setting eclass until resolve.
13004 All callers: Make sure that PointerArithmetic gets resolved.
13006 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
13008 * ArrayCreation (LookupType): If the type does not resolve
13009 to an array, give an error.
13011 2004-08-27 Marek Safar <marek.safar@seznam.cz>
13013 * statement.cs (Try.Resolve): Fixed bug #64222
13015 2004-08-27 Martin Baulig <martin@ximian.com>
13018 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
13021 2004-08-26 Marek Safar <marek.safar@seznam.cz>
13023 * ecore.cs (Constantify): Get underlying type via
13024 System.Enum.GetUnderlyingType to avoid StackOverflow on the
13025 Windows in special cases.
13027 2004-08-26 Marek Safar <marek.safar@seznam.cz>
13029 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
13030 for obtaining also private methods.
13031 (GetRemoveMethod): Used GetRemoveMethod (true)
13032 for obtaining also private methods.
13034 2004-08-24 Martin Baulig <martin@ximian.com>
13036 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
13037 MethodAttributes.HideBySig for operators.
13039 2004-08-23 Martin Baulig <martin@ximian.com>
13041 Back to the old error reporting system :-)
13043 * report.cs (Message): Removed.
13044 (Report.MessageData, ErrorData, WarningData): Removed.
13045 (Report.Error, Warning): Back to the old system.
13047 2004-08-23 Martin Baulig <martin@ximian.com>
13049 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
13051 * class.cs (TypeContainer.ParentContainer): New public virtual
13052 method; replaces the explicit interface implementation.
13053 (ClassPart.ParentContainer): Override.
13055 2004-08-23 Martin Baulig <martin@ximian.com>
13057 * statement.cs (Switch): Added support for constant switches; see
13058 #59428 or test-285.cs.
13060 2004-08-22 Marek Safar <marek.safar@seznam.cz>
13063 * statement.cs (GetEnumeratorFilter): Removed useless
13064 logic because C# specs is strict. GetEnumerator must be
13067 2004-08-22 Martin Baulig <martin@ximian.com>
13069 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13070 a switch and may break, reset the barrier. Fixes #59867.
13072 2004-08-22 Marek Safar <marek.safar@seznam.cz>
13074 CLS-Compliance speed up (~5% for corlib)
13076 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
13077 New method. Tests container for CLS-Compliant names
13079 * class.cs (TypeContainer.VerifyClsName): New method.
13080 Checks whether container name is CLS Compliant.
13081 (Constructor): Implements IMethodData.
13083 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
13084 low-case table for CLS Compliance test.
13085 (MemberCache.VerifyClsParameterConflict): New method.
13086 Checks method parameters for CS3006 error.
13088 * enum.cs (EnumMember): Is derived from MemberCore.
13089 (Enum.VerifyClsName): Optimized for better performance.
13091 2004-08-06 Marek Safar <marek.safar@seznam.cz>
13093 * report.cs: Renamed Error_T to Error and changed all
13096 2004-08-06 Marek Safar <marek.safar@seznam.cz>
13098 * class.cs (TypeContainer.IndexerArrayList): New inner class
13099 container for indexers.
13100 (TypeContainer.DefaultIndexerName): New constant for default
13101 indexer name. Replaced all "Item" with this constant.
13102 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
13104 * typemanager.cs (TypeManager.default_member_ctor): Cache here
13105 DefaultMemberAttribute constructor.
13107 2004-08-05 Martin Baulig <martin@ximian.com>
13109 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13112 2004-08-05 Marek Safar <marek.safar@seznam.cz>
13114 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
13115 multi platforms problem.
13117 * compiler.csproj: Included shared files.
13119 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13121 Fix bug 60333, 55971 in the more general way
13122 * attribute.cs (Attribute.GetAttributeArgumentExpression):
13123 Added arg_type argument for constant conversion.
13124 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
13126 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13129 * class.cs (TypeContainer ): New inner classes MethodArrayList,
13130 OperatorArrayList, MethodCoreArrayList for typecontainer
13131 containers. Changed class member types to these new types.
13132 (MethodArrayList.DefineMembers): Added test for CS0659.
13134 2004-08-04 Miguel de Icaza <miguel@ximian.com>
13136 * cfold.cs: Synchronize the folding with the code in expression.cs
13137 Binary.DoNumericPromotions for uint operands.
13139 * attribute.cs: Revert patch from Raja, it introduced a regression
13140 while building Blam-1.2.1 (hard to isolate a test case).
13142 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13146 (TypeContainer.Define): Renamed to DefineContainerMembers because of
13148 (MethodCore.parent_method): New member. The method we're overriding
13149 if this is an override method.
13150 (MethodCore.CheckBase): Moved from Method class and made common.
13151 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
13153 (MethodCore.CheckForDuplications): New abstract method. For custom
13154 member duplication search in a container
13155 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
13156 method and its return type.
13157 (Event.conflict_symbol): New member. Symbol with same name in the
13161 (MemberCache.FindMemberWithSameName): New method. The method
13162 is looking for conflict with inherited symbols.
13164 2004-08-04 Martin Baulig <martin@ximian.com>
13166 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
13168 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
13170 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13172 * report.cs (Message): New enum for better error, warning reference in
13174 (MessageData): New inner abstract class. It generally handles printing of
13175 error and warning messages.
13176 Removed unused Error, Warning, Message methods.
13178 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13180 Fix for cs0592-8.cs test
13182 (Attributable.ValidAttributeTargets): Made public.
13183 (Attribute.ExplicitTarget): New member for explicit target value.
13184 (Attribute.CheckTargets): Now we translate explicit attribute
13185 target to Target here.
13187 2004-08-03 Ben Maurer <bmaurer@ximian.com>
13189 * ecore.cs (MethodGroupExpr): new IsBase property.
13191 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
13193 * delegate.cs (DelegateCreation): store a MethodGroupExpr
13194 rather than an instance expr.
13196 (DelegateCreation.Emit): Use the method group rather than
13197 the instance expression. Also, if you have base.Foo as the
13198 method for a delegate, make sure to emit ldftn, not ldftnvirt.
13200 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
13202 (NewDelegate.DoResolve): Only check for the existance of Invoke
13203 if the method is going to be needed. Use MethodGroupExpr.
13205 (NewDelegate.Emit): Remove, DelegateCreation implements this.
13207 * expression.cs: For pointer arith., make sure to use
13208 the size of the type, not the size of the pointer to
13211 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13214 * class.cs (Class): Added error CS0502 test.
13216 2004-08-03 John Luke <jluke@cfl.rr.com>
13217 Raja R Harinath <rharinath@novell.com>
13220 * attribute.cs (Attribute.complained_before): New flag.
13221 (Attribute.ResolveType, Attribute.Resolve),
13222 (Attribute.DefinePInvokeMethod): Set it.
13223 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
13225 2004-08-03 Martin Baulig <martin@ximian.com>
13227 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
13228 use a user-defined operator; we still need to do numeric
13229 promotions in case one argument is a builtin type and the other
13230 one has an implicit conversion to that type. Fixes #62322.
13232 2004-08-02 Martin Baulig <martin@ximian.com>
13234 * statement.cs (LocalInfo.Flags): Added `IsThis'.
13235 (LocalInfo.IsThis): New public property.
13236 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
13238 2004-08-01 Martin Baulig <martin@ximian.com>
13240 * class.cs (TypeContainer.GetClassBases): Don't set the default
13241 here since we may get called from GetPartialBases().
13242 (TypeContainer.DefineType): If GetClassBases() didn't return a
13243 parent, use the default one.
13245 2004-07-30 Duncan Mak <duncan@ximian.com>
13247 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
13249 2004-07-30 Martin Baulig <martin@ximian.com>
13251 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
13253 * class.cs (SourceMethod): New public class, derive from the
13254 symbol writer's ISourceMethod.
13255 (Method): Use the new symbol writer API.
13257 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
13258 as argument and use the new symbol writer.
13261 (SourceFile): Implement the symbol writer's ISourceFile.
13262 (Location.SymbolDocument): Removed.
13263 (Location.SourceFile): New public property.
13265 * symbolwriter.cs: Use the new symbol writer API.
13267 2004-07-30 Raja R Harinath <rharinath@novell.com>
13269 * Makefile (install-local): Remove. Functionality moved to
13272 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
13274 * Makefile: Install mcs.exe.config file together with mcs.exe.
13275 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
13276 correct runtime version.
13278 2004-07-25 Martin Baulig <martin@ximian.com>
13281 (TypeContainer.RegisterOrder): Removed, this was unused.
13282 (TypeContainer, interface_order): Removed.
13283 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
13284 TypeContainer as argument since we can also be called with a
13285 `PartialContainer' for a partial class/struct/interface.
13286 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
13287 of checking whether we're an `Interface' - we could be a
13288 `PartialContainer'.
13289 (PartialContainer.Register): Override; call
13290 AddClass()/AddStruct()/AddInterface() on our parent.
13292 * cs-parser.jay (interface_member_declaration): Add things to the
13293 `current_container', not the `current_class'.
13295 * rootcontext.cs (RegisterOrder): The overloaded version which
13296 takes an `Interface' was unused, removed.
13298 * typemanager.cs (TypeManager.LookupInterface): Return a
13299 `TypeContainer', not an `Interface'.
13300 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
13301 contain a `PartialContainer' for an interface, so check it's
13302 `Kind' to figure out what it is.
13304 2004-07-25 Martin Baulig <martin@ximian.com>
13306 * class.cs (Class.DefaultTypeAttributes): New public constant.
13307 (Struct.DefaultTypeAttributes): Likewise.
13308 (Interface.DefaultTypeAttributes): Likewise.
13309 (PartialContainer.TypeAttr): Override this and add the
13310 DefaultTypeAttributes.
13312 2004-07-25 Martin Baulig <martin@ximian.com>
13314 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
13315 we can just use the `Parent' field instead.
13317 2004-07-25 Martin Baulig <martin@ximian.com>
13319 * class.cs (TypeContainer.Emit): Renamed to EmitType().
13321 2004-07-25 Martin Baulig <martin@ximian.com>
13323 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
13324 our parts before defining any methods.
13325 (TypeContainer.VerifyImplements): Make this virtual.
13326 (ClassPart.VerifyImplements): Override and call VerifyImplements()
13327 on our PartialContainer.
13329 2004-07-25 Martin Baulig <martin@ximian.com>
13331 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
13333 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
13334 argument, we can just use the `Parent' field instead.
13337 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
13338 (MemberBase.DoDefine): Likewise.
13340 2004-07-24 Martin Baulig <martin@ximian.com>
13342 * decl.cs (MemberCore.Parent): New public field.
13343 (DeclSpace.Parent): Moved to MemberCore.
13345 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
13346 (MemberBase.ctor): Added TypeContainer argument, pass it to our
13348 (FieldBase, Field, Operator): Likewise.
13349 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
13350 (EventField, Event): Likewise.
13352 2004-07-23 Martin Baulig <martin@ximian.com>
13354 * class.cs (PartialContainer): New public class.
13355 (ClassPart): New public class.
13356 (TypeContainer): Added support for partial classes.
13357 (TypeContainer.GetClassBases): Splitted some of the functionality
13358 out into GetNormalBases() and GetPartialBases().
13360 * cs-tokenizer.cs (Token.PARTIAL): New token.
13361 (Tokenizer.consume_identifier): Added some hacks to recognize
13362 `partial', but only if it's immediately followed by `class',
13363 `struct' or `interface'.
13365 * cs-parser.jay: Added support for partial clases.
13367 2004-07-23 Martin Baulig <martin@ximian.com>
13369 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
13370 a `DeclSpace' and also made it readonly.
13371 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
13372 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
13373 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
13375 * cs-parser.jay: Pass the `current_class', not the
13376 `current_container' (at the moment, this is still the same thing)
13377 to a new Method, Property, Event, Indexer or Constructor.
13379 2004-07-23 Martin Baulig <martin@ximian.com>
13381 * cs-parser.jay (CSharpParser): Added a new `current_class' field
13382 and removed the `current_interface' one.
13383 (struct_declaration, class_declaration, interface_declaration):
13384 Set `current_class' to the newly created class/struct/interface;
13385 set their `Bases' and call Register() before parsing their body.
13387 2004-07-23 Martin Baulig <martin@ximian.com>
13389 * class.cs (Kind): New public enum.
13390 (TypeContainer): Made this class abstract.
13391 (TypeContainer.Kind): New public readonly field.
13392 (TypeContainer.CheckDef): New public method; moved here from
13394 (TypeContainer.Register): New public abstract method.
13395 (TypeContainer.GetPendingImplementations): New public abstract
13397 (TypeContainer.GetClassBases): Removed the `is_class' and
13398 `is_iface' parameters.
13399 (TypeContainer.DefineNestedTypes): Formerly known as
13401 (ClassOrStruct): Made this class abstract.
13403 * tree.cs (RootTypes): New public type.
13405 2004-07-20 Martin Baulig <martin@ximian.com>
13407 * tree.cs (Tree.RecordNamespace): Removed.
13408 (Tree.Namespaces): Removed.
13410 * rootcontext.cs (RootContext.IsNamespace): Removed.
13412 * cs-parser.jay (namespace_declaration): Just create a new
13413 NamespaceEntry here.
13415 2004-07-20 Martin Baulig <martin@ximian.com>
13417 * statement.cs (ExceptionStatement): New abstract class. This is
13418 now used as a base class for everyone who's using `finally'.
13419 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
13420 our local variables before using them.
13422 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
13423 virtual method. This is used by Yield.Resolve() to "steal" an
13424 outer block's `finally' clauses.
13425 (FlowBranchingException): The .ctor now takes an ExceptionStatement
13428 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
13429 version which takes an ExceptionStatement. This version must be
13430 used to create exception branchings.
13433 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
13434 (Iterator.EmitMoveNext): Added exception support; protect the
13435 block with a `fault' clause, properly handle 'finally' clauses.
13436 (Iterator.EmitDispose): Run all the `finally' clauses here.
13438 2004-07-20 Martin Baulig <martin@ximian.com>
13440 * iterator.cs: This is the first of a set of changes in the
13441 iterator code. Match the spec more closely: if we're an
13442 IEnumerable, then GetEnumerator() must be called. The first time
13443 GetEnumerator() is called, it returns the current instance; all
13444 subsequent invocations (if any) must create a copy.
13446 2004-07-19 Miguel de Icaza <miguel@ximian.com>
13448 * expression.cs: Resolve the constant expression before returning
13451 2004-07-19 Martin Baulig <martin@ximian.com>
13453 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
13454 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
13455 the return type of the new EmitContext.
13457 2004-07-18 Martin Baulig <martin@ximian.com>
13459 * class.cs (Property.Define): Fix iterators.
13461 * iterators.cs (Iterator.Define): Moved the
13462 `container.AddInterator (this)' call here from the .ctor; only do
13463 it if we resolved successfully.
13465 2004-07-17 Miguel de Icaza <miguel@ximian.com>
13467 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
13468 `true' for preprocessing directives that we parse. The return
13469 value indicates whether we should return to regular tokenizing or
13470 not, not whether it was parsed successfully.
13472 In the past if we were in: #if false ... #line #endif, we would
13473 resume parsing after `#line'. See bug 61604.
13475 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
13476 building: IsEnumType should return true only for enums, not for
13477 enums or System.Enum itself. This fixes #61593.
13479 Likely what happened is that corlib was wrong: mcs depended on
13480 this bug in some places. The bug got fixed, we had to add the
13481 hack, which caused bug 61593.
13483 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
13484 that was a workaround for the older conditions.
13486 2004-07-16 Ben Maurer <bmaurer@ximian.com>
13488 * assign.cs: IAssignMethod has a new interface, as documented
13489 inline. All assignment code now uses this new api.
13491 * ecore.cs, expression.cs: All classes which implement
13492 IAssignMethod now use the new interface.
13494 * expression.cs (Invocation): add a hack to EmitCall so that
13495 IndexerAccess can be the target of a compound assignment without
13496 evaluating its arguments twice.
13498 * statement.cs: Handle changes in Invocation api.
13500 2004-07-16 Martin Baulig <martin@ximian.com>
13502 * iterators.cs: Rewrote this. We're now using one single Proxy
13503 class for both the IEnumerable and the IEnumerator interface and
13504 `Iterator' derives from Class so we can use the high-level API.
13506 * class.cs (TypeContainer.AddIterator): New method.
13507 (TypeContainer.DoDefineType): New protected virtual method, which
13508 is called from DefineType().
13509 (TypeContainer.DoDefineMembers): Call DefineType() and
13510 DefineMembers() on all our iterators.
13511 (TypeContainer.Emit): Call Emit() on all our iterators.
13512 (TypeContainer.CloseType): Call CloseType() on all our iterators.
13514 * codegen.cs (EmitContext.CurrentIterator): New public field.
13516 2004-07-15 Martin Baulig <martin@ximian.com>
13519 (TypeManager.not_supported_exception_type): New type.
13521 2004-07-14 Martin Baulig <martin@ximian.com>
13523 * iterators.cs: Use real error numbers.
13525 2004-07-14 Martin Baulig <martin@ximian.com>
13527 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
13528 requires this to be a System.Collection.IEnumerable and not a
13529 class implementing that interface.
13530 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
13532 2004-07-13 Marek Safar <marek.safar@seznam.cz>
13534 * class.cs: Fixed previous fix, it broke some error tests.
13536 2004-07-12 Martin Baulig <martin@ximian.com>
13538 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
13541 2004-07-09 Miguel de Icaza <miguel@ximian.com>
13543 * assign.cs (LocalTemporary): Add new argument: is_address,If
13544 `is_address' is true, then the value that we store is the address
13545 to the real value, and not the value itself.
13547 * ecore.cs (PropertyExpr): use the new local temporary
13548 stuff to allow us to handle X.Y += z (where X is a struct)
13550 2004-07-08 Martin Baulig <martin@ximian.com>
13552 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
13553 not always return, just like we're doing in Using.Resolve().
13555 2004-07-07 Miguel de Icaza <miguel@ximian.com>
13557 * cs-parser.jay (fixed_statement): flag this as Pinned.
13559 2004-07-06 Miguel de Icaza <miguel@ximian.com>
13561 * typemanager.cs (TypeManager): Removed MakePinned method, this
13562 mechanism is replaced with the .NET 2.x compatible mechanism of
13563 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
13565 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
13566 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
13567 `IsFixed' property which has a different meaning.
13569 2004-07-02 Raja R Harinath <rharinath@novell.com>
13571 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
13572 visible from inside a nested class, not just the names of the
13573 immediately enclosing class.
13574 Fix for bug #60730.
13576 2004-06-24 Raja R Harinath <rharinath@novell.com>
13578 * expression.cs (BetterConversion): Remove buggy special-case
13579 handling of "implicit constant expression conversions". At this
13580 point, we already know that the conversion is possible -- we're
13581 only checking to see which is better.
13583 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13585 * cs-parser.jay: Added error CS0210 test.
13587 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13589 * cs-parser.jay: Added error CS0134 test.
13591 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13594 * cs-parser.jay: Added error CS0145 test.
13596 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13598 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
13600 2004-06-23 Ben Maurer <bmaurer@ximian.com>
13602 * expression.cs (StackAlloc.Resolve): The argument may not
13603 be a constant; deal with this case.
13605 2004-06-23 Marek Safar <marek.safar@seznam.cz>
13607 * attribute.cs (IndexerName_GetIndexerName): Renamed to
13608 GetIndexerAttributeValue.
13609 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
13611 * class.cs (Indexer.Define): Added error tests for CS0415,
13614 2004-06-23 Miguel de Icaza <miguel@ximian.com>
13616 * attribute.cs (Attribute.Resolve): Keep field code in sync with
13619 2004-06-23 Martin Baulig <martin@ximian.com>
13621 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
13622 neither return nor throw, reset the barrier as well. Fixes #60457.
13624 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
13626 * class.cs : EventAttributes is now set to None by default.
13627 This fixes bug #60459.
13629 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13632 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
13633 Don't throw exception but return null (it's sufficient now).
13635 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13637 * typemanager.cs (GetArgumentTypes): Faster implementation.
13639 2004-06-18 Martin Baulig <martin@ximian.com>
13641 * attribute.cs (Attribute.Resolve): Check whether we're an
13642 EmptyCast which a Constant child. Fixes #60333.
13644 2004-06-17 Ben Maurer <bmaurer@ximian.com>
13646 * statement.cs (EmitCollectionForeach): Account for the fact that
13647 not all valuetypes are in areas which we can take the address of.
13648 For these variables, we store to a temporary variable. Also, make
13649 sure that we dont emit a `callvirt' on a valuetype method.
13651 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13653 * expression.cs (StackAlloc.DoReSolve): Added test for
13654 negative parameter (CS0247).
13656 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13659 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
13661 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13664 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
13667 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13669 Fix bug #58254 & cs1555.cs, cs1556.cs
13670 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
13672 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13674 * cs-parser.jay: Added error CS1669 test for indexers.
13676 2004-06-11 Martin Baulig <martin@ximian.com>
13678 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
13679 call this twice: for params and varargs methods.
13681 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13684 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
13686 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13688 * attribute.cs (Attribute.GetValidTargets): Made public.
13691 (AbstractPropertyEventMethod): New class for better code sharing.
13692 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
13694 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
13696 2004-06-11 Raja R Harinath <rharinath@novell.com>
13699 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
13700 that the call to Resolve is part of a MemberAccess.
13701 (Expression.Resolve): Use it for SimpleName resolution.
13702 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
13703 Add 'intermediate' boolean argument.
13704 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
13705 error message when the SimpleName can be resolved ambiguously
13706 between an expression and a type.
13707 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
13709 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
13710 call on the left-side.
13712 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13715 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
13717 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13719 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
13721 2004-06-11 Martin Baulig <martin@ximian.com>
13723 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
13724 varargs methods if applicable.
13726 2004-06-11 Martin Baulig <martin@ximian.com>
13728 * expression.cs (Invocation.EmitCall): Don't use
13729 `method.CallingConvention == CallingConventions.VarArgs' since the
13730 method could also have `CallingConventions.HasThis'.
13732 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13734 * class.cs (Event.GetSignatureForError): Implemented.
13735 Fixed crash in error test cs3010.cs
13737 2004-06-10 Miguel de Icaza <miguel@ximian.com>
13739 * cs-tokenizer.cs: Change the way we track __arglist to be
13740 consistent with the other keywords.
13742 2004-06-09 Miguel de Icaza <miguel@ximian.com>
13744 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
13747 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
13749 * codegen.cs: Check that all referenced assemblies have a strongname
13750 before strongnaming the compiled assembly. If not report error CS1577.
13751 Fix bug #56563. Patch by Jackson Harper.
13752 * typemanager.cs: Added a method to return all referenced assemblies.
13753 Fix bug #56563. Patch by Jackson Harper.
13755 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13758 (Method.ApplyAttributeBuilder): Moved and added conditional
13759 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
13762 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
13764 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13767 * class.cs: (EventField.attribute_targets): Changed default target.
13769 2004-06-08 Martin Baulig <martin@ximian.com>
13771 * expression.cs (Invocation.EmitCall): Enable varargs methods.
13773 2004-06-08 Martin Baulig <martin@ximian.com>
13775 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
13777 2004-06-07 Martin Baulig <martin@ximian.com>
13779 Added support for varargs methods.
13781 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
13784 * cs-parser.jay: Added support for `__arglist'.
13786 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
13788 * expression.cs (Argument.AType): Added `ArgList'.
13789 (Invocation): Added support for varargs methods.
13790 (ArglistAccess): New public class.
13791 (Arglist): New public class.
13793 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
13795 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
13796 a method's top-level block if the method has varargs.
13798 * support.cs (ReflectionParameters, InternalParameters): Added
13799 support for varargs methods.
13801 2004-06-07 Miguel de Icaza <miguel@ximian.com>
13803 * class.cs: Provide location in indexer error report.
13805 * driver.cs: Use standard names.
13807 * namespace.cs: Catch the use of using after a namespace has been
13808 declared also on using aliases.
13810 2004-06-03 Raja R Harinath <rharinath@novell.com>
13813 * typemanager.cs (closure_private_ok, closure_invocation_type)
13814 (closure_qualifier_type, closure_invocation_assembly)
13815 (FilterWithClosure): Move to ...
13816 (Closure): New internal nested class.
13817 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
13818 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
13819 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
13820 (MemberLookup, MemberLookupFailed): Use it.
13821 * expression.cs (New.DoResolve): Treat the lookup for the
13822 constructor as being qualified by the 'new'ed type.
13823 (Indexers.GetIndexersForTypeOrInterface): Update.
13825 2004-06-03 Marek Safar <marek.safar@seznam.cz>
13828 (GetConditionalAttributeValue): New method. Returns
13829 condition of ConditionalAttribute.
13830 (SearchMulti): New method. Returns all attributes of type 't'.
13831 Use it when attribute is AllowMultiple = true.
13832 (IsConditionalMethodExcluded): New method.
13835 (Method.IsExcluded): Implemented. Returns true if method has conditional
13836 attribute and the conditions is not defined (method is excluded).
13837 (IMethodData): Extended interface for ConditionalAttribute support.
13838 (PropertyMethod.IsExcluded): Implemented.
13841 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
13844 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
13847 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
13849 * expression.cs (ArrayCreationExpression): Make this just an
13850 `expression'. It can't be a statement, so the code here was
13853 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13856 * typemanager.cs (GetFullNameSignature): New method for
13859 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13862 * class.cs (MemberBase.GetSignatureForError): New virtual method.
13863 Use this method when MethodBuilder is null.
13864 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
13865 Added test for error CS0626 (MONO reports error for this situation).
13866 (IMethodData.GetSignatureForError): Extended interface.
13868 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13871 (AttributeTester.GetObsoleteAttribute): Returns instance of
13872 ObsoleteAttribute when type is obsolete.
13875 (TypeContainer.VerifyObsoleteAttribute): Override.
13876 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
13877 (MethodCode.VerifyObsoleteAttribute): Override.
13878 (MemberBase.VerifyObsoleteAttribute): Override.
13881 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
13882 and report proper error.
13885 Delegate.VerifyObsoleteAttribute): Override.
13888 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
13889 and report proper error.
13890 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
13893 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
13897 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
13898 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
13899 Added test for ObsoleteAttribute.
13902 (Catch): Derived from Statement.
13904 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13906 Fixed bug #59071 & cs0160.cs
13908 * statement.cs (Try.Resolve): Check here whether order of catch
13909 clauses matches their dependencies.
13911 2004-05-31 Miguel de Icaza <miguel@ximian.com>
13913 * Reverted patch to namespace.cs (Use lookuptypedirect). This
13914 caused a regression: #59343. Referencing nested classes from an
13915 assembly stopped working.
13917 2004-05-31 Martin Baulig <martin@ximian.com>
13919 MCS is now frozen for beta 2.
13921 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13923 * convert.cs: add a trivial cache for overload operator resolution.
13925 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13927 * decl.cs: If possible, use lookuptypedirect here. We can only do
13928 this if there is no `.' after the namespace. Avoids using
13929 LookupType, which does lots of slow processing.
13930 (FindNestedType) New method, does what it says :-).
13931 * namespace.cs: use LookupTypeDirect.
13932 * rootcontext.cs: use membercache, if possible.
13933 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
13935 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13938 According to the spec,
13940 In a member access of the form E.I, if E is a single identifier,
13941 and if the meaning of E as a simple-name (§7.5.2) is a constant,
13942 field, property, localvariable, or parameter with the same type as
13943 the meaning of E as a type-name (§3.8), then both possible
13944 meanings of E are permitted.
13946 We did not check that E as a simple-name had the same type as E as
13949 This trivial check gives us 5-7% on bootstrap time.
13951 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13953 * expression.cs (Invocation.OverloadResolve): Avoid the
13954 use of hashtables and boxing here by allocating on demand.
13956 2004-05-30 Martin Baulig <martin@ximian.com>
13958 * rootcontext.cs (RootContext.LookupType): Don't cache things if
13959 we're doing a silent lookup. Don't try to lookup nested types in
13960 TypeManager.object_type (thanks to Ben Maurer).
13962 2004-05-30 Martin Baulig <martin@ximian.com>
13964 Committing a patch from Ben Maurer.
13966 * rootcontext.cs (RootContext.LookupType): Cache negative results.
13968 2004-05-29 Martin Baulig <martin@ximian.com>
13970 * class.cs (IMethodData.ShouldIgnore): New method.
13972 * typemanager.cs (TypeManager.MethodFlags): Don't take a
13973 `Location' argument, we don't need it anywhere. Use
13974 `IMethodData.ShouldIgnore ()' instead of
13975 `MethodData.GetMethodFlags ()'.
13976 (TypeManager.AddMethod): Removed.
13977 (TypeManager.AddMethod2): Renamed to AddMethod.
13979 2004-05-29 Martin Baulig <martin@ximian.com>
13981 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
13983 * convert.cs (Convert.ImplicitReferenceConversion): If we're
13984 converting from a class type S to an interface type and we already
13985 have an object on the stack, don't box it again. Fixes #52578.
13987 2004-05-29 Martin Baulig <martin@ximian.com>
13989 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
13990 Added support for `params' parameters. Fixes #59267.
13992 2004-05-29 Martin Baulig <martin@ximian.com>
13994 * literal.cs (NullPointer): Provide a private .ctor which sets
13995 `type' to TypeManager.object_type. Fixes #59048.
13997 2004-05-29 Martin Baulig <martin@ximian.com>
13999 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
14000 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
14002 * ecore.cs (EventExpr.instance_expr): Make the field private.
14004 2004-05-26 Marek Safar <marek.safar@seznam.cz>
14006 Fixed bug #50080 & cs0214-2.cs
14007 * expression.cs (Cast.DoResolve): Check unsafe context here.
14009 * statement.cs (Resolve.DoResolve): Likewise.
14011 2004-05-26 Martin Baulig <martin@ximian.com>
14013 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
14015 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
14016 (RootContext.LookupType): Pass down the `silent' flag.
14018 2004-05-25 Martin Baulig <martin@ximian.com>
14021 (MethodGroupExpr.IdenticalTypeName): New public property.
14022 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
14023 expression actually refers to a type.
14025 2004-05-25 Martin Baulig <martin@ximian.com>
14027 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
14028 for #56176 and made it actually work.
14030 2004-05-25 Martin Baulig <martin@ximian.com>
14032 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
14033 (FieldExpr, PropertyExpr): Override and implement
14034 CacheTemporaries. Fixes #52279.
14036 2004-05-25 Miguel de Icaza <miguel@ximian.com>
14038 * location.cs: In the new compiler listing a file twice is a
14039 warning, not an error.
14041 2004-05-24 Martin Baulig <martin@ximian.com>
14043 * enum.cs (Enum.DefineType): For the `BaseType' to be a
14044 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
14046 2004-05-24 Martin Baulig <martin@ximian.com>
14048 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
14049 walking the `using' list. Fixes #53921.
14051 2004-05-24 Martin Baulig <martin@ximian.com>
14053 * const.cs (Const.LookupConstantValue): Added support for
14054 EmptyCast's; fixes #55251.
14056 2004-05-24 Martin Baulig <martin@ximian.com>
14058 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
14059 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
14060 which does the CS0135 check. The reason is that we first need to
14061 check whether the variable actually exists.
14063 2004-05-24 Martin Baulig <martin@ximian.com>
14065 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
14066 than RootContext.LookupType() to find the explicit interface
14067 type. Fixes #58584.
14069 2004-05-24 Raja R Harinath <rharinath@novell.com>
14071 * Makefile: Simplify. Use executable.make.
14072 * mcs.exe.sources: New file. List of sources of mcs.exe.
14074 2004-05-24 Anders Carlsson <andersca@gnome.org>
14078 Use the invariant culture when doing String.Compare for CLS case
14081 2004-05-23 Martin Baulig <martin@ximian.com>
14083 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
14084 don't have any dots. Fixes #52622, added cs0246-8.cs.
14086 * namespace.cs (NamespaceEntry.Lookup): Likewise.
14088 2004-05-23 Marek Safar <marek.safar@seznam.cz>
14090 * class.cs (MemberBase.Define): Reuse MemberType member for
14091 resolved type. Other methods can use it too.
14093 2004-05-23 Martin Baulig <martin@ximian.com>
14095 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
14096 the variable also exists in the current block (otherwise, we need
14097 to report a CS0103). Fixes #58670.
14099 2004-05-23 Martin Baulig <martin@ximian.com>
14101 * flowanalysis.cs (Reachability.Reachable): Compute this
14102 on-the-fly rather than storing it as a field.
14104 2004-05-23 Martin Baulig <martin@ximian.com>
14106 * flowanalysis.cs (Reachability.And): Manually compute the
14107 resulting `barrier' from the reachability.
14109 2004-05-23 Marek Safar <marek.safar@seznam.cz>
14112 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
14113 instance of ObsoleteAttribute when symbol is obsolete.
14116 (IMethodData): Extended interface for ObsoleteAttribute support.
14118 2004-05-22 Marek Safar <marek.safar@seznam.cz>
14120 * attribute.cs: Fix bug #55970
14122 2004-05-22 Marek Safar <marek.safar@seznam.cz>
14126 (GetObsoleteAttribute): New method. Creates the instance of
14128 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
14129 ObsoleteAttribute when member is obsolete.
14130 (AttributeTester.Report_ObsoleteMessage): Common method for
14131 Obsolete error/warning reporting.
14134 (TypeContainer.base_classs_type): New member for storing parent type.
14137 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
14138 for this MemberCore.
14140 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14142 * attribute.cs, const.cs: Fix bug #58590
14144 2004-05-21 Martin Baulig <martin@ximian.com>
14146 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
14147 out parameters if the end of the method is unreachable. Fixes
14150 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14152 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
14153 Hari was right, why extra method.
14155 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14157 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
14159 2004-05-20 Martin Baulig <martin@ximian.com>
14161 Merged this back from gmcs to keep the differences to a minumum.
14163 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
14164 instead of a Declspace.
14165 (Attribute.ResolveType): Likewise.
14166 (Attributes.Search): Likewise.
14167 (Attributes.Contains): Likewise.
14168 (Attributes.GetClsCompliantAttribute): Likewise.
14170 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
14172 (MethodData.ApplyAttributes): Take an EmitContext instead of a
14175 2004-05-19 Marek Safar <marek.safar@seznam.cz>
14177 Fix bug #58688 (MCS does not report error when the same attribute
14180 * attribute.cs (Attribute.Emit): Distinction between null and default.
14182 2004-05-19 Raja R Harinath <rharinath@novell.com>
14184 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
14185 of a top-level attribute without an attribute target.
14186 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
14188 (Attribute.Conditional_GetConditionName),
14189 (Attribute.Obsolete_GetObsoleteMessage): Update.
14190 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
14191 part of ScanForIndexerName.
14192 (Attribute.CanIgnoreInvalidAttribute): New function.
14193 (Attribute.ScanForIndexerName): Move to ...
14194 (Attributes.ScanForIndexerName): ... here.
14195 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
14196 (Attributes.Search): New internal variant that can choose not to
14197 complain if types aren't resolved. The original signature now
14199 (Attributes.GetClsCompliantAttribute): Use internal variant, with
14200 complaints suppressed.
14201 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
14202 only if it not useful.
14203 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
14204 top-level for attributes that are shared between the assembly
14205 and a top-level class.
14206 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
14207 * class.cs: Update to reflect changes.
14208 (DefineIndexers): Fuse loops.
14209 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
14210 a couple more variants of attribute names.
14212 2004-05-18 Marek Safar <marek.safar@seznam.cz>
14214 Fix bug #52585 (Implemented explicit attribute declaration)
14217 (Attributable.ValidAttributeTargets): New abstract method. It gets
14218 list of valid attribute targets for explicit target declaration.
14219 (Attribute.Target): It holds target itself.
14220 (AttributeSection): Removed.
14221 (Attribute.CheckTargets): New method. It checks whether attribute
14222 target is valid for the current element.
14225 (EventProperty): New class. For events that are declared like
14226 property (with add and remove accessors).
14227 (EventField): New class. For events that are declared like field.
14230 * cs-parser.jay: Implemented explicit attribute target declaration.
14232 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
14233 Override ValidAttributeTargets.
14236 (ReturnParameter): Class for applying custom attributes on
14238 (ParameterAtribute): New class. Class for applying custom
14239 attributes on the parameter type.
14241 2004-05-17 Miguel de Icaza <miguel@ximian.com>
14243 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
14246 (Method): Allow UNSAFE here.
14248 * modifiers.cs: Support unsafe reporting.
14250 2004-05-17 Marek Safar <marek.safar@seznam.cz>
14252 * decl.cs: Fix bug #58478.
14254 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14256 * statement.cs: When checking for unreachable code on an EmptyStatement,
14257 set the location. Fixes bug #58488.
14259 2004-05-13 Miguel de Icaza <miguel@ximian.com>
14261 * driver.cs: Add -pkg handling.
14263 From Gonzalo: UseShelLExecute=false
14265 2004-05-12 Marek Safar <marek.safar@seznam.cz>
14268 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
14270 (Attribute.IsClsCompliaceRequired): Moved to base for better
14272 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
14273 when attribute is AttributeUsageAttribute.
14274 (Attribute.GetValidTargets): Simplified.
14275 (Attribute.GetAttributeUsage): New method returns AttributeUsage
14276 attribute for this type.
14277 (Attribute.ApplyAttributes): Method renamed to Emit and make
14279 (GlobalAttributeSection): New class for special handling of global
14280 attributes (assembly, module).
14281 (AttributeSection.Emit): New method.
14283 * class.cs: Implemented Attributable abstract methods.
14284 (MethodCore.LabelParameters): Moved to Parameter class.
14285 (Accessor): Is back simple class.
14286 (PropertyMethod): Implemented Attributable abstract class.
14287 (DelegateMethod): Implemented Attributable abstract class.
14288 (Event): New constructor for disctintion between normal Event
14289 and Event with accessors.
14291 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
14293 * codegen.cs, const.cs, decl.cs, delegate.cs:
14294 (CommonAssemblyModulClass): Implemented Attributable abstract class
14297 * enum.cs: Implement IAttributeSupport interface.
14298 (EnumMember): New class for emum members. Implemented Attributable
14302 (ParameterBase): Is abstract.
14303 (ReturnParameter): New class for easier [return:] attribute handling.
14305 * typemanager.cs: Removed builder_to_attr.
14307 2004-05-11 Raja R Harinath <rharinath@novell.com>
14310 * attribute.cs (Attribute.GetPositionalValue): New function.
14311 * class.cs (TypeContainer.VerifyMembers): New function.
14312 (TypeContainer.Emit): Use it.
14313 (ClassOrStruct): New base class for Class and Struct.
14314 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
14315 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
14317 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
14318 then each non-static field should have a FieldOffset attribute.
14319 Otherwise, none of the fields should have a FieldOffset attribute.
14320 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
14321 and FieldOffset attributes.
14322 * typemanager.cs (TypeManager.struct_layout_attribute_type)
14323 (TypeManager.field_offset_attribute_type): New core types.
14324 (TypeManager.InitCoreTypes): Initialize them.
14326 2004-05-11 Michal Moskal <malekith@pld-linux.org>
14328 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
14329 Return correct type.
14332 2004-05-09 Miguel de Icaza <miguel@ximian.com>
14334 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
14335 be implicitly converted to ulong.
14337 * expression.cs: The logic for allowing operator &, | and ^ worked
14338 was wrong, it worked before because we did not report an error in
14339 an else branch. Fixes 57895.
14341 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
14342 allow volatile fields to be reference types.
14344 2004-05-07 Miguel de Icaza <miguel@ximian.com>
14346 * driver.cs: Add support for /debug-
14348 2004-05-07 Raja R Harinath <rharinath@novell.com>
14350 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
14351 Add a 'complain' parameter to silence errors.
14352 (Attribute.Resolve): Update to changes. Put in sanity check to catch
14353 silently overlooked type-resolutions.
14354 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
14355 to reflect changes.
14356 (Attributes.Search): New function.
14357 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
14358 (Attributes.GetAttributeFullName): Remove hack.
14359 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
14360 Update to reflect changes.
14361 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14362 Use Attributes.Search instead of nested loops.
14364 2004-05-07 Marek Safar <marek.safar@seznam.cz>
14367 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
14368 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
14369 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
14371 * report.cs: (Report.Warning): Renamed to Warning_T because of
14372 parameter collision.
14374 2004-05-05 Raja R Harinath <rharinath@novell.com>
14376 * expression.cs (MemberAccess.ResolveMemberAccess):
14377 Exit with non-zero status after Report.Error.
14378 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
14380 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
14382 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14384 * support.cs: Don't hang when the file is empty.
14386 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14388 * support.cs: In SeekableStreamReader, compute the preamble size of the
14389 underlying stream. Position changes should take into account that initial
14392 2004-05-03 Todd Berman <tberman@sevenl.net>
14394 * driver.cs: remove unused GetSysVersion function.
14396 2004-05-03 Todd Berman <tberman@sevenl.net>
14398 * driver.cs: Remove the hack from saturday, as well as the hack
14399 from jackson (LoadAssemblyFromGac), also adds the CWD to the
14400 link_paths to get that bit proper.
14402 2004-05-01 Todd Berman <tberman@sevenl.net>
14404 * driver.cs: Try a LoadFrom before a Load, this checks the current
14405 path. This is currently a bug in mono that is be fixed, however, this
14406 provides a workaround for now. This will be removed when the bug
14409 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
14411 * CryptoConvert.cs: Updated to latest version. Fix issue with
14412 incomplete key pairs (#57941).
14414 2004-05-01 Todd Berman <tberman@sevenl.net>
14416 * driver.cs: Remove '.' from path_chars, now System.* loads properly
14419 2004-04-30 Jackson Harper <jackson@ximian.com>
14421 * codegen.cs: Open keys readonly.
14423 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14425 * typemanager.cs: don't report cyclic struct layout when a struct
14426 contains 2 or more fields of the same type. Failed for Pango.AttrShape
14427 which has 2 Pango.Rectangle fields.
14429 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
14431 * expression.cs: Handle IntPtr comparisons with IL code
14432 rather than a method call.
14434 2004-04-29 Martin Baulig <martin@ximian.com>
14436 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
14437 the list of PropertyInfo's in class hierarchy and find the
14438 accessor. Fixes #56013.
14440 2004-04-29 Martin Baulig <martin@ximian.com>
14442 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
14444 2004-04-29 Martin Baulig <martin@ximian.com>
14446 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14448 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
14450 2004-04-29 Martin Baulig <martin@ximian.com>
14452 * class.cs (ConstructorInitializer.Resolve): Check whether the
14453 parent .ctor is accessible. Fixes #52146.
14455 2004-04-29 Martin Baulig <martin@ximian.com>
14457 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14459 * statement.cs (Using.EmitLocalVariableDecls): Use
14460 TypeManager.idisposable_type, not typeof (IDisposable).
14461 (Foreach.EmitCollectionForeach): Added support for valuetypes.
14463 2004-04-29 Martin Baulig <martin@ximian.com>
14465 * class.cs (Event.Define): Don't emit the field and don't set
14466 RTSpecialName and SpecialName for events on interfaces. Fixes
14469 2004-04-29 Raja R Harinath <rharinath@novell.com>
14471 Refactor Attribute.ApplyAttributes.
14472 * attribute.cs (Attributable): New base class for objects that can
14473 have Attributes applied on them.
14474 (Attribute): Make AttributeUsage fields public.
14475 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
14476 (Attribute.IsInternalCall): New property.
14477 (Attribute.UsageAttr): Convert to a public read-only property.
14478 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
14479 (Attribute.ResolveType, Attribute.Resolve)
14480 (Attribute.ScanForIndexerName): Update to reflect changes.
14481 (Attribute.CheckAttributeTarget): Re-format.
14482 (Attribute.ApplyAttributes): Refactor, to various
14483 Attributable.ApplyAttributeBuilder methods.
14484 * decl.cs (MemberCore): Make Attributable.
14485 * class.cs (Accessor): Make Attributable.
14486 (MethodData.ApplyAttributes): Use proper attribute types, not
14488 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
14489 (TypeContainer.ApplyAttributeBuilder)
14490 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
14491 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
14492 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
14493 (Operator.ApplyAttributeBuilder): New factored-out methods.
14494 * const.cs (Const.ApplyAttributeBuilder): Likewise.
14495 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
14496 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
14497 * parameter.cs (ParameterBase): New Attributable base class
14498 that can also represent Return types.
14499 (Parameter): Update to the changes.
14501 2004-04-29 Jackson Harper <jackson@ximian.com>
14503 * driver.cs: Prefer the corlib system version when looking for
14504 assemblies in the GAC. This is still a hack, but its a better hack
14507 2004-04-29 Marek Safar <marek.safar@seznam.cz>
14509 * decl.cs, enum.cs: Improved error 3005 reporting.
14511 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
14512 (related_symbols): New private member for list of symbols
14513 related to reported error/warning.
14515 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
14517 2004-04-29 Martin Baulig <martin@ximian.com>
14519 * ecore.cs (Expression.Constantify): If we're an enum and
14520 TypeManager.TypeToCoreType() doesn't give us another type, use
14521 t.UnderlyingSystemType. Fixes #56178.
14523 2004-04-29 Martin Baulig <martin@ximian.com>
14525 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
14526 interfaces and for each interface, only add members directly
14527 declared in that interface. Fixes #53255.
14529 2004-04-28 Martin Baulig <martin@ximian.com>
14531 * expression.cs (ConditionalLogicalOperator): Use a temporary
14532 variable for `left' to avoid that we evaluate it more than once;
14535 2004-04-28 Martin Baulig <martin@ximian.com>
14537 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
14540 2004-04-28 Martin Baulig <martin@ximian.com>
14542 * statement.cs (LocalInfo.Resolve): Check whether the type is not
14545 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
14546 whether the type is not void (CS1547).
14548 2004-04-28 Martin Baulig <martin@ximian.com>
14550 * expression.cs (Unary.DoResolveLValue): Override this and report
14551 CS0131 for anything but Operator.Indirection.
14553 2004-04-28 Martin Baulig <martin@ximian.com>
14555 Committing a patch from Ben Maurer; see bug #50820.
14557 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14560 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14563 2004-04-28 Martin Baulig <martin@ximian.com>
14565 Committing a patch from Ben Maurer; see bug #50820.
14567 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14570 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14573 2004-04-28 Martin Baulig <martin@ximian.com>
14575 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
14576 (Block.AddLabel): Call DoLookupLabel() to only search in the
14579 2004-04-28 Martin Baulig <martin@ximian.com>
14581 * cfold.cs (ConstantFold.BinaryFold): Added special support for
14582 comparing StringConstants and NullLiterals in Equality and Inequality.
14584 2004-04-28 Jackson Harper <jackson@ximian.com>
14586 * driver.cs: Attempt to load referenced assemblies from the
14587 GAC. This is the quick and dirty version of this method that
14588 doesnt take into account versions and just takes the first
14589 canidate found. Will be good enough for now as we will not have more
14590 then one version installed into the GAC until I update this method.
14592 2004-04-28 Martin Baulig <martin@ximian.com>
14594 * typemanager.cs (TypeManager.CheckStructCycles): New public
14595 static method to check for cycles in the struct layout.
14597 * rootcontext.cs (RootContext.PopulateTypes): Call
14598 TypeManager.CheckStructCycles() for each TypeContainer.
14599 [Note: We only need to visit each type once.]
14601 2004-04-28 Martin Baulig <martin@ximian.com>
14603 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
14605 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
14606 success and added `out object value'. Use a `bool resolved' field
14607 to check whether we've already been called rather than
14608 `ConstantValue != null' since this breaks for NullLiterals.
14610 2004-04-28 Raja R Harinath <rharinath@novell.com>
14612 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
14613 setting of this flag, since the 'set' method may be non-public.
14615 2004-04-28 Raja R Harinath <rharinath@novell.com>
14617 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
14618 check on current_vector.Block.
14620 2004-04-27 Martin Baulig <martin@ximian.com>
14622 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
14623 a field initializer. Fixes #56459.
14625 2004-04-27 Martin Baulig <martin@ximian.com>
14627 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
14628 we're not attempting to use an indexer. Fixes #52154.
14630 2004-04-27 Martin Baulig <martin@ximian.com>
14632 * statement.cs (Return): Don't create a return label if we don't
14633 need it; reverts my change from January 20th. Thanks to Ben
14636 2004-04-27 Martin Baulig <martin@ximian.com>
14638 According to the spec, `goto' can only leave a nested scope, but
14641 * statement.cs (Block.LookupLabel): Only lookup in the current
14642 block, don't recurse into parent or child blocks.
14643 (Block.AddLabel): Check in parent and child blocks, report
14644 CS0140/CS0158 if we find a duplicate.
14645 (Block): Removed this indexer for label lookups.
14646 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
14647 this already does the error reporting for us.
14650 (FlowBranching.UsageVector.Block): New public variable; may be null.
14651 (FlowBranching.CreateSibling): Added `Block' argument.
14652 (FlowBranching.LookupLabel): New public virtual method. Lookup a
14653 label for the target of a `goto' and check whether we're not
14654 leaving a `finally'.
14656 2004-04-27 Martin Baulig <martin@ximian.com>
14658 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14659 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
14662 2004-04-27 Martin Baulig <martin@ximian.com>
14664 * statement.cs (Block.AddLabel): Also check for implicit blocks
14665 and added a CS0158 check.
14667 2004-04-27 Martin Baulig <martin@ximian.com>
14669 * flowanalysis.cs (FlowBranchingLoop): New class.
14670 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
14671 UsageVector's instead of an ArrayList.
14672 (FlowBranching.Label): Likewise.
14673 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
14674 (FlowBranching.AddBreakVector): New method.
14676 2004-04-27 Miguel de Icaza <miguel@ximian.com>
14678 * attribute.cs: Small regression fix: only convert the type if we
14679 the type is different, fixes System.Drawing build.
14681 2004-04-27 Martin Baulig <martin@ximian.com>
14683 * attribute.cs (Attribute.Resolve): If we have a constant value
14684 for a named field or property, implicity convert it to the correct
14687 2004-04-27 Raja R Harinath <rharinath@novell.com>
14689 * statement.cs (Block.Block): Implicit blocks share
14690 'child_variable_names' fields with parent blocks.
14691 (Block.AddChildVariableNames): Remove.
14692 (Block.AddVariable): Mark variable as "used by a child block" in
14693 every surrounding block.
14694 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
14695 been used in a child block, complain about violation of "Invariant
14696 meaning in blocks" rule.
14697 * cs-parser.jay (declare_local_variables): Don't use
14698 AddChildVariableNames.
14699 (foreach_statement): Don't create an implicit block: 'foreach'
14700 introduces a scope.
14702 2004-04-23 Miguel de Icaza <miguel@ximian.com>
14704 * convert.cs (ImplicitNumericConversion): 0 is also positive when
14705 converting from 0L to ulong. Fixes 57522.
14707 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14709 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
14710 derived class hides via 'new' keyword field from base class (test-242.cs).
14711 TODO: Handle this in the more general way.
14713 * class.cs (CheckBase): Ditto.
14715 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14717 * decl.cs (caching_flags): New member for storing cached values
14719 (MemberCore.Flags): New enum where bit flags for caching_flags
14721 (MemberCore.cls_compliance): Moved to caching_flags.
14722 (DeclSpace.Created): Moved to caching_flags.
14724 * class.cs: Use caching_flags instead of DeclSpace.Created
14726 2004-04-21 Miguel de Icaza <miguel@ximian.com>
14728 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
14729 if we are only a derived class, not a nested class.
14731 * typemanager.cs: Same as above, but do this at the MemberLookup
14732 level (used by field and methods, properties are handled in
14733 PropertyExpr). Allow for the qualified access if we are a nested
14736 2004-04-21 Marek Safar <marek.safar@seznam.cz>
14738 * class.cs: Refactoring.
14739 (IMethodData): New inteface; Holds links to parent members
14740 to avoid member duplication (reduced memory allocation).
14741 (Method): Implemented IMethodData interface.
14742 (PropertyBase): New inner classes for get/set methods.
14743 (PropertyBase.PropertyMethod): Implemented IMethodData interface
14744 (Event): New inner classes for add/remove methods.
14745 (Event.DelegateMethod): Implemented IMethodData interface.
14747 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
14748 EmitContext (related to class.cs refactoring).
14750 2004-04-21 Raja R Harinath <rharinath@novell.com>
14752 * delegate.cs (Delegate.VerifyApplicability): If the number of
14753 arguments are the same as the number of parameters, first try to
14754 verify applicability ignoring any 'params' modifier on the last
14758 2004-04-16 Raja R Harinath <rharinath@novell.com>
14760 * class.cs (TypeContainer.AddIndexer): Use
14761 'ExplicitInterfaceName' to determine if interface name was
14762 explicitly specified. 'InterfaceType' is not initialized at this time.
14763 (TypeContainer.DefineIndexers): Remove use of temporary list. The
14764 Indexers array is already in the required order. Initialize
14765 'IndexerName' only if there are normal indexers.
14766 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
14767 (TypeContainer.Emit): Emit DefaultMember attribute only if
14768 IndexerName is initialized.
14771 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
14773 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
14776 2004-04-15 Raja R Harinath <rharinath@novell.com>
14778 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
14782 * attribute.cs (Attribute.Resolve): Check for duplicate named
14786 2004-04-15 Miguel de Icaza <miguel@ximian.com>
14788 * iterators.cs (MarkYield): track whether we are in an exception,
14789 and generate code accordingly. Use a temporary value to store the
14790 result for our state.
14792 I had ignored a bit the interaction of try/catch with iterators
14793 since their behavior was not entirely obvious, but now it is
14794 possible to verify that our behavior is the same as MS .NET 2.0
14798 2004-04-14 Miguel de Icaza <miguel@ximian.com>
14800 * iterators.cs: Avoid creating temporaries if there is no work to
14803 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
14804 Enumerations, use TypeManager.EnumToUnderlying and call
14807 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
14810 (This.Emit): Use EmitContext.EmitThis to emit our
14813 (This.EmitAssign): Ditto.
14815 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
14816 codepaths, we will move all the functionality into
14819 (FieldExpr.EmitAssign): Ditto.
14821 This fixes several hidden bugs that I uncovered while doing a code
14822 review of this today.
14824 * codegen.cs (EmitThis): reworked so the semantics are more clear
14825 and also support value types "this" instances.
14827 * iterators.cs: Changed so that for iterators in value types, we
14828 do not pass the value type as a parameter.
14830 Initialization of the enumerator helpers is now done in the caller
14831 instead of passing the parameters to the constructors and having
14832 the constructor set the fields.
14834 The fields have now `assembly' visibility instead of private.
14836 2004-04-11 Miguel de Icaza <miguel@ximian.com>
14838 * expression.cs (Argument.Resolve): Check if fields passed as ref
14839 or out are contained in a MarshalByRefObject.
14841 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
14842 another compiler type.
14844 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
14846 * class.cs (Indexer.Define): use the new name checking method.
14847 Also, return false on an error.
14848 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
14849 (is_identifier_[start/part]_character): make static.
14851 2004-04-10 Miguel de Icaza <miguel@ximian.com>
14853 * expression.cs (Binary.ResolveOperator): Do no append strings
14854 twice: since we can be invoked more than once (array evaluation)
14855 on the same concatenation, take care of this here. Based on a fix
14856 from Ben (bug #56454)
14858 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
14860 * codegen.cs: Fix another case where CS1548 must be reported (when
14861 delay-sign isn't specified and no private is available #56564). Fix
14862 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
14863 error when MCS is used on the MS runtime and we need to delay-sign
14864 (which seems unsupported by AssemblyBuilder - see #56621).
14866 2004-04-08 Marek Safar <marek.safar@seznam.cz>
14868 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
14869 (TypeManager.ComputeNamespaces): Faster implementation for
14872 * compiler.csproj: Updated AssemblyName to mcs.
14874 2004-04-07 Miguel de Icaza <miguel@ximian.com>
14876 * rootcontext.cs: Add new types to the boot resolution.
14878 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
14879 MulticastDelegate is not allowed.
14881 * typemanager.cs: Add new types to lookup: System.TypedReference
14884 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
14885 check for TypedReference or ArgIterator, they are not allowed.
14887 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
14888 makes us properly catch 1510 in some conditions (see bug 56016 for
14891 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
14893 * CryptoConvert.cs: update from corlib version
14896 2004-04-05 Miguel de Icaza <miguel@ximian.com>
14898 * class.cs (Indexer.Define): Check indexername declaration
14900 2004-04-05 Marek Safar <marek.safar@seznam.cz>
14902 * attribute.cs (IsClsCompliant): Fixed problem with handling
14903 all three states (compliant, not-compliant, undetected).
14905 2004-03-30 Marek Safar <marek.safar@seznam.cz>
14907 * attribute.cs (Attribute): Location is now public.
14908 (Resolve): Store resolved arguments (pos_values) in attribute class.
14909 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
14910 (GetClsCompliantAttributeValue): New method that gets
14911 CLSCompliantAttribute value.
14912 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
14913 if exists else null.
14914 (AttributeTester): New class for CLS-Compliant verification routines.
14916 * class.cs (Emit): Add CLS-Compliant verification.
14917 (Method.GetSignatureForError): Implemented.
14918 (Constructor.GetSignatureForError): Implemented
14919 (Constructor.HasCompliantArgs): Returns if constructor has
14920 CLS-Compliant arguments.
14921 (Constructor.Emit): Override.
14922 (Construcor.IsIdentifierClsCompliant): New method; For constructors
14923 is needed to test only parameters.
14924 (FieldBase.GetSignatureForError): Implemented.
14925 (TypeContainer): New member for storing base interfaces.
14926 (TypeContainer.FindMembers): Search in base interfaces too.
14928 * codegen.cs (GetClsComplianceAttribute): New method that gets
14929 assembly or module CLSCompliantAttribute value.
14930 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
14932 (ModuleClass.Emit): Add error 3012 test.
14934 * const.cs (Emit): Override and call base for CLS-Compliant tests.
14936 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
14937 state for all decl types.
14938 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
14939 if CLS-Compliant tests are required.
14940 (IsClsCompliaceRequired): New method. Analyze whether code
14941 must be CLS-Compliant.
14942 (IsExposedFromAssembly): New method. Returns true when MemberCore
14943 is exposed from assembly.
14944 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
14945 value or gets cached value.
14946 (HasClsCompliantAttribute): New method. Returns true if MemberCore
14947 is explicitly marked with CLSCompliantAttribute.
14948 (IsIdentifierClsCompliant): New abstract method. This method is
14949 used to testing error 3005.
14950 (IsIdentifierAndParamClsCompliant): New method. Common helper method
14951 for identifier and parameters CLS-Compliant testing.
14952 (VerifyClsCompliance): New method. The main virtual method for
14953 CLS-Compliant verifications.
14954 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
14955 null. I don't know why is null (too many public members !).
14956 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
14957 and get value of first CLSCompliantAttribute that found.
14959 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
14960 (VerifyClsCompliance): Override and add extra tests.
14962 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
14963 clscheck- disable CLS-Compliant verification event if assembly is has
14964 CLSCompliantAttribute(true).
14966 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
14967 ApllyAttribute is now called in emit section as in the other cases.
14968 Possible future Emit integration.
14969 (IsIdentifierClsCompliant): New override.
14970 (VerifyClsCompliance): New override.
14971 (GetEnumeratorName): Returns full enum name.
14973 * parameter.cs (GetSignatureForError): Implemented.
14975 * report.cs (WarningData): New struct for Warning message information.
14976 (LocationOfPreviousError): New method.
14977 (Warning): New method. Reports warning based on the warning table.
14978 (Error_T): New method. Reports error based on the error table.
14980 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
14981 verifications are done here.
14983 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
14985 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
14986 CLSCompliantAttribute.
14987 (all_imported_types): New member holds all imported types from other
14989 (LoadAllImportedTypes): New method fills static table with exported types
14990 from all referenced assemblies.
14991 (Modules): New property returns all assembly modules.
14993 2004-03-30 Miguel de Icaza <miguel@ximian.com>
14995 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
14996 throwing a parser error.
14998 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
14999 which removes the hardcoded get_/set_ prefixes for properties, as
15000 IL allows for the properties to be named something else.
15004 * expression.cs: Do not override operand before we know if it is
15005 non-null. Fix 56207
15007 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15009 * typemanager.cs: support for pinned variables.
15011 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15013 * decl.cs, typemanager.cs: Avoid using an arraylist
15014 as a buffer if there is only one result set.
15016 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15018 * expression.cs: Make sure you cant call a static method
15019 with an instance expression, bug #56174.
15021 2004-03-29 Miguel de Icaza <miguel@ximian.com>
15023 * class.cs (IsDuplicateImplementation): Improve error reporting to
15024 flag 663 (method only differs in parameter modifier).
15026 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
15027 in preprocessor directives.
15029 * location.cs (LookupFile): Allow for the empty path.
15031 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
15032 better approach for some of that patch, but its failing with the
15033 CharSet enumeration. For now try/catch will do.
15035 * typemanager.cs: Do not crash if a struct does not have fields.
15038 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15040 * expression.cs: cs0213, cant fix a fixed expression.
15043 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15045 * cs-parser.jay: detect invalid embeded statements gracefully.
15048 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15050 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
15053 the invocation type may not be a subclass of the tye of the item/
15054 The type of the item must be a subclass of the invocation item.
15059 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
15061 * attribute.cs: Added methods to get a string and a bool from an
15062 attribute. Required to information from AssemblyKeyFileAttribute,
15063 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
15064 * codegen.cs: Modified AssemblyName creation to include support for
15065 strongnames. Catch additional exceptions to report them as CS1548.
15066 * compiler.csproj: Updated include CryptoConvert.cs.
15067 * compiler.csproj.user: Removed file - user specific configuration.
15068 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
15069 Mono.Security assembly. The original class is maintained and tested in
15070 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
15071 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
15072 like CSC 8.0 (C# v2) supports.
15073 * Makefile: Added CryptoConvert.cs to mcs sources.
15074 * rootcontext.cs: Added new options for strongnames.
15076 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
15078 * driver.cs: For --expect-error, report error code `2'
15079 if the program compiled with no errors, error code `1' if
15080 it compiled with an error other than the one expected.
15082 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
15084 * compiler.csproj: Updated for Visual Studio .NET 2003.
15085 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
15086 * compiler.sln: Updated for Visual Studio .NET 2003.
15088 2004-03-24 Ravi Pratap M <ravi@ximian.com>
15090 * expression.cs: Fix bug #47234. We basically need to apply the
15091 rule that we prefer the conversion of null to a reference type
15092 when faced with a conversion to 'object' (csc behaviour).
15094 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15096 * statement.cs: Shorter form for foreach, eliminates
15097 a local variable. r=Martin.
15099 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15101 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
15102 checks if we can use brtrue/brfalse to test for 0.
15103 * expression.cs: use the above in the test for using brtrue/brfalse.
15104 cleanup code a bit.
15106 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15108 * expression.cs: Rewrite string concat stuff. Benefits:
15110 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
15111 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
15112 rather than a concat chain.
15114 * typemanager.cs: Add lookups for more concat overloads.
15116 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15118 * expression.cs: Emit shorter il code for array init.
15135 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
15137 * statement.cs: Before, two switch blocks would be merged if the
15138 total size of the blocks (end_item - begin_item + 1) was less than
15139 two times the combined sizes of the blocks.
15141 Now, it will only merge if after the merge at least half of the
15146 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
15148 * class.cs : csc build fix for GetMethods(). See bug #52503.
15150 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
15152 * expression.cs: Make sure fp comparisons work with NaN.
15153 This fixes bug #54303. Mig approved this patch a long
15154 time ago, but we were not able to test b/c the runtime
15157 2004-03-19 Miguel de Icaza <miguel@ximian.com>
15159 * ecore.cs (TypExpr.GetHashCode): implement this overload.
15161 2004-03-19 Martin Baulig <martin@ximian.com>
15163 * class.cs (MemberCore.IsDuplicateImplementation): Report the
15164 error here and not in our caller.
15166 2004-03-19 Martin Baulig <martin@ximian.com>
15168 * interface.cs: Completely killed this file.
15169 (Interface): We're now a TypeContainer and live in class.cs.
15171 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
15172 argument; we're now also called for interfaces.
15173 (TypeContainer.DefineMembers): Allow this method being called
15175 (TypeContainer.GetMethods): New public method; formerly known as
15176 Interface.GetMethod(). This is used by PendingImplementation.
15177 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
15178 it's now private and non-static.
15179 (Interface): Moved this here; it's now implemented similar to
15181 (Method, Property, Event, Indexer): Added `bool is_interface'
15182 argument to their .ctor's.
15183 (MemberBase.IsInterface): New public field.
15185 * cs-parser.jay: Create normal Method, Property, Event, Indexer
15186 instances instead of InterfaceMethod, InterfaceProperty, etc.
15187 (opt_interface_base): Removed; we now use `opt_class_base' instead.
15188 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
15190 2004-03-19 Martin Baulig <martin@ximian.com>
15192 * class.cs (MethodCore.IsDuplicateImplementation): New private
15193 method which does the CS0111 checking.
15194 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
15195 Use IsDuplicateImplementation().
15197 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
15199 * decl.cs (FindMemberToOverride): New method to find the correct
15200 method or property to override in the base class.
15202 - Make Method/Property use the above method to find the
15203 version in the base class.
15204 - Remove the InheritableMemberSignatureCompare as it is now
15207 This patch makes large code bases much faster to compile, as it is
15208 O(n) rather than O(n^2) to do this validation.
15210 Also, it fixes bug 52458 which is that nested classes are not
15211 taken into account when finding the base class member.
15213 Reviewed/Approved by Martin.
15215 2004-03-17 Marek Safar <marek.safar@seznam.cz>
15217 * interface.cs: In all interface classes removed redundant
15218 member initialization.
15220 2004-03-16 Martin Baulig <martin@ximian.com>
15222 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
15224 2004-03-15 Miguel de Icaza <miguel@ximian.com>
15226 * decl.cs (DefineTypeAndParents): New helper method to define a
15227 type's containers before the type itself is defined; This is a
15228 bug exposed by the recent changes to Windows.Forms when an
15229 implemented interface was defined inside a class that had not been
15232 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
15234 (Check): Loop correctly to report errors modifiers
15235 (UNSAFE was not in the loop, since it was the same as TOP).
15237 * interface.cs: Every interface member now takes a ModFlags,
15238 instead of a "is_new" bool, which we set on the base MemberCore.
15240 Every place where we called "UnsafeOk" in the interface, now we
15241 call the proper member (InterfaceMethod.UnsafeOK) instead to get
15242 the unsafe settings from the member declaration instead of the
15243 container interface.
15245 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
15247 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
15248 `set_indexer_name' to the pending bits (one per type).
15250 We fixed a bug today that was picking the wrong method to
15251 override, since for properties the existing InterfaceMethod code
15252 basically ignored the method name. Now we make sure that the
15253 method name is one of the valid indexer names.
15255 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
15257 * support.cs (SeekableStreamReader): Keep track of stream byte
15258 positions and don't mix them with character offsets to the buffer.
15260 Patch from Gustavo Giráldez
15262 2004-03-15 Marek Safar <marek.safar@seznam.cz>
15264 * interface.cs (InterfaceSetGetBase): Removed double member
15265 initialization, base class does it as well.
15267 2004-03-13 Martin Baulig <martin@ximian.com>
15269 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
15270 when compiling corlib.
15272 2004-03-13 Miguel de Icaza <miguel@ximian.com>
15274 * convert.cs (ExplicitConversion): We were reporting an error on
15275 certain conversions (object_type source to a value type, when the
15276 expression was `null') before we had a chance to pass it through
15277 the user defined conversions.
15279 * driver.cs: Replace / and \ in resource specifications to dots.
15282 * class.cs: Add check for duplicate operators. Fixes 52477
15284 2004-03-11 Miguel de Icaza <miguel@ximian.com>
15286 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
15287 that are in the middle of the statements, not only at the end.
15290 * class.cs (TypeContainer.AddField): No longer set the
15291 `HaveStaticConstructor' flag, now we call it
15292 `UserDefineStaticConstructor' to diferentiate the slightly
15293 semantic difference.
15295 The situation is that we were not adding BeforeFieldInit (from
15296 Modifiers.TypeAttr) to classes that could have it.
15297 BeforeFieldInit should be set to classes that have no static
15302 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
15304 And most importantly Zoltan's comment:
15306 http://bugzilla.ximian.com/show_bug.cgi?id=44229
15308 "I think beforefieldinit means 'it's ok to initialize the type sometime
15309 before its static fields are used', i.e. initialization does not need
15310 to be triggered by the first access to the type. Setting this flag
15311 helps the JIT to compile better code, since it can run the static
15312 constructor at JIT time, and does not need to generate code to call it
15313 (possibly lots of times) at runtime. Unfortunately, mcs does not set
15314 this flag for lots of classes like String.
15316 csc sets this flag if the type does not have an explicit static
15317 constructor. The reasoning seems to be that if there are only static
15318 initalizers for a type, and no static constructor, then the programmer
15319 does not care when this initialization happens, so beforefieldinit
15322 This bug prevents the AOT compiler from being usable, since it
15323 generates so many calls to mono_runtime_class_init that the AOT code
15324 is much slower than the JITted code. The JITted code is faster,
15325 because it does not generate these calls if the vtable is type is
15326 already initialized, which is true in the majority of cases. But the
15327 AOT compiler can't do this."
15329 2004-03-10 Miguel de Icaza <miguel@ximian.com>
15331 * class.cs (MethodData.Emit): Refactor the code so symbolic
15332 information is generated for destructors; For some reasons we
15333 were taking a code path that did not generate symbolic information
15336 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
15338 * class.cs: Create a Constructor.CheckBase method that
15339 takes care of all validation type code. The method
15340 contains some code that was moved from Define.
15342 It also includes new code that checks for duplicate ctors.
15343 This fixes bug #55148.
15345 2004-03-09 Joshua Tauberer <tauberer@for.net>
15347 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
15348 a { ... }-style array creation invokes EmitStaticInitializers
15349 which is not good for reference-type arrays. String, decimal
15350 and now null constants (NullCast) are not counted toward
15351 static initializers.
15353 2004-03-05 Martin Baulig <martin@ximian.com>
15355 * location.cs (SourceFile.HasLineDirective): New public field;
15356 specifies whether the file contains or is referenced by a "#line"
15358 (Location.DefineSymbolDocuments): Ignore source files which
15359 either contain or are referenced by a "#line" directive.
15361 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
15363 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
15364 direct access to our parent, so check the method inline there.
15366 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
15368 * expression.cs (Invocation.EmitCall): Miguel's last commit
15369 caused a regression. If you had:
15374 In Foo the implict this would be null.
15376 2004-02-27 Miguel de Icaza <miguel@ximian.com>
15378 * expression.cs (Invocation.EmitCall): If the method is not
15379 virtual, do not emit a CallVirt to it, use Call.
15381 * typemanager.cs (GetFullNameSignature): Improve the method to
15382 cope with ".ctor" and replace it with the type name.
15384 * class.cs (ConstructorInitializer.Resolve): Now the method takes
15385 as an argument the ConstructorBuilder where it is being defined,
15386 to catch the recursive constructor invocations.
15388 2004-02-26 Miguel de Icaza <miguel@ximian.com>
15390 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
15391 routines to check if a type is an enumerable/enumerator allow
15392 classes that implement the IEnumerable or IEnumerator interfaces.
15394 * class.cs (Property, Operator): Implement IIteratorContainer, and
15395 implement SetYields.
15397 (Property.Define): Do the block swapping for get_methods in the
15398 context of iterators. We need to check if Properties also
15399 include indexers or not.
15401 (Operator): Assign the Block before invoking the
15402 OperatorMethod.Define, so we can trigger the Iterator code
15405 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
15406 Property and Operator classes are not created when we parse the
15407 declarator but until we have the block completed, so we use a
15408 singleton SimpleIteratorContainer.Simple to flag whether the
15409 SetYields has been invoked.
15411 We propagate this setting then to the Property or the Operator to
15412 allow the `yield' to function.
15414 2004-02-25 Marek Safar <marek.safar@seznam.cz>
15416 * codegen.cs: Implemented attribute support for modules.
15417 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
15418 Assembly/Module functionality.
15420 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
15421 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
15422 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
15424 2004-02-16 Marek Safar <marek.safar@seznam.cz>
15426 * interface.cs (FindMembers): The operation is performed on all base
15427 interfaces and not only on the first. It is required for future CLS Compliance patch.
15429 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
15431 * statement.cs, codegen.cs:
15432 This patch deals with patterns such as:
15434 public class List : IEnumerable {
15436 public MyEnumerator GetEnumerator () {
15437 return new MyEnumerator(this);
15440 IEnumerator IEnumerable.GetEnumerator () {
15444 public struct MyEnumerator : IEnumerator {
15449 Before, there were a few things we did wrong:
15450 1) we would emit callvirt on a struct, which is illegal
15451 2) we emited ldarg when we needed to emit ldarga
15452 3) we would mistakenly call the interface methods on an enumerator
15453 type that derived from IEnumerator and was in another assembly. For example:
15455 public class MyEnumerator : IEnumerator
15457 Would have the interface methods called, even if there were public impls of the
15458 method. In a struct, this lead to invalid IL code.
15460 2004-02-11 Marek Safar <marek.safar@seznam.cz>
15462 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
15465 * delegate.cs (Define): Fixed crash when delegate type is undefined.
15467 2004-02-11 Miguel de Icaza <miguel@ximian.com>
15469 * cs-parser.jay: Fix small regression: we were not testing V2
15470 compiler features correctly.
15472 * interface.cs: If the emit context is null, then create one
15474 2004-02-09 Marek Safar <marek.safar@seznam.cz>
15476 * decl.cs (GetSignatureForError): New virtual method to get full name
15477 for error messages.
15479 * attribute.cs (IAttributeSupport): New interface for attribute setting.
15480 Now it is possible to rewrite ApplyAttributes method to be less if/else.
15482 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
15483 Duplicated members and code in these classes has been removed.
15484 Better encapsulation in these classes.
15486 2004-02-07 Miguel de Icaza <miguel@ximian.com>
15488 * assign.cs (Assign.DoResolve): When dealing with compound
15489 assignments, there is a new rule in ECMA C# 2.4 (might have been
15490 there before, but it is documented here) that states that in:
15494 If b is of type int, and the `op' is a shift-operator, then the
15495 above is evaluated as:
15499 * expression.cs (Binary.ResolveOperator): Instead of testing for
15500 int/uint/long/ulong, try to implicitly convert to any of those
15501 types and use that in pointer arithmetic.
15503 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
15504 method to print information for from the type, not from the
15505 null-method we were given.
15507 2004-02-01 Duncan Mak <duncan@ximian.com>
15509 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
15510 parsing for cmd, fixes bug #53694.
15512 2004-02-04 Marek Safar <marek.safar@seznam.cz>
15514 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
15515 in the member name duplication tests. Property and operator name duplication
15516 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
15518 2004-02-03 Marek Safar <marek.safar@seznam.cz>
15520 * interface.cs (PopulateMethod): Fixed crash when interface method
15521 returns not existing type (error test cs0246-3.cs).
15523 2004-02-02 Ravi Pratap M <ravi@ximian.com>
15525 * cs-parser.jay (interface_accessors): Re-write actions to also
15526 store attributes attached to get and set methods. Fix spelling
15529 (inteface_property_declaration): Modify accordingly.
15531 (InterfaceAccessorInfo): New helper class to store information to pass
15532 around between rules that use interface_accessors.
15534 * interface.cs (Emit): Apply attributes on the get and set
15535 accessors of properties and indexers too.
15537 * attribute.cs (ApplyAttributes): Modify accordingly to use the
15538 right MethodBuilder when applying attributes to the get and set accessors.
15540 2004-01-31 Miguel de Icaza <miguel@ximian.com>
15542 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
15544 2004-01-26 Miguel de Icaza <miguel@ximian.com>
15546 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
15548 2004-01-25 Miguel de Icaza <miguel@ximian.com>
15550 * cs-parser.jay: Remove YIELD token, instead use the new grammar
15551 changes that treat `yield' specially when present before `break'
15552 or `return' tokens.
15554 * cs-tokenizer.cs: yield is no longer a keyword.
15556 2004-01-23 Marek Safar <marek.safar@seznam.cz>
15558 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
15559 setting for default constructors.
15560 For default constructors are almost every time set wrong Modifier. The
15561 generated IL code has been alright. But inside mcs this values was
15562 wrong and this was reason why several of my CLS Compliance tests
15565 2004-01-22 Martin Baulig <martin@ximian.com>
15567 * cs-parser.jay (namespace_or_type_name): Return an Expression,
15568 not a QualifiedIdentifier. This is what `type_name_expression'
15569 was previously doing.
15570 (type_name_expression): Removed; the code is now in
15571 `namespace_or_type_name'.
15572 (qualified_identifier): Removed, use `namespace_or_type_name'
15574 (QualifiedIdentifier): Removed this class.
15576 2004-01-22 Martin Baulig <martin@ximian.com>
15578 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
15579 not a string as alias name.
15581 2004-01-21 Miguel de Icaza <miguel@ximian.com>
15583 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
15584 #52730 bug, and instead compute correctly the need to use a
15585 temporary variable when requesting an address based on the
15586 static/instace modified of the field and the constructor.
15588 2004-01-21 Martin Baulig <martin@ximian.com>
15590 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
15591 class and namespace before looking up aliases. Fixes #52517.
15593 2004-01-21 Martin Baulig <martin@ximian.com>
15595 * flowanalysis.cs (UsageVector.Merge): Allow variables being
15596 assinged in a 'try'; fixes exception4.cs.
15598 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15599 * class.cs : Implemented parameter-less constructor for TypeContainer
15601 * decl.cs: Attributes are now stored here. New property OptAttributes
15603 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
15605 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
15607 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15609 * typemanager.cs (CSharpSignature): Now reports also inner class name.
15610 (CSharpSignature): New method for indexer and property signature.
15612 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15614 * pending.cs (IsVirtualFilter): Faster implementation.
15616 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15618 * typemanager.cs: Avoid inclusion of same assembly more than once.
15620 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15622 * cs-parser.jay: Fixed problem where the last assembly attribute
15623 has been applied also to following declaration (class, struct, etc.)
15625 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15627 * class.cs: Added error CS0538, CS0539 reporting.
15628 Fixed crash on Microsoft runtime when field type is void.
15630 * cs-parser.jay: Added error CS0537 reporting.
15632 * pending.cs: Added error CS0535 reporting.
15633 Improved error report for errors CS0536, CS0534.
15635 2004-01-20 Miguel de Icaza <miguel@ximian.com>
15637 Merge a few bits from the Anonymous Method MCS tree.
15639 * statement.cs (ToplevelBlock): New class for toplevel methods,
15640 will hold anonymous methods, lifted variables.
15642 * cs-parser.jay: Create toplevel blocks for delegates and for
15643 regular blocks of code.
15645 2004-01-20 Martin Baulig <martin@ximian.com>
15647 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
15648 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
15649 and `NeedExplicitReturn'; added `IsLastStatement'.
15650 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
15651 have a `ReturnLabel' or we're not unreachable.
15653 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
15654 child's reachability; don't just override ours with it. Fixes
15655 #58058 (lluis's example).
15656 (FlowBranching): Added public InTryOrCatch(), InCatch(),
15657 InFinally(), InLoop(), InSwitch() and
15658 BreakCrossesTryCatchBoundary() methods.
15660 * statement.cs (Return): Do all error checking in Resolve().
15661 Unless we are the last statement in a top-level block, always
15662 create a return label and jump to it.
15663 (Break, Continue): Do all error checking in Resolve(); also make
15664 sure we aren't leaving a `finally'.
15665 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
15666 statement in a top-level block.
15667 (Block.Flags): Added `IsDestructor'.
15668 (Block.IsDestructor): New public property.
15670 2004-01-20 Martin Baulig <martin@ximian.com>
15672 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
15674 2004-01-20 Martin Baulig <martin@ximian.com>
15676 * statement.cs (Statement.ResolveUnreachable): New public method.
15677 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
15678 (Block.Resolve): Resolve unreachable statements.
15680 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15682 * expression.cs: We need to fix the case where we do
15683 not have a temp variable here.
15685 * assign.cs: Only expression compound assignments need
15686 temporary variables.
15688 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15690 * flowanalysis.cs: Reduce memory allocation in a few ways:
15691 - A block with no variables should not allocate a bit
15693 - A method with no out parameters does not need any tracking
15694 for assignment of the parameters, so we need not allocate
15697 public readonly Type[] VariableTypes;
15698 public readonly string[] VariableNames;
15699 Are redundant. The data is already stored in the variable
15700 map, so we need not allocate another array for it.
15701 - We need to add alot of checks for if (params | locals) == null
15702 due to the first two changes.
15704 2004-01-18 Miguel de Icaza <miguel@ximian.com>
15706 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
15707 implement IMemoryLocation, we store a copy on a local variable and
15708 take the address of it. Patch from Benjamin Jemlich
15710 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
15711 to use a special "type_name_expression" rule which reduces the
15712 number of "QualifiedIdentifier" classes created, and instead
15713 directly creates MemberAccess expressions.
15715 2004-01-17 Miguel de Icaza <miguel@ximian.com>
15717 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
15718 that fixes #52853. Null literal assignment to ValueType
15720 * class.cs (MethodData.Emit): Instead of checking the name of the
15721 method to determine if its a destructor, create a new derived
15722 class from Method called Destructor, and test for that.
15724 * cs-parser.jay: Create a Destructor object instead of a Method.
15726 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
15730 2004-01-16 Miguel de Icaza <miguel@ximian.com>
15732 * expression.cs (Binary.ResolveOperator): Perform an implicit
15733 conversion from MethodGroups to their delegate types on the
15734 Addition operation.
15736 * delegate.cs: Introduce a new class DelegateCreation that is the
15737 base class for `NewDelegate' and `ImplicitDelegateCreation',
15738 factor some code in here.
15740 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
15741 conversion from MethodGroups to compatible delegate types.
15743 * ecore.cs (Expression.Resolve): Do not flag error 654
15744 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
15745 we allow conversions from MethodGroups to delegate types now.
15747 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
15748 assignments in v2 either.
15750 2004-01-10 Miguel de Icaza <miguel@ximian.com>
15752 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
15753 static read-only fields in ctors.
15755 Applied patch from Benjamin Jemlich
15757 * expression.cs (UnaryMutator): Avoid leaking local variables.
15759 2004-01-09 Miguel de Icaza <miguel@ximian.com>
15761 * cs-tokenizer.cs (IsCastToken): Allow the various native types
15762 here to return true, as they can be used like this:
15764 (XXX) int.MEMBER ()
15766 Fixed 49836 and all the other dups
15768 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
15770 * driver.cs: Implement /win32res and /win32icon.
15772 2004-01-08 Miguel de Icaza <miguel@ximian.com>
15774 * cs-parser.jay: Add a rule to improve error handling for the
15775 common mistake of placing modifiers after the type.
15777 2004-01-07 Miguel de Icaza <miguel@ximian.com>
15779 * cs-parser.jay (interface_event_declaration): Catch
15780 initialization of events on interfaces, and report cs0068
15782 * cs-parser.jay (interface_event_declaration): Catch
15783 initialization of events.
15785 * ecore.cs: Better report missing constructors.
15787 * expression.cs (Binary.ResolveOperator): My previous bug fix had
15788 the error reporting done in the wrong place. Fix.
15790 * expression.cs (Binary.ResolveOperator): Catch the
15791 operator + (E x, E y) error earlier, and later allow for implicit
15792 conversions in operator +/- (E e, U x) from U to the underlying
15795 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
15796 52596, if the container class is abstract, the default constructor
15797 is protected otherwise its public (before, we were always public).
15799 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
15802 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
15803 Jemlich that fixes bug #52597, MCS was generating invalid code for
15804 idisposable structs. Thanks to Ben for following up with this
15807 2004-01-06 Miguel de Icaza <miguel@ximian.com>
15809 * driver.cs: Allow assemblies without code to be generated, fixes
15812 2004-01-07 Nick Drochak <ndrochak@gol.com>
15814 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
15816 2004-01-05 Miguel de Icaza <miguel@ximian.com>
15818 * cs-parser.jay: Add rules to improve error reporting if fields or
15819 methods are declared at the namespace level (error 116)
15821 * Add rules to catch event add/remove
15823 2004-01-04 David Sheldon <dave-mono@earth.li>
15825 * expression.cs: Added matching ")" to error message for
15828 2004-01-03 Todd Berman <tberman@gentoo.org>
15830 * ecore.cs, attribute.cs:
15831 Applying fix from #52429.
15833 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15835 * ecore.cs, expression.cs, statement.cs:
15836 Total rewrite of how we handle branching. We
15837 now handle complex boolean expressions with fewer
15838 jumps. As well if (x == 0) no longer emits a ceq.
15840 if (x is Foo) is much faster now, because we generate
15843 Overall, we get a pretty big improvement on our benchmark
15844 tests. The code we generate is smaller and more readable.
15846 I did a full two-stage bootstrap. The patch was reviewed
15847 by Martin and Miguel.
15849 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15851 * cs-parser.jay: Make primary_expression not take a QI.
15852 we dont need this because the member_access rule covers
15853 us here. So we replace the rule with just IDENTIFIER.
15855 This has two good effects. First, we remove a s/r conflict.
15856 Second, we allocate many fewer QualifiedIdentifier objects.
15858 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15860 * attribute.cs: Handle MarshalAs attributes as pseudo, and
15861 set the correct information via SRE. This prevents
15862 hanging on the MS runtime. Fixes #29374.
15864 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15866 * convert.cs: correctly handle conversions to value types
15867 from Enum and ValueType as unboxing conversions.
15869 Fixes bug #52569. Patch by Benjamin Jemlich.
15871 2004-01-02 Ravi Pratap <ravi@ximian.com>
15873 * expression.cs (BetterConversion): Prefer int -> uint
15874 over int -> ulong (csc's behaviour). This fixed bug #52046.
15876 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
15878 * decl.cs (MemberCache.FindMembers): now returns a
15881 * typemanager.cs: In general, go with with ^^.
15882 (CopyNewMethods): take an IList.
15883 (RealMemberLookup): Only allocate an arraylist
15884 if we copy from two sets of methods.
15886 This change basically does two things:
15887 1) Fewer array lists allocated due to CopyNewMethods.
15888 2) the explicit cast in MemberList costed ALOT.
15890 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
15892 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
15893 a hashtable to avoid needless string allocations when an identifier is
15894 used more than once (the common case).
15896 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
15898 * pending.cs: MS's TypeBuilder.GetInterfaces ()
15899 is broken, it will not return anything. So, we
15900 have to use the information we have in mcs to
15903 * typemanager.cs: Add a cache for GetInterfaces,
15904 since this will now be used more often (due to ^^)
15906 (GetExplicitInterfaces) New method that gets the
15907 declared, not effective, interfaces on a type
15908 builder (eg, if you have interface IFoo, interface
15909 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
15912 This patch makes MCS able to bootstrap itself on
15915 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
15917 * expression.cs: Remove the Nop's that Miguel put
15920 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15922 * report.cs, codegen.cs: Give the real stack trace to
15923 the error when an exception is thrown.
15925 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15927 * decl.cs: only allocate hashtables for ifaces if
15930 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15932 * expression.cs: fix the error from cs0121-2.cs
15933 (a parent interface has two child interfaces that
15934 have a function with the same name and 0 params
15935 and the function is called through the parent).
15937 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
15939 * class.cs, rootcontext.cs, typmanager.cs: do not
15942 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
15944 * codegen.cs: remove stack for the ec flow branching.
15945 It is already a linked list, so no need.
15947 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
15949 * Makefile: Allow custom profiler here.
15951 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
15953 * typemanager.cs (LookupType):
15954 - Use a static char [], because split takes
15955 a param array for args, so it was allocating
15957 - Do not store true in a hashtable, it boxes.
15959 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
15961 * flowanalysis.cs: bytify common enums.
15963 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
15965 * modifiers.cs: Add a new set of flags for the
15966 flags allowed on explicit interface impls.
15967 * cs-parser.jay: catch the use of modifiers in
15968 interfaces correctly.
15969 * class.cs: catch private void IFoo.Blah ().
15971 All related to bug #50572.
15973 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
15975 * decl.cs: Rewrite the consistant accessability checking.
15976 Accessability is not linear, it must be implemented in
15977 a tableish way. Fixes #49704.
15979 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
15981 * expression.cs: Handle negation in a checked context.
15982 We must use subtraction from zero. Fixes #38674.
15984 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
15986 * class.cs: Ignore static void main in DLLs.
15987 * rootcontext.cs: Handle the target type here,
15988 since we are have to access it from class.cs
15989 * driver.cs: account for the above.
15991 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
15993 * report.cs: Give line numbers and files if available.
15995 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
15997 * driver.cs: Implement /addmodule.
15999 * typemanager.cs: Change 'modules' field so it now contains Modules not
16002 2003-12-20 Martin Baulig <martin@ximian.com>
16004 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
16005 (FieldBase.IsAssigned): Removed this field.
16006 (FieldBase.SetAssigned): New public method.
16007 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
16009 2003-12-20 Martin Baulig <martin@ximian.com>
16011 * expression.cs (LocalVariableReference.DoResolve): Don't set
16012 `vi.Used' if we're called from DoResolveLValue().
16014 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
16015 returns the usage vector it just merged into the current one -
16016 pass this one to UsageWarning().
16017 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
16018 of the `EmitContext', don't call this recursively on our children.
16020 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
16022 * driver.cs: Implement /target:module.
16024 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
16026 * support.cs (CharArrayHashtable): New helper class.
16028 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
16029 char arrays, not strings, so we can avoid creating a string in
16030 consume_identifier if the identifier is a keyword.
16032 2003-12-16 Martin Baulig <martin@ximian.com>
16034 * statement.cs (LocalInfo.Assigned): Removed this property.
16035 (LocalInfo.Flags): Removed `Assigned'.
16036 (LocalInfo.IsAssigned): New public method; takes the EmitContext
16037 and uses flow analysis.
16038 (Block.UsageWarning): Made this method private.
16039 (Block.Resolve): Call UsageWarning() if appropriate.
16041 * expression.cs (LocalVariableReference.DoResolve): Always set
16042 LocalInfo.Used here.
16044 2003-12-13 Martin Baulig <martin@ximian.com>
16046 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
16047 any value here; we're now using flow analysis to figure out
16048 whether a statement/block returns a value.
16050 2003-12-13 Martin Baulig <martin@ximian.com>
16052 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
16054 (FlowBranching.MergeFinally): Don't call
16055 `branching.CheckOutParameters()' here, this is called in
16057 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
16058 when adding the `finally' vector.
16060 2003-12-13 Martin Baulig <martin@ximian.com>
16063 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
16064 actually work and also fix #48962.
16066 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
16068 * decl.cs: Do not check System.Object for nested types,
16069 since we know it does not have any. Big bang for buck:
16072 Run 1: 8.35 seconds
16073 Run 2: 8.32 seconds
16074 corlib: 17.99 seconds
16076 Run 1: 8.17 seconds
16077 Run 2: 8.17 seconds
16078 corlib: 17.39 seconds
16080 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
16082 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
16083 time we are returning 0 members, so we save alot here.
16085 2003-12-11 Martin Baulig <martin@ximian.com>
16087 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
16088 `MergeChild()', also just take the `FlowBranching' as argument;
16089 call Merge() on it and return the result.
16090 (FlowBranching.Merge): We don't need to do anything if we just
16093 2003-12-11 Martin Baulig <martin@ximian.com>
16095 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
16096 them in an `ArrayList' to reduce memory usage. Thanks to Ben
16097 Maurer for this idea.
16099 2003-12-11 Martin Baulig <martin@ximian.com>
16101 * flowanalysis.cs (MergeResult): This class is now gone; we now
16102 use the `UsageVector' for this. The reason for this is that if a
16103 branching just has one sibling, we don't need to "merge" them at
16104 all - that's the next step to do.
16105 (FlowBranching.Merge): We now return a `UsageVector' instead of a
16108 2003-12-11 Martin Baulig <martin@ximian.com>
16110 Reworked flow analyis and made it more precise and bug-free. The
16111 most important change is that we're now using a special `Reachability'
16112 class instead of having "magic" meanings of `FlowReturns'. I'll
16113 do some more cleanups and optimizations and also add some more
16114 documentation this week.
16116 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
16117 largely reworked this class.
16118 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
16119 the new `Reachability' class instead of having "magic" values here.
16120 (FlowBranching): We're now using an instance of `Reachability'
16121 instead of having separate `Returns', `Breaks' etc. fields.
16123 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
16124 based on flow analysis; ignore the return value of block.Emit ().
16126 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
16128 * driver.cs typemanager.cs: Find the mono extensions to corlib even
16129 if they are private.
16131 2003-12-09 Martin Baulig <martin@ximian.com>
16133 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
16134 call them directly on the UsageVector.
16136 2003-12-09 Martin Baulig <martin@ximian.com>
16138 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
16139 Changed return type from `FlowReturns' to `Reachability'.
16141 2003-12-09 Martin Baulig <martin@ximian.com>
16143 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
16144 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
16145 `Reachable' fields with a single `Reachability' one.
16147 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16149 * class.cs (FindMembers): Remove foreach's.
16154 Run 1: 8.74 seconds
16155 Run 2: 8.71 seconds
16158 Run 1: 8.64 seconds
16159 Run 2: 8.58 seconds
16162 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16167 This patch does a few things:
16168 1. EmptyStatement is now a singleton, so it is never reallocated.
16169 2. All blah is EmptyStatement constructs have been changed to
16170 blah == EmptyStatement.Value, which is much faster and valid
16171 now that EmptyStatement is a singleton.
16172 3. When resolving a block, rather than allocating a new array for
16173 the non-empty statements, empty statements are replaced with
16174 EmptyStatement.Value
16175 4. Some recursive functions have been made non-recursive.
16176 Mainly the performance impact is from (3), however (1) and (2) are needed for
16177 this to work. (4) does not make a big difference in normal situations, however
16178 it makes the profile look saner.
16183 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
16184 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
16185 Total memory allocated: 56397 KB
16188 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
16189 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
16190 Total memory allocated: 55666 KB
16192 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16194 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
16195 than the hashtable in a hashtable version
16197 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
16198 we always end up concating a string. This results in a huge perf
16199 loss, because many strings have to be tracked by the GC. In this
16200 patch, we first use a hashtable that works with two keys, so that
16201 the strings do not need to be concat'ed.
16205 Run 1: 8.74 seconds
16206 Run 2: 8.71 seconds
16209 Run 1: 8.65 seconds
16210 Run 2: 8.56 seconds
16212 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16214 * Makefile: Add a new target `do-time' that does a quick and simple
16215 profile, leaving easy to parse output.
16217 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
16219 * codegen.cs (Init): Create the dynamic assembly with
16220 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
16222 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
16224 * support.cs: Make the PtrHashtable use only one
16225 instance of its comparer.
16227 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
16229 * typemanager.cs: Fix lookup of GetNamespaces.
16231 2003-11-29 Miguel de Icaza <miguel@ximian.com>
16233 * expression.cs: Removed redundant line.
16235 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
16236 ArrayLists, use for loops with bounds.
16238 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
16241 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
16242 arraylists, use for loop with bounds.
16244 The above three changes give us a 0.071 second performance
16245 improvement out of 3.294 seconds down to 3.223. On my machine
16246 the above changes reduced the memory usage by 1,387 KB during
16247 compiler bootstrap.
16249 * cs-parser.jay (QualifiedIdentifier): New class used to represent
16250 QualifiedIdentifiers. Before we created a new string through
16251 concatenation, and mostly later on, the result would be
16252 manipulated by DecomposeQI through string manipulation.
16254 This reduced the compiler memory usage for bootstrapping from
16255 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
16256 compile times in 0.05 seconds.
16258 2003-11-28 Dick Porter <dick@ximian.com>
16260 * support.cs: Do string compares with the Invariant culture.
16268 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
16269 the comparison is done with the Invariant culture.
16271 2003-11-27 Miguel de Icaza <miguel@ximian.com>
16273 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
16274 GetEnumerator method.
16276 (ProbeCollectionType): Iterate starting at the most specific type
16277 upwards looking for a GetEnumerator
16279 * expression.cs: Shift count can be up to 31 for int/uint and 63
16282 2003-11-26 Miguel de Icaza <miguel@ximian.com>
16284 * statement.cs (Block.LookupLabel): Also look for the label on the
16285 children blocks. Use a hash table to keep track of visited
16288 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
16289 we actually did transform the other operand, otherwise fall back
16290 to the common codepath that casts to long.
16292 * cs-tokenizer.cs: Use the same code pattern as the int case.
16293 Maybe I should do the parsing myself, and avoid depending on the
16294 Parse routines to get this done.
16296 2003-11-25 Miguel de Icaza <miguel@ximian.com>
16298 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16299 which fixes bug 51347. This time test it.
16301 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
16302 attributes for example can not tell the difference between these.
16303 The difference was only a syntax feature of the language.
16305 * attribute.cs: Apply attributes to delegates.
16307 * delegate.cs: Call the apply attributes method.
16309 2003-11-24 Miguel de Icaza <miguel@ximian.com>
16311 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
16312 comparing 0 vs Byte.MinValue, not the value
16314 (ImplicitConversionRequired): When reporting a conversion error,
16315 use error 31 to print out the constant error instead of the
16318 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16319 which fixes bug 51347.
16321 2003-11-22 Miguel de Icaza <miguel@ximian.com>
16323 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
16324 which fixes the -warnaserror command line option.
16326 2003-11-21 Miguel de Icaza <miguel@ximian.com>
16328 * cfold.cs (DoNumericPromotions): During constant folding of
16329 additions on UIntConstant, special case intconstants with
16330 IntConstants like we do on the expression binary operator.
16332 2003-11-12 Miguel de Icaza <miguel@ximian.com>
16334 * convert.cs (ImplicitReferenceConversion): We were missing a case
16335 (System.Enum are not value types or class types, so we need to
16336 classify them separatedly).
16338 * driver.cs: We do not support error 2007.
16340 2003-11-12 Jackson Harper <jackson@ximian.com>
16342 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
16343 system directory. Also use the full file name so users can
16344 libraries names mscorlib-o-tron.dll in a non system dir.
16346 2003-11-10 Martin Baulig <martin@ximian.com>
16348 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
16349 (TypeManager.InitCoreTypes): Initialize them here, but instead of
16350 calling `ResolveType()' on them, directly assign their `Type'.
16352 2003-11-08 Martin Baulig <martin@ximian.com>
16354 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
16355 return value and the `out parent' parameter.
16356 (TypeContainer.DefineType): Moved the CS0644 check into
16357 GetClassBases(). Don't pass the interface types to the
16358 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
16359 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
16361 * ecore.cs (TypeExpr.IsAttribute): New property.
16362 (TypeExpr.GetInterfaces): New method.
16364 * interface.cs (Interface.GetInterfaceTypeByName): Return a
16365 TypeExpr instead of a Type.
16366 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
16367 (Interface.DefineType): Don't pass the interface types to the
16368 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
16369 them later and then call `TypeBulider.AddInterfaceImplementation()'.
16371 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
16372 instead of a `Type[]'.
16373 (TypeManager.RegisterBuilder): Likewise.
16374 (TypeManager.AddUserInterface): Likewise.
16375 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
16376 `Type[]' and also return a `TypeExpr[]'.
16377 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
16379 2003-11-08 Martin Baulig <martin@ximian.com>
16381 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
16384 2003-11-08 Martin Baulig <martin@ximian.com>
16386 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
16387 TypeManager.ResolveExpressionTypes().
16389 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
16390 instead of an Expression.
16391 (TypeExpr): This is now an abstract base class for `TypeExpression'.
16392 (TypeExpression): New public class; formerly known as `TypeExpr'.
16394 * expression.cs (ComposedCast): Derive from TypeExpr.
16396 * typemanager.cs (TypeManager.system_*_expr): These are now
16397 TypExpr's instead of Expression's.
16398 (TypeManager.ResolveExpressionTypes): New public static function;
16399 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
16402 2003-11-06 Miguel de Icaza <miguel@ximian.com>
16404 * expression.cs (New.DoResolve): Do not dereference value that
16405 might be a null return.
16407 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
16408 sure that the constant value has the right type. Fixes an
16409 unreported bug, similar to 50425.
16411 * const.cs (Const.LookupConstantValue): Call
16412 ImplicitStandardConversionExists before doing a conversion to
16413 avoid havng the TypeManager.ChangeType do conversions.
16415 Reduced the number of casts used
16417 (Const.ChangeType): New routine to enable reuse of the constant
16418 type changing code from statement.
16420 * typemanager.cs (ChangeType): Move common initialization to
16421 static global variables.
16425 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
16426 every value type to go through, even if it was void. Fix that.
16428 * cs-tokenizer.cs: Use is_identifier_start_character on the start
16429 character of the define, and the is_identifier_part_character for
16430 the rest of the string.
16432 2003-11-05 Miguel de Icaza <miguel@ximian.com>
16434 * expression.cs (UnaryMutator.EmitCode): When I updated
16435 LocalVariableReference.DoResolve, I overdid it, and dropped an
16436 optimization done on local variable references.
16438 2003-11-04 Miguel de Icaza <miguel@ximian.com>
16440 * ecore.cs: Convert the return from Ldlen into an int.
16442 2003-10-20 Miguel de Icaza <miguel@ximian.com>
16444 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
16445 the accessibility, this is a special case for toplevel non-public
16446 classes (internal for instance).
16448 2003-10-20 Nick Drochak <ndrochak@gol.com>
16450 * ecore.cs: Fix typo and build. Needed another right paren.
16452 2003-10-19 Miguel de Icaza <miguel@ximian.com>
16454 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
16455 `internal' case regular and protected, but not allowing protected
16456 to be evaluated later. Bug 49840
16458 2003-10-15 Miguel de Icaza <miguel@ximian.com>
16460 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
16461 to kb.Nlast, and not the kb.nFirst to isolate the switch
16464 Extract the underlying type, so enumerations of long/ulong are
16465 treated like long/ulong.
16467 2003-10-14 Miguel de Icaza <miguel@ximian.com>
16469 * expression.cs (New): Overload the meaning of RequestedType to
16470 track the possible creation of the NewDelegate type, since
16471 DoResolve is invoked more than once for new constructors on field
16474 See bugs: #48800 and #37014
16476 * cs-parser.jay (declare_local_constants): Take an arraylist
16477 instead of a single constant.
16479 (local_constant_declaration): It should take a
16480 constant_declarators, not a constant_declarator. Fixes 49487
16482 * convert.cs: Fix error report.
16484 2003-10-13 Jackson Harper <jackson@ximian.com>
16486 * typemanager.cs (TypeToCoreType): Add float and double this fixes
16489 2003-10-09 Martin Baulig <martin@ximian.com>
16491 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
16493 (MethodCore.DoDefineParameters): Removed the TypeContainer
16494 argument; use the DeclSpace which was passed to the .ctor instead.
16495 (MethodCore.CheckParameter): Take a DeclSpace instead of a
16496 TypeContainer; we only need a DeclSpace here.
16498 2003-10-09 Martin Baulig <martin@ximian.com>
16500 * class.cs (MethodData): Added additional `DeclSpace ds' argument
16502 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
16503 EmitContext's .ctor.
16505 2003-10-09 Martin Baulig <martin@ximian.com>
16507 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
16508 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
16509 AsAccessible(), moved them as well.
16511 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
16513 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
16515 * cs-parser.jay : Renamed yyName to yyNames related to jay.
16517 2003-10-07 Miguel de Icaza <miguel@ximian.com>
16519 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
16520 generation for >=, as spotted by Paolo, bug 48679.
16521 Patch from David Waite.
16523 * cs-tokenizer.cs: Add handling for #pragma.
16525 * cs-parser.jay: Allow for both yield and yield return in the
16526 syntax. The anti-cobolization of C# fight will go on!
16528 * class.cs (TypeBuilder.DefineType): Catch error condition here
16529 (Parent.DefineType erroring out and returning null).
16531 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16532 coping with enumerations variables, we were mistakenly processing
16533 them as a regular value type instead of built-in types. Fixes the
16536 * typemanager.cs (IsBuiltinOrEnum): New method.
16538 2003-09-30 Miguel de Icaza <miguel@ximian.com>
16540 * cs-parser.jay: Upgrade: yield now needs the return clause.
16542 2003-09-19 Martin Baulig <martin@ximian.com>
16544 * decl.cs (MemberCache.SetupCacheForInterface): Take a
16545 `MemberCache parent' argument. Normally, an interface doesn't
16546 have a parent type except System.Object, but we use this in gmcs
16547 for generic type parameters.
16549 2003-09-18 Martin Baulig <martin@ximian.com>
16551 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
16552 on `type.IsInterface'; don't check whether the type has a parent
16553 to determine whether it's an interface.
16555 2003-09-15 Martin Baulig <martin@ximian.com>
16557 * class.cs (TypeContainer.DefineType): Added an error flag to
16558 avoid reporting duplicate CS0146's ("class definition is
16561 * driver.cs (Driver.MainDriver): Abort if
16562 RootContext.ResolveTree() reported any errors.
16564 2003-09-07 Martin Baulig <martin@ximian.com>
16566 * report.cs (Error, Warning): Added overloaded versions which take
16567 a `params object[] args' and call String.Format().
16569 2003-09-07 Martin Baulig <martin@ximian.com>
16571 * decl.cs (DeclSpace..ctor): Don't call
16572 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
16573 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
16574 (DeclSpace.RecordDecl): New method.
16576 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
16578 2003-09-02 Ravi Pratap <ravi@ximian.com>
16580 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
16581 value attributes to be applied to ParameterBuilders.
16583 * class.cs (MethodCore.LabelParameters): Make static and more
16584 generic so that it can be used from other places - like interface
16585 methods, for instance.
16587 * interface.cs (Interface.Emit): Call LabelParameters before
16588 emitting attributes on the InterfaceMethod.
16590 2003-08-26 Martin Baulig <martin@ximian.com>
16592 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
16593 resolving aliases; fixes #47927.
16595 2003-08-26 Martin Baulig <martin@ximian.com>
16597 * statement.cs (Using.DoResolve): This is internally emitting a
16598 try/finally clause, so we need to set ec.NeedExplicitReturn if we
16599 do not always return. Fixes #47681.
16601 2003-08-26 Martin Baulig <martin@ximian.com>
16603 * decl.cs (MemberCore): Moved WarningNotHiding(),
16604 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
16606 (AdditionResult): Make this nested in DeclSpace.
16607 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
16608 argument; call NamespaceEntry.Define() unless we're nested in a
16611 * namespace.cs (Namespace.DefineName): New public function. This
16612 is called from DeclSpace's .ctor to add
16613 (Namespace.Lookup): Include DeclSpaces in the lookup.
16615 * class.cs (Operator): Derive from MemberBase, not MemberCore.
16617 * const.cs (Const): Derive from MemberBase, not MemberCore.
16619 2003-08-25 Martin Baulig <martin@ximian.com>
16621 * convert.cs (Convert.ExplicitReferenceConversion): When
16622 converting from an interface type to a class, unbox if the target
16623 type is a struct type. Fixes #47822.
16625 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16627 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
16630 2003-08-22 Martin Baulig <martin@ximian.com>
16632 * class.cs (TypeManager.DefineType): When defining a nested type,
16633 call DefineType() on our parent; fixes #47801.
16635 2003-08-22 Martin Baulig <martin@ximian.com>
16637 * class.cs (MethodData.Define): While checking if a method is an
16638 interface implementation, improve the test a bit more to fix #47654.
16640 2003-08-22 Martin Baulig <martin@ximian.com>
16642 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
16643 correctly; fixes #47722.
16645 2003-08-22 Martin Baulig <martin@ximian.com>
16647 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
16648 LocalVariableReference, ensure it's not read-only. Fixes #47536.
16650 * statement.cs (Fixed.DoResolve): Make all variables read-only.
16652 2003-08-22 Martin Baulig <martin@ximian.com>
16654 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
16655 can only be assigned in static constructors. Fixes #47161.
16657 2003-08-22 Martin Baulig <martin@ximian.com>
16659 Rewrote and improved the flow analysis code.
16661 * flowbranching.cs (FlowBranching): Make this class abstract.
16662 (FlowBranching.CreateBranching): New static function to create a
16663 new flow branching.
16664 (FlowBranchingBlock, FlowBranchingException): New classes.
16665 (FlowBranching.UsageVector.Type): New public readonly field.
16666 (FlowBranching.UsageVector.Breaks): Removed the setter.
16667 (FlowBranching.UsageVector.Returns): Removed the setter.
16668 (FlowBranching.UsageVector): Added Break(), Return(),
16669 NeverReachable() and Throw() methods to modify the reachability.
16670 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
16671 done by FlowBranching.Merge().
16672 (FlowBranching.UsageVector.MergeChild): New method; merges the
16673 merge result into the current vector.
16674 (FlowBranching.Merge): New abstract method to merge a branching.
16676 2003-08-12 Martin Baulig <martin@ximian.com>
16678 * expression.cs (Indirection.CacheTemporaries): Create the
16679 LocalTemporary with the pointer type, not its element type.
16681 2003-08-10 Miguel de Icaza <miguel@ximian.com>
16683 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
16684 token was a keyword or not.
16686 Add `error' options where an IDENTIFIER was expected; Provide
16687 CheckToken and CheckIdentifierToken convenience error reporting
16690 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
16692 * decl.cs: Rename `NamespaceEntry Namespace' public field into
16693 NameSpaceEntry NameSpaceEntry.
16695 (LookupInterfaceOrClass): Avoid creating a full qualified name
16696 from namespace and name: avoid doing lookups when we know the
16697 namespace is non-existant. Use new Tree.LookupByNamespace which
16698 looks up DeclSpaces based on their namespace, name pair.
16700 * driver.cs: Provide a new `parser verbose' to display the
16701 exception thrown during parsing. This is turned off by default
16702 now, so the output of a failure from mcs is more graceful.
16704 * namespace.cs: Track all the namespaces defined in a hashtable
16707 (IsNamespace): New method
16709 2003-08-09 Miguel de Icaza <miguel@ximian.com>
16711 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
16712 we know that we need to concatenate (full typename can never be
16717 * statement.cs: Use a bitfield; Do not initialize to null things
16718 which are done by the constructor by default.
16720 * cs-parser.jay: bug fix, parameter was 4, not 3.
16722 * expression.cs: Just use the property;
16724 * statement.cs: No need for GetVariableInfo method.
16726 2003-08-08 Martin Baulig <martin@ximian.com>
16728 * flowanalysis.cs (FlowReturns): This is now nested in the
16729 `FlowBranching' class.
16730 (MyBitVector): Moved this here from statement.cs.
16731 (FlowBranching.SiblingType): New enum type.
16732 (FlowBranching.CreateSibling): Added `SiblingType' argument.
16734 2003-08-07 Martin Baulig <martin@ximian.com>
16736 * flowanalysis.cs (FlowBranchingType): This is now nested in the
16737 `FlowBranching' class and called `BranchingType'.
16739 2003-08-07 Martin Baulig <martin@ximian.com>
16741 * flowanalysis.cs: Moved all the control flow analysis code into
16744 2003-08-07 Martin Baulig <martin@ximian.com>
16746 * assign.cs (Assign.DoResolve): `target' must either be an
16747 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
16750 2003-08-07 Miguel de Icaza <miguel@ximian.com>
16752 * expression.cs (BinaryMethod): This kind of expression is created by the
16753 Binary class if it determines that the operator has to be handled
16756 (BinaryDelegate): This kind of expression is created if we are
16757 dealing with a + or - operator on delegates.
16759 (Binary): remove method, argumetns, and DelegateOperator: when
16760 dealing with methods,
16762 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
16764 * statement.cs (Block): use bitfields for the three extra booleans
16765 we had in use. Remove unused topblock parameter.
16767 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
16769 * assign.cs: Drop extra unneeded tests.
16771 2003-08-06 Miguel de Icaza <miguel@ximian.com>
16773 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
16775 * statement.cs (Foreach): Use VariableStorage instead of
16778 * codegen.cs (VariableStorage): New class used by clients that
16779 require a variable stored: locals or fields for variables that
16780 need to live across yield.
16782 Maybe provide a convenience api for EmitThis+EmitLoad?
16784 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
16787 2003-08-05 Miguel de Icaza <miguel@ximian.com>
16789 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
16790 RemapParameterLValue): New methods that are used to turn a
16791 precomputed FieldInfo into an expression like this:
16795 The idea is to use this instead of making LocalVariableReference
16796 have more than one meaning.
16798 * cs-parser.jay: Add error production to BASE.
16800 * ecore.cs: Deal with TypeManager.GetField returning null, which
16801 is now a valid return value.
16803 (FieldExprNoAddress): New expression for Fields whose address can
16806 * expression.cs (LocalVariableReference): During the resolve
16807 phases, create new expressions if we are in a remapping context.
16808 Remove code that dealt with remapping here.
16810 (ParameterReference): same.
16812 (ProxyInstance): New expression, like the `This' expression, but
16813 it is born fully resolved. We know what we are doing, so remove
16814 the errors that are targeted to user-provided uses of `this'.
16816 * statement.cs (Foreach): our variable is now stored as an
16817 Expression; During resolution, follow the protocol, dont just
16818 assume it will return this.
16820 2003-08-06 Martin Baulig <martin@ximian.com>
16822 * support.cs (SeekableStreamReader.cs): New public class.
16824 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
16825 SeekableStreamReader instead of the normal StreamReader.
16827 2003-08-04 Martin Baulig <martin@ximian.com>
16829 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
16830 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
16831 deambiguate casts and delegate invocations.
16832 (parenthesized_expression): Use the new tokens to ensure this is
16833 not a cast of method invocation.
16835 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
16836 when reading a `)' and Deambiguate_CloseParens () was previously
16839 * expression.cs (ParenthesizedExpression): New class. This is
16840 just used for the CS0075 test.
16841 (Binary.DoResolve): Check for CS0075.
16843 2003-07-29 Ravi Pratap <ravi@ximian.com>
16845 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
16846 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
16847 reference comparison.
16849 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
16850 examine the ReturnType for equality - this is necessary in the
16851 cases of implicit and explicit operators whose signature also
16852 includes the return type.
16854 2003-07-26 Miguel de Icaza <miguel@ximian.com>
16856 * namespace.cs: Cache the result of the namespace computation,
16857 instead of computing it every time.
16859 2003-07-24 Miguel de Icaza <miguel@ximian.com>
16861 * decl.cs: Use a global arraylist that we reuse over invocations
16862 to avoid excesive memory consumption. Reduces memory usage on an
16863 mcs compile by one meg (45 average).
16865 * typemanager.cs (LookupTypeReflection): In .NET pointers are
16866 private, work around that.
16868 2003-07-23 Miguel de Icaza <miguel@ximian.com>
16870 * literal.cs (IntLiteral): Define Zero and One static literals.
16872 * cs-parser.jay (integer_literal): use static literals to reduce
16873 memory usage for the most used literals (0, 1 and -1). 211kb
16874 reduced in memory usage.
16876 Replace all calls to `new ArrayList' with `new
16877 ArrayList(4)' which is a good average number for most allocations,
16878 and also requires only 16 bytes of memory for its buffer by
16881 This reduced MCS memory usage in seven megabytes for the RSS after
16884 2003-07-28 Ravi Pratap <ravi@ximian.com>
16886 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
16887 handle params methods the correct way by forming only one
16888 applicable set with params and normal methods in them. Earlier we
16889 were looking at params methods only if we found no normal methods
16890 which was not the correct thing to do.
16892 (Invocation.BetterFunction): Take separate arguments indicating
16893 when candidate and the best method are params methods in their
16896 This fixes bugs #43367 and #46199.
16898 * attribute.cs: Documentation updates.
16900 (CheckAttribute): Rename to CheckAttributeTarget.
16901 (GetValidPlaces): Rename to GetValidTargets.
16903 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
16904 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
16908 2003-07-28 Martin Baulig <martin@ximian.com>
16910 * class.cs (TypeContainer.DefineMembers): Use the base type's full
16911 name when looking up the base class of a nested class. Fixes #46977.
16913 2003-07-26 Martin Baulig <martin@ximian.com>
16915 * expression.cs (Indexers.Indexer): New nested struct; contains
16916 getter, setter and the indexer's type.
16917 (Indexers.Properties): This is now an ArrayList of
16918 Indexers.Indexer's.
16919 (IndexerAccess.DoResolveLValue): Correctly set the type if the
16920 indexer doesn't have any getters.
16922 * assign.cs (Assign.DoResolve): Also do the implicit conversions
16923 for embedded property and indexer assignments.
16925 2003-07-26 Martin Baulig <martin@ximian.com>
16927 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
16928 preprocessor directive is not the first non-whitespace character
16931 2003-07-26 Martin Baulig <martin@ximian.com>
16933 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
16934 namespace parsing, follow the spec more closely.
16936 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
16937 NamespaceEntry.Lookup().
16939 2003-07-25 Martin Baulig <martin@ximian.com>
16941 * MethodCore.cs (OverridesSomething): New public field; it's set
16942 from TypeContainer.DefineMembers if this method overrides
16943 something (which doesn't need to be a method). Fix #39462.
16945 2003-07-25 Ravi Pratap <ravi@ximian.com>
16947 * typemanager.cs (GetMembers): Ensure that the list of members is
16948 reversed. This keeps things in sync.
16950 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
16951 find an AttributeUsage attribute.
16953 * expression.cs (Invocation.OverloadResolve): Perform the check
16954 which disallows Invoke to be directly called on a Delegate.
16956 (Error_InvokeOnDelegate): Report error cs1533.
16958 2003-07-25 Martin Baulig <martin@ximian.com>
16960 * expression.cs (Indexers.GetIndexersForType): Only look in the
16961 interface hierarchy if the requested type is already an
16962 interface. Fixes #46788 while keeping #46502 fixed.
16964 2003-07-25 Martin Baulig <martin@ximian.com>
16966 * class.cs (TypeContainer.DefineMembers): Check whether all
16967 readonly fields have been assigned and report warning CS0649 if
16970 * statement.cs (LocalInfo.IsFixed): Always return true if this is
16973 2003-07-24 Ravi Pratap <ravi@ximian.com>
16975 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
16976 returned from GetMethods to make things consistent with the
16977 assumptions MCS makes about ordering of methods.
16979 This should comprehensively fix bug #45127 and it does :-)
16981 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
16982 ordering is actually reverse.
16984 * Clean up some debug messages I left lying around.
16986 * interface.cs (Populate*): Get rid of code which emits attributes
16987 since the stage in which we emit attributes is the 'Emit' stage,
16988 not the define stage.
16990 (Emit): Move attribute emission for interface members here.
16992 2003-07-22 Ravi Pratap <ravi@ximian.com>
16994 * expression.cs (Invocation.OverloadResolve): Follow the spec more
16995 closely: we eliminate methods in base types when we have an
16996 applicable method in a top-level type.
16998 Please see section 14.5.5.1 for an exact description of what goes
17001 This fixes bug #45127 and a host of other related to corlib compilation.
17003 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
17004 array is the method corresponding to the top-level type (this is
17005 because of the changes made to icall.c) so we change this
17008 (MethodGroupExpr.Name): This too.
17010 * typemanager.cs (GetElementType): New method which does the right
17011 thing when compiling corlib.
17013 * everywhere: Make use of the above in the relevant places.
17015 2003-07-22 Martin Baulig <martin@ximian.com>
17017 * cs-parser.jay (invocation_expression): Moved
17018 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
17019 `cast_expression', but create a InvocationOrCast which later
17020 resolves to either an Invocation or a Cast.
17022 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
17023 method; call this before EmitStatement() to make sure that this
17024 expression can be used as a statement.
17026 * expression.cs (InvocationOrCast): New class; resolves to either
17027 an Invocation or a Cast.
17029 * statement.cs (StatementExpression): Call ResolveStatement() on
17030 the ExpressionStatement before emitting it.
17032 2003-07-21 Martin Baulig <martin@ximian.com>
17034 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
17035 `ref' and `out' attributes match; fixes #46220.
17036 (MemberAccess.ResolveMemberAccess): You can't reference a type
17037 through an expression; fixes #33180.
17038 (Indexers.GetIndexersForType): Don't return the indexers from
17039 interfaces the class implements; fixes #46502.
17041 2003-07-21 Martin Baulig <martin@ximian.com>
17043 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
17044 CS0661 checks; fixes bug #30442.
17046 2003-07-21 Martin Baulig <martin@ximian.com>
17048 * decl.cs (AdditionResult): Added `Error'.
17050 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
17052 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
17053 makes cs0031.cs actually work.
17055 2003-07-20 Martin Baulig <martin@ximian.com>
17057 * namespace.cs: Fixed that bug which caused a crash when compiling
17058 the debugger's GUI.
17060 2003-07-20 Miguel de Icaza <miguel@ximian.com>
17062 * typemanager.cs (LookupTypeReflection): Never expose types which
17063 are NotPublic, NestedPrivate, NestedAssembly, or
17064 NestedFamANDAssem. We used to return these, and later do a check
17065 that would report a meaningful error, but the problem is that we
17066 would not get the real match, if there was a name override.
17068 2003-07-18 Miguel de Icaza <miguel@ximian.com>
17070 * namespace.cs (Namespace, Name): Do not compute the namespace
17071 name dynamically, compute it in the constructor. This reduced
17072 memory usage by 1697 KB.
17074 * driver.cs: Use --pause to pause at the end.
17076 2003-07-17 Peter Williams <peter@newton.cx>
17078 * Makefile: Change the name of the test target so that it doesn't
17079 conflict with the recursive test target.
17081 2003-07-17 Miguel de Icaza <miguel@ximian.com>
17083 * expression.cs (LocalVariableReference.Emit, EmitAssign,
17084 AddressOf): Do not use EmitThis, that was wrong, use the actual
17087 2003-07-15 Miguel de Icaza <miguel@ximian.com>
17089 * class.cs (MethodData.Define): While checking if a method is an
17090 interface implementation, improve the test: If we are not public
17091 (use new test here: use the computed MethodAttributes directly,
17092 instead of the parsed modifier flags) check if the `implementing'
17093 method comes from an interface or not.
17095 * pending.cs (VerifyPendingMethods): Slightly better error
17098 * makefile: add test target that does the mcs bootstrap.
17100 2003-07-16 Ravi Pratap <ravi@ximian.com>
17102 * interface.cs (Define): Do nothing here since there are no
17103 members to populate etc. Move the attribute emission out of here
17104 since this was just totally the wrong place to put it. Attribute
17105 application happens during the 'Emit' phase, not in the 'Define'
17108 (Emit): Add this method and move the attribute emission here
17110 * rootcontext.cs (EmitCode): Call the Emit method on interface
17113 2003-07-14 Ravi Pratap M <ravi@ximian.com>
17115 * expression.cs (OverloadResolve): Report error only if Location
17116 is not 'Null' which means that there was a probe going on.
17118 2003-07-14 Martin Baulig <martin@ximian.com>
17120 * expression.cs (ConditionalLogicalOperator): New public class to
17121 implement user defined conditional logical operators.
17122 This is section 14.11.2 in the spec and bug #40505.
17124 2003-07-14 Martin Baulig <martin@ximian.com>
17126 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
17128 2003-07-14 Martin Baulig <martin@ximian.com>
17130 * codegen.cs (EmitContext.InFixedInitializer): New public field.
17132 * ecore.cs (IVariable.VerifyFixed): New interface method.
17134 * expression.cs (Unary.ResolveOperator): When resolving the `&'
17135 operator, check whether the variable is actually fixed. Fixes bug
17136 #36055. Set a variable definitely assigned when taking its
17137 address as required by the spec.
17139 * statement.cs (LocalInfo.IsFixed): New field.
17140 (LocalInfo.MakePinned): Set `IsFixed' to true.
17142 2003-07-14 Ravi Pratap M <ravi@ximian.com>
17144 * attribute.cs (Attribute.Resolve): While doing a Member lookup
17145 for .ctors, ensure that we only ask for members declared in the
17146 attribute type (BindingFlags.DeclaredOnly).
17150 * expression.cs (Error_WrongNumArguments): Report error 1501
17151 correctly the way CSC does.
17153 2003-07-13 Martin Baulig <martin@ximian.com>
17155 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
17156 lookup on the fully qualified name, to make things like "X.X" work
17157 where "X.X" is a fully qualified type name, but we also have a
17158 namespace "X" in the using list. Fixes #41975.
17160 2003-07-13 Martin Baulig <martin@ximian.com>
17162 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
17163 function. If we're a CompoundAssign, we need to create an embedded
17164 CompoundAssign, not an embedded Assign.
17165 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
17168 2003-07-13 Martin Baulig <martin@ximian.com>
17170 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
17171 work to fix bug #46088.
17173 2003-07-13 Ravi Pratap <ravi@ximian.com>
17175 * class.cs (Operator.Emit): Do not emit attributes here - it is
17176 taken care of by the Method class that we delegate too. This takes
17177 care of bug #45876.
17179 2003-07-10 Martin Baulig <martin@ximian.com>
17181 * expression.cs (TypeOfVoid): New class.
17182 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
17184 2003-07-10 Martin Baulig <martin@ximian.com>
17186 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
17189 2003-07-10 Martin Baulig <martin@ximian.com>
17191 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
17192 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
17194 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
17196 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
17198 2003-07-10 Martin Baulig <martin@ximian.com>
17200 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
17201 of decimal. Fixes #42850.
17203 NOTE: I also fixed the created byte blob, but this doesn't work on
17204 the MS runtime and csc never produces any byte blobs for decimal
17207 2003-07-10 Martin Baulig <martin@ximian.com>
17209 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
17210 structs; fixes #32068.
17211 (Block.AddChildVariableNames): Fixed #44302.
17213 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17215 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
17217 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17219 * attribute.cs: And this test is onger needed.
17221 2003-07-08 Martin Baulig <martin@ximian.com>
17223 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
17224 inaccessible types. Fixes #36313.
17226 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
17228 * namespace.cs (NamespaceEntry): Create implicit entries for all
17229 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
17230 implicit entries for N1.N2 and N1.
17232 2003-07-08 Martin Baulig <martin@ximian.com>
17234 Rewrote the handling of namespaces to fix a lot of the issues
17235 wrt. `using' aliases etc.
17237 * namespace.cs (Namespace): Splitted this class into a
17238 per-assembly `Namespace' and a per-file `NamespaceEntry'.
17240 * typemanager.cs (TypeManager.IsNamespace): Removed.
17241 (TypeManager.ComputeNamespaces): Only compute namespaces from
17242 loaded assemblies here, not the namespaces from the assembly we're
17243 currently compiling.
17245 2003-07-08 Martin Baulig <martin@ximian.com>
17247 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
17249 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17251 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
17254 I thought about the memory savings here, but LookupTypeReflection
17255 is used under already very constrained scenarios. Compiling
17256 corlib or mcs only exposes one hit, so it would not really reduce
17257 any memory consumption.
17259 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17261 * typemanager.cs: fixes bug #45889 by only adding public types from
17262 other assemblies to the list of known types.
17264 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17266 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
17267 on the type we resolved.
17269 2003-07-05 Martin Baulig <martin@ximian.com>
17271 * pending.cs (PendingImplementation.ParentImplements): Don't
17272 create the proxy if the parent is abstract.
17274 * class.cs (TypeContainer.DefineIndexers): Process explicit
17275 interface implementations first. Fixes #37714.
17277 2003-07-04 Miguel de Icaza <miguel@ximian.com>
17279 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
17280 defined recursively; but since we modify the input parameters
17281 (left is set to `this' temporarily), we reset this value if the
17282 left_is_explicit is false, which gives the original semantics to
17285 * literal.cs (NullPointer): new class used to represent a null
17286 literal in a pointer context.
17288 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
17289 type is a pointer, use a NullPointer object instead of a
17290 NullLiteral. Closes 43687
17292 (ExplicitConversion): Convert pointer values using
17293 the conv opcode to the proper type.
17295 * ecore.cs (New): change ValueTypeVariable property into a method,
17296 that returns whether the valuetype is suitable for being used.
17298 * expression.cs (Binary.DoNumericPromotions): Only return if we
17299 the int constant was a valid uint, and we can return both left and
17300 right as uints. If not, we continue processing, to trigger the
17301 type conversion. This fixes 39018.
17303 * statement.cs (Block.EmitMeta): During constant resolution, set
17304 the CurrentBlock property on the emitcontext, so that we resolve
17305 constants propertly.
17307 2003-07-02 Martin Baulig <martin@ximian.com>
17309 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
17310 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
17312 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
17313 than emitting it here.
17315 * statement.cs: Fixed some more flow analysis bugs.
17317 2003-07-02 Martin Baulig <martin@ximian.com>
17319 * class.cs (MethodData.Define): When implementing interface
17320 methods, set Final unless we're Virtual.
17322 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
17323 check work for interface methods.
17325 2003-07-01 Martin Baulig <martin@ximian.com>
17327 * ecore.cs (EmitContext.This): Replaced this property with a
17328 GetThis() method which takes a Location argument. This ensures
17329 that we get the correct error location for a CS0188.
17331 2003-07-01 Miguel de Icaza <miguel@ximian.com>
17333 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
17334 ImplicitStandardConversion.
17336 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
17338 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
17340 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
17343 2003-06-30 Miguel de Icaza <miguel@ximian.com>
17345 * class.cs (Constructor.Define): Turn off initlocals for unsafe
17348 (MethodData.Define): Turn off initlocals for unsafe methods.
17350 2003-06-29 Miguel de Icaza <miguel@ximian.com>
17352 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
17353 complete; Fixes #37521.
17355 * delegate.cs: Use Modifiers.TypeAttr to compute the
17356 TypeAttributes, instead of rolling our own. This makes the flags
17357 correct for the delegates.
17359 2003-06-28 Miguel de Icaza <miguel@ximian.com>
17361 * class.cs (Constructor.Define): Set the private flag for static
17362 constructors as well.
17364 * cs-parser.jay (statement_expression): Set the return value to
17365 null, to avoid a crash when we catch an error.
17367 2003-06-24 Miguel de Icaza <miguel@ximian.com>
17369 * cs-parser.jay: Applied patch from Jackson that adds support for
17370 extern and unsafe modifiers to destructor declarations.
17372 * expression.cs: Report error 21 if the user is trying to index a
17375 * driver.cs: Add an error message, suggested by the bug report.
17377 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
17378 if we do not have a ": this ()" constructor initializer. Fixes 45149
17380 2003-06-14 Miguel de Icaza <miguel@ximian.com>
17382 * namespace.cs: Add some information to reduce FAQs.
17384 2003-06-13 Miguel de Icaza <miguel@ximian.com>
17386 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
17387 underlying enumeration types. Fixes #43915.
17389 * expression.cs: Treat ushort/short as legal values to be used in
17390 bitwise operations.
17392 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
17394 * delegate.cs: transfer custom attributes for paramenters from
17395 the delegate declaration to Invoke and BeginInvoke.
17397 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
17399 * attribute.cs: handle custom marshalers and emit marshal info
17402 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
17404 * makefile.gnu: Added anonymous.cs to the compiler sources.
17406 2003-05-28 Miguel de Icaza <miguel@ximian.com>
17408 * iterators.cs: Change the name of the proxy class to include two
17411 * cs-parser.jay: Update grammar to include anonymous methods.
17413 * anonymous.cs: new file.
17415 2003-05-27 Miguel de Icaza <miguel@ximian.com>
17417 * class.cs (Field.Define): Add missing test for pointers and
17420 2003-05-27 Ravi Pratap <ravi@ximian.com>
17422 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
17423 we use the stobj opcode.
17425 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
17426 since it wasn't the correct fix.
17428 It still is puzzling that we are required to use stobj for IntPtr
17429 which seems to be a ValueType.
17431 2003-05-26 Miguel de Icaza <miguel@ximian.com>
17433 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
17434 during regular simple name resolution. Now, the trick is that
17435 instead of returning for processing the simplename, we do a
17436 TypeManager.LookupType (ie, a rooted lookup as opposed to a
17437 contextual lookup type). If a match is found, return that, if
17438 not, return for further composition.
17440 This fixes long-standing 30485.
17442 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
17443 using the address to initialize an object, do an Stobj instead of
17444 using the regular Stelem.
17446 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
17447 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
17448 Because if we are a BaseIndexerAccess that value will be true.
17451 * statement.cs (GotoCase.Resolve): Return after reporting an
17452 error, do not attempt to continue.
17454 * expression.cs (PointerArithmetic.Emit): If our operand is a
17455 long, convert our constants to match the operand before
17456 multiplying. Convert to I type before adding. Fixes 43670.
17458 2003-05-14 Ravi Pratap <ravi@ximian.com>
17460 * enum.cs (ImplicitConversionExists) : Rename to
17461 ImplicitEnumConversionExists to remove ambiguity.
17463 * ecore.cs (NullCast): New type of cast expression class which
17464 basically is very similar to EmptyCast with the difference being
17465 it still is a constant since it is used only to cast a null to
17467 (eg. (string) null)
17469 * convert.cs (ImplicitReferenceConversion): When casting a null
17470 literal, we return a NullCast.
17472 * literal.cs (NullLiteralTyped): Remove - I don't see why this
17473 should be around anymore.
17475 The renaming (reported was slightly wrong). Corrections:
17477 ConvertImplicitStandard -> ImplicitConversionStandard
17478 ConvertExplicitStandard -> ExplicitConversionStandard
17480 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
17481 before passing them in !
17483 * convert.cs (ImplicitConversionStandard): When comparing for
17484 equal expr and target types, ensure that expr is not a
17487 In general, we must not be checking (expr_type ==
17488 target_type) in the top level conversion methods
17489 (ImplicitConversion, ExplicitConversion etc). This checking is
17490 done in the methods that they delegate to.
17492 2003-05-20 Miguel de Icaza <miguel@ximian.com>
17494 * convert.cs: Move Error_CannotConvertType,
17495 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
17496 ImplicitNumericConversion, ImplicitConversionExists,
17497 ImplicitUserConversionExists, StandardConversionExists,
17498 FindMostEncompassedType, FindMostSpecificSource,
17499 FindMostSpecificTarget, ImplicitUserConversion,
17500 ExplicitUserConversion, GetConversionOperators,
17501 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
17502 TryImplicitIntConversion, Error_CannotConvertImplicit,
17503 ConvertImplicitRequired, ConvertNumericExplicit,
17504 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
17505 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
17508 Perform the following renames:
17510 StandardConversionExists -> ImplicitStandardConversionExists
17511 ConvertImplicit -> ImplicitConversion
17512 ConvertImplicitStandard -> ImplicitStandardConversion
17513 TryImplicitIntConversion -> ImplicitIntConversion
17514 ConvertImplicitRequired -> ImplicitConversionRequired
17515 ConvertNumericExplicit -> ExplicitNumericConversion
17516 ConvertReferenceExplicit -> ExplicitReferenceConversion
17517 ConvertExplicit -> ExplicitConversion
17518 ConvertExplicitStandard -> ExplicitStandardConversion
17520 2003-05-19 Martin Baulig <martin@ximian.com>
17522 * statement.cs (TypeInfo.StructInfo): Made this type protected.
17523 (TypeInfo): Added support for structs having structs as fields.
17525 * ecore.cs (FieldExpr): Implement IVariable.
17526 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
17527 VariableInfo for the field.
17529 2003-05-18 Martin Baulig <martin@ximian.com>
17531 * expression.cs (This.DoResolve): Report a CS0027 if we're
17532 emitting a field initializer.
17534 2003-05-18 Martin Baulig <martin@ximian.com>
17536 * expression.cs (This.ResolveBase): New public function.
17537 (This.DoResolve): Check for CS0188.
17539 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
17542 * ecore.cs (MethodGroupExpr.DoResolve): Set the
17543 `instance_expression' to null if we don't have any non-static
17546 2003-05-18 Martin Baulig <martin@ximian.com>
17548 Reworked the way how local variables and parameters are handled by
17549 the flow analysis code.
17551 * statement.cs (TypeInfo, VariableMap): New public classes.
17552 (VariableInfo): New public class. This is now responsible for
17553 checking whether a variable has been assigned. It is used for
17554 parameters and local variables.
17555 (Block.EmitMeta): Take the InternalParameters as argument; compute
17556 the layout of the flow vectors here.
17557 (Block.LocalMap, Block.ParameterMap): New public properties.
17558 (FlowBranching): The .ctor doesn't get the InternalParameters
17559 anymore since Block.EmitMeta() now computes the layout of the flow
17561 (MyStructInfo): This class is now known as `StructInfo' and nested
17562 in `TypeInfo'; we don't access this directly anymore.
17564 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
17565 property and removed IsAssigned(), IsFieldAssigned(),
17566 SetAssigned() and SetFieldAssigned(); we now call them on the
17567 VariableInfo so we don't need to duplicate this code everywhere.
17569 * expression.cs (ParameterReference): Added `Block block' argument
17571 (LocalVariableReference, ParameterReference, This): The new
17572 VariableInfo class is now responsible for all the definite
17575 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
17576 IsParameterAssigned, SetParameterAssigned): Removed.
17578 2003-05-18 Martin Baulig <martin@ximian.com>
17580 * typemanager.cs (InitCoreTypes): Try calling
17581 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
17582 the 3-args-version. Corlib now also needs our `void_type'.
17583 (GetMethod): Added overloaded version which takes an optional
17584 `bool report_errors' to allow lookups of optional methods.
17586 2003-05-12 Martin Baulig <martin@ximian.com>
17588 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
17589 only used for locals and not for parameters.
17591 2003-05-12 Miguel de Icaza <miguel@ximian.com>
17593 * support.cs (InternalParameters.ParameterType): Return the
17594 ExternalType of the parameter.
17596 * parameter.cs (Parameter.ExternalType): drop the two arguments,
17599 2003-05-11 Miguel de Icaza <miguel@ximian.com>
17601 * class.cs (MethodData.Define): Do not set the `newslot' on
17602 interface members, if they are also flagged as "override".
17604 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
17605 better code for ++i and i++. This only works for static fields
17606 and local variables.
17608 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
17609 want to pull the DeclSpace out of the builder_to_declspace instead
17610 of the TypeBuilder (like in TypeContainer.FindMembers).
17612 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
17613 instead of LookupTypeContainer. Fixes the crash on .NET for
17614 looking up interface members.
17616 * const.cs: Create our own emit context during the Definition
17617 stage, so that constants are evaluated in the proper context, when
17618 a recursive definition happens.
17620 2003-05-11 Martin Baulig <martin@ximian.com>
17622 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
17623 new block for a switch section.
17624 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
17625 the adding/lookup in the switch block. Fixes #39828.
17627 2003-05-09 Miguel de Icaza <miguel@ximian.com>
17629 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
17630 functionality: I needed to convert the data after I had performed
17631 the add/sub operation into the operands type size.
17633 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
17634 pass the type for the box operation, otherwise the resulting
17635 object would have been of type object.
17637 (BoxedCast): Add constructor to specify the type to box as.
17639 2003-05-07 Miguel de Icaza <miguel@ximian.com>
17641 * iterators.cs: I was reusing the `count' variable inadvertently,
17642 take steps to not allow this to happen.
17644 2003-05-06 Miguel de Icaza <miguel@ximian.com>
17646 * attribute.cs (Attribute.Resolve): Params attributes are encoded
17647 by creating an array at the point where the params starts and
17648 putting all those arguments there, then adjusting the size of the
17651 2003-05-05 Miguel de Icaza <miguel@ximian.com>
17653 * expression.cs (New.AddressOf): Implement interface
17654 IMemoryLocation. This is used when the `new' operator is used in
17655 the context of an invocation to a method on a value type.
17657 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
17660 * namespace.cs: Also check the using aliases here.
17662 * driver.cs: Move the test for using validity after the types have
17663 been entered, so we do a single pass that also includes the using
17666 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
17667 in the regular case. CreateSiblingForFinally is doing extra
17670 * attribute.cs (GetAttributeArgumentExpression): Store the result
17671 on an out value, and use the return value to indicate failure
17672 instead of using null (which is a valid return for Constant.GetValue).
17674 * statement.cs: Perform the analysis flow for the increment
17675 portion after the statement, because this will be the real flow of
17676 execution. Fixes #42385
17678 * codegen.cs (EmitContext.EmitArgument,
17679 EmitContext.EmitStoreArgument): New helper functions when the
17680 RemapToProxy flag is set.
17682 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
17685 Add support for remapping parameters.
17687 * iterators.cs: Propagate parameter values; Store parameter
17688 values in the proxy classes.
17690 2003-05-04 Miguel de Icaza <miguel@ximian.com>
17692 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
17693 need a proxy reference; I do not know what I was thinking
17695 * cs-parser.jay (constructor_initializer): catch another error,
17696 and display nice message.
17698 (field_declaration): catch void field declaration
17699 to flag a better error.
17701 * class.cs (MemberBase.CheckBase): Report an error instead of a
17702 warning if a new protected member is declared in a struct.
17703 (Field.Define): catch the error of readonly/volatile.
17705 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
17707 (FieldExpr.AddressOf): ditto. Catch error where the address of a
17708 volatile variable is taken
17710 2003-05-02 Miguel de Icaza <miguel@ximian.com>
17712 * statement.cs (Fixed.Resolve): Report an error if we are not in
17715 2003-05-01 Miguel de Icaza <miguel@ximian.com>
17717 * typemanager.cs: reuse the code that handles type clashes for
17718 delegates and enumerations.
17720 * class.cs (Report28): Always report.
17722 * expression.cs (EncodeAsAttribute): Allow nulls here.
17724 2003-04-28 Miguel de Icaza <miguel@ximian.com>
17726 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
17727 the functionality for testing whether an expression is valid for
17728 an attribute here. Also handle the case of arrays of elements
17731 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
17732 encoding a linear array into an array of objects that are suitable
17733 to be passed to an CustomAttributeBuilder.
17735 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
17737 * ecore.cs: (FieldExpr): Handle field remapping here.
17739 * iteratators.cs: Pass the instance variable (if the method is an
17740 instance method) to the constructors, so we can access the field
17741 variables on the class.
17743 TODO: Test this with structs. I think the THIS variable on
17744 structs might have to be a pointer, and not a refenrece
17746 2003-04-27 Miguel de Icaza <miguel@ximian.com>
17748 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
17749 local variables to fields in a proxy class.
17751 * iterators.cs (PopulateProxy): Rename our internal fields to
17753 Create a <THIS> field if we are an instance method, so we can
17754 reference our parent container variables.
17755 (MapVariable): Called back from the EmitContext code to enter a
17756 new variable to field mapping into the proxy class (we just create
17760 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
17761 for using the remapped locals to fields.
17763 I placed the code here, because that gives the same semantics to
17764 local variables, and only changes the Emit code.
17766 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
17767 statements inside iterators.
17768 (VariableInfo): Add a FieldBuilder for the cases when we are
17769 remapping local variables to fields in a proxy class
17771 * ecore.cs (SimpleNameResolve): Avoid testing two times for
17772 current_block != null.
17774 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
17775 not cope with strings, as it has been moved to the
17776 TableSwitchEmit. Fixed bug in switch generation.
17778 * expression.cs (New.DoResolve): Provide more context for the user
17779 when reporting an error.
17781 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
17784 * expression.cs (MemberAccess.DoResolve): When we get a type back,
17785 check the permissions for it. Note than in a type-resolution
17786 context the check was already present in DeclSpace.ResolveType,
17787 but was missing from the MemberAccess.
17789 (ArrayCreation.CheckIndices): warn if the user has
17790 more nested levels of expressions, but there are no more
17791 dimensions specified. Avoids crash on bug 41906.
17793 2003-04-26 Miguel de Icaza <miguel@ximian.com>
17795 * statement.cs (Block): replace Implicit bool, for a generic
17797 New flag: `Unchecked'. This is used during the EmitMeta phase
17798 (which is out-of-line with the regular Resolve/Emit process for a
17799 statement, as this is done ahead of time, but still gets a chance
17800 to call constant resolve).
17802 (Block.Flags): new enum for adding a new flag.
17804 (Block.EmitMeta): track the state of unchecked.
17806 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
17807 to enable constant resolution to work there as well.
17809 2003-04-22 Miguel de Icaza <miguel@ximian.com>
17811 * typemanager.cs (ienumerable_type): Also look up
17812 System.Collections.IEnumerable.
17814 2003-04-21 Miguel de Icaza <miguel@ximian.com>
17816 TODO: Test more than one conditional per method.
17818 * class.cs (Indexer.Define): Report the location where the user is
17819 referencing the unsupported feature.
17821 (MethodData): Overload the use of `conditionals' to
17822 minimize the creation of needless ArrayLists. This saves roughly
17823 212kb on my machine.
17825 (Method): Implement the new IIteratorContainer interface.
17826 (Method.SetYields): Implement the method by setting the ModFlags
17827 to contain METHOD_YIELDS.
17829 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
17830 which just got set to null.
17832 * iterators.cs: New file.
17834 (Yield, YieldBreak): New statements.
17836 * statement.cs (Return.Resolve): Flag an error if we are used in
17837 an iterator method.
17839 * codegen.cs (InIterator): New flag set if the code is being
17840 compiled in an iterator method.
17842 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
17843 internal modifier, and we just use it to avoid adding extra
17844 fields, as this is seldom used.
17846 * cs-parser.jay: Add yield_statement (yield and yield break).
17848 * driver.cs: New flag -v2 to turn on version 2 features.
17850 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
17851 hashtable when v2 is enabled.
17853 2003-04-20 Miguel de Icaza <miguel@ximian.com>
17855 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
17856 there is already a namespace defined with this name.
17858 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
17859 people upgraded their corlibs.
17861 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
17862 always use fully qualified types, no need to use the compiler
17865 (TypeManager.IsNamespace): Use binarysearch.
17867 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
17868 AddDelegate): I did not quite use the new IsValid API properly: I
17869 have to pass the short-name and the fullname. I was passing only
17870 the basename instead of the fullname sometimes.
17872 (TypeContainer.DefineType): call NamespaceClash.
17874 * interface.cs (Interface.DefineType): use NamespaceClash before
17877 * delegate.cs (Delegate.DefineType): use NamespaceClash before
17880 * enum.cs: (Enum.DefineType): use NamespaceClash before
17883 * typemanager.cs (: 3-line patch that gives us some tasty 11%
17884 speed increase. First, use the negative_hits cache when we get a
17885 negative. Second, add the type with its full original name
17886 instead of the new . and + encoded name (reflection uses + to
17887 separate type from a nested type). Use LookupTypeReflection
17888 directly which bypasses the type->name hashtable (that we already
17889 know does not contain the type.
17891 * decl.cs (DeclSpace.ResolveTypeExpr): track the
17892 location/container type.
17894 * driver.cs: When passing utf8, use directly the UTF8Encoding.
17896 2003-04-19 Miguel de Icaza <miguel@ximian.com>
17898 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
17900 * delegate.cs (NewDelegate.Resolve): Test whether an instance
17901 method is being referenced in the method group from a static
17902 context, and report error 120 if so.
17904 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
17907 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
17908 is created, we create the A namespace).
17910 * cs-parser.jay: A namespace also introduces a DeclarationFound.
17913 2003-04-18 Miguel de Icaza <miguel@ximian.com>
17915 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
17916 invocation to ModuleBuilder.GetType with the same values will
17917 return a new type instance, so we need to cache its return
17920 * expression.cs (Binary.ResolveOperator): Only allow the compare
17921 operators on enums if they are of the same type.
17923 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
17924 types of ValueType on their own case. Before we were giving them
17925 the same treatment as objects.
17927 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
17928 fullname. Short name is used to compare against container name.
17929 Fullname is used to check against defined namespace names.
17931 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
17932 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
17934 (Method.CheckBase): Call parent.
17935 (MemberBase.CheckBase): Check for protected members on sealed
17937 (PropertyBase.CheckBase): Call parent.
17938 (Field.Define): Call parent.
17940 * report.cs: Negative error codes are now mapped to 8000 - code,
17941 so that the display is render more nicely.
17943 * typemanager.cs: Do not use try/catch, instead report a regular
17946 (GetPointerType, GetReferenceType): These methods provide
17947 mechanisms to obtain the T* and T& from a T. We had the code
17948 previously scattered around the code base, and it also used
17949 TypeManager.LookupType that would go through plenty of caches.
17950 This one goes directly to the type source.
17952 In some places we did the Type.GetType followed by
17953 ModuleBuilder.GetType, but not in others, so this unifies the
17954 processing as well.
17956 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
17957 statements now that we have namespace information.
17959 * typemanager.cs (IsNamespace): New method, returns whether the
17960 string presented is a namespace or not.
17962 (ComputeNamespaces): New public entry point, computes the list of
17963 available namespaces, using the GetNamespaces API call in Mono, or
17964 the slower version in MS.NET.
17966 Now before we start the semantic analysis phase, we have a
17967 complete list of namespaces including everything that the user has
17970 Deleted old code to cache namespaces in .nsc files.
17972 2003-04-17 Miguel de Icaza <miguel@ximian.com>
17974 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
17975 class/struct location definition Location for the implicit
17976 constructor location.
17978 (Operator.Define): Use the location of the operator for the
17979 implicit Method definition.
17981 (Constructor.Emit): use the constructor location for the implicit
17982 base initializer constructor.
17984 * ecore.cs: Remove ITypeExpression. This interface is now gone,
17985 and the Expression class now contains two new methods:
17987 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
17988 isolate type lookup from the rest of the resolution process.
17990 Since we use Expressions to hold type definitions due to the way
17991 we parse the input we have historically overloaded Resolve to
17992 perform the Type lookups if a special flag is passed. Now this is
17993 eliminated and two methods take their place.
17995 The differences in the two methods between xStep and xTerminal is
17996 that xStep is involved in our current lookup system that uses
17997 SimpleNames to compose a name, while xTerminal is used just to
17998 catch the case where the simplename lookup failed.
18000 2003-04-16 Miguel de Icaza <miguel@ximian.com>
18002 * expression.cs (ResolveMemberAccess): Remove redundant code.
18003 TypeExpr expressions are always born fully resolved.
18005 * interface.cs (PopulateMethod): Do not lookup the types twice.
18006 We were doing it once during SemanticAnalysis and once during
18009 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
18010 in local variable type definitions, were being returned as a
18011 SimpleName (we decomposed everything into a string), that is
18012 because primary_expression was being used instead of a type in the
18013 grammar (reduce/reduce conflicts).
18015 The part that was wrong is that we converted the expression into a
18016 string (an oversimplification in one hand, compounded with primary
18017 expressions doing string concatenation).
18023 Would return "A.B.C[]" as a SimpleName. This stopped things like
18024 using clauses from working on this particular context. And a type
18025 was being matched directly against "A.B.C[]".
18027 We now use the correct approach, and allow for ComposedCast to be
18028 part of the unary expression. So the "A.B.C []" become a composed
18029 cast of "A.B.C" (as a nested group of MemberAccess with a
18030 SimpleName at the end) plus the rank composition "[]".
18034 2003-04-10 Miguel de Icaza <miguel@ximian.com>
18036 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
18037 for the access level checking.
18039 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
18040 `TypeContainer container', because I kept getting confused when I
18041 was debugging this code.
18043 * expression.cs (Indexers): Instead of tracking getters/setters,
18044 we now track them in parallel. We create one arraylist less, but
18045 most importantly it is possible now for the LValue code to find a
18046 matching get for a set.
18048 (IndexerAccess.DoResolveLValue): Update the code.
18049 GetIndexersForType has been modified already to extract all the
18050 indexers from a type. The code assumed it did not.
18052 Also make the code set the correct return type for the indexer.
18053 This was fixed a long time ago for properties, but was missing for
18054 indexers. It used to be void_type.
18056 (Binary.Emit): Test first for doubles instead of
18057 floats, as they are more common.
18059 (Binary.EmitBranchable): Use the .un version of the branch opcodes
18060 when dealing with floats and the <=, >= operators. This fixes bug
18063 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
18064 to load the array value by emitting a load on the foreach variable
18065 type. This was incorrect.
18067 We now emit the code to load an element using the the array
18068 variable type, and then we emit the conversion operator.
18072 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
18074 * attribute.cs: Avoid allocation of ArrayLists in the common case.
18076 2003-04-09 Miguel de Icaza <miguel@ximian.com>
18078 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
18079 test for protection before we test for signatures.
18081 (MethodSignature.ToString): implement.
18083 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
18084 to the case where we reduced into a LongConstant.
18086 * decl.cs (CheckAccessLevel): If the type is an array, we can not
18087 depend on whether the information is acurrate, because the
18088 Microsoft runtime will always claim that the array type is public,
18089 regardless of the real state.
18091 If the type is a pointer, another problem happens: the type is
18092 reported as non-public in Microsoft.
18094 In both cases we have to call CheckAccessLevel recursively with
18095 the underlying type as the argument to be tested.
18097 2003-04-08 Miguel de Icaza <miguel@ximian.com>
18099 * assign.cs (Assign.Emit): If we are dealing with a compound
18100 assignment expression, we should use the code path that stores the
18101 intermediate result in a temporary value. This fixes #40903.
18103 *expression.cs (Indirection.ToString): Provide ToString method for
18106 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
18108 * class.cs: Null out fields holding references to Block objects so
18109 they can be garbage collected.
18111 * expression.cs (OverloadResolve): Remove unused local.
18113 2003-04-07 Martin Baulig <martin@ximian.com>
18115 * codegen.cs (EmitContext.CurrentFile): New public field.
18116 (EmitContext.Mark): Use the CurrentFile to check whether the
18117 location is in the correct file.
18118 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
18120 2003-04-07 Martin Baulig <martin@ximian.com>
18122 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
18124 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
18125 location. [FIXME: The location argument which gets passed to this
18126 method is sometimes wrong!]
18128 2003-04-07 Nick Drochak <ndrochak@gol.com>
18130 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
18132 2003-04-07 Miguel de Icaza <miguel@ximian.com>
18134 * expression.cs (Indirection.EmitAssign): We were using the
18135 temporary, but returning immediately instead of continuing the
18138 2003-04-06 Martin Baulig <martin@ximian.com>
18140 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
18141 if it's a nested child, but also deriving from the outer class.
18144 * typemanager.cs (IsNestedChildOf): Make this work if it's a
18145 nested child, but also deriving from the outer class. See
18147 (FilterWithClosure): We may access private members of the outer
18148 class if we're a nested child and deriving from the outer class.
18149 (RealMemberLookup): Only set `closure_private_ok' if the
18150 `original_bf' contained BindingFlags.NonPublic.
18152 2003-04-05 Martin Baulig <martin@ximian.com>
18154 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
18156 2003-04-02 Miguel de Icaza <miguel@ximian.com>
18158 * class.cs (Event.Define): Do not allow abstract events to have
18161 2003-04-01 Miguel de Icaza <miguel@ximian.com>
18163 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
18164 block in event declarations.
18166 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
18167 value type, get its address.
18169 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
18170 leaving a class on the stack instead of a boolean value (int
18171 0/1). Change the code so we compare against null, and then the
18172 result against zero.
18174 * class.cs (TypeContainer.GetClassBases): We were checking for the
18175 parent class being sealed too late.
18177 * expression.cs (Binary.Emit): For <= and >= when dealing with
18178 floating point values, use cgt.un and clt.un instead of cgt and
18181 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
18183 * statement.cs: Apply the same optimization as MS: skip the
18184 GetEnumerator returning an IEnumerator, and use the one returning a
18185 CharEnumerator instead. This allows us to avoid the try-finally block
18188 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
18190 * cs-parser.jay: Attributes cannot be applied to
18191 namespaces. Fixes #40473
18193 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18196 (Add*): check if the name is valid using the full name for constants,
18197 fields, properties and events.
18199 2003-03-28 Miguel de Icaza <miguel@ximian.com>
18201 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
18202 char constants to be part of the enumeration.
18204 * expression.cs (Conditional.DoResolve): Add support for operator
18205 true. Implements the missing functionality from 14.12
18207 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
18208 operator true/false as required by the spec.
18210 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
18211 implicit conversion to boolean.
18213 * statement.cs (Statement.ResolveBoolean): A boolean expression is
18214 also one where the type implements `operator true'.
18216 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
18217 get an expression that will invoke operator true based on an
18220 (GetConversionOperators): Removed the hack that called op_True
18223 (Expression.ResolveBoolean): Move this from Statement.
18225 2003-03-17 Miguel de Icaza <miguel@ximian.com>
18227 * ecore.cs (FieldExpr): do not allow initialization of initonly
18228 fields on derived classes
18230 2003-03-13 Martin Baulig <martin@ximian.com>
18232 * statement.cs (Block.Emit): Call ig.BeginScope() and
18233 ig.EndScope() when compiling with debugging info; call
18234 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
18236 2003-03-08 Miguel de Icaza <miguel@ximian.com>
18238 * expression.cs (Indexers): Do not construct immediately, allow
18239 for new members to be appended as we go. Fixes 38143
18241 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18243 * expression.cs: save/restore context when resolving an unchecked
18246 2003-03-05 Miguel de Icaza <miguel@ximian.com>
18248 * cfold.cs: Catch division by zero in modulus operator during
18251 2003-03-03 Miguel de Icaza <miguel@ximian.com>
18253 * interface.cs (Interface.DefineMembers): Avoid defining members
18256 2003-02-27 Miguel de Icaza <miguel@ximian.com>
18258 * driver.cs: handle the +/- options for -noconfig
18260 * statement.cs (Unckeched.Resolve): Also track the state of
18261 unchecked in the Resolve phase.
18263 2003-02-27 Martin Baulig <martin@ximian.com>
18265 * ecore.cs (Expression.MemberLookup): Don't create a
18266 MethodGroupExpr for something which is not a method. Fixes #38291.
18268 2003-02-25 Miguel de Icaza <miguel@ximian.com>
18270 * class.cs (MemberBase.CheckParameters): Also check that the type
18271 is unmanaged if it is a pointer.
18273 * expression.cs (SizeOf.Resolve): Add location information.
18275 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
18276 a managed type is declared.
18278 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
18279 parameter modifiers as well. Fixes bug 38606
18281 * class.cs: Very sad. Am backing out the speed up changes
18282 introduced by the ArrayList -> Array in the TypeContainer, as they
18283 were not actually that much faster, and introduced a bug (no error
18284 reports on duplicated methods).
18286 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
18287 source first, this will guarantee that we have a valid expression
18288 before calling in lower levels functions that will require a
18289 resolved object. Then use this original_source in the
18290 target.ResolveLValue instead of the original source that was
18293 Another change. Use target.Resolve instead of LValueResolve.
18294 Although we are resolving for LValues, we will let the Assign code
18295 take care of that (it will be called again from Resolve). This
18296 basically allows code like this:
18298 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
18299 class Y { void A (X x) { x [0] += o; }
18301 The problem was that the indexer was trying to resolve for
18302 set_Item (idx, object o) and never finding one. The real set_Item
18303 was set_Item (idx, X). By delaying the process we get the right
18308 2003-02-23 Martin Baulig <martin@ximian.com>
18310 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
18311 while calling DoEmit ().
18313 * codegen.cs (EmitContext.Mark): Don't mark locations in other
18314 source files; if you use the #line directive inside a method, the
18315 compiler stops emitting line numbers for the debugger until it
18316 reaches the end of the method or another #line directive which
18317 restores the original file.
18319 2003-02-23 Martin Baulig <martin@ximian.com>
18321 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
18323 2003-02-23 Martin Baulig <martin@ximian.com>
18325 * statement.cs (Block.AddChildVariableNames): We need to call this
18326 recursively, not just for our immediate children.
18328 2003-02-23 Martin Baulig <martin@ximian.com>
18330 * class.cs (Event.Define): Always make the field private, like csc does.
18332 * typemanager.cs (TypeManager.RealMemberLookup): Make events
18333 actually work, fixes bug #37521.
18335 2003-02-23 Miguel de Icaza <miguel@ximian.com>
18337 * delegate.cs: When creating the various temporary "Parameters"
18338 classes, make sure that we call the ComputeAndDefineParameterTypes
18339 on those new parameters (just like we do with the formal ones), to
18340 allow them to be resolved in the context of the DeclSpace.
18342 This fixes the bug that Dick observed in Bugzilla #38530.
18344 2003-02-22 Miguel de Icaza <miguel@ximian.com>
18346 * expression.cs (ResolveMemberAccess): When resolving a constant,
18347 do not attempt to pull a constant if the value was not able to
18348 generate a valid constant.
18350 * const.cs (LookupConstantValue): Do not report more errors than required.
18352 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18354 * expression.cs: fixes bug #38328.
18356 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18358 * class.cs: Changed all the various members that can be part of a
18359 class from being an ArrayList to be an Array of the right type.
18360 During the DefineType type_list, interface_list, delegate_list and
18361 enum_list are turned into types, interfaces, delegates and enums
18364 And during the member population, indexer_list, event_list,
18365 constant_list, field_list, instance_constructor_list, method_list,
18366 operator_list and property_list are turned into their real arrays.
18368 Although we could probably perform this operation earlier, for
18369 good error reporting we need to keep the lists and remove the
18370 lists for longer than required.
18372 This optimization was triggered by Paolo profiling the compiler
18373 speed on the output of `gen-sample-program.pl' perl script.
18375 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
18376 not crash in methods like MemberLookupFailed that use this field.
18378 This problem arises when the compiler fails to resolve a type
18379 during interface type definition for example.
18381 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18383 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
18384 inherit from System.Object, so we have to stop at null, not only
18385 when reaching System.Object.
18387 2003-02-17 Miguel de Icaza <miguel@ximian.com>
18389 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
18390 DeclaredOnly because the parent indexer might have had a different
18391 name, but did not loop until the top of the hierarchy was reached.
18393 The problem this one fixes is 35492: when a class implemented an
18394 indexer from an interface, we were getting the interface method
18395 (which was abstract) and we were flagging an error (can not invoke
18398 This also keeps bug 33089 functioning, and test-148 functioning.
18400 * typemanager.cs (IsSpecialMethod): The correct way of figuring
18401 out if a method is special is to see if it is declared in a
18402 property or event, or whether it is one of the predefined operator
18403 names. This should fix correctly #36804.
18405 2003-02-15 Miguel de Icaza <miguel@ximian.com>
18407 The goal here is to remove the dependency on EmptyCast.Peel ().
18408 Killing it completely.
18410 The problem is that currently in a number of places where
18411 constants are expected, we have to "probe" for an EmptyCast, and
18412 Peel, which is not the correct thing to do, as this will be
18413 repetitive and will likely lead to errors.
18415 The idea is to remove any EmptyCasts that are used in casts that
18416 can be reduced to constants, so we only have to cope with
18419 This bug hunt was triggered by Bug 37363 and the desire to remove
18420 the duplicate pattern where we were "peeling" emptycasts to check
18421 whether they were constants. Now constants will always be
18424 * ecore.cs: Use an enumconstant here instead of wrapping with
18427 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
18428 throwing me off. By handling this we can get rid of a few hacks.
18430 * statement.cs (Switch): Removed Peel() code.
18432 2003-02-14 Miguel de Icaza <miguel@ximian.com>
18434 * class.cs: Location information for error 508
18436 * expression.cs (New.DoResolve): Add a guard against double
18437 resolution of an expression.
18439 The New DoResolve might be called twice when initializing field
18440 expressions (see EmitFieldInitializers, the call to
18441 GetInitializerExpression will perform a resolve on the expression,
18442 and later the assign will trigger another resolution
18444 This leads to bugs (#37014)
18446 * delegate.cs: The signature for EndInvoke should contain any ref
18447 or out parameters as well. We were not doing this in the past.
18449 * class.cs (Field.Define): Do not overwrite the type definition
18450 inside the `volatile' group. Turns out that volatile enumerations
18451 were changing the type here to perform a validity test, which
18454 2003-02-12 Miguel de Icaza <miguel@ximian.com>
18456 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
18457 and structs, we do not want to load the instance variable
18459 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
18460 enum_type has to be handled like an object reference (implicit
18461 conversions exists from this to object), but the regular IsClass
18462 and IsValueType tests will never return true for this one.
18464 Also we use TypeManager.IsValueType instead of type.IsValueType,
18465 just for consistency with the rest of the code (this is only
18466 needed if we ever use the construct exposed by test-180.cs inside
18467 corlib, which we dont today).
18469 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
18471 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
18474 2003-02-09 Martin Baulig <martin@ximian.com>
18476 * namespace.cs (Namespace..ctor): Added SourceFile argument.
18477 (Namespace.DefineNamespaces): New static public method; this is
18478 called when we're compiling with debugging to add all namespaces
18479 to the symbol file.
18481 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
18482 pass it to the Namespace's .ctor.
18484 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
18485 and MethodBase arguments; pass the namespace ID to the symwriter;
18486 pass the MethodBase instead of the token to the symwriter.
18487 (SymbolWriter.DefineNamespace): New method to add a namespace to
18490 2003-02-09 Martin Baulig <martin@ximian.com>
18492 * symbolwriter.cs: New file. This is a wrapper around
18493 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
18494 methods here in near future.
18496 2003-02-09 Martin Baulig <martin@ximian.com>
18498 * codegen.cs (EmitContext.Mark): Just pass the arguments to
18499 ILGenerator.MarkSequencePoint() which are actually used by the
18502 2003-02-09 Martin Baulig <martin@ximian.com>
18504 * location.cs (SourceFile): New public sealed class. This
18505 contains the name and an index which is used in the location's token.
18506 (Location): Reserve an appropriate number of bits in the token for
18507 the source file instead of walking over that list, this gives us a
18508 really huge performance improvement when compiling with debugging.
18510 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
18511 `SourceFile' argument instead of a string.
18512 (Driver.ProcessFile): Add all the files via Location.AddFile(),
18513 but don't parse/tokenize here, we need to generate the list of all
18514 source files before we do that.
18515 (Driver.ProcessFiles): New static function. Parses/tokenizes all
18518 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
18519 instead of a string.
18521 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
18524 2003-02-09 Martin Baulig <martin@ximian.com>
18526 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
18527 filename on `#line default'.
18529 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
18531 * statement.cs: don't clear the pinned var when the fixed statement
18532 returns from the method (fixes bug#37752).
18534 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
18536 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
18539 2003-02-07 Martin Baulig <martin@ximian.com>
18541 * driver.cs: Removed the `--debug-args' command line argument.
18543 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
18544 automatically by the AsssemblyBuilder.
18545 (CodeGen.InitializeSymbolWriter): We don't need to call any
18546 initialization function on the symbol writer anymore. This method
18547 doesn't take any arguments.
18549 2003-02-03 Miguel de Icaza <miguel@ximian.com>
18551 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
18552 from referenced assemblies as well.
18554 2003-02-02 Martin Baulig <martin@ximian.com>
18556 * class.cs (MethodData.Emit): Generate debugging info for external methods.
18558 2003-02-02 Martin Baulig <martin@ximian.com>
18560 * class.cs (Constructor.Emit): Open the symbol writer before
18561 emitting the constructor initializer.
18562 (ConstructorInitializer.Emit): Call ec.Mark() to allow
18563 single-stepping through constructor initializers.
18565 2003-01-30 Miguel de Icaza <miguel@ximian.com>
18567 * class.cs: Handle error 549: do not allow virtual methods in
18570 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
18572 * decl.cs: Check access levels when resolving types
18574 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
18576 * statement.cs: Add parameters and locals set in catch blocks that might
18577 return to set vector
18579 2003-01-29 Miguel de Icaza <miguel@ximian.com>
18581 * class.cs (Operator): Set the SpecialName flags for operators.
18583 * expression.cs (Invocation.DoResolve): Only block calls to
18584 accessors and operators on SpecialName methods.
18586 (Cast.TryReduce): Handle conversions from char constants.
18589 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
18591 * statement.cs: small memory and time optimization in FlowBranching.
18593 2003-01-28 Pedro Mart <yoros@wanadoo.es>
18595 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
18596 problem that the last fix but in the other sid (Set).
18598 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
18599 access when there is no indexer in the hierarchy.
18601 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
18603 * class.cs: Combine some if statements.
18605 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18607 * driver.cs: fixed bug #37187.
18609 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
18611 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
18612 any indexer, it's needed to build a list with all the indexers in the
18613 hierarchy (AllGetters), else we have problems. Fixes #35653.
18615 2003-01-23 Miguel de Icaza <miguel@ximian.com>
18617 * class.cs (MethodData.Define): It is wrong for an interface
18618 implementation to be static in both cases: explicit and implicit.
18619 We were only handling this in one case.
18621 Improve the if situation there to not have negations.
18623 * class.cs (Field.Define): Turns out that we do not need to check
18624 the unsafe bit on field definition, only on usage. Remove the test.
18626 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18628 * driver.cs: use assembly.Location instead of Codebase (the latest
18629 patch made mcs fail when using MS assemblies).
18631 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
18633 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
18634 get the path to *corlib.dll.
18636 2003-01-21 Nick Drochak <ndrochak@gol.com>
18640 * typemanager.cs: Remove compiler warnings
18642 2003-01-20 Duncan Mak <duncan@ximian.com>
18644 * AssemblyInfo.cs: Bump the version number to 0.19.
18646 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18648 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
18650 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
18652 * class.cs (Constructor::Emit): Emit debugging info for constructors.
18654 2003-01-17 Miguel de Icaza <miguel@ximian.com>
18656 * cs-parser.jay: Small fix: we were not comparing the constructor
18657 name correctly. Thanks to Zoltan for the initial pointer.
18659 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
18661 * cs-tokenizer.cs: Set file name when specified with #line
18663 2003-01-15 Miguel de Icaza <miguel@ximian.com>
18665 * cs-parser.jay: Only perform the constructor checks here if we
18666 are named like the class; This will help provider a better
18667 error. The constructor path is taken when a type definition is
18668 not found, but most likely the user forgot to add the type, so
18669 report that rather than the constructor error.
18671 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
18673 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
18676 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18678 * cs-parser.jay: Add cleanup call.
18680 2003-01-13 Duncan Mak <duncan@ximian.com>
18682 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
18683 consistent with other methods.
18685 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18687 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
18689 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
18691 * attribute.cs: only set GuidAttr to true when we have a
18694 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18698 * typemanager.cs: fixes to allow mcs compile corlib with the new
18699 Type.IsSubclassOf fix.
18701 2003-01-08 Miguel de Icaza <miguel@ximian.com>
18703 * expression.cs (LocalVariableReference.DoResolve): Classify a
18704 constant as a value, not as a variable. Also, set the type for
18707 * cs-parser.jay (fixed_statement): take a type instead of a
18708 pointer_type, so we can produce a better error message later.
18710 * statement.cs (Fixed.Resolve): Flag types that are not pointers
18713 (For.DoEmit): Make inifinite loops have a
18714 non-conditional branch back.
18716 (Fixed.DoEmit): First populate the pinned variables, then emit the
18717 statement, then clear the variables. Before I was emitting the
18718 code once for each fixed piece.
18721 2003-01-08 Martin Baulig <martin@ximian.com>
18723 * statement.cs (FlowBranching.MergeChild): A break in a
18724 SWITCH_SECTION does not leave a loop. Fixes #36155.
18726 2003-01-08 Martin Baulig <martin@ximian.com>
18728 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
18729 lives in the same number space than `param_map'. Fixes #36154.
18731 2003-01-07 Miguel de Icaza <miguel@ximian.com>
18733 * cs-parser.jay (constructor_declaration): Set the
18734 Constructor.ModFlags before probing for it. This makes the
18735 compiler report 514, 515 and 132 (the code was there, but got
18738 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
18739 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
18740 (GotoCase.Resolve): Set `Returns' to ALWAYS.
18742 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
18744 * enum.cs: create the enum static fields using the enum type.
18746 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
18748 * class.cs: don't try to create the ParamBuilder for the return
18749 type if it's not needed (and handle it breaking for the ms runtime
18752 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
18754 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
18756 2002-12-29 Miguel de Icaza <miguel@ximian.com>
18758 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
18759 the command. This showed up while compiling the JANET source
18760 code, which used \r as its only newline separator.
18762 2002-12-28 Miguel de Icaza <miguel@ximian.com>
18764 * class.cs (Method.Define): If we are an operator (because it
18765 reuses our code), then set the SpecialName and HideBySig. #36128
18767 2002-12-22 Miguel de Icaza <miguel@ximian.com>
18769 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
18770 exception, report error 120 `object reference required'.
18772 * driver.cs: Add --pause option, used during to measure the size
18773 of the process as it goes with --timestamp.
18775 * expression.cs (Invocation.DoResolve): Do not allow methods with
18776 SpecialName to be invoked.
18778 2002-12-21 Miguel de Icaza <miguel@ximian.com>
18780 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
18781 number before adding it.
18783 2002-12-21 Ravi Pratap <ravi@ximian.com>
18785 * ecore.cs (StandardImplicitConversion): When in an unsafe
18786 context, we allow conversion between void * to any other pointer
18787 type. This fixes bug #35973.
18789 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
18791 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
18792 is not thrown when extensionless outputs are used
18794 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18796 * rootcontext.cs: fixed compilation of corlib.
18798 2002-12-19 Miguel de Icaza <miguel@ximian.com>
18800 * attribute.cs (Attributes.Contains): Add new method.
18802 * class.cs (MethodCore.LabelParameters): if the parameter is an
18803 `out' parameter, check that no attribute `[In]' has been passed.
18805 * enum.cs: Handle the `value__' name in an enumeration.
18807 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
18809 * decl.cs: Added special case to allow overrides on "protected
18812 2002-12-18 Ravi Pratap <ravi@ximian.com>
18814 * attribute.cs (Attributes.AddAttributeSection): Rename to this
18815 since it makes much more sense.
18817 (Attributes.ctor): Don't require a Location parameter.
18819 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
18821 * attribute.cs (ApplyAttributes): Remove extra Location parameters
18822 since we already have that information per attribute.
18824 * everywhere : make appropriate changes.
18826 * class.cs (LabelParameters): Write the code which actually
18827 applies attributes to the return type. We can't do this on the MS
18828 .NET runtime so we flag a warning in the case an exception is
18831 2002-12-18 Miguel de Icaza <miguel@ximian.com>
18833 * const.cs: Handle implicit null conversions here too.
18835 2002-12-17 Ravi Pratap <ravi@ximian.com>
18837 * class.cs (MethodCore.LabelParameters): Remove the extra
18838 Type [] parameter since it is completely unnecessary. Instead
18839 pass in the method's attributes so that we can extract
18840 the "return" attribute.
18842 2002-12-17 Miguel de Icaza <miguel@ximian.com>
18844 * cs-parser.jay (parse): Use Report.Error to flag errors instead
18845 of ignoring it and letting the compile continue.
18847 * typemanager.cs (ChangeType): use an extra argument to return an
18848 error condition instead of throwing an exception.
18850 2002-12-15 Miguel de Icaza <miguel@ximian.com>
18852 * expression.cs (Unary.TryReduce): mimic the code for the regular
18853 code path. Perform an implicit cast in the cases where we can
18854 implicitly convert to one of the integral types, and then reduce
18855 based on that constant. This fixes bug #35483.
18857 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18859 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
18861 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18863 * namespace.cs: fixed bug #35489.
18865 2002-12-12 Miguel de Icaza <miguel@ximian.com>
18867 * class.cs: Remove some dead code.
18869 * cs-parser.jay: Estimate the number of methods needed
18870 (RootContext.MethodCount);
18872 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
18873 numbers instead of StringBuilders.
18875 * support.cs (PtrHashtable): Add constructor with initial size;
18876 We can now reduce reallocations of the method table.
18878 2002-12-10 Ravi Pratap <ravi@ximian.com>
18880 * attribute.cs (ApplyAttributes): Keep track of the emitted
18881 attributes on a per-target basis. This fixes bug #35413.
18883 2002-12-10 Miguel de Icaza <miguel@ximian.com>
18885 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
18886 default to the Windows 1252 encoding.
18888 (UnixParseOption): Support version, thanks to Alp for the missing
18891 * AssemblyInfo.cs: Add nice assembly information.
18893 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
18896 * cs-parser.jay: Allow a trailing comma before the close bracked
18897 in the attribute_section production.
18899 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
18900 address of the instance was being taken, I will take this out,
18901 because we take the address of the object immediately here.
18903 2002-12-09 Ravi Pratap <ravi@ximian.com>
18905 * typemanager.cs (AreMultipleAllowed): Take care of the most
18906 obvious case where attribute type is not in the current assembly -
18909 2002-12-08 Miguel de Icaza <miguel@ximian.com>
18911 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
18912 definitions, instead of doing that afterwards.
18914 Also we use a nice little hack, depending on the constructor, we
18915 know if we are a "composed" name or a simple name. Hence, we
18916 avoid the IndexOf test, and we avoid
18918 * codegen.cs: Add code to assist in a bug reporter to track down
18919 the source of a compiler crash.
18921 2002-12-07 Ravi Pratap <ravi@ximian.com>
18923 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
18924 types have been emitted for a given element and flag an error
18925 if something which does not have AllowMultiple set is used more
18928 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
18929 attribute types and their corresponding AllowMultiple properties
18931 (AreMultipleAllowed): Check the property for a given type.
18933 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
18934 property in the case we have a TypeContainer.
18936 (Attributes.AddAttribute): Detect duplicates and just skip on
18937 adding them. This trivial fix catches a pretty gross error in our
18938 attribute emission - global attributes were being emitted twice!
18940 Bugzilla bug #33187 is now fixed.
18942 2002-12-06 Miguel de Icaza <miguel@ximian.com>
18944 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
18945 instead of pp_and).
18947 * expression.cs (Binary.ResolveOperator): I can only use the
18948 Concat (string, string, string) and Concat (string, string,
18949 string, string) if the child is actually a concatenation of
18952 2002-12-04 Miguel de Icaza <miguel@ximian.com>
18954 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
18955 context where we need a 2-character lookahead.
18957 * pending.cs (PendingImplementation): Rework so we can keep track
18958 of interface types all the time, and flag those which were
18959 implemented by parents as optional.
18961 2002-12-03 Miguel de Icaza <miguel@ximian.com>
18963 * expression.cs (Binary.ResolveOperator): Use
18964 String.Concat(string,string,string) or
18965 String.Concat(string,string,string,string) when possible.
18967 * typemanager: More helper methods.
18970 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
18972 * pending.cs: remove the bogus return from GetMissingInterfaces()
18973 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
18975 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18977 * namespace.cs: avoid duplicated 'using xxx' being added to
18978 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
18979 when we get more than one 'using' statement for the same namespace.
18980 Report a CS0105 warning for it.
18982 2002-11-30 Miguel de Icaza <miguel@ximian.com>
18984 * cs-tokenizer.cs (consume_identifier): use read directly, instead
18985 of calling getChar/putback, uses internal knowledge of it.
18987 (xtoken): Reorder tokenizer so most common patterns are checked
18988 first. This reduces the compilation time in another 5% (from 8.11s
18989 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
18991 The parsing time is 22% of the compilation in mcs, and from that
18992 64% is spent on the tokenization process.
18994 I tried using a binary search for keywords, but this is slower
18995 than the hashtable. Another option would be to do a couple of
18998 * Not use a StringBuilder, instead use an array of chars,
18999 with a set value. Notice that this way we could catch
19000 the 645 error without having to do it *afterwards*.
19002 * We could write a hand-parser to avoid the hashtable
19003 compares altogether.
19005 The identifier consumption process takes 37% of the tokenization
19006 time. Another 15% is spent on is_number. 56% of the time spent
19007 on is_number is spent on Int64.Parse:
19009 * We could probably choose based on the string length to
19010 use Int32.Parse or Int64.Parse and avoid all the 64-bit
19013 Another 3% is spend on wrapping `xtoken' in the `token' function.
19015 Handle 0xa0 as whitespace (#34752)
19017 2002-11-26 Miguel de Icaza <miguel@ximian.com>
19019 * typemanager.cs (IsCLRType): New routine to tell whether a type
19020 is one of the builtin types.
19022 Maybe it needs to use TypeCodes to be faster. Maybe we could use
19023 typecode in more places instead of doing pointer comparissions.
19024 We could leverage some knowledge about the way the typecodes are
19027 New code to cache namespaces in assemblies, it is currently not
19028 invoked, to be used soon.
19030 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
19032 * expression.cs (Binary.ResolveOperator): specially handle
19033 strings, and do not perform user-defined operator overloading for
19036 2002-11-24 Miguel de Icaza <miguel@ximian.com>
19038 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
19039 internalcall as it is a pretty simple operation; Avoid whenever
19040 possible to call Char.IsLetter.
19042 (consume_identifier): Cut by half the number of
19043 hashtable calls by merging the is_keyword and GetKeyword behavior.
19045 Do not short-circuit, because if we do, we
19046 report errors (ie, #if false && true would produce an invalid
19050 2002-11-24 Martin Baulig <martin@ximian.com>
19052 * expression.cs (Cast.TryReduce): If we're in checked syntax,
19053 check constant ranges and report a CS0221. Fixes #33186.
19055 2002-11-24 Martin Baulig <martin@ximian.com>
19057 * cs-parser.jay: Make this work for uninitialized variable
19058 declarations in the `for' initializer. Fixes #32416.
19060 2002-11-24 Martin Baulig <martin@ximian.com>
19062 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
19063 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
19065 2002-11-24 Martin Baulig <martin@ximian.com>
19067 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
19068 argument; if true, we also check for user-defined conversions.
19069 This is only needed if both arguments are of a user-defined type.
19070 Fixes #30443, added test-175.cs.
19071 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
19073 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
19075 2002-11-24 Martin Baulig <martin@ximian.com>
19077 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
19078 function to get the store opcode.
19079 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
19080 only emit the Ldelema if the store opcode is Stobj. You must run
19081 both test-34 and test-167 to test this. Fixes #34529.
19083 2002-11-23 Martin Baulig <martin@ximian.com>
19085 * ecore.cs (Expression.MemberLookup): Added additional
19086 `qualifier_type' argument which is used when we're being called
19087 from MemberAccess.DoResolve() and null if we're called from a
19089 (Expression.MemberLookupFailed): New method to report errors; this
19090 does the CS1540 check and reports the correct error message.
19092 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
19093 argument for the CS1540 check and redone the way how we're dealing
19094 with private members. See the comment in the source code for details.
19095 (FilterWithClosure): Reverted this back to revision 1.197; renamed
19096 `closure_start_type' to `closure_qualifier_type' and check whether
19097 it's not null. It was not this filter being broken, it was just
19098 being called with the wrong arguments.
19100 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
19101 and pass it the correct `qualifier_type'; this also does the error
19104 2002-11-22 Miguel de Icaza <miguel@ximian.com>
19106 * expression.cs (Invocation.EmitParams): If the we are dealing
19107 with a non-built-in value type, load its address as well.
19109 (ArrayCreation): Use a a pretty constant instead
19110 of the hardcoded value 2. Use 6 instead of 2 for the number of
19111 static initializers.
19113 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
19114 because they are not really value types, just glorified integers.
19116 * driver.cs: Do not append .exe, the CSC compiler does not do it.
19118 * ecore.cs: Remove redundant code for enumerations, make them use
19119 the same code path as everything else, fixes the casting issue
19120 with enumerations in Windows.Forms.
19122 * attribute.cs: Do only cast to string if it is a string, the
19123 validation happens later.
19125 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
19126 people upgrade their corlibs.
19128 * ecore.cs: Oops, enumerations were not following the entire code path
19130 2002-11-21 Miguel de Icaza <miguel@ximian.com>
19132 * typemanager.cs (FilterWithClosure): Commented out the test for
19133 1540 in typemanager.cs, as it has problems when accessing
19134 protected methods from a parent class (see test-174.cs).
19136 * attribute.cs (Attribute.ValidateGuid): new method.
19137 (Attribute.Resolve): Use above.
19139 2002-11-19 Miguel de Icaza <miguel@ximian.com>
19141 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
19143 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
19144 handling for enumerations, as we only needed the TypeContainer
19145 functionality to begin with (this is required for the fix below to
19146 work for enums that reference constants in a container class for
19149 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
19151 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
19152 a valid TypeBuilder to perform lookups on.o
19154 * class.cs (InheritableMemberSignatureCompare): Use true in the
19155 call to GetGetMethod and GetSetMethod, because we are comparing
19156 the signature, and we need to get the methods *even* if they are
19159 (PropertyBase.CheckBase): ditto.
19161 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
19162 GotoCase.Resolve): Use Peel on EmpytCasts.
19164 * ecore.cs (EmptyCast): drop child, add Peel method.
19166 2002-11-17 Martin Baulig <martin@ximian.com>
19168 * ecore.cs (EmptyCast.Child): New public property.
19170 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
19171 label resolved to an EmptyCast. Fixes #34162.
19172 (GotoCase.Resolve): Likewise.
19173 (Block.EmitMeta): Likewise.
19175 2002-11-17 Martin Baulig <martin@ximian.com>
19177 * expression.cs (Invocation.BetterConversion): Prefer int over
19178 uint; short over ushort; long over ulong for integer literals.
19179 Use ImplicitConversionExists instead of StandardConversionExists
19180 since we also need to check for user-defined implicit conversions.
19181 Fixes #34165. Added test-173.cs.
19183 2002-11-16 Martin Baulig <martin@ximian.com>
19185 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
19186 with the `true' and `false' literals. Fixes #33151.
19188 2002-11-16 Martin Baulig <martin@ximian.com>
19190 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
19191 October 22nd; don't do the cs1540 check for static members.
19193 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
19194 now using our own filter here and doing the cs1540 check again.
19196 2002-11-16 Martin Baulig <martin@ximian.com>
19198 * support.cs (InternalParameters): Don't crash if we don't have
19199 any fixed parameters. Fixes #33532.
19201 2002-11-16 Martin Baulig <martin@ximian.com>
19203 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
19204 when looking up static methods to make this work on Windows.
19207 2002-11-16 Martin Baulig <martin@ximian.com>
19209 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
19210 a setter rather than using PropertyInfo.CanWrite.
19212 2002-11-15 Nick Drochak <ndrochak@gol.com>
19214 * class.cs: Allow acces to block member by subclasses. Fixes build
19217 2002-11-14 Martin Baulig <martin@ximian.com>
19219 * class.cs (Constructor.Emit): Added the extern/block check.
19222 2002-11-14 Martin Baulig <martin@ximian.com>
19224 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
19225 iteration while looking for indexers, this is needed because the
19226 indexer may have a different name in our base classes. Fixed the
19227 error reporting (no indexers at all, not get accessor, no
19228 overloaded match). Fixes bug #33089.
19229 (IndexerAccess.DoResolveLValue): Likewise.
19231 2002-11-14 Martin Baulig <martin@ximian.com>
19233 * class.cs (PropertyBase.CheckBase): Make this work for multiple
19234 indexers. Fixes the first part of bug #33089.
19235 (MethodSignature.InheritableMemberSignatureCompare): Added support
19238 2002-11-13 Ravi Pratap <ravi@ximian.com>
19240 * attribute.cs (Attribute.Resolve): Catch the
19241 NullReferenceException and report it since it isn't supposed to
19244 2002-11-12 Miguel de Icaza <miguel@ximian.com>
19246 * expression.cs (Binary.EmitBranchable): Also handle the cases for
19247 LogicalOr and LogicalAnd that can benefit from recursively
19248 handling EmitBranchable. The code now should be nice for Paolo.
19250 2002-11-08 Miguel de Icaza <miguel@ximian.com>
19252 * typemanager.cs (LookupType): Added a negative-hit hashtable for
19253 the Type lookups, as we perform quite a number of lookups on
19254 non-Types. This can be removed once we can deterministically tell
19255 whether we have a type or a namespace in advance.
19257 But this might require special hacks from our corlib.
19261 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
19262 and double which avoids a conversion from an integer to a double.
19264 * expression.cs: tiny optimization, avoid calling IsConstant,
19265 because it effectively performs the lookup twice.
19267 2002-11-06 Miguel de Icaza <miguel@ximian.com>
19269 But a bogus return here to keep the semantics of the old code
19270 until the Mono runtime is fixed.
19272 * pending.cs (GetMissingInterfaces): New method used to remove all
19273 the interfaces that are already implemented by our parent
19274 classes from the list of pending methods.
19276 * interface.cs: Add checks for calls after ResolveTypeExpr.
19278 2002-11-05 Miguel de Icaza <miguel@ximian.com>
19280 * class.cs (Class.Emit): Report warning 67: event not used if the
19281 warning level is beyond 3.
19283 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
19284 being a NullLiteral.
19286 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
19289 * class.cs (TypeContainer.GetClassBases): Cover a missing code
19290 path that might fail if a type can not be resolved.
19292 * expression.cs (Binary.Emit): Emit unsigned versions of the
19295 * driver.cs: use error 5.
19297 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
19299 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
19301 2002-11-01 Miguel de Icaza <miguel@ximian.com>
19303 * cs-parser.jay (switch_section): A beautiful patch from Martin
19304 Baulig that fixed 33094.
19306 2002-10-31 Miguel de Icaza <miguel@ximian.com>
19308 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
19309 Check whether the base is abstract and report an error if so.
19311 * expression.cs (IndexerAccess.DoResolveLValue,
19312 IndexerAccess.DoResolve): ditto.
19314 (Invocation.DoResolve): ditto.
19316 (Invocation.FullMethodDesc): Improve the report string.
19318 * statement.cs (Block): Eliminate IsVariableDefined as it is
19319 basically just a wrapper for GetVariableInfo.
19321 * ecore.cs (SimpleName): Use new
19323 * support.cs (ReflectionParamter.ParameterType): We unwrap the
19324 type, as we return the actual parameter ref/unref state on a
19327 2002-10-30 Miguel de Icaza <miguel@ximian.com>
19329 * support.cs: Return proper flags REF/OUT fixing the previous
19332 * expression.cs: Reverted last patch, that was wrong. Is_ref is
19333 not used to mean `ref' but `ref or out' in ParameterReference
19335 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
19336 full type signature instead of calling TypeManger.CSharpName
19339 * support.cs (InternalParameters.ParameterDesc): Do not compare
19340 directly to the modflags, because REF/OUT will actually be bitsets
19343 * delegate.cs (VerifyMethod): Check also the modifiers.
19345 * cs-tokenizer.cs: Fix bug where floating point values with an
19346 exponent where a sign was missing was ignored.
19348 * driver.cs: Allow multiple assemblies to be specified in a single
19351 2002-10-28 Miguel de Icaza <miguel@ximian.com>
19353 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
19354 because identifiers after a parenthesis would end up in this kind
19355 of production, and we needed to desamiguate it for having casts
19358 (UserDefinedType *) xxx
19360 2002-10-24 Miguel de Icaza <miguel@ximian.com>
19362 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
19363 we should set on the Bindingflags.NonPublic, but not turn on
19364 private_ok. private_ok controls whether a Private member is
19365 returned (this is chekced on the filter routine), while the
19366 BindingFlags.NonPublic just controls whether private/protected
19367 will be allowed. This fixes the problem part of the problem of
19368 private properties being allowed to be used in derived classes.
19370 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
19371 so we can call the children DoResolveLValue method (this will
19372 properly signal errors on lvalue assignments to base properties)
19374 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
19375 getter are null, and we have a property info, we know that this
19376 happened because the lookup failed, so we report an error 122 for
19377 protection level violation.
19379 We also silently return if setter and getter are null in the
19380 resolve functions, this condition only happens if we have flagged
19381 the error before. This is the other half of the problem.
19383 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
19384 not have accessibility information, that is why we were returning
19385 true in the filter function in typemanager.cs.
19387 To properly report 122 (property is inaccessible because of its
19388 protection level) correctly, we report this error in ResolveAccess
19389 by failing if both the setter and the getter are lacking (ie, the
19392 DoResolve and DoLResolve have been modified to check for both
19393 setter/getter being null and returning silently, the reason being
19394 that I did not want to put the knowledge about this error in upper
19397 int old = Report.Errors;
19398 x = new PropertyExpr (...);
19399 if (old != Report.Errors)
19404 So the property expr is returned, but it is invalid, so the error
19405 will be flagged during the resolve process.
19407 * class.cs: Remove InheritablePropertySignatureCompare from the
19408 class, as we no longer depend on the property signature to compute
19409 whether it is possible to implement a method or not.
19411 The reason is that calling PropertyInfo.GetGetMethod will return
19412 null (in .NET, in Mono it works, and we should change this), in
19413 cases where the Get Method does not exist in that particular
19418 class X { public virtual int A { get { return 1; } } }
19420 class Z : Y { public override int A { get { return 2; } } }
19422 Would fail in Z because the parent (Y) would not have the property
19423 defined. So we avoid this completely now (because the alternative
19424 fix was ugly and slow), and we now depend exclusively on the
19427 (PropertyBase.CheckBase): Use a method-base mechanism to find our
19428 reference method, instead of using the property.
19430 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
19431 routines are gone now.
19433 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
19434 names, they were incorrectly named.
19436 * cs-tokenizer.cs: Return are more gentle token on failure.
19438 * pending.cs (PendingImplementation.InterfaceMethod): This routine
19439 had an out-of-sync index variable, which caused it to remove from
19440 the list of pending methods the wrong method sometimes.
19442 2002-10-22 Miguel de Icaza <miguel@ximian.com>
19444 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
19445 CanWrite, because those refer to this particular instance of the
19446 property, and do not take into account the fact that we can
19447 override single members of a property.
19449 Constructor requires an EmitContext. The resolution process does
19450 not happen here, but we need to compute the accessors before,
19451 because the resolution does not always happen for properties.
19453 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
19454 subclass, before we did not update this flag, but we did update
19457 (GetAccessors): Drop this routine, as it did not work in the
19458 presence of partially overwritten set/get methods.
19460 Notice that this broke the cs1540 detection, but that will require
19463 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19467 * driver.cs: issue a warning instead of an error if we don't support
19468 debugging for the platform. Also ignore a couple of errors that may
19469 arise when trying to write the symbols. Undo my previous patch.
19471 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19473 * driver.cs: ignore /debug switch except for Unix platforms.
19475 2002-10-23 Nick Drochak <ndrochak@gol.com>
19477 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
19479 2002-10-21 Miguel de Icaza <miguel@ximian.com>
19481 * driver.cs: Do not make mcs-debug conditional, so we do not break
19482 builds that use it.
19484 * statement.cs (UsageVector.MergeChildren): I would like Martin to
19485 review this patch. But basically after all the children variables
19486 have been merged, the value of "Breaks" was not being set to
19487 new_breaks for Switch blocks. I think that it should be set after
19488 it has executed. Currently I set this to the value of new_breaks,
19489 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
19490 conservative, but I do not understand this code very well.
19492 I did not break anything in the build, so that is good ;-)
19494 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
19496 2002-10-20 Mark Crichton <crichton@gimp.org>
19498 * cfold.cs: Fixed compile blocker. Really fixed it this time.
19500 2002-10-20 Nick Drochak <ndrochak@gol.com>
19502 * cfold.cs: Fixed compile blocker.
19504 2002-10-20 Miguel de Icaza <miguel@ximian.com>
19506 * driver.cs: I was chekcing the key, not the file.
19508 2002-10-19 Ravi Pratap <ravi@ximian.com>
19510 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
19511 message that we were generating - we just need to silently return
19514 2002-10-19 Miguel de Icaza <miguel@ximian.com>
19516 * class.cs (Event.Define): Change my previous commit, as this
19517 breaks the debugger. This is a temporary hack, as it seems like
19518 the compiler is generating events incorrectly to begin with.
19520 * expression.cs (Binary.ResolveOperator): Added support for
19521 "U operator - (E x, E y)"
19523 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
19526 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
19527 init-only variables, but this path did not take into account that
19528 there might be also instance readonly variables. Correct this
19531 This fixes bug 32253
19533 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
19536 * driver.cs: Change the extension for modules to `netmodule'
19538 * cs-parser.jay: Improved slightly the location tracking for
19539 the debugger symbols.
19541 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
19542 modifiers that were specified instead of the hardcoded value
19543 (FamAndAssem). This was basically ignoring the static modifier,
19544 and others. Fixes 32429.
19546 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
19547 fixed a bug in the process (32476)
19549 * expression.cs (ArrayAccess.EmitAssign): Patch from
19550 hwang_rob@yahoo.ca that fixes bug 31834.3
19552 2002-10-18 Miguel de Icaza <miguel@ximian.com>
19554 * driver.cs: Make the module extension .netmodule.
19556 2002-10-16 Miguel de Icaza <miguel@ximian.com>
19558 * driver.cs: Report an error if the resource file is not found
19559 instead of crashing.
19561 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
19562 false, like Emit does.
19564 2002-10-16 Nick Drochak <ndrochak@gol.com>
19566 * typemanager.cs: Remove unused private member. Also reported mcs
19567 bug to report this as a warning like csc.
19569 2002-10-15 Martin Baulig <martin@gnome.org>
19571 * statement.cs (Statement.Emit): Made this a virtual method; emits
19572 the line number info and calls DoEmit().
19573 (Statement.DoEmit): New protected abstract method, formerly knows
19574 as Statement.Emit().
19576 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
19578 2002-10-11 Miguel de Icaza <miguel@ximian.com>
19580 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
19581 have fixed a remaining problem: not every AddXXXX was adding a
19582 fully qualified name.
19584 Now everyone registers a fully qualified name in the DeclSpace as
19585 being defined instead of the partial name.
19587 Downsides: we are slower than we need to be due to the excess
19588 copies and the names being registered this way.
19590 The reason for this is that we currently depend (on the corlib
19591 bootstrap for instance) that types are fully qualified, because
19592 we dump all the types in the namespace, and we should really have
19593 types inserted into the proper namespace, so we can only store the
19594 basenames in the defined_names array.
19596 2002-10-10 Martin Baulig <martin@gnome.org>
19598 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
19599 from bug #31834, see the bug report for a testcase which is
19602 2002-10-10 Martin Baulig <martin@gnome.org>
19604 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
19605 flow analysis code for this.
19607 * statement.cs (Do, While, For): Tell the flow analysis code about
19609 (FlowBranching.UsageVector): Added support for infinite loops.
19610 (Block.Resolve): Moved the dead code elimination here and use flow
19613 2002-10-09 Miguel de Icaza <miguel@ximian.com>
19615 * class.cs (Field.Define): Catch cycles on struct type
19618 * typemanager.cs (IsUnmanagedtype): Do not recursively check
19619 fields if the fields are static. We only need to check instance
19622 * expression.cs (As.DoResolve): Test for reference type.
19624 * statement.cs (Using.ResolveExpression): Use
19625 ConvertImplicitRequired, not ConvertImplicit which reports an
19627 (Using.ResolveLocalVariableDecls): ditto.
19629 * expression.cs (Binary.ResolveOperator): Report errors in a few
19630 places where we had to.
19632 * typemanager.cs (IsUnmanagedtype): Finish implementation.
19634 2002-10-08 Miguel de Icaza <miguel@ximian.com>
19636 * expression.cs: Use StoreFromPtr instead of extracting the type
19637 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
19639 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
19640 an enumeration value to a System.Enum, but System.Enum is not a
19641 value type, but an class type, so we need to box.
19643 (Expression.ConvertExplicit): One codepath could return
19644 errors but not flag them. Fix this. Fixes #31853
19646 * parameter.cs (Resolve): Do not allow void as a parameter type.
19648 2002-10-06 Martin Baulig <martin@gnome.org>
19650 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
19651 if it's a class type and not a struct. Fixes #31815.
19653 2002-10-06 Martin Baulig <martin@gnome.org>
19655 * statement.cs: Reworked the flow analysis code a bit to make it
19656 usable for dead code elimination.
19658 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19660 * cs-parser.jay: allow empty source files. Fixes bug #31781.
19662 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19664 * expression.cs (ComposedCast.DoResolveType): A quick workaround
19665 to fix the test 165, will investigate deeper.
19667 2002-10-04 Martin Baulig <martin@gnome.org>
19669 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
19670 finally blocks actually work.
19671 (Try.Resolve): We don't need to create a sibling for `finally' if
19672 there is no finally block.
19674 2002-10-04 Martin Baulig <martin@gnome.org>
19676 * class.cs (Constructor.Define): The default accessibility for a
19677 non-default constructor is private, not public.
19679 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19681 * class.cs (Constructor): Make AllowedModifiers public, add
19684 * cs-parser.jay: Perform the modifiers test here, as the
19685 constructor for the Constructor class usually receives a zero
19686 because of the way we create it (first we create, later we
19687 customize, and we were never checking the modifiers).
19689 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
19690 is a version of LookupTypeReflection that includes the type-name
19691 cache. This can be used as a fast path for functions that know
19692 the fully qualified name and are only calling into *.GetType() to
19693 obtain a composed type.
19695 This is also used by TypeManager.LookupType during its type
19698 (LookupType): We now also track the real type name, as sometimes
19699 we can get a quey for the real type name from things like
19700 ComposedCast. This fixes bug 31422.
19702 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
19703 complete type fullname, it does not have to go through the type
19704 resolution system to obtain the composed version of the type (for
19705 obtaining arrays or pointers).
19707 (Conditional.Emit): Use the EmitBoolExpression to
19708 generate nicer code, as requested by Paolo.
19710 (ArrayCreation.CheckIndices): Use the patch from
19711 hwang_rob@yahoo.ca to validate the array initializers.
19713 2002-10-03 Miguel de Icaza <miguel@ximian.com>
19715 * class.cs (ConstructorInitializer.Emit): simplify code by using
19716 Invocation.EmitCall, and at the same time, fix the bugs in calling
19717 parent constructors that took variable arguments.
19719 * ecore.cs (Expression.ConvertNumericExplicit,
19720 Expression.ImplicitNumericConversion): Remove the code that
19721 manually wrapped decimal (InternalTypeConstructor call is now gone
19724 * expression.cs (Cast.TryReduce): Also handle decimal types when
19725 trying to perform a constant fold on the type.
19727 * typemanager.cs (IsUnmanagedtype): Partially implemented.
19729 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
19730 that only turned off an error report, and did nothing else.
19732 2002-10-02 Miguel de Icaza <miguel@ximian.com>
19734 * driver.cs: Handle and ignore /fullpaths
19736 2002-10-01 Miguel de Icaza <miguel@ximian.com>
19738 * expression.cs (Binary.ResolveOperator): Catch the case where
19739 DoNumericPromotions returns true,
19741 (Binary.DoNumericPromotions): Simplify the code, and the tests.
19743 2002-09-27 Miguel de Icaza <miguel@ximian.com>
19745 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
19748 2002-09-26 Miguel de Icaza <miguel@ximian.com>
19750 * ecore.cs (ConvertNumericExplicit): It is not enough that the
19751 conversion exists, but it is also required that the conversion be
19752 performed. This manifested in "(Type64Enum) 2".
19754 * class.cs (TypeManager.AddMethod): The fix is not to change
19755 AddEnum, because that one was using a fully qualified name (every
19756 DeclSpace derivative does), but to change the AddMethod routine
19757 that was using an un-namespaced name. This now correctly reports
19758 the duplicated name.
19760 Revert patch until I can properly fix it. The issue
19761 is that we have a shared Type space across all namespaces
19762 currently, which is wrong.
19764 Options include making the Namespace a DeclSpace, and merge
19765 current_namespace/current_container in the parser.
19767 2002-09-25 Miguel de Icaza <miguel@ximian.com>
19769 * cs-parser.jay: Improve error reporting when we get a different
19770 kind of expression in local_variable_type and
19771 local_variable_pointer_type.
19773 Propagate this to avoid missleading errors being reported.
19775 * ecore.cs (ImplicitReferenceConversion): treat
19776 TypeManager.value_type as a target just like object_type. As
19781 Is valid, and needs to result in the int 1 being boxed before it
19782 is assigned to the value type v.
19784 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
19785 to validate the enumeration name.
19787 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
19788 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
19789 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
19791 * ecore.cs (TryImplicitIntConversion): When doing an
19792 implicit-enumeration-conversion, check if the type is 64-bits and
19793 perform a conversion before passing to EnumConstant.
19795 2002-09-23 Miguel de Icaza <miguel@ximian.com>
19797 * decl.cs (Error_AmbiguousTypeReference); New routine used to
19798 report ambiguous type references. Unlike the MS version, we
19799 report what the ambiguity is. Innovation at work ;-)
19801 (DeclSpace.FindType): Require a location argument to
19802 display when we display an ambiguous error.
19804 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
19806 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
19808 * expression.cs (EmitDynamicInitializers): Apply patch from
19809 hwang_rob@yahoo.ca that fixes the order in which we emit our
19812 2002-09-21 Martin Baulig <martin@gnome.org>
19814 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
19815 delegate takes no arguments.
19817 2002-09-20 Miguel de Icaza <miguel@ximian.com>
19819 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
19822 * expression.cs: Extract the underlying type.
19824 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
19826 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
19828 2002-09-19 Miguel de Icaza <miguel@ximian.com>
19830 * class.cs (TypeContainer.DefineType): We can not use the nice
19831 PackingSize with the size set to 1 DefineType method, because it
19832 will not allow us to define the interfaces that the struct
19835 This completes the fixing of bug 27287
19837 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
19838 means also structs. This fixes part of the problem.
19839 (Expresion.ImplicitReferenceConversionExists): ditto.
19841 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
19842 error if there were no errors reported during the type lookup
19843 process, to avoid duplicates or redundant errors. Without this
19844 you would get an ambiguous errors plus a type not found. We have
19845 beaten the user enough with the first error.
19847 (DeclSparce.FindType): Emit a warning if we have an ambiguous
19850 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
19851 during the resolution process, stop the lookup, this avoids
19852 repeated error reports (same error twice).
19854 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
19856 * typemanager.cs (LookupType): Redo the type lookup code to match
19857 the needs of System.Reflection.
19859 The issue is that System.Reflection requires references to nested
19860 types to begin with a "+" sign instead of a dot. So toplevel
19861 types look like: "NameSpace.TopLevelClass", and nested ones look
19862 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
19865 2002-09-19 Martin Baulig <martin@gnome.org>
19867 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
19868 says that a method always returns or always throws an exception,
19869 don't report the CS0161.
19871 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
19872 set `Returns = new_returns'.
19874 2002-09-19 Martin Baulig <martin@gnome.org>
19876 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
19877 to an enum constant, check for a CS0176.
19879 2002-09-18 Miguel de Icaza <miguel@ximian.com>
19881 * class.cs (TypeContainer.CheckPairedOperators): Now we check
19882 for operators that must be in pairs and report errors.
19884 * ecore.cs (SimpleName.DoResolveType): During the initial type
19885 resolution process, when we define types recursively, we must
19886 check first for types in our current scope before we perform
19887 lookups in the enclosing scopes.
19889 * expression.cs (MakeByteBlob): Handle Decimal blobs.
19891 (Invocation.VerifyArgumentsCompat): Call
19892 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
19893 I thought we were supposed to always call this, but there are a
19894 few places in the code where we dont do it.
19896 2002-09-17 Miguel de Icaza <miguel@ximian.com>
19898 * driver.cs: Add support in -linkres and -resource to specify the
19899 name of the identifier.
19901 2002-09-16 Miguel de Icaza <miguel@ximian.com>
19903 * ecore.cs (StandardConversionExists): Sync with the conversion
19904 code: allow anything-* to void* conversions.
19906 (FindMostSpecificSource): Use an Expression argument
19907 instead of a Type, because we might be handed over a Literal which
19908 gets a few more implicit conversions that plain types do not. So
19909 this information was being lost.
19911 Also, we drop the temporary type-holder expression when not
19914 2002-09-17 Martin Baulig <martin@gnome.org>
19916 * class.cs (PropertyBase.CheckBase): Don't check the base class if
19917 this is an explicit interface implementation.
19919 2002-09-17 Martin Baulig <martin@gnome.org>
19921 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
19922 different `IndexerName' attributes.
19924 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
19925 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
19926 virtual CommonResolve().
19928 2002-09-16 Miguel de Icaza <miguel@ximian.com>
19930 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
19931 and convert that to the UnderlyingType.
19933 * statement.cs (Foreach.Resolve): Indexers are just like variables
19934 or PropertyAccesses.
19936 * cs-tokenizer.cs (consume_string): Track line numbers and columns
19937 inside quoted strings, we were not doing this before.
19939 2002-09-16 Martin Baulig <martin@gnome.org>
19941 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
19942 resolve it. This is needed for the definite assignment check of the
19943 instance expression, fixes bug #29846.
19944 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
19946 2002-09-16 Nick Drochak <ndrochak@gol.com>
19948 * parameter.cs: Fix compile error. Cannot reference static member
19949 from an instance object. Is this an mcs bug?
19951 2002-09-14 Martin Baulig <martin@gnome.org>
19953 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
19954 multiple times. Fixes bug #30295, added test-166.cs.
19956 2002-09-14 Martin Baulig <martin@gnome.org>
19958 * statement.cs (Block.Emit): Don't emit unreachable code.
19959 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
19960 `break' statements.
19961 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
19963 2002-09-14 Martin Baulig <martin@gnome.org>
19965 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
19968 2002-09-14 Martin Baulig <martin@gnome.org>
19970 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
19971 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
19972 be false on the ms runtime.
19974 2002-09-13 Martin Baulig <martin@gnome.org>
19976 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
19977 the CS0038 error message.
19979 2002-09-12 Miguel de Icaza <miguel@ximian.com>
19981 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
19982 constant inside, return it.
19984 2002-09-12 Martin Baulig <martin@gnome.org>
19986 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
19987 implicit conversion can be done between enum types.
19989 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
19990 check whether an implicit conversion to the current enum's UnderlyingType
19991 exists and report an error if not.
19993 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
19994 without debugging support.
19996 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
19997 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
19999 2002-09-12 Martin Baulig <martin@gnome.org>
20001 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
20003 * ecore.cs (IMemberExpr.DeclaringType): New property.
20004 (SimpleName.SimpleNameResolve): Check whether we're accessing a
20005 nonstatic member of an outer type (CS0038).
20007 2002-09-11 Miguel de Icaza <miguel@ximian.com>
20009 * driver.cs: Activate the using-error detector at warning level
20010 4 (at least for MS-compatible APIs).
20012 * namespace.cs (VerifyUsing): Small buglett fix.
20014 * pending.cs (PendingImplementation): pass the container pointer.
20016 * interface.cs (GetMethods): Allow for recursive definition. Long
20017 term, I would like to move every type to support recursive
20018 definitions, not the current ordering mechanism that we have right
20021 The situation is this: Attributes are handled before interfaces,
20022 so we can apply attributes to interfaces. But some attributes
20023 implement interfaces, we will now handle the simple cases
20024 (recursive definitions will just get an error).
20026 * parameter.cs: Only invalidate types at the end if we fail to
20029 2002-09-09 Martin Baulig <martin@gnome.org>
20031 * ecore.cs (PropertyExpr.Emit): Also check for
20032 TypeManager.system_int_array_get_length so this'll also work when
20033 compiling corlib. Fixes #30003.
20035 2002-09-09 Martin Baulig <martin@gnome.org>
20037 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
20038 and throw an exception if we can't get the type's size. Fixed #30040,
20041 2002-09-09 Martin Baulig <martin@gnome.org>
20043 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
20045 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
20046 context. Fixes bug #30027.
20048 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
20049 virtual functions. Fixes bug #30043, added test-164.cs.
20051 2002-09-08 Ravi Pratap <ravi@ximian.com>
20053 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
20055 2002-09-08 Nick Drochak <ndrochak@gol.com>
20057 * driver.cs: Use an object to get the windows codepage since it's not a
20060 2002-09-08 Miguel de Icaza <miguel@ximian.com>
20062 * statement.cs (For.Emit): for infinite loops (test == null)
20063 return whether there is a break inside, not always "true".
20065 * namespace.cs (UsingEntry): New struct to hold the name of the
20066 using definition, the location where it is defined, and whether it
20067 has been used in a successful type lookup.
20069 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
20074 2002-09-06 Ravi Pratap <ravi@ximian.com>
20076 * attribute.cs : Fix incorrect code which relied on catching
20077 a NullReferenceException to detect a null being passed in
20078 where an object was expected.
20080 2002-09-06 Miguel de Icaza <miguel@ximian.com>
20082 * statement.cs (Try): flag the catch variable as assigned
20084 * expression.cs (Cast): Simplified by using ResolveType instead of
20085 manually resolving.
20087 * statement.cs (Catch): Fix bug by using ResolveType.
20089 2002-09-06 Ravi Pratap <ravi@ximian.com>
20091 * expression.cs (BetterConversion): Special case for when we have
20092 a NullLiteral as the argument and we have to choose between string
20093 and object types - we choose string the way csc does.
20095 * attribute.cs (Attribute.Resolve): Catch the
20096 NullReferenceException and report error #182 since the Mono
20097 runtime no more has the bug and having this exception raised means
20098 we tried to select a constructor which takes an object and is
20101 2002-09-05 Ravi Pratap <ravi@ximian.com>
20103 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
20104 message (1502, 1503) when we can't locate a method after overload
20105 resolution. This is much more informative and closes the bug
20108 * interface.cs (PopulateMethod): Return if there are no argument
20109 types. Fixes a NullReferenceException bug.
20111 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
20112 expressions too. Previously we were checking only in one place for
20113 positional arguments leaving out named arguments.
20115 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
20116 type to the enum type is not allowed. Remove code corresponding to
20119 (ConvertNumericExplicit): Allow explicit conversions from
20120 the underlying type to enum type. This precisely follows the spec
20121 and closes a bug filed by Gonzalo.
20123 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20126 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
20128 2002-09-03 Miguel de Icaza <miguel@ximian.com>
20130 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
20131 it was important that we stored the right value after the
20132 reduction in `converted'.
20134 2002-09-04 Martin Baulig <martin@gnome.org>
20136 * location.cs (Location.SymbolDocument): Use full pathnames for the
20139 2002-08-30 Miguel de Icaza <miguel@ximian.com>
20141 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
20142 of the expression resolve mechanism, because that will catch the
20143 SimpleName error failures.
20145 (Conditional): If we can not resolve the
20146 expression, return, do not crash.
20148 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20151 (location): display token name instead of its number.
20153 2002-08-28 Martin Baulig <martin@gnome.org>
20155 * expression.cs (Binary.ResolveOperator): Don't silently return
20156 but return an error if an operator cannot be applied between two
20159 2002-08-28 Martin Baulig <martin@gnome.org>
20161 * class.cs (Constructor.Define): Set the permission attributes
20162 correctly instead of making all constructors public.
20164 2002-08-28 Martin Baulig <martin@gnome.org>
20166 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
20167 for private members before reporting a CS0103; if we find anything,
20170 2002-08-28 Martin Baulig <martin@gnome.org>
20172 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
20173 to check whether `closure_start_type == closure_invocation_type',
20174 we also need to check whether `m.DeclaringType == closure_invocation_type'
20175 before bypassing the permission checks. We might be accessing
20176 protected/private members from the base class.
20177 (TypeManager.RealMemberLookup): Only set private_ok if private
20178 members were requested via BindingFlags.NonPublic.
20180 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
20182 * expression.cs (MemberAccess.ResolveMemberAccess): Set
20183 MethodGroupExpr.IsExplicitImpl if appropriate.
20184 (Invocation.DoResolve): Don't report the CS0120 for explicit
20185 interface implementations.
20187 2002-08-27 Martin Baulig <martin@gnome.org>
20189 * expression.cs (Invocation.DoResolve): If this is a static
20190 method and we don't have an InstanceExpression, we must report
20193 2002-08-25 Martin Baulig <martin@gnome.org>
20195 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
20196 `==' between a valuetype and an object.
20198 2002-08-25 Miguel de Icaza <miguel@ximian.com>
20200 * ecore.cs (TypeExpr): Provide a ToString method.
20202 2002-08-24 Martin Baulig <martin@gnome.org>
20204 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
20205 now called proggie.dbg and it's a binary file.
20207 2002-08-23 Martin Baulig <martin@gnome.org>
20209 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
20211 2002-08-23 Martin Baulig <martin@gnome.org>
20213 * struct.cs (MyStructInfo.ctor): Make this work with empty
20214 structs; it's not allowed to use foreach() on null.
20216 2002-08-23 Martin Baulig <martin@gnome.org>
20218 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
20219 writer the full pathname of the generated assembly.
20221 2002-08-23 Martin Baulig <martin@gnome.org>
20223 * statements.cs (FlowBranching.UsageVector.MergeChildren):
20224 A `finally' block never returns or breaks; improved handling of
20227 2002-08-23 Martin Baulig <martin@gnome.org>
20229 * statement.cs (Throw.Resolve): Allow `throw null'.
20231 2002-08-23 Martin Baulig <martin@gnome.org>
20233 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
20234 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
20235 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
20236 MemberLookup would return a wrong event if this is an explicit
20237 interface implementation and the class has an event with the same
20240 2002-08-23 Martin Baulig <martin@gnome.org>
20242 * statement.cs (Block.AddChildVariableNames): New public method.
20243 (Block.AddChildVariableName): Likewise.
20244 (Block.IsVariableNameUsedInChildBlock): Likewise.
20245 (Block.AddVariable): Check whether a variable name has already
20246 been used in a child block.
20248 * cs-parser.jay (declare_local_variables): Mark all variable names
20249 from the current block as being used in a child block in the
20252 2002-08-23 Martin Baulig <martin@gnome.org>
20254 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
20255 find the symbol writer.
20257 * driver.cs: csc also allows the arguments to /define being
20258 separated by commas, not only by semicolons.
20260 2002-08-23 Martin Baulig <martin@gnome.org>
20262 * interface.cs (Interface.GetMembers): Added static check for events.
20264 2002-08-15 Martin Baulig <martin@gnome.org>
20266 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
20267 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
20269 * ecore.cs (Expression.MemberLookup): Added documentation and explained
20270 why the MethodData.EmitDestructor() change was necessary.
20272 2002-08-20 Martin Baulig <martin@gnome.org>
20274 * class.cs (TypeContainer.FindMembers): Added static check for events.
20276 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
20278 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
20279 use Type.GetEvents(), not Type.FindMembers().
20281 2002-08-20 Martin Baulig <martin@gnome.org>
20283 * decl.cs (MemberCache): Added a special method cache which will
20284 be used for method-only searched. This ensures that a method
20285 search will return a MethodInfo with the correct ReflectedType for
20288 2002-08-20 Martin Baulig <martin@gnome.org>
20290 * decl.cs (DeclSpace.FindMembers): Made this public.
20292 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20294 * delegate.cs: fixed build on windows.
20295 [FIXME: Filed as bug #29150: MCS must report these errors.]
20297 2002-08-19 Ravi Pratap <ravi@ximian.com>
20299 * ecore.cs (StandardConversionExists): Return a false
20300 if we are trying to convert the void type to anything else
20301 since that is not allowed.
20303 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
20304 we flag error 70 in the event an event is trying to be accessed
20305 directly from outside the declaring type.
20307 2002-08-20 Martin Baulig <martin@gnome.org>
20309 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
20310 MemberCache from typemanager.cs to decl.cs.
20312 2002-08-19 Martin Baulig <martin@gnome.org>
20314 * class.cs (TypeContainer): Implement IMemberContainer.
20315 (TypeContainer.DefineMembers): Create the MemberCache.
20316 (TypeContainer.FindMembers): Do better BindingFlags checking; only
20317 return public members if BindingFlags.Public was given, check
20318 whether members are static.
20320 2002-08-16 Martin Baulig <martin@gnome.org>
20322 * decl.cs (DeclSpace.Define): Splitted this in Define and
20323 DefineMembers. DefineMembers is called first and initializes the
20326 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
20327 DefineMembers() on all our DeclSpaces.
20329 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
20330 but call DefineMembers() on all nested interfaces. We call their
20331 Define() in our new Define() function.
20333 * interface.cs (Interface): Implement IMemberContainer.
20334 (Interface.Define): Moved all code except the attribute stuf to
20336 (Interface.DefineMembers): Initialize the member cache.
20338 * typemanager.cs (IMemberFinder): Removed this interface, we don't
20339 need this anymore since we can use MemberCache.FindMembers directly.
20341 2002-08-19 Martin Baulig <martin@gnome.org>
20343 * typemanager.cs (MemberCache): When creating the cache for an
20344 interface type, add all inherited members.
20345 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
20346 to `out bool used_cache' and documented it.
20347 (TypeManager.MemberLookup): If we already used the cache in the first
20348 iteration, we don't need to do the interfaces check.
20350 2002-08-19 Martin Baulig <martin@gnome.org>
20352 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
20353 here from IMemberFinder and don't implement this interface anymore.
20354 (DeclSpace.MemberCache): Moved here from IMemberFinder.
20356 * typemanager.cs (IMemberFinder): This interface is now only used by
20357 classes which actually support the member cache.
20358 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
20359 since we only put DeclSpaces into this Hashtable.
20360 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
20361 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
20363 2002-08-16 Martin Baulig <martin@gnome.org>
20365 * typemanager.cs (ICachingMemberFinder): Removed.
20366 (IMemberFinder.MemberCache): New property.
20367 (TypeManager.FindMembers): Merged this with RealFindMembers().
20368 This function will never be called from TypeManager.MemberLookup()
20369 so we can't use the cache here, just the IMemberFinder.
20370 (TypeManager.MemberLookup_FindMembers): Check whether the
20371 IMemberFinder has a MemberCache and call the cache's FindMembers
20373 (MemberCache): Rewrote larger parts of this yet another time and
20374 cleaned it up a bit.
20376 2002-08-15 Miguel de Icaza <miguel@ximian.com>
20378 * driver.cs (LoadArgs): Support quoting.
20380 (Usage): Show the CSC-like command line arguments.
20382 Improved a few error messages.
20384 2002-08-15 Martin Baulig <martin@gnome.org>
20386 * typemanager.cs (IMemberContainer.Type): New property.
20387 (IMemberContainer.IsInterface): New property.
20389 The following changes are conditional to BROKEN_RUNTIME, which is
20390 defined at the top of the file.
20392 * typemanager.cs (MemberCache.MemberCache): Don't add the base
20393 class'es members, but add all members from TypeHandle.ObjectType
20394 if we're an interface.
20395 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
20396 is the current type.
20397 (MemberCache.CacheEntry.Container): Removed this field.
20398 (TypeHandle.GetMembers): Include inherited members.
20400 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20402 * typemanager.cs: fixed compilation and added a comment on a field that
20405 2002-08-15 Martin Baulig <martin@gnome.org>
20407 * class.cs (ConstructorInitializer.Resolve): In the
20408 Expression.MemberLookup call, use the queried_type as
20411 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
20412 declared' attribute, it's always true.
20413 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
20414 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
20415 temporary wrapper for FindMembers which tells MemberLookup whether
20416 members from the base classes are included in the return value.
20417 This will go away soon.
20418 (TypeManager.MemberLookup): Use this temporary hack here; once the
20419 new MemberCache is completed, we don't need to do the DeclaredOnly
20420 looping here anymore since the MemberCache will take care of this.
20421 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
20422 (MemberCache): When creating the MemberCache for a class, get
20423 members from the current class and all its base classes.
20424 (MemberCache.CacheEntry.Container): New field. This is a
20425 temporary hack until the Mono runtime is fixed to distinguish
20426 between ReflectedType and DeclaringType. It allows us to use MCS
20427 with both the MS runtime and the unfixed Mono runtime without
20428 problems and without accecting performance.
20429 (MemberCache.SearchMembers): The DeclaredOnly looping from
20430 TypeManager.MemberLookup is now done here.
20432 2002-08-14 Martin Baulig <martin@gnome.org>
20434 * statement.cs (MyStructInfo.MyStructInfo): Don't call
20435 Type.GetFields on dynamic types but get the fields from the
20436 corresponding TypeContainer.
20437 (MyStructInfo.GetStructInfo): Added check for enum types.
20439 * typemanager.cs (MemberList.IsSynchronized): Implemented.
20440 (MemberList.SyncRoot): Implemented.
20441 (TypeManager.FilterWithClosure): No need to check permissions if
20442 closure_start_type == closure_invocation_type, don't crash if
20443 closure_invocation_type is null.
20445 2002-08-13 Martin Baulig <martin@gnome.org>
20447 Rewrote TypeContainer.FindMembers to use a member cache. This
20448 gives us a speed increase of about 35% for the self-hosting MCS
20449 build and of about 15-20% for the class libs (both on GNU/Linux).
20451 * report.cs (Timer): New class to get enhanced profiling. This
20452 whole class is "TIMER" conditional since it remarkably slows down
20455 * class.cs (MemberList): New class. This is an IList wrapper
20456 which we're now using instead of passing MemberInfo[]'s around to
20457 avoid copying this array unnecessarily.
20458 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
20459 (ICachingMemberFinder, IMemberContainer): New interface.
20460 (TypeManager.FilterWithClosure): If `criteria' is null, the name
20461 has already been checked, otherwise use it for the name comparision.
20462 (TypeManager.FindMembers): Renamed to RealMemberFinder and
20463 provided wrapper which tries to use ICachingMemberFinder.FindMembers
20464 if possible. Returns a MemberList, not a MemberInfo [].
20465 (TypeHandle): New class, implements IMemberContainer. We create
20466 one instance of this class per type, it contains a MemberCache
20467 which is used to do the member lookups.
20468 (MemberCache): New class. Each instance of this class contains
20469 all members of a type and a name-based hash table.
20470 (MemberCache.FindMembers): This is our new member lookup
20471 function. First, it looks up all members of the requested name in
20472 the hash table. Then, it walks this list and sorts out all
20473 applicable members and returns them.
20475 2002-08-13 Martin Baulig <martin@gnome.org>
20477 In addition to a nice code cleanup, this gives us a performance
20478 increase of about 1.4% on GNU/Linux - not much, but it's already
20479 half a second for the self-hosting MCS compilation.
20481 * typemanager.cs (IMemberFinder): New interface. It is used by
20482 TypeManager.FindMembers to call FindMembers on a TypeContainer,
20483 Enum, Delegate or Interface.
20484 (TypeManager.finder_to_member_finder): New PtrHashtable.
20485 (TypeManager.finder_to_container): Removed.
20486 (TypeManager.finder_to_delegate): Removed.
20487 (TypeManager.finder_to_interface): Removed.
20488 (TypeManager.finder_to_enum): Removed.
20490 * interface.cs (Interface): Implement IMemberFinder.
20492 * delegate.cs (Delegate): Implement IMemberFinder.
20494 * enum.cs (Enum): Implement IMemberFinder.
20496 * class.cs (TypeContainer): Implement IMemberFinder.
20498 2002-08-12 Martin Baulig <martin@gnome.org>
20500 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
20502 2002-08-12 Martin Baulig <martin@gnome.org>
20504 * ecore.cs (ITypeExpression): New interface for expressions which
20506 (TypeExpression): Renamed to TypeLookupExpression.
20507 (Expression.DoResolve): If we're doing a types-only lookup, the
20508 expression must implement the ITypeExpression interface and we
20509 call DoResolveType() on it.
20510 (SimpleName): Implement the new ITypeExpression interface.
20511 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
20512 hack, the situation that we're only looking up types can't happen
20513 anymore when this method is called. Moved the type lookup code to
20514 DoResolveType() and call it.
20515 (SimpleName.DoResolveType): This ITypeExpression interface method
20516 is now doing the types-only lookup.
20517 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
20518 (ResolveFlags): Added MaskExprClass.
20520 * expression.cs (MemberAccess): Implement the ITypeExpression
20522 (MemberAccess.DoResolve): Added support for a types-only lookup
20523 when we're called via ITypeExpression.DoResolveType().
20524 (ComposedCast): Implement the ITypeExpression interface.
20526 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
20527 Expression.Resolve() with ResolveFlags.Type instead.
20529 2002-08-12 Martin Baulig <martin@gnome.org>
20531 * interface.cs (Interface.Define): Apply attributes.
20533 * attribute.cs (Attribute.ApplyAttributes): Added support for
20534 interface attributes.
20536 2002-08-11 Martin Baulig <martin@gnome.org>
20538 * statement.cs (Block.Emit): Only check the "this" variable if we
20539 do not always throw an exception.
20541 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
20542 whether the property has a set accessor.
20544 2002-08-11 Martin Baulig <martin@gnome.org>
20546 Added control flow analysis support for structs.
20548 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
20549 with control flow analysis turned off.
20550 (IVariable): New interface.
20551 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
20552 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
20553 (FieldExpr.DoResolve): Resolve the instance expression with flow
20554 analysis turned off and do the definite assignment check after the
20555 resolving when we know what the expression will resolve to.
20557 * expression.cs (LocalVariableReference, ParameterReference):
20558 Implement the new IVariable interface, only call the flow analysis
20559 code if ec.DoFlowAnalysis is true.
20560 (This): Added constructor which takes a Block argument. Implement
20561 the new IVariable interface.
20562 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
20563 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
20564 This does the definite assignment checks for struct members.
20566 * class.cs (Constructor.Emit): If this is a non-static `struct'
20567 constructor which doesn't have any initializer, call
20568 Block.AddThisVariable() to tell the flow analysis code that all
20569 struct elements must be initialized before control returns from
20572 * statement.cs (MyStructInfo): New public class.
20573 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
20574 argument to this indexer. If non-zero, check an individual struct
20575 member, not the whole struct.
20576 (FlowBranching.CheckOutParameters): Check struct members.
20577 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
20578 overloaded versions of these methods which take an additional
20579 `int field_idx' argument to check struct members.
20580 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
20581 overloaded versions of these methods which take an additional
20582 `string field_name' argument to check struct member.s
20583 (VariableInfo): Implement the IVariable interface.
20584 (VariableInfo.StructInfo): New public property. Returns the
20585 MyStructInfo instance of the variable if it's a struct or null.
20586 (Block.AddThisVariable): New public method. This is called from
20587 Constructor.Emit() for non-static `struct' constructor which do
20588 not have any initializer. It creates a special variable for the
20589 "this" instance variable which will be checked by the flow
20590 analysis code to ensure that all of the struct's fields are
20591 initialized before control returns from the constructor.
20592 (UsageVector): Added support for struct members. If a
20593 variable/parameter is a struct with N members, we reserve a slot
20594 in the usage vector for each member. A struct is considered fully
20595 initialized if either the struct itself (slot 0) or all its
20596 members are initialized.
20598 2002-08-08 Martin Baulig <martin@gnome.org>
20600 * driver.cs (Driver.MainDriver): Only report an error CS5001
20601 if there were no compilation errors.
20603 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
20604 `UnsafeContext' property to determine whether the parent is in
20605 unsafe context rather than checking the parent's ModFlags:
20606 classes nested in an unsafe class are unsafe as well.
20608 2002-08-08 Martin Baulig <martin@gnome.org>
20610 * statement.cs (UsageVector.MergeChildren): Distinguish between
20611 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
20612 we return. Added test17() and test18() to test-154.cs.
20614 2002-08-08 Martin Baulig <martin@gnome.org>
20616 * typemanager.cs (TypeManager.FilterWithClosure): If we have
20617 Family access, make sure the invoking type isn't a subclass of the
20618 queried type (that'd be a CS1540).
20620 * ecore.cs (Expression.MemberLookup): Added overloaded version of
20621 this method which takes an additional `Type invocation_type'.
20623 * expression.cs (BaseAccess.DoResolve): Use the base type as
20624 invocation and query type.
20625 (MemberAccess.DoResolve): If the lookup failed and we're about to
20626 report a CS0122, try a lookup with the ec.ContainerType - if this
20627 succeeds, we must report a CS1540.
20629 2002-08-08 Martin Baulig <martin@gnome.org>
20631 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
20632 (MethodGroupExpr): Implement the IMemberExpr interface.
20634 * expression (MemberAccess.ResolveMemberAccess): No need to have
20635 any special code for MethodGroupExprs anymore, they're now
20638 2002-08-08 Martin Baulig <martin@gnome.org>
20640 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
20641 Family, FamANDAssem and FamORAssem permissions.
20642 (TypeManager.IsSubclassOrNestedChildOf): New public method.
20644 2002-08-08 Martin Baulig <martin@gnome.org>
20646 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
20647 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
20650 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
20652 * driver.cs: implemented /resource option to embed managed resources.
20654 2002-08-07 Martin Baulig <martin@gnome.org>
20656 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
20657 (FieldBase.HasFieldInitializer): New public property.
20658 (FieldBase.GetInitializerExpression): New public method. Resolves and
20659 returns the field initializer and makes sure it is only resolved once.
20660 (TypeContainer.EmitFieldInitializers): Call
20661 FieldBase.GetInitializerExpression to get the initializer, this ensures
20662 that it isn't resolved multiple times.
20664 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
20665 the resolving process (SimpleName/MemberLookup) that we're currently
20666 emitting a field initializer (which must not access any instance members,
20667 this is an error CS0236).
20669 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
20670 argument, if the `IsFieldInitializer' flag is set, we must report and
20671 error CS0236 and not an error CS0120.
20673 2002-08-07 Martin Baulig <martin@gnome.org>
20675 * ecore.cs (IMemberExpr): New public interface.
20676 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
20677 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
20678 if the expression is an IMemberExpr.
20680 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
20681 to be null, implicitly default to `this' if we're non-static in
20682 this case. Simplified the code a lot by using the new IMemberExpr
20683 interface. Also fixed bug #28176 here.
20685 2002-08-06 Martin Baulig <martin@gnome.org>
20687 * cs-parser.jay (SimpleLookup): Removed. We need to create
20688 ParameterReferences during semantic analysis so that we can do a
20689 type-only search when resolving Cast, TypeOf and SizeOf.
20690 (block): Pass the `current_local_parameters' to the Block's
20693 * class.cs (ConstructorInitializer): Added `Parameters parameters'
20694 argument to the constructor.
20695 (ConstructorInitializer.Resolve): Create a temporary implicit
20696 block with the parameters.
20698 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
20699 references here if we aren't doing a type-only search.
20701 * statement.cs (Block): Added constructor which takes a
20702 `Parameters parameters' argument.
20703 (Block.Parameters): New public property.
20705 * support.cs (InternalParameters.Parameters): Renamed `parameters'
20706 to `Parameters' and made it public readonly.
20708 2002-08-06 Martin Baulig <martin@gnome.org>
20710 * ecore.cs (Expression.Warning): Made this public as well.
20712 * report.cs (Report.Debug): Print the contents of collections.
20714 2002-08-06 Martin Baulig <martin@gnome.org>
20716 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
20717 used to tell Resolve() which kinds of expressions it may return.
20718 (Expression.Resolve): Added overloaded version of this method which
20719 takes a `ResolveFlags flags' argument. This can be used to tell
20720 Resolve() which kinds of expressions it may return. Reports a
20722 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
20723 ResolveFlags.SimpleName.
20724 (Expression.Error118): Added overloaded version of this method which
20725 takes a `ResolveFlags flags' argument. It uses the flags to determine
20726 which kinds of expressions are allowed.
20728 * expression.cs (Argument.ResolveMethodGroup): New public method.
20729 Resolves an argument, but allows a MethodGroup to be returned.
20730 This is used when invoking a delegate.
20732 * TODO: Updated a bit.
20734 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20736 Fixed compilation with csc.
20738 * ecore.cs: Expression.Error made public. Is this correct? Should
20739 Warning be made public too?
20741 * expression.cs: use ea.Location instead of ea.loc.
20742 [FIXME: Filed as bug #28607: MCS must report these errors.]
20744 2002-08-06 Martin Baulig <martin@gnome.org>
20746 * ecore.cs (Expression.loc): Moved the location here instead of
20747 duplicating it in all derived classes.
20748 (Expression.Location): New public property.
20749 (Expression.Error, Expression.Warning): Made them non-static and
20750 removed the location argument.
20751 (Expression.Warning): Added overloaded version which takes an
20752 `int level' argument.
20753 (Expression.Error118): Make this non-static and removed the
20754 expression and location arguments.
20755 (TypeExpr): Added location argument to the constructor.
20757 * expression.cs (StaticCallExpr): Added location argument to
20759 (Indirection, PointerArithmetic): Likewise.
20760 (CheckedExpr, UnCheckedExpr): Likewise.
20761 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
20762 (StringPtr): Likewise.
20765 2002-08-05 Martin Baulig <martin@gnome.org>
20767 * expression.cs (BaseAccess.DoResolve): Actually report errors.
20769 * assign.cs (Assign.DoResolve): Check whether the source
20770 expression is a value or variable.
20772 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
20773 while resolving the corresponding blocks.
20775 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
20776 an error, don't silently return null.
20778 * statement.cs (Block.AddVariable): Do the error reporting here
20779 and distinguish between CS0128 and CS0136.
20780 (Block.DoResolve): Report all unused labels (warning CS0164).
20781 (LabeledStatement): Pass the location to the constructor.
20782 (LabeledStatement.HasBeenReferenced): New property.
20783 (LabeledStatement.Resolve): Set it to true here.
20785 * statement.cs (Return.Emit): Return success even after reporting
20786 a type mismatch error (CS0126 or CS0127), this is what csc does and
20787 it avoids confusing the users with any consecutive errors.
20789 2002-08-05 Martin Baulig <martin@gnome.org>
20791 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
20793 * const.cs (Const.LookupConstantValue): Catch circular definitions.
20795 * expression.cs (MemberAccess.DoResolve): Silently return if an
20796 error has already been reported.
20798 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
20799 error has already been reported.
20801 2002-08-05 Martin Baulig <martin@gnome.org>
20803 * statement.cs (UsageVector): Only initialize the `parameters'
20804 vector if we actually have any "out" parameters.
20806 2002-08-05 Martin Baulig <martin@gnome.org>
20808 * expression.cs (Binary.ResolveOperator): When combining delegates,
20809 they must have the same type.
20811 2002-08-05 Martin Baulig <martin@gnome.org>
20813 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
20814 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
20815 work with the ms runtime and we also don't need it: if we're a
20816 PropertyBuilder and not in the `indexer_arguments' hash, then we
20817 are a property and not an indexer.
20819 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
20820 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
20821 since the latter one doesn't work with the ms runtime.
20823 2002-08-03 Martin Baulig <martin@gnome.org>
20825 Fixed bugs #27998 and #22735.
20827 * class.cs (Method.IsOperator): New public field.
20828 (Method.CheckBase): Report CS0111 if there's already a method
20829 with the same parameters in the current class. Report CS0508 when
20830 attempting to change the return type of an inherited method.
20831 (MethodData.Emit): Report CS0179 if a method doesn't have a body
20832 and it's not marked abstract or extern.
20833 (PropertyBase): New abstract base class for Property and Indexer.
20834 (PropertyBase.CheckBase): Moved here from Property and made it work
20836 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
20837 the same so we can reuse it there.
20838 (Property, Indexer): Derive from PropertyBase.
20839 (MethodSignature.inheritable_property_signature_filter): New delegate
20840 to find properties and indexers.
20842 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
20843 argument and improved error reporting.
20845 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
20846 EmptyReadOnlyParameters and made it a property.
20848 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
20849 version of this method which takes a `PropertyInfo indexer'.
20850 (TypeManager.RegisterIndexer): New method.
20852 * class.cs: Added myself as author of this file :-)
20854 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20856 * class.cs: fixed compilation on windoze.
20858 2002-08-03 Martin Baulig <martin@gnome.org>
20860 * interface.cs (Interface.GetInterfaceBases): Check whether all
20861 base interfaces are at least as accessible than the current one.
20863 * class.cs (TypeContainer.GetClassBases): Check whether base types
20864 are at least as accessible than the current type.
20865 (TypeContainer.AsAccessible): Implemented and made non-static.
20866 (MemberBase.CheckParameters): Report errors if the accessibility
20869 * delegate.cs (Delegate.Delegate): The default visibility is
20870 internal for top-level types and private for nested types.
20871 (Delegate.Define): Report errors if the accessibility checks fail.
20873 * enum.cs (Enum.Enum): The default visibility is internal for
20874 top-level types and private for nested types.
20875 (Enum.DefineType): Compute the correct visibility.
20877 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
20878 function which takes a `bool is_toplevel' instead of a TypeContainer.
20880 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
20883 2002-08-02 Martin Baulig <martin@gnome.org>
20885 * expression.cs (LocalVariableReferenc): Added constructor which
20886 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
20887 (LocalVariableReference.IsReadOnly): New property.
20888 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
20889 variable is readonly, use our own readonly flag to do this; you can
20890 use the new constructor to get a writable reference to a read-only
20893 * cs-parser.jay (foreach_statement, using_statement): Get a writable
20894 reference to the local variable.
20896 2002-08-01 Miguel de Icaza <miguel@ximian.com>
20898 * rootcontext.cs (ResolveCore): Also include System.Exception
20900 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
20901 we reach an EmptyStatement.
20903 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
20906 * expression.cs (Binary.ResolveOperator): Check error result in
20909 use brtrue/brfalse directly and avoid compares to null.
20911 2002-08-02 Martin Baulig <martin@gnome.org>
20913 * class.cs (TypeContainer.Define): Define all nested interfaces here.
20914 Fixes bug #28407, added test-155.cs.
20916 2002-08-01 Martin Baulig <martin@gnome.org>
20918 * class.cs (Event.EmitDefaultMethod): Make this work with static
20919 events. Fixes #28311, added verify-3.cs.
20921 2002-08-01 Martin Baulig <martin@gnome.org>
20923 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
20924 `is_disposable' fields.
20925 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
20926 `hm.is_disposable' if we're using the collection pattern.
20927 (Foreach.EmitCollectionForeach): Use the correct type for the
20928 enumerator's local variable, only emit the try/finally block if
20929 necessary (fixes #27713).
20931 2002-08-01 Martin Baulig <martin@gnome.org>
20933 * ecore.cs (Expression.report118): Renamed to Error118 and made
20936 * statement.cs (Throw.Resolve): Check whether the expression is of
20937 the correct type (CS0118) and whether the type derives from
20938 System.Exception (CS0155).
20939 (Catch.Resolve): New method. Do the type lookup here and check
20940 whether it derives from System.Exception (CS0155).
20941 (Catch.CatchType, Catch.IsGeneral): New public properties.
20943 * typemanager.cs (TypeManager.exception_type): Added.
20945 2002-07-31 Miguel de Icaza <miguel@ximian.com>
20947 * driver.cs: Updated About function.
20949 2002-07-31 Martin Baulig <martin@gnome.org>
20951 Implemented Control Flow Analysis.
20953 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
20954 (EmitContext.CurrentBranching): Added.
20955 (EmitContext.StartFlowBranching): Added.
20956 (EmitContext.EndFlowBranching): Added.
20957 (EmitContext.KillFlowBranching): Added.
20958 (EmitContext.IsVariableAssigned): Added.
20959 (EmitContext.SetVariableAssigned): Added.
20960 (EmitContext.IsParameterAssigned): Added.
20961 (EmitContext.SetParameterAssigned): Added.
20962 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
20963 Added control flow analysis stuff here.
20965 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
20966 resolve the expression as lvalue.
20967 (LocalVariableReference.DoResolve): Check whether the variable has
20968 already been assigned.
20969 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
20970 the parameter as assigned here.
20971 (ParameterReference.DoResolve): Check whether the parameter has already
20973 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
20974 expression as lvalue.
20976 * statement.cs (FlowBranching): New class for the flow analysis code.
20977 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
20978 (LabeledStatement.IsDefined): New public property.
20979 (LabeledStatement.AddUsageVector): New public method to tell flow
20980 analyis that the label may be reached via a forward jump.
20981 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
20983 (VariableInfo.Number): New public field. This is used by flow analysis
20984 to number all locals of a block.
20985 (Block.CountVariables): New public property. This is the number of
20986 local variables in this block (including the locals from all parent
20988 (Block.EmitMeta): Number all the variables.
20990 * statement.cs: Added flow analysis support to all classes.
20992 2002-07-31 Martin Baulig <martin@gnome.org>
20994 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
20995 To get debugging messages, compile mcs with /define:MCS_DEBUG and
20996 then use this argument.
20998 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
21000 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
21001 use this to specify /define options.
21003 2002-07-29 Martin Baulig <martin@gnome.org>
21005 * statement.cs (Fixed): Moved all code that does variable lookups
21006 and resolvings from Emit to Resolve.
21008 * statement.cs (For): Moved all code that does variable lookups
21009 and resolvings from Emit to Resolve.
21011 * statement.cs (Using): Moved all code that does variable lookups
21012 and resolvings from Emit to Resolve.
21014 2002-07-29 Martin Baulig <martin@gnome.org>
21016 * attribute.cs (Attribute.Resolve): Explicitly catch a
21017 System.NullReferenceException when creating the
21018 CustromAttributeBuilder and report a different warning message.
21020 2002-07-29 Martin Baulig <martin@gnome.org>
21022 * support.cs (ParameterData.ParameterName): Added method to
21023 get the name of a parameter.
21025 * typemanager.cs (TypeManager.IsValueType): New public method.
21027 2002-07-29 Martin Baulig <martin@gnome.org>
21029 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
21030 is a flag which specifies that it's either ref or out.
21031 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
21032 the out parameter to `out Parameter.Modifier mod', also set the
21033 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
21035 * support.cs (InternalParameters.ParameterModifier): Distinguish
21036 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
21037 Parameter.Modifier.ISBYREF flag if it's either ref or out.
21039 * expression.cs (Argument.GetParameterModifier): Distinguish
21040 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
21041 Parameter.Modifier.ISBYREF flag if it's either ref or out.
21043 2002-07-29 Martin Baulig <martin@gnome.org>
21045 * expression.cs (ParameterReference.ParameterReference): Added
21046 `Location loc' argument to the constructor.
21048 * cs-parser.jay: Pass location to ParameterReference.
21050 2002-07-28 Miguel de Icaza <miguel@ximian.com>
21052 * statement.cs (Try): Initialize the location.
21054 * cs-parser.jay: pass location to Try.
21056 * expression.cs (Unary.Reduce): Change the prototype to return
21057 whether a constant fold could be performed or not. The result is
21058 returned in an out parameters. In the case of Indirection and
21059 AddressOf, we want to perform the full tests.
21061 2002-07-26 Miguel de Icaza <miguel@ximian.com>
21063 * statement.cs (Statement.Emit): Flag dead code.
21065 2002-07-27 Andrew Birkett <andy@nobugs.org>
21067 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
21069 2002-07-27 Martin Baulig <martin@gnome.org>
21071 * class.cs (MethodData.Define): Put back call to
21072 TypeManager.AddMethod(), accidentally commented this out.
21074 * report.cs (Debug): New public method to print debugging information,
21075 this is `[Conditional ("DEBUG")]'.
21077 2002-07-26 Martin Baulig <martin@gnome.org>
21079 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
21080 (switch_statement): Push the current_block to the switch_stack and
21081 pop it again when we're done with the switch.
21082 (switch_section): The new block is a child of the current_block.
21083 Fixes bug #24007, added test-152.cs.
21085 2002-07-27 Martin Baulig <martin@gnome.org>
21087 * expression.cs (Invocation.EmitArguments): When calling a varargs
21088 function with only its fixed arguments, we need to pass an empty
21091 2002-07-27 Martin Baulig <martin@gnome.org>
21093 Mono 0.13 has been released.
21095 2002-07-25 Miguel de Icaza <miguel@ximian.com>
21097 * driver.cs: Rename --resource to --linkres, because that is what
21098 we do currently, we dont support --resource yet.
21100 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
21102 2002-07-25 Martin Baulig <martin@gnome.org>
21104 * class.cs (MethodData): New public class. This is a `method builder'
21105 class for a method or one accessor of a Property/Indexer/Event.
21106 (MethodData.GetMethodFlags): Moved here from MemberBase.
21107 (MethodData.ApplyAttributes): Likewise.
21108 (MethodData.ApplyObsoleteAttribute): Likewise.
21109 (MethodData.ApplyConditionalAttribute): Likewise.
21110 (MethodData.ApplyDllImportAttribute): Likewise.
21111 (MethodData.CheckAbstractAndExternal): Likewise.
21112 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
21113 (MethodData.Emit): Formerly known as Method.Emit().
21114 (MemberBase): Moved everything which was specific to a single
21115 accessor/method to MethodData.
21116 (Method): Create a new MethodData and call Define() and Emit() on it.
21117 (Property, Indexer, Event): Create a new MethodData objects for each
21118 accessor and call Define() and Emit() on them.
21120 2002-07-25 Martin Baulig <martin@gnome.org>
21122 Made MethodCore derive from MemberBase to reuse the code from there.
21123 MemberBase now also checks for attributes.
21125 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
21126 (MemberBase.GetMethodFlags): Moved here from class Method and marked
21128 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
21129 `CallingConventions cc' and `Attributes opt_attrs' arguments.
21130 (MemberBase.ApplyAttributes): New virtual method; applies the
21131 attributes to a method or accessor.
21132 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
21133 (MemberBase.ApplyConditionalAttribute): Likewise.
21134 (MemberBase.ApplyDllImportAttribute): Likewise.
21135 (MemberBase.CheckAbstractAndExternal): Likewise.
21136 (MethodCore.ParameterTypes): This is now a property instead of a
21137 method, it's initialized from DoDefineParameters().
21138 (MethodCore.ParameterInfo): Removed the set accessor.
21139 (MethodCore.DoDefineParameters): New protected virtual method to
21140 initialize ParameterTypes and ParameterInfo.
21141 (Method.GetReturnType): We can now simply return the MemberType.
21142 (Method.GetMethodFlags): Override the MemberBase version and add
21143 the conditional flags.
21144 (Method.CheckBase): Moved some code from Define() here, call
21145 DoDefineParameters() here.
21146 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
21147 here to avoid some larger code duplication.
21148 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
21149 ensure that abstract and external accessors don't declare a body.
21151 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
21152 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
21153 lookup in the attribute's parent classes, so we need to abort as soon
21154 as we found the first match.
21155 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
21156 the attribute has no arguments.
21158 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
21161 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21163 * cs-parser.jay: reverted previous patch.
21165 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21167 * cs-parser.jay: fixed bug #22119.
21169 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21171 * attribute.cs: fixed compilation. The error was:
21172 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
21173 be assigned to before control leaves the current method."
21174 [FIXME: Filed as bug #28186: MCS must report this error.]
21176 2002-07-25 Martin Baulig <martin@gnome.org>
21178 * attribute.cs (Attribute.Conditional_GetConditionName): New static
21179 method to pull the condition name ouf of a Conditional attribute.
21180 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
21181 the obsolete message and error flag out of an Obsolete attribute.
21183 * class.cs (Method.GetMethodFlags): New public method to get the
21184 TypeManager.MethodFlags for this method.
21185 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
21187 (Method.Define): Get and apply the Obsolete and Conditional attributes;
21188 if we're overriding a virtual function, set the new private variable
21189 `parent_method'; call the new TypeManager.AddMethod().
21191 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
21192 the MethodBuilder and the Method in a PtrHashtable.
21193 (TypeManager.builder_to_method): Added for this purpose.
21194 (TypeManager.MethodFlags): Added IsObsoleteError.
21195 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
21196 Obsolete and Conditional arguments in MethodBuilders. If we discover
21197 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
21198 the message from the attribute.
21200 2002-07-24 Martin Baulig <martin@gnome.org>
21202 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
21203 preprocessor directives, ensure that the argument to #define/#undef is
21204 exactly one identifier and that it's actually an identifier.
21206 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
21209 2002-07-24 Martin Baulig <martin@gnome.org>
21211 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
21212 initialize it to TypeManager.object_type in the constructor.
21213 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
21214 of the `hm.get_current' method if we're using the collection pattern.
21215 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
21216 for the explicit conversion to make it work when we're using the collection
21217 pattern and the `Current' property has a different return type than `object'.
21220 2002-07-24 Martin Baulig <martin@gnome.org>
21222 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
21223 does not match, but don't report any errors. This method is called in
21224 order for all methods in a MethodGroupExpr until a matching method is
21225 found, so we don't want to bail out if the first method doesn't match.
21226 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
21227 matches, report the 123. Fixes #28070.
21229 2002-07-24 Martin Baulig <martin@gnome.org>
21231 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
21232 TypeManager.TypeToCoreType() to the top of the method so the
21233 following equality checks will work. Fixes #28107.
21235 2002-07-24 Martin Baulig <martin@gnome.org>
21237 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
21238 operand is of type uint, and the other operand is of type sbyte,
21239 short or int, the operands are converted to type long." -
21240 Actually do what this comment already told us. Fixes bug #28106,
21243 2002-07-24 Martin Baulig <martin@gnome.org>
21245 * class.cs (MethodBase): New abstract class. This is now a base
21246 class for Property, Indexer and Event to avoid some code duplication
21247 in their Define() and DefineMethods() methods.
21248 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
21249 generic methods for Define() and DefineMethods().
21250 (FieldBase): Derive from MemberBase, not MemberCore.
21251 (Property): Derive from MemberBase, not MemberCore.
21252 (Property.DefineMethod): Moved all the code from this method to the
21253 new MethodBase.DefineAccessor(), just call it with appropriate
21255 (Property.Define): Call the new Property.DoDefine(), this does some
21256 sanity checks and we don't need to duplicate the code everywhere.
21257 (Event): Derive from MemberBase, not MemberCore.
21258 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
21259 accessors, this will also make them work with interface events.
21260 (Indexer): Derive from MemberBase, not MemberCore.
21261 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
21262 (Indexer.Define): Use the new MethodBase functions.
21264 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
21265 argument to the constructor.
21266 (Interface.FindMembers): Added support for interface events.
21267 (Interface.PopluateEvent): Implemented.
21269 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
21271 2002-07-22 Miguel de Icaza <miguel@ximian.com>
21273 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
21274 but this is required to check for a method name being the same as
21275 the containing class.
21279 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21281 * interface.cs: initialize variable.
21283 2002-07-23 Martin Baulig <martin@gnome.org>
21285 Implemented the IndexerName attribute in interfaces.
21287 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
21288 name if this is an explicit interface implementation.
21289 (Indexer.InterfaceIndexerName): New public variable. If we're
21290 implementing an interface indexer, this is the IndexerName in that
21291 interface. Otherwise, it's the IndexerName.
21292 (Indexer.DefineMethod): If we're implementing interface indexer,
21293 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
21294 and Pending.ImplementIndexer methods.
21295 (Indexer.Define): Also define the PropertyBuilder if we're
21296 implementing an interface indexer and this is neither an explicit
21297 interface implementation nor do the IndexerName match the one in
21300 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
21301 If a method is defined here, then we always need to create a proxy
21302 for it. This is used when implementing interface indexers.
21303 (Pending.IsInterfaceIndexer): New public method.
21304 (Pending.ImplementIndexer): New public method.
21305 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
21306 This is used when implementing interface indexers to define a proxy
21308 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
21309 define a proxy if necessary.
21311 * interface.cs (Interface.IndexerName): New public variable.
21312 (Interface.PopulateIndexer): Set the IndexerName.
21313 (Interface.DefineIndexers): New private method. Populate all the
21314 indexers and make sure their IndexerNames match.
21316 * typemanager.cs (IndexerPropertyName): Added support for interface
21319 2002-07-22 Martin Baulig <martin@gnome.org>
21321 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
21322 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
21323 ret if HasReturnLabel.
21324 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
21327 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
21328 and set the ec.LoopBeginTryCatchLevel.
21329 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
21330 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
21331 the current ec.TryCatchLevel, the branch goes out of an exception
21332 block. In this case, we need to use Leave and not Br.
21334 2002-07-22 Martin Baulig <martin@gnome.org>
21336 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
21337 block unless the block does not always return or it is contained in
21338 another try { ... } catch { ... } block. Fixes bug #26506.
21339 Added verify-1.cs to the test suite.
21341 2002-07-22 Martin Baulig <martin@gnome.org>
21343 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
21344 then we do not always return. Fixes bug #24985.
21346 2002-07-22 Martin Baulig <martin@gnome.org>
21348 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
21349 lookup on a per-class level; ie. walk up the class hierarchy until we
21350 found at least one applicable method, then choose the best among them.
21351 Fixes bug #24463 and test-29.cs.
21353 2002-07-22 Martin Baulig <martin@gnome.org>
21355 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
21356 return types of the methods. The return type is not part of the
21357 signature and we must not check it to make the `new' modifier work.
21358 Fixes bug #27999, also added test-147.cs.
21359 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
21361 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
21362 on the method's return type.
21364 2002-07-21 Martin Baulig <martin@gnome.org>
21366 * assign.cs: Make this work if the rightmost source is a constant and
21367 we need to do an implicit type conversion. Also adding a few more tests
21368 to test-38.cs which should have caught this.
21370 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
21371 target in the makefile for this. The makefile.gnu is primarily intended
21372 for end-users who don't want to debug the compiler.
21374 2002-07-21 Martin Baulig <martin@gnome.org>
21376 * assign.cs: Improved the Assign class so it can now handle embedded
21377 assignments (X = Y = Z = something). As a side-effect this'll now also
21378 consume less local variables. test-38.cs now passes with MCS, added
21379 a few new test cases to that test.
21381 2002-07-20 Martin Baulig <martin@gnome.org>
21383 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
21384 instructions. Fixes bug #27977, also added test-146.cs.
21386 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21388 * cs-tokenizer.cs: fixed getHex ().
21390 2002-07-19 Martin Baulig <martin@gnome.org>
21392 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
21393 not Type.GetType() to lookup the array type. This is needed when
21394 we're constructing an array of a user-defined type.
21395 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
21396 single-dimensional arrays, but also for single-dimensial arrays of
21399 2002-07-19 Martin Baulig <martin@gnome.org>
21401 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
21402 this function is called, it's not allowed to share LocalBuilders
21403 among ILGenerators.
21405 2002-07-19 Martin Baulig <martin@gnome.org>
21407 * expression.cs (Argument.Resolve): Report an error 118 when trying
21408 to pass a type as argument.
21410 2002-07-18 Martin Baulig <martin@gnome.org>
21412 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
21413 Conv_R_Un for the signed `long' type.
21415 2002-07-15 Miguel de Icaza <miguel@ximian.com>
21417 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
21418 `expr' for the temporary result, as that will fail if we do
21419 multiple resolves on the same expression.
21421 2002-07-05 Miguel de Icaza <miguel@ximian.com>
21423 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
21424 ec.TypeContainer for looking up aliases.
21426 * class.cs (TypeContainer): Remove LookupAlias from here.
21428 * decl.cs (DeclSpace); Move here.
21430 2002-07-01 Miguel de Icaza <miguel@ximian.com>
21432 * class.cs (FindMembers): Only call filter if the constructor
21433 bulider is not null.
21435 Also handle delegates in `NestedTypes' now. Now we will perform
21436 type lookups using the standard resolution process. This also
21439 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
21440 This uses Expressions (the limited kind that can be parsed by the
21441 tree) instead of strings.
21443 * expression.cs (ComposedCast.ToString): Implement, used to flag
21444 errors since now we have to render expressions.
21446 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
21449 * ecore.cs (SimpleName.ToString): ditto.
21451 * cs-parser.jay: Instead of using strings to assemble types, use
21452 Expressions to assemble the type (using SimpleName, ComposedCast,
21453 MemberAccess). This should fix the type lookups in declarations,
21454 because we were using a different code path for this.
21456 * statement.cs (Block.Resolve): Continue processing statements
21457 even when there is an error.
21459 2002-07-17 Miguel de Icaza <miguel@ximian.com>
21461 * class.cs (Event.Define): Also remove the `remove' method from
21462 the list of pending items.
21464 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
21465 generate more compact code.
21467 2002-07-17 Martin Baulig <martin@gnome.org>
21469 * const.cs (Const.LookupConstantValue): Add support for constant
21470 `unchecked' and `checked' expressions.
21471 Also adding test case test-140.cs for this.
21473 2002-07-17 Martin Baulig <martin@gnome.org>
21475 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
21476 check whether mi.ReturnType implements the IEnumerator interface; the
21477 `==' and the IsAssignableFrom() will fail in this situation.
21479 2002-07-16 Ravi Pratap <ravi@ximian.com>
21481 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
21484 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21486 * expression.cs: fixed bug #27811.
21488 2002-07-14 Miguel de Icaza <miguel@ximian.com>
21490 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
21491 Molaro: when we are a ref, the value already contains a pointer
21492 value, do not take the address of it.
21494 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
21495 * removed mb-parser.jay and mb-tokenizer.cs
21497 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21499 * expression.cs: check against the building corlib void type.
21501 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
21503 * ecore.cs: fix for valuetype static readonly fields: when
21504 initializing them, we need their address, not the address of a copy.
21506 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
21508 * typemanager.cs: register also enum_type in corlib.
21510 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21512 * class.cs: allow calling this (but not base) initializers in structs.
21514 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
21516 * ecore.cs: make sure we compare against the building base types
21519 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
21521 * typemanager.cs: fix TypeToCoreType() to handle void and object
21522 (corlib gets no more typerefs after this change).
21524 2002-07-12 Miguel de Icaza <miguel@ximian.com>
21526 * expression.cs (ArrayCreation.EmitArrayArguments): use
21527 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
21529 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
21530 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
21531 array indexes, the runtime actually forbids them.
21533 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
21534 for array arguments here.
21536 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
21537 instead of the default for ValueTypes.
21539 (New.DoEmit): Use IsValueType instead of
21540 IsSubclassOf (value_type)
21541 (New.DoResolve): ditto.
21542 (Invocation.EmitCall): ditto.
21544 * assign.cs (Assign): ditto.
21546 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
21547 Statements *are* currently doing part of their resolution during
21550 Expressions do always resolve during resolve, but statements are
21551 only required to propagate resolution to their children.
21553 2002-07-11 Miguel de Icaza <miguel@ximian.com>
21555 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
21557 (LoadAssembly): Do not add the dll if it is already specified
21559 (MainDriver): Add the System directory to the link path at the end,
21560 after all the other -L arguments.
21562 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
21563 wrong opcode for loading bytes and bools (ldelem.i1 instead of
21564 ldelem.u1) and using the opposite for sbytes.
21566 This fixes Digger, and we can finally run it.
21568 * driver.cs (UnixParseOption): Move the option parsing here.
21569 (CSCParseOption): Implement CSC-like parsing of options.
21571 We now support both modes of operation, the old Unix way, and the
21572 new CSC-like way. This should help those who wanted to make cross
21573 platform makefiles.
21575 The only thing broken is that /r:, /reference: and /lib: are not
21576 implemented, because I want to make those have the same semantics
21577 as the CSC compiler has, and kill once and for all the confussion
21578 around this. Will be doing this tomorrow.
21580 * statement.cs (Unsafe.Resolve): The state is checked during
21581 resolve, not emit, so we have to set the flags for IsUnsfe here.
21583 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21585 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
21586 not catch the Error_ObjectRefRequired in SimpleName (as it is
21587 possible to have a class/instance variable name that later gets
21588 deambiguated), we have to check this here.
21590 2002-07-10 Ravi Pratap <ravi@ximian.com>
21592 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
21593 make static and put into Expression.
21595 (Event.Define): Register the private field of the event with the
21596 TypeManager so that GetFieldFromEvent can get at it.
21598 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
21599 keep track of the private field associated with an event which
21602 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
21605 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
21607 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21609 * expression.cs (Binary.EmitBranchable): this routine emits the
21610 Binary expression in a branchable context. This basically means:
21611 we need to branch somewhere, not just get the value on the stack.
21613 This works together with Statement.EmitBoolExpression.
21615 * statement.cs (Statement.EmitBoolExpression): Use
21618 2002-07-09 Miguel de Icaza <miguel@ximian.com>
21620 * statement.cs (For): Reduce the number of jumps in loops.
21622 (For): Implement loop inversion for the For statement.
21624 (Break): We can be breaking out of a Try/Catch controlled section
21625 (foreach might have an implicit try/catch clause), so we need to
21626 use Leave instead of Br.
21628 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
21629 now). If the instace expression supports IMemoryLocation, we use
21630 the AddressOf method from the IMemoryLocation to extract the
21631 address instead of emitting the instance.
21633 This showed up with `This', as we were emitting the instance
21634 always (Emit) instead of the Address of This. Particularly
21635 interesting when This is a value type, as we dont want the Emit
21636 effect (which was to load the object).
21638 2002-07-08 Miguel de Icaza <miguel@ximian.com>
21640 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
21642 * statement.cs (Checked): Set the CheckedState during the resolve
21643 process too, as the ConvCast operations track the checked state on
21644 the resolve process, and not emit.
21646 * cs-parser.jay (namespace_member_declaration): Flag that we have
21647 found a declaration when we do. This is used to flag error 1529
21649 * driver.cs: Report ok when we display the help only.
21651 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
21653 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
21655 2002-07-04 Miguel de Icaza <miguel@ximian.com>
21657 * cs-tokenizer.cs (define): We also have to track locally the
21658 defines. AllDefines is just used for the Conditional Attribute,
21659 but we also need the local defines for the current source code.
21661 2002-07-03 Miguel de Icaza <miguel@ximian.com>
21663 * statement.cs (While, For, Do): These loops can exit through a
21664 Break statement, use this information to tell whether the
21665 statement is the last piece of code.
21667 (Break): Flag that we break.
21669 * codegen.cs (EmitContexts): New `Breaks' state variable.
21671 2002-07-03 Martin Baulig <martin@gnome.org>
21673 * class.cs (TypeContainer.MethodModifiersValid): Allow override
21674 modifiers in method declarations in structs. Otherwise, you won't
21675 be able to override things like Object.Equals().
21677 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21679 * class.cs (Method, Property, Indexer): Do not allow the public
21680 modifier to be used in explicit interface implementations.
21682 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
21683 override modifiers in method declarations in structs
21685 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
21687 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
21688 integer or real overflow, report an error
21690 2002-07-02 Martin Baulig <martin@gnome.org>
21692 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
21693 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
21694 to tell the runtime about our newly created System.Object and
21695 System.ValueType types.
21697 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21699 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
21700 struct instead of Ldarg/Starg.
21702 2002-07-02 Martin Baulig <martin@gnome.org>
21704 * expression.cs (Indirection.Indirection): Call
21705 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
21707 2002-07-02 Martin Baulig <martin@gnome.org>
21709 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
21710 ValueType, call TypeManager.TypeToCoreType() on it.
21711 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
21712 the OpCodes.Newarr argument.
21714 2002-07-02 Martin Baulig <martin@gnome.org>
21716 * expression.cs (Invocation.EmitCall): When compiling corlib,
21717 replace all calls to the system's System.Array type to calls to
21718 the newly created one.
21720 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
21721 System.Array methods.
21722 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
21723 from the system's System.Array type which must be replaced.
21725 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
21727 * typemanager.cs: load unverifiable_code_ctor so we can build
21728 corlib using the correct type. Avoid using GetTypeCode() with
21730 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
21731 TypeManager.object_type to allow building corlib.
21733 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
21735 * ecore.cs: handle System.Enum separately in LoadFromPtr().
21737 2002-07-01 Martin Baulig <martin@gnome.org>
21739 * class.cs: Make the last change actually work, we need to check
21740 whether `ifaces != null' to avoid a crash.
21742 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21744 * class.cs: when we build structs without fields that implement
21745 interfaces, we need to add the interfaces separately, since there is
21746 no API to both set the size and add the interfaces at type creation
21749 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21751 * expression.cs: the dimension arguments to the array constructors
21752 need to be converted if they are a long.
21754 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
21756 * class.cs: don't emit ldarg.0 if there is no parent constructor
21757 (fixes showstopper for corlib).
21759 2002-06-29 Martin Baulig <martin@gnome.org>
21761 MCS now compiles corlib on GNU/Linux :-)
21763 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
21764 ie. check for MethodImplOptions.InternalCall.
21766 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
21767 and TypeManager.attribute_type are null, so we must explicitly check
21768 whether parent is not null to find out whether it's an attribute type.
21769 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
21770 and SetBuilder, not only if the property is neither abstract nor external.
21771 This is necessary to set the MethodImplOptions on the accessor methods.
21772 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
21773 SetBuilder, see Property.Emit().
21775 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
21776 populate "System.Object", "System.ValueType" and "System.Attribute" since
21777 they've already been populated from BootCorlib_PopulateCoreTypes().
21779 2002-06-29 Martin Baulig <martin@gnome.org>
21781 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
21782 is the NullLiteral, we also need to make sure that target_type is not
21785 2002-06-29 Martin Baulig <martin@gnome.org>
21787 * rootcontext.cs (RootContext.ResolveCore): We must initialize
21788 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
21789 before calling BootstrapCorlib_ResolveDelegate ().
21791 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21793 * statement.cs: fixed build-breaker. All tests passed ok.
21795 2002-06-27 Martin Baulig <martin@gnome.org>
21797 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
21798 for System.Decimal when compiling corlib.
21800 2002-06-27 Martin Baulig <martin@gnome.org>
21802 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
21803 switch blocks which contain nothing but a default clause.
21805 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
21807 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
21809 2002-06-27 Martin Baulig <martin@gnome.org>
21811 * ecore.cs (PropertyExpr.PropertyExpr): Call
21812 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
21814 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
21815 is already a TypeBuilder.
21817 2002-06-27 Martin Baulig <martin@gnome.org>
21819 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
21820 `target_type == TypeManager.array_type', not IsAssignableFrom() in
21821 the "from an array-type to System.Array" case. This makes it work
21822 when compiling corlib.
21824 2002-06-27 Martin Baulig <martin@gnome.org>
21826 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
21827 non-static PropertyExpr, set its InstanceExpression. This makes
21828 the `ICollection.Count' property work in System/Array.cs.
21830 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
21832 * driver.cs: Made error handling more consistent. Errors now
21833 tracked by Report class, so many methods which used to return int
21834 now return void. Main() now prints success/failure and
21835 errors/warnings message.
21837 Renamed '--probe' compiler argument to '--expect-error'. Removed
21838 the magic number return values (123 and 124). Now, if the
21839 expected error occurs, the compiler exits with success (exit value
21840 0). If the compilation completes without seeing that particular
21841 error, the compiler exits with failure (exit value 1). The
21842 makefile in mcs/errors has been changed to handle the new behaviour.
21844 * report.cs: Made 'expected error' number a property and renamed
21845 it from 'Probe' to 'ExpectedError'.
21847 * genericparser.cs: Removed error handling support, since it is
21848 now all done by Report class.
21850 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
21851 class, so parse() no longer returns an int.
21853 * namespace.cs: Use Report.Error instead of GenericParser.error
21855 2002-06-22 Miguel de Icaza <miguel@ximian.com>
21857 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
21858 TypeContainer.AddOperator): At the front of the list put the
21859 explicit implementations, so they get resolved/defined first.
21861 2002-06-21 Miguel de Icaza <miguel@ximian.com>
21863 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
21864 interface type is implemented by this TypeContainer. Used during
21865 explicit interface implementation.
21867 (Property.Define, Indexer.Define, Method.Define): Validate that
21868 the given interface in the explicit implementation is one of the
21869 base classes for the containing type.
21871 Also if we are explicitly implementing an interface, but there is
21872 no match in the pending implementation table, report an error.
21874 (Property.Define): Only define the property if we are
21875 not explicitly implementing a property from an interface. Use the
21876 correct name also for those properties (the same CSC uses,
21877 although that is really not needed).
21879 (Property.Emit): Do not emit attributes for explicitly implemented
21880 properties, as there is no TypeBuilder.
21882 (Indexer.Emit): ditto.
21884 Hiding then means that we do not really *implement* a pending
21885 implementation, which makes code fail.
21887 2002-06-22 Martin Baulig <martin@gnome.org>
21889 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
21890 the return value of Object.GetType(). [FIXME: we need to do this whenever
21891 we get a type back from the reflection library].
21893 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
21895 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
21897 2002-06-20 Miguel de Icaza <miguel@ximian.com>
21899 * attribute.cs: Return null if we can not look up the type.
21901 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
21902 the interface types found.
21904 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
21905 interface types found.
21907 * typemanager.cs (GetInterfaces): Make this routine returns alll
21908 the interfaces and work around the lame differences between
21909 System.Type and System.Reflection.Emit.TypeBuilder in the results
21910 result for GetInterfaces.
21912 (ExpandInterfaces): Given an array of interface types, expand and
21913 eliminate repeated ocurrences of an interface. This expands in
21914 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
21917 2002-06-21 Martin Baulig <martin@gnome.org>
21919 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
21922 2002-06-21 Martin Baulig <martin@gnome.org>
21924 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
21925 and called with one of the core types, return the corresponding typebuilder for
21928 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
21931 2002-06-21 Martin Baulig <martin@gnome.org>
21933 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
21934 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
21935 (Expression.ConvertReferenceExplicit): Likewise.
21937 * expression.cs (ElementAccess.DoResolve): Likewise.
21938 (ElementAccess.DoResolveLValue): Likewise.
21940 2002-06-10 Martin Baulig <martin@gnome.org>
21942 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
21943 add the "value" parameter to the parameter list.
21945 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
21948 2002-06-19 Miguel de Icaza <miguel@ximian.com>
21950 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
21951 the argument to an int, uint, long or ulong, per the spec. Also
21952 catch negative constants in array creation.
21954 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
21956 * class.cs: do not allow the same interface to appear twice in
21957 the definition list.
21959 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
21961 * ecore.cs: don't use ldlen with System.Array.
21963 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
21965 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
21967 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
21969 * modifiers.cs: produce correct field attributes for protected
21970 internal. Easy fix so miguel can work on ther harder stuff:-)
21972 2002-06-18 Miguel de Icaza <miguel@ximian.com>
21974 * pending.cs: New file. Move the code from class.cs here.
21975 Support clearning the pending flag for all methods (when not doing
21976 explicit interface implementation).
21978 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
21980 * rootcontext.cs: added a couple more types needed to bootstrap.
21982 2002-06-17 Miguel de Icaza <miguel@ximian.com>
21984 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
21985 constructor in the type, instead of any constructor in the type
21986 hierarchy. Thanks to Paolo for finding this bug (it showed up as
21987 a bug in the Mono runtime when applying the params attribute).
21989 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
21990 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
21992 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
21994 * expression.cs (Unary.ResolveOperator): Use TypeManager
21995 to resolve the type.
21997 2002-06-13 Ravi Pratap <ravi@ximian.com>
21999 * cs-parser.jay (enum_member_declaration): Pass in the attributes
22002 * enum.cs (AddEnumMember): Add support to store the attributes associated
22003 with each member too.
22005 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
22006 field builders too - this takes care of the enum member case.
22008 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
22010 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
22011 address-of operator on both value types and pointers.
22013 2002-06-10 Martin Baulig <martin@gnome.org>
22015 * interface.cs (Interface.PopulateIndexer): Add the indexer's
22016 PropertyBuilder to the `property_builders' list.
22018 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
22019 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
22020 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
22021 find any indexers which are inherited from an interface.
22023 2002-06-09 Martin Baulig <martin@gnome.org>
22025 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
22026 the same type as the constant if necessary. There's also a test-130.cs
22029 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
22031 * typemanager.cs (TypeManager.ChangeType): Previously known as
22032 Enum.ChangeEnumType().
22034 2002-06-09 Martin Baulig <martin@gnome.org>
22036 * expression.cs (Cast.TryReduce): Added support for consts.
22038 2002-06-08 Ravi Pratap <ravi@ximian.com>
22040 * class.cs (Accessor): Hold attributes information so we can pass
22043 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
22044 Modify to pass in attributes attached to the methods.
22046 (add_accessor_declaration, remove_accessor_declaration): Ditto.
22048 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
22049 to handle the Accessor kind :-)
22051 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
22053 2002-06-08 Martin Baulig <martin@gnome.org>
22055 * expression.cs (Unary.TryReduceNegative): Added support for
22058 2002-06-08 Martin Baulig <martin@gnome.org>
22060 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
22061 name can't be found in the `defined_names' - the caller will do a
22062 MemberLookup in this case and thus find methods in System.Enum
22063 such as Enum.IsDefined().
22065 2002-06-08 Martin Baulig <martin@gnome.org>
22067 * enum.cs (Enum.ChangeEnumType): This is a custom version of
22068 Convert.ChangeType() which works with TypeBuilder created types.
22069 (Enum.LookupEnumValue, Enum.Define): Use it here.
22071 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
22072 `TypeBuilder.BaseType != null' check.
22073 (TypeContainer.FindMembers): Only lookup parent members if we
22074 actually have a parent.
22075 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
22076 (ConstructorInitializer.Resolve): Likewise.
22078 * interface.cs (Interface.FindMembers): Added
22079 `TypeBuilder.BaseType != null' check.
22081 * rootcontext.cs (RootContext.ResolveCore): Added
22082 "System.Runtime.CompilerServices.IndexerNameAttribute" to
22083 classes_second_stage.
22085 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
22086 debug_type and trace_type when compiling with --nostdlib.
22088 2002-06-07 Martin Baulig <martin@gnome.org>
22090 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
22091 (AddField): Set it to true when adding a non-static field.
22092 (DefineType): Use `have_nonstatic_fields' to find out whether we
22093 have non-static fields, not `Fields != null'.
22095 2002-06-02 Miguel de Icaza <miguel@ximian.com>
22097 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
22098 dereferencing a null on the static-field code path)
22100 2002-05-30 Martin Baulig <martin@gnome.org>
22102 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
22103 to take command line arguments. Use reflection to call the new
22104 custom `Initialize' function on the symbol writer and pass it the
22105 command line arguments.
22107 * driver.cs (--debug-args): New command line argument to pass command
22108 line arguments to the symbol writer.
22110 2002-05-28 Miguel de Icaza <miguel@ximian.com>
22112 * assign.cs (DoResolve): Forgot to do the implicit conversion to
22113 the target type for indexers and properties. Thanks to Joe for
22116 2002-05-27 Miguel de Icaza <miguel@ximian.com>
22118 * typemanager.cs (MethodFlags): returns the method flags
22119 (Obsolete/ShouldIgnore) that control warning emission and whether
22120 the invocation should be made, or ignored.
22122 * expression.cs (Invocation.Emit): Remove previous hack, we should
22123 not do this on matching a base type, we should do this based on an attribute
22125 Only emit calls to System.Diagnostics.Debug and
22126 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
22127 on the command line.
22129 * rootcontext.cs: Global settings for tracing and debugging.
22131 * cs-tokenizer.cs (define): New utility function to track
22132 defines. Set the global settings for TRACE and DEBUG if found.
22134 2002-05-25 Ravi Pratap <ravi@ximian.com>
22136 * interface.cs (Populate*): Pass in the TypeContainer as well as
22137 the DeclSpace as parameters so that we can create EmitContexts and
22138 then use that to apply attributes etc.
22140 (PopulateMethod, PopulateEvent, PopulateProperty)
22141 (PopulateIndexer): Apply attributes everywhere.
22143 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
22146 (ApplyAttributes): Update accordingly.
22148 We now apply interface attributes for all members too.
22150 2002-05-26 Miguel de Icaza <miguel@ximian.com>
22152 * class.cs (Indexer.Define); Correctly check if we are explicit
22153 implementation (instead of checking the Name for a ".", we
22154 directly look up if the InterfaceType was specified).
22156 Delay the creation of the PropertyBuilder.
22158 Only create the PropertyBuilder if we are not an explicit
22159 interface implementation. This means that explicit interface
22160 implementation members do not participate in regular function
22161 lookups, and hence fixes another major ambiguity problem in
22162 overload resolution (that was the visible effect).
22164 (DefineMethod): Return whether we are doing an interface
22167 * typemanager.cs: Temporary hack until we get attributes in
22168 interfaces (Ravi is working on that) and we get IndexerName
22169 support in interfaces.
22171 * interface.cs: Register the indexers as properties.
22173 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
22174 warning, I have verified that this is a bug in the .NET runtime
22175 (JavaScript suffers of the same problem).
22177 * typemanager.cs (MemberLookup): When looking up members for
22178 interfaces, the parent of an interface is the implicit
22179 System.Object (so we succeed in searches of Object methods in an
22180 interface method invocation. Example: IEnumerable x; x.ToString
22183 2002-05-25 Miguel de Icaza <miguel@ximian.com>
22185 * class.cs (Event): Events should also register if they do
22186 implement the methods that an interface requires.
22188 * typemanager.cs (MemberLookup); use the new GetInterfaces
22191 (GetInterfaces): The code used to lookup interfaces for a type is
22192 used in more than one place, factor it here.
22194 * driver.cs: Track the errors at the bottom of the file, we kept
22197 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
22198 instance if the method we are calling is static!
22200 2002-05-24 Miguel de Icaza <miguel@ximian.com>
22202 * attribute.cs (ApplyAttributes): Make this function filter out
22203 the IndexerName attribute (as that attribute in reality is never
22204 applied) and return the string constant for the IndexerName
22207 * class.cs (TypeContainer.Emit): Validate that all the indexers
22208 have the same IndexerName attribute, and if so, set the
22209 DefaultName attribute on the class.
22211 * typemanager.cs: The return value might contain other stuff (not
22212 only methods). For instance, consider a method with an "Item"
22213 property and an Item method.
22215 * class.cs: If there is a problem with the parameter types,
22218 2002-05-24 Ravi Pratap <ravi@ximian.com>
22220 * ecore.cs (ImplicitConversionExists): Wrapper function which also
22221 looks at user defined conversion after making a call to
22222 StandardConversionExists - we need this for overload resolution.
22224 * expression.cs : Update accordingly the various method calls.
22226 This fixes 2 bugs filed against implicit user defined conversions
22228 2002-05-22 Miguel de Icaza <miguel@ximian.com>
22230 * statement.cs: Track the result of the assignment.
22232 2002-05-21 Miguel de Icaza <miguel@ximian.com>
22234 * expression.cs (MemberAccess): Improved error reporting for
22235 inaccessible members.
22237 2002-05-22 Martin Baulig <martin@gnome.org>
22239 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
22240 itself with debugging support.
22242 2002-05-22 Martin Baulig <martin@gnome.org>
22244 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
22245 Removed, this isn't needed anymore.
22247 2002-05-20 Martin Baulig <martin@gnome.org>
22249 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
22250 be underlying type for an enum.
22252 2002-05-20 Miguel de Icaza <miguel@ximian.com>
22254 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
22255 that splits out the loading of just the core types.
22257 * rootcontext.cs (ResolveCore): Split the struct resolution in
22258 two, so we can load the enumeration underlying types before any
22261 * expression.cs (Is): Bandaid until we fix properly Switch (see
22262 bug #24985 for details).
22264 * typemanager.cs (ImplementsInterface): The hashtable will contain
22265 a null if there are no interfaces implemented.
22267 2002-05-18 Miguel de Icaza <miguel@ximian.com>
22269 * cs-parser.jay (indexer_declarator): It is fine to have array
22272 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22274 * typemanager.cs: (RegisterBuilder): New function used to register
22275 TypeBuilders that implement interfaces. Since
22276 TypeBuilder.GetInterfaces (as usual) does not work with lame
22278 (AddUserType): register interfaces.
22280 (ImplementsInterface): Use the builder_to_ifaces hash if we are
22281 dealing with TypeBuilder. Also, arrays are showing up as
22282 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
22283 methods can not be invoked on them!
22285 * ecore.cs (ExplicitReferenceConversionExists): Made public.
22286 (ImplicitReferenceConversionExists): Split out from
22287 StandardConversionExists.
22289 * expression.cs (As): We were only implementing one of the three
22290 cases for the as operator. We now implement them all.
22291 (Is): Implement the various other cases for Is as well.
22293 * typemanager.cs (CACHE): New define used to control if we want or
22294 not the FindMembers cache. Seems to have a negative impact on
22295 performance currently
22297 (MemberLookup): Nested types have full acess to
22298 enclosing type members
22300 Remove code that coped with instance/static returns for events, we
22301 now catch this in RealFindMembers.
22303 (RealFindMembers): only perform static lookup if the instance
22304 lookup did not return a type or an event.
22306 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22308 * assign.cs (CompoundAssign): We pass more semantic information
22309 now to Compound Assignments than we did before: now we have all
22310 the information at hand, and now we resolve the target *before* we
22311 do the expression expansion, which allows the "CacheValue" method
22312 to have the effect we intended (before, a [x] += 1 would generate
22313 two differen ArrayAccess expressions from the ElementAccess,
22314 during the resolution process).
22316 (CompoundAssign.DoResolve): Resolve target and original_source here.
22318 2002-05-16 Miguel de Icaza <miguel@ximian.com>
22320 * expression.cs (ArrayAccess): dropped debugging information.
22322 * typemanager.cs: Small bug fix: I was always returning i_members,
22323 instead of one of i_members or s_members (depending on which had
22326 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
22327 method is invoked before any code generation takes place, and it
22328 is a mechanism to inform that the expression will be invoked more
22329 than once, and that the method should use temporary values to
22330 avoid having side effects
22332 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
22334 * ecore.cs (Expression.CacheTemporaries): Provide empty default
22337 * expression.cs (Indirection, ArrayAccess): Add support for
22338 CacheTemporaries in these two bad boys.
22340 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
22341 ldobj or ldind_ref.
22342 (StoreFromPtr): Handle stobj as well.
22344 * expression.cs (UnaryMutator): Share more code.
22346 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
22347 down: I was not tracking the Filter function as well, which
22348 was affecting the results of the cache.
22350 2002-05-15 Miguel de Icaza <miguel@ximian.com>
22352 * attribute.cs: Remove the hack to handle the CharSet property on
22355 2002-05-14 Miguel de Icaza <miguel@ximian.com>
22357 * attribute.cs (DoResolve): More uglyness, we now only try to
22358 resolve the attribute partially, to extract the CharSet
22359 information (only if we are a StructLayout attribute). Otherwise
22361 (GetExtraTypeInfo): Add some code to conditionally kill in the
22362 future this. I am more and more convinced that the .NET
22363 framework has special code to handle the attribute setting on
22366 * expression.cs (IsParamsMethodApplicable): Revert my previous
22367 foreach change here, it was wrong.
22369 2002-05-13 Miguel de Icaza <miguel@ximian.com>
22371 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
22372 (pp_expr): do not abort on unknown input, just return.
22373 (eval): abort if there are pending chars.
22375 * attribute.cs (Attribute.Resolve): Positional parameters are
22376 optional. Deal with that case.
22378 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
22379 the Ansi/Unicode/Auto information for the type.
22381 (TypeContainer.DefineType): instantiate the EmitContext here, as
22382 we will be using it during the type definition (to resolve
22383 attributes) and during the emit phase.
22385 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
22386 to pull type information out of the attributes
22388 (Attribute.Resolve): track the constructor builder, and allow for
22389 multiple invocations (structs and classes will use this).
22391 * ecore.cs (MemberLookupFinal): new version with all the
22392 parameters customizable.
22394 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
22395 constructors. Return if the result value is null (as the error
22396 would have been flagged already by MemberLookupFinal)
22398 Do not allow instances of abstract classes or interfaces to be
22401 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
22402 We have to compare the assembly property here when dealing with
22403 FamANDAssem and Assembly access modifiers, because we might be
22404 creating an assembly from *modules* (that means that we are not
22405 getting TypeBuilders for types defined in other modules that are
22406 part of this assembly).
22408 (Method.Emit): If the method is marked abstract and has a body,
22411 (TypeContainer.DefineMembers): If both the defined member and the
22412 parent name match are methods, then do not emit any warnings: let
22413 the Method.Define routine take care of flagging warnings. But if
22414 there is a mismatch (method overrides something else, or method is
22415 overriwritten by something, then emit warning).
22417 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
22418 set to null, this means `do not check for the return type on the
22421 (Method.Define): set the return type for the method signature to
22422 null, so that we get methods with the same name and parameters and
22423 different return types. This is used to flag warning 114 (you are
22424 hiding a method, and you probably want to use the new/override
22427 * typemanager.cs (MemberLookup): Implemented proper access
22428 control, closing a long standing set of bug reports. The problem
22429 was that the Framework only has two bits: Public and NonPublic,
22430 and NonPublic includes private and protected methods, but we need
22431 to enforce the FamANDAssem, FamOrAssem and Family.
22433 2002-05-11 Miguel de Icaza <miguel@ximian.com>
22435 * statement.cs (GotoCase): Return true: Ammounts to giving up
22436 knowledge on whether we return or not, and letting the other case
22437 be responsible for it.
22439 2002-05-10 Miguel de Icaza <miguel@ximian.com>
22441 * driver.cs: Do not load directories for each file processed, only
22442 do it if there is a pattern.
22444 * ecore.cs: Report readonly assigns here as well, as we might have
22445 been resolved only by MemberAccess.
22447 (SimpleName.SimpleNameResolve): Also be useful for LValue
22448 resolution. We need this to propagate assign to local readonly variables
22450 * typemanager.cs: Use a ptrhashtable for the criteria, because we
22451 do not want to reuse potential criteria memory.
22453 * class.cs (MyEventBuilder): Set reflected_type;
22455 * ecore.cs (Constantify): Added support for constifying bools.
22457 (RootContext.LookupType): Added a cache for values looked up in
22458 the declaration space.
22460 * typemanager.cs (FindMembers): Now is a front-end to
22461 RealFindMembers, and provides a two-level hashtable-based cache to
22464 15% performance improvement: from 22.5 to 19.2 seconds.
22466 * expression.cs (IsParamsMethodApplicable): use foreach.
22467 (Invocation.DoResolve): ditto.
22468 (New.DoResolve): ditto.
22469 (ArrayCreation.DoResolve): ditto.
22471 * ecore.cs (FindMostEncompassingType): use foreach.
22473 * delegate.cs (NewDelegate.DoResolve): Use foreach
22475 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
22476 (RemoveMethods): use foreach.
22478 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
22479 nested foreach statements instead of for, and also break out of
22480 the inner loop once a match is found.
22482 (Invocation.OverloadResolve): Use foreach, simplify the code.
22484 2002-05-08 Miguel de Icaza <miguel@ximian.com>
22486 * cfold.cs (BinaryFold): During an enumeration evaluation context,
22487 we actually unwrap the expression to allow for extra information
22490 * expression.cs: Use Shr_Un on unsigned operations.
22492 2002-05-08 Ravi Pratap <ravi@ximian.com>
22494 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
22495 applicable operators was not being considered correctly. This closes
22496 the bug Miguel reported.
22498 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
22500 * attribute.cs: check that the type derives from System.Attribute
22501 and report the correct error in that case (moved the duplicate code to
22502 its own method, too).
22504 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
22506 * attribute.cs: lookup attribute type name as the spec says: first the
22507 bare attribute name and then name + "Attribute" (nant compiles with
22508 mcs after this fix).
22510 2002-05-07 Miguel de Icaza <miguel@ximian.com>
22512 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
22513 Because of the way we parse things, we should try to see if a
22514 UIntConstant can fit in an integer.
22516 2002-05-07 Ravi Pratap <ravi@ximian.com>
22518 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
22519 when we are in an explicit context.
22521 (ConvertReferenceExplicit): When converting from Iface type S to Class
22522 T make sure the rules are implemented as an OR.
22524 * parameter.cs (ParameterType): Make it a property for now although the
22525 purpose really isn't anything immediate.
22527 * expression.cs (Is*Applicable): Do better checking on the parameter type
22528 of a ref/out parameter. The ones from the system assemblies are already
22529 marked with the correct type so we don't need to do any correction.
22531 * ecore.cs (StandardConversionExists): Conversion from Interface types to
22532 the object type is standard too so include that.
22534 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22536 * ecore.cs (StandardConversionExists): Augment with missing code:
22537 deal with IntConstant, LongConstants and Enumerations.
22539 * assign.cs: Report the error, instead of failing silently
22541 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
22542 typecontainer that they are declared, because the
22543 typecontainer/namespace will have the list of using clauses that
22544 need to be applied.
22546 Assembly Attributes were escaping the normal registration
22549 (EmitCode): Apply attributes within an EmitContext that represents
22550 the container they were declared on.
22552 * cs-parser.jay: Track bases for structs. How did I get this wrong?
22554 2002-05-06 Ravi Pratap <ravi@ximian.com>
22556 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
22557 Revamp completely - make much cleaner as we now operate only
22560 (FindMostSpecificSource, FindMostSpecificTarget): New methods
22561 to implement the logic detailed in the spec more correctly.
22563 (UserDefinedConversion): Update accordingly.
22565 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22567 * statement.cs: Return flow analysis information up.
22569 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
22572 (token): Do not consume an extra character before calling
22575 2002-05-06 Piers Haken <piersh@friskit.com>
22577 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
22579 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22581 * class.cs (Constructor.Emit): Set the IsStatic flag in the
22582 EmitContext during the instance constructor initializer
22583 resolution, to stop access to instance variables.
22585 This is mandated by the spec, last paragraph of the `constructor
22586 initializers' section.
22588 2002-05-05 Miguel de Icaza <miguel@ximian.com>
22590 * cs-parser.jay, class.cs (Accessor): new class used to represent
22591 an accessor (get or set). In the past we used `null' to represent
22592 a missing accessor. But this is ambiguous because there was no
22593 way to tell in abstract indexers/properties if one of them was
22596 Now there is a way of addressing that.
22598 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
22599 instead of FindMembers.
22601 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
22602 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
22604 * attribute.cs: Treat indexers and properties as the same in terms
22605 of applying attributes
22607 * ecore.cs (FindMostEncompassedType): Use statically initialized
22608 EmptyExpressions()s like we do elsewhere to avoid creating useless
22609 objects (and we take this out of the tight loop).
22611 (GetConversionOperators): Move the code to extract the actual
22612 operators to a separate routine to clean things up.
22614 2002-05-04 Miguel de Icaza <miguel@ximian.com>
22616 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
22617 events are always registered FieldBuilders.
22619 * class.cs (FieldBase): New class shared by Fields
22621 * delegate.cs: If we are a toplevel delegate, use our full name.
22622 If we are a nested delegate, then only use our tail name.
22624 2002-05-02 Ravi Pratap <ravi@ximian.com>
22626 * expression.cs (IsApplicable): Ensure that we add the "&" to
22627 ref/out types before comparing it with the type of the argument.
22629 (IsParamsMethodApplicable): Ditto.
22631 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
22634 * delegate.cs : Handle the case when we have more than one applicable
22635 method. Flag an error only when we finish checking all.
22637 2002-05-02 Miguel de Icaza <miguel@ximian.com>
22639 * expression.cs: Add support for boolean static initializers.
22641 2002-05-01 Miguel de Icaza <miguel@ximian.com>
22643 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
22645 * parameter.cs (ComputeParameterTypes,
22646 ComputeAndDefineParameterTypes): Better error handling: now we
22647 clear the `types' cache if we fail during any of the type lookups.
22648 We also return the status code correctly to our caller
22650 * delegate.cs: If we fail to define a delegate, abort the extra
22653 * expression.cs (Binary.ResolveOperator): for
22654 operator==(object,object) and operator !=(object, object) we also
22655 have to verify that there is an implicit conversion from one to
22658 (ArrayAccess.DoResolve): Array Access can operate on
22661 2002-04-30 Miguel de Icaza <miguel@ximian.com>
22663 * assign.cs (CompoundAssign): A new class used as a "flag" that
22664 the assignment actually is happening as part of a compound
22665 assignment operator.
22667 During compound assignment, a few new rules exist to enable things
22674 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
22675 to the type of x) if y is implicitly convertible to the type of x,
22676 and the operator is a builtin operator and the return type of the
22677 operator is explicitly convertible to the type of x.
22679 * rootcontext.cs: Reset warning level to 2. 4 catches various
22680 "interesting" features in mcs, we must clean this up at some
22681 point, but currently am trying to kill other bugs ;-)
22683 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
22684 in container classes as well.
22686 * expression.cs (Binary.ResolveOperator): Handle string case
22687 before anything else (as operator overloading does emit an error
22688 before doing anything else).
22690 This code could go away when we move to a table driven model, but
22691 i could not come up with a good plan last night.
22693 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
22695 * typemanager.cs (CSharpName): reimplementation using regex.
22696 * class.cs: added null check for fields in Emit
22697 * rootcontext.cs: set warninglevel to 4
22699 2002-04-29 Miguel de Icaza <miguel@ximian.com>
22701 * typemanager.cs (CSharpName): reimplemented with Lupus
22704 2002-04-28 Miguel de Icaza <miguel@ximian.com>
22706 * statement.cs (If): correclty implement Resolve, because we were
22707 not catching sem errors in there. The same process is needed
22709 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
22712 (Statement.Warning_DeadCodeFound): Factorize code.
22713 (While): Report dead code here too.
22715 (Statement): Added Resolve virtual method to allow
22716 for resolution split from the emit code.
22718 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22720 * statement.cs (EmitBoolExpression): No longer try to resolve the
22722 (MakeBoolean): New utility function that resolve, implicitly
22723 converts to boolean and tags the expression.
22726 (If, Do): Implement dead code elimination.
22727 (While): Implement loop inversion
22729 (Do, While, For, If): Resolve the expression prior to calling our
22732 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
22735 - added method Report28 (warning: program has more than one entry point)
22736 - added method IsEntryPoint, implements paragraph 10.1 of the spec
22737 - modified method Method.Define, the part at the end of the method
22739 * rootcontext.cs: added static public Location EntryPointLocation;
22741 * ../errors/cs0028.cs : Add test case for the above warning.
22744 - modified method CSharpName to allow arrays of primitive type to
22745 be printed nicely (e.g. instead of System.Int32[][] it now prints
22747 - added method CSharpSignature: returns the signature of a method
22748 in string format to be used in reporting errors, warnings, etc.
22750 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
22753 2002-04-26 Ravi Pratap <ravi@ximian.com>
22755 * delegate.cs (Define): Fix extremely silly bug where I was
22756 setting the type of the 'object' parameter of the BeginInvoke
22757 method to System.IAsyncResult instead of System.Object ;-)
22759 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22761 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
22764 (Constructor.Emit): return if we fail to initialize the
22765 constructor. Another door closed!
22767 * expression.cs (New.DoResolve): Improve error message (from -6 to
22768 1501). Use DeclaredOnly lookup to find the exact constructor.
22770 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
22771 loop. This is useful.
22773 * cs-parser.jay: Adjust the default parameters so that destructors
22774 have the proper signature.
22776 2002-04-26 Martin Baulig <martin@gnome.org>
22778 * driver.cs (LoadAssembly): If `assembly' contains any characters
22779 which are only valid in path names and not in assembly names
22780 (currently slash, backslash and point), use Assembly.LoadFrom ()
22781 instead of Assembly.Load () on the `assembly' (before iteration
22782 over the link_paths).
22784 2002-04-26 Martin Baulig <martin@gnome.org>
22786 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
22788 2002-04-25 Miguel de Icaza <miguel@ximian.com>
22790 * class.cs (Property): use the new typemanager.MemberLookup
22792 (TypeContainer.MemberLookup): Implement using the
22793 TypeManager.MemberLookup now.
22795 * typemanager.cs: Make MemberLookup a function of the TypeManager,
22796 and return MemberInfos, so that these can be used without an
22797 EmitContext (what we had before).
22799 2002-04-24 Miguel de Icaza <miguel@ximian.com>
22801 * expression.cs: Fix the case where the argument to params if the
22802 type of the params. I omitted handling this before. Fixed
22804 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22806 * driver.cs: Call BootCorlib_PopulateCoreType
22808 * class.cs (Property.CheckBase): Check for properties only, not
22811 * interface.cs: Temporary hack: try/catch around the
22812 CustomAttributeBuilder, because I am getting an exception that I
22815 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
22816 types whose definitions are required to be there (attributes are
22817 defined before standard types).
22819 Compute definitions as we boot the various types, as they are used
22820 immediately (value_type class will need object_type, but if we do
22821 not initialize object_type, we will pass a null, which will let
22822 the runtime pick the System.Object from the existing corlib, which
22823 is not what we want).
22825 2002-04-22 Patrik Torstensson <totte@labs2.com>
22827 * cs-tokenizer.cs: fixed a number of trim() issues.
22829 2002-04-22 Ravi Pratap <ravi@ximian.com>
22831 * expression.cs (Argument.Type): Ensure that we return the correct
22832 type when we have out or ref parameters [in which case we
22835 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22837 * class.cs (Property, Indexer): Allow extern modifier in there.
22839 * typemanager.cs (InitBaseTypes): Initializes object_type and
22840 value_type, since those will be used early on during the bootstrap
22841 process to compile corlib.
22843 (InitCoreTypes): Move code from here to InitBaseTypes.
22845 2002-04-21 Miguel de Icaza <miguel@ximian.com>
22847 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
22848 single-dimension arrays as using the ldlen opcode.
22850 Daniel Lewis discovered this optimization.
22852 * typemanager.cs: Add signature for System.Array::get_Length
22854 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22856 * statement.cs: report the error when the foreach does not apply to an
22857 array nor a collection.
22859 2002-04-19 Miguel de Icaza <miguel@ximian.com>
22861 * expression.cs: Add implicit conversions to the operator ~.
22863 * constant.cs (DecimalConstant.Emit): Emit decimal value.
22865 * typemanager.cs: Locate the decimal constructor.
22867 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22869 * attribute.cs: use the new property of TypeOf.
22870 * expression.cs: added 'get' property around typearg.
22872 These changes fix a build breaker reported by NickD. Is this the
22873 correct way to fix? If not, please, revert my changes and make it
22876 2002-04-17 Miguel de Icaza <miguel@ximian.com>
22878 * attribute.cs: Add support for typeof in attribute invocations.
22879 I am not sure that this is right though.
22881 2002-04-14 Duncan Mak <duncan@ximian.com>
22883 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
22884 Binary.Operator.Division case.
22886 2002-04-13 Ravi Pratap <ravi@ximian.com>
22888 * class.cs (DefineType): Ensure that we do a proper check on
22889 attribute types and also register it with the TypeManager.
22891 (TypeContainer.Targets): The default for attribute types is
22892 AttributeTargets.All.
22894 * attribute.cs (ApplyAttributes): Registering the attribute type
22895 is done elsewhere, not when we discover we have a Usage attribute.
22897 2002-04-12 Ravi Pratap <ravi@ximian.com>
22899 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
22900 and get rid of is_delegate parameter.
22902 * everywhere : update.
22904 2002-04-12 Ravi Pratap <ravi@ximian.com>
22906 * cs-parser.jay (compilation_unit): Revamp completely to use
22907 some new ideas that I got from Rhys' grammar to solve the problems
22908 with assembly level attributes.
22910 (outer_declaration): New grammar production.
22912 (attribute_sections): Add.
22914 (opt_attributes): Base on attribute_sections
22916 (namespace_declaration): Allow opt_attributes to tackle the case
22917 when we have assembly level attributes - we are clever in this
22920 * attribute.cs (ApplyAttributes): Do not worry about assembly
22921 attributes in the non-global context.
22923 * rootcontext.cs (AddGlobalAttributes): Go back to using this
22924 instead of SetGlobalAttributes.
22926 * class.cs, rootcontext.cs : Ensure we define and generate
22927 attribute types before anything else.
22929 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
22930 and flag the new error -20 for the case when the attribute type
22931 does not have valid targets specified. csc does not catch this.
22933 * ../errors/errors.txt : update for error # -20
22935 2002-04-11 Ravi Pratap <ravi@ximian.com>
22937 * support.cs (InternalParameters.ParameterModifier): Do some null
22938 checking and return sane values.
22940 * class.cs (Method.Define): If we are a PInvoke method, ensure
22941 that we are static and extern. Report error # 601
22943 * ../errors/cs0601.cs : Add test case for the above error.
22945 2002-04-07 Ravi Pratap <ravi@ximian.com>
22947 * rootcontext.cs (attribute_types): We need to keep type of
22948 all attribute types separately and emit code for them first.
22950 (RegisterAttribute) : Implement.
22952 * class.cs (DefineType): Check if the current Type is a custom
22953 attribute type and register it accordingly.
22955 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
22956 adding the first attribute twice and rename to
22958 (SetGlobalAttributes): this.
22960 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
22963 * attribute.cs (ApplyAttributes): Take an additional argument telling us
22964 if we are processing global arguments. Hmm, I am unsure of this.
22966 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22968 * expression.cs: added static array of strings to avoid calling
22969 Enum.ToString () for Operator in Binary. Significant recover of
22972 2002-04-10 Miguel de Icaza <miguel@ximian.com>
22974 * class.cs (FindMembers): Allow the Builders of the various
22975 members to be null. If they are skip them. This only happens
22976 during the PInvoke declaration.
22978 2002-04-09 Miguel de Icaza <miguel@ximian.com>
22980 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
22981 failure, so we do not keep going afterwards.
22983 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
22984 wanted to pass `false' as the `is_delegate' argument. If this is
22985 the case, why not use delegate_type == null to mean `is_delegate =
22986 false' and anything else as is_delegate = true.
22988 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
22990 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
22991 code for the section, not the beginning of the tests.
22993 2002-04-08 Miguel de Icaza <miguel@ximian.com>
22995 * cfold.cs: Handle operator + (Enum x, Underlying x)
22997 * expression.cs (Binary): same. Warn about errors where we have
22998 Enum/Enum in operator + as well.
23000 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
23003 - added support for switch(bool)
23004 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
23005 - add TableSwitchEmit() to handle table-based switch statements
23007 2002-04-05 Ravi Pratap <ravi@ximian.com>
23009 * expression.cs (Invocation.OverloadResolve): Factor out code which
23010 does parameter compatibility checking with arguments so that we can
23011 re-use the code even from Delegate.VerifyApplicability
23013 (VerifyArgumentsCompat): Move above code here.
23015 * delegate.cs (VerifyApplicability): Get rid of duplicate code
23016 and instead make a call to the above method.
23018 2002-03-31 Ravi Pratap <ravi@ximian.com>
23020 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
23021 We use it to keep track of classes which are attribute types.
23023 2002-04-02 Miguel de Icaza <miguel@ximian.com>
23025 * delegate.cs (Delegate.Define): Correctly define the types in the
23026 presence of fixed and array parameters.
23028 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
23031 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
23032 include NonPublic after the first iteration.
23034 * class.cs (Indexer.CheckBase): Only check if both parents are
23037 * cs-parser.jay (accessor_body): If empty, set to null.
23039 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
23040 same code path here to resolve constants names that we did have in
23041 MemberAccess.DoResolve. There is too much code duplicated here.
23043 2002-04-01 Miguel de Icaza <miguel@ximian.com>
23045 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
23047 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
23050 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
23051 tokens, numbers and strings.
23053 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
23056 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
23057 asyncronous parameters and the regular parameters.
23059 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
23060 specify the target directory.
23062 * expression.cs: (This.DoResolve): Simplify
23063 (As.Emit): Optimize, do not generate IsInst if the expression is
23064 always of the given type.
23066 (Is.DoResolve): Bug fix, we were reporting both always/never for
23069 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
23070 creating too many unnecessary arrays.
23072 2002-03-31 Miguel de Icaza <miguel@ximian.com>
23074 * class.cs (EmitFieldInitializer): Use Assign expression to assign
23075 fields instead of rolling our own initializer. Takes care of all
23076 implicit conversions, and drops unnecessary static checks/argument.
23078 2002-03-31 Dick Porter <dick@ximian.com>
23080 * driver.cs: use the GetDirectories() return values properly, and
23081 use "/" as path separator.
23083 2002-03-30 Miguel de Icaza <miguel@ximian.com>
23085 * expression.cs (Unary): Optimize - - expr into expr.
23086 (Binary): Optimize a + (-b) into a -b.
23088 * codegen.cs (CodeGen): Made all methods static.
23090 2002-03-29 Miguel de Icaza <miguel@ximian.com>
23094 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
23095 TypeBuilder property.
23097 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
23100 * tree.cs: Removed the various RecordXXXX, and replaced with a
23101 single RecordDecl. Removed all the accessor methods, and just
23102 left a single access point Type
23104 * enum.cs: Rename DefineEnum to DefineType.
23106 * decl.cs: New abstract method `DefineType' used to unify the
23107 Defines for Enumerations, Interfaces, TypeContainers and
23110 (FindType): Moved LookupInterfaceOrClass here. Moved the
23111 LookupBaseClasses method that used to live in class.cs and
23112 interface.cs here, and renamed to FindType.
23114 * delegate.cs: Implement DefineType. Take advantage of the
23115 refactored pattern for locating the parent builder without taking
23116 the parent_builder argument (which we know does not work if we are
23117 nested, and triggering a toplevel definition).
23119 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23121 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
23122 accessibility of a member has changed during override and report
23125 * class.cs (Method.Define, Property.Define): Only complain on
23126 overrides if the method is private, any other accessibility is
23127 fine (and since we just checked the permission is the same, we are
23130 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
23131 and elif are processed always. The other pre-processing
23132 directives are only processed if we are "taking" the path
23134 2002-03-29 Martin Baulig <martin@gnome.org>
23136 * class.cs (Method.Emit): Only emit symbolic debugging info if the
23137 current location is not Null.
23139 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
23140 a separate method so we can profile it.
23142 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
23143 `span.Seconds' are just seconds, but no minutes or hours.
23144 (MainDriver): Profile the CodeGen.SaveSymbols calls.
23146 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23148 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
23149 Remove the gratuitous set of Final:
23151 // If an interface implementation, then we can set Final.
23152 if (((flags & MethodAttributes.Abstract) == 0) &&
23153 implementing.DeclaringType.IsInterface)
23154 flags |= MethodAttributes.Final;
23156 I do not know what I was smoking when I used that.
23159 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
23160 step into fixing the name resolution issues for delegates and
23161 unifying the toplevel name resolution.
23163 2002-03-28 Martin Baulig <martin@gnome.org>
23165 * class.cs (Method.Emit): If we have a symbol writer, call its
23166 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
23167 tell it about the current method.
23169 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
23170 writer that we're going to emit the first byte of IL code for a new
23171 statement (a new source line).
23172 (EmitContext.EmitTopBlock): If we have a symbol writer, call
23173 EmitContext.Mark() before emitting any code.
23175 * location.cs (SymbolDocument): Return null when we're Null.
23177 * statement.cs (Statement): Moved the `Location loc' variable here.
23178 (Statement.EmitBoolExpression): If we have a symbol writer, call
23179 ec.Mark() before emitting any code to tell it that we're at the
23180 beginning of a new statement.
23181 (StatementExpression): Added `Location' argument to the constructor.
23182 (Block): Added public readonly variable `StartLocation' and public
23183 variable `EndLocation'. The latter is to be set using SetEndLocation().
23184 (Block): Added constructor which takes a start and end location.
23185 (Block.SetEndLocation): New method. This sets the end location.
23186 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
23187 local variables we create.
23188 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
23189 each statement and do also mark the begin and end of the block.
23191 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
23192 tell it the current lexer.Location, use Location.Null for the end of the
23194 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
23195 current block, set its end location using SetEndLocation().
23196 (statement_expression): StatementExpression constructor now takes the
23197 lexer.Location as additional argument.
23198 (for_statement, declare_local_variables): Likewise.
23199 (declare_local_variables): When creating a new implicit block, use the
23200 new Block constructor and pass it the lexer.Location.
23202 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23204 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
23205 members also on the parent interfaces recursively.
23207 2002-03-27 Miguel de Icaza <miguel@ximian.com>
23209 * report.cs: Use new formats, since Gonzalo finished the missing
23212 * expression.cs (Binary.ResolveOperator): added missing operator|
23213 operator& and operator^ for bool/bool.
23215 * cs-parser.jay: CheckDef now takes a Location argument that is
23216 used to report errors more precisly (instead of reporting the end
23217 of a definition, we try to track something which is a lot closer
23218 to the source of the problem).
23220 * cs-tokenizer.cs: Track global token use, so we can properly flag
23221 the use of #define/#undef after the first token has been seen.
23223 Also, rename the reportXXXX to Error_DescriptiveName
23225 * decl.cs (DeclSpace.IsTopLevel): Move property here from
23226 TypeContainer, so that Enum and Interface can use this too.
23228 * class.cs (TypeContainer.LookupInterfaceOrClass,
23229 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
23230 `builder' argument. Typically this was used to pass the parent
23231 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
23234 The problem is that a nested class could trigger the definition of
23235 a toplevel class, and the builder would be obviously wrong in that
23238 So we drop this argument, and we compute dynamically the
23239 TypeBuilder/ModuleBuilder (the correct information was available
23240 to us anyways from DeclSpace.Parent)
23242 * interface.cs (Interface.DefineInterface): Drop builder
23243 parameter cleanup like class.cs
23245 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
23248 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
23251 (Try.Emit): Propagate the returns value from the statement.
23253 (Return.Emit): Even if we are leavning
23255 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
23257 * modifiers.cs: Fix the computation of MethodAttributes flags.
23259 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
23261 * driver.cs: allow compilation of files that start with '/'.
23262 Add a default case when checking the argument of --target.
23264 2002-03-25 Miguel de Icaza <miguel@ximian.com>
23266 * interface.cs: Implement the same search algorithm for types in
23267 the interface code.
23269 * delegate.cs: Do not allow multiple definition.
23271 * Recovered ChangeLog that got accidentally amputated
23273 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
23275 * rootcontext.cs: Load manually enum to allow core classes to
23276 contain enumerations.
23278 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
23279 Update to new static methods in TypeManager.
23281 * typemanager.cs (GetMethod, GetConstructor): Use our
23282 implementation of FindMembers to find the members, since during
23283 corlib compilation, the types are TypeBuilders and GetMethod and
23284 GetConstructor do not work.
23286 Make all methods in TypeManager static.
23288 (InitCodeHelpers): Split the functionality from
23289 the InitCodeTypes function.
23291 * driver.cs: Call InitCodeHelpers after we have populated the
23294 * cs-parser.jay (delegate_declaration): we did not used to compute
23295 the delegate name correctly for void delegates.
23297 2002-03-24 Miguel de Icaza <miguel@ximian.com>
23299 * rootcontext.cs (RootContext): Init the interface_resolve_order
23300 and type_container_resolve_order always.
23302 (ResolveCore, BootstrapCorlib_ResolveClass,
23303 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
23304 compiler when compiling with --nostdlib
23306 * class.cs (TypeContainer.DefineType): Check that our parent is
23307 not null. This test is most important when we are bootstraping
23310 * codegen.cs: Split out the symbol writing code.
23312 2002-03-25 Martin Baulig <martin@gnome.org>
23314 * driver.cs (-g): Made -g an alias for --debug.
23316 2002-03-24 Martin Baulig <martin@gnome.org>
23318 * codegen.cs (SymbolWriter): New public variable. Returns the
23319 current symbol writer.
23320 (CodeGen): Added `bool want_debugging_support' argument to the
23321 constructor. If true, tell the ModuleBuild that we want debugging
23322 support and ask it for the ISymbolWriter.
23323 (Save): If we have a symbol writer, call it's Close() method after
23324 saving the assembly.
23326 * driver.c (--debug): New command line argument to create a
23327 debugger information file.
23329 * location.cs (SymbolDocument): New public property. Returns an
23330 ISymbolDocumentWriter object for the current source file or null
23331 if we don't have a symbol writer.
23333 2002-03-21 Miguel de Icaza <miguel@ximian.com>
23335 * driver.cs (LoadAssembly): Correctly return when all the paths
23336 have been tried and not before.
23338 * statement.cs (Switch.Emit): return the actual coverage for this
23339 statement (returns/not-returns)
23341 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
23342 switch of the statement if we are the last switch section. That
23343 kills two problems: try/catch problems (we used to emit an empty
23344 nop at the end) and switch statements where all branches would
23347 2002-03-19 Miguel de Icaza <miguel@ximian.com>
23349 * driver.cs: Add default assemblies (the equivalent to the
23350 Microsoft CSC.RSP file)
23352 * cs-tokenizer.cs: When updating `cols and setting it to zero,
23353 also update tokens_seen and set it to false.
23355 * driver.cs: Implement --recurse for Mike.
23357 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
23358 correctly splitting out the paths.
23360 2002-03-18 Miguel de Icaza <miguel@ximian.com>
23362 * interface.cs (Interface.PopulateProperty): Instead of using
23363 `parent' as the declaration space for the set parameters, use
23366 * support.cs (InternalParameters): InternalParameters constructor
23367 takes a DeclSpace instead of a TypeContainer.
23369 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
23370 types are being initialized, load the address of it before calling
23373 (New): Provide a mechanism to disable the generation of local
23374 value type temporaries when the caller will be providing us with
23375 an address to store it.
23377 (ArrayCreation.EmitDynamicInitializers): Use it.
23379 2002-03-17 Miguel de Icaza <miguel@ximian.com>
23381 * expression.cs (Invocation.EmitArguments): Only probe for array
23382 property if there is more than one argument. Sorry about that.
23384 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
23385 empty param arrays.
23387 * class.cs (Method.LabelParameters): Fix incorrect code path that
23388 prevented the `ParamArrayAttribute' from being applied to the
23391 2002-03-16 Miguel de Icaza <miguel@ximian.com>
23393 * support.cs (ReflectionParameters): Correctly compute whether the
23394 last argument is a params array. Fixes the problem with
23397 * typemanager.cs: Make the assemblies array always be non-null
23398 (empty, but non-null)
23400 * tree.cs (RecordDecl): New function that abstracts the recording
23401 of names. This reports error 101, and provides a pointer to the
23402 previous declaration. Fixes a crash in the compiler.
23404 * cs-parser.jay (constructor_declaration): Update to new grammar,
23405 and provide a constructor_body that can be empty.
23407 2002-03-15 Miguel de Icaza <miguel@ximian.com>
23409 * driver.cs: Add support for --resources.
23411 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
23412 Make all types for the various array helper methods be integer.
23414 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
23415 CheckState to ConvCast.
23417 (ConvCast): Now it takes a `checked' state argument, to avoid
23418 depending on the emit context for the conversion, and just using
23419 the resolve time setting.
23421 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
23422 instead of Invocation.EmitArguments. We do not emit the original
23423 arguments, instead we emit those which have been converted to
23424 unsigned int expressions.
23426 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
23428 * codegen.cs: ditto.
23430 * expression.cs (LocalVariableReference): Drop the use of the
23431 Store function that depended on the variable index.
23433 * statement.cs (VariableInfo): Drop the `Idx' property from this
23434 class, as this is not taking into account the indexes for
23435 temporaries tat we generate during the execution, getting the
23438 * class.cs: First emit class initializers, then call the parent
23441 * expression.cs (Binary): Fix opcode emision.
23442 (UnaryMutator.EmitCode): Support checked code generation
23444 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
23445 matches for events for both the Static and Instance scans,
23446 pointing to the same element. Fix that.
23448 2002-03-14 Miguel de Icaza <miguel@ximian.com>
23450 * rootcontext.cs (ResolveTree): Always set the
23451 interface_resolve_order, because nested interfaces will be calling
23454 * class.cs (GetInterfaceOrClass): Track the same resolution
23455 process used by TypeManager.LookupType. This fixes the nested
23456 type lookups in class declarations (separate path from
23459 (TypeContainer.DefineType): Also define nested interfaces.
23460 (TypeContainer.RegisterOrder): New public function used to
23461 register the order in which child interfaces need to be closed.
23463 Nested interfaces need to be closed after their parents have been
23466 * interface.cs (InterfaceAttr): Put all the logic for computing
23467 the interface attribute here.
23469 (DefineInterface): Register our interface order with the
23470 RootContext or with the TypeContainer depending on the case.
23472 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23474 * cs-parser.jay: rework foreach statement to work with the new
23475 changes to the policy on SimpleNames.
23477 * report.cs: support Stacktrace on warnings as well.
23479 * makefile: drop --unsafe and /unsafe from the compile.
23481 2002-03-13 Ravi Pratap <ravi@ximian.com>
23483 * ecore.cs (StandardConversionExists): Modify to take an Expression
23484 as the first parameter. Ensure we do null -> reference type conversion
23487 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
23488 temporary Expression objects.
23490 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
23492 * interface.cs: workaround bug in method overloading resolution
23493 (there is already a bugzilla bug for it).
23495 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23497 We could also solve this problem by having a separate path for
23498 performing type lookups, instead of DoResolve, we could have a
23499 ResolveType entry point, and only participating pieces of the
23500 production (simplename, deref, array) would implement this.
23502 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
23503 signal SimpleName to only resolve type names and not attempt to
23504 resolve anything else.
23506 * expression.cs (Cast): Set the flag.
23508 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
23510 * class.cs: Only report 108 if there is no `new' modifier.
23512 * cs-parser.jay: rework foreach statement to work with the new
23513 changes to the policy on SimpleNames.
23515 * report.cs: support Stacktrace on warnings as well.
23517 * makefile: drop --unsafe and /unsafe from the compile.
23519 2002-03-11 Miguel de Icaza <miguel@ximian.com>
23521 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23522 lookups here, instead of doing that at parse time. This means
23523 that our grammar will not introduce `LocalVariableReferences' as
23524 expressions at this point. That solves the problem of code like
23528 static void Main ()
23532 This is only half the fix. The full fix requires parameters to
23533 also be handled in this way.
23535 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
23536 makes the use more obvious of the DeclSpace. The
23537 ec.TypeContainer.TypeBuilder is now only used to pull the
23538 TypeBuilder for it.
23540 My theory is that I can get rid of the TypeBuilder completely from
23541 the EmitContext, and have typecasts where it is used (from
23542 DeclSpace to where it matters).
23544 The only pending problem is that the code that implements Aliases
23545 is on TypeContainer, and probably should go in DeclSpace.
23547 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23548 lookups here, instead of doing that at parse time. This means
23549 that our grammar will not introduce `LocalVariableReferences' as
23550 expressions at this point. That solves the problem of code like
23554 static void Main ()
23558 This is only half the fix. The full fix requires parameters to
23559 also be handled in this way.
23561 * class.cs (Property.DefineMethod): When implementing an interface
23562 method, set newslot, when implementing an abstract method, do not
23563 set the flag (before we tried never setting it, or always setting
23564 it, which is the difference).
23565 (Indexer.DefineMethod): same.
23566 (Method.DefineMethod): same.
23568 * ecore.cs: Only set the status used flag if we get back a Field.
23570 * attribute.cs: Temporary hack, so Paolo can keep working.
23572 2002-03-08 Ravi Pratap <ravi@ximian.com>
23574 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
23575 the unmanaged type in the case we have a MarshalAs attribute.
23577 (Resolve): Handle the case when we are parsing the special MarshalAs
23578 attribute [we need to store the unmanaged type to use later]
23580 * typemanager.cs (marshal_as_attr_type): Built in type for the
23581 MarshalAs Attribute.
23583 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
23584 on parameters and accordingly set the marshalling info.
23586 2002-03-09 Miguel de Icaza <miguel@ximian.com>
23588 * class.cs: Optimizing slightly by removing redundant code after
23589 we switched to the `NoTypes' return value.
23590 (Property.DefineMethod): use NoTypes here too.
23592 This fixes the bug I introduced in my last batch of changes.
23594 2002-03-05 Ravi Pratap <ravi@ximian.com>
23596 * tree.cs (RecordEnum): Add. We now keep track of enums too.
23598 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
23599 Enums since those are types too.
23601 * cs-parser.jay (enum_declaration): Record enums as we parse them.
23603 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
23604 thanks to a call during the lookup process.
23606 2002-03-07 Miguel de Icaza <miguel@ximian.com>
23608 * statement.cs (Foreach): Lots of work to accomodate a particular
23609 kind of foreach statement that I had not kept in mind. It is
23610 possible to have foreachs on classes that provide a GetEnumerator
23611 method that return objects that implement the "pattern" for using
23612 a foreach, there is no need to support GetEnumerator
23615 This is needed to compile nant.
23617 * decl.cs: Only report 114 if the member is not `Finalize' and if
23618 the warning level is at least 2.
23620 * class.cs: Moved the compare function from Method to
23623 (MethodSignature.InheritableMemberSignatureCompare): Add new
23624 filter function that is used to extract inheritable methods from a
23627 (Method.Define): Use the new `inheritable_method_signature_filter'
23630 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
23633 2002-03-06 Miguel de Icaza <miguel@ximian.com>
23635 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
23637 * cs-parser.jay: Add opt_semicolon to the interface declaration.
23639 * expression.cs: Pass location information to
23640 ConvertImplicitStandard.
23642 * class.cs: Added debugging code to track return values from
23645 2002-03-05 Miguel de Icaza <miguel@ximian.com>
23647 * expression.cs (Is.DoResolve): If either side of the `is' is an
23648 interface, do not flag the warning.
23650 * ecore.cs (ImplicitReferenceConversion): We need a separate test
23653 * report.cs: Allow for --fatal to be used with --probe.
23655 * typemanager.cs (NoTypes): Move the definition for the empty Type
23658 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
23660 (TypeContainer.DefineProxy): New function used to proxy to parent
23661 implementations when implementing interfaces.
23662 (TypeContainer.ParentImplements): used to lookup if our parent
23663 implements a public function that is required by an interface.
23664 (TypeContainer.VerifyPendingMethods): Hook this up.
23666 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
23667 `modules' and `assemblies' arraylists into arrays. We only grow
23668 these are the very early start up of the program, so this improves
23669 the speedof LookupType (nicely measured).
23671 * expression.cs (MakeByteBlob): Replaced unsafe code with
23672 BitConverter, as suggested by Paolo.
23674 * cfold.cs (ConstantFold.Binary): Special case: perform constant
23675 folding of string concatenation, but if either side is a string,
23676 and the other is not, then return null, and let the runtime use
23677 the concatenation on the string plus the object (using
23678 `Object.ToString').
23680 2002-03-04 Miguel de Icaza <miguel@ximian.com>
23682 Constant Folding has been implemented now.
23684 * expression.cs (Unary.Reduce): Do not throw an exception, catch
23685 the error instead on types that are not supported in one's
23688 * constant.cs (Constant and all children): New set of functions to
23689 perform implict and explicit conversions.
23691 * ecore.cs (EnumConstant): Implement the new functions to perform
23692 conversion by proxying to the child expression.
23694 * codegen.cs: (ConstantCheckState): Constant evaluation has its
23695 own separate setting that can not be turned off from the command
23696 line using --unchecked or --checked and is only controlled using
23697 the checked/unchecked statements and expressions. This setting is
23698 used by the constant folder to flag errors.
23700 * expression.cs (CheckedExpr, UncheckedExpr): Set the
23701 ConstantCheckState as well.
23703 During Resolve, they also have to flag the state, because the
23704 constant folder runs completely in the Resolve phase.
23706 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
23709 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23711 * cfold.cs: New file, this file contains the constant folder.
23713 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
23714 argument to track whether we are using the resulting address to
23715 load or store a value and provide better error messages.
23717 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
23718 new AddressOf arguments.
23720 * statement.cs (Foreach.EmitCollectionForeach): Update
23722 * expression.cs (Argument.Emit): Call AddressOf with proper
23723 arguments to track usage.
23725 (New.DoEmit): Call AddressOf with new arguments.
23727 (Unary.Emit): Adjust AddressOf call.
23729 2002-03-01 Ravi Pratap <ravi@ximian.com>
23731 * cs-parser.jay (member_access): Change the case for pre-defined types
23732 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
23735 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
23738 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
23739 essentially like methods and apply attributes like MethodImplOptions to them too.
23741 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
23744 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
23745 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
23748 * Update code everywhere accordingly.
23750 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
23752 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
23754 2002-02-28 Ravi Pratap <ravi@ximian.com>
23756 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
23757 try performing lookups against those instead of jumping straight into using
23758 the 'using' clauses.
23760 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
23762 (LookupType): Perform lookups in implicit parents too.
23764 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
23765 sequence as RootContext.LookupType.
23767 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
23768 the various cases of namespace lookups into this method.
23770 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23772 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
23773 in positional arguments)
23775 * class.cs (Operator): Update the AllowedModifiers to contain
23778 * cs-parser.jay: Update operator declaration to allow for the
23779 operator body to be empty.
23781 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
23784 2002-02-27 Miguel de Icaza <miguel@ximian.com>
23786 * class.cs (Method.Emit): Label parameters.
23788 * driver.cs: Return 1 or 0 as the program exit code.
23790 2002-02-26 Miguel de Icaza <miguel@ximian.com>
23792 * expression.cs: Special case the `null' object when trying to
23793 auto-compute the type, as anything can be explicitly converted to
23796 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
23797 spotting this Paolo.
23799 (Expression.ImplicitNumericConversion): Perform comparissions of
23800 the type using the underlying type in the case of an enumeration
23801 rather than using the enumeration type for the compare.
23803 Cope with the underlying == type case, which is not possible to
23806 (Expression.ConvertNumericExplicit): Perform comparissions of
23807 the type using the underlying type in the case of an enumeration
23808 rather than using the enumeration type for the compare.
23810 * driver.cs: If the user does not supply an extension, assume .exe
23812 * cs-parser.jay (if_statement): Rewrote so that we can track the
23813 location for the if statement.
23815 * expression.cs (Binary.ConstantFold): Only concat strings when
23816 the operation is "+", not everything ;-)
23818 * statement.cs (Statement.EmitBoolExpression): Take a location
23820 (If, While, Do): Track location.
23822 * expression.cs (Binary.ResolveOperator): In the object + string
23823 case, I was missing a call to ConvertImplicit
23825 2002-02-25 Ravi Pratap <ravi@ximian.com>
23827 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
23828 Location arguments. Ensure we use RootContext.LookupType to do our work
23829 and not try to do a direct Type.GetType and ModuleBuilder.GetType
23831 * interface.cs (PopulateMethod): Handle the type of the parameter being
23834 * expression.cs (Invocation.BetterFunction): Handle the case when we
23835 have a params method with no fixed arguments and a call is made with no
23838 2002-02-25 Miguel de Icaza <miguel@ximian.com>
23840 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
23841 the verbatim-string-literal
23843 * support.cs (InternalParameters.ParameterModifier): handle null
23845 (InternalParameters.ParameterType): ditto.
23847 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
23848 duplicating the name of the variable parameter.
23849 (GetParameterByName): Fix bug where we were not looking up array
23850 paramters if they were the only present (thanks Paolo!).
23851 (GetParameterInfo): We only have an empty set of types if both
23852 fixed and array are set to null.
23853 (GetParameterInfo-idx): Handle FixedParameter == null
23855 * cs-parser.jay: Handle the case where there is no catch
23856 statements (missing null test).
23858 2002-02-22 Miguel de Icaza <miguel@ximian.com>
23860 * driver.cs (MainDriver): Be conservative on our command line
23863 Catch DirectoryNotFoundException when calling GetFiles.
23865 (SplitPathAndPattern): Used to split the input specification into
23866 a path and a pattern that we can feed to Directory.GetFiles.
23868 2002-02-21 Miguel de Icaza <miguel@ximian.com>
23870 * statement.cs (Fixed): Implement the last case of the Fixed
23871 statement (string handling).
23873 * expression.cs (StringPtr): New class used to return a char * to
23874 a string; Used by the Fixed statement.
23876 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
23878 * expression.cs (Binary.ResolveOperator): Remove redundant
23879 MemberLookup pn parent type.
23880 Optimize union call, we do not need a union if the types are the same.
23881 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
23884 Specialize the use of MemberLookup everywhere, instead of using
23885 the default settings.
23887 (StackAlloc): Implement stackalloc keyword.
23889 * cs-parser.jay: Add rule to parse stackalloc.
23891 * driver.cs: Handle /h, /help, /?
23893 * expression.cs (MakeByteBlob): Removed the hacks we had in place
23894 before we supported unsafe code.
23896 * makefile: add --unsafe to the self compilation of mcs.
23898 2002-02-20 Miguel de Icaza <miguel@ximian.com>
23900 * expression.cs (PointerArithmetic): New class that is used to
23901 perform pointer arithmetic.
23902 (Binary.Resolve): Handle pointer arithmetic
23903 Handle pointer comparission.
23904 (ArrayPtr): Utility expression class that is used to take the
23905 address of an array.
23907 (ElementAccess): Implement array access for pointers
23909 * statement.cs (Fixed): Implement fixed statement for arrays, we
23910 are missing one more case before we are done.
23912 * expression.cs (Indirection): Implement EmitAssign and set the
23913 ExprClass to Variable. This allows pointer dereferences to be
23914 treated as variables, and to have values assigned to them.
23916 * ecore.cs (Expression.StoreFromPtr): New utility function to
23917 store values dereferencing.
23919 2002-02-20 Ravi Pratap <ravi@ximian.com>
23921 * expression.cs (Binary.ResolveOperator): Ensure that we are
23922 not trying to operate on a void type - this fixes the reported
23925 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
23926 the parent implementation is sealed.
23928 * ../errors/cs0239.cs : Add.
23930 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
23932 * typemanager.cs (unverifiable_code_type): Corresponds to
23933 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
23934 which have unsafe code in them.
23936 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
23939 2002-02-19 Miguel de Icaza <miguel@ximian.com>
23941 * cs-tokenizer.cs: Add support for @"litreal strings"
23943 Make tokenizer accept pre-processor directives
23944 on any column (remove the old C-like limitation).
23946 * rootcontext.cs (EmitCode): Emit any global attributes.
23947 (AddGlobalAttributes): Used to keep track of assembly attributes.
23949 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
23951 * cs-parser.jay: Add support for global attributes.
23953 2002-02-17 Miguel de Icaza <miguel@ximian.com>
23955 * expression.cs (Indirection): New helper class. Unary will
23956 create Indirection classes to be able to implement the
23957 IMemoryLocation interface on it.
23959 2002-02-16 Miguel de Icaza <miguel@ximian.com>
23961 * cs-parser.jay (fixed_statement): reference the right statement.
23963 * statement.cs (Fixed.Emit): Finish implementing the fixed
23964 statement for the &x case.
23966 2002-02-14 Miguel de Icaza <miguel@ximian.com>
23968 * class.cs (Property.Define, Method.Define): Remove newslot when
23971 * modifiers.cs: My use of NewSlot when `Abstract' was set was
23972 wrong. NewSlot should only be used if the `new' keyword is present.
23974 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
23975 locating our system dir. Sorry about this.
23977 2002-02-13 Miguel de Icaza <miguel@ximian.com>
23979 * driver.cs (GetSystemDir): Compute correctly the location of our
23980 system assemblies. I was using the compiler directory instead of
23981 the library directory.
23983 2002-02-13 Ravi Pratap <ravi@ximian.com>
23985 * expression.cs (BetterFunction): Put back in what Miguel commented out
23986 since it is the correct fix. The problem is elsewhere ;-)
23988 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
23989 parameters of the parms method are themselves compatible or not !
23991 (StandardConversionExists): Fix very dangerous bug where we were forgetting
23992 to check that a class implements an interface before saying that an implicit
23993 conversion was allowed. Use ImplementsInterface to do the checking.
23995 2002-02-13 Miguel de Icaza <miguel@ximian.com>
23997 * class.cs (Method.Define): Track whether we are an explicit
23998 implementation or not. And only call DefineMethodOverride if we
23999 are an explicit implementation.
24001 (Property.DefineMethod): Ditto.
24003 2002-02-11 Ravi Pratap <ravi@ximian.com>
24005 * expression.cs (BetterFunction): Catch hideous bug which was
24006 preventing us from detecting ambiguous calls due to implicit casts i.e
24009 2002-01-29 Miguel de Icaza <miguel@ximian.com>
24011 * support.cs (Pair): Remove un-needed method. I figured why I was
24012 getting the error in cs-parser.jay, the variable in a foreach loop
24013 is readonly, and the compiler does not really treat this as a variable.
24015 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
24016 instead of EQUALS in grammar.
24018 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
24020 * expression.cs (Unary.DoResolve): Check whether the argument is
24023 2002-01-28 Miguel de Icaza <miguel@ximian.com>
24025 * support.cs: Api for Pair to set a value. Despite the fact that
24026 the variables are public the MS C# compiler refuses to compile
24027 code that accesses the field if the variable is part of a foreach
24030 * statement.cs (Fixed): Begin implementation of the fixed
24033 (Block.AddVariable): Return the VariableInfo on success and null
24034 on failure instead of true/false.
24036 * cs-parser.jay (foreach): Catch errors on variables already
24037 defined (we were ignoring this value before) and properly unwind
24038 the block hierarchy
24040 (fixed_statement): grammar for the fixed statement.
24042 2002-01-25 Miguel de Icaza <miguel@ximian.com>
24044 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
24045 pointer types to be incretemented.
24047 (SizeOf): Implement.
24049 * cs-parser.jay (pointer_member_access): Implement
24050 expr->IDENTIFIER production.
24052 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
24053 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
24056 (Unary): Implement indirection.
24058 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
24059 use in non-unsafe context).
24061 (SimpleName.DoResolve): Check for pointers in field access on safe
24064 (Expression.LoadFromPtr): Factor the load-indirect code in this
24065 function. This was duplicated in UnboxCast and ParameterReference
24067 2002-01-24 Miguel de Icaza <miguel@ximian.com>
24069 * expression.cs (ComposedCast): report an error if a pointer cast
24070 is used in a safe region.
24072 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
24073 pointer type casts in unsafe context.
24075 * codegen.cs (EmitContext): Set up IsUnsafe.
24077 * cs-parser.jay (non_expression_type): Add productions for pointer
24080 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
24081 code. We should not use force into static mode if the method is
24082 not virtual. Fixes bug in MIS
24084 * statement.cs (Do.Emit, While.Emit, For.Emit,
24085 Statement.EmitBoolExpression): Add support to Do and While to
24086 propagate infinite loop as `I do return' semantics.
24088 Improve the For case to also test for boolean constants.
24090 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
24091 to the list of attributes we can add.
24093 Remove `EmitContext' argument.
24095 * class.cs (Method.Define): Apply parameter attributes.
24096 (Constructor.Define): Apply parameter attributes.
24097 (MethodCore.LabelParameters): Move here the core of labeling
24100 * support.cs (ReflectionParameters.ParameterModifier,
24101 InternalParameters.ParameterModifier): Use IsByRef on the type and
24102 only return the OUT bit for these parameters instead of in/out/ref
24105 This is because I miss-understood things. The ParameterInfo.IsIn
24106 and IsOut represent whether the parameter has the [In] and [Out]
24109 2002-01-22 Miguel de Icaza <miguel@ximian.com>
24111 * ecore.cs (FieldExpr.Emit): Release temporaries.
24113 * assign.cs (LocalTemporary.Release): new function.
24115 * codegen.cs (EmitContext.GetTemporaryStorage,
24116 EmitContext.FreeTemporaryStorage): Rework the way we deal with
24117 temporary storage. Now we can "put back" localbuilders when we
24120 2002-01-21 Miguel de Icaza <miguel@ximian.com>
24122 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
24123 need to make a copy of the variable to generate verifiable code.
24125 2002-01-19 Miguel de Icaza <miguel@ximian.com>
24127 * driver.cs: Compute dynamically the system directory.
24129 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
24130 Slower, but more generally useful. Used by the abstract
24131 registering implementation.
24133 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
24134 the rules for the special rule on Type/instances. First check if
24135 we have the same name, and if so, try that special static path
24136 rather than the instance path.
24138 2002-01-18 Miguel de Icaza <miguel@ximian.com>
24140 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
24143 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
24144 Enum, ValueType, Delegate or Array for non-corlib compiles.
24146 * cs-tokenizer.cs: Catch long identifiers (645)
24148 * typemanager.cs (IndexerPropetyName): Ravi never tested this
24151 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
24152 fix, we were returning too early, so we were not registering
24153 pending methods from abstract classes.
24155 Do not register pending methods if the class is abstract.
24157 * expression.cs (Conditional.DoResolve): Report circular implicit
24158 conversions when we neecd to compute it for conditional
24161 (Is.DoResolve): If the expression is always of the provided type,
24162 flag warning 183. If the expression can not ever be of the
24163 provided type flag warning 184.
24165 * class.cs: Catch 169 as well.
24167 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
24170 2002-01-18 Nick Drochak <ndrochak@gol.com>
24172 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
24174 2002-01-17 Miguel de Icaza <miguel@ximian.com>
24176 * interface.cs: (PopulateMethod): Check for pointers being defined
24177 only if the unsafe context is active.
24178 (PopulateProperty): ditto.
24179 (PopulateIndexer): ditto.
24181 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
24182 specified. If pointers are present, make sure that they are
24183 present in an unsafe context.
24184 (Constructor, Constructor.Define): ditto.
24185 (Field, Field.Define): ditto.
24186 (Property, Property.Define): ditto.
24187 (Event, Event.Define): ditto.
24189 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
24190 hashtable if there are classes or structs defined.
24192 * expression.cs (LocalVariableReference.DoResolve): Simplify this
24193 code, as the constant resolution moved.
24195 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
24196 the metadata, so we can flag error 133.
24198 * decl.cs (MemberCore.UnsafeOK): New function to test that a
24199 pointer is being declared in an unsafe context.
24201 2002-01-16 Miguel de Icaza <miguel@ximian.com>
24203 * modifiers.cs (Modifiers.Check): Require a Location argument.
24204 Report error 227 for Unsafe use.
24206 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
24208 * statement.cs (For.Emit): If the test is null, then report that
24209 we do `return', as we wont reach anything afterwards.
24211 (Switch.SwitchGoverningType): Track the expression that matched
24214 * driver.cs: Allow negative numbers as an error code to flag.
24216 * cs-parser.jay: Handle 1551.
24218 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
24220 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24222 * cs-parser.jay: Report 1518 (type declaration can only contain
24223 class, struct, interface, enum or delegate)
24225 (switch_label): Report 1523 (keywords `case' or `default' must
24228 (opt_switch_sections): Report 1522 (empty switch)
24230 * driver.cs: Report 1515 (response file specified multiple times)
24231 Report 1516 (Source file specified multiple times).
24233 * expression.cs (Argument.Resolve): Signal 1510
24235 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
24236 access not allowed in static code)
24238 2002-01-11 Ravi Pratap <ravi@ximian.com>
24240 * typemanager.cs (IsPointerType): Utility method which we are going
24243 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
24244 the object type, so we take care of that.
24246 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
24248 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
24249 added to non-params parameters :-)
24251 * typemanager.cs (CSharpName): Include 'void' type too.
24253 (void_ptr_type): Include in the set of core types.
24255 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
24258 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
24261 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
24262 completely forgotten about it.
24264 2002-01-10 Ravi Pratap <ravi@ximian.com>
24266 * cs-parser.jay (pointer_type): Add. This begins our implementation
24267 of parsing rules for unsafe code.
24269 (unsafe_statement): Implement.
24271 (embedded_statement): Modify to include the above.
24273 * statement.cs (Unsafe): Implement new class for unsafe blocks.
24275 * codegen.cs (EmitContext.InUnsafe): Add. This determines
24276 if the current context is an unsafe one.
24278 * cs-parser.jay (local_variable_pointer_type): Since local variable types
24279 are handled differently, we need separate rules for them.
24281 (local_variable_declaration): Update to use local_variable_pointer_type
24282 to allow variable declarations of unmanaged pointer types.
24284 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
24285 in unsafe contexts.
24287 * ../errors/cs0214.cs : Add.
24289 2002-01-16 Nick Drochak <ndrochak@gol.com>
24291 * makefile: remove 'response' file when cleaning.
24293 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24295 * cs-parser.jay: Report 1524.
24297 2002-01-14 Miguel de Icaza <miguel@ximian.com>
24299 * typemanager.cs (RegisterMethod): drop checking if we have
24300 registered this from here
24302 2002-01-12 Miguel de Icaza <miguel@ximian.com>
24304 * class.cs (Method.EmitDestructor): Implement calling our base
24307 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
24308 value of InFinally.
24310 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
24311 this routine and will wrap the call in a try/catch block. Deal
24314 2002-01-11 Miguel de Icaza <miguel@ximian.com>
24316 * ecore.cs (Expression.MemberLookup): instead of taking a
24317 parameter `same_type' that was used to tell whether we could
24318 access private members we compute our containing type from the
24321 (FieldExpr): Added partial support for volatile fields. This does
24322 not work for volatile fields exposed from assemblies, as I can not
24323 figure out how to extract the modreq from it.
24325 Updated all the source files to use this.
24327 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
24328 because it is referenced by MemberLookup very often.
24330 2002-01-09 Ravi Pratap <ravi@ximian.com>
24332 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
24333 TypeBuilder.GetCustomAttributes to retrieve what we need.
24335 Get rid of redundant default_member_attr_type as this is the same as
24336 default_member_type which already exists.
24338 * interface.cs, attribute.cs : Update accordingly.
24340 2002-01-08 Miguel de Icaza <miguel@ximian.com>
24342 * typemanager.cs: Enable IndexerPropertyName again. It does not
24343 work for TYpeBuilders though. Ravi, can you please fix this?
24345 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
24347 * expression.cs (Argument.Emit): Handle the case of ref objects
24348 being passed to ref functions;
24350 (ParameterReference.EmitLoad): Loads the content of the pointer
24351 without dereferencing.
24353 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24355 * cs-tokenizer.cs: Implemented the pre-processing expressions.
24357 2002-01-08 Ravi Pratap <ravi@ximian.com>
24359 * class.cs (Indexer.DefineMethod): Incorporate the interface
24360 type in the name of the method if we are doing explicit interface
24363 * expression.cs (ConversionExists): Remove as it is completely obsolete.
24365 (BetterConversion): Fix extremely trivial bug where we were referring to
24366 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
24369 * ../errors/bug16.cs : Add although we have fixed it.
24371 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24373 * expression.cs (BaseIndexer): Begin implementation.
24375 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
24377 * cs-parser.jay (indexer_declarator): Use qualified_identifier
24378 production directly to remove a shift/reduce, and implement
24379 explicit interface implementation.
24381 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
24382 after a floating point suffix.
24384 * expression.cs (DoNumericPromotions): Improved the conversion for
24385 uint/uint. If we have a constant, we avoid doing a typecast to a
24388 * class.cs (Indexer): Implement explicit interface implementation
24391 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
24393 * class.cs: make the default instance constructor public and hidebysig.
24395 2001-01-03 Ravi Pratap <ravi@ximian.com>
24397 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
24398 so we can call it from elsewhere.
24400 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
24401 we emit it internally if the class has a defined indexer; otherwise the user
24402 emits it by decorating the class definition with the DefaultMemberAttribute.
24404 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
24405 attribute is not used on a type which defines an indexer.
24407 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
24408 character when we skip whitespace.
24410 * ../errors/cs0646.cs : Add.
24412 2002-01-03 Miguel de Icaza <miguel@ximian.com>
24414 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
24417 * makefile: Add practical target `mcs3.exe' which builds the third
24418 generation compiler.
24420 * expression.cs (New): Fix structures constructor calling.
24422 * class.cs (Property, Method, Indexer): Emit Final flag on the
24423 method if we are an interface implementation and we are not
24426 * ecore.cs (PropertyExpr): New public field `IsBase', tells
24427 whether this property is referencing a `base' method.
24429 * expression.cs (Invocation.EmitCall): take an extra argument:
24430 is_base, this is used to determine whether the `call' or
24431 `callvirt' opcode should be used.
24434 * delegate.cs: update EmitCall.
24436 * class.cs (Method.Define): Set NewSlot for the cases where we are
24437 not implementing an interface method.
24439 (Property.Define): ditto.
24441 2002-01-02 Miguel de Icaza <miguel@ximian.com>
24443 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
24444 'r'. Allows mcs to parse itself fully.
24446 2002-01-02 Ravi Pratap <ravi@ximian.com>
24448 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
24449 of the number of initializers that require the InitializeArray method.
24451 (CheckIndices): Store the Expression in all cases - not the plain value. Also
24452 update the above field where necessary.
24454 (MakeByteBlob): Update accordingly.
24456 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
24459 (EmitDynamicInitializers): Update in accordance with the new optimization.
24461 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
24462 same OpCode applies.
24464 * cs-parser.jay : Fix some glaring errors I introduced.
24466 2002-01-01 Ravi Pratap <ravi@ximian.com>
24468 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
24469 so that we can check for name clashes there too.
24471 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
24472 for interface indexers.
24474 * interfaces.cs (Define): Emit the default member attribute.
24476 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
24477 variable was being referred to while setting the value ;-)
24479 2002-01-01 Miguel de Icaza <miguel@ximian.com>
24481 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
24482 byte-by-byte information when we know the data is zero.
24484 Make the block always a multiple of 4, because
24485 DefineInitializedData has a bug.
24487 * assign.cs: Fix, we should assign from the temporary, not from
24490 * expression.cs (MakeByteBlob): Fix my incorrect code.
24492 2001-12-31 Miguel de Icaza <miguel@ximian.com>
24494 * typemanager.cs (EnumToUnderlying): This function is used to get
24495 the underlying type from an enumeration, because it does not
24498 * constant.cs: Use the I4_S form for values between -128 and 127.
24500 * statement.cs (Block.LookupLabel): Looks up a label.
24501 (Block): Drop support for labeled blocks.
24503 (LabeledStatement): New kind of statement that represents a label
24506 (Goto): Finally implement this bad boy.
24508 * cs-parser.jay: Update to reflect new mechanism to implement
24511 2001-12-30 Miguel de Icaza <miguel@ximian.com>
24513 * codegen.cs (EmitContext.This): a codegen property that keeps the
24514 a single instance of this instead of creating many different this
24517 * delegate.cs (Delegate.DoResolve): Update to use the property;
24519 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
24521 * expression.cs (BaseAccess.DoResolve): Ditto.
24523 2001-12-29 Ravi Pratap <ravi@ximian.com>
24525 * typemanager.cs (methodimpl_attr_type): Add to hold the type
24526 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
24528 (InitCoreTypes): Update accordingly.
24530 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
24531 so we can quickly store the state.
24533 (ApplyAttributes): Set the correct implementation flags
24534 for InternalCall methods.
24536 2001-12-29 Miguel de Icaza <miguel@ximian.com>
24538 * expression.cs (EmitCall): if a method is not virtual, then do
24539 not use callvirt on it.
24541 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
24542 user defined stuff) requires the use of stobj, which takes an
24543 address on the stack instead of an array and an index. So emit
24544 the Ldelema operation for it.
24546 (EmitStoreOpcode): Use stobj for valuetypes.
24548 (UnaryMutator.EmitCode): Use the right 1 value depending on
24549 whether we are dealing with int64/uint64, float or doubles.
24551 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
24552 constructors that I implemented last night.
24554 (Constructor.IsDefault): Fix to work properly for static
24557 * cs-parser.jay (CheckDef): report method signature errors.
24558 Update error number 103 to be 132.
24560 * decl.cs: New AdditionResult enumeration value: MethodExists.
24561 Although we do this check for methods later on in the semantic
24562 analysis, catching repeated default constructors is so easy that
24563 we catch these here.
24565 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
24568 (ParameterReference.EmitAssign, Emit): handle
24571 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
24572 (ArrayAccess.EmitStoreOpcode): ditto.
24574 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
24576 * expression.cs (MakeByteBlob): Complete all the missing types
24577 (uint, short, ushort, byte, sbyte)
24579 * class.cs: Only init instance field initializers on instance
24582 Rename `constructors' to instance_constructors.
24584 (TypeContainer.AddConstructor): Only add constructors to the list
24585 if it is not static.
24587 Make sure that we handle default_static_constructor independently
24588 everywhere where we handle instance_constructors
24590 2001-12-28 Miguel de Icaza <miguel@ximian.com>
24592 * class.cs: Do not lookup or create a base initializer for a
24593 static constructor.
24595 (ConstructorInitializer.Resolve): use the proper type to lookup
24598 * cs-parser.jay: Report error 1585 (modifiers between type and name).
24600 * enum.cs, interface.cs: Remove CloseType, this is taken care by
24603 * decl.cs: CloseType is now an virtual method, the default
24604 implementation just closes this type.
24606 2001-12-28 Ravi Pratap <ravi@ximian.com>
24608 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
24609 to PreserveSig by default. Also emit HideBySig on such methods.
24611 Basically, set the defaults to standard values.
24613 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
24614 argument, if candidate is better, it can't be worse than the best !
24616 (Invocation): Re-write bits to differentiate between methods being
24617 applicable in their expanded form and their normal form - for params
24620 Get rid of use_standard everywhere as only standard conversions are allowed
24621 in overload resolution.
24623 More spec conformance.
24625 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24627 * driver.cs: Add --timestamp, to see where the compiler spends
24630 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
24631 `this' in static code.
24633 (SimpleName.DoResolve): Implement in terms of a helper function
24634 that allows static-references to be passed upstream to
24637 (Expression.ResolveWithSimpleName): Resolve specially simple
24638 names when called by MemberAccess to implement the special
24641 (Expression.ImplicitReferenceConversion): Handle conversions from
24642 Null to reference types before others, as Null's type is
24645 * expression.cs (Invocation.EmitCall): Handle the special case of
24646 calling methods declared on a reference type from a ValueType
24647 (Base classes System.Object and System.Enum)
24649 (MemberAccess.Resolve): Only perform lookups on Enumerations if
24650 the left hand side is a TypeExpr, not on every enumeration.
24652 (Binary.Resolve): If types are reference types, then do a cast to
24653 object on operators != and == of both arguments.
24655 * typemanager.cs (FindMembers): Extract instance and static
24656 members if requested.
24658 * interface.cs (PopulateProperty): Use void_type instead of null
24659 as the return type for the setter method.
24661 (PopulateIndexer): ditto.
24663 2001-12-27 Ravi Pratap <ravi@ximian.com>
24665 * support.cs (ReflectionParameters): Fix minor bug where we
24666 were examining the wrong parameter for the ParamArray attribute.
24668 Cope with requests for the type of the parameter at position
24669 greater than the params parameter's. We now return the element
24670 type of the params array as that makes more sense.
24672 * expression.cs (Invocation.IsParamsMethodApplicable): Update
24673 accordingly as we no longer have to extract the element type
24676 (Invocation.OverloadResolve): Update.
24678 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24680 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
24681 against IEnumerator, test whether the return value is a descendant
24682 of the IEnumerator interface.
24684 * class.cs (Indexer.Define): Use an auxiliary method to implement
24685 the other bits of the method definition. Begin support for
24686 explicit interface implementation.
24688 (Property.DefineMethod): Use TypeManager.void_type instead of null
24689 for an empty return value.
24691 2001-12-26 Miguel de Icaza <miguel@ximian.com>
24693 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
24694 dealing with a FieldExpr which is composed of a FieldBuilder, in
24695 the code path we did extract the constant, but we should have
24696 obtained the underlying value to be able to cast it (otherwise we
24697 end up in an infinite loop, this is what Ravi was running into).
24699 (ArrayCreation.UpdateIndices): Arrays might be empty.
24701 (MemberAccess.ResolveMemberAccess): Add support for section
24702 14.5.4.1 that deals with the special case of E.I when E is a type
24703 and something else, that I can be a reference to a static member.
24705 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
24706 handle a particular array type to create byte blobs, it is just
24707 something we dont generate byteblobs for.
24709 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
24712 * location.cs (Push): remove the key from the hashtable that we
24713 are about to add. This happens for empty files.
24715 * driver.cs: Dispose files after we have parsed them.
24717 (tokenize): new function that only runs the tokenizer on its
24718 input, for speed testing.
24720 2001-12-26 Ravi Pratap <ravi@ximian.com>
24722 * class.cs (Event.Define): Define the private field only if there
24723 are no accessors defined.
24725 * expression.cs (ResolveMemberAccess): If there is no associated
24726 field with the event, that means we have an event defined with its
24727 own accessors and we should flag error cs0070 since transforming
24728 ourselves into a field is not valid in that case.
24730 * ecore.cs (SimpleName.DoResolve): Same as above.
24732 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
24733 and charset to sane values.
24735 2001-12-25 Ravi Pratap <ravi@ximian.com>
24737 * assign.cs (DoResolve): Perform check on events only if they
24738 are being accessed outside the declaring type.
24740 * cs-parser.jay (event_declarations): Update rules to correctly
24741 set the type of the implicit parameter etc.
24743 (add_accessor, remove_accessor): Set current local parameters.
24745 * expression.cs (Binary): For delegate addition and subtraction,
24746 cast the return value from the method into the appropriate delegate
24749 2001-12-24 Ravi Pratap <ravi@ximian.com>
24751 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
24752 of these as the workaround is unnecessary.
24754 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
24755 delegate data - none of that is needed at all.
24757 Re-write bits to extract the instance expression and the delegate method
24760 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
24763 * attribute.cs (ApplyAttributes): New method to take care of common tasks
24764 of attaching attributes instead of duplicating code everywhere.
24766 * everywhere : Update code to do attribute emission using the above method.
24768 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24770 * expression.cs (IsParamsMethodApplicable): if there are not
24771 parameters, return immediately.
24773 * ecore.cs: The 0 literal can be implicity converted to an enum
24776 (SimpleName.DoResolve): First lookup the type, then lookup the
24779 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
24780 want to get its address. If the InstanceExpression is not
24781 addressable, store the result in a temporary variable, then get
24784 * codegen.cs: Only display 219 errors on warning level or above.
24786 * expression.cs (ArrayAccess): Make it implement the
24787 IMemoryLocation interface.
24789 (Binary.DoResolve): handle the operator == (object a, object b)
24790 and operator != (object a, object b) without incurring into a
24791 BoxedCast (because 5 != o should never be performed).
24793 Handle binary enumerator operators.
24795 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
24796 value type, otherwise use Ldelem_ref.
24798 Use precomputed names;
24800 (AddressOf): Implement address of
24802 * cs-parser.jay (labeled_statement): Fix recursive block
24803 addition by reworking the production.
24805 * expression.cs (New.DoEmit): New has a special case:
24807 If we are dealing with a ValueType, we have a few
24808 situations to deal with:
24810 * The target of New is a ValueType variable, that is
24811 easy, we just pass this as the variable reference
24813 * The target of New is being passed as an argument,
24814 to a boxing operation or a function that takes a
24817 In this case, we need to create a temporary variable
24818 that is the argument of New.
24821 2001-12-23 Ravi Pratap <ravi@ximian.com>
24823 * rootcontext.cs (LookupType): Check that current_type is not null before
24824 going about looking at nested types.
24826 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
24827 not implement the IAssignMethod interface any more.
24829 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
24830 where we tranform them into FieldExprs if they are being resolved from within
24831 the declaring type.
24833 * ecore.cs (SimpleName.DoResolve): Do the same here.
24835 * assign.cs (DoResolve, Emit): Clean up code considerably.
24837 * ../errors/bug10.cs : Add.
24839 * ../errors/cs0070.cs : Add.
24841 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
24843 * assign.cs : Get rid of EventIsLocal everywhere.
24845 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24847 * ecore.cs (ConvertIntLiteral): finished the implementation.
24849 * statement.cs (SwitchLabel): Convert the value we are using as a
24850 key before looking up the table.
24852 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24854 * codegen.cs (EmitTopBlock): Require a Location argument now.
24856 * cs-parser.jay (constructor_declarator): We need to setup
24857 current_local_parameters before we parse the
24858 opt_constructor_initializer, to allow the variables to be bound
24859 to the constructor arguments.
24861 * rootcontext.cs (LookupType): First lookup nested classes in our
24862 class and our parents before we go looking outside our class.
24864 * expression.cs (ConstantFold): Extract/debox the values at the
24867 * rootcontext.cs (EmitCode): Resolve the constants first before we
24868 resolve the types. This is not really needed, but it helps debugging.
24870 * statement.cs: report location.
24872 * cs-parser.jay: pass location to throw statement.
24874 * driver.cs: Small bug fix.
24876 * report.cs: Updated format to be 4-zero filled digits.
24878 2001-12-22 Ravi Pratap <ravi@ximian.com>
24880 * expression.cs (CheckIndices): Fix minor bug where the wrong
24881 variable was being referred to ;-)
24883 (DoEmit): Do not call EmitStaticInitializers when the
24884 underlying type is System.Object.
24886 2001-12-21 Ravi Pratap <ravi@ximian.com>
24888 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
24889 and do the usual workaround for SRE.
24891 * class.cs (MyEventBuilder.EventType): New member to get at the type
24892 of the event, quickly.
24894 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
24896 * assign.cs (Assign.DoResolve): Handle the case when the target
24897 is an EventExpr and perform the necessary checks.
24899 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
24902 (SimpleName.MemberStaticCheck): Include check for EventExpr.
24904 (EventExpr): Set the type in the constructor itself since we
24905 are meant to be born fully resolved.
24907 (EventExpr.Define): Revert code I wrote earlier.
24909 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
24910 instance expression is null. The instance expression is a This in that case
24911 or a null, depending on whether it is a static method or not.
24913 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
24914 refers to more than one method.
24916 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
24917 and accordingly flag errors.
24919 2001-12-21 Miguel de Icaza <miguel@ximian.com>
24921 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
24923 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24925 * location.cs (ToString): Provide useful rutine.
24927 2001-12-21 Miguel de Icaza <miguel@ximian.com>
24929 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
24930 objects, return the actual integral boxed.
24932 * statement.cs (SwitchLabel): define an ILLabel for each
24935 (Switch.CheckSwitch): If the value is a Literal, extract
24936 the underlying literal.
24938 Also in the unused hashtable we had, add the SwitchLabel so we can
24939 quickly look this value up.
24941 * constant.cs: Implement a bunch of new constants. Rewrite
24942 Literal based on this. Made changes everywhere to adapt to this.
24944 * expression.cs (Expression.MakeByteBlob): Optimize routine by
24945 dereferencing array only once, and also copes with enumrations.
24947 bytes are two bytes wide, not one.
24949 (Cast): Perform constant conversions.
24951 * ecore.cs (TryImplicitIntConversion): Return literals instead of
24952 wrappers to the literals here.
24954 * expression.cs (DoNumericPromotions): long literals can converted
24955 to ulong implicity (this is taken care of elsewhere, but I was
24956 missing this spot).
24958 * ecore.cs (Expression.Literalize): Make the return type Literal,
24959 to improve type checking.
24961 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
24963 2001-12-20 Miguel de Icaza <miguel@ximian.com>
24965 * literal.cs: Revert code from ravi that checked the bounds. The
24966 bounds are sane by the definition of the type itself.
24968 * typemanager.cs: Fix implementation of ImplementsInterface. We
24969 need to actually look up in our parent hierarchy for interfaces
24972 * const.cs: Use the underlying type for enumerations
24974 * delegate.cs: Compute the basename for the delegate creation,
24975 that should fix the delegate test case, and restore the correct
24976 Type Lookup semantics in rootcontext
24978 * rootcontext.cs: Revert Ravi's last patch. The correct way of
24979 referencing a nested type with the Reflection API is using the "+"
24982 * cs-parser.jay: Do not require EOF token at the end.
24984 2001-12-20 Ravi Pratap <ravi@ximian.com>
24986 * rootcontext.cs (LookupType): Concatenate type names with
24987 a '.' instead of a '+' The test suite passes again.
24989 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
24990 field of the enumeration.
24992 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
24993 the case when the member is an EventExpr.
24995 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
24996 static has an associated instance expression.
24998 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
25000 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
25002 * class.cs (Event.Define): Register event and perform appropriate checks
25005 We define the Add and Remove methods even if the use provides none because
25006 in that case, we provide default implementations ourselves.
25008 Define a private field of the type of the event. This is done by the CSC compiler
25009 and we should be doing it too ;-)
25011 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
25012 More methods we use in code we generate.
25014 (multicast_delegate_type, delegate_type): Two separate types since the distinction
25017 (InitCoreTypes): Update accordingly for the above.
25019 * class.cs (Event.Emit): Generate code for default accessors that we provide
25021 (EmitDefaultMethod): Do the job in the above.
25023 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
25026 2001-12-20 Miguel de Icaza <miguel@ximian.com>
25028 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
25029 builders even if we were missing one.
25031 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
25032 pass the Basename as our class name instead of the Name. The
25033 basename will be correctly composed for us.
25035 * parameter.cs (Paramters): Now takes a Location argument.
25037 * decl.cs (DeclSpace.LookupType): Removed convenience function and
25038 make all the code call directly LookupType in RootContext and take
25039 this chance to pass the Location information everywhere.
25041 * Everywhere: pass Location information.
25043 2001-12-19 Miguel de Icaza <miguel@ximian.com>
25045 * class.cs (Constructor.Define): Updated way of detecting the
25046 length of the parameters.
25048 (TypeContainer.DefineType): Use basename as the type name for
25051 (TypeContainer.Define): Do not recursively define types here, as
25052 definition is taken care in order by the RootContext.
25054 * tree.cs: Keep track of namespaces in a per-file basis.
25056 * parameter.cs (Parameter.ComputeSignature): Update to use
25059 (Parameters.GetSignature): ditto.
25061 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
25062 instead of a TypeContainer.
25064 (Interface.SemanticAnalysis): Use `this' instead of our parent to
25065 resolve names. Because we need to be resolve in our context, not
25068 * driver.cs: Implement response files.
25070 * class.cs (TypeContainer.DefineType): If we are defined, do not
25071 redefine ourselves.
25073 (Event.Emit): Emit the code for add/remove handlers.
25074 (Event.Define): Save the MethodBuilders for add/remove.
25076 * typemanager.cs: Use pair here too.
25078 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
25079 DictionaryEntry requires the first argument to be non-null.
25081 (enum_declaration): Compute full name for registering the
25084 (delegate_declaration): Instead of using
25085 formal_parameter_list, use opt_formal_parameter_list as the list
25088 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
25089 (EventParsing): New property that controls whether `add' and
25090 `remove' are returned as tokens or identifiers (for events);
25092 2001-12-19 Ravi Pratap <ravi@ximian.com>
25094 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
25095 use MyEventBuilder only and let it wrap the real builder for us.
25097 (MyEventBuilder): Revamp constructor etc.
25099 Implement all operations that we perform on EventBuilder in precisely the same
25102 (FindMembers): Update to use the EventBuilder member.
25104 (Event.Emit): Update accordingly.
25106 2001-12-18 Ravi Pratap <ravi@ximian.com>
25108 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
25109 by calling the appropriate methods.
25111 (GetCustomAttributes): Make stubs as they cannot possibly do anything
25114 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
25116 2001-12-17 Ravi Pratap <ravi@ximian.com>
25118 * delegate.cs (Delegate.Populate): Check that the return type
25119 and various parameters types are indeed accessible.
25121 * class.cs (Constructor.Define): Same here.
25123 (Field.Define): Ditto.
25125 (Event.Define): Ditto.
25127 (Operator.Define): Check that the underlying Method defined itself
25128 correctly - so it's MethodBuilder should not be null.
25130 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
25131 expression happens to be null.
25133 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
25134 members but as of now we don't seem to be able to do anything really useful with it.
25136 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
25137 not the EventBuilder.
25139 2001-12-18 Miguel de Icaza <miguel@ximian.com>
25141 * cs-tokenizer.cs: Add support for defines.
25142 Add support for #if, #elif, #else, #endif
25144 (eval_var): evaluates a variable.
25145 (eval): stubbed for evaluating functions.
25147 * cs-parser.jay: Pass the defines information
25149 * driver.cs: Add --define command line option.
25151 * decl.cs: Move MemberCore here.
25153 Make it the base class for DeclSpace. This allows us to catch and
25154 report 108 and 109 for everything now.
25156 * class.cs (TypeContainer.Define): Extract all the members
25157 before populating and emit the warning 108 (new keyword required
25158 to override) instead of having each member implement this.
25160 (MemberCore.Define): New abstract method, we will be using this in
25161 the warning reporting engine in Populate.
25163 (Operator.Define): Adjust to new MemberCore protocol.
25165 * const.cs (Const): This does not derive from Expression, it is a
25166 temporary object we use to create fields, it is a MemberCore.
25168 * class.cs (Method.Define): Allow the entry point to be in a
25171 * driver.cs: Rewrite the argument handler to clean it up a bit.
25173 * rootcontext.cs: Made it just an auxiliary namespace feature by
25174 making everything static.
25176 * driver.cs: Adapt code to use RootContext type name instead of
25179 * delegate.cs: Remove RootContext argument.
25181 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
25184 * class.cs (Event.Define): The lookup can fail.
25186 * cs-tokenizer.cs: Begin implementation of pre-procesor.
25188 * expression.cs: Resolve the this instance before invoking the code.
25190 2001-12-17 Miguel de Icaza <miguel@ximian.com>
25192 * cs-parser.jay: Add a production in element_access that allows
25193 the thing to become a "type" reference. This way we can parse
25194 things like "(string [])" as a type.
25196 Note that this still does not handle the more complex rules of
25200 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
25202 * ecore.cs: (CopyNewMethods): new utility function used to
25203 assemble the list of methods from running FindMembers.
25205 (MemberLookup): Rework FindMembers so that
25207 2001-12-16 Miguel de Icaza <miguel@ximian.com>
25209 * class.cs (TypeContainer): Remove Delegates who fail to be
25212 * delegate.cs (Populate): Verify that we dont get null return
25213 values. TODO: Check for AsAccessible.
25215 * cs-parser.jay: Use basename to emit error 574 (destructor should
25216 have the same name as container class), not the full name.
25218 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
25219 possible representation.
25221 Also implements integer type suffixes U and L.
25223 2001-12-15 Miguel de Icaza <miguel@ximian.com>
25225 * expression.cs (ArrayCreation.DoResolve): We need to do the
25226 argument resolution *always*.
25228 * decl.cs: Make this hold the namespace. Hold the root context as
25230 (LookupType): Move here.
25232 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
25234 * location.cs (Row, Name): Fixed the code, it was always returning
25235 references to the first file.
25237 * interface.cs: Register properties defined through interfaces.
25239 * driver.cs: Add support for globbing on the command line
25241 * class.cs (Field): Make it derive from MemberCore as well.
25244 2001-12-15 Ravi Pratap <ravi@ximian.com>
25246 * class.cs (Event::Define): Check that the type of the event is a delegate
25247 type else flag error #66.
25249 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
25252 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
25253 values of EntryPoint, CharSet etc etc.
25255 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
25257 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
25258 be null and we should ignore this. I am not sure if this is really clean. Apparently,
25259 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
25260 which needs this to do its work.
25262 * ../errors/cs0066.cs : Add.
25264 2001-12-14 Miguel de Icaza <miguel@ximian.com>
25266 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
25269 * class.cs: (MethodSignature.MethodSignature): Removed hack that
25270 clears out the parameters field.
25271 (MemberSignatureCompare): Cleanup
25273 (MemberCore): New base class used to share code between MethodCore
25276 (RegisterRequiredImplementations) BindingFlags.Public requires
25277 either BindingFlags.Instace or Static. Use instance here.
25279 (Property): Refactored code to cope better with the full spec.
25281 * parameter.cs (GetParameterInfo): Return an empty array instead
25284 * class.cs (Property): Abstract or extern properties have no bodies.
25286 * parameter.cs (GetParameterInfo): return a zero-sized array.
25288 * class.cs (TypeContainer.MethodModifiersValid): Move all the
25289 method modifier validation to the typecontainer so we can reuse
25290 this on properties.
25292 (MethodCore.ParameterTypes): return an empty sized array of types.
25294 (Property.Define): Test property modifier validity.
25296 Add tests for sealed/override too.
25298 (Method.Emit): abstract or extern methods have no bodies.
25300 2001-12-14 Ravi Pratap <ravi@ximian.com>
25302 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
25305 (Method::Define, ::Emit): Modify accordingly.
25307 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
25309 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
25311 * makefile: Pass in /unsafe.
25313 2001-12-13 Miguel de Icaza <miguel@ximian.com>
25315 * class.cs (MakeKey): Kill routine.
25317 * class.cs (TypeContainer.Define): Correctly define explicit
25318 method implementations (they require the full interface name plus
25321 * typemanager.cs: Deply the PtrHashtable here and stop using the
25322 lame keys. Things work so much better.
25324 This of course broke everyone who depended on `RegisterMethod' to
25325 do the `test for existance' test. This has to be done elsewhere.
25327 * support.cs (PtrHashtable): A hashtable that avoid comparing with
25328 the object stupid Equals method (because, that like fails all over
25329 the place). We still do not use it.
25331 * class.cs (TypeContainer.SetRequiredInterface,
25332 TypeContainer.RequireMethods): Killed these two routines and moved
25333 all the functionality to RegisterRequiredImplementations.
25335 (TypeContainer.RegisterRequiredImplementations): This routine now
25336 registers all the implementations required in an array for the
25337 interfaces and abstract methods. We use an array of structures
25338 which can be computed ahead of time to reduce memory usage and we
25339 also assume that lookups are cheap as most classes will not
25340 implement too many interfaces.
25342 We also avoid creating too many MethodSignatures.
25344 (TypeContainer.IsInterfaceMethod): Update and optionally does not
25345 clear the "pending" bit if we find that there are problems with
25348 (TypeContainer.VerifyPendingMethods): Update to report errors of
25349 methods that look like implementations but are not.
25351 (TypeContainer.Define): Add support for explicit interface method
25354 2001-12-12 Miguel de Icaza <miguel@ximian.com>
25356 * typemanager.cs: Keep track of the parameters here instead of
25357 being a feature of the TypeContainer.
25359 * class.cs: Drop the registration of parameters here, as
25360 InterfaceMethods are also interface declarations.
25362 * delegate.cs: Register methods with the TypeManager not only with
25363 the TypeContainer. This code was buggy.
25365 * interface.cs: Full registation here.
25367 2001-12-11 Miguel de Icaza <miguel@ximian.com>
25369 * expression.cs: Remove reducer for binary expressions, it can not
25372 * const.cs: Put here the code that used to go into constant.cs
25374 * constant.cs: Put here the code for constants, this is a new base
25375 class for Literals.
25377 * literal.cs: Make Literal derive from Constant.
25379 2001-12-09 Miguel de Icaza <miguel@ximian.com>
25381 * statement.cs (Return.Emit): Report error 157 if the user
25382 attempts to return from a finally block.
25384 (Return.Emit): Instead of emitting a return, jump to the end of
25387 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
25388 LocalBuilder to store the result of the function. ReturnLabel is
25389 the target where we jump.
25392 2001-12-09 Radek Doulik <rodo@ximian.com>
25394 * cs-parser.jay: remember alias in current namespace
25396 * ecore.cs (SimpleName::DoResolve): use aliases for types or
25399 * class.cs (LookupAlias): lookup alias in my_namespace
25401 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
25403 (LookupAlias): lookup alias in this and if needed in parent
25406 2001-12-08 Miguel de Icaza <miguel@ximian.com>
25410 * rootcontext.cs: (ModuleBuilder) Made static, first step into
25411 making things static. I need this to avoid passing the
25412 TypeContainer when calling ParameterType.
25414 * support.cs (InternalParameters.ParameterType): Remove ugly hack
25415 that did string manipulation to compute the type and then call
25416 GetType. Use Parameter.ParameterType instead.
25418 * cs-tokenizer.cs: Consume the suffix for floating values.
25420 * expression.cs (ParameterReference): figure out whether this is a
25421 reference parameter or not. Kill an extra variable by computing
25422 the arg_idx during emission.
25424 * parameter.cs (Parameters.GetParameterInfo): New overloaded
25425 function that returns whether a parameter is an out/ref value or not.
25427 (Parameter.ParameterType): The type of the parameter (base,
25428 without ref/out applied).
25430 (Parameter.Resolve): Perform resolution here.
25431 (Parameter.ExternalType): The full type (with ref/out applied).
25433 * statement.cs (Using.Emit, Using.EmitExpression): Implement
25434 support for expressions on the using statement.
25436 2001-12-07 Miguel de Icaza <miguel@ximian.com>
25438 * statement.cs (Using.EmitLocalVariableDecls): Split the
25439 localvariable handling of the using statement.
25441 (Block.EmitMeta): Keep track of variable count across blocks. We
25442 were reusing slots on separate branches of blocks.
25444 (Try.Emit): Emit the general code block, we were not emitting it.
25446 Check the type of the declaration to be an IDisposable or
25447 something that can be implicity converted to it.
25449 Emit conversions if required.
25451 * ecore.cs (EmptyExpression): New utility class.
25452 (Expression.ImplicitConversionExists): New utility function.
25454 2001-12-06 Miguel de Icaza <miguel@ximian.com>
25456 * statement.cs (Using): Implement.
25458 * expression.cs (LocalVariableReference): Support read only variables.
25460 * statement.cs: Remove the explicit emit for the Leave opcode.
25461 (VariableInfo): Add a readonly field.
25463 2001-12-05 Miguel de Icaza <miguel@ximian.com>
25465 * ecore.cs (ConvCast): new class used to encapsulate the various
25466 explicit integer conversions that works in both checked and
25467 unchecked contexts.
25469 (Expression.ConvertNumericExplicit): Use new ConvCast class to
25470 properly generate the overflow opcodes.
25472 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25474 * statement.cs: The correct type for the EmptyExpression is the
25475 element_type, not the variable type. Ravi pointed this out.
25477 2001-12-04 Ravi Pratap <ravi@ximian.com>
25479 * class.cs (Method::Define): Handle PInvoke methods specially
25480 by using DefinePInvokeMethod instead of the usual one.
25482 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
25483 above to do the task of extracting information and defining the method.
25485 2001-12-04 Ravi Pratap <ravi@ximian.com>
25487 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
25488 of the condition for string type.
25490 (Emit): Move that here.
25492 (ArrayCreation::CheckIndices): Keep string literals in their expression
25495 (EmitDynamicInitializers): Handle strings appropriately.
25497 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25499 * codegen.cs (EmitContext): Replace multiple variables with a
25500 single pointer to the current Switch statement.
25502 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
25505 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25509 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
25512 (Foreach.Emit): Foreach on arrays was not setting
25513 up the loop variables (for break/continue).
25515 (GotoCase): Semi-implented.
25517 2001-12-03 Ravi Pratap <ravi@ximian.com>
25519 * attribute.cs (CheckAttribute): Handle system attributes by using
25520 Attribute.GetAttributes to examine information we need.
25522 (GetValidPlaces): Same here.
25524 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
25526 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
25528 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
25530 (Method::Define): Set appropriate flags if we have a DllImport attribute.
25532 (Method::Emit): Handle the case when we are a PInvoke method.
25534 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25536 * expression.cs: Use ResolveWithSimpleName on compound names.
25538 2001-12-02 Ravi Pratap <ravi@ximian.com>
25540 * constant.cs (EmitConstant): Make sure we resolve the associated expression
25541 before trying to reduce it.
25543 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
25545 * constant.cs (LookupConstantValue): Implement.
25547 (EmitConstant): Use the above in emitting the constant.
25549 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
25550 that are user-defined by doing a LookupConstantValue on them.
25552 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
25555 2001-11-29 Miguel de Icaza <miguel@ximian.com>
25557 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
25559 (BaseAccess.DoResolve): Implement.
25561 (MemberAccess.DoResolve): Split this routine into a
25562 ResolveMemberAccess routine that can be used independently
25564 2001-11-28 Miguel de Icaza <miguel@ximian.com>
25566 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
25567 As that share bits of the implementation. Is returns a boolean,
25568 while As returns the Type that is being probed.
25570 2001-12-01 Ravi Pratap <ravi@ximian.com>
25572 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
25573 instead of a Literal - much easier.
25575 (EnumInTransit): Remove - utterly useless :-)
25577 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
25579 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
25581 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
25582 chain when we have no associated expression.
25584 2001-11-30 Ravi Pratap <ravi@ximian.com>
25586 * constant.cs (Define): Use Location while reporting the errror.
25588 Also emit a warning when 'new' is used and there is no inherited
25591 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
25594 (LookupEnumValue): Implement to lookup an enum member's value and define it
25597 (Populate): Re-write accordingly to use the above routine.
25599 2001-11-27 Miguel de Icaza <miguel@ximian.com>
25601 * expression.cs (This): Fix prototype for DoResolveLValue to
25602 override the base class DoResolveLValue.
25604 * cs-parser.cs: Report errors cs574 and cs575 (destructor
25607 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
25608 (we need to load the address of the field here). This fixes
25611 (FieldExpr.DoResolveLValue): Call the DoResolve
25612 function to initialize the Instance expression.
25614 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
25615 correctly the GetEnumerator operation on a value type.
25617 * cs-parser.jay: Add more simple parsing error catches.
25619 * statement.cs (Switch): Add support for string switches.
25620 Handle null specially.
25622 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
25624 2001-11-28 Ravi Pratap <ravi@ximian.com>
25626 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
25628 (declare_local_constant): New helper function.
25630 * statement.cs (AddConstant): Keep a separate record of constants
25632 (IsConstant): Implement to determine if a variable is a constant.
25634 (GetConstantExpression): Implement.
25636 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
25638 * statement.cs (IsVariableDefined): Re-write.
25640 2001-11-27 Ravi Pratap <ravi@ximian.com>
25642 * class.cs (TypeContainer::FindMembers): Look for constants
25643 in the case when we are looking for MemberTypes.Field
25645 * expression.cs (MemberAccess::DoResolve): Check that in the
25646 case we are a FieldExpr and a Literal, we are not being accessed
25647 by an instance reference.
25649 * cs-parser.jay (local_constant_declaration): Implement.
25651 (declaration_statement): Implement for constant declarations.
25653 2001-11-26 Miguel de Icaza <miguel@ximian.com>
25655 * statement.cs (Switch): Catch double defaults.
25657 (Switch): More work on the switch() statement
25658 implementation. It works for integral values now, need to finish
25662 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25664 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
25665 integer literals into other integer literals. To be used by
25668 2001-11-24 Ravi Pratap <ravi@ximian.com>
25670 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
25673 (EmitDynamicInitializers): Cope with the above since we extract data
25674 directly from ArrayData now.
25676 (ExpectInitializers): Keep track of whether initializers are mandatory
25679 (Bounds): Make it a hashtable to prevent the same dimension being
25680 recorded for every element in that dimension.
25682 (EmitDynamicInitializers): Fix bug which prevented the Set array method
25685 Also fix bug which was causing the indices to be emitted in the reverse
25688 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25690 * expression.cs (ArrayCreation): Implement the bits that Ravi left
25691 unfinished. They do not work, because the underlying code is
25694 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25696 * cs-parser.jay: Remove bogus fixme.
25698 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
25699 on Switch statement.
25701 2001-11-23 Ravi Pratap <ravi@ximian.com>
25703 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
25706 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
25707 parameter. Apparently, any expression is allowed.
25709 (ValidateInitializers): Update accordingly.
25711 (CheckIndices): Fix some tricky bugs thanks to recursion.
25713 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
25714 I was being completely brain-dead.
25716 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
25717 and re-write acordingly.
25719 (DelegateInvocation): Re-write accordingly.
25721 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
25723 (MakeByteBlob): Handle types more correctly.
25725 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
25726 initialization from expressions but it is incomplete because I am a complete
25729 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25731 * statement.cs (If.Emit): Fix a bug that generated incorrect code
25732 on If. Basically, we have to return `true' (ie, we do return to
25733 our caller) only if both branches of the if return.
25735 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
25736 short-circuit operators, handle them as short circuit operators.
25738 (Cast.DoResolve): Resolve type.
25739 (Cast.Cast): Take an expression as the target type.
25741 * cs-parser.jay (cast_expression): Remove old hack that only
25742 allowed a limited set of types to be handled. Now we take a
25743 unary_expression and we resolve to a type during semantic
25746 Use the grammar productions from Rhys to handle casts (this is
25747 not complete like Rhys syntax yet, we fail to handle that corner
25748 case that C# has regarding (-x), but we will get there.
25750 2001-11-22 Ravi Pratap <ravi@ximian.com>
25752 * class.cs (EmitFieldInitializer): Take care of the case when we have a
25753 field which is an array type.
25755 * cs-parser.jay (declare_local_variables): Support array initialization too.
25757 * typemanager.cs (MakeKey): Implement.
25759 (everywhere): Use the above appropriately.
25761 * cs-parser.jay (for_statement): Update for array initialization while
25762 declaring variables.
25764 * ecore.cs : The error message was correct, it's the variable's names that
25765 were misleading ;-) Make the code more readable.
25767 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
25768 the correct type etc.
25770 (ConvertExplicit): Handle Enum types by examining the underlying type.
25772 2001-11-21 Ravi Pratap <ravi@ximian.com>
25774 * parameter.cs (GetCallingConvention): Always return
25775 CallingConventions.Standard for now.
25777 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25779 * expression.cs (Binary.ResolveOperator): Update the values of `l'
25780 and `r' after calling DoNumericPromotions.
25782 * ecore.cs: Fix error message (the types were in the wrong order).
25784 * statement.cs (Foreach.ProbeCollectionType): Need to pass
25785 BindingFlags.Instance as well
25787 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
25788 implicit int literal conversion in an empty cast so that we
25789 propagate the right type upstream.
25791 (UnboxCast): new class used to unbox value types.
25792 (Expression.ConvertExplicit): Add explicit type conversions done
25795 (Expression.ImplicitNumericConversion): Oops, forgot to test for
25796 the target type before applying the implicit LongLiterals to ULong
25799 2001-11-21 Miguel de Icaza <miguel@ximian.com>
25801 * cs-parser.jay (for_statement): Reworked the way For works: now
25802 we declare manually any variables that are introduced in
25803 for_initializer to solve the problem of having out-of-band code
25804 emition (that is what got for broken).
25806 (declaration_statement): Perform the actual variable declaration
25807 that used to be done in local_variable_declaration here.
25809 (local_variable_declaration): Do not declare anything, just pass
25810 the information on a DictionaryEntry
25812 2001-11-20 Ravi Pratap <ravi@ximian.com>
25814 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
25815 re-write of the logic to now make it recursive.
25817 (UpdateIndices): Re-write accordingly.
25819 Store element data in a separate ArrayData list in the above methods.
25821 (MakeByteBlob): Implement to dump the array data into a byte array.
25823 2001-11-19 Ravi Pratap <ravi@ximian.com>
25825 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
25828 * constant.cs (Define): Implement.
25830 (EmitConstant): Re-write fully.
25832 Pass in location info.
25834 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
25837 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
25838 DictionaryEntry since we need location info too.
25840 (constant_declaration): Update accordingly.
25842 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
25843 code into another method : UpdateIndices.
25845 2001-11-18 Ravi Pratap <ravi@ximian.com>
25847 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
25848 some type checking etc.
25850 2001-11-17 Ravi Pratap <ravi@ximian.com>
25852 * expression.cs (ArrayCreation::ValidateInitializers): Implement
25853 bits to provide dimension info if the user skips doing that.
25855 Update second constructor to store the rank correctly.
25857 2001-11-16 Ravi Pratap <ravi@ximian.com>
25859 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
25860 and try to implement.
25862 * ../errors/cs0150.cs : Add.
25864 * ../errors/cs0178.cs : Add.
25866 2001-11-16 Miguel de Icaza <miguel@ximian.com>
25868 * statement.cs: Implement foreach on multi-dimensional arrays.
25870 * parameter.cs (Parameters.GetParameterByName): Also lookup the
25871 name of the params argument.
25873 * expression.cs: Use EmitStoreOpcode to get the right opcode while
25874 initializing the array.
25876 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
25877 we can use this elsewhere.
25879 * statement.cs: Finish implementation of foreach for single
25882 * cs-parser.jay: Use an out-of-band stack to pass information
25883 around, I wonder why I need this.
25885 foreach_block: Make the new foreach_block the current_block.
25887 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
25888 function used to return a static Parameters structure. Used for
25889 empty parameters, as those are created very frequently.
25891 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
25893 2001-11-15 Ravi Pratap <ravi@ximian.com>
25895 * interface.cs : Default modifier is private, not public. The
25896 make verify test passes again.
25898 2001-11-15 Ravi Pratap <ravi@ximian.com>
25900 * support.cs (ReflectionParameters): Fix logic to determine
25901 whether the last parameter is a params one. Test 9 passes again.
25903 * delegate.cs (Populate): Register the builders we define with
25904 RegisterParameterForBuilder. Test 19 passes again.
25906 * cs-parser.jay (property_declaration): Reference $6 instead
25907 of $$ to get at the location.
25909 (indexer_declaration): Similar stuff.
25911 (attribute): Ditto.
25913 * class.cs (Property): Register parameters for the Get and Set methods
25914 if they exist. Test 23 passes again.
25916 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
25917 call to EmitArguments as we are sure there aren't any params arguments.
25918 Test 32 passes again.
25920 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
25921 IndexOutOfRangeException.
25923 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
25924 Test 33 now passes again.
25926 2001-11-15 Miguel de Icaza <miguel@ximian.com>
25928 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
25929 broke a bunch of things. Will have to come up with a better way
25930 of tracking locations.
25932 * statement.cs: Implemented foreach for single dimension arrays.
25934 2001-11-09 Miguel de Icaza <miguel@ximian.com>
25936 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
25937 an error. This removes the lookup from the critical path.
25939 * cs-parser.jay: Removed use of temporary_loc, which is completely
25942 2001-11-14 Miguel de Icaza <miguel@ximian.com>
25944 * support.cs (ReflectionParameters.ParameterModifier): Report
25945 whether the argument is a PARAMS argument or not.
25947 * class.cs: Set the attribute `ParamArrayAttribute' on the
25948 parameter argument.
25950 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
25951 and cons_param_array_attribute (ConstructorInfo for
25952 ParamArrayAttribute).,
25954 * codegen.cs: Emit the return using the `Return' statement, that
25955 way we can report the error correctly for missing return values.
25957 * class.cs (Method.Emit): Clean up.
25959 * expression.cs (Argument.Resolve): Take another argument: the
25960 location where this argument is used. Notice that this is not
25961 part of the "Argument" class as to reduce the size of the
25962 structure (we know the approximate location anyways).
25964 Test if the argument is a variable-reference, if not, then
25965 complain with a 206.
25967 (Argument.Emit): Emit addresses of variables.
25969 (Argument.FullDesc): Simplify.
25971 (Invocation.DoResolve): Update for Argument.Resolve.
25973 (ElementAccess.DoResolve): ditto.
25975 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
25976 method should be virtual, as this method is always virtual.
25978 (NewDelegate.DoResolve): Update for Argument.Resolve.
25980 * class.cs (ConstructorInitializer.DoResolve): ditto.
25982 * attribute.cs (Attribute.Resolve): ditto.
25984 2001-11-13 Miguel de Icaza <miguel@ximian.com>
25986 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
25988 * expression.cs (ParameterReference): Drop IStackStorage and implement
25989 IAssignMethod instead.
25991 (LocalVariableReference): ditto.
25993 * ecore.cs (FieldExpr): Drop IStackStorage and implement
25994 IAssignMethod instead.
25996 2001-11-13 Miguel de Icaza <miguel@ximian.com>
25998 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
25999 enumerations that are used in heavily used structures derive from
26000 byte in a laughable and pathetic attempt to reduce memory usage.
26001 This is the kind of pre-optimzations that you should not do at
26002 home without adult supervision.
26004 * expression.cs (UnaryMutator): New class, used to handle ++ and
26005 -- separatedly from the other unary operators. Cleans up the
26006 code, and kills the ExpressionStatement dependency in Unary.
26008 (Unary): Removed `method' and `Arguments' from this class, making
26009 it smaller, and moving it all to SimpleCall, so I can reuse this
26010 code in other locations and avoid creating a lot of transient data
26011 strucutres when not required.
26013 * cs-parser.jay: Adjust for new changes.
26015 2001-11-11 Miguel de Icaza <miguel@ximian.com>
26017 * enum.cs (Enum.Populate): If there is a failure during
26020 * cs-parser.jay (opt_enum_base): we used to catch type errors
26021 here, but this is really incorrect. The type error should be
26022 catched during semantic analysis.
26024 2001-12-11 Ravi Pratap <ravi@ximian.com>
26026 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
26027 current_local_parameters as expected since I, in my stupidity, had forgotten
26030 * attribute.cs (GetValidPlaces): Fix stupid bug.
26032 * class.cs (Method::Emit): Perform check on applicability of attributes.
26034 (Constructor::Emit): Ditto.
26036 (Field::Emit): Ditto.
26038 (Field.Location): Store location information.
26040 (Property, Event, Indexer, Operator): Ditto.
26042 * cs-parser.jay (field_declaration): Pass in location for each field.
26044 * ../errors/cs0592.cs : Add.
26046 2001-11-12 Ravi Pratap <ravi@ximian.com>
26048 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
26050 (InitCoreTypes): Update accordingly.
26052 (RegisterAttrType, LookupAttr): Implement.
26054 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
26055 info about the same.
26057 (Resolve): Update to populate the above as necessary.
26059 (Error592): Helper.
26061 (GetValidPlaces): Helper to the above.
26063 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
26065 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
26067 2001-11-12 Ravi Pratap <ravi@ximian.com>
26069 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
26071 * ../errors/cs0617.cs : Add.
26073 2001-11-11 Ravi Pratap <ravi@ximian.com>
26075 * enum.cs (Emit): Rename to Populate to be more consistent with what
26076 we expect it to do and when exactly it is called.
26078 * class.cs, rootcontext.cs : Update accordingly.
26080 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
26081 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
26083 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
26085 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
26086 of a fieldinfo using the above, when dealing with a FieldBuilder.
26088 2001-11-10 Ravi Pratap <ravi@ximian.com>
26090 * ../errors/cs0031.cs : Add.
26092 * ../errors/cs1008.cs : Add.
26094 * ../errrors/cs0543.cs : Add.
26096 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
26099 (FindMembers): Implement.
26101 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
26102 enums and delegates too.
26104 (enum_types): Rename to builder_to_enum.
26106 (delegate_types): Rename to builder_to_delegate.
26108 * delegate.cs (FindMembers): Implement.
26110 2001-11-09 Ravi Pratap <ravi@ximian.com>
26112 * typemanager.cs (IsEnumType): Implement.
26114 * enum.cs (Emit): Re-write parts to account for the underlying type
26115 better and perform checking etc.
26117 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
26118 of the underlying type.
26120 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
26123 * enum.cs (error31): Helper to report error #31.
26125 * cs-parser.jay (enum_declaration): Store location of each member too.
26127 * enum.cs (member_to_location): New hashtable.
26129 (AddEnumMember): Update location hashtable.
26131 (Emit): Use the location of each member while reporting errors.
26133 2001-11-09 Miguel de Icaza <miguel@ximian.com>
26135 * cs-parser.jay: A for_initializer if is a
26136 local_variable_declaration really ammount to have an implicit
26137 block with the variable declaration and no initializer for for.
26139 * statement.cs (For.Emit): Cope with null initializers.
26141 This fixes the infinite loop on for initializers.
26143 2001-11-08 Miguel de Icaza <miguel@ximian.com>
26145 * enum.cs: More cleanup.
26147 * ecore.cs: Remove dead code.
26149 * class.cs (Property.Emit): More simplification.
26150 (Event.Emit): ditto.
26152 Reworked to have less levels of indentation.
26154 2001-11-08 Ravi Pratap <ravi@ximian.com>
26156 * class.cs (Property): Emit attributes.
26166 * enum.cs (Emit): Ditto.
26168 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
26171 * class.cs (Field, Event, etc.): Move attribute generation into the
26172 Emit method everywhere.
26174 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
26175 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
26176 as we had no way of defining nested enums !
26178 * rootcontext.cs : Adjust code accordingly.
26180 * typemanager.cs (AddEnumType): To keep track of enum types separately.
26182 2001-11-07 Ravi Pratap <ravi@ximian.com>
26184 * expression.cs (EvalConstantExpression): Move into ecore.cs
26186 * enum.cs (Enum): Rename some members and make them public and readonly
26187 according to our convention.
26189 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
26192 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
26194 (Enum::Emit): Write a simple version for now which doesn't try to compute
26195 expressions. I shall modify this to be more robust in just a while.
26197 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
26199 (TypeContainer::CloseType): Create the Enum types too.
26201 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
26203 * expression.cs (EvalConstantExpression): Get rid of completely.
26205 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
26206 user-defined values and other cases.
26208 (IsValidEnumLiteral): Helper function.
26210 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
26211 out there in the case we had a literal FieldExpr.
26213 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
26215 (Literalize): Revamp a bit to take two arguments.
26217 (EnumLiteral): New class which derives from Literal to wrap enum literals.
26219 2001-11-06 Ravi Pratap <ravi@ximian.com>
26221 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
26223 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
26225 (Resolve): Use the above to ensure we have proper initializers.
26227 2001-11-05 Ravi Pratap <ravi@ximian.com>
26229 * expression.cs (Expression::EvalConstantExpression): New method to
26230 evaluate constant expressions.
26232 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
26234 2001-11-07 Miguel de Icaza <miguel@ximian.com>
26236 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
26239 (Binary.ResolveOperator): Handle operator != (object a, object b)
26240 and operator == (object a, object b);
26242 (Binary.DoNumericPromotions): Indicate whether the numeric
26243 promotion was possible.
26245 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
26248 Made the ArrayAccess implement interface IAssignMethod instead of
26249 IStackStore as the order in which arguments are passed reflects
26252 * assign.cs: Instead of using expr.ExprClass to select the way of
26253 assinging, probe for the IStackStore/IAssignMethod interfaces.
26255 * typemanager.cs: Load InitializeArray definition.
26257 * rootcontext.cs (RootContext.MakeStaticData): Used to define
26258 static data that can be used to initialize arrays.
26260 2001-11-05 Miguel de Icaza <miguel@ximian.com>
26262 * expression.cs: Handle operator== and operator!= for booleans.
26264 (Conditioal.Reduce): Implement reducer for the ?: operator.
26266 (Conditional.Resolve): Implement dead code elimination.
26268 (Binary.Resolve): Catch string literals and return a new
26269 concatenated string.
26271 (Unary.Reduce): Implement reduction of unary expressions.
26273 * ecore.cs: Split out the expression core handling here.
26275 (Expression.Reduce): New method used to perform constant folding
26276 and CSE. This is needed to support constant-expressions.
26278 * statement.cs (Statement.EmitBoolExpression): Pass true and false
26279 targets, and optimize for !x.
26281 2001-11-04 Ravi Pratap <ravi@ximian.com>
26283 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
26284 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
26285 set custom atttributes.
26287 * literal.cs (Literal::GetValue): New abstract method to return the actual
26288 value of the literal, cast as an object.
26290 (*Literal): Implement GetValue method.
26292 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
26293 expressions to the arraylist but objects of type Argument.
26295 * class.cs (TypeContainer::Emit): Emit our attributes too.
26297 (Method::Emit, Constructor::Emit): Ditto.
26299 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
26300 to be ignoring earlier.
26302 2001-11-03 Ravi Pratap <ravi@ximian.com>
26304 * attribute.cs (AttributeSection::Define): Implement to do the business
26305 of constructing a CustomAttributeBuilder.
26307 (Attribute): New trivial class. Increases readability of code.
26309 * cs-parser.jay : Update accordingly.
26311 (positional_argument_list, named_argument_list, named_argument): New rules
26313 (attribute_arguments): Use the above so that we are more correct.
26315 2001-11-02 Ravi Pratap <ravi@ximian.com>
26317 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
26318 to perform all checks for a method with a params parameter.
26320 (Invocation::OverloadResolve): Update to use the above method and therefore
26321 cope correctly with params method invocations.
26323 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
26326 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
26327 constructors in our parent too because we can't afford to miss out on
26330 * attribute.cs (AttributeSection): New name for the class Attribute
26332 Other trivial changes to improve readability.
26334 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
26335 use the new class names.
26337 2001-11-01 Ravi Pratap <ravi@ximian.com>
26339 * class.cs (Method::Define): Complete definition for params types too
26341 (Indexer::Define): Ditto.
26343 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
26344 Cope everywhere with a request for info about the array parameter.
26346 2001-11-01 Ravi Pratap <ravi@ximian.com>
26348 * tree.cs (RecordNamespace): Fix up to check for the correct key.
26350 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
26351 local_variable_type to extract the string corresponding to the type.
26353 (local_variable_type): Fixup the action to use the new helper method.
26355 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
26358 * expression.cs : Clean out code which uses the above.
26360 2001-10-31 Ravi Pratap <ravi@ximian.com>
26362 * typemanager.cs (RegisterMethod): Check if we already have an existing key
26363 and bale out if necessary by returning a false.
26365 (RegisterProperty): Ditto.
26367 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
26368 and print out appropriate error messages.
26370 * interface.cs (everywhere): Ditto.
26372 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
26373 location to constructor.
26375 * class.cs (Property, Event, Indexer): Update accordingly.
26377 * ../errors/cs111.cs : Added.
26379 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
26380 of a method, as laid down by the spec.
26382 (Invocation::OverloadResolve): Use the above method.
26384 2001-10-31 Ravi Pratap <ravi@ximian.com>
26386 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
26387 now take a TypeContainer and a Parameters object.
26389 (ParameterData): Modify return type of ParameterModifier method to be
26390 Parameter.Modifier and not a string.
26392 (ReflectionParameters, InternalParameters): Update accordingly.
26394 * expression.cs (Argument::GetParameterModifier): Same here.
26396 * support.cs (InternalParameters::ParameterType): Find a better way of determining
26397 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
26398 symbol in it at all so maybe this is only for now.
26400 2001-10-30 Ravi Pratap <ravi@ximian.com>
26402 * support.cs (InternalParameters): Constructor now takes an extra argument
26403 which is the actual Parameters class.
26405 (ParameterDesc): Update to provide info on ref/out modifiers.
26407 * class.cs (everywhere): Update call to InternalParameters to pass in
26408 the second argument too.
26410 * support.cs (ParameterData): Add ParameterModifier, which is a method
26411 to return the modifier info [ref/out etc]
26413 (InternalParameters, ReflectionParameters): Implement the above.
26415 * expression.cs (Argument::ParameterModifier): Similar function to return
26416 info about the argument's modifiers.
26418 (Invocation::OverloadResolve): Update to take into account matching modifiers
26421 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
26422 a new SetFormalParameters object which we pass to InternalParameters.
26424 2001-10-30 Ravi Pratap <ravi@ximian.com>
26426 * expression.cs (NewArray): Merge into the ArrayCreation class.
26428 2001-10-29 Ravi Pratap <ravi@ximian.com>
26430 * expression.cs (NewArray): Merge classes NewBuiltinArray and
26431 NewUserdefinedArray into one as there wasn't much of a use in having
26434 * expression.cs (Argument): Change field's name to ArgType from Type.
26436 (Type): New readonly property which returns the proper type, taking into
26437 account ref/out modifiers.
26439 (everywhere): Adjust code accordingly for the above.
26441 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
26442 whether we are emitting for a ref or out parameter.
26444 * expression.cs (Argument::Emit): Use the above field to set the state.
26446 (LocalVariableReference::Emit): Update to honour the flag and emit the
26449 * parameter.cs (Attributes): Set the correct flags for ref parameters.
26451 * expression.cs (Argument::FullDesc): New function to provide a full desc.
26453 * support.cs (ParameterData): Add method ParameterDesc to the interface.
26455 (ReflectionParameters, InternalParameters): Implement the above method.
26457 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
26460 (Invocation::FullMethodDesc): Ditto.
26462 2001-10-29 Miguel de Icaza <miguel@ximian.com>
26464 * cs-parser.jay: Add extra production for the second form of array
26467 * expression.cs (ArrayCreation): Update to reflect the above
26470 * Small changes to prepare for Array initialization.
26472 2001-10-28 Miguel de Icaza <miguel@ximian.com>
26474 * typemanager.cs (ImplementsInterface): interface might be null;
26475 Deal with this problem;
26477 Also, we do store negative hits on the cache (null values), so use
26478 this instead of calling t.GetInterfaces on the type everytime.
26480 2001-10-28 Ravi Pratap <ravi@ximian.com>
26482 * typemanager.cs (IsBuiltinType): New method to help determine the same.
26484 * expression.cs (New::DoResolve): Get rid of array creation code and instead
26485 split functionality out into different classes.
26487 (New::FormArrayType): Move into NewBuiltinArray.
26489 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
26492 (NewBuiltinArray): New class to handle creation of built-in arrays.
26494 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
26495 account creation of one-dimensional arrays.
26497 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
26499 (NewUserdefinedArray::DoResolve): Implement.
26501 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
26503 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
26504 we maintain inside the TypeManager. This is necessary to perform lookups on the
26507 (LookupType): Update to perform GetType on the module builders too.
26509 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
26511 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
26513 2001-10-23 Ravi Pratap <ravi@ximian.com>
26515 * expression.cs (New::DoResolve): Implement guts of array creation.
26517 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
26519 2001-10-27 Miguel de Icaza <miguel@ximian.com>
26521 * expression.cs: Fix bug I introduced lsat night that broke
26524 (Expression.Resolve): Report a 246 error (can not resolve name)
26525 if we find a SimpleName in the stream.
26527 (Expression.ResolveLValue): Ditto.
26529 (Expression.ResolveWithSimpleName): This function is a variant of
26530 ResolveName, this one allows SimpleNames to be returned without a
26531 warning. The only consumer of SimpleNames is MemberAccess
26533 2001-10-26 Miguel de Icaza <miguel@ximian.com>
26535 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
26536 might arrive here. I have my doubts that this is correct.
26538 * statement.cs (Lock): Implement lock statement.
26540 * cs-parser.jay: Small fixes to support `lock' and `using'
26542 * cs-tokenizer.cs: Remove extra space
26544 * driver.cs: New flag --checked, allows to turn on integer math
26547 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
26548 Threading.Monitor.Exit
26550 2001-10-23 Miguel de Icaza <miguel@ximian.com>
26552 * expression.cs (IndexerAccess::DoResolveLValue): Set the
26553 Expression Class to be IndexerAccess.
26555 Notice that Indexer::DoResolve sets the eclass to Value.
26557 2001-10-22 Miguel de Icaza <miguel@ximian.com>
26559 * class.cs (TypeContainer::Emit): Emit code for indexers.
26561 * assign.cs (IAssignMethod): New interface implemented by Indexers
26562 and Properties for handling assignment.
26564 (Assign::Emit): Simplify and reuse code.
26566 * expression.cs (IndexerAccess, PropertyExpr): Implement
26567 IAssignMethod, clean up old code.
26569 2001-10-22 Ravi Pratap <ravi@ximian.com>
26571 * typemanager.cs (ImplementsInterface): New method to determine if a type
26572 implements a given interface. Provides a nice cache too.
26574 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
26577 (ConvertReferenceExplicit): Ditto.
26579 * delegate.cs (Delegate::Populate): Update to define the parameters on the
26580 various methods, with correct names etc.
26582 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
26583 Operator.UnaryNegation.
26585 * cs-parser.jay (operator_declarator): Be a little clever in the case where
26586 we have a unary plus or minus operator.
26588 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
26591 * everywhere : update accordingly.
26593 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
26596 * class.cs (Method::Define): For the case where we are implementing a method
26597 inherited from an interface, we need to set the MethodAttributes.Final flag too.
26598 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
26600 2001-10-21 Ravi Pratap <ravi@ximian.com>
26602 * interface.cs (FindMembers): Implement to work around S.R.E
26605 * typemanager.cs (IsInterfaceType): Implement.
26607 (FindMembers): Update to handle interface types too.
26609 * expression.cs (ImplicitReferenceConversion): Re-write bits which
26610 use IsAssignableFrom as that is not correct - it doesn't work.
26612 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
26613 and accordingly override EmitStatement.
26615 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
26616 using the correct logic :-)
26618 2001-10-19 Ravi Pratap <ravi@ximian.com>
26620 * ../errors/cs-11.cs : Add to demonstrate error -11
26622 2001-10-17 Miguel de Icaza <miguel@ximian.com>
26624 * assign.cs (Assign::Resolve): Resolve right hand side first, and
26625 then pass this as a hint to ResolveLValue.
26627 * expression.cs (FieldExpr): Add Location information
26629 (FieldExpr::LValueResolve): Report assignment to readonly
26632 (Expression::ExprClassFromMemberInfo): Pass location information.
26634 (Expression::ResolveLValue): Add new method that resolves an
26637 (Expression::DoResolveLValue): Default invocation calls
26640 (Indexers): New class used to keep track of indexers in a given
26643 (IStackStore): Renamed from LValue, as it did not really describe
26644 what this did. Also ResolveLValue is gone from this interface and
26645 now is part of Expression.
26647 (ElementAccess): Depending on the element access type
26649 * typemanager.cs: Add `indexer_name_type' as a Core type
26650 (System.Runtime.CompilerServices.IndexerNameAttribute)
26652 * statement.cs (Goto): Take a location.
26654 2001-10-18 Ravi Pratap <ravi@ximian.com>
26656 * delegate.cs (Delegate::VerifyDelegate): New method to verify
26657 if two delegates are compatible.
26659 (NewDelegate::DoResolve): Update to take care of the case when
26660 we instantiate a delegate from another delegate.
26662 * typemanager.cs (FindMembers): Don't even try to look up members
26663 of Delegate types for now.
26665 2001-10-18 Ravi Pratap <ravi@ximian.com>
26667 * delegate.cs (NewDelegate): New class to take care of delegate
26670 * expression.cs (New): Split the delegate related code out into
26671 the NewDelegate class.
26673 * delegate.cs (DelegateInvocation): New class to handle delegate
26676 * expression.cs (Invocation): Split out delegate related code into
26677 the DelegateInvocation class.
26679 2001-10-17 Ravi Pratap <ravi@ximian.com>
26681 * expression.cs (New::DoResolve): Implement delegate creation fully
26682 and according to the spec.
26684 (New::DoEmit): Update to handle delegates differently.
26686 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
26687 because of which we were printing out arguments in reverse order !
26689 * delegate.cs (VerifyMethod): Implement to check if the given method
26690 matches the delegate.
26692 (FullDelegateDesc): Implement.
26694 (VerifyApplicability): Implement.
26696 * expression.cs (Invocation::DoResolve): Update to accordingly handle
26697 delegate invocations too.
26699 (Invocation::Emit): Ditto.
26701 * ../errors/cs1593.cs : Added.
26703 * ../errors/cs1594.cs : Added.
26705 * delegate.cs (InstanceExpression, TargetMethod): New properties.
26707 2001-10-16 Ravi Pratap <ravi@ximian.com>
26709 * typemanager.cs (intptr_type): Core type for System.IntPtr
26711 (InitCoreTypes): Update for the same.
26713 (iasyncresult_type, asynccallback_type): Ditto.
26715 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
26718 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
26721 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
26722 the builders for the 4 members of a delegate type :-)
26724 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
26727 * expression.cs (New::DoResolve): Implement guts for delegate creation.
26729 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
26731 2001-10-15 Miguel de Icaza <miguel@ximian.com>
26733 * statement.cs (Break::Emit): Implement.
26734 (Continue::Emit): Implement.
26736 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
26737 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
26738 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
26739 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
26742 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
26743 properties that track the label for the current loop (begin of the
26744 loop and end of the loop).
26746 2001-10-15 Ravi Pratap <ravi@ximian.com>
26748 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
26749 use of emitting anything at all.
26751 * class.cs, rootcontext.cs : Get rid of calls to the same.
26753 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
26755 (Populate): Define the constructor correctly and set the implementation
26758 * typemanager.cs (delegate_types): New hashtable to hold delegates that
26761 (AddDelegateType): Implement.
26763 (IsDelegateType): Implement helper method.
26765 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
26767 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
26768 and accordingly handle it.
26770 * delegate.cs (Populate): Take TypeContainer argument.
26771 Implement bits to define the Invoke method. However, I still haven't figured out
26772 how to take care of the native int bit :-(
26774 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
26775 Qualify the name of the delegate, not its return type !
26777 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
26780 (StandardConversionExists): Checking for array types turns out to be recursive.
26782 (ConvertReferenceExplicit): Implement array conversion.
26784 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
26786 2001-10-12 Ravi Pratap <ravi@ximian.com>
26788 * cs-parser.jay (delegate_declaration): Store the fully qualified
26789 name as it is a type declaration.
26791 * delegate.cs (ReturnType, Name): Rename members to these. Make them
26794 (DefineDelegate): Renamed from Define. Does the same thing essentially,
26795 as TypeContainer::DefineType.
26797 (Populate): Method in which all the definition of the various methods (Invoke)
26800 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
26803 (CloseDelegate): Finally creates the delegate.
26805 * class.cs (TypeContainer::DefineType): Update to define delegates.
26806 (Populate, Emit and CloseType): Do the same thing here too.
26808 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
26809 delegates in all these operations.
26811 2001-10-14 Miguel de Icaza <miguel@ximian.com>
26813 * expression.cs: LocalTemporary: a new expression used to
26814 reference a temporary that has been created.
26816 * assign.cs: Handle PropertyAccess back here, so that we can
26817 provide the proper semantic access to properties.
26819 * expression.cs (Expression::ConvertReferenceExplicit): Implement
26820 a few more explicit conversions.
26822 * modifiers.cs: `NEW' modifier maps to HideBySig.
26824 * expression.cs (PropertyExpr): Make this into an
26825 ExpressionStatement, and support the EmitStatement code path.
26827 Perform get/set error checking, clean up the interface.
26829 * assign.cs: recognize PropertyExprs as targets, and if so, turn
26830 them into toplevel access objects.
26832 2001-10-12 Miguel de Icaza <miguel@ximian.com>
26834 * expression.cs: PropertyExpr::PropertyExpr: use work around the
26837 * typemanager.cs: Keep track here of our PropertyBuilders again to
26838 work around lameness in SRE.
26840 2001-10-11 Miguel de Icaza <miguel@ximian.com>
26842 * expression.cs (LValue::LValueResolve): New method in the
26843 interface, used to perform a second resolution pass for LValues.
26845 (This::DoResolve): Catch the use of this in static methods.
26847 (This::LValueResolve): Implement.
26849 (This::Store): Remove warning, assigning to `this' in structures
26852 (Invocation::Emit): Deal with invocation of
26853 methods on value types. We need to pass the address to structure
26854 methods rather than the object itself. (The equivalent code to
26855 emit "this" for structures leaves the entire structure on the
26856 stack instead of a pointer to it).
26858 (ParameterReference::DoResolve): Compute the real index for the
26859 argument based on whether the method takes or not a `this' pointer
26860 (ie, the method is static).
26862 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
26863 value types returned from functions when we need to invoke a
26864 method on the sturcture.
26867 2001-10-11 Ravi Pratap <ravi@ximian.com>
26869 * class.cs (TypeContainer::DefineType): Method to actually do the business of
26870 defining the type in the Modulebuilder or Typebuilder. This is to take
26871 care of nested types which need to be defined on the TypeBuilder using
26872 DefineNestedMethod.
26874 (TypeContainer::GetClassBases): Implement. Essentially the code from the
26875 methods in RootContext, only ported to be part of TypeContainer.
26877 (TypeContainer::GetInterfaceOrClass): Ditto.
26879 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
26881 * interface.cs (Interface::DefineInterface): New method. Does exactly
26882 what RootContext.CreateInterface did earlier, only it takes care of nested types
26885 (Interface::GetInterfaces): Move from RootContext here and port.
26887 (Interface::GetInterfaceByName): Same here.
26889 * rootcontext.cs (ResolveTree): Re-write.
26891 (PopulateTypes): Re-write.
26893 * class.cs (TypeContainer::Populate): Populate nested types too.
26894 (TypeContainer::Emit): Emit nested members too.
26896 * typemanager.cs (AddUserType): Do not make use of the FullName property,
26897 instead just use the name argument passed in as it is already fully
26900 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
26901 to TypeContainer mapping to see if a type is user-defined.
26903 * class.cs (TypeContainer::CloseType): Implement.
26905 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
26906 the default constructor.
26908 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
26911 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
26913 * interface.cs (CloseType): Create the type here.
26915 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
26918 Remove all the methods which are now in TypeContainer.
26920 2001-10-10 Ravi Pratap <ravi@ximian.com>
26922 * delegate.cs (Define): Re-write bits to define the delegate
26925 2001-10-10 Miguel de Icaza <miguel@ximian.com>
26927 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
26929 * expression.cs (ImplicitReferenceConversion): handle null as well
26930 as a source to convert to any reference type.
26932 * statement.cs (Return): Perform any implicit conversions to
26933 expected return type.
26935 Validate use of return statement.
26937 * codegen.cs (EmitContext): Pass the expected return type here.
26939 * class.cs (Method, Constructor, Property): Pass expected return
26940 type to EmitContext.
26942 2001-10-09 Miguel de Icaza <miguel@ximian.com>
26944 * expression.cs: Make DoResolve take an EmitContext instead of a
26947 Replaced `l' and `location' for `loc', for consistency.
26949 (Error, Warning): Remove unneeded Tc argument.
26951 * assign.cs, literal.cs, constant.cs: Update to new calling
26954 * codegen.cs: EmitContext now contains a flag indicating whether
26955 code is being generated in a static method or not.
26957 * cs-parser.jay: DecomposeQI, new function that replaces the old
26958 QualifiedIdentifier. Now we always decompose the assembled
26959 strings from qualified_identifier productions into a group of
26962 2001-10-08 Miguel de Icaza <miguel@ximian.com>
26964 * rootcontext.cs: Deal with field-less struct types correctly now
26965 by passing the size option to Define Type.
26967 * class.cs: Removed hack that created one static field.
26969 2001-10-07 Miguel de Icaza <miguel@ximian.com>
26971 * statement.cs: Moved most of the code generation here.
26973 2001-10-09 Ravi Pratap <ravi@ximian.com>
26975 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
26978 (ElementAccess): Remove useless bits for now - keep checks as the spec
26981 2001-10-08 Ravi Pratap <ravi@ximian.com>
26983 * expression.cs (ElementAccess::DoResolve): Remove my crap code
26984 and start performing checks according to the spec.
26986 2001-10-07 Ravi Pratap <ravi@ximian.com>
26988 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
26989 rank_specifiers instead.
26991 (rank_specifiers): Change the order in which the rank specifiers are stored
26993 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
26995 * expression.cs (ElementAccess): Implement the LValue interface too.
26997 2001-10-06 Ravi Pratap <ravi@ximian.com>
26999 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
27000 except that user defined conversions are not included.
27002 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
27003 perform the conversion of the return type, if necessary.
27005 (New::DoResolve): Check whether we are creating an array or an object
27006 and accordingly do the needful.
27008 (New::Emit): Same here.
27010 (New::DoResolve): Implement guts of array creation.
27012 (New::FormLookupType): Helper function.
27014 2001-10-07 Miguel de Icaza <miguel@ximian.com>
27016 * codegen.cs: Removed most of the code generation here, and move the
27017 corresponding code generation bits to the statement classes.
27019 Added support for try/catch/finalize and throw.
27021 * cs-parser.jay: Added support for try/catch/finalize.
27023 * class.cs: Catch static methods having the flags override,
27024 virtual or abstract.
27026 * expression.cs (UserCast): This user cast was not really doing
27027 what it was supposed to do. Which is to be born in fully resolved
27028 state. Parts of the resolution were being performed at Emit time!
27032 2001-10-05 Miguel de Icaza <miguel@ximian.com>
27034 * expression.cs: Implicity convert the result from UserCast.
27036 2001-10-05 Ravi Pratap <ravi@ximian.com>
27038 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
27039 prevented it from working correctly.
27041 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
27042 merely ConvertImplicit.
27044 2001-10-05 Miguel de Icaza <miguel@ximian.com>
27046 * typemanager.cs: Make the LookupTypeContainer function static,
27047 and not per-instance.
27049 * class.cs: Make static FindMembers (the one that takes a Type
27052 * codegen.cs: Add EmitForeach here.
27054 * cs-parser.jay: Make foreach a toplevel object instead of the
27055 inline expansion, as we need to perform semantic analysis on it.
27057 2001-10-05 Ravi Pratap <ravi@ximian.com>
27059 * expression.cs (Expression::ImplicitUserConversion): Rename to
27060 UserDefinedConversion.
27062 (Expression::UserDefinedConversion): Take an extra argument specifying
27063 whether we look for explicit user conversions too.
27065 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
27067 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
27069 (ExplicitUserConversion): Make it a call to UserDefinedConversion
27070 with the appropriate arguments.
27072 * cs-parser.jay (cast_expression): Record location too.
27074 * expression.cs (Cast): Record location info.
27076 (Expression::ConvertExplicit): Take location argument.
27078 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
27079 to determine if we are doing explicit conversions.
27081 (UserCast::Emit): Update accordingly.
27083 (Expression::ConvertExplicit): Report an error if everything fails.
27085 * ../errors/cs0030.cs : Add.
27087 2001-10-04 Miguel de Icaza <miguel@ximian.com>
27089 * modifiers.cs: If the ABSTRACT keyword is present, also set the
27090 virtual and newslot bits.
27092 * class.cs (TypeContainer::RegisterRequiredImplementations):
27093 Record methods we need.
27095 (TypeContainer::MakeKey): Helper function to make keys for
27096 MethodBases, since the Methodbase key is useless.
27098 (TypeContainer::Populate): Call RegisterRequiredImplementations
27099 before defining the methods.
27101 Create a mapping for method_builders_to_methods ahead of time
27102 instead of inside a tight loop.
27104 (::RequireMethods): Accept an object as the data to set into the
27105 hashtable so we can report interface vs abstract method mismatch.
27107 2001-10-03 Miguel de Icaza <miguel@ximian.com>
27109 * report.cs: Make all of it static.
27111 * rootcontext.cs: Drop object_type and value_type computations, as
27112 we have those in the TypeManager anyways.
27114 Drop report instance variable too, now it is a global.
27116 * driver.cs: Use try/catch on command line handling.
27118 Add --probe option to debug the error reporting system with a test
27121 * report.cs: Add support for exiting program when a probe
27122 condition is reached.
27124 2001-10-03 Ravi Pratap <ravi@ximian.com>
27126 * expression.cs (Binary::DoNumericPromotions): Fix the case when
27127 we do a forcible conversion regardless of type, to check if
27128 ForceConversion returns a null.
27130 (Binary::error19): Use location to report error.
27132 (Unary::error23): Use location here too.
27134 * ../errors/cs0019.cs : Check in.
27136 * ../errors/cs0023.cs : Check in.
27138 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
27139 case of a non-null MethodInfo object with a length of 0 !
27141 (Binary::ResolveOperator): Flag error if overload resolution fails to find
27142 an applicable member - according to the spec :-)
27143 Also fix logic to find members in base types.
27145 (Unary::ResolveOperator): Same here.
27147 (Unary::report23): Change name to error23 and make first argument a TypeContainer
27148 as I was getting thoroughly confused between this and error19 :-)
27150 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
27151 (::FindMostEncompassedType): Implement.
27152 (::FindMostEncompassingType): Implement.
27153 (::StandardConversionExists): Implement.
27155 (UserImplicitCast): Re-vamp. We now need info about most specific
27156 source and target types so that we can do the necessary conversions.
27158 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
27159 mathematical union with no duplicates.
27161 2001-10-03 Miguel de Icaza <miguel@ximian.com>
27163 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
27164 in order from base classes to child classes, so that we can in
27165 child classes look up in our parent for method names and
27166 attributes (required for handling abstract, virtual, new, override
27167 constructs: we need to instrospect our base class, and if we dont
27168 populate the classes in order, the introspection might be
27169 incorrect. For example, a method could query its parent before
27170 the parent has any methods and would determine that the parent has
27171 no abstract methods (while it could have had them)).
27173 (RootContext::CreateType): Record the order in which we define the
27176 2001-10-02 Miguel de Icaza <miguel@ximian.com>
27178 * class.cs (TypeContainer::Populate): Also method definitions can
27179 fail now, keep track of this.
27181 (TypeContainer::FindMembers): Implement support for
27182 DeclaredOnly/noDeclaredOnly flag.
27184 (Constructor::Emit) Return the ConstructorBuilder.
27186 (Method::Emit) Return the MethodBuilder.
27187 Check for abstract or virtual methods to be public.
27189 * rootcontext.cs (RootContext::CreateType): Register all the
27190 abstract methods required for the class to be complete and the
27191 interface methods that must be implemented.
27193 * cs-parser.jay: Report error 501 (method requires body if it is
27194 not marked abstract or extern).
27196 * expression.cs (TypeOf::Emit): Implement.
27198 * typemanager.cs: runtime_handle_type, new global type.
27200 * class.cs (Property::Emit): Generate code for properties.
27202 2001-10-02 Ravi Pratap <ravi@ximian.com>
27204 * expression.cs (Unary::ResolveOperator): Find operators on base type
27205 too - we now conform exactly to the spec.
27207 (Binary::ResolveOperator): Same here.
27209 * class.cs (Operator::Define): Fix minor quirk in the tests.
27211 * ../errors/cs0215.cs : Added.
27213 * ../errors/cs0556.cs : Added.
27215 * ../errors/cs0555.cs : Added.
27217 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27219 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
27220 single integer which is really efficient
27222 2001-10-01 Ravi Pratap <ravi@ximian.com>
27224 * expression.cs (Expression::ImplicitUserConversion): Use location
27225 even in the case when we are examining True operators.
27227 * class.cs (Operator::Define): Perform extensive checks to conform
27228 with the rules for operator overloading in the spec.
27230 * expression.cs (Expression::ImplicitReferenceConversion): Implement
27231 some of the other conversions mentioned in the spec.
27233 * typemanager.cs (array_type): New static member for the System.Array built-in
27236 (cloneable_interface): For System.ICloneable interface.
27238 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
27239 we start resolving the tree and populating types.
27241 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
27243 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27245 * expression.cs (Expression::ExprClassFromMemberInfo,
27246 Expression::Literalize): Create literal expressions from
27247 FieldInfos which are literals.
27249 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
27250 type casts, because they were wrong. The test suite in tests
27253 (ImplicitNumericConversion): ushort to ulong requires a widening
27256 Int32 constant to long requires widening cast as well.
27258 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
27259 for integers because the type on the stack is not i4.
27261 2001-09-30 Miguel de Icaza <miguel@ximian.com>
27263 * expression.cs (report118): require location argument.
27265 * parameter.cs: Do not dereference potential null value.
27267 * class.cs: Catch methods that lack the `new' keyword when
27268 overriding a name. Report warnings when `new' is used without
27269 anything being there to override.
27271 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
27273 * class.cs: Only add constructor to hashtable if it is non-null
27274 (as now constructors can fail on define).
27276 (TypeManager, Class, Struct): Take location arguments.
27278 Catch field instance initialization in structs as errors.
27280 accepting_filter: a new filter for FindMembers that is static so
27281 that we dont create an instance per invocation.
27283 (Constructor::Define): Catch errors where a struct constructor is
27286 * cs-parser.jay: Pass location information for various new
27289 * delegate.cs (Delegate): take a location argument.
27291 * driver.cs: Do not call EmitCode if there were problesm in the
27292 Definition of the types, as many Builders wont be there.
27294 * decl.cs (Decl::Decl): Require a location argument.
27296 * cs-tokenizer.cs: Handle properly hex constants that can not fit
27297 into integers, and find the most appropiate integer for it.
27299 * literal.cs: Implement ULongLiteral.
27301 * rootcontext.cs: Provide better information about the location of
27302 failure when CreateType fails.
27304 2001-09-29 Miguel de Icaza <miguel@ximian.com>
27306 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
27309 * expression.cs (Binary::CheckShiftArguments): Add missing type
27311 (Binary::ResolveOperator): Add type to the logical and and logical
27312 or, Bitwise And/Or and Exclusive Or code paths, it was missing
27315 (Binary::DoNumericPromotions): In the case where either argument
27316 is ulong (and most signed types combined with ulong cause an
27317 error) perform implicit integer constant conversions as well.
27319 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27321 * expression.cs (UserImplicitCast): Method should always be
27323 (Invocation::BetterConversion): Simplified test for IntLiteral.
27325 (Expression::ImplicitNumericConversion): Split this routine out.
27326 Put the code that performs implicit constant integer conversions
27329 (Expression::Resolve): Become a wrapper around DoResolve so we can
27330 check eclass and type being set after resolve.
27332 (Invocation::Badness): Remove this dead function
27334 (Binary::ResolveOperator): Do not compute the expensive argumnets
27335 unless we have a union for it.
27337 (Probe::Emit): Is needs to do an isinst and then
27338 compare against null.
27340 (::CanConvert): Added Location argument. If the Location argument
27341 is null (Location.Null), then we do not report errors. This is
27342 used by the `probe' mechanism of the Explicit conversion. We do
27343 not want to generate an error for something that the user
27344 explicitly requested to be casted. But the pipeline for an
27345 explicit cast first tests for potential implicit casts.
27347 So for now, if the Location is null, it means `Probe only' to
27348 avoid adding another argument. Might have to revise this
27351 (ClassCast): New class used to type cast objects into arbitrary
27352 classes (used in Explicit Reference Conversions).
27354 Implement `as' as well.
27356 Reverted all the patches from Ravi below: they were broken:
27358 * The use of `level' as a mechanism to stop recursive
27359 invocations is wrong. That was there just to catch the
27360 bug with a strack trace but not as a way of addressing
27363 To fix the problem we have to *understand* what is going
27364 on and the interactions and come up with a plan, not
27365 just get things going.
27367 * The use of the type conversion cache that I proposed
27368 last night had an open topic: How does this work across
27369 protection domains. A user defined conversion might not
27370 be public in the location where we are applying the
27371 conversion, a different conversion might be selected
27372 (ie, private A->B (better) but public B->A (worse),
27373 inside A, A->B applies, but outside it, B->A will
27376 * On top of that (ie, even if the above is solved),
27377 conversions in a cache need to be abstract. Ie, `To
27378 convert from an Int to a Short use an OpcodeCast', not
27379 `To convert from an Int to a Short use the OpcodeCast on
27380 the variable 5' (which is what this patch was doing).
27382 2001-09-28 Ravi Pratap <ravi@ximian.com>
27384 * expression.cs (Invocation::ConversionExists): Re-write to use
27385 the conversion cache
27387 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
27388 cache all conversions done, not just user-defined ones.
27390 (Invocation::BetterConversion): The real culprit. Use ConversionExists
27391 to determine if a conversion exists instead of acutually trying to
27392 perform the conversion. It's faster too.
27394 (Expression::ConvertExplicit): Modify to use ConversionExists to check
27395 and only then attempt the implicit conversion.
27397 2001-09-28 Ravi Pratap <ravi@ximian.com>
27399 * expression.cs (ConvertImplicit): Use a cache for conversions
27400 already found. Check level of recursion and bail out if necessary.
27402 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27404 * typemanager.cs (string_concat_string_string, string_concat_object_object):
27405 Export standard methods that we expect for string operations.
27407 * statement.cs (Block::UsageWarning): Track usage of variables and
27408 report the errors for not used variables.
27410 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
27413 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27415 * codegen.cs: remove unnneded code
27417 * expression.cs: Removed BuiltinTypeAccess class
27419 Fix the order in which implicit conversions are
27422 The previous fixed dropped support for boxed conversions (adding a
27423 test to the test suite now)
27425 (UserImplicitCast::CanConvert): Remove test for source being null,
27426 that code is broken. We should not feed a null to begin with, if
27427 we do, then we should track the bug where the problem originates
27428 and not try to cover it up here.
27430 Return a resolved expression of type UserImplicitCast on success
27431 rather than true/false. Ravi: this is what I was talking about,
27432 the pattern is to use a static method as a "constructor" for
27435 Also, do not create arguments until the very last minute,
27436 otherwise we always create the arguments even for lookups that
27437 will never be performed.
27439 (UserImplicitCast::Resolve): Eliminate, objects of type
27440 UserImplicitCast are born in a fully resolved state.
27442 * typemanager.cs (InitCoreTypes): Init also value_type
27443 (System.ValueType).
27445 * expression.cs (Cast::Resolve): First resolve the child expression.
27447 (LValue): Add new method AddressOf to be used by
27450 Change the argument of Store to take an EmitContext instead of an
27451 ILGenerator, because things like FieldExpr need to be able to call
27452 their children expression to generate the instance code.
27454 (Expression::Error, Expression::Warning): Sugar functions for
27457 (Expression::MemberLookup): Accept a TypeContainer instead of a
27458 Report as the first argument.
27460 (Expression::ResolvePrimary): Killed. I still want to improve
27461 this as currently the code is just not right.
27463 (Expression::ResolveMemberAccess): Simplify, but it is still
27466 (Unary::Resolve): Catch errors in AddressOf operators.
27468 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
27469 index to a byte for the short-version, or the compiler will choose
27470 the wrong Emit call, which generates the wrong data.
27472 (ParameterReference::Emit, ::Store): same.
27474 (FieldExpr::AddressOf): Implement.
27476 * typemanager.cs: TypeManager: made public variable instead of
27479 * driver.cs: document --fatal.
27481 * report.cs (ErrorMessage, WarningMessage): new names for the old
27482 Error and Warning classes.
27484 * cs-parser.jay (member_access): Turn built-in access to types
27485 into a normal simplename
27487 2001-09-27 Ravi Pratap <ravi@ximian.com>
27489 * expression.cs (Invocation::BetterConversion): Fix to cope
27490 with q being null, since this was introducing a bug.
27492 * expression.cs (ConvertImplicit): Do built-in conversions first.
27494 2001-09-27 Ravi Pratap <ravi@ximian.com>
27496 * expression.cs (UserImplicitCast::Resolve): Fix bug.
27498 2001-09-27 Ravi Pratap <ravi@ximian.com>
27500 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
27501 I had introduced long ago (what's new ?).
27503 * expression.cs (UserImplicitCast::CanConvert): Static method to do
27504 the work of all the checking.
27505 (ConvertImplicit): Call CanConvert and only then create object if necessary.
27506 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
27508 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
27509 that is the right way.
27511 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
27512 overloading resolution. Use everywhere instead of cutting and pasting code.
27514 (Binary::ResolveOperator): Use MakeUnionSet.
27516 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
27517 we have to convert to bool types. Not complete yet.
27519 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27521 * typemanager.cs (TypeManager::CSharpName): support ushort.
27523 * expression.cs (Expression::TryImplicitIntConversion): Attempts
27524 to provide an expression that performsn an implicit constant int
27525 conversion (section 6.1.6).
27526 (Expression::ConvertImplicitRequired): Reworked to include
27527 implicit constant expression conversions.
27529 (Expression::ConvertNumericExplicit): Finished.
27531 (Invocation::Emit): If InstanceExpression is null, then it means
27532 that we perform a call on this.
27534 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27536 * expression.cs (Unary::Emit): Remove some dead code.
27537 (Probe): Implement Resolve and Emit for `is'.
27538 (Expression::ConvertImplicitRequired): Attempt to do constant
27539 expression conversions here. Maybe should be moved to
27540 ConvertImplicit, but I am not sure.
27541 (Expression::ImplicitLongConstantConversionPossible,
27542 Expression::ImplicitIntConstantConversionPossible): New functions
27543 that tell whether is it possible to apply an implicit constant
27544 expression conversion.
27546 (ConvertNumericExplicit): Started work on explicit numeric
27549 * cs-parser.jay: Update operator constants.
27551 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
27552 (Parameters::GetSignature): Hook up VerifyArgs here.
27553 (Parameters::VerifyArgs): Verifies that no two arguments have the
27556 * class.cs (Operator): Update the operator names to reflect the
27557 ones that the spec expects (as we are just stringizing the
27560 * expression.cs (Unary::ResolveOperator): Fix bug: Use
27561 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
27562 previous usage did only work for our methods.
27563 (Expression::ConvertImplicit): Handle decimal implicit numeric
27564 conversions as well.
27565 (Expression::InternalTypeConstructor): Used to invoke constructors
27566 on internal types for default promotions.
27568 (Unary::Emit): Implement special handling for the pre/post
27569 increment/decrement for overloaded operators, as they need to have
27570 the same semantics as the other operators.
27572 (Binary::ResolveOperator): ditto.
27573 (Invocation::ConversionExists): ditto.
27574 (UserImplicitCast::Resolve): ditto.
27576 2001-09-26 Ravi Pratap <ravi@ximian.com>
27578 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
27579 operator, return after emitting body. Regression tests pass again !
27581 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
27582 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
27583 (Invocation::OverloadResolve): Ditto.
27584 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
27586 * everywhere : update calls to the above methods accordingly.
27588 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27590 * assign.cs (Assign): Make it inherit from ExpressionStatement.
27592 * expression.cs (ExpressionStatement): New base class used for
27593 expressions that can appear in statements, so that we can provide
27594 an alternate path to generate expression that do not leave a value
27597 (Expression::Emit, and all the derivatives): We no longer return
27598 whether a value is left on the stack or not. Every expression
27599 after being emitted leaves a single value on the stack.
27601 * codegen.cs (EmitContext::EmitStatementExpression): Use the
27602 facilties of ExpressionStatement if possible.
27604 * cs-parser.jay: Update statement_expression.
27606 2001-09-25 Miguel de Icaza <miguel@ximian.com>
27608 * driver.cs: Change the wording of message
27610 2001-09-25 Ravi Pratap <ravi@ximian.com>
27612 * expression.cs (Binary::ResolveOperator): Had forgottten to set
27613 the type of the expression to the return type of the method if
27614 we have an overloaded operator match ! The regression tests pass again !
27615 (Unary::ResolveOperator): Ditto.
27617 * expression.cs (Invocation::ConversionExists): Correct the member lookup
27618 to find "op_Implicit", not "implicit" ;-)
27619 (UserImplicitCast): New class to take care of user-defined implicit conversions.
27620 (ConvertImplicit, ForceConversion): Take TypeContainer argument
27622 * everywhere : Correct calls to the above accordingly.
27624 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
27625 (ConvertImplicit): Do user-defined conversion if it exists.
27627 2001-09-24 Miguel de Icaza <miguel@ximian.com>
27629 * assign.cs: track location.
27630 (Resolve): Use implicit conversions on assignment.
27632 * literal.cs: Oops. Not good, Emit of short access values should
27633 pass (Bytes) or the wrong argument will be selected.
27635 * expression.cs (Unary::Emit): Emit code for -expr.
27637 (Unary::ResolveOperator): Handle `Substract' for non-constants
27638 (substract from zero from the non-constants).
27639 Deal with Doubles as well.
27641 (Expression::ConvertImplicitRequired): New routine that reports an
27642 error if no implicit conversion exists.
27644 (Invocation::OverloadResolve): Store the converted implicit
27645 expressions if we make them
27647 2001-09-24 Ravi Pratap <ravi@ximian.com>
27649 * class.cs (ConstructorInitializer): Take a Location argument.
27650 (ConstructorBaseInitializer): Same here.
27651 (ConstructorThisInitializer): Same here.
27653 * cs-parser.jay : Update all calls accordingly.
27655 * expression.cs (Unary, Binary, New): Take location argument.
27656 Update accordingly everywhere.
27658 * cs-parser.jay : Update all calls to the above to take a location
27661 * class.cs : Ditto.
27663 2001-09-24 Ravi Pratap <ravi@ximian.com>
27665 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
27666 (Invocation::BetterConversion): Same here
27667 (Invocation::ConversionExists): Ditto.
27669 (Invocation::ConversionExists): Implement.
27671 2001-09-22 Ravi Pratap <ravi@ximian.com>
27673 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
27674 Also take an additional TypeContainer argument.
27676 * All over : Pass in TypeContainer as argument to OverloadResolve.
27678 * typemanager.cs (CSharpName): Update to check for the string type and return
27681 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
27684 2001-09-21 Ravi Pratap <ravi@ximian.com>
27686 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
27687 (Invocation::BetterFunction): Implement.
27688 (Invocation::BetterConversion): Implement.
27689 (Invocation::ConversionExists): Skeleton, no implementation yet.
27691 Okay, things work fine !
27693 2001-09-21 Miguel de Icaza <miguel@ximian.com>
27695 * typemanager.cs: declare and load enum_type, delegate_type and
27698 * expression.cs (Expression::Emit): Now emit returns a value that
27699 tells whether a value is left on the stack or not. This strategy
27700 might be reveted tomorrow with a mechanism that would address
27701 multiple assignments.
27702 (Expression::report118): Utility routine to report mismatches on
27705 (Unary::Report23): Report impossible type/operator combination
27708 (Unary::IsIncrementableNumber): Whether the type can be
27709 incremented or decremented with add.
27710 (Unary::ResolveOperator): Also allow enumerations to be bitwise
27712 (Unary::ResolveOperator): Implement ++, !, ~,
27714 (Invocation::Emit): Deal with new Emit convetion.
27716 * All Expression derivatives: Updated their Emit method to return
27717 whether they leave values on the stack or not.
27719 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
27720 stack for expressions that are statements.
27722 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27724 * expression.cs (LValue): New interface. Must be implemented by
27726 (LocalVariableReference, ParameterReference, FieldExpr): Implement
27729 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
27730 interface for generating code, simplifies the code.
27732 2001-09-20 Ravi Pratap <ravi@ximian.com>
27734 * expression.cs (everywhere): Comment out return statements in ::Resolve
27735 methods to avoid the warnings.
27737 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27739 * driver.cs (parse): Report error 2001 if we can not open the
27742 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
27745 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
27748 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
27749 otherwise nested blocks end up with the same index.
27751 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
27753 * expression.cs: Instead of having FIXMEs in the Resolve
27754 functions, throw exceptions so it is obvious that we are facing a
27757 * cs-parser.jay (invocation_expression): Pass Location information.
27759 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
27760 Use a basename for those routines because .NET does not like paths
27763 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
27766 2001-09-19 Miguel de Icaza <miguel@ximian.com>
27768 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
27769 are loading the correct data types (throws an exception if not).
27770 (TypeManager::InitCoreTypes): Use CoreLookupType
27772 * expression.cs (Unary::ResolveOperator): return the child
27773 expression for expressions which are just +expr.
27774 (Unary::ResolveOperator): Return negative literals for -LITERAL
27775 expressions (otherwise they are Unary {Literal}).
27776 (Invocation::Badness): Take into account `Implicit constant
27777 expression conversions'.
27779 * literal.cs (LongLiteral): Implement long literal class.
27780 (IntLiteral): export the `Value' of the intliteral.
27782 2001-09-19 Ravi Pratap <ravi@ximian.com>
27784 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
27786 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
27787 instead of 'Operator'
27789 * expression.cs (Binary::ResolveOperator): Update accordingly.
27790 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
27793 * cs-parser.jay (unary_expression): Update to use the new names.
27795 * gen-treedump.cs (GetUnary): Same here.
27797 * expression.cs (Unary::Resolve): Implement.
27798 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
27799 operators are found instead of making noise ;-)
27800 (Unary::ResolveOperator): New method to do precisely the same thing which
27801 Binary::ResolveOperator does for Binary expressions.
27802 (Unary.method, .Arguments): Add.
27803 (Unary::OperName): Implement.
27804 (Unary::ForceConversion): Copy and Paste !
27806 * class.cs (Operator::Define): Fix a small bug for the case when we have
27809 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
27810 for the inbuilt operators. Only overloading works for now ;-)
27812 2001-09-18 Miguel de Icaza <miguel@ximian.com>
27814 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
27815 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
27817 * expression.cs (This::Emit): Implement.
27818 (This::Resolve): Implement.
27819 (TypeOf:Resolve): Implement.
27820 (Expression::ResolveSimpleName): Add an implicit this to instance
27822 (MemberAccess::Resolve): Deal with Parameters and Fields.
27823 Bind instance variable to Field expressions.
27824 (FieldExpr::Instance): New field used to track the expression that
27825 represents the object instance.
27826 (FieldExpr::Resolve): Track potential errors from MemberLookup not
27828 (FieldExpr::Emit): Implement.
27830 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
27831 the last instruction contains a return opcode to avoid generating
27832 the last `ret' instruction (this generates correct code, and it is
27833 nice to pass the peverify output).
27835 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
27836 initializer for static and instance variables.
27837 (Constructor::Emit): Allow initializer to be null in the case of
27838 static constructors. Only emit initializer for instance
27841 (TypeContainer::FindMembers): Return a null array if there are no
27844 Also fix the code for the MemberTypes.Method branch, as it was not
27845 scanning that for operators (or tried to access null variables before).
27847 * assign.cs (Assign::Emit): Handle instance and static fields.
27851 * driver.cs: Stop compilation if there are parse errors.
27853 * cs-parser.jay (constructor_declaration): Provide default base
27854 initializer for non-static constructors.
27855 (constructor_declarator): Do not provide a default base
27856 initializers if none was specified.
27857 Catch the fact that constructors should not have parameters.
27859 * class.cs: Do not emit parent class initializers for static
27860 constructors, that should be flagged as an error.
27862 2001-09-18 Ravi Pratap <ravi@ximian.com>
27864 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
27865 Move back code into TypeContainer::Populate.
27867 2001-09-18 Ravi Pratap <ravi@ximian.com>
27869 * class.cs (TypeContainer::AddConstructor): Fix the check to
27870 compare against Name, not Basename.
27871 (Operator::OpType): Change Plus and Minus to Add and Subtract.
27873 * cs-parser.jay : Update accordingly.
27875 * class.cs (TypeContainer::FindMembers): For the case where we are searching
27876 for methods, don't forget to look into the operators too.
27877 (RegisterMethodBuilder): Helper method to take care of this for
27878 methods, constructors and operators.
27879 (Operator::Define): Completely revamp.
27880 (Operator.OperatorMethod, MethodName): New fields.
27881 (TypeContainer::Populate): Move the registering of builders into
27882 RegisterMethodBuilder.
27883 (Operator::Emit): Re-write.
27885 * expression.cs (Binary::Emit): Comment out code path to emit method
27886 invocation stuff for the case when we have a user defined operator. I am
27887 just not able to get it right !
27889 2001-09-17 Miguel de Icaza <miguel@ximian.com>
27891 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
27894 (Expression::MemberLookup): Provide a version that allows to
27895 specify the MemberTypes and BindingFlags.
27897 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
27898 so it was not fetching variable information from outer blocks.
27900 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
27901 Beforefieldinit as it was buggy.
27903 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
27904 that Ravi put here.
27906 * class.cs (Constructor::Emit): Only emit if block is not null.
27907 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
27908 deal with this by semantically definining it as if the user had
27911 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
27912 constructors as we now "emit" them at a higher level.
27914 (TypeContainer::DefineDefaultConstructor): Used to define the
27915 default constructors if none was provided.
27917 (ConstructorInitializer): Add methods Resolve and Emit.
27919 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
27921 2001-09-17 Ravi Pratap <ravi@ximian.com>
27923 * class.cs (TypeContainer::EmitDefaultConstructor): Register
27924 the default constructor builder with our hashtable for methodbuilders
27927 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
27928 and argument_count is 0 in which case we have a match.
27929 (Binary::ResolveOperator): More null checking and miscellaneous coding
27932 2001-09-17 Ravi Pratap <ravi@ximian.com>
27934 * rootcontext.cs (IsNameSpace): Compare against null.
27936 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
27938 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
27939 and Unary::Operator.
27941 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
27944 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
27945 we have overloaded operators.
27946 (Binary::ResolveOperator): Implement the part which does the operator overload
27949 * class.cs (Operator::Emit): Implement.
27950 (TypeContainer::Emit): Emit the operators we have too.
27952 * expression.cs (Binary::Emit): Update to emit the appropriate code for
27953 the case when we have a user-defined operator.
27955 2001-09-17 Miguel de Icaza <miguel@ximian.com>
27957 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
27959 2001-09-16 Ravi Pratap <ravi@ximian.com>
27961 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
27962 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
27963 (Constructor::Emit): Implement.
27964 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
27965 if we have no work to do.
27966 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
27969 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
27970 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
27972 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
27975 2001-09-15 Ravi Pratap <ravi@ximian.com>
27977 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
27979 (Tree::RecordNamespace): Method to do what the name says ;-)
27980 (Tree::Namespaces): Property to get at the namespaces hashtable.
27982 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
27985 * rootcontext.cs (IsNamespace): Fixed it :-)
27987 2001-09-14 Miguel de Icaza <miguel@ximian.com>
27989 * class.cs (TypeContainer::FindMembers): Add support for
27991 (MethodCore): New class that encapsulates both the shared aspects
27992 of a Constructor and a Method.
27993 (Method, Constructor): Factored pieces into MethodCore.
27995 * driver.cs: Added --fatal which makes errors throw exceptions.
27996 Load System assembly as well as part of the standard library.
27998 * report.cs: Allow throwing exceptions on errors for debugging.
28000 * modifiers.cs: Do not use `parent', instead use the real type
28001 container to evaluate permission settings.
28003 * class.cs: Put Ravi's patch back in. He is right, and we will
28004 have to cope with the
28006 2001-09-14 Ravi Pratap <ravi@ximian.com>
28008 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
28009 FamORAssem, not FamANDAssem.
28011 2001-09-14 Miguel de Icaza <miguel@ximian.com>
28013 * driver.cs: Added --parse option that only parses its input files
28016 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
28017 incorrect. IsTopLevel is not used to tell whether an object is
28018 root_types or not (that can be achieved by testing this ==
28019 root_types). But to see if this is a top-level *class* (not
28020 necessarly our "toplevel" container).
28022 2001-09-14 Ravi Pratap <ravi@ximian.com>
28024 * enum.cs (Enum::Define): Modify to call the Lookup method on the
28025 parent instead of a direct call to GetType.
28027 2001-09-14 Ravi Pratap <ravi@ximian.com>
28029 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
28030 Modifiers.TypeAttr. This should just be a call to that method.
28032 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
28033 object so that we can determine if we are top-level or not.
28035 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
28038 * enum.cs (Enum::Define): Ditto.
28040 * modifiers.cs (FieldAttr): Re-write.
28042 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
28043 (TypeContainer::HaveStaticConstructor): New property to provide access
28044 to precisely that info.
28046 * modifiers.cs (MethodAttr): Re-write.
28047 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
28049 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
28050 of top-level types as claimed.
28052 2001-09-13 Miguel de Icaza <miguel@ximian.com>
28054 * expression.cs (MemberLookup): Fruitless attempt to lookup
28055 constructors. Maybe I need to emit default constructors? That
28056 might be it (currently .NET emits this for me automatically).
28057 (Invocation::OverloadResolve): Cope with Arguments == null.
28058 (Invocation::EmitArguments): new function, shared by the new
28059 constructor and us.
28060 (Invocation::Emit): Handle static and instance methods. Emit
28061 proper call instruction for virtual or non-virtual invocations.
28062 (New::Emit): Implement.
28063 (New::Resolve): Implement.
28064 (MemberAccess:Resolve): Implement.
28065 (MethodGroupExpr::InstanceExpression): used conforming to the spec
28066 to track instances.
28067 (FieldExpr::Resolve): Set type.
28069 * support.cs: Handle empty arguments.
28071 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
28072 SimpleLookup): Auxiliary routines to help parse a qualifier
28075 Update qualifier_identifier rule.
28077 * codegen.cs: Removed debugging messages.
28079 * class.cs: Make this a global thing, this acts just as a "key" to
28080 objects that we might have around.
28082 (Populate): Only initialize method_builders_to_methods once.
28084 * expression.cs (PropertyExpr): Initialize type from the
28087 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
28088 Resolve pattern. Attempt to implicitly convert value to boolean.
28091 * expression.cs: Set the type for the int32/int32 argument case.
28092 (Binary::ResolveOperator): Set the return type to boolean for
28093 comparission operators
28095 * typemanager.cs: Remove debugging print code.
28097 (Invocation::Resolve): resolve type.
28099 * class.cs: Allocate a MemberInfo of the correct size, as the code
28100 elsewhere depends on the test to reflect the correct contents.
28102 (Method::) Keep track of parameters, due to System.Reflection holes
28104 (TypeContainer::Populate): Keep track of MethodBuilders to Method
28107 (TypeContainer::FindMembers): Use ArrayList and then copy an array
28108 of the exact size and return that.
28110 (Class::LookupMethodByBuilder): New function that maps
28111 MethodBuilders to its methods. Required to locate the information
28112 on methods because System.Reflection bit us again.
28114 * support.cs: New file, contains an interface ParameterData and
28115 two implementations: ReflectionParameters and InternalParameters
28116 used to access Parameter information. We will need to grow this
28119 * expression.cs (Invocation::GetParameterData): implement a cache
28120 and a wrapper around the ParameterData creation for methods.
28121 (Invocation::OverloadResolve): Use new code.
28123 2001-09-13 Ravi Pratap <ravi@ximian.com>
28125 * class.cs (TypeContainer::EmitField): Remove and move into
28126 (Field::Define): here and modify accordingly.
28127 (Field.FieldBuilder): New member.
28128 (TypeContainer::Populate): Update accordingly.
28129 (TypeContainer::FindMembers): Implement.
28131 2001-09-13 Miguel de Icaza <miguel@ximian.com>
28133 * statement.cs: (VariableInfo::VariableType): New field to be
28134 initialized with the full type once it is resolved.
28136 2001-09-12 Miguel de Icaza <miguel@ximian.com>
28138 * parameter.cs (GetParameterInfo): Use a type cache to compute
28139 things only once, and to reuse this information
28141 * expression.cs (LocalVariableReference::Emit): Implement.
28142 (OpcodeCast::Emit): fix.
28144 (ParameterReference::Resolve): Implement.
28145 (ParameterReference::Emit): Implement.
28147 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
28148 that are expressions need to stay as Expressions.
28150 * typemanager.cs (CSharpName): Returns the C# name of a type if
28153 * expression.cs (Expression::ConvertImplicit): New function that
28154 implements implicit type conversions.
28156 (Expression::ImplicitReferenceConversion): Implements implicit
28157 reference conversions.
28159 (EmptyCast): New type for transparent casts.
28161 (OpcodeCast): New type for casts of types that are performed with
28162 a sequence of bytecodes.
28164 (BoxedCast): New type used for casting value types into reference
28165 types. Emits a box opcode.
28167 (Binary::DoNumericPromotions): Implements numeric promotions of
28168 and computation of the Binary::Type.
28170 (Binary::EmitBranchable): Optimization.
28172 (Binary::Emit): Implement code emission for expressions.
28174 * typemanager.cs (TypeManager): Added two new core types: sbyte
28177 2001-09-12 Ravi Pratap <ravi@ximian.com>
28179 * class.cs (TypeContainer::FindMembers): Method which does exactly
28180 what Type.FindMembers does, only we don't have to use reflection. No
28181 implementation yet.
28183 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
28184 typecontainer objects as we need to get at them.
28185 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
28187 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
28188 typecontainer object.
28190 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
28191 of just a Report object.
28193 2001-09-11 Ravi Pratap <ravi@ximian.com>
28195 * class.cs (Event::Define): Go back to using the prefixes "add_" and
28197 (TypeContainer::Populate): Now define the delegates of the type too.
28198 (TypeContainer.Delegates): Property to access the list of delegates defined
28201 * delegates.cs (Delegate::Define): Implement partially.
28203 * modifiers.cs (TypeAttr): Handle more flags.
28205 2001-09-11 Ravi Pratap <ravi@ximian.com>
28207 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
28209 (Operator::Define): Re-write logic to get types by using the LookupType method
28210 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
28211 (Indexer::Define): Ditto.
28212 (Event::Define): Ditto.
28213 (Property::Define): Ditto.
28215 2001-09-10 Ravi Pratap <ravi@ximian.com>
28217 * class.cs (TypeContainer::Populate): Now define operators too.
28218 (TypeContainer.Operators): New property to access the list of operators
28220 (Operator.OperatorMethodBuilder): New member to hold the method builder
28221 for the operator we are defining.
28222 (Operator::Define): Implement.
28224 2001-09-10 Ravi Pratap <ravi@ximian.com>
28226 * class.cs (Event::Define): Make the prefixes of the accessor methods
28227 addOn_ and removeOn_
28229 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
28230 of the location being passed in too. Ideally, this should go later since all
28231 error reporting should be done through the Report object.
28233 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
28234 (Populate): Iterate thru the indexers we have and define them too.
28235 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
28236 for the get and set accessors.
28237 (Indexer::Define): Implement.
28239 2001-09-09 Miguel de Icaza <miguel@ximian.com>
28241 * expression.cs (Binary::Resolve): Beginning of it. I scratched
28242 my previous implementation, did not work.
28244 * typemanager.cs: Add a couple of missing types (the longs).
28246 * literal.cs: Use TypeManager.bool_type instead of getting it.
28248 * expression.cs (EventExpr): New kind of expressions.
28249 (Expressio::ExprClassFromMemberInfo): finish
28251 2001-09-08 Miguel de Icaza <miguel@ximian.com>
28253 * assign.cs: Emit stores to static fields differently.
28255 2001-09-08 Ravi Pratap <ravi@ximian.com>
28257 * Merge in changes and adjust code to tackle conflicts. Backed out my
28258 code in Assign::Resolve ;-)
28260 2001-09-08 Ravi Pratap <ravi@ximian.com>
28262 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
28263 instead Report.Error and also pass in the location.
28264 (CSharpParser::Lexer): New readonly property to return the reference
28265 to the Tokenizer object.
28266 (declare_local_variables): Use Report.Error with location instead of plain
28270 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
28271 (Operator.CheckBinaryOperator): Ditto.
28273 * cs-parser.jay (operator_declarator): Update accordingly.
28275 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
28276 (CheckBinaryOperator): Same here.
28278 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
28279 on the name without any prefixes of namespace names etc. This is because we
28280 already might have something already fully qualified like
28281 'System.Console.WriteLine'
28283 * assign.cs (Resolve): Begin implementation. Stuck ;-)
28285 2001-09-07 Ravi Pratap <ravi@ximian.com>
28287 * cs-tokenizer.cs (location): Return a string which also contains
28290 * expression.cs (ElementAccess): New class for expressions of the
28291 type 'element access.'
28292 (BaseAccess): New class for expressions of the type 'base access.'
28293 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
28296 * cs-parser.jay (element_access): Implement action.
28297 (base_access): Implement actions.
28298 (checked_expression, unchecked_expression): Implement.
28300 * cs-parser.jay (local_variable_type): Correct and implement.
28301 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
28303 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
28305 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
28306 name and the specifiers.
28308 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
28310 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
28311 making them all public ;-)
28313 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
28316 2001-09-07 Miguel de Icaza <miguel@ximian.com>
28318 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
28320 (FieldExpr, PropertyExprs): New resolved expressions.
28321 (SimpleName::MemberStaticCheck): Perform static checks for access
28322 to non-static fields on static methods. Maybe this should be
28323 generalized for MemberAccesses.
28324 (SimpleName::ResolveSimpleName): More work on simple name
28327 * cs-parser.jay (primary_expression/qualified_identifier): track
28328 the parameter index.
28330 * codegen.cs (CodeGen::Save): Catch save exception, report error.
28331 (EmitContext::EmitBoolExpression): Chain to expression generation
28332 instead of temporary hack.
28333 (::EmitStatementExpression): Put generic expression code generation.
28335 * assign.cs (Assign::Emit): Implement variable assignments to
28336 local variables, parameters and fields.
28338 2001-09-06 Miguel de Icaza <miguel@ximian.com>
28340 * statement.cs (Block::GetVariableInfo): New method, returns the
28341 VariableInfo for a variable name in a block.
28342 (Block::GetVariableType): Implement in terms of GetVariableInfo
28344 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
28345 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
28347 2001-09-06 Ravi Pratap <ravi@ximian.com>
28349 * cs-parser.jay (operator_declaration): Continue on my quest : update
28350 to take attributes argument.
28351 (event_declaration): Ditto.
28352 (enum_declaration): Ditto.
28353 (indexer_declaration): Ditto.
28355 * class.cs (Operator::Operator): Update constructor accordingly.
28356 (Event::Event): Ditto.
28358 * delegate.cs (Delegate::Delegate): Same here.
28360 * enum.cs (Enum::Enum): Same here.
28362 2001-09-05 Ravi Pratap <ravi@ximian.com>
28364 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
28366 * ../tests/cs0658.cs : New file to demonstrate error 0658.
28368 * attribute.cs (Attributes): New class to encapsulate all attributes which were
28369 being passed around as an arraylist.
28370 (Attributes::AddAttribute): Method to add attribute sections.
28372 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
28373 (struct_declaration): Update accordingly.
28374 (constant_declaration): Update.
28375 (field_declaration): Update.
28376 (method_header): Update.
28377 (fixed_parameter): Update.
28378 (parameter_array): Ditto.
28379 (property_declaration): Ditto.
28380 (destructor_declaration): Ditto.
28382 * class.cs (Struct::Struct): Update constructors accordingly.
28383 (Class::Class): Ditto.
28384 (Field::Field): Ditto.
28385 (Method::Method): Ditto.
28386 (Property::Property): Ditto.
28387 (TypeContainer::OptAttribute): update property's return type.
28389 * interface.cs (Interface.opt_attributes): New member.
28390 (Interface::Interface): Update to take the extra Attributes argument.
28392 * parameter.cs (Parameter::Parameter): Ditto.
28394 * constant.cs (Constant::Constant): Ditto.
28396 * interface.cs (InterfaceMemberBase): New OptAttributes field.
28397 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
28398 the attributes as a parameter.
28399 (InterfaceProperty): Update constructor call.
28400 (InterfaceEvent): Ditto.
28401 (InterfaceMethod): Ditto.
28402 (InterfaceIndexer): Ditto.
28404 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
28405 pass the attributes too.
28406 (interface_event_declaration): Ditto.
28407 (interface_property_declaration): Ditto.
28408 (interface_method_declaration): Ditto.
28409 (interface_declaration): Ditto.
28411 2001-09-05 Miguel de Icaza <miguel@ximian.com>
28413 * class.cs (Method::Define): Track the "static Main" definition to
28414 create an entry point.
28416 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
28417 EntryPoint if we find it.
28419 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
28420 (EmitContext::ig): Make this variable public.
28422 * driver.cs: Make the default output file be the first file name
28423 with the .exe extension.
28425 Detect empty compilations
28427 Handle various kinds of output targets. Handle --target and
28428 rename -t to --dumper.
28430 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
28431 methods inherited from Expression return now an Expression. This
28432 will is used during the tree rewriting as we resolve them during
28435 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
28436 the spec. Missing entirely is the information about
28437 accessability of elements of it.
28439 (Expression::ExprClassFromMemberInfo): New constructor for
28440 Expressions that creates a fully initialized Expression based on
28441 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
28444 (Invocation::Resolve): Begin implementing resolution of invocations.
28446 * literal.cs (StringLiteral): Implement Emit.
28448 2001-09-05 Ravi Pratap <ravi@ximian.com>
28450 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
28453 2001-09-04 Ravi Pratap <ravi@ximian.com>
28455 * cs-parser.jay (attribute_arguments): Implement actions.
28456 (attribute): Fix bug in production. Implement action.
28457 (attribute_list): Implement.
28458 (attribute_target): Implement.
28459 (attribute_target_specifier, opt_target_specifier): Implement
28460 (CheckAttributeTarget): New method to check if the attribute target
28462 (attribute_section): Implement.
28463 (opt_attributes): Implement.
28465 * attribute.cs : New file to handle attributes.
28466 (Attribute): Class to hold attribute info.
28468 * cs-parser.jay (opt_attribute_target_specifier): Remove production
28469 (attribute_section): Modify production to use 2 different rules to
28470 achieve the same thing. 1 s/r conflict down !
28471 Clean out commented, useless, non-reducing dimension_separator rules.
28473 * class.cs (TypeContainer.attributes): New member to hold list
28474 of attributes for a type.
28475 (Struct::Struct): Modify to take one more argument, the attribute list.
28476 (Class::Class): Ditto.
28477 (Field::Field): Ditto.
28478 (Method::Method): Ditto.
28479 (Property::Property): Ditto.
28481 * cs-parser.jay (struct_declaration): Update constructor call to
28482 pass in the attributes too.
28483 (class_declaration): Ditto.
28484 (constant_declaration): Ditto.
28485 (field_declaration): Ditto.
28486 (method_header): Ditto.
28487 (fixed_parameter): Ditto.
28488 (parameter_array): Ditto.
28489 (property_declaration): Ditto.
28491 * constant.cs (Constant::Constant): Update constructor similarly.
28492 Use System.Collections.
28494 * parameter.cs (Parameter::Parameter): Update as above.
28496 2001-09-02 Ravi Pratap <ravi@ximian.com>
28498 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
28499 (TypeContainer.delegates): New member to hold list of delegates.
28501 * cs-parser.jay (delegate_declaration): Implement the action correctly
28502 this time as I seem to be on crack ;-)
28504 2001-09-02 Miguel de Icaza <miguel@ximian.com>
28506 * rootcontext.cs (RootContext::IsNamespace): new function, used to
28507 tell whether an identifier represents a namespace.
28509 * expression.cs (NamespaceExpr): A namespace expression, used only
28510 temporarly during expression resolution.
28511 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
28512 utility functions to resolve names on expressions.
28514 2001-09-01 Miguel de Icaza <miguel@ximian.com>
28516 * codegen.cs: Add hook for StatementExpressions.
28518 * class.cs: Fix inverted test for static flag in methods.
28520 2001-09-02 Ravi Pratap <ravi@ximian.com>
28522 * class.cs (Operator::CheckUnaryOperator): Correct error number used
28523 to make it coincide with MS' number.
28524 (Operator::CheckBinaryOperator): Ditto.
28526 * ../errors/errors.txt : Remove error numbers added earlier.
28528 * ../errors/cs1019.cs : Test case for error # 1019
28530 * ../errros/cs1020.cs : Test case for error # 1020
28532 * cs-parser.jay : Clean out commented cruft.
28533 (dimension_separators, dimension_separator): Comment out. Ostensibly not
28534 used anywhere - non-reducing rule.
28535 (namespace_declarations): Non-reducing rule - comment out.
28537 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
28538 with TypeContainer::AddEnum.
28540 * delegate.cs : New file for delegate handling classes.
28541 (Delegate): Class for declaring delegates.
28543 * makefile : Update.
28545 * cs-parser.jay (delegate_declaration): Implement.
28547 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
28549 * class.cs (Event::Define): Implement.
28550 (Event.EventBuilder): New member.
28552 * class.cs (TypeContainer::Populate): Update to define all enums and events
28554 (Events): New property for the events arraylist we hold. Shouldn't we move to using
28555 readonly fields for all these cases ?
28557 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28559 * class.cs (Property): Revamp to use the convention of making fields readonly.
28560 Accordingly modify code elsewhere.
28562 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
28563 the Define method of the Property class.
28565 * class.cs : Clean up applied patch and update references to variables etc. Fix
28567 (TypeContainer::Populate): Update to define all the properties we have. Also
28568 define all enumerations.
28570 * enum.cs (Define): Implement.
28572 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28574 * cs-parser.jay (overloadable_operator): The semantic value is an
28575 enum of the Operator class.
28576 (operator_declarator): Implement actions.
28577 (operator_declaration): Implement.
28579 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
28580 validity of definitions.
28581 (Operator::CheckBinaryOperator): Static method to check for binary operators
28582 (TypeContainer::AddOperator): New method to add an operator to a type.
28584 * cs-parser.jay (indexer_declaration): Added line to actually call the
28585 AddIndexer method so it gets added ;-)
28587 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
28588 already taken care of by the MS compiler ?
28590 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28592 * class.cs (Operator): New class for operator declarations.
28593 (Operator::OpType): Enum for the various operators.
28595 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28597 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
28598 ostensibly handle this in semantic analysis.
28600 * cs-parser.jay (general_catch_clause): Comment out
28601 (specific_catch_clauses, specific_catch_clause): Ditto.
28602 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
28603 (catch_args, opt_catch_args): New productions.
28604 (catch_clause): Rewrite to use the new productions above
28605 (catch_clauses): Modify accordingly.
28606 (opt_catch_clauses): New production to use in try_statement
28607 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
28608 and re-write the code in the actions to extract the specific and
28609 general catch clauses by being a little smart ;-)
28611 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
28612 Hooray, try and catch statements parse fine !
28614 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28616 * statement.cs (Block::GetVariableType): Fix logic to extract the type
28617 string from the hashtable of variables.
28619 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
28620 I end up making that mistake ;-)
28621 (catch_clauses): Fixed gross error which made Key and Value of the
28622 DictionaryEntry the same : $1 !!
28624 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28626 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
28628 * cs-parser.jay (event_declaration): Correct to remove the semicolon
28629 when the add and remove accessors are specified.
28631 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28633 * cs-parser.jay (IndexerDeclaration): New helper class to hold
28634 information about indexer_declarator.
28635 (indexer_declarator): Implement actions.
28636 (parsing_indexer): New local boolean used to keep track of whether
28637 we are parsing indexers or properties. This is necessary because
28638 implicit_parameters come into picture even for the get accessor in the
28639 case of an indexer.
28640 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
28642 * class.cs (Indexer): New class for indexer declarations.
28643 (TypeContainer::AddIndexer): New method to add an indexer to a type.
28644 (TypeContainer::indexers): New member to hold list of indexers for the
28647 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28649 * cs-parser.jay (add_accessor_declaration): Implement action.
28650 (remove_accessor_declaration): Implement action.
28651 (event_accessors_declaration): Implement
28652 (variable_declarators): swap statements for first rule - trivial.
28654 * class.cs (Event): New class to hold information about event
28656 (TypeContainer::AddEvent): New method to add an event to a type
28657 (TypeContainer::events): New member to hold list of events.
28659 * cs-parser.jay (event_declaration): Implement actions.
28661 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28663 * cs-parser.jay (dim_separators): Implement. Make it a string
28664 concatenating all the commas together, just as they appear.
28665 (opt_dim_separators): Modify accordingly
28666 (rank_specifiers): Update accordingly. Basically do the same
28667 thing - instead, collect the brackets here.
28668 (opt_rank_sepcifiers): Modify accordingly.
28669 (array_type): Modify to actually return the complete type string
28670 instead of ignoring the rank_specifiers.
28671 (expression_list): Implement to collect the expressions
28672 (variable_initializer): Implement. We make it a list of expressions
28673 essentially so that we can handle the array_initializer case neatly too.
28674 (variable_initializer_list): Implement.
28675 (array_initializer): Make it a list of variable_initializers
28676 (opt_array_initializer): Modify accordingly.
28678 * expression.cs (New::NType): Add enumeration to help us
28679 keep track of whether we have an object/delegate creation
28680 or an array creation.
28681 (New:NewType, New::Rank, New::Indices, New::Initializers): New
28682 members to hold data about array creation.
28683 (New:New): Modify to update NewType
28684 (New:New): New Overloaded contructor for the array creation
28687 * cs-parser.jay (array_creation_expression): Implement to call
28688 the overloaded New constructor.
28690 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
28692 * class.cs (TypeContainer::Constructors): Return member
28693 constructors instead of returning null.
28695 2001-08-26 Miguel de Icaza <miguel@ximian.com>
28697 * typemanager.cs (InitCoreTypes): Initialize the various core
28698 types after we have populated the type manager with the user
28699 defined types (this distinction will be important later while
28700 compiling corlib.dll)
28702 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
28703 on Expression Classification. Now all expressions have a method
28704 `Resolve' and a method `Emit'.
28706 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
28707 generation from working. Also add some temporary debugging
28710 2001-08-24 Miguel de Icaza <miguel@ximian.com>
28712 * codegen.cs: Lots of code generation pieces. This is only the
28713 beginning, will continue tomorrow with more touches of polish. We
28714 handle the fundamentals of if, while, do, for, return. Others are
28715 trickier and I need to start working on invocations soon.
28717 * gen-treedump.cs: Bug fix, use s.Increment here instead of
28720 * codegen.cs (EmitContext): New struct, used during code
28721 emission to keep a context. Most of the code generation will be
28724 * cs-parser.jay: Add embedded blocks to the list of statements of
28725 this block. So code generation proceeds in a top down fashion.
28727 2001-08-23 Miguel de Icaza <miguel@ximian.com>
28729 * statement.cs: Add support for multiple child blocks.
28731 2001-08-22 Miguel de Icaza <miguel@ximian.com>
28733 * codegen.cs (EmitCode): New function, will emit the code for a
28734 Block of code given a TypeContainer and its ILGenerator.
28736 * statement.cs (Block): Standard public readonly optimization.
28737 (Block::Block constructors): Link children.
28738 (Block::Child): Child Linker.
28739 (Block::EmitVariables): Emits IL variable declarations.
28741 * class.cs: Drop support for MethodGroups here, delay until
28743 (Method::): Applied the same simplification that I did before, and
28744 move from Properties to public readonly fields.
28745 (Method::ParameterTypes): Returns the parameter types for the
28746 function, and implements a cache that will be useful later when I
28747 do error checking and the semantic analysis on the methods is
28749 (Constructor::GetCallingConvention): Renamed from CallingConvetion
28750 and made a method, optional argument tells whether this is a class
28751 or a structure to apply the `has-this' bit.
28752 (Method::GetCallingConvention): Implement, returns the calling
28754 (Method::Define): Defines the type, a second pass is performed
28755 later to populate the methods.
28757 (Constructor::ParameterTypes): implement a cache similar to the
28758 one on Method::ParameterTypes, useful later when we do semantic
28761 (TypeContainer::EmitMethod): New method. Emits methods.
28763 * expression.cs: Removed MethodGroup class from here.
28765 * parameter.cs (Parameters::GetCallingConvention): new method.
28767 2001-08-21 Miguel de Icaza <miguel@ximian.com>
28769 * class.cs (TypeContainer::Populate): Drop RootContext from the
28772 (Constructor::CallingConvention): Returns the calling convention.
28773 (Constructor::ParameterTypes): Returns the constructor parameter
28776 (TypeContainer::AddConstructor): Keep track of default constructor
28777 and the default static constructor.
28779 (Constructor::) Another class that starts using `public readonly'
28780 instead of properties.
28782 (Constructor::IsDefault): Whether this is a default constructor.
28784 (Field::) use readonly public fields instead of properties also.
28786 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
28787 track of static constructors; If none is used, turn on
28788 BeforeFieldInit in the TypeAttributes.
28790 * cs-parser.jay (opt_argument_list): now the return can be null
28791 for the cases where there are no arguments.
28793 (constructor_declarator): If there is no implicit `base' or
28794 `this', then invoke the default parent constructor.
28796 * modifiers.cs (MethodAttr): New static function maps a set of
28797 modifiers flags into a MethodAttributes enum
28798 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
28799 MethodAttr, TypeAttr to represent the various mappings where the
28800 modifiers are used.
28801 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
28803 2001-08-19 Miguel de Icaza <miguel@ximian.com>
28805 * parameter.cs (GetParameterInfo): Fix bug where there would be no
28808 * interface.cs (PopulateIndexer): Implemented the code generator
28809 for interface indexers.
28811 2001-08-17 Miguel de Icaza <miguel@ximian.com>
28813 * interface.cs (InterfaceMemberBase): Now we track the new status
28816 (PopulateProperty): Implement property population. Woohoo! Got
28817 Methods and Properties going today.
28819 Removed all the properties for interfaces, and replaced them with
28820 `public readonly' fields.
28822 2001-08-16 Miguel de Icaza <miguel@ximian.com>
28824 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
28825 initialize their hashtables/arraylists only when they are needed
28826 instead of doing this always.
28828 * parameter.cs: Handle refs and out parameters.
28830 * cs-parser.jay: Use an ArrayList to construct the arguments
28831 instead of the ParameterCollection, and then cast that to a
28834 * parameter.cs: Drop the use of ParameterCollection and use
28835 instead arrays of Parameters.
28837 (GetParameterInfo): Use the Type, not the Name when resolving
28840 2001-08-13 Miguel de Icaza <miguel@ximian.com>
28842 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
28843 and instead use public readonly fields.
28845 * class.cs: Put back walking code for type containers.
28847 2001-08-11 Miguel de Icaza <miguel@ximian.com>
28849 * class.cs (MakeConstant): Code to define constants.
28851 * rootcontext.cs (LookupType): New function. Used to locate types
28854 2001-08-08 Miguel de Icaza <miguel@ximian.com>
28856 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
28857 this System.Reflection code is. Kudos to Microsoft
28859 * typemanager.cs: Implement a type cache and avoid loading all
28860 types at boot time. Wrap in LookupType the internals. This made
28861 the compiler so much faster. Wow. I rule!
28863 * driver.cs: Make sure we always load mscorlib first (for
28864 debugging purposes, nothing really important).
28866 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
28867 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
28869 * rootcontext.cs: Lookup types on their namespace; Lookup types
28870 on namespaces that have been imported using the `using' keyword.
28872 * class.cs (TypeContainer::TypeAttr): Virtualize.
28873 (Class::TypeAttr): Return attributes suitable for this bad boy.
28874 (Struct::TypeAttr): ditto.
28875 Handle nested classes.
28876 (TypeContainer::) Remove all the type visiting code, it is now
28877 replaced with the rootcontext.cs code
28879 * rootcontext.cs (GetClassBases): Added support for structs.
28881 2001-08-06 Miguel de Icaza <miguel@ximian.com>
28883 * interface.cs, statement.cs, class.cs, parameter.cs,
28884 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
28885 Drop use of TypeRefs, and use strings instead.
28887 2001-08-04 Miguel de Icaza <miguel@ximian.com>
28891 * class.cs (Struct::Struct): set the SEALED flags after
28892 checking the modifiers.
28893 (TypeContainer::TypeAttr): new property, returns the
28894 TypeAttributes for a class.
28896 * cs-parser.jay (type_list): Oops, list production was creating a
28897 new list of base types.
28899 * rootcontext.cs (StdLib): New property.
28900 (GetInterfaceTypeByName): returns an interface by type name, and
28901 encapsulates error handling here.
28902 (GetInterfaces): simplified.
28903 (ResolveTree): Encapsulated all the tree resolution here.
28904 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
28907 * driver.cs: Add support for --nostdlib, to avoid loading the
28908 default assemblies.
28909 (Main): Do not put tree resolution here.
28911 * rootcontext.cs: Beginning of the class resolution.
28913 2001-08-03 Miguel de Icaza <miguel@ximian.com>
28915 * rootcontext.cs: Provide better error reporting.
28917 * cs-parser.jay (interface_base): set our $$ to be interfaces.
28919 * rootcontext.cs (CreateInterface): Handle the case where there
28920 are no parent interfaces.
28922 (CloseTypes): Routine to flush types at the end.
28923 (CreateInterface): Track types.
28924 (GetInterfaces): Returns an array of Types from the list of
28925 defined interfaces.
28927 * typemanager.c (AddUserType): Mechanism to track user types (puts
28928 the type on the global type hash, and allows us to close it at the
28931 2001-08-02 Miguel de Icaza <miguel@ximian.com>
28933 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
28934 RecordInterface instead.
28936 * cs-parser.jay: Updated to reflect changes above.
28938 * decl.cs (Definition): Keep track of the TypeBuilder type that
28939 represents this type here. Not sure we will use it in the long
28940 run, but wont hurt for now.
28942 * driver.cs: Smaller changes to accomodate the new code.
28944 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
28947 * rootcontext.cs (CreateInterface): New method, used to create
28948 the System.TypeBuilder type for interfaces.
28949 (ResolveInterfaces): new entry point to resolve the interface
28951 (CodeGen): Property, used to keep track of the code generator.
28953 2001-07-26 Miguel de Icaza <miguel@ximian.com>
28955 * cs-parser.jay: Add a second production for delegate_declaration
28958 (enum_body): Put an opt_comma here instead of putting it on
28959 enum_body or enum_member_declarations so we can handle trailing
28960 commas on enumeration members. Gets rid of a shift/reduce.
28962 (type_list): Need a COMMA in the middle.
28964 (indexer_declaration): Tell tokenizer to recognize get/set
28966 * Remove old targets.
28968 * Re-add the parser target.
28970 2001-07-13 Simon Cozens <simon@simon-cozens.org>
28972 * cs-parser.jay: Add precendence rules for a number of operators
28973 ot reduce the number of shift/reduce conflicts in the grammar.
28975 2001-07-17 Miguel de Icaza <miguel@ximian.com>
28977 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
28980 Get rid of old crufty code.
28982 * rootcontext.cs: Use this to keep track of the parsed
28983 representation and the defined types available to the program.
28985 * gen-treedump.cs: adjust for new convention.
28987 * type.cs: Split out the type manager, and the assembly builder
28990 * typemanager.cs: the type manager will live here now.
28992 * cil-codegen.cs: And the code generator here.
28994 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
28996 * makefile: Fixed up for easy making.
28998 2001-07-13 Simon Cozens <simon@simon-cozens.org>
29000 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
29003 (unary_expression): Expand pre_increment_expression and
29004 post_decrement_expression to reduce a shift/reduce.
29006 2001-07-11 Simon Cozens
29008 * cs-tokenizer.cs: Hex numbers should begin with a 0.
29010 Improve allow_keyword_as_indent name.
29012 2001-06-19 Miguel de Icaza <miguel@ximian.com>
29014 * Adjustments for Beta2.
29016 2001-06-13 Miguel de Icaza <miguel@ximian.com>
29018 * decl.cs: Added `Define' abstract method.
29019 (InTransit): new property, used to catch recursive definitions.
29021 * interface.cs: Implement `Define'.
29023 * modifiers.cs: Map Modifiers.constants to
29024 System.Reflection.TypeAttribute flags.
29026 * class.cs: Keep track of types and user-defined types.
29027 (BuilderInit): New method for creating an assembly
29028 (ResolveType): New function to launch the resolution process, only
29029 used by interfaces for now.
29031 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
29032 that are inserted into the name space.
29034 2001-06-08 Miguel de Icaza <miguel@ximian.com>
29036 * ARGH. I have screwed up my tree so many times due to the use of
29037 rsync rather than using CVS. Going to fix this at once.
29039 * driver.cs: Objetify driver. Load assemblies, use assemblies to
29042 2001-06-07 Miguel de Icaza <miguel@ximian.com>
29044 * Experiment successful: Use System.Type rather that our own
29047 2001-05-25 Miguel de Icaza <miguel@ximian.com>
29049 * cs-parser.jay: Removed nsAliases from here.
29051 Use new namespaces, handle `using XXX;'
29053 * namespace.cs: Reimplemented namespace handling, use a recursive
29054 definition of the class. Now we can keep track of using clauses
29055 and catch invalid using clauses.
29057 2001-05-24 Miguel de Icaza <miguel@ximian.com>
29059 * gen-treedump.cs: Adapted for all the renaming.
29061 * expression.cs (Expression): this class now has a Type property
29062 which returns an expression Type.
29064 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
29065 `Type', as this has a different meaning now in the base
29067 2001-05-22 Miguel de Icaza <miguel@ximian.com>
29069 * interface.cs, class.cs: Removed from all the sources the
29070 references to signature computation, as we can not do method
29071 signature computation during the parsing time, as we are not
29072 trying to solve at that point distinguishing:
29076 void a (NS.Blah x) {}
29079 Which depending on the context might be valid or not, as we do not
29080 know if Blah is the same thing as NS.Blah at that point.
29082 * Redid everything so the code uses TypeRefs now instead of
29083 Types. TypeRefs are just temporary type placeholders, that need
29084 to be resolved. They initially have a pointer to a string and the
29085 current scope in which they are used. This is used later by the
29086 compiler to resolve the reference to an actual Type.
29088 * DeclSpace is no longer a CIR.Type, and neither are
29089 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
29090 are all DeclSpaces, but no Types.
29092 * type.cs (TypeRefManager): This implements the TypeRef manager,
29093 which keeps track of all the types that need to be resolved after
29094 the parsing has finished.
29096 2001-05-13 Miguel de Icaza <miguel@ximian.com>
29098 * ARGH. We are going to have to store `foreach' as a class rather
29099 than resolving it, as we need to verify error 1579 after name
29100 resolution. *OR* we could keep a flag that says `This request to
29101 IEnumerator comes from a foreach statement' which we can then use
29102 to generate the error.
29104 2001-05-10 Miguel de Icaza <miguel@ximian.com>
29106 * class.cs (TypeContainer.AddMethod): we now add methods to the
29107 MethodGroup instead of the method hashtable.
29109 * expression.cs: Add MethodGroup abstraction, which gets us one
29110 step closer to the specification in the way we handle method
29113 * cs-parser.jay (primary_expression): qualified_identifier now
29114 tried to match up an identifier to a local variable reference or
29115 to a parameter reference.
29117 current_local_parameters is now a parser global variable that
29118 points to the current parameters for the block, used during name
29121 (property_declaration): Now creates an implicit `value' argument to
29124 2001-05-09 Miguel de Icaza <miguel@ximian.com>
29126 * parameter.cs: Do not use `param' arguments as part of the
29127 signature, per the spec.
29129 2001-05-08 Miguel de Icaza <miguel@ximian.com>
29131 * decl.cs: Base class for classes, structs and interfaces. This
29132 is the "Declaration Space"
29134 * cs-parser.jay: Use CheckDef for checking declaration errors
29135 instead of having one on each function.
29137 * class.cs: Factor out some code for handling error handling in
29138 accordance to the "Declarations" section in the "Basic Concepts"
29139 chapter in the ECMA C# spec.
29141 * interface.cs: Make all interface member classes derive from
29142 InterfaceMemberBase.
29144 2001-05-07 Miguel de Icaza <miguel@ximian.com>
29146 * Many things: all interfaces are parsed and generated in
29147 gen-treedump. Support for member variables, constructors,
29148 destructors, properties, constants is there.
29150 Beginning of the IL backend, but very little done, just there for
29153 2001-04-29 Miguel de Icaza <miguel@ximian.com>
29155 * cs-parser.jay: Fix labeled statement.
29157 * cs-tokenizer.cs (escape): Escape " and ' always.
29158 ref_line, ref_name: keep track of the line/filename as instructed
29159 by #line by the compiler.
29162 2001-04-27 Miguel de Icaza <miguel@ximian.com>
29164 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
29165 to match the values in System.CodeDOM.
29167 Divid renamed to Divide.
29169 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
29171 (Statements.set): remove.
29173 * System.CodeDOM/CodeCatchClause.cs: always have a valid
29176 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
29177 falseStatements always have valid values.
29179 * cs-parser.jay: Use System.CodeDOM now.