1 2010-06-30 Marek Safar <marek.safar@gmail.com>
3 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs,
4 delegate.cs, cs-parser.jay, visit.cs: Use MemberAccess to resolve
5 base access expression, it has all bits done correctly.
7 2010-06-30 Marek Safar <marek.safar@gmail.com>
9 * support.cs: Removed unused code.
11 * ecore.cs: Don't use memberlookup for operators.
13 2010-06-30 Marek Safar <marek.safar@gmail.com>
15 * typemanager.cs, membercache.cs, convert.cs, expression.cs,
16 ecore.cs: Replace remaining MethodLookup with correct user operator
17 lookup (to do correct deep lookup). Clean up most of outstanding
18 quirks in binary operator overload resolution.
20 2010-06-29 Marek Safar <marek.safar@gmail.com>
22 * import.cs: Operators must have between 1 and 2 parameters.
24 * method.cs: Switch destructor to direct membercache lookup
26 2010-06-29 Marek Safar <marek.safar@gmail.com>
28 * driver.cs, expression.cs: Use Membercache for StringConcat when
29 it got all what is needed.
31 2010-06-29 Marek Safar <marek.safar@gmail.com>
33 * membercache.cs, expression.cs, statement.cs, doc.cs, ecore.cs:
34 Changed FindMembers to allocate a new list only when a filter is
35 used. Saves decent chunk of memory and should save even more in the
36 future when the filter is not used that often.
38 2010-06-28 Marek Safar <marek.safar@gmail.com>
40 * field.cs, property.cs, assign.cs, const.cs, expression.cs,
41 ecore.cs, class.cs, cs-parser.jay, enum.cs: Don't use intermediate
42 structure for simple type fields (saves memory and makes few things
43 simpler). Clean up some hacks mostly for events.
45 2010-06-25 Marek Safar <marek.safar@gmail.com>
47 * statement.cs, cs-parser.jay: Don't create expensive block for
50 2010-06-24 Marek Safar <marek.safar@gmail.com>
52 * statement.cs, report.cs: Rethrow internal error when reporting is
55 * ecore.cs: Check for identical name only when simple name is set.
58 2010-06-24 Marek Safar <marek.safar@gmail.com>
61 * generic.cs, expression.cs, ecore.cs: Added a new type expression
62 for open generic type to pass unbound type arguments to typeof
65 2010-06-24 Marek Safar <marek.safar@gmail.com>
67 * statement.cs: Foreach collection implementation refactoring to
68 search for GetEnumerator more preciselly. Fixes #431453 and more
71 * linq.cs, decl.cs, ecore.cs, delegate.cs: Update methodgroup api.
73 2010-06-23 Marek Safar <marek.safar@gmail.com>
75 * cs-parser.jay: Track more locations.
77 2010-06-22 Marek Safar <marek.safar@gmail.com>
79 * cs-tokenizer.cs, location.cs, cs-parser.jay: Track more locations.
81 2010-06-18 Marek Safar <marek.safar@gmail.com>
83 * cs-tokenizer.cs, anonymous.cs, expression.cs, statement.cs,
84 support.cs, location.cs, cs-parser.jay: Some work on full ast mode.
86 2010-06-18 Marek Safar <marek.safar@gmail.com>
88 * convert.cs, typespec.cs, method.cs: Fixed few more dynamic
91 2010-06-18 Marek Safar <marek.safar@gmail.com>
93 * typemanager.cs, namespace.cs: Report more predefined types and
94 imported types collision types as a warning.
95 Fixes #537414, #601157
97 2010-06-18 Marek Safar <marek.safar@gmail.com>
99 * generic.cs: Overrides base method constraint can use method type
102 * import.cs: Removed redundant cache.
104 2010-06-17 Marek Safar <marek.safar@gmail.com>
106 * generic.cs: Propagate type only inflate downwards.
108 2010-06-17 Marek Safar <marek.safar@gmail.com>
110 A fix for bug #614955
111 * method.cs: Do not reject binary dynamic operators.
113 2010-06-17 Marek Safar <marek.safar@gmail.com>
115 * typespec.cs: Internal types have no generic parameters.
118 2010-06-17 Marek Safar <marek.safar@gmail.com>
120 A fix for bug #614955
121 * cs-parser.jay: Correctly set expression mode for default parameter
124 2010-06-17 Marek Safar <marek.safar@gmail.com>
126 A fix for bug #615023
127 * ecore.cs: Resolve dynamic namespace and keyword collision in the
128 favour of the keyword.
130 2010-06-17 Marek Safar <marek.safar@gmail.com>
132 A fix for bug #614917
133 * convert.cs: Allow more undocumented 0 like values to enum type
136 2010-06-17 Marek Safar <marek.safar@gmail.com>
138 * generic.cs, method.cs: Inflate copied type parameters from base
139 class or explicit interfaces.
141 * convert.cs: Fixed conversion between two type parameters.
144 2010-06-16 Marek Safar <marek.safar@gmail.com>
146 * membercache.cs, convert.cs: Correctly resize an array used by
149 2010-06-15 Marek Safar <marek.safar@gmail.com>
151 A fix for bug #599601
152 * dynamic.cs, ecore.cs: A new flag for dynamic resolver to ignore
153 generated member access left expression.
155 2010-06-16 Marek Safar <marek.safar@gmail.com>
157 * expression.cs: Dispatch dynamic invocation solely on left
160 2010-06-16 Marek Safar <marek.safar@gmail.com>
162 * expression.cs, statement.cs: Always persist explicit cast
163 semantic at expression level.
165 2010-06-15 Marek Safar <marek.safar@gmail.com>
167 * expression.cs, attribute.cs: Enable generic type parameters
170 2010-06-15 Marek Safar <marek.safar@gmail.com>
172 A fix for bug #612146
173 * generic.cs: Don't use fixed array for inflated type parameter
174 interface constraints.
176 2010-06-15 Marek Safar <marek.safar@gmail.com>
178 * typespec.cs: ElementTypeSpec has to use its own ITypeDefinition.
180 * report.cs: Unwrap elements for related symbols reporting.
182 2010-06-15 Marek Safar <marek.safar@gmail.com>
184 A fix for bug #612796
185 * cs-tokenizer.cs: Offset correctly keywords the first character
188 2010-06-15 Marek Safar <marek.safar@gmail.com>
190 A fix for bug #613397
191 * expression.cs: Removed too aggressive object initializers
194 2010-06-15 Marek Safar <marek.safar@gmail.com>
196 * parameter.cs, property.cs, membercache.cs, decl.cs, iterators.cs,
197 anonymous.cs, expression.cs, support.cs, method.cs, pending.cs,
198 class.cs, cs-parser.jay: Simplify parsing of accessors by removing
199 any intermediate steps and fake nodes, also saves few MBs of memory.
201 2010-06-11 Marek Safar <marek.safar@gmail.com>
203 * modifiers.cs, rootcontext.cs, location.cs, cs-parser.jay: More
204 precise modifiers parsing.
206 2010-06-09 Marek Safar <marek.safar@gmail.com>
208 * cs-tokenizer.cs, anonymous.cs, expression.cs, cs-parser.jay:
209 Fixed few shift/reduce conflicts.
211 2010-06-09 Marek Safar <marek.safar@gmail.com>
213 * typemanager.cs, parameter.cs, dynamic.cs, typespec.cs,
214 expression.cs, ecore.cs, cs-parser.jay: Fully parse composed type
215 specifiers and stop using string in AST.
217 2010-06-07 Marek Safar <marek.safar@gmail.com>
219 * typemanager.cs, eval.cs, iterators.cs, anonymous.cs, expression.cs
220 method.cs, class.cs, delegate.cs, cs-parser.jay, driver.cs, visit.cs
221 enum.cs: Hold location of predefined types.
223 2010-06-07 Marek Safar <marek.safar@gmail.com>
225 A fix for bug #610878
226 * pending.cs: Clone cached list before modifying.
228 2010-06-04 Marek Safar <marek.safar@gmail.com>
230 * convert.cs, typespec.cs, expression.cs: Start using array member
231 kind for better conversion checks.
233 * import.cs, report.cs: Report better error message for runtime
236 2010-06-04 Marek Safar <marek.safar@gmail.com>
238 * membercache.cs, convert.cs, nullable.cs, expression.cs: Optimize
239 user defined conversion probing and simplify user conversion for
240 nullabe types. Fixes #610940.
242 2010-06-03 Marek Safar <marek.safar@gmail.com>
244 A fix for bug #610919
245 * parameter.cs, property.cs, cs-parser.jay: Use independent implicit
246 parameters for explicit event accessors. Anonymous method capturing
247 won't otherwise work for event implicit parameter.
249 2010-06-02 Marek Safar <marek.safar@gmail.com>
251 A fix for bug #610088
252 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs:
253 Ignore overrides for base overload resolution as for non-base
254 expressions and convert the best candidate to closest override
257 2010-06-01 Marek Safar <marek.safar@gmail.com>
259 A fix for bug #610139
260 * generic.cs, convert.cs: Recursively check effective base interface
262 2010-06-01 Marek Safar <marek.safar@gmail.com>
264 * statement.cs: Handle nullable types and type parameters in using
265 statement, avoid boxing value types. Also fixes #571010
267 2010-06-01 Marek Safar <marek.safar@gmail.com>
269 * convert.cs, expression.cs: Emit unbox for underlying nullable
272 2010-05-29 Marek Safar <marek.safar@gmail.com>
274 A fix for bug #610126
275 * expression.cs: Don't use branch optimization for types bigger than
278 2010-05-28 Marek Safar <marek.safar@gmail.com>
280 A fix for bug #609088
281 * import.cs: Check private modifier correctly.
283 2010-05-28 Marek Safar <marek.safar@gmail.com>
285 A fix for bug #609049
286 * ecore.cs: Don't ignore override methods when looking for base
289 2010-05-27 Marek Safar <marek.safar@gmail.com>
291 A fix for bugs #608007, #572540, #566130, #476358
293 * generic.cs, linq.cs, expression.cs, statement.cs, cs-parser.jay:
294 More tricky refactoring of implicit linq blocks.
296 2010-05-25 Marek Safar <marek.safar@gmail.com>
298 * linq.cs, cs-parser.jay: Keep location for all linq clauses.
300 2010-05-25 Marek Safar <marek.safar@gmail.com>
302 * context.cs, expression.cs, cs-parser.jay: Don't store current
303 block in This expression (it's too early for linq blocks).
305 2010-05-21 Marek Safar <marek.safar@gmail.com>
307 * expression.cs: Use constrained prefix more broadly to avoid boxing.
309 2010-05-20 Marek Safar <marek.safar@gmail.com>
311 A fix for bug #591149
312 * nullable.cs: Don't double wrap same expression.
314 2010-05-20 Marek Safar <marek.safar@gmail.com>
316 A fix for bug #569827
317 * anonymous.cs: Any issued error in probing mode means no match.
319 2010-05-20 Marek Safar <marek.safar@gmail.com>
321 * expression.cs: Search for base indexer using the closest match
324 2010-05-20 Marek Safar <marek.safar@gmail.com>
326 A fix for bug #572071
327 * method.cs: Set override constraints using unexpanded interface
330 2010-05-20 Marek Safar <marek.safar@gmail.com>
332 A fix for bug #572071
333 * ecore.cs: Include secondary extension method lookup in probing
336 2010-05-19 Marek Safar <marek.safar@gmail.com>
338 A fix for bug #515801
339 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
342 2010-05-19 Marek Safar <marek.safar@gmail.com>
344 A fix for bug #515801
345 * pending.cs: Advance counter correctly.
347 2010-05-19 Marek Safar <marek.safar@gmail.com>
349 A fix for bug #480139
350 * method.cs, pending.cs: Indexer override uses base name.
352 2010-05-19 Marek Safar <marek.safar@gmail.com>
354 A fix for bug #424064
355 * generic.cs: Replace original with inflated type parameter on
358 2010-05-19 Marek Safar <marek.safar@gmail.com>
360 A fix for bug #359733
361 * parameter.cs: Extension attribute can be defined in each assembly.
363 2010-05-18 Marek Safar <marek.safar@gmail.com>
365 A fix for bug #446507
366 * method.cs: Only one method can implement an interface.
368 2010-05-18 Marek Safar <marek.safar@gmail.com>
370 A fix for bug #594905
371 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
372 Typed null can be used as a source for expression methods.
374 2010-05-18 Marek Safar <marek.safar@gmail.com>
376 A fix for bug #606551
377 * namespace.cs: Using directive imports only types and not nested
380 2010-05-17 Marek Safar <marek.safar@gmail.com>
382 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
383 delegate.cs: Member instance is resolved after member overload
384 definitely resolves static/instance property of member expression.
385 Fixes #545047, #358848, #456605, #460016, #603299
387 2010-05-12 Marek Safar <marek.safar@gmail.com>
389 A fix for bug #604981
390 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
391 details for nested anonymous methods stories.
393 2010-05-11 Marek Safar <marek.safar@gmail.com>
395 A fix for bug #604735
396 * namespace.cs: Don't report namespace collision.
398 2010-05-11 Marek Safar <marek.safar@gmail.com>
400 A fix for bug #604748
401 * class.cs, typespec.cs: Search full imported attribute hierarchy
404 2010-05-11 Marek Safar <marek.safar@gmail.com>
406 * namespace.cs: Ignore missing dependencies failure at
409 2010-05-11 Marek Safar <marek.safar@gmail.com>
411 A fix for bug #604640
412 * namespace.cs: Don't resolve using constraints too early.
414 2010-05-11 Marek Safar <marek.safar@gmail.com>
416 A fix for bug #604239
417 * generic.cs: Copy partial type constraints to partial container.
419 2010-05-10 Marek Safar <marek.safar@gmail.com>
421 A fix for bug #557210
422 * import.cs: Relax underlying enum field rules.
424 2010-05-10 Marek Safar <marek.safar@gmail.com>
426 A fix for bug #603476
427 * property.cs: Implement IParametersMember for indexer accessors.
429 2010-05-07 Marek Safar <marek.safar@gmail.com>
431 A fix for bug #601141
432 * class.cs: Update all partial modifiers.
434 2010-05-06 Marek Safar <marek.safar@gmail.com>
436 A fix for bug #601708
437 * method.cs, membercache.cs: Destructors cannot be hidden.
439 2010-05-06 Marek Safar <marek.safar@gmail.com>
441 A fix for bug #602551
442 * class.cs: Resursive reference of type definition is allowed.
444 2010-05-06 Marek Safar <marek.safar@gmail.com>
446 * anonymous.cs: Mutate cached storey instance types too.
448 2010-05-06 Marek Safar <marek.safar@gmail.com>
450 A fix for bug #602443
451 * convert.cs: Explicit enum conversion cannot involve user operators
453 2010-05-05 Miguel de Icaza <miguel@novell.com>
455 * class.cs (TypeContainer.DefineBaseTypes)
456 (TypeContainer.CheckRecursiveDefinition): check for the iface not
457 being null, as we could have failed resolution and crashed;
460 * cs-parser.jay: Productions to catch common mistakes when other
461 punctuation operators are used instead of comma. Fixes 571702
463 2010-05-05 Marek Safar <marek.safar@gmail.com>
465 * anonymous.cs: Mutate correct set of constraints.
467 2010-05-05 Marek Safar <marek.safar@gmail.com>
469 A fix for bug #602842
470 * expression.cs: Resolve all array bound arguments.
472 2010-05-05 Marek Safar <marek.safar@gmail.com>
474 * import.cs: Don't import private fields.
476 2010-04-30 Marek Safar <marek.safar@gmail.com>
478 Partially based on patch by <sami.lamti@gmail.com>
480 * eval.cs, ecore.cs: Fixed eval show methods.
482 2010-04-30 Marek Safar <marek.safar@gmail.com>
484 * generic.cs, delegate.cs: Implement output type inference of
485 methodgroup now when the specification was cleared at least little
488 2010-04-29 Marek Safar <marek.safar@gmail.com>
490 A fix for bug #575611
491 * class.cs: Fix recursive unmanaged recursice sruct check.
493 2010-04-29 Marek Safar <marek.safar@gmail.com>
495 A fix for bug #479776
496 * expression.cs: Implement typeof unbounded nested generic types.
498 2010-04-29 Marek Safar <marek.safar@gmail.com>
500 A fix for bug #474953
501 * class.cs: Fix valid recursive base type definition.
503 2010-04-29 Marek Safar <marek.safar@gmail.com>
505 A fix for bug #421737
506 * convert.cs, expression.cs: A boxing conversion exists from a
507 nullable-type to a reference type, if a boxing conversion exists
508 from the underlying non-nullable-value-type to the reference type.
510 2010-04-29 Marek Safar <marek.safar@gmail.com>
512 A fix for bug #376875
513 * import.cs: Import volatile modifier.
515 2010-04-29 Marek Safar <marek.safar@gmail.com>
517 A fix for bug #372412
518 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
521 2010-04-29 Marek Safar <marek.safar@gmail.com>
523 A fix for bug #568955
524 * statements.cs: Handle recursive scope initializers.
526 2010-04-28 Marek Safar <marek.safar@gmail.com>
528 A fix for bug #566511
529 * anonymous.cs: Always get inflated version of hoisted variable
530 on generic type definition.
532 2010-04-28 Marek Safar <marek.safar@gmail.com>
534 * import.cs, membercache.cs: Relax rules for valid properties.
536 2010-04-28 Marek Safar <marek.safar@gmail.com>
538 * import.cs: Intern arrays used in generic arguments.
540 2010-04-28 Marek Safar <marek.safar@gmail.com>
542 A fix for bug #600398
543 * convert.cs: Actually use effective base type for the comparison.
545 2010-04-28 Marek Safar <marek.safar@gmail.com>
547 A fix for bug #600326
548 * ecore.cs: Pass arity to base member lookup.
550 2010-04-28 Marek Safar <marek.safar@gmail.com>
552 A fix for bug #573385
553 * expression.cs: MemberAccess is of generic type based on right
556 2010-05-28 Marek Safar <marek.safar@gmail.com>
558 * cs-tokenizer.cs: Made tab size configurable.
560 2010-05-27 Marek Safar <marek.safar@gmail.com>
562 * attribute.cs: Ensure Obsolete members are defined before doing
565 2010-05-27 Marek Safar <marek.safar@gmail.com>
567 * visit.cs: Add DOM visitor skeleton.
571 2010-05-27 Marek Safar <marek.safar@gmail.com>
573 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
575 2010-05-27 Marek Safar <marek.safar@gmail.com>
577 * *.cs: Major rewrite of compiler internals to better work with
578 unmodified System.Reflection.Emit. Some of the key changes are
579 - TypeSpec replaces reflection specific System.Type.
580 - All Type(TypeSpec) operations are now done in compiler therefore
581 no dependency on SRE to inflate generic members and types or to
582 query unclosed types.
583 - MemberCache is now the only and full hierarchical topology.
584 - Generic constraints are implemented properly.
585 - And as a bonus compilation is on average 30% faster.
587 2010-04-15 Jb Evain <jbevain@novell.com>
589 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
591 2010-04-12 Marek Safar <marek.safar@gmail.com>
593 * expression.cs, attribute.cs, parameter.cs: More attribute type
596 2010-04-12 Marek Safar <marek.safar@gmail.com>
598 A fix for bug #593342
600 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
601 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
602 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
603 codegen.cs: Add custom attribute encoder to deal with unfinished
604 types and easier corlib bootstrap from its own types.
606 2010-03-26 Marek Safar <marek.safar@gmail.com>
608 * cs-parser.jay: Report invalid constraint types.
610 2010-03-16 Jb Evain <jbevain@novell.com>
612 * Makefile: rename the net_2_1 profile to moonlight.
614 2010-03-11 Marek Safar <marek.safar@gmail.com>
616 * statement.cs, cs-parser.jay: Use correct location for empty
619 2010-03-11 Marek Safar <marek.safar@gmail.com>
621 * cs-parser.jay: Disable Location from expression.
623 * generic.cs: Check constraints for overrides in the parser.
625 2010-03-09 Marek Safar <marek.safar@gmail.com>
627 * cs-parser.jay (GetLocation): Use an expression when available.
629 2010-03-04 Marek Safar <marek.safar@gmail.com>
631 A fix for bug #582579
632 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
634 2010-03-04 Marek Safar <marek.safar@gmail.com>
636 A patch by kornelpal@gmail.com
638 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
639 compiler generated classes sealed by default. Emit and close top
640 level compiler generated classes as well.
642 * support.cs: Use RuntimeHelpers.GetHashCode.
644 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
646 * Makefile: We need to use the internal bootstrapping gmcs for
647 net_2_1_bootstrap too now.
649 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
651 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
653 2010-03-02 Marek Safar <marek.safar@gmail.com>
655 * cs-tokenizer.cs: Missed few locations in previous fix.
657 2010-03-02 Marek Safar <marek.safar@gmail.com>
659 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
660 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
661 Report correct location for operator errors.
663 2010-03-02 Marek Safar <marek.safar@gmail.com>
665 * typemanager.cs (IsDynamicType): Don't check external types when
666 the attribute is not external.
668 2010-02-24 Marek Safar <marek.safar@gmail.com>
670 A fix for bug #582579
671 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
674 2010-02-24 Marek Safar <marek.safar@gmail.com>
676 A fix for bug #581804
677 * ecore.cs: Fixed type comparison.
679 2010-02-08 Miguel de Icaza <miguel@novell.com>
681 * namespace.cs (CompletionGetTypesStartingWith): Do not include
682 private types in the completion results.
684 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
687 2010-02-17 Marek Safar <marek.safar@gmail.com>
689 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
692 2010-02-14 Miguel de Icaza <miguel@novell.com>
694 * eval.cs: Do not do the report printer dance unless the user has
695 set the DescribeTypes feature.
697 2010-02-10 Marek Safar <marek.safar@gmail.com>
699 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
701 2010-02-08 Marek Safar <marek.safar@gmail.com>
703 A fix for bug #577029
704 * anonymous.cs: Fixed TypeBuilder* check.
706 2010-02-06 Miguel de Icaza <miguel@novell.com>
708 * eval.cs (CompileBlock): Also undo if there are problems during
709 semantic analysis, fixes various cases where invalid C# code would
710 be reported, but the internal changes would not be undone.
712 2010-02-03 Miguel de Icaza <miguel@novell.com>
714 * driver.cs: Change the --fatal flag to allow a number to be
715 passed, this ignores the first N fatal errors. Useful to debug
716 errors that do not happen on the first hit.
718 * cs-parser.jay (invocation_expression): accept both the
719 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
720 inside an invocation.
722 * driver.cs: Expose FatalErrors.
724 * eval.cs: Initialize the printer's Fatal property from the
725 Driver's FatalError flag, this allows csharp --fatal to work
728 Add support for calling Describe (typeof (TYPE)) if the expression
731 2010-02-02 Marek Safar <marek.safar@gmail.com>
733 A fix for bug #574991
734 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
737 2010-02-02 Marek Safar <marek.safar@gmail.com>
739 A fix for bug #575986
740 * expression.cs: Don't mutate typeof type definitions.
742 2010-01-28 Marek Safar <marek.safar@gmail.com>
744 * decl.cs: Use only one set of modifiers.
746 2010-01-26 Marek Safar <marek.safar@gmail.com>
748 A fix for bug #573329
749 * eval.cs: Don't disable error reporting completely on silent mode.
751 2010-01-25 Marek Safar <marek.safar@gmail.com>
753 A fix for bug #573312
754 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
755 pointer index of unknown size types greater than 2.
757 2010-01-15 Marek Safar <marek.safar@gmail.com>
759 * *.cs: Use only 1 member kind enum.
761 2010-01-15 Marek Safar <marek.safar@gmail.com>
763 * *.cs: Add event specification.
765 2010-01-14 Marek Safar <marek.safar@gmail.com>
767 * membercache.cs: Extracted from decl.cs.
769 * *.cs: Put more infrastructure in place.
771 2010-01-13 Marek Safar <marek.safar@gmail.com>
773 * *.cs: Add property specification, unused yet.
775 2010-01-13 Marek Safar <marek.safar@gmail.com>
777 * property.cs: Move all property based declarations into a new file.
779 2010-01-13 Marek Safar <marek.safar at gmail.com>
781 * expression.cs (Conditional): Resolve reduced expression.
783 2010-01-13 Marek Safar <marek.safar at gmail.com>
785 * *.cs: Introduced non-generic method specification.
787 2010-01-07 Marek Safar <marek.safar@gmail.com>
789 * method.cs: Move all method based declarations into a new file.
791 2010-01-07 Marek Safar <marek.safar@gmail.com>
793 * *.cs: Extract field specification.
795 2009-12-17 Marek Safar <marek.safar@gmail.com>
797 * field.cs: Extracted from class.cs
799 2009-12-15 Marek Safar <marek.safar@gmail.com>
801 * attribute.cs (GetFixedBuffer): Work on field definition only.
803 2009-12-15 Marek Safar <marek.safar@gmail.com>
805 * *.cs: Clean up NET_4_0 conditional where possible.
807 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
809 support.cs (DynamicType): Assembly property returns the assembly builder.
810 This is required due to how compiler context works in corlib.
812 2009-12-14 Marek Safar <marek.safar@gmail.com>
814 A fix for bug #564376
815 * assign.cs (LocalTemporary): Removed no longer needed special
818 2009-12-11 Marek Safar <marek.safar@gmail.com>
820 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
821 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
822 enum for easier debugging.
824 2009-12-10 Marek Safar <marek.safar@gmail.com>
826 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
829 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
832 2009-12-10 Marek Safar <marek.safar@gmail.com>
834 * cs-parser.jay, statement.cs: Handle parser error in code
837 2009-12-10 Marek Safar <marek.safar@gmail.com>
839 * ecore.cs: Ignore base imported methods when they are already
842 * eval.cs: Handle non-existent keys.
844 * report.cs, driver.cs: Make fatal work with console printer only.
846 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
848 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
850 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
852 * typemanager.cs: Add MakeGenericMethod that checks if the method
853 is really the generic method definition.
855 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
856 to inflate generic methods.
858 2009-12-08 Marek Safar <marek.safar@gmail.com>
860 A fix for bug #561149
861 * anonymous.cs: Use actual type parameters when checking for generic
864 2009-12-08 Marek Safar <marek.safar@gmail.com>
866 A fix for bug #561369
867 * expression.cs (DoNumericPromotion): Fixed typo.
869 2009-12-08 Marek Safar <marek.safar@gmail.com>
871 *.cs: Moving to generics world.
873 cs-parser.jay: Removed current_array_type.
875 2009-12-07 Marek Safar <marek.safar@gmail.com>
877 *.cs: Moving to generics world.
879 2009-12-04 Marek Safar <marek.safar@gmail.com>
881 *.cs: Moving to generics world (day 2).
883 2009-12-03 Marek Safar <marek.safar@gmail.com>
885 *.cs: Moving to generics world.
887 2009-12-02 Marek Safar <marek.safar@gmail.com>
889 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
890 Encode dynamic type attribute for elements where attributes cannot
893 2009-12-01 Marek Safar <marek.safar@gmail.com>
895 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
898 2009-12-01 Marek Safar <marek.safar@gmail.com>
900 A fix for bug #360455
901 * class.cs: Never report a unused warning for generic events to
902 workaround wrong expression type.
904 2009-11-30 Marek Safar <marek.safar@gmail.com>
906 A fix for bug #558305
907 * decl.cs, class.cs: Check partial method definitions using correct
910 2009-11-30 Marek Safar <marek.safar@gmail.com>
912 * argument.cs: Don't cache rarely used dynamic flag.
914 2009-11-27 Marek Safar <marek.safar@gmail.com>
916 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
918 2009-11-27 Marek Safar <marek.safar@gmail.com>
920 * ecore.cs (SimpleName): Removed no longer needed in_transit as
921 Resolve is now non-reentrant (saves ~0.6MB for corlib).
923 2009-11-26 Marek Safar <marek.safar@gmail.com>
925 A fix for bug #545081
926 * decl.cs: Check private nested types of nested types recursively.
928 2009-11-26 Marek Safar <marek.safar@gmail.com>
930 A fix for bug #558305
931 * location.cs: Ignore self referencing #line directive
933 2009-11-26 Marek Safar <marek.safar@gmail.com>
935 A fix for bug #558292
936 * class.cs: Allow single unsafe fixed buffer fields.
938 2009-11-26 Marek Safar <marek.safar@gmail.com>
940 * expression: Optimize few more zero-based operations.
942 2009-11-26 Marek Safar <marek.safar@gmail.com>
944 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
945 avoids boxing of literal values.
947 2009-11-26 Marek Safar <marek.safar@gmail.com>
949 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
950 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
951 codegen.cs: LocatedToken redesing to avoid excessive allocation and
952 boxing (saves ~7MB for corlib). Also fixes presise token location.
954 2009-11-25 Marek Safar <marek.safar@gmail.com>
956 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
959 2009-11-24 Marek Safar <marek.safar@gmail.com>
961 * expression.cs: Lower static array initializer barrier.
963 * support.cs, driver.cs: Share reader buffer.
965 2009-11-23 Marek Safar <marek.safar@gmail.com>
967 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
969 2009-11-23 Marek Safar <marek.safar@gmail.com>
971 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
972 cleanup some obsolete code.
974 2009-11-20 Marek Safar <marek.safar@gmail.com>
976 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
979 2009-11-20 Marek Safar <marek.safar@gmail.com>
981 * *.cs: Resolved expressions are never resolved again, this helps to
982 uncover some not easy to find bugs and improve the performance.
984 2009-11-19 Marek Safar <marek.safar@gmail.com>
986 * *.cs: Made constant expressions fully compatible with any other
989 2009-11-19 Marek Safar <marek.safar@gmail.com>
991 * *.cs: DoResolve is a worker method and has to be protected.
993 2009-11-18 Marek Safar <marek.safar@gmail.com>
995 * *.cs: More context specific handling.
997 2009-11-17 Marek Safar <marek.safar@gmail.com>
999 * *.cs: More context specific handling.
1001 2009-11-16 Marek Safar <marek.safar@gmail.com>
1003 * dynamic.cs, class.cs: Removed few fixed user types conversions.
1005 * symbolwriter.cs: Uses public ILOffset.
1007 2009-11-13 Marek Safar <marek.safar@gmail.com>
1009 A fix for bug #553650
1010 * generic.cs: Another missing TypeToCoreType, still too many to fix.
1012 2009-11-13 Marek Safar <marek.safar@gmail.com>
1014 A fix for bug #555170
1016 * class.cs, delegate.cs, enum.cs: Constants have to be available
1017 for parameters resolve.
1019 2009-11-12 Marek Safar <marek.safar@gmail.com>
1021 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
1024 2009-11-12 Marek Safar <marek.safar@gmail.com>
1026 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
1027 with a statically known candidate set.
1029 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
1031 * generic.cs: Made type inflation for generic constraint checks
1032 recursive. This fixes BGO #553655.
1034 2009-11-11 Marek Safar <marek.safar@gmail.com>
1036 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
1039 2009-11-10 Marek Safar <marek.safar@gmail.com>
1041 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
1042 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
1043 attribute.cs: Add some dynamic error checking.
1045 2009-11-07 Marek Safar <marek.safar@gmail.com>
1047 A fix for bug #553465
1049 * expression.cs: Fixed mixed version of expression tree anonymous
1052 2009-11-06 Marek Safar <marek.safar@gmail.com>
1054 A fix for bug #553031
1056 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
1057 expression tree version of anonymous type with members declaration.
1059 2009-11-05 Marek Safar <marek.safar@gmail.com>
1061 * parameter.cs: Handle nullable parameter default expression.
1063 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
1064 class.cs, attribute.cs: Check for wrong dynamic arguments.
1066 2009-11-05 Marek Safar <marek.safar@gmail.com>
1068 * statement.cs: Dynamic statements.
1070 2009-11-04 Marek Safar <marek.safar@gmail.com>
1072 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
1073 Compound assignments over dynamic type.
1075 2009-11-03 Marek Safar <marek.safar@gmail.com>
1077 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
1078 constructor arguments.
1080 2009-10-30 Marek Safar <marek.safar@gmail.com>
1082 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
1083 codegen.cs: Unary mutator on dynamic member access expression.
1085 2009-10-29 Marek Safar <marek.safar@gmail.com>
1087 A fix for bug #550580
1088 * convert.cs: Don't eliminate explicit precission casts.
1090 2009-10-28 Marek Safar <marek.safar@gmail.com>
1092 A fix for bug #550404
1094 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
1095 expression.cs, statement.cs, ecore.cs: Quote any nested expression
1098 2009-10-27 Marek Safar <marek.safar@gmail.com>
1100 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
1103 * class.cs: Allow nullable binary user operators.
1105 2009-10-26 Marek Safar <marek.safar@gmail.com>
1107 * expression.cs: Move binary expression optimization at the end of
1110 2009-10-23 Marek Safar <marek.safar@gmail.com>
1112 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
1113 Separate NullConstant from NullLiteral.
1115 2009-10-23 Marek Safar <marek.safar@gmail.com>
1117 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
1118 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
1119 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
1120 ModuleContainer. Add common unclosed member check routine.
1122 2009-10-22 Marek Safar <marek.safar@gmail.com>
1124 * argument.cs: Use literal flag for real literals only.
1126 * dynamic.cs: Use correct return type for custom delegates.
1128 2009-10-22 Marek Safar <marek.safar@gmail.com>
1130 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
1133 2009-10-22 Marek Safar <marek.safar@gmail.com>
1135 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
1137 2009-10-21 Marek Safar <marek.safar@gmail.com>
1139 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
1142 2009-10-21 Marek Safar <marek.safar@gmail.com>
1144 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
1147 2009-10-20 Marek Safar <marek.safar@gmail.com>
1149 * argument.cs, dynamic.cs, expression.cs: Latest API update.
1151 2009-10-19 Marek Safar <marek.safar@gmail.com>
1153 * typemanager.cs, expression.cs: Dynamic array initializer.
1155 2009-10-16 Marek Safar <marek.safar@gmail.com>
1157 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
1160 2009-10-16 Marek Safar <marek.safar@gmail.com>
1162 A fix for bug #493523, #507067
1163 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
1164 standard nullable conversion using underlying standard conversion
1165 and not full conversion.
1167 2009-10-15 Marek Safar <marek.safar@gmail.com>
1169 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
1170 type in VerifyArgumentsCompat.
1172 2009-10-15 Marek Safar <marek.safar@gmail.com>
1174 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1175 Reject variable used with type arguments.
1177 2009-10-14 Marek Safar <marek.safar@gmail.com>
1179 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
1180 Implement dynamic expressions assignment.
1182 2009-10-14 Marek Safar <marek.safar@gmail.com>
1184 * expression.cs: Build underlying expression when resolving unary
1187 2009-10-14 Marek Safar <marek.safar@gmail.com>
1189 * expression.cs: Emit enum array initializer using binary blob.
1191 2009-10-08 Marek Safar <marek.safar@gmail.com>
1193 * typemanager.cs, constant.cs: Optimize decimal constants which fit
1196 2009-10-07 Marek Safar <marek.safar@gmail.com>
1198 * typemanager.cs: Reset object_type.
1200 * assign: Made SimpleAssign public.
1202 2009-10-06 Marek Safar <marek.safar@gmail.com>
1204 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
1205 invocation assembly to IsThisOrFriendAssembly.
1207 2009-10-05 Marek Safar <marek.safar@gmail.com>
1209 * expression.cs: Equality comparison of generic parameter with
1212 2009-10-05 Marek Safar <marek.safar@gmail.com>
1214 A fix for bug #543570
1215 * generic.cs: Import predefined constraints correctly.
1217 2009-10-02 Marek Safar <marek.safar@gmail.com>
1219 * ecore.cs: Don't crash on overloads with optional paremeters where
1220 arguments count overflows.
1222 * parameter.cs: Import optional parameter constants using optional
1225 2009-10-01 Marek Safar <marek.safar@gmail.com>
1227 * Makefile: Default is gmcs compiler.
1229 2009-10-01 Marek Safar <marek.safar@gmail.com>
1231 * cs-parser.jay: Fixed few NRE.
1233 2009-10-01 Marek Safar <marek.safar@gmail.com>
1235 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
1237 2009-09-30 Marek Safar <marek.safar@gmail.com>
1239 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
1240 ShimExpression, ImplicitCast.
1242 2009-09-30 Marek Safar <marek.safar@gmail.com>
1244 A fix for bug #542959
1245 * delegate.cs: Emit correct delegate instance variable when there
1246 are static and non-static overloads.
1248 2009-09-29 Marek Safar <marek.safar@gmail.com>
1250 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
1251 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
1253 2009-09-28 Marek Safar <marek.safar@gmail.com>
1255 A fix for bug #542487
1256 * ecore.cs: Resolve extension methods hidden by properties.
1258 2009-09-25 Marek Safar <marek.safar@gmail.com>
1260 * expression.cs, ecore.cs: More dynamic binary expressions.
1262 2009-09-22 Marek Safar <marek.safar@gmail.com>
1264 * nullable.cs, expression.cs: Fixed null lifted conversion for
1265 bitwise enum operations.
1267 2009-09-22 Marek Safar <marek.safar@gmail.com>
1269 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
1270 values in checked context.
1272 2009-09-22 Marek Safar <marek.safar@gmail.com>
1274 * expression.cs, ecore.cs: Fixed array index constant conversion.
1276 2009-09-20 Miguel de Icaza <miguel@novell.com>
1278 * expression.cs: Do not crash when MemberLookup returns something
1279 that is not a MemberExpr here. Report error 582 instead.
1283 2009-09-18 Marek Safar <marek.safar@gmail.com>
1285 * decl.cs, class.cs: Check protected property accessors.
1287 2009-09-18 Marek Safar <marek.safar@gmail.com>
1289 * dynamic.cs, assign.cs: Dynamic compound assignment.
1291 2009-09-17 Marek Safar <marek.safar@gmail.com>
1293 * expression.cs: Fixed compound assignment explicit conversion.
1295 2009-09-17 Marek Safar <marek.safar@gmail.com>
1297 * expression.cs, ecore.cs: Cannot infer variables from method group.
1299 2009-09-16 Marek Safar <marek.safar@gmail.com>
1301 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
1302 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
1303 codegen.cs: Dynamic binary operations scaffolding.
1305 2009-09-15 Marek Safar <marek.safar@gmail.com>
1307 * expression.cs: Fixes nullable promotion for enum type variables.
1309 2009-09-11 Marek Safar <marek.safar@gmail.com>
1311 * driver.cs, dynamic.cs: Reset more static variables.
1313 2009-09-11 Marek Safar <marek.safar@gmail.com>
1315 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1316 driver.cs: Introduced Expression::MakeExpression.
1318 2009-09-11 Marek Safar <marek.safar@gmail.com>
1320 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1322 2009-09-09 Marek Safar <marek.safar@gmail.com>
1324 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1327 2009-09-09 Marek Safar <marek.safar@gmail.com>
1329 A fix for bug #518707
1330 * expression.cs (Is): Optimize only generic parameter type
1331 expression probing value type generic parameter.
1333 2009-09-09 Marek Safar <marek.safar@gmail.com>
1335 A fix for bug #532571
1336 * ecore.cs: Check for simple name type arguments used with
1339 2009-09-08 Marek Safar <marek.safar@gmail.com>
1341 A fix for bug #497421
1342 * generic.cs (CheckConstraint): Don't use buildin types to check for
1343 parameterless constructor.
1345 2009-09-08 Marek Safar <marek.safar@gmail.com>
1347 A fix for bug #537402
1348 * generic.cs (CheckConstraint): Correctly inflate generic type
1349 arguments when checking generic method.
1351 2009-09-08 Marek Safar <marek.safar@gmail.com>
1353 A fix for bug #536463
1354 * decl.cs (AddToContainer): Don't report collision between explicit
1355 and parameterless non-explicit members.
1357 2009-09-08 Marek Safar <marek.safar@gmail.com>
1359 * eval.cs: Reset more static stuff.
1361 2009-09-07 Marek Safar <marek.safar@gmail.com>
1363 A fix for bug #324625
1364 * expression.cs, ecore.cs: Create nested generic type expression
1365 using declaring and not current type.
1367 2009-09-07 Marek Safar <marek.safar@gmail.com>
1369 * *.cs: Changed Report class to accept various output printers and
1370 be an instance class. An expression resolver can now use different
1371 message reporter for each call and Report.Error can safely throw
1372 an exception. Part of ongoing work to turn mcs into proper library.
1374 2009-09-04 Marek Safar <marek.safar@gmail.com>
1376 * statement.cs, ecore.cs: Removed error reporting from emit code.
1378 2009-09-04 Marek Safar <marek.safar@gmail.com>
1380 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1382 2009-09-03 Marek Safar <marek.safar@gmail.com>
1384 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1385 parser checks out of constructors.
1387 2009-09-02 Marek Safar <marek.safar@gmail.com>
1389 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1391 2009-09-02 Marek Safar <marek.safar@gmail.com>
1393 A fix for bug #535448
1394 * anonymous.cs, class.cs: Copy return label between all contexts.
1396 2009-09-02 Marek Safar <marek.safar@gmail.com>
1398 A fix for bug #535395
1399 * namespace.cs: Resolve context can be null.
1401 2009-08-25 Marek Safar <marek.safar@gmail.com>
1403 A fix for bug #533912
1404 * generic.cs: Use correct context for constraints resolving.
1406 2009-08-25 Marek Safar <marek.safar@gmail.com>
1408 A fix for bug #532630
1409 * driver.cs: Trim conditional symbols.
1411 2009-08-25 Marek Safar <marek.safar@gmail.com>
1413 * context.cs: New file.
1415 * *.exe.sources, *.csproj: Updated.
1417 2009-08-25 Marek Safar <marek.safar@gmail.com>
1419 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1420 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1421 IMembercontext, some small cleanups.
1423 2009-08-24 Marek Safar <marek.safar@gmail.com>
1425 * *.cs: Split ResolveContext and EmitContext.
1427 2009-08-24 Marek Safar <marek.safar@gmail.com>
1429 * *.cs: Only ResolveContext implements IMemberContext.
1431 2009-08-21 Marek Safar <marek.safar@gmail.com>
1433 * *.cs: Renamed IResolveContext to IMemberContext.
1435 2009-08-21 Marek Safar <marek.safar@gmail.com>
1437 * *.cs: Detached ResolveContext from EmitContext.
1439 2009-08-21 Marek Safar <marek.safar@gmail.com>
1441 * codegen.cs: Moved flow-analysis to BlockContext.
1443 2009-08-21 Marek Safar <marek.safar@gmail.com>
1445 * *.cs: Detached BlockContext from EmitContext.
1447 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1449 * statement.cs: avoid nullref when the return value of GetEnumerator()
1450 does not contain any MoveNext() method.
1452 2009-08-19 Marek Safar <marek.safar@gmail.com>
1454 * *.cs: Removed IResolveContext::GenericDeclContainer.
1456 2009-08-19 Marek Safar <marek.safar@gmail.com>
1458 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1460 2009-08-19 Marek Safar <marek.safar@gmail.com>
1462 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1463 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1465 2009-08-18 Marek Safar <marek.safar@gmail.com>
1467 * *.cs: Removed boolean fields from EmitContext.
1469 2009-08-18 Marek Safar <marek.safar@gmail.com>
1471 * *.cs: Add IResolveContext::IsStatic.
1473 2009-08-18 Marek Safar <marek.safar@gmail.com>
1475 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1477 2009-08-17 Marek Safar <marek.safar@gmail.com>
1479 * *.cs: Removed DeclContainer from EmitContext.
1481 2009-08-17 Marek Safar <marek.safar@gmail.com>
1483 * *.cs: Add IResolveContext::CurrentTypeParameters.
1485 2009-08-14 Marek Safar <marek.safar@gmail.com>
1487 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1489 2009-08-14 Marek Safar <marek.safar@gmail.com>
1491 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1492 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1494 2009-08-13 Marek Safar <marek.safar@gmail.com>
1496 * decl.cs: Look in PartialContainer for parent type parameters.
1498 2009-08-13 Marek Safar <marek.safar@gmail.com>
1500 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1501 codegen.cs: Add IResolveContext::LookupTypeParameter.
1503 2009-08-13 Marek Safar <marek.safar@gmail.com>
1505 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1506 Moved resolved logic from Emit to Resolve.
1508 2009-08-13 Marek Safar <marek.safar@gmail.com>
1510 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1511 codegen.cs: Reworked atttributes handling of ResolveContext.
1513 2009-08-12 Marek Safar <marek.safar@gmail.com>
1515 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1516 LookupNamespaceOrType to ResolveContext.
1518 2009-08-12 Marek Safar <marek.safar@gmail.com>
1520 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1521 class.cs: Removed unused parameters and methods.
1523 2009-08-11 Marek Safar <marek.safar@gmail.com>
1525 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1526 codegen.cs: Finding the best common type of a set of expressions for
1529 2009-08-07 Marek Safar <marek.safar@gmail.com>
1531 * dynamic.cs, expression.cs: More dynamic conversions.
1533 2009-08-06 Miguel de Icaza <miguel@novell.com>
1535 * generic.cs: This loop was incorrect, it was increment ii, but
1536 checking for `i'. This was a change introduced to fix #327497,
1539 * class.cs: Catch another case for cs0533 error, fixes #324782.
1541 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1543 * typemanager.cs (GetGenericArguments): SRE returns null for
1544 generic methods on type builder instances if they are not generic
1545 themselves. For example, for Foo<int>::Bar() it returns null, but
1546 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1548 2009-08-05 Marek Safar <marek.safar@gmail.com>
1550 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1551 delegate.cs: Work on dynamic binding.
1553 2009-08-04 Marek Safar <marek.safar@gmail.com>
1555 A second fix for bug #525342
1556 * class.cs: Attach partial method attributes to method
1559 2009-08-03 Marek Safar <marek.safar@gmail.com>
1561 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1564 * rootcontext.cs: Default to langversion v4.
1566 2009-08-03 Marek Safar <marek.safar@gmail.com>
1568 * pending.cs: Check return type before member info is set.
1570 2009-08-03 Marek Safar <marek.safar@gmail.com>
1572 * anonymous.cs: Fully initialize generic hoisted field expression.
1574 2009-08-02 Miguel de Icaza <miguel@novell.com>
1576 * cs-parser.jay: Flag variables declared on the interactive shell
1577 as used to prevent the 168 warning about local variable not being
1580 2009-07-31 Marek Safar <marek.safar@gmail.com>
1582 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1583 attribute.cs: Emit dynamic export attribute.
1585 2009-07-30 Marek Safar <marek.safar@gmail.com>
1587 * expression.cs: More verifier work.
1589 2009-07-29 Marek Safar <marek.safar@gmail.com>
1591 * nullable.cs: Fixed SRE crash during corlib compilation.
1593 2009-07-29 Marek Safar <marek.safar@gmail.com>
1595 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1596 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1597 More TypeManager.TypeToCoreType needed.
1599 2009-07-29 Marek Safar <marek.safar@gmail.com>
1601 * anonymous.cs: Update after recent SRE fixes.
1603 2009-07-28 Marek Safar <marek.safar@gmail.com>
1605 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1606 version of GetFieldHandle for fields of generic types.
1608 2009-07-27 Marek Safar <marek.safar@gmail.com>
1610 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1611 ecore.cs: Add TypeManager.IsDynamicType,
1612 PredefinedAttributes.Dynamic.
1614 2009-07-27 Marek Safar <marek.safar@gmail.com>
1616 A fix for bug #415375
1617 * expression.cs: Fixed object and reference type parameter
1620 2009-07-27 Marek Safar <marek.safar@gmail.com>
1622 A fix for bug #525342
1623 * class.cs: Attach partial method attributes to method
1626 2009-07-24 Marek Safar <marek.safar@gmail.com>
1628 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1631 2009-07-24 Marek Safar <marek.safar@gmail.com>
1633 * anonymous.cs (MutateField): Add imported types handling.
1635 2009-07-23 Marek Safar <marek.safar@gmail.com>
1637 * expression.cs, delegate.cs: Moved arguments resolve into their
1638 counterparts expressions. Removed argument resolve from
1639 CollectionElementInitializer.
1641 2009-07-23 Marek Safar <marek.safar@gmail.com>
1643 A fix for bug #523683
1644 * convert.cs, delegate.cs: Use common overload mechanism for method
1645 group conversion check.
1647 2009-07-22 Marek Safar <marek.safar@gmail.com>
1649 A fix for bug #523899
1650 * generics.cs: Exact type inference with other bound types.
1652 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1654 Don't complain when the same type is implemented by the output
1655 assembly as well as multiple referenced assemblies
1656 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1657 'must_be_unique' flag.
1658 (GlobalRootNamespace): Update to changes.
1659 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1660 already have a type in hand.
1662 2009-07-22 Marek Safar <marek.safar@gmail.com>
1664 * expression.cs: More verifier instrumentation.
1666 * statement.cs: Do proper throw expression conversion.
1668 2009-07-22 Marek Safar <marek.safar@gmail.com>
1670 A fix for bug #522789
1671 * expression.cs: Mutate invocation return type.
1673 2009-07-16 Marek Safar <marek.safar@gmail.com>
1675 * anonymous.cs: Split assignable and readonly generated variable
1678 2009-07-16 Marek Safar <marek.safar@gmail.com>
1680 A fix for bug #521671
1681 * statement.cs: Fixed crash when checking missing type.
1683 2009-07-16 Marek Safar <marek.safar@gmail.com>
1685 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1686 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1687 class.cs, driver.cs: Work on dynamic binding.
1689 * dynamic.cs: New file.
1691 * *.sources, *.proj: Updated.
1693 2009-07-15 Marek Safar <marek.safar@gmail.com>
1695 * expression.cs (Conditional): Avoid double Resolve.
1697 2009-07-13 Marcus Griep <marcus@griep.us>
1699 * ecore.cs: Fix obscure bug with resolving members of interfaces
1700 that hide parent interface members. Fixes bug #444388 and corrects
1703 2009-07-13 Marek Safar <marek.safar@gmail.com>
1705 * expression.cs (LocalVariableReference): Bounce resolve.
1707 2009-07-10 Marek Safar <marek.safar@gmail.com>
1709 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1710 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1713 * support.cs: New dynamic type wrapper.
1715 2009-07-08 Marek Safar <marek.safar@gmail.com>
1717 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1718 typed local variable.
1720 2009-07-06 Marek Safar <marek.safar@gmail.com>
1722 A fix for bug #519005
1723 * anonymous.cs: Use null_type as no return type placeholder.
1725 2009-07-02 Marek Safar <marek.safar@gmail.com>
1727 * generic.cs: Handle type inference of identical type parameters
1728 with different bounds.
1730 2009-07-01 Marek Safar <marek.safar@gmail.com>
1732 * expression.cs, class.cs: Events variance.
1734 * cs-parser.jay: Interface events error messages.
1736 2009-07-01 Marek Safar <marek.safar@gmail.com>
1738 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1740 2009-06-29 Marek Safar <marek.safar@gmail.com>
1742 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1743 parameter expression can be value-type New.
1745 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1747 2009-06-26 Marek Safar <marek.safar@gmail.com>
1749 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1750 Implemented C# 4.0 named arguments.
1752 2009-06-24 Marek Safar <marek.safar@gmail.com>
1754 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1755 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1756 parameter modifier. Also fixes bug #515497.
1758 2009-06-24 Marek Safar <marek.safar@gmail.com>
1760 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1761 arguments expression to be implemented.
1763 *.sources: Add argument.cs
1765 2009-06-23 Marek Safar <marek.safar@gmail.com>
1767 * parameter.cs: Moved GetParameterIndexByName to base class.
1769 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1770 unused AType. Use argument's version of GetExpressionTree.
1772 2009-06-22 Marek Safar <marek.safar@gmail.com>
1774 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1777 2009-06-17 Marek Safar <marek.safar@gmail.com>
1779 A fix for bug #514096
1780 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1782 2009-06-17 Marek Safar <marek.safar@gmail.com>
1784 * expression.cs: The first multi-dimensional array nested array
1785 initializers was not checked.
1787 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1789 2009-06-17 Marek Safar <marek.safar@gmail.com>
1791 A fix for bug #513400
1792 * nullable.cs (EmitEquality): Operands emit could be simplified for
1793 built-in types when we now emit user operators differently.
1795 2009-06-16 Marek Safar <marek.safar@gmail.com>
1797 * ecore.cs: Report inaccessible delegate methods correctly.
1799 2009-06-16 Marek Safar <marek.safar@gmail.com>
1801 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1802 cs-parser.jay: Implemented C# 4.0 optional parameters.
1804 2009-06-16 Marek Safar <marek.safar@gmail.com>
1806 * driver.cs: Removed broken DefineManifestResource.
1808 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1810 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1811 Use $(BOOTSTRAP_PROFILE) instead.
1813 2009-06-12 Jb Evain <jbevain@novell.com>
1815 * rootcontext.cs: add a Platform field.
1816 * driver.cs: handle /platform.
1817 * codegen.cs: pass the proper flags according to
1818 the platform when saving the assembly.
1820 2009-06-11 Marek Safar <marek.safar@gmail.com>
1822 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1823 Add optional parameters grammar.
1825 2009-06-10 Marek Safar <marek.safar@gmail.com>
1827 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1828 driver.cs: Split lang version and metadata version.
1830 2009-06-10 Marek Safar <marek.safar@gmail.com>
1832 * decl.cs: Better overload ctor collision error message.
1834 2009-06-05 Jb Evain <jbevain@novell.com>
1836 * driver.cs (EmbededResource): avoid using an internal method
1837 in gmcs to embed manifest resources.
1839 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1841 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1842 the compiler from older mono versions (like moon's bots)
1844 2009-06-04 Marek Safar <marek.safar@gmail.com>
1846 * namespace.cs (LookupTypeReflection): Ignore collisions between
1849 2009-06-04 Marek Safar <marek.safar@gmail.com>
1851 * codegen.cs: Enabled generic type forwarders.
1853 2009-06-04 Marek Safar <marek.safar@gmail.com>
1855 * dmcs.*: Add another version of SRE compiler.
1857 2009-06-03 Marek Safar <marek.safar@gmail.com>
1859 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1860 generic-mcs.cs: Fixed variant type conversions.
1862 2009-06-02 Marek Safar <marek.safar@gmail.com>
1864 A fix for bug #507863
1865 * codegen.cs: Fixes a crash on invalid string value attribute.
1867 2009-06-01 Marek Safar <marek.safar@gmail.com>
1869 A fix for bug #508334
1870 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1871 cs-parser.jay: Fully import __arglist modifier.
1873 2009-05-29 Marek Safar <marek.safar@gmail.com>
1875 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1876 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1877 actually work with closed generic types.
1879 2009-05-27 Alan McGovern <amcgovern@novell.com>
1881 * class.cs, decl.cs, delegate.cs, parameter.cs:
1882 Fix the build by replacing the use of 'var' with the actual type.
1884 2009-05-27 Marek Safar <marek.safar@gmail.com>
1886 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1887 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1890 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1893 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1894 Marek Safar <marek.safar@gmail.com>
1896 A fix for bug #377509
1897 * parameter.cs: Use predefined and not empty name for implicit
1900 2009-05-21 Marek Safar <marek.safar@gmail.com>
1902 * class.cs: Don't report wrong warnings for event fields.
1904 2009-05-21 Marek Safar <marek.safar@gmail.com>
1906 A fix for bug #504667
1907 * class.cs: Check for static class using parent container instead of
1910 2009-05-08 Marek Safar <marek.safar@gmail.com>
1912 A fix for bug #496922
1913 * expression.cs: Always use temporary variable when using object
1916 2009-04-28 Marek Safar <marek.safar@gmail.com>
1918 A fix for bug #495112
1919 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1922 2009-04-27 Miguel de Icaza <miguel@novell.com>
1924 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1926 2009-04-24 Miguel de Icaza <miguel@novell.com>
1928 * complete.cs: No idea how gonzalo got a null in the list, but
1931 2009-04-24 Miguel de Icaza <miguel@novell.com>
1933 * complete.cs (CompletionElementInitializer): New completion class
1934 to support completing inside a C# 3 element initializer, so this
1935 allows completion for Silverlight situations where it is very
1938 new TextBlock () { Fo<TAB>
1940 (CompletionSimpleName): Expose the prefix that was
1941 passed to the simple name.
1943 * cs-parser.jay (object_or_collection_initializer): Add support
1944 for element_initializers.
1946 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1947 special case completion expressions as this method aggressively
1948 collects data before it operates, and errors were being thrown
1949 earlier than we were able to complete.
1951 2009-04-23 Miguel de Icaza <miguel@novell.com>
1953 * eval.cs: Make getcompletions silent and enable debugging output
1954 if the -v option is passed.
1956 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1957 Consider looking up the namespace that matches the prefix being
1960 This is part of the support for allowing completions like:
1961 `System.Co<TAB>' to complete to System.Console.
1963 * complete.cs (CompletionSimpleName.AppendResults): Make this
1966 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1968 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1969 COMPLETE_COMPLETION as internal.
1971 2009-04-17 Miguel de Icaza <miguel@novell.com>
1973 * complete.cs: Include namespace resolution in simple names as
1974 well as global types and types in the using scope in the
1977 * namespace.cs: Supporting infrastrcture to provide completions
1978 based on the current using scope.
1980 * eval.cs: Introduce an entry point that allows for initialization
1981 to return a list of the files passed on the command line.
1983 2009-04-14 Marek Safar <marek.safar@gmail.com>
1985 A fix for bug #494243
1986 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1988 2009-04-13 Marek Safar <marek.safar@gmail.com>
1990 A fix for bug #493887
1991 * statement.cs: Don't skip string multi-section with default or
1992 null label when populating string hashtable.
1994 2009-04-06 Marek Safar <marek.safar@gmail.com>
1996 A fix for bug #492329
1997 * expression.cs (New): Load variable when assigning type parameter
2000 2009-04-06 Marek Safar <marek.safar@gmail.com>
2002 A fix for bug #488960
2003 * decl.cs: Compare MVAR types using non-null values.
2005 2009-03-27 Marek Safar <marek.safar@gmail.com>
2007 * typemanager.cs, expression.cs: Removed unused nullable checks.
2009 2009-03-27 Marek Safar <marek.safar@gmail.com>
2011 * *.cs: Removed some gmcs conditionals.
2013 2009-03-26 Marek Safar <marek.safar@gmail.com>
2015 * generic.cs, support.cs: Moved generics stuff out of support.cs
2017 2009-03-24 Marek Safar <marek.safar@gmail.com>
2019 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
2022 2009-03-23 Marek Safar <marek.safar@gmail.com>
2024 * attribute.cs: Consider all members for error reporting when
2025 checking named arguments.
2027 2009-03-23 Marek Safar <marek.safar@gmail.com>
2029 A fix for bug #487625
2030 * namespace.cs: Use a warning for all predefined type conflicts.
2032 2009-03-23 Marek Safar <marek.safar@gmail.com>
2034 A fix for bug #485706
2035 * statement.cs: Explicitly type catch type argument to pass verifier
2038 2009-03-22 Miguel de Icaza <miguel@novell.com>
2040 Initial support to provide code completion facilities to consumers
2041 of the evaluator API.
2043 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
2044 support the completion engine. When we reach the end of the
2045 input stream instead of returning EOF, when this flag is true the
2046 tokenizer instead produces:
2048 One GENERATE_COMPLETION token: this token then must be
2049 handled in the grammar at every point where the user
2050 would likely request a completion.
2052 As many COMPLETE_COMPLETION tokens as necessary. These
2053 tokens are generated to assist the parser in unwinding and
2054 producing a valid parse tree.
2056 The parser rules do not have to be perfect, the parser needs to be
2057 augmented with judicious use of GENERATE_COMPLETION tokens to
2058 improve the areas where we can provide completion and the parser
2059 needs to add support for COMPLETE_COMPLETION tokens in productions
2062 It is common to not have enough support for COMPLETE_COMPLETION
2063 under certain rules and that even if we generated the
2064 GENERATE_COMPLETION token that the resulting tree will be invalid
2065 due to the missing rules that support COMPLETE_COMPLETION.
2067 The final EOF token is produced by having the parser notify the
2068 tokenizer when it reaches the root production that the next token
2071 * support.cs (CompletionResult): New Exception. This exception
2072 is thrown to return the completion results when one of the special
2073 completion expressions is reached.
2075 This exception is thrown by the completing ExpressionStatements
2076 classes that live in complete.cs
2078 * complete.cs (CompletingExpression): a new base class for
2079 completing expressions. This derives from the
2080 ExpressionStatement class and not from Expression as it allows
2081 completion to happen not only where expressions are expected in
2082 the grammar, but also where statements are expected.
2084 (CompletionSimpleName): A new class used to provide completions
2085 for SimpleNames. This currently only resolves to local
2086 variables from the evaluator context (GetVars call).
2088 (CompletionMemberAccess): Implements support for completing member
2091 * cs-parser.jay: Add support for completion in a few places.
2093 * eval.cs (GetCompletions): New public API for the evaluator that
2094 returns a list of possible completions given the input. The
2095 return value is an array of completions
2097 * anonymous.cs (Compatible): If the exception thrown from the
2098 resolved expression is a CompletionResult exception let that one
2099 through instead of printing a diagnostic error in the try/catch.
2101 2009-03-22 Miguel de Icaza <miguel@novell.com>
2105 * driver.cs (Main): Use Environment.Exit to quit quickly and
2106 prevent the compiler from doing the usual wait for helper thread
2109 This is to prevent a slowdown that was reported by Gonzalo on
2112 2009-03-19 Marek Safar <marek.safar@gmail.com>
2114 * ecore.cs: Load build-in types directly instead of accessing
2117 2009-03-18 Marek Safar <marek.safar@gmail.com>
2119 * ecore.cs: Always use unbox.any when available.
2121 2009-03-18 Marek Safar <marek.safar@gmail.com>
2123 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
2125 2009-03-17 Marek Safar <marek.safar@gmail.com>
2127 * generic.cs: Removed obsolete version of type inference.
2129 2009-03-16 Marek Safar <marek.safar@gmail.com>
2131 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
2132 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
2133 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
2134 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
2136 2009-03-11 Marek Safar <marek.safar@gmail.com>
2138 A fix for bug #482996
2139 * anonymous.cs: Make sure we are not infering return type when
2140 checking type compatibility.
2142 2009-03-11 Marek Safar <marek.safar@gmail.com>
2144 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
2145 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
2146 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
2147 attributes in their own structure. Needed when accessing their
2148 properties before they are resolved.
2150 2009-03-09 Marek Safar <marek.safar@gmail.com>
2152 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
2153 hashtable (~10x faster).
2155 * driver.cs: Removed wrong Reset.
2157 2009-03-08 Marek Safar <marek.safar@gmail.com>
2159 * class.cs: Use correct common base type for unmanaged delayed
2162 * rootcontext.cs: Wrap unhandled exception.
2164 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
2166 Make SeekableStreamReader self-tuning and arbitrarily seekable
2167 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
2169 (SeekableStreamReader.Position.set): Use it. Simplify logic
2170 which, as a side-effect, makes it arbitrarily-seekable. Tune the
2171 buffer size when the stream needs to be re-read from the beginning.
2173 2009-03-05 Marek Safar <marek.safar@gmail.com>
2175 A fix for bug #480100
2176 * parameter.cs: A parameter is not hoisted when used directly as ET.
2178 2009-03-04 Marek Safar <marek.safar@gmail.com>
2180 * statement.cs: Fixed an issue when using variable is of interface
2183 2009-03-03 Marek Safar <marek.safar@gmail.com>
2185 A fix for bug #480319
2186 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
2188 2009-03-03 Marek Safar <marek.safar@gmail.com>
2190 A fix for bug #480867
2191 * typemanager.cs, expression.cs, ecore.cs: Changed method group
2192 expression to have no valid type.
2194 2009-03-03 Marek Safar <marek.safar@gmail.com>
2196 A fix for bug #481258
2197 * class.cs: Set extension method flag in partial container.
2199 2009-03-03 Marek Safar <marek.safar@gmail.com>
2201 * statement.cs, typemanager.cs: Use expression for StringEmitter.
2203 * attribute.cs: Add sanity check.
2205 2009-02-27 Marek Safar <marek.safar@gmail.com>
2207 * class.cs: Add external constructor error.
2209 2009-02-26 Marek Safar <marek.safar@gmail.com>
2211 A fix for bug #475354
2212 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
2213 correctly user defined nullable equality operators.
2215 2009-02-25 Marek Safar <marek.safar@gmail.com>
2217 A fix for bug #479532
2218 * expression.cs: Implement NewInitialize::AddressOf.
2220 2009-02-25 Marek Safar <marek.safar@gmail.com>
2222 A fix for bug #413633
2223 * expression.cs: Iterate all base class-constraint types.
2225 2009-02-24 Marek Safar <marek.safar@gmail.com>
2227 A fix for bug #479209
2228 * literal.cs: Mutate null underlying type.
2230 2009-02-24 Marek Safar <marek.safar@gmail.com>
2232 A fix for bug #476295
2233 * convert.cs: Avoid wrapping implicitly convertible reference type.
2235 2009-02-23 Marek Safar <marek.safar@gmail.com>
2237 * iterators.cs: Create MemberName correctly.
2239 2009-02-23 Marek Safar <marek.safar@gmail.com>
2241 A fix for bug #478655
2242 * literal.cs: Check also underlying null type conversion.
2244 2009-02-21 Marek Safar <marek.safar@gmail.com>
2246 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
2248 2009-02-20 Marek Safar <marek.safar@gmail.com>
2250 A fix for bug #477447
2251 * statement.cs: Add reference to correct parent storey when this
2252 is accessible from deep children storey (more than 1 level).
2254 2009-02-19 Marek Safar <marek.safar@gmail.com>
2256 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
2257 * class.cs: Define base type members before setting up member cache.
2259 2009-02-18 Marek Safar <marek.safar@gmail.com>
2261 A fix for bug #477378
2262 * nullable.cs, expression.cs, statement.cs: More precise null type
2265 2009-02-18 Marek Safar <marek.safar@gmail.com>
2267 A fix for bug #472805
2268 * typemanager.cs, namespace.cs: Import only visible extension method
2271 2009-02-18 Marek Safar <marek.safar@gmail.com>
2273 A fix for bug #476895
2274 * attribute.cs: Use correct resolve context for attribute type.
2276 2009-02-18 Marek Safar <marek.safar@gmail.com>
2278 A fix for bug #476266
2279 * anonymous.cs: Mutate multi-dimensional arrays.
2281 2009-02-18 Marek Safar <marek.safar@gmail.com>
2283 A fix for bug #476400
2284 * statement.cs, expression.cs: Removed wrong Dispose optimization.
2286 2009-02-18 Marek Safar <marek.safar@gmail.com>
2288 A fix for bug #476811
2289 * generics.cs: Fixed null-literal check.
2291 2009-02-17 Marek Safar <marek.safar@gmail.com>
2293 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
2294 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
2295 messing with static variables.
2297 2009-02-16 Marek Safar <marek.safar@gmail.com>
2299 A fix for bug #475965
2300 * generics.cs: Check generic parameter type after extracting from
2303 2009-02-16 Marek Safar <marek.safar@gmail.com>
2305 A fix for bug #475823
2306 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
2309 2009-02-14 Marek Safar <marek.safar@gmail.com>
2311 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
2312 Simplified event field definition using backing field and not
2313 field builder directly.
2315 * expression.cs (EmitLdArg): Optimize fast paths.
2317 2009-02-13 Marek Safar <marek.safar@gmail.com>
2319 A fix for bug #475327
2320 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2322 2009-02-13 Marek Safar <marek.safar@gmail.com>
2324 A fix for bug #475342
2325 * cs-parser.jay: Using 'super' instead of 'base' to call base
2326 constructor crashes compiler.
2328 2009-02-13 Marek Safar <marek.safar@gmail.com>
2330 A fix for bug #475354
2331 * expression.cs (Constantify): Add nullable types.
2333 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2335 2009-02-12 Marek Safar <marek.safar@gmail.com>
2337 A fix for bug #475246
2338 * expression.cs: More broken flowanalysis hacking needed.
2340 2009-02-12 Marek Safar <marek.safar@gmail.com>
2342 * attribute.cs: Compare only ref/out array modifiers.
2344 2009-02-11 Marek Safar <marek.safar@gmail.com>
2346 * statement.cs: Use member cache when looking for foreach members.
2348 2009-02-11 Marek Safar <marek.safar@gmail.com>
2350 * expression.cs: Don't expose internal initializer types.
2352 * statement.cs: Check also explicit conversions for goto case.
2354 2009-02-11 Marek Safar <marek.safar@gmail.com>
2356 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2358 2009-02-10 Marek Safar <marek.safar@gmail.com>
2360 * *.cs: Replace null-type with NullLiteral where appropriate.
2362 2009-02-09 Marek Safar <marek.safar@gmail.com>
2364 * expression.cs: Initializer of reference argument use temporary
2365 variable to be verifiable.
2367 * parameter.cs: Share EmitLdArg.
2369 2009-02-09 Marek Safar <marek.safar@gmail.com>
2371 A fix for bug #473559
2372 * class.cs: Fixed: Not reporting error about nested class with the
2375 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2377 Contributed under the MIT/X11 license.
2379 * generic.cs: Added VerifyVariantTypeParameters which performs new
2380 variance verification logic. The old logic, based on the spec, was
2381 wrong because the spec is full of LIES!
2383 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2385 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2388 * ecore.cs: Added calls to the new variance verification logic.
2391 * delegate.cs: Removed calls to the old variance verification logic.
2393 2009-02-06 Marek Safar <marek.safar@gmail.com>
2395 * delegate.cs: Use cached Invoke method directly.
2397 2009-02-06 Marek Safar <marek.safar@gmail.com>
2399 * expression.cs: Emit expression tree for hoisted variable access.
2401 2009-02-04 Marek Safar <marek.safar@gmail.com>
2403 * namespace.cs: Add better extension class check.
2405 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2407 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2409 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2411 This patch adds initial generic variance support to the compiler.
2412 It is contributed under the MIT/X11 license.
2414 * typemanager.cs: Modified ImplementsInterface to check variance.
2415 Added VerifyVariantTypeParameters which checks the specified type to see
2416 if it uses a variant type parameter as a type argument (which is not
2417 allowed). Added IsVariantOf which determins if the first type is a
2418 variant of the second. NOTE: This only supports reference types at
2419 the moment to conform with the current level of VM support. When the
2420 VM supports value types, this will follow step.
2422 * generic.cs: Added the Variance enum. Added a Variance property to
2423 TypeParameter and added variance support to definition phase. Added a
2424 Variance property to TypeParameterName. Also check to make sure that
2425 no variant types appear in generic method parameters.
2427 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2428 keywords if the langversion supports it.
2430 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2431 that variant types are only used in legal positions. Also added
2432 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2435 * decl.cs: Construct TypeParameter with the variance information.
2437 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2438 and ImplicitConversionStandard.
2440 * rootcontext.cs: Added new "Future" language version.
2442 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2443 type parameters are not used as type arguments in interface inheritance.
2444 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2445 parameters are not used as method return types. In MemberBase.
2446 ResolveMemberType, ensure that variant type parameters are not used
2447 as type arguments. Also call VerifyNoVariantTypeParameters on every
2448 set of parameters which are resolved.
2450 * delegate.cs: Modified Delegate.Define to ensure that variant
2451 parameters are not used as type arguments and that a contravariant
2452 parameter is not used as the return type. Also call
2453 VerifyNoVariantTypeParameters on the delegate parameters.
2455 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2456 to specify generic variance.
2458 * driver.cs: Added support for LanguageVersion.Future in the form of
2459 "-langversion:future".
2461 * generic-mcs.cs: Stubbed out new members in generic.cs.
2463 2009-02-03 Marek Safar <marek.safar@gmail.com>
2465 * class.cs, generic.cs: Emit type parameter constraints for nested
2468 2009-02-02 Marek Safar <marek.safar@gmail.com>
2470 A fix for bug #471213
2471 * class.cs: Avoid emitting backing field for abstract event fields.
2473 2009-02-01 Marek Safar <marek.safar@gmail.com>
2475 A fix for bug #359731
2476 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2479 2009-01-30 Marek Safar <marek.safar@gmail.com>
2481 A fix for bug #470767
2482 * statement.cs: Introduced BlockScopeExpression, needed when
2483 expression tree conversion has to emit scope variables.
2485 2009-01-29 Marek Safar <marek.safar@gmail.com>
2487 * class.cs: Remove duplicate CallingConvention.
2489 2009-01-29 Marek Safar <marek.safar@gmail.com>
2491 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2492 when I finally found the right naming convention.
2494 2009-01-29 Marek Safar <marek.safar@gmail.com>
2496 * cs-tokenizer.cs: Put back different open parens optimization.
2498 2009-01-28 Marek Safar <marek.safar@gmail.com>
2500 A fix for bug #470227
2501 * cs-tokenizer.cs: Remove too agressive parser optimization.
2503 2009-01-28 Marek Safar <marek.safar@gmail.com>
2505 A fix for bug #324319
2506 * class.cs: Remove too early base type resolve.
2508 2009-01-27 Marek Safar <marek.safar@gmail.com>
2510 A fix for bug #324319
2511 * ecore.cs: Explicitly type null when assigning to type argument to
2512 make pass verifier check.
2514 2009-01-27 Marek Safar <marek.safar@gmail.com>
2516 * anonymous.cs: Fixed recent regression when initializing captured
2519 2009-01-26 Marek Safar <marek.safar@gmail.com>
2521 A fix for bug #469019
2522 * anonymous.cs: Use all parent type parameters when instantiating
2523 nested generic storey.
2525 2009-01-26 Marek Safar <marek.safar@gmail.com>
2527 * expression.cs: Check for null instance methodgroup expression.
2529 2009-01-26 Marek Safar <marek.safar@gmail.com>
2531 A fix for bug #469244
2532 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2533 instance inside a conditional expression.
2535 2009-01-23 Marek Safar <marek.safar@gmail.com>
2537 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2538 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2539 GetElementType and HasElementType. IsValueType clean up.
2541 2009-01-23 Marek Safar <marek.safar@gmail.com>
2543 * nullable.cs: Use common EmitCall.
2545 * expression.cs: Emit constraint. for virtual calls only.
2547 2009-01-23 Marek Safar <marek.safar@gmail.com>
2549 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2550 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2551 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2554 2009-01-22 Jb Evain <jbevain@novell.com>
2556 * anonymous.cs: make anonymous types' ToString implementation
2557 match what csc outputs.
2559 2009-01-21 Marek Safar <marek.safar@gmail.com>
2561 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2564 2009-01-17 Marek Safar <marek.safar@gmail.com>
2566 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2569 2009-01-16 Marek Safar <marek.safar@gmail.com>
2571 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2574 2009-01-15 Marek Safar <marek.safar@gmail.com>
2576 A fix for bug #466634
2577 * statement.cs: Add reference for nested storey when only this
2580 2009-01-15 Marek Safar <marek.safar@gmail.com>
2582 A fix for bug #466474
2583 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2586 2009-01-15 Marek Safar <marek.safar@gmail.com>
2588 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2589 Fixed nested stories parent referencing process. Also fixes #463985.
2591 2009-01-06 Marek Safar <marek.safar@gmail.com>
2593 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2594 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2595 implementation. Also fixes #463108.
2597 2009-01-05 Marek Safar <marek.safar@gmail.com>
2599 A fix for bug #416109
2600 * decl.cs: Issue correct CLSAttribute warning location.
2602 2009-01-05 Marek Safar <marek.safar@gmail.com>
2604 A fix for bug #456775
2605 * attribute.cs: Use attribute owner scope when resolving attribute
2608 2009-01-05 Marek Safar <marek.safar@gmail.com>
2610 A fix for bug #457257
2611 * decl.cs: Fixed incorrect member declaring type comparison.
2613 2009-01-05 Marek Safar <marek.safar@gmail.com>
2615 A fix for bug #460896
2616 * driver.cs: Handle /RES resources as embeddable.
2618 2009-01-05 Marek Safar <marek.safar@gmail.com>
2620 A fix for bug #462515
2621 * ecore.cs: Report inacessible members upwards.
2623 2009-01-05 Marek Safar <marek.safar@gmail.com>
2625 A fix for bug #463190, #463192
2626 * decl.cs, namespace.cs: Also import internal extension classes.
2628 2009-01-04 Marek Safar <marek.safar@gmail.com>
2630 A fix for bug #463415
2631 * generic.cs: Use right index for RemoveDependentTypes.
2633 2009-01-02 Marek Safar <marek.safar@gmail.com>
2635 A fix for bug #463196
2636 * expression.cs: Fixed enum to null comparison.
2638 2009-01-02 Marek Safar <marek.safar@gmail.com>
2640 A fix for bug #463121
2641 * nullable.cs: Fixed nullable user equality operator comparison.
2643 2009-01-02 Marek Safar <marek.safar@gmail.com>
2645 A fix for bug #462950
2646 * class.cs, decl.cs: Use full explicit name when defining automatic
2647 property backing field.
2649 2009-01-02 Marek Safar <marek.safar@gmail.com>
2651 A fix for bug #462592
2652 * pending.cs: Emit type arguments for generic proxy method.
2654 2008-12-30 Marek Safar <marek.safar@gmail.com>
2656 * expression.cs (As): Mutate all type arguments.
2658 2008-12-29 Marek Safar <marek.safar@gmail.com>
2660 A fix for bug #462622
2661 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2664 2008-12-29 Marek Safar <marek.safar@gmail.com>
2666 A fix for bug #450782
2667 * ecore.cs: Consider more variables of form V.I to be fixed.
2669 2008-12-29 Marek Safar <marek.safar@gmail.com>
2671 A fix for bug #460712
2672 * typemanager.cs: Core types could be imported.
2674 2008-12-28 Marek Safar <marek.safar@gmail.com>
2676 A fix for bugs #460847, #460772, #458049, #457339, #447807
2677 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2678 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2679 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2680 user lambdas used inside query clauses.
2682 2008-12-18 Marek Safar <marek.safar@gmail.com>
2684 A fix for bug #460229
2685 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2687 2008-12-18 Marek Safar <marek.safar@gmail.com>
2689 A fix for bug #459952
2690 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2692 2008-12-18 Marek Safar <marek.safar@gmail.com>
2694 A fix for bug #459630
2695 * convert.cs: Enum to valuetype conversion is not allowed.
2697 2008-12-18 Marek Safar <marek.safar@gmail.com>
2699 A fix for bug #457087
2700 * generic.cs: Don't crash when constraint comes from type
2703 2008-12-16 Marek Safar <marek.safar@gmail.com>
2705 A fix for bug #459221
2706 * anonymous.cs, statement.cs: Delay only captured this
2709 2008-12-12 Marek Safar <marek.safar@gmail.com>
2711 A fix for bug #457489
2712 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2713 and initialization to capture scope initializers correctly.
2715 2008-12-11 Marek Safar <marek.safar@gmail.com>
2717 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2718 ParameterReference refactoring.
2720 2008-12-03 Marek Safar <marek.safar@gmail.com>
2722 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2723 to be imported from any assembly.
2725 2008-12-03 Marek Safar <marek.safar@gmail.com>
2727 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2728 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2729 from anonymous method and lambda expression.
2731 2008-12-01 Marek Safar <marek.safar@gmail.com>
2733 A fix for bug #448560
2734 * expression.cs (As): Box any generic type arguments to be
2737 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2739 Add tripwire for implicit conversion bugs
2740 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2742 (MethodGroupExpr.OverloadResolve): Add sanity check between
2743 IsApplicable and VerifyArgumentsCompat.
2744 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2746 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2748 Fix build break in System.Data_test
2749 * convert.cs (ImplicitConversionExists): Move NullLiteral
2751 (ImplicitStandardConversionExists): ... here.
2753 2008-11-28 Marek Safar <marek.safar@gmail.com>
2755 * literal.cs: Emit correctly explicit null to nullable cast.
2757 2008-11-28 Marek Safar <marek.safar@gmail.com>
2759 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2762 2008-11-28 Marek Safar <marek.safar@gmail.com>
2764 A fix for bug #449005
2765 * convert.cs, nullable.cs: Use only one implicit nullable
2768 2008-11-27 Marek Safar <marek.safar@gmail.com>
2770 * convert.cs, literal.cs: More Convert cleanup is needed.
2772 2008-11-27 Marek Safar <marek.safar@gmail.com>
2774 * decl.cs, class.cs: Fixed misleading error message.
2776 2008-11-26 Marek Safar <marek.safar@gmail.com>
2778 A fix for bug #449005
2779 * nullable.cs (EmitEquality): Disable optimization for user operator
2782 2008-11-25 Marek Safar <marek.safar@gmail.com>
2784 A fix for bug #447027
2785 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2786 with context variables stored as expression instances.
2788 2008-11-25 Marek Safar <marek.safar@gmail.com>
2790 A fix for bug #447027
2791 * delegate.cs: Fixed delegate VerifyMethod logic.
2793 2008-11-24 Marek Safar <marek.safar@gmail.com>
2795 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2798 2008-11-21 Marek Safar <marek.safar@gmail.com>
2800 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2801 member type resolve to follow normal flow, instead of random
2804 2008-11-21 Marek Safar <marek.safar@gmail.com>
2806 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2809 2008-11-21 Marek Safar <marek.safar@gmail.com>
2811 * const.cs: Emit decimal array constant as literal.
2813 2008-11-20 Marek Safar <marek.safar@gmail.com>
2815 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2817 2008-11-19 Marek Safar <marek.safar@gmail.com>
2819 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2820 into real property (saves 8 MB for corlib compilation).
2822 2008-11-19 Marek Safar <marek.safar@gmail.com>
2824 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2825 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2826 generic-mcs.cs: Small cleanup of TypeArguments.
2828 2008-11-18 Marek Safar <marek.safar@gmail.com>
2830 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2831 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2832 of ConstructedType expression, renamed to GenericTypeExpr.
2834 2008-11-17 Marek Safar <marek.safar@gmail.com>
2836 A fix for bug #445303
2837 * location.cs (IsConditionalDefined): Handle undefined global
2840 2008-11-17 Marek Safar <marek.safar@gmail.com>
2842 A fix for bug #444678
2843 * expression.cs (TryReduceConstant): Always create new constant
2846 2008-11-17 Marek Safar <marek.safar@gmail.com>
2848 A fix for bug #444673
2849 * ecore.cs: Ignore open generic types when used as generic type
2852 2008-11-17 Marek Safar <marek.safar@gmail.com>
2854 A fix for bug #445458
2855 * expression.cs, cs-parser.jay: Don't crash when an expression
2858 2008-11-17 Marek Safar <marek.safar@gmail.com>
2860 A fix for bug #445464
2861 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2862 inside unbound type.
2864 2008-11-14 Jb Evain <jbevain@novell.com>
2866 * driver.cs: ignore empty -nowarn argument such as
2867 the one in -nowarn:12,13,,.
2869 2008-11-13 Marek Safar <marek.safar@gmail.com>
2871 A fix for bug #444271
2872 * anonymous.cs: Rescan parent storeys when best candidate was
2875 2008-11-13 Marek Safar <marek.safar@gmail.com>
2877 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2878 useless UnboundTypeExpression.
2880 * attribute.cs: Do check obsolete attribute on generic types.
2882 2008-11-12 Marek Safar <marek.safar@gmail.com>
2884 A fix for bugs #425680, #400139
2885 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2888 2008-11-11 Marek Safar <marek.safar@gmail.com>
2890 A fix for bug #435747
2891 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2892 compound value types assignment. Few micro optimizations added.
2894 2008-11-10 Marek Safar <marek.safar@gmail.com>
2896 A fix for bug #442610
2897 * anonymous.cs (MutateConstructor): More SRE hacking.
2899 2008-11-10 Marek Safar <marek.safar@gmail.com>
2901 A fix for bug #442579
2902 * ecore.cs: Also initialize expanded form of a method with 1 params
2905 2008-11-06 Marek Safar <marek.safar@gmail.com>
2907 * expression.cs (UnaryMutator): Do early l-side check.
2909 2008-11-05 Miguel de Icaza <miguel@novell.com>
2911 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2912 Init, otherwise we would crash later on when checking for friend
2915 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2916 Otherwise we never get any meaningful information as to what
2919 2008-11-05 Marek Safar <marek.safar@gmail.com>
2921 A fix for bug #436318
2922 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2924 2008-11-05 Miguel de Icaza <miguel@novell.com>
2926 * namespace.cs: Turns out that it was a really bad idea to hide
2927 the errors for namespaces not found here in eval mode.
2929 * eval.cs: When we process using clauses, only enter those into
2930 the list of valid using clauses after they have been validated.
2932 The above change gives the proper semantics: it does not
2933 senselessly report the same errors with broken using statements by
2934 never storing them in the first place when they are invalid.
2936 2008-11-05 Marek Safar <marek.safar@gmail.com>
2938 A fix for bug #421839
2939 * cs-parser.jay: Remove expression from coalesce rule to force lower
2940 priority than the assignment operator.
2942 2008-11-05 Marek Safar <marek.safar@gmail.com>
2944 A fix for bug #437875
2945 * nullable.cs: Compile correctly method group operand used with null
2946 coalescing operator.
2948 2008-11-04 Marek Safar <marek.safar@gmail.com>
2950 A fix for bug #434589
2951 * expression.cs (Binary): Ignore lifted conversions when at least
2952 one operand is of reference type.
2954 2008-11-04 Marek Safar <marek.safar@gmail.com>
2956 * cs-parser.jay: Better syntax error report.
2958 2008-11-03 Marek Safar <marek.safar@gmail.com>
2960 A fix for bug #436792
2961 * cs-parser.jay: Use GetLocation to access location.
2963 2008-11-03 Marek Safar <marek.safar@gmail.com>
2965 A fix for bug #440774
2966 * cs-parser.jay: Also set current_array_type when parsing local
2969 2008-11-03 Marek Safar <marek.safar@gmail.com>
2971 A fix for bug #440785
2972 * expression.cs (As): Don't resolve self modifing expression
2975 2008-11-03 Marek Safar <marek.safar@gmail.com>
2977 A fix for bug #439447
2978 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2980 2008-11-03 Marek Safar <marek.safar@gmail.com>
2982 A fix for bug #437571
2983 * cs-parser.jay: Fixes internal error for invalid expression
2986 2008-10-17 Marek Safar <marek.safar@gmail.com>
2988 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2990 2008-10-17 Marek Safar <marek.safar@gmail.com>
2992 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2994 2008-10-17 Marek Safar <marek.safar@gmail.com>
2996 * cs-tokenizer.cs: More precise cast parsing.
2998 2008-10-16 Martin Baulig <martin@ximian.com>
3000 * anonymous.cs (AnonymousMethodStorey): Put back the
3001 `hoisted_locals' hashtable and use it in EmitType().
3003 2008-10-15 Marek Safar <marek.safar@gmail.com>
3005 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
3006 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
3009 2008-10-14 Marek Safar <marek.safar@gmail.com>
3011 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
3013 2008-10-14 Marek Safar <marek.safar@gmail.com>
3015 * statement.cs: Mutate scope initializers.
3017 2008-10-14 Marek Safar <marek.safar@gmail.com>
3019 * expression.cs: Use typeless value for This constant.
3021 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
3023 2008-10-14 Marek Safar <marek.safar@gmail.com>
3025 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
3028 2008-10-13 Marek Safar <marek.safar@gmail.com>
3030 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
3033 2008-10-13 Marek Safar <marek.safar@gmail.com>
3035 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
3036 parser and tokenizer. Fixes many ambiguities including #433258.
3038 2008-10-10 Marek Safar <marek.safar@gmail.com>
3040 * cs-parser.jay: Fixed missing accessor recovery.
3042 2008-10-10 Marek Safar <marek.safar@gmail.com>
3044 A fix for bug #433701
3045 * expression.cs: Better error message.
3047 2008-10-10 Marek Safar <marek.safar@gmail.com>
3049 * cs-parser.jay, expression.cs: Start reporting real parser errors.
3051 * Makefile: Disabled unused debug symbols.
3053 Also fixes: #320556, #321097, #321656, #321876, #351316
3055 2008-10-09 Miguel de Icaza <miguel@novell.com>
3057 * eval.cs: rename "<interactive>" to "{interactive}", to work
3058 around a requirement in the compiler that this be a valid
3059 filename, and in Windows it is not (433886).
3061 2008-10-09 Marek Safar <marek.safar@gmail.com>
3063 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
3065 2008-10-08 Marek Safar <marek.safar@gmail.com>
3067 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
3068 cs-parser.jay: Generic type declaration and type arguments cleanup.
3070 2008-10-05 Marek Safar <marek.safar@gmail.com>
3072 * cs-parser.jay: Allow parsing weird array creation construct.
3074 2008-10-05 Marek Safar <marek.safar@gmail.com>
3076 * cs-parser.jay: Conflicts reduction.
3078 2008-10-04 Marek Safar <marek.safar@gmail.com>
3080 * cs-parser.jay: Conflicts reduction.
3082 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
3085 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
3086 property. Add a 'count' hint about the use of the shared vector.
3087 Ensure that we don't leak out dirty bits.
3088 (UsageVector.MergeChild): Throw away information about variables
3090 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
3092 2008-10-03 Marek Safar <marek.safar@gmail.com>
3094 A fix for bug #431746
3095 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
3096 parameters when iterator is created.
3098 2008-10-03 Marek Safar <marek.safar@gmail.com>
3100 A fix for bug #431827
3101 * expression.cs: Fixed right based pointer arithmetic operations
3104 2008-10-03 Marek Safar <marek.safar@gmail.com>
3106 A fix for bug #353779
3107 * assign.cs, expression.cs: Fixed compound assignment conversions.
3109 2008-10-02 Marek Safar <marek.safar@gmail.com>
3111 A fix for bug #375262
3112 * statement.cs: Refactor ArrayForeach to be usable with string
3113 indexer. Optimized single dimentional arrays foreach.
3115 2008-10-02 Marek Safar <marek.safar@gmail.com>
3117 A fix for bug #431255
3118 * anonymous.cs, expression.cs: Removed broken optimization.
3120 2008-10-01 Marek Safar <marek.safar@gmail.com>
3122 * anonymous.cs: Use full type parameters of parent generic
3123 containers. Removed unnecessary AddParentStoreyReference call.
3125 2008-10-01 Marek Safar <marek.safar@gmail.com>
3127 A fix for bug #324702
3128 * class.cs: Use better shorter names for explicit interface member
3131 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
3133 2008-10-01 Marek Safar <marek.safar@gmail.com>
3135 * expression.cs: Use new interface to check fixed expression.
3137 2008-10-01 Marek Safar <marek.safar@gmail.com>
3139 A fix for bug #421101
3140 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
3141 interface to check for fixed fixed-buffers.
3143 2008-10-01 Marek Safar <marek.safar@gmail.com>
3145 A fix for bug #429264
3146 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
3148 * delegate.cs: Removed unnecessary casts.
3150 2008-09-30 Marek Safar <marek.safar@gmail.com>
3152 A fix for bug #352151
3153 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
3154 class.cs: Fixed already defined explicit interface members check.
3156 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
3158 cs-tokenizer.cs: Fix typo.
3160 2008-09-28 Miguel de Icaza <miguel@novell.com>
3162 * eval.cs (InteractiveBase): The quit command now just sets a
3163 flag, instead of calling Environment.Exit(), it is milder on
3166 CompiledMethod is now in Mono.CSharp, not nested inside
3167 the Evaluator, it was inconvenient to use.
3169 2008-09-27 Miguel de Icaza <miguel@novell.com>
3171 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
3172 code to be invoked without having to reparse.
3174 2008-09-27 Miguel de Icaza <miguel@novell.com>
3176 * ecore.cs: The recent changes to FieldExpr broke this as well.
3177 Fixes LINQ queries in the interactive shell.
3179 * Multiple files: indentation fixing for the Mono coding
3180 guidelines for the switch statement.
3182 * eval.cs: Make the Evaluator API thread safe.
3184 2008-09-26 Marek Safar <marek.safar@gmail.com>
3186 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
3187 constructor parsing.
3189 2008-09-26 Marek Safar <marek.safar@gmail.com>
3191 A fix for bug #325326
3192 * statement.cs: Check possible mistaken empty statement using
3193 explicit blocks only.
3195 2008-09-25 Miguel de Icaza <miguel@novell.com>
3197 * eval.cs (LoadAssembly, ReferenceAssembly): Call
3198 RootNamespace.ComputeNamespaces to update the internal list of
3199 namespaces, this is no longer done for us.
3201 (InteractiveBase): Use the Evaluator APIs instead of calling into
3204 2008-09-25 Marek Safar <marek.safar@gmail.com>
3206 A fix for bug #429264
3207 * expression.cs: Missing mutator for access to multidimensional
3210 2008-09-25 Marek Safar <marek.safar@gmail.com>
3212 * class.cs, statement: Emit DebuggerHidden attribute for iterator
3215 * driver.cs: Missing input argument check.
3217 2008-09-25 Marek Safar <marek.safar@gmail.com>
3219 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
3220 expression.cs, statement.cs, rootcontext.cs, class.cs,
3221 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
3224 2008-09-24 Miguel de Icaza <miguel@novell.com>
3226 * ecore.cs (FieldExpr): Only initialize eclass when we return a
3227 fully constructed FieldExpr, fixes the regression introduced in
3230 * ecore.cs, expression.cs: Plug back the eclass initialization as
3231 otherwise it regresses `csharp'.
3233 2008-09-24 Marek Safar <marek.safar@gmail.com>
3235 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
3236 ecore.cs, attribute.cs: Moved obsolete method checks from emit
3237 phase to resolve phase. It resolves problems with expression trees
3238 and fixes bugs #323796, #325156.
3240 2008-09-23 Marek Safar <marek.safar@gmail.com>
3242 * codegen.cs: Report better error when symbol writer is missing.
3244 2008-09-23 Marek Safar <marek.safar@gmail.com>
3246 * codegen.cs: Set .NET symbol writer.
3248 * decl.cs: Guard against null generic arguments.
3250 * report.cs: Don't report exactly same additional details.
3252 2008-09-22 Marek Safar <marek.safar@gmail.com>
3254 A fix for bug #324917
3255 * cs-parser.jay: Add missing multidimensional non-expression type
3258 2008-09-22 Marek Safar <marek.safar@gmail.com>
3260 A fix for bug #428191
3261 * anonymous.cs: Create an outer generic fields also for non-storey
3264 2008-09-22 Marek Safar <marek.safar@gmail.com>
3266 A fix for bug #378294
3267 * class.cs: Make fixed size buffers gmcs feature only.
3269 2008-09-22 Marek Safar <marek.safar@gmail.com>
3271 A fix for bug #355622, #324993
3272 * assign.cs, const.cs, class.cs: Create new EmitContext for each
3275 2008-09-19 Marek Safar <marek.safar@gmail.com>
3277 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
3280 2008-09-19 Marek Safar <marek.safar@gmail.com>
3282 A fix for bug #416110
3283 * generic.cs: Struct constraint results in default ctor and
3284 ValueType base type constraint to be set.
3286 2008-09-19 Marek Safar <marek.safar@gmail.com>
3288 A fix for bug #423791
3289 * generic.cs: Fixed params output type type-inference.
3291 2008-09-19 Marek Safar <marek.safar@gmail.com>
3293 * cs-parser.jay, expression.cs: Fixed few expression crashes.
3295 2008-09-19 Marek Safar <marek.safar@gmail.com>
3297 * cs-tokenizer.cs: Don't break on extra partial modifier.
3299 2008-09-19 Marek Safar <marek.safar@gmail.com>
3301 A fix for bug #427592
3302 * generic.cs: Use common parameter resolve method.
3304 2008-09-18 Marek Safar <marek.safar@gmail.com>
3306 A fix for bug #414758
3307 * expression.cs, ecore.cs: Fixed crash when accessing non-static
3310 2008-09-18 Marek Safar <marek.safar@gmail.com>
3312 * driver.cs, namespace.cs: Read types and namespaces after all
3313 requested assemblies are loaded, fixes issues with System.Core
3314 auto-reference, and #419888.
3316 2008-09-18 Marek Safar <marek.safar@gmail.com>
3318 A fix for bug #417705
3319 * cs-parser.jay: Fixed as/is operator expression split.
3321 2008-09-18 Marek Safar <marek.safar@gmail.com>
3323 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3324 Fixed expression tree representation of empty new expression and
3325 new initializer expression.
3327 2008-09-18 Miguel de Icaza <miguel@novell.com>
3329 * eval.cs: Remove warning, keep reference to driver around.
3331 * Hide fields that do not need to be public.
3333 2008-09-17 Marek Safar <marek.safar@gmail.com>
3335 A fix for bug #426385
3336 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3337 conversion for array elements.
3339 2008-09-17 Marek Safar <marek.safar@gmail.com>
3341 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3342 void parsing conflicts.
3344 2008-09-15 Marek Safar <marek.safar@gmail.com>
3346 A fix for bug #425601
3347 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3348 System.Core only when there is no custom ExtensionAttribute
3351 2008-09-15 Miguel de Icaza <miguel@novell.com>
3353 * namespace.cs: Do not report CS0246 (name
3355 2008-09-12 Marek Safar <marek.safar@gmail.com>
3357 A fix for bug #425669
3358 * generic.cs: Don't cache generic static anonymous method
3361 2008-09-12 Marek Safar <marek.safar@gmail.com>
3363 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3364 conflicting constraints.
3366 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3368 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3371 2008-09-12 Marek Safar <marek.safar@gmail.com>
3373 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3374 to null pointer conversion fixes.
3376 2008-09-11 Marek Safar <marek.safar@gmail.com>
3378 * cs-parser.jay, expression.cs: An implicitly typed local variable
3379 declarator cannot use an array initializer.
3381 2008-09-11 Marek Safar <marek.safar@gmail.com>
3383 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3385 2008-09-11 Marek Safar <marek.safar@gmail.com>
3387 * generic.cs (InflatedConstraints): Don't crash when constraints
3390 * cs-parser.jay: const_declarator is a block.
3392 * constant.cs: Check for not allowed NaN conversions.
3394 2008-09-10 Miguel de Icaza <miguel@novell.com>
3396 * driver.cs: Drop --shell argument, the compiler is no longer a
3399 * eval.cs: Move most of the code that deals with evaluation into
3400 this file and document the public API from repl.cs
3402 * repl.cs: Remove from here.
3404 2008-09-10 Marek Safar <marek.safar@gmail.com>
3406 A fix for bug #424684
3407 * generic.cs: Generic class constraints must come first.
3409 2008-09-09 Miguel de Icaza <miguel@novell.com>
3411 * cs-parser.jay: Improve error reporting for syntax errors in
3412 statements and expressions, we now report the expected tokens
3413 instead of reporting the useless "; expected".
3415 Drop the strings from the token declaration, it turns out that
3416 they did not do what I thought they did. Instead they were adding
3417 two sets of tokens to the tables.
3419 2008-09-09 Marek Safar <marek.safar@gmail.com>
3421 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3422 delegate.cs: Share special type check.
3424 2008-09-09 Marek Safar <marek.safar@gmail.com>
3426 A fix for bug #423981
3427 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3429 2008-09-09 Marek Safar <marek.safar@gmail.com>
3431 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3434 2008-09-09 Marek Safar <marek.safar@gmail.com>
3436 A fix for bugs: #324750, #335946
3437 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3438 lookup rule to determine ?-based tokens.
3440 2008-09-08 Miguel de Icaza <miguel@novell.com>
3442 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3443 expressions (like event adding or removing) end up here, so we
3444 need to treat those as statements.
3446 Add LoadAssembly method.
3448 2008-09-04 Miguel de Icaza <miguel@novell.com>
3450 * repl.cs: Add Time method.
3452 2008-09-05 Marek Safar <marek.safar@gmail.com>
3454 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3456 2008-09-05 Miguel de Icaza <miguel@novell.com>
3458 * repl.cs: Add workaround for old compilers.
3460 2008-09-04 Jb Evain <jbevain@novell.com>
3462 * repl.cs (PrettyPrint): pretty print everything that
3463 implements IDictionary, as well as IEnumerables. Also,
3464 add a quit helper property.
3466 2008-09-04 Marek Safar <marek.safar@gmail.com>
3468 * constant.cs: Better error reporting for decimal literals.
3470 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3473 2008-09-04 Marek Safar <marek.safar@gmail.com>
3474 Miguel de Icaza <miguel@novell.com>
3476 A fix for bug #422951
3477 * assign.cs (Assign.DoResolve): Perform the type conversions
3478 checks before we attempt to initialize `New' initializers.
3480 2008-09-04 Marek Safar <marek.safar@gmail.com>
3482 A fix for bug #422853
3483 * delegate.cs (DelegateCreation): Add special handling for
3484 EmptyExpression.Null instance expression which is just another
3485 hack for undecided member instance exression.
3487 2008-09-04 Marek Safar <marek.safar@gmail.com>
3489 * expression.cs, ecore.cs: Emit full expression tree for reduced
3492 2008-09-04 Marek Safar <marek.safar@gmail.com>
3494 * expression.cs (This): Guard against multi-resolving.
3496 * ecore.cs, statement.cs (Throw): Simplified.
3498 * flowanalysis.cs: Also verify event fields.
3500 2008-09-04 Miguel de Icaza <miguel@novell.com>
3502 * assign.cs (Assign.DoResolve): Perform the type conversions
3503 checks before we attempt to initialize `New' initializers.
3505 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3507 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3510 * repl.cs: Update help.
3512 2008-09-03 Miguel de Icaza <miguel@novell.com>
3514 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3515 handling of the default config handling, including the special
3516 treatment of System.Core assembly.
3518 Fixes the REPL processing for LINQ.
3520 2008-09-03 Marek Safar <marek.safar@gmail.com>
3522 A fix for bug #422507
3523 * expression.cs (UnboxCast): Add missing child expression mutator.
3525 2008-09-03 Marek Safar <marek.safar@gmail.com>
3527 * driver.cs: Don't self reference System.Core assembly.
3529 2008-09-03 Marek Safar <marek.safar@gmail.com>
3531 A fix for bug #422507
3532 * expression.cs (StringConcat): Add missing type mutator.
3534 2008-09-03 Marek Safar <marek.safar@gmail.com>
3536 * generic.cs (TypeInferenceContext): Follow equality rule for
3537 constructed type lower bound type inference.
3539 2008-09-02 Miguel de Icaza <miguel@novell.com>
3541 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3542 <dblank@cs.brynmawr.edu> which updates the cursor position on
3545 2008-09-02 Marek Safar <marek.safar@gmail.com>
3547 A fix for bug #367145
3548 * driver.cs: Fixed import of extension methods when using -noconfig
3551 2008-09-02 Marek Safar <marek.safar@gmail.com>
3553 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3554 version from non-generic implementation instead.
3556 2008-09-01 Marek Safar <marek.safar@gmail.com>
3558 A fix for bug #418908
3559 * class.cs: Use AddScopeStatement for field initializers.
3561 2008-09-01 Marek Safar <marek.safar@gmail.com>
3563 A fix for bug #415385
3564 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3566 2008-09-01 Marek Safar <marek.safar@gmail.com>
3568 A fix for bug #421736
3569 * iterators.cs: Don't crash on unreachable iterators.
3571 2008-09-01 Marek Safar <marek.safar@gmail.com>
3573 A fix for bug #421628
3574 * parameter.cs, attribute.cs: Clone also parameter attributes.
3576 2008-08-30 Miguel de Icaza <miguel@novell.com>
3578 * namespace.cs (LookupType): In EvalMode, try to replace
3579 the TypeBuilder from our cache with a Type as Reflection.Emit does
3580 not like to mix code from older assemblies emitted and new
3583 This sounds like a serious Mono bug that prevents multiple
3584 assemblies to be generated and consumed at the same time.
3586 * cs-parser.jay (push_current_class): Do not make interactive
3587 classes internal or private, make them public as we currently
3588 generate each new class in a new assembly.
3590 2008-08-29 Miguel de Icaza <miguel@novell.com>
3592 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3593 remove types that are entered into the global namespace during
3594 parsing so that we can remove them on failure.
3596 * cs-parser.jay: Parsing: we now keep track of types that are
3597 entered into global variables and queue those in case the parsing
3600 This happens in a few situations: during partial-input, we invoke
3601 the parser repeatedly for example with the string "class X", this
3602 would cause X to be registed, and we need to remove this
3603 registration so that another parse attempt later with say "class X {"
3604 would actually work.
3606 Additionally, if there is an error in the resolution phase, for
3607 example: "class X : NonExistant {}" th
3609 * cs-parser.jay: Be more precise with the errors being raised,
3610 instead of flagging all exceptions during parsing to be attributed
3611 to the parsing process, distinguish those from errors happening in
3612 the actions and hint that using -v would produce the actual
3615 * repl.cs: Do not load all compiler references on each reset,
3616 doing the partial reset takes care of this.
3618 2008-08-28 Miguel de Icaza <miguel@novell.com>
3620 * repl.cs: Add support for loading all the files from
3621 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3624 Introduce a micro-parser that is able to deambiguate on its input
3625 whether we are dealing with a compilation unit (namespace, class,
3626 interface, struct, delegate) declaration or a statement. This
3627 allows both declarations and statements to be entered.
3629 Set history size by default to 300 lines.
3631 Instead of distinguishing based on the parser.InteractiveResult,
3632 have only two cases: statements were parsed, or a compilation unit
3633 was. Always pull the Using statement additions from the
3634 compilation unit parse.
3636 * cs-tokenizer.cs: Rename tokens to better describe their intent
3637 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3639 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3640 EvalMode is used to trigger the lookup of global variables while
3641 StatementMode is used turn variable declarations into static
3644 * getline.cs: Allow history size to be set.
3646 2008-08-29 Marek Safar <marek.safar@gmail.com>
3648 A fix for bug #360755
3649 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3651 2008-08-29 Marek Safar <marek.safar@gmail.com>
3653 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3655 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3656 member name, it is too confusing
3658 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3660 * rootcontext.cs: Finally default to warning level 4.
3662 2008-08-28 Marek Safar <marek.safar@gmail.com>
3664 * class.cs (CheckBase): Ignore overloaded operators.
3666 2008-08-28 Marek Safar <marek.safar@gmail.com>
3668 A fix for bug #420830
3669 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3671 2008-08-28 Marek Safar <marek.safar@gmail.com>
3673 A fix for bug #420832
3674 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3676 2008-08-28 Marek Safar <marek.safar@gmail.com>
3678 A fix for bug #420386
3679 * nullables.cs: Fixed logic of nullable user comparison operators involving
3682 2008-08-28 Marek Safar <marek.safar@gmail.com>
3684 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3686 2008-08-27 Miguel de Icaza <miguel@novell.com>
3688 * repl.cs: Add support for aborting the running code with C-c.
3690 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3692 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3694 2008-08-27 Miguel de Icaza <miguel@novell.com>
3696 * cs-parser.jay (interactive_statement_list): A new set of rules
3697 for hosting statements that uses the "interactive_" prefix.
3699 * repl.cs: Add support for parsing `using' as a statement or as a
3700 directive. Deambiguating before passing this to the parser.
3702 We need to distinguish statement_expressions that occur at the
3703 toplevel vs those that occur embedded into expressions.
3705 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3706 that fixes the cursor key handling, and a history bug.
3708 2008-08-26 Miguel de Icaza <miguel@novell.com>
3710 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3711 limitations in Console, instead the 2.0 bootstrap libraries now
3712 include the Console bits.
3714 Also, remove the use of Nullables from getline.cs
3718 Interactive support for the C# compiler. Use gmcs --shell to
3719 enter a read-eval-print loop shell.
3721 Docs: http://www.mono-project.com/CsharpRepl
3723 * sources: include repl.cs here and getline.cs for gmcs.exe,
3724 everything else is getline.cs impaired.
3726 * Makefile: when bootstrapping pass a special flag
3727 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3728 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3729 This distinguishes those two cases.
3731 * repl.cs: Support for a read-eval-print loop. Will be soon
3732 refactored into eval support and then REPL on top of it.
3734 * ecore.cs: If a simplename lookup fails, before erroring out,
3735 if we are in EvalMode to resolve the name to a declaration in the
3738 This means that variable declarations that happened in previous
3739 classes (as repl puts every statement in a separate class) are
3740 made visible in this way.
3742 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3743 triggered an error due to the end of file being reached. This is
3744 used to do multi-line input, and notify the caller that the user
3745 needs to provide more text before a successful parse.
3747 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3748 to drive the evaluation with a custom wrapper.
3750 * driver.cs: Add support for --shell, and refactor some code to be
3753 * namespace.cs: Add support for serializing the contents of the
3754 namespaces and reloading them.
3756 * getline.cs: A managed implementation of ReadLine under
3757 X11/Apache2 license terms. Easy to embed in other applications as
3760 * namespace.cs: Add some functions to save and restore the
3763 * rootcontext.cs: New public field.
3765 * cs-tokenizer.cs: Add support for one of the possible characters
3766 we introduce into the token stream.
3768 This patch does not affect the regular tokenization process, the
3769 only performance hit would happen if there is an invalid character
3770 on the input string.
3772 * support.cs: Move isatty helper routine here.
3774 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3775 code generator for in-memory assemblies.
3777 2008-08-26 Marek Safar <marek.safar@gmail.com>
3779 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3780 parameter cannot be always used as a type.
3782 2008-08-21 Marek Safar <marek.safar@gmail.com>
3784 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3786 2008-08-21 Marek Safar <marek.safar@gmail.com>
3788 * convert.cs: Implement explicit array to IList<T> conversion.
3790 2008-08-20 Marek Safar <marek.safar@gmail.com>
3792 A fix for bug #362740
3793 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3795 2008-08-20 Marek Safar <marek.safar@gmail.com>
3797 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3798 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3799 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3800 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3801 handling to use just one type of infrastructure and deal with generics
3804 2008-07-23 Martin Baulig <martin@ximian.com>
3806 *** Merged this from trunk revision 108527 ***
3809 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3810 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3813 2008-08-15 Marek Safar <marek.safar@gmail.com>
3815 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3818 2008-08-15 Marek Safar <marek.safar@gmail.com>
3820 * delegate.cs: Fixed compiler crash when creating delegate using partial
3823 * typemanager.cs: MulticastDelegate is not a delegate.
3825 2008-08-14 Marek Safar <marek.safar@gmail.com>
3827 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3830 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3832 * cs-parser.jay (type): Allow 'var' in mcs too.
3833 (local_variable_type): Likewise.
3835 2008-08-14 Marek Safar <marek.safar@gmail.com>
3837 * driver.cs: Removed broken -noconfig variants.
3839 2008-08-14 Marek Safar <marek.safar@gmail.com>
3841 A fix for bug #417078
3842 * expression.cs: Emit correctly left side pointer operators.
3844 2008-08-13 Marek Safar <marek.safar@gmail.com>
3846 * generic.cs, lambda.cs: Inflate method generic arguments only.
3848 2008-08-12 Marek Safar <marek.safar@gmail.com>
3850 * class.cs: Fixed struct layout check regression.
3852 2008-08-12 Marek Safar <marek.safar@gmail.com>
3854 * cs-parser.jay, enum.cs: Simplified enum parsing.
3856 * decl.cs: Check all type parameters conflicts.
3858 * expression.cs, statement.cs, attribute.cs: More expression checks.
3860 2008-08-11 Marek Safar <marek.safar@gmail.com>
3862 * generic.cs: Add type inference types restriction.
3864 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3865 anonymous.cs, expression.cs: Allocate less accessor parameters.
3867 2008-08-08 Marek Safar <marek.safar@gmail.com>
3869 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3872 2008-08-08 Marek Safar <marek.safar@gmail.com>
3874 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3876 2008-08-07 Marek Safar <marek.safar@gmail.com>
3878 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3879 Also fixes #362146 and #381592.
3881 2008-08-07 Marek Safar <marek.safar@gmail.com>
3883 * ecore.cs: Reduced constant cannot be used as an attribute value.
3885 * cs-parser.jay: Base expression has to be a type.
3887 * expression.cs (Conditional): Uses ReducedExpression.
3889 2008-08-06 Marek Safar <marek.safar@gmail.com>
3891 A fix for bug #376826
3892 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3893 address of hoisted local variable or parameter cannot be taken.
3895 2008-08-05 Marek Safar <marek.safar@gmail.com>
3897 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3898 anonymous method inside checked/unchecked expression.
3900 2008-08-05 Marek Safar <marek.safar@gmail.com>
3902 * typemanager.cs (IsEqual): Guard against null.
3904 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3905 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3906 routine. Fixed few misleading conversion errors.
3908 2008-08-04 Marek Safar <marek.safar@gmail.com>
3910 * class.cs: Consider generics when checking cycles in struct layout.
3912 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3914 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3916 2008-08-04 Marek Safar <marek.safar@gmail.com>
3918 A fix for bug #414165
3919 * anonymous.cs: Use same anonymous implementation method for all anonymous
3922 2008-08-04 Marek Safar <marek.safar@gmail.com>
3924 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3927 2008-08-04 Marek Safar <marek.safar@gmail.com>
3929 * cs-parser.jay: Typeof argument has to be a type expression.
3931 * namespace.cs: Check alias and namespace definitions collisions.
3933 * class.cs, pending.cs: Moved explicit interface accessor implementation
3936 * delegate.cs, expression.cs: Verify special name invocations.
3938 2008-08-01 Marek Safar <marek.safar@gmail.com>
3940 * cs-parser.jay: Don't choke on empty generic type arguments.
3942 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3944 * expression.cs, ecore.cs: Minor expressions bugs.
3946 2008-08-01 Marek Safar <marek.safar@gmail.com>
3948 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3949 and added more error handling.
3951 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3953 * modifiers.cs, enum.cs: Fixed.
3955 2008-07-31 Jb Evain <jbevain@novell.com>
3957 * driver.cs: remove -pkg ability of smcs.
3959 2008-07-30 Marek Safar <marek.safar@gmail.com>
3961 * statement.cs (Switch): Correctly set empty default target for single
3964 2008-07-30 Marek Safar <marek.safar@gmail.com>
3966 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3967 string switch statement implementation to use string dictionary which
3968 significantly (2-8x) improves performance of generated code.
3970 2008-07-29 Marek Safar <marek.safar@gmail.com>
3972 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3973 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3975 2008-07-29 Marek Safar <marek.safar@gmail.com>
3977 A fix for bug #412595
3978 * typemanager.cs, convert.cs, expression.cs: Some types are never
3979 convertible to each other.
3981 2008-07-29 Marek Safar <marek.safar@gmail.com>
3983 * nullable.cs (CreateNullConstant): An error messages update.
3985 2008-07-29 Marek Safar <marek.safar@gmail.com>
3987 A fix for bug #412595
3988 * cfold.cs: Don't cast undefined bool constant.
3990 2008-07-29 Martin Baulig <martin@ximian.com>
3993 (SymbolWriter.Reset): New public static method.
3996 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3998 2008-07-28 Marek Safar <marek.safar@gmail.com>
4000 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
4002 * expression.cs (ElementAccess): Exact size allocation.
4004 2008-07-26 Marek Safar <marek.safar@gmail.com>
4006 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
4008 2008-07-25 Marek Safar <marek.safar@gmail.com>
4010 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
4012 * class.cs: Removed $PRIVATE$ field hack which caused problems during
4015 2008-07-25 Marek Safar <marek.safar@gmail.com>
4017 A fix for bug #412217
4018 * assign.cs: Mutate also assignment type.
4020 2008-07-25 Marek Safar <marek.safar@gmail.com>
4022 A fix for bug #323644
4023 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
4026 2008-07-25 Marek Safar <marek.safar@gmail.com>
4028 A fix for bug #412134
4029 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
4030 non-enumerable operands when overloading equality or bitwise operators.
4032 2008-07-25 Marek Safar <marek.safar@gmail.com>
4034 * anonymous.cs: Cache closed generic anonymous method delegates.
4036 2008-07-24 Marek Safar <marek.safar@gmail.com>
4038 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
4039 anonymous.cs, statement.cs: Always emit anonymous method as static method
4040 when is instance free. Use nesting for nested anynomous methods blocks.
4042 2008-07-23 Marek Safar <marek.safar@gmail.com>
4044 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
4047 2008-07-23 Marek Safar <marek.safar@gmail.com>
4049 * expression.cs: Removed MakeSimpleCall.
4051 2008-07-23 Marek Safar <marek.safar@gmail.com>
4053 A fix for bug #323012
4054 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
4055 Base method implementing interface has to be public.
4057 2008-07-23 Marek Safar <marek.safar@gmail.com>
4059 * cs-parser.jay: Don't break on missing argument.
4061 2008-07-22 Marek Safar <marek.safar@gmail.com>
4063 A fix for bug #320993
4064 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
4065 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
4067 2008-07-22 Marek Safar <marek.safar@gmail.com>
4069 A fix for bug #320748
4070 * convert.cs: Implicit user operators cannot convert to interfaces
4072 2008-07-22 Marek Safar <marek.safar@gmail.com>
4074 A fix for bug #312686
4075 * driver.cs: Ignore empty assembly references.
4077 2008-07-22 Marek Safar <marek.safar@gmail.com>
4079 A fix for bug #387040
4080 * ecore.cs: Skip constrains check for an explicit implementation.
4082 2008-07-21 Marek Safar <marek.safar@gmail.com>
4084 A fix for bug #409045
4085 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
4086 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
4087 identifiers are file specific unless passed as input arguments.
4089 2008-07-21 Marek Safar <marek.safar@gmail.com>
4091 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
4092 to emit UnmanagedMarshal data under 2.0 profile.
4094 2008-07-21 Marek Safar <marek.safar@gmail.com>
4096 A fix for bug #410369
4097 * parameter.cs: Clone correctly ParamsParameter.
4099 2008-07-21 Marek Safar <marek.safar@gmail.com>
4101 * expression.cs (Argument): Always report type for type based expressions
4104 2008-07-18 Marek Safar <marek.safar@gmail.com>
4106 A fix for bug #410666
4107 * anonymous.cs: Correctly initialize generic storey reference.
4109 2008-07-18 Marek Safar <marek.safar@gmail.com>
4111 * convert.cs: Don't box same type arguments.
4113 2008-07-18 Marek Safar <marek.safar@gmail.com>
4115 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
4116 Finished missing generic type mutators.
4118 2008-07-18 Marek Safar <marek.safar@gmail.com>
4120 * iterators.cs, statement.cs: Finished statements CloneTo.
4122 2008-07-18 Marek Safar <marek.safar@gmail.com>
4124 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
4126 * expression.cs: Emit optimized default value expressions in expression tree
4129 2008-07-18 Marek Safar <marek.safar@gmail.com>
4131 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
4133 2008-07-17 Marek Safar <marek.safar@gmail.com>
4135 A fix for bug #367536
4136 * cs-parser.jay: Check static constructor of generic types for an access
4139 2008-07-17 Marek Safar <marek.safar@gmail.com>
4141 A fix for bug #353800
4142 * lambda.cs: Emit ret for contextual statements.
4144 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
4145 up emitting redundant ret for all anonymous methods with return.
4147 2008-07-17 Marek Safar <marek.safar@gmail.com>
4149 A fix for bug #365188
4150 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
4151 create anonymous method storey in unreachable block.
4153 2008-07-17 Marek Safar <marek.safar@gmail.com>
4155 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
4156 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
4157 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
4158 statement.cs: Fixed relevant defects found by Gendarme.
4160 2008-07-17 Marek Safar <marek.safar@gmail.com>
4162 A fix for bug #325291
4163 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
4164 statement.cs: Replaced IAnonymousHost with top level block flag.
4166 2008-07-17 Marek Safar <marek.safar@gmail.com>
4168 * cs-parser.jay: Clean up unused open_parens.
4170 2008-07-17 Marek Safar <marek.safar@gmail.com>
4172 * ecore.cs: Custom error message for a range variable assignment.
4174 2008-07-16 Marek Safar <marek.safar@gmail.com>
4176 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
4179 2008-07-16 Marek Safar <marek.safar@gmail.com>
4181 * literal.cs: Null literal is of object type.
4183 2008-07-16 Marek Safar <marek.safar@gmail.com>
4185 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
4186 expression of nullable equality comparison.
4188 2008-07-15 Marek Safar <marek.safar@gmail.com>
4190 * expression.cs(PointerArithmetic): Removed redundant assignment.
4192 2008-07-15 Marek Safar <marek.safar@gmail.com>
4194 * decl.cs (GetSignatureForError): Report full namespace name for containers.
4196 2008-07-14 Marek Safar <marek.safar@gmail.com>
4198 A fix for bug #408361
4199 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
4200 they are replaced by GetMethod.
4202 2008-07-14 Marek Safar <marek.safar@gmail.com>
4204 A fix for bug #408721 by jeremie.laval@gmail.com
4205 * expression.cs (Indirection): Implemented CloneTo.
4207 2008-07-14 Marek Safar <marek.safar@gmail.com>
4209 * statement.cs (AssignableSlots): Temporary disabled variable initialization
4212 2008-07-14 Marek Safar <marek.safar@gmail.com>
4214 * report.cs (EnableReporting): Don't reinitialize 0-based values.
4216 2008-07-11 Marek Safar <marek.safar@gmail.com>
4218 * linq.cs: Reset tranparent parameter counter in probing mode.
4220 2008-07-11 Marek Safar <marek.safar@gmail.com>
4222 * anonymous.cs: Mutate anonymous method type.
4224 2008-07-11 Marek Safar <marek.safar@gmail.com>
4226 * ecore.cs, anonymous.cs: Mutate field expressions.
4228 2008-07-10 Marek Safar <marek.safar@gmail.com>
4230 A fix for bug #369670
4231 * linq.cs, statement.cs: Use explicit block for query expressions variables.
4233 2008-07-10 Marek Safar <marek.safar@gmail.com>
4235 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
4237 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
4240 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
4241 only one '>', and finds a '>>', abort the generic lookahead.
4243 2008-07-10 Marek Safar <marek.safar@gmail.com>
4245 A fix for bug #319902
4246 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
4248 2008-07-10 Marek Safar <marek.safar@gmail.com>
4250 A fix for bug #406371
4251 * statement.cs: Moved EmitSymbolInfo to Block.
4253 2008-07-09 Marek Safar <marek.safar@gmail.com>
4255 * ecore.cs: Report better error for extension method overload failures.
4257 2008-07-09 Marek Safar <marek.safar@gmail.com>
4259 * expression.cs (Is): No need to box reference values.
4261 2008-07-09 Marek Safar <marek.safar@gmail.com>
4263 * class.cs: Use event resolve context when initializing CreateEmitContext.
4265 2008-07-09 Marek Safar <marek.safar@gmail.com>
4267 A fix for bug #394436
4268 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
4269 method used inside expression trees. Added more LINQ to expression tree
4272 2008-07-08 Marek Safar <marek.safar@gmail.com>
4274 A fix for bug #378189, #370577
4275 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
4278 2008-07-08 Marek Safar <marek.safar@gmail.com>
4280 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
4283 2008-07-08 Marek Safar <marek.safar@gmail.com>
4285 A fix for bug #406702
4286 * anonymous.cs: Always park anonymous method in the nearest parent storey.
4288 2008-07-07 Marek Safar <marek.safar@gmail.com>
4290 A fix for bug #406648
4291 * cs-parser.jay: Report nullable use in mcs for some cases.
4293 2008-07-07 Marek Safar <marek.safar@gmail.com>
4295 * ecore.cs: Improved argument mismatch error messages.
4297 2008-07-07 Marek Safar <marek.safar@gmail.com>
4299 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
4301 2008-07-07 Marek Safar <marek.safar@gmail.com>
4303 * expression.cs (TypeOf): Mutate type argument.
4305 2008-07-04 Marek Safar <marek.safar@gmail.com>
4307 * class.cs: Report missing partial modifier for correct type.
4309 2008-07-04 Marek Safar <marek.safar@gmail.com>
4311 * ecore.cs, expression.cs (VariableReference): Variable property is
4314 2008-07-04 Marek Safar <marek.safar@gmail.com>
4316 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4318 2008-07-04 Marek Safar <marek.safar@gmail.com>
4320 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4323 2008-07-04 Marek Safar <marek.safar@gmail.com>
4325 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4326 anonymous method storey to an instance method when only "this" is hoisted.
4328 2008-07-03 Marek Safar <marek.safar@gmail.com>
4330 A fix for bug #321615
4331 * expression.cs: Pointer comparisons use unsigned operator.
4333 2008-07-03 Marek Safar <marek.safar@gmail.com>
4335 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4337 2008-07-02 Marek Safar <marek.safar@gmail.com>
4339 A fix for bug #404905
4340 * class.cs: Always initialize local unsafe variables.
4342 2008-06-30 Marek Safar <marek.safar@gmail.com>
4344 A fix for bug #396987
4345 * expression.cs (NewInitialize): Clear local temporary variable for next run
4347 2008-06-27 Marek Safar <marek.safar@gmail.com>
4349 A fix for bug #401020
4350 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4352 2008-06-27 Marek Safar <marek.safar@gmail.com>
4354 A fix for bug #398319
4355 * cs-parser.jay: Implemented undocumented base access expression inside
4358 2008-06-26 Marek Safar <marek.safar@gmail.com>
4360 A fix for bug #404227
4361 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4363 2008-06-26 Marek Safar <marek.safar@gmail.com>
4365 A fix for bug #404227
4366 * convert.cs: Fixed explicit array to interface cast.
4368 2008-06-26 Marek Safar <marek.safar@gmail.com>
4370 A fix for bug #403894
4371 * delegate.cs: Mutate DelegateInvocation type.
4373 2008-06-26 Marek Safar <marek.safar@gmail.com>
4375 A fix for bug #379348
4376 * delegate.cs: Box a load of generic parameters.
4378 2008-06-26 Marek Safar <marek.safar@gmail.com>
4380 * expression.cs: Add an array creation arguments mutate.
4382 2008-06-26 Marek Safar <marek.safar@gmail.com>
4384 A fix for bug #386068
4385 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4388 2008-06-25 Marek Safar <marek.safar@gmail.com>
4390 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4393 2008-06-25 Marek Safar <marek.safar@gmail.com>
4395 A fix for bug #403518
4396 * delegate.cs: Type correctly anonymous method new invocation.
4398 2008-06-24 Marek Safar <marek.safar@gmail.com>
4400 A fix for bug #394826
4401 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4404 2008-06-24 Marek Safar <marek.safar@gmail.com>
4406 A fix for bug #394826
4407 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4410 2008-06-24 Marek Safar <marek.safar@gmail.com>
4412 * class.cs: Clone indexer parameters for localized capturing.
4414 2008-06-24 Marek Safar <marek.safar@gmail.com>
4416 A fix for bug #402379
4417 * expression.cs: Don't crash when an object initializer resolve fails.
4419 2008-06-24 Marek Safar <marek.safar@gmail.com>
4421 A fix for bug #402888
4422 * expression.cs: Mutate conditional expression.
4424 2008-06-24 Marek Safar <marek.safar@gmail.com>
4426 A fix for bug #401012
4427 * class.cs: Keep StructLayout in shared container.
4429 2008-06-24 Marek Safar <marek.safar@gmail.com>
4431 A fix for bug #400438
4432 * decl.cs, class.cs: Only properties can be automatically implemented.
4434 2008-06-24 Marek Safar <marek.safar@gmail.com>
4436 * statement.cs (ChangeToIterator): Copy also labels.
4438 2008-06-23 Marek Safar <marek.safar@gmail.com>
4440 * ecore.cs: Pass type argument details to parent extension method.
4442 2008-06-23 Marek Safar <marek.safar@gmail.com>
4444 A fix for bug #375966
4445 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4447 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4449 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4451 2008-06-22 Marek Safar <marek.safar@gmail.com>
4453 A fix for bug #394347
4454 * anonymous.cs: Cache compatible delegates as compatibility check produces
4455 a new method every time.
4457 2008-06-20 Marek Safar <marek.safar@gmail.com>
4459 * anonymous.cs: Propagate storey reference for single references.
4461 2008-06-20 Marek Safar <marek.safar@gmail.com>
4463 A fix for bug #387615
4464 * assign.cs, expression.cs: Correctly clone compound assignment.
4466 2008-06-19 Marek Safar <marek.safar@gmail.com>
4468 A fix for bug #359611, #359604
4469 * anonymous.cs: Mutate all types of hoisted parameters.
4471 2008-06-19 Marek Safar <marek.safar@gmail.com>
4473 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4474 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4475 expression.cs, codegen.cs, statement.cs
4477 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4478 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4480 ** Anonymous methods, lambda expressions rewrite **
4482 Anonymous expressions are now resolved when an explicit block is resolved
4483 and they don't require any registration procedure anymore. Further,
4484 anonymous methods are defined when explicit block is emitted which allows
4485 better control of whole process and opens possibilities for more
4486 optimizations as well as alternative to reverse whole process.
4488 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4489 process consistent and to correctly emit hoisted generic methods when they
4490 have at least 1 hoisted variable.
4492 2008-06-17 Martin Baulig <martin@ximian.com>
4494 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4496 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4497 virtual property; check it in Emit().
4498 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4500 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4502 (Indexer.Define): Likewise.
4504 2008-06-17 Marek Safar <marek.safar@gmail.com>
4506 * convert.cs: Don't use IsInterface on type arguments.
4508 * delegate.cs: DelegateInvocation uses MethodInfo.
4510 * parameter.cs: Removed IsTypeParameter.
4512 * generic-mcs.cs: More missing stuff.
4514 2008-06-16 Martin Baulig <martin@ximian.com>
4517 (Modifiers.DEBUGGER_HIDDEN): New public const.
4520 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4523 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4524 (AbstractPropertyEventMethod): Likewise.
4525 (Constructor.Emit): Likewise.
4526 (SourceMethod.SetCompilerGenerated): Removed.
4528 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4532 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4533 if we're an `IteratorHost'.
4534 (AnonymousMethodMethod..ctor): Don't set
4535 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4538 2008-06-16 Marek Safar <marek.safar@gmail.com>
4540 * statement.cs: Clean-up foreach statements.
4542 2008-06-12 Marek Safar <marek.safar@gmail.com>
4544 * class.cs: Stop using public method which should not exist
4545 (MethodBuilder.SetGenericMethodSignature).
4547 2008-06-11 Martin Baulig <martin@ximian.com>
4550 (Location.LookupFile): Add `CompilationUnit' argument; when given
4551 a relative file name, make it relative to the directory the .cs
4552 file is located in instead of using the current directory.
4554 2008-06-11 Martin Baulig <martin@ximian.com>
4557 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4558 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4559 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4560 (SourceMethod.SetCompilerGenerated): Likewise.
4562 2008-06-11 Marek Safar <marek.safar@gmail.com>
4564 * codegen.cs, driver: Only write symbol file when it's asked for.
4566 2008-06-11 Marek Safar <marek.safar@gmail.com>
4568 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4570 2008-06-10 Martin Baulig <martin@ximian.com>
4572 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4574 2008-06-09 Marek Safar <marek.safar@gmail.com>
4576 A fix for bug #316290
4577 * expression.cs: Include decimal operators in predefined table.
4579 * parameters.cs: More readonlyness.
4581 2008-06-09 Marek Safar <marek.safar@gmail.com>
4583 A fix for bug #397213
4584 * cs-parser.jay: One more missing current_local_parameters reset.
4586 2008-06-09 Marek Safar <marek.safar@gmail.com>
4588 A fix for bug #396633
4589 * class.cs: Host backing field in partial container.
4591 2008-06-09 Marek Safar <marek.safar@gmail.com>
4593 A fix for bug #397068
4594 * expression.cs: Check both operand types when predefined operator is used.
4596 2008-06-05 Martin Baulig <martin@ximian.com>
4598 Merged the `debugger-kahalo' branch.
4601 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4602 we're an iterator method.
4603 (SourceMethod): Reflect latest symbol writer changes;
4604 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4605 now `start_row' and `end_row'.
4606 (Constructor.Emit): Fix the logic whether to emit symbol information.
4608 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4612 (CompilationUnit): New public class; derives from `SourceFile'.
4613 (SourceFileEntry.DefineSymbolInfo): New public method.
4614 (SourceFileEntry.SetChecksum): New public method.
4615 (Location): Encode hidden line numbers by using `column == 255';
4616 the .ctor now accepts `column == -1' to mark a hidden line number.
4617 (Location.Hidden): New public property.
4618 (Location.CheckPoint): Add `CompilationUnit'.
4619 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4620 (Location.Push): Add `CompilationUnit compile_unit' argument.
4621 (Location.CompilationUnit): New public property.
4624 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4626 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4628 * driver.cs: `SourceFile' -> `CompilationUnit'.
4630 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4632 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4634 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4638 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4639 new symbol writer API to also pass the file.
4641 2008-06-05 Marek Safar <marek.safar@gmail.com>
4643 * statement.cs: Emit catch variable assignment using variable expression.
4645 2008-06-05 Marek Safar <marek.safar@gmail.com>
4647 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4648 with other variable types.
4650 2008-06-04 Marek Safar <marek.safar@gmail.com>
4652 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4653 GetLength method emit, it breaks resolve rules.
4655 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4656 Marek Safar <marek.safar@gmail.com>
4658 A fix for bug #395542
4659 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4662 2008-06-02 Marek Safar <marek.safar@gmail.com>
4664 A fix for bug #395287
4665 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4667 2008-05-31 Marek Safar <marek.safar@gmail.com>
4669 A fix for bug #395845
4670 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4671 non-nullable parameter type.
4673 2008-05-31 Marek Safar <marek.safar@gmail.com>
4675 * class.cs: Handle contructor initializer as a statement in top-level block.
4677 2008-05-30 Marek Safar <marek.safar@gmail.com>
4679 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4680 security attributes.
4682 2008-05-24 Marek Safar <marek.safar@gmail.com>
4684 * ecore.cs, expression.cs: Small IVariable refactoring.
4686 2008-05-22 Marek Safar <marek.safar@gmail.com>
4688 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4690 2008-05-21 Marek Safar <marek.safar@gmail.com>
4692 * cs-parser.jay: Removed redundant catch type check.
4694 2008-05-21 Marek Safar <marek.safar@gmail.com>
4696 A fix for bug #390372
4697 * nullable.cs: Set correct return type.
4699 2008-05-21 Marek Safar <marek.safar@gmail.com>
4701 A fix for bug #391062
4702 * typemanager.cs: Fixed crash when comparing null types.
4704 2008-05-21 Marek Safar <marek.safar@gmail.com>
4706 A fix for bug #391871
4707 * cs-parser.jay: Better error handling for invalid catch type.
4709 2008-05-20 Marek Safar <marek.safar@gmail.com>
4711 A fix for bug #392155
4712 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4714 2008-05-15 Marek Safar <marek.safar@gmail.com>
4716 A fix for bug #390666
4717 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4720 2008-05-15 Marek Safar <marek.safar@gmail.com>
4722 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4725 2008-05-13 Marek Safar <marek.safar@gmail.com>
4727 A fix for bug #389625
4728 * delegate.cs, generic.cs: Some progress on method group return type
4731 2008-05-13 Marek Safar <marek.safar@gmail.com>
4733 A fix for bug #378419
4734 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4736 2008-05-12 Marek Safar <marek.safar@gmail.com>
4738 * class.cs (Constructor): Added IsCompilerGenerated.
4740 2008-05-12 Marek Safar <marek.safar@gmail.com>
4742 * expression.cs: Enum binary operators can accept non-enum operand only when
4743 is implicitly convertible to underlying type.
4745 2008-05-12 Marek Safar <marek.safar@gmail.com>
4747 A fix for bug #389272
4748 * support.cs: Workaround System.InvalidOperationException for enums.
4750 2008-05-12 Marek Safar <marek.safar@gmail.com>
4752 A fix for bug #389073
4753 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4755 2008-05-10 Marek Safar <marek.safar@gmail.com>
4757 * driver.cs: Split Parse.
4759 * location.cs (LookupFile): Uses string.Empty.
4761 2008-05-07 Marek Safar <marek.safar@gmail.com>
4763 * expression.cs, parameter.cs: Small ParameterReference clean up.
4765 2008-05-07 Marek Safar <marek.safar@gmail.com>
4767 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4768 hack. Fixes #387502.
4770 2008-05-06 Martin Baulig <martin@ximian.com>
4772 * class.cs (Constructor.Emit): Fix the logic whether to emit
4775 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4778 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4779 InvalidOperationException when the iterator is before the start or
4782 2008-05-06 Marek Safar <marek.safar@gmail.com>
4784 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4785 when left is nullable type.
4787 2008-05-06 Marek Safar <marek.safar@gmail.com>
4789 A fix for bug #386628
4790 * expression.cs (LocalVariableReference): Continue in resolving when
4791 variable is not assigned.
4793 2008-05-05 Marek Safar <marek.safar@gmail.com>
4795 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4796 nullable operations.
4798 2008-05-04 Marek Safar <marek.safar@gmail.com>
4800 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4801 it saves many redundant temporary variables for nullable operations.
4803 2008-05-03 Marek Safar <marek.safar@gmail.com>
4805 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4807 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4810 * nullable.cs: Constant coalescing operator optimizations.
4812 2008-05-03 Marek Safar <marek.safar@gmail.com>
4814 * constant.cs: Use unsigned conversion for values which are unsigned only.
4816 2008-05-03 Marek Safar <marek.safar@gmail.com>
4818 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4819 coalescing operator as it should be.
4821 2008-05-02 Marek Safar <marek.safar@gmail.com>
4823 A fix for bug #371016
4824 * expression.cs: All predefined delegate operators require implicit method
4827 2008-05-02 Marek Safar <marek.safar@gmail.com>
4829 * constant.cs: Emit long constant as uint when fits the range.
4831 * convert.cs, expression.cs: Fixed few unsafe conversions.
4833 2008-05-02 Marek Safar <marek.safar@gmail.com>
4835 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4837 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4840 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4842 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4844 2008-05-01 Marek Safar <marek.safar@gmail.com>
4846 * constant.cs, literal.cs: IsLiteral property for error reporting.
4848 * ecore.cs, expression.cs: Implemented Property expression.
4850 2008-05-01 Marek Safar <marek.safar@gmail.com>
4852 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4854 * nullable.cs: Implemented nullable coalescing null operator.
4856 * ecore.cs, expression.cs: Expression trees work.
4858 2008-05-01 Marek Safar <marek.safar@gmail.com>
4860 * ecore.cs: CreateExpressionTree is finally abstract.
4862 * expression.cs, linq.cs: Updated.
4864 2008-05-01 Marek Safar <marek.safar@gmail.com>
4866 * expression.cs, ecore.cs: Block base access expression inside expression
4869 2008-05-01 Marek Safar <marek.safar@gmail.com>
4871 A fix for bug #385058
4872 * expression.cs: User-defined operator implementations always take
4873 precedence over predefined operator implementations.
4875 2008-04-30 Marek Safar <marek.safar@gmail.com>
4877 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4878 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4879 expression tree conversions.
4881 2008-04-30 Marek Safar <marek.safar@gmail.com>
4883 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4884 operators method details to Operator class.
4886 2008-04-30 Marek Safar <marek.safar@gmail.com>
4888 * anonymous.cs: Pass unsafe flags to anonymous container.
4890 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4891 inside expression tree.
4893 2008-04-29 Martin Baulig <martin@ximian.com>
4895 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4896 (Tokenizer.PopPosition): Also restore the `line'.
4898 2008-04-29 Marek Safar <marek.safar@gmail.com>
4900 * delegate.cs: Implemented Invoke expression.
4902 2008-04-29 Marek Safar <marek.safar@gmail.com>
4904 * expression.cs: Fixed equality reference comparison regression.
4906 2008-04-29 Marek Safar <marek.safar@gmail.com>
4908 * ecore.cs: Clean up EmptyCast hack.
4910 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4911 using correct conversion rules. Also fixes #383993.
4913 2008-04-28 Martin Baulig <martin@ximian.com>
4915 * class.cs (Constructor.Emit): Don't emit debugging information
4916 for generated default .ctor's.
4918 2008-04-28 Marek Safar <marek.safar@gmail.com>
4920 * convert.cs: Empty-cast ushort to int conversion.
4922 2008-04-28 Marek Safar <marek.safar@gmail.com>
4924 A fix for bug #384191
4925 * ecore.cs, expression.cs: Fixed expression cloning.
4927 2008-04-28 Marek Safar <marek.safar@gmail.com>
4929 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4931 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4933 Fix #381559, test-638.cs, test-639.cs
4934 * assign.cs (CompoundAssign.Helper): New wrapper.
4935 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4937 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4938 Pass unconverted expressions to the params array creation expression.
4939 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4940 (PropertyExpr.EmitAssign): Likewise.
4941 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4942 element if it is of kind CompoundAssign.Helper.
4943 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4944 first before anything else.
4945 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4946 (ArrayAccess.LoadArrayAndArguments): Simplify.
4948 2008-04-27 Marek Safar <marek.safar@gmail.com>
4950 * expression.cs: Fixed cloning of typeof(void).
4952 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4954 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4955 (Assign.Emit): Likewise. Move it to ...
4956 (CompoundAssign.DoResolve): ... here and ...
4957 (CompoundAssign.Emit): ... here.
4958 (EventAddOrRemove): New helper to handle += and -= on events, and
4959 avoid the use of BinaryDelegates.
4960 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4961 (EventExpr.EmitAddOrRemove): Improve.
4962 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4964 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4965 create VarExprs for 'foo.bar.var'.
4966 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4967 is a highly inappropriate name for its functionality.
4969 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4971 Simplify handling of multiple assignments
4972 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4974 (SimpleAssign): New. Class to be used for normal assignments.
4975 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4976 * expression.cs, parameter.cs, statement.cs: Likewise.
4978 2008-04-25 Marek Safar <marek.safar@gmail.com>
4980 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4981 for incompatible underlying types, more to come, uff.
4983 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4986 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4987 Handle 'leave_copy'.
4989 2008-04-25 Marek Safar <marek.safar@gmail.com>
4991 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4993 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4995 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4996 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4997 * statement.cs (While, Do, For): Allow test to have side effects.
4998 (For.DoEmit): Always emit InitStatement.
5001 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
5002 Always create SideEffectConstant.
5003 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
5004 of type EnumConstant.
5006 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
5007 Handle 'right' being SideEffectConstant of type 'bool'.
5009 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
5010 Use left.EmitBranchable instead of open coding it, so as to
5011 improve optimization opportunities.
5013 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
5015 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
5017 (Expression.EmitSideEffect): Document.
5019 2008-04-23 Marek Safar <marek.safar@gmail.com>
5021 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
5023 2008-04-23 Marek Safar <marek.safar@gmail.com>
5025 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
5027 2008-04-23 Marek Safar <marek.safar@gmail.com>
5029 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
5030 conversion to expression tree.
5032 2008-04-23 Marek Safar <marek.safar@gmail.com>
5034 * ecore.cs: Removed unused expression.
5036 2008-04-22 Marek Safar <marek.safar@gmail.com>
5038 * expression.cs: Implemented NegateChecked and New expressions.
5040 2008-04-22 Marek Safar <marek.safar@gmail.com>
5042 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
5044 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
5047 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
5048 needing final 'ret' instruction.
5050 2008-04-22 Marek Safar <marek.safar@gmail.com>
5052 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
5054 2008-04-21 Marek Safar <marek.safar@gmail.com>
5056 * expression.cs: Emit ldnull and not null expression as an instance argument
5057 of static method expression calls.
5059 2008-04-21 Marek Safar <marek.safar@gmail.com>
5061 A fix for bug #378200
5062 * expression.cs: Fixed crash when creating parameterless expression tree
5065 2008-04-21 Marek Safar <marek.safar@gmail.com>
5067 A fix for bug #375297
5068 * anonymous.cs: Fixed crash when inferring from null argument anonymous
5071 2008-04-21 Marek Safar <marek.safar@gmail.com>
5073 A fix for bug #377596
5074 * decl.cs, class.cs: Emit delegate type argument attributes.
5076 2008-04-21 Marek Safar <marek.safar@gmail.com>
5078 A fix for bug #365314
5079 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
5081 2008-04-21 Marek Safar <marek.safar@gmail.com>
5083 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
5086 2008-04-21 Marek Safar <marek.safar@gmail.com>
5088 * generic.cs (TypeParameter): Removed redundant location.
5090 2008-04-19 Marek Safar <marek.safar@gmail.com>
5092 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
5093 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
5094 FullNamedExpression in all declaration type expression, statements will come
5097 2008-04-18 Marek Safar <marek.safar@gmail.com>
5099 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
5100 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
5102 2008-04-18 Marek Safar <marek.safar@gmail.com>
5104 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
5107 2008-04-17 Marek Safar <marek.safar@gmail.com>
5109 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
5112 2008-04-17 Marek Safar <marek.safar@gmail.com>
5114 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
5118 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
5120 Hook up 'EmitSideEffect'
5121 * constant.cs (Constant.EmitSideEffect): New.
5122 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
5123 (SideEffectConstant.EmitSideEffect): New.
5124 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
5125 unconditional branch in EmitBranchable.
5126 (FieldExpr.EmitBranchable): New.
5127 * expression.cs (Unary.EmitSideEffect): New.
5128 (Binary.EmitSideEffect): New.
5129 (VariableReference.EmitSideEffect): New. Do nothing.
5131 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5133 Introduce 'EmitSideEffect'
5134 * ecore.cs (Expression.EmitSideEffect): New.
5135 (TypeCast): Rename from EmptyCast.
5137 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
5138 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
5139 * convert.cs, nullable.cs: Update to changes.
5141 2008-04-16 Marek Safar <marek.safar@gmail.com>
5143 * class.cs, cs-parser.jay: Early check for base types expression.
5145 2008-04-16 Marek Safar <marek.safar@gmail.com>
5147 * decl.cs (MemberName): Declare PrettyName as obsolete.
5149 2008-04-16 Marek Safar <marek.safar@gmail.com>
5151 * namespace.cs: Use MemberName comparison.
5153 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5156 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
5158 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
5159 (MemberName.FullyQualifiedName): New. Provides the functionality
5160 that users assume FullName would have.
5161 * ecore.cs, namespace.cs: Update to changes.
5163 * statement.cs (Using.assign): Make into ExpressionStatement.
5164 (Using.EmitPreTryBody): Simplify.
5166 2008-04-16 Marek Safar <marek.safar@gmail.com>
5168 * report.cs: ColorFormat is protected.
5170 * rootcontext.cs: Unused fields clean-up.
5172 * namespace.cs: Made UsingEntry name private.
5174 2008-04-16 Marek Safar <marek.safar@gmail.com>
5176 * cs-tokenizer.cs, location.cs: Removed unused field.
5178 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
5179 Raja R Harinath <harinath@hurrynot.org>
5182 * constant.cs (SideEffectConstant.value): Rename from 'left'.
5183 (SideEffectConstant.side_effect): Rename from 'right'.
5184 (SideEffectConstant..ctor): Normalize 'side_effect'.
5185 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
5186 value of this constant.
5187 * cfold.cs: Update to changes.
5189 2008-04-15 Marek Safar <marek.safar@gmail.com>
5191 * cs-paser.jay: Removed unused variable.
5193 * driver.cs: Made Compile instance method.
5195 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
5197 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
5199 2008-04-15 Marek Safar <marek.safar@gmail.com>
5201 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
5203 2008-04-13 Jb Evain <jbevain@novell.com>
5205 * namespace.cs: update the System.Core fullname for 2.1
5206 * driver.cs: update the list of required assemblies for 2.1.
5207 Merged from the Moonlight 2 branch.
5209 2008-04-11 Marek Safar <marek.safar@gmail.com>
5211 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
5212 types and user defined operators. User operators arguments has to be checked
5213 for null value before invocation, which also means no operator is called
5214 when any argument is not convertible to unwrapped nullable type.
5216 2008-04-09 Marek Safar <marek.safar@gmail.com>
5218 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
5219 of Unary expressions to follow operator overloading rules precisely.
5220 Also fixes #321794, #323794
5222 2008-04-08 Marek Safar <marek.safar@gmail.com>
5224 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
5227 2008-04-08 Marek Safar <marek.safar@gmail.com>
5229 * expression.cs, ecore.cs: Implemented MemberInit expression.
5231 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
5233 Fix mono/tests/exception4.cs
5234 * statement.cs (ExceptionStatement, TryCatch): Revert to using
5235 ec.NeedReturnLabel () rather emitting a 'nop'.
5237 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
5239 (TryCatch.SomeCodeFollows): Likewise.
5240 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
5241 for 'break', 'continue' and 'return' statements inside a try.
5242 We're fairly sure that the generated IL stream will have more
5243 instructions textually following the try.
5244 (FlowBranchingTryCatch): Likewise.
5246 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
5247 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
5250 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
5251 wrapper -- forward everything to CollectionForeach.
5252 (CollectionForeach.NonDisposableWrapper): New.
5253 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
5254 instead of a pop + branch to end.
5256 2008-04-07 Marek Safar <marek.safar@gmail.com>
5258 A fix for bug #377485
5259 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
5260 Propagate location for extension method groups. Report conversion failure at
5263 2008-04-07 Marek Safar <marek.safar@gmail.com>
5265 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
5266 ListInit and Field expressions.
5268 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
5270 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
5271 Since $PC is always -1 inside the body of MoveNext, the fault
5273 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
5274 * statement.cs (ExceptionStatement.emit_finally): Likewise.
5275 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
5277 The denouement! Fix #324708
5278 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
5279 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
5280 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
5281 'finally' inside the finally clause.
5283 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
5284 inside an iterator. Don't emit the body of the 'finally' inside
5285 the finally clause yet.
5287 Use the ResumableStatement infrastructure for MoveNext ()
5288 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
5289 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
5290 'old_resume_points'. Move dispatcher upfront.
5291 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
5292 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
5293 in an enumerator. This encodes the main fix in this patch series
5294 -- we can only jump into the first instruction of a try from the
5295 outside, but we want to emit try/finally regions in iterators and
5296 resume in the middle of them.
5298 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
5300 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
5301 of NeedReturnLabel here.
5303 Introduce a common point for emitting try/finally to IL
5304 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
5305 features of the various subclasses, which are now driven by ...
5306 (ExceptionStatement.EmitPreTryBody): ... this and ...
5307 (ExceptionStatement.EmitTryBody): ... this and the original
5309 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
5310 Remove DoEmit and update to follow above protocol.
5312 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5313 of the dispatcher are the same, skip emitting the 'switch'.
5314 * iterator.cs (Iterator.EmitDispose): Update to changes.
5316 Clean up handling of 'using' statement
5317 * statement.cs (UsingTemporary): New. Carved out of ...
5318 (Using): ... this. Simplify drastically. Handle exactly
5320 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5321 or Using as appropriate. If there are multiple variable declared,
5322 create nested Using statements.
5323 (resource_acquisition): Kill.
5325 * statement.cs (ExceptionStatement.EmitForDispose): Use
5326 EmitFinallyBody, not EmitFinally.
5328 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5329 * iterator.cs: Update to changes.
5331 Start using the ResumableStatement infrastructure
5332 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5333 (ResumableStatement.EmitForDispose): New.
5334 (ExceptionStatement): Override them.
5335 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5336 EmitForDispose to create the body of the Dispose method. Don't
5339 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5340 * statement.cs (Toplevel.AddResumePoint): ... here.
5341 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5342 * flowanalysis.cs (FlowBranchingIterator): New.
5343 * codegen.cs (EmitContext): Update to changes.
5345 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5346 (Iterator.old_resume_points): Rename from 'resume_points'.
5347 (Iterator.MoveNextStatement): Remove unused class.
5349 New infrastructure for try/finally in iterators (still unused)
5350 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5351 (FlowBranchingToplevel.AddResumePoint): Hook into
5352 ToplevelBlock.AddResumePoint.
5353 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5354 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5355 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5356 resume points and assign program-counter values.
5357 (ExceptionBlock.AddResumePoint): Collect resume points for
5358 de-muxer at the top of try block.
5359 * iterators.cs (Yield.CheckContext): Simplify.
5360 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5362 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5364 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5365 argument to an ExitStatement.
5366 (FlowBranchingException): Refactor saved origins code.
5367 * statement.cs (ExitStatement): Update to cahges.
5368 * iterator.cs (YieldBreak): Likewise.
5370 * statement.cs (ResumableStatement): New. Common base class for
5371 YieldReturn and ExceptionStatement.
5372 (ExitStatement): New. Common base class for Return and YieldBreak.
5373 (Return): Update to changes.
5374 * iterator.cs (YieldBreak): Likewise.
5375 * lambda.cs (ContextualReturn): Likewise.
5378 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5379 emit a meaningful error message.
5381 Fix #324765, #319508
5382 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5383 (VariableInfo.SetAssigned): Set it.
5384 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5385 determine if CS0219 or CS0168 is appropriate. Don't use
5386 flow-analysis information.
5387 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5388 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5389 (EmitContext.EndFlowBranching): ... this.
5391 2008-04-03 Marek Safar <marek.safar@gmail.com>
5393 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5395 2008-04-03 Marek Safar <marek.safar@gmail.com>
5397 A fix for bug #376508
5398 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5399 ImplicitConversionExists.
5401 2008-04-03 Marek Safar <marek.safar@gmail.com>
5403 * expression.cs (Binary): Added remaining binary operators to expression
5406 * nullable.cs: Optimize shift with null argument.
5408 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5410 Fix minor IL regression
5411 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5412 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5413 * cs-parser.jay (try_statement): Update to changes.
5415 * statement.cs (TryFinally.need_exc_block): Delete.
5416 (TryFinally): Update to changes.
5418 Now all ExceptionStatements are unconditional
5419 * statement.cs (CollectionForeach.DisposableWrapper): New.
5420 Extract out the try/finally code into a new wrapper.
5421 (CollectionForeach.Resolve): Use it to simplify the code.
5423 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5425 Start at simplifying ExceptionStatement semantics a bit
5426 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5427 * cs-parser.jay (try_statement): Update to changes.
5428 (opt_catch_clauses): Remove.
5429 * flowanalysis.cs: Update to changes.
5430 (FlowBranching.BranchingType.TryCatch): New.
5431 (FlowBranchingTryCatch): New.
5433 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5434 (FlowBranching.CreateBranching): Update to changes.
5435 (FlowBranchingBlock.AddSibling): Add sanity check.
5436 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5439 * iterators.cs (Iterator.MarkFinally): Remove.
5440 * statement.cs (ExceptionStatement): Update to changes.
5442 Add support for skipping over finally blocks at runtime. First
5443 in a series to fix #324708
5444 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5445 (Iterator.EmitMoveNext): Initialize it.
5446 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5447 branch over the body of the 'finally' clause.
5449 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5451 Avoid lopsided use of Foo/DoFoo names
5452 * statement.cs (ExpressionStatement.EmitFinallyBody):
5453 Rename from EmitFinally.
5454 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5455 * iterator.cs: Update to changes.
5457 2008-04-02 Marek Safar <marek.safar@gmail.com>
5459 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5460 based on UserOperatorCall. More binary nullable operators clean up.
5462 2008-04-02 Martin Baulig <martin@ximian.com>
5464 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5466 2008-04-02 Marek Safar <marek.safar@gmail.com>
5468 * nullable.cs: Merge user and empty conversions when lifting expression
5471 * expression.cs (StringConcat): Implemented expression tree representation.
5473 2008-04-01 Marek Safar <marek.safar@gmail.com>
5475 * nullable.cs: When lifting null literal and a user operator exists, no call
5478 2008-04-01 Marek Safar <marek.safar@gmail.com>
5480 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5483 2008-04-01 Marek Safar <marek.safar@gmail.com>
5485 * nullable.cs, expression.cs: Use namespace instead heavily nested
5486 monster abstract class.
5488 2008-04-01 Marek Safar <marek.safar@gmail.com>
5490 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5491 lifting of null literal and user operators. Clean up of some temporary
5494 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5496 Fix #368224, test-629.cs
5497 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5498 if it crossed an unwind-protect boundary.
5499 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5500 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5501 inside an unwind-protected region.
5502 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5503 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5504 'leave' instead of a 'br' if unwind-protected.
5505 (Iterator.EmitYieldBreak): Likewise.
5507 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5509 * driver.cs: Only define versioninfo resources if no win32 resource
5512 2008-03-28 Marek Safar <marek.safar@gmail.com>
5514 A fix for bug #372375
5515 * convert.cs: Fixed boxing of nullable types.
5517 2008-03-28 Marek Safar <marek.safar@gmail.com>
5519 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5522 2008-03-28 Marek Safar <marek.safar@gmail.com>
5524 A fix for bug #374619
5525 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5527 2008-03-27 Marek Safar <marek.safar@gmail.com>
5529 * lambda.cs: Check return type only for invocation.
5531 2008-03-27 Marek Safar <marek.safar@gmail.com>
5533 A fix for bug #374214
5534 * ecore.cs: Correctly report argument type mismatch.
5536 2008-03-27 Marek Safar <marek.safar@gmail.com>
5538 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5539 and not rely on broken IsEnum.
5541 2008-03-27 Marek Safar <marek.safar@gmail.com>
5543 * nullable.cs: New file, extracted from generic.cs.
5545 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5547 2008-03-27 Marek Safar <marek.safar@gmail.com>
5549 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5550 predefined comparison operators and null literals.
5552 * report.cs: New warning ID.
5554 2008-03-25 Marek Safar <marek.safar@gmail.com>
5556 A fix for bug #370577
5557 * lambda.cs: Check return type too.
5559 2008-03-25 Marek Safar <marek.safar@gmail.com>
5561 A fix for bug #372846
5562 * class.cs: Automatic properties can be declared as unsafe.
5564 2008-03-20 Marek Safar <marek.safar@gmail.com>
5566 * location.cs: Use string based concatenation.
5568 * expression.cs: LiftedBinaryOperator is gmcs only.
5570 2008-03-20 Marek Safar <marek.safar@gmail.com>
5572 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5573 conversions rules and expression trees.
5575 2008-03-19 Marek Safar <marek.safar@gmail.com>
5577 * delegate.cs: Use extension method source as delegate target.
5579 2008-03-19 Marek Safar <marek.safar@gmail.com>
5581 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5582 binary operations to be purely based on binary operations and optimized
5583 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5584 and other ET refactoring.
5586 * typemanager.cs: Fixed warning.
5588 2008-03-17 Marek Safar <marek.safar@gmail.com>
5590 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5592 * symbolwriter.cs: Fixed.
5594 2008-03-17 Marek Safar <marek.safar@gmail.com>
5596 * anonymous.cs, driver.cs: Reset anonymous types counters.
5598 2008-03-17 Marek Safar <marek.safar@gmail.com>
5600 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5602 * class.cs: Use fullname for all type member definitions.
5604 2008-02-19 Martin Baulig <martin@ximian.com>
5607 (IMethodData.EmitExtraSymbolInfo): New interface method.
5608 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5609 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5610 interface method here as an empty public virtual method.
5613 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5614 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5615 CodeGen.SymbolWriter.SetRealMethodName().
5617 2008-02-18 Martin Baulig <martin@ximian.com>
5620 (ScopeInfo.EmitType): Override this and emit debugging
5621 information for captured variables.
5622 (RootScopeInfo.EmitType): Override this and emit symbol
5623 information for a captured `this'.
5625 2008-02-15 Martin Baulig <martin@ximian.com>
5627 * iterators.cs: Emit debugging info.
5630 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5631 (EmitContext.OmitDebuggingInfo): New public property.
5634 (While): Override Emit() and don't emit symbol info there; do it
5635 inside DoEmit() instead.
5636 (Block.Emit): Omit symbol information while emitting the scope
5637 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5639 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5640 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5641 .ctor to make `IsIterator' work.
5643 2008-03-14 Martin Baulig <martin@ximian.com>
5645 * symbolwriter.cs: Added the new symbol writer function from the
5646 debugger's `terrania' branch; temporarily enclose them inside
5647 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5650 2008-03-14 Martin Baulig <martin@ximian.com>
5653 (SymbolWriter): Make this a public static class.
5656 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5657 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5659 2008-03-14 Marek Safar <marek.safar@gmail.com>
5661 A fix for bug #370577
5662 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5665 2008-03-14 Marek Safar <marek.safar@gmail.com>
5667 * typemanager.cs (CSharpName): Made 250 times faster.
5669 2008-03-13 Marek Safar <marek.safar@gmail.com>
5671 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5673 2008-03-12 Marek Safar <marek.safar@gmail.com>
5675 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5676 crash when predefined field does not exist.
5678 2008-03-12 Marek Safar <marek.safar@gmail.com>
5680 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5682 2008-03-12 Marek Safar <marek.safar@gmail.com>
5684 * class.cs (FixedField): Don't crash when contructors are missing.
5686 2008-03-11 Marek Safar <marek.safar@gmail.com>
5688 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5689 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5690 check internal types accessibility for internal and external types.
5691 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5693 2008-03-11 Marek Safar <marek.safar@gmail.com>
5695 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5696 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5697 attribute.cs, statement: Use corect instance of predefined types (work
5698 related to #364674).
5700 2008-03-07 Marek Safar <marek.safar@gmail.com>
5702 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5704 2008-03-07 Marek Safar <marek.safar@gmail.com>
5706 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5707 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5708 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5709 predefined types clean up, delayed predefined types members initialization
5710 (work related to #364674).
5712 2008-03-05 Marek Safar <marek.safar@gmail.com>
5714 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5716 2008-03-05 Marek Safar <marek.safar@gmail.com>
5718 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5719 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5720 predefined types clean up (work related to #364674).
5722 2008-03-04 Marek Safar <marek.safar@gmail.com>
5724 * ecore.cs: Print an error message instead of throwing exception.
5726 2008-03-04 Marek Safar <marek.safar@gmail.com>
5728 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5729 expression.cs, statement.cs: Unififed null literal representation.
5731 2008-03-03 Marek Safar <marek.safar@gmail.com>
5733 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5734 expression.cs: Refactored binary operators resolve phase and improved speed.
5735 The nullable code is still missing and won't work correctly, more fixes
5738 It also fixes #323726, #324312, #324248, and many other unreported issues.
5740 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5742 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5745 2008-02-27 Marek Safar <marek.safar@gmail.com>
5747 * ecore.cs: Clean-up and split BetterConversion.
5749 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5752 * enum.cs (EnumMember.Value): Only access 'value' if
5753 ResolveValue says it's ok.
5754 (EnumMember.DoResolveValue): Don't set prev_member.value.
5755 (Enum.GetDefinition): Reverse arguments of Equals --
5756 EnumMember.Value can return 'null'.
5758 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5760 2008-02-22 Marek Safar <marek.safar@gmail.com>
5762 * generic.cs, expression.cs: More ongoing work on expression trees.
5764 2008-02-21 Marek Safar <marek.safar@gmail.com>
5766 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5767 handle missing matches when mutiple operators exist.
5769 2008-02-20 Marek Safar <marek.safar@gmail.com>
5771 A fix for bug #363218
5772 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5775 2008-02-20 Marek Safar <marek.safar@gmail.com>
5777 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5778 update. This time to deal correctly with SideEffectConstant expression used
5779 as an argument for another constant folding.
5781 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5783 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5786 2008-02-19 Marek Safar <marek.safar@gmail.com>
5788 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5790 2008-02-19 Marek Safar <marek.safar@gmail.com>
5792 A fix for bug #328136
5793 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5794 side is a false constant, because we still need to evaluate the right-hand
5797 * statement.cs (If): Emit two types of boolean constants (simple constant,
5798 side-effect constant).
5800 2008-02-19 Marek Safar <marek.safar@gmail.com>
5802 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5804 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5807 2008-02-18 Marek Safar <marek.safar@gmail.com>
5809 A fix for bug #361457
5810 * ecore.cs (IsApplicable): Params methods have lower priority.
5812 * support.cs: Return correct parameter modifier for params types.
5814 2008-02-18 Marek Safar <marek.safar@gmail.com>
5816 * generic.cs (TypeParameter): Cache attribute target name.
5818 * support.cs: Removed unused variable.
5820 * typemanager.cs: Removed debugging leftover.
5822 * ecore.cs: Use local type instead of a property;
5824 * class.cs (VerifyMembers): Consider also parent to test whether type member
5827 * expression.cs (FullMethodDesc): Removed.
5829 * attribute.cs (IsValidArgumentType): Made static.
5831 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5833 Cleanup to be more readable.
5834 * Makefile (GMCS_PROFILE): Remove.
5835 (COMPILER_NAME): New helper.
5837 2008-02-15 Miguel de Icaza <miguel@novell.com>
5839 * cs-tokenizer.cs: if a conditional expression happens inside a
5840 (...) this also means that we do not need to de-ambiguate between
5841 an parenthesized expression and a cast.
5845 * constant.cs (SideEffectConstant): a constant value that happens
5846 to have a side effect.
5848 Fixes the build regressions introduced by the fix for #359789
5850 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5852 * expression.cs (Conditional.Emit): when emitting the ternary
5853 operator, use local variables to generate code verifiable code.
5855 The verifier cannot infer that the type on stack before the
5856 stloc.0 is executed is of type ParentB. This happens because the
5857 stack merge algorithm uses only parent types when deciding which
5858 is the common type. This is described in Part III 1.8.1.3 of ECMA
5861 This code compiled with mcs is not verifiable under MS. The MS
5862 verifier picks the first common interface of Foo and Bar, which is
5863 wrong, but doesn't use a full join type of the 2 interfaces.
5865 CSC uses a clever hack to compile such code in a verifiable
5866 way. It stores the intermediate values in a local variable with
5871 2008-02-14 Miguel de Icaza <miguel@novell.com>
5873 * expression.cs: Do not fold BitwiseAnd operators when the left
5874 side is a false constant, because we still need to evaluate the
5879 * support.cs: Instead of throwing an InternalErrorException when
5880 the position of the stream is outside the boundary of our buffer,
5881 reset the state of the reader, and restart the reading from the
5882 beginning of the file.
5884 2008-02-14 Marek Safar <marek.safar@gmail.com>
5886 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5888 2008-02-14 Marek Safar <marek.safar@gmail.com>
5890 A fix for bug #361686
5891 * decl.cs: A protected types used inside a private class which parents
5892 derives from the protected class are accessible.
5894 2008-02-13 Marek Safar <marek.safar@gmail.com>
5896 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5897 the parameterless constructor.
5899 2008-02-13 Marek Safar <marek.safar@gmail.com>
5901 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5902 lookup methods to use standard member cache when doing member lookup.
5904 2008-02-12 Marek Safar <marek.safar@gmail.com>
5906 * driver.cs: Don't report full path for referenced module as assembly error.
5908 2008-02-12 Marek Safar <marek.safar@gmail.com>
5910 * Makefile: Fixed `qh' target to work on all machines.
5912 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5913 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5914 and HasElementType with TypeManager implementation.
5916 2008-02-08 Marek Safar <marek.safar@gmail.com>
5918 A fix for bugs #325134, #359749
5919 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5920 first binds point to non-method member expression.
5922 2008-02-08 Marek Safar <marek.safar@gmail.com>
5924 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5926 2008-02-08 Marek Safar <marek.safar@gmail.com>
5928 A fix for bugs #321394, #323028
5929 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5930 Reworked naive IsAccessibleAs implementation to handle nested types.
5932 2008-02-05 Jb Evain <jbevain@novell.com>
5934 * class.cs: use generic type comparison for parameters
5937 2008-02-05 Marek Safar <marek.safar@gmail.com>
5939 A fix for bug #325372
5940 * class.cs: Use generic type comparison when testing method signatures.
5942 2008-02-05 Marek Safar <marek.safar@gmail.com>
5944 A fix for bug #357047
5945 * ecore.cs: Applied C# 3.0 changes to better conversion.
5947 2008-02-05 Marek Safar <marek.safar@gmail.com>
5949 A fix for bug #358374
5950 * cs-parser.jay: Correctly set modifiers for all constructor types.
5952 2008-02-04 Marek Safar <marek.safar@gmail.com>
5954 A fix for bug #355251
5955 * generic.cs: Added base class constraint based type inference.
5957 2008-02-01 Marek Safar <marek.safar@gmail.com>
5959 A fix for bug #357255
5960 * decl.cs: One more missing visibility check.
5962 2008-02-01 Marek Safar <marek.safar@gmail.com>
5964 * support.cs: Fixed broken return.
5966 2008-01-25 Marek Safar <marek.safar@gmail.com>
5968 * report.cs: Correctly reset warnings count after probing.
5970 2008-01-25 Martin Baulig <martin@ximian.com>
5973 (NamespaceEntry.SymbolFileID): Make this work again after
5974 MemberName.ToString() is gone.
5976 2008-01-25 Marek Safar <marek.safar@gmail.com>
5978 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5981 2008-01-25 Marek Safar <marek.safar@gmail.com>
5983 * generic.cs: Use full implicit conversion for type inference fixing.
5985 2008-01-24 Marek Safar <marek.safar@gmail.com>
5987 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5988 Fixed user operator conversions.
5990 2008-01-24 Marek Safar <marek.safar@gmail.com>
5992 * generic.cs: Do nullable type to null comparison optimization during
5995 2008-01-24 Marek Safar <marek.safar@gmail.com>
5997 A fix for bug #355163
5998 * generic.cs: Enabled l-value resolve on nullable expressions.
6000 2008-01-24 Marek Safar <marek.safar@gmail.com>
6002 A fix for bug #353986
6003 * class.cs: Ingore static ctors with parameters for any further checks.
6005 2008-01-24 Marek Safar <marek.safar@gmail.com>
6007 A fix for bug #354310
6008 * namespace.cs: Removed redundant check.
6010 2008-01-24 Marek Safar <marek.safar@gmail.com>
6012 A fix for bug #354928
6013 * expression.cs: ElementInitializers can be resolved only once.
6015 2008-01-24 Marek Safar <marek.safar@gmail.com>
6017 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
6018 Condition expressions.
6020 2008-01-23 Marek Safar <marek.safar@gmail.com>
6022 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
6024 2008-01-22 Marek Safar <marek.safar@gmail.com>
6026 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
6029 * generic.cs: Implemented coalesce expression.
6031 2008-01-22 Marek Safar <marek.safar@gmail.com>
6033 A fix for bug #355145
6034 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
6035 expression tree type inference.
6037 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
6040 * expression.cs (Binary.IsUnsignedType): Fix typo.
6042 2008-01-22 Marek Safar <marek.safar@gmail.com>
6044 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
6046 2008-01-22 Marek Safar <marek.safar@gmail.com>
6048 A fix for bug #355161
6049 * ecore.cs, expression.cs: Wider range of extension method supported
6052 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
6054 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
6055 AssemblyBuilder to operate in compiler context. Fixes mcs part of
6058 2008-01-22 Marek Safar <marek.safar@gmail.com>
6060 A fix for bug #355148
6061 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
6063 2008-01-22 Miguel de Icaza <miguel@novell.com>
6065 * expression.cs (CreateExpressionTree): Add support for or and
6066 logical or, and indent following the coding conventions.
6068 * typemanager.cs (LinqExpression): renamed from
6069 ExpressionTreeManager, for a shorter name.
6071 Use TypeManager.CoreLookupType to lookup types from our core
6072 assemblies and turn those into "Type" variables.
6074 Consumers that previously used "Namespace" and "Type" from this
6075 class should instead use the TypeExpression which is a type that
6076 is fully resolved (without involving the regular C# resolution
6079 This typically looks like this:
6081 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
6082 new MemberAccess (texpr, name, type_arguments, loc)
6084 This avoids the problem in: #355178
6086 2008-01-21 Marek Safar <marek.safar@gmail.com>
6088 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
6089 feature in parser only as we do in other cases.
6091 2008-01-21 Marek Safar <marek.safar@gmail.com>
6093 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
6094 typemanager.cs: A refactoring of params arguments to reuse existing
6095 expressions (params -> array initializer) to emit params argument instead
6096 of specialized handling.
6097 It was required by expression tree implementation and it has other benefits
6098 as well, we now apply same optimization for params arguments as we do for
6101 2008-01-18 Marek Safar <marek.safar@gmail.com>
6103 A fix for bug #353526
6104 * generic.cs: A type inference of params arguments may not required any
6105 temporary array creation.
6107 2008-01-18 Marek Safar <marek.safar@gmail.com>
6109 A fix for bug #353534
6110 * generic.cs, ecore.cs, expression.cs: A method group type inference is
6111 supported for delegates only.
6113 2008-01-18 Marek Safar <marek.safar@gmail.com>
6115 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
6116 type for more than 1 candidates.
6118 2008-01-18 Marek Safar <marek.safar@gmail.com>
6120 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
6123 2008-01-16 Marek Safar <marek.safar@gmail.com>
6125 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
6126 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
6127 operator) expressions.
6129 2008-01-16 Zoltan Varga <vargaz@gmail.com>
6131 * statement.cs: Avoid declaring an IL variable for this_variable since it is
6132 not accessed from the generated IL.
6134 2008-01-14 Marek Safar <marek.safar@gmail.com>
6136 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
6137 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
6138 statement.cs: The first expression tree implementation drop, mostly
6139 infrastructure work.
6141 2008-01-14 Marek Safar <marek.safar@gmail.com>
6143 * ecore.cs (IsNestedChild): Refactored.
6145 2008-01-11 Marek Safar <marek.safar@gmail.com>
6147 * lambda.cs: Don't use a cast on unknown expression statement.
6149 2008-01-10 Geoff Norton <gnorton@novell.com>
6151 * cs-tokenizer.cs: One more token to distinguish between method and lambda
6154 2008-01-09 Marek Safar <marek.safar@gmail.com>
6156 * doc.cs: Report better /doc crash details.
6158 2008-01-09 Marek Safar <marek.safar@gmail.com>
6160 A fix for bug #352536
6161 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
6163 2008-01-08 Marek Safar <marek.safar@gmail.com>
6165 A fix for bug #352287
6166 * ecore.cs, expression.cs: Do `this' access checking in all member access
6169 2008-01-08 Marek Safar <marek.safar@gmail.com>
6171 * rootcontext.cs, driver.cs: Switch to linq mode by default.
6173 * report.cs: Reset message stacks.
6175 2008-01-08 Marek Safar <marek.safar@gmail.com>
6177 * generic.cs (InferInPhases): Correctly calculate params position.
6179 2008-01-08 Marek Safar <marek.safar@gmail.com>
6181 * cs-tokenizer.cs: No need to parse full string when parsing lambda
6184 2008-01-07 Marek Safar <marek.safar@gmail.com>
6186 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
6188 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
6190 * driver.cs: Updated --help option.
6192 2008-01-07 Marek Safar <marek.safar@gmail.com>
6194 * generic.cs (InferParamsTypeArguments): Removed.
6195 (InferInPhases): Add params type inference.
6196 (LowerBoundInference): Fixed scoring mechanism.
6198 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
6200 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
6202 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
6203 byte array for unsigned "baked" assemblies.
6205 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
6207 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
6208 array for assemblies that are not strongnamed.
6210 2008-01-04 Marek Safar <marek.safar@gmail.com>
6212 A fix for bug #351481
6213 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
6214 declaring type for nested generic types.
6216 2008-01-04 Marek Safar <marek.safar@gmail.com>
6218 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
6219 instead of ToString.
6221 2008-01-03 Marek Safar <marek.safar@gmail.com>
6223 A fix for bug #351047
6224 * expression.cs (Binary.ResolveOperator): Allow equality operators between
6225 null and structs only when equality and inequality operators are defined
6226 either as an user-operators or predefined operators.
6228 2008-01-03 Marek Safar <marek.safar@gmail.com>
6230 A fix for bug #351047
6231 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
6233 2008-01-03 Marek Safar <marek.safar@gmail.com>
6235 A fix for bug #351257
6236 * cs-tokenizer.cs: Advance line number for '\r' correctly.
6238 2008-01-03 Marek Safar <marek.safar@gmail.com>
6240 A fix for bug #351157
6241 * class.cs (Using): Fixed yet another broken cloning.
6243 (Block): Put back more sensible default value for statements.
6245 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
6247 * codegen.cs: Allow AssemblyVersion with only major version component.
6250 2007-12-29 Marek Safar <marek.safar@gmail.com>
6252 A fix for bug #324654
6253 * class.cs: Use FullName property as member name.
6255 2007-12-28 Marek Safar <marek.safar@gmail.com>
6257 A fix for bug #342117
6258 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
6259 constructor constraint.
6261 2007-12-28 Marek Safar <marek.safar@gmail.com>
6263 A fix for bug #338273
6264 * class.cs (ProbertyBase): Access modifier checks are required for overrides
6267 2007-12-28 Marek Safar <marek.safar@gmail.com>
6269 A fix for bug #350839
6270 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
6272 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6274 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6277 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6279 * statement.cs: Changed some Hashtables to use HybridDictionaries
6280 instead. It was observed that some HashTables only contained a few
6281 items in the vast majority of cases. Since HybridDictionary is
6282 more efficient on small sets (<10 elements), "known_variables"
6283 from class ExplicitBlock as well as "labels" and "constants " from
6284 class Block were changed to HybridDictionaries.
6286 Atsai results: (56216kb->54987kb)
6288 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
6291 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6293 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6296 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6298 * expression.cs: foreach loop to for loop, saved on allocation of
6299 enumerator (59333kb->59141kb)
6301 * statement.cs. Changed foreach loops to for loops, saved on
6302 allocation of enumerator (59141kb->59006kb)
6304 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
6305 when constructed with no specified capacity. This was causing a
6306 few ArrayLists to allocate more memory than they would potentially
6307 need in the Block class and MemberCache class. Setting the
6308 ArrayLists to construct with a capacity of 1 saves some
6309 memory. (56216kb->55585kb)
6311 2007-12-27 Marek Safar <marek.safar@gmail.com>
6313 A fix for bug #347189 (2nd issue)
6314 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6317 2007-12-27 Miguel de Icaza <miguel@novell.com>
6319 * report.cs: Do not use colors if stdout and stderr are not a
6322 2007-12-27 Marek Safar <marek.safar@gmail.com>
6324 A fix for bug #346998
6325 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6328 2007-12-27 Marek Safar <marek.safar@gmail.com>
6330 A fix for bug #343465
6331 * class.cs: Explicit method name for nested types uses dots only.
6333 2007-12-27 Marek Safar <marek.safar@gmail.com>
6335 A fix for bug #343707
6336 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6338 2007-12-27 Marek Safar <marek.safar@gmail.com>
6340 * ecore.cs: Report type inference errors only when arguments count matches
6343 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6345 * expression.cs, report.cs: New warning.
6347 * typemanager.cs: Catch anonymous method type too.
6349 2007-12-23 Marek Safar <marek.safar@gmail.com>
6351 A fix for bug #346379
6352 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6354 2007-12-23 Marek Safar <marek.safar@gmail.com>
6356 A fix for bug #347359
6357 * expression.cs (Invocation): Don't resolve already resolved expression.
6359 2007-12-23 Marek Safar <marek.safar@gmail.com>
6361 A fix for bug #347189
6362 * class.cs (FixedField): Use non-dependent code only in the define phase.
6364 2007-12-23 Marek Safar <marek.safar@gmail.com>
6366 A fix for bug #348076
6367 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6369 2007-12-22 Marek Safar <marek.safar@gmail.com>
6371 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6372 discovered extension methods.
6374 2007-12-22 Marek Safar <marek.safar@gmail.com>
6376 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6379 2007-12-21 Miguel de Icaza <miguel@novell.com>
6381 * report.cs (ErrorMessage): Add support for using colors on
6382 terminals that support it.
6384 2007-12-21 Marek Safar <marek.safar@gmail.com>
6386 * ecore.cs: Use information about expanded params for error reporting.
6388 2007-12-21 Marek Safar <marek.safar@gmail.com>
6390 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6391 and logic for params overloads.
6393 2007-12-15 Miguel de Icaza <miguel@novell.com>
6395 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6396 as this is also created from the parser. Fixes #349034
6398 2007-12-12 Miguel de Icaza <miguel@novell.com>
6400 * statement.cs (Throw.CloneTo): it is valid to have empty
6401 expressions for throw.
6403 2007-12-03 Marek Safar <marek.safar@gmail.com>
6405 * cs-parser.jay: Set delegate constraint parsing region correctly.
6407 2007-12-03 Marek Safar <marek.safar@gmail.com>
6409 A fix for bug #345467
6410 * typemanager.cs (IsEqual): Compare generic parameters position only.
6412 2007-11-28 Marek Safar <marek.safar@gmail.com>
6414 * expression.cs (BaseAccess): Type arguments can be null.
6416 2007-11-27 Raja R Harinath <harinath@gmail.com>
6418 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6419 consistent even when an error has occured.
6420 (Switch.Resolve): Likewise.
6422 2007-11-22 Marek Safar <marek.safar@gmail.com>
6424 A fix for bug #334505
6425 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6428 2007-11-22 Marek Safar <marek.safar@gmail.com>
6430 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6431 refactorings required to resolve extension methods correctly when mixing
6432 generics and non-generics members.
6434 2007-11-20 Marek Safar <marek.safar@gmail.com>
6436 A fix for bug #342584
6437 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6440 2007-11-19 Marek Safar <marek.safar@gmail.com>
6442 A fix for bug #342512
6443 * delegate.cs: Use delegate argument expression when is available. Don't
6444 emit virtual call when class is sealed.
6446 2007-11-16 Marek Safar <marek.safar@gmail.com>
6448 A fix for bug #325423
6449 * assign.cs (FieldInitializer): Use resolved expression for emit.
6451 * class.cs: Print less confusing error message.
6453 2007-11-16 Marek Safar <marek.safar@gmail.com>
6455 * cs-tokenizer.cs: Removed GMCS ifdefs.
6457 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6460 * cs-parser.jay: Disabled nullable check.
6462 * generic-mcs: Copied more generic stuff.
6464 2007-11-16 Marek Safar <marek.safar@gmail.com>
6466 * gcs-parser.jay: Merged to cs-parser.jay.
6468 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6469 * *.csproj, *.sources: Updated to use only jay parser file.
6471 2007-11-16 Marek Safar <marek.safar@gmail.com>
6473 * gcs-parser.jay: Added nullable and default expression feature checks.
6475 2007-11-16 Marek Safar <marek.safar@gmail.com>
6477 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6478 it fixes many TODOs and hidden bugs.
6480 * expression: Removed duplicate error check.
6482 2007-11-15 Marek Safar <marek.safar@gmail.com>
6484 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6485 implicitly type local variable only when it is used in a declaration.
6487 2007-11-15 Marek Safar <marek.safar@gmail.com>
6489 * attribute.cs: Use CS0612 for empty strings.
6491 2007-11-14 Marek Safar <marek.safar@gmail.com>
6493 * lambda.cs, statement.cs: Contextual return may act as a statement.
6495 2007-11-14 Marek Safar <marek.safar@gmail.com>
6497 A fix for a regression cause by #324222
6498 * class.cs: Don't report unused even when it implements an interface.
6500 2007-11-13 Marek Safar <marek.safar@gmail.com>
6502 A fix for bug #341205
6503 * ecore.cs, expression.cs: Method group expression cannot do static
6504 method access with an instance reference check before overloading takes
6507 2007-11-13 Marek Safar <marek.safar@gmail.com>
6509 A fix for bug #325359
6510 * class.cs: Use predictable name for automatically generated property.
6512 2007-11-12 Marek Safar <marek.safar@gmail.com>
6514 A fix for bug #324996
6515 * expression.cs (Is): Handle case where D is nullable and T is not
6518 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6520 2007-11-12 Marek Safar <marek.safar@gmail.com>
6522 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6523 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6524 Flush small error reporting changes.
6526 2007-11-09 Marek Safar <marek.safar@gmail.com>
6528 A fix for bug #324996
6529 * expression.cs: Rewrote Is expression implementation to work with
6530 generics, nullable types, anonymous method. A const result expression
6531 uses existing infrastructure instead of custom not fully-featured one.
6533 2007-11-08 Marek Safar <marek.safar@gmail.com>
6535 A fix for bug #340202
6536 * class.cs: Consider generics for volatile field.
6538 2007-11-08 Marek Safar <marek.safar@gmail.com>
6540 A fix for bug #335594
6541 * expression.cs: Use conversion rules when handling string addition.
6543 2007-11-07 Marek Safar <marek.safar@gmail.com>
6545 A fix for bug #336651
6546 * expression.cs: Fixed a crash when probing is on.
6548 2007-11-07 Marek Safar <marek.safar@gmail.com>
6550 A fix for bug #324242
6551 * covert.cs: Added a conversion from any nullable-type with an
6552 underlying enum-type to the type System.Enum.
6554 2007-11-07 Marek Safar <marek.safar@gmail.com>
6556 A fix for bug #324222
6557 * class.cs: Report all non-used event fields.
6559 2007-11-07 Marek Safar <marek.safar@gmail.com>
6561 A fix for bug #325161
6562 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6563 qualifier for generic types.
6565 2007-11-07 Marek Safar <marek.safar@gmail.com>
6567 A fix for bug #322971
6568 * expression.cs, ecore.cs: Added intermediate result value check for
6571 2007-11-07 Marek Safar <marek.safar@gmail.com>
6573 A fix for bug #324754
6574 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6575 when it was requested.
6577 2007-11-07 Marek Safar <marek.safar@gmail.com>
6579 A fix for bug #325101
6580 * expression.cs: Do type not value comparison for `is' expression.
6582 2007-11-07 Marek Safar <marek.safar@gmail.com>
6584 A fix for bug #320236
6585 * convert.cs: Don't apply user conversion on underlying target type.
6587 2007-11-06 Marek Safar <marek.safar@gmail.com>
6589 * expression.cs: Don't use unresolved expression for error reporting.
6591 2007-11-06 Marek Safar <marek.safar@gmail.com>
6593 A fix for bugs #337712, #324490
6594 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6595 overloading resolution too.
6597 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6598 the process consistent and more robust.
6600 * expression.cs, linq.cs, report.cs: Update.
6602 2007-11-02 Marek Safar <marek.safar@gmail.com>
6604 A fix for bug #332909
6605 * attribute.cs: Resolve attributes in correct context using error
6608 * rootcontext.cs: Define Obsolete attribute members as core members.
6610 2007-11-02 Marek Safar <marek.safar@gmail.com>
6612 * statement.cs: Removed unused methods.
6614 2007-10-31 Wade Berrier <wberrier@novell.com>
6616 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6617 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6620 2007-10-31 Marek Safar <marek.safar@gmail.com>
6622 A fix for bug #338102
6623 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6624 methods registered as non-generics.
6626 2007-10-31 Marek Safar <marek.safar@gmail.com>
6628 A fix for bugs #337712, #324490
6629 * delegate.cs: Delegate covariance and contravariance is not allowed for
6632 2007-10-31 Marek Safar <marek.safar@gmail.com>
6634 A fix for bug #337719
6635 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6638 2007-10-30 Marek Safar <marek.safar@gmail.com>
6640 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6642 2007-10-29 Marek Safar <marek.safar@gmail.com>
6644 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6647 2007-10-29 Raja R Harinath <rharinath@novell.com>
6649 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6651 2007-10-29 Marek Safar <marek.safar@gmail.com>
6653 A fix for bug #334652
6654 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6655 extension methods when we have not found the best candidate in normal
6658 2007-10-27 Marek Safar <marek.safar@gmail.com>
6660 * AssemblyInfo.cs: Keep up-to-date.
6662 2007-10-27 Marek Safar <marek.safar@gmail.com>
6664 * Makefile: Fixed generics compiler name.
6666 2007-10-27 Marek Safar <marek.safar@gmail.com>
6668 * lambda.test: removed, lambda parsing is done differently.
6670 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6672 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6674 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6676 2007-10-27 Marek Safar <marek.safar@gmail.com>
6678 * Makefile, *.sources : All C# compilers are in mcs folder.
6680 * *.cs: Use existing 2_1 define for smcs.
6682 2007-10-26 Marek Safar <marek.safar@gmail.com>
6684 A fix for bug #335847
6685 * assign.cs, expression.cs: Couple of changes to avoid creating a
6686 temporary variable for each object initializer assignment statement. It
6687 simplifies struct initialization too, otherwise two temporary variables
6689 Implemented optimization of redundant default element initializers.
6691 2007-10-25 Marek Safar <marek.safar@gmail.com>
6693 A fix for bug #336766
6694 * expression.cs (Class.CheckBase): Use generic name when method is
6697 2007-10-25 Marek Safar <marek.safar@gmail.com>
6699 A fix for bug #334737
6700 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6701 variable and not variable argument for prepared copies.
6703 2007-10-24 Marek Safar <marek.safar@gmail.com>
6705 A fix for bug #325110
6706 * class.cs, expression.cs, attribute.cs: Use open generic method when
6707 checking conditional attribute.
6709 2007-10-24 Marek Safar <marek.safar@gmail.com>
6711 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6712 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6713 FeatureIsNotAvailable.
6715 2007-10-24 Marek Safar <marek.safar@gmail.com>
6717 ** C# 3.0 Partial methods
6719 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6720 methods support. Because of member cache issue with generics only
6721 non-generics partial methods are fully supported.
6723 2007-10-23 Marek Safar <marek.safar@gmail.com>
6725 * class.cs, decl.cs: Rewrote member overloads check to cope with
6726 generics and to use member cache for member checking. It also improves
6727 performance and fixes remaining overloads issues.
6729 2007-10-20 Marek Safar <marek.safar@gmail.com>
6731 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6732 roottypes.cs, typemanager.cs:
6734 A member cache creation logic changed to add members immediately and
6735 not rely on fallback. The member cache is now only prefered way
6736 how to access and find type declaration members. It saves 5 MB of memory
6737 during MWF compilation and makes code ready for more optimizations and
6738 clean-ups, it's also a pre-requirement for partial methods.
6740 2007-10-18 Raja R Harinath <harinath@gmail.com>
6742 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6743 handling for generic parameters.
6745 2007-10-15 Marek Safar <marek.safar@gmail.com>
6747 * class.cs (FixedField): Removed redundant volatile check.
6749 2007-10-15 Marek Safar <marek.safar@gmail.com>
6751 * class.cs, decl.cs: Fixed overload members verification to do only one
6752 check per possible collision.
6754 2007-10-13 Marek Safar <marek.safar@gmail.com>
6756 A fix for bug #325478
6757 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6758 and create only one disposable flags container.
6760 2007-10-12 Marek Safar <marek.safar@gmail.com>
6762 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6763 * statement.cs (Fixed): Fixed variables cloning.
6765 2007-10-12 Marek Safar <marek.safar@gmail.com>
6767 A fix for bug #333342
6768 * class.cs (EventField): Don't mark value type event as synchronized.
6770 2007-10-12 Marek Safar <marek.safar@gmail.com>
6772 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6773 inference to identify best candidate method correctly.
6774 (ProperyExpr): A range variable is read only and cannot be modified.
6776 2007-10-11 Marek Safar <marek.safar@gmail.com>
6778 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6779 logic to identify best candidate method correctly.
6781 2007-10-11 Marek Safar <marek.safar@gmail.com>
6783 * location.cs (Equals, GetHashCode): Removed.
6785 2007-10-11 Marek Safar <marek.safar@gmail.com>
6787 * report.cs: Implemented message recorder. It is used mainly for lambda
6788 expressions to capture otherwise swallowed error messages.
6790 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6792 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6794 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6796 * expression.cs (MemberAccess): Always report lookup failure.
6798 * location.cs: Implemented Equals, GetHashCode.
6800 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6802 2007-10-10 Jb Evain <jbevain@novell.com>
6804 * codegen.cs: re-enable assembly version check.
6806 2007-10-09 Marek Safar <marek.safar@gmail.com>
6808 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6811 * namespace.cs (UsingAlias): Do correct version check.
6813 2007-10-08 Marek Safar <marek.safar@gmail.com>
6815 * expresison.cs, ecore.cs: Issue extension method error message when
6818 * rootcontext.cs: Added ISO_2 compiler mode option.
6820 2007-10-08 Marek Safar <marek.safar@gmail.com>
6822 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6825 2007-10-08 Marek Safar <marek.safar@gmail.com>
6827 * attribute.cs (GetString, GetBoolean): Work with both literal and
6830 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6831 Moved method overload specific methods to MethodGroupExpr.
6833 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6834 it should be less memory consuming.
6836 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6838 * codegen.cs: remove the assembly version check until the buildbot is
6841 2007-10-07 Jb Evain <jbevain@novell.com>
6843 * attribute.cs (Attribute.GetString): if the value
6844 expression is a StringConstant, return its string value.
6846 2007-10-07 Jb Evain <jbevain@novell.com>
6848 * typemanager.cs: add `assembly_version_attribute_type`.
6849 * codegen.cs: on attribute emission, check that the
6850 AssemblyVersionAttribute doesn't overflow.
6852 2007-10-05 Marek Safar <marek.safar@gmail.com>
6854 A fix for bug #324677
6855 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6856 parent container of a scope container with currently resolved one.
6858 2007-10-05 Marek Safar <marek.safar@gmail.com>
6860 A fix for bug #325534
6861 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6864 2007-10-05 Marek Safar <marek.safar@gmail.com>
6866 A fix for bug #327504
6867 * class.cs (Operator.Define): Refactored implicit and explicit user
6868 operator conversion rules.
6870 2007-10-05 Marek Safar <marek.safar@gmail.com>
6872 A fix for bug #327520
6873 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6875 2007-10-04 Marek Safar <marek.safar@gmail.com>
6877 A fix for bug #328022
6878 * class.cs (MethodData.Define): Use correct method to check whether
6879 a method implementents an accessor.
6881 2007-10-04 Marek Safar <marek.safar@gmail.com>
6883 A fix for bug #330069
6884 * statement.cs (Fixed.Resolve): Read the first array element only when
6885 an array is instantiated.
6887 2007-10-04 Marek Safar <marek.safar@gmail.com>
6889 * expression.cs, assign.cs, generics.cs: Print correct operator when
6890 compound assignment is used.
6892 2007-10-04 Marek Safar <marek.safar@gmail.com>
6894 A fix for bug #325841
6895 * expression.cs (ArrayAccess): Use full argument cloning only for
6896 string compound concatenation.
6898 2007-10-03 Marek Safar <marek.safar@gmail.com>
6900 A fix for bug #328774
6901 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6903 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6906 2007-10-03 Raja R Harinath <rharinath@novell.com>
6909 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6910 Event accessibility checks here. Remove some bogus code that
6911 accidently made GenericMethods work.
6912 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6914 2007-09-25 Marek Safar <marek.safar@gmail.com>
6916 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6918 * statement.cs (Block): Refactored AddVariable to allow error handling
6921 * generic.cs: New stub.
6923 2007-09-23 Marek Safar <marek.safar@gmail.com>
6925 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6928 2007-09-17 Marek Safar <marek.safar@gmail.com>
6930 * class.cs: Use partial container to record whether any partial part
6931 contains static field initializer and therefore default contructor has
6934 2007-09-14 Marek Safar <marek.safar@gmail.com>
6936 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6937 mono-list when only one of two partial parts has defined accessibility
6940 2007-09-14 Marek Safar <marek.safar@gmail.com>
6942 A fix for bug #82845
6944 * class.cs (TypeContainer): Set correct resolve context for all field
6947 2007-09-13 Marek Safar <marek.safar@gmail.com>
6949 * assign.cs: Fixed a crash when field is resolved twice with an error.
6951 * codegen.cs: Changed InFieldInitializer to be flag.
6953 * anonymous.cs, ecore.cs, expression.cs: Update after
6954 IsInFieldInitializer rename.
6956 * const.cs: Removed unused parameter.
6958 * class.cs: Changed the way how we resolve and emit field initializers.
6959 The field initilizers have to have access to contructor block to emit
6960 compiler generated code.
6962 2007-09-13 Marek Safar <marek.safar@gmail.com>
6964 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6965 generics use TypeContainer instead.
6967 2007-09-12 Marek Safar <marek.safar@gmail.com>
6969 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6971 * lambda.cs (ResolveParameters): Use more powerful
6972 InflateGenericArgument.
6974 * parameters.cs: Better exception message.
6976 2007-09-10 Marek Safar <marek.safar@gmail.com>
6978 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6979 correct expression block type.
6981 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6983 * expression.cs (Invocation): Extracted method group resolve to
6986 2007-09-07 Marek Safar <marek.safar@gmail.com>
6988 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6989 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6991 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6992 generic extension methods.
6994 2007-09-06 Marek Safar <marek.safar@gmail.com>
6996 A fix for bug #82676 (Do I get it right now?)
6997 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6998 object before a standard conversion is applied.
7000 2007-09-06 Marek Safar <marek.safar@gmail.com>
7002 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
7005 2007-09-05 Marek Safar <marek.safar@gmail.com>
7007 A fix for bug #82676
7008 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
7009 non-generic interface types.
7011 2007-09-05 Marek Safar <marek.safar@gmail.com>
7013 A fix for bug #82690
7014 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
7016 2007-09-05 Marek Safar <marek.safar@gmail.com>
7018 A fix for bug #82571
7019 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
7020 modifier for container based methods.
7022 2007-09-05 Marek Safar <marek.safar@gmail.com>
7024 A fix for bug #82676
7025 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
7026 any interface-type T means to any of interface type T.
7028 2007-09-04 Marek Safar <marek.safar@gmail.com>
7030 * namespace.cs: We have 2 versions of System.Core assembly.
7032 2007-09-04 Marek Safar <marek.safar@gmail.com>
7034 A fix for bug #82652
7035 * class.cs (Class.GetClassBases): Compare types and not expressions.
7037 2007-09-04 Marek Safar <marek.safar@gmail.com>
7039 A fix for bug #82620
7040 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
7041 actually never worked before.
7042 (IndexerAccess): Emit prepared arguments before they are modified.
7044 2007-09-04 Marek Safar <marek.safar@gmail.com>
7046 A fix for bug #82563
7047 * assign.cs: Revert wrong fix.
7049 * expression.cs (VariableReference.EmitAssign): Handle ref reference
7051 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
7052 Instead of ldelema/stdind we have to use temporary variables to handle
7053 cases like String.Concat (params string[]).
7055 2007-08-31 Marek Safar <marek.safar@gmail.com>
7057 * class.cs: EmitAttributes to Emit rename.
7059 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
7061 (MemberCore.HasClsCompliantAttribute): Don't depend on
7062 GetClsCompliantAttributeValue execution.
7064 2007-08-31 Marek Safar <marek.safar@gmail.com>
7066 * anonymous.cs: Use shorter type prefix.
7068 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
7071 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
7072 variables when probing is on.
7074 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
7075 unresolved variables.
7076 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
7077 handle transparent identifiers.
7079 2007-08-26 Marek Safar <marek.safar@gmail.com>
7081 * attribute.cs (IsClsCompliant): Add nullable types test.
7083 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
7085 * doc.cs : catch other types of exception than XmlException to
7086 report CS1570. Fixed bug #82565.
7088 2007-08-23 Marek Safar <marek.safar@gmail.com>
7090 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
7091 The number of delegate parameters has to match.
7092 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
7095 2007-08-21 Marek Safar <marek.safar@gmail.com>
7097 * anonymous.cs (AnonymousMethod): Generate private anonymous method
7098 to fix problem with private arguments.
7100 2007-08-20 Marek Safar <marek.safar@gmail.com>
7102 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
7104 * decl.cs (MemberName): Ignore generic type with no generic arguments.
7106 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
7107 empty. Add cloning suport.
7109 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
7111 2007-08-20 Marek Safar <marek.safar@gmail.com>
7113 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
7114 to create EmptyCast. It handles EmptyConstantCast specialization for
7117 2007-08-18 Marek Safar <marek.safar@gmail.com>
7119 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
7120 (EmitArrayArgument): One routine for array arguments.
7121 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
7123 2007-08-17 Marek Safar <marek.safar@gmail.com>
7125 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
7127 2007-08-17 Marek Safar <marek.safar@gmail.com>
7129 * anonymous.cs: MemberLookupFinal update.
7131 * class.cs (ConstructorInitializer): Is expression based.
7133 * delegate.cs: MethodGroupExpr update.
7135 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
7137 (Error_MemberLookupFailed): Customizable error override.
7138 (MethodGroupExpr): Keep queried type for later usage.
7139 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
7142 * expression.cs: Error_MemberLookupFailed refactoring.
7143 (New.DoResolve): Resolve as much as possible.
7144 (ElementInitializer.Error_MemberLookupFailed): Object initializer
7145 customization for invalid member types.
7147 * statement.cs: MethodGroupExpr update.
7149 2007-08-16 Marek Safar <marek.safar@gmail.com>
7151 * modifier.cs (Check): Check all modifiers and not only accessibility
7154 2007-08-16 Marek Safar <marek.safar@gmail.com>
7156 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
7157 type and not an expression.
7159 2007-08-16 Marek Safar <marek.safar@gmail.com>
7161 * statement.cs (Catch.Clone): Type and variable can be null.
7163 2007-08-16 Marek Safar <marek.safar@gmail.com>
7165 A fix for bug #81979
7166 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
7167 I am really not sure whether this is the best fix.
7169 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
7172 2007-08-14 Marek Safar <marek.safar@gmail.com>
7174 ** C# 3.0 Object and collection initializers (major re-write)
7176 * assign.cs (DoResolve): Initializers are not assign related.
7178 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
7179 used during collection or object initialization.
7181 * expression.cs (Error_InvalidArguments): Add initializers specific
7182 messages. More will come later because it requires some general
7184 (New.DoResolve): Better error handling for unsafe types.
7185 (EmptyExpressionStatement): New class.
7186 (ElementInitializer): An object initializer expression.
7187 (CollectionElementInitializer): A collection initializer expression.
7188 (CollectionOrObjectInitializers): A block of object or collection
7190 (NewInitialize): New expression with element/object initializers.
7192 * statement.cs: Reverted object/collection initializer hacks.
7194 * typemanager.cs (CSharpName): Filter __arglist type.
7196 2007-08-09 Marek Safar <marek.safar@gmail.com>
7198 ** C# 3.0 Anonymous Types (update to the latest standard)
7200 * expression.cs (Binary.ResolveOperator): Threat all null based types
7202 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
7203 (AnonymousTypeParameter): Updated.
7205 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
7206 (AnonymousTypeClass): New anonymous type container.
7208 * class.cs (AddField): Return operation result.
7210 * generic.cs: Another empty TypeArguments overload.
7212 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
7213 are stored at top of normal hierarchy.
7215 * typemanager.cs (CSharpName): Filter anonymous types.
7217 2007-08-09 Marek Safar <marek.safar@gmail.com>
7219 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
7220 as single Concat call. How could we miss that :-(
7222 2007-08-08 Marek Safar <marek.safar@gmail.com>
7224 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
7226 2007-08-07 Miguel de Icaza <miguel@novell.com>
7228 * expression.cs: Fix the previous commit, the creation of the
7229 arguments array list needs also to be conditional on the arguments
7232 * class.cs: Add a little bit of help to help narrow down problems.
7234 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
7235 not try to copy in that case.
7237 * driver.cs: When building SMCS, include a new different set of
7238 default assemblies here. Do this here so we can control whether
7239 to include the default assemblies with /noconfig.
7241 2007-08-03 Marek Safar <marek.safar@gmail.com>
7243 A fix for bug #81979
7244 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
7247 2007-08-03 Marek Safar <marek.safar@gmail.com>
7249 A fix for bug #82300
7251 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
7252 we are in probing scope.
7254 2007-08-03 Marek Safar <marek.safar@gmail.com>
7256 A fix for bug #82301
7258 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
7259 (Statement.CloneTo): Clone and not map children blocks.
7261 2007-08-03 Marek Safar <marek.safar@gmail.com>
7263 A fix for bug #82299
7265 * expression.cs (LocalVariableReference.CloneTo): Remap local info
7268 * statement.cs (Statement.CloneTo): Clone variables before statements
7269 to allow remaping of local variables.
7271 2007-08-03 Marek Safar <marek.safar@gmail.com>
7273 A fix for bug #82296
7276 * report.cs: Log crash details for future clone problems.
7278 * statement.cs (Return.Clone): Don't clone non-existent expression.
7280 2007-08-03 Raja R Harinath <harinath@gmail.com>
7282 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
7283 (Class.AddBasesForPart): Move CS0537 check here from ...
7284 * cs-parser.jay (class_declaration): ... here. Move calling of
7285 'AddBasesForPart' to ...
7286 (class_bases): ... here.
7287 (struct_declaration, interface_declaration): Update to changes.
7289 2007-08-02 Marek Safar <marek.safar@gmail.com>
7291 A fix for bug #81923
7293 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
7294 conversion is allowed.
7296 2007-08-02 Marek Safar <marek.safar@gmail.com>
7298 A fix for bug #81564
7300 * ecore.cs (EventExpr): Add IsBase handling.
7302 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
7305 2007-08-02 Raja R Harinath <harinath@gmail.com>
7307 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
7308 * cs-parser.jay: Some whitespace cleanups.
7309 (current_delegate): New.
7311 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
7312 a dummy code block, and use 'type_name' instead of 'member_name'.
7313 (interface_declaration, class_declaration): Likewise.
7314 (delegate_declaration): Likewise. Rearrange slightly and use
7316 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7317 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7319 2007-08-02 Marek Safar <marek.safar@gmail.com>
7321 A fix for bug #82039
7323 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7326 * typemanager.cs (CSharpName): Split to string overload.
7328 2007-08-02 Marek Safar <marek.safar@gmail.com>
7331 * report.cs: Updated warning CS0472.
7333 2007-08-01 Marek Safar <marek.safar@gmail.com>
7335 A fix for bug #82181
7337 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7339 2007-08-01 Marek Safar <marek.safar@gmail.com>
7341 A fix for bug #82277
7342 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7344 2007-08-01 Marek Safar <marek.safar@gmail.com>
7346 ** C# 3.0 Type Inference (major bits are working)
7348 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7349 (.ImplicitStandardConversionExists): Uses compatible.
7350 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7351 (.InferReturnType): New method.
7352 (.Compatible): Refactored.
7353 (.ResolveParameters): Uses factory to create resolved parameters.
7354 (.CompatibleMethod): Add probing mode support.
7355 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7356 clearly distinguish between 2 different operations.
7357 (LambdaMethod): Moved to lambda.cs.
7358 (AnonymousMethod): Removed unused fields and methods.
7359 (AnonymousDelegate): Simplified.
7361 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7363 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7365 * delegate.cs (Delegate): New mehods to reduce code duplication.
7366 (.GetConstructor): New method.
7367 (.GetInvokeMethod): New method.
7368 (DelegateCreation): Updated.
7370 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7372 (OverloadResolve): Made probing little bit faster.
7374 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7377 * generic.cs (TypeInferenceContext): Dummy implementation.
7379 * iterators.cs: Updated after Resolve/Define rename.
7381 * lambda.cs (LambdaExpression)
7382 (.ResolveParameters): Handles both type of arguments and type inference too.
7384 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7385 (InflateTypes): Updated.
7387 * support.cs (InflateTypes): Changed signature and updated.
7389 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7390 (MemberLookup_FindMembers): More MS tricks.
7391 (GetParameterData): Ditto.
7392 (GetDelegateParameters): Uses quick path for dynamic types.
7394 2007-08-01 Marek Safar <marek.safar@gmail.com>
7396 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7399 2007-07-31 Marek Safar <marek.safar@gmail.com>
7401 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7404 2007-07-26 Jb Evain <jbevain@novell.com>
7406 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7407 which takes a boolean 'report_errors', similar to the GetMethod.
7408 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7409 in .net 2.1, do not report errors here.
7411 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7412 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7413 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7416 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7417 of the type InternalsVisibleToAttribute before the first call
7418 to CoreLookupType which is allowed to fail (third boolean parameter
7419 to true). Because, during the resolution for a type that is not
7420 immediately found, we try to check if the type is not defined in
7421 a friend assembly, and to do so, we need the
7422 InternalVisibleToAttribute.
7424 2007-07-23 Miguel de Icaza <miguel@novell.com>
7426 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7427 feature that allows structs to be compared against null and inline
7428 the result as true or false.
7430 Notice that the same code is not permitted inside a generic block
7431 of code that would do:
7433 class Foo<T> where T : struct {
7440 It is only allowed if the type of T is not bound (no where
7441 clause). In my opinion, this CSC 2 behavior is broken but people
7442 seem to be using it (IronRuby does, a few bug reports on bugzilla
7443 have it and some people have complained about it).
7445 All of the users that depend on this behavior have code that is
7448 * report.cs (Warning, Error): make these take object arguments,
7449 not strings, as that allows us to take advantage of Format.
7451 2007-07-20 William Holmes <billholmes54@gmail.com>
7453 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7454 Left member variable for the Count.
7455 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7456 MemberName.CountTypeArguments to avoid a NRE.
7458 This code is contributed under the MIT X11 license
7460 2007-07-18 Marek Safar <marek.safar@gmail.com>
7462 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7464 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7466 * doc.cs : generic method arguments are written as ``x while generic
7467 type arguments are `x. Combined with the previous change, fixed bug
7470 2007-07-18 Raja R Harinath <rharinath@novell.com>
7473 * expression.cs (Binary.ResolveOperator): When converting
7474 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7476 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7478 * doc.cs : when T: or whatever x: is specified, it does not really
7479 check the doc comment's syntax correctness. Fixed bug #82006.
7481 2007-07-18 Marek Safar <marek.safar@gmail.com>
7483 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7484 LambdaExpression better.
7486 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7488 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7490 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7491 as it can be generated.
7493 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7496 * lambda.cs (LambdaExpression): Refactored to share same code with
7497 AnonymousMethodExpression.
7499 2007-07-17 Marek Safar <marek.safar@gmail.com>
7501 * anonymous.cs (MakeName): Include host name for easier debugging.
7502 (LambdaMethod): New class for lambda spcecific stuff.
7504 * attribute.cs: Set EmitContext return type.
7506 * class.cs: Set EmitContext return type.
7508 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7509 with null/void meaning.
7511 * iterators.cs (ContainerType): Implemented.
7513 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7515 * statement.cs (Return): Updated to lambda expressions.
7516 (Block.CloneTo): Parent can be null.
7518 2007-07-13 Marek Safar <marek.safar@gmail.com>
7520 A fix for bug #81917
7521 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7523 * class.cs (FixedField): Check whether field is in unsafe scope.
7525 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7526 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7528 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7531 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7533 2007-07-13 Marek Safar <marek.safar@gmail.com>
7535 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7536 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7539 2007-07-13 Marek Safar <marek.safar@gmail.com>
7541 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7543 2007-07-13 Marek Safar <marek.safar@gmail.com>
7545 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7546 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7548 * codegen.cs(EmitContext): Add ProbingMode flag.
7550 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7552 * driver.cs: For now set both warning values.
7554 * ecore.cs (SimpleName): Name is readonly.
7555 (MethodGroup.OverloadResolve): One quick path for probing.
7557 * expression.cs (Unary): Set Oper r/o.
7558 (Binary): Set Oper r/o.
7559 (ParameterReference): Set few instance variables as r/o.
7560 (ParameterReference.DoResolveBase): Don't capture aruments when
7562 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7563 (Arglist): arguments are private.
7564 (SizeOf): type is private and r/o.
7565 (MemberAccess): arguments are private.
7567 * report.cs: Enhanced reporting on/off capabilities.
7569 * lambda.cs: Uses ec.IsInProbingMode.
7570 (ContextualReturn): Derives from return.
7572 * rootcontext.cs: For now set both warning values.
7574 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7576 (Return.Resolve): Don't die immediately.
7577 (Block.Resolve): Speed-up probing.
7578 (Block.CloneTo): Clone only child blocks.
7580 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7582 * iterators.cs: reverted Miguel's latest change (r81925) as it
7583 breaks the build in System.
7585 2007-07-13 Miguel de Icaza <miguel@novell.com>
7587 * iterators.cs (Yield.CheckContext): Check for the iterator type
7588 also here as we can call into Yield even in codepaths that are not
7590 (MethodOrOperator is the only path that was checked).
7592 In addition to the standard check, use a more specific check for
7593 constructors to report a more verbose error.
7595 2007-07-12 Miguel de Icaza <miguel@novell.com>
7597 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7598 report the warning and continue
7600 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7601 values on the stack on the call to Emit. Use EmitStatement if
7602 possible, or using Emit + Pop if not possible. Fixes #82064
7604 2007-07-12 Raja R Harinath <rharinath@novell.com>
7606 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7607 avoid try...finally in some cases.
7609 2007-07-10 Marek Safar <marek.safar@gmail.com>
7611 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7613 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7614 instead of method. Re-use standard error handling.
7615 (ConstructorInitializer.Emit): Simplified.
7617 * delegate.cs: Updated after Invocation.EmitCall change.
7619 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7620 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7621 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7622 method and don't permanently changing input arguments.
7623 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7624 is resolved it has one of the candidates is the best one which is later
7625 used to emit. Removed a few unused method.
7626 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7628 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7629 (Binary.ResolveOperator): Ditto.
7630 (ConditionalLogicalOperator.DoResolve): Ditto.
7631 (Invocation): Uses method group.
7632 (Invocation.DoResolve): Simplified.
7633 (Invocation.EmitCall): Removed useless is_static.
7634 (Invocation.Emit): Delegate to method group.
7635 (Invocation.EmitStatement): Simplified.
7636 (New): Uses method group.
7637 (MemberAccess.DoResolve): Don't destroy original expression.
7639 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7641 2007-07-04 Marek Safar <marek.safar@gmail.com>
7643 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7646 * lambda.cs: Add custom error message type.
7648 2007-07-03 Marek Safar <marek.safar@gmail.com>
7650 * lambda.cs: Simplified little bit.
7652 * parameter.cs: Introduced ImplicitLambdaParameter.
7653 (Parameters.CreateFullyResolved): New factory instead of ctor.
7657 * delegate.cs: Updated parameter creation.
7659 2007-07-03 Marek Safar <marek.safar@gmail.com>
7661 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7664 * generic.cs: Synchronized with gmcs.
7666 2007-07-03 Marek Safar <marek.safar@gmail.com>
7668 * class.cs (Indexer): Check return type as soon as possible.
7670 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7673 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7675 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7677 * parameter.cs (Parameter): Use expression type when it is available.
7679 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7680 method modifier for the first parameter only.
7682 2007-06-24 Marek Safar <marek.safar@gmail.com>
7684 A fix for bug #81938
7685 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7687 * constant.cs: Tide up an exception message.
7689 2007-06-22 Marek Safar <marek.safar@gmail.com>
7691 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7692 an uninitialized variable is used.
7694 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7696 2007-06-22 Marek Safar <marek.safar@gmail.com>
7698 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7699 not found error handling.
7701 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7703 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7704 (ArrayCreation.DoResolve): Simplified.
7705 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7706 its own resolve process.
7707 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7709 2007-06-20 Marek Safar <marek.safar@gmail.com>
7711 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7714 2007-06-20 Marek Safar <marek.safar@gmail.com>
7716 * cs-tokenizer.cs: Removed var related stuff.
7718 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7719 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7720 a type and a keyword at same time.
7722 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7725 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7726 implicitly typed arrays, more changes will follow.
7728 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7730 2007-06-19 Marek Safar <marek.safar@gmail.com>
7732 * ecore.cs (VarExpr): Removed Handled field.
7734 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7735 build-in assign functionality.
7736 (ForEach.Resolve): Removed all implicitly typed local variable code and
7738 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7739 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7741 2007-06-18 Marek Safar <marek.safar@gmail.com>
7743 * assign.cs: Removed implicitly typed local variable check.
7745 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7746 referencing implicitly typed local variable.
7747 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7750 * statement.cs (Fixed): Removed unsupported implicitly typed local
7753 2007-06-15 Marek Safar <marek.safar@gmail.com>
7755 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7757 2007-06-14 Marek Safar <marek.safar@gmail.com>
7759 A fix for bugs #81855 and #76274
7760 * attribute.cs (AttachTo): Always set owner for global attributes to
7763 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7766 * cs-parser.jay: Assembly and module attributes must precede all other
7767 elements except using clauses and extern alias declarations.
7769 2007-06-13 Marek Safar <marek.safar@gmail.com>
7771 A fix for bug #81748
7773 * expression.cs: More checks for non ISO-1 features.
7775 2007-06-12 Marek Safar <marek.safar@gmail.com>
7777 A fix for bug #81807
7778 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7779 present inside switch statement and it is required by nullable check.
7781 2007-06-12 Marek Safar <marek.safar@gmail.com>
7783 A fix for bug #81840
7784 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7785 when type matching fails.
7787 * namespace.cs: Tiny error message change.
7789 2007-06-12 Marek Safar <marek.safar@gmail.com>
7791 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7792 reporting. Added automatic property check.
7794 * class.cs: Updated after CheckAbstractAndExtern relocation.
7795 (AEventPropertyAccessor.GetSignatureForError): Customized.
7797 2007-06-11 Marek Safar <marek.safar@gmail.com>
7799 * class.cs (DefineBaseTypes): Base type can be undefined.
7801 * ecore.cs (TypeLookup): Minor refactoring.
7802 (DoResolveAsTypeStep): Removed redundant check.
7804 * namespace.cs (Lookup): Removed redundant check.
7806 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7807 ResolveAsTypeTerminal step.
7808 (BootstrapCorlib_*): Simplified.
7809 (PopulateCoreType): Core types can be now external.
7811 2007-06-07 Marek Safar <marek.safar@gmail.com>
7813 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7815 (InferTypeArguments): Infers anonymous expression type arguments.
7816 (Compatible): Split to Compatible and InferTypeArguments.
7818 * lambda.cs: Updated.
7820 2007-06-08 Marek Safar <marek.safar@gmail.com>
7822 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7824 2007-06-07 Raja R Harinath <harinath@gmail.com>
7826 Fix #80477, cs0135-2.cs, cs0135-3.cs
7827 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7828 names to the "known" variables list.
7829 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7830 parameter names are also "known".
7831 (Block.CheckError136): Remove.
7832 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7835 2007-06-07 Marek Safar <marek.safar@gmail.com>
7837 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7839 2007-06-06 Marek Safar <marek.safar@gmail.com>
7841 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7842 internal error not an user error.
7844 * expression.cs (IsApplicable): Refactored to make debugging easier.
7846 * support.cs: More tricks for non-mono runtimes.
7848 * typemanager.cs (CoreLookupType): Made public.
7849 (InitSystemCore): All linq specific stuff moved to linq.cs
7851 2007-06-05 Marek Safar <marek.safar@gmail.com>
7853 * typemanager.cs (CSharpSignature): One more missing build-in types
7855 More tricks for non-mono runtime.
7857 2007-06-05 Raja R Harinath <harinath@gmail.com>
7859 * statement.cs (Block.CheckError136_InParents): Remove.
7860 (Block.AddVariable): Use GetParameterInfo instead.
7861 (ToplevelBlock.ProcessArguments): Likewise.
7863 2007-06-04 Raja R Harinath <rharinath@novell.com>
7865 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7867 (ToplevelBlock.GetParameterInfo): Split out of ...
7868 (ToplevelBlock.GetParameterRefernce): ... this.
7869 (ToplevelBlock.ParameterMap): Remove.
7870 * expression.cs (ParameterReference): Update to use
7871 ToplevelParameterInfo.
7873 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7876 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7877 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7879 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7880 (ToplevelBlock.ProcessParameters) ... here.
7881 (ToplevelBlock..ctor): Invoke it.
7883 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7886 * statement.cs (IKnownVariable): New interface.
7887 (LocalInfo): Implement it.
7888 (ToplevelParameterInfo): New class.
7889 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7890 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7891 GetKnownVariableInfo.
7893 2007-06-03 Raja R Harinath <harinath@gmail.com>
7895 Partly speed up CS0136 error checks.
7896 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7897 'recurse' parameter.
7898 (Block.DoCheckError136): Only check errors in parameters. Move
7899 local variable checks ...
7900 (Block.AddVariable): ... here, and ...
7901 (ToplevelBlock.ResolveMeta): ... here.
7903 2007-06-02 Raja R Harinath <harinath@gmail.com>
7905 * statement.cs (Block.IsChildOf): Remove.
7907 * statement.cs (Statement.Clone): Move special case code ...
7908 (Block.CloneTo): ... here.
7910 2007-05-29 Raja R Harinath <rharinath@novell.com>
7912 * statement.cs (ToplevelBlock.container): Remove field. It's
7913 redundant with 'Parent'.
7914 (ToplevelBlock.ContainerBlock): Remove accessor.
7915 (ToplevelBlock..ctor): Update to changes. Register anonymous
7916 child with parent here, ...
7917 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7919 (start_anonymous): Don't save current_block.
7920 (top_current_block): Remove.
7922 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7923 (Block.Resolve): Update to changes.
7924 (Block..ctor): Move setting of "correct" 'Toplevel'
7925 and 'Explicit' fields to ...
7926 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7928 2007-05-27 Raja R Harinath <harinath@gmail.com>
7931 * statement.cs (Block.Implicit): Remove.
7932 (Block): Update to changes.
7933 * flowanalysis.cs: Likewise.
7935 Mildly speed up CheckInvariantMeaningInBlock
7936 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7937 Recursively call AddKnownVariable to all enclosing blocks.
7938 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7939 Remove recursive calls.
7940 (Block): Update to changes.
7942 New ExplicitBlock invariants
7943 * statement.cs (Block.Explicit): New field. It points to the
7944 immediately enclosing non-implicit block.
7945 (Block..ctor): Maintain the invariant.
7946 * cs-parser.jay: Take advantage of invariant.
7948 Introduce ExplicitBlock
7949 * statement.cs (ExplicitBlock): New.
7950 (ToplevelBlock): Derive from it.
7951 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7953 (Block.Implicit): Update to changes.
7954 * cs-parser.jay: Update to changes.
7957 * codegen.cs (EmitContext.IsLastStatement): Remove.
7958 * statement.cs (Block.DoEmit): Update to changes.
7960 2007-05-25 Raja R Harinath <rharinath@novell.com>
7962 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7963 modifying current_block directly.
7965 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7967 * class.cs: Implemented automatic properties (C# 3.0)
7968 Thanks to Marek for the help.
7970 2007-05-23 Raja R Harinath <rharinath@novell.com>
7972 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7973 variable as assigned, note also that all its components are
7975 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7977 2007-05-19 Marek Safar <marek.safar@gmail.com>
7979 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7980 member is marked as compiler generated.
7982 * decl.cs (MemberCore): Refactored ModFlags into property.
7984 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7985 (Check): Check only accessibility modifiers.
7987 2007-05-18 Raja R Harinath <rharinath@novell.com>
7989 Track all assignable slots in one bit array
7990 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7991 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7992 logic from VariableMap constructor here. Use the same 'offset'
7993 variable that's later used for computing offsets of local
7995 * flowanalysis.cs (UsageVector.parameters): Remove.
7996 (UsageVector): Update to changes.
7997 (VariableMap): Remove.
7999 Avoid creating ParameterMap in every block
8000 * statement.cs (Block.ParameterMap): Move ...
8001 (ToplevelBlock.ParameterMap): ... here.
8002 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
8004 * flowanalysis.cs (FlowBranching.param_map): Remove.
8005 (FlowBranching.UsageVector): Update to changes.
8006 (FlowBranchingToplevel.CheckOutParameters): Likewise.
8008 * statement.cs (Block.CloneTo): Clone Toplevel field too.
8010 * expression.cs (ParameterReference): Distinguish between block
8011 where parameter was referenced and declared.
8013 2007-05-18 Marek Safar <marek.safar@gmail.com>
8015 * flowanalysis.cs, statement.cs: Put back improved error handling.
8017 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
8021 Imporved object and collection initialization (C# 3.0).
8023 2007-05-15 Marek Safar <marek.safar@gmail.com>
8025 A fix for bug #81380
8026 * expression.cs (Is.DoResolve): Only value types have constant `is'
8029 2007-05-15 Raja R Harinath <rharinath@novell.com>
8031 * statement.cs (ToplevelBlock.child): Remove.
8033 2007-05-15 Raja R Harinath <harinath@gmail.com>
8035 Rationalize ResolveMeta: refactoring
8036 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
8037 out constant handling code into ...
8038 (Block.DoResolveConstants): ... this.
8040 Rationalize ResolveMeta: kill local_map
8041 * statement.cs (Block.local_map, Block.LocalMap): Remove.
8042 (Block.AssignableSlots): New.
8043 (Block.ResolveMeta): Make protected. Don't create a VariableMap
8044 for locals -- move code from VariableMap here. Avoid unnecessary
8046 * flowanalysis.cs (FlowBranching.local_map): Remove.
8047 (FlowBranching..ctor): Use Block.AssignableSlots.
8048 (VariableMap): Remove unused constructors.
8050 2007-05-11 Raja R Harinath <rharinath@novell.com>
8052 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
8054 2007-05-11 Marek Safar <marek.safar@gmail.com>
8056 * typemanager.cs (IsFriendAssembly): Should not be called for building
8059 2007-05-09 Marek Safar <marek.safar@gmail.com>
8061 * literal.cs (NullConstant): Print null in all cases.
8063 * expression.cs (Binary.ResolveOperator): Implemented delegate
8064 comparison based on C# 2.0 changes.
8066 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
8068 This code is contributed under the MIT X11 license
8070 The following enables support for several C# 3.0 language features:
8072 * cs-tokenizer.cs: Added support for the "var" keyword.
8074 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
8075 Added VarExpr class to facilitate type inferencing.
8077 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
8078 to support anonymous types.
8080 * assign.cs: Added support for type inferencing and initialization.
8082 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
8084 * expression.cs: Added implicit array support to ArrayCreation.
8085 Added 5 types and 1 interface:
8087 IInitializable Implementing classes can inject initializing
8088 statements after object instantiation.
8090 Initializer Stores data for object initialization.
8092 AnonymousType An expression for anonymous types.
8094 AnonymousTypeParameter Stores data about an anonymous type's field.
8096 NewInitialize An expression for object initialization.
8098 CollectionInitialize An expression for collection initialization.
8100 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
8103 2007-05-06 Marek Safar <marek.safar@gmail.com>
8105 A fix for bug #81500
8106 * cs-tokenizer.cs: Add special handling for coalescing operator.
8108 2007-05-06 Marek Safar <marek.safar@gmail.com>
8110 A fix for bug #81529
8111 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
8112 its value from base class until it is redefined.
8114 2007-05-02 Raja R Harinath <rharinath@novell.com>
8116 Fix regression in cs0631-3.cs
8117 * cs-parser.jay (operator_declarator): Add opt_attributes to error
8118 fallback. Make error fallback catch more cases.
8120 2007-05-01 Miguel de Icaza <miguel@novell.com>
8122 * cs-parser.jay: Allow parameters in operator declarations to have
8125 2007-04-27 Miguel de Icaza <miguel@novell.com>
8127 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
8130 * lambda.cs (ContextualReturn.Resolve): An expression is valid
8131 inside the ContextualReturn, it does not have to be an
8132 ExpressionStatement.
8134 2007-04-24 Miguel de Icaza <miguel@novell.com>
8136 * lambda.cs (ContextualReturn.Resolve): if the return type is not
8139 2007-04-23 Miguel de Icaza <miguel@novell.com>
8141 * anonymous.cs (AnonymousContainer): split the virtual Resolve
8142 method in two methods: ResolveNoDefine and Resolve.
8144 ResolveNoDefine will stop just after ResolveTopBlock has been
8147 Resolve will then continue by creating a method and issuing the
8148 call to method.Define ().
8150 (AnonymousMethod): Split and implement the new Resolve and
8151 ResolveNoDefine as well.
8153 * lambda.cs (LambdaExpression): Split the anonymous method
8154 resolution code into a separate routine (CoreCompatibilityTest)
8155 from DoCompatibleTest.
8157 (LambdaExpression.TryBuild): New method, this method tries to
8158 build the LambdaExpression with the given set of types to be used
8159 as the types for the various parameters of the lambda expression.
8161 If the compilation succeed with the given types, the infered type
8162 of the Anonymous method is returned, otherwise null is returned.
8164 2007-04-23 Marek Safar <marek.safar@gmail.com>
8166 A fix for bug #81414
8167 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
8169 2007-04-22 Miguel de Icaza <miguel@novell.com>
8171 * cs-tokenizer.cs: Change various identifiers here from the
8172 camelCasing to the recommended Linux-like style for instance
8173 variables from the Coding Guidelines.
8175 2007-04-19 Martin Baulig <martin@ximian.com>
8178 (Convert.ImplicitReferenceConversionCore): Allow conversions from
8179 System.Enum to System.ValueType.
8181 2007-04-13 Martin Baulig <martin@ximian.com>
8183 Rewrote implicit reference conversions. We need to distinguish
8184 between implicit reference conversions (13.1.4) and implicit
8185 boxing conversions (13.1.5).
8187 According to the spec, there's an an implicit conversion
8188 "From a one-dimensional array-type S[] to IList<T> and base
8189 interfaces of this interface, provided there is an implicit
8190 reference conversion from S to T." Note that this does not
8191 include boxing conversions.
8194 (Convert.ImplicitTypeParameterBoxingConversion): New method.
8195 (Convert.ImplicitReferenceConversion): Split into
8196 ImplicitReferenceConversionCore() and
8197 ImplicitBoxingConversionExist().
8198 (Convert.ImplicitReferenceConversionExists): Use the new
8199 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
8201 2007-04-12 Martin Baulig <martin@ximian.com>
8203 * convert.cs (Convert.ImplicitReferenceConversion): Move the
8204 `TypeManager.null_type' checks up to the top of the method.
8206 2007-04-11 Marek Safar <marek.safar@gmail.com>
8208 A fix for bug #81350
8209 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
8212 2007-04-11 Martin Baulig <martin@ximian.com>
8214 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
8215 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
8216 to make this work for generic classes; fixes #79561.
8218 2007-04-11 Martin Baulig <martin@ximian.com>
8220 * expression.cs (As): Add support for nullable types; fixes #79371.
8222 2007-04-11 Martin Baulig <martin@ximian.com>
8224 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
8225 `type.FullName' is null; fixes #80243.
8227 2007-04-11 Martin Baulig <martin@ximian.com>
8229 * expression.cs (Invocation.IsApplicable): Don't modify the method
8230 if type inference succeeded, but the method was not applicable.
8233 2007-04-10 Marek Safar <marek.safar@gmail.com>
8235 A fix for bug #81324
8236 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
8237 internal and external namespaces containers.
8239 2007-04-10 Martin Baulig <martin@ximian.com>
8241 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
8242 TypeManager.DropGenericMethodArguments() so we also call
8243 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
8245 2007-04-10 Martin Baulig <martin@ximian.com>
8247 * iterators.cs (Iterator.CreateIterator): Don't crash if
8248 `method.ReturnType' is null. This happens if something went wrong
8249 while resolving that typ (we already reported an error in this case).
8251 2007-04-10 Martin Baulig <martin@ximian.com>
8253 * expression.cs (New.DoResolve): Don't call CheckComImport() on
8254 generic interfaces; report the CS0144 directly.
8256 2007-04-10 Martin Baulig <martin@ximian.com>
8258 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
8259 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
8261 2007-04-10 Martin Baulig <martin@ximian.com>
8263 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
8265 2007-04-09 Raja R Harinath <rharinath@novell.com>
8268 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
8269 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
8272 * statement.cs (For.Resolve): If resolution fails, use
8275 2007-04-08 Marek Safar <marek.safar@gmail.com>
8277 * anonymous.cs (MakeName): Make faster and zero-based.
8278 (VerifyExplicitParameterCompatibility): Back to mode where generic
8279 parameter is ignored.
8280 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
8282 * class.cs (EmitType): Method can emit another new method.
8284 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
8286 * driver.cs: Updated.
8288 * lambda.cs: Reuse predefined empty parameters.
8290 * parameter.cs: Updated
8292 * support.cs: Implemented InflateTypes.
8294 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
8295 (InitSystemCore): Introduced to isolate 3.0 dependencies.
8297 2007-04-03 Martin Baulig <martin@ximian.com>
8301 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
8302 version of TypeManager.IsOverride() which also works with generic
8305 2007-04-03 Martin Baulig <martin@ximian.com>
8310 (Convert.ExplicitReferenceConversion): We need to cast when
8311 converting from IList<T> to S[].
8313 2007-04-01 Marek Safar <marek.safar@gmail.com>
8315 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8318 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8320 2007-03-31 Marek Safar <marek.safar@gmail.com>
8322 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8323 argument and return type inferring.
8325 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8326 (ReturnType): Turned to property.
8328 * statement.cs (Return): Implemented return type inferring.
8330 * support.cs (ReflectionParameters): Use local types if possible.
8332 2007-03-30 Raja R Harinath <rharinath@novell.com>
8334 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8335 (FlowBranching.UsageVector): Update to changes.
8337 Prepare to kill 'Reachability'
8338 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8339 argument of constructor.
8341 2007-03-29 Raja R Harinath <rharinath@novell.com>
8343 Prepare to kill 'Reachability'
8344 * flowanalysis.cs (UsageVector.is_unreachable): New.
8345 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8346 'reachability', and verify they're consistent.
8349 * expression.cs (New.EmitStatement): Handle type parameters here too.
8351 2007-03-29 Martin Baulig <martin@ximian.com>
8356 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8357 CompilerGeneratedClass.
8358 (ScopeInfo.EmitScopeInstance): Make this protected.
8359 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8360 `ec.CurrentAnonymousMethod.Scope == Scope'.
8362 * statement.cs (Block.ScopeInfo): Make this a property.
8364 2007-03-27 Raja R Harinath <harinath@gmail.com>
8366 Prepare to kill 'Reachability'
8367 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8368 (FlowBranching.UsageVector.Reachability): Remove property.
8369 (FlowBranching.UsageVector.IsUnreachable): New property.
8370 (FlowBranching.UsageVector.ResetBarrier): New.
8371 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8372 * codegen.cs, statement.cs: Update to changes.
8374 2007-03-27 Martin Baulig <martin@ximian.com>
8379 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8382 2007-03-26 Raja R Harinath <rharinath@novell.com>
8384 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8385 instead of TriState. Remove all mention of TriState.
8387 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8388 replaced by a boolean. Add boolean 'is_unreachable' field, check
8389 and maintain invariants.
8391 2007-03-25 Marek Safar <marek.safar@gmail.com>
8393 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8395 2007-03-25 Marek Safar <marek.safar@gmail.com>
8397 * expression.cs: Stop using obsolete 2.0 opcodes.
8399 2007-03-25 Marek Safar <marek.safar@gmail.com>
8401 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8402 one of the latests Martin's fixes.
8404 2007-03-23 Miguel de Icaza <miguel@novell.com>
8406 * expression.cs: On BigEndian systems, swap the bytes, temporary
8407 solution until we get a new bitconverter class.
8409 2007-03-23 Martin Baulig <martin@ximian.com>
8413 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8414 "Method" and "Method`1". Normally, a cache lookup is done on the
8415 "Method" form (ie. without the generic arity), but this one makes
8416 lookups on the full form work as well.
8418 2007-03-22 Raja R Harinath <rharinath@novell.com>
8420 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8423 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8425 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8426 ordered_member_list, to TypeBuilder to store members to be defined
8427 in the order they were parsed in.
8428 - ordered_explicit_member_list contains all properties indexers
8429 and methods that are defined as explicit implementation of an
8430 interface or base class.
8431 - ordered_member_list contains all properties indexers and methods
8432 that are not defined as explicit implementation of an interface
8435 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8436 functionality in these removed classes has been replaced with
8437 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8438 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8440 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8441 to CheckForDuplications inside GetMethod and SetMethod Define Method
8442 to handle method property and indexer name conflicts.
8446 All code is contributed under the MIT/X11 license.
8448 2007-03-20 Martin Baulig <martin@ximian.com>
8450 * class.cs (TypeContainer.Interfaces): Removed; they're now
8451 included in `TypeContainer.Types'.
8453 2007-03-20 Martin Baulig <martin@ximian.com>
8455 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8457 * class.cs (TypeContainer.CreateType): New public method. This is
8458 now called before DefineType() to create the TypeBuilders.
8459 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8460 has already been created by CreateType().
8461 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8462 don't resolve our base classes here; this has been moved into
8463 DefineBaseTypes(). We're now called from CreateType().
8464 (TypeContainer.DefineBaseTypes): New private method; resolve our
8465 base classes here. We're now called from DefineType().
8468 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8469 our types first to create all the TypeBuilders. After that, call
8470 TypeContainer.DefineType() on all the types which'll resolve their
8471 base classes and setup the resolve order.
8473 2007-03-20 Martin Baulig <martin@ximian.com>
8475 * class.cs (TypeContainer.Enums): Removed; they're now included in
8476 `TypeContainer.Types'.
8478 2007-03-20 Martin Baulig <martin@ximian.com>
8481 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8482 (TypeContainer.DoResolveMembers): Call DefineType() on our
8483 `compiler_generated' classes; moved here from DefineNestedTypes().
8486 (RootContext.ResolveTree): Call ResolveMembers() on all
8487 TypeContainer's in the `type_container_resolve_order'.
8489 2007-03-19 Marek Safar <marek.safar@gmail.com>
8491 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8493 2007-03-17 Marek Safar <marek.safar@gmail.com>
8495 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8496 implementation flags.
8498 2007-03-17 Marek Safar <marek.safar@gmail.com>
8500 * class.cs: More optimizations for type parameters.
8502 2007-03-15 Marek Safar <marek.safar@gmail.com>
8504 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8506 * ecore.cs, parameter.cs: More common code for both corlibs.
8508 * typemanager.cs (IsGenericMethod): Simplified.
8510 2007-03-15 Raja R Harinath <rharinath@novell.com>
8512 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8514 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8516 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8517 unconditionally. Simplify explanation.
8518 (Try.Resolve, Using.Resolve): Likewise.
8520 2007-03-15 Martin Baulig <martin@ximian.com>
8524 * decl.cs (DeclSpace): If we're a partial class, use our
8525 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8527 2007-03-15 Raja R Harinath <rharinath@novell.com>
8529 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8531 (FlowBranching.UsageVector): Update to changes.
8532 (FlowBranching.MergeSiblings): Likewise.
8533 * statement.cs: Likewise.
8535 2007-03-15 Martin Baulig <martin@ximian.com>
8540 (MemberCache): Added a special .ctor for type parameters.
8543 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8546 2007-03-09 Martin Baulig <martin@ximian.com>
8548 * enum.cs (Enum): Make this a TypeContainer.
8549 (EnumMember): Derive from `Const'.
8552 (Const.DoResolveValue): New protected virtual method; move most of
8553 the functionality of ResolveValue() here so we can override it in
8555 (Const.CreateConstantReference): Make this virtual.
8557 * class.cs (Kind): Add `Kind.Enum'.
8558 (TypeContainer.Emit): Don't emit the enums here; they're already
8559 in the `RootContext.typecontainer_resolve_order'.
8561 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8562 here; they're already in the `typecontainer_resolve_order'.
8564 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8565 TypeManager.DropGenericTypeArguments().
8568 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8569 (TypeManager.IsEnumType): Likewise.
8570 (TypeManager.EnumToUnderlying): Likewise.
8571 (TypeManager.IsEqual): Add support for enums.
8573 2007-03-12 Raja R Harinath <rharinath@novell.com>
8575 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8576 DefaultParameterValueAttribute to be undefined, say if System.dll
8579 2007-03-11 Marek Safar <marek.safar@gmail.com>
8581 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8584 2007-03-10 Marek Safar <marek.safar@gmail.com>
8586 * class.cs, parameter.cs: Unified parameters verification.
8588 2007-03-08 Martin Baulig <martin@ximian.com>
8590 * cs-parser.jay (constructor_header): Pass the location to the
8591 newly created TopLevelBlock.
8593 2007-03-07 Martin Baulig <martin@ximian.com>
8595 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8597 2007-03-06 Miguel de Icaza <miguel@novell.com>
8599 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8600 with the changes from David, fixes the build.
8602 2007-03-05 David Mitchell <dmitchell@logos.com>
8604 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8605 and its base interfaces to a one-dimensional array type S[],
8606 provided there is an implicit or explicit reference conversion
8609 2007-03-03 Marek Safar <marek.safar@gmail.com>
8611 * cs-tokenizer.cs: Implemented basic linq grammar.
8613 * driver.cs: Set linq lang version on demand.
8615 2007-02-26 Marek Safar <marek.safar@gmail.com>
8617 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8619 2007-02-25 Marek Safar <marek.safar@gmail.com>
8621 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8624 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8626 Check property and event extern attributes.
8628 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8631 2007-02-24 Marek Safar <marek.safar@gmail.com>
8633 A fix for bug #80407
8634 * ecore.cs: Don't report ambiguity error when methods have same parent.
8636 2007-02-23 Marek Safar <marek.safar@gmail.com>
8638 A fix for bug #80878
8639 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8641 2007-02-22 Marek Safar <marek.safar@gmail.com>
8643 * attribute.cs: Enable ExtensionAttribute presence test.
8645 2007-02-22 Marek Safar <marek.safar@gmail.com>
8647 * class.cs: Warn about missing GetHashCode only when Equals is override.
8649 * decl.cs: Check accessibility of type arguments.
8651 * typemanager.cs: Correctly report nullable array.
8653 2007-02-20 Marek Safar <marek.safar@gmail.com>
8655 * class.cs, report.cs: Capture more details when things go wrong.
8657 2007-02-20 Marek Safar <marek.safar@gmail.com>
8659 A fix for bug #80650
8660 * cs-parser.jay: Anonymous container starts at constructor declaration
8661 and not at block beginning because it has to be usable in constructor
8664 * statement.cs: Use context location and not block one for error reporting.
8666 2007-02-18 Marek Safar <marek.safar@gmail.com>
8668 A fix for bug #78712
8669 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8672 2007-02-18 Marek Safar <marek.safar@gmail.com>
8674 A fix for bug #80493 by Atsushi Enomoto
8675 * cs-parser.jay: Ignore invalid attribute target.
8677 2007-02-18 Marek Safar <marek.safar@gmail.com>
8679 * cs-tokenizer.cs: Ignore '\0' as white space character.
8681 2007-02-17 Miguel de Icaza <miguel@novell.com>
8683 * cs-parser.jay: Add support for lambda expressions to the mcs
8686 * lambda.cs: Only clone when we are probing, not on the final call
8687 (Compatible is the final call).
8689 * statement.cs (CloneContext): Introduce class to provide block
8690 remapping during clone.
8692 All statements Clone themselves now.
8694 (Clone): special handling for blocks, when we clone a block, we
8695 register the block inside this routine, as children of the block
8696 might trigger a lookup.
8698 * expression.cs: Add support for CloneContext in all expressions.
8700 2007-02-17 Marek Safar <marek.safar@gmail.com>
8702 A fix for bug #80493
8703 * statement.cs: Report ambiguous warning when interfaces are not related.
8705 2007-02-15 Marek Safar <marek.safar@gmail.com>
8707 C# 3.0 extension methods.
8709 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8710 cannot be used directly.
8712 * class.cs (Class.Emit): Emit extension attribute if any class method
8713 is extension method.
8714 (Method.Define): Add basic extension method validation conditions.
8715 (Method.Emit): Emit extension attribute for method.
8717 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8718 extension method exists. Currently we follow same approach as Microsoft
8719 does, emit even if a method or a class are private but this can change
8722 * cs-parser.jay: Add handling of `this' keyword in method parameters
8725 * decl.cs (DeclSpace.IsStaticClass): New property.
8726 (MemberCache.FindExtensionMethods): Looks for extension methods with
8727 defined name and extension type.
8729 * doc.cs: Updated after OverloadResolve changes.
8731 * driver.cs: Add new soft reference to System.Core.dll.
8733 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8734 (ExtensionMethodGroupExpr): Represents group of extension methods.
8736 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8737 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8738 to MethodGroupExpr and made non-static for easier customization.
8739 (Invocation.DoResolve): Add extension method lookup when no standard
8741 (MemberAccess.DoResolve): Try extension methods if no member exists.
8743 * modifiers.cs: Add METHOD_EXTENSION modifier.
8745 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8746 as well as candidate extension type.
8747 (ComputeNamespaces): When assembly constains extension methods registers
8749 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8750 extension method lookup.
8751 (Namespace.LookupExtensionMethod): Looks for extension method in this
8753 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8754 find a method which matches name and extensionType.
8756 * parameter.cs (Parameter): Add This modifer.
8757 (HasExtensionMethodModifier): New property.
8758 (Resolve): Add extension parameter check.
8759 (ModFlags): turned to property to exclude this modifier as it is not real
8761 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8763 * support.cs (ParameterData): Add ExtensionMethodType.
8764 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8766 * typemanager.cs: Add type and ctor extension attribute type.
8768 2007-02-15 Miguel de Icaza <miguel@novell.com>
8770 * report.cs (DisableErrors, EnableErrors): used to prevent error
8771 output when we are "trying" to compile various methods with
8774 * ecore.cs (Expression): Add Clone method that calls the virtual
8775 CloneTo method. The current CloneTo method in Expression throws
8776 an exception so we can track down all the places where this must
8777 be implemented (not using abstract, because that would be a lot of
8778 up-front-work before we can start testing the implementation
8781 Important: we only need Clone capabilities for expressions created
8782 by the parser, as the expressions we will be cloning are
8783 expressions in the pre-resolved state. This vastly simplifies
8786 (SimpleName): Add CloneTo that does nothing.
8787 (EmptyCast): Add CloneTo.
8789 * expression.cs (Binary): Implement CloneTo.
8790 (Invocation.IsApplicable): Store the current ec in
8791 EmitContext.TempEc and restore it on return. This is used so we
8792 do not have to sprinkle hundres of methods with an extra
8793 EmitContext, we know that the only user is the lambda expression
8794 ImplicitConversionExists code.
8796 (Argument): Add Cloning capabilities.
8797 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8798 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8799 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8800 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8801 IndexerAccess): Add Clone capability.
8803 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8805 (Argument): Add cloning capability.
8807 * assign.cs (Assign): Implement CloneTo.
8809 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8811 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8812 version by calling Convert with the EmitContext (that we are
8813 currently storing in ec, this is not great, but will do for now,
8814 to avoid passing EmitContext parameters to hundreds of functions
8815 that do not need them now).
8817 (SetExpression): Remove, it is not needed.
8819 (ContextualReturn): Implement CloneTo.
8821 * statement.cs (Statement): Implement cloning infrastructure,
8822 similar to expressions.
8824 (Block): Partial implementation of Clone for statements.
8826 (Return): Implement clone.
8828 * constant.cs (Constant.CloneTo): New method, does nothing.
8830 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8831 solution, until we decide how to exactly do this.
8833 2007-02-14 Marek Safar <marek.safar@gmail.com>
8835 A fix for bug #80493
8836 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8837 a property is override we need to use second accessor.
8839 2007-02-13 Marek Safar <marek.safar@gmail.com>
8841 A fix for bug #80418
8842 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8845 2007-02-13 Marek Safar <marek.safar@gmail.com>
8847 Another fix for bug #80749
8848 * pending.cs: Abstract class has priority over interfaces.
8850 2007-02-13 Marek Safar <marek.safar@gmail.com>
8852 Another fix for bug #80749
8853 * pending.cs: Abstract class has priority over interfaces.
8855 2007-02-13 Marek Safar <marek.safar@gmail.com>
8857 Another fix for bug #80749
8858 * pending.cs: Abstract class has priority over interfaces.
8860 2007-02-13 Marek Safar <marek.safar@gmail.com>
8862 Another fix for bug #80749
8863 * pending.cs: Abstract class has priority over interfaces.
8865 2007-02-13 Marek Safar <marek.safar@gmail.com>
8867 * class.cs Better error message.
8869 * driver.cs: Add shorter versions of -optimize option.
8871 2007-02-13 Martin Baulig <martin@ximian.com>
8873 * class.cs (Constructor.Emit): Check the return value of
8874 ec.ResolveTopBlock() and return on error.
8876 2007-02-13 Raja R Harinath <rharinath@novell.com>
8878 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8879 message to fix error message regression.
8881 2007-02-12 Marek Safar <marek.safar@gmail.com>
8883 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8885 2007-02-12 Marek Safar <marek.safar@gmail.com>
8887 A fix for bug #80749
8888 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8889 its parent container.
8891 * class.cs (DefineFieldInitializers): Each initializer can has different
8894 * const.cs: Updated.
8896 2007-02-11 Miguel de Icaza <miguel@novell.com>
8898 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8899 now all the heavy lifting to check that embedded statements or
8900 expressions have the right form is done in the ContextualReturn.
8902 (ContextualReturn): New class.
8904 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8905 method that can be invoked to report 201, so we do not replicate
8908 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8910 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8911 treating tabs as spaces.
8913 2007-02-09 Marek Safar <marek.safar@gmail.com>
8915 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8916 * assign.cs: Use full implicit conversion for right side check.
8918 2007-02-09 Marek Safar <marek.safar@gmail.com>
8920 * statement.cs (Switch): Switch over boolean type is not standardized.
8922 2007-02-08 Marek Safar <marek.safar@gmail.com>
8924 A fix for bug #80755
8925 * decl.cs (FindBaseEvent): Don't use method cache for events.
8927 2007-02-07 Marek Safar <marek.safar@gmail.com>
8929 * cs-parser.jay: Better syntax error handling.
8931 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8932 instead of underlying type value.
8934 2007-02-06 Marek Safar <marek.safar@gmail.com>
8936 * driver.cs: Check define identifier before is registered.
8938 * namespace.cs: Use existing error message.
8940 * report.cs: New warning.
8942 2007-02-06 Marek Safar <marek.safar@gmail.com>
8944 A fix for bug #80742
8945 * expression.cs: Delegate Invoke method can be called directly.
8947 2007-02-06 Marek Safar <marek.safar@gmail.com>
8949 A fix for bug #80676
8950 * class.cs (IsEntryPoint): The Main method can have params modifier.
8952 2007-02-04 Miguel de Icaza <miguel@novell.com>
8954 * parameter.cs (Parameter, Parameters): Add Clone method.
8956 * anonymous.cs (Compatible): Turn method into virtual method, so
8957 LambdaExpression can implement a different behavior.
8959 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8960 out the basic checking here, so it can be used by
8963 * lambda.cs: Introduce "Compatible" function that will do the
8966 2007-02-02 Marek Safar <marek.safar@gmail.com>
8968 * attribute.cs: Unified one error message.
8970 * class.cs (Class): Use type attributes and not properties to test static
8972 (IsEntryPoint): Don's pass local variable.
8974 * convert.cs: Removed duplicate check.
8976 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8978 * driver.cs: Don't crash when soft reference does not exist.
8980 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8981 (UsingEntry): Removed redundant allocation.
8983 * parameter.cs: Add fast path for type parameters.
8985 * support.cs: Don't allocate attribute when it's not used.
8987 2007-01-30 Miguel de Icaza <miguel@novell.com>
8990 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8991 this into a virtual method, so we can override it in LambdaExpression.
8993 * driver.cs: Improve diagnostics in case of failure.
8995 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8996 write a function that is slightly more complex and that parses:
8998 type identifier [, type identifier]* )
9000 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
9003 (canEmpty ? i >= 0 : i > 0)
9005 2007-01-30 Raja R Harinath <rharinath@novell.com>
9007 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
9008 exception on possibly valid code.
9010 2007-01-29 Raja R Harinath <rharinath@novell.com>
9012 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
9014 (parse_opt_type_arguments): Remove. It's almost the same as
9016 (parse_namespace_or_typename): Use parse_less_than.
9018 2007-01-28 Miguel de Icaza <miguel@novell.com>
9020 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
9021 this bug took a few hours to find, because the state saved and
9022 restored by PushPosition and PopPosition was ignoring the state of
9023 parse_generic_less_than.
9025 I can also now remove the handling of OP_LT and OP_GT, this solves
9028 * cs-tokenizer.cs: store the location for the ARROW token, we use
9031 (PushPosition, PopPosition): save/restore also `current_token',
9032 restore `parse_generic_less_than' (was missing).
9034 (parse_opt_type_arguments): use parse_type, not
9035 parse_namespace_or_typename to parse types.
9037 * lambda.cs: Empty new file, will eventually have the lambda
9038 expression implementation.
9040 * lambda.test: used to test the internal tokenizer.
9042 * report.cs (FeatureIsNotISO1): Rename from
9043 FeatureIsNotStandardized, because it was about the language level
9044 (1 vs 2) it was not about standarization.
9046 (FeatureRequiresLINQ): New.
9048 * support.cs (SeekableStreamReader): Only require that the reader
9049 is a TextReader, not a StreamReader, so we can plug StringReader.
9051 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
9052 given position in the input stream the following tokens can be
9053 parsed as a type followed by an identifier.
9055 (is_punct): after a '(' if parse_type_and_parameter returns true,
9056 then return a special token OPEN_PARENS_LAMBDA which is used to
9057 avoid reduce/reduce errors in the grammar for the
9058 lambda_expression rules.
9060 (parse_type): implement a type parser inside the
9061 tokenizer, the parser only returns true or false depending on
9062 whether the input at a given position can be parsed as a type.
9064 (peek_token): new method used during type parsing.
9066 2007-01-28 Raja R Harinath <rharinath@novell.com>
9069 * anonymous.cs (ScopeInfo.InflateParameters): New.
9070 (AnonymousContainer.Resolve): Use it to redirect types of
9071 delegate parameters.
9073 2007-01-27 Raja R Harinath <rharinath@novell.com>
9076 * expression.cs (Error_InvalidArguments): Don't use two different
9077 messages for CS1503. Use ExtraInformation and
9078 SymbolRelatedToPreviousError instead.
9081 * decl.cs (DeclSpace.initialize_type_params): Don't access
9082 'type_params' of a partial class directly.
9084 2007-01-26 Miguel de Icaza <miguel@novell.com>
9086 * constant.cs: Removed a handful of out-of-range checks that were
9089 2007-01-25 Marek Safar <marek.safar@gmail.com>
9091 * expression.cs (CheckUselessComparison): Add additional check for char
9094 * namespace.cs: Fixed typo.
9096 2007-01-23 Miguel de Icaza <miguel@novell.com>
9098 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
9099 gone, instead we inline the test, preventing the needless casts to
9100 longs, ulongs and doubles for the parameters, avoiding calls to
9101 methods that overchecked stuff, and instead inlined things
9104 2007-01-20 Marek Safar <marek.safar@gmail.com>
9106 * cs-parser.jay: Better parameter error handling.
9108 2007-01-17 Marek Safar <marek.safar@gmail.com>
9110 A fix for bug #80368, #80522
9111 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
9112 whether array initializer contains constants only.
9113 (ArrayCreation.Emit): Use better formula to decide when
9114 are array initializers for static initialization.
9115 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
9116 have to emit even constants otherwise they are pre-initialized.
9118 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
9119 Raja R Harinath <rharinath@novell.com>
9121 Fix emit order of 'get' vs. 'set'.
9122 * support.cs (Accessors): New.
9123 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
9124 Note the order in which accessors are declared in the source.
9125 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
9126 Refactored from Property.Define and Indexer.Define.
9127 (PropertyBase.DefineAccessors): New helper that calls the above in
9128 appropriate order as noted by the parser.
9129 (Property.Define, Indexer.Define): Update to changes.
9130 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
9132 2007-01-17 Raja R Harinath <rharinath@novell.com>
9134 Fix cs0029-6.cs and gcs0029-2.cs (regression)
9135 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
9136 there's an implicit conversion from the current type to the target
9137 type before converting the underlying constant.
9139 2007-01-16 Marek Safar <marek.safar@gmail.com>
9141 * const.cs (ResolveValue): Updated after constant conversion was made more
9144 * constant.cs (GetAttributableValue): constant to object conversion is
9145 used for attributes only.
9146 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
9147 constant conversions.
9148 (LongConstant.ConvertImplicitly): Ditto.
9150 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
9151 (ImplicitConversionStandard): Handle constant conversion as extra step.
9152 It solves the issue when constant conversion was called indirectly like
9153 inside array initializer and constant folding was skipped.
9155 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
9158 * statement.cs(ImplicitConversionStandard): Updated after constant
9159 conversion was made more generic.
9161 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
9163 * expression.cs (As.DoResolve): Use GenericConstraints instead of
9164 Constraints, solves the problem where the compiler incorrectly
9165 reported that a type parameter was not constrained to a class (Bug
9168 2007-01-14 Marek Habersack <grendello@gmail.com>
9170 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
9172 2007-01-14 Marek Safar <marek.safar@gmail.com>
9174 A fix for bug #80368
9175 * assign.cs (FieldInitializer): New class implements field
9176 initializer statement.
9178 * attribute.cs: Update after FieldMember rename.
9180 * class.cs (PropertyBasedMember): New common class for property based
9182 (InterfaceMemberBase): New base class for all members which can be used as
9183 an interface members.
9184 (MethodCore): Moved really common code to InterfaceMemberBase.
9185 (Method.Define): Equal and GetHasCode detection is relevant for methods
9187 (MethodData.Define): Don't assume that public event implements an
9188 interface automatically.
9189 (MethodData.DefineMethodBuilder): Issue an error even if only extern
9191 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
9192 (FieldMember): Merged with FieldBase.
9193 (EventProperty.AEventPropertyAccessor): New specialization to check whether
9194 event extern modifier can be used.
9195 (EventField.EventFieldAccessor): Moved event field specific code here.
9196 (Event.AllowedModifiers): Even event can be extern.
9197 (Event.FindOutBaseMethod): New override specific to events.
9198 (Indexer.parameters): Reintroduce parameters because base class holds
9199 only properties common data.
9200 (Indexer.CheckForDuplications): Indexers are threated as methods so we
9201 need do extra parameters check.
9203 * const.cs: Update after FieldMember rename.
9205 * decl.cs (MemberCache.FindBaseEvent): New method.
9207 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
9208 to reflect that indexer is now derived from PropertyBased.
9210 * ecore.cs (GetMemberType): Made public.
9211 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
9214 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
9216 * typemanager.cs (CSharpSignature): Correctly print event accessors.
9217 (RegisterEvent): Removed.
9218 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
9219 (GetPrivateFieldOfEvent): Renamed to GetEventField.
9221 2007-01-11 Raja R Harinath <rharinath@novell.com>
9224 * statement.cs (CollectionForeach.TryType): Prefer generic
9225 GetEnumerator over non-generic variant. Fix code to follow comments.
9227 2007-01-09 Raja R Harinath <rharinath@novell.com>
9230 * support.cs (ReflectionParameter): Don't use an invalid index on
9231 the generic parameter data.
9233 2007-01-08 Miguel de Icaza <miguel@novell.com>
9235 * driver.cs: Just add a tiny bit of infrastructure.
9237 2007-01-02 Marek Safar <marek.safar@gmail.com>
9239 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
9240 where field type is struct from current assembly.
9242 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
9245 2007-01-02 Marek Safar <marek.safar@gmail.com>
9247 A fix for bug #80381
9248 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
9251 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
9253 (Namespace.LookupType): Always use core types from corlib when speficied.
9255 * report.cs: A new warning.
9257 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
9258 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
9259 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
9261 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
9262 (InitCoreTypes): Set expression type of object_type and value_type
9263 immediately after lookup.
9265 2007-01-01 Miguel de Icaza <miguel@novell.com>
9267 * cs-tokenizer.cs: Accept Pc class characters (Connector
9268 Punctuation) as valid identifiers. Fixes #78259
9270 * expression.cs (Invocation.DoResolve): Moved the check for the
9271 use of `this' for doing method calls to the Invocation resolution
9272 step, after overload resolution has taken place instead of doing
9273 the check at the low-level `This.DoResolve' level.
9275 The `This.DoResolve'(appens before overload resolution, so it has
9276 no way of knowing if the method that will be called will be
9277 instace or static, triggering an erroneous report for cs0188 (Bug
9280 We now do the check for instance method invocations after we know
9281 what method will be called.
9283 (This.CheckThisUsage): Move the actual use of this structure
9284 checking into its own method and expose it.
9286 * Everywhere that called Error_ValueCannotBeConverted: pass a new
9289 Exceptions: Null.ConvertImplicitly,
9290 Constant.ImplicitConversionRequired as there are too many call
9291 sites for passing the ec.
9293 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
9294 EmitContext, if the value is null, then we do not try to provide
9295 the extra information from the error (If a userdefined conversion
9296 exists, as UserDefinedConversion requires a non null-EmitContext).
9300 2006-12-30 Raja R Harinath <rharinath@novell.com>
9302 * flowanalysis.cs (MyBitVector): Document some invariants.
9303 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
9304 introduced below, and add a couple of others,
9306 2006-12-30 Marek Safar <marek.safar@gmail.com>
9308 * attribute.cs (GetMethodObsoleteAttribute): Uses new
9309 GetPropertyFromAccessor and GetEventFromAccessor.
9311 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
9312 overrides non-obsolete one.
9313 (Indexer.Define): Error message has been moved to the parser.
9315 * cs-parser.jay: Better syntax errors handling.
9317 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9318 when an invocation has no arguments.
9320 * ecore.cs: Removed not used caching.
9322 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9325 * report.cs: Add a new warning.
9327 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9329 * typemanager.cs (enumeration_type): Removed.
9330 (CSharpSignature): Reuses IsSpecialMethod.
9331 (IsEqual): Hack for MS BCL.
9332 (GetPropertyFromAccessor): New method.
9333 (GetEventFromAccessor): New method.
9334 (IsSpecialMethod): Fixed to handle more cases.
9336 2006-12-30 Marek Safar <marek.safar@gmail.com>
9338 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9339 Made white spaces array static.
9341 * ecore.cs (RemoveGenericArity): Optimized.
9343 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9345 (MyBitVector.initialize_vector): Simplified.
9347 2006-12-22 Miguel de Icaza <miguel@novell.com>
9349 * ecore.cs: Am not entirely happy with this hack, but it seems to
9350 address the issue in 80257 (a small test case for
9353 I set the MethodGroupExpr.Type to an internal compiler type
9354 (itself in this case) to force the resolution to take place. Why
9355 it does not take place with a null is beyond me.
9357 2006-12-20 Marek Safar <marek.safar@gmail.com>
9359 A fix for bug #80288
9360 * expression.cs (ResolveOperator): Consider user defined conversion for
9361 logical and operator too.
9362 (EmitBranchable): Optimization for logical and when full constant folding
9363 could not be applied but one operand is constant.
9365 2006-12-19 Marek Safar <marek.safar@gmail.com>
9367 * class.cs (GetClassBases): Write 5 times every day, will never use
9368 FullName for error reporting.
9370 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9372 2006-12-19 Martin Baulig <martin@ximian.com>
9374 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9375 the symbol file info here.
9377 2006-12-18 Marek Safar <marek.safar@gmail.com>
9379 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9380 of `elseif' is taking then following sections are not taking.
9381 Fixes an issue reported on mono mailing list.
9383 2006-12-18 Marek Safar <marek.safar@gmail.com>
9385 A fix for bug #80300
9386 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9387 a caller is not taking.
9389 2006-12-18 Raja R Harinath <rharinath@novell.com>
9391 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9392 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9393 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9394 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9395 * class.cs: Update to changes.
9397 2006-12-17 Marek Safar <marek.safar@gmail.com>
9399 A fix for bug #79934
9400 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9403 * class.cs (ResolveMembers): Register an iterator in current container and
9406 2006-12-16 Raja R Harinath <rharinath@novell.com>
9409 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9410 satisfy a params annotated parameter.
9412 2006-12-16 Marek Safar <marek.safar@gmail.com>
9414 A fix for bug #77014
9415 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9416 paramters correctly and not rely on hacks in Parameters class.
9417 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9419 (Invocation.VerifyArgumentsCompat): Ditto.
9420 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9423 * parameter.cs (HasParams): Don't assume that params is the last one.
9425 * support.cs (ReflectionParameters.ctor): Look for params attribute
9427 (ReflectionParameters.ParameterType): Removed hack when we returned last
9428 parameter for out of range parameters.
9429 (ParameterName, ParameterModifier): Ditto.
9431 2006-12-14 Marek Safar <marek.safar@gmail.com>
9433 A fix for bug #79987
9434 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9435 when assembly is not CLS compliant but type is. I have no idea why is this
9438 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9440 2006-12-13 Miguel de Icaza <miguel@novell.com>
9442 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9443 in struct constructors, they are basically no-ops.
9445 2006-12-12 Marek Safar <marek.safar@gmail.com>
9447 * cs-tokenizer.cs (Position): Save preprocessor status too.
9449 2006-12-12 Marek Safar <marek.safar@gmail.com>
9451 A fix for bug #77794
9452 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9454 2006-12-12 Marek Safar <marek.safar@gmail.com>
9456 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9458 (pp_expr): Report error for an invalid expression.
9459 (handle_preprocessing_directive): Simplified; add more error checking.
9461 2006-12-11 Marek Safar <marek.safar@gmail.com>
9463 A fix for bug #74939
9464 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9465 directives handling.
9467 2006-12-10 Marek Safar <marek.safar@gmail.com>
9469 A fix for bugs #80093, and #75984
9470 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9471 logic, it seems to me as it worked before "by coincidence".
9472 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9473 (cleanup): Enabled endif check.
9475 2006-12-09 Marek Safar <marek.safar@gmail.com>
9477 A fix for bug #80162
9478 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9479 enumerators are never ambiguous.
9481 2006-12-08 Raja R Harinath <rharinath@novell.com>
9484 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9486 2006-12-06 Marek Safar <marek.safar@gmail.com>
9488 A fix for bug #80144
9489 * class.cs (EventProperty.Define): Explicit implementation means
9490 that an even is used.
9492 2006-12-06 Marek Safar <marek.safar@gmail.com>
9494 Fixes the operators implementation (part II)
9496 * cfold.cs (DoConstantNumericPromotions): Renamed to
9497 DoBinaryNumericPromotions and simplified.
9498 (BinaryFold): Couple of conversion fixes; simplified.
9500 * constant.cs, ecore.cs, literal.cs
9501 (ToType): Renamed to ConvertImplicitly.
9502 (Reduce): Renamed to ConvertExplicitly.
9504 * class.cs, convert.cs: Updated.
9506 * expression.cs: TryReduce doesn't throw an exception.
9508 2006-12-01 Marek Safar <marek.safar@gmail.com>
9510 A fix for bug #80108
9511 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9514 2006-11-30 Marek Safar <marek.safar@gmail.com>
9516 Fixes unary operators implementation (part I)
9519 * cfold.cs (Error_CompileTimeOverflow): Made internal
9521 * const.cs (IConstant): Changed to use reference to constant and
9522 not constant itself.
9523 Updated IConstant implementations.
9525 * constant.cs (CreateConstant): New factory method.
9526 Updated IConstant implementation.
9528 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9530 * ecore.cs: Updated to use CreateConstantReference.
9532 * enum.cs: Reflects IConstant changes.
9534 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9536 * literal.cs (NullConstant): Change to be independently usable.
9538 2006-11-29 Martin Baulig <martin@ximian.com>
9540 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9541 we need to emit the scope initializer before calling the base .ctor.
9543 * anonymous.cs: Merged back from the new anonymous methods branch.
9544 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9546 * expression.cs (ParameterReference.DoResolveBase): Create a
9547 "normal" ScopeInfo when capturing parameters rather than using the
9548 root scope; this makes things work with anonymous methods having
9552 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9554 2006-11-22 Marek Safar <marek.safar@gmail.com>
9556 A fix for bug #79987
9557 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9558 check to a base class.
9559 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9560 only when assembly has missing attribute.
9561 * report.cs: Update.
9563 2006-11-21 Marek Safar <marek.safar@gmail.com>
9565 * cs-tokenizer.cs: Merged with gmcs version.
9567 2006-11-20 Marek Safar <marek.safar@gmail.com>
9570 * cs-parser.jay: Better error message when partial keyword is misplaced.
9572 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9574 A fix for bug #79810
9575 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9576 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9577 a RuntimeWrappedException by default.
9579 2006-11-18 Marek Safar <marek.safar@gmail.com>
9581 A fix for bug #79843
9582 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9584 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9586 2006-11-18 Marek Safar <marek.safar@gmail.com>
9588 * driver.cs, namespace.cs: Uses faster IndexOf version.
9590 2006-11-17 Marek Safar <marek.safar@gmail.com>
9592 A fix for bug #79941
9593 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9595 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9596 even if internal name is different.
9597 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9598 (UserDefinedConversion): Simplified as the operators cannot be internal.
9599 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9601 (MethodLookup): Replaced EmitContext with parentType.
9602 * expression.cs: Updated.
9604 2006-11-09 Raja R Harinath <rharinath@novell.com>
9606 * driver.cs (BadAssembly): Handle all the ugliness of
9607 DefineDynamicAssembly.
9609 2006-11-08 Raja R Harinath <rharinath@novell.com>
9611 Address parts of #58244 -- most of what's left is in the runtime
9612 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9613 CS1509 error checks, and handle them for all assembly loads, not
9614 just the first invocation.
9615 (LoadModule): Likewise. Move handling of 'adder_method' ...
9616 * codegen.cs (AssemblyClass.AddModule): ... here.
9618 2006-11-02 Marek Safar <marek.safar@gmail.com>
9620 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9621 IEnumerable<T> is ambiguous.
9623 2006-10-31 Marek Safar <marek.safar@gmail.com>
9625 A fix for bug #67689
9626 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9627 GetEnumerator is ambiguous.
9629 * report.cs: Add new warning.
9631 2006-10-29 Marek Safar <marek.safar@gmail.com>
9633 A fix for bug #78602
9634 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9635 to protected member can be nested type.
9637 2006-10-28 Marek Safar <marek.safar@gmail.com>
9639 A fix for bug #78965
9640 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9641 to protected member must derive from current type.
9643 2006-10-27 Marek Safar <marek.safar@gmail.com>
9645 assign.cs: Reuses error method.
9647 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9648 instead of type for constants.
9649 (Expression.Error_ValueAssignment): Common error method.
9651 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9654 2006-10-27 Marek Safar <marek.safar@gmail.com>
9656 A fix for bug #79081
9657 * expression.cs (MemberAccess.DoResolve): Check nested type
9660 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9662 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9664 2006-10-26 Marek Safar <marek.safar@gmail.com>
9666 A fix for bug #76591
9667 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9669 2006-10-26 Marek Safar <marek.safar@gmail.com>
9671 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9672 type forwarder of the same type multiple times.
9674 2006-10-26 Raja R Harinath <rharinath@novell.com>
9677 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9678 instance as an rvalue, even when we later resolve as an lvalue.
9680 2006-10-25 Martin Baulig <martin@ximian.com>
9682 * anonymous.cs: Fix #79673.
9684 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9686 A fix for bug #79666
9687 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9688 ignored when is optimized (= default value) as its value is already set.
9690 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9692 A fix for bug #79724
9693 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9694 TypeContainer for type lookup.
9696 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9698 A fix for bug #79231
9699 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9700 * expression.cs (OverloadResolve): Always convert type name for
9702 (ResolveNamespaceOrType): Don't confuse a nested type with any
9705 2006-10-18 Martin Baulig <martin@ximian.com>
9707 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9709 2006-10-17 Miguel de Icaza <miguel@novell.com>
9711 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9712 an int32, but requesting an int64 from the conversion
9714 2006-10-12 Martin Baulig <martin@ximian.com>
9717 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9719 2006-10-12 Martin Baulig <martin@ximian.com>
9722 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9724 2006-10-11 Miguel de Icaza <miguel@novell.com>
9726 * convert.cs: Remove broken code: I was doing the "Existance"
9727 tests for Implicit conversions.
9729 2006-10-10 Miguel de Icaza <miguel@novell.com>
9731 * convert.cs: Added one missing case in
9732 ImplicitStandardConversionExists uint64 to intptr.
9736 * typemanager.cs (uintptr_type): another core known type.
9738 * ecore.cs (OperatorCast): routine used to do cast operations that
9739 depend on op_Explicit. We could change some of the Decimal
9740 conversions to use this.
9742 This one has a probe mechanism that checks both types for an op_
9743 which it coudl be used to eliminate two classes: CastToDecimal
9744 and CastFromDecimal.
9746 * convert.cs: Implement the conversions documented in #59800
9748 2006-10-10 Martin Baulig <martin@ximian.com>
9750 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9751 before RootScope.ResolveMembers().
9753 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9754 `CurrentType' if appropriate.
9756 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9758 A fix for bug #78568
9759 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9760 when contains binary operators.
9761 * cs-parser.jay: Updated.
9763 2006-10-09 Martin Baulig <martin@ximian.com>
9766 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9767 moved that into Define() and also do the other type parameter
9768 checks there. Fixes #79094. Added gtest-292.cs.
9771 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9772 since that doesn't include type parameters; don't use `Ldelema'
9773 for type parameters. Fixes #78980. Added gtest-293.cs.
9775 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9778 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9779 conversion is allowed.
9781 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9783 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9784 error reporting when no error occurs.
9786 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9788 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9791 2006-10-06 Raja R Harinath <rharinath@novell.com>
9794 * class.cs (DefineTypeBuilder): Check circular dependencies before
9795 setting the parent of the TypeBuilder.
9796 (CheckRecursiveDefinition): Don't use 'BaseType', since
9797 it may not be valid until after DefineTypeBuilder. Use
9798 'base_type' instead.
9800 2006-10-04 Martin Baulig <martin@ximian.com>
9802 Merged the Anonymous Methods patch.
9804 * anonymous.cs, iterators.cs: The new anonymous methods code.
9806 * statement.cs (Variable): New public abstract class.
9807 (LocalInfo.Variable): New public property.
9808 (LocalInfo.ResolveVariable): New public method.
9809 (Block.Flags): Add `IsIterator'.
9810 (Block.AddVariable): Improved the CS0136 check.
9811 (Block.AnonymousChildren): New public property.
9812 (Block.AddAnonymousChild): New public method.
9813 (ToplevelBlock): Update to use the new anonymous method framework.
9814 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9815 `ToplevelBlock'; this is required to correctly implement the
9817 (Fixed, Using): Use `TemporaryVariable' instead of directly
9818 creating the `LocalBuilder'.
9820 * parameter.cs (Parameter.ResolveVariable): New public method.
9821 (Parameters.ResolveVariable): Likewise.
9823 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9825 * class.cs (TypeContainer): Replaced the `iterators' list and
9826 corresponding methods with a list of `CompilerGeneratedClass'es.
9827 (TypeContainer.ResolveMembers): New public method.
9828 (Method): `IIteratorContainer' has been replaced by
9831 * expression.cs (VariableReference): New public abstract base
9832 class for `LocalVariableReference', `ParameterReference' and
9835 * codegen.cs (EmitContext): Removed `capture_context',
9836 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9837 (EmitContext.EmitThis): Removed.
9839 * cs-parser.jay: Replace `iterator_container' with
9842 2006-10-04 Martin Baulig <martin@ximian.com>
9844 * generic.cs (GenericMethod): Don't make this abstract.
9845 (Constraints.Clone): Added dummy implementation.
9847 2006-10-04 Raja R Harinath <harinath@gmail.com>
9850 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9851 'declspaces'. Avoid allocating arrays willy-nilly.
9854 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9855 cases out of the switch.
9857 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9859 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9860 message when non-generic type is used with the type arguments.
9861 * expression.cs: Updated.
9863 2006-09-28 Raja R Harinath <rharinath@novell.com>
9866 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9867 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9868 Change semantics slightly. Don't insist on having only one
9869 temporary EmptyExpression -- just throttle the creation of new ones.
9872 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9873 non-interfaces too. If no methods are found, don't try to create
9876 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9878 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9881 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9882 us produce better error message.
9884 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9886 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9887 of the `|' operator.
9889 * report.cs: A new warning added.
9891 2006-09-27 Martin Baulig <martin@ximian.com>
9893 * generic.cs (GenericMethod): Don't make this abstract.
9895 2006-09-27 Martin Baulig <martin@ximian.com>
9898 (InternalErrorException): Added overloaded ctor taking a params array.
9900 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9902 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9903 Fixed the cases when same error was reported twice.
9905 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9906 now report symbol information.
9908 2006-09-25 Martin Baulig <martin@ximian.com>
9910 * class.cs: Completely unified with the gmcs version.
9912 2006-09-25 Martin Baulig <martin@ximian.com>
9914 * typemanager.cs (TypeManager.IsNullableType): New public function.
9915 (TypeManager.IsNullableTypeOf): Likewise.
9916 (TypeManager.IsNullableValueType): Likewise.
9918 * class.cs (MethodCore): Added the `GenericMethod' argument from
9919 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9921 2006-09-24 Raja R Harinath <harinath@gmail.com>
9923 * convert.cs: Unify with gmcs version.
9925 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9927 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9928 verify them as well.
9930 * report.cs: New warning.
9932 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9934 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9935 for anonymous block with out argument.
9937 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9939 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9940 not used private events only.
9942 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9944 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9946 * const.cs (Const.Define): Check for constant type.
9947 (Const.IsConstantTypeValid): Looks for valid constant types.
9949 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9951 * ecore.cs (EmptyConstantCast): New common class for all constant based
9954 * expression.cs (Is.DoResolve): Handle null constant especially.
9955 (New.DoResolve): Check for new void().
9956 (MemberAccess.DoResolve): Cope with all kind of nulls.
9958 * literal.cs (NullConstant): Uses EmptyConstantCast.
9959 (NullDefault): Based on EmptyConstantCast.
9960 (NullLiteral): Uses EmptyConstantCast.
9962 * statement.cs (Block.ResolveMeta): Check for constant type.
9964 2006-09-22 Martin Baulig <martin@ximian.com>
9966 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9968 2006-09-22 Raja R Harinath <rharinath@novell.com>
9970 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9974 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9975 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9978 2006-09-22 Martin Baulig <martin@ximian.com>
9980 * ecore.cs: Merged with the gmcs version.
9982 * generic.cs (ConstructedType): New dummy class.
9983 (TypeArguments): Don't make this abstract.
9986 (TypeManager.IsGenericTypeDefinition): New method.
9987 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9989 2006-09-22 Raja R Harinath <rharinath@novell.com>
9991 * expression.cs (ComposedCast): Check for arrays of TypedReference
9992 before creating the type, not after.
9994 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9996 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9997 after ToType change.
9999 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
10000 when constant must be implicitly convertible.
10002 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
10004 * ecore.cs (NullCast): Derives from NullConstant.
10006 * expression.cs (Is.DoResolve): Removed useless variables.
10007 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
10008 (New.Constantify): Add enum support.
10009 (MemberAccess.DoResolve): Add warning when accessing null constant or
10012 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
10015 * literal.cs (NullConstant): New abstract class with common
10016 functionality for all null specializations.
10017 (NullDefault): Represents default(X) when result can be
10019 (NullLiteral): Updated.
10021 * report.cs: Add new warning.
10023 2006-09-21 Martin Baulig <martin@ximian.com>
10025 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
10027 2006-09-21 Martin Baulig <martin@ximian.com>
10029 * generic.cs (GenericConstraints): New dummy class.
10030 (Constraints): Likewise.
10031 (TypeParameter): Likewise.
10032 (TypeParameterName): Likewise.
10033 (GenericMethod): Likewise.
10035 * typemanager.cs (TypeManager.GetGenericArguments): New method.
10037 * decl.cs: Merged with the gmcs version.
10039 2006-09-21 Raja R Harinath <rharinath@novell.com>
10041 * generic.cs (TypeParameter): Implement IMemberContainer.
10042 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
10044 * rootcontext.cs: Unify with gmcs version.
10046 * report.cs: Unify with gmcs version.
10047 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
10048 from gmcs/generics.cs.
10049 * generics.cs (TypeParameter): New dummy class.
10051 * support.cs: Unify with gmcs version.
10053 2006-09-20 Raja R Harinath <rharinath@novell.com>
10055 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
10056 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
10058 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
10059 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
10060 * mcs.exe.sources: Add generic.cs.
10062 * codegen.cs: Unify with gmcs version.
10064 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
10065 (EmitContext): Add GenericDeclContainer implementation.
10066 * decl.cs (MemberCore, DeclSpace): Likewise.
10067 * namespace.cs: Remove #ifdef GMCS_SOURCE.
10069 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
10070 MCS TypeManager has a corresponding dummy method.
10072 2006-09-19 Martin Baulig <martin@ximian.com>
10074 * expression.cs: Completely merged with the gmcs version.
10076 2006-09-19 Martin Baulig <martin@ximian.com>
10078 * expression.cs (Invocation): Merged with the gmcs version.
10079 (ArrayAccess.GetStoreOpcode): Likewise.
10081 2006-09-19 Martin Baulig <martin@ximian.com>
10084 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
10085 (TypeManager.IsGenericMethodDefinition): Likewise.
10087 2006-09-19 Martin Baulig <martin@ximian.com>
10090 (TypeManager.IsEqual): Moved the gmcs implementation here.
10091 (TypeManager.DropGenericTypeArguments): Likewise.
10092 (TypeManager.DropGenericMethodArguments): Likewise.
10093 (TypeManager.GetTypeArguments): Moved here from gmcs.
10094 (TypeManager.HasGenericArguments): Likewise.
10096 2006-09-19 Martin Baulig <martin@ximian.com>
10098 * expression.cs (Binary): Merged with the gmcs version.
10100 2006-09-19 Martin Baulig <martin@ximian.com>
10102 * expression.cs (Probe, As, Is): Merged with the gmcs version.
10104 2006-09-19 Martin Baulig <martin@ximian.com>
10106 * typemanager.cs: Merged with the gmcs version.
10108 2006-09-16 Raja R Harinath <rharinath@novell.com>
10110 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
10111 * driver.cs: Likewise.
10113 2006-09-16 Marek Safar <marek.safar@seznam.cz>
10116 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
10117 only if parent type is class.
10118 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
10121 2006-09-15 Marek Safar <marek.safar@seznam.cz>
10124 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
10126 * typemanager.cs(CSharpName): Converts NullType to null.
10128 2006-09-15 Martin Baulig <martin@ximian.com>
10131 (TypeManager.GetMethodName): Added mcs implementation.
10132 (TypeManager.IsEqual): Likewise.
10135 (SimpleName.RemoveGenericArity): Added dummy implementation.
10137 * pending.cs: Merged with the gmcs version.
10139 2006-09-15 Martin Baulig <martin@ximian.com>
10141 * statement.cs: Merge with the gmcs version.
10143 2006-09-15 Martin Baulig <martin@ximian.com>
10145 * statement.cs (Switch): Merge with the gmcs implementation
10146 (without nullables), which is newer.
10148 2006-09-15 Martin Baulig <martin@ximian.com>
10150 * statement.cs (Block.Variables): Make this public.
10151 (ToplevelBlock.Parameters): Make this a property.
10152 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
10154 2006-09-15 Martin Baulig <martin@ximian.com>
10156 * namespace.cs: Merge with the gmcs version.
10158 2006-09-15 Martin Baulig <martin@ximian.com>
10160 * decl.cs (MemberName): Minor code cleanups.
10162 2006-09-15 Martin Baulig <martin@ximian.com>
10164 * parameter.cs: Merge with the gmcs version.
10166 2006-09-15 Martin Baulig <martin@ximian.com>
10168 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
10169 and an error in mcs.
10171 2006-09-15 Martin Baulig <martin@ximian.com>
10173 * flowanalysis.cs: Merged from GMCS; added the generics code into
10174 a `GMCS_SOURCE' conditional so we can share this file.
10176 2006-09-08 Martin Baulig <martin@ximian.com>
10178 * typemanager.cs (TypeManager.interlocked_type): New public field.
10179 (TypeManager.int_interlocked_compare-exchange): New public field.
10180 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
10181 enumerator types here and call InitGenericCoreTypes().
10182 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
10183 after calling InitEnumUnderlyingTypes().
10186 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
10187 `classes_second_stage'.
10189 2006-09-14 Marek Safar <marek.safar@seznam.cz>
10191 * assign.cs, ecore.cs, expression.cs: Share error message text.
10192 * class.cs (FieldMember.Define): Check for varible of static type.
10193 * driver.cs (LoadAssembly): Uses error output for errors.
10194 * statement.cs: Updated.
10196 2006-09-08 Marek Safar <marek.safar@seznam.cz>
10198 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
10201 2006-09-07 Martin Baulig <martin@ximian.com>
10204 (MainDriver): Revert r62663 from Marek; see #70506 for details.
10206 2006-08-29 Miguel de Icaza <miguel@novell.com>
10208 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
10210 2006-08-17 Miguel de Icaza <miguel@novell.com>
10212 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
10213 #52019 and #79064, the use of the \uXXXX sequence in source code
10214 to represent unicode characters.
10216 2006-08-15 Marek Safar <marek.safar@seznam.cz>
10218 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
10220 * class.cs, ecore.cs, statement.cs: Merged to one error message.
10222 2006-08-13 Miguel de Icaza <miguel@novell.com>
10224 * assign.cs: Catch attempts to assign to a method groups in += and
10227 2006-08-13 Marek Safar <marek.safar@seznam.cz>
10230 * cs-parser.jay: Don't destroy current array type by typeof of array's.
10232 2006-08-12 Marek Safar <marek.safar@seznam.cz>
10234 * class.cs (Method.Define): Issue a warning when generic method looks like
10236 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
10239 2006-08-09 Marek Safar <marek.safar@seznam.cz>
10241 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
10243 * decl.cs (MemberCache.FindMembers): When container is interface we need to
10244 search all base interfaces as a member can be ambiguous.
10245 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
10246 Constructor member type filter.
10247 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
10248 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
10249 reporting for returned memberinfos.
10250 * report.cs: Updated.
10251 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
10252 version to work on all runtimes.
10253 (TypeManager.RealMemberLookup): Removed members filtering.
10255 2006-08-08 Raja R Harinath <rharinath@novell.com>
10257 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
10258 (PropertyExpr.EmitAssign): Likewise.
10259 * expression.cs (Indirection.EmitAssign): Likewise.
10260 (LocalVariableReference.EmitAssign): Likewise.
10261 (ParameterReference.EmitAssign): Likewise.
10262 (Invocation.EmitArguments): Likewise.
10263 (ArrayAccess.EmitAssign): Likewise.
10264 (IndexerAccess.EmitAssign): Likewise.
10265 (This.EmitAssign): Likewise.
10266 (ConditionalLogicalOperator.Emit): Likewise.
10269 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
10270 instead of ArrayList. If the hashtable has a LocalBuilder, don't
10271 leave it in after returning it.
10272 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
10274 2006-08-06 Marek Safar <marek.safar@seznam.cz>
10276 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
10279 2006-08-03 Raja R Harinath <rharinath@novell.com>
10281 Fix cs0146-3.cs and cs0146-4.cs.
10282 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
10283 enclosing types don't depend on the current type.
10285 2006-08-02 Raja R Harinath <rharinath@novell.com>
10288 * class.cs (TypeContainer.DoDefineMembers): Use
10289 FindBaseMemberWithSameName on Parent, since we're interested in
10290 whether we hide inherited members or not.
10291 (FindBaseMemberWithSameName): Make slightly more robust.
10293 Fix the non-generic testcase from #77396
10294 * decl.cs (DeclSpace.DeclContainer): Remove override.
10296 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
10297 declspaces for doppelgangers too.
10298 (UsingEntry): Implement IResolveContext.
10299 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
10300 'this' as the resolve context.
10301 (LocalAliasEntry): Likewise.
10303 Implement parts of #77403
10304 * roottypes.cs (RootDeclSpace): New. Used to represent the
10305 toplevel declaration space. Each namespace declaration introduces
10306 a "partial" root declaretion space.
10307 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
10308 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
10309 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
10310 from 'current_namespace.SlaveDeclSpace'.
10311 (namespace_declaration): Likewise.
10312 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10313 check. It can't happen now.
10314 * decl.cs (DeclSpace.LookupType): Likewise.
10315 * driver.cs (MainDriver): Sanity check.
10317 2006-08-01 Raja R Harinath <rharinath@novell.com>
10319 * decl.cs (DeclSpace.FindNestedType): Remove.
10320 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10321 LookupTypeContainer to get the container of the nested type.
10322 * class.cs (TypeContainer.FindNestedType): Make non-override.
10324 2006-07-31 Raja R Harinath <rharinath@novell.com>
10326 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10327 * class.cs (TypeContainer.PartialContainer): ... here.
10328 (TypeContainer.AddBasesForPart): New helper.
10329 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10331 * cs-parser.jay (current_class): Convert to DeclSpace.
10332 (struct_declaration, interface_declaration, class_declaration):
10333 Use AddBasesForPart instead of .Bases directly.
10334 * const.cs, iterators.cs: Update to changes.
10336 2006-07-28 Raja R Harinath <rharinath@novell.com>
10338 * class.cs (TypeContainer.AddMemberType): Rename from
10339 AddToTypeContainer.
10340 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10341 (AddTypeContainer): New. Combine AddClassOrStruct and
10343 (AddPartial): Update. Add 'is_partial' argument.
10344 * roottypes.cs: Update to changes.
10345 * cs-parser.jay (push_current_class): New helper for handling
10346 current_container and current_class.
10347 (struct_declaration, interface_declaration, class_declaration):
10350 2006-07-26 Raja R Harinath <rharinath@novell.com>
10352 * roottypes.cs: Rename from tree.cs.
10354 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10355 * tree.cs (Tree, ITreeDump): Remove types.
10356 * rootcontext.cs (tree, Tree): Remove fields.
10357 (root, ToplevelTypes): New.
10358 * *.cs: Update to rename.
10360 * tree.cs (Tree.RecordDecl): Remove.
10361 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10363 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10365 2006-07-23 Raja R Harinath <harinath@gmail.com>
10367 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10368 DoFlowAnalysis and OmitStructFlowAnalysis here.
10369 (ec.With): Rename from WithUnsafe and generalize.
10370 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10371 (ec.WithFlowAnalyis): New.
10372 * ecore.cs, expression.cs, statement.cs: Update.
10374 2006-07-22 Raja R Harinath <harinath@gmail.com>
10376 * statement.cs (Block.ResolveMeta): Simplify slightly.
10378 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10379 multiple boolean fields. Convert InUnsafe, constant_check_state,
10380 check_state to flags.
10381 (CheckState, ConstantCheckState): Update.
10382 (InUnsafe): New read-only property.
10383 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10385 (WithUnsafe): New helper similar to WithCheckState.
10386 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10387 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10389 2006-07-21 Raja R Harinath <rharinath@novell.com>
10391 Make comparisons use the same IL irrespective of whether they're
10392 in a 'checked' or 'unchecked' context: one of the issues in #78899
10393 * codegen.cs (EmitContext.CheckState): Make read-only property.
10394 (EmitContext.ConstantCheckState): Likewise.
10395 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10396 helper that implement a save/restore stack for CheckState
10397 values. This is the only way to change check-state.
10398 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10399 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10400 (CheckedExpr.EmitBranchable): New forwarding method.
10401 (UnCheckedExpr): Likewise.
10402 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10403 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10404 (Checked.Resolve, checked.DoEmit): Likewise.
10406 2006-07-20 Miguel de Icaza <miguel@novell.com>
10408 * anonymous.cs: Cache the resolved anonymous delegate, and return
10409 this so that the ResolveTopBlock is only triggered once, not
10412 Currently we trigger ResolvetopBlock twice due to a first pass of
10413 argument check compatibility, and a second pass that does the
10416 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10418 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10420 * rootcontext.cs (Reset): Add helper_classes.
10422 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10425 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10428 2006-07-13 Miguel de Icaza <miguel@novell.com>
10430 * statement.cs (Lock): Handle expressions of type
10431 TypeManager.null_type specially. Fixes #78770
10433 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10435 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10438 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10440 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10441 for accessors as well.
10442 * ecore.cs (EventExpr): Add AccessorTable.
10444 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10447 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10448 for CS0122 where appropriate.
10449 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10451 (Filter): Assembly can be null in the case of top level attributes.
10453 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10457 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10458 is done at global level.
10460 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10462 A fix for #77002, Implemented TypeForwarder support.
10464 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10465 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10466 * typemanager.cs (): Add type_forwarder_attr_type.
10468 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10470 * report.cs: Add CS0469 warning.
10472 2006-06-21 Martin Baulig <martin@ximian.com>
10474 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10475 the `try'-block, so we also report CS0016 etc. there.
10477 2006-06-21 Martin Baulig <martin@ximian.com>
10480 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10482 2006-06-21 Martin Baulig <martin@ximian.com>
10484 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10485 also report CS1686 for parameters.
10487 2006-06-21 Martin Baulig <martin@ximian.com>
10489 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10490 instead of an error if the value is not implicitly convertible to
10491 the switch types; fixes #77964.
10493 2006-06-21 Raja R Harinath <rharinath@novell.com>
10496 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10497 FieldBuilder is null.
10500 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10501 'left' and 'right' before error-checking.
10503 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10505 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10507 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10508 (FieldExpr.DoResolve): likewise.
10509 (PropertyExpr.InstanceResolve): likewise.
10510 (EventExpr.InstanceResolve): likewise.
10512 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10514 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10515 attribute applicable tests for attribute argument.
10517 2006-06-02 Raja R Harinath <rharinath@novell.com>
10520 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10521 (Binary.OverloadResolve_PredefinedIntegral): New.
10522 (Binary.OverloadResolve_PredefinedFloating): New.
10523 (Binary.OverloadResolve_PredefinedString): New.
10524 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10525 Follow the standard more closely, and treat numeric promotions in
10526 terms of overload resolution.
10527 (Binary.CheckShiftArguments): Simplify.
10529 2006-06-01 Raja R Harinath <rharinath@novell.com>
10531 * flowanalysis.cs (MyBitVector): Simplify representation.
10532 (MyBitVector.Clone): Avoid allocating BitArray.
10533 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10534 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10535 (*): Update. Change all references to MyBitVector.And and
10536 MyBitVector.Or to &= and |=.
10538 2006-05-29 Raja R Harinath <rharinath@novell.com>
10540 Fix cs0231-[34].cs.
10541 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10542 to param arguments too.
10544 2006-05-26 Miguel de Icaza <miguel@novell.com>
10546 * cs-parser.jay: Catch another parsing form for arglist being
10547 followed by other arguments. Fixes #78313.
10549 2006-05-24 Raja R Harinath <rharinath@novell.com>
10551 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10552 checking of out parameters to ...
10553 (FlowBranchingToplevel.Merge): ... here.
10554 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10555 set, propagate the origin upward, and only complain if there was
10557 (FlowBranchingException.AddContinueOrigin): Likewise.
10558 (FlowBranchingException.AddReturnOrigin): Likewise.
10559 (FlowBranchingException.AddGotoOrigin): Likewise.
10561 2006-05-23 Raja R Harinath <rharinath@novell.com>
10563 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10564 unreachable, skip it.
10565 (FlowBranchingException.Merge): Always propagate jumps, even if
10566 the finally block renders subsequent code unreachable.
10568 2006-05-18 Raja R Harinath <rharinath@novell.com>
10571 * statement.cs (Goto.Resolve): Move responsibility for resolving
10572 'goto' to FlowBranching.AddGotoOrigin.
10573 (Goto.SetResolvedTarget): New. Callback to set the
10574 LabeledStatement that's the target of the goto.
10575 (Goto.DoEmit): Use Leave instead of Br when crossing an
10576 unwind-protect boundary.
10577 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10578 LookupLabel and adjust to new semantics.
10579 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10580 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10581 Goto.SetResolvedTarget to update target.
10582 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10583 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10584 AddBreakOrigin & co. Delay propagation until ...
10585 (FlowBranchingException.Merge): ... this.
10587 * statement.cs (Block.Resolve): Always depend on flow-branching to
10588 determine unreachability. Kill workaround that originally emitted
10589 only one statement after an "unreachable" label (see infloop in
10592 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10593 This is still "wrong", but anything better would probably need a
10594 multi-pass algorithm.
10595 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10596 usage vector. Force current usage vector to be reachable, to
10597 optimistically signify backward jumps.
10598 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10600 (FlowBranchingLabeled.Merge): New. If no backward jump was
10601 detected, return the original salted-away usage vector instead,
10602 updated with appropriate changes. Print unreachable warning if
10604 * statement.cs (Block.Resolve): Don't print unreachable warning on
10605 a labeled statement.
10607 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10609 * driver.cs: Pass filename without path to AssemblyBuilder's
10610 AddResourceFile. Fixes bug #78407.
10612 2006-05-17 Raja R Harinath <rharinath@novell.com>
10614 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10615 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10616 (FlowBranching.MergeChild): Overwrite
10617 reachability information from Labeled branchings too.
10619 2006-05-16 Raja R Harinath <rharinath@novell.com>
10621 * statement.cs (Goto.Resolve): Merge jump origins here ...
10622 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10624 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10625 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10626 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10627 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10629 * statement.cs (Goto.Resolve): ... not here.
10630 (Goto.Emit): Remove CS1632 check.
10632 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10634 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10637 2006-05-11 Raja R Harinath <rharinath@novell.com>
10639 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10640 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10641 (FlowBranchingException.Label): Likewise.
10643 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10645 (MyBitVector.Or): Use it to avoid losing information (Count).
10646 (FlowBranching.MergeOrigins): Likewise.
10648 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10649 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10650 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10651 (UsageVector.ToString): Simplify.
10652 (UsageVector.MergeSiblings): Move here from ...
10653 (FlowBranching.Merge): ... here.
10654 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10657 2006-05-10 Raja R Harinath <rharinath@novell.com>
10659 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10660 null bitvector is treated as all-true.
10662 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10663 (MyBitVector): Rationalize invariants. 'vector != null' implies
10664 that we have our own copy of the bitvector. Otherwise,
10665 'InheritsFrom == null' implies all inherited bits are true.
10667 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10669 * statement.cs (LocalInfo): Add IsConstant.
10670 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10671 local variable for constants.
10673 2006-05-09 Raja R Harinath <rharinath@novell.com>
10675 * flowanalysis.cs (MyBitVector.Empty): New.
10676 (MyBitVector): Don't allow InheritedFrom to be null.
10677 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10678 (UsageVector, FlowBranching): Update to changes.
10680 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10681 recursion. The 'Parent == null' condition isn't sufficient for
10683 (FlowBranching.AddBreakOrigin): Likewise.
10684 (FlowBranching.AddContinueOrigin): Likewise.
10685 (FlowBranching.AddReturnOrigin): Likewise.
10686 (FlowBranching.StealFinallyClauses): Likewise.
10687 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10688 (FlowBranching.CheckOutParameters): Likewise.
10689 (FlowBranchingToplevel): Terminate all the above recursions here.
10690 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10691 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10693 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10695 (FlowBranchingToplevel): New. Empty for now.
10696 (FlowBranching.MergeTopBlock): Update.
10697 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10698 branching for the anonymous delegate.
10699 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10701 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10702 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10703 information at the start of the merge. Reorganize.
10705 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10707 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10709 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10711 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10712 to newly introduced ctor.
10714 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10715 message to one place.
10716 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10719 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10721 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10723 * ecore.cs (Expression.ResolveAsConstant): Updated.
10725 * statement.cs (ResolveMeta): Updated.
10727 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10729 * cs-parser.jay: __arglist cannot be used in initializer.
10731 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10734 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10737 2006-05-05 Raja R Harinath <rharinath@novell.com>
10739 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10740 (LabeledStatement): Add 'name' parameter.
10741 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10742 (Block.AddLabel): Update to changes.
10743 * cs-parser.jay (labeled_statement): Likewise.
10745 * flowanalysis.cs (BranchingType.Labeled): New.
10746 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10747 (FlowBranchingLabeled): New. Does nothing for now, but will
10748 eventually handle 'goto' flows.
10749 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10750 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10751 that's terminated ...
10752 (Block.Resolve): ... here.
10754 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10755 (UsageVector.MergeFinallyOrigins): Likewise.
10756 (FlowBranching.InTryOrCatch): Likewise.
10757 (FlowBranching.AddFinallyVector): Likewise.
10758 (FlowBranchingException): Update to changes.
10761 * statement.cs (Return.Resolve): Move error checking to ...
10762 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10763 (FlowBranchingException): Handle return origins like break and
10765 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10767 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10770 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10773 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10776 * class.cs (MethodData.Define): Do public accessor check only when method
10777 implements an interface.
10779 2006-05-04 Raja R Harinath <rharinath@novell.com>
10781 Remove special handling of 'break'
10782 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10783 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10784 (UsageVector.Break): Remove.
10785 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10787 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10789 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10790 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10792 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10795 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10796 be the interface member.
10798 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10801 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10802 for emitting small (int) values.
10804 2006-05-03 Raja R Harinath <rharinath@novell.com>
10807 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10808 control-flow passes through the 'finally' after merging-in all the
10809 control-flows from 'try' and the 'catch' clauses.
10811 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10812 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10813 always true at the only non-recursive entry point.
10814 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10815 FlowBranchingBreakable.
10816 (FlowBranchingLoop): Remove.
10817 * statement.cs (Return.DoResolve): Update to changes.
10820 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10821 (FlowBranching.CreateBranching): Handle it: create a
10822 FlowBranchingContinuable.
10823 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10824 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10825 except that it handles the 'continue' command.
10826 (FlowBranching.UsageVector.MergeOrigins): Rename from
10828 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10829 except that it overrides AddContinueOrigin.
10830 (FlowBranchingException): Override AddContinueOrigin, similar to
10832 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10833 Create a new branching around the embedded statement.
10834 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10835 control flow after the embedded statement.
10836 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10838 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10839 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10840 FlowBranchingBreakable.
10841 (FlowBranchingSwitch): Remove.
10844 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10845 error reporting to ...
10846 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10847 Rename from 'AddBreakVector'. Add new location argument. Return
10848 a bool indicating whether the 'break' crosses an unwind-protect.
10849 (FlowBranchingException.AddBreakOrigin): Add.
10850 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10851 flowbranching after updating with the effects of the 'finally'
10853 (FlowBranchingBreakable): New common base class for
10854 FlowBranchingLoop and FlowBranchingSwitch.
10856 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10857 embedded statement.
10858 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10860 2006-05-02 Raja R Harinath <rharinath@novell.com>
10862 * statement.cs (Do.Resolve): If the loop is infinite, set the
10864 (While.Resolve, For.Resolve): Set a barrier after the embedded
10865 statement. There's no direct control flow that goes from the end
10866 of the embedded statement to the end of the loop.
10867 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10868 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10869 above ensure that the reachability is correctly computed.
10871 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10872 (UsageVector.MergeBreakOrigins): If the current path is
10873 unreachable, treat it as if all parameters/locals are initialized.
10874 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10875 infinite loops before merging-in break origins.
10877 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10878 (Reachability.Reachable): Split part into ...
10879 (Reachability.Unreachable): ... this. Simplify.
10880 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10882 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10883 (Reachability.SetThrowsSometimes): Likewise.
10884 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10885 TriState.Always, use corresponding property.
10886 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10887 (Block.Resolve): Likewise. Remove some redundant checks.
10889 2006-05-02 Raja R Harinath <harinath@gmail.com>
10891 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10892 (Reachability.Meet): Don't bother checking AlwaysThrows --
10893 barrier is always set.
10894 (FlowBranchingBlock.Merge): Likewise.
10896 2006-05-01 Raja R Harinath <harinath@gmail.com>
10898 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10899 checks for unreachable.
10901 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10904 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10906 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10907 whether field is really assigned.
10909 2006-04-30 Raja R Harinath <harinath@gmail.com>
10911 * flowanalysis.cs (Reachability): Make 4-argument constructor
10913 (Reachability.Meet): Rename from 'And'. Remove static variant.
10914 (Reachability.Always): Rename from the highly misleading
10915 'Reachability.Never'.
10916 (FlowBranching.Merge): Update to changes. Mark an impossible
10917 situation with a 'throw'.
10918 (*): Update to changes.
10920 2006-04-29 Raja R Harinath <harinath@gmail.com>
10922 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10923 Remove 'Undefined'.
10924 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10925 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10926 (*): Update to changes.
10927 * statement.cs: Update to changes.
10929 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10932 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10934 2006-04-28 Raja R Harinath <harinath@gmail.com>
10936 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10939 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10940 argument to two arguments: an usage-vector and a bool. Move call
10941 to FlowBranching.Merge () ...
10942 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10944 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10945 handling of loop and switch reachability to ...
10946 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10948 2006-04-27 Raja R Harinath <harinath@gmail.com>
10950 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10951 handling to FlowBranchingLoop.InLoop.
10952 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10954 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10957 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10958 anonymous method is allowed from AnonymousContainer here.
10960 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10962 2006-04-24 Raja R Harinath <rharinath@novell.com>
10965 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10967 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10970 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10971 (DoubleConstant.Reduce): Ditto.
10973 2006-04-23 Raja R Harinath <rharinath@novell.com>
10975 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10976 Remove 'lvalue_right_side' argument. Move parts to ...
10977 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10978 (LocalVariable.DoResolveLValue): ... these.
10980 2006-04-21 Raja R Harinath <rharinath@novell.com>
10983 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10984 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10985 (LocalVariableReference.DoResolveBase): Use it to implement new
10987 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10988 (Argument.Resolve): Simplify. Move CS1510 check ...
10989 * ecore.cs (Expression.ResolveLValue): ... here.
10990 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10991 (PropertyExpr.DoResolveLValue): Likewise.
10992 (FieldExpr.Report_AssignToReadonly): Likewise.
10993 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10994 LValueMemberAccess or LValueMemberOutAccess on instance depending
10996 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10997 DoResolve as appropriate.
10999 2006-04-20 Raja R Harinath <rharinath@novell.com>
11002 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
11003 implicit conversions on 'out' and 'ref' arguments.
11005 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
11006 improve clarity. Remove dead code.
11009 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
11010 (Catch.Resolve): Resolve VarBlock if it exists.
11012 2006-04-19 Miguel de Icaza <miguel@novell.com>
11014 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
11015 twice, this was some residual code, the enumerator was emitted
11016 properly in the two branche of if later.
11018 2006-04-19 Raja R Harinath <rharinath@novell.com>
11020 * expression.cs (Cast.ResolveLValue): Remove. The result of a
11021 cast is never an lvalue.
11022 (Cast.DoResolve, Cast.ResolveRest): Combine.
11023 (Argument.Emit): Simplify slightly. Move 'Expr is
11024 IMemoryLocation' check ...
11025 (Argument.Resolve): ... here.
11026 (Argument.Error_LValueRequired): Remove. Inline into only user.
11028 Simplifications. Fix cs0191-2.cs
11029 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
11030 CS1649 and CS1651 to ...
11031 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
11032 the actual selection of the error code and message to a lookup
11033 table. Add a dummy return value to simplify callsites.
11034 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
11035 readonly fields of other instances of the same type. Move CS0197
11037 * expression.cs (Argument.Resolve): ... here. Simplify code.
11038 Ensure that ec.InRefOutArgumentResolving is only set during LValue
11039 resolution of an out or ref argument. The code simplification
11040 above uses this invariant.
11042 2006-04-18 Raja R Harinath <rharinath@novell.com>
11044 Possibly fix #77752. Fix cs1690-[4-7].cs.
11045 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
11046 CheckMarshallByRefAccess. Drop parameter.
11047 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
11049 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
11050 InstanceExpression.
11051 * report.cs (AllWarnings): Add CS1690.
11052 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
11053 for ref access too.
11054 (LocalVariableReference.DoResolveBase): Update.
11056 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11058 * class.cs (MethodOrOperator): Moved common parts from method class.
11059 detect obsolete attributes.
11060 (Method.Define): Simplified as it reuses code from base.
11061 (Constructor.ValidAttributeTargets): Fixed issue found during
11063 (Destructor.ValidAttributeTargets): Fixed issue found during
11065 (Operator): Finished refactoring set off by #78020. Operator class is now
11066 ordinary method class.
11068 * anonymous.cs: Updated.
11070 * decl.cs (DeclSpace): Add IsGeneric
11072 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11074 * class.cs (Constructor.Emit): Don't emit the attributes twice.
11076 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11078 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
11079 detect obsolete attributes.
11080 (Method.CreateEmitContext): Moved to MethodOrOperator.
11082 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11085 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
11086 customized exception to make crash detection easier.
11087 (MethodOrOperator): Started to work on new base class for methods and
11089 (Method): Derives from MethodOrOperator.
11090 (Constructor.Emit): Emits its own attributes.
11091 (AbstractPropertyEventMethod.Emit): Ditto.
11092 (Operator): Derives from MethodOrOperator, will refactor fully in extra
11094 (Operator.Emit): It's temporary more tricky than should be.
11096 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
11098 * report.cs (InternalErrorException): Add ctor with inner exception.
11100 2006-04-08 Marek Safar <marek.safar@seznam.cz>
11103 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
11106 2006-04-07 Marek Safar <marek.safar@seznam.cz>
11109 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
11112 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11114 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
11115 attribute is present and Guid not.
11116 (Interface.ApplyAttributeBuilder): Ditto.
11118 * attribute.cs: Add error message.
11120 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11124 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
11125 sources (it's composite) so hold them in extra array as they are used in
11126 Emit phase only. It worked in the previous versions by mistake.
11127 (Attribute.Emit): Emit attribute for more owners when exist.
11129 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
11130 it has now different behaviour.
11132 2006-04-04 Marek Safar <marek.safar@seznam.cz>
11134 * constant.cs (Constant.IsDefaultInitializer): New method.
11136 * class.cs: Updated.
11138 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
11139 re-initialize default values. It saves KBs almost for every assembly.
11140 Thanks Zoltan for the idea.
11141 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
11142 (ArrayCreation.DoResolve): Resolve only once.
11143 (ArrayCreation.Emit): Emit static initializer only when it is faster.
11144 (ArrayCreation.GetAttributableValue): Cope with optimized values.
11146 2006-04-03 Zoltan Varga <vargaz@gmail.com>
11148 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
11151 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11153 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
11154 in an embedded statement too.
11156 2006-04-01 Raja R Harinath <rharinath@novell.com>
11159 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
11161 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11165 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
11168 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
11170 2006-03-31 Marek Safar <marek.safar@seznam.cz>
11172 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
11175 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
11176 LocalTemporary change.
11178 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
11180 (ClassOrStruct.DefineFieldInitializers): Implemented static field
11181 initializers optimization.
11182 (ClassOrStruct.TypeAttr): Moved from modifiers.
11183 (Constructor.CheckBase): Don't crash when static ctor has parameters.
11184 (FieldBase.ResolveInitializer): Resolves initializer.
11185 (FieldBase.HasDefaultInitializer): New property.
11187 * cs-parser.jay: Removed message.
11189 * expression.cs (CompilerGeneratedThis): New specialization.
11191 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
11193 2006-03-28 Marek Safar <marek.safar@seznam.cz>
11195 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
11197 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11199 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
11200 be now EnumConstants only.
11202 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11204 * attribute.cs, driver.cs: Reset more caches.
11206 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11208 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
11210 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11212 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
11213 for easier reuse. Updated all overrides.
11214 (IntegralConstant): New base class for all integral constants.
11215 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
11216 of the constant range, report custom error.
11217 (UIntConstant.Reduce): Fixed uint conversion.
11219 * ecore.cs, literal.cs: Reduce updates.
11221 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11225 * class.cs (Constructor.Define): Removed extra if for default ctors.
11226 A patch from Atsushi Enomoto.
11228 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11230 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
11231 GetAttributableValue.
11233 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
11236 * convert.cs (ImplicitConversionRequired): Error message moved to
11239 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
11240 automatic implicit conversion of an output value.
11241 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
11243 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
11245 (TypeOf.GetAttributableValue): Add extra handling for object type.
11247 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
11248 special error message.
11250 2006-03-25 Marek Safar <marek.safar@seznam.cz>
11252 * class.cs (Constructor.Emit): Don't crash when struct ctor is
11254 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
11255 compatible with MS runtime.
11257 2006-03-23 Marek Safar <marek.safar@seznam.cz>
11259 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
11260 attribute arguments here.
11262 * class.cs (Indexer.Define): The check was moved to attribute class.
11264 2006-03-22 Marek Safar <marek.safar@seznam.cz>
11266 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
11267 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
11270 2006-03-22 Raja R Harinath <rharinath@novell.com>
11272 Support ParameterDefaultValueAttribute in gmcs. Also applied to
11273 mcs to keep code differences small.
11274 * attribute.cs (Attribute.GetParameterDefaultValue): New.
11275 * typemanager.cs (parameter_default_value_attribute_type): New.
11276 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
11279 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11281 * expression.cs (StringConcat.Append): Reverted back to no warning state.
11283 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11285 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
11287 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
11290 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
11292 * doc-bootstrap.cs : fix build.
11294 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11296 * expression.cs (StringConcat.Append): Issue a warning when empty string
11297 is going to append.
11299 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11301 * assign.cs (CompoundAssign.ResolveSource): Removed.
11303 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
11306 * class.cs (TypeContainer.FindMethods): Removed.
11307 (TypeContainer.CheckMemberUsage): Made static.
11309 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
11311 * constant.cs (CheckRange): Removed unused type argument.
11312 (CheckUnsigned): Removed unused type argument.
11314 * cs-parser.jay: Updated after MemberAccess clean up.
11315 Uses Length for empty string test.
11317 * cs-tokenizer.cs: Uses Length for empty string test.
11318 (IsCastToken): Made static.
11319 (is_hex): Made static.
11320 (real_type_suffix): Made static.
11322 * decl.cs (SetupCache): Made static.
11323 (OnGenerateDocComment): Removed unused ds argument.
11325 * delegate.cs (VerifyDelegate): Removed unused argument.
11327 * doc.cs: Uses Length for empty string test.
11329 * driver.cs: Uses Length for empty string test.
11331 * enum.cs (IsValidEnumType): Made static
11333 * expression.cs (EnumLiftUp): Removed unused argument.
11334 (ResolveMethodGroup): Ditto.
11335 (BetterConversion): Ditto.
11336 (GetVarargsTypes): Ditto.
11337 (UpdateIndices): Ditto.
11338 (ValidateInitializers): Ditto.
11339 (MemberAccess.ctor): Ditto.
11340 (GetIndexersForType): Ditto.
11342 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11344 * iterators.cs: Updated after MemberAccess clean up.
11346 * location.cs: Uses Length for empty string test.
11348 * namespace.cs: Uses Length for empty string test.
11350 * report.cs (CheckWarningCode): Made static.
11352 * statement.cs (LabeledStatement): Removed unused argument.
11354 * typemanager.cs (FilterNone): Removed.
11356 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11358 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11361 * class.cs: Updated.
11363 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11365 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11367 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11371 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11372 reporting, it's more tricky than I thought.
11374 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11378 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11380 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11381 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11382 Add more error reporting; Fixed issue with params.
11384 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11386 * cs-parser.jay: AnonymousMethod requires host container.
11388 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11390 2006-03-18 Raja R Harinath <harinath@gmail.com>
11392 * class.cs: Change 'TypeContainer ds' constructor argument to
11393 'DeclSpace parent'. Some classes were missed below due to
11394 different naming convention.
11396 * class.cs (MemberCore.Parent): Delete. This makes the
11397 ParentContainer changes below enforceable by the compiler.
11399 Treat pointers to enclosing declaration space as 'DeclSpace', not
11401 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11402 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11404 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11406 (Block.AddThisVariable): Likewise.
11407 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11408 (AbstractPropertyEventMethod.Emit): Likewise.
11409 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11410 (GetMethod.Define, SetMethod.Define): Likewise.
11411 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11412 (DelegateMethod.EmitMethod): Likewise.
11414 Fix regression test-partial-13.cs.
11415 Rationalize use of PartialContainer. Ensure that the partial
11416 class semantics can be tied to type-correctness, i.e., any
11417 violation will cause a compile error.
11418 * class.cs, const.cs: Access all fields that belong to class
11419 TypeContainer via ParentContainer. Arguments of EmitContexts and
11420 Resolve()-like functions still use 'Parent'.
11422 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11423 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11424 (PropertyMethod.CheckModifiers): Remove unused argument.
11425 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11428 2006-03-17 Raja R Harinath <harinath@gmail.com>
11430 Make semantics of PartialContainer simpler.
11431 * decl.cs (DeclSpace.IsPartial): Remove.
11432 * class.cs (TypeContainer.IsPartial): Likewise.
11433 (TypeContainer..ctor): Set PartialContainer to point to self.
11434 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11435 (TypeContainer.FindNestedType): Likewise.
11436 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11438 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11440 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11442 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11444 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11447 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11449 * class.cs (Operator.Define): An error for base conversion was not
11450 reported correctly.
11452 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11454 * iterator.cs : yield break is allowed in try statement which has
11455 catch clauses. Fixed bug #77767.
11457 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11459 A fix for #77593, #77574.
11461 * class.cs (MethodCore.CheckBase): Another if for operator.
11463 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11465 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11468 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11469 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11472 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11475 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11476 Updated after another emitcontext usage was clean up. It should help us to
11477 synchronize with gmcs easier.
11479 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11483 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11484 (Event.Define): ditto
11485 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11487 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11488 Removed redundant code and set NewSlot for Invoke method too.
11490 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11491 (Parameters.MergeGenerated): New method. Use this method when you merge
11492 compiler generated argument with user arguments.
11494 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11496 * attribute.cs (ResolveAsTypeTerminal): Removed.
11498 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11499 specialization for predefined types; 30% speed up.
11500 Finally placed obsolete check to right place.
11501 (Expression.ResolveType): Removed.
11503 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11504 Updated after ResolveType was removed.
11506 * expression.cs (Cast.ctor): Check void cast.
11507 (Binary.ResolveAsTypeTerminal): Is never type.
11508 (Conditional.ResolveAsTypeTerminal): Is never type.
11510 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11512 2006-03-01 Raja R Harinath <rharinath@novell.com>
11515 * expression.cs (ParameterReference.DoResolveBase): Change return
11517 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11521 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11524 * typemanager.cs (GetFullNameSignature): Don't nullref on
11525 protected accessors.
11527 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11529 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11530 these two separated members to simplify the code.
11531 (Attribute.Resolve): Refactored to use new fields and methods.
11532 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11533 implemented obsolete attribute checking.
11534 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11535 implemented obsolete checking again. It look line never ending quest ;-)
11536 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11538 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11540 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11542 *class.cs (Property.Define): Add RegisterProperty call.
11544 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11545 argument groups (only 2).
11547 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11548 encoding expression to arguments.
11549 (Expression.ExprClassToResolveFlags): Just turned to property.
11551 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11552 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11553 optimized as well as implemented support for zero-length attributes.
11555 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11556 Add caching of PropertyInfo's.
11558 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11560 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11561 error multiple times.
11563 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11565 New partial class implementation.
11566 A fix for #77027, #77029, #77403
11568 * attribute.cs (Attributable): Made attributes protected.
11570 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11571 the replacements of ClassPart and PartialContainer.
11572 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11573 (TypeContainer.AddInterface): Ditto.
11574 (TypeContainer.AddPartial): The main method for partial classes. It checks
11575 for errors and merges ModFlags and attributes. At the end class is added to
11576 partial_parts list.
11577 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11579 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11580 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11581 from the rest of partial classes.
11582 (TypeContainer.GetClassBases): Simplified.
11583 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11585 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11586 (TypeContainer.HasExplicitLayout): Uses Flags now.
11587 (PartialContainer): Removed.
11588 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11589 (StaticClass): Was merged with Class.
11590 (Class.GetClassBases): class and static class bases are verified here.
11591 (Class.TypeAttr): Added static attributes when class is static.
11592 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11593 (MemberBase): In some cases we need to call parent container for partial
11594 class. It should be eliminated but it's not easy now.
11596 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11598 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11599 partial classed to accumulate class comments.
11600 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11602 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11604 * driver.cs (MainDriver): Tree.GetDecl was removed.
11606 * modifiers.cs (Modifiers): Add partial modifier.
11608 * tree.cs (Tree.decl): Removed.
11609 (RootTypes): Started to use this class more often for root types
11612 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11616 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11617 external interface does not have an attribute.
11619 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11621 Another prerequisites for new partial classs implementation.
11623 * attribute.cs (Attribute.Equal): Implemented.
11624 (Attribute.Emit): Changed as attributes can be applied more than twice.
11625 (Attributes.Emit): Check for duplicate attributes here.
11627 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11628 as a parameter, clean-up.
11630 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11634 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11635 contains obsolete attribute check which can in some cases look for base
11636 type of current class which is not initialized yet.
11637 (TypeContainer.BaseType): Replacement of ptype.
11639 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11641 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11643 First of prerequisites for new partial classs implemention.
11645 * attribute.cs (Attributable): Extended by ResolveContext;
11646 Attributes finally have correct context for resolving in all cases.
11647 (AttachTo): Attribute owner is assigned here.
11649 * codegen.cs (IResolveContext): Introduce new interface to hold
11650 all information needed in resolving phase.
11651 (EmitContext): Implements IResolveContext; more clean-up needed here.
11653 * decl.cs (MemberCore): Implemented IResolveContext.
11655 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11656 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11657 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11658 Refactored to use new IResolveContext instead of EmitContext; cleanup
11660 2006-02-06 Miguel de Icaza <miguel@novell.com>
11662 * codegen.cs (EmitScopeInitFromBlock): check here the
11663 capture_context, there is no need to make two calls to the
11666 * anonymous.cs: Add some debugging messages that might help me
11667 track other instances of this problem in the future (the
11668 regression of test 467).
11670 * cs-parser.jay: track the variable block, as we need to initalize
11671 any captured variables declared in this block for the "catch"
11672 portion of the "Try" statement.
11674 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11675 scope initialization for captured variables.
11677 Also, move the emit for the variables after the block location has
11680 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11682 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11684 2006-02-02 Miguel de Icaza <miguel@novell.com>
11686 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11687 commit yesterday, the initialization for the roots is necessary.
11688 What is not necessary is the scope activation.
11690 2006-02-02 Raja R Harinath <rharinath@novell.com>
11692 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11693 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11695 (Argument.Resolve): Remove CS0206 checks.
11697 2006-02-01 Miguel de Icaza <miguel@novell.com>
11699 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11700 scopes for all the roots, the scopes will now be emitted when the
11701 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11703 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11704 code. This reduces a lot of existing cruft.
11706 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11707 that the ScopeInfo is generated as we enter the scope, not at the
11708 time of use, which is what we used to do before.
11710 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11711 every time a Block is about to be emitted if we have a
11714 2006-02-01 Raja R Harinath <rharinath@novell.com>
11716 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11718 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11720 * typemanager.cs (cons_param_array_attribute): Make private.
11721 (Reset): Set it to null.
11722 (InitCoreHelpers): Don't initialize it.
11723 (ConsParamArrayAttribute): New. Initialize it as needed.
11724 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11726 2006-01-31 Miguel de Icaza <miguel@novell.com>
11728 * expression.cs: There might be errors reported during the
11729 selection of applicable methods. If there are errors, do not
11730 continue execution as it will lead the compiler to crash.
11732 2006-01-30 Miguel de Icaza <miguel@novell.com>
11734 * expression.cs: Member access is not allowed on anonymous
11735 methods. Fixes #77402.
11737 2006-01-30 Raja R Harinath <rharinath@novell.com>
11740 * cs-parser.jay (VariableDeclaration): Don't set
11741 current_array_type to null.
11742 (field_declaration, event_declaration, declaration_statement):
11743 Set it to null here.
11745 2006-01-28 Raja R Harinath <harinath@gmail.com>
11747 * typemanager.cs (GenericParameterPosition): New.
11750 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11752 * doc.cs : To process "include" elements, first we should create
11753 another list than XmlNodeList, because it could result in node
11754 removal, which could result in that the XmlNodeList gives up
11755 yielding next node.
11757 (Also made code identical to gmcs again.)
11759 2006-01-25 Miguel de Icaza <miguel@novell.com>
11761 * ecore.cs: Introduce an error report that we were not catching
11762 before, if not silent, we must report the error. Gonzalo ran into
11765 2006-01-23 Miguel de Icaza <miguel@novell.com>
11767 A fix for bug: #76957
11769 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11770 ComputeMethodHost before creating the method, this is a new
11773 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11774 that this method references (RegisterScope). The actual scope
11775 where the method is hosted is computed with the ComputeMethodHost
11776 before we create the method.
11778 Moved the Deepest routine here.
11780 (AnonymousContainer.ComputeMethodHost): New routine used to
11781 compute the proper ScopeInfo that will host the anonymous method.
11783 (ScopeInfo): Deal with multiple roots. The problem was that we
11784 did not have a unique root where all ScopeInfos could be hanged
11785 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11788 Remove AdjustMethodScope which is now computed at the end. Remove
11789 LinkScope which did a partial link, instead link all ScopeInfos
11790 before code generation from the new "LinkScopes" routine.
11792 Simplify all the Add* routines as they no longer need to maintain
11793 the tree, they just need to record that they are using variables
11796 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11797 routines to produce the forest of ScopeInfo trees.
11799 * class.cs (TypeContainer.AppendMethod): This is just like
11800 AddMethod, but ensures that an interface implementation method
11801 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11802 methods, but at the end.
11804 We use this functionality to ensure that the generated MoveNext
11805 method in the iterator class is resolved/emitted before the
11806 enumerator methods created.
11808 This is required because the MoveNext method computes the right
11809 ScopeInfo for the method. And the other methods will eventually
11810 need to resolve and fetch information computed from the anonymous
11813 2006-01-21 Raja R Harinath <harinath@gmail.com>
11814 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11816 Fix rest of #76995.
11817 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11818 the 'aliases' hash.
11819 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11820 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11822 2006-01-18 Raja R Harinath <rharinath@novell.com>
11824 Fix #76656, cs0231-2.cs.
11825 * cs-parser.jay (formal_parameter_list): Make error case catch
11827 (parenthesized_expression_0): Add CS1026 check.
11828 (invocation_expression): Remove unused { $$ = lexer.Location }.
11830 2006-01-17 Raja R Harinath <rharinath@novell.com>
11833 * cs-parser.jay (statement_expression): Don't list out the
11834 individual statement-expressions. Convert syntax error into
11837 2006-01-16 Raja R Harinath <rharinath@novell.com>
11840 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11841 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11842 CheckIntermediateModification.
11843 (FieldExpr.DoResolve): Add new two-argument version that
11844 allows us to resolve the InstanceExpression as an lvalue.
11845 The one-argument variant is now just a wrapper.
11846 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11847 Resolve the lhs as an lvalue if the it has a value type.
11848 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11849 from Assign.DoResolve.
11850 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11851 resolved as an lvalue.
11852 (PropertyExpr.DoResolve): Update.
11853 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11854 has a value type. Move CS1612 check here from
11855 CheckIntermediateModification.
11856 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11857 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11858 'right_side' of a ResolveLValue on an 'out' argument.
11859 (EmptyExpression.LValueMemberAccess): New. Used as the
11860 'right_side' of a propagated ResolveLValue on a value type.
11861 (LocalVariableReference.DoResolveBase): Recognize
11862 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11864 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11865 EmptyExpression.Null.
11867 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11869 * typemanager.cs : added IsGenericParameter(). In mcs it always
11871 * doc.cs : for generic parameters, use GenericParameterPosition,
11874 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11876 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11878 2006-01-12 Miguel de Icaza <miguel@novell.com>
11880 This fixes the problem where we used ldfld instead of ldflda to
11881 load the "THIS" pointer on captured parameters, when THIS is a
11882 value type. See bug #77205.
11884 * iterators.cs (CapturedThisReference.Emit): Pass false to
11885 EmitThis (we do not need the address).
11887 * codegen.cs (EmitThis): it needs to know whether we need the
11888 address of `this' or not. This is used by value types.
11890 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11891 every other call passes false.
11893 2006-01-12 Raja R Harinath <rharinath@novell.com>
11896 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11898 * expression.cs (Invocation.OverloadResolve): Update.
11899 (Invocation.DoResolve): Avoid double resolution of invocation.
11901 2006-01-11 Raja R Harinath <rharinath@novell.com>
11904 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11905 unary negation of floating point types as 0-expr; negation cannot
11906 overflow in floating point types.
11909 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11910 on operands of 'void' type.
11913 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11914 and ExclusiveOr for boolean constants too.
11916 2006-01-09 Raja R Harinath <rharinath@novell.com>
11919 * expression.cs (Invocation.OverloadResolve): Replace reflected
11920 override methods with their base virtual methods, rather than
11921 skipping over them.
11922 * typemanager.cs (TypeManager.GetOverride): New.
11924 2006-01-05 Jb Evain <jbevain@gmail.com>
11926 * class.cs (Property.Define, Indexer.Define): do not tag the
11927 properties as SpecialName | RTSpecialName.
11929 2006-01-04 Miguel de Icaza <miguel@novell.com>
11931 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11932 doing a low-level comparission of parameter types. It was lacking
11933 a check for __argslist.
11935 2005-12-30 Miguel de Icaza <miguel@novell.com>
11937 * expression.cs (ParameterReference.DoResolveBase): Allow
11938 reference parameters if they are local to this block.
11940 This allows the ref and out parameters of a delegate to be used in
11941 an anonymous method, for example:
11943 delegate void set (out int x);
11945 set s = delegate (out int x){
11949 This is used by functionality introduced late in the C# language.
11951 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11952 method that take ref and out parameters.
11954 Fixes #77119 which was a late change in the spec.
11956 2005-12-23 Miguel de Icaza <miguel@novell.com>
11958 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11959 parent if its the same scope. Fixes #77060.
11961 2005-12-21 Miguel de Icaza <miguel@novell.com>
11963 * driver.cs: Report the case of no source files and no -out:
11966 2005-12-20 Raja R Harinath <rharinath@novell.com>
11969 * expression.cs (ComposedCast.GetSignatureForError): Define.
11971 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11975 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11976 ListDictionary, to contain the ExternAliasEntry entries (in
11977 addition to the NamespaceEntry.aliases hashtable). This field is
11978 shared between the original entry and its doppelganger (bodyless
11980 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11981 extern_aliases field.
11982 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11983 lookup in extern_aliases.
11985 2005-12-16 Raja R Harinath <rharinath@novell.com>
11988 * class.cs (TypeContainer.Mark_HasEquals): New.
11989 (TypeContainer.Mark_HasGetHashCode): New.
11990 (ClassPart): Override them.
11991 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11994 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11995 'parent' argument to the base constructor.
11997 Remove all mention of TypeContainer from decl.cs.
11998 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11999 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
12000 (DeclSpace.DeclSpace): Likewise.
12001 (DeclSpace.DefineMembers): Remove unused argument.
12002 * cs-parser.jay (pop_current_class): Update to changes. Simplify
12003 debugging check -- we don't care if the debug code throws an
12004 InvalidCastException instead of an InternalErrorException.
12005 * class.cs (TypeContainer.DefineMembers): Update to changes.
12006 (TypeContainer.DoDefineMembers): Likewise.
12007 (TypeContainer.GetMethods): Likewise.
12008 (PropertyMember.Define): Likewise.
12009 (MemberBase.Parent): New property that forwards to
12010 MemberCore.Parent, but ensures that we get a TypeContainer.
12011 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
12012 (RootContext.PopulateTypes): Likewise. Remove special case code
12013 for !RootContext.StdLib: DefineMembers is idempotent.
12015 2005-12-14 Miguel de Icaza <miguel@novell.com>
12017 * convert.cs (ExplicitConversionCore): Check the return value from
12018 ExplicitConversionCore which can return null on failure. Fixes #76914
12020 2005-12-13 Marek Safar <marek.safar@seznam.cz>
12022 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
12024 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
12026 * doc.cs : The search for referenced namespace was insufficient to
12027 get global one as it used to do. Fixed bug #76965.
12029 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
12031 * doc.cs : check name in cref in the last phase that whether it is
12034 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12036 * cs-tokenizer.cs : reverted the latest change: it somehow broke
12039 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12041 * doc.cs : so it turned out that we cannot skip override check for
12042 interface members. Fixed bug #76954.
12044 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12046 * cs-tokenizer.cs : fixed bug #75984:
12047 - #warning and #error should not be handled when the source line
12049 - #line is not checked strictly when the source line is disabled.
12050 - #define and #undef is on the other hand checked strictly at any
12053 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
12055 * cs-tokenizer.cs : missing Location (actually, filename) in one of
12058 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12060 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
12062 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
12063 event initializers.
12064 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
12065 (FieldBase.Initializer): Initializer is now optional.
12066 (EventField.Define): Only event field can have initializer.
12068 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
12070 * const.cs (Const): Reuse initializer.
12072 * cs-parser.jay: Updated after FieldBase changes.
12073 Added current_array_type to simplify array initializers.
12075 * ecore.cs (NullCast.IsDefaultValue): Implemented.
12077 * expression.cs, iterators.cs: Updated.
12079 * namespace.cs (NamespaceEntry): Made UsingFound private.
12081 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12083 * parameterCollection.cs: Obsolete, removed.
12084 * parser.cs: Obsolete, removed.
12086 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12089 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
12091 * enum.cs (Enum.Define): Set obsolete context here.
12093 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12096 - FindDocumentedMember() now expects 1) paramList as null
12097 when "we don't have to check the number of parameters" and
12098 2) Type.EmptyTypes when "there is no arguments".
12099 - Introduced FoundMember struct to hold the exact type which was
12100 used to find the documented member (the above change broke
12101 test-xml-044; it might be better just to use DeclaringType than
12102 what MS does, like this change does, but it depends on usage.)
12104 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12106 * doc.cs : documented member might be from DeclaringType for nested
12107 types. Fixed bug #76782.
12109 2005-12-03 Ben Maurer <bmaurer@ximian.com>
12111 * anonymous.cs: Have the param code handle leaving copies on the
12112 stack etc. Allows anonymous params to take part in the assignment
12113 code (++, +=, etc). Fixes bug #76550
12115 * expression.cs: Handle the prepare_for_load/leave_copy by passing
12116 it down to the anon code.
12118 * iterators.cs: Use dummy var here
12120 * codegen.cs: Handle new vars
12122 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12125 * class.cs (MethodData.Define): Set proper Obsolete context.
12127 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
12129 (FieldExpr.DoResolve): Ditto.
12131 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12134 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
12135 parent is not obsolete.
12137 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
12139 * doc.cs : (FindDocumentedMember) find parameterless members first
12140 and get CS0419 in the early stage. Fixed first case of bug #76727.
12142 2005-11-30 Marek Safar <marek.safar@seznam.cz>
12145 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
12146 no error was reported.
12148 *expression.cs (Binary.DoResolve): left can be null.
12150 2005-11-22 Marek Safar <marek.safar@seznam.cz>
12153 * class.cs (MethodData.Emit): Parameters should be labeled first.
12155 2005-11-21 Marek Safar <marek.safar@seznam.cz>
12158 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
12160 2005-11-18 Marek Safar <marek.safar@seznam.cz>
12162 * attribute.cs (AreParametersCompliant): Moved to Parameter.
12164 * class.cs (MethodCore): Parameter clean up.
12165 (IMethodData): Added ParameterInfo.
12166 (MethodData): Parameter clean up.
12167 (Indexer.Define): Parameter clean up.
12179 * typemanager.cs: Parameter clean up.
12181 * delegate.cs (Define): Get rid of duplicated code.
12183 * expression.cs (ParameterReference): Removed useless parameters
12185 (Invocation): Ditto.
12187 * parameter.cs (ParamsParameter): New class, params specialization.
12188 (ArglistParameter): Attemp to separate arglist.
12189 (Parameter): Refactored to be reusable and faster.
12190 (Parameter.Modifier): Made understandable.
12191 (Parameters): Changed to be used as a class for `this' assembly
12192 parameters. Refactored to use new specialized classes.
12194 * support.cs (ParameterData): Added Types property.
12195 (InternalParameters): Deleted.
12197 2005-08-20 Martin Baulig <martin@ximian.com>
12199 Merging this patch from GMCS to fix #75867.
12201 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12202 scope if we don't already have it.
12204 2005-11-17 Martin Baulig <martin@ximian.com>
12207 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
12208 inherit the scope from our parent. Fixes #76653.
12210 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12212 * doc.cs : the previous patch does not actually fix the bug.
12213 PropertyInfo override check is now implemented and really fixed it.
12214 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
12216 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12218 * doc.cs : apply "override filter" also to properties.
12221 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12223 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
12224 no need to check overrides. For classes, omit those results from
12225 interfaces since they must exist in the class. Fixed bug #76726.
12227 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12229 * typemanager.cs : (GetFullNameSignature) differentiate indexers
12230 with different parameters. Fixed the second problem in #76685.
12232 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12234 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
12235 get expected 'protected' access in CheckValidFamilyAccess()).
12238 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12240 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
12241 Fixed bug #76705. CS1569 was incorrectly commented out.
12243 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12245 * doc.cs : use Invocation.IsOverride() to do real override check.
12246 * expression.cs : made Invocation.IsOverride() internal.
12248 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12250 * doc.cs : use TypeManager.FindMembers() instead of (possible)
12251 TypeBuilder.FindMembers() and filter overriden base members out.
12254 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12256 * doc.cs : ref/out parameters are represented as '@' (instead of
12257 '&' in type FullName). Fixed bug #76630 (additionally crefs).
12259 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12261 * doc.cs : when there was no '.' in cref to methods in doc comment,
12262 then parameters were missing in the output. Fixed bug #76691.
12264 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12266 * driver.cs : don't output docs when there is an error.
12269 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12272 Now it should detect indexers. Fixed primary concern in bug #76685.
12273 Fixed CS0419 message to not show the identical member signature in
12276 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12278 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
12279 instead of Type.FindMembers() since it does not handle events.
12282 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
12284 * codegen.cs: Fixed typo (speficied -> specified).
12286 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12289 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
12291 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12293 * attribute.cs: Changed error message.
12295 * cs-tokenizer.cs: One more check.
12297 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12299 * statement.cs (Block.Resolve): Ignore empty statement.
12301 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12303 * report.cs: Made error/warning methods more strict to avoid
12306 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
12307 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
12308 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
12309 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
12311 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12313 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12314 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12316 * class.cs (TypeContainer.IsComImport): New property.
12317 (Constructor.Define): Create proper ctor for ComImport types.
12319 * expression.cs (New.CheckComImport): Fixed.
12321 2005-11-07 Miguel de Icaza <miguel@novell.com>
12323 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12324 that a parameter has been captured does not mean that we do not
12325 have to do the rest of the processing. This fixes the second part
12326 of #76592. If there was another anonymous method capturing
12327 values in the past, the Scope would never be set for the second
12328 method that captured the same parameter.
12330 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12331 properly manipulate the stack. Second part of fix for #76592.
12333 * expression.cs (New): Add support for invoking "new" on
12334 interfaces that have been flagged with the ComImport attribute and
12335 the CoClass. Fixes #76637
12337 * statement.cs (Try.DoEmit): When a variable is captured, do not
12338 try to emit the vi.LocalBuilder variable as it has been captured.
12339 Create a temporary variable and store the results on the
12340 FieldBuilder. Fixes #76642
12342 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12344 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12346 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12348 * expression.cs (Binary.DoResolve): Added && optimalization.
12350 * typemanager.cs (AddUserType): Removed useless argument.
12352 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12354 * statement.cs (Block.variables): Uses ListDictionary.
12356 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12359 * class.cs (PartialContainer.EmitType): Customized to emit
12360 security attributes.
12361 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12362 for partial classes.
12364 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12367 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12368 access has to be fixed.
12370 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12372 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12375 * ecore.cs (NullCast.Reduce): Implemented.
12377 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12380 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12382 (Foreach.Resolve): Catch null properly.
12384 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12386 * cs-tokenizer.cs: Warning text fix.
12388 * driver.cs: AllWarningNumbers exposed on public interface.
12390 * report.cs (): Reviewed warning numbers.
12391 (IsValidWarning): Use binary search.
12393 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12395 * driver.cs: Implemeted resource visibility.
12396 (Resources): New class for code sharing between /res: and
12399 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12402 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12405 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12408 * ecore.cs (NullCast): Child is contant only.
12410 * literal.cs (NullLiteral.Reduce): null can be converted to any
12413 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12415 * driver.cs: Use Encoding.Default as default code page instead
12418 2005-10-27 Raja R Harinath <rharinath@novell.com>
12421 * expression.cs (Invocation.Error_InvalidArguments): Handle
12422 __arglist parameters.
12423 (Invocation.VerifyArgumentsCompat): Likewise.
12424 * support.cs (ReflectionParameters.GetSignatureForError): Print
12425 __arglist parameters.
12426 (InternalParamters.GetSignatureForError): Likewise.
12427 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12429 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12431 * attribute.cs (GetPropertyValue): Made public.
12433 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12435 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12437 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12440 * driver.cs: Reflect method name change.
12442 * statement.cs (Try.Resolve): Warn when try has both general
12443 exception handlers.
12445 * typemanager.cs: runtime_compatibility_attr_type new predefined
12448 2005-10-26 Raja R Harinath <harinath@gmail.com>
12451 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12452 treat it as an empty parameter list.
12454 2005-10-26 Raja R Harinath <rharinath@novell.com>
12457 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12458 ResolveAsTypeStep silent.
12459 * statement.cs (Block.AddConstant): Mark block as used.
12460 (Block.ResolveMeta): Avoid piling on error messages
12461 if a constant initializer resolution fails.
12463 2005-10-25 Raja R Harinath <rharinath@novell.com>
12465 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12467 (NamespaceEntry.VerifyAllUsing): New.
12468 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12469 behaviour. Delegates actual resolution of alias to ...
12470 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12471 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12473 * driver.cs (Driver.MainDriver): Update.
12475 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12476 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12478 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12480 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12481 RootNamespace.DefineNamespacesForAll.
12483 2005-10-24 Raja R Harinath <harinath@gmail.com>
12485 * typemanager.cs (assemblies, external_aliases, modules)
12486 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12487 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12488 overhead. Move resposibility ...
12489 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12490 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12492 2005-10-23 Raja R Harinath <harinath@gmail.com>
12494 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12495 cached_namespaces. Improve usage.
12496 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12497 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12498 Move from GlobalRootNamespace and simplify.
12499 (RootNamespace.Global): Make instance variable.
12500 (RootNamespace.RootNamespace): Add "alias name" parameter.
12501 (GlobalRootNamespace): Simplify drastically.
12502 (Namespace.Lookup): Don't use GetNamespace.
12503 * typemanager.cs (GetRootNamespace): Rename from
12504 ComputeNamespaceForAlias.
12505 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12507 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12509 * anonymous.cs (AnonymousContainer): Don't crash when container
12512 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12514 * expression.cs (Binary.DoResolve): Warn when comparing same
12517 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12520 * expression.cs (Binary.DoResolve): It looks like there are no
12521 convetsion rules in enum context.
12523 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12525 Add support for extern alias qualifiers.
12526 * typemanager.cs: Move some LookupTypeReflection code
12527 to namespace.cs, to have cleaner code. Added some methods
12528 to help us keep track of the extern aliased references.
12529 * driver.cs: Add suport for extern alias assemblies on command
12530 line and check for their warnings/errors. Also keep track of the
12531 extern aliased assemblies.
12532 * namespace.cs: Move the global functionality of Namespace
12533 to GlobalRootNamespace/RootNamespace. Now the global namespace
12534 is GlobalRootNamespace.Globa. Also the code moved from
12535 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12536 Finally added LocalAliasEntry (AliasEntry before) and
12537 ExternAliasEntry, to handle alias statements.
12538 * cs-parser.jay: Add support in the grammar for extern alias
12540 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12541 Update callings to Namespace (now in GlobalRootNamespace).
12543 2005-10-18 Raja R Harinath <rharinath@novell.com>
12546 * class.cs (TypeContainer.DefineType): Move updating of
12547 topological sort earlier in the code.
12548 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12550 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12553 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12555 * constant.cs (Constant.TryReduce): Moved from Cast class.
12556 (Reduce): Made little bit more OO and fixed missing conversions.
12558 * ecore.cs (Reduce): Implemented.
12559 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12561 * literal.cs (Reduce): Implemented.
12563 * class.cs: Reverted Miguel's wrong commit.
12565 2005-10-14 Miguel de Icaza <miguel@novell.com>
12567 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12569 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12571 * cs-parser.jay, expression.cs : CS0214 was missing error location
12572 for constants. Fixed bug #76404.
12574 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12577 * convert.cs (ExplicitConversionCore): Fixed object->enum
12580 2005-10-10 Raja R Harinath <rharinath@novell.com>
12582 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12583 InstanceExpression.
12584 (PropertyExpr.EmitCall): Likewise.
12585 * expression.cs (Invocation.EmitArguments): Handle case where
12587 (Invocation.EmitCall): Avoid allocating temporary variable if
12588 there are no arguments.
12590 2005-10-07 Raja R Harinath <rharinath@novell.com>
12593 * convert.cs (ImplicitConversionStandard): Move conversion of
12594 void* to arbitrary pointer types ...
12595 (ExplicitConversionStandard): .. here.
12596 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12597 error to always print typenames.
12599 2005-10-07 Raja R Harinath <rharinath@novell.com>
12601 * convert.cs (GetConversionOperator): Rename from
12602 GetConversionOperators. Move operator selection code from ...
12603 (UserDefinedConversion): ... here.
12605 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12607 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12610 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12612 * assign.cs (Assign.DoResolve): Error method changed.
12614 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12616 * const.cs (ResolveValue): Reset in_transit immediately.
12618 * constant.cs: Error method changed.
12620 * convert.cs: Removed useless location parameter.
12621 (ExplicitNumericConversion): Don't do double enum check.
12622 (ExplicitConversionCore): Renamed from ExplicitConversion.
12623 (ExplicitUnsafe): Extracted from ExplicitConversion.
12624 (ExplicitConversion): Uses for error reporting.
12626 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12628 (ResolveBoolean): Uses common error method.
12629 (CastToDecimal): Get rid of ec.
12630 (CastFromDecimal): Optimized.
12631 (ConvCast): Get rid of ec.
12633 * enum.cs (ResolveValue): Reset in_transit immediately.
12634 (Emit): Return after first error.
12636 * expression.cs: Convert changes.
12638 * literal.cs: Error method changed.
12640 * statement.cs: Error method changed.
12642 2005-10-03 Raja R Harinath <rharinath@novell.com>
12644 * support.cs (SeekableStreamReader.Position): Don't error out when
12645 the requested position is just beyond the end of the current
12648 2005-09-28 Raja R Harinath <rharinath@novell.com>
12650 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12651 try to keep in sync with the byte count of the underlying Stream.
12652 However, this limits us to a window size of 2048 characters: i.e.,
12653 the maximum lookahead of our lexer/parser can be 2048 characters.
12655 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12658 * driver.cs: Fix compilation files with full root path.
12660 2005-09-25 Miguel de Icaza <miguel@novell.com>
12662 * report.cs (SymbolRelatedToPreviousError): Format the output so
12663 it does not use an open parenthesis that is never closed.
12665 * driver.cs: Follow coding guidelines
12667 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12670 * const.cs (Const.ResolveValue): Check for assigning non-null
12671 value to reference type.
12673 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12675 * anonymous.cs: Implemented ExprClassName.
12677 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12680 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12683 * class.cs (StaticClass.DefineContainerMembers): Report protected
12686 * codegen.cs: if(ed) PRODUCTION.
12688 * convert.cs (Error_CannotImplicitConversion): Better error
12691 * cs-parser.jay: More error checks.
12693 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12695 * driver.cs (CSCParseOption): Enabled wrong option check.
12697 * ecore.cs (Expression.ExprClassName): Turned to property.
12698 (MemberExpr.CheckIntermediateModification): For checking boxed
12699 value types modification.
12701 * statement.cs (Fixed.Resolve): Expression type must be
12702 convertible to fixed type.
12703 (CollectionForeach.GetEnumeratorFilter,TryType):
12704 Small refactoring for easier error checking.
12706 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12708 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12711 * class.cs (GeneratedBaseInitializer): New class for customization
12712 compiler generated initializers.
12713 (MemberBase.DoDefine): Check Obsolete attribute here.
12714 (FieldMember.DoDefine): Ditto.
12716 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12719 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12720 (MemberCore.GetObsoleteAttribute): Removed argument.
12721 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12722 (MemberCore.CheckObsoleteType): New helper.
12726 * statement.cs: Updates after MemberCore changes.
12728 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12729 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12731 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12732 obsolete attribute for compiler construct.
12733 (As.DoResolve): Cache result.
12735 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12737 2005-09-26 Raja R Harinath <rharinath@novell.com>
12740 * expression.cs (This.VerifyFixed): In a value type T, the type of
12741 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12742 value type R, 'this' is treated as a value parameter.
12744 2005-09-22 Miguel de Icaza <miguel@novell.com>
12746 * statement.cs (Lock): Use the TemporaryVariable class instead of
12747 manually using local variables as those do not work when variables
12750 * ecore.cs: Moved the TemporaryVariable class from being a nested
12751 class inside Foreach to be a public class that can be employed in
12754 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12756 * cs-parser.jay: interface_accessors replaced by
12757 accessor_declarations.
12759 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12762 * statement.cs (GotoCase.Resolve): Convert null constant to
12764 (SwitchLabel.ResolveAndReduce): Ditto.
12765 (SwitchLabel.NullStringCase): Custom null stamp.
12766 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12768 typemanager.cs (CSharpSignature): Don't skip first argument
12771 2005-09-18 Miguel de Icaza <miguel@novell.com>
12773 * driver.cs: Set InEmacs based on the environment variable EMACS.
12775 * location.cs (InEmacs): in this mode, do not report column
12776 location as it confuses Emacs.
12778 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12780 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12781 expression.cs, iterators.cs, literal.cs: Store constants and
12784 * class.cs (MemberBase.ShortName): Pass location.
12786 * cs-parser.jay: Some location fixes.
12788 * ecore.cs (Expression.Location): Made virtual.
12790 2005-09-05 Miguel de Icaza <miguel@novell.com>
12792 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12793 if the underlying types are the same, otherwise we need to produce
12794 code that will do the proper cast.
12796 This was exposed by Marek's constant rewrite which produced
12797 invalid code for the call site:
12799 enum X : long { a }
12800 void Method (X v) {}
12804 This fixes test-49.cs
12806 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12808 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12809 Type/Object should be allowed as well. Fixed bug #75968.
12811 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12813 * expression.cs : (Binary.DoResolve): when one is enum constant and
12814 another is constant 0, then return enum one *as enum type*.
12817 2005-09-02 Raja R Harinath <rharinath@novell.com>
12819 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12823 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12824 flow-branching for LocalVariableReferences in case we were invoked
12825 from a MemberAccess.
12826 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12828 (LocalVariableReference.DoResolveBase): ... this.
12829 (MemberAccess.Resolve): Do the check that was disabled during
12832 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12835 (PartialContainer.Create): check abstract/sealed/static strictly
12836 but abstract/sealed can exist only at one side. Fixed bug #75883.
12838 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12841 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12842 specified, don't default to UnmanagedType.I4.
12844 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12846 * expression.cs : conditional operator should check possibly
12847 incorrect assign expression. Fixed bug #75946.
12849 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12851 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12852 Reverting the change. gmcs is much complex than mcs on this matter.
12854 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12856 * cs-tokenizer.cs : To read another token ahead of the actual
12857 consumption, use new SavedToken and cache token instead of moving
12858 back the stream with SeekableStreamReader (it seemed problematic).
12860 driver.cs : Thus use StreamReader directly.
12861 * support.cs : Thus removed SeekableStreamReader.
12863 2005-08-30 Raja R Harinath <rharinath@novell.com>
12866 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12867 (ScopeInfo.EmitScopeType): Use it to construct field names from
12868 names of captured locals.
12871 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12872 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12873 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12874 (ExplicitConversion): Remove enum cases already handled by
12875 implicit conversion. Move implicit conversion check to the beginning.
12876 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12877 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12878 Don't treat System.Enum as a struct.
12880 2005-08-30 Jb Evain <jbevain@gmail.com>
12882 * attribute.cs: handles as expression in parameters.
12884 2005-08-30 Raja R Harinath <rharinath@novell.com>
12887 * class.cs (TypeContainer.VerifyClsName): Don't use a
12888 PartialContainer when verifying CLS compliance.
12889 (AbstractPropertyEventMethod): Set Parent here, ...
12890 (PropertyMethod): ... not here.
12892 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12894 * attribute.cs : escaped attribute name should not be allowed to be
12895 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12897 2005-08-29 Raja R Harinath <rharinath@novell.com>
12900 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12901 when converting a long constant to unsigned long.
12902 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12903 detect where IsApplicable and VerifyArgumentsCompat disagree.
12905 2005-08-29 Raja R Harinath <rharinath@novell.com>
12906 and Carlos Alberto Cortez <carlos@unixmexico.org>
12909 * class.cs (TypeContainer.CanElideInitializer): New helper.
12910 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12911 can safely emitting the initializer of a field.
12913 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12915 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12916 allowed inside a switch (without loop). Fixed bug #75433.
12918 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12920 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12921 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12923 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12925 * driver.cs : kinda reverting the default encoding changes (not exact
12926 revert since I noticed that "codepage:reset" might not work fine).
12928 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12930 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12931 Location. Now getter and setter store location correctly.
12932 (errors/cs0111-12.cs now reports the expected location.)
12934 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12936 * driver.cs : Use default encoding on the environment.
12937 Removed (now that) extra parameter for SeekableStreamReader.
12938 * support.cs : (SeekableStreamReader) third .ctor() argument for
12939 StreamReader is not required (always true). preamble size could
12940 be acquired in simpler and safe way.
12942 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12944 * cs-parser.jay: report CS0642 at warning level 3
12945 and report CS0642 for an if else statement also
12946 fixes bug #74745. Patch by John Luke (and a bit
12948 Removed extra CS0642 warning check for "while",
12950 * statement.cs: In Block.Resolve(), CS0642 check
12951 is reimplemented to check a sequence of an empty
12952 statement and a block.
12954 Both fix bug #66777.
12956 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12958 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12959 detection until I fix it.
12961 * cs-tokenizer.cs: Changed error message.
12963 * cs-parser.jay: Fixed 2 error locations.
12965 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12966 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12969 * enum.cs (GetSignatureForError): Fixed.
12971 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12975 * typemanager.cs (RegisterProperty): Removed.
12977 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12979 2005-08-24 Raja R Harinath <rharinath@novell.com>
12982 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12983 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12985 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12987 * expression.cs : tiny fix is required for not warning positive ulong.
12990 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12992 * expression.cs : add CS0652 check for constant and integral
12993 expression. Fixed bug #53974.
12995 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12997 * expression.cs : in DoNumericPromotions(), check if there is implicit
12998 conversion overload for string (to check CS0034). Fixed bug #52492.
13000 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13002 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
13004 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13006 * ecore.cs : report location when it is *not* Null.
13008 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13014 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
13015 correctly. Fixed bug #75721.
13017 2005-08-23 Raja R Harinath <rharinath@novell.com>
13019 * support.cs (SeekableStreamReader.Position): Avoid an expensive
13020 loop that performs 'min (pos, char_count)'.
13023 * expression.cs (Unary.ResolveOperator): Don't discard implicit
13024 converted value in Operator.OnesComplement.
13026 2005-08-22 Ben Maurer <bmaurer@ximian.com>
13028 * anonymous.cs: If the anon method is pulled into a helper class,
13029 it needs to be `internal' not `private'. Fixes runtime behavior on
13032 2005-08-20 Martin Baulig <martin@ximian.com>
13034 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
13035 scope if we don't already have it.
13037 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
13038 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
13041 2005-08-17 Marek Safar <marek.safar@seznam.cz>
13044 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
13045 is a partial class.
13047 2005-08-16 Marek Safar <marek.safar@seznam.cz>
13049 The big constants rewrite
13050 Fix #75746, #75685 and more
13051 As a side effect saved 1MB for MWF ;-)
13053 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
13054 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
13055 enum based for corlib compilation.
13057 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
13060 * class.cs (FixedField.Define): Use ResolveAsConstant.
13062 * const.cs (IConstant): Interface constants and enums.
13063 (Const.ResolveValue): New method for constant resolvning.
13064 (ExternalConstant): Constants from imported assemblies.
13066 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
13067 conversion; like enums.
13068 (Constant.ToType): Converts this constant to different type.
13069 (Constant.Increment): Adds 1.
13071 * convert.cs (ImplicitConversionRequired): Simplified.
13073 * cs-parser.jay: Create EnumMember directly.
13075 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
13077 * doc.cs (GenerateEnumDocComment): Removed.
13079 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
13080 (ConvertIntLiteral): Removed.
13081 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
13083 * enum.cs (EnumMember): Implement IConstant.
13084 (Enum.IsValidEnumConstant): Removed.
13085 (Enum.GetNextDefaultValue): Removed.
13086 (Enum.FindMembers): Updated.
13087 (Enum.GenerateDocComment): Iterate enum members.
13089 * expression.cs (Cast.TryReduce): Handle enums correctly.
13090 (New.Constantify): Made public.
13091 (MemberAccess.DoResolve): Removed contant specific if(s).
13093 * literal.cs (NullLiteral): Implement new abstract methods.
13095 * statement.cs (GotoCase.Resolve): Use new constant methods.
13096 (SwitchLabel.ResolveAndReduce): Use new constant methods.
13098 * typemanager.cs (LookupEnum): Removed.
13099 (IsEnumType): Fixed to work with corlib.
13100 (RegisterConstant): Removed.
13101 (LookupConstant): Removed.
13102 (GetConstant): Changed to work with IConstant.
13104 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
13106 * location.cs : Fixed overflown (>255) column number.
13108 2005-08-03 Raja R Harinath <rharinath@novell.com>
13110 First cut of the qualified-alias-member feature.
13111 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
13113 * cs-parser.jay (DOUBLE_COLON): New token.
13114 (namespace_or_type_name): Add rule for recognizing
13115 qualified-alias-members.
13116 (primary_expression): Likewise.
13117 (element_access): Allow QualifiedAliasMember as a possible
13118 type-bearing expression.
13119 (local_variable_type, local_variable_pointer_type): Likewise.
13120 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
13121 aliases in the current and enclosing namespace declarations.
13122 (NamespaceEntry.UsingAlias): Add CS0440 warning.
13123 * decl.cs (MemberName.is_double_colon): New.
13124 (MemberName.MemberName): Add new constructor for alias-member.
13125 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
13126 * expression.cs (QualifiedAliasMember): New expression type.
13128 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13130 * location.cs : it borked when no argument was specified.
13132 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13134 * location.cs : tiny ToString() format fix.
13136 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13138 * statement.cs : oops, it was missing.
13140 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13142 A set of fixes for precise line/column location.
13145 "token" field now holds a file/line "delta", a line number offset
13146 from the segment, and a column number. See also:
13147 http://lists.ximian.com/pipermail/mono-devel-list/2004-
13148 December/009508.html
13149 Removed static IsNull. Use instance IsNull property instead.
13150 * cs-tokenizer.cs :
13151 For some tokens it stores Location. For Identifier it stores
13152 LocatedToken which is a pair of string name and location.
13153 Column numbers are adjusted only at getChar().
13155 Use Location.ToString() for reporting (it now contains column).
13157 Largely modified to use LocatedToken instead of
13158 string (IDENTIFIER), and to acquire Location from some tokens.
13159 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
13160 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
13162 Now MemberName holds Location. DeclSpace.ctor() receives Location
13163 as a parameter. Removed extra parameters to all derived classes.
13164 Replaced Location.IsNull() with instance property.
13165 * assign.cs, expression.cs :
13166 Added .ctor() overload that omits Location.
13168 Added "nameEscaped" flag that indicates the identifier was escaped
13169 in the source file. This fixes bug #57047.
13171 2005-08-02 Marek Safar <marek.safar@seznam.cz>
13173 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
13174 New method, looking for lo-case imported cls type.
13176 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
13179 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
13181 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
13183 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
13184 all_imported_types.
13185 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
13187 Optimized to save 3.5 MB for SWF compilation.
13189 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13191 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
13192 (PartialContainer.Create): Moved logic AddToContainer.
13193 (PartialContainer.MarkForDuplicationCheck): Shares name.
13195 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
13198 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
13200 (Namespace.GetSignatureForError): New method.
13202 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
13203 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
13205 2005-08-01 Raja R Harinath <rharinath@novell.com>
13208 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
13209 member lookup rather than qualifier_type, since qualifier_type can
13212 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13214 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
13217 2005-07-31 Miguel de Icaza <miguel@novell.com>
13219 * statement.cs: Copy the local exception into the exception
13220 captured local. Fixes 75674
13222 2005-07-31 Raja R Harinath <harinath@gmail.com>
13225 * expression.cs (Invocation.OverloadResolve): Don't report error
13226 CS1501 if error CS1502 has been reported.
13227 (New.DoResolve): Delegate CS1501 reporting to
13228 Invocation.OverloadResolve.
13231 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
13232 invariant-meaning-in-block property in an enclosing block if
13235 2005-07-29 Marek Safar <marek.safar@seznam.cz>
13237 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
13238 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
13239 (Switch.CheckSwitch): Just save 50kb for SWF.
13241 2005-07-27 Martin Baulig <martin@ximian.com>
13243 * anonymous.cs (CaptureContext.AddField): Added
13244 `AnonymousContainer am' argument; compute its toplevel scope if
13245 it's not already computed. Fixes #75649.
13247 2005-07-26 Raja R Harinath <rharinath@novell.com>
13250 * class.cs (Constructor.Emit): Reset block to null if the block
13253 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13255 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
13257 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13259 * class.cs (MethodData.Define): Check whether accessor implementing
13260 interface is public.
13262 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
13264 2005-07-22 Marek Safar <marek.safar@seznam.cz>
13267 * namespace.cs (LookupType): Moved same type check to...
13269 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
13270 with the same name.
13272 2005-07-21 Raja R Harinath <rharinath@novell.com>
13274 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
13275 already found a typebuilder.
13276 * class.cs (MethodCore.IsDuplicateImplementation): Compare
13277 MemberNames, not strings.
13279 * const.cs (Error_ExpressionMustBeConst):
13280 Rename from Error_EpressionMustBeConst.
13281 * const.cs, class.cs, statement.cd: Update.
13283 2005-07-21 Marek Safar <marek.safar@seznam.cz>
13287 * const.cs (Const.LookupConstantValue): Report missing contant expression
13289 (Error_EpressionMustBeConstant): Only one error method.
13291 * class.cs, statement.c: Updated.
13293 2005-07-20 Raja R Harinath <rharinath@novell.com>
13295 * statement.cs (Block.Flags): Add back HasVarargs.
13296 (Block.flags): Make protected.
13297 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
13299 * typemanager.cs (types, typecontainers, user_types): Remove.
13300 (UserTypes, TypeContainers): Likewise.
13301 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
13302 (CleanUp, Reset): Update.
13303 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
13304 (GetNestedType): Use Type.GetNestedType.
13305 (CoreLookupType): Take two arguments, the namespace and the
13306 basename of the type. Update to use the Namespace.Lookup
13308 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
13309 (RealMemberLookup): Use IsNestedChildOf instead of playing with
13310 string concatenation and substring matches.
13311 * class.cs, enum.cs, delegate.cs: Update to changes.
13313 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13315 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13316 Expression and made virtual.
13318 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13319 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13321 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13323 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13326 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13329 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13332 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13333 AssemblyCultureAttribute is not used on executable.
13336 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13338 2005-07-16 Raja R Harinath <rharinath@novell.com>
13341 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13342 New. Reports CS0252/CS0253.
13343 Mostly taken from preliminary patch by Duncak Mak.
13344 (Binary.DoResolveOperator): Store results of operator lookup.
13345 Use them to detect if we need to warn about unintended reference
13348 2005-07-15 Raja R Harinath <rharinath@novell.com>
13351 * namespace.cs (Namespace.Lookup): Add back location parameter.
13352 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13353 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13355 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13356 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13357 (Namespace.LookupType): ... this.
13358 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13360 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13361 purported to handle pointers.
13362 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13365 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13367 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13370 2005-07-15 Raja R Harinath <rharinath@novell.com>
13372 * namespace.cs (Namespace.Lookup): Drop location parameter.
13373 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13374 (NamespaceEntry.Lookup): ... this.
13375 (NamespaceEntry.Error_AmbiguousTypeReference):
13376 Move here from DeclSpace.
13377 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13379 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13380 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13381 Move to NamespaceEntry.
13382 * delegate.cs, expression.cs: Update to changes.
13384 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13386 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13387 CheckAttributeType and refactored.
13388 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13389 ResolveAsTypeTerminal error handling.
13390 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13392 (GetSignatureForError): Print errors in same way.
13395 * codegen.cs: Reflect attribute GetSignatureForError change.
13398 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13400 * namespace.cs (UsingEntry): Refactored to make fields private.
13403 statement.cs: Error_UnexpectedKind has extra parameter.
13405 2005-07-14 Raja R Harinath <rharinath@novell.com>
13407 * ecore.cs (IAlias): Remove.
13408 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13409 that implement the interface.
13410 * namespace.cs (Namespace): Likewise.
13411 (Namespace.declspaces): Renamed from 'defined_names'.
13412 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13413 DeclSpace instead of an IAlias.
13414 * tree.cs (Tree.AddDecl): Update.
13416 2005-07-12 Raja R Harinath <rharinath@novell.com>
13418 * statement.cs (Block.Flags); Remove HasVarargs.
13419 (Block.HasVarargs): Move to ToplevelBlock.
13420 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13421 (Block.Variables): Make protected. Initialize variable hashtable
13423 (Block.AddVariable): Update.
13424 (Block.Resolve): Update to changes.
13425 (ToplevelBlock.HasVarargs): New boolean.
13426 (ToplevelBlock.ThisVariable): Move here from Block.
13427 (ToplevelBlock.AddThisVariable): Likewise.
13428 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13429 * expression.cs (This.ResolveBase): Update to changes.
13430 (ArglistAccess.DoResolve): Likewise.
13432 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13435 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13437 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13438 not used and not used & assigned.
13439 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13441 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13444 * expression.cs (Is.DoResolve): null is never provided type.
13446 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13449 * cs-parser.jay: Less strict event error rule to catch more errors.
13451 2005-07-08 Martin Baulig <martin@ximian.com>
13453 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13454 gettter (allowed) or setter (not allowed).
13456 * class.cs (Accessor): Implement IIteratorContainer.
13457 (Accessor.Yields): New public field.
13458 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13459 per-accessor basis.
13462 (get_accessor_declaration, set_accessor_declaration): Set the
13463 `yields' flag on the accessor, not the property.
13464 (property_declaration): Do the iterators check on a per-accessor
13465 basis and not for the whole property.
13467 2005-07-08 Martin Baulig <martin@ximian.com>
13469 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13470 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13472 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13475 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13476 (ExtractSecurityPermissionSet): Cope with self referencing security
13477 attributes properly.
13479 * driver.cs (SetOutputFile): Made public property OutputFile.
13481 2005-07-07 Raja R Harinath <rharinath@novell.com>
13484 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13485 has_nonstatic_fields. Make into a FieldBase pointer.
13486 (TypeContainer.AddField): Add CS0282 check.
13487 (TypeContainer.EmitType): Update.
13489 2005-07-06 Miguel de Icaza <miguel@novell.com>
13491 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13492 compare if they start with __.
13494 2005-07-06 Raja R Harinath <rharinath@novell.com>
13496 * statement.cs (Switch.SwitchGoverningType): Only look at
13497 UserCasts that don't need implicit standard conversions to one of
13498 the allowed switch types (Fixes test-322.cs).
13499 (LocalInfo.Resolve): Re-enable sanity-test.
13501 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13503 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13505 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13507 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13509 2005-07-06 Raja R Harinath <rharinath@novell.com>
13512 * ecore.cs (SimpleName.GetSignatureForError): Add.
13513 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13514 (MemberAccess.GetSignatureForError): Add.
13516 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13518 The big error and warning messages review.
13548 * typemanager.cs: Updated.
13550 * class.cs: (MethodCore.SetYields): Moved here to share.
13551 (PropertyMethod.Define): Moved iterator setup here.
13553 * iterators.cs: Add orig_method to have full access to parent
13556 2005-07-05 Raja R Harinath <rharinath@novell.com>
13558 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13559 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13560 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13561 variable of struct type.
13562 * expression.cs (Unary.ResolveOperator): Update to change.
13563 (Indirection.VerifyFixed): Likewise.
13564 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13565 (ParameterReference.VerifyFixed): Value parameters are fixed.
13566 (This.VerifyFixed): Treat 'this' as a value parameter.
13567 * statement.cs (LocalInfo.IsFixed): Remove.
13569 2005-07-01 Martin Baulig <martin@ximian.com>
13571 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13572 `ec.EmitThis ()' to get the correct scope.
13574 2005-07-01 Martin Baulig <martin@ximian.com>
13576 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13577 instance is a ParameterReference; fixes #75299.
13579 2005-07-01 Martin Baulig <martin@ximian.com>
13581 Reverted Marek's latest patch (r46725):
13582 - it contains structural changes which are neither mentioned in
13583 the ChangeLog nor explained anywhere; for example the additional
13584 argument of EmitContext's and Iterator's .ctor's and the
13585 TypeContainer.DefineMembers() change.
13586 - structural changes like this should go in in seperate patches
13587 and not be hidden in a huge patch which just seems to affect
13588 warnings and errors.
13589 a big and hard to understand patch.
13590 - it breaks iterators and causes regressions, for instance in
13593 2005-06-30 Raja R Harinath <rharinath@novell.com>
13596 * expression.cs (Indexers.map): Remove.
13597 (Indexers.Append): Filter out inaccessible setters and getters.
13598 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13601 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13602 Refactored from ...
13603 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13604 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13605 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13606 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13608 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13611 * class.cs (FieldBase.GetInitializerExpression): One more field
13614 2005-06-28 Miguel de Icaza <miguel@novell.com>
13616 * pending.cs: Do not define a proxy if the base method is virtual,
13617 it will be picked up by the runtime (bug 75270).
13619 2005-06-08 Martin Baulig <martin@ximian.com>
13621 The big Iterators rewrite :-)
13623 * iterators.cs: Rewrite this to use the anonymous methods framework.
13625 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13626 before the TypeContainers; see 2test-21.cs.
13629 (TypeContainer.DefineType): Don't create a new EmitContext if we
13630 already have one (this only happens if we're an Iterator).
13631 (TypeContainer.Define): Also call Define() on all our iterators.
13632 (Method.CreateEmitContext): Added support for iterators.
13635 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13636 (AnonymousContainer.CreateMethodHost): Moved here from
13637 AnonymousMethod and made abstract.
13638 (AnonymousContainer.CreateScopeType): New abstract method.
13639 (AnonymousContainer.IsIterator): New public property.
13640 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13641 get the ScopeTypeBuilder rather than manually defining it here.
13642 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13645 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13646 before RootContext.DefineTypes().
13648 * codegen.cs (EmitContext.RemapToProxy): Removed.
13649 (EmitContext.CurrentAnonymousMethod): Changed type from
13650 AnonymousMethod -> AnonymousContainer.
13651 (EmitContext.ResolveTopBlock): Protect from being called twice.
13652 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13653 (EmitContext.EmitThis): Removed the iterators hacks; use the
13654 anonymous methods framework for that.
13657 (ToplevelBlock.Container): Make this a property, not a field.
13658 (ToplevelBlock.ReParent): New public method; move the
13659 ToplevelBlock into a new container.
13660 (Foreach.TemporaryVariable): Simplify.
13662 2005-06-05 Martin Baulig <martin@ximian.com>
13664 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13665 (Block.AddTemporaryVariable): New public method; creates a new
13666 `LocalInfo' for a temporary variable.
13667 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13669 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13670 non-iterator variables.
13672 2005-06-05 Martin Baulig <martin@ximian.com>
13674 * statement.cs (Foreach.TemporaryVariable): Create the
13675 LocalBuilder in the Emit phase and not in Resolve since in some
13676 situations, we don't have an ILGenerator during Resolve; see
13677 2test-19.cs for an example.
13679 2005-06-04 Martin Baulig <martin@ximian.com>
13681 **** Merged r45395 from GCS ****
13683 The big Foreach rewrite - Part II.
13685 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13686 with `PropertyInfo ienumerator_getcurrent'.
13688 * codegen.cs (VariableStorage): Removed.
13691 (Foreach): Derive from Statement, not ExceptionStatement.
13692 (Foreach.CollectionForeach): New nested class. Moved all the code
13693 dealing with collection foreach here.
13694 (Foreach.ForeachHelperMethods): Removed.
13695 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13697 2005-05-23 Martin Baulig <martin@ximian.com>
13699 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13700 don't need to. Fix #75014.
13702 2005-05-20 Martin Baulig <martin@ximian.com>
13704 Merged r44808 from GMCS.
13706 * class.cs (TypeContainer.CircularDepException): Removed.
13707 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13708 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13709 (CS0146) and interface (CS0529) dependencies here.
13711 2005-06-21 Raja R Harinath <rharinath@novell.com>
13713 * expression.cs (Invocation.EmitCall): Fix initialization
13714 'this_call' to reflect current behaviour. Fix indentation.
13716 * convert.cs (FindMostEncompassedType): Add two trivial special
13717 cases (number_of_types == 0 || number_of_types == 1).
13718 (FindMostEncompasingType): Likewise.
13720 2005-06-17 Raja R Harinath <rharinath@novell.com>
13722 Some cleanups preparing for the fix of #75283.
13723 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13725 (EventExpr.InstanceResolve): Likewise.
13726 (EventExpr.DoResolve): Remove redundant checks.
13728 2005-06-10 Duncan Mak <duncan@novell.com>
13730 * cs-tokenizer.cs (process_directives): New flag for controlling
13731 the processing of preprocessor directives.
13732 (x_token): After seeing a '#', return Token.NONE instead of going
13733 to handle_preprocessing_directive() when not processing
13734 directives. This avoids unnecessary processing during the token peek in
13739 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13740 the existing error reporting methods instead of Report.Error.
13742 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13743 after Raja's rewrite.
13745 2005-06-08 Miguel de Icaza <miguel@novell.com>
13747 * class.cs: Small fix.
13749 2005-06-08 Raja R Harinath <rharinath@novell.com>
13752 * class.cs (GetPartialBases): Fix return value check of
13753 part.GetClassBases.
13755 2005-06-07 Raja R Harinath <rharinath@novell.com>
13757 Ensure that partial classes are registered in their enclosing
13758 namespace. Initial part of fix of #75160.
13759 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13760 Register declspace with namespace here, not in
13761 DeclSpace.RecordDecl.
13762 * cs-parser.jay: Pass namespace to RecordDecl.
13763 * class.cs (PartialContainer.Create): Likewise.
13764 (ClassPart.DefineType): New sanity-check. Throws an exception if
13766 * decl.cs (Declspace.RecordDecl): Remove.
13767 * namespace.cs (NamespaceEntry.DefineName): Remove.
13769 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13771 * rootcontext.cs: Reset TargetExt as well.
13773 2005-06-03 Raja R Harinath <rharinath@novell.com>
13775 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13776 -langversion:ISO-1.
13778 2005-06-02 Raja R Harinath <rharinath@novell.com>
13780 Fix #75080, cs0119.cs.
13781 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13783 (Expression.Resolve): ... this. Use it. Remove bogus code
13784 allowing ExprClass.Type and ExprClass.Namespace for
13785 ResolveFlags.VariableOrValue.
13786 (Expression.Resolve) [1-argument variant]: Change default resolve
13787 flags based on language version.
13788 (Expression.Error_UnexpectedKind): Use a simple string array
13789 rather than an ArrayList.
13790 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13791 not ExprClass.Type.
13792 (TypeOfVoid.DoResolve): Likewise.
13793 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13794 flags argument -- it always has the same value.
13796 2005-05-31 Raja R Harinath <rharinath@novell.com>
13799 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13800 Use it in the error message.
13801 * assign.cs, expression.cs, statement.cs: Update.
13803 2005-05-30 Raja R Harinath <rharinath@novell.com>
13806 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13807 the "almostMatchedMember" case too.
13808 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13809 that failed the accessibility checks to 'almost_match'.
13811 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13813 * attribute.cs: Use internal MethodBuilder methods to set
13814 ExactSpelling and SetLastError on PInvoke methods, instead
13815 of passing them via charset. Fixes #75060.
13817 2005-05-27 Raja R Harinath <rharinath@novell.com>
13819 * parameter.cs (Parameter): Remove TODO comment.
13820 (Parameter.DefineParameter): Remove Location parameter.
13821 (Parameters.LabelParameters): Likewise.
13822 * class.cs (Constructor.Emit): Update to change.
13823 (MethodData.Emit): Likewise.
13824 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13825 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13827 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13830 Removed Parameters.Location and added Parameter.Location instead.
13831 Removed Location parameter from Emit() and GetSignature().
13838 Modified all related calls.
13840 2005-05-26 Raja R Harinath <rharinath@novell.com>
13842 Improve user-defined conversion handling.
13843 * convert.cs (GetConversionOperators): Rewrite. Return only the
13844 applicable operators.
13845 (AddConversionOperators): New. Helper for GetConversionOperators.
13846 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13847 there is only one most encompassed/encompassing type.
13848 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13849 "applicable operator" handling.
13850 (UserConversion): Move cache here from GetConversionOperators.
13851 Directly cache the chosen operator, rather than the whole
13853 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13854 case. Allow conversion of decimal to sbyte and byte too.
13855 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13856 New static methods. Used to avoid allocating EmptyExpressions in
13859 2005-05-24 Duncan Mak <duncan@novell.com>
13861 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13862 another class, used in Convert.ExplicitNumericConversion.
13863 (CastToDecimal): New class, similar to above, but casts to
13864 System.Decimal, used in Convert.ImplicitNumericConversion and also
13865 in explicit convesion from double/float to decimal.
13867 * convert.cs (ImplicitNumericConversion): Handle implicit
13868 conversions to System.Decimal.
13869 (ExplicitNumericConversion): handle explicit conversions to
13874 2005-05-20 Miguel de Icaza <miguel@novell.com>
13876 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13877 know the type at this stage, just break through. Fixes #75008
13879 2005-05-19 Martin Baulig <martin@ximian.com>
13882 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13883 to disable error reporting.
13885 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13886 here since we don't want to report an error; see the new test-336.cs.
13888 2005-05-19 Raja R Harinath <rharinath@novell.com>
13890 * statement.cs (ToplevelBlock.GetParameterReference)
13891 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13892 Move here from class Block.
13893 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13894 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13896 2005-05-18 Martin Baulig <martin@ximian.com>
13901 (FlowBranching.Reachability): Add non-static public And() and Or()
13903 (FlowBranchingSwitch): New class; do the `break_origins' thing
13904 like in FlowBranchingLoop.
13905 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13906 reachability, not just locals and parameters.
13907 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13908 switch; MergeBreakOrigins() now takes care of that.
13910 2005-05-18 Martin Baulig <martin@ximian.com>
13912 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13913 a loop and may leave it, reset the barrier; fixes #74974.
13915 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13917 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13920 * cs-parser.jay: Catch more lexical errors.
13922 * report.cs: Add one more Error method.
13925 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13927 2005-05-17 Martin Baulig <martin@ximian.com>
13929 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13932 2005-05-16 Raja R Harinath <rharinath@novell.com>
13934 Fix test-382.cs. Emit values of decimal constants.
13935 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13937 (TypeContainer.AddField): ... this.
13938 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13939 with initializers to include 'Const's.
13940 (ClassPart.RegisterFieldForInitialization): Forward to
13942 * const.cs (Const.Const): Pass initializer to base class.
13943 (Const.Define): In case of decimal constants, register them for
13944 initialization in a static constructor.
13946 2005-05-14 Martin Baulig <martin@ximian.com>
13948 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13949 do not call ResolveUnreachable() on unreachable statements in
13950 here, see the comment in the source code.
13952 2005-05-13 Raja R Harinath <rharinath@novell.com>
13955 * expression.cs (BinaryResolveOperator): If one of the operands of
13956 an equality comparison is 'null' and the other is a pointer type,
13957 convert the null to a NullPointer.
13958 * convert.cs (ImplicitReferenceConversion): If the expression is a
13959 NullLiteral and the target type is a pointer type, return a
13960 NullPointer instead.
13961 (ImplicitConversionStandard): Likewise.
13963 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13965 * cs-parser.jay: Set readonly context based on special constructs.
13967 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13968 readonly variable error handling.
13970 * rootcontext.cs (EmitCode): Don't verify members when error
13973 * statement.cs (LocalInfo): Add reaodnly context information.
13974 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13976 2005-05-13 Raja R Harinath <rharinath@novell.com>
13978 * statement.cs (Block.Resolve): Revert change below. Modify fix
13979 for #74041 to initialize 'resolved' to false only for explicit
13980 blocks. Fixes #74873.
13982 2005-05-12 Raja R Harinath <harinath@gmail.com>
13985 * typemanager.cs (unmanaged_enclosing_types): New.
13986 (IsUnmanagedType): Avoid infloops by using
13987 'unmanaged_enclosing_types' to talk with recursive invocations.
13989 2005-05-13 Martin Baulig <martin@ximian.com>
13991 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13992 instance variable, not a local. Fix #74873.
13993 (Block.ResolveUnreachable): Set it to true here.
13995 2005-05-11 Duncan Mak <duncan@novell.com>
13997 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13998 continuing to process for 'arg'.
13999 (handle_preprocessing_directive): Check the argument of the #endif
14000 directive and report error CS1025 if there are any trailing
14003 According to the C# spec, having even whitespace after the #endif
14004 directive is illegal; however, because we call arg.TrimEnd ()
14005 beforehand, we have the same behavior as csc, allowing whitespace
14006 after the directive.
14010 2005-05-11 Marek Safar <marek.safar@seznam.cz>
14014 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
14015 (Constructor.GetObsoleteAttribute): Implemented correctly.
14017 2005-05-10 Martin Baulig <martin@ximian.com>
14019 * support.cs (ReflectionParameters.ParameterModifier): Use
14020 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
14021 and `ParameterAttributes.In'. Fixes #74884.
14023 2005-05-10 Marek Safar <marek.safar@seznam.cz>
14025 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
14027 * expression.cs (Argument.GetParameterModifier): Turned to property.
14028 (Invocation.Error_InvalidArguments): Add more descriptive errors.
14030 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
14033 2005-05-09 Raja R Harinath <rharinath@novell.com>
14036 * decl.cs (MemberCache.AddMethods): Register override methods,
14037 rather than non-override methods.
14038 * typemanager.cs (RegisterOverride): New.
14039 (IsOverride): Update.
14041 2005-05-09 Marek Safar <marek.safar@seznam.cz>
14045 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
14046 recursive declaration.
14048 * statement.cs (Block.ResolveMeta): Report any error in resolving.
14050 2005-05-06 Marek Safar <marek.safar@seznam.cz>
14052 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
14054 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
14056 2005-05-05 Raja R Harinath <rharinath@novell.com>
14059 * decl.cs (DeclSpace.FamilyAccessible):
14060 Use TypeManager.IsNestedFamilyAccessible.
14062 Fix reopened #64812.
14063 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
14066 2005-05-04 Raja R Harinath <rharinath@novell.com>
14067 Abin Thomas <projectmonokochi@rediffmail.com>
14068 Anoob V E <projectmonokochi@rediffmail.com>
14069 Harilal P R <projectmonokochi@rediffmail.com>
14072 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
14073 allow access to all static members.
14075 2005-05-04 Martin Baulig <martin@ximian.com>
14077 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
14079 2005-05-04 Martin Baulig <martin@ximian.com>
14083 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
14084 section at the end; make things work if `default' is not the last
14087 2005-05-04 Martin Baulig <martin@ximian.com>
14091 * statement.cs (Switch): Replaced the `got_default' field with a
14092 `default_section' one.
14093 (Switch.CheckSwitch): Set `default_section' here.
14094 (Switch.Resolve): If we're a constant switch and the constant is
14095 not found, use the default section.
14097 2005-05-03 Martin Baulig <martin@ximian.com>
14099 * expression.cs (ArrayAccess.EmitGetLength): New public method.
14101 * statement.cs (Foreach.ArrayForeach): New nested class.
14102 (Foreach.TemporaryVariable): New nested class.
14103 (Foreach.EmitArrayForeach): Removed; this is now in the new
14104 ArrayForeach class.
14106 2005-05-03 Raja R Harinath <rharinath@novell.com>
14108 * pending.cs (BaseImplements): Move the #74773 fix here. This is
14110 (VerifyPendingMethods): Revert change below.
14112 * typemanager.cs (IsOverride, RegisterNonOverride): New.
14113 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
14114 that used to trigger warning -28. Remove warning -28.
14115 * expression.cs (Invocation.OverloadResolve): Use
14116 TypeManager.IsOverride to distinguish override methods.
14119 * pending.cs (VerifyPendingMethods): If a base type implements the
14120 requested interface, don't bother checking individual methods of
14121 the base type. As a side-effect, this prevents the creation of
14122 unnecessary proxies.
14124 2005-05-02 Martin Baulig <martin@ximian.com>
14128 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
14129 Also `And' the locals if the old vector is null.
14130 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
14131 null; in this case we basically reset all the variables.
14133 2005-05-02 Martin Baulig <martin@ximian.com>
14137 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
14138 Added `FlowBranching branching' argument; always `and' the
14139 variables instead of `or'ing them unless we're an infinite loop.
14141 * statement.cs (While.Resolve): Create a new sibling unless we're
14144 2005-05-02 Martin Baulig <martin@ximian.com>
14148 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
14149 arguments; use it instead of creating a new TopLevelBlock.
14150 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
14151 our ConstructorInitializer.
14154 (TopLevelBlock.TopLevelBranching): New public property.
14155 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
14156 and create our `TopLevelBranching'.
14158 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
14159 anonymous method host, use `block.TopLevelBranching' rather than
14160 creating a new branching.
14162 2005-04-20 Miguel de Icaza <miguel@novell.com>
14164 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
14165 a ScopeInfo, if any of the current children is a child of the new
14166 entry, move those children there.
14168 2005-04-30 Martin Baulig <martin@ximian.com>
14170 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
14171 at the beginning of a SwitchSection. Fix #73335.
14173 2005-04-27 Marek Safar <marek.safar@seznam.cz>
14176 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
14178 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
14179 (FieldExpr.DoResolve): Obsolete members are ignored for field
14182 2005-04-26 Marek Safar <marek.safar@seznam.cz>
14184 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
14185 of arrays detection.
14187 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
14189 (Field.VerifyClsCompliance): Volatile fields are not compliant.
14191 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
14194 2005-04-25 Ben Maurer <bmaurer@ximian.com>
14196 * cs-parser.jay: Use the prefered version of -unsafe in error
14199 2005-04-22 Marek Safar <marek.safar@seznam.cz>
14201 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
14204 2005-04-20 John Luke <john.luke@gmail.com>
14206 * driver.cs: fix typo in error message, --outout to --output
14208 2005-04-20 Marek Safar <marek.safar@seznam.cz>
14210 * codegen.cs (InRefOutArgumentResolving): New field.
14212 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
14213 fields outside contructor.
14215 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
14217 2005-04-19 Miguel de Icaza <miguel@novell.com>
14219 * anonymous.cs (CaptureContext.EmitParameterInstance): The
14220 parameter code was not completed ever, so it was not as up-to-date
14221 as local variables. Must finish it.
14223 The bug fix was to compare the Toplevel of the block, not the
14224 current block. Thanks for Ben for pointing this out.
14226 2005-04-19 Raja R Harinath <rharinath@novell.com>
14228 * decl.cs (AddMethods): Use the declaring type of the problem
14229 method to determine if we want to squash a warning.
14231 2005-04-19 Marek Safar <marek.safar@seznam.cz>
14233 * attribute.cs: Removed debug output.
14235 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
14237 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
14240 2005-04-18 Raja R Harinath <rharinath@novell.com>
14243 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
14244 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
14245 all null comparisons against reference types.
14247 2005-04-18 Marek Safar <marek.safar@seznam.cz>
14250 * class.cs (TypeContainer.CircularDepException) New nested
14252 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
14253 (TypeContainer.DefineType): Removed error, reset InTransit before
14255 (Class.DefineType): Throw exception when is in Transit.
14256 Catch exception and report error.
14257 (Struct.DefineType): Throw exception when is in Transit.
14258 Catch exception and report error.
14259 (Interface.DefineType): Throw exception when is in Transit.
14260 Catch exception and report error.
14262 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
14263 handle nested exception handlers.
14265 * flowanalysis.cs (InTryWithCatch): New method, search for try with
14268 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
14269 InFinally and InCatch storage.
14271 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
14272 (Catch.Resolve): Set and Restore ec.InCatch.
14273 (Try.Resolve): Set and Restore ec.InFinally.
14274 (Try.HasCatch): True when try has catch.
14276 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
14278 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
14279 for the same event member, so exclude such cases from warning 419.
14282 2005-04-16 Miguel de Icaza <miguel@novell.com>
14284 * expression.cs (Binary.ResolveOperator): Apply patch from John
14285 Luke to fix bug 59864: operators &, | and ^ on enumerations
14286 require that the same enum type on both sides.
14288 * driver.cs: Add warnings to old flag usage, this is to assist
14289 people who produce Makefiles and hope that the Makefiles will be
14292 * class.cs (TypeContainer.EmitType): Moved the definition of the
14293 special $PRIVATE$ field from the resolve phase to the Emit phase.
14294 During resolve we do not know if we are a struct with
14295 HasExplicitLayout, we know this only after the attributes for the
14298 Set the FieldOffset to zero on the dummy field that we create for
14299 the class. Fixes 74590.
14301 2005-04-16 Raja R Harinath <rharinath@novell.com>
14304 * ecore.cs (PropertyExpr.resolved): New.
14305 (DoResolve): Use it to handle a case of double resolution here.
14306 Handle a case of identical-name-and-type-name.
14307 * expression.cs (ArrayCreation.CheckIndices): Avoid double
14308 resolution by storing the results of expression resolution back
14309 into the "probes" array.
14311 2005-04-15 Raja R Harinath <rharinath@novell.com>
14313 Fix cs0208-7.cs and cs0208-8.cs.
14314 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14315 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14316 error reporting to point out the reason a struct is not unmanaged.
14318 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14320 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14321 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14323 2005-04-13 Raja R Harinath <rharinath@novell.com>
14326 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14327 IdenticalNameAndTypeName here.
14328 (EventExpr.InstanceResolve): Likewise.
14330 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14332 C# 2.0 DefaultCharSetAttribute implementation
14334 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14335 which allows us to set GlobalNamespace for every resolve.
14336 (Attribute.ResolveArguments): Cut from Resolve.
14337 (Attribute.GetCharSetValue): Returns CharSet named argument.
14338 (Attribute.DefinePInvokeMethod): Gets default charset from
14340 (GlobalAttribute.ResolveAsTypeStep): Override.
14341 (GlobalAttribute.ResolveArguments): Override.
14343 * class.cs (TypeAttr): Is protected.
14345 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14346 (ModuleClass.DefaultCharSetType): New memeber.
14347 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14349 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14350 charset from module.
14352 * delegate.cs (TypeAttr): Override.
14353 (Delegate.DefineType): Use this TypeAttr.
14355 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14356 at very early stage (before types are defined) to resolve model
14357 module attributes. It will probably not work with corlib but it
14360 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14361 charset from module.
14363 * typemanager.cs (default_charset_type): New type.
14365 2005-04-13 Raja R Harinath <rharinath@novell.com>
14367 * decl.cs (MemberCache.AddMethods): Don't warn if
14368 System.Object.Finalize has buggy MethodAttributes.
14370 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14373 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14375 * doc.cs : detect ambiguous reference to overloaded members.
14376 Fixed bug #71603. MS 1.1 csc does not detect it.
14378 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14380 * doc.cs : delegates must not be referenced with parameters.
14383 2005-04-12 Miguel de Icaza <miguel@novell.com>
14385 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14387 2005-04-10 Miguel de Icaza <miguel@novell.com>
14389 * driver.cs (MainDriver): Stop processing if the CLS stage found
14392 (CompilerCallableEntryPoint.InvokeCompiler): Always
14393 reset after execution; Take a TextWriter argument for the
14396 * report.cs: Use the error stream instead of hardcoding stderr.
14398 2005-04-09 Miguel de Icaza <miguel@novell.com>
14400 * class.cs: Reduce code paths to test, too small of an
14401 optimization to make it worth the extra testing. Always perform
14404 2005-04-08 Raja R Harinath <rharinath@novell.com>
14407 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14408 operators that had errors reported on them.
14410 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14412 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14414 (Attribute.Resolve): Add named argument type checking.
14416 * class.cs (FixedField.Define): Use IsPrimitiveType
14418 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14420 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14421 unsafe parameter types.
14423 * statement.cs (Using.ResolveExpression): Add better error description.
14425 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14427 2005-04-08 Raja R Harinath <rharinath@novell.com>
14430 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14431 AttributeUsageAttribute in the emitcontext of the attribute class,
14432 not in the emitcontext of the attributable entity it was attached to.
14433 * cs-parser.jay: Use 'current_class', not 'current_container',
14434 when creating a GlobalAttribute.
14436 2005-04-08 Alp Toker <alp@atoker.com>
14438 * pending.cs: The fix to #58413 failed to compile methods implementing
14439 interfaces with/without params modifiers and vice versa, even though
14440 params modifiers aren't part of the signature. Make the modifier check
14441 less strict as in csc.
14443 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14444 Anoob V E <projectmonokochi@rediffmail.com>
14445 Harilal P R <projectmonokochi@rediffmail.com>
14448 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14449 modifiers of pending methods.
14450 (PendingImplementation.PendingImplementation): Initialize it.
14451 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14452 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14453 with ParameterData. Add check for modifiers.
14454 * class.cs (MethodData.Define): Update to changes.
14456 2005-04-07 Raja R Harinath <rharinath@novell.com>
14458 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14460 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14462 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14465 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14468 * typemanager.cs: Registered RequiredAttributeAttribute.
14470 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14472 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14473 Warning CS0169 is back at level 3.
14474 (IMethodData.SetMemberIsUsed): New method.
14476 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14477 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14479 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14481 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14483 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14486 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14489 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14490 to avoid the problems with nested types.
14492 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14493 Anoob V.E <projectmonokochi@rediffmail.com>
14494 Harilal P.R <projectmonokochi@rediffmail.com>
14495 Raja R Harinath <rharinath@novell.com>
14498 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14500 * typemanager (GetConstructor): Make public.
14502 2005-04-05 John Luke <john.luke@gmail.com>
14503 Raja R Harinath <rharinath@novell.com>
14506 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14507 struct too. Return false quicker in a few cases.
14508 (VerifyUnManaged): Use it.
14510 2005-04-05 Raja R Harinath <rharinath@novell.com>
14513 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14514 not 'unreachable_seen'.
14516 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14518 * attribute.cs (Attribute.GetValue): Removed unused.
14520 * codegen.cs (CodeGen.TrimExt): Removed unused.
14522 * cs-parser.jay (output): Removed unused.
14524 * cs-tokenizer.cs (hex_digits): Removed unused.
14526 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14528 * expression.cs (Indirection.LoadExprValue): Removed unused.
14529 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14531 * iterators.cs (Iterator.param_types): Removed unused.
14533 * statement.cs (Goto.block): Removed unused.
14534 (ToplevelBlock.did): Removed unused.
14535 (Switch.ResolveConstantSwitch): Removed unused.
14537 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14539 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14542 2005-04-01 Raja R Harinath <rharinath@novell.com>
14544 Fix #74232 and cs0208-3.cs.
14545 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14546 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14547 unmanaged type. Don't use FieldBuilders when 't' is a
14548 TypeBuilder. Use ModFlags and MemberType fields.
14549 * class.cs (MemberBase.member_type): Rename from MemberType.
14550 (MemberBase.MemberType): New property. Determines member_type on
14552 (MemberBase.DoDefine): Don't initialize MemberType here.
14553 (FieldMember.Define): Likewise.
14555 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14558 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14559 Attributes are emitted there.
14561 2005-04-01 Raja R Harinath <rharinath@novell.com>
14563 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14564 keyword in 'partial enum' too.
14565 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14567 Report from Kamil Skalski <nazgul@omega.pl>.
14570 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14571 have partial containers too.
14573 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14574 in block' checks to Block.CheckInvariantMeaningInBlock.
14575 * statement.cs (Block.GetKnownVariableInfo): Make private.
14576 (Block.IsVariableUsedInChildBlock): Remove.
14577 (Block.IsVariableUsedInBlock): Likewise.
14578 (Block.CheckInvariantMeaningInBlock): New. Show location of
14579 conflicting declaration.
14580 (Block.AddVariable): Make error messages less long-winded and more
14581 specific. Show location of conflicting declaration.
14582 * parameter.cs (Parameters.Location): New readonly property.
14584 2005-03-31 Raja R Harinath <rharinath@novell.com>
14586 Clean up semantics of invoking ResolveMemberAccess.
14587 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14588 can have an instance, ensure that we pass in a non-TypeExpression
14589 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14590 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14591 argument. Update to changes and simplify.
14592 (FieldExpr.Emitinstance): Remove CS0120 check.
14593 (PropertyExpr.EmitInstance): Likewise.
14594 * expression.cs (Argument.Resolve): Likewise.
14595 (Invocation.DoResolve): Update to changes in semantics of
14596 InstanceExpression.
14598 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14601 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14604 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14606 2005-03-31 Raja R Harinath <rharinath@novell.com>
14608 Fix difference in behaviour with commandline invocation.
14609 * driver.cs (Driver.Reset): New.
14610 (CompilerCallableEntryPoint): Call it.
14612 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14613 variable" warnings if the boolean expression failed to resolve.
14615 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14617 * attribute.cs: Fix the union of several permissions when some of them
14618 are unrestricted (so the result isn't an unrestricted permission set).
14621 2005-03-30 Raja R Harinath <rharinath@novell.com>
14623 * ecore.cs (MemberExpr): New class. Convert from interface
14625 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14626 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14628 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14629 (MethodGroupExpr.IsExplicitImpl): Remove.
14630 (Expression.GetFieldFromEvent): Remove.
14631 (SimpleName.MemberStaticCheck): Remove.
14632 (SimpleName.DoSimpleNameResolve): Update to changes.
14633 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14634 (MemberAccess.IdenticalNameAndTypeName): Remove.
14635 (MemberAccess.error176): Move to MemberExpr.
14636 (MemberAccess.DoResolve): Update to changes.
14637 (BaseAccess.DoResolve): Likewise.
14639 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14641 C# 2.0 Conditional attribute class implementation
14643 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14644 Analyzes class whether it has attribute which has ConditionalAttribute
14645 and its condition is not defined.
14647 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14648 (Class.IsExcluded): New method. Search for at least one defined
14649 condition in ConditionalAttribute of attribute class.
14651 2005-03-30 Raja R Harinath <rharinath@novell.com>
14653 * ecore.cs (PropertyExpr): Derive from Expression, not
14654 ExpressionStatement.
14655 (PropertyExpr.EmitStatement): Remove.
14657 2005-03-29 Raja R Harinath <rharinath@novell.com>
14660 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14661 internal field "value__" of an enum be private. The examples for
14662 "value__" that I found on MSDN all used FieldAttributes.Private.
14664 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14665 Don't mention IL method attribute names.
14667 Fix #47991. Remove a TODO.
14668 * statement.cs (Block.Toplevel): Make into a field.
14669 (Block.Parameters): Move into ToplevelBlock.
14670 (Block.known_variables): Rename from child_variable_names.
14671 (Block.Block): Remove variants that take Parameters. Initialize
14672 'Toplevel' with the immediately surrounding toplevel block.
14673 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14674 LocalInfo parameter.
14675 (Block.GetKnownVariableInfo): New.
14676 (Block.IsVariableNameUsedInChildBlock): Update.
14677 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14678 the block, even though it may not be in scope.
14679 (Block.AddVariable): Remove Parameters parameter. Use
14680 Toplevel.Parameters instead.
14681 (Block.AddConstant): Remove Parameters parameter.
14682 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14683 (Block.IsParamaterReference): Likewise.
14684 (Block.IsLocalParameter): Likewise. Simplify a lot.
14685 (ToplevelBlock.Parameters): New. Moved from Block.
14686 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14687 initialize Parameters to a non-null value.
14688 * cs-parser.jay: Update to changes.
14689 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14690 simple names that mean different things in the same block. Use
14691 Block.IsVariableNameUsedInBlock.
14693 2005-03-28 Raja R Harinath <rharinath@novell.com>
14695 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14696 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14697 GetTypeHandle. It is possible for a reflected type to derive from
14698 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14699 System.Array during mscorlib compilation).
14700 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14701 contain a method_hash, don't create one either. Don't create a
14702 deep copy of the base cache's method_hash.
14703 (MemberCache.SetupCache): Rename back from DeepCopy.
14704 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14705 already initialized. If we see an override function, add its
14706 underlying base virtual function to the member_hash too.
14708 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14710 2005-03-26 Raja R Harinath <harinath@acm.org>
14713 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14714 fails to resolve, ensure that the LHS is still resolved as an
14717 2005-03-25 Raja R Harinath <harinath@acm.org>
14719 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14721 (Enum.current_ec): Remove.
14722 (Enum.LookupEnumValue): Remove EmitContext argument.
14723 Just uses the one created during DefineType.
14724 (Enum.FindMembers): Update.
14725 * expression.cs (MemberAccess.DoResolve): Update.
14727 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14729 * assign.cs (Assign.DoResolve): Check for CS1717 when
14730 source and target are same (uses Equals).
14732 * expression.cs (LocalVariableReference, ParameterReference,
14733 This): Implemented Equals, GetHashCode.
14735 * statement.cs (Block.GetParameterReference): Removed useless
14738 2005-03-22 Raja R Harinath <rharinath@novell.com>
14741 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14742 blocks before deciding whether the error is cs0136 or cs0128.
14744 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14745 (using_alias_directive, using_namespace_directive): Pass
14746 MemberName, not an expression to Namespace.UsingAlias and
14748 (MakeName): Use the MemberName of the namespace.
14749 * namespace.cs (Namespace.MemberName): New.
14750 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14751 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14753 * decl.cs (MemberName.Name): Make readonly.
14754 (MemberName.FromDotted): New "constructor".
14755 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14756 (MemberCore.Name): Compute from MemberName on demand.
14757 (MemberCore.SetMemberName): Provide a way to change the
14759 (MemberCore.AddToContainer): Don't take a fullname parameter.
14760 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14761 fully qualified name of the container to the member name.
14762 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14763 only if the type is a member of the root container.
14764 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14765 MemberName.Left rather than searching for an embedded ".".
14766 (PartialContainer.CreatePart): Update to changes in RootContext.
14767 (MemberBase.ShortName): Turn into a property. Use
14768 MemberCore.SetMemberName.
14769 (MemberBase.ExplicitInterfaceName): Remove.
14770 (MemberBase.UpdateMemberName): Remove.
14771 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14772 (PropertyBase.SetMemberName): New override.
14773 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14774 (Tree.GetDecl): New.
14775 (Tree.AllDecls): Rename from Decls.
14776 * attribute.cs, enum.cs, report.cs: Update to changes.
14777 * driver.cs (MainDriver): Use MemberName.FromDotted on
14778 RootContext.MainClass.
14780 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14782 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14785 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14787 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14789 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14790 property accessor modifiers.
14792 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14793 fixed buffer attribute (CS1716).
14794 (PropertyMethod.HasCustomAccessModifier): When property accessor
14795 has custom modifier.
14797 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14799 (PropertyExpr.DoResolveLValue): Add CS0272.
14801 2005-03-17 Miguel de Icaza <miguel@novell.com>
14803 * convert.cs: When converting to a pointer, use the proper Conv.U
14804 or Conv.I depending on the source data type.
14806 * cs-tokenizer.cs: Make the size for large decimal constants,
14809 2005-03-17 Martin Baulig <martin@ximian.com>
14811 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14812 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14814 2005-03-17 Martin Baulig <martin@ximian.com>
14816 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14817 to bool so we can return an error condition.
14818 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14821 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14823 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14826 2005-03-16 Raja R Harinath <rharinath@novell.com>
14828 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14829 Refactor to avoid traversing the list of assemblies, and to avoid
14830 string concatenation.
14831 * typemanager.cs (guid_attr_type): Remove.
14832 (negative_hits, pointers, references): Remove hashes.
14834 (GetConstructedType): New. Uses type_hash to handle constructed
14835 types (arrays, references, pointers).
14836 (GetReferenceType, GetPointerType): Use it.
14837 (GetNestedType): New. Uses type_hash to handle nested types of
14839 (LookupType, LookupTypeDirect): Remove.
14840 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14841 'types' hash and LookupTypeReflection directly.
14842 (params_string, params_object): Use GetConstructedType.
14843 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14845 (Namespace.Lookup): Use cached_types.
14846 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14847 provided by old TypeManager.LookupType.
14848 * rootcontext.cs (MakeFQN): Remove.
14849 * decl.cs (DeclSpace.MakeFQN): Likewise.
14850 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14851 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14852 TypeManager.GetConstructedType.
14853 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14855 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14857 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14860 * cs-parser.jay: Reports CS1527 for any namespace element.
14862 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14865 * expression.cs (ParameterReference.IsAssigned): Changed error to
14867 (Error_WrongNumArguments): Moved CS0245 detection here.
14869 * statement.cs (Return.Resolve): Add CS1622 report.
14871 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14873 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14875 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14877 * attribute.cs expression.cs: Get rid of some allocations.
14879 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14881 * doc.cs : just eliminate the latest change.
14883 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14885 * doc.cs : commented out the latest change. It breaks xml-030.cs
14887 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14889 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14890 fail. So invoke CreateType() in FindDocumentedType().
14892 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14894 * cs-tokenizer.cs : added IsKeyword().
14895 * doc.cs : Detect keyword incorrectly used as identifier.
14896 Allow identifiers prefixed by @.
14898 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14900 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14901 It caused exception in namespace resolving (again!).
14903 * class.cs (Class.ctor): Removed exit.
14904 (PropertyMethod.ctor): ditto.
14906 * codegen.cs (Codegen.Reset): Reset static data.
14907 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14909 * cs-tokenizer.cs (Cleanup): Removed.
14911 * driver.cs (GetSystemDir): Rewrote to one line command.
14912 It caused problem with unloaded dynamic modules.
14913 (UnixParseOption): Removed Exit.
14914 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14915 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14916 Now can be mcs used as library.
14918 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14921 * location.cs (Reset): Reset static data.
14923 * namespace.cs (Reset): Reset static data.
14925 * report.cs (Report.Reset): Reset static data.
14927 * rootcontext.cs (RootContext.Reset): Reset static data.
14929 * tree.cs (RootTypes.ctor): Use Location.Null
14931 * typemanager.cs (TypeManager.Reset): Reset static data.
14932 (CoreLookupType): Removed Exit.
14933 (TypeHandle.Reset): Reset static data.
14935 2005-03-10 Raja R Harinath <rharinath@novell.com>
14938 * typemanager.cs (ComputeNamespaces): Import namespaces from
14939 referenced modules too.
14941 2005-03-09 Raja R Harinath <rharinath@novell.com>
14943 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14946 2005-03-09 Raja R Harinath <rharinath@novell.com>
14948 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14949 enclosing DeclSpace. This ensures that a name-lookup populates
14950 more caches and there are fewer 'TypeExpression's. Carve out
14951 nested type lookup into ...
14952 (LookupNestedTypeInHierarchy): ... this.
14954 2005-03-09 Raja R Harinath <rharinath@novell.com>
14956 Clean up a few partial-class semantics.
14957 Fixes test-357.cs and cs1618-2.cs.
14958 * cs-parser.jay (struct_declaration): Use 'current_class' as
14959 parent of newly-created struct. Remove call to Register ().
14960 Use 'pop_current_class' to complete handing the current struct.
14961 (interface_declaration): Likewise.
14962 (class_declaration): Likewise.
14963 (enum_declaration): Use 'current_class' as parent of newly created
14965 (delegate_declaration): Likewise.
14966 (pop_current_class): New function. This is used to handle closing
14967 up the 'current_class' and 'current_container', and pointing them
14968 to the enclosing class/container.
14969 (CSharpParser): Initialize 'current_class' too.
14970 * decl.cs (MemberCore): Add check for invariant: a partial
14971 container is not a parsed entity, and thus does not enclose any
14973 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14974 (DeclSpace.BaseTypeExpr): Use it.
14975 (DeclSpace.LookupType): Add check for invariant.
14976 * class.cs (TypeContainer): Add check for invariant: a nested
14977 class should have the same NamespaceEntry as its enclosing class.
14978 (TypeContainer.EmitFieldInitializers): Make virtual.
14979 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14981 (TypeContainer.Register): Remove.
14982 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14983 null. Use TypeResolveEmitContext for resolving base types and
14984 interfaces. Move initialization of Parts.TypeBuilder here from
14986 (TypeContainer.DefineNestedTypes): ... here.
14987 (PartialContainer): Take a Namespace not a NamespaceEntry.
14988 (PartialContainer.Create): Don't use Register. Call the
14989 appropriate Add... function directly.
14990 (ClassPart): Take both the PartialContainer and the enclosing
14991 class as constructor arguments.
14992 (ClassPart.EmitFieldInitializers): Override.
14993 (ClassPart.PartFindNestedTypes): Remove.
14994 (FieldBase.GetInitializerExpression): Resolve the initializer
14995 expression in the emit context of the enclosing class.
14996 * tree.cs (RootTypes): Remove Register ().
14998 2005-03-08 Marek Safar <marek.safar@seznam.cz>
15000 * cs-parser.jay: Removed CS0134.
15002 * driver.cs: Removed CS1901.
15004 * expression.cs (SizeOf.DoResolve): Don't report CS0233
15005 for predefined types.
15007 2005-03-07 Duncan Mak <duncan@novell.com>
15009 * codegen.cs (Save): Catch UnauthorizedAccessException as
15010 well. Fixes bug #73454.
15012 2005-03-07 Marek Safar <marek.safar@seznam.cz>
15014 * cs-tokenizer.cs (xtoken): Add CS1035.
15016 * class.cs (MethodData.Define): Add CS0683.
15017 (FieldMember.ctor): Add CS0681.
15019 2005-03-07 Raja R Harinath <rharinath@novell.com>
15021 * ecore.cs (SimpleName.DoResolve): Rename from
15022 SimpleName.DoResolveAllowStatic.
15023 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
15024 Pass 'intermediate' flag to MemberStaticCheck.
15025 (SimpleName.MemberStaticCheck): Skip "static check" only in case
15026 of "intermediate" lookups via MemberAccess.
15027 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
15028 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
15030 2005-03-07 Raja R Harinath <rharinath@novell.com>
15033 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
15034 slipped in because of variable names that are identical to a
15035 builtin type's BCL equivalent ('string String;', 'int Int32;').
15036 (PropertyExpr.EmitInstance): Likewise.
15038 2005-03-04 Marek Safar <marek.safar@seznam.cz>
15040 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
15042 * report.cs (warning_ignore_table): Made public.
15044 2005-03-04 Raja R Harinath <rharinath@novell.com>
15047 * class.cs (MethodData.Emit): Pass 'container' to
15048 container.GetObsoleteAttribute instead of 'container.Parent'.
15050 2005-03-03 Marek Safar <marek.safar@seznam.cz>
15052 * cs-parser.jay: Add 1534 error test.
15054 * iterators.cs (Yield.CheckContext): Add error 1629.
15055 (Iterator.ctor): Save unsafe modifier.
15056 (MoveNextMethod.DoEmit): Restore unsafe context.
15058 * namespace.cs (UsingAlias): Better error message.
15060 2005-03-03 Dan Winship <danw@novell.com>
15062 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
15063 the warning message [#73219]
15065 2005-03-03 Raja R Harinath <rharinath@novell.com>
15067 Fix compile with MCS 1.0.0.0.
15068 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
15069 w_restore to not depend on string constant folding.
15071 2005-03-03 Raja R Harinath <rharinath@novell.com>
15073 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
15074 CS0246 check to users who passed 'silent = false'.
15075 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
15077 (SimpleName.SimpleNameResolve): Update.
15078 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
15079 (MemberAccess.IdenticalNameAndTypeName): Update.
15080 * doc.cs (FindDocumentedTypeNonArray): Update.
15082 2005-03-03 Raja R Harinath <rharinath@novell.com>
15084 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
15085 * parameters.cs (ComputeAndDefineParameters): Remove.
15086 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
15087 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
15088 Use GetParameterInfo.
15090 2005-03-02 Marek Safar <marek.safar@seznam.cz>
15092 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
15094 2005-03-02 Raja R Harinath <rharinath@novell.com>
15096 Unify DeclSpace.LookupType and DeclSpace.FindType.
15097 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
15098 is in charge of defining nested types on demand.
15099 (DeclSpace.LookupType): Use it when the current_type is a
15100 TypeBuilder. Use LookupTypeDirect for reflected types.
15101 (DeclSpace.FindType): Remove.
15102 (DeclSpace.LookupInterfaceOrClass): Likewise.
15103 (DeclSpace.DefineTypeAndParents): Likewise.
15104 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
15105 DeclSpace.LookupType.
15106 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
15107 * typemanager.cs (LookupType): Simplify.
15108 (AddUserType): Remove type from negative_hits.
15109 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
15110 * class.cs (TypeContainer.FindMembers): Move handling of nested
15112 (TypeContainer.FindMembers_NestedTypes): ... here.
15113 (TypeContainer.FindNestedType): Implement override.
15114 (ClassPart.FindNestedType): Delegate to PartialContainer.
15115 (ClassPart.PartFindNestedType): Looks up the nested types of the
15118 2005-03-02 Martin Baulig <martin@ximian.com>
15120 * class.cs (TypeContainer.DoDefineMembers): We also need a default
15121 static constructor in static classes.
15123 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
15125 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
15126 sizeParamIndex is not specified.
15128 2005-03-01 Marek Safar <marek.safar@seznam.cz>
15131 * report.cs (WarningMessage.IsEnabled): Missing null check.
15133 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15135 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
15136 in the fields and not in the properties.
15138 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
15140 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
15143 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15145 * attribute.cs: Small refactoring (improved robustness).
15146 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
15147 (ValidateGuid): Removed.
15148 (Resolve): Removed referenced to above mentioned.
15149 (GetAttributeUsage): Made private and changed to work without
15151 (GetIndexerAttributeValue): Don't crash.
15152 (GetConditionalAttributeValue): Ditto.
15153 (GetClsCompliantAttributeValue): Ditto.
15154 (ExtractSecurityPermissionSet): All attributes exceptions are
15156 (GetPropertyValue): New helper.
15157 (GetMethodImplOptions): New method.
15158 (DefinePInvokeMethod): Reuse common code. Implemented handling of
15159 some missing properties.
15161 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
15162 (Method.ApplyAttributeBuilder): Updated.
15164 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
15167 2005-02-28 Raja R Harinath <rharinath@novell.com>
15170 * report.cs (Report.SymbolRelatedToPreviousError): Handle
15171 non-simple types (array, pointer, reference).
15173 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15175 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
15177 * class.cs (MethodCore.IsDuplicateImplementation): Special error
15179 (Method.CheckBase): Catch wrong destructor here.
15180 (MethodData.Define): Add errors 550, 668.
15182 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
15184 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
15186 * pending.cs (VerifyPendingMethods): Add error 551.
15188 * typemanager.cs (CSharpName): Next error report helper.
15190 2005-02-25 Marek Safar <marek.safar@seznam.cz>
15192 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
15193 attributes. Removed useless attribute double check.
15194 It saves almost 2MBs for corlib.
15196 2005-02-25 Raja R Harinath <rharinath@novell.com>
15199 * statement.cs (ExpressionStatement.Resolve): Make robust to being
15200 called twice in case of error.
15202 2005-02-23 Chris Toshok <toshok@ximian.com>
15204 Fix compiler portions of #72827.
15205 * statement.cs (Block.Emit): call Begin/EndScope on the
15206 EmitContext instead of the ILGenerator.
15208 * codegen.cs (EmitContext.BeginScope): new method, call
15209 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
15211 (EmitContext.BeginScope): same, but EndScope and CloseScope
15213 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
15214 offset and call the superclass's OpenScope(int) with it.
15215 (SymbolWriter.CloseScope): get the current il
15216 offset and call superclass's CloseScope(int) with it.
15218 2005-02-23 Marek Safar <marek.safar@seznam.cz>
15220 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
15221 CS1677 for out and ref as well.
15223 * class.cs (Method.Define): Add error CS1599 detection.
15225 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
15227 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
15229 * delegate.cs (Delegate.Define): Add error CS1599 detection.
15231 * support.cs.cs (ModifierDesc): New helper method.
15233 2005-02-23 Raja R Harinath <rharinath@novell.com>
15234 Abin Thomas <projectmonokochi@rediffmail.com>
15235 Anoob V E <projectmonokochi@rediffmail.com>
15236 Harilal P R <projectmonokochi@rediffmail.com>
15238 Fix #57851, #72718.
15239 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
15240 MemberLookup (used for error reporting) actually returns a result.
15241 Fix error report number (122, not 112).
15243 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
15244 Anoob V E <projectmonokochi@rediffmail.com>
15245 Harilal P R <projectmonokochi@rediffmail.com>
15248 * pending.cs (PendingImplementation.GetAbstractMethods):
15249 Find NonPublic members too.
15251 2005-02-22 Marek Safar <marek.safar@seznam.cz>
15253 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
15256 * class.cs (MethodCore.CheckMethodAgainstBase):
15257 Add error 239 report.
15259 2005-02-21 Raja R Harinath <rharinath@novell.com>
15262 * expression.cs (Invocation.IsApplicable): Make public.
15263 (Invocation.IsParamsMethodApplicable): Likewise.
15264 * delegate.cs (Delegate.VerifyApplicability): Don't use
15265 Invocation.VerifyArgumentCompat for parameter applicability
15266 testing. Use Invocation.IsApplicable and
15267 Invocation.IsParamsMethodApplicable.
15269 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15271 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
15273 * class.cs (Operator.Define): Add error 217 report.
15275 2005-02-21 Raja R Harinath <rharinath@novell.com>
15277 * namespace.cs (UsingEntry.Resolve): Undo change below.
15279 2005-02-21 Raja R Harinath <rharinath@novell.com>
15282 * ecore.cs (Expression.MemberLookupFailed): Add argument to
15283 disable the error message when the extended MemberLookup also
15285 (Expression.MemberLookupFinal): Update.
15286 (SimpleName.DoSimpleNameResolve): Update.
15287 * expression.cs (MemberAccess.ResolveNamespaceOrType):
15288 Don't use MemberLookupFinal.
15289 (New.DoResolve): Update.
15290 (BaseAccess.CommonResolve): Update.
15292 2005-02-21 Raja R Harinath <rharinath@novell.com>
15295 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
15296 occured previously, don't resolve again.
15298 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15301 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
15302 argument. Call ResolveAttributeUsage for unresolved.
15303 when types doesn't match ctor arguments.
15305 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
15306 for nested attribute classes.
15307 (Class.attribute_usage): Removed.
15308 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
15309 for attribute class.
15311 * ecore.cs (IsAttribute): Removed.
15313 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15315 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15317 (attribute_types): Removed.
15318 (EmitCode): Global attributes are emited as the latest.
15320 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15322 * class.cs (EmitFieldInitializers): Don't emit field initializer
15323 for default values when optimilization is on.
15325 * constant.cs (Constant.IsDefaultValue): New property.
15327 * driver.cs: Add /optimize handling.
15331 * literal.cs: Implement new IsDefaultValue property.
15333 * rootcontext.cs (Optimize): New field, holds /optimize option.
15335 2005-02-18 Raja R Harinath <rharinath@novell.com>
15337 Fix crasher in re-opened #72347.
15338 * namespace.cs (Namespace.Lookup): Return null if
15339 DeclSpace.DefineType returns null.
15342 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15344 2005-02-18 Raja R Harinath <rharinath@novell.com>
15346 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15347 now returns null if it cannot resolve to an lvalue.
15348 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15349 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15350 returned null. Remove check for SimpleName.
15351 (EventExpr.DoResolveLValue): New.
15352 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15353 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15355 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15356 avoid CS0131 error.
15357 (Unary.ResolveOperator): Move CS0211 check ...
15358 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15360 (Unary.DoResolveLValue): Simplify.
15361 (AddressOf.DoResolveLValue): New.
15362 (ArrayAccess.DoResolveLValue): New.
15364 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15366 * attribute.cs (Attribute.Resolve): Add arguments casting for
15367 when types doesn't match ctor arguments.
15369 2005-02-16 Raja R Harinath <rharinath@novell.com>
15371 Fix parts of #63202.
15372 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15373 lookup of operator in base type. Ensure that all checks happen
15374 when the operator resolves to an "op_..." method.
15376 2005-02-15 Raja R Harinath <rharinath@novell.com>
15379 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15380 'ignore_cs0104' parameter. Pass it to ...
15381 (NamespaceEntry.Lookup): ... this.
15382 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15383 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15384 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15385 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15386 Update. Request that cs0104 errors be ignored.
15387 (ComposedCast.ResolveAsTypeStep): Update.
15389 2005-02-14 Raja R Harinath <rharinath@novell.com>
15392 * expression.cs (Invocation.BetterFunction): Remove support for
15393 comparing virtual functions and their overrides.
15394 (Invocation.IsOverride): New.
15395 (Invocation.OverloadResolve): Don't consider 'override' functions
15396 during candidate selection. Store them in a lookaside list.
15397 If the selected method is a 'virtual' function, use the list to
15398 find any overrides that are closer to the LHS type.
15400 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15402 * expression.cs (New.DoResolve): Add complex core type reduction.
15403 (New.Constantify): Converts complex core type syntax like 'new int ()'
15404 to simple constant.
15406 2005-02-14 Raja R Harinath <rharinath@novell.com>
15408 * decl.cs (EntryType.EntryType): New constructor to create an
15409 updated copy of a cache entry.
15410 (MemberCache.AddMethods): Use it.
15411 (MemberCache.ClearDeclaredOnly): Remove.
15412 (MemberCache.MemberCache): Update.
15414 2005-02-11 Miguel de Icaza <miguel@novell.com>
15416 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15417 variable. This one is represents the actual low-level declaration
15418 of the method, as opposed to the semantic level `IsStatic'.
15420 An anonymous method which is hosted into a static method might be
15421 actually an instance method. IsStatic would reflect the
15422 container, while MethodIsStatic represents the actual code
15425 * expression.cs (ParameterReference): Use the new MethodIsStatic
15426 instead of IsStatic.
15428 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15429 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15430 set on the current EmitContext.
15432 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15433 resolve our casted expression as an LValue. This triggers the
15434 proper LValue processing that is later required by Assign.
15438 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15440 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15442 C# 2.0 Fixed buffer implementation
15444 * anonymous.cs: Update after RegisterHelperClass renaming.
15446 * attribute.cs (AttributeTester.fixed_buffer_cache):
15447 Cache of external fixed buffers.
15448 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15449 implementation if field is fixed buffer else null.
15452 (TypeContainer.AddField): Accept FieldMember instead of Field.
15453 (FieldBase.IsFieldClsCompliant): Extracted code from
15454 VerifyClsCompliance descendant customization.
15455 (FixedField): New class handles fixed buffer fields.
15456 (FixedFieldExternal): Keeps information about imported fixed
15458 (IFixedField): Make access to internal or external fixed buffer
15461 * cs-parser.jay: Add fixed buffer parsing.
15463 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15466 * expression.cs (Indirection): Extended implementation to accept
15467 fixed buffer field.
15468 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15469 (ElementAccess.MakePointerAccess): Get type as parameter.
15470 (DoResolve): Add fixed buffer field expression conversion.
15471 (DoResolveLValue): Ditto.
15472 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15473 (ArrayPtr): Derives from FixedBufferPtr.
15474 (ArrayPtr.Emit): Add extra emit for array elements.
15476 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15478 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15479 for compiler generated types.
15480 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15482 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15483 and consume less memory.
15484 (Fixed.Resolve): Add fixed buffer case.
15486 * typemanager.cs (compiler_generated_attr_ctor,
15487 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15488 (HasElementType): Add our own implementation to work on every
15491 2005-02-11 Miguel de Icaza <miguel@novell.com>
15493 * anonymous.cs (CaptureContext): Track whether `this' has been
15496 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15497 only captured `this' if it was implicitly done (instance
15498 methods/variables were used).
15500 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15501 `this' must be captured.
15503 2005-01-30 Miguel de Icaza <miguel@novell.com>
15505 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15506 is null it means that there has been no need to capture anything,
15507 so we just create a sibling.
15509 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15511 Just a partial fix. The other half is fairly elusive.
15513 2005-02-10 Raja R Harinath <rharinath@novell.com>
15515 Fix #52586, cs0121-4.cs.
15516 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15517 and return a hashtable.
15518 (MemberCache.ClearDeclaredOnly): New.
15519 (MemberCache.MemberCache): Update to change. Make a deep copy of
15520 the method_hash of a base type too.
15521 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15522 type methods. Overwrite entries with the same MethodHandle so
15523 that the ReflectedType is correct. The process leaves in base
15524 virtual functions and their overrides as distinct entries.
15525 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15526 matters since it was boxed in a ArrayList before.
15527 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15529 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15530 case of a virtual function and its override (choose the overload
15532 (Invocation.OverloadResolve): Avoid 'override' members during
15533 'applicable_type' calculation.
15535 2005-02-09 Raja R Harinath <rharinath@novell.com>
15537 Combine two near-redundant caches.
15538 * typemanager.cs (method_params): Rename from method_internal_params.
15539 (TypeManager.GetParameterData): New. Replace
15540 Invocation.GetParameterData.
15541 (TypeManager.LookupParametersByBuilder): Remove.
15542 * expression.cs (Invocation.method_parameter_cache): Remove.
15543 (Invocation.GetParameterData): Remove.
15545 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15548 2005-02-08 Raja R Harinath <rharinath@novell.com>
15551 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15552 TypeManager.multicast_delegate_type is null, resolve it by looking
15553 up "System.MulticastDelegate".
15554 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15556 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15557 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15558 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15561 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15562 (LabeledStatement.AddReference): New. Set 'referenced'.
15563 (Goto.Resolve): Use it.
15565 2005-02-05 John Luke <john.luke@gmail.com>
15567 * driver.cs: remove duplicate -doc line in Usage ()
15569 2005-02-04 Raja R Harinath <rharinath@novell.com>
15571 * location.cs (Location.AddFile): Fix CS2002 error report.
15573 2005-02-02 Martin Baulig <martin@ximian.com>
15575 * delegate.cs (Delegate.DefineType): Report an internal error if
15576 TypeManager.multicast_delegate_type is null. See bug #72015 for
15579 2005-02-02 Raja R Harinath <rharinath@novell.com>
15581 Fix a crasher in a variant of #31984.
15582 * const.cs (Constant.CheckBase): New override that defers the
15583 new-or-override check in case the base type hasn't been populated
15585 (Constant.Define): Ensure the new-or-override check is performed.
15587 2005-02-01 Duncan Mak <duncan@ximian.com>
15589 * const.cs (LookupConstantValue): Check that `ce' is not null
15590 before calling GetValue ().
15592 2005-02-01 Raja R Harinath <rharinath@novell.com>
15594 Fix test-334.cs (#69519).
15595 * cs-parser.jay (using_alias_directive): Pass in an expression to
15596 NamespaceEntry.UsingAlias.
15597 (using_namespace_directive): Pass in an expression to
15598 NamespaceEntry.Using.
15599 (namespace_name): Don't flatten to a string.
15600 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15601 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15603 (NamespaceEntry.UsingEntry): Likewise.
15604 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15606 (NamespaceEntry.LookupForUsing): Remove.
15607 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15609 (NamespaceEntry.Lookup): Remove support for dotted names.
15611 2005-02-01 Raja R Harinath <rharinath@novell.com>
15613 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15615 (NamespaceEntry.ImplicitParent): Compute on demand.
15616 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15617 parallels the current.
15618 (NamespaceEntry.LookupForUsing): Use it.
15619 (NamespaceEntry.Lookup): If the current namespace-entry is
15620 implicit, don't search aliases and using tables.
15622 2005-02-01 Raja R Harinath <rharinath@novell.com>
15625 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15627 (TypeContainer.BaseCache): Compute on demand.
15628 (TypeContainer.FindMembers): Define constants and types if they're
15629 not already created.
15630 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15632 * const.cs (Constant.Define): Make idempotent.
15634 2005-01-29 Miguel de Icaza <miguel@novell.com>
15636 * pending.cs: Produce better code (no nops produced by using Ldarg
15639 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15640 i - 1' it should be arg + 1.
15644 2005-01-28 Raja R Harinath <rharinath@novell.com>
15646 * attribute.cs (Attribute.CheckAttributeType): Make private
15648 (Attribute.ResolveType): Make virtual.
15649 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15650 handling of RootContext.Tree.Types.
15652 2005-01-27 Raja R Harinath <rharinath@novell.com>
15654 Update attribute-handling to use the SimpleName/MemberAccess
15656 * cs-parser.jay (attribute): Pass in an expression to the
15657 constructors of Attribute and GlobalAttribute.
15658 * attribute.cs (Attribute): Take an expression for the name.
15659 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15660 passed in attribute name expression.
15661 (Attribute.CheckAttributeType): Use it.
15662 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15663 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15664 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15665 argument to prevent error messages if the lookup fails.
15667 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15669 * expression.cs (Indirection): Implemented IVariable interface
15670 to support indirection in AddressOf operator.
15671 (PointerArithmetic.Emit): Add optimalization for case where
15672 result can be precomputed.
15674 2005-01-26 Martin Baulig <martin@ximian.com>
15676 * class.cs (TypeContainer.AttributeTargets): Return the correct
15677 AttributeTargets depending on our `Kind' instead of throwing an
15678 exception; fixes #71632.
15680 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15683 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15686 2005-01-25 Raja R Harinath <rharinath@novell.com>
15689 * expression.cs (MemberAccess.DoResolve): Don't complain with
15690 cs0572 when the LHS of a member access has identical name and type
15693 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15696 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15698 Create custom PermissionSet only for PermissionSetAttribute.
15700 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15703 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15704 delegates in static class.
15706 2005-01-24 Martin Baulig <martin@ximian.com>
15708 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15709 merging an implicit block, just use its reachability.
15711 * statement.cs (Block.Resolve): Make the unreachable code check
15712 work wrt. implicit blocks; see test-337 from #63842.
15714 2005-01-21 Alp Toker <alp@atoker.com>
15716 * cs-parser.jay: destructor_declaration's container is PartialContainer
15717 not Class when partial types are used, so use Kind prop instead of
15720 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15722 * cs-parser.jay: Improve error reporting when an interface
15723 declares new types.
15725 2005-01-20 Dick Porter <dick@ximian.com>
15727 * support.cs: SeekableStreamReader fix from Sandor Dobos
15728 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15729 chars are read. Fixes bug 70369.
15731 2005-01-20 Raja R Harinath <rharinath@novell.com>
15733 * cs-parser.jay (catch_clause): Simplify current_block handling
15736 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15738 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15739 code with ImplicitStandardConversion to handle the implicit
15740 conversion of method groups into valid delegate invocations.
15742 The problem is that in parameter handling we were using this code
15743 path. Fixes bug #64698
15745 2005-01-19 Raja R Harinath <rharinath@novell.com>
15747 * cs-parser.jay: Fix several infelicities.
15748 - Avoid assigning to the parser value stack. Code like
15749 '$3 = null' is unclean. Synthesize a value for the code block
15751 - Avoid using oob_stack for storing location information. Use ...
15752 (_mark_): ... this. New (empty) rule. Saves the current location
15754 (foreach_statement): Avoid using oob_stack for current_block
15755 handling. Use technique used in for_statement and
15756 using_statement. Synthesize a value for the code block to store
15757 additional intermediate information.
15759 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15761 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15762 of a different type is only allowed to private fields of a
15763 containing type, not on fields of a base class.
15765 See test-174.cs and error cs0122-9.cs
15767 2005-01-13 Raja R Harinath <rharinath@novell.com>
15769 Fix test-335.cs (bug #58126).
15770 * cs-parser.jay (argument): Split out non-expression parts of the
15771 rule into 'non_simple_argument'.
15772 (invocation_expression): Support parenthesized invocations with
15773 multiple arguments, and with single non-simple arguments.
15775 2005-01-13 Raja R Harinath <rharinath@novell.com>
15777 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15780 2005-01-12 Raja R Harinath <rharinath@novell.com>
15782 Fix cs0038-1.cs, cs1640-6.cs.
15783 * ecore.cs (Expression.Resolve): Remove special-case for
15784 SimpleName in error-handling.
15785 (Expression.almostMatchedMembers): Relax access permission to
15787 (Expression.MemberLookupFailed): Handle duplicates in
15788 almostMatchedMembers list.
15789 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15790 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15791 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15792 overload if the passed in MemberInfo is a MethodBase.
15794 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15797 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15798 for non-CAS & merge permission sets properly.
15800 2005-01-11 Raja R Harinath <rharinath@novell.com>
15802 Improve standard-compliance of simple name and member access
15803 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15804 * ecore.cs (FullNamedExpression): New abstract base class
15805 for Namespaces and TypeExpressions.
15806 (ResolveFlags.SimpleName): Remove.
15807 (SimpleName): Remove support for dotted names.
15808 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15809 DeclSpace.FindType and DeclSpace.LookupType.
15810 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15811 (Expression.ExprClassName): Make member function.
15812 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15813 a namespace. Remove creation of dotted "SimpleName"s.
15814 (MemberAccess.DoResolve): Likewise.
15815 * decl.cs (DeclSpace.Cache): Make private.
15816 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15817 (DeclSpace.FindType): Update.
15818 (DeclSpace.LookupType): Move here from RootContext. Return a
15819 FullNamedExpression.
15820 * namespace.cs (Namespace): Derive from FullNamedExpression
15821 so that it can be part of expression resolution.
15822 (Namespace.Lookup): Return an FullNamedExpression.
15823 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15825 * rootcontext.cs (NamespaceLookup): Remove.
15826 (LookupType): Move to DeclSpace.
15827 * attribute.cs (CheckAttributeType): Update.
15828 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15829 (FindDocumentedTypeNonArray): Likewise.
15831 2005-01-11 Raja R Harinath <rharinath@novell.com>
15833 Fix cs0509.cs, cs1632.cs.
15834 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15835 is the same as IsInterface.
15836 (TypeContainer.GetClassBases): Likewise.
15837 * statement.cs (LabeledStatement.ig): New field.
15838 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15840 (LabeledStatement.DoEmit): Check that the label was created with
15841 the same ILGenerator.
15843 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15846 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15847 accessors to its properties.
15849 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15850 from accessors to property.
15852 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15855 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15856 only for overrides.
15858 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15860 * attribute.cs: Check for null and empty strings.
15862 I have lost another battle to Paolo.
15864 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15867 * class.cs (PropertyMethod): Set Parent field in ctors.
15868 (SetMethod.InternalParameters): Add unsafe switch hack.
15869 Override MarkForDuplicationCheck where it is appropriate.
15871 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15872 It says whether container allows members with the same name.
15873 Base default is no.
15874 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15875 Removed is_method parameter.
15877 2005-01-06 Duncan Mak <duncan@ximian.com>
15879 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15880 because the previous change led to incorrect reporting of CS1032
15881 ("Cannot define/undefine preprocessor symbols after first token in
15882 file"). Instead of using `tokens_seen' as the only flag that
15883 triggers CS1040, introduce `comments_seen'. This new flag is used
15884 to signify having seen comments on the current line, so it is
15885 unset after a newline.
15887 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15889 * doc.cs : When searching for a type, find nested type too.
15890 This fixes bug #71040.
15892 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15895 - Warn missing member comment on those classes which also does not
15896 have doc comments. Fixed bug #71041.
15897 - Don't warn missing doc comment on default constructor.
15900 2005-01-06 Duncan Mak <duncan@ximian.com>
15902 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15903 comments, set `tokens_seen' to true. This allows us to detect
15904 misplaced preprocessor directives (i.e. not at the beginning of
15905 the a line, nor after whitespaces). In that case, report error
15906 CS1040. This fixes bug #56460.
15908 * cs-parser.jay (interface_member_declaration): Add checks for
15909 IsExplicitImpl, and report CS0541 error if an interface member is
15910 defined as an explicit interface declaration.
15912 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15915 * class.cs (PropertyMethod): Set Parent field in ctors.
15916 (SetMethod.InternalParameters): Add unsafe switch hack.
15918 * decl.cs (MemberCore.Parent): Cannot be readonly.
15920 2005-01-06 Raja R Harinath <rharinath@novell.com>
15922 * decl.cs (DeclSpace.ResolveType): Remove.
15923 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15924 Merge in code from ...
15925 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15926 * class.cs, enum.cs: Update to changes.
15928 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15930 * anonymous.cs: Ensure that we init the scope of our parent if it
15931 has not been initialized yet.
15933 2004-12-30 Duncan Mak <duncan@ximian.com>
15935 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15936 if field.FieldBuilder is null. Fixes #70758.
15938 * convert.cs: Fixed some typos and updated some of the comments.
15939 (ImplicitStandardConversionExists):
15940 (TryImplicitIntConversion): If `target_type' is an interface and
15941 the type of `ic' implements this interface, return true or a new
15942 BoxedCast instead of null. This fixes #70468.
15944 2004-12-29 Duncan Mak <duncan@ximian.com>
15946 * expression.cs (Argument.Emit): Check that Expr is
15947 IMemoryLocation before casting to it, and report CS1510 otherwise.
15951 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15953 * statement.cs (Block.ThisVariable): remove the recursion here, to
15954 make the --profile more sane.
15956 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15958 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15959 assembly, by JB Evain.
15961 2004-12-17 Raja R Harinath <rharinath@novell.com>
15963 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15964 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15965 "parent" refers to enclosing type/class. "base" refers to superclass.
15967 2004-12-17 Raja R Harinath <rharinath@novell.com>
15969 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15970 Ensure that we only have GlobalAttributes.
15971 * attribute.cs (Attribute.Emit): Make non-virtual.
15972 (GlobalAttribute.Emit): Remove.
15973 (Attribute.Resolve): Make virtual.
15974 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15975 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15976 the argument. Don't create one.
15977 (Attribute.GetObsoleteAttribute): Likewise.
15978 (Attribute.GetClsCompliantAttributeValue): Likewise.
15979 * class.cs, decl.cs: Update to changes.
15981 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15983 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15985 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15987 * statement.cs (Foreach.Resolve): Add error 186 report.
15989 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15991 * expression.cs (Conditional.DoResolve): Add warning 429.
15993 * statement.cs (If.Resolve): Add warning 665.
15995 2004-12-16 Raja R Harinath <rharinath@novell.com>
15997 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15998 except when in the parser, and in GlobalAttribute.
15999 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
16000 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
16001 RootContext.Tree.Types.NamespaceEntry once work is done.
16002 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
16003 and resets RootContext.Tree.Types.NamespaceEntry.
16005 2004-12-15 Marek Safar <marek.safar@seznam.cz>
16007 * cs-parser.jay: Don't create a block for every variable.
16009 2004-12-14 Miguel de Icaza <miguel@ximian.com>
16011 * location.cs: Provide extra information.
16013 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
16014 variables from the captured environment, it is the ldarg_0.
16016 2004-12-14 Marek Safar <marek.safar@seznam.cz>
16018 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
16021 * class.cs: Changed warning level for 169 to avoid developer
16022 displeasure from warning flooding. It will be changed back when they
16023 fix most of current BCL warnings.
16025 * RootContext.cs: Pushed default WarningLevel to 3.
16027 * statement.cs: Removed unused variable.
16029 2004-12-14 Marek Safar <marek.safar@seznam.cz>
16031 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
16032 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
16033 Add error 502 report.
16034 (StaticClass.DefineType): Add error 441 report.
16035 (Class.AllowedModifiersProp): New virtual property as temporary
16036 extension to AllowedModifiers.
16037 (Class.DefineType): Add error 418 report. Moved ModFlags check here
16038 to share implementation with StaticClass and don't call virtual
16041 * driver.cs (MainDriver): Add error 1558 test.
16043 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
16044 report. Moved error 36 test here.
16046 * statement.cs (Throw.Resolve): Add error 724 report.
16048 * typemanager.cs: Add out_attribute_type core type.
16050 2004-12-13 Marek Safar <marek.safar@seznam.cz>
16052 * class.cs (TypeContainer.VerifyClsCompliance): Add error
16054 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
16056 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
16059 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
16061 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
16062 Add error 3023 report.
16063 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
16065 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
16068 2004-12-12 John Luke <john.luke@gmail.com>
16070 * driver.cs (AddArgs): take -- into account when
16071 adding arguments, fixes bug 65710
16073 2004-12-12 Martin Baulig <martin@ximian.com>
16075 * expression.cs (Unary.TryReduceNegative): Added support for
16076 SByteConstant and ByteConstant.
16077 (Unary.Reduce): Check error values from TryReduceNegative().
16079 2004-12-10 Marek Safar <marek.safar@seznam.cz>
16081 * attributes.cs (Attribute.Resolve): Avoid multiple error report
16082 and report exception as error 182.
16084 2004-12-10 Raja R Harinath <rharinath@novell.com>
16086 * driver.cs (Main): Fix message when there are warnings.
16088 2004-12-09 Miguel de Icaza <miguel@ximian.com>
16090 * delegate.cs: Fixed my fix from yesterday, sorry about that.
16092 2004-12-09 Marek Safar <marek.safar@seznam.cz>
16094 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
16095 Reduced number of warnings.
16097 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
16099 2004-12-08 Miguel de Icaza <miguel@ximian.com>
16101 * driver.cs: Removed message.
16103 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
16105 2004-12-08 <vargaz@freemail.hu>
16107 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
16109 2004-12-08 Martin Baulig <martin@ximian.com>
16111 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
16112 instead of a CS3002 for properties and indexer.
16114 2004-12-08 Martin Baulig <martin@ximian.com>
16116 * decl.cs (MemberName.ToString): Make this work again.
16118 2004-12-08 Marek Safar <marek.safar@seznam.cz>
16120 * attribute.cs (Resolve): Add error 591 detection.
16122 * class.cs (FieldMember.Define): Add error 1547 detection.
16123 (Indexer.Define): Add error 620 detection.
16124 (Operator.Define): Add error 590 detection.
16126 * ecore.cs: Missing argument for error 79.
16128 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
16131 2004-12-07 Marek Safar <marek.safar@seznam.cz>
16134 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
16137 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
16139 * cs-parser.jay : handle doc comments on implicit/explicit operators.
16140 Some operator comments were suppressed.
16141 * doc.cs : Implicit/explicit operator name in doc comments are like
16142 "op_Explicit(type)~returnType", so added suffix handling.
16144 2004-12-07 Martin Baulig <martin@ximian.com>
16147 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
16148 (MemberCore.GetClsCompliantAttributeValue): Likewise.
16149 (DeclSpace.ec): New protected field; store the EmitContext here.
16150 (DeclSpace.EmitContext): New public property; moved here from
16152 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
16155 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
16156 (Enum.Emit): Don't create a new EmitContext.
16158 * delegate.cs (Delegate.DefineType): Always create the
16161 * iterators.cs (Iterators.DefineIterator): Create a new
16162 EmitContext and store it in `ec'.
16164 2004-08-24 Martin Baulig <martin@ximian.com>
16167 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
16168 this for accessibility checks.
16169 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
16170 IsNestedFamilyAccessible.
16171 (TypeManager.IsSubclassOf): New method, do what the name actually
16174 2004-12-06 Raja R Harinath <rharinath@novell.com>
16176 Fix crash on cs0657-17.cs.
16177 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
16178 Use RootContext.Tree.Types, not 'new RootTypes ()'.
16179 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
16180 the case where the NamespaceEntry gets overwritten.
16182 2004-12-06 Marek Safar <marek.safar@seznam.cz>
16184 Fixed #69195, #56821
16185 * ecore.cs (ResolveBoolean): Tiny refactoring.
16187 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
16188 of right expression resolving when left is false constant and
16189 operator is LogicalAnd OR true constant and operator is LogicalOr.
16191 * statement.cs (ResolveUnreachable): Always reports warning.
16193 2004-12-05 Miguel de Icaza <miguel@ximian.com>
16195 * class.cs: Distinguish between 1721 and 1722 (just a little help
16196 for the programmer).
16198 2004-12-03 Miguel de Icaza <miguel@ximian.com>
16200 * delegate.cs: Only allow this on new versions of the language.
16202 2004-12-02 Duncan Mak <duncan@ximian.com>
16204 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
16206 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
16207 here as a static method. Take an additional bool out parameter
16208 `must_do_cs1540_check' for signaling to InstanceResolve.
16209 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
16210 member field from PropertyExpr class and made it an argument of
16211 the method instead.
16212 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
16213 check for MarshalByRefObject, and report CS0122 instead of CS1540.
16214 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
16215 and `remove_accessor' as well as InstanceResolve: report CS0122
16220 2004-12-03 Raja R Harinath <rharinath@novell.com>
16222 Fix test-327.cs, test-328.cs, and put in early infrastructure
16223 for eventually fixing #52697.
16224 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
16225 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
16226 from other methods.
16227 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
16228 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
16229 (VerifyUsing, error246): Update.
16230 * rootcontext.cs (RootContext.NamespaceLookup): Just use
16231 'NamespaceEntry.LookupNamespaceOrType'.
16233 2004-12-03 Martin Baulig <martin@ximian.com>
16235 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16236 method as our child, call AnonymousMethod.Compatible() on it.
16238 2004-12-03 Raja R Harinath <rharinath@novell.com>
16240 Disable XML documentation support in 'basic' profile.
16241 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
16242 Redirect XmlElement to System.Object.
16243 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
16244 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
16245 * mcs.exe.sources: Add doc-bootstrap.cs.
16246 * doc-bootstrap.cs: New file. Contains empty stub implementation
16249 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
16251 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
16252 comments are allowed.
16254 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16256 * delegate.cs: Add checks for subtypes in paramaters and return values
16257 in VerifyMethod () to add support for Covariance/Contravariance
16260 2004-12-02 Miguel de Icaza <miguel@ximian.com>
16262 * report.cs: Remove extra closing parenthesis.
16264 * convert.cs (Error_CannotImplicitConversion): If the name of the
16265 types are the same, provide some extra information.
16267 * class.cs (FieldBase): Use an unused bit field from the field to
16268 encode the `has_offset' property from the FieldMember. This saves
16269 a couple of Ks on bootstrap compilation.
16271 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16272 method as our child, return the AnonymousMethod resolved
16275 * expression.cs (New.DoResolve): Allow return values from
16276 NewDelegate to also include AnonymousMethods.
16280 2004-12-02 Marek Safar <marek.safar@seznam.cz>
16283 * attribute.cs (Resolve): Improved implementation of params
16284 attribute arguments.
16286 * support.cs (ParameterData): Add HasParams to be faster.
16288 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
16290 all things are for /doc support:
16292 * doc.cs: new file that supports XML documentation generation.
16293 * mcs.exe.sources: added doc.cs.
16295 Handle /doc command line option.
16296 Report error 2006 instead of 5 for missing file name for /doc.
16297 Generate XML documentation when required, after type resolution.
16299 Added support for picking up documentation (/// and /** ... */),
16300 including a new XmlCommentState enumeration.
16302 Added lines to fill Documentation element for field, constant,
16303 property, indexer, method, constructor, destructor, operator, event
16304 and class, struct, interface, delegate, enum.
16305 Added lines to warn incorrect comment.
16307 Added Documentation field (passed only when /doc was specified).
16309 Added DocComment, DocCommentHeader, GenerateDocComment() and
16310 OnGenerateDocComment() and some supporting private members for
16311 /doc feature to MemberCore.
16313 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16315 Added overriden DocCommentHeader.
16317 Added overriden DocCommentHeader and GenerateDocComment().
16319 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16321 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16322 unwrapping the enumeration values, chain to
16323 DoConstantNumericPromotions again, so we can promote things to the
16324 fundamental types (takes care of enums that are bytes, sbytes).
16328 2004-12-01 Raja R Harinath <rharinath@novell.com>
16330 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16331 Fix long-standing bug in type-lookup. Use FindType instead of
16332 LookupType when ec.ResolvingTypeTree.
16333 (Attribute.ResolveType, Attribute.Resolve)
16334 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16336 (Attributes.Search): Remove internal version. Update.
16337 (Attributes.SearchMulti): Update.
16338 (Attributes.GetClsCompliantAttribute): Remove.
16339 (Attributes.GetIndexerNameAttribute): Remove.
16340 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16341 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16342 * class.cs (Indexer.Define): Likewise.
16344 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16347 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16348 MarshallByReference members access.
16350 * expression.cs: Use CheckMarshallByRefAccess;
16351 Better error CS0197 message.
16353 * report.cs: Print whole related error message.
16355 2004-11-30 Raja R Harinath <rharinath@novell.com>
16357 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16358 the current directory to help debugging.
16360 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16362 * class (GetClassBases): Better error 60 report.
16363 (EventProperty): Disabled warning 67 detection.
16365 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16368 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16370 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16373 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16376 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16378 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16380 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16382 * attribute.cs (Attribute.Resolve): Refine error reporting and
16383 report a cs0117 if the identifier does not exist, to distinguish
16384 from 0617 which is a miss-use of the actual identifier.
16386 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16387 between cs0070 and cs0079.
16389 * class.cs (MemberBase.DoDefine): When reporting a wrong
16390 accessibility level, we use MethodCore to compare instead of
16391 Method (this was a regression in some refactoring effort).
16393 So now we correctly report cs0056 again.
16395 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16396 testing the target_type (which was known to be object_type) and
16397 not the source type (which is anonymous_method).
16399 Fixed reporting of error cs1660.
16401 * expression.cs (UserCast.Source): Expose the underlying cast.
16403 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16404 allowed types to find a match to int32 first (most common).
16406 In addition, it ignores any ImplicitUserConversions that did an
16407 internal implicit conversion (as the switch statement allows only
16408 one integral conversion to exist).
16410 * class.cs (PartialContainer.Create): rename `name' to
16411 `member_name' for clarity. Then replace the string calls with a
16412 call to MemberName.GetPartialName, as now using
16413 MemberName.ToString is an error (this is due to the side effects
16414 it had, that were fixed in the past).
16416 This will restore the error reporting on a number of partial class
16417 errors that were missusing this (and getting an exception as a
16418 results, which is now just a plain textual warning, because
16419 yyparse debug output would crash otherwise).
16421 2004-11-26 Raja R Harinath <rharinath@novell.com>
16423 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16425 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16427 * rootcontext.cs (LookupType): Make sure to cache lookups that
16428 don't give us a negative result. This saves about 5% of corlib
16431 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16433 * report.cs (AbstractMessage.Print): messages are sent to stderr
16435 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16436 non-interface in the list of interfaces (at this point, either
16437 parent was properly set, or a base class is being listed in the
16438 interfaces section).
16440 This flags error 1722, and resolves the crash from bug 69259.
16442 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16444 * statement.cs (Using.EmitExpressionFinally): make this work right
16445 for valuetypes. Fixes 69926.
16447 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16449 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16450 converted to an enum" here, before we try to change the underlying
16451 type. This code exists, but it is a different code path than the
16452 one used while encoding constants.
16454 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16455 old bug: when converting from the null literal to a pointer,
16456 return an EmptyCast, not the NullLiteral.
16458 This fixes #69921, the recent null_type changes probably made this
16459 bug more prominent.
16461 (ImplicitReferenceConversionExists): In addition, resynchronized
16462 the code here, so it matches the same code in
16463 ImplicitReferenceConversionExists for the `from any class-type S
16464 to any interface-type T'.
16467 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16469 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16471 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16473 * cs-parser.jay: Use verbosity accordingly.
16475 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16477 * expression.cs (Unary.ResolveOperator): Do not report warning;
16478 AddressOf reads from variable.
16480 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16482 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16486 * attribute.cs (Attributable): Removed CheckTargets.
16487 (Attributes.Emit): Explicit attribute targets are tested here.
16489 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16490 not enabled for interfaces.
16492 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16493 (GetAssemblyName): Ouch next bug there.
16495 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16497 * expression.cs: Error 275 added.
16499 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16501 Fix bug #69177 (Implemented decimal constant support)
16503 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16504 (BinaryFold): Add DecimalConstant.
16506 * const.cs (Define): Decimal constant
16508 (ChangeType): Add decimal type handling.
16509 (LookupConstantValue): Don't set value for decimal type but
16510 emit DecimalConstantAttribute. Needed for constant optimization.
16512 * constant.cs (ToDecimal): New method.
16513 (ConvertToDecimal): New method.
16514 (IntConstant): Implemented ConvertToDecimal.
16515 (DecimalConstant.Emit): Emit optimized version for decimals in
16518 * expression.cs (ResolveOperator): Changed order of constant
16519 reduction to work correctly with native types which have
16520 overloaded operators.
16521 (ResolveMemberAccess): Extract constant value from attribute
16524 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16526 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16527 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16528 (ChangeType): Decimal is special.
16529 (TypeToCoreType): Add decimal type.
16531 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16533 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16536 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16538 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16541 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16543 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16545 * pending.cs (PendingImplementation): Grab only interfaces.
16547 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16549 * statement.cs (ForeachHelperMethods): Add location member and
16550 error 202 detection.
16552 2004-11-19 Raja R Harinath <rharinath@novell.com>
16554 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16555 automatically handled by executable.make.
16556 (PROGRAM): Make profile-specific.
16558 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16560 * expression.cs (DoResolveBase): Fixed wrong warning for out
16563 2004-11-18 Martin Baulig <martin@ximian.com>
16565 Merged latest changes into gmcs. Please keep this comment in
16566 here, it makes it easier for me to see what changed in MCS since
16567 the last time I merged.
16569 2004-11-17 Raja R Harinath <rharinath@novell.com>
16571 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16572 (TypeHandle.GetMemberCache): New.
16573 (TypeHandle.TypeHandle): Update.
16574 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16575 (TypeManager.LookupParentInterfacesCache):
16576 Rename from LookupInterfaceCache. Optimize slightly.
16577 (TypeManager.MemberLookup_FindMembers): Update.
16578 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16579 multi-type variant.
16580 (AddCacheContents): Rename from AddHashtable.
16581 * class.cs (TypeContainer.parent_container): Remove.
16582 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16583 (TypeContainer.DoDefineMembers): Don't initialize it.
16584 Update to name changes.
16586 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16588 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16589 that factors the code to check access modifiers on override.
16591 (PropertyBase): Use the code here.
16593 Patch from Lluis S'anchez, fixes bug #69361.
16595 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16597 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16598 routine that is used to report the use of a captured variable
16599 whose address has been taken.
16601 There are two checks: one when variables are being captured and
16602 the other check is when the address of a variable is taken.
16604 (because an anonymous methods might be resolved before *or* after
16605 the address has been taken) and
16607 * expression.cs (Conditional.DoResolve): Remove the special
16608 casing that Martin added to trueExpr and falseExpr being both
16609 NullLiteral. We get the right behavior now just by introducing
16610 the null_type into the compiler.
16612 * convert.cs (ExplicitConversion): Change the code to use
16613 null_type instead of testing `expr is NullLiteral'.
16614 (ImplicitConversionStandard): use null_type too.
16615 (ImplicitReferenceConversionExists): use null_type too.
16616 (ImplicitReferenceConversion): use null_type too.
16618 * literal.cs: The type of `NullLiteral' is now null_type instead
16620 (Resolve): Set the type here.
16622 * typemanager.cs: Introduce null_type.
16624 2004-11-17 Martin Baulig <martin@ximian.com>
16626 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16627 direction, like FindMembers() does. Fixes #69546, testcase is in
16630 2004-11-16 Martin Baulig <martin@ximian.com>
16632 This is based on a patch from Marek Safar, see bug #69082.
16633 Fixes bugs #63705 and #67130.
16635 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16636 method; create a MemberCache for an interface type and cache the
16639 * decl.cs (IMemberContainer.ParentContainer): Removed.
16640 (IMemberContainer.ParentCache): New property.
16641 (MemberCache.SetupCacheForInterface): Removed.
16642 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16643 to create a cache for an interface's "parent".
16645 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16648 2004-11-16 Martin Baulig <martin@ximian.com>
16650 Merged back from gmcs; these changes already went into gmcs a
16651 couple of weeks ago.
16654 (TypeManager.AddUserType): Removed the `ifaces' argument.
16655 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16657 (TypeManager.AddUserInterface): Removed.
16658 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16660 (TypeManager.GetInterfaces): Likewise.
16661 (TypeManager.GetExplicitInterfaces): Likewise.
16663 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16665 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16666 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16668 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16670 * statement.cs: Avoid adding bools to a hashtable.
16672 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16674 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16675 calling an unsafe method from a safe location.
16677 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16680 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16682 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16684 * namespace.cs (VerifyUsing): use GetPartialName instead of
16687 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16689 * statement.cs (Return.Resolve): Fix regression in typo: if
16690 `in_exc', we have to request a NeedReturnLabel, this was a typo
16691 introduced in the anonymous method check-in. Fixes #69131.
16693 * Indexers were using the ShortName when defining themselves,
16694 causing a regression in the compiler bootstrap when applying the
16695 patch from 2004-11-02 (first part), now they use their full name
16696 and the bug is gone.
16698 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16700 * driver.cs: Strip the path from the names of embedded resources. Fixes
16703 2004-11-04 Raja R Harinath <rharinath@novell.com>
16705 Fix error message regression: cs0104-2.cs.
16706 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16707 (AliasEntry.Resolve): Update.
16708 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16710 (RootContext.LookupType): Update.
16712 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16714 * cs-parser.jay: Add support for handling accessor modifiers
16715 * class: Add support port accessor modifiers and error checking,
16716 define PropertyMethod.Define as virtual (not abstract anymore)
16717 * ecore.cs: Add checking for proeprties access with access modifiers
16718 * iterators.cs: Modify Accessor constructor call based in the modified
16720 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16722 * expression.cs (StringConcat): Handle being called twice,
16723 as when we have a concat in a field init with more than two
16726 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16728 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16729 special case explicit implementations, we should always produce
16730 the .property or .event declaration.
16732 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16733 since it will not return correct data if people use this
16734 unresolved in the presence of using statements (see test-313).
16736 * class.cs (MethodData.Define): If we are an explicit interface
16737 implementation, set the method name to the full name of the
16738 interface plus the name of the method.
16740 Notice that using the method.MethodName.GetFullName() does not
16741 work, as it will only contain the name as declared on the source
16742 file (it can be a shorthand in the presence of using statements)
16743 and not the fully qualifed type name, for example:
16747 class D : ICloneable {
16748 object ICloneable.Clone () {
16752 Would produce a method called `ICloneable.Clone' instead of
16753 `System.ICloneable.Clone'.
16755 * namespace.cs (Alias.Resolve): Use GetPartialName.
16757 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16759 * cs-parser.jay: Add error 1055 report.
16761 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16763 * assign.cs (Assign.DoResolve): Only do the transform of
16764 assignment into a New if the types are compatible, if not, fall
16765 through and let the implicit code deal with the errors and with
16766 the necessary conversions.
16768 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16770 * cs-parser.jay: Add error 1031 report.
16772 * cs-tokenizer.cs: Add location for error 1038.
16774 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16776 * cs-parser.jay: Add error 1016 report.
16778 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16780 * cs-parser.jay: Add errors 1575,1611 report.
16782 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16784 * cs-parser.jay: Add error 1001 report.
16786 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16789 * attribute.cs (GetMarshal): Add method argument for
16790 caller identification.
16792 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16793 agument for GetMarshal and RuntimeMissingSupport.
16795 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16797 * attribute.cs (ExtractSecurityPermissionSet): Removed
16798 TypeManager.code_access_permission_type.
16800 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16802 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16804 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16805 for obsolete use of a variable here. Fixes regression on errors
16806 cs0619-25 and cs0619-26.
16808 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16810 Fix #62358, implemented security attribute encoding.
16812 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16813 Tests permitted SecurityAction for assembly or other types.
16814 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16815 data from SecurityPermissionAttribute to PermisionSet class.
16817 * class.cs (ApplyAttributeBuilder): Added special handling
16818 for System.Security.Permissions.SecurityAttribute based types.
16820 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16821 special handling for System.Security.Permissions.SecurityAttribute
16824 * enum.cs (ApplyAttributeBuilder): Added special handling
16825 for System.Security.Permissions.SecurityAttribute based types.
16827 * parameter.cs (ApplyAttributeBuilder): Added special handling
16828 for System.Security.Permissions.SecurityAttribute based types.
16830 * rootcontext.cs: Next 2 core types.
16832 * typemanager.cs (TypeManager.security_permission_attr_type):
16833 Built in type for the SecurityPermission Attribute.
16834 (code_access_permission_type): Build in type.
16836 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16838 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16839 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16840 all of this information into
16841 EmitContext.EmitCapturedVariableInstance.
16843 * codegen.cs (EmitCapturedVariableInstance): move here the
16844 funcionality of emitting an ldarg.0 in the presence of a
16845 remapping. This centralizes the instance emit code.
16847 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16848 then emit a load of this: it means that we have reached the
16849 topmost ScopeInfo: the one that contains the pointer to the
16850 instance of the class hosting the anonymous method.
16852 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16853 captures to the topmost CaptureContext.
16855 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16857 * expression.cs (LocalVariableReference): Move the knowledge about
16858 the iterators into codegen's EmitCapturedVariableInstance.
16860 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16862 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16863 all code paths return a value from an anonymous method (it is the
16864 same as the 161 error, but for anonymous methods).
16866 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16868 The introduction of anonymous methods in the compiler changed
16869 various ways of doing things in the compiler. The most
16870 significant one is the hard split between the resolution phase
16871 and the emission phases of the compiler.
16873 For instance, routines that referenced local variables no
16874 longer can safely create temporary variables during the
16875 resolution phase: they must do so from the emission phase,
16876 since the variable might have been "captured", hence access to
16877 it can not be done with the local-variable operations from the runtime.
16881 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16882 is a toplevel block.
16884 (ToplevelBlock): A new kind of Block, these are the blocks that
16885 are created by the parser for all toplevel method bodies. These
16886 include methods, accessors and anonymous methods.
16888 These contain some extra information not found in regular blocks:
16889 A pointer to an optional CaptureContext (for tracking captured
16890 local variables and parameters). A pointer to the parent
16893 (Return.Resolve): Catch missmatches when returning a value from an
16894 anonymous method (error 1662).
16895 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16898 (Break.Resolve): ditto.
16900 (SwitchLabel): instead of defining the labels during the
16901 resolution phase, we now turned the public ILLabel and ILLabelCode
16902 labels into methods called GetILLabelCode() and GetILLabel() that
16903 only define the label during the Emit phase.
16905 (GotoCase): Track the SwitchLabel instead of the computed label
16906 (its contained therein). Emit the code by using
16907 SwitchLabel.GetILLabelCode ().
16909 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16910 whether the Local has been captured or not.
16912 (LocalInfo.IsCaptured): New property, used to tell whether the
16913 local has been captured.
16915 * anonymous.cs: Vastly updated to contain the anonymous method
16918 The main classes here are: CaptureContext which tracks any
16919 captured information for a toplevel block and ScopeInfo used to
16920 track the activation frames for various local variables.
16922 Each toplevel block has an optional capture context associated
16923 with it. When a method contains an anonymous method both the
16924 toplevel method and the anonymous method will create a capture
16925 context. When variables or parameters are captured, they are
16926 recorded on the CaptureContext that owns them, for example:
16930 MyDelegate d = delegate {
16935 Here `a' will be recorded as captured on the toplevel
16936 CapturedContext, the inner captured context will not have anything
16937 (it will only have data if local variables or parameters from it
16938 are captured in a nested anonymous method.
16940 The ScopeInfo is used to track the activation frames for local
16941 variables, for example:
16943 for (int i = 0; i < 10; i++)
16944 for (int j = 0; j < 10; j++){
16945 MyDelegate d = delegate {
16950 At runtime this captures a single captured variable `i', but it
16951 captures 10 different versions of the variable `j'. The variable
16952 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16953 recorded on a child.
16955 The toplevel ScopeInfo will also track information like the `this'
16956 pointer if instance variables were referenced (this is necessary
16957 as the anonymous method lives inside a nested class in the host
16958 type of the method).
16960 (AnonymousMethod): Expanded to track the Toplevel, implement
16961 `AnonymousMethod.Compatible' to tell whether an anonymous method
16962 can be converted to a target delegate type.
16964 The routine now also produces the anonymous method content
16966 (AnonymousDelegate): A helper class that derives from
16967 DelegateCreation, this is used to generate the code necessary to
16968 produce the delegate for the anonymous method that was created.
16970 * assign.cs: API adjustments for new changes in
16971 Convert.ImplicitStandardConversionExists.
16973 * class.cs: Adjustments to cope with the fact that now toplevel
16974 blocks are of type `ToplevelBlock'.
16976 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16977 insteda of standard blocks.
16979 Flag errors if params arguments are passed to anonymous methods.
16981 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16982 `CurrentAnonymousMethod' which points to the current Anonymous
16983 Method. The variable points to the AnonymousMethod class that
16984 holds the code being compiled. It is set in the new EmitContext
16985 created for the anonymous method.
16987 (EmitContext.Phase): Introduce a variable and an enumeration to
16988 assist in enforcing some rules about when and where we are allowed
16989 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16990 only one that enfonces this right now).
16992 (EmitContext.HaveCaptureInfo): new helper method that returns
16993 whether we have a CapturedContext initialized.
16995 (EmitContext.CaptureVariable): New method used to register that a
16996 LocalInfo must be flagged for capturing.
16998 (EmitContext.CapturedParameter): New method used to register that a
16999 parameters must be flagged for capturing.
17001 (EmitContext.CapturedField): New method used to register that a
17002 field must be flagged for capturing.
17004 (EmitContext.HaveCapturedVariables,
17005 EmitContext.HaveCapturedFields): Return whether there are captured
17006 variables or fields.
17008 (EmitContext.EmitMethodHostInstance): This is used to emit the
17009 instance for the anonymous method. The instance might be null
17010 (static methods), this (for anonymous methods that capture nothing
17011 and happen to live side-by-side with the current method body) or a
17012 more complicated expression if the method has a CaptureContext.
17014 (EmitContext.EmitTopBlock): Routine that drives the emission of
17015 code: it will first resolve the top block, then emit any metadata
17016 and then emit the code. The split is done so that we can extract
17017 any anonymous methods and flag any captured variables/parameters.
17019 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
17020 during this phase, the ILGenerator should not be used as labels
17021 and local variables declared here might not be accessible to any
17022 code that is part of an anonymous method.
17024 Exceptions to this include the temporary variables that are
17025 created by some statements internally for holding temporary
17028 (EmitContext.EmitMeta): New routine, in charge of emitting all the
17031 (EmitContext.TemporaryReturn): This method is typically called
17032 from the Emit phase, and its the only place where we allow the
17033 ReturnLabel to be defined other than the EmitMeta. The reason is
17034 that otherwise we would have to duplicate a lot of logic in the
17035 Resolve phases of various methods that today is on the Emit
17038 (EmitContext.NeedReturnLabel): This no longer creates the label,
17039 as the ILGenerator is not valid during the resolve phase.
17041 (EmitContext.EmitThis): Extended the knowledge in this class to
17042 work in anonymous methods in addition to iterators.
17044 (EmitContext.EmitCapturedVariableInstance): This emits whatever
17045 code is necessary on the stack to access the instance to a local
17046 variable (the variable will be accessed as a field).
17048 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
17049 EmitContext.EmitAddressOfParameter): Routines to support
17050 parameters (not completed at this point).
17052 Removals: Removed RemapLocal and RemapLocalLValue. We probably
17053 will also remove the parameters.
17055 * convert.cs (Convert): Define a `ConstantEC' which points to a
17056 null. This is just to prefity some code that uses
17057 ImplicitStandardConversion code and do not have an EmitContext
17060 The idea is to flag explicitly that at that point in time, it is
17061 known that the conversion will not trigger the delegate checking
17062 code in implicit conversions (which requires a valid
17065 Everywhere: pass new EmitContext parameter since
17066 ImplicitStandardConversionExists now requires it to check for
17067 anonymous method conversions.
17069 (Convert.ImplicitStandardConversionExists): If the type of an
17070 expression is the anonymous_method_type, and the type is a
17071 delegate, we invoke the AnonymousMethod.Compatible method to check
17072 whether an implicit conversion is possible.
17074 (Convert.ImplicitConversionStandard): Only do implicit method
17075 group conversions if the language level is not ISO_1.
17077 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
17078 MethodInfo for the Invoke method. used by Delegate and
17081 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
17082 method conversions if the target type is a delegate.
17084 Removed extra debugging nops.
17086 (LocalVariableReference): Turn the `local_info' into a public
17089 Add `prepared' field, the same hack used for FieldExprs to cope
17090 with composed assignments, as Local variables do not necessarily
17091 operate purely on the stack as they used to: they can be captured
17094 Add `temp' for a temporary result, like fields.
17096 Refactor DoResolve and DoResolveLValue into DoResolveBase.
17098 It now copes with Local variables that are captured and emits the
17099 proper instance variable to load it from a field in the captured
17102 (ParameterReference.DoResolveBase): During the resolve phase,
17103 capture parameters if we are in an anonymous method.
17105 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
17106 anonymous method, use the EmitContext helper routines to emit the
17107 parameter reference.
17109 * iterators.cs: Set RemapToProxy to true/false during the
17112 * parameters.cs (GetParameterByName): New helper method.
17114 * typemanager.cs (anonymous_method_type) a new type that
17115 represents an anonyous method. This is always an internal type,
17116 used as a fencepost to test against the anonymous-methodness of an
17119 2004-10-20 Marek Safar <marek.safar@seznam.cz>
17121 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
17123 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
17125 2004-10-18 Martin Baulig <martin@ximian.com>
17127 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
17128 `Type' directly, but call ResolveType() on it.
17129 (Catch.Resolve): Likewise.
17130 (Foreach.Resolve): Likewise.
17132 2004-10-18 Martin Baulig <martin@ximian.com>
17134 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
17135 `Type' directly, but call ResolveType() on it.
17136 (Probe.DoResolve): Likewise.
17137 (ArrayCreation.LookupType): Likewise.
17138 (TypeOf.DoResolve): Likewise.
17139 (SizeOf.DoResolve): Likewise.
17141 2004-10-18 Martin Baulig <martin@ximian.com>
17143 * expression.cs (Invocation.BetterFunction): Put back
17144 TypeManager.TypeToCoreType().
17146 2004-10-18 Raja R Harinath <rharinath@novell.com>
17148 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
17151 2004-10-18 Martin Baulig <martin@ximian.com>
17153 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
17154 `Type' directly, but call ResolveType() on it.
17156 2004-10-18 Martin Baulig <martin@ximian.com>
17158 * class.cs (FieldMember.Define): Don't access the TypeExpr's
17159 `Type' directly, but call ResolveType() on it.
17160 (MemberBase.DoDefine): Likewise.
17162 * expression.cs (New.DoResolve): Don't access the TypeExpr's
17163 `Type' directly, but call ResolveType() on it.
17164 (ComposedCast.DoResolveAsTypeStep): Likewise.
17166 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
17167 `Type' directly, but call ResolveType() on it.
17169 2004-10-17 John Luke <john.luke@gmail.com>
17171 * class.cs (Operator.GetSignatureForError): use CSharpName
17173 * parameter.cs (Parameter.GetSignatureForError): Returns
17174 correct name even if was not defined.
17176 2004-10-13 Raja R Harinath <rharinath@novell.com>
17179 * class.cs (TypeContainer.EmitContext): New property.
17180 (DefineNestedTypes): Create an emitcontext for each part.
17181 (MethodCore.DoDefineParameters): Use container's emitcontext.
17182 Pass type array to InternalParameters.
17183 (MemberBase.DoDefine): Use container's emitcontext.
17184 (FieldMember.Define): Likewise.
17185 (Event.Define): Likewise.
17186 (SetMethod.GetParameterInfo): Change argument to EmitContext.
17187 Pass type array to InternalParameters.
17188 (SetIndexerMethod.GetParameterInfo): Likewise.
17189 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
17190 * delegate.cs (Define): Pass emitcontext to
17191 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
17192 array to InternalParameters.
17193 * expression.cs (ParameterReference.DoResolveBase): Pass
17194 emitcontext to GetParameterInfo.
17195 (ComposedCast.DoResolveAsTypeStep): Remove check on
17196 ec.ResolvingTypeTree.
17197 * parameter.cs (Parameter.Resolve): Change argument to
17198 EmitContext. Use ResolveAsTypeTerminal.
17199 (Parameter.GetSignature): Change argument to EmitContext.
17200 (Parameters.ComputeSignature): Likewise.
17201 (Parameters.ComputeParameterTypes): Likewise.
17202 (Parameters.GetParameterInfo): Likewise.
17203 (Parameters.ComputeAndDefineParameterTypes): Likewise.
17204 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
17205 * support.cs (InternalParameters..ctor): Remove variant that takes
17207 * typemanager.cs (system_intptr_expr): New.
17208 (InitExpressionTypes): Initialize it.
17210 2004-10-12 Chris Toshok <toshok@ximian.com>
17212 * cs-parser.jay: fix location for try_statement and catch_clause.
17214 2004-10-11 Martin Baulig <martin@ximian.com>
17216 * report.cs: Don't make --fatal abort on warnings, we have
17217 -warnaserror for that.
17219 2004-10-07 Raja R Harinath <rharinath@novell.com>
17221 More DeclSpace.ResolveType avoidance.
17222 * decl.cs (MemberCore.InUnsafe): New property.
17223 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
17224 with newly created EmitContext.
17225 (FieldMember.Define): Likewise.
17226 * delegate.cs (Delegate.Define): Likewise.
17227 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
17228 only if normal name-lookup fails.
17229 (TypeExpr.DoResolve): Enable error-checking.
17230 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
17231 (SizeOf.DoResolve): Likewise.
17232 (ComposedCast.DoResolveAsTypeStep): Likewise.
17233 (StackAlloc.DoResolve): Likewise.
17234 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
17235 (Block.Unsafe): New property.
17236 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
17237 (Unsafe): Set 'unsafe' flag of contained block.
17238 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
17239 (Fixed.Resolve): Likewise.
17240 (Catch.Resolve): Likewise.
17241 (Using.ResolveLocalVariableDecls): Likewise.
17242 (Foreach.Resolve): Likewise.
17244 2004-10-05 John Luke <john.luke@gmail.com>
17246 * cs-parser.jay: add location to error CS0175
17248 2004-10-04 Miguel de Icaza <miguel@ximian.com>
17250 * ecore.cs (Expression.Constantity): Add support for turning null
17253 * const.cs (Const.Define): Allow constants to be reference types
17254 as long as the value is Null.
17256 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
17258 * namespace.cs (NamespaceEntry.Using): No matter which warning
17259 level is set, check if this namespace name has already been added.
17261 2004-10-03 Ben Maurer <bmaurer@ximian.com>
17263 * expression.cs: reftype [!=]= null should always use br[true,false].
17266 2004-10-03 Marek Safar <marek.safar@seznam.cz>
17269 * attribute.cs: Enum conversion moved to
17270 GetAttributeArgumentExpression to be applied to the all
17273 2004-10-01 Raja R Harinath <rharinath@novell.com>
17275 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
17276 * class.c (TypeContainer.DefineType): Flag error if
17277 base types aren't accessible due to access permissions.
17278 * decl.cs (DeclSpace.ResolveType): Move logic to
17279 Expression.ResolveAsTypeTerminal.
17280 (DeclSpace.ResolveTypeExpr): Thin layer over
17281 Expression.ResolveAsTypeTerminal.
17282 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
17283 Refactor code into NestedAccess. Use it.
17284 (DeclSpace.NestedAccess): New.
17285 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
17286 argument to silence errors. Check access permissions.
17287 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
17288 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
17289 (Cast.DoResolve): Likewise.
17290 (New.DoResolve): Likewise.
17291 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
17292 (TypeOf.DoResolve): Likewise.
17294 * expression.cs (Invocation.BetterConversion): Return the Type of
17295 the better conversion. Implement section 14.4.2.3 more faithfully.
17296 (Invocation.BetterFunction): Make boolean. Make correspondence to
17297 section 14.4.2.2 explicit.
17298 (Invocation.OverloadResolve): Update.
17299 (Invocation): Remove is_base field.
17300 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
17301 (Invocation.Emit): Likewise.
17303 2004-09-27 Raja R Harinath <rharinath@novell.com>
17305 * README: Update to changes.
17307 2004-09-24 Marek Safar <marek.safar@seznam.cz>
17309 * cs-parser.jay: Reverted 642 warning fix.
17311 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17314 * decl.cs (FindMemberWithSameName): Indexer can have more than
17317 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17319 * expression.cs (LocalVariableReference.DoResolveLValue):
17320 Do not report warning 219 for out values.
17321 (EmptyExpression.Null): New member to avoid extra allocations.
17323 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17325 * cs-parser.jay: Fix wrong warning 642 report.
17327 * cs-tokenizer.cs (CheckNextToken): New helper;
17328 Inspect next character if is same as expected.
17330 2004-09-23 Martin Baulig <martin@ximian.com>
17332 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17333 (Convert.ImplicitReferenceConversionExists): Likewise.
17335 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17337 * class.cs (Operator.Define): Add error 448 and 559 report.
17339 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17341 * class.cs (MemberBase.IsTypePermitted): New protected
17342 method for checking error CS0610.
17344 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17346 * class.cs (TypeContainer.HasExplicitLayout): New property
17347 Returns whether container has StructLayout attribute set Explicit.
17348 (FieldMember): New abstract class for consts and fields.
17349 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17350 (Field): Reuse FieldMember.
17352 * const.cs (Const): Reuse FieldMember.
17354 * rootcontext.cs: EmitConstants call moved to class.
17356 2004-09-22 Martin Baulig <martin@ximian.com>
17358 Thanks to Peter Sestoft for this bug report.
17360 * expression.cs (Conditional): If both the `trueExpr' and the
17361 `falseExpr' is a NullLiteral, return a NullLiteral.
17363 2004-09-22 Martin Baulig <martin@ximian.com>
17365 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17366 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17367 for the "get_Current" call.
17369 2004-09-22 Martin Baulig <martin@ximian.com>
17371 Marek and me just fixed one of our oldest bugs: #28562 :-)
17373 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17375 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17376 we're an EnumConstant, just return that.
17377 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17378 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17379 to get the value which'll actually be written into the attribute.
17380 However, we have to use GetValue() to access the attribute's value
17383 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17385 * constant.cs (Constant.IsNegative): New abstract property
17388 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17389 (StackAlloc.DoResolve): Reused IsNegative.
17391 2004-09-21 Martin Baulig <martin@ximian.com>
17393 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17394 if we're used in an iterator, we may be called from different
17397 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17398 we actually have an exception block.
17400 2004-09-20 John Luke <jluke@cfl.rr.com>
17402 * class.cs, cs-parser.jay: Improve the error report for 1520:
17403 report the actual line where the error happens, not where the
17404 class was declared.
17406 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17407 Pass location information that was available elsewhere.
17409 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17411 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17412 runtime to delay sign assemblies.
17414 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17416 * cs-parser.jay: Do not report the stack trace, this is barely
17419 2004-08-22 John Luke <john.luke@gmail.com>
17421 * driver.cs : check that a resource id is not already used
17422 before adding it, report CS1508 if it is, bug #63637
17424 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17426 * ecore.cs: Removed dead code.
17428 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17430 * class.cs: Do not report warning CS0067 on the interfaces.
17432 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17434 * cs-parser.jay: Add error 504 report.
17436 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17438 * rootcontext.cs: WarningLevel is 4 by default now.
17440 * statement.cs (Fixed.Resolve): Do not null
17443 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17446 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17447 deep search when property is not virtual.
17448 (PropertyExpr.ResolveAccessors): Make one call for both
17451 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17454 * statement.cs: Error 152 report constains also location.
17456 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17459 * const.cs: Explicitly set constant as static.
17461 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17464 * cs-parser.jay: Add error 1017 report.
17466 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17468 Fixed bug #59980, #64224
17469 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17471 * typemanager.cs (IsSpecialMethod): Simplified
17473 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17475 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17476 condition with better params.
17478 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17481 * attribute.cs (Resolve): Property has to have both
17484 2004-09-14 Martin Baulig <martin@ximian.com>
17486 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17488 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17491 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17492 called and is obsolete then this member suppress message
17493 when call is inside next [Obsolete] method or type.
17495 * expression.cs: Use TestObsoleteMethodUsage member.
17497 2004-09-14 Martin Baulig <martin@ximian.com>
17499 * cs-parser.jay: Sync a bit with the GMCS version.
17501 2004-09-14 Martin Baulig <martin@ximian.com>
17503 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17504 (CSharpParser.yacc_verbose_flag): New public field.
17506 * genericparser.cs: Removed.
17508 2004-09-14 Raja R Harinath <rharinath@novell.com>
17510 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17512 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17514 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17516 2004-09-10 Martin Baulig <martin@ximian.com>
17518 Backported my MemberName changes from GMCS into MCS.
17520 - we are now using a special `MemberName' class instead of using
17521 strings; in GMCS, the `MemberName' also contains the type
17524 - changed the grammar rules a bit:
17525 * the old `member_name' is now a `namespace_or_type_name':
17526 The rule is that we use `namespace_or_type_name' everywhere
17527 where we expect either a "member name" (GetEnumerator) or a
17528 "member name" with an explicit interface name
17529 (IEnumerable.GetEnumerator).
17530 In GMCS, the explicit interface name may include type arguments
17531 (IEnumerable<T>.GetEnumerator).
17532 * we use `member_name' instead of just `IDENTIFIER' for
17534 The rule is that we use `member_name' wherever a member may
17535 have type parameters in GMCS.
17537 * decl.cs (MemberName): New public class.
17538 (MemberCore.MemberName): New public readonly field.
17539 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17540 (DeclSpace): Likewise.
17542 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17543 * enum.cs (Enum.ctor): Likewise.
17545 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17547 (AliasEntry.ctor): Take a MemberName, not an Expression.
17548 (AliasEntry.UsingAlias): Likewise.
17550 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17551 (IMethodData.MemberName): Changed type from string to MemberName.
17552 (MemberBase.ExplicitInterfaceName): Likewise.
17553 (AbstractPropertyEventMethod.SetupName): Make this private.
17554 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17555 argument; compute the member name here.
17556 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17557 on the `member.MemberName' and the `prefix'.
17559 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17561 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17562 thus, we get a `MemberName' instead of a `string'. These
17563 declarations may have type parameters in GMCS.
17564 (interface_method_declaration, delegate_declaration): Likewise.
17565 (class_declaration, interface_declaration): Likewise.
17566 (method_header): Use `namespace_or_type_name' instead of
17567 `member_name'. We may be an explicit interface implementation.
17568 (property_declaration, event_declaration): Likewise.
17569 (member_name): This is now just an `IDENTIFIER', not a
17570 `namespace_or_type_name'.
17571 (type_name, interface_type): Removed.
17572 (namespace_or_type_name): Return a MemberName, not an Expression.
17573 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17574 call GetTypeExpression() on the MemberName to get an expression.
17575 (IndexerDeclaration.interface_type): Changed type from string to
17577 (MakeName): Operate on MemberName's instead of string's.
17579 2004-09-13 Raja R Harinath <rharinath@novell.com>
17582 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17583 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17584 lookup to avoid symbols introduced by 'using'.
17585 * rootcontext.cs (NamespaceLookup): Update.
17587 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17589 * class.cs (TypeContainer.DoDefineMembers): Do not call
17590 DefineDefaultConstructor for static classes.
17592 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17594 * attribute.cs (Attribute.Resolve): Add error 653 report.
17596 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17598 (Method.ApplyAttributeBuilder): Add error 685 report.
17599 (Operator.Define): Add error 564 report.
17601 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17603 * expression.cs (Invocation.DoResolve): Add error
17604 245 and 250 report.
17606 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17609 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17611 * class.cs (ConstructorInitializer.Resolve):
17612 Wrong error number (515->516).
17614 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17616 * class.cs (Indexer.Define): Add error 631 report.
17618 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17620 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17622 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17624 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17626 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17628 * cs-parser.jay: Added error CS0241 report.
17630 2004-09-10 Raja R Harinath <rharinath@novell.com>
17632 * cs-parser.jay (fixed_statement): Introduce a scope for the
17633 declaration in the 'fixed' statement.
17635 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17637 * cs-parser.jay: Added CS0230 error report.
17639 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17641 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17643 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17645 * expression.cs (Argument.Resolve): Added error CS0192 and
17648 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17650 C# 2.0 #pragma warning feature
17652 * cs-tokenizer.cs (PreProcessPragma): New method;
17653 Handles #pragma directive.
17655 * report.cs (WarningRegions): New class; Support
17656 class for #pragma warning directive. It tests whether
17657 warning is enabled for a given line.
17659 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17661 * const.cs: Add more descriptive error report, tahnks to
17664 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17666 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17668 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17670 * expression.cs: Apply patch from Ben: Remove dead code from
17671 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17672 as that code just threw an exception anwyays.
17674 * const.cs: Remove the call to the turnintoconstant, for details
17677 * literal.cs: The type of the null-literal is the null type; So
17678 we use a placeholder type (literal.cs:System.Null, defined here)
17681 * expression.cs (Conditional.DoResolve): Remove some old code that
17682 is no longer needed, conversions have been fixed.
17684 (ArrayCreationExpression.DoResolve): Return false if we fail to
17685 resolve the inner expression.
17687 2004-09-07 Raja R Harinath <rharinath@novell.com>
17690 * cs-parser.jay (delegate_declaration): Record a delegate
17691 declaration as a type declaration.
17692 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17694 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17696 * parameter.cs: Do not crash if the type can not be resolved.
17698 * expression.cs: Report errors with unsafe pointers, fixes #64896
17700 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17702 * expression.cs: Pointer arith always needs to do a conv.i
17703 if the operand is a long. fix 65320
17705 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17707 Fixed cs0619-37.cs, cs0619-38.cs
17709 * enum.cs (GetObsoleteAttribute): Removed.
17711 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17712 on Enum member is double staged. The first is tested member
17715 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17717 Fixed #56986, #63631, #65231
17719 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17720 adds member to name container.
17721 (TypeContainer.AddToTypeContainer): New method, adds type to
17723 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17724 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17725 AddOperator): Simplified by reusing AddToMemberContainer.
17726 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17728 (Method.CheckForDuplications): Fixed implementation to test all
17730 (MemberBase): Detection whether member is explicit interface
17731 implementation is now in constructor.
17732 (MemberBase.UpdateMemberName): Handles IndexerName.
17733 (Accessor): Changed to keep also location information.
17734 (AbstractPropertyEventMethod): Is derived from MemberCore.
17735 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17736 will be emited or not.
17737 (PropertyBase.AreAccessorsDuplicateImplementation):
17738 Tests whether accessors are not in collision with some method.
17739 (Operator): Is derived from MethodCore to simplify common
17742 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17744 (DeclSpace.AddToContainer): Adds the member to defined_names
17745 table. It tests for duplications and enclosing name conflicts.
17747 * enum.cs (EnumMember): Clean up to reuse the base structures
17749 2004-09-03 Martin Baulig <martin@ximian.com>
17751 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17752 into TypeContainer, to make partial classes work again.
17754 2004-09-03 Martin Baulig <martin@ximian.com>
17756 * rootcontext.cs (RootContext.V2): Removed.
17758 2004-03-23 Martin Baulig <martin@ximian.com>
17760 * expression.cs (Invocation.OverloadResolve): Added `bool
17761 may_fail' argument and use it instead of the Location.IsNull() hack.
17763 2004-09-03 Martin Baulig <martin@ximian.com>
17765 Merged latest changes into gmcs. Please keep this comment in
17766 here, it makes it easier for me to see what changed in MCS since
17767 the last time I merged.
17769 2004-09-03 Raja R Harinath <rharinath@novell.com>
17772 * expression.cs (BetterConversion): Don't allow either conversion
17773 to be null. Remove redundant implicit conversion test when 'q ==
17774 null' -- when this function is invoked, we already know that the
17775 implicit conversion exists.
17776 (BetterFunction): Assume that 'best' is non-null. Remove
17777 redundant reimplementation of IsApplicable when 'best' is null.
17778 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17779 number of arguments.
17780 (IsAncestralType): Extract from OverloadResolve.
17781 (OverloadResolve): Make robust to the MethodGroupExpr being
17782 unsorted. Implement all the logic of Section 14.5.5.1, and
17783 support overloading of methods from multiple applicable types.
17784 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17786 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17787 (RealError, Warning): Append type of report to related symbol.
17789 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17791 * enum.cs: Fixed CLS-Compliance checks for enum members.
17792 Error tests cs3008-8.cs, cs3014-8.cs
17794 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17796 Fixed bug #62342, #63102
17797 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17798 like ImplementMethod.
17800 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17802 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17805 2004-09-02 Martin Baulig <martin@ximian.com>
17807 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17808 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17811 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17813 C# 2.0 Static classes implemented
17815 * class.cs (TypeContainer): instance_constructors,
17816 initialized_fields, initialized_static_fields,
17817 default_constructor, base_inteface_types are protected to be
17818 accessible from StaticClass.
17819 (TypeContainer.DefineDefaultConstructor): New virtual method
17820 for custom default constructor generating
17821 (StaticClass): New class to handle "Static classes" feature.
17823 * cs-parser.jay: Handle static keyword on class like instance
17826 * driver.cs: Added "/langversion" command line switch with two
17827 options (iso-1, default).
17829 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17831 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17833 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17835 * delegate.cs: Style.
17837 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17839 * delegate.cs: Add seperate instance expr field for miguel.
17841 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17843 * PointerArithmetic (Resolve): make sure we are not doing
17844 pointer arith on void*. Also, make sure we are resolved
17845 by not setting eclass until resolve.
17847 All callers: Make sure that PointerArithmetic gets resolved.
17849 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17851 * ArrayCreation (LookupType): If the type does not resolve
17852 to an array, give an error.
17854 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17856 * statement.cs (Try.Resolve): Fixed bug #64222
17858 2004-08-27 Martin Baulig <martin@ximian.com>
17861 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17864 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17866 * ecore.cs (Constantify): Get underlying type via
17867 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17868 Windows in special cases.
17870 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17872 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17873 for obtaining also private methods.
17874 (GetRemoveMethod): Used GetRemoveMethod (true)
17875 for obtaining also private methods.
17877 2004-08-24 Martin Baulig <martin@ximian.com>
17879 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17880 MethodAttributes.HideBySig for operators.
17882 2004-08-23 Martin Baulig <martin@ximian.com>
17884 Back to the old error reporting system :-)
17886 * report.cs (Message): Removed.
17887 (Report.MessageData, ErrorData, WarningData): Removed.
17888 (Report.Error, Warning): Back to the old system.
17890 2004-08-23 Martin Baulig <martin@ximian.com>
17892 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17894 * class.cs (TypeContainer.ParentContainer): New public virtual
17895 method; replaces the explicit interface implementation.
17896 (ClassPart.ParentContainer): Override.
17898 2004-08-23 Martin Baulig <martin@ximian.com>
17900 * statement.cs (Switch): Added support for constant switches; see
17901 #59428 or test-285.cs.
17903 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17906 * statement.cs (GetEnumeratorFilter): Removed useless
17907 logic because C# specs is strict. GetEnumerator must be
17910 2004-08-22 Martin Baulig <martin@ximian.com>
17912 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17913 a switch and may break, reset the barrier. Fixes #59867.
17915 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17917 CLS-Compliance speed up (~5% for corlib)
17919 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17920 New method. Tests container for CLS-Compliant names
17922 * class.cs (TypeContainer.VerifyClsName): New method.
17923 Checks whether container name is CLS Compliant.
17924 (Constructor): Implements IMethodData.
17926 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17927 low-case table for CLS Compliance test.
17928 (MemberCache.VerifyClsParameterConflict): New method.
17929 Checks method parameters for CS3006 error.
17931 * enum.cs (EnumMember): Is derived from MemberCore.
17932 (Enum.VerifyClsName): Optimized for better performance.
17934 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17936 * report.cs: Renamed Error_T to Error and changed all
17939 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17941 * class.cs (TypeContainer.IndexerArrayList): New inner class
17942 container for indexers.
17943 (TypeContainer.DefaultIndexerName): New constant for default
17944 indexer name. Replaced all "Item" with this constant.
17945 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17947 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17948 DefaultMemberAttribute constructor.
17950 2004-08-05 Martin Baulig <martin@ximian.com>
17952 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17955 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17957 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17958 multi platforms problem.
17960 * compiler.csproj: Included shared files.
17962 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17964 Fix bug 60333, 55971 in the more general way
17965 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17966 Added arg_type argument for constant conversion.
17967 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17969 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17972 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17973 OperatorArrayList, MethodCoreArrayList for typecontainer
17974 containers. Changed class member types to these new types.
17975 (MethodArrayList.DefineMembers): Added test for CS0659.
17977 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17979 * cfold.cs: Synchronize the folding with the code in expression.cs
17980 Binary.DoNumericPromotions for uint operands.
17982 * attribute.cs: Revert patch from Raja, it introduced a regression
17983 while building Blam-1.2.1 (hard to isolate a test case).
17985 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17989 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17991 (MethodCore.parent_method): New member. The method we're overriding
17992 if this is an override method.
17993 (MethodCore.CheckBase): Moved from Method class and made common.
17994 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17996 (MethodCore.CheckForDuplications): New abstract method. For custom
17997 member duplication search in a container
17998 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17999 method and its return type.
18000 (Event.conflict_symbol): New member. Symbol with same name in the
18004 (MemberCache.FindMemberWithSameName): New method. The method
18005 is looking for conflict with inherited symbols.
18007 2004-08-04 Martin Baulig <martin@ximian.com>
18009 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
18011 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
18013 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18015 * report.cs (Message): New enum for better error, warning reference in
18017 (MessageData): New inner abstract class. It generally handles printing of
18018 error and warning messages.
18019 Removed unused Error, Warning, Message methods.
18021 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18023 Fix for cs0592-8.cs test
18025 (Attributable.ValidAttributeTargets): Made public.
18026 (Attribute.ExplicitTarget): New member for explicit target value.
18027 (Attribute.CheckTargets): Now we translate explicit attribute
18028 target to Target here.
18030 2004-08-03 Ben Maurer <bmaurer@ximian.com>
18032 * ecore.cs (MethodGroupExpr): new IsBase property.
18034 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
18036 * delegate.cs (DelegateCreation): store a MethodGroupExpr
18037 rather than an instance expr.
18039 (DelegateCreation.Emit): Use the method group rather than
18040 the instance expression. Also, if you have base.Foo as the
18041 method for a delegate, make sure to emit ldftn, not ldftnvirt.
18043 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
18045 (NewDelegate.DoResolve): Only check for the existance of Invoke
18046 if the method is going to be needed. Use MethodGroupExpr.
18048 (NewDelegate.Emit): Remove, DelegateCreation implements this.
18050 * expression.cs: For pointer arith., make sure to use
18051 the size of the type, not the size of the pointer to
18054 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18057 * class.cs (Class): Added error CS0502 test.
18059 2004-08-03 John Luke <jluke@cfl.rr.com>
18060 Raja R Harinath <rharinath@novell.com>
18063 * attribute.cs (Attribute.complained_before): New flag.
18064 (Attribute.ResolveType, Attribute.Resolve),
18065 (Attribute.DefinePInvokeMethod): Set it.
18066 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
18068 2004-08-03 Martin Baulig <martin@ximian.com>
18070 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
18071 use a user-defined operator; we still need to do numeric
18072 promotions in case one argument is a builtin type and the other
18073 one has an implicit conversion to that type. Fixes #62322.
18075 2004-08-02 Martin Baulig <martin@ximian.com>
18077 * statement.cs (LocalInfo.Flags): Added `IsThis'.
18078 (LocalInfo.IsThis): New public property.
18079 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
18081 2004-08-01 Martin Baulig <martin@ximian.com>
18083 * class.cs (TypeContainer.GetClassBases): Don't set the default
18084 here since we may get called from GetPartialBases().
18085 (TypeContainer.DefineType): If GetClassBases() didn't return a
18086 parent, use the default one.
18088 2004-07-30 Duncan Mak <duncan@ximian.com>
18090 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
18092 2004-07-30 Martin Baulig <martin@ximian.com>
18094 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
18096 * class.cs (SourceMethod): New public class, derive from the
18097 symbol writer's ISourceMethod.
18098 (Method): Use the new symbol writer API.
18100 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
18101 as argument and use the new symbol writer.
18104 (SourceFile): Implement the symbol writer's ISourceFile.
18105 (Location.SymbolDocument): Removed.
18106 (Location.SourceFile): New public property.
18108 * symbolwriter.cs: Use the new symbol writer API.
18110 2004-07-30 Raja R Harinath <rharinath@novell.com>
18112 * Makefile (install-local): Remove. Functionality moved to
18115 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
18117 * Makefile: Install mcs.exe.config file together with mcs.exe.
18118 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
18119 correct runtime version.
18121 2004-07-25 Martin Baulig <martin@ximian.com>
18124 (TypeContainer.RegisterOrder): Removed, this was unused.
18125 (TypeContainer, interface_order): Removed.
18126 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
18127 TypeContainer as argument since we can also be called with a
18128 `PartialContainer' for a partial class/struct/interface.
18129 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
18130 of checking whether we're an `Interface' - we could be a
18131 `PartialContainer'.
18132 (PartialContainer.Register): Override; call
18133 AddClass()/AddStruct()/AddInterface() on our parent.
18135 * cs-parser.jay (interface_member_declaration): Add things to the
18136 `current_container', not the `current_class'.
18138 * rootcontext.cs (RegisterOrder): The overloaded version which
18139 takes an `Interface' was unused, removed.
18141 * typemanager.cs (TypeManager.LookupInterface): Return a
18142 `TypeContainer', not an `Interface'.
18143 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
18144 contain a `PartialContainer' for an interface, so check it's
18145 `Kind' to figure out what it is.
18147 2004-07-25 Martin Baulig <martin@ximian.com>
18149 * class.cs (Class.DefaultTypeAttributes): New public constant.
18150 (Struct.DefaultTypeAttributes): Likewise.
18151 (Interface.DefaultTypeAttributes): Likewise.
18152 (PartialContainer.TypeAttr): Override this and add the
18153 DefaultTypeAttributes.
18155 2004-07-25 Martin Baulig <martin@ximian.com>
18157 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
18158 we can just use the `Parent' field instead.
18160 2004-07-25 Martin Baulig <martin@ximian.com>
18162 * class.cs (TypeContainer.Emit): Renamed to EmitType().
18164 2004-07-25 Martin Baulig <martin@ximian.com>
18166 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
18167 our parts before defining any methods.
18168 (TypeContainer.VerifyImplements): Make this virtual.
18169 (ClassPart.VerifyImplements): Override and call VerifyImplements()
18170 on our PartialContainer.
18172 2004-07-25 Martin Baulig <martin@ximian.com>
18174 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
18176 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
18177 argument, we can just use the `Parent' field instead.
18180 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
18181 (MemberBase.DoDefine): Likewise.
18183 2004-07-24 Martin Baulig <martin@ximian.com>
18185 * decl.cs (MemberCore.Parent): New public field.
18186 (DeclSpace.Parent): Moved to MemberCore.
18188 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
18189 (MemberBase.ctor): Added TypeContainer argument, pass it to our
18191 (FieldBase, Field, Operator): Likewise.
18192 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
18193 (EventField, Event): Likewise.
18195 2004-07-23 Martin Baulig <martin@ximian.com>
18197 * class.cs (PartialContainer): New public class.
18198 (ClassPart): New public class.
18199 (TypeContainer): Added support for partial classes.
18200 (TypeContainer.GetClassBases): Splitted some of the functionality
18201 out into GetNormalBases() and GetPartialBases().
18203 * cs-tokenizer.cs (Token.PARTIAL): New token.
18204 (Tokenizer.consume_identifier): Added some hacks to recognize
18205 `partial', but only if it's immediately followed by `class',
18206 `struct' or `interface'.
18208 * cs-parser.jay: Added support for partial clases.
18210 2004-07-23 Martin Baulig <martin@ximian.com>
18212 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
18213 a `DeclSpace' and also made it readonly.
18214 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
18215 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
18216 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
18218 * cs-parser.jay: Pass the `current_class', not the
18219 `current_container' (at the moment, this is still the same thing)
18220 to a new Method, Property, Event, Indexer or Constructor.
18222 2004-07-23 Martin Baulig <martin@ximian.com>
18224 * cs-parser.jay (CSharpParser): Added a new `current_class' field
18225 and removed the `current_interface' one.
18226 (struct_declaration, class_declaration, interface_declaration):
18227 Set `current_class' to the newly created class/struct/interface;
18228 set their `Bases' and call Register() before parsing their body.
18230 2004-07-23 Martin Baulig <martin@ximian.com>
18232 * class.cs (Kind): New public enum.
18233 (TypeContainer): Made this class abstract.
18234 (TypeContainer.Kind): New public readonly field.
18235 (TypeContainer.CheckDef): New public method; moved here from
18237 (TypeContainer.Register): New public abstract method.
18238 (TypeContainer.GetPendingImplementations): New public abstract
18240 (TypeContainer.GetClassBases): Removed the `is_class' and
18241 `is_iface' parameters.
18242 (TypeContainer.DefineNestedTypes): Formerly known as
18244 (ClassOrStruct): Made this class abstract.
18246 * tree.cs (RootTypes): New public type.
18248 2004-07-20 Martin Baulig <martin@ximian.com>
18250 * tree.cs (Tree.RecordNamespace): Removed.
18251 (Tree.Namespaces): Removed.
18253 * rootcontext.cs (RootContext.IsNamespace): Removed.
18255 * cs-parser.jay (namespace_declaration): Just create a new
18256 NamespaceEntry here.
18258 2004-07-20 Martin Baulig <martin@ximian.com>
18260 * statement.cs (ExceptionStatement): New abstract class. This is
18261 now used as a base class for everyone who's using `finally'.
18262 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
18263 our local variables before using them.
18265 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
18266 virtual method. This is used by Yield.Resolve() to "steal" an
18267 outer block's `finally' clauses.
18268 (FlowBranchingException): The .ctor now takes an ExceptionStatement
18271 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
18272 version which takes an ExceptionStatement. This version must be
18273 used to create exception branchings.
18276 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
18277 (Iterator.EmitMoveNext): Added exception support; protect the
18278 block with a `fault' clause, properly handle 'finally' clauses.
18279 (Iterator.EmitDispose): Run all the `finally' clauses here.
18281 2004-07-20 Martin Baulig <martin@ximian.com>
18283 * iterator.cs: This is the first of a set of changes in the
18284 iterator code. Match the spec more closely: if we're an
18285 IEnumerable, then GetEnumerator() must be called. The first time
18286 GetEnumerator() is called, it returns the current instance; all
18287 subsequent invocations (if any) must create a copy.
18289 2004-07-19 Miguel de Icaza <miguel@ximian.com>
18291 * expression.cs: Resolve the constant expression before returning
18294 2004-07-19 Martin Baulig <martin@ximian.com>
18296 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
18297 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
18298 the return type of the new EmitContext.
18300 2004-07-18 Martin Baulig <martin@ximian.com>
18302 * class.cs (Property.Define): Fix iterators.
18304 * iterators.cs (Iterator.Define): Moved the
18305 `container.AddInterator (this)' call here from the .ctor; only do
18306 it if we resolved successfully.
18308 2004-07-17 Miguel de Icaza <miguel@ximian.com>
18310 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
18311 `true' for preprocessing directives that we parse. The return
18312 value indicates whether we should return to regular tokenizing or
18313 not, not whether it was parsed successfully.
18315 In the past if we were in: #if false ... #line #endif, we would
18316 resume parsing after `#line'. See bug 61604.
18318 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18319 building: IsEnumType should return true only for enums, not for
18320 enums or System.Enum itself. This fixes #61593.
18322 Likely what happened is that corlib was wrong: mcs depended on
18323 this bug in some places. The bug got fixed, we had to add the
18324 hack, which caused bug 61593.
18326 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18327 that was a workaround for the older conditions.
18329 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18331 * assign.cs: IAssignMethod has a new interface, as documented
18332 inline. All assignment code now uses this new api.
18334 * ecore.cs, expression.cs: All classes which implement
18335 IAssignMethod now use the new interface.
18337 * expression.cs (Invocation): add a hack to EmitCall so that
18338 IndexerAccess can be the target of a compound assignment without
18339 evaluating its arguments twice.
18341 * statement.cs: Handle changes in Invocation api.
18343 2004-07-16 Martin Baulig <martin@ximian.com>
18345 * iterators.cs: Rewrote this. We're now using one single Proxy
18346 class for both the IEnumerable and the IEnumerator interface and
18347 `Iterator' derives from Class so we can use the high-level API.
18349 * class.cs (TypeContainer.AddIterator): New method.
18350 (TypeContainer.DoDefineType): New protected virtual method, which
18351 is called from DefineType().
18352 (TypeContainer.DoDefineMembers): Call DefineType() and
18353 DefineMembers() on all our iterators.
18354 (TypeContainer.Emit): Call Emit() on all our iterators.
18355 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18357 * codegen.cs (EmitContext.CurrentIterator): New public field.
18359 2004-07-15 Martin Baulig <martin@ximian.com>
18362 (TypeManager.not_supported_exception_type): New type.
18364 2004-07-14 Martin Baulig <martin@ximian.com>
18366 * iterators.cs: Use real error numbers.
18368 2004-07-14 Martin Baulig <martin@ximian.com>
18370 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18371 requires this to be a System.Collection.IEnumerable and not a
18372 class implementing that interface.
18373 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18375 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18377 * class.cs: Fixed previous fix, it broke some error tests.
18379 2004-07-12 Martin Baulig <martin@ximian.com>
18381 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18384 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18386 * assign.cs (LocalTemporary): Add new argument: is_address,If
18387 `is_address' is true, then the value that we store is the address
18388 to the real value, and not the value itself.
18390 * ecore.cs (PropertyExpr): use the new local temporary
18391 stuff to allow us to handle X.Y += z (where X is a struct)
18393 2004-07-08 Martin Baulig <martin@ximian.com>
18395 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18396 not always return, just like we're doing in Using.Resolve().
18398 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18400 * cs-parser.jay (fixed_statement): flag this as Pinned.
18402 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18404 * typemanager.cs (TypeManager): Removed MakePinned method, this
18405 mechanism is replaced with the .NET 2.x compatible mechanism of
18406 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18408 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18409 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18410 `IsFixed' property which has a different meaning.
18412 2004-07-02 Raja R Harinath <rharinath@novell.com>
18414 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18415 visible from inside a nested class, not just the names of the
18416 immediately enclosing class.
18417 Fix for bug #60730.
18419 2004-06-24 Raja R Harinath <rharinath@novell.com>
18421 * expression.cs (BetterConversion): Remove buggy special-case
18422 handling of "implicit constant expression conversions". At this
18423 point, we already know that the conversion is possible -- we're
18424 only checking to see which is better.
18426 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18428 * cs-parser.jay: Added error CS0210 test.
18430 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18432 * cs-parser.jay: Added error CS0134 test.
18434 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18437 * cs-parser.jay: Added error CS0145 test.
18439 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18441 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18443 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18445 * expression.cs (StackAlloc.Resolve): The argument may not
18446 be a constant; deal with this case.
18448 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18450 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18451 GetIndexerAttributeValue.
18452 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18454 * class.cs (Indexer.Define): Added error tests for CS0415,
18457 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18459 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18462 2004-06-23 Martin Baulig <martin@ximian.com>
18464 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18465 neither return nor throw, reset the barrier as well. Fixes #60457.
18467 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18469 * class.cs : EventAttributes is now set to None by default.
18470 This fixes bug #60459.
18472 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18475 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18476 Don't throw exception but return null (it's sufficient now).
18478 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18480 * typemanager.cs (GetArgumentTypes): Faster implementation.
18482 2004-06-18 Martin Baulig <martin@ximian.com>
18484 * attribute.cs (Attribute.Resolve): Check whether we're an
18485 EmptyCast which a Constant child. Fixes #60333.
18487 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18489 * statement.cs (EmitCollectionForeach): Account for the fact that
18490 not all valuetypes are in areas which we can take the address of.
18491 For these variables, we store to a temporary variable. Also, make
18492 sure that we dont emit a `callvirt' on a valuetype method.
18494 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18496 * expression.cs (StackAlloc.DoReSolve): Added test for
18497 negative parameter (CS0247).
18499 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18502 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18504 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18507 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18510 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18512 Fix bug #58254 & cs1555.cs, cs1556.cs
18513 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18515 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18517 * cs-parser.jay: Added error CS1669 test for indexers.
18519 2004-06-11 Martin Baulig <martin@ximian.com>
18521 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18522 call this twice: for params and varargs methods.
18524 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18527 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18529 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18531 * attribute.cs (Attribute.GetValidTargets): Made public.
18534 (AbstractPropertyEventMethod): New class for better code sharing.
18535 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18537 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18539 2004-06-11 Raja R Harinath <rharinath@novell.com>
18542 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18543 that the call to Resolve is part of a MemberAccess.
18544 (Expression.Resolve): Use it for SimpleName resolution.
18545 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18546 Add 'intermediate' boolean argument.
18547 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18548 error message when the SimpleName can be resolved ambiguously
18549 between an expression and a type.
18550 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18552 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18553 call on the left-side.
18555 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18558 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18560 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18562 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18564 2004-06-11 Martin Baulig <martin@ximian.com>
18566 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18567 varargs methods if applicable.
18569 2004-06-11 Martin Baulig <martin@ximian.com>
18571 * expression.cs (Invocation.EmitCall): Don't use
18572 `method.CallingConvention == CallingConventions.VarArgs' since the
18573 method could also have `CallingConventions.HasThis'.
18575 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18577 * class.cs (Event.GetSignatureForError): Implemented.
18578 Fixed crash in error test cs3010.cs
18580 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18582 * cs-tokenizer.cs: Change the way we track __arglist to be
18583 consistent with the other keywords.
18585 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18587 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18590 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18592 * codegen.cs: Check that all referenced assemblies have a strongname
18593 before strongnaming the compiled assembly. If not report error CS1577.
18594 Fix bug #56563. Patch by Jackson Harper.
18595 * typemanager.cs: Added a method to return all referenced assemblies.
18596 Fix bug #56563. Patch by Jackson Harper.
18598 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18601 (Method.ApplyAttributeBuilder): Moved and added conditional
18602 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18605 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18607 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18610 * class.cs: (EventField.attribute_targets): Changed default target.
18612 2004-06-08 Martin Baulig <martin@ximian.com>
18614 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18616 2004-06-08 Martin Baulig <martin@ximian.com>
18618 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18620 2004-06-07 Martin Baulig <martin@ximian.com>
18622 Added support for varargs methods.
18624 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18627 * cs-parser.jay: Added support for `__arglist'.
18629 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18631 * expression.cs (Argument.AType): Added `ArgList'.
18632 (Invocation): Added support for varargs methods.
18633 (ArglistAccess): New public class.
18634 (Arglist): New public class.
18636 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18638 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18639 a method's top-level block if the method has varargs.
18641 * support.cs (ReflectionParameters, InternalParameters): Added
18642 support for varargs methods.
18644 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18646 * class.cs: Provide location in indexer error report.
18648 * driver.cs: Use standard names.
18650 * namespace.cs: Catch the use of using after a namespace has been
18651 declared also on using aliases.
18653 2004-06-03 Raja R Harinath <rharinath@novell.com>
18656 * typemanager.cs (closure_private_ok, closure_invocation_type)
18657 (closure_qualifier_type, closure_invocation_assembly)
18658 (FilterWithClosure): Move to ...
18659 (Closure): New internal nested class.
18660 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18661 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18662 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18663 (MemberLookup, MemberLookupFailed): Use it.
18664 * expression.cs (New.DoResolve): Treat the lookup for the
18665 constructor as being qualified by the 'new'ed type.
18666 (Indexers.GetIndexersForTypeOrInterface): Update.
18668 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18671 (GetConditionalAttributeValue): New method. Returns
18672 condition of ConditionalAttribute.
18673 (SearchMulti): New method. Returns all attributes of type 't'.
18674 Use it when attribute is AllowMultiple = true.
18675 (IsConditionalMethodExcluded): New method.
18678 (Method.IsExcluded): Implemented. Returns true if method has conditional
18679 attribute and the conditions is not defined (method is excluded).
18680 (IMethodData): Extended interface for ConditionalAttribute support.
18681 (PropertyMethod.IsExcluded): Implemented.
18684 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18687 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18690 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18692 * expression.cs (ArrayCreationExpression): Make this just an
18693 `expression'. It can't be a statement, so the code here was
18696 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18699 * typemanager.cs (GetFullNameSignature): New method for
18702 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18705 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18706 Use this method when MethodBuilder is null.
18707 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18708 Added test for error CS0626 (MONO reports error for this situation).
18709 (IMethodData.GetSignatureForError): Extended interface.
18711 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18714 (AttributeTester.GetObsoleteAttribute): Returns instance of
18715 ObsoleteAttribute when type is obsolete.
18718 (TypeContainer.VerifyObsoleteAttribute): Override.
18719 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18720 (MethodCode.VerifyObsoleteAttribute): Override.
18721 (MemberBase.VerifyObsoleteAttribute): Override.
18724 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18725 and report proper error.
18728 Delegate.VerifyObsoleteAttribute): Override.
18731 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18732 and report proper error.
18733 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18736 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18740 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18741 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18742 Added test for ObsoleteAttribute.
18745 (Catch): Derived from Statement.
18747 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18749 Fixed bug #59071 & cs0160.cs
18751 * statement.cs (Try.Resolve): Check here whether order of catch
18752 clauses matches their dependencies.
18754 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18756 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18757 caused a regression: #59343. Referencing nested classes from an
18758 assembly stopped working.
18760 2004-05-31 Martin Baulig <martin@ximian.com>
18762 MCS is now frozen for beta 2.
18764 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18766 * convert.cs: add a trivial cache for overload operator resolution.
18768 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18770 * decl.cs: If possible, use lookuptypedirect here. We can only do
18771 this if there is no `.' after the namespace. Avoids using
18772 LookupType, which does lots of slow processing.
18773 (FindNestedType) New method, does what it says :-).
18774 * namespace.cs: use LookupTypeDirect.
18775 * rootcontext.cs: use membercache, if possible.
18776 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18778 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18781 According to the spec,
18783 In a member access of the form E.I, if E is a single identifier,
18784 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18785 field, property, localvariable, or parameter with the same type as
18786 the meaning of E as a type-name (§3.8), then both possible
18787 meanings of E are permitted.
18789 We did not check that E as a simple-name had the same type as E as
18792 This trivial check gives us 5-7% on bootstrap time.
18794 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18796 * expression.cs (Invocation.OverloadResolve): Avoid the
18797 use of hashtables and boxing here by allocating on demand.
18799 2004-05-30 Martin Baulig <martin@ximian.com>
18801 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18802 we're doing a silent lookup. Don't try to lookup nested types in
18803 TypeManager.object_type (thanks to Ben Maurer).
18805 2004-05-30 Martin Baulig <martin@ximian.com>
18807 Committing a patch from Ben Maurer.
18809 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18811 2004-05-29 Martin Baulig <martin@ximian.com>
18813 * class.cs (IMethodData.ShouldIgnore): New method.
18815 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18816 `Location' argument, we don't need it anywhere. Use
18817 `IMethodData.ShouldIgnore ()' instead of
18818 `MethodData.GetMethodFlags ()'.
18819 (TypeManager.AddMethod): Removed.
18820 (TypeManager.AddMethod2): Renamed to AddMethod.
18822 2004-05-29 Martin Baulig <martin@ximian.com>
18824 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18826 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18827 converting from a class type S to an interface type and we already
18828 have an object on the stack, don't box it again. Fixes #52578.
18830 2004-05-29 Martin Baulig <martin@ximian.com>
18832 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18833 Added support for `params' parameters. Fixes #59267.
18835 2004-05-29 Martin Baulig <martin@ximian.com>
18837 * literal.cs (NullPointer): Provide a private .ctor which sets
18838 `type' to TypeManager.object_type. Fixes #59048.
18840 2004-05-29 Martin Baulig <martin@ximian.com>
18842 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18843 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18845 * ecore.cs (EventExpr.instance_expr): Make the field private.
18847 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18849 Fixed bug #50080 & cs0214-2.cs
18850 * expression.cs (Cast.DoResolve): Check unsafe context here.
18852 * statement.cs (Resolve.DoResolve): Likewise.
18854 2004-05-26 Martin Baulig <martin@ximian.com>
18856 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18858 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18859 (RootContext.LookupType): Pass down the `silent' flag.
18861 2004-05-25 Martin Baulig <martin@ximian.com>
18864 (MethodGroupExpr.IdenticalTypeName): New public property.
18865 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18866 expression actually refers to a type.
18868 2004-05-25 Martin Baulig <martin@ximian.com>
18870 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18871 for #56176 and made it actually work.
18873 2004-05-25 Martin Baulig <martin@ximian.com>
18875 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18876 (FieldExpr, PropertyExpr): Override and implement
18877 CacheTemporaries. Fixes #52279.
18879 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18881 * location.cs: In the new compiler listing a file twice is a
18882 warning, not an error.
18884 2004-05-24 Martin Baulig <martin@ximian.com>
18886 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18887 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18889 2004-05-24 Martin Baulig <martin@ximian.com>
18891 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18892 walking the `using' list. Fixes #53921.
18894 2004-05-24 Martin Baulig <martin@ximian.com>
18896 * const.cs (Const.LookupConstantValue): Added support for
18897 EmptyCast's; fixes #55251.
18899 2004-05-24 Martin Baulig <martin@ximian.com>
18901 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18902 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18903 which does the CS0135 check. The reason is that we first need to
18904 check whether the variable actually exists.
18906 2004-05-24 Martin Baulig <martin@ximian.com>
18908 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18909 than RootContext.LookupType() to find the explicit interface
18910 type. Fixes #58584.
18912 2004-05-24 Raja R Harinath <rharinath@novell.com>
18914 * Makefile: Simplify. Use executable.make.
18915 * mcs.exe.sources: New file. List of sources of mcs.exe.
18917 2004-05-24 Anders Carlsson <andersca@gnome.org>
18921 Use the invariant culture when doing String.Compare for CLS case
18924 2004-05-23 Martin Baulig <martin@ximian.com>
18926 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18927 don't have any dots. Fixes #52622, added cs0246-8.cs.
18929 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18931 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18933 * class.cs (MemberBase.Define): Reuse MemberType member for
18934 resolved type. Other methods can use it too.
18936 2004-05-23 Martin Baulig <martin@ximian.com>
18938 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18939 the variable also exists in the current block (otherwise, we need
18940 to report a CS0103). Fixes #58670.
18942 2004-05-23 Martin Baulig <martin@ximian.com>
18944 * flowanalysis.cs (Reachability.Reachable): Compute this
18945 on-the-fly rather than storing it as a field.
18947 2004-05-23 Martin Baulig <martin@ximian.com>
18949 * flowanalysis.cs (Reachability.And): Manually compute the
18950 resulting `barrier' from the reachability.
18952 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18955 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18956 instance of ObsoleteAttribute when symbol is obsolete.
18959 (IMethodData): Extended interface for ObsoleteAttribute support.
18961 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18963 * attribute.cs: Fix bug #55970
18965 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18969 (GetObsoleteAttribute): New method. Creates the instance of
18971 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18972 ObsoleteAttribute when member is obsolete.
18973 (AttributeTester.Report_ObsoleteMessage): Common method for
18974 Obsolete error/warning reporting.
18977 (TypeContainer.base_classs_type): New member for storing parent type.
18980 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18981 for this MemberCore.
18983 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18985 * attribute.cs, const.cs: Fix bug #58590
18987 2004-05-21 Martin Baulig <martin@ximian.com>
18989 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18990 out parameters if the end of the method is unreachable. Fixes
18993 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18995 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18996 Hari was right, why extra method.
18998 2004-05-21 Marek Safar <marek.safar@seznam.cz>
19000 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
19002 2004-05-20 Martin Baulig <martin@ximian.com>
19004 Merged this back from gmcs to keep the differences to a minumum.
19006 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
19007 instead of a Declspace.
19008 (Attribute.ResolveType): Likewise.
19009 (Attributes.Search): Likewise.
19010 (Attributes.Contains): Likewise.
19011 (Attributes.GetClsCompliantAttribute): Likewise.
19013 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
19015 (MethodData.ApplyAttributes): Take an EmitContext instead of a
19018 2004-05-19 Marek Safar <marek.safar@seznam.cz>
19020 Fix bug #58688 (MCS does not report error when the same attribute
19023 * attribute.cs (Attribute.Emit): Distinction between null and default.
19025 2004-05-19 Raja R Harinath <rharinath@novell.com>
19027 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
19028 of a top-level attribute without an attribute target.
19029 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
19031 (Attribute.Conditional_GetConditionName),
19032 (Attribute.Obsolete_GetObsoleteMessage): Update.
19033 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
19034 part of ScanForIndexerName.
19035 (Attribute.CanIgnoreInvalidAttribute): New function.
19036 (Attribute.ScanForIndexerName): Move to ...
19037 (Attributes.ScanForIndexerName): ... here.
19038 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
19039 (Attributes.Search): New internal variant that can choose not to
19040 complain if types aren't resolved. The original signature now
19042 (Attributes.GetClsCompliantAttribute): Use internal variant, with
19043 complaints suppressed.
19044 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
19045 only if it not useful.
19046 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
19047 top-level for attributes that are shared between the assembly
19048 and a top-level class.
19049 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
19050 * class.cs: Update to reflect changes.
19051 (DefineIndexers): Fuse loops.
19052 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
19053 a couple more variants of attribute names.
19055 2004-05-18 Marek Safar <marek.safar@seznam.cz>
19057 Fix bug #52585 (Implemented explicit attribute declaration)
19060 (Attributable.ValidAttributeTargets): New abstract method. It gets
19061 list of valid attribute targets for explicit target declaration.
19062 (Attribute.Target): It holds target itself.
19063 (AttributeSection): Removed.
19064 (Attribute.CheckTargets): New method. It checks whether attribute
19065 target is valid for the current element.
19068 (EventProperty): New class. For events that are declared like
19069 property (with add and remove accessors).
19070 (EventField): New class. For events that are declared like field.
19073 * cs-parser.jay: Implemented explicit attribute target declaration.
19075 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
19076 Override ValidAttributeTargets.
19079 (ReturnParameter): Class for applying custom attributes on
19081 (ParameterAtribute): New class. Class for applying custom
19082 attributes on the parameter type.
19084 2004-05-17 Miguel de Icaza <miguel@ximian.com>
19086 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
19089 (Method): Allow UNSAFE here.
19091 * modifiers.cs: Support unsafe reporting.
19093 2004-05-17 Marek Safar <marek.safar@seznam.cz>
19095 * decl.cs: Fix bug #58478.
19097 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19099 * statement.cs: When checking for unreachable code on an EmptyStatement,
19100 set the location. Fixes bug #58488.
19102 2004-05-13 Miguel de Icaza <miguel@ximian.com>
19104 * driver.cs: Add -pkg handling.
19106 From Gonzalo: UseShelLExecute=false
19108 2004-05-12 Marek Safar <marek.safar@seznam.cz>
19111 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
19113 (Attribute.IsClsCompliaceRequired): Moved to base for better
19115 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
19116 when attribute is AttributeUsageAttribute.
19117 (Attribute.GetValidTargets): Simplified.
19118 (Attribute.GetAttributeUsage): New method returns AttributeUsage
19119 attribute for this type.
19120 (Attribute.ApplyAttributes): Method renamed to Emit and make
19122 (GlobalAttributeSection): New class for special handling of global
19123 attributes (assembly, module).
19124 (AttributeSection.Emit): New method.
19126 * class.cs: Implemented Attributable abstract methods.
19127 (MethodCore.LabelParameters): Moved to Parameter class.
19128 (Accessor): Is back simple class.
19129 (PropertyMethod): Implemented Attributable abstract class.
19130 (DelegateMethod): Implemented Attributable abstract class.
19131 (Event): New constructor for disctintion between normal Event
19132 and Event with accessors.
19134 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
19136 * codegen.cs, const.cs, decl.cs, delegate.cs:
19137 (CommonAssemblyModulClass): Implemented Attributable abstract class
19140 * enum.cs: Implement IAttributeSupport interface.
19141 (EnumMember): New class for emum members. Implemented Attributable
19145 (ParameterBase): Is abstract.
19146 (ReturnParameter): New class for easier [return:] attribute handling.
19148 * typemanager.cs: Removed builder_to_attr.
19150 2004-05-11 Raja R Harinath <rharinath@novell.com>
19153 * attribute.cs (Attribute.GetPositionalValue): New function.
19154 * class.cs (TypeContainer.VerifyMembers): New function.
19155 (TypeContainer.Emit): Use it.
19156 (ClassOrStruct): New base class for Class and Struct.
19157 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
19158 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
19160 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
19161 then each non-static field should have a FieldOffset attribute.
19162 Otherwise, none of the fields should have a FieldOffset attribute.
19163 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
19164 and FieldOffset attributes.
19165 * typemanager.cs (TypeManager.struct_layout_attribute_type)
19166 (TypeManager.field_offset_attribute_type): New core types.
19167 (TypeManager.InitCoreTypes): Initialize them.
19169 2004-05-11 Michal Moskal <malekith@pld-linux.org>
19171 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
19172 Return correct type.
19175 2004-05-09 Miguel de Icaza <miguel@ximian.com>
19177 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
19178 be implicitly converted to ulong.
19180 * expression.cs: The logic for allowing operator &, | and ^ worked
19181 was wrong, it worked before because we did not report an error in
19182 an else branch. Fixes 57895.
19184 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
19185 allow volatile fields to be reference types.
19187 2004-05-07 Miguel de Icaza <miguel@ximian.com>
19189 * driver.cs: Add support for /debug-
19191 2004-05-07 Raja R Harinath <rharinath@novell.com>
19193 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
19194 Add a 'complain' parameter to silence errors.
19195 (Attribute.Resolve): Update to changes. Put in sanity check to catch
19196 silently overlooked type-resolutions.
19197 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
19198 to reflect changes.
19199 (Attributes.Search): New function.
19200 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
19201 (Attributes.GetAttributeFullName): Remove hack.
19202 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
19203 Update to reflect changes.
19204 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
19205 Use Attributes.Search instead of nested loops.
19207 2004-05-07 Marek Safar <marek.safar@seznam.cz>
19210 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
19211 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
19212 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
19214 * report.cs: (Report.Warning): Renamed to Warning_T because of
19215 parameter collision.
19217 2004-05-05 Raja R Harinath <rharinath@novell.com>
19219 * expression.cs (MemberAccess.ResolveMemberAccess):
19220 Exit with non-zero status after Report.Error.
19221 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
19223 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
19225 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19227 * support.cs: Don't hang when the file is empty.
19229 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19231 * support.cs: In SeekableStreamReader, compute the preamble size of the
19232 underlying stream. Position changes should take into account that initial
19235 2004-05-03 Todd Berman <tberman@sevenl.net>
19237 * driver.cs: remove unused GetSysVersion function.
19239 2004-05-03 Todd Berman <tberman@sevenl.net>
19241 * driver.cs: Remove the hack from saturday, as well as the hack
19242 from jackson (LoadAssemblyFromGac), also adds the CWD to the
19243 link_paths to get that bit proper.
19245 2004-05-01 Todd Berman <tberman@sevenl.net>
19247 * driver.cs: Try a LoadFrom before a Load, this checks the current
19248 path. This is currently a bug in mono that is be fixed, however, this
19249 provides a workaround for now. This will be removed when the bug
19252 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
19254 * CryptoConvert.cs: Updated to latest version. Fix issue with
19255 incomplete key pairs (#57941).
19257 2004-05-01 Todd Berman <tberman@sevenl.net>
19259 * driver.cs: Remove '.' from path_chars, now System.* loads properly
19262 2004-04-30 Jackson Harper <jackson@ximian.com>
19264 * codegen.cs: Open keys readonly.
19266 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19268 * typemanager.cs: don't report cyclic struct layout when a struct
19269 contains 2 or more fields of the same type. Failed for Pango.AttrShape
19270 which has 2 Pango.Rectangle fields.
19272 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
19274 * expression.cs: Handle IntPtr comparisons with IL code
19275 rather than a method call.
19277 2004-04-29 Martin Baulig <martin@ximian.com>
19279 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
19280 the list of PropertyInfo's in class hierarchy and find the
19281 accessor. Fixes #56013.
19283 2004-04-29 Martin Baulig <martin@ximian.com>
19285 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
19287 2004-04-29 Martin Baulig <martin@ximian.com>
19289 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19291 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
19293 2004-04-29 Martin Baulig <martin@ximian.com>
19295 * class.cs (ConstructorInitializer.Resolve): Check whether the
19296 parent .ctor is accessible. Fixes #52146.
19298 2004-04-29 Martin Baulig <martin@ximian.com>
19300 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19302 * statement.cs (Using.EmitLocalVariableDecls): Use
19303 TypeManager.idisposable_type, not typeof (IDisposable).
19304 (Foreach.EmitCollectionForeach): Added support for valuetypes.
19306 2004-04-29 Martin Baulig <martin@ximian.com>
19308 * class.cs (Event.Define): Don't emit the field and don't set
19309 RTSpecialName and SpecialName for events on interfaces. Fixes
19312 2004-04-29 Raja R Harinath <rharinath@novell.com>
19314 Refactor Attribute.ApplyAttributes.
19315 * attribute.cs (Attributable): New base class for objects that can
19316 have Attributes applied on them.
19317 (Attribute): Make AttributeUsage fields public.
19318 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19319 (Attribute.IsInternalCall): New property.
19320 (Attribute.UsageAttr): Convert to a public read-only property.
19321 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19322 (Attribute.ResolveType, Attribute.Resolve)
19323 (Attribute.ScanForIndexerName): Update to reflect changes.
19324 (Attribute.CheckAttributeTarget): Re-format.
19325 (Attribute.ApplyAttributes): Refactor, to various
19326 Attributable.ApplyAttributeBuilder methods.
19327 * decl.cs (MemberCore): Make Attributable.
19328 * class.cs (Accessor): Make Attributable.
19329 (MethodData.ApplyAttributes): Use proper attribute types, not
19331 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19332 (TypeContainer.ApplyAttributeBuilder)
19333 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19334 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19335 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19336 (Operator.ApplyAttributeBuilder): New factored-out methods.
19337 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19338 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19339 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19340 * parameter.cs (ParameterBase): New Attributable base class
19341 that can also represent Return types.
19342 (Parameter): Update to the changes.
19344 2004-04-29 Jackson Harper <jackson@ximian.com>
19346 * driver.cs: Prefer the corlib system version when looking for
19347 assemblies in the GAC. This is still a hack, but its a better hack
19350 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19352 * decl.cs, enum.cs: Improved error 3005 reporting.
19354 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19355 (related_symbols): New private member for list of symbols
19356 related to reported error/warning.
19358 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19360 2004-04-29 Martin Baulig <martin@ximian.com>
19362 * ecore.cs (Expression.Constantify): If we're an enum and
19363 TypeManager.TypeToCoreType() doesn't give us another type, use
19364 t.UnderlyingSystemType. Fixes #56178.
19366 2004-04-29 Martin Baulig <martin@ximian.com>
19368 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19369 interfaces and for each interface, only add members directly
19370 declared in that interface. Fixes #53255.
19372 2004-04-28 Martin Baulig <martin@ximian.com>
19374 * expression.cs (ConditionalLogicalOperator): Use a temporary
19375 variable for `left' to avoid that we evaluate it more than once;
19378 2004-04-28 Martin Baulig <martin@ximian.com>
19380 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19383 2004-04-28 Martin Baulig <martin@ximian.com>
19385 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19388 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19389 whether the type is not void (CS1547).
19391 2004-04-28 Martin Baulig <martin@ximian.com>
19393 * expression.cs (Unary.DoResolveLValue): Override this and report
19394 CS0131 for anything but Operator.Indirection.
19396 2004-04-28 Martin Baulig <martin@ximian.com>
19398 Committing a patch from Ben Maurer; see bug #50820.
19400 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19403 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19406 2004-04-28 Martin Baulig <martin@ximian.com>
19408 Committing a patch from Ben Maurer; see bug #50820.
19410 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19413 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19416 2004-04-28 Martin Baulig <martin@ximian.com>
19418 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19419 (Block.AddLabel): Call DoLookupLabel() to only search in the
19422 2004-04-28 Martin Baulig <martin@ximian.com>
19424 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19425 comparing StringConstants and NullLiterals in Equality and Inequality.
19427 2004-04-28 Jackson Harper <jackson@ximian.com>
19429 * driver.cs: Attempt to load referenced assemblies from the
19430 GAC. This is the quick and dirty version of this method that
19431 doesnt take into account versions and just takes the first
19432 canidate found. Will be good enough for now as we will not have more
19433 then one version installed into the GAC until I update this method.
19435 2004-04-28 Martin Baulig <martin@ximian.com>
19437 * typemanager.cs (TypeManager.CheckStructCycles): New public
19438 static method to check for cycles in the struct layout.
19440 * rootcontext.cs (RootContext.PopulateTypes): Call
19441 TypeManager.CheckStructCycles() for each TypeContainer.
19442 [Note: We only need to visit each type once.]
19444 2004-04-28 Martin Baulig <martin@ximian.com>
19446 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19448 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19449 success and added `out object value'. Use a `bool resolved' field
19450 to check whether we've already been called rather than
19451 `ConstantValue != null' since this breaks for NullLiterals.
19453 2004-04-28 Raja R Harinath <rharinath@novell.com>
19455 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19456 setting of this flag, since the 'set' method may be non-public.
19458 2004-04-28 Raja R Harinath <rharinath@novell.com>
19460 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19461 check on current_vector.Block.
19463 2004-04-27 Martin Baulig <martin@ximian.com>
19465 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19466 a field initializer. Fixes #56459.
19468 2004-04-27 Martin Baulig <martin@ximian.com>
19470 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19471 we're not attempting to use an indexer. Fixes #52154.
19473 2004-04-27 Martin Baulig <martin@ximian.com>
19475 * statement.cs (Return): Don't create a return label if we don't
19476 need it; reverts my change from January 20th. Thanks to Ben
19479 2004-04-27 Martin Baulig <martin@ximian.com>
19481 According to the spec, `goto' can only leave a nested scope, but
19484 * statement.cs (Block.LookupLabel): Only lookup in the current
19485 block, don't recurse into parent or child blocks.
19486 (Block.AddLabel): Check in parent and child blocks, report
19487 CS0140/CS0158 if we find a duplicate.
19488 (Block): Removed this indexer for label lookups.
19489 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19490 this already does the error reporting for us.
19493 (FlowBranching.UsageVector.Block): New public variable; may be null.
19494 (FlowBranching.CreateSibling): Added `Block' argument.
19495 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19496 label for the target of a `goto' and check whether we're not
19497 leaving a `finally'.
19499 2004-04-27 Martin Baulig <martin@ximian.com>
19501 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19502 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19505 2004-04-27 Martin Baulig <martin@ximian.com>
19507 * statement.cs (Block.AddLabel): Also check for implicit blocks
19508 and added a CS0158 check.
19510 2004-04-27 Martin Baulig <martin@ximian.com>
19512 * flowanalysis.cs (FlowBranchingLoop): New class.
19513 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19514 UsageVector's instead of an ArrayList.
19515 (FlowBranching.Label): Likewise.
19516 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19517 (FlowBranching.AddBreakVector): New method.
19519 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19521 * attribute.cs: Small regression fix: only convert the type if we
19522 the type is different, fixes System.Drawing build.
19524 2004-04-27 Martin Baulig <martin@ximian.com>
19526 * attribute.cs (Attribute.Resolve): If we have a constant value
19527 for a named field or property, implicity convert it to the correct
19530 2004-04-27 Raja R Harinath <rharinath@novell.com>
19532 * statement.cs (Block.Block): Implicit blocks share
19533 'child_variable_names' fields with parent blocks.
19534 (Block.AddChildVariableNames): Remove.
19535 (Block.AddVariable): Mark variable as "used by a child block" in
19536 every surrounding block.
19537 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19538 been used in a child block, complain about violation of "Invariant
19539 meaning in blocks" rule.
19540 * cs-parser.jay (declare_local_variables): Don't use
19541 AddChildVariableNames.
19542 (foreach_statement): Don't create an implicit block: 'foreach'
19543 introduces a scope.
19545 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19547 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19548 converting from 0L to ulong. Fixes 57522.
19550 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19552 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19553 derived class hides via 'new' keyword field from base class (test-242.cs).
19554 TODO: Handle this in the more general way.
19556 * class.cs (CheckBase): Ditto.
19558 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19560 * decl.cs (caching_flags): New member for storing cached values
19562 (MemberCore.Flags): New enum where bit flags for caching_flags
19564 (MemberCore.cls_compliance): Moved to caching_flags.
19565 (DeclSpace.Created): Moved to caching_flags.
19567 * class.cs: Use caching_flags instead of DeclSpace.Created
19569 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19571 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19572 if we are only a derived class, not a nested class.
19574 * typemanager.cs: Same as above, but do this at the MemberLookup
19575 level (used by field and methods, properties are handled in
19576 PropertyExpr). Allow for the qualified access if we are a nested
19579 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19581 * class.cs: Refactoring.
19582 (IMethodData): New inteface; Holds links to parent members
19583 to avoid member duplication (reduced memory allocation).
19584 (Method): Implemented IMethodData interface.
19585 (PropertyBase): New inner classes for get/set methods.
19586 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19587 (Event): New inner classes for add/remove methods.
19588 (Event.DelegateMethod): Implemented IMethodData interface.
19590 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19591 EmitContext (related to class.cs refactoring).
19593 2004-04-21 Raja R Harinath <rharinath@novell.com>
19595 * delegate.cs (Delegate.VerifyApplicability): If the number of
19596 arguments are the same as the number of parameters, first try to
19597 verify applicability ignoring any 'params' modifier on the last
19601 2004-04-16 Raja R Harinath <rharinath@novell.com>
19603 * class.cs (TypeContainer.AddIndexer): Use
19604 'ExplicitInterfaceName' to determine if interface name was
19605 explicitly specified. 'InterfaceType' is not initialized at this time.
19606 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19607 Indexers array is already in the required order. Initialize
19608 'IndexerName' only if there are normal indexers.
19609 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19610 (TypeContainer.Emit): Emit DefaultMember attribute only if
19611 IndexerName is initialized.
19614 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19616 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19619 2004-04-15 Raja R Harinath <rharinath@novell.com>
19621 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19625 * attribute.cs (Attribute.Resolve): Check for duplicate named
19629 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19631 * iterators.cs (MarkYield): track whether we are in an exception,
19632 and generate code accordingly. Use a temporary value to store the
19633 result for our state.
19635 I had ignored a bit the interaction of try/catch with iterators
19636 since their behavior was not entirely obvious, but now it is
19637 possible to verify that our behavior is the same as MS .NET 2.0
19641 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19643 * iterators.cs: Avoid creating temporaries if there is no work to
19646 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19647 Enumerations, use TypeManager.EnumToUnderlying and call
19650 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19653 (This.Emit): Use EmitContext.EmitThis to emit our
19656 (This.EmitAssign): Ditto.
19658 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19659 codepaths, we will move all the functionality into
19662 (FieldExpr.EmitAssign): Ditto.
19664 This fixes several hidden bugs that I uncovered while doing a code
19665 review of this today.
19667 * codegen.cs (EmitThis): reworked so the semantics are more clear
19668 and also support value types "this" instances.
19670 * iterators.cs: Changed so that for iterators in value types, we
19671 do not pass the value type as a parameter.
19673 Initialization of the enumerator helpers is now done in the caller
19674 instead of passing the parameters to the constructors and having
19675 the constructor set the fields.
19677 The fields have now `assembly' visibility instead of private.
19679 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19681 * expression.cs (Argument.Resolve): Check if fields passed as ref
19682 or out are contained in a MarshalByRefObject.
19684 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19685 another compiler type.
19687 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19689 * class.cs (Indexer.Define): use the new name checking method.
19690 Also, return false on an error.
19691 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19692 (is_identifier_[start/part]_character): make static.
19694 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19696 * expression.cs (Binary.ResolveOperator): Do no append strings
19697 twice: since we can be invoked more than once (array evaluation)
19698 on the same concatenation, take care of this here. Based on a fix
19699 from Ben (bug #56454)
19701 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19703 * codegen.cs: Fix another case where CS1548 must be reported (when
19704 delay-sign isn't specified and no private is available #56564). Fix
19705 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19706 error when MCS is used on the MS runtime and we need to delay-sign
19707 (which seems unsupported by AssemblyBuilder - see #56621).
19709 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19711 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19712 (TypeManager.ComputeNamespaces): Faster implementation for
19715 * compiler.csproj: Updated AssemblyName to mcs.
19717 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19719 * rootcontext.cs: Add new types to the boot resolution.
19721 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19722 MulticastDelegate is not allowed.
19724 * typemanager.cs: Add new types to lookup: System.TypedReference
19727 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19728 check for TypedReference or ArgIterator, they are not allowed.
19730 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19731 makes us properly catch 1510 in some conditions (see bug 56016 for
19734 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19736 * CryptoConvert.cs: update from corlib version
19739 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19741 * class.cs (Indexer.Define): Check indexername declaration
19743 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19745 * attribute.cs (IsClsCompliant): Fixed problem with handling
19746 all three states (compliant, not-compliant, undetected).
19748 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19750 * attribute.cs (Attribute): Location is now public.
19751 (Resolve): Store resolved arguments (pos_values) in attribute class.
19752 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19753 (GetClsCompliantAttributeValue): New method that gets
19754 CLSCompliantAttribute value.
19755 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19756 if exists else null.
19757 (AttributeTester): New class for CLS-Compliant verification routines.
19759 * class.cs (Emit): Add CLS-Compliant verification.
19760 (Method.GetSignatureForError): Implemented.
19761 (Constructor.GetSignatureForError): Implemented
19762 (Constructor.HasCompliantArgs): Returns if constructor has
19763 CLS-Compliant arguments.
19764 (Constructor.Emit): Override.
19765 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19766 is needed to test only parameters.
19767 (FieldBase.GetSignatureForError): Implemented.
19768 (TypeContainer): New member for storing base interfaces.
19769 (TypeContainer.FindMembers): Search in base interfaces too.
19771 * codegen.cs (GetClsComplianceAttribute): New method that gets
19772 assembly or module CLSCompliantAttribute value.
19773 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19775 (ModuleClass.Emit): Add error 3012 test.
19777 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19779 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19780 state for all decl types.
19781 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19782 if CLS-Compliant tests are required.
19783 (IsClsCompliaceRequired): New method. Analyze whether code
19784 must be CLS-Compliant.
19785 (IsExposedFromAssembly): New method. Returns true when MemberCore
19786 is exposed from assembly.
19787 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19788 value or gets cached value.
19789 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19790 is explicitly marked with CLSCompliantAttribute.
19791 (IsIdentifierClsCompliant): New abstract method. This method is
19792 used to testing error 3005.
19793 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19794 for identifier and parameters CLS-Compliant testing.
19795 (VerifyClsCompliance): New method. The main virtual method for
19796 CLS-Compliant verifications.
19797 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19798 null. I don't know why is null (too many public members !).
19799 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19800 and get value of first CLSCompliantAttribute that found.
19802 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19803 (VerifyClsCompliance): Override and add extra tests.
19805 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19806 clscheck- disable CLS-Compliant verification event if assembly is has
19807 CLSCompliantAttribute(true).
19809 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19810 ApllyAttribute is now called in emit section as in the other cases.
19811 Possible future Emit integration.
19812 (IsIdentifierClsCompliant): New override.
19813 (VerifyClsCompliance): New override.
19814 (GetEnumeratorName): Returns full enum name.
19816 * parameter.cs (GetSignatureForError): Implemented.
19818 * report.cs (WarningData): New struct for Warning message information.
19819 (LocationOfPreviousError): New method.
19820 (Warning): New method. Reports warning based on the warning table.
19821 (Error_T): New method. Reports error based on the error table.
19823 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19824 verifications are done here.
19826 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19828 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19829 CLSCompliantAttribute.
19830 (all_imported_types): New member holds all imported types from other
19832 (LoadAllImportedTypes): New method fills static table with exported types
19833 from all referenced assemblies.
19834 (Modules): New property returns all assembly modules.
19836 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19838 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19839 throwing a parser error.
19841 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19842 which removes the hardcoded get_/set_ prefixes for properties, as
19843 IL allows for the properties to be named something else.
19847 * expression.cs: Do not override operand before we know if it is
19848 non-null. Fix 56207
19850 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19852 * typemanager.cs: support for pinned variables.
19854 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19856 * decl.cs, typemanager.cs: Avoid using an arraylist
19857 as a buffer if there is only one result set.
19859 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19861 * expression.cs: Make sure you cant call a static method
19862 with an instance expression, bug #56174.
19864 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19866 * class.cs (IsDuplicateImplementation): Improve error reporting to
19867 flag 663 (method only differs in parameter modifier).
19869 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19870 in preprocessor directives.
19872 * location.cs (LookupFile): Allow for the empty path.
19874 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19875 better approach for some of that patch, but its failing with the
19876 CharSet enumeration. For now try/catch will do.
19878 * typemanager.cs: Do not crash if a struct does not have fields.
19881 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19883 * expression.cs: cs0213, cant fix a fixed expression.
19886 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19888 * cs-parser.jay: detect invalid embeded statements gracefully.
19891 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19893 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19896 the invocation type may not be a subclass of the tye of the item/
19897 The type of the item must be a subclass of the invocation item.
19902 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19904 * attribute.cs: Added methods to get a string and a bool from an
19905 attribute. Required to information from AssemblyKeyFileAttribute,
19906 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19907 * codegen.cs: Modified AssemblyName creation to include support for
19908 strongnames. Catch additional exceptions to report them as CS1548.
19909 * compiler.csproj: Updated include CryptoConvert.cs.
19910 * compiler.csproj.user: Removed file - user specific configuration.
19911 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19912 Mono.Security assembly. The original class is maintained and tested in
19913 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19914 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19915 like CSC 8.0 (C# v2) supports.
19916 * Makefile: Added CryptoConvert.cs to mcs sources.
19917 * rootcontext.cs: Added new options for strongnames.
19919 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19921 * driver.cs: For --expect-error, report error code `2'
19922 if the program compiled with no errors, error code `1' if
19923 it compiled with an error other than the one expected.
19925 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19927 * compiler.csproj: Updated for Visual Studio .NET 2003.
19928 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19929 * compiler.sln: Updated for Visual Studio .NET 2003.
19931 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19933 * expression.cs: Fix bug #47234. We basically need to apply the
19934 rule that we prefer the conversion of null to a reference type
19935 when faced with a conversion to 'object' (csc behaviour).
19937 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19939 * statement.cs: Shorter form for foreach, eliminates
19940 a local variable. r=Martin.
19942 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19944 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19945 checks if we can use brtrue/brfalse to test for 0.
19946 * expression.cs: use the above in the test for using brtrue/brfalse.
19947 cleanup code a bit.
19949 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19951 * expression.cs: Rewrite string concat stuff. Benefits:
19953 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19954 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19955 rather than a concat chain.
19957 * typemanager.cs: Add lookups for more concat overloads.
19959 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19961 * expression.cs: Emit shorter il code for array init.
19978 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19980 * statement.cs: Before, two switch blocks would be merged if the
19981 total size of the blocks (end_item - begin_item + 1) was less than
19982 two times the combined sizes of the blocks.
19984 Now, it will only merge if after the merge at least half of the
19989 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19991 * class.cs : csc build fix for GetMethods(). See bug #52503.
19993 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19995 * expression.cs: Make sure fp comparisons work with NaN.
19996 This fixes bug #54303. Mig approved this patch a long
19997 time ago, but we were not able to test b/c the runtime
20000 2004-03-19 Miguel de Icaza <miguel@ximian.com>
20002 * ecore.cs (TypExpr.GetHashCode): implement this overload.
20004 2004-03-19 Martin Baulig <martin@ximian.com>
20006 * class.cs (MemberCore.IsDuplicateImplementation): Report the
20007 error here and not in our caller.
20009 2004-03-19 Martin Baulig <martin@ximian.com>
20011 * interface.cs: Completely killed this file.
20012 (Interface): We're now a TypeContainer and live in class.cs.
20014 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
20015 argument; we're now also called for interfaces.
20016 (TypeContainer.DefineMembers): Allow this method being called
20018 (TypeContainer.GetMethods): New public method; formerly known as
20019 Interface.GetMethod(). This is used by PendingImplementation.
20020 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
20021 it's now private and non-static.
20022 (Interface): Moved this here; it's now implemented similar to
20024 (Method, Property, Event, Indexer): Added `bool is_interface'
20025 argument to their .ctor's.
20026 (MemberBase.IsInterface): New public field.
20028 * cs-parser.jay: Create normal Method, Property, Event, Indexer
20029 instances instead of InterfaceMethod, InterfaceProperty, etc.
20030 (opt_interface_base): Removed; we now use `opt_class_base' instead.
20031 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
20033 2004-03-19 Martin Baulig <martin@ximian.com>
20035 * class.cs (MethodCore.IsDuplicateImplementation): New private
20036 method which does the CS0111 checking.
20037 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
20038 Use IsDuplicateImplementation().
20040 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
20042 * decl.cs (FindMemberToOverride): New method to find the correct
20043 method or property to override in the base class.
20045 - Make Method/Property use the above method to find the
20046 version in the base class.
20047 - Remove the InheritableMemberSignatureCompare as it is now
20050 This patch makes large code bases much faster to compile, as it is
20051 O(n) rather than O(n^2) to do this validation.
20053 Also, it fixes bug 52458 which is that nested classes are not
20054 taken into account when finding the base class member.
20056 Reviewed/Approved by Martin.
20058 2004-03-17 Marek Safar <marek.safar@seznam.cz>
20060 * interface.cs: In all interface classes removed redundant
20061 member initialization.
20063 2004-03-16 Martin Baulig <martin@ximian.com>
20065 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
20067 2004-03-15 Miguel de Icaza <miguel@ximian.com>
20069 * decl.cs (DefineTypeAndParents): New helper method to define a
20070 type's containers before the type itself is defined; This is a
20071 bug exposed by the recent changes to Windows.Forms when an
20072 implemented interface was defined inside a class that had not been
20075 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
20077 (Check): Loop correctly to report errors modifiers
20078 (UNSAFE was not in the loop, since it was the same as TOP).
20080 * interface.cs: Every interface member now takes a ModFlags,
20081 instead of a "is_new" bool, which we set on the base MemberCore.
20083 Every place where we called "UnsafeOk" in the interface, now we
20084 call the proper member (InterfaceMethod.UnsafeOK) instead to get
20085 the unsafe settings from the member declaration instead of the
20086 container interface.
20088 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
20090 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
20091 `set_indexer_name' to the pending bits (one per type).
20093 We fixed a bug today that was picking the wrong method to
20094 override, since for properties the existing InterfaceMethod code
20095 basically ignored the method name. Now we make sure that the
20096 method name is one of the valid indexer names.
20098 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
20100 * support.cs (SeekableStreamReader): Keep track of stream byte
20101 positions and don't mix them with character offsets to the buffer.
20103 Patch from Gustavo Giráldez
20105 2004-03-15 Marek Safar <marek.safar@seznam.cz>
20107 * interface.cs (InterfaceSetGetBase): Removed double member
20108 initialization, base class does it as well.
20110 2004-03-13 Martin Baulig <martin@ximian.com>
20112 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
20113 when compiling corlib.
20115 2004-03-13 Miguel de Icaza <miguel@ximian.com>
20117 * convert.cs (ExplicitConversion): We were reporting an error on
20118 certain conversions (object_type source to a value type, when the
20119 expression was `null') before we had a chance to pass it through
20120 the user defined conversions.
20122 * driver.cs: Replace / and \ in resource specifications to dots.
20125 * class.cs: Add check for duplicate operators. Fixes 52477
20127 2004-03-11 Miguel de Icaza <miguel@ximian.com>
20129 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
20130 that are in the middle of the statements, not only at the end.
20133 * class.cs (TypeContainer.AddField): No longer set the
20134 `HaveStaticConstructor' flag, now we call it
20135 `UserDefineStaticConstructor' to diferentiate the slightly
20136 semantic difference.
20138 The situation is that we were not adding BeforeFieldInit (from
20139 Modifiers.TypeAttr) to classes that could have it.
20140 BeforeFieldInit should be set to classes that have no static
20145 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
20147 And most importantly Zoltan's comment:
20149 http://bugzilla.ximian.com/show_bug.cgi?id=44229
20151 "I think beforefieldinit means 'it's ok to initialize the type sometime
20152 before its static fields are used', i.e. initialization does not need
20153 to be triggered by the first access to the type. Setting this flag
20154 helps the JIT to compile better code, since it can run the static
20155 constructor at JIT time, and does not need to generate code to call it
20156 (possibly lots of times) at runtime. Unfortunately, mcs does not set
20157 this flag for lots of classes like String.
20159 csc sets this flag if the type does not have an explicit static
20160 constructor. The reasoning seems to be that if there are only static
20161 initalizers for a type, and no static constructor, then the programmer
20162 does not care when this initialization happens, so beforefieldinit
20165 This bug prevents the AOT compiler from being usable, since it
20166 generates so many calls to mono_runtime_class_init that the AOT code
20167 is much slower than the JITted code. The JITted code is faster,
20168 because it does not generate these calls if the vtable is type is
20169 already initialized, which is true in the majority of cases. But the
20170 AOT compiler can't do this."
20172 2004-03-10 Miguel de Icaza <miguel@ximian.com>
20174 * class.cs (MethodData.Emit): Refactor the code so symbolic
20175 information is generated for destructors; For some reasons we
20176 were taking a code path that did not generate symbolic information
20179 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
20181 * class.cs: Create a Constructor.CheckBase method that
20182 takes care of all validation type code. The method
20183 contains some code that was moved from Define.
20185 It also includes new code that checks for duplicate ctors.
20186 This fixes bug #55148.
20188 2004-03-09 Joshua Tauberer <tauberer@for.net>
20190 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
20191 a { ... }-style array creation invokes EmitStaticInitializers
20192 which is not good for reference-type arrays. String, decimal
20193 and now null constants (NullCast) are not counted toward
20194 static initializers.
20196 2004-03-05 Martin Baulig <martin@ximian.com>
20198 * location.cs (SourceFile.HasLineDirective): New public field;
20199 specifies whether the file contains or is referenced by a "#line"
20201 (Location.DefineSymbolDocuments): Ignore source files which
20202 either contain or are referenced by a "#line" directive.
20204 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
20206 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
20207 direct access to our parent, so check the method inline there.
20209 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
20211 * expression.cs (Invocation.EmitCall): Miguel's last commit
20212 caused a regression. If you had:
20217 In Foo the implict this would be null.
20219 2004-02-27 Miguel de Icaza <miguel@ximian.com>
20221 * expression.cs (Invocation.EmitCall): If the method is not
20222 virtual, do not emit a CallVirt to it, use Call.
20224 * typemanager.cs (GetFullNameSignature): Improve the method to
20225 cope with ".ctor" and replace it with the type name.
20227 * class.cs (ConstructorInitializer.Resolve): Now the method takes
20228 as an argument the ConstructorBuilder where it is being defined,
20229 to catch the recursive constructor invocations.
20231 2004-02-26 Miguel de Icaza <miguel@ximian.com>
20233 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
20234 routines to check if a type is an enumerable/enumerator allow
20235 classes that implement the IEnumerable or IEnumerator interfaces.
20237 * class.cs (Property, Operator): Implement IIteratorContainer, and
20238 implement SetYields.
20240 (Property.Define): Do the block swapping for get_methods in the
20241 context of iterators. We need to check if Properties also
20242 include indexers or not.
20244 (Operator): Assign the Block before invoking the
20245 OperatorMethod.Define, so we can trigger the Iterator code
20248 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
20249 Property and Operator classes are not created when we parse the
20250 declarator but until we have the block completed, so we use a
20251 singleton SimpleIteratorContainer.Simple to flag whether the
20252 SetYields has been invoked.
20254 We propagate this setting then to the Property or the Operator to
20255 allow the `yield' to function.
20257 2004-02-25 Marek Safar <marek.safar@seznam.cz>
20259 * codegen.cs: Implemented attribute support for modules.
20260 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
20261 Assembly/Module functionality.
20263 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
20264 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
20265 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
20267 2004-02-16 Marek Safar <marek.safar@seznam.cz>
20269 * interface.cs (FindMembers): The operation is performed on all base
20270 interfaces and not only on the first. It is required for future CLS Compliance patch.
20272 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
20274 * statement.cs, codegen.cs:
20275 This patch deals with patterns such as:
20277 public class List : IEnumerable {
20279 public MyEnumerator GetEnumerator () {
20280 return new MyEnumerator(this);
20283 IEnumerator IEnumerable.GetEnumerator () {
20287 public struct MyEnumerator : IEnumerator {
20292 Before, there were a few things we did wrong:
20293 1) we would emit callvirt on a struct, which is illegal
20294 2) we emited ldarg when we needed to emit ldarga
20295 3) we would mistakenly call the interface methods on an enumerator
20296 type that derived from IEnumerator and was in another assembly. For example:
20298 public class MyEnumerator : IEnumerator
20300 Would have the interface methods called, even if there were public impls of the
20301 method. In a struct, this lead to invalid IL code.
20303 2004-02-11 Marek Safar <marek.safar@seznam.cz>
20305 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
20308 * delegate.cs (Define): Fixed crash when delegate type is undefined.
20310 2004-02-11 Miguel de Icaza <miguel@ximian.com>
20312 * cs-parser.jay: Fix small regression: we were not testing V2
20313 compiler features correctly.
20315 * interface.cs: If the emit context is null, then create one
20317 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20319 * decl.cs (GetSignatureForError): New virtual method to get full name
20320 for error messages.
20322 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20323 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20325 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20326 Duplicated members and code in these classes has been removed.
20327 Better encapsulation in these classes.
20329 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20331 * assign.cs (Assign.DoResolve): When dealing with compound
20332 assignments, there is a new rule in ECMA C# 2.4 (might have been
20333 there before, but it is documented here) that states that in:
20337 If b is of type int, and the `op' is a shift-operator, then the
20338 above is evaluated as:
20342 * expression.cs (Binary.ResolveOperator): Instead of testing for
20343 int/uint/long/ulong, try to implicitly convert to any of those
20344 types and use that in pointer arithmetic.
20346 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20347 method to print information for from the type, not from the
20348 null-method we were given.
20350 2004-02-01 Duncan Mak <duncan@ximian.com>
20352 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20353 parsing for cmd, fixes bug #53694.
20355 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20357 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20358 in the member name duplication tests. Property and operator name duplication
20359 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20361 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20363 * interface.cs (PopulateMethod): Fixed crash when interface method
20364 returns not existing type (error test cs0246-3.cs).
20366 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20368 * cs-parser.jay (interface_accessors): Re-write actions to also
20369 store attributes attached to get and set methods. Fix spelling
20372 (inteface_property_declaration): Modify accordingly.
20374 (InterfaceAccessorInfo): New helper class to store information to pass
20375 around between rules that use interface_accessors.
20377 * interface.cs (Emit): Apply attributes on the get and set
20378 accessors of properties and indexers too.
20380 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20381 right MethodBuilder when applying attributes to the get and set accessors.
20383 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20385 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20387 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20389 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20391 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20393 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20394 changes that treat `yield' specially when present before `break'
20395 or `return' tokens.
20397 * cs-tokenizer.cs: yield is no longer a keyword.
20399 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20401 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20402 setting for default constructors.
20403 For default constructors are almost every time set wrong Modifier. The
20404 generated IL code has been alright. But inside mcs this values was
20405 wrong and this was reason why several of my CLS Compliance tests
20408 2004-01-22 Martin Baulig <martin@ximian.com>
20410 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20411 not a QualifiedIdentifier. This is what `type_name_expression'
20412 was previously doing.
20413 (type_name_expression): Removed; the code is now in
20414 `namespace_or_type_name'.
20415 (qualified_identifier): Removed, use `namespace_or_type_name'
20417 (QualifiedIdentifier): Removed this class.
20419 2004-01-22 Martin Baulig <martin@ximian.com>
20421 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20422 not a string as alias name.
20424 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20426 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20427 #52730 bug, and instead compute correctly the need to use a
20428 temporary variable when requesting an address based on the
20429 static/instace modified of the field and the constructor.
20431 2004-01-21 Martin Baulig <martin@ximian.com>
20433 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20434 class and namespace before looking up aliases. Fixes #52517.
20436 2004-01-21 Martin Baulig <martin@ximian.com>
20438 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20439 assinged in a 'try'; fixes exception4.cs.
20441 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20442 * class.cs : Implemented parameter-less constructor for TypeContainer
20444 * decl.cs: Attributes are now stored here. New property OptAttributes
20446 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20448 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20450 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20452 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20453 (CSharpSignature): New method for indexer and property signature.
20455 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20457 * pending.cs (IsVirtualFilter): Faster implementation.
20459 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20461 * typemanager.cs: Avoid inclusion of same assembly more than once.
20463 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20465 * cs-parser.jay: Fixed problem where the last assembly attribute
20466 has been applied also to following declaration (class, struct, etc.)
20468 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20470 * class.cs: Added error CS0538, CS0539 reporting.
20471 Fixed crash on Microsoft runtime when field type is void.
20473 * cs-parser.jay: Added error CS0537 reporting.
20475 * pending.cs: Added error CS0535 reporting.
20476 Improved error report for errors CS0536, CS0534.
20478 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20480 Merge a few bits from the Anonymous Method MCS tree.
20482 * statement.cs (ToplevelBlock): New class for toplevel methods,
20483 will hold anonymous methods, lifted variables.
20485 * cs-parser.jay: Create toplevel blocks for delegates and for
20486 regular blocks of code.
20488 2004-01-20 Martin Baulig <martin@ximian.com>
20490 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20491 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20492 and `NeedExplicitReturn'; added `IsLastStatement'.
20493 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20494 have a `ReturnLabel' or we're not unreachable.
20496 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20497 child's reachability; don't just override ours with it. Fixes
20498 #58058 (lluis's example).
20499 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20500 InFinally(), InLoop(), InSwitch() and
20501 BreakCrossesTryCatchBoundary() methods.
20503 * statement.cs (Return): Do all error checking in Resolve().
20504 Unless we are the last statement in a top-level block, always
20505 create a return label and jump to it.
20506 (Break, Continue): Do all error checking in Resolve(); also make
20507 sure we aren't leaving a `finally'.
20508 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20509 statement in a top-level block.
20510 (Block.Flags): Added `IsDestructor'.
20511 (Block.IsDestructor): New public property.
20513 2004-01-20 Martin Baulig <martin@ximian.com>
20515 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20517 2004-01-20 Martin Baulig <martin@ximian.com>
20519 * statement.cs (Statement.ResolveUnreachable): New public method.
20520 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20521 (Block.Resolve): Resolve unreachable statements.
20523 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20525 * expression.cs: We need to fix the case where we do
20526 not have a temp variable here.
20528 * assign.cs: Only expression compound assignments need
20529 temporary variables.
20531 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20533 * flowanalysis.cs: Reduce memory allocation in a few ways:
20534 - A block with no variables should not allocate a bit
20536 - A method with no out parameters does not need any tracking
20537 for assignment of the parameters, so we need not allocate
20540 public readonly Type[] VariableTypes;
20541 public readonly string[] VariableNames;
20542 Are redundant. The data is already stored in the variable
20543 map, so we need not allocate another array for it.
20544 - We need to add alot of checks for if (params | locals) == null
20545 due to the first two changes.
20547 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20549 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20550 implement IMemoryLocation, we store a copy on a local variable and
20551 take the address of it. Patch from Benjamin Jemlich
20553 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20554 to use a special "type_name_expression" rule which reduces the
20555 number of "QualifiedIdentifier" classes created, and instead
20556 directly creates MemberAccess expressions.
20558 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20560 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20561 that fixes #52853. Null literal assignment to ValueType
20563 * class.cs (MethodData.Emit): Instead of checking the name of the
20564 method to determine if its a destructor, create a new derived
20565 class from Method called Destructor, and test for that.
20567 * cs-parser.jay: Create a Destructor object instead of a Method.
20569 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20573 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20575 * expression.cs (Binary.ResolveOperator): Perform an implicit
20576 conversion from MethodGroups to their delegate types on the
20577 Addition operation.
20579 * delegate.cs: Introduce a new class DelegateCreation that is the
20580 base class for `NewDelegate' and `ImplicitDelegateCreation',
20581 factor some code in here.
20583 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20584 conversion from MethodGroups to compatible delegate types.
20586 * ecore.cs (Expression.Resolve): Do not flag error 654
20587 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20588 we allow conversions from MethodGroups to delegate types now.
20590 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20591 assignments in v2 either.
20593 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20595 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20596 static read-only fields in ctors.
20598 Applied patch from Benjamin Jemlich
20600 * expression.cs (UnaryMutator): Avoid leaking local variables.
20602 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20604 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20605 here to return true, as they can be used like this:
20607 (XXX) int.MEMBER ()
20609 Fixed 49836 and all the other dups
20611 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20613 * driver.cs: Implement /win32res and /win32icon.
20615 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20617 * cs-parser.jay: Add a rule to improve error handling for the
20618 common mistake of placing modifiers after the type.
20620 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20622 * cs-parser.jay (interface_event_declaration): Catch
20623 initialization of events on interfaces, and report cs0068
20625 * cs-parser.jay (interface_event_declaration): Catch
20626 initialization of events.
20628 * ecore.cs: Better report missing constructors.
20630 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20631 the error reporting done in the wrong place. Fix.
20633 * expression.cs (Binary.ResolveOperator): Catch the
20634 operator + (E x, E y) error earlier, and later allow for implicit
20635 conversions in operator +/- (E e, U x) from U to the underlying
20638 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20639 52596, if the container class is abstract, the default constructor
20640 is protected otherwise its public (before, we were always public).
20642 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20645 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20646 Jemlich that fixes bug #52597, MCS was generating invalid code for
20647 idisposable structs. Thanks to Ben for following up with this
20650 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20652 * driver.cs: Allow assemblies without code to be generated, fixes
20655 2004-01-07 Nick Drochak <ndrochak@gol.com>
20657 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20659 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20661 * cs-parser.jay: Add rules to improve error reporting if fields or
20662 methods are declared at the namespace level (error 116)
20664 * Add rules to catch event add/remove
20666 2004-01-04 David Sheldon <dave-mono@earth.li>
20668 * expression.cs: Added matching ")" to error message for
20671 2004-01-03 Todd Berman <tberman@gentoo.org>
20673 * ecore.cs, attribute.cs:
20674 Applying fix from #52429.
20676 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20678 * ecore.cs, expression.cs, statement.cs:
20679 Total rewrite of how we handle branching. We
20680 now handle complex boolean expressions with fewer
20681 jumps. As well if (x == 0) no longer emits a ceq.
20683 if (x is Foo) is much faster now, because we generate
20686 Overall, we get a pretty big improvement on our benchmark
20687 tests. The code we generate is smaller and more readable.
20689 I did a full two-stage bootstrap. The patch was reviewed
20690 by Martin and Miguel.
20692 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20694 * cs-parser.jay: Make primary_expression not take a QI.
20695 we dont need this because the member_access rule covers
20696 us here. So we replace the rule with just IDENTIFIER.
20698 This has two good effects. First, we remove a s/r conflict.
20699 Second, we allocate many fewer QualifiedIdentifier objects.
20701 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20703 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20704 set the correct information via SRE. This prevents
20705 hanging on the MS runtime. Fixes #29374.
20707 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20709 * convert.cs: correctly handle conversions to value types
20710 from Enum and ValueType as unboxing conversions.
20712 Fixes bug #52569. Patch by Benjamin Jemlich.
20714 2004-01-02 Ravi Pratap <ravi@ximian.com>
20716 * expression.cs (BetterConversion): Prefer int -> uint
20717 over int -> ulong (csc's behaviour). This fixed bug #52046.
20719 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20721 * decl.cs (MemberCache.FindMembers): now returns a
20724 * typemanager.cs: In general, go with with ^^.
20725 (CopyNewMethods): take an IList.
20726 (RealMemberLookup): Only allocate an arraylist
20727 if we copy from two sets of methods.
20729 This change basically does two things:
20730 1) Fewer array lists allocated due to CopyNewMethods.
20731 2) the explicit cast in MemberList costed ALOT.
20733 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20735 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20736 a hashtable to avoid needless string allocations when an identifier is
20737 used more than once (the common case).
20739 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20741 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20742 is broken, it will not return anything. So, we
20743 have to use the information we have in mcs to
20746 * typemanager.cs: Add a cache for GetInterfaces,
20747 since this will now be used more often (due to ^^)
20749 (GetExplicitInterfaces) New method that gets the
20750 declared, not effective, interfaces on a type
20751 builder (eg, if you have interface IFoo, interface
20752 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20755 This patch makes MCS able to bootstrap itself on
20758 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20760 * expression.cs: Remove the Nop's that Miguel put
20763 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20765 * report.cs, codegen.cs: Give the real stack trace to
20766 the error when an exception is thrown.
20768 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20770 * decl.cs: only allocate hashtables for ifaces if
20773 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20775 * expression.cs: fix the error from cs0121-2.cs
20776 (a parent interface has two child interfaces that
20777 have a function with the same name and 0 params
20778 and the function is called through the parent).
20780 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20782 * class.cs, rootcontext.cs, typmanager.cs: do not
20785 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20787 * codegen.cs: remove stack for the ec flow branching.
20788 It is already a linked list, so no need.
20790 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20792 * Makefile: Allow custom profiler here.
20794 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20796 * typemanager.cs (LookupType):
20797 - Use a static char [], because split takes
20798 a param array for args, so it was allocating
20800 - Do not store true in a hashtable, it boxes.
20802 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20804 * flowanalysis.cs: bytify common enums.
20806 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20808 * modifiers.cs: Add a new set of flags for the
20809 flags allowed on explicit interface impls.
20810 * cs-parser.jay: catch the use of modifiers in
20811 interfaces correctly.
20812 * class.cs: catch private void IFoo.Blah ().
20814 All related to bug #50572.
20816 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20818 * decl.cs: Rewrite the consistant accessability checking.
20819 Accessability is not linear, it must be implemented in
20820 a tableish way. Fixes #49704.
20822 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20824 * expression.cs: Handle negation in a checked context.
20825 We must use subtraction from zero. Fixes #38674.
20827 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20829 * class.cs: Ignore static void main in DLLs.
20830 * rootcontext.cs: Handle the target type here,
20831 since we are have to access it from class.cs
20832 * driver.cs: account for the above.
20834 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20836 * report.cs: Give line numbers and files if available.
20838 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20840 * driver.cs: Implement /addmodule.
20842 * typemanager.cs: Change 'modules' field so it now contains Modules not
20845 2003-12-20 Martin Baulig <martin@ximian.com>
20847 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20848 (FieldBase.IsAssigned): Removed this field.
20849 (FieldBase.SetAssigned): New public method.
20850 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20852 2003-12-20 Martin Baulig <martin@ximian.com>
20854 * expression.cs (LocalVariableReference.DoResolve): Don't set
20855 `vi.Used' if we're called from DoResolveLValue().
20857 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20858 returns the usage vector it just merged into the current one -
20859 pass this one to UsageWarning().
20860 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20861 of the `EmitContext', don't call this recursively on our children.
20863 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20865 * driver.cs: Implement /target:module.
20867 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20869 * support.cs (CharArrayHashtable): New helper class.
20871 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20872 char arrays, not strings, so we can avoid creating a string in
20873 consume_identifier if the identifier is a keyword.
20875 2003-12-16 Martin Baulig <martin@ximian.com>
20877 * statement.cs (LocalInfo.Assigned): Removed this property.
20878 (LocalInfo.Flags): Removed `Assigned'.
20879 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20880 and uses flow analysis.
20881 (Block.UsageWarning): Made this method private.
20882 (Block.Resolve): Call UsageWarning() if appropriate.
20884 * expression.cs (LocalVariableReference.DoResolve): Always set
20885 LocalInfo.Used here.
20887 2003-12-13 Martin Baulig <martin@ximian.com>
20889 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20890 any value here; we're now using flow analysis to figure out
20891 whether a statement/block returns a value.
20893 2003-12-13 Martin Baulig <martin@ximian.com>
20895 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20897 (FlowBranching.MergeFinally): Don't call
20898 `branching.CheckOutParameters()' here, this is called in
20900 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20901 when adding the `finally' vector.
20903 2003-12-13 Martin Baulig <martin@ximian.com>
20906 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20907 actually work and also fix #48962.
20909 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20911 * decl.cs: Do not check System.Object for nested types,
20912 since we know it does not have any. Big bang for buck:
20915 Run 1: 8.35 seconds
20916 Run 2: 8.32 seconds
20917 corlib: 17.99 seconds
20919 Run 1: 8.17 seconds
20920 Run 2: 8.17 seconds
20921 corlib: 17.39 seconds
20923 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20925 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20926 time we are returning 0 members, so we save alot here.
20928 2003-12-11 Martin Baulig <martin@ximian.com>
20930 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20931 `MergeChild()', also just take the `FlowBranching' as argument;
20932 call Merge() on it and return the result.
20933 (FlowBranching.Merge): We don't need to do anything if we just
20936 2003-12-11 Martin Baulig <martin@ximian.com>
20938 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20939 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20940 Maurer for this idea.
20942 2003-12-11 Martin Baulig <martin@ximian.com>
20944 * flowanalysis.cs (MergeResult): This class is now gone; we now
20945 use the `UsageVector' for this. The reason for this is that if a
20946 branching just has one sibling, we don't need to "merge" them at
20947 all - that's the next step to do.
20948 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20951 2003-12-11 Martin Baulig <martin@ximian.com>
20953 Reworked flow analyis and made it more precise and bug-free. The
20954 most important change is that we're now using a special `Reachability'
20955 class instead of having "magic" meanings of `FlowReturns'. I'll
20956 do some more cleanups and optimizations and also add some more
20957 documentation this week.
20959 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20960 largely reworked this class.
20961 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20962 the new `Reachability' class instead of having "magic" values here.
20963 (FlowBranching): We're now using an instance of `Reachability'
20964 instead of having separate `Returns', `Breaks' etc. fields.
20966 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20967 based on flow analysis; ignore the return value of block.Emit ().
20969 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20971 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20972 if they are private.
20974 2003-12-09 Martin Baulig <martin@ximian.com>
20976 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20977 call them directly on the UsageVector.
20979 2003-12-09 Martin Baulig <martin@ximian.com>
20981 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20982 Changed return type from `FlowReturns' to `Reachability'.
20984 2003-12-09 Martin Baulig <martin@ximian.com>
20986 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20987 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20988 `Reachable' fields with a single `Reachability' one.
20990 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20992 * class.cs (FindMembers): Remove foreach's.
20997 Run 1: 8.74 seconds
20998 Run 2: 8.71 seconds
21001 Run 1: 8.64 seconds
21002 Run 2: 8.58 seconds
21005 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21010 This patch does a few things:
21011 1. EmptyStatement is now a singleton, so it is never reallocated.
21012 2. All blah is EmptyStatement constructs have been changed to
21013 blah == EmptyStatement.Value, which is much faster and valid
21014 now that EmptyStatement is a singleton.
21015 3. When resolving a block, rather than allocating a new array for
21016 the non-empty statements, empty statements are replaced with
21017 EmptyStatement.Value
21018 4. Some recursive functions have been made non-recursive.
21019 Mainly the performance impact is from (3), however (1) and (2) are needed for
21020 this to work. (4) does not make a big difference in normal situations, however
21021 it makes the profile look saner.
21026 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
21027 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
21028 Total memory allocated: 56397 KB
21031 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
21032 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
21033 Total memory allocated: 55666 KB
21035 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21037 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
21038 than the hashtable in a hashtable version
21040 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
21041 we always end up concating a string. This results in a huge perf
21042 loss, because many strings have to be tracked by the GC. In this
21043 patch, we first use a hashtable that works with two keys, so that
21044 the strings do not need to be concat'ed.
21048 Run 1: 8.74 seconds
21049 Run 2: 8.71 seconds
21052 Run 1: 8.65 seconds
21053 Run 2: 8.56 seconds
21055 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21057 * Makefile: Add a new target `do-time' that does a quick and simple
21058 profile, leaving easy to parse output.
21060 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
21062 * codegen.cs (Init): Create the dynamic assembly with
21063 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
21065 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
21067 * support.cs: Make the PtrHashtable use only one
21068 instance of its comparer.
21070 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
21072 * typemanager.cs: Fix lookup of GetNamespaces.
21074 2003-11-29 Miguel de Icaza <miguel@ximian.com>
21076 * expression.cs: Removed redundant line.
21078 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
21079 ArrayLists, use for loops with bounds.
21081 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
21084 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
21085 arraylists, use for loop with bounds.
21087 The above three changes give us a 0.071 second performance
21088 improvement out of 3.294 seconds down to 3.223. On my machine
21089 the above changes reduced the memory usage by 1,387 KB during
21090 compiler bootstrap.
21092 * cs-parser.jay (QualifiedIdentifier): New class used to represent
21093 QualifiedIdentifiers. Before we created a new string through
21094 concatenation, and mostly later on, the result would be
21095 manipulated by DecomposeQI through string manipulation.
21097 This reduced the compiler memory usage for bootstrapping from
21098 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
21099 compile times in 0.05 seconds.
21101 2003-11-28 Dick Porter <dick@ximian.com>
21103 * support.cs: Do string compares with the Invariant culture.
21111 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
21112 the comparison is done with the Invariant culture.
21114 2003-11-27 Miguel de Icaza <miguel@ximian.com>
21116 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
21117 GetEnumerator method.
21119 (ProbeCollectionType): Iterate starting at the most specific type
21120 upwards looking for a GetEnumerator
21122 * expression.cs: Shift count can be up to 31 for int/uint and 63
21125 2003-11-26 Miguel de Icaza <miguel@ximian.com>
21127 * statement.cs (Block.LookupLabel): Also look for the label on the
21128 children blocks. Use a hash table to keep track of visited
21131 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
21132 we actually did transform the other operand, otherwise fall back
21133 to the common codepath that casts to long.
21135 * cs-tokenizer.cs: Use the same code pattern as the int case.
21136 Maybe I should do the parsing myself, and avoid depending on the
21137 Parse routines to get this done.
21139 2003-11-25 Miguel de Icaza <miguel@ximian.com>
21141 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21142 which fixes bug 51347. This time test it.
21144 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
21145 attributes for example can not tell the difference between these.
21146 The difference was only a syntax feature of the language.
21148 * attribute.cs: Apply attributes to delegates.
21150 * delegate.cs: Call the apply attributes method.
21152 2003-11-24 Miguel de Icaza <miguel@ximian.com>
21154 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
21155 comparing 0 vs Byte.MinValue, not the value
21157 (ImplicitConversionRequired): When reporting a conversion error,
21158 use error 31 to print out the constant error instead of the
21161 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21162 which fixes bug 51347.
21164 2003-11-22 Miguel de Icaza <miguel@ximian.com>
21166 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
21167 which fixes the -warnaserror command line option.
21169 2003-11-21 Miguel de Icaza <miguel@ximian.com>
21171 * cfold.cs (DoNumericPromotions): During constant folding of
21172 additions on UIntConstant, special case intconstants with
21173 IntConstants like we do on the expression binary operator.
21175 2003-11-12 Miguel de Icaza <miguel@ximian.com>
21177 * convert.cs (ImplicitReferenceConversion): We were missing a case
21178 (System.Enum are not value types or class types, so we need to
21179 classify them separatedly).
21181 * driver.cs: We do not support error 2007.
21183 2003-11-12 Jackson Harper <jackson@ximian.com>
21185 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
21186 system directory. Also use the full file name so users can
21187 libraries names mscorlib-o-tron.dll in a non system dir.
21189 2003-11-10 Martin Baulig <martin@ximian.com>
21191 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
21192 (TypeManager.InitCoreTypes): Initialize them here, but instead of
21193 calling `ResolveType()' on them, directly assign their `Type'.
21195 2003-11-08 Martin Baulig <martin@ximian.com>
21197 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
21198 return value and the `out parent' parameter.
21199 (TypeContainer.DefineType): Moved the CS0644 check into
21200 GetClassBases(). Don't pass the interface types to the
21201 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
21202 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
21204 * ecore.cs (TypeExpr.IsAttribute): New property.
21205 (TypeExpr.GetInterfaces): New method.
21207 * interface.cs (Interface.GetInterfaceTypeByName): Return a
21208 TypeExpr instead of a Type.
21209 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
21210 (Interface.DefineType): Don't pass the interface types to the
21211 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
21212 them later and then call `TypeBulider.AddInterfaceImplementation()'.
21214 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
21215 instead of a `Type[]'.
21216 (TypeManager.RegisterBuilder): Likewise.
21217 (TypeManager.AddUserInterface): Likewise.
21218 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
21219 `Type[]' and also return a `TypeExpr[]'.
21220 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
21222 2003-11-08 Martin Baulig <martin@ximian.com>
21224 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
21227 2003-11-08 Martin Baulig <martin@ximian.com>
21229 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
21230 TypeManager.ResolveExpressionTypes().
21232 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
21233 instead of an Expression.
21234 (TypeExpr): This is now an abstract base class for `TypeExpression'.
21235 (TypeExpression): New public class; formerly known as `TypeExpr'.
21237 * expression.cs (ComposedCast): Derive from TypeExpr.
21239 * typemanager.cs (TypeManager.system_*_expr): These are now
21240 TypExpr's instead of Expression's.
21241 (TypeManager.ResolveExpressionTypes): New public static function;
21242 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
21245 2003-11-06 Miguel de Icaza <miguel@ximian.com>
21247 * expression.cs (New.DoResolve): Do not dereference value that
21248 might be a null return.
21250 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
21251 sure that the constant value has the right type. Fixes an
21252 unreported bug, similar to 50425.
21254 * const.cs (Const.LookupConstantValue): Call
21255 ImplicitStandardConversionExists before doing a conversion to
21256 avoid havng the TypeManager.ChangeType do conversions.
21258 Reduced the number of casts used
21260 (Const.ChangeType): New routine to enable reuse of the constant
21261 type changing code from statement.
21263 * typemanager.cs (ChangeType): Move common initialization to
21264 static global variables.
21268 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
21269 every value type to go through, even if it was void. Fix that.
21271 * cs-tokenizer.cs: Use is_identifier_start_character on the start
21272 character of the define, and the is_identifier_part_character for
21273 the rest of the string.
21275 2003-11-05 Miguel de Icaza <miguel@ximian.com>
21277 * expression.cs (UnaryMutator.EmitCode): When I updated
21278 LocalVariableReference.DoResolve, I overdid it, and dropped an
21279 optimization done on local variable references.
21281 2003-11-04 Miguel de Icaza <miguel@ximian.com>
21283 * ecore.cs: Convert the return from Ldlen into an int.
21285 2003-10-20 Miguel de Icaza <miguel@ximian.com>
21287 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
21288 the accessibility, this is a special case for toplevel non-public
21289 classes (internal for instance).
21291 2003-10-20 Nick Drochak <ndrochak@gol.com>
21293 * ecore.cs: Fix typo and build. Needed another right paren.
21295 2003-10-19 Miguel de Icaza <miguel@ximian.com>
21297 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
21298 `internal' case regular and protected, but not allowing protected
21299 to be evaluated later. Bug 49840
21301 2003-10-15 Miguel de Icaza <miguel@ximian.com>
21303 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
21304 to kb.Nlast, and not the kb.nFirst to isolate the switch
21307 Extract the underlying type, so enumerations of long/ulong are
21308 treated like long/ulong.
21310 2003-10-14 Miguel de Icaza <miguel@ximian.com>
21312 * expression.cs (New): Overload the meaning of RequestedType to
21313 track the possible creation of the NewDelegate type, since
21314 DoResolve is invoked more than once for new constructors on field
21317 See bugs: #48800 and #37014
21319 * cs-parser.jay (declare_local_constants): Take an arraylist
21320 instead of a single constant.
21322 (local_constant_declaration): It should take a
21323 constant_declarators, not a constant_declarator. Fixes 49487
21325 * convert.cs: Fix error report.
21327 2003-10-13 Jackson Harper <jackson@ximian.com>
21329 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21332 2003-10-09 Martin Baulig <martin@ximian.com>
21334 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21336 (MethodCore.DoDefineParameters): Removed the TypeContainer
21337 argument; use the DeclSpace which was passed to the .ctor instead.
21338 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21339 TypeContainer; we only need a DeclSpace here.
21341 2003-10-09 Martin Baulig <martin@ximian.com>
21343 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21345 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21346 EmitContext's .ctor.
21348 2003-10-09 Martin Baulig <martin@ximian.com>
21350 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21351 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21352 AsAccessible(), moved them as well.
21354 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21356 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21358 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21360 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21362 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21363 generation for >=, as spotted by Paolo, bug 48679.
21364 Patch from David Waite.
21366 * cs-tokenizer.cs: Add handling for #pragma.
21368 * cs-parser.jay: Allow for both yield and yield return in the
21369 syntax. The anti-cobolization of C# fight will go on!
21371 * class.cs (TypeBuilder.DefineType): Catch error condition here
21372 (Parent.DefineType erroring out and returning null).
21374 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21375 coping with enumerations variables, we were mistakenly processing
21376 them as a regular value type instead of built-in types. Fixes the
21379 * typemanager.cs (IsBuiltinOrEnum): New method.
21381 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21383 * cs-parser.jay: Upgrade: yield now needs the return clause.
21385 2003-09-19 Martin Baulig <martin@ximian.com>
21387 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21388 `MemberCache parent' argument. Normally, an interface doesn't
21389 have a parent type except System.Object, but we use this in gmcs
21390 for generic type parameters.
21392 2003-09-18 Martin Baulig <martin@ximian.com>
21394 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21395 on `type.IsInterface'; don't check whether the type has a parent
21396 to determine whether it's an interface.
21398 2003-09-15 Martin Baulig <martin@ximian.com>
21400 * class.cs (TypeContainer.DefineType): Added an error flag to
21401 avoid reporting duplicate CS0146's ("class definition is
21404 * driver.cs (Driver.MainDriver): Abort if
21405 RootContext.ResolveTree() reported any errors.
21407 2003-09-07 Martin Baulig <martin@ximian.com>
21409 * report.cs (Error, Warning): Added overloaded versions which take
21410 a `params object[] args' and call String.Format().
21412 2003-09-07 Martin Baulig <martin@ximian.com>
21414 * decl.cs (DeclSpace..ctor): Don't call
21415 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21416 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21417 (DeclSpace.RecordDecl): New method.
21419 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21421 2003-09-02 Ravi Pratap <ravi@ximian.com>
21423 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21424 value attributes to be applied to ParameterBuilders.
21426 * class.cs (MethodCore.LabelParameters): Make static and more
21427 generic so that it can be used from other places - like interface
21428 methods, for instance.
21430 * interface.cs (Interface.Emit): Call LabelParameters before
21431 emitting attributes on the InterfaceMethod.
21433 2003-08-26 Martin Baulig <martin@ximian.com>
21435 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21436 resolving aliases; fixes #47927.
21438 2003-08-26 Martin Baulig <martin@ximian.com>
21440 * statement.cs (Using.DoResolve): This is internally emitting a
21441 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21442 do not always return. Fixes #47681.
21444 2003-08-26 Martin Baulig <martin@ximian.com>
21446 * decl.cs (MemberCore): Moved WarningNotHiding(),
21447 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21449 (AdditionResult): Make this nested in DeclSpace.
21450 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21451 argument; call NamespaceEntry.Define() unless we're nested in a
21454 * namespace.cs (Namespace.DefineName): New public function. This
21455 is called from DeclSpace's .ctor to add
21456 (Namespace.Lookup): Include DeclSpaces in the lookup.
21458 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21460 * const.cs (Const): Derive from MemberBase, not MemberCore.
21462 2003-08-25 Martin Baulig <martin@ximian.com>
21464 * convert.cs (Convert.ExplicitReferenceConversion): When
21465 converting from an interface type to a class, unbox if the target
21466 type is a struct type. Fixes #47822.
21468 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21470 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21473 2003-08-22 Martin Baulig <martin@ximian.com>
21475 * class.cs (TypeManager.DefineType): When defining a nested type,
21476 call DefineType() on our parent; fixes #47801.
21478 2003-08-22 Martin Baulig <martin@ximian.com>
21480 * class.cs (MethodData.Define): While checking if a method is an
21481 interface implementation, improve the test a bit more to fix #47654.
21483 2003-08-22 Martin Baulig <martin@ximian.com>
21485 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21486 correctly; fixes #47722.
21488 2003-08-22 Martin Baulig <martin@ximian.com>
21490 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21491 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21493 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21495 2003-08-22 Martin Baulig <martin@ximian.com>
21497 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21498 can only be assigned in static constructors. Fixes #47161.
21500 2003-08-22 Martin Baulig <martin@ximian.com>
21502 Rewrote and improved the flow analysis code.
21504 * flowbranching.cs (FlowBranching): Make this class abstract.
21505 (FlowBranching.CreateBranching): New static function to create a
21506 new flow branching.
21507 (FlowBranchingBlock, FlowBranchingException): New classes.
21508 (FlowBranching.UsageVector.Type): New public readonly field.
21509 (FlowBranching.UsageVector.Breaks): Removed the setter.
21510 (FlowBranching.UsageVector.Returns): Removed the setter.
21511 (FlowBranching.UsageVector): Added Break(), Return(),
21512 NeverReachable() and Throw() methods to modify the reachability.
21513 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21514 done by FlowBranching.Merge().
21515 (FlowBranching.UsageVector.MergeChild): New method; merges the
21516 merge result into the current vector.
21517 (FlowBranching.Merge): New abstract method to merge a branching.
21519 2003-08-12 Martin Baulig <martin@ximian.com>
21521 * expression.cs (Indirection.CacheTemporaries): Create the
21522 LocalTemporary with the pointer type, not its element type.
21524 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21526 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21527 token was a keyword or not.
21529 Add `error' options where an IDENTIFIER was expected; Provide
21530 CheckToken and CheckIdentifierToken convenience error reporting
21533 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21535 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21536 NameSpaceEntry NameSpaceEntry.
21538 (LookupInterfaceOrClass): Avoid creating a full qualified name
21539 from namespace and name: avoid doing lookups when we know the
21540 namespace is non-existant. Use new Tree.LookupByNamespace which
21541 looks up DeclSpaces based on their namespace, name pair.
21543 * driver.cs: Provide a new `parser verbose' to display the
21544 exception thrown during parsing. This is turned off by default
21545 now, so the output of a failure from mcs is more graceful.
21547 * namespace.cs: Track all the namespaces defined in a hashtable
21550 (IsNamespace): New method
21552 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21554 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21555 we know that we need to concatenate (full typename can never be
21560 * statement.cs: Use a bitfield; Do not initialize to null things
21561 which are done by the constructor by default.
21563 * cs-parser.jay: bug fix, parameter was 4, not 3.
21565 * expression.cs: Just use the property;
21567 * statement.cs: No need for GetVariableInfo method.
21569 2003-08-08 Martin Baulig <martin@ximian.com>
21571 * flowanalysis.cs (FlowReturns): This is now nested in the
21572 `FlowBranching' class.
21573 (MyBitVector): Moved this here from statement.cs.
21574 (FlowBranching.SiblingType): New enum type.
21575 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21577 2003-08-07 Martin Baulig <martin@ximian.com>
21579 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21580 `FlowBranching' class and called `BranchingType'.
21582 2003-08-07 Martin Baulig <martin@ximian.com>
21584 * flowanalysis.cs: Moved all the control flow analysis code into
21587 2003-08-07 Martin Baulig <martin@ximian.com>
21589 * assign.cs (Assign.DoResolve): `target' must either be an
21590 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21593 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21595 * expression.cs (BinaryMethod): This kind of expression is created by the
21596 Binary class if it determines that the operator has to be handled
21599 (BinaryDelegate): This kind of expression is created if we are
21600 dealing with a + or - operator on delegates.
21602 (Binary): remove method, argumetns, and DelegateOperator: when
21603 dealing with methods,
21605 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21607 * statement.cs (Block): use bitfields for the three extra booleans
21608 we had in use. Remove unused topblock parameter.
21610 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21612 * assign.cs: Drop extra unneeded tests.
21614 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21616 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21618 * statement.cs (Foreach): Use VariableStorage instead of
21621 * codegen.cs (VariableStorage): New class used by clients that
21622 require a variable stored: locals or fields for variables that
21623 need to live across yield.
21625 Maybe provide a convenience api for EmitThis+EmitLoad?
21627 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21630 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21632 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21633 RemapParameterLValue): New methods that are used to turn a
21634 precomputed FieldInfo into an expression like this:
21638 The idea is to use this instead of making LocalVariableReference
21639 have more than one meaning.
21641 * cs-parser.jay: Add error production to BASE.
21643 * ecore.cs: Deal with TypeManager.GetField returning null, which
21644 is now a valid return value.
21646 (FieldExprNoAddress): New expression for Fields whose address can
21649 * expression.cs (LocalVariableReference): During the resolve
21650 phases, create new expressions if we are in a remapping context.
21651 Remove code that dealt with remapping here.
21653 (ParameterReference): same.
21655 (ProxyInstance): New expression, like the `This' expression, but
21656 it is born fully resolved. We know what we are doing, so remove
21657 the errors that are targeted to user-provided uses of `this'.
21659 * statement.cs (Foreach): our variable is now stored as an
21660 Expression; During resolution, follow the protocol, dont just
21661 assume it will return this.
21663 2003-08-06 Martin Baulig <martin@ximian.com>
21665 * support.cs (SeekableStreamReader.cs): New public class.
21667 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21668 SeekableStreamReader instead of the normal StreamReader.
21670 2003-08-04 Martin Baulig <martin@ximian.com>
21672 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21673 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21674 deambiguate casts and delegate invocations.
21675 (parenthesized_expression): Use the new tokens to ensure this is
21676 not a cast of method invocation.
21678 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21679 when reading a `)' and Deambiguate_CloseParens () was previously
21682 * expression.cs (ParenthesizedExpression): New class. This is
21683 just used for the CS0075 test.
21684 (Binary.DoResolve): Check for CS0075.
21686 2003-07-29 Ravi Pratap <ravi@ximian.com>
21688 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21689 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21690 reference comparison.
21692 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21693 examine the ReturnType for equality - this is necessary in the
21694 cases of implicit and explicit operators whose signature also
21695 includes the return type.
21697 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21699 * namespace.cs: Cache the result of the namespace computation,
21700 instead of computing it every time.
21702 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21704 * decl.cs: Use a global arraylist that we reuse over invocations
21705 to avoid excesive memory consumption. Reduces memory usage on an
21706 mcs compile by one meg (45 average).
21708 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21709 private, work around that.
21711 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21713 * literal.cs (IntLiteral): Define Zero and One static literals.
21715 * cs-parser.jay (integer_literal): use static literals to reduce
21716 memory usage for the most used literals (0, 1 and -1). 211kb
21717 reduced in memory usage.
21719 Replace all calls to `new ArrayList' with `new
21720 ArrayList(4)' which is a good average number for most allocations,
21721 and also requires only 16 bytes of memory for its buffer by
21724 This reduced MCS memory usage in seven megabytes for the RSS after
21727 2003-07-28 Ravi Pratap <ravi@ximian.com>
21729 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21730 handle params methods the correct way by forming only one
21731 applicable set with params and normal methods in them. Earlier we
21732 were looking at params methods only if we found no normal methods
21733 which was not the correct thing to do.
21735 (Invocation.BetterFunction): Take separate arguments indicating
21736 when candidate and the best method are params methods in their
21739 This fixes bugs #43367 and #46199.
21741 * attribute.cs: Documentation updates.
21743 (CheckAttribute): Rename to CheckAttributeTarget.
21744 (GetValidPlaces): Rename to GetValidTargets.
21746 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21747 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21751 2003-07-28 Martin Baulig <martin@ximian.com>
21753 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21754 name when looking up the base class of a nested class. Fixes #46977.
21756 2003-07-26 Martin Baulig <martin@ximian.com>
21758 * expression.cs (Indexers.Indexer): New nested struct; contains
21759 getter, setter and the indexer's type.
21760 (Indexers.Properties): This is now an ArrayList of
21761 Indexers.Indexer's.
21762 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21763 indexer doesn't have any getters.
21765 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21766 for embedded property and indexer assignments.
21768 2003-07-26 Martin Baulig <martin@ximian.com>
21770 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21771 preprocessor directive is not the first non-whitespace character
21774 2003-07-26 Martin Baulig <martin@ximian.com>
21776 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21777 namespace parsing, follow the spec more closely.
21779 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21780 NamespaceEntry.Lookup().
21782 2003-07-25 Martin Baulig <martin@ximian.com>
21784 * MethodCore.cs (OverridesSomething): New public field; it's set
21785 from TypeContainer.DefineMembers if this method overrides
21786 something (which doesn't need to be a method). Fix #39462.
21788 2003-07-25 Ravi Pratap <ravi@ximian.com>
21790 * typemanager.cs (GetMembers): Ensure that the list of members is
21791 reversed. This keeps things in sync.
21793 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21794 find an AttributeUsage attribute.
21796 * expression.cs (Invocation.OverloadResolve): Perform the check
21797 which disallows Invoke to be directly called on a Delegate.
21799 (Error_InvokeOnDelegate): Report error cs1533.
21801 2003-07-25 Martin Baulig <martin@ximian.com>
21803 * expression.cs (Indexers.GetIndexersForType): Only look in the
21804 interface hierarchy if the requested type is already an
21805 interface. Fixes #46788 while keeping #46502 fixed.
21807 2003-07-25 Martin Baulig <martin@ximian.com>
21809 * class.cs (TypeContainer.DefineMembers): Check whether all
21810 readonly fields have been assigned and report warning CS0649 if
21813 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21816 2003-07-24 Ravi Pratap <ravi@ximian.com>
21818 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21819 returned from GetMethods to make things consistent with the
21820 assumptions MCS makes about ordering of methods.
21822 This should comprehensively fix bug #45127 and it does :-)
21824 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21825 ordering is actually reverse.
21827 * Clean up some debug messages I left lying around.
21829 * interface.cs (Populate*): Get rid of code which emits attributes
21830 since the stage in which we emit attributes is the 'Emit' stage,
21831 not the define stage.
21833 (Emit): Move attribute emission for interface members here.
21835 2003-07-22 Ravi Pratap <ravi@ximian.com>
21837 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21838 closely: we eliminate methods in base types when we have an
21839 applicable method in a top-level type.
21841 Please see section 14.5.5.1 for an exact description of what goes
21844 This fixes bug #45127 and a host of other related to corlib compilation.
21846 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21847 array is the method corresponding to the top-level type (this is
21848 because of the changes made to icall.c) so we change this
21851 (MethodGroupExpr.Name): This too.
21853 * typemanager.cs (GetElementType): New method which does the right
21854 thing when compiling corlib.
21856 * everywhere: Make use of the above in the relevant places.
21858 2003-07-22 Martin Baulig <martin@ximian.com>
21860 * cs-parser.jay (invocation_expression): Moved
21861 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21862 `cast_expression', but create a InvocationOrCast which later
21863 resolves to either an Invocation or a Cast.
21865 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21866 method; call this before EmitStatement() to make sure that this
21867 expression can be used as a statement.
21869 * expression.cs (InvocationOrCast): New class; resolves to either
21870 an Invocation or a Cast.
21872 * statement.cs (StatementExpression): Call ResolveStatement() on
21873 the ExpressionStatement before emitting it.
21875 2003-07-21 Martin Baulig <martin@ximian.com>
21877 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21878 `ref' and `out' attributes match; fixes #46220.
21879 (MemberAccess.ResolveMemberAccess): You can't reference a type
21880 through an expression; fixes #33180.
21881 (Indexers.GetIndexersForType): Don't return the indexers from
21882 interfaces the class implements; fixes #46502.
21884 2003-07-21 Martin Baulig <martin@ximian.com>
21886 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21887 CS0661 checks; fixes bug #30442.
21889 2003-07-21 Martin Baulig <martin@ximian.com>
21891 * decl.cs (AdditionResult): Added `Error'.
21893 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21895 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21896 makes cs0031.cs actually work.
21898 2003-07-20 Martin Baulig <martin@ximian.com>
21900 * namespace.cs: Fixed that bug which caused a crash when compiling
21901 the debugger's GUI.
21903 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21905 * typemanager.cs (LookupTypeReflection): Never expose types which
21906 are NotPublic, NestedPrivate, NestedAssembly, or
21907 NestedFamANDAssem. We used to return these, and later do a check
21908 that would report a meaningful error, but the problem is that we
21909 would not get the real match, if there was a name override.
21911 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21913 * namespace.cs (Namespace, Name): Do not compute the namespace
21914 name dynamically, compute it in the constructor. This reduced
21915 memory usage by 1697 KB.
21917 * driver.cs: Use --pause to pause at the end.
21919 2003-07-17 Peter Williams <peter@newton.cx>
21921 * Makefile: Change the name of the test target so that it doesn't
21922 conflict with the recursive test target.
21924 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21926 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21927 AddressOf): Do not use EmitThis, that was wrong, use the actual
21930 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21932 * class.cs (MethodData.Define): While checking if a method is an
21933 interface implementation, improve the test: If we are not public
21934 (use new test here: use the computed MethodAttributes directly,
21935 instead of the parsed modifier flags) check if the `implementing'
21936 method comes from an interface or not.
21938 * pending.cs (VerifyPendingMethods): Slightly better error
21941 * makefile: add test target that does the mcs bootstrap.
21943 2003-07-16 Ravi Pratap <ravi@ximian.com>
21945 * interface.cs (Define): Do nothing here since there are no
21946 members to populate etc. Move the attribute emission out of here
21947 since this was just totally the wrong place to put it. Attribute
21948 application happens during the 'Emit' phase, not in the 'Define'
21951 (Emit): Add this method and move the attribute emission here
21953 * rootcontext.cs (EmitCode): Call the Emit method on interface
21956 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21958 * expression.cs (OverloadResolve): Report error only if Location
21959 is not 'Null' which means that there was a probe going on.
21961 2003-07-14 Martin Baulig <martin@ximian.com>
21963 * expression.cs (ConditionalLogicalOperator): New public class to
21964 implement user defined conditional logical operators.
21965 This is section 14.11.2 in the spec and bug #40505.
21967 2003-07-14 Martin Baulig <martin@ximian.com>
21969 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21971 2003-07-14 Martin Baulig <martin@ximian.com>
21973 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21975 * ecore.cs (IVariable.VerifyFixed): New interface method.
21977 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21978 operator, check whether the variable is actually fixed. Fixes bug
21979 #36055. Set a variable definitely assigned when taking its
21980 address as required by the spec.
21982 * statement.cs (LocalInfo.IsFixed): New field.
21983 (LocalInfo.MakePinned): Set `IsFixed' to true.
21985 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21987 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21988 for .ctors, ensure that we only ask for members declared in the
21989 attribute type (BindingFlags.DeclaredOnly).
21993 * expression.cs (Error_WrongNumArguments): Report error 1501
21994 correctly the way CSC does.
21996 2003-07-13 Martin Baulig <martin@ximian.com>
21998 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21999 lookup on the fully qualified name, to make things like "X.X" work
22000 where "X.X" is a fully qualified type name, but we also have a
22001 namespace "X" in the using list. Fixes #41975.
22003 2003-07-13 Martin Baulig <martin@ximian.com>
22005 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
22006 function. If we're a CompoundAssign, we need to create an embedded
22007 CompoundAssign, not an embedded Assign.
22008 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
22011 2003-07-13 Martin Baulig <martin@ximian.com>
22013 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
22014 work to fix bug #46088.
22016 2003-07-13 Ravi Pratap <ravi@ximian.com>
22018 * class.cs (Operator.Emit): Do not emit attributes here - it is
22019 taken care of by the Method class that we delegate too. This takes
22020 care of bug #45876.
22022 2003-07-10 Martin Baulig <martin@ximian.com>
22024 * expression.cs (TypeOfVoid): New class.
22025 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
22027 2003-07-10 Martin Baulig <martin@ximian.com>
22029 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
22032 2003-07-10 Martin Baulig <martin@ximian.com>
22034 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
22035 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
22037 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
22039 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
22041 2003-07-10 Martin Baulig <martin@ximian.com>
22043 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
22044 of decimal. Fixes #42850.
22046 NOTE: I also fixed the created byte blob, but this doesn't work on
22047 the MS runtime and csc never produces any byte blobs for decimal
22050 2003-07-10 Martin Baulig <martin@ximian.com>
22052 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
22053 structs; fixes #32068.
22054 (Block.AddChildVariableNames): Fixed #44302.
22056 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22058 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
22060 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22062 * attribute.cs: And this test is onger needed.
22064 2003-07-08 Martin Baulig <martin@ximian.com>
22066 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
22067 inaccessible types. Fixes #36313.
22069 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
22071 * namespace.cs (NamespaceEntry): Create implicit entries for all
22072 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
22073 implicit entries for N1.N2 and N1.
22075 2003-07-08 Martin Baulig <martin@ximian.com>
22077 Rewrote the handling of namespaces to fix a lot of the issues
22078 wrt. `using' aliases etc.
22080 * namespace.cs (Namespace): Splitted this class into a
22081 per-assembly `Namespace' and a per-file `NamespaceEntry'.
22083 * typemanager.cs (TypeManager.IsNamespace): Removed.
22084 (TypeManager.ComputeNamespaces): Only compute namespaces from
22085 loaded assemblies here, not the namespaces from the assembly we're
22086 currently compiling.
22088 2003-07-08 Martin Baulig <martin@ximian.com>
22090 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
22092 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22094 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
22097 I thought about the memory savings here, but LookupTypeReflection
22098 is used under already very constrained scenarios. Compiling
22099 corlib or mcs only exposes one hit, so it would not really reduce
22100 any memory consumption.
22102 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22104 * typemanager.cs: fixes bug #45889 by only adding public types from
22105 other assemblies to the list of known types.
22107 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22109 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
22110 on the type we resolved.
22112 2003-07-05 Martin Baulig <martin@ximian.com>
22114 * pending.cs (PendingImplementation.ParentImplements): Don't
22115 create the proxy if the parent is abstract.
22117 * class.cs (TypeContainer.DefineIndexers): Process explicit
22118 interface implementations first. Fixes #37714.
22120 2003-07-04 Miguel de Icaza <miguel@ximian.com>
22122 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
22123 defined recursively; but since we modify the input parameters
22124 (left is set to `this' temporarily), we reset this value if the
22125 left_is_explicit is false, which gives the original semantics to
22128 * literal.cs (NullPointer): new class used to represent a null
22129 literal in a pointer context.
22131 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
22132 type is a pointer, use a NullPointer object instead of a
22133 NullLiteral. Closes 43687
22135 (ExplicitConversion): Convert pointer values using
22136 the conv opcode to the proper type.
22138 * ecore.cs (New): change ValueTypeVariable property into a method,
22139 that returns whether the valuetype is suitable for being used.
22141 * expression.cs (Binary.DoNumericPromotions): Only return if we
22142 the int constant was a valid uint, and we can return both left and
22143 right as uints. If not, we continue processing, to trigger the
22144 type conversion. This fixes 39018.
22146 * statement.cs (Block.EmitMeta): During constant resolution, set
22147 the CurrentBlock property on the emitcontext, so that we resolve
22148 constants propertly.
22150 2003-07-02 Martin Baulig <martin@ximian.com>
22152 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
22153 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
22155 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
22156 than emitting it here.
22158 * statement.cs: Fixed some more flow analysis bugs.
22160 2003-07-02 Martin Baulig <martin@ximian.com>
22162 * class.cs (MethodData.Define): When implementing interface
22163 methods, set Final unless we're Virtual.
22165 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
22166 check work for interface methods.
22168 2003-07-01 Martin Baulig <martin@ximian.com>
22170 * ecore.cs (EmitContext.This): Replaced this property with a
22171 GetThis() method which takes a Location argument. This ensures
22172 that we get the correct error location for a CS0188.
22174 2003-07-01 Miguel de Icaza <miguel@ximian.com>
22176 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
22177 ImplicitStandardConversion.
22179 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
22181 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
22183 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
22186 2003-06-30 Miguel de Icaza <miguel@ximian.com>
22188 * class.cs (Constructor.Define): Turn off initlocals for unsafe
22191 (MethodData.Define): Turn off initlocals for unsafe methods.
22193 2003-06-29 Miguel de Icaza <miguel@ximian.com>
22195 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
22196 complete; Fixes #37521.
22198 * delegate.cs: Use Modifiers.TypeAttr to compute the
22199 TypeAttributes, instead of rolling our own. This makes the flags
22200 correct for the delegates.
22202 2003-06-28 Miguel de Icaza <miguel@ximian.com>
22204 * class.cs (Constructor.Define): Set the private flag for static
22205 constructors as well.
22207 * cs-parser.jay (statement_expression): Set the return value to
22208 null, to avoid a crash when we catch an error.
22210 2003-06-24 Miguel de Icaza <miguel@ximian.com>
22212 * cs-parser.jay: Applied patch from Jackson that adds support for
22213 extern and unsafe modifiers to destructor declarations.
22215 * expression.cs: Report error 21 if the user is trying to index a
22218 * driver.cs: Add an error message, suggested by the bug report.
22220 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
22221 if we do not have a ": this ()" constructor initializer. Fixes 45149
22223 2003-06-14 Miguel de Icaza <miguel@ximian.com>
22225 * namespace.cs: Add some information to reduce FAQs.
22227 2003-06-13 Miguel de Icaza <miguel@ximian.com>
22229 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
22230 underlying enumeration types. Fixes #43915.
22232 * expression.cs: Treat ushort/short as legal values to be used in
22233 bitwise operations.
22235 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
22237 * delegate.cs: transfer custom attributes for paramenters from
22238 the delegate declaration to Invoke and BeginInvoke.
22240 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
22242 * attribute.cs: handle custom marshalers and emit marshal info
22245 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
22247 * makefile.gnu: Added anonymous.cs to the compiler sources.
22249 2003-05-28 Miguel de Icaza <miguel@ximian.com>
22251 * iterators.cs: Change the name of the proxy class to include two
22254 * cs-parser.jay: Update grammar to include anonymous methods.
22256 * anonymous.cs: new file.
22258 2003-05-27 Miguel de Icaza <miguel@ximian.com>
22260 * class.cs (Field.Define): Add missing test for pointers and
22263 2003-05-27 Ravi Pratap <ravi@ximian.com>
22265 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
22266 we use the stobj opcode.
22268 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
22269 since it wasn't the correct fix.
22271 It still is puzzling that we are required to use stobj for IntPtr
22272 which seems to be a ValueType.
22274 2003-05-26 Miguel de Icaza <miguel@ximian.com>
22276 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
22277 during regular simple name resolution. Now, the trick is that
22278 instead of returning for processing the simplename, we do a
22279 TypeManager.LookupType (ie, a rooted lookup as opposed to a
22280 contextual lookup type). If a match is found, return that, if
22281 not, return for further composition.
22283 This fixes long-standing 30485.
22285 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
22286 using the address to initialize an object, do an Stobj instead of
22287 using the regular Stelem.
22289 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
22290 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
22291 Because if we are a BaseIndexerAccess that value will be true.
22294 * statement.cs (GotoCase.Resolve): Return after reporting an
22295 error, do not attempt to continue.
22297 * expression.cs (PointerArithmetic.Emit): If our operand is a
22298 long, convert our constants to match the operand before
22299 multiplying. Convert to I type before adding. Fixes 43670.
22301 2003-05-14 Ravi Pratap <ravi@ximian.com>
22303 * enum.cs (ImplicitConversionExists) : Rename to
22304 ImplicitEnumConversionExists to remove ambiguity.
22306 * ecore.cs (NullCast): New type of cast expression class which
22307 basically is very similar to EmptyCast with the difference being
22308 it still is a constant since it is used only to cast a null to
22310 (eg. (string) null)
22312 * convert.cs (ImplicitReferenceConversion): When casting a null
22313 literal, we return a NullCast.
22315 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22316 should be around anymore.
22318 The renaming (reported was slightly wrong). Corrections:
22320 ConvertImplicitStandard -> ImplicitConversionStandard
22321 ConvertExplicitStandard -> ExplicitConversionStandard
22323 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22324 before passing them in !
22326 * convert.cs (ImplicitConversionStandard): When comparing for
22327 equal expr and target types, ensure that expr is not a
22330 In general, we must not be checking (expr_type ==
22331 target_type) in the top level conversion methods
22332 (ImplicitConversion, ExplicitConversion etc). This checking is
22333 done in the methods that they delegate to.
22335 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22337 * convert.cs: Move Error_CannotConvertType,
22338 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22339 ImplicitNumericConversion, ImplicitConversionExists,
22340 ImplicitUserConversionExists, StandardConversionExists,
22341 FindMostEncompassedType, FindMostSpecificSource,
22342 FindMostSpecificTarget, ImplicitUserConversion,
22343 ExplicitUserConversion, GetConversionOperators,
22344 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22345 TryImplicitIntConversion, Error_CannotConvertImplicit,
22346 ConvertImplicitRequired, ConvertNumericExplicit,
22347 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22348 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22351 Perform the following renames:
22353 StandardConversionExists -> ImplicitStandardConversionExists
22354 ConvertImplicit -> ImplicitConversion
22355 ConvertImplicitStandard -> ImplicitStandardConversion
22356 TryImplicitIntConversion -> ImplicitIntConversion
22357 ConvertImplicitRequired -> ImplicitConversionRequired
22358 ConvertNumericExplicit -> ExplicitNumericConversion
22359 ConvertReferenceExplicit -> ExplicitReferenceConversion
22360 ConvertExplicit -> ExplicitConversion
22361 ConvertExplicitStandard -> ExplicitStandardConversion
22363 2003-05-19 Martin Baulig <martin@ximian.com>
22365 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22366 (TypeInfo): Added support for structs having structs as fields.
22368 * ecore.cs (FieldExpr): Implement IVariable.
22369 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22370 VariableInfo for the field.
22372 2003-05-18 Martin Baulig <martin@ximian.com>
22374 * expression.cs (This.DoResolve): Report a CS0027 if we're
22375 emitting a field initializer.
22377 2003-05-18 Martin Baulig <martin@ximian.com>
22379 * expression.cs (This.ResolveBase): New public function.
22380 (This.DoResolve): Check for CS0188.
22382 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22385 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22386 `instance_expression' to null if we don't have any non-static
22389 2003-05-18 Martin Baulig <martin@ximian.com>
22391 Reworked the way how local variables and parameters are handled by
22392 the flow analysis code.
22394 * statement.cs (TypeInfo, VariableMap): New public classes.
22395 (VariableInfo): New public class. This is now responsible for
22396 checking whether a variable has been assigned. It is used for
22397 parameters and local variables.
22398 (Block.EmitMeta): Take the InternalParameters as argument; compute
22399 the layout of the flow vectors here.
22400 (Block.LocalMap, Block.ParameterMap): New public properties.
22401 (FlowBranching): The .ctor doesn't get the InternalParameters
22402 anymore since Block.EmitMeta() now computes the layout of the flow
22404 (MyStructInfo): This class is now known as `StructInfo' and nested
22405 in `TypeInfo'; we don't access this directly anymore.
22407 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22408 property and removed IsAssigned(), IsFieldAssigned(),
22409 SetAssigned() and SetFieldAssigned(); we now call them on the
22410 VariableInfo so we don't need to duplicate this code everywhere.
22412 * expression.cs (ParameterReference): Added `Block block' argument
22414 (LocalVariableReference, ParameterReference, This): The new
22415 VariableInfo class is now responsible for all the definite
22418 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22419 IsParameterAssigned, SetParameterAssigned): Removed.
22421 2003-05-18 Martin Baulig <martin@ximian.com>
22423 * typemanager.cs (InitCoreTypes): Try calling
22424 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22425 the 3-args-version. Corlib now also needs our `void_type'.
22426 (GetMethod): Added overloaded version which takes an optional
22427 `bool report_errors' to allow lookups of optional methods.
22429 2003-05-12 Martin Baulig <martin@ximian.com>
22431 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22432 only used for locals and not for parameters.
22434 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22436 * support.cs (InternalParameters.ParameterType): Return the
22437 ExternalType of the parameter.
22439 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22442 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22444 * class.cs (MethodData.Define): Do not set the `newslot' on
22445 interface members, if they are also flagged as "override".
22447 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22448 better code for ++i and i++. This only works for static fields
22449 and local variables.
22451 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22452 want to pull the DeclSpace out of the builder_to_declspace instead
22453 of the TypeBuilder (like in TypeContainer.FindMembers).
22455 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22456 instead of LookupTypeContainer. Fixes the crash on .NET for
22457 looking up interface members.
22459 * const.cs: Create our own emit context during the Definition
22460 stage, so that constants are evaluated in the proper context, when
22461 a recursive definition happens.
22463 2003-05-11 Martin Baulig <martin@ximian.com>
22465 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22466 new block for a switch section.
22467 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22468 the adding/lookup in the switch block. Fixes #39828.
22470 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22472 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22473 functionality: I needed to convert the data after I had performed
22474 the add/sub operation into the operands type size.
22476 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22477 pass the type for the box operation, otherwise the resulting
22478 object would have been of type object.
22480 (BoxedCast): Add constructor to specify the type to box as.
22482 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22484 * iterators.cs: I was reusing the `count' variable inadvertently,
22485 take steps to not allow this to happen.
22487 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22489 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22490 by creating an array at the point where the params starts and
22491 putting all those arguments there, then adjusting the size of the
22494 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22496 * expression.cs (New.AddressOf): Implement interface
22497 IMemoryLocation. This is used when the `new' operator is used in
22498 the context of an invocation to a method on a value type.
22500 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22503 * namespace.cs: Also check the using aliases here.
22505 * driver.cs: Move the test for using validity after the types have
22506 been entered, so we do a single pass that also includes the using
22509 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22510 in the regular case. CreateSiblingForFinally is doing extra
22513 * attribute.cs (GetAttributeArgumentExpression): Store the result
22514 on an out value, and use the return value to indicate failure
22515 instead of using null (which is a valid return for Constant.GetValue).
22517 * statement.cs: Perform the analysis flow for the increment
22518 portion after the statement, because this will be the real flow of
22519 execution. Fixes #42385
22521 * codegen.cs (EmitContext.EmitArgument,
22522 EmitContext.EmitStoreArgument): New helper functions when the
22523 RemapToProxy flag is set.
22525 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22528 Add support for remapping parameters.
22530 * iterators.cs: Propagate parameter values; Store parameter
22531 values in the proxy classes.
22533 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22535 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22536 need a proxy reference; I do not know what I was thinking
22538 * cs-parser.jay (constructor_initializer): catch another error,
22539 and display nice message.
22541 (field_declaration): catch void field declaration
22542 to flag a better error.
22544 * class.cs (MemberBase.CheckBase): Report an error instead of a
22545 warning if a new protected member is declared in a struct.
22546 (Field.Define): catch the error of readonly/volatile.
22548 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22550 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22551 volatile variable is taken
22553 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22555 * statement.cs (Fixed.Resolve): Report an error if we are not in
22558 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22560 * typemanager.cs: reuse the code that handles type clashes for
22561 delegates and enumerations.
22563 * class.cs (Report28): Always report.
22565 * expression.cs (EncodeAsAttribute): Allow nulls here.
22567 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22569 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22570 the functionality for testing whether an expression is valid for
22571 an attribute here. Also handle the case of arrays of elements
22574 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22575 encoding a linear array into an array of objects that are suitable
22576 to be passed to an CustomAttributeBuilder.
22578 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22580 * ecore.cs: (FieldExpr): Handle field remapping here.
22582 * iteratators.cs: Pass the instance variable (if the method is an
22583 instance method) to the constructors, so we can access the field
22584 variables on the class.
22586 TODO: Test this with structs. I think the THIS variable on
22587 structs might have to be a pointer, and not a refenrece
22589 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22591 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22592 local variables to fields in a proxy class.
22594 * iterators.cs (PopulateProxy): Rename our internal fields to
22596 Create a <THIS> field if we are an instance method, so we can
22597 reference our parent container variables.
22598 (MapVariable): Called back from the EmitContext code to enter a
22599 new variable to field mapping into the proxy class (we just create
22603 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22604 for using the remapped locals to fields.
22606 I placed the code here, because that gives the same semantics to
22607 local variables, and only changes the Emit code.
22609 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22610 statements inside iterators.
22611 (VariableInfo): Add a FieldBuilder for the cases when we are
22612 remapping local variables to fields in a proxy class
22614 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22615 current_block != null.
22617 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22618 not cope with strings, as it has been moved to the
22619 TableSwitchEmit. Fixed bug in switch generation.
22621 * expression.cs (New.DoResolve): Provide more context for the user
22622 when reporting an error.
22624 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22627 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22628 check the permissions for it. Note than in a type-resolution
22629 context the check was already present in DeclSpace.ResolveType,
22630 but was missing from the MemberAccess.
22632 (ArrayCreation.CheckIndices): warn if the user has
22633 more nested levels of expressions, but there are no more
22634 dimensions specified. Avoids crash on bug 41906.
22636 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22638 * statement.cs (Block): replace Implicit bool, for a generic
22640 New flag: `Unchecked'. This is used during the EmitMeta phase
22641 (which is out-of-line with the regular Resolve/Emit process for a
22642 statement, as this is done ahead of time, but still gets a chance
22643 to call constant resolve).
22645 (Block.Flags): new enum for adding a new flag.
22647 (Block.EmitMeta): track the state of unchecked.
22649 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22650 to enable constant resolution to work there as well.
22652 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22654 * typemanager.cs (ienumerable_type): Also look up
22655 System.Collections.IEnumerable.
22657 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22659 TODO: Test more than one conditional per method.
22661 * class.cs (Indexer.Define): Report the location where the user is
22662 referencing the unsupported feature.
22664 (MethodData): Overload the use of `conditionals' to
22665 minimize the creation of needless ArrayLists. This saves roughly
22666 212kb on my machine.
22668 (Method): Implement the new IIteratorContainer interface.
22669 (Method.SetYields): Implement the method by setting the ModFlags
22670 to contain METHOD_YIELDS.
22672 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22673 which just got set to null.
22675 * iterators.cs: New file.
22677 (Yield, YieldBreak): New statements.
22679 * statement.cs (Return.Resolve): Flag an error if we are used in
22680 an iterator method.
22682 * codegen.cs (InIterator): New flag set if the code is being
22683 compiled in an iterator method.
22685 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22686 internal modifier, and we just use it to avoid adding extra
22687 fields, as this is seldom used.
22689 * cs-parser.jay: Add yield_statement (yield and yield break).
22691 * driver.cs: New flag -v2 to turn on version 2 features.
22693 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22694 hashtable when v2 is enabled.
22696 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22698 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22699 there is already a namespace defined with this name.
22701 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22702 people upgraded their corlibs.
22704 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22705 always use fully qualified types, no need to use the compiler
22708 (TypeManager.IsNamespace): Use binarysearch.
22710 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22711 AddDelegate): I did not quite use the new IsValid API properly: I
22712 have to pass the short-name and the fullname. I was passing only
22713 the basename instead of the fullname sometimes.
22715 (TypeContainer.DefineType): call NamespaceClash.
22717 * interface.cs (Interface.DefineType): use NamespaceClash before
22720 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22723 * enum.cs: (Enum.DefineType): use NamespaceClash before
22726 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22727 speed increase. First, use the negative_hits cache when we get a
22728 negative. Second, add the type with its full original name
22729 instead of the new . and + encoded name (reflection uses + to
22730 separate type from a nested type). Use LookupTypeReflection
22731 directly which bypasses the type->name hashtable (that we already
22732 know does not contain the type.
22734 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22735 location/container type.
22737 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22739 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22741 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22743 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22744 method is being referenced in the method group from a static
22745 context, and report error 120 if so.
22747 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22750 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22751 is created, we create the A namespace).
22753 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22756 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22758 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22759 invocation to ModuleBuilder.GetType with the same values will
22760 return a new type instance, so we need to cache its return
22763 * expression.cs (Binary.ResolveOperator): Only allow the compare
22764 operators on enums if they are of the same type.
22766 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22767 types of ValueType on their own case. Before we were giving them
22768 the same treatment as objects.
22770 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22771 fullname. Short name is used to compare against container name.
22772 Fullname is used to check against defined namespace names.
22774 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22775 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22777 (Method.CheckBase): Call parent.
22778 (MemberBase.CheckBase): Check for protected members on sealed
22780 (PropertyBase.CheckBase): Call parent.
22781 (Field.Define): Call parent.
22783 * report.cs: Negative error codes are now mapped to 8000 - code,
22784 so that the display is render more nicely.
22786 * typemanager.cs: Do not use try/catch, instead report a regular
22789 (GetPointerType, GetReferenceType): These methods provide
22790 mechanisms to obtain the T* and T& from a T. We had the code
22791 previously scattered around the code base, and it also used
22792 TypeManager.LookupType that would go through plenty of caches.
22793 This one goes directly to the type source.
22795 In some places we did the Type.GetType followed by
22796 ModuleBuilder.GetType, but not in others, so this unifies the
22797 processing as well.
22799 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22800 statements now that we have namespace information.
22802 * typemanager.cs (IsNamespace): New method, returns whether the
22803 string presented is a namespace or not.
22805 (ComputeNamespaces): New public entry point, computes the list of
22806 available namespaces, using the GetNamespaces API call in Mono, or
22807 the slower version in MS.NET.
22809 Now before we start the semantic analysis phase, we have a
22810 complete list of namespaces including everything that the user has
22813 Deleted old code to cache namespaces in .nsc files.
22815 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22817 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22818 class/struct location definition Location for the implicit
22819 constructor location.
22821 (Operator.Define): Use the location of the operator for the
22822 implicit Method definition.
22824 (Constructor.Emit): use the constructor location for the implicit
22825 base initializer constructor.
22827 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22828 and the Expression class now contains two new methods:
22830 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22831 isolate type lookup from the rest of the resolution process.
22833 Since we use Expressions to hold type definitions due to the way
22834 we parse the input we have historically overloaded Resolve to
22835 perform the Type lookups if a special flag is passed. Now this is
22836 eliminated and two methods take their place.
22838 The differences in the two methods between xStep and xTerminal is
22839 that xStep is involved in our current lookup system that uses
22840 SimpleNames to compose a name, while xTerminal is used just to
22841 catch the case where the simplename lookup failed.
22843 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22845 * expression.cs (ResolveMemberAccess): Remove redundant code.
22846 TypeExpr expressions are always born fully resolved.
22848 * interface.cs (PopulateMethod): Do not lookup the types twice.
22849 We were doing it once during SemanticAnalysis and once during
22852 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22853 in local variable type definitions, were being returned as a
22854 SimpleName (we decomposed everything into a string), that is
22855 because primary_expression was being used instead of a type in the
22856 grammar (reduce/reduce conflicts).
22858 The part that was wrong is that we converted the expression into a
22859 string (an oversimplification in one hand, compounded with primary
22860 expressions doing string concatenation).
22866 Would return "A.B.C[]" as a SimpleName. This stopped things like
22867 using clauses from working on this particular context. And a type
22868 was being matched directly against "A.B.C[]".
22870 We now use the correct approach, and allow for ComposedCast to be
22871 part of the unary expression. So the "A.B.C []" become a composed
22872 cast of "A.B.C" (as a nested group of MemberAccess with a
22873 SimpleName at the end) plus the rank composition "[]".
22877 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22879 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22880 for the access level checking.
22882 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22883 `TypeContainer container', because I kept getting confused when I
22884 was debugging this code.
22886 * expression.cs (Indexers): Instead of tracking getters/setters,
22887 we now track them in parallel. We create one arraylist less, but
22888 most importantly it is possible now for the LValue code to find a
22889 matching get for a set.
22891 (IndexerAccess.DoResolveLValue): Update the code.
22892 GetIndexersForType has been modified already to extract all the
22893 indexers from a type. The code assumed it did not.
22895 Also make the code set the correct return type for the indexer.
22896 This was fixed a long time ago for properties, but was missing for
22897 indexers. It used to be void_type.
22899 (Binary.Emit): Test first for doubles instead of
22900 floats, as they are more common.
22902 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22903 when dealing with floats and the <=, >= operators. This fixes bug
22906 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22907 to load the array value by emitting a load on the foreach variable
22908 type. This was incorrect.
22910 We now emit the code to load an element using the the array
22911 variable type, and then we emit the conversion operator.
22915 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22917 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22919 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22921 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22922 test for protection before we test for signatures.
22924 (MethodSignature.ToString): implement.
22926 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22927 to the case where we reduced into a LongConstant.
22929 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22930 depend on whether the information is acurrate, because the
22931 Microsoft runtime will always claim that the array type is public,
22932 regardless of the real state.
22934 If the type is a pointer, another problem happens: the type is
22935 reported as non-public in Microsoft.
22937 In both cases we have to call CheckAccessLevel recursively with
22938 the underlying type as the argument to be tested.
22940 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22942 * assign.cs (Assign.Emit): If we are dealing with a compound
22943 assignment expression, we should use the code path that stores the
22944 intermediate result in a temporary value. This fixes #40903.
22946 *expression.cs (Indirection.ToString): Provide ToString method for
22949 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22951 * class.cs: Null out fields holding references to Block objects so
22952 they can be garbage collected.
22954 * expression.cs (OverloadResolve): Remove unused local.
22956 2003-04-07 Martin Baulig <martin@ximian.com>
22958 * codegen.cs (EmitContext.CurrentFile): New public field.
22959 (EmitContext.Mark): Use the CurrentFile to check whether the
22960 location is in the correct file.
22961 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22963 2003-04-07 Martin Baulig <martin@ximian.com>
22965 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22967 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22968 location. [FIXME: The location argument which gets passed to this
22969 method is sometimes wrong!]
22971 2003-04-07 Nick Drochak <ndrochak@gol.com>
22973 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22975 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22977 * expression.cs (Indirection.EmitAssign): We were using the
22978 temporary, but returning immediately instead of continuing the
22981 2003-04-06 Martin Baulig <martin@ximian.com>
22983 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22984 if it's a nested child, but also deriving from the outer class.
22987 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22988 nested child, but also deriving from the outer class. See
22990 (FilterWithClosure): We may access private members of the outer
22991 class if we're a nested child and deriving from the outer class.
22992 (RealMemberLookup): Only set `closure_private_ok' if the
22993 `original_bf' contained BindingFlags.NonPublic.
22995 2003-04-05 Martin Baulig <martin@ximian.com>
22997 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22999 2003-04-02 Miguel de Icaza <miguel@ximian.com>
23001 * class.cs (Event.Define): Do not allow abstract events to have
23004 2003-04-01 Miguel de Icaza <miguel@ximian.com>
23006 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
23007 block in event declarations.
23009 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
23010 value type, get its address.
23012 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
23013 leaving a class on the stack instead of a boolean value (int
23014 0/1). Change the code so we compare against null, and then the
23015 result against zero.
23017 * class.cs (TypeContainer.GetClassBases): We were checking for the
23018 parent class being sealed too late.
23020 * expression.cs (Binary.Emit): For <= and >= when dealing with
23021 floating point values, use cgt.un and clt.un instead of cgt and
23024 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
23026 * statement.cs: Apply the same optimization as MS: skip the
23027 GetEnumerator returning an IEnumerator, and use the one returning a
23028 CharEnumerator instead. This allows us to avoid the try-finally block
23031 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
23033 * cs-parser.jay: Attributes cannot be applied to
23034 namespaces. Fixes #40473
23036 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23039 (Add*): check if the name is valid using the full name for constants,
23040 fields, properties and events.
23042 2003-03-28 Miguel de Icaza <miguel@ximian.com>
23044 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
23045 char constants to be part of the enumeration.
23047 * expression.cs (Conditional.DoResolve): Add support for operator
23048 true. Implements the missing functionality from 14.12
23050 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
23051 operator true/false as required by the spec.
23053 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
23054 implicit conversion to boolean.
23056 * statement.cs (Statement.ResolveBoolean): A boolean expression is
23057 also one where the type implements `operator true'.
23059 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
23060 get an expression that will invoke operator true based on an
23063 (GetConversionOperators): Removed the hack that called op_True
23066 (Expression.ResolveBoolean): Move this from Statement.
23068 2003-03-17 Miguel de Icaza <miguel@ximian.com>
23070 * ecore.cs (FieldExpr): do not allow initialization of initonly
23071 fields on derived classes
23073 2003-03-13 Martin Baulig <martin@ximian.com>
23075 * statement.cs (Block.Emit): Call ig.BeginScope() and
23076 ig.EndScope() when compiling with debugging info; call
23077 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
23079 2003-03-08 Miguel de Icaza <miguel@ximian.com>
23081 * expression.cs (Indexers): Do not construct immediately, allow
23082 for new members to be appended as we go. Fixes 38143
23084 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23086 * expression.cs: save/restore context when resolving an unchecked
23089 2003-03-05 Miguel de Icaza <miguel@ximian.com>
23091 * cfold.cs: Catch division by zero in modulus operator during
23094 2003-03-03 Miguel de Icaza <miguel@ximian.com>
23096 * interface.cs (Interface.DefineMembers): Avoid defining members
23099 2003-02-27 Miguel de Icaza <miguel@ximian.com>
23101 * driver.cs: handle the +/- options for -noconfig
23103 * statement.cs (Unckeched.Resolve): Also track the state of
23104 unchecked in the Resolve phase.
23106 2003-02-27 Martin Baulig <martin@ximian.com>
23108 * ecore.cs (Expression.MemberLookup): Don't create a
23109 MethodGroupExpr for something which is not a method. Fixes #38291.
23111 2003-02-25 Miguel de Icaza <miguel@ximian.com>
23113 * class.cs (MemberBase.CheckParameters): Also check that the type
23114 is unmanaged if it is a pointer.
23116 * expression.cs (SizeOf.Resolve): Add location information.
23118 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
23119 a managed type is declared.
23121 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
23122 parameter modifiers as well. Fixes bug 38606
23124 * class.cs: Very sad. Am backing out the speed up changes
23125 introduced by the ArrayList -> Array in the TypeContainer, as they
23126 were not actually that much faster, and introduced a bug (no error
23127 reports on duplicated methods).
23129 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
23130 source first, this will guarantee that we have a valid expression
23131 before calling in lower levels functions that will require a
23132 resolved object. Then use this original_source in the
23133 target.ResolveLValue instead of the original source that was
23136 Another change. Use target.Resolve instead of LValueResolve.
23137 Although we are resolving for LValues, we will let the Assign code
23138 take care of that (it will be called again from Resolve). This
23139 basically allows code like this:
23141 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
23142 class Y { void A (X x) { x [0] += o; }
23144 The problem was that the indexer was trying to resolve for
23145 set_Item (idx, object o) and never finding one. The real set_Item
23146 was set_Item (idx, X). By delaying the process we get the right
23151 2003-02-23 Martin Baulig <martin@ximian.com>
23153 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
23154 while calling DoEmit ().
23156 * codegen.cs (EmitContext.Mark): Don't mark locations in other
23157 source files; if you use the #line directive inside a method, the
23158 compiler stops emitting line numbers for the debugger until it
23159 reaches the end of the method or another #line directive which
23160 restores the original file.
23162 2003-02-23 Martin Baulig <martin@ximian.com>
23164 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
23166 2003-02-23 Martin Baulig <martin@ximian.com>
23168 * statement.cs (Block.AddChildVariableNames): We need to call this
23169 recursively, not just for our immediate children.
23171 2003-02-23 Martin Baulig <martin@ximian.com>
23173 * class.cs (Event.Define): Always make the field private, like csc does.
23175 * typemanager.cs (TypeManager.RealMemberLookup): Make events
23176 actually work, fixes bug #37521.
23178 2003-02-23 Miguel de Icaza <miguel@ximian.com>
23180 * delegate.cs: When creating the various temporary "Parameters"
23181 classes, make sure that we call the ComputeAndDefineParameterTypes
23182 on those new parameters (just like we do with the formal ones), to
23183 allow them to be resolved in the context of the DeclSpace.
23185 This fixes the bug that Dick observed in Bugzilla #38530.
23187 2003-02-22 Miguel de Icaza <miguel@ximian.com>
23189 * expression.cs (ResolveMemberAccess): When resolving a constant,
23190 do not attempt to pull a constant if the value was not able to
23191 generate a valid constant.
23193 * const.cs (LookupConstantValue): Do not report more errors than required.
23195 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23197 * expression.cs: fixes bug #38328.
23199 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23201 * class.cs: Changed all the various members that can be part of a
23202 class from being an ArrayList to be an Array of the right type.
23203 During the DefineType type_list, interface_list, delegate_list and
23204 enum_list are turned into types, interfaces, delegates and enums
23207 And during the member population, indexer_list, event_list,
23208 constant_list, field_list, instance_constructor_list, method_list,
23209 operator_list and property_list are turned into their real arrays.
23211 Although we could probably perform this operation earlier, for
23212 good error reporting we need to keep the lists and remove the
23213 lists for longer than required.
23215 This optimization was triggered by Paolo profiling the compiler
23216 speed on the output of `gen-sample-program.pl' perl script.
23218 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
23219 not crash in methods like MemberLookupFailed that use this field.
23221 This problem arises when the compiler fails to resolve a type
23222 during interface type definition for example.
23224 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23226 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
23227 inherit from System.Object, so we have to stop at null, not only
23228 when reaching System.Object.
23230 2003-02-17 Miguel de Icaza <miguel@ximian.com>
23232 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
23233 DeclaredOnly because the parent indexer might have had a different
23234 name, but did not loop until the top of the hierarchy was reached.
23236 The problem this one fixes is 35492: when a class implemented an
23237 indexer from an interface, we were getting the interface method
23238 (which was abstract) and we were flagging an error (can not invoke
23241 This also keeps bug 33089 functioning, and test-148 functioning.
23243 * typemanager.cs (IsSpecialMethod): The correct way of figuring
23244 out if a method is special is to see if it is declared in a
23245 property or event, or whether it is one of the predefined operator
23246 names. This should fix correctly #36804.
23248 2003-02-15 Miguel de Icaza <miguel@ximian.com>
23250 The goal here is to remove the dependency on EmptyCast.Peel ().
23251 Killing it completely.
23253 The problem is that currently in a number of places where
23254 constants are expected, we have to "probe" for an EmptyCast, and
23255 Peel, which is not the correct thing to do, as this will be
23256 repetitive and will likely lead to errors.
23258 The idea is to remove any EmptyCasts that are used in casts that
23259 can be reduced to constants, so we only have to cope with
23262 This bug hunt was triggered by Bug 37363 and the desire to remove
23263 the duplicate pattern where we were "peeling" emptycasts to check
23264 whether they were constants. Now constants will always be
23267 * ecore.cs: Use an enumconstant here instead of wrapping with
23270 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
23271 throwing me off. By handling this we can get rid of a few hacks.
23273 * statement.cs (Switch): Removed Peel() code.
23275 2003-02-14 Miguel de Icaza <miguel@ximian.com>
23277 * class.cs: Location information for error 508
23279 * expression.cs (New.DoResolve): Add a guard against double
23280 resolution of an expression.
23282 The New DoResolve might be called twice when initializing field
23283 expressions (see EmitFieldInitializers, the call to
23284 GetInitializerExpression will perform a resolve on the expression,
23285 and later the assign will trigger another resolution
23287 This leads to bugs (#37014)
23289 * delegate.cs: The signature for EndInvoke should contain any ref
23290 or out parameters as well. We were not doing this in the past.
23292 * class.cs (Field.Define): Do not overwrite the type definition
23293 inside the `volatile' group. Turns out that volatile enumerations
23294 were changing the type here to perform a validity test, which
23297 2003-02-12 Miguel de Icaza <miguel@ximian.com>
23299 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
23300 and structs, we do not want to load the instance variable
23302 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
23303 enum_type has to be handled like an object reference (implicit
23304 conversions exists from this to object), but the regular IsClass
23305 and IsValueType tests will never return true for this one.
23307 Also we use TypeManager.IsValueType instead of type.IsValueType,
23308 just for consistency with the rest of the code (this is only
23309 needed if we ever use the construct exposed by test-180.cs inside
23310 corlib, which we dont today).
23312 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23314 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23317 2003-02-09 Martin Baulig <martin@ximian.com>
23319 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23320 (Namespace.DefineNamespaces): New static public method; this is
23321 called when we're compiling with debugging to add all namespaces
23322 to the symbol file.
23324 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23325 pass it to the Namespace's .ctor.
23327 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23328 and MethodBase arguments; pass the namespace ID to the symwriter;
23329 pass the MethodBase instead of the token to the symwriter.
23330 (SymbolWriter.DefineNamespace): New method to add a namespace to
23333 2003-02-09 Martin Baulig <martin@ximian.com>
23335 * symbolwriter.cs: New file. This is a wrapper around
23336 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23337 methods here in near future.
23339 2003-02-09 Martin Baulig <martin@ximian.com>
23341 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23342 ILGenerator.MarkSequencePoint() which are actually used by the
23345 2003-02-09 Martin Baulig <martin@ximian.com>
23347 * location.cs (SourceFile): New public sealed class. This
23348 contains the name and an index which is used in the location's token.
23349 (Location): Reserve an appropriate number of bits in the token for
23350 the source file instead of walking over that list, this gives us a
23351 really huge performance improvement when compiling with debugging.
23353 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23354 `SourceFile' argument instead of a string.
23355 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23356 but don't parse/tokenize here, we need to generate the list of all
23357 source files before we do that.
23358 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23361 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23362 instead of a string.
23364 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23367 2003-02-09 Martin Baulig <martin@ximian.com>
23369 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23370 filename on `#line default'.
23372 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23374 * statement.cs: don't clear the pinned var when the fixed statement
23375 returns from the method (fixes bug#37752).
23377 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23379 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23382 2003-02-07 Martin Baulig <martin@ximian.com>
23384 * driver.cs: Removed the `--debug-args' command line argument.
23386 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23387 automatically by the AsssemblyBuilder.
23388 (CodeGen.InitializeSymbolWriter): We don't need to call any
23389 initialization function on the symbol writer anymore. This method
23390 doesn't take any arguments.
23392 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23394 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23395 from referenced assemblies as well.
23397 2003-02-02 Martin Baulig <martin@ximian.com>
23399 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23401 2003-02-02 Martin Baulig <martin@ximian.com>
23403 * class.cs (Constructor.Emit): Open the symbol writer before
23404 emitting the constructor initializer.
23405 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23406 single-stepping through constructor initializers.
23408 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23410 * class.cs: Handle error 549: do not allow virtual methods in
23413 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23415 * decl.cs: Check access levels when resolving types
23417 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23419 * statement.cs: Add parameters and locals set in catch blocks that might
23420 return to set vector
23422 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23424 * class.cs (Operator): Set the SpecialName flags for operators.
23426 * expression.cs (Invocation.DoResolve): Only block calls to
23427 accessors and operators on SpecialName methods.
23429 (Cast.TryReduce): Handle conversions from char constants.
23432 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23434 * statement.cs: small memory and time optimization in FlowBranching.
23436 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23438 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23439 problem that the last fix but in the other sid (Set).
23441 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23442 access when there is no indexer in the hierarchy.
23444 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23446 * class.cs: Combine some if statements.
23448 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23450 * driver.cs: fixed bug #37187.
23452 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23454 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23455 any indexer, it's needed to build a list with all the indexers in the
23456 hierarchy (AllGetters), else we have problems. Fixes #35653.
23458 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23460 * class.cs (MethodData.Define): It is wrong for an interface
23461 implementation to be static in both cases: explicit and implicit.
23462 We were only handling this in one case.
23464 Improve the if situation there to not have negations.
23466 * class.cs (Field.Define): Turns out that we do not need to check
23467 the unsafe bit on field definition, only on usage. Remove the test.
23469 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23471 * driver.cs: use assembly.Location instead of Codebase (the latest
23472 patch made mcs fail when using MS assemblies).
23474 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23476 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23477 get the path to *corlib.dll.
23479 2003-01-21 Nick Drochak <ndrochak@gol.com>
23483 * typemanager.cs: Remove compiler warnings
23485 2003-01-20 Duncan Mak <duncan@ximian.com>
23487 * AssemblyInfo.cs: Bump the version number to 0.19.
23489 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23491 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23493 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23495 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23497 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23499 * cs-parser.jay: Small fix: we were not comparing the constructor
23500 name correctly. Thanks to Zoltan for the initial pointer.
23502 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23504 * cs-tokenizer.cs: Set file name when specified with #line
23506 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23508 * cs-parser.jay: Only perform the constructor checks here if we
23509 are named like the class; This will help provider a better
23510 error. The constructor path is taken when a type definition is
23511 not found, but most likely the user forgot to add the type, so
23512 report that rather than the constructor error.
23514 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23516 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23519 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23521 * cs-parser.jay: Add cleanup call.
23523 2003-01-13 Duncan Mak <duncan@ximian.com>
23525 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23526 consistent with other methods.
23528 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23530 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23532 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23534 * attribute.cs: only set GuidAttr to true when we have a
23537 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23541 * typemanager.cs: fixes to allow mcs compile corlib with the new
23542 Type.IsSubclassOf fix.
23544 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23546 * expression.cs (LocalVariableReference.DoResolve): Classify a
23547 constant as a value, not as a variable. Also, set the type for
23550 * cs-parser.jay (fixed_statement): take a type instead of a
23551 pointer_type, so we can produce a better error message later.
23553 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23556 (For.DoEmit): Make inifinite loops have a
23557 non-conditional branch back.
23559 (Fixed.DoEmit): First populate the pinned variables, then emit the
23560 statement, then clear the variables. Before I was emitting the
23561 code once for each fixed piece.
23564 2003-01-08 Martin Baulig <martin@ximian.com>
23566 * statement.cs (FlowBranching.MergeChild): A break in a
23567 SWITCH_SECTION does not leave a loop. Fixes #36155.
23569 2003-01-08 Martin Baulig <martin@ximian.com>
23571 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23572 lives in the same number space than `param_map'. Fixes #36154.
23574 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23576 * cs-parser.jay (constructor_declaration): Set the
23577 Constructor.ModFlags before probing for it. This makes the
23578 compiler report 514, 515 and 132 (the code was there, but got
23581 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23582 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23583 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23585 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23587 * enum.cs: create the enum static fields using the enum type.
23589 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23591 * class.cs: don't try to create the ParamBuilder for the return
23592 type if it's not needed (and handle it breaking for the ms runtime
23595 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23597 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23599 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23601 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23602 the command. This showed up while compiling the JANET source
23603 code, which used \r as its only newline separator.
23605 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23607 * class.cs (Method.Define): If we are an operator (because it
23608 reuses our code), then set the SpecialName and HideBySig. #36128
23610 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23612 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23613 exception, report error 120 `object reference required'.
23615 * driver.cs: Add --pause option, used during to measure the size
23616 of the process as it goes with --timestamp.
23618 * expression.cs (Invocation.DoResolve): Do not allow methods with
23619 SpecialName to be invoked.
23621 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23623 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23624 number before adding it.
23626 2002-12-21 Ravi Pratap <ravi@ximian.com>
23628 * ecore.cs (StandardImplicitConversion): When in an unsafe
23629 context, we allow conversion between void * to any other pointer
23630 type. This fixes bug #35973.
23632 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23634 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23635 is not thrown when extensionless outputs are used
23637 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23639 * rootcontext.cs: fixed compilation of corlib.
23641 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23643 * attribute.cs (Attributes.Contains): Add new method.
23645 * class.cs (MethodCore.LabelParameters): if the parameter is an
23646 `out' parameter, check that no attribute `[In]' has been passed.
23648 * enum.cs: Handle the `value__' name in an enumeration.
23650 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23652 * decl.cs: Added special case to allow overrides on "protected
23655 2002-12-18 Ravi Pratap <ravi@ximian.com>
23657 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23658 since it makes much more sense.
23660 (Attributes.ctor): Don't require a Location parameter.
23662 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23664 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23665 since we already have that information per attribute.
23667 * everywhere : make appropriate changes.
23669 * class.cs (LabelParameters): Write the code which actually
23670 applies attributes to the return type. We can't do this on the MS
23671 .NET runtime so we flag a warning in the case an exception is
23674 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23676 * const.cs: Handle implicit null conversions here too.
23678 2002-12-17 Ravi Pratap <ravi@ximian.com>
23680 * class.cs (MethodCore.LabelParameters): Remove the extra
23681 Type [] parameter since it is completely unnecessary. Instead
23682 pass in the method's attributes so that we can extract
23683 the "return" attribute.
23685 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23687 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23688 of ignoring it and letting the compile continue.
23690 * typemanager.cs (ChangeType): use an extra argument to return an
23691 error condition instead of throwing an exception.
23693 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23695 * expression.cs (Unary.TryReduce): mimic the code for the regular
23696 code path. Perform an implicit cast in the cases where we can
23697 implicitly convert to one of the integral types, and then reduce
23698 based on that constant. This fixes bug #35483.
23700 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23702 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23704 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23706 * namespace.cs: fixed bug #35489.
23708 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23710 * class.cs: Remove some dead code.
23712 * cs-parser.jay: Estimate the number of methods needed
23713 (RootContext.MethodCount);
23715 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23716 numbers instead of StringBuilders.
23718 * support.cs (PtrHashtable): Add constructor with initial size;
23719 We can now reduce reallocations of the method table.
23721 2002-12-10 Ravi Pratap <ravi@ximian.com>
23723 * attribute.cs (ApplyAttributes): Keep track of the emitted
23724 attributes on a per-target basis. This fixes bug #35413.
23726 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23728 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23729 default to the Windows 1252 encoding.
23731 (UnixParseOption): Support version, thanks to Alp for the missing
23734 * AssemblyInfo.cs: Add nice assembly information.
23736 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23739 * cs-parser.jay: Allow a trailing comma before the close bracked
23740 in the attribute_section production.
23742 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23743 address of the instance was being taken, I will take this out,
23744 because we take the address of the object immediately here.
23746 2002-12-09 Ravi Pratap <ravi@ximian.com>
23748 * typemanager.cs (AreMultipleAllowed): Take care of the most
23749 obvious case where attribute type is not in the current assembly -
23752 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23754 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23755 definitions, instead of doing that afterwards.
23757 Also we use a nice little hack, depending on the constructor, we
23758 know if we are a "composed" name or a simple name. Hence, we
23759 avoid the IndexOf test, and we avoid
23761 * codegen.cs: Add code to assist in a bug reporter to track down
23762 the source of a compiler crash.
23764 2002-12-07 Ravi Pratap <ravi@ximian.com>
23766 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23767 types have been emitted for a given element and flag an error
23768 if something which does not have AllowMultiple set is used more
23771 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23772 attribute types and their corresponding AllowMultiple properties
23774 (AreMultipleAllowed): Check the property for a given type.
23776 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23777 property in the case we have a TypeContainer.
23779 (Attributes.AddAttribute): Detect duplicates and just skip on
23780 adding them. This trivial fix catches a pretty gross error in our
23781 attribute emission - global attributes were being emitted twice!
23783 Bugzilla bug #33187 is now fixed.
23785 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23787 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23788 instead of pp_and).
23790 * expression.cs (Binary.ResolveOperator): I can only use the
23791 Concat (string, string, string) and Concat (string, string,
23792 string, string) if the child is actually a concatenation of
23795 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23797 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23798 context where we need a 2-character lookahead.
23800 * pending.cs (PendingImplementation): Rework so we can keep track
23801 of interface types all the time, and flag those which were
23802 implemented by parents as optional.
23804 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23806 * expression.cs (Binary.ResolveOperator): Use
23807 String.Concat(string,string,string) or
23808 String.Concat(string,string,string,string) when possible.
23810 * typemanager: More helper methods.
23813 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23815 * pending.cs: remove the bogus return from GetMissingInterfaces()
23816 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23818 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23820 * namespace.cs: avoid duplicated 'using xxx' being added to
23821 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23822 when we get more than one 'using' statement for the same namespace.
23823 Report a CS0105 warning for it.
23825 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23827 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23828 of calling getChar/putback, uses internal knowledge of it.
23830 (xtoken): Reorder tokenizer so most common patterns are checked
23831 first. This reduces the compilation time in another 5% (from 8.11s
23832 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23834 The parsing time is 22% of the compilation in mcs, and from that
23835 64% is spent on the tokenization process.
23837 I tried using a binary search for keywords, but this is slower
23838 than the hashtable. Another option would be to do a couple of
23841 * Not use a StringBuilder, instead use an array of chars,
23842 with a set value. Notice that this way we could catch
23843 the 645 error without having to do it *afterwards*.
23845 * We could write a hand-parser to avoid the hashtable
23846 compares altogether.
23848 The identifier consumption process takes 37% of the tokenization
23849 time. Another 15% is spent on is_number. 56% of the time spent
23850 on is_number is spent on Int64.Parse:
23852 * We could probably choose based on the string length to
23853 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23856 Another 3% is spend on wrapping `xtoken' in the `token' function.
23858 Handle 0xa0 as whitespace (#34752)
23860 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23862 * typemanager.cs (IsCLRType): New routine to tell whether a type
23863 is one of the builtin types.
23865 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23866 typecode in more places instead of doing pointer comparissions.
23867 We could leverage some knowledge about the way the typecodes are
23870 New code to cache namespaces in assemblies, it is currently not
23871 invoked, to be used soon.
23873 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23875 * expression.cs (Binary.ResolveOperator): specially handle
23876 strings, and do not perform user-defined operator overloading for
23879 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23881 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23882 internalcall as it is a pretty simple operation; Avoid whenever
23883 possible to call Char.IsLetter.
23885 (consume_identifier): Cut by half the number of
23886 hashtable calls by merging the is_keyword and GetKeyword behavior.
23888 Do not short-circuit, because if we do, we
23889 report errors (ie, #if false && true would produce an invalid
23893 2002-11-24 Martin Baulig <martin@ximian.com>
23895 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23896 check constant ranges and report a CS0221. Fixes #33186.
23898 2002-11-24 Martin Baulig <martin@ximian.com>
23900 * cs-parser.jay: Make this work for uninitialized variable
23901 declarations in the `for' initializer. Fixes #32416.
23903 2002-11-24 Martin Baulig <martin@ximian.com>
23905 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23906 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23908 2002-11-24 Martin Baulig <martin@ximian.com>
23910 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23911 argument; if true, we also check for user-defined conversions.
23912 This is only needed if both arguments are of a user-defined type.
23913 Fixes #30443, added test-175.cs.
23914 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23916 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23918 2002-11-24 Martin Baulig <martin@ximian.com>
23920 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23921 function to get the store opcode.
23922 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23923 only emit the Ldelema if the store opcode is Stobj. You must run
23924 both test-34 and test-167 to test this. Fixes #34529.
23926 2002-11-23 Martin Baulig <martin@ximian.com>
23928 * ecore.cs (Expression.MemberLookup): Added additional
23929 `qualifier_type' argument which is used when we're being called
23930 from MemberAccess.DoResolve() and null if we're called from a
23932 (Expression.MemberLookupFailed): New method to report errors; this
23933 does the CS1540 check and reports the correct error message.
23935 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23936 argument for the CS1540 check and redone the way how we're dealing
23937 with private members. See the comment in the source code for details.
23938 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23939 `closure_start_type' to `closure_qualifier_type' and check whether
23940 it's not null. It was not this filter being broken, it was just
23941 being called with the wrong arguments.
23943 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23944 and pass it the correct `qualifier_type'; this also does the error
23947 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23949 * expression.cs (Invocation.EmitParams): If the we are dealing
23950 with a non-built-in value type, load its address as well.
23952 (ArrayCreation): Use a a pretty constant instead
23953 of the hardcoded value 2. Use 6 instead of 2 for the number of
23954 static initializers.
23956 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23957 because they are not really value types, just glorified integers.
23959 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23961 * ecore.cs: Remove redundant code for enumerations, make them use
23962 the same code path as everything else, fixes the casting issue
23963 with enumerations in Windows.Forms.
23965 * attribute.cs: Do only cast to string if it is a string, the
23966 validation happens later.
23968 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23969 people upgrade their corlibs.
23971 * ecore.cs: Oops, enumerations were not following the entire code path
23973 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23975 * typemanager.cs (FilterWithClosure): Commented out the test for
23976 1540 in typemanager.cs, as it has problems when accessing
23977 protected methods from a parent class (see test-174.cs).
23979 * attribute.cs (Attribute.ValidateGuid): new method.
23980 (Attribute.Resolve): Use above.
23982 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23984 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23986 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23987 handling for enumerations, as we only needed the TypeContainer
23988 functionality to begin with (this is required for the fix below to
23989 work for enums that reference constants in a container class for
23992 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23994 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23995 a valid TypeBuilder to perform lookups on.o
23997 * class.cs (InheritableMemberSignatureCompare): Use true in the
23998 call to GetGetMethod and GetSetMethod, because we are comparing
23999 the signature, and we need to get the methods *even* if they are
24002 (PropertyBase.CheckBase): ditto.
24004 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
24005 GotoCase.Resolve): Use Peel on EmpytCasts.
24007 * ecore.cs (EmptyCast): drop child, add Peel method.
24009 2002-11-17 Martin Baulig <martin@ximian.com>
24011 * ecore.cs (EmptyCast.Child): New public property.
24013 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
24014 label resolved to an EmptyCast. Fixes #34162.
24015 (GotoCase.Resolve): Likewise.
24016 (Block.EmitMeta): Likewise.
24018 2002-11-17 Martin Baulig <martin@ximian.com>
24020 * expression.cs (Invocation.BetterConversion): Prefer int over
24021 uint; short over ushort; long over ulong for integer literals.
24022 Use ImplicitConversionExists instead of StandardConversionExists
24023 since we also need to check for user-defined implicit conversions.
24024 Fixes #34165. Added test-173.cs.
24026 2002-11-16 Martin Baulig <martin@ximian.com>
24028 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
24029 with the `true' and `false' literals. Fixes #33151.
24031 2002-11-16 Martin Baulig <martin@ximian.com>
24033 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
24034 October 22nd; don't do the cs1540 check for static members.
24036 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
24037 now using our own filter here and doing the cs1540 check again.
24039 2002-11-16 Martin Baulig <martin@ximian.com>
24041 * support.cs (InternalParameters): Don't crash if we don't have
24042 any fixed parameters. Fixes #33532.
24044 2002-11-16 Martin Baulig <martin@ximian.com>
24046 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
24047 when looking up static methods to make this work on Windows.
24050 2002-11-16 Martin Baulig <martin@ximian.com>
24052 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
24053 a setter rather than using PropertyInfo.CanWrite.
24055 2002-11-15 Nick Drochak <ndrochak@gol.com>
24057 * class.cs: Allow acces to block member by subclasses. Fixes build
24060 2002-11-14 Martin Baulig <martin@ximian.com>
24062 * class.cs (Constructor.Emit): Added the extern/block check.
24065 2002-11-14 Martin Baulig <martin@ximian.com>
24067 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
24068 iteration while looking for indexers, this is needed because the
24069 indexer may have a different name in our base classes. Fixed the
24070 error reporting (no indexers at all, not get accessor, no
24071 overloaded match). Fixes bug #33089.
24072 (IndexerAccess.DoResolveLValue): Likewise.
24074 2002-11-14 Martin Baulig <martin@ximian.com>
24076 * class.cs (PropertyBase.CheckBase): Make this work for multiple
24077 indexers. Fixes the first part of bug #33089.
24078 (MethodSignature.InheritableMemberSignatureCompare): Added support
24081 2002-11-13 Ravi Pratap <ravi@ximian.com>
24083 * attribute.cs (Attribute.Resolve): Catch the
24084 NullReferenceException and report it since it isn't supposed to
24087 2002-11-12 Miguel de Icaza <miguel@ximian.com>
24089 * expression.cs (Binary.EmitBranchable): Also handle the cases for
24090 LogicalOr and LogicalAnd that can benefit from recursively
24091 handling EmitBranchable. The code now should be nice for Paolo.
24093 2002-11-08 Miguel de Icaza <miguel@ximian.com>
24095 * typemanager.cs (LookupType): Added a negative-hit hashtable for
24096 the Type lookups, as we perform quite a number of lookups on
24097 non-Types. This can be removed once we can deterministically tell
24098 whether we have a type or a namespace in advance.
24100 But this might require special hacks from our corlib.
24104 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
24105 and double which avoids a conversion from an integer to a double.
24107 * expression.cs: tiny optimization, avoid calling IsConstant,
24108 because it effectively performs the lookup twice.
24110 2002-11-06 Miguel de Icaza <miguel@ximian.com>
24112 But a bogus return here to keep the semantics of the old code
24113 until the Mono runtime is fixed.
24115 * pending.cs (GetMissingInterfaces): New method used to remove all
24116 the interfaces that are already implemented by our parent
24117 classes from the list of pending methods.
24119 * interface.cs: Add checks for calls after ResolveTypeExpr.
24121 2002-11-05 Miguel de Icaza <miguel@ximian.com>
24123 * class.cs (Class.Emit): Report warning 67: event not used if the
24124 warning level is beyond 3.
24126 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
24127 being a NullLiteral.
24129 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
24132 * class.cs (TypeContainer.GetClassBases): Cover a missing code
24133 path that might fail if a type can not be resolved.
24135 * expression.cs (Binary.Emit): Emit unsigned versions of the
24138 * driver.cs: use error 5.
24140 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
24142 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
24144 2002-11-01 Miguel de Icaza <miguel@ximian.com>
24146 * cs-parser.jay (switch_section): A beautiful patch from Martin
24147 Baulig that fixed 33094.
24149 2002-10-31 Miguel de Icaza <miguel@ximian.com>
24151 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
24152 Check whether the base is abstract and report an error if so.
24154 * expression.cs (IndexerAccess.DoResolveLValue,
24155 IndexerAccess.DoResolve): ditto.
24157 (Invocation.DoResolve): ditto.
24159 (Invocation.FullMethodDesc): Improve the report string.
24161 * statement.cs (Block): Eliminate IsVariableDefined as it is
24162 basically just a wrapper for GetVariableInfo.
24164 * ecore.cs (SimpleName): Use new
24166 * support.cs (ReflectionParamter.ParameterType): We unwrap the
24167 type, as we return the actual parameter ref/unref state on a
24170 2002-10-30 Miguel de Icaza <miguel@ximian.com>
24172 * support.cs: Return proper flags REF/OUT fixing the previous
24175 * expression.cs: Reverted last patch, that was wrong. Is_ref is
24176 not used to mean `ref' but `ref or out' in ParameterReference
24178 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
24179 full type signature instead of calling TypeManger.CSharpName
24182 * support.cs (InternalParameters.ParameterDesc): Do not compare
24183 directly to the modflags, because REF/OUT will actually be bitsets
24186 * delegate.cs (VerifyMethod): Check also the modifiers.
24188 * cs-tokenizer.cs: Fix bug where floating point values with an
24189 exponent where a sign was missing was ignored.
24191 * driver.cs: Allow multiple assemblies to be specified in a single
24194 2002-10-28 Miguel de Icaza <miguel@ximian.com>
24196 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
24197 because identifiers after a parenthesis would end up in this kind
24198 of production, and we needed to desamiguate it for having casts
24201 (UserDefinedType *) xxx
24203 2002-10-24 Miguel de Icaza <miguel@ximian.com>
24205 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
24206 we should set on the Bindingflags.NonPublic, but not turn on
24207 private_ok. private_ok controls whether a Private member is
24208 returned (this is chekced on the filter routine), while the
24209 BindingFlags.NonPublic just controls whether private/protected
24210 will be allowed. This fixes the problem part of the problem of
24211 private properties being allowed to be used in derived classes.
24213 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
24214 so we can call the children DoResolveLValue method (this will
24215 properly signal errors on lvalue assignments to base properties)
24217 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
24218 getter are null, and we have a property info, we know that this
24219 happened because the lookup failed, so we report an error 122 for
24220 protection level violation.
24222 We also silently return if setter and getter are null in the
24223 resolve functions, this condition only happens if we have flagged
24224 the error before. This is the other half of the problem.
24226 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
24227 not have accessibility information, that is why we were returning
24228 true in the filter function in typemanager.cs.
24230 To properly report 122 (property is inaccessible because of its
24231 protection level) correctly, we report this error in ResolveAccess
24232 by failing if both the setter and the getter are lacking (ie, the
24235 DoResolve and DoLResolve have been modified to check for both
24236 setter/getter being null and returning silently, the reason being
24237 that I did not want to put the knowledge about this error in upper
24240 int old = Report.Errors;
24241 x = new PropertyExpr (...);
24242 if (old != Report.Errors)
24247 So the property expr is returned, but it is invalid, so the error
24248 will be flagged during the resolve process.
24250 * class.cs: Remove InheritablePropertySignatureCompare from the
24251 class, as we no longer depend on the property signature to compute
24252 whether it is possible to implement a method or not.
24254 The reason is that calling PropertyInfo.GetGetMethod will return
24255 null (in .NET, in Mono it works, and we should change this), in
24256 cases where the Get Method does not exist in that particular
24261 class X { public virtual int A { get { return 1; } } }
24263 class Z : Y { public override int A { get { return 2; } } }
24265 Would fail in Z because the parent (Y) would not have the property
24266 defined. So we avoid this completely now (because the alternative
24267 fix was ugly and slow), and we now depend exclusively on the
24270 (PropertyBase.CheckBase): Use a method-base mechanism to find our
24271 reference method, instead of using the property.
24273 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
24274 routines are gone now.
24276 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
24277 names, they were incorrectly named.
24279 * cs-tokenizer.cs: Return are more gentle token on failure.
24281 * pending.cs (PendingImplementation.InterfaceMethod): This routine
24282 had an out-of-sync index variable, which caused it to remove from
24283 the list of pending methods the wrong method sometimes.
24285 2002-10-22 Miguel de Icaza <miguel@ximian.com>
24287 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
24288 CanWrite, because those refer to this particular instance of the
24289 property, and do not take into account the fact that we can
24290 override single members of a property.
24292 Constructor requires an EmitContext. The resolution process does
24293 not happen here, but we need to compute the accessors before,
24294 because the resolution does not always happen for properties.
24296 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
24297 subclass, before we did not update this flag, but we did update
24300 (GetAccessors): Drop this routine, as it did not work in the
24301 presence of partially overwritten set/get methods.
24303 Notice that this broke the cs1540 detection, but that will require
24306 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24310 * driver.cs: issue a warning instead of an error if we don't support
24311 debugging for the platform. Also ignore a couple of errors that may
24312 arise when trying to write the symbols. Undo my previous patch.
24314 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24316 * driver.cs: ignore /debug switch except for Unix platforms.
24318 2002-10-23 Nick Drochak <ndrochak@gol.com>
24320 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24322 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24324 * driver.cs: Do not make mcs-debug conditional, so we do not break
24325 builds that use it.
24327 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24328 review this patch. But basically after all the children variables
24329 have been merged, the value of "Breaks" was not being set to
24330 new_breaks for Switch blocks. I think that it should be set after
24331 it has executed. Currently I set this to the value of new_breaks,
24332 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24333 conservative, but I do not understand this code very well.
24335 I did not break anything in the build, so that is good ;-)
24337 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24339 2002-10-20 Mark Crichton <crichton@gimp.org>
24341 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24343 2002-10-20 Nick Drochak <ndrochak@gol.com>
24345 * cfold.cs: Fixed compile blocker.
24347 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24349 * driver.cs: I was chekcing the key, not the file.
24351 2002-10-19 Ravi Pratap <ravi@ximian.com>
24353 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24354 message that we were generating - we just need to silently return
24357 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24359 * class.cs (Event.Define): Change my previous commit, as this
24360 breaks the debugger. This is a temporary hack, as it seems like
24361 the compiler is generating events incorrectly to begin with.
24363 * expression.cs (Binary.ResolveOperator): Added support for
24364 "U operator - (E x, E y)"
24366 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24369 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24370 init-only variables, but this path did not take into account that
24371 there might be also instance readonly variables. Correct this
24374 This fixes bug 32253
24376 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24379 * driver.cs: Change the extension for modules to `netmodule'
24381 * cs-parser.jay: Improved slightly the location tracking for
24382 the debugger symbols.
24384 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24385 modifiers that were specified instead of the hardcoded value
24386 (FamAndAssem). This was basically ignoring the static modifier,
24387 and others. Fixes 32429.
24389 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24390 fixed a bug in the process (32476)
24392 * expression.cs (ArrayAccess.EmitAssign): Patch from
24393 hwang_rob@yahoo.ca that fixes bug 31834.3
24395 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24397 * driver.cs: Make the module extension .netmodule.
24399 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24401 * driver.cs: Report an error if the resource file is not found
24402 instead of crashing.
24404 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24405 false, like Emit does.
24407 2002-10-16 Nick Drochak <ndrochak@gol.com>
24409 * typemanager.cs: Remove unused private member. Also reported mcs
24410 bug to report this as a warning like csc.
24412 2002-10-15 Martin Baulig <martin@gnome.org>
24414 * statement.cs (Statement.Emit): Made this a virtual method; emits
24415 the line number info and calls DoEmit().
24416 (Statement.DoEmit): New protected abstract method, formerly knows
24417 as Statement.Emit().
24419 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24421 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24423 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24424 have fixed a remaining problem: not every AddXXXX was adding a
24425 fully qualified name.
24427 Now everyone registers a fully qualified name in the DeclSpace as
24428 being defined instead of the partial name.
24430 Downsides: we are slower than we need to be due to the excess
24431 copies and the names being registered this way.
24433 The reason for this is that we currently depend (on the corlib
24434 bootstrap for instance) that types are fully qualified, because
24435 we dump all the types in the namespace, and we should really have
24436 types inserted into the proper namespace, so we can only store the
24437 basenames in the defined_names array.
24439 2002-10-10 Martin Baulig <martin@gnome.org>
24441 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24442 from bug #31834, see the bug report for a testcase which is
24445 2002-10-10 Martin Baulig <martin@gnome.org>
24447 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24448 flow analysis code for this.
24450 * statement.cs (Do, While, For): Tell the flow analysis code about
24452 (FlowBranching.UsageVector): Added support for infinite loops.
24453 (Block.Resolve): Moved the dead code elimination here and use flow
24456 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24458 * class.cs (Field.Define): Catch cycles on struct type
24461 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24462 fields if the fields are static. We only need to check instance
24465 * expression.cs (As.DoResolve): Test for reference type.
24467 * statement.cs (Using.ResolveExpression): Use
24468 ConvertImplicitRequired, not ConvertImplicit which reports an
24470 (Using.ResolveLocalVariableDecls): ditto.
24472 * expression.cs (Binary.ResolveOperator): Report errors in a few
24473 places where we had to.
24475 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24477 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24479 * expression.cs: Use StoreFromPtr instead of extracting the type
24480 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24482 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24483 an enumeration value to a System.Enum, but System.Enum is not a
24484 value type, but an class type, so we need to box.
24486 (Expression.ConvertExplicit): One codepath could return
24487 errors but not flag them. Fix this. Fixes #31853
24489 * parameter.cs (Resolve): Do not allow void as a parameter type.
24491 2002-10-06 Martin Baulig <martin@gnome.org>
24493 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24494 if it's a class type and not a struct. Fixes #31815.
24496 2002-10-06 Martin Baulig <martin@gnome.org>
24498 * statement.cs: Reworked the flow analysis code a bit to make it
24499 usable for dead code elimination.
24501 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24503 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24505 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24507 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24508 to fix the test 165, will investigate deeper.
24510 2002-10-04 Martin Baulig <martin@gnome.org>
24512 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24513 finally blocks actually work.
24514 (Try.Resolve): We don't need to create a sibling for `finally' if
24515 there is no finally block.
24517 2002-10-04 Martin Baulig <martin@gnome.org>
24519 * class.cs (Constructor.Define): The default accessibility for a
24520 non-default constructor is private, not public.
24522 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24524 * class.cs (Constructor): Make AllowedModifiers public, add
24527 * cs-parser.jay: Perform the modifiers test here, as the
24528 constructor for the Constructor class usually receives a zero
24529 because of the way we create it (first we create, later we
24530 customize, and we were never checking the modifiers).
24532 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24533 is a version of LookupTypeReflection that includes the type-name
24534 cache. This can be used as a fast path for functions that know
24535 the fully qualified name and are only calling into *.GetType() to
24536 obtain a composed type.
24538 This is also used by TypeManager.LookupType during its type
24541 (LookupType): We now also track the real type name, as sometimes
24542 we can get a quey for the real type name from things like
24543 ComposedCast. This fixes bug 31422.
24545 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24546 complete type fullname, it does not have to go through the type
24547 resolution system to obtain the composed version of the type (for
24548 obtaining arrays or pointers).
24550 (Conditional.Emit): Use the EmitBoolExpression to
24551 generate nicer code, as requested by Paolo.
24553 (ArrayCreation.CheckIndices): Use the patch from
24554 hwang_rob@yahoo.ca to validate the array initializers.
24556 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24558 * class.cs (ConstructorInitializer.Emit): simplify code by using
24559 Invocation.EmitCall, and at the same time, fix the bugs in calling
24560 parent constructors that took variable arguments.
24562 * ecore.cs (Expression.ConvertNumericExplicit,
24563 Expression.ImplicitNumericConversion): Remove the code that
24564 manually wrapped decimal (InternalTypeConstructor call is now gone
24567 * expression.cs (Cast.TryReduce): Also handle decimal types when
24568 trying to perform a constant fold on the type.
24570 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24572 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24573 that only turned off an error report, and did nothing else.
24575 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24577 * driver.cs: Handle and ignore /fullpaths
24579 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24581 * expression.cs (Binary.ResolveOperator): Catch the case where
24582 DoNumericPromotions returns true,
24584 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24586 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24588 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24591 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24593 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24594 conversion exists, but it is also required that the conversion be
24595 performed. This manifested in "(Type64Enum) 2".
24597 * class.cs (TypeManager.AddMethod): The fix is not to change
24598 AddEnum, because that one was using a fully qualified name (every
24599 DeclSpace derivative does), but to change the AddMethod routine
24600 that was using an un-namespaced name. This now correctly reports
24601 the duplicated name.
24603 Revert patch until I can properly fix it. The issue
24604 is that we have a shared Type space across all namespaces
24605 currently, which is wrong.
24607 Options include making the Namespace a DeclSpace, and merge
24608 current_namespace/current_container in the parser.
24610 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24612 * cs-parser.jay: Improve error reporting when we get a different
24613 kind of expression in local_variable_type and
24614 local_variable_pointer_type.
24616 Propagate this to avoid missleading errors being reported.
24618 * ecore.cs (ImplicitReferenceConversion): treat
24619 TypeManager.value_type as a target just like object_type. As
24624 Is valid, and needs to result in the int 1 being boxed before it
24625 is assigned to the value type v.
24627 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24628 to validate the enumeration name.
24630 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24631 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24632 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24634 * ecore.cs (TryImplicitIntConversion): When doing an
24635 implicit-enumeration-conversion, check if the type is 64-bits and
24636 perform a conversion before passing to EnumConstant.
24638 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24640 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24641 report ambiguous type references. Unlike the MS version, we
24642 report what the ambiguity is. Innovation at work ;-)
24644 (DeclSpace.FindType): Require a location argument to
24645 display when we display an ambiguous error.
24647 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24649 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24651 * expression.cs (EmitDynamicInitializers): Apply patch from
24652 hwang_rob@yahoo.ca that fixes the order in which we emit our
24655 2002-09-21 Martin Baulig <martin@gnome.org>
24657 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24658 delegate takes no arguments.
24660 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24662 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24665 * expression.cs: Extract the underlying type.
24667 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24669 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24671 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24673 * class.cs (TypeContainer.DefineType): We can not use the nice
24674 PackingSize with the size set to 1 DefineType method, because it
24675 will not allow us to define the interfaces that the struct
24678 This completes the fixing of bug 27287
24680 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24681 means also structs. This fixes part of the problem.
24682 (Expresion.ImplicitReferenceConversionExists): ditto.
24684 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24685 error if there were no errors reported during the type lookup
24686 process, to avoid duplicates or redundant errors. Without this
24687 you would get an ambiguous errors plus a type not found. We have
24688 beaten the user enough with the first error.
24690 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24693 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24694 during the resolution process, stop the lookup, this avoids
24695 repeated error reports (same error twice).
24697 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24699 * typemanager.cs (LookupType): Redo the type lookup code to match
24700 the needs of System.Reflection.
24702 The issue is that System.Reflection requires references to nested
24703 types to begin with a "+" sign instead of a dot. So toplevel
24704 types look like: "NameSpace.TopLevelClass", and nested ones look
24705 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24708 2002-09-19 Martin Baulig <martin@gnome.org>
24710 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24711 says that a method always returns or always throws an exception,
24712 don't report the CS0161.
24714 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24715 set `Returns = new_returns'.
24717 2002-09-19 Martin Baulig <martin@gnome.org>
24719 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24720 to an enum constant, check for a CS0176.
24722 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24724 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24725 for operators that must be in pairs and report errors.
24727 * ecore.cs (SimpleName.DoResolveType): During the initial type
24728 resolution process, when we define types recursively, we must
24729 check first for types in our current scope before we perform
24730 lookups in the enclosing scopes.
24732 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24734 (Invocation.VerifyArgumentsCompat): Call
24735 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24736 I thought we were supposed to always call this, but there are a
24737 few places in the code where we dont do it.
24739 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24741 * driver.cs: Add support in -linkres and -resource to specify the
24742 name of the identifier.
24744 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24746 * ecore.cs (StandardConversionExists): Sync with the conversion
24747 code: allow anything-* to void* conversions.
24749 (FindMostSpecificSource): Use an Expression argument
24750 instead of a Type, because we might be handed over a Literal which
24751 gets a few more implicit conversions that plain types do not. So
24752 this information was being lost.
24754 Also, we drop the temporary type-holder expression when not
24757 2002-09-17 Martin Baulig <martin@gnome.org>
24759 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24760 this is an explicit interface implementation.
24762 2002-09-17 Martin Baulig <martin@gnome.org>
24764 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24765 different `IndexerName' attributes.
24767 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24768 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24769 virtual CommonResolve().
24771 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24773 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24774 and convert that to the UnderlyingType.
24776 * statement.cs (Foreach.Resolve): Indexers are just like variables
24777 or PropertyAccesses.
24779 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24780 inside quoted strings, we were not doing this before.
24782 2002-09-16 Martin Baulig <martin@gnome.org>
24784 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24785 resolve it. This is needed for the definite assignment check of the
24786 instance expression, fixes bug #29846.
24787 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24789 2002-09-16 Nick Drochak <ndrochak@gol.com>
24791 * parameter.cs: Fix compile error. Cannot reference static member
24792 from an instance object. Is this an mcs bug?
24794 2002-09-14 Martin Baulig <martin@gnome.org>
24796 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24797 multiple times. Fixes bug #30295, added test-166.cs.
24799 2002-09-14 Martin Baulig <martin@gnome.org>
24801 * statement.cs (Block.Emit): Don't emit unreachable code.
24802 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24803 `break' statements.
24804 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24806 2002-09-14 Martin Baulig <martin@gnome.org>
24808 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24811 2002-09-14 Martin Baulig <martin@gnome.org>
24813 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24814 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24815 be false on the ms runtime.
24817 2002-09-13 Martin Baulig <martin@gnome.org>
24819 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24820 the CS0038 error message.
24822 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24824 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24825 constant inside, return it.
24827 2002-09-12 Martin Baulig <martin@gnome.org>
24829 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24830 implicit conversion can be done between enum types.
24832 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24833 check whether an implicit conversion to the current enum's UnderlyingType
24834 exists and report an error if not.
24836 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24837 without debugging support.
24839 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24840 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24842 2002-09-12 Martin Baulig <martin@gnome.org>
24844 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24846 * ecore.cs (IMemberExpr.DeclaringType): New property.
24847 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24848 nonstatic member of an outer type (CS0038).
24850 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24852 * driver.cs: Activate the using-error detector at warning level
24853 4 (at least for MS-compatible APIs).
24855 * namespace.cs (VerifyUsing): Small buglett fix.
24857 * pending.cs (PendingImplementation): pass the container pointer.
24859 * interface.cs (GetMethods): Allow for recursive definition. Long
24860 term, I would like to move every type to support recursive
24861 definitions, not the current ordering mechanism that we have right
24864 The situation is this: Attributes are handled before interfaces,
24865 so we can apply attributes to interfaces. But some attributes
24866 implement interfaces, we will now handle the simple cases
24867 (recursive definitions will just get an error).
24869 * parameter.cs: Only invalidate types at the end if we fail to
24872 2002-09-09 Martin Baulig <martin@gnome.org>
24874 * ecore.cs (PropertyExpr.Emit): Also check for
24875 TypeManager.system_int_array_get_length so this'll also work when
24876 compiling corlib. Fixes #30003.
24878 2002-09-09 Martin Baulig <martin@gnome.org>
24880 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24881 and throw an exception if we can't get the type's size. Fixed #30040,
24884 2002-09-09 Martin Baulig <martin@gnome.org>
24886 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24888 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24889 context. Fixes bug #30027.
24891 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24892 virtual functions. Fixes bug #30043, added test-164.cs.
24894 2002-09-08 Ravi Pratap <ravi@ximian.com>
24896 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24898 2002-09-08 Nick Drochak <ndrochak@gol.com>
24900 * driver.cs: Use an object to get the windows codepage since it's not a
24903 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24905 * statement.cs (For.Emit): for infinite loops (test == null)
24906 return whether there is a break inside, not always "true".
24908 * namespace.cs (UsingEntry): New struct to hold the name of the
24909 using definition, the location where it is defined, and whether it
24910 has been used in a successful type lookup.
24912 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24917 2002-09-06 Ravi Pratap <ravi@ximian.com>
24919 * attribute.cs : Fix incorrect code which relied on catching
24920 a NullReferenceException to detect a null being passed in
24921 where an object was expected.
24923 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24925 * statement.cs (Try): flag the catch variable as assigned
24927 * expression.cs (Cast): Simplified by using ResolveType instead of
24928 manually resolving.
24930 * statement.cs (Catch): Fix bug by using ResolveType.
24932 2002-09-06 Ravi Pratap <ravi@ximian.com>
24934 * expression.cs (BetterConversion): Special case for when we have
24935 a NullLiteral as the argument and we have to choose between string
24936 and object types - we choose string the way csc does.
24938 * attribute.cs (Attribute.Resolve): Catch the
24939 NullReferenceException and report error #182 since the Mono
24940 runtime no more has the bug and having this exception raised means
24941 we tried to select a constructor which takes an object and is
24944 2002-09-05 Ravi Pratap <ravi@ximian.com>
24946 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24947 message (1502, 1503) when we can't locate a method after overload
24948 resolution. This is much more informative and closes the bug
24951 * interface.cs (PopulateMethod): Return if there are no argument
24952 types. Fixes a NullReferenceException bug.
24954 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24955 expressions too. Previously we were checking only in one place for
24956 positional arguments leaving out named arguments.
24958 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24959 type to the enum type is not allowed. Remove code corresponding to
24962 (ConvertNumericExplicit): Allow explicit conversions from
24963 the underlying type to enum type. This precisely follows the spec
24964 and closes a bug filed by Gonzalo.
24966 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24969 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24971 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24973 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24974 it was important that we stored the right value after the
24975 reduction in `converted'.
24977 2002-09-04 Martin Baulig <martin@gnome.org>
24979 * location.cs (Location.SymbolDocument): Use full pathnames for the
24982 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24984 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24985 of the expression resolve mechanism, because that will catch the
24986 SimpleName error failures.
24988 (Conditional): If we can not resolve the
24989 expression, return, do not crash.
24991 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24994 (location): display token name instead of its number.
24996 2002-08-28 Martin Baulig <martin@gnome.org>
24998 * expression.cs (Binary.ResolveOperator): Don't silently return
24999 but return an error if an operator cannot be applied between two
25002 2002-08-28 Martin Baulig <martin@gnome.org>
25004 * class.cs (Constructor.Define): Set the permission attributes
25005 correctly instead of making all constructors public.
25007 2002-08-28 Martin Baulig <martin@gnome.org>
25009 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
25010 for private members before reporting a CS0103; if we find anything,
25013 2002-08-28 Martin Baulig <martin@gnome.org>
25015 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
25016 to check whether `closure_start_type == closure_invocation_type',
25017 we also need to check whether `m.DeclaringType == closure_invocation_type'
25018 before bypassing the permission checks. We might be accessing
25019 protected/private members from the base class.
25020 (TypeManager.RealMemberLookup): Only set private_ok if private
25021 members were requested via BindingFlags.NonPublic.
25023 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
25025 * expression.cs (MemberAccess.ResolveMemberAccess): Set
25026 MethodGroupExpr.IsExplicitImpl if appropriate.
25027 (Invocation.DoResolve): Don't report the CS0120 for explicit
25028 interface implementations.
25030 2002-08-27 Martin Baulig <martin@gnome.org>
25032 * expression.cs (Invocation.DoResolve): If this is a static
25033 method and we don't have an InstanceExpression, we must report
25036 2002-08-25 Martin Baulig <martin@gnome.org>
25038 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
25039 `==' between a valuetype and an object.
25041 2002-08-25 Miguel de Icaza <miguel@ximian.com>
25043 * ecore.cs (TypeExpr): Provide a ToString method.
25045 2002-08-24 Martin Baulig <martin@gnome.org>
25047 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
25048 now called proggie.dbg and it's a binary file.
25050 2002-08-23 Martin Baulig <martin@gnome.org>
25052 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
25054 2002-08-23 Martin Baulig <martin@gnome.org>
25056 * struct.cs (MyStructInfo.ctor): Make this work with empty
25057 structs; it's not allowed to use foreach() on null.
25059 2002-08-23 Martin Baulig <martin@gnome.org>
25061 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
25062 writer the full pathname of the generated assembly.
25064 2002-08-23 Martin Baulig <martin@gnome.org>
25066 * statements.cs (FlowBranching.UsageVector.MergeChildren):
25067 A `finally' block never returns or breaks; improved handling of
25070 2002-08-23 Martin Baulig <martin@gnome.org>
25072 * statement.cs (Throw.Resolve): Allow `throw null'.
25074 2002-08-23 Martin Baulig <martin@gnome.org>
25076 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
25077 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
25078 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
25079 MemberLookup would return a wrong event if this is an explicit
25080 interface implementation and the class has an event with the same
25083 2002-08-23 Martin Baulig <martin@gnome.org>
25085 * statement.cs (Block.AddChildVariableNames): New public method.
25086 (Block.AddChildVariableName): Likewise.
25087 (Block.IsVariableNameUsedInChildBlock): Likewise.
25088 (Block.AddVariable): Check whether a variable name has already
25089 been used in a child block.
25091 * cs-parser.jay (declare_local_variables): Mark all variable names
25092 from the current block as being used in a child block in the
25095 2002-08-23 Martin Baulig <martin@gnome.org>
25097 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
25098 find the symbol writer.
25100 * driver.cs: csc also allows the arguments to /define being
25101 separated by commas, not only by semicolons.
25103 2002-08-23 Martin Baulig <martin@gnome.org>
25105 * interface.cs (Interface.GetMembers): Added static check for events.
25107 2002-08-15 Martin Baulig <martin@gnome.org>
25109 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
25110 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
25112 * ecore.cs (Expression.MemberLookup): Added documentation and explained
25113 why the MethodData.EmitDestructor() change was necessary.
25115 2002-08-20 Martin Baulig <martin@gnome.org>
25117 * class.cs (TypeContainer.FindMembers): Added static check for events.
25119 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
25121 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
25122 use Type.GetEvents(), not Type.FindMembers().
25124 2002-08-20 Martin Baulig <martin@gnome.org>
25126 * decl.cs (MemberCache): Added a special method cache which will
25127 be used for method-only searched. This ensures that a method
25128 search will return a MethodInfo with the correct ReflectedType for
25131 2002-08-20 Martin Baulig <martin@gnome.org>
25133 * decl.cs (DeclSpace.FindMembers): Made this public.
25135 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25137 * delegate.cs: fixed build on windows.
25138 [FIXME: Filed as bug #29150: MCS must report these errors.]
25140 2002-08-19 Ravi Pratap <ravi@ximian.com>
25142 * ecore.cs (StandardConversionExists): Return a false
25143 if we are trying to convert the void type to anything else
25144 since that is not allowed.
25146 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
25147 we flag error 70 in the event an event is trying to be accessed
25148 directly from outside the declaring type.
25150 2002-08-20 Martin Baulig <martin@gnome.org>
25152 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
25153 MemberCache from typemanager.cs to decl.cs.
25155 2002-08-19 Martin Baulig <martin@gnome.org>
25157 * class.cs (TypeContainer): Implement IMemberContainer.
25158 (TypeContainer.DefineMembers): Create the MemberCache.
25159 (TypeContainer.FindMembers): Do better BindingFlags checking; only
25160 return public members if BindingFlags.Public was given, check
25161 whether members are static.
25163 2002-08-16 Martin Baulig <martin@gnome.org>
25165 * decl.cs (DeclSpace.Define): Splitted this in Define and
25166 DefineMembers. DefineMembers is called first and initializes the
25169 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
25170 DefineMembers() on all our DeclSpaces.
25172 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
25173 but call DefineMembers() on all nested interfaces. We call their
25174 Define() in our new Define() function.
25176 * interface.cs (Interface): Implement IMemberContainer.
25177 (Interface.Define): Moved all code except the attribute stuf to
25179 (Interface.DefineMembers): Initialize the member cache.
25181 * typemanager.cs (IMemberFinder): Removed this interface, we don't
25182 need this anymore since we can use MemberCache.FindMembers directly.
25184 2002-08-19 Martin Baulig <martin@gnome.org>
25186 * typemanager.cs (MemberCache): When creating the cache for an
25187 interface type, add all inherited members.
25188 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
25189 to `out bool used_cache' and documented it.
25190 (TypeManager.MemberLookup): If we already used the cache in the first
25191 iteration, we don't need to do the interfaces check.
25193 2002-08-19 Martin Baulig <martin@gnome.org>
25195 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
25196 here from IMemberFinder and don't implement this interface anymore.
25197 (DeclSpace.MemberCache): Moved here from IMemberFinder.
25199 * typemanager.cs (IMemberFinder): This interface is now only used by
25200 classes which actually support the member cache.
25201 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
25202 since we only put DeclSpaces into this Hashtable.
25203 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
25204 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
25206 2002-08-16 Martin Baulig <martin@gnome.org>
25208 * typemanager.cs (ICachingMemberFinder): Removed.
25209 (IMemberFinder.MemberCache): New property.
25210 (TypeManager.FindMembers): Merged this with RealFindMembers().
25211 This function will never be called from TypeManager.MemberLookup()
25212 so we can't use the cache here, just the IMemberFinder.
25213 (TypeManager.MemberLookup_FindMembers): Check whether the
25214 IMemberFinder has a MemberCache and call the cache's FindMembers
25216 (MemberCache): Rewrote larger parts of this yet another time and
25217 cleaned it up a bit.
25219 2002-08-15 Miguel de Icaza <miguel@ximian.com>
25221 * driver.cs (LoadArgs): Support quoting.
25223 (Usage): Show the CSC-like command line arguments.
25225 Improved a few error messages.
25227 2002-08-15 Martin Baulig <martin@gnome.org>
25229 * typemanager.cs (IMemberContainer.Type): New property.
25230 (IMemberContainer.IsInterface): New property.
25232 The following changes are conditional to BROKEN_RUNTIME, which is
25233 defined at the top of the file.
25235 * typemanager.cs (MemberCache.MemberCache): Don't add the base
25236 class'es members, but add all members from TypeHandle.ObjectType
25237 if we're an interface.
25238 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
25239 is the current type.
25240 (MemberCache.CacheEntry.Container): Removed this field.
25241 (TypeHandle.GetMembers): Include inherited members.
25243 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25245 * typemanager.cs: fixed compilation and added a comment on a field that
25248 2002-08-15 Martin Baulig <martin@gnome.org>
25250 * class.cs (ConstructorInitializer.Resolve): In the
25251 Expression.MemberLookup call, use the queried_type as
25254 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
25255 declared' attribute, it's always true.
25256 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
25257 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
25258 temporary wrapper for FindMembers which tells MemberLookup whether
25259 members from the base classes are included in the return value.
25260 This will go away soon.
25261 (TypeManager.MemberLookup): Use this temporary hack here; once the
25262 new MemberCache is completed, we don't need to do the DeclaredOnly
25263 looping here anymore since the MemberCache will take care of this.
25264 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
25265 (MemberCache): When creating the MemberCache for a class, get
25266 members from the current class and all its base classes.
25267 (MemberCache.CacheEntry.Container): New field. This is a
25268 temporary hack until the Mono runtime is fixed to distinguish
25269 between ReflectedType and DeclaringType. It allows us to use MCS
25270 with both the MS runtime and the unfixed Mono runtime without
25271 problems and without accecting performance.
25272 (MemberCache.SearchMembers): The DeclaredOnly looping from
25273 TypeManager.MemberLookup is now done here.
25275 2002-08-14 Martin Baulig <martin@gnome.org>
25277 * statement.cs (MyStructInfo.MyStructInfo): Don't call
25278 Type.GetFields on dynamic types but get the fields from the
25279 corresponding TypeContainer.
25280 (MyStructInfo.GetStructInfo): Added check for enum types.
25282 * typemanager.cs (MemberList.IsSynchronized): Implemented.
25283 (MemberList.SyncRoot): Implemented.
25284 (TypeManager.FilterWithClosure): No need to check permissions if
25285 closure_start_type == closure_invocation_type, don't crash if
25286 closure_invocation_type is null.
25288 2002-08-13 Martin Baulig <martin@gnome.org>
25290 Rewrote TypeContainer.FindMembers to use a member cache. This
25291 gives us a speed increase of about 35% for the self-hosting MCS
25292 build and of about 15-20% for the class libs (both on GNU/Linux).
25294 * report.cs (Timer): New class to get enhanced profiling. This
25295 whole class is "TIMER" conditional since it remarkably slows down
25298 * class.cs (MemberList): New class. This is an IList wrapper
25299 which we're now using instead of passing MemberInfo[]'s around to
25300 avoid copying this array unnecessarily.
25301 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
25302 (ICachingMemberFinder, IMemberContainer): New interface.
25303 (TypeManager.FilterWithClosure): If `criteria' is null, the name
25304 has already been checked, otherwise use it for the name comparision.
25305 (TypeManager.FindMembers): Renamed to RealMemberFinder and
25306 provided wrapper which tries to use ICachingMemberFinder.FindMembers
25307 if possible. Returns a MemberList, not a MemberInfo [].
25308 (TypeHandle): New class, implements IMemberContainer. We create
25309 one instance of this class per type, it contains a MemberCache
25310 which is used to do the member lookups.
25311 (MemberCache): New class. Each instance of this class contains
25312 all members of a type and a name-based hash table.
25313 (MemberCache.FindMembers): This is our new member lookup
25314 function. First, it looks up all members of the requested name in
25315 the hash table. Then, it walks this list and sorts out all
25316 applicable members and returns them.
25318 2002-08-13 Martin Baulig <martin@gnome.org>
25320 In addition to a nice code cleanup, this gives us a performance
25321 increase of about 1.4% on GNU/Linux - not much, but it's already
25322 half a second for the self-hosting MCS compilation.
25324 * typemanager.cs (IMemberFinder): New interface. It is used by
25325 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25326 Enum, Delegate or Interface.
25327 (TypeManager.finder_to_member_finder): New PtrHashtable.
25328 (TypeManager.finder_to_container): Removed.
25329 (TypeManager.finder_to_delegate): Removed.
25330 (TypeManager.finder_to_interface): Removed.
25331 (TypeManager.finder_to_enum): Removed.
25333 * interface.cs (Interface): Implement IMemberFinder.
25335 * delegate.cs (Delegate): Implement IMemberFinder.
25337 * enum.cs (Enum): Implement IMemberFinder.
25339 * class.cs (TypeContainer): Implement IMemberFinder.
25341 2002-08-12 Martin Baulig <martin@gnome.org>
25343 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25345 2002-08-12 Martin Baulig <martin@gnome.org>
25347 * ecore.cs (ITypeExpression): New interface for expressions which
25349 (TypeExpression): Renamed to TypeLookupExpression.
25350 (Expression.DoResolve): If we're doing a types-only lookup, the
25351 expression must implement the ITypeExpression interface and we
25352 call DoResolveType() on it.
25353 (SimpleName): Implement the new ITypeExpression interface.
25354 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25355 hack, the situation that we're only looking up types can't happen
25356 anymore when this method is called. Moved the type lookup code to
25357 DoResolveType() and call it.
25358 (SimpleName.DoResolveType): This ITypeExpression interface method
25359 is now doing the types-only lookup.
25360 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25361 (ResolveFlags): Added MaskExprClass.
25363 * expression.cs (MemberAccess): Implement the ITypeExpression
25365 (MemberAccess.DoResolve): Added support for a types-only lookup
25366 when we're called via ITypeExpression.DoResolveType().
25367 (ComposedCast): Implement the ITypeExpression interface.
25369 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25370 Expression.Resolve() with ResolveFlags.Type instead.
25372 2002-08-12 Martin Baulig <martin@gnome.org>
25374 * interface.cs (Interface.Define): Apply attributes.
25376 * attribute.cs (Attribute.ApplyAttributes): Added support for
25377 interface attributes.
25379 2002-08-11 Martin Baulig <martin@gnome.org>
25381 * statement.cs (Block.Emit): Only check the "this" variable if we
25382 do not always throw an exception.
25384 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25385 whether the property has a set accessor.
25387 2002-08-11 Martin Baulig <martin@gnome.org>
25389 Added control flow analysis support for structs.
25391 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25392 with control flow analysis turned off.
25393 (IVariable): New interface.
25394 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25395 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25396 (FieldExpr.DoResolve): Resolve the instance expression with flow
25397 analysis turned off and do the definite assignment check after the
25398 resolving when we know what the expression will resolve to.
25400 * expression.cs (LocalVariableReference, ParameterReference):
25401 Implement the new IVariable interface, only call the flow analysis
25402 code if ec.DoFlowAnalysis is true.
25403 (This): Added constructor which takes a Block argument. Implement
25404 the new IVariable interface.
25405 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25406 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25407 This does the definite assignment checks for struct members.
25409 * class.cs (Constructor.Emit): If this is a non-static `struct'
25410 constructor which doesn't have any initializer, call
25411 Block.AddThisVariable() to tell the flow analysis code that all
25412 struct elements must be initialized before control returns from
25415 * statement.cs (MyStructInfo): New public class.
25416 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25417 argument to this indexer. If non-zero, check an individual struct
25418 member, not the whole struct.
25419 (FlowBranching.CheckOutParameters): Check struct members.
25420 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25421 overloaded versions of these methods which take an additional
25422 `int field_idx' argument to check struct members.
25423 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25424 overloaded versions of these methods which take an additional
25425 `string field_name' argument to check struct member.s
25426 (VariableInfo): Implement the IVariable interface.
25427 (VariableInfo.StructInfo): New public property. Returns the
25428 MyStructInfo instance of the variable if it's a struct or null.
25429 (Block.AddThisVariable): New public method. This is called from
25430 Constructor.Emit() for non-static `struct' constructor which do
25431 not have any initializer. It creates a special variable for the
25432 "this" instance variable which will be checked by the flow
25433 analysis code to ensure that all of the struct's fields are
25434 initialized before control returns from the constructor.
25435 (UsageVector): Added support for struct members. If a
25436 variable/parameter is a struct with N members, we reserve a slot
25437 in the usage vector for each member. A struct is considered fully
25438 initialized if either the struct itself (slot 0) or all its
25439 members are initialized.
25441 2002-08-08 Martin Baulig <martin@gnome.org>
25443 * driver.cs (Driver.MainDriver): Only report an error CS5001
25444 if there were no compilation errors.
25446 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25447 `UnsafeContext' property to determine whether the parent is in
25448 unsafe context rather than checking the parent's ModFlags:
25449 classes nested in an unsafe class are unsafe as well.
25451 2002-08-08 Martin Baulig <martin@gnome.org>
25453 * statement.cs (UsageVector.MergeChildren): Distinguish between
25454 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25455 we return. Added test17() and test18() to test-154.cs.
25457 2002-08-08 Martin Baulig <martin@gnome.org>
25459 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25460 Family access, make sure the invoking type isn't a subclass of the
25461 queried type (that'd be a CS1540).
25463 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25464 this method which takes an additional `Type invocation_type'.
25466 * expression.cs (BaseAccess.DoResolve): Use the base type as
25467 invocation and query type.
25468 (MemberAccess.DoResolve): If the lookup failed and we're about to
25469 report a CS0122, try a lookup with the ec.ContainerType - if this
25470 succeeds, we must report a CS1540.
25472 2002-08-08 Martin Baulig <martin@gnome.org>
25474 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25475 (MethodGroupExpr): Implement the IMemberExpr interface.
25477 * expression (MemberAccess.ResolveMemberAccess): No need to have
25478 any special code for MethodGroupExprs anymore, they're now
25481 2002-08-08 Martin Baulig <martin@gnome.org>
25483 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25484 Family, FamANDAssem and FamORAssem permissions.
25485 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25487 2002-08-08 Martin Baulig <martin@gnome.org>
25489 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25490 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25493 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25495 * driver.cs: implemented /resource option to embed managed resources.
25497 2002-08-07 Martin Baulig <martin@gnome.org>
25499 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25500 (FieldBase.HasFieldInitializer): New public property.
25501 (FieldBase.GetInitializerExpression): New public method. Resolves and
25502 returns the field initializer and makes sure it is only resolved once.
25503 (TypeContainer.EmitFieldInitializers): Call
25504 FieldBase.GetInitializerExpression to get the initializer, this ensures
25505 that it isn't resolved multiple times.
25507 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25508 the resolving process (SimpleName/MemberLookup) that we're currently
25509 emitting a field initializer (which must not access any instance members,
25510 this is an error CS0236).
25512 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25513 argument, if the `IsFieldInitializer' flag is set, we must report and
25514 error CS0236 and not an error CS0120.
25516 2002-08-07 Martin Baulig <martin@gnome.org>
25518 * ecore.cs (IMemberExpr): New public interface.
25519 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25520 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25521 if the expression is an IMemberExpr.
25523 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25524 to be null, implicitly default to `this' if we're non-static in
25525 this case. Simplified the code a lot by using the new IMemberExpr
25526 interface. Also fixed bug #28176 here.
25528 2002-08-06 Martin Baulig <martin@gnome.org>
25530 * cs-parser.jay (SimpleLookup): Removed. We need to create
25531 ParameterReferences during semantic analysis so that we can do a
25532 type-only search when resolving Cast, TypeOf and SizeOf.
25533 (block): Pass the `current_local_parameters' to the Block's
25536 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25537 argument to the constructor.
25538 (ConstructorInitializer.Resolve): Create a temporary implicit
25539 block with the parameters.
25541 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25542 references here if we aren't doing a type-only search.
25544 * statement.cs (Block): Added constructor which takes a
25545 `Parameters parameters' argument.
25546 (Block.Parameters): New public property.
25548 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25549 to `Parameters' and made it public readonly.
25551 2002-08-06 Martin Baulig <martin@gnome.org>
25553 * ecore.cs (Expression.Warning): Made this public as well.
25555 * report.cs (Report.Debug): Print the contents of collections.
25557 2002-08-06 Martin Baulig <martin@gnome.org>
25559 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25560 used to tell Resolve() which kinds of expressions it may return.
25561 (Expression.Resolve): Added overloaded version of this method which
25562 takes a `ResolveFlags flags' argument. This can be used to tell
25563 Resolve() which kinds of expressions it may return. Reports a
25565 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25566 ResolveFlags.SimpleName.
25567 (Expression.Error118): Added overloaded version of this method which
25568 takes a `ResolveFlags flags' argument. It uses the flags to determine
25569 which kinds of expressions are allowed.
25571 * expression.cs (Argument.ResolveMethodGroup): New public method.
25572 Resolves an argument, but allows a MethodGroup to be returned.
25573 This is used when invoking a delegate.
25575 * TODO: Updated a bit.
25577 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25579 Fixed compilation with csc.
25581 * ecore.cs: Expression.Error made public. Is this correct? Should
25582 Warning be made public too?
25584 * expression.cs: use ea.Location instead of ea.loc.
25585 [FIXME: Filed as bug #28607: MCS must report these errors.]
25587 2002-08-06 Martin Baulig <martin@gnome.org>
25589 * ecore.cs (Expression.loc): Moved the location here instead of
25590 duplicating it in all derived classes.
25591 (Expression.Location): New public property.
25592 (Expression.Error, Expression.Warning): Made them non-static and
25593 removed the location argument.
25594 (Expression.Warning): Added overloaded version which takes an
25595 `int level' argument.
25596 (Expression.Error118): Make this non-static and removed the
25597 expression and location arguments.
25598 (TypeExpr): Added location argument to the constructor.
25600 * expression.cs (StaticCallExpr): Added location argument to
25602 (Indirection, PointerArithmetic): Likewise.
25603 (CheckedExpr, UnCheckedExpr): Likewise.
25604 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25605 (StringPtr): Likewise.
25608 2002-08-05 Martin Baulig <martin@gnome.org>
25610 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25612 * assign.cs (Assign.DoResolve): Check whether the source
25613 expression is a value or variable.
25615 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25616 while resolving the corresponding blocks.
25618 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25619 an error, don't silently return null.
25621 * statement.cs (Block.AddVariable): Do the error reporting here
25622 and distinguish between CS0128 and CS0136.
25623 (Block.DoResolve): Report all unused labels (warning CS0164).
25624 (LabeledStatement): Pass the location to the constructor.
25625 (LabeledStatement.HasBeenReferenced): New property.
25626 (LabeledStatement.Resolve): Set it to true here.
25628 * statement.cs (Return.Emit): Return success even after reporting
25629 a type mismatch error (CS0126 or CS0127), this is what csc does and
25630 it avoids confusing the users with any consecutive errors.
25632 2002-08-05 Martin Baulig <martin@gnome.org>
25634 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25636 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25638 * expression.cs (MemberAccess.DoResolve): Silently return if an
25639 error has already been reported.
25641 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25642 error has already been reported.
25644 2002-08-05 Martin Baulig <martin@gnome.org>
25646 * statement.cs (UsageVector): Only initialize the `parameters'
25647 vector if we actually have any "out" parameters.
25649 2002-08-05 Martin Baulig <martin@gnome.org>
25651 * expression.cs (Binary.ResolveOperator): When combining delegates,
25652 they must have the same type.
25654 2002-08-05 Martin Baulig <martin@gnome.org>
25656 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25657 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25658 work with the ms runtime and we also don't need it: if we're a
25659 PropertyBuilder and not in the `indexer_arguments' hash, then we
25660 are a property and not an indexer.
25662 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25663 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25664 since the latter one doesn't work with the ms runtime.
25666 2002-08-03 Martin Baulig <martin@gnome.org>
25668 Fixed bugs #27998 and #22735.
25670 * class.cs (Method.IsOperator): New public field.
25671 (Method.CheckBase): Report CS0111 if there's already a method
25672 with the same parameters in the current class. Report CS0508 when
25673 attempting to change the return type of an inherited method.
25674 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25675 and it's not marked abstract or extern.
25676 (PropertyBase): New abstract base class for Property and Indexer.
25677 (PropertyBase.CheckBase): Moved here from Property and made it work
25679 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25680 the same so we can reuse it there.
25681 (Property, Indexer): Derive from PropertyBase.
25682 (MethodSignature.inheritable_property_signature_filter): New delegate
25683 to find properties and indexers.
25685 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25686 argument and improved error reporting.
25688 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25689 EmptyReadOnlyParameters and made it a property.
25691 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25692 version of this method which takes a `PropertyInfo indexer'.
25693 (TypeManager.RegisterIndexer): New method.
25695 * class.cs: Added myself as author of this file :-)
25697 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25699 * class.cs: fixed compilation on windoze.
25701 2002-08-03 Martin Baulig <martin@gnome.org>
25703 * interface.cs (Interface.GetInterfaceBases): Check whether all
25704 base interfaces are at least as accessible than the current one.
25706 * class.cs (TypeContainer.GetClassBases): Check whether base types
25707 are at least as accessible than the current type.
25708 (TypeContainer.AsAccessible): Implemented and made non-static.
25709 (MemberBase.CheckParameters): Report errors if the accessibility
25712 * delegate.cs (Delegate.Delegate): The default visibility is
25713 internal for top-level types and private for nested types.
25714 (Delegate.Define): Report errors if the accessibility checks fail.
25716 * enum.cs (Enum.Enum): The default visibility is internal for
25717 top-level types and private for nested types.
25718 (Enum.DefineType): Compute the correct visibility.
25720 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25721 function which takes a `bool is_toplevel' instead of a TypeContainer.
25723 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25726 2002-08-02 Martin Baulig <martin@gnome.org>
25728 * expression.cs (LocalVariableReferenc): Added constructor which
25729 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25730 (LocalVariableReference.IsReadOnly): New property.
25731 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25732 variable is readonly, use our own readonly flag to do this; you can
25733 use the new constructor to get a writable reference to a read-only
25736 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25737 reference to the local variable.
25739 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25741 * rootcontext.cs (ResolveCore): Also include System.Exception
25743 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25744 we reach an EmptyStatement.
25746 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25749 * expression.cs (Binary.ResolveOperator): Check error result in
25752 use brtrue/brfalse directly and avoid compares to null.
25754 2002-08-02 Martin Baulig <martin@gnome.org>
25756 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25757 Fixes bug #28407, added test-155.cs.
25759 2002-08-01 Martin Baulig <martin@gnome.org>
25761 * class.cs (Event.EmitDefaultMethod): Make this work with static
25762 events. Fixes #28311, added verify-3.cs.
25764 2002-08-01 Martin Baulig <martin@gnome.org>
25766 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25767 `is_disposable' fields.
25768 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25769 `hm.is_disposable' if we're using the collection pattern.
25770 (Foreach.EmitCollectionForeach): Use the correct type for the
25771 enumerator's local variable, only emit the try/finally block if
25772 necessary (fixes #27713).
25774 2002-08-01 Martin Baulig <martin@gnome.org>
25776 * ecore.cs (Expression.report118): Renamed to Error118 and made
25779 * statement.cs (Throw.Resolve): Check whether the expression is of
25780 the correct type (CS0118) and whether the type derives from
25781 System.Exception (CS0155).
25782 (Catch.Resolve): New method. Do the type lookup here and check
25783 whether it derives from System.Exception (CS0155).
25784 (Catch.CatchType, Catch.IsGeneral): New public properties.
25786 * typemanager.cs (TypeManager.exception_type): Added.
25788 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25790 * driver.cs: Updated About function.
25792 2002-07-31 Martin Baulig <martin@gnome.org>
25794 Implemented Control Flow Analysis.
25796 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25797 (EmitContext.CurrentBranching): Added.
25798 (EmitContext.StartFlowBranching): Added.
25799 (EmitContext.EndFlowBranching): Added.
25800 (EmitContext.KillFlowBranching): Added.
25801 (EmitContext.IsVariableAssigned): Added.
25802 (EmitContext.SetVariableAssigned): Added.
25803 (EmitContext.IsParameterAssigned): Added.
25804 (EmitContext.SetParameterAssigned): Added.
25805 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25806 Added control flow analysis stuff here.
25808 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25809 resolve the expression as lvalue.
25810 (LocalVariableReference.DoResolve): Check whether the variable has
25811 already been assigned.
25812 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25813 the parameter as assigned here.
25814 (ParameterReference.DoResolve): Check whether the parameter has already
25816 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25817 expression as lvalue.
25819 * statement.cs (FlowBranching): New class for the flow analysis code.
25820 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25821 (LabeledStatement.IsDefined): New public property.
25822 (LabeledStatement.AddUsageVector): New public method to tell flow
25823 analyis that the label may be reached via a forward jump.
25824 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25826 (VariableInfo.Number): New public field. This is used by flow analysis
25827 to number all locals of a block.
25828 (Block.CountVariables): New public property. This is the number of
25829 local variables in this block (including the locals from all parent
25831 (Block.EmitMeta): Number all the variables.
25833 * statement.cs: Added flow analysis support to all classes.
25835 2002-07-31 Martin Baulig <martin@gnome.org>
25837 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25838 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25839 then use this argument.
25841 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25843 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25844 use this to specify /define options.
25846 2002-07-29 Martin Baulig <martin@gnome.org>
25848 * statement.cs (Fixed): Moved all code that does variable lookups
25849 and resolvings from Emit to Resolve.
25851 * statement.cs (For): Moved all code that does variable lookups
25852 and resolvings from Emit to Resolve.
25854 * statement.cs (Using): Moved all code that does variable lookups
25855 and resolvings from Emit to Resolve.
25857 2002-07-29 Martin Baulig <martin@gnome.org>
25859 * attribute.cs (Attribute.Resolve): Explicitly catch a
25860 System.NullReferenceException when creating the
25861 CustromAttributeBuilder and report a different warning message.
25863 2002-07-29 Martin Baulig <martin@gnome.org>
25865 * support.cs (ParameterData.ParameterName): Added method to
25866 get the name of a parameter.
25868 * typemanager.cs (TypeManager.IsValueType): New public method.
25870 2002-07-29 Martin Baulig <martin@gnome.org>
25872 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25873 is a flag which specifies that it's either ref or out.
25874 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25875 the out parameter to `out Parameter.Modifier mod', also set the
25876 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25878 * support.cs (InternalParameters.ParameterModifier): Distinguish
25879 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25880 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25882 * expression.cs (Argument.GetParameterModifier): Distinguish
25883 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25884 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25886 2002-07-29 Martin Baulig <martin@gnome.org>
25888 * expression.cs (ParameterReference.ParameterReference): Added
25889 `Location loc' argument to the constructor.
25891 * cs-parser.jay: Pass location to ParameterReference.
25893 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25895 * statement.cs (Try): Initialize the location.
25897 * cs-parser.jay: pass location to Try.
25899 * expression.cs (Unary.Reduce): Change the prototype to return
25900 whether a constant fold could be performed or not. The result is
25901 returned in an out parameters. In the case of Indirection and
25902 AddressOf, we want to perform the full tests.
25904 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25906 * statement.cs (Statement.Emit): Flag dead code.
25908 2002-07-27 Andrew Birkett <andy@nobugs.org>
25910 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25912 2002-07-27 Martin Baulig <martin@gnome.org>
25914 * class.cs (MethodData.Define): Put back call to
25915 TypeManager.AddMethod(), accidentally commented this out.
25917 * report.cs (Debug): New public method to print debugging information,
25918 this is `[Conditional ("DEBUG")]'.
25920 2002-07-26 Martin Baulig <martin@gnome.org>
25922 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25923 (switch_statement): Push the current_block to the switch_stack and
25924 pop it again when we're done with the switch.
25925 (switch_section): The new block is a child of the current_block.
25926 Fixes bug #24007, added test-152.cs.
25928 2002-07-27 Martin Baulig <martin@gnome.org>
25930 * expression.cs (Invocation.EmitArguments): When calling a varargs
25931 function with only its fixed arguments, we need to pass an empty
25934 2002-07-27 Martin Baulig <martin@gnome.org>
25936 Mono 0.13 has been released.
25938 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25940 * driver.cs: Rename --resource to --linkres, because that is what
25941 we do currently, we dont support --resource yet.
25943 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25945 2002-07-25 Martin Baulig <martin@gnome.org>
25947 * class.cs (MethodData): New public class. This is a `method builder'
25948 class for a method or one accessor of a Property/Indexer/Event.
25949 (MethodData.GetMethodFlags): Moved here from MemberBase.
25950 (MethodData.ApplyAttributes): Likewise.
25951 (MethodData.ApplyObsoleteAttribute): Likewise.
25952 (MethodData.ApplyConditionalAttribute): Likewise.
25953 (MethodData.ApplyDllImportAttribute): Likewise.
25954 (MethodData.CheckAbstractAndExternal): Likewise.
25955 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25956 (MethodData.Emit): Formerly known as Method.Emit().
25957 (MemberBase): Moved everything which was specific to a single
25958 accessor/method to MethodData.
25959 (Method): Create a new MethodData and call Define() and Emit() on it.
25960 (Property, Indexer, Event): Create a new MethodData objects for each
25961 accessor and call Define() and Emit() on them.
25963 2002-07-25 Martin Baulig <martin@gnome.org>
25965 Made MethodCore derive from MemberBase to reuse the code from there.
25966 MemberBase now also checks for attributes.
25968 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25969 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25971 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25972 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25973 (MemberBase.ApplyAttributes): New virtual method; applies the
25974 attributes to a method or accessor.
25975 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25976 (MemberBase.ApplyConditionalAttribute): Likewise.
25977 (MemberBase.ApplyDllImportAttribute): Likewise.
25978 (MemberBase.CheckAbstractAndExternal): Likewise.
25979 (MethodCore.ParameterTypes): This is now a property instead of a
25980 method, it's initialized from DoDefineParameters().
25981 (MethodCore.ParameterInfo): Removed the set accessor.
25982 (MethodCore.DoDefineParameters): New protected virtual method to
25983 initialize ParameterTypes and ParameterInfo.
25984 (Method.GetReturnType): We can now simply return the MemberType.
25985 (Method.GetMethodFlags): Override the MemberBase version and add
25986 the conditional flags.
25987 (Method.CheckBase): Moved some code from Define() here, call
25988 DoDefineParameters() here.
25989 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25990 here to avoid some larger code duplication.
25991 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25992 ensure that abstract and external accessors don't declare a body.
25994 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25995 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25996 lookup in the attribute's parent classes, so we need to abort as soon
25997 as we found the first match.
25998 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25999 the attribute has no arguments.
26001 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
26004 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26006 * cs-parser.jay: reverted previous patch.
26008 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26010 * cs-parser.jay: fixed bug #22119.
26012 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26014 * attribute.cs: fixed compilation. The error was:
26015 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
26016 be assigned to before control leaves the current method."
26017 [FIXME: Filed as bug #28186: MCS must report this error.]
26019 2002-07-25 Martin Baulig <martin@gnome.org>
26021 * attribute.cs (Attribute.Conditional_GetConditionName): New static
26022 method to pull the condition name ouf of a Conditional attribute.
26023 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
26024 the obsolete message and error flag out of an Obsolete attribute.
26026 * class.cs (Method.GetMethodFlags): New public method to get the
26027 TypeManager.MethodFlags for this method.
26028 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
26030 (Method.Define): Get and apply the Obsolete and Conditional attributes;
26031 if we're overriding a virtual function, set the new private variable
26032 `parent_method'; call the new TypeManager.AddMethod().
26034 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
26035 the MethodBuilder and the Method in a PtrHashtable.
26036 (TypeManager.builder_to_method): Added for this purpose.
26037 (TypeManager.MethodFlags): Added IsObsoleteError.
26038 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
26039 Obsolete and Conditional arguments in MethodBuilders. If we discover
26040 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
26041 the message from the attribute.
26043 2002-07-24 Martin Baulig <martin@gnome.org>
26045 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
26046 preprocessor directives, ensure that the argument to #define/#undef is
26047 exactly one identifier and that it's actually an identifier.
26049 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
26052 2002-07-24 Martin Baulig <martin@gnome.org>
26054 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
26055 initialize it to TypeManager.object_type in the constructor.
26056 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
26057 of the `hm.get_current' method if we're using the collection pattern.
26058 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
26059 for the explicit conversion to make it work when we're using the collection
26060 pattern and the `Current' property has a different return type than `object'.
26063 2002-07-24 Martin Baulig <martin@gnome.org>
26065 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
26066 does not match, but don't report any errors. This method is called in
26067 order for all methods in a MethodGroupExpr until a matching method is
26068 found, so we don't want to bail out if the first method doesn't match.
26069 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
26070 matches, report the 123. Fixes #28070.
26072 2002-07-24 Martin Baulig <martin@gnome.org>
26074 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
26075 TypeManager.TypeToCoreType() to the top of the method so the
26076 following equality checks will work. Fixes #28107.
26078 2002-07-24 Martin Baulig <martin@gnome.org>
26080 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
26081 operand is of type uint, and the other operand is of type sbyte,
26082 short or int, the operands are converted to type long." -
26083 Actually do what this comment already told us. Fixes bug #28106,
26086 2002-07-24 Martin Baulig <martin@gnome.org>
26088 * class.cs (MethodBase): New abstract class. This is now a base
26089 class for Property, Indexer and Event to avoid some code duplication
26090 in their Define() and DefineMethods() methods.
26091 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
26092 generic methods for Define() and DefineMethods().
26093 (FieldBase): Derive from MemberBase, not MemberCore.
26094 (Property): Derive from MemberBase, not MemberCore.
26095 (Property.DefineMethod): Moved all the code from this method to the
26096 new MethodBase.DefineAccessor(), just call it with appropriate
26098 (Property.Define): Call the new Property.DoDefine(), this does some
26099 sanity checks and we don't need to duplicate the code everywhere.
26100 (Event): Derive from MemberBase, not MemberCore.
26101 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
26102 accessors, this will also make them work with interface events.
26103 (Indexer): Derive from MemberBase, not MemberCore.
26104 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
26105 (Indexer.Define): Use the new MethodBase functions.
26107 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
26108 argument to the constructor.
26109 (Interface.FindMembers): Added support for interface events.
26110 (Interface.PopluateEvent): Implemented.
26112 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
26114 2002-07-22 Miguel de Icaza <miguel@ximian.com>
26116 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
26117 but this is required to check for a method name being the same as
26118 the containing class.
26122 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26124 * interface.cs: initialize variable.
26126 2002-07-23 Martin Baulig <martin@gnome.org>
26128 Implemented the IndexerName attribute in interfaces.
26130 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
26131 name if this is an explicit interface implementation.
26132 (Indexer.InterfaceIndexerName): New public variable. If we're
26133 implementing an interface indexer, this is the IndexerName in that
26134 interface. Otherwise, it's the IndexerName.
26135 (Indexer.DefineMethod): If we're implementing interface indexer,
26136 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
26137 and Pending.ImplementIndexer methods.
26138 (Indexer.Define): Also define the PropertyBuilder if we're
26139 implementing an interface indexer and this is neither an explicit
26140 interface implementation nor do the IndexerName match the one in
26143 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
26144 If a method is defined here, then we always need to create a proxy
26145 for it. This is used when implementing interface indexers.
26146 (Pending.IsInterfaceIndexer): New public method.
26147 (Pending.ImplementIndexer): New public method.
26148 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
26149 This is used when implementing interface indexers to define a proxy
26151 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
26152 define a proxy if necessary.
26154 * interface.cs (Interface.IndexerName): New public variable.
26155 (Interface.PopulateIndexer): Set the IndexerName.
26156 (Interface.DefineIndexers): New private method. Populate all the
26157 indexers and make sure their IndexerNames match.
26159 * typemanager.cs (IndexerPropertyName): Added support for interface
26162 2002-07-22 Martin Baulig <martin@gnome.org>
26164 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
26165 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
26166 ret if HasReturnLabel.
26167 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
26170 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
26171 and set the ec.LoopBeginTryCatchLevel.
26172 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
26173 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
26174 the current ec.TryCatchLevel, the branch goes out of an exception
26175 block. In this case, we need to use Leave and not Br.
26177 2002-07-22 Martin Baulig <martin@gnome.org>
26179 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
26180 block unless the block does not always return or it is contained in
26181 another try { ... } catch { ... } block. Fixes bug #26506.
26182 Added verify-1.cs to the test suite.
26184 2002-07-22 Martin Baulig <martin@gnome.org>
26186 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
26187 then we do not always return. Fixes bug #24985.
26189 2002-07-22 Martin Baulig <martin@gnome.org>
26191 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
26192 lookup on a per-class level; ie. walk up the class hierarchy until we
26193 found at least one applicable method, then choose the best among them.
26194 Fixes bug #24463 and test-29.cs.
26196 2002-07-22 Martin Baulig <martin@gnome.org>
26198 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
26199 return types of the methods. The return type is not part of the
26200 signature and we must not check it to make the `new' modifier work.
26201 Fixes bug #27999, also added test-147.cs.
26202 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
26204 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
26205 on the method's return type.
26207 2002-07-21 Martin Baulig <martin@gnome.org>
26209 * assign.cs: Make this work if the rightmost source is a constant and
26210 we need to do an implicit type conversion. Also adding a few more tests
26211 to test-38.cs which should have caught this.
26213 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
26214 target in the makefile for this. The makefile.gnu is primarily intended
26215 for end-users who don't want to debug the compiler.
26217 2002-07-21 Martin Baulig <martin@gnome.org>
26219 * assign.cs: Improved the Assign class so it can now handle embedded
26220 assignments (X = Y = Z = something). As a side-effect this'll now also
26221 consume less local variables. test-38.cs now passes with MCS, added
26222 a few new test cases to that test.
26224 2002-07-20 Martin Baulig <martin@gnome.org>
26226 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
26227 instructions. Fixes bug #27977, also added test-146.cs.
26229 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26231 * cs-tokenizer.cs: fixed getHex ().
26233 2002-07-19 Martin Baulig <martin@gnome.org>
26235 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
26236 not Type.GetType() to lookup the array type. This is needed when
26237 we're constructing an array of a user-defined type.
26238 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
26239 single-dimensional arrays, but also for single-dimensial arrays of
26242 2002-07-19 Martin Baulig <martin@gnome.org>
26244 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
26245 this function is called, it's not allowed to share LocalBuilders
26246 among ILGenerators.
26248 2002-07-19 Martin Baulig <martin@gnome.org>
26250 * expression.cs (Argument.Resolve): Report an error 118 when trying
26251 to pass a type as argument.
26253 2002-07-18 Martin Baulig <martin@gnome.org>
26255 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
26256 Conv_R_Un for the signed `long' type.
26258 2002-07-15 Miguel de Icaza <miguel@ximian.com>
26260 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
26261 `expr' for the temporary result, as that will fail if we do
26262 multiple resolves on the same expression.
26264 2002-07-05 Miguel de Icaza <miguel@ximian.com>
26266 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
26267 ec.TypeContainer for looking up aliases.
26269 * class.cs (TypeContainer): Remove LookupAlias from here.
26271 * decl.cs (DeclSpace); Move here.
26273 2002-07-01 Miguel de Icaza <miguel@ximian.com>
26275 * class.cs (FindMembers): Only call filter if the constructor
26276 bulider is not null.
26278 Also handle delegates in `NestedTypes' now. Now we will perform
26279 type lookups using the standard resolution process. This also
26282 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
26283 This uses Expressions (the limited kind that can be parsed by the
26284 tree) instead of strings.
26286 * expression.cs (ComposedCast.ToString): Implement, used to flag
26287 errors since now we have to render expressions.
26289 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
26292 * ecore.cs (SimpleName.ToString): ditto.
26294 * cs-parser.jay: Instead of using strings to assemble types, use
26295 Expressions to assemble the type (using SimpleName, ComposedCast,
26296 MemberAccess). This should fix the type lookups in declarations,
26297 because we were using a different code path for this.
26299 * statement.cs (Block.Resolve): Continue processing statements
26300 even when there is an error.
26302 2002-07-17 Miguel de Icaza <miguel@ximian.com>
26304 * class.cs (Event.Define): Also remove the `remove' method from
26305 the list of pending items.
26307 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
26308 generate more compact code.
26310 2002-07-17 Martin Baulig <martin@gnome.org>
26312 * const.cs (Const.LookupConstantValue): Add support for constant
26313 `unchecked' and `checked' expressions.
26314 Also adding test case test-140.cs for this.
26316 2002-07-17 Martin Baulig <martin@gnome.org>
26318 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26319 check whether mi.ReturnType implements the IEnumerator interface; the
26320 `==' and the IsAssignableFrom() will fail in this situation.
26322 2002-07-16 Ravi Pratap <ravi@ximian.com>
26324 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26327 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26329 * expression.cs: fixed bug #27811.
26331 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26333 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26334 Molaro: when we are a ref, the value already contains a pointer
26335 value, do not take the address of it.
26337 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26338 * removed mb-parser.jay and mb-tokenizer.cs
26340 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26342 * expression.cs: check against the building corlib void type.
26344 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26346 * ecore.cs: fix for valuetype static readonly fields: when
26347 initializing them, we need their address, not the address of a copy.
26349 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26351 * typemanager.cs: register also enum_type in corlib.
26353 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26355 * class.cs: allow calling this (but not base) initializers in structs.
26357 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26359 * ecore.cs: make sure we compare against the building base types
26362 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26364 * typemanager.cs: fix TypeToCoreType() to handle void and object
26365 (corlib gets no more typerefs after this change).
26367 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26369 * expression.cs (ArrayCreation.EmitArrayArguments): use
26370 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26372 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26373 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26374 array indexes, the runtime actually forbids them.
26376 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26377 for array arguments here.
26379 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26380 instead of the default for ValueTypes.
26382 (New.DoEmit): Use IsValueType instead of
26383 IsSubclassOf (value_type)
26384 (New.DoResolve): ditto.
26385 (Invocation.EmitCall): ditto.
26387 * assign.cs (Assign): ditto.
26389 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26390 Statements *are* currently doing part of their resolution during
26393 Expressions do always resolve during resolve, but statements are
26394 only required to propagate resolution to their children.
26396 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26398 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26400 (LoadAssembly): Do not add the dll if it is already specified
26402 (MainDriver): Add the System directory to the link path at the end,
26403 after all the other -L arguments.
26405 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26406 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26407 ldelem.u1) and using the opposite for sbytes.
26409 This fixes Digger, and we can finally run it.
26411 * driver.cs (UnixParseOption): Move the option parsing here.
26412 (CSCParseOption): Implement CSC-like parsing of options.
26414 We now support both modes of operation, the old Unix way, and the
26415 new CSC-like way. This should help those who wanted to make cross
26416 platform makefiles.
26418 The only thing broken is that /r:, /reference: and /lib: are not
26419 implemented, because I want to make those have the same semantics
26420 as the CSC compiler has, and kill once and for all the confussion
26421 around this. Will be doing this tomorrow.
26423 * statement.cs (Unsafe.Resolve): The state is checked during
26424 resolve, not emit, so we have to set the flags for IsUnsfe here.
26426 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26428 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26429 not catch the Error_ObjectRefRequired in SimpleName (as it is
26430 possible to have a class/instance variable name that later gets
26431 deambiguated), we have to check this here.
26433 2002-07-10 Ravi Pratap <ravi@ximian.com>
26435 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26436 make static and put into Expression.
26438 (Event.Define): Register the private field of the event with the
26439 TypeManager so that GetFieldFromEvent can get at it.
26441 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26442 keep track of the private field associated with an event which
26445 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26448 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26450 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26452 * expression.cs (Binary.EmitBranchable): this routine emits the
26453 Binary expression in a branchable context. This basically means:
26454 we need to branch somewhere, not just get the value on the stack.
26456 This works together with Statement.EmitBoolExpression.
26458 * statement.cs (Statement.EmitBoolExpression): Use
26461 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26463 * statement.cs (For): Reduce the number of jumps in loops.
26465 (For): Implement loop inversion for the For statement.
26467 (Break): We can be breaking out of a Try/Catch controlled section
26468 (foreach might have an implicit try/catch clause), so we need to
26469 use Leave instead of Br.
26471 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26472 now). If the instace expression supports IMemoryLocation, we use
26473 the AddressOf method from the IMemoryLocation to extract the
26474 address instead of emitting the instance.
26476 This showed up with `This', as we were emitting the instance
26477 always (Emit) instead of the Address of This. Particularly
26478 interesting when This is a value type, as we dont want the Emit
26479 effect (which was to load the object).
26481 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26483 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26485 * statement.cs (Checked): Set the CheckedState during the resolve
26486 process too, as the ConvCast operations track the checked state on
26487 the resolve process, and not emit.
26489 * cs-parser.jay (namespace_member_declaration): Flag that we have
26490 found a declaration when we do. This is used to flag error 1529
26492 * driver.cs: Report ok when we display the help only.
26494 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26496 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26498 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26500 * cs-tokenizer.cs (define): We also have to track locally the
26501 defines. AllDefines is just used for the Conditional Attribute,
26502 but we also need the local defines for the current source code.
26504 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26506 * statement.cs (While, For, Do): These loops can exit through a
26507 Break statement, use this information to tell whether the
26508 statement is the last piece of code.
26510 (Break): Flag that we break.
26512 * codegen.cs (EmitContexts): New `Breaks' state variable.
26514 2002-07-03 Martin Baulig <martin@gnome.org>
26516 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26517 modifiers in method declarations in structs. Otherwise, you won't
26518 be able to override things like Object.Equals().
26520 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26522 * class.cs (Method, Property, Indexer): Do not allow the public
26523 modifier to be used in explicit interface implementations.
26525 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26526 override modifiers in method declarations in structs
26528 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26530 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26531 integer or real overflow, report an error
26533 2002-07-02 Martin Baulig <martin@gnome.org>
26535 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26536 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26537 to tell the runtime about our newly created System.Object and
26538 System.ValueType types.
26540 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26542 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26543 struct instead of Ldarg/Starg.
26545 2002-07-02 Martin Baulig <martin@gnome.org>
26547 * expression.cs (Indirection.Indirection): Call
26548 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26550 2002-07-02 Martin Baulig <martin@gnome.org>
26552 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26553 ValueType, call TypeManager.TypeToCoreType() on it.
26554 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26555 the OpCodes.Newarr argument.
26557 2002-07-02 Martin Baulig <martin@gnome.org>
26559 * expression.cs (Invocation.EmitCall): When compiling corlib,
26560 replace all calls to the system's System.Array type to calls to
26561 the newly created one.
26563 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26564 System.Array methods.
26565 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26566 from the system's System.Array type which must be replaced.
26568 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26570 * typemanager.cs: load unverifiable_code_ctor so we can build
26571 corlib using the correct type. Avoid using GetTypeCode() with
26573 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26574 TypeManager.object_type to allow building corlib.
26576 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26578 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26580 2002-07-01 Martin Baulig <martin@gnome.org>
26582 * class.cs: Make the last change actually work, we need to check
26583 whether `ifaces != null' to avoid a crash.
26585 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26587 * class.cs: when we build structs without fields that implement
26588 interfaces, we need to add the interfaces separately, since there is
26589 no API to both set the size and add the interfaces at type creation
26592 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26594 * expression.cs: the dimension arguments to the array constructors
26595 need to be converted if they are a long.
26597 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26599 * class.cs: don't emit ldarg.0 if there is no parent constructor
26600 (fixes showstopper for corlib).
26602 2002-06-29 Martin Baulig <martin@gnome.org>
26604 MCS now compiles corlib on GNU/Linux :-)
26606 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26607 ie. check for MethodImplOptions.InternalCall.
26609 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26610 and TypeManager.attribute_type are null, so we must explicitly check
26611 whether parent is not null to find out whether it's an attribute type.
26612 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26613 and SetBuilder, not only if the property is neither abstract nor external.
26614 This is necessary to set the MethodImplOptions on the accessor methods.
26615 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26616 SetBuilder, see Property.Emit().
26618 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26619 populate "System.Object", "System.ValueType" and "System.Attribute" since
26620 they've already been populated from BootCorlib_PopulateCoreTypes().
26622 2002-06-29 Martin Baulig <martin@gnome.org>
26624 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26625 is the NullLiteral, we also need to make sure that target_type is not
26628 2002-06-29 Martin Baulig <martin@gnome.org>
26630 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26631 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26632 before calling BootstrapCorlib_ResolveDelegate ().
26634 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26636 * statement.cs: fixed build-breaker. All tests passed ok.
26638 2002-06-27 Martin Baulig <martin@gnome.org>
26640 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26641 for System.Decimal when compiling corlib.
26643 2002-06-27 Martin Baulig <martin@gnome.org>
26645 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26646 switch blocks which contain nothing but a default clause.
26648 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26650 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26652 2002-06-27 Martin Baulig <martin@gnome.org>
26654 * ecore.cs (PropertyExpr.PropertyExpr): Call
26655 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26657 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26658 is already a TypeBuilder.
26660 2002-06-27 Martin Baulig <martin@gnome.org>
26662 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26663 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26664 the "from an array-type to System.Array" case. This makes it work
26665 when compiling corlib.
26667 2002-06-27 Martin Baulig <martin@gnome.org>
26669 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26670 non-static PropertyExpr, set its InstanceExpression. This makes
26671 the `ICollection.Count' property work in System/Array.cs.
26673 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26675 * driver.cs: Made error handling more consistent. Errors now
26676 tracked by Report class, so many methods which used to return int
26677 now return void. Main() now prints success/failure and
26678 errors/warnings message.
26680 Renamed '--probe' compiler argument to '--expect-error'. Removed
26681 the magic number return values (123 and 124). Now, if the
26682 expected error occurs, the compiler exits with success (exit value
26683 0). If the compilation completes without seeing that particular
26684 error, the compiler exits with failure (exit value 1). The
26685 makefile in mcs/errors has been changed to handle the new behaviour.
26687 * report.cs: Made 'expected error' number a property and renamed
26688 it from 'Probe' to 'ExpectedError'.
26690 * genericparser.cs: Removed error handling support, since it is
26691 now all done by Report class.
26693 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26694 class, so parse() no longer returns an int.
26696 * namespace.cs: Use Report.Error instead of GenericParser.error
26698 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26700 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26701 TypeContainer.AddOperator): At the front of the list put the
26702 explicit implementations, so they get resolved/defined first.
26704 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26706 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26707 interface type is implemented by this TypeContainer. Used during
26708 explicit interface implementation.
26710 (Property.Define, Indexer.Define, Method.Define): Validate that
26711 the given interface in the explicit implementation is one of the
26712 base classes for the containing type.
26714 Also if we are explicitly implementing an interface, but there is
26715 no match in the pending implementation table, report an error.
26717 (Property.Define): Only define the property if we are
26718 not explicitly implementing a property from an interface. Use the
26719 correct name also for those properties (the same CSC uses,
26720 although that is really not needed).
26722 (Property.Emit): Do not emit attributes for explicitly implemented
26723 properties, as there is no TypeBuilder.
26725 (Indexer.Emit): ditto.
26727 Hiding then means that we do not really *implement* a pending
26728 implementation, which makes code fail.
26730 2002-06-22 Martin Baulig <martin@gnome.org>
26732 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26733 the return value of Object.GetType(). [FIXME: we need to do this whenever
26734 we get a type back from the reflection library].
26736 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26738 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26740 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26742 * attribute.cs: Return null if we can not look up the type.
26744 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26745 the interface types found.
26747 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26748 interface types found.
26750 * typemanager.cs (GetInterfaces): Make this routine returns alll
26751 the interfaces and work around the lame differences between
26752 System.Type and System.Reflection.Emit.TypeBuilder in the results
26753 result for GetInterfaces.
26755 (ExpandInterfaces): Given an array of interface types, expand and
26756 eliminate repeated ocurrences of an interface. This expands in
26757 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26760 2002-06-21 Martin Baulig <martin@gnome.org>
26762 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26765 2002-06-21 Martin Baulig <martin@gnome.org>
26767 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26768 and called with one of the core types, return the corresponding typebuilder for
26771 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26774 2002-06-21 Martin Baulig <martin@gnome.org>
26776 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26777 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26778 (Expression.ConvertReferenceExplicit): Likewise.
26780 * expression.cs (ElementAccess.DoResolve): Likewise.
26781 (ElementAccess.DoResolveLValue): Likewise.
26783 2002-06-10 Martin Baulig <martin@gnome.org>
26785 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26786 add the "value" parameter to the parameter list.
26788 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26791 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26793 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26794 the argument to an int, uint, long or ulong, per the spec. Also
26795 catch negative constants in array creation.
26797 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26799 * class.cs: do not allow the same interface to appear twice in
26800 the definition list.
26802 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26804 * ecore.cs: don't use ldlen with System.Array.
26806 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26808 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26810 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26812 * modifiers.cs: produce correct field attributes for protected
26813 internal. Easy fix so miguel can work on ther harder stuff:-)
26815 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26817 * pending.cs: New file. Move the code from class.cs here.
26818 Support clearning the pending flag for all methods (when not doing
26819 explicit interface implementation).
26821 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26823 * rootcontext.cs: added a couple more types needed to bootstrap.
26825 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26827 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26828 constructor in the type, instead of any constructor in the type
26829 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26830 a bug in the Mono runtime when applying the params attribute).
26832 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26833 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26835 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26837 * expression.cs (Unary.ResolveOperator): Use TypeManager
26838 to resolve the type.
26840 2002-06-13 Ravi Pratap <ravi@ximian.com>
26842 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26845 * enum.cs (AddEnumMember): Add support to store the attributes associated
26846 with each member too.
26848 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26849 field builders too - this takes care of the enum member case.
26851 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26853 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26854 address-of operator on both value types and pointers.
26856 2002-06-10 Martin Baulig <martin@gnome.org>
26858 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26859 PropertyBuilder to the `property_builders' list.
26861 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26862 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26863 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26864 find any indexers which are inherited from an interface.
26866 2002-06-09 Martin Baulig <martin@gnome.org>
26868 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26869 the same type as the constant if necessary. There's also a test-130.cs
26872 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26874 * typemanager.cs (TypeManager.ChangeType): Previously known as
26875 Enum.ChangeEnumType().
26877 2002-06-09 Martin Baulig <martin@gnome.org>
26879 * expression.cs (Cast.TryReduce): Added support for consts.
26881 2002-06-08 Ravi Pratap <ravi@ximian.com>
26883 * class.cs (Accessor): Hold attributes information so we can pass
26886 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26887 Modify to pass in attributes attached to the methods.
26889 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26891 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26892 to handle the Accessor kind :-)
26894 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26896 2002-06-08 Martin Baulig <martin@gnome.org>
26898 * expression.cs (Unary.TryReduceNegative): Added support for
26901 2002-06-08 Martin Baulig <martin@gnome.org>
26903 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26904 name can't be found in the `defined_names' - the caller will do a
26905 MemberLookup in this case and thus find methods in System.Enum
26906 such as Enum.IsDefined().
26908 2002-06-08 Martin Baulig <martin@gnome.org>
26910 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26911 Convert.ChangeType() which works with TypeBuilder created types.
26912 (Enum.LookupEnumValue, Enum.Define): Use it here.
26914 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26915 `TypeBuilder.BaseType != null' check.
26916 (TypeContainer.FindMembers): Only lookup parent members if we
26917 actually have a parent.
26918 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26919 (ConstructorInitializer.Resolve): Likewise.
26921 * interface.cs (Interface.FindMembers): Added
26922 `TypeBuilder.BaseType != null' check.
26924 * rootcontext.cs (RootContext.ResolveCore): Added
26925 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26926 classes_second_stage.
26928 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26929 debug_type and trace_type when compiling with --nostdlib.
26931 2002-06-07 Martin Baulig <martin@gnome.org>
26933 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26934 (AddField): Set it to true when adding a non-static field.
26935 (DefineType): Use `have_nonstatic_fields' to find out whether we
26936 have non-static fields, not `Fields != null'.
26938 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26940 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26941 dereferencing a null on the static-field code path)
26943 2002-05-30 Martin Baulig <martin@gnome.org>
26945 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26946 to take command line arguments. Use reflection to call the new
26947 custom `Initialize' function on the symbol writer and pass it the
26948 command line arguments.
26950 * driver.cs (--debug-args): New command line argument to pass command
26951 line arguments to the symbol writer.
26953 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26955 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26956 the target type for indexers and properties. Thanks to Joe for
26959 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26961 * typemanager.cs (MethodFlags): returns the method flags
26962 (Obsolete/ShouldIgnore) that control warning emission and whether
26963 the invocation should be made, or ignored.
26965 * expression.cs (Invocation.Emit): Remove previous hack, we should
26966 not do this on matching a base type, we should do this based on an attribute
26968 Only emit calls to System.Diagnostics.Debug and
26969 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26970 on the command line.
26972 * rootcontext.cs: Global settings for tracing and debugging.
26974 * cs-tokenizer.cs (define): New utility function to track
26975 defines. Set the global settings for TRACE and DEBUG if found.
26977 2002-05-25 Ravi Pratap <ravi@ximian.com>
26979 * interface.cs (Populate*): Pass in the TypeContainer as well as
26980 the DeclSpace as parameters so that we can create EmitContexts and
26981 then use that to apply attributes etc.
26983 (PopulateMethod, PopulateEvent, PopulateProperty)
26984 (PopulateIndexer): Apply attributes everywhere.
26986 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26989 (ApplyAttributes): Update accordingly.
26991 We now apply interface attributes for all members too.
26993 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26995 * class.cs (Indexer.Define); Correctly check if we are explicit
26996 implementation (instead of checking the Name for a ".", we
26997 directly look up if the InterfaceType was specified).
26999 Delay the creation of the PropertyBuilder.
27001 Only create the PropertyBuilder if we are not an explicit
27002 interface implementation. This means that explicit interface
27003 implementation members do not participate in regular function
27004 lookups, and hence fixes another major ambiguity problem in
27005 overload resolution (that was the visible effect).
27007 (DefineMethod): Return whether we are doing an interface
27010 * typemanager.cs: Temporary hack until we get attributes in
27011 interfaces (Ravi is working on that) and we get IndexerName
27012 support in interfaces.
27014 * interface.cs: Register the indexers as properties.
27016 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
27017 warning, I have verified that this is a bug in the .NET runtime
27018 (JavaScript suffers of the same problem).
27020 * typemanager.cs (MemberLookup): When looking up members for
27021 interfaces, the parent of an interface is the implicit
27022 System.Object (so we succeed in searches of Object methods in an
27023 interface method invocation. Example: IEnumerable x; x.ToString
27026 2002-05-25 Miguel de Icaza <miguel@ximian.com>
27028 * class.cs (Event): Events should also register if they do
27029 implement the methods that an interface requires.
27031 * typemanager.cs (MemberLookup); use the new GetInterfaces
27034 (GetInterfaces): The code used to lookup interfaces for a type is
27035 used in more than one place, factor it here.
27037 * driver.cs: Track the errors at the bottom of the file, we kept
27040 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
27041 instance if the method we are calling is static!
27043 2002-05-24 Miguel de Icaza <miguel@ximian.com>
27045 * attribute.cs (ApplyAttributes): Make this function filter out
27046 the IndexerName attribute (as that attribute in reality is never
27047 applied) and return the string constant for the IndexerName
27050 * class.cs (TypeContainer.Emit): Validate that all the indexers
27051 have the same IndexerName attribute, and if so, set the
27052 DefaultName attribute on the class.
27054 * typemanager.cs: The return value might contain other stuff (not
27055 only methods). For instance, consider a method with an "Item"
27056 property and an Item method.
27058 * class.cs: If there is a problem with the parameter types,
27061 2002-05-24 Ravi Pratap <ravi@ximian.com>
27063 * ecore.cs (ImplicitConversionExists): Wrapper function which also
27064 looks at user defined conversion after making a call to
27065 StandardConversionExists - we need this for overload resolution.
27067 * expression.cs : Update accordingly the various method calls.
27069 This fixes 2 bugs filed against implicit user defined conversions
27071 2002-05-22 Miguel de Icaza <miguel@ximian.com>
27073 * statement.cs: Track the result of the assignment.
27075 2002-05-21 Miguel de Icaza <miguel@ximian.com>
27077 * expression.cs (MemberAccess): Improved error reporting for
27078 inaccessible members.
27080 2002-05-22 Martin Baulig <martin@gnome.org>
27082 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
27083 itself with debugging support.
27085 2002-05-22 Martin Baulig <martin@gnome.org>
27087 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
27088 Removed, this isn't needed anymore.
27090 2002-05-20 Martin Baulig <martin@gnome.org>
27092 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
27093 be underlying type for an enum.
27095 2002-05-20 Miguel de Icaza <miguel@ximian.com>
27097 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
27098 that splits out the loading of just the core types.
27100 * rootcontext.cs (ResolveCore): Split the struct resolution in
27101 two, so we can load the enumeration underlying types before any
27104 * expression.cs (Is): Bandaid until we fix properly Switch (see
27105 bug #24985 for details).
27107 * typemanager.cs (ImplementsInterface): The hashtable will contain
27108 a null if there are no interfaces implemented.
27110 2002-05-18 Miguel de Icaza <miguel@ximian.com>
27112 * cs-parser.jay (indexer_declarator): It is fine to have array
27115 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27117 * typemanager.cs: (RegisterBuilder): New function used to register
27118 TypeBuilders that implement interfaces. Since
27119 TypeBuilder.GetInterfaces (as usual) does not work with lame
27121 (AddUserType): register interfaces.
27123 (ImplementsInterface): Use the builder_to_ifaces hash if we are
27124 dealing with TypeBuilder. Also, arrays are showing up as
27125 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
27126 methods can not be invoked on them!
27128 * ecore.cs (ExplicitReferenceConversionExists): Made public.
27129 (ImplicitReferenceConversionExists): Split out from
27130 StandardConversionExists.
27132 * expression.cs (As): We were only implementing one of the three
27133 cases for the as operator. We now implement them all.
27134 (Is): Implement the various other cases for Is as well.
27136 * typemanager.cs (CACHE): New define used to control if we want or
27137 not the FindMembers cache. Seems to have a negative impact on
27138 performance currently
27140 (MemberLookup): Nested types have full acess to
27141 enclosing type members
27143 Remove code that coped with instance/static returns for events, we
27144 now catch this in RealFindMembers.
27146 (RealFindMembers): only perform static lookup if the instance
27147 lookup did not return a type or an event.
27149 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27151 * assign.cs (CompoundAssign): We pass more semantic information
27152 now to Compound Assignments than we did before: now we have all
27153 the information at hand, and now we resolve the target *before* we
27154 do the expression expansion, which allows the "CacheValue" method
27155 to have the effect we intended (before, a [x] += 1 would generate
27156 two differen ArrayAccess expressions from the ElementAccess,
27157 during the resolution process).
27159 (CompoundAssign.DoResolve): Resolve target and original_source here.
27161 2002-05-16 Miguel de Icaza <miguel@ximian.com>
27163 * expression.cs (ArrayAccess): dropped debugging information.
27165 * typemanager.cs: Small bug fix: I was always returning i_members,
27166 instead of one of i_members or s_members (depending on which had
27169 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
27170 method is invoked before any code generation takes place, and it
27171 is a mechanism to inform that the expression will be invoked more
27172 than once, and that the method should use temporary values to
27173 avoid having side effects
27175 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
27177 * ecore.cs (Expression.CacheTemporaries): Provide empty default
27180 * expression.cs (Indirection, ArrayAccess): Add support for
27181 CacheTemporaries in these two bad boys.
27183 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
27184 ldobj or ldind_ref.
27185 (StoreFromPtr): Handle stobj as well.
27187 * expression.cs (UnaryMutator): Share more code.
27189 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
27190 down: I was not tracking the Filter function as well, which
27191 was affecting the results of the cache.
27193 2002-05-15 Miguel de Icaza <miguel@ximian.com>
27195 * attribute.cs: Remove the hack to handle the CharSet property on
27198 2002-05-14 Miguel de Icaza <miguel@ximian.com>
27200 * attribute.cs (DoResolve): More uglyness, we now only try to
27201 resolve the attribute partially, to extract the CharSet
27202 information (only if we are a StructLayout attribute). Otherwise
27204 (GetExtraTypeInfo): Add some code to conditionally kill in the
27205 future this. I am more and more convinced that the .NET
27206 framework has special code to handle the attribute setting on
27209 * expression.cs (IsParamsMethodApplicable): Revert my previous
27210 foreach change here, it was wrong.
27212 2002-05-13 Miguel de Icaza <miguel@ximian.com>
27214 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
27215 (pp_expr): do not abort on unknown input, just return.
27216 (eval): abort if there are pending chars.
27218 * attribute.cs (Attribute.Resolve): Positional parameters are
27219 optional. Deal with that case.
27221 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
27222 the Ansi/Unicode/Auto information for the type.
27224 (TypeContainer.DefineType): instantiate the EmitContext here, as
27225 we will be using it during the type definition (to resolve
27226 attributes) and during the emit phase.
27228 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
27229 to pull type information out of the attributes
27231 (Attribute.Resolve): track the constructor builder, and allow for
27232 multiple invocations (structs and classes will use this).
27234 * ecore.cs (MemberLookupFinal): new version with all the
27235 parameters customizable.
27237 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
27238 constructors. Return if the result value is null (as the error
27239 would have been flagged already by MemberLookupFinal)
27241 Do not allow instances of abstract classes or interfaces to be
27244 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
27245 We have to compare the assembly property here when dealing with
27246 FamANDAssem and Assembly access modifiers, because we might be
27247 creating an assembly from *modules* (that means that we are not
27248 getting TypeBuilders for types defined in other modules that are
27249 part of this assembly).
27251 (Method.Emit): If the method is marked abstract and has a body,
27254 (TypeContainer.DefineMembers): If both the defined member and the
27255 parent name match are methods, then do not emit any warnings: let
27256 the Method.Define routine take care of flagging warnings. But if
27257 there is a mismatch (method overrides something else, or method is
27258 overriwritten by something, then emit warning).
27260 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
27261 set to null, this means `do not check for the return type on the
27264 (Method.Define): set the return type for the method signature to
27265 null, so that we get methods with the same name and parameters and
27266 different return types. This is used to flag warning 114 (you are
27267 hiding a method, and you probably want to use the new/override
27270 * typemanager.cs (MemberLookup): Implemented proper access
27271 control, closing a long standing set of bug reports. The problem
27272 was that the Framework only has two bits: Public and NonPublic,
27273 and NonPublic includes private and protected methods, but we need
27274 to enforce the FamANDAssem, FamOrAssem and Family.
27276 2002-05-11 Miguel de Icaza <miguel@ximian.com>
27278 * statement.cs (GotoCase): Return true: Ammounts to giving up
27279 knowledge on whether we return or not, and letting the other case
27280 be responsible for it.
27282 2002-05-10 Miguel de Icaza <miguel@ximian.com>
27284 * driver.cs: Do not load directories for each file processed, only
27285 do it if there is a pattern.
27287 * ecore.cs: Report readonly assigns here as well, as we might have
27288 been resolved only by MemberAccess.
27290 (SimpleName.SimpleNameResolve): Also be useful for LValue
27291 resolution. We need this to propagate assign to local readonly variables
27293 * typemanager.cs: Use a ptrhashtable for the criteria, because we
27294 do not want to reuse potential criteria memory.
27296 * class.cs (MyEventBuilder): Set reflected_type;
27298 * ecore.cs (Constantify): Added support for constifying bools.
27300 (RootContext.LookupType): Added a cache for values looked up in
27301 the declaration space.
27303 * typemanager.cs (FindMembers): Now is a front-end to
27304 RealFindMembers, and provides a two-level hashtable-based cache to
27307 15% performance improvement: from 22.5 to 19.2 seconds.
27309 * expression.cs (IsParamsMethodApplicable): use foreach.
27310 (Invocation.DoResolve): ditto.
27311 (New.DoResolve): ditto.
27312 (ArrayCreation.DoResolve): ditto.
27314 * ecore.cs (FindMostEncompassingType): use foreach.
27316 * delegate.cs (NewDelegate.DoResolve): Use foreach
27318 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27319 (RemoveMethods): use foreach.
27321 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27322 nested foreach statements instead of for, and also break out of
27323 the inner loop once a match is found.
27325 (Invocation.OverloadResolve): Use foreach, simplify the code.
27327 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27329 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27330 we actually unwrap the expression to allow for extra information
27333 * expression.cs: Use Shr_Un on unsigned operations.
27335 2002-05-08 Ravi Pratap <ravi@ximian.com>
27337 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27338 applicable operators was not being considered correctly. This closes
27339 the bug Miguel reported.
27341 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27343 * attribute.cs: check that the type derives from System.Attribute
27344 and report the correct error in that case (moved the duplicate code to
27345 its own method, too).
27347 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27349 * attribute.cs: lookup attribute type name as the spec says: first the
27350 bare attribute name and then name + "Attribute" (nant compiles with
27351 mcs after this fix).
27353 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27355 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27356 Because of the way we parse things, we should try to see if a
27357 UIntConstant can fit in an integer.
27359 2002-05-07 Ravi Pratap <ravi@ximian.com>
27361 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27362 when we are in an explicit context.
27364 (ConvertReferenceExplicit): When converting from Iface type S to Class
27365 T make sure the rules are implemented as an OR.
27367 * parameter.cs (ParameterType): Make it a property for now although the
27368 purpose really isn't anything immediate.
27370 * expression.cs (Is*Applicable): Do better checking on the parameter type
27371 of a ref/out parameter. The ones from the system assemblies are already
27372 marked with the correct type so we don't need to do any correction.
27374 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27375 the object type is standard too so include that.
27377 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27379 * ecore.cs (StandardConversionExists): Augment with missing code:
27380 deal with IntConstant, LongConstants and Enumerations.
27382 * assign.cs: Report the error, instead of failing silently
27384 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27385 typecontainer that they are declared, because the
27386 typecontainer/namespace will have the list of using clauses that
27387 need to be applied.
27389 Assembly Attributes were escaping the normal registration
27392 (EmitCode): Apply attributes within an EmitContext that represents
27393 the container they were declared on.
27395 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27397 2002-05-06 Ravi Pratap <ravi@ximian.com>
27399 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27400 Revamp completely - make much cleaner as we now operate only
27403 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27404 to implement the logic detailed in the spec more correctly.
27406 (UserDefinedConversion): Update accordingly.
27408 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27410 * statement.cs: Return flow analysis information up.
27412 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27415 (token): Do not consume an extra character before calling
27418 2002-05-06 Piers Haken <piersh@friskit.com>
27420 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27422 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27424 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27425 EmitContext during the instance constructor initializer
27426 resolution, to stop access to instance variables.
27428 This is mandated by the spec, last paragraph of the `constructor
27429 initializers' section.
27431 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27433 * cs-parser.jay, class.cs (Accessor): new class used to represent
27434 an accessor (get or set). In the past we used `null' to represent
27435 a missing accessor. But this is ambiguous because there was no
27436 way to tell in abstract indexers/properties if one of them was
27439 Now there is a way of addressing that.
27441 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27442 instead of FindMembers.
27444 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27445 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27447 * attribute.cs: Treat indexers and properties as the same in terms
27448 of applying attributes
27450 * ecore.cs (FindMostEncompassedType): Use statically initialized
27451 EmptyExpressions()s like we do elsewhere to avoid creating useless
27452 objects (and we take this out of the tight loop).
27454 (GetConversionOperators): Move the code to extract the actual
27455 operators to a separate routine to clean things up.
27457 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27459 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27460 events are always registered FieldBuilders.
27462 * class.cs (FieldBase): New class shared by Fields
27464 * delegate.cs: If we are a toplevel delegate, use our full name.
27465 If we are a nested delegate, then only use our tail name.
27467 2002-05-02 Ravi Pratap <ravi@ximian.com>
27469 * expression.cs (IsApplicable): Ensure that we add the "&" to
27470 ref/out types before comparing it with the type of the argument.
27472 (IsParamsMethodApplicable): Ditto.
27474 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27477 * delegate.cs : Handle the case when we have more than one applicable
27478 method. Flag an error only when we finish checking all.
27480 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27482 * expression.cs: Add support for boolean static initializers.
27484 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27486 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27488 * parameter.cs (ComputeParameterTypes,
27489 ComputeAndDefineParameterTypes): Better error handling: now we
27490 clear the `types' cache if we fail during any of the type lookups.
27491 We also return the status code correctly to our caller
27493 * delegate.cs: If we fail to define a delegate, abort the extra
27496 * expression.cs (Binary.ResolveOperator): for
27497 operator==(object,object) and operator !=(object, object) we also
27498 have to verify that there is an implicit conversion from one to
27501 (ArrayAccess.DoResolve): Array Access can operate on
27504 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27506 * assign.cs (CompoundAssign): A new class used as a "flag" that
27507 the assignment actually is happening as part of a compound
27508 assignment operator.
27510 During compound assignment, a few new rules exist to enable things
27517 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27518 to the type of x) if y is implicitly convertible to the type of x,
27519 and the operator is a builtin operator and the return type of the
27520 operator is explicitly convertible to the type of x.
27522 * rootcontext.cs: Reset warning level to 2. 4 catches various
27523 "interesting" features in mcs, we must clean this up at some
27524 point, but currently am trying to kill other bugs ;-)
27526 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27527 in container classes as well.
27529 * expression.cs (Binary.ResolveOperator): Handle string case
27530 before anything else (as operator overloading does emit an error
27531 before doing anything else).
27533 This code could go away when we move to a table driven model, but
27534 i could not come up with a good plan last night.
27536 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27538 * typemanager.cs (CSharpName): reimplementation using regex.
27539 * class.cs: added null check for fields in Emit
27540 * rootcontext.cs: set warninglevel to 4
27542 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27544 * typemanager.cs (CSharpName): reimplemented with Lupus
27547 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27549 * statement.cs (If): correclty implement Resolve, because we were
27550 not catching sem errors in there. The same process is needed
27552 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27555 (Statement.Warning_DeadCodeFound): Factorize code.
27556 (While): Report dead code here too.
27558 (Statement): Added Resolve virtual method to allow
27559 for resolution split from the emit code.
27561 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27563 * statement.cs (EmitBoolExpression): No longer try to resolve the
27565 (MakeBoolean): New utility function that resolve, implicitly
27566 converts to boolean and tags the expression.
27569 (If, Do): Implement dead code elimination.
27570 (While): Implement loop inversion
27572 (Do, While, For, If): Resolve the expression prior to calling our
27575 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27578 - added method Report28 (warning: program has more than one entry point)
27579 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27580 - modified method Method.Define, the part at the end of the method
27582 * rootcontext.cs: added static public Location EntryPointLocation;
27584 * ../errors/cs0028.cs : Add test case for the above warning.
27587 - modified method CSharpName to allow arrays of primitive type to
27588 be printed nicely (e.g. instead of System.Int32[][] it now prints
27590 - added method CSharpSignature: returns the signature of a method
27591 in string format to be used in reporting errors, warnings, etc.
27593 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27596 2002-04-26 Ravi Pratap <ravi@ximian.com>
27598 * delegate.cs (Define): Fix extremely silly bug where I was
27599 setting the type of the 'object' parameter of the BeginInvoke
27600 method to System.IAsyncResult instead of System.Object ;-)
27602 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27604 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27607 (Constructor.Emit): return if we fail to initialize the
27608 constructor. Another door closed!
27610 * expression.cs (New.DoResolve): Improve error message (from -6 to
27611 1501). Use DeclaredOnly lookup to find the exact constructor.
27613 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27614 loop. This is useful.
27616 * cs-parser.jay: Adjust the default parameters so that destructors
27617 have the proper signature.
27619 2002-04-26 Martin Baulig <martin@gnome.org>
27621 * driver.cs (LoadAssembly): If `assembly' contains any characters
27622 which are only valid in path names and not in assembly names
27623 (currently slash, backslash and point), use Assembly.LoadFrom ()
27624 instead of Assembly.Load () on the `assembly' (before iteration
27625 over the link_paths).
27627 2002-04-26 Martin Baulig <martin@gnome.org>
27629 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27631 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27633 * class.cs (Property): use the new typemanager.MemberLookup
27635 (TypeContainer.MemberLookup): Implement using the
27636 TypeManager.MemberLookup now.
27638 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27639 and return MemberInfos, so that these can be used without an
27640 EmitContext (what we had before).
27642 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27644 * expression.cs: Fix the case where the argument to params if the
27645 type of the params. I omitted handling this before. Fixed
27647 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27649 * driver.cs: Call BootCorlib_PopulateCoreType
27651 * class.cs (Property.CheckBase): Check for properties only, not
27654 * interface.cs: Temporary hack: try/catch around the
27655 CustomAttributeBuilder, because I am getting an exception that I
27658 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27659 types whose definitions are required to be there (attributes are
27660 defined before standard types).
27662 Compute definitions as we boot the various types, as they are used
27663 immediately (value_type class will need object_type, but if we do
27664 not initialize object_type, we will pass a null, which will let
27665 the runtime pick the System.Object from the existing corlib, which
27666 is not what we want).
27668 2002-04-22 Patrik Torstensson <totte@labs2.com>
27670 * cs-tokenizer.cs: fixed a number of trim() issues.
27672 2002-04-22 Ravi Pratap <ravi@ximian.com>
27674 * expression.cs (Argument.Type): Ensure that we return the correct
27675 type when we have out or ref parameters [in which case we
27678 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27680 * class.cs (Property, Indexer): Allow extern modifier in there.
27682 * typemanager.cs (InitBaseTypes): Initializes object_type and
27683 value_type, since those will be used early on during the bootstrap
27684 process to compile corlib.
27686 (InitCoreTypes): Move code from here to InitBaseTypes.
27688 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27690 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27691 single-dimension arrays as using the ldlen opcode.
27693 Daniel Lewis discovered this optimization.
27695 * typemanager.cs: Add signature for System.Array::get_Length
27697 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27699 * statement.cs: report the error when the foreach does not apply to an
27700 array nor a collection.
27702 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27704 * expression.cs: Add implicit conversions to the operator ~.
27706 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27708 * typemanager.cs: Locate the decimal constructor.
27710 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27712 * attribute.cs: use the new property of TypeOf.
27713 * expression.cs: added 'get' property around typearg.
27715 These changes fix a build breaker reported by NickD. Is this the
27716 correct way to fix? If not, please, revert my changes and make it
27719 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27721 * attribute.cs: Add support for typeof in attribute invocations.
27722 I am not sure that this is right though.
27724 2002-04-14 Duncan Mak <duncan@ximian.com>
27726 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27727 Binary.Operator.Division case.
27729 2002-04-13 Ravi Pratap <ravi@ximian.com>
27731 * class.cs (DefineType): Ensure that we do a proper check on
27732 attribute types and also register it with the TypeManager.
27734 (TypeContainer.Targets): The default for attribute types is
27735 AttributeTargets.All.
27737 * attribute.cs (ApplyAttributes): Registering the attribute type
27738 is done elsewhere, not when we discover we have a Usage attribute.
27740 2002-04-12 Ravi Pratap <ravi@ximian.com>
27742 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27743 and get rid of is_delegate parameter.
27745 * everywhere : update.
27747 2002-04-12 Ravi Pratap <ravi@ximian.com>
27749 * cs-parser.jay (compilation_unit): Revamp completely to use
27750 some new ideas that I got from Rhys' grammar to solve the problems
27751 with assembly level attributes.
27753 (outer_declaration): New grammar production.
27755 (attribute_sections): Add.
27757 (opt_attributes): Base on attribute_sections
27759 (namespace_declaration): Allow opt_attributes to tackle the case
27760 when we have assembly level attributes - we are clever in this
27763 * attribute.cs (ApplyAttributes): Do not worry about assembly
27764 attributes in the non-global context.
27766 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27767 instead of SetGlobalAttributes.
27769 * class.cs, rootcontext.cs : Ensure we define and generate
27770 attribute types before anything else.
27772 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27773 and flag the new error -20 for the case when the attribute type
27774 does not have valid targets specified. csc does not catch this.
27776 * ../errors/errors.txt : update for error # -20
27778 2002-04-11 Ravi Pratap <ravi@ximian.com>
27780 * support.cs (InternalParameters.ParameterModifier): Do some null
27781 checking and return sane values.
27783 * class.cs (Method.Define): If we are a PInvoke method, ensure
27784 that we are static and extern. Report error # 601
27786 * ../errors/cs0601.cs : Add test case for the above error.
27788 2002-04-07 Ravi Pratap <ravi@ximian.com>
27790 * rootcontext.cs (attribute_types): We need to keep type of
27791 all attribute types separately and emit code for them first.
27793 (RegisterAttribute) : Implement.
27795 * class.cs (DefineType): Check if the current Type is a custom
27796 attribute type and register it accordingly.
27798 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27799 adding the first attribute twice and rename to
27801 (SetGlobalAttributes): this.
27803 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27806 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27807 if we are processing global arguments. Hmm, I am unsure of this.
27809 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27811 * expression.cs: added static array of strings to avoid calling
27812 Enum.ToString () for Operator in Binary. Significant recover of
27815 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27817 * class.cs (FindMembers): Allow the Builders of the various
27818 members to be null. If they are skip them. This only happens
27819 during the PInvoke declaration.
27821 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27823 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27824 failure, so we do not keep going afterwards.
27826 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27827 wanted to pass `false' as the `is_delegate' argument. If this is
27828 the case, why not use delegate_type == null to mean `is_delegate =
27829 false' and anything else as is_delegate = true.
27831 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27833 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27834 code for the section, not the beginning of the tests.
27836 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27838 * cfold.cs: Handle operator + (Enum x, Underlying x)
27840 * expression.cs (Binary): same. Warn about errors where we have
27841 Enum/Enum in operator + as well.
27843 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27846 - added support for switch(bool)
27847 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27848 - add TableSwitchEmit() to handle table-based switch statements
27850 2002-04-05 Ravi Pratap <ravi@ximian.com>
27852 * expression.cs (Invocation.OverloadResolve): Factor out code which
27853 does parameter compatibility checking with arguments so that we can
27854 re-use the code even from Delegate.VerifyApplicability
27856 (VerifyArgumentsCompat): Move above code here.
27858 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27859 and instead make a call to the above method.
27861 2002-03-31 Ravi Pratap <ravi@ximian.com>
27863 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27864 We use it to keep track of classes which are attribute types.
27866 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27868 * delegate.cs (Delegate.Define): Correctly define the types in the
27869 presence of fixed and array parameters.
27871 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27874 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27875 include NonPublic after the first iteration.
27877 * class.cs (Indexer.CheckBase): Only check if both parents are
27880 * cs-parser.jay (accessor_body): If empty, set to null.
27882 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27883 same code path here to resolve constants names that we did have in
27884 MemberAccess.DoResolve. There is too much code duplicated here.
27886 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27888 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27890 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27893 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27894 tokens, numbers and strings.
27896 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27899 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27900 asyncronous parameters and the regular parameters.
27902 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27903 specify the target directory.
27905 * expression.cs: (This.DoResolve): Simplify
27906 (As.Emit): Optimize, do not generate IsInst if the expression is
27907 always of the given type.
27909 (Is.DoResolve): Bug fix, we were reporting both always/never for
27912 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27913 creating too many unnecessary arrays.
27915 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27917 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27918 fields instead of rolling our own initializer. Takes care of all
27919 implicit conversions, and drops unnecessary static checks/argument.
27921 2002-03-31 Dick Porter <dick@ximian.com>
27923 * driver.cs: use the GetDirectories() return values properly, and
27924 use "/" as path separator.
27926 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27928 * expression.cs (Unary): Optimize - - expr into expr.
27929 (Binary): Optimize a + (-b) into a -b.
27931 * codegen.cs (CodeGen): Made all methods static.
27933 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27937 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27938 TypeBuilder property.
27940 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27943 * tree.cs: Removed the various RecordXXXX, and replaced with a
27944 single RecordDecl. Removed all the accessor methods, and just
27945 left a single access point Type
27947 * enum.cs: Rename DefineEnum to DefineType.
27949 * decl.cs: New abstract method `DefineType' used to unify the
27950 Defines for Enumerations, Interfaces, TypeContainers and
27953 (FindType): Moved LookupInterfaceOrClass here. Moved the
27954 LookupBaseClasses method that used to live in class.cs and
27955 interface.cs here, and renamed to FindType.
27957 * delegate.cs: Implement DefineType. Take advantage of the
27958 refactored pattern for locating the parent builder without taking
27959 the parent_builder argument (which we know does not work if we are
27960 nested, and triggering a toplevel definition).
27962 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27964 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27965 accessibility of a member has changed during override and report
27968 * class.cs (Method.Define, Property.Define): Only complain on
27969 overrides if the method is private, any other accessibility is
27970 fine (and since we just checked the permission is the same, we are
27973 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27974 and elif are processed always. The other pre-processing
27975 directives are only processed if we are "taking" the path
27977 2002-03-29 Martin Baulig <martin@gnome.org>
27979 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27980 current location is not Null.
27982 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27983 a separate method so we can profile it.
27985 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27986 `span.Seconds' are just seconds, but no minutes or hours.
27987 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27989 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27991 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27992 Remove the gratuitous set of Final:
27994 // If an interface implementation, then we can set Final.
27995 if (((flags & MethodAttributes.Abstract) == 0) &&
27996 implementing.DeclaringType.IsInterface)
27997 flags |= MethodAttributes.Final;
27999 I do not know what I was smoking when I used that.
28002 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
28003 step into fixing the name resolution issues for delegates and
28004 unifying the toplevel name resolution.
28006 2002-03-28 Martin Baulig <martin@gnome.org>
28008 * class.cs (Method.Emit): If we have a symbol writer, call its
28009 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
28010 tell it about the current method.
28012 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
28013 writer that we're going to emit the first byte of IL code for a new
28014 statement (a new source line).
28015 (EmitContext.EmitTopBlock): If we have a symbol writer, call
28016 EmitContext.Mark() before emitting any code.
28018 * location.cs (SymbolDocument): Return null when we're Null.
28020 * statement.cs (Statement): Moved the `Location loc' variable here.
28021 (Statement.EmitBoolExpression): If we have a symbol writer, call
28022 ec.Mark() before emitting any code to tell it that we're at the
28023 beginning of a new statement.
28024 (StatementExpression): Added `Location' argument to the constructor.
28025 (Block): Added public readonly variable `StartLocation' and public
28026 variable `EndLocation'. The latter is to be set using SetEndLocation().
28027 (Block): Added constructor which takes a start and end location.
28028 (Block.SetEndLocation): New method. This sets the end location.
28029 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
28030 local variables we create.
28031 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
28032 each statement and do also mark the begin and end of the block.
28034 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
28035 tell it the current lexer.Location, use Location.Null for the end of the
28037 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
28038 current block, set its end location using SetEndLocation().
28039 (statement_expression): StatementExpression constructor now takes the
28040 lexer.Location as additional argument.
28041 (for_statement, declare_local_variables): Likewise.
28042 (declare_local_variables): When creating a new implicit block, use the
28043 new Block constructor and pass it the lexer.Location.
28045 2002-03-28 Miguel de Icaza <miguel@ximian.com>
28047 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
28048 members also on the parent interfaces recursively.
28050 2002-03-27 Miguel de Icaza <miguel@ximian.com>
28052 * report.cs: Use new formats, since Gonzalo finished the missing
28055 * expression.cs (Binary.ResolveOperator): added missing operator|
28056 operator& and operator^ for bool/bool.
28058 * cs-parser.jay: CheckDef now takes a Location argument that is
28059 used to report errors more precisly (instead of reporting the end
28060 of a definition, we try to track something which is a lot closer
28061 to the source of the problem).
28063 * cs-tokenizer.cs: Track global token use, so we can properly flag
28064 the use of #define/#undef after the first token has been seen.
28066 Also, rename the reportXXXX to Error_DescriptiveName
28068 * decl.cs (DeclSpace.IsTopLevel): Move property here from
28069 TypeContainer, so that Enum and Interface can use this too.
28071 * class.cs (TypeContainer.LookupInterfaceOrClass,
28072 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
28073 `builder' argument. Typically this was used to pass the parent
28074 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
28077 The problem is that a nested class could trigger the definition of
28078 a toplevel class, and the builder would be obviously wrong in that
28081 So we drop this argument, and we compute dynamically the
28082 TypeBuilder/ModuleBuilder (the correct information was available
28083 to us anyways from DeclSpace.Parent)
28085 * interface.cs (Interface.DefineInterface): Drop builder
28086 parameter cleanup like class.cs
28088 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
28091 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
28094 (Try.Emit): Propagate the returns value from the statement.
28096 (Return.Emit): Even if we are leavning
28098 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
28100 * modifiers.cs: Fix the computation of MethodAttributes flags.
28102 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
28104 * driver.cs: allow compilation of files that start with '/'.
28105 Add a default case when checking the argument of --target.
28107 2002-03-25 Miguel de Icaza <miguel@ximian.com>
28109 * interface.cs: Implement the same search algorithm for types in
28110 the interface code.
28112 * delegate.cs: Do not allow multiple definition.
28114 * Recovered ChangeLog that got accidentally amputated
28116 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
28118 * rootcontext.cs: Load manually enum to allow core classes to
28119 contain enumerations.
28121 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
28122 Update to new static methods in TypeManager.
28124 * typemanager.cs (GetMethod, GetConstructor): Use our
28125 implementation of FindMembers to find the members, since during
28126 corlib compilation, the types are TypeBuilders and GetMethod and
28127 GetConstructor do not work.
28129 Make all methods in TypeManager static.
28131 (InitCodeHelpers): Split the functionality from
28132 the InitCodeTypes function.
28134 * driver.cs: Call InitCodeHelpers after we have populated the
28137 * cs-parser.jay (delegate_declaration): we did not used to compute
28138 the delegate name correctly for void delegates.
28140 2002-03-24 Miguel de Icaza <miguel@ximian.com>
28142 * rootcontext.cs (RootContext): Init the interface_resolve_order
28143 and type_container_resolve_order always.
28145 (ResolveCore, BootstrapCorlib_ResolveClass,
28146 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
28147 compiler when compiling with --nostdlib
28149 * class.cs (TypeContainer.DefineType): Check that our parent is
28150 not null. This test is most important when we are bootstraping
28153 * codegen.cs: Split out the symbol writing code.
28155 2002-03-25 Martin Baulig <martin@gnome.org>
28157 * driver.cs (-g): Made -g an alias for --debug.
28159 2002-03-24 Martin Baulig <martin@gnome.org>
28161 * codegen.cs (SymbolWriter): New public variable. Returns the
28162 current symbol writer.
28163 (CodeGen): Added `bool want_debugging_support' argument to the
28164 constructor. If true, tell the ModuleBuild that we want debugging
28165 support and ask it for the ISymbolWriter.
28166 (Save): If we have a symbol writer, call it's Close() method after
28167 saving the assembly.
28169 * driver.c (--debug): New command line argument to create a
28170 debugger information file.
28172 * location.cs (SymbolDocument): New public property. Returns an
28173 ISymbolDocumentWriter object for the current source file or null
28174 if we don't have a symbol writer.
28176 2002-03-21 Miguel de Icaza <miguel@ximian.com>
28178 * driver.cs (LoadAssembly): Correctly return when all the paths
28179 have been tried and not before.
28181 * statement.cs (Switch.Emit): return the actual coverage for this
28182 statement (returns/not-returns)
28184 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
28185 switch of the statement if we are the last switch section. That
28186 kills two problems: try/catch problems (we used to emit an empty
28187 nop at the end) and switch statements where all branches would
28190 2002-03-19 Miguel de Icaza <miguel@ximian.com>
28192 * driver.cs: Add default assemblies (the equivalent to the
28193 Microsoft CSC.RSP file)
28195 * cs-tokenizer.cs: When updating `cols and setting it to zero,
28196 also update tokens_seen and set it to false.
28198 * driver.cs: Implement --recurse for Mike.
28200 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
28201 correctly splitting out the paths.
28203 2002-03-18 Miguel de Icaza <miguel@ximian.com>
28205 * interface.cs (Interface.PopulateProperty): Instead of using
28206 `parent' as the declaration space for the set parameters, use
28209 * support.cs (InternalParameters): InternalParameters constructor
28210 takes a DeclSpace instead of a TypeContainer.
28212 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
28213 types are being initialized, load the address of it before calling
28216 (New): Provide a mechanism to disable the generation of local
28217 value type temporaries when the caller will be providing us with
28218 an address to store it.
28220 (ArrayCreation.EmitDynamicInitializers): Use it.
28222 2002-03-17 Miguel de Icaza <miguel@ximian.com>
28224 * expression.cs (Invocation.EmitArguments): Only probe for array
28225 property if there is more than one argument. Sorry about that.
28227 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
28228 empty param arrays.
28230 * class.cs (Method.LabelParameters): Fix incorrect code path that
28231 prevented the `ParamArrayAttribute' from being applied to the
28234 2002-03-16 Miguel de Icaza <miguel@ximian.com>
28236 * support.cs (ReflectionParameters): Correctly compute whether the
28237 last argument is a params array. Fixes the problem with
28240 * typemanager.cs: Make the assemblies array always be non-null
28241 (empty, but non-null)
28243 * tree.cs (RecordDecl): New function that abstracts the recording
28244 of names. This reports error 101, and provides a pointer to the
28245 previous declaration. Fixes a crash in the compiler.
28247 * cs-parser.jay (constructor_declaration): Update to new grammar,
28248 and provide a constructor_body that can be empty.
28250 2002-03-15 Miguel de Icaza <miguel@ximian.com>
28252 * driver.cs: Add support for --resources.
28254 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
28255 Make all types for the various array helper methods be integer.
28257 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
28258 CheckState to ConvCast.
28260 (ConvCast): Now it takes a `checked' state argument, to avoid
28261 depending on the emit context for the conversion, and just using
28262 the resolve time setting.
28264 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
28265 instead of Invocation.EmitArguments. We do not emit the original
28266 arguments, instead we emit those which have been converted to
28267 unsigned int expressions.
28269 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
28271 * codegen.cs: ditto.
28273 * expression.cs (LocalVariableReference): Drop the use of the
28274 Store function that depended on the variable index.
28276 * statement.cs (VariableInfo): Drop the `Idx' property from this
28277 class, as this is not taking into account the indexes for
28278 temporaries tat we generate during the execution, getting the
28281 * class.cs: First emit class initializers, then call the parent
28284 * expression.cs (Binary): Fix opcode emision.
28285 (UnaryMutator.EmitCode): Support checked code generation
28287 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
28288 matches for events for both the Static and Instance scans,
28289 pointing to the same element. Fix that.
28291 2002-03-14 Miguel de Icaza <miguel@ximian.com>
28293 * rootcontext.cs (ResolveTree): Always set the
28294 interface_resolve_order, because nested interfaces will be calling
28297 * class.cs (GetInterfaceOrClass): Track the same resolution
28298 process used by TypeManager.LookupType. This fixes the nested
28299 type lookups in class declarations (separate path from
28302 (TypeContainer.DefineType): Also define nested interfaces.
28303 (TypeContainer.RegisterOrder): New public function used to
28304 register the order in which child interfaces need to be closed.
28306 Nested interfaces need to be closed after their parents have been
28309 * interface.cs (InterfaceAttr): Put all the logic for computing
28310 the interface attribute here.
28312 (DefineInterface): Register our interface order with the
28313 RootContext or with the TypeContainer depending on the case.
28315 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28317 * cs-parser.jay: rework foreach statement to work with the new
28318 changes to the policy on SimpleNames.
28320 * report.cs: support Stacktrace on warnings as well.
28322 * makefile: drop --unsafe and /unsafe from the compile.
28324 2002-03-13 Ravi Pratap <ravi@ximian.com>
28326 * ecore.cs (StandardConversionExists): Modify to take an Expression
28327 as the first parameter. Ensure we do null -> reference type conversion
28330 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28331 temporary Expression objects.
28333 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28335 * interface.cs: workaround bug in method overloading resolution
28336 (there is already a bugzilla bug for it).
28338 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28340 We could also solve this problem by having a separate path for
28341 performing type lookups, instead of DoResolve, we could have a
28342 ResolveType entry point, and only participating pieces of the
28343 production (simplename, deref, array) would implement this.
28345 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28346 signal SimpleName to only resolve type names and not attempt to
28347 resolve anything else.
28349 * expression.cs (Cast): Set the flag.
28351 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28353 * class.cs: Only report 108 if there is no `new' modifier.
28355 * cs-parser.jay: rework foreach statement to work with the new
28356 changes to the policy on SimpleNames.
28358 * report.cs: support Stacktrace on warnings as well.
28360 * makefile: drop --unsafe and /unsafe from the compile.
28362 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28364 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28365 lookups here, instead of doing that at parse time. This means
28366 that our grammar will not introduce `LocalVariableReferences' as
28367 expressions at this point. That solves the problem of code like
28371 static void Main ()
28375 This is only half the fix. The full fix requires parameters to
28376 also be handled in this way.
28378 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28379 makes the use more obvious of the DeclSpace. The
28380 ec.TypeContainer.TypeBuilder is now only used to pull the
28381 TypeBuilder for it.
28383 My theory is that I can get rid of the TypeBuilder completely from
28384 the EmitContext, and have typecasts where it is used (from
28385 DeclSpace to where it matters).
28387 The only pending problem is that the code that implements Aliases
28388 is on TypeContainer, and probably should go in DeclSpace.
28390 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28391 lookups here, instead of doing that at parse time. This means
28392 that our grammar will not introduce `LocalVariableReferences' as
28393 expressions at this point. That solves the problem of code like
28397 static void Main ()
28401 This is only half the fix. The full fix requires parameters to
28402 also be handled in this way.
28404 * class.cs (Property.DefineMethod): When implementing an interface
28405 method, set newslot, when implementing an abstract method, do not
28406 set the flag (before we tried never setting it, or always setting
28407 it, which is the difference).
28408 (Indexer.DefineMethod): same.
28409 (Method.DefineMethod): same.
28411 * ecore.cs: Only set the status used flag if we get back a Field.
28413 * attribute.cs: Temporary hack, so Paolo can keep working.
28415 2002-03-08 Ravi Pratap <ravi@ximian.com>
28417 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28418 the unmanaged type in the case we have a MarshalAs attribute.
28420 (Resolve): Handle the case when we are parsing the special MarshalAs
28421 attribute [we need to store the unmanaged type to use later]
28423 * typemanager.cs (marshal_as_attr_type): Built in type for the
28424 MarshalAs Attribute.
28426 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28427 on parameters and accordingly set the marshalling info.
28429 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28431 * class.cs: Optimizing slightly by removing redundant code after
28432 we switched to the `NoTypes' return value.
28433 (Property.DefineMethod): use NoTypes here too.
28435 This fixes the bug I introduced in my last batch of changes.
28437 2002-03-05 Ravi Pratap <ravi@ximian.com>
28439 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28441 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28442 Enums since those are types too.
28444 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28446 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28447 thanks to a call during the lookup process.
28449 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28451 * statement.cs (Foreach): Lots of work to accomodate a particular
28452 kind of foreach statement that I had not kept in mind. It is
28453 possible to have foreachs on classes that provide a GetEnumerator
28454 method that return objects that implement the "pattern" for using
28455 a foreach, there is no need to support GetEnumerator
28458 This is needed to compile nant.
28460 * decl.cs: Only report 114 if the member is not `Finalize' and if
28461 the warning level is at least 2.
28463 * class.cs: Moved the compare function from Method to
28466 (MethodSignature.InheritableMemberSignatureCompare): Add new
28467 filter function that is used to extract inheritable methods from a
28470 (Method.Define): Use the new `inheritable_method_signature_filter'
28473 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28476 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28478 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28480 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28482 * expression.cs: Pass location information to
28483 ConvertImplicitStandard.
28485 * class.cs: Added debugging code to track return values from
28488 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28490 * expression.cs (Is.DoResolve): If either side of the `is' is an
28491 interface, do not flag the warning.
28493 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28496 * report.cs: Allow for --fatal to be used with --probe.
28498 * typemanager.cs (NoTypes): Move the definition for the empty Type
28501 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28503 (TypeContainer.DefineProxy): New function used to proxy to parent
28504 implementations when implementing interfaces.
28505 (TypeContainer.ParentImplements): used to lookup if our parent
28506 implements a public function that is required by an interface.
28507 (TypeContainer.VerifyPendingMethods): Hook this up.
28509 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28510 `modules' and `assemblies' arraylists into arrays. We only grow
28511 these are the very early start up of the program, so this improves
28512 the speedof LookupType (nicely measured).
28514 * expression.cs (MakeByteBlob): Replaced unsafe code with
28515 BitConverter, as suggested by Paolo.
28517 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28518 folding of string concatenation, but if either side is a string,
28519 and the other is not, then return null, and let the runtime use
28520 the concatenation on the string plus the object (using
28521 `Object.ToString').
28523 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28525 Constant Folding has been implemented now.
28527 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28528 the error instead on types that are not supported in one's
28531 * constant.cs (Constant and all children): New set of functions to
28532 perform implict and explicit conversions.
28534 * ecore.cs (EnumConstant): Implement the new functions to perform
28535 conversion by proxying to the child expression.
28537 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28538 own separate setting that can not be turned off from the command
28539 line using --unchecked or --checked and is only controlled using
28540 the checked/unchecked statements and expressions. This setting is
28541 used by the constant folder to flag errors.
28543 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28544 ConstantCheckState as well.
28546 During Resolve, they also have to flag the state, because the
28547 constant folder runs completely in the Resolve phase.
28549 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28552 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28554 * cfold.cs: New file, this file contains the constant folder.
28556 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28557 argument to track whether we are using the resulting address to
28558 load or store a value and provide better error messages.
28560 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28561 new AddressOf arguments.
28563 * statement.cs (Foreach.EmitCollectionForeach): Update
28565 * expression.cs (Argument.Emit): Call AddressOf with proper
28566 arguments to track usage.
28568 (New.DoEmit): Call AddressOf with new arguments.
28570 (Unary.Emit): Adjust AddressOf call.
28572 2002-03-01 Ravi Pratap <ravi@ximian.com>
28574 * cs-parser.jay (member_access): Change the case for pre-defined types
28575 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28578 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28581 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28582 essentially like methods and apply attributes like MethodImplOptions to them too.
28584 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28587 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28588 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28591 * Update code everywhere accordingly.
28593 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28595 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28597 2002-02-28 Ravi Pratap <ravi@ximian.com>
28599 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28600 try performing lookups against those instead of jumping straight into using
28601 the 'using' clauses.
28603 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28605 (LookupType): Perform lookups in implicit parents too.
28607 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28608 sequence as RootContext.LookupType.
28610 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28611 the various cases of namespace lookups into this method.
28613 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28615 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28616 in positional arguments)
28618 * class.cs (Operator): Update the AllowedModifiers to contain
28621 * cs-parser.jay: Update operator declaration to allow for the
28622 operator body to be empty.
28624 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28627 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28629 * class.cs (Method.Emit): Label parameters.
28631 * driver.cs: Return 1 or 0 as the program exit code.
28633 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28635 * expression.cs: Special case the `null' object when trying to
28636 auto-compute the type, as anything can be explicitly converted to
28639 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28640 spotting this Paolo.
28642 (Expression.ImplicitNumericConversion): Perform comparissions of
28643 the type using the underlying type in the case of an enumeration
28644 rather than using the enumeration type for the compare.
28646 Cope with the underlying == type case, which is not possible to
28649 (Expression.ConvertNumericExplicit): Perform comparissions of
28650 the type using the underlying type in the case of an enumeration
28651 rather than using the enumeration type for the compare.
28653 * driver.cs: If the user does not supply an extension, assume .exe
28655 * cs-parser.jay (if_statement): Rewrote so that we can track the
28656 location for the if statement.
28658 * expression.cs (Binary.ConstantFold): Only concat strings when
28659 the operation is "+", not everything ;-)
28661 * statement.cs (Statement.EmitBoolExpression): Take a location
28663 (If, While, Do): Track location.
28665 * expression.cs (Binary.ResolveOperator): In the object + string
28666 case, I was missing a call to ConvertImplicit
28668 2002-02-25 Ravi Pratap <ravi@ximian.com>
28670 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28671 Location arguments. Ensure we use RootContext.LookupType to do our work
28672 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28674 * interface.cs (PopulateMethod): Handle the type of the parameter being
28677 * expression.cs (Invocation.BetterFunction): Handle the case when we
28678 have a params method with no fixed arguments and a call is made with no
28681 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28683 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28684 the verbatim-string-literal
28686 * support.cs (InternalParameters.ParameterModifier): handle null
28688 (InternalParameters.ParameterType): ditto.
28690 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28691 duplicating the name of the variable parameter.
28692 (GetParameterByName): Fix bug where we were not looking up array
28693 paramters if they were the only present (thanks Paolo!).
28694 (GetParameterInfo): We only have an empty set of types if both
28695 fixed and array are set to null.
28696 (GetParameterInfo-idx): Handle FixedParameter == null
28698 * cs-parser.jay: Handle the case where there is no catch
28699 statements (missing null test).
28701 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28703 * driver.cs (MainDriver): Be conservative on our command line
28706 Catch DirectoryNotFoundException when calling GetFiles.
28708 (SplitPathAndPattern): Used to split the input specification into
28709 a path and a pattern that we can feed to Directory.GetFiles.
28711 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28713 * statement.cs (Fixed): Implement the last case of the Fixed
28714 statement (string handling).
28716 * expression.cs (StringPtr): New class used to return a char * to
28717 a string; Used by the Fixed statement.
28719 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28721 * expression.cs (Binary.ResolveOperator): Remove redundant
28722 MemberLookup pn parent type.
28723 Optimize union call, we do not need a union if the types are the same.
28724 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28727 Specialize the use of MemberLookup everywhere, instead of using
28728 the default settings.
28730 (StackAlloc): Implement stackalloc keyword.
28732 * cs-parser.jay: Add rule to parse stackalloc.
28734 * driver.cs: Handle /h, /help, /?
28736 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28737 before we supported unsafe code.
28739 * makefile: add --unsafe to the self compilation of mcs.
28741 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28743 * expression.cs (PointerArithmetic): New class that is used to
28744 perform pointer arithmetic.
28745 (Binary.Resolve): Handle pointer arithmetic
28746 Handle pointer comparission.
28747 (ArrayPtr): Utility expression class that is used to take the
28748 address of an array.
28750 (ElementAccess): Implement array access for pointers
28752 * statement.cs (Fixed): Implement fixed statement for arrays, we
28753 are missing one more case before we are done.
28755 * expression.cs (Indirection): Implement EmitAssign and set the
28756 ExprClass to Variable. This allows pointer dereferences to be
28757 treated as variables, and to have values assigned to them.
28759 * ecore.cs (Expression.StoreFromPtr): New utility function to
28760 store values dereferencing.
28762 2002-02-20 Ravi Pratap <ravi@ximian.com>
28764 * expression.cs (Binary.ResolveOperator): Ensure that we are
28765 not trying to operate on a void type - this fixes the reported
28768 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28769 the parent implementation is sealed.
28771 * ../errors/cs0239.cs : Add.
28773 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28775 * typemanager.cs (unverifiable_code_type): Corresponds to
28776 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28777 which have unsafe code in them.
28779 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28782 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28784 * cs-tokenizer.cs: Add support for @"litreal strings"
28786 Make tokenizer accept pre-processor directives
28787 on any column (remove the old C-like limitation).
28789 * rootcontext.cs (EmitCode): Emit any global attributes.
28790 (AddGlobalAttributes): Used to keep track of assembly attributes.
28792 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28794 * cs-parser.jay: Add support for global attributes.
28796 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28798 * expression.cs (Indirection): New helper class. Unary will
28799 create Indirection classes to be able to implement the
28800 IMemoryLocation interface on it.
28802 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28804 * cs-parser.jay (fixed_statement): reference the right statement.
28806 * statement.cs (Fixed.Emit): Finish implementing the fixed
28807 statement for the &x case.
28809 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28811 * class.cs (Property.Define, Method.Define): Remove newslot when
28814 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28815 wrong. NewSlot should only be used if the `new' keyword is present.
28817 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28818 locating our system dir. Sorry about this.
28820 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28822 * driver.cs (GetSystemDir): Compute correctly the location of our
28823 system assemblies. I was using the compiler directory instead of
28824 the library directory.
28826 2002-02-13 Ravi Pratap <ravi@ximian.com>
28828 * expression.cs (BetterFunction): Put back in what Miguel commented out
28829 since it is the correct fix. The problem is elsewhere ;-)
28831 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28832 parameters of the parms method are themselves compatible or not !
28834 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28835 to check that a class implements an interface before saying that an implicit
28836 conversion was allowed. Use ImplementsInterface to do the checking.
28838 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28840 * class.cs (Method.Define): Track whether we are an explicit
28841 implementation or not. And only call DefineMethodOverride if we
28842 are an explicit implementation.
28844 (Property.DefineMethod): Ditto.
28846 2002-02-11 Ravi Pratap <ravi@ximian.com>
28848 * expression.cs (BetterFunction): Catch hideous bug which was
28849 preventing us from detecting ambiguous calls due to implicit casts i.e
28852 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28854 * support.cs (Pair): Remove un-needed method. I figured why I was
28855 getting the error in cs-parser.jay, the variable in a foreach loop
28856 is readonly, and the compiler does not really treat this as a variable.
28858 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28859 instead of EQUALS in grammar.
28861 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28863 * expression.cs (Unary.DoResolve): Check whether the argument is
28866 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28868 * support.cs: Api for Pair to set a value. Despite the fact that
28869 the variables are public the MS C# compiler refuses to compile
28870 code that accesses the field if the variable is part of a foreach
28873 * statement.cs (Fixed): Begin implementation of the fixed
28876 (Block.AddVariable): Return the VariableInfo on success and null
28877 on failure instead of true/false.
28879 * cs-parser.jay (foreach): Catch errors on variables already
28880 defined (we were ignoring this value before) and properly unwind
28881 the block hierarchy
28883 (fixed_statement): grammar for the fixed statement.
28885 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28887 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28888 pointer types to be incretemented.
28890 (SizeOf): Implement.
28892 * cs-parser.jay (pointer_member_access): Implement
28893 expr->IDENTIFIER production.
28895 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28896 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28899 (Unary): Implement indirection.
28901 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28902 use in non-unsafe context).
28904 (SimpleName.DoResolve): Check for pointers in field access on safe
28907 (Expression.LoadFromPtr): Factor the load-indirect code in this
28908 function. This was duplicated in UnboxCast and ParameterReference
28910 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28912 * expression.cs (ComposedCast): report an error if a pointer cast
28913 is used in a safe region.
28915 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28916 pointer type casts in unsafe context.
28918 * codegen.cs (EmitContext): Set up IsUnsafe.
28920 * cs-parser.jay (non_expression_type): Add productions for pointer
28923 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28924 code. We should not use force into static mode if the method is
28925 not virtual. Fixes bug in MIS
28927 * statement.cs (Do.Emit, While.Emit, For.Emit,
28928 Statement.EmitBoolExpression): Add support to Do and While to
28929 propagate infinite loop as `I do return' semantics.
28931 Improve the For case to also test for boolean constants.
28933 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28934 to the list of attributes we can add.
28936 Remove `EmitContext' argument.
28938 * class.cs (Method.Define): Apply parameter attributes.
28939 (Constructor.Define): Apply parameter attributes.
28940 (MethodCore.LabelParameters): Move here the core of labeling
28943 * support.cs (ReflectionParameters.ParameterModifier,
28944 InternalParameters.ParameterModifier): Use IsByRef on the type and
28945 only return the OUT bit for these parameters instead of in/out/ref
28948 This is because I miss-understood things. The ParameterInfo.IsIn
28949 and IsOut represent whether the parameter has the [In] and [Out]
28952 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28954 * ecore.cs (FieldExpr.Emit): Release temporaries.
28956 * assign.cs (LocalTemporary.Release): new function.
28958 * codegen.cs (EmitContext.GetTemporaryStorage,
28959 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28960 temporary storage. Now we can "put back" localbuilders when we
28963 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28965 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28966 need to make a copy of the variable to generate verifiable code.
28968 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28970 * driver.cs: Compute dynamically the system directory.
28972 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28973 Slower, but more generally useful. Used by the abstract
28974 registering implementation.
28976 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28977 the rules for the special rule on Type/instances. First check if
28978 we have the same name, and if so, try that special static path
28979 rather than the instance path.
28981 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28983 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28986 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28987 Enum, ValueType, Delegate or Array for non-corlib compiles.
28989 * cs-tokenizer.cs: Catch long identifiers (645)
28991 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28994 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28995 fix, we were returning too early, so we were not registering
28996 pending methods from abstract classes.
28998 Do not register pending methods if the class is abstract.
29000 * expression.cs (Conditional.DoResolve): Report circular implicit
29001 conversions when we neecd to compute it for conditional
29004 (Is.DoResolve): If the expression is always of the provided type,
29005 flag warning 183. If the expression can not ever be of the
29006 provided type flag warning 184.
29008 * class.cs: Catch 169 as well.
29010 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
29013 2002-01-18 Nick Drochak <ndrochak@gol.com>
29015 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
29017 2002-01-17 Miguel de Icaza <miguel@ximian.com>
29019 * interface.cs: (PopulateMethod): Check for pointers being defined
29020 only if the unsafe context is active.
29021 (PopulateProperty): ditto.
29022 (PopulateIndexer): ditto.
29024 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
29025 specified. If pointers are present, make sure that they are
29026 present in an unsafe context.
29027 (Constructor, Constructor.Define): ditto.
29028 (Field, Field.Define): ditto.
29029 (Property, Property.Define): ditto.
29030 (Event, Event.Define): ditto.
29032 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
29033 hashtable if there are classes or structs defined.
29035 * expression.cs (LocalVariableReference.DoResolve): Simplify this
29036 code, as the constant resolution moved.
29038 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
29039 the metadata, so we can flag error 133.
29041 * decl.cs (MemberCore.UnsafeOK): New function to test that a
29042 pointer is being declared in an unsafe context.
29044 2002-01-16 Miguel de Icaza <miguel@ximian.com>
29046 * modifiers.cs (Modifiers.Check): Require a Location argument.
29047 Report error 227 for Unsafe use.
29049 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
29051 * statement.cs (For.Emit): If the test is null, then report that
29052 we do `return', as we wont reach anything afterwards.
29054 (Switch.SwitchGoverningType): Track the expression that matched
29057 * driver.cs: Allow negative numbers as an error code to flag.
29059 * cs-parser.jay: Handle 1551.
29061 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
29063 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29065 * cs-parser.jay: Report 1518 (type declaration can only contain
29066 class, struct, interface, enum or delegate)
29068 (switch_label): Report 1523 (keywords `case' or `default' must
29071 (opt_switch_sections): Report 1522 (empty switch)
29073 * driver.cs: Report 1515 (response file specified multiple times)
29074 Report 1516 (Source file specified multiple times).
29076 * expression.cs (Argument.Resolve): Signal 1510
29078 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
29079 access not allowed in static code)
29081 2002-01-11 Ravi Pratap <ravi@ximian.com>
29083 * typemanager.cs (IsPointerType): Utility method which we are going
29086 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
29087 the object type, so we take care of that.
29089 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
29091 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
29092 added to non-params parameters :-)
29094 * typemanager.cs (CSharpName): Include 'void' type too.
29096 (void_ptr_type): Include in the set of core types.
29098 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
29101 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
29104 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
29105 completely forgotten about it.
29107 2002-01-10 Ravi Pratap <ravi@ximian.com>
29109 * cs-parser.jay (pointer_type): Add. This begins our implementation
29110 of parsing rules for unsafe code.
29112 (unsafe_statement): Implement.
29114 (embedded_statement): Modify to include the above.
29116 * statement.cs (Unsafe): Implement new class for unsafe blocks.
29118 * codegen.cs (EmitContext.InUnsafe): Add. This determines
29119 if the current context is an unsafe one.
29121 * cs-parser.jay (local_variable_pointer_type): Since local variable types
29122 are handled differently, we need separate rules for them.
29124 (local_variable_declaration): Update to use local_variable_pointer_type
29125 to allow variable declarations of unmanaged pointer types.
29127 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
29128 in unsafe contexts.
29130 * ../errors/cs0214.cs : Add.
29132 2002-01-16 Nick Drochak <ndrochak@gol.com>
29134 * makefile: remove 'response' file when cleaning.
29136 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29138 * cs-parser.jay: Report 1524.
29140 2002-01-14 Miguel de Icaza <miguel@ximian.com>
29142 * typemanager.cs (RegisterMethod): drop checking if we have
29143 registered this from here
29145 2002-01-12 Miguel de Icaza <miguel@ximian.com>
29147 * class.cs (Method.EmitDestructor): Implement calling our base
29150 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
29151 value of InFinally.
29153 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
29154 this routine and will wrap the call in a try/catch block. Deal
29157 2002-01-11 Miguel de Icaza <miguel@ximian.com>
29159 * ecore.cs (Expression.MemberLookup): instead of taking a
29160 parameter `same_type' that was used to tell whether we could
29161 access private members we compute our containing type from the
29164 (FieldExpr): Added partial support for volatile fields. This does
29165 not work for volatile fields exposed from assemblies, as I can not
29166 figure out how to extract the modreq from it.
29168 Updated all the source files to use this.
29170 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
29171 because it is referenced by MemberLookup very often.
29173 2002-01-09 Ravi Pratap <ravi@ximian.com>
29175 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
29176 TypeBuilder.GetCustomAttributes to retrieve what we need.
29178 Get rid of redundant default_member_attr_type as this is the same as
29179 default_member_type which already exists.
29181 * interface.cs, attribute.cs : Update accordingly.
29183 2002-01-08 Miguel de Icaza <miguel@ximian.com>
29185 * typemanager.cs: Enable IndexerPropertyName again. It does not
29186 work for TYpeBuilders though. Ravi, can you please fix this?
29188 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
29190 * expression.cs (Argument.Emit): Handle the case of ref objects
29191 being passed to ref functions;
29193 (ParameterReference.EmitLoad): Loads the content of the pointer
29194 without dereferencing.
29196 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29198 * cs-tokenizer.cs: Implemented the pre-processing expressions.
29200 2002-01-08 Ravi Pratap <ravi@ximian.com>
29202 * class.cs (Indexer.DefineMethod): Incorporate the interface
29203 type in the name of the method if we are doing explicit interface
29206 * expression.cs (ConversionExists): Remove as it is completely obsolete.
29208 (BetterConversion): Fix extremely trivial bug where we were referring to
29209 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
29212 * ../errors/bug16.cs : Add although we have fixed it.
29214 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29216 * expression.cs (BaseIndexer): Begin implementation.
29218 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
29220 * cs-parser.jay (indexer_declarator): Use qualified_identifier
29221 production directly to remove a shift/reduce, and implement
29222 explicit interface implementation.
29224 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
29225 after a floating point suffix.
29227 * expression.cs (DoNumericPromotions): Improved the conversion for
29228 uint/uint. If we have a constant, we avoid doing a typecast to a
29231 * class.cs (Indexer): Implement explicit interface implementation
29234 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
29236 * class.cs: make the default instance constructor public and hidebysig.
29238 2001-01-03 Ravi Pratap <ravi@ximian.com>
29240 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
29241 so we can call it from elsewhere.
29243 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
29244 we emit it internally if the class has a defined indexer; otherwise the user
29245 emits it by decorating the class definition with the DefaultMemberAttribute.
29247 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
29248 attribute is not used on a type which defines an indexer.
29250 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
29251 character when we skip whitespace.
29253 * ../errors/cs0646.cs : Add.
29255 2002-01-03 Miguel de Icaza <miguel@ximian.com>
29257 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
29260 * makefile: Add practical target `mcs3.exe' which builds the third
29261 generation compiler.
29263 * expression.cs (New): Fix structures constructor calling.
29265 * class.cs (Property, Method, Indexer): Emit Final flag on the
29266 method if we are an interface implementation and we are not
29269 * ecore.cs (PropertyExpr): New public field `IsBase', tells
29270 whether this property is referencing a `base' method.
29272 * expression.cs (Invocation.EmitCall): take an extra argument:
29273 is_base, this is used to determine whether the `call' or
29274 `callvirt' opcode should be used.
29277 * delegate.cs: update EmitCall.
29279 * class.cs (Method.Define): Set NewSlot for the cases where we are
29280 not implementing an interface method.
29282 (Property.Define): ditto.
29284 2002-01-02 Miguel de Icaza <miguel@ximian.com>
29286 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
29287 'r'. Allows mcs to parse itself fully.
29289 2002-01-02 Ravi Pratap <ravi@ximian.com>
29291 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
29292 of the number of initializers that require the InitializeArray method.
29294 (CheckIndices): Store the Expression in all cases - not the plain value. Also
29295 update the above field where necessary.
29297 (MakeByteBlob): Update accordingly.
29299 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
29302 (EmitDynamicInitializers): Update in accordance with the new optimization.
29304 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
29305 same OpCode applies.
29307 * cs-parser.jay : Fix some glaring errors I introduced.
29309 2002-01-01 Ravi Pratap <ravi@ximian.com>
29311 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
29312 so that we can check for name clashes there too.
29314 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29315 for interface indexers.
29317 * interfaces.cs (Define): Emit the default member attribute.
29319 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29320 variable was being referred to while setting the value ;-)
29322 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29324 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29325 byte-by-byte information when we know the data is zero.
29327 Make the block always a multiple of 4, because
29328 DefineInitializedData has a bug.
29330 * assign.cs: Fix, we should assign from the temporary, not from
29333 * expression.cs (MakeByteBlob): Fix my incorrect code.
29335 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29337 * typemanager.cs (EnumToUnderlying): This function is used to get
29338 the underlying type from an enumeration, because it does not
29341 * constant.cs: Use the I4_S form for values between -128 and 127.
29343 * statement.cs (Block.LookupLabel): Looks up a label.
29344 (Block): Drop support for labeled blocks.
29346 (LabeledStatement): New kind of statement that represents a label
29349 (Goto): Finally implement this bad boy.
29351 * cs-parser.jay: Update to reflect new mechanism to implement
29354 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29356 * codegen.cs (EmitContext.This): a codegen property that keeps the
29357 a single instance of this instead of creating many different this
29360 * delegate.cs (Delegate.DoResolve): Update to use the property;
29362 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29364 * expression.cs (BaseAccess.DoResolve): Ditto.
29366 2001-12-29 Ravi Pratap <ravi@ximian.com>
29368 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29369 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29371 (InitCoreTypes): Update accordingly.
29373 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29374 so we can quickly store the state.
29376 (ApplyAttributes): Set the correct implementation flags
29377 for InternalCall methods.
29379 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29381 * expression.cs (EmitCall): if a method is not virtual, then do
29382 not use callvirt on it.
29384 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29385 user defined stuff) requires the use of stobj, which takes an
29386 address on the stack instead of an array and an index. So emit
29387 the Ldelema operation for it.
29389 (EmitStoreOpcode): Use stobj for valuetypes.
29391 (UnaryMutator.EmitCode): Use the right 1 value depending on
29392 whether we are dealing with int64/uint64, float or doubles.
29394 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29395 constructors that I implemented last night.
29397 (Constructor.IsDefault): Fix to work properly for static
29400 * cs-parser.jay (CheckDef): report method signature errors.
29401 Update error number 103 to be 132.
29403 * decl.cs: New AdditionResult enumeration value: MethodExists.
29404 Although we do this check for methods later on in the semantic
29405 analysis, catching repeated default constructors is so easy that
29406 we catch these here.
29408 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29411 (ParameterReference.EmitAssign, Emit): handle
29414 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29415 (ArrayAccess.EmitStoreOpcode): ditto.
29417 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29419 * expression.cs (MakeByteBlob): Complete all the missing types
29420 (uint, short, ushort, byte, sbyte)
29422 * class.cs: Only init instance field initializers on instance
29425 Rename `constructors' to instance_constructors.
29427 (TypeContainer.AddConstructor): Only add constructors to the list
29428 if it is not static.
29430 Make sure that we handle default_static_constructor independently
29431 everywhere where we handle instance_constructors
29433 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29435 * class.cs: Do not lookup or create a base initializer for a
29436 static constructor.
29438 (ConstructorInitializer.Resolve): use the proper type to lookup
29441 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29443 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29446 * decl.cs: CloseType is now an virtual method, the default
29447 implementation just closes this type.
29449 2001-12-28 Ravi Pratap <ravi@ximian.com>
29451 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29452 to PreserveSig by default. Also emit HideBySig on such methods.
29454 Basically, set the defaults to standard values.
29456 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29457 argument, if candidate is better, it can't be worse than the best !
29459 (Invocation): Re-write bits to differentiate between methods being
29460 applicable in their expanded form and their normal form - for params
29463 Get rid of use_standard everywhere as only standard conversions are allowed
29464 in overload resolution.
29466 More spec conformance.
29468 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29470 * driver.cs: Add --timestamp, to see where the compiler spends
29473 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29474 `this' in static code.
29476 (SimpleName.DoResolve): Implement in terms of a helper function
29477 that allows static-references to be passed upstream to
29480 (Expression.ResolveWithSimpleName): Resolve specially simple
29481 names when called by MemberAccess to implement the special
29484 (Expression.ImplicitReferenceConversion): Handle conversions from
29485 Null to reference types before others, as Null's type is
29488 * expression.cs (Invocation.EmitCall): Handle the special case of
29489 calling methods declared on a reference type from a ValueType
29490 (Base classes System.Object and System.Enum)
29492 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29493 the left hand side is a TypeExpr, not on every enumeration.
29495 (Binary.Resolve): If types are reference types, then do a cast to
29496 object on operators != and == of both arguments.
29498 * typemanager.cs (FindMembers): Extract instance and static
29499 members if requested.
29501 * interface.cs (PopulateProperty): Use void_type instead of null
29502 as the return type for the setter method.
29504 (PopulateIndexer): ditto.
29506 2001-12-27 Ravi Pratap <ravi@ximian.com>
29508 * support.cs (ReflectionParameters): Fix minor bug where we
29509 were examining the wrong parameter for the ParamArray attribute.
29511 Cope with requests for the type of the parameter at position
29512 greater than the params parameter's. We now return the element
29513 type of the params array as that makes more sense.
29515 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29516 accordingly as we no longer have to extract the element type
29519 (Invocation.OverloadResolve): Update.
29521 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29523 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29524 against IEnumerator, test whether the return value is a descendant
29525 of the IEnumerator interface.
29527 * class.cs (Indexer.Define): Use an auxiliary method to implement
29528 the other bits of the method definition. Begin support for
29529 explicit interface implementation.
29531 (Property.DefineMethod): Use TypeManager.void_type instead of null
29532 for an empty return value.
29534 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29536 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29537 dealing with a FieldExpr which is composed of a FieldBuilder, in
29538 the code path we did extract the constant, but we should have
29539 obtained the underlying value to be able to cast it (otherwise we
29540 end up in an infinite loop, this is what Ravi was running into).
29542 (ArrayCreation.UpdateIndices): Arrays might be empty.
29544 (MemberAccess.ResolveMemberAccess): Add support for section
29545 14.5.4.1 that deals with the special case of E.I when E is a type
29546 and something else, that I can be a reference to a static member.
29548 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29549 handle a particular array type to create byte blobs, it is just
29550 something we dont generate byteblobs for.
29552 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29555 * location.cs (Push): remove the key from the hashtable that we
29556 are about to add. This happens for empty files.
29558 * driver.cs: Dispose files after we have parsed them.
29560 (tokenize): new function that only runs the tokenizer on its
29561 input, for speed testing.
29563 2001-12-26 Ravi Pratap <ravi@ximian.com>
29565 * class.cs (Event.Define): Define the private field only if there
29566 are no accessors defined.
29568 * expression.cs (ResolveMemberAccess): If there is no associated
29569 field with the event, that means we have an event defined with its
29570 own accessors and we should flag error cs0070 since transforming
29571 ourselves into a field is not valid in that case.
29573 * ecore.cs (SimpleName.DoResolve): Same as above.
29575 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29576 and charset to sane values.
29578 2001-12-25 Ravi Pratap <ravi@ximian.com>
29580 * assign.cs (DoResolve): Perform check on events only if they
29581 are being accessed outside the declaring type.
29583 * cs-parser.jay (event_declarations): Update rules to correctly
29584 set the type of the implicit parameter etc.
29586 (add_accessor, remove_accessor): Set current local parameters.
29588 * expression.cs (Binary): For delegate addition and subtraction,
29589 cast the return value from the method into the appropriate delegate
29592 2001-12-24 Ravi Pratap <ravi@ximian.com>
29594 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29595 of these as the workaround is unnecessary.
29597 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29598 delegate data - none of that is needed at all.
29600 Re-write bits to extract the instance expression and the delegate method
29603 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29606 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29607 of attaching attributes instead of duplicating code everywhere.
29609 * everywhere : Update code to do attribute emission using the above method.
29611 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29613 * expression.cs (IsParamsMethodApplicable): if there are not
29614 parameters, return immediately.
29616 * ecore.cs: The 0 literal can be implicity converted to an enum
29619 (SimpleName.DoResolve): First lookup the type, then lookup the
29622 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29623 want to get its address. If the InstanceExpression is not
29624 addressable, store the result in a temporary variable, then get
29627 * codegen.cs: Only display 219 errors on warning level or above.
29629 * expression.cs (ArrayAccess): Make it implement the
29630 IMemoryLocation interface.
29632 (Binary.DoResolve): handle the operator == (object a, object b)
29633 and operator != (object a, object b) without incurring into a
29634 BoxedCast (because 5 != o should never be performed).
29636 Handle binary enumerator operators.
29638 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29639 value type, otherwise use Ldelem_ref.
29641 Use precomputed names;
29643 (AddressOf): Implement address of
29645 * cs-parser.jay (labeled_statement): Fix recursive block
29646 addition by reworking the production.
29648 * expression.cs (New.DoEmit): New has a special case:
29650 If we are dealing with a ValueType, we have a few
29651 situations to deal with:
29653 * The target of New is a ValueType variable, that is
29654 easy, we just pass this as the variable reference
29656 * The target of New is being passed as an argument,
29657 to a boxing operation or a function that takes a
29660 In this case, we need to create a temporary variable
29661 that is the argument of New.
29664 2001-12-23 Ravi Pratap <ravi@ximian.com>
29666 * rootcontext.cs (LookupType): Check that current_type is not null before
29667 going about looking at nested types.
29669 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29670 not implement the IAssignMethod interface any more.
29672 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29673 where we tranform them into FieldExprs if they are being resolved from within
29674 the declaring type.
29676 * ecore.cs (SimpleName.DoResolve): Do the same here.
29678 * assign.cs (DoResolve, Emit): Clean up code considerably.
29680 * ../errors/bug10.cs : Add.
29682 * ../errors/cs0070.cs : Add.
29684 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29686 * assign.cs : Get rid of EventIsLocal everywhere.
29688 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29690 * ecore.cs (ConvertIntLiteral): finished the implementation.
29692 * statement.cs (SwitchLabel): Convert the value we are using as a
29693 key before looking up the table.
29695 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29697 * codegen.cs (EmitTopBlock): Require a Location argument now.
29699 * cs-parser.jay (constructor_declarator): We need to setup
29700 current_local_parameters before we parse the
29701 opt_constructor_initializer, to allow the variables to be bound
29702 to the constructor arguments.
29704 * rootcontext.cs (LookupType): First lookup nested classes in our
29705 class and our parents before we go looking outside our class.
29707 * expression.cs (ConstantFold): Extract/debox the values at the
29710 * rootcontext.cs (EmitCode): Resolve the constants first before we
29711 resolve the types. This is not really needed, but it helps debugging.
29713 * statement.cs: report location.
29715 * cs-parser.jay: pass location to throw statement.
29717 * driver.cs: Small bug fix.
29719 * report.cs: Updated format to be 4-zero filled digits.
29721 2001-12-22 Ravi Pratap <ravi@ximian.com>
29723 * expression.cs (CheckIndices): Fix minor bug where the wrong
29724 variable was being referred to ;-)
29726 (DoEmit): Do not call EmitStaticInitializers when the
29727 underlying type is System.Object.
29729 2001-12-21 Ravi Pratap <ravi@ximian.com>
29731 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29732 and do the usual workaround for SRE.
29734 * class.cs (MyEventBuilder.EventType): New member to get at the type
29735 of the event, quickly.
29737 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29739 * assign.cs (Assign.DoResolve): Handle the case when the target
29740 is an EventExpr and perform the necessary checks.
29742 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29745 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29747 (EventExpr): Set the type in the constructor itself since we
29748 are meant to be born fully resolved.
29750 (EventExpr.Define): Revert code I wrote earlier.
29752 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29753 instance expression is null. The instance expression is a This in that case
29754 or a null, depending on whether it is a static method or not.
29756 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29757 refers to more than one method.
29759 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29760 and accordingly flag errors.
29762 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29764 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29766 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29768 * location.cs (ToString): Provide useful rutine.
29770 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29772 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29773 objects, return the actual integral boxed.
29775 * statement.cs (SwitchLabel): define an ILLabel for each
29778 (Switch.CheckSwitch): If the value is a Literal, extract
29779 the underlying literal.
29781 Also in the unused hashtable we had, add the SwitchLabel so we can
29782 quickly look this value up.
29784 * constant.cs: Implement a bunch of new constants. Rewrite
29785 Literal based on this. Made changes everywhere to adapt to this.
29787 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29788 dereferencing array only once, and also copes with enumrations.
29790 bytes are two bytes wide, not one.
29792 (Cast): Perform constant conversions.
29794 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29795 wrappers to the literals here.
29797 * expression.cs (DoNumericPromotions): long literals can converted
29798 to ulong implicity (this is taken care of elsewhere, but I was
29799 missing this spot).
29801 * ecore.cs (Expression.Literalize): Make the return type Literal,
29802 to improve type checking.
29804 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29806 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29808 * literal.cs: Revert code from ravi that checked the bounds. The
29809 bounds are sane by the definition of the type itself.
29811 * typemanager.cs: Fix implementation of ImplementsInterface. We
29812 need to actually look up in our parent hierarchy for interfaces
29815 * const.cs: Use the underlying type for enumerations
29817 * delegate.cs: Compute the basename for the delegate creation,
29818 that should fix the delegate test case, and restore the correct
29819 Type Lookup semantics in rootcontext
29821 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29822 referencing a nested type with the Reflection API is using the "+"
29825 * cs-parser.jay: Do not require EOF token at the end.
29827 2001-12-20 Ravi Pratap <ravi@ximian.com>
29829 * rootcontext.cs (LookupType): Concatenate type names with
29830 a '.' instead of a '+' The test suite passes again.
29832 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29833 field of the enumeration.
29835 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29836 the case when the member is an EventExpr.
29838 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29839 static has an associated instance expression.
29841 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29843 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29845 * class.cs (Event.Define): Register event and perform appropriate checks
29848 We define the Add and Remove methods even if the use provides none because
29849 in that case, we provide default implementations ourselves.
29851 Define a private field of the type of the event. This is done by the CSC compiler
29852 and we should be doing it too ;-)
29854 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29855 More methods we use in code we generate.
29857 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29860 (InitCoreTypes): Update accordingly for the above.
29862 * class.cs (Event.Emit): Generate code for default accessors that we provide
29864 (EmitDefaultMethod): Do the job in the above.
29866 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29869 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29871 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29872 builders even if we were missing one.
29874 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29875 pass the Basename as our class name instead of the Name. The
29876 basename will be correctly composed for us.
29878 * parameter.cs (Paramters): Now takes a Location argument.
29880 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29881 make all the code call directly LookupType in RootContext and take
29882 this chance to pass the Location information everywhere.
29884 * Everywhere: pass Location information.
29886 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29888 * class.cs (Constructor.Define): Updated way of detecting the
29889 length of the parameters.
29891 (TypeContainer.DefineType): Use basename as the type name for
29894 (TypeContainer.Define): Do not recursively define types here, as
29895 definition is taken care in order by the RootContext.
29897 * tree.cs: Keep track of namespaces in a per-file basis.
29899 * parameter.cs (Parameter.ComputeSignature): Update to use
29902 (Parameters.GetSignature): ditto.
29904 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29905 instead of a TypeContainer.
29907 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29908 resolve names. Because we need to be resolve in our context, not
29911 * driver.cs: Implement response files.
29913 * class.cs (TypeContainer.DefineType): If we are defined, do not
29914 redefine ourselves.
29916 (Event.Emit): Emit the code for add/remove handlers.
29917 (Event.Define): Save the MethodBuilders for add/remove.
29919 * typemanager.cs: Use pair here too.
29921 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29922 DictionaryEntry requires the first argument to be non-null.
29924 (enum_declaration): Compute full name for registering the
29927 (delegate_declaration): Instead of using
29928 formal_parameter_list, use opt_formal_parameter_list as the list
29931 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29932 (EventParsing): New property that controls whether `add' and
29933 `remove' are returned as tokens or identifiers (for events);
29935 2001-12-19 Ravi Pratap <ravi@ximian.com>
29937 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29938 use MyEventBuilder only and let it wrap the real builder for us.
29940 (MyEventBuilder): Revamp constructor etc.
29942 Implement all operations that we perform on EventBuilder in precisely the same
29945 (FindMembers): Update to use the EventBuilder member.
29947 (Event.Emit): Update accordingly.
29949 2001-12-18 Ravi Pratap <ravi@ximian.com>
29951 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29952 by calling the appropriate methods.
29954 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29957 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29959 2001-12-17 Ravi Pratap <ravi@ximian.com>
29961 * delegate.cs (Delegate.Populate): Check that the return type
29962 and various parameters types are indeed accessible.
29964 * class.cs (Constructor.Define): Same here.
29966 (Field.Define): Ditto.
29968 (Event.Define): Ditto.
29970 (Operator.Define): Check that the underlying Method defined itself
29971 correctly - so it's MethodBuilder should not be null.
29973 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29974 expression happens to be null.
29976 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29977 members but as of now we don't seem to be able to do anything really useful with it.
29979 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29980 not the EventBuilder.
29982 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29984 * cs-tokenizer.cs: Add support for defines.
29985 Add support for #if, #elif, #else, #endif
29987 (eval_var): evaluates a variable.
29988 (eval): stubbed for evaluating functions.
29990 * cs-parser.jay: Pass the defines information
29992 * driver.cs: Add --define command line option.
29994 * decl.cs: Move MemberCore here.
29996 Make it the base class for DeclSpace. This allows us to catch and
29997 report 108 and 109 for everything now.
29999 * class.cs (TypeContainer.Define): Extract all the members
30000 before populating and emit the warning 108 (new keyword required
30001 to override) instead of having each member implement this.
30003 (MemberCore.Define): New abstract method, we will be using this in
30004 the warning reporting engine in Populate.
30006 (Operator.Define): Adjust to new MemberCore protocol.
30008 * const.cs (Const): This does not derive from Expression, it is a
30009 temporary object we use to create fields, it is a MemberCore.
30011 * class.cs (Method.Define): Allow the entry point to be in a
30014 * driver.cs: Rewrite the argument handler to clean it up a bit.
30016 * rootcontext.cs: Made it just an auxiliary namespace feature by
30017 making everything static.
30019 * driver.cs: Adapt code to use RootContext type name instead of
30022 * delegate.cs: Remove RootContext argument.
30024 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
30027 * class.cs (Event.Define): The lookup can fail.
30029 * cs-tokenizer.cs: Begin implementation of pre-procesor.
30031 * expression.cs: Resolve the this instance before invoking the code.
30033 2001-12-17 Miguel de Icaza <miguel@ximian.com>
30035 * cs-parser.jay: Add a production in element_access that allows
30036 the thing to become a "type" reference. This way we can parse
30037 things like "(string [])" as a type.
30039 Note that this still does not handle the more complex rules of
30043 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
30045 * ecore.cs: (CopyNewMethods): new utility function used to
30046 assemble the list of methods from running FindMembers.
30048 (MemberLookup): Rework FindMembers so that
30050 2001-12-16 Miguel de Icaza <miguel@ximian.com>
30052 * class.cs (TypeContainer): Remove Delegates who fail to be
30055 * delegate.cs (Populate): Verify that we dont get null return
30056 values. TODO: Check for AsAccessible.
30058 * cs-parser.jay: Use basename to emit error 574 (destructor should
30059 have the same name as container class), not the full name.
30061 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
30062 possible representation.
30064 Also implements integer type suffixes U and L.
30066 2001-12-15 Miguel de Icaza <miguel@ximian.com>
30068 * expression.cs (ArrayCreation.DoResolve): We need to do the
30069 argument resolution *always*.
30071 * decl.cs: Make this hold the namespace. Hold the root context as
30073 (LookupType): Move here.
30075 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
30077 * location.cs (Row, Name): Fixed the code, it was always returning
30078 references to the first file.
30080 * interface.cs: Register properties defined through interfaces.
30082 * driver.cs: Add support for globbing on the command line
30084 * class.cs (Field): Make it derive from MemberCore as well.
30087 2001-12-15 Ravi Pratap <ravi@ximian.com>
30089 * class.cs (Event::Define): Check that the type of the event is a delegate
30090 type else flag error #66.
30092 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
30095 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
30096 values of EntryPoint, CharSet etc etc.
30098 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
30100 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
30101 be null and we should ignore this. I am not sure if this is really clean. Apparently,
30102 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
30103 which needs this to do its work.
30105 * ../errors/cs0066.cs : Add.
30107 2001-12-14 Miguel de Icaza <miguel@ximian.com>
30109 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
30112 * class.cs: (MethodSignature.MethodSignature): Removed hack that
30113 clears out the parameters field.
30114 (MemberSignatureCompare): Cleanup
30116 (MemberCore): New base class used to share code between MethodCore
30119 (RegisterRequiredImplementations) BindingFlags.Public requires
30120 either BindingFlags.Instace or Static. Use instance here.
30122 (Property): Refactored code to cope better with the full spec.
30124 * parameter.cs (GetParameterInfo): Return an empty array instead
30127 * class.cs (Property): Abstract or extern properties have no bodies.
30129 * parameter.cs (GetParameterInfo): return a zero-sized array.
30131 * class.cs (TypeContainer.MethodModifiersValid): Move all the
30132 method modifier validation to the typecontainer so we can reuse
30133 this on properties.
30135 (MethodCore.ParameterTypes): return an empty sized array of types.
30137 (Property.Define): Test property modifier validity.
30139 Add tests for sealed/override too.
30141 (Method.Emit): abstract or extern methods have no bodies.
30143 2001-12-14 Ravi Pratap <ravi@ximian.com>
30145 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
30148 (Method::Define, ::Emit): Modify accordingly.
30150 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
30152 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
30154 * makefile: Pass in /unsafe.
30156 2001-12-13 Miguel de Icaza <miguel@ximian.com>
30158 * class.cs (MakeKey): Kill routine.
30160 * class.cs (TypeContainer.Define): Correctly define explicit
30161 method implementations (they require the full interface name plus
30164 * typemanager.cs: Deply the PtrHashtable here and stop using the
30165 lame keys. Things work so much better.
30167 This of course broke everyone who depended on `RegisterMethod' to
30168 do the `test for existance' test. This has to be done elsewhere.
30170 * support.cs (PtrHashtable): A hashtable that avoid comparing with
30171 the object stupid Equals method (because, that like fails all over
30172 the place). We still do not use it.
30174 * class.cs (TypeContainer.SetRequiredInterface,
30175 TypeContainer.RequireMethods): Killed these two routines and moved
30176 all the functionality to RegisterRequiredImplementations.
30178 (TypeContainer.RegisterRequiredImplementations): This routine now
30179 registers all the implementations required in an array for the
30180 interfaces and abstract methods. We use an array of structures
30181 which can be computed ahead of time to reduce memory usage and we
30182 also assume that lookups are cheap as most classes will not
30183 implement too many interfaces.
30185 We also avoid creating too many MethodSignatures.
30187 (TypeContainer.IsInterfaceMethod): Update and optionally does not
30188 clear the "pending" bit if we find that there are problems with
30191 (TypeContainer.VerifyPendingMethods): Update to report errors of
30192 methods that look like implementations but are not.
30194 (TypeContainer.Define): Add support for explicit interface method
30197 2001-12-12 Miguel de Icaza <miguel@ximian.com>
30199 * typemanager.cs: Keep track of the parameters here instead of
30200 being a feature of the TypeContainer.
30202 * class.cs: Drop the registration of parameters here, as
30203 InterfaceMethods are also interface declarations.
30205 * delegate.cs: Register methods with the TypeManager not only with
30206 the TypeContainer. This code was buggy.
30208 * interface.cs: Full registation here.
30210 2001-12-11 Miguel de Icaza <miguel@ximian.com>
30212 * expression.cs: Remove reducer for binary expressions, it can not
30215 * const.cs: Put here the code that used to go into constant.cs
30217 * constant.cs: Put here the code for constants, this is a new base
30218 class for Literals.
30220 * literal.cs: Make Literal derive from Constant.
30222 2001-12-09 Miguel de Icaza <miguel@ximian.com>
30224 * statement.cs (Return.Emit): Report error 157 if the user
30225 attempts to return from a finally block.
30227 (Return.Emit): Instead of emitting a return, jump to the end of
30230 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
30231 LocalBuilder to store the result of the function. ReturnLabel is
30232 the target where we jump.
30235 2001-12-09 Radek Doulik <rodo@ximian.com>
30237 * cs-parser.jay: remember alias in current namespace
30239 * ecore.cs (SimpleName::DoResolve): use aliases for types or
30242 * class.cs (LookupAlias): lookup alias in my_namespace
30244 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
30246 (LookupAlias): lookup alias in this and if needed in parent
30249 2001-12-08 Miguel de Icaza <miguel@ximian.com>
30253 * rootcontext.cs: (ModuleBuilder) Made static, first step into
30254 making things static. I need this to avoid passing the
30255 TypeContainer when calling ParameterType.
30257 * support.cs (InternalParameters.ParameterType): Remove ugly hack
30258 that did string manipulation to compute the type and then call
30259 GetType. Use Parameter.ParameterType instead.
30261 * cs-tokenizer.cs: Consume the suffix for floating values.
30263 * expression.cs (ParameterReference): figure out whether this is a
30264 reference parameter or not. Kill an extra variable by computing
30265 the arg_idx during emission.
30267 * parameter.cs (Parameters.GetParameterInfo): New overloaded
30268 function that returns whether a parameter is an out/ref value or not.
30270 (Parameter.ParameterType): The type of the parameter (base,
30271 without ref/out applied).
30273 (Parameter.Resolve): Perform resolution here.
30274 (Parameter.ExternalType): The full type (with ref/out applied).
30276 * statement.cs (Using.Emit, Using.EmitExpression): Implement
30277 support for expressions on the using statement.
30279 2001-12-07 Miguel de Icaza <miguel@ximian.com>
30281 * statement.cs (Using.EmitLocalVariableDecls): Split the
30282 localvariable handling of the using statement.
30284 (Block.EmitMeta): Keep track of variable count across blocks. We
30285 were reusing slots on separate branches of blocks.
30287 (Try.Emit): Emit the general code block, we were not emitting it.
30289 Check the type of the declaration to be an IDisposable or
30290 something that can be implicity converted to it.
30292 Emit conversions if required.
30294 * ecore.cs (EmptyExpression): New utility class.
30295 (Expression.ImplicitConversionExists): New utility function.
30297 2001-12-06 Miguel de Icaza <miguel@ximian.com>
30299 * statement.cs (Using): Implement.
30301 * expression.cs (LocalVariableReference): Support read only variables.
30303 * statement.cs: Remove the explicit emit for the Leave opcode.
30304 (VariableInfo): Add a readonly field.
30306 2001-12-05 Miguel de Icaza <miguel@ximian.com>
30308 * ecore.cs (ConvCast): new class used to encapsulate the various
30309 explicit integer conversions that works in both checked and
30310 unchecked contexts.
30312 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30313 properly generate the overflow opcodes.
30315 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30317 * statement.cs: The correct type for the EmptyExpression is the
30318 element_type, not the variable type. Ravi pointed this out.
30320 2001-12-04 Ravi Pratap <ravi@ximian.com>
30322 * class.cs (Method::Define): Handle PInvoke methods specially
30323 by using DefinePInvokeMethod instead of the usual one.
30325 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30326 above to do the task of extracting information and defining the method.
30328 2001-12-04 Ravi Pratap <ravi@ximian.com>
30330 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30331 of the condition for string type.
30333 (Emit): Move that here.
30335 (ArrayCreation::CheckIndices): Keep string literals in their expression
30338 (EmitDynamicInitializers): Handle strings appropriately.
30340 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30342 * codegen.cs (EmitContext): Replace multiple variables with a
30343 single pointer to the current Switch statement.
30345 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30348 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30352 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30355 (Foreach.Emit): Foreach on arrays was not setting
30356 up the loop variables (for break/continue).
30358 (GotoCase): Semi-implented.
30360 2001-12-03 Ravi Pratap <ravi@ximian.com>
30362 * attribute.cs (CheckAttribute): Handle system attributes by using
30363 Attribute.GetAttributes to examine information we need.
30365 (GetValidPlaces): Same here.
30367 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30369 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30371 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30373 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30375 (Method::Emit): Handle the case when we are a PInvoke method.
30377 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30379 * expression.cs: Use ResolveWithSimpleName on compound names.
30381 2001-12-02 Ravi Pratap <ravi@ximian.com>
30383 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30384 before trying to reduce it.
30386 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30388 * constant.cs (LookupConstantValue): Implement.
30390 (EmitConstant): Use the above in emitting the constant.
30392 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30393 that are user-defined by doing a LookupConstantValue on them.
30395 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30398 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30400 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30402 (BaseAccess.DoResolve): Implement.
30404 (MemberAccess.DoResolve): Split this routine into a
30405 ResolveMemberAccess routine that can be used independently
30407 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30409 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30410 As that share bits of the implementation. Is returns a boolean,
30411 while As returns the Type that is being probed.
30413 2001-12-01 Ravi Pratap <ravi@ximian.com>
30415 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30416 instead of a Literal - much easier.
30418 (EnumInTransit): Remove - utterly useless :-)
30420 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30422 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30424 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30425 chain when we have no associated expression.
30427 2001-11-30 Ravi Pratap <ravi@ximian.com>
30429 * constant.cs (Define): Use Location while reporting the errror.
30431 Also emit a warning when 'new' is used and there is no inherited
30434 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30437 (LookupEnumValue): Implement to lookup an enum member's value and define it
30440 (Populate): Re-write accordingly to use the above routine.
30442 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30444 * expression.cs (This): Fix prototype for DoResolveLValue to
30445 override the base class DoResolveLValue.
30447 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30450 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30451 (we need to load the address of the field here). This fixes
30454 (FieldExpr.DoResolveLValue): Call the DoResolve
30455 function to initialize the Instance expression.
30457 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30458 correctly the GetEnumerator operation on a value type.
30460 * cs-parser.jay: Add more simple parsing error catches.
30462 * statement.cs (Switch): Add support for string switches.
30463 Handle null specially.
30465 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30467 2001-11-28 Ravi Pratap <ravi@ximian.com>
30469 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30471 (declare_local_constant): New helper function.
30473 * statement.cs (AddConstant): Keep a separate record of constants
30475 (IsConstant): Implement to determine if a variable is a constant.
30477 (GetConstantExpression): Implement.
30479 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30481 * statement.cs (IsVariableDefined): Re-write.
30483 2001-11-27 Ravi Pratap <ravi@ximian.com>
30485 * class.cs (TypeContainer::FindMembers): Look for constants
30486 in the case when we are looking for MemberTypes.Field
30488 * expression.cs (MemberAccess::DoResolve): Check that in the
30489 case we are a FieldExpr and a Literal, we are not being accessed
30490 by an instance reference.
30492 * cs-parser.jay (local_constant_declaration): Implement.
30494 (declaration_statement): Implement for constant declarations.
30496 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30498 * statement.cs (Switch): Catch double defaults.
30500 (Switch): More work on the switch() statement
30501 implementation. It works for integral values now, need to finish
30505 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30507 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30508 integer literals into other integer literals. To be used by
30511 2001-11-24 Ravi Pratap <ravi@ximian.com>
30513 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30516 (EmitDynamicInitializers): Cope with the above since we extract data
30517 directly from ArrayData now.
30519 (ExpectInitializers): Keep track of whether initializers are mandatory
30522 (Bounds): Make it a hashtable to prevent the same dimension being
30523 recorded for every element in that dimension.
30525 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30528 Also fix bug which was causing the indices to be emitted in the reverse
30531 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30533 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30534 unfinished. They do not work, because the underlying code is
30537 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30539 * cs-parser.jay: Remove bogus fixme.
30541 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30542 on Switch statement.
30544 2001-11-23 Ravi Pratap <ravi@ximian.com>
30546 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30549 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30550 parameter. Apparently, any expression is allowed.
30552 (ValidateInitializers): Update accordingly.
30554 (CheckIndices): Fix some tricky bugs thanks to recursion.
30556 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30557 I was being completely brain-dead.
30559 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30560 and re-write acordingly.
30562 (DelegateInvocation): Re-write accordingly.
30564 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30566 (MakeByteBlob): Handle types more correctly.
30568 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30569 initialization from expressions but it is incomplete because I am a complete
30572 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30574 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30575 on If. Basically, we have to return `true' (ie, we do return to
30576 our caller) only if both branches of the if return.
30578 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30579 short-circuit operators, handle them as short circuit operators.
30581 (Cast.DoResolve): Resolve type.
30582 (Cast.Cast): Take an expression as the target type.
30584 * cs-parser.jay (cast_expression): Remove old hack that only
30585 allowed a limited set of types to be handled. Now we take a
30586 unary_expression and we resolve to a type during semantic
30589 Use the grammar productions from Rhys to handle casts (this is
30590 not complete like Rhys syntax yet, we fail to handle that corner
30591 case that C# has regarding (-x), but we will get there.
30593 2001-11-22 Ravi Pratap <ravi@ximian.com>
30595 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30596 field which is an array type.
30598 * cs-parser.jay (declare_local_variables): Support array initialization too.
30600 * typemanager.cs (MakeKey): Implement.
30602 (everywhere): Use the above appropriately.
30604 * cs-parser.jay (for_statement): Update for array initialization while
30605 declaring variables.
30607 * ecore.cs : The error message was correct, it's the variable's names that
30608 were misleading ;-) Make the code more readable.
30610 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30611 the correct type etc.
30613 (ConvertExplicit): Handle Enum types by examining the underlying type.
30615 2001-11-21 Ravi Pratap <ravi@ximian.com>
30617 * parameter.cs (GetCallingConvention): Always return
30618 CallingConventions.Standard for now.
30620 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30622 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30623 and `r' after calling DoNumericPromotions.
30625 * ecore.cs: Fix error message (the types were in the wrong order).
30627 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30628 BindingFlags.Instance as well
30630 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30631 implicit int literal conversion in an empty cast so that we
30632 propagate the right type upstream.
30634 (UnboxCast): new class used to unbox value types.
30635 (Expression.ConvertExplicit): Add explicit type conversions done
30638 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30639 the target type before applying the implicit LongLiterals to ULong
30642 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30644 * cs-parser.jay (for_statement): Reworked the way For works: now
30645 we declare manually any variables that are introduced in
30646 for_initializer to solve the problem of having out-of-band code
30647 emition (that is what got for broken).
30649 (declaration_statement): Perform the actual variable declaration
30650 that used to be done in local_variable_declaration here.
30652 (local_variable_declaration): Do not declare anything, just pass
30653 the information on a DictionaryEntry
30655 2001-11-20 Ravi Pratap <ravi@ximian.com>
30657 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30658 re-write of the logic to now make it recursive.
30660 (UpdateIndices): Re-write accordingly.
30662 Store element data in a separate ArrayData list in the above methods.
30664 (MakeByteBlob): Implement to dump the array data into a byte array.
30666 2001-11-19 Ravi Pratap <ravi@ximian.com>
30668 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30671 * constant.cs (Define): Implement.
30673 (EmitConstant): Re-write fully.
30675 Pass in location info.
30677 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30680 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30681 DictionaryEntry since we need location info too.
30683 (constant_declaration): Update accordingly.
30685 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30686 code into another method : UpdateIndices.
30688 2001-11-18 Ravi Pratap <ravi@ximian.com>
30690 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30691 some type checking etc.
30693 2001-11-17 Ravi Pratap <ravi@ximian.com>
30695 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30696 bits to provide dimension info if the user skips doing that.
30698 Update second constructor to store the rank correctly.
30700 2001-11-16 Ravi Pratap <ravi@ximian.com>
30702 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30703 and try to implement.
30705 * ../errors/cs0150.cs : Add.
30707 * ../errors/cs0178.cs : Add.
30709 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30711 * statement.cs: Implement foreach on multi-dimensional arrays.
30713 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30714 name of the params argument.
30716 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30717 initializing the array.
30719 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30720 we can use this elsewhere.
30722 * statement.cs: Finish implementation of foreach for single
30725 * cs-parser.jay: Use an out-of-band stack to pass information
30726 around, I wonder why I need this.
30728 foreach_block: Make the new foreach_block the current_block.
30730 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30731 function used to return a static Parameters structure. Used for
30732 empty parameters, as those are created very frequently.
30734 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30736 2001-11-15 Ravi Pratap <ravi@ximian.com>
30738 * interface.cs : Default modifier is private, not public. The
30739 make verify test passes again.
30741 2001-11-15 Ravi Pratap <ravi@ximian.com>
30743 * support.cs (ReflectionParameters): Fix logic to determine
30744 whether the last parameter is a params one. Test 9 passes again.
30746 * delegate.cs (Populate): Register the builders we define with
30747 RegisterParameterForBuilder. Test 19 passes again.
30749 * cs-parser.jay (property_declaration): Reference $6 instead
30750 of $$ to get at the location.
30752 (indexer_declaration): Similar stuff.
30754 (attribute): Ditto.
30756 * class.cs (Property): Register parameters for the Get and Set methods
30757 if they exist. Test 23 passes again.
30759 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30760 call to EmitArguments as we are sure there aren't any params arguments.
30761 Test 32 passes again.
30763 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30764 IndexOutOfRangeException.
30766 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30767 Test 33 now passes again.
30769 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30771 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30772 broke a bunch of things. Will have to come up with a better way
30773 of tracking locations.
30775 * statement.cs: Implemented foreach for single dimension arrays.
30777 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30779 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30780 an error. This removes the lookup from the critical path.
30782 * cs-parser.jay: Removed use of temporary_loc, which is completely
30785 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30787 * support.cs (ReflectionParameters.ParameterModifier): Report
30788 whether the argument is a PARAMS argument or not.
30790 * class.cs: Set the attribute `ParamArrayAttribute' on the
30791 parameter argument.
30793 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30794 and cons_param_array_attribute (ConstructorInfo for
30795 ParamArrayAttribute).,
30797 * codegen.cs: Emit the return using the `Return' statement, that
30798 way we can report the error correctly for missing return values.
30800 * class.cs (Method.Emit): Clean up.
30802 * expression.cs (Argument.Resolve): Take another argument: the
30803 location where this argument is used. Notice that this is not
30804 part of the "Argument" class as to reduce the size of the
30805 structure (we know the approximate location anyways).
30807 Test if the argument is a variable-reference, if not, then
30808 complain with a 206.
30810 (Argument.Emit): Emit addresses of variables.
30812 (Argument.FullDesc): Simplify.
30814 (Invocation.DoResolve): Update for Argument.Resolve.
30816 (ElementAccess.DoResolve): ditto.
30818 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30819 method should be virtual, as this method is always virtual.
30821 (NewDelegate.DoResolve): Update for Argument.Resolve.
30823 * class.cs (ConstructorInitializer.DoResolve): ditto.
30825 * attribute.cs (Attribute.Resolve): ditto.
30827 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30829 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30831 * expression.cs (ParameterReference): Drop IStackStorage and implement
30832 IAssignMethod instead.
30834 (LocalVariableReference): ditto.
30836 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30837 IAssignMethod instead.
30839 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30841 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30842 enumerations that are used in heavily used structures derive from
30843 byte in a laughable and pathetic attempt to reduce memory usage.
30844 This is the kind of pre-optimzations that you should not do at
30845 home without adult supervision.
30847 * expression.cs (UnaryMutator): New class, used to handle ++ and
30848 -- separatedly from the other unary operators. Cleans up the
30849 code, and kills the ExpressionStatement dependency in Unary.
30851 (Unary): Removed `method' and `Arguments' from this class, making
30852 it smaller, and moving it all to SimpleCall, so I can reuse this
30853 code in other locations and avoid creating a lot of transient data
30854 strucutres when not required.
30856 * cs-parser.jay: Adjust for new changes.
30858 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30860 * enum.cs (Enum.Populate): If there is a failure during
30863 * cs-parser.jay (opt_enum_base): we used to catch type errors
30864 here, but this is really incorrect. The type error should be
30865 catched during semantic analysis.
30867 2001-12-11 Ravi Pratap <ravi@ximian.com>
30869 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30870 current_local_parameters as expected since I, in my stupidity, had forgotten
30873 * attribute.cs (GetValidPlaces): Fix stupid bug.
30875 * class.cs (Method::Emit): Perform check on applicability of attributes.
30877 (Constructor::Emit): Ditto.
30879 (Field::Emit): Ditto.
30881 (Field.Location): Store location information.
30883 (Property, Event, Indexer, Operator): Ditto.
30885 * cs-parser.jay (field_declaration): Pass in location for each field.
30887 * ../errors/cs0592.cs : Add.
30889 2001-11-12 Ravi Pratap <ravi@ximian.com>
30891 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30893 (InitCoreTypes): Update accordingly.
30895 (RegisterAttrType, LookupAttr): Implement.
30897 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30898 info about the same.
30900 (Resolve): Update to populate the above as necessary.
30902 (Error592): Helper.
30904 (GetValidPlaces): Helper to the above.
30906 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30908 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30910 2001-11-12 Ravi Pratap <ravi@ximian.com>
30912 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30914 * ../errors/cs0617.cs : Add.
30916 2001-11-11 Ravi Pratap <ravi@ximian.com>
30918 * enum.cs (Emit): Rename to Populate to be more consistent with what
30919 we expect it to do and when exactly it is called.
30921 * class.cs, rootcontext.cs : Update accordingly.
30923 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30924 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30926 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30928 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30929 of a fieldinfo using the above, when dealing with a FieldBuilder.
30931 2001-11-10 Ravi Pratap <ravi@ximian.com>
30933 * ../errors/cs0031.cs : Add.
30935 * ../errors/cs1008.cs : Add.
30937 * ../errrors/cs0543.cs : Add.
30939 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30942 (FindMembers): Implement.
30944 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30945 enums and delegates too.
30947 (enum_types): Rename to builder_to_enum.
30949 (delegate_types): Rename to builder_to_delegate.
30951 * delegate.cs (FindMembers): Implement.
30953 2001-11-09 Ravi Pratap <ravi@ximian.com>
30955 * typemanager.cs (IsEnumType): Implement.
30957 * enum.cs (Emit): Re-write parts to account for the underlying type
30958 better and perform checking etc.
30960 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30961 of the underlying type.
30963 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30966 * enum.cs (error31): Helper to report error #31.
30968 * cs-parser.jay (enum_declaration): Store location of each member too.
30970 * enum.cs (member_to_location): New hashtable.
30972 (AddEnumMember): Update location hashtable.
30974 (Emit): Use the location of each member while reporting errors.
30976 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30978 * cs-parser.jay: A for_initializer if is a
30979 local_variable_declaration really ammount to have an implicit
30980 block with the variable declaration and no initializer for for.
30982 * statement.cs (For.Emit): Cope with null initializers.
30984 This fixes the infinite loop on for initializers.
30986 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30988 * enum.cs: More cleanup.
30990 * ecore.cs: Remove dead code.
30992 * class.cs (Property.Emit): More simplification.
30993 (Event.Emit): ditto.
30995 Reworked to have less levels of indentation.
30997 2001-11-08 Ravi Pratap <ravi@ximian.com>
30999 * class.cs (Property): Emit attributes.
31009 * enum.cs (Emit): Ditto.
31011 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
31014 * class.cs (Field, Event, etc.): Move attribute generation into the
31015 Emit method everywhere.
31017 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
31018 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
31019 as we had no way of defining nested enums !
31021 * rootcontext.cs : Adjust code accordingly.
31023 * typemanager.cs (AddEnumType): To keep track of enum types separately.
31025 2001-11-07 Ravi Pratap <ravi@ximian.com>
31027 * expression.cs (EvalConstantExpression): Move into ecore.cs
31029 * enum.cs (Enum): Rename some members and make them public and readonly
31030 according to our convention.
31032 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
31035 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
31037 (Enum::Emit): Write a simple version for now which doesn't try to compute
31038 expressions. I shall modify this to be more robust in just a while.
31040 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
31042 (TypeContainer::CloseType): Create the Enum types too.
31044 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
31046 * expression.cs (EvalConstantExpression): Get rid of completely.
31048 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
31049 user-defined values and other cases.
31051 (IsValidEnumLiteral): Helper function.
31053 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
31054 out there in the case we had a literal FieldExpr.
31056 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
31058 (Literalize): Revamp a bit to take two arguments.
31060 (EnumLiteral): New class which derives from Literal to wrap enum literals.
31062 2001-11-06 Ravi Pratap <ravi@ximian.com>
31064 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
31066 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
31068 (Resolve): Use the above to ensure we have proper initializers.
31070 2001-11-05 Ravi Pratap <ravi@ximian.com>
31072 * expression.cs (Expression::EvalConstantExpression): New method to
31073 evaluate constant expressions.
31075 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
31077 2001-11-07 Miguel de Icaza <miguel@ximian.com>
31079 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
31082 (Binary.ResolveOperator): Handle operator != (object a, object b)
31083 and operator == (object a, object b);
31085 (Binary.DoNumericPromotions): Indicate whether the numeric
31086 promotion was possible.
31088 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
31091 Made the ArrayAccess implement interface IAssignMethod instead of
31092 IStackStore as the order in which arguments are passed reflects
31095 * assign.cs: Instead of using expr.ExprClass to select the way of
31096 assinging, probe for the IStackStore/IAssignMethod interfaces.
31098 * typemanager.cs: Load InitializeArray definition.
31100 * rootcontext.cs (RootContext.MakeStaticData): Used to define
31101 static data that can be used to initialize arrays.
31103 2001-11-05 Miguel de Icaza <miguel@ximian.com>
31105 * expression.cs: Handle operator== and operator!= for booleans.
31107 (Conditioal.Reduce): Implement reducer for the ?: operator.
31109 (Conditional.Resolve): Implement dead code elimination.
31111 (Binary.Resolve): Catch string literals and return a new
31112 concatenated string.
31114 (Unary.Reduce): Implement reduction of unary expressions.
31116 * ecore.cs: Split out the expression core handling here.
31118 (Expression.Reduce): New method used to perform constant folding
31119 and CSE. This is needed to support constant-expressions.
31121 * statement.cs (Statement.EmitBoolExpression): Pass true and false
31122 targets, and optimize for !x.
31124 2001-11-04 Ravi Pratap <ravi@ximian.com>
31126 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
31127 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
31128 set custom atttributes.
31130 * literal.cs (Literal::GetValue): New abstract method to return the actual
31131 value of the literal, cast as an object.
31133 (*Literal): Implement GetValue method.
31135 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
31136 expressions to the arraylist but objects of type Argument.
31138 * class.cs (TypeContainer::Emit): Emit our attributes too.
31140 (Method::Emit, Constructor::Emit): Ditto.
31142 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
31143 to be ignoring earlier.
31145 2001-11-03 Ravi Pratap <ravi@ximian.com>
31147 * attribute.cs (AttributeSection::Define): Implement to do the business
31148 of constructing a CustomAttributeBuilder.
31150 (Attribute): New trivial class. Increases readability of code.
31152 * cs-parser.jay : Update accordingly.
31154 (positional_argument_list, named_argument_list, named_argument): New rules
31156 (attribute_arguments): Use the above so that we are more correct.
31158 2001-11-02 Ravi Pratap <ravi@ximian.com>
31160 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
31161 to perform all checks for a method with a params parameter.
31163 (Invocation::OverloadResolve): Update to use the above method and therefore
31164 cope correctly with params method invocations.
31166 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
31169 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
31170 constructors in our parent too because we can't afford to miss out on
31173 * attribute.cs (AttributeSection): New name for the class Attribute
31175 Other trivial changes to improve readability.
31177 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
31178 use the new class names.
31180 2001-11-01 Ravi Pratap <ravi@ximian.com>
31182 * class.cs (Method::Define): Complete definition for params types too
31184 (Indexer::Define): Ditto.
31186 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
31187 Cope everywhere with a request for info about the array parameter.
31189 2001-11-01 Ravi Pratap <ravi@ximian.com>
31191 * tree.cs (RecordNamespace): Fix up to check for the correct key.
31193 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
31194 local_variable_type to extract the string corresponding to the type.
31196 (local_variable_type): Fixup the action to use the new helper method.
31198 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
31201 * expression.cs : Clean out code which uses the above.
31203 2001-10-31 Ravi Pratap <ravi@ximian.com>
31205 * typemanager.cs (RegisterMethod): Check if we already have an existing key
31206 and bale out if necessary by returning a false.
31208 (RegisterProperty): Ditto.
31210 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
31211 and print out appropriate error messages.
31213 * interface.cs (everywhere): Ditto.
31215 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
31216 location to constructor.
31218 * class.cs (Property, Event, Indexer): Update accordingly.
31220 * ../errors/cs111.cs : Added.
31222 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
31223 of a method, as laid down by the spec.
31225 (Invocation::OverloadResolve): Use the above method.
31227 2001-10-31 Ravi Pratap <ravi@ximian.com>
31229 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
31230 now take a TypeContainer and a Parameters object.
31232 (ParameterData): Modify return type of ParameterModifier method to be
31233 Parameter.Modifier and not a string.
31235 (ReflectionParameters, InternalParameters): Update accordingly.
31237 * expression.cs (Argument::GetParameterModifier): Same here.
31239 * support.cs (InternalParameters::ParameterType): Find a better way of determining
31240 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
31241 symbol in it at all so maybe this is only for now.
31243 2001-10-30 Ravi Pratap <ravi@ximian.com>
31245 * support.cs (InternalParameters): Constructor now takes an extra argument
31246 which is the actual Parameters class.
31248 (ParameterDesc): Update to provide info on ref/out modifiers.
31250 * class.cs (everywhere): Update call to InternalParameters to pass in
31251 the second argument too.
31253 * support.cs (ParameterData): Add ParameterModifier, which is a method
31254 to return the modifier info [ref/out etc]
31256 (InternalParameters, ReflectionParameters): Implement the above.
31258 * expression.cs (Argument::ParameterModifier): Similar function to return
31259 info about the argument's modifiers.
31261 (Invocation::OverloadResolve): Update to take into account matching modifiers
31264 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
31265 a new SetFormalParameters object which we pass to InternalParameters.
31267 2001-10-30 Ravi Pratap <ravi@ximian.com>
31269 * expression.cs (NewArray): Merge into the ArrayCreation class.
31271 2001-10-29 Ravi Pratap <ravi@ximian.com>
31273 * expression.cs (NewArray): Merge classes NewBuiltinArray and
31274 NewUserdefinedArray into one as there wasn't much of a use in having
31277 * expression.cs (Argument): Change field's name to ArgType from Type.
31279 (Type): New readonly property which returns the proper type, taking into
31280 account ref/out modifiers.
31282 (everywhere): Adjust code accordingly for the above.
31284 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
31285 whether we are emitting for a ref or out parameter.
31287 * expression.cs (Argument::Emit): Use the above field to set the state.
31289 (LocalVariableReference::Emit): Update to honour the flag and emit the
31292 * parameter.cs (Attributes): Set the correct flags for ref parameters.
31294 * expression.cs (Argument::FullDesc): New function to provide a full desc.
31296 * support.cs (ParameterData): Add method ParameterDesc to the interface.
31298 (ReflectionParameters, InternalParameters): Implement the above method.
31300 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
31303 (Invocation::FullMethodDesc): Ditto.
31305 2001-10-29 Miguel de Icaza <miguel@ximian.com>
31307 * cs-parser.jay: Add extra production for the second form of array
31310 * expression.cs (ArrayCreation): Update to reflect the above
31313 * Small changes to prepare for Array initialization.
31315 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31317 * typemanager.cs (ImplementsInterface): interface might be null;
31318 Deal with this problem;
31320 Also, we do store negative hits on the cache (null values), so use
31321 this instead of calling t.GetInterfaces on the type everytime.
31323 2001-10-28 Ravi Pratap <ravi@ximian.com>
31325 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31327 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31328 split functionality out into different classes.
31330 (New::FormArrayType): Move into NewBuiltinArray.
31332 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31335 (NewBuiltinArray): New class to handle creation of built-in arrays.
31337 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31338 account creation of one-dimensional arrays.
31340 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31342 (NewUserdefinedArray::DoResolve): Implement.
31344 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31346 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31347 we maintain inside the TypeManager. This is necessary to perform lookups on the
31350 (LookupType): Update to perform GetType on the module builders too.
31352 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31354 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31356 2001-10-23 Ravi Pratap <ravi@ximian.com>
31358 * expression.cs (New::DoResolve): Implement guts of array creation.
31360 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31362 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31364 * expression.cs: Fix bug I introduced lsat night that broke
31367 (Expression.Resolve): Report a 246 error (can not resolve name)
31368 if we find a SimpleName in the stream.
31370 (Expression.ResolveLValue): Ditto.
31372 (Expression.ResolveWithSimpleName): This function is a variant of
31373 ResolveName, this one allows SimpleNames to be returned without a
31374 warning. The only consumer of SimpleNames is MemberAccess
31376 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31378 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31379 might arrive here. I have my doubts that this is correct.
31381 * statement.cs (Lock): Implement lock statement.
31383 * cs-parser.jay: Small fixes to support `lock' and `using'
31385 * cs-tokenizer.cs: Remove extra space
31387 * driver.cs: New flag --checked, allows to turn on integer math
31390 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31391 Threading.Monitor.Exit
31393 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31395 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31396 Expression Class to be IndexerAccess.
31398 Notice that Indexer::DoResolve sets the eclass to Value.
31400 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31402 * class.cs (TypeContainer::Emit): Emit code for indexers.
31404 * assign.cs (IAssignMethod): New interface implemented by Indexers
31405 and Properties for handling assignment.
31407 (Assign::Emit): Simplify and reuse code.
31409 * expression.cs (IndexerAccess, PropertyExpr): Implement
31410 IAssignMethod, clean up old code.
31412 2001-10-22 Ravi Pratap <ravi@ximian.com>
31414 * typemanager.cs (ImplementsInterface): New method to determine if a type
31415 implements a given interface. Provides a nice cache too.
31417 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31420 (ConvertReferenceExplicit): Ditto.
31422 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31423 various methods, with correct names etc.
31425 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31426 Operator.UnaryNegation.
31428 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31429 we have a unary plus or minus operator.
31431 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31434 * everywhere : update accordingly.
31436 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31439 * class.cs (Method::Define): For the case where we are implementing a method
31440 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31441 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31443 2001-10-21 Ravi Pratap <ravi@ximian.com>
31445 * interface.cs (FindMembers): Implement to work around S.R.E
31448 * typemanager.cs (IsInterfaceType): Implement.
31450 (FindMembers): Update to handle interface types too.
31452 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31453 use IsAssignableFrom as that is not correct - it doesn't work.
31455 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31456 and accordingly override EmitStatement.
31458 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31459 using the correct logic :-)
31461 2001-10-19 Ravi Pratap <ravi@ximian.com>
31463 * ../errors/cs-11.cs : Add to demonstrate error -11
31465 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31467 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31468 then pass this as a hint to ResolveLValue.
31470 * expression.cs (FieldExpr): Add Location information
31472 (FieldExpr::LValueResolve): Report assignment to readonly
31475 (Expression::ExprClassFromMemberInfo): Pass location information.
31477 (Expression::ResolveLValue): Add new method that resolves an
31480 (Expression::DoResolveLValue): Default invocation calls
31483 (Indexers): New class used to keep track of indexers in a given
31486 (IStackStore): Renamed from LValue, as it did not really describe
31487 what this did. Also ResolveLValue is gone from this interface and
31488 now is part of Expression.
31490 (ElementAccess): Depending on the element access type
31492 * typemanager.cs: Add `indexer_name_type' as a Core type
31493 (System.Runtime.CompilerServices.IndexerNameAttribute)
31495 * statement.cs (Goto): Take a location.
31497 2001-10-18 Ravi Pratap <ravi@ximian.com>
31499 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31500 if two delegates are compatible.
31502 (NewDelegate::DoResolve): Update to take care of the case when
31503 we instantiate a delegate from another delegate.
31505 * typemanager.cs (FindMembers): Don't even try to look up members
31506 of Delegate types for now.
31508 2001-10-18 Ravi Pratap <ravi@ximian.com>
31510 * delegate.cs (NewDelegate): New class to take care of delegate
31513 * expression.cs (New): Split the delegate related code out into
31514 the NewDelegate class.
31516 * delegate.cs (DelegateInvocation): New class to handle delegate
31519 * expression.cs (Invocation): Split out delegate related code into
31520 the DelegateInvocation class.
31522 2001-10-17 Ravi Pratap <ravi@ximian.com>
31524 * expression.cs (New::DoResolve): Implement delegate creation fully
31525 and according to the spec.
31527 (New::DoEmit): Update to handle delegates differently.
31529 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31530 because of which we were printing out arguments in reverse order !
31532 * delegate.cs (VerifyMethod): Implement to check if the given method
31533 matches the delegate.
31535 (FullDelegateDesc): Implement.
31537 (VerifyApplicability): Implement.
31539 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31540 delegate invocations too.
31542 (Invocation::Emit): Ditto.
31544 * ../errors/cs1593.cs : Added.
31546 * ../errors/cs1594.cs : Added.
31548 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31550 2001-10-16 Ravi Pratap <ravi@ximian.com>
31552 * typemanager.cs (intptr_type): Core type for System.IntPtr
31554 (InitCoreTypes): Update for the same.
31556 (iasyncresult_type, asynccallback_type): Ditto.
31558 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31561 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31564 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31565 the builders for the 4 members of a delegate type :-)
31567 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31570 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31572 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31574 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31576 * statement.cs (Break::Emit): Implement.
31577 (Continue::Emit): Implement.
31579 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31580 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31581 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31582 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31585 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31586 properties that track the label for the current loop (begin of the
31587 loop and end of the loop).
31589 2001-10-15 Ravi Pratap <ravi@ximian.com>
31591 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31592 use of emitting anything at all.
31594 * class.cs, rootcontext.cs : Get rid of calls to the same.
31596 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31598 (Populate): Define the constructor correctly and set the implementation
31601 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31604 (AddDelegateType): Implement.
31606 (IsDelegateType): Implement helper method.
31608 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31610 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31611 and accordingly handle it.
31613 * delegate.cs (Populate): Take TypeContainer argument.
31614 Implement bits to define the Invoke method. However, I still haven't figured out
31615 how to take care of the native int bit :-(
31617 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31618 Qualify the name of the delegate, not its return type !
31620 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31623 (StandardConversionExists): Checking for array types turns out to be recursive.
31625 (ConvertReferenceExplicit): Implement array conversion.
31627 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31629 2001-10-12 Ravi Pratap <ravi@ximian.com>
31631 * cs-parser.jay (delegate_declaration): Store the fully qualified
31632 name as it is a type declaration.
31634 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31637 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31638 as TypeContainer::DefineType.
31640 (Populate): Method in which all the definition of the various methods (Invoke)
31643 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31646 (CloseDelegate): Finally creates the delegate.
31648 * class.cs (TypeContainer::DefineType): Update to define delegates.
31649 (Populate, Emit and CloseType): Do the same thing here too.
31651 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31652 delegates in all these operations.
31654 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31656 * expression.cs: LocalTemporary: a new expression used to
31657 reference a temporary that has been created.
31659 * assign.cs: Handle PropertyAccess back here, so that we can
31660 provide the proper semantic access to properties.
31662 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31663 a few more explicit conversions.
31665 * modifiers.cs: `NEW' modifier maps to HideBySig.
31667 * expression.cs (PropertyExpr): Make this into an
31668 ExpressionStatement, and support the EmitStatement code path.
31670 Perform get/set error checking, clean up the interface.
31672 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31673 them into toplevel access objects.
31675 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31677 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31680 * typemanager.cs: Keep track here of our PropertyBuilders again to
31681 work around lameness in SRE.
31683 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31685 * expression.cs (LValue::LValueResolve): New method in the
31686 interface, used to perform a second resolution pass for LValues.
31688 (This::DoResolve): Catch the use of this in static methods.
31690 (This::LValueResolve): Implement.
31692 (This::Store): Remove warning, assigning to `this' in structures
31695 (Invocation::Emit): Deal with invocation of
31696 methods on value types. We need to pass the address to structure
31697 methods rather than the object itself. (The equivalent code to
31698 emit "this" for structures leaves the entire structure on the
31699 stack instead of a pointer to it).
31701 (ParameterReference::DoResolve): Compute the real index for the
31702 argument based on whether the method takes or not a `this' pointer
31703 (ie, the method is static).
31705 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31706 value types returned from functions when we need to invoke a
31707 method on the sturcture.
31710 2001-10-11 Ravi Pratap <ravi@ximian.com>
31712 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31713 defining the type in the Modulebuilder or Typebuilder. This is to take
31714 care of nested types which need to be defined on the TypeBuilder using
31715 DefineNestedMethod.
31717 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31718 methods in RootContext, only ported to be part of TypeContainer.
31720 (TypeContainer::GetInterfaceOrClass): Ditto.
31722 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31724 * interface.cs (Interface::DefineInterface): New method. Does exactly
31725 what RootContext.CreateInterface did earlier, only it takes care of nested types
31728 (Interface::GetInterfaces): Move from RootContext here and port.
31730 (Interface::GetInterfaceByName): Same here.
31732 * rootcontext.cs (ResolveTree): Re-write.
31734 (PopulateTypes): Re-write.
31736 * class.cs (TypeContainer::Populate): Populate nested types too.
31737 (TypeContainer::Emit): Emit nested members too.
31739 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31740 instead just use the name argument passed in as it is already fully
31743 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31744 to TypeContainer mapping to see if a type is user-defined.
31746 * class.cs (TypeContainer::CloseType): Implement.
31748 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31749 the default constructor.
31751 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31754 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31756 * interface.cs (CloseType): Create the type here.
31758 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31761 Remove all the methods which are now in TypeContainer.
31763 2001-10-10 Ravi Pratap <ravi@ximian.com>
31765 * delegate.cs (Define): Re-write bits to define the delegate
31768 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31770 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31772 * expression.cs (ImplicitReferenceConversion): handle null as well
31773 as a source to convert to any reference type.
31775 * statement.cs (Return): Perform any implicit conversions to
31776 expected return type.
31778 Validate use of return statement.
31780 * codegen.cs (EmitContext): Pass the expected return type here.
31782 * class.cs (Method, Constructor, Property): Pass expected return
31783 type to EmitContext.
31785 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31787 * expression.cs: Make DoResolve take an EmitContext instead of a
31790 Replaced `l' and `location' for `loc', for consistency.
31792 (Error, Warning): Remove unneeded Tc argument.
31794 * assign.cs, literal.cs, constant.cs: Update to new calling
31797 * codegen.cs: EmitContext now contains a flag indicating whether
31798 code is being generated in a static method or not.
31800 * cs-parser.jay: DecomposeQI, new function that replaces the old
31801 QualifiedIdentifier. Now we always decompose the assembled
31802 strings from qualified_identifier productions into a group of
31805 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31807 * rootcontext.cs: Deal with field-less struct types correctly now
31808 by passing the size option to Define Type.
31810 * class.cs: Removed hack that created one static field.
31812 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31814 * statement.cs: Moved most of the code generation here.
31816 2001-10-09 Ravi Pratap <ravi@ximian.com>
31818 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31821 (ElementAccess): Remove useless bits for now - keep checks as the spec
31824 2001-10-08 Ravi Pratap <ravi@ximian.com>
31826 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31827 and start performing checks according to the spec.
31829 2001-10-07 Ravi Pratap <ravi@ximian.com>
31831 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31832 rank_specifiers instead.
31834 (rank_specifiers): Change the order in which the rank specifiers are stored
31836 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31838 * expression.cs (ElementAccess): Implement the LValue interface too.
31840 2001-10-06 Ravi Pratap <ravi@ximian.com>
31842 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31843 except that user defined conversions are not included.
31845 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31846 perform the conversion of the return type, if necessary.
31848 (New::DoResolve): Check whether we are creating an array or an object
31849 and accordingly do the needful.
31851 (New::Emit): Same here.
31853 (New::DoResolve): Implement guts of array creation.
31855 (New::FormLookupType): Helper function.
31857 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31859 * codegen.cs: Removed most of the code generation here, and move the
31860 corresponding code generation bits to the statement classes.
31862 Added support for try/catch/finalize and throw.
31864 * cs-parser.jay: Added support for try/catch/finalize.
31866 * class.cs: Catch static methods having the flags override,
31867 virtual or abstract.
31869 * expression.cs (UserCast): This user cast was not really doing
31870 what it was supposed to do. Which is to be born in fully resolved
31871 state. Parts of the resolution were being performed at Emit time!
31875 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31877 * expression.cs: Implicity convert the result from UserCast.
31879 2001-10-05 Ravi Pratap <ravi@ximian.com>
31881 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31882 prevented it from working correctly.
31884 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31885 merely ConvertImplicit.
31887 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31889 * typemanager.cs: Make the LookupTypeContainer function static,
31890 and not per-instance.
31892 * class.cs: Make static FindMembers (the one that takes a Type
31895 * codegen.cs: Add EmitForeach here.
31897 * cs-parser.jay: Make foreach a toplevel object instead of the
31898 inline expansion, as we need to perform semantic analysis on it.
31900 2001-10-05 Ravi Pratap <ravi@ximian.com>
31902 * expression.cs (Expression::ImplicitUserConversion): Rename to
31903 UserDefinedConversion.
31905 (Expression::UserDefinedConversion): Take an extra argument specifying
31906 whether we look for explicit user conversions too.
31908 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31910 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31912 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31913 with the appropriate arguments.
31915 * cs-parser.jay (cast_expression): Record location too.
31917 * expression.cs (Cast): Record location info.
31919 (Expression::ConvertExplicit): Take location argument.
31921 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31922 to determine if we are doing explicit conversions.
31924 (UserCast::Emit): Update accordingly.
31926 (Expression::ConvertExplicit): Report an error if everything fails.
31928 * ../errors/cs0030.cs : Add.
31930 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31932 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31933 virtual and newslot bits.
31935 * class.cs (TypeContainer::RegisterRequiredImplementations):
31936 Record methods we need.
31938 (TypeContainer::MakeKey): Helper function to make keys for
31939 MethodBases, since the Methodbase key is useless.
31941 (TypeContainer::Populate): Call RegisterRequiredImplementations
31942 before defining the methods.
31944 Create a mapping for method_builders_to_methods ahead of time
31945 instead of inside a tight loop.
31947 (::RequireMethods): Accept an object as the data to set into the
31948 hashtable so we can report interface vs abstract method mismatch.
31950 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31952 * report.cs: Make all of it static.
31954 * rootcontext.cs: Drop object_type and value_type computations, as
31955 we have those in the TypeManager anyways.
31957 Drop report instance variable too, now it is a global.
31959 * driver.cs: Use try/catch on command line handling.
31961 Add --probe option to debug the error reporting system with a test
31964 * report.cs: Add support for exiting program when a probe
31965 condition is reached.
31967 2001-10-03 Ravi Pratap <ravi@ximian.com>
31969 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31970 we do a forcible conversion regardless of type, to check if
31971 ForceConversion returns a null.
31973 (Binary::error19): Use location to report error.
31975 (Unary::error23): Use location here too.
31977 * ../errors/cs0019.cs : Check in.
31979 * ../errors/cs0023.cs : Check in.
31981 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31982 case of a non-null MethodInfo object with a length of 0 !
31984 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31985 an applicable member - according to the spec :-)
31986 Also fix logic to find members in base types.
31988 (Unary::ResolveOperator): Same here.
31990 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31991 as I was getting thoroughly confused between this and error19 :-)
31993 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31994 (::FindMostEncompassedType): Implement.
31995 (::FindMostEncompassingType): Implement.
31996 (::StandardConversionExists): Implement.
31998 (UserImplicitCast): Re-vamp. We now need info about most specific
31999 source and target types so that we can do the necessary conversions.
32001 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
32002 mathematical union with no duplicates.
32004 2001-10-03 Miguel de Icaza <miguel@ximian.com>
32006 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
32007 in order from base classes to child classes, so that we can in
32008 child classes look up in our parent for method names and
32009 attributes (required for handling abstract, virtual, new, override
32010 constructs: we need to instrospect our base class, and if we dont
32011 populate the classes in order, the introspection might be
32012 incorrect. For example, a method could query its parent before
32013 the parent has any methods and would determine that the parent has
32014 no abstract methods (while it could have had them)).
32016 (RootContext::CreateType): Record the order in which we define the
32019 2001-10-02 Miguel de Icaza <miguel@ximian.com>
32021 * class.cs (TypeContainer::Populate): Also method definitions can
32022 fail now, keep track of this.
32024 (TypeContainer::FindMembers): Implement support for
32025 DeclaredOnly/noDeclaredOnly flag.
32027 (Constructor::Emit) Return the ConstructorBuilder.
32029 (Method::Emit) Return the MethodBuilder.
32030 Check for abstract or virtual methods to be public.
32032 * rootcontext.cs (RootContext::CreateType): Register all the
32033 abstract methods required for the class to be complete and the
32034 interface methods that must be implemented.
32036 * cs-parser.jay: Report error 501 (method requires body if it is
32037 not marked abstract or extern).
32039 * expression.cs (TypeOf::Emit): Implement.
32041 * typemanager.cs: runtime_handle_type, new global type.
32043 * class.cs (Property::Emit): Generate code for properties.
32045 2001-10-02 Ravi Pratap <ravi@ximian.com>
32047 * expression.cs (Unary::ResolveOperator): Find operators on base type
32048 too - we now conform exactly to the spec.
32050 (Binary::ResolveOperator): Same here.
32052 * class.cs (Operator::Define): Fix minor quirk in the tests.
32054 * ../errors/cs0215.cs : Added.
32056 * ../errors/cs0556.cs : Added.
32058 * ../errors/cs0555.cs : Added.
32060 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32062 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
32063 single integer which is really efficient
32065 2001-10-01 Ravi Pratap <ravi@ximian.com>
32067 * expression.cs (Expression::ImplicitUserConversion): Use location
32068 even in the case when we are examining True operators.
32070 * class.cs (Operator::Define): Perform extensive checks to conform
32071 with the rules for operator overloading in the spec.
32073 * expression.cs (Expression::ImplicitReferenceConversion): Implement
32074 some of the other conversions mentioned in the spec.
32076 * typemanager.cs (array_type): New static member for the System.Array built-in
32079 (cloneable_interface): For System.ICloneable interface.
32081 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
32082 we start resolving the tree and populating types.
32084 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
32086 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32088 * expression.cs (Expression::ExprClassFromMemberInfo,
32089 Expression::Literalize): Create literal expressions from
32090 FieldInfos which are literals.
32092 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
32093 type casts, because they were wrong. The test suite in tests
32096 (ImplicitNumericConversion): ushort to ulong requires a widening
32099 Int32 constant to long requires widening cast as well.
32101 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
32102 for integers because the type on the stack is not i4.
32104 2001-09-30 Miguel de Icaza <miguel@ximian.com>
32106 * expression.cs (report118): require location argument.
32108 * parameter.cs: Do not dereference potential null value.
32110 * class.cs: Catch methods that lack the `new' keyword when
32111 overriding a name. Report warnings when `new' is used without
32112 anything being there to override.
32114 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
32116 * class.cs: Only add constructor to hashtable if it is non-null
32117 (as now constructors can fail on define).
32119 (TypeManager, Class, Struct): Take location arguments.
32121 Catch field instance initialization in structs as errors.
32123 accepting_filter: a new filter for FindMembers that is static so
32124 that we dont create an instance per invocation.
32126 (Constructor::Define): Catch errors where a struct constructor is
32129 * cs-parser.jay: Pass location information for various new
32132 * delegate.cs (Delegate): take a location argument.
32134 * driver.cs: Do not call EmitCode if there were problesm in the
32135 Definition of the types, as many Builders wont be there.
32137 * decl.cs (Decl::Decl): Require a location argument.
32139 * cs-tokenizer.cs: Handle properly hex constants that can not fit
32140 into integers, and find the most appropiate integer for it.
32142 * literal.cs: Implement ULongLiteral.
32144 * rootcontext.cs: Provide better information about the location of
32145 failure when CreateType fails.
32147 2001-09-29 Miguel de Icaza <miguel@ximian.com>
32149 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
32152 * expression.cs (Binary::CheckShiftArguments): Add missing type
32154 (Binary::ResolveOperator): Add type to the logical and and logical
32155 or, Bitwise And/Or and Exclusive Or code paths, it was missing
32158 (Binary::DoNumericPromotions): In the case where either argument
32159 is ulong (and most signed types combined with ulong cause an
32160 error) perform implicit integer constant conversions as well.
32162 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32164 * expression.cs (UserImplicitCast): Method should always be
32166 (Invocation::BetterConversion): Simplified test for IntLiteral.
32168 (Expression::ImplicitNumericConversion): Split this routine out.
32169 Put the code that performs implicit constant integer conversions
32172 (Expression::Resolve): Become a wrapper around DoResolve so we can
32173 check eclass and type being set after resolve.
32175 (Invocation::Badness): Remove this dead function
32177 (Binary::ResolveOperator): Do not compute the expensive argumnets
32178 unless we have a union for it.
32180 (Probe::Emit): Is needs to do an isinst and then
32181 compare against null.
32183 (::CanConvert): Added Location argument. If the Location argument
32184 is null (Location.Null), then we do not report errors. This is
32185 used by the `probe' mechanism of the Explicit conversion. We do
32186 not want to generate an error for something that the user
32187 explicitly requested to be casted. But the pipeline for an
32188 explicit cast first tests for potential implicit casts.
32190 So for now, if the Location is null, it means `Probe only' to
32191 avoid adding another argument. Might have to revise this
32194 (ClassCast): New class used to type cast objects into arbitrary
32195 classes (used in Explicit Reference Conversions).
32197 Implement `as' as well.
32199 Reverted all the patches from Ravi below: they were broken:
32201 * The use of `level' as a mechanism to stop recursive
32202 invocations is wrong. That was there just to catch the
32203 bug with a strack trace but not as a way of addressing
32206 To fix the problem we have to *understand* what is going
32207 on and the interactions and come up with a plan, not
32208 just get things going.
32210 * The use of the type conversion cache that I proposed
32211 last night had an open topic: How does this work across
32212 protection domains. A user defined conversion might not
32213 be public in the location where we are applying the
32214 conversion, a different conversion might be selected
32215 (ie, private A->B (better) but public B->A (worse),
32216 inside A, A->B applies, but outside it, B->A will
32219 * On top of that (ie, even if the above is solved),
32220 conversions in a cache need to be abstract. Ie, `To
32221 convert from an Int to a Short use an OpcodeCast', not
32222 `To convert from an Int to a Short use the OpcodeCast on
32223 the variable 5' (which is what this patch was doing).
32225 2001-09-28 Ravi Pratap <ravi@ximian.com>
32227 * expression.cs (Invocation::ConversionExists): Re-write to use
32228 the conversion cache
32230 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
32231 cache all conversions done, not just user-defined ones.
32233 (Invocation::BetterConversion): The real culprit. Use ConversionExists
32234 to determine if a conversion exists instead of acutually trying to
32235 perform the conversion. It's faster too.
32237 (Expression::ConvertExplicit): Modify to use ConversionExists to check
32238 and only then attempt the implicit conversion.
32240 2001-09-28 Ravi Pratap <ravi@ximian.com>
32242 * expression.cs (ConvertImplicit): Use a cache for conversions
32243 already found. Check level of recursion and bail out if necessary.
32245 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32247 * typemanager.cs (string_concat_string_string, string_concat_object_object):
32248 Export standard methods that we expect for string operations.
32250 * statement.cs (Block::UsageWarning): Track usage of variables and
32251 report the errors for not used variables.
32253 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
32256 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32258 * codegen.cs: remove unnneded code
32260 * expression.cs: Removed BuiltinTypeAccess class
32262 Fix the order in which implicit conversions are
32265 The previous fixed dropped support for boxed conversions (adding a
32266 test to the test suite now)
32268 (UserImplicitCast::CanConvert): Remove test for source being null,
32269 that code is broken. We should not feed a null to begin with, if
32270 we do, then we should track the bug where the problem originates
32271 and not try to cover it up here.
32273 Return a resolved expression of type UserImplicitCast on success
32274 rather than true/false. Ravi: this is what I was talking about,
32275 the pattern is to use a static method as a "constructor" for
32278 Also, do not create arguments until the very last minute,
32279 otherwise we always create the arguments even for lookups that
32280 will never be performed.
32282 (UserImplicitCast::Resolve): Eliminate, objects of type
32283 UserImplicitCast are born in a fully resolved state.
32285 * typemanager.cs (InitCoreTypes): Init also value_type
32286 (System.ValueType).
32288 * expression.cs (Cast::Resolve): First resolve the child expression.
32290 (LValue): Add new method AddressOf to be used by
32293 Change the argument of Store to take an EmitContext instead of an
32294 ILGenerator, because things like FieldExpr need to be able to call
32295 their children expression to generate the instance code.
32297 (Expression::Error, Expression::Warning): Sugar functions for
32300 (Expression::MemberLookup): Accept a TypeContainer instead of a
32301 Report as the first argument.
32303 (Expression::ResolvePrimary): Killed. I still want to improve
32304 this as currently the code is just not right.
32306 (Expression::ResolveMemberAccess): Simplify, but it is still
32309 (Unary::Resolve): Catch errors in AddressOf operators.
32311 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
32312 index to a byte for the short-version, or the compiler will choose
32313 the wrong Emit call, which generates the wrong data.
32315 (ParameterReference::Emit, ::Store): same.
32317 (FieldExpr::AddressOf): Implement.
32319 * typemanager.cs: TypeManager: made public variable instead of
32322 * driver.cs: document --fatal.
32324 * report.cs (ErrorMessage, WarningMessage): new names for the old
32325 Error and Warning classes.
32327 * cs-parser.jay (member_access): Turn built-in access to types
32328 into a normal simplename
32330 2001-09-27 Ravi Pratap <ravi@ximian.com>
32332 * expression.cs (Invocation::BetterConversion): Fix to cope
32333 with q being null, since this was introducing a bug.
32335 * expression.cs (ConvertImplicit): Do built-in conversions first.
32337 2001-09-27 Ravi Pratap <ravi@ximian.com>
32339 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32341 2001-09-27 Ravi Pratap <ravi@ximian.com>
32343 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32344 I had introduced long ago (what's new ?).
32346 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32347 the work of all the checking.
32348 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32349 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32351 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32352 that is the right way.
32354 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32355 overloading resolution. Use everywhere instead of cutting and pasting code.
32357 (Binary::ResolveOperator): Use MakeUnionSet.
32359 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32360 we have to convert to bool types. Not complete yet.
32362 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32364 * typemanager.cs (TypeManager::CSharpName): support ushort.
32366 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32367 to provide an expression that performsn an implicit constant int
32368 conversion (section 6.1.6).
32369 (Expression::ConvertImplicitRequired): Reworked to include
32370 implicit constant expression conversions.
32372 (Expression::ConvertNumericExplicit): Finished.
32374 (Invocation::Emit): If InstanceExpression is null, then it means
32375 that we perform a call on this.
32377 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32379 * expression.cs (Unary::Emit): Remove some dead code.
32380 (Probe): Implement Resolve and Emit for `is'.
32381 (Expression::ConvertImplicitRequired): Attempt to do constant
32382 expression conversions here. Maybe should be moved to
32383 ConvertImplicit, but I am not sure.
32384 (Expression::ImplicitLongConstantConversionPossible,
32385 Expression::ImplicitIntConstantConversionPossible): New functions
32386 that tell whether is it possible to apply an implicit constant
32387 expression conversion.
32389 (ConvertNumericExplicit): Started work on explicit numeric
32392 * cs-parser.jay: Update operator constants.
32394 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32395 (Parameters::GetSignature): Hook up VerifyArgs here.
32396 (Parameters::VerifyArgs): Verifies that no two arguments have the
32399 * class.cs (Operator): Update the operator names to reflect the
32400 ones that the spec expects (as we are just stringizing the
32403 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32404 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32405 previous usage did only work for our methods.
32406 (Expression::ConvertImplicit): Handle decimal implicit numeric
32407 conversions as well.
32408 (Expression::InternalTypeConstructor): Used to invoke constructors
32409 on internal types for default promotions.
32411 (Unary::Emit): Implement special handling for the pre/post
32412 increment/decrement for overloaded operators, as they need to have
32413 the same semantics as the other operators.
32415 (Binary::ResolveOperator): ditto.
32416 (Invocation::ConversionExists): ditto.
32417 (UserImplicitCast::Resolve): ditto.
32419 2001-09-26 Ravi Pratap <ravi@ximian.com>
32421 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32422 operator, return after emitting body. Regression tests pass again !
32424 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32425 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32426 (Invocation::OverloadResolve): Ditto.
32427 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32429 * everywhere : update calls to the above methods accordingly.
32431 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32433 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32435 * expression.cs (ExpressionStatement): New base class used for
32436 expressions that can appear in statements, so that we can provide
32437 an alternate path to generate expression that do not leave a value
32440 (Expression::Emit, and all the derivatives): We no longer return
32441 whether a value is left on the stack or not. Every expression
32442 after being emitted leaves a single value on the stack.
32444 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32445 facilties of ExpressionStatement if possible.
32447 * cs-parser.jay: Update statement_expression.
32449 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32451 * driver.cs: Change the wording of message
32453 2001-09-25 Ravi Pratap <ravi@ximian.com>
32455 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32456 the type of the expression to the return type of the method if
32457 we have an overloaded operator match ! The regression tests pass again !
32458 (Unary::ResolveOperator): Ditto.
32460 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32461 to find "op_Implicit", not "implicit" ;-)
32462 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32463 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32465 * everywhere : Correct calls to the above accordingly.
32467 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32468 (ConvertImplicit): Do user-defined conversion if it exists.
32470 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32472 * assign.cs: track location.
32473 (Resolve): Use implicit conversions on assignment.
32475 * literal.cs: Oops. Not good, Emit of short access values should
32476 pass (Bytes) or the wrong argument will be selected.
32478 * expression.cs (Unary::Emit): Emit code for -expr.
32480 (Unary::ResolveOperator): Handle `Substract' for non-constants
32481 (substract from zero from the non-constants).
32482 Deal with Doubles as well.
32484 (Expression::ConvertImplicitRequired): New routine that reports an
32485 error if no implicit conversion exists.
32487 (Invocation::OverloadResolve): Store the converted implicit
32488 expressions if we make them
32490 2001-09-24 Ravi Pratap <ravi@ximian.com>
32492 * class.cs (ConstructorInitializer): Take a Location argument.
32493 (ConstructorBaseInitializer): Same here.
32494 (ConstructorThisInitializer): Same here.
32496 * cs-parser.jay : Update all calls accordingly.
32498 * expression.cs (Unary, Binary, New): Take location argument.
32499 Update accordingly everywhere.
32501 * cs-parser.jay : Update all calls to the above to take a location
32504 * class.cs : Ditto.
32506 2001-09-24 Ravi Pratap <ravi@ximian.com>
32508 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32509 (Invocation::BetterConversion): Same here
32510 (Invocation::ConversionExists): Ditto.
32512 (Invocation::ConversionExists): Implement.
32514 2001-09-22 Ravi Pratap <ravi@ximian.com>
32516 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32517 Also take an additional TypeContainer argument.
32519 * All over : Pass in TypeContainer as argument to OverloadResolve.
32521 * typemanager.cs (CSharpName): Update to check for the string type and return
32524 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32527 2001-09-21 Ravi Pratap <ravi@ximian.com>
32529 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32530 (Invocation::BetterFunction): Implement.
32531 (Invocation::BetterConversion): Implement.
32532 (Invocation::ConversionExists): Skeleton, no implementation yet.
32534 Okay, things work fine !
32536 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32538 * typemanager.cs: declare and load enum_type, delegate_type and
32541 * expression.cs (Expression::Emit): Now emit returns a value that
32542 tells whether a value is left on the stack or not. This strategy
32543 might be reveted tomorrow with a mechanism that would address
32544 multiple assignments.
32545 (Expression::report118): Utility routine to report mismatches on
32548 (Unary::Report23): Report impossible type/operator combination
32551 (Unary::IsIncrementableNumber): Whether the type can be
32552 incremented or decremented with add.
32553 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32555 (Unary::ResolveOperator): Implement ++, !, ~,
32557 (Invocation::Emit): Deal with new Emit convetion.
32559 * All Expression derivatives: Updated their Emit method to return
32560 whether they leave values on the stack or not.
32562 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32563 stack for expressions that are statements.
32565 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32567 * expression.cs (LValue): New interface. Must be implemented by
32569 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32572 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32573 interface for generating code, simplifies the code.
32575 2001-09-20 Ravi Pratap <ravi@ximian.com>
32577 * expression.cs (everywhere): Comment out return statements in ::Resolve
32578 methods to avoid the warnings.
32580 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32582 * driver.cs (parse): Report error 2001 if we can not open the
32585 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32588 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32591 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32592 otherwise nested blocks end up with the same index.
32594 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32596 * expression.cs: Instead of having FIXMEs in the Resolve
32597 functions, throw exceptions so it is obvious that we are facing a
32600 * cs-parser.jay (invocation_expression): Pass Location information.
32602 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32603 Use a basename for those routines because .NET does not like paths
32606 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32609 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32611 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32612 are loading the correct data types (throws an exception if not).
32613 (TypeManager::InitCoreTypes): Use CoreLookupType
32615 * expression.cs (Unary::ResolveOperator): return the child
32616 expression for expressions which are just +expr.
32617 (Unary::ResolveOperator): Return negative literals for -LITERAL
32618 expressions (otherwise they are Unary {Literal}).
32619 (Invocation::Badness): Take into account `Implicit constant
32620 expression conversions'.
32622 * literal.cs (LongLiteral): Implement long literal class.
32623 (IntLiteral): export the `Value' of the intliteral.
32625 2001-09-19 Ravi Pratap <ravi@ximian.com>
32627 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32629 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32630 instead of 'Operator'
32632 * expression.cs (Binary::ResolveOperator): Update accordingly.
32633 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32636 * cs-parser.jay (unary_expression): Update to use the new names.
32638 * gen-treedump.cs (GetUnary): Same here.
32640 * expression.cs (Unary::Resolve): Implement.
32641 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32642 operators are found instead of making noise ;-)
32643 (Unary::ResolveOperator): New method to do precisely the same thing which
32644 Binary::ResolveOperator does for Binary expressions.
32645 (Unary.method, .Arguments): Add.
32646 (Unary::OperName): Implement.
32647 (Unary::ForceConversion): Copy and Paste !
32649 * class.cs (Operator::Define): Fix a small bug for the case when we have
32652 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32653 for the inbuilt operators. Only overloading works for now ;-)
32655 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32657 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32658 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32660 * expression.cs (This::Emit): Implement.
32661 (This::Resolve): Implement.
32662 (TypeOf:Resolve): Implement.
32663 (Expression::ResolveSimpleName): Add an implicit this to instance
32665 (MemberAccess::Resolve): Deal with Parameters and Fields.
32666 Bind instance variable to Field expressions.
32667 (FieldExpr::Instance): New field used to track the expression that
32668 represents the object instance.
32669 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32671 (FieldExpr::Emit): Implement.
32673 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32674 the last instruction contains a return opcode to avoid generating
32675 the last `ret' instruction (this generates correct code, and it is
32676 nice to pass the peverify output).
32678 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32679 initializer for static and instance variables.
32680 (Constructor::Emit): Allow initializer to be null in the case of
32681 static constructors. Only emit initializer for instance
32684 (TypeContainer::FindMembers): Return a null array if there are no
32687 Also fix the code for the MemberTypes.Method branch, as it was not
32688 scanning that for operators (or tried to access null variables before).
32690 * assign.cs (Assign::Emit): Handle instance and static fields.
32694 * driver.cs: Stop compilation if there are parse errors.
32696 * cs-parser.jay (constructor_declaration): Provide default base
32697 initializer for non-static constructors.
32698 (constructor_declarator): Do not provide a default base
32699 initializers if none was specified.
32700 Catch the fact that constructors should not have parameters.
32702 * class.cs: Do not emit parent class initializers for static
32703 constructors, that should be flagged as an error.
32705 2001-09-18 Ravi Pratap <ravi@ximian.com>
32707 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32708 Move back code into TypeContainer::Populate.
32710 2001-09-18 Ravi Pratap <ravi@ximian.com>
32712 * class.cs (TypeContainer::AddConstructor): Fix the check to
32713 compare against Name, not Basename.
32714 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32716 * cs-parser.jay : Update accordingly.
32718 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32719 for methods, don't forget to look into the operators too.
32720 (RegisterMethodBuilder): Helper method to take care of this for
32721 methods, constructors and operators.
32722 (Operator::Define): Completely revamp.
32723 (Operator.OperatorMethod, MethodName): New fields.
32724 (TypeContainer::Populate): Move the registering of builders into
32725 RegisterMethodBuilder.
32726 (Operator::Emit): Re-write.
32728 * expression.cs (Binary::Emit): Comment out code path to emit method
32729 invocation stuff for the case when we have a user defined operator. I am
32730 just not able to get it right !
32732 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32734 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32737 (Expression::MemberLookup): Provide a version that allows to
32738 specify the MemberTypes and BindingFlags.
32740 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32741 so it was not fetching variable information from outer blocks.
32743 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32744 Beforefieldinit as it was buggy.
32746 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32747 that Ravi put here.
32749 * class.cs (Constructor::Emit): Only emit if block is not null.
32750 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32751 deal with this by semantically definining it as if the user had
32754 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32755 constructors as we now "emit" them at a higher level.
32757 (TypeContainer::DefineDefaultConstructor): Used to define the
32758 default constructors if none was provided.
32760 (ConstructorInitializer): Add methods Resolve and Emit.
32762 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32764 2001-09-17 Ravi Pratap <ravi@ximian.com>
32766 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32767 the default constructor builder with our hashtable for methodbuilders
32770 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32771 and argument_count is 0 in which case we have a match.
32772 (Binary::ResolveOperator): More null checking and miscellaneous coding
32775 2001-09-17 Ravi Pratap <ravi@ximian.com>
32777 * rootcontext.cs (IsNameSpace): Compare against null.
32779 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32781 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32782 and Unary::Operator.
32784 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32787 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32788 we have overloaded operators.
32789 (Binary::ResolveOperator): Implement the part which does the operator overload
32792 * class.cs (Operator::Emit): Implement.
32793 (TypeContainer::Emit): Emit the operators we have too.
32795 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32796 the case when we have a user-defined operator.
32798 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32800 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32802 2001-09-16 Ravi Pratap <ravi@ximian.com>
32804 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32805 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32806 (Constructor::Emit): Implement.
32807 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32808 if we have no work to do.
32809 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32812 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32813 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32815 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32818 2001-09-15 Ravi Pratap <ravi@ximian.com>
32820 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32822 (Tree::RecordNamespace): Method to do what the name says ;-)
32823 (Tree::Namespaces): Property to get at the namespaces hashtable.
32825 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32828 * rootcontext.cs (IsNamespace): Fixed it :-)
32830 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32832 * class.cs (TypeContainer::FindMembers): Add support for
32834 (MethodCore): New class that encapsulates both the shared aspects
32835 of a Constructor and a Method.
32836 (Method, Constructor): Factored pieces into MethodCore.
32838 * driver.cs: Added --fatal which makes errors throw exceptions.
32839 Load System assembly as well as part of the standard library.
32841 * report.cs: Allow throwing exceptions on errors for debugging.
32843 * modifiers.cs: Do not use `parent', instead use the real type
32844 container to evaluate permission settings.
32846 * class.cs: Put Ravi's patch back in. He is right, and we will
32847 have to cope with the
32849 2001-09-14 Ravi Pratap <ravi@ximian.com>
32851 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32852 FamORAssem, not FamANDAssem.
32854 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32856 * driver.cs: Added --parse option that only parses its input files
32859 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32860 incorrect. IsTopLevel is not used to tell whether an object is
32861 root_types or not (that can be achieved by testing this ==
32862 root_types). But to see if this is a top-level *class* (not
32863 necessarly our "toplevel" container).
32865 2001-09-14 Ravi Pratap <ravi@ximian.com>
32867 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32868 parent instead of a direct call to GetType.
32870 2001-09-14 Ravi Pratap <ravi@ximian.com>
32872 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32873 Modifiers.TypeAttr. This should just be a call to that method.
32875 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32876 object so that we can determine if we are top-level or not.
32878 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32881 * enum.cs (Enum::Define): Ditto.
32883 * modifiers.cs (FieldAttr): Re-write.
32885 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32886 (TypeContainer::HaveStaticConstructor): New property to provide access
32887 to precisely that info.
32889 * modifiers.cs (MethodAttr): Re-write.
32890 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32892 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32893 of top-level types as claimed.
32895 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32897 * expression.cs (MemberLookup): Fruitless attempt to lookup
32898 constructors. Maybe I need to emit default constructors? That
32899 might be it (currently .NET emits this for me automatically).
32900 (Invocation::OverloadResolve): Cope with Arguments == null.
32901 (Invocation::EmitArguments): new function, shared by the new
32902 constructor and us.
32903 (Invocation::Emit): Handle static and instance methods. Emit
32904 proper call instruction for virtual or non-virtual invocations.
32905 (New::Emit): Implement.
32906 (New::Resolve): Implement.
32907 (MemberAccess:Resolve): Implement.
32908 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32909 to track instances.
32910 (FieldExpr::Resolve): Set type.
32912 * support.cs: Handle empty arguments.
32914 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32915 SimpleLookup): Auxiliary routines to help parse a qualifier
32918 Update qualifier_identifier rule.
32920 * codegen.cs: Removed debugging messages.
32922 * class.cs: Make this a global thing, this acts just as a "key" to
32923 objects that we might have around.
32925 (Populate): Only initialize method_builders_to_methods once.
32927 * expression.cs (PropertyExpr): Initialize type from the
32930 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32931 Resolve pattern. Attempt to implicitly convert value to boolean.
32934 * expression.cs: Set the type for the int32/int32 argument case.
32935 (Binary::ResolveOperator): Set the return type to boolean for
32936 comparission operators
32938 * typemanager.cs: Remove debugging print code.
32940 (Invocation::Resolve): resolve type.
32942 * class.cs: Allocate a MemberInfo of the correct size, as the code
32943 elsewhere depends on the test to reflect the correct contents.
32945 (Method::) Keep track of parameters, due to System.Reflection holes
32947 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32950 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32951 of the exact size and return that.
32953 (Class::LookupMethodByBuilder): New function that maps
32954 MethodBuilders to its methods. Required to locate the information
32955 on methods because System.Reflection bit us again.
32957 * support.cs: New file, contains an interface ParameterData and
32958 two implementations: ReflectionParameters and InternalParameters
32959 used to access Parameter information. We will need to grow this
32962 * expression.cs (Invocation::GetParameterData): implement a cache
32963 and a wrapper around the ParameterData creation for methods.
32964 (Invocation::OverloadResolve): Use new code.
32966 2001-09-13 Ravi Pratap <ravi@ximian.com>
32968 * class.cs (TypeContainer::EmitField): Remove and move into
32969 (Field::Define): here and modify accordingly.
32970 (Field.FieldBuilder): New member.
32971 (TypeContainer::Populate): Update accordingly.
32972 (TypeContainer::FindMembers): Implement.
32974 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32976 * statement.cs: (VariableInfo::VariableType): New field to be
32977 initialized with the full type once it is resolved.
32979 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32981 * parameter.cs (GetParameterInfo): Use a type cache to compute
32982 things only once, and to reuse this information
32984 * expression.cs (LocalVariableReference::Emit): Implement.
32985 (OpcodeCast::Emit): fix.
32987 (ParameterReference::Resolve): Implement.
32988 (ParameterReference::Emit): Implement.
32990 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32991 that are expressions need to stay as Expressions.
32993 * typemanager.cs (CSharpName): Returns the C# name of a type if
32996 * expression.cs (Expression::ConvertImplicit): New function that
32997 implements implicit type conversions.
32999 (Expression::ImplicitReferenceConversion): Implements implicit
33000 reference conversions.
33002 (EmptyCast): New type for transparent casts.
33004 (OpcodeCast): New type for casts of types that are performed with
33005 a sequence of bytecodes.
33007 (BoxedCast): New type used for casting value types into reference
33008 types. Emits a box opcode.
33010 (Binary::DoNumericPromotions): Implements numeric promotions of
33011 and computation of the Binary::Type.
33013 (Binary::EmitBranchable): Optimization.
33015 (Binary::Emit): Implement code emission for expressions.
33017 * typemanager.cs (TypeManager): Added two new core types: sbyte
33020 2001-09-12 Ravi Pratap <ravi@ximian.com>
33022 * class.cs (TypeContainer::FindMembers): Method which does exactly
33023 what Type.FindMembers does, only we don't have to use reflection. No
33024 implementation yet.
33026 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
33027 typecontainer objects as we need to get at them.
33028 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
33030 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
33031 typecontainer object.
33033 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
33034 of just a Report object.
33036 2001-09-11 Ravi Pratap <ravi@ximian.com>
33038 * class.cs (Event::Define): Go back to using the prefixes "add_" and
33040 (TypeContainer::Populate): Now define the delegates of the type too.
33041 (TypeContainer.Delegates): Property to access the list of delegates defined
33044 * delegates.cs (Delegate::Define): Implement partially.
33046 * modifiers.cs (TypeAttr): Handle more flags.
33048 2001-09-11 Ravi Pratap <ravi@ximian.com>
33050 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
33052 (Operator::Define): Re-write logic to get types by using the LookupType method
33053 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
33054 (Indexer::Define): Ditto.
33055 (Event::Define): Ditto.
33056 (Property::Define): Ditto.
33058 2001-09-10 Ravi Pratap <ravi@ximian.com>
33060 * class.cs (TypeContainer::Populate): Now define operators too.
33061 (TypeContainer.Operators): New property to access the list of operators
33063 (Operator.OperatorMethodBuilder): New member to hold the method builder
33064 for the operator we are defining.
33065 (Operator::Define): Implement.
33067 2001-09-10 Ravi Pratap <ravi@ximian.com>
33069 * class.cs (Event::Define): Make the prefixes of the accessor methods
33070 addOn_ and removeOn_
33072 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
33073 of the location being passed in too. Ideally, this should go later since all
33074 error reporting should be done through the Report object.
33076 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
33077 (Populate): Iterate thru the indexers we have and define them too.
33078 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
33079 for the get and set accessors.
33080 (Indexer::Define): Implement.
33082 2001-09-09 Miguel de Icaza <miguel@ximian.com>
33084 * expression.cs (Binary::Resolve): Beginning of it. I scratched
33085 my previous implementation, did not work.
33087 * typemanager.cs: Add a couple of missing types (the longs).
33089 * literal.cs: Use TypeManager.bool_type instead of getting it.
33091 * expression.cs (EventExpr): New kind of expressions.
33092 (Expressio::ExprClassFromMemberInfo): finish
33094 2001-09-08 Miguel de Icaza <miguel@ximian.com>
33096 * assign.cs: Emit stores to static fields differently.
33098 2001-09-08 Ravi Pratap <ravi@ximian.com>
33100 * Merge in changes and adjust code to tackle conflicts. Backed out my
33101 code in Assign::Resolve ;-)
33103 2001-09-08 Ravi Pratap <ravi@ximian.com>
33105 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
33106 instead Report.Error and also pass in the location.
33107 (CSharpParser::Lexer): New readonly property to return the reference
33108 to the Tokenizer object.
33109 (declare_local_variables): Use Report.Error with location instead of plain
33113 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
33114 (Operator.CheckBinaryOperator): Ditto.
33116 * cs-parser.jay (operator_declarator): Update accordingly.
33118 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
33119 (CheckBinaryOperator): Same here.
33121 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
33122 on the name without any prefixes of namespace names etc. This is because we
33123 already might have something already fully qualified like
33124 'System.Console.WriteLine'
33126 * assign.cs (Resolve): Begin implementation. Stuck ;-)
33128 2001-09-07 Ravi Pratap <ravi@ximian.com>
33130 * cs-tokenizer.cs (location): Return a string which also contains
33133 * expression.cs (ElementAccess): New class for expressions of the
33134 type 'element access.'
33135 (BaseAccess): New class for expressions of the type 'base access.'
33136 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
33139 * cs-parser.jay (element_access): Implement action.
33140 (base_access): Implement actions.
33141 (checked_expression, unchecked_expression): Implement.
33143 * cs-parser.jay (local_variable_type): Correct and implement.
33144 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
33146 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
33148 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
33149 name and the specifiers.
33151 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
33153 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
33154 making them all public ;-)
33156 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
33159 2001-09-07 Miguel de Icaza <miguel@ximian.com>
33161 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
33163 (FieldExpr, PropertyExprs): New resolved expressions.
33164 (SimpleName::MemberStaticCheck): Perform static checks for access
33165 to non-static fields on static methods. Maybe this should be
33166 generalized for MemberAccesses.
33167 (SimpleName::ResolveSimpleName): More work on simple name
33170 * cs-parser.jay (primary_expression/qualified_identifier): track
33171 the parameter index.
33173 * codegen.cs (CodeGen::Save): Catch save exception, report error.
33174 (EmitContext::EmitBoolExpression): Chain to expression generation
33175 instead of temporary hack.
33176 (::EmitStatementExpression): Put generic expression code generation.
33178 * assign.cs (Assign::Emit): Implement variable assignments to
33179 local variables, parameters and fields.
33181 2001-09-06 Miguel de Icaza <miguel@ximian.com>
33183 * statement.cs (Block::GetVariableInfo): New method, returns the
33184 VariableInfo for a variable name in a block.
33185 (Block::GetVariableType): Implement in terms of GetVariableInfo
33187 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
33188 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
33190 2001-09-06 Ravi Pratap <ravi@ximian.com>
33192 * cs-parser.jay (operator_declaration): Continue on my quest : update
33193 to take attributes argument.
33194 (event_declaration): Ditto.
33195 (enum_declaration): Ditto.
33196 (indexer_declaration): Ditto.
33198 * class.cs (Operator::Operator): Update constructor accordingly.
33199 (Event::Event): Ditto.
33201 * delegate.cs (Delegate::Delegate): Same here.
33203 * enum.cs (Enum::Enum): Same here.
33205 2001-09-05 Ravi Pratap <ravi@ximian.com>
33207 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
33209 * ../tests/cs0658.cs : New file to demonstrate error 0658.
33211 * attribute.cs (Attributes): New class to encapsulate all attributes which were
33212 being passed around as an arraylist.
33213 (Attributes::AddAttribute): Method to add attribute sections.
33215 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
33216 (struct_declaration): Update accordingly.
33217 (constant_declaration): Update.
33218 (field_declaration): Update.
33219 (method_header): Update.
33220 (fixed_parameter): Update.
33221 (parameter_array): Ditto.
33222 (property_declaration): Ditto.
33223 (destructor_declaration): Ditto.
33225 * class.cs (Struct::Struct): Update constructors accordingly.
33226 (Class::Class): Ditto.
33227 (Field::Field): Ditto.
33228 (Method::Method): Ditto.
33229 (Property::Property): Ditto.
33230 (TypeContainer::OptAttribute): update property's return type.
33232 * interface.cs (Interface.opt_attributes): New member.
33233 (Interface::Interface): Update to take the extra Attributes argument.
33235 * parameter.cs (Parameter::Parameter): Ditto.
33237 * constant.cs (Constant::Constant): Ditto.
33239 * interface.cs (InterfaceMemberBase): New OptAttributes field.
33240 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
33241 the attributes as a parameter.
33242 (InterfaceProperty): Update constructor call.
33243 (InterfaceEvent): Ditto.
33244 (InterfaceMethod): Ditto.
33245 (InterfaceIndexer): Ditto.
33247 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
33248 pass the attributes too.
33249 (interface_event_declaration): Ditto.
33250 (interface_property_declaration): Ditto.
33251 (interface_method_declaration): Ditto.
33252 (interface_declaration): Ditto.
33254 2001-09-05 Miguel de Icaza <miguel@ximian.com>
33256 * class.cs (Method::Define): Track the "static Main" definition to
33257 create an entry point.
33259 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
33260 EntryPoint if we find it.
33262 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
33263 (EmitContext::ig): Make this variable public.
33265 * driver.cs: Make the default output file be the first file name
33266 with the .exe extension.
33268 Detect empty compilations
33270 Handle various kinds of output targets. Handle --target and
33271 rename -t to --dumper.
33273 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
33274 methods inherited from Expression return now an Expression. This
33275 will is used during the tree rewriting as we resolve them during
33278 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
33279 the spec. Missing entirely is the information about
33280 accessability of elements of it.
33282 (Expression::ExprClassFromMemberInfo): New constructor for
33283 Expressions that creates a fully initialized Expression based on
33284 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
33287 (Invocation::Resolve): Begin implementing resolution of invocations.
33289 * literal.cs (StringLiteral): Implement Emit.
33291 2001-09-05 Ravi Pratap <ravi@ximian.com>
33293 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
33296 2001-09-04 Ravi Pratap <ravi@ximian.com>
33298 * cs-parser.jay (attribute_arguments): Implement actions.
33299 (attribute): Fix bug in production. Implement action.
33300 (attribute_list): Implement.
33301 (attribute_target): Implement.
33302 (attribute_target_specifier, opt_target_specifier): Implement
33303 (CheckAttributeTarget): New method to check if the attribute target
33305 (attribute_section): Implement.
33306 (opt_attributes): Implement.
33308 * attribute.cs : New file to handle attributes.
33309 (Attribute): Class to hold attribute info.
33311 * cs-parser.jay (opt_attribute_target_specifier): Remove production
33312 (attribute_section): Modify production to use 2 different rules to
33313 achieve the same thing. 1 s/r conflict down !
33314 Clean out commented, useless, non-reducing dimension_separator rules.
33316 * class.cs (TypeContainer.attributes): New member to hold list
33317 of attributes for a type.
33318 (Struct::Struct): Modify to take one more argument, the attribute list.
33319 (Class::Class): Ditto.
33320 (Field::Field): Ditto.
33321 (Method::Method): Ditto.
33322 (Property::Property): Ditto.
33324 * cs-parser.jay (struct_declaration): Update constructor call to
33325 pass in the attributes too.
33326 (class_declaration): Ditto.
33327 (constant_declaration): Ditto.
33328 (field_declaration): Ditto.
33329 (method_header): Ditto.
33330 (fixed_parameter): Ditto.
33331 (parameter_array): Ditto.
33332 (property_declaration): Ditto.
33334 * constant.cs (Constant::Constant): Update constructor similarly.
33335 Use System.Collections.
33337 * parameter.cs (Parameter::Parameter): Update as above.
33339 2001-09-02 Ravi Pratap <ravi@ximian.com>
33341 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33342 (TypeContainer.delegates): New member to hold list of delegates.
33344 * cs-parser.jay (delegate_declaration): Implement the action correctly
33345 this time as I seem to be on crack ;-)
33347 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33349 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33350 tell whether an identifier represents a namespace.
33352 * expression.cs (NamespaceExpr): A namespace expression, used only
33353 temporarly during expression resolution.
33354 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33355 utility functions to resolve names on expressions.
33357 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33359 * codegen.cs: Add hook for StatementExpressions.
33361 * class.cs: Fix inverted test for static flag in methods.
33363 2001-09-02 Ravi Pratap <ravi@ximian.com>
33365 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33366 to make it coincide with MS' number.
33367 (Operator::CheckBinaryOperator): Ditto.
33369 * ../errors/errors.txt : Remove error numbers added earlier.
33371 * ../errors/cs1019.cs : Test case for error # 1019
33373 * ../errros/cs1020.cs : Test case for error # 1020
33375 * cs-parser.jay : Clean out commented cruft.
33376 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33377 used anywhere - non-reducing rule.
33378 (namespace_declarations): Non-reducing rule - comment out.
33380 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33381 with TypeContainer::AddEnum.
33383 * delegate.cs : New file for delegate handling classes.
33384 (Delegate): Class for declaring delegates.
33386 * makefile : Update.
33388 * cs-parser.jay (delegate_declaration): Implement.
33390 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33392 * class.cs (Event::Define): Implement.
33393 (Event.EventBuilder): New member.
33395 * class.cs (TypeContainer::Populate): Update to define all enums and events
33397 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33398 readonly fields for all these cases ?
33400 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33402 * class.cs (Property): Revamp to use the convention of making fields readonly.
33403 Accordingly modify code elsewhere.
33405 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33406 the Define method of the Property class.
33408 * class.cs : Clean up applied patch and update references to variables etc. Fix
33410 (TypeContainer::Populate): Update to define all the properties we have. Also
33411 define all enumerations.
33413 * enum.cs (Define): Implement.
33415 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33417 * cs-parser.jay (overloadable_operator): The semantic value is an
33418 enum of the Operator class.
33419 (operator_declarator): Implement actions.
33420 (operator_declaration): Implement.
33422 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33423 validity of definitions.
33424 (Operator::CheckBinaryOperator): Static method to check for binary operators
33425 (TypeContainer::AddOperator): New method to add an operator to a type.
33427 * cs-parser.jay (indexer_declaration): Added line to actually call the
33428 AddIndexer method so it gets added ;-)
33430 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33431 already taken care of by the MS compiler ?
33433 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33435 * class.cs (Operator): New class for operator declarations.
33436 (Operator::OpType): Enum for the various operators.
33438 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33440 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33441 ostensibly handle this in semantic analysis.
33443 * cs-parser.jay (general_catch_clause): Comment out
33444 (specific_catch_clauses, specific_catch_clause): Ditto.
33445 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33446 (catch_args, opt_catch_args): New productions.
33447 (catch_clause): Rewrite to use the new productions above
33448 (catch_clauses): Modify accordingly.
33449 (opt_catch_clauses): New production to use in try_statement
33450 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33451 and re-write the code in the actions to extract the specific and
33452 general catch clauses by being a little smart ;-)
33454 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33455 Hooray, try and catch statements parse fine !
33457 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33459 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33460 string from the hashtable of variables.
33462 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33463 I end up making that mistake ;-)
33464 (catch_clauses): Fixed gross error which made Key and Value of the
33465 DictionaryEntry the same : $1 !!
33467 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33469 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33471 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33472 when the add and remove accessors are specified.
33474 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33476 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33477 information about indexer_declarator.
33478 (indexer_declarator): Implement actions.
33479 (parsing_indexer): New local boolean used to keep track of whether
33480 we are parsing indexers or properties. This is necessary because
33481 implicit_parameters come into picture even for the get accessor in the
33482 case of an indexer.
33483 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33485 * class.cs (Indexer): New class for indexer declarations.
33486 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33487 (TypeContainer::indexers): New member to hold list of indexers for the
33490 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33492 * cs-parser.jay (add_accessor_declaration): Implement action.
33493 (remove_accessor_declaration): Implement action.
33494 (event_accessors_declaration): Implement
33495 (variable_declarators): swap statements for first rule - trivial.
33497 * class.cs (Event): New class to hold information about event
33499 (TypeContainer::AddEvent): New method to add an event to a type
33500 (TypeContainer::events): New member to hold list of events.
33502 * cs-parser.jay (event_declaration): Implement actions.
33504 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33506 * cs-parser.jay (dim_separators): Implement. Make it a string
33507 concatenating all the commas together, just as they appear.
33508 (opt_dim_separators): Modify accordingly
33509 (rank_specifiers): Update accordingly. Basically do the same
33510 thing - instead, collect the brackets here.
33511 (opt_rank_sepcifiers): Modify accordingly.
33512 (array_type): Modify to actually return the complete type string
33513 instead of ignoring the rank_specifiers.
33514 (expression_list): Implement to collect the expressions
33515 (variable_initializer): Implement. We make it a list of expressions
33516 essentially so that we can handle the array_initializer case neatly too.
33517 (variable_initializer_list): Implement.
33518 (array_initializer): Make it a list of variable_initializers
33519 (opt_array_initializer): Modify accordingly.
33521 * expression.cs (New::NType): Add enumeration to help us
33522 keep track of whether we have an object/delegate creation
33523 or an array creation.
33524 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33525 members to hold data about array creation.
33526 (New:New): Modify to update NewType
33527 (New:New): New Overloaded contructor for the array creation
33530 * cs-parser.jay (array_creation_expression): Implement to call
33531 the overloaded New constructor.
33533 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33535 * class.cs (TypeContainer::Constructors): Return member
33536 constructors instead of returning null.
33538 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33540 * typemanager.cs (InitCoreTypes): Initialize the various core
33541 types after we have populated the type manager with the user
33542 defined types (this distinction will be important later while
33543 compiling corlib.dll)
33545 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33546 on Expression Classification. Now all expressions have a method
33547 `Resolve' and a method `Emit'.
33549 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33550 generation from working. Also add some temporary debugging
33553 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33555 * codegen.cs: Lots of code generation pieces. This is only the
33556 beginning, will continue tomorrow with more touches of polish. We
33557 handle the fundamentals of if, while, do, for, return. Others are
33558 trickier and I need to start working on invocations soon.
33560 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33563 * codegen.cs (EmitContext): New struct, used during code
33564 emission to keep a context. Most of the code generation will be
33567 * cs-parser.jay: Add embedded blocks to the list of statements of
33568 this block. So code generation proceeds in a top down fashion.
33570 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33572 * statement.cs: Add support for multiple child blocks.
33574 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33576 * codegen.cs (EmitCode): New function, will emit the code for a
33577 Block of code given a TypeContainer and its ILGenerator.
33579 * statement.cs (Block): Standard public readonly optimization.
33580 (Block::Block constructors): Link children.
33581 (Block::Child): Child Linker.
33582 (Block::EmitVariables): Emits IL variable declarations.
33584 * class.cs: Drop support for MethodGroups here, delay until
33586 (Method::): Applied the same simplification that I did before, and
33587 move from Properties to public readonly fields.
33588 (Method::ParameterTypes): Returns the parameter types for the
33589 function, and implements a cache that will be useful later when I
33590 do error checking and the semantic analysis on the methods is
33592 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33593 and made a method, optional argument tells whether this is a class
33594 or a structure to apply the `has-this' bit.
33595 (Method::GetCallingConvention): Implement, returns the calling
33597 (Method::Define): Defines the type, a second pass is performed
33598 later to populate the methods.
33600 (Constructor::ParameterTypes): implement a cache similar to the
33601 one on Method::ParameterTypes, useful later when we do semantic
33604 (TypeContainer::EmitMethod): New method. Emits methods.
33606 * expression.cs: Removed MethodGroup class from here.
33608 * parameter.cs (Parameters::GetCallingConvention): new method.
33610 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33612 * class.cs (TypeContainer::Populate): Drop RootContext from the
33615 (Constructor::CallingConvention): Returns the calling convention.
33616 (Constructor::ParameterTypes): Returns the constructor parameter
33619 (TypeContainer::AddConstructor): Keep track of default constructor
33620 and the default static constructor.
33622 (Constructor::) Another class that starts using `public readonly'
33623 instead of properties.
33625 (Constructor::IsDefault): Whether this is a default constructor.
33627 (Field::) use readonly public fields instead of properties also.
33629 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33630 track of static constructors; If none is used, turn on
33631 BeforeFieldInit in the TypeAttributes.
33633 * cs-parser.jay (opt_argument_list): now the return can be null
33634 for the cases where there are no arguments.
33636 (constructor_declarator): If there is no implicit `base' or
33637 `this', then invoke the default parent constructor.
33639 * modifiers.cs (MethodAttr): New static function maps a set of
33640 modifiers flags into a MethodAttributes enum
33641 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33642 MethodAttr, TypeAttr to represent the various mappings where the
33643 modifiers are used.
33644 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33646 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33648 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33651 * interface.cs (PopulateIndexer): Implemented the code generator
33652 for interface indexers.
33654 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33656 * interface.cs (InterfaceMemberBase): Now we track the new status
33659 (PopulateProperty): Implement property population. Woohoo! Got
33660 Methods and Properties going today.
33662 Removed all the properties for interfaces, and replaced them with
33663 `public readonly' fields.
33665 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33667 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33668 initialize their hashtables/arraylists only when they are needed
33669 instead of doing this always.
33671 * parameter.cs: Handle refs and out parameters.
33673 * cs-parser.jay: Use an ArrayList to construct the arguments
33674 instead of the ParameterCollection, and then cast that to a
33677 * parameter.cs: Drop the use of ParameterCollection and use
33678 instead arrays of Parameters.
33680 (GetParameterInfo): Use the Type, not the Name when resolving
33683 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33685 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33686 and instead use public readonly fields.
33688 * class.cs: Put back walking code for type containers.
33690 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33692 * class.cs (MakeConstant): Code to define constants.
33694 * rootcontext.cs (LookupType): New function. Used to locate types
33697 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33699 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33700 this System.Reflection code is. Kudos to Microsoft
33702 * typemanager.cs: Implement a type cache and avoid loading all
33703 types at boot time. Wrap in LookupType the internals. This made
33704 the compiler so much faster. Wow. I rule!
33706 * driver.cs: Make sure we always load mscorlib first (for
33707 debugging purposes, nothing really important).
33709 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33710 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33712 * rootcontext.cs: Lookup types on their namespace; Lookup types
33713 on namespaces that have been imported using the `using' keyword.
33715 * class.cs (TypeContainer::TypeAttr): Virtualize.
33716 (Class::TypeAttr): Return attributes suitable for this bad boy.
33717 (Struct::TypeAttr): ditto.
33718 Handle nested classes.
33719 (TypeContainer::) Remove all the type visiting code, it is now
33720 replaced with the rootcontext.cs code
33722 * rootcontext.cs (GetClassBases): Added support for structs.
33724 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33726 * interface.cs, statement.cs, class.cs, parameter.cs,
33727 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33728 Drop use of TypeRefs, and use strings instead.
33730 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33734 * class.cs (Struct::Struct): set the SEALED flags after
33735 checking the modifiers.
33736 (TypeContainer::TypeAttr): new property, returns the
33737 TypeAttributes for a class.
33739 * cs-parser.jay (type_list): Oops, list production was creating a
33740 new list of base types.
33742 * rootcontext.cs (StdLib): New property.
33743 (GetInterfaceTypeByName): returns an interface by type name, and
33744 encapsulates error handling here.
33745 (GetInterfaces): simplified.
33746 (ResolveTree): Encapsulated all the tree resolution here.
33747 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33750 * driver.cs: Add support for --nostdlib, to avoid loading the
33751 default assemblies.
33752 (Main): Do not put tree resolution here.
33754 * rootcontext.cs: Beginning of the class resolution.
33756 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33758 * rootcontext.cs: Provide better error reporting.
33760 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33762 * rootcontext.cs (CreateInterface): Handle the case where there
33763 are no parent interfaces.
33765 (CloseTypes): Routine to flush types at the end.
33766 (CreateInterface): Track types.
33767 (GetInterfaces): Returns an array of Types from the list of
33768 defined interfaces.
33770 * typemanager.c (AddUserType): Mechanism to track user types (puts
33771 the type on the global type hash, and allows us to close it at the
33774 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33776 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33777 RecordInterface instead.
33779 * cs-parser.jay: Updated to reflect changes above.
33781 * decl.cs (Definition): Keep track of the TypeBuilder type that
33782 represents this type here. Not sure we will use it in the long
33783 run, but wont hurt for now.
33785 * driver.cs: Smaller changes to accomodate the new code.
33787 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33790 * rootcontext.cs (CreateInterface): New method, used to create
33791 the System.TypeBuilder type for interfaces.
33792 (ResolveInterfaces): new entry point to resolve the interface
33794 (CodeGen): Property, used to keep track of the code generator.
33796 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33798 * cs-parser.jay: Add a second production for delegate_declaration
33801 (enum_body): Put an opt_comma here instead of putting it on
33802 enum_body or enum_member_declarations so we can handle trailing
33803 commas on enumeration members. Gets rid of a shift/reduce.
33805 (type_list): Need a COMMA in the middle.
33807 (indexer_declaration): Tell tokenizer to recognize get/set
33809 * Remove old targets.
33811 * Re-add the parser target.
33813 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33815 * cs-parser.jay: Add precendence rules for a number of operators
33816 ot reduce the number of shift/reduce conflicts in the grammar.
33818 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33820 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33823 Get rid of old crufty code.
33825 * rootcontext.cs: Use this to keep track of the parsed
33826 representation and the defined types available to the program.
33828 * gen-treedump.cs: adjust for new convention.
33830 * type.cs: Split out the type manager, and the assembly builder
33833 * typemanager.cs: the type manager will live here now.
33835 * cil-codegen.cs: And the code generator here.
33837 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33839 * makefile: Fixed up for easy making.
33841 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33843 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33846 (unary_expression): Expand pre_increment_expression and
33847 post_decrement_expression to reduce a shift/reduce.
33849 2001-07-11 Simon Cozens
33851 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33853 Improve allow_keyword_as_indent name.
33855 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33857 * Adjustments for Beta2.
33859 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33861 * decl.cs: Added `Define' abstract method.
33862 (InTransit): new property, used to catch recursive definitions.
33864 * interface.cs: Implement `Define'.
33866 * modifiers.cs: Map Modifiers.constants to
33867 System.Reflection.TypeAttribute flags.
33869 * class.cs: Keep track of types and user-defined types.
33870 (BuilderInit): New method for creating an assembly
33871 (ResolveType): New function to launch the resolution process, only
33872 used by interfaces for now.
33874 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33875 that are inserted into the name space.
33877 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33879 * ARGH. I have screwed up my tree so many times due to the use of
33880 rsync rather than using CVS. Going to fix this at once.
33882 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33885 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33887 * Experiment successful: Use System.Type rather that our own
33890 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33892 * cs-parser.jay: Removed nsAliases from here.
33894 Use new namespaces, handle `using XXX;'
33896 * namespace.cs: Reimplemented namespace handling, use a recursive
33897 definition of the class. Now we can keep track of using clauses
33898 and catch invalid using clauses.
33900 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33902 * gen-treedump.cs: Adapted for all the renaming.
33904 * expression.cs (Expression): this class now has a Type property
33905 which returns an expression Type.
33907 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33908 `Type', as this has a different meaning now in the base
33910 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33912 * interface.cs, class.cs: Removed from all the sources the
33913 references to signature computation, as we can not do method
33914 signature computation during the parsing time, as we are not
33915 trying to solve at that point distinguishing:
33919 void a (NS.Blah x) {}
33922 Which depending on the context might be valid or not, as we do not
33923 know if Blah is the same thing as NS.Blah at that point.
33925 * Redid everything so the code uses TypeRefs now instead of
33926 Types. TypeRefs are just temporary type placeholders, that need
33927 to be resolved. They initially have a pointer to a string and the
33928 current scope in which they are used. This is used later by the
33929 compiler to resolve the reference to an actual Type.
33931 * DeclSpace is no longer a CIR.Type, and neither are
33932 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33933 are all DeclSpaces, but no Types.
33935 * type.cs (TypeRefManager): This implements the TypeRef manager,
33936 which keeps track of all the types that need to be resolved after
33937 the parsing has finished.
33939 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33941 * ARGH. We are going to have to store `foreach' as a class rather
33942 than resolving it, as we need to verify error 1579 after name
33943 resolution. *OR* we could keep a flag that says `This request to
33944 IEnumerator comes from a foreach statement' which we can then use
33945 to generate the error.
33947 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33949 * class.cs (TypeContainer.AddMethod): we now add methods to the
33950 MethodGroup instead of the method hashtable.
33952 * expression.cs: Add MethodGroup abstraction, which gets us one
33953 step closer to the specification in the way we handle method
33956 * cs-parser.jay (primary_expression): qualified_identifier now
33957 tried to match up an identifier to a local variable reference or
33958 to a parameter reference.
33960 current_local_parameters is now a parser global variable that
33961 points to the current parameters for the block, used during name
33964 (property_declaration): Now creates an implicit `value' argument to
33967 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33969 * parameter.cs: Do not use `param' arguments as part of the
33970 signature, per the spec.
33972 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33974 * decl.cs: Base class for classes, structs and interfaces. This
33975 is the "Declaration Space"
33977 * cs-parser.jay: Use CheckDef for checking declaration errors
33978 instead of having one on each function.
33980 * class.cs: Factor out some code for handling error handling in
33981 accordance to the "Declarations" section in the "Basic Concepts"
33982 chapter in the ECMA C# spec.
33984 * interface.cs: Make all interface member classes derive from
33985 InterfaceMemberBase.
33987 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33989 * Many things: all interfaces are parsed and generated in
33990 gen-treedump. Support for member variables, constructors,
33991 destructors, properties, constants is there.
33993 Beginning of the IL backend, but very little done, just there for
33996 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33998 * cs-parser.jay: Fix labeled statement.
34000 * cs-tokenizer.cs (escape): Escape " and ' always.
34001 ref_line, ref_name: keep track of the line/filename as instructed
34002 by #line by the compiler.
34005 2001-04-27 Miguel de Icaza <miguel@ximian.com>
34007 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
34008 to match the values in System.CodeDOM.
34010 Divid renamed to Divide.
34012 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
34014 (Statements.set): remove.
34016 * System.CodeDOM/CodeCatchClause.cs: always have a valid
34019 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
34020 falseStatements always have valid values.
34022 * cs-parser.jay: Use System.CodeDOM now.